Timeline



May 19, 2012:

9:43 PM Changeset in webkit [117705] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix. Don't stop the build if a build system update check fails.

6:55 PM Changeset in webkit [117704] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed build fix. Remove a couple files wx doesn't use from the build.

5:19 PM Changeset in webkit [117703] by aestes@apple.com
  • 5 edits in trunk/Source/WebKit2

Use USE_APPKIT and USE_SECURITY_FRAMEWORK in a few more places
https://bugs.webkit.org/show_bug.cgi?id=86951

Reviewed by Dan Bernstein.

  • UIProcess/WebProcessProxy.messages.in: Change #if PLATFORM(MAC) to

the more specific #if USE(SECURITY_FRAMEWORK).

  • UIProcess/mac/WebPageProxyMac.mm: Wrap some uses of AppKit classes

with #if USE(APPKIT).

  • UIProcess/mac/WebPopupMenuProxyMac.h: Ditto.
  • UIProcess/mac/WebPopupMenuProxyMac.mm: Ditto.
4:52 PM FeatureFlags edited by rakuco@webkit.org
ENABLE(CSS_GRID_LAYOUT) has been removed in r117613. (diff)
4:51 PM AddingFeatures edited by rakuco@webkit.org
build-webkit does not contain the feature list anymore, it has been … (diff)
4:49 PM AddingFeatures edited by rakuco@webkit.org
Add the related CMake file to the list (diff)
4:36 PM Changeset in webkit [117702] by jsbell@chromium.org
  • 108 edits in trunk/LayoutTests

IndexedDB layout tests should make better use of test library functions
https://bugs.webkit.org/show_bug.cgi?id=86932

Reviewed by Ojan Vafai.

Use functions like shouldBeEqualToString, shouldBeNull, evalAndExpectException
and so forth where possible.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/createObjectStore-null-name-expected.txt:
  • storage/indexeddb/cursor-added-bug-expected.txt:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue-validity-expected.txt:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-inconsistency-expected.txt:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-key-order-expected.txt:
  • storage/indexeddb/cursor-primary-key-order-expected.txt:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/factory-basics-expected.txt:
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/factory-deletedatabase-expected.txt:
  • storage/indexeddb/get-keyrange-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-multientry-expected.txt:
  • storage/indexeddb/index-population-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/legacy-constants-expected.txt:
  • storage/indexeddb/mutating-cursor-expected.txt:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-clear-expected.txt:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/opencursor-key-expected.txt:
  • storage/indexeddb/prefetch-bugfix-108071-expected.txt:
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/resources/basics.js:

(test):
(openCallback):

  • storage/indexeddb/resources/create-object-store-options.js:

(setVersionComplete):

  • storage/indexeddb/resources/createObjectStore-null-name.js:

(createAndPopulateObjectStore):

  • storage/indexeddb/resources/cursor-added-bug.js:

(setVersionSuccess):

  • storage/indexeddb/resources/cursor-continue-validity.js:

(deleteExisting):

  • storage/indexeddb/resources/cursor-continue.js:

(deleteExisting):

  • storage/indexeddb/resources/cursor-delete.js:

(setVersionSuccess):

  • storage/indexeddb/resources/cursor-inconsistency.js:

(setVersionSuccess):
(checkCursor):

  • storage/indexeddb/resources/cursor-index-delete.js:

(setVersionSuccess):

  • storage/indexeddb/resources/cursor-key-order.js:

(checkStore.curreq.onsuccess.getreq.onsuccess):
(checkStore.curreq.onsuccess):
(checkStore):

  • storage/indexeddb/resources/cursor-primary-key-order.js:

(checkStore.cursorRequest.onsuccess):
(checkStore):

  • storage/indexeddb/resources/cursor-skip-deleted.js:

(setVersionSuccess):

  • storage/indexeddb/resources/cursor-update.js:

(setVersionSuccess):
(basicUpdateCursor.request.onsuccess):
(basicUpdateCursor):
(autoIncrementUpdateCursor.request.onsuccess):
(autoIncrementUpdateCursor):
(keyPathUpdateCursor.request.onsuccess):
(keyPathUpdateCursor):
(keyCursor):

  • storage/indexeddb/resources/data-corruption.js:

(setVersionSuccess):
(doCheck):

  • storage/indexeddb/resources/database-basics.js:

(setVersionSuccess):
(createAnotherObjectStore):

  • storage/indexeddb/resources/database-quota.js:

(setVersionSuccess):

  • storage/indexeddb/resources/duplicates.js:

(deleteExisting):
(cursor1Continue):
(cursor1Continue2):
(openObjectCursor):
(cursor2Continue):
(cursor2Continue2):
(last):

  • storage/indexeddb/resources/error-causes-abort-by-default.js:

(deleteExisting):

  • storage/indexeddb/resources/exception-in-event-aborts.js:

(deleteExisting):

  • storage/indexeddb/resources/factory-basics.js:

(test):

  • storage/indexeddb/resources/factory-cmp.js:

(test):
(testValidKeys):
(testIdenticalKeys):

  • storage/indexeddb/resources/factory-deletedatabase.js:

(deleteExisting):

  • storage/indexeddb/resources/get-keyrange.js:

(deleteExisting):

  • storage/indexeddb/resources/index-basics.js:

(deleteExisting):
(cursor1Continue):
(cursor1Continue2):
(cursor1Continue3):
(openObjectCursor):
(cursor2Continue):
(cursor2Continue2):
(cursor2Continue3):
(last):

  • storage/indexeddb/resources/index-count.js:

(prepareDatabase):
(verifyCount.request.onsuccess):
(verifyCount):
(verifyCountWithRange.nextTest.request.onsuccess):
(verifyCountWithRange.nextTest):
(verifyCountWithRange):
(verifyCountWithKey.nextTest.request.onsuccess):
(verifyCountWithKey.nextTest):
(verifyCountWithKey):

  • storage/indexeddb/resources/index-cursor.js:

(deleteExisting):

  • storage/indexeddb/resources/index-multientry.js:

(prepareDatabase):
(verifyIndexes.request.onsuccess):
(verifyIndexes):

  • storage/indexeddb/resources/index-population.js:

(setVersion2Abort):

  • storage/indexeddb/resources/index-unique.js:

(deleteExisting):
(cursorSuccess):
(keyCursorSuccess):

  • storage/indexeddb/resources/key-type-array.js:

(test):

  • storage/indexeddb/resources/keyrange.js:

(test):

  • storage/indexeddb/resources/legacy-constants.js:

(populateStore):
(checkNext.request.onsuccess):
(checkNext):
(checkNextNoDuplicate.request.onsuccess):
(checkNextNoDuplicate):
(checkPrev.request.onsuccess):
(checkPrev):
(checkPrevNoDuplicate.request.onsuccess):
(checkPrevNoDuplicate):

  • storage/indexeddb/resources/mutating-cursor.js:

(setVersionSuccess):

  • storage/indexeddb/resources/objectstore-autoincrement.js:

(setVersionSuccess):
(testLongKeyPath.cursorRequest.onsuccess):
(testLongKeyPath):

  • storage/indexeddb/resources/objectstore-basics.js:

(setVersionSuccess):
(createIndex):
(createAnotherIndex):
(addDateSuccess):
(addAgainFailure):

  • storage/indexeddb/resources/objectstore-clear.js:

(deleteExisting):

  • storage/indexeddb/resources/objectstore-count.js:

(prepareDatabase):
(verifyCount.request.onsuccess):
(verifyCount):
(verifyCountWithRange.nextTest.request.onsuccess):
(verifyCountWithRange.nextTest):
(verifyCountWithRange):
(verifyCountWithKey.nextTest.request.onsuccess):
(verifyCountWithKey.nextTest):
(verifyCountWithKey):

  • storage/indexeddb/resources/objectstore-cursor.js:

(deleteExisting):

  • storage/indexeddb/resources/objectstore-removeobjectstore.js:

(deleteExisting):
(deleteObjectStore):

  • storage/indexeddb/resources/open-cursor.js:

(cursorWithKeySuccess):
(cursorSuccess):
(setVersionSuccess):

  • storage/indexeddb/resources/opencursor-key.js:

(testObjectStore.request.onsuccess):
(testObjectStore):
(testIndex.request.onsuccess):
(testIndex):
(testIndexWithKey.request.onsuccess):
(testIndexWithKey):

  • storage/indexeddb/resources/prefetch-bugfix-108071.js:

(setVersionSuccess):

  • storage/indexeddb/resources/queued-commands.js:
  • storage/indexeddb/resources/request-event-propagation.js:

(deleteExisting):

  • storage/indexeddb/resources/setVersion-null.js:

(postSetVersion):

  • storage/indexeddb/resources/shared.js:

(evalAndExpectExceptionClass):

  • storage/indexeddb/resources/transaction-abort.js:

(deleteExisting):

  • storage/indexeddb/resources/transaction-and-objectstore-calls.js:

(created):
(afterComplete):

  • storage/indexeddb/resources/transaction-basics.js:

(addRemoveIDBObjects):
(addRemoveAddIDBObjects):
(addIDBObjects):
(addIDBObjectsAndCommit):
(removeIDBObjects):
(setVersionSuccess):
(testDOMStringList):

  • storage/indexeddb/resources/transaction-event-propagation.js:

(deleteExisting):

  • storage/indexeddb/resources/transaction-rollback.js:

(addSuccess):
(getSuccess):

  • storage/indexeddb/resources/two-version-changes.js:

(test):

  • storage/indexeddb/resources/values-odd-types.js:

(openACursor.request.onsuccess):
(openACursor):

  • storage/indexeddb/setVersion-null-expected.txt:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-rollback-expected.txt:
  • storage/indexeddb/two-version-changes-expected.txt:
  • storage/indexeddb/values-odd-types-expected.txt:
4:03 PM Changeset in webkit [117701] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Remove a test that does not exist anymore from the skipped list, and
improve the comment for the other test at the block which relies on v8
stuff.

  • platform/efl/Skipped:
3:58 PM Changeset in webkit [117700] by aestes@apple.com
  • 8 edits in trunk/Source/WebKit2

2012-05-19 Andy Estes <aestes@apple.com>

Fix more build errors found when disabling ENABLE_DRAG_SUPPORT

Rubber stamped by Jon Honeycutt.

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/WebPageProxy.cpp: (WebKit):
  • UIProcess/WebPageProxy.h: (WebPageProxy):
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit):
  • WebProcess/WebPage/WebPage.h: (WebPage):
  • WebProcess/WebPage/WebPage.messages.in:
3:51 PM Changeset in webkit [117699] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Move skipped tests which depend on a showModalDialog()
implementation from Skipped to test_expectations.txt to have all
of them grouped together.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
1:52 PM Changeset in webkit [117698] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r108181): corruption after scrolling
https://bugs.webkit.org/show_bug.cgi?id=86934
<rdar://problem/11487337>

Reviewed by Dan Bernstein.

Use the flipped Y coordinate when resetting the scrolled rect.

  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::resetScrolledRect):

1:48 PM Changeset in webkit [117697] by eae@chromium.org
  • 11 edits in trunk/Source/WebCore

Simplify RenderOverflow by using Rects
https://bugs.webkit.org/show_bug.cgi?id=86894

Reviewed by Eric Seidel.

Simplify the RenderOverflow class and the uses of it by storing the
overflow values in rects and using the rects instead of the individual
values where it makes sense.

No new tests, no change in functionality.

  • page/FrameView.cpp:

(WebCore::FrameView::adjustPageHeightDeprecated):
Change to use layoutOverflowRect().maxX() and replace C style casts with
C++ style to comply with style guide.

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalTopLayoutOverflow):
(WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::logicalTopVisualOverflow):
(WebCore::InlineFlowBox::logicalBottomVisualOverflow):
Change methods to use layoutOverflowRect() and visualOverflowRect().

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
Change methods to use visualOverflowRect().

(WebCore::RenderBox::clearLayoutOverflow):
Use setLayoutOverflow instead of resetLayoutOverflow (which has been
removed as it did exactly the same thing as the set method).

  • rendering/RenderBox.h:

(WebCore::RenderBox::maxLayoutOverflow):
(WebCore::RenderBox::logicalLeftLayoutOverflow):
(WebCore::RenderBox::logicalRightLayoutOverflow):
(WebCore::RenderBox::logicalLeftVisualOverflow):
(WebCore::RenderBox::logicalRightVisualOverflow):
Remove minYLayoutOverflow, maxYLayoutOverflow, minXLayoutOverflow and
maxXLayoutOverflow and update the remaining methods to use
layoutOverflowRect().

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):
Change to use layoutOverflowRect().

  • rendering/RenderOverflow.h:

(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::layoutOverflowRect):
(WebCore::RenderOverflow::visualOverflowRect):
(RenderOverflow):
(WebCore::RenderOverflow::setMinYLayoutOverflow):
(WebCore::RenderOverflow::setMaxYLayoutOverflow):
(WebCore::RenderOverflow::setMinXLayoutOverflow):
(WebCore::RenderOverflow::setMaxXLayoutOverflow):
(WebCore::RenderOverflow::setMinYVisualOverflow):
(WebCore::RenderOverflow::setMaxYVisualOverflow):
(WebCore::RenderOverflow::setMinXVisualOverflow):
(WebCore::RenderOverflow::setMaxXVisualOverflow):
(WebCore):
(WebCore::RenderOverflow::move):
(WebCore::RenderOverflow::addLayoutOverflow):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setLayoutOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
Change RenderOverflow to use two rects instead of two sets of four
values. Remove [min|max][Layout|Visual]Overflow getters and change the
layoutOverflowRect and visualOverflowRect methods to return the rects.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):
Change to use visualOverflowRect().

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):
Change to use visualOverflowRect().

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
Change to use visualOverflowRect().

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):
Change to use layoutOverflowRect().

1:41 PM Changeset in webkit [117696] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove bbox caching from SVGPathElement
https://bugs.webkit.org/show_bug.cgi?id=86233

Reviewed by Nikolas Zimmermann.

Remove caching of path bounding box, since SVGLocatable::getBBox is not used much at all.
This saves 200k of memory for worldcup.svg on 64-bit machine.

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::getBBox):

  • svg/SVGPathElement.h:

(SVGPathElement):

12:29 PM Changeset in webkit [117695] by aestes@apple.com
  • 18 edits in trunk/Source

Fix build errors found when disabling ENABLE_DRAG_SUPPORT
https://bugs.webkit.org/show_bug.cgi?id=86947

Reviewed by Jon Honeycutt.

Source/WebCore:

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseMoveEventToSubframe):

  • platform/mac/ClipboardMac.mm:

(WebCore):

Source/WebKit/mac:

  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm:
  • WebView/WebFrame.mm:
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm:

(-[WebFrameView _setDocumentView:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView acceptsFirstMouse:]):
(-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
(matchesExtensionOrEquivalent):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView moveDragCaretToPoint:]):
(-[WebView removeDragCaret]):

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(createSandboxExtensionsForFileUpload):
(-[WKView performDragOperation:]):

  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):

11:25 AM Changeset in webkit [117694] by commit-queue@webkit.org
  • 7 edits in trunk

The order of CSS properties is wrong in background shorthand
https://bugs.webkit.org/show_bug.cgi?id=86152

Patch by Joe Thomas <joethomas@motorola.com> on 2012-05-19
Reviewed by Ryosuke Niwa.

Corrected the order of properties returned in StylePropertySet::getPropertyValue for background shorthand property to match the specification
http://www.w3.org/TR/css3-background/#background.

Source/WebCore:

  • css/StylePropertyShorthand.cpp:

(WebCore::backgroundShorthand):

LayoutTests:

  • fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
  • fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
  • fast/dom/background-shorthand-csstext-expected.txt:
  • fast/dom/background-shorthand-csstext.html:
11:12 AM Changeset in webkit [117693] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, add test expectations for further tests that
fail intermittently with an image diff due to repainting problems.

  • platform/gtk/test_expectations.txt:
10:01 AM Changeset in webkit [117692] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Plug-in process should only be enabled if Netscape plug-in API is enabled
https://bugs.webkit.org/show_bug.cgi?id=86945

Reviewed by Dan Bernstein.

  • config.h: Only define ENABLE_PLUGIN_PROCESS if ENABLE_NETSCAPE_PLUGIN_API is true.
9:29 AM Changeset in webkit [117691] by commit-queue@webkit.org
  • 1 edit
    14 adds in trunk/LayoutTests

[EFL] More rebaselining needed after r117672
https://bugs.webkit.org/show_bug.cgi?id=86944

Unreviewed EFL gardening. Add missing EFL expectations for several
CSS3 and forms tests.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-19

  • platform/efl/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
  • platform/efl/css3/selectors3/html/css3-modsel-24-expected.txt: Added.
  • platform/efl/css3/selectors3/html/css3-modsel-68-expected.txt: Added.
  • platform/efl/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
  • platform/efl/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
  • platform/efl/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Added.
  • platform/efl/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Added.
  • platform/efl/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
  • platform/efl/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
  • platform/efl/css3/selectors3/xml/css3-modsel-24-expected.txt: Added.
  • platform/efl/css3/selectors3/xml/css3-modsel-68-expected.txt: Added.
  • platform/efl/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
  • platform/efl/fast/forms/input-appearance-bkcolor-expected.txt: Added.
  • platform/efl/fast/forms/textfield-outline-expected.txt: Added.
6:58 AM Changeset in webkit [117690] by commit-queue@webkit.org
  • 152 edits in trunk/LayoutTests

[EFL] Massive rebaselining needed after r117672
https://bugs.webkit.org/show_bug.cgi?id=86940

Unreviewed EFL gardening.

Rebaseline is needed for a lot of tests after r117672.
In many tests, contents in input element are shifted to the start
(left in LTR and right in RTL) by 1px, and widths of input
elements are shrunk by 2px.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-19

  • platform/efl/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/efl/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/efl/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/efl/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/efl/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/efl/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/efl/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/efl/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/efl/fast/css/input-search-padding-expected.png:
  • platform/efl/fast/css/input-search-padding-expected.txt:
  • platform/efl/fast/css/line-height-expected.png:
  • platform/efl/fast/css/line-height-expected.txt:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/efl/fast/css/text-overflow-input-expected.png:
  • platform/efl/fast/css/text-overflow-input-expected.txt:
  • platform/efl/fast/dom/isindex-001-expected.png:
  • platform/efl/fast/dom/isindex-001-expected.txt:
  • platform/efl/fast/dom/isindex-002-expected.png:
  • platform/efl/fast/dom/isindex-002-expected.txt:
  • platform/efl/fast/events/autoscroll-expected.png:
  • platform/efl/fast/events/autoscroll-expected.txt:
  • platform/efl/fast/forms/basic-inputs-expected.png:
  • platform/efl/fast/forms/basic-inputs-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.png:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/control-restrict-line-height-expected.png:
  • platform/efl/fast/forms/control-restrict-line-height-expected.txt:
  • platform/efl/fast/forms/encoding-test-expected.png:
  • platform/efl/fast/forms/encoding-test-expected.txt:
  • platform/efl/fast/forms/fieldset-align-expected.png:
  • platform/efl/fast/forms/fieldset-align-expected.txt:
  • platform/efl/fast/forms/floating-textfield-relayout-expected.png:
  • platform/efl/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/efl/fast/forms/input-align-expected.png:
  • platform/efl/fast/forms/input-align-expected.txt:
  • platform/efl/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/efl/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/efl/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/efl/fast/forms/input-appearance-focus-expected.png:
  • platform/efl/fast/forms/input-appearance-focus-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.png:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/efl/fast/forms/input-appearance-selection-expected.png:
  • platform/efl/fast/forms/input-appearance-selection-expected.txt:
  • platform/efl/fast/forms/input-appearance-visibility-expected.png:
  • platform/efl/fast/forms/input-appearance-visibility-expected.txt:
  • platform/efl/fast/forms/input-appearance-width-expected.png:
  • platform/efl/fast/forms/input-appearance-width-expected.txt:
  • platform/efl/fast/forms/input-disabled-color-expected.png:
  • platform/efl/fast/forms/input-disabled-color-expected.txt:
  • platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/efl/fast/forms/input-field-text-truncated-expected.png:
  • platform/efl/fast/forms/input-field-text-truncated-expected.txt:
  • platform/efl/fast/forms/input-readonly-dimmed-expected.png:
  • platform/efl/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/efl/fast/forms/input-readonly-empty-expected.png:
  • platform/efl/fast/forms/input-readonly-empty-expected.txt:
  • platform/efl/fast/forms/input-spaces-expected.png:
  • platform/efl/fast/forms/input-spaces-expected.txt:
  • platform/efl/fast/forms/input-table-expected.png:
  • platform/efl/fast/forms/input-table-expected.txt:
  • platform/efl/fast/forms/input-text-click-inside-expected.png:
  • platform/efl/fast/forms/input-text-click-inside-expected.txt:
  • platform/efl/fast/forms/input-text-double-click-expected.png:
  • platform/efl/fast/forms/input-text-double-click-expected.txt:
  • platform/efl/fast/forms/input-text-option-delete-expected.png:
  • platform/efl/fast/forms/input-text-option-delete-expected.txt:
  • platform/efl/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/efl/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/efl/fast/forms/input-text-word-wrap-expected.png:
  • platform/efl/fast/forms/input-text-word-wrap-expected.txt:
  • platform/efl/fast/forms/input-type-text-min-width-expected.png:
  • platform/efl/fast/forms/input-type-text-min-width-expected.txt:
  • platform/efl/fast/forms/input-value-expected.png:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/forms/input-width-expected.png:
  • platform/efl/fast/forms/input-width-expected.txt:
  • platform/efl/fast/forms/minWidthPercent-expected.png:
  • platform/efl/fast/forms/minWidthPercent-expected.txt:
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/efl/fast/forms/search-rtl-expected.png:
  • platform/efl/fast/forms/search-rtl-expected.txt:
  • platform/efl/fast/forms/search-styled-expected.png:
  • platform/efl/fast/forms/search-styled-expected.txt:
  • platform/efl/fast/forms/search-vertical-alignment-expected.png:
  • platform/efl/fast/forms/search-vertical-alignment-expected.txt:
  • platform/efl/fast/forms/searchfield-heights-expected.png:
  • platform/efl/fast/forms/searchfield-heights-expected.txt:
  • platform/efl/fast/forms/tabbing-input-iframe-expected.png:
  • platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/efl/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/efl/fast/forms/text-style-color-expected.png:
  • platform/efl/fast/forms/text-style-color-expected.txt:
  • platform/efl/fast/forms/textfield-focus-ring-expected.png:
  • platform/efl/fast/forms/textfield-focus-ring-expected.txt:
  • platform/efl/fast/forms/textfield-outline-expected.png:
  • platform/efl/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/efl/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/efl/fast/frames/take-focus-from-iframe-expected.png:
  • platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/efl/fast/html/details-no-summary4-expected.png:
  • platform/efl/fast/html/details-no-summary4-expected.txt:
  • platform/efl/fast/html/details-open-javascript-expected.png:
  • platform/efl/fast/html/details-open-javascript-expected.txt:
  • platform/efl/fast/html/details-open2-expected.png:
  • platform/efl/fast/html/details-open2-expected.txt:
  • platform/efl/fast/html/details-open4-expected.png:
  • platform/efl/fast/html/details-open4-expected.txt:
  • platform/efl/fast/lists/dynamic-marker-crash-expected.png:
  • platform/efl/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/efl/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/efl/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/efl/fast/repaint/search-field-cancel-expected.png:
  • platform/efl/fast/repaint/search-field-cancel-expected.txt:
  • platform/efl/fast/repaint/subtree-root-skipped-expected.png:
  • platform/efl/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-expected.png:
  • platform/efl/fast/replaced/replaced-breaking-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/efl/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/efl/fast/replaced/width100percent-textfield-expected.png:
  • platform/efl/fast/replaced/width100percent-textfield-expected.txt:
  • platform/efl/fast/table/003-expected.png:
  • platform/efl/fast/table/003-expected.txt:
  • platform/efl/fast/table/colspanMinWidth-expected.png:
  • platform/efl/fast/table/colspanMinWidth-expected.txt:
  • platform/efl/fast/table/spanOverlapRepaint-expected.png:
  • platform/efl/fast/table/spanOverlapRepaint-expected.txt:
  • platform/efl/fast/table/text-field-baseline-expected.png:
  • platform/efl/fast/table/text-field-baseline-expected.txt:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.png:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt:
6:32 AM Changeset in webkit [117689] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2012-05-19 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update two pixel test results on Lion, which show marginal diffs.

  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.png:
4:18 AM Changeset in webkit [117688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Windows build broken due to changes in the http://trac.webkit.org/changeset/117646
https://bugs.webkit.org/show_bug.cgi?id=86939

The changeset 117646 changed the JSString::toBoolean signature. This
change is for fixing the windows build break.

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-19
Reviewed by Ryosuke Niwa.

2:29 AM Changeset in webkit [117687] by Csaba Osztrogonác
  • 5 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed weekend gardening.

  • platform/qt-4.8/Skipped: Copy/paste error fix after r117588.
  • platform/qt/fast/forms/form-hides-table-expected.png: Added after r117640.
  • platform/qt/fast/forms/form-hides-table-expected.txt: Updated after r117640.
  • platform/qt/fast/table/form-with-table-style-expected.png: Updated after r117640.
  • platform/qt/fast/table/form-with-table-style-expected.txt: Updated after r117640.
2:24 AM Changeset in webkit [117686] by rniwa@webkit.org
  • 22 edits
    3 adds in trunk

Tools: Build fix. Sometimes --suffixes isn't supplied.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.rebaseline):
(GardeningHTTPRequestHandler.optimizebaselines):

LayoutTests: More Chromium rebaselines after r117672.

  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-24-expected.png: Added.
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac/fast/forms/select-empty-option-height-expected.txt: Added.
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-24-expected.png: Added.
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-24-expected.txt:
2:07 AM Changeset in webkit [117685] by rniwa@webkit.org
  • 4 edits
    5 copies in trunk/LayoutTests

More SnowLeopard rebaselines.

  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt.
  • platform/mac-snowleopard/fast/css/font-family-pictograph-expected.txt: Copied from LayoutTests/platform/mac/fast/css/font-family-pictograph-expected.txt.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt:
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt:
  • platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/canvas-putImageData-expected.txt.
  • platform/mac-snowleopard/media/controls-styling-expected.txt: Copied from LayoutTests/platform/mac/media/controls-styling-expected.txt.
  • platform/mac-snowleopard/media/controls-without-preload-expected.txt:
  • platform/mac-snowleopard/media/media-can-play-wav-audio-expected.txt: Copied from LayoutTests/platform/mac/media/media-can-play-wav-audio-expected.txt.
1:14 AM WebKitGTK/1.8.x edited by zandobersek@gmail.com
(diff)
1:03 AM Changeset in webkit [117684] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Touch Internals.* in an attempt to fix Windows builds after r117646.

  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:
12:59 AM Changeset in webkit [117683] by zandobersek@gmail.com
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed, adding GTK baselines for new tests added in r117477.

  • platform/gtk/css2.1/20110323/table-height-algorithm-023-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-height-algorithm-024-expected.txt: Added.
  • platform/gtk/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
  • platform/gtk/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
12:42 AM Changeset in webkit [117682] by rniwa@webkit.org
  • 17 edits in trunk

Tools: Add "Lion" -> "mac-lion" to the builder port map.

  • Scripts/webkitpy/layout_tests/port/builders.py:

LayoutTests: Lion rebaseline after r117672.

  • platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/invalid/residual-style-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
12:27 AM Changeset in webkit [117681] by Csaba Osztrogonác
  • 234 edits
    1 copy
    3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r117672.

  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/qt/editing/input/caret-at-the-edge-of-input-expected.png: Added.
  • platform/qt/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/qt/editing/pasteboard/4806874-expected.png:
  • platform/qt/editing/pasteboard/4806874-expected.txt:
  • platform/qt/editing/pasteboard/input-field-1-expected.png:
  • platform/qt/editing/pasteboard/input-field-1-expected.txt:
  • platform/qt/editing/selection/3690703-2-expected.png:
  • platform/qt/editing/selection/3690703-2-expected.txt:
  • platform/qt/editing/selection/3690703-expected.png:
  • platform/qt/editing/selection/3690703-expected.txt:
  • platform/qt/editing/selection/3690719-expected.png:
  • platform/qt/editing/selection/3690719-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.png:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4975120-expected.png:
  • platform/qt/editing/selection/4975120-expected.txt:
  • platform/qt/editing/selection/drag-select-1-expected.png:
  • platform/qt/editing/selection/drag-select-1-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/qt/fast/css/input-search-padding-expected.png:
  • platform/qt/fast/css/input-search-padding-expected.txt:
  • platform/qt/fast/css/line-height-expected.png:
  • platform/qt/fast/css/line-height-expected.txt:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/qt/fast/css/text-overflow-input-expected.png:
  • platform/qt/fast/css/text-overflow-input-expected.txt:
  • platform/qt/fast/dom/isindex-001-expected.png:
  • platform/qt/fast/dom/isindex-001-expected.txt:
  • platform/qt/fast/events/context-no-deselect-expected.png:
  • platform/qt/fast/events/context-no-deselect-expected.txt:
  • platform/qt/fast/forms/basic-inputs-expected.png:
  • platform/qt/fast/forms/basic-inputs-expected.txt:
  • platform/qt/fast/forms/box-shadow-override-expected.png:
  • platform/qt/fast/forms/box-shadow-override-expected.txt:
  • platform/qt/fast/forms/control-restrict-line-height-expected.png:
  • platform/qt/fast/forms/control-restrict-line-height-expected.txt:
  • platform/qt/fast/forms/encoding-test-expected.png:
  • platform/qt/fast/forms/encoding-test-expected.txt:
  • platform/qt/fast/forms/fieldset-align-expected.png:
  • platform/qt/fast/forms/fieldset-align-expected.txt:
  • platform/qt/fast/forms/floating-textfield-relayout-expected.png:
  • platform/qt/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/qt/fast/forms/form-element-geometry-expected.png:
  • platform/qt/fast/forms/form-element-geometry-expected.txt:
  • platform/qt/fast/forms/input-align-expected.png:
  • platform/qt/fast/forms/input-align-expected.txt:
  • platform/qt/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/qt/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/qt/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/qt/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/qt/fast/forms/input-appearance-disabled-expected.png:
  • platform/qt/fast/forms/input-appearance-disabled-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.png:
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/qt/fast/forms/input-appearance-readonly-expected.png:
  • platform/qt/fast/forms/input-appearance-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.png:
  • platform/qt/fast/forms/input-appearance-selection-expected.txt:
  • platform/qt/fast/forms/input-appearance-visibility-expected.png:
  • platform/qt/fast/forms/input-appearance-visibility-expected.txt:
  • platform/qt/fast/forms/input-baseline-expected.png:
  • platform/qt/fast/forms/input-baseline-expected.txt:
  • platform/qt/fast/forms/input-disabled-color-expected.png:
  • platform/qt/fast/forms/input-disabled-color-expected.txt:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/qt/fast/forms/input-field-text-truncated-expected.png:
  • platform/qt/fast/forms/input-field-text-truncated-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/qt/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/qt/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/qt/fast/forms/input-readonly-empty-expected.png:
  • platform/qt/fast/forms/input-readonly-empty-expected.txt:
  • platform/qt/fast/forms/input-spaces-expected.png:
  • platform/qt/fast/forms/input-spaces-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.png:
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.png:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.png:
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/input-text-word-wrap-expected.png:
  • platform/qt/fast/forms/input-text-word-wrap-expected.txt:
  • platform/qt/fast/forms/input-width-expected.png:
  • platform/qt/fast/forms/input-width-expected.txt:
  • platform/qt/fast/forms/minWidthPercent-expected.png:
  • platform/qt/fast/forms/minWidthPercent-expected.txt:
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/qt/fast/forms/placeholder-position-expected.png:
  • platform/qt/fast/forms/placeholder-position-expected.txt:
  • platform/qt/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.png:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.png:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.png:
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
  • platform/qt/fast/forms/text-style-color-expected.png:
  • platform/qt/fast/forms/text-style-color-expected.txt:
  • platform/qt/fast/forms/textfield-focus-ring-expected.png:
  • platform/qt/fast/forms/textfield-focus-ring-expected.txt:
  • platform/qt/fast/forms/textfield-outline-expected.png: Added.
  • platform/qt/fast/forms/textfield-outline-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.png: Copied from LayoutTests/platform/qt/fast/transforms/transformed-focused-text-input-expected.png.
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.png:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/qt/fast/html/details-no-summary4-expected.png:
  • platform/qt/fast/html/details-no-summary4-expected.txt:
  • platform/qt/fast/html/details-open-javascript-expected.png:
  • platform/qt/fast/html/details-open-javascript-expected.txt:
  • platform/qt/fast/html/details-open2-expected.png:
  • platform/qt/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-open4-expected.png:
  • platform/qt/fast/html/details-open4-expected.txt:
  • platform/qt/fast/lists/dynamic-marker-crash-expected.png:
  • platform/qt/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/qt/fast/repaint/search-field-cancel-expected.png:
  • platform/qt/fast/repaint/search-field-cancel-expected.txt:
  • platform/qt/fast/repaint/subtree-root-skipped-expected.png:
  • platform/qt/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.png:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/qt/fast/replaced/width100percent-textfield-expected.png:
  • platform/qt/fast/replaced/width100percent-textfield-expected.txt:
  • platform/qt/fast/table/colspanMinWidth-expected.png:
  • platform/qt/fast/table/colspanMinWidth-expected.txt:
  • platform/qt/fast/table/spanOverlapRepaint-expected.png:
  • platform/qt/fast/table/spanOverlapRepaint-expected.txt:
  • platform/qt/fast/table/text-field-baseline-expected.png:
  • platform/qt/fast/table/text-field-baseline-expected.txt:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.png:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/qt/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/qt/svg/hixie/mixed/003-expected.png:
  • platform/qt/svg/hixie/mixed/003-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug24200-expected.png:
  • platform/qt/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.png:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug55545-expected.png:
  • platform/qt/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug59354-expected.png:
  • platform/qt/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.png:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/qt/tables/mozilla/dom/tableDom-expected.png:
  • platform/qt/tables/mozilla/dom/tableDom-expected.txt:
  • platform/qt/tables/mozilla/other/move_row-expected.png:
  • platform/qt/tables/mozilla/other/move_row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
12:13 AM Changeset in webkit [117680] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, rolling out r117675.
http://trac.webkit.org/changeset/117675
https://bugs.webkit.org/show_bug.cgi?id=86938

Broke builds. You can't initialize members by members
themselves (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-19

Source/WebKit/chromium:

  • public/WebFrame.h:

(WebFrame):

  • public/WebPlugin.h:

(WebPlugin):
(WebKit::WebPlugin::printBegin):

  • public/WebPrintParams.h:
  • src/WebFrameImpl.cpp:

(WebKit):
(WebKit::WebFrameImpl::printBegin):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::printBegin):

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::numberOfPages):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printPage):

May 18, 2012:

11:36 PM Changeset in webkit [117679] by rniwa@webkit.org
  • 314 edits
    2 adds
    4 deletes in trunk/LayoutTests

Yet another Chromium rebaselines after r117672.

  • fast/forms/textfield-outline-expected.txt: Added.
  • platform/chromium-linux-x86/fast/forms/date: Removed.
  • platform/chromium-linux/fast/forms/basic-inputs-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-linux/fast/forms/encoding-test-expected.png:
  • platform/chromium-linux/fast/forms/fieldset-align-expected.png:
  • platform/chromium-linux/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-linux/fast/forms/input-align-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-linux/fast/forms/input-baseline-expected.png:
  • platform/chromium-linux/fast/forms/input-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-linux/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-linux/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-linux/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-linux/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-linux/fast/forms/input-spaces-expected.png:
  • platform/chromium-linux/fast/forms/input-table-expected.png:
  • platform/chromium-linux/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-linux/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-linux/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-linux/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-linux/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-linux/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.txt:
  • platform/chromium-linux/fast/forms/input-width-expected.png:
  • platform/chromium-linux/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-linux/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-linux/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-linux/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-linux/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-linux/fast/forms/search-rtl-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-linux/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/chromium-linux/fast/forms/text-style-color-expected.png:
  • platform/chromium-linux/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.png:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-leopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-leopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-leopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-styled-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-leopard/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png: Removed.
  • platform/chromium-mac/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac/fast/forms/input-align-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac/fast/forms/input-table-expected.png:
  • platform/chromium-mac/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.png:
  • platform/chromium-mac/fast/forms/input-width-expected.png: Added.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/search-styled-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-win-xp/fast/forms/search-styled-expected.png:
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win-xp/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/chromium-win/fast/forms/basic-inputs-expected.png:
  • platform/chromium-win/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-win/fast/forms/encoding-test-expected.png:
  • platform/chromium-win/fast/forms/encoding-test-expected.txt:
  • platform/chromium-win/fast/forms/fieldset-align-expected.png:
  • platform/chromium-win/fast/forms/fieldset-align-expected.txt:
  • platform/chromium-win/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-win/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-win/fast/forms/input-align-expected.png:
  • platform/chromium-win/fast/forms/input-align-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-visibility-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-width-expected.txt:
  • platform/chromium-win/fast/forms/input-baseline-expected.png:
  • platform/chromium-win/fast/forms/input-baseline-expected.txt:
  • platform/chromium-win/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-win/fast/forms/input-disabled-color-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-win/fast/forms/input-field-text-truncated-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-win/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-win/fast/forms/input-readonly-empty-expected.txt:
  • platform/chromium-win/fast/forms/input-spaces-expected.png:
  • platform/chromium-win/fast/forms/input-spaces-expected.txt:
  • platform/chromium-win/fast/forms/input-table-expected.png:
  • platform/chromium-win/fast/forms/input-table-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-win/fast/forms/input-text-click-outside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-win/fast/forms/input-text-word-wrap-expected.txt:
  • platform/chromium-win/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-win/fast/forms/input-type-text-min-width-expected.txt:
  • platform/chromium-win/fast/forms/input-value-expected.png:
  • platform/chromium-win/fast/forms/input-value-expected.txt:
  • platform/chromium-win/fast/forms/input-width-expected.png:
  • platform/chromium-win/fast/forms/input-width-expected.txt:
  • platform/chromium-win/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-win/fast/forms/minWidthPercent-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.png:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.png:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/chromium-win/fast/forms/text-style-color-expected.png:
  • platform/chromium-win/fast/forms/text-style-color-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/textfield-outline-expected.png:
  • platform/chromium-win/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/efl/fast/forms/textfield-outline-expected.txt: Removed.
  • platform/gtk/fast/forms/textfield-outline-expected.txt: Removed.
11:13 PM Changeset in webkit [117678] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] remove obsolete WebViewClient::startDragging version
https://bugs.webkit.org/show_bug.cgi?id=86887

Reviewed by Adam Barth.

  • public/WebViewClient.h:

(WebKit::WebViewClient::startDragging):

11:09 PM Changeset in webkit [117677] by rniwa@webkit.org
  • 426 edits
    60 adds
    2 deletes in trunk/LayoutTests

More Chromium rebaselines after r117672.

  • platform/chromium-linux-x86/css3: Added.
  • platform/chromium-linux-x86/css3/selectors3: Added.
  • platform/chromium-linux-x86/css3/selectors3/html: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-23-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-24-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-68-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-69-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-23-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-24-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-69-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-23-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-68-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-69-expected.png: Added.
  • platform/chromium-linux-x86/http/tests/navigation: Added.
  • platform/chromium-linux-x86/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/chromium-linux/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-linux/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-linux/editing/pasteboard/4806874-expected.png:
  • platform/chromium-linux/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-linux/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-2-expected.txt:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.txt:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.txt:
  • platform/chromium-linux/editing/selection/4895428-3-expected.png:
  • platform/chromium-linux/editing/selection/4975120-expected.png:
  • platform/chromium-linux/editing/selection/drag-select-1-expected.png:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-linux/fast/css/input-search-padding-expected.png:
  • platform/chromium-linux/fast/css/input-search-padding-expected.txt:
  • platform/chromium-linux/fast/css/line-height-expected.png:
  • platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-linux/fast/css/text-overflow-input-expected.png:
  • platform/chromium-linux/fast/dom/isindex-001-expected.png:
  • platform/chromium-linux/fast/dom/isindex-002-expected.png:
  • platform/chromium-linux/fast/events/autoscroll-expected.png:
  • platform/chromium-linux/fast/events/context-no-deselect-expected.png:
  • platform/chromium-linux/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary4-expected.png:
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png:
  • platform/chromium-linux/fast/html/details-open2-expected.png:
  • platform/chromium-linux/fast/html/details-open4-expected.png:
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-linux/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-linux/fast/repaint/subtree-root-skipped-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-linux/fast/table/colspanMinWidth-expected.png:
  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium-linux/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-linux/fast/table/text-field-baseline-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-linux/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-linux/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-linux/svg/hixie/mixed/003-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-leopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-leopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-leopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac-leopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-leopard/fast/table/003-expected.png:
  • platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-23-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-24-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-68-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-69-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-23-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-24-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-69-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-23-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-68-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-69-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
  • platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac/editing/selection/4975120-expected.png:
  • platform/chromium-mac/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt: Removed.
  • platform/chromium-mac/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac/fast/css/line-height-expected.png:
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac/fast/events/autoscroll-expected.png:
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac/fast/html/details-open2-expected.png:
  • platform/chromium-mac/fast/html/details-open4-expected.png:
  • platform/chromium-mac/fast/invalid/residual-style-expected.txt: Added.
  • platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.png:
  • platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.txt: Added.
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.txt: Added.
  • platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac/fast/table/003-expected.png:
  • platform/chromium-mac/fast/table/colspanMinWidth-expected.png: Added.
  • platform/chromium-mac/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-win-vista/css3: Added.
  • platform/chromium-win-vista/css3/selectors3: Added.
  • platform/chromium-win-vista/css3/selectors3/html: Added.
  • platform/chromium-win-vista/css3/selectors3/html/css3-modsel-23-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/html/css3-modsel-24-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/html/css3-modsel-68-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/html/css3-modsel-69-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/xhtml: Added.
  • platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-23-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-24-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-69-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/xml: Added.
  • platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-23-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-68-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-69-expected.png: Added.
  • platform/chromium-win-vista/http/tests/navigation: Added.
  • platform/chromium-win-vista/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-win/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/chromium-win/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-win/editing/inserting/before-after-input-element-expected.txt:
  • platform/chromium-win/editing/pasteboard/4806874-expected.png:
  • platform/chromium-win/editing/pasteboard/4806874-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.txt:
  • platform/chromium-win/editing/selection/3690703-2-expected.png:
  • platform/chromium-win/editing/selection/3690703-2-expected.txt:
  • platform/chromium-win/editing/selection/3690703-expected.png:
  • platform/chromium-win/editing/selection/3690703-expected.txt:
  • platform/chromium-win/editing/selection/3690719-expected.png:
  • platform/chromium-win/editing/selection/3690719-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.png:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.png:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/drag-select-1-expected.png:
  • platform/chromium-win/editing/selection/drag-select-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/fast/css/input-search-padding-expected.png:
  • platform/chromium-win/fast/css/input-search-padding-expected.txt:
  • platform/chromium-win/fast/css/line-height-expected.png:
  • platform/chromium-win/fast/css/line-height-expected.txt:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium-win/fast/css/text-overflow-input-expected.png:
  • platform/chromium-win/fast/css/text-overflow-input-expected.txt:
  • platform/chromium-win/fast/dom/isindex-001-expected.png:
  • platform/chromium-win/fast/dom/isindex-001-expected.txt:
  • platform/chromium-win/fast/dom/isindex-002-expected.png:
  • platform/chromium-win/fast/dom/isindex-002-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.png:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.png:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.png:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.png:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.png:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.png:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-win/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/repaint/subtree-root-skipped-expected.png:
  • platform/chromium-win/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/chromium-win/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-win/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-win/fast/replaced/width100percent-textfield-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-expected.png:
  • platform/chromium-win/fast/table/colspanMinWidth-expected.txt:
  • platform/chromium-win/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-win/fast/table/spanOverlapRepaint-expected.txt:
  • platform/chromium-win/fast/table/text-field-baseline-expected.png:
  • platform/chromium-win/fast/table/text-field-baseline-expected.txt:
  • platform/chromium-win/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-win/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/003-expected.png:
  • platform/chromium-win/svg/hixie/mixed/003-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-win/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-win/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/chromium/test_expectations.txt:
10:21 PM Changeset in webkit [117676] by Philippe Normand
  • 134 edits
    14 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r117672.

  • platform/gtk/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
  • platform/gtk/css3/selectors3/html/css3-modsel-24-expected.txt: Added.
  • platform/gtk/css3/selectors3/html/css3-modsel-68-expected.txt: Added.
  • platform/gtk/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Added.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Added.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
  • platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
  • platform/gtk/css3/selectors3/xml/css3-modsel-24-expected.txt: Added.
  • platform/gtk/css3/selectors3/xml/css3-modsel-68-expected.txt: Added.
  • platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
  • platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/gtk/editing/inserting/before-after-input-element-expected.txt:
  • platform/gtk/editing/pasteboard/4806874-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/input-field-1-expected.txt:
  • platform/gtk/editing/selection/3690703-2-expected.txt:
  • platform/gtk/editing/selection/3690703-expected.txt:
  • platform/gtk/editing/selection/3690719-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/line-height-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/css/text-overflow-input-expected.txt:
  • platform/gtk/fast/dom/isindex-001-expected.txt:
  • platform/gtk/fast/dom/isindex-002-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/encoding-test-expected.txt:
  • platform/gtk/fast/forms/fieldset-align-expected.txt:
  • platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/form-hides-table-expected.txt:
  • platform/gtk/fast/forms/input-align-expected.txt:
  • platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
  • platform/gtk/fast/forms/input-appearance-width-expected.txt:
  • platform/gtk/fast/forms/input-baseline-expected.txt:
  • platform/gtk/fast/forms/input-disabled-color-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/gtk/fast/forms/input-readonly-empty-expected.txt:
  • platform/gtk/fast/forms/input-spaces-expected.txt:
  • platform/gtk/fast/forms/input-table-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
  • platform/gtk/fast/forms/input-type-text-min-width-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/input-width-expected.txt:
  • platform/gtk/fast/forms/minWidthPercent-expected.txt:
  • platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/gtk/fast/forms/text-style-color-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-outline-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/forms/validation-message-appearance-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
  • platform/gtk/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/repaint/search-field-cancel-expected.txt:
  • platform/gtk/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/replaced/width100percent-textfield-expected.txt:
  • platform/gtk/fast/table/003-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-expected.txt:
  • platform/gtk/fast/table/form-with-table-style-expected.txt:
  • platform/gtk/fast/table/spanOverlapRepaint-expected.txt:
  • platform/gtk/fast/table/text-field-baseline-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-in-text-controls-expected.txt:
  • platform/gtk/svg/hixie/mixed/003-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla/other/move_row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug99948-expected.txt: Added.
10:20 PM Changeset in webkit [117675] by commit-queue@webkit.org
  • 10 edits in trunk

Source/WebKit/chromium: [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
https://bugs.webkit.org/show_bug.cgi?id=86684

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-05-18
Reviewed by Darin Fisher.

  • public/WebFrame.h:

(WebFrame):

  • public/WebPlugin.h:

(WebPlugin):

  • public/WebPrintParams.h:

(WebKit::WebPrintParams::WebPrintParams):
(WebPrintParams):

  • src/WebFrameImpl.cpp:

(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::printBegin):

Tools: [chromium] User overloaded printBegin() webkit API to support auto fit to page functionality.
https://bugs.webkit.org/show_bug.cgi?id=86684

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-05-18
Reviewed by Darin Fisher.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::numberOfPages):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printPage):

9:36 PM Changeset in webkit [117674] by rniwa@webkit.org
  • 171 edits in trunk/LayoutTests

Chromium Mac rebaseline after r117672.

  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-submit-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-in-malformed-markup-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/range-thumb-height-percentage-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.txt:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
9:35 PM Changeset in webkit [117673] by rniwa@webkit.org
  • 161 edits
    1 delete in trunk/LayoutTests

Mac rebaseline after r117672.

  • platform/mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/mac/editing/inserting/before-after-input-element-expected.txt:
  • platform/mac/editing/pasteboard/4806874-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.png:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/dom/isindex-001-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.png:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/basic-inputs-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/encoding-test-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.png:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-visibility-expected.txt:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.txt:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-field-text-truncated-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-readonly-empty-expected.txt:
  • platform/mac/fast/forms/input-spaces-expected.txt:
  • platform/mac/fast/forms/input-table-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/input-text-word-wrap-expected.txt:
  • platform/mac/fast/forms/input-type-text-min-width-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/input-width-expected.txt:
  • platform/mac/fast/forms/minWidthPercent-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/select-empty-option-height-expected.txt: Removed.
  • platform/mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/mac/fast/forms/text-style-color-expected.png:
  • platform/mac/fast/forms/text-style-color-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.png:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/replaced/width100percent-textfield-expected.txt:
  • platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/mac/fast/table/003-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/spanOverlapRepaint-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla/other/move_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • svg/custom/svg-fonts-in-text-controls-expected.txt:
9:29 PM Changeset in webkit [117672] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

WebKit erroneously add 1px padding in input elements
https://bugs.webkit.org/show_bug.cgi?id=86784

Reviewed by Kent Tamura.

Source/WebCore:

Fixed the bug by removing the code that added left and right paddings in input elements.
The code was added in r13567 to match a very old version of Internet Explorer but this quirk
does not seem to exists in IE9 (both in quirks and standard modes).

A lot of tests need to be rebaselined due to 1px difference inside input elements, and 2px
differences for the width of input elements. (In some extreme cases, line breaking changed
due to the width change).

Test: fast/forms/input-textarea-padding-match.html

  • css/html.css:

(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

LayoutTests:

Add a regression test.

Rebaseline lots of tests per getting rid of extra 1px padding on left and right will be done
in separate commits. Input elements' widths got shrunk by 2px in most cases and the text moved
1px to the start (left for LTR and right for RTL).

  • fast/forms/input-textarea-padding-match-expected.html: Added.
  • fast/forms/input-textarea-padding-match.html: Added.
9:21 PM Changeset in webkit [117671] by Philippe Normand
  • 3 edits in trunk/Source/WebKit/gtk

Unreviewed, rolling out r117628.
http://trac.webkit.org/changeset/117628
https://bugs.webkit.org/show_bug.cgi?id=86936

triggers 20+ timeouts in the editing test suite (Requested by
philn on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-18

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString):

  • webkit/webkitspellcheckerenchant.cpp:

(checkSpellingOfString):

8:29 PM Changeset in webkit [117670] by pkasting@chromium.org
  • 4 edits
    2 adds
    4 deletes in trunk/LayoutTests

More baseline updates after r117640.
https://bugs.webkit.org/show_bug.cgi?id=86920

Unreviewed, test expectations update.

  • fast/forms/form-hides-table-expected.txt: Removed.
  • fast/table/form-with-table-style-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/form-hides-table-expected.txt: Removed.
  • platform/chromium-linux/fast/table/form-with-table-style-expected.txt: Removed.
  • platform/chromium-win/fast/forms/form-hides-table-expected.txt:
  • platform/chromium-win/fast/table/form-with-table-style-expected.png:
  • platform/chromium-win/fast/table/form-with-table-style-expected.txt:
  • platform/gtk/fast/forms/form-hides-table-expected.txt: Added.
  • platform/gtk/fast/table/form-with-table-style-expected.txt: Added.
8:23 PM Changeset in webkit [117669] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Fix expectation for test from r117667 with the bot result.

The diff also happens to match the result for the other ports.

  • platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt:
8:18 PM Changeset in webkit [117668] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip a few tests which are actually passing.

  • platform/efl/Skipped:
7:59 PM Changeset in webkit [117667] by rakuco@webkit.org
  • 2 edits
    8 adds in trunk/LayoutTests

[EFL] Unskip tests and add expectations after r116776.

  • platform/efl/Skipped:
  • platform/efl/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/efl/fast/writing-mode/japanese-lr-text-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-lr-text-expected.txt: Added.
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/efl/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/efl/fast/writing-mode/vertical-font-fallback-expected.txt: Added.
7:50 PM Changeset in webkit [117666] by rakuco@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Gardening after r116761 and the jhbuild/font changes.

  • platform/efl/Skipped:
  • platform/efl/fast/forms/select-disabled-appearance-expected.png:
  • platform/efl/fast/forms/select-disabled-appearance-expected.txt:
7:24 PM Changeset in webkit [117665] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Fix broken expectations in r117651.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
6:13 PM Changeset in webkit [117664] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Add diagnostic CRASH calls for tiler crashes
https://bugs.webkit.org/show_bug.cgi?id=86930

Reviewed by James Robinson.

These lines would normally crash on their own due to null pointers,
but having an explicit CRASH call will help us differentiate what the
real problem might be in the crash report.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::updateTiles):

6:11 PM Changeset in webkit [117663] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r136942 to r137976.

  • DEPS:
6:08 PM Changeset in webkit [117662] by commit-queue@webkit.org
  • 20 edits
    6 adds in trunk

Source/WebCore: Update Media Source implementation to reflect changes in 0.5 spec.
https://bugs.webkit.org/show_bug.cgi?id=83607

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-05-18
Reviewed by Darin Fisher.

Tests: http/tests/media/media-source/video-media-source-event-attributes.html

http/tests/media/media-source/webm/video-media-source-abort.html
http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html

  • html/HTMLAttributeNames.in: Add onwebkitsourcexxx event attribute names.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute): Add code to register event listeners for the onwebkitsourcexxx attributes.
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore):
(WebCore::HTMLMediaElement::webkitSourceAddId): Changed code to pass the parsed type & codecs to m_player instead of the whole MIME-type string. This was done to allow some simple parsing & validation code to be shared in WebKit instead of reimplemented in every port.
(WebCore::HTMLMediaElement::webkitSourceBuffered): New method in the v0.5 spec. It validates the parameters & that it is being called in the correct state. If so it forwards the call to m_player.
(WebCore::HTMLMediaElement::webkitSourceAppend): Adds id parameter to match v0.5 signature. Minor logic changes that avoid calling m_player for 0 byte arrays and fixes exceptions reported for a null array and a parse error so they match the spec text.
(WebCore::HTMLMediaElement::webkitSourceAbort): New method in the v0.5 spec. It validates the parameter & that it is being called in athe correct state. If so it forwards the call to m_player.

  • html/HTMLMediaElement.h:

(HTMLMediaElement): Added new methods, signature updates, and onwebitsourcexxx event listener attributes.

  • html/HTMLMediaElement.idl: Added new methods, signature updates, and onwebitsourcexxx event listener attributes.
  • platform/ContentType.cpp:

(WebCore::ContentType::codecs): A new method that parses the codecs parameter into a vector of codec strings.
(WebCore):

  • platform/ContentType.h:

(ContentType):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::sourceAddId): Update the signature to take the parsed type and codecs vector.
(WebCore::NullMediaPlayerPrivate::sourceBuffered): Add default implementation for this new method.
(WebCore::NullMediaPlayerPrivate::sourceRemoveId): Remove id parameter name to match other methods.
(WebCore::NullMediaPlayerPrivate::sourceAppend): Updated signature to include id parameter.
(WebCore::NullMediaPlayerPrivate::sourceAbort): Add default implementation for this new method.
(WebCore::NullMediaPlayerPrivate::sourceEndOfStream): Remove parameter name to match other methods.
(WebCore::MediaPlayer::sourceAddId): Update the signature to take the parsed type and codecs vector.
(WebCore):
(WebCore::MediaPlayer::sourceBuffered): Add implementation for new method that forwards the call to the MediaPlayerPrivate interface.
(WebCore::MediaPlayer::sourceAppend): Update method to forward the new id parameter in the signature.
(WebCore::MediaPlayer::sourceAbort): Add implementation for new method that forwards the call to the MediaPlayerPrivate interface.

  • platform/graphics/MediaPlayer.h: Update interface to include new methods and updated signatures.
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::sourceAddId): Update the signature to take the parsed type and codecs vector.
(WebCore::MediaPlayerPrivateInterface::sourceBuffered): Add default implementation for new method.
(WebCore::MediaPlayerPrivateInterface::sourceAppend): Update method to forward the new id parameter in the signature.
(WebCore::MediaPlayerPrivateInterface::sourceAbort): Add default implementation for new method.

Source/WebKit/chromium: Update Media Source implementation to reflect changes in 0.5 spec.
https://bugs.webkit.org/show_bug.cgi?id=83607

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-05-18
Reviewed by Darin Fisher.

  • public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::sourceAddId): Update the signature to take the parsed type and codecs vector.
(WebKit::WebMediaPlayer::sourceBuffered): Add default implementation for new method.
(WebKit::WebMediaPlayer::sourceAppend): Update signature to include id parameter.
(WebKit::WebMediaPlayer::sourceAbort): Add default implementation for new method.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::sourceAddId): Update the signature to take the parsed type and codecs vector.
(WebKit::WebMediaPlayerClientImpl::sourceBuffered): Added implementation for new method. Converts WebKit::WebTimeRanges to WebCore::TimeRanges.
(WebKit):
(WebKit::WebMediaPlayerClientImpl::sourceAppend): Update signature to include id parameter.
(WebKit::WebMediaPlayerClientImpl::sourceAbort): Implementation for new method.

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl): Added declarations for new methods and updated signatures for existing ones.

LayoutTests: Updated Media Source LayoutTests to use v0.5 spec signatures and added
new tests to verify the behavior of the new methods.
https://bugs.webkit.org/show_bug.cgi?id=83607

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-05-18
Reviewed by Darin Fisher.

  • http/tests/media/media-source/video-media-source-event-attributes-expected.txt: Added.
  • http/tests/media/media-source/video-media-source-event-attributes.html: Added. Tests onwebkitsourcexxx event attributes.
  • http/tests/media/media-source/webm/video-media-source-abort-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-abort.html: Added. Tests basic webkitSourceAbort() functionality.
  • http/tests/media/media-source/webm/video-media-source-add-and-remove-ids-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html: Added. Tests webkitSourceAddId() & webkitSourceRemoveId().
  • http/tests/media/media-source/webm/video-media-source-errors.html: Style fixes and add addSourceId() since we need to add an ID before appending data now.
  • http/tests/media/media-source/webm/video-media-source-play.html: Style fixes and add addSourceId().
  • http/tests/media/media-source/webm/video-media-source-seek.html: Style fixes and add addSourceId().
  • http/tests/media/media-source/webm/video-media-source-state-changes.html: Style fixes and add addSourceId().
  • http/tests/media/media-source/webm/webm-media-source.js:

(getData.request.onload): Style fix.
(getData): Style fix.
(loadWebMData): Style fix.
(addSourceId): New helper method that adds SOURCE_ID to the video tag so data can be appended with this ID.
(appendHeaders): Add SOURCE_ID parameter since the webkitSourceAppend() signature changed.
(appendCluster): Add SOURCE_ID parameter since the webkitSourceAppend() signature changed.
(appendUntilEndOfStream): Add SOURCE_ID parameter since the webkitSourceAppend() signature changed.

5:54 PM Changeset in webkit [117661] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(117646): fast/canvas/webgl/glsl-conformance.html is crashing in the DFG
https://bugs.webkit.org/show_bug.cgi?id=86929

Reviewed by Oliver Hunt.

The problem was that if CFG simplification saw a Branch with identical successors,
it would always perform a basic block merge. But that's wrong if the successor has
other predecessors.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

5:04 PM Changeset in webkit [117660] by rakuco@webkit.org
  • 6 edits in trunk

[EFL][DRT] Make it possible to enable CSS Grid Layout.
https://bugs.webkit.org/show_bug.cgi?id=86921

Reviewed by Tony Chang.

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::overridePreference):

4:58 PM Changeset in webkit [117659] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

Revert to float method of selection rect alignment for line box tree
https://bugs.webkit.org/show_bug.cgi?id=86904

Reviewed by Eric Seidel.

In r117491, we introduced a new method of alignment for the selection rect in the sub-pixel case.
It turns out there is at least one case on Mac where this leaves a gap when painting selection rects
originating in the line box tree. This patch reverts us to the float method for the line box tree,
but retains the LayoutRect snapping for gap rects.

No new tests. Covered by existing tests with sub-pixel layout enabled.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paintSelection): Re-enabling the FloatRect flavor of
alignSelectionRectToDevicePixels for the line box tree.

  • rendering/InlineTextBox.cpp:

(WebCore::alignSelectionRectToDevicePixels): Moving LayoutRect flavor to RenderBlock.
(WebCore::InlineTextBox::paintSelection): Happily clearing up the bifurcation of algorithms for
sub-pixel layout.

  • rendering/InlineTextBox.h: Re-enabling the FloatRect flavor of alignSelectionRectToDevicePixels

for the line box tree.

  • rendering/RenderBlock.cpp:

(WebCore::alignSelectionRectToDevicePixels): Re-seating the LayoutRect version of
alignSelectionRectToDevicePixels for use with GapRects.

4:47 PM Changeset in webkit [117658] by eric@webkit.org
  • 4 edits
    2 adds in trunk
Assertion failure in BidiResolver::commitExplicitEmbedding() (!inIsolate()
m_currentExplicitEmbeddingSequence.isEmpty()) at wikipedia.org

https://bugs.webkit.org/show_bug.cgi?id=76574

Reviewed by Levi Weintraub.

Source/WebCore:

Consider this example:
<span style="unicode-bidi: embed"><span style="unicode-bidi: isolate">a</span></span>
Before this patch, we would ASSERT when computing the text runs, as we would have encountered
the "embed LTR" directive from the outer span, but not try to "commit" this embedding until
we encountered the first charater (an optimization to avoid creating unnecessary bidi embedding contexts).
The ASSERT we were hitting was to ensure that embedding directives inside an isolated span
did not bleed out and effect the surrounding text.

bidi "isolate" support uses a multi-pass Unicode Bidi Algorithm (UBA), which when encountering
"isolated" sections of text ignores them in the first pass, and then goes back and runs
a separate instance of the UBA on those isolated sections.

Once we scan into an "isolate" section (during an outer UBA application) we should not respect
any embedding directives inside that "isolate" section.

However, in the above example, our "don't commit embeddings until we need them" and
"assert we don't respect embeddings inside isolated spans" were conflicting.
The fix is to make sure we always commit any pending embedding directives *before*
we enter an isolate section.

Luckly there was no functional bug here as we were still respecting
the embedding directives we were belatedly committing. After this change we're commiting
those directives at a more appropriate time, thus avoiding the ASSERT.

Test: fast/text/bidi-isolate-embedding-crash.html

  • platform/text/BidiResolver.h:

(WebCore::::commitExplicitEmbedding):

  • rendering/InlineIterator.h:

(WebCore::notifyObserverEnteredObject):
(WebCore::IsolateTracker::commitExplicitEmbedding):

LayoutTests:

  • fast/text/bidi-isolate-embedding-crash-expected.txt: Added.
  • fast/text/bidi-isolate-embedding-crash.html: Added.
4:44 PM Changeset in webkit [117657] by leviw@chromium.org
  • 5 edits
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed. Updating non-mac platform expectations after r117640.

  • fast/forms/form-hides-table-expected.txt: Added.
  • fast/table/form-with-table-style-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/table/form-with-table-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/form-with-table-style-expected.png:
  • platform/chromium-mac/fast/table/form-with-table-style-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/forms/form-hides-table-expected.txt: Removed.
  • platform/gtk/fast/table/form-with-table-style-expected.txt: Removed.
4:34 PM Changeset in webkit [117656] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

BitmapImage::BitmapImage(CGImageRef, ImageObserver*) needs to set m_sizeRespectingOrientation
https://bugs.webkit.org/show_bug.cgi?id=86915

Reviewed by Oliver Hunt.

Set m_sizeRespectingOrientation to be the same as m_size. Otherwise it stays at 0x0 since
this constructor also sets m_haveSize to true for the BitmapImage.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::BitmapImage):

4:28 PM Changeset in webkit [117655] by leviw@chromium.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r117640) fast/table/form-with-table and fast/forms/form-hides-table fail on Mac
https://bugs.webkit.org/show_bug.cgi?id=86920

Unreviewed. Updating expectations after r117640.

  • platform/mac/fast/forms/form-hides-table-expected.txt:
  • platform/mac/fast/table/form-with-table-style-expected.txt:
4:20 PM Changeset in webkit [117654] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFG simplification crashes if it's trying to remove an unreachable block
that has an already-killed-off unreachable successor
https://bugs.webkit.org/show_bug.cgi?id=86918

Reviewed by Oliver Hunt.

This fixes crashes in:
inspector/styles/styles-computed-trace.html
inspector/console/console-big-array.html

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::fixPhis):

4:12 PM Changeset in webkit [117653] by rakuco@webkit.org
  • 5 edits
    3 adds in trunk/LayoutTests

[EFL] More random gardening.

Remove a few tests which do not exist anymore from the skipped
list, and rebaseline and add expectations for a few others.

  • platform/efl/Skipped:
  • platform/efl/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Added.
  • platform/efl/fast/invalid/004-expected.txt:
  • platform/efl/fast/invalid/010-expected.png:
  • platform/efl/fast/invalid/010-expected.txt:
  • platform/efl/fast/text/zero-font-size-expected.png: Added.
  • platform/efl/fast/text/zero-font-size-expected.txt: Added.
4:06 PM Changeset in webkit [117652] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r117607.

  • platform/mac/WebCoreNSCellExtras.m:
3:59 PM Changeset in webkit [117651] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] More expectations updates, mostly for flaky tests.
http://code.google.com/p/chromium/issues/detail?id=24182
https://bugs.webkit.org/show_bug.cgi?id=54151
https://bugs.webkit.org/show_bug.cgi?id=85174
https://bugs.webkit.org/show_bug.cgi?id=86592
https://bugs.webkit.org/show_bug.cgi?id=86907
https://bugs.webkit.org/show_bug.cgi?id=86908
https://bugs.webkit.org/show_bug.cgi?id=86909

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
3:49 PM Changeset in webkit [117650] by caio.oliveira@openbossa.org
  • 5 edits in trunk/Source/WebCore

Fix remaining uses of JSValue::toBoolean()
https://bugs.webkit.org/show_bug.cgi?id=86912

Reviewed by Filip Pizlo.

And unbreak Qt build.

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::convertValueToQVariant):

3:48 PM Changeset in webkit [117649] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening; update results after r117640.

  • platform/efl/fast/forms/form-hides-table-expected.txt:
  • platform/efl/fast/table/form-with-table-style-expected.txt:
3:42 PM Changeset in webkit [117648] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Try to add the right expectation for fast/forms/plaintext-mode-2.html
after r117597.

  • platform/efl/test_expectations.txt:
3:35 PM WebInspector edited by wil@marrant.org
(diff)
3:34 PM Changeset in webkit [117647] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; run CSS grid layout tests after r117613.

  • platform/efl/test_expectations.txt:
3:34 PM WebInspector edited by wil@marrant.org
(diff)
3:30 PM Changeset in webkit [117646] by fpizlo@apple.com
  • 79 edits
    4 adds in trunk/Source

DFG should have control flow graph simplification
https://bugs.webkit.org/show_bug.cgi?id=84553

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Merged r115512 from dfgopt.

This change gives the DFG the ability to simplify the control flow graph
as part of an optimization fixpoint that includes CSE, CFA, and constant
folding. This required a number of interesting changes including:

  • Solidifying the set of invariants that the DFG obeys. For example, the head and tail of each basic block must advertise the set of live locals and the set of available locals, respectively. It must do so by referring to the first access to the local in the block (for head) and the last one (for tail). This patch introduces the start of a validation step that may be turned on even with asserts disabled. To ensure that these invariants are preserved, I had to remove the redundant phi elimination phase. For now I just remove the call, but in the future we will probably remove it entirely unless we find a use for it.


  • Making it easier to get the boolean version of a JSValue. This is a pure operation, but we previously did not treat it as such.


  • Fixing the merging and filtering of AbstractValues that correspond to concrete JSValues. This was previously broken and was limiting the effect of running constant folding. Fixing this meant that I had to change how constant folding eliminates GetLocal nodes, so as to ensure that the resulting graph still obeys DFG rules.


  • Introducing simplified getters for some of the things that DFG phases want to know about, like the Nth child of a node (now just graph.child(...) if you don't care about performance too much) or getting successors of a basic block.


The current CFG simplifier can handle almost all of the cases that it
ought to handle; the noteworthy one that is not yet handled is removing
basic blocks that just have jumps. To do this right we need to be able
to remove jump-only blocks that also perform keep-alive on some values.
To make this work, we need to be able to hoist the keep-alive into (or
just above) a Branch. This is not fundamentally difficult but I opted to
let this patch omit this optimization. We can handle this later.

This is a big win on programs that include inline functions that are
often called with constant arguments. Of course, SunSpider, V8, and
Kraken don't count. Those benchmarks are completely neutral with this
change.

  • API/JSValueRef.cpp:

(JSValueToBoolean):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.h:

(JSC::CodeBlock::dfgOSREntryDataForBytecodeIndex):

  • bytecode/Operands.h:

(JSC::Operands::setOperandFirstTime):
(Operands):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::operator!=):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validateIgnoringValue):
(AbstractValue):

  • dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::child):
(JSC::DFG::AdjacencyList::setChild):
(AdjacencyList):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::~BasicBlock):
(BasicBlock):
(JSC::DFG::BasicBlock::numNodes):
(JSC::DFG::BasicBlock::nodeIndex):
(JSC::DFG::BasicBlock::isPhiIndex):
(JSC::DFG::BasicBlock::isInPhis):
(JSC::DFG::BasicBlock::isInBlock):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(DFG):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::run):
(JSC::DFG::CFAPhase::performBlockCFA):
(JSC::DFG::performCFA):

  • dfg/DFGCFAPhase.h:

(DFG):

  • dfg/DFGCFGSimplificationPhase.cpp: Added.

(DFG):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::killUnreachable):
(JSC::DFG::CFGSimplificationPhase::findOperandSource):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::jettisonBlock):
(JSC::DFG::CFGSimplificationPhase::fixPhis):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::OperandSubstitution):
(OperandSubstitution):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::dump):
(JSC::DFG::CFGSimplificationPhase::skipGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
(JSC::DFG::performCFGSimplification):

  • dfg/DFGCFGSimplificationPhase.h: Added.

(DFG):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::run):
(CSEPhase):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(JSC::DFG::performCSE):

  • dfg/DFGCSEPhase.h:

(DFG):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::performConstantFolding):

  • dfg/DFGConstantFoldingPhase.h:

(DFG):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGEdge.h:

(Edge):
(JSC::DFG::Edge::operator UnspecifiedBoolType*):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupBlock):
(JSC::DFG::performFixup):

  • dfg/DFGFixupPhase.h:

(DFG):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::handleSuccessor):
(DFG):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::resetReachability):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::changeIndex):
(Graph):
(JSC::DFG::Graph::changeEdge):
(JSC::DFG::Graph::numSuccessors):
(JSC::DFG::Graph::successor):
(JSC::DFG::Graph::successorForCondition):
(JSC::DFG::Graph::isPredictedNumerical):
(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):
(JSC::DFG::Graph::numChildren):
(JSC::DFG::Graph::child):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToConstant):
(JSC::DFG::Node::numSuccessors):
(Node):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::successorForCondition):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.cpp:

(JSC::DFG::Phase::endPhase):

  • dfg/DFGPhase.h:

(JSC::DFG::runPhase):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::performPredictionPropagation):

  • dfg/DFGPredictionPropagationPhase.h:

(DFG):

  • dfg/DFGRedundantPhiEliminationPhase.cpp:

(JSC::DFG::RedundantPhiEliminationPhase::run):
(JSC::DFG::performRedundantPhiElimination):

  • dfg/DFGRedundantPhiEliminationPhase.h:

(DFG):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):
(ScoreBoard):
(JSC::DFG::ScoreBoard::useIfHasResult):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileRegExpExec):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::nextBlock):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::jump):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp: Added.

(DFG):
(Validate):
(JSC::DFG::Validate::Validate):
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::reportValidationContext):
(JSC::DFG::Validate::dumpData):
(JSC::DFG::Validate::dumpGraphIfAppropriate):
(JSC::DFG::validate):

  • dfg/DFGValidate.h: Added.

(DFG):
(JSC::DFG::validate):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):
(JSC::DFG::performVirtualRegisterAllocation):

  • dfg/DFGVirtualRegisterAllocationPhase.h:

(DFG):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncSome):

  • runtime/BooleanConstructor.cpp:

(JSC::constructBoolean):
(JSC::callBooleanConstructor):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSObject.cpp:

(JSC):

  • runtime/JSObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::toBoolean):

  • runtime/JSString.h:

(JSString):
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

  • runtime/JSValue.h:
  • runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

  • runtime/RegExpConstructor.cpp:

(JSC::setRegExpConstructorMultiline):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

Source/WebCore:

Reviewed by Oliver Hunt.

Merged r115512 from dfgopt.

JSValue::toBoolean(ExecState*) -> JSValue::toBoolean()

No new tests, because no new behavior.

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

  • bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDirectoryEntryCustom.cpp:

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

  • bindings/js/JSDirectoryEntrySyncCustom.cpp:

(WebCore::getFlags):

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::dataFunctionMatrix):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateEventListenerCall):
(GenerateImplementation):
(JSValueToNative):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertValueToJObject):

Source/WebKit/mac:

Reviewed by Oliver Hunt.

Merged r115512 from dfgopt.

JSValue::toBoolean(ExecState*) -> JSValue::toBoolean()

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray):

Source/WebKit2:

Reviewed by Oliver Hunt.

Merged r115512 from dfgopt.

JSValue::toBoolean(ExecState*) -> JSValue::toBoolean()

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

3:27 PM Changeset in webkit [117645] by shawnsingh@chromium.org
  • 4 edits in trunk/Source

[chromium] add back-face visibility check for renderSurfaces
https://bugs.webkit.org/show_bug.cgi?id=86870

Reviewed by Adrienne Walker.

Source/WebCore:

Test added CCLayerTreeHostCommonTest::verifyBackFaceCullingWithPreserves3dForFlatteningSurface

Chromium was not checking back-face visibility for renderSurfaces
that needed it. This patch adds that check and the appropriate
unit test.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerIsInExisting3DRenderingContext):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

3:24 PM Changeset in webkit [117644] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening; unskip a few passing tests.

  • platform/efl/Skipped:
3:22 PM Changeset in webkit [117643] by dpranke@chromium.org
  • 3 edits in trunk/Tools

scm.add() doesn't work properly with svn 1.7
https://bugs.webkit.org/show_bug.cgi?id=86779

Reviewed by Eric Seidel.

Re-land the change in r117526 with a fix to maintain
compatibility with SVN 1.4.4 (yay Leopard!); turns out
that "svn info foo" works correctly in 1.4.4 but
"svn info" from the directory "foo" doesn't if foo is
not part of a checkout. in_working_directory() and
value_from_svn_info() were using the arguments inconsistently,
leading to weird errors.

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM):
(SCM.in_working_directory):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN):
(SVN.in_working_directory):

3:15 PM Changeset in webkit [117642] by leviw@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Moving myself from committer to reviewer.

  • Scripts/webkitpy/common/config/committers.py:
3:15 PM Changeset in webkit [117641] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Remove one-space indentation from LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html
https://bugs.webkit.org/show_bug.cgi?id=86897

Patch by Joe Thomas <joethomas@motorola.com> on 2012-05-18
Reviewed by Tony Chang.

  • fast/backgrounds/background-shorthand-with-backgroundSize-style.html:

2012-05-17 Levi Weintraub <leviw@chromium.org>

Standalone table-columns should be wrapped in anonymous tables
https://bugs.webkit.org/show_bug.cgi?id=86671

Reviewed by Julien Chaffraix.

Adding 2 test cases and updating test results for two with changed expectations.

  • fast/table/table-column-generates-anonymous-table-expected.html: Added.
  • fast/table/table-column-generates-anonymous-table.html: Added.
  • fast/table/table-column-group-generates-anonymous-table-expected.html: Added.
  • fast/table/table-column-group-generates-anonymous-table.html: Added.
  • platform/chromium-linux/fast/forms/form-hides-table-expected.txt: Added. An anonymous

table is now generated to enclose the misparented table column.

  • platform/chromium-linux/fast/table/form-with-table-style-expected.txt: Added.
  • platform/chromium-linux/fast/table/form-with-table-style-expected.png: Modified. The

expectations previously were wrong in that the table column occupied height the
equivalent of its line-height. This is correctly no longer the case.

  • platform/chromium/test_expectations.txt: Modified. Skipping modified tests on other

platforms until I can rebaseline.

3:09 PM Changeset in webkit [117640] by leviw@chromium.org
  • 5 edits
    6 adds in trunk

Standalone table-columns should be wrapped in anonymous tables
https://bugs.webkit.org/show_bug.cgi?id=86671

Reviewed by Julien Chaffraix.

Source/WebCore:

The CSS2 spec specifies that table-columns misparented outside of a table or
table-column-group should be wrapped in an anonymous table. Updating
RenderObject::addChild to follow the spec.
see http://www.w3.org/TR/CSS2/tables.html#anonymous-boxes for details.

Tests: fast/table/table-column-generates-anonymous-table.html

fast/table/table-column-group-generates-anonymous-table.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):

LayoutTests:

Adding 2 test cases and updating test results for two with changed expectations.

  • fast/table/table-column-generates-anonymous-table-expected.html: Added.
  • fast/table/table-column-generates-anonymous-table.html: Added.
  • fast/table/table-column-group-generates-anonymous-table-expected.html: Added.
  • fast/table/table-column-group-generates-anonymous-table.html: Added.
  • platform/chromium-linux/fast/forms/form-hides-table-expected.txt: Added. An anonymous

table is now generated to enclose the misparented table column.

  • platform/chromium-linux/fast/table/form-with-table-style-expected.txt: Added.
  • platform/chromium-linux/fast/table/form-with-table-style-expected.png: Modified. The

expectations previously were wrong in that the table column occupied height the
equivalent of its line-height. This is correctly no longer the case.

  • platform/chromium/test_expectations.txt: Modified. Skipping modified tests on other

platforms until I can rebaseline.

2:57 PM Changeset in webkit [117639] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip grid layout tests that are failing after r117613.

It looks like apple mac had grid layout enabled prior to r117613?
These tests shouldn't have been passing before.

  • platform/mac/test_expectations.txt:
2:50 PM Changeset in webkit [117638] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Validation of Last Fat Finger result is needed for selection.
https://bugs.webkit.org/show_bug.cgi?id=86888

Reviewed by Antonio Gomes.

PR 128393.

Cached FatFingersResults must be validatible against
the desired request to ensure the result is both for
the same point and of the same type.

  • WebKitSupport/FatFingers.h:

(WebKit):
(FatFingersResult):
(BlackBerry::WebKit::FatFingersResult::FatFingersResult):
(BlackBerry::WebKit::FatFingersResult::reset):
(BlackBerry::WebKit::FatFingersResult::resultMatches):
(BlackBerry::WebKit::FatFingersResult::originPosition):
(BlackBerry::WebKit::FatFingersResult::adjustedPosition):
(BlackBerry::WebKit::FatFingersResult::positionWasAdjusted):
(BlackBerry::WebKit::FatFingersResult::isTextInput):
(BlackBerry::WebKit::FatFingersResult::isValid):
(BlackBerry::WebKit::FatFingersResult::node):
(BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectAtPoint):

2:49 PM Changeset in webkit [117637] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):

2:47 PM Changeset in webkit [117636] by fpizlo@apple.com
  • 17 edits
    2 adds in trunk/Source/JavaScriptCore

DFG should have constant propagation
https://bugs.webkit.org/show_bug.cgi?id=84004

Reviewed by Gavin Barraclough.

Merge r114554 from dfgopt.

Changes AbstractValue to be able to hold a "set" of constants, where
the maximum set size is 1 - so merging a value containing constant A
with another value containing constant B where A != B will result in
the AbstractValue claiming that it does not know any constants (i.e.
it'll just have a predicted type and possible a structure).

Added a constant folding phase that uses this new information to
replace pure operations known to have constant results with
JSConstants. This is OSR-exit-aware, in that it will prepend a Phantom
that refers to all of the kids of the node we replaced.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberValue):
(AbstractValue):
(JSC::DFG::AbstractValue::valueIsTop):
(JSC::DFG::AbstractValue::value):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):

  • dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::initialize):
(AdjacencyList):
(JSC::DFG::AdjacencyList::reset):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::constantCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGConstantFoldingPhase.cpp: Added.

(DFG):
(ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::performConstantFolding):

  • dfg/DFGConstantFoldingPhase.h: Added.

(DFG):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::convertToConstant):

  • dfg/DFGInsertionSet.h:

(JSC::DFG::InsertionSet::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToConstant):
(Node):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/JSValue.h:

(JSValue):

2:46 PM Changeset in webkit [117635] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

Support imageSmoothingEnabled
https://bugs.webkit.org/show_bug.cgi?id=82804

Patch by Keyar Hood <keyar@chromium.org> on 2012-05-18
Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/canvas-imageSmoothingEnabled.html

Added the imageSmoothingEnabled parameter to the
CanvasRenderingContext2D object. When it is set to false, it sets
InterpolationQuality to InterpolationNone. When set to true, it sets
the InterpolationQuality to DefaultInterpolationQuality (as that is the
only other value used).

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::webkitImageSmoothingEnabled):
(WebCore):
(WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled):

  • html/canvas/CanvasRenderingContext2D.h:

(CanvasRenderingContext2D):

  • html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

  • fast/canvas/canvas-imageSmoothingEnabled-expected.txt: Added.
  • fast/canvas/canvas-imageSmoothingEnabled.html: Added.
  • fast/canvas/script-tests/canvas-imageSmoothingEnabled.js: Added.
2:45 PM Changeset in webkit [117634] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Missing plugin msg becomes "insecure plugin version" after Real Player page refresh
https://bugs.webkit.org/show_bug.cgi?id=86903
<rdar://problem/11477163>

Reviewed by Andreas Kling.

Set blocked to false before returning early when the plug-in doesn't exist.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::getPluginPath):

2:42 PM Changeset in webkit [117633] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Percentage height replaced elements sometimes cause overflow of table contents
https://bugs.webkit.org/show_bug.cgi?id=85581

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-18
Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/replaced/table-replaced-element.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
This change guarantees that the containing block of a replaced element with percentage
height will be marked as having a percentage height descendant.

LayoutTests:

  • fast/replaced/table-replaced-element-expected.txt: Added.
  • fast/replaced/table-replaced-element.html: Added.

New layout test.

2:39 PM Changeset in webkit [117632] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing mac baselines after r117613.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
2:37 PM Changeset in webkit [117631] by rakuco@webkit.org
  • 7 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Work a bit on the infamous "Needs rebaseline" list by removing a few
tests which are actually passing and updating some expectations.

  • platform/efl/Skipped:
  • platform/efl/fast/forms/caret-rtl-expected.png:
  • platform/efl/fast/forms/caret-rtl-expected.txt:
  • platform/efl/fast/forms/listbox-clip-expected.png:
  • platform/efl/fast/forms/listbox-clip-expected.txt:
  • platform/efl/fast/forms/search-styled-expected.txt:
2:36 PM Changeset in webkit [117630] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] [WK2] Memory leaks in WebKitBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=86872

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-18
Reviewed by Martin Robinson.

Fix memory leaks by adopting WKArray of WebBackForwardListItems
allocations using AdoptWK.

  • UIProcess/API/gtk/WebKitBackForwardList.cpp:

(webkit_back_forward_list_get_back_list):
(webkit_back_forward_list_get_back_list_with_limit):
(webkit_back_forward_list_get_forward_list):
(webkit_back_forward_list_get_forward_list_with_limit):

2:36 PM Changeset in webkit [117629] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build for Qt by using ASSERT_UNUSED in DFGSpeculativeJIT
https://bugs.webkit.org/show_bug.cgi?id=86902

Reviewed by Andreas Kling.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):

2:30 PM Changeset in webkit [117628] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

Spell checker doesn't recognize contractions (apostrophes)
https://bugs.webkit.org/show_bug.cgi?id=86118

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-18
Reviewed by Gustavo Noronha Silva.

The Enchant spell checker was breaking words on apostrophes, because
apparently they were always being detected as Pango word-end
characters. In reality, to know whether or not the apostrophe is a
word end character requires looking at a string with a larger
granularity than one character. In reality, WebCore has already
ensured that any apostrophes in the string belong to contractions by
using the WordBreakIterator.

Simplify the way the we break strings, by just manually trimming off
all non-graphable characters from the string and then finding the end
of the first word by looking for the next non-graphable character.
This has the side effect of removing the dependency on Pango and
eliminating one copy.

This change also cleans up some misbehavior on the part of the
WebCoreSupport layer which was not converting from Unicode character
offsets to UTF-16. These offsets can be different if any of the
characters in the UTF-16 string are surrogate pairs (non BMP
characters).

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString): Properly
convert from Unicode offsets to UTF-16 offsets.

  • webkit/webkitspellcheckerenchant.cpp:

(findByteOffsetToFirstNonGraphableCharacter): Added this helper.
(checkSpellingOfString): Don't split words on apostrophes.

2:24 PM Changeset in webkit [117627] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Fix

ietestcenter/css3/valuesandunits/units-000.htm expectations after
r117609.

2:22 PM Changeset in webkit [117626] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaseline test after r117412.

  • platform/efl/fast/borders/border-antialiasing-expected.png:
  • platform/efl/test_expectations.txt:
2:10 PM Changeset in webkit [117625] by ostapenko.viatcheslav@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r117501): It made almost all tests assert in debug mode
https://bugs.webkit.org/show_bug.cgi?id=86854

Reviewed by Andreas Kling.

Initialize boolean flag in constructor and recheck the flag which can be
modified by another thread under mutex.

No new tests, fixes regression that caused layout test crash.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::syncThreadMainLoop):

2:01 PM Changeset in webkit [117624] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk

[EFL] Web Intents code is not compiling
https://bugs.webkit.org/show_bug.cgi?id=85364

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-18
Reviewed by Adam Barth.

.:

Remove broken CMake directive for WEB_INTENTS.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Add missing implementation for
JSIntentConstructor::constructJSIntent() in JS bindings.

  • CMakeLists.txt:
  • UseJSC.cmake:
  • bindings/js/JSIntentConstructor.cpp: Added.

(WebCore):
(WebCore::JSIntentConstructor::constructJSIntent):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp: Add missing header include.
  • ewk/ewk_intent_private.h: Ditto.
  • ewk/ewk_intent_request.cpp:

(ewk_intent_request_new): Do not PassRefPtr after it becomes 0.

LayoutTests:

Move webintents test cases to test expectations until the needed
features are implemented and Web Intents are enabled by default
for EFL port.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
1:57 PM Changeset in webkit [117623] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

PDF page does not show up when opened in the background
https://bugs.webkit.org/show_bug.cgi?id=86890
<rdar://problem/11259951>

Reviewed by Andreas Kling.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateAcceleratedCompositingMode:WebKit::]):
Just set the new render layer if we're already in accelerated compositing mode.

1:52 PM Changeset in webkit [117622] by commit-queue@webkit.org
  • 5 edits in trunk

background-size specified by a single value in background shorthand fails to parse.
https://bugs.webkit.org/show_bug.cgi?id=86739

Patch by Joe Thomas <joethomas@motorola.com> on 2012-05-18
Reviewed by Tony Chang.

While parsing the background shorthand property, if the second parsedValue is not a valid unit,
parseFillSize should return the first parsedValue instead of failing.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillSize):

LayoutTests:

  • fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
  • fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
1:45 PM Changeset in webkit [117621] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Buildbot output does not print result stats anymore
https://bugs.webkit.org/show_bug.cgi?id=85366

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

Make run-webkit-tests pass --verbose to new-run-webkit-tests
on EFL Debug bot.

  • Scripts/run-webkit-tests:

(runningOnBuildBot):

1:42 PM Changeset in webkit [117620] by fpizlo@apple.com
  • 12 edits
    2 adds in trunk/Source/JavaScriptCore

DFG should have out-of-line slow paths
https://bugs.webkit.org/show_bug.cgi?id=83992

Reviewed by Oliver Hunt.

Merge of r114472 and r114553 from dfgopt.

Introduces the notion of slow path code generation closures in the DFG.
These are defined in DFGSlowPathGenerator.h, though they are fairly
extensible so DFGSpeculativeJIT64.cpp and DFGSpeculativeJIT32_64.cpp
define a couple special-purpose ones. A slow path generation closure
(DFG::SlowPathGenerator) is executed after the main speculative path is
generated. This makes them great for scheduling slow path code out of
the way of the hot paths.

This patch also converts most - but not all - of the DFG to use slow
path generators instead of inline slow paths.

The result is a sub-1% improvement on SunSpider and V8, and a miniscule
regression on Kraken.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
(TrustedImmPtr):
(JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
(TrustedImm32):

  • bytecode/StructureStubInfo.h:
  • dfg/DFGCommon.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(DFG):
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):
(JITCompiler):

  • dfg/DFGSilentRegisterSavePlan.h: Added.

(DFG):
(SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::spillAction):
(JSC::DFG::SilentRegisterSavePlan::fillAction):
(JSC::DFG::SilentRegisterSavePlan::nodeIndex):
(JSC::DFG::SilentRegisterSavePlan::gpr):
(JSC::DFG::SilentRegisterSavePlan::fpr):

  • dfg/DFGSlowPathGenerator.h: Added.

(DFG):
(SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::~SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::generate):
(JSC::DFG::SlowPathGenerator::label):
(JSC::DFG::SlowPathGenerator::call):
(JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::linkFrom):
(JSC::DFG::JumpingSlowPathGenerator::jumpTo):
(CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::call):
(JSC::DFG::CallSlowPathGenerator::setUp):
(JSC::DFG::CallSlowPathGenerator::recordCall):
(JSC::DFG::CallSlowPathGenerator::tearDown):
(CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::generateInternal):
(CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathCall):
(AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathMove):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(DFG):
(JSC::DFG::SpeculativeJIT::~SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

  • dfg/DFGSpeculativeJIT.h:

(DFG):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentSavePlanForFPR):
(JSC::DFG::SpeculativeJIT::silentSpill):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::pickCanTrample):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::generateInternal):
(DFG):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::generateInternal):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::generateInternal):
(DFG):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::generateInternal):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):

1:40 PM Changeset in webkit [117619] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Remove the obsolete AM_PROG_CC_STDC
https://bugs.webkit.org/show_bug.cgi?id=85250

Patch by Adrian Bunk <bunk@stusta.de> on 2012-05-18
Reviewed by Martin Robinson.

  • configure.ac:
1:37 PM Changeset in webkit [117618] by rakuco@webkit.org
  • 2 edits in trunk

[CMake] Unreviewed, remove ENABLE_CSS_GRID_LAYOUT option after r117613.

  • Source/cmake/WebKitFeatures.cmake:
1:36 PM Changeset in webkit [117617] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Default values for ewk_view video tracks settings should be documented
https://bugs.webkit.org/show_bug.cgi?id=85169

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-18
Reviewed by Antonio Gomes.

Document default values for video tracks settings in ewk_view.

  • ewk/ewk_view.h:
1:35 PM Changeset in webkit [117616] by rakuco@webkit.org
  • 8 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Update a few text expectations after r116761 and the jhbuild and
font updates. tables/mozilla is still being skipped, but I will
unskip it after all the new expectations are landed.

  • platform/efl/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug55694-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_caption_align_top-expected.txt:
1:33 PM Changeset in webkit [117615] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Enable web intents flag for chromium build
https://bugs.webkit.org/show_bug.cgi?id=86762

Patch by Greg Billock <gbillock@google.com> on 2012-05-18
Reviewed by Adam Barth.

This flag is enabled in the Chromium-side build.

  • features.gypi:
1:30 PM Changeset in webkit [117614] by haraken@chromium.org
  • 1 edit
    1 delete in trunk/PerformanceTests

[perf-test] Remove Bindings/dom-attributes.html
https://bugs.webkit.org/show_bug.cgi?id=86820

Reviewed by Ryosuke Niwa.

Bindings/dom-attributes.html is just a collection of random
DOM attributes and methods. Now we've added more reasonable
micro benchmarks by classifying DOM binding call paths, we
can remove Bindings/dom-attributes.html.

  • Bindings/dom-attributes.html: Removed.
12:41 PM WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
12:23 PM Changeset in webkit [117613] by tony@chromium.org
  • 77 edits
    2 adds in trunk

remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off
https://bugs.webkit.org/show_bug.cgi?id=86767

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Remove ENABLE_CSS_GRID_LAYOUT.

Source/WebCore:

We disable grid by ignoring the display type at CSS parse time.

Test: fast/css-grid-layout/grid-disabled-by-default.html

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp: Remove compile checks.

(WebCore):
(WebCore::valueForGridPosition):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue): Move display into parseValue.
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue): Ignore while parsing if not enabled.
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::cssGridLayoutEnabled):
(WebCore):

  • css/CSSParser.h:
  • css/CSSParserMode.h:

(CSSParserContext):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • dom/Document.cpp:

(WebCore::Document::cssGridLayoutEnabled): Added to keep track of whether grid is enabled or not.
(WebCore):

  • dom/Document.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setCSSGridLayoutEnabled): Added.
(WebCore::Settings::cssGridLayoutEnabled): Added.
(Settings):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleGridData.cpp:
  • rendering/style/StyleGridData.h:
  • rendering/style/StyleGridItemData.cpp:
  • rendering/style/StyleGridItemData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(WebCore):
(StyleRareNonInheritedData):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setExperimentalCSSGridLayoutEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences cssGridLayoutEnabled]):
(-[WebPreferences setCSSGridLayoutEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCSSGridLayoutEnabled):
(WKPreferencesGetCSSGridLayoutEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::overridePreference):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • fast/css-grid-layout/display-grid-set-get.html: Enable grid layout for the test.
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html: Enable grid layout for the test.
  • fast/css-grid-layout/grid-columns-rows-get-set.html: Enable grid layout for the test.
  • fast/css-grid-layout/grid-disabled-by-default-expected.txt: Added.
  • fast/css-grid-layout/grid-disabled-by-default.html: Added.
  • fast/css-grid-layout/grid-item-column-row-get-set.html: Enable grid layout for the test.
  • platform/chromium/test_expectations.txt: Run grid layout tests.
12:16 PM Changeset in webkit [117612] by mrobinson@webkit.org
  • 12 edits
    1 delete in trunk/Source

OOM running webgl/sdk/tests/conformance/context/context-creation-and-destruction.html
https://bugs.webkit.org/show_bug.cgi?id=80509

Reviewed by Alejandro G. Castro.

Source/WebCore:

No new tests. This is covered by by context-creation-and-destruction.html
Khronos conformance test which will be part of the WebKit repository once
bug 44310 is closed.

Rework the ownership of GLContexts. Instead of having them managed by the
state of window mapping or removed by calling a static method, always have
them owned by the callers. This makes all GLContext creators factory methods
that return PassOwnPtr.

This change also switches the sharing context for a WebView from the window
context to a global shared context. This simplifies things greatly, allowing
the removal of GLContextGtk and makes the factory change easier.

  • GNUmakefile.list.am: Remove GLContextGtk.cpp from the source list.
  • platform/graphics/cairo/GLContext.cpp:

(WebCore::GLContext::sharingContext): Added, getter for the global sharing context.
(WebCore::GLContext::createContextForWindow): Added, a factory method for creating
window contexts.
(WebCore::GLContext::createOffscreenContext): Allow passing a sharing context here.
(WebCore::GLContext::makeContextCurrent): Assert that this is the main thread, to
increase the guarantee that we are only using these contexts on the main thread.
(WebCore::GLContext::getCurrent): Ditto.

  • platform/graphics/cairo/GLContext.h: Update the above method signatures and remove

createOffscreenContext, which has just been subsumed into the other factory methods.

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: The HostWindow is no longer needed

to get the sharing context, so we can simplify things quite a bit and make a platform
independent implementation here.

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Ditto.
  • platform/graphics/glx/GLContextGLX.cpp: Modify all the factory methods to return PassOwnPtr.
  • platform/graphics/glx/GLContextGLX.h: Ditto.
  • platform/graphics/gtk/GLContextGtk.cpp: Removed.

Source/WebKit/gtk:

AcceleratedCompositingContext context now fully owns the GLContext for its
window. This simplifies this quite a bit. We also properly clean it up when
destroying the layer tree, to go more easily on resources.

  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext):

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::glContext):
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):

12:12 PM Changeset in webkit [117611] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Script elements inserted while fragment parsing should have their "already started" flag set.
https://bugs.webkit.org/show_bug.cgi?id=86376

Patch by Pablo Flouret <pablof@motorola.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

Source/WebCore:

Step 3 of:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#scriptTag

Test: fast/parser/script-already-started-flag-in-fragment-parsing-mode.html

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::create):

  • html/HTMLScriptElement.h:

(HTMLScriptElement):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertScriptElement):

LayoutTests:

  • fast/parser/script-already-started-flag-in-fragment-parsing-mode-expected.txt: Added.
  • fast/parser/script-already-started-flag-in-fragment-parsing-mode.html: Added.
11:42 AM Changeset in webkit [117610] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Expose FrameSelection::absoluteCaretBounds via window.internals
https://bugs.webkit.org/show_bug.cgi?id=86390

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

.:

Exports necessary symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

Add 'absoluteCaretBounds' method to Internals, which returns the
FrameSelection::absoluteCaretBounds.

Test: editing/selection/internal-caret-rect.html

  • WebCore.exp.in: Export the necessary symbols.
  • testing/Internals.cpp:

(WebCore::Internals::absoluteCaretBounds): Implementation of new method.
(WebCore):

  • testing/Internals.h: Declare the new method.

(Internals):

  • testing/Internals.idl: Declare the new method.

Source/WebKit2:

Exports necessary symbols.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

A simple test case for the new 'absoluteCaretBounds' method.

  • editing/selection/internal-caret-rect-expected.txt: Added.
  • editing/selection/internal-caret-rect.html: Added.
11:33 AM Changeset in webkit [117609] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding test expectations for a few tests
crashing on the debug builds.

  • platform/gtk/test_expectations.txt:
11:11 AM Changeset in webkit [117608] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Multithreaded compositor unit tests intermittently failing
https://bugs.webkit.org/show_bug.cgi?id=74623

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-18
Reviewed by Adrienne Walker.

The flakiness of the CCLayerTreeHost tests stem from processing tasks after the
tests finish. To fix this, I've disabled the dispatch* methods after endTest is
called, effectively preventing any further tasks scheduled by the tests from
being processed. I have also reworked the checks in
CCLayerTreeHostTestWriteLayersRedraw to make the test more robust.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsAnimate):
(WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsAnimateAndCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchAcquireLayerTextures):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::dispatchSetVisible):
(WTF::CCLayerTreeHostTest::dispatchSetInvisible):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::endTest):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::afterTest):

11:09 AM Changeset in webkit [117607] by mitz@apple.com
  • 4 edits
    2 adds in trunk/Source/WebCore

<rdar://problem/11467250> No focus ring around popup buttons

Reviewed by Anders Carlsson.

The exact same issue was fixed for buttons drawn in ThemeMac.mm in <rdar://problem/10542095>.
This change extends the fix to also cover buttons drawn in RenderThemeMac.mm.

  • WebCore.xcodeproj/project.pbxproj: Added WebCoreNSCellExtras.{h.m}.
  • platform/mac/ThemeMac.mm: Removed the definitions of BUTTON_CELL_DRAW_WITH_FRAME_DRAWS_FOCUS_RING

and -[NSCell _web_drawFocusRingWithFrame:inView:] from here. They are now in WebCoreNSCellExtras.

  • platform/mac/WebCoreNSCellExtras.h: Added.
  • platform/mac/WebCoreNSCellExtras.m: Added.

(-[NSCell _web_drawFocusRingWithFrame:inView:]): Moved from ThemeMac.mm here.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuList): Changed to use -_web_drawFocusRingWithFrame:inView:.
(WebCore::RenderThemeMac::setPopupButtonCellState): Removed call to updateFocusedState() when
the focus ring is drawn separately.

11:02 AM Changeset in webkit [117606] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] Fix early return of the mimeTypeCache function after r117207.

Rubber-stamped by Martin Robinson.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Set

typeListInitialized to true after the cache has been filled so
that next call to the function goes through the early return path.

10:50 AM Changeset in webkit [117605] by mrobinson@webkit.org
  • 5 edits in trunk

Get IndexedDB closer to building for GTK+.

Reviewed by Philippe Normand.

.:

  • configure.ac: Make out the IndexedDB imply USE_LEVELDB, as LevelDB is the

only IndexedDB backend at the moment. Also mark IndexedDB as incomplete.

Source/WebCore:

No new tests. This is only a build fix.

  • GNUmakefile.am: Add the appropriate option to enable LevelDB support.
  • GNUmakefile.list.am: Add missing indexed database files to the source list.
9:56 AM Changeset in webkit [117604] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Removed stale references in the Xcode project after r117369.

  • WebCore.xcodeproj/project.pbxproj: Removed references to CSSStyleDeclaration.cpp.
9:42 AM Changeset in webkit [117603] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Refactor LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html
https://bugs.webkit.org/show_bug.cgi?id=86782

Patch by Joe Thomas <joethomas@motorola.com> on 2012-05-18
Reviewed by Tony Chang.

Refactored the testcase to include round-trip testing.

  • fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
  • fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
9:20 AM Changeset in webkit [117602] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=86859
(r117572) editing/spelling/spellcheck-async-remove-frame.html crashes on Mac

  • platform/mac/Skipped:
9:13 AM Changeset in webkit [117601] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/inspector/front-end/Script.js

Fixing crbug.com/127741: DevTools: [regression] devtools scripts tree is flooded with internal chromium extension scripts.

  • inspector/front-end/Script.js:

TBR=vsevik@chromium.org
BUG=127741
Review URL: https://chromiumcodereview.appspot.com/10409030

9:10 AM Changeset in webkit [117600] by vsevik@chromium.org
  • 17 edits in trunk

Web Inspector: Add resource to UISourceCode constructor.
https://bugs.webkit.org/show_bug.cgi?id=86853

Reviewed by Pavel Feldman.

Source/WebCore:

This is a first step of merging resource revision support into UISourceCode.

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/DebuggerResourceBinding.js:

(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):

  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping.prototype._debuggerReset):

  • inspector/front-end/JavaScriptSource.js:
  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createUISourceCode):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.isAnonymousScript):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StyleSource):
(WebInspector.StyleSourceFrame):
(WebInspector.StyleSourceFrame.prototype.commitEditing):
(WebInspector.StyleSourceFrame.prototype.afterTextChanged):
(WebInspector.StyleSourceFrame.prototype._contentChanged):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.resource):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/ui-source-code.html:
8:57 AM Changeset in webkit [117599] by yurys@chromium.org
  • 4 edits in trunk

Web Inspector: error when expanding an HTMLAllCollection object in the console
https://bugs.webkit.org/show_bug.cgi?id=86741

Reviewed by Pavel Feldman.

Source/WebCore:

RuntimeAgent.callFunctionOn should work correcly with arguments of type HTMLAllCollection.

  • inspector/InjectedScriptSource.js:

LayoutTests:

  • inspector/console/inspect-html-all-collection.html:
8:39 AM Changeset in webkit [117598] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: resource revision content is not rendered properly. Resource content is shown instead.
https://bugs.webkit.org/show_bug.cgi?id=86856

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceRevisionSourceFrame):
(WebInspector.ResourceRevisionSourceFrame.prototype.get resource):

8:38 AM Changeset in webkit [117597] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening failure test cases.
https://bugs.webkit.org/show_bug.cgi?id=86728

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com>, Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-05-18

  • platform/efl/Skipped: removing tests related to editing callbacks functionality.
  • platform/efl/test_expectations.txt: adding new bugs regarding drag'n'drop and spell checking.

Merging tests with particular bugs.

8:34 AM Changeset in webkit [117596] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

fast/events/mouseup-from-button2.html needs a specific expected file for Qt
https://bugs.webkit.org/show_bug.cgi?id=86783

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-18
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/fast/events/mouseup-from-button2-expected.txt: Added.
8:21 AM Changeset in webkit [117595] by Carlos Garcia Campos
  • 5 edits
    1 move in trunk/Source/WebKit2

[GTK] Allow to attach/detach the inspector in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=86823

Reviewed by Gustavo Noronha Silva.

Also rename WebInspectorGtk.cpp as WebInspectorProxyGtk.cpp since
it implements the platform specific methods of WebInspectorProxy.

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseContainerAdd): Allow to add a WebView containing
the inspector as an internal child.
(webkitWebViewBaseContainerRemove): Check whether the widget
removed is the inspector web view.
(webkitWebViewBaseContainerForall): When includeInternals is True,
add also the inspector web view if it's present.
(resizeWebKitWebViewBaseFromAllocation): Allocate space for the
inspector web view if it's present.
(webkitWebViewBaseSetInspectorViewHeight): Private function used
by the inspector proxy to set the height of the inspector web
view.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy): Remove unneeded method windowDestroyed.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp.

(WebKit::inspectorFilesBasePath):
(WebKit::inspectorWindowClosed): Renamed as inspectorWindowClosed
instead of inspectorWindowDestroyed, since this is called when the
window manager requests to close the window, and not when the
widget is destroyed. Also remove the call to windowDestroyed that
has been removed.
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::createInspectorWindow): Helper
function to create the inspector window and add the inspector
view. Also set the inspector window as transient for the
inspected view toplevel window. And use a weak pointer to make
sure inspector window pointer is NULL when it's destroyed, not
only when the window is closed.
(WebKit::WebInspectorProxy::platformOpen): Call platformAttach if
the inspector is opened attached, or createInspectorWindow
otherwise.
(WebKit::WebInspectorProxy::platformDidClose): Always set the view
inspector pointer to NULL.
(WebKit::WebInspectorProxy::platformBringToFront): Implement it by
showing the toplevel window where the inspector view is contained.
(WebKit::WebInspectorProxy::platformIsFront): Implement it by
checking whether the toplevel window where the inspector view is
contained is active or not.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Return
early if there's no inspector window.
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight): Return
the height of the inpected view.
(WebKit::WebInspectorProxy::platformAttach): Remove the view from
the current window if there's one, and insert the inspector view
into the inspected view.
(WebKit::WebInspectorProxy::platformDetach): Remove the inspector
view from the inspected view and create a new window for it if
it's visible.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Call
webkitWebViewBaseSetInspectorViewHeight().

8:19 AM Changeset in webkit [117594] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Return TRUE for events handled to avoid their propagation.

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseButtonPressEvent):
(webkitWebViewBaseButtonReleaseEvent):
(webkitWebViewBaseScrollEvent):
(webkitWebViewBaseMotionNotifyEvent):

7:49 AM Changeset in webkit [117593] by jocelyn.turcotte@nokia.com
  • 2 edits
    17 adds in trunk/LayoutTests

[Qt] Add results for compositing tests dependent on scrollbars thickness.

Reviewed by Csaba Osztrogonác.

Qt's QStyle scrollbar theme has a scrollbar thickness of 16px while
the standard results expect a thickness of 15px.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt: Added.
7:38 AM Changeset in webkit [117592] by commit-queue@webkit.org
  • 9 edits in trunk

[Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
https://bugs.webkit.org/show_bug.cgi?id=86731

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-18
Reviewed by Simon Hausmann.

Source/WebKit2:

Set the page visibility on a single page instead of on all pages
from the page group.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetPageVisibilityState):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPageVisibilityState):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Set the page visibility on a single page instead of on all pages
from the page group.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setPageVisibility):
(WTR::LayoutTestController::resetPageVisibility):

LayoutTests:

Unskip fast/events/page-visibility-iframe-move-test.html.

  • platform/qt-5.0-wk2/Skipped:
7:28 AM Changeset in webkit [117591] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Unskip test after r117218.

  • platform/efl/Skipped:
7:26 AM Changeset in webkit [117590] by yi.4.shen@nokia.com
  • 22 edits
    2 adds in trunk

REGRESSION (r102553): Smart links do not work
https://bugs.webkit.org/show_bug.cgi?id=85463

Source/WebCore:

Reviewed by NOBODY Ryosuke Niwa.

To fix the regression of smart links, we need to check TextCheckingTypeLink option in
Editor::markAndReplaceFor().

Test: editing/inserting/typing-space-to-trigger-smart-link.html

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

Tools:

Reviewed by Ryosuke Niwa.

Add LayoutTestController::setAutomaticLinkDetectionEnabled().

  • DumpRenderTree/LayoutTestController.cpp:

(setAutomaticLinkDetectionEnabledCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Set automatic link detection enabled.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

LayoutTests:

Reviewed by Ryosuke Niwa.

Add a new test for testing the smart link.

  • editing/inserting/typing-space-to-trigger-smart-link-expected.txt: Added.
  • editing/inserting/typing-space-to-trigger-smart-link.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
  • platform/win/Skipped:
7:16 AM Changeset in webkit [117589] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Add shortcut to dump Security Origin and Web Database information
https://bugs.webkit.org/show_bug.cgi?id=86521

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-18
Reviewed by Gustavo Noronha Silva.

Added key combination (CTRL+s) to dump information about the
security origin and databases of the main frame. Useful for API
testing and debugging.

  • EWebLauncher/main.c:

(on_key_down):

7:06 AM Changeset in webkit [117588] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skipped list cleanup.

  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
7:01 AM Changeset in webkit [117587] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: empty CSS Declaration is generated by clicking the left space of 'user agent stylesheet' on Styles sidebar of Elements panel
https://bugs.webkit.org/show_bug.cgi?id=86850

Reviewed by Yury Semikhatsky.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):

6:59 AM Changeset in webkit [117586] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Remove console.error() call committed by mistake.

  • inspector/front-end/View.js:

(WebInspector.View._assert):

6:55 AM Changeset in webkit [117585] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: live edit resets cursor to 0,0
https://bugs.webkit.org/show_bug.cgi?id=86851

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/DebuggerResourceBinding.js:

(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):

6:55 AM Changeset in webkit [117584] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Text input events are emitted for nodes that do not allow editing.
https://bugs.webkit.org/show_bug.cgi?id=86836

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-18
Reviewed by Kenneth Rohde Christiansen.

Text input events are not anymore emitted for nodes that do not allow editing.
This can be checked with fast/events/key-events-in-input-button.html test output.

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::handleEditingKeyboardEvent): Returns false if the node cannot edit.

6:46 AM Changeset in webkit [117583] by commit-queue@webkit.org
  • 13 edits
    1 move in trunk/LayoutTests

Deflaking http/tests/security/contentSecurityPolicy/script-src-redirect.html
https://bugs.webkit.org/show_bug.cgi?id=86433

Patch by Mike West <mkwst@chromium.org> on 2012-05-18
Reviewed by Adam Barth.

As it turns out, this was a straightforward typo on my part. Loading
the wrong JS file is a surefire way to break tests. I've rewritten the
test function to make it more difficult to make such a mistake in the
future, and pushed that change to source-list-parsing-* tests that use
the same methodology.

  • http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/resources/source-list-parsing-base.js.

(test):
(finishTesting):

  • http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-redirect.html:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-01.html:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-02.html:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-03.html:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-04.html:
  • platform/chromium/test_expectations.txt: Unskipping.
  • platform/mac-lion/Skipped: Unskipping.
  • platform/gtk/test_expectations.txt: Unskipping.
  • platform/efl/test_expectations.txt: Unskipping.
  • platform/qt/Skipped: Unskipping.
  • platform/mac/Skipped: Unskipping.
6:43 AM Changeset in webkit [117582] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: exception in console when pressing % button in CPU profile view
https://bugs.webkit.org/show_bug.cgi?id=86849

Reviewed by Pavel Feldman.

Use root node to get children, not DataGrid object.

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileView.prototype.refreshVisibleData):

6:30 AM Changeset in webkit [117581] by yurys@chromium.org
  • 9 edits in trunk

Web Inspector: remove unnecessary indirection from profile types
https://bugs.webkit.org/show_bug.cgi?id=86845

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced CSSProfileHeader and CPUProfileHeader, moved view creation from
the type to corresponding profile headers. Removed some inderection and
private fields assigned in random places. Added type annotations.

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):
(WebInspector.CPUProfileHeader):
(WebInspector.CPUProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.CPUProfileHeader.prototype.createView):

  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.stopRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile):
(WebInspector.CSSSelectorProfileType.prototype.createProfile):
(WebInspector.CSSProfileHeader):
(WebInspector.CSSProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.CSSProfileHeader.prototype.createView):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.createTemporaryProfile):
(WebInspector.HeapSnapshotProfileType.prototype.createProfile):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.HeapProfileHeader.prototype.createView):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype.saveToFile):

  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
(WebInspector.ProfileLauncherView.prototype._profileTypeChanged):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType):
(WebInspector.ProfileHeader):
(WebInspector.ProfileHeader.prototype.profileType):
(WebInspector.ProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.ProfileHeader.prototype.existingView):
(WebInspector.ProfileHeader.prototype.view):
(WebInspector.ProfileHeader.prototype.createView):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype.showProfile):
(WebInspector.ProfilesPanel.prototype.getProfiles):
(WebInspector.ProfilesPanel.prototype.findTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._searchableViews):

  • inspector/front-end/View.js:

(WebInspector.View._assert):

LayoutTests:

  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):

5:42 AM Changeset in webkit [117580] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Cleaning skip list. Unskip passing tests.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-18
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/Skipped:
5:32 AM Changeset in webkit [117579] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8][Refactoring] Remove V8Proxy::throwError(const char*, ErrorType, v8::Isolate*=0)
https://bugs.webkit.org/show_bug.cgi?id=86802

Reviewed by Adam Barth.

As commented here (https://bugs.webkit.org/show_bug.cgi?id=84074#c5),
I am refactoring a series of confusing throwError()s. This would be
the final patch for the refactoring.

This patch removes V8Proxy::throwError(const char*, ErrorType, v8::Isolate*=0).
Also this patch refactors up a couple of throwError()s that I've forgot to
refactor in the previous patches.

No tests. No change in behavior.

  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallback):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

4:28 AM Changeset in webkit [117578] by morrita@google.com
  • 2 edits in trunk/Source/WebKit2

Yet another unreviewed build fix on r117572, this time for wk2...

  • WebProcess/WebCoreSupport/WebEditorClient.h:
4:20 AM Changeset in webkit [117577] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] [DRT] media/media-document-audio-repaint.html needs rebaselining after r117326
https://bugs.webkit.org/show_bug.cgi?id=86839

Unreviewed gardening, EFL rebaseline after r117326.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-18

  • platform/efl/media/media-document-audio-repaint-expected.png:
  • platform/efl/media/media-document-audio-repaint-expected.txt:
4:01 AM Changeset in webkit [117576] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html crashes regularly
https://bugs.webkit.org/show_bug.cgi?id=79656

Unreviewed gardening. Unskip tests, maybe they aren't flakey now.

  • platform/qt-5.0-wk2/Skipped:
3:55 AM Changeset in webkit [117575] by morrita@google.com
  • 10 edits in trunk/Source/WebKit

Another unreviewed attempt to fix build breakage on r117572.

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.h:

(WebKit::EditorClient::frameWillDetachPage):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient::frameWillDetachPage):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::frameWillDetachPage):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::frameWillDetachPage):

3:35 AM Changeset in webkit [117574] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix build breakage on r117572

  • editing/Editor.cpp:

(WebCore::Editor::willDetachPage):

3:30 AM Changeset in webkit [117573] by commit-queue@webkit.org
  • 1 edit
    14 adds in trunk/LayoutTests

[EFL] [DRT] Add baselines for new tests added in r117477 and r117339
https://bugs.webkit.org/show_bug.cgi?id=86834

Unreviewed, add EFL baselines for new tests added in r117477 and
r117339.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-18

  • platform/efl/css2.1/20110323/inline-table-001-expected.png: Added.
  • platform/efl/css2.1/20110323/inline-table-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/inline-table-002a-expected.png: Added.
  • platform/efl/css2.1/20110323/inline-table-002a-expected.txt: Added.
  • platform/efl/css2.1/20110323/inline-table-003-expected.png: Added.
  • platform/efl/css2.1/20110323/inline-table-003-expected.txt: Added.
  • platform/efl/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
  • platform/efl/css2.1/20110323/table-height-algorithm-023-expected.txt: Added.
  • platform/efl/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
  • platform/efl/css2.1/20110323/table-height-algorithm-024-expected.txt: Added.
  • platform/efl/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
  • platform/efl/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
  • platform/efl/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
  • platform/efl/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
3:17 AM Changeset in webkit [117572] by morrita@google.com
  • 27 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=85515
Stale frame in WebCore::SpellChecker::didCheckSucceeded

Source/WebCore:

Reviewed by Ryosuke Niwa.

Added EditorClient::frameWillDetachPage() notification to give a
change to invalidate pending spellcheck requests on the client.

Test: editing/spelling/spellcheck-async-remove-frame.html

  • editing/Editor.cpp:

(WebCore::Editor::Editor):

  • editing/Editor.h:

(Editor):

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::frameWillDetachPage):

  • page/EditorClient.h:

(EditorClient):

Source/WebKit/blackberry:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientBlackBerry.h:

(WebCore::EditorClientBlackBerry::frameWillDetachPage):

Source/WebKit/chromium:

Added WebTextCheckingCompletionImpl::invalidate() to mark
pending spellcheck request as invalid, and added frameWillDetachPage()
to fire it.

Reviewed by Ryosuke Niwa.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::frameWillDetachPage):
(WebKit):
(WebKit::EditorClientImpl::requestCheckingOfString):
(WebKit::EditorClientImpl::didCheckString):

  • src/EditorClientImpl.h:

(WebKit):
(EditorClientImpl):

  • src/WebTextCheckingCompletionImpl.cpp:

(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
(WebKit::WebTextCheckingCompletionImpl::invalidate):
(WebKit):

  • src/WebTextCheckingCompletionImpl.h:

(WebKit):
(WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
(WebTextCheckingCompletionImpl):
(WebKit::WebTextCheckingCompletionImpl::spellChecker):

Source/WebKit/efl:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::frameWillDetachPage):

Source/WebKit/gtk:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientGtk.h:

(WebKit::EditorClient::frameWillDetachPage):

Source/WebKit/mac:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.h:

Source/WebKit/qt:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientQt.h:

(WebCore::EditorClientQt::frameWillDetachPage):

Source/WebKit/win:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient::frameWillDetachPage):

Source/WebKit/wince:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::frameWillDetachPage):

Source/WebKit/wx:

Reviewed by Ryosuke Niwa.

  • WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::frameWillDetachPage):

LayoutTests:

Reviewed by Ryosuke Niwa.

  • editing/spelling/spellcheck-async-remove-frame-expected.txt: Added.
  • editing/spelling/spellcheck-async-remove-frame.html: Added.
3:10 AM Changeset in webkit [117571] by pfeldman@chromium.org
  • 18 edits in trunk

Web Inspector: add ContentProvider::contentType and use it when rendering navigator tree.
https://bugs.webkit.org/show_bug.cgi?id=86833

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Added ContentProvider::contentType, regactored NavigatorView to use the icon defined by the content type.

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/ContentProvider.js:

(WebInspector.ContentProvider.prototype.contentType):

  • inspector/front-end/ContentProviders.js:

(WebInspector.ConcatenatedScriptsContentProvider.prototype.contentType):
(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.CompilerSourceMappingContentProvider.prototype.contentType):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider):
(WebInspector.StaticContentProvider.prototype.contentType):
(WebInspector.StaticContentProvider.prototype.requestContent):

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorTreeOutline.prototype.scriptTreeElements):
(WebInspector.NavigatorSourceTreeElement):

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.contentType):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.contentType):
(WebInspector.Resource.prototype.canonicalMimeType):
(WebInspector.ResourceRevision.prototype.contentType):

  • inspector/front-end/ResourceType.js:

(WebInspector.ResourceType.prototype.toString):
(WebInspector.ResourceType.prototype.canonicalMimeType):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.contentType):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.SnippetContentProvider):

  • inspector/front-end/StylesPanel.js:
  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.contentType):

  • inspector/front-end/navigatorView.css:

(.navigator-stylesheet-tree-item .icon):
(.navigator-document-tree-item .icon):

LayoutTests:

  • http/tests/inspector/search/search-in-static.html:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
3:01 AM TestExpectationsProposal edited by zandobersek@gmail.com
(diff)
2:49 AM Changeset in webkit [117570] by rniwa@webkit.org
  • 171 edits in trunk/LayoutTests

Unreviewed, rolling out r117559.
http://trac.webkit.org/changeset/117559

Wrong rebaseline per rolling out 117556

  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-submit-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-in-malformed-markup-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/range-thumb-height-percentage-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.txt:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
2:23 AM Changeset in webkit [117569] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a binding benchmark for getElementById() for an undefined id
https://bugs.webkit.org/show_bug.cgi?id=86812

Reviewed by Ryosuke Niwa.

We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

This patch adds a benchmark for document.getElementById() for an undefined id.
This benchmark covers 'getElementById (not in document)' in Dromaeo/dom-query.html,
and other Node-query methods that return a null.'

(Note: This benchmark is slower than document.getElementById() for a defined id.
We will fix the performance issue soon.)

Test results in my Linux desktop:

RESULT Bindings: undefined-get-element-by-id= 271.945751345 runs/s
median= 273.122389532 runs/s, stdev= 6.78219237299 runs/s, min= 257.4002574 runs/s, max= 281.690140845 runs/s

RESULT Bindings: undefined-get-element-by-id= 269.105872408 runs/s
median= 268.948655257 runs/s, stdev= 5.73707323755 runs/s, min= 257.4002574 runs/s, max= 278.128950695 runs/s

RESULT Bindings: undefined-get-element-by-id= 269.987513372 runs/s
median= 272.952853598 runs/s, stdev= 5.30252336078 runs/s, min= 255.754475703 runs/s, max= 273.97260274 runs/s

RESULT Bindings: undefined-get-element-by-id= 270.169625901 runs/s
median= 271.604938272 runs/s, stdev= 5.29502391906 runs/s, min= 258.064516129 runs/s, max= 278.481012658 runs/s

RESULT Bindings: undefined-get-element-by-id= 269.054631422 runs/s
median= 267.966292802 runs/s, stdev= 6.27197240579 runs/s, min= 258.064516129 runs/s, max= 278.481012658 runs/s

  • Bindings/undefined-get-element-by-id.html: Added.
2:20 AM Changeset in webkit [117568] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a binding benchmark for getElementsByTagName()
https://bugs.webkit.org/show_bug.cgi?id=86810

Reviewed by Ryosuke Niwa.

We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

This patch adds a benchmark for document.getElementsByTagName().
This benchmark covers 'getElementsByTagName (not in document)',
'getElementsByTagName', 'getElementsByName (not in document)'
and 'getElementsByName' in Dromaeo/dom-query.html, and other DOM
methods that return a NodeList.

Test results in my Linux desktop:

RESULT Bindings: get-elements-by-tag-name= 364.542328875 runs/s
median= 366.972477064 runs/s, stdev= 5.25387955333 runs/s, min= 351.317440402 runs/s, max= 368.421052632 runs/s

RESULT Bindings: get-elements-by-tag-name= 364.341569369 runs/s
median= 366.492146597 runs/s, stdev= 4.867374197 runs/s, min= 352.644836272 runs/s, max= 367.936925099 runs/s

RESULT Bindings: get-elements-by-tag-name= 363.924242967 runs/s
median= 366.013071895 runs/s, stdev= 5.16768212289 runs/s, min= 351.317440402 runs/s, max= 367.936925099 runs/s

RESULT Bindings: get-elements-by-tag-name= 365.332594438 runs/s
median= 367.454068241 runs/s, stdev= 6.17046918572 runs/s, min= 350.0 runs/s, max= 370.37037037 runs/s

RESULT Bindings: get-elements-by-tag-name= 363.999514324 runs/s
median= 366.492146597 runs/s, stdev= 5.31235674905 runs/s, min= 350.877192982 runs/s, max= 368.421052632 runs/s

  • Bindings/get-elements-by-tag-name.html: Added.
2:08 AM Changeset in webkit [117567] by commit-queue@webkit.org
  • 10 edits in trunk/LayoutTests

Unreviewed, rolling out r117558.
http://trac.webkit.org/changeset/117558
https://bugs.webkit.org/show_bug.cgi?id=86827

Wrong rebaseline per rolling out 117556 (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-18

  • platform/mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • svg/custom/svg-fonts-in-text-controls-expected.txt:
2:03 AM Changeset in webkit [117566] by rniwa@webkit.org
  • 153 edits in trunk/LayoutTests

Unreviewed, rolling out r117557.
http://trac.webkit.org/changeset/117557
https://bugs.webkit.org/show_bug.cgi?id=86826

Wrong rebaseline per rolling out 117556 (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-18

  • platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/mac/editing/inserting/before-after-input-element-expected.txt:
  • platform/mac/editing/pasteboard/4806874-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.png:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/dom/isindex-001-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.png:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/basic-inputs-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/encoding-test-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.png:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-visibility-expected.txt:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.txt:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-field-text-truncated-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-readonly-empty-expected.txt:
  • platform/mac/fast/forms/input-spaces-expected.txt:
  • platform/mac/fast/forms/input-table-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/input-text-word-wrap-expected.txt:
  • platform/mac/fast/forms/input-type-text-min-width-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/input-width-expected.txt:
  • platform/mac/fast/forms/minWidthPercent-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/select-empty-option-height-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/mac/fast/forms/text-style-color-expected.png:
  • platform/mac/fast/forms/text-style-color-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.png:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/replaced/width100percent-textfield-expected.txt:
  • platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/mac/fast/table/003-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/spanOverlapRepaint-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla/other/move_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
2:00 AM Changeset in webkit [117565] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r117556.
http://trac.webkit.org/changeset/117556
https://bugs.webkit.org/show_bug.cgi?id=86825

Wrong fix. IE still adds 1px padding. We're missing that in
textarea (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-18

Source/WebCore:

  • css/html.css:

(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

LayoutTests:

  • fast/forms/input-textarea-padding-match-expected.html: Removed.
  • fast/forms/input-textarea-padding-match.html: Removed.
1:53 AM Changeset in webkit [117564] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: remove File abstraction from the AdvancedSearchController, migrate it to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=86809

Reviewed by Yury Semikhatsky.

This change migrates AdvancedSearchController from "Object" to "UISourceCode".
I don't see why we need this abstraction and as a side effect, it makes search
across scripts work for styles.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._createAnchor):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._appendSearchMatches):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):
(WebInspector.FileBasedSearchResultsPane.SearchResult):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope.prototype.createSearchResultsPane):

  • inspector/front-end/inspector.js:

(WebInspector._registerShortcuts):

1:40 AM Changeset in webkit [117563] by haraken@chromium.org
  • 1 edit
    7 adds in trunk/PerformanceTests

[perf-test] Add 7 micro benchmarks for DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=86816

Reviewed by Ryosuke Niwa.

We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.
This patch adds seven micro benchmarks for DOM bindings.

id-getter.html covers 'element.property' in Dromaeo/dom-attr.html,
'innerHTML' in Dromaeo/dom-modify.html, and other DOM attributes that
return a String.

id-setter.html covers 'element.property = value' in Dromaeo/dom-attr.html,
and other DOM attributes that sets a String.

undefined-id-getter.html covers undefined DOM attributes that return an empty String.

append-child.html covers 'appendChild' and 'removeChild' in Dromaeo/dom-modify.html.

insert-before.html covers 'insertBefore' in Dromaeo/dom-modify.html and replaceChild().

create-element.html covers 'createElement', 'createTextNode' and 'cloneNode'
in Dromaeo/dom-modify.html, and other DOM methods that return a new Node object.

node-list-access.html covers 'childNodes' in Dromaeo/dom-traverse.html,
and other DOM attributes that access NodeList.

Test results in my Linux desktop:

[id-getter]
RESULT Bindings: id-getter= 550.517821097 runs/s
median= 550.688360451 runs/s, stdev= 0.970723739106 runs/s, min= 548.628428928 runs/s, max= 552.070263488 runs/s

RESULT Bindings: id-getter= 550.655839847 runs/s
median= 550.688360451 runs/s, stdev= 1.03312821884 runs/s, min= 549.313358302 runs/s, max= 552.070263488 runs/s

RESULT Bindings: id-getter= 550.277753355 runs/s
median= 550.344180225 runs/s, stdev= 1.19960683464 runs/s, min= 547.945205479 runs/s, max= 552.070263488 runs/s

RESULT Bindings: id-getter= 550.072271009 runs/s
median= 550.344180225 runs/s, stdev= 1.38925152131 runs/s, min= 547.263681592 runs/s, max= 552.070263488 runs/s

RESULT Bindings: id-getter= 548.802050235 runs/s
median= 548.628428928 runs/s, stdev= 1.18244513683 runs/s, min= 545.905707196 runs/s, max= 550.688360451 runs/s

[id-setter]
RESULT Bindings: id-setter= 211.370591663 runs/s
median= 210.803689065 runs/s, stdev= 1.4555795889 runs/s, min= 209.973753281 runs/s, max= 214.285714286 runs/s

RESULT Bindings: id-setter= 215.439081352 runs/s
median= 214.797136038 runs/s, stdev= 1.50920388121 runs/s, min= 213.049267643 runs/s, max= 218.446601942 runs/s

RESULT Bindings: id-setter= 216.721698466 runs/s
median= 215.956886352 runs/s, stdev= 1.54090749644 runs/s, min= 214.285714286 runs/s, max= 219.78021978 runs/s

RESULT Bindings: id-setter= 216.343019087 runs/s
median= 215.827338129 runs/s, stdev= 1.46619894553 runs/s, min= 215.053763441 runs/s, max= 218.97810219 runs/s

RESULT Bindings: id-setter= 216.799288017 runs/s
median= 215.956886352 runs/s, stdev= 1.49100776978 runs/s, min= 215.311004785 runs/s, max= 219.78021978 runs/s

[undefined-id-getter]
RESULT Bindings: undefined-id-getter= 494.104255241 runs/s
median= 494.132368875 runs/s, stdev= 1.13092821109 runs/s, min= 490.797546012 runs/s, max= 495.662949195 runs/s

RESULT Bindings: undefined-id-getter= 493.921802916 runs/s
median= 493.827160494 runs/s, stdev= 1.25097443119 runs/s, min= 490.196078431 runs/s, max= 495.662949195 runs/s

RESULT Bindings: undefined-id-getter= 491.976485667 runs/s
median= 492.004920049 runs/s, stdev= 0.947090576896 runs/s, min= 490.196078431 runs/s, max= 493.827160494 runs/s

RESULT Bindings: undefined-id-getter= 491.987710185 runs/s
median= 494.132368875 runs/s, stdev= 8.66602543327 runs/s, min= 454.545454545 runs/s, max= 495.662949195 runs/s

RESULT Bindings: undefined-id-getter= 494.195515847 runs/s
median= 494.437577256 runs/s, stdev= 1.06135681702 runs/s, min= 490.797546012 runs/s, max= 495.662949195 runs/s

[append-child]
RESULT Bindings: append-child= 260.628237026 runs/s
median= 260.926399352 runs/s, stdev= 2.55231060598 runs/s, min= 256.739409499 runs/s, max= 265.604249668 runs/s

RESULT Bindings: append-child= 280.796193436 runs/s
median= 280.791435348 runs/s, stdev= 2.53961321867 runs/s, min= 277.427490542 runs/s, max= 286.085825748 runs/s

RESULT Bindings: append-child= 279.856209714 runs/s
median= 280.25477707 runs/s, stdev= 2.85447647301 runs/s, min= 275.344180225 runs/s, max= 284.237726098 runs/s

RESULT Bindings: append-child= 280.834502714 runs/s
median= 280.25477707 runs/s, stdev= 2.67738046429 runs/s, min= 277.427490542 runs/s, max= 287.206266319 runs/s

RESULT Bindings: append-child= 274.723872106 runs/s
median= 273.291925466 runs/s, stdev= 3.03671746706 runs/s, min= 272.614622057 runs/s, max= 282.413350449 runs/s

[insert-before]
RESULT Bindings: insert-before= 180.986913006 runs/s
median= 180.878552972 runs/s, stdev= 0.758038687299 runs/s, min= 180.18018018 runs/s, max= 183.968462549 runs/s

RESULT Bindings: insert-before= 186.339916144 runs/s
median= 186.170212766 runs/s, stdev= 0.869022097127 runs/s, min= 185.676392573 runs/s, max= 189.798339265 runs/s

RESULT Bindings: insert-before= 189.45344838 runs/s
median= 189.349112426 runs/s, stdev= 0.811854866567 runs/s, min= 187.79342723 runs/s, max= 192.539109507 runs/s

RESULT Bindings: insert-before= 189.363295991 runs/s
median= 189.349112426 runs/s, stdev= 0.75387713097 runs/s, min= 188.014101058 runs/s, max= 192.076830732 runs/s

RESULT Bindings: insert-before= 189.252041642 runs/s
median= 189.349112426 runs/s, stdev= 0.840447225363 runs/s, min= 187.573270809 runs/s, max= 192.076830732 runs/s

[create-element]
RESULT Bindings: create-element= 280.675830077 runs/s
median= 280.701824914 runs/s, stdev= 0.788606343054 runs/s, min= 279.441117764 runs/s, max= 282.542885974 runs/s

RESULT Bindings: create-element= 276.427631436 runs/s
median= 277.227722772 runs/s, stdev= 3.39874667549 runs/s, min= 262.417994377 runs/s, max= 279.162512463 runs/s

RESULT Bindings: create-element= 277.156894411 runs/s
median= 277.227722772 runs/s, stdev= 1.13255119226 runs/s, min= 274.914089347 runs/s, max= 278.884462151 runs/s

RESULT Bindings: create-element= 278.066825356 runs/s
median= 278.191822254 runs/s, stdev= 0.686497782792 runs/s, min= 276.953511375 runs/s, max= 279.162512463 runs/s

RESULT Bindings: create-element= 276.431538109 runs/s
median= 276.406712734 runs/s, stdev= 0.759593662298 runs/s, min= 275.229357798 runs/s, max= 278.053624628 runs/s

[node-list-access]
RESULT Bindings: node-list-access= 222.747504073 runs/s
median= 222.772277228 runs/s, stdev= 0.789027527555 runs/s, min= 221.674876847 runs/s, max= 224.159402242 runs/s

RESULT Bindings: node-list-access= 220.722448287 runs/s
median= 221.266217576 runs/s, stdev= 1.65463497875 runs/s, min= 217.391304348 runs/s, max= 222.222222222 runs/s

RESULT Bindings: node-list-access= 222.195870443 runs/s
median= 222.222222222 runs/s, stdev= 0.489709262091 runs/s, min= 221.13022113 runs/s, max= 223.048327138 runs/s

RESULT Bindings: node-list-access= 221.431121677 runs/s
median= 221.538545435 runs/s, stdev= 0.608292116087 runs/s, min= 220.048899756 runs/s, max= 222.772277228 runs/s

RESULT Bindings: node-list-access= 219.001367135 runs/s
median= 221.538545435 runs/s, stdev= 4.65773933007 runs/s, min= 209.973753281 runs/s, max= 222.496909765 runs/s

  • Bindings/append-child.html: Added.
  • Bindings/create-element.html: Added.
  • Bindings/id-getter.html: Added.
  • Bindings/id-setter.html: Added.
  • Bindings/insert-before.html: Added.
  • Bindings/node-list-access.html: Added.
  • Bindings/undefined-id-getter.html: Added.
1:25 AM Changeset in webkit [117562] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add an option to show last N hidden children of node in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=86757

Reviewed by Pavel Feldman.

Renamed "Show next N" to "Show N before" and added "Show N after" button. Also
when all 3 buttons would have equal effect there is now only "Show all N" button.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ShowMoreDataGridNode.js:

(WebInspector.ShowMoreDataGridNode):
(WebInspector.ShowMoreDataGridNode.prototype._showLastChunk):
(WebInspector.ShowMoreDataGridNode.prototype._updateLabels):
(WebInspector.ShowMoreDataGridNode.prototype.createCells):

1:15 AM Changeset in webkit [117561] by commit-queue@webkit.org
  • 9 edits
    2 adds
    1 delete in trunk

[EFL] DRT needs an implementation of layoutTestController.setSerializeHTTPLoads
https://bugs.webkit.org/show_bug.cgi?id=86101

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

Source/WebKit/efl:

Add missing implementation setSerializeHTTPLoads to EFL's
DumpRenderTreeSupport to allow testing resource load order.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setSerializeHTTPLoads):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation setSerializeHTTPLoads to allow
testing resource load order.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setSerializeHTTPLoads):

LayoutTests:

Unskip test cases which rely on LayoutTestController's setSerializeHTTPLoads
implementation and add EFL expectations for tests same as in mac port (MIME
type is "application/javascript" instead of "application/x-javascript").

  • platform/efl/Skipped:
  • platform/efl/fast/loader/file-protocol-fragment-expected.txt: Removed. The current

result matches the base expectation, so removed the platform-specific results.

  • platform/efl/fast/preloader/document-write-2-expected.txt: Added.
  • platform/efl/fast/preloader/document-write-expected.txt: Added.
  • platform/efl/test_expectations.txt:
1:12 AM Changeset in webkit [117560] by jochen@chromium.org
  • 8 edits in trunk

Source/WebKit/chromium: [chromium] plumb the frame for which a drag was initiated to the WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=86670

Reviewed by Kent Tamura.

  • public/WebViewClient.h:

(WebKit::WebViewClient::startDragging):
(WebViewClient):

  • src/DragClientImpl.cpp:

(WebKit::DragClientImpl::startDrag):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::startDragging):

  • src/WebViewImpl.h:

(WebViewImpl):

Tools: [chromium] plumb the frame for which a drag was initiated to the WebViewClient

https://bugs.webkit.org/show_bug.cgi?id=86670

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::startDragging):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

1:04 AM TestExpectationsProposal edited by mjs@apple.com
(diff)
12:53 AM TestExpectationsProposal edited by mjs@apple.com
(diff)
12:51 AM TestExpectationsProposal edited by mjs@apple.com
(diff)
12:50 AM TestExpectationsProposal edited by mjs@apple.com
(diff)
12:49 AM TestExpectationsProposal created by mjs@apple.com
12:48 AM Changeset in webkit [117559] by rniwa@webkit.org
  • 171 edits in trunk/LayoutTests

Chromium Mac rebaseline after r117556.

  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-submit-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-in-malformed-markup-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/range-thumb-height-percentage-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.txt:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
12:46 AM Changeset in webkit [117558] by rniwa@webkit.org
  • 10 edits in trunk/LayoutTests

SnowLeopard and SVG rebaselines after r117556.

  • platform/mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • svg/custom/svg-fonts-in-text-controls-expected.txt:
12:44 AM Changeset in webkit [117557] by rniwa@webkit.org
  • 153 edits in trunk/LayoutTests

Mac rebaseline after r117556.

  • platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/mac/editing/inserting/before-after-input-element-expected.txt:
  • platform/mac/editing/pasteboard/4806874-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.png:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/dom/isindex-001-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.png:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/basic-inputs-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/encoding-test-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.png:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-visibility-expected.txt:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.txt:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-field-text-truncated-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-readonly-empty-expected.txt:
  • platform/mac/fast/forms/input-spaces-expected.txt:
  • platform/mac/fast/forms/input-table-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/input-text-word-wrap-expected.txt:
  • platform/mac/fast/forms/input-type-text-min-width-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/input-width-expected.txt:
  • platform/mac/fast/forms/minWidthPercent-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/select-empty-option-height-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/mac/fast/forms/text-style-color-expected.png:
  • platform/mac/fast/forms/text-style-color-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.png:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/replaced/width100percent-textfield-expected.txt:
  • platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/mac/fast/table/003-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/spanOverlapRepaint-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla/other/move_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
12:42 AM Changeset in webkit [117556] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

WebKit erroneously add 1px padding in input elements
https://bugs.webkit.org/show_bug.cgi?id=86784

Reviewed by Kent Tamura.

Source/WebCore:

Fixed the bug by removing the code that added left and right paddings in input elements.
The code was added in r13567 to match a very old version of Internet Explorer but this quirk
does not seem to exists in IE9 (both in quirks and standard modes).

A lot of tests need to be rebaselined due to 1px difference inside input elements, and 2px
differences for the width of input elements. (In some extreme cases, line breaking changed
due to the width change).

Test: fast/forms/input-textarea-padding-match.html

  • css/html.css:

(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

LayoutTests:

Add a regression.

Also rebaseline tests in separate commits per getting rid of extra 1px padding on left and right.
Input elements' widths got shrunk by 2px in most cases and the text moved 1px to the start
(left for LTR and right for RTL).

  • fast/forms/input-textarea-padding-match-expected.html: Added.
  • fast/forms/input-textarea-padding-match.html: Added.
12:37 AM Changeset in webkit [117555] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

[Qt] Gesture tap highlighter needs to take overflow clip into account.
https://bugs.webkit.org/show_bug.cgi?id=84989

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-18
Reviewed by Kenneth Rohde Christiansen.

.:

  • ManualTests/qt/tap-highlighting-overflow-hidden.html: Added.

Source/WebCore:

Apply overflow clip on the focus ring if needed.

Follow up patches are needed to address the following cases.

[Qt] Gesture tap highlighter should take parent iframe's transform into account.
https://bugs.webkit.org/show_bug.cgi?id=86645

[Qt] Gesture tap highlighter needs to take frame clipping into account.
https://bugs.webkit.org/show_bug.cgi?id=86646

[Qt] Gesture tap highlighter's overflow clip is not always correct when
nested enclosing containers have transforms.
https://bugs.webkit.org/show_bug.cgi?id=86641

Manual test: ManualTests/qt/tap-highlighting-overflow-hidden.html

  • page/GestureTapHighlighter.cpp:

(WebCore::GestureTapHighlighter::pathForNodeHighlight):

12:29 AM Changeset in webkit [117554] by rniwa@webkit.org
  • 5 edits
    1 delete in trunk/LayoutTests

Chromium rebaselines.

  • platform/chromium-mac-leopard/fast/lists/003-vertical-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10296-1-expected.txt: Removed.
  • platform/chromium-mac/fast/lists/003-vertical-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.txt:
12:20 AM Changeset in webkit [117553] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a binding benchmark for div.setAttribute()
https://bugs.webkit.org/show_bug.cgi?id=86815

Reviewed by Ryosuke Niwa.

We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

This patch adds a benchmark for div.setAttribute(). This benchmark
covers 'setAttribute' in Dromaeo/dom-attr.html and other DOM methods
that return an undefined.

Test results in my Linux desktop:

RESULT Bindings: set-attribute= 793.745073252 runs/s
median= 791.589665765 runs/s, stdev= 6.00467159709 runs/s, min= 785.27607362 runs/s, max= 808.080808081 runs/s

RESULT Bindings: set-attribute= 790.858444164 runs/s
median= 787.918921436 runs/s, stdev= 7.86264953655 runs/s, min= 780.234070221 runs/s, max= 806.04534005 runs/s

RESULT Bindings: set-attribute= 787.277571417 runs/s
median= 784.31372549 runs/s, stdev= 7.45363346657 runs/s, min= 778.588807786 runs/s, max= 804.020100503 runs/s

RESULT Bindings: set-attribute= 782.401393791 runs/s
median= 779.062978802 runs/s, stdev= 6.48250081621 runs/s, min= 777.642770352 runs/s, max= 796.019900498 runs/s

RESULT Bindings: set-attribute= 791.792516608 runs/s
median= 791.556728232 runs/s, stdev= 6.49182980397 runs/s, min= 779.220779221 runs/s, max= 808.080808081 runs/s

  • Bindings/set-attribute.html: Added.
12:06 AM Changeset in webkit [117552] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] appcache tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86619

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-18
Reviewed by Ryosuke Niwa.

Source/WebKit/efl:

No longer set the application cache path in ewk_main since the
path can only be set once and this prevents DRT (or apps) to set
it. Update the ewk_settings documentation to reflect these
changes.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

  • ewk/ewk_settings.h:

Tools:

Correctly set the application cache database path in EFL's
DumpRenderTree initialization code.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::initialize):

12:03 AM Changeset in webkit [117551] by commit-queue@webkit.org
  • 11 edits
    5 adds in trunk

[EFL] Add simple implementation of Web Intents
https://bugs.webkit.org/show_bug.cgi?id=86354

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-18
Reviewed by Eric Seidel.

.:

Enable WEB_INTENTS flag by default on EFL port.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit:

Add new ewk_intent.* and ewk_intent_request.* files to CMake.

  • CMakeLists.txt:
  • PlatformEfl.cmake:

Source/WebKit/efl:

Add new EFL wrappers for WebCore's Intent and IntentRequest.
Implement dispatchIntent() in EFL's FrameLoaderClient and emit a new
"intent,new" signal on the frame to notify clients of new intent
requests.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore):
(WebCore::FrameLoaderClientEfl::dispatchIntent):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

  • ewk/ewk_frame.cpp:

(ewk_frame_intent_new):

  • ewk/ewk_frame.h:
  • ewk/ewk_frame_private.h:
  • ewk/ewk_intent.cpp: Added.

(_Ewk_Intent):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_data_get):
(ewk_intent_service_get):
(ewk_intent_extra_get):
(ewk_intent_new):
(ewk_intent_free):

  • ewk/ewk_intent.h: Added.
  • ewk/ewk_intent_private.h: Added.

(WebCore):

  • ewk/ewk_intent_request.cpp: Added.

(_Ewk_Intent_Request):
(ewk_intent_request_ref):
(ewk_intent_request_unref):
(ewk_intent_request_intent_get):
(ewk_intent_request_result_post):
(ewk_intent_request_failure_post):
(ewk_intent_request_new):

  • ewk/ewk_intent_request.h: Added.

May 17, 2012:

11:49 PM Changeset in webkit [117550] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a binding benchmark for div.getAttribute()
https://bugs.webkit.org/show_bug.cgi?id=86814

Reviewed by Ryosuke Niwa.

We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

This patch adds a benchmark for div.getAttribute(). This benchmark
covers 'getAttribute' in Dromaeo/dom-attr.html, and other DOM methods
that return a String.

Test results in my Linux desktop:

RESULT Bindings: get-attribute= 250.088158538 runs/s
median= 250.469728765 runs/s, stdev= 4.66551901315 runs/s, min= 240.673886883 runs/s, max= 256.739409499 runs/s

RESULT Bindings: get-attribute= 250.209764698 runs/s
median= 250.626959986 runs/s, stdev= 4.12030002477 runs/s, min= 241.254523522 runs/s, max= 255.102040816 runs/s

RESULT Bindings: get-attribute= 248.907532887 runs/s
median= 250.312891114 runs/s, stdev= 3.23173125874 runs/s, min= 240.673886883 runs/s, max= 251.572327044 runs/s

RESULT Bindings: get-attribute= 250.243680844 runs/s
median= 250.783797637 runs/s, stdev= 4.19327170024 runs/s, min= 240.963855422 runs/s, max= 255.102040816 runs/s

RESULT Bindings: get-attribute= 245.329046608 runs/s
median= 244.948040416 runs/s, stdev= 2.24314248534 runs/s, min= 240.384615385 runs/s, max= 248.756218905 runs/s

  • Bindings/get-attribute.html: Added.
11:32 PM Changeset in webkit [117549] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] KURL::fileSystemPath() should strip the query of the uri
https://bugs.webkit.org/show_bug.cgi?id=86721

Reviewed by Martin Robinson.

  • platform/gtk/KURLGtk.cpp:

(WebCore::KURL::fileSystemPath): Use the already parsed path to
create the GFile instead of the whole URL string. The parsed path
doesn't include neither the fragment (#) nor the query (?) parts.

11:29 PM Changeset in webkit [117548] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a binding benchmark for getElementById()
https://bugs.webkit.org/show_bug.cgi?id=86808

Reviewed by Ryosuke Niwa.

Currently Bindings/dom-attributes.html is just a collection
of random DOM attributes and methods. We should remove it and
instead add more reasonable micro benchmarks by classifying
DOM binding call paths.

This patch adds a benchmark for document.getElementById(),
which covers other DOM methods that return a Node Object.

The reason why we want to add a benchmark for document.getElementById()
in spite of the fact that Dromaeo/dom-query.html is already testing
document.getElementById(), is that Dromaeo/dom-query.html outputs one
result for several benchmarks (i.e. getElementById().nodeType,
getElementsByTagName()[0].nodeType etc), and thus we cannot observe
regression of getElementById() itself. (Catching regression of
getElementById() would be critical.)

Test results in my Linux desktop:

RESULT Bindings: get-element-by-id= 300.933707795 runs/s
median= 302.267002519 runs/s, stdev= 3.04954648504 runs/s, min= 295.930949445 runs/s, max= 305.34351145 runs/s

RESULT Bindings: get-element-by-id= 302.030324483 runs/s
median= 302.267481977 runs/s, stdev= 1.78518068367 runs/s, min= 298.507462687 runs/s, max= 304.568527919 runs/s

RESULT Bindings: get-element-by-id= 301.993483538 runs/s
median= 302.648171501 runs/s, stdev= 1.87604126626 runs/s, min= 296.662546354 runs/s, max= 304.568527919 runs/s

RESULT Bindings: get-element-by-id= 301.936607982 runs/s
median= 302.45758701 runs/s, stdev= 1.88991087072 runs/s, min= 298.879202989 runs/s, max= 304.955527319 runs/s

RESULT Bindings: get-element-by-id= 301.952234563 runs/s
median= 302.648171501 runs/s, stdev= 1.59929752614 runs/s, min= 299.625468165 runs/s, max= 304.568527919 runs/s

  • Bindings/get-element-by-id.html: Added.
11:03 PM Changeset in webkit [117547] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a benchmark for body.scrollTop
https://bugs.webkit.org/show_bug.cgi?id=86806

Reviewed by Ryosuke Niwa.

Currently Bindings/dom-attributes.html is just a collection of random
DOM attributes and methods. We should remove it and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

This patch adds a benchmark for body.scrollTop, which covers other
DOM attributes that return small integers.

(Note: Performance optimization for the benchmark will be coming soon.)

Test results in my Linux desktop:

RESULT Bindings: scroll-top= 209.410654239 runs/s
median= 211.64021164 runs/s, stdev= 4.09958741195 runs/s, min= 201.005025126 runs/s, max= 212.483399734 runs/s

RESULT Bindings: scroll-top= 195.651111157 runs/s
median= 196.319018405 runs/s, stdev= 1.77011627406 runs/s, min= 191.846522782 runs/s, max= 197.28729963 runs/s
RESULT Bindings: scroll-top= 200.004907612 runs/s
median= 201.511335013 runs/s, stdev= 3.27455403827 runs/s, min= 193.236714976 runs/s, max= 202.53164557 runs/s

RESULT Bindings: scroll-top= 209.582737512 runs/s
median= 210.803689065 runs/s, stdev= 3.16769655464 runs/s, min= 203.045685279 runs/s, max= 211.920529801 runs/s

RESULT Bindings: scroll-top= 199.924607687 runs/s
median= 201.13144338 runs/s, stdev= 3.11080503619 runs/s, min= 193.003618818 runs/s, max= 202.02020202 runs/s

  • Bindings/scroll-top.html: Added.
10:50 PM Changeset in webkit [117546] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8][Refactoring] Remove V8Proxy::deletionNotHandledByInterceptor()
https://bugs.webkit.org/show_bug.cgi?id=86803

Reviewed by Dimitri Glazkov.

V8Proxy::deletionNotHandledByInterceptor() is used by V8StorageCustom.cpp
only, just in order to return v8::Handle<v8::Boolean>(). In such cases,
other custom bindings are hard-coding 'return v8::Handle<v8::Boolean>()'.
Thus we can hard-code 'return v8::Handle<v8::Boolean>()' in V8StorageCustom.cpp
too, and remove V8Proxy::deletionNotHandledByInterceptor().

No tests. No change in behavior.

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageDeleter):

10:44 PM Changeset in webkit [117545] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: speed-up markQueriableHeapObjects function.
https://bugs.webkit.org/show_bug.cgi?id=86732

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._flagsOfNode):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
(WebInspector.HeapSnapshot.prototype._calculateFlags):

10:35 PM Changeset in webkit [117544] by kinuko@chromium.org
  • 5 edits in trunk/Source/WebCore

Some Spelling Mistakes Result in Compile Errors with ENABLE(FILE_SYSTEM) in LocalFileSystem.cpp
https://bugs.webkit.org/show_bug.cgi?id=86103

Reviewed by Rob Buis.

Added build fixes and some (limited) common implementation for non-chromium ports.

No new tests as this should have no functionality changes.

  • Modules/filesystem/DOMFileSystemBase.cpp:

(WebCore::DOMFileSystemBase::isValidType): Added common implementation for non-chromium ports.
(WebCore::DOMFileSystemBase::crackFileSystemURL): Ditto.
(WebCore::DOMFileSystemBase::supportsToURL): Ditto.
(WebCore::DOMFileSystemBase::createFileSystemURL): Ditto.

  • Modules/filesystem/LocalFileSystem.cpp:

(WebCore::LocalFileSystem::readFileSystem): Fixed.
(WebCore::LocalFileSystem::requestFileSystem): Fixed.

  • platform/blackberry/AsyncFileSystemBlackBerry.cpp:

(WebCore::AsyncFileSystem::openFileSystem): Fixed.

  • platform/gtk/AsyncFileSystemGtk.cpp:

(WebCore::AsyncFileSystem::openFileSystem): Fixed.

10:33 PM Changeset in webkit [117543] by fpizlo@apple.com
  • 2 edits in branches/dfgopt/Source/JavaScriptCore

Fix a typo that Geoff noticed but that I forgot to fix in the last commit.
https://bugs.webkit.org/show_bug.cgi?id=86552

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

10:30 PM Changeset in webkit [117542] by fpizlo@apple.com
  • 28 edits
    18 adds in branches/dfgopt

DFG should optimize aliased uses of the Arguments object of the current call frame
https://bugs.webkit.org/show_bug.cgi?id=86552

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Performs must-alias and escape analysis on uses of CreateArguments, and if
a variable is must-aliased to CreateArguments and does not escape, then we
turn all uses of that variable into direct arguments accesses.

36% speed-up on V8/earley leading to a 2.3% speed-up overall in V8.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::uncheckedArgumentsRegister):

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::argumentsThatWereNotCreated):
(ValueRecovery):
(JSC::ValueRecovery::dump):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAdjacencyList.h:

(AdjacencyList):
(JSC::DFG::AdjacencyList::removeEdgeFromBag):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUses):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(AssemblyHelpers):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):

  • dfg/DFGGPRInfo.h:

(GPRInfo):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::collectGarbage):
(DFG):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::executableFor):
(JSC::DFG::Graph::argumentsRegisterFor):
(JSC::DFG::Graph::uncheckedArgumentsRegisterFor):
(JSC::DFG::Graph::clobbersWorld):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler.h:

(JSC::DFG::OSRExitCompiler::OSRExitCompiler):
(OSRExitCompiler):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsArgumentsAlias):
(VariableAccessData):
(JSC::DFG::VariableAccessData::isArgumentsAlias):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_get_argument_by_val):

LayoutTests:

Rubber stamped by Geoff Garen.

Added a bunch of tests that check that our optimizations for aliased uses of the
'arguments' object are robust against various forms of JavaScript crazy.

  • fast/js/dfg-arguments-alias-escape-expected.txt: Added.
  • fast/js/dfg-arguments-alias-escape.html: Added.
  • fast/js/dfg-arguments-alias-expected.txt: Added.
  • fast/js/dfg-arguments-alias.html: Added.
  • fast/js/dfg-arguments-cross-code-origin-expected.txt: Added.
  • fast/js/dfg-arguments-cross-code-origin.html: Added.
  • fast/js/dfg-arguments-mixed-alias-expected.txt: Added.
  • fast/js/dfg-arguments-mixed-alias.html: Added.
  • fast/js/dfg-arguments-osr-exit-expected.txt: Added.
  • fast/js/dfg-arguments-osr-exit.html: Added.
  • fast/js/dfg-arguments-unexpected-escape-expected.txt: Added.
  • fast/js/dfg-arguments-unexpected-escape.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-arguments-alias-escape.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-alias.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-cross-code-origin.js: Added.

(foo):
(bar):
(baz):

  • fast/js/script-tests/dfg-arguments-mixed-alias.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-osr-exit.js: Added.

(baz):
(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-unexpected-escape.js: Added.

(baz):
(foo):
(bar):

9:57 PM Changeset in webkit [117541] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

AudioBufferSourceNode and MediaElementAudioSourceNode should support multi-channel > stereo
https://bugs.webkit.org/show_bug.cgi?id=75119

Patch by Wei James <james.wei@intel.com> on 2012-05-17
Reviewed by Chris Rogers.

As multiple channel support in AudioBus and other places is already
implemented, the check can be removed here.

  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::setFormat):

9:46 PM Changeset in webkit [117540] by rakuco@webkit.org
  • 5 edits in trunk

[EFL][DRT] Call resetInternalsObject() after each test.
https://bugs.webkit.org/show_bug.cgi?id=86793

Reviewed by Antonio Gomes.

We need to reset the internals object's settings after running
each test so that there are no interferences between each test's
results.

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::globalContextRefForFrame):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(runTest):

9:41 PM Changeset in webkit [117539] by Philippe Normand
  • 2 edits in trunk/Source/WebKit2

Unreviewed, WebKit2 GTK/Qt build fix attempt after r117516.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

9:37 PM Changeset in webkit [117538] by pilgrim@chromium.org
  • 8 edits
    1 copy in trunk/Source

[Chromium] Move Web Workers methods to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=86799

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::didStartWorkerRunLoop):
(WebKit::Platform::didStopWorkerRunLoop):

  • chromium/public/WebWorkerRunLoop.h: Added.

(WebCore):
(WebKit):
(WebWorkerRunLoop):
(Task):
(WebKit::WebWorkerRunLoop::Task::~Task):
(WebKit::operator==):
(WebKit::operator<):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebWorkerRunLoop.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::didStartWorkerRunLoop):
(WebCore::PlatformSupport::didStopWorkerRunLoop):

9:35 PM WebKit Team edited by leviw@chromium.org
Moving myself to reviewers. (diff)
9:33 PM Changeset in webkit [117537] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/11419933> Problems with flipped writing modes and compositing
https://bugs.webkit.org/show_bug.cgi?id=86032

Reviewed by Anders Carlsson.

Source/WebCore:

Test: compositing/bounds-in-flipped-writing-mode.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateLayerBounds): Apply a writing-mode flip to the bounding box
if needed.

LayoutTests:

  • compositing/bounds-in-flipped-writing-mode-expected.txt: Added.
  • compositing/bounds-in-flipped-writing-mode.html: Added.
8:39 PM Changeset in webkit [117536] by haraken@chromium.org
  • 10 edits in trunk/Source/WebCore

[V8][Refactoring] Remove V8Proxy::throwError(const char*, v8::Isolate* = 0)
https://bugs.webkit.org/show_bug.cgi?id=86794

Reviewed by Adam Barth.

As commented here (https://bugs.webkit.org/show_bug.cgi?id=84074#c5),
I am refactoring a series of confusing throwError()s.
This patch removes V8Proxy::throwError(const char*, v8::Isolate* = 0).

No tests. No change in behavior.

  • bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):
(WebCore::getMessagePortArray):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageCallback):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::openCallback):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionStartAccessorGetter):
(WebCore::V8HTMLInputElement::selectionStartAccessorSetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorGetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorSetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter):
(WebCore::V8HTMLInputElement::setSelectionRangeCallback):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAccessorSetter):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::inspectedObjectCallback):

8:36 PM Changeset in webkit [117535] by danakj@chromium.org
  • 20 edits in trunk/Source

[chromium] Scale all compositor output by the defaultDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=86051

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

On initialization, give the defaultDeviceScaleFactor to the compositor
to have it scale all output from WebCore's layout size to physical
pixels. This allows us to scale up to high-dpi devices without using
fixed-layout, so we can leave the WebCore frame size in layout pixels,
while drawing the frame into a larger physical pixel size.

CCLayerTreeHost becomes aware of the deviceScaleFactor and scales all
output by this factor by scaling the viewport and all drawing
transforms.

Anything that works in physical pixels (content space), uses the
deviceViewportSize() in place of the viewportSize(), since when
deviceScaleFactor != 1 in CCLayerTreeHost, the WebCore viewport
is no longer physical pixels.

Scroll positions are in layout pixels, and must be scaled to/from
content space within the compositor.

Unit tests: CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromiumClient):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):
(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deviceViewportSize):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::viewportSize):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

Add the applyDefaultDeviceScaleInCompositor setting. When enabled, we
apply the scale factor during compositing instead of applying it through
the pageScaleFactor.

NonCompositedContentHost is the GraphicLayerClient for the GraphicsLayer
containing the document's body. It needs to report the page/device scale
that should be used when scaling the contents of the GraphicsLayer, and
when changes occur to them such that its contentsSize or contentsScale
is affected.

Store the deviceScaleFactor being used in the compositor. The remainder
of the deviceScaleFactor() is being applied to the pageScale.

  • public/WebSettings.h:
  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setViewport):

  • src/NonCompositedContentHost.h:

(NonCompositedContentHost):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setApplyDefaultDeviceScaleFactorInCompositor):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::applyDefaultDeviceScaleFactorInCompositor):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setDeviceScaleFactor):
(WebKit::WebViewImpl::enableFixedLayoutMode):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::updateLayerTreeViewport):

  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(MockLayerTreeHostImpl):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::beginTest):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::afterTest):
(WTF):
(WTF::TEST_F):

  • tests/LayerRendererChromiumTest.cpp:
  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):

8:24 PM Changeset in webkit [117534] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

[Shadow DOM] Add an assertion to make sure a visited node is not an active insertion point.
https://bugs.webkit.org/show_bug.cgi?id=86708

Reviewed by Eric Seidel.

Since InsertionPoint now has isActive() member function,
we can add an assertion to ComposedShadowTreeWalker::assertPrecondition()
using that function.

No new tests, no change in behavior.

  • dom/ComposedShadowTreeWalker.h:

(WebCore::ComposedShadowTreeWalker::assertPrecondition):

8:16 PM Changeset in webkit [117533] by pkasting@chromium.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r117526.
http://trac.webkit.org/changeset/117526
https://bugs.webkit.org/show_bug.cgi?id=86801

broke Chromium Mac 10.5 layout test canaries (Requested by
pkasting on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-17

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM):
(SCM.in_working_directory):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN):
(SVN.in_working_directory):

8:10 PM Changeset in webkit [117532] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source

Versioning.

8:01 PM Changeset in webkit [117531] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Prune unnecessary failure expectations.
http://code.google.com/p/chromium/issues/detail?id=32670
https://bugs.webkit.org/show_bug.cgi?id=74694
https://bugs.webkit.org/show_bug.cgi?id=82129
https://bugs.webkit.org/show_bug.cgi?id=83503
https://bugs.webkit.org/show_bug.cgi?id=86439

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
7:45 PM Changeset in webkit [117530] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Prune unnecessary failure expectations.
http://code.google.com/p/chromium/issues/detail?id=23489
http://code.google.com/p/chromium/issues/detail?id=67540
http://code.google.com/p/chromium/issues/detail?id=68436
http://code.google.com/p/chromium/issues/detail?id=77706
https://bugs.webkit.org/show_bug.cgi?id=47949
https://bugs.webkit.org/show_bug.cgi?id=65462
https://bugs.webkit.org/show_bug.cgi?id=68436
https://bugs.webkit.org/show_bug.cgi?id=73838
https://bugs.webkit.org/show_bug.cgi?id=74694
https://bugs.webkit.org/show_bug.cgi?id=83185

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
7:36 PM Changeset in webkit [117529] by fischman@chromium.org
  • 6 edits in trunk/Source

[Chromium] Store HTTP version in WebURLResponse
https://bugs.webkit.org/show_bug.cgi?id=86522

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebURLResponse.h:

(WebURLResponse):

Source/WebCore:

No new tests; this isn't exposed to the web platform.

  • platform/chromium/support/WebURLResponse.cpp:

(WebKit::WebURLResponse::httpVersion):
(WebKit):
(WebKit::WebURLResponse::setHTTPVersion):

  • platform/network/chromium/ResourceResponse.h:

(ResourceResponse):
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::httpVersion):
(WebCore::ResourceResponse::setHTTPVersion):

7:14 PM Changeset in webkit [117528] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Floor y coordinate in Chromium's GraphicsContext::drawLineForText to avoid anti-aliasing
https://bugs.webkit.org/show_bug.cgi?id=86775

Reviewed by Eric Seidel.

Despite operating in floats, we always want to draw lines for text aligned to pixel boundaries.
There are similar functions to do this in other platforms, but to get proper results, we only
need to floor the y value, as we always draw these lines horizontally.

No tests. No change in behavior prior to sub-pixel change.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawLineForText):

7:12 PM Changeset in webkit [117527] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Prune unnecessary failure expectations.
http://code.google.com/p/chromium/issues/detail?id=11251
http://code.google.com/p/chromium/issues/detail?id=69181
http://code.google.com/p/chromium/issues/detail?id=124313
http://code.google.com/p/chromium/issues/detail?id=124779
https://bugs.webkit.org/show_bug.cgi?id=80067
https://bugs.webkit.org/show_bug.cgi?id=84125
https://bugs.webkit.org/show_bug.cgi?id=85553

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
7:05 PM Changeset in webkit [117526] by dpranke@chromium.org
  • 3 edits in trunk/Tools

scm.add() doesn't work properly with svn 1.7
https://bugs.webkit.org/show_bug.cgi?id=86779

Reviewed by Ojan Vafai.

The code relied on '.svn' directories being present
in order to tell if a directory had already been added to the
repository; this is no longer true in SVN 1.7.

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM):
(SCM.in_working_directory):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN):
(SVN.in_working_directory):

6:46 PM Changeset in webkit [117525] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Fix bad baseline from http://trac.webkit.org/changeset/117480/.
https://bugs.webkit.org/show_bug.cgi?id=84167

Unreviewed, test expectations update.

  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
6:40 PM Changeset in webkit [117524] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Linux amd64 platform reported as i686
https://bugs.webkit.org/show_bug.cgi?id=86778
http://code.google.com/p/chromium/issues/detail?id=128167

Remove the old hard-coded gyp define and allow the more recent (but
still quite old) code in Source/WebCore/page/NavigatorBase.cpp to take
precedence and detect this at runtime.

Patch by Michael Moss <mmoss@chromium.org> on 2012-05-17
Reviewed by Tony Chang.

No new tests because it's hardware dependent.

  • WebCore.gyp/WebCore.gyp:
6:34 PM Changeset in webkit [117523] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

Setting array index -1 and looping over array causes bad behavior
https://bugs.webkit.org/show_bug.cgi?id=86733
<rdar://problem/11477670>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • dfg/DFGOperations.cpp:

LayoutTests:

  • fast/js/dfg-negative-array-index-expected.txt: Added.
  • fast/js/dfg-negative-array-index.html: Added.
  • fast/js/script-tests/dfg-negative-array-index.js: Added.

(foo):

6:28 PM Changeset in webkit [117522] by pkasting@chromium.org
  • 8 edits in trunk/LayoutTests

[chromium] More rebaselines/expectation updates.
https://bugs.webkit.org/show_bug.cgi?id=86441

Unreviewed, test expectations update.

  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium/test_expectations.txt:
6:20 PM Changeset in webkit [117521] by vangelis@chromium.org
  • 12 edits in trunk/Source

Source/Platform: [chromium] Expose layer tiling size options to WebSettings
https://bugs.webkit.org/show_bug.cgi?id=86425

Adding entries for tile size and max untiled layer size.

Reviewed by Adrienne Walker.

  • chromium/public/WebLayerTreeView.h:

(WebKit):
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore: [chromium] Expose layer tiling size options to WebSettings.
https://bugs.webkit.org/show_bug.cgi?id=86425

Removing hardcoded tile size and max untiled layer size from TiledLayerChromium
and instead have the values passed in via the LTH CCSettings. This will allow
different compositor instances to adjust tiling parameters as needed and makes
it possible to set the values via command line arguments.

Reviewed by Adrienne Walker.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
Made some additional adjustments to the single-tile heuristic
to make it work better with arbitrary sizes while still avoiding
to create unreasonably large layers.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):

Source/WebKit/chromium: Expose layer tiling size options to WebSettings.
https://bugs.webkit.org/show_bug.cgi?id=86425

This will allow tiling parameters to be set via command line flags
passed to the Renderer.

Reviewed by Adrienne Walker.

  • public/WebSettings.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setDefaultTileSize):
(WebKit):
(WebKit::WebSettingsImpl::setMaxUntiledLayerSize):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::defaultTileSize):
(WebKit::WebSettingsImpl::maxUntiledLayerSize):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

6:12 PM Changeset in webkit [117520] by pilgrim@chromium.org
  • 8 edits
    1 copy in trunk/Source

[Chromium] Move fileUtilities to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=86777

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::fileUtilities):

  • chromium/public/WebFileUtilities.h: Added.

(WebKit):
(WebFileUtilities):
(WebKit::WebFileUtilities::revealFolderInOS):
(WebKit::WebFileUtilities::fileExists):
(WebKit::WebFileUtilities::deleteFile):
(WebKit::WebFileUtilities::deleteEmptyDirectory):
(WebKit::WebFileUtilities::getFileSize):
(WebKit::WebFileUtilities::getFileModificationTime):
(WebKit::WebFileUtilities::directoryName):
(WebKit::WebFileUtilities::pathByAppendingComponent):
(WebKit::WebFileUtilities::makeAllDirectories):
(WebKit::WebFileUtilities::getAbsolutePath):
(WebKit::WebFileUtilities::isDirectory):
(WebKit::WebFileUtilities::filePathToURL):
(WebKit::WebFileUtilities::openFile):
(WebKit::WebFileUtilities::closeFile):
(WebKit::WebFileUtilities::seekFile):
(WebKit::WebFileUtilities::truncateFile):
(WebKit::WebFileUtilities::readFromFile):
(WebKit::WebFileUtilities::writeToFile):
(WebKit::WebFileUtilities::~WebFileUtilities):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebFileUtilities.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::fileExists):
(WebCore::PlatformSupport::deleteFile):
(WebCore::PlatformSupport::deleteEmptyDirectory):
(WebCore::PlatformSupport::getFileSize):
(WebCore::PlatformSupport::revealFolderInOS):
(WebCore::PlatformSupport::getFileModificationTime):
(WebCore::PlatformSupport::directoryName):
(WebCore::PlatformSupport::pathByAppendingComponent):
(WebCore::PlatformSupport::makeAllDirectories):
(WebCore::PlatformSupport::getAbsolutePath):
(WebCore::PlatformSupport::isDirectory):
(WebCore::PlatformSupport::filePathToURL):
(WebCore::PlatformSupport::openFile):
(WebCore::PlatformSupport::closeFile):
(WebCore::PlatformSupport::seekFile):
(WebCore::PlatformSupport::truncateFile):
(WebCore::PlatformSupport::readFromFile):
(WebCore::PlatformSupport::writeToFile):

5:55 PM Changeset in webkit [117519] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Rolled out r117495 because it caused som out of memory crashes.

  • heap/Heap.cpp:

(JSC::Heap::collect):

5:50 PM Changeset in webkit [117518] by Lucas Forschler
  • 1 copy in tags/Safari-536.12

New Tag.

5:40 PM Changeset in webkit [117517] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Refactored the Heap to move more MarkedSpace logic into MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=86790

Reviewed by Gavin Barraclough.

  • heap/Heap.cpp:

(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::markRoots):
(JSC):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::collect):

  • heap/Heap.h:

(Heap): Took all the functors from here...

  • heap/MarkedBlock.h:

(CountFunctor):
(JSC::MarkedBlock::CountFunctor::CountFunctor):
(JSC::MarkedBlock::CountFunctor::count):
(JSC::MarkedBlock::CountFunctor::returnValue):
(MarkedBlock):

  • heap/MarkedSpace.h:

(JSC::ClearMarks::operator()):
(JSC):
(JSC::Sweep::operator()):
(JSC::MarkCount::operator()):
(JSC::Size::operator()):
(JSC::Capacity::operator()):
(MarkedSpace):
(JSC::MarkedSpace::clearMarks):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::size):
(JSC::MarkedSpace::capacity): and put them here.

5:12 PM Changeset in webkit [117516] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Plug-ins blacklist mechanism can tell clients about plug-in with null identifier
https://bugs.webkit.org/show_bug.cgi?id=86788
<rdar://problem/11479503>

Reviewed by John Sullivan.

Pass along the URL string of the blocked plug-in so we can find the plug-in even if there was no
MIME type specified in the <embed> or <object> tag.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

4:35 PM Changeset in webkit [117515] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Memory leak in NetworkInfoClient
https://bugs.webkit.org/show_bug.cgi?id=86603

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-17
Reviewed by Adam Barth.

Source/WebCore:

Fix a memory leak in NetworkInfoClient by using OwnPtr and
change the class not to inherite from RefCounted.

  • Modules/networkinfo/NetworkInfoClient.h:

Source/WebKit/efl:

Fix a memory leak in NetworkInfoClient by using OwnPtr and making
the client to be owned by the View.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

4:25 PM Changeset in webkit [117514] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=86786
Two mathml/presentation tests fail on Mac

  • platform/mac/Skipped:
4:25 PM Changeset in webkit [117513] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=86785
Two fast/repaint tests fail on mac lion

  • platform/mac-lion/Skipped:
4:20 PM Changeset in webkit [117512] by jsbell@chromium.org
  • 11 edits in trunk/Source

IndexedDB: Remove IDBIndex.storeName
https://bugs.webkit.org/show_bug.cgi?id=86676

Reviewed by Tony Chang.

Source/WebCore:

Older versions of the IDB spec exposed IDBIndex.storeName. While it's been removed
from the IDL, the additional storage/plumbing are unnecessary clutter. Nuke it!

No new tests - no functional changes.

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl): Remove storeName parameter, and
const declaration on object store param. The former was used to get a non-const pointer
via indirection in openCursorInternal.
(WebCore::IDBIndexBackendImpl::openCursorInternal): Use store pointer directly, don't
look it up by name in the transaction.

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create): Remove storeName parameters.
(IDBIndexBackendImpl): Remove storeName() method.

  • Modules/indexeddb/IDBIndexBackendInterface.h:

(IDBIndexBackendInterface): Remove storeName parameter.

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::createIndex): Remove storeName parameter.
(WebCore::IDBObjectStoreBackendImpl::loadIndexes): Remove storeName parameter.

Source/WebKit/chromium:

  • public/WebIDBIndex.h:

(WebIDBIndex): Can't remove from here until Chromium is updated

  • src/IDBIndexBackendProxy.cpp: Removed storeName()
  • src/IDBIndexBackendProxy.h: Removed storeName()

(IDBIndexBackendProxy):

  • src/WebIDBIndexImpl.cpp: Removed storeName()
  • src/WebIDBIndexImpl.h: Removed storeName()

(WebIDBIndexImpl):

4:19 PM Changeset in webkit [117511] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] www.thestar.com/iphone Viewport Weirdness
https://bugs.webkit.org/show_bug.cgi?id=86756

Reviewed by George Staikos.

PR 156710
On high DPI devices, the virtual viewport size of this page was smaller
than screen size. During the refreshing of the page, we reset the scale
when the state was Committed, then layouted and rendered contents based
on the virtual viewport size and default scale 1, which caused a small
size thumbnail before we restored the previous view state.
Fixed it by keeping the previous scale, user scalable and
m_userViewportArguments during the Committed state of refreshing.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):

4:11 PM Changeset in webkit [117510] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Don't let -[CALayer renderInContext:] try to render WebView's root layer
https://bugs.webkit.org/show_bug.cgi?id=86773
<rdar://problem/10950075>

Reviewed by Dan Bernstein.

-[CALayer renderInContext:] doesn't correctly render our layer tree, so
don't let it try. Calling drawRect: with a bitmap context will already
do the right thing for WebViews.

  • WebView/WebHTMLView.mm: Create a subclass of CALayer called WebLayerHostingLayer.

(-[WebLayerHostingLayer renderInContext:]): override renderInContext: to be a NOOP.
(-[WebHTMLView attachRootLayer:]): Create a WebLayerHostingLayer rather than a CALayer.

4:03 PM Changeset in webkit [117509] by jsbell@chromium.org
  • 14 edits in trunk

IndexedDB: Implement IDBObjectStore.autoIncrement
https://bugs.webkit.org/show_bug.cgi?id=86662

Reviewed by Dimitri Glazkov.

Source/WebCore:

Simple boolean accessor defined in the IDB spec, which reflects the
object store's internal autoIncrement flag.

Test: storage/indexeddb/objectstore-basics.html

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::autoIncrement): Forward call to back end.
(WebCore):

  • Modules/indexeddb/IDBObjectStore.h: Expose attribute as method.

(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStore.idl: Define the attribute.
  • Modules/indexeddb/IDBObjectStoreBackendInterface.h: Expose in interface.

(IDBObjectStoreBackendInterface):

Source/WebKit/chromium:

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::autoIncrement):
(WebKit):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::autoIncrement):
(WebKit):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

LayoutTests:

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/resources/objectstore-basics.js:

(setVersionSuccess):

3:44 PM Changeset in webkit [117508] by jonlee@apple.com
  • 2 edits in trunk/Tools

Update Apple buildbots to prioritize latest changelists
https://bugs.webkit.org/show_bug.cgi?id=86766

Reviewed by Brady Eidson.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(pickLatestBuild): Function to get the most pick the most recent build request.
(loadBuilderConfig): Configure builders in the AppleMac and AppleWin categories to
use the pickLatestBuild function when choosing which request to build next.

3:35 PM Changeset in webkit [117507] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

[V8][Refactoring] Remove throwError("message", XXXError) from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=86744

Reviewed by Adam Barth.

As commented in https://bugs.webkit.org/show_bug.cgi?id=84074#c5,
I am refactoring a series of confusing throwError()s.

This patch removes throwError("message", XXXError) in CodeGeneratorV8.pm
and replaces it with throwTypeError("message") or throwError(XXXError, "message").

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::constructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::V8TestObj::constructorCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

3:27 PM Changeset in webkit [117506] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Add more descriptive warnings for framebuffer incomplete conditions
https://bugs.webkit.org/show_bug.cgi?id=86774

Patch by Gregg Tavares <gman@google.com> on 2012-05-17
Reviewed by Kenneth Russell.

No new tests as there is no new functionality

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):

  • html/canvas/WebGLFramebuffer.h:

(WebGLFramebuffer):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::checkFramebufferStatus):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::printGLWarningToConsole):

  • html/canvas/WebGLRenderingContext.h:
3:26 PM Changeset in webkit [117505] by pkasting@chromium.org
  • 25 edits
    2 adds in trunk/LayoutTests

[chromium] Rebaseline.
https://bugs.webkit.org/show_bug.cgi?id=86441

Unreviewed, test expecations update.

  • platform/chromium-mac-leopard/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/column-rules-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/positive-leading-expected.png:
  • platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/column-rules-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/positive-leading-expected.png:
  • platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-mac/fast/multicol/column-rules-expected.png:
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-mac/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-mac/fast/multicol/positive-leading-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-lr/column-rules-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/column-rules-expected.png:
  • platform/chromium/test_expectations.txt:
3:09 PM Changeset in webkit [117504] by oliver@apple.com
  • 6 edits in trunk/Source

Endeavour to make the windows test bot actually able to run tests.
https://bugs.webkit.org/show_bug.cgi?id=86772

Reviewed by Sam Weinig.

Source/WebCore:

Use WEBKIT_EXPORT to get correct export behaviour on windows, rather than
relying on the .def files.

  • bindings/js/JSDOMGlobalObject.h:

(JSDOMGlobalObject):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

Source/WebKit2:

Remove the ClassInfo exports from the .def files as we're now using
WEBKIT_EXPORT declarations to get expected behaviour on windows.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
3:04 PM Changeset in webkit [117503] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a micro benchmark for div.firstChild getter for an undefined firstChild
https://bugs.webkit.org/show_bug.cgi?id=86725

Reviewed by Ryosuke Niwa.

We are going to remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

In this bug, we add a micro benchmark for div.firstChild getter for an
undefined firstChild. This benchmark covers other undefined DOM attributes
that return a null.

(Note: In V8, div.firstChild for an undefined firstChild is currently slower
than div.firstChild for a defined firstChild.)

Test results in my Linux desktop:

RESULT Bindings: undefined-first-child= 541.408311042 runs/s
median= 541.205412054 runs/s, stdev= 1.29841219187 runs/s, min= 537.897310513 runs/s, max= 543.209876543 runs/s

RESULT Bindings: undefined-first-child= 541.00750695 runs/s
median= 540.540540541 runs/s, stdev= 0.967521230965 runs/s, min= 539.215686275 runs/s, max= 543.209876543 runs/s

RESULT Bindings: undefined-first-child= 523.630714897 runs/s
median= 523.560209424 runs/s, stdev= 1.01570919645 runs/s, min= 522.193211488 runs/s, max= 525.624178712 runs/s

RESULT Bindings: undefined-first-child= 553.077663588 runs/s
median= 553.459119497 runs/s, stdev= 0.805697397863 runs/s, min= 551.378446115 runs/s, max= 554.156171285 runs/s

RESULT Bindings: undefined-first-child= 541.5401432 runs/s
median= 541.538666618 runs/s, stdev= 0.954301364767 runs/s, min= 539.877300613 runs/s, max= 543.209876543 runs/s

  • Bindings/undefined-first-child.html: Added.
2:59 PM Changeset in webkit [117502] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=86266
r112643/r116697 break Webview form input fields
-and corresponding-
<rdar://problem/11400430>

Reviewed by Dan Bernstein.

There is a recent history of changes in this are that seem worth documenting.
First was the change to switch to using NSTextFieldCell to draw text fields:
http://trac.webkit.org/changeset/104240

That led to problems because of the clear background that I thought at the time
were specific to MountainLion. To fix that, I made this change:
http://trac.webkit.org/changeset/110480

But that change resulted in styled text fields getting an un-themed border, which
led to this change on the branch: http://trac.webkit.org/changeset/112643 and a
change on TOT that was identical for Lion and SnowLeopard but introduced new
behavior for MountainLion: http://trac.webkit.org/changeset/116697

And that brings us to this bug, where it turns out the clear background is a
problem on Lion and SnowLeopard too. This patch fixes the bug by using the
original WebCoreSystemInterface function to paint all text fields on Lion and
SnowLeopard that are styled. This is what we used to paint all text fields before
r104240, which is the first change listed above. Un-styled text fields will still
use NSTextFieldCell on these platforms, but with a hardcoded white background.

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::textField):

2:49 PM Changeset in webkit [117501] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

IconDatabase: Move icon retain/release off of the main thread.
<http://webkit.org/b/85799>
<rdar://problem/9507113>

Reviewed by Brady Eidson.

Batch up the retain/release operations and execute them as part of the sync thread loop.
The batch execution is guarded by a new mutex (m_urlsToRetainOrReleaseLock.)
This avoids blocking the main thread on m_urlAndIconLock for basic retain/release.

There is one exception; if there are pending retain/release operations in synchronousIconForPageURL,
it will acquire the lock and flush the operations.

There should be no behavior change, this is only meant to reduce lock contention.

  • loader/icon/PageURLRecord.h:

(WebCore::PageURLRecord::retain):
(WebCore::PageURLRecord::release):

Added a 'count' argument to these so we can batch up the operations in IconDatabase.

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::performScheduleOrDeferSyncTimer):
(WebCore::IconDatabase::performScheduleOrDeferSyncTimerOnMainThread):
(WebCore::IconDatabase::scheduleOrDeferSyncTimer):

Perform the the timer scheduling on the main thread as it can be done on a different
thread by way of retainIconForPageURL or releaseIconForPageURL.

(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::performRetainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::performReleaseIconForPageURL):
(WebCore::IconDatabase::retainedPageURLCount):
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::syncThreadMainLoop):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):

2:46 PM Changeset in webkit [117500] by enne@google.com
  • 9 edits in branches/chromium/1132/Source

Merge 117171 - [chromium] Ensure animations get ticked at least once when added.

https://bugs.webkit.org/show_bug.cgi?id=86013

Patch by Ian Vollick < vollick@chromium.org> on 2012-05-15
Reviewed by James Robinson.
Merged by hand by Adrienne Walker, because it didn't apply cleanly.

Source/WebCore:

Tested in

CCLayerTreeHostTestTickAnimationWhileBackgrounded.runSingleThreaded
CCLayerTreeHostTestAddAnimationWithTimingFunction.runSingleThreaded
CCLayerTreeHostTestSynchronizeAnimationStartTimes.runSingleThreaded
CCLayerTreeHostTestAnimationFinishedEvents.runSingleThreaded

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::addAnimation):
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::finishCommitOnImplThread): (WebCore::CCLayerTreeHost::didAddAnimation): (WebCore): (WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
  • platform/graphics/chromium/cc/CCLayerTreeHost.h: (CCLayerTreeHost):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
  • platform/graphics/chromium/cc/CCProxy.h: (CCProxy):
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (CCSingleThreadProxyAnimationTimer): (WebCore::CCSingleThreadProxyAnimationTimer::create): (WebCore::CCSingleThreadProxyAnimationTimer::CCSingleThreadProxyAnimationTimer): (WebCore): (WebCore::CCSingleThreadProxy::CCSingleThreadProxy): (WebCore::CCSingleThreadProxy::didAddAnimation): (WebCore::CCSingleThreadProxy::doComposite):
  • platform/graphics/chromium/cc/CCSingleThreadProxy.h: (WebCore):
  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp: (WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers): (WTF):
2:41 PM Changeset in webkit [117499] by rniwa@webkit.org
  • 1 edit
    2 copies in branches/chromium/1132

Merge 117361 - REGRESSION(r92823): WebKit strips font-weight: normal from b element when copying
https://bugs.webkit.org/show_bug.cgi?id=86663

Reviewed by Tony Chang.

The bug was caused by removeStyleFromRulesAndContext incorrectly stripping font-weight property
even when the context had no font-weight property because of a property name mismatch in getPropertiesNotIn.

Fixed the mismatch.

Test: editing/pasteboard/paste-text-with-style-5.html

  • editing/EditingStyle.cpp:

(WebCore::getPropertiesNotIn):
Review URL: https://chromiumcodereview.appspot.com/10391190

2:34 PM Changeset in webkit [117498] by rniwa@webkit.org
  • 1 edit
    2 copies in branches/chromium/1084

Merge 117361 - REGRESSION(r92823): WebKit strips font-weight: normal from b element when copying
https://bugs.webkit.org/show_bug.cgi?id=86663

Reviewed by Tony Chang.

The bug was caused by removeStyleFromRulesAndContext incorrectly stripping font-weight property
even when the context had no font-weight property because of a property name mismatch in getPropertiesNotIn.

Fixed the mismatch.

Test: editing/pasteboard/paste-text-with-style-5.html

  • editing/EditingStyle.cpp:

(WebCore::getPropertiesNotIn):

2:31 PM Changeset in webkit [117497] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Kill RenderLayer::relativePositionOffset(LayoutUnit& relX, LayoutUnit& relY) and cleanup RenderInline::clippedOverflowRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=86551

Reviewed by Abhishek Arya.

No test since there is no expected change in behavior.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
Changed the function to use LayoutRect arithmetics instead of calculating
top / left manually. While at it, improved the naming, removed some local
variables and removed an unneeded style() NULL-check.

  • rendering/RenderLayer.h: Removed the function.
2:23 PM Changeset in webkit [117496] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Increase the GC allocation trigger
https://bugs.webkit.org/show_bug.cgi?id=86699

Reviewed by Sam Weinig.

This helps a lot when the heap is growing, and helps to resolve
the regression caused by r116484.

  • heap/Heap.cpp:

(JSC::Heap::collect):

2:21 PM Changeset in webkit [117495] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2

Make the docked Web Inspector use autoresizing masks so the view doesn't jitter when
resizing the window.

https://webkit.org/b/86765

Reviewed by John Sullivan.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter close]): Added. Zero out _inspectorProxy.
(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]): Preform the work on a delay to
prevent interfering with Cocoa's resizing.
(WebKit::WebInspectorProxy::createInspectorWindow): Added setAutoresizingMask: call.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Removed setAutoresizingMask: call.
createInspectorWindow and platformAttach do this now.
(WebKit::WebInspectorProxy::platformDidClose): Call close on WKWebInspectorProxyObjCAdapter.
(WebKit::WebInspectorProxy::platformAttach): Added setAutoresizingMask: call.

2:17 PM Changeset in webkit [117494] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Fix linking errors
https://bugs.webkit.org/show_bug.cgi?id=86768

Reviewed by Antonio Gomes.

Add some missing stubs so we can link again.

  • platform/blackberry/ContextMenuBlackBerry.cpp:

(WebCore::ContextMenu::itemCount):
(WebCore):

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::screenHorizontalDPI):
(WebCore):
(WebCore::screenVerticalDPI):

2:06 PM Changeset in webkit [117493] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, update test number tracking media-continues-playing-after-replace-source.html

  • platform/efl/test_expectations.txt:
2:05 PM Changeset in webkit [117492] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Remove passing tests, re-number some still-present issues.
https://bugs.webkit.org/show_bug.cgi?id=86441
https://bugs.webkit.org/show_bug.cgi?id=86701
https://bugs.webkit.org/show_bug.cgi?id=86712

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
1:57 PM Changeset in webkit [117491] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

Fix rounding in paintSelection
https://bugs.webkit.org/show_bug.cgi?id=86693

Reviewed by Eric Seidel.

Break out rounding logic from InlineTextBox::paintSelection into separate
function and use it for all the EllipsisBox paintSelection implementation
and selection gap calculation. This ensures that selections are painted
without gaps and overlaps once we turn on subpixel layout.

No new tests, covered by existing tests in editing/selection and
editing/style.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paintSelection):

  • rendering/InlineTextBox.cpp:

(WebCore::alignSelectionRectToDevicePixels):
(WebCore):
(WebCore::InlineTextBox::paintSelection):

  • rendering/InlineTextBox.h:

(WebCore):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):

1:55 PM Changeset in webkit [117490] by rakuco@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Gardening, update expectations after r117426.

  • platform/efl/editing/unsupported-content/list-type-before-expected.txt:
  • platform/efl/editing/unsupported-content/table-type-after-expected.txt:
  • platform/efl/editing/unsupported-content/table-type-before-expected.txt:
1:46 PM Changeset in webkit [117489] by robert@webkit.org
  • 3 edits
    8 moves
    22 adds in trunk/LayoutTests

Rebaseline Chromium results after r117477

Unreviewed gardening.

  • platform/chromium-linux/css2.1/20110323/table-height-algorithm-023-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.png.
  • platform/chromium-linux/css2.1/20110323/table-height-algorithm-024-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.png.
  • platform/chromium-linux/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.png.
  • platform/chromium-linux/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.png.
  • platform/chromium-mac-leopard/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10296-1-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/table-height-algorithm-023-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/table-height-algorithm-024-expected.txt: Added.
  • platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
  • platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
  • platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
  • platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-height-algorithm-023-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-height-algorithm-024-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.txt.
  • platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
  • platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.txt.
  • platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
  • platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.txt.
  • platform/chromium/test_expectations.txt:
1:30 PM Changeset in webkit [117488] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] fast/dom/gc-10.html behaves badly
https://bugs.webkit.org/show_bug.cgi?id=86771

Unreviewed, skipping fast/dom/gc-10.html as it badly affects other tests.

  • platform/gtk/test_expectations.txt:
1:10 PM Changeset in webkit [117487] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Cleanup headers in SelectionHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=86760

Reviewed by Antonio Gomes.

Clean up includes in SelectionHandler.cpp.

  • WebKitSupport/SelectionHandler.cpp:
1:08 PM Changeset in webkit [117486] by robert@webkit.org
  • 4 edits in trunk/LayoutTests

Rebaseline two tests on Mac and update Mac expectations after r117339

Unreviewed gardening.

  • platform/mac/fast/repaint/float-overflow-expected.txt:
  • platform/mac/fast/repaint/float-overflow-right-expected.txt:
  • platform/mac/test_expectations.txt:
1:04 PM Changeset in webkit [117485] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Limiting render surface texture manager memory to 0 when contentsMemoryUseBytes is large.
https://bugs.webkit.org/show_bug.cgi?id=86764

Patch by Michal Mocny <mmocny@google.com> on 2012-05-17
Reviewed by Adrienne Walker.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::beginDrawingFrame):

1:01 PM Changeset in webkit [117484] by mitz@apple.com
  • 9 edits
    2 adds in trunk

In vertical writing modes, pagination may split a line after a block shifts
https://bugs.webkit.org/show_bug.cgi?id=86763

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/multicol/pageLogicalOffset-vertical.html

LayoutState::pageLogicalOffset() was returning bogus results in vertical writing modes,
because it was always using physical heights. Changed it to take a RenderBox and use its
writing mode to choose between heights and widths.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::pageLogicalOffset):
(WebCore::LayoutState::addForcedColumnBreak):

  • rendering/LayoutState.h:

(LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

LayoutTests:

  • fast/multicol/pageLogicalOffset-vertical-expected.html: Added.
  • fast/multicol/pageLogicalOffset-vertical.html: Added.
12:58 PM Changeset in webkit [117483] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] expandSelectionToGranularity should only use VisibleSelection and not range.
https://bugs.webkit.org/show_bug.cgi?id=86759

Reviewed by Antonio Gomes.

expandSelectionToGranularity unnecesarily converted the
selection to range and back. Using the selection
directly is preferred.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::expandSelectionToGranularity):

12:43 PM Changeset in webkit [117482] by inferno@chromium.org
  • 8 edits
    15 adds in trunk

Move run-in handling to addChild, instead of in layout.
https://bugs.webkit.org/show_bug.cgi?id=86387

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/runin/insert-before-run-in.html

fast/runin/run-in-after-run-in.html
fast/runin/run-in-parent-add-child.html
fast/runin/run-in-parent-block-child-add-and-intrude.html
fast/runin/run-in-parent-block-child-add.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): handle run-ins here
instead of layout. We do run-in handling when we see a new child with run-in display
or add a new block whose previous sibling is run-in.
(WebCore::RenderBlock::makeChildrenNonInline): if we will have block children, need
to move run-in back to its original position.
(WebCore::RenderBlock::handleSpecialChild): no longer need to handle run-ins during layout.
(WebCore::destroyRunIn): helper to destroy a block or inline run-in.
(WebCore):
(WebCore::RenderBlock::createReplacementRunIn): helper to create the new replacement run-in.
For moveRunInUnderSiblingBlockIfNeeded, it will be used to create a new inline run-in
that goes into the next sibling block. For moveRunInToOriginalPosition, it creates a new
block run-in that goes back to where it came from.
(WebCore::RenderBlock::moveRunInUnderSiblingBlockIfNeeded): almost same as previous
handleRunInChild function, but with the return type removed. Also, we don't allow
a run-in to intrude into a block that already has a run-in.
(WebCore::RenderBlock::moveRunInToOriginalPosition): moves run-in back to where it came from.

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderBoxModelObject.cpp: move all moveChild* functions from RenderBox, since

they can now be used to move children of inlines.
(WebCore::RenderBoxModelObject::moveChildTo): same.
(WebCore):
(WebCore::RenderBoxModelObject::moveChildrenTo): same.

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):
(WebCore::RenderBoxModelObject::moveChildTo): same.
(WebCore::RenderBoxModelObject::moveAllChildrenTo): same.
(WebCore::RenderBoxModelObject::moveChildrenTo): same.

LayoutTests:

The following tests need the render tree results as they help
to show the positioning of the run-in with respect to the next
sibling block.

  • fast/runin/insert-before-run-in-expected.png: Added.
  • fast/runin/insert-before-run-in-expected.txt: Added.
  • fast/runin/insert-before-run-in.html: Added.
  • fast/runin/run-in-after-run-in-expected.png: Added.
  • fast/runin/run-in-after-run-in-expected.txt: Added.
  • fast/runin/run-in-after-run-in.html: Added.
  • fast/runin/run-in-parent-add-child-expected.png: Added.
  • fast/runin/run-in-parent-add-child-expected.txt: Added.
  • fast/runin/run-in-parent-add-child.html: Added.
  • fast/runin/run-in-parent-block-child-add-and-intrude-expected.png: Added.
  • fast/runin/run-in-parent-block-child-add-and-intrude-expected.txt: Added.
  • fast/runin/run-in-parent-block-child-add-and-intrude.html: Added.
  • fast/runin/run-in-parent-block-child-add-expected.png: Added.
  • fast/runin/run-in-parent-block-child-add-expected.txt: Added.
  • fast/runin/run-in-parent-block-child-add.html: Added.
12:38 PM Changeset in webkit [117481] by mnaganov@chromium.org
  • 7 edits in trunk/Source

Support Copy ... actions for the Web Inspector remote debugging mode.
https://bugs.webkit.org/show_bug.cgi?id=86621

Reviewed by Pavel Feldman.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.documentCopy):
(.WebInspector.InspectorFrontendHostStub.prototype.copyText):
(.WebInspector.clipboardAccessDeniedMessage):
(.WebInspector.ClipboardAccessDeniedScreen):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.documentCopy):
(WebInspector.documentCopyEventFired):

Source/WebKit/chromium:

  • src/js/DevTools.js:

(WebInspector.clipboardAccessDeniedMessage):

12:36 PM Changeset in webkit [117480] by robert@webkit.org
  • 24 edits
    1 copy
    6 adds
    6 deletes in trunk/LayoutTests

Rebaseline results after r117339

Unreviewed gardening.

  • fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-mac-leopard/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-mac-leopard/editing/selection/inline-table-expected.png:
  • platform/chromium-mac-leopard/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac-leopard/fast/css-generated-content/inline-display-types-expected.png:
  • platform/chromium-mac-leopard/fast/inline-block/001-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/inline-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/css-generated-content/inline-display-types-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline-block/001-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-mac/editing/pasteboard/innerText-inline-table-expected.txt: Added.
  • platform/chromium-mac/editing/selection/inline-table-expected.png:
  • platform/chromium-mac/editing/selection/inline-table-expected.txt: Added.
  • platform/chromium-mac/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-3-expected.txt: Added.
  • platform/chromium-mac/fast/css-generated-content/inline-display-types-expected.png:
  • platform/chromium-mac/fast/css-generated-content/inline-display-types-expected.txt: Added.
  • platform/chromium-mac/fast/inline-block/001-expected.png:
  • platform/chromium-mac/fast/inline-block/001-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
  • platform/chromium-win-vista/fast/css-generated-content/inline-display-types-expected.png: Removed.
  • platform/chromium-win-vista/fast/inline-block/001-expected.png: Removed.
  • platform/chromium-win-xp/fast/css-generated-content/inline-display-types-expected.png: Removed.
  • platform/chromium-win-xp/fast/inline-block/001-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Copied from LayoutTests/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt.
  • platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
  • platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
12:10 PM Changeset in webkit [117479] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, unskip test after r117205.

  • platform/efl/test_expectations.txt:
12:08 PM Changeset in webkit [117478] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

This is not a joke: 3.7X speedup from removing a call to sleep
https://bugs.webkit.org/show_bug.cgi?id=86702

Reviewed by Eric Seidel.

The speedup was on a GC benchmark, with a custom VM caching layer
not in TOT yet.

Instruments showed most GC threads spending the majority of their
time sleeping instead of doing useful work. Removing the call to
sleep sped up the benchmark.

  • wtf/TCSpinLock.h:

(TCMalloc_SlowLock): Since a spin lock is only ever held for a short
amount of time, don't sleep for a long amount of time waiting for it
to unlock -- yielding to the scheduler is sufficient.

If we find a case where someone is sitting on a spin lock for over 2ms,
we should fix the spin lock holder, not the spin lock.

12:07 PM Changeset in webkit [117477] by robert@webkit.org
  • 9 edits
    13 adds in trunk

CSS 2.1 failure: table-height-algorithm-023 and -024 fail
https://bugs.webkit.org/show_bug.cgi?id=85405

Reviewed by Eric Seidel.

Source/WebCore:

Treat vertical-align: [length] the same as vertical-align: baseline.

Tests: css2.1/20110323/table-height-algorithm-023.htm

css2.1/20110323/table-height-algorithm-024.htm
fast/table/mozilla-bug10296-vertical-align-1.html
fast/table/mozilla-bug10296-vertical-align-2.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

LayoutTests:

  • css2.1/20110323/table-height-algorithm-023.htm: Added.
  • css2.1/20110323/table-height-algorithm-024.htm: Added.

Tests from the CSS test suite.

  • fast/table/mozilla-bug10296-vertical-align-1.html: Added.
  • fast/table/mozilla-bug10296-vertical-align-2.html: Added.

I split out the part of bug10296-1.html that gets rebaselined here so that the new results
are visible. I also changed the text so that the expected result is less mysterious.

  • platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.txt: Added.
  • platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
  • platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug10296-1-expected.txt:
12:04 PM Changeset in webkit [117476] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix rounding in RenderFlowThread::paintIntoRegion
https://bugs.webkit.org/show_bug.cgi?id=86695

Reviewed by Eric Seidel.

Fix rounding of offset in paintIntoRegion to ensure that we paint on
device pixel boundaries.

Covered by existing tests in fast/regions.

  • platform/graphics/FractionalLayoutPoint.h:

(WebCore::roundedIntPoint):
Add roundedIntPoint(FractionalLayoutSize) function.
(WebCore):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::paintIntoRegion):

12:04 PM Changeset in webkit [117475] by rakuco@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[EFL] Gardening after r116339.

Add platform-specific results for the tests below.

  • platform/efl/fast/repaint/float-overflow-expected.txt: Added.
  • platform/efl/fast/repaint/float-overflow-right-expected.txt: Added.
11:58 AM Changeset in webkit [117474] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Tools

[Qt] Fix MiniBrowser by using correct syntax for qrc URLs
https://bugs.webkit.org/show_bug.cgi?id=86761

Reviewed by Alexis Menard.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::updateVisualMockTouchPoints):

11:57 AM Changeset in webkit [117473] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Parser: Avoid unnecessary ref count churn in token constructors.
<http://webkit.org/b/86667>

Reviewed by Antti Koivisto.

Pass AtomicString by const reference to avoid useless ref count churn
in AtomicHTMLToken() and AtomicXMLToken().

  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):

  • xml/parser/XMLToken.h:

(WebCore::AtomicXMLToken::AtomicXMLToken):

11:50 AM Changeset in webkit [117472] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, unskip another passing test after r117426.

  • platform/efl/test_expectations.txt:
11:48 AM Changeset in webkit [117471] by kling@webkit.org
  • 5 edits in trunk/Source

Make PluginInfoStore properly thread-safe.
<http://webkit.org/b/86648>
<rdar://problem/11451178>

Reviewed by Darin Adler.

Source/WebCore:

  • plugins/PluginData.h:

(WebCore::MimeClassInfo::isolatedCopy):
(WebCore::PluginInfo::isolatedCopy):

Source/WebKit2:

Deep copy the internal storage of PluginInfoStore after constructing it, as we can
be doing this from a secondary thread.

  • Shared/Plugins/PluginModuleInfo.h:

(WebKit::PluginModuleInfo::isolatedCopy):

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::deepIsolatedCopyPluginInfoVector):
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
(WebKit::PluginInfoStore::plugins):

11:44 AM Changeset in webkit [117470] by hbono@chromium.org
  • 34 edits in trunk/Source

[Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=86591

Reviewed by Ryosuke Niwa.

This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection
function to remove platform-specific code from Editor::respondToChangedSelection
function.

No new tests, no change in behavior.

Source/WebCore:

  • editing/Editor.cpp:

(WebCore::Editor::respondToChangedSelection):

  • loader/EmptyClients.h:

(WebCore::EmptyTextCheckerClient::shouldEraseMarkersAfterChangeSelection):

  • platform/text/TextCheckerClient.h:

(TextCheckerClient):

Source/WebKit/blackberry:

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldEraseMarkersAfterChangeSelection):
(WebCore):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::shouldEraseMarkersAfterChangeSelection):
(WebKit):

  • src/EditorClientImpl.h:

(EditorClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::shouldEraseMarkersAfterChangeSelection):
(WebCore):

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::shouldEraseMarkersAfterChangeSelection):
(WebKit):

  • WebCoreSupport/TextCheckerClientGtk.h:

(TextCheckerClientGtk):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldEraseMarkersAfterChangeSelection):

Source/WebKit/qt:

  • WebCoreSupport/TextCheckerClientQt.cpp:

(WebCore::TextCheckerClientQt::shouldEraseMarkersAfterChangeSelection):
(WebCore):

  • WebCoreSupport/TextCheckerClientQt.h:

(TextCheckerClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::shouldEraseMarkersAfterChangeSelection):

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::shouldEraseMarkersAfterChangeSelection):
(WebKit):

  • WebCoreSupport/EditorClientWinCE.h:

(EditorClientWinCE):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::shouldEraseMarkersAfterChangeSelection):
(WebCore):

  • WebKitSupport/EditorClientWx.h:

(EditorClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):
(WebKit):

  • WebProcess/WebCoreSupport/WebEditorClient.h:
11:41 AM Changeset in webkit [117469] by jamesr@google.com
  • 16 edits in trunk/Source

[chromium] Convert GraphicsLayerChromium to use WebLayer types
https://bugs.webkit.org/show_bug.cgi?id=86269

Reviewed by Adrienne Walker.

Source/Platform:

Adds some new WebLayer / WebContentLayer APIs that WebCore::GraphicsLayerChromium needs.

  • chromium/public/WebContentLayer.h:

(WebCore):
(WebKit):
(WebContentLayer):

  • chromium/public/WebLayer.h:

(WebKit):
(WebKit::WebLayer::isNull):
(WebLayer):

  • chromium/public/WebTransformationMatrix.h:

(WebKit::WebTransformationMatrix::~WebTransformationMatrix):

Fix a memory leak - WebPrivateOwnPtr<>s have to be explicitly cleared.

(WebTransformationMatrix):

Source/WebCore:

This converts GraphicsLayerChromium over to use WebLayer and WebContentLayer. The conversion is not completely
as the Web*Layer APIs are not yet quite complete enough to use everywhere, and the PlatformLayer typedef is not
changed in this patch. The places where we have to punch out through API layer are marked by
unwrap<*LayerChromium>() calls and FIXME's in the Web*Layer.h files. There aren't many.

Refactor only, existing tests apply.

  • platform/chromium/support/WebTransformationMatrix.cpp:

(WebKit):
(WebKit::WebTransformationMatrix::reset):
(WebKit::WebTransformationMatrix::projectPoint):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::setName):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::hostLayerForChildren):
(WebCore::GraphicsLayerChromium::layerForParent):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore::GraphicsLayerChromium::hasContentsLayer):
(WebCore::GraphicsLayerChromium::contentsLayer):
(WebCore::GraphicsLayerChromium::primaryLayer):
(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/WebContentLayer.cpp:

(WebKit::WebContentLayer::clearClient):
(WebKit):
(WebKit::WebContentLayer::setDrawsContent):
(WebKit::WebContentLayer::drawsContent):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>):

  • src/WebContentLayerImpl.cpp:
  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • src/WebLayer.cpp:

(WebKit::WebLayer::setSublayerTransform):
(WebKit):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::setIsDrawable):
(WebKit::WebLayer::setPreserves3D):
(WebKit::WebLayer::setDoubleSided):
(WebKit::WebLayer::setBackgroundColor):
(WebKit::WebLayer::setContentsScale):

  • tests/ImageLayerChromiumTest.cpp:

(WebCore::TEST):

11:34 AM Changeset in webkit [117468] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

remove bit rotted comment about css properties
https://bugs.webkit.org/show_bug.cgi?id=86750

Reviewed by Alexis Menard.

It's not clear to me what the first block was even referring to.
Aural doesn't seem to exist anymore. It might be worth keeping,
"All the CSS properties are not supported by the renderer at the
moment.", but it seems obvious to me.

No new tests, just removing a comment.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

11:33 AM Changeset in webkit [117467] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Remove unnecessary expectations for passing tests.
https://bugs.webkit.org/show_bug.cgi?id=86698

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
11:22 AM Changeset in webkit [117466] by enne@google.com
  • 2 edits in trunk/Source/WebCore

Insert source file and line number for v8 function calls into tracing
https://bugs.webkit.org/show_bug.cgi?id=84613

Reviewed by Kentaro Hara.

The trace for v8 function calls doesn't include any information about
what function is being called. Pass this information along so it can
be less opaque.

  • bindings/v8/V8Proxy.cpp:

(WebCore::resourceInfo):
(WebCore):
(WebCore::resourceString):
(WebCore::V8Proxy::instrumentedCallFunction):

  • platform/chromium/TraceEvent.h:

(WebCore::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):

11:21 AM Changeset in webkit [117465] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, unskip some tests after r117426.

  • platform/efl/test_expectations.txt:
11:09 AM Changeset in webkit [117464] by commit-queue@webkit.org
  • 11 edits
    1 copy
    2 adds in trunk

[EFL] Add API for Web Database handling
https://bugs.webkit.org/show_bug.cgi?id=85178

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-17
Reviewed by Antonio Gomes.

Source/WebKit:

Added the new Web Database API to the buildsystem.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Add API for Web Database. This API will allow a browser
to query information about size, name, filename and remove
databases based on the origin. It will be also possible to
list all databases for a given origin.

  • ewk/EWebKit.h:
  • ewk/ewk_security_origin.cpp:

(ewk_security_origin_web_database_get_all):

  • ewk/ewk_security_origin.h:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_settings.h:
  • ewk/ewk_web_database.cpp: Added.

(_Ewk_Web_Database):
(ewk_web_database_display_name_get):
(ewk_web_database_expected_size_get):
(ewk_web_database_filename_get):
(ewk_web_database_name_get):
(ewk_web_database_security_origin_get):
(ewk_web_database_size_get):
(ewk_web_database_remove):
(ewk_web_database_remove_all):
(ewk_web_database_free):
(ewk_web_database_list_free):
(ewk_web_database_new):

  • ewk/ewk_web_database.h: Added.
  • ewk/ewk_web_database_private.h: Copied from Source/WebKit/efl/ewk/EWebKit.h.

(WebCore):

Tools:

Use the newly introduced Web Database API in EFL's DRT.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::clearAllDatabases):

10:54 AM Changeset in webkit [117463] by caio.oliveira@openbossa.org
  • 5 edits in trunk

[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
https://bugs.webkit.org/show_bug.cgi?id=73802

Reviewed by Ryosuke Niwa.

Source/WebCore:

Timeout was caused by an infinite in the outer loop of
pushDownInlineStyleAroundNode(). The outer loop variable 'current' should point at the
node containing 'targetNode'. The inner loop traverse the children of 'current'
and discover the children that contains 'targetNode'.

However, before the inner loop, we call removeInlineStyleFromElement() that can
potentially remove the 'current' node from the tree, moving its children to
'current' former parent. For that reason 'child' and 'lastChild' are collected
before this call.

The tricky part is that changing the 'current' children parent, we might trigger
further side-effects, that can remove either 'child' or 'lastChild' from the tree
too. The infinite loop was due to 'child' being off the document, so it's
nextSibling() is 0, and we go another run of outer loop without changing
'current' because the 'targetNode' wasn't in the first child that inner loop
couldn't reach.

When testing Qt on Mac, there was also a crash in RenderTextControl when the font
family was empty, this patch fixes it as well.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Use NodeVector
instead of relying on first/last child being valid after
removeInlineStyleFromElement() is called. Skip the child if it has no parent,
this is an indication that it was removed from the tree.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::hasValidAvgCharWidth): Empty AtomicStrings aren't
supported by HashSet, so we have to early return in this case.

LayoutTests:

  • platform/qt/Skipped: Unskipped. Note that it is still skipped for wk2 because

setEditingBehavior is not implemented for WebKitTestRunner yet.

10:52 AM Changeset in webkit [117462] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: implement Go To selector for stylesheet files.
https://bugs.webkit.org/show_bug.cgi?id=86751

Reviewed by Yury Semikhatsky.

StyleSheetOutlineDialog is introduced.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/FilteredItemSelectionDialog.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createButtonAndRegisterShortcuts):
(WebInspector.ScriptsPanel.prototype._showOutlineDialog):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StyleSheetOutlineDialog):
(WebInspector.StyleSheetOutlineDialog.show):
(WebInspector.StyleSheetOutlineDialog.prototype.itemTitleAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemKeyAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemsCount):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems.didGetStyleSheet):
(WebInspector.StyleSheetOutlineDialog.prototype.selectItem):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._generateTabId):
(WebInspector.TabbedEditorContainer.prototype.currentFile):

10:50 AM Changeset in webkit [117461] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r117449): Unreviewed, rolling out r117449.
https://bugs.webkit.org/show_bug.cgi?id=86753

Broke many unskipped tests which lack expectations

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
10:27 AM Changeset in webkit [117460] by mitz@apple.com
  • 41 edits in trunk

REGRESSION (r117428): WebKit API/SPI was removed
https://bugs.webkit.org/show_bug.cgi?id=86748

Reverted r117428.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setMediaPlaybackRequiresUserGesture):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setDomainRelaxationForbidden):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setDomainRelaxationForbiddenForURLScheme):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

  • WebKit.order:
  • WebView/WebView.mm:

(+[WebView _setDomainRelaxationForbidden:forURLScheme:]):

  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(WebView::setDomainRelaxationForbiddenForURLScheme):

  • WebView.h:

(WebView):

Source/WebKit2:

  • win/WebKit2.def:

Tools:

  • DumpRenderTree/LayoutTestController.cpp:

(setDomainRelaxationForbiddenForURLSchemeCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

LayoutTests:

  • http/tests/security/setDomainRelaxationForbiddenForURLScheme.html:
10:25 AM Changeset in webkit [117459] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Fix link error caused by not directly linking with edbus
https://bugs.webkit.org/show_bug.cgi?id=86747

Unreviewed build fix.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-17

.:

  • Source/cmake/FindEFL.cmake:

Source/WebKit:

  • PlatformEfl.cmake:
10:20 AM Changeset in webkit [117458] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Build fix, SelectionHandler extra debug logs
https://bugs.webkit.org/show_bug.cgi?id=86743

Reviewed by Antonio Gomes.

Add include for BlackBerryPlatformLog to SelectionHandler.cpp

  • WebKitSupport/SelectionHandler.cpp:
10:05 AM Changeset in webkit [117457] by zandobersek@gmail.com
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed, adding GTK baselines for new tests added in r115641, r116975 and r117339.

  • platform/gtk/css2.1/20110323/inline-table-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-table-002a-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-table-003-expected.txt: Added.
  • platform/gtk/fast/hidpi/image-set-border-image-comparison-expected.txt: Added.
  • platform/gtk/mathml/presentation/mroot-pref-width-expected.txt: Added.
9:35 AM Changeset in webkit [117456] by Csaba Osztrogonác
  • 3 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
9:05 AM Changeset in webkit [117455] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: create SourceFrames with content providers.
https://bugs.webkit.org/show_bug.cgi?id=86742

Reviewed by Vsevolod Vlasov.

Simple refactoring.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame):
(WebInspector.ResourceSourceFrame.prototype.get resource):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._createSourceFrame):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype._ensureContentLoaded):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StyleSourceFrame):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.contentURL):

9:00 AM Changeset in webkit [117454] by yurys@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: error when expanding an HTMLAllCollection object in the console
https://bugs.webkit.org/show_bug.cgi?id=86741

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/console/inspect-html-all-collection.html

  • inspector/InjectedScriptSource.js: take into account that typeof HTMLAllCollection is "undefined"

when checking if object resolved by id is valid.

LayoutTests:

Test that RemoteObject.callFunctionOn can be successfully invoked on a
remote object representing HTMLAllCollection instance.

  • inspector/console/inspect-html-all-collection-expected.txt: Added.
  • inspector/console/inspect-html-all-collection.html: Added.
8:57 AM Changeset in webkit [117453] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix attempt. Changing class to struct in forward declaration.

  • fileapi/File.h:

(WebCore):

8:51 AM Changeset in webkit [117452] by pfeldman@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: convert styles panel into UISourceCodeProvider in the scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=86734

Reviewed by Vsevolod Vlasov.

This change also makes Scripts render ans Source Code under that experiment.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.get toolbarItemLabel):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.StylesUISourceCodeProvider.prototype._initialize):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype._reset):
(WebInspector.StyleSource):
(WebInspector.StyleSourceFrame):
(WebInspector.StyleSourceFrame.prototype.canEditSource):
(WebInspector.StyleSourceFrame.prototype.requestContent):
(WebInspector.StyleSourceFrame.prototype.commitEditing):
(WebInspector.StyleSourceFrame.prototype.afterTextChanged):
(WebInspector.StyleSourceFrame.prototype._clearIncrementalUpdateTimer):
(WebInspector.StyleSourceFrame.prototype._contentChanged):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):

  • inspector/front-end/UISourceCode.js:
  • inspector/front-end/inspector.js:

(WebInspector._createPanels):

8:42 AM Changeset in webkit [117451] by Antti Koivisto
  • 3 edits
    2 adds in trunk

Frame flattening should not expand tiny frames
https://bugs.webkit.org/show_bug.cgi?id=86736

Source/WebCore:

Reviewed by Kenneth Rohde Christiansen.

If a frame has so small fixed size that it is not usefully scrollable on desktop it is probably
not meant to be scrolled. Displaying any otherwise invisible content by expanding the frame
may end up looking like a rendering error.

The patch prevents expansion of frames that have fixed width or height less than 8px.

Test: fast/frames/flattening/iframe-tiny.html

  • rendering/RenderFrameBase.cpp:

(WebCore::shouldExpandFrame):
(WebCore):
(WebCore::RenderFrameBase::layoutWithFlattening):

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • fast/frames/flattening/iframe-tiny-expected.txt: Added.
  • fast/frames/flattening/iframe-tiny.html: Added.
8:21 AM Changeset in webkit [117450] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Web Inspector: assertion failure when inspecting a shared worker in debug mode
https://bugs.webkit.org/show_bug.cgi?id=86726

Reviewed by Pavel Feldman.

No need to keep RefPtr to WorkerThread in a task that will be executed on
that thread, raw pointer can be used instead.

  • inspector/WorkerDebuggerAgent.cpp:
8:19 AM Changeset in webkit [117449] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening failure test cases.
https://bugs.webkit.org/show_bug.cgi?id=86728

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com>, Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-05-17

  • platform/efl/Skipped: removing tests related to editing callbacks functionality.
  • platform/efl/test_expectations.txt: adding new bugs regarding drag'n'drop and spell checking.

Merging tests with particular bugs.

8:17 AM Changeset in webkit [117448] by haraken@chromium.org
  • 16 edits in trunk/Source/WebCore

[V8][Refactoring] Support an optional 'message' argument for throwTypeError()
https://bugs.webkit.org/show_bug.cgi?id=86576

Reviewed by Adam Barth.

As commented in https://bugs.webkit.org/show_bug.cgi?id=84074#c5,
I am planning to refactor a series of confusing throwError()s into
throwError() and throwTypeError().

This patch supports an optional 'message' argument for V8Proxy::throwTypeError().
Also this patch replaces throwError("message", V8Proxy::TypeError) in custom bindings
with V8Proxy::throwTypeError("message").

No tests. No change in behavior.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::throwTypeError):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallback):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallback):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::requestPermissionCallback):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback):

  • bindings/v8/custom/V8WebKitPointConstructor.cpp:

(WebCore::V8WebKitPoint::constructorCallback):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

7:21 AM Changeset in webkit [117447] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Extensions API] pages shown in sidebar are limited in height to 150px
https://bugs.webkit.org/show_bug.cgi?id=86659

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionView):
(WebInspector.ExtensionSidebarPane.prototype.setPage): set default iframe height to 150px, unless already set by user.

  • inspector/front-end/inspector.css: set extension view and iframe elements to "fill", iframe to 100% height.

(iframe.extension):

7:08 AM Changeset in webkit [117446] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[chromium] run-webkit-tests can't work on ubuntu 12.04
https://bugs.webkit.org/show_bug.cgi?id=86565

Patch by Li Yin <li.yin@intel.com> on 2012-05-17
Reviewed by Kent Tamura.

On ubuntu 12.04, the package ttf-thai-tlwg install the Garuda.ttf
into /usr/share/fonts/truetype/tlwg/Garuda.ttf, not /usr/share/fonts/truetype/thai/Garuda.ttf

  • DumpRenderTree/chromium/TestShellLinux.cpp:

(checkAndLoadFontFile):
(setupFontconfig):

6:54 AM Changeset in webkit [117445] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Hover on a breakpoint in breakpoint-pane does not get differentiated.
https://bugs.webkit.org/show_bug.cgi?id=86711

Changed color values with background on hover over breakpoints.

Patch by Sam D <dsam2912@gmail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.

UI change, No new tests.

  • inspector/front-end/inspector.css:

(.breakpoint-list li:hover):

6:35 AM Changeset in webkit [117444] by zandobersek@gmail.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening, adding platform-specific baselines for
two tests affected by r117339.

  • platform/gtk/fast/repaint/float-overflow-expected.txt: Added.
  • platform/gtk/fast/repaint/float-overflow-right-expected.txt: Added.
6:35 AM Changeset in webkit [117443] by epoger@chromium.org
  • 2 edits in trunk/Tools

Add setting of additional_expectations option to
chromium_unittest.test_overrides_and_builder_names(),
so we can test order in which the base and chromium expectations files
are combined.

https://bugs.webkit.org/show_bug.cgi?id=86642

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_overrides_and_builder_names):

6:32 AM Changeset in webkit [117442] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: DOM Breakpoints Pane should allow to Remove All the breakpoints
https://bugs.webkit.org/show_bug.cgi?id=86716

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.

Added a new context menu to provide Remove All DOM breakpoint option.

UI Feature. Tests not required.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype._removeAllBreakpoints):
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):

6:29 AM Changeset in webkit [117441] by kkristof@inf.u-szeged.hu
  • 2 edits
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expectation.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-17

  • platform/qt-5.0-wk2/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added after r117419.
  • platform/qt-5.0-wk2/svg/css/text-gradient-shadow-expected.txt: Added after r117289.
  • platform/qt/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added after r117419.
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt: Update after r117429.
6:26 AM Changeset in webkit [117440] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Patch by Tsarko Yaroslav <eriktsarko@googlemail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.

Bug 71271: [Qt] Web Inspector: local inspector client UI becomes unresponsive on debugger pause during
https://bugs.webkit.org/show_bug.cgi?id=71271

Web Inspector should not belong to any other page groups since it is a specialized debugger window.
The reason for this change is when debugger pauses web page it pauses all the pages in the page group of debuggee.
This leads that Web Inspector front-end is paused too leading to locked Web Inspector GUI (bugzilla ticket 71271).

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::openInspectorFrontend):

6:07 AM Changeset in webkit [117439] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION: http/tests/xmlhttprequest/basic-auth-nopassword.html started to crash with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85632

Unskip the now passing test after Qt5 fix.

  • platform/qt-5.0-wk1/Skipped:
5:52 AM Changeset in webkit [117438] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] svg/zoom/page/zoom-svg-float-border-padding.xml crashes
https://bugs.webkit.org/show_bug.cgi?id=79631

  • platform/qt/Skipped: Try to unskip them.
5:48 AM Changeset in webkit [117437] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: HeapSnapshot: speed-up calculateObjectToWindowDistance
https://bugs.webkit.org/show_bug.cgi?id=86718

The idea is to switch from nodeIndex2distance array to nodeOrdinal2distance external array.
Due to nature of nodeIndex values the original array was sparsed.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get distanceToWindow):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):

5:39 AM Changeset in webkit [117436] by kbalazs@webkit.org
  • 5 edits in trunk

[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620

Reviewed by Csaba Osztrogonác.

Tools:

Reenable TestNetscapePlugin with Qt 4.

  • Tools.pro:

LayoutTests:

Don't disable plugin tests for Qt 4.

  • platform/qt-5.0/Skipped:
  • platform/qt/Skipped:
5:30 AM Changeset in webkit [117435] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt][WK2] fast/events/page-visibility-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=83263

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-17
Reviewed by Kenneth Rohde Christiansen.

Tools:

Handle "preview" state and avoid string conversion.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setPageVisibility):

LayoutTests:

Unskip two page-visibility tests: iframe-propagation-test.html
and transition-test.html.

  • platform/qt-5.0-wk2/Skipped:
5:27 AM Changeset in webkit [117434] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unksip one more now passing test.

  • platform/qt/Skipped:
5:24 AM Changeset in webkit [117433] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unksip a now passing test.

  • platform/qt/Skipped:
5:07 AM Changeset in webkit [117432] by kinuko@chromium.org
  • 7 edits
    2 adds in trunk

Allow FileSystem API implementation to pass snapshot metadata at File creation time
https://bugs.webkit.org/show_bug.cgi?id=78879

Reviewed by Jian Li.

Source/WebCore:

We query File metadata (e.g. size and modifiedTime) when File.size,
lastModifiedTime or webkitSlice() is accessed / called, but in some
platform-specific filesystems it may not be feasible since synchronous
metadata query could take very long time.

This patch adds new File constructor which takes metadata argument
to allow each FileSystem API implementation to pass snapshot metadata
so that File object could cache the given metadata not to make
synchronous query.

We only call this constructor if the filesystem type is neither
Temporary nor Persistent, therefore this patch should not affect
existing code behavior.

Test: fast/filesystem/file-read-after-write.html

  • Modules/filesystem/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::createFile):

  • Modules/filesystem/DOMFileSystemSync.cpp:
  • fileapi/Blob.cpp:

(WebCore::Blob::webkitSlice): Updated implementation.

  • fileapi/Blob.h:
  • fileapi/File.cpp:

(WebCore::File::File): Added new constructor.
(WebCore::File::lastModifiedDate): Updated implementation.
(WebCore::File::size): Updated implementation.
(WebCore::File::captureSnapshot): Updated implementation.

  • fileapi/File.h:

(WebCore::File::createForFileSystemFile): Added.

  • platform/AsyncFileSystem.h:

(AsyncFileSystem): Updated comment.

LayoutTests:

Added tests for making sure metadata is not cached in the regular
temporary filesystem.

  • fast/filesystem/file-metadata-after-write-expected.txt: Added.
  • fast/filesystem/file-metadata-after-write.html: Added.
4:55 AM Changeset in webkit [117431] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating chrome test expectations.

  • platform/chromium/test_expectations.txt:
4:37 AM Changeset in webkit [117430] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[Performance test] Add a micro benchmark for div.firstChild getter
https://bugs.webkit.org/show_bug.cgi?id=86582

Reviewed by Ryosuke Niwa.

We are going to remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

In this bug, we add a micro benchmark for div.firstChild getter.
This benchmark covers 'firstChild', 'lastChild', 'nextSibling' and
'previousSibling' in Dromaeo/dom-traverse.html, and other DOM attributes
that return a Node object.

Multiple test results in my Linux desktop:

RESULT Bindings: first-child= 798.157160346 runs/s
median= 798.004987531 runs/s, stdev= 1.52006063407 runs/s, min= 796.019900498 runs/s, max= 801.001251564 runs/s
RESULT Bindings: first-child= 797.603608554 runs/s
median= 797.872340426 runs/s, stdev= 2.2522621261 runs/s, min= 791.556728232 runs/s, max= 801.001251564 runs/s
RESULT Bindings: first-child= 798.656295468 runs/s
median= 798.004987531 runs/s, stdev= 1.79367478063 runs/s, min= 797.01120797 runs/s, max= 803.011292346 runs/s
RESULT Bindings: first-child= 797.812784267 runs/s
median= 798.004987531 runs/s, stdev= 2.31766523191 runs/s, min= 791.100123609 runs/s, max= 802.005012531 runs/s
RESULT Bindings: first-child= 797.963311597 runs/s
median= 798.004987531 runs/s, stdev= 2.53014907337 runs/s, min= 789.14919852 runs/s, max= 801.001251564 runs/s

  • Bindings/first-child.html: Added.
4:35 AM Changeset in webkit [117429] by kkristof@inf.u-szeged.hu
  • 7 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Test expectation update.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-17

  • platform/qt/fast/block/float/overhanging-tall-block-expected.png:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt:After 117310.
  • platform/qt/fast/repaint/float-overflow-expected.png:
  • platform/qt/fast/repaint/float-overflow-expected.txt: After r117339.
  • platform/qt/fast/repaint/float-overflow-right-expected.png:
  • platform/qt/fast/repaint/float-overflow-right-expected.txt: After r117339.
4:14 AM Changeset in webkit [117428] by gyuyoung.kim@samsung.com
  • 41 edits in trunk

Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
https://bugs.webkit.org/show_bug.cgi?id=86704

Reviewed by Eric Seidel.

.:

  • Source/autotools/symbols.filter: Add setDomainRelaxationForbiddenForURLScheme symbol filter.

Source/WebCore:

Add setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way by means of the InternalSettings interface.

No new tests, since we are improving here the infra-structure for testing
a specific method.

  • testing/InternalSettings.cpp:

(WebCore):
(WebCore::InternalSettings::setDomainRelaxationForbiddenForURLScheme):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

  • public/WebView.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

(WebViewImpl):

Source/WebKit/gtk:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

  • WebKit.order:
  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:
  • WebView.h:

(WebView):

Source/WebKit2:

  • win/WebKit2.def: Add setDomainRelaxationForbiddenForURLScheme symbol filter.

Tools:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Invoke setDomainRelaxationForbiddenForURLScheme functions from internalSettings, because it is able to work in the
cross-port way via the InternalSettings interface.

  • http/tests/security/setDomainRelaxationForbiddenForURLScheme.html:
4:09 AM Changeset in webkit [117427] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing reftests.

  • platform/qt/Skipped:
4:06 AM Changeset in webkit [117426] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[EFL] [DRT] EFL's DumpRenderTree should support LayoutTestController's dumpEditingCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=84835

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-05-17
Reviewed by Eric Seidel.

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp: Call appropriate callbacks for editing actions.

(WebCore::EditorClientEfl::shouldDeleteRange):
(WebCore::EditorClientEfl::shouldBeginEditing):
(WebCore::EditorClientEfl::shouldEndEditing):
(WebCore::EditorClientEfl::shouldInsertText):
(WebCore::EditorClientEfl::shouldChangeSelectedRange):
(WebCore::EditorClientEfl::shouldApplyStyle):
(WebCore::EditorClientEfl::didBeginEditing):
(WebCore::EditorClientEfl::didEndEditing):
(WebCore::EditorClientEfl::shouldInsertNode):

  • WebCoreSupport/EditorClientEfl.h: Add structures needed by editing callbacks.

(Ewk_Should_Insert_Node_Event):
(Ewk_Should_Insert_Text_Event):
(Ewk_Should_Change_Selected_Range_Event):
(Ewk_Should_Apply_Style_Event):

Tools:

Added editing callbacks implementation.

  • DumpRenderTree/efl/CMakeLists.txt: Add EditingCallbacks.cpp to compilation.
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Invoke connectEditingCallbacks.

(DumpRenderTreeChrome::createView):

  • DumpRenderTree/efl/EditingCallbacks.cpp: Added. Dump editing callbacks.

(dumpPath):
(dumpRange):
(insertActionString):
(selectionAffinityString):
(shouldBeginEditing):
(shouldEndEditing):
(shouldInsertNode):
(shouldInsertText):
(shouldDeleteRange):
(shouldChangeSelectedRange):
(shouldApplyStyle):
(editingBegan):
(userChangedContents):
(editingEnded):
(selectionChanged):
(connectEditingCallbacks):

  • DumpRenderTree/efl/EditingCallbacks.h: Added.
4:03 AM Changeset in webkit [117425] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Roll out r117382 because of layout test crashes on EFL debug buildbot.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::initialize):

3:42 AM Changeset in webkit [117424] by noel.gordon@gmail.com
  • 427 edits
    99 copies
    37 adds
    131 deletes in branches/chromium/1132/LayoutTests

Merge 116839 - Optimise and update test expectations after r116636

Unreviewed test expectations update.

  • fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Renamed from LayoutTests/platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt.
  • fast/block/float/014-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/014-expected.txt.
  • fast/images/gray-scale-jpeg-with-color-profile-expected.txt:
  • fast/repaint/backgroundSizeRepaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/backgroundSizeRepaint-expected.txt.
  • fast/repaint/clipped-relative-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/clipped-relative-expected.txt.
  • fast/repaint/selected-replaced-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/selected-replaced-expected.txt.
  • fast/replaced/absolute-image-sizing-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/absolute-image-sizing-expected.txt.
  • fast/replaced/image-onload-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/image-onload-expected.txt.
  • fast/replaced/image-sizing-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/image-sizing-expected.txt.
  • fast/replaced/width100percent-image-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/width100percent-image-expected.txt.
  • fast/writing-mode/background-horizontal-bt-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-horizontal-bt-expected.txt.
  • fast/writing-mode/background-vertical-lr-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-vertical-lr-expected.txt.
  • fast/writing-mode/background-vertical-rl-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-vertical-rl-expected.txt.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize20-expected.png: Added. [ChangeLog snipped: too many to list in drover and gcl]

TBR=noel.gordon@gmail.com

3:16 AM Changeset in webkit [117423] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed attempt to fix a Windows build breakage.

  • public/WebIntent.h:

(WebIntent):

3:09 AM Changeset in webkit [117422] by haraken@chromium.org
  • 2 edits in trunk/Tools

[Performance test] In perftest.py, do not include 'description' in 'results'
https://bugs.webkit.org/show_bug.cgi?id=86696

Reviewed by Csaba Osztrogoná.

'results' in perftest.py should not include any data that is not expected
by the perf bot server. We do not need to send 'description' to the perf bot
server since 'description' is always the same.

Thus this patch just removes 'description' from 'results'.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest.parse_output):
(PerfTest.output_statistics):
(ChromiumStylePerfTest.parse_output):
(PageLoadingPerfTest.run):

2:55 AM Changeset in webkit [117421] by shinyak@chromium.org
  • 7 edits in trunk

ShadowRoot.selection should be ShadowRoot.getSelection()
https://bugs.webkit.org/show_bug.cgi?id=86598

Reviewed by Hajime Morita.

Source/WebCore:

In the latest spec, ShadowRoot.selection is changed to ShadowRoot.getSelection().
So update the implementation.

  • dom/ShadowRoot.cpp:
  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/ShadowRoot.idl:

LayoutTests:

In the latest spec, ShadowRoot.selection is changed to ShadowRoot.getSelection().
So update the tests.

  • editing/shadow/selection-of-orphan-shadowroot.html:
  • editing/shadow/selection-of-shadowroot.html: Removed unnecessary code to

call ShadowRoot.selection by using ShadowRoot.getSelection(). Now ShadowRoot.getSelection()
can be called directly.

2:30 AM Changeset in webkit [117420] by shinyak@chromium.org
  • 13 edits
    2 deletes in trunk/Source/WebCore

[Refactoring] Remove TreeScopeAdjuster
https://bugs.webkit.org/show_bug.cgi?id=86599

Reviewed by Hajime Morita.

It seems the right place of the method of TreeScopeAdjuster are in VisibleSelection
and TreeScope. So we can remove TreeScopeAdjuster.

No new tests, no change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::ancestorInThisScope):
(WebCore):

  • dom/TreeScope.h:

(TreeScope):

  • dom/TreeScopeAdjuster.cpp: Removed.
  • dom/TreeScopeAdjuster.h: Removed.
  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::adjustPositionBefore):
(WebCore):
(WebCore::VisibleSelection::adjustPositionAfter):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):

  • editing/VisibleSelection.h:

(VisibleSelection):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::shadowAdjustedNode):
(WebCore::DOMSelection::shadowAdjustedOffset):

2:24 AM Changeset in webkit [117419] by mnaganov@chromium.org
  • 3 edits
    6 copies in branches/chromium/1132

Merge 117307 - Avoid jumpscroll when entering new text in a multi-line editor.
https://bugs.webkit.org/show_bug.cgi?id=82875

Reviewed by Ryosuke Niwa

Scroll caret to the edge of the viewport in case if a line break or a paragraph
separator is inserted at the end of a multi-line editor. This avoids
undesirable jumpscroll in cases when there is content under the editor.

Tests: editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html

editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html
editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html

  • editing/Editor.cpp:

(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::revealSelectionAfterEditingOperation):

  • editing/Editor.h:

(Editor):

  • editing/input/resources/reveal-utilities.js:

(performJumpAtTheEdgeTest):

  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added.
  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html: Added.
  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea-expected.txt: Added.
  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html: Added.
  • editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable-expected.txt: Added.
  • editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html: Added.

TBR=mnaganov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10382217

2:12 AM Changeset in webkit [117418] by zherczeg@webkit.org
  • 10 edits
    1 delete in trunk/Source/WebCore

NEON intrinsic should be used with arithmetic mode of composite filter
https://bugs.webkit.org/show_bug.cgi?id=86622

Reviewed by Nikolas Zimmermann.

Rewrite hand written assembly code to increase portability and readibility
of the code. Remove the unnecessary FECompositeArithmeticNEON.cpp from the
project

Existing tests cover this issue.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/FEComposite.cpp:

(WebCore):
(WebCore::computeArithmeticPixels):
(WebCore::arithmeticSoftware):
(WebCore::FEComposite::platformArithmeticSoftware):

  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp: Removed.
  • platform/graphics/filters/arm/FECompositeArithmeticNEON.h:

(WebCore):
(WebCore::FEComposite::computeArithmeticPixelsNeon):
(WebCore::FEComposite::platformArithmeticNeon):

2:03 AM Changeset in webkit [117417] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

showNodePath will be useful for debugging purpose.
https://bugs.webkit.org/show_bug.cgi?id=86450

This patch implements showNodePath, which outputs node information in
a xpath-like format, e.g. /HTML/BODY/DIV[@id="test" and position()=0]/P[0]

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-17
Reviewed by Hajime Morita.

No new tests, just adding debugging interface.

  • dom/Node.cpp:

(WebCore::Node::showNodePathForThis):
(WebCore):
(showNodePath):

  • dom/Node.h:

(Node):

1:58 AM Changeset in webkit [117416] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking tests which need rebaselining after r117412.

  • platform/chromium/test_expectations.txt:
1:48 AM Changeset in webkit [117415] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking acid3-test-77.html as fail.

  • platform/chromium/test_expectations.txt:
1:21 AM Changeset in webkit [117414] by g.czajkowski@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Do not check NULL pointer allocated by new.
https://bugs.webkit.org/show_bug.cgi?id=86610

Reviewed by Ryosuke Niwa.

WebKit-Efl doesn't check pointers that are initialized by new.
Those checks are not needed because new operator doesn't return NULL.
Only an overloaded version of new returns NULL pointer.

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_entry_new):

  • ewk/ewk_view.cpp:

(_ewk_view_core_frame_new):

1:18 AM Changeset in webkit [117413] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r116331): RSS Headlines/links are missing (-webkit-box-flex broken?)
https://bugs.webkit.org/show_bug.cgi?id=85991

Source/WebCore:

Fix for regression failures on deprecated flex box test cases.

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-05-17
Reviewed by Eric Seidel.

Test: fast/css/deprecated-flex-box-zero-width-intrinsic-max-width.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):
Fix to use intrinsic width when the fixed width:0 , for deprecated flex boxes.

LayoutTests:

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-05-17
Reviewed by Eric Seidel.

  • fast/css/deprecated-flex-box-zero-width-intrinsic-max-width-expected.txt: Added.
  • fast/css/deprecated-flex-box-zero-width-intrinsic-max-width.html: Added.
1:14 AM Changeset in webkit [117412] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

CSS3 Multicolumn: Content in normal flow extending into column gaps should be clipped at middle of column-gap
https://bugs.webkit.org/show_bug.cgi?id=86441

Patch by Uday Kiran <udaykiran@motorola.com> on 2012-05-17
Reviewed by Eric Seidel.

Source/WebCore:

Content in the normal flow that extends into column gaps (e.g., long words or images)
is clipped in the middle of the column gap.
http://www.w3.org/TR/css3-multicol/#overflow-inside-multicol-elements

Test: fast/multicol/overflow-into-columngap.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnContents):

LayoutTests:

Test for content in normal flow that extends into column gaps.
http://www.w3.org/TR/css3-multicol/#overflow-inside-multicol-elements

  • fast/multicol/overflow-into-columngap-expected.html: Added.
  • fast/multicol/overflow-into-columngap.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
1:06 AM Changeset in webkit [117411] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[Worker] Web Worker lacks test to check the name attribute of SharedWorker
https://bugs.webkit.org/show_bug.cgi?id=86714

Patch by Li Yin <li.yin@intel.com> on 2012-05-17
Reviewed by Kentaro Hara.

Spec: http://www.w3.org/TR/2012/CR-workers-20120501/#sharedworkerglobalscope
The name attribute must return the value it was assigned when the SharedWorkerGlobalScope object was created.
So we should have a test to check it, there is a related test "fast/worker/shared-worker-name.html" already,
but it doesn't cover this.

  • fast/workers/resources/shared-worker-common.js:

(handleMessage):

  • fast/workers/resources/shared-worker-name.js:

(test11.worker.port.onmessage):
(test11):

  • fast/workers/shared-worker-name-expected.txt:
12:46 AM Changeset in webkit [117410] by haraken@chromium.org
  • 2 edits in trunk/Tools

[Performance test] Always fill resultsdescription? in perftest.py
https://bugs.webkit.org/show_bug.cgi?id=86696

Reviewed by Ryosuke Niwa.

This is a follow-up patch for r117397 to fix perf bot failures.
This patch fills resultsdescription? always.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PageLoadingPerfTest.run):

12:30 AM Changeset in webkit [117409] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] fast/frames/frame-crash-with-page-cache.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=85879

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-17
Reviewed by Noam Rosenthal.

Source/WebKit/efl:

_ewk_frame_smart_del() is considering now that the frame can be present in cache.
loader()->detachFromParent() is only applied for the main frame.
loader()->cancelAndClear() is not used anymore.

  • ewk/ewk_frame.cpp:

(_ewk_frame_smart_del):

LayoutTests:

  • platform/efl/test_expectations.txt: Removed fast/frames/frame-crash-with-page-cache.html.
12:27 AM Changeset in webkit [117408] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking input-appearance-range.html as fail.

  • platform/chromium/test_expectations.txt:
12:10 AM Changeset in webkit [117407] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking backgr_position-table.html and some others as fail.

  • platform/chromium/test_expectations.txt:
12:07 AM Changeset in webkit [117406] by Csaba Osztrogonác
  • 18 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening after r117339.
https://bugs.webkit.org/show_bug.cgi?id=84167

  • platform/qt/Skipped:
  • platform/qt/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/qt/editing/selection/iframe-expected.png:
  • platform/qt/editing/selection/iframe-expected.txt:
  • platform/qt/editing/selection/inline-table-expected.png:
  • platform/qt/editing/selection/inline-table-expected.txt:
  • platform/qt/editing/selection/table-caret-3-expected.png:
  • platform/qt/editing/selection/table-caret-3-expected.txt:
  • platform/qt/fast/css-generated-content/inline-display-types-expected.png:
  • platform/qt/fast/css-generated-content/inline-display-types-expected.txt:
  • platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
  • platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
  • platform/qt/fast/inline-block/001-expected.png:
  • platform/qt/fast/inline-block/001-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/qt/test_expectations.txt:

May 16, 2012:

11:54 PM Changeset in webkit [117405] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620

  • platform/qt/Skipped: Skip failing tests after r117288.
11:53 PM Changeset in webkit [117404] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r117372.
http://trac.webkit.org/changeset/117372
https://bugs.webkit.org/show_bug.cgi?id=86710

"triggerring crashes" (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16

Source/WebCore:

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateAudioRateSignalValues):
(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):

  • Modules/webaudio/AudioParam.h:

(WebCore::AudioParam::context):
(WebCore::AudioParam::hasSampleAccurateValues):
(WebCore::AudioParam::AudioParam):
(AudioParam):

LayoutTests:

  • webaudio/audioparam-connect-audioratesignal.html:
  • webaudio/audioparam-summingjunction-expected.txt: Removed.
  • webaudio/audioparam-summingjunction.html: Removed.
11:40 PM Changeset in webkit [117403] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening after r117373.

  • platform/gtk/fast/forms/input-align-image-expected.txt:
  • platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
11:36 PM Changeset in webkit [117402] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r117396.
http://trac.webkit.org/changeset/117396
https://bugs.webkit.org/show_bug.cgi?id=86709

"breaks chromium tree" (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16

  • WebKit.gyp:
  • public/WebTextInputInfo.h: Removed.
  • public/WebTextInputType.h:
  • public/WebWidget.h:

(WebKit::WebWidget::textInputType):

  • src/WebTextInputInfo.cpp: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputType):

  • src/WebViewImpl.h:

(WebViewImpl):

11:22 PM Changeset in webkit [117401] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620

  • platform/qt/Skipped: Skip failing tests after r117288.
11:20 PM Changeset in webkit [117400] by morrita@google.com
  • 2 edits
    6 moves
    3 adds
    2 deletes in trunk/LayoutTests

Unreviewed expectations update.

  • fast/repaint/float-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-expected.png.
  • fast/repaint/float-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-expected.txt.
  • fast/repaint/float-overflow-right-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-right-expected.png.
  • fast/repaint/float-overflow-right-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-right-expected.txt.
  • platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.txt: Added.
  • platform/chromium-mac/fast/repaint/float-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/float-overflow-expected.txt: Renamed from LayoutTests/platform/gtk/fast/repaint/float-overflow-expected.txt.
  • platform/chromium-mac/fast/repaint/float-overflow-right-expected.png: Added.
  • platform/chromium-mac/fast/repaint/float-overflow-right-expected.txt: Renamed from LayoutTests/platform/gtk/fast/repaint/float-overflow-right-expected.txt.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/repaint/float-overflow-expected.png: Removed.
  • platform/gtk/fast/repaint/float-overflow-right-expected.png: Removed.
11:17 PM Changeset in webkit [117399] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Restore accidentally changed copyrights.
https://bugs.webkit.org/show_bug.cgi?id=86471

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-05-16
Reviewed by Antonio Gomes.

Restore accidentally changed copyrights.

  • ewk/ewk_js_private.h:
  • ewk/ewk_security_origin_private.h:
  • ewk/ewk_view_private.h:
10:18 PM Changeset in webkit [117398] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Get text direction at the start and end of selection.
https://bugs.webkit.org/show_bug.cgi?id=86573

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-05-16
Reviewed by Adam Barth.

Add an interface to get text direction at the start and end of
selection for Android, as on Android different selection delimiters
are needed for RTL text. Unlike other platforms, the start and end
delimiters of selection are different, so we need determine the shape
of delimiter based on text direction.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::selectionTextDirection):

  • src/WebViewImpl.cpp:

(WebKit):
(WebKit::WebViewImpl::selectionTextDirection):

  • src/WebViewImpl.h:

(WebViewImpl):

10:16 PM Changeset in webkit [117397] by haraken@chromium.org
  • 4 edits in trunk

[Performance test] Support "description" for PerfTestRunner.run and PerfTestRunner.runPerSecond
https://bugs.webkit.org/show_bug.cgi?id=86696

Reviewed by Ryosuke Niwa.

We want to add some description for each PerfTestRunner.run and
PerfTestRunner.runPerSecond, so that people can know what each
run is testing.

Output example:

$ ./Tools/Scripts/run-perf-tests Bindings/first-child.html
Running Bindings/first-child.html (1 of 1)
DESCRIPTION: Benchmark for DOM attributes that return a Node object.
RESULT Bindings: first-child= 788.359076534 runs/s
median= 797.508097751 runs/s, stdev= 19.0972905207 runs/s, min= 746.666666667 runs/s, max= 801.001251564 runs/s

PerformanceTests:

  • resources/runner.js:

(PerfTestRunner.logStatistics):
(PerfTestRunner.printStatistics):
(PerfTestRunner.runPerSecond):

Tools:

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):
(PerfTest.parse_output):
(PerfTest.output_statistics):

10:03 PM Changeset in webkit [117396] by abarth@webkit.org
  • 6 edits
    1 copy
    1 add in trunk/Source/WebKit/chromium

[Chromium] Implement WebViewImpl::textInputInfo() for Android
https://bugs.webkit.org/show_bug.cgi?id=86440

Reviewed by Darin Fisher.

This patch adds WebView::textInputInfo(), which describes the text
input that currently has focus. Android is planning to use this to
determine what sort of keyboard or text entry UI to show. This API
subsumes the textInputType() API, which will be removed once the
clients have been updated.

  • WebKit.gyp:
  • public/WebTextInputInfo.h: Added.

(WebKit):
(WebTextInputInfo):
(WebKit::WebTextInputInfo::WebTextInputInfo):
(WebKit::operator==):
(WebKit::operator!=):

  • public/WebTextInputType.h:
  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::textInputInfo):
(WebKit::WebWidget::textInputType):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputInfo):
(WebKit):
(WebKit::WebViewImpl::textInputType):

  • src/WebViewImpl.h:

(WebViewImpl):

9:53 PM Changeset in webkit [117395] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Fix bug number for video-controls-drag.html in the test_expectation.txt
https://bugs.webkit.org/show_bug.cgi?id=86607

Unreviewed EFL gardening.

Change BUGWK number to point to right patch.

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-16

  • platform/efl/test_expectations.txt:
9:37 PM Changeset in webkit [117394] by hayato@chromium.org
  • 15 edits
    2 adds in trunk

Implement a Shadow DOM spec's section 6 'Events'.
https://bugs.webkit.org/show_bug.cgi?id=78586

Reviewed by Dimitri Glazkov.

Source/WebCore:

This implements a Shadow DOM spec's section 6 'Events', introducing a new
algorithm so that event dispatching use a composed shadow DOM tree,
instead of normal DOM tree, in dispatching events to each node.

The spec is here: http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events

Summary of changes:

  • Attaching shadow DOM does not affect an event dispatching

behavior of enclosing DOM tree. This applies even if some nodes
are distributed to insertion points. We keep a compatibility of
existing event dispatching mechanism so that we won't break Web.

  • Event ancestors, which are used in dispatching events in capture (or

bubble) phase, are now the result of traversing ancestors in composed
shadow DOM tree order, instead of normal DOM tree order.

  • Event's target and related-target are correctly adjusted so that

we don't leak any node which is inaccessible from the event's
current-target node. We enforce both upper and lower boundary
encapsulation of Shadow DOM in event dispatching

Here is an example of event dispatching. Suppose we have the following DOM tree, which
includes some nested shadow hosts and insertion points
A
`--B-----[SR-B]

C `--G--------------[SR-G]
| `-D<H select=C>J---------------[SR-J]

-E -<I select=E> | -<K select=H> -<N select=K>

`-F |

`--L---------------[SR-L]

-<M select=I> -<O select=M>

Notation: [SR-X]: Shadow Root

<X select=Y>: Insertion Point, called X, which selects Y.

If a mouse moves from node '#F' to node '#D', the following
'mouseover' events are dispatched in each ancestor node:

[currentTarget] [target] [related-target]

#D #D #F
#C #D #F
#H #H #I
#K #K #M
#N #N #M
#SR-J #N #M
#J #K #M
#SR-G #K #M
#G #H #I
#SR-B #H #I
#B #D #F
#A #D #F

Details are:

  • Insertion points, such as <content> or <shadow>, are resolved correctly

in calculating event ancestors. That means if a node is distributed to
an insertion point, the insertion point is now an ancestor of the node in
bubbling (or capturing) events.

  • Both insertion points and shadow roots now can receive events. We can add

event listeners to insertion points and shadow roots.

  • Dispatched event's target is now adjusted correctly using the re-targeting

algorithm. The algorithm is now fully aware of insertion points.

  • Dispatched event's related-target can now differ in each tree scope of

event ancestors. We choose the most appropriate related-target using the
related target resolution algorithm for each node.

Performance consideration:
This patch can achieve the competitive performance. The results of
./Tools/Scripts/run-perf-tests PerformanceTests/DOM/Events.html for
before/after this patch are:

Before applying this patch:

Running DOM/Events.html (1 of 1)
RESULT DOM: Events= 270.310714286 ms
median= 269.75 ms, stdev= 2.0042397663 ms, min= 267.357142857 ms, max= 276.5 ms

After applying this patch:

Running DOM/Events.html (1 of 1)
RESULT DOM: Events= 268.108333333 ms
median= 267.5 ms, stdev= 2.41883157195 ms, min= 263.625 ms, max= 273.142857143 ms

I've also conducted a micro benchmark using both
Shadow-Free-DOM-Tree and DOM-Tree-With-Shadow-Host.
See https://bugs.webkit.org/show_bug.cgi?id=78586#c40 for the results.
It seems that the new implementation has more capabilities, but
doesn't sacrifice a performance of event dispatching in either cases.

Test: fast/dom/shadow/shadow-dom-event-dispatching.html

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::parentIncludingInsertionPointAndShadowRoot):
(WebCore):
(WebCore::ComposedShadowTreeWalker::traverseParentIncludingInsertionPointAndShadowRoot):

  • dom/ComposedShadowTreeWalker.h:

(ComposedShadowTreeWalker):

  • dom/EventContext.cpp:

(WebCore::EventContext::EventContext):
(WebCore::EventContext::handleLocalEvents):

  • dom/EventContext.h:

(EventContext):
(WebCore::EventContext::relatedTarget):
(WebCore):
(WebCore::EventContext::setRelatedTarget):

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::EventRelatedTargetAdjuster):
(WebCore):
(WebCore::EventRelatedTargetAdjuster::adjust):
(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):
(WebCore::EventDispatcher::adjustRelatedTarget):
(WebCore::EventDispatcher::ensureEventAncestors):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::determineDispatchBehavior):

  • dom/EventDispatcher.h:

(WebCore):
(EventRelatedTargetAdjuster):
(EventDispatcher):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:

(WebCore::toMouseEvent):
(WebCore):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching.html: Added.
  • platform/efl/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
9:28 PM Changeset in webkit [117393] by noel.gordon@gmail.com
  • 1 edit
    3 copies
    4 adds in branches/chromium/1132/LayoutTests/platform

Merge 116725 - [chromium] Rebaseline compositing/geometry/horizontal-scroll-composited.html after r107389

Unreviewed test expectations update.

  • platform/chromium-linux-x86/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-linux/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win-xp/compositing/geometry/horizontal-scroll-composited-expected.png: Added.

TBR=noel.gordon@gmail.com
Review URL: https://chromiumcodereview.appspot.com/10388180

9:09 PM Changeset in webkit [117392] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

Moving caret up or down skips lines when there's a non-editable line
https://bugs.webkit.org/show_bug.cgi?id=81490

Reviewed by Eric Seidel.

Source/WebCore:

The bug was caused by previousRootInlineBoxCandidatePosition and nextRootInlineBoxCandidatePosition
skipping leaf nodes that constitute a new line and belong to the same editable region because block elements
that separate lines are not editable so it looked as if all editable lines belong to a single line as far as
those two functions are concerned.

Fixed the bug by using the first leaf node that belongs to the same editable region but does not belong in
the same as the start node.

This patch is based on a patch authored by Yi Shen (Nokia).

Test: editing/selection/move-between-lines-of-different-editabilities.html

  • editing/visible_units.cpp:

(WebCore::previousRootInlineBoxCandidatePosition):
(WebCore::nextRootInlineBoxCandidatePosition):

LayoutTests:

Added a regression test.

  • editing/selection/move-between-lines-of-different-editabilities.html: Added.
  • editing/selection/move-by-word-visually-mac-expected.txt: Rebaselined a test case. It failed

before this change and still fails after this change.

8:58 PM Changeset in webkit [117391] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix Mac SL build.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
8:55 PM Changeset in webkit [117390] by macpherson@chromium.org
  • 6 edits
    31 adds in trunk/LayoutTests

Add tests for CSS Variables.
https://bugs.webkit.org/show_bug.cgi?id=86575

Reviewed by Dimitri Glazkov.

  • fast/css/variables/colors-test-expected.html: Added.
  • fast/css/variables/colors-test.html: Added.
  • fast/css/variables/complex-cycle-expected.html: Added.
  • fast/css/variables/complex-cycle.html: Added.
  • fast/css/variables/computed-style-expected.html: Added.
  • fast/css/variables/computed-style.html: Added.
  • fast/css/variables/inherited-values-expected.html: Added.
  • fast/css/variables/inherited-values.html: Added.
  • fast/css/variables/inline-styles-expected.html: Added.
  • fast/css/variables/inline-styles.html: Added.
  • fast/css/variables/invalid-shorthand-expected.html: Added.
  • fast/css/variables/invalid-shorthand.html: Added.
  • fast/css/variables/invalid-variable-value-expected.html: Added.
  • fast/css/variables/invalid-variable-value.html: Added.
  • fast/css/variables/multi-level-cycle-expected.html: Added.
  • fast/css/variables/multi-level-cycle.html: Added.
  • fast/css/variables/redefinition-expected.html: Added.
  • fast/css/variables/redefinition.html: Added.
  • fast/css/variables/shorthand-expected.html: Added.
  • fast/css/variables/shorthand.html: Added.
  • fast/css/variables/simple-cycle-expected.html: Added.
  • fast/css/variables/simple-cycle.html: Added.
  • fast/css/variables/undefined-expected.html: Added.
  • fast/css/variables/undefined.html: Added.
  • fast/css/variables/use-before-defined-expected.html: Added.
  • fast/css/variables/use-before-defined.html: Added.
  • fast/css/variables/var-inside-shorthand-expected.html: Added.
  • fast/css/variables/var-inside-shorthand.html: Added.
  • fast/css/variables/variable-chain-expected.html: Added.
  • fast/css/variables/variable-chain.html: Added.
  • platform/chromium/test_expectations.txt: Skip tests until variables implementation lands.
  • platform/efl/test_expectations.txt: Skip tests until variables implementation lands.
  • platform/gtk/test_expectations.txt: Skip tests until variables implementation lands.
  • platform/mac/test_expectations.txt: Skip tests until variables implementation lands.
  • platform/qt/test_expectations.txt: Skip tests until variables implementation lands.
8:52 PM Changeset in webkit [117389] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking failing test.

  • platform/chromium/test_expectations.txt:
8:37 PM Changeset in webkit [117388] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

Use pixelSnappedLogicalHeight for TableSection layout
https://bugs.webkit.org/show_bug.cgi?id=86665

Reviewed by Eric Seidel.

We do table layout using integers to ensure we follow the spec (see
https://trac.webkit.org/wiki/LayoutUnit for details), but were previously
flooring the logical height used in layoutRows. This caused us to mis-
calculate the intrinsic padding and grow cells beyond their proper height.

No new tests. Fully covered by existing tests with sub-pixel enabled.

  • rendering/RenderBox.h:

(WebCore::RenderBox::pixelSnappedLogicalHeight): Added these convenience
methods.
(WebCore::RenderBox::pixelSnappedLogicalWidth):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

8:35 PM Changeset in webkit [117387] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking failing test.

  • platform/chromium/test_expectations.txt:
8:24 PM Changeset in webkit [117386] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking cross-fade-background-image.html as failing.

  • platform/chromium/test_expectations.txt:
8:19 PM Changeset in webkit [117385] by tony@chromium.org
  • 65 edits in trunk

rename display:-webkit-flexbox to display:-webkit-flex
https://bugs.webkit.org/show_bug.cgi?id=86529

Reviewed by Eric Seidel.

Source/WebCore:

Also renames -webkit-inline-flexbox to -webkit-inline-flex.

No new tests. Covered by existing tests.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in: Update keyword values.
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/style/RenderStyleConstants.h: Rename const values.

LayoutTests:

  • css3/flexbox/anonymous-block-merge-crash.html:
  • css3/flexbox/anonymous-block.html:
  • css3/flexbox/auto-height-dynamic.html:
  • css3/flexbox/child-overflow.html:
  • css3/flexbox/columns-auto-size.html:
  • css3/flexbox/cross-axis-scrollbar.html:
  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/display-flexbox-set-get-expected.txt:
  • css3/flexbox/display-flexbox-set-get.html:
  • css3/flexbox/flex-algorithm-min-max.html:
  • css3/flexbox/flex-algorithm-with-margins.html:
  • css3/flexbox/flex-algorithm.html:
  • css3/flexbox/flex-align-baseline.html:
  • css3/flexbox/flex-align-column.html:
  • css3/flexbox/flex-align-end.html:
  • css3/flexbox/flex-align-max.html:
  • css3/flexbox/flex-align-percent-height.html:
  • css3/flexbox/flex-align-stretch.html:
  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/flex-flow-border.html:
  • css3/flexbox/flex-flow-margins-auto-size.html:
  • css3/flexbox/flex-flow-margins.html:
  • css3/flexbox/flex-flow-orientations.html:
  • css3/flexbox/flex-flow-overflow.html:
  • css3/flexbox/flex-flow-padding.html:
  • css3/flexbox/flex-flow.html:
  • css3/flexbox/flex-item-child-overflow.html:
  • css3/flexbox/flex-no-flex.html:
  • css3/flexbox/flex-order.html:
  • css3/flexbox/flex-pack.html:
  • css3/flexbox/flexbox-overflow-auto-expected.html:
  • css3/flexbox/flexbox-overflow-auto.html:
  • css3/flexbox/floated-flexbox.html:
  • css3/flexbox/insert-text-crash.html:
  • css3/flexbox/line-wrapping.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-column-auto.html:
  • css3/flexbox/multiline-line-pack-horizontal-column.html:
  • css3/flexbox/multiline-line-pack.html:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-reverse-wrap-baseline.html:
  • css3/flexbox/multiline-reverse-wrap-overflow.html:
  • css3/flexbox/multiline-shrink-to-fit.html:
  • css3/flexbox/multiline.html:
  • css3/flexbox/nested-stretch.html:
  • css3/flexbox/orthogonal-flex-directions.html:
  • css3/flexbox/position-absolute-child.html:
  • css3/flexbox/preferred-widths-orthogonal.html:
  • css3/flexbox/preferred-widths.html:
  • css3/flexbox/repaint-rtl-column.html:
  • css3/flexbox/repaint.html:
  • css3/flexbox/true-centering.html:
  • css3/flexbox/writing-modes.html:
8:17 PM Changeset in webkit [117384] by commit-queue@webkit.org
  • 18 edits
    4 copies
    8 adds in trunk

IDL and implementation for Web Intents delivery
https://bugs.webkit.org/show_bug.cgi?id=83634

Patch by Greg Billock <gbillock@google.com> on 2012-05-16
Reviewed by Adam Barth.

Source/WebCore:

The delivered intent has some extra fields and methods (extras,
postResult, postFailure) from the invocation intent. It is implemented
as a subclass. Responses from the service JS are passed to an embedder
client object provided when the intent is delivered.
See http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
Test: webintents/web-intents-delivery.html

  • Modules/intents/DOMWindowIntents.cpp: Copied from Source/WebCore/Modules/intents/DOMWindowIntents.idl.

(WebCore):
(WebCore::DOMWindowIntents::DOMWindowIntents):
(WebCore::DOMWindowIntents::~DOMWindowIntents):
(WebCore::DOMWindowIntents::from):
(WebCore::DOMWindowIntents::webkitIntent):
(WebCore::DOMWindowIntents::deliver):

  • Modules/intents/DOMWindowIntents.h: Copied from Source/WebCore/Modules/intents/DOMWindowIntents.idl.

(WebCore):
(DOMWindowIntents):

  • Modules/intents/DOMWindowIntents.idl:
  • Modules/intents/DeliveredIntent.cpp: Copied from Source/WebCore/Modules/intents/Intent.h.

(WebCore):
(WebCore::DeliveredIntent::create):
(WebCore::DeliveredIntent::DeliveredIntent):
(WebCore::DeliveredIntent::ports):
(WebCore::DeliveredIntent::getExtra):
(WebCore::DeliveredIntent::postResult):
(WebCore::DeliveredIntent::postFailure):

  • Modules/intents/DeliveredIntent.h: Copied from Source/WebCore/Modules/intents/Intent.h.

(WebCore):
(DeliveredIntent):
(WebCore::DeliveredIntent::~DeliveredIntent):

  • Modules/intents/DeliveredIntent.idl: Copied from Source/WebCore/Modules/intents/Intent.h.
  • Modules/intents/Intent.h:

(WebCore::Intent::~Intent):
(Intent):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/v8/custom/V8DeliveredIntentCustom.cpp: Copied from Source/WebCore/Modules/intents/Intent.h.

(WebCore):
(WebCore::V8DeliveredIntent::portsAccessorGetter):

Source/WebKit/chromium:

The embedder will implement the WebDeliveredIntentClient interface, which
will get notifications of postResult/postFailure from the service page.

  • public/WebDeliveredIntentClient.h:
  • public/WebFrame.h:

(WebKit):
(WebFrame):

  • src/WebDeliveredIntentClient.cpp:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::deliverIntent):
(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

8:14 PM Changeset in webkit [117383] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

[V8][Refactoring] Replace throwError("message", XXXError)
with throwError(XXXError, "message")
https://bugs.webkit.org/show_bug.cgi?id=86579

Reviewed by Adam Barth.

This is one of a series of refactoring commented in
https://bugs.webkit.org/show_bug.cgi?id=84074#c5

Currently there are two equivalent throwError()s; i.e. throwError("message", XXXError)
and throwError(XXXError, "message"). In this bug we replace
throwError("message", XXXError) with throwError(XXXError, "message")
(except for the case where XXXError == TypeError. This is because
throwError("message", TypeError) will be replaced with throwTypeError("message")
in a follow-up patch).

No tests. No change in behavior.

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectPropertyEnumerator):

  • bindings/v8/V8Proxy.cpp:

(WebCore::handleMaxRecursionDepthExceeded):

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallback):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::appendCallback):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

7:59 PM Changeset in webkit [117382] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] appcache tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86619

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16
Reviewed by Gustavo Noronha Silva.

Correctly set the application cache database path in EFL's
DumpRenderTree initialization code.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::initialize):

7:21 PM Changeset in webkit [117381] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Pass Isolate to remaining toV8()
https://bugs.webkit.org/show_bug.cgi?id=86570

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to toV8(). I've landed a bunch of
patches to pass Isolate to toV8(), and this would be the last
patch for passing Isolate to toV8().

No tests. No change in behavior.

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::getNamedItems):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

7:18 PM Changeset in webkit [117380] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Add new build slave for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=86567

Reviewed by Ryosuke Niwa.

Add a build slave for EFL 32-bit linux build.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
7:18 PM Changeset in webkit [117379] by jamesr@google.com
  • 13 edits in trunk/Source

GraphicsContext3D interface should not be aware of CanvasRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=86550

Reviewed by Darin Adler.

Source/WebCore:

GraphicsContext3D is a WebCore/platform API construct. CanvasRenderingContext is a WebCore/html concept. Thus,
the former shouldn't depend on the latter. In turns out that all everyone ever wants from a
CanvasRenderingContext in GraphicsContext3D is its underlying ImageBuffer, which is a WebCore/platform concept,
so this just updates the APIs and implementations to use that instead.

Refactor only, no new tests.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cairo/DrawingBufferCairo.cpp:

(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/clutter/DrawingBufferClutter.cpp:

(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):

  • platform/graphics/gpu/DrawingBuffer.h:
  • platform/graphics/gpu/qt/DrawingBufferQt.cpp:

(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):

Source/WebKit/chromium:

Updates chromium implementation of GraphicsContext3D for API change and removes a bunch of unnecessary
#includes.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

7:09 PM Changeset in webkit [117378] by commit-queue@webkit.org
  • 9 edits in trunk

[EFL] Support for Battery Status API on the WebKit-Efl
https://bugs.webkit.org/show_bug.cgi?id=83254

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-16
Reviewed by Chang Shu.

.:

Add dependency check for e_ukit package which is in the e_dbus library.

  • Source/cmake/FindEFL.cmake:

Source/WebKit:

Add e_ukit library and include directory to get battery status of device.

  • PlatformEfl.cmake:

Source/WebKit/efl:

The set of e_dbus libraries, e_ukit library in particular, enables to support all types of battery status events (e.g., charging, chargingTime, dischargingTime, level).

  • WebCoreSupport/BatteryClientEfl.cpp:

(WebCore::BatteryClientEfl::BatteryClientEfl):
(WebCore::BatteryClientEfl::startUpdating):
(WebCore::BatteryClientEfl::stopUpdating):
(WebCore::BatteryClientEfl::setBatteryStatus):
(WebCore):
(WebCore::BatteryClientEfl::timerFired):
(WebCore::BatteryClientEfl::getBatteryStatus):
(WebCore::BatteryClientEfl::setBatteryClient):

  • WebCoreSupport/BatteryClientEfl.h:

(WebCore::BatteryClientEfl::batteryStatus):
(BatteryClientEfl):

Tools:

Add e_dbus libraries to jhbuild's modules list.

  • efl/jhbuild.modules:
6:36 PM Changeset in webkit [117377] by jsbell@chromium.org
  • 7 edits in trunk/Source/WebCore

SerializedScriptValue: lazy initialization of static nullValue not threadsafe
https://bugs.webkit.org/show_bug.cgi?id=70833

Reviewed by Kentaro Hara.

Remove unsafe lazy initialization of static |null| SSV. None of the callers
appeared to be in performance-critical areas - most were preparing an event to
be dispatched to script - so no per-call-site caching was added.

No new tests - no functional changes.

  • bindings/js/SerializedScriptValue.cpp: Mint a new one each time.

(WebCore::SerializedScriptValue::nullValue):

  • bindings/js/SerializedScriptValue.h: Return via PassRefPtr.
  • bindings/v8/SerializedScriptValue.cpp: Mint a new one each time.

(WebCore::SerializedScriptValue::nullValue):

  • bindings/v8/SerializedScriptValue.h: Return via PassRefPtr.

(SerializedScriptValue):

  • dom/Document.cpp:

(WebCore::Document::statePopped): Change to PassRefPtr to maintain refcount.

  • dom/Document.h:

(Document):

6:31 PM Changeset in webkit [117376] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

CachedImage does not clear the ImageObserver pointer when dropping its Image ref
https://bugs.webkit.org/show_bug.cgi?id=86689

Reviewed by Eric Seidel.

Image instances keep a weak pointer to their ImageObserver, which may be null. CachedImage is an ImageObserver
and holds a RefPtr<Image> m_image. When CachedImage initializes its m_image to either an SVGImage or BitmapImage,
it sets itself as that Image's ImageObserver. However, CachedImage never clears the ImageObserver pointer, even
when dropping its reference to the Image. This means if other code holds a RefPtr<Image> there is no promise
that calls on that Image will be valid. This patch clears the CachedImage::m_image's ImageObserver pointer
whenever the CachedImage drops its reference. Image already has null checks for its m_imageObserver so this is
always a safe operation.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::~CachedImage):
(WebCore::CachedImage::clear):

6:28 PM Changeset in webkit [117375] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Fix a broken copyright of V8SVGElementCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=86569

Reviewed by Nate Chapin.

This patch just fixes a broken copyright of V8SVGElementCustom.cpp.

Blame changeset: r54153

No tests. No change in behavior.

  • bindings/v8/custom/V8SVGElementCustom.cpp:
6:19 PM Changeset in webkit [117374] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Pass Isolate to convertEventTargetToV8Object()
https://bugs.webkit.org/show_bug.cgi?id=86566

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to convertEventTargetToV8Object().
I made the 'isolate' argument optional, since
convertEventTargetToV8Object() can be called from the WebCore context.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(NativeToJSValue):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore):
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):

6:17 PM Changeset in webkit [117373] by pkasting@chromium.org
  • 2 edits in trunk/Source/WebCore

Correctly display malformed GIFs which specify bogus extension block
sizes.
https://bugs.webkit.org/show_bug.cgi?id=86531

Reviewed by James Robinson.

This was broken by r117333, which was an attempt to avoid memory errors
on GIFs that were malformed in a similar way. It turns out some GIFs
in the wild (i.e. "our LayoutTests directory") relied on some of the
effects of the old code. This refixes in a way that doesn't break
these.

No new tests, covered by existing tests.

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::read):

6:14 PM Changeset in webkit [117372] by crogers@google.com
  • 5 edits
    2 adds in trunk

AudioParam must support fan-in (multiple audio connections)
https://bugs.webkit.org/show_bug.cgi?id=83610

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/audioparam-summingjunction.html

  • Modules/webaudio/AudioParam.cpp:
  • Modules/webaudio/AudioParam.h:

(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateAudioRateSignalValues):
Sums intrinsic parameter value with all audio-rate connections.

(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):
Support multiple connections.

(WebCore::AudioParam::hasSampleAccurateValues):
If we have one or more audio-rate connections.

(WebCore::AudioParam::AudioParam):
AudioParam now sub-classes AudioSummingJunction.

LayoutTests:

  • webaudio/audioparam-connect-audioratesignal.html:
  • webaudio/audioparam-summingjunction-expected.txt: Added.
  • webaudio/audioparam-summingjunction.html: Added.
5:46 PM Changeset in webkit [117371] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Pass Isolate to createV8HTMLWrapper() and createV8SVGWrapper()
https://bugs.webkit.org/show_bug.cgi?id=86558

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to createV8HTMLWrapper() and createV8SVGWrapper().

Basically 'isolate' has been implemented as the last argument
but before 'forceNewObject' argument, because 'forceNewObject' is an optional
argument and omitted in most cases. Due to the convention,
this patch puts 'isolate' before 'forceNewObject'.

No tests. No change in behavior.

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

  • dom/make_names.pl:

(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

5:42 PM Changeset in webkit [117370] by fpizlo@apple.com
  • 6 edits in branches/dfgopt/Source/JavaScriptCore

DFG should have sparse conditional constant propagation
https://bugs.webkit.org/show_bug.cgi?id=86580

Reviewed by Oliver Hunt.

This enhances CFA so that if it suspects at any point during the fixpoint that a
branch will only go one way, then it only propagates in that one way.

This vastly increases the opportunities for CFG simplification. For example, it
enables us to evaporate this loop:

for (var i = 0; i < 1; ++i) doThings(i);

As a result, it uncovered loads of bugs in the CFG simplifier. In particular:

  • Phi fixup was assuming that all Phis worth fixing up are shouldGenerate(). That's not true; we also fixup Phis that are dead.


  • GetLocal fixup was assuming that it's only necessary to rewire links to a GetLocal, and that the GetLocal's own links don't need to be rewired. Untrue, because the GetLocal may not be rewirable (first block has no GetLocal for r42 but second block does have a GetLocal), in which case it will refer to a Phi in the second block. We need it to refer to a Phi from the first block to ensure that subsequent transformations work.


  • Tail operand fixup was ignoring the fact that Phis in successors may contain references to the children of our tail variables. Hence, successor Phi child substitution needs to use the original second block variable table as its prior, rather than trying to reconstruct the prior later (since by that point the children of the second block's tail variables will have been fixed up, so we will not know what the prior would have been).
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::reset):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::branchDirectionToString):
(AbstractState):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::OperandSubstitution):
(OperandSubstitution):
(JSC::DFG::CFGSimplificationPhase::skipGetLocal):
(JSC::DFG::CFGSimplificationPhase::recordPossibleIncomingReference):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::changeEdge):

5:30 PM Changeset in webkit [117369] by rniwa@webkit.org
  • 11 edits
    1 delete in trunk/Source/WebCore

Move showStyle from CSSStyleDeclaration to StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=86675

Reviewed by Andreas Kling.

Moved the function. Also deleted CSSStyleDeclaration.cpp since it's no longer needed.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/CSSStyleDeclaration.cpp:

(WebCore):

  • css/CSSStyleDeclaration.h:

(CSSStyleDeclaration):

  • css/StylePropertySet.cpp:

(WebCore):
(WebCore::StylePropertySet::showStyle):

  • css/StylePropertySet.h:

(StylePropertySet):

5:28 PM Changeset in webkit [117368] by mrobinson@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix the indexed database build for GTK+.

  • GNUmakefile.list.am: Add missing files to the build.
  • bindings/gobject/GNUmakefile.am: Be smarter about filtering out deactivating indexed database.
  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute): Always skip attributes that return indexed database types.

5:19 PM Changeset in webkit [117367] by jchaffraix@webkit.org
  • 12 edits
    32 adds
    4 deletes in trunk/LayoutTests

Unreviewed gardening after r117339 (table baseline computation change).

  • fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.txt: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.png: Removed.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/inline-table-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-table-002a-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-table-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-table-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-table-002a-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-table-003-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/iframe-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-table-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-table-002a-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/inline-table-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/iframe-expected.png:
  • platform/chromium-mac/css2.1/20110323/inline-table-001-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/inline-table-001-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/inline-table-002a-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/inline-table-002a-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/inline-table-003-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/inline-table-003-expected.txt: Added.
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.txt: Added.
  • platform/chromium-mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added.
  • platform/chromium-win-vista/editing/selection: Removed.
  • platform/chromium-win-vista/fast/css-generated-content: Added.
  • platform/chromium-win-vista/fast/css-generated-content/inline-display-types-expected.png: Added.
  • platform/chromium-win-vista/fast/inline-block: Added.
  • platform/chromium-win-vista/fast/inline-block/001-expected.png: Added.
  • platform/chromium-win-xp/fast/css-generated-content: Added.
  • platform/chromium-win-xp/fast/css-generated-content/inline-display-types-expected.png: Added.
  • platform/chromium-win-xp/fast/inline-block: Added.
  • platform/chromium-win-xp/fast/inline-block/001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-table-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-table-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-table-002a-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-table-002a-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-table-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-table-003-expected.txt: Added.
  • platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-win/editing/selection/iframe-expected.png:
  • platform/chromium-win/editing/selection/inline-table-expected.png:
  • platform/chromium-win/editing/selection/table-caret-3-expected.png:
  • platform/chromium-win/fast/css-generated-content/inline-display-types-expected.png:
  • platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
  • platform/chromium-win/fast/inline-block/001-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
  • platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
5:09 PM Changeset in webkit [117366] by jonlee@apple.com
  • 3 edits
    6 adds in trunk

Animated GIFs in page cache get updated
https://bugs.webkit.org/show_bug.cgi?id=86668
<rdar://problem/11395549>

Reviewed by Brady Eidson.

Source/WebCore:

Test: fast/loader/image-in-page-cache.html

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged): When we are notified by the CachedImage that the image has
changed, we check to see if the document is in the page cache. If so, we should not be updating,
so we bail out early.

LayoutTests:

This test loads pages with subframes that display the same animated gif. When one of
the pages goes into the page cache, we want to make sure that we do not crash as a
side effect of the page's images getting updated.

  • fast/loader/image-in-page-cache-expected.txt: Added.
  • fast/loader/image-in-page-cache.html: Added.
  • fast/loader/resources/animated-image-subframe.html: Added.
  • fast/loader/resources/animated-image.html: Added.
  • fast/loader/resources/animated-image2.html: Added.
  • fast/loader/resources/animated-image3.html: Added.
5:07 PM Changeset in webkit [117365] by timothy_horton@apple.com
  • 4 edits
    2 adds in trunk

Crash if SVG gradient stop has display: none set
https://bugs.webkit.org/show_bug.cgi?id=86686
<rdar://problem/10751905>

Reviewed by Dean Jackson.

Source/WebCore:

Create a renderer for SVGStopElement regardless of the "display" property.
This matches the behavior of Opera and the SVG specification.

Test: svg/custom/gradient-stop-display-none-crash.svg

  • svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::rendererIsNeeded):
(WebCore):

  • svg/SVGStopElement.h:

(SVGStopElement):

LayoutTests:

Add a test that ensures that we don't crash if "display: none" is set on an SVGStopElement.

  • svg/custom/gradient-stop-display-none-crash-expected.txt: Added.
  • svg/custom/gradient-stop-display-none-crash.svg: Added.
5:00 PM Changeset in webkit [117364] by Lucas Forschler
  • 24 edits
    4 copies in branches/safari-536-branch

Merged r116595.

4:42 PM Changeset in webkit [117363] by Philippe Normand
  • 12 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r116069 and r117339.

  • platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/gtk/editing/selection/iframe-expected.txt:
  • platform/gtk/editing/selection/inline-table-expected.txt:
  • platform/gtk/editing/selection/table-caret-3-expected.txt:
  • platform/gtk/fast/css-generated-content/inline-display-types-expected.txt:
  • platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
  • platform/gtk/fast/forms/input-align-image-expected.txt:
  • platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/gtk/fast/inline-block/001-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
4:35 PM Changeset in webkit [117362] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Clear the m_private pointer when destroying WebFilterOperations to avoid assert in WebPrivateOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86654

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebFilterOperations.h:

(WebKit::WebFilterOperations::~WebFilterOperations):
(WebFilterOperations):

Source/WebCore:

  • platform/chromium/support/WebFilterOperations.cpp:

(WebKit::WebFilterOperations::reset):
(WebKit::WebFilterOperations::destroy):
(WebKit):

4:30 PM Changeset in webkit [117361] by rniwa@webkit.org
  • 2 edits
    2 adds in trunk

REGRESSION(r92823): WebKit strips font-weight: normal from b element when copying
https://bugs.webkit.org/show_bug.cgi?id=86663

Reviewed by Tony Chang.

The bug was caused by removeStyleFromRulesAndContext incorrectly stripping font-weight property
even when the context had no font-weight property because of a property name mismatch in getPropertiesNotIn.

Fixed the mismatch.

Test: editing/pasteboard/paste-text-with-style-5.html

  • editing/EditingStyle.cpp:

(WebCore::getPropertiesNotIn):

4:29 PM Changeset in webkit [117360] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark a test as failing.
https://bugs.webkit.org/show_bug.cgi?id=86683

Unreviewed, expectations update.

  • platform/chromium/test_expectations.txt:
4:24 PM Changeset in webkit [117359] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Merge nextRootInlineBox with nextLinePosition
https://bugs.webkit.org/show_bug.cgi?id=81593

Reviewed by Enrica Casucci.

Call previousRootInlineBox and nextRootInlineBox in previousLinePosition and nextLinePosition respectively
to share the code. Moved out the nullity check of startBox and extracted the renderer's node from the former
two, and added editableType to their argument lists to match the interface in both use cases.

Also moved out the code to extract root inline box using RenderedPosition from those two functions and
expanded in call sites since previousLinePosition and nextLinePosition need to return the candidate position
even when the root inline box doesn't exist. To this end, renamed previousRootInlineBox and nextRootInlineBox
to previousRootInlineBoxCandidatePosition and nextRootInlineBoxCandidatePosition respectively.

In addition, got rid of one version of nextLeafWithSameEditability that adjusted node with respect to offset
This variant did:

Node* child = node->childNode(offset);
node = child ? child->nextLeafNode() : node->lastDescendant()->nextLeafNode();

instead of:

node = node->nextLeafNode();

at the beginning of the function. Observe that the former code is logically equivalent to:

Node* child = node->childNode(offset);
node = child ? child : node->lastDescendant();
node = node->nextLeafNode();

Thus, the first two lines of this logically equivalent code is added in nextLinePosition wherein we used to
call the removed variant.

This refactoring with no behavioral change would help us resolving the bug 81490.

  • editing/visible_units.cpp:

(WebCore::previousRootInlineBoxCandidatePosition): Renamed from previousRootInlineBox.
(WebCore::nextRootInlineBoxCandidatePosition): Renamed from nextRootInlineBox.
(WebCore::logicallyPreviousBox): Checks the nullity of startBox's renderer and node. Also extracts the root
inline box out of the position per the interface change.
(WebCore::logicallyNextBox): Ditto.
(WebCore::previousLinePosition): Calls previousRootInlineBoxCandidatePosition.
(WebCore::nextLinePosition): Calls nextRootInlineBoxCandidatePosition.

4:06 PM Changeset in webkit [117358] by jchaffraix@webkit.org
  • 10 edits in branches/chromium/1132

Merge 117335 - layerX/layerY warning should be removed
https://bugs.webkit.org/show_bug.cgi?id=86264

Reviewed by James Robinson.

Source/WebCore:

Covered by: fast/dom/Window/window-xy-properties.html

fast/events/init-events.html
fast/events/mouse-relative-position.html
fast/events/mouseclick-target-and-positioning.html
fast/events/simulated-click-coords.html
jquery/event.html

This change just removes the warning pending proper investigation.

Longer explanation: The layerX/layerY warning was added prematurely
as we didn't assess the web-compatibility potential breakage vs the
maintenance cost. There is also not readily available replacement.

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::layerX):
(WebCore::MouseRelatedEvent::layerY):

  • dom/UIEvent.cpp:

(WebCore::UIEvent::layerX):
(WebCore::UIEvent::layerY):

  • dom/UIEvent.h:

Removed warnDeprecatedLayerXYUsage and all the associated calls.

LayoutTests:

Removed console message about layerX/layerY deprecation.

  • fast/dom/Window/window-xy-properties-expected.txt:
  • fast/events/init-events-expected.txt:
  • fast/events/mouse-relative-position-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/events/simulated-click-coords-expected.txt:
  • jquery/event-expected.txt:
  • platform/qt/fast/events/mouse-relative-position-expected.txt:

TBR=jchaffraix@webkit.org

3:56 PM Changeset in webkit [117357] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Unflag tests needing

rebaseline. I'll pull them from the bot ASAP.

3:47 PM Changeset in webkit [117356] by mihaip@chromium.org
  • 2 edits
    4 copies in branches/chromium/1084

Merge 115471 - Infinite backgroundClipRect should not be scrolled.
https://bugs.webkit.org/show_bug.cgi?id=84979

Reviewed by Adrienne Walker.

Source/WebCore:

Test: compositing/iframes/scroll-fixed-transformed-element.html

By accidentally scrolling clipRects that should be considered
"infinite", they were no longer being considered infinite. This
caused a chain of un-intended code paths that caused fixed
position elements to stutter when scrolling in Chromium.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundClipRect):

LayoutTests:

  • compositing/iframes/resources/fixed-position-transformed-subframe.html: Added.
  • compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
  • compositing/iframes/scroll-fixed-transformed-element-expected.txt: Added.
  • compositing/iframes/scroll-fixed-transformed-element.html: Added.

TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10392139

3:37 PM Changeset in webkit [117355] by noel.gordon@gmail.com
  • 5 edits
    1 delete in trunk/Source/WebCore

[chromium] Remove ImageDecoderCG.cpp from platform/image-decoders
https://bugs.webkit.org/show_bug.cgi?id=86346

Reviewed by Adam Barth.

ImageDecoderCG.cpp was added for use in the Chromium port in r70846. Remove the
implementation now that Chromium uses Skia on Mac OSX by default.

No new tests. No change in behavior.

  • WebCore.gypi: Remove ImageDecoderCG.cpp from the gyp project.
  • platform/graphics/ImageSource.h: Revert the r70846 changes.
  • platform/image-decoders/ImageDecoder.cpp: Remove copyReferenceToBitmapData().

(WebCore::ImageFrame::operator=): Return to using copyBitmapData() (as it was)
given the removal of copyReferenceToBitmapData() above.

  • platform/image-decoders/ImageDecoder.h:

(ImageFrame): Remove copyReferenceToBitmapData() declaration.

  • platform/image-decoders/cg/ImageDecoderCG.cpp: Removed, and it was the only

decoder with a port-specific implementation of copyReferenceToBitmapData().

3:27 PM Changeset in webkit [117354] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Simplify AudioNode ref-counting by removing RefTypeDisabled
https://bugs.webkit.org/show_bug.cgi?id=85681

Patch by Raymond Toy <Raymond Toy> on 2012-05-16
Reviewed by Chris Rogers.

Existing tests should cover these changes.

  • Modules/webaudio/AudioNode.cpp: Remove RefTypeDiabled and m_disabledRefCount.

(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::enableOutputsIfNecessary): New
(WebCore::AudioNode::ref):
(WebCore::AudioNode::disableOutputsIfNecessary): New
(WebCore::AudioNode::finishDeref):

  • Modules/webaudio/AudioNode.h: Remove RefTypeDisabled and m_disabledRefCount.
  • Modules/webaudio/AudioNodeInput.cpp: Removed uses of RefTypeDisbled.

(WebCore::AudioNodeInput::disconnect):
(WebCore::AudioNodeInput::disable):
(WebCore::AudioNodeInput::enable):

3:25 PM Changeset in webkit [117353] by ojan@chromium.org
  • 5 edits in trunk/Source/WebCore

Fix perf regression from r116487
https://bugs.webkit.org/show_bug.cgi?id=86680

Reviewed by Ryosuke Niwa.

http://trac.webkit.org/changeset/116487 caused a 6% regression on
Dromaeo's dom-attr test. The issue is that we invalidated NodeList
caches whenever an id/checked/type attribute changed.

First, we don't need to invalidate on checked/type since that only
affects the values return by NodeList items, not the list of items.
Second, we only need to invalidate NodeList caches when an id attribute
changes on a FormControlElement.

Incidentally, we also don't need to invalidate caches for changes
to attributes that don't have an ownerElement.

No new tests. This is strictly a performance improvement.

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Node.cpp:

(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):

  • dom/Node.h:

(Node):

3:16 PM Changeset in webkit [117352] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] The FCC shows up on an empty input field
https://bugs.webkit.org/show_bug.cgi?id=86657

Patch by Yongxin Dai <yodai@rim.com> on 2012-05-16
Reviewed by Antonio Gomes.

Turn off the caret by sending a caret changed notification with empty caret.
PR #120620

Reviewed Internally by Mike Fenton.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

3:10 PM Changeset in webkit [117351] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r117332.
http://trac.webkit.org/changeset/117332
https://bugs.webkit.org/show_bug.cgi?id=86679

It makes the Qt Linux bot very unhappy (Requested by darktears
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16

  • platform/qt/Skipped:
2:58 PM Changeset in webkit [117350] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r117196.

2:58 PM Changeset in webkit [117349] by arv@chromium.org
  • 2 edits in trunk/LayoutTests

Make window-property-shadowing-name.html fail faster
https://bugs.webkit.org/show_bug.cgi?id=86664

Reviewed by Ojan Vafai.

This makes test sync instead of async by checking the return value of window.open.

  • fast/dom/Window/window-property-shadowing-name.html:
2:55 PM Changeset in webkit [117348] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark test as flakily timing out.
https://bugs.webkit.org/show_bug.cgi?id=82698

Unreviewed, expectations update.

  • platform/chromium/test_expectations.txt:
2:55 PM Changeset in webkit [117347] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r117165.

2:53 PM Changeset in webkit [117346] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r117158.

2:51 PM Changeset in webkit [117345] by Lucas Forschler
  • 7 edits in branches/safari-536-branch/Source/WebCore

Merged r117147.

2:31 PM Changeset in webkit [117344] by eae@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Unreviewed chromium rebaseline for change in r117310.

  • platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.png:
  • platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.txt: Removed.
  • platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
2:21 PM Changeset in webkit [117343] by mhahnenberg@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839

Reviewed by Geoff Garen.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • jit/JITStubs.cpp: Making changes to use the new return value of growPropertyStorage.

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSObject.cpp:

(JSC::JSObject::growPropertyStorage): Renamed to more accurately reflect that we're
growing our already-existing PropertyStorage.

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::setPropertyStorage): "Atomically" sets the new property storage
and the new structure so that we can be sure a GC never occurs when our Structure
info is out of sync with our PropertyStorage.
(JSC):
(JSC::JSObject::putDirectInternal): Moved the check to see if we should
allocate more backing store before the actual property insertion into
the structure.
(JSC::JSObject::putDirectWithoutTransition): Ditto.
(JSC::JSObject::transitionTo): Ditto.

  • runtime/Structure.cpp:

(JSC::Structure::suggestedNewPropertyStorageSize): Added to keep the resize policy
for property backing stores contained within the Structure class.
(JSC):

  • runtime/Structure.h:

(JSC::Structure::shouldGrowPropertyStorage): Lets clients know if another insertion
into the Structure would require resizing the property backing store so that they can
preallocate the required storage.
(Structure):

2:18 PM Changeset in webkit [117342] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Fix bad expectation added in r117249.
https://bugs.webkit.org/show_bug.cgi?id=82698

Unreviewed, test expectation fix.

  • editing/shadow/selection-of-orphan-shadowroot-expected.txt:
2:14 PM Changeset in webkit [117341] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB: WebKit API for IDBObjectStore.autoIncrement property
https://bugs.webkit.org/show_bug.cgi?id=86661

Reviewed by Dimitri Glazkov.

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::autoIncrement):

2:06 PM Changeset in webkit [117340] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

GC is not thread-safe when moving values between C stacks
https://bugs.webkit.org/show_bug.cgi?id=86672

Reviewed by Phil Pizlo.

GC pauses thread A while marking thread A, and then B while marking B,
which isn't safe against A and B moving values between each others'
stacks.

This is a theoretical bug -- I haven't been able to reproduce it
in the wild.

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots): Pause all C stacks for the
duration of stack marking, to avoid missing values that might be moving
between C stacks.

2:06 PM Changeset in webkit [117339] by robert@webkit.org
  • 30 edits
    11 adds in trunk

CSS 2.1 failure: inline-table-001 fails
https://bugs.webkit.org/show_bug.cgi?id=84167

Reviewed by Julien Chaffraix.

Source/WebCore:

Override lastLineBoxBaseline() in RenderTable so that it picks up the baseline
of the text in the first row of the table. This allows inline tables to find the
correct baseline to align to.

Tests:

css2.1/20110323/inline-table-001.htm
css2.1/20110323/inline-table-002a.htm
css2.1/20110323/inline-table-003.htm
fast/css/empty-cell-baseline.html

  • rendering/RenderTable.cpp:

(WebCore::getLineBoxBaseline):
(WebCore):
(WebCore::RenderTable::lastLineBoxBaseline):
(WebCore::RenderTable::firstLineBoxBaseline):

  • rendering/RenderTable.h:

(RenderTable):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstLineBoxBaseline): if a cell is empty it cannot provide a

baseline. Tested by fast/css/empty-cell-baseline.html

LayoutTests:

  • css2.1/20110323/inline-table-001.htm: Added.
  • css2.1/20110323/inline-table-002a.htm: Added.
  • css2.1/20110323/inline-table-003.htm: Added. From the CSS 2.1 test suite.
  • fast/css/empty-cell-baseline-expected.html: Added.
  • fast/css/empty-cell-baseline.html: Added. This ensures we don't take a baseline from an empty cell.
  • fast/inline-block/001.html: Modified to make expected results clearer.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.txt: Added.
  • platform/chromium-linux/editing/pasteboard/innerText-inline-table-expected.png:

Progression, the baseline of the text in each cell has moved up to where it should be.

  • platform/chromium-linux/editing/selection/iframe-expected.png:

Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.

  • platform/chromium-linux/editing/selection/inline-table-expected.png:

Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.

  • platform/chromium-linux/editing/selection/table-caret-3-expected.png:

Progression, 'foo' and 'baz' line up with the first row of the inline table.

  • platform/chromium-linux/fast/css-generated-content/inline-display-types-expected.png:

Progression, 'Test' and 'content' now line up.

  • platform/chromium-linux/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:

Progression, the two boxes now line up.

  • platform/chromium-linux/fast/inline-block/001-expected.png:

Progression, the boxes now line up in the same way as FF and Opera.

  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:

Progression, the baseline of the text in each cell has moved up to where it should be.

  • platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/chromium-win/editing/selection/iframe-expected.txt:
  • platform/chromium-win/editing/selection/inline-table-expected.txt:
  • platform/chromium-win/editing/selection/table-caret-3-expected.txt:
  • platform/chromium-win/fast/css-generated-content/inline-display-types-expected.txt:
  • platform/chromium-win/fast/inline-block/001-expected.txt:
  • platform/chromium-win/fast/repaint/float-overflow-expected.txt:
  • platform/chromium-win/fast/repaint/float-overflow-right-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/Skipped:

Text rebaselines.

2:02 PM Changeset in webkit [117338] by jsbell@chromium.org
  • 8 edits in trunk/Source/WebCore

IndexedDB: Rename valid/finished methods to isValid/isFinished to match coding standard
https://bugs.webkit.org/show_bug.cgi?id=86655

Reviewed by Tony Chang.

No new tests - no functional changes.

  • Modules/indexeddb/IDBKey.h:

(WebCore::IDBKey::isValid): valid() => isValid()

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::transactionFinished):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::isFinished): finished() => isFinished()

  • Modules/indexeddb/IDBTransaction.h:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

1:57 PM Changeset in webkit [117337] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[WK2] Support layoutTestController.dumpProgressFinishedCallback() in WKTR
https://bugs.webkit.org/show_bug.cgi?id=81613

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-16
Reviewed by Brady Eidson.

Unskip the related test from mac-kw2 and gtk-wk2 as support has been added.

  • platform/gtk-wk2/Skipped:
  • platform/mac-wk2/Skipped:
1:56 PM Changeset in webkit [117336] by jpfau@apple.com
  • 2 edits in trunk/Source/WebCore

ImageLoader can still dispatch beforeload events for ImageDocuments
https://bugs.webkit.org/show_bug.cgi?id=86658
<rdar://problem/11465863>

Reviewed by Brady Eidson.

Prevent flags regarding sending beforeload events from being set on ImageDocuments.

No new tests; testing framework doesn't allow for testing ImageDocuments with injected JavaScript.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

1:50 PM Changeset in webkit [117335] by jchaffraix@webkit.org
  • 12 edits in trunk

layerX/layerY warning should be removed
https://bugs.webkit.org/show_bug.cgi?id=86264

Reviewed by James Robinson.

Source/WebCore:

Covered by: fast/dom/Window/window-xy-properties.html

fast/events/init-events.html
fast/events/mouse-relative-position.html
fast/events/mouseclick-target-and-positioning.html
fast/events/simulated-click-coords.html
jquery/event.html

This change just removes the warning pending proper investigation.

Longer explanation: The layerX/layerY warning was added prematurely
as we didn't assess the web-compatibility potential breakage vs the
maintenance cost. There is also not readily available replacement.

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::layerX):
(WebCore::MouseRelatedEvent::layerY):

  • dom/UIEvent.cpp:

(WebCore::UIEvent::layerX):
(WebCore::UIEvent::layerY):

  • dom/UIEvent.h:

Removed warnDeprecatedLayerXYUsage and all the associated calls.

LayoutTests:

Removed console message about layerX/layerY deprecation.

  • fast/dom/Window/window-xy-properties-expected.txt:
  • fast/events/init-events-expected.txt:
  • fast/events/mouse-relative-position-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/events/simulated-click-coords-expected.txt:
  • jquery/event-expected.txt:
  • platform/qt/fast/events/mouse-relative-position-expected.txt:
1:41 PM Changeset in webkit [117334] by jsbell@chromium.org
  • 5 edits in trunk/Source/WebCore

IndexedDB: Use accessors for backing store / database id in store/index backends
https://bugs.webkit.org/show_bug.cgi?id=86652

Reviewed by Tony Chang.

Hide the private members m_backingStore and m_databaseId of IDBObjectStoreBackendImpl
and IDBIndexBackendImpl behind accessors. This is preparation for removing these
members and only holding references to the IDBDatabaseBackendImpl: webkit.org/b/83074

No new tests - no functional changes.

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getByRangeInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::getKeyByRangeInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::backingStore): Added.
(WebCore::IDBIndexBackendImpl::databaseId): Added.
(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::getByRangeInternal):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::backingStore): Added.
(WebCore::IDBObjectStoreBackendImpl::databaseId): Added.
(IDBObjectStoreBackendImpl):

1:36 PM Changeset in webkit [117333] by pkasting@chromium.org
  • 3 edits
    3 adds in trunk

Malformed GIF can cause decoder to read off end of heap buffer
https://bugs.webkit.org/show_bug.cgi?id=86531

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/images/read-past-end-of-buffer.html
This test is only expected to catch problems if run under Address
Sanitizer or a similar memory-checking utility.

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::read):

LayoutTests:

The test here is only expected to catch problems if run under Address
Sanitizer or a similar memory-checking utility.

  • fast/images/read-past-end-of-buffer-expected.txt: Added.
  • fast/images/read-past-end-of-buffer.html: Added.
  • fast/images/resources/wrong-block-length.gif: Added.
1:31 PM Changeset in webkit [117332] by alexis.menard@openbossa.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION?(62951): media tests fail
https://bugs.webkit.org/show_bug.cgi?id=42094

Reviewed by Noam Rosenthal.

Enable some media layout tests so that our coverage is more than inexistant.

  • platform/qt/Skipped:
1:25 PM Changeset in webkit [117331] by Lucas Forschler
  • 15 edits in branches/safari-536-branch/Source

Merged r117129.

1:20 PM Changeset in webkit [117330] by efidler@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Don't reset the default font families in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=86660

Reviewed by Rob Buis.

PR 152467
The default families are also set definitively in WebCore/page/blackberry/SettingsBlackBerry.cpp

  • Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::standardSettings):

1:15 PM Changeset in webkit [117329] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

[chromium] Add WebKit API to access inner text value of input element
https://bugs.webkit.org/show_bug.cgi?id=85353

Patch by Keishi Hattori <keishi@webkit.org> on 2012-05-16
Reviewed by Kent Tamura.

  • Source/autotools/symbols.filter: Added HTMLInputElement::setEditingValue
1:07 PM Changeset in webkit [117328] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, rebaselining after r117310.

  • platform/gtk/fast/block/float/overhanging-tall-block-expected.txt:
1:04 PM Changeset in webkit [117327] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk

[chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on chromium linux
https://bugs.webkit.org/show_bug.cgi?id=86236

Patch by Varun Jain <varunjain@google.com> on 2012-05-16
Reviewed by Tony Chang.

.:

  • ManualTests/chromium/modifiers-during-drag-and-drop.html: Added.

Source/WebCore:

ManualTests: ManualTests/chromium/modifiers-during-drag-and-drop.html

  • page/DragController.cpp:

(WebCore::createMouseEvent):

  • platform/DragData.cpp:

(WebCore):
(WebCore::DragData::modifierKeyState):

  • platform/DragData.h:

(DragData):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::ChromiumDataObject):

  • platform/chromium/ChromiumDataObject.h:

(WebCore::ChromiumDataObject::modifierKeyState):
(WebCore::ChromiumDataObject::setModifierKeyState):
(ChromiumDataObject):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::modifierKeyState):
(WebCore):

Source/WebKit/chromium:

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::webInputEventKeyStateToPlatformEventKeyState):
(WebKit):
(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragOver):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):

  • src/WebViewImpl.h:

(WebViewImpl):

12:55 PM Changeset in webkit [117326] by jer.noble@apple.com
  • 7 edits in trunk

<video> elements with no video tracks report false for webkitSupportsFullscreen.
https://bugs.webkit.org/show_bug.cgi?id=86650

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; updated media/media-fullscreen-inline.html.

With the new Full Screen API, the restriction that only video elements with
video tracks can enter full screen seems arbitrary. Some media types will
occasionally determine they have video tracks long after loadedmetadata, which
breaks websites who check for webkitSupportsFullscreen(). Relax the restriction
on webkitSupportsFullscreen() for ports where the Full Screen API is enabled and
supported so as to no longer require hasVideo().

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::supportsFullscreen):

LayoutTests:

Fix media-fullscreen.js to support the new FULLSCREEN_API events, if present.
Fix the media-fullscreen-inline.html test and unskip on Lion.

  • media/media-fullscreen-inline-expected.txt:
  • media/media-fullscreen-inline.html:
  • media/media-fullscreen.js:

(fullscreenchange):
(loadedmetadata):
(addEventListeners):

  • platform/mac-lion/Skipped:
12:48 PM WebKitGTK/WebKit2Roadmap edited by zandobersek@gmail.com
(diff)
12:48 PM Changeset in webkit [117325] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
https://bugs.webkit.org/show_bug.cgi?id=63132

Removed test from skipped list, since it now passes on mac.

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-05-16
Reviewed by Alexis Menard.

  • platform/qt-mac/Skipped:
12:40 PM Changeset in webkit [117324] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build change after exported symbol
updates (r114790) and expansion of CG routines in WebPage
PDF output (r114476).

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRectToPDF): Exclude CG use on WinCairo.
(WebKit::WebPage::drawPagesToPDF): Exclude CG use on WinCairo.

  • win/WebKit2CFLite.def: Don't claim to export symbols we don't

provide (e.g., full screen API calls).

12:31 PM Changeset in webkit [117323] by kling@webkit.org
  • 16 edits in trunk/Source/WebCore

Avoid reparsing the style attribute when cloning elements.
<http://webkit.org/b/86574>

Reviewed by Antti Koivisto.

Refactor cloning of attributes a bit to dodge the styleAttr reparse previously
caused by ElementAttributeData::setAttributes().

Introduced Element::cloneDataFromElement() which takes care of cloning the
ElementAttributeData as well as "non-attribute properties" (which is currently
specific to HTMLInputElement.)

Also includes some additional dodging of attribute vector traversal to find
old/new 'id' and 'name' attributes.

I'm seeing a ~10% improvement on PerformanceTests/DOM/CloneNodes locally.

  • dom/Document.cpp:

(WebCore::Document::importNode):

  • dom/Element.cpp:

(WebCore::Element::cloneElementWithoutChildren):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::cloneDataFromElement):

  • dom/Element.h:

(WebCore::Element::copyNonAttributePropertiesFromElement):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::cloneDataFrom):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/Node.h:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::parseAttribute):

  • dom/StyledElement.h:
  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

  • html/HTMLElement.cpp:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement):

  • html/HTMLInputElement.h:
  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::innerPatchNode):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setNodeName):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
(WebCore::SVGUseElement::transferUseAttributesToReplacedElement):

12:25 PM Changeset in webkit [117322] by bfulgham@webkit.org
  • 4 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build change after r115385. Several Cairo
image routines were modified to use new wrapper classes, but the
relevant WinCairo sources were not updated to match.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::create):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

  • platform/win/DragImageCairoWin.cpp:

(WebCore::createDragImageFromImage):

12:22 PM Changeset in webkit [117321] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r117124.

12:20 PM Changeset in webkit [117320] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r117113.

12:18 PM Changeset in webkit [117319] by Lucas Forschler
  • 5 edits in branches/safari-536-branch/Source

Merged r117108.

12:16 PM Changeset in webkit [117318] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source/WebCore

Merged r117032.

12:13 PM Changeset in webkit [117317] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebCore

Merged r117021.

12:11 PM Changeset in webkit [117316] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r116971.

12:10 PM Changeset in webkit [117315] by Lucas Forschler
  • 15 edits
    1 copy
    1 delete in branches/safari-536-branch/Source/WebKit2

Merged r116796.

11:48 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
11:45 AM Changeset in webkit [117314] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Scrollbar layers should respect accelerated drawing setting
https://bugs.webkit.org/show_bug.cgi?id=86644
<rdar://problem/11462038>

Reviewed by Simon Fraser.

When creating scrollbar layers, pass through the accelerated drawing setting.

No new tests.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

11:41 AM Changeset in webkit [117313] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

FrameView::scrollContentsFastPath should use painted area to determine whether to drop out of the fast path
https://bugs.webkit.org/show_bug.cgi?id=86651
<rdar://problem/11459243>

Reviewed by Simon Fraser.

Previously, we decided to fall out of the fast scrolling path by the number of fixed-position elements
on the page. This was less than ideal if a single fixed position element took up a significant portion
of the page, or if there were many small, cheap-to-paint fixed elements.

Instead, we should use the fast path if less than 50% of the page will be repainted by fixed-position
elements, and otherwise fall back to the slow path.

I've tested a few different thresholds with an internal test; 50% seems to work relatively well,
but the ideal value is hard to determine and likely depends on hardware.

No new tests, performance improvement with few large fixed-position objects or many small ones.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

11:31 AM Changeset in webkit [117312] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Use ThrottledTextureUploader with threaded compositing.
https://bugs.webkit.org/show_bug.cgi?id=85848

Patch by David Reveman <reveman@chromium.org> on 2012-05-16
Reviewed by Adrienne Walker.

Switch to ThrottledUploader in CCThreadProxy.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:
11:31 AM Changeset in webkit [117311] by Simon Fraser
  • 3 edits in trunk/Source/WTF

Make things build with DUMP_HASHTABLE_STATS=1
https://bugs.webkit.org/show_bug.cgi?id=86571

Reviewed by Geoffrey Garen.

DUMP_HASHTABLE_STATS bitrotted after the WTF separation. This patch
makes it build.

Added WTF_EXPORTDATA to the global data, and WTF_EXPORT_PRIVATE to
the static HashTableStats methods. Added a dumpStats() method
that is not yet called anywhere; we can no longer rely on destroying
a global object to dump the stats because global destructors are
disallowed.

  • wtf/HashTable.cpp:

(WTF):
(WTF::HashTableStats::recordCollisionAtCount):
(WTF::HashTableStats::dumpStats):

  • wtf/HashTable.h:

(HashTableStats):

11:30 AM Changeset in webkit [117310] by eae@chromium.org
  • 7 edits in trunk

Change ascents and descent back to ints for now
https://bugs.webkit.org/show_bug.cgi?id=86518

Reviewed by Eric Seidel.

Change ascents and descent calculation back to integers for now as it
looks like we'll need to support both the 1/60 and 1/1 implementations of
FractionalLayoutUnit for the immediate future to ensure that text is
rendered at the same offset and with the height regardless of the
ENABLE_SUBPIXEL_LAYOUT flag.

This ensures that most websites will look the same at 100% zoom
regardless of the flag and also allows us to the same test expectations
for the vast majority of layout tests.

Eventually we want to move those back to FractionalLayoutUnits as that
will result in more correct rendering.

Source/WebCore:

No new tests, no change in functionality.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

  • rendering/RootInlineBox.cpp:

(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/RootInlineBox.h:

(RootInlineBox):

LayoutTests:

  • platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
11:18 AM Changeset in webkit [117309] by kenrb@chromium.org
  • 3 edits
    2 adds in trunk

Crash due to first-letter not getting computed on RenderTableCell
https://bugs.webkit.org/show_bug.cgi?id=86133

Reviewed by Abhishek Arya.

Source/WebCore:

RenderTableCell overrides RenderBlock::layout() but doesn't call
updateFirstLetter() in it. This is normally not a problem because
updateFirstLetter() gets called during preferred logical width
computation, but there exist rare occasions when layout of the table
cell happens without preferred logical widths being dirty, in which
case the first-letter update can be skipped.

This patch adds a call to updateFirstLetter() to
RenderTableCell::layout(). This ensures that the first-letter is up
to date before commencing block layout.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::layout)

LayoutTests:

Test to exercise crashing condition in bug 86133.

  • fast/css-generated-content/first-letter-table-cell-format-block-crash-expected.txt: Added
  • fast/css-generated-content/first-letter-table-cell-format-block-crash.html: Added
10:53 AM Changeset in webkit [117308] by senorblanco@chromium.org
  • 12 edits in trunk/LayoutTests

New baselines required after r117187.
https://bugs.webkit.org/show_bug.cgi?id=86486

Unreviewed gardening.

  • platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-linux/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-leopard/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-image-expected.png:
  • platform/chromium/test_expectations.txt:
10:45 AM Changeset in webkit [117307] by mnaganov@chromium.org
  • 5 edits
    6 adds in trunk

Avoid jumpscroll when entering new text in a multi-line editor.
https://bugs.webkit.org/show_bug.cgi?id=82875

Reviewed by Ryosuke Niwa

Scroll caret to the edge of the viewport in case if a line break or a paragraph
separator is inserted at the end of a multi-line editor. This avoids
undesirable jumpscroll in cases when there is content under the editor.

Tests: editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html

editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html
editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html

  • editing/Editor.cpp:

(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::revealSelectionAfterEditingOperation):

  • editing/Editor.h:

(Editor):

  • editing/input/resources/reveal-utilities.js:

(performJumpAtTheEdgeTest):

  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added.
  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html: Added.
  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea-expected.txt: Added.
  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html: Added.
  • editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable-expected.txt: Added.
  • editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html: Added.
10:36 AM Changeset in webkit [117306] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Pressing esc after requesting snippet creation should remove snippet.
https://bugs.webkit.org/show_bug.cgi?id=86639

Reviewed by Pavel Feldman.

Added committed parameter to NavigatorView.rename() callback.

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype.rename.commitHandler):
(WebInspector.NavigatorView.prototype.rename.cancelHandler):
(WebInspector.NavigatorView.prototype.rename.afterEditing):

  • inspector/front-end/ScriptsNavigator.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested):

10:29 AM Changeset in webkit [117305] by Carlos Garcia Campos
  • 10 edits
    2 copies
    4 adds in trunk/Source/WebKit2

[GTK] Add API to get plugins to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=86356

Reviewed by Martin Robinson.

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitMimeInfo.cpp: Added.

(_WebKitMimeInfo): Boxed type to represent MIME type information.
(webkitMimeInfoCreate): Ceate a new WebKitMimeInfo.
(webkit_mime_info_ref):
(webkit_mime_info_unref):
(webkit_mime_info_get_mime_type): Return the mime type.
(webkit_mime_info_get_description): Return the mime type
description.
(webkit_mime_info_get_extensions): Return the list of extensions
associated to the mime type.

  • UIProcess/API/gtk/WebKitMimeInfo.h: Added.
  • UIProcess/API/gtk/WebKitMimeInfoPrivate.h: Added.
  • UIProcess/API/gtk/WebKitPlugin.cpp: Added.

(webkitPluginFinalize):
(webkit_plugin_init):
(webkit_plugin_class_init):
(webkitPluginCreate): Create a new WebKitPlugin for the given
PluginModuleInfo.
(webkit_plugin_get_name): Return the plugin name.
(webkit_plugin_get_description): Return the plugin description.
(webkit_plugin_get_path): Return the path where the plugin is
installed.
(webkit_plugin_get_mime_info_list): Return the list of mime types
handled by the plugin.

  • UIProcess/API/gtk/WebKitPlugin.h: Added.
  • UIProcess/API/gtk/WebKitPluginPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_additional_plugins_directory): Set an
additional directory to be scanned for plugins.
(GetPluginsAsyncData): Helper struct used to asynchronously get
the list of plugins.
(getPluginsAsyncDataCreate): Create a GetPluginsAsyncData struct.
(getPluginsAsyncDataDestroy): Destroy a GetPluginsAsyncData
struct.
(webkitWebContextGetPluginThread): Thread body to get the list of
plugins installed.
(webkit_web_context_get_plugins): Asynchronously get the list of
plugins installed.
(webkit_web_context_get_plugins_finish): Finish async operation
started by webkit_web_context_get_plugins() returning a list of
WebKitPlugin.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for

WebKitPlugin.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add new types.
  • UIProcess/API/gtk/tests/GNUmakefile.am:
  • UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(testWebContextGetPlugins):
(beforeAll):

  • UIProcess/API/gtk/webkit2.h:
10:22 AM Changeset in webkit [117304] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Missing RenderApplet cast check in HTMLAppletElement::renderWidgetForJSBindings.
https://bugs.webkit.org/show_bug.cgi?id=86627

Reviewed by Andreas Kling.

Source/WebCore:

Test: java/inline-applet-crash.html

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::renderWidgetForJSBindings):

LayoutTests:

  • java/inline-applet-crash-expected.txt: Added.
  • java/inline-applet-crash.html: Added.
9:56 AM Changeset in webkit [117303] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=86643
http/tests/security/contentSecurityPolicy/script-src-redirect.html fails on Mac bots

  • platform/mac/Skipped: Add to skipped list while Oliver and Michael are exploring it.
9:38 AM Changeset in webkit [117302] by pfeldman@chromium.org
  • 10 edits in trunk

Web Inspector: extract CompositeUISourceCodeProvider from DebuggerScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=86634

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Extract refactoring.

  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype.uiSourceCodeProviders):
(WebInspector.DebuggerScriptMapping.prototype._parsedScriptSource):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._loadUISourceCodes):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.CompositeUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._registerUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeAdded):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeReplaced):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeRemoved):
(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodes):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.UISourceCodeProvider.prototype.addEventListener):
(WebInspector.UISourceCodeProvider.prototype.removeEventListener):

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/linkifier.html:
  • inspector/debugger/scripts-panel.html:
9:30 AM Changeset in webkit [117301] by beidson@apple.com
  • 4 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=86638
Bump the version number on the WKBundlePageLoaderClient

Reviewed by Dan Bernstein.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: s/1/2/
  • Shared/APIClientTraits.cpp: Update client traits for the BundlePageLoaderClient
  • Shared/APIClientTraits.h: Update client traits for the BundlePageLoaderClient
  • ChangeLog: Change a confusing ChangeLog entry to reflect the actual client that was changed.
9:22 AM Changeset in webkit [117300] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Double Clicking on "No watch expressions" should add an expression
https://bugs.webkit.org/show_bug.cgi?id=86631

Reviewed by Vsevolod Vlasov.

A double-click listener for the section element adds a new watch expression if the correct element
has been clicked.
Drive-by: do not persist deleted (null) watch expressions.

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype._sectionDoubleClick):
(WebInspector.WatchExpressionsSection.prototype.updateExpression):

9:11 AM Changeset in webkit [117299] by vsevik@chromium.org
  • 8 edits in trunk

Web Inspector: Support script snippets saving.
https://bugs.webkit.org/show_bug.cgi?id=86632

Reviewed by Pavel Feldman.

Source/WebCore:

Added SnippetJavaScriptSource extending JavaScriptSource and overriding isEditable() and commitWorkingCopy() methods.
ScriptSnippetModel now creates instances of this new class for snippets.
Also maps in ScriptSnippetModel simplified.

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.commitWorkingCopy):
(WebInspector):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.deleteScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.renameScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.setScriptSnippetContent):
(WebInspector.ScriptSnippetModel.prototype._uiSourceCodeList):
(WebInspector.ScriptSnippetModel.prototype._releasedUISourceCodes):
(WebInspector.SnippetJavaScriptSource):
(WebInspector.SnippetJavaScriptSource.prototype.isEditable):
(WebInspector.SnippetJavaScriptSource.prototype.commitWorkingCopy):
(WebInspector.SnippetJavaScriptSource.prototype.get snippetId):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested):

LayoutTests:

  • inspector/debugger/script-snippet-model.html:
9:09 AM Changeset in webkit [117298] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Rounding errors on 32-bit machines causes tests to fail
https://bugs.webkit.org/show_bug.cgi?id=86194

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16
Reviewed by Martin Robinson.

Pass additional CXXFLAGS to CMake in an attempt to harmonize floating
point values between 32-bit and 64-bit architectures.
Same flags are already used by Qt and GTK ports.

  • Scripts/webkitdirs.pm:

(determineArchitecture):
(generateBuildSystemFromCMakeProject):

9:00 AM Changeset in webkit [117297] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Memory leak in RenderThemeEfl
https://bugs.webkit.org/show_bug.cgi?id=86609

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-16
Reviewed by Martin Robinson.

Fix a memory leak by freeing the cairo surface with
cairo_surface_destroy.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::cacheThemePartFlush):

8:49 AM Changeset in webkit [117296] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Speedup heap snapshot postprocessing
https://bugs.webkit.org/show_bug.cgi?id=86635

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-16
Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

8:48 AM Changeset in webkit [117295] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, followup for r117273 that fixes the Web Inspector's Computed Style pane layout.

  • inspector/front-end/elementsPanel.css:

(.styles-section.computed-style.expanded .properties > li):
(.styles-section.computed-style.expanded .properties > li .webkit-css-property):

8:42 AM Changeset in webkit [117294] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] New failing and flakey tests with newer Qt 5
https://bugs.webkit.org/show_bug.cgi?id=86452

Unreviewed gardening, skip new failing/flakey tests to paint
the bots green. (To be able to catch new and new regressions.)

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
8:41 AM Changeset in webkit [117293] by caseq@chromium.org
  • 11 edits
    2 adds in trunk

Web Inspector: [Extensions API] expose evaluateOptions in audit formatters
https://bugs.webkit.org/show_bug.cgi?id=86617

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/extensions/extensions-audits-content-script.html

  • apply extension-specific audit formatters earlier (in ExtensionAduitCategory, not along with the rest in AuditFormatters);
  • use ExtensionServer.evaluate() to handle evaluateOptions instead of PageAgent.evaluate();
  • inspector/front-end/AuditFormatters.js: Move node and object formatters to ExtensionAuditCategory.

(WebInspector.partiallyApplyFormatters): Added a method to traverse formatters tree and apply formatters that are passed as input.

  • inspector/front-end/ExtensionAuditCategory.js:

(WebInspector.ExtensionAuditCategory): Pass extensionOrigin.
(WebInspector.ExtensionAuditCategoryResults.prototype._addNode): Apply extensions formatters before adding the result.
(WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
(WebInspector.ExtensionAuditCategoryResults.prototype.evaluate): moved from AuditFormatters.
(WebInspector.ExtensionAuditFormatters.object.onEvaluate):
(WebInspector.ExtensionAuditFormatters.object):
(WebInspector.ExtensionAuditFormatters.node.onNodeAvailable):
(WebInspector.ExtensionAuditFormatters.node.onEvaluate):
(WebInspector.ExtensionAuditFormatters.node):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onAddAuditCategory): Plumb extensionOrigin through to audit category.

LayoutTests:

  • inspector/extensions/extensions-audits-content-script-expected.txt: Added.
  • inspector/extensions/extensions-audits-content-script.html: Added.
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
8:27 AM Changeset in webkit [117292] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Add missing include that was causing build errors.
https://bugs.webkit.org/show_bug.cgi?id=86502

Patch by Genevieve Mak <gmak@rim.com> on 2012-05-16
Reviewed by Rob Buis.
Reviewed Internally by Liam Quinn.

  • WebKitSupport/InputHandler.cpp:
7:56 AM Changeset in webkit [117291] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebCore

Fixes the build with Qt 5 HEAD

Patch by Donald Carr <donald.carr@nokia.com> on 2012-05-16
Reviewed by Csaba Osztrogonác.

  • WebCore.pri:
  • platform/graphics/texmap/TextureMapperGL.cpp:
  • plugins/qt/PluginViewQt.cpp:
7:52 AM Changeset in webkit [117290] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh is broken
https://bugs.webkit.org/show_bug.cgi?id=86629

Reviewed by Pavel Feldman.

Listen to DebuggerModel instead of DebuggerPresentationModel which is gone.

  • src/js/Tests.js:

(.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed):

7:47 AM Changeset in webkit [117289] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

SVGSVGElement checkIntersection and checkEnclosure Mem corruption
https://bugs.webkit.org/show_bug.cgi?id=67923

Patch by Rob Buis <rbuis@rim.com> on 2012-05-16
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Only call checkIntersection/checkEnclosure when we have a valid renderer.

Test: svg/custom/intersection-list-null.svg

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::checkIntersection):
(WebCore::SVGSVGElement::checkEnclosure):

LayoutTests:

Add test to check that checkIntersection/checkEnclosure do not
crash when null is used for the element parameter.

  • svg/custom/intersection-list-null-expected.txt: Added.
  • svg/custom/intersection-list-null.svg: Added.
7:23 AM Changeset in webkit [117288] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620

Reviewed by Csaba Osztrogonác.

Temporary workaround not to fail layout tests.

  • Tools.pro: Disable TestNetscapePlugin.
7:22 AM Changeset in webkit [117287] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: debugger browser tests are broken
https://bugs.webkit.org/show_bug.cgi?id=86624

Reviewed by Vsevolod Vlasov.

Use WebInspector.panels.scripts._scriptMapping instead of
WebInspector.panels.scripts._presentationModel as the latter
has been deleted.

  • src/js/Tests.js:

(.TestSuite.prototype.nonAnonymousUISourceCodes_):

7:21 AM WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
7:21 AM Changeset in webkit [117286] by Simon Hausmann
  • 4 edits in trunk

Source/WebCore: Unreviewed, rolling out r110699.
http://trac.webkit.org/changeset/110699
https://bugs.webkit.org/show_bug.cgi?id=80982

Not needed anymore and broke modal event loops

  • platform/qt/RunLoopQt.cpp:

(WebCore::RunLoop::TimerObject::TimerObject):
(WebCore::RunLoop::TimerObject::performWork):
(RunLoop::TimerObject):

LayoutTests: Unskip fast/animation/request-animation-frame-during-modal.html that was
skipped due to r110699.

  • platform/qt-5.0-wk2/Skipped:
7:19 AM WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
7:08 AM Changeset in webkit [117285] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix uninitialized struct member added by r117258
https://bugs.webkit.org/show_bug.cgi?id=86611

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-16
Reviewed by Gustavo Noronha Silva.

When adding a new member to _Ewk_View_Smart_Class,
EWK_VIEW_SMART_CLASS_VERSION needs to be updated.

  • ewk/ewk_view.h:
6:58 AM Changeset in webkit [117284] by Csaba Osztrogonác
  • 7 edits
    146 adds in trunk/LayoutTests

Unreviewed gardening: updating expectations after r117259
https://bugs.webkit.org/show_bug.cgi?id=86463

  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/custom/altglyph-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/altglyph-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/text/kerning-expected.png: Added.
  • platform/qt-5.0-wk2/svg/text/kerning-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.png: Added.
  • platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
  • platform/qt-5.0/svg/batik/text/smallFonts-expected.png: Added.
  • platform/qt-5.0/svg/batik/text/smallFonts-expected.txt: Added.
  • platform/qt-5.0/svg/batik/text/textAnchor-expected.png: Added.
  • platform/qt-5.0/svg/batik/text/textAnchor-expected.txt: Added.
  • platform/qt-5.0/svg/batik/text/textEffect-expected.png: Added.
  • platform/qt-5.0/svg/batik/text/textEffect-expected.txt: Added.
  • platform/qt-5.0/svg/batik/text/textEffect3-expected.png: Added.
  • platform/qt-5.0/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/qt-5.0/svg/batik/text/textPosition2-expected.png: Added.
  • platform/qt-5.0/svg/batik/text/textPosition2-expected.txt:
  • platform/qt-5.0/svg/carto.net/window-expected.png: Added.
  • platform/qt-5.0/svg/carto.net/window-expected.txt: Added.
  • platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
  • platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt:
  • platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
  • platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt:
  • platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.png: Added.
  • platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.txt:
  • platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
  • platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.txt: Added.
  • platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.png: Added.
  • platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.txt: Added.
  • platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/qt-5.0/svg/custom/svg-features-expected.txt: Added.
  • platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.png: Added.
  • platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.txt: Added.
  • platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.png: Added.
  • platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.txt: Added.
  • platform/qt-5.0/svg/custom/text-linking-expected.png: Added.
  • platform/qt-5.0/svg/custom/text-linking-expected.txt: Added.
  • platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.txt: Added.
  • platform/qt-5.0/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Added.
  • platform/qt-5.0/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Added.
  • platform/qt-5.0/svg/text/text-align-01-b-expected.png: Added.
  • platform/qt-5.0/svg/text/text-align-01-b-expected.txt: Added.
  • platform/qt-5.0/svg/text/text-align-02-b-expected.png: Added.
  • platform/qt-5.0/svg/text/text-align-02-b-expected.txt: Added.
  • platform/qt-5.0/svg/text/text-align-04-b-expected.png: Added.
  • platform/qt-5.0/svg/text/text-align-04-b-expected.txt: Added.
  • platform/qt-5.0/svg/text/text-align-06-b-expected.png: Added.
  • platform/qt-5.0/svg/text/text-align-06-b-expected.txt: Added.
  • platform/qt-5.0/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/qt-5.0/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/qt-5.0/svg/text/text-text-01-b-expected.png: Added.
  • platform/qt-5.0/svg/text/text-text-01-b-expected.txt: Added.
  • platform/qt-5.0/svg/text/text-text-04-t-expected.png: Added.
  • platform/qt-5.0/svg/text/text-text-04-t-expected.txt: Added.
  • platform/qt-5.0/svg/text/text-tselect-01-b-expected.png: Added.
  • platform/qt-5.0/svg/text/text-tselect-01-b-expected.txt: Added.
  • platform/qt-5.0/svg/text/text-tspan-01-b-expected.png: Added.
  • platform/qt-5.0/svg/text/text-tspan-01-b-expected.txt: Added.
  • platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
  • platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Added.
  • platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
  • platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.txt: Added.
6:57 AM Changeset in webkit [117283] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 113099 - Crash in SelectorChecker::checkOneSelector.
https://bugs.webkit.org/show_bug.cgi?id=83040

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/css-set-selector-text-crash.html

Removing the early bail when we detect that our selector text
hasn't changed, and we don't notify the styleSelectorChanged.
In fact, when we adopt the new selector list, the old one will
get destroyed and the styleSelectorChanged call needs to be made.

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

LayoutTests:

  • fast/css/css-set-selector-text-crash-expected.txt: Added.
  • fast/css/css-set-selector-text-crash.html: Added.
6:57 AM Changeset in webkit [117282] by kov@webkit.org
  • 3 edits
    1 add in releases/WebKitGTK/webkit-1.8

Merge 113597 - Crash due to floats not cleared before starting SVG <text> layout.
https://bugs.webkit.org/show_bug.cgi?id=83021

Reviewed by Dirk Schulze.

.:

  • ManualTests/svg-text-float-not-removed-crash.html: Added.

Source/WebCore:

Manual Test - ManualTests/svg-text-float-not-removed-crash.html.
Can't reproduce the failure in DRT.

forceLayoutInlineChildren is used in SVG <text> layout and overrides
RenderBlock::layoutBlock. However, it missed the 'clearFloats' step,
which will cause a crash when trying to access removed renderers.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::forceLayoutInlineChildren):

6:56 AM Changeset in webkit [117281] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 112973 - <select> shouldn't intrude as a run-in.
https://bugs.webkit.org/show_bug.cgi?id=82829

Reviewed by Tony Chang.

Source/WebCore:

Matches Opera's behavior which also does not allow <select>
to intrude as a run-in into the neighbouring block.
IE and Firefox doesn't support run-ins, so can't compare behavior
with them.

Test: fast/runin/select-runin.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::handleRunInChild):

LayoutTests:

  • fast/runin/select-runin-expected.txt: Added.
  • fast/runin/select-runin.html: Added.

Conflicts:

Source/WebCore/rendering/RenderBlock.cpp

6:56 AM Changeset in webkit [117280] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 113825 - Crash due to intruding float not removed from next siblings.
https://bugs.webkit.org/show_bug.cgi?id=83301

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html

markSiblingsWithFloatsForLayout currently only handled overhanging floats and made
checks for those by checking if logicalBottomForFloat > our logicalHeight. We need
to take care of intruding floats as well, since these can intrude into the neighbouring
blocks too. So, generalized the function to check all our next siblings if they contains
that float (one getting removed) and if yes, mark it and all its descendants for layout.
This fixes the crash.

For performance, we change the looping condition to iterate over the next sibling
blocks first and finding which ones can contain floats and then check it against
our floating object list. Currently, it is the other way around and is less
performant due to repeated calls to isRenderBlock(), isFloatingOrPositioned()
and avoidFloats().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):

LayoutTests:

  • fast/block/float/intruding-float-not-removed-from-next-sibling-crash-expected.txt: Added.
  • fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html: Added.
6:56 AM Changeset in webkit [117279] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 113670 - ASSERTION FAILED: !attached() in Node::attach.
https://bugs.webkit.org/show_bug.cgi?id=80726

Reviewed by Adam Barth.

Source/WebCore:

While parsing XML document, prevent attaching the leaf text node
back to document, if its parent is not attached.

Test: fast/dom/text-node-attach-crash.xhtml

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::exitText):

LayoutTests:

  • fast/dom/text-node-attach-crash-expected.txt: Added.
  • fast/dom/text-node-attach-crash.xhtml: Added.
6:55 AM Changeset in webkit [117278] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.8

Merge 112184 - FrameLoader::shouldAllowNavigation uses Frame for context rather than Document
https://bugs.webkit.org/show_bug.cgi?id=81020

Reviewed by Eric Seidel.

Source/WebCore:

The vast majority of security checks in the browser should use a
ScriptExecutionContext (aka a Document) to designate "who" is
attempting to perform a given action. Unfortunately,
shouldAllowNavigation was using a Frame to designate "who" is
attempting the navigation.

In cases when the executing script is "inactive" (i.e., belongs to a
document that is not currently displayed in a Frame), using the Frame
can cause us to grant the script the privileges of the document that's
currently displayed in the Frame rather than the one that contains the
script.

This patch moves shouldAllowNavigation from FrameLoader to Document
(and renames it to canNavigate), effectively change the context object
from a Frame to a Document.

Test: http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html

  • bindings/generic/BindingSecurity.h:

(BindingSecurity):
(WebCore):

  • bindings/v8/V8Utilities.cpp:

(WebCore):

  • bindings/v8/V8Utilities.h:

(WebCore):

  • Deletes unused code.
  • dom/Document.cpp:

(WebCore::canAccessAncestor):
(WebCore):
(WebCore::Document::canNavigate):

  • canNavigate is copied from FrameLoader::shouldAllowNavigation. I've added a null-check bailout if the document is inactive.
  • dom/Document.h:

(Document):

  • loader/FormState.cpp:

(WebCore::FormState::FormState):
(WebCore::FormState::create):

  • loader/FormState.h:

(WebCore):
(FormState):
(WebCore::FormState::sourceDocument):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • Changes the context object from Frame to Document.
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore):
(WebCore::FrameLoader::findFrameForNavigation):

  • FrameLoader::findFrameForNavigation still incorrectly uses Frame as the context object, but that's a bug for another patch.

(WebCore::createWindow):

  • loader/FrameLoader.h:

(FrameLoader):

  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledFormSubmission::fire):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::close):
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::open):

  • page/History.cpp:

(WebCore::History::go):

Source/WebKit/mac:

Update call site to new function name.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchWillSubmitForm):

Source/WebKit/win:

Update call site to new function name.

  • WebFrame.cpp:

(WebFrame::dispatchWillSubmitForm):

Source/WebKit2:

Update call site to new function name.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

LayoutTests:

Test that a script from an inactive document doesn't inherit the
navigation privileges of the document that currently occupies the
frame.

  • http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child-expected.txt: Added.
  • http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html: Added.
  • http/tests/security/frameNavigation/resources/fail.html: Added.
  • http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html:
  • http/tests/security/frameNavigation/resources/popup-ready-to-navigate-child.html: Added.
6:55 AM Changeset in webkit [117277] by pfeldman@chromium.org
  • 21 edits
    1 move in trunk

Web Inspector: split ScriptMapping into UISourceCodeProvider and SourceMapping.
https://bugs.webkit.org/show_bug.cgi?id=86616

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change simply splits the interface.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.get uiSourceCodes):
(WebInspector.CompilerScriptMapping.prototype.reset):

  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/DebuggerResourceBinding.js:

(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):

  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype.uiSourceCodes):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeAdded):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeReplaced):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeRemoved):

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.OpenScriptDialog):
(WebInspector.OpenScriptDialog.install):
(WebInspector.OpenScriptDialog._show):

  • inspector/front-end/PresentationConsoleMessageHelper.js:

(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleCleared):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.uiSourceCodes):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):

  • inspector/front-end/Script.js:
  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._uiSourceCodes):
(WebInspector.SnippetScriptMapping.prototype.uiSourceCodes):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeAdded):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeRemoved):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):

  • inspector/front-end/SourceMapping.js: Renamed from Source/WebCore/inspector/front-end/ScriptMapping.js.
  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCodeProvider):
(WebInspector.UISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.UILocation):
(WebInspector.UILocation.prototype.uiLocationToRawLocation):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • inspector/debugger/scripts-panel.html:
6:47 AM Changeset in webkit [117276] by commit-queue@webkit.org
  • 14 edits in trunk

Add didFinishProgress BundleUIClient callback
https://bugs.webkit.org/show_bug.cgi?id=86541

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-16
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Added didFinishProgress BundleUIClient callback needed by
WebKitTestRunner. This callback is invoked in postProgressFinishedNotification.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didFinishProgress):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

(InjectedBundlePageLoaderClient):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):

  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

Tools:

Added support for dumpProgressFinishedCallback.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didFinishProgress):
(WTR):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpProgressFinishedCallback):
(WTR::LayoutTestController::setShouldDumpProgressFinishedCallback):
(WTR::LayoutTestController::shouldDumpProgressFinishedCallback):
(LayoutTestController):

LayoutTests:

Unskip passing test.

  • platform/qt-5.0-wk2/Skipped:
6:44 AM Changeset in webkit [117275] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Fix my typo.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-16

  • platform/qt/Skipped: After r117262.
6:40 AM Changeset in webkit [117274] by vsevik@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: Implement snippet creation/renaming in ScriptsNavigator.
https://bugs.webkit.org/show_bug.cgi?id=82622

Reviewed by Pavel Feldman.

Implemented snippet creation and renaming.
Added TitleChanged event to UISourceCode.

  • inspector/front-end/NavigatorOverlayController.js:

(WebInspector.NavigatorOverlayController.prototype._containingElementFocused):
(WebInspector.NavigatorOverlayController.prototype.isNavigatorPinned):
(WebInspector.NavigatorOverlayController.prototype.isNavigatorHidden):

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype._uiSourceCodeTitleChanged):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._addUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._removeUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._fileRenamed):
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._snippetsNavigatorViewForUISourceCode):
(WebInspector.ScriptsNavigator.prototype.addUISourceCode):
(WebInspector.ScriptsNavigator.prototype.isScriptSourceAdded):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCode):
(WebInspector.ScriptsNavigator.prototype.rename):
(WebInspector.ScriptsNavigator.prototype._fileRenamed):
(WebInspector.ScriptsNavigator.prototype._snippetCreationRequested):
(WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._snippetCreationRequested):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.set _hideDebuggerSidebar):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeTitleChanged):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.urlChanged):

6:25 AM Changeset in webkit [117273] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: gradient properties are painful to inspect / author.
https://bugs.webkit.org/show_bug.cgi?id=86379

Reviewed by Pavel Feldman.

The CSS styles layout has been changed to allow property values to wrap onto subsequent lines
to let the users see the entire value text.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle.): Avoid line breaks between the color swatch and value.

  • inspector/front-end/elementsPanel.css:

(.styles-section .properties li.not-parsed-ok img.exclamation-mark):
(.styles-section .properties li):
(.styles-section .properties li .webkit-css-property):
(.styles-section.expanded .properties > li):
(.styles-section .properties > li .webkit-css-property):
(.styles-section .properties > li.child-editing):
(.styles-section .properties > li.child-editing .webkit-css-property):
(.styles-section .properties .enabled-button):

6:16 AM Changeset in webkit [117272] by yurys@chromium.org
  • 7 edits
    1 move in trunk/Source/WebCore

Web Inspector: rename ProfileView.js to CPUProfileView.js
https://bugs.webkit.org/show_bug.cgi?id=86612

Reviewed by Pavel Feldman.

Renamed ProfileView.js to CPUProfileView.js to match the file content.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CPUProfileView.js: Renamed from Source/WebCore/inspector/front-end/ProfileView.js.

(WebInspector.CPUProfileView.profileCallback):
(WebInspector.CPUProfileView.prototype.get statusBarItems):
(WebInspector.CPUProfileView.prototype.get profile):
(WebInspector.CPUProfileView.prototype.set profile):
(WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):
(WebInspector.CPUProfileView.prototype.get topDownProfileDataGridTree):
(WebInspector.CPUProfileView.prototype.get currentTree):
(WebInspector.CPUProfileView.prototype.set currentTree):
(WebInspector.CPUProfileView.prototype.willHide):
(WebInspector.CPUProfileView.prototype.refresh):
(WebInspector.CPUProfileView.prototype.refreshVisibleData):
(WebInspector.CPUProfileView.prototype.refreshShowAsPercents):
(WebInspector.CPUProfileView.prototype.searchCanceled):
(WebInspector.CPUProfileView.prototype.performSearch.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):
(WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToLastSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToNextSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult):
(WebInspector.CPUProfileView.prototype.showingFirstSearchResult):
(WebInspector.CPUProfileView.prototype.showingLastSearchResult):
(WebInspector.CPUProfileView.prototype._jumpToSearchResult):
(WebInspector.CPUProfileView.prototype._changeView.set else):
(WebInspector.CPUProfileView.prototype._focusClicked):
(WebInspector.CPUProfileView.prototype._excludeClicked):
(WebInspector.CPUProfileView.prototype._resetClicked):
(WebInspector.CPUProfileView.prototype._dataGridNodeSelected):
(WebInspector.CPUProfileView.prototype._dataGridNodeDeselected):
(WebInspector.CPUProfileView.prototype._sortProfile):
(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.get buttonTooltip):
(WebInspector.CPUProfileType.prototype.buttonClicked):
(WebInspector.CPUProfileType.prototype.get treeItemTitle):
(WebInspector.CPUProfileType.prototype.get description):
(WebInspector.CPUProfileType.prototype.isRecordingProfile):
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.stopRecordingProfile):
(WebInspector.CPUProfileType.prototype.setRecordingProfile):
(WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.CPUProfileType.prototype.createView):
(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
5:53 AM Changeset in webkit [117271] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

"border: collapse" + "display: none" rows in the tbody while having thead or tfoot doesn't render the opposite border
https://bugs.webkit.org/show_bug.cgi?id=67877

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-05-16
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/table-collapsed-borders.html

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
When getting the previous row group's after border, pass SkipEmptySections as the second param
to the RenderTable::sectionAbove() call. Thus if the currSection is the top most section of the
table passing SkipEmptySections to sectionAbove() would return null which should be the expected
behavior.

(WebCore::RenderTableCell::computeCollapsedAfterBorder):
When getting the following row group's before border, pass SkipEmptySections as the second param
to the RenderTable::sectionBelow() call. Thus if the currSection is the bottom most section of the
table passing SkipEmptySections to sectionBelow() would return null which should be the expected
behavior.

LayoutTests:

  • fast/css/table-collapsed-borders-expected.html: Added.
  • fast/css/table-collapsed-borders.html: Added.

Added new reftest for testing table with collapsed borders.

5:48 AM Changeset in webkit [117270] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: follow up to r117267 - fixing typo and removing unnecessary dispatch.
https://bugs.webkit.org/show_bug.cgi?id=86613

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):

5:41 AM Changeset in webkit [117269] by vsevik@chromium.org
  • 14 edits in trunk

Web Inspector: Move edit/save script source logic to JavaScriptSource.
https://bugs.webkit.org/show_bug.cgi?id=86604

Reviewed by Pavel Feldman.

Source/WebCore:

Added working copy notion to UISourceCode.
Moved DebuggerResourceBinding content edit calls to JavaScriptSource.
Added WorkingCopyChanged event to UISourceCode.

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/DebuggerResourceBinding.js:

(WebInspector.DebuggerResourceBinding.prototype.canSetContent):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector.JavaScriptSource.prototype.isEditable):
(WebInspector.JavaScriptSource.prototype.commitWorkingCopy):
(WebInspector):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.wasShown):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeContentChanged):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._removeUISourceCode):
(WebInspector.NavigatorView.prototype._addUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._removeUISourceCodeListeners):
(WebInspector.NavigatorView.prototype.reset):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createUISourceCode):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._updateFileTitle.get if):
(WebInspector.TabbedEditorContainer.prototype._updateFileTitle):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeContentChanged):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.contentChanged):
(WebInspector.UISourceCode.prototype.isEditable):
(WebInspector.UISourceCode.prototype.workingCopy):
(WebInspector.UISourceCode.prototype.setWorkingCopy):
(WebInspector.UISourceCode.prototype.isDirty):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/scripts-panel.html:
5:36 AM Changeset in webkit [117268] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] A few tests need expected result or rebaselining
https://bugs.webkit.org/show_bug.cgi?id=86595

Unreviewed EFL gardening. Add missing EFL text expectation for
media/video-frame-accurate-seek.html.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16

  • platform/efl/media/video-frame-accurate-seek-expected.txt: Added.
5:22 AM Changeset in webkit [117267] by pfeldman@chromium.org
  • 14 edits in trunk

Web Inspector: get rid of UISourceCodeListChanged event.
https://bugs.webkit.org/show_bug.cgi?id=86601

Reviewed by Vsevolod Vlasov.

Source/WebCore:

There was unnecessary conversion between this event and UISourceCodeAdded/Removed/Replaced.

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.reset):

  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeAdded):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeReplaced):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeRemoved):

  • inspector/front-end/NavigatorView.js:
  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
(WebInspector.ResourceScriptMapping.prototype.reset):

  • inspector/front-end/ScriptMapping.js:
  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.ScriptSnippetModel.prototype._reset):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeAdded):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeRemoved):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype.replaceUISourceCode):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):

  • inspector/front-end/TabbedEditorContainer.js:

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • inspector/debugger/scripts-panel.html:
5:07 AM Changeset in webkit [117266] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Layout tests under inspector/profiler are failing on chromium win
https://bugs.webkit.org/show_bug.cgi?id=86495

Unreviewed. Remove custom expectations for heap profiler tests. They should pass
after r117241.

  • platform/chromium/test_expectations.txt:
5:00 AM Changeset in webkit [117265] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Remove full-screen-keyboard-disabled.html from test_expectation.txt
https://bugs.webkit.org/show_bug.cgi?id=86596

Unreviewed EFL gardening.

Remove full-screen-keyboard-disabled.html from test_expectation.txt.
This case is not failed since r117205.

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-16

  • platform/efl/test_expectations.txt:
4:58 AM Changeset in webkit [117264] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] [DRT] Unskip passing tests related to computedStyleIncludingVisitedInfo and display
https://bugs.webkit.org/show_bug.cgi?id=86473

Unreviewed gardening, partially reverts r117073.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-16

  • platform/efl/Skipped:
4:55 AM Changeset in webkit [117263] by keishi@webkit.org
  • 16 edits
    2 adds in trunk

[chromium] Add WebKit API to access inner text value of input element
https://bugs.webkit.org/show_bug.cgi?id=85353

Reviewed by Kent Tamura.

.:

  • Source/autotools/symbols.filter: Added HTMLInputElement::setEditingValue

Source/WebCore:

Test: fast/forms/editing-value.html

We need this to implement the datalist UI for <input type=email multiple>.
HTMLInputElement.value gives you the sanitized value so the whitespace between values are trimmed.
We need to append the selected suggestion to the end without modifying the rest of the text.

  • WebCore.exp.in: Added HTMLInputElement::setEditingValue
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setEditingValue):
(WebCore):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • testing/Internals.cpp:

(WebCore::Internals::setEditingValue):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/chromium:

  • public/WebInputElement.h:

(WebInputElement):

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::editingValue):
(WebKit):
(WebKit::WebInputElement::setEditingValue):

Source/WebKit2:

  • win/WebKit2.def: Added HTMLInputElement::setEditingValue
  • win/WebKit2CFLite.def: Added HTMLInputElement::setEditingValue

LayoutTests:

  • fast/forms/editing-value-expected.txt: Added.
  • fast/forms/editing-value.html: Added. Tests that setting the editing value takes care of the style and placeholder, and that it fires an input event.
4:47 AM Changeset in webkit [117262] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Gardening. Skip failing test after 117246.
https://bugs.webkit.org/show_bug.cgi?id=86606

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-16
Reviewed by Csaba Osztrongonác.

  • platform/qt/Skipped:
4:43 AM Changeset in webkit [117261] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Cookies should be checked during parsing to improve performance.
https://bugs.webkit.org/show_bug.cgi?id=85028

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-16
Reviewed by George Staikos.

We shouldn't waste time and memery on invalid cookies. It is better to drop them during parsing.
We shouldn't check the default domain since it is set with host. So we only check domains which are parsed
from response headers.

No new tests. No functionality change.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::setCookies):

  • platform/blackberry/CookieManager.h:
  • platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):

4:36 AM Changeset in webkit [117260] by pierre.rossi@gmail.com
  • 87 edits
    1 copy
    23 adds in trunk/LayoutTests

Unreviewed gardening: updating expectations after r117259
https://bugs.webkit.org/show_bug.cgi?id=86463

  • platform/qt/http/tests/misc/SVGFont-delayed-load-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/qt/svg/custom/acid3-test-77-expected.txt: Added.
  • platform/qt/svg/custom/altglyph-expected.png:
  • platform/qt/svg/custom/altglyph-expected.txt:
  • platform/qt/svg/custom/font-face-simple-expected.png:
  • platform/qt/svg/custom/font-face-simple-expected.txt:
  • platform/qt/svg/custom/global-constructors-expected.txt: Added.
  • platform/qt/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/qt/svg/custom/glyph-selection-lang-attribute-expected.txt:
  • platform/qt/svg/custom/glyph-setting-d-attribute-expected.png:
  • platform/qt/svg/custom/glyph-setting-d-attribute-expected.txt: Added.
  • platform/qt/svg/custom/insertItemBefore-from-non-list-origin-expected.txt: Added.
  • platform/qt/svg/custom/missing-xlink-expected.png: Added.
  • platform/qt/svg/custom/missing-xlink-expected.txt: Added.
  • platform/qt/svg/custom/path-bad-data-expected.png: Added.
  • platform/qt/svg/custom/path-bad-data-expected.txt: Added.
  • platform/qt/svg/custom/stroke-width-click-expected.txt: Added.
  • platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/qt/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/qt/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
  • platform/qt/svg/custom/visibility-override-filter-expected.png: Copied from LayoutTests/platform/qt/svg/custom/glyph-setting-d-attribute-expected.png.
  • platform/qt/svg/custom/visibility-override-filter-expected.txt: Added.
  • platform/qt/svg/dom/altGlyph-dom-expected.txt:
  • platform/qt/svg/dom/baseVal-animVal-crash-expected.txt: Added.
  • platform/qt/svg/dom/font-face-elements-expected.txt: Added.
  • platform/qt/svg/text/kerning-expected.png:
  • platform/qt/svg/text/kerning-expected.txt:
  • platform/qt/svg/text/multichar-glyph-expected.png:
  • platform/qt/svg/text/multichar-glyph-expected.txt:
  • platform/qt/svg/text/text-altglyph-01-b-expected.png:
  • platform/qt/svg/text/text-altglyph-01-b-expected.txt:
  • platform/qt/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/qt/svg/text/text-fonts-01-t-expected.txt: Added.
  • platform/qt/svg/text/text-hkern-expected.png:
  • platform/qt/svg/text/text-hkern-expected.txt:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.png:
  • platform/qt/svg/text/text-intro-05-t-expected.png: Added.
  • platform/qt/svg/text/text-intro-05-t-expected.txt: Added.
  • platform/qt/svg/text/text-text-04-t-expected.png:
  • platform/qt/svg/text/text-text-04-t-expected.txt:
  • platform/qt/svg/text/text-text-05-t-expected.png:
  • platform/qt/svg/text/text-text-05-t-expected.txt:
  • platform/qt/svg/text/text-text-06-t-expected.png:
  • platform/qt/svg/text/text-text-06-t-expected.txt:
  • platform/qt/svg/text/text-tselect-02-f-expected.png: Added.
  • platform/qt/svg/text/text-tselect-02-f-expected.txt: Added.
  • platform/qt/svg/text/text-vkern-expected.png:
  • platform/qt/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.png:
4:29 AM Changeset in webkit [117259] by pierre.rossi@gmail.com
  • 9 edits in trunk

[Qt] Enable SVG Fonts by default
https://bugs.webkit.org/show_bug.cgi?id=86463

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Another feature we can get for free after switching to using
the font fast path with QRawFont.
It will get disabled in features.prf if either SVG support is
disabled or if we are not using QRawFont (e.g. for Qt 4).

Covered by a series of tests that were skipped for the
Qt port up until now.

  • platform/graphics/qt/FontPlatformData.h:

(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
Initialize the platform data used as fallback in conjunction with SVG
fonts so it will honor size, weight and oblique-ness.

  • rendering/svg/SVGTextMetricsBuilder.cpp: Avoid forcing the complex path.

(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText):
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::ensureGlyphCache): avoid ambiguity with String(const QString&)

Tools:

  • qmake/mkspecs/features/features.pri:

LayoutTests:

  • platform/qt-4.8/Skipped: Skipped the relevant tests...
  • platform/qt/Skipped: ... and unskipped them here.
4:26 AM Changeset in webkit [117258] by commit-queue@webkit.org
  • 13 edits in trunk

[EFL] EFL's LayoutTestController does not implement setApplicationCacheOriginQuota
https://bugs.webkit.org/show_bug.cgi?id=85585

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Add new function to Ewk_Security_Origin to set the application cache
quota. Implement reachedApplicationCacheOriginQuota in
ChromeClientEfl. Add function to the Ewk_View to report that the
application cache quota was reached.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::reachedApplicationCacheOriginQuota):

  • ewk/ewk_security_origin.cpp:

(ewk_security_origin_application_cache_quota_set):

  • ewk/ewk_security_origin.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_exceeded_application_cache_quota):

  • ewk/ewk_view.h:
  • ewk/ewk_view_private.h:

Tools:

Implement setApplicationCacheOriginQuota in EFL's
LayoutTestController.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onExceededApplicationCacheQuota):
(drtViewAdd):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setApplicationCacheOriginQuota):

LayoutTests:

Unskip the test cases that require implementation of
setApplicationCacheOriginQuota in EFL's LayoutTestController.

  • platform/efl/Skipped:
4:20 AM Changeset in webkit [117257] by bashi@chromium.org
  • 4 edits in trunk/Source

[Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing
https://bugs.webkit.org/show_bug.cgi?id=86589

Reviewed by Kent Tamura.

Source/Platform:

  • chromium/public/WebTransformationMatrix.h: Added destructor.

(WebTransformationMatrix):

Source/WebCore:

Need to call m_private.reset(0) before destructing WebTransformationMatrix objects.

No new tests. WebTransformationMatrixTest should pass on debug build.

  • platform/chromium/support/WebTransformationMatrix.cpp:

(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
(WebKit):

4:13 AM Changeset in webkit [117256] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk/LayoutTests

[EFL] A few tests need expected result or rebaselining
https://bugs.webkit.org/show_bug.cgi?id=86595

Unreviewed EFL gardening. Add expected results for a few tests and
unskip them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16

  • platform/efl/Skipped:
  • platform/efl/fast/forms/input-text-double-click-expected.png: Added.
  • platform/efl/fast/forms/input-text-double-click-expected.txt:
  • platform/efl/http/tests/misc/slow-loading-mask-expected.png: Added.
  • platform/efl/http/tests/misc/slow-loading-mask-expected.txt: Added.
  • platform/efl/media/video-frame-accurate-seek-expected.png: Added.
4:03 AM Changeset in webkit [117255] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation
https://bugs.webkit.org/show_bug.cgi?id=83776

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-16
Reviewed by Tor Arne Vestbø.

Source/WebKit/efl:

Added helper new function implementing JS script evaluation in an isolated world.
Worlds are cached by their id.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Added missing implementation of LayoutTestController::evaluateScriptInIsolatedWorld().

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::evaluateScriptInIsolatedWorld):

LayoutTests:

Unskipped corresponding testcases.

  • platform/efl/test_expectations.txt:
3:58 AM WebKit Team edited by g.czajkowski@samsung.com
(diff)
3:43 AM Changeset in webkit [117254] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Move WebFrameNetworkingContext to WebKit namespace.
https://bugs.webkit.org/show_bug.cgi?id=86590

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-16
Reviewed by Simon Hausmann.

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::create):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:

(WebKit):
(WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::originatingObject):
(WebKit::WebFrameNetworkingContext::~WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::networkAccessManager):
(WebKit::WebFrameNetworkingContext::mimeSniffingEnabled):
(WebKit::WebFrameNetworkingContext::thirdPartyCookiePolicyPermission):

3:34 AM Changeset in webkit [117253] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] http/tests/misc/iframe-reparenting-id-collision.html can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=86588

Unreviewed EFL gardening. Unskip
http/tests/misc/iframe-reparenting-id-collision.html which is passing
now that Bug 64085 is closed.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16

  • platform/efl/Skipped:
3:27 AM Changeset in webkit [117252] by g.czajkowski@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
3:24 AM Changeset in webkit [117251] by hans@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Speech JavaScript API: pass WebSecurityOrigin to embedder
https://bugs.webkit.org/show_bug.cgi?id=86348

Reviewed by Adam Barth.

Pass the WebSecurityOrigin of the SpeecReco object to the embedder when calling
start(). The origin will be used to determine whether speech recognition is
allowed or not.

  • public/WebSpeechRecognitionParams.h:

(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::origin):
(WebSpeechRecognitionParams):

  • src/SpeechRecognitionClientProxy.cpp:

(WebKit::SpeechRecognitionClientProxy::start):

3:19 AM Changeset in webkit [117250] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening after r117123 and r117225.

  • platform/gtk/test_expectations.txt:
3:08 AM Changeset in webkit [117249] by shinyak@chromium.org
  • 11 edits
    5 adds
    3 deletes in trunk

ShadowRoot.selection should return the seleciton whose range is in a shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=82698

Reviewed by Ryosuke Niwa.

Source/WebCore:

The selection object returned from shadowRoot.selection should be able to see
the inner object of the shadowRoot.

In the previous code, the node out of the shadow subtree was returned for
anchorNode, focusNode, baseNode, and extentNode. This patch enables us to get
the corresponding shadow ancestor in the specified TreeScope (m_treeScope).

Tests: editing/shadow/selection-of-orphan-shadowroot.html

editing/shadow/selection-of-shadowroot.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::selection):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::getSelection): When shadow DOM feature is not enabled, we want to use the same
instance of DOMSelection among Document and ShadowRoot.

  • dom/TreeScopeAdjuster.cpp:

(WebCore::TreeScopeAdjuster::TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::ancestorInThisScope): Since node could be null, I've added a node check code.

  • dom/TreeScopeAdjuster.h:

(TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::treeScope):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::anchorNode):
(WebCore::DOMSelection::anchorOffset):
(WebCore::DOMSelection::focusNode):
(WebCore::DOMSelection::focusOffset):
(WebCore::DOMSelection::baseNode):
(WebCore::DOMSelection::baseOffset):
(WebCore::DOMSelection::extentNode):
(WebCore::DOMSelection::extentOffset):
(WebCore::DOMSelection::shadowAdjustedNode): Gets the corresponding node in the m_treeScope from the Position.
(WebCore):
(WebCore::DOMSelection::shadowAdjustedOffset): Gets the corresponding node offset in the m_treeScope from the Position.

  • page/DOMSelection.h:

(WebCore):
(DOMSelection):

LayoutTests:

This patch contains 2 tests:

  • Generates a complex HTML tree having a ShadowRoot, an older ShadowRoot, a nested ShadowRoot,

nested ShadowRoot in an older ShadowRoot, etc., and try to drag from a nested shadow root of
older shadow root to a nested shadow root of younger shadow root. Then checks nodes of Shadowroot.selection
are in the same tree scope or null.

  • Generates a ShadowDOM which is not inserted into a document, and confirms nodes taken from

the selection are all null.

Also, this patch deprecates old shadowRoot.selection tests, because they test to check
window.getSelection() and shadowRoot.selection is the same. This behavior is changed by this patch.

  • editing/shadow/selection-of-orphan-shadowroot-expected.txt: Added.
  • editing/shadow/selection-of-orphan-shadowroot.html: Added.
  • editing/shadow/selection-of-shadowroot-expected.txt: Added.
  • editing/shadow/selection-of-shadowroot.html: Added.
  • fast/dom/resources/event-sender-util.js:

(mouseMoveToElem):
(dragFromTo):

  • fast/dom/shadow/resources/shadow-dom-util.js: Added.

(getElementByIdConsideringShadowDOM.iter):
(getElementByIdConsideringShadowDOM):

  • fast/dom/shadow/selection-in-shadow.html: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/shadow/selection-in-shadow-expected.txt: Removed.
  • platform/chromium/fast/dom/shadow/selection-in-shadow-expected.txt: Removed.
  • platform/qt/Skipped:
2:58 AM Changeset in webkit [117248] by abecsi@webkit.org
  • 6 edits in trunk

[WTR] Visited link tracking is not disabled properly
https://bugs.webkit.org/show_bug.cgi?id=76699

Reviewed by Jocelyn Turcotte.

Source/WebKit2:

If PLATFORM_STRATEGIES is enabled visited link tracking is done through
VisitedLinkProvider and not through PageGroup.
InjectedBundle sets the shouldTrackVisitedLinks flag on the PageGroup,
thus the shared VisitedLinkTable does get populated with visited links
regardless of the flag.

The WebProcess should only track visited links if tracking is specifically
enabled for a test through WTR's LayoutTestController.

This patch fixes several flacky and failing layout tests on Qt-WK2.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setShouldTrackVisitedLinks): Let the WebProcess
know about visited link tracking.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::setShouldTrackVisitedLinks):
(WebKit::WebProcess::addVisitedLink):

  • WebProcess/WebProcess.h:

(WebProcess):

LayoutTests:

  • platform/qt-5.0-wk2/Skipped: Unskip passing tests.
2:54 AM Changeset in webkit [117247] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update

Adding further suppressions for flaky tests on cr-linux ews.

  • platform/chromium/test_expectations.txt:
2:46 AM Changeset in webkit [117246] by commit-queue@webkit.org
  • 5 edits
    1 copy
    2 adds in trunk

[BlackBerry] xhr request to non existent file response is 0 and not 404.
https://bugs.webkit.org/show_bug.cgi?id=86344

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-16
Reviewed by George Staikos.

Source/WebCore:

NetworkJob receives 404 for a XMLHttpRequest which calls open("HEAD", "notExist.html", true).
There are no data received because its method is HEAD.
This case should not be treated as a failure.

Add shouldNotifyClientFailed() to treat XMLHttpRequest as a special case.
XMLHttpRequest will fail when status code is smaller than zero.

If we use "GET" and receive 404 without body, NetworkJob won't go through failing code path, too.
So add http/tests/xmlhttprequest/xmlhttprequest-check-get-readystate-for-404-without-body.html
to check this case.

Test: http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html

http/tests/xmlhttprequest/xmlhttprequest-check-get-readystate-for-404-without-body.html

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendResponseIfNeeded):

LayoutTests:

  • http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html:
2:43 AM Changeset in webkit [117245] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip a fixed test
https://bugs.webkit.org/show_bug.cgi?id=84434

  • platform/qt-5.0-wk2/Skipped:
2:34 AM Changeset in webkit [117244] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] fast/loader/stateobjects/replacestate-in-iframe.html can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=86586

Unreviewed EFL gardening. Unskip
fast/loader/stateobjects/replacestate-in-iframe.html since the
infinite loop bug has been fixed in r81232.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16

  • platform/efl/Skipped:
2:32 AM Changeset in webkit [117243] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.
Modified test fails after r117123.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-16

  • platform/qt/Skipped:
2:32 AM Changeset in webkit [117242] by morrita@google.com
  • 22 edits in trunk/Source/WebCore

HasCustomWillOrDidRecalcStyleFlag and family should live in a bit.
https://bugs.webkit.org/show_bug.cgi?id=86175

Reviewed by Ryosuke Niwa.

This change unifies following flags into one HasCustomCallbacksFlag.

  • HasCustomWillOrDidRecalcStyleFlag
  • HasCustomStyleForRendererFlag
  • IsFrameOwnerElementFlag

By this change, some callbacks can be called even if there are no override.
So all custom callbacks should just pass these invocations.

No new tests. No behavior change.

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildFrameDisconnector::collectDescendant):

  • dom/Element.cpp:

(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):
(WebCore::Element::willRecalcStyle):
(WebCore):
(WebCore::Element::didRecalcStyle):
(WebCore::Element::customStyleForRenderer):

  • dom/Element.h:

(Element):

  • dom/Node.h:

(WebCore::Node::isFrameOwnerElement):
(WebCore::Node::hasCustomCallbacks):
(WebCore::Node::setHasCustomCallbacks):

  • dom/Text.cpp:

(WebCore::Text::recalcTextStyle):
(WebCore::Text::willRecalcTextStyle):
(WebCore):

  • dom/Text.h:

(Text):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::disconnectContentFrame):

  • html/HTMLFrameOwnerElement.h:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::HTMLIFrameElement):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache):
(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache):
(WebCore::HTMLPlugInImageElement::customStyleForRenderer):

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerElement::customStyleForRenderer):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
(WebCore::TextControlInnerTextElement::customStyleForRenderer):

  • html/shadow/TextControlInnerElements.h:

(TextControlInnerElement):
(TextControlInnerTextElement):

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::TextFieldDecorationElement):
(WebCore::TextFieldDecorationElement::customStyleForRenderer):

  • html/shadow/TextFieldDecorationElement.h:

(TextFieldDecorationElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::SVGElement):
(WebCore::SVGElement::customStyleForRenderer):

  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGShadowText::SVGShadowText):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement):

2:26 AM Changeset in webkit [117241] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: exception when switching to heap profiler comparison view
https://bugs.webkit.org/show_bug.cgi?id=86224

Reviewed by Pavel Feldman.

Make sure the messages are dispatched in the same order as they are sent in
case a fake worker is used for heap snapshot processing.

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.AsyncTaskQueue):
(WebInspector.AsyncTaskQueue.prototype.addTask):
(WebInspector.AsyncTaskQueue.prototype._onTimeout):
(WebInspector.AsyncTaskQueue.prototype._scheduleTimer):
(WebInspector.HeapSnapshotFakeWorker):
(WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):

2:19 AM Changeset in webkit [117240] by commit-queue@webkit.org
  • 14 edits in trunk/LayoutTests

[EFL][DRT] Gardening failures after r117123 and r117205
https://bugs.webkit.org/show_bug.cgi?id=86584

Unreviewed, EFL gardening.

Media expectations updated now that they draw the fullscreen icon.
Moved flaky test to test_expectations, unskipped unexpected pass.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-16

  • platform/efl/media/controls-after-reload-expected.png:
  • platform/efl/media/controls-after-reload-expected.txt:
  • platform/efl/media/controls-strict-expected.png:
  • platform/efl/media/controls-strict-expected.txt:
  • platform/efl/media/controls-without-preload-expected.png:
  • platform/efl/media/controls-without-preload-expected.txt:
  • platform/efl/media/video-controls-rendering-expected.png:
  • platform/efl/media/video-controls-rendering-expected.txt:
  • platform/efl/media/video-display-toggle-expected.png:
  • platform/efl/media/video-display-toggle-expected.txt:
  • platform/efl/media/video-zoom-controls-expected.png:
  • platform/efl/media/video-zoom-controls-expected.txt:
  • platform/efl/test_expectations.txt:
2:16 AM Changeset in webkit [117239] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Add new commands for Ewk_Editor_Command.
https://bugs.webkit.org/show_bug.cgi?id=74921

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-05-16
Reviewed by Hajime Morita.

Add new commands for Ewk_Editor_Command enum and introduce new table to keep
enum and string values in sync.

  • ewk/ewk_view.cpp: Added a table with EditorCommand struct elements.

(EditorCommand): Added structure consisting of enum and string value.
(_Ewk_View_Private_Data):
(_ewk_view_editor_command_string_get): Added.
(ewk_view_editor_command_execute):

  • ewk/ewk_view.h: Ewk_Editor_Command enum extended.
2:12 AM Changeset in webkit [117238] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] PlatformKeyboardEvent: figures, letters and printscreen key handling
https://bugs.webkit.org/show_bug.cgi?id=85503

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-16
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

  • platform/efl/EflKeyboardUtilities.cpp:

(WebCore::addCharactersToKeyMap): aux function
(WebCore):
(WebCore::createKeyMap): Figures and letters keys are added to the keyMap
(WebCore::addCharactersToWinKeyMap): aux function
(WebCore::createWindowsKeyMap): Capital letters keys are added to the windowsKeyMap. Corrected value for printscreen key.
(WebCore::singleCharacterString): Return empty text for printscreen key.

LayoutTests:

Bug-related testcases are unskipped.

  • platform/efl/Skipped:
2:00 AM Changeset in webkit [117237] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Tests that require DASHBOARD_SUPPORT should be moved to test expectations
https://bugs.webkit.org/show_bug.cgi?id=86578

Unreviewed EFL gardening. Move tests that require DASHBOARD_SUPPORT
flag to test expectations and skip them since this feature is
Mac-specific.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
1:57 AM Changeset in webkit [117236] by yurys@chromium.org
  • 2 edits in trunk/PerformanceTests

Unreviewed. Fix heap profiler performance test after r117234.

  • inspector/heap-snapshot.html:
1:56 AM Changeset in webkit [117235] by pfeldman@chromium.org
  • 20 edits
    1 move in trunk

Web Inspector: rename DebuggerPresentationModel to DebuggerScriptMapping, make it private to ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=86594

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change completes the elimination of the presentation model.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/AuditFormatters.js:

(WebInspector.AuditFormatters.resourceLink):

  • inspector/front-end/DebuggerResourceBinding.js:

(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):

  • inspector/front-end/DebuggerScriptMapping.js: Renamed from Source/WebCore/inspector/front-end/DebuggerPresentationModel.js.

(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeListChanged):

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.OpenScriptDialog):
(WebInspector.OpenScriptDialog.install):
(WebInspector.OpenScriptDialog._show):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):

  • inspector/front-end/PresentationConsoleMessageHelper.js:

(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleCleared):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._loadUISourceCodes):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCodeProject):
(WebInspector.UISourceCodeProject.prototype.uiSourceCodes):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._createPanels):

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/linkifier.html:
  • inspector/debugger/scripts-panel.html:
1:47 AM Changeset in webkit [117234] by yurys@chromium.org
  • 7 edits in trunk

Web Inspector: use separate fields for storing HeapSnapshotLoaderProxy and HeapSnapshotProxy
https://bugs.webkit.org/show_bug.cgi?id=86488

Reviewed by Pavel Feldman.

Source/WebCore:

Simplified heap profiler snapshot loading code. Introduced dedicated fields for
snapshot loader proxy and for snapshot proxy.

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotLoaderProxy):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.callLoadCallbacks):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype.get loaded):
(WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.profileCallback):
(WebInspector.HeapSnapshotView):
(WebInspector.HeapSnapshotView.prototype.dispose):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback1):
(WebInspector.HeapSnapshotView.prototype._changeView):
(WebInspector.HeapProfileHeader): split _proxy field into _loaderProxy and _snapshotProxy
(WebInspector.HeapProfileHeader.prototype.snapshotProxy):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
(WebInspector.HeapProfileHeader.prototype.dispose):
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate):
(WebInspector.HeapProfileHeader.prototype.pushJSONChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.canSaveToFile):
(WebInspector.HeapProfileHeader.prototype.loadFromFile.onLoad):
(WebInspector.HeapProfileHeader.prototype.loadFromFile):

LayoutTests:

  • inspector/profiler/heap-snapshot-inspect-dom-wrapper.html: instead of sniffing a method

call we can use HeapProfileHeader.load directly.

1:38 AM Changeset in webkit [117233] by caseq@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Use CSS columns feature for HelpScreen contents.
https://bugs.webkit.org/show_bug.cgi?id=86367

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-16
Reviewed by Yury Semikhatsky.

Right-docked inspector should show shortcuts/settings in one column.
Bottom-docked inspector should use horizontal space more effectively
(more than 2 columns in shortcuts/settings).

Please see attached screenshots.

UI adjustments, no new tests.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen): Turned table to div.
(WebInspector.SettingsScreen.prototype._appendSection): Removed.

  • inspector/front-end/ShortcutsScreen.js:

(WebInspector.ShortcutsScreen.prototype._buildTable): Removed "balancing" algorithm.
(WebInspector.ShortcutsSection.prototype.renderSection): Turned table to div.
(WebInspector.ShortcutsSection.prototype._renderHeader): Ditto.

  • inspector/front-end/helpScreen.css: Use CSS columns feature.

(.help-container): Added columns container.
(.help-block): Added "section".
(.help-line): Added key shortcut line.
(.help-key-cell): Added key shortcut cell.
(.help-cell): Ditto
(.help-section-title): Combined title classes
(.help-content p): Adjusted spacing.

1:18 AM Changeset in webkit [117232] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update

Removes unnecessary entries and added suppressions
for some flaky tests on cr-linux ews.

  • platform/chromium/test_expectations.txt:
1:00 AM Changeset in webkit [117231] by jochen@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp

Merge 116556 - [chromium] Check whether an active document loader exists before accessing it
https://bugs.webkit.org/show_bug.cgi?id=85892

Reviewed by Eric Seidel.

Although FrameLoader::loadInSameDocument which invokes this
method does not have a provisional document loader, we're seeing crashes
where the FrameLoader is in provisional state, and thus
activeDocumentLoader returns 0. Lacking any understanding of how this
can happen, we do this check here to avoid crashing.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):

TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10391159

12:47 AM Changeset in webkit [117230] by yosin@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Adding myself(yosin@chromium.org) to committers list

12:44 AM Changeset in webkit [117229] by Nikolas Zimmermann
  • 1 edit
    2 adds in trunk/LayoutTests

SVG TRef/Use NULL ptr
https://bugs.webkit.org/show_bug.cgi?id=78700

Add testcase covering a problem fixed in trunk.

  • svg/custom/bug78700-expected.txt: Added.
  • svg/custom/bug78700.svg: Added.
12:41 AM Changeset in webkit [117228] by pfeldman@chromium.org
  • 3 edits in branches/chromium/1132/Source/WebCore/inspector/front-end

Merge 116672 - Web Inspector: search title is shown beside the search field (not under) in the vertical mode.
https://bugs.webkit.org/show_bug.cgi?id=86120

Reviewed by Yury Semikhatsky.

This change makes search title render as placeholder at all times.
It also adjusts the size of the search field when navigation arrows appear.

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._createSearchNavigationButton):

  • inspector/front-end/inspector.css:

(#toolbar-search-item):
(.with-navigation-buttons #search):
(.toolbar-search-navigation-label):
(.with-navigation-buttons .toolbar-search-navigation-label):

  • inspector/front-end/inspector.html:

TBR=pfeldman@chromium.org
BUG=126550
Review URL: https://chromiumcodereview.appspot.com/10377162

12:36 AM Changeset in webkit [117227] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r117050.
http://trac.webkit.org/changeset/117050
https://bugs.webkit.org/show_bug.cgi?id=86587

"Some heap profiler tests started timing out" (Requested by
yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotFakeWorker):
(WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):

12:22 AM Changeset in webkit [117226] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r117206.
http://trac.webkit.org/changeset/117206
https://bugs.webkit.org/show_bug.cgi?id=86583

breaks chromium browser_tests (Requested by bashi1 on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::continueAfterContentPolicy):

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::create):

12:21 AM Changeset in webkit [117225] by Nikolas Zimmermann
  • 17 edits
    6 adds in trunk

REGRESSION(r105057): Infinite loop inside SVGTextLayoutEngine::currentLogicalCharacterMetrics
https://bugs.webkit.org/show_bug.cgi?id=83405

Reviewed by Darin Adler.

Source/WebCore:

Dynamically adding tspans carrying position information in the x/y/dx/dy/rotate lists is broken.
To avoid mistakes like this in future, simplify the calling code in RenderSVGInlineText and centralize
the management of all caches (text positioning element cache / metrics map / layout attributes) in
RenderSVGText. This avoids the hack in SVGRootInlineBox::computePerCharacterLayoutInformation() which
called textRoot->rebuildLayoutAttributes(), which was used to fix previous security issues with this code.
Instead correctly handle destruction of RenderSVGInlineText in RenderSVGText, keeping the m_layoutAttributes
synchronized with the current state of the render tree. Fixes highcharts problems.

Tests: svg/text/add-tspan-position-bug.html

svg/text/highcharts-assertion.html
svg/text/modify-tspan-position-bug.html

  • rendering/svg/RenderSVGBlock.h:

(RenderSVGBlock):

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::addChild):
(WebCore::RenderSVGInline::removeChild):

  • rendering/svg/RenderSVGInline.h:

(RenderSVGInline):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):

  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::RenderSVGText):
(WebCore::RenderSVGText::~RenderSVGText):
(WebCore::collectLayoutAttributes):
(WebCore::RenderSVGText::subtreeChildWasAdded):
(WebCore::findPreviousAndNextAttributes):
(WebCore::checkLayoutAttributesConsistency):
(WebCore::RenderSVGText::willBeDestroyed):
(WebCore::RenderSVGText::subtreeChildWillBeRemoved):
(WebCore::RenderSVGText::subtreeChildWasRemoved):
(WebCore::RenderSVGText::subtreeStyleDidChange):
(WebCore::RenderSVGText::subtreeTextDidChange):
(WebCore::updateFontInAllDescendants):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::RenderSVGText::removeChild):

  • rendering/svg/RenderSVGText.h:

(RenderSVGText):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::layoutChildren):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForWholeTree):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildCharacterDataMap):

  • rendering/svg/SVGTextLayoutAttributesBuilder.h:

(SVGTextLayoutAttributesBuilder):
(WebCore::SVGTextLayoutAttributesBuilder::numberOfTextPositioningElements):

  • svg/SVGAElement.cpp:
  • svg/SVGAElement.h:

(SVGAElement):

  • svg/SVGTextContentElement.cpp:
  • svg/SVGTextContentElement.h:

(SVGTextContentElement):

LayoutTests:

Add three new testcases covering the problem.

  • svg/text/add-tspan-position-bug-expected.html: Added.
  • svg/text/add-tspan-position-bug.html: Added.
  • svg/text/highcharts-assertion-expected.txt: Added.
  • svg/text/highcharts-assertion.html: Added.
  • svg/text/modify-tspan-position-bug-expected.html: Added.
  • svg/text/modify-tspan-position-bug.html: Added.

May 15, 2012:

11:45 PM Changeset in webkit [117224] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in Document::nodeChildrenWillBeRemoved.
https://bugs.webkit.org/show_bug.cgi?id=85247