Timeline
Jun 12, 2012:
- 11:50 PM Changeset in webkit [120165] by
-
- 17 edits in trunk
Unprefix Blob.webkitSlice
https://bugs.webkit.org/show_bug.cgi?id=78111
Reviewed by Adam Barth.
Source/WebCore:
Add unprefixed Blob.slice and start showing a deprecation message when webkitSlice is called.
No new tests: existing tests that call webkitSlice() are converted to slice(). They should keep running.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_blob_slice): Removed.
(webkit_dom_blob_webkit_slice): Added.
- fileapi/Blob.cpp:
(WebCore::Blob::slice):
(WebCore):
(WebCore::Blob::webkitSlice):
(WebCore::Blob::sliceInternal): Added.
- fileapi/Blob.h:
(WebCore):
(Blob):
- fileapi/Blob.idl:
LayoutTests:
Converted existing tests that are calling Blob.webkitSlice() to call slice().
- fast/files/blob-slice-overflow.html:
- fast/files/blob-slice-test.html:
- fast/files/resources/read-blob-test-cases.js:
(testReadingSlicedFileBlob):
(testReadingSlicedTextBlob):
(testReadingSlicedArrayBufferBlob):
(testReadingSlicedHybridBlob):
(testReadingTripleSlicedHybridBlob):
- fast/filesystem/resources/file-writer-utils.js:
(verifyByteRangeIsZeroesHelper):
- http/tests/local/blob/script-tests/send-hybrid-blob.js:
(runHybridBlobTest):
- http/tests/local/blob/script-tests/send-sliced-data-blob.js:
(runSliceTest):
- http/tests/local/fileapi/script-tests/send-sliced-dragged-file.js:
(onStableFileDrop):
(onUnstableFileDrop):
- http/tests/local/formdata/resources/send-form-data-common.js:
(testSendingFormData):
- inspector/profiler/heap-snapshot-loader.html:
- 11:33 PM Changeset in webkit [120164] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r120036.
http://trac.webkit.org/changeset/120036
https://bugs.webkit.org/show_bug.cgi?id=88965
"assert failed in debug build" (Requested by maryw on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-12
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyDataReceived):
- 11:01 PM Changeset in webkit [120163] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed morning gardening, skip new failing tests.
- platform/qt/Skipped:
- 10:39 PM Changeset in webkit [120162] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt][Mac] Unreviewed buildfix after r120076.
- WebCoreSupport/QTKitFullScreenVideoHandler.h:
- 10:19 PM Changeset in webkit [120161] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Roll chromium rev in DEPS
https://bugs.webkit.org/show_bug.cgi?id=88934
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-12
Reviewed by James Robinson.
Rolling to 141410
- DEPS:
- 10:00 PM Changeset in webkit [120160] by
-
- 2 edits in trunk/Source/WebCore
webcore should depend on webcore_arm_neon for only arm target_arch
https://bugs.webkit.org/show_bug.cgi?id=88839
Patch by Wei James <james.wei@intel.com> on 2012-06-12
Reviewed by Adam Barth.
- WebCore.gyp/WebCore.gyp:
- 9:56 PM Changeset in webkit [120159] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for ARMv7 debug builds.
- jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
- 9:50 PM Changeset in webkit [120158] by
-
- 6 edits2 adds in trunk
Can't set el.type on a <button> element
https://bugs.webkit.org/show_bug.cgi?id=14439
Patch by Edaena Salinas Jasso <edaena@apple.com> on 2012-06-12
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/dom/HTMLButtonElement/change-type.html
- bindings/objc/PublicDOMInterfaces.h:
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::setType): Added implementation of setType method.
(WebCore):
- html/HTMLButtonElement.h:
(HTMLButtonElement): Added setType method.
- html/HTMLButtonElement.idl: Removed readonly restriction to the type variable.
LayoutTests:
- fast/dom/HTMLButtonElement/change-type-expected.txt: Added.
- fast/dom/HTMLButtonElement/change-type.html: Added.
- 9:47 PM Changeset in webkit [120157] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: Update expectations for http/tests/media/media-source/webm/video-media-source-seek.html
This test has racy events (seeked and webkitsourceended) so is
flaky on Linux Dbg. Updated bug 85952 that is tracking flakiness
in these tests.
- platform/chromium/TestExpectations:
- 9:32 PM Changeset in webkit [120156] by
-
- 8 edits5 adds in trunk
[Chromium] Implement font shaping with font-feature-settings on Mac
https://bugs.webkit.org/show_bug.cgi?id=69826
Reviewed by Tony Chang.
Source/WebCore:
Add HarfBuzz-ng text shaper.
Chromium mac port uses it as secondary text shaper to support OpenType features.
HarfBuzz-ng is only used when -webkit-font-feature-settings is specified and
corresponding font is not an AAT font.
No new tests. css3/font-feature-settings-rendering.html should pass on Chromium mac port.
- WebCore.gyp/WebCore.gyp: Added harfbuzz-ng dependencies.
- WebCore.gypi: Added harfbuzz-ng files.
- platform/graphics/FontPlatformData.h:
(FontPlatformData): Added m_harfbuzzFace.
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::platformDataInit): Copy m_harfbuzzFace.
(WebCore::FontPlatformData::platformDataAssign): Ditto.
(WebCore):
(WebCore::isAATFont):
(WebCore::FontPlatformData::harfbuzzFace):
- platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp: Added.
(WebCore):
(WebCore::harfbuzzFaceCache):
(WebCore::HarfBuzzFace::HarfBuzzFace):
(WebCore::HarfBuzzFace::~HarfBuzzFace):
- platform/graphics/harfbuzz/ng/HarfBuzzFace.h: Added.
(WebCore):
(HarfBuzzFace):
(WebCore::HarfBuzzFace::create):
- platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp: Added.
(WebCore):
(WebCore::floatToHarfBuzzPosition):
(WebCore::getGlyph):
(WebCore::getGlyphHorizontalAdvance):
(WebCore::getGlyphHorizontalOrigin):
(WebCore::getGlyphExtents):
(WebCore::harfbuzzCoreTextGetFontFuncs):
(WebCore::releaseTableData):
(WebCore::harfbuzzCoreTextGetTable):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: Added.
(WebCore):
(WebCore::harfbuzzPositionToFloat):
(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions):
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::~HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setFontFeatures):
(WebCore::HarfBuzzShaper::shape):
(WebCore::HarfBuzzShaper::setupHarfBuzzRun):
(WebCore::HarfBuzzShaper::shapeHarfBuzzRun):
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun):
(WebCore::HarfBuzzShaper::offsetForPosition):
(WebCore::HarfBuzzShaper::selectionRect):
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.h: Added.
(WebCore):
(HarfBuzzShaper):
(WebCore::HarfBuzzShaper::totalWidth):
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setWidth):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numGlyphs):
(WebCore::HarfBuzzShaper::HarfBuzzRun::width):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore):
(WebCore::preferHarfBuzz): Added.
(WebCore::Font::selectionRectForComplexText): Use HarfBuzzShaper if font-feature-settings exists.
(WebCore::Font::drawComplexText): Ditto.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.
LayoutTests:
- platform/chromium/TestExpectations: Updated expectation of css3/font-feature-settings-rendering.html. The result need to be rebaselined.
- 8:39 PM Changeset in webkit [120155] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: Update expectations
fast/forms/datetimelocal/input-valueasdate-datetimelocal.html is
passing, so I expanded fast/forms/datetimelocal to TEXT failures
for all other tests. See bug 29359.
Likewise for
fast/forms/color/input-value-sanitization-color.html. See bug
88951.
fast/js/integer-division-neg2tothe32-by-neg1.html is passing on
Chromium WebKit waterfall, so updating CRASH to PASS CRASH. See
bug 81732.
- platform/chromium/TestExpectations:
- 8:31 PM Changeset in webkit [120154] by
-
- 27 edits2 adds in trunk/Source/WebCore
WIP: Implement CSS Variables Standard.
https://bugs.webkit.org/show_bug.cgi?id=85580
Reviewed by Ojan Vafai.
Implement CSS Variables Module Level 1. (See http://www.w3.org/TR/css-variables/)
A HashMap of properties is referenced by RenderStyle, and used to store variables as strings.
That HashMap is copy-on-write, and unless new variables are defined is simply a pointer to the
parent's definitions. At usage time the variable's value is parsed according to the CSS property
where it is used.
Variables can:
Define lists of values (ie. entire shorthand values).
Define individual values.
Refer to other variables. (Cycle detection is implemented).
Please see the supplied test cases for example usage.
Missing features:
CSS variables cannot yet be used inside some functions such as -webkit-calc.
Covered by existing test suite under fast/css/variables.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSGrammar.y:
- css/CSSParser.cpp:
(WebCore):
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::storeVariableDeclaration):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::lex):
- css/CSSParser.h:
(CSSParser):
- css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customSerializeResolvingVariables):
(WebCore):
- css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::isVariableName):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSValue.cpp:
(WebCore::CSSValue::serializeResolvingVariables):
(WebCore):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(CSSValue):
(WebCore::CSSValue::isVariableValue):
- css/CSSValueList.cpp:
(WebCore):
(WebCore::CSSValueList::customSerializeResolvingVariables):
- css/CSSValueList.h:
(CSSValueList):
- css/CSSVariableValue.h: Added.
(WebCore):
(CSSVariableValue):
(WebCore::CSSVariableValue::create):
(WebCore::CSSVariableValue::name):
(WebCore::CSSVariableValue::value):
(WebCore::CSSVariableValue::CSSVariableValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleResolver.h:
- css/WebKitCSSTransformValue.cpp:
(WebCore):
(WebCore::WebKitCSSTransformValue::customSerializeResolvingVariables):
- css/WebKitCSSTransformValue.h:
(WebKitCSSTransformValue):
- css/makeprop.pl:
- rendering/style/RenderStyle.h:
- rendering/style/StyleVariableData.h: Added.
(WebCore):
(StyleVariableData):
(WebCore::StyleVariableData::create):
(WebCore::StyleVariableData::copy):
(WebCore::StyleVariableData::operator==):
(WebCore::StyleVariableData::operator!=):
(WebCore::StyleVariableData::setVariable):
(WebCore::StyleVariableData::StyleVariableData):
- 8:23 PM Changeset in webkit [120153] by
-
- 2 edits in trunk/Source/WTF
Try to fix the build.
Maybe don't export inlined functions.
- wtf/ThreadingPrimitives.h:
(WTF::MutexTryLocker::MutexTryLocker):
(WTF::MutexTryLocker::~MutexTryLocker):
(WTF::MutexTryLocker::locked):
- 8:05 PM Changeset in webkit [120152] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: Update expectations for video-media-source-add-and-remove-ids.html
https://bugs.webkit.org/show_bug.cgi?id=88949
- platform/chromium/TestExpectations:
- 7:50 PM Changeset in webkit [120151] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix for case-sensitive file systems: use the right case.
- heap/ListableHandler.h:
- 7:37 PM Changeset in webkit [120150] by
-
- 2 edits in trunk/Tools
Wrap bot types inside ().
https://bugs.webkit.org/show_bug.cgi?id=88893
Reviewed by Stephanie Lewis.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 7:06 PM Changeset in webkit [120149] by
-
- 11 edits in trunk/Source/JavaScriptCore
GC should be 1.7X faster
https://bugs.webkit.org/show_bug.cgi?id=88840
Reviewed by Oliver Hunt.
I profiled, and removed anything that showed up as a concurrency
bottleneck. Then, I added 3 threads to our max thread count, since we
can scale up to more threads now.
- heap/BlockAllocator.cpp:
(JSC::BlockAllocator::BlockAllocator):
(JSC::BlockAllocator::~BlockAllocator):
(JSC::BlockAllocator::releaseFreeBlocks):
(JSC::BlockAllocator::waitForRelativeTimeWhileHoldingLock):
(JSC::BlockAllocator::waitForRelativeTime):
(JSC::BlockAllocator::blockFreeingThreadMain):
- heap/BlockAllocator.h:
(BlockAllocator):
(JSC::BlockAllocator::allocate):
(JSC::BlockAllocator::deallocate): Use a spin lock for the common case
where we're just popping a linked list. (A pthread mutex would sleep our
thread even if the lock were only contended for a microsecond.)
Scope the lock to avoid holding it while allocating VM, since that's a
slow activity and it doesn't modify any of our data structures.
We still use a pthread mutex to handle our condition variable since we
have to, and it's not a hot path.
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::doneFillingBlock):
- heap/CopiedSpace.h:
(JSC::CopiedSpace::CopiedSpace): Use a spin lock for the to space lock,
since it just guards linked list and hash table manipulation.
- heap/MarkStack.cpp:
(JSC::MarkStackSegmentAllocator::MarkStackSegmentAllocator):
(JSC::MarkStackSegmentAllocator::allocate):
(JSC::MarkStackSegmentAllocator::release):
(JSC::MarkStackSegmentAllocator::shrinkReserve): Use a spin lock, since
we're just managing a linked list.
(JSC::MarkStackArray::donateSomeCellsTo): Changed donation to be proportional
to our current stack size. This fixes cases where we used to donate too
much. Interestingly, donating too much was starving the donor (when it
ran out of work later) *and* the recipient (since it had to wait on a
long donation operation to complete before it could acquire the lock).
In the worst case, we're still guaranteed to donate N cells in roughly log N time.
This change also fixes cases where we used to donate too little, since
we would always keep a fixed minimum number of cells. In the worst case,
with N marking threads, would could have N large object graph roots in
our stack for the duration of GC, and scale to only 1 thread.
It's an interesting observation that a single object in the mark stack
might represent an arbitrarily large object graph -- and only the act
of marking can find out.
(JSC::MarkStackArray::stealSomeCellsFrom): Steal in proportion to idle
threads. Once again, this fixes cases where constants could cause us
to steal too much or too little.
(JSC::SlotVisitor::donateKnownParallel): Always wake up other threads
if they're idle. We can afford to do this because we're conservative
about when we donate.
(JSC::SlotVisitor::drainFromShared):
- heap/MarkStack.h:
(MarkStackSegmentAllocator):
(MarkStackArray):
(JSC):
- heap/SlotVisitor.h: Merged the "should I donate?" decision into a
single function, for simplicity.
- runtime/Options.cpp:
(minimumNumberOfScansBetweenRebalance): Reduced the delay before donation
a lot. We can afford to do this because, in the common case, donation is
a single branch that decides not to donate.
(cpusToUse): Use more CPUs now, since we scale better now.
- runtime/Options.h:
(Options): Removed now-unused variables.
- 6:29 PM Changeset in webkit [120148] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(120121): inspector tests crash in DFG
https://bugs.webkit.org/show_bug.cgi?id=88941
Reviewed by Geoffrey Garen.
The CFG simplifier has two different ways of fixing up GetLocal, Phantom, and Flush. If we've
already fixed up the node one way, we shouldn't try the other way. The reason why we shouldn't
is that the second way depends on the node referring to other nodes in the to-be-jettisoned
block. After fixup they potentially will refer to nodes in the block being merged to.
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
- 6:28 PM Changeset in webkit [120147] by
-
- 13 edits2 adds in trunk
Shadow Pseudo ID should be able to nest to point nested shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=62218
Reviewed by Dimitri Glazkov.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- updateSpecifiersWithElementName() didn't take nesting into account. tag history can contain selector entries which isn't marked as ShadowDescendant yet. such entry can be found by investigating isUnknownPseudoElement().
- SelectorChecker::checkSelector() was too strict. Unknown pseudo elements are essentially a kind of class or id in implementation perspective. For such, rejecting by missing elementStyle doesn't make sense: It isn't a pseudo but a real element for WebCore after all.
- Added Internals::setShadowPseudoId() to create a test harness whose DOM tree contains pseudo shadow ids.
Before this change, following selecdtor chain is created for "p::-shadow-child::-nested-shadow-child":
[both tag name and -shadow-id are set] <-(ShadowDescendant)- [-nested-shadow-id]
What we want, which is created by this change is:
[tag] <-(ShadowDescendant)- [-shadow-id is set] <-(ShadowdescenDant)- [-nested-shadow-id]
Test: fast/dom/shadow/shadow-nested-pseudo-id.html
- WebCore.exp.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::updateSpecifiersWithElementName):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
- testing/Internals.cpp:
(WebCore::Internals::setShadowPseudoId):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- fast/dom/shadow/shadow-nested-pseudo-id-expected.txt: Added.
- fast/dom/shadow/shadow-nested-pseudo-id.html: Added.
- 5:42 PM BuildingOnWindows edited by
- There is no directory called OpenSource. LayoutTests is just in the … (diff)
- 5:39 PM Changeset in webkit [120146] by
-
- 4 edits in trunk/LayoutTests
Chromium rebaselines after r120135. The new results are clearly more correct.
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
- 5:33 PM Changeset in webkit [120145] by
-
- 8 edits in trunk
[soup] Prevent setting or editing httpOnly cookies from JavaScript
https://bugs.webkit.org/show_bug.cgi?id=88760
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-12
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Prevent setting or overwriting httpOnly cookies from JavaScript.
Fix setCookies() so that it parses all the cookies and not just
the first one.
Test: http/tests/cookies/js-get-and-set-http-only-cookie.html
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::httpOnlyCookieExists):
(WebCore):
(WebCore::setCookies):
Tools:
Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
to v2.33.2 for both GTK and EFL ports.
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
LayoutTests:
Unskip http/tests/cookies/js-get-and-set-http-only-cookie.html for
both GTK and EFL ports now that that we don't allow overwriting
httpOnly cookies from JavaScript anymore.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 5:28 PM Changeset in webkit [120144] by
-
- 19 edits3 adds in trunk
[EFL] Enable SHADOW_DOM flag
https://bugs.webkit.org/show_bug.cgi?id=87732
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-12
Reviewed by Kentaro Hara.
.:
Enable SHADOW_DOM flag by default at compile time for EFL port.
- Source/autotools/symbols.filter: Fix GTK build by adding new symbol.
- Source/cmake/OptionsEfl.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
Test: fast/dom/shadow/shadow-root-innerHTML.html
- dom/ShadowRoot.idl: Add JSGenerateToJSObject extended attribute so
that the ShadowRoot properties are accessible on JS side.
- testing/Internals.idl: Fix SHADOW_DOM ifdef check.
Source/WebKit:
Add WebCore/bindings/generic to include directories so
that we can include RuntimeEnabledFeatures.h.
- CMakeLists.txt:
Source/WebKit/efl:
Add Ewk setting to toggle Shadow DOM support at runtime.
- ewk/ewk_settings.cpp:
(ewk_settings_shadow_dom_enable_get):
(ewk_settings_shadow_dom_enable_set):
- ewk/ewk_settings.h:
Tools:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
SHADOW_DOM by default in DRT.
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
Chromium and Mac ports.
(drtViewAdd):
- Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
at compile time for EFL port.
LayoutTests:
Unskip most of the test cases associated to Shadow DOM now that the
feature is enabled by default for EFL's DRT.
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- platform/efl/fast/dom/shadow/form-in-shadow-expected.txt: Added.
- platform/efl/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt: Added.
- 5:23 PM Changeset in webkit [120143] by
-
- 4 edits in trunk/Source
Dynamic hash table in DOMObjectHashTableMap is wrong in multiple threads
https://bugs.webkit.org/show_bug.cgi?id=87334
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Add a copy member function to JSC::HasTable. This function will copy all data
members except for *table* which contains thread specific data that prevents
up copying it. When you want to copy a JSC::HashTable that was constructed
on another thread you should call JSC::HashTable::copy().
- runtime/Lookup.h:
(JSC::HashTable::copy):
(HashTable):
Source/WebCore:
Adapt to JSC::HashTable::copy to avoid copy dynamic table member of a HashTable.
The dynamic table may be allocated on other thread and contains thread specific
identifiers. For example, a hash table of JSEntryArray was first initialized on a
worker thread, and then the user reloaded the page, another worker thread is
created due to reload, the dynamic allocated table in *staticTable* is specific
to the first worker thread which has died. If the user reload the page again,
the dynamic table will be freed and memory corruption will occur.
No functionalities changed, no new tests.
- bindings/js/DOMObjectHashTableMap.h:
(WebCore::DOMObjectHashTableMap::get):
- 5:10 PM Changeset in webkit [120142] by
-
- 8 edits in trunk/Source
[chromium] Port Canvas2DLayerBridge over to WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=88597
Patch by James Robinson <jamesr@chromium.org> on 2012-06-12
Reviewed by Adrienne Walker.
Source/Platform:
This adds two new APIs to WebExternalTextureLayer that are used by the accelerated 2d canvas path:
- willModifyTexture() is called to indicate that a system outside the compositor's control is about to modify
the texture backing the WebExternalTextureLayer. This indicates to the compositor that it needs to avoid
producing more frames using this texture until it can do a full commit - either by double buffering or
appropriate flow control.
- setRateLimitContext() is called to enable rate limiting for this texture. The rate limiting logic blocks if
too many invalidate() or invalidateRect() calls are made on the texture outside of the context of a
WebLayerTreeViewClient::updateAnimations() call to prevent a non-vsynced producer from getting too far ahead of
the compositor.
- chromium/public/WebExternalTextureLayer.h:
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebExternalTextureLayer):
Source/WebCore:
This converts Canvas2DLayerBridge to using public WebLayer API types instead of LayerChromium types.
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(AcceleratedDeviceContext):
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::skCanvas):
(WebCore::Canvas2DLayerBridge::prepareTexture):
(WebCore::Canvas2DLayerBridge::context):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
- platform/graphics/chromium/Canvas2DLayerBridge.h:
(WebCore):
(Canvas2DLayerBridge):
Source/WebKit/chromium:
Implementations for new WebExternalTextureLayer APIs, updates test.
- src/WebExternalTextureLayer.cpp:
(WebKit::WebExternalTextureLayer::willModifyTexture):
(WebKit):
(WebKit::WebExternalTextureLayer::setRateLimitContext):
- tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
- 5:04 PM Changeset in webkit [120141] by
-
- 4 edits in branches/safari-536-branch
Merged r119280 -> <rdar://problem/11620927>
- 5:01 PM Changeset in webkit [120140] by
-
- 2 edits in trunk/LayoutTests
Add some expecations to green the chromium tree while the bugs are resolved.
- platform/chromium/TestExpectations:
- 4:56 PM Changeset in webkit [120139] by
-
- 2 edits in branches/safari-536-branch/Source/WebKit2
Merged r119758 -> <rdar://problem/11430118>
- 4:40 PM Changeset in webkit [120138] by
-
- 1 edit13 moves in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=88928
[WK2] New http/tests/loading/* tests fail
There's some latent timing issue with WK2 tests that prevents us from getting the last load delegate callback
before finishing the test.
Fortunately for the sake of these tests the load delegate dumps are entirely irrelevant.
Moving them from http/tests/loading to http/tests/misc and getting new, cleaner results fixes this.
Rubberstamped by Darin Adler.
- http/tests/misc/embed-image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt.
- http/tests/misc/embed-image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/embed-image-load-outlives-gc-without-crashing.html.
- http/tests/misc/image-input-type-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt.
- http/tests/misc/image-input-type-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/image-input-type-outlives-gc-without-crashing.html.
- http/tests/misc/image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt.
- http/tests/misc/image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/image-load-outlives-gc-without-crashing.html.
- http/tests/misc/object-image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt.
- http/tests/misc/object-image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/object-image-load-outlives-gc-without-crashing.html.
- http/tests/misc/resources/slowimage.php: Renamed from LayoutTests/http/tests/loading/resources/slowimage.php.
- http/tests/misc/svg-image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt.
- http/tests/misc/svg-image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/svg-image-load-outlives-gc-without-crashing.html.
- http/tests/misc/video-poster-image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt.
- http/tests/misc/video-poster-image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/video-poster-image-load-outlives-gc-without-crashing.html.
- 4:16 PM Changeset in webkit [120137] by
-
- 4 edits3 adds in trunk
DFG should not ASSERT if you have a double use of a variable that is not revealed to be a double
until after CFG simplification
https://bugs.webkit.org/show_bug.cgi?id=88927
<rdar://problem/11513971>
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Speculation fixup needs to run if simplification did things, because simplification can change
predictions - particularly if you had a control flow path that stored weird things into a
variable, but that path got axed by the simplifier.
Running fixup in the fixpoint requires making it idempotent, which it previously wasn't. Only
one place needed to be changed, namely the un-MustGenerate-ion of ValueToInt32.
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
LayoutTests:
Reviewed by Geoffrey Garen.
- fast/js/dfg-double-use-of-post-simplification-double-prediction-expected.txt: Added.
- fast/js/dfg-double-use-of-post-simplification-double-prediction.html: Added.
- fast/js/script-tests/dfg-double-use-of-post-simplification-double-prediction.js: Added.
(foo):
- 4:07 PM Changeset in webkit [120136] by
-
- 3 edits in trunk/Source/WebCore
Fix packing in StyleBoxData for Windows.
https://bugs.webkit.org/show_bug.cgi?id=88858
Reviewed by Tony Chang.
MSVC doesn't pack bitfields if the types are mixed.
We can safely change the bool type to an unsigned so
the packing will happen. I have added a compile assert
for future regressions.
No new tests : we should not see any regressions.
- rendering/style/StyleBoxData.h:
- rendering/style/StyleBoxData.cpp:
(StyleBoxData):
- 4:04 PM Changeset in webkit [120135] by
-
- 11 edits in trunk/Source
[chromium] Paint scrollbars on WebKit thread and composite those textures
https://bugs.webkit.org/show_bug.cgi?id=88145
Reviewed by James Robinson.
Source/WebCore:
Scrollbars were previously painted and uploaded on the compositor
thread. This isn't possible to do for many scrollbar themes. This
patch changes ScrollbarLayerChromium to paint the scrollbar into two
parts: the thumb, and everything else. These are uploaded into
textures and synced over to the CCScrollbarImpl where they are
composited and drawn.
Mac and overlay scrollbars are still not enabled to have compositor
thread-updated scrollbars.
As a bonus, fix LayerRendererChromium::drawTextureQuad to draw quads
that do not fill the entire layer bounds.
Tested by existing layout and unit tests by removing the condition
that these scrollbar layers are only created when the threaded proxy
exists.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::scrollbarLayerDidChange):
- platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::thumbRect):
(WebCore):
- platform/ScrollbarThemeComposite.h:
(ScrollbarThemeComposite):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawTextureQuad):
- platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::theme):
(WebCore):
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(ScrollbarBackgroundPainter):
(WebCore::ScrollbarBackgroundPainter::create):
(WebCore::ScrollbarBackgroundPainter::paint):
(WebCore::ScrollbarBackgroundPainter::ScrollbarBackgroundPainter):
(ScrollbarThumbPainter):
(WebCore::ScrollbarThumbPainter::create):
(WebCore::ScrollbarThumbPainter::paint):
(WebCore::ScrollbarThumbPainter::ScrollbarThumbPainter):
(WebCore::ScrollbarLayerChromium::setLayerTreeHost):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
(WebCore::ScrollbarLayerChromium::updatePart):
(WebCore::ScrollbarLayerChromium::update):
- platform/graphics/chromium/ScrollbarLayerChromium.h:
(WebCore):
(ScrollbarLayerChromium):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(WebCore::CCScrollbarLayerImpl::setBackgroundTextureId):
(WebCore::CCScrollbarLayerImpl::setThumbTextureId):
(CCScrollbarLayerImpl):
Source/WebKit/chromium:
Remove scrollbarLayerLostContext test that no longer makes sense. The
compositor won't draw at all after a lost context if it has no
contents.
- tests/CCLayerTreeHostImplTest.cpp:
- 3:52 PM Changeset in webkit [120134] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash when rendering web page that's being destroyed
https://bugs.webkit.org/show_bug.cgi?id=88915
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-06-12
Reviewed by Rob Buis.
PR #164943
This was a null pointer dereference that happened when the compositor
was asked to render after being disconnected from its web page.
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
- 3:47 PM Changeset in webkit [120133] by
-
- 3 edits in trunk/Tools
WinLauncher should show loading errors
https://bugs.webkit.org/show_bug.cgi?id=80760
Patch by Ashod Nakashian <ashodnakashian@yahoo.com> on 2012-06-12
Reviewed by Brent Fulgham.
- WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
(WinLauncherWebHost::didFailProvisionalLoadWithError):
- WinLauncher/WinLauncher.h:
(WinLauncherWebHost::didFailProvisionalLoadWithError):
(WinLauncherWebHost):
- 3:39 PM Changeset in webkit [120132] by
-
- 4 edits2 adds in trunk
Replaced items in a flexbox should be coerced to display:block
https://bugs.webkit.org/show_bug.cgi?id=87068
Reviewed by Ojan Vafai.
Source/WebCore:
The flexbox spec lists HTML tags that should automatically be converted
to display:block when a flex child. It also says that atomic inline-level
children should become block (e.g., inline-table should be treated as table).
http://dev.w3.org/csswg/css3-flexbox/#flex-items
Test: css3/flexbox/flexitem.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
LayoutTests:
- css3/flexbox/flexitem-expected.txt: Added.
- css3/flexbox/flexitem.html: Added.
- css3/flexbox/resources/flexbox.js:
(checkExpectedValues):
- 3:36 PM Changeset in webkit [120131] by
-
- 20 edits7 adds in trunk
IndexedDB: ObjectStore/Index shouldn't hold reference to backing store
https://bugs.webkit.org/show_bug.cgi?id=83074
Reviewed by Tony Chang.
Source/WebCore:
We should be able to collect and close the leveldb backing store as soon as the database
connection is closed, but the IDBObjectStoreBackendImpl and IDBIndexBackendImpl were
holding RefPtrs, and those objects are kept alive by script references.
Replaced RefPtrs to the IDBBackingStore with pointers to the IDBDatabase. On the back end,
IDBDatabaseBackendImpl maintains a RefPtr to the IDBObjectStoreBackendImpl object, so
a raw pointer back is safe. On the front end, the IDBObjectStore maintains a RefPtr to
the IDBDatabase so script can navigate upwards. Ditto on both ends for the ObjectStore/Index
relationship. The frontend objects maintain RefPtrs to the backend objects, so the backend
objects and their owners are maintained as long as there's a script reference. To ensure
that all LevelDB objects are destructed in the right order, transactions indirectly track all
open cursors and ensure they are closed when the transaction finishes, and database closing
is explicitly prevented from occurring until transactions are complete.
Also made IDBDatabaseBackendImpl handle a null IDBFactoryBackendImpl pointer, for testing.
Tests: storage/indexeddb/database-close.html
storage/indexeddb/persistence.html
[Chromium] webkit_unit_tests --gtest_filter=IDBDatabaseBackendTest.BackingStoreRetention
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::close): Release LevelDB resources when closed to allow backing store to close.
- Modules/indexeddb/IDBCursorBackendImpl.h:
(WebCore):
- Modules/indexeddb/IDBDatabase.cpp: Ensure connection close deferred until all transactions are finished.
(WebCore::IDBDatabase::transactionCreated): Accounting.
(WebCore::IDBDatabase::transactionFinished): Accounting.
(WebCore::IDBDatabase::close):
(WebCore):
(WebCore::IDBDatabase::closeConnection):
- Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Track outstanding transactions for forced-close scenarios.
(WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStore): Don't pass in backing store reference.
(WebCore::IDBDatabaseBackendImpl::setVersion): Use transaction() for consistent accounting.
(WebCore::IDBDatabaseBackendImpl::transactionFinished): Accounting.
(WebCore::IDBDatabaseBackendImpl::transaction): Accounting.
(WebCore::IDBDatabaseBackendImpl::close): Unregister from factory when last connection is closed.
(WebCore::IDBDatabaseBackendImpl::loadObjectStores): Don't pass in backing store reference.
(WebCore::IDBDatabaseBackendImpl::removeObjectStoreFromMap):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(WebCore):
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::deleteDatabase): Don't hang on to deleted databases eternally.
- Modules/indexeddb/IDBFactoryBackendImpl.h: Backend map controls IDBDatabaseBackend lifetimes.
(IDBFactoryBackendImpl):
- Modules/indexeddb/IDBIndexBackendImpl.cpp: Don't hold backing store references.
(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
- Modules/indexeddb/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::create):
(IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::backingStore):
(WebCore::IDBIndexBackendImpl::databaseId):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Don't hold backing store references.
(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::create):
(IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::backingStore):
(WebCore::IDBObjectStoreBackendImpl::databaseId):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction): For IDBDatabase accounting, allow ref during ctor.
(WebCore::IDBTransaction::onAbort): Accounting.
(WebCore::IDBTransaction::onComplete): Accounting.
- Modules/indexeddb/IDBTransaction.h:
(WebCore::IDBTransaction::isVersionChange): Convenience function.
(IDBTransaction):
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort): Cleanup ordering to allow backing store to close.
(WebCore::IDBTransactionBackendImpl::commit): Cleanup ordering to allow backing store to close.
Source/WebKit/chromium:
- WebKit.gypi:
- tests/IDBDatabaseBackendTest.cpp: Added.
(WebCore):
(WebCore::TEST):
LayoutTests:
The storage/indexeddb/persistence.html test verifies http://webkit.org/b/88788 which
was revealed by this patch set. The storage/indexeddb/database-close.html test verifies
the precise database connection closing semantics defined in the IDB spec.
- storage/indexeddb/database-close-expected.txt: Added.
- storage/indexeddb/database-close.html: Added.
- storage/indexeddb/persistence-expected.txt: Added.
- storage/indexeddb/persistence.html: Added.
- storage/indexeddb/resources/database-close.js: Added.
(test):
(openConnection.request.onsuccess.request.onsuccess):
(openConnection.request.onsuccess):
(openConnection):
(openVersionChangeConnection.request2.onsuccess):
(openVersionChangeConnection):
(testClose.transactionCompleted):
(testClose.request.onsuccess):
(testClose):
- storage/indexeddb/resources/persistence.js: Added.
(test):
(openAndChangeVersion.request.onsuccess.request.onsuccess.trans.oncomplete):
(openAndChangeVersion.request.onsuccess.request.onsuccess):
(openAndChangeVersion.request.onsuccess):
- 3:19 PM Changeset in webkit [120130] by
-
- 2 edits3 adds in trunk/Tools
[EFL][WK2] Add MiniBrowserEfl.
https://bugs.webkit.org/show_bug.cgi?id=61850
Reviewed by Chang Shu.
Implement MiniBrowser for EFL.
- CMakeLists.txt:
- MiniBrowser/efl/CMakeLists.txt: Added.
- MiniBrowser/efl/main.c: Added.
(_MiniBrowser):
(main_signal_exit):
(on_ecore_evas_resize):
(browserCreate):
(main):
- 3:12 PM Changeset in webkit [120129] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Don't set visible layer rect in CCLayerTreeHost paint iteration
https://bugs.webkit.org/show_bug.cgi?id=88895
Reviewed by James Robinson.
We should only set visible layer rects during the recursion in
CClayerTreeHostCommon and not while we're painting. This is one last
straggling piece of code that never got moved.
Tested by existing mask-related layout tests.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateVisibleAndScissorRectsInternal):
- 3:02 PM Changeset in webkit [120128] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Set contentBounds() on impl layers in CCLayerTreeHostCommonTests
https://bugs.webkit.org/show_bug.cgi?id=88903
Reviewed by Adrienne Walker.
Without setting the contentBounds() on impl layers, the visibleLayerRect
will be wrong. This is not the case for main-thread layers, which most
of the tests in this file use. But this is a potential serious confusion
for future test implementors so I'd like to make it explicit now.
- tests/CCLayerTreeHostCommonTest.cpp:
- 2:57 PM Changeset in webkit [120127] by
-
- 4 edits in trunk/Source
[chromium] Return empty visibleLayerRect for layers with empty content bounds
https://bugs.webkit.org/show_bug.cgi?id=88901
Reviewed by Adrienne Walker.
Source/WebCore:
This change should only affect tests. Currently if you set up a
CCLayerImpl with some bounds, but don't set the contentBounds, then
they are empty by default. In this case the visibleLayerRect gets
set inappropriately to the layer's target surface contentRect which
in a completely different coordinate space.
Fixed up tests that were passing bogusly and failed after this change.
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateVisibleLayerRect):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
- 2:55 PM Changeset in webkit [120126] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviwed nightly gardening.
- platform/qt/Skipped:
- 2:46 PM Changeset in webkit [120125] by
-
- 4 edits in trunk/Source/WebCore
[chromium] ScrollingCoordinator::setScrollLayer should update scroll layer ids
https://bugs.webkit.org/show_bug.cgi?id=88882
Reviewed by James Robinson.
Tested manually, as scrollbar layers are currently only created when
threaded compositing is enabled and none of those layout tests trigger
this bug.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
- platform/graphics/chromium/ScrollbarLayerChromium.h:
(WebCore::ScrollbarLayerChromium::setScrollLayerId):
(ScrollbarLayerChromium):
- platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):
- 2:44 PM Changeset in webkit [120124] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Scale was incorrect when reloading a simple web page after initial load
https://bugs.webkit.org/show_bug.cgi?id=88889
Reviewed by Adam Treat.
Patch by Jacky Jiang <zhajiang@rim.com>
PR: 164442
When we were reloading a web page with the load type FrameLoadTypeSame
after the initial load, the first layout timer was fired after the load
Finished state, in which case the web page would have no chance to zoom
to the initial scale during the layout as it was only for load
Committed state. This patch takes care of it.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::layoutFinished):
(BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):
- 2:40 PM Changeset in webkit [120123] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviwed nightly gardening.
- platform/qt/Skipped: Remove rolled out tests.
- platform/qt/fast/multicol/span/clone-flexbox-expected.txt: Updated after r120100.
- 2:39 PM Changeset in webkit [120122] by
-
- 6 edits in trunk/Source
Source/WebCore: [chromium mac] Don't include things in subframeworks of
ApplicationServices.framework.
Subframeworks move around from SDK to SDK and OS release to OS
release, but just using the top-level umbrella framework guarantees
forward compatibility. When building for Chromium Mac, just #include
<ApplicationServices/ApplicationServices.h> instead of reaching in to
subframeworks.
https://bugs.webkit.org/show_bug.cgi?id=88569
Patch by Mark Mentovai <mark@chromium.org> on 2012-06-12
Reviewed by Stephen White.
No new tests.
- platform/graphics/GlyphBuffer.h:
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
- platform/graphics/skia/GraphicsContextSkia.cpp:
Source/WebKit/chromium: [chromium mac] Don't #include things in subframeworks of
ApplicationServices.framework.
#including the umbrella <ApplicatonServices/ApplicationServices.h>
exposed an ambiguous name, FontMetrics, that needs to be fully
qualified as WebCore::FontMetrics.
https://bugs.webkit.org/show_bug.cgi?id=88569
Patch by Mark Mentovai <mark@chromium.org> on 2012-06-12
Reviewed by Stephen White.
- src/WebFontImpl.cpp:
(WebKit::WebFontImpl::estimateTextBounds):
- 2:18 PM WebKit Team edited by
- (diff)
- 2:15 PM Changeset in webkit [120121] by
-
- 3 edits3 adds in trunk
REGRESSION (r119779): Javascript TypeError: 'undefined' is not an object
https://bugs.webkit.org/show_bug.cgi?id=88783
<rdar://problem/11640299>
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
If you don't keep alive the base of an object access over the various checks
you do for the prototype chain, you're going to have a bad time.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetById):
LayoutTests:
Reviewed by Geoffrey Garen.
- fast/js/dfg-proto-access-inline-osr-exit-expected.txt: Added.
- fast/js/dfg-proto-access-inline-osr-exit.html: Added.
- fast/js/script-tests/dfg-proto-access-inline-osr-exit.js: Added.
(foo):
(Thingy):
- 2:09 PM Changeset in webkit [120120] by
-
- 2 edits in trunk/Tools
Unreviewed. Update my email address in committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 2:08 PM Changeset in webkit [120119] by
-
- 10 edits8 adds in trunk
Apply animations and transitions for first-letter element
https://bugs.webkit.org/show_bug.cgi?id=85253
Source/WebCore:
Add animations and transitions support for the first-letter
pseudo element.
Instead of calling RenderOject::node() in the animations code,
now we need to call RenderObject::styledGeneratingNode() because
pseudo elements does not have a Node associated with the
RenderObject.
Initial patch by Simon Fraser
Reviewed by Simon Fraser.
Tests: animations/first-letter-animation.html
animations/first-letter-play-state.html
transitions/first-letter-color-transition.html
transitions/first-letter-transition.html
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::setAnimatableStyle):
(WebCore::RenderObject::styledGeneratingNode):
(WebCore):
- rendering/RenderObject.h:
(RenderObject):
LayoutTests:
Reviewed by Simon Fraser.
- animations/first-letter-animation-expected.txt: Added.
- animations/first-letter-animation.html: Added.
- animations/first-letter-play-state-expected.txt: Added.
- animations/first-letter-play-state.html: Added.
- transitions/first-letter-color-transition-expected.txt: Added.
- transitions/first-letter-color-transition.html: Added.
- transitions/first-letter-transition-expected.txt: Added.
- transitions/first-letter-transition.html: Added.
- 2:04 PM Changeset in webkit [120118] by
-
- 5 edits in trunk
Checking a radio button doesn't uncheck other buttons in the same group in some cases.
https://bugs.webkit.org/show_bug.cgi?id=88835
Reviewed by Ryosuke Niwa.
Source/WebCore:
This change fixes a bug that checking a radio button in a radio button
group in a form detached from a document tree doesn't uncheck another
checked radio button in the radio button group.
A radio button participates in a radio button group in the following
conditions:
- If it is owned by a form element regardless of the form is in a
document tree or not, or
- If it is not owned by any form elements and it is in a document tree.
A radio button group for the radio button is owned by the document.
For HTMLInputElement::removedFrom():
The old code always unregistered the radio button if it was removed from
the document tree. It was incorrect because we don't need to unregister
it if it has an owner form and the owner form is not changed by
removedFrom().
If the owner form is cleared by removedFrom(), willChangeForm()
unregisters the radio button. So what we should do in removedFrom() is
to unregister the radio button only if the radio button group is owned
by the document.
For HTMLInputElement::insertedInto():
The old code always registered the radio button if it is inserted into
the document tree. It was incorrect because we don't need to register it
if it has an owner form and the owner form is not changed by
insertedInto().
If the owner form is changed by insertedInto(), didChangeForm()
registers the radio button. So We should register the radio button only
if its radio button group will be owned by the document.
Test: Add test cases to fast/forms/radio/radio-group.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::insertedInto):
Register this to CheckedRadioButtons only if new group owner is Document.
(WebCore::HTMLInputElement::removedFrom):
Unregister this from CheckedRadioButtons only if old group owner was Document.
LayoutTests:
- fast/forms/radio/radio-group-expected.txt:
- fast/forms/radio/radio-group.html: Add test cases.
- 1:54 PM Changeset in webkit [120117] by
-
- 4 edits in trunk/Source
[chromium] REGRESSION(119769): Canvas2DLayerBridge may go away before its TextureLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=88910
Reviewed by Adrienne Walker.
Source/WebCore:
Unregister the bridge as its TextureLayerChromium client when going away.
Covered by new unit test in Canvas2DLayerBridgeTest.cpp.
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
Source/WebKit/chromium:
New unit test to verify that we can still update a TextureLayerChromium after the bridge owning it has gone
away.
- tests/Canvas2DLayerBridgeTest.cpp:
- 1:54 PM Changeset in webkit [120116] by
-
- 1 edit in branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand.cpp
Merge 119872
BUG=130927
Review URL: https://chromiumcodereview.appspot.com/10544115
- 1:50 PM Changeset in webkit [120115] by
-
- 5 edits in branches/chromium/1132/Source/WebCore/editing
Merge 119870
BUG=130722
Review URL: https://chromiumcodereview.appspot.com/10536125
- 1:45 PM Changeset in webkit [120114] by
-
- 18 edits in trunk
IndexedDB: Error codes, phase two
https://bugs.webkit.org/show_bug.cgi?id=88690
Patch by Alec Flett <alecflett@chromium.org> on 2012-06-12
Reviewed by Tony Chang.
Source/WebCore:
Update the next phase of IndexedDB error codes to match the spec.
This update is mostly focused on DATA_ERR vs CONSTRAINT_ERR.
Also moves some of the error checking for the transaction mode
into the frontend and replaces the backend checks with asserts, so that
we can consolidate error checking in one place.
This also removes a few FIXME's that are no longer true (about
I/O errors - the spec was updated and our implementation was
already correct)
No new tests, existing tests cover changed behavior.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::deleteFunction):
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::deleteFunction):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::clear):
- Modules/indexeddb/IDBTransaction.h:
(WebCore::IDBTransaction::enumMode):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
LayoutTests:
- storage/indexeddb/cursor-advance-expected.txt:
- storage/indexeddb/index-unique-expected.txt:
- storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
- storage/indexeddb/mozilla/index-prev-no-duplicate.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics-workers-expected.txt:
- storage/indexeddb/resources/cursor-advance.js:
(openSuccess):
(createObjectStore.trans.oncomplete):
(createObjectStore):
(populateObjectStore):
- storage/indexeddb/resources/index-unique.js:
(addMoreDataFailed):
- storage/indexeddb/resources/objectstore-basics.js:
(addAgainFailure):
- 1:38 PM Changeset in webkit [120113] by
-
- 2 edits in trunk/Tools
[EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
https://bugs.webkit.org/show_bug.cgi?id=84707
Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
use_lib64 variable is preconfigured to True by jhbuild.
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-12
Reviewed by Dirk Pranke.
- efl/jhbuildrc:
- 1:37 PM Changeset in webkit [120112] by
-
- 2 edits2 adds in trunk
Disable autoplay when user gesture is required for media playback
https://bugs.webkit.org/show_bug.cgi?id=88897
Patch by Min Qin <qinmin@google.com> on 2012-06-12
Reviewed by Adam Barth.
When user gesture is required for media playback, we should block autoplay.
Otherwise, people will use autoplay instead of video.play() to bypass the gesture requirement.
Test: media/no-autoplay-with-user-gesture-requirement.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setReadyState):
- 1:37 PM Changeset in webkit [120111] by
-
- 150 edits in trunk/LayoutTests
Use testRunner in accessibility tests instead of layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=88755
Reviewed by Tony Chang.
Replaced all instances of layoutTestController in accessibility tests by testRunner.
- accessibility/:
- platform/chromium/accessibility/:
- platform/gtk/accessibility/:
- platform/mac/accessibility/:
- platform/win/accessibility/:
- 1:27 PM Changeset in webkit [120110] by
-
- 2 edits in trunk/Tools
Add zlieber@chromium.org to contributors list
https://bugs.webkit.org/show_bug.cgi?id=88904
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 1:21 PM Changeset in webkit [120109] by
-
- 2 edits in trunk/Tools
Rename Apple bots to a standard convention.
https://bugs.webkit.org/show_bug.cgi?id=88893
Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
Reviewed by Simon Fraser.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 1:20 PM Changeset in webkit [120108] by
-
- 5 edits2 adds in trunk
HTML parser should yield more to improve perceived page load time
https://bugs.webkit.org/show_bug.cgi?id=86165
Source/WebCore:
Patch by Shrey Banga <banga@chromium.org> on 2012-06-12
Reviewed by Tony Gentilcore.
Test: fast/events/event-yield-timing.html
We want the parser to yield at least every 500ms to keep the page somewhat responsive and allow painting.
Since it would be too expensive to check the time after each token, the previous heuristic was to check every 4,096 tokens.
That works fine for most tokens, but a script may spend an arbitrary amount of time executing.
This patch fixes the issue by causing the parser to check the elapsed time immediately after executing a script.
- html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::checkForYieldBeforeScript):
- html/parser/HTMLParserScheduler.h:
(WebCore::PumpSession::PumpSession):
(PumpSession):
(WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
LayoutTests:
Added test for parser yield times after seeing a script
Patch by Shrey Banga <banga@chromium.org> on 2012-06-12
Reviewed by Tony Gentilcore.
- fast/parser/parser-yield-timing-expected.txt: Added.
- fast/parser/parser-yield-timing.html: Added.
- http/tests/loading/gmail-assert-on-load-expected.txt: The test was added
for an assert that failed on debug builds when an iframe removed itself
from its parent window after blocking for 1 second. In previous builds,
the destroyIt() function was called without yielding to the event loop,
which lead to didFailLoadWithError being called. The fix for bug 86165
ensures that we yield after executing the script, which leads to
didHandleOnloadEventsForFrame being called instead. This is the cause
of the change in output of the test. The test still successfully removes
the iframe and since no asserts fail in the debug build, we should consider
it as passing.
- 1:09 PM Changeset in webkit [120107] by
-
- 3 edits in trunk/LayoutTests
LayoutTests/http/tests/xmlhttprequest/origin-exact-matching.html is giving trouble due to too many redirects
https://bugs.webkit.org/show_bug.cgi?id=88896
Patch by Pablo Flouret <pablof@motorola.com> on 2012-06-12
Reviewed by Darin Adler.
The test was giving out "too many redirect" errors on GTK and EFL due to
using redirect-cors.php without an actual url to redirect.
Redirects are not actually tested in that test, a script that set the
Access-Control-Allow-Origin header to an arbitrary origin was needed and
redirect-cors.php was the only existing one that had the capability. The
infinite redirect thing was an unintended consequence.
Use resources/access-control-allow-lists.php to set the header instead.
- http/tests/xmlhttprequest/origin-exact-matching-expected.txt:
- http/tests/xmlhttprequest/resources/origin-exact-matching-iframe.html:
- 1:01 PM Changeset in webkit [120106] by
-
- 2 edits in trunk/LayoutTests
Update more expectations to match the state of the bots.
- platform/chromium/TestExpectations:
- 12:55 PM Changeset in webkit [120105] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Fix incorrect LayerChromium scroll position for RTL overflow pages
https://bugs.webkit.org/show_bug.cgi?id=88887
Reviewed by James Robinson.
The scroll position on layers needs to take into account the scroll
origin, since RTL pages start scrolled all the way to the right.
Otherwise, when scrolling left the scroll position incorrectly will go
negative, causing havok in scrollbar theme code that just assumes that
it's always scrolled all the way to the left.
Also, now that the scroll origin is passed into NCCH, handle
scrollOrigin.y() for layer adjusting. This is always zero in practice,
but it seemed awkward to just drop it and that assumption could always
change in the future.
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::paintContents):
- src/NonCompositedContentHost.h:
(NonCompositedContentHost):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateLayerTreeViewport):
- 12:47 PM Changeset in webkit [120104] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening after r120099, fix two incorrect text expectations.
- platform/gtk/TestExpectations:
- 12:17 PM Changeset in webkit [120103] by
-
- 3 edits in trunk/Source
[chromium] Don't crash in CCLayerIterator if the root layer doesn't have a render surface
https://bugs.webkit.org/show_bug.cgi?id=88886
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-06-12
Reviewed by James Robinson.
If we are iterating over a render render surface layer list where the
root layer does not have a render surface, fail gracefully instead of
crashing.
Tests: CCLayerIteratorTest.{emptyTree,rootLayerWithoutRenderSurface}
- platform/graphics/chromium/cc/CCLayerIterator.h:
(WebCore::CCLayerIterator::CCLayerIterator):
- 12:17 PM Changeset in webkit [120102] by
-
- 3 edits3 copies in branches/chromium/1132
Merge 119158
BUG=129191
Review URL: https://chromiumcodereview.appspot.com/10542126
- 12:07 PM Changeset in webkit [120101] by
-
- 1 edit4 copies in branches/chromium/1132
Merge 119914
BUG=121128
Review URL: https://chromiumcodereview.appspot.com/10533113
- 12:06 PM Changeset in webkit [120100] by
-
- 35 edits in trunk
Change default for flex-grow back to 0
https://bugs.webkit.org/show_bug.cgi?id=88443
Reviewed by Tony Chang.
Source/WebCore:
- rendering/style/RenderStyle.h:
LayoutTests:
- css3/flexbox/flex-algorithm.html:
- css3/flexbox/flex-order.html:
- css3/flexbox/flex-property-parsing-expected.txt:
- css3/flexbox/flex-property-parsing.html:
- 12:01 PM Changeset in webkit [120099] by
-
- 2 edits in trunk/LayoutTests
[Gtk] TestExpectations should remove use of FAIL expectations
https://bugs.webkit.org/show_bug.cgi?id=88894
Reviewed by Martin Robinson.
Remove FAIL expectation from Gtk's TestExpectations file, replacing it
with TEXT or IMAGE in case of reftests. That should suffice for now as the
buildbots don't run pixel tests at the moment.
- platform/gtk/TestExpectations:
- 11:52 AM Changeset in webkit [120098] by
-
- 1 edit in branches/chromium/1132/Source/WebCore/dom/Document.cpp
Merge 119439
BUG=131087
Review URL: https://chromiumcodereview.appspot.com/10537130
- 11:52 AM Changeset in webkit [120097] by
-
- 3 edits in trunk/LayoutTests
Separate RemoveID test cases.
https://bugs.webkit.org/show_bug.cgi?id=88798
Reviewed by Eric Carlson.
- http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt:
- http/tests/media/media-source/video-media-source-add-and-remove-ids.html:
- 11:24 AM Changeset in webkit [120096] by
-
- 4 edits13 adds in trunk
<rdar://problem/11593686> and https://bugs.webkit.org/show_bug.cgi?id=88683
Garbage collection of an <img> element can cause reentrant event dispatch.
Reviewed by Darin Adler.
Source/WebCore:
The most straightforward solution is for ImageLoader to keep its Element alive
with ref/deref any time the Image is actually loading.
ImageLoader should always do this for all Elements, and if those Elements want/need
different behavior for when they are detached then they need to manually stop their
loads.
Tests: http/tests/loading/embed-image-load-outlives-gc-without-crashing.html
http/tests/loading/image-input-type-outlives-gc-without-crashing.html
http/tests/loading/image-load-outlives-gc-without-crashing.html
http/tests/loading/object-image-load-outlives-gc-without-crashing.html
http/tests/loading/svg-image-load-outlives-gc-without-crashing.html
http/tests/loading/video-poster-image-load-outlives-gc-without-crashing.html
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::updatedHasPendingLoadEvent):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):
- loader/ImageLoader.h:
(ImageLoader):
LayoutTests:
New tests for all users of ImageLoader:
- http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt: Added.
- http/tests/loading/embed-image-load-outlives-gc-without-crashing.html: Added.
- http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt: Added.
- http/tests/loading/image-input-type-outlives-gc-without-crashing.html: Added.
- http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt: Added.
- http/tests/loading/image-load-outlives-gc-without-crashing.html: Added.
- http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt: Added.
- http/tests/loading/object-image-load-outlives-gc-without-crashing.html: Added.
- http/tests/loading/resources/slowimage.php: Added.
- http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt: Added.
- http/tests/loading/svg-image-load-outlives-gc-without-crashing.html: Added.
- http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt: Added.
- http/tests/loading/video-poster-image-load-outlives-gc-without-crashing.html: Added.
Shared sub resource for all of those tests:
- http/tests/loading/resources/slowimage.php: Added.
- 11:21 AM Changeset in webkit [120095] by
-
- 2 edits in trunk/LayoutTests
Update some tests to better match actual results on the bots.
- platform/chromium/TestExpectations:
- 11:07 AM Changeset in webkit [120094] by
-
- 6 edits in trunk/Source
[chromium] Make damage tracking more robust to early exits
https://bugs.webkit.org/show_bug.cgi?id=84803
Reviewed by James Robinson.
Source/WebCore:
All CCDamageTrackerTest unit tests updated;
One new unit test added:
CCDamageTrackerTest.verifyDamageAccumulatesUntilReset
Damage tracking inherently needs to be aware of all changes that
occur for every frame. Before this patch, anyone modifying details
of CCLayerTreeHostImpl and the drawing phases of the compositor
needed to be careful to avoid early exiting once draw is
initiated, otherwise running the risk of damage tracking's state
getting out-of-sync from actual changes. This patch makes the
damage tracker API more asynchronous-like, so that damage will
continue to accumulate until it is explicitly notified that
damaged areas have been drawn. This will allow more freedom in
designing and restructuing drawing code in the compositor, without
worrying as much about damage tracking getting out-of-sync.
- platform/graphics/chromium/cc/CCDamageTracker.h:
(WebCore::CCDamageTracker::didDrawDamagedArea):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::clearDamageForAllSurfaces):
(WebKitTests::TEST_F):
- 11:02 AM Changeset in webkit [120093] by
-
- 9 edits1 copy2 moves4 adds17 deletes in trunk
Make document.documentURI readonly from JavaScript
https://bugs.webkit.org/show_bug.cgi?id=65187
Patch by Mike West <mkwst@chromium.org> on 2012-06-12
Reviewed by Alexey Proskuryakov.
Source/WebCore:
The DOM4 working draft marks the documentURI attribute as read only
(http://www.w3.org/TR/dom/#document). Firefox has shipped with this
behavior since https://hg.mozilla.org/mozilla-central/rev/3bc751906409
landed in October 2011, IE9 doesn't support the property, and
Opera throws a NO_MODIFICATION_ALLOWED_ERR. This patch changes WebKit
to silently fail (matching Firefox's behavior) by setting the property
to readonly in the IDL.
Document::setDocumentURI and the m_documentURI property are retained
for compatibility with ObjC clients, and the readonly attribute is
ifdeffed out for ObjC.
This patch adds a single test to verify the behavior, and removes a
variety of tests that depended on the writable behavior. In particular,
potential security issues involving the document.baseURL property are
avoided completely as long as this property can't be changed.
Test: fast/dom/documenturi-readonly.html
- dom/Document.cpp:
(WebCore::Document::setDocumentURI):
Adds a comment explaining that the fallback is necessary only to
support ObjC, not for JS calls.
- dom/Document.cpp:
(WebCore::Document::updateBaseURL):
Ditto.
(Document):
- dom/Document.idl:
Add readonly to the attribute and drop null value when not in
LANGUAGE_OBJECTIVE_C.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
- TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
(-[SetDocumentURITest webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):
LayoutTests:
- dom/xhtml/level3/core/documentsetdocumenturi01-expected.txt: Removed.
- dom/xhtml/level3/core/documentsetdocumenturi01.xhtml-disabled: Renamed from LayoutTests/dom/xhtml/level3/core/documentsetdocumenturi01.xhtml.
- dom/xhtml/level3/core/documentsetdocumenturi02-expected.txt: Removed.
- dom/xhtml/level3/core/documentsetdocumenturi02.xhtml-disabled: Renamed from LayoutTests/dom/xhtml/level3/core/documentsetdocumenturi02.xhtml.
Disabling these two tests, because they write out documentURI which is a
file:URL dependent on a local path.
- dom/xhtml/level3/core/documentsetdocumenturi03-expected.txt:
- dom/xhtml/level3/core/nodegetbaseuri02-expected.txt:
Updating these two tests to match the new, read-only behavior.
- fast/dom/documenturi-affects-relative-paths-expected.txt: Removed.
- fast/dom/documenturi-affects-relative-paths.html: Removed.
- fast/dom/documenturi-assigned-junk-implies-baseuri-null-expected.txt: Removed.
- fast/dom/documenturi-assigned-junk-implies-baseuri-null.html: Removed.
- fast/dom/documenturi-assigned-junk-implies-relative-urls-do-not-resolve-expected.txt: Removed.
- fast/dom/documenturi-assigned-junk-implies-relative-urls-do-not-resolve.html: Removed.
- fast/dom/documenturi-can-hold-arbitrary-string-expected.txt: Removed.
- fast/dom/documenturi-can-hold-arbitrary-string.html: Removed.
Removing now-irrelevant tests.
- fast/dom/documenturi-readonly-expected.txt: Added.
- fast/dom/documenturi-readonly.html: Added.
Adding a test to verify that document.documentURI is read-only.
- http/tests/security/xss-DENIED-document-baseURI-javascript-expected.txt: Removed.
- http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces-expected.txt: Removed.
- http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces.html: Removed.
- http/tests/security/xss-DENIED-document-baseURI-javascript.html: Removed.
- platform/chromium/dom/xhtml/level3/core/nodegetbaseuri02-expected.txt: Added
Platform-specific result for Chromium, which doesn't set the
lineproperty on exceptions.
- storage/domstorage/events/documentURI-expected.txt: Removed.
- storage/domstorage/events/documentURI.html: Removed.
- storage/domstorage/events/script-tests/documentURI.js: Removed.
Removing now-irrelevant tests.
- 10:52 AM Changeset in webkit [120092] by
-
- 2 edits in trunk/Source/WebCore
Support !ENABLE(VIDEO) builds with horizontally layed out video controls.
https://bugs.webkit.org/show_bug.cgi?id=88881
Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-12
Reviewed by Csaba Osztrogonác.
No new tests as this is a regression from WK87835.
- html/shadow/SliderThumbElement.cpp:
(WebCore::hasVerticalAppearance):
Ifdef out video related functionality, since usesVerticalVolumeSlider
does not exist in that case.
- 10:28 AM Changeset in webkit [120091] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix crash in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=88808
Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-12
Reviewed by Antonio Gomes.
m_page is destroyed before InputHandler, so should move the call to destroy popup to chromeDestroyed().
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::chromeDestroyed():
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::~InputHandler):
- 10:11 AM Changeset in webkit [120090] by
-
- 3 edits2 copies in branches/safari-536-branch
Merged r119739 -> <rdar://problem/11616643>
- 10:08 AM Changeset in webkit [120089] by
-
- 3 edits3 copies in branches/safari-536-branch
Merged r119644 -> <rdar://problem/11575112>
- 10:05 AM Changeset in webkit [120088] by
-
- 2 edits in branches/safari-536-branch/Source/WebKit/mac
Merged r119543 -> <rdar://problem/11602601>
- 10:04 AM Changeset in webkit [120087] by
-
- 2 edits in branches/safari-536-branch/Source/WebKit/mac
Merged r119542 -> <rdar://problem/11602601>
- 9:57 AM Changeset in webkit [120086] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: allow clearing revision history.
https://bugs.webkit.org/show_bug.cgi?id=88847
Reviewed by Vsevolod Vlasov.
This change also renames "Revision history" to "Local modifications".
I intend to list modifications to all files in that view in the subsequent change.
- English.lproj/localizedStrings.js:
- inspector/front-end/Resource.js:
(WebInspector.Resource._clearResourceHistory):
- inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView.else.clearHistory):
(WebInspector.RevisionHistoryView):
(WebInspector.RevisionHistoryView.prototype._revisionAdded):
(WebInspector.RevisionHistoryTreeElement):
(WebInspector.RevisionHistoryTreeElement.prototype._createLine):
(WebInspector.RevisionHistoryTreeElement.prototype.allowRevert):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.appendApplicableItems):
- 9:44 AM Changeset in webkit [120085] by
-
- 8 edits1 add in trunk/Source/WebCore
Web Inspector: use jsdifflib for revision diff calculation.
https://bugs.webkit.org/show_bug.cgi?id=88791
Reviewed by Vsevolod Vlasov.
Present diff calculation is incomplete, it does not properly handle the following case:
[a, b, c, d, e, f, g, h] => [c, d, e, f, g, h, a, b]
We should not be implementing diff by ourselves. I imported jsdifflib from
https://github.com/cemerick/jsdifflib. It has BSD license that is compatible with WebKit.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryTreeElement.prototype.onexpand.step2):
(WebInspector.RevisionHistoryTreeElement.prototype.onexpand):
(WebInspector.RevisionHistoryTreeElement.prototype._createLine.appendLineNumber):
(WebInspector.RevisionHistoryTreeElement.prototype._createLine):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/externs.js:
(difflib.stringAsLines):
(difflib.SequenceMatcher):
(difflib.SequenceMatcher.prototype.get_opcodes):
- inspector/front-end/inspector.html:
- inspector/front-end/jsdifflib.js: Added.
(difflib.defaultJunkFunction):
(difflib.stripLinebreaks):
(difflib.stringAsLines):
(difflib.reduce):
(difflib.ntuplecomp):
(difflib.calculate_ratio):
(difflib.dictget):
(difflib.SequenceMatcher.this.set_seqs):
(difflib.SequenceMatcher.this.set_seq1):
(difflib.SequenceMatcher.this.set_seq2):
(difflib.SequenceMatcher.this.chain_b):
(difflib.SequenceMatcher.this.find_longest_match):
(difflib.SequenceMatcher.this.get_matching_blocks):
(difflib.SequenceMatcher.this.get_opcodes):
(difflib.SequenceMatcher.this.get_grouped_opcodes):
(difflib.SequenceMatcher.this.quick_ratio):
(difflib.SequenceMatcher.this.real_quick_ratio):
- inspector/front-end/revisionHistory.css:
(.revision-history-line-separator .webkit-line-number):
- 9:32 AM Changeset in webkit [120084] by
-
- 7 edits in trunk
[EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
https://bugs.webkit.org/show_bug.cgi?id=88715
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-12
Reviewed by Noam Rosenthal.
.:
Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
- Source/cmake/OptionsEfl.cmake:
- Source/cmakeconfig.h.cmake:
Tools:
Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Unskip fast/files/blob-builder-crash.html now that
LEGACY_WEBKIT_BLOB_BUILDER flag is enabled by default
on EFL port.
- platform/efl/Skipped:
- 9:28 AM Changeset in webkit [120083] by
-
- 2 edits in trunk/Tools
[Qt] Fix -Werror for the buildbots
https://bugs.webkit.org/show_bug.cgi?id=88223
Rubber-stamped by Tor Arne Vestbø.
Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
- qmake/mkspecs/features/unix/default_post.prf:
- 9:15 AM Changeset in webkit [120082] by
-
- 5 edits3 adds in trunk
[GStreamer] http/tests/media/video-buffered-range-contains-currentTime.html is failing
https://bugs.webkit.org/show_bug.cgi?id=87575
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-12
Reviewed by Philippe Normand.
Source/WebCore:
When EOS is reached in forward playback, the position does not necessarily
match the duration. This confuses HTMLMediaElement and causes the "ended"
event not to be fired. To avoid this, we synchronize position and duration
values in this case.
Test: http/tests/media/video-buffered-range-contains-currentTime.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
LayoutTests:
Unskip http/tests/media/video-buffered-range-contains-currentTime.html for both
GTK and EFL ports now that MediaPlayerPrivateGStreamer correctly reports EOS and
now that the "ended" event is properly fired.
- platform/efl/TestExpectations:
- platform/efl/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
- platform/gtk/TestExpectations:
- platform/gtk/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
- 8:34 AM Changeset in webkit [120081] by
-
- 8 edits in trunk/Source/WebCore
Refactor InputType::receiveDroppedFiles to take DragData
https://bugs.webkit.org/show_bug.cgi?id=88860
Reviewed by Kent Tamura.
So that we can centralize the file paths related code into FileInputType
and makes it easier to extract more data from DragData for
<input type=file> (like bug 88293 for directory drag-and-drop).
No new tests as this has no behavioral changes.
- html/FileInputType.cpp:
(WebCore::FileInputType::receiveDroppedFiles):
- html/FileInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::receiveDroppedFiles):
- html/HTMLInputElement.h:
- html/InputType.cpp:
(WebCore::InputType::receiveDroppedFiles):
- html/InputType.h:
- page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
- 8:29 AM Changeset in webkit [120080] by
-
- 3 edits in trunk/Source/WebCore
Generate -webkit-box-decoration-break property only when the feature is enabled
https://bugs.webkit.org/show_bug.cgi?id=88861
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-12
Reviewed by Alexis Menard.
Otherwise it will hit an assertion if the property is present on the
style but the feature disabled. Also fixes a compilation warning when
the feature is disabled.
- css/CSSPropertyNames.in:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- 8:11 AM Changeset in webkit [120079] by
-
- 2 edits in trunk/LayoutTests
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591
Reviewed by Martin Robinson.
Remove FAIL text expectations for sputnik tests that have been
consistently passing on all the Gtk builders.
- platform/gtk/TestExpectations:
- 8:10 AM Changeset in webkit [120078] by
-
- 2 edits in trunk/Source/WebCore
Tweaked the Mac export file a bit more, adding more-correct iOS cases.
Reviewed by David Kilzer.
- WebCore.exp.in: Rearrangement.
- 8:06 AM Changeset in webkit [120077] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix.
- UIProcess/qt/QtViewportHandler.cpp:
(WebKit::QtViewportHandler::initialRect):
- 8:04 AM Changeset in webkit [120076] by
-
- 7 edits in trunk/Source
Using extrernal ICU library on case unsensitive drives will not work
https://bugs.webkit.org/show_bug.cgi?id=70913
Reviewed by Csaba Osztrogonác.
Source/WebCore:
- platform/graphics/surfaces/GraphicsSurface.h:
Source/WebKit2:
- WebProcess/WebPage/UpdateAtlas.cpp:
Source/WTF:
Properly set the include path for the WTF module and for modules using it.
The path should include Source/WTF/wtf only when building WTF itself. Other
modules are expected to include the headers as #include <wtf/Header.h>, so
only add Source/WTF to their include path.
"unicode/utf8.h" should now then always reference to ICU in the include path
and "wtf/unicode/UTF8.h" reference to the WTF version.
This will work as long as WTF object files don't depend on ICU themselves.
Removed gobject, qt and unicode from the include path as those directories
don't exist anymore.
- WTF.pri:
- WTF.pro:
- 7:55 AM Changeset in webkit [120075] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Do not move/scale content while the user is interacting with it
https://bugs.webkit.org/show_bug.cgi?id=88872
Reviewed by Simon Hausmann.
Don't try moving content into valid bounds when the content
size changes and the user is interacting with the content.
Only apply the viewport initial scale after user interaction
has ended.
- UIProcess/qt/QtViewportHandler.cpp:
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportHandler::setInitialScaleIfNeeded):
(WebKit::QtViewportHandler::viewportAttributesChanged):
(WebKit::QtViewportHandler::pageContentsSizeChanged):
(WebKit::QtViewportHandler::initialRect):
(WebKit):
- UIProcess/qt/QtViewportHandler.h:
(QtViewportHandler):
- 7:51 AM Changeset in webkit [120074] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use a safer way to shrink JS memory usage
https://bugs.webkit.org/show_bug.cgi?id=88811
Patch by Yong Li <yoli@rim.com> on 2012-06-12
Reviewed by Antonio Gomes.
We should just make a GC request and JSC will check if it is safe to do anything.
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::clearMemoryCaches):
- 7:39 AM Changeset in webkit [120073] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Use TextureDrawQuad for video layer output when it produces a single GL texture
https://bugs.webkit.org/show_bug.cgi?id=88814
Reviewed by Adrienne Walker.
When a CCVideLayerImpl produces quads for a frame that is contained
in a single GL texture, then use the TextureDrawQuad instead of the
VideoDrawQuad. Moves the computation for the RGBA(software) and
NativeTexture (hardware) cases from LayerRendererChromium into
CCVideoLayerImpl, so it can embed these values in the TextureDrawQuad.
No new tests, behaviour should be the same.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
- 7:31 AM Changeset in webkit [120072] by
-
- 11 edits in trunk
Change the volume slider to horizontal rendering for Chrome video controls.
https://bugs.webkit.org/show_bug.cgi?id=87835
Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-12
Reviewed by Eric Carlson.
Source/WebCore:
No new tests - final patch in the Chrome controls update series will contain rebaselined tests.
The Chrome video controls are receiving a visual update. The volume slider is moved into
the controls with horizontal rendering, the volume slider container is removed. The visual
update itself is in a separate patch.
- css/mediaControlsChromium.css:
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
Removed relative positioning to render all controls elements equally in DOM order.
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
Removed absolute positioning to render all controls elements equally in DOM order.
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
Removed absolute positioning to render all controls elements equally in DOM order.
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
Removed volume slider container - it's not necessary any more.
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
Remove flexbox and introduce inline display to always display this field.
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
Removed absolute positioning to render all controls elements equally in DOM order.
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
Removed volume slider container - it's not necessary any more.
(WebCore::MediaControlRootElementChromium::create):
Appended the volume slider and the mute button directly to the panel, removed volume slider container.
(WebCore::MediaControlRootElementChromium::setMediaController):
Removed volume slider container.
(WebCore::MediaControlRootElementChromium::reportedError):
Removed volume slider container.
(WebCore::MediaControlRootElementChromium::showVolumeSlider):
Removed volume slider container.
- html/shadow/MediaControlRootElementChromium.h:
(WebCore):
(MediaControlRootElementChromium):
Removed volume slider container.
- html/shadow/SliderThumbElement.cpp:
(WebCore::hasVerticalAppearance):
Allow use of horizontal media volume slider.
(WebCore::RenderSliderThumb::layout):
Reuse hasVerticalAppearance function.
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaVolumeSlider):
Change line drawing from vertical to horizontal.
- rendering/RenderTheme.h:
(WebCore::RenderTheme::usesVerticalVolumeSlider):
Add usesVerticalVolumeSlider function to allow horizontal volume sliders.
- rendering/RenderThemeChromiumMac.h:
(WebCore::RenderThemeChromiumMac::usesVerticalVolumeSlider):
Add usesVerticalVolumeSlider function to allow horizontal volume sliders.
Add usesVerticalVolumeSlider function to allow horizontal volume sliders.
- rendering/RenderThemeChromiumSkia.h:
(WebCore::RenderThemeChromiumSkia::usesVerticalVolumeSlider):
Add usesVerticalVolumeSlider function to allow horizontal volume sliders.
LayoutTests:
The Chrome video controls are receiving a visual update. The volume slider is included into
the controls with horizontal rendering, the volume slider container is removed. The visual
update itself is in a separate patch.
- platform/chromium/TestExpectations:
Temporarily skip tests related to volume controls rendering for Chromium.
- 7:21 AM Changeset in webkit [120071] by
-
- 5 edits in trunk
[CSSRegions]NamedFlow::overset should return true when there's no region chain attached
https://bugs.webkit.org/show_bug.cgi?id=88515
The CSS Regions specifies that the "overset" attribute needs to return true if the content overflows, there's no region attached to the flow
or if the NamedFlow is in the NULL state:
http://www.w3.org/TR/css3-regions/#dom-named-flow-overset
Source/WebCore:
This patch updates WebKit's behavior in the last two situations to match the one in the spec.
Patch by Andrei Bucur <abucur@adobe.com> on 2012-06-12
Reviewed by Andreas Kling.
Test: fast/regions/webkit-named-flow-overset.html was updated
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::computeOverflowStateForRegions): If the last valid region is null, the flow has not region chain attached or it's in the NULL state.
LayoutTests:
The overset test was updated to cover the attribute value in case of a flow in the NULL state.
Patch by Andrei Bucur <abucur@adobe.com> on 2012-06-12
Reviewed by Andreas Kling.
- fast/regions/webkit-named-flow-overset-expected.txt:
- fast/regions/webkit-named-flow-overset.html:
- 6:58 AM Changeset in webkit [120070] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Provide context menu for deleting recorded profile on Profiles Panel
https://bugs.webkit.org/show_bug.cgi?id=88286
Added the context menu to delete the selected profile.
Patch by Rahul Tiwari <rahultiwari.cse.iitr@gmail.com> on 2012-06-12
Reviewed by Pavel Feldman.
No new tests required as UI related change
- English.lproj/localizedStrings.js: Removed property svn:mime-type.
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
- 6:52 AM Changeset in webkit [120069] by
-
- 2 edits in trunk/Source/WebCore
2012-06-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: removed svn:mime-type property from English.lproj/localizedStrings.js
- English.lproj/localizedStrings.js
- 6:45 AM Changeset in webkit [120068] by
-
- 3 edits in trunk/Source/WebCore
Tried to fix the notification-enabled build after r120044.
- notifications/NotificationController.cpp:
(WebCore::NotificationController::NotificationController):
(WebCore::NotificationController::create):
(WebCore::provideNotification):
- notifications/NotificationController.h:
(NotificationController):
- 6:40 AM Changeset in webkit [120067] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Skip test failing randomly in GTK bots after r120040.
- platform/gtk/TestExpectations:
- 6:33 AM Changeset in webkit [120066] by
-
- 2 edits in trunk/Source/WebCore
[Qt][Texmap] Falling leaves demo missing clipping.
https://bugs.webkit.org/show_bug.cgi?id=88704
The bug originated from begining native painting mode of QPainter after enabling
scissor test, because begining native painting mode disables scissor test.
Covered by existing compositing tests.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-12
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::beginPainting):
- 6:30 AM Changeset in webkit [120065] by
-
- 3 edits in trunk/Source/WebCore
[Qt][Win] Buildfix related to fromWinHBITMAP
https://bugs.webkit.org/show_bug.cgi?id=88863
Reviewed by Jocelyn Turcotte.
- platform/graphics/qt/GraphicsContextQt.cpp: Add qt_pixmapFromWinHBITMAP and HBitmapFormat enum.
(WebCore):
(WebCore::GraphicsContext::releaseWindowsContext):
- platform/graphics/qt/ImageQt.cpp:
(WebCore): Move qt_pixmapFromWinHBITMAP to outside of WebCore namespace. (Fix after r119924.)
- 6:19 AM Changeset in webkit [120064] by
-
- 3 edits in trunk
[CMake] Enabled CSS_BOX_DECORATION_BREAK by default
https://bugs.webkit.org/show_bug.cgi?id=88850
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-12
Reviewed by Alexis Menard.
Enabled it by default on CMake ports like in other ports.
This patch is a follow up to r120029.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- 5:51 AM Changeset in webkit [120063] by
-
- 2 edits in trunk/Tools
[REGRESSION][WTR] Build fail with werror after r120054
https://bugs.webkit.org/show_bug.cgi?id=88862
Reviewed by Csaba Osztrogonác.
Some static helpers become unused after counterValueForElementById
has moved to Internals. Let's remove them.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR):
- 5:28 AM Changeset in webkit [120062] by
-
- 7 edits2 adds in trunk
[Shadow DOM] <style> inside Shadow subtree should be scoped inside the subtree.
https://bugs.webkit.org/show_bug.cgi?id=87805
Source/WebCore:
Modified HTMLStyleElement to be treated as a scoped style independent
of its "scoped" attribute's value if HTMLStyleElement is in shadow
subtree. HTMLStyleElement has the following four cases talking about
"scoped" attribute and whether is in shadow subtree or not:
1, HTMLStyleElement is "scoped" and is in document tree,
2, HTMLStyleElement is "scoped" and is in shadow subtree,
3, HTMLStyleElement is not "scoped" and is in document tree, and
4, HTMLStyleElement is not "scoped" and is in shadow subtree.
The case 1 and 2 are not changed. This patch affected the case 4.
At the case 4, the HTMLStyleElement's scoping node is the shadow root.
This change is the first step for fixing style scope bug,
i.e. HTMLStyleElements in shadow subtree are applied to any element
in document tree.
Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-12
Reviewed by Dimitri Glazkov.
Test: fast/css/style-scoped/style-scoped-change-scoped-in-shadow.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::determineScope):
Modified to return a shadow root if a targeted stylesheet owner node is
not scoped but in some shadow DOM subtree.
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::parseAttribute):
Modified to use the below scopedAttributeChanged when a changed
attribute's name is "scoped".
(WebCore::HTMLStyleElement::scopedAttributeChanged):
Newly added. According to new scoped value and isInShadowTree,
add or remove style rules to/from scopedAuthorRules via
registerWithScopingNode or unregisterWithScopingNode.
(WebCore::HTMLStyleElement::registerWithScopingNode):
Added one boolean argument to determine whether HTMLStyleElement is
scoped or not. The reason why not using scoped() is the comment:
"We cannot rely on the scoped element already being present when this
method is invoked. Therefore we cannot rely on scoped()"
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
Changed the code for updating m_isRegisteredWithScopingNode. Now
set m_scopedStyleRegistrationState to be NotRegistered.
(WebCore::HTMLStyleElement::insertedInto):
Modified to invoke registerWithScopingNode when an element is not
scoped but in some shadow subtree.
(WebCore::HTMLStyleElement::removedFrom):
Modified to invoke unregisterWithScopingNode when an element is not
scoped but in some shadow subtree.
- html/HTMLStyleElement.h:
(HTMLStyleElement):
Modified the type of m_isRegisteredWithScopingNode from bool to
enum and renamed to m_scopedStyleRegistrationState. Now the member
variable keeps what HTMLStyleElement's scoping node is, i.e.
none (this means, not in shadow subtree and not scoped), shadow root or
parent node.
Added one new method scopedAttributeChanged's declaration and
modified the declaration of registerWithScopingNode.
LayoutTests:
Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-12
Reviewed by Dimitri Glazkov.
- fast/css/style-scoped/registering-shadowroot-expected.txt:
- fast/css/style-scoped/registering-shadowroot.html:
- fast/css/style-scoped/style-scoped-change-scoped-in-shadow-expected.txt: Added.
- fast/css/style-scoped/style-scoped-change-scoped-in-shadow.html: Added.
- 5:06 AM Changeset in webkit [120061] by
-
- 3 edits in trunk/Source/WebCore
Removing unused parameter Page
https://bugs.webkit.org/show_bug.cgi?id=88848
Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-12
Reviewed by Kentaro Hara.
Removed the unused parameter Page* supplied to the create function
and constructor in DeviceOrientationController.
The parameter Page* was previously stored in an instance variable
m_page, but this was removed (see https://bugs.webkit.org/show_bug.cgi?id=88812).
No new tests because the removed parameter was unused and untested.
- dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::DeviceOrientationController):
(WebCore::DeviceOrientationController::create):
(WebCore::provideDeviceOrientationTo):
- dom/DeviceOrientationController.h:
(DeviceOrientationController):
- 4:53 AM Changeset in webkit [120060] by
-
- 2 edits in trunk/Tools
[Qt] Slave losts cause build break on bots
https://bugs.webkit.org/show_bug.cgi?id=38980
Minor fix after r59261.
Reviewed by Tor Arne Vestbø.
- Scripts/build-webkit:
(unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
- 4:48 AM Changeset in webkit [120059] by
-
- 7 edits in trunk/LayoutTests
Unreviewed. Add reference to bug 88859 for test skipped in r120055.
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 4:30 AM Changeset in webkit [120058] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: Add expectations for speech-recognition-event-constructor
This looks like it was failing as it was added in r120053. Filed
bug 88856.
- platform/chromium/TestExpectations:
- 4:18 AM Changeset in webkit [120057] by
-
- 32 edits2 moves5 deletes in trunk
Unreviewed, rolling out r120051.
http://trac.webkit.org/changeset/120051
https://bugs.webkit.org/show_bug.cgi?id=88852
some tests are crashing (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-12
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/ContextEnabledFeatures.cpp: Renamed from Source/WebKit/chromium/src/ContextFeaturesClientImpl.cpp.
(WebCore):
(WebCore::ContextEnabledFeatures::shadowDOMEnabled):
(WebCore::ContextEnabledFeatures::styleScopedEnabled):
(WebCore::ContextEnabledFeatures::pagePopupEnabled):
- bindings/generic/ContextEnabledFeatures.h: Renamed from Source/WebKit/chromium/src/ContextFeaturesClientImpl.h.
(WebCore):
(ContextEnabledFeatures):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::determineScope):
- dom/ContextFeatures.cpp: Removed.
- dom/ContextFeatures.h: Removed.
- dom/DOMAllInOne.cpp:
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore):
(Document):
- dom/Position.cpp:
(WebCore::Position::Position):
(WebCore::Position::findParent):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection):
- dom/make_names.pl:
(printConstructorInterior):
(printFactoryCppFile):
(printWrapperFunctions):
(printWrapperFactoryCppFile):
- editing/markup.cpp:
(WebCore::createFragmentFromMarkupWithContext):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
- html/shadow/HTMLContentElement.cpp:
(WebCore::contentTagName):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::allowShadowDOM):
(WebCore::FrameLoaderClient::allowStyleScoped):
(FrameLoaderClient):
(WebCore::FrameLoaderClient::allowPagePopup):
- platform/RefCountedSupplement.h: Removed.
- platform/Supplementable.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseXML):
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebPermissionClient.h:
(WebKit::WebPermissionClient::allowWebComponents):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowShadowDOM):
(WebKit):
(WebKit::FrameLoaderClientImpl::allowStyleScoped):
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::initPage):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPermissionClient):
(WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
(WebKit):
LayoutTests:
- fast/dom/shadow/elements-in-frameless-document-expected.txt: Removed.
- fast/dom/shadow/elements-in-frameless-document.html: Removed.
- 4:09 AM Changeset in webkit [120056] by
-
- 7 edits2 deletes in trunk/LayoutTests
[Qt] Diverging test results on 32/64 bit architectures
https://bugs.webkit.org/show_bug.cgi?id=82601
Unreviewed gardening, update expected files.
- platform/qt/Skipped: Unskip svg/transforms/transform-origin-css-property.xhtml, because it passes now.
- platform/qt/fast/repaint/moving-shadow-on-container-expected.png:
- platform/qt/fast/repaint/moving-shadow-on-path-expected.png:
- platform/qt/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.png:
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/qt/svg/transforms/transform-origin-css-property-expected.png: Removed, because it is a reftest.
- platform/qt/svg/transforms/transform-origin-css-property-expected.txt: Removed, because it is a reftest.
- 4:05 AM Changeset in webkit [120055] by
-
- 7 edits in trunk/LayoutTests
Unreviewed; skipping the new XHR blob test on the platforms where XHR_RESPONSE_BLOB is not enabled.
http/tests/xmlhttprequest/response-blob-size.html
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 3:47 AM Changeset in webkit [120054] by
-
- 64 edits in trunk
[DRT] LTC:: counterValueForElementById() could be moved to Internals.
https://bugs.webkit.org/show_bug.cgi?id=84406
Reviewed by Hajime Morita.
.:
Exporting Internals::counterValueForElement symbols for the Gtk build.
- Source/autotools/symbols.filter:
Source/WebCore:
Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
Covered by existing test cases.
- testing/Internals.cpp:
(WebCore::Internals::counterValue):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/efl:
Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
Source/WebKit/gtk:
Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/qt:
Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp:
- WebFrame.h:
Source/WebKit2:
Exporting Internals::counterValueForElement symbols for the win build.
- win/WebKit2.def:
Tools:
Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setPOSIXLocale):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
LayoutTests:
Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
- fast/css/counters/2displays-expected.txt:
- fast/css/counters/2displays.html:
- fast/css/counters/adding-nodes.html:
- fast/css/counters/after-continuation-expected.txt:
- fast/css/counters/after-continuation.html:
- fast/css/counters/content-021-expected.txt:
- fast/css/counters/content-021.html:
- fast/css/counters/counter-before-content-not-incremented.html:
- fast/css/counters/counter-increment-000-expected.txt:
- fast/css/counters/counter-increment-000.html:
- fast/css/counters/counter-increment-001-expected.txt:
- fast/css/counters/counter-increment-001.html:
- fast/css/counters/counter-increment-002.html:
- fast/css/counters/counter-increment-inherit-expected.txt:
- fast/css/counters/counter-increment-inherit.htm:
- fast/css/counters/counter-increment-overflow.html:
- fast/css/counters/counter-increment-tests-expected.txt:
- fast/css/counters/counter-increment-tests.htm:
- fast/css/counters/counter-reset-000.html:
- fast/css/counters/counter-reset-001.html:
- fast/css/counters/counter-reset-002.html:
- fast/css/counters/counterValueForElementById-expected.txt:
- fast/css/counters/counterValueForElementById.html:
- fast/css/counters/deep-before-expected.txt:
- fast/css/counters/deep-before.html:
- fast/css/counters/invalidate-cached-counter-node.html:
- fast/css/counters/nesting.html:
- 3:38 AM Changeset in webkit [120053] by
-
- 15 edits2 adds in trunk
Speech JavaScript API: Make SpeechRecognitionError an Event
https://bugs.webkit.org/show_bug.cgi?id=88784
Reviewed by Adam Barth.
Source/WebCore:
Make SpeechRecognitionError an Event. The spec was updated to make it
an event in its own right, rather than an attribute of
SpeechRecognitionEvent.
Test: fast/speech/scripted/speechrecognition-errors.html
- Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::didReceiveError):
- Modules/speech/SpeechRecognitionError.cpp:
(WebCore::SpeechRecognitionError::SpeechRecognitionError):
(WebCore::SpeechRecognitionError::interfaceName):
(WebCore):
- Modules/speech/SpeechRecognitionError.h:
(WebCore::SpeechRecognitionError::create):
(SpeechRecognitionError):
- Modules/speech/SpeechRecognitionError.idl:
- Modules/speech/SpeechRecognitionEvent.cpp:
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):
- Modules/speech/SpeechRecognitionEvent.h:
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
- Modules/speech/SpeechRecognitionEvent.idl:
- dom/EventNames.in:
Tools:
Make it possible to have MockWebSpeechRecognizer fire error events.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setMockSpeechRecognitionError):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
(WebKit):
(ErrorTask):
(WebKit::ErrorTask::ErrorTask):
(MockWebSpeechRecognizer::addMockResult):
(MockWebSpeechRecognizer::setError):
- DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
(MockWebSpeechRecognizer):
LayoutTests:
Add a layout test that fires a SpeechRecognitionError.
- fast/speech/scripted/speechrecognition-errors-expected.txt: Added.
- fast/speech/scripted/speechrecognition-errors.html: Added.
- 3:13 AM Changeset in webkit [120052] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Skip test failing on GTK bots after r119947.
- platform/gtk/TestExpectations: Skip test.
- 2:49 AM Changeset in webkit [120051] by
-
- 32 edits1 copy2 moves4 adds in trunk
REGRESSION(r118098): <content> element does not render distributed children when cloned from another document
https://bugs.webkit.org/show_bug.cgi?id=88148
Source/WebCore:
Reviewed by Dimitri Glazkov.
The shadow DOM availability was decided through FrameLoaderClient.
But there are documents which don't have any associated frames, in
which any shadow DOM related elements cannot be constructed. That
resulsted the regression.
This change introduces a Page-based client called
ContextFeaturesClient which takes the role from FrameLoaderClient
to decide the feature availability, and ContextFeatures which is a
proxy of ContextFeaturesClient. ContextEnabledFeatures is is
replaced with ContextFeatures.
Each ContextFeatures object is owned by a Page, and is attached to
each Document in the page even if the page itself has no referenct
to Frames or Pages. With ContextFeatures, each Document can decide
the feature availability even if it cannot reach Page or Frame.
On RefCountedSupplement: Document instance can live longer than a
Page where it is shwon. This means that ContextFeatures instance
needs to survive after owner Page destruction because it's
referenced from possibly surviving Documents. RefCountedSupplement
is introduced to cover this scenario: It allows supplement classes
to live after Page's destruction.
RefCountedSupplement::hostDestroyed() is notified when the hosting
page is gone. ContextFeatures clears its reference to the client
using this notification.
Test: fast/dom/shadow/elements-in-frameless-document.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::determineScope):
- dom/ContextFeatures.cpp: Added.
(WebCore):
(WebCore::ContextFeaturesClient::empty):
(WebCore::ContextFeatures::supplementName):
(WebCore::ContextFeatures::defaultSwitch):
(WebCore::ContextFeatures::shadowDOMEnabled):
(WebCore::ContextFeatures::styleScopedEnabled):
(WebCore::ContextFeatures::pagePopupEnabled):
(WebCore::provideContextFeaturesTo):
(WebCore::provideContextFeaturesToDocumentFrom):
- dom/ContextFeatures.h: Added.
(WebCore):
(ContextFeatures):
(WebCore::ContextFeatures::ContextFeatures):
(WebCore::ContextFeatures::hostDestroyed):
(ContextFeaturesClient):
(WebCore::ContextFeaturesClient::~ContextFeaturesClient):
(WebCore::ContextFeaturesClient::isEnabled):
(WebCore::ContextFeatures::create):
(WebCore::ContextFeatures::isEnabled):
- dom/DOMAllInOne.cpp:
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):
- dom/Document.h:
(WebCore::Document::contextFeatures):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setContextFeatures):
- dom/Position.cpp:
(WebCore::Position::Position):
(WebCore::Position::findParent):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection):
- dom/make_names.pl:
(printConstructorInterior):
(printFactoryCppFile):
(printWrapperFunctions):
(printWrapperFactoryCppFile):
- editing/markup.cpp:
(WebCore::createFragmentFromMarkupWithContext):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
- html/shadow/HTMLContentElement.cpp:
(WebCore::contentTagName):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
- loader/FrameLoaderClient.h:
- platform/RefCountedSupplement.h: Copied from Source/WebCore/platform/Supplementable.h.
(WebCore):
(RefCountedSupplement):
(WebCore::RefCountedSupplement::hostDestroyed):
(Wrapper):
(WebCore::RefCountedSupplement::Wrapper::Wrapper):
(WebCore::RefCountedSupplement::Wrapper::~Wrapper):
(WebCore::RefCountedSupplement::Wrapper::wrapped):
(WebCore::RefCountedSupplement::provideTo):
(WebCore::RefCountedSupplement::from):
- platform/Supplementable.h:
(WebCore::Supplement::isRefCountedWrapper):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseXML):
Source/WebKit/chromium:
Reviewed by Dimitri Glazkov.
- Added ContextFeaturesClientImpl which implements WebCore::ContextFeaturesClient.
- Replaced PagePopupFrameLoaderClient with PagePopupFeaturesClient.
- WebKit.gyp:
- public/WebPermissionClient.h:
(WebKit):
(WebKit::WebPermissionClient::allowWebComponents):
- src/ContextFeaturesClientImpl.cpp: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.cpp.
(WebKit):
(WebKit::ContextFeaturesClientImpl::isEnabled):
- src/ContextFeaturesClientImpl.h: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.h.
(WebKit):
(ContextFeaturesClientImpl):
(WebKit::ContextFeaturesClientImpl::ContextFeaturesClientImpl):
(WebKit::ContextFeaturesClientImpl::setPermissionClient):
- src/FrameLoaderClientImpl.cpp:
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
- src/WebPagePopupImpl.cpp:
(PagePopupFeaturesClient):
(WebKit::PagePopupFeaturesClient::isEnabled):
(WebKit):
(WebKit::WebPagePopupImpl::initPage):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPermissionClient):
(WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
(WebKit):
LayoutTests:
Reviewed by Dimitri Glazkov.
- fast/dom/shadow/elements-in-frameless-document-expected.txt: Added.
- fast/dom/shadow/elements-in-frameless-document.html: Added.
- 2:21 AM Changeset in webkit [120050] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: Rebaseline gradient-after-transparent-border
Font antialiasing differences are causing this to fail after
rebaseline in r120043.
- platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.png:
- 2:10 AM Changeset in webkit [120049] by
-
- 16 edits2 adds in trunk
Remove unnecessary functions: setName() and formControlName()
https://bugs.webkit.org/show_bug.cgi?id=88392
Reviewed by Kentaro Hara.
Source/WebCore:
'name' IDL attributes of form-related elements should be [Reflected],
and we don't need to have setName(). We used formControlName() for
name() implementation, and formControlName() is not needed because it
just converts a null attribute to an empty string. Our binding code does it.
We don't remove FormAssociatedElement::name() because many C++ code use it.
FormAssociatedElement::name() is virtual, and HTMLInputElement overrides
it so that it returns a cache of the name attribtue value because
CheckedRadioButtons class needs to know an old name attribute value when
the name attribtue is changed.
References:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-object-name
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-form-name
http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#dom-fe-name
Test: fast/forms/name-attribute.html
- dom/Element.h: Remove formControlName().
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::name):
Copied from formControlName() implementation of HTMLFormControlElement.
- html/FormAssociatedElement.h:
(FormAssociatedElement): Make name() virtual, remove formControlName().
- html/FormController.cpp:
(WebCore::FormController::formElementsState):
Use name() instead of formControlName().
- html/HTMLFormControlElement.cpp:
Remove formControlName() and setName().
- html/HTMLFormControlElement.h: ditto.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::name): Renamed from formControlName().
- html/HTMLInputElement.h:
(HTMLInputElement): Renamed formControlName() to name(), and make it public.
- html/HTMLKeygenElement.idl: Make 'name' [Reflected].
- html/HTMLObjectElement.cpp: Remove formControlName().
- html/HTMLObjectElement.h: ditto.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::appendFormData):
Use name() instead of formControlName().
- html/HTMLSelectElement.idl: Make 'name' [Reflected].
- html/HTMLTextAreaElement.idl: Make 'name' [Reflected].
LayoutTests:
- fast/forms/name-attribute-expected.txt: Added.
- fast/forms/name-attribute.html: Added.
- 1:58 AM Changeset in webkit [120048] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Skip test crashing on GTK debug bots.
- platform/gtk/TestExpectations: Skip test.
- 1:32 AM FeatureFlags edited by
- Add CSS_BOX_DECORATION_BREAK (diff)
- 1:21 AM Changeset in webkit [120047] by
-
- 2 edits in trunk/LayoutTests
[Chromium] video-media-source-add-and-remove-ids.html needs to be skipped
until a chromium patch lands that will cause different expectations.
Unreviewed.
- platform/chromium/TestExpectations:
- 12:46 AM Changeset in webkit [120046] by
-
- 3 edits1 delete in trunk/LayoutTests
[Chromium] Unreviewed: Rebaseline gradients tests
Rebaseline two gradients tests after r120033 that I missed in
rebaselines in r120043.
- platform/chromium-linux-x86/fast/gradients/css3-radial-gradients2-expected.png: Removed.
- platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.png:
- platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.png:
- 12:08 AM Changeset in webkit [120045] by
-
- 5 edits in trunk
Property names of the built-in object cannot be retrieved
after trying to delete one of its properties
https://bugs.webkit.org/show_bug.cgi?id=86461
Patch by Hojong Han <hojong.han@samsung.com> on 2012-06-12
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::getClassPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
LayoutTests:
- fast/js/delete-syntax-expected.txt:
- fast/js/script-tests/delete-syntax.js:
Jun 11, 2012:
- 11:24 PM Changeset in webkit [120044] by
-
- 69 edits in trunk/Source
Remove unused member variables found by clang's -Wunused-private-field
https://bugs.webkit.org/show_bug.cgi?id=88812
Reviewed by Anders Carlsson.
Source/WebCore:
Change a few |class|s that were used only to pin down the size of
existing classes to |struct|, so that clang doesn't warn about these
memvars.
No intended behavior change.
- Modules/geolocation/GeolocationController.cpp:
(WebCore::GeolocationController::GeolocationController):
- Modules/geolocation/GeolocationController.h:
(GeolocationController):
- Modules/webaudio/AudioContext.h:
(AudioContext):
- Modules/webaudio/AudioParamTimeline.h:
(AudioParamTimeline):
- accessibility/AccessibilityScrollbar.h:
(AccessibilityScrollbar):
- bindings/v8/ScriptScope.cpp:
(WebCore::ScriptScope::ScriptScope):
- bindings/v8/ScriptScope.h:
(ScriptScope):
- css/CSSValue.cpp:
- css/StylePropertySet.cpp:
- dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::DeviceOrientationController):
- dom/DeviceOrientationController.h:
(DeviceOrientationController):
- editing/ReplaceSelectionCommand.cpp:
(ReplacementFragment):
(WebCore::ReplacementFragment::ReplacementFragment):
- editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
- editing/TextIterator.h:
(SimplifiedBackwardsTextIterator):
(BackwardsCharacterIterator):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
- html/HTMLFormCollection.h:
(HTMLFormCollection):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
- html/shadow/MediaControlElements.h:
(MediaControlFullscreenButtonElement):
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
- html/shadow/MediaControlRootElementChromium.h:
(MediaControlRootElementChromium):
- html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::LoadableTextTrack):
- html/track/LoadableTextTrack.h:
(LoadableTextTrack):
- inspector/CodeGeneratorInspector.py:
(Generator.go):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
- inspector/InspectorDOMDebuggerAgent.h:
(InspectorDOMDebuggerAgent):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
- notifications/NotificationController.cpp:
(WebCore::NotificationController::NotificationController):
- notifications/NotificationController.h:
(NotificationController):
- page/animation/CompositeAnimation.h:
(WebCore::CompositeAnimation::CompositeAnimation):
(CompositeAnimation):
- platform/Length.cpp:
- platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::ReverbConvolver):
- platform/audio/ReverbConvolver.h:
(ReverbConvolver):
- platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):
- platform/audio/ReverbConvolverStage.h:
(ReverbConvolverStage):
- platform/graphics/TextRun.cpp:
(ExpectedTextRunSize):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
- platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(JPEGImageReader):
- platform/leveldb/LevelDBTransaction.cpp:
(WebCore::LevelDBTransaction::TreeIterator::next):
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::TextCodecICU):
- platform/text/TextCodecICU.h:
(TextCodecICU):
- rendering/InlineBox.cpp:
- rendering/InlineFlowBox.cpp:
- rendering/RenderText.cpp:
- rendering/style/KeyframeList.h:
(WebCore::KeyframeList::KeyframeList):
(KeyframeList):
- rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::RenderSVGTextPath):
- rendering/svg/RenderSVGTextPath.h:
- rendering/svg/SVGInlineTextBox.cpp:
- svg/SVGPathByteStreamSource.cpp:
- svg/SVGPathByteStreamSource.h:
- svg/SVGPathTraversalStateBuilder.cpp:
(WebCore::SVGPathTraversalStateBuilder::SVGPathTraversalStateBuilder):
- svg/SVGPathTraversalStateBuilder.h:
(SVGPathTraversalStateBuilder):
- xml/XSLStyleSheet.h:
Source/WebKit/chromium:
- src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
- src/AudioDestinationChromium.h:
(AudioDestinationChromium):
- src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl):
- src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):
- src/WebFrameImpl.cpp:
(ChromePluginPrintContext):
- src/WebInputEvent.cpp:
- src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):
- src/WorkerAsyncFileWriterChromium.cpp:
(WebCore::WorkerAsyncFileWriterChromium::WorkerAsyncFileWriterChromium):
- src/WorkerAsyncFileWriterChromium.h:
(WorkerAsyncFileWriterChromium):
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestSetVisible::CCLayerTreeHostTestSetVisible):
(CCLayerTreeHostTestSetVisible):
- 11:22 PM Changeset in webkit [120043] by
-
- 30 edits1 copy2 adds5 deletes in trunk/LayoutTests
[Chromium] Unreviewed: Rebaseline gradients tests
r120033 added IMAGE failures for bunch of gradient tests that will
need rebaselining as a result of that change. This is that
rebaseline.
(File list elided because it is too long.)
- 11:17 PM Changeset in webkit [120042] by
-
- 3 edits2 adds in trunk
XHR returns size==0 Blob
https://bugs.webkit.org/show_bug.cgi?id=88750
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Response Blob's .size field must have the correct response size.
Test: http/tests/xmlhttprequest/response-blob-size.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseBlob):
LayoutTests:
- http/tests/xmlhttprequest/response-blob-size-expected.txt: Added.
- http/tests/xmlhttprequest/response-blob-size.html: Added.
- 11:03 PM Changeset in webkit [120041] by
-
- 2 edits in trunk/Source/WebKit2
[CMAKE][WK2] Make WebProcess target name more clear.
https://bugs.webkit.org/show_bug.cgi?id=88767
Reviewed by Ryosuke Niwa.
- CMakeLists.txt: Change WebProcess_NAME to WebProcess_EXECUTABLE_NAME.
- 10:40 PM Changeset in webkit [120040] by
-
- 10 edits in trunk
Introduce an Enclosure Element for Chromium video controls.
https://bugs.webkit.org/show_bug.cgi?id=87683
Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-11
Reviewed by Eric Carlson.
Source/WebCore:
Updated tests.
The Chrome video controls are receiving a visual update. A new enclosure div is required
to provide for a offset space from the video's boundaries. The visual update itself is in
a separate patch.
- css/mediaControlsChromium.css:
(video::-webkit-media-controls-enclosure):
Introduce CSS for enclosure div so it doesn't show yet.
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlChromiumEnclosureElement::MediaControlChromiumEnclosureElement):
Definition of the new enclosure element.
(WebCore::MediaControlChromiumEnclosureElement::create):
Definition of a create operator for the new enclosure element.
(WebCore::MediaControlChromiumEnclosureElement::shadowPseudoId):
Definition of the shadowPseudoId of -webkit-media-controls-enclosure for the enclosure div.
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
Initialize member element for enclosure div.
(WebCore::MediaControlRootElementChromium::create):
Instantiate enclosure div and add into DOM between controls and panel elements.
(WebCore::MediaControlRootElementChromium::setMediaController):
Set media controller for enclosure div.
(WebCore::MediaControlRootElementChromium::createTextTrackDisplay):
Insert text track display container to enclosure rather than panel.
- html/shadow/MediaControlRootElementChromium.h:
(WebCore):
(MediaControlChromiumEnclosureElement):
(WebCore::MediaControlChromiumEnclosureElement::setMediaController):
(WebCore::MediaControlChromiumEnclosureElement::mediaController):
(WebCore::MediaControlChromiumEnclosureElement::isMediaControlElement):
Add declaration of the new enclosure element and its member functions.
(MediaControlRootElementChromium):
Add member variable to controls root element to hold the enclosure element.
LayoutTests:
Change fullscreen/video-controls-override.html, media/media-controls-invalid-url.html and
media/track/track-cue-rendering-snap-to-lines-not-set.html to deal with the new enclosure
div in Chromium controls and use the mediaControlsElement() helper function to find elements
inside the controls.
Fail video controls tests in test expectations.
- fullscreen/video-controls-override-expected.txt: Updated.
- fullscreen/video-controls-override.html: Use mediaControlsElement helper function.
- media/media-controls-invalid-url.html: Use mediaControlsElement helper function.
- media/track/track-cue-rendering-snap-to-lines-not-set.html: Height is provided by enclosure element.
- platform/chromium/TestExpectations: Fail video controls tests.
- 10:32 PM Changeset in webkit [120039] by
-
- 3 edits in trunk/Tools
Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
https://bugs.webkit.org/show_bug.cgi?id=88836
Reviewed by Dirk Pranke.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
- 9:23 PM Changeset in webkit [120038] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: Expectations for track-cues-cuechange.html
https://bugs.webkit.org/show_bug.cgi?id=88833
media/track/track-cues-cuechange.html is timing out flakily like
some other media tests noted in bug 88833.
- platform/chromium/TestExpectations:
- 9:10 PM Changeset in webkit [120037] by
-
- 5 edits in trunk
WebKit doesn't allow replacing the document element with a DocumentFragment containing one element
https://bugs.webkit.org/show_bug.cgi?id=88681
Patch by Elliott Sprehn <Elliott Sprehn> on 2012-06-11
Reviewed by Ojan Vafai.
Source/WebCore:
Fix bug where replacing an immediate child of a Document with a DocumentFragment
would throw a HIERARCHY_REQUEST_ERR instead of replacing the node as required by DOM4.
http://www.w3.org/TR/domcore/#mutation-algorithms
- dom/Document.cpp:
(WebCore::Document::canReplaceChild):
When the newChild was a DocumentFragment we incorrectly
iterated over the document's children twice instead of the
fragment when counting the total number of elements and
doctypes to enfoce that there's only one of each.
LayoutTests:
Re-enables a bunch of disabled tests that are long since fixed and rewrites
the tests to use a more modern js-test-pre.js style.
https://bugs.webkit.org/show_bug.cgi?id=12751
- fast/dom/Document/replace-child-expected.txt:
- fast/dom/Document/replace-child.html:
- 8:46 PM Changeset in webkit [120036] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Add handling of notifyDataReceived in NetworkJob even there's no data inside
https://bugs.webkit.org/show_bug.cgi?id=88773
Reviewed by Rob Buis.
Handling notifyDataReceived event even if there is no data inside.
This event was critical because it gives downloadFilterStream a chance
to follow up NetworkStream close event, and it also make pluginView in
FrameLoaderBlackBerry return normal logic.
RIM PR# 164563
Reviewed internally by Leo Yang.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyDataReceived):
- 8:44 PM Changeset in webkit [120035] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Wrong mimetype for empty file link
https://bugs.webkit.org/show_bug.cgi?id=88642
Reviewed by Rob Buis.
RIM PR# 164164
For empty file link, we shouldn't give "application/octet-stream"
which will lead to download.
Reviewed internally by Charles Wei.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendResponseIfNeeded):
- 8:21 PM Changeset in webkit [120034] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: Update test expectations with bugs for media test timeouts
- platform/chromium/TestExpectations:
- 8:04 PM Changeset in webkit [120033] by
-
- 4 edits in trunk
GeneratorGeneratedImage should cache images for the non-tiled case
https://bugs.webkit.org/show_bug.cgi?id=87094
Patch by Jin Yang <jin.a.yang@intel.com> on 2012-06-11
Reviewed by Simon Fraser.
Source/WebCore:
We cache the generated image if generator is not changed. By compared
with generating image on the fly, it will lose a little pixel precision
and several layout tests should be rebaselined. With this patch, the IE test
drive benchmark "Bayou" can gain about 50%.
No new tests. Performance optimization.
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
LayoutTests:
Update expectations: added failures for baselines to come.
- platform/chromium/TestExpectations:
- 8:04 PM Changeset in webkit [120032] by
-
- 2 edits in trunk/Tools
[EFL] Remove CMakeCache.txt before building
https://bugs.webkit.org/show_bug.cgi?id=88717
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-11
Reviewed by Antonio Gomes.
Remove CMake cache file before every build to avoid using outdated
build flags when new features get enabled. This will avoid unexpected
failures on the bots due to outdated build flags.
- Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
- 8:02 PM Changeset in webkit [120031] by
-
- 15 edits in trunk
Add new Pointer Lock spec attribute webkitPointerLockElement.
https://bugs.webkit.org/show_bug.cgi?id=88799
Source/WebCore:
Reviewed by Dimitri Glazkov.
Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
New attribute webkitPointerLockElement added. Follow up patches
will remove the previous isLocked attribute. Tests updated to use
the new attribute.
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitPointerLockElementEnabled):
- dom/Document.cpp:
(WebCore):
(WebCore::Document::webkitPointerLockElement):
- dom/Document.h:
(Document):
- dom/Document.idl:
- page/PointerLockController.h:
(WebCore::PointerLockController::element):
Tools:
Reviewed by Dimitri Glazkov.
Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
New attribute webkitPointerLockElement added. Follow up patches
will remove the previous isLocked attribute. Tests updated to use
the new attribute.
WebViewHost logic required modification to correctly repond to
a lock, unlock, pointerLockElement call series. Specifically,
unlocking must be queued after a lock command is issued always
as the lock state may not be set yet with a lock request in flight.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
(WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
LayoutTests:
Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
New attribute webkitPointerLockElement added. Follow up patches
will remove the previous isLocked attribute. Tests updated to use
the new attribute.
Reviewed by Dimitri Glazkov.
- pointer-lock/lock-already-locked-expected.txt:
- pointer-lock/lock-already-locked.html:
- pointer-lock/pointer-lock-api-expected.txt:
- pointer-lock/pointer-lock-api.html:
- pointer-lock/pointerlocklost-event-expected.txt:
- pointer-lock/pointerlocklost-event.html:
- 7:51 PM Changeset in webkit [120030] by
-
- 7 edits in trunk/Source
Consolidate Pointer Lock runtime enabled flags to just one.
https://bugs.webkit.org/show_bug.cgi?id=88810
Reviewed by Dimitri Glazkov.
Source/WebCore:
No new tests.
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::pointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::setPointerLockEnabled):
- dom/MouseEvent.idl:
- page/Navigator.idl:
Source/WebKit/chromium:
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enablePointerLock):
(WebKit::WebRuntimeFeatures::isPointerLockEnabled):
- 7:21 PM Changeset in webkit [120029] by
-
- 26 edits in trunk
[CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
https://bugs.webkit.org/show_bug.cgi?id=88804
Reviewed by Tony Chang.
Protect box-decoration-break behind a feature flag enabled by default.
.:
- configure.ac:
Source/WebCore:
No new tests : no behavior change here.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- rendering/style/RenderStyle.h:
- rendering/style/StyleBoxData.cpp:
(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):
- rendering/style/StyleBoxData.h:
(StyleBoxData):
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 7:05 PM Changeset in webkit [120028] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: http/tests/xmlhttprequest/origin-exact-matching.html is timing out on XP about half the time
- platform/chromium/TestExpectations:
- 6:48 PM Changeset in webkit [120027] by
-
- 4 edits in trunk/LayoutTests
Unreviewed expected result update after r120017.
- platform/gtk/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
Rebaselined gtk.
- platform/efl/Skipped:
- platform/qt/Skipped:
Skipped the test with some explanation on those platforms as I couldn't get
the new baseline.
- 6:42 PM Changeset in webkit [120026] by
-
- 3 edits in trunk/LayoutTests
Updated expected results for this test after r120017.
- platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.png:
- platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
- 6:12 PM Changeset in webkit [120025] by
-
- 2 edits in trunk/LayoutTests
Added http/tests/security/mixedContent/blob-url-in-iframe.html back to the Mac skip list, as
it is still failing intermittently. <http://webkit.org/b/88736> will track this.
- platform/mac/Skipped:
- 6:09 PM FeatureFlags edited by
- Add CSS_IMAGE_RESOLUTION (diff)
- 5:58 PM Changeset in webkit [120024] by
-
- 7 edits in trunk
[CMAKE][EFL] Remove duplicated executable output path
https://bugs.webkit.org/show_bug.cgi?id=88765
Reviewed by Daniel Bates.
CMake files for EFL port have redefined executable output path. However, EFL port doesn't
need to define again because it is already defined in top-level CMake file.
Source/JavaScriptCore:
- shell/CMakeLists.txt:
Source/WebKit2:
- CMakeLists.txt:
Tools:
- DumpRenderTree/efl/CMakeLists.txt:
- EWebLauncher/CMakeLists.txt:
- 5:39 PM Changeset in webkit [120023] by
-
- 11 edits1 copy in trunk/Source
[chromium] Port DrawingBufferChromium from TextureLayerChromium over to WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=86273
Reviewed by Adrienne Walker.
Source/Platform:
- Platform.gypi:
- chromium/public/WebExternalTextureLayer.h:
(WebKit):
(WebExternalTextureLayer):
- chromium/public/WebExternalTextureLayerClient.h: Copied from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp.
(WebKit):
(WebTextureUpdater):
(WebKit::WebTextureUpdater::~WebTextureUpdater):
(WebExternalTextureLayerClient):
(WebKit::WebExternalTextureLayerClient::~WebExternalTextureLayerClient):
Source/WebCore:
This converts more WebCore code over to using public APIs instead of internal compositor layer types.
Refactor only, no change in behavior thus no new tests.
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):
- platform/graphics/chromium/TextureLayerChromium.cpp:
(WebCore::TextureLayerChromium::~TextureLayerChromium):
(WebCore::TextureLayerChromium::setRateLimitContext):
(WebCore::TextureLayerChromium::setNeedsDisplayRect):
(WebCore::TextureLayerChromium::update):
- platform/graphics/chromium/TextureLayerChromium.h:
(WebKit):
(TextureLayerChromiumClient):
Source/WebKit/chromium:
- src/WebExternalTextureLayer.cpp:
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebKit):
(WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::clearClient):
(WebKit::WebExternalTextureLayer::setOpaque):
(WebKit::WebExternalTextureLayer::setPremultipliedAlpha):
- 5:32 PM Changeset in webkit [120022] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Autofill feature implementation for BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=85577
Patch by Jonathan Dong <Jonathan Dong> on 2012-06-11
Reviewed by Rob Buis.
Remove the autofill saving procedure out of dispatchWillSubmitForm, this procedure
is same as the procedure in dispatchWillSendSubmitEvent.
Some sites will redirect to other url in its login process, which will cause the
user get notified to save credentials for this provisional redirecting url if we
put this saving procedure in dispatchWillSubmitForm. So we should remove it to make
sure we only save the autofill data before the submit event is fired.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
- 5:29 PM Changeset in webkit [120021] by
-
- 26 edits1 copy1 add in trunk
Pass the right color space over to the web process so we can set it on our CA context
https://bugs.webkit.org/show_bug.cgi?id=88819
<rdar://problem/11629050>
Reviewed by John Sullivan.
Source/WebKit2:
- Platform/mac/LayerHostingContext.h:
(LayerHostingContext):
- Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::createForWindowServer):
Use a single constructor and explicitly set up the parameters of the constructed object.
(WebKit::LayerHostingContext::setColorSpace):
(WebKit::LayerHostingContext::colorSpace):
Add getter and setter.
- Scripts/webkit2/messages.py:
(struct_or_class):
WebKit::ColorSpaceData is a struct.
- Shared/WebPageCreationParameters.cpp:
Encode and decode the color space parameter.
- Shared/WebPageCreationParameters.h:
Add the color space.
- Shared/mac/ColorSpaceData.h: Added.
- Shared/mac/ColorSpaceData.mm: Added.
Add a new class that represents a color space that can be sent over the wire.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::colorSpace):
Call through to the WKView.
- UIProcess/API/mac/WKView.mm:
(-[WKView _windowDidChangeBackingProperties:]):
Fix whitespace.
(-[WKView viewDidChangeBackingProperties]):
Check if our new color space is different from the current one and null the current one out if that is the case,
it will be reinitialized by the next call to -[WKView _colorSpace].
(-[WKView _colorSpace:]):
Compute the color space. If we're not in a window we'll get the main screen's color space.
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::colorSpaceDidChange):
Add empty stub.
- UIProcess/PageClient.h:
Add colorSpace getter.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
Initialize the color space.
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::colorSpaceDidChange):
Send the new color space over to the web process.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::colorSpace):
Call through to the page client.
- WebKit2.xcodeproj/project.pbxproj:
Add ColorSpaceData.h and ColorSpaceData.mm.
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingArea.messages.in:
Add SetColorSpace message.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Set the color space from the creation parameters.
(WebKit::TiledCoreAnimationDrawingArea::setColorSpace):
Set the color space on the layer hosting context.
(WebKit::TiledCoreAnimationDrawingArea::updateLayerHostingContext):
Make sure we apply the color space from the previous layer hosting context if one exists.
WebKitLibraries:
Add WKCAContextSetColorSpace and WKCAContextGetColorSpace.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 5:02 PM Changeset in webkit [120020] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Seek calls are being unnecessarily delayed
https://bugs.webkit.org/show_bug.cgi?id=88732
Patch by Max Feil <mfeil@rim.com> on 2012-06-11
Reviewed by Antonio Gomes.
There is a problem with the way the m_userDrivenSeekTimer is
implemented. When MediaPlayerPrivate::seek() is called, there
is always a 100ms delay even if the timer is not running. The
timer is supposed to space out (i.e. throttle) repeated seeks
that come in too soon after a previous seek, but currently it
is slowing down even single seeks and seeks that come in with
adequate delay after a previous seek. I fixed this in my patch
by improving the way the timer fired function is called.
A note on the new m_lastSeekTimePending flag: This flag is
needed so that userDrivenSeekTimerFired() knows whether or not
to perform the seek. The only case where this flag will not be
set is if no MediaPlayerPrivate::seek() call came in while the
timer was active, in which case it's important to do nothing.
I could encode this flag's information into the m_lastSeekTime
float, for example by initializing it and resetting it to NAN
and using isnan(). But I feel that using a separate bool is a
more portable approach.
No new tests. I would like to propose not including a layout test
with this fix. Doing timing tests for 100ms delays is tricky
from Javascript, and I don't think the benefit of such a test
outweighs the extra time it would take to develop one. The test
would also be a problem to maintain as it may give different
results over different runs and across different target hardware.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
- 4:48 PM Changeset in webkit [120019] by
-
- 4 edits in trunk/Tools
Don't consider show warnings in the garden-o-matic UI for non-layout test failures
https://bugs.webkit.org/show_bug.cgi?id=88816
Reviewed by Dirk Pranke.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
Expose a way to clear AsynchronousCaches.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
- 4:18 PM Changeset in webkit [120018] by
-
- 3 edits3 adds in trunk
[BlackBerry] Unexpected repeats of short media
https://bugs.webkit.org/show_bug.cgi?id=88733
Patch by Max Feil <mfeil@rim.com> on 2012-06-11
Reviewed by Antonio Gomes.
Source/WebCore:
The m_userDrivenSeekTimer is causing unwanted repeats of short
media such as sound effects because it is causing the current
time to not reflect that the media has finished playing.
This problem only affects media whose duration is close to
or less than the SeekSubmissionDelay, which is currently
set to 100ms. My fix is to ignore the userDrivenSeekTimer in
MediaPlayerPrivate::currentTime() if the duration of the media
is within twice the SeekSubmissionDelay. Seek drag smoothness
is a non-issue for such short media.
Test: platform/blackberry/media/short-media-repeats-correctly.html
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
LayoutTests:
Test for problem where short media repeats unintentionally.
- media/content/short.wav: Added.
- platform/blackberry/media/short-media-repeats-correctly-expected.txt: Added.
- platform/blackberry/media/short-media-repeats-correctly.html: Added.
- 4:14 PM Changeset in webkit [120017] by
-
- 3 edits8 adds in trunk
Account for margin after when laying out <legend> element
https://bugs.webkit.org/show_bug.cgi?id=35981
Reviewed by Abhishek Arya.
Source/WebCore:
Tests: fast/forms/legend-after-margin-horizontal-writing-mode.html
fast/forms/legend-after-margin-vertical-writing-mode.html
fast/forms/legend-after-margin-with-before-border-horizontal-mode.html
fast/forms/legend-small-after-margin-before-border-horizontal-mode.html
The existing code would ignore margin after when layouting out the <legend>. This
change only adds the code to handle the margin after, the margin before is still
ignored as it's not obvious how it should be working.
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::layoutSpecialExcludedChild):
Split the code in 2 code paths to reflect how we position and size. Those are covered by the
tests above.
LayoutTests:
- fast/forms/legend-after-margin-horizontal-writing-mode-expected.html: Added.
- fast/forms/legend-after-margin-horizontal-writing-mode.html: Added.
- fast/forms/legend-after-margin-vertical-writing-mode-expected.html: Added.
- fast/forms/legend-after-margin-vertical-writing-mode.html: Added.
- fast/forms/legend-after-margin-with-before-border-horizontal-mode-expected.html: Added.
- fast/forms/legend-after-margin-with-before-border-horizontal-mode.html: Added.
- fast/forms/legend-small-after-margin-before-border-horizontal-mode-expected.html: Added.
- fast/forms/legend-small-after-margin-before-border-horizontal-mode.html: Added.
- 4:12 PM Changeset in webkit [120016] by
-
- 6 edits in trunk/Source/WebCore
[chromium] Use WebGraphicsContext3D in rate limiting logic inside compositor
https://bugs.webkit.org/show_bug.cgi?id=86259
Reviewed by Adrienne Walker.
This refactors the compositor's rate limiting implementation to use the Platform API's WebGraphicsContext3D
directly instead of WebCore::GraphicsContext3D to cut down on the number of spurious WebCore dependencies in the
compositor. The one change in contract is that the caller to CCLayerTreeHost::startRateLimit() now has to call
CCLayerTreeHost::stopRateLimit() before allowing the referenced context to go away since CCLayerTreeHost no
longer retains a reference, but this was always happening already.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):
- platform/graphics/chromium/RateLimiter.cpp:
(WebCore::RateLimiter::create):
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::start):
(WebCore::RateLimiter::rateLimitContext):
- platform/graphics/chromium/RateLimiter.h:
(WebKit):
(RateLimiter):
- platform/graphics/chromium/TextureLayerChromium.cpp:
(WebCore::TextureLayerChromium::~TextureLayerChromium):
(WebCore::TextureLayerChromium::setRateLimitContext):
(WebCore::TextureLayerChromium::setNeedsDisplayRect):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::stopRateLimiter):
(WebCore::CCLayerTreeHost::rateLimit):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- 3:58 PM Changeset in webkit [120015] by
-
- 13 edits1 delete in trunk/Source
[chromium] Separate CCVideoDrawQuad and from the layer tree and video provider by removing ManagedTexture and WebVideoFrame pointers from the quad
https://bugs.webkit.org/show_bug.cgi?id=88363
Reviewed by Adrienne Walker.
Source/Platform:
- Platform.gypi:
- chromium/public/WebVideoFrame.h:
- chromium/src/WebVideoFrame.cpp: Removed.
Source/WebCore:
CCVideoDrawQuad should not contain any pointers to data in the layer
tree so we are able to serialize it across process boundaries. This
patch removes the ManagedTexture pointers from the quad class,
replacing them with texture ids. It removes the WebVideoFrame* from
the quad, replacing it with the frame provider's texture id included
in the WebVideoFrame structure. And it uses a WebTransformationMatrix
instead of a pointer to an array of floats.
Texture allocation is done in CCVideoLayerImpl via the
contentsTextureAllocator, so that the memory usage can be tracked.
We move the copyPlaneToTextures() method back from LayerRendererChromium
to CCVideoLayerImpl, as this method uses the texture data pointer in the
WebVideoFrame, and we do not want to give this pointer to the quad
class. Instead, this method makes use of the LayerTextureSubImage class
to copy the pixel data into the texture.
LayerTextureSubImage is updated to allow non-4byte texture formats.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::drawNativeTexture2D):
(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):
- platform/graphics/chromium/LayerTextureSubImage.cpp:
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
- platform/graphics/chromium/TextureCopier.cpp:
- platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
- platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::planes):
(WebCore::CCVideoDrawQuad::frameProviderTextureId):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):
(WebCore::CCVideoLayerImpl::FramePlane::allocateData):
(WebCore):
(WebCore::CCVideoLayerImpl::FramePlane::freeData):
(WebCore::CCVideoLayerImpl::allocatePlaneData):
(WebCore::CCVideoLayerImpl::copyPlaneData):
(WebCore::CCVideoLayerImpl::freePlaneData):
(WebCore::CCVideoLayerImpl::freeUnusedPlaneData):
(WebCore::CCVideoLayerImpl::didLoseContext):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(FramePlane):
(WebCore::CCVideoLayerImpl::FramePlane::FramePlane):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
- tests/CCTiledLayerTestCommon.h:
(WebKitTests::FakeTextureCopier::copyToTexture):
- tests/Canvas2DLayerChromiumTest.cpp:
- 3:41 PM Changeset in webkit [120014] by
-
- 4 edits in trunk/Source
IndexedDB: Object stores are not successfully deleted
https://bugs.webkit.org/show_bug.cgi?id=88788
Reviewed by Tony Chang.
Source/WebCore:
Discovered while working on http://webkit.org/b/83074 - object stores are not
being deleted from the backing store. Deletion would succeed in the in-memory
data structures, but after closing/re-opening the backing store the object store
(but not its indexes/data) would reappear. Due to 83074, this isn't detectable
by DRT without a full restart.
Test: [chromium] webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.ComparisonTest'
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
Source/WebKit/chromium:
- tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):
- 3:29 PM Changeset in webkit [120013] by
-
- 5 edits in trunk
Crash in fast/files/read tests during Garbage Collection
https://bugs.webkit.org/show_bug.cgi?id=87165
Reviewed by Michael Saboff
Source/WebCore:
Fix previous fix for hasPendingActivity, and fix a bug in a complex
abort case as well--abort during the final progress event of a write
would hang the writer.
- Modules/filesystem/FileWriter.cpp:
(WebCore::FileWriter::stop):
(WebCore::FileWriter::write):
(WebCore::FileWriter::truncate):
(WebCore::FileWriter::didWrite):
(WebCore::FileWriter::didTruncate):
(WebCore::FileWriter::didFail):
(WebCore::FileWriter::completeAbort):
(WebCore::FileWriter::doOperation):
(WebCore::FileWriter::signalCompletion):
LayoutTests:
Simplify file-writer-abort-continue.js a bit, and add a new test case
for a write that gets aborted in the final progress event, which
previously would have hung the FileWriter.
- fast/filesystem/file-writer-abort-continue-expected.txt:
- fast/filesystem/resources/file-writer-abort-continue.js:
- 3:16 PM Changeset in webkit [120012] by
-
- 5 edits in trunk
.: Replace obsolete mkdir_p variable with MKDIR_P
https://bugs.webkit.org/show_bug.cgi?id=88790
Patch by Arnaud Renevier <arno@renevier.net> on 2012-06-11
Reviewed by Martin Robinson.
- GNUmakefile.am:
- configure.ac:
Source/WebKit/gtk/po: Replace obsolete mkdir_p variables with MKDIR_P
https://bugs.webkit.org/show_bug.cgi?id=88790
Patch by Arnaud Renevier <arno@renevier.net> on 2012-06-11
Reviewed by Martin Robinson.
- GNUmakefile.am:
- 3:05 PM Changeset in webkit [120011] by
-
- 13 edits in trunk/LayoutTests
WebAudio tests need to set WebKitWebAudioEnabled.
https://bugs.webkit.org/show_bug.cgi?id=88624
Patch by Dongwoo Im <dw.im@samsung.com> on 2012-06-11
Reviewed by Chris Rogers.
- webaudio/audiochannelmerger-basic.html: Set WebKitWebAudioEnabled by including 'audio-testing.js'.
- webaudio/audionode-connect-order.html: ditto.
- webaudio/biquadfilternode-basic.html: ditto.
- webaudio/delaynode-maxdelay.html: ditto.
- webaudio/delaynode-scheduling.html: ditto.
- webaudio/delaynode.html: ditto.
- webaudio/javascriptaudionode-downmix8-2channel-input.html: ditto.
- webaudio/javascriptaudionode-upmix2-8channel-input.html: ditto.
- webaudio/mediaelementaudiosourcenode-gc.html: ditto.
- webaudio/mediaelementaudiosourcenode.html: ditto.
- webaudio/realtimeanalyser-fft-sizing.html: ditto.
- webaudio/stereo2mono-down-mixing.html: ditto.
- 3:04 PM Changeset in webkit [120010] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] [BlackBerry] browser video player fullscreen mode (portrait) does not play well with rotation
https://bugs.webkit.org/show_bug.cgi?id=88809
Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Adjust the media container dimensions, whenever the FrameView::frameRect
(aka viewport rect) changes
Reviewed internally by Jacky Jiang.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateViewportSize):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
- 3:03 PM Changeset in webkit [120009] by
-
- 2 edits in trunk/Source/WebKit/blackberry
browser video player fullscreen mode (portrait) does not play well with viewport metatag - Controls are off screen so cannot exit fullscreen https://bugs.webkit.org/show_bug.cgi?id=88719 PR #164026
Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Instead of using WebPage's viewport size, which suffers from
dealing with transformed coordinates, viewport metatag changes,
etc, lets use WebCore::FrameView's visibleContentRect::Size::Width,
which abstract all these variations.
It fixes an overscale issue we were having when video player entered
fullscreen, and webpage had viewport metatag set.
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
- 2:37 PM Changeset in webkit [120008] by
-
- 8 edits in trunk/Source
[chromium] Implement position:fixed in compositor thread
https://bugs.webkit.org/show_bug.cgi?id=70103
Reviewed by Adrienne Walker.
Source/WebCore:
Significant contributions to this patch by Alpha Lam and Sami Kyostila.
This patch is the compositor-side change that adds support for
fixed-position layers to be composited layers. Before this patch,
fixed-position elements were positioned only by WebCore (i.e. main
thread when painting), and the compositor did not have enough
knowledge on its own to position it properly. This patch adds the
necessary math and plumbs the necessary layer information so that
the impl thread can properly position fixed-position elements on
its own. This support is necessary for correctness of composited
fixed-position elements, which can greatly help to avoid
repainting container layers when scrolling with a fixed-position
layer.
There also needs to be WebCore-side support for this, which is
addressed in https://bugs.webkit.org/show_bug.cgi?id=78864
Unit tests added to CCLayerTreeHostCommonTest:
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDirectContainer
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithTransformedDirectContainer
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDistantContainer
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDistantContainerAndTransforms
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithMultipleScrollDeltas
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithIntermediateSurfaceAndTransforms
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithMultipleIntermediateSurfaces
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithContainerLayerThatHasSurface
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerThatIsAlsoFixedPositionContainer
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerThatHasNoContainer
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setIsContainerForFixedPositionLayers):
(WebCore::LayerChromium::isContainerForFixedPositionLayers):
(LayerChromium):
(WebCore::LayerChromium::setFixedToContainerLayerVisibleRect):
(WebCore::LayerChromium::fixedToContainerLayerVisibleRect):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setIsContainerForFixedPositionLayers):
(WebCore::CCLayerImpl::isContainerForFixedPositionLayers):
(CCLayerImpl):
(WebCore::CCLayerImpl::setFixedToContainerLayerVisibleRect):
(WebCore::CCLayerImpl::fixedToContainerLayerVisibleRect):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::computeScrollCompensationForThisLayer):
(WebCore):
(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):
Source/WebKit/chromium:
- tests/CCLayerTreeHostCommonTest.cpp:
- 2:17 PM Changeset in webkit [120007] by
-
- 2 edits in trunk/Tools
nrwt exits early too frequently
https://bugs.webkit.org/show_bug.cgi?id=73843
Reviewed by Ryosuke Niwa.
Change the defaults for new-run-webkit-tests for both
--exit-after-n-failures and --exit-after-n-crashes-or-timeouts
to zero (i.e., we will never exit early by default).
If people want their buildbots to exit early it is their
responsibility to update their buildbot configs appropriately.
Note that we have tests that ensure that these flags work for
non-zero numbers, but we don't have tests that either test the
default or ensure that zero means "run all of the tests". I
think that's okay but can add tests if others disagree.
Also note that it looks like no changes on the build.webkit.org
master.cfg are necessary; all of the bots seem to be using the
RunWebKitTests wrapper which is already setting the flags. There
is a NewRunWebKitTests wrapper, but that looks to be unused; I
will delete that in a separate patch.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 2:01 PM Changeset in webkit [120006] by
-
- 1 edit2 copies in branches/chromium/1132
Merge 119733
BUG=127185
TBR=raymes@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10540108
- 1:52 PM Changeset in webkit [120005] by
-
- 22 edits in trunk/Source
Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
https://bugs.webkit.org/show_bug.cgi?id=88723
Reviewed by Dan Bernstein.
Source/WebCore:
- WebCore.exp.in:
Update export.
- editing/Editor.cpp:
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
- editing/Editor.h:
(Editor):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- page/Frame.cpp:
(WebCore::Frame::Frame):
- page/Frame.h:
(Frame):
- page/FrameTree.cpp:
(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):
- page/FrameTree.h:
(FrameTree):
- page/Location.cpp:
(WebCore::Location::ancestorOrigins):
- xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::hasNoStyleInformation):
Update for the removal of disconnected frames and text search exclusions concepts.
Source/WebKit/blackberry:
- WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::scopeStringMatches):
Source/WebKit/mac:
- WebView/WebFrame.mm:
- WebView/WebFramePrivate.h:
Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:]
Source/WebKit/win:
- WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
Stop doing anything in these functions.
- 1:30 PM Changeset in webkit [120004] by
-
- 515 edits32 deletes in trunk/LayoutTests
Last large slew of Chromium windows png rebaselines. See http://crbug.com/131829 for more information.
List of rebaselined files excluded because it's too long.
- 1:22 PM Changeset in webkit [120003] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] WebInputEvent::isGestureEventType should return true for GestureTwoFingerTap
https://bugs.webkit.org/show_bug.cgi?id=88789
Patch by Varun Jain <varunjain@chromium.org> on 2012-06-11
Reviewed by Adam Barth.
- public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):
- 1:16 PM Changeset in webkit [120002] by
-
- 3 edits in trunk/Source/WebKit2
Crash when a plug-in tries to use the NPRuntime API with JavaScript disabled
https://bugs.webkit.org/show_bug.cgi?id=88797
<rdar://problem/11574844>
Reviewed by Brady Eidson.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::initialize):
Handle the windowNPObjectID being 0.
(WebKit::PluginControllerProxy::windowScriptNPObject):
Handle m_windownPObject being null.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowScriptNPObject):
Return null if JavaScript is disabled.
(WebKit::PluginView::pluginElementNPObject):
Ditto.
- 1:16 PM Changeset in webkit [120001] by
-
- 3 edits in trunk/Tools
[EFL] [DRT] Reset CacheModel before running each test
https://bugs.webkit.org/show_bug.cgi?id=87534
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-11
Reviewed by Gustavo Noronha Silva.
Reset cache model to default before running each test to fix some
flaky tests on EFL build bots. Also fix case value in setCacheModel.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setCacheModel):
- 1:15 PM Changeset in webkit [120000] by
-
- 15 edits2 adds in trunk
SVGImageCache leaks image data
https://bugs.webkit.org/show_bug.cgi?id=87792
Source/WebCore:
There are two functions to remove a client from a CachedImage:
- CachedResource::removeClient()
- CachedImage::removeClientForRenderer().
It's easy to make error to call the former which will leak the cached
image buffers in SVGImageCache.
This change combined the two by adding the virtual
CachedResource::didRemoveClient(). CachedImage will do SVGImageCache
cleanup in the function.
Reviewed by Nikolas Zimmermann.
Test: svg/as-image/svg-image-leak-cached-data.html
- loader/cache/CachedFont.h:
(WebCore::CachedFontClient::resourceClientType): Added 'const'.
- loader/cache/CachedImage.cpp:
(WebCore):
(WebCore::CachedImage::didRemoveClient): Removes the client from SVGImageCache.
(WebCore::CachedImage::lookupOrCreateImageForRenderer):
- loader/cache/CachedImage.h:
(CachedImage):
(WebCore::CachedImageClient::resourceClientType): Added 'const'.
- loader/cache/CachedRawResource.h:
(WebCore::CachedRawResourceClient::resourceClientType): Added 'const'.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::removeClient): Added invocation of didRemoveClient().
- loader/cache/CachedResource.h:
(WebCore::CachedResource::didRemoveClient): Added for subclasses to do additional works.
- loader/cache/CachedResourceClient.h:
(WebCore::CachedResourceClient::resourceClientType): Added 'const'.
- loader/cache/CachedSVGDocument.h:
(WebCore::CachedSVGDocumentClient::resourceClientType): Added 'const'.
- loader/cache/CachedStyleSheetClient.h:
(WebCore::CachedStyleSheetClient::resourceClientType): Added 'const'.
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::removeClient):
- rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::removeClient):
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::~SVGImageCache): Added checking for leaks.
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndScales):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForClient):
- svg/graphics/SVGImageCache.h:
(WebCore):
(SVGImageCache):
LayoutTests:
Reviewed by Nikolas Zimmermann.
New test case.
- svg/as-image/svg-image-leak-cached-data-expected.txt: Added.
- svg/as-image/svg-image-leak-cached-data.html: Added.
- 12:50 PM Changeset in webkit [119999] by
-
- 2 edits in trunk/Tools
[GTK] Memory leaks in DRT EventSender.cpp
https://bugs.webkit.org/show_bug.cgi?id=88774
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-11
Reviewed by Martin Robinson.
Fix a few possible memory leaks in EventSender code.
- DumpRenderTree/gtk/EventSender.cpp:
(contextClickCallback): Free the event returned by gdk_event_new().
(mouseDownCallback): Ditto.
(mouseUpCallback): Ditto.
- 12:45 PM Changeset in webkit [119998] by
-
- 4 edits in trunk
[EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
https://bugs.webkit.org/show_bug.cgi?id=88661
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-11
Reviewed by Dirk Pranke.
Tools:
Pass string length explicitly when creating String object from
non-null-terminated UChar* returned by characters().
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::pathToLocalResource):
LayoutTests:
Unskip test cases which rely on pathToLocalResource().
- platform/efl/TestExpectations:
- 11:54 AM Changeset in webkit [119997] by
-
- 5 edits in trunk/Source
[Chromium] Call shared timer functions directly
https://bugs.webkit.org/show_bug.cgi?id=88781
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/chromium/SharedTimerChromium.cpp:
(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireInterval):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 11:48 AM Changeset in webkit [119996] by
-
- 4 edits2 adds in trunk
Relative pos. input fields in columns vanish when you start typing in them
https://bugs.webkit.org/show_bug.cgi?id=76834
Patch by Pravin D <pravind.2k4@gmail.com> on 2012-06-11
Reviewed by Julien Chaffraix.
Source/WebCore:
Test: fast/multicol/multicol-with-child-renderLayer-for-input.html
- page/FrameView.cpp:
(WebCore::updateLayerPositionFlags):
Helper function to prepare the UpdateLayerPositionsFlags based on the input parameters.
If didFullRepaint flag is set, then CheckForRepaints flag is removed from the default flags.
Also during a relayout of a subtree, if the RenderLayer of the subtree root is paginated then updatePagination flag is
included in the flags.
(WebCore):
(WebCore::FrameView::layout):
Now uses the helper function updateLayerPositionFlags() to get the final set of UpdateLayerPositionsFlags.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::isPaginated):
(RenderLayer):
isPaginated function is made public so that FrameView class can use it prepare UpdateLayerPositionsFlags.
LayoutTests:
- fast/multicol/multicol-with-child-renderLayer-for-input-expected.html: Added.
- fast/multicol/multicol-with-child-renderLayer-for-input.html: Added.
- 11:37 AM Changeset in webkit [119995] by
-
- 15 edits3 copies in branches/chromium/1132
Merge 119742 - Plumb CORS attribute information from HTMLMediaElement to media players so it can be used
https://bugs.webkit.org/show_bug.cgi?id=88349
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/video-cross-origin-readback.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerCORSMode):
(WebCore):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::wouldTaintOrigin):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::didPassCORSAccessCheck):
(WebCore):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerCORSMode):
(MediaPlayer):
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::didPassCORSAccessCheck):
(MediaPlayerPrivateInterface):
Source/WebKit/chromium:
- public/WebMediaPlayer.h:
(WebMediaPlayer):
- src/AssertMatchingEnums.cpp:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::didPassCORSAccessCheck):
(WebKit):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
LayoutTests:
- http/tests/security/resources/video-cross-origin-allow.php: Added.
- http/tests/security/video-cross-origin-readback-expected.txt: Added.
- http/tests/security/video-cross-origin-readback.html: Added.
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wk2/Skipped:
TBR=fischman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10536097
- 11:36 AM Changeset in webkit [119994] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Remove some dead code in PasteboardChromium
https://bugs.webkit.org/show_bug.cgi?id=88782
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Leftover detritus from bug 88038.
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
- 11:35 AM Changeset in webkit [119993] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Removing long WebDeviceOrientation constructor
https://bugs.webkit.org/show_bug.cgi?id=88779
Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-11
Reviewed by Adam Barth.
Removing the WebDeviceOrientation constructor with nine parameters.
Chromium has been changed to use the default constructor and setter
functions instead (see https://chromiumcodereview.appspot.com/10542025/).
- public/WebDeviceOrientation.h:
- 11:29 AM Changeset in webkit [119992] by
-
- 273 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in compositing tests
https://bugs.webkit.org/show_bug.cgi?id=88766
Reviewed by Tony Chang.
- compositing/:
- compositing/animation/:
- compositing/backface-visibility/:
- compositing/backing/:
- compositing/culling/:
- compositing/geometry/:
- compositing/iframes/:
- compositing/iframes/resources/:
- compositing/images/:
- compositing/layer-creation/:
- compositing/masks/:
- compositing/overflow/:
- compositing/plugins/:
- compositing/reflections/:
- compositing/repaint/:
- compositing/resources/:
- compositing/rtl/:
- compositing/scaling/:
- compositing/tiling/:
- compositing/transitions/:
- compositing/video/:
- compositing/visibility/:
- compositing/webgl/:
- platform/chromium/compositing/:
- platform/chromium/compositing/force-compositing-mode/:
- platform/chromium/compositing/rubberbanding/:
- platform/mac/compositing/canvas/:
- 11:26 AM Changeset in webkit [119991] by
-
- 539 edits9 adds24 deletes in trunk/LayoutTests
Large slew of Chromium windows png rebaselines. See http://crbug.com/131829 for more information.
List of rebaselined files excluded because it's too long.
- 11:23 AM Changeset in webkit [119990] by
-
- 153 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in css 1, css 2.1, and css3 tests
https://bugs.webkit.org/show_bug.cgi?id=88769
Reviewed by Tony Chang.
- css1/units/zero-duration-without-units.html:
- css3/calc/:
- css3/filters/:
- css3/filters/custom/:
- css3/filters/resources/:
- css3/filters/script-tests/:
- css3/flexbox/:
- css3/font-feature-settings-rendering.html:
- css3/images/cross-fade-invalidation.html:
- css3/images/optimize-contrast-canvas.html:
- css3/images/optimize-contrast-image.html:
- css3/khtml-background-size-0x0-bmp.html:
- css3/parsing-css3-nthchild.html:
- css3/style-zoomed-image.html:
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html:
- css3/zoom-coords.xhtml:
- platform/win/css2.1/resources/run-webkit-tests-epilogue.html:
- platform/win/css2.1/resources/run-webkit-tests-prologue.html:
- 11:21 AM Changeset in webkit [119989] by
-
- 1 edit in branches/chromium/1132/Source/WebKit/chromium/public/WebMediaPlayer.h
Merge 119569 - [chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349
https://bugs.webkit.org/show_bug.cgi?id=88388
Reviewed by Darin Fisher.
- public/WebMediaPlayer.h:
TBR=fischman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10533083
- 11:14 AM Changeset in webkit [119988] by
-
- 11 edits in trunk
[chromium] Provide access to the WebPlugin created by the helper plugin widget
https://bugs.webkit.org/show_bug.cgi?id=88028
Patch by David Dorwin <ddorwin@chromium.org> on 2012-06-11
Reviewed by Adam Barth.
Source/WebKit/chromium:
A WebPlugin is created when the document created by createHelperPlugin() is laid out.
Expose it so the embedder can interact with the plugin instance.
- public/WebHelperPlugin.h:
(WebKit):
(WebHelperPlugin):
- public/WebMediaPlayerClient.h:
(WebKit):
- public/WebPlugin.h:
(WebKit::WebPlugin::isPlaceholder):
(WebPlugin):
- src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::WebHelperPluginImpl):
(WebKit):
(WebKit::WebHelperPluginImpl::getPlugin):
(WebKit::WebHelperPluginImpl::initPage):
(WebKit::WebHelperPluginImpl::close):
- src/WebHelperPluginImpl.h:
(WebKit):
(WebHelperPluginImpl):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::createHelperPlugin):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- src/WebPagePopupImpl.cpp:
Tools:
Added isPlaceholder() to WebPlugin.
- DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin::isPlaceholder):
- 11:13 AM Changeset in webkit [119987] by
-
- 5 edits in trunk/Source/WebCore
[Chromium] Theme updates for Android in menu list rendering and selection backgrounds
https://bugs.webkit.org/show_bug.cgi?id=88775
Reviewed by Adam Barth.
For Chrome on Android, use the width of the scrollbar down arrow instead
of the scrollbar's width for determining the arrow padding to apply for
menu list rendering, as WebKit isn't drawing a scrollbar (thus width=0).
Furthermore, change the default active selection background color to be
equal to the tap highlighting color.
These changes should be covered by existing layout tests.
- rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):
(WebCore): Retrieve the scrollbar down arrow's size via PlatformSupport.
- rendering/RenderThemeChromiumAndroid.h: Override the menuListArrowPadding
and platformActiveSelectionBackgroundColor methods, and add a static
static RGBA32 color for the default active selection bg color.
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::menuListArrowPadding): Default to
the scrollbar thickness, not changing behavior for non-Android.
(WebCore::RenderThemeChromiumSkia::menuListInternalPadding): Instead
of polling the scrollbar thickness, call menuListArrowPadding().
- rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia): Add the menuListArrowPadding() as a protected method.
- 10:39 AM Changeset in webkit [119986] by
-
- 3 edits in trunk/Tools
rebaseline from garden-o-matic leaves N processes each time it is run
https://bugs.webkit.org/show_bug.cgi?id=88586
Reviewed by Dirk Pranke.
This appears to only be a problem on python 2.7. Maybe a bug causing
pools to not be garbage collected?
- Scripts/webkitpy/common/system/executive.py:
(Executive.run_in_parallel): close() and join() the process pool.
- Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_run_in_parallel):
- 10:22 AM Changeset in webkit [119985] by
-
- 53 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in animations tests
https://bugs.webkit.org/show_bug.cgi?id=88757
Reviewed by Tony Chang.
- animations/3d/change-transform-in-end-event.html:
- animations/3d/replace-filling-transform.html:
- animations/3d/state-at-end-event-transform.html:
- animations/3d/transform-origin-vs-functions.html:
- animations/animation-add-events-in-handler.html:
- animations/animation-border-overflow.html:
- animations/animation-controller-drt-api.html:
- animations/animation-direction-reverse-fill-mode-hardware.html:
- animations/animation-direction-reverse-fill-mode.html:
- animations/animation-drt-api-multiple-keyframes.html:
- animations/animation-drt-api.html:
- animations/animation-end-event-destroy-renderer.html:
- animations/animation-end-event-short-iterations.html:
- animations/animation-hit-test-transform.html:
- animations/animation-hit-test.html:
- animations/animation-iteration-event-destroy-renderer.html:
- animations/animation-matrix-negative-scale-unmatrix.html:
- animations/animation-on-inline-crash.html:
- animations/animation-shorthand-overriding.html:
- animations/animation-shorthand-removed.html:
- animations/animation-shorthand.html:
- animations/animation-start-event-destroy-renderer.html:
- animations/animation-welcome-safari.html:
- animations/body-removal-crash.html:
- animations/change-keyframes-name.html:
- animations/change-transform-style-during-animation.html:
- animations/combo-transform-translate+scale.html:
- animations/empty-keyframes.html:
- animations/fill-mode-forwards.html:
- animations/fill-mode-iteration-count-non-integer.html:
- animations/fill-mode-missing-from-to-keyframes.html:
- animations/fill-mode-multiple-keyframes.html:
- animations/fill-mode-removed.html:
- animations/fill-mode-reverse.html:
- animations/fill-mode-transform.html:
- animations/fill-mode.html:
- animations/fill-unset-properties.html:
- animations/font-size-using-ems.html-disabled:
- animations/import-crash.html:
- animations/keyframe-timing-functions-transform.html:
- animations/keyframe-timing-functions2.html:
- animations/keyframes-iteration-count-non-integer.html:
- animations/longhand-timing-function.html:
- animations/missing-from-to-transforms.html:
- animations/missing-from-to.html:
- animations/pause-crash.html:
- animations/resources/animation-test-helpers.js:
(checkExpectedValue):
(endTest):
- animations/state-at-end-event.html:
- animations/suspend-resume-animation-events.html:
- animations/suspend-transform-animation.html:
- animations/transition-and-animation-3.html:
- animations/unanimated-style.html:
- 10:19 AM Changeset in webkit [119984] by
-
- 22 edits3 adds in trunk
Add css3-images image-resolution (dppx only)
https://bugs.webkit.org/show_bug.cgi?id=85332
Patch by David Barr <davidbarr@chromium.org> on 2012-06-11
Reviewed by Tony Chang.
The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#image-resolution
Source/WebCore:
Test: fast/css/image-resolution.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSGrammar.y:
- css/CSSParser.cpp:
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore):
(WebCore::CSSParser::parseImageResolution):
(WebCore::CSSParser::detectNumberToken):
- css/CSSParser.h:
- css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::unitCategory):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
- css/CSSPrimitiveValue.h:
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/StyleBuilder.cpp:
(WebCore):
(ApplyPropertyImageResolution):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyImageResolution::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::styleDidChange):
(WebCore::RenderImage::imageDimensionsChanged):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
LayoutTests:
- fast/css/image-resolution/image-resolution-expected.txt: Added.
- fast/css/image-resolution/image-resolution.html: Added.
- platform/chromium/TestExpectations: Skip tests until image-resolution implementation lands.
- platform/efl/TestExpectations: Skip tests until image-resolution implementation lands.
- platform/gtk/TestExpectations: Skip tests until image-resolution implementation lands.
- platform/mac/TestExpectations: Skip tests until image-resolution implementation lands.
- platform/qt/TestExpectations: Skip tests until image-resolution implementation lands.
- 9:57 AM Changeset in webkit [119983] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Make media (<video> and <audio>) slide draggable again https://bugs.webkit.org/show_bug.cgi?id=88742 PR #158199
Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>
First check if the element is a range type then gets its
shadow DOM ancestor.
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::shouldConvertTouchToMouse):
- 9:49 AM Changeset in webkit [119982] by
-
- 4 edits in trunk/Source
[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
https://bugs.webkit.org/show_bug.cgi?id=88371
Reviewed by James Robinson.
Source/WebCore:
Unit test: CCLayerTreeHostImplTest.layersFreeTextures
- platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
- 8:31 AM Changeset in webkit [119981] by
-
- 9 edits in trunk
Unreviewed. Fix make distcheck issues.
.:
- GNUmakefile.am: Initialize jscore nosource variables.
Source/JavaScriptCore:
- GNUmakefile.list.am: Remove non existent header file.
Source/WebCore:
- GNUmakefile.am: Add idl files in editing dir to EXTRA_DIST.
- GNUmakefile.list.am: Add missing header file.
Source/WTF:
- GNUmakefile.list.am: Add missing header file.
- 7:59 AM Changeset in webkit [119980] by
-
- 21 edits5 adds1 delete in trunk/LayoutTests
[Chromium] Unreviewed: Rebaseline more SVG tests on Windows.
- platform/chromium-linux-x86/svg/batik/filters/filterRegions-expected.png: Removed.
- platform/chromium-win-vista/svg/batik/paints/gradientLimit-expected.png: Added.
- platform/chromium-win-xp/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
- platform/chromium-win-xp/svg/batik/text/smallFonts-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/linking-a-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/linking-a-02-b-expected.png:
- platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
- platform/chromium-win/svg/as-image/same-image-two-instances-expected.png:
- platform/chromium-win/svg/as-image/svg-as-relative-image-expected.png:
- platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png:
- platform/chromium-win/svg/batik/filters/feTile-expected.png:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
- 7:37 AM Changeset in webkit [119979] by
-
- 7 edits1 delete in trunk/LayoutTests
[Chromium] Unreviewed: Rebaselines for svg/as-background-image tests on Windows.
- platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
- platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
- platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png:
- platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
- 7:33 AM Changeset in webkit [119978] by
-
- 5 edits2 deletes in trunk
Reverted r119940 because it caused multiple media tests to fail on Lion.
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore):
(WebCore::HTMLMediaElement::userCancelledLoad):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):
LayoutTests:
- http/tests/media/video-src-invalid-error-expected.txt: Removed.
- http/tests/media/video-src-invalid-error.html: Removed.
- 7:05 AM Changeset in webkit [119977] by
-
- 6 edits3 adds in trunk
Source/WebCore: [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)$
https://bugs.webkit.org/show_bug.cgi?id=87841
Reviewed by Simon Hausmann.
No new tests were needed.
- Target.pri:
- WebCore.pri:
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):
Tools: [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
https://bugs.webkit.org/show_bug.cgi?id=87841
Reviewed by Simon Hausmann.
- qmake/config.tests/libwebp/libwebp.cpp: Added.
(main):
- qmake/config.tests/libwebp/libwebp.pro: Added.
- qmake/sync.profile:
- 7:02 AM Changeset in webkit [119976] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening after r119962. Four inspector/debugger tests still fail after they have been re-enabled.
https://bugs.webkit.org/show_bug.cgi?id=43332
Patch by János Badics <János Badics> on 2012-06-11
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 6:53 AM Changeset in webkit [119975] by
-
- 8 edits in trunk/Source
Add QML api for setting device width and height
https://bugs.webkit.org/show_bug.cgi?id=88777
Reviewed by Simon Hausmann.
Source/WebCore:
Change the default values for deviceWidth/Height to be 0 (unset). The
original values were introduced by Qt and 0 makes it possible to
detect if a value has never been set and therefore fall back.
Only Qt depended on the former values.
- page/Settings.cpp:
(WebCore::Settings::Settings):
Source/WebKit2:
Add the new API and set the default values to 0 (unset). The
current values were introduced by Qt and only Qt depends on them.
- Shared/WebPreferencesStore.h:
(WebKit):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::deviceWidth):
(QQuickWebViewExperimental::setDeviceWidth):
(QQuickWebViewExperimental::deviceHeight):
(QQuickWebViewExperimental::setDeviceHeight):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/qt/QtViewportHandler.cpp:
(WebKit::QtViewportHandler::viewportItemSizeChanged):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
- 6:20 AM Changeset in webkit [119974] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Should call frameDetached() in WebPagePopupImpl::close()
https://bugs.webkit.org/show_bug.cgi?id=88754
Reviewed by Adam Barth.
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::close): Calls FrameLoader::frameDetached().
- 5:49 AM Changeset in webkit [119973] by
-
- 19 edits in trunk/LayoutTests
[Chromium] Unreviewed: Rebaselines and updated expectations for media tests
Pixel differences are due to antialiasing and different rounded
corners on the media progress bar. The difference is not
noticeable.
- platform/chromium-win/media/audio-controls-rendering-expected.png:
- platform/chromium-win/media/audio-repaint-expected.png:
- platform/chromium-win/media/controls-after-reload-expected.png:
- platform/chromium-win/media/controls-layout-direction-expected.png:
- platform/chromium-win/media/controls-strict-expected.png:
- platform/chromium-win/media/controls-styling-expected.png:
- platform/chromium-win/media/controls-without-preload-expected.png:
- platform/chromium-win/media/media-controls-clone-expected.png:
- platform/chromium-win/media/media-document-audio-repaint-expected.png:
- platform/chromium-win/media/video-controls-rendering-expected.png:
- platform/chromium-win/media/video-display-toggle-expected.png:
- platform/chromium-win/media/video-layer-crash-expected.png:
- platform/chromium-win/media/video-no-audio-expected.png:
- platform/chromium-win/media/video-playing-and-pause-expected.png:
- platform/chromium-win/media/video-transformed-expected.png:
- platform/chromium-win/media/video-volume-slider-expected.png:
- platform/chromium-win/media/video-zoom-controls-expected.png:
- platform/chromium/TestExpectations:
- 5:19 AM Changeset in webkit [119972] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: Mark track-cue-rendering-inner-timestamps.html failing on Vista
- platform/chromium/TestExpectations:
- 4:27 AM Changeset in webkit [119971] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skipping http/tests/security/mixedContent/filesystem-url-in-iframe.html
https://bugs.webkit.org/show_bug.cgi?id=88770
ENABLE(FILE_SYSTEM) is disabled; this test should be skipped until
that feature is enabled. Moving it up into the proper section of the
Skipped file to make sure it's enabled if and when the feature makes
it into the port.
Patch by Mike West <mkwst@chromium.org> on 2012-06-11
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 3:29 AM Changeset in webkit [119970] by
-
- 6 edits in trunk/Source/WebKit/qt
[Qt][Win] Add missing includes to fix the build
https://bugs.webkit.org/show_bug.cgi?id=88538
Reviewed by Simon Hausmann.
- Api/qwebframe.cpp:
- WebCoreSupport/ChromeClientQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/GeolocationClientQt.cpp:
- WebCoreSupport/IconDatabaseClientQt.cpp:
- 3:24 AM Changeset in webkit [119969] by
-
- 2 edits in trunk/Source/WebCore
[Qt][Win] Fix UString related build problem in Source/WebCore/bridge/qt/qt_instance.cpp
https://bugs.webkit.org/show_bug.cgi?id=88310
Reviewed by Simon Hausmann.
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getPropertyNames):
- 2:49 AM Changeset in webkit [119968] by
-
- 2 edits in trunk/Source/WebCore
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918
Unreviewed build fix.
No new tests added as this is a build fix.
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-06-11
- platform/qt/FileSystemQt.cpp:
- 2:38 AM Changeset in webkit [119967] by
-
- 4 edits2 adds in trunk
Rect-based hittesting doesn't work in tables.
https://bugs.webkit.org/show_bug.cgi?id=86605
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-11
Reviewed by Julien Chaffraix.
Source/WebCore:
The existing code only performed a single binary lookup for the central
hit-test point. This meant area-based hit-testing did not work across
table-cell borders. All cells spanned by a hit-test area must be hit
tested.
This patch introduces three auxilary functions to help calculate rows
and columns spanned by an rect. These are intended to also be used by
repaint logic in a later patch.
For point-based hit-testing we maintain unchanged behavior and still
only hit test a single column in a single row.
Test: fast/dom/nodesFromRect-table.html
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::logicalRectForWritingModeAndDirection):
(WebCore::RenderTableSection::spannedRows):
(WebCore::RenderTableSection::spannedColumns):
(WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderTableSection.h:
(RenderTableSection):
LayoutTests:
Test nodesFromRect on tables.
- fast/dom/nodesFromRect-table-expected.txt: Added.
- fast/dom/nodesFromRect-table.html: Added.
- 2:26 AM Changeset in webkit [119966] by
-
- 5 edits in trunk/Source
Adding a flag to show fullscreen media controls in chromium
https://bugs.webkit.org/show_bug.cgi?id=88266
Patch by Min Qin <qinmin@google.com> on 2012-06-11
Reviewed by Adam Barth.
Source/WebCore:
The default chromium shadow DOM for media element does not contain fullscreen button.
This change adds a flag to display the fullscreen button.
It will be used by the android port.
No new tests needed. We will use the same layout tests as desktop chromium.
However, new test result expections will be added later.
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::create):
(WebCore::MediaControlRootElementChromium::setMediaController):
(WebCore::MediaControlRootElementChromium::reset):
(WebCore::MediaControlRootElementChromium::reportedError):
- html/shadow/MediaControlRootElementChromium.h:
(MediaControlRootElementChromium):
Source/WebKit/chromium:
Adding a flag to the gyp file so that we can enable fullscreen media control
- features.gypi:
- 2:17 AM Changeset in webkit [119965] by
-
- 8 edits in trunk/Source
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-06-11
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
No new tests needed / applicable (using operating system functionality).
Added method to read free file system space for a path to support cache model
implementation in Qt WK 2.
- platform/FileSystem.h:
(WebCore):
- platform/qt/FileSystemQt.cpp:
(WebCore::getVolumeFreeSizeForPath): Added for Qt ports.
(WebCore):
Source/WebKit2:
Added implementation of cache model for Qt WK 2 port including supporting
functionality such as WebProcess creation parameters and default values
for disk cache directories.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
- UIProcess/qt/WebContextQt.cpp:
(WebKit::defaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::physicalMemorySizeInBytes):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):
- 2:00 AM Changeset in webkit [119964] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening, skip new failing tests.
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-06-11
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 1:26 AM Changeset in webkit [119963] by
-
- 2 edits in trunk/LayoutTests
[EFL] skip http/tests/cookies/js-get-and-set-http-only-cookie.html test case
https://bugs.webkit.org/show_bug.cgi?id=88751
Unreviewed EFL gardening. Skip newly introduced test case that is failing
on most ports.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-11
- platform/efl/TestExpectations:
- 1:24 AM Changeset in webkit [119962] by
-
- 4 edits in trunk
[JSC] Web Inspector: implement breaking from native callback
https://bugs.webkit.org/show_bug.cgi?id=43332
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-06-11
Reviewed by Pavel Feldman.
These test cases were enabled:
LayoutTests/inspector/debugger/dom-breakpoints.html
LayoutTests/inspector/debugger/event-listener-breakpoints.html
LayoutTests/inspector/debugger/step-through-event-listeners.html
LayoutTests/inspector/debugger/xhr-breakpoints.html
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::breakProgram):
- bindings/js/ScriptDebugServer.h:
(WebCore::supportsNativeBreakpoints):
- 1:23 AM Changeset in webkit [119961] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: Remove expectations for passing tests
The flakiness dashboard indicates that
platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.cylinder.html
and
platform/chromium/virtual/gpu/fast/canvas/canvas-currentColor.html
are passing on all platforms now.
- platform/chromium/TestExpectations:
- 1:17 AM Changeset in webkit [119960] by
-
- 2 edits in trunk/Source/WebCore
Spellchecker crash in async scenario.
https://bugs.webkit.org/show_bug.cgi?id=88617
Reviewed by Tony Chang.
SpellCheckRequest::invokeRequest() can be reached after the frame is detached.
SpellCheckRequest should ignore such a request since TextCheckerClient is not available
for detached Frames.
No new tests. It's hard to reproduce this.
- editing/SpellChecker.cpp:
(WebCore::SpellChecker::invokeRequest):
- 1:11 AM Changeset in webkit [119959] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
https://bugs.webkit.org/show_bug.cgi?id=88752
Unreviewed EFL gardening. Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
now that it no longer depends on the legacy blob builder (r119944).
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-11
- platform/efl/TestExpectations:
- 12:41 AM Changeset in webkit [119958] by
-
- 4 edits in trunk/Source/WebCore
[EFL] Extract CursorMap from WidgetEfl.cpp.
https://bugs.webkit.org/show_bug.cgi?id=88633
Reviewed by Ryosuke Niwa.
In order to share CursorMap in WebKit/efl and UIProcess of WebKit2/Efl,
extract it and expose getEcoreCursor.
No new tests, refactoring only.
- platform/efl/EflScreenUtilities.cpp:
(WebCore):
(CursorMap):
(WebCore::CursorMap::cursor):
(WebCore::CursorMap::CursorMap):
(WebCore::getEcoreCursor):
- platform/efl/EflScreenUtilities.h:
(WebCore):
- platform/efl/WidgetEfl.cpp:
(WebCore::Widget::applyFallbackCursor):
- 12:14 AM QtWebKitForQt5 edited by
- (diff)
Jun 10, 2012:
- 11:58 PM Changeset in webkit [119957] by
-
- 18 edits in trunk/Source
Unreviewed, rolling out r119955.
http://trac.webkit.org/changeset/119955
https://bugs.webkit.org/show_bug.cgi?id=88758
Breaks Chromium compile - Chromium depends on removed API
(Requested by dominicc on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-10
Source/WebCore:
- WebCore.exp.in:
- editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea):
(WebCore):
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):
(WebCore::Editor::nextVisibleRange):
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
- editing/Editor.h:
(Editor):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- page/Frame.cpp:
(WebCore::Frame::Frame):
- page/Frame.h:
(Frame):
(WebCore::Frame::isDisconnected):
(WebCore):
(WebCore::Frame::setIsDisconnected):
(WebCore::Frame::excludeFromTextSearch):
(WebCore::Frame::setExcludeFromTextSearch):
- page/FrameTree.cpp:
(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):
- page/FrameTree.h:
(FrameTree):
- page/Location.cpp:
(WebCore::Location::ancestorOrigins):
- xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::hasNoStyleInformation):
Source/WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _setIsDisconnected:]):
(-[WebFrame _setExcludeFromTextSearch:]):
- WebView/WebFramePrivate.h:
Source/WebKit/win:
- WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
- 11:23 PM Changeset in webkit [119956] by
-
- 7 edits in trunk
Using BlobBuilder should show a deprecation warning message (if it is enabled)
https://bugs.webkit.org/show_bug.cgi?id=88644
Reviewed by Jian Li.
Source/WebCore:
Mac has already disabled BlobBuilder, but Chromium still has it.
We should start showing a warning to let people migrate to using Blob constructor.
Tests: fast/files/blob-builder-crash.html
- fileapi/WebKitBlobBuilder.cpp:
(WebCore):
(WebCore::WebKitBlobBuilder::create):
- fileapi/WebKitBlobBuilder.h:
(WebCore):
(WebKitBlobBuilder):
- fileapi/WebKitBlobBuilder.idl:
LayoutTests:
- fast/files/blob-builder-crash-expected.txt:
- 11:11 PM Changeset in webkit [119955] by
-
- 18 edits in trunk/Source
Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
https://bugs.webkit.org/show_bug.cgi?id=88723
Reviewed by Dan Bernstein.
Source/WebCore:
- WebCore.exp.in:
Update export.
- editing/Editor.cpp:
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
- editing/Editor.h:
(Editor):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- page/Frame.cpp:
(WebCore::Frame::Frame):
- page/Frame.h:
(Frame):
- page/FrameTree.cpp:
(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):
- page/FrameTree.h:
(FrameTree):
- page/Location.cpp:
(WebCore::Location::ancestorOrigins):
- xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::hasNoStyleInformation):
Update for the removal of disconnected frames and text search exclusions concepts.
Source/WebKit/mac:
- WebView/WebFrame.mm:
- WebView/WebFramePrivate.h:
Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:]
Source/WebKit/win:
- WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
Stop doing anything in these functions.
- 11:03 PM Changeset in webkit [119954] by
-
- 17 edits3 copies9 moves1 add in trunk/Source/WebCore
Move Quota related code out of DOMWindow and into the quota/ folder
https://bugs.webkit.org/show_bug.cgi?id=88512
Patch by Kinuko Yasuda <kinuko@google.com> on 2012-06-07
Reviewed by Adam Barth.
No new tests: no visible changes.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- Modules/quota/DOMWindowQuota.cpp: Added.
- Modules/quota/DOMWindowQuota.h: Added.
- Modules/quota/DOMWindowQuota.idl: Added.
- Modules/quota/StorageInfo.cpp: Renamed from Source/WebCore/storage/StorageInfo.cpp.
- Modules/quota/StorageInfo.h: Renamed from Source/WebCore/storage/StorageInfo.h.
- Modules/quota/StorageInfo.idl: Renamed from Source/WebCore/storage/StorageInfo.idl.
- Modules/quota/StorageInfoErrorCallback.h: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.h.
- Modules/quota/StorageInfoErrorCallback.idl: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.idl.
- Modules/quota/StorageInfoQuotaCallback.h: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.h.
- Modules/quota/StorageInfoQuotaCallback.idl: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.idl.
- Modules/quota/StorageInfoUsageCallback.h: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.h.
- Modules/quota/StorageInfoUsageCallback.idl: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.idl.
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/copyForwardingHeaders.cmd:
- WebCore.xcodeproj/project.pbxproj:
- page/DOMWindow.cpp:
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 10:47 PM Changeset in webkit [119953] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: Add expectations for svg-as-background-6.html
Like other SVG tests noted in bug 83303, this test fails on
Windows because it uses a sans-serif font where a serif font is
expected.
- platform/chromium/TestExpectations:
- 10:35 PM Changeset in webkit [119952] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Unreviewed: Rebaseline fixed-position-transform-composited-page-scale on Linux, Win
These differ in antialiasing only, where there are already
platform differences antialiasing.
- platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- 9:45 PM Changeset in webkit [119951] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: Update
css3/font-feature-settings-rendering.html again -- actually it may
pass if a particular DLL is installed. So expect PASS or
IMAGE+TEXT failure from this test.
- platform/chromium/TestExpectations:
- 9:38 PM Changeset in webkit [119950] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed: Update
css3/font-feature-settings-rendering.html expectations to fail on
XP.
- platform/chromium/TestExpectations:
- 8:58 PM Changeset in webkit [119949] by
-
- 6 edits2 adds in trunk
An inheritance of '-webkit-user-modify' does not stop at shadow boundary.
https://bugs.webkit.org/show_bug.cgi?id=88514
Reviewed by Ryosuke Niwa.
Source/WebCore:
In StyleResolver::styleForElement(), we reset '-webkit-user-modify'
CSS property after inheriting a parent style, but that is not
enough. We also have to reset '-webkit-user-modify' when we use a
cached result in applying matched properties.
Test: fast/dom/shadow/user-modify-inheritance.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::styleForElement):
- css/StyleResolver.h:
(StyleResolver):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::inheritFrom):
- rendering/style/RenderStyle.h:
LayoutTests:
- fast/dom/shadow/user-modify-inheritance-expected.txt: Added.
- fast/dom/shadow/user-modify-inheritance.html: Added.
- 7:30 PM Changeset in webkit [119948] by
-
- 19 edits2 adds in trunk
[Forms] Introduce Decimal behind the InputNumber type
https://bugs.webkit.org/show_bug.cgi?id=88383
Reviewed by Kent Tamura.
Source/WebCore:
This patch introduces decimal arithmetic for steppable input types,
e.g. date, datetime, number, range, and so on, to avoid rounding error
caused by base 2 floating point representation, e.g. C/C++ double type.
Most of decimal arithmetic calculations are implemented in StepRange
class, replacing "double" with "Decimal", InputType::applyStep, and
InputType::stepFromRenderer.
Changes introduced by this patch are still intermediate state.
Following patch will replace InputNumber type to Decimal type for
completion of introducing decimal arithmetic.
Test: fast/forms/range/range-value-rounding.html
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::serialize): Changed for Decimal type.
(WebCore::BaseDateAndTimeInputType::serializeWithComponents): ditto.
- html/DateInputType.cpp:
(WebCore::DateInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
- html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
- html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
- html/InputType.cpp:
(WebCore::InputType::rangeUnderflow): Changed for Decimal type.
(WebCore::InputType::rangeOverflow): Changed for Decimal type.
(WebCore::InputType::minimum): Changed for Decimal type.
(WebCore::InputType::maximum): ditto.
(WebCore::InputType::isInRange): ditto.
(WebCore::InputType::isOutOfRange): ditto.
(WebCore::InputType::stepMismatch): ditto.
(WebCore::InputType::validationMessage): ditto.
(WebCore::InputType::parseToNumberOrNaN): ditto.
(WebCore::InputType::applyStep): ditto.
(WebCore::InputType::stepUpFromRenderer): ditto.
- html/InputType.h:
(InputType): Removed parseToNumberWIthDecimaplPlaces.
- html/MonthInputType.cpp:
(WebCore::MonthInputType::createStepRange): Changed for Decimal type.
- html/NumberInputType.cpp:
(WebCore::RealNumberRenderSize): Added for calculateRenderSize.
(WebCore::calculateRenderSize): Added. This function replacess lengthBeforeDecimalPoint.
(WebCore::NumberInputType::createStepRange): Changed for Decimal type.
(WebCore::NumberInputType::sizeShouldIncludeDecoration): Changed to use calculateRenderSize.
(WebCore::NumberInputType::parseToNumber): Changed for Decimal type.
(WebCore::NumberInputType::serialize): ditto.
- html/NumberInputType.h:
(NumberInputType): Removed parseToNumberWIthDecimaplPlaces.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createStepRange): Changed for Decimal type.
(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::parseToNumber): ditto.
(WebCore::RangeInputType::serialize): ditto.
- html/StepRange.cpp:
(WebCore::StepRange::StepRange): Removed decimal places and changed for Decimal type.
(WebCore::StepRange::acceptableError): Changed for Decimal type.
(WebCore::StepRange::alignValueForStep): ditto.
(WebCore::StepRange::clampValue): Changed for Decimal type and std::min/max.
(WebCore::StepRange::parseStep): Changed for Decimal type and removed NumberWithDecimalPlaces.
(WebCore::StepRange::stepMismatch): Changed for Decimal type.
(WebCore::convertDoubleToInputNumber): Changed to real implementation.
(WebCore::convertInputNumberToDouble): Changed to real implementation.
- html/StepRange.h:
(InputNumber): Replacement of NumberWithDecimalPlaces.
(WebCore::StepRange::InputNumber::InputNumber):
- html/TimeInputType.cpp:
(WebCore::TimeInputType::createStepRange): Changed for Decimal type.
- html/WeekInputType.cpp:
(WebCore::WeekInputType::createStepRange): Changed for Decimal type.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::serializeForNumberType): Added Decimal version.
(WebCore::parseToDecimalForNumberType): Added.
- html/parser/HTMLParserIdioms.h: Updated comments for parseToDoubleForNumberType.
- html/shadow/SliderThumbElement.cpp:
(WebCore::sliderPosition): Changed for Decimal type.
LayoutTests:
- fast/forms/range/range-value-rounding-expected.txt: Added.
- fast/forms/range/range-value-rounding.html: Added.
- 7:16 PM Changeset in webkit [119947] by
-
- 7 edits3 adds in trunk
[BlackBerry] Possible to clobber httponly cookie.
https://bugs.webkit.org/show_bug.cgi?id=86067
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-06-10
Reviewed by Rob Buis.
Source/WebCore:
If a cookie is set by javaScript and there is already a same httpOnly cookie in cookieManager,
we should reject it. If it has a httpOnly property, we reject it, too.
Test: http/tests/cookies/js-get-and-set-http-only-cookie.html
- platform/blackberry/CookieJarBlackBerry.cpp:
(WebCore::setCookies):
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
(WebCore::CookieManager::setPrivateMode):
- platform/blackberry/CookieManager.h:
- platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookie):
- platform/blackberry/CookieMap.h:
(CookieMap):
LayoutTests:
- http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
- http/tests/cookies/js-get-and-set-http-only-cookie.html: Added.
- platform/chromium/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
- 2:36 PM Changeset in webkit [119946] by
-
- 6 edits2 adds in trunk
Expose layoutTestController as testRunner
https://bugs.webkit.org/show_bug.cgi?id=88210
Reviewed by Darin Adler.
Tools:
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::makeWindowObject):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::bindJSObjectsToWindow):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::initJSObjects):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::makeWindowObject):
LayoutTests:
Add a test for testRunner object.
- fast/harness/testrunner-object-expected.txt: Added.
- fast/harness/testrunner-object.html: Added.
- 1:18 PM Changeset in webkit [119945] by
-
- 3 edits3 adds in trunk
Access control allow lists starting with a comma are parsed incorrectly (CORS)
https://bugs.webkit.org/show_bug.cgi?id=88461
Patch by Pablo Flouret <pablof@motorola.com> on 2012-06-10
Reviewed by Adam Barth.
Source/WebCore:
The parsing algorithm would stop parsing at the first comma (being an
empty entry, of sorts) and bail out, effectively ignoring the whole
header.
Test: http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html
- loader/CrossOriginPreflightResultCache.cpp:
(WebCore::parseAccessControlAllowList):
LayoutTests:
- http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html: Added.
- http/tests/xmlhttprequest/resources/access-control-allow-lists.php: Added.
- 12:48 PM Changeset in webkit [119944] by
-
- 4 edits in trunk/LayoutTests
Removing mixed content tests' dependency on WebKitBlobBuilder:
https://bugs.webkit.org/show_bug.cgi?id=88736
http/tests/security/mixedContent/blob-url-in-iframe.html and
http/tests/security/mixedContent/filesystem-url-in-iframe.html both
relied on WebKitBlobBuilder, which is disabled on some builds. `new
Blob()` is the new hotness that these tests should be using instead. This
patch migrates both tests to the new API.
It also reenables blob-url-in-iframe.html on mac (filesystem-url-in-iframe.html
remains disabled, as the filesystem APIs are disabled entirely).
Patch by Mike West <mkwst@chromium.org> on 2012-06-10
Reviewed by Adam Barth.
- http/tests/security/mixedContent/blob-url-in-iframe.html:
- http/tests/security/mixedContent/filesystem-url-in-iframe.html:
- platform/mac/Skipped:
- 12:19 PM Changeset in webkit [119943] by
-
- 2 edits in trunk/Source/WebCore
Some additional tweaks to keep TreeShared code simple/clean
https://bugs.webkit.org/show_bug.cgi?id=88738
Reviewed by Adam Barth.
- platform/TreeShared.h: Make constructor and destructor both protected.
It's slightly dangerous to have a public non-virtual destructor, and there
is no reason it needs to be public.
(WebCore::TreeShared::~TreeShared): Make debug-only destructor non-virtual;
we were getting no value from it being virtual. Now that it's non-virtual,
there is no need to use an #if on it since it's an empty inline destructor
in non-debug builds.
- 11:44 AM Changeset in webkit [119942] by
-
- 4 edits in trunk/LayoutTests
[EFL][GTK] media/track/track-cue-rendering-inner-timestamps.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88725
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10
Reviewed by Eric Carlson.
- media/track/track-cue-rendering-inner-timestamps.html: Round the timestamp values
so that the test passes for EFL and GTK ports.
- platform/efl/TestExpectations: Unskip test.
- platform/gtk/TestExpectations: Unskip test.
- 11:41 AM Changeset in webkit [119941] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip fast/dom/frame-loading-via-document-write.html
https://bugs.webkit.org/show_bug.cgi?id=88737
Unreviewed EFL gardening. Skipping test that is flaky after r119788.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10
- platform/efl/TestExpectations:
- 11:18 AM Changeset in webkit [119940] by
-
- 5 edits2 adds in trunk
REGRESSION: Setting invalid media "src" does not cause "error" event
https://bugs.webkit.org/show_bug.cgi?id=88423
Reviewed by Eric Carlson.
Source/WebCore:
Test: http/tests/media/video-src-invalid-error.html
Two problems here. When the loadTimer is scheduled, the m_pendingLoadFlags
variable is set to specify what type of load is scheduled. It is cleared
when the loadTimer fires. But, when prepareForLoad() stops the loadTimer,
it does not clear the m_pendingLoadFlags variable, so the next time
scheduleLoad() is called (when the src is changed to an invalid URL)
prepareForLoad() is not called again.
Second problem: Due to a bug in QTKit (<rdar://problem/11606415>), the
QTMovieLoadStateChangedNotification is never fired for an invalid http
URL if QTMovieOpenAsyncRequiredAttribute:YES is not passed when creating
the QTMovie.
Add a new utility method which both stops the m_loadTimer and clears the
m_pendingLoadFlags, and use it in all the places where m_loadTimer was
stopped explicitly:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::stopLoadTimer): Added
(WebCore::HTMLMediaElement::userCancelledLoad):
- html/HTMLMediaElement.h:
And pass QTMovieOpenAsyncRequiredAttribute:YES when creating the QTMovie:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):
LayoutTests:
- http/tests/media/video-src-invalid-error-expected.txt: Added.
- http/tests/media/video-src-invalid-error.html: Added.
- 11:14 AM Changeset in webkit [119939] by
-
- 3 edits in trunk/Source/WebCore
Add logging functions to MediaPlayerPrivateQTKit.
https://bugs.webkit.org/show_bug.cgi?id=88425
Reviewed by Eric Carlson.
No new tests; adds logging functions to aide debugging.
MediaPlayerPrivateQTKit should emit the same kind of logging messages as
other MediaPlayerPrivate engines to aide in debugging.
Distinguish between loadedRangesChanged() and loadStateChanged() for logging
purposes:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::loadedRangesChanged):
(-[WebCoreMovieObserver loadedRangesChanged:]):
Add LOG messages for each of the following functions:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::detachQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::prepareToPlay):
(WebCore::MediaPlayerPrivateQTKit::play):
(WebCore::MediaPlayerPrivateQTKit::pause):
(WebCore::MediaPlayerPrivateQTKit::seek):
(WebCore::MediaPlayerPrivateQTKit::cancelSeek):
(WebCore::MediaPlayerPrivateQTKit::setVolume):
(WebCore::MediaPlayerPrivateQTKit::setRate):
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
(WebCore::MediaPlayerPrivateQTKit::cancelLoad):
(WebCore::MediaPlayerPrivateQTKit::prepareForRendering):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::loadStateChanged):
(WebCore::MediaPlayerPrivateQTKit::rateChanged):
(WebCore::MediaPlayerPrivateQTKit::sizeChanged):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):
(WebCore::MediaPlayerPrivateQTKit::didEnd):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCache):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForSite):
(WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks):
- 11:09 AM Changeset in webkit [119938] by
-
- 8 edits in trunk/Source/WebCore
WebCore should use a single definition of an invalid media time.
https://bugs.webkit.org/show_bug.cgi?id=88572
Reviewed by Eric Carlson.
No new tests; no change in functionality, so covered by existing tests.
Add a new, universal definition for an invalid media time:
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayer::invalidTime):
Use this new definition instead of the hodge podge of (identical) local
definitions for an invalid media time:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::invalidateCachedTime):
(WebCore::HTMLMediaElement::currentTime):
(WebCore::HTMLMediaElement::initialTime):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::prepareMediaFragmentURI):
(WebCore::HTMLMediaElement::applyMediaFragmentURI):
- html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::invalidTimeValue):
(WebCore::MediaFragmentURIParser::MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::startTime):
(WebCore::MediaFragmentURIParser::endTime):
(WebCore::MediaFragmentURIParser::parseTimeFragment):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::duration):
(WebCore::MediaPlayerPrivateAVFoundation::seeking):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
(WebCore::MediaPlayerPrivateAVFoundation::invalidateCachedDuration):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::duration):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):
- 10:15 AM Changeset in webkit [119937] by
-
- 16 edits in trunk
Remove unneeded callRemovedLastRef function from TreeShared refactoring
https://bugs.webkit.org/show_bug.cgi?id=88653
Reviewed by Sam Weinig.
.:
- Source/autotools/symbols.filter: Filter removedLastRef instead of
callRemovedLastRef.
Source/WebCore:
- WebCore.exp.in: Updated to remove callRemovedLastRef and add removedLastRef.
- dom/ContainerNode.cpp: Removed callRemovedLastRef, which is no longer
needed and also had a bad cast in it.
- dom/Document.h: Made removedLastRef private and non-virtual and made Node
a friend so it can call the private function.
- dom/Node.cpp:
(WebCore::Node::removedLastRef): Moved here. This should not be an inline
function. Added comments explaining why it should not be inlined. Also added
explicit code to call to Document::removedLastRef, and added a comment why
that's the right thing to do here.
- dom/Node.h: Inherit from TreeShared<Node, ContainerNode>. Made the
removedLastRef function non-virtual and removed it from the header file.
Updated TreeShared using statements. Made the TreeShared template class a
friend so it can call the private removedLastRef.
- html/HTMLFormControlElement.h: Updated TreeShared using statements to specify
Node instead, which accomplishes the same thing.
- html/HTMLObjectElement.h: Ditto.
- platform/TreeShared.h: Made TreeShared take two template arguments for the
node type and the parent node type. Removed the callRemovedLastRef functions and
the extra forward declarations it required. Removed the private unused
removedLastRef function; not sure why it was left in here at all.
(WebCore::TreeShared::deref): Call removedLastRef instead of callRemovedLastRef.
(WebCore::TreeShared::setParent): Use ParentNodeType.
(WebCore::TreeShared::parent): Ditto.
(WebCore::adopted): Updated to have both template arguments.
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::removedLastRef): Replaced callRemovedLastRef with
this. Moved the body out of the header and added a comment explaining why the
function should not be inlined.
- svg/SVGElementInstance.h: Made removedLastRef non-virtual, non-inline, and
private. Made TreeShared a friend so it can call the private removedLastRef.
Updated TreeShared using statements.
Source/WebKit2:
- win/WebKit2.def: Export removedLastRef instead of callRemovedLastRef.
- win/WebKit2CFLite.def: Ditto.
- 9:54 AM Changeset in webkit [119936] by
-
- 4 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening. Updating a few animations tests baselines,
adding test expectations for one FileSystem test.
- platform/gtk/TestExpectations:
- platform/gtk/animations/3d/change-transform-in-end-event-expected.txt:
- platform/gtk/animations/3d/matrix-transform-type-animation-expected.txt: Added.
- platform/gtk/animations/3d/state-at-end-event-transform-expected.txt:
- 9:33 AM Changeset in webkit [119935] by
-
- 2 edits in trunk/LayoutTests
Temporarily added http/tests/security/mixedContent/blob-url-in-iframe.html to the Mac skip
list. <http://webkit.org/b/88736> tracks moving this test off of the legacy
WebKitBlobBuilder API.
- platform/mac/Skipped:
- 9:14 AM Changeset in webkit [119934] by
-
- 2 edits in trunk/LayoutTests
Added http/tests/security/mixedContent/filesystem-url-in-iframe.html to the Mac skip list,
because FILE_SYSTEM is not enabled.
Part of: http/tests/security/mixedContent/blob-url-in-iframe.html and http/tests/security/mixedContent/filesystem-url-in-iframe.html are failing
<http://webkit.org/b/88736>
- platform/mac/Skipped:
- 9:14 AM Changeset in webkit [119933] by
-
- 2 edits in trunk/LayoutTests
[EFL] 2 fast/multicol/span tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=88734
Unreviewed EFL gardening. Move to TestExpectations 2 tests that
are flaky on the bot.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10
- platform/efl/TestExpectations:
- 8:37 AM Changeset in webkit [119932] by
-
- 2 edits in trunk/Source/WebCore
- WebCore.exp.in: Re-sorted and alphabetized the file.
- 8:32 AM Changeset in webkit [119931] by
-
- 3 edits in trunk/LayoutTests
[EFL][GTK] Skip http/tests/xmlhttprequest/origin-exact-matching.html added in r119911
https://bugs.webkit.org/show_bug.cgi?id=88728
Unreviewed gardening. Skip new test added in r119911 which fails for both
GTK and EFL ports.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 8:29 AM Changeset in webkit [119930] by
-
- 2 edits in trunk/LayoutTests
[EFL] Several test cases can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=88731
Unreviewed EFL gardening. Unskip a few tests that are passing after
r118618 was rolled out.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10
- platform/efl/TestExpectations:
- 7:53 AM Changeset in webkit [119929] by
-
- 3 edits in trunk/LayoutTests
[EFL] skip userscripts/window-onerror-for-isolated-world-*.html tests
https://bugs.webkit.org/show_bug.cgi?id=88730
Unreviewed EFL gardening. Skip a few tests causing flakiness.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- 7:21 AM Changeset in webkit [119928] by
-
- 5 edits2 copies2 adds in trunk/Source/WebKit2
[EFL][WK2] Add and refactor ewk API in order to support MiniBrowser without WK API.
https://bugs.webkit.org/show_bug.cgi?id=84124
Reviewed by Chang Shu.
Modify ewk_view and add ewk_context to provide a platform-depedent WebKit2
API.
This patch provides the minimum to support MiniBrowser.
- PlatformEfl.cmake: add ewk_context.cpp.
- UIProcess/API/efl/EWebKit2.h: Added.
- UIProcess/API/efl/ewk_context.cpp: Added.
(_Ewk_Context):
(createDefaultWebContext):
(ewk_context_WKContext_get):
(ewk_context_default_get):
- UIProcess/API/efl/ewk_context.h: Added.
- UIProcess/API/efl/ewk_context_private.h: Added.
- UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_del):
(ewk_view_base_add):
(ewk_view_add_with_context):
(ewk_view_add):
(ewk_view_uri_set):
(ewk_view_uri_get):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_private.h:
- 6:44 AM Changeset in webkit [119927] by
-
- 2 edits in trunk/Source/WebCore
[Qt][Win] Fix building Source/WebCore/plugins/win/PluginViewWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=88308
Reviewed by Simon Hausmann.
No new tests, just a build fix.
Use ownerWindow() from page client. It has been
introduced for x11 plugins to solve exactly the
same problem.
- plugins/win/PluginViewWin.cpp:
(windowHandleForPageClient):
- 5:49 AM Changeset in webkit [119926] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Build fix for !ENABLE(JIT) after r119844 and r119925.
- runtime/Executable.h:
(ExecutableBase):
(JSC::ExecutableBase::clearCodeVirtual):
- 5:25 AM Changeset in webkit [119925] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Build fix for !ENABLE(JIT) after r119844.
- runtime/Executable.h:
(ExecutableBase):
(JSC):
- 5:09 AM Changeset in webkit [119924] by
-
- 2 edits in trunk/Source/WebCore
[Qt][Win] Fix building ImageQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=88306
Reviewed by Simon Hausmann.
No new tests, this is just a build fix.
- platform/graphics/qt/ImageQt.cpp:
(WebCore):
(WebCore::BitmapImage::create):
Adapt to the "API" changes in Qt.
- 4:43 AM Changeset in webkit [119923] by
-
- 3 edits in trunk/LayoutTests
[EFL][GTK] Skip media/track/track-cue-rendering-inner-timestamps.html added in r119907
https://bugs.webkit.org/show_bug.cgi?id=88726
Unreviewed gardening. Skip test added in r119907 for GTK and EFL ports.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
Jun 9, 2012:
- 11:36 PM Changeset in webkit [119922] by
-
- 2 edits in trunk/Source/WebCore
Make WebGL mark draws for compositing even if the draw count is zero
https://bugs.webkit.org/show_bug.cgi?id=88718
Patch by Gregg Tavares <gman@google.com> on 2012-06-09
Reviewed by Kenneth Russell.
No new tests as no new functionality.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
- 11:31 PM Changeset in webkit [119921] by
-
- 8 edits14 deletes in trunk
[Chromium] Remove JavaScriptCore dependencies from gyp
https://bugs.webkit.org/show_bug.cgi?id=88510
Reviewed by Adam Barth.
Chromium doesn't support JSC any more and there doesn't seem to be
a strong interest in using GYP as the common build system in other
ports.
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCore.gyp: WebCore still depends on YARR interpreter.
- JavaScriptCore.gypi: Only include YARR source.
- gyp/JavaScriptCore.gyp: Removed.
- gyp/gtk.gyp: Removed.
Source/WebCore:
No new functionality => No new tests.
- gyp/WebCore.gyp: Removed.
- gyp/copy-forwarding-and-icu-headers.sh: Removed.
- gyp/copy-inspector-resources.sh: Removed.
- gyp/generate-derived-sources.sh: Removed.
- gyp/generate-webcore-export-file-generator.sh: Removed.
- gyp/gtk.gyp: Removed.
- gyp/run-if-exists.sh: Removed.
- gyp/streamline-inspector-source.sh: Removed.
- gyp/update-info-plist.sh: Removed.
Source/WTF:
- WTF.gyp/WTF.gyp:
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- Scripts/generate-project-files: Removed.
- 7:45 PM Changeset in webkit [119920] by
-
- 2 edits in trunk/LayoutTests
Remove a Chromium test expectation for the test that has been rolled out in r119918.
- platform/chromium/TestExpectations:
- 6:08 PM Changeset in webkit [119919] by
-
- 2 edits in trunk/Source/WebCore
Refactor and improve code style in TextResourceDecoder to prepare for buffering improvement
https://bugs.webkit.org/show_bug.cgi?id=88566
Reviewed by Alexey Proskuryakov.
- loader/TextResourceDecoder.cpp:
(WebCore::bytesEqual): Added helper function to make comparing against sequences of bytes
easier to read at the call site.
(WebCore::KanjiCode::judge): Changed to use bytesEqual in a few places, merged multiple if
statements, got rid of else after goto.
(WebCore::TextResourceDecoder::checkForCSSCharset): Changed to use early return instead of
nesting the whole function. Changed to use bytesEqual.
(WebCore::skipComment): Changed to use early return for more cases. Changed to use bytesEqual.
(WebCore::TextResourceDecoder::checkForHeadCharset): Changed to use bytesEqual.
(WebCore::TextResourceDecoder::decode): Changed to use emptyString() instead of "", since
the former is more efficient.
- 4:03 PM Changeset in webkit [119918] by
-
- 21 edits4 deletes in trunk
Unreviewed, rolling out r118618 and r119353.
http://trac.webkit.org/changeset/118618
http://trac.webkit.org/changeset/119353
https://bugs.webkit.org/show_bug.cgi?id=88720
Caused at least 30 different crashes on ClusterFuzz (Requested
by inferno-sec on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-09
Source/WebCore:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::allClientsRemoved):
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::allClientsRemoved):
- loader/cache/CachedFont.h:
(WebCore::CachedFontClient::resourceClientType):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::removeClientForRenderer):
(WebCore):
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::lookupOrCreateImageForRenderer):
- loader/cache/CachedImage.h:
(CachedImage):
(WebCore::CachedImageClient::resourceClientType):
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::allClientsRemoved):
(WebCore):
- loader/cache/CachedRawResource.h:
(CachedRawResource):
(WebCore::CachedRawResourceClient::resourceClientType):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::removeClient):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::allClientsRemoved):
- loader/cache/CachedResourceClient.h:
(WebCore::CachedResourceClient::resourceClientType):
- loader/cache/CachedSVGDocument.h:
(WebCore::CachedSVGDocumentClient::resourceClientType):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::allClientsRemoved):
- loader/cache/CachedStyleSheetClient.h:
(WebCore::CachedStyleSheetClient::resourceClientType):
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::removeClient):
- rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::removeClient):
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeRendererFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndScales):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):
- svg/graphics/SVGImageCache.h:
(WebCore):
(SVGImageCache):
LayoutTests:
- http/tests/cache/cancel-in-progress-load-expected.txt: Removed.
- http/tests/cache/cancel-in-progress-load.html: Removed.
- http/tests/misc/write-while-waiting.html:
- svg/as-image/svg-image-leak-cached-data-expected.txt: Removed.
- svg/as-image/svg-image-leak-cached-data.html: Removed.
- 2:38 PM Changeset in webkit [119917] by
-
- 2 edits in trunk/LayoutTests
Fix Chromium test expectations after my previous commit (r119916).
- platform/chromium/TestExpectations:
- 1:57 PM Changeset in webkit [119916] by
-
- 2 edits in trunk/LayoutTests
Spring CRASH cleanup of Chromium test expectations.
Removed a whole bunch of bogus CRASH test expectations.
- platform/chromium/TestExpectations:
- 12:58 PM Changeset in webkit [119915] by
-
- 2 edits in trunk/LayoutTests
Remove bogus CRASH expectations from skipped tests.
There's no point in specifying test expectation when tests are skipped.
- platform/chromium/TestExpectations:
- 12:37 PM Changeset in webkit [119914] by
-
- 3 edits4 adds in trunk
Fixed-position foreignObject descendants should be relative to the foreignObject viewport
https://bugs.webkit.org/show_bug.cgi?id=88547
Reviewed by Abhishek Arya.
Source/WebCore:
Tests: svg/foreignObject/fO-fixed-position-crash.html
svg/foreignObject/fixed-position-expected.svg
svg/foreignObject/fixed-position.svg
Fixed position elements are currently registered with the top level
RenderView even when embedded within an SVG foreignOject. This patch
changes containingBlock() & container() to return the containing
foreignObject renderer instead.
The new foreignObject fixed position behavior matches that of current
FireFox and Opera versions and is consistent with the spec:
http://www.w3.org/TR/CSS2/visuren.html#fixed-positioning
http://www.w3.org/TR/SVG/coords.html#EstablishingANewViewport
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::container):
LayoutTests:
- svg/foreignObject/fO-fixed-position-crash-expected.txt: Added.
- svg/foreignObject/fO-fixed-position-crash.html: Added.
- svg/foreignObject/fixed-position-expected.svg: Added.
- svg/foreignObject/fixed-position.svg: Added.
- 12:35 PM Changeset in webkit [119913] by
-
- 7 edits3 adds in trunk
Can't use eval in iframes sanbdoxed via CSP header
https://bugs.webkit.org/show_bug.cgi?id=88450
Reviewed by Mihai Parparita.
Source/WebCore:
The initial empty document in a frame inherits the security context of
its parent (including the CSP policy). When we load the real document,
in some cases we'll do a "secure transition" to the new document. That
means that we leave the global object in place in case the parent
document has created any properties that it expects will be visible to
the new document.
If the parent document has a CSP policy that blocks eval, the "no eval"
bit will be set on the global object of the initial document. When we
perform a "secure transition" to the new document, we'll keep the bit,
which is wrong. In this patch, we reset the bit by always enabling
eval when clearing the context, regardless of whether we're performing
a "secure transition".
Test: http/tests/security/contentSecurityPolicy/iframe-inside-csp.html
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::enableEval):
(WebCore):
- bindings/js/ScriptController.h:
(ScriptController):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::enableEval):
(WebCore):
(WebCore::ScriptController::disableEval):
- bindings/v8/ScriptController.h:
(ScriptController):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):
LayoutTests:
- http/tests/security/contentSecurityPolicy/iframe-inside-csp-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/iframe-inside-csp.html: Added.
- http/tests/security/contentSecurityPolicy/resources/sandboxed-eval.php: Added.
- 12:14 PM Changeset in webkit [119912] by
-
- 3 edits in trunk/LayoutTests
[EFL] skip new tests added in r119883
https://bugs.webkit.org/show_bug.cgi?id=88716
Unreviewed EFL gardening. Skip new tests added in r119883.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-09
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- 11:42 AM Changeset in webkit [119911] by
-
- 4 edits3 adds in trunk
The value in Access-Control-Allow-Origin is not being matched correctly for CORS-enabled requests
https://bugs.webkit.org/show_bug.cgi?id=88139
Patch by Pablo Flouret <pablof@motorola.com> on 2012-06-09
Reviewed by Adam Barth.
Source/WebCore:
Compare a request's origin with the value given in any
Access-Control-Allow-Origin headers in an exact, case-sensitive manner,
instead of using SecurityOrigin::isSameSchemeHostPort(). Per step 3 of
the resource sharing check algorithm in
http://dvcs.w3.org/hg/cors/raw-file/tip/Overview.html#resource-sharing-check
Test: http/tests/xmlhttprequest/origin-exact-matching.html
- loader/CrossOriginAccessControl.cpp:
(WebCore::passesAccessControlCheck):
LayoutTests:
- http/tests/xmlhttprequest/origin-exact-matching-expected.txt: Added.
- http/tests/xmlhttprequest/origin-exact-matching.html: Added.
- http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Get rid of a trailing slash in the origin.
- http/tests/xmlhttprequest/resources/origin-exact-matching-iframe.html: Added.
- 11:26 AM Changeset in webkit [119910] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip tests that rely on pathToLocalResource() due to regression in r119788
https://bugs.webkit.org/show_bug.cgi?id=88714
Unreviewed EFL gardening. Skip tests that rely on pathToLocalResource()
due to regression in r119788.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-09
- platform/efl/TestExpectations:
- 10:34 AM Changeset in webkit [119909] by
-
- 6 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling back in part2 of r118646.
This patch removes eager finalization.
Weak pointer finalization should be lazy
https://bugs.webkit.org/show_bug.cgi?id=87599
Reviewed by Sam Weinig.
- heap/Heap.cpp:
(JSC::Heap::collect): Don't finalize eagerly -- we'll do it lazily.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep): Do sweep weak sets when sweeping a block,
since we won't get another chance.
- heap/MarkedBlock.h:
(JSC::MarkedBlock::sweepWeakSet):
- heap/MarkedSpace.cpp:
(MarkedSpace::WeakSetSweep):
- heap/MarkedSpace.h:
(JSC::MarkedSpace::sweepWeakSets): Removed now-unused code.
- 10:11 AM Changeset in webkit [119908] by
-
- 3 edits in trunk/Source/WebCore
[Qt][Texmap] All layers with backingStore are opaque when using TextureMapperGL.
https://bugs.webkit.org/show_bug.cgi?id=88703
The bug originated from StillImage that is not override
Image::currentFrameHasAlpha(), so it always returns false.
StillImage is used by ImageBuffer, and if Texmap draws contents on ImageBuffer,
TextureMapperBackingStore thinks contents does not have alpha.
Covered by existing compositing tests.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-09
Reviewed by Noam Rosenthal.
- platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::currentFrameHasAlpha):
(WebCore):
- platform/graphics/qt/StillImageQt.h:
(StillImage):
- 10:01 AM Changeset in webkit [119907] by
-
- 7 edits3 adds in trunk
Basic support for timestamps within a TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=88187
Implemented support for timestamps within a TextTrackCue.
This enables rendering functionality for Karaoke and Paint-on captions.
Patch by Victor Carbune <victor@rosedu.org> on 2012-06-09
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-cue-rendering-inner-timestamps.html
- css/mediaControls.css: Remove the background shadow pseudo-id and
added two others, which can be further used for styling past / future
contents of the cue.
(video::-webkit-media-text-track-past-nodes): Used to style elements
within the cue that are before the current movie time.
(video::-webkit-media-text-track-future-nodes): Used to style elements
within the cue that are after the current movie time.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Regardless of whether
the active set changed or not, the current cues need to be informed of the current
movie time.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue): Initiliazed past and future containers.
(WebCore::TextTrackCue::getCueAsHTML): Checked whether the current cue text has
inner timestamps or not, in order to render faster if no timestamps are there.
(WebCore::TextTrackCue::updateDisplayTree): Added method that keeps the past and future
containers up to date, given a current movie time.
(WebCore):
(WebCore::TextTrackCue::getDisplayTree): Replaced the cue background container with the
past cues container. The *internal* display tree of the cue now has two containers,
representing past and future elements.
- html/track/TextTrackCue.h: Added several variables to support the new functionality.
(TextTrackCue):
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken): Updated representation for this patch.
- html/track/WebVTTParser.h:
(WebVTTParser): Made public the collectTimeStamp method, as this is required for
parsing timestamps within a cue as well.
LayoutTests:
- media/track/captions-webvtt/captions-inner-timestamps.vtt: Added.
- media/track/track-cue-rendering-inner-timestamps-expected.txt: Added.
- media/track/track-cue-rendering-inner-timestamps.html: Added.
- 9:53 AM Changeset in webkit [119906] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Open links in Sources panel by default and fallback to Resources and Network panel otherwise.
https://bugs.webkit.org/show_bug.cgi?id=88710
Reviewed by Pavel Feldman.
- inspector/front-end/inspector.js:
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector._showAnchorLocation):
- 9:48 AM Changeset in webkit [119905] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Only expand root domain in Sources/Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=88135
Reviewed by Pavel Feldman.
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorTreeOutline._treeElementsCompare.compare.typeWeight):
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
- 9:46 AM Changeset in webkit [119904] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Pretty print should respect text editor indent setting.
https://bugs.webkit.org/show_bug.cgi?id=88713
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptFormatter.js:
- 9:29 AM Changeset in webkit [119903] by
-
- 2 edits in trunk/Source/WebCore
Fixed the build after r119895.
- WebCore.xcodeproj/project.pbxproj:
- 6:18 AM Changeset in webkit [119902] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [refactoring] rename TimelineVerticalOverview into TimelineFrameOverview
https://bugs.webkit.org/show_bug.cgi?id=88708
Reviewed by Vsevolod Vlasov.
- rename TimelineVerticalOverview to TimelineFrameOverview;
- rename associated fields, parameters, CSS classes etc;
- rename overview mode designators to match the UI;
- drop unused CSS rules for old-style mode selector;
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showEvents):
(WebInspector.TimelineOverviewPane.prototype._showFrames):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.addFrame):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineFrameOverview):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._shouldShowFrames):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
- inspector/front-end/timelinePanel.css:
(.timeline-frame-overview #timeline-overview-grid):
(.timeline-frame-overview .timeline-overview-window):
(.timeline-frame-overview .timeline-overview-dividers-background):
(.timeline-frame-overview #timeline-overview-memory):
(.timeline-frame-overview-status-bar-item.toggled-on .glyph):
(.timeline-frame-overview-bars):
(.timeline.timeline-frame-overview .resources-divider):
(.sidebar-tree-item .timeline-frame-overview-status-bar-item):
- 5:01 AM Changeset in webkit [119901] by
-
- 10 edits in trunk
IndexedDB: Inspector should handle null, string, and array keyPaths
https://bugs.webkit.org/show_bug.cgi?id=84303
Reviewed by Pavel Feldman.
Source/WebCore:
Supported different key path types and updated tests to cover each case.
Key path strings are now highlighted in the DataGrid column headers.
- inspector/Inspector.json:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.idbKeyPathFromKeyPath):
(WebInspector.IndexedDBModel.keyPathStringFromIDBKeyPath):
(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.ObjectStore.prototype.get keyPathString):
(WebInspector.IndexedDBModel.Index.prototype.get keyPathString):
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._createDataGrid):
(WebInspector.IDBDataView.prototype._keyColumnHeaderFragment):
(WebInspector.IDBDataView.prototype._keyPathStringFragment):
(WebInspector.IDBDataGridNode.prototype.createCell):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBObjectStoreTreeElement.prototype._updateTooltip):
(WebInspector.IDBIndexTreeElement.prototype._updateTooltip):
LayoutTests:
- http/tests/inspector/indexeddb/database-structure-expected.txt:
- http/tests/inspector/indexeddb/database-structure.html:
- 4:49 AM Changeset in webkit [119900] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening failure case on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=88656
Unreviewed EFL gardening after r119795. jquery/core.html test
is crashing on debug bot and failing with a text diff on
release bot.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-09
- platform/efl/TestExpectations:
- 4:25 AM Changeset in webkit [119899] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Increase size limits for resource content cached in InspectorResourceAgent.
https://bugs.webkit.org/show_bug.cgi?id=88674
Reviewed by Pavel Feldman.
- inspector/NetworkResourcesData.cpp:
- 4:23 AM Changeset in webkit [119898] by
-
- 18 edits in trunk
Web Inspector: Limit DebuggerAgent.Location use to DebuggerModel only, introduce WebInspector.RawLocation to be used elsewhere.
https://bugs.webkit.org/show_bug.cgi?id=87270
Reviewed by Pavel Feldman.
Source/WebCore:
Introduced WebInspector.RawLocation interface, a generic raw location independent from concrete domain (Styles, Debugger).
Made WebInspector.DebuggerModel.Location implement it and switched all debugger related methods to it.
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._breakpointResolved):
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype.continueToLocation):
(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
(WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.prototype._breakpointResolved):
(WebInspector.DebuggerModel.prototype.createRawLocation):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):
(WebInspector.DebuggerModel.prototype.setSelectedCallFrame):
(WebInspector.DebuggerModel.prototype.createLiveLocation):
(WebInspector.DebuggerModel.CallFrame.prototype.get location):
(WebInspector.DebuggerModel.CallFrame.prototype.createLiveLocation):
- inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):
(WebInspector.DebuggerResourceBinding.prototype.setContent.get if):
(WebInspector.DebuggerResourceBinding.prototype.setContent):
(WebInspector.DebuggerResourceBinding.prototype._setContentWithInitialContent):
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):
- inspector/front-end/Linkifier.js:
- inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
- inspector/front-end/PresentationConsoleMessageHelper.js:
- inspector/front-end/RawSourceCode.js:
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
- inspector/front-end/Script.js:
(WebInspector.Script.prototype.rawLocationToUILocation):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.SnippetScriptMapping.prototype.rawLocationToUILocation):
- inspector/front-end/SourceMapping.js:
- inspector/front-end/UISourceCode.js:
(WebInspector.RawLocation):
LayoutTests:
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/pause-in-inline-script.html:
- 3:16 AM Changeset in webkit [119897] by
-
- 15 edits in trunk/Source
Web Inspector: Add message loop instrumentation to public API and timeline agent
https://bugs.webkit.org/show_bug.cgi?id=88639
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-06-09
Reviewed by Vsevolod Vlasov.
Message loop instrumentation will show when the render thread is busy.
That way developer can discover if a render thread business causes low fps, or not.
Source/WebCore:
- inspector/InspectorClient.h:
(WebCore::InspectorClient::startMessageLoopMonitoring): Starts observer.
(WebCore::InspectorClient::stopMessageLoopMonitoring): Stops observer.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
Changed timeline agent constructor parameters.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willProcessTaskImpl):
Forwards observer notification.
(WebCore):
(WebCore::InspectorInstrumentation::didProcessTaskImpl):
Ditto.
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willProcessTask):
Ditto.
(WebCore):
(WebCore::InspectorInstrumentation::didProcessTask):
Ditto.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start):
Starts observer.
(WebCore::InspectorTimelineAgent::stop):
Stops observer.
(WebCore::InspectorTimelineAgent::supportsFrameInstrumentation):
Changed result origin.
(WebCore::InspectorTimelineAgent::willProcessTask):
Noop implementqation.
(WebCore):
(WebCore::InspectorTimelineAgent::didProcessTask):
Noop implementqation.
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
Changed constructor parameters.
- inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::create):
Ditto.
(InspectorTimelineAgent):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
Changed timeline agent constructor parameters.
Source/WebKit/chromium:
- public/WebDevToolsAgent.h:
(WebDevToolsAgent):
- public/WebDevToolsAgentClient.h:
(WebDevToolsAgentClient):
(WebKit::WebDevToolsAgentClient::startMessageLoopMonitoring):
Request message loop notifications.
(WebKit::WebDevToolsAgentClient::stopMessageLoopMonitoring):
Cancel message loop notifications.
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::startMessageLoopMonitoring):
Request message loop notifications.
(WebKit):
(WebKit::InspectorClientImpl::stopMessageLoopMonitoring):
Cancel message loop notifications.
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::startMessageLoopMonitoring):
Request message loop notifications.
(WebKit):
(WebKit::WebDevToolsAgentImpl::stopMessageLoopMonitoring):
Cancel message loop notifications.
(WebKit::WebDevToolsAgentImpl::instrumentWillProcessTask):
Message loop notification.
(WebKit::WebDevToolsAgentImpl::instrumentDidProcessTask):
Ditto.
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
- 3:13 AM Changeset in webkit [119896] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: optimize timeline's frame mode overview appearance for 30fps
https://bugs.webkit.org/show_bug.cgi?id=88556
Reviewed by Vsevolod Vlasov.
- adjust frame overview scale to 30fps == full height by default;
- provide a fall-back auto-scale mode when median frame is longer than 1/30s;
- add horizontal lines for 30 and 60fps;
- drive-by fix: always use same order of categories in frame bars.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames):
(WebInspector.TimelineVerticalOverview.prototype._renderBars):
(WebInspector.TimelineVerticalOverview.prototype._drawFPSMarks):
(WebInspector.TimelineVerticalOverview.prototype._renderBar):
- 2:05 AM Changeset in webkit [119895] by
-
- 35 edits6 adds in trunk
Add UNDO_MANAGER flag
https://bugs.webkit.org/show_bug.cgi?id=87908
Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-06-09
Reviewed by Tony Chang.
.:
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Add undoManager property to document behind the UNDO_MANAGER flag and
add placeholders for some methods of undoManager.
Test: editing/undomanager/document-has-undomanager.html
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore):
(WebCore::Document::undoManager):
- dom/Document.h:
(WebCore):
(Document):
- dom/Document.idl:
- editing/UndoManager.cpp: Added.
(WebCore):
(WebCore::UndoManager::create):
(WebCore::UndoManager::UndoManager):
(WebCore::UndoManager::undo):
(WebCore::UndoManager::redo):
(WebCore::UndoManager::clearUndo):
(WebCore::UndoManager::clearRedo):
- editing/UndoManager.h: Added.
(WebCore):
(UndoManager):
- editing/UndoManager.idl: Added.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
Jun 8, 2012:
- 11:18 PM Changeset in webkit [119894] by
-
- 3 edits in trunk/Tools
webkit-patch land-safely should set cq? if the patch author is not in committers.py
https://bugs.webkit.org/show_bug.cgi?id=88689
Reviewed by Dirk Pranke.
When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
in committers.py or the contributor cannot commit. If anything, the contributor can still
set cq+ on thier patches manually so I don't think this will be an issue for people who
don't list their Bugzille email on committers.py.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._commit_queue_flag):
- Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test_commit_queue_flag):
(test_commit_queue_flag.assert_commit_queue_flag):
- 10:44 PM Changeset in webkit [119893] by
-
- 9 edits2 adds in trunk
RenderLayer::paintChildLayerIntoColumns doesn't properly pixel snap
https://bugs.webkit.org/show_bug.cgi?id=88554
Reviewed by Darin Adler.
Source/WebCore:
Column handling code in RenderLayer and RenderBlock was improperly clipping and translating
using floats derived from FractionalLayoutUnits without pixel snapping. RenderLayer also
improperly stored render tree offsets in ints instead of LayoutUnits. This corrects this
issue.
Test: fast/sub-pixel/column-clipping.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnContents):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintChildLayerIntoColumns):
LayoutTests:
- fast/sub-pixel/column-clipping-expected.html: Added.
- fast/sub-pixel/column-clipping.html: Added.
- platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
- platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
- platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
- platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
- platform/chromium/TestExpectations:
- 10:02 PM Changeset in webkit [119892] by
-
- 4 edits in trunk/LayoutTests
Remove FAIL test expectations from EFL, Mac, and Qt ports' test expectations.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 8:50 PM Changeset in webkit [119891] by
-
- 7 edits2 adds in trunk
REGRESSION(r116487?): HTMLFormElement::elementsname is empty if the form is detached from the document tree
https://bugs.webkit.org/show_bug.cgi?id=88632
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-06-08
Reviewed by Ryosuke Niwa.
Source/WebCore:
Update root node of RadioNodeList when the form element is detached from dom tree.
Test: fast/forms/radionodelist-whose-form-element-detached-from-domtree.html
- dom/Node.cpp:
(WebCore::Node::resetCachedRadioNodeListRootNode):
New function to update the root node of RadioNodeLists to form element from document.
- dom/Node.h: Ditto.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::removedFrom):
On detach, we update the root node of all RadioNodeLists of this form element.
- html/RadioNodeList.cpp:
(WebCore::RadioNodeList::setRootElement):
Setter for updating root node.
- html/RadioNodeList.h:
(RadioNodeList): Ditto.
LayoutTests:
- fast/forms/radionodelist-whose-form-element-detached-from-domtree-expected.txt: Added.
- fast/forms/radionodelist-whose-form-element-detached-from-domtree.html: Added.
- 8:04 PM Changeset in webkit [119890] by
-
- 2 edits in trunk/Tools
remove obsolete NewRunWebKitTests buildbot master factory classes
https://bugs.webkit.org/show_bug.cgi?id=88693
Reviewed by Ryosuke Niwa.
I believe these aren't used any more ...
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests.getText2):
(BuildAndTestLeaksFactory):
- 7:51 PM Changeset in webkit [119889] by
-
- 3 edits in trunk/LayoutTests
Remove all uses of FAIL test expectation from Chromium test expectations.
- platform/chromium/TestExpectations:
- platform/gtk/TestExpectations:
- 7:45 PM Changeset in webkit [119888] by
-
- 3 edits in trunk/Tools
[Chromium-Android] Build DumpRenderTree with Android SDK
https://bugs.webkit.org/show_bug.cgi?id=88598
Change WebKit side of DRT related code according to some recent changes at chromium side.
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.init):
(ChromiumAndroidPort._path_to_driver):
- 7:29 PM Changeset in webkit [119887] by
-
- 21 edits in trunk/Source
[Chromium] Compositor doesn't support translucent root layers.
https://bugs.webkit.org/show_bug.cgi?id=87821
Patch by David Reveman <reveman@chromium.org> on 2012-06-08
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebLayer.h:
(WebLayer):
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebCore:
Forward the isTransparent WebView setting to WebLayerTreeView,
CCLayerTreeHost and CCLayerTreeHostImpl as hasTransparentBackground.
Use hasTransparentBackground setting to determine how to clear the
root render pass and draw the background. Set opaque flag correctly
on the NonCompositedContentHost's graphics layer to make sure
sub-pixel rendering is not used with a transparent WebView.
Unit tests: CCLayerTreeHostImplTest.hasTransparentBackground
LayerRendererChromiumTest2.opaqueRenderPass
LayerRendererChromiumTest2.transparentRenderPass
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::clearRenderPass):
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setHasTransparentBackground):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::hasTransparentBackground):
(WebCore::CCLayerTreeHostImpl::setHasTransparentBackground):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::CCRenderPass):
- platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore::CCRenderPass::hasTransparentBackground):
(WebCore::CCRenderPass::setHasTransparentBackground):
(CCRenderPass):
Source/WebKit/chromium:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit):
- src/NonCompositedContentHost.h:
(NonCompositedContentHost):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setHasTransparentBackground):
(WebKit):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsTransparent):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- tests/CCLayerTreeHostImplTest.cpp:
- tests/LayerRendererChromiumTest.cpp:
(ClearCountingContext):
(ClearCountingContext::ClearCountingContext):
(ClearCountingContext::clear):
(ClearCountingContext::clearCount):
(TEST):
- 7:26 PM Changeset in webkit [119886] by
-
- 6 edits3 adds in trunk/Source
[chromium] Single thread proxy's animation timer should short circuit if the layer renderer has not been initialized
https://bugs.webkit.org/show_bug.cgi?id=88668
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-08
Reviewed by James Robinson.
Source/WebCore:
Unit test: CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer.runSingleThreaded
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
Source/WebKit/chromium:
- WebKit.gypi:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestWriteLayersRedraw::beginTest):
(WTF::CCLayerTreeHostTestWriteLayersAfterVisible::commitCompleteOnCCThread):
(WTF):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::CCLayerTreeHostTestLayerAddedWithAnimation):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::didAddAnimation):
(CCLayerTreeHostTestLayerAddedWithAnimation):
- tests/CCSingleThreadProxyTest.cpp: Added.
(FakeWebGraphicsContext3DMakeCurrentFails):
(FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::beginTest):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::animateLayers):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::didRecreateContext):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::afterTest):
(TEST_F):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::beginTest):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::animateLayers):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::didRecreateContext):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::didAddAnimation):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::afterTest):
- tests/CCThreadedTest.cpp: Added.
(WebKitTests):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WebKitTests::TestHooks::createContext):
(WebKitTests::MockLayerTreeHostImpl::create):
(WebKitTests::MockLayerTreeHostImpl::beginCommit):
(WebKitTests::MockLayerTreeHostImpl::commitComplete):
(WebKitTests::MockLayerTreeHostImpl::prepareToDraw):
(WebKitTests::MockLayerTreeHostImpl::drawLayers):
(WebKitTests::MockLayerTreeHostImpl::animateLayers):
(WebKitTests::MockLayerTreeHostImpl::lowFrequencyAnimationInterval):
(WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(MockLayerTreeHost):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(MockLayerTreeHostClient):
(WebKitTests::MockLayerTreeHostClient::create):
(WebKitTests::MockLayerTreeHostClient::MockLayerTreeHostClient):
(TimeoutTask):
(WebKitTests::TimeoutTask::TimeoutTask):
(WebKitTests::TimeoutTask::clearTest):
(WebKitTests::TimeoutTask::~TimeoutTask):
(WebKitTests::TimeoutTask::run):
(BeginTask):
(WebKitTests::BeginTask::BeginTask):
(WebKitTests::BeginTask::~BeginTask):
(WebKitTests::BeginTask::run):
(EndTestTask):
(WebKitTests::EndTestTask::EndTestTask):
(WebKitTests::EndTestTask::~EndTestTask):
(WebKitTests::EndTestTask::clearTest):
(WebKitTests::EndTestTask::run):
(WebKitTests::CCThreadedTest::CCThreadedTest):
(WebKitTests::CCThreadedTest::endTest):
(WebKitTests::CCThreadedTest::endTestAfterDelay):
(WebKitTests::CCThreadedTest::postSetNeedsAnimateToMainThread):
(WebKitTests::CCThreadedTest::postAddAnimationToMainThread):
(WebKitTests::CCThreadedTest::postAddInstantAnimationToMainThread):
(WebKitTests::CCThreadedTest::postSetNeedsCommitToMainThread):
(WebKitTests::CCThreadedTest::postAcquireLayerTextures):
(WebKitTests::CCThreadedTest::postSetNeedsRedrawToMainThread):
(WebKitTests::CCThreadedTest::postSetNeedsAnimateAndCommitToMainThread):
(WebKitTests::CCThreadedTest::postSetVisibleToMainThread):
(WebKitTests::CCThreadedTest::postDidAddAnimationToMainThread):
(WebKitTests::CCThreadedTest::doBeginTest):
(WebKitTests::CCThreadedTest::timeout):
(WebKitTests::CCThreadedTest::scheduleComposite):
(WebKitTests::CCThreadedTest::onEndTest):
(WebKitTests::CCThreadedTest::dispatchSetNeedsAnimate):
(WebKitTests::CCThreadedTest::dispatchAddInstantAnimation):
(WebKitTests::CCThreadedTest::dispatchAddAnimation):
(WebKitTests::CCThreadedTest::dispatchSetNeedsAnimateAndCommit):
(WebKitTests::CCThreadedTest::dispatchSetNeedsCommit):
(WebKitTests::CCThreadedTest::dispatchAcquireLayerTextures):
(WebKitTests::CCThreadedTest::dispatchSetNeedsRedraw):
(WebKitTests::CCThreadedTest::dispatchSetVisible):
(WebKitTests::CCThreadedTest::dispatchSetInvisible):
(WebKitTests::CCThreadedTest::dispatchComposite):
(WebKitTests::CCThreadedTest::dispatchDidAddAnimation):
(WebKitTests::CCThreadedTest::runTest):
- tests/CCThreadedTest.h: Added.
(WebCore):
(WebKit):
(WebKitTests):
(TestHooks):
(WebKitTests::TestHooks::beginCommitOnCCThread):
(WebKitTests::TestHooks::commitCompleteOnCCThread):
(WebKitTests::TestHooks::prepareToDrawOnCCThread):
(WebKitTests::TestHooks::drawLayersOnCCThread):
(WebKitTests::TestHooks::animateLayers):
(WebKitTests::TestHooks::willAnimateLayers):
(WebKitTests::TestHooks::applyScrollAndScale):
(WebKitTests::TestHooks::updateAnimations):
(WebKitTests::TestHooks::layout):
(WebKitTests::TestHooks::didRecreateContext):
(WebKitTests::TestHooks::didAddAnimation):
(WebKitTests::TestHooks::didCommit):
(WebKitTests::TestHooks::didCommitAndDrawFrame):
(WebKitTests::TestHooks::scheduleComposite):
(WebKitTests::TestHooks::notifyAnimationStarted):
(WebKitTests::TestHooks::notifyAnimationFinished):
(CCThreadedTest):
(WebKitTests::CCThreadedTest::clearTimeout):
(WebKitTests::CCThreadedTest::clearEndTestTask):
(WebKitTests::CCThreadedTest::layerTreeHost):
(CCThreadedTestThreadOnly):
(WebKitTests::CCThreadedTestThreadOnly::runTestThreaded):
(MockLayerTreeHostImpl):
(CompositorFakeWebGraphicsContext3DWithTextureTracking):
- 7:00 PM Changeset in webkit [119885] by
-
- 1 edit8 adds in trunk/LayoutTests
Last set of chromium rebaselines missed in r119875.
- platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
- platform/chromium-linux/svg/custom/js-update-container-expected.png: Added.
- platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.png: Added.
- platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.png: Added.
- platform/chromium-linux/svg/custom/js-update-transform-addition-expected.png: Added.
- platform/chromium-linux/svg/custom/js-update-transform-changes-expected.png: Added.
- platform/chromium-linux/svg/custom/marker-referencePoint-expected.png: Added.
- platform/chromium-linux/svg/custom/non-scaling-stroke-markers-expected.png: Added.
- 6:56 PM Changeset in webkit [119884] by
-
- 7 edits4 adds in trunk
Caret is not rendered in empty inline contenteditable elements
https://bugs.webkit.org/show_bug.cgi?id=85793
Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-06-08
Reviewed by Ryosuke Niwa.
Source/WebCore:
Override localCaretRect in RenderInline. The implementation was almost
identical to localCaretRect in RenderBlock for empty block elements, so
I refactored RenderBlock::localCaretRect and moved the logic to a new
method 'localCaretRectForEmptyElement' in RenderBoxModelObject. The
implementation of 'localCaretRect' in RenderBlock and RenderInline both
use this helper method in RenderBoxModelObject.
Tests: editing/selection/caret-in-empty-inline-1.html
editing/selection/caret-in-empty-inline-2.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::localCaretRect):
Modified to use RenderBoxModelObject::localCaretRectForEmptyElement.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
(WebCore):
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
Add localCaretRectForEmptyElement helper method.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::localCaretRect):
(WebCore):
- rendering/RenderInline.h:
(RenderInline):
Override localCaretRect using localCaretRectForEmptyElement.
LayoutTests:
Add test cases for caret in empty inline.
- editing/selection/caret-in-empty-inline-1-expected.txt: Added.
- editing/selection/caret-in-empty-inline-1.html: Added.
- editing/selection/caret-in-empty-inline-2-expected.txt: Added.
- editing/selection/caret-in-empty-inline-2.html: Added.
- 6:51 PM Changeset in webkit [119883] by
-
- 5 edits4 adds in trunk
Source/WebCore: Treat blob: and filesystem: URLs generated via secure origins as secure.
https://bugs.webkit.org/show_bug.cgi?id=84054
Loading a blob: or filesystem: URL into an iframe or image that's
contained on an HTTPS page shouldn't generate a mixed content warning.
This change adds a SecurityOrigin::isSecure to check both against a
URLs protocol, and the protocol of it's so-called "inner URL" if it's
the type of URL that has such a thing. These sorts of URLs which are
generated from secure sources will themselves be treated as secure.
Patch by Mike West <mkwst@chromium.org> on 2012-06-08
Reviewed by Adam Barth.
Tests: http/tests/security/mixedContent/blob-url-in-iframe.html
http/tests/security/mixedContent/filesystem-url-in-iframe.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::isMixedContent):
- page/SecurityOrigin.cpp:
(WebCore):
(WebCore::SecurityOrigin::isSecure):
- page/SecurityOrigin.h:
(SecurityOrigin):
LayoutTests: Excluding blob: and filesystem: schemes from the mixed content check.
https://bugs.webkit.org/show_bug.cgi?id=84054
Patch by Mike West <mkwst@chromium.org> on 2012-06-08
Reviewed by Adam Barth.
- http/tests/security/mixedContent/blob-url-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/blob-url-in-iframe.html: Added.
- http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/filesystem-url-in-iframe.html: Added.
- 5:56 PM Changeset in webkit [119882] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] [TextureMapperGL] Nvidia card does not update WebGL texture when interacting with canvas
https://bugs.webkit.org/show_bug.cgi?id=87797
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-08
Reviewed by Philippe Normand.
No new tests. WebGL is already covered by WebGL tests and this
bug is only present on certain hardware.
After resolving multisampling before drawing the texture via the
TextureMapper, first rebind the multisampling framebuffer. This ensures
that the texture isn't active in two framebuffers at a time.
- platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper): Rebind the multisampling
framebuffer.
- 5:46 PM Changeset in webkit [119881] by
-
- 2 edits in trunk/Source/WebKit2
[WinCairo] Build fix after Windows export definition file change.
- win/WebKit2CFLite.def: This file needs to be kept in sync with
WebKit2.def (aside from the WebKitInterface exports.)
- 5:12 PM Changeset in webkit [119880] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix crash on PagePopupChromeClient
https://bugs.webkit.org/show_bug.cgi?id=88675
Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-08
Reviewed by Antonio Gomes.
PR 163672.
Actually it's the bug inside InputHandler, should delete the old popup and create a new one,
because update() is problematic. Also no need to save pointer in InputHandler.
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::openPagePopup):
(WebCore::ChromeClientBlackBerry::closePagePopup):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::~InputHandler):
(BlackBerry::WebKit::InputHandler::openSelectPopup):
- WebKitSupport/InputHandler.h:
(WebCore):
(InputHandler):
- 5:07 PM Changeset in webkit [119879] by
-
- 3 edits2 adds in trunk
[BlackBerry] Default font settings are getting deleted
https://bugs.webkit.org/show_bug.cgi?id=88670
Reviewed by Rob Buis.
Source/WebKit/blackberry:
RIM PR: 163720
WebSettings is overriding the default font settings with "", which deletes them.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
LayoutTests:
This test crashes if -webkit-body (i.e. WebCore::Settings::standardFontFamily())
is not a valid font family.
- fonts/valid-standard-font.html: Added.
- 4:57 PM Changeset in webkit [119878] by
-
- 6 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling back in part1 of r118646.
This patch includes everything necessary for lazy finalization, but
keeps eager finalization enabled for the time being.
Weak pointer finalization should be lazy
https://bugs.webkit.org/show_bug.cgi?id=87599
Reviewed by Sam Weinig.
- heap/MarkedBlock.cpp:
- heap/MarkedBlock.h:
(JSC::MarkedBlock::resetAllocator):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::resetAllocators):
- heap/MarkedSpace.h:
(JSC::MarkedSpace::resetAllocators): Don't force allocator reset anymore.
It will happen automatically when a weak set is swept. It's simpler to
have only one canonical way for this to happen, and it wasn't buying
us anything to do it eagerly.
- heap/WeakBlock.cpp:
(JSC::WeakBlock::sweep): Don't short-circuit a sweep unless we know
the sweep would be a no-op. If even one finalizer is pending, we need to
run it, since we won't get another chance.
- heap/WeakSet.cpp:
(JSC::WeakSet::sweep): This loop can be simpler now that
WeakBlock::sweep() does what we mean.
Reset our allocator after a sweep because this is the optimal time to
start trying to recycle old weak pointers.
(JSC::WeakSet::tryFindAllocator): Don't sweep when searching for an
allocator because we've swept already, and forcing a new sweep would be
wasteful.
- heap/WeakSet.h:
(JSC::WeakSet::shrink): Be sure to reset our allocator after a shrink
because the shrink may have removed the block the allocator was going to
allocate out of.
- 4:54 PM Changeset in webkit [119877] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/11412294> Add appropriate iOS default font settings
Reviewed by Dan Bernstein.
- page/mac/SettingsMac.mm: (WebCore::Settings::initializeDefaultFontFamilies):
- 4:41 PM Changeset in webkit [119876] by
-
- 3 edits in trunk/Source/WebCore
IndexedDB: Transactions without any request scheduled should abort itself.
https://bugs.webkit.org/show_bug.cgi?id=88052
Reviewed by Kentaro Hara.
This is needed for indexedDB to make it work for JSC. We need to clean up all the
pending transactions(transactions without any request scheduled) when leaving Javascript context.
Manually tested using the existing test LayoutTests/storage/indexeddb/tutorial.html
- bindings/js/JSMainThreadExecState.cpp:
(WebCore):
(WebCore::JSMainThreadExecState::didLeaveScriptContext):
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
(JSMainThreadExecState):
- 4:18 PM Changeset in webkit [119875] by
-
- 34 edits9 copies8 adds1 delete in trunk/LayoutTests
Final set of chromium rebaselines for skia change. See crbug.com/131829.
- platform/chromium-linux/svg/clip-path/clipper-placement-issue-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
- platform/chromium-linux/svg/css/arrow-with-shadow-expected.png: Added.
- platform/chromium-linux/svg/css/background-image-svg-expected.png: Added.
- platform/chromium-linux/svg/custom/broken-internal-references-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png.
- platform/chromium-linux/svg/custom/dynamic-empty-path-expected.png: Added.
- platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.png: Added.
- platform/chromium-linux/svg/custom/svgpolyparser-extra-space-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
- platform/chromium-linux/svg/custom/use-forward-refs-expected.png: Added.
- platform/chromium-linux/svg/custom/use-on-clip-path-with-transformation-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png.
- platform/chromium-linux/svg/text/text-hkern-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
- platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
- platform/chromium-linux/svg/text/text-vkern-expected.png: Added.
- platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png.
- platform/chromium-linux/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png.
- platform/chromium-linux/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
- platform/chromium-win-xp/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Removed.
- platform/chromium-win/svg/custom/js-late-marker-creation-expected.png:
- platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png:
- platform/chromium-win/svg/custom/js-update-bounce-expected.png:
- platform/chromium-win/svg/custom/js-update-container-expected.png:
- platform/chromium-win/svg/custom/js-update-path-changes-expected.png:
- platform/chromium-win/svg/custom/js-update-path-removal-expected.png:
- platform/chromium-win/svg/custom/js-update-polygon-changes-expected.png:
- platform/chromium-win/svg/custom/js-update-polygon-removal-expected.png:
- platform/chromium-win/svg/custom/js-update-transform-addition-expected.png:
- platform/chromium-win/svg/custom/js-update-transform-changes-expected.png:
- platform/chromium-win/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
- platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
- platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.png:
- platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/chromium-win/svg/custom/linking-a-03-b-viewTarget-expected.png:
- platform/chromium-win/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
- platform/chromium-win/svg/custom/linking-uri-01-b-expected.png:
- platform/chromium-win/svg/custom/marker-changes-expected.png:
- platform/chromium-win/svg/custom/marker-child-changes-css-expected.png:
- platform/chromium-win/svg/custom/marker-child-changes-expected.png:
- platform/chromium-win/svg/custom/marker-opacity-expected.png:
- platform/chromium-win/svg/custom/marker-referencePoint-expected.png:
- platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png:
- platform/chromium-win/svg/custom/marker-viewBox-changes-expected.png:
- platform/chromium-win/svg/custom/mask-colorspace-expected.png:
- platform/chromium-win/svg/custom/mask-on-multiple-objects-expected.png:
- platform/chromium-win/svg/custom/no-inherited-dashed-stroke-expected.png:
- platform/chromium-win/svg/custom/non-circular-marker-reference-expected.png:
- platform/chromium-win/svg/custom/non-scaling-stroke-markers-expected.png:
- platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.png:
- platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.png:
- platform/chromium-win/svg/filters/invalidate-on-child-layout-expected.png:
- platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
- platform/chromium/TestExpectations:
- 4:13 PM Changeset in webkit [119874] by
-
- 2 edits in trunk
Fix the GTK+ build when OpenGL is enabled.
- configure.ac: Fix the build.
- 4:13 PM Changeset in webkit [119873] by
-
- 2 edits in trunk/LayoutTests
viewspec-parser tests still timeout in Chromium debug even when marked slow.
- platform/chromium/TestExpectations:
- 4:09 PM Changeset in webkit [119872] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::CompositeEditCommand::breakOutOfEmptyListItem
https://bugs.webkit.org/show_bug.cgi?id=88361
Reviewed by Levi Weintraub.
Use RefPtr instead of raw pointers across DOM mutations.
No tests are added for the lack of a reliable reduction.
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
- 4:00 PM Changeset in webkit [119871] by
-
- 6 edits4 deletes in trunk
Unreviewed, rolling out r119514.
http://trac.webkit.org/changeset/119514
https://bugs.webkit.org/show_bug.cgi?id=88664
Broke JSFiddle.net (Requested by arv on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-08
Source/WebCore:
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initIsolate):
LayoutTests:
- fast/dom/Window/window-property-shadowing-name-expected.txt:
- fast/dom/Window/window-property-shadowing-name.html:
- fast/dom/Window/window-property-shadowing-onclick-expected.txt: Removed.
- fast/dom/Window/window-property-shadowing-onclick.html: Removed.
- platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Removed.
- platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Removed.
- 3:35 PM Changeset in webkit [119870] by
-
- 6 edits in trunk/Source/WebCore
Crash in WebCore::InsertParagraphSeparatorCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=88108
Reviewed by Levi Weintraub.
Use NodeVector instead of walking through siblings as we mutate the DOM.
No new tests are added since there is no reliable reduction.
- editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveRemainingSiblingsToNewParent):
(WebCore):
- editing/CompositeEditCommand.h:
(CompositeEditCommand):
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
- 3:24 PM Changeset in webkit [119869] by
-
- 2 edits in trunk
[GTK] build accelerated compositing on by default if OpenGL is present
https://bugs.webkit.org/show_bug.cgi?id=88677
Reviewed by Alejandro G. Castro.
Build accelerated compositing by default if OpenGL is present, just like WebGL.
Also prevent enabling WebGL if Clutter is turned on.
- configure.ac: Build AC by default.
- 2:59 PM Changeset in webkit [119868] by
-
- 12 edits in trunk/Source
IndexedDB: rename some instances of open to registerFrontendCallbacks
https://bugs.webkit.org/show_bug.cgi?id=88611
Source/WebCore:
We should still make the change in the WebKit API.
Reviewed by Tony Chang.
No new tests, just a method rename.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::registerFrontendCallbacks):
- Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
Source/WebKit/chromium:
Reviewed by Tony Chang.
- src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):
- src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
- src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::open):
- src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
- 2:37 PM Changeset in webkit [119867] by
-
- 5 edits in trunk/Source
[chromium] Skip willDraw() and didDraw() on fully occluded layers
https://bugs.webkit.org/show_bug.cgi?id=88435
Reviewed by Adrienne Walker.
Source/WebCore:
Current willDraw() is called on all layers with non-empty
visibleLayerRect and non-empty scissorRect. This excludes
layers outside the viewport, but does not exclude occluded
layers. We add a check for occlusion to calculateRenderPasses
in order to avoid willDraw() when it will be culled anyway.
We prevent didDraw() from being called for occluded layers, for
which we did not call didDraw() by holding a vector of layers
for which we did call willDraw(). This lets us avoid storing a
flag on the layers, or computing occlusion again in
didDrawAllLayers.
Unit test: CCLayerTreeHostImplTest.willDrawNotCalledOnOccludedLayer
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(FrameData):
(CCLayerTreeHostImpl):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
- 2:37 PM Changeset in webkit [119866] by
-
- 462 edits4 copies9 moves10 adds221 deletes in trunk/LayoutTests
Second wave of Chromium rebaselines after skia change. See crbug.com/131829.
List of changed expectations deleted because it's too long.
- 2:30 PM Changeset in webkit [119865] by
-
- 8 edits in trunk/Source/JavaScriptCore
Unreviewed roll out r119795.
This broke jquery/core.html
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
- llint/LowLevelInterpreter.asm:
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/JSGlobalThis.cpp:
(JSC::JSGlobalThis::setUnwrappedObject):
- runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
(JSC::JSObject::createInheritorID):
- runtime/JSObject.h:
(JSObject):
(JSC::JSObject::resetInheritorID):
(JSC):
(JSC::JSObject::offsetOfInheritorID):
(JSC::JSObject::inheritorID):
- 2:13 PM Changeset in webkit [119864] by
-
- 1 edit2 adds2 deletes in trunk/LayoutTests
Added Mac pixel results for canvas-imageSmoothingEnabled-patterns.html, and made the text
results shared between platforms.
- fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
- platform/chromium/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
- platform/gtk/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
- platform/mac/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
- 2:12 PM Changeset in webkit [119863] by
-
- 3 edits in trunk/LayoutTests
[chromium] Unreviewed, rebaseline a chromium-win result that changed
due to the various mock scrollbar changes.
https://bugs.webkit.org/show_bug.cgi?id=88490
- platform/chromium-win/fast/repaint/fixed-tranformed-expected.png:
- platform/chromium/TestExpectations:
- 1:37 PM Changeset in webkit [119862] by
-
- 2 edits in trunk/Source/WebCore
EventHandler shouldn't schedule the fake mousemove event timer when scrolling on devices that don't have a mouse
https://bugs.webkit.org/show_bug.cgi?id=88379
Reviewed by James Robinson.
Patch by Antonio Gomes <agomes@rim.com>
Paraphrasing Andy Estes:
"In <http://trac.webkit.org/changeset/119465> we stopped dispatching fake
mousemove events when scrolling on devices that don't support mice. This event
is dispatched on a timer, so one better would be to not even schedule the
timer (rather than scheduling the timer but making it a no-op).
No new tests, as no functionality has changed. We basically do not
start a timer under a given circumstance instead of fire it, it times out,
and we make the callback no-op when under the given circumstance.
It is still possible though that we have the following scenario:
- Setting::deviceSupportsMouse set as true;
- we fire the timer;
- before its callback gets executed (timed out) the setting gets toggled.
So for sakeness, lets keep the check in both places.
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
- 1:31 PM Changeset in webkit [119861] by
-
- 4 edits in trunk/Source
[chromium] Clean up some unnecessary LayerChromium.h includes
https://bugs.webkit.org/show_bug.cgi?id=88599
Reviewed by Adam Barth.
Source/WebCore:
Reworks test code slightly to use WebCore interfaces.
- testing/Internals.cpp:
(WebCore::Internals::setBackgroundBlurOnNode):
Source/WebKit/chromium:
Removes unused include, update comment.
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
- 1:13 PM Changeset in webkit [119860] by
-
- 1184 edits93 adds229 deletes in trunk/LayoutTests
WebCore::ImageBuffer.cpp has broken color table code
https://bugs.webkit.org/show_bug.cgi?id=80321
Unreviewed Chromium test expectations update after changes to SVG filter color conversion.
Full list of changed files excluded to to very large number.
- platform/chromium/TestExpectations:
- 1:04 PM Changeset in webkit [119859] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Fix JavaScriptCore/ChangeLog goof, where Geoff's change did not have a date + name + email header
- 1:02 PM Changeset in webkit [119858] by
-
- 2 edits in trunk/Source/JavaScriptCore
PredictedType should be called SpeculatedType
https://bugs.webkit.org/show_bug.cgi?id=88477
Unreviewed, fix a renaming goof from http://trac.webkit.org/changeset/119660.
I accidentally renamed ByteCodeParser::getPrediction to
ByteCodeParser::getSpeculation. That was not the intent. This changes it
back.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):
- 12:57 PM Changeset in webkit [119857] by
-
- 13 edits in trunk/Source
Explictly mark stubs called by JIT as being internal
https://bugs.webkit.org/show_bug.cgi?id=88552
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
- dfg/DFGOSRExitCompiler.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- jit/HostCallReturnValue.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/ThunkGenerators.cpp:
- llint/LLIntSlowPaths.h: Mark a bunch of stubs as being
WTF_INTERNAL. Change most calls to SYMBOL_STRING_RELOCATION to
LOCAL_REFERENCE, or GLOBAL_REFERENCE in the case of the wrappers
to truly global symbols.
- offlineasm/asm.rb: Generate LOCAL_REFERENCE instead of
SYMBOL_STRING_RELOCATION.
Don't rely on weak pointers for eager CodeBlock finalization
https://bugs.webkit.org/show_bug.cgi?id=88465
Reviewed by Gavin Barraclough.
This is incompatible with lazy weak pointer finalization.
I considered just making CodeBlock finalization lazy-friendly, but it
turns out that the heap is already way up in CodeBlock's business when
it comes to finalization, so I decided to finish the job and move full
responsibility for CodeBlock finalization into the heap.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Maybe this
will build.
- debugger/Debugger.cpp: Updated for rename.
- heap/Heap.cpp:
(JSC::Heap::deleteAllCompiledCode): Renamed for consistency. Fixed a bug
where we would not delete code for a code block that had been previously
jettisoned. I don't know if this happens in practice -- I mostly did
this to improve consistency with deleteUnmarkedCompiledCode.
(JSC::Heap::deleteUnmarkedCompiledCode): New function, responsible for
eager finalization of unmarked code blocks.
(JSC::Heap::collect): Updated for rename. Updated to call
deleteUnmarkedCompiledCode(), which takes care of jettisoned DFG code
blocks too.
(JSC::Heap::addCompiledCode): Renamed, since this points to all code
now, not just functions.
- heap/Heap.h:
(Heap): Keep track of all user code, not just functions. This is a
negligible additional overhead, since most code is function code.
- runtime/Executable.cpp:
(JSC::*::finalize): Removed these functions, since we don't rely on
weak pointer finalization anymore.
(JSC::FunctionExecutable::FunctionExecutable): Moved linked-list stuff
into base class so all executables can be in the list.
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::clearCode): All we need to do is delete our
CodeBlock -- that will delete all of its internal data structures.
(JSC::FunctionExecutable::clearCodeIfNotCompiling): Factored out a helper
function to improve clarity.
- runtime/Executable.h:
(JSC::ExecutableBase): Moved linked-list stuff
into base class so all executables can be in the list.
(JSC::NativeExecutable::create):
(NativeExecutable):
(ScriptExecutable):
(JSC::ScriptExecutable::finishCreation):
(JSC::EvalExecutable::create):
(EvalExecutable):
(JSC::ProgramExecutable::create):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::create): Don't use a finalizer -- the heap
will call us back to destroy our code block.
(JSC::FunctionExecutable::discardCode): Renamed to clearCodeIfNotCompiling()
for clarity.
(JSC::FunctionExecutable::isCompiling): New helper function, for clarity.
(JSC::ScriptExecutable::clearCodeVirtual): New helper function, since
the heap needs to make polymorphic calls to clear code.
- runtime/JSGlobalData.cpp:
(JSC::StackPreservingRecompiler::operator()):
- runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Updated for
renames.
Source/WTF:
- wtf/ExportMacros.h (WTF_INTERNAL, HAVE_INTERNAL_VISIBILITY): New
defines. Regardless of what the port does about visibility in
general, for code referenced only from assembly it is useful to
give it internal visibility.
- wtf/InlineASM.h: Split SYMBOL_STRING_RELOCATION into
LOCAL_REFERENCE and GLOBAL_REFERENCE; the former will try to avoid
indirection if HAVE(INTERNAL_VISIBILITY).
- 12:49 PM Changeset in webkit [119856] by
-
- 6 edits in trunk/LayoutTests
IndexedDB: Add regression test to verify that legacy constants have been removed
https://bugs.webkit.org/show_bug.cgi?id=88669
Reviewed by Tony Chang.
- storage/indexeddb/legacy-constants-expected.txt:
- storage/indexeddb/mozilla/create-index-unique-expected.txt:
- storage/indexeddb/mozilla/resources/create-index-unique.js:
(createAndVerifyIndex):
- storage/indexeddb/resources/constants.js:
(test):
- storage/indexeddb/resources/legacy-constants.js:
(testObsoleteConstants):
- 12:25 PM Changeset in webkit [119855] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
First wave of Chromium rebaselines after skia rollback. See crbug.com/131829.
List of changed expected files excluded because it's too long.
- 12:19 PM Changeset in webkit [119854] by
-
- 535 edits21 copies16 moves218 adds15 deletes in trunk/LayoutTests
First wave of Chromium rebaselines after skia rollback. See crbug.com/131289.
List of changed expected files excluded because it's too long.
- 12:05 PM Changeset in webkit [119853] by
-
- 8 edits1 copy in trunk
[V8] Keep TextTrackList alive as long as its owner is alive
https://bugs.webkit.org/show_bug.cgi?id=88541
Reviewed by Adam Barth.
Add a hidden reference from the owner to the text track list.
Source/WebCore:
Covered by existing tests.
- Target.pri: Add V8TextTrackListCustom.cpp.
- UseV8.cmake: Ditto.
- WebCore.gypi: Ditto.
- bindings/v8/V8HiddenPropertyName.h:
(WebCore):
- bindings/v8/custom/V8TextTrackListCustom.cpp: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.
(WebCore):
(WebCore::toV8): When the wrapper is created add a reference to the owner of the TextTrackList to the TextTrackList.
- html/track/TextTrackList.idl:
LayoutTests:
- platform/chromium/TestExpectations:
- 11:53 AM Changeset in webkit [119852] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 11:44 AM Changeset in webkit [119851] by
-
- 2 edits in trunk/Tools
Add app_abi option for DumpRenderTree_apk
https://bugs.webkit.org/show_bug.cgi?id=88626
Patch by Wei James <james.wei@intel.com> on 2012-06-08
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 11:41 AM Changeset in webkit [119850] by
-
- 20 edits2 adds in trunk/Source
[chromium] Accelerated animations should use WebTransformOperations
https://bugs.webkit.org/show_bug.cgi?id=87686
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-08
Reviewed by James Robinson.
CCTransformKeyframe new owns a WebTransformOperations rather than a
TransformOperations. LayerChromium's API has been changed so that
LayerChromium::addAnimation should take only a CCActiveAnimation.
GraphicsLayerChromium is new responsible for translating to
WebTransformOperations and creating CCActiveAnimations. Tests that use
the public API (that is, they call addAnimation with KeyframeValueList
and Animation arguments) have been moved to GraphicsLayerChromiumTest.
Source/WebCore:
Unit tests:
GraphicsLayerChromiumTest.createOpacityAnimation
GraphicsLayerChromiumTest.createTransformAnimation
GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
GraphicsLayerChromiumTest.createTransformAnimationWithSingularMatrix
GraphicsLayerChromiumTest.createReversedAnimation
GraphicsLayerChromiumTest.createAlternatingAnimation
GraphicsLayerChromiumTest.createReversedAlternatingAnimation
- WebCore.gypi:
- platform/graphics/chromium/AnimationTranslationUtil.cpp: Added.
(WebCore):
(WebCore::toWebTransformOperations):
(WebCore::appendKeyframe):
(WebCore::CCKeyframedTransformAnimationCurve):
(WebCore::createActiveAnimation):
- platform/graphics/chromium/AnimationTranslationUtil.h: Added.
(WebCore):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::addAnimation):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::addAnimation):
- platform/graphics/chromium/LayerChromium.h:
(WebCore):
(WebCore::LayerChromium::bounds):
(LayerChromium):
- platform/graphics/chromium/LinkHighlight.cpp:
(WebCore::LinkHighlight::LinkHighlight):
- platform/graphics/chromium/cc/CCAnimationCurve.h:
(CCTransformAnimationCurve):
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:
(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
(CCTransformKeyframe):
(CCKeyframedTransformAnimationCurve):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::removeAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::addAnimation):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):
- platform/graphics/chromium/cc/CCLayerAnimationController.h:
(CCLayerAnimationControllerClient):
(CCLayerAnimationController):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::bounds):
Source/WebKit/chromium:
- tests/CCAnimationTestCommon.cpp:
(WebCore::addOpacityTransition):
(WebCore::addAnimatedTransform):
(WebKitTests::FakeTransformTransition::getValue):
- tests/CCAnimationTestCommon.h:
- tests/CCKeyframedAnimationCurveTest.cpp:
- tests/CCLayerAnimationControllerTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):
- tests/GraphicsLayerChromiumTest.cpp:
(MockLayerTreeHostClient):
(WebKitTests):
(MockLayerTreeHost):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::expectTranslateX):
(WebKitTests::TEST_F):
- tests/LayerChromiumTest.cpp:
- 11:39 AM Changeset in webkit [119849] by
-
- 6 edits in trunk/Source/WebCore
[Texmap] Accelerated versions of drop-shadow and blur filters
https://bugs.webkit.org/show_bug.cgi?id=87695
Reviewed by Kenneth Rohde Christiansen.
Added shaders for blur and drop-shadow effects.
The shaders use sampling of multiple coordinates and averaging them with normal-
distribution to create a fast gaussian blur effect.
Covered by existing tests in css3/filters.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawFiltered):
Call the prepare function explicitly, with a size argument that's used to calculate
some of the uniform values.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::intermediateSurfaceRect):
The outsets of the effect have to be considered when calculating the intermediate rect.
Otherwise the resulting image is scaled instead of outsetted.
(WebCore::applyFilters):
- platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::StandardFilterProgram::StandardFilterProgram):
Added the new shaders.
(WebCore::StandardFilterProgram::prepare):
(WebCore::TextureMapperShaderManager::getShaderForFilter):
- platform/graphics/texmap/TextureMapperShaderManager.h:
(StandardFilterProgram):
- 11:36 AM Changeset in webkit [119848] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix the build after r119844.
- bindings/js/GCController.cpp:
(WebCore::GCController::discardAllCompiledCode):
- 11:34 AM Changeset in webkit [119847] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] [WK2] API tests randomly assert in WebLayerTreeRenderer::assignImageToLayer
https://bugs.webkit.org/show_bug.cgi?id=88667
Reviewed by Noam Rosenthal.
Move deactivation of WebLayerTreeRenderer from LayerTreeHostProxy::purgeBackingStores
to WebLayerTreeRenderer::purgeGLResources. LayerTreeHostProxy::purgeBackingStores is
invoked on main thread after going through call gate and it is too late to deactivate
renderer here, because some update messages are able to go through.
WebLayerTreeRenderer::purgeGLResources is called directly from render node deallocation
and it is right place to deactivate renderer.
- UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::purgeBackingStores):
- UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::purgeGLResources):
- 11:24 AM Changeset in webkit [119846] by
-
- 2 edits in trunk/Source/WebCore
Add COMPILE_ASSERT to StyledElement to ensure it doesn't accidentally grow larger.
https://bugs.webkit.org/show_bug.cgi?id=88627
Patch by Mike West <mkwst@chromium.org> on 2012-06-08
Reviewed by Adam Barth.
No change in user-facing behavior.
- dom/StyledElement.cpp:
(WebCore):
- 11:19 AM Changeset in webkit [119845] by
-
- 2 edits3 adds in trunk/LayoutTests
[chromium] Unreviewed, rebaseline platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html after skia gamma correction
https://bugs.webkit.org/show_bug.cgi?id=88589
- platform/chromium-linux/platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle-expected.png: Added.
- platform/chromium/TestExpectations:
- 11:17 AM Changeset in webkit [119844] by
-
- 9 edits in trunk/Source/JavaScriptCore
Don't rely on weak pointers for eager CodeBlock finalization
https://bugs.webkit.org/show_bug.cgi?id=88465
Reviewed by Gavin Barraclough.
This is incompatible with lazy weak pointer finalization.
I considered just making CodeBlock finalization lazy-friendly, but it
turns out that the heap is already way up in CodeBlock's business when
it comes to finalization, so I decided to finish the job and move full
responsibility for CodeBlock finalization into the heap.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Maybe this
will build.
- debugger/Debugger.cpp: Updated for rename.
- heap/Heap.cpp:
(JSC::Heap::deleteAllCompiledCode): Renamed for consistency. Fixed a bug
where we would not delete code for a code block that had been previously
jettisoned. I don't know if this happens in practice -- I mostly did
this to improve consistency with deleteUnmarkedCompiledCode.
(JSC::Heap::deleteUnmarkedCompiledCode): New function, responsible for
eager finalization of unmarked code blocks.
(JSC::Heap::collect): Updated for rename. Updated to call
deleteUnmarkedCompiledCode(), which takes care of jettisoned DFG code
blocks too.
(JSC::Heap::addCompiledCode): Renamed, since this points to all code
now, not just functions.
- heap/Heap.h:
(Heap): Keep track of all user code, not just functions. This is a
negligible additional overhead, since most code is function code.
- runtime/Executable.cpp:
(JSC::*::finalize): Removed these functions, since we don't rely on
weak pointer finalization anymore.
(JSC::FunctionExecutable::FunctionExecutable): Moved linked-list stuff
into base class so all executables can be in the list.
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::clearCode): All we need to do is delete our
CodeBlock -- that will delete all of its internal data structures.
(JSC::FunctionExecutable::clearCodeIfNotCompiling): Factored out a helper
function to improve clarity.
- runtime/Executable.h:
(JSC::ExecutableBase): Moved linked-list stuff
into base class so all executables can be in the list.
(JSC::NativeExecutable::create):
(NativeExecutable):
(ScriptExecutable):
(JSC::ScriptExecutable::finishCreation):
(JSC::EvalExecutable::create):
(EvalExecutable):
(JSC::ProgramExecutable::create):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::create): Don't use a finalizer -- the heap
will call us back to destroy our code block.
(JSC::FunctionExecutable::discardCode): Renamed to clearCodeIfNotCompiling()
for clarity.
(JSC::FunctionExecutable::isCompiling): New helper function, for clarity.
(JSC::ScriptExecutable::clearCodeVirtual): New helper function, since
the heap needs to make polymorphic calls to clear code.
- runtime/JSGlobalData.cpp:
(JSC::StackPreservingRecompiler::operator()):
- runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Updated for
renames.
- 11:14 AM Changeset in webkit [119843] by
-
- 2 edits in trunk/Source/WebKit/chromium
More than 8 fingers get ignored by touch
https://bugs.webkit.org/show_bug.cgi?id=88359
Reviewed by James Robinson.
- public/WebInputEvent.h: Increase of TouchPoints per TouchEvent from 8 to 12.
- 10:59 AM Changeset in webkit [119842] by
-
- 2 edits in trunk/LayoutTests
Added svg/filters/color-space-conversion.svg to the Mac skip list. It has been failing since
its addition in r119841. <http://webkit.org/b/88672> is tracking the failure.
- platform/mac/Skipped:
- 10:52 AM Changeset in webkit [119841] by
-
- 2 edits in trunk/LayoutTests
WebCore::ImageBuffer.cpp has broken color table code
https://bugs.webkit.org/show_bug.cgi?id=80321
Unreviewed Chromium expectations update.
Adding tests that are failing pending a rebaseline.
- platform/chromium/TestExpectations:
- 10:46 AM Changeset in webkit [119840] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, remove css3/flexbox/child-overflow.html from TestExpectations.
Since bug 77368 is now fixed, this test passes.
- platform/chromium/TestExpectations:
- 9:57 AM Changeset in webkit [119839] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Fix several compiler warnings and errors.
https://bugs.webkit.org/show_bug.cgi?id=88660
Reviewed by Pavel Feldman.
Fixed several compiler warnings and errors.
Removed isEmpty method from Object.prototype and made it static method on Object.
- inspector/InjectedScriptExterns.js:
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._detachFrame):
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildDominatorTree):
- inspector/front-end/utilities.js:
(Object.isEmpty):
- 9:54 AM Changeset in webkit [119838] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Fix assertion failure introduced by bug 87551
https://bugs.webkit.org/show_bug.cgi?id=88659
Patch by Max Feil <mfeil@rim.com> on 2012-06-08
Reviewed by Antonio Gomes.
The determineRenderSlider() convenience function added in bug
87551 made an assumption that wasn't always true. This didn't
cause a functional error but it caused an assertion failure,
which indicates a problem with the code. PR164142.
No new tests because this case is already covered by ASSERT's.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::determineRenderSlider):
- 9:37 AM Changeset in webkit [119837] by
-
- 11 edits3 adds in trunk
[GTK] Add API to get the library version to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=88426
Reviewed by Martin Robinson.
.:
- configure.ac: Generate WebKitVersion.h from WebKitVersion.h.in
file.
Source/WebKit2:
- GNUmakefile.am:
- GNUmakefile.list.am:
- UIProcess/API/gtk/WebKitVersion.cpp: Added.
(webkit_get_major_version):
(webkit_get_minor_version):
(webkit_get_micro_version):
- UIProcess/API/gtk/WebKitVersion.h.in: Added.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new symbols.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new section
for WebKitVersion.
- UIProcess/API/gtk/tests/GNUmakefile.am:
- UIProcess/API/gtk/tests/TestWebKitVersion.cpp: Added.
(testWebKitVersion):
(testWebKitCheckVersion):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/webkit2.h: Include WebKitVersion.h.
Tools:
- gtk/generate-gtkdoc:
(get_webkit2_options): Add built sources to the list of files, but
ignore enum types and marshallers.
- 9:27 AM BuildBot edited by
- FIxed a typo (diff)
- 9:26 AM BuildBot edited by
- Fixed formatting of lists (diff)
- 8:36 AM Changeset in webkit [119836] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix for Chromium TestExpectations.
A file crept into the expectations that has not yet been submitted.
- platform/chromium/TestExpectations:
- 8:35 AM Changeset in webkit [119835] by
-
- 2 edits in trunk/Source/WebKit/qt
Unreviewed, fix file permissions.
- WebCoreSupport/FrameLoaderClientQt.cpp:
- 8:23 AM Changeset in webkit [119834] by
-
- 4 edits1 add in trunk
Some overlay scrollbar API calls in ScrollAnimatorMac can lead to an assertion in RenderBox::mapAbsoluteToLocalPoint
https://bugs.webkit.org/show_bug.cgi?id=74111
Patch by Ion Rosca <Ion Rosca> on 2012-06-08
Reviewed by Simon Fraser.
.:
- ManualTests/scrollbar-crash-on-hide-scrolled-area.html: Added.
Source/WebCore:
Added zero-delay timer for AppKit scroll notification that can be called during layout.
Manual test: ManualTests/scrollbar-crash-on-hide-scrolled-area.html
This assertion does not fire when running layout tests. It can be easly reproduced using a debug build by loading the manual test page.
- platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledSoon):
(WebCore):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):
- 8:20 AM Changeset in webkit [119833] by
-
- 6 edits in trunk
Adding few already supported features to the FeatureSet in DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=86482
Source/WebCore:
Text, Filter and View features are already implemented but they
are not added to the SVG11 feature set. This is corrected in this patch.
Reviewed by Nikolas Zimmermann.
No new testcase is needed because we already have one what checks the svg features via
DOMImplementation (svg/custom/svg-features.html).
- dom/DOMImplementation.cpp:
(WebCore::isSVG11Feature):
LayoutTests:
Reviewed by Nikolas Zimmermann.
- platform/qt-5.0/svg/custom/svg-features-expected.txt:
- platform/qt/svg/custom/svg-features-expected.txt:
- svg/custom/svg-features-expected.txt:
- 8:13 AM Changeset in webkit [119832] by
-
- 4 edits in trunk
Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88604
Reviewed by Kent Tamura.
Tools:
DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::requestPointerUnlock):
LayoutTests:
Removed CRASH expectation.
Test is no longer crashing with this fix to DumpRenderTree.
- platform/chromium/TestExpectations:
- 8:01 AM Changeset in webkit [119831] by
-
- 5 edits2 adds in trunk
WebCore::ImageBuffer.cpp has broken color table code
https://bugs.webkit.org/show_bug.cgi?id=80321
Reviewed by Dirk Schulze.
Source/WebCore:
The code in ImageBuffer::transformColorSpace had two problems that are
fixed by this patch.
First, it was using member variables for data
that is static constant. This is incredibly wasteful, as every
ImageBuffer that is created (and we make a lot of them) gets its own
copy of the LUT and the table is initialized again and again. The
patch replaces this with a static local, with lazy evaluation, in
the method that uses the tables.
Second, the code for filling the table was mapping 255 to 254, thus
reducing the intensity and alpha of every image it pushed through a
color transform.
Test: svg/filters/color-space-conversion.svg
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::transformColorSpace):
- platform/graphics/ImageBuffer.h:
(ImageBuffer):
LayoutTests:
Temporarily marking Chromium tests expected to fail as a result of this patch. And a new test.
- platform/chromium/TestExpectations:
- svg/filters/color-space-conversion.svg:
- svg/filters/color-space-conversion-expected.svg:
- 7:44 AM Changeset in webkit [119830] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Better labels positioning on the memory pie chart
https://bugs.webkit.org/show_bug.cgi?id=88652
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-08
Reviewed by Vsevolod Vlasov.
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryPieChart.prototype._paint.paintPercentAndLabel):
(WebInspector.NativeMemoryPieChart.prototype._paint):
- 7:30 AM Changeset in webkit [119829] by
-
- 2 edits in trunk/Source/WebKit2
Tried to fix the Snow Leopard build after r119806.
- WebKit2Prefix.h:
- 7:23 AM Changeset in webkit [119828] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-08
- DEPS:
- 7:11 AM Changeset in webkit [119827] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/viewport/viewport-133.html fails
https://bugs.webkit.org/show_bug.cgi?id=80689
Since https://bugs.webkit.org/show_bug.cgi?id=88047 remove this
test case, remove it from skip list.
Reviewed by Laszlo Gombos.
- platform/qt/Skipped:
- 6:07 AM Changeset in webkit [119826] by
-
- 30 edits in trunk
Web Inspector: Annotate timeline records with a frame identifier
https://bugs.webkit.org/show_bug.cgi?id=86406
Patch by Bryan McQuade <bmcquade@google.com> on 2012-06-08
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Tests: Updated existing layout tests.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorInstrumentation.cpp:
(WebCore::frameForScriptExecutionContext):
(WebCore):
(WebCore::InspectorInstrumentation::didScheduleResourceRequestImpl):
(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willCallFunctionImpl):
(WebCore::InspectorInstrumentation::willChangeXHRReadyStateImpl):
(WebCore::InspectorInstrumentation::willDispatchEventImpl):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
(WebCore::InspectorInstrumentation::willEvaluateScriptImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::willLayoutImpl):
(WebCore::InspectorInstrumentation::willLoadXHRImpl):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::willRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::willSendRequestImpl):
(WebCore::InspectorInstrumentation::willReceiveResourceDataImpl):
(WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::loadEventFiredImpl):
(WebCore::InspectorInstrumentation::willWriteHTMLImpl):
(WebCore::InspectorInstrumentation::didRequestAnimationFrameImpl):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didScheduleResourceRequest):
(WebCore::InspectorInstrumentation::didInstallTimer):
(WebCore::InspectorInstrumentation::didRemoveTimer):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::willChangeXHRReadyState):
(WebCore::InspectorInstrumentation::willDispatchEvent):
(WebCore::InspectorInstrumentation::willEvaluateScript):
(WebCore::InspectorInstrumentation::willFireTimer):
(WebCore::InspectorInstrumentation::willLayout):
(WebCore::InspectorInstrumentation::willLoadXHR):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::willRecalculateStyle):
(WebCore::InspectorInstrumentation::willReceiveResourceData):
(WebCore::InspectorInstrumentation::willReceiveResourceResponse):
(WebCore::InspectorInstrumentation::willWriteHTML):
(WebCore::InspectorInstrumentation::didRequestAnimationFrame):
(WebCore::InspectorInstrumentation::didCancelAnimationFrame):
(WebCore::InspectorInstrumentation::willFireAnimationFrame):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::willDispatchEvent):
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::willRecalculateStyle):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::willComposite):
(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::willFireTimer):
(WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
(WebCore::InspectorTimelineAgent::willLoadXHR):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::didRequestAnimationFrame):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrame):
(WebCore::InspectorTimelineAgent::willFireAnimationFrame):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::pushCancelableRecord):
(WebCore::InspectorTimelineAgent::commitCancelableRecords):
- inspector/InspectorTimelineAgent.h:
(WebCore):
(WebCore::InspectorTimelineAgent::create):
(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.isEventDivider):
(WebInspector.TimelinePresentationModel.Record):
LayoutTests:
- inspector/timeline/timeline-animation-frame-expected.txt:
- inspector/timeline/timeline-dom-content-loaded-event-expected.txt:
- inspector/timeline/timeline-event-dispatch-expected.txt:
- inspector/timeline/timeline-injected-script-eval-expected.txt:
- inspector/timeline/timeline-layout-expected.txt:
- inspector/timeline/timeline-load-event-expected.txt:
- inspector/timeline/timeline-network-resource-expected.txt:
- inspector/timeline/timeline-paint-expected.txt:
- inspector/timeline/timeline-parse-html-expected.txt:
- inspector/timeline/timeline-recalculate-styles-expected.txt:
- inspector/timeline/timeline-script-tag-1-expected.txt:
- inspector/timeline/timeline-script-tag-2-expected.txt:
- inspector/timeline/timeline-test.js:
- inspector/timeline/timeline-timer-expected.txt:
- platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt:
- platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt:
- platform/chromium/inspector/timeline/timeline-layout-expected.txt:
- platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
- platform/chromium/inspector/timeline/timeline-paint-expected.txt:
- platform/chromium/inspector/timeline/timeline-parse-html-expected.txt:
- platform/chromium/inspector/timeline/timeline-timer-expected.txt:
- 5:59 AM Changeset in webkit [119825] by
-
- 2 edits in trunk/LayoutTests
Unreviewed update for chromium test expectations.
viewspec-parser-*.html were marked as SLOW.
- platform/chromium/TestExpectations:
BUGWK87772 SLOW : svg/dom/viewspec-parser-1.html = PASS
BUGWK87772 SLOW : svg/dom/viewspec-parser-2.html = PASS
BUGWK87772 SLOW : svg/dom/viewspec-parser-3.html = PASS
BUGWK87772 SLOW : svg/dom/viewspec-parser-4.html = PASS
BUGWK87772 SLOW : svg/dom/viewspec-parser-5.html = PASS
- 5:46 AM Changeset in webkit [119824] by
-
- 12 edits in trunk/Source/WebCore
Unreviewed, rolling out r119821.
http://trac.webkit.org/changeset/119821
https://bugs.webkit.org/show_bug.cgi?id=88648
Seems to have regression on Mac (Requested by kinuko on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-08
- fileapi/File.cpp:
(WebCore::File::File):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding):
(WebCore):
(WebCore::File::captureSnapshot):
- fileapi/File.h:
(File):
- fileapi/File.idl:
- platform/FileMetadata.h:
(WebCore::FileMetadata::FileMetadata):
- platform/FileSystem.h:
- platform/chromium/support/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
- platform/network/BlobData.cpp:
(WebCore):
- platform/network/BlobData.h:
(BlobDataItem):
(WebCore::BlobDataItem::BlobDataItem):
- platform/network/FormData.cpp:
(WebCore::FormData::appendFile):
- platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::advanceCurrentStream):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::blobIsOutOfDate):
- 5:29 AM Changeset in webkit [119823] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, removing duplicated entries in gyp.
- WebCore.gypi:
- 5:16 AM Changeset in webkit [119822] by
-
- 3 edits2 adds in trunk
Microdata: An element with an empty itemprop= should not get listed in the .properties list.
https://bugs.webkit.org/show_bug.cgi?id=88235
Reviewed by Ryosuke Niwa.
Source/WebCore:
As per the specification change http://html5.org/r/6854, an element should be listed in .properties
if the elelement has an attribute itemprop specified and the element has one or more property names.
Test: fast/dom/MicroData/element-with-empty-itemprop.html
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::itemAfter):
LayoutTests:
- fast/dom/MicroData/element-with-empty-itemprop-expected.txt: Added.
- fast/dom/MicroData/element-with-empty-itemprop.html: Added.
- 4:50 AM Changeset in webkit [119821] by
-
- 12 edits in trunk/Source/WebCore
File::lastModifiedDate should use NaN or separate boolean flag for null Date value
https://bugs.webkit.org/show_bug.cgi?id=87826
Reviewed by Kent Tamura.
Test: http/tests/local/fileapi/file-last-modified-after-delete.html
- fileapi/File.cpp:
(WebCore::File::File):
(WebCore::File::captureSnapshot):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding): Removed.
- fileapi/File.h:
(File):
- fileapi/File.idl:
- platform/FileMetadata.h:
(WebCore::FileMetadata::FileMetadata):
- platform/FileSystem.h:
- platform/chromium/support/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
- platform/network/BlobData.h:
(WebCore::BlobDataItem::doNotCheckFileChange): Removed.
- platform/network/BlobData.cpp:
- platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::advanceCurrentStream):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::blobIsOutOfDate):
- 4:44 AM Changeset in webkit [119820] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip passing sputnik tests
https://bugs.webkit.org/show_bug.cgi?id=88641
Unreviewed, unskip sputnik tests which are passing now.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-08
- platform/efl/TestExpectations:
- 4:11 AM Changeset in webkit [119819] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, removing crash expectations for two plugins
tests that were fixed after LLInt was enabled for the Gtk port in r119593.
- platform/gtk/TestExpectations:
- 4:02 AM Changeset in webkit [119818] by
-
- 7 edits4 adds in trunk
Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=87976
Reviewed by Kent Tamura.
Tools:
Provide a mock implementation of WebSpeechRecognizer for
DumpRenderTree. This will allow better testing of the API via layout
tests.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::addMockSpeechRecognitionResult):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
(MockWebSpeechRecognizer::create):
(MockWebSpeechRecognizer::start):
(MockWebSpeechRecognizer::stop):
(MockWebSpeechRecognizer::abort):
(MockWebSpeechRecognizer::MockWebSpeechRecognizer):
(MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
(MockWebSpeechRecognizer::ResultTask::runIfValid):
- DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
(WebKit):
(MockWebSpeechRecognizer):
(MockWebSpeechRecognizer::addMockResult):
(MockWebSpeechRecognizer::taskList):
(ClientCallTask):
(MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
(ResultTask):
(MockWebSpeechRecognizer::ResultTask::ResultTask):
(NoMatchTask):
(MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::speechRecognizer):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
(WebViewHost::mockSpeechRecognizer):
LayoutTests:
Add a layout test using the new mock, pushing a mock result through
and checking that events fire correctly.
- fast/speech/scripted/speechrecognition-basics-expected.txt: Added.
- fast/speech/scripted/speechrecognition-basics.html: Added.
- 3:59 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 3:41 AM Changeset in webkit [119817] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening after r119795, adding separate test expectations
for jquery/core.html - the test is crashing on debug builds and failing
with a text diff on release builds.
- platform/gtk/TestExpectations:
- 2:53 AM Changeset in webkit [119816] by
-
- 15 edits2 adds in trunk/Source/WebCore
Move form-related functions of Document to FormController
https://bugs.webkit.org/show_bug.cgi?id=88497
Reviewed by Hajime Morita.
A lot of files depend on Document.h. We had to build many files when we
touched form-related features in Document.h or
CheckedRadioButtons.h. This patch reduces such pain.
No new tests. Just a refactoring.
- CMakeLists.txt: Add FormController.cpp and/or FormController.h.
- GNUmakefile.list.am: ditto.
- Target.pri: ditto.
- WebCore.gypi: ditto.
- WebCore.vcproj/WebCore.vcproj: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto.
- dom/Document.cpp: Removed form-releated features except the followings.
(WebCore::Document::formController): Accessor for a FormController.
(WebCore::Document::formElementsState):
Just returns FormController::formElementsState().
We don't create new FormController.
(WebCore::Document::setStateForNewFormElements):
Just returns FormController::setStateForNewFormElements().
We don't create new FormController if the specified vector is empty.
- dom/Document.h:
Moved form-related functions to FormController.
- html/FormController.cpp: Added. Moved from Document.cpp.
- html/FormController.h: Added. Moved from Document.h
- html/FormAssociatedElement.cpp: Use Document::formController().
(WebCore::FormAssociatedElement::didMoveToNewDocument):
(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formAttributeChanged):
- html/HTMLFormControlElementWithState.cpp: Use Document::formController().
(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):
- html/HTMLFormElement.cpp: Use Document::formController().
(WebCore::HTMLFormElement::didNotifyDescendantInsertions):
(WebCore::HTMLFormElement::removedFrom):
- html/HTMLInputElement.cpp: Use Document::formController().
(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::didMoveToNewDocument):
(WebCore::HTMLInputElement::checkedRadioButtons):
- html/HTMLInputElement.h:
Declare CheckedRadioButtons. It was provided by Document.h.
- html/parser/HTMLConstructionSite.h:
Declare HTMLFormElement. It was provided by Document.h
- 2:50 AM Changeset in webkit [119815] by
-
- 12 edits2 adds in trunk/Source
Add FileSystem item to storage tree.
https://bugs.webkit.org/show_bug.cgi?id=72691
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-08
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/FileSystemModel.js: Added.
- inspector/front-end/Images/fileSystem.png: Added.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.FileSystemListTreeElement):
(WebInspector.FileSystemListTreeElement.prototype.onexpand):
(WebInspector.FileSystemListTreeElement.prototype.onattach):
(WebInspector.FileSystemListTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemAdded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemTreeElementByName):
(WebInspector.FileSystemListTreeElement.prototype._refreshFileSystem):
(WebInspector.FileSystemTreeElement):
(WebInspector.FileSystemTreeElement.prototype.get fileSystemName):
(WebInspector.FileSystemTreeElement.prototype.get itemURL):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/resourcesPanel.css:
(.file-system-storage-tree-item .icon):
- inspector/front-end/utilities.js:
Source/WebKit/chromium:
- src/js/DevTools.js:
- 2:19 AM Changeset in webkit [119814] by
-
- 5 edits in trunk/Source/WebCore
REGRESSION r119802: Remove unnecessary ASSERT(!m_deletionHasBegun) from Document.h
https://bugs.webkit.org/show_bug.cgi?id=88528
Reviewed by Ryosuke Niwa.
m_deletionHasBegun should become true just before 'delete this'.
No tests. No change in behavior.
- dom/Document.h:
(WebCore::Document::guardRef):
(WebCore::Document::guardDeref):
- 2:09 AM Changeset in webkit [119813] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Re-enable SHARED_WORKERS for Android until a build fix has been resolved.
https://bugs.webkit.org/show_bug.cgi?id=88637
Unreviewed build fix.
Linking content_shell on the Chromium side fails due to an unresolved
call to WebSharedWorker::create(). Since this blocks WebKit rolls,
temporarily re-enable the feature until this has been solved.
- features.gypi:
- 1:29 AM Changeset in webkit [119812] by
-
- 1 edit1 copy1 move in trunk/LayoutTests
[chromium] Run optimize-baselines over canvas-toDataURL-webp.html results
Unreviewed test expectations update.
- platform/chromium-mac/fast/canvas/canvas-toDataURL-webp-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/canvas/canvas-toDataURL-webp-expected.png.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/canvas/canvas-toDataURL-webp-expected.png.
- 1:14 AM Changeset in webkit [119811] by
-
- 2 edits in trunk/Source/WebCore
HTTP 204 No Content responses shouldn't trigger MIME type warnings in the web inspector
https://bugs.webkit.org/show_bug.cgi?id=88603
Reviewed by Pavel Feldman.
A 204 response doesn't have an entity body, so its MIME type is kind of
meaningless. We shouldn't spam the console with a warning about MIME
types.
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
- 1:01 AM Changeset in webkit [119810] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip tests using disabled SHADOW_DOM feature on Qt.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-08
- platform/qt/Skipped:
- 12:51 AM Changeset in webkit [119809] by
-
- 11 edits in trunk/Source/WebCore
[Forms] Drop StepRange::NumberWithDecimalPlacesOrMissing
https://bugs.webkit.org/show_bug.cgi?id=88621
Reviewed by Kent Tamura.
This patch changes NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.
We use NaN as indication of having value or not.
No new tests, because this patch doesn't change behavior.
- html/DateInputType.cpp:
(WebCore::DateInputType::createStepRange): Replace NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.
- html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::createStepRange): ditto.
- html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::createStepRange): ditto.
- html/MonthInputType.cpp:
(WebCore::MonthInputType::createStepRange): ditto.
- html/NumberInputType.cpp:
(WebCore::NumberInputType::createStepRange): ditto.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createStepRange): ditto.
- html/StepRange.cpp:
(WebCore::StepRange::StepRange): Checks value is finite or not.
(WebCore::StepRange::parseStep): Replace NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.
- html/StepRange.h:
(StepRange): Removed NumberWithDecimalPlacesOrMissing.
- html/TimeInputType.cpp:
(WebCore::TimeInputType::createStepRange): NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.
- html/WeekInputType.cpp:
(WebCore::WeekInputType::createStepRange): ditto.
- 12:45 AM Changeset in webkit [119808] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fixed a comment, pointed out by ap@.
- platform/TreeShared.h:
(WebCore):
- 12:42 AM Changeset in webkit [119807] by
-
- 2 edits in trunk/Source/WebCore
[chromium] WEBP image blue and red color channels reversed on Android
https://bugs.webkit.org/show_bug.cgi?id=88613
Reviewed by Kent Tamura.
No new tests. Covered by test fast/images/webp-image-decoding.html though I'm
not sure where/how the Androids run their layout tests.
- platform/image-decoders/webp/WEBPImageDecoder.cpp:
(outputMode): Detect little-endian Skia with a blue pixel shift (aka Android)
which seems to be the way for them per bug 75861.
- 12:29 AM Changeset in webkit [119806] by
-
- 3 edits in trunk/Source/WebKit2
[WebKit2] Move Mac-specific bits from config.h to WebKit2Prefix.h
https://bugs.webkit.org/show_bug.cgi?id=88625
Reviewed by Dan Bernstein.
Since the Mac supports prefix headers, there is no point in having
Mac-specific code in WebKit2's config.h. Move it to WebKit2Prefix.h.
- WebKit2Prefix.h:
- config.h:
- 12:27 AM Changeset in webkit [119805] by
-
- 2 edits in trunk/LayoutTests
Fixed fast/files/read-blob-async.html failing after r119791.
- fast/files/resources/read-blob-test-cases.js:
(testReadingSingleArrayBufferBlob):
(testReadingSlicedArrayBufferBlob):
(testReadingMultipleArrayBufferBlob):
(testReadingHybridBlob):
(testReadingSlicedHybridBlob):
(testReadingTripleSlicedHybridBlob):
- 12:22 AM Changeset in webkit [119804] by
-
- 1 edit1 add in trunk/LayoutTests
[chromium] New virtual GPU canvas-toDataURL-webp.html results after r119787
Unreviewed test expectations update.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png: Added.
- 12:04 AM Changeset in webkit [119803] by
-
- 2 edits in trunk/Source/WebCore
Remove the assertion that has been moved to TreeScope after r119802.
- dom/Document.cpp:
(WebCore::Document::removedLastRef):
