Timeline
Jun 20, 2012:
- 11:08 PM Changeset in webkit [120905] by
-
- 4 edits in trunk/Source/WebCore
[cairo] improve putByteArray speed by avoiding max/min checks at Color construction.
https://bugs.webkit.org/show_bug.cgi?id=89138
Patch by Arnaud Renevier <arno@renevier.net> on 2012-06-20
Reviewed by Adam Barth.
Color constructor accepts integer arguments and checks if they are
between 0 and 255. In some cases, we already known those numbers to be
within those boundaries. For example when using unsigned chars. So
this patch introduces Color::createUnChecked which return a Color
object without checking for boundaries.
No new tests: no behaviour change
- platform/graphics/Color.cpp:
(WebCore::colorFromPremultipliedARGB):
- platform/graphics/Color.h:
(WebCore::Color::createUnCheked):
(Color):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::putByteArray):
- 10:39 PM Changeset in webkit [120904] by
-
- 4 edits in trunk/Source
[Chromium] Damage tracker is not used without partial swap, causing valid render passes to be removed
https://bugs.webkit.org/show_bug.cgi?id=89589
Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-20
Reviewed by Adrienne Walker.
Source/WebCore:
When not using partial swap, the CCDamageTracker was not used, and
its m_currentDamageRect was always empty. As a result,
CCLayerTreeHostImpl was thinking no content was changed and was
removing more textures than needed. Fixed this by turning on
CCDamageTracker usage even if not using partial swap, but
overwriting the rootScissorRect with viewport rect if required.
Added unit tests to exercise this scenario.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
Source/WebKit/chromium:
Added unit tests to check surface texture caching when partial
swap is not used.
- tests/CCLayerTreeHostImplTest.cpp:
- 10:11 PM Changeset in webkit [120903] by
-
- 7 edits in trunk/Source/WebCore
[Forms] Make step action of SpinButtonElement replaceable
https://bugs.webkit.org/show_bug.cgi?id=89439
Reviewed by Kent Tamura.
This patch introduces SpinButtonElement::Callback to specify step
action by control clients for using SpinButtonElement by
TextFieldInputType and future version of TimeInputField.
In addition to this improving flexibility of SpinButtonElement, we
free HTMLInputElement from SpinButtonElement dependency on
stepUpFromRenderer.
No new tests. This patch doesn't change behavior.
- html/HTMLInputElement.cpp: Removed stepUpFromRenderer().
- html/HTMLInputElement.h: Removed stepUpFromRenderer().
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::~TextFieldInputType): Added to call SpinButtonElement::removeStepActionHandler.
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton): Changed to call spinButtonStep{Down,Up}
(WebCore::TextFieldInputType::handleWheelEventForSpinButton): Changed to call spinButtonStep{Down,Up}
(WebCore::TextFieldInputType::createShadowSubtree): Added SpinButtonElement::StepActionHandler parameter.
(WebCore::TextFieldInputType::destroyShadowSubtree): Added to call SpinButtonElement::removeStepActionHandler.
(WebCore::TextFieldInputType::spinButtonStepDown): Added for implementation of SpinButtonElement::StepActionHandler.
(WebCore::TextFieldInputType::spinButtonStepUp): Added for implementation of SpinButtonElement::StepActionHandler.
- html/TextFieldInputType.h:
(TextFieldInputType):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::SpinButtonElement): Added StepActionHandler parameter.
(WebCore::SpinButtonElement::defaultEventHandler): Changed to call doStepAction.
(WebCore::SpinButtonElement::doStepAction): Added to call StepActionHandler if possible.
(WebCore::SpinButtonElement::step): Changed to call doStepAction.
- html/shadow/TextControlInnerElements.h:
(StepActionHandler): Added.
- 9:46 PM Changeset in webkit [120902] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Modify CCDamageTracker hash to allow for layer id 0
https://bugs.webkit.org/show_bug.cgi?id=89631
Reviewed by James Robinson.
HashMap has the bizarre property that 0 is the empty value for integer
keys. Modify the damage tracking HashMap to use negative values for
both the empty and the deleted key traits. Additionally, make sure we
never generate negative layer IDs in practice.
Test: passes webkit_unit_tests with the patch in bug 89589 applied.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
- platform/graphics/chromium/cc/CCDamageTracker.h:
(RectMapKeyTraits):
(WebCore::CCDamageTracker::RectMapKeyTraits::emptyValue):
(WebCore::CCDamageTracker::RectMapKeyTraits::constructDeletedValue):
(WebCore::CCDamageTracker::RectMapKeyTraits::isDeletedValue):
(CCDamageTracker):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
- 9:27 PM Changeset in webkit [120901] by
-
- 2 edits in trunk/Tools
[WinCairo] Unreviewed build fix.
The wrapper script that launched new- and old-run-webkit-tests
was discarding the --wincairo argument needed to get the proper
test infrastructure to build under WinCairo.
- Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
behavior to chain the --wincairo flag through to the new build
and test scripts.
- 9:18 PM Changeset in webkit [120900] by
-
- 6 edits in trunk/Source/WebCore
Use Dictionary in MutationObserver.observe to kill custom code
https://bugs.webkit.org/show_bug.cgi?id=89629
Reviewed by Ryosuke Niwa.
Move code for dictionary parsing in MutationObserver.observe
that used to be duplicated (with different implementations)
in JSC and V8 bindings into WebKitMutationObserver.cpp, using
the new Dictionary interface.
No new tests, no change in behavior.
- bindings/js/JSWebKitMutationObserverCustom.cpp:
- bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
- dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::observe):
- dom/WebKitMutationObserver.h:
(WebCore):
- dom/WebKitMutationObserver.idl:
- 7:03 PM Changeset in webkit [120899] by
-
- 4 edits in trunk/Source
Unreviewed, rolling out r120889.
http://trac.webkit.org/changeset/120889
https://bugs.webkit.org/show_bug.cgi?id=89630
[Chromium] webkit_unit_tests didDrawNotCalledOnHiddenLayer
start failing (Requested by ukai on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-20
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
- 7:00 PM Changeset in webkit [120898] by
-
- 4 edits in trunk/Source/JavaScriptCore
Reduced (but did not eliminate) use of "berzerker GC"
https://bugs.webkit.org/show_bug.cgi?id=89237
Reviewed by Gavin Barraclough.
(PART 1)
This patch turned out to be crashy, so I'm landing the non-crashy bits
first.
This part is pre-requisite refactoring. I didn't actually turn off
"berzerker GC" or turn on incremental shrinking.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::removeBlock): Make sure to clear the free list when
we throw away the block we're currently allocating out of. Otherwise, we'll
allocate out of a stale free list.
- heap/MarkedSpace.cpp:
(JSC::Free::Free):
(JSC::Free::operator()):
(JSC::Free::returnValue): Refactored this functor to use a shared helper
function, so we can share our implementation with the incremental sweeper.
Also changed to freeing individual blocks immediately instead of linking
them into a list for later freeing. This makes the programming interface
simpler, and it's slightly more efficient to boot.
(JSC::MarkedSpace::~MarkedSpace): Updated for rename.
(JSC::MarkedSpace::freeBlock):
(JSC::MarkedSpace::freeOrShrinkBlock): New helper functions to share behavior
with the incremental sweeper.
(JSC::MarkedSpace::shrink): Updated for new functor behavior.
- heap/MarkedSpace.h: Statically typed languages are awesome.
- 6:38 PM Changeset in webkit [120897] by
-
- 12 edits2 adds in trunk/Source/JavaScriptCore
DFG should optimize ResolveGlobal
https://bugs.webkit.org/show_bug.cgi?id=89617
Reviewed by Oliver Hunt.
This adds inlining of ResolveGlobal accesses that are known monomorphic. It also
adds the specific function optimization to ResolveGlobal, when it is inlined. And,
it makes internal functions act like specific functions, since that will be the
most common use-case of this optimization.
This is only a slighy speed-up (sub 1%), since we don't yet do the obvious thing
with this optimization, which is to completely inline common "globally resolved"
function and constructor calls, like "new Array()".
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::globalResolveInfoForBytecodeOffset):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::numberOfGlobalResolveInfos):
- bytecode/GlobalResolveInfo.h:
(JSC::getGlobalResolveInfoBytecodeOffset):
(JSC):
- bytecode/ResolveGlobalStatus.cpp: Added.
(JSC):
(JSC::computeForStructure):
(JSC::computeForLLInt):
(JSC::ResolveGlobalStatus::computeFor):
- bytecode/ResolveGlobalStatus.h: Added.
(JSC):
(ResolveGlobalStatus):
(JSC::ResolveGlobalStatus::ResolveGlobalStatus):
(JSC::ResolveGlobalStatus::state):
(JSC::ResolveGlobalStatus::isSet):
(JSC::ResolveGlobalStatus::operator!):
(JSC::ResolveGlobalStatus::isSimple):
(JSC::ResolveGlobalStatus::takesSlowPath):
(JSC::ResolveGlobalStatus::structure):
(JSC::ResolveGlobalStatus::offset):
(JSC::ResolveGlobalStatus::specificValue):
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(DFG):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- runtime/JSObject.cpp:
(JSC::getCallableObjectSlow):
(JSC):
(JSC::JSObject::put):
(JSC::JSObject::putDirectVirtual):
(JSC::JSObject::putDirectAccessor):
- runtime/JSObject.h:
(JSC):
(JSC::getCallableObject):
(JSC::JSObject::putOwnDataProperty):
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
- 6:34 PM Changeset in webkit [120896] by
-
- 8 edits2 adds in trunk
Source/WebCore: [Shadow][Editing] Deleting character in distributed element caused a crash.
https://bugs.webkit.org/show_bug.cgi?id=88484
Reviewed by Ryosuke Niwa.
If we mutate nodes which are children of a shadow host, it causes
ElementShadow::invalidateDistribution(). As a result, shadow host
is detached (and lazyAttached()) and its renderer is gone. That
causes assertion error since isEditablePosition() assumes
anchorNode's style was correctly calculated.
This patch makes isEditablePosition() call
document->updateLayoutIgnorePendingStylesheets() so that it does
not return a bogus result.
There is an exceptional caller of isEditablePosition,
RenderBlock::paintCaret(), from where we can not call
updateLayout() in isEditablePosition because it hits assertion,
ASSERT(!isPainting). So I've added the third parameter to
isEditablePosition to control updating the style.
Test: edition/shadow/delete-characters-in-distributed-node.html
- editing/FrameSelection.h:
(WebCore::FrameSelection::rendererIsEditable):
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::rendererIsEditable):
(WebCore):
- editing/VisibleSelection.h:
(VisibleSelection):
- editing/htmlediting.cpp:
(WebCore::isEditablePosition):
- editing/htmlediting.h:
(WebCore):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintCaret):
LayoutTests: [Shadow][Editing] Deleting character in distributed element caused a crash
https://bugs.webkit.org/show_bug.cgi?id=88484
Reviewed by Ryosuke Niwa.
- editing/shadow/delete-characters-in-distributed-node-crash-expected.txt: Added.
- editing/shadow/delete-characters-in-distributed-node-crash.html: Added.
- 6:31 PM Changeset in webkit [120895] by
-
- 8 edits in trunk
Unmodified form control value are overwritten by another form
control value with the same name after navigating and going back
https://bugs.webkit.org/show_bug.cgi?id=89409
Reviewed by Hajime Morita.
Source/WebCore:
Detail of the bug:
If a page had multiple form controls of which names and types were
identical like the following:
<input type=text name=name1 id=input1>
<input type=text name=name1 id=input2>
and a user updated the value of the second control, then went to
another page and went back to the page again, we restored the updated
value to the first element, and didn't update the second element.
We didn't save unmodified control state, and the form state data
had no ways to represent "this control should be skipped".
How to resovle the bug:
We need to represent "this control should be skipped" in the
seriazlied form state vector.
- A serialized control state had three items:
name, type, value.
Now we change it to:
name, type, flag, optional value
- It is definitely incompatible with serizlized state produced by
older WebCore. So, we need to add the signature string to
represent the version of serialized state format.
- Because the state for a form control is variable-length and we
can't deserialize it in reverse-order, we change the on-memory
representation from Vector<> to Deque<>.
Test: fast/forms/state-restore-to-non-edited-controls.html
- html/FormController.cpp:
(WebCore::FormControlState::serializeTo):
Added. Serialize a state for a form control to a string vector.
(WebCore::FormControlState::deserialize):
Added. Produce a FormControlState object from the specified string vector.
It can produce a FromControlState of the failure type.
(WebCore::formStateSignature): The signature string of the serialized state.
(WebCore::FormController::formElementsState):
- Capacity: The size of seirlized data for one form control is typically 4. +1 for the signature.
- We need to store a FormControlState with no values.
(WebCore::FormController::setStateForNewFormElements):
- We can't iterate over the stateVector in reverse order any more because serialized control state is variable-length.
- We put FormControlState objects to HashMap instead of String objects.
(WebCore::FormController::takeStateForFormElement):
Updated for Deque<>.
- html/FormController.h:
(FormControlState): Declare deserialize() and serializeTo().
(WebCore::FormControlState::isFailure): Added.
(WebCore::FormControlState::FormControlState):
Added to create a FormControlState with failure type.
(FormController):
Change the value type of m_stateForNewFormElements from Vector<String>
to Deque<FormControlState>.
LayoutTests:
- fast/forms/resources/state-restore-broken-state-2.html:
Take care of the signature string at the beginning of the array.
- fast/forms/state-restore-broken-state-expected.txt:
Updated for the serialized format change.
- fast/forms/state-restore-to-non-edited-controls-expected.txt:
- fast/forms/state-restore-to-non-edited-controls.html:
Add a test for a case of duplicated names.
- 6:29 PM Changeset in webkit [120894] by
-
- 4 edits2 adds1 delete in trunk/LayoutTests
Unskip fast/hidpi/device-scale-factor-paint.html
https://bugs.webkit.org/show_bug.cgi?id=89618
Reviewed by Beth Dakin.
Now that this test doesn't cause WebKit2 to crash, we can unskip it.
- fast/hidpi/device-scale-factor-paint-expected.html: Removed.
- Previously, this test was a reftest, but the reference also tried to set the device scale factor, which seems problematic. This patch converts the test to a normal image test. There aren't any scrollbars or text, so many platforms should be able to use the same expected PNG file.
- fast/hidpi/device-scale-factor-paint.html:
- Wrap the call to notifyDone in a thunk because it doesn't work otherwise.
- platform/mac/Skipped:
- platform/mac/fast/hidpi/device-scale-factor-paint-expected.png: Added.
- platform/mac/fast/hidpi/device-scale-factor-paint-expected.txt: Added.
- platform/wk2/Skipped:
- 6:13 PM Changeset in webkit [120893] by
-
- 11 edits2 moves in trunk/Source/WebCore
[CSS Shaders] Rename CustomFilterShader class name to CustomFilterCompiledProgram
https://bugs.webkit.org/show_bug.cgi?id=89578
Reviewed by Dean Jackson.
I've renamed CustomFilterShader to CustomFilterCompiledProgram to make it obvious that it is the result of
calling CustomFilterProgram::compileProgramWithContext.
No new tests, just renamed an existing class.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/CustomFilterCompiledProgram.cpp: Renamed from Source/WebCore/platform/graphics/filters/CustomFilterShader.cpp.
(WebCore):
(WebCore::CustomFilterCompiledProgram::defaultVertexShaderString):
(WebCore::CustomFilterCompiledProgram::defaultFragmentShaderString):
(WebCore::CustomFilterCompiledProgram::CustomFilterCompiledProgram):
(WebCore::CustomFilterCompiledProgram::compileShader):
(WebCore::CustomFilterCompiledProgram::linkProgram):
(WebCore::CustomFilterCompiledProgram::initializeParameterLocations):
(WebCore::CustomFilterCompiledProgram::uniformLocationByName):
(WebCore::CustomFilterCompiledProgram::~CustomFilterCompiledProgram):
- platform/graphics/filters/CustomFilterCompiledProgram.h: Renamed from Source/WebCore/platform/graphics/filters/CustomFilterShader.h.
(WebCore):
- platform/graphics/filters/CustomFilterProgram.cpp:
(WebCore::CustomFilterProgram::compileProgramWithContext): Renamed method from createShaderWithContext to compileProgramWithContext.
- platform/graphics/filters/CustomFilterProgram.h:
(WebCore):
- platform/graphics/filters/FECustomFilter.cpp: Renamed m_shader to m_compiledProgram.
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::initializeContext):
(WebCore::FECustomFilter::bindProgramParameters):
(WebCore::FECustomFilter::bindProgramAndBuffers):
- platform/graphics/filters/FECustomFilter.h:
(WebCore):
(FECustomFilter):
- 6:03 PM Changeset in webkit [120892] by
-
- 1 edit2 adds in trunk/PerformanceTests
Add a performance test for paths in SVG
https://bugs.webkit.org/show_bug.cgi?id=89547
Reviewed by Ryosuke Niwa.
This change adds the first performance test for SVG paths.
In the test we modify complex cubic paths in several ways, testing:
transformations, clipping, d attribute changes, stroke properties,
text on a path, and opacity.
Sample test results on my Linux desktop:
RESULT SVG: SvgCubics= 68.85 ms
median= 69.5 ms, stdev= 4.70398767005 ms, min= 56.0 ms, max= 75.0 ms
RESULT SVG: SvgCubics= 68.4 ms
median= 69.0 ms, stdev= 3.51283361405 ms, min= 59.0 ms, max= 74.0 ms
RESULT SVG: SvgCubics= 66.95 ms
median= 67.0 ms, stdev= 3.4420197559 ms, min= 59.0 ms, max= 74.0 ms
RESULT SVG: SvgCubics= 70.2 ms
median= 71.5 ms, stdev= 3.23419232576 ms, min= 63.0 ms, max= 74.0 ms
- SVG: Added.
- SVG/SvgCubics.html: Added.
- 5:53 PM Changeset in webkit [120891] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: reduce timeline refresh rate
https://bugs.webkit.org/show_bug.cgi?id=89548
Reviewed by Pavel Feldman.
Minimize resource contention with the inspected page during refresh:
- reduce refresh for both overview and main panes to 300ms
- automatically limit window size to approximately one pageful of events in the lower pane
- do not refresh lower pane for events that are outside of the window
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineOverviewPane.prototype.setWindowTimes): Set overview window by times.
(WebInspector.TimelineOverviewPane.prototype._updateWindow):
(WebInspector.TimelineOverviewPane.prototype._scheduleRefresh): Refresh once in 300ms (insted of once in 100ms).
(WebInspector.TimelineOverviewWindow.prototype._setWindow):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded): Do not refresh if the new record is outside of window.
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._scheduleRefresh): Refresh rate: 100ms -> 300ms.
(WebInspector.TimelinePanel.prototype._refreshRecords): Automatically set overview window.
- inspector/front-end/TimelinePresentationModel.js: Expose filterRecords
(WebInspector.TimelinePresentationModel.prototype.filteredRecords):
(WebInspector.TimelinePresentationModel.prototype.filterRecords):
(WebInspector.TimelinePresentationModel.prototype._innerFilterRecords):
- 5:43 PM Changeset in webkit [120890] by
-
- 24 edits3 adds in trunk/Source/WebKit2
[WK2] Color chooser API missing
https://bugs.webkit.org/show_bug.cgi?id=87495
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-20
Reviewed by Andreas Kling.
Added ColorChooser API to WebKit2. This API allows the
embedder to define a custom color picker for <input type="color">.
Only one ColorChooser can be active for a page at a time. Although
the implementation doesn't not assume a modal dialog, no other
color chooser will be created until the active one is closed.
Also added stubs for all platforms, so it wont break the build when
enabling color chooser, even though they don't have the backend
implemented yet.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- UIProcess/API/efl/PageClientImpl.cpp:
(WebKit):
(WebKit::PageClientImpl::createColorChooserProxy):
- UIProcess/API/efl/PageClientImpl.h:
(PageClientImpl):
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit):
(WebKit::PageClientImpl::createColorChooserProxy):
- UIProcess/API/gtk/PageClientImpl.h:
(PageClientImpl):
- UIProcess/API/mac/PageClientImpl.h:
(PageClientImpl):
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit):
(WebKit::PageClientImpl::createColorChooserProxy):
- UIProcess/PageClient.h:
(WebKit):
(PageClient):
- UIProcess/WebColorChooserProxy.h: Added.
(WebCore):
(WebKit):
(WebColorChooserProxy):
(Client):
(WebKit::WebColorChooserProxy::Client::~Client):
(WebKit::WebColorChooserProxy::~WebColorChooserProxy):
(WebKit::WebColorChooserProxy::invalidate):
(WebKit::WebColorChooserProxy::WebColorChooserProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit):
(WebKit::WebPageProxy::showColorChooser):
(WebKit::WebPageProxy::setColorChooserColor):
(WebKit::WebPageProxy::endColorChooser):
(WebKit::WebPageProxy::didChooseColor):
(WebKit::WebPageProxy::didEndColorChooser):
(WebKit::WebPageProxy::processDidCrash):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/qt/QtPageClient.cpp:
(WebKit):
(WebKit::QtPageClient::createColorChooserProxy):
- UIProcess/qt/QtPageClient.h:
(QtPageClient):
- UIProcess/win/WebView.cpp:
(WebKit):
(WebKit::WebView::createColorChooserProxy):
- UIProcess/win/WebView.h:
(WebView):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createColorChooser):
- WebProcess/WebCoreSupport/WebColorChooser.cpp: Added.
(WebKit):
(WebKit::WebColorChooser::WebColorChooser):
(WebKit::WebColorChooser::~WebColorChooser):
(WebKit::WebColorChooser::didChooseColor):
(WebKit::WebColorChooser::didEndChooser):
(WebKit::WebColorChooser::disconnectFromPage):
(WebKit::WebColorChooser::setSelectedColor):
(WebKit::WebColorChooser::endChooser):
- WebProcess/WebCoreSupport/WebColorChooser.h: Added.
(WebCore):
(WebKit):
(WebColorChooser):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::close):
(WebKit):
(WebKit::WebPage::setActiveColorChooser):
(WebKit::WebPage::didEndColorChooser):
(WebKit::WebPage::didChooseColor):
- WebProcess/WebPage/WebPage.h:
(WebKit):
(WebPage):
(WebKit::WebPage::activeColorChooser):
- WebProcess/WebPage/WebPage.messages.in:
- win/WebKit2.vcproj:
- 5:43 PM Changeset in webkit [120889] by
-
- 4 edits in trunk/Source
[Chromium] Damage tracker is not used without partial swap, causing valid render passes to be removed
https://bugs.webkit.org/show_bug.cgi?id=89589
Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-20
Reviewed by Adrienne Walker.
Source/WebCore:
When not using partial swap, the CCDamageTracker was not used, and
its m_currentDamageRect was always empty. As a result,
CCLayerTreeHostImpl was thinking no content was changed and was
removing more textures than needed. Fixed this by turning on
CCDamageTracker usage even if not using partial swap, but
overwriting the rootScissorRect with viewport rect if required.
Added unit tests to exercise this scenario.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
Source/WebKit/chromium:
Added unit tests to check surface texture caching when partial
swap is not used.
- tests/CCLayerTreeHostImplTest.cpp:
- 5:31 PM Changeset in webkit [120888] by
-
- 17 edits in trunk
IndexedDB: Remove redundant IDBObjectStore.delete() overloads
https://bugs.webkit.org/show_bug.cgi?id=89587
Reviewed by Darin Fisher.
Source/WebCore:
The IDBObjectStore.delete(IDBKey) overload can delegate to the delete(IDBKeyRange)
overload. Also cleaned up redundant checks in related overloads.
Test: storage/indexeddb/deleted-objects.html
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::deleteFunction): Call keyRange variant instead.
- Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::get): Remove redundant deleted/invalid IDBKey checks.
(WebCore::IDBIndex::getKey): Remove redundant deleted/invalid IDBKey checks.
- Modules/indexeddb/IDBKeyRange.cpp: Null IDBKeys are not acceptable; currently
not passed in by any callers.
(WebCore::IDBKeyRange::only):
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get): Was missing deleted check in IDBKeyRange overload.
Removed redundant checks in IDBKey overload.
(WebCore::IDBObjectStore::deleteFunction): Delegate to IDBKeyRange overload.
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Remove IDBKey overload.
- Modules/indexeddb/IDBObjectStoreBackendImpl.h: Remove IDBKey overload.
(IDBObjectStoreBackendImpl):
- Modules/indexeddb/IDBObjectStoreBackendInterface.h: Remove IDBKey overload.
Source/WebKit/chromium:
- public/WebIDBObjectStore.h: Add note to remove overload when Chromium is updated.
(WebIDBObjectStore):
- src/IDBObjectStoreBackendProxy.cpp: Delete IDBKey overload.
- src/IDBObjectStoreBackendProxy.h: Delete IDBKey overload.
(IDBObjectStoreBackendProxy):
- src/WebIDBObjectStoreImpl.cpp: Delete IDBKey overload.
- src/WebIDBObjectStoreImpl.h: Delete IDBKey overload.
(WebIDBObjectStoreImpl):
LayoutTests:
- storage/indexeddb/deleted-objects-expected.txt:
- storage/indexeddb/resources/deleted-objects.js: Test IDBKeyRange overloads.
(openDatabase.request.onsuccess.request.onsuccess):
(openDatabase.request.onsuccess):
(openDatabase):
- 5:10 PM Changeset in webkit [120887] by
-
- 3 edits4 adds in trunk
[Shadow][Editing] Selection will break editing boundaries in Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=89075
Reviewed by Antti Koivisto.
Source/WebCore:
At the shadow boundary, some styles (e.g. user-modify, text-decoration) cannot be inherited
from the shadow host. However, when style property cache is used, such styles are wrongly
inherited from the cache.
So this patch makes not to use cache for inehrited styles at the shadow boundary.
Tests: editing/shadow/breaking-editing-boundary-with-table.html
editing/shadow/contenteditable-propagation-at-shadow-boundary.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
LayoutTests:
Test cases to confirm that (1) selection does not break editing boundary,
and (2) content-editable is not propagated from shadow host to shadow DOM.
Actually a patch for Bug 88514 contains a test for (2), but it is not enough.
- editing/shadow/breaking-editing-boundary-with-table.html: Added.
- editing/shadow/contenteditable-propagation-at-shadow-boundary.html: Added.
- 4:55 PM Changeset in webkit [120886] by
-
- 2 edits in trunk/Source/JavaScriptCore
Functions on global objects should be specializable
https://bugs.webkit.org/show_bug.cgi?id=89615
Reviewed by Oliver Hunt.
I tested to see if this brought back the bug in https://bugs.webkit.org/show_bug.cgi?id=33343,
and it didn't. Bug 33343 was the reason why we disabled global object function specialization
to begin with. So I'm guessing this is safe.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- 4:49 PM Changeset in webkit [120885] by
-
- 15 edits in trunk/Source
Source/WebCore: Moving cookieEnabled/setCookieEnabled from Page to Settings.
https://bugs.webkit.org/show_bug.cgi?id=89545
Patch by Garret Kelly <gdk@chromium.org> on 2012-06-20
Reviewed by Adam Barth.
- dom/Document.cpp:
(WebCore::Document::cookie):
(WebCore::Document::setCookie):
- page/Navigator.cpp:
(WebCore::Navigator::cookieEnabled):
- page/Page.h:
(Page):
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setCookieEnabled):
(WebCore::Settings::cookieEnabled):
(Settings):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
Source/WebKit/chromium: Moving cookieEnabled/setCookieEnabled from Page to Settings, and
exposing through WebSettings.
https://bugs.webkit.org/show_bug.cgi?id=89545
Patch by Garret Kelly <gdk@chromium.org> on 2012-06-20
Reviewed by Adam Barth.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setCookieEnabled):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
Source/WebKit/mac: Moving cookieEnabled/setCookieEnabled from Page to Settings.
https://bugs.webkit.org/show_bug.cgi?id=89545
Patch by Garret Kelly <gdk@chromium.org> on 2012-06-20
Reviewed by Adam Barth.
- WebView/WebView.mm:
(-[WebView _cookieEnabled]):
(-[WebView _setCookieEnabled:]):
Source/WebKit/win: Moving cookieEnabled/setCookieEnabled from Page to Settings.
https://bugs.webkit.org/show_bug.cgi?id=89545
Patch by Garret Kelly <gdk@chromium.org> on 2012-06-20
Reviewed by Adam Barth.
- WebView.cpp:
(WebView::setCookieEnabled):
(WebView::cookieEnabled):
- 4:45 PM Changeset in webkit [120884] by
-
- 4 edits in branches/safari-536-branch/Source
Versioning.
- 4:37 PM Changeset in webkit [120883] by
-
- 6 edits in trunk
internals.settings.setDeviceScaleFactor doesn't work for WebKit2 and must be removed
https://bugs.webkit.org/show_bug.cgi?id=89274
Reviewed by James Robinson.
Source/WebCore:
Using this window.internals API causes the apple-mac port to ASSERT in
WebKit2 because WebKit2 keeps a copy of this state in the UI process.
When a test uses this internals API, the WebCore state gets out of sync
with the state in the UI process.
Tests should use setBackingScaleFactor instead.
- testing/InternalSettings.cpp:
(WebCore):
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl:
LayoutTests:
- fast/hidpi/device-scale-factor-paint.html:
- 4:36 PM Changeset in webkit [120882] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: persist timeline panel overview mode
https://bugs.webkit.org/show_bug.cgi?id=88711
Reviewed by Pavel Feldman.
- replace all internal methods of switching to a new mode of TimelineOverviewPane with setMode();
- make current mode a persistent setting;
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
- 4:31 PM Changeset in webkit [120881] by
-
- 2 edits in trunk/Source/WebKit/chromium
Perform hit-test from correct frame in isRectTopmost()
https://bugs.webkit.org/show_bug.cgi?id=89492
Patch by Raymes Khoury <raymes@chromium.org> on 2012-06-20
Reviewed by Levi Weintraub.
Hit-testing was being performed from the main frame, which gave the
incorrect result if the plugin was in a different frame.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::isRectTopmost):
- 4:17 PM Changeset in webkit [120880] by
-
- 1 copy in tags/Safari-536.21
New Tag.
- 4:05 PM Changeset in webkit [120879] by
-
- 8 edits in trunk/Source
<rdar://problem/11653784> and https://bugs.webkit.org/show_bug.cgi?id=89590
showModalDialog message handling is flaky in WebKit2
Because RunLoop::performWork() swaps the function queue to a temporary Vector before calling
the functions an inner run-loop - such as we see with running a modal dialog - does not have
a change to handle any of the functions that were queued after the WebPageProxy::RunModal message.
By servicing the functions in the queue one at a time we can give the RunLoop a chance to pick up
where it left off if RunLoop::performWork is re-entered.
To guarantee RunLoop::performWork is re-entered to handle those functions we also need to signal
its source before entering the modal run loop so our RunLoop is woken up.
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.exp.in:
- platform/RunLoop.cpp:
(WebCore::RunLoop::performWork): Take the first function off the queue one at a time so subsequent
functions remain in the queue and can be handled by an inner modal run loop.
- platform/RunLoop.h:
(RunLoop): Change the function queue to be a Deque to efficiently support "takeFirst"
Source/WebKit2:
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::wakeUpRunLoop): Added so the WebPageProxy can signal the runloop to be woken up
before it enters the modal dialog run loop.
- Platform/CoreIPC/Connection.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runModal): Call wakeUpRunLoop() before entering the modal dialog run loop.
- 4:01 PM Changeset in webkit [120878] by
-
- 2 edits in trunk/Tools
<http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
Reviewed by Dan Bernstein.
- Scripts/webkitdirs.pm:
(executableHasEntitlements):
(safariPathFromSafariBundle):
- 3:57 PM Changeset in webkit [120877] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Support mobile device rotation resizing
https://bugs.webkit.org/show_bug.cgi?id=86819
Patch by Alexandre Elias <aelias@google.com> on 2012-06-20
Reviewed by Adam Barth.
Resizes on a mobile device are caused either by rotation or
on-screen-keyboard bringup, and need different treatment to remain
naturally laid out, scaled and scrolled without disorienting the user.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
- 3:49 PM Changeset in webkit [120876] by
-
- 3 edits1 add in trunk
Account for device scale factor when creating image for dragging.
https://bugs.webkit.org/show_bug.cgi?id=89489
Patch by Varun Jain <varunjain@chromium.org> on 2012-06-20
Reviewed by Adam Barth.
.:
- ManualTests/chromium/drag-image-accounts-for-device-scale.html: Added.
Source/WebCore:
Manual Test: ManualTests/chromium/drag-image-accounts-for-device-scale.html
- page/Frame.cpp:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
- 3:36 PM Changeset in webkit [120875] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fixed typos in the change log.
- 3:35 PM Changeset in webkit [120874] by
-
- 5 edits in trunk/Source
Add a != operator to ViewportArguments
https://bugs.webkit.org/show_bug.cgi?id=87505
Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>
Source/WebCore:
Add a != operator to ViewportArguments for convenience.
- dom/ViewportArguments.h:
(ViewportArguments):
(WebCore::ViewportArguments::operator!=):
Source/WebKit/blackberry:
Use != operator of ViewportArguments.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- Api/WebViewportArguments.cpp:
(BlackBerry::WebKit::WebViewportArguments::operator!=):
- 3:25 PM Changeset in webkit [120873] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing tests.
- platform/qt/Skipped:
- 3:22 PM Changeset in webkit [120872] by
-
- 1 edit14 copies in branches/chromium/1180
Merge 120859 - REGRESSION(r113885): Margin not properly applied to elements with align=center
https://bugs.webkit.org/show_bug.cgi?id=89515
Reviewed by Levi Weintraub.
Source/WebCore:
Tests: fast/block/negative-margin-start-positive-margin-end.html
fast/block/negative-start-margin-align-center.html
fast/block/positive-margin-block-child-align-center-rtl.html
fast/block/positive-margin-block-child-align-center.html
fast/block/positive-margin-start-align-center.html
fast/block/positive-margin-start-negative-margin-end-align-center.html
fast/table/table-cell-negative-start-margin-align-center.html
r113885 changed the code-path for elements with auto width to call computeInlineDirectionMargins.
However this uncovered an existing bug in the function when dealing with align="center" (text-align: -webkit-center)
where we would ignore the margin. This goes against what other browsers are doing and our previous behavior.
Note that align="left" and "right" are likely impacted too and will be investigated / fixed in follow-up changes.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeInlineDirectionMargins):
To match other browsers' behavior, changed the function to include margin in our computations.
LayoutTests:
- fast/block/negative-margin-start-positive-margin-end-expected.html: Added.
- fast/block/negative-margin-start-positive-margin-end.html: Added.
- fast/block/negative-start-margin-align-center-expected.html: Added.
- fast/block/negative-start-margin-align-center.html: Added.
- fast/block/positive-margin-block-child-align-center-expected.html: Added.
- fast/block/positive-margin-block-child-align-center.html: Added.
- fast/block/positive-margin-start-align-center-expected.html: Added.
- fast/block/positive-margin-start-align-center.html: Added.
- fast/block/positive-margin-start-negative-margin-end-align-center-expected.html: Added.
- fast/block/positive-margin-start-negative-margin-end-align-center.html: Added.
Those checks the combination of margin start / end both positive and negative.
- fast/block/positive-margin-block-child-align-center-rtl-expected.html: Added.
- fast/block/positive-margin-block-child-align-center-rtl.html: Added.
One ltr test as I didn't find any.
- fast/table/table-cell-negative-start-margin-align-center-expected.html: Added.
- fast/table/table-cell-negative-start-margin-align-center.html: Added.
This test is very similar to the one above but involves a table.
TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10578056
- 3:17 PM Changeset in webkit [120871] by
-
- 1 edit14 copies in branches/chromium/1132
Merge 120859 - REGRESSION(r113885): Margin not properly applied to elements with align=center
https://bugs.webkit.org/show_bug.cgi?id=89515
Reviewed by Levi Weintraub.
Source/WebCore:
Tests: fast/block/negative-margin-start-positive-margin-end.html
fast/block/negative-start-margin-align-center.html
fast/block/positive-margin-block-child-align-center-rtl.html
fast/block/positive-margin-block-child-align-center.html
fast/block/positive-margin-start-align-center.html
fast/block/positive-margin-start-negative-margin-end-align-center.html
fast/table/table-cell-negative-start-margin-align-center.html
r113885 changed the code-path for elements with auto width to call computeInlineDirectionMargins.
However this uncovered an existing bug in the function when dealing with align="center" (text-align: -webkit-center)
where we would ignore the margin. This goes against what other browsers are doing and our previous behavior.
Note that align="left" and "right" are likely impacted too and will be investigated / fixed in follow-up changes.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeInlineDirectionMargins):
To match other browsers' behavior, changed the function to include margin in our computations.
LayoutTests:
- fast/block/negative-margin-start-positive-margin-end-expected.html: Added.
- fast/block/negative-margin-start-positive-margin-end.html: Added.
- fast/block/negative-start-margin-align-center-expected.html: Added.
- fast/block/negative-start-margin-align-center.html: Added.
- fast/block/positive-margin-block-child-align-center-expected.html: Added.
- fast/block/positive-margin-block-child-align-center.html: Added.
- fast/block/positive-margin-start-align-center-expected.html: Added.
- fast/block/positive-margin-start-align-center.html: Added.
- fast/block/positive-margin-start-negative-margin-end-align-center-expected.html: Added.
- fast/block/positive-margin-start-negative-margin-end-align-center.html: Added.
Those checks the combination of margin start / end both positive and negative.
- fast/block/positive-margin-block-child-align-center-rtl-expected.html: Added.
- fast/block/positive-margin-block-child-align-center-rtl.html: Added.
One ltr test as I didn't find any.
- fast/table/table-cell-negative-start-margin-align-center-expected.html: Added.
- fast/table/table-cell-negative-start-margin-align-center.html: Added.
This test is very similar to the one above but involves a table.
TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10536229
- 3:15 PM Changeset in webkit [120870] by
-
- 8 edits21 deletes in trunk/LayoutTests
Computed style tests are a maintenance burden on the project
https://bugs.webkit.org/show_bug.cgi?id=87991
Reviewed by Eric Seidel.
Convert computed-style.html, computed-style-without-renderer.html and getComputedStyle-basic.xhtml
to use a whitelist of properties rather than a blacklist. The whitelist includes all properties
that are supported based on the checked in results so all ports can share the same values. Adding
new properties won't cause these tests to be rebaselined.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer.html: Remove indenting and use a fixed
width for the middle div so we don't get fractional pixel values for ports with fractional pixel
values enabled.
- fast/css/getComputedStyle/computed-style.html:
- fast/css/getComputedStyle/resources/property-names.js: Whitelist of common CSS properties.
- platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/mac/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/qt/svg/css/getComputedStyle-basic-expected.png: Removed.
- platform/qt/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- svg/css/getComputedStyle-basic-expected.txt:
- svg/css/getComputedStyle-basic.xhtml:
- 3:08 PM Changeset in webkit [120869] by
-
- 2 edits in trunk/Source/WebCore
Let XCode have its own way.
- WebCore.xcodeproj/project.pbxproj:
- 3:05 PM Changeset in webkit [120868] by
-
- 6 edits in trunk/Source/WebCore
Move m_listsInvalidatedAtDocument from NodeListsNodeData to Document
https://bugs.webkit.org/show_bug.cgi?id=89603
Reviewed by Andreas Kling.
Moved the variable. m_listsInvalidatedAtDocument is never used in non-Document nodes
so it was just wasting memory space.
- dom/Document.cpp:
(WebCore::Document::registerDynamicSubtreeNodeList):
(WebCore::Document::unregisterDynamicSubtreeNodeList):
(WebCore):
(WebCore::Document::clearNodeListCaches):
- dom/Document.h:
(Document):
- dom/DynamicNodeList.h:
(DynamicSubtreeNodeList):
- dom/Node.cpp:
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged):
(WebCore):
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes): RadioNodeList
is invalidated at document level. No need to invalidate it again here.
(WebCore::NodeListsNodeData::isEmpty):
- dom/NodeRareData.h:
(NodeListsNodeData):
- 3:02 PM Changeset in webkit [120867] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r120821.
http://trac.webkit.org/changeset/120821
https://bugs.webkit.org/show_bug.cgi?id=89605
It made duplicated reviewer entries (Requested by Ossy on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-20
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.set_reviewer):
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_set_reviewer):
(test_set_short_description_and_bug_url):
- 2:58 PM Changeset in webkit [120866] by
-
- 44 edits3 copies in trunk/Source/WebCore
Unreviewed, rolling out r120854.
http://trac.webkit.org/changeset/120854
https://bugs.webkit.org/show_bug.cgi?id=89604
Broke Chromium WebKit Linux (dbg) (Requested by arv on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-20
- Target.pri:
- UseV8.cmake:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
- bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
- bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
- bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
(WebCore):
- bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
(WebCore):
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8TextTrackListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
- css/CSSStyleSheet.idl:
- css/StyleSheet.idl:
- dom/DOMStringMap.idl:
- dom/NamedNodeMap.idl:
- html/DOMTokenList.idl:
- html/track/TextTrackList.idl:
- 2:30 PM Changeset in webkit [120865] by
-
- 8 edits in trunk/Tools
nrwt outputs empty files for wdiff output if wdiff is not installed
https://bugs.webkit.org/show_bug.cgi?id=88709
Reviewed by Tony Chang.
Reviewed by Tony Chang.
Don't write -wdiff or -pretty.html files if wdiff or prettypatch
aren't available, and clean up the handling for them in the port
code.
- Scripts/webkitpy/run_webkit_tests_integrationtest.py:
(MainTest.test_output_diffs):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.create_text_diff_and_write_result):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.check_pretty_patch):
(Port.check_wdiff):
(Port._wdiff_missing_message):
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort.check_build):
(ChromiumLinuxPort._wdiff_missing_message):
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.check_build):
(ChromiumMacPort):
(ChromiumMacPort._wdiff_missing_message):
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest):
- 2:25 PM Changeset in webkit [120864] by
-
- 3 edits in trunk/Tools
nrwt: fix unit tests for ensuring svn revision is correct
https://bugs.webkit.org/show_bug.cgi?id=89498
Reviewed by Eric Seidel.
Reviewed by Eric Seidel.
Fix the unit tests for testing that we are embedding the SVN
revision in the results json for NRWT properly; this was broken
in r120646 but because the MockHost worked differently than the
real one (by always initializing the MockSCM object) we didn't
notice. Unfortunately, just changing the default breaks all
sorts of unit tests ...
- Scripts/webkitpy/common/host_mock.py:
(MockHost.init):
(MockHost._initialize_scm):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_no_svn_revision):
(ResultSummaryTest.test_svn_revision):
- 2:22 PM Changeset in webkit [120863] by
-
- 5 edits in trunk/Tools
new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
https://bugs.webkit.org/show_bug.cgi?id=69360
Reviewed by Eric Seidel.
Reviewed by Eric Seidel.
Propagate the 'port_implementation' part of the platform (i.e.,
gtk,qt,chromium) to webkit-build-directory so that we can pick
up the gtk-specific handling of WEBKITOUTPUTDIR ...
I didn't write any additional tests for this; testing it
properly is an integration test between the python code and the
perl code, which I verified by hand.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.init):
- Scripts/webkitpy/layout_tests/port/config.py:
(Config.init):
(Config.build_directory):
- Scripts/webkitpy/layout_tests/port/config_mock.py:
(MockConfig.init):
- Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.test_build_directory_passes_port_implementation):
- 2:20 PM Changeset in webkit [120862] by
-
- 5 edits2 adds in trunk
Crash on accessing a removed renderer from percent height descendant map.
https://bugs.webkit.org/show_bug.cgi?id=88017
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/block/percent-height-descendant-not-removed-crash2.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hasPercentHeightContainerMap): helper to tell
if we have a height container map.
(WebCore):
(WebCore::RenderBlock::hasPercentHeightDescendant): change from a debug
only function to a regular function for use. no need to null check
for a percent height container map in this function.
(WebCore::RenderBlock::clearPercentHeightDescendantsFrom): helper to
clear all percent height descendants under us.
(WebCore::RenderBlock::removePercentHeightDescendantIfNeeded): helper to
clear the box if it exists in the percent height descendant map.
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed): remove the assert and change the
percent height detection check to use removePercentHeightDescendantIfNeeded.
We shouldn't rely on logicalHeight().isPercent() as it can change when our
writing mode changes. Instead, just query the map directly to see if we exist.
(WebCore::RenderBox::styleDidChange): when our writing mode changes from
horizontal to vertical or vice versa, we clear all our descendants from
the percent height descendant map. Cache the value of isHorizontalWritingMode()
before it changes in styleDidChange and compare it with the new value
(can't use oldStyle->isHorizontalWritingMode() since it can be inherited
and already updated).
LayoutTests:
- fast/block/percent-height-descendant-not-removed-crash2-expected.txt: Added.
- fast/block/percent-height-descendant-not-removed-crash2.html: Added.
- 2:15 PM Changeset in webkit [120861] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add an API to immediately enable cross-site XHR
https://bugs.webkit.org/show_bug.cgi?id=89594
Internally Reviewed by Yong Li.
Patch by Christopher Hutten-Czapski <chutten@rim.com> on 2012-06-20
Reviewed by Rob Buis.
There is no API to disable it as clients may rely on legacy behaviour
of not disabling until the next frame load.
- Api/WebPage.cpp:
(BlackBerry::WebKit::enableCrossSiteXHRRecursively):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::enableCrossSiteXHR):
(BlackBerry::WebKit::WebPage::enableCrossSiteXHR):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- 2:07 PM Changeset in webkit [120860] by
-
- 2 edits in trunk/Source/JavaScriptCore
build-webkit failure due to illegal 32-bit integer constants in code
generated by offlineasm
https://bugs.webkit.org/show_bug.cgi?id=89347
Reviewed by Geoffrey Garen.
The offending constants are the magic numbers used by offlineasm to find
offsets in the generated machine code. Added code to turn them into what
the C++ compiler will believe to be valid 32-bit values.
- offlineasm/offsets.rb:
- 2:04 PM Changeset in webkit [120859] by
-
- 3 edits14 adds in trunk
REGRESSION(r113885): Margin not properly applied to elements with align=center
https://bugs.webkit.org/show_bug.cgi?id=89515
Reviewed by Levi Weintraub.
Reviewed by Levi Weintraub.
Source/WebCore:
Tests: fast/block/negative-margin-start-positive-margin-end.html
fast/block/negative-start-margin-align-center.html
fast/block/positive-margin-block-child-align-center-rtl.html
fast/block/positive-margin-block-child-align-center.html
fast/block/positive-margin-start-align-center.html
fast/block/positive-margin-start-negative-margin-end-align-center.html
fast/table/table-cell-negative-start-margin-align-center.html
r113885 changed the code-path for elements with auto width to call computeInlineDirectionMargins.
However this uncovered an existing bug in the function when dealing with align="center" (text-align: -webkit-center)
where we would ignore the margin. This goes against what other browsers are doing and our previous behavior.
Note that align="left" and "right" are likely impacted too and will be investigated / fixed in follow-up changes.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeInlineDirectionMargins):
To match other browsers' behavior, changed the function to include margin in our computations.
LayoutTests:
- fast/block/negative-margin-start-positive-margin-end-expected.html: Added.
- fast/block/negative-margin-start-positive-margin-end.html: Added.
- fast/block/negative-start-margin-align-center-expected.html: Added.
- fast/block/negative-start-margin-align-center.html: Added.
- fast/block/positive-margin-block-child-align-center-expected.html: Added.
- fast/block/positive-margin-block-child-align-center.html: Added.
- fast/block/positive-margin-start-align-center-expected.html: Added.
- fast/block/positive-margin-start-align-center.html: Added.
- fast/block/positive-margin-start-negative-margin-end-align-center-expected.html: Added.
- fast/block/positive-margin-start-negative-margin-end-align-center.html: Added.
Those checks the combination of margin start / end both positive and negative.
- fast/block/positive-margin-block-child-align-center-rtl-expected.html: Added.
- fast/block/positive-margin-block-child-align-center-rtl.html: Added.
One ltr test as I didn't find any.
- fast/table/table-cell-negative-start-margin-align-center-expected.html: Added.
- fast/table/table-cell-negative-start-margin-align-center.html: Added.
This test is very similar to the one above but involves a table.
- 1:48 PM Changeset in webkit [120858] by
-
- 8 edits in trunk/Source
[chromium] Separate LayerRenderer initialization from updateLayers
https://bugs.webkit.org/show_bug.cgi?id=89525
Reviewed by Adrienne Walker.
Source/WebCore:
This adds an explicit call to initialize the layer renderer of a given CCLayerTreeHost instead of having it be
implicit in updateLayers(). This way the proxies can control the initialization sequence more closely and do
useful work between the two calls.
Refactor, no change in behavior. Covered by existing tests.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::initializeLayerRendererIfNeeded):
(WebCore):
(WebCore::CCLayerTreeHost::updateLayers):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::commitAndComposite):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::beginFrame):
Source/WebKit/chromium:
Update tests to call initializeLayerRendererIfNeeded() before calling updateLayers() to reflect what the proxies
do.
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
- tests/TiledLayerChromiumTest.cpp:
- 1:33 PM Changeset in webkit [120857] by
-
- 1 edit2 copies in branches/chromium/1180
Merge 120737 - Crash in RenderInline::willBeDestroyed.
BUG=103423
Review URL: https://chromiumcodereview.appspot.com/10575040
- 1:25 PM Changeset in webkit [120856] by
-
- 2 edits in trunk/LayoutTests
r120844: Skip two tests on Qt
The tests fast/block/float/previous-sibling-abspos-001.html and
fast/block/float/previous-sibling-float-001.html have pixel differences
on Qt. Skip them for now - bug 89597 opened.
Unreviewed, gardening.
- platform/qt/Skipped:
- 1:23 PM Changeset in webkit [120855] by
-
- 2 edits in trunk/Source/WebCore
SecurityOrigin::canDisplay() should return true when m_universalAccess is true
https://bugs.webkit.org/show_bug.cgi?id=84865
Patch by Yong Li <yoli@rim.com> on 2012-06-20
Reviewed by Adam Barth.
Add an early return (true) in canDisplay() for if (m_universalAccess),
as we did for canAccess() and canRequest().
No new tests. We should be good as long as this change doesn't break existing
tests, which means the contents supposed to be blocked are still blocked when
m_universalAccess is false.
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canDisplay):
- 1:16 PM Changeset in webkit [120854] by
-
- 44 edits3 deletes in trunk/Source/WebCore
[V8] Use v8::V8::AddImplicitReferences instead of SetHiddenValue
https://bugs.webkit.org/show_bug.cgi?id=80880
Reviewed by Adam Barth.
We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.
To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8). Interfaces that have *IsReachable
also have a dependent life time (just like if V8DependentLifetime was present).
Retry. Last time we got ASAN issues on some Cromium Linux bots.
No new tests. Covered by existing tests.
- Target.pri:
- UseV8.cmake:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGenerateIsReachable): Abstracted GenerateIsReachable and JSGenerateIsReachable.
(GetCustomIsReachable): Ditto.
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
- bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
- bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
- bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
- bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8TextTrackListCustom.cpp: Removed.
- css/CSSStyleSheet.idl:
- css/StyleSheet.idl:
- dom/DOMStringMap.idl:
- dom/NamedNodeMap.idl:
- html/DOMTokenList.idl:
- html/track/TextTrackList.idl:
- 1:10 PM FeatureFlags edited by
- Add a bug link for CSS_BOX_DECORATION_BREAK (diff)
- 1:00 PM Changeset in webkit [120853] by
-
- 2 edits in trunk/Tools
Fix import sorting missed in r120846
Reviewed by Tony Chang.
- Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
- 12:53 PM Changeset in webkit [120852] by
-
- 3 edits in trunk/Tools
Fix chromium win http servers after breakage introduced in r120846.
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.start_http_server):
- Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd.init):
- 12:47 PM Changeset in webkit [120851] by
-
- 4 edits in trunk/Tools
tweak output of webkit-patch print-{baselines,expectations}
https://bugs.webkit.org/show_bug.cgi?id=89588
Reviewed by Tony Chang.
Minor tweaks to the output to make it more readable, including
turning off csv by default for print-baselines with multiple ports.
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort):
- Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.execute):
(PrintBaselines.execute):
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.run_test):
(PrintExpectationsTest.test_multiple):
(PrintBaselinesTest.setUp):
(PrintBaselinesTest.test_multiple):
- 12:33 PM Changeset in webkit [120850] by
-
- 3 edits in trunk/Source/WebCore
Regression(r116408): Ctrl-A (select all) on large text file hangs the tab with high CPU usage
https://bugs.webkit.org/show_bug.cgi?id=89562
Reviewed by Ryosuke Niwa.
Rather than replace the newlines in-place (in O(n2)), build a new string using StringBuilder, which takes O(n).
No new tests, this is a perf improvement.
- platform/chromium/ClipboardUtilitiesChromium.cpp:
(WebCore::replaceNewlinesWithWindowsStyleNewlines):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::replaceNewlinesWithWindowsStyleNewlines):
- 12:28 PM Changeset in webkit [120849] by
-
- 10 edits17 adds in trunk
Add support for fit-content etc
https://bugs.webkit.org/show_bug.cgi?id=38919
Patch by Elliott Sprehn <Elliott Sprehn> on 2012-06-20
Reviewed by Tony Chang.
Source/WebCore:
Implement the CSS3 intrinsic dimension keywords for width properties and
add most of the plumbing for height properties but don't expose them
yet since this patch doesn't enforce them (matching current Gecko).
http://dev.w3.org/csswg/css3-writing-modes/#intrinsic-sizing
This patch implements -webkit-min-content, -webkit-max-content,
-webkit-fill-available and -webkit-fit-content for all width
properties.
Tests: fast/css-intrinsic-dimensions/height-dynamic-property-value.html
fast/css-intrinsic-dimensions/height-property-value.html
fast/css-intrinsic-dimensions/max-width-constrained.html
fast/css-intrinsic-dimensions/max-width-unconstrained.html
fast/css-intrinsic-dimensions/min-width.html
fast/css-intrinsic-dimensions/width-avoid-floats.html
fast/css-intrinsic-dimensions/width-dynamic-property-value.html
fast/css-intrinsic-dimensions/width-property-value.html
fast/css-intrinsic-dimensions/width.html
- css/CSSParser.cpp: Add parser support for the new keywords.
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValue.cpp:
(WebCore):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- css/LengthFunctions.cpp: Implement conversion functions.
(WebCore::minimumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::StyleBuilder::StyleBuilder): Clean up the template for old
intrinsic values and add new values. Rename old intrinsic to
LegacyIntrinsic and add support for the new dimension keywords as
Intrinsic.
- platform/Length.h:
(WebCore::Length::isIntrinsicOrAuto):
(WebCore::Length::isLegacyIntrinsic): New method to check for old
min-intrinsic and intrinsic keywords.
(WebCore::Length::isIntrinsic): New method to check for CSS3 intrinsic
dimension keywords like min-content.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegionUsing): Expose the max
and min logical preferred widths as the new keywords.
(WebCore::RenderBox::sizesLogicalWidthToFitContent): Renamed method to
be more consistent with the new MinContent naming in the spec.
- rendering/RenderBox.h:
(RenderBox):
LayoutTests:
Tests for CSS3 intrinsic dimension keywords as defined in the
writing modes spec. This tests the implementation for width and
ensures that height properties don't allow the new keywords yet
since they're not implemented by this patch.
- fast/css-intrinsic-dimensions/height-dynamic-property-value-expected.txt: Added.
- fast/css-intrinsic-dimensions/height-dynamic-property-value.html: Added.
- fast/css-intrinsic-dimensions/height-property-value-expected.txt: Added.
- fast/css-intrinsic-dimensions/height-property-value.html: Added.
- fast/css-intrinsic-dimensions/max-width-constrained-expected.html: Added.
- fast/css-intrinsic-dimensions/max-width-constrained.html: Added.
- fast/css-intrinsic-dimensions/max-width-unconstrained-expected.html: Added.
- fast/css-intrinsic-dimensions/max-width-unconstrained.html: Added.
- fast/css-intrinsic-dimensions/min-width-expected.html: Added.
- fast/css-intrinsic-dimensions/min-width.html: Added.
- fast/css-intrinsic-dimensions/width-avoid-floats-expected.html: Added.
- fast/css-intrinsic-dimensions/width-avoid-floats.html: Added.
- fast/css-intrinsic-dimensions/width-dynamic-property-value-expected.txt: Added.
- fast/css-intrinsic-dimensions/width-dynamic-property-value.html: Added.
- fast/css-intrinsic-dimensions/width-expected.html: Added.
- fast/css-intrinsic-dimensions/width-keyword-classes.css: Added.
(.min-content):
(.max-content):
(.fill-available):
(.fit-content):
(.max-width-min-content):
(.max-width-max-content):
(.max-width-fill-available):
(.max-width-fit-content):
(.min-width-min-content):
(.min-width-max-content):
(.min-width-fill-available):
(.min-width-fit-content):
- fast/css-intrinsic-dimensions/width-property-value-expected.txt: Added.
- fast/css-intrinsic-dimensions/width-property-value.html: Added.
- fast/css-intrinsic-dimensions/width.html: Added.
- 12:25 PM Changeset in webkit [120848] by
-
- 1 edit2 copies in branches/chromium/1180
Merge 120638 - REGRESSION(r118414): some pages on concursolutions.com doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=89399
http://crbug.com/132097
Reviewed by Adam Barth.
Source/WebCore:
The bug was caused by insertAdjacentHTML's not passing context element to createFragmentForInnerOuterHTML.
Test: fast/html/adjacent-html-context-element.html
- html/HTMLElement.cpp:
(WebCore::HTMLElement::insertAdjacentHTML):
LayoutTests:
Add a regression test.
- fast/html/adjacent-html-context-element-expected.txt: Added.
- fast/html/adjacent-html-context-element.html: Added.
Review URL: https://chromiumcodereview.appspot.com/10577039
- 12:17 PM Changeset in webkit [120847] by
-
- 12 edits6 adds in trunk
[chromium] webkit-backface-visibility doesn't work with video
https://bugs.webkit.org/show_bug.cgi?id=88908
When determining a contents layer's backface culling, use the parent
layer's transform and backface-visibility properties. Track which
layers need this special treatment with useParentBackfaceVisibility
and setUseParentBackfaceVisibility functions in WebCore::LayerChromium,
WebKit::WebLayer, and WebCore::CCLayerImpl.
Patch by Christopher Cameron <ccameron@chromium.org> on 2012-06-20
Reviewed by Adrienne Walker.
Source/Platform:
- chromium/public/WebLayer.h:
(WebLayer):
Add an accessor to specify that a layer should use its parent's
backface culling behavior.
Source/WebCore:
Tests: compositing/backface-visibility/backface-visibility-image.html
compositing/backface-visibility/backface-visibility-webgl.html
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setupContentsLayer):
When a contents layer is added, tag it as inheriting its backface
culling from its parent.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
Initialize new m_useParentBackfaceVisibility member variable.
(WebCore::LayerChromium::pushPropertiesTo):
Propagate m_useParentBackfaceVisibility to CCLayerImpl.
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setUseParentBackfaceVisibility):
(WebCore::LayerChromium::useParentBackfaceVisibility):
(LayerChromium):
Add m_useParentBackfaceVisibility member variable and modify
and query accessors.
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
Initialize new m_useParentBackfaceVisibility member variable.
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setUseParentBackfaceVisibility):
(WebCore::CCLayerImpl::useParentBackfaceVisibility):
(CCLayerImpl):
Add m_useParentBackfaceVisibility member variable and modify
and query accessors.
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::layerShouldBeSkipped):
When examining a layer, if the layer has
useParentBackfaceVisibility set then use the layer's parent
layer to determine backface culling.
Source/WebKit/chromium:
- src/WebLayer.cpp:
(WebKit::WebLayer::setUseParentBackfaceVisibility):
Add an accessor to specify that a layer should use its parent's
backface culling behavior.
LayoutTests:
- compositing/backface-visibility/backface-visibility-image-expected.png: Added.
- compositing/backface-visibility/backface-visibility-image-expected.txt: Added.
- compositing/backface-visibility/backface-visibility-image.html: Added.
- compositing/backface-visibility/backface-visibility-webgl-expected.png: Added.
- compositing/backface-visibility/backface-visibility-webgl-expected.txt: Added.
- compositing/backface-visibility/backface-visibility-webgl.html: Added.
- 12:00 PM Changeset in webkit [120846] by
-
- 9 edits1 add in trunk/Tools
new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
https://bugs.webkit.org/show_bug.cgi?id=88134
Reviewed by Tony Chang.
Change NRWT to spin up 2*min(child_processes, locked_shards)
http servers by default so that we are less likely to get a
bunch of http timeouts at the beginning of a test run.
Note that I had to tweak executive_mock to support mocked stderr
because the apache_http_server code reads stderr when starting a
process to ensure it started okay.
- Scripts/webkitpy/common/system/executive_mock.py:
(MockProcess.init):
- Scripts/webkitpy/common/system/outputcapture.py:
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
(Manager.start_servers_with_lock):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.start_http_server):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.start_http_server):
(TestPort._path_to_apache):
(TestPort):
(TestPort._path_to_apache_config_file):
- Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd.init):
- Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
(LayoutTestApacheHttpd.init):
- Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd.init):
- Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase.init):
- 11:42 AM Changeset in webkit [120845] by
-
- 3 edits2 adds in trunk
Source/WebCore: Don't re-enter CachedResource::removeClient() if an XHR
is canceled and restarted multiple times.
https://bugs.webkit.org/show_bug.cgi?id=89378
Reviewed by Eric Seidel.
Test: http/tests/xmlhttprequest/reentrant-cancel.html
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::cancel):
(WebCore::DocumentThreadableLoader::clearResource): Save off a copy of m_resource
then clear it, so we don't call clearResource() multiple times for the same resource.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=89378.
Reviewed by Eric Seidel.
- http/tests/xmlhttprequest/reentrant-cancel-expected.txt: Added.
- http/tests/xmlhttprequest/reentrant-cancel.html: Added.
- 11:40 AM Changeset in webkit [120844] by
-
- 3 edits10 adds in trunk
Negative margin block doesn't properly clear a float enclosed by a previous sibling
https://bugs.webkit.org/show_bug.cgi?id=10900
Reviewed by Eric Seidel.
Source/WebCore:
Tests: fast/block/float/previous-sibling-abspos-001.html
fast/block/float/previous-sibling-abspos-002.html
fast/block/float/previous-sibling-float-001.html
fast/block/float/previous-sibling-float-002.html
fast/css/clear-float-sibling.html
Parent blocks keep a list of child floats that extend out of the parent block and
by implication overhang into the parent's siblings. But this doesn't work if the
sibling has collapsing margins - it will not find the float in the previous block's
list so will ignore the float and fail to clear it.
RenderBlock:collapseMargins() needs to check if a child's collapsing margin has
reduced the height of the parent up past the bottom of its previous sibling's lowest float
and add the now overhanging float to the parent's float list if appropriate. No need to do
this if the previous sibling is a float or is positioned - the child will clear/avoid it anyway
and attempting to avoid floated children of floats causes incorrect layout.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseMargins):
LayoutTests:
- fast/block/float/previous-sibling-abspos-001-expected.html: Added.
- fast/block/float/previous-sibling-abspos-001.html: Added.
- fast/block/float/previous-sibling-abspos-002-expected.html: Added.
- fast/block/float/previous-sibling-abspos-002.html: Added.
- fast/block/float/previous-sibling-float-001-expected.html: Added.
- fast/block/float/previous-sibling-float-001.html: Added.
- fast/block/float/previous-sibling-float-002-expected.html: Added.
- fast/block/float/previous-sibling-float-002.html: Added.
- fast/css/clear-float-sibling-expected.html: Added.
- fast/css/clear-float-sibling.html: Added.
- 11:36 AM Changeset in webkit [120843] by
-
- 1 edit3 copies in branches/chromium/1180
Merge 120750 - Fix scrollbar layers being misplaced with a clipped owner layer
https://bugs.webkit.org/show_bug.cgi?id=89486
Reviewed by Simon Fraser.
Source/WebCore:
Scrollbar layers are positioned relative to their parent layer. If
that parent gets clipped, then that positioning becomes incorrect and
scrollbars get positioned relative to the clipped bounds instead of
the full bounds. Fix by not clipping in this case.
Test: compositing/overflow/scrollbars-with-clipped-owner.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds):
LayoutTests:
- compositing/overflow/scrollbars-with-clipped-owner-expected.png: Added.
- compositing/overflow/scrollbars-with-clipped-owner-expected.txt: Added.
- compositing/overflow/scrollbars-with-clipped-owner.html: Added.
TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/10536221
- 11:28 AM Changeset in webkit [120842] by
-
- 17 edits2 copies in trunk/Source/WebCore
Web Inspector: Allow module injections into the InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=89530
Add a new InjectedScriptModule abstract class that inherits InjectedScriptBase
to reuse implementation, and which javascript code is injected via
InjectedScript.
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-20
Reviewed by Pavel Feldman.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptObject.cpp:
(WebCore::ScriptObject::ScriptObject):
(WebCore):
- bindings/js/ScriptObject.h:
(ScriptObject):
(WebCore::ScriptObject::ScriptObject):
- bindings/v8/ScriptObject.cpp:
(WebCore::ScriptObject::ScriptObject):
(WebCore):
- bindings/v8/ScriptObject.h:
(ScriptObject):
(WebCore::ScriptObject::~ScriptObject):
- inspector/InjectedScript.cpp:
- inspector/InjectedScript.h:
(WebCore):
(WebCore::InjectedScript::name):
(InjectedScript):
- inspector/InjectedScriptBase.cpp:
(WebCore::InjectedScriptBase::callFunctionWithEvalEnabled):
- inspector/InjectedScriptBase.h:
(WebCore):
(InjectedScriptBase):
- inspector/InjectedScriptManager.h:
(InjectedScriptManager):
(WebCore::InjectedScriptManager::inspectedStateAccessCheck):
- inspector/InjectedScriptModule.cpp: Copied from Source/WebCore/inspector/InjectedScriptBase.h.
(WebCore):
(WebCore::InjectedScriptModule::InjectedScriptModule):
(WebCore::InjectedScriptModule::ensureInjected):
- inspector/InjectedScriptModule.h: Copied from Source/WebCore/bindings/js/ScriptObject.h.
(WebCore):
(InjectedScriptModule):
- inspector/InjectedScriptSource.js:
(.):
- 11:24 AM Changeset in webkit [120841] by
-
- 3 edits in trunk/Source/JavaScriptCore
Made the incremental sweeper more aggressive
https://bugs.webkit.org/show_bug.cgi?id=89527
Reviewed by Oliver Hunt.
This is a pre-requisite to getting rid of "berzerker GC" because we need
the sweeper to reclaim memory in a timely fashion, or we'll see a memory
footprint regression.
- heap/IncrementalSweeper.h:
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::scheduleTimer): Since the time slice is predictable,
no need to use a data member to record it.
(JSC::IncrementalSweeper::doSweep): Sweep as many blocks as we can in a
small time slice. This is better than sweeping only one block per timer
fire because that strategy has a heavy timer overhead, and artificially
delays memory reclamation.
- 11:22 AM Changeset in webkit [120840] by
-
- 4 edits in branches/chromium/1180/Source/WebCore/html/canvas
Merge 120636 - Fix framebuffer-object-attachment.html failures
https://bugs.webkit.org/show_bug.cgi?id=89387
Reviewed by Kenneth Russell.
- html/canvas/WebGLFramebuffer.cpp: fix detachment behavior with depth/stencil/depth_stencil conflicts
(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
- html/canvas/WebGLFramebuffer.h:
(WebGLFramebuffer):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer): move logic to WebGLFramebuffer
(WebCore::WebGLRenderingContext::framebufferTexture2D): Ditto.
(WebCore::WebGLRenderingContext::getParameter): Correct the wrong assumption that it's always checking the drawingbuffer's DEPTH_BITS/STENCIL_BITS
- html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
TBR=zmo@google.com
Review URL: https://chromiumcodereview.appspot.com/10584035
- 11:18 AM Changeset in webkit [120839] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Enable setAcceleratedCompositingForFixedPositionEnabled
https://bugs.webkit.org/show_bug.cgi?id=89575
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-20
Reviewed by Antonio Gomes.
Enable the flag so that we get position:fixed elemetns to be rendered
using accelerated compositing.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
- 11:11 AM Changeset in webkit [120838] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Timeline label bar jiggles when scrolling
https://bugs.webkit.org/show_bug.cgi?id=89579
Reviewed by Vsevolod Vlasov.
Adding timeline header into the timeline panel and settings its position
to absolute. Drive-by fix that updates rulers on sidebar resize.
- inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid):
(WebInspector.TimelineGrid.prototype.get gridHeaderElement):
(WebInspector.TimelineGrid.prototype.addEventDividers):
(WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype.onResize):
- inspector/front-end/timelinePanel.css:
(#timeline-grid-header):
- 10:58 AM Changeset in webkit [120837] by
-
- 9 edits in trunk/Source
[chromium] Make sure that render surfaces are not pixel doubled with a device scale factor of 2
https://bugs.webkit.org/show_bug.cgi?id=86882
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-20
Reviewed by Adrienne Walker.
To ensure that render surfaces are not pixel doubled when device scale factor is
two, the render surface's owning layer's draw transform is scaled by the
contents scale (in the same way that the parent matrix is scaled by the device
scale factor). The transformedLayerRect's dimensions also need to be in pixel
space. The surface origin transform should not scale, but needs to offset the
correct number of pixels, and the replica transforms need to be modified to
account for the scaling.
Source/WebCore:
To accomplish this, CCLayerImpl's needed to be made aware of contentsScale.
Thanks to Adrienne Walker for the computation of the replica draw transform.
Unit test: CCLayerTreeHostCommonTest.verifyRenderSurfaceTranformsInHighDPI
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setContentsScale):
(WebCore::CCLayerImpl::contentsScale):
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::CCScrollbar::totalSize):
Source/WebKit/chromium:
- tests/CCLayerTreeHostCommonTest.cpp:
- 10:51 AM Changeset in webkit [120836] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Fix JSC ChangeLog, forgot to add a comment to the ChangeLog before committing.
- 10:49 AM Changeset in webkit [120835] by
-
- 3 edits2 adds in trunk
[CSS3 Backgrounds and Borders] Implement box-decoration-break rendering.
https://bugs.webkit.org/show_bug.cgi?id=88228
Reviewed by Eric Seidel.
Source/WebCore:
Implement the new CSS property box-decoration-break. It modifies
where we decide whether the borders needs to be sliced or not by
checking if the box-decoration-break is set to clone. If it's the case
then we need to explicitely redraw all edges.
Test: fast/box-decoration-break/box-decoration-break-rendering.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::paintFillLayer):
LayoutTests:
Add new tests to cover the feature.
- fast/box-decoration-break/box-decoration-break-rendering-expected.html: Added.
- fast/box-decoration-break/box-decoration-break-rendering.html: Added.
- 10:48 AM Changeset in webkit [120834] by
-
- 20 edits2 adds in trunk/Source/JavaScriptCore
DFG should be able to print disassembly interleaved with the IR
https://bugs.webkit.org/show_bug.cgi?id=89551
Reviewed by Geoffrey Garen.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::labelIgnoringWatchpoints):
(ARMv7Assembler):
- assembler/AbstractMacroAssembler.h:
(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::labelIgnoringWatchpoints):
- assembler/X86Assembler.h:
(X86Assembler):
(JSC::X86Assembler::labelIgnoringWatchpoints):
- dfg/DFGCommon.h:
(JSC::DFG::shouldShowDisassembly):
(DFG):
- dfg/DFGDisassembler.cpp: Added.
(DFG):
(JSC::DFG::Disassembler::Disassembler):
(JSC::DFG::Disassembler::dump):
(JSC::DFG::Disassembler::dumpDisassembly):
- dfg/DFGDisassembler.h: Added.
(DFG):
(Disassembler):
(JSC::DFG::Disassembler::setStartOfCode):
(JSC::DFG::Disassembler::setForBlock):
(JSC::DFG::Disassembler::setForNode):
(JSC::DFG::Disassembler::setEndOfMainPath):
(JSC::DFG::Disassembler::setEndOfCode):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::amountOfNodeWhiteSpace):
(DFG):
(JSC::DFG::Graph::printNodeWhiteSpace):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
- dfg/DFGGraph.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(DFG):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JITCompiler):
(JSC::DFG::JITCompiler::setStartOfCode):
(JSC::DFG::JITCompiler::setForBlock):
(JSC::DFG::JITCompiler::setForNode):
(JSC::DFG::JITCompiler::setEndOfMainPath):
(JSC::DFG::JITCompiler::setEndOfCode):
- dfg/DFGNode.h:
(Node):
(JSC::DFG::Node::willHaveCodeGen):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::nodeFlagsAsString):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
- runtime/Options.h:
(Options):
- 10:27 AM Changeset in webkit [120833] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed build fix.
- tests/IDBDatabaseBackendTest.cpp:
(WebCore::MockIDBCallbacks::~MockIDBCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):
- 10:24 AM Changeset in webkit [120832] by
-
- 13 edits in trunk/Source
Use IntSize in RenderLayer to represent scroll offsets
https://bugs.webkit.org/show_bug.cgi?id=89154
Reviewed by Eric Seidel.
Source/WebCore:
Refactoring, covered by existing tests.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::scrollTo):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::forwardEvent):
- page/SpatialNavigation.cpp:
(WebCore::scrollInDirection):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::start):
Updated those call-sites to use the IntSize variant of the scrolling function.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::panScrollFromPoint):
Updated the signature to use IntPoint to avoid an extra round-trip to LayoutPoint
(furthermore touch points should be in device pixels).
(WebCore::RenderLayer::clampScrollOffset):
Added this function that clamps a scroll offset to the box's size. This enables more
code sharing between the different functions. Also removed a NULL-check that shouldn't
be needed: scrolling is a RenderBox concept so any callers should ensure that we have
a RenderBox or it makes no sense to try to scroll.
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::adjustedScrollDelta):
(WebCore::RenderLayer::scrollByRecursively):
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Updated to do IntSize arithmetic. Reuse clampScrollOffset when applicable.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::scrollToXOffset):
(WebCore::RenderLayer::scrollToYOffset):
Updated the functions to take IntSize as much as possible.
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::scrollRenderer):
Updated to pass an IntSize to scrollToOffset.
Source/WebKit/win:
- WebView.cpp:
(WebView::gesture):
Updated to pass an IntSize to scrollByRecursively.
Source/WebKit2:
- WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::gestureDidScroll):
Updated to pass an IntSize to scrollByRecursively.
- 10:22 AM Changeset in webkit [120831] by
-
- 9 edits in trunk/Source/WebKit2
[WK2] Implement Web Intent delivery
https://bugs.webkit.org/show_bug.cgi?id=88989
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-20
Reviewed by Anders Carlsson.
Add a deliverIntent() method to the WebFrame so that
Web intents can be delivered once matched to a
specific service.
- UIProcess/WebFrameProxy.cpp:
(WebKit):
(WebKit::WebFrameProxy::deliverIntent):
- UIProcess/WebFrameProxy.h:
(WebKit):
(WebFrameProxy):
- UIProcess/WebIntentData.h:
(WebKit::WebIntentData::store):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit):
(WebKit::WebFrame::deliverIntent):
- WebProcess/WebPage/WebFrame.h:
(WebKit):
(WebFrame):
- WebProcess/WebPage/WebPage.cpp:
(WebKit):
(WebKit::WebPage::deliverIntentToFrame):
- WebProcess/WebPage/WebPage.h:
(WebKit):
(WebPage):
- WebProcess/WebPage/WebPage.messages.in:
- 10:14 AM Changeset in webkit [120830] by
-
- 7 edits in branches/safari-536-branch/Source/WebKit2
Merged r120376 -> <rdar://problem/11652545>
- 9:33 AM Changeset in webkit [120829] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: mark used/allocated JS heap on the native memory bar chart.
https://bugs.webkit.org/show_bug.cgi?id=89476
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-20
Reviewed by Yury Semikhatsky.
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryBarChart):
(WebInspector.NativeMemoryBarChart.prototype._updateView):
- inspector/front-end/nativeMemoryProfiler.css:
(.memory-bar-chart-bar):
(.memory-bar-chart-unused):
(.memory-bar-chart-percent):
- 9:17 AM Changeset in webkit [120828] by
-
- 7 edits in trunk/Source
[Chromium] IndexedDB: Don't close database if pending connections are in flight
https://bugs.webkit.org/show_bug.cgi?id=89512
Source/WebCore:
Add a counter tracking connections between the two phases, which is used along with
the completed connection count to determine the total number of connections.
Reviewed by Tony Chang.
Test: webkit_unit_tests --gtest_filter='IDBDatabaseBackendTest.ConnectionLifecycle'
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::connectionCount):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::close):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::openInternal):
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
Source/WebKit/chromium:
Reviewed by Tony Chang.
- tests/IDBDatabaseBackendTest.cpp:
(MockIDBCallbacks):
(WebCore::MockIDBCallbacks::create):
(WebCore::MockIDBCallbacks::MockIDBCallbacks):
(WebCore):
(FakeIDBDatabaseCallbacks):
(WebCore::FakeIDBDatabaseCallbacks::create):
(WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
(WebCore::TEST):
- 9:15 AM Changeset in webkit [120827] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: duplicating selected text when Enter key is pressed
https://bugs.webkit.org/show_bug.cgi?id=89559
Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-06-20
Reviewed by Pavel Feldman.
- inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
The returned result of method normalize() should be used.
- 9:07 AM Changeset in webkit [120826] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] Fix memory leak in GraphicsContext3DCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=89561
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-20
Reviewed by Martin Robinson.
Fix a memory leak in GraphicsContext3D::getImageData().
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::getImageData): asNewNativeImage() returns a
caller-owned pointer to the native image data. So, using OwnPtr to manage
memory automatically.
- 9:06 AM Changeset in webkit [120825] by
-
- 2 edits in trunk/Tools
Unreviewed: Back out accidentally checked in debug print which broke a test
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.parse_output):
- 9:01 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 8:41 AM Changeset in webkit [120824] by
-
- 60 edits in trunk/Source/WebCore
Use HitTestPoint instead of LayoutPoint for nodeAtPoint.
https://bugs.webkit.org/show_bug.cgi?id=89448
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-20
Reviewed by Eric Seidel.
This patch updates the API of nodeAtPoint without changing any
functionality. This is largest change necessary to support
transforms in area-based hit-testing, but is only boilerplate.
No change in functionality. No new tests.
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::nodeAtPoint):
- rendering/EllipsisBox.h:
(EllipsisBox):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
- rendering/HitTestResult.h:
(WebCore::HitTestPoint::intersects):
(HitTestPoint):
(HitTestResult):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::nodeAtPoint):
- rendering/InlineBox.h:
(InlineBox):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineFlowBox.h:
(InlineFlowBox):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
- rendering/InlineTextBox.h:
(InlineTextBox):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::hitTestContents):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::nodeAtPoint):
- rendering/RenderEmbeddedObject.h:
(RenderEmbeddedObject):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::hitTestRegion):
- rendering/RenderFlowThread.h:
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::nodeAtPoint):
- rendering/RenderFrameSet.h:
(RenderFrameSet):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):
- rendering/RenderImage.h:
(RenderImage):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::nodeAtPoint):
- rendering/RenderInline.h:
(RenderInline):
- rendering/RenderLayer.cpp:
(WebCore::ClipRect::intersects):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestContents):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::hitTestPaginatedChildLayer):
(WebCore::RenderLayer::hitTestChildLayerColumns):
- rendering/RenderLayer.h:
(ClipRect):
(RenderLayer):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::hitTest):
- rendering/RenderLineBoxList.h:
(RenderLineBoxList):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::nodeAtPoint):
- rendering/RenderListBox.h:
(RenderListBox):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::hitTest):
(WebCore::RenderObject::nodeAtPoint):
- rendering/RenderObject.h:
(RenderObject):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::nodeAtPoint):
- rendering/RenderRegion.h:
(RenderRegion):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
- rendering/RenderTable.h:
(RenderTable):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::nodeAtPoint):
- rendering/RenderTableRow.h:
(RenderTableRow):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderTableSection.h:
(RenderTableSection):
- rendering/RenderText.h:
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::nodeAtPoint):
- rendering/RenderTextControlMultiLine.h:
(RenderTextControlMultiLine):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
- rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::nodeAtPoint):
- rendering/RenderWidget.h:
(RenderWidget):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::nodeAtPoint):
- rendering/RootInlineBox.h:
(RootInlineBox):
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
(WebCore::RenderSVGForeignObject::nodeAtPoint):
- rendering/svg/RenderSVGForeignObject.h:
(RenderSVGForeignObject):
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::nodeAtPoint):
- rendering/svg/RenderSVGModelObject.h:
(RenderSVGModelObject):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):
- rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::nodeAtFloatPoint):
(WebCore::RenderSVGText::nodeAtPoint):
- rendering/svg/RenderSVGText.h:
(RenderSVGText):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):
- rendering/svg/SVGInlineTextBox.h:
(SVGInlineTextBox):
- 8:09 AM Changeset in webkit [120823] by
-
- 3 edits2 adds in trunk
Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
https://bugs.webkit.org/show_bug.cgi?id=78789
Reviewed by Ryosuke Niwa.
PerformanceTests:
Added PerfTestRunner fixture around it.
- Animation/balls.html: Added.
Tools:
Updated parser to include fps as a valid unit.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output):
- 8:07 AM Changeset in webkit [120822] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: don't report context ids before DidCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=89567
Reviewed by Pavel Feldman.
When inspector state is restored only report existing context ids
if "did commit load" even has already been dispatched.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::restore):
- inspector/PageRuntimeAgent.h:
(WebCore):
(WebCore::PageRuntimeAgent::create):
(PageRuntimeAgent):
- 8:03 AM Changeset in webkit [120821] by
-
- 3 edits in trunk/Tools
webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
https://bugs.webkit.org/show_bug.cgi?id=67935
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-06-20
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.set_reviewer):
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_set_reviewer):
(test_set_short_description_and_bug_url):
- 6:52 AM Changeset in webkit [120820] by
-
- 76 edits in trunk/Source
[Chromium] Remove redundant #includes in compositor
https://bugs.webkit.org/show_bug.cgi?id=89503
Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-20
Reviewed by Adrienne Walker.
Source/WebCore:
Removed some redundant #includes to clarify dependency
picture. Some 90 #includes removed, some 50 less disruptive
#includes added. This brings the number of class dependencies to
902 from 1383.
No new tests are required, as this is only affects compile-time behavior.
- platform/graphics/chromium/AnimationTranslationUtil.h:
(WebCore):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
- platform/graphics/chromium/Canvas2DLayerBridge.h:
- platform/graphics/chromium/ContentLayerChromium.cpp:
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/DrawingBufferChromium.cpp:
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/ManagedTexture.cpp:
- platform/graphics/chromium/ProgramBinding.h:
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
- platform/graphics/chromium/RenderSurfaceChromium.h:
- platform/graphics/chromium/TextureCopier.cpp:
- platform/graphics/chromium/TextureLayerChromium.cpp:
- platform/graphics/chromium/TextureManager.cpp:
- platform/graphics/chromium/TiledLayerChromium.cpp:
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(WebCore):
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
- platform/graphics/chromium/cc/CCDrawQuad.cpp:
- platform/graphics/chromium/cc/CCFontAtlas.cpp:
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
- platform/graphics/chromium/cc/CCFrameRateController.h:
(WebCore):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
- platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
- platform/graphics/chromium/cc/CCLayerAnimationController.h:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
(WebCore):
- platform/graphics/chromium/cc/CCProxy.cpp:
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
- platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
- platform/graphics/chromium/cc/CCRenderSurface.h:
- platform/graphics/chromium/cc/CCRenderer.h:
- platform/graphics/chromium/cc/CCScopedThreadProxy.h:
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
- platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
- platform/graphics/chromium/cc/CCThreadProxy.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore):
- platform/graphics/chromium/cc/CCTimer.cpp:
- platform/graphics/chromium/cc/CCTimer.h:
(WebCore):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
Source/WebKit/chromium:
Minor adjustments to #include statements to remove
dependencies. No new tests.
- src/WebCompositorImpl.cpp:
- src/WebLayerTreeView.cpp:
- tests/CCLayerTestCommon.cpp:
- tests/CCLayerTreeHostImplTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
- tests/CCOcclusionTrackerTest.cpp:
- tests/CCQuadCullerTest.cpp:
- tests/CCTiledLayerImplTest.cpp:
- tests/ImageLayerChromiumTest.cpp:
- tests/LayerRendererChromiumTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
- 6:32 AM Changeset in webkit [120819] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Implement native memory bar diagram
https://bugs.webkit.org/show_bug.cgi?id=89106
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-20
Reviewed by Yury Semikhatsky.
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryBarChart):
(WebInspector.NativeMemoryBarChart.prototype._updateStats):
(WebInspector.NativeMemoryBarChart.prototype.willHide):
(WebInspector.NativeMemoryBarChart.prototype.wasShown):
(WebInspector.NativeMemoryBarChart.prototype._updateView):
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/nativeMemoryProfiler.css:
(.memory-bar-chart-name):
(.memory-bar-chart-bar):
(.memory-bar-chart-size):
(.memory-bar-chart-total):
- 6:26 AM Changeset in webkit [120818] by
-
- 4 edits in trunk/Source/WebKit2
REGRESSION (120705) : LayerTreeHostQt asserts in debug.
https://bugs.webkit.org/show_bug.cgi?id=89487
Reviewed by Noam Rosenthal.
We try to call createHandle twice on the same handle when the
first matching atlas is full. This patch solved the problem by
moving the createHandle call inside UpdateAtlas and call createHandle
only when the atlas is not full. We can also remove the surface()
getter as it is not used anymore.
- WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
- WebProcess/WebPage/UpdateAtlas.h:
(UpdateAtlas):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::beginContentUpdate):
- 5:35 AM Changeset in webkit [120817] by
-
- 13 edits in trunk
Speech JavaScript API: add SpeechRecognition.maxAlternatives attribute
https://bugs.webkit.org/show_bug.cgi?id=89459
Reviewed by Eric Seidel.
Source/WebCore:
Add the SpeechRecognition.maxAlternatives attribute.
Test: fast/speech/scripted/basics.html:
- Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::SpeechRecognition):
- Modules/speech/SpeechRecognition.h:
(WebCore::SpeechRecognition::maxAlternatives):
(WebCore::SpeechRecognition::setMaxAlternatives):
(SpeechRecognition):
- Modules/speech/SpeechRecognition.idl:
- Modules/speech/SpeechRecognitionClient.h:
(SpeechRecognitionClient):
- Modules/speech/SpeechRecognitionController.h:
(WebCore::SpeechRecognitionController::start):
(SpeechRecognitionController):
Source/WebKit/chromium:
Plumbing for the maxAlternatives attribute.
- public/WebSpeechRecognitionParams.h:
(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::maxAlternatives):
(WebSpeechRecognitionParams):
- src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::start):
- src/SpeechRecognitionClientProxy.h:
(SpeechRecognitionClientProxy):
LayoutTests:
Update the basic test to check for presence of the maxAlternatives attribute.
- fast/speech/scripted/basics-expected.txt:
- fast/speech/scripted/basics.html:
- 4:48 AM Changeset in webkit [120816] by
-
- 4 edits2 adds in trunk
applyAuthorStyles makes rules declared in all enclosing shadow dom subtrees applicable.
https://bugs.webkit.org/show_bug.cgi?id=89061
Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-20
Reviewed by Dimitri Glazkov.
Source/WebCore:
Fixing apply-author-styles bug. If there exists some shadow subtree A
and A has apply-author-styles flag set, whether some rules declared in
a tree B is applicable in A or not depends on:
- the tree B encloses the tree A, and
- all trees which enclose A and are enclosed by B has apply-author-styles set.
c.f.
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#styles
However the second rule was not implemented.
Test: fast/css/style-scoped/style-scoped-apply-author-styles.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::setupScopeStack):
Modified to add a new member variable, authorStyleBoundsIndex to
ScopeStackFrame used by m_scopeStack. The index means: if shadow dom
subtree A and B has the same value and A encloses B, all shadow dom
subtrees which enclose B and are enclosed by B have
apply-author-styles set. And B also has apply-author-styles set.
This means, if some element X has authorStyleBoundsIndex N, all
rulesets whose scopes have authorStyleBoundsIndex N are applicable in
B's tree scope. If all shadow dom subtrees have apply-author-styles
unset, the index looks almost the same as treeScope(). In this case,
Rules in different tree scopes have different author style bounds
index.
(WebCore::StyleResolver::pushScope):
(WebCore::StyleResolver::popScope):
Added the code for updating m_scopeStackParentBoundsIndex. The member
variable keeps m_scopeStackParent's author style bounds index.
(WebCore::StyleResolver::matchScopedAuthorRules):
Modified to consider author style's bounds index. Firstly applying
scoped styles declared in document if apply-author-styles is set.
Next, applying scoped styles declared in shadow dom subtree with
considering author style bounds index, i.e. considering
apply-author-styles flag.
- css/StyleResolver.h:
(WebCore::StyleResolver::ScopeStackFrame::ScopeStackFrame):
(ScopeStackFrame):
Added m_authorStyleBoundsIndex to keep apply-author-styles flag
information. m_authorStyleBoundsIndex increments by 1 if shadow root is
given and it has apply-author-styles unset.
Now rules in the same authorStyleBoundsIndex should be applied.
(StyleResolver):
Added m_scopeStackParentBoundsIndex.
As m_scopeStackParentAuthorStyleBoundsIndex is a little long,
used m_scopeStackParentBoundsIndex.
LayoutTests:
- fast/css/style-scoped/style-scoped-apply-author-styles-expected.txt: Added.
- fast/css/style-scoped/style-scoped-apply-author-styles.html: Added.
- 4:07 AM Changeset in webkit [120815] by
-
- 2 edits in trunk/Tools
Unreviewed trivial permissions fix.
- qmake/mkspecs/features/features.prf: Don't mark this file as executable.
- 3:36 AM Changeset in webkit [120814] by
-
- 5 edits2 adds in trunk/Source/WebCore
Adds DeviceMotionClientMock
https://bugs.webkit.org/show_bug.cgi?id=89220
Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-20
Reviewed by Steve Block.
No new tests because DeviceMotionClientMock is designed to enable future testing and cannot be tested in itself.
Adds DeviceMotionClientMock in WebCore to enable testing of DeviceMotion once it is fully implemented in WebKit.
This addition was originally included in https://bugs.webkit.org/show_bug.cgi?id=89197 but was split into a separate patch for easier review.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- platform/mock/DeviceMotionClientMock.cpp: Added.
(WebCore):
(WebCore::DeviceMotionClientMock::DeviceMotionClientMock):
(WebCore::DeviceMotionClientMock::setController):
(WebCore::DeviceMotionClientMock::startUpdating):
(WebCore::DeviceMotionClientMock::stopUpdating):
(WebCore::DeviceMotionClientMock::setMotion):
(WebCore::DeviceMotionClientMock::timerFired):
- platform/mock/DeviceMotionClientMock.h: Added.
(WebCore):
(DeviceMotionClientMock):
- 2:58 AM Changeset in webkit [120813] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Unreviewed build fix
The platform plugin example uses QGridLayout and thus needs QT += widgets
- examples/platformplugin/platformplugin.pro:
- 1:47 AM Changeset in webkit [120812] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Removed some tests from TestExpectations
as they were passing in the tree bots.
- platform/gtk/TestExpectations:
- 12:54 AM Changeset in webkit [120811] by
-
- 6 edits1 add in trunk/LayoutTests
Unreviewed rebaselining.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
- platform/chromium-mac-leopard/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
- platform/chromium/TestExpectations:
- 12:50 AM QtWebKitBuildBots edited by
- (diff)
- 12:00 AM Changeset in webkit [120810] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Select the marker range when right-clicking on a marker.
https://bugs.webkit.org/show_bug.cgi?id=89331
Reviewed by Hajime Morita.
Chromium always selects only one word when right-clicking on a spelling marker.
This prevents selecting whole region specified by a marker if the marker
consists of two or more words. This change retrieves a range coverted by a
marker and select the range. This emulates the behavior of Mac Chromium and it
does not need any workarounds for Mac.
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
Jun 19, 2012:
- 11:51 PM Changeset in webkit [120809] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Clicking "Clear all profiles" while ongoing recording should reset the ProfileLauncherView
https://bugs.webkit.org/show_bug.cgi?id=89464
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-06-19
Reviewed by Yury Semikhatsky.
Resetting the ProfileLauncherView in order to reflect the correct states of buttons
No new tests as UI related minor fix.
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):
- 11:46 PM Changeset in webkit [120808] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Speculative skipping to try to paint the bot green.
- platform/qt-mac/Skipped:
- 11:30 PM Changeset in webkit [120807] by
-
- 4 edits in trunk
[EFL][Regression] Build break after r120786
https://bugs.webkit.org/show_bug.cgi?id=89549
Unreviewed build fix for Efl port.
Source/WebKit2:
- CMakeLists.txt: Added disassembler in includes.
Tools:
- DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
- 11:29 PM Changeset in webkit [120806] by
-
- 3 edits in trunk/Source/WebCore
Assertion for event's target is wrong.
https://bugs.webkit.org/show_bug.cgi?id=89479
Reviewed by Hajime Morita.
Fix an assertion to ensure that event's target is reachable from a current target.
No new tests. Fix an assert condition.
- dom/EventContext.cpp:
(WebCore::EventContext::EventContext):
- dom/EventContext.h:
(EventContext):
(WebCore::EventContext::setRelatedTarget):
(WebCore::EventContext::isUnreachableNode):
(WebCore):
(WebCore::EventContext::isReachable):
- 11:23 PM Changeset in webkit [120805] by
-
- 2 edits in trunk/Source/WebKit
[CMake] Unreviewed speculative buildfix after r120786.
- CMakeLists.txt:
- 11:03 PM Changeset in webkit [120804] by
-
- 3 edits in trunk/Source/WebCore
Refactoring: Geolocation::startRequest() should not create the GeoNotifiers
https://bugs.webkit.org/show_bug.cgi?id=89533
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-06-19
Reviewed by David Kilzer.
It was odd to create the GeoNotifiers in Geolocation::startRequest() and having
assertions from the call site.
This patch move GeoNotifiers initialization to the exposed methods and pass them to
startRequest() as needed.
This will also help when adding support for dynamic permission reset and suspend/resume.
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::startRequest):
- Modules/geolocation/Geolocation.h:
(Geolocation):
- 10:51 PM Changeset in webkit [120803] by
-
- 2 edits in trunk/Source/WebKit/gtk
Refine syncLayersTimeoutCallback for Accelerated Compositing.
https://bugs.webkit.org/show_bug.cgi?id=89538
Patch by Chang Wan Hong <jourmoon@company100.net> on 2012-06-19
Reviewed by Martin Robinson.
syncLayersTimeout reschedules the timer so that it can render each frame
every 1/60 seconds on animation. However, because it takes to time to execute
renderLayersToWindow, the timer is delayed. To fix this, we must reschedule
the timer before calling renderLayersToWindow.
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::syncLayersTimeout):
- 10:40 PM Changeset in webkit [120802] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Skip one more crashing test.
- platform/qt-mac/Skipped:
- 10:36 PM Changeset in webkit [120801] by
-
- 3 edits2 adds in trunk
Source/WebCore: Fixes condition where inserting a CounterNode subtree which could result in incorrect placement.
https://bugs.webkit.org/show_bug.cgi?id=88142
Reviewed by Adam Barth.
Test: fast/css/counters/counter-reset-subtree-insert-crash.html
- rendering/CounterNode.cpp:
(WebCore::CounterNode::insertAfter):
LayoutTests: Add test which inserts a CounterNode subtree which contains reset nodes into another tree.
https://bugs.webkit.org/show_bug.cgi?id=88142
Reviewed by Adam Barth.
- fast/css/counters/counter-reset-subtree-insert-crash-expected.txt: Added.
- fast/css/counters/counter-reset-subtree-insert-crash.html: Added.
- 10:34 PM Changeset in webkit [120800] by
-
- 3 edits in trunk/LayoutTests
Unreviewed expected update after r120735.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 10:18 PM Changeset in webkit [120799] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Unreviewed buildfix after r120790. Typo fix.
- platform/graphics/gstreamer/ImageGStreamerQt.cpp:
(ImageGStreamer::ImageGStreamer):
- 10:12 PM Changeset in webkit [120798] by
-
- 31 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in fast/{files,filesystem}
https://bugs.webkit.org/show_bug.cgi?id=89462
Reviewed by Ryosuke Niwa.
- fast/files/apply-blob-url-to-img.html:
- fast/files/apply-blob-url-to-xhr.html:
- fast/files/blob-builder-crash.html:
- fast/files/blob-slice-overflow.html:
- fast/files/blob-slice-test.html:
- fast/files/create-blob-url-crash.html:
- fast/files/domurl-script-execution-context-crash.html:
- fast/files/file-reader-abort.html:
- fast/files/file-reader-directory-crash.html:
- fast/files/file-reader-event-listener.html:
- fast/files/file-reader-file-url.html:
- fast/files/file-reader-sandbox-iframe.html:
- fast/files/null-origin-string.html:
- fast/files/read-blob-async.html:
- fast/files/read-file-async.html:
- fast/files/resources/file-reader-real.html:
- fast/files/resources/setup-for-read-common.js:
- fast/files/revoke-blob-url.html:
- fast/files/script-tests/xhr-response-blob.js:
- fast/files/workers/inline-worker-via-blob-url.html:
- fast/files/workers/worker-apply-blob-url-to-xhr.html:
- fast/files/workers/worker-read-blob-async.html:
- fast/files/workers/worker-read-blob-sync.html:
- fast/files/workers/worker-read-file-async.html:
- fast/files/workers/worker-read-file-sync.html:
- fast/filesystem/cross-filesystem-op.html:
- fast/filesystem/file-after-reload-crash.html:
- fast/filesystem/file-metadata-after-write.html:
- fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
- fast/filesystem/filesystem-uri-origin.html:
- 9:31 PM Changeset in webkit [120797] by
-
- 8 edits in trunk
[Shadow DOM] ShadowRoot.host should be gone
https://bugs.webkit.org/show_bug.cgi?id=88387
Source/WebCore:
According to the w3c spec change,
i.e. https://www.w3.org/Bugs/Public/show_bug.cgi?id=16764
Removed host attribute from ShadowRoot.idl.
Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-19
Reviewed by Dimitri Glazkov.
No new tests, because this change modified only idl.
- dom/ShadowRoot.idl:
Just removed host attribute.
LayoutTests:
Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-19
Reviewed by Dimitri Glazkov.
- fast/css/style-scoped/style-scoped-in-shadow-expected.txt:
- fast/css/style-scoped/style-scoped-in-shadow.html:
- fast/dom/shadow/resources/shadow-dom.js:
(isShadowRoot):
- fast/dom/shadow/shadow-root-js-api-expected.txt:
- fast/dom/shadow/shadow-root-js-api.html:
Just removed references to shadow root's host attribute.
- 9:26 PM Changeset in webkit [120796] by
-
- 3 edits in trunk/LayoutTests
Fix a form restore test broken by HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=89539
Reviewed by Kentaro Hara.
Before HTML5 parser, we parsed innerHTML input text and we attached
renderers to parsed nodes at the same time. The parsed nodes had
restored form values because we restore form values only for attached
elements.
After HTML5 parser, we don't attach renderers during innerHTML
parsing. state-restore-to-nonedited-controls.html used innerHTML to
built a form and the test haven't worked since introducing HTML5 parser.
This patch changes the test so that it uses document.write() instead of
innerHTML.
- fast/forms/state-restore-to-non-edited-controls-expected.txt:
Note that the FAIL line is expected. It's due to Bug 88685.
- fast/forms/state-restore-to-non-edited-controls.html:
Use document.write() instead of innerHTML.
- 9:06 PM Changeset in webkit [120795] by
-
- 3 edits in trunk/Tools
NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
https://bugs.webkit.org/show_bug.cgi?id=64489
Reviewed by Tony Chang.
This change changes NRWT so that we don't start the websocket
server if we aren't running websocket tests and don't start the
HTTP server if we aren't running http tests.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._websocket_tests):
(Manager.start_servers_with_lock):
(Manager.stop_servers_with_lock):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_servers_started):
- 9:01 PM Changeset in webkit [120794] by
-
- 3 edits in trunk/Tools
test-webkitpy: add a -p flag to pass through captured output to enable debugging
https://bugs.webkit.org/show_bug.cgi?id=89158
Reviewed by Eric Seidel.
Normally when outputcapture runs it intercepts stdout/stderr,
which makes running under the debugger difficult and mostly
pointless (since you can't see any output). This change adds a
flag to test-webkitpy (-p) that will cause outputcapture to pass
through the output as well as capture it.
- Scripts/webkitpy/common/system/outputcapture.py:
(OutputCapture.stream_wrapper):
(OutputCapture._capture_output_with_name):
- Scripts/webkitpy/common/system/outputcapture_unittest.py:
(OutputCaptureTest.setUp):
- Scripts/webkitpy/test/main.py:
(Tester._parse_args):
(Tester._run_tests):
(Tester._log_exception):
(_CaptureAndPassThroughStream):
(_CaptureAndPassThroughStream.init):
(_CaptureAndPassThroughStream.write):
(_CaptureAndPassThroughStream._message_is_from_pdb):
(_CaptureAndPassThroughStream.flush):
(_CaptureAndPassThroughStream.getvalue):
- 8:43 PM Changeset in webkit [120793] by
-
- 4 edits in trunk/LayoutTests
Test fix after r120521.
- webarchive/resources/dump-webarchive.js:
- webarchive/test-duplicate-resources-expected.webarchive:
- webarchive/test-script-src-expected.webarchive:
- 8:28 PM Changeset in webkit [120792] by
-
- 1233 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in fast/doctypes, dom, dynamic, encoding, events, eventsource, and exclusions tests
https://bugs.webkit.org/show_bug.cgi?id=89438
Reviewed by Tony Chang.
- fast/doctypes/005-case-preserving.html:
- fast/doctypes/doctype-after-comment.html:
- fast/doctypes/doctype-at-end.html:
- fast/doctypes/doctype-in-element.html:
- fast/doctypes/doctype-parsing.html:
- fast/doctypes/html-doctype.html:
- fast/doctypes/xhtml-with-xhtmlmp-doctype.xhtml:
- fast/doctypes/xml-doctype.xhtml:
- fast/dom/:
- fast/dynamic/5872671.html:
- fast/dynamic/ancestor-to-absolute.html:
- fast/dynamic/checkbox-selection-crash.html:
- fast/dynamic/containing-block-change.html:
- fast/dynamic/crash-generated-counter.html:
- fast/dynamic/crash-generated-image.html:
- fast/dynamic/crash-generated-quote.html:
- fast/dynamic/crash-generated-text.html:
- fast/dynamic/crash-paint-no-documentElement-renderer.html-disabled:
- fast/dynamic/float-remove-above-line-2.html:
- fast/dynamic/float-remove-above-line.html:
- fast/dynamic/hover-before-position-after-style-change.html:
- fast/dynamic/hover-before-position-after-style-change2.html:
- fast/dynamic/hover-style-recalc-crash.html:
- fast/dynamic/hovered-detach.html:
- fast/dynamic/inline-to-block-crash.html:
- fast/dynamic/insertAdjacentElement.html:
- fast/dynamic/insertAdjacentHTML-allowed-parents.html:
- fast/dynamic/insertAdjacentHTML.html:
- fast/dynamic/insertAdjacentText.html:
- fast/dynamic/jQuery-animation-crash.html:
- fast/dynamic/layer-hit-test-crash.html:
- fast/dynamic/layer-no-longer-paginated.html:
- fast/dynamic/outerHTML-no-element.html:
- fast/dynamic/paused-event-dispatch.html:
- fast/dynamic/position-absolute-to-fixed-crash.html:
- fast/dynamic/position-change-layout.html:
- fast/dynamic/recursive-layout.html:
- fast/dynamic/style-access-late-stylesheet-load.html:
- fast/dynamic/subtree-common-root.html:
- fast/dynamic/subtree-table-cell-height.html:
- fast/dynamic/subtree-unrooted.html:
- fast/encoding/:
- fast/events/:
- platform/chromium/fast/events/drag-downloadURL.html:
- platform/chromium/fast/events/intercept-postmessage.html:
- platform/chromium/fast/events/rtl-scrollbar.html:
- platform/gtk/fast/events/event-sender-metakey.html:
- platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk.html:
- platform/mac/fast/dom/character-index-for-point.html:
- platform/mac/fast/dom/objc-wrapper-identity.html:
- platform/mac/fast/dom/wrapper-classes-objc.html:
- platform/mac/fast/dom/wrapper-round-tripping.html:
- platform/mac/fast/events/objc-event-api.html:
- platform/mac/fast/events/objc-keyboard-event-creation.html:
- platform/qt/fast/events/event-sender-keydown-frame.html:
- platform/win/fast/events/alt-numpad.html:
- platform/win/fast/events/alt-space-scroll.html:
- platform/win/fast/events/double-dead-char.html:
- platform/win/fast/events/keyLocation-numpad.html:
- platform/win/fast/events/panScroll-correct-direction.html:
- platform/win/fast/events/panScroll-event-fired.html:
- platform/win/fast/events/panScroll-image-no-scroll.html:
- platform/win/fast/events/panScroll-imageMap-href-no-scroll.html:
- platform/win/fast/events/panScroll-imageMap-noHref-scroll.html:
- platform/win/fast/events/panScroll-nested-divs.html:
- platform/win/fast/events/panScroll-no-iframe-jump.html:
- platform/win/fast/events/panScroll-preventDefault.html:
- platform/win/fast/events/script-tests/context-click-events.js:
- 8:27 PM Changeset in webkit [120791] by
-
- 21 edits in trunk/Source/WebCore
Pass ScriptValue by const ref where possible
https://bugs.webkit.org/show_bug.cgi?id=89531
Reviewed by Kentaro Hara.
Previously ScriptValue was sometimes passed by value, sometimes by const ref.
For consistency and optimality, pass by const ref everywhere (except where
ScriptValue is returned from non-accessor methods).
No new tests, no change in behavior.
- bindings/js/ScriptFunctionCall.h:
(ScriptCallback):
- bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::getHeapObjectId):
- bindings/js/ScriptProfiler.h:
(ScriptProfiler):
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::setException):
- bindings/js/WorkerScriptController.h:
(WorkerScriptController):
- bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptCallback::ScriptCallback):
- bindings/v8/ScriptFunctionCall.h:
(ScriptCallback):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::getHeapObjectId):
(WebCore):
- bindings/v8/ScriptProfiler.h:
(ScriptProfiler):
- bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::operator!=):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::setException):
- bindings/v8/WorkerScriptController.h:
(WorkerScriptController):
- css/MediaQueryListListener.h:
(WebCore::MediaQueryListListener::create):
(WebCore::MediaQueryListListener::MediaQueryListListener):
- dom/CustomEvent.cpp:
(WebCore::CustomEvent::initCustomEvent):
- dom/CustomEvent.h:
(CustomEvent):
(WebCore::CustomEvent::detail):
- dom/MessageEvent.h:
(WebCore::MessageEvent::dataAsScriptValue):
- dom/PopStateEvent.h:
(WebCore::PopStateEvent::state):
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::wrapObject):
- inspector/InjectedScript.h:
(InjectedScript):
- 7:25 PM Changeset in webkit [120790] by
-
- 12 edits in trunk
[GStreamer] 0.11 video-sink
https://bugs.webkit.org/show_bug.cgi?id=77087
Reviewed by Martin Robinson.
- configure.ac: Fix required gstreamer 0.11 version
Source/WebCore:
Port the video sink to GStreamer 0.11 APIs. There is no change in
functionality compared to 0.10, for now.
- platform/graphics/gstreamer/GStreamerVersioning.cpp:
(webkitGetVideoSizeAndFormatFromCaps):
(webkitGstCreateBuffer):
- platform/graphics/gstreamer/GStreamerVersioning.h:
(WebCore):
- platform/graphics/gstreamer/ImageGStreamer.h:
(WebCore::ImageGStreamer::createImage):
(WebCore::ImageGStreamer::setCropRect):
(WebCore::ImageGStreamer::rect):
(ImageGStreamer):
- platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer):
- platform/graphics/gstreamer/ImageGStreamerQt.cpp:
(ImageGStreamer::ImageGStreamer):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(_WebKitVideoSinkPrivate):
(webkitVideoSinkRender):
(webkitVideoSinkProposeAllocation):
(webkit_video_sink_class_init):
- platform/graphics/gstreamer/VideoSinkGStreamer.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- 7:15 PM Changeset in webkit [120789] by
-
- 12 edits in trunk/Source
Add monitor profile support for Win
https://bugs.webkit.org/show_bug.cgi?id=88565
Patch by Tony Payne <tpayne@chromium.org> on 2012-06-19
Reviewed by Eric Seidel.
Source/Platform:
- chromium/public/Platform.h:
(Platform):
(WebKit::Platform::screenColorProfile):
Source/WebCore:
Tests: fast/images/jpeg-with-color-profile.html
fast/images/png-with-color-profile.html. Also covered by numerous
layout tests.
- WebCore.gyp/WebCore.gyp:
- platform/PlatformScreen.h:
(WebCore):
- platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenColorProfile):
(WebCore):
- platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenColorProfile):
(WebCore):
- platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenColorProfile):
(WebCore):
- platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenColorProfile):
(WebCore):
- platform/image-decoders/ImageDecoder.h:
(ImageFrame):
(ImageDecoder):
(WebCore::ImageDecoder::qcmsOutputDeviceProfile):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(turboSwizzled):
(colorSpaceHasAlpha):
- 7:12 PM Changeset in webkit [120788] by
-
- 2 edits in trunk/Tools
garden-o-matic fails to rebaseline tests with MISSING results
https://bugs.webkit.org/show_bug.cgi?id=89521
Reviewed by Kenneth Russell.
If the bots report "MISSING", we should try to find PNG and TXT results on the server.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
- 6:46 PM Changeset in webkit [120787] by
-
- 2 edits in trunk/Tools
svn.delete_list fails to delete empty parent directories
https://bugs.webkit.org/show_bug.cgi?id=89520
Reviewed by Dirk Pranke.
These functions were calling scm.delete and scm.add, which already
delete the parent directory. We'd get an exception when we tried to
delete the parent directory again.
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN._add_parent_directories):
(SVN._delete_parent_directories):
- 6:33 PM Changeset in webkit [120786] by
-
- 26 edits1 add in trunk/Source/JavaScriptCore
JSC should be able to show disassembly for all generated JIT code
https://bugs.webkit.org/show_bug.cgi?id=89536
Reviewed by Gavin Barraclough.
Now instead of doing linkBuffer.finalizeCode(), you do
FINALIZE_CODE(linkBuffer, (... explanation ...)). FINALIZE_CODE() then
prints your explanation and the disassembled code, if
Options::showDisassembly is set to true.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- assembler/LinkBuffer.cpp: Added.
(JSC):
(JSC::LinkBuffer::finalizeCodeWithoutDisassembly):
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::performFinalization):
(JSC::LinkBuffer::dumpLinkStatistics):
(JSC::LinkBuffer::dumpCode):
- assembler/LinkBuffer.h:
(LinkBuffer):
(JSC):
- assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodeRef::tryToDisassemble):
(MacroAssemblerCodeRef):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
- dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
- disassembler/Disassembler.h:
(JSC):
(JSC::tryToDisassemble):
- disassembler/UDis86Disassembler.cpp:
(JSC::tryToDisassemble):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITCode.h:
(JSC::JITCode::tryToDisassemble):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
- jit/ThunkGenerators.cpp:
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
- llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):
- runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
- runtime/Options.h:
(Options):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
- 6:31 PM Changeset in webkit [120785] by
-
- 3 edits in trunk/Tools
webkitpy: Simplify fetch_bugs_matching_search()
https://bugs.webkit.org/show_bug.cgi?id=89497
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-19
Reviewed by Adam Barth.
Removed parameter with default value. It's not being used
and the handling of the parameter was wrong. Saves a check.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.fetch_bugs_matching_search):
- Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.fetch_bugs_matching_search):
- 6:29 PM Changeset in webkit [120784] by
-
- 1 edit4 deletes in trunk/LayoutTests
Remove the failing expected results added in
http://trac.webkit.org/changeset/119190 now that these tests pass.
Rubber-stamped by Jessie Berlin.
- platform/win/fast/frames/frame-set-scaling-hit-expected.txt: Removed.
- platform/win/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Removed.
- platform/win/fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Removed.
- platform/win/fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Removed.
- 6:04 PM Changeset in webkit [120783] by
-
- 3 edits2 adds in trunk
[V8] Fix issue where a callback got a null calling context
https://bugs.webkit.org/show_bug.cgi?id=89532
Reviewed by Kentaro Hara.
Source/WebCore:
Test: fast/dom/Window/post-message-crash.html
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback): Check the calling context and throw a type error (like JSC) if it is null.
LayoutTests:
- fast/dom/Window/post-message-crash-expected.txt: Added.
- fast/dom/Window/post-message-crash.html: Added.
- 5:54 PM Changeset in webkit [120782] by
-
- 4 edits in branches/safari-536-branch/Source
Versioning.
- 5:49 PM Changeset in webkit [120781] by
-
- 1 copy in tags/Safari-536.20
New Tag.
- 5:40 PM Changeset in webkit [120780] by
-
- 9 edits in trunk/Source/WebCore
Refactor RenderFlexibleBox terminology to use grow/shrink instead of positive/negative
https://bugs.webkit.org/show_bug.cgi?id=89493
Reviewed by Eric Seidel.
The spec stopped referring to positive and negative flex and now
talks about flex grow and flex shrink. Also, the preferred size is
now known as the flex basis. Make the code match the terms used in
the spec. http://dev.w3.org/csswg/css3-flexbox/
This will also make it easier to split flex into long hand notation
(flex-grow, flex-shrink and flex-basis).
No new tests, covered by existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::PropertyWrapperFlex::equals):
(WebCore::PropertyWrapperFlex::blend):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flexBasisForChild):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
(WebCore::RenderFlexibleBox::freezeViolations):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
- rendering/RenderFlexibleBox.h:
- rendering/style/RenderStyle.h:
- rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
- rendering/style/StyleFlexibleBoxData.h:
(StyleFlexibleBoxData):
- 5:25 PM Changeset in webkit [120779] by
-
- 2 edits1 delete in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
- platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/resize-while-save-active-expected.txt: Removed.
- platform/chromium/TestExpectations:
Referenced bugs 89529 and 89534.
- 5:20 PM Changeset in webkit [120778] by
-
- 4 edits1 delete in trunk/Source/JavaScriptCore
[Qt][Mac] REGRESSION(r120742): It broke the build
https://bugs.webkit.org/show_bug.cgi?id=89516
Reviewed by Geoffrey Garen.
Removing GCActivityCallbackCF.cpp because it doesn't mesh well with cross-platform
code on Darwin (e.g. Qt). We now use plain ol' vanilla ifdefs to handle platforms
without CF support. These if-defs will probably disappear in the future when we
use cross-platform timers in HeapTimer.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/GCActivityCallback.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::cancel):
- runtime/GCActivityCallbackCF.cpp: Removed.
- 5:15 PM Changeset in webkit [120777] by
-
- 2 edits in trunk/Tools
webkitpy: remove unneeded imports in layout_tests/port/chromium.py
https://bugs.webkit.org/show_bug.cgi?id=89522
Reviewed by Eric Seidel.
They were no longer being used. No tests necessary.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 5:09 PM Changeset in webkit [120776] by
-
- 5 edits3 adds in trunk
Source/WebCore: Make DOMFileSystem selectively structure clonable so it can be the body of a web intent.
https://bugs.webkit.org/show_bug.cgi?id=88267
Patch by Steve VanDeBogart <vandebo@chromium.org> on 2012-06-19
Reviewed by David Levin.
This functionality will allow FileSystem API objects to be dispatched to
web content in order to enable, for instance, an intent notifying web
content that a particular filesystem has been mounted by the local
system. The goal at this point is not to enable across-the-board
clonability, but just for handling the particular use case.
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::V8ObjectMap::Writer::writeDOMFileSystem):
(WebCore::V8ObjectMap::Serializer::writeDOMFileSystem):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Reader::readDOMFileSystem):
LayoutTests: Add filesystem regression test to check that the filesystem object is
not serializable as created by javascript.
https://bugs.webkit.org/show_bug.cgi?id=88267
Patch by Greg Billock <gbillock@google.com> on 2012-06-19
Reviewed by David Levin.
- fast/filesystem/filesystem-unserializable-expected.html: Added.
- fast/filesystem/filesystem-unserializable.html: Added.
- fast/filesystem/script-tests/filesystem-unserializable.js: Added.
- 5:07 PM Changeset in webkit [120775] by
-
- 76 edits in trunk/Source
Unreviewed, rolling out r120772.
http://trac.webkit.org/changeset/120772
https://bugs.webkit.org/show_bug.cgi?id=89503
Broke build on Chromium Mac
Source/WebCore:
- platform/graphics/chromium/AnimationTranslationUtil.h:
(WebCore):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
- platform/graphics/chromium/Canvas2DLayerBridge.h:
- platform/graphics/chromium/ContentLayerChromium.cpp:
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/DrawingBufferChromium.cpp:
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore):
- platform/graphics/chromium/ImageLayerChromium.cpp:
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/ManagedTexture.cpp:
- platform/graphics/chromium/ProgramBinding.h:
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
- platform/graphics/chromium/RenderSurfaceChromium.h:
- platform/graphics/chromium/TextureCopier.cpp:
- platform/graphics/chromium/TextureLayerChromium.cpp:
- platform/graphics/chromium/TextureManager.cpp:
- platform/graphics/chromium/TiledLayerChromium.cpp:
- platform/graphics/chromium/TiledLayerChromium.h:
(WebCore):
- platform/graphics/chromium/cc/CCActiveAnimation.h:
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
- platform/graphics/chromium/cc/CCDrawQuad.cpp:
- platform/graphics/chromium/cc/CCFontAtlas.cpp:
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
- platform/graphics/chromium/cc/CCFrameRateController.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
- platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
- platform/graphics/chromium/cc/CCLayerAnimationController.h:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
- platform/graphics/chromium/cc/CCProxy.cpp:
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
- platform/graphics/chromium/cc/CCRenderPass.h:
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
- platform/graphics/chromium/cc/CCRenderSurface.h:
- platform/graphics/chromium/cc/CCRenderer.h:
(WebCore):
- platform/graphics/chromium/cc/CCScopedThreadProxy.h:
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
- platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
- platform/graphics/chromium/cc/CCThreadProxy.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
- platform/graphics/chromium/cc/CCTimer.cpp:
- platform/graphics/chromium/cc/CCTimer.h:
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
Source/WebKit/chromium:
- src/WebCompositorImpl.cpp:
- src/WebLayerTreeView.cpp:
- tests/CCLayerTestCommon.cpp:
- tests/CCLayerTreeHostImplTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
- tests/CCOcclusionTrackerTest.cpp:
- tests/CCQuadCullerTest.cpp:
- tests/CCTiledLayerImplTest.cpp:
- tests/ImageLayerChromiumTest.cpp:
- tests/LayerRendererChromiumTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
- 4:50 PM Changeset in webkit [120774] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Should check the return value of fromUTF8() before executing the script.
https://bugs.webkit.org/show_bug.cgi?id=89500
Patch by Yong Li <yoli@rim.com> on 2012-06-19
Reviewed by Rob Buis.
PR# 166623.
WebPagePrivate::executeJavaScript() should check the return value of fromUTF8()
before executing the script to avoid potential crash on invalid script source.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
- 4:47 PM Changeset in webkit [120773] by
-
- 2 edits in trunk/LayoutTests
Skipping failing tests to keep the bots green. Filed
https://bugs.webkit.org/show_bug.cgi?id=89528 to track fixing the
real problem.
- platform/mac/Skipped:
- 4:46 PM Changeset in webkit [120772] by
-
- 76 edits in trunk/Source
[Chromium] Remove redundant #includes in compositor
https://bugs.webkit.org/show_bug.cgi?id=89503
Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-19
Reviewed by Adrienne Walker.
Source/WebCore:
Removed some redundant #includes to clarify dependency
picture. Some 90 #includes removed, some 50 less disruptive
#includes added. This brings the number of class dependencies to
902 from 1383.
No new tests are required, as this is only affects compile-time behavior.
- platform/graphics/chromium/AnimationTranslationUtil.h:
(WebCore):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
- platform/graphics/chromium/Canvas2DLayerBridge.h:
- platform/graphics/chromium/ContentLayerChromium.cpp:
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/DrawingBufferChromium.cpp:
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/ManagedTexture.cpp:
- platform/graphics/chromium/ProgramBinding.h:
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
- platform/graphics/chromium/RenderSurfaceChromium.h:
- platform/graphics/chromium/TextureCopier.cpp:
- platform/graphics/chromium/TextureLayerChromium.cpp:
- platform/graphics/chromium/TextureManager.cpp:
- platform/graphics/chromium/TiledLayerChromium.cpp:
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(WebCore):
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
- platform/graphics/chromium/cc/CCDrawQuad.cpp:
- platform/graphics/chromium/cc/CCFontAtlas.cpp:
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
- platform/graphics/chromium/cc/CCFrameRateController.h:
(WebCore):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
- platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
- platform/graphics/chromium/cc/CCLayerAnimationController.h:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
(WebCore):
- platform/graphics/chromium/cc/CCProxy.cpp:
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
- platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
- platform/graphics/chromium/cc/CCRenderSurface.h:
- platform/graphics/chromium/cc/CCRenderer.h:
- platform/graphics/chromium/cc/CCScopedThreadProxy.h:
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
- platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
- platform/graphics/chromium/cc/CCThreadProxy.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore):
- platform/graphics/chromium/cc/CCTimer.cpp:
- platform/graphics/chromium/cc/CCTimer.h:
(WebCore):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
Source/WebKit/chromium:
Minor adjustments to #include statements to remove
dependencies. No new tests.
- src/WebCompositorImpl.cpp:
- src/WebLayerTreeView.cpp:
- tests/CCLayerTestCommon.cpp:
- tests/CCLayerTreeHostImplTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
- tests/CCOcclusionTrackerTest.cpp:
- tests/CCQuadCullerTest.cpp:
- tests/CCTiledLayerImplTest.cpp:
- tests/ImageLayerChromiumTest.cpp:
- tests/LayerRendererChromiumTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
- 4:43 PM Changeset in webkit [120771] by
-
- 4 edits in branches/chromium/1180/Source/WebCore
Merge 120640 - [chromium] REGRESSION(r120346) ContentLayerPainter should clear rect to be painted
https://bugs.webkit.org/show_bug.cgi?id=89376
Reviewed by Adrienne Walker.
In r120346, a refactor moved a clearRect()/clip() call from ContentLayerPainter - which all
ContentLayerChromiums use - out to OpaqueRectTrackingContentLayerDelegate - which all GraphicsLayerChromium
backed layers use, but which callers using WebContentLayer directly do not use. This meant that the canvas
wasn't cleared/clipped as WebContentLayerClient.h claimed it would be. This moves the clear and the clip
into CanvasLayerTextureUpdater which all paths use, including layers that don't use the ContentLayerPainter.
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::paint):
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
TBR=jamesr@google.com
BUG=132982
Review URL: https://chromiumcodereview.appspot.com/10574034
- 4:39 PM Changeset in webkit [120770] by
-
- 5 edits in trunk/Source/WebCore
Align RenderLayer's descendant dependent flags semantics
https://bugs.webkit.org/show_bug.cgi?id=89241
Reviewed by Simon Fraser.
Refactoring only, covered by existing tests.
This change aligns the naming and implementation of the different descendant
dependent flags. While aligning, I found some bugs (inefficiencies) with how
the visible descendant flags was computed.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setHasVisibleContent):
Changed this method to not take a boolean as every callers was passing 'true'.
Reworked the logic under this assumption.
(WebCore::RenderLayer::dirtyVisibleContentStatus):
Updated after the following renaming.
(WebCore::RenderLayer::dirtyAncestorChainVisibleDescendantStatus):
Renamed this function from dirtyVisibleDescendantStatus to match the hasSelfPaintingLayer
naming and implementation.
(WebCore::RenderLayer::setAncestorChainHasVisibleDescendant):
Added this function to factor the visible descendant setting out of defunct childVisibilityChanged.
Also improved the efficiency of the function by clearing the dirty flag as it goes up (an unnoticed bug).
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
Updated to use the new functions lieu of childVisibilityChanged.
- rendering/RenderLayer.h:
(RenderLayer::childVisibilityChanged):
Removed this function as it wasn't adding much and it's a lot more clear to call
dirtyAncestorChainVisibleDescendantStatus / setAncestorChainHasVisibleDescendant.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Updated those callers after removing the boolean parameter from setHasVisibleContent.
- 4:21 PM Changeset in webkit [120769] by
-
- 10 edits2 adds in trunk/Source/WebCore
Web Inspector: Extract InjectedScriptBase class from the InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=89107
Extract methods from the InjectedScript that do not depend on
the concrete InjectedScriptSource.js implementation.
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-19
Reviewed by Pavel Feldman.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::nodeForObjectId):
(WebCore::InjectedScript::releaseObject):
(WebCore::InjectedScript::wrapCallFrames):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapSerializedObject):
(WebCore::InjectedScript::findObjectById):
(WebCore::InjectedScript::inspectNode):
(WebCore::InjectedScript::releaseObjectGroup):
(WebCore::InjectedScript::nodeAsScriptValue):
- inspector/InjectedScript.h:
(WebCore):
(InjectedScript):
- inspector/InjectedScriptBase.cpp: Added.
(WebCore):
(WebCore::InjectedScriptBase::InjectedScriptBase):
(WebCore::InjectedScriptBase::canAccessInspectedWindow):
(WebCore::InjectedScriptBase::injectedScriptObject):
(WebCore::InjectedScriptBase::callFunctionWithEvalEnabled):
(WebCore::InjectedScriptBase::makeCall):
(WebCore::InjectedScriptBase::makeEvalCall):
- inspector/InjectedScriptBase.h: Copied from Source/WebCore/bindings/js/ScriptObject.h.
(WebCore):
(InjectedScriptBase):
(WebCore::InjectedScriptBase::~InjectedScriptBase):
(WebCore::InjectedScriptBase::hasNoValue):
(WebCore::InjectedScriptBase::scriptState):
- inspector/InspectorAllInOne.cpp:
- 4:19 PM Changeset in webkit [120768] by
-
- 2 edits1 move2 adds2 deletes in trunk/LayoutTests
[Chromium][Mac] Layout Test ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm is failing
https://bugs.webkit.org/show_bug.cgi?id=89411
Unreviewed test expectations update generated by garden-o-matic.
- ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt.
- platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Removed.
- platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
- platform/chromium/TestExpectations:
Removed IMAGE MISSING expectation for this test.
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Removed.
- 4:10 PM Changeset in webkit [120767] by
-
- 3 edits3 adds in trunk
DFG CFA forgets to notify subsequent phases of found constants if it proves LogicalNot to be a constant
https://bugs.webkit.org/show_bug.cgi?id=89511
<rdar://problem/11700089>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
LayoutTests:
- fast/js/dfg-constant-fold-logical-not-branch-expected.txt: Added.
- fast/js/dfg-constant-fold-logical-not-branch.html: Added.
- fast/js/script-tests/dfg-constant-fold-logical-not-branch.js: Added.
(foo1):
(foo2):
(Stuff):
(Stuff.prototype.thingy):
(Stuff.prototype.otherThingy):
- 4:09 PM Changeset in webkit [120766] by
-
- 1 edit10 deletes in trunk/LayoutTests
Remove the failing results added in
http://trac.webkit.org/changeset/119144 and
http://trac.webkit.org/changeset/119149 now that these tests pass
without them.
Rubber-stamped by Jessie Berlin.
- platform/win/fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Removed.
- platform/win/fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Removed.
- platform/win/fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Removed.
- platform/win/fast/events/popup-blocked-from-untrusted-mouse-click-expected.txt: Removed.
- platform/win/fast/events/popup-blocking-timers-expected.txt: Removed.
- platform/win/fast/events/remove-target-in-mouseup-deep-expected.txt: Removed.
- platform/win/fast/events/remove-target-in-mouseup-expected.txt: Removed.
- platform/win/fast/events/remove-target-in-mouseup-insertback-expected.txt: Removed.
- platform/win/fast/events/remove-target-in-mouseup-twice-expected.txt: Removed.
- platform/win/fast/events/remove-target-with-shadow-in-drag-expected.txt: Removed.
- 3:51 PM Changeset in webkit [120765] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r120621.
http://trac.webkit.org/changeset/120621
https://bugs.webkit.org/show_bug.cgi?id=89518
Memory graph should have been behind the experimental flag.
(Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-19
- inspector/front-end/NativeMemorySnapshotView.js:
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
- inspector/front-end/nativeMemoryProfiler.css:
(.memory-blocks-list .item):
- 3:49 PM Changeset in webkit [120764] by
-
- 2 edits in trunk/Source/WebCore
The CSS_WRAP_SHAPE CSSWrapShape::Type is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=89403
Patch by Hans Muller <hmuller@adobe.com> on 2012-06-19
Reviewed by Eric Seidel.
Removed CSS_WRAP_SHAPE_PATH definition from CSSWrapShapes.h.
It's no longer required. This definition was never used or
tested, no new tests are required.
- css/CSSWrapShapes.h:
- 3:48 PM Changeset in webkit [120763] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Missing notifyContentRendered() when resuming rendering
https://bugs.webkit.org/show_bug.cgi?id=89507
RIM PR 150049
Reviewed by Antonio Gomes.
All the current calls to notifyContentRendered() are
located in the RenderQueue, but this omits the case
when we force rendering from resumeBackingStore()
after rendering had been suspended for a while.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
- 3:46 PM Changeset in webkit [120762] by
-
- 1 edit2 copies in branches/chromium/1132
Merge 120559
BUG=130356
Review URL: https://chromiumcodereview.appspot.com/10536212
- 3:34 PM Changeset in webkit [120761] by
-
- 3 edits4 adds in trunk
Absolute positioned objects should not be added to anonymous block lists
https://bugs.webkit.org/show_bug.cgi?id=87768
Reviewed by Abhishek Arya.
Source/WebCore:
containingBlock() was returning an anonymous block for absolute
positioned objects under a relative positioned inline in the case
that the inline is split and the object is underneath the block
continuation. Anonymous blocks should never have anything in their
positioned object lists because they can be destroyed at any time
for a different reasons such as anonymous block merging, which is
a problem for layout if they have m_posChildNeedsLayout set.
This patch adds a generic check for anonymous blocks in
containingBlock() to correct this problem.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
LayoutTests:
Test crashing condition in bug 87768.
- fast/block/positioning/abspositioned-object-under-split-relpositioned-inline-crash-expected.txt: Added
- fast/block/positioning/abspositioned-object-under-split-relpositioned-inline-crash.html: Added
- fast/block/positioning/insert-positioned-in-anonymous-crash-expected.txt: Added
- fast/block/positioning/insert-positioned-in-anonymous-crash.html: Added
- 3:30 PM Changeset in webkit [120760] by
-
- 5 edits in trunk
Source/WebCore: Web Inspector: extensionPanel.onSearch
actionstrings should be
enumerated.
https://bugs.webkit.org/show_bug.cgi?id=89509
Patch by Jan Keromnes <janx@linux.com> on 2012-06-19
Reviewed by Pavel Feldman.
Fixed LayoutTests/inspector/extensions/extensions-api-expected.txt
accordingly.
- inspector/front-end/ExtensionAPI.js:
(defineCommonExtensionSymbols):
(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler):
(injectedExtensionAPI.Panels.prototype.get SearchAction):
- inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.searchCanceled):
(WebInspector.ExtensionPanel.prototype.performSearch):
(WebInspector.ExtensionPanel.prototype.jumpToNextSearchResult):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
LayoutTests: Web Inspector: extensionPanel.onSearch
actionstrings should be enumerated
https://bugs.webkit.org/show_bug.cgi?id=89509
Patch by Jan Keromnes <janx@linux.com> on 2012-06-19
Reviewed by Pavel Feldman.
- inspector/extensions/extensions-api-expected.txt:
- 3:18 PM Changeset in webkit [120759] by
-
- 5 edits in trunk/Source/WebCore
[chromium] Add an allocation step for CCRenderer before drawing a frame
https://bugs.webkit.org/show_bug.cgi?id=88924
Reviewed by Adrienne Walker.
This step will be used to decide which RenderPass textures can be kept
alive and do not need to be drawn again.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore):
(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
(WebCore::LayerRendererChromium::beginDrawingFrame):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
- platform/graphics/chromium/cc/CCRenderer.h:
(CCRenderer):
- 3:01 PM Changeset in webkit [120758] by
-
- 2 edits1 add in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/resize-while-save-active-expected.txt:
Added expectations without trailing newlines; unclear why this only happens in this configuration.
- platform/chromium/TestExpectations:
Added reference to https://bugs.webkit.org/show_bug.cgi?id=89510 .
- 2:44 PM Changeset in webkit [120757] by
-
- 12 edits2 adds in trunk/Source/WebCore
[CSS Shaders] Create a shared object between FECustomFilter objects to store the shared resources
https://bugs.webkit.org/show_bug.cgi?id=87878
Reviewed by Dean Jackson.
An object called CustomFilterGlobalContext is created the first time a new FECustomFilter is needed in a document.
It is used to store the GraphicsContext3D needed to render the CSS Shaders. The context is shared by all the elements
in a document (no cross-domain).
More resources will be shared in following patches, including precompiled shaders and vertices/indices data.
https://bugs.webkit.org/show_bug.cgi?id=88427
https://bugs.webkit.org/show_bug.cgi?id=88429
The plan is to make CustomFilterGlobalContext and FECustomFilter (or a base class extracted out of it) usable from platform
code in the hardware accelerated compositing layer. The only dependency of the code is on the GraphicsContext3D.
No new tests. No functionality is changed yet, just added the new objects.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/CustomFilterGlobalContext.cpp: Added.
(WebCore):
(WebCore::CustomFilterGlobalContext::CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):
- platform/graphics/filters/CustomFilterGlobalContext.h: Added.
(WebCore):
(CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::context):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter): Changed to use the global context instead of the host window.
(WebCore::FECustomFilter::create):
(WebCore::FECustomFilter::initializeContext):
- platform/graphics/filters/FECustomFilter.h:
(WebCore):
(FECustomFilter):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build): Changed to initialize the global context if needed and pass it to the FECustomFilter.
- rendering/RenderView.cpp:
(WebCore):
(WebCore::RenderView::customFilterGlobalContext):
- rendering/RenderView.h:
(WebCore):
(RenderView):
- 2:43 PM Changeset in webkit [120756] by
-
- 2 edits in trunk/Tools
Missing results aren't shown in garden-o-matic
Reviewed by Kenneth Russell.
Previously we didn't know to look for text and image results when the
bot told us that results were missing.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
- 2:33 PM Changeset in webkit [120755] by
-
- 7 edits in trunk
[cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html
https://bugs.webkit.org/show_bug.cgi?id=53085
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-19
Reviewed by Martin Robinson.
Source/WebCore:
Clipping previously unlimited vertical and horizontal pattern repeats with
a clip rectangle similar to the Qt Graphics Context.
No new tests, this patch fixes
canvas/philip/tests/2d.pattern.paint.repeat* tests.
- platform/graphics/Pattern.h:
(WebCore::Pattern::getPatternSpaceTransform): Adding constant getter method to be able to map to pattern space externally, needed by PlatformContextCairo::clipForPatternFilling.
- platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::prepareForFilling):
(WebCore::PlatformContextCairo::clipForPatternFilling): Clip pattern repeats if needed.
- platform/graphics/cairo/PlatformContextCairo.h:
LayoutTests:
canvas/philip/tests/2d.pattern.paint.repeat* tests now passing.
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- 2:20 PM Changeset in webkit [120754] by
-
- 6 edits in trunk
[Shadow DOM] An upper boundary breaks if a child node of an insertion point is clicked.
https://bugs.webkit.org/show_bug.cgi?id=89407
Reviewed by Dimitri Glazkov.
Source/WebCore:
Update an event re-targeting algorithm so that it can set event's
target correctly when a fallback element in an insertion point is
clicked. To distinguish between distributed nodes and fallback
elements in an ancestor chain of composite shadow tree, an event
dispatcher checks explicitly whether a node is actually
distributed or assigned to the given insertion point.
Test: fast/dom/shadow/shadow-dom-event-dispatching.html
- dom/EventDispatcher.cpp:
(WebCore::isAssignedTo):
(WebCore):
(WebCore::EventDispatcher::ensureEventAncestors):
- html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::contains):
LayoutTests:
- fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
- fast/dom/shadow/shadow-dom-event-dispatching.html:
- 2:19 PM Changeset in webkit [120753] by
-
- 5 edits1 copy in trunk/Source/WebKit/chromium
IndexedDB: Add new type (and chromium webkit API) for metadata snapshot
https://bugs.webkit.org/show_bug.cgi?id=88678
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::metadata):
- public/WebIDBKeyPath.h:
(WebIDBKeyPath):
(WebKit::WebIDBKeyPath::WebIDBKeyPath):
(WebKit::WebIDBKeyPath::~WebIDBKeyPath):
(WebKit::WebIDBKeyPath::operator=): Used by Chromium backend.
- public/WebIDBMetadata.h: Added new type.
(WebKit):
(WebIDBMetadata):
(WebKit::WebIDBMetadata::WebIDBMetadata):
(ObjectStore):
(WebKit::WebIDBMetadata::ObjectStore::ObjectStore):
(Index):
(WebKit::WebIDBMetadata::Index::Index):
- src/WebIDBKeyPath.cpp: Conform to normal WebXXX patern.
(WebKit::WebIDBKeyPath::assign):
(WebKit):
(WebKit::WebIDBKeyPath::reset):
- 2:12 PM Changeset in webkit [120752] by
-
- 1 edit5 adds in trunk/LayoutTests
[Chromium] Add LayoutTests for find in page.
https://bugs.webkit.org/show_bug.cgi?id=89453
Patch by Martin Kosiba <mkosiba@google.com> on 2012-06-19
Reviewed by Adam Barth.
- platform/chromium/editing/text-iterator/findString-restarts-at-last-position-expected.txt: Added.
- platform/chromium/editing/text-iterator/findString-restarts-at-last-position.html: Added.
- platform/chromium/editing/text-iterator/findString-start-search-after-selection-expected.txt: Added.
- platform/chromium/editing/text-iterator/findString-start-search-after-selection.html: Added.
- 2:06 PM Changeset in webkit [120751] by
-
- 4 edits in trunk/Source/JavaScriptCore
CodeBlock::needsCallReturnIndices() is no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=89490
Patch by Mark Lam <mark.lam@apple.com> on 2012-06-19
Reviewed by Geoffrey Garen.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::needsCallReturnIndices): removed.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- 2:00 PM Changeset in webkit [120750] by
-
- 3 edits3 adds in trunk
Fix scrollbar layers being misplaced with a clipped owner layer
https://bugs.webkit.org/show_bug.cgi?id=89486
Reviewed by Simon Fraser.
Source/WebCore:
Scrollbar layers are positioned relative to their parent layer. If
that parent gets clipped, then that positioning becomes incorrect and
scrollbars get positioned relative to the clipped bounds instead of
the full bounds. Fix by not clipping in this case.
Test: compositing/overflow/scrollbars-with-clipped-owner.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds):
LayoutTests:
- compositing/overflow/scrollbars-with-clipped-owner-expected.png: Added.
- compositing/overflow/scrollbars-with-clipped-owner-expected.txt: Added.
- compositing/overflow/scrollbars-with-clipped-owner.html: Added.
- 1:13 PM Changeset in webkit [120749] by
-
- 5 edits2 adds in trunk
[Shadow][Editing] applying document.execCommand('bold') twice to elements having shadow insertion points causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=88502
Reviewed by Ryosuke Niwa.
Source/WebCore:
When inserting or removing insertion points (<shadow> or <content>) into or from Shdaow DOM,
ElementShadow::invalidateDistribution() will be called immediately. It will remove all the renderers
of elements in the Shadow DOM. Since Node::rendererIsEditable() returns false when an renderer does not
exist, all the elements in the Shadow DOM will be considered as non-content-editable until recalculating
layout, though some of them may actually be content-editable.
Actually the current code does not recalculate layout inside editing command, so a disaster happens.
For example, performing an editing command quits before completing all the commands, because the command
thinks it is adding some elements to a non-content-editable element (but actually it's content-editable).
So we have to recalculate layout if necessary when checking an element is content-editable or not.
This can be achieved by using Node::isContentEditable() instead of Node::rendererIsEditable().
Test: editing/shadow/bold-twice-in-shadow.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
- editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):
- editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doApply):
LayoutTests:
- editing/shadow/bold-twice-in-shadow-expected.txt: Added.
- editing/shadow/bold-twice-in-shadow.html: Added.
- 1:11 PM Changeset in webkit [120748] by
-
- 5 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r120744.
http://trac.webkit.org/changeset/120744
https://bugs.webkit.org/show_bug.cgi?id=89220
Broke build on Chromium Windows canary bots
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- platform/mock/DeviceMotionClientMock.cpp: Removed.
- platform/mock/DeviceMotionClientMock.h: Removed.
- 1:05 PM Changeset in webkit [120747] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, try to fix Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
- 12:48 PM Changeset in webkit [120746] by
-
- 3 edits74 deletes in trunk/LayoutTests
Remove some failing layout tests results added in
http://trac.webkit.org/changeset/119285 and
http://trac.webkit.org/changeset/119295. Most of these tests pass
without the failing results. Only one of them passes with the failing
result; compositing/layer-creation/spanOverlapsCanvas.html. I left that
failing result in place.
Rubber-stamped by Alexey Proskuryakov.
- platform/win/compositing/geometry/flipped-writing-mode-expected.txt: Removed.
- platform/win/compositing/geometry/foreground-layer-expected.txt: Removed.
- platform/win/compositing/geometry/foreground-offset-change-expected.txt: Removed.
- platform/win/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
- platform/win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Removed.
- platform/win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
- platform/win/compositing/geometry/layer-due-to-layer-children-expected.txt: Removed.
- platform/win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Removed.
- platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
- platform/win/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Removed.
- platform/win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Removed.
- platform/win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.
- platform/win/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Removed.
- platform/win/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Removed.
- platform/win/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Removed.
- platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Removed.
- platform/win/compositing/geometry/outline-change-expected.txt: Removed.
- platform/win/compositing/geometry/partial-layout-update-expected.txt: Removed.
- platform/win/compositing/geometry/preserve-3d-switching-expected.txt: Removed.
- platform/win/compositing/geometry/root-layer-update-expected.txt: Removed.
- platform/win/compositing/geometry/tall-page-composited-expected.txt: Removed.
- platform/win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Removed.
- platform/win/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
- platform/win/compositing/geometry/video-opacity-overlay-expected.txt: Removed.
- platform/win/compositing/iframes/become-composited-nested-iframes-expected.txt: Removed.
- platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
- platform/win/compositing/iframes/composited-iframe-alignment-expected.txt: Removed.
- platform/win/compositing/iframes/composited-iframe-scroll-expected.txt: Removed.
- platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
- platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
- platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Removed.
- platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Removed.
- platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
- platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Removed.
- platform/win/compositing/iframes/iframe-content-flipping-expected.txt: Removed.
- platform/win/compositing/iframes/iframe-copy-on-scroll-expected.txt: Removed.
- platform/win/compositing/iframes/iframe-in-composited-layer-expected.txt: Removed.
- platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
- platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
- platform/win/compositing/iframes/invisible-iframe-expected.txt: Removed.
- platform/win/compositing/iframes/invisible-nested-iframe-expected.txt: Removed.
- platform/win/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Removed.
- platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/win/compositing/iframes/layout-on-compositing-change-expected.txt: Removed.
- platform/win/compositing/iframes/nested-iframe-scrolling-expected.txt: Removed.
- platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
- platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/win/compositing/iframes/page-cache-layer-tree-expected.txt: Removed.
- platform/win/compositing/iframes/resizer-expected.txt: Removed.
- platform/win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
- platform/win/compositing/images: Removed.
- platform/win/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
- platform/win/compositing/images/direct-image-background-color-expected.txt: Removed.
- platform/win/compositing/images/direct-pdf-image-expected.txt: Removed.
- platform/win/compositing/images/direct-svg-image-expected.txt: Removed.
- platform/win/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Removed.
- platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
- platform/win/compositing/layer-creation/overlap-animation-expected.txt: Removed.
- platform/win/compositing/layer-creation/overlap-child-layer-expected.txt: Removed.
- platform/win/compositing/layer-creation/overlap-clipping-expected.txt: Removed.
- platform/win/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Removed.
- platform/win/compositing/layer-creation/overlap-transformed-layer-expected.txt: Removed.
- platform/win/compositing/layer-creation/overlap-transforms-expected.txt: Removed.
- platform/win/compositing/layer-creation/rotate3d-overlap-expected.txt: Removed.
- platform/win/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
- platform/win/compositing/layer-creation/stacking-context-overlap-expected.txt: Removed.
- platform/win/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Removed.
- platform/win/compositing/layer-creation/translatez-overlap-expected.txt: Removed.
- platform/win/compositing/masks: Removed.
- platform/win/compositing/masks/direct-image-mask-expected.txt: Removed.
- platform/win/compositing/masks/masked-ancestor-expected.txt: Removed.
- platform/win/compositing/masks/multiple-masks-expected.txt: Removed.
- platform/win/compositing/masks/simple-composited-mask-expected.txt: Removed.
- platform/win/compositing/overflow/ancestor-overflow-expected.txt: Removed.
- platform/win/compositing/overflow/clip-descendents-expected.txt: Removed.
- platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Removed.
- platform/win/compositing/overflow/content-loses-scrollbars-expected.txt: Removed.
- platform/win/compositing/overflow/overflow-compositing-descendant-expected.txt: Removed.
- platform/win/compositing/overflow/overflow-positioning-expected.txt: Removed.
- platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Removed.
- platform/win/compositing/overflow/resize-painting-expected.txt: Removed.
- platform/win/compositing/rtl: Removed.
- platform/win/compositing/rtl/rtl-absolute-expected.txt: Removed.
- platform/win/compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
- platform/win/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
- platform/win/compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
- platform/win/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed.
- platform/win/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
- platform/win/compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
- platform/win/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed.
- platform/win/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed.
- platform/win/compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
- platform/win/compositing/rtl/rtl-relative-expected.txt: Removed.
- platform/win/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Removed.
- platform/win/compositing/visibility: Removed.
- platform/win/compositing/visibility/layer-visible-content-expected.txt: Removed.
- platform/win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Removed.
- 12:42 PM Changeset in webkit [120745] by
-
- 16 edits22 adds in trunk/Source
It should be possible to look at disassembly
https://bugs.webkit.org/show_bug.cgi?id=89319
Source/JavaScriptCore:
Reviewed by Sam Weinig.
This imports the udis86 disassembler library. The library is placed
behind an abstraction in disassembler/Disassembler.h, so that we can
in the future use other disassemblers (for other platforms) whenever
appropriate. As a first step, the disassembler is being invoked for
DFG verbose dumps.
If we ever want to merge a new version of udis86 in the future, I've
made notes about changes I made to the library in
disassembler/udis86/differences.txt.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- disassembler: Added.
- disassembler/Disassembler.h: Added.
(JSC):
(JSC::tryToDisassemble):
- disassembler/UDis86Disassembler.cpp: Added.
(JSC):
(JSC::tryToDisassemble):
- disassembler/udis86: Added.
- disassembler/udis86/differences.txt: Added.
- disassembler/udis86/itab.py: Added.
(UdItabGenerator):
(UdItabGenerator.init):
(UdItabGenerator.toGroupId):
(UdItabGenerator.genLookupTable):
(UdItabGenerator.genLookupTableList):
(UdItabGenerator.genInsnTable):
(genItabH):
(genItabH.UD_ITAB_H):
(genItabC):
(genItab):
(main):
- disassembler/udis86/optable.xml: Added.
- disassembler/udis86/ud_opcode.py: Added.
(UdOpcodeTables):
(UdOpcodeTables.sizeOfTable):
(UdOpcodeTables.nameOfTable):
(UdOpcodeTables.updateTable):
(UdOpcodeTables.Insn):
(UdOpcodeTables.Insn.init):
(UdOpcodeTables.Insn.init.opcode):
(UdOpcodeTables.parse):
(UdOpcodeTables.addInsnDef):
(UdOpcodeTables.print_table):
(UdOpcodeTables.print_tree):
- disassembler/udis86/ud_optable.py: Added.
(UdOptableXmlParser):
(UdOptableXmlParser.parseDef):
(UdOptableXmlParser.parse):
(printFn):
(parse):
(main):
- disassembler/udis86/udis86.c: Added.
(ud_init):
(ud_disassemble):
(ud_set_mode):
(ud_set_vendor):
(ud_set_pc):
(ud):
(ud_insn_asm):
(ud_insn_off):
(ud_insn_hex):
(ud_insn_ptr):
(ud_insn_len):
- disassembler/udis86/udis86.h: Added.
- disassembler/udis86/udis86_decode.c: Added.
(eff_adr_mode):
(ud_lookup_mnemonic):
(decode_prefixes):
(modrm):
(resolve_operand_size):
(resolve_mnemonic):
(decode_a):
(decode_gpr):
(resolve_gpr64):
(resolve_gpr32):
(resolve_reg):
(decode_imm):
(decode_modrm_reg):
(decode_modrm_rm):
(decode_o):
(decode_operand):
(decode_operands):
(clear_insn):
(resolve_mode):
(gen_hex):
(decode_insn):
(decode_3dnow):
(decode_ssepfx):
(decode_ext):
(decode_opcode):
(ud_decode):
- disassembler/udis86/udis86_decode.h: Added.
(ud_itab_entry_operand):
(ud_itab_entry):
(ud_lookup_table_list_entry):
(sse_pfx_idx):
(mode_idx):
(modrm_mod_idx):
(vendor_idx):
(is_group_ptr):
(group_idx):
- disassembler/udis86/udis86_extern.h: Added.
- disassembler/udis86/udis86_input.c: Added.
(inp_buff_hook):
(inp_file_hook):
(ud):
(ud_set_user_opaque_data):
(ud_get_user_opaque_data):
(ud_set_input_buffer):
(ud_set_input_file):
(ud_input_skip):
(ud_input_end):
(ud_inp_next):
(ud_inp_back):
(ud_inp_peek):
(ud_inp_move):
(ud_inp_uint8):
(ud_inp_uint16):
(ud_inp_uint32):
(ud_inp_uint64):
- disassembler/udis86/udis86_input.h: Added.
- disassembler/udis86/udis86_itab_holder.c: Added.
- disassembler/udis86/udis86_syn-att.c: Added.
(opr_cast):
(gen_operand):
(ud_translate_att):
- disassembler/udis86/udis86_syn-intel.c: Added.
(opr_cast):
(gen_operand):
(ud_translate_intel):
- disassembler/udis86/udis86_syn.c: Added.
- disassembler/udis86/udis86_syn.h: Added.
(mkasm):
- disassembler/udis86/udis86_types.h: Added.
(ud_operand):
(ud):
- jit/JITCode.h:
(JITCode):
(JSC::JITCode::tryToDisassemble):
Source/WebCore:
Reviewed by Sam Weinig.
Just fixing EFL's build system now that JSC has a new directory.
- CMakeLists.txt:
Source/WTF:
Reviewed by Sam Weinig.
Made changes to Assertions.h to make it friendly to C code again.
Added ENABLE(DISASSEMBLER) and USE(UDIS86) logic to Platform.h.
- wtf/Assertions.h:
- wtf/Platform.h:
- 12:27 PM Changeset in webkit [120744] by
-
- 5 edits2 adds in trunk/Source/WebCore
Adds DeviceMotionClientMock
https://bugs.webkit.org/show_bug.cgi?id=89220
Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-19
Reviewed by Steve Block.
Adds DeviceMotionClientMock in WebCore to enable testing of DeviceMotion once it is fully implemented in WebKit.
This addition was originally included in https://bugs.webkit.org/show_bug.cgi?id=89197 but was split into a separate patch for easier review.
No new tests because DeviceMotionClientMock is designed to enable future testing and cannot be tested in itself.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- platform/mock/DeviceMotionClientMock.cpp: Added.
(WebCore):
(WebCore::DeviceMotionClientMock::DeviceMotionClientMock):
(WebCore::DeviceMotionClientMock::setController):
(WebCore::DeviceMotionClientMock::startUpdating):
(WebCore::DeviceMotionClientMock::stopUpdating):
(WebCore::DeviceMotionClientMock::setMotion):
(WebCore::DeviceMotionClientMock::timerFired):
- platform/mock/DeviceMotionClientMock.h: Added.
(WebCore):
(DeviceMotionClientMock):
- 12:22 PM Changeset in webkit [120743] by
-
- 2 edits in trunk/Tools
Fix regression introduced in r120646 where the svn revision isn't saved in results.json
Unreviewed, build fix.
It turns out that we store the svn revision two different ways
in the JSON, and I only caught one of them :(. This should fix
the other.
Also, this part of the code is poorly tested. I will investigate
adding at least a basic test for this in a separate fix.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):
- 12:17 PM Changeset in webkit [120742] by
-
- 14 edits2 adds in trunk/Source/JavaScriptCore
GCActivityCallback and IncrementalSweeper should share code
https://bugs.webkit.org/show_bug.cgi?id=89400
Reviewed by Geoffrey Garen.
A lot of functionality is duplicated between GCActivityCallback and IncrementalSweeper.
We should extract the common functionality out into a separate class that both of them
can inherit from. This refactoring will be an even greater boon when we add the ability
to shut these two agents down in a thread-safe fashion
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- heap/Heap.cpp:
(JSC::Heap::Heap): Move initialization down so that the JSGlobalData has a valid Heap when
we're initializing the GCActivityCallback and the IncrementalSweeper.
- heap/Heap.h:
(Heap):
- heap/HeapTimer.cpp: Added.
(JSC):
(JSC::HeapTimer::HeapTimer): Initialize the various base class data that
DefaultGCActivityCallback::commonConstructor() used to do.
(JSC::HeapTimer::~HeapTimer): Call to invalidate().
(JSC::HeapTimer::synchronize): Same functionality as the old DefaultGCActivityCallback::synchronize().
Virtual so that non-CF subclasses can override.
(JSC::HeapTimer::invalidate): Tears down the runloop timer to prevent any future firing.
(JSC::HeapTimer::timerDidFire): Callback to pass to the timer function. Casts and calls the virtual doWork().
- heap/HeapTimer.h: Added. This is the class that serves as the common base class for
both GCActivityCallback and IncrementalSweeper. It handles setting up and tearing down run loops and synchronizing
across threads for its subclasses.
(JSC):
(HeapTimer):
- heap/IncrementalSweeper.cpp: Changes to accomodate the extraction of common functionality
between IncrementalSweeper and GCActivityCallback into a common ancestor.
(JSC):
(JSC::IncrementalSweeper::doWork):
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::cancelTimer):
(JSC::IncrementalSweeper::create):
- heap/IncrementalSweeper.h:
(IncrementalSweeper):
- runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
- runtime/GCActivityCallback.h:
(GCActivityCallback):
(JSC::GCActivityCallback::willCollect):
(JSC::GCActivityCallback::GCActivityCallback):
(JSC):
(DefaultGCActivityCallback): Remove the platform data struct. The platform data should be kept in
the class itself so as to be accessible by doWork(). Most of the platform data for CF is kept in
HeapTimer anyways, so we only need the m_delay field now.
- runtime/GCActivityCallbackBlackBerry.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::didAllocate):
- runtime/GCActivityCallbackCF.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::cancel):
- 12:09 PM Changeset in webkit [120741] by
-
- 2 edits in trunk/Source/WebCore
Fix link error with fillWithEmptyClients
https://bugs.webkit.org/show_bug.cgi?id=89484
Patch by Alexandre Elias <aelias@google.com> on 2012-06-19
Reviewed by Ryosuke Niwa.
fillWithEmptyClients() was within #if ENABLE() guard in the .cpp file
but not in the header. There is now a caller unrelated to these ENABLEs
in WebHelperPluginImpl, so linking fails if both SVG and PAGE_POPUP
are disabled.
This function looks generic, so just remove the ENABLE guards.
No new tests. (Build fix.)
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
- 11:27 AM Changeset in webkit [120740] by
-
- 5 edits in trunk/Tools
REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
https://bugs.webkit.org/show_bug.cgi?id=78127
Reviewed by Ryosuke Niwa.
Add the --add-platform-exceptions flag from ORWT, and ensure
that --new-baseline is equivalent to --reset-results
--add-platform-exceptions. Also fix the default logic for where to
put PNGs and render tree dumps if --new-test-results is true:
if --add-platform-exceptions is False, baselines should go in
the least-specific platform directory (e.g., platform/mac)
rather than the most-specific (platform/mac-snowleopard).
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner):
(SingleTestRunner.run):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._add_missing_baselines):
(SingleTestRunner._location_for_new_baseline):
(SingleTestRunner._overwrite_baselines):
(SingleTestRunner._save_baseline_data):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.baseline_path):
(Port):
(Port.baseline_platform_dir):
(Port.baseline_version_dir):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RebaselineTest.assertBaselines):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):
- 11:25 AM Changeset in webkit [120739] by
-
- 8 edits in trunk/LayoutTests
Rebaseline some media controller tests.
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-strict-expected.txt:
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/media/video-display-toggle-expected.txt:
- platform/mac/media/video-no-audio-expected.txt:
- platform/mac/media/video-playing-and-pause-expected.txt:
- 11:21 AM Changeset in webkit [120738] by
-
- 9 edits in trunk/Tools
NRWT should not take memory used as disk cache into account when deciding how many processes to launch
https://bugs.webkit.org/show_bug.cgi?id=81379
Reviewed by Eric Seidel.
The 'free memory' calculation we were running on the mac seemed
to underestimate how many children we can run in parallel, and
it was complex. This patch replaces that calculation with a
simpler one that reserves 2GB for overhead and assumes 256MB per
DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
Also, there was a bug where we were truncating the memory
installed on the machine to 4GB by casting to an int instead of
a long; this was probably the source of some of the earlier
problems when using total memory.
This patch also removes the no-longer-needed restrictions on the
number of workers on beefy Lion boxes for both Apple Mac and Chromium
Mac; we should now use all of the cores by default.
The memory calculations have only been implemented on the mac;
having the calculation in base.default_child_processes() was IMO
misleading, and so this patch also moves the computation into
the MacPort. I have not heard of the # of workers being an issue
on any other ports, so this should be fine.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.total_bytes_memory):
- Scripts/webkitpy/common/system/platforminfo_mock.py:
(PlatformInfo.total_bytes_memory):
(PlatformInfo.total_bytes_memory):
(PlatformInfo._win_version_tuple_from_cmd):
- Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_total_bytes_memory):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_child_processes):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_default_child_processes):
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.operating_system):
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.default_child_processes):
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(TestMacPort.test_default_child_processes):
- 11:05 AM Changeset in webkit [120737] by
-
- 3 edits2 adds in trunk
Crash in RenderInline::willBeDestroyed.
https://bugs.webkit.org/show_bug.cgi?id=89386
Reviewed by Julien Chaffraix.
Source/WebCore:
We were unable to find the previous continuation during the process
of cleaning up empty anonymous block continuation. The reason being
that we were just looking till our immediate parent and ignoring the
fact that it can be enclosed in anonymous blocks. The change skips
over anonymous blocks in the parent chain.
Test: fullscreen/empty-anonymous-block-continuation-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
LayoutTests:
- fullscreen/empty-anonymous-block-continuation-crash-expected.txt: Added.
- fullscreen/empty-anonymous-block-continuation-crash.html: Added.
- 11:03 AM Changeset in webkit [120736] by
-
- 5 edits in trunk
new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
https://bugs.webkit.org/show_bug.cgi?id=85446
Reviewed by Simon Fraser.
Tools:
Embed whether pixel testing was enabled into the results.json.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):
LayoutTests:
This change makes results.html aware of whether pixel tests were
enabled when the tests were run; if they weren't, we ignore
expected IMAGE tests that pass instead of reporting them as
'unexpected pass'.
- fast/harness/resources/results-test.js:
(mockResults):
- fast/harness/results.html:
- 10:59 AM Changeset in webkit [120735] by
-
- 26 edits in trunk
Remove the -webkit-match-nearest-mail-blockquote-color property.
<http://webkit.org/b/89480>
Reviewed by Antti Koivisto.
Source/WebCore:
This property does nothing except taking up a bit on StyleRareNonInheritedData.
It's apparently famous for being the longest property name we support.
This passes the torch to -webkit-border-bottom-right-radius.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests:
- fast/css/getComputedStyle/resources/property-names.js:
- fast/dom/CSSStyleDeclaration/access-longest-css-property-expected.txt:
- fast/dom/CSSStyleDeclaration/access-longest-css-property.html:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 10:57 AM Changeset in webkit [120734] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Animations continue to request frames after they have finished
https://bugs.webkit.org/show_bug.cgi?id=89483
Patch by Andrew Lo <anlo@rim.com> on 2012-06-19
Reviewed by Rob Buis.
Don't report that we have running animations if all the animations
are finished. This prevents unnecessary requesting of animation frames.
Internal PR165119
Internally Reviewed by Arvid Nilsson.
- platform/graphics/blackberry/LayerAnimation.cpp:
(WebCore::progress):
(WebCore::fetchIntervalEndpoints):
(WebCore::LayerAnimation::apply):
- platform/graphics/blackberry/LayerAnimation.h:
(WebCore::LayerAnimation::finished):
(WebCore::LayerAnimation::LayerAnimation):
(LayerAnimation):
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::updateAnimations):
- 10:55 AM Changeset in webkit [120733] by
-
- 2 edits in branches/safari-536-branch/LayoutTests
Merged r120642
- 10:55 AM Changeset in webkit [120732] by
-
- 2 edits in trunk/Source/WebCore
Wrong repaintContainerSkipped in RenderObject::container()
when positioned objects are enclosed in a <foreignObject>.
https://bugs.webkit.org/show_bug.cgi?id=89384
Reviewed by Simon Fraser.
No new tests. The bug was found in a code audit.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::container):
- 10:43 AM Changeset in webkit [120731] by
-
- 3 edits2 adds in trunk
Crash in WebCore::RenderSVGModelObject::checkIntersection
https://bugs.webkit.org/show_bug.cgi?id=89059
Reviewed by Rob Buis.
Source/WebCore:
getElementCTM updates layout causing the renderer to be destroyed. We get
the new renderer by storing the element pointer and later accessing it using
the element pointer.
Test: svg/custom/intersection-list-crash.svg
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::checkIntersection):
(WebCore::RenderSVGModelObject::checkEnclosure):
LayoutTests:
- svg/custom/intersection-list-crash-expected.txt: Added.
- svg/custom/intersection-list-crash.svg: Added.
- 10:38 AM Changeset in webkit [120730] by
-
- 1 add in branches/chromium/1180/codereview.settings
adding for easy drover
- 10:37 AM Changeset in webkit [120729] by
-
- 1 copy in branches/chromium/1180
creating branch for m21
- 10:25 AM Changeset in webkit [120728] by
-
- 3 edits in trunk/Source/WebCore
FileWriter progress events should be throttled to 50ms
https://bugs.webkit.org/show_bug.cgi?id=89022
Reviewed by Kent Tamura.
No new tests; existing tests validate our event sequences, and testing
timing is likely to be flaky.
- Modules/filesystem/FileWriter.cpp:
(WebCore):
(WebCore::FileWriter::FileWriter):
(WebCore::FileWriter::didWrite): Throttle sending progress events.
- Modules/filesystem/FileWriter.h:
(FileWriter): Add a variable that remembers when the last event was
sent.
- 10:10 AM Changeset in webkit [120727] by
-
- 21 edits in trunk
Source/WebCore: WebCore part of: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394
Reviewed by Darin Adler.
Updated fast/multicol/pagination-*.html.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForDocument): Changed to handle the new Pagination::Mode enum
values and set the column progression in addition to the column axis.
- page/Page.h: Changed the Pagination::Mode enum values to ones that specify an axis and a
direction along that axis.
- testing/Internals.cpp:
(WebCore::Internals::setPagination): Changed to support the new Pagination::Mode enum values.
Source/WebKit/mac: WebKit/mac part of: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394
Reviewed by Darin Adler.
- WebView/WebView.mm:
(-[WebView _setPaginationMode:]): Changed to map new WebPaginationMode values to new
Pagination::Mode values.
(-[WebView _paginationMode]): Similarly, in the opposite direction.
- WebView/WebViewPrivate.h: Replaced WebPaginationMode values with ones that specify an
axis and a direction along that axis.
Source/WebKit2: WebKit2 part of: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394
Reviewed by Darin Adler.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPaginationMode): Changed to map new WKPaginationMode values to new
Pagination::Mode values.
(WKPageGetPaginationMode): Similarly, in the opposite direction.
- UIProcess/API/C/WKPagePrivate.h: Replaced WKPaginationMode values with ones that specify
an axis and a direction along that axis.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController setPaginationMode:]): Changed to handle new values.
(-[WKBrowsingContextController paginationMode]): Ditto.
- UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Replaced
WKBrowsingContextPaginationMode values with ones that specify an axis and a direction along
that axis.
LayoutTests: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394
Reviewed by Darin Adler.
- fast/multicol/pagination-h-horizontal-bt.html:
- fast/multicol/pagination-h-horizontal-tb.html:
- fast/multicol/pagination-h-vertical-lr.html:
- fast/multicol/pagination-h-vertical-rl.html:
- fast/multicol/pagination-v-horizontal-bt.html:
- fast/multicol/pagination-v-horizontal-tb.html:
- fast/multicol/pagination-v-vertical-lr.html:
- fast/multicol/pagination-v-vertical-rl.html:
- 10:09 AM Changeset in webkit [120726] by
-
- 2 edits in trunk/Source/WebKit/mac
[Mac] -[WebPDFView _menuItemsFromPDFKitForEvent:] leaks NSMenuItems
https://bugs.webkit.org/show_bug.cgi?id=89434
Reviewed by Darin Adler.
- WebView/WebPDFView.mm:
(-[WebPDFView _menuItemsFromPDFKitForEvent:]): Release copied
NSMenuItems once they're stored in copiedItems.
- 9:37 AM Changeset in webkit [120725] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Skip new failing and crashing tests to try to paint the bot green.
- platform/qt-mac/Skipped:
- 9:37 AM Changeset in webkit [120724] by
-
- 1 edit2 copies in branches/chromium/1132
Merge 118297 - REGRESSION (115573): Incorrect rounding of margins for floats
https://bugs.webkit.org/show_bug.cgi?id=87319
Reviewed by Eric Seidel.
Source/WebCore:
In RenderBlock::computeInlinePreferredLogicalWidths we used a float to
accumulate margins for floating children while the children themselves
represent their margins as LayoutUnits. Due to lack of rounding this can
cause the block to be too small at certain certain zoom levels, causing
unwanted wrapping.
This patch changes computeInlinePreferredLogicalWidths to use a
LayoutUnit to accumulate the margins and thus ensures that the margin
values are rounded the same way.
Test: fast/block/float/floats-with-margin-should-not-wrap.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
LayoutTests:
Add new test ensuring that using margins with floats doesn't cause
undesired wrapping.
- fast/block/float/floats-with-margin-should-not-wrap-expected.html: Added.
- fast/block/float/floats-with-margin-should-not-wrap.html: Added.
- 9:21 AM Changeset in webkit [120723] by
-
- 1 edit27 deletes in trunk/LayoutTests
[Qt] Unreviewed gardening, remove unnecessary expected files.
- platform/qt/animations/combo-transform-translate+scale-expected.txt: Removed.
- platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
- platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Removed.
- platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
- platform/qt/editing/inserting/return-key-in-hidden-field-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-noscript-expected.txt: Removed.
- platform/qt/editing/pasteboard/select-element-1-expected.txt: Removed.
- platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.txt: Removed.
- platform/qt/fast/css/border-solid-single-edge-antialias-expected.txt: Removed.
- platform/qt/fast/dom/Window/window-resize-contents-expected.txt: Removed.
- platform/qt/fast/events/mouse-relative-position-expected.txt: Removed.
- platform/qt/fast/preloader/document-write-noscript-expected.txt: Removed.
- platform/qt/fast/repaint/table-hover-on-link-expected.txt: Removed.
- platform/qt/http/tests/misc/SVGFont-delayed-load-expected.txt: Removed.
- platform/qt/http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt: Removed.
- platform/qt/svg/custom/acid3-test-77-expected.txt: Removed.
- platform/qt/svg/custom/circular-marker-reference-1-expected.txt: Removed.
- platform/qt/svg/custom/glyph-setting-d-attribute-expected.txt: Removed.
- platform/qt/svg/custom/insertItemBefore-from-non-list-origin-expected.txt: Removed.
- platform/qt/svg/custom/use-transfer-width-height-properties-to-svg-expected.txt: Removed.
- platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt: Removed.
- platform/qt/svg/dom/baseVal-animVal-crash-expected.txt: Removed.
- platform/qt/svg/dom/css-transforms-expected.txt: Removed.
- platform/qt/svg/dom/font-face-elements-expected.txt: Removed.
- platform/qt/svg/hixie/links/001-expected.txt: Removed.
- platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- 9:15 AM Changeset in webkit [120722] by
-
- 1 edit2 deletes in trunk/LayoutTests
[Qt] Unreviewed gardening, remove unnecessary expected files.
- platform/qt-5.0/fast/dom/DeviceMotion/create-event-expected.txt: Removed.
- platform/qt-5.0/fast/dom/DeviceOrientation/create-event-expected.txt: Removed.
- 9:12 AM WebKitGTK/1.8.x edited by
- (diff)
- 9:07 AM Changeset in webkit [120721] by
-
- 3 edits in trunk/Source/WebCore
Make RenderTableSection - nodeAtPoint and paintObject reuse spanning logic.
https://bugs.webkit.org/show_bug.cgi?id=88066
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-19
Reviewed by Julien Chaffraix.
Makes dirtiedRows and dirtiedColumns reuse spannedRows and spannedColumns
internally. This also changes their API to accept a damage-rect flipped
by logicalRectForWritingModeAndDirection.
The generic code in spannedRows and spannedColumns solves a few FIXMEs
surrounding RTL tables, which should improve performance.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::dirtiedRows):
(WebCore::RenderTableSection::dirtiedColumns):
(WebCore::RenderTableSection::paintObject):
- rendering/RenderTableSection.h:
(WebCore::CellSpan::start):
(WebCore::CellSpan::end):
(CellSpan):
(RenderTableSection):
- 8:59 AM Changeset in webkit [120720] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip one more failing test.
- platform/qt-5.0-wk2/Skipped:
- 8:47 AM Changeset in webkit [120719] by
-
- 3 edits in trunk/Source/WebCore
[JSC] Implement support for JSDictionary::convertValue(Vector<String>& result)
https://bugs.webkit.org/show_bug.cgi?id=89447
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-19
Reviewed by Adam Barth.
Add implementation for JSDictionary::convertValue(Vector<String>& result)
so that IDBDatabase::createObjectStore() compiles with JSC.
Tests: storage/indexeddb
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
(WebCore):
- bindings/js/JSDictionary.h:
- 8:45 AM Changeset in webkit [120718] by
-
- 2 edits in trunk/Source/WebCore
[Mac] AudioFileReader::createBus() leaks an AudioBufferList if ExtAudioFileRead() returns an error
https://bugs.webkit.org/show_bug.cgi?id=89429
Reviewed by Darin Adler.
- platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::createBus): Call destroyAudioBufferList()
before returning if ExtAudioFileRead() returns an error.
- 8:40 AM Changeset in webkit [120717] by
-
- 5 edits in trunk/LayoutTests
Fixing Typos in DeviceOrientation and DeviceMotion Tests
https://bugs.webkit.org/show_bug.cgi?id=89339
Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-19
Reviewed by Steve Block.
- fast/dom/DeviceMotion/create-event-expected.txt:
- fast/dom/DeviceMotion/script-tests/create-event.js:
- fast/dom/DeviceOrientation/no-synchronous-events-expected.txt:
- fast/dom/DeviceOrientation/script-tests/no-synchronous-events.js:
- 8:38 AM Changeset in webkit [120716] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Style Fix in WebDeviceOrientationController
https://bugs.webkit.org/show_bug.cgi?id=89337
Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-19
Reviewed by Steve Block.
Changing a local variable from a PassRefPtr to a RefPtr in order to be consistent with the style guide.
- src/WebDeviceOrientationController.cpp:
(WebKit::WebDeviceOrientationController::didChangeDeviceOrientation):
- 8:17 AM Changeset in webkit [120715] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip one more failing test.
- platform/qt-5.0-wk2/Skipped:
- 8:17 AM Changeset in webkit [120714] by
-
- 2 edits in trunk/Source/WebCore
Fix the GTK+ build by adding some missing source files to the source list.
- GNUmakefile.list.am: WebGLDepthTexture.cpp/h to the source list.
- 8:15 AM Changeset in webkit [120713] by
-
- 2 edits in trunk
[Qt] Fix the Windows build when Qt is built without -release or -debug
https://bugs.webkit.org/show_bug.cgi?id=89471
Reviewed by Tor Arne Vestbø.
Make sure that we at least remove build_all on Windows for api.pri,
as WebCore wasn't built for all configurations.
- Source/api.pri:
- 7:25 AM Changeset in webkit [120712] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed typo fix.
- platform/qt/Skipped:
- 7:15 AM Changeset in webkit [120711] by
-
- 13 edits in trunk/Source
Remove the function ScriptDebugServer::supportsNativeBreakpoints()
https://bugs.webkit.org/show_bug.cgi?id=88759
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-06-19
Reviewed by Pavel Feldman.
Source/WebCore:
Since both JSC and V8 support DOM breakpoint now, remove the conditional interface and related code.
So there is no new tests.
- bindings/js/ScriptDebugServer.h:
- bindings/v8/ScriptDebugServer.h:
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype._populateContextMenu):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshRequest):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype._clearInterface):
- inspector/front-end/Settings.js:
- inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):
Source/WebKit/chromium:
- src/js/DevTools.js:
- 7:06 AM Changeset in webkit [120710] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Make text in WebSocket Frames tab selectable
https://bugs.webkit.org/show_bug.cgi?id=89307
Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-06-19
Reviewed by Yury Semikhatsky.
- inspector/front-end/ResourceWebSocketFrameView.js:
(WebInspector.ResourceWebSocketFrameView):
- inspector/front-end/networkPanel.css:
(.resource-websocket-frame-view):
- 7:03 AM Changeset in webkit [120709] by
-
- 19 edits in trunk/Source/WebCore
Web Inspector: Support 'Restart frame' in protocol and backend
https://bugs.webkit.org/show_bug.cgi?id=89147
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-06-19
Reviewed by Yury Semikhatsky.
Inspector.json got new command in Debugger domain.
A call path from InspectorDebuggerAgent to V8 Debug.LiveEdit.RestartFrame API
is built.
JSC implementation is a stub with fix me (40300).
- bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::restart):
(WebCore):
- bindings/js/ScriptDebugServer.cpp:
(WebCore):
(WebCore::ScriptDebugServer::updateCallStack):
- bindings/js/ScriptDebugServer.h:
(ScriptDebugServer):
- bindings/v8/DebuggerScript.js:
(.):
- bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::restart):
(WebCore):
- bindings/v8/JavaScriptCallFrame.h:
(JavaScriptCallFrame):
- bindings/v8/ScriptDebugServer.cpp:
(WebCore):
(WebCore::ScriptDebugServer::updateCallStack):
- bindings/v8/ScriptDebugServer.h:
- bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
- bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::restartCallback):
(WebCore):
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::restartFrame):
(WebCore):
- inspector/InjectedScript.h:
(InjectedScript):
- inspector/InjectedScriptExterns.js:
(JavaScriptCallFrame.prototype.restart):
- inspector/InjectedScriptSource.js:
(.):
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::restartFrame):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/JavaScriptCallFrame.idl:
- 7:03 AM Changeset in webkit [120708] by
-
- 4 edits1 copy in trunk/LayoutTests
New inspector/styles/inject-stylesheet.html fails
https://bugs.webkit.org/show_bug.cgi?id=89364
Reviewed by Zoltan Herczeg.
LayoutTestController in Chromium injects testRunner into the Inspector window, while its other implementations don't.
Additionally, testRunner.addUserStyleSheet() behavior differs across platforms: Chromium injects stylesheets
with the "Author" level, while the others do with the "User" level, so the Chromium expectation stands apart.
- inspector/styles/inject-stylesheet-expected.txt:
- inspector/styles/inject-stylesheet.html:
- platform/chromium/inspector/styles/inject-stylesheet-expected.txt: Copied from LayoutTests/inspector/styles/inject-stylesheet-expected.txt.
- platform/qt/Skipped:
- 6:59 AM Changeset in webkit [120707] by
-
- 3 edits in trunk/Source/WebCore
Replaced printf with fprintf in DEBUG_AUDIONODE_REFERENCES
Change printf to fprintf in DEBUG_AUDIONODE_REFERENCES
https://bugs.webkit.org/show_bug.cgi?id=86564
Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-06-19
Reviewed by Csaba Osztrogonác.
There is no need for new tests: writing data to stderr, instead of stdout.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::~AudioContext):
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):
(WebCore::AudioNode::printNodeCounts):
- 5:59 AM Changeset in webkit [120706] by
-
- 5 edits in trunk
[GTK] Assert failure in svg/batik/text/textDecoration.svg,textEffect3.svg for 64bit Debug bot
https://bugs.webkit.org/show_bug.cgi?id=89104
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-19
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Adding SVGInline to assertion to fix assertion failure. Same assertion was hit on Chromium.
Covered by existing tests
svg/batik/text/textDecoration.svg
svg/batik/text/textEffect3.svg
where the assertion failure was hit.
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::shouldTransformOnTextPainting):
LayoutTests:
Removing CRASH expectations after assertion failure is now fixed.
- platform/chromium/TestExpectations:
- platform/gtk/TestExpectations:
- 4:43 AM Changeset in webkit [120705] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Create an extra atlas when there is no available buffer space.
https://bugs.webkit.org/show_bug.cgi?id=89012
Reviewed by Noam Rosenthal.
In case of the desktop mode when we scroll the view all the tiles
are updated. It can happen that there no available buffer space for
the currently used atlas(especially when scrolling fast). In that case
we can create a new one. One future improvement could be to make a timer and
delete this extra atlas when it is not used.
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::beginContentUpdateInAtlas):
(WebKit::LayerTreeHostQt::beginContentUpdate):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
- 4:34 AM Changeset in webkit [120704] by
-
- 14 edits in trunk/Source
[Qt] Buildfix for newer Qt5, use QPointer instead of the deprecated QWeakPointer.
https://bugs.webkit.org/show_bug.cgi?id=89449
Reviewed by Simon Hausmann.
Source/WebCore:
- bridge/qt/qt_instance.h:
(QtInstance):
- bridge/qt/qt_runtime.h:
(QtField):
- platform/Widget.h:
(Widget):
Source/WebKit/qt:
- Api/qwebframe_p.h:
(QWebHitTestResultPrivate):
- Api/qwebpage_p.h:
(QWebPagePrivate):
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createFrame):
- WebCoreSupport/PageClientQt.h:
(PageClientQGraphicsWidget):
Source/WebKit2:
- UIProcess/API/qt/qquicknetworkreply_p.h:
- 3:46 AM FeatureFlags edited by
- Add CSP_NEXT (diff)
- 3:44 AM Changeset in webkit [120703] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Document the versions enums where added
https://bugs.webkit.org/show_bug.cgi?id=89452
Patch by Albert Astals Cid <albert.astals@canonical.com> on 2012-06-19
Reviewed by Simon Hausmann.
- Api/qwebpage.cpp:
- 3:38 AM Changeset in webkit [120702] by
-
- 7 edits2 adds in trunk
Web Inspector: FileSystem tree should hide uninitialized FileSystem
https://bugs.webkit.org/show_bug.cgi?id=88602
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-19
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: http/tests/inspector/filesystem/get-filesystem-root.html
- inspector/Inspector.json:
- inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::getFileSystemRoot):
- inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._originAdded):
(WebInspector.FileSystemModel.prototype.refreshFileSystemList):
(WebInspector.FileSystemModel.prototype._gotFileSystem):
(WebInspector.FileSystemModel.FileSystem):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototype.getFileSystemRoot):
(WebInspector.FileSystemRequestManager.prototype._gotFileSystemRoot):
(WebInspector.FileSystemDispatcher.prototype.gotFileSystemRoot):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):
LayoutTests:
- http/tests/inspector/filesystem/get-filesystem-root-expected.txt: Added.
- http/tests/inspector/filesystem/get-filesystem-root.html: Added.
- 3:27 AM Changeset in webkit [120701] by
-
- 6 edits in trunk/Source/WebKit/chromium
[Chromium] Web Inspector: remove unnecessary indirection from message loop instrumentation
https://bugs.webkit.org/show_bug.cgi?id=89443
Removed start/stopMainThreadMonitoring methods from WebDevToolsAgentClient
and WebDevToolsAgentImpl. The functionality is now implemented inside
InspectorClientImpl.
Reviewed by Vsevolod Vlasov.
- public/WebDevToolsAgentClient.h:
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::clearBrowserCookies):
(WebKit::InspectorClientImpl::startMainThreadMonitoring):
(WebKit::InspectorClientImpl::stopMainThreadMonitoring):
(WebKit::InspectorClientImpl::willProcessTask):
(WebKit):
(WebKit::InspectorClientImpl::didProcessTask):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebDevToolsAgentImpl.cpp:
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
- 3:18 AM Changeset in webkit [120700] by
-
- 2 edits in trunk/Websites/webkit.org
Update webkit.org to refer to layoutTestController instead of testRunner
https://bugs.webkit.org/show_bug.cgi?id=89445
Reviewed by Kent Tamura.
- quality/testwriting.html:
- 2:33 AM Changeset in webkit [120699] by
-
- 2 edits in trunk/Tools
[Qt] Modify HTTPS port to 8443 for performance tests
https://bugs.webkit.org/show_bug.cgi?id=89442
Reviewed by Ryosuke Niwa.
We should be consistent with the default HTTPS port and with the changelog of r119188.
- Scripts/webkitpy/performance_tests/perftest.py:
(ReplayServer.init):
- 2:13 AM Changeset in webkit [120698] by
-
- 19 edits in trunk
Introduce ENABLE_CSP_NEXT configuration flag.
https://bugs.webkit.org/show_bug.cgi?id=89300
Patch by Mike West <mkwst@chromium.org> on 2012-06-19
Reviewed by Adam Barth.
The 1.0 draft of the Content Security Policy spec is just about to
move to Last Call. We'll hide work on the upcoming 1.1 spec behind
this ENABLE flag, disabled by default.
Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 2:12 AM Changeset in webkit [120697] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r120552): Many tests timing out on Windows
https://bugs.webkit.org/show_bug.cgi?id=89433
Reviewed by Andy Estes.
- wtf/CurrentTime.cpp:
(WTF::lowResUTCTime):
It looks like there were two bugs:
1) the function was converting from 100ths of nanoseconds to seconds
rather than 100s of nanoseconds to seconds by dividing by
(nsPerSecond * 100) rather than (nsPerSecond / 100)
2) the function should've been returning milliseconds, not seconds
- 2:10 AM Changeset in webkit [120696] by
-
- 5 edits in trunk/Source/WebCore
Make StylePropertySet::merge() always override on conflict
https://bugs.webkit.org/show_bug.cgi?id=89348
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-19
Reviewed by Ryosuke Niwa.
merge() was only used with argOverridesOnConflict = true, which
makes the extra parameter useless. It will also save a boolean check.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::mergeAndOverrideOnConflict):
- css/StylePropertySet.h:
(StylePropertySet):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::overrideWithStyle):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
- 1:57 AM Changeset in webkit [120695] by
-
- 9 edits in trunk/Source/WebCore
[Forms] Move isKeyboardFocusable and isMouseFocusable to InputType from HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=89425
Reviewed by Kent Tamura.
This patch moves implementation of HTMLInpueElement::isKeyboardFocusable
and isMouseFocusable to InputType class to allow each implementation
of InputType can decide focus-ability.
No new tests. This patch doesn't change behavior.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isKeyboardFocusable): Changed to call InputType::isKeyboardFocusable.
(WebCore::HTMLInputElement::isMouseFocusable): Changed to call InputType::isMouseFocusable.
(WebCore::HTMLInputElement::isTextFormControlFocusable): Added to allow InputType can call a method in HTMLTextFormControlElement.
(WebCore::HTMLInputElement::isTextFormControlKeyboardFocusable): Added to allow InputType can call a method in HTMLTextFormControlElement.
(WebCore::HTMLInputElement::isTextFormControlMouseFocusable): Added to allow InputType can call a method in HTMLTextFormControlElement.
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
(WebCore::InputType::isKeyboardFocusable): Changed to call isTextFormControlKeyboardFocusable.
(WebCore::InputType::isMouseFocusable): Added for default method of derived InputType classes.
- html/InputType.h:
(InputType): Chagned signature of isKeyboardFocusable.
- html/RadioInputType.cpp:
(WebCore::RadioInputType::isKeyboardFocusable): Changed to call isTextFormControlKeyboardFocusable which was done in HTMLInputElement.
- html/RadioInputType.h:
(RadioInputType):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::isKeyboardFocusable): Moved implementation from HTMLInputElement.
(WebCore::TextFieldInputType::isMouseFocusable): Moved implementation from HTMLInputElement.
- html/TextFieldInputType.h:
(TextFieldInputType):
- 1:55 AM Changeset in webkit [120694] by
-
- 19 edits in trunk/Source
Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()
https://bugs.webkit.org/show_bug.cgi?id=67582
Reviewed by David Levin.
Source/WebCore:
Added a new synchronous method to the IconDatabase that returns a
native image for the platform instead of a WebCore::Image*.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousNativeIconForPageURL):
(WebCore):
- loader/icon/IconDatabase.h:
(IconDatabase):
- loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
(IconDatabaseBase):
Source/WebKit/blackberry:
Use synchronousNativeIconForPageURL() to retrieve favicons.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
Source/WebKit/cf:
Fixes windows build.
- WebCoreSupport/WebInspectorClientCF.cpp:
Source/WebKit/efl:
Use synchronousNativeIconForPageURL() to retrieve favicons.
- ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
- ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):
Source/WebKit/gtk:
Use synchronousNativeIconForPageURL() to retrieve favicons.
- webkit/webkitfavicondatabase.cpp:
(getIconPixbufSynchronously):
Source/WebKit/qt:
Use synchronousNativeIconForPageURL() to retrieve favicons.
- Api/qwebhistory.cpp:
(QWebHistoryItem::icon):
- Api/qwebsettings.cpp:
(QWebSettings::iconForUrl):
- 1:45 AM Changeset in webkit [120693] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Use AutodrainedPool instead of NSAutoreleasePool in AudioBus::loadPlatformResource()
https://bugs.webkit.org/show_bug.cgi?id=89427
Reviewed by Dan Bernstein.
loadPlatformResource() called -[NSAutoreleasePool release] at each of
its exit points, which is not only an error-prone pattern but is
incorrect in garbage-collected environments. AutodrainedPool solves
both these problems by automatically calling -[NSAutoreleasePool drain]
when going out of scope.
- platform/audio/mac/AudioBusMac.mm:
(WebCore::AudioBus::loadPlatformResource):
- 1:38 AM Changeset in webkit [120692] by
-
- 9 edits in trunk
[EFL] EFL's LayoutTestController does not support setTextDirection
https://bugs.webkit.org/show_bug.cgi?id=87481
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-19
Reviewed by Hajime Morita.
Source/WebKit/efl:
Add new Ewk_View method to set the text direction, by calling
Editor::setBaseWritingDirection() internally, as Mac and Chromium
ports do.
- WebCoreSupport/AssertMatchingEnums.cpp:
- ewk/ewk_view.cpp:
(ewk_view_text_direction_set):
- ewk/ewk_view.h:
Tools:
Implement setTextDirection in EFL's LayoutTestController and
properly reset its value between test cases to avoid flakiness.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setTextDirection):
LayoutTests:
Unskip related test case now that EFL's LayoutTestController
implements setTextDirection.
- platform/efl/Skipped:
- 1:36 AM Changeset in webkit [120691] by
-
- 2 edits in trunk/Source/WebCore
Compilation failure in StyleResolver.cpp
https://bugs.webkit.org/show_bug.cgi?id=89446
Patch by Mike West <mkwst@chromium.org> on 2012-06-19
Reviewed by Ryosuke Niwa.
Adding 'CSSPropertyWebkitColumnProgression' to a switch statement from
which it was missing.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- 1:23 AM Changeset in webkit [120690] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Unreviewed build system fix after r120051.
- Target.pri:
- 1:18 AM Writing DumpAsMarkup Tests edited by
- s/layoutTestController/testRunner/ (diff)
- 1:17 AM Writing Layout Tests for DumpRenderTree edited by
- s/layoutTestController/testRunner/ (diff)
- 1:16 AM Creating and Submitting Layout Tests and Patches edited by
- s/layoutTestController/testRunner/ (diff)
- 1:15 AM Changeset in webkit [120689] by
-
- 3 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r120586.
http://trac.webkit.org/changeset/120586
https://bugs.webkit.org/show_bug.cgi?id=89444
doesn't fix mac issue (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-19
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::replaceMisspelledRange):
- 12:40 AM Changeset in webkit [120688] by
-
- 2 edits in trunk/Tools
[Qt] Temporarily disable xvfb driver in nrwt
https://bugs.webkit.org/show_bug.cgi?id=88414
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._build_driver):
- 12:35 AM Changeset in webkit [120687] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectation update.
- platform/chromium/TestExpectations:
- 12:35 AM Changeset in webkit [120686] by
-
- 2 edits in trunk
[Qt] Allow the modules file generation to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=89010
Patch by Joel Dillon <joel.dillon@codethink.co.uk>, Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-06-19
Reviewed by Csaba Osztrogonác.
Add calls to toSystemPath and use QMAKE_DIR_SEP where necessary.
- Source/api.pri:
- 12:32 AM Changeset in webkit [120685] by
-
- 2 edits in trunk
[Qt] Fix TARGET not properly being set for QtWebKitd5.dll when building in debug.
https://bugs.webkit.org/show_bug.cgi?id=88880
load(qt_module_config) adjusts the TARGET to add the "d" suffix when doing
the debug build_pass. When doing the first pass, qt_module_config.prf doesn't
adjust the target since it is in debug_and_release and expects the debug
build_pass to come later. However, since we remove debug_and_release from CONFIG
right after this, the TARGET hasn't been adjusted and the debug build_pass
will not happen.
Work around it by disabling this optimization on Windows.
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-06-19
Reviewed by Tor Arne Vestbø.
- Source/api.pri:
- 12:27 AM Changeset in webkit [120684] by
-
- 17 edits2 adds in trunk
Add a scheme registry for bypassing Content Security Policy.
https://bugs.webkit.org/show_bug.cgi?id=89373
Patch by Mike West <mkwst@chromium.org> on 2012-06-19
Reviewed by Adam Barth.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
The Content Security Policy specification notes that "Enforcing a CSP
policy should not interfere with the operation of user-supplied scripts
such as third-party user-agent add-ons and JavaScript bookmarklets."
(https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#processing-model)
This use case can be at least partially addressed by adding a scheme
registry for certain types of URLs whose resources should be loaded
regardless of a page's defined policy directives.
See http://crbug.com/133223 for additional context.
Test: http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html
- WebCore.exp.in:
Exporting new symbols for use by Internals.
- page/ContentSecurityPolicy.cpp:
(WebCore::isAllowedByAllWithURL):
Adding a check against the new SchemeRegistry method to determine
whether or not we should proceed with checking the URL against the
policy.
- platform/SchemeRegistry.cpp:
(WebCore::CSPBypassingSchemes):
(WebCore):
(WebCore::SchemeRegistry::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsBypassingContentSecurityPolicy):
(WebCore::SchemeRegistry::schemeShouldBypassContentSecurityPolicy):
- platform/SchemeRegistry.h:
(SchemeRegistry):
Adding the scheme registry for CSP-bypassing URL schemes.
- testing/Internals.cpp:
(WebCore):
(WebCore::Internals::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebCore::Internals::removeURLSchemeRegisteredAsBypassingContentSecurityPolicy):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Adding a method to Internals so that we can write a layout test.
Source/WebKit/chromium:
- public/WebSecurityPolicy.h:
(WebSecurityPolicy):
- src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebKit):
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- http/tests/security/contentSecurityPolicy/register-bypassing-scheme-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html: Added.
- 12:23 AM Changeset in webkit [120683] by
-
- 492 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in fast/canvas, clip, compact, constructors, cookies, and css* tests
https://bugs.webkit.org/show_bug.cgi?id=89431
Reviewed by Kent Tamura.
- fast/canvas/:
- fast/constructors/constructor-as-function-crash.html:
- fast/css-generated-content/absolute-position-inside-inline.html:
- fast/css-generated-content/after-with-first-letter-float-crash.html:
- fast/css-generated-content/attr-missing.html:
- fast/css-generated-content/before-content-with-list-marker-in-anon-block-crash.html:
- fast/css-generated-content/block-after.html:
- fast/css-generated-content/drag-state.html:
- fast/css-generated-content/empty-content-with-float-crash.html:
- fast/css-generated-content/first-letter-next-sibling-crash.html:
- fast/css-generated-content/first-letter-table-cell-format-block-crash.html:
- fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html:
- fast/css-generated-content/floating-before-content-with-list-marker-crash.html:
- fast/css-generated-content/hit-test-generated-content.html:
- fast/css-generated-content/hover-style-change.html:
- fast/css-generated-content/inline-splitting-with-after-float-crash.html:
- fast/css-generated-content/malformed-url.html:
- fast/css-generated-content/positioned-background-hit-test-crash.html:
- fast/css-generated-content/positioned-div-with-floating-after-content-crash.html:
- fast/css-generated-content/positioned-generated-content-under-run-in-crash.html:
- fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash.html:
- fast/css-generated-content/reset-content-to-initial.html:
- fast/css-generated-content/resources/pass.html:
- fast/css-generated-content/resources/positioned-div-with-floating-after-content-crash-frame2.html:
- fast/css-generated-content/spellingToolTip-assert.html:
- fast/css-generated-content/table-row-after-no-crash.html:
- fast/css-generated-content/table-with-scrollbar-corner.html:
- fast/css-generated-content/text-before-table-col-crash.html:
- fast/css-grid-layout/display-grid-set-get.html:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
- fast/css-grid-layout/grid-columns-rows-get-set.html:
- fast/css-grid-layout/grid-item-column-row-get-set.html:
- fast/css/:
- platform/mac/fast/canvas/canvas-draw-xbm-image.html:
- platform/qt/fast/canvas/toDataURL-jpeg-alpha.html:
- platform/qt/fast/canvas/toDataURL-jpeg-primarycolors.html:
- platform/qt/fast/canvas/toDataURL-jpeg-quality-basic.html:
- platform/qt/fast/canvas/toDataURL-jpeg-quality-notnumber.html:
- platform/qt/fast/canvas/toDataURL-jpeg-quality-outsiderange.html:
Jun 18, 2012:
- 11:52 PM Changeset in webkit [120682] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip failing tests.
- platform/qt-4.8/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt/Skipped:
- 11:35 PM Changeset in webkit [120681] by
-
- 87 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in fast/animation, autoresize, backgrounds, block, body-propagation, borders, and box-* tests
https://bugs.webkit.org/show_bug.cgi?id=89422
Reviewed by Kent Tamura.
- fast/animation/request-animation-frame-detach-element.html:
- fast/animation/request-animation-frame-detach-element2.html:
- fast/animation/request-animation-frame-disabled.html:
- fast/animation/request-animation-frame-during-modal.html:
- fast/animation/request-animation-frame-iframe.html:
- fast/animation/script-tests/request-animation-frame-cancel.js:
- fast/animation/script-tests/request-animation-frame-cancel2.js:
- fast/animation/script-tests/request-animation-frame-disabled.js:
- fast/animation/script-tests/request-animation-frame-timestamps-advance.js:
- fast/animation/script-tests/request-animation-frame-timestamps.js:
- fast/animation/script-tests/request-animation-frame-within-callback.js:
- fast/animation/script-tests/request-animation-frame.js:
- fast/autoresize/autoresize-with-iframe.html:
- fast/autoresize/basic.html:
- fast/autoresize/turn-off-autoresize.html:
- fast/backgrounds/animated-gif-as-background.html:
- fast/backgrounds/animated-svg-as-mask.html:
- fast/backgrounds/background-fast-path-simple-color.html:
- fast/backgrounds/background-fill-zero-area-crash.html:
- fast/backgrounds/background-repeat-computed-style.html:
- fast/backgrounds/multiple-backgrounds-assert.html:
- fast/backgrounds/root-background-propagation.html:
- fast/backgrounds/root-background-propagation2.html:
- fast/backgrounds/size/contain-and-cover-zoomed.html:
- fast/backgrounds/solid-color-context-restore.html:
- fast/block/:
- fast/borders/border-image-reset-by-border-shorthand.html:
- fast/borders/border-image-slice-omission.html:
- fast/borders/border-mixed-alpha.html:
- fast/borders/border-radius-complex-inner.html:
- fast/borders/border-radius-parsing.html:
- fast/borders/negative-border-width.html:
- fast/borders/outline-alpha-block.html:
- fast/borders/outline-alpha-inline.html:
- fast/box-shadow/box-shadow-clipped-slices.html:
- fast/box-shadow/box-shadow-currentcolor.html:
- fast/box-shadow/no-blur-multiple-offsets.html:
- fast/box-shadow/resources/box-shadow-overflow-scroll.js:
- fast/box-shadow/spread-multiple-inset.html:
- fast/box-shadow/spread-multiple-normal.html:
- 11:33 PM Changeset in webkit [120680] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow
https://bugs.webkit.org/show_bug.cgi?id=89424
Reviewed by Dan Bernstein.
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart): Store the NSShadow
in a RetainPtr so that it's released before going out of scope.
- 11:20 PM Changeset in webkit [120679] by
-
- 21 edits in trunk/Source/WebCore
Refactoring: Introduce a class to represent restoring state of a form control
https://bugs.webkit.org/show_bug.cgi?id=89412
Reviewed by Hajime Morita.
HTMLFormControlElementWithState::saveFormControlState had two return
values; One is a boolean to represent whether we should save the state
or not, and another is form control value. This patch introduces
FormControlState class representing these values.
We're going to extend FormControlState class so that it can contain
multiple strings to fix a FileInputType issue and it have another type
to fix Bug 89409.
No new tests. Just a refactoring.
- html/FormController.cpp:
(WebCore::FormController::formElementsState):
Gets a state string from a FormControlState instance.
(WebCore::FormController::takeStateForFormElement):
Creates a FormControlState instance with a state string.
- html/FormController.h:
(WebCore::FormControlState): Added.
- html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::saveFormControlState):
Use FormControlState class.
(WebCore::BaseCheckableInputType::restoreFormControlState): ditto.
- html/BaseCheckableInputType.h:
(BaseCheckableInputType): ditto.
- html/FileInputType.cpp:
(WebCore::FileInputType::saveFormControlState): ditto.
(WebCore::FileInputType::restoreFormControlState): ditto.
- html/FileInputType.h:
(FileInputType): ditto.
- html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::saveFormControlState): ditto.
(WebCore::HTMLFormControlElementWithState::finishParsingChildren): ditto.
- html/HTMLFormControlElementWithState.h:
(HTMLFormControlElementWithState): ditto.
(WebCore::HTMLFormControlElementWithState::restoreFormControlState): ditto.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::saveFormControlState): ditto.
(WebCore::HTMLInputElement::restoreFormControlState): ditto.
- html/HTMLInputElement.h:
(HTMLInputElement): ditto.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::saveFormControlState): ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): ditto.
- html/HTMLSelectElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::saveFormControlState): ditto.
(WebCore::HTMLTextAreaElement::restoreFormControlState): ditto.
- html/HTMLTextAreaElement.h:
- html/HiddenInputType.cpp:
(WebCore::HiddenInputType::saveFormControlState): ditto.
(WebCore::HiddenInputType::restoreFormControlState): ditto.
- html/HiddenInputType.h:
(HiddenInputType): ditto.
- html/InputType.cpp:
(WebCore::InputType::saveFormControlState): ditto.
(WebCore::InputType::restoreFormControlState): ditto.
- html/InputType.h:
(InputType): ditto.
- html/PasswordInputType.cpp:
(WebCore::PasswordInputType::saveFormControlState): ditto.
(WebCore::PasswordInputType::restoreFormControlState): ditto.
- html/PasswordInputType.h:
(PasswordInputType): ditto.
- 11:16 PM Changeset in webkit [120678] by
-
- 5 edits in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines after rollouts in r120627.
- platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
- platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
- platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
- platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:
- 11:09 PM Changeset in webkit [120677] by
-
- 4 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening, update expected files.
- platform/qt/Skipped: Skip a new failing test to paint the bot green.
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Updated after r120609.
- platform/qt/fast/multicol/progression-reverse-expected.png: Added after r120609.
- platform/qt/fast/multicol/progression-reverse-expected.txt: Added after r120609.
- platform/qt/svg/css/getComputedStyle-basic-expected.txt: Updated after r120609.
- 11:07 PM Changeset in webkit [120676] by
-
- 5 edits3 adds in trunk
Source/JavaScriptCore: Changed JSC to always record line number information so that error.stack
and window.onerror() can report proper line numbers.
https://bugs.webkit.org/show_bug.cgi?id=89410
Patch by Mark Lam <mark.lam@apple.com> on 2012-06-18
Reviewed by Geoffrey Garen.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit): m_lineInfo is now available unconditionally.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addLineInfo):
(JSC::CodeBlock::hasLineInfo): Unused. Now removed.
(JSC::CodeBlock::needsCallReturnIndices):
(CodeBlock):
(RareData): Hoisted m_lineInfo out of m_rareData. m_lineInfo is now
filled in unconditionally.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::addLineInfo):
LayoutTests: Ensure that error.stack and window.onerror always have the appropriate
line numbers of the exception being thrown.
https://bugs.webkit.org/show_bug.cgi?id=89410
Patch by Mark Lam <mark.lam@apple.com> on 2012-06-18
Reviewed by Geoffrey Garen.
- fast/js/exception-line-number-expected.txt: Added.
- fast/js/exception-line-number.html: Added.
- fast/js/script-tests/exception-line-number.js: Added.
(foo):
(window.onerror):
- 10:47 PM Changeset in webkit [120675] by
-
- 4 edits in trunk
[EFL] Fontconfig can't be linked properly
https://bugs.webkit.org/show_bug.cgi?id=89418
Unreviewed build fix.
Make Fontconfig be linked correctly.
Source/WebCore:
No new tests. This is only a build fix.
- PlatformEfl.cmake: add FONTCONFIG_LIBRARIES to WebCore_LIBRARIES.
Tools:
- MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
- 10:47 PM Changeset in webkit [120674] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fix (one more) for r120667: skip '.svn' directory from the test results.
- fast/forms/file/input-file-entries.html:
- 10:34 PM Changeset in webkit [120673] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] Fix memory leaks in GLContextGLX.cpp
https://bugs.webkit.org/show_bug.cgi?id=89346
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-18
Reviewed by Martin Robinson.
Fix memory leaks found in GLContextGLX.cpp.
- platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::cleanupActiveContextsAtExit): Removing element reduces
size of the vector, so the loop termination condition was failing in the last
iteration, when the vector contains more than one element. This patch fixes the
issue by iterating the vector backwards, so the termination condition doesn't
fail until the size() reaches 0.
(WebCore::GLContextGLX::createPbufferContext): Delete GLXPbuffer
returned by glXCreatePbuffer().
(WebCore::GLContextGLX::createPixmapContext): Delete XVisualInfo
returned by glXChooseVisual().
- 10:19 PM Changeset in webkit [120672] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed gardening. Add missing expectation file.
- fast/text/title-crash-expected.txt: Added.
- 10:09 PM Changeset in webkit [120671] by
-
- 2 edits in trunk/Tools
Unreviewed. Updating email for committers.py script.
- Scripts/webkitpy/common/config/committers.py:
- 10:08 PM Changeset in webkit [120670] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fix for r120667: skip '.svn' directory from the test results.
- fast/forms/file/input-file-entries.html:
- 9:56 PM Changeset in webkit [120669] by
-
- 2 edits in trunk/Tools
Fix a typo that caused TestFailures to have a syntax error.
Sadly TestFailures is broken for another reason now too:
https://bugs.webkit.org/show_bug.cgi?id=89419
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
(ViewController.prototype._domForBuildName):
- 9:34 PM Changeset in webkit [120668] by
-
- 16 edits2 copies3 adds in trunk
Source/WebCore: Expose WEBGL_depth_texture extension to WebGL
https://bugs.webkit.org/show_bug.cgi?id=87029
Patch by Gregg Tavares <gman@google.com> on 2012-06-18
Reviewed by Kenneth Russell.
Test: fast/canvas/webgl/webgl-depth-texture.html
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/WebGLDepthTexture.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebCore::WebGLDepthTexture::WebGLDepthTexture):
(WebCore::WebGLDepthTexture::~WebGLDepthTexture):
(WebCore::WebGLDepthTexture::getName):
(WebCore::WebGLDepthTexture::create):
(WebCore::WebGLDepthTexture::supported):
- html/canvas/WebGLDepthTexture.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebGLDepthTexture):
- html/canvas/WebGLDepthTexture.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::initializeAttachments):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::validateSettableTexFormat):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::generateMipmap):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
(WebCore::WebGLRenderingContext::validateTexFuncData):
- html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::getClearBitsByAttachmentType):
(WebCore):
(WebCore::GraphicsContext3D::getClearBitsByFormat):
- platform/graphics/GraphicsContext3D.h:
LayoutTests: Expose WEBGL_depth_texture extension to WebGL
https://bugs.webkit.org/show_bug.cgi?id=87029
Patch by Gregg Tavares <gman@google.com> on 2012-06-18
Reviewed by Kenneth Russell.
- fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils):
- fast/canvas/webgl/webgl-depth-texture-expected.txt: Added.
- fast/canvas/webgl/webgl-depth-texture.html: Added.
- 9:13 PM Changeset in webkit [120667] by
-
- 21 edits8 adds in trunk
Support File/DirectoryEntry access for <input type=file> if FileSystem API is enabled
https://bugs.webkit.org/show_bug.cgi?id=88293
Reviewed by Tony Chang.
Source/WebCore:
Proposal email on whatwg: http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033814.html
Proposal draft: http://wiki.whatwg.org/wiki/DragAndDropEntries
Test: fast/forms/file/input-file-entries.html
- Modules/filesystem/HTMLInputElementFileSystem.cpp: Added.
- Modules/filesystem/HTMLInputElementFileSystem.h: Added.
- Modules/filesystem/HTMLInputElementFileSystem.idl: Added.
- WebCore.gypi:
- html/FileInputType.cpp:
(WebCore::FileInputType::receiveDroppedFiles): Retrieves dropped file
system Id if the given DragData has it.
(WebCore::FileInputType::droppedFileSystemId): Added. This returns
dropped file system Id retrieved in receiveDroppedFiles, or an empty
string if the platform does not support isolated file system for
dropped files.
- html/FileInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::droppedFileSystemId): Added.
- html/HTMLInputElement.h:
- html/InputType.cpp:
(WebCore::InputType::droppedFileSystemId): Added.
- html/InputType.h:
- platform/DragData.cpp:
- platform/DragData.h:
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::droppedFileSystemId): Added.
LayoutTests:
- fast/forms/file/input-file-entries-expected.txt: Added.
- fast/forms/file/input-file-entries.html: Added.
- fast/forms/resources/dir1/UTF8-2.txt: Added.
- fast/forms/resources/dir1/UTF8.txt: Added.
- fast/forms/resources/dir2/green.jpg: Added.
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 9:02 PM Changeset in webkit [120666] by
-
- 4 edits2 adds in trunk
[Crash][Editing] VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries() crashes in some Shadow DOM case.
https://bugs.webkit.org/show_bug.cgi?id=88500
Reviewed by Ryosuke Niwa.
Source/WebCore:
When selecting from a child of shadow host to an element in Shadow DOM, the start position of
Selection comes after the end position of Selection in some cases. This caused a crash.
For example, let's think '<div id="host">A</div>D' and host has a Shadow DOM whose innerHTML
is 'B<content></content>C'. When selecting from just after A (p1 = (PositionIsOffsetInAnchor,
#text, 1)) to just before B (p2 = (PositionIsOffsetInAnchor, shadowRoot, 0)), since
comparePosition always judge as p2 is before p1, m_start and m_end in VisibleSelection
will be p2 and p1 respectively.
However, the anchorNodes of p1 and p2 have the different tree scope, we have to adjust p2 to
the same tree scope as p1. Since p2 is m_start, m_start was adjusted to positionAfterNode(div).
This breaks the assumption that m_start is always before (or equal to) m_end.
This patch keeps the assumption. When we cannot move m_start to positionAfterNode(div),
we move m_start to positionBeforeNode(div). Note that we cannot always move m_start to
positionBeforeNode(div), because when selecting just after D (p3 = (PositionIsOffsetInAnchor,
D's parent, 2), we don't want to select A.
In this case, m_start should be adjusted to positionAfterNode(div).
Test: editing/shadow/breaking-editing-boundaries.html
- editing/VisibleSelection.cpp:
(WebCore::adjustPositionForEnd):
(WebCore):
(WebCore::adjustPositionForStart):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
- editing/VisibleSelection.h:
(VisibleSelection):
LayoutTests:
- editing/shadow/breaking-editing-boundaries-expected.txt: Added.
- editing/shadow/breaking-editing-boundaries.html: Added.
- 8:54 PM Changeset in webkit [120665] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test marking. Marked border-radius-clip-002.htm as a failure.
- platform/chromium/TestExpectations:
- 8:34 PM Changeset in webkit [120664] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix r120663, which didn't land the change that was reviewed.
- 8:32 PM Changeset in webkit [120663] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] In JSGlobalData.cpp, enableAssembler() sometimes leaks two CF objects
https://bugs.webkit.org/show_bug.cgi?id=89415
Reviewed by Sam Weinig.
In the case where canUseJIT was a non-NULL CFBooleanRef,
enableAssembler() would leak both canUseJITKey and canUseJIT by
returning before calling CFRelease. Fix this by using RetainPtr.
- runtime/JSGlobalData.cpp:
(JSC::enableAssembler):
- 8:20 PM Changeset in webkit [120662] by
-
- 3 edits1 add in trunk
Crash when setting title dynamically
https://bugs.webkit.org/show_bug.cgi?id=88083
Reviewed by Dan Bernstein.
Source/WebCore:
Test: fast/text/title-crash.html
The crashing code takes a rare branch in StyleResolver::styleForElement() where
m_parentStyle is set to point to m_style. Consequently, while applying properties
to m_style we end up mutating m_parentStyle.
In this situation, we clone style() and point m_parentStyle at the clone. The
clone is destroyed at the end of StyleResolver::styleForElement().
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
LayoutTests:
- fast/text/title-crash.html: Added.
- 8:04 PM Changeset in webkit [120661] by
-
- 3 edits3 adds in trunk
RenderLayerBacking sometimes doesn't attach scrollbars to graphics layer tree
https://bugs.webkit.org/show_bug.cgi?id=89402
Reviewed by James Robinson.
Source/WebCore:
RenderLayerBacking only attaches scrollbar layers to the graphics
layer tree if there's a clip layer. This is wrong, because these
scrollbars become orphans and other code expects them to handle
repainting the scrollbars (which now become invisible). Fix by always
attaching scrollbar layers.
Test: compositing/overflow/image-load-overflow-scrollbars.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateInternalHierarchy):
LayoutTests:
Add a test where an image load creates overflow.
- compositing/overflow/image-load-overflow-scrollbars-expected.png: Added.
- compositing/overflow/image-load-overflow-scrollbars-expected.txt: Added.
- compositing/overflow/image-load-overflow-scrollbars.html: Added.
- 7:54 PM Changeset in webkit [120660] by
-
- 2 edits in trunk/LayoutTests
Make serve-video.php serve 206 responses
https://bugs.webkit.org/show_bug.cgi?id=89252
Reviewed by Adam Barth.
- http/tests/media/resources/serve-video.php:
- 7:51 PM Changeset in webkit [120659] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] GesturePinchBegin and friends are gesture events
https://bugs.webkit.org/show_bug.cgi?id=89398
Reviewed by James Robinson.
- public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):
- 7:25 PM Changeset in webkit [120658] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test marking. Marked border-radius-clip-002.htm as a failure.
- platform/chromium/TestExpectations:
- 7:06 PM Changeset in webkit [120657] by
-
- 4 edits in trunk/Tools
Provide bug links for suspicious commits
https://bugs.webkit.org/show_bug.cgi?id=89408
Reviewed by Adam Barth.
Add links to bugs for the suspicious commits if we have bug data.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
(ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
(ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
- 6:54 PM Changeset in webkit [120656] by
-
- 4 edits6 copies in branches/chromium/1132
Merge 120257 - Padding and borders can cause integer overflow in block layouts
< rdar://problem/11328762>
Reviewed by Tony Chang.
Source/WebCore:
Tests: fast/block/block-size-integer-overflow.html
fast/flexbox/box-size-integer-overflow.html
fast/table/table-size-integer-overflow.html
- rendering/AutoTableLayout.cpp: Decreased max int.
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
- rendering/FixedTableLayout.cpp: Use shared constant.
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
- rendering/RenderBlock.cpp: Removed unused constant.
- rendering/TableLayout.h: Add shared constant.
(TableLayout):
LayoutTests:
- fast/block/block-size-integer-overflow-expected.txt: Added.
- fast/block/block-size-integer-overflow.html: Added.
- fast/flexbox/box-size-integer-overflow-expected.txt: Added.
- fast/flexbox/box-size-integer-overflow.html: Added.
- fast/table/table-size-integer-overflow-expected.txt: Added.
- fast/table/table-size-integer-overflow.html: Added.
TBR=tc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10583010
- 6:38 PM Changeset in webkit [120655] by
-
- 10 edits in trunk
[Chromium] DeviceOrientation Cleanup
https://bugs.webkit.org/show_bug.cgi?id=89354
Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-18
Reviewed by Kent Tamura.
Source/WebCore:
No new tests because there is no intended change in behavior.
- platform/mock/DeviceOrientationClientMock.h: added OVERRIDE specifier for virtual functions
(DeviceOrientationClientMock):
Source/WebKit/chromium:
- public/WebDeviceOrientation.h: added const-qualifiers to getters, simplified an overly-complicated parameter to two functions
(WebKit::WebDeviceOrientation::isNull):
(WebKit::WebDeviceOrientation::canProvideAlpha):
(WebKit::WebDeviceOrientation::alpha):
(WebKit::WebDeviceOrientation::canProvideBeta):
(WebKit::WebDeviceOrientation::beta):
(WebKit::WebDeviceOrientation::canProvideGamma):
(WebKit::WebDeviceOrientation::gamma):
(WebKit::WebDeviceOrientation::canProvideAbsolute):
(WebKit::WebDeviceOrientation::absolute):
(WebDeviceOrientation):
- public/WebDeviceOrientationClient.h: added WEBKIT_ASSERT_NOT_REACHED to virtual functions
(WebKit::WebDeviceOrientationClient::setController):
(WebKit::WebDeviceOrientationClient::startUpdating):
(WebKit::WebDeviceOrientationClient::stopUpdating):
(WebKit::WebDeviceOrientationClient::lastOrientation):
- public/WebDeviceOrientationClientMock.h: added OVERRIDE specifier for virtual functions
(WebDeviceOrientationClientMock):
- src/DeviceOrientationClientProxy.h: designated functions as 'virtual' and added OVERRIDE specifier
(DeviceOrientationClientProxy):
- src/WebDeviceOrientation.cpp: simplified overly-complicated parameter to two functions
(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::operator=):
Tools:
- DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
(WebViewHost):
- 6:32 PM Changeset in webkit [120654] by
-
- 4 edits in trunk
[EFL] media/video-seek-past-end-playing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=89301
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-18
Reviewed by Philippe Normand.
Source/WebCore:
Switch to double for media duration and playback position
calculations to avoid precision problems.
This patch also removes the workaround for the precision
problem in didEnd() which is no longer needed.
Test: media/video-seek-past-end-playing.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::duration):
LayoutTests:
Unskip media/video-seek-past-end-playing.html now that the
precision problem in MediaPlayerPrivateGStreamer is fixed.
- platform/efl/TestExpectations:
- 6:30 PM Changeset in webkit [120653] by
-
- 117 edits16 moves1 add6 deletes in trunk/LayoutTests
2012-06-18 Andrew Scherkus <scherkus@chromium.org>
[Chromium] Unreviewed. Rebaseline media layout tests due to updated controls.
- platform/chromium-linux-x86/media/video-empty-source-expected.txt: Removed.
- platform/chromium-linux/fast/layers/video-layer-expected.png:
- platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png:
- platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
- platform/chromium-linux/media/audio-controls-rendering-expected.png:
- platform/chromium-linux/media/audio-repaint-expected.png:
- platform/chromium-linux/media/controls-after-reload-expected.png:
- platform/chromium-linux/media/controls-layout-direction-expected.png:
- platform/chromium-linux/media/controls-strict-expected.png:
- platform/chromium-linux/media/controls-styling-expected.png:
- platform/chromium-linux/media/controls-without-preload-expected.png:
- platform/chromium-linux/media/media-controls-clone-expected.png:
- platform/chromium-linux/media/media-document-audio-repaint-expected.png:
- platform/chromium-linux/media/video-controls-rendering-expected.png:
- platform/chromium-linux/media/video-display-toggle-expected.png:
- platform/chromium-linux/media/video-empty-source-expected.png:
- platform/chromium-linux/media/video-empty-source-expected.txt: Removed.
- platform/chromium-linux/media/video-no-audio-expected.png:
- platform/chromium-linux/media/video-playing-and-pause-expected.png:
- platform/chromium-linux/media/video-zoom-controls-expected.png:
- platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
- platform/chromium-mac-leopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
- platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
- platform/chromium-mac-leopard/media/audio-repaint-expected.png:
- platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
- platform/chromium-mac-leopard/media/controls-strict-expected.png:
- platform/chromium-mac-leopard/media/controls-styling-expected.png:
- platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
- platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
- platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
- platform/chromium-mac-leopard/media/video-empty-source-expected.png:
- platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Removed.
- platform/chromium-mac-leopard/media/video-no-audio-expected.png:
- platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
- platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
- platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
- platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
- platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
- platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
- platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
- platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
- platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
- platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
- platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
- platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
- platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
- platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
- platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
- platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Removed.
- platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
- platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
- platform/chromium-mac/fast/layers/video-layer-expected.png:
- platform/chromium-mac/fast/layers/video-layer-expected.txt:
- platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
- platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
- platform/chromium-mac/media/audio-controls-rendering-expected.png:
- platform/chromium-mac/media/audio-controls-rendering-expected.txt:
- platform/chromium-mac/media/audio-repaint-expected.png:
- platform/chromium-mac/media/audio-repaint-expected.txt:
- platform/chromium-mac/media/controls-after-reload-expected.png:
- platform/chromium-mac/media/controls-after-reload-expected.txt:
- platform/chromium-mac/media/controls-layout-direction-expected.png:
- platform/chromium-mac/media/controls-strict-expected.png:
- platform/chromium-mac/media/controls-strict-expected.txt:
- platform/chromium-mac/media/controls-styling-expected.png:
- platform/chromium-mac/media/controls-styling-expected.txt:
- platform/chromium-mac/media/controls-without-preload-expected.png:
- platform/chromium-mac/media/controls-without-preload-expected.txt:
- platform/chromium-mac/media/media-controls-clone-expected.png:
- platform/chromium-mac/media/media-controls-clone-expected.txt:
- platform/chromium-mac/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
- platform/chromium-mac/media/video-controls-rendering-expected.png:
- platform/chromium-mac/media/video-controls-rendering-expected.txt:
- platform/chromium-mac/media/video-display-toggle-expected.png:
- platform/chromium-mac/media/video-display-toggle-expected.txt:
- platform/chromium-mac/media/video-empty-source-expected.png:
- platform/chromium-mac/media/video-empty-source-expected.txt:
- platform/chromium-mac/media/video-no-audio-expected.png:
- platform/chromium-mac/media/video-no-audio-expected.txt:
- platform/chromium-mac/media/video-playing-and-pause-expected.png:
- platform/chromium-mac/media/video-playing-and-pause-expected.txt:
- platform/chromium-mac/media/video-zoom-controls-expected.png:
- platform/chromium-mac/media/video-zoom-controls-expected.txt:
- platform/chromium-win-vista/media/video-empty-source-expected.txt: Removed.
- platform/chromium-win-xp/media/video-empty-source-expected.txt: Removed.
- platform/chromium-win/fast/layers/video-layer-expected.png:
- platform/chromium-win/fast/layers/video-layer-expected.txt:
- platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
- platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
- platform/chromium-win/media/audio-controls-rendering-expected.png:
- platform/chromium-win/media/audio-controls-rendering-expected.txt:
- platform/chromium-win/media/audio-repaint-expected.png:
- platform/chromium-win/media/audio-repaint-expected.txt:
- platform/chromium-win/media/controls-after-reload-expected.png:
- platform/chromium-win/media/controls-after-reload-expected.txt:
- platform/chromium-win/media/controls-layout-direction-expected.png:
- platform/chromium-win/media/controls-strict-expected.png:
- platform/chromium-win/media/controls-strict-expected.txt:
- platform/chromium-win/media/controls-styling-expected.png:
- platform/chromium-win/media/controls-styling-expected.txt:
- platform/chromium-win/media/controls-without-preload-expected.png:
- platform/chromium-win/media/controls-without-preload-expected.txt:
- platform/chromium-win/media/media-controls-clone-expected.png:
- platform/chromium-win/media/media-controls-clone-expected.txt:
- platform/chromium-win/media/media-document-audio-repaint-expected.png:
- platform/chromium-win/media/media-document-audio-repaint-expected.txt:
- platform/chromium-win/media/video-controls-rendering-expected.png:
- platform/chromium-win/media/video-controls-rendering-expected.txt:
- platform/chromium-win/media/video-display-toggle-expected.png:
- platform/chromium-win/media/video-display-toggle-expected.txt:
- platform/chromium-win/media/video-empty-source-expected.png:
- platform/chromium-win/media/video-empty-source-expected.txt:
- platform/chromium-win/media/video-no-audio-expected.png:
- platform/chromium-win/media/video-no-audio-expected.txt:
- platform/chromium-win/media/video-playing-and-pause-expected.png:
- platform/chromium-win/media/video-playing-and-pause-expected.txt:
- platform/chromium-win/media/video-zoom-controls-expected.png:
- platform/chromium-win/media/video-zoom-controls-expected.txt:
- platform/chromium/TestExpectations:
- platform/win-xp/fast/layers/video-layer-expected.txt: Renamed from LayoutTests/platform/win/fast/layers/video-layer-expected.txt.
- platform/win-xp/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/win/media/audio-controls-rendering-expected.txt.
- platform/win-xp/media/audio-repaint-expected.txt: Renamed from LayoutTests/platform/win/media/audio-repaint-expected.txt.
- platform/win-xp/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/win/media/controls-after-reload-expected.txt.
- platform/win-xp/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/win/media/controls-strict-expected.txt.
- platform/win-xp/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/win/media/controls-styling-expected.txt.
- platform/win-xp/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/win/media/controls-without-preload-expected.txt.
- platform/win-xp/media/media-controls-clone-expected.txt: Renamed from LayoutTests/platform/win/media/media-controls-clone-expected.txt.
- platform/win-xp/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt.
- platform/win-xp/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/win/media/video-controls-rendering-expected.txt.
- platform/win-xp/media/video-display-toggle-expected.txt: Renamed from LayoutTests/platform/win/media/video-display-toggle-expected.txt.
- platform/win-xp/media/video-empty-source-expected.txt: Renamed from LayoutTests/platform/win/media/video-empty-source-expected.txt.
- platform/win-xp/media/video-no-audio-expected.txt: Renamed from LayoutTests/platform/win/media/video-no-audio-expected.txt.
- platform/win-xp/media/video-playing-and-pause-expected.txt: Renamed from LayoutTests/platform/win/media/video-playing-and-pause-expected.txt.
- platform/win-xp/media/video-zoom-controls-expected.png: Renamed from LayoutTests/platform/win/media/video-zoom-controls-expected.png.
- platform/win-xp/media/video-zoom-controls-expected.txt: Renamed from LayoutTests/platform/win/media/video-zoom-controls-expected.txt.
- 6:29 PM Changeset in webkit [120652] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 6:21 PM Changeset in webkit [120651] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectations update to mark tests as timing out due to r120627.
- platform/chromium/TestExpectations:
- 6:12 PM Changeset in webkit [120650] by
-
- 2 edits in trunk/Tools
[chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=89254
Patch by James Robinson <jamesr@chromium.org> on 2012-06-18
Reviewed by Adrienne Walker.
This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
upstream.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createGraphicsContext3D):
- 6:09 PM Changeset in webkit [120649] by
-
- 2 edits in trunk/Tools
Minor fix suggested by Adam Barth.
Use $(this._what).empty(); rather than removing children one at a time.
For some reason removeAllChildren() is undefined on this node.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- 6:03 PM Changeset in webkit [120648] by
-
- 7 edits in trunk/Tools
Show TOT revision in garden-o-matic, and make the revisions into links
https://bugs.webkit.org/show_bug.cgi?id=89396
Reviewed by Adam Barth.
The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
where the revisions are links to trac.
To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
the knock-on effect of flipping the target and href attributes for anchors in some test output.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
(ViewController.prototype._displayTesters.updateList.list):
(ViewController.prototype._displayTesters.updateList):
(ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
(ViewController.prototype._domForRegressionRange):
(ViewController.prototype._domForAuxiliaryUIElements):
(ViewController.prototype._domForBuildName):
(ViewController.prototype):
(ViewController.prototype.):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- 6:02 PM Changeset in webkit [120647] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Unreviewed chromium expectations.
- platform/chromium-mac/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
- platform/chromium-win/compositing/fixed-position-scroll-offset-history-restore-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/fixed-position-scroll-offset-history-restore-expected.png.
- 5:58 PM Changeset in webkit [120646] by
-
- 2 edits in trunk/Tools
REGRESSION(r100558): NRWT should work without SVN or GIT
https://bugs.webkit.org/show_bug.cgi?id=76630
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2012-06-18
Reviewed by Dirk Pranke.
NRWT is not supposed to have a requirement that we have an
actual SVN or Git checkout, and we were unnecessarily
initializing the checkout. This patch removes that line :).
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(main):
- 5:50 PM Changeset in webkit [120645] by
-
- 21 edits8 deletes in trunk
Unreviewed, rolling out r120593.
http://trac.webkit.org/changeset/120593
https://bugs.webkit.org/show_bug.cgi?id=89404
Caused failures in fast/forms/file/input-file-entries.html
(Requested by atwilson on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18
Source/WebCore:
- Modules/filesystem/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createIsolatedFileSystem):
- Modules/filesystem/HTMLInputElementFileSystem.cpp: Removed.
- Modules/filesystem/HTMLInputElementFileSystem.h: Removed.
- Modules/filesystem/HTMLInputElementFileSystem.idl: Removed.
- WebCore.gypi:
- html/FileInputType.cpp:
(WebCore::FileInputType::receiveDroppedFiles):
- html/FileInputType.h:
(FileInputType):
- html/HTMLInputElement.cpp:
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
- html/InputType.h:
(InputType):
- platform/DragData.cpp:
(WebCore::DragData::modifierKeyState):
(WebCore):
- platform/DragData.h:
(DragData):
- platform/chromium/DragDataChromium.cpp:
LayoutTests:
- fast/forms/file/input-file-entries-expected.txt: Removed.
- fast/forms/file/input-file-entries.html: Removed.
- fast/forms/resources/dir1/UTF8-2.txt: Removed.
- fast/forms/resources/dir1/UTF8.txt: Removed.
- fast/forms/resources/dir2/green.jpg: Removed.
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 4:54 PM Changeset in webkit [120644] by
-
- 6 edits2 adds in trunk/Source
[chromium] Use WebImageLayer in GraphicsLayerChromium for image layers
https://bugs.webkit.org/show_bug.cgi?id=89150
Reviewed by Adrienne Walker.
Source/Platform:
Adds a WebImageLayer type to represent layers backed by (guess what) Images.
- Platform.gypi:
- chromium/public/WebImageLayer.h: Added.
(WebCore):
(WebKit):
(WebImageLayer):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::~WebImageLayer):
Source/WebCore:
Uses WebImageLayer instead of ImageLayerChromium for GraphicsLayerChromium::setContentsToImage.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
Source/WebKit/chromium:
Implementation of WebImageLayer. Note: This could (should?) live in WebCore/platform/chromium/support/, but it's
here to be next to the other Web*Layer.cpp implementation files.
- WebKit.gyp:
- src/WebImageLayer.cpp: Added.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::setBitmap):
- 4:41 PM Changeset in webkit [120643] by
-
- 11 edits in trunk/Source
[chromium] GraphicsLayerChromium should use WebContentLayer directly
https://bugs.webkit.org/show_bug.cgi?id=89145
Reviewed by Adrienne Walker.
Source/Platform:
Add an opaque rect parameter to WebContentLayerClient::paintContents() for a client to (optionally) provide
information about opaque portions of the painted region for culling optimizations.
- chromium/public/WebContentLayerClient.h:
(WebContentLayerClient):
Source/WebCore:
Ports GraphicsLayerChromium (or more specifically OpaqueRectTrackingContentLayerDelegate) to implement
WebContentLayerClient instead of ContentLayerDelegate. In addition to the mechanical changes, this requires
eagerly setting drawsContent on GraphicsLayerChromium::m_layer since WebContentLayerImpl's default value is
different from LayerChromium's. Covered by all of compositing/
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:
(OpaqueRectTrackingContentLayerDelegate):
Source/WebKit/chromium:
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::paintContents):
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTestMainThreadTypes::createLayer):
- tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::OpaqueRectTrackingContentLayerDelegateTest):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::canvasRect):
(WebCore::TEST_F):
- tests/WebLayerTest.cpp:
- 4:35 PM Changeset in webkit [120642] by
-
- 2 edits in trunk/LayoutTests
Skipping dictation tests on WK2.
Unreviewed.
- platform/mac-wk2/Skipped:
- 4:30 PM Changeset in webkit [120641] by
-
- 13 edits in trunk
Add from-image to css3-images image-resolution
https://bugs.webkit.org/show_bug.cgi?id=85451
Patch by David Barr <davidbarr@chromium.org> on 2012-06-18
Reviewed by Tony Chang.
Source/WebCore:
The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-resolution
No new tests; extended fast/css/image-resolution/image-resolution.html
- css/CSSParser.cpp: Accept from-image identifier in image-resolution property.
(WebCore::CSSParser::parseImageResolution): Map CSSValueFromImage to identifier value from cssValuePool.
- css/CSSValueKeywords.in: Add from-image.
- css/StyleBuilder.cpp: Extend ApplyPropertyImageResolution to apply RenderStyle::imageResolutionSource.
(WebCore::ApplyPropertyImageResolution::applyInheritValue): Apply RenderStyle::imageResolutionSource.
(WebCore::ApplyPropertyImageResolution::applyInitialValue): Apply RenderStyle::imageResolutionSource.
(WebCore::ApplyPropertyImageResolution::applyValue): Map CSSValueFromImage to ImageResolutionFromImage.
- rendering/RenderImage.cpp: Extend conditions for recalculation of intrinsic size.
(WebCore::RenderImage::styleDidChange): Update intrinsic size if RenderStyle::imageResolutionSource() has changed.
- rendering/style/RenderStyle.cpp: Include StyleRareInheritedData::m_imageResolutionSource in style diff.
(WebCore::RenderStyle::diff): Map change in StyleRareInheritedData::m_imageResolutionSource to StyleDifferenceLayout.
- rendering/style/RenderStyle.h: Add RenderStyle::imageResolutionSource, RenderStyle::setImageResolutionSource, RenderStyle::initialImageResolutionSource.
- rendering/style/RenderStyleConstants.h: Add enum ImageResolutionSource.
- rendering/style/StyleRareInheritedData.cpp: Add StyleRareInheritedData::m_imageResolutionSource.
(WebCore::StyleRareInheritedData::StyleRareInheritedData): Add m_imageResolutionSource to default and copy constructor.
(WebCore::StyleRareInheritedData::operator==): Include m_imageResolutionSource in comparison.
- rendering/style/StyleRareInheritedData.h: Add StyleRareInheritedData::m_imageResolutionSource.
(StyleRareInheritedData): Add 1-bit field StyleRareInheritedData::m_imageResolutionSource.
LayoutTests:
- fast/css/image-resolution/image-resolution-expected.txt:
- fast/css/image-resolution/image-resolution.html:
- 4:16 PM Changeset in webkit [120640] by
-
- 4 edits in trunk/Source/WebCore
[chromium] REGRESSION(r120346) ContentLayerPainter should clear rect to be painted
https://bugs.webkit.org/show_bug.cgi?id=89376
Reviewed by Adrienne Walker.
In r120346, a refactor moved a clearRect()/clip() call from ContentLayerPainter - which all
ContentLayerChromiums use - out to OpaqueRectTrackingContentLayerDelegate - which all GraphicsLayerChromium
backed layers use, but which callers using WebContentLayer directly do not use. This meant that the canvas
wasn't cleared/clipped as WebContentLayerClient.h claimed it would be. This moves the clear and the clip
into CanvasLayerTextureUpdater which all paths use, including layers that don't use the ContentLayerPainter.
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::paint):
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
- 4:14 PM Changeset in webkit [120639] by
-
- 12 edits8 deletes in trunk
Unreviewed, rolling out r120119.
http://trac.webkit.org/changeset/120119
Multiple regressions on ClusterFuzz
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
(RenderObject):
LayoutTests:
- animations/first-letter-animation-expected.txt: Removed.
- animations/first-letter-animation.html: Removed.
- animations/first-letter-play-state-expected.txt: Removed.
- animations/first-letter-play-state.html: Removed.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- transitions/first-letter-color-transition-expected.txt: Removed.
- transitions/first-letter-color-transition.html: Removed.
- transitions/first-letter-transition-expected.txt: Removed.
- transitions/first-letter-transition.html: Removed.
- 4:09 PM Changeset in webkit [120638] by
-
- 3 edits2 adds in trunk
REGRESSION(r118414): some pages on concursolutions.com doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=89399
Reviewed by Adam Barth.
Source/WebCore:
The bug was caused by insertAdjacentHTML's not passing context element to createFragmentForInnerOuterHTML.
Test: fast/html/adjacent-html-context-element.html
- html/HTMLElement.cpp:
(WebCore::HTMLElement::insertAdjacentHTML):
LayoutTests:
Add a regression test.
- fast/html/adjacent-html-context-element-expected.txt: Added.
- fast/html/adjacent-html-context-element.html: Added.
- 4:03 PM Changeset in webkit [120637] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Ensure layout has happened before calling into hasNonEmptyBoundingBox()
Also update existing code to use updateLayoutIgnorePendingStylesheets()
https://bugs.webkit.org/show_bug.cgi?id=89258
Reviewed by James Robinson.
- src/WebNode.cpp:
(WebKit::WebNode::isFocusable): Use updateLayoutIgnorePendingStylesheets()
(WebKit::WebNode::hasNonEmptyBoundingBox): Force layout before checking the bounding box
- 3:37 PM Changeset in webkit [120636] by
-
- 5 edits in trunk/Source/WebCore
Fix framebuffer-object-attachment.html failures
https://bugs.webkit.org/show_bug.cgi?id=89387
Reviewed by Kenneth Russell.
- html/canvas/WebGLFramebuffer.cpp: fix detachment behavior with depth/stencil/depth_stencil conflicts
(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
- html/canvas/WebGLFramebuffer.h:
(WebGLFramebuffer):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer): move logic to WebGLFramebuffer
(WebCore::WebGLRenderingContext::framebufferTexture2D): Ditto.
(WebCore::WebGLRenderingContext::getParameter): Correct the wrong assumption that it's always checking the drawingbuffer's DEPTH_BITS/STENCIL_BITS
- html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
- 3:17 PM Changeset in webkit [120635] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed expectations update for chromium after r120602.
- platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
- 3:17 PM Changeset in webkit [120634] by
-
- 8 edits in trunk/Source
[chromium] Ensure that skipping frames during an accelerated animation doesn't cause starvation
https://bugs.webkit.org/show_bug.cgi?id=87766
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-18
Reviewed by James Robinson.
Source/WebCore:
Unit tests:
CCLayerTreeHostTestCheckerboardDoesNotStarveDraws.runMultiThread
CCSchedulerStateMachineTest.TestFailedDrawsWillEventuallyForceADrawAfterTheNextCommit
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::didDrawIfPossibleCompleted):
(WebCore::CCSchedulerStateMachine::setMaximumNumberOfFailedDrawsBeforeDrawIsForced):
(WebCore):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(CCSchedulerStateMachine):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestCheckerboardDoesNotStarveDraws):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::beginTest):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::afterTest):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::animateLayers):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::prepareToDrawOnCCThread):
(WTF::TEST_F):
- tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):
(WebCore):
- tests/CCThreadedTest.cpp:
(WebKitTests::MockLayerTreeHostImpl::prepareToDraw):
- tests/CCThreadedTest.h:
(WebKitTests::TestHooks::prepareToDrawOnCCThread):
- 3:16 PM Changeset in webkit [120633] by
-
- 2 edits in trunk/Tools
[garden-o-matic] Add support for the GTK builders
https://bugs.webkit.org/show_bug.cgi?id=89360
Reviewed by Adam Barth.
Add the 'gtk' platform, essentially a copy of the 'apple' platform since
both get their data from build.webkit.org.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):
- 3:08 PM Changeset in webkit [120632] by
-
- 2 edits in trunk
[BlackBerry] Enable LEGACY_VIEWPORT_ADAPTION
https://bugs.webkit.org/show_bug.cgi?id=89381
Reviewed by Antonio Gomes.
PR 163598
Enable LEGACY_VIEWPORT_ADAPTION.
- Source/cmake/OptionsBlackBerry.cmake:
- 3:08 PM Changeset in webkit [120631] by
-
- 6 edits in branches/chromium/1132
Merge 120629 - [chromium/mac] Unbreak smooth scrolling.
https://bugs.webkit.org/show_bug.cgi?id=89327
Reviewed by Dimitri Glazkov.
Broken by Sam in r115589 / r115591.
Source/WebCore:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::scrollAnimationEnabledForSystem):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
(TestWebKitAPI::InjectedBundleController::platformInitialize):
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10572004
- 3:07 PM Changeset in webkit [120630] by
-
- 12 edits4 adds2 deletes in trunk/LayoutTests
Update baselines after http://trac.webkit.org/changeset/120609.
- platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-linux/fast/multicol/progression-reverse-expected.png: Added.
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-leopard/fast/css/getComputedStyle: Removed.
- platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-snowleopard/fast/multicol/progression-reverse-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac/fast/multicol/progression-reverse-expected.png: Added.
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/fast/multicol/progression-reverse-expected.png: Added.
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- 2:48 PM Changeset in webkit [120629] by
-
- 6 edits in trunk
[chromium/mac] Unbreak smooth scrolling.
https://bugs.webkit.org/show_bug.cgi?id=89327
Reviewed by Dimitri Glazkov.
Broken by Sam in r115589 / r115591.
Source/WebCore:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::scrollAnimationEnabledForSystem):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
(TestWebKitAPI::InjectedBundleController::platformInitialize):
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
- 2:43 PM Changeset in webkit [120628] by
-
- 2 edits in trunk/LayoutTests
Updating test results to include flakey cookies tests.
Unreviewed.
- platform/mac/TestExpectations:
- 2:38 PM Changeset in webkit [120627] by
-
- 41 edits in trunk
Unreviewed, rolling out r120541, r120547, and r120548.
http://trac.webkit.org/changeset/120541
http://trac.webkit.org/changeset/120547
http://trac.webkit.org/changeset/120548
https://bugs.webkit.org/show_bug.cgi?id=89383
This approach doesn't work for WebKit2 (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18
Source/WebCore:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
- testing/InternalSettings.h:
(InternalSettings):
Tools:
- DumpRenderTree/LayoutTestController.cpp:
(setBackingScaleFactorCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::setBackingScaleFactor):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setBackingScaleFactor):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setBackingScaleFactor):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setBackingScaleFactor):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setBackingScaleFactor):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setBackingScaleFactor):
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::postSetBackingScaleFactor):
(WTR):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setBackingScaleFactor):
(WTR):
(WTR::LayoutTestController::callSetBackingScaleFactorCallback):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
LayoutTests:
- compositing/tiled-layers-hidpi.html:
- fast/canvas/2d.backingStorePixelRatio.html:
- fast/canvas/2d.imageDataHD.html:
- fast/hidpi/broken-image-icon-hidpi.html:
- fast/hidpi/broken-image-with-size-hidpi.html:
- fast/hidpi/clip-text-in-hidpi.html:
- fast/hidpi/focus-rings.html:
- fast/hidpi/image-set-as-background.html:
- fast/hidpi/image-set-background-dynamic.html:
- fast/hidpi/image-set-background-repeat-without-size.html:
- fast/hidpi/image-set-background-repeat.html:
- fast/hidpi/image-set-border-image-comparison.html:
- fast/hidpi/image-set-border-image-dynamic.html:
- fast/hidpi/image-set-border-image-simple.html:
- fast/hidpi/image-set-in-content-dynamic.html:
- fast/hidpi/image-set-out-of-order.html:
- fast/hidpi/image-set-simple.html:
- fast/hidpi/image-set-without-specified-width.html:
- fast/hidpi/resize-corner-hidpi.html:
- fast/hidpi/video-controls-in-hidpi.html:
- platform/mac-wk2/plugins/contents-scale-factor.html:
- svg/as-image/image-respects-deviceScaleFactor.html:
- 2:34 PM Changeset in webkit [120626] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] NetworkJob::startNewJobWithRequest() should check the frame pointer
https://bugs.webkit.org/show_bug.cgi?id=89369
Patch by Yong Li <yoli@rim.com> on 2012-06-18
Reviewed by Antonio Gomes.
NetworkJob::startNewJobWithRequest() should stop proceeding if the frame is null,
which means it is a PingLoader job and should just finish now.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::startNewJobWithRequest):
- 2:08 PM Changeset in webkit [120625] by
-
- 2 edits in trunk/LayoutTests
Fix the expected result for this test. This got landed with the wrong expected.txt file.
- http/tests/security/contentSecurityPolicy/source-list-parsing-malformed-meta-expected.txt:
- 1:40 PM Changeset in webkit [120624] by
-
- 3 edits2 adds in trunk
Ideographic comma and full-stops are mishandled in linebreak
https://bugs.webkit.org/show_bug.cgi?id=87041
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop-2.html
Specifically, line breaks were always allowed after an ideographic comma or full stop, even
before a closing bracket.
- rendering/break_lines.cpp:
(WebCore::shouldBreakAfter): Removed code that unconditionally allowed line breaks after
ideographic commas and full stops, which was added for <http://webkit.org/b/17411> to work
around an issue in Unicode 5.0. Current line break iterator implementations are based on
newer versions of Unicode, which do not have that issue, so we can use them instead of the
hardcoded approximate rule.
LayoutTests:
- fast/text/line-breaks-after-ideographic-comma-or-full-stop-2-expected.txt: Added.
- fast/text/line-breaks-after-ideographic-comma-or-full-stop-2.html: Added.
- 1:35 PM Changeset in webkit [120623] by
-
- 2 edits in trunk/Source/WebCore
[TextureMapper] Rename shader variables to match the naming scheme of the newer filter shaders
https://bugs.webkit.org/show_bug.cgi?id=89324
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-18
Reviewed by Noam Rosenthal.
Rename shader variables to align them with those in the new filter shaders.
No new tests. This is just a simple refactor.
- platform/graphics/texmap/TextureMapperShaderManager.cpp:
Rename shader variables so that uniforms are prefixed by "u_", attributes by "a_",
and texture samplers by "s_".
- 1:23 PM Changeset in webkit [120622] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Overscroll can get reset while interacting with a page, due to style recalculations and scroll position clamping
https://bugs.webkit.org/show_bug.cgi?id=89371
PR #166982
Reviewed by Adam Treat.
Patch by Antonio Gomes <agomes@rim.com>
While scrolling, the WebKit thread gets intercalated WebPage::setScrollPosition
calls dispatched from the UI thread. These calls are wrapped with
ScrollableArea::setConstrainsScrollingToContentEdge(false|true) calls, which
can clamp the scroll position (removes overscroll) if set to 'true'.
The following situation can happen: user is scrolling, and WebKit
thread is not in the middle of a WebPage::setScrollPosition call
(so setConstrainsScrollingToContentEdge is 'true'), and a relayout happens.
In this scenario, the scroll position will get clamped to 0,0, removing any
possible overscrolling.
See the stack trace below, paying special attention to frame 16:
Patch fixes this issue by tying ScrollableArea::setConstrainsScrollingToContentEdge
to BackingStore::m_isZoomingOrScrolling, when we are sure clamping should not happen.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setScrollPosition):
- 1:17 PM Changeset in webkit [120621] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Implement native memory bar diagram
https://bugs.webkit.org/show_bug.cgi?id=89106
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-18
Reviewed by Pavel Feldman.
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryBarChart):
(WebInspector.NativeMemoryBarChart.prototype._updateStats):
(WebInspector.NativeMemoryBarChart.prototype.willHide):
(WebInspector.NativeMemoryBarChart.prototype.wasShown):
(WebInspector.NativeMemoryBarChart.prototype._updateView):
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
- inspector/front-end/nativeMemoryProfiler.css:
(.memory-bar-chart-name):
(.memory-bar-chart-bar):
(.memory-bar-chart-size):
(.memory-bar-chart-total):
- 1:06 PM Changeset in webkit [120620] by
-
- 2 edits in trunk/Tools
REGRESSION(r120546): It made 3 webkitpy tests fail
https://bugs.webkit.org/show_bug.cgi?id=89332
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-06-18
Reviewed by Adam Barth.
Update the BaselineOptimizer unittest after r120546.
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_no_add_mac_future):
(BaselineOptimizerTest.test_mac_future):
(BaselineOptimizerTest.test_complex_shadowing):
- 12:59 PM Changeset in webkit [120619] by
-
- 5 edits in trunk/Tools
new-run-webkit-tests output gets confused when logging
https://bugs.webkit.org/show_bug.cgi?id=63793
Reviewed by Adam Barth.
Ship all of the log messages generated in the worker back
to the manager; this allows the messages to be properly
serialized to stderr and for the meter to flush its output correctly.
Note however that this will likely result in messages to be
logged out of order between workers; I'm not sure that there's
an easy way to fix this short of buffering a potentially
unbounded amount of data. It might be better to just log through
stderr unless we're in 'metering' mode, but it's also worth
noting that we already get messages out of order through stderr
on Windows.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.handle_done):
(Manager.handle_finished_test):
(Manager._log_messages):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.init):
(Worker._set_up_logging):
(Worker.run):
(Worker._run_test):
(Worker.cleanup):
(Worker.run_single_test):
(_WorkerLogHandler):
(_WorkerLogHandler.init):
(_WorkerLogHandler.emit):
- Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream.write):
(MeteredStream.writeln):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.writeln):
- 12:53 PM Changeset in webkit [120618] by
-
- 2 edits1 add in trunk/PerformanceTests
Web Inspector: native memory snapshot performance and coverage test implementation.
https://bugs.webkit.org/show_bug.cgi?id=89363
We have to track the performance of MemoryAgent.getProcessMemoryDistribution.
Also this test will work as a burn down chart for Unknown memory metric.
Reviewed by Pavel Feldman.
- inspector/native-memory-snapshot.html: Added.
- inspector/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.reportSize):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
- 12:51 PM Changeset in webkit [120617] by
-
- 3 edits2 adds in trunk
Crash in CSPSource::parseSource
https://bugs.webkit.org/show_bug.cgi?id=89353
Patch by Mike West <mkwst@chromium.org> on 2012-06-18
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/contentSecurityPolicy/source-list-parsing-malformed-meta.html
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPSourceList::parseSource):
Checking that we're not past the end of the string before deref.
LayoutTests:
- http/tests/security/contentSecurityPolicy/source-list-parsing-malformed-meta.html: Added.
- 12:30 PM Changeset in webkit [120616] by
-
- 3 edits20 adds in trunk
CSS 2.1 failure: table-height-algorithm-012 fails
https://bugs.webkit.org/show_bug.cgi?id=85652
Reviewed by Julien Chaffraix.
Source/WebCore:
Test: css2.1/20110323/table-height-algorithm-012.htm
fast/css/vertical-align-baseline-rowspan-001.htm
fast/css/vertical-align-baseline-rowspan-002.htm
fast/css/vertical-align-baseline-rowspan-003.htm
fast/css/vertical-align-baseline-rowspan-004.htm
fast/css/vertical-align-baseline-rowspan-005.htm
fast/css/vertical-align-baseline-rowspan-006.htm
fast/css/vertical-align-baseline-rowspan-007.htm
fast/css/vertical-align-baseline-rowspan-008.htm
fast/css/vertical-align-baseline-rowspan-009.htm
A spanning cell with Vertical-align set to 'baseline' should align the cell's content baseline
(which is the bottom of the first line of text or in-flow content) with the baseline of the first of the rows it spans.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight): Only calculate the baseline for the first row in a rowspan. This
ensures that any height added to the rowspan from the baseline is only added to the first row in the span rather than
to each of them.
(WebCore::RenderTableSection::layoutRows): Rather than get the baseline for each row in a rowspan (with the result that
only the baseline for the last row actually sticks), calculate it for the first row in the rowspan only. This function is
inefficient when handling rowspans so this doesn't fix the fact that redundant calculations are performed on each subsequent
row in the span - that should be done separately.
LayoutTests:
- css2.1/20110323/table-height-algorithm-012-expected.html: Added.
- css2.1/20110323/table-height-algorithm-012.htm: Added.
- fast/css/vertical-align-baseline-rowspan-001-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-001.htm: Added.
- fast/css/vertical-align-baseline-rowspan-002-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-002.htm: Added.
- fast/css/vertical-align-baseline-rowspan-003-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-003.htm: Added.
These are a few variations on table-height-algorithm-012.htm
- fast/css/vertical-align-baseline-rowspan-004-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-004.htm: Added.
- fast/css/vertical-align-baseline-rowspan-005-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-005.htm: Added.
- fast/css/vertical-align-baseline-rowspan-006-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-006.htm: Added.
These three test the calculation of the baseline RenderTableSection::calcRowLogicalHeight,
where we now always use the first row in the span. Without this the 'Filler Text' in the middle
cell aligns beyond the top of the table.
- fast/css/vertical-align-baseline-rowspan-007-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-007.htm: Added.
- fast/css/vertical-align-baseline-rowspan-008-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-008.htm: Added.
- fast/css/vertical-align-baseline-rowspan-009-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-009.htm: Added.
These make sure the alignment used in the first row of the span is correct when things like
the height of the cell and the height of the span are specified.
- 12:16 PM Changeset in webkit [120615] by
-
- 5 edits in trunk
Event dispatcher should use InsertionPoint::hasDistribution instead of InsertinPoint::isActive in re-targeting.
https://bugs.webkit.org/show_bug.cgi?id=89180
Reviewed by Dimitri Glazkov.
Source/WebCore:
If an event is fired on a fallback element within a insertion
point which does not select any nodes, the result of event's
re-targeting will be wrong since it uses
InsertionPoint::isActive() to judge an existence of a lower boundary.
That must use InsertionPoint::hasDistribution().
Test: fast/dom/shadow/shadow-dom-event-dispatching.html
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::ensureEventAncestors):
LayoutTests:
- fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
- fast/dom/shadow/shadow-dom-event-dispatching.html:
- 12:02 PM Changeset in webkit [120614] by
-
- 4 edits in trunk/Tools
[garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
https://bugs.webkit.org/show_bug.cgi?id=89362
Reviewed by Simon Fraser.
Replace white spaces, braces and dots in the builder name with underscores. This
way the JQuery tabs will be properly matched with the according container.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- 11:52 AM Changeset in webkit [120613] by
-
- 9 edits in trunk
Source/WebCore: [chromium] Add iccjpeg and qcms to chromium port
Reviewed by Adam Barth.
Covered by existing layout tests which will be rebaselined.
- WebCore.gyp/WebCore.gyp: Add qcms to the build.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile. On OSX, return the default RGB profile. Add FIXME to use the user's monitor profile and verify that profile for other platforms.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the two known output color spaces for which the decoder uses a data swizzle. (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For libjpeg-turbo, alpha may be present in the swizzled output color space.
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
to use during decoding, and ensure we switch to inputing RGBA data to qcms
even if the desired output data is BGRA: outputScanlines() sends BGRA data
to the frame buffer following color correction if needed.
(JPEGImageReader):
(WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
(WebCore::JPEGImageReader::createColorTransform): Create color transform.
Release the existing transform (if any) and assign to the color transform
created from the color profile data.
(WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
transform to each decoded image row.
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other setters and getters. (WebCore::PNGImageReader::decodingSizeOnly): Ditto. (WebCore::PNGImageReader::setHasAlpha): Ditto. (WebCore::PNGImageReader::hasAlpha): Ditto. (WebCore::PNGImageReader::interlaceBuffer): Ditto. (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer, used when a color transform is applied to the decoded image pixels. (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer. (WebCore::PNGImageReader::colorTransform): qcms color transform getter. (WebCore::PNGImageReader::createColorTransform): Create color transform. Release the existing transform (if any) and assign to the color transform created from the color profile data. (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color transform to use for decoding. Clear m_colorProfile (not used anymore). (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if a color transform is needed for decoding. Apply color transform to each decoded image row.
- platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no longer used. Add a FIXME to remove the old implementation. (WebCore::ImageFrame::setStatus): Remove old color correction code.
Patch by Tony Payne <tpayne@chromium.org> on 2012-06-18
Source/WTF: [chromium] Add iccjpeg and qcms to chromium port.
https://bugs.webkit.org/show_bug.cgi?id=81974
Patch by Tony Payne <tpayne@chromium.org> on 2012-06-18
- wtf/Platform.h: Add Chromium USE defines for ICCJPEG and QCMSLIB
to each Chromium platform, excluding Android.
Reviewed by Adam Barth.
- 11:45 AM Changeset in webkit [120612] by
-
- 17 edits in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines after r120596 and r120609.
- platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/gtk/fast/layers/video-layer-expected.txt:
- platform/gtk/media/audio-controls-rendering-expected.txt:
- platform/gtk/media/audio-repaint-expected.txt:
- platform/gtk/media/controls-strict-expected.txt:
- platform/gtk/media/controls-styling-expected.txt:
- platform/gtk/media/controls-without-preload-expected.txt:
- platform/gtk/media/media-controls-clone-expected.txt:
- platform/gtk/media/media-document-audio-repaint-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt:
- platform/gtk/media/video-empty-source-expected.txt:
- platform/gtk/media/video-no-audio-expected.txt:
- platform/gtk/media/video-volume-slider-expected.txt:
- platform/gtk/media/video-zoom-controls-expected.txt:
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- 11:45 AM Changeset in webkit [120611] by
-
- 4 edits in trunk/Tools
nrwt: metered output doesn't handle C cleanly
https://bugs.webkit.org/show_bug.cgi?id=89249
Reviewed by Tony Chang.
If you ctrl-c a running nrwt (w/o --verbose), then all but
two characters of the last update are erased, and then we print
"interrupted, exiting" as an update, which itself then gets
erased. Fix this so that we flush the meter (making the last
update persistent, so that we print the C for a visual clue),
print the interrupt message, and move on ...
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream.flush):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._write):
(Printer):
(Printer.flush):
- 11:37 AM Changeset in webkit [120610] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip one more failing test to paint.
- platform/qt/Skipped:
- 11:05 AM Changeset in webkit [120609] by
-
- 20 edits3 adds in trunk
Column progression direction cannot be set independently of writing direction
https://bugs.webkit.org/show_bug.cgi?id=89315
Source/WebCore:
Added a column-progression property, which can have the values 'normal' and 'reverse'. When
set to 'reverse', the first column is positioned at the end side of the block, and
subsequent columns go from the in the start direction (in the inline column axis case; in
the block column axis case, the first column coincides with the block and subsequent columns
go before the block).
Reviewed by Darin Adler.
Test: fast/multicol/progression-reverse.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added handling of the new
property.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Added validity check for the new property. The valid
values are the identifiers 'normal' and 'reverse'.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added this mapping from ColumnProgression
enum values to the identifiers 'normal and 'reverse'.
(WebCore::CSSPrimitiveValue::operator ColumnProgression): Added this mapping from the
identifiers 'normal' and 'reverse' to ColumnProgression enum values.
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty): Added the new property to the set of
non-inherited properties.
- css/CSSPropertyNames.in: Added -webkit-column-progression.
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder): Added a handler for the new property.
- rendering/ColumnInfo.h:
(WebCore::ColumnInfo::ColumnInfo): Added an initializer for the m_progressionIsReversed
member variable.
(WebCore::ColumnInfo::progressionIsReversed): Added this accessor.
(WebCore::ColumnInfo::setProgressionIsReversed): Ditto.
(ColumnInfo): Added a m_progressionIsReversed member variable.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules): Changed to advance in the reverse direction if
needed.
(WebCore::RenderBlock::setDesiredColumnCountAndWidth): Added call to
ColumnInfo::setProgressionIsReversed(), based on the new property.
(WebCore::RenderBlock::columnRectAt): Changed to take the progression direction into
account.
- rendering/style/RenderStyle.h: Added accessors and initial value for column progression.
- rendering/style/RenderStyleConstants.h: Added ColumnProgression enum.
- rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData): Added initializer for the m_progression
member variable.
(WebCore::StyleMultiColData::operator==): Added equality check for m_progression.
- rendering/style/StyleMultiColData.h:
(StyleMultiColData): Added m_progression member variable.
LayoutTests:
Reviewed by Darin Adler.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/multicol/progression-reverse-expected.png: Added.
- fast/multicol/progression-reverse-expected.txt: Added.
- fast/multicol/progression-reverse.html: Added.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/svg/css/getComputedStyle-basic-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 10:51 AM JavaScriptCore edited by
- Typo, 3rd paragraph - "JavaScriptCode" (diff)
- 10:23 AM Changeset in webkit [120608] by
-
- 4 edits in trunk/Source/WebCore
[TextureMapper] Replace the source transform with a flip uniform
https://bugs.webkit.org/show_bug.cgi?id=89317
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-18
Reviewed by Noam Rosenthal.
No new tests. This should not change any observable behavior.
- platform/graphics/texmap/TextureMapperGL.cpp: Instead of building and passing
the m4src matrix to the shader, just pass a single uniform that says whether or
not the texture should be flipped.
- platform/graphics/texmap/TextureMapperShaderManager.cpp: Change the shader programs
to deal with a flip variable rather than a source matrix.
(WebCore::TextureMapperShaderProgram::TextureMapperShaderProgram): Instead of getting the location
of the source matrix, get the location of the flip uniform.
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple): Ditto.
(WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple): Ditto.
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask): Ditto.
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::TextureMapperShaderProgramRectOpacityAndMask): Ditto.
- platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore::TextureMapperShaderProgram::flipLocation): Added this getter.
(TextureMapperShaderProgram): Rename the source matrix location member to reflect above changes.
- 10:17 AM Changeset in webkit [120607] by
-
- 7 edits in trunk
Unreviewed, rolling out r120598.
http://trac.webkit.org/changeset/120598
https://bugs.webkit.org/show_bug.cgi?id=89359
Patch causes crashes on EFL and GTK release builds (Requested
by zdobersek on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18
Source/WebCore:
- platform/graphics/Pattern.h:
(Pattern):
- platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::prepareForFilling):
- platform/graphics/cairo/PlatformContextCairo.h:
LayoutTests:
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- 10:15 AM Changeset in webkit [120606] by
-
- 18 edits in trunk/Source/WebCore
Unreviewed, rolling out r120592.
http://trac.webkit.org/changeset/120592
https://bugs.webkit.org/show_bug.cgi?id=89357
Broke v8 bindings on windows. (Requested by atwilson on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18
- bindings/js/JSJavaScriptCallFrameCustom.cpp:
- bindings/js/ScriptDebugServer.cpp:
- bindings/js/ScriptDebugServer.h:
(ScriptDebugServer):
- bindings/v8/DebuggerScript.js:
(.):
- bindings/v8/JavaScriptCallFrame.cpp:
- bindings/v8/JavaScriptCallFrame.h:
(JavaScriptCallFrame):
- bindings/v8/ScriptDebugServer.cpp:
- bindings/v8/ScriptDebugServer.h:
- bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
- bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
- inspector/InjectedScript.cpp:
- inspector/InjectedScript.h:
(InjectedScript):
- inspector/InjectedScriptSource.js:
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setScriptSource):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/JavaScriptCallFrame.idl:
- 10:11 AM Changeset in webkit [120605] by
-
- 2 edits in trunk/Source/WebCore
RenderTableSection wastes vector capacity
https://bugs.webkit.org/show_bug.cgi?id=86561
Reviewed by Antti Koivisto.
Memory optimization, covered by existing tests.
The issue is that addChild calls Vector::grow() which can over-allocate our row grid (especially
for small tables as we allocate at least 16 entries). As we don't know if addChild is called
in a loop (e.g. during parsing), we postpone the shrinkToFit call at layout time.
(WebCore::RenderTableSection::layout):
Added a shrinkToFit call with some explanation as to why it's good trade-off to do it now.
- 10:04 AM Changeset in webkit [120604] by
-
- 18 edits in trunk/LayoutTests
[EFL] Rebaseline media tests after r120596
https://bugs.webkit.org/show_bug.cgi?id=89352
Unreviewed EFL gardening. Rebaseline a few media tests
due to r120596.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-18
- platform/efl/fast/layers/video-layer-expected.txt:
- platform/efl/media/audio-controls-rendering-expected.txt:
- platform/efl/media/audio-repaint-expected.png:
- platform/efl/media/audio-repaint-expected.txt:
- platform/efl/media/controls-after-reload-expected.txt:
- platform/efl/media/controls-strict-expected.txt:
- platform/efl/media/controls-styling-expected.txt:
- platform/efl/media/controls-without-preload-expected.txt:
- platform/efl/media/media-controls-clone-expected.png:
- platform/efl/media/media-controls-clone-expected.txt:
- platform/efl/media/media-document-audio-repaint-expected.txt:
- platform/efl/media/video-controls-rendering-expected.png:
- platform/efl/media/video-controls-rendering-expected.txt:
- platform/efl/media/video-display-toggle-expected.txt:
- platform/efl/media/video-empty-source-expected.txt:
- platform/efl/media/video-zoom-controls-expected.png:
- platform/efl/media/video-zoom-controls-expected.txt:
- 9:55 AM Changeset in webkit [120603] by
-
- 6 edits1 move1 delete in trunk
[Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
https://bugs.webkit.org/show_bug.cgi?id=89228
Reviewed by Tony Chang.
Source/WebKit/chromium:
- WebKit.gyp:
- public/linux/WebFontRendering.h:
(WebKit):
(WebFontRendering):
- public/linuxish/WebFontRendering.h: Removed.
- src/linux/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp.
(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::setLCDOrder):
(WebKit::WebFontRendering::setLCDOrientation):
Tools:
- DumpRenderTree/chromium/LayoutTestController.cpp:
- DumpRenderTree/chromium/TestShellAndroid.cpp:
- 9:40 AM Changeset in webkit [120602] by
-
- 5 edits3 deletes in trunk
webkit fails IETC border-radius-clip-002
https://bugs.webkit.org/show_bug.cgi?id=83205
Source/WebCore:
Added addRoundedRectClip instead of just clip when clipToBorderRadius
is true and bgLayer->clip() == ContentFillBox.
Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-18
Reviewed by Simon Fraser.
This change is covered by the existing test: ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.
However expected images should be updated. I updated chromium-linux
and chromium-mac's expected images and removed chromium-win,
chromium-mac-leopard and chromium-mac-snowleopard's expected images.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
As the code for "clipping to content boxes as necessary" doesn't
consider border-radius or not, added the code for checking
clipToBorderRadius or not, and if so, modified to use
getBackgroundRoundedRect for obtaining rounded rect and to use
addRoundedRectClip by using the obtained rounded rect.
LayoutTests:
Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-18
Reviewed by Simon Fraser.
- platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
- platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Removed.
- platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Removed.
- platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Removed.
- 9:33 AM Changeset in webkit [120601] by
-
- 3 edits4 adds in trunk
Source/WebCore: Allow updateFixedElementsAfterScrolling() to run during layout.
https://bugs.webkit.org/show_bug.cgi?id=84965
This is needed because HistoryController restores the previous scroll
position during layout (because we don't want an ugly flash of wrongly-
scrolled content).
Patch by Iain Merrick <husky@google.com> on 2012-06-18
Reviewed by Simon Fraser.
Test: compositing/fixed-position-scroll-offset-history-restore.html
- page/FrameView.cpp:
(WebCore::FrameView::updateFixedElementsAfterScrolling):
LayoutTests: Allow updateFixedElementsAfterScrolling() to run during layout.
https://bugs.webkit.org/show_bug.cgi?id=84965
This is needed because HistoryController restores the previous scroll
position during layout (because we don't want an ugly flash of wrongly-
scrolled content).
Patch by Iain Merrick <husky@google.com> on 2012-06-18
Reviewed by Simon Fraser.
- compositing/fixed-position-scroll-offset-history-restore-expected.txt: Added.
- compositing/fixed-position-scroll-offset-history-restore.html: Added.
- compositing/resources/fixed-position-scroll-offset-history-restore-2.html: Added.
- platform/chromium-linux/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
- 9:04 AM Changeset in webkit [120600] by
-
- 3 edits3 adds in trunk
CSSOM wrappers are not built for rules in the per-document and page group user stylesheets
https://bugs.webkit.org/show_bug.cgi?id=89221
Reviewed by Antti Koivisto.
Source/WebCore:
The issue manifested itself by not displaying injected page group stylesheet data in the Styles pane.
Test: inspector/styles/inject-stylesheet.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
LayoutTests:
- inspector/styles/inject-stylesheet-expected.txt: Added.
- inspector/styles/inject-stylesheet.html: Added.
- inspector/styles/resources/inject-stylesheet-iframe-data.html: Added.
- 8:52 AM Changeset in webkit [120599] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip one more failing test. (Less test == less problem. :) )
- platform/qt/Skipped:
- 8:41 AM Changeset in webkit [120598] by
-
- 7 edits in trunk
[cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html
https://bugs.webkit.org/show_bug.cgi?id=53085
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-18
Reviewed by Martin Robinson.
Source/WebCore:
Clipping previously unlimited vertical and horizontal pattern repeats with
a clip rectangle similar to the Qt Graphics Context.
No new tests, this patch fixes
canvas/philip/tests/2d.pattern.paint.repeat* tests.
- platform/graphics/Pattern.h:
(WebCore::Pattern::getPatternSpaceTransform): Adding constant getter method to be able to map to pattern space externally, needed by PlatformContextCairo::clipForPatternFilling.
- platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::prepareForFilling):
(WebCore::PlatformContextCairo::clipForPatternFilling): Clip pattern repeats if needed.
- platform/graphics/cairo/PlatformContextCairo.h:
LayoutTests:
canvas/philip/tests/2d.pattern.paint.repeat* tests now passing.
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- 8:06 AM Changeset in webkit [120597] by
-
- 2 edits in trunk/Source/WebCore
Touch events with default actions should be handled.
https://bugs.webkit.org/show_bug.cgi?id=89304.
Reviewed by Kent Tamura.
Covered by existing tests and tests in blocked bug
https://bugs.webkit.org/show_bug.cgi?id=88807
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Return true that the touch event
was handled for either preventDefault or defaultHandled.
- 8:04 AM Changeset in webkit [120596] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION introduced in bug 88623: new shadowPseudoId elements need to get default styling.
https://bugs.webkit.org/show_bug.cgi?id=89280
Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-18
Reviewed by Eric Carlson.
No new tests; existing tests found this bug.
- css/html.css:
(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container):
Add -webkit-media-slider-container to the default styling.
(input[type="range"]::-webkit-slider-thumb, input[type="range"]::-webkit-media-slider-thumb):
Add -webkit-media-slider-thumb to the default styling.
- 7:45 AM Changeset in webkit [120595] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, remove duplicates from the GTK WK2
Skipped list that are already present in the generic WK2 Skipped
list or in GTK's TestExpectations.
- platform/gtk-wk2/Skipped:
- 7:27 AM Changeset in webkit [120594] by
-
- 3 edits2 adds in trunk/Source/WebKit/qt
[Qt] Update QML plugins to Qt 5 style
https://bugs.webkit.org/show_bug.cgi?id=89027
Reviewed by Csaba Osztrogonác.
Since support for Qt 4 style plugins was removed from Qt 5
we need to update our plugins to the new style to be able
to build with a more recent Qt 5 hash.
Add empty plugin description json files for now.
- declarative/experimental/plugin.cpp:
- declarative/experimental/plugin.json: Added.
- declarative/plugin.cpp:
(WebKitQmlPlugin):
- declarative/plugin.json: Added.
- 7:10 AM Changeset in webkit [120593] by
-
- 21 edits10 adds in trunk
Support File/DirectoryEntry access for <input type=file> if FileSystem API is enabled
https://bugs.webkit.org/show_bug.cgi?id=88293
Reviewed by Tony Chang.
Source/WebCore:
Proposal email on whatwg: http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033814.html
Proposal draft: http://wiki.whatwg.org/wiki/DragAndDropEntries
Test: fast/forms/file/input-file-entries.html
- Modules/filesystem/HTMLInputElementFileSystem.cpp: Added.
- Modules/filesystem/HTMLInputElementFileSystem.h: Added.
- Modules/filesystem/HTMLInputElementFileSystem.idl: Added.
- WebCore.gypi:
- html/FileInputType.cpp:
(WebCore::FileInputType::receiveDroppedFiles): Retrieves dropped file
system Id if the given DragData has it.
(WebCore::FileInputType::droppedFileSystemId): Added. This returns
dropped file system Id retrieved in receiveDroppedFiles, or an empty
string if the platform does not support isolated file system for
dropped files.
- html/FileInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::droppedFileSystemId): Added.
- html/HTMLInputElement.h:
- html/InputType.cpp:
(WebCore::InputType::droppedFileSystemId): Added.
- html/InputType.h:
- platform/DragData.cpp:
- platform/DragData.h:
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::droppedFileSystemId): Added.
LayoutTests:
- fast/forms/file/input-file-entries-expected.txt: Added.
- fast/forms/file/input-file-entries.html: Added.
- fast/forms/resources/dir1/UTF8-2.txt: Added.
- fast/forms/resources/dir1/UTF8.txt: Added.
- fast/forms/resources/dir2/green.jpg: Added.
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 6:54 AM Changeset in webkit [120592] by
-
- 18 edits in trunk/Source/WebCore
Web Inspector: Support 'Restart frame' in protocol and backend
https://bugs.webkit.org/show_bug.cgi?id=89147
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-06-18
Reviewed by Yury Semikhatsky.
Inspector.json got new command in Debugger domain.
A call path from InspectorDebuggerAgent to V8 Debug.LiveEdit.RestartFrame API
is built.
JSC implementation is a stub with fix me (40300).
- bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::restart):
(WebCore):
- bindings/js/JavaScriptCallFrame.h:
(JavaScriptCallFrame):
- bindings/js/ScriptDebugServer.cpp:
(WebCore):
(WebCore::ScriptDebugServer::updateCallStack):
- bindings/js/ScriptDebugServer.h:
(ScriptDebugServer):
- bindings/v8/DebuggerScript.js:
(.):
- bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::restart):
(WebCore):
- bindings/v8/JavaScriptCallFrame.h:
(JavaScriptCallFrame):
- bindings/v8/ScriptDebugServer.cpp:
(WebCore):
(WebCore::ScriptDebugServer::updateCallStack):
- bindings/v8/ScriptDebugServer.h:
- bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
- bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::restartCallback):
(WebCore):
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::restartFrame):
(WebCore):
- inspector/InjectedScript.h:
(InjectedScript):
- inspector/InjectedScriptSource.js:
(.):
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::restartFrame):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/JavaScriptCallFrame.idl:
- 6:46 AM Changeset in webkit [120591] by
-
- 10 edits in trunk
Unreviewed, rolling out r120485 and r120582.
http://trac.webkit.org/changeset/120485
http://trac.webkit.org/changeset/120582
https://bugs.webkit.org/show_bug.cgi?id=89345
chromeos tree breakage (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18
Source/WebCore:
- WebCore.gyp/WebCore.gyp:
- platform/image-decoders/ImageDecoder.h:
(ImageFrame):
(ImageDecoder):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(turboSwizzled):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::decode):
(JPEGImageReader):
(WebCore::JPEGImageDecoder::outputScanlines):
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::currentBufferSize):
(PNGImageReader):
(WebCore::PNGImageReader::decodingSizeOnly):
(WebCore::PNGImageReader::interlaceBuffer):
(WebCore::PNGImageReader::hasAlpha):
(WebCore::PNGImageReader::setHasAlpha):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
- platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore):
(WebCore::resolveColorSpace):
(WebCore::createColorSpace):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):
Source/WTF:
- wtf/Platform.h:
LayoutTests:
- platform/chromium/TestExpectations:
- 5:53 AM Changeset in webkit [120590] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening after r120311. It made inspector/extensions/extensions-panel.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=89333
Patch by János Badics <János Badics> on 2012-06-18
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 4:49 AM Companies and Organizations that have contributed to WebKit edited by
- (diff)
- 4:40 AM Changeset in webkit [120589] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Add heap profiler owned memory to the pie chart
https://bugs.webkit.org/show_bug.cgi?id=89203
Heap profiler may consume considerable amount of memory
which is currently falls into Unknown category.
Give it a separate sector on the pie chart.
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-18
Reviewed by Yury Semikhatsky.
- bindings/js/ScriptProfiler.h:
(WebCore::ScriptProfiler::profilerSnapshotsSize):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::profilerSnapshotsSize):
(WebCore):
- bindings/v8/ScriptProfiler.h:
(ScriptProfiler):
- inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
(WebCore::inspectorData):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
- 4:13 AM Changeset in webkit [120588] by
-
- 7 edits in trunk
[GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
https://bugs.webkit.org/show_bug.cgi?id=89226
Reviewed by Martin Robinson.
Source/WebCore:
Implement webkitAccessibleValueGetMinimumIncrement() properly,
doing something similar to what is done in AccessibilityObject's
increment() and decrement() functions.
Also, added missing bits to webkitAccessibleValueSetCurrentValue
to make sure we check the new value against range limits.
- accessibility/gtk/WebKitAccessibleInterfaceValue.cpp:
(webkitAccessibleValueGetCurrentValue):
(webkitAccessibleValueGetMaximumValue):
(webkitAccessibleValueGetMinimumValue):
(webkitAccessibleValueSetCurrentValue):
(webkitAccessibleValueGetMinimumIncrement):
Source/WebKit/gtk:
Remove unnecesary functions incrementAccessibilityValue() and
decrementAccessibilityValue() from DumpRenderTreeSupportGtk.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
Implement increment() and decrement() functions in term of the AtkValue interface,
instead of using DumpRenderTreeSupportGtk helper class.
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):
(alterCurrentValue):
(AccessibilityUIElement::increment):
(AccessibilityUIElement::decrement):
- 4:11 AM Changeset in webkit [120587] by
-
- 3 edits6 deletes in trunk/LayoutTests
fast/files/xhr-response-blob should use other file/blob type than javascript
https://bugs.webkit.org/show_bug.cgi?id=89338
Reviewed by Kentaro Hara.
Changing the test to use the most basic text/plain type.
Also removing platform-specific expectations.
- fast/files/script-tests/xhr-response-blob.js: Updated.
- fast/files/xhr-response-blob-expected.txt: Updated.
- platform/chromium-linux/fast/files/xhr-response-blob-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/files/xhr-response-blob-expected.txt: Removed.
- platform/chromium-mac/fast/files/xhr-response-blob-expected.txt: Removed.
- platform/chromium/fast/files/xhr-response-blob-expected.txt: Removed.
- platform/qt/fast/files/xhr-response-blob-expected.txt: Removed.
- 4:09 AM Changeset in webkit [120586] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Spellchecker should show suggestions only when right-clicking a misspelled word.
https://bugs.webkit.org/show_bug.cgi?id=89331
Reviewed by Hajime Morita.
When a selection includes two or more misspelled words, it is not so easy to
select one word from them and to show its suggestions. To avoid this problem,
this change shows suggestions only when the selection is collapsed. For this
case, we can use Range::setStart and setEnd to convert a DocumentMarker to a
Range.
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Added a check that the selection is collapsed.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::replaceMisspelledRange): Added a check that the selection is collapsed. Also, use Range::setStart() and Range::setEnd() to get the marker range to emulate the behavior of DocumentMarker::markersInRange().
- 3:56 AM Changeset in webkit [120585] by
-
- 2 edits in trunk/Source
[chromium] Cleanup: remove PlatformSupport::createAsyncFileSystem as it's no longer used
https://bugs.webkit.org/show_bug.cgi?id=89083
Reviewed by Kentaro Hara.
Source/WebCore:
No new tests as this has no functional changes.
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
- 3:43 AM Changeset in webkit [120584] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed gardening after r120574.
- fast/files/xhr-response-blob-expected.txt:
- platform/qt/fast/files/xhr-response-blob-expected.txt: Added.
- 3:30 AM Changeset in webkit [120583] by
-
- 9 edits in trunk
Fix syntax of FileReader::readAsDataURL result
https://bugs.webkit.org/show_bug.cgi?id=89330
When readAsDataURL generates data URL without media type, it used to omit semicolon before
"base64" keyword. But this semicolor is required in this case, according to RFC2397.
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-18
Reviewed by Kent Tamura.
Source/WebCore:
Test: fast/files/read-blob-async.html
fast/files/workers/worker-read-blob-async.html:
fast/files/workers/worker-read-blob-sync.html:
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::convertToDataURL):
LayoutTests:
- fast/files/read-blob-async-expected.txt:
- fast/files/workers/worker-read-blob-async-expected.txt:
- fast/files/workers/worker-read-blob-sync-expected.txt:
- platform/chromium/fast/files/read-blob-async-expected.txt:
- platform/chromium/fast/files/workers/worker-read-blob-async-expected.txt:
- platform/chromium/fast/files/workers/worker-read-blob-sync-expected.txt:
- 3:24 AM Changeset in webkit [120582] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed chormium crash fix. This should be revisited.
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::qcmsOutputDeviceProfile):
- 3:03 AM Changeset in webkit [120581] by
-
- 4 edits1 add in trunk
[EFL] fast/files/xhr-response-blob.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=89334
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-18
Reviewed by Kentaro Hara.
Source/WebCore:
Call wrap() instead of createWrapper() in JSBlob's toJS()
to avoid hitting the !getCachedWrapper ASSERT in
createWrapper() because we fail to use the cached wrapper.
Test: fast/files/xhr-response-blob.html
- bindings/js/JSBlobCustom.cpp:
(WebCore::toJS):
LayoutTests:
Unskip fast/files/xhr-response-blob.html now that it
no longer crashes.
- platform/efl/TestExpectations:
- platform/efl/fast/files/xhr-response-blob-expected.txt: Added.
- 2:31 AM Changeset in webkit [120580] by
-
- 4 edits in trunk/LayoutTests
[Chromium] fast/events/constructors/speech-recognition-event-constructor.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88856
Reviewed by Adam Barth.
This fixes and re-enables the layout test that I forgot to update in r120053.
- fast/events/constructors/speech-recognition-event-constructor-expected.txt:
- fast/events/constructors/speech-recognition-event-constructor.html:
- platform/chromium/TestExpectations:
- 2:07 AM Changeset in webkit [120579] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: rename Unknown to Other in Native heap snapshot.
https://bugs.webkit.org/show_bug.cgi?id=89306
Cosmetic change.
Reviewed by Yury Semikhatsky.
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.MemoryBlockViewProperties._initialize):
- 1:24 AM Changeset in webkit [120578] by
-
- 2 edits in trunk/LayoutTests
[EFL] skip fast/files/xhr-response-blob.html
https://bugs.webkit.org/show_bug.cgi?id=89335
Unreviewed EFL gardening. Skip fast/files/xhr-response-blob.html
because it is crashing.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-18
- platform/efl/TestExpectations:
- 1:12 AM Changeset in webkit [120577] by
-
- 2 edits in trunk/Source/WebCore
TextureMapperLayer: invisible layers do not let their children to be painted
https://bugs.webkit.org/show_bug.cgi?id=88786
Reviewed by Noam Rosenthal.
Do not early discard recursively painting children layers if the
current layer is not visible.
Changes already covered by compositing tests. This fixes both
compositing/backface-visibility/backface-visibility-3d.html and
compositing/backface-visibility/backface-visibility-non3d.html.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::isVisible):
- 12:25 AM Changeset in webkit [120576] by
-
- 4 edits9 adds in trunk/LayoutTests
[EFL] Rebaseline needed after r117339
https://bugs.webkit.org/show_bug.cgi?id=89328
Unreviewed EFL gardening. Rebaseline a few tests after r117339.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-18
- platform/efl/TestExpectations:
- platform/efl/editing/pasteboard/innerText-inline-table-expected.png: Added.
- platform/efl/editing/pasteboard/innerText-inline-table-expected.txt: Added.
- platform/efl/editing/selection/iframe-expected.png: Added.
- platform/efl/editing/selection/iframe-expected.txt: Added.
- platform/efl/editing/selection/inline-table-expected.png: Added.
- platform/efl/editing/selection/inline-table-expected.txt: Added.
- platform/efl/editing/selection/table-caret-3-expected.png: Added.
- platform/efl/editing/selection/table-caret-3-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug2479-2-expected.txt:
- 12:12 AM Changeset in webkit [120575] by
-
- 22 edits4 adds in trunk/LayoutTests
[EFL] Rebaseline needed after r120477
https://bugs.webkit.org/show_bug.cgi?id=89325
Unreviewed EFL gardening. Rebaseline a few tests after r120477.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-18
- platform/efl/TestExpectations:
- platform/efl/editing/deleting/delete-3800834-fix-expected.png: Added.
- platform/efl/editing/deleting/delete-3800834-fix-expected.txt: Added.
- platform/efl/fast/dynamic/011-expected.png:
- platform/efl/fast/dynamic/011-expected.txt:
- platform/efl/fast/forms/formmove3-expected.png:
- platform/efl/fast/forms/formmove3-expected.txt:
- platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.png:
- platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/efl/fast/invalid/001-expected.png:
- platform/efl/fast/invalid/001-expected.txt:
- platform/efl/fast/invalid/003-expected.png:
- platform/efl/fast/invalid/003-expected.txt:
- platform/efl/fast/invalid/004-expected.png:
- platform/efl/fast/invalid/004-expected.txt:
- platform/efl/fast/invalid/007-expected.png:
- platform/efl/fast/invalid/007-expected.txt:
- platform/efl/fast/invalid/019-expected.png:
- platform/efl/fast/invalid/019-expected.txt:
- platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug647-expected.png:
- platform/efl/tables/mozilla/bugs/bug647-expected.txt:
- platform/efl/tables/mozilla/other/wa_table_tr_align-expected.png:
- platform/efl/tables/mozilla/other/wa_table_tr_align-expected.txt:
- 12:06 AM Changeset in webkit [120574] by
-
- 19 edits in trunk
XHR_RESPONSE_BLOB is not enabled on some platforms
https://bugs.webkit.org/show_bug.cgi?id=88859
Reviewed by Adam Barth.
Source/WebCore:
Removing XHR_RESPONSE_BLOB since the current implementation has
no platform-specific part.
Test: http/tests/xmlhttprequest/blob-response-size.html
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitChildren):
(WebCore::JSXMLHttpRequest::response):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseBlob):
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::clearResponseBuffers):
(WebCore::XMLHttpRequest::didReceiveData):
- xml/XMLHttpRequest.h:
(XMLHttpRequest):
- xml/XMLHttpRequest.idl:
Source/WebKit/chromium:
Removing XHR_RESPONSE_BLOB since the current implementation has
no platform-specific part.
- src/PlatformSupport.cpp:
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableXHRResponseBlob):
(WebKit::WebRuntimeFeatures::isXHRResponseBlobEnabled):
LayoutTests:
Removing xhr.Blob related test from Skipped files.
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
Jun 17, 2012:
- 11:43 PM Changeset in webkit [120573] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Add EFL baseline for fast/parser/nested-fragment-parser-crash.html
https://bugs.webkit.org/show_bug.cgi?id=89329
Unreviewed EFL gardening. Use the same expectation for
fast/parser/nested-fragment-parser-crash.html as mac.
The test is passing since it does not crash.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-17
- platform/efl/TestExpectations:
- platform/efl/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
- 11:36 PM Changeset in webkit [120572] by
-
- 4 edits in trunk/Source/WebCore
[TextureMapper] Reduce boilerplate code in the TextureMapperShaderManager
https://bugs.webkit.org/show_bug.cgi?id=89293
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-17
Reviewed by Noam Rosenthal.
Refactor TextureMapperShaderManager to reduce boilerplate code, by:
- Making fragment and shader source arguments to the superclass constructor.
- Removing virtual methods (which should not be called in constructors) with constructor implementations. This exchanges a small amount of code duplication for a lot less boilerplate.
- Standardizing on the fooLocation name instead of fooVariable.
- Removing the ::prepare() series of methods for non-filter shaders. It's betters to have all the uniform and attribute binding in the same place.
No new tests. This is just a refactor and shouldn't change any functionality.
- platform/graphics/texmap/TextureMapperGL.cpp:
Handle binding the mask texture and opacity at both of the previous ::prepare callsites. Also
rename "shaderInfo" to "program".
- platform/graphics/texmap/TextureMapperShaderManager.cpp: Perform the refactoring described above.
- platform/graphics/texmap/TextureMapperShaderManager.h: Ditto.
- 11:32 PM Changeset in webkit [120571] by
-
- 2 edits in trunk/Source/WebCore
Fix Framebuffer restrictions
https://bugs.webkit.org/show_bug.cgi?id=89320
Patch by Gregg Tavares <gman@google.com> on 2012-06-17
Reviewed by Kenneth Russell.
No new tests, just fixing old ones
- html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::checkStatus):
- 10:34 PM UsingGitWithWebKit edited by
- Add "Copying file aka svn copy" section (diff)
- 9:57 PM Changeset in webkit [120570] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, marking some tests as failures..
- platform/chromium/TestExpectations:
- 9:57 PM Changeset in webkit [120569] by
-
- 20 edits in trunk/Source/WebCore
[Forms] Move search field related code to RenderSearchField from RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=88980
Reviewed by Kent Tamura.
This patch moves search field related methods in RenderTextControlSingleLine
to new class RenderSearchField and changes related classes to use
RenderSearchField.
No new tests. This patch doesn't change behavior.
- CMakeLists.txt: Added new file RenderSearchField.cpp
- GNUmakefile.list.am: Added new file RenderSearchField.cpp and RenderSearchField.h
- Target.pri: ditto
- WebCore.gypi: ditto
- WebCore.vcproj/WebCore.vcproj: ditto
- WebCore.xcodeproj/project.pbxproj: ditto
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::subtreeHasChanged): Call RenderSearchField::updateCancelButtonVisibility
(WebCore::HTMLInputElement::addSearchResult): Changed to call InputType::addSearchResult.
- html/InputType.cpp:
(WebCore::InputType::addSearchResult): Added.
- html/InputType.h:
- html/SearchInputType.cpp:
(WebCore::SearchInputType::addSearchResult): Moved from HTMLInputElement.
(WebCore::SearchInputType::createRenderer): Added to create RenderSearchField.
(WebCore::SearchInputType::searchEventsShouldBeDispatched): Moved from HTMLInputElement.
(WebCore::SearchInputType::subtreeHasChanged) Moved search related code from HTMLInputElement.
- html/SearchInputType.h:
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler): Use RenderSearchField instead of RenderTextControlSingleLine.
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create): Got rid isSearchField() guard for addSearchResult().
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::RenderSearchField): Renamed to RenderSearchField.
(WebCore::RenderSearchField::~RenderSearchField): ditto
(WebCore::RenderSearchField::resultsButtonElement): ditto
(WebCore::RenderSearchField::cancelButtonElement): ditto
(WebCore::RenderSearchField::addSearchResult): ditto
(WebCore::RenderSearchField::showPopup): ditto
(WebCore::RenderSearchField::hidePopup): ditto
(WebCore::RenderSearchField::computeControlHeight): Added.
(WebCore::RenderSearchField::updateFromElement): Moved search field related code from RenderTextControlSingleLine.
(WebCore::RenderSearchField::updateCancelButtonVisibility): Renamed to RenderSearchField.
(WebCore::RenderSearchField::visibilityForCancelButton): ditto
(WebCore::RenderSearchField::autosaveName): ditto
(WebCore::RenderSearchField::valueChanged): ditto
(WebCore::RenderSearchField::itemText): ditto
(WebCore::RenderSearchField::itemLabel): ditto
(WebCore::RenderSearchField::itemIcon): ditto
(WebCore::RenderSearchField::itemIsEnabled): ditto
(WebCore::RenderSearchField::itemStyle): ditto
(WebCore::RenderSearchField::menuStyle): ditto
(WebCore::RenderSearchField::clientInsetLeft): ditto
(WebCore::RenderSearchField::clientInsetRight): ditto
(WebCore::RenderSearchField::clientPaddingLeft): ditto
(WebCore::RenderSearchField::clientPaddingRight): ditto
(WebCore::RenderSearchField::listSize): ditto
(WebCore::RenderSearchField::selectedIndex): ditto
(WebCore::RenderSearchField::popupDidHide): ditto
(WebCore::RenderSearchField::itemIsSeparator): ditto
(WebCore::RenderSearchField::itemIsLabel): ditto
(WebCore::RenderSearchField::itemIsSelected): ditto
(WebCore::RenderSearchField::setTextFromItem): ditto
(WebCore::RenderSearchField::fontSelector): ditto
(WebCore::RenderSearchField::hostWindow): ditto
(WebCore::RenderSearchField::createScrollbar): ditto
(WebCore::RenderSearchField::computeHeightLimit): Added.
(WebCore::RenderSearchField::centerContainerIfNeeded): Added.
- rendering/RenderSearchField.h:
(WebCore::toRenderSearchField): Added.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Remove search field related code.
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): ditto.
(WebCore::RenderTextControlSingleLine::computeHeightLimit): Added.
(WebCore::RenderTextControlSingleLine::layout): Use new methods for removing isSearchField.
(WebCore::RenderTextControlSingleLine::computeControlHeight): Added.
(WebCore::RenderTextControlSingleLine::updateFromElement): Remove search field related code.
- rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::centerContainerIfNeeded): Added.
(WebCore::RenderTextControlSingleLine::containerElement): Exposed for RenderSearchField.
(WebCore::RenderTextControlSingleLine::innerBlockElement): Exposed for RenderSearchField.
- rendering/RenderingAllInOne.cpp: Added RenderSearchField.cpp
- 9:35 PM Changeset in webkit [120568] by
-
- 6 edits in trunk/Source/JavaScriptCore
GC copy phase spends needless cycles zero-filling blocks
https://bugs.webkit.org/show_bug.cgi?id=89128
Reviewed by Gavin Barraclough.
We only need to zero-fill when we're allocating memory that might not
get fully initialized before GC.
- heap/CopiedBlock.h:
(JSC::CopiedBlock::createNoZeroFill):
(JSC::CopiedBlock::create): Added a way to create without zero-filling.
This is our optimization.
(JSC::CopiedBlock::zeroFillToEnd):
(JSC::CopiedBlock::CopiedBlock): Split zero-filling out from creation,
so we can sometimes create without zero-filling.
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::tryAllocateSlowCase):
(JSC::CopiedSpace::doneCopying): Renamed addNewBlock to allocateBlock()
to clarify that the new block is always newly-allocated.
(JSC::CopiedSpace::doneFillingBlock): Make sure to zero-fill to the end
of a block that might be used in the future for allocation. (Most of the
time, this is a no-op, since we've already filled the block completely.)
(JSC::CopiedSpace::getFreshBlock): Removed this function because the
abstraction of "allocation must succeed" is no longer useful.
- heap/CopiedSpace.h: Updated declarations to match.
- heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::allocateBlockForCopyingPhase): New function, which
knows that it can skip zero-filling.
Added tighter scoping to our lock, to improve parallelism.
(JSC::CopiedSpace::allocateBlock): Folded getFreshBlock functionality
into this function, for simplicity.
- heap/MarkStack.cpp:
(JSC::SlotVisitor::startCopying):
(JSC::SlotVisitor::allocateNewSpace): Use our new zero-fill-free helper
function for great good.
- 9:18 PM Changeset in webkit [120567] by
-
- 1 edit2 copies in trunk/Source/WebCore
[Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=89155
This patch copies RenderTextControlSingleLine.cpp and .h into RenderSearchField.cpp
and .h with just "cp" code. New files aren't compiled until bug 88980.
No new tests. This patch doesn't change behavior.
- rendering/RenderSearchField.cpp: Added. (WebCore): (WebCore::RenderTextControlInnerBlock::positionForPoint): (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::containerElement): (WebCore::RenderTextControlSingleLine::innerBlockElement): (WebCore::RenderTextControlSingleLine::innerSpinButtonElement): (WebCore::RenderTextControlSingleLine::resultsButtonElement): (WebCore::RenderTextControlSingleLine::cancelButtonElement): (WebCore::RenderTextControlSingleLine::textBaseStyle): (WebCore::RenderTextControlSingleLine::addSearchResult): (WebCore::RenderTextControlSingleLine::showPopup): (WebCore::RenderTextControlSingleLine::hidePopup): (WebCore::RenderTextControlSingleLine::paint): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::controlClipRect): (WebCore::RenderTextControlSingleLine::getAvgCharWidth): (WebCore::RenderTextControlSingleLine::preferredContentWidth): (WebCore::RenderTextControlSingleLine::computeControlHeight): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::createInnerBlockStyle): (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): (WebCore::RenderTextControlSingleLine::visibilityForCancelButton): (WebCore::RenderTextControlSingleLine::textShouldBeTruncated): (WebCore::RenderTextControlSingleLine::autosaveName): (WebCore::RenderTextControlSingleLine::valueChanged): (WebCore::RenderTextControlSingleLine::itemText): (WebCore::RenderTextControlSingleLine::itemLabel): (WebCore::RenderTextControlSingleLine::itemIcon): (WebCore::RenderTextControlSingleLine::itemIsEnabled): (WebCore::RenderTextControlSingleLine::itemStyle): (WebCore::RenderTextControlSingleLine::menuStyle): (WebCore::RenderTextControlSingleLine::clientInsetLeft): (WebCore::RenderTextControlSingleLine::clientInsetRight): (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight): (WebCore::RenderTextControlSingleLine::listSize): (WebCore::RenderTextControlSingleLine::selectedIndex): (WebCore::RenderTextControlSingleLine::popupDidHide): (WebCore::RenderTextControlSingleLine::itemIsSeparator): (WebCore::RenderTextControlSingleLine::itemIsLabel): (WebCore::RenderTextControlSingleLine::itemIsSelected): (WebCore::RenderTextControlSingleLine::setTextFromItem): (WebCore::RenderTextControlSingleLine::fontSelector): (WebCore::RenderTextControlSingleLine::hostWindow): (WebCore::RenderTextControlSingleLine::autoscroll): (WebCore::RenderTextControlSingleLine::scrollWidth): (WebCore::RenderTextControlSingleLine::scrollHeight): (WebCore::RenderTextControlSingleLine::scrollLeft): (WebCore::RenderTextControlSingleLine::scrollTop): (WebCore::RenderTextControlSingleLine::setScrollLeft): (WebCore::RenderTextControlSingleLine::setScrollTop): (WebCore::RenderTextControlSingleLine::scroll): (WebCore::RenderTextControlSingleLine::logicalScroll): (WebCore::RenderTextControlSingleLine::createScrollbar): (WebCore::RenderTextControlSingleLine::inputElement):
- rendering/RenderSearchField.h: Added. (WebCore): (RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::popupIsVisible): (WebCore::RenderTextControlSingleLine::isTextField): (WebCore::toRenderTextControlSingleLine): (RenderTextControlInnerBlock): (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
- 9:11 PM Changeset in webkit [120566] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r120565.
http://trac.webkit.org/changeset/120565
https://bugs.webkit.org/show_bug.cgi?id=89155
Bad commit message
- rendering/RenderSearchField.cpp: Removed.
- rendering/RenderSearchField.h: Removed.
- 9:08 PM Changeset in webkit [120565] by
-
- 1 edit2 copies in trunk/Source/WebCore
Try 1
- 7:43 PM Changeset in webkit [120564] by
-
- 4 edits in trunk/Source
Unreviewed build fix.
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
- 7:42 PM Changeset in webkit [120563] by
-
- 5 edits in trunk/Source/WebCore
[GStreamer] optimize ::naturalSize()
https://bugs.webkit.org/show_bug.cgi?id=89314
Reviewed by Martin Robinson.
Keep track of the video-sink sinkpad in the MediaPlayerPrivate and
adapt the webkitGstGetPadCaps API accordingly. The benefit of this
change is to reduce the number of calls to
gst_element_get_static_pad() and the corresponding gst_pad_unref().
- platform/graphics/gstreamer/GStreamerVersioning.cpp:
(webkitGstGetPadCaps):
- platform/graphics/gstreamer/GStreamerVersioning.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
- 7:35 PM Changeset in webkit [120562] by
-
- 2 edits in trunk
Unreviewed, GTK 64-bit build fix after r120551.
- Source/autotools/symbols.filter:
- 7:28 PM Changeset in webkit [120561] by
-
- 2 edits in trunk/Source/WebCore
Don't mark main frame layer opaque if the frame view is transparent
https://bugs.webkit.org/show_bug.cgi?id=88234
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-06-17
Reviewed by Simon Fraser.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
- 7:22 PM Changeset in webkit [120560] by
-
- 1 edit2 adds in trunk/LayoutTests
colspan in table-layout:fixed does not add up widths properly
https://bugs.webkit.org/show_bug.cgi?id=20213
Reviewed by Abhishek Arya.
The bug has been fixed (likely by bug 14858) so landing the test case as fixed table layout with cell spanning several
<col>'s with fixed widths is not properly covered.
- fast/table/fixed-table-layout/fixed-layout-column-colspan-wrong-size-expected.txt: Added.
- fast/table/fixed-table-layout/fixed-layout-column-colspan-wrong-size.html: Added.
- 7:12 PM Changeset in webkit [120559] by
-
- 3 edits2 adds in trunk
Prevent crash in SVGDocumentExtensions::removeAllElementReferencesForTarget.
https://bugs.webkit.org/show_bug.cgi?id=88144
Reviewed by Abhishek Arya.
Source/WebCore:
When iterating over referencing elements to rebuild after a reference change in
SVGDocumentExtensions::removeAllElementReferencesForTarget, we can
modify the underlying toBeNotified vector, invalidating it. This change checks
that a vector element is valid before rebuilding, preventing a crash.
Some definitions from SVGDocumentExtensions that may put this patch in context:
An example of a "referenced elements" is a <path>.
An example of a "referencing element" is a <textPath href='some_path_id'>.
m_elementDependencies is a map from referenced elements (e.g., paths) to
a set of referencing elements (e.g., textPaths).
The check that the vector element is valid relies on checking if the referencing
element is in m_elementDependencies. This check is allowed because in the
destructor of SVGTextPathElement (and SVGFeImageElement),
removeAllTargetReferencesForElement() is called, removing the referencing element
from m_elementDependencies.
Simply checking if the referencing element is anywhere in m_elementDependencies
is enough to show it is valid, but that requires iterating over all referenced
elements to see if the given referencing element is present. This change
only checks if the textPath is still in the elements referencing the
path being removed, and only removes the referenced element from
m_elementDependencies after forcing the referencing elements to be rebuilt.
Test: svg/text/textpath-reference-crash.html
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget):
LayoutTests:
- svg/text/textpath-reference-crash-expected.txt: Added.
- svg/text/textpath-reference-crash.html: Added.
- 7:09 PM Changeset in webkit [120558] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r120390.
http://trac.webkit.org/changeset/120390
https://bugs.webkit.org/show_bug.cgi?id=89155
Failed to copy merge history to RenderSerachField.{cpp,h}
- rendering/RenderSearchField.cpp: Removed.
- rendering/RenderSearchField.h: Removed.
- 7:06 PM Changeset in webkit [120557] by
-
- 20 edits in trunk/Source/WebCore
Unreviewed, rolling out r120432.
http://trac.webkit.org/changeset/120432
https://bugs.webkit.org/show_bug.cgi?id=88980
Failed to copy merge history to RenderSerachField.{cpp,h}
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::subtreeHasChanged):
(WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
(WebCore):
(WebCore::HTMLInputElement::addSearchResult):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
- html/InputType.h:
(InputType):
- html/SearchInputType.cpp:
- html/SearchInputType.h:
(SearchInputType):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- rendering/RenderSearchField.cpp:
(WebCore::RenderTextControlInnerBlock::positionForPoint):
(WebCore):
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::containerElement):
(WebCore::RenderTextControlSingleLine::innerBlockElement):
(WebCore::RenderTextControlSingleLine::innerSpinButtonElement):
(WebCore::RenderTextControlSingleLine::resultsButtonElement):
(WebCore::RenderTextControlSingleLine::cancelButtonElement):
(WebCore::RenderTextControlSingleLine::textBaseStyle):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::paint):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::styleDidChange):
(WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
(WebCore::RenderTextControlSingleLine::hasControlClip):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::getAvgCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::computeControlHeight):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
(WebCore::RenderTextControlSingleLine::autosaveName):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::itemText):
(WebCore::RenderTextControlSingleLine::itemLabel):
(WebCore::RenderTextControlSingleLine::itemIcon):
(WebCore::RenderTextControlSingleLine::itemIsEnabled):
(WebCore::RenderTextControlSingleLine::itemStyle):
(WebCore::RenderTextControlSingleLine::menuStyle):
(WebCore::RenderTextControlSingleLine::clientInsetLeft):
(WebCore::RenderTextControlSingleLine::clientInsetRight):
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
(WebCore::RenderTextControlSingleLine::listSize):
(WebCore::RenderTextControlSingleLine::selectedIndex):
(WebCore::RenderTextControlSingleLine::popupDidHide):
(WebCore::RenderTextControlSingleLine::itemIsSeparator):
(WebCore::RenderTextControlSingleLine::itemIsLabel):
(WebCore::RenderTextControlSingleLine::itemIsSelected):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::fontSelector):
(WebCore::RenderTextControlSingleLine::hostWindow):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):
(WebCore::RenderTextControlSingleLine::createScrollbar):
(WebCore::RenderTextControlSingleLine::inputElement):
- rendering/RenderSearchField.h:
(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::isTextField):
(WebCore::toRenderTextControlSingleLine):
(WebCore):
(RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore):
(WebCore::RenderTextControlSingleLine::containerElement):
(WebCore::RenderTextControlSingleLine::innerBlockElement):
(WebCore::RenderTextControlSingleLine::resultsButtonElement):
(WebCore::RenderTextControlSingleLine::cancelButtonElement):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::computeControlHeight):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::autosaveName):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::itemText):
(WebCore::RenderTextControlSingleLine::itemLabel):
(WebCore::RenderTextControlSingleLine::itemIcon):
(WebCore::RenderTextControlSingleLine::itemIsEnabled):
(WebCore::RenderTextControlSingleLine::itemStyle):
(WebCore::RenderTextControlSingleLine::menuStyle):
(WebCore::RenderTextControlSingleLine::clientInsetLeft):
(WebCore::RenderTextControlSingleLine::clientInsetRight):
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
(WebCore::RenderTextControlSingleLine::listSize):
(WebCore::RenderTextControlSingleLine::selectedIndex):
(WebCore::RenderTextControlSingleLine::popupDidHide):
(WebCore::RenderTextControlSingleLine::itemIsSeparator):
(WebCore::RenderTextControlSingleLine::itemIsLabel):
(WebCore::RenderTextControlSingleLine::itemIsSelected):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::fontSelector):
(WebCore::RenderTextControlSingleLine::hostWindow):
(WebCore::RenderTextControlSingleLine::createScrollbar):
- rendering/RenderTextControlSingleLine.h:
(WebCore):
(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::popupIsVisible):
- rendering/RenderingAllInOne.cpp:
- 6:59 PM Changeset in webkit [120556] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG should attempt to use structure watchpoints for all inlined get_by_id's and put_by_id's
https://bugs.webkit.org/show_bug.cgi?id=89316
Reviewed by Oliver Hunt.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addStructureTransitionCheck):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- 5:20 PM Changeset in webkit [120555] by
-
- 7 edits in trunk/Tools
garden-o-matic 'Results' panel is broken for the Apple platform
https://bugs.webkit.org/show_bug.cgi?id=89310
Reviewed by Adam Barth.
For platforms that don't use accumulated build directories on the server,
carry along buildLocation data with buildInfo, so that we know where to
look for the test results files for a given test.
Renamed historicalResultsSummaryURLs to historicalResultsLocations because
it now returns an array of objects with buildNumber, revision and url info.
Fixed results.fetchResultsURLs() to use this data to find results.
Fixed the results display to not scroll when you click on a test to see the results.
Made the h3s look less ugly
Don't try to show the flakiness dashboard for the Apple platform.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
(.results-view .top-panel):
(.results-view h3):
- 4:06 PM Changeset in webkit [120554] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r111041): Missing element type check in RenderThemeMac::paintMediaFullscreenButton
https://bugs.webkit.org/show_bug.cgi?id=89270
Reviewed by Oliver Hunt.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaFullscreenButton): Use the proper idiom for getting
a media control element's type.
- 2:19 PM Changeset in webkit [120553] by
-
- 13 edits in trunk/Source
[Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged
https://bugs.webkit.org/show_bug.cgi?id=88482
Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-17
Reviewed by Adrienne Walker.
Source/WebCore:
Post-processing CCRenderPassList after it's been generated and
removing all render surface quads for which there are
cached textures, and whose content didn't change. Added a new
flag to CCLayerImpl to differentiate surface property change and
layer property change.
The changes are covered by new unit tests that check that
the removal algorithm functions propertly. No rendering
behaviour change, so no new layout tests.
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::layerNeedsToRedrawOntoItsTargetSurface):
(WebCore):
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::layerSurfacePropertyChanged):
(WebCore):
(WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setTransform):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::removeRenderPassesRecursive):
(WebCore):
(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(FrameData):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::hasCachedContentsTexture):
(WebCore):
(WebCore::CCRenderSurface::contentsChanged):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
Added tests to verify quad removal algorithm. Added infrastructure
code to generate custom render passes out of a script encoded as C
string.
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
- tests/CCLayerImplTest.cpp:
(WebCore):
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
- 2:06 PM Changeset in webkit [120552] by
-
- 2 edits in trunk/Source/WTF
[WIN] Simplify implementation of currentTime()
https://bugs.webkit.org/show_bug.cgi?id=83156
Reviewed by Brent Fulgham.
Use GetSystemTimeAsFileTime() instead of ftime().
This avoids an unneeded call to the MS CRT and
brings the Win/WinCE code closer together.
- wtf/CurrentTime.cpp:
(WTF::lowResUTCTime):
(WTF::currentTime):
- 11:36 AM Changeset in webkit [120551] by
-
- 2 edits in trunk
Unreviewed, GTK build fix after r120397.
- Source/autotools/symbols.filter:
- 4:15 AM Changeset in webkit [120550] by
-
- 5 edits in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines after r120541.
- platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
- platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
- platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
- platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:
- 3:16 AM Changeset in webkit [120549] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=89302
Unreviewed EFL gardening. Skip flaky test.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-17
- platform/efl/TestExpectations:
- 1:34 AM Changeset in webkit [120548] by
-
- 3 edits in trunk/Source/WebCore
Attempt to fix a large number of tests I broke with http://trac.webkit.org/changeset/120547
We need to reset the device scale facter after each test.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
- testing/InternalSettings.h:
(InternalSettings):
- 12:01 AM Changeset in webkit [120547] by
-
- 5 edits in trunk/LayoutTests
Update a few more tests to use internals.settings.setDeviceScaleFactor.
- compositing/tiled-layers-hidpi.html:
- fast/canvas/2d.backingStorePixelRatio.html:
- fast/canvas/2d.imageDataHD.html:
- platform/mac-wk2/plugins/contents-scale-factor.html:
Jun 16, 2012:
- 9:53 PM Changeset in webkit [120546] by
-
- 18 edits in trunk/Tools
Make garden-o-matic work for the Apple Mac port
https://bugs.webkit.org/show_bug.cgi?id=84642
Reviewed by Adam Barth.
Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
educating the scripts in various ways:
- Wrap up platform-related differences in config.kPlatforms[]
- Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
- The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do, so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most recent build with valid results.
- The webkit.org bots often generate results directories with no layout test data (e.g. when testers try to test a build that has already been deleted). Make walkHistory() more robust here.
- webkit.org uses differently named test result directories, that include the SVN revision as well as the build number. That forces us to fetch more build info before we can get the result directory URL.
- chromium.org serves raw directory listings for a builder's results directories. webkit.org serves those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results dirs.
- Various URLs differ between webkit.org and chromium.org
- Better UI for the failures info, so that some info is visible even when not hovered.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
(LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
(ol.notifications>li table.failures):
(ol.notifications>li:hover table.failures):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
(#onebar #platform-picker):
- Scripts/webkitpy/layout_tests/port/builders.py:
- 9:42 PM Changeset in webkit [120545] by
-
- 3 edits in trunk/Source/WebCore
[Texmap] Share gaussian formula between shaders in TextureMapperShaderManager.
https://bugs.webkit.org/show_bug.cgi?id=89277
This patch makes blur and drop shadow shader share gaussian formula.
On the other hand, blur and drop shadow filter computed a gaussian weight in
pixel shader. However, a gaussian kernal has always same values, so this patch
computes the gaussian kernel only one time using CPU.
It is more accurate and faster.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-16
Reviewed by Noam Rosenthal.
Covered by existing tests, particularly css3/filters/.
- platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore):
(WebCore::StandardFilterProgram::StandardFilterProgram):
(WebCore::gauss):
(WebCore::gaussianKernel):
(WebCore::StandardFilterProgram::prepare):
- platform/graphics/texmap/TextureMapperShaderManager.h:
- 8:55 PM Changeset in webkit [120544] by
-
- 11 edits in trunk/Source
[chromium] Make the deviceScaleFactor dynamically adjustable.
https://bugs.webkit.org/show_bug.cgi?id=88916
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebLayerTreeView.h: Plumb setDeviceScaleFactor and
deviceScaleFactor functions.
(WebKit::WebLayerTreeView::Settings::Settings): Remove deviceScaleFactor from
settings as it is now dynamic.
(Settings):
(WebLayerTreeView):
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed use of static
deviceScaleFactor from settings with dyanmic m_deviceScaleFactor
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::setDeviceScaleFactor): Added function to
set deviceScaleFactor.
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings): Removed static deviceScaleFactor
(CCSettings):
(CCLayerTreeHost): Added dynamic m_deviceScaleFactor in its place.
(WebCore::CCLayerTreeHost::deviceScaleFactor):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Same as above.
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
(WebCore::CCLayerTreeHostImpl::setDeviceScaleFactor): Added function to
set deviceScaleFactor.
(WebCore):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Added dynamic
m_deviceScaleFactor instance variable.
(WebCore::CCLayerTreeHostImpl::deviceScaleFactor):
(CCLayerTreeHostImpl):
Source/WebKit/chromium:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings): Removed unused
static deviceScaleFactor.
(WebKit::WebLayerTreeView::setDeviceScaleFactor):
(WebKit):
(WebKit::WebLayerTreeView::deviceScaleFactor):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setDeviceScaleFactor): Push the dynamic deviceScaleFactor
to the compositor as required.
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- tests/CCLayerTreeHostTest.cpp: Tests use dynamic setDeviceScaleFactor.
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::beginTest):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
- 6:05 PM Changeset in webkit [120543] by
-
- 9 edits2 moves in trunk
Unreviewed, rolling out r120536.
http://trac.webkit.org/changeset/120536
https://bugs.webkit.org/show_bug.cgi?id=89296
Does not compile on chromium-linux (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-16
Source/WebCore:
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore):
(WebCore::FontPlatformData::setHinting):
(WebCore::FontPlatformData::setAutoHint):
(WebCore::FontPlatformData::setUseBitmaps):
(WebCore::FontPlatformData::setAntiAlias):
(WebCore::FontPlatformData::setSubpixelRendering):
(WebCore::FontPlatformData::setSubpixelPositioning):
(WebCore::FontPlatformData::setupPaint):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):
Source/WebKit/chromium:
- WebKit.gyp:
- public/linux/WebFontRendering.h:
- public/linuxish/WebFontRendering.h: Renamed from Source/WebKit/chromium/public/WebFontRendering.h.
(WebKit):
(WebFontRendering):
- src/linuxish/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/WebFontRendering.cpp.
(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::setLCDOrder):
(WebKit::WebFontRendering::setLCDOrientation):
Tools:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):
- DumpRenderTree/chromium/TestShellAndroid.cpp:
- 6:01 PM Changeset in webkit [120542] by
-
- 13 edits in trunk/Source
Unreviewed, rolling out r120539.
http://trac.webkit.org/changeset/120539
https://bugs.webkit.org/show_bug.cgi?id=89295
Does not compile on chromium-mac (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-16
Source/WebCore:
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setTransform):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::prepareContentsTexture):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
- tests/CCLayerImplTest.cpp:
(WebCore):
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
- 5:39 PM Changeset in webkit [120541] by
-
- 34 edits in trunk
layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=89274
Reviewed by Levi Weintraub.
Tools:
Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
Note: The WebKit2 API that setBackingScaleFactor exercises is still
tested by API-level tests.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
LayoutTests:
We don't need both layoutTestController.setBackingScaleFactor and
internals.settings.setDeviceScaleFactor because they do exactly the
same thing. This patch removes setBackingScaleFactor because it's
async nature is annoying and implementing it requires a bunch of
port-specific code.
- fast/hidpi/broken-image-icon-hidpi.html:
- fast/hidpi/broken-image-with-size-hidpi.html:
- fast/hidpi/clip-text-in-hidpi.html:
- fast/hidpi/focus-rings.html:
- fast/hidpi/image-set-as-background.html:
- fast/hidpi/image-set-background-dynamic.html:
- fast/hidpi/image-set-background-repeat-without-size.html:
- fast/hidpi/image-set-background-repeat.html:
- fast/hidpi/image-set-border-image-comparison.html:
- fast/hidpi/image-set-border-image-dynamic.html:
- fast/hidpi/image-set-border-image-simple.html:
- fast/hidpi/image-set-in-content-dynamic.html:
- fast/hidpi/image-set-out-of-order.html:
- fast/hidpi/image-set-simple.html:
- fast/hidpi/image-set-without-specified-width.html:
- fast/hidpi/resize-corner-hidpi.html:
- fast/hidpi/video-controls-in-hidpi.html:
- svg/as-image/image-respects-deviceScaleFactor.html:
- 5:35 PM Changeset in webkit [120540] by
-
- 3 edits4 adds in trunk
Ignore paths in Content Security Policy sources rather than failing to parse them.
https://bugs.webkit.org/show_bug.cgi?id=89281
Patch by Mike West <mkwst@chromium.org> on 2012-06-16
Reviewed by Adam Barth.
Source/WebCore:
In short:
script-src http://example.com/should allow scripts from
http://example.com. Currently, it allows no scripts at all, as the
terminal/isn't accepted as part of a hostname.
This patch adjusts CSPSourceList::parseSource to accept paths (and
discard them). Once this lands, the next step will be to keep the
path, and use it when comparing source origins in the various
allowXXXFromSource methods.
Tests: http/tests/security/contentSecurityPolicy/source-list-parsing-05.html
http/tests/security/contentSecurityPolicy/source-list-parsing-06.html
- page/ContentSecurityPolicy.cpp:
(CSPSourceList):
(WebCore):
(WebCore::CSPSourceList::parseSource):
Reworked this method entirely to support paths.
(WebCore::CSPSourceList::parsePath):
More or less a no-op at the moment.
(WebCore::CSPSourceList::parsePort):
Moved the
:assertion here from parseSource.
LayoutTests:
- http/tests/security/contentSecurityPolicy/source-list-parsing-05-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-05.html: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-06-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-06.html: Added.
- 5:26 PM Changeset in webkit [120539] by
-
- 13 edits in trunk/Source
[Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged
https://bugs.webkit.org/show_bug.cgi?id=88482
Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-16
Reviewed by Adrienne Walker.
Source/WebCore:
Post-processing CCRenderPassList after it's been generated and
removing all render surface quads for which there are
cached textures, and whose content didn't change. Added a new
flag to CCLayerImpl to differentiate surface property change and
layer property change.
The changes are covered by new unit tests that check that
the removal algorithm functions propertly. No rendering
behaviour change, so no new layout tests.
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::layerNeedsToRedrawOntoItsTargetSurface):
(WebCore):
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::layerSurfacePropertyChanged):
(WebCore):
(WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setTransform):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::removeRenderPassesRecursive):
(WebCore):
(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(FrameData):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::hasCachedContentsTexture):
(WebCore):
(WebCore::CCRenderSurface::contentsChanged):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
Added tests to verify quad removal algorithm. Added infrastructure
code to generate custom render passes out of a script
encoded as C string.
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
- tests/CCLayerImplTest.cpp:
(WebCore):
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
- 5:17 PM Changeset in webkit [120538] by
-
- 3 edits in trunk/LayoutTests
Fix test cases for
header/footerAXRoleDescription
https://bugs.webkit.org/show_bug.cgi?id=88911
The relative URLs to js-test-pre.js and js-test-post.js were incorrect.
Patch by Mike West <mkwst@chromium.org> on 2012-06-16
Reviewed by Simon Fraser.
- platform/mac/accessibility/footer.html:
- platform/mac/accessibility/header.html:
- 5:13 PM Changeset in webkit [120537] by
-
- 5 edits in trunk/LayoutTests
[EFL] Rebaseline fast/lists/001*.html tests after r120495
https://bugs.webkit.org/show_bug.cgi?id=89283
Unreviewed EFL gardening after r120495.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-16
- platform/efl/fast/lists/001-expected.png:
- platform/efl/fast/lists/001-expected.txt:
- platform/efl/fast/lists/001-vertical-expected.png:
- platform/efl/fast/lists/001-vertical-expected.txt:
- 4:28 PM Changeset in webkit [120536] by
-
- 9 edits2 moves in trunk
[Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
https://bugs.webkit.org/show_bug.cgi?id=89228
Source/WebCore:
Reverse the dependency originally from WebKit::WebFontRendering to WebCore::FontPlatformDataHarfBuzz
so that WebKit::WebFontRendering can be platform-independent.
Reviewed by Tony Chang.
Refactory only. No new tests.
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::setupPaint):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):
Source/WebKit/chromium:
Reverse dependency originally from WebCore::FontPlatformDataHarfBuzz to WebKit::WebFontRendering
so that WebKit::WebFontRendering can be platform-independent.
This also avoids the ambiguous name 'linuxish'.
Reviewed by Tony Chang.
- WebKit.gyp:
- public/WebFontRendering.h: Copied from Source/WebKit/chromium/public/linuxish/WebFontRendering.h. Added getters under WEBKIT_IMPLEMENTATION.
(WebFontRendering):
- public/linux/WebFontRendering.h:
- public/linuxish: Removed.
- public/linuxish/WebFontRendering.h: Removed.
- src/WebFontRendering.cpp: Copied from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. Changed setters to be independent of platform-dependent implementation and added getters.
(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::hinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::autoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::useBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::antiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::subpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::subpixelPositioning):
- src/linuxish: Removed.
- src/linuxish/WebFontRendering.cpp: Removed.
Tools:
Reviewed by Tony Chang.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):
- DumpRenderTree/chromium/TestShellAndroid.cpp:
- 4:01 PM WebKit Team edited by
- Changed affiliation (diff)
- 3:59 PM Changeset in webkit [120535] by
-
- 22 edits in trunk/LayoutTests
[EFL] Rebaseline MathML tests after r120492
https://bugs.webkit.org/show_bug.cgi?id=89282
Unreviewed EFL gardening. Several MathML tests needed
rebaselining after r120492.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-16
- platform/efl/mathml/presentation/attributes-expected.txt:
- platform/efl/mathml/presentation/fenced-expected.txt:
- platform/efl/mathml/presentation/fenced-mi-expected.txt:
- platform/efl/mathml/presentation/fractions-expected.txt:
- platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/efl/mathml/presentation/mo-stretch-expected.txt:
- platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
- platform/efl/mathml/presentation/roots-expected.txt:
- platform/efl/mathml/presentation/row-alignment-expected.png:
- platform/efl/mathml/presentation/row-alignment-expected.txt:
- platform/efl/mathml/presentation/sub-expected.txt:
- platform/efl/mathml/presentation/subsup-expected.txt:
- platform/efl/mathml/presentation/sup-expected.txt:
- platform/efl/mathml/presentation/tables-expected.txt:
- platform/efl/mathml/presentation/tokenElements-expected.txt:
- platform/efl/mathml/presentation/under-expected.png:
- platform/efl/mathml/presentation/under-expected.txt:
- platform/efl/mathml/presentation/underover-expected.png:
- platform/efl/mathml/presentation/underover-expected.txt:
- platform/efl/mathml/xHeight-expected.png:
- platform/efl/mathml/xHeight-expected.txt:
- 3:35 PM Changeset in webkit [120534] by
-
- 7 edits in trunk/Source
Settings::devicePixelRatio doesn't do anything and is confusing
https://bugs.webkit.org/show_bug.cgi?id=89272
Reviewed by James Robinson.
Source/WebCore:
Settings::devicePixelRatio is yet another piece of state trying to
represent the device scale factor. The canonical place to store this
state is Page::m_deviceScaleFactor. Nothing in WebCore references
Settings::devicePixelRatio anymore, so we can remove it.
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(Settings):
Source/WebKit2:
- Shared/WebPreferencesStore.h:
(WebKit):
- Remove boilerplate code for the setting.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::devicePixelRatio):
(QQuickWebViewExperimental::setDevicePixelRatio):
- Change these functions to get and set the real device scale factor.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
- Use the real device scale factor for the viewport calculation.
(WebKit::WebPage::updatePreferences):
- Remove boilerplate code for the setting.
- 3:22 PM Changeset in webkit [120533] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] SIGSEV in WebCore::TextureMapperGL::drawTexture.
https://bugs.webkit.org/show_bug.cgi?id=89113
TextureMapperTile::m_texture is created lazilly, so we need null check before
using it.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-16
Reviewed by Noam Rosenthal.
No new tests. This patch doesn't change behavior.
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperTile::paint):
- 3:17 PM Changeset in webkit [120532] by
-
- 5 edits in trunk/Source/WebCore
[Texmap] Remove unused code in Texmap.
https://bugs.webkit.org/show_bug.cgi?id=89265
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-16
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::didSynchronize):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::syncCompositingState):
- platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
- 3:10 PM Changeset in webkit [120531] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-16
- DEPS:
- 1:00 PM Changeset in webkit [120530] by
-
- 12 edits2 adds9 deletes in trunk/LayoutTests
Remove a bunch of 32-bit specific results. These results are the same
on 64 bit.
- platform/chromium-linux-x86/compositing/color-matching: Removed.
- platform/chromium-linux-x86/compositing/color-matching/image-color-matching-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/crash-hw-sw-switch-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/custom: Removed.
- platform/chromium-linux-x86/css3/filters/custom/custom-filter-shader-cache-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/custom/effect-custom-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/custom/missing-custom-filter-shader-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-blur-hw-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-brightness-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-brightness-hw-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-contrast-hw-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
- platform/chromium-linux-x86/fast/images: Removed.
- platform/chromium-linux-x86/fast/images/jpeg-with-color-profile-expected.png: Removed.
- platform/chromium-linux-x86/fast/images/png-with-color-profile-expected.png: Removed.
- platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
- platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
- platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
- platform/chromium-linux/css3/filters/custom/missing-custom-filter-shader-expected.png:
- platform/chromium-linux/css3/filters/effect-blur-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-drop-shadow-hw-expected.png:
- platform/chromium-linux/fast/images/jpeg-with-color-profile-expected.png: Added.
- platform/chromium-linux/fast/images/png-with-color-profile-expected.png: Added.
- 12:53 PM Changeset in webkit [120529] by
-
- 61 edits19 adds27 deletes in trunk/LayoutTests
Update baselines after http://trac.webkit.org/changeset/120485
- platform/chromium-linux-x86/http/tests/local: Removed.
- platform/chromium-linux-x86/http/tests/local/file-url-sent-as-referer-expected.png: Removed.
- platform/chromium-linux-x86/scrollbars: Removed.
- platform/chromium-linux-x86/scrollbars/listbox-scrollbar-combinations-expected.png: Removed.
- platform/chromium-linux-x86/scrollbars/overflow-scrollbar-combinations-expected.png: Removed.
- platform/chromium-linux-x86/svg/as-border-image: Removed.
- platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/createImageElement-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/createImageElement2-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/focus-ring-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/group-opacity-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/image-parent-translation-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/js-update-image-and-display-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/js-update-image-and-display2-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/js-update-image-and-display3-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/js-update-image-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/text-image-opacity-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/feImage-subregions-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/filter-source-position-expected.png: Removed.
- platform/chromium-linux-x86/svg/repaint: Removed.
- platform/chromium-linux-x86/svg/repaint/image-href-change-expected.png: Removed.
- platform/chromium-linux-x86/svg/transforms/animated-path-inside-transformed-html-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
- platform/chromium-linux/http/tests/local/file-url-sent-as-referer-expected.png:
- platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.png:
- platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-linux/svg/custom/createImageElement2-expected.png:
- platform/chromium-linux/svg/custom/focus-ring-expected.png:
- platform/chromium-linux/svg/custom/image-parent-translation-expected.png:
- platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
- platform/chromium-linux/svg/custom/text-image-opacity-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-win-vista/http/tests/local: Removed.
- platform/chromium-win-vista/svg/dynamic-updates: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
- platform/chromium-win-xp/svg/dynamic-updates: Removed.
- platform/chromium-win/http/tests/local/file-url-sent-as-referer-expected.png:
- platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.png:
- platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/custom/createImageElement-expected.png:
- platform/chromium-win/svg/custom/createImageElement2-expected.png:
- platform/chromium-win/svg/custom/focus-ring-expected.png:
- platform/chromium-win/svg/custom/group-opacity-expected.png:
- platform/chromium-win/svg/custom/image-parent-translation-expected.png:
- platform/chromium-win/svg/custom/image-small-width-height-expected.png:
- platform/chromium-win/svg/custom/js-update-image-and-display-expected.png:
- platform/chromium-win/svg/custom/js-update-image-and-display2-expected.png:
- platform/chromium-win/svg/custom/js-update-image-and-display3-expected.png:
- platform/chromium-win/svg/custom/js-update-image-expected.png:
- platform/chromium-win/svg/custom/text-image-opacity-expected.png:
- platform/chromium-win/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium-win/svg/filters/feImage-subregions-expected.png:
- platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
- platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
- platform/chromium-win/svg/filters/filter-source-position-expected.png:
- platform/chromium-win/svg/repaint/image-href-change-expected.png:
- platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- 9:48 AM Changeset in webkit [120528] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines
after r120492 and r120495.
- platform/gtk/fast/lists/001-expected.txt:
- platform/gtk/fast/lists/001-vertical-expected.txt:
- platform/gtk/mathml/xHeight-expected.txt:
- 9:16 AM Changeset in webkit [120527] by
-
- 2 edits in trunk/Source/WebCore
[TexmapGL] Reduce the number of glTexSubImage2D calls
https://bugs.webkit.org/show_bug.cgi?id=83665
Instead of copy the pixels row by row, put the pixels in a buffer and
call glTexSubImage2D just once.
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
- 2:21 AM Changeset in webkit [120526] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] WebFrameClient::userAgentOverride() should take in a WebFrame* as its first argument
https://bugs.webkit.org/show_bug.cgi?id=89233
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-06-16
Reviewed by Darin Fisher.
Adds a WebFrame* to the WebFrameClient::userAgentOverride() function.
- public/WebFrameClient.h:
(WebKit::WebFrameClient::userAgentOverride):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::userAgent):
- tests/FrameLoaderClientImplTest.cpp:
- 1:42 AM Changeset in webkit [120525] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip a new failing test.
- platform/qt-5.0-wk2/Skipped:
- 1:34 AM Changeset in webkit [120524] by
-
- 9 edits1 add in trunk/LayoutTests
[Qt] Unreviewed weekend gardening.
- platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.png: Updated after after r120411.
- platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.txt: Updated after after r120411.
- platform/qt-5.0/fast/forms/box-shadow-override-expected.png: Updated after after r120411.
- platform/qt-5.0/fast/forms/box-shadow-override-expected.txt: Updated after after r120411.
- platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Updated after r120495.
- platform/qt/fast/lists/001-expected.png: Updated after r120495.
- platform/qt/fast/lists/001-expected.txt: Updated after r120495.
- platform/qt/fast/lists/001-vertical-expected.png: Updated after r120495.
- platform/qt/fast/lists/001-vertical-expected.txt: Updated after r120495.
