Timeline
Jul 5, 2012:
- 11:27 PM Changeset in webkit [121945] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Showing the context menu in the Web Inspector can crash the browser
https://bugs.webkit.org/show_bug.cgi?id=88800
Patch by Arnaud Renevier <arno@renevier.net> on 2012-07-05
Reviewed by Carlos Garcia Campos.
Remove ContextMenuItem from its parent before appending it again to a
new parent
No new tests, behavior is unchanged.
- platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::appendItem):
- 11:07 PM Changeset in webkit [121944] by
-
- 5 edits in trunk/Source/WebKit2
[WK2][EFL] Ewk_View needs to report load status changes
https://bugs.webkit.org/show_bug.cgi?id=90566
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.
Add new "load,finished", "load,provisional,failed",
"load,provisional,redirect" and "load,provisional,started"
signals on the Ewk_View to notify the client of different
load state changes.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_load_finished):
(ewk_view_load_provisional_failed):
(ewk_view_load_provisional_redirect):
(ewk_view_load_provisional_started):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_loader_client.cpp:
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(ewk_view_loader_client_attach):
- UIProcess/API/efl/ewk_view_private.h:
- 9:52 PM Changeset in webkit [121943] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Unreviewed 64 bit buildfix after r121925.
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
- 9:31 PM Changeset in webkit [121942] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Transform should be applied to the clip rect in QRawWebView::paint
https://bugs.webkit.org/show_bug.cgi?id=90652
Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.
Applying the transformation matrix to the clip rect in QRawWebView::paint.
- UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::paint):
- 9:25 PM Changeset in webkit [121941] by
-
- 2 edits in trunk/Tools
Add Jason Liu to committers.py.
https://bugs.webkit.org/show_bug.cgi?id=90654
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 9:09 PM Changeset in webkit [121940] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed Chromium gardening. Roll Chromium DEPS
- DEPS: 145501 => 145569
- 8:57 PM Changeset in webkit [121939] by
-
- 12 edits2 deletes in trunk/LayoutTests
Unreviewed Chromium gardening - Rebaseline for r121917.
- platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac/fast/html/details-marker-style-expected.png:
- platform/chromium-mac/fast/html/details-marker-style-expected.txt:
- platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/chromium-win/fast/html/details-marker-style-expected.png:
- platform/chromium-win/fast/html/details-marker-style-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- 8:47 PM Changeset in webkit [121938] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Unreviewed, Fix build break when WEB_AUDIO is enabled.
https://bugs.webkit.org/show_bug.cgi?id=90653
Unreviewed build fix.
A new file, AudioFIFO.cpp, is added for the Web Audio fearure.
This file should be included into the CMakeLists.txt file.
Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-05
- CMakeLists.txt: Add the newly created file into the CMakeLists.txt
- 8:33 PM Changeset in webkit [121937] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed Chromium gardening - Disable WebAnimationTest for Linux and Windows.
https://bugs.webkit.org/show_bug.cgi?id=90651
- tests/WebAnimationTest.cpp:
(WebKit):
(WebKit::TEST):
- 7:50 PM Changeset in webkit [121936] by
-
- 3 edits3 adds in trunk
Multiple Content Security Policy headers are correctly processed as separate headers.
https://bugs.webkit.org/show_bug.cgi?id=90629
Source/WebCore:
Headers of the same name are normalized into a single, comma-separated
string as per RFC2616, section 4.2. We didn't correctly account for this
in ContentSecurityPolicy::didReceiveHeader. Now we do by walking through
the header string, looking for commas and processing each block in turn.
This oversight bit Firefox as well, and was patched in February:
https://bugzilla.mozilla.org/show_bug.cgi?id=717511
Patch by Mike West <mkwst@chromium.org> on 2012-07-05
Reviewed by Adam Barth.
Test: http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
LayoutTests:
Patch by Mike West <mkwst@chromium.org> on 2012-07-05
Reviewed by Adam Barth.
- http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html: Added.
- http/tests/security/contentSecurityPolicy/resources/echo-multiple-headers.pl: Added.
- 6:55 PM Changeset in webkit [121935] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skipping failing tests.
- platform/mac/Skipped:
- 6:47 PM Changeset in webkit [121934] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][EFL] Ewk_View should provide API to set/get device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=90590
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.
Add API to Ewk_View so retrieve and set the device
pixel ratio.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
- UIProcess/API/efl/ewk_view.h:
- 6:27 PM Changeset in webkit [121933] by
-
- 6 edits in trunk
Unreviewed, rolling out r121921.
http://trac.webkit.org/changeset/121921
https://bugs.webkit.org/show_bug.cgi?id=90648
caused hundreds of crashes on Mac (Requested by pizlo on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-05
Source/WebCore:
- editing/SurroundingText.cpp:
(WebCore::SurroundingText::SurroundingText):
- editing/TextIterator.cpp:
(WebCore::CharacterIterator::advance):
(WebCore::BackwardsCharacterIterator::advance):
LayoutTests:
- platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
- platform/chromium/editing/surrounding-text/surrounding-text.html:
- 6:24 PM Changeset in webkit [121932] by
-
- 4 edits in trunk/Source
Type-ahead doesn't work in options inside optgroups
https://bugs.webkit.org/show_bug.cgi?id=90647
<rdar://problem/5604894>
Reviewed by Dan Bernstein.
Set the title of the menu item to a string that doesn't contain any leading or trailing whitespace.
Source/WebCore:
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenuMac::populate):
Source/WebKit2:
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::populate):
- 6:05 PM Changeset in webkit [121931] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix the build error introduced by enabling CUSTOM_THEME_HANDLER
https://bugs.webkit.org/show_bug.cgi?id=90588
Reviewed by Rob Buis.
Fix the build error introduced by enabling CUSTOM_THEME_HANDLER.
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
- 5:26 PM Changeset in webkit [121930] by
-
- 3 edits2 adds in trunk
t/fuzzer-mouse-crash
<patch description>
- 5:20 PM Changeset in webkit [121929] by
-
- 4 edits2 adds in trunk
Double release of resources if the load is canceled in a callback of ResourceLoader::didFinishLoading
https://bugs.webkit.org/show_bug.cgi?id=90431
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-05
Reviewed by Anders Carlsson.
Source/WebCore:
In ResourceLoader::didFinishLoadingOnePart(), we invoke didFinishLoad() on the WebKit client. If WebKit
causes the current frame to cancel the load synchronously, the resources are already freed when
ResourceLoader::didFinishLoadingOnePart() ends.
When ResourceLoader::didFinishLoading() subsequently invokes releaseResources(), we are releasing the
resources a second time.
This patch add a second check for cancellation after invoking ResourceLoader::didFinishLoadingOnePart() to
avoid such issues.
The previous check at the beginning of ResourceLoader::didFinishLoading() has been removed because it is
redundant with ResourceLoader::didFinishLoadingOnePart().
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFinishLoadingOnePart):
Tools:
Add a Mac API test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html: Added.
- TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm: Added.
(-[CancelLoadFromResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[CancelLoadFromResourceLoadDelegateFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- 5:04 PM Changeset in webkit [121928] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSString::tryHashConstLock() fails to get exclusive lock
https://bugs.webkit.org/show_bug.cgi?id=90639
Reviewed by Oliver Hunt.
Added check that the string is already locked even before compare and swap.
- heap/MarkStack.cpp:
(JSC::JSString::tryHashConstLock):
- 4:31 PM Changeset in webkit [121927] by
-
- 2 edits in trunk/Source/WTF
INLINE_ARM_FUNCTION(thingy) should make thingy be thumb2 if we're using thumb2
https://bugs.webkit.org/show_bug.cgi?id=90644
Reviewed by Mark Hahnenberg.
Fix breakage introduced in http://trac.webkit.org/changeset/121885
- wtf/InlineASM.h:
- 4:14 PM Changeset in webkit [121926] by
-
- 4 edits in trunk/Source/WebCore
Add a utility method for hasOverflowClip() or hasClip()
https://bugs.webkit.org/show_bug.cgi?id=90635
Reviewed by Dean Jackson.
Add RenderObject::hasClipOrOverflowClip() as a convenience method
since we end up calling hasOverfFlowClip() hasClip() a lot in the layer code. No new tests; refactoring only.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::calculateRects):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer):
(WebCore::RenderLayerCompositor::clipsCompositingDescendants):
- rendering/RenderObject.h:
(WebCore::RenderObject::hasClipOrOverflowClip):
- 3:55 PM Changeset in webkit [121925] by
-
- 61 edits1 add in trunk/Source/JavaScriptCore
Inline property storage should not be wasted when it is exhausted
https://bugs.webkit.org/show_bug.cgi?id=90347
Reviewed by Gavin Barraclough.
Previously, if we switched an object from using inline storage to out-of-line
storage, we would abandon the inline storage. This would have two main implications:
(i) all accesses to the object, even for properties that were previously in inline
storage, must now take an extra indirection; and (ii) we waste a non-trivial amount
of space since we must allocate additional out-of-line storage to hold properties
that would have fit in the inline storage. There's also the copying cost when
switching to out-of-line storage - we must copy all inline properties into ouf-of-line
storage.
This patch changes the way that object property storage works so that we can use both
inline and out-of-line storage concurrently. This is accomplished by introducing a
new notion of property offset. This PropertyOffset is a 32-bit signed integer and it
behaves as follows:
offset == -1: invalid offset, indicating a property that does not exist.
0 <= offset <= inlineStorageCapacity: offset into inline storage.
inlineStorageCapacity < offset: offset into out-of-line storage.
Because non-final objects don't have inline storage, the only valid PropertyOffsets
for those objects' properties are -1 or > inlineStorageCapacity.
This now means that the decision to use inline or out-of-line storage for an access is
made based on the offset, rather than the structure. It also means that any access
where the offset is a variable must have an extra branch, unless the type of the
object is also known (if it's known to be a non-final object then we can just assert
that the offset is >= inlineStorageCapacity).
This looks like a big Kraken speed-up and a slight V8 speed-up.
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::ldrWide8BitImmediate):
(JSC::ARMv7Assembler::replaceWithLoad):
(JSC::ARMv7Assembler::replaceWithAddressComputation):
- assembler/AbstractMacroAssembler.h:
(AbstractMacroAssembler):
(ConvertibleLoadLabel):
(JSC::AbstractMacroAssembler::ConvertibleLoadLabel::ConvertibleLoadLabel):
(JSC::AbstractMacroAssembler::ConvertibleLoadLabel::isSet):
(JSC::AbstractMacroAssembler::labelIgnoringWatchpoints):
(JSC::AbstractMacroAssembler::replaceWithLoad):
(JSC::AbstractMacroAssembler::replaceWithAddressComputation):
- assembler/CodeLocation.h:
(JSC):
(CodeLocationCommon):
(CodeLocationConvertibleLoad):
(JSC::CodeLocationConvertibleLoad::CodeLocationConvertibleLoad):
(JSC::CodeLocationCommon::convertibleLoadAtOffset):
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
- assembler/LinkBuffer.h:
(LinkBuffer):
(JSC::LinkBuffer::locationOf):
- assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::convertibleLoadPtr):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::convertibleLoadPtr):
(MacroAssemblerX86):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::convertibleLoadPtr):
(MacroAssemblerX86_64):
- assembler/RepatchBuffer.h:
(RepatchBuffer):
(JSC::RepatchBuffer::replaceWithLoad):
(JSC::RepatchBuffer::replaceWithAddressComputation):
(JSC::RepatchBuffer::setLoadInstructionIsActive):
- assembler/X86Assembler.h:
(JSC::X86Assembler::replaceWithLoad):
(X86Assembler):
(JSC::X86Assembler::replaceWithAddressComputation):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):
- bytecode/GetByIdStatus.h:
(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::offset):
(GetByIdStatus):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdStatus.h:
(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::offset):
(PutByIdStatus):
- bytecode/ResolveGlobalStatus.cpp:
(JSC):
(JSC::computeForStructure):
- bytecode/ResolveGlobalStatus.h:
(JSC::ResolveGlobalStatus::ResolveGlobalStatus):
(JSC::ResolveGlobalStatus::offset):
(ResolveGlobalStatus):
- bytecode/StructureSet.h:
(StructureSet):
- bytecode/StructureStubInfo.h:
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):
- dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):
- heap/MarkStack.cpp:
(JSC::visitChildren):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCacheGetByID):
(JSC::Interpreter::privateExecute):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- jit/JIT.h:
(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JIT):
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve_global):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve_global):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::emit_op_get_by_pname):
- jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/x86.rb:
- runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::functionNameOffset):
- runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
(JSC):
(JSC::JSFinalObject::visitChildren):
(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::removeDirect):
(JSC::JSObject::growOutOfLineStorage):
(JSC::JSObject::getOwnPropertyDescriptor):
- runtime/JSObject.h:
(JSObject):
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::hasInlineStorage):
(JSC::JSObject::inlineStorageUnsafe):
(JSC::JSObject::inlineStorage):
(JSC::JSObject::outOfLineStorage):
(JSC::JSObject::locationForOffset):
(JSC::JSObject::offsetForLocation):
(JSC::JSObject::getDirectOffset):
(JSC::JSObject::putDirectOffset):
(JSC::JSObject::putUndefinedAtDirectOffset):
(JSC::JSObject::addressOfOutOfLineStorage):
(JSC::JSObject::finishCreation):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSFinalObject):
(JSC::JSFinalObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::offsetOfOutOfLineStorage):
(JSC::JSObject::setOutOfLineStorage):
(JSC::JSObject::JSObject):
(JSC):
(JSC::JSCell::fastGetOwnProperty):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::offsetRelativeToPatchedStorage):
(JSC::indexRelativeToBase):
(JSC::offsetRelativeToBase):
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
- runtime/JSPropertyNameIterator.h:
(JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::getOffset):
(JSC::JSPropertyNameIterator::finishCreation):
- runtime/JSValue.cpp:
(JSC::JSValue::putToPrimitive):
- runtime/Operations.h:
(JSC::normalizePrototypeChain):
- runtime/Options.cpp:
(JSC):
(JSC::Options::initialize):
- runtime/PropertyMapHashTable.h:
(PropertyMapEntry):
(JSC::PropertyMapEntry::PropertyMapEntry):
(PropertyTable):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::getDeletedOffset):
(JSC::PropertyTable::addDeletedOffset):
(JSC::PropertyTable::nextOffset):
(JSC):
(JSC::PropertyTable::sizeInMemory):
- runtime/PropertyOffset.h: Added.
(JSC):
(JSC::checkOffset):
(JSC::validateOffset):
(JSC::isValidOffset):
(JSC::isInlineOffset):
(JSC::isOutOfLineOffset):
(JSC::offsetInInlineStorage):
(JSC::offsetInOutOfLineStorage):
(JSC::offsetInRespectiveStorage):
(JSC::numberOfOutOfLineSlotsForLastOffset):
(JSC::numberOfSlotsForLastOffset):
(JSC::nextPropertyOffsetFor):
(JSC::firstPropertyOffsetFor):
- runtime/PropertySlot.h:
(JSC::PropertySlot::cachedOffset):
(JSC::PropertySlot::setValue):
(JSC::PropertySlot::setCacheableGetterSlot):
(JSC::PropertySlot::clearOffset):
- runtime/PutPropertySlot.h:
(JSC::PutPropertySlot::setExistingProperty):
(JSC::PutPropertySlot::setNewProperty):
(JSC::PutPropertySlot::cachedOffset):
(PutPropertySlot):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::nextOutOfLineStorageCapacity):
(JSC::Structure::growOutOfLineCapacity):
(JSC::Structure::suggestedNewOutOfLineStorageCapacity):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
- runtime/Structure.h:
(Structure):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::previousID):
(JSC::Structure::outOfLineCapacity):
(JSC::Structure::outOfLineSizeForKnownFinalObject):
(JSC::Structure::outOfLineSizeForKnownNonFinalObject):
(JSC::Structure::outOfLineSize):
(JSC::Structure::hasInlineStorage):
(JSC::Structure::inlineCapacity):
(JSC::Structure::inlineSizeForKnownFinalObject):
(JSC::Structure::inlineSize):
(JSC::Structure::totalStorageSize):
(JSC::Structure::totalStorageCapacity):
(JSC::Structure::firstValidOffset):
(JSC::Structure::lastValidOffset):
(JSC::Structure::isValidOffset):
(JSC::Structure::isEmpty):
(JSC::Structure::transitionCount):
(JSC::Structure::get):
- 1:36 PM Changeset in webkit [121924] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSObjectCallAsFunction should thisConvert the provided thisObject
https://bugs.webkit.org/show_bug.cgi?id=90628
Reviewed by Gavin Barraclough.
Perform this conversion on the provided this object.
- API/JSObjectRef.cpp:
(JSObjectCallAsFunction):
- 1:19 PM Changeset in webkit [121923] by
-
- 3 edits2 adds in trunk/Source/WebCore
Code refactoring: move mimeTypeFromUTITree to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=90619
We should move UTI handling related code to a separate file.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-07-05
Reviewed by David Kilzer.
- WebCore.xcodeproj/project.pbxproj: Add UTIUtilities.h/UTIUtilities.mm to xcode project, and drive-by fix
that happened when editing the Xcode project file.
- platform/network/mac/UTIUtilities.h: Added.
(WebCore):
- platform/network/mac/UTIUtilities.mm: Added. move mimeTypeFromUTITree to UTIUtilities.mm.
(WebCore):
(WebCore::mimeTypeFromUTITree):
- platform/network/mac/WebCoreURLResponse.mm: include UTIUtilities.h to use mimeTypeFromUTITree.
(WebCore):
- 1:07 PM Changeset in webkit [121922] by
-
- 5 edits14 adds in trunk/Source
[chromium] Create a WebKit::Web* wrapper for the cc animation classes
https://bugs.webkit.org/show_bug.cgi?id=90303
Reviewed by James Robinson.
Source/Platform:
- Platform.gypi:
- chromium/public/WebAnimation.h: Added.
(WebCore):
(WebKit):
(WebAnimation):
(WebKit::WebAnimation::WebAnimation):
(WebKit::WebAnimation::~WebAnimation):
- chromium/public/WebAnimationCurve.h: Added.
(WebCore):
(WebKit):
(WebAnimationCurve):
(WebKit::WebAnimationCurve::~WebAnimationCurve):
(WebKit::WebAnimationCurve::WebAnimationCurve):
- chromium/public/WebFloatAnimationCurve.h: Added.
(WebCore):
(WebKit):
(WebFloatAnimationCurve):
(WebKit::WebFloatAnimationCurve::WebFloatAnimationCurve):
(WebKit::WebFloatAnimationCurve::~WebFloatAnimationCurve):
- chromium/public/WebFloatKeyframe.h: Added.
(WebKit):
(WebKit::WebFloatKeyframe::WebFloatKeyframe):
(WebFloatKeyframe):
- chromium/public/WebTransformAnimationCurve.h: Added.
(WebCore):
(WebKit):
(WebTransformAnimationCurve):
(WebKit::WebTransformAnimationCurve::WebTransformAnimationCurve):
(WebKit::WebTransformAnimationCurve::~WebTransformAnimationCurve):
- chromium/public/WebTransformKeyframe.h: Added.
(WebKit):
(WebKit::WebTransformKeyframe::WebTransformKeyframe):
(WebTransformKeyframe):
Source/WebKit/chromium:
- WebKit.gyp:
- WebKit.gypi:
- src/WebAnimation.cpp: Added.
(WebKit):
(WebKit::WebAnimation::iterations):
(WebKit::WebAnimation::setIterations):
(WebKit::WebAnimation::startTime):
(WebKit::WebAnimation::setStartTime):
(WebKit::WebAnimation::timeOffset):
(WebKit::WebAnimation::setTimeOffset):
(WebKit::WebAnimation::alternatesDirection):
(WebKit::WebAnimation::setAlternatesDirection):
(WebKit::WebAnimation::toCCActiveAnimation):
(WebKit::WebAnimation::initialize):
(WebKit::WebAnimation::destroy):
- src/WebAnimationCurveCommon.cpp: Added.
(WebKit):
(WebKit::createTimingFunction):
- src/WebAnimationCurveCommon.h: Added.
(WebCore):
(WebKit):
- src/WebFloatAnimationCurve.cpp: Added.
(WebKit):
(WebKit::WebFloatAnimationCurve::add):
(WebKit::WebFloatAnimationCurve::toCCAnimationCurve):
(WebKit::WebFloatAnimationCurve::initialize):
(WebKit::WebFloatAnimationCurve::destroy):
- src/WebTransformAnimationCurve.cpp: Added.
(WebKit):
(WebKit::WebTransformAnimationCurve::add):
(WebKit::WebTransformAnimationCurve::toCCAnimationCurve):
(WebKit::WebTransformAnimationCurve::initialize):
(WebKit::WebTransformAnimationCurve::destroy):
- tests/WebAnimationTest.cpp: Added.
- tests/WebFloatAnimationCurveTest.cpp: Added.
- tests/WebTransformAnimationCurveTest.cpp: Added.
- 1:03 PM Changeset in webkit [121921] by
-
- 6 edits in trunk
Character iterators should not advance if they are at end
https://bugs.webkit.org/show_bug.cgi?id=90560
Reviewed by Ryosuke Niwa.
Source/WebCore:
CharacterIterator and BackwardsCharacterIterator try to advance their
internal TextIterator without checking if they already are at end.
This can cause crashes in TextIterator::advance.
Test: platform/chromium/editing/surrounding-text/surrounding-text.html
- editing/SurroundingText.cpp:
(WebCore::SurroundingText::SurroundingText):
- editing/TextIterator.cpp:
(WebCore::CharacterIterator::advance):
(WebCore::BackwardsCharacterIterator::advance):
LayoutTests:
Add a new test case where character iterators are already at end when
trying to advance. This was caught by Chromium's address sanitizer
here: http://code.google.com/p/chromium/issues/detail?id=135705
- platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
- platform/chromium/editing/surrounding-text/surrounding-text.html:
- 12:57 PM Changeset in webkit [121920] by
-
- 4 edits in trunk/Source/WebCore
Text Autosizing: Add basic framework
https://bugs.webkit.org/show_bug.cgi?id=88655
Follow-up patch tweaking method signatures.
Patch by John Mellor <johnme@chromium.org> on 2012-07-05
Reviewed by Simon Fraser.
No functional change, so no new tests.
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processBlock):
(WebCore::TextAutosizer::processText):
(WebCore):
- rendering/TextAutosizer.h:
(TextAutosizer):
- 12:49 PM Changeset in webkit [121919] by
-
- 6 edits2 copies in trunk/Source/WebKit2
[WK2] Add C API for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=90545
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-05
Reviewed by Anders Carlsson.
Add C API for WKBatteryManager and WKBatteryStatus
so that clients can support the Battery Status API
in WebKit2.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- UIProcess/API/C/WKBatteryManager.cpp:
(WKBatteryManagerProviderDidChangeBatteryStatus):
(WKBatteryManagerProviderUpdateBatteryStatus):
- UIProcess/API/C/WKBatteryStatus.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp.
(WKBatteryStatusGetTypeID):
(WKBatteryStatusCreate):
- UIProcess/API/C/WKBatteryStatus.h: Copied from Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp.
- 12:44 PM Changeset in webkit [121918] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: move cursor to the current search match.
https://bugs.webkit.org/show_bug.cgi?id=90621
Reviewed by Vsevolod Vlasov.
After closing the search dialog, the cursor should be at the latest search match location.
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.markAndRevealRange):
(WebInspector.TextEditor.prototype._handleFocused):
- 11:20 AM Changeset in webkit [121917] by
-
- 11 edits4 adds in trunk
Subpixel layout broken with spans with CSS position other than static
https://bugs.webkit.org/show_bug.cgi?id=90097
Patch by Behdad Esfahbod <behdad@behdad.org> on 2012-07-05
Reviewed by Eric Seidel.
In InlineBox, don't truncate size to integers when returning.
In RenderBlock, don't round-up width to next integer. Round-up to
next LayoutUnit instead.
Test: Added fast/sub-pixel/size-of-span-with-different-positions.html
Adjust expected outputs affected by the rounding changes.
- platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::fromFloatCeil):
(FractionalLayoutUnit):
- rendering/InlineBox.h:
(WebCore::InlineBox::size):
- rendering/RenderBlock.cpp:
(WebCore::updatePreferredWidth):
- 11:01 AM Changeset in webkit [121916] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r121899.
http://trac.webkit.org/changeset/121899
https://bugs.webkit.org/show_bug.cgi?id=90623
Unauthorized WK2 API breakage (Requested by andersca on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-05
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedURLAPI):
- 10:54 AM Changeset in webkit [121915] by
-
- 2 edits in trunk/Tools
Adding myself as committer to committers.py
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 10:46 AM Changeset in webkit [121914] by
-
- 3 edits in trunk
[CMake] Fix some CMake warnings
https://bugs.webkit.org/show_bug.cgi?id=90558
Fix WebKit options so they match with FeatureList.pm.
Reviewed by Dan Bates.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- 10:37 AM Changeset in webkit [121913] by
-
- 8 edits in trunk
[Mac][WK2] Enable HTTPS tests
https://bugs.webkit.org/show_bug.cgi?id=90600
Reviewed by Brady Eidson.
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed a misleading comment.
It explained why we were doing this here instead of a frame load delegate, but that's
just history, not an explanation of why we need this code.
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
Ignore certificate errors for localhost and 127.0.0.1. Since this is only needed
for tests, it seems appropriate to have platform specific solutions in every WTR,
and not add a WebKit2 API.
LayoutTests:
Unskip in common wk2 skipped file, re-skip everywhere besides Mac.
- platform/gtk-wk2/Skipped:
- platform/qt-5.0-wk2/Skipped:
- platform/win-wk2/Skipped:
- platform/wk2/Skipped:
- 10:19 AM Changeset in webkit [121912] by
-
- 4 edits2 adds in trunk
Source/WebCore: REGRESSION (r115654): Sometimes does not replace content for multipart/x-mixed-replace
https://bugs.webkit.org/show_bug.cgi?id=88436
Reviewed by Brady Eidson.
Test: http/tests/multipart/multipart-replace-non-html-content.php
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData): We should only send receivedFirstData() once per main resource load,
rather than multiple times in a multipart load.
(WebCore::DocumentLoader::setupForReplaceByMIMEType): m_gotFirstByte isn't set to true until data is
actually committed, and multipart data is often not committed until the part is finished. Check
whether the SharedBuffer is non-null instead.
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): The JSInternals object my have already been cleared if the window shell
was cleared as part of creation of a new Document. Check it before using it.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=88436.
Reviewed by Brady Eidson.
- http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
- http/tests/multipart/multipart-replace-non-html-content.php: Added.
- 9:44 AM Changeset in webkit [121911] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: move search field to the bottom of the page.
https://bugs.webkit.org/show_bug.cgi?id=90610
Reviewed by Vsevolod Vlasov.
This is the first step in the Search/replace implementation. This change moves search
field from the inspector toolbar to the inspector view footer that is visible upon Cmd/Ctrl+F.
- English.lproj/localizedStrings.js:
- inspector/front-end/InspectorView.js:
(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype._pushToHistory):
(WebInspector.InspectorView.prototype.panelsElement):
(WebInspector.InspectorView.prototype.setFooterElement):
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.show):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):
- inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype.focusSearchField):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
- inspector/front-end/inspector.css:
(#search):
(.toolbar-search-container):
(.toolbar-search-navigation):
(.toolbar-search-navigation:hover):
(.toolbar-search-navigation.toolbar-search-navigation-prev):
(.toolbar-search-navigation.toolbar-search-navigation-next):
(.toolbar-search-navigation-hidden):
(.status-bar):
(.search-drawer-header input[type="search"].search-config-search):
(.inspector-footer):
(.inspector-footer > div):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector.get _setCompactMode):
(WebInspector.postDocumentKeyDown):
- 9:39 AM Changeset in webkit [121910] by
-
- 2 edits in trunk
[Qt] Move Webkit1 before WebKit2 in the build order
Reviewed by Csaba Osztrogonác.
- WebKit.pro:
- 9:27 AM WebKit Team edited by
- (diff)
- 9:21 AM Changeset in webkit [121909] by
-
- 3 edits2 adds in trunk
[Chromium] Clear m_currentInputEvent after handled by pointerLockMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=90391
Source/WebKit/chromium:
WebViewImpl::handleInputEvent was keeping a pointer to an input event that would
later be accessed. When in pointer lock, that pointer was not being cleared.
Code modified to use TemporaryChange to automatically clear the pointer at all
method exit points.
Reviewed by Abhishek Arya.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
LayoutTests:
Test that reproduces bug 90391:
Enable pointer lock, receive mouse move, call window.open, don't crash.
Reviewed by Abhishek Arya.
- pointer-lock/bug90391-move-then-window-open-crash-expected.txt: Added.
- pointer-lock/bug90391-move-then-window-open-crash.html: Added.
- 9:13 AM Changeset in webkit [121908] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: added low-level instrumentation support for TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90264
Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-07-05
Reviewed by Pavel Feldman.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::timelineAgentForOrphanEvents):
(WebCore::InspectorInstrumentation::setTimelineAgentForOrphanEvents):
(WebCore::InspectorInstrumentation::threadSpecificTimelineAgentForOrphanEvents):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- 8:38 AM Changeset in webkit [121907] by
-
- 17 edits3 adds in trunk
Text Autosizing: Add test framework and simple test.
https://bugs.webkit.org/show_bug.cgi?id=90561
Source/WebCore:
Exposes methods allowing Layout Tests to enable Text Autosizing and
get the same results as if they were running on a mobile device.
Patch by John Mellor <johnme@chromium.org> on 2012-07-05
Reviewed by Adam Barth.
Test: fast/text-autosizing/simple-paragraph.html
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore):
(WebCore::Settings::setTextAutosizingWindowSizeOverride):
- page/Settings.h:
(Settings):
(WebCore::Settings::textAutosizingWindowSizeOverride):
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::boostSubtree):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setTextAutosizingEnabled):
(WebCore):
(WebCore::InternalSettings::setTextAutosizingWindowSizeOverride):
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl:
Source/WebKit/chromium:
ENABLE(TEXT_AUTOSIZING) is now on in Chromium (but disabled at runtime).
This allows it to be used in Layout Tests (and in future by Web
Inspector's mobile device emulation).
Patch by John Mellor <johnme@chromium.org> on 2012-07-05
Reviewed by Adam Barth.
- features.gypi:
LayoutTests:
Added a RefTest checking that Text Autosizing is active.
Skipped the text-autosizing test directory on platforms that
currently disable ENABLE(TEXT_AUTOSIZING).
Patch by John Mellor <johnme@chromium.org> on 2012-07-05
Reviewed by Adam Barth.
- fast/text-autosizing/simple-paragraph-expected.html: Added.
- fast/text-autosizing/simple-paragraph.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 8:27 AM Changeset in webkit [121906] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: timeline events in the vicinity of event dividers some times are tricky to expand
https://bugs.webkit.org/show_bug.cgi?id=90572
Reviewed by Pavel Feldman.
- do not use resources-event-divider-padding;
- make dividers larger and use border-color to visualize them;
- move resources-<color>-divider to timelinePanel.css, as they're not used outside of timeline;
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.createEventDivider):
- inspector/front-end/inspectorCommon.css:
- inspector/front-end/timelinePanel.css:
(.timeline .resources-event-divider):
(.resources-red-divider):
(.resources-blue-divider):
(.resources-orange-divider):
(.resources-divider.last):
(.timeline .resources-event-divider.timeline-frame-divider):
- 8:17 AM Changeset in webkit [121905] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: incorrect height of main timeline pane after switching to memory mode
https://bugs.webkit.org/show_bug.cgi?id=90387
Reviewed by Pavel Feldman.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._splitterDragging):
(WebInspector.TimelinePanel.prototype.set _setSplitterPosition):
(WebInspector.TimelinePanel.prototype._overviewModeChanged):
- 7:23 AM Changeset in webkit [121904] by
-
- 6 edits2 adds in trunk/Source/WebKit/chromium
[chromium] Add a method didChangeFormState to WebViewClient.
https://bugs.webkit.org/show_bug.cgi?id=90563
Patch by Oli Lan <olilan@chromium.org> on 2012-07-05
Reviewed by Adam Barth.
This patch adds a new method didChangeFormState to WebViewClient,
and calls it from ChromeClientImpl::formStateDidChange with the changed node.
This new method can be used for example by the Android port to update the browser's
IME when the state of the currently focused text node has changed. To facilitate this
usage, a focused() method has been added to WebNode.
A new test has been added to WebViewTest. This test checks that didChangeFormState
is called when an input's value is changed, and also checks that WebNode::focused() returns
the correct value for the provided node, in both the focused and non-focused cases.
- public/WebNode.h:
- public/WebViewClient.h:
(WebKit::WebViewClient::didChangeFormState):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::formStateDidChange):
- src/WebNode.cpp:
(WebKit::WebNode::focused):
(WebKit):
- tests/WebViewTest.cpp:
(FormChangeWebViewClient):
(WebKit::FormChangeWebViewClient::didChangeFormState):
(WebKit::FormChangeWebViewClient::reset):
(WebKit::FormChangeWebViewClient::called):
(WebKit::FormChangeWebViewClient::focused):
(WebKit):
(WebKit::TEST_F):
- tests/data/input_field_set_value_while_focused.html: Added.
- tests/data/input_field_set_value_while_not_focused.html: Added.
- 7:20 AM Changeset in webkit [121903] by
-
- 2 edits in trunk
[CMAKE] Unreviewd typo fix after r121857
- Source/cmake/WebKitMacros.cmake:
- 7:19 AM Changeset in webkit [121902] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Add support for keyboard increment / decrement on numbers in attributes in Elements Panel
https://bugs.webkit.org/show_bug.cgi?id=89586
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-05
Reviewed by Pavel Feldman
Refactoring the key events while editing style property values. Migrated the code to UIUtils.js and referred
from StylesSidebarPane.js, ElementsTreeOutline.js and MetricsSidebarPane.js.
No new tests as code refactoring and UI feature added to ElementsTreeOutline.js
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingAttribute.handleKeyDownEvents):
(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
- inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown.finishHandler):
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown.customNumberHandler):
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._handleNameOrValueUpDown.finishHandler):
(WebInspector.StylesSidebarPane.prototype._handleNameOrValueUpDown):
- inspector/front-end/UIUtils.js:
(WebInspector._modifiedHexValue):
(WebInspector._modifiedFloatNumber):
(WebInspector.handleElementValueModifications):
- 6:10 AM Changeset in webkit [121901] by
-
- 3 edits in trunk/Tools
[Qt] Remove rpath-hacks in qt_webkit.pri
Having it in qt_webkit.pri meant that all client apps would inherit the rpath,
even if they were not using QtWebKit.
This is a regression for people who build client apps against a non-installed
QtWebKit, as the client app will be missing a rpath to the standalone WebKit
build dir. This can be solved by LD_LIBRARY_PATH or custom QMAKE_RPATHDIR
logic, until the real issue is fixed in Qt.
Reviewed by Csaba Osztrogonác.
- 5:31 AM Changeset in webkit [121900] by
-
- 10 edits1 add1 delete in trunk/Source/WebCore
NEON intrinsics should be used with gaussian blur filter
https://bugs.webkit.org/show_bug.cgi?id=90166
Reviewed by Zoltan Herczeg.
Rewrite inline assembly to NEON intrinsics for better portabilty
and readibility. Remove unnecessary FEGaussianBlurNEON.cpp and add
NEONHelpers.h to the project which will contains the shared
NEON code of the filters.
Existing tests cover this issue.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApplyWorker):
- platform/graphics/filters/FEGaussianBlur.h:
(FEGaussianBlur):
- platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Removed.
- platform/graphics/filters/arm/FEGaussianBlurNEON.h:
(WebCore::boxBlurNEON):
- platform/graphics/filters/arm/NEONHelpers.h: Added.
(WebCore):
(WebCore::loadRGBA8AsFloat):
(WebCore::storeFloatAsRGBA8):
- 4:21 AM Changeset in webkit [121899] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] WTR crashes if a URL is passed as a parameter
https://bugs.webkit.org/show_bug.cgi?id=88093
Reviewed by Zoltan Herczeg.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedURLAPI):
Don't special case null string. It's handled
fine by WebURL and passing 0 is not suitable
to the API.
- 3:54 AM Changeset in webkit [121898] by
-
- 4 edits2 moves in trunk/Source/WebKit
[EFL] Change class name from NotificationClientEfl to NotificationPresenterClientEfl.
https://bugs.webkit.org/show_bug.cgi?id=90542
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit:
NotificationClientEfl.cpp is changed to NotificationPresenterClientEfl.cpp
to be in line with other ports(qt, chromium, gtk).
- PlatformEfl.cmake:
Source/WebKit/efl:
Change class name from NotificationClientEfl to NotificationPresenterClientEfl
to be in line with other ports.(qt, chromium, blackberry)
- WebCoreSupport/ChromeClientEfl.cpp:
- WebCoreSupport/NotificationPresenterClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.cpp.
(WebCore):
(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::~NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::show):
(WebCore::NotificationPresenterClientEfl::cancel):
(WebCore::NotificationPresenterClientEfl::notificationObjectDestroyed):
(WebCore::NotificationPresenterClientEfl::notificationControllerDestroyed):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):
- WebCoreSupport/NotificationPresenterClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.h.
(WebCore):
(NotificationPresenterClientEfl):
- 3:52 AM Changeset in webkit [121897] by
-
- 7 edits1 add in trunk
[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
https://bugs.webkit.org/show_bug.cgi?id=88608
Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-05
Reviewed by Hajime Morita.
.:
- Source/cmake/OptionsEfl.cmake: Enable the CUSTOM_SCHEME_HANDLER feature as default.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::isProtocolHandlerRegistered): Add a stub function.
(WebKit::WebChromeClient::unregisterProtocolHandler): Add a stub function.
(WebChromeClient):
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.
LayoutTests:
- platform/efl/fast/dom/unregister-protocol-handler-expected.txt: Expected result of the EFL port.
- 3:33 AM Changeset in webkit [121896] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Having a "Scroll into view" for nodes through web inspector.
https://bugs.webkit.org/show_bug.cgi?id=89554
Added options for scrolling-into-view the element node through web
inspector.
Patch by Sam D <dsam2912@gmail.com> on 2012-07-05
Reviewed by Pavel Feldman.
No new tests. UI change.
- English.lproj/localizedStrings.js:
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(.):
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.callFunction):
- 2:34 AM Changeset in webkit [121895] by
-
- 4 edits in trunk/Source/WebCore
Add Gamepad logging channel
https://bugs.webkit.org/show_bug.cgi?id=90570
Reviewed by Carlos Garcia Campos.
Add a new logging channel for logging significant
events that are related to Gamepad API implementation.
No new tests - no new testable functionality.
- platform/Logging.cpp:
(WebCore):
(WebCore::getChannelFromName):
- platform/Logging.h:
(WebCore):
- platform/gtk/GamepadsGtk.cpp: Log when a device is
registered or unregistered.
(WebCore::GamepadsGtk::registerDevice):
(WebCore::GamepadsGtk::unregisterDevice):
- 2:22 AM Changeset in webkit [121894] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r121891.
- platform/qt/Skipped:
- 1:47 AM Changeset in webkit [121893] by
-
- 13 edits10 adds in trunk
[Wk2][EFL] EFL needs a WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=87659
Reviewed by Kenneth Rohde Christiansen.
.:
- Source/CMakeLists.txt:
Set compiler flags for WebCoreTestSupport to be linked into TestRunnerInjectedBundle
shared library.
- Source/cmake/WebKitMacros.cmake: Remove unnecessary dependency.
Source/WebKit2:
- PlatformEfl.cmake: Added WKImageCairo.cpp in source list.
Tools:
Add an implementation of WebKitTestRunner for Efl port.
- CMakeLists.txt: Includes WebKitTestRunner build script.
- Scripts/build-webkittestrunner: Added knowledge of WebKitTestRunner/Efl.
- Scripts/webkitpy/layout_tests/port/efl.py: Ditto.
(EflPort.setup_environ_for_server):
- WebKitTestRunner/CMakeLists.txt: Added.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Added.
- WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Added.
- WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Added.
- WebKitTestRunner/PlatformEfl.cmake: Added.
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/TestController.cpp:
- WebKitTestRunner/config.h: Added knowledge of WebKitTestRunner/Efl.
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Added.
- WebKitTestRunner/efl/TestControllerEfl.cpp: Added.
- WebKitTestRunner/efl/main.cpp: Added.
(main):
- 1:36 AM Changeset in webkit [121892] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Add ewk_view_reload_bypass_cache API.
https://bugs.webkit.org/show_bug.cgi?id=89413
Patch by Hyerim Bae <hyerim.bae@samsung.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.
Add API, which is for reloading documents without cache.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_reload_bypass_cache):
- UIProcess/API/efl/ewk_view.h:
- 1:19 AM Changeset in webkit [121891] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [JSC] support JS execution in the context of an isolated world
https://bugs.webkit.org/show_bug.cgi?id=85709
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-07-05
Reviewed by Gavin Barraclough.
No new test case for this bug.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore):
- 1:14 AM Changeset in webkit [121890] by
-
- 5 edits in trunk
[WK2][EFL] Ewk_View needs API to load HTML data
https://bugs.webkit.org/show_bug.cgi?id=90540
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Add method to Ewk_View to load provided HTML data.
This is used for e.g. when an URL cannot be reached
and we need to display an error page.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_html_load):
- UIProcess/API/efl/ewk_view.h:
Tools:
Update EFL MiniBrowser to catch the "load,error" signal
on the view and display an error page.
- MiniBrowser/efl/main.c:
(on_error):
(browserCreate):
- 12:59 AM Changeset in webkit [121889] by
-
- 6 edits8 adds in trunk/Source/WebKit2
[WK2][EFL] Ewk_View needs to report new resource requests
https://bugs.webkit.org/show_bug.cgi?id=90577
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.
Add new "resource,request,new" signal to Ewk_View to
notify clients of the resource requests being initiated.
New Ewk_Url_Request and Ewk_Web_Resource types are
introduced in order to provide the clients with the
needed information regarding the resource requests.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_url_request.cpp: Added.
(_Ewk_Url_Request):
(ewk_url_request_ref):
(ewk_url_request_unref):
(ewk_url_request_url_get):
(ewk_request_first_party_get):
(ewk_url_request_http_method_get):
(ewk_url_request_new):
- UIProcess/API/efl/ewk_url_request.h: Added.
- UIProcess/API/efl/ewk_url_request_private.h: Added.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
(ewk_view_resource_load_initiated):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_private.h:
- UIProcess/API/efl/ewk_view_resource_load_client.cpp: Added.
(didInitiateLoadForResource):
(ewk_view_resource_load_client_attach):
- UIProcess/API/efl/ewk_view_resource_load_client_private.h: Added.
- UIProcess/API/efl/ewk_web_resource.cpp: Added.
(_Ewk_Web_Resource):
(ewk_web_resource_ref):
(ewk_web_resource_unref):
(ewk_web_resource_uri_get):
(ewk_web_resource_new):
(ewk_web_resource_main_get):
- UIProcess/API/efl/ewk_web_resource.h: Added.
- UIProcess/API/efl/ewk_web_resource_private.h: Added.
- 12:58 AM Changeset in webkit [121888] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, marking a test as a flaky crasher after r121869.
- platform/gtk/TestExpectations:
- 12:53 AM Changeset in webkit [121887] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Unreviewed buildfix after r121886. Typo fix.
- assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
- 12:24 AM Changeset in webkit [121886] by
-
- 2 edits in trunk/Tools
Hidden dirs are not copied when creating the built product archive
https://bugs.webkit.org/show_bug.cgi?id=90559
Reviewed by Carlos Garcia Campos.
Hidden dirs are not copied inside the built product archive
because the recursive copy command was ignoring them. We need those
hidden directories for the GTK WebKit2 testing bot to work fine.
- BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): replaced "*" by "." to include hidden
dirs/files.
- 12:04 AM Changeset in webkit [121885] by
-
- 19 edits in trunk/Source
Port DFG JIT to traditional ARM
https://bugs.webkit.org/show_bug.cgi?id=90198
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This patch contains the macro assembler part of the
DFG JIT support on ARM systems with fixed 32 bit instruction
width. A large amount of old code was refactored, and the ARMv4
or lower support is removed from the macro assembler.
Sunspider is improved by 8%, and V8 is 92%.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::dataTransfer32):
(JSC::ARMAssembler::baseIndexTransfer32):
(JSC):
(JSC::ARMAssembler::dataTransfer16):
(JSC::ARMAssembler::baseIndexTransfer16):
(JSC::ARMAssembler::dataTransferFloat):
(JSC::ARMAssembler::baseIndexTransferFloat):
(JSC::ARMAssembler::executableCopy):
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::ARMAssembler):
(JSC::ARMAssembler::emitInst):
(JSC::ARMAssembler::vmov_f64_r):
(ARMAssembler):
(JSC::ARMAssembler::vabs_f64_r):
(JSC::ARMAssembler::vneg_f64_r):
(JSC::ARMAssembler::ldr_imm):
(JSC::ARMAssembler::ldr_un_imm):
(JSC::ARMAssembler::dtr_u):
(JSC::ARMAssembler::dtr_ur):
(JSC::ARMAssembler::dtr_d):
(JSC::ARMAssembler::dtr_dr):
(JSC::ARMAssembler::dtrh_u):
(JSC::ARMAssembler::dtrh_ur):
(JSC::ARMAssembler::dtrh_d):
(JSC::ARMAssembler::dtrh_dr):
(JSC::ARMAssembler::fdtr_u):
(JSC::ARMAssembler::fdtr_d):
(JSC::ARMAssembler::push_r):
(JSC::ARMAssembler::pop_r):
(JSC::ARMAssembler::poke_r):
(JSC::ARMAssembler::peek_r):
(JSC::ARMAssembler::vmov_vfp64_r):
(JSC::ARMAssembler::vmov_arm64_r):
(JSC::ARMAssembler::vmov_vfp32_r):
(JSC::ARMAssembler::vmov_arm32_r):
(JSC::ARMAssembler::vcvt_u32_f64_r):
(JSC::ARMAssembler::vcvt_f64_f32_r):
(JSC::ARMAssembler::vcvt_f32_f64_r):
(JSC::ARMAssembler::clz_r):
(JSC::ARMAssembler::bkpt):
(JSC::ARMAssembler::bx):
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::labelIgnoringWatchpoints):
(JSC::ARMAssembler::labelForWatchpoint):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::getLdrImmAddress):
(JSC::ARMAssembler::replaceWithJump):
(JSC::ARMAssembler::maxJumpReplacementSize):
(JSC::ARMAssembler::getOp2Byte):
(JSC::ARMAssembler::getOp2Half):
(JSC::ARMAssembler::RM):
(JSC::ARMAssembler::RS):
(JSC::ARMAssembler::RD):
(JSC::ARMAssembler::RN):
- assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::ensureSpaceForAnyInstruction):
- assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::add32):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::and32):
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::mul32):
(JSC::MacroAssemblerARM::neg32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::xor32):
(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::load8Signed):
(JSC::MacroAssemblerARM::load16):
(JSC::MacroAssemblerARM::load16Signed):
(JSC::MacroAssemblerARM::load32):
(JSC::MacroAssemblerARM::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::store32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::store8):
(JSC::MacroAssemblerARM::store16):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::jump):
(JSC::MacroAssemblerARM::branchAdd32):
(JSC::MacroAssemblerARM::mull32):
(JSC::MacroAssemblerARM::branchMul32):
(JSC::MacroAssemblerARM::nearCall):
(JSC::MacroAssemblerARM::compare32):
(JSC::MacroAssemblerARM::test32):
(JSC::MacroAssemblerARM::sub32):
(JSC::MacroAssemblerARM::call):
(JSC::MacroAssemblerARM::loadFloat):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::storeFloat):
(JSC::MacroAssemblerARM::storeDouble):
(JSC::MacroAssemblerARM::moveDouble):
(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::absDouble):
(JSC::MacroAssemblerARM::negateDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::convertFloatToDouble):
(JSC::MacroAssemblerARM::convertDoubleToFloat):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerARM::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerARM::truncateDoubleToInt32):
(JSC::MacroAssemblerARM::truncateDoubleToUint32):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
(JSC::MacroAssemblerARM::branchDoubleNonZero):
(JSC::MacroAssemblerARM::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerARM::invert):
(JSC::MacroAssemblerARM::replaceWithJump):
(JSC::MacroAssemblerARM::maxJumpReplacementSize):
(JSC::MacroAssemblerARM::call32):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::label):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
- dfg/DFGCCallHelpers.h:
(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArguments):
- dfg/DFGFPRInfo.h:
(DFG):
- dfg/DFGGPRInfo.h:
(DFG):
(GPRInfo):
- dfg/DFGOperations.cpp:
(JSC):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
- jit/JITStubs.cpp:
(JSC):
- jit/JITStubs.h:
(JITStackFrame):
- jit/JSInterfaceJIT.h:
(JSInterfaceJIT):
Source/WTF:
Enabling DFG JIT on ARM systems with 32 bit instruction set.
- wtf/InlineASM.h:
- wtf/Platform.h:
Jul 4, 2012:
- 11:53 PM Changeset in webkit [121884] by
-
- 3 edits in trunk/Source/WebCore
Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.
https://bugs.webkit.org/show_bug.cgi?id=90447
Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-04
Reviewed by Alexey Proskuryakov.
No new tests. This patch doesn't change behavior.
- platform/graphics/BitmapImage.h:
(BitmapImage):
- platform/graphics/qt/StillImageQt.h:
(StillImage):
- 11:45 PM Changeset in webkit [121883] by
-
- 10 edits11 adds in trunk
Implement the script-nonce Content Security Policy directive.
https://bugs.webkit.org/show_bug.cgi?id=89577
Patch by Mike West <mkwst@chromium.org> on 2012-07-04
Reviewed by Adam Barth.
Source/WebCore:
This patch implements the (experimental) script-nonce Content Security
Policy directive from the 1.1 spec, which allows for selective
execution of script by specifying a "nonce" attribute for the
script tag. Script is only loaded and executed if it both matches the
nonce and matches the script-src whitelist (if present).
The implementation is gated on the ENABLE_CSP_NEXT flag, which is
currently disabled for all ports other than Chromium.
Tests: http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html
http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce.html
http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html
http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce.html
http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked.html
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::executeScript):
Passing the nonce attribute through to check against CSP.
- html/HTMLAttributeNames.in:
- html/HTMLScriptElement.idl:
Adding the
nonce
attribute to the script tag.
- page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
(WebCore::CSPDirectiveList::logInvalidNonce):
(WebCore):
(WebCore::CSPDirectiveList::checkNonceAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
If a nonce is set, deny JavaScript URLs and inline event handlers.
(WebCore::CSPDirectiveList::allowScriptNonce):
(WebCore::CSPDirectiveList::parseScriptNonce):
(WebCore::CSPDirectiveList::addDirective):
(WebCore::isAllowedByAllWithNonce):
(WebCore::ContentSecurityPolicy::allowScriptNonce):
- page/ContentSecurityPolicy.h:
(WebCore):
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl:
Adding noncy goodness to the echo script.
- http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:
(test):
- platform/gtk/TestExpectations:
Skipping 1.1 tests on GTK (missed it in r121879).
- 11:02 PM Changeset in webkit [121882] by
-
- 14 edits17 moves1 add in trunk/Source/WebCore
Notifications should be in Modules/notifications
https://bugs.webkit.org/show_bug.cgi?id=82121
Reviewed by Adam Barth.
The notifications directory is now self-contained. This patch moves it to the Modules directory.
No new tests, covered by existing tests.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Modules/notifications/DOMWindowNotifications.cpp: Renamed from Source/WebCore/notifications/DOMWindowNotifications.cpp.
(WebCore):
(WebCore::DOMWindowNotifications::DOMWindowNotifications):
(WebCore::DOMWindowNotifications::~DOMWindowNotifications):
(WebCore::DOMWindowNotifications::from):
(WebCore::DOMWindowNotifications::webkitNotifications):
(WebCore::DOMWindowNotifications::disconnectFrameForPageCache):
(WebCore::DOMWindowNotifications::reconnectFrameFromPageCache):
(WebCore::DOMWindowNotifications::willDestroyGlobalObjectInCachedFrame):
(WebCore::DOMWindowNotifications::willDestroyGlobalObjectInFrame):
(WebCore::DOMWindowNotifications::willDetachGlobalObjectFromFrame):
- Modules/notifications/DOMWindowNotifications.h: Renamed from Source/WebCore/notifications/DOMWindowNotifications.h.
(WebCore):
(DOMWindowNotifications):
- Modules/notifications/DOMWindowNotifications.idl: Renamed from Source/WebCore/notifications/DOMWindowNotifications.idl.
- Modules/notifications/Notification.cpp: Renamed from Source/WebCore/notifications/Notification.cpp.
(WebCore):
(WebCore::Notification::Notification):
(WebCore::Notification::~Notification):
(WebCore::Notification::create):
(WebCore::getAndAddEventListener):
(WebCore::Notification::interfaceName):
(WebCore::Notification::show):
(WebCore::Notification::close):
(WebCore::Notification::eventTargetData):
(WebCore::Notification::ensureEventTargetData):
(WebCore::Notification::contextDestroyed):
(WebCore::Notification::finalize):
(WebCore::Notification::dispatchShowEvent):
(WebCore::Notification::dispatchClickEvent):
(WebCore::Notification::dispatchCloseEvent):
(WebCore::Notification::dispatchErrorEvent):
(WebCore::Notification::taskTimerFired):
(WebCore::Notification::permissionLevel):
(WebCore::Notification::permissionString):
(WebCore::Notification::requestPermission):
- Modules/notifications/Notification.h: Renamed from Source/WebCore/notifications/Notification.h.
(WebCore):
(Notification):
(WebCore::Notification::cancel):
(WebCore::Notification::isHTML):
(WebCore::Notification::setHTML):
(WebCore::Notification::url):
(WebCore::Notification::setURL):
(WebCore::Notification::iconURL):
(WebCore::Notification::title):
(WebCore::Notification::body):
(WebCore::Notification::dir):
(WebCore::Notification::setDir):
(WebCore::Notification::replaceId):
(WebCore::Notification::setReplaceId):
(WebCore::Notification::tag):
(WebCore::Notification::setTag):
(WebCore::Notification::direction):
(WebCore::Notification::scriptExecutionContext):
(WebCore::Notification::detachPresenter):
(WebCore::Notification::setBody):
(WebCore::Notification::refEventTarget):
(WebCore::Notification::derefEventTarget):
- Modules/notifications/Notification.idl: Renamed from Source/WebCore/notifications/Notification.idl.
- Modules/notifications/NotificationCenter.cpp: Renamed from Source/WebCore/notifications/NotificationCenter.cpp.
(WebCore):
(WebCore::NotificationCenter::create):
(WebCore::NotificationCenter::NotificationCenter):
(WebCore::NotificationCenter::checkPermission):
(WebCore::NotificationCenter::requestPermission):
(WebCore::NotificationCenter::stop):
(WebCore::NotificationCenter::requestTimedOut):
(WebCore::NotificationCenter::NotificationRequestCallback::createAndStartTimer):
(WebCore::NotificationCenter::NotificationRequestCallback::NotificationRequestCallback):
(WebCore::NotificationCenter::NotificationRequestCallback::startTimer):
(WebCore::NotificationCenter::NotificationRequestCallback::timerFired):
- Modules/notifications/NotificationCenter.h: Renamed from Source/WebCore/notifications/NotificationCenter.h.
(WebCore):
(NotificationCenter):
(WebCore::NotificationCenter::createHTMLNotification):
(WebCore::NotificationCenter::createNotification):
(WebCore::NotificationCenter::client):
(NotificationRequestCallback):
- Modules/notifications/NotificationCenter.idl: Renamed from Source/WebCore/notifications/NotificationCenter.idl.
- Modules/notifications/NotificationClient.h: Renamed from Source/WebCore/notifications/NotificationClient.h.
(WebCore):
(NotificationClient):
(WebCore::NotificationClient::clearNotifications):
(WebCore::NotificationClient::~NotificationClient):
- Modules/notifications/NotificationController.cpp: Renamed from Source/WebCore/notifications/NotificationController.cpp.
(WebCore):
(WebCore::NotificationController::NotificationController):
(WebCore::NotificationController::~NotificationController):
(WebCore::NotificationController::create):
(WebCore::NotificationController::clientFrom):
(WebCore::NotificationController::supplementName):
(WebCore::provideNotification):
- Modules/notifications/NotificationController.h: Renamed from Source/WebCore/notifications/NotificationController.h.
(WebCore):
(NotificationController):
(WebCore::NotificationController::from):
(WebCore::NotificationController::client):
- Modules/notifications/NotificationPermissionCallback.h: Renamed from Source/WebCore/notifications/NotificationPermissionCallback.h.
(WebCore):
(NotificationPermissionCallback):
(WebCore::NotificationPermissionCallback::~NotificationPermissionCallback):
- Modules/notifications/NotificationPermissionCallback.idl: Renamed from Source/WebCore/notifications/NotificationPermissionCallback.idl.
- Modules/notifications/WorkerContextNotifications.cpp: Renamed from Source/WebCore/notifications/WorkerContextNotifications.cpp.
(WebCore):
(WebCore::WorkerContextNotifications::WorkerContextNotifications):
(WebCore::WorkerContextNotifications::~WorkerContextNotifications):
(WebCore::WorkerContextNotifications::from):
(WebCore::WorkerContextNotifications::webkitNotifications):
- Modules/notifications/WorkerContextNotifications.h: Renamed from Source/WebCore/notifications/WorkerContextNotifications.h.
(WebCore):
(WorkerContextNotifications):
- Modules/notifications/WorkerContextNotifications.idl: Renamed from Source/WebCore/notifications/WorkerContextNotifications.idl.
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/copyForwardingHeaders.cmd:
- WebCore.xcodeproj/project.pbxproj:
- 10:35 PM Changeset in webkit [121881] by
-
- 2 edits in trunk/Tools
Unreviewed Chromium gardening, Disable always failed python tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=90587
PortTest.qt_linux and mac_lion are always failed on Chromium Windows at
creating child process.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.disabled_test_qt_linux):
(PortTest.disabled_test_mac_lion):
- 9:27 PM Changeset in webkit [121880] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, Chromium gardening. Roll Chromium DEPS.
- DEPS: chromium_rev: 145322 => 145501
- 9:04 PM Changeset in webkit [121879] by
-
- 7 edits in trunk/LayoutTests
Skip CSP 1.1 tests on ports where it's disabled.
https://bugs.webkit.org/show_bug.cgi?id=90564
Patch by Mike West <mkwst@chromium.org> on 2012-07-04
Reviewed by Adam Barth.
- platform/efl/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 8:48 PM Changeset in webkit [121878] by
-
- 2 edits in trunk/Tools
[Tools] webkit_unittest.py got assertion
https://bugs.webkit.org/show_bug.cgi?id=90579
Reviewed by Hajime Morita.
This patch updates expectation of assertion in test_skipped_directories_for_symbols().
r121874 added new (exclude) directory (inspector/styles/variables), however it didn't
update one of two assertions.
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
- 8:30 PM Changeset in webkit [121877] by
-
- 3 edits in trunk/LayoutTests
AudioNode test should cover numberOfInputs and numberOfOutputs of AudioDestinationNode
https://bugs.webkit.org/show_bug.cgi?id=90578
Patch by Li Yin <li.yin@intel.com> on 2012-07-04
Reviewed by Chris Rogers.
Spec: http://www.w3.org/TR/webaudio/#AudioDestinationNode-section
An AudioSourceNode has no inputs and a single output.
An AudioDestinationNode has one input and no outputs.
Currently, the test webaudio/audionode.html has covered AudioSourceNode,
it is still required to cover AudioDestinationNode.
- webaudio/audionode-expected.txt:
- webaudio/audionode.html:
- 6:54 PM Changeset in webkit [121876] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening, drop test expectations for
Chromium-Linux and Chromium-Win.
- platform/chromium/TestExpectations:
- 6:25 PM Changeset in webkit [121875] by
-
- 2 edits in trunk/Source/WebCore
Remove inline keywords from functions which can not be inlined in ComposedShadowTreeWalker
https://bugs.webkit.org/show_bug.cgi?id=90432
Reviewed by Hajime Morita.
No new tests - no functional changes.
- dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):
- 5:15 PM Changeset in webkit [121874] by
-
- 14 edits3 adds in trunk
Inspector crashes when trying to inspect a page with CSS variables
https://bugs.webkit.org/show_bug.cgi?id=89818
Reviewed by Antti Koivisto.
Patch works by fixing treating handling of CSSPropertyID == CSSPropertyVariable as a special case,
and looking up the author-defined property name from the CSSValue.
Added test inspector/styles/variables/css-variables.html that inspects an element using CSS variables.
Test is skipped when variables are compiled out.
- css/CSSProperty.cpp:
(WebCore::CSSProperty::cssName):
(WebCore):
(WebCore::CSSProperty::cssText):
- css/CSSProperty.h:
(CSSProperty):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::item):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::populateAllProperties):
- 3:41 PM Changeset in webkit [121873] by
-
- 3 edits in trunk/Tools
webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
https://bugs.webkit.org/show_bug.cgi?id=67935
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-04
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.set_reviewer):
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_set_reviewer):
(test_set_short_description_and_bug_url):
- 3:06 PM Changeset in webkit [121872] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Implement device metrics for blackberry.
https://bugs.webkit.org/show_bug.cgi?id=90494
RIM PR #159034
Patch by Hanna Ma <Hanma@rim.com> on 2012-07-04
Reviewed by Rob Buis.
Implement calls to the application to change the device metrics for
the web inspector.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::applySizeOverride):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setTextZoomFactor):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::InspectorClientBlackBerry):
(WebCore::InspectorClientBlackBerry::canOverrideDeviceMetrics):
(WebCore):
(WebCore::InspectorClientBlackBerry::overrideDeviceMetrics):
(WebCore::InspectorClientBlackBerry::supportsFrameInstrumentation):
- WebCoreSupport/InspectorClientBlackBerry.h:
(InspectorClientBlackBerry):
- 2:36 PM Changeset in webkit [121871] by
-
- 17 edits1 copy in trunk
Web Inspector [JSC]: Implement ScriptCallStack::stackTrace
https://bugs.webkit.org/show_bug.cgi?id=40118
Patch by Anthony Scian <ascian@rim.com> on 2012-07-04
Reviewed by Yong Li.
Source/JavaScriptCore:
Added member functions to expose function name, urlString, and line #.
Refactored toString to make use of these member functions to reduce
duplicated code for future maintenance.
Manually tested refactoring of toString by tracing thrown exceptions.
- interpreter/Interpreter.h:
(JSC::StackFrame::toString):
(JSC::StackFrame::friendlySourceURL):
(JSC::StackFrame::friendlyFunctionName):
(JSC::StackFrame::friendlyLineNumber):
Source/WebCore:
Implemented stub for createScriptCallStack to call into
Interpreter and extract the current stack frames, iterate
through the frames and create the return result required.
No new tests, manually tested thrown exception and inspector
tracebacks.
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
LayoutTests:
Updated test results now that createScriptCallStack is functional.
- http/tests/inspector/console-resource-errors-expected.txt:
- http/tests/inspector/console-xhr-logging-async-expected.txt:
- http/tests/inspector/console-xhr-logging-expected.txt:
- http/tests/inspector/network/script-as-text-loading-expected.txt:
- inspector/timeline/timeline-animation-frame-expected.txt:
- inspector/timeline/timeline-layout-expected.txt:
- inspector/timeline/timeline-mark-timeline-expected.txt:
- inspector/timeline/timeline-network-resource-expected.txt:
- inspector/timeline/timeline-paint-expected.txt:
- inspector/timeline/timeline-parse-html-expected.txt:
- inspector/timeline/timeline-time-stamp-expected.txt:
- inspector/timeline/timeline-timer-expected.txt:
- platform/chromium/http/tests/inspector/console-xhr-logging-async-expected.txt:
- 1:50 PM Changeset in webkit [121870] by
-
- 17 edits in trunk/Source
[chromium] Respect memory needed for RenderSurfaces when reserving contents textures
https://bugs.webkit.org/show_bug.cgi?id=89901
Reviewed by Adrienne Walker.
Source/WebCore:
Treat the memory allocation given to a tab as an allocation for its
contents and surfaces. Then only use up contents memory such that
the surface textures will still fit within the limit. Report histograms
for the amount of contents and surface texture memory used by each
frame generated by the main thread.
In the context of ubercomp, each nested compositor will use less memory
for contents ensuring that the root compositor has space for surfaces
caused by that nested compositor.
Since surface memory can no longer be taken by contents, we remove the
preferred memory limit from the texture manager.
Tests: TiledLayerChromiumTest.dontAllocateContentsWhenTargetSurfaceCantBeAllocated
CCPrioritizedTextureTest.renderSurfacesReduceMemoryAvailableOutsideRootSurface
CCPrioritizedTextureTest.renderSurfacesReduceMemoryAvailableForRequestLate
CCPrioritizedTextureTest.whenRenderSurfaceNotAvailableTexturesAlsoNotAvailable
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawBackgroundFilters):
- platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::setTexturePriorities):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::prioritizeTextures):
(WebCore::CCLayerTreeHost::paintLayerContents):
- platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::didUseContentsTextureMemoryBytes):
(WebCore):
(WebCore::CCOverdrawMetrics::didUseRenderSurfaceTextureMemoryBytes):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):
- platform/graphics/chromium/cc/CCOverdrawMetrics.h:
(CCOverdrawMetrics):
- platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:
(WebCore::CCPrioritizedTextureManager::CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::prioritizeTextures):
(WebCore::CCPrioritizedTextureManager::requestLate):
(WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
(WebCore::CCPrioritizedTextureManager::reduceMemory):
- platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:
(WebCore::CCPrioritizedTextureManager::create):
(WebCore::CCPrioritizedTextureManager::memoryForRenderSurfacesBytes):
(CCPrioritizedTextureManager):
- platform/graphics/chromium/cc/CCPriorityCalculator.cpp:
(WebCore::CCPriorityCalculator::uiPriority):
(WebCore::CCPriorityCalculator::visiblePriority):
(WebCore):
(WebCore::CCPriorityCalculator::renderSurfacePriority):
(WebCore::CCPriorityCalculator::priorityFromDistance):
(WebCore::CCPriorityCalculator::priorityFromVisibility):
- platform/graphics/chromium/cc/CCPriorityCalculator.h:
(CCPriorityCalculator):
Source/WebKit/chromium:
- tests/CCPrioritizedTextureTest.cpp:
(WTF::CCPrioritizedTextureTest::createManager):
(WTF::TEST_F):
(WTF):
- tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeTiledLayerChromium::setTexturePriorities):
(WebKitTests):
- tests/CCTiledLayerTestCommon.h:
(FakeTiledLayerChromium):
- tests/TiledLayerChromiumTest.cpp:
- 1:32 PM Changeset in webkit [121869] by
-
- 4 edits in trunk/Source
[GTK] Enable parallel GC
https://bugs.webkit.org/show_bug.cgi?id=90568
Reviewed by Martin Robinson.
Source/JavaScriptCore:
- runtime/Options.cpp: Include <algorithm.h> for std::min.
Source/WTF:
- wtf/Platform.h: Add GTK to the ENABLE_PARALLEL_GC party.
- 12:23 PM Changeset in webkit [121868] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, skip another two http tests that
timeout and just extend the complete build cycle.
- platform/gtk/TestExpectations:
- 10:47 AM Changeset in webkit [121867] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r121862.
http://trac.webkit.org/changeset/121862
https://bugs.webkit.org/show_bug.cgi?id=90569
It broke built-product-archive for GTK, Qt and EFL (Requested
by svillar on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-04
- BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
- 10:43 AM Changeset in webkit [121866] by
-
- 5 edits2 adds in trunk/Source/WebCore
Text Autosizing: Add basic framework
https://bugs.webkit.org/show_bug.cgi?id=88655
This adds a highly simplified foundation that subsequent Text Autosizing patches
can build upon. I've refactored this code (since the earlier combined diff
uploaded to http://webkit.org/b/84186) to touch as few files as possible.
Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.
No new tests. I plan to add a test framework as my next Text Autosizing patch.
- WebCore.gypi:
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore):
(Document):
(WebCore::Document::textAutosizer):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- rendering/TextAutosizer.cpp: Added.
(WebCore):
(WebCore::TextAutosizer::TextAutosizer):
(WebCore::TextAutosizer::~TextAutosizer):
(WebCore::TextAutosizer::create):
(WebCore::TextAutosizer::boostSubtree):
(WebCore::TextAutosizer::boostBlock):
(WebCore::TextAutosizer::boostText):
(WebCore::TextAutosizer::treatAsInline):
(WebCore::TextAutosizer::traverseNext):
(WebCore::TextAutosizer::cloneRenderStyleWithState):
- rendering/TextAutosizer.h: Added.
(WebCore):
(TextAutosizer):
- 10:39 AM Changeset in webkit [121865] by
-
- 11 edits2 deletes in trunk
Unreviewed, rolling out r121767.
http://trac.webkit.org/changeset/121767
https://bugs.webkit.org/show_bug.cgi?id=89584
Crashes inspected page while recording timeline due to
conflict with BeginFrame in record stack
Source/WebCore:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willProcessTask):
(WebCore::InspectorTimelineAgent::didProcessTask):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._onRecordAdded):
- inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._addRecord):
- inspector/front-end/TimelineModel.js:
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineCategoryStrips.prototype.update.appendRecord):
(WebInspector.TimelineCategoryStrips.prototype.update):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.recordStyle):
(WebInspector.TimelinePresentationModel.categoryForRecord):
(WebInspector.TimelinePresentationModel.forAllRecords):
(WebInspector.TimelinePresentationModel.prototype.addRecord):
LayoutTests:
- inspector/timeline-dfs-expected.txt: Removed.
- inspector/timeline-dfs.html: Removed.
- inspector/timeline/timeline-enum-stability-expected.txt:
- 10:27 AM Changeset in webkit [121864] by
-
- 4 edits in trunk/Source
[chromium] Clear RenderSurfaces still when no idle paint will be done
https://bugs.webkit.org/show_bug.cgi?id=90553
Reviewed by Adrienne Walker.
Source/WebCore:
Currently if idle painting is disabled, updateLayers() will early-out.
But this prevents it from doing cleanup and clearing all RenderSurface
pointers, leaving the layer tree in an unexpected state.
Tests: CCLayerTreeHostTestCompositeAndReadbackCleanup
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTestCompositeAndReadbackCleanup):
(WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::CCLayerTreeHostTestCompositeAndReadbackCleanup):
(WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::beginTest):
(WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::afterTest):
(WTF):
- 10:18 AM Changeset in webkit [121863] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove CCLayerTreeHostTestThreadOnly class to cleanup CCLayerTreeHostTests
https://bugs.webkit.org/show_bug.cgi?id=90556
Reviewed by Adrienne Walker.
Currently many tests that run both single and threaded versions subclass
from CCLayerTreeHostTestThreadOnly just from copy/pasting. The class
only adds a runTestThreaded() which calls runTest(true). Many other
tests do run only in threaded mode call runTest(true) themselves, making
for an inconsistent mess.
We remove CCLayerTreeHostTestThreadOnly class, so we don't have tests
inheriting it that are not thread-only. And now all tests that are
thread-only call runTest(true) consistently.
- tests/CCLayerTreeHostTest.cpp:
(WTF::TEST_F):
- 9:43 AM Changeset in webkit [121862] by
-
- 2 edits in trunk/Tools
Hidden dirs are not copied when creating the built product archive
https://bugs.webkit.org/show_bug.cgi?id=90559
Reviewed by Carlos Garcia Campos.
Hidden dirs are not copied inside the built product archive because
the recursive copy command was ignoring them. We need those hidden
directories for the GTK WebKit2 testing bot to work fine.
- BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): removed the trailing "*" from the copy
command.
- 9:16 AM Changeset in webkit [121861] by
-
- 25 edits in trunk
Text Autosizing: Add compile flag and runtime setting
https://bugs.webkit.org/show_bug.cgi?id=87394
.:
This patch renames Font Boosting to Text Autosizing.
Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.
- configure.ac:
Source/JavaScriptCore:
This patch renames Font Boosting to Text Autosizing.
Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
This patch renames Font Boosting to Text Autosizing and adds compile guards around the runtime setting.
Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.
No functionality yet, so no new tests.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- Target.pri:
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setTextAutosizingEnabled):
- page/Settings.h:
(Settings):
(WebCore::Settings::textAutosizingEnabled):
Source/WebKit/chromium:
This patch renames Font Boosting to Text Autosizing and adds compile guards around the runtime setting.
Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.
- features.gypi:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setTextAutosizingEnabled):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
Source/WebKit/mac:
This patch renames Font Boosting to Text Autosizing.
Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
This patch renames Font Boosting to Text Autosizing.
Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.
- Configurations/FeatureDefines.xcconfig:
Tools:
This patch renames Font Boosting to Text Autosizing.
Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
This patch renames Font Boosting to Text Autosizing.
Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 9:10 AM Changeset in webkit [121860] by
-
- 10 edits2 adds in trunk
Web Inspector: Emulate pseudo styles (hover etc.) of non-selected elements
https://bugs.webkit.org/show_bug.cgi?id=86630
Reviewed by Pavel Feldman.
Source/WebCore:
- A map of pseudo-states for all bound DOM nodes is maintained in the backend and queried whenever StyleResolver
calculates the effective element style.
- In the frontend, markers are introduced to distinguish elements that have forced pseudo styles set for them.
Additionally, dimmed markers are added for collapsed nodes, whose descendants have forced pseudo styles.
More ElementDecorator subtypes will be added for other types of markers.
Test: inspector/styles/force-pseudo-state.html
- English.lproj/localizedStrings.js:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::recalcStyleForPseudoStateIfNeeded):
(WebCore::InspectorCSSAgent::elementForId):
(WebCore::InspectorCSSAgent::didRemoveDocument):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::resetPseudoStates):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._setPseudoClassForNodeId):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype._createNodeDecorators):
(WebInspector.ElementsTreeOutline.prototype.updateOpenCloseTags):
(WebInspector.ElementsTreeOutline.ElementDecorator):
(WebInspector.ElementsTreeOutline.ElementDecorator.prototype.decorate):
(WebInspector.ElementsTreeOutline.ElementDecorator.prototype.decorateAncestor):
(WebInspector.ElementsTreeOutline.PseudoStateDecorator):
(WebInspector.ElementsTreeOutline.PseudoStateDecorator.prototype.decorate):
(WebInspector.ElementsTreeOutline.PseudoStateDecorator.prototype.decorateAncestor):
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateForcedPseudoStateItems):
(WebInspector.ElementsTreeElement.prototype.updateTitle):
(WebInspector.ElementsTreeElement.prototype._createDecoratorElement):
(WebInspector.ElementsTreeElement.prototype._updateDecorations):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype.get forcedPseudoClasses):
(WebInspector.StylesSidebarPane.prototype._updateForcedPseudoStateInputs):
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
- inspector/front-end/elementsPanel.css:
(#elements-content .elements-gutter-decoration):
(#elements-content .elements-gutter-decoration.elements-has-decorated-children):
LayoutTests:
- inspector/styles/force-pseudo-state-expected.txt: Added.
- inspector/styles/force-pseudo-state.html: Added.
- 8:36 AM Changeset in webkit [121859] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix search on the network panel.
https://bugs.webkit.org/show_bug.cgi?id=90557
Reviewed by Vsevolod Vlasov.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):
- 8:31 AM Changeset in webkit [121858] by
-
- 10 edits in trunk/Source/WebCore
Stop tracking line number in tokenizer
https://bugs.webkit.org/show_bug.cgi?id=90544
Reviewed by Adam Barth.
Because SegmentedString knows how to track the current line and column,
a tokenizer does not need to keep track of the current line by itself.
No behavior change, so no new tests.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::lineNumber):
(WebCore::HTMLDocumentParser::textPosition):
- html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::flushBufferedEndTag):
(WebCore):
(WebCore::HTMLTokenizer::nextToken):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processScriptStartTag):
- html/track/WebVTTTokenizer.cpp:
(WebCore::WebVTTTokenizer::reset):
(WebCore::WebVTTTokenizer::nextToken):
- platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase):
- platform/text/SegmentedString.h:
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(SegmentedString):
- xml/parser/MarkupTokenizerBase.h:
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):
(WebCore::MarkupTokenizerBase::emitAndResumeIn):
(WebCore::MarkupTokenizerBase::emitEndOfFile):
(WebCore::MarkupTokenizerBase::reset):
(MarkupTokenizerBase):
- xml/parser/MarkupTokenizerInlineMethods.h:
(WebCore):
- xml/parser/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::nextToken):
- 8:25 AM Changeset in webkit [121857] by
-
- 6 edits in trunk
[CMAKE] Add GENERATE_BINDINGS macro to share the codes which use generate-bindings.pl.
https://bugs.webkit.org/show_bug.cgi?id=90258
Reviewed by Rob Buis.
.:
This new macro calls generate-bindings.pl and append generated sources
into proper source list.
- Source/cmake/WebKitMacros.cmake:
Source/WebCore:
Use GENERATE_BINDINGS instead of using generate-bindings.pl directly.
- UseJSC.cmake:
- UseV8.cmake:
- PlatformBlackBerry.cmake:
- 8:19 AM Changeset in webkit [121856] by
-
- 2 edits in trunk/Tools
[Qt] Replace deprecated IN_PWD with PWD
Reviewed by Csaba Osztrogonác.
- qmake/mkspecs/features/default_pre.prf:
- 8:14 AM Changeset in webkit [121855] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: UISourceCode should take care of adding revision after committing working copy.
https://bugs.webkit.org/show_bug.cgi?id=90549
Reviewed by Pavel Feldman.
Revision is now added in UISourceCode.commitWorkingCopy synchronously even if saving to JS VM or CSS model failed.
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModelResourceBinding.prototype.setStyleContent):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
- inspector/front-end/StylesPanel.js:
(WebInspector.StyleSource.prototype._callOrSetTimeout):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
- inspector/front-end/Workspace.js:
(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodeForURL):
- 8:13 AM Changeset in webkit [121854] by
-
- 2 edits in trunk/Tools
[Qt] Don't try to build WTR twice
Reviewed by Csaba Osztrogonác.
- 8:06 AM Changeset in webkit [121853] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: move settings button back to the right.
https://bugs.webkit.org/show_bug.cgi?id=90552
Reviewed by Vsevolod Vlasov.
- inspector/front-end/inspector.css:
(button.status-bar-item:active, button.status-bar-item.emulate-active):
(button.settings-status-bar-item):
- 7:59 AM Changeset in webkit [121852] by
-
- 6 edits in trunk/Tools
Unreviewed, rolling out r121821.
http://trac.webkit.org/changeset/121821
https://bugs.webkit.org/show_bug.cgi?id=90551
This patch did not receive a high-quality review and has a
number of errors (Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-04
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Build.results_url):
- Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
(ChromiumBuilder.accumulated_results_url):
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand.init):
(Rebaseline):
(Rebaseline._builder_to_pull_from):
(Rebaseline._tests_to_update):
(Rebaseline.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline.mock_builder_to_pull_from):
(test_rebaseline):
- 7:21 AM Changeset in webkit [121851] by
-
- 11 edits in trunk
[Qt] Get rid of un-needed QT += declarative for Qt 5
The declarative module has been renamed to quick1 in Qt 5, and the
engine-only module for Qt 5 is named 'qml'. For many of the instances
we could just remove 'declarative', since the project file was only
used for Qt5/WebKit2 builds. In the other cases the module was wrapped
in a haveQt(4) scope.
Reviewed by Csaba Osztrogonác.
- 7:07 AM Changeset in webkit [121850] by
-
- 12 edits1 delete in trunk/Source/WebCore
Web Inspector: Get rid of ResourceDomainModelBinding and DebuggerResourceBinding, make Resource.setContent private.
https://bugs.webkit.org/show_bug.cgi?id=90531
Reviewed by Pavel Feldman.
Resource.setContent made private. It is delegating now to UISourceCodes which take care of domain specific actions.
DebuggerResourceBinding was be removed and DebuggerResourceBinding.setScriptSource was moved to JavaScriptSource.
ResourceDomainModelBinding was removed as well.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModelResourceBinding):
- inspector/front-end/DebuggerResourceBinding.js: Removed.
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
(WebInspector.JavaScriptSource.prototype._setScriptSource.didEditScriptSource):
(WebInspector.JavaScriptSource.prototype._setScriptSource):
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._setContent):
(WebInspector.Resource.prototype.revertToOriginal):
(WebInspector.Resource.prototype.revertAndClearHistory):
(WebInspector.ResourceRevision.prototype.revertToThis):
- inspector/front-end/StylesPanel.js:
(WebInspector.StyleSource.prototype.isEditable):
- inspector/front-end/UISourceCode.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/Workspace.js:
(WebInspector.Workspace):
- inspector/front-end/inspector.html:
- 6:55 AM Changeset in webkit [121849] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: follow up to r121843, reduce inspector dock timeout to 200ms.
- inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarButton.prototype.makeLongClickEnabled.mouseDown):
- 6:54 AM Changeset in webkit [121848] by
-
- 4 edits in trunk
[Qt] Remove a few un-needed load(features) after r121777
The features are computed by configure.pro and cached in .qmake.cache.
Reviewed by Jocelyn Turcotte.
- 6:48 AM Changeset in webkit [121847] by
-
- 3 edits in trunk/Tools
[Qt] Use haveQtModule() in project files instead of manual checks
Reviewed by Jocelyn Turcotte.
- 6:44 AM Changeset in webkit [121846] by
-
- 2 edits in trunk/Tools
[Qt] Fix haveQtModule() check
Without {} brackets we were pulling out the value of the module.name variable.
Reviewed by Jocelyn Turcotte.
- 6:41 AM Changeset in webkit [121845] by
-
- 2 edits in trunk/Source/WebKit
[Qt] Fix broken OR-operator in project file
Qmake expects |, not . The result was that the block was entered, even if none of the two defines were set to 1.
Reviewed by Jocelyn Turcotte.
- 5:57 AM Changeset in webkit [121844] by
-
- 5 edits in trunk/Source
[chromium] Correctly reject accelerated animations with certain rotations.
https://bugs.webkit.org/show_bug.cgi?id=89768
Reviewed by James Robinson.
Source/WebCore:
UnitTests:
GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
GraphicsLayerChromiumTest.createTransformAnimationWithRotationInvolvingNegativeAngles
GraphicsLayerChromiumTest.createTransformAnimationWithSmallRotationInvolvingLargeAngles
- platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::appendKeyframe):
(WebCore::isRotationType):
(WebCore):
(WebCore::causesRotationOfAtLeast180Degrees):
(WebCore::CCKeyframedTransformAnimationCurve):
(WebCore::createActiveAnimation):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::addAnimation):
Source/WebKit/chromium:
- tests/GraphicsLayerChromiumTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
- 5:53 AM Changeset in webkit [121843] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: "Dock to right" shouldn't be in the settings dialog
https://bugs.webkit.org/show_bug.cgi?id=76917
Reviewed by Vsevolod Vlasov.
Introduced 'long click-enabled' options for status bar buttons. Made dock/undock one of them.
- inspector/front-end/Images/statusbarButtonGlyphs.png:
- inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarButton.prototype._clicked):
(WebInspector.StatusBarButton.prototype.set visible):
(WebInspector.StatusBarButton.prototype.makeLongClickEnabled.mouseDown):
(WebInspector.StatusBarButton.prototype.makeLongClickEnabled.mouseUp):
(WebInspector.StatusBarButton.prototype.makeLongClickEnabled):
(WebInspector.StatusBarButton.prototype._showOptions.mouseOver):
(WebInspector.StatusBarButton.prototype._showOptions.mouseOut):
(WebInspector.StatusBarButton.prototype._showOptions.mouseUp):
(WebInspector.StatusBarButton.prototype._showOptions):
- inspector/front-end/UIUtils.js:
(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
(WebInspector.GlassPane):
(WebInspector.GlassPane.prototype.dispose):
- inspector/front-end/inspector.css:
(.long-click-glyph):
(.long-click-glyph.shadow):
(button.status-bar-item:active:not(.emulate-inactive), button.status-bar-item.emulate-active):
(.alternate-status-bar-buttons-bar):
(.alternate-status-bar-buttons-bar .status-bar-item):
- inspector/front-end/inspector.js:
(WebInspector._createGlobalStatusBarItems):
(WebInspector._createDockOptions.onClick.set else):
(WebInspector._createDockOptions.onClick):
- 5:32 AM Changeset in webkit [121842] by
-
- 5 edits in trunk/LayoutTests
REGRESSION(r121792): inspector/extensions/extensions-resources.html fails
https://bugs.webkit.org/show_bug.cgi?id=90530
Reviewed by Pavel Feldman.
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.InspectorTest.finishDebuggerTest.disableDebugger):
(initialize_DebuggerTest.InspectorTest.finishDebuggerTest.debuggerDisabled):
(initialize_DebuggerTest.InspectorTest.finishDebuggerTest):
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.completeTest):
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest):
- inspector/extensions/extensions-resources-expected.txt:
- inspector/extensions/extensions-resources.html:
- 5:09 AM Changeset in webkit [121841] by
-
- 7 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines after r121789.
- platform/gtk/TestExpectations:
- platform/gtk/css1/formatting_model/floating_elements-expected.png: Added.
- platform/gtk/css1/formatting_model/floating_elements-expected.txt:
- platform/gtk/fast/block/float/010-expected.png:
- platform/gtk/fast/block/float/010-expected.txt:
- platform/gtk/fast/block/float/independent-align-positioning-expected.png:
- platform/gtk/fast/block/float/independent-align-positioning-expected.txt:
- 4:06 AM Changeset in webkit [121840] by
-
- 2 edits in trunk/Tools
[WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library
https://bugs.webkit.org/show_bug.cgi?id=90541
Reviewed by Carlos Garcia Campos.
We must add the contents of WebKitBuild/*/Libraries/ directory to
the file to be uploaded to b.w.o to successfully run WebKit2 tests
in the WebKit2 testing bot.
- BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): appended Libraries to the list of
neededDirectories.
- 2:02 AM Changeset in webkit [121839] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing test.
https://bugs.webkit.org/show_bug.cgi?id=90530
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-07-04
- platform/qt/Skipped: skip inspector/extensions/extensions-resources.html.
- 1:31 AM Changeset in webkit [121838] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Removed some tests from TestExpectations
as they were passing in the tree bots.
- platform/gtk/TestExpectations:
- 1:05 AM Changeset in webkit [121837] by
-
- 2 edits in trunk/Tools
[GTK] WebKit2 testing bot unable to find the build directory
https://bugs.webkit.org/show_bug.cgi?id=90523
Reviewed by Carlos Garcia Campos.
The presence of GNUmakefile was used to determine whether a given
directory was a valid build directory or not. That's not correct for
testing bots as we export only the minimum required stuff to run the
tests.
- gtk/common.py:
(get_build_path.is_valid_build_directory): added an extra check.:
- 12:53 AM Changeset in webkit [121836] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r121813.
http://trac.webkit.org/changeset/121813
https://bugs.webkit.org/show_bug.cgi?id=90522
Causes browser_tests failure:
ErrorPageTest.DNSError_GoBack2{Forward2,AndForward} on
Chromium {Linux,Mac,Win} (Requested by yosin on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-04
Source/WebCore:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):
LayoutTests:
- http/tests/multipart/multipart-replace-non-html-content-expected.txt: Removed.
- http/tests/multipart/multipart-replace-non-html-content.php: Removed.
- 12:33 AM Changeset in webkit [121835] by
-
- 7 edits3 adds in trunk/Source/WebKit2
[EFL][WK2] Ewk_View should report load errors
https://bugs.webkit.org/show_bug.cgi?id=90479
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-04
Reviewed by Kenneth Rohde Christiansen.
The Ewk_View now emits a "load,error" signal when the
main frame fails loading. Information about the error
is provided via the new Ewk_Web_Error type.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_load_error):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_loader_client.cpp:
(didFailLoadWithErrorForFrame):
(ewk_view_loader_client_attach):
- UIProcess/API/efl/ewk_view_private.h:
- UIProcess/API/efl/ewk_web_error.cpp: Added.
(_Ewk_Web_Error):
(ewk_web_error_free):
(ewk_web_error_domain_get):
(ewk_web_error_url_get):
(ewk_web_error_code_get):
(ewk_web_error_description_get):
(ewk_web_error_cancellation_get):
(ewk_web_error_new):
- UIProcess/API/efl/ewk_web_error.h: Added.
- UIProcess/API/efl/ewk_web_error_private.h: Added.
- 12:30 AM Changeset in webkit [121834] by
-
- 2 edits in trunk/Tools
Adding myself to committers list.
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 12:29 AM Changeset in webkit [121833] by
-
- 4 edits in trunk
[EFL] Change format of return value of navigator.language
https://bugs.webkit.org/show_bug.cgi?id=89639
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-04
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Remove encoding type from return value of navigator.language.
For example, from en-US.UTF-8 to en-US.
Use exist test case (fast/js/navigator-language.html).
- platform/efl/LanguageEfl.cpp:
(WebCore::platformLanguage):
LayoutTests:
- platform/efl/TestExpectations: Remove fast/js/navigator-language.html
- 12:03 AM Changeset in webkit [121832] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening for Mac
https://bugs.webkit.org/show_bug.cgi?id=90430
- platform/chromium/TestExpectations: Add TIMEOUT to inspector/timeline/timeline-receive-response-event.html
Jul 3, 2012:
- 11:52 PM Changeset in webkit [121831] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening for Win build
https://bugs.webkit.org/show_bug.cgi?id=90517
- platform/chromium/TestExpectations: Add svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg as flaky on Windows
- 11:34 PM Changeset in webkit [121830] by
-
- 7 edits in trunk
[WK2][EFL] Ewk_View should report the load progress
https://bugs.webkit.org/show_bug.cgi?id=90457
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
The Ewk_View now reports the estimated load progress
of the page via the new "load,progress".
A method is also added to Ewk_View in order to
retrieve the current load progress.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_load_progress_get):
(ewk_view_load_progress_changed):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_loader_client.cpp:
(didChangeProgress):
(ewk_view_loader_client_attach):
- UIProcess/API/efl/ewk_view_private.h:
Tools:
Update EFL MiniBrowser so that it listens for the
"load,progress" on the Ewk_View and updates its
window title accordingly.
- MiniBrowser/efl/main.c:
(title_set):
(on_title_changed):
(on_progress):
(browserCreate):
- 11:18 PM Changeset in webkit [121829] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Don't show accel labels in context menu items
https://bugs.webkit.org/show_bug.cgi?id=90437
Reviewed by Martin Robinson.
When a context menu item is created with a GtkMenuItem that has
been created from a GtkAction, if the action has an accelerator,
it's shown in the menu item label, like menu items in a menu
bar. In that case we should reset the accel closure of the menu
item label, like GtkUIManager does for popup menus, to make sure
the accelerator is not shown. This isn't needed for all other
ContextMenuIem constructors, because the GtkAction is created
without accelerator by webkit in those cases.
- platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
- 10:49 PM Changeset in webkit [121828] by
-
- 4 edits2 moves in trunk/Source
[EFL] Move BatteryClientEfl from WebKit to WebCore
https://bugs.webkit.org/show_bug.cgi?id=90063
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
Move BatteryClientEfl class from WebKit to WebCore
so that it can be reused in WebKit2.
Source/WebCore:
No new tests, no behavior change.
- PlatformEfl.cmake:
- platform/efl/BatteryClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.cpp.
(WebCore):
(WebCore::BatteryClientEfl::BatteryClientEfl):
(WebCore::BatteryClientEfl::setController):
(WebCore::BatteryClientEfl::startUpdating):
(WebCore::BatteryClientEfl::stopUpdating):
(WebCore::BatteryClientEfl::batteryControllerDestroyed):
(WebCore::BatteryClientEfl::setBatteryStatus):
(WebCore::BatteryClientEfl::timerFired):
(WebCore::BatteryClientEfl::getBatteryStatus):
(WebCore::BatteryClientEfl::setBatteryClient):
- platform/efl/BatteryClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.h.
(WebCore):
(BatteryClientEfl):
(WebCore::BatteryClientEfl::~BatteryClientEfl):
(WebCore::BatteryClientEfl::batteryStatus):
Source/WebKit:
- PlatformEfl.cmake:
- 10:44 PM WebKit Team edited by
- (diff)
- 10:19 PM Changeset in webkit [121827] by
-
- 2 edits in trunk/Source/WebCore
Add a comment in order to clarify why
BitmapImage::frameHasAlphaAtIndex returns true as default.
https://bugs.webkit.org/show_bug.cgi?id=90445
Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-03
Reviewed by Eric Seidel.
No new tests. This patch doesn't change behavior.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameHasAlphaAtIndex):
(WebCore):
- 10:00 PM Changeset in webkit [121826] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening for Win build
- platform/chromium/TestExpectations: Add TEXT to http/tests/misc/last-modified-parsing.htl
- 8:27 PM Changeset in webkit [121825] by
-
- 2 edits in trunk/Tools
disable failing mock-chromium-mac python unit tests
Unreviewed, build fix.
Disable these tests until I can figure out why they're failing
on the bots.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.disabled_test_chromium_mac_lion):
(PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
- 7:59 PM Changeset in webkit [121824] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Checkerboard shown when clicking on error page buttons
https://bugs.webkit.org/show_bug.cgi?id=90152
RIM PR #161867
Reviewed by George Staikos.
r121514 just made the race occur in lower possibility but can't avoid it.
This path is using another approach to fix the problem. When we are resetting
backingstore while committing a page we need to suspend backingstore and
screen update to make sure no other threads can update backingstore and screen.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
- 7:34 PM Changeset in webkit [121823] by
-
- 13 edits in trunk/Source
[chromium] Avoid calling getUniformLocation??() in the compositor startup
https://bugs.webkit.org/show_bug.cgi?id=90217
Patch by Alex Sakhartchouk <alexst@chromium.org> on 2012-07-03
Reviewed by Adrienne Walker.
Source/Platform:
Adding an entry point for bindUniformLocationCHROMIUM.
- chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::bindUniformLocationCHROMIUM):
Source/WebCore:
This change allows chrome compositor to bind uniform locations instead of querying
them from the graphics context by using GL_CHROMIUM_bind_uniform_location.
The extention itself is tested in chromium and the change in webkit simply adds
plumbing to allow its usage. Existing pixel tests would be able to verify proper behaviour.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tileCheckerboardProgram):
(WebCore::LayerRendererChromium::solidColorProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderPassProgram):
(WebCore::LayerRendererChromium::renderPassProgramAA):
(WebCore::LayerRendererChromium::renderPassMaskProgram):
(WebCore::LayerRendererChromium::renderPassMaskProgramAA):
(WebCore::LayerRendererChromium::tileProgram):
(WebCore::LayerRendererChromium::tileProgramOpaque):
(WebCore::LayerRendererChromium::tileProgramAA):
(WebCore::LayerRendererChromium::tileProgramSwizzle):
(WebCore::LayerRendererChromium::tileProgramSwizzleOpaque):
(WebCore::LayerRendererChromium::tileProgramSwizzleAA):
(WebCore::LayerRendererChromium::textureProgram):
(WebCore::LayerRendererChromium::textureProgramFlip):
(WebCore::LayerRendererChromium::textureIOSurfaceProgram):
(WebCore::LayerRendererChromium::videoYUVProgram):
(WebCore::LayerRendererChromium::videoStreamTextureProgram):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/ProgramBinding.cpp:
(WebCore::ProgramBindingBase::ProgramBindingBase):
(WebCore::ProgramBindingBase::~ProgramBindingBase):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::link):
(WebCore):
(WebCore::ProgramBindingBase::cleanup):
(WebCore::ProgramBindingBase::createShaderProgram):
(WebCore::ProgramBindingBase::cleanupShaders):
- platform/graphics/chromium/ProgramBinding.h:
(ProgramBindingBase):
(WebCore::ProgramBinding::initialize):
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderPosTex::init):
(WebCore::VertexShaderPosTexYUVStretch::init):
(WebCore::VertexShaderPos::init):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderTile::init):
(WebCore::VertexShaderVideoTransform::init):
(WebCore::FragmentTexAlphaBinding::init):
(WebCore::FragmentTexOpaqueBinding::init):
(WebCore::FragmentShaderOESImageExternal::init):
(WebCore::FragmentShaderRGBATexAlphaAA::init):
(WebCore::FragmentTexClampAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderYUVVideo::init):
(WebCore::FragmentShaderColor::init):
(WebCore::FragmentShaderCheckerboard::init):
- platform/graphics/chromium/ShaderChromium.h:
(VertexShaderPosTex):
(VertexShaderPosTexYUVStretch):
(VertexShaderPos):
(WebCore::VertexShaderPosTexIdentity::init):
(VertexShaderPosTexTransform):
(VertexShaderQuad):
(VertexShaderTile):
(VertexShaderVideoTransform):
(FragmentTexAlphaBinding):
(FragmentTexOpaqueBinding):
(FragmentShaderOESImageExternal):
(FragmentShaderRGBATexAlphaAA):
(FragmentTexClampAlphaAABinding):
(FragmentShaderRGBATexAlphaMask):
(FragmentShaderRGBATexAlphaMaskAA):
(FragmentShaderYUVVideo):
(FragmentShaderColor):
(FragmentShaderCheckerboard):
- platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):
- platform/graphics/chromium/TextureCopier.h:
(WebCore::AcceleratedTextureCopier::create):
(AcceleratedTextureCopier):
Source/WebKit/chromium:
Fixing the build error.
- tests/TextureCopierTest.cpp:
- 7:23 PM Changeset in webkit [121822] by
-
- 2 edits in trunk/Tools
Add vollick to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=90512
Reviewed by Adrienne Walker.
- Scripts/webkitpy/common/config/committers.py:
- 7:13 PM Changeset in webkit [121821] by
-
- 6 edits in trunk/Tools
Improve webkit-patch rebaseline to work for more cases
https://bugs.webkit.org/show_bug.cgi?id=90504
Reviewed by Dirk Pranke.
-Makes it work for the build.chromium.org bots.
-Lets you rebaseline all builders instead of just one.
-Lets you pass in the builder or test to rebaseline.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Build.results_url):
Make this work for build.chromium.org builders as well.
- Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
(ChromiumBuilder):
(ChromiumBuilder.latest_cached_build):
ChromiumBuilder doesn't support large parts of the Builder interface.
This provides the bare minimum for this patch to work. Eventually,
we should create a single interface that can be supported for both
sets of buildbots.
- Scripts/webkitpy/layout_tests/port/builders.py:
(builder_path_from_name):
(all_builder_names):
memoizing here is incorrect because the test override _exact_matches,
so these can return different values. In either case, I'm pretty sure these
are not remotely hot codepaths.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand.init):
(Rebaseline):
(Rebaseline.init):
(Rebaseline._builders_to_pull_from):
(Rebaseline._builder_with_name):
(Rebaseline._tests_to_update):
(Rebaseline.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline.mock_builders_to_pull_from):
(test_rebaseline):
(test_rebaseline_command_line_flags):
(test_rebaseline_multiple_builders):
(test_rebaseline_multiple_builders.mock_builders_to_pull_from):
(test_rebaseline_multiple_builders.mock_tests_to_update):
- 7:05 PM Changeset in webkit [121820] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Rebaseline: svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml
- platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
- 6:56 PM Changeset in webkit [121819] by
-
- 5 edits in trunk
[EFL] Enable CSS variables support at compile time
https://bugs.webkit.org/show_bug.cgi?id=90448
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
Turn on CSS_VARIABLES flag by default on EFL port.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmakeconfig.h.cmake:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 6:05 PM WebKit Team edited by
- Adding Ian Vollick to the list of committers. (diff)
- 5:47 PM Changeset in webkit [121818] by
-
- 5 edits in trunk/Source
[V8] Remove enableFasterDOMStoreAccess which is never used
https://bugs.webkit.org/show_bug.cgi?id=90489
Reviewed by Adam Barth.
Source/WebCore:
No new tests. Dead code removal.
- bindings/v8/V8DOMMap.cpp:
- bindings/v8/V8DOMMap.h:
(WebCore):
Source/WebKit/chromium:
- src/WebScriptController.cpp:
(WebKit::WebScriptController::enableV8SingleThreadMode):
- 5:23 PM Changeset in webkit [121817] by
-
- 9 edits in trunk/Source/WebCore
Binding: IDL type DOMString[] shouldn't match null
https://bugs.webkit.org/show_bug.cgi?id=84217
Reviewed by Kentaro Hara.
Similar to r121714, IDL overloads with T[] (which is only minimally supported)
were being treated as Nullable by default during overloaded method dispatching,
which deviates from the WebIDL specification. Extend the previous change to
look for Nullable (specified by "?" type suffix in the IDL) for array types.
Also, after inspection of the spec, use a strict "is this an Array?" test in
the JS generator rather than an "inherits from Array.prototype?" test, to
match the WebIDL spec.
IDL files with affected overloads are modified to include the "?" suffix
so that no behavior changes are introduced by this patch - the JS and V8
generator results before/after the change show no diffs apart from the stricter
isJSArray() test.
Test: bindings/scripts/test/TestObj.idl (a non-Nullable T[] overload)
- Modules/indexeddb/IDBDatabase.idl: Tag T[] overloads with ? suffix.
- Modules/indexeddb/IDBObjectStore.idl: Ditto.
- Modules/vibration/NavigatorVibration.idl: Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Check isNullable for T[].
(GenerateParametersCheckExpression):
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateParametersCheckExpression):
- bindings/scripts/test/JS/JSTestObj.cpp: Rebaselined.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod9):
(WebCore):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
- bindings/scripts/test/TestObj.idl: Tag existing T[] with ?, add non-? T[].
- bindings/scripts/test/V8/V8TestObj.cpp: Rebaselined.
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::overloadedMethodCallback):
- 5:14 PM Changeset in webkit [121816] by
-
- 6 edits in trunk/Tools
nrwt: clean up exception handling and make sure we log some more failures
https://bugs.webkit.org/show_bug.cgi?id=90503
Reviewed by Ojan Vafai.
There were several places where exceptions weren't getting
logged, most notably if you passed a bad value to --platform.
This change tests that and cleans things up a bit; more cleanup
will be possible when we rework the manager_worker_broker code.
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_BrokerConnection.raise_exception):
(_InlineWorkerConnection.raise_exception):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.run):
(Worker.kill_driver):
- Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory.get):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_unsupported_platfrom):
- 5:03 PM Changeset in webkit [121815] by
-
- 2 edits in trunk/LayoutTests
Parameter 'id' is not used in getUserModifyProperty() of fast/dom/shadow/user-modify-inheritance.html.
https://bugs.webkit.org/show_bug.cgi?id=90434
Reviewed by Ryosuke Niwa.
- fast/dom/shadow/user-modify-inheritance.html:
- 5:01 PM Changeset in webkit [121814] by
-
- 2 edits1 delete in trunk/LayoutTests
eventSender.beginDragWithFiles had been implemented in Windows, related tests should be removed from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=87610
Patch by Xueqing Huang <huangxueqing@baidu.com> on 2012-07-03
Reviewed by Jessie Berlin.
- platform/win/Skipped:
- platform/win/fast/dom/Window: Removed.
- platform/win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Removed.
- 4:54 PM Changeset in webkit [121813] by
-
- 4 edits2 adds in trunk
Source/WebCore: REGRESSION (r115654): Sometimes does not replace content for multipart/x-mixed-replace
https://bugs.webkit.org/show_bug.cgi?id=88436
Reviewed by Brady Eidson.
Test: http/tests/multipart/multipart-replace-non-html-content.php
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData): We should only send receivedFirstData() once per main resource load,
rather than multiple times in a multipart load.
(WebCore::DocumentLoader::setupForReplaceByMIMEType): m_gotFirstByte isn't set to true until data is
actually committed, and multipart data is often not committed until the part is finished. Check
whether the SharedBuffer is non-null instead.
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): The JSInternals object my have already been cleared if the window shell
was cleared as part of creation of a new Document. Check it before using it.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=88436.
Reviewed by Brady Eidson.
- http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
- http/tests/multipart/multipart-replace-non-html-content.php: Added.
- 4:53 PM Changeset in webkit [121812] by
-
- 7 edits in trunk/Tools
nrwt: fix mock port
https://bugs.webkit.org/show_bug.cgi?id=90500
Reviewed by Ojan Vafai.
The MockDRT code was never updated when we switched the chromium
ports to using "drt mode" by default. This change updates that
code, fixes a typo in the chromium port that went undetected
(default_test_timeout_ms -> default_timeout_ms), and adds tests
that actually exercise some of the mock ports. These tests are
useful in that they will exercise the port-specific code in an
end-to-end-manner, but they are a bit slow for some reason (>1s
each) that I need to look into.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.stop):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.default_timeout_ms):
- Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(TestChromiumAndroidPort.test_default_timeout_ms):
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
(main):
(parse_options):
(MockTestShell):
(MockTestShell.output_for_test):
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTTest.assertTest):
(MockTestShellTest):
(MockTestShellTest.make_drt):
(MockTestShellTest.test_test_shell_parse_options):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest):
(PortTest.assert_mock_port_works):
(PortTest.test_chromium_mac_lion):
(PortTest.test_chromium_mac_lion_in_test_shell_mode):
(PortTest.test_qt_linux):
(PortTest.test_mac_lion):
- 4:47 PM Changeset in webkit [121811] by
-
- 1 copy in tags/Safari-534.57.6
New Tag.
- 4:40 PM Changeset in webkit [121810] by
-
- 4 edits2 copies in trunk/Source/WebCore
Add AudioFIFO class and simplify AudioPullFIFO
https://bugs.webkit.org/show_bug.cgi?id=90398
Patch by Raymond Toy <Raymond Toy> on 2012-07-03
Reviewed by Chris Rogers.
No new tests. This code will be used in audio back-end implementation.
Add AudioFIFO class to implement main parts of FIFO. Simplify
implementation of AudioPushFIFO by using AudioFIFO.
- WebCore.gypi: Add new files.
New AudioFIFO class
- platform/audio/AudioFIFO.cpp: Copied from Source/WebCore/platform/audio/AudioPullFIFO.cpp.
(WebCore):
(WebCore::AudioFIFO::AudioFIFO):
(WebCore::AudioFIFO::consume):
(WebCore::AudioFIFO::push):
(WebCore::AudioFIFO::findWrapLengths):
- platform/audio/AudioFIFO.h: Copied from Source/WebCore/platform/audio/AudioPullFIFO.h.
(WebCore):
(AudioFIFO):
(WebCore::AudioFIFO::framesInFifo):
(WebCore::AudioFIFO::updateIndex):
Use AudioFIFO
- platform/audio/AudioPullFIFO.cpp:
(WebCore::AudioPullFIFO::AudioPullFIFO):
(WebCore::AudioPullFIFO::consume):
(WebCore::AudioPullFIFO::fillBuffer):
- platform/audio/AudioPullFIFO.h:
(AudioPullFIFO):
- 4:31 PM Changeset in webkit [121809] by
-
- 4 edits in trunk/Tools
nrwt: make the worker class stand alone with a cleaner interface
https://bugs.webkit.org/show_bug.cgi?id=90409
Reviewed by Ojan Vafai.
Currently the Worker class derives from AbstractWorker, which is
kind of crufty and awkward; it would be better if we did not
rely on shared state.
This change changes that so that Worker derives from object, and
exposes the following interface:
init() - called in the manager process
safe_init() - called in the worker process to initialize
unpicklable state
handle() - a single routine to handle all messages
cleanup() - called so the worker can clean up
Also, all of the "administrative" messages that are handled by
the worker (notification of start/stop/etc.) move into
manager_worker_broker - this reduces worker.py to just handling
the mechanics of actually running each test.
For the moment, we do this by creating Yet Another wrapper/proxy
class in manager_worker_broker, but this will get simpler
shortly when the rest of m_w_b is cleaned up.
With this change worker is now in its new form but there will be
a follow-on change that cleans up some names and other minor
things.
This change is again mostly just moving things around and should
be covered by the (updated) existing tests.
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get):
(AbstractWorker.init):
(AbstractWorker.run):
(AbstractWorker):
(AbstractWorker.handle_stop):
(AbstractWorker.handle_test_list):
(AbstractWorker.yield_to_broker):
(AbstractWorker.post_message):
(_WorkerConnection.init):
(_Process.run):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker):
(_TestWorker.init):
(_TestWorker.name):
(_TestWorker.cleanup):
(_TestWorker.handle):
(_TestWorker.safe_init):
(_TestWorker.stop):
(_TestsMixin.handle_finished_test):
(_TestsMixin.setUp):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker):
(Worker.init):
(Worker.safe_init):
(Worker.handle):
- 4:31 PM Changeset in webkit [121808] by
-
- 13 edits15 adds in trunk/Source/WebKit2
[WK2] Add support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=89558
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-03
Reviewed by Anders Carlsson.
Add support for Battery Status API to WebKit2.
- CMakeLists.txt:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Platform/CoreIPC/MessageID.h:
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- Shared/WebBatteryStatus.cpp: Added.
(WebKit):
(WebKit::WebBatteryStatus::WebBatteryStatus):
(WebKit::WebBatteryStatus::~WebBatteryStatus):
(WebKit::WebBatteryStatus::Data::encode):
(WebKit::WebBatteryStatus::Data::decode):
- Shared/WebBatteryStatus.h: Added.
(WebKit):
(WebBatteryStatus):
(Data):
(WebKit::WebBatteryStatus::create):
(WebKit::WebBatteryStatus::isCharging):
(WebKit::WebBatteryStatus::chargingTime):
(WebKit::WebBatteryStatus::dischargingTime):
(WebKit::WebBatteryStatus::level):
(WebKit::WebBatteryStatus::data):
(WebKit::WebBatteryStatus::type):
- Target.pri:
- UIProcess/API/C/WKAPICast.h:
(WebKit):
- UIProcess/API/C/WKBatteryManager.cpp: Added.
(WKBatteryManagerGetTypeID):
- UIProcess/API/C/WKBatteryManager.h: Added.
- UIProcess/WebBatteryManagerProxy.cpp: Added.
(WebKit):
(WebKit::WebBatteryManagerProxy::create):
(WebKit::WebBatteryManagerProxy::WebBatteryManagerProxy):
(WebKit::WebBatteryManagerProxy::~WebBatteryManagerProxy):
(WebKit::WebBatteryManagerProxy::invalidate):
(WebKit::WebBatteryManagerProxy::initializeProvider):
(WebKit::WebBatteryManagerProxy::didReceiveMessage):
(WebKit::WebBatteryManagerProxy::startUpdating):
(WebKit::WebBatteryManagerProxy::stopUpdating):
(WebKit::WebBatteryManagerProxy::providerDidChangeBatteryStatus):
(WebKit::WebBatteryManagerProxy::providerUpdateBatteryStatus):
- UIProcess/WebBatteryManagerProxy.h: Added.
(CoreIPC):
(WebKit):
(WebBatteryManagerProxy):
(WebKit::WebBatteryManagerProxy::clearContext):
(WebKit::WebBatteryManagerProxy::type):
- UIProcess/WebBatteryManagerProxy.messages.in: Added.
- UIProcess/WebBatteryProvider.cpp: Added.
(WebKit):
(WebKit::WebBatteryProvider::startUpdating):
(WebKit::WebBatteryProvider::stopUpdating):
- UIProcess/WebBatteryProvider.h: Added.
(WebKit):
(WebBatteryProvider):
- WebKit2.pri:
- WebProcess/Battery/WebBatteryManager.cpp: Added.
(WebKit):
(WebKit::WebBatteryManager::WebBatteryManager):
(WebKit::WebBatteryManager::~WebBatteryManager):
(WebKit::WebBatteryManager::didReceiveMessage):
(WebKit::WebBatteryManager::registerWebPage):
(WebKit::WebBatteryManager::unregisterWebPage):
(WebKit::WebBatteryManager::didChangeBatteryStatus):
(WebKit::WebBatteryManager::updateBatteryStatus):
- WebProcess/Battery/WebBatteryManager.h: Added.
(CoreIPC):
(WebKit):
(WebBatteryManager):
- WebProcess/Battery/WebBatteryManager.messages.in: Added.
- WebProcess/WebCoreSupport/WebBatteryClient.cpp: Added.
(WebKit):
(WebKit::WebBatteryClient::startUpdating):
(WebKit::WebBatteryClient::stopUpdating):
(WebKit::WebBatteryClient::batteryControllerDestroyed):
- WebProcess/WebCoreSupport/WebBatteryClient.h: Added.
(WebKit):
(WebBatteryClient):
(WebKit::WebBatteryClient::WebBatteryClient):
(WebKit::WebBatteryClient::~WebBatteryClient):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):
- WebProcess/WebProcess.h:
(WebProcess):
(WebKit::WebProcess::batteryManager):
- 4:11 PM Changeset in webkit [121807] by
-
- 4 edits in trunk/Tools
nrwt: moving child process logging code into manager_worker_broker
https://bugs.webkit.org/show_bug.cgi?id=90408
Reviewed by Ojan Vafai.
Users of manager_worker_broker should not have to be aware of
whether they're in the same process or different processes and
configure logging themselves; mwb should hide this complexity.
We can't quite do this completely/correctly yet, since the
manager expects to get a list of messages to log, but this
change fixes the worker side of it, at least.
This is just moving code around, there is no new functionality
and this should be covered by existing tests.
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(AbstractWorker.init):
(_WorkerConnection.init):
(_WorkerConnection.post_message):
(_WorkerConnection):
(_WorkerConnection.set_up_logging):
(_WorkerConnection.clean_up_logging):
(_InlineWorkerConnection.run):
(_MultiProcessWorkerConnection.run):
(_WorkerLogHandler):
(_WorkerLogHandler.init):
(_WorkerLogHandler.emit):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker.run):
(_TestsMixin.handle_done):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.init):
(Worker.run):
(Worker._run_test):
(Worker.cleanup):
(Worker.run_single_test):
- 3:57 PM Changeset in webkit [121806] by
-
- 7 edits in trunk/Source/JavaScriptCore
Enh: Hash Const JSString in Backing Stores to Save Memory
https://bugs.webkit.org/show_bug.cgi?id=86024
Reviewed by Oliver Hunt.
During garbage collection, each marking thread keeps a HashMap of
strings. While visiting via MarkStack::copyAndAppend(), we check to
see if the string we are visiting is already in the HashMap. If not
we add it. If so, we change the reference to the current string we're
visiting to the prior string.
To reduce the performance impact of this change, two throttles have
ben added. 1) We only try hash consting if a significant number of new
strings have been created since the last hash const. Currently this is
set at 100 strings. 2) If a string is unique at the end of a marking
it will not be checked during further GC phases. In some cases this
won't catch all duplicates, but we are trying to catch the growth of
duplicate strings.
- heap/Heap.cpp:
(JSC::Heap::markRoots):
- heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::resetChildren):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::setup): Check to see if enough strings have been created
to hash const.
(JSC::MarkStack::reset): Added call to clear m_uniqueStrings.
(JSC::JSString::tryHashConstLock): New method to lock JSString for
hash consting.
(JSC::JSString::releaseHashConstLock): New unlock method.
(JSC::JSString::shouldTryHashConst): Set of checks to see if we should
try to hash const the string.
(JSC::MarkStack::internalAppend): New method that performs the hash consting.
(JSC::SlotVisitor::copyAndAppend): Changed to call the new hash
consting internalAppend().
- heap/MarkStack.h:
(MarkStackThreadSharedData):
(MarkStack):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::haveEnoughNewStringsToHashConst):
(JSC::JSGlobalData::resetNewStringsSinceLastHashConst):
- runtime/JSString.h:
(JSString): Changed from using bool flags to using an unsigned
m_flags field. This works better with the weakCompareAndSwap in
JSString::tryHashConstLock(). Changed the 8bitness setting and
checking to use new accessors.
(JSC::JSString::JSString):
(JSC::JSString::finishCreation):
(JSC::JSString::is8Bit): Updated for new m_flags.
(JSC::JSString::setIs8Bit): New setter.
New hash const flags accessors:
(JSC::JSString::isHashConstSingleton):
(JSC::JSString::clearHashConstSingleton):
(JSC::JSString::setHashConstSingleton):
(JSC::JSRopeString::finishCreation):
(JSC::JSRopeString::append):
- 2:56 PM Changeset in webkit [121805] by
-
- 5 edits5 adds in trunk/LayoutTests
Unreviewed chromium mac rebaselines.
- platform/chromium-mac-snowleopard/css1/formatting_model/floating_elements-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/block/float/010-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/010-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/block/float/independent-align-positioning-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/independent-align-positioning-expected.txt: Added.
- platform/chromium-mac/fast/block/float/010-expected.png:
- platform/chromium-mac/fast/block/float/010-expected.txt: Added.
- platform/chromium-mac/fast/block/float/independent-align-positioning-expected.png:
- platform/chromium-mac/fast/block/float/independent-align-positioning-expected.txt: Added.
- 2:44 PM Changeset in webkit [121804] by
-
- 2 edits in trunk/Source/WTF
[BlackBerry] Turn on DFGJIT in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=90482
Set ENABLE_DFG_JIT for PLATFORM(BLACKBERRY).
Patch by Yong Li <yoli@rim.com> on 2012-07-03
Reviewed by Rob Buis.
- wtf/Platform.h:
- 2:37 PM Changeset in webkit [121803] by
-
- 2 edits in trunk/Source/WebCore
Protect this DocumentThreadableLoader in cancel() to handle reentrancy properly.
https://bugs.webkit.org/show_bug.cgi?id=90483
Reviewed by Abhishek Arya.
No new tests, covered by http/tests/xmlhttprequest/reentrant-cancel.html
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::cancel):
- 2:02 PM Changeset in webkit [121802] by
-
- 2 edits in trunk/Tools
[chromium] Don't archive build files generated by VS2010
https://bugs.webkit.org/show_bug.cgi?id=90493
Reviewed by Ojan Vafai.
In particular, the pch (pre compiled header) files are gigantic, making
release.zip almost a 1gb in size.
- BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
- 1:26 PM Changeset in webkit [121801] by
-
- 16 edits in trunk
[chromium] Unreviewed, update .gitignore to handle VS2010 files.
Source/JavaScriptCore:
- JavaScriptCore.gyp/.gitignore:
Source/Platform:
- Platform.gyp/.gitignore:
Source/ThirdParty:
- glu/.gitignore:
Source/WebCore:
- WebCore.gyp/.gitignore:
Source/WebKit/chromium:
- .gitignore:
Source/WTF:
- WTF.gyp/.gitignore:
Tools:
- .gitignore:
- DumpRenderTree/DumpRenderTree.gyp/.gitignore:
- TestWebKitAPI/TestWebKitAPI.gyp/.gitignore:
- 1:23 PM Changeset in webkit [121800] by
-
- 4 edits in trunk/Tools
Have webkit-patch rebaseline use rebaseline-test-internal
https://bugs.webkit.org/show_bug.cgi?id=90491
Reviewed by Dirk Pranke.
This lets it handle new files, reduces duplicate code and lays the
groundwork for making rebaseline have a richer interface.
- Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
(MockBuild):
(MockBuild.init):
(MockBuilder.build):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand._files_to_add):
(Rebaseline):
(Rebaseline._builder_to_pull_from):
(Rebaseline._tests_to_update):
(Rebaseline.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_overrides_are_included_correctly):
(test_rebaseline):
(test_rebaseline.mock_builder_to_pull_from):
(test_rebaseline.mock_tests_to_update):
- 12:30 PM Changeset in webkit [121799] by
-
- 3 edits in trunk/Tools
Rename rebaseline-test to rebaseline-test-internal
https://bugs.webkit.org/show_bug.cgi?id=90485
Reviewed by Adam Barth.
It's now only used by other rebaseline commands. It's still useful to leave it
as it's own command to aid in debugging when something goes wrong. In a followup
patch, I'll make webkit-patch rebaseline cover any use-cases that rebaseline-test
might have covered.
We no longer need the --print-scm-changes option since the only caller always passes
that option in.
Also, make all the arguments command-line flags instead. Simplifies the code
a bit in my opinion.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest):
(RebaselineTest.init):
(RebaselineTest.execute):
(AbstractParallelRebaselineCommand._rebaseline_commands):
(RebaselineExpectations.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_all):
- 12:19 PM Changeset in webkit [121798] by
-
- 23 edits in trunk/Source/JavaScriptCore
Add ability to symbolically set and dump JSC VM options.
See comments in runtime/Options.h for details on how the options work.
https://bugs.webkit.org/show_bug.cgi?id=90420
Patch by Mark Lam <mark.lam@apple.com> on 2012-07-03
Reviewed by Filip Pizlo.
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
- assembler/LinkBuffer.h:
(JSC):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::reoptimizationRetryCounter):
(JSC::CodeBlock::countReoptimization):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
(JSC::CodeBlock::exitCountThresholdForReoptimization):
(JSC::CodeBlock::exitCountThresholdForReoptimizationFromLoop):
- bytecode/ExecutionCounter.h:
(JSC::ExecutionCounter::clippedThreshold):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
- dfg/DFGCapabilities.h:
(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):
- dfg/DFGCommon.h:
(JSC::DFG::shouldShowDisassembly):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
- heap/MarkStack.cpp:
(JSC::MarkStackSegmentAllocator::allocate):
(JSC::MarkStackSegmentAllocator::shrinkReserve):
(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
- heap/MarkStack.h:
(JSC::MarkStack::mergeOpaqueRootsIfProfitable):
(JSC::MarkStack::addOpaqueRoot):
- heap/SlotVisitor.h:
(JSC::SlotVisitor::donate):
- jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
- jsc.cpp:
(printUsageStatement):
(parseArguments):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSGlobalData.cpp:
(JSC::enableAssembler):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
- runtime/Options.cpp:
(JSC):
(JSC::overrideOptionWithHeuristic):
(JSC::Options::initialize):
(JSC::Options::setOption):
(JSC::Options::dumpAllOptions):
(JSC::Options::dumpOption):
- runtime/Options.h:
(JSC):
(Options):
(EntryInfo):
- 12:12 PM Changeset in webkit [121797] by
-
- 2 edits in trunk/Source/WebCore
[Gtk][Gamepads] 'warning: comparison is always true due to limited range of data type [-Wtype-limits]' in GamepadsGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=90477
Reviewed by Martin Robinson.
Vector::find() returns value of type size_t, springing errors when
assigning the value to a variable of type unsigned. Use size_t type
for that variable instead.
No new tests - no changed functionality.
- platform/gtk/GamepadsGtk.cpp:
(WebCore::GamepadsGtk::unregisterDevice):
- 12:08 PM Changeset in webkit [121796] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, give a bug number to slow inspector tests and
move into the slow section.
- platform/chromium/TestExpectations:
- 12:07 PM Changeset in webkit [121795] by
-
- 2 edits in trunk/Source/WebCore
Fix LayoutUnit usage in RenderImage::imageDimensionsChanged
https://bugs.webkit.org/show_bug.cgi?id=90173
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-03
Reviewed by Eric Seidel.
The appropriate type should be used for storing width() and height() into local temporary variables.
No new tests, no change in behavior.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
- 12:04 PM Changeset in webkit [121794] by
-
- 8 edits in trunk/LayoutTests
Suppress tests requiring rebaselining after r121789
Unreviewed, gardening.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/Skipped:
- platform/qt/TestExpectations:
- platform/win/Skipped:
- 11:59 AM Changeset in webkit [121793] by
-
- 2 edits in trunk/Source/WebCore
[TextureMapper] Typo in edge-distance anti-aliasing code
https://bugs.webkit.org/show_bug.cgi?id=90475
Patch by Sergio Villar Senin <svillar@igalia.com> on 2012-07-03
Reviewed by Martin Robinson.
No new tests. This just fixes a typo.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawQuad):
- 10:51 AM Changeset in webkit [121792] by
-
- 10 edits in trunk
Web Inspector: [Extensions API] Resource manipulations should be based on UISourceCode thus extending Sources Panel.
https://bugs.webkit.org/show_bug.cgi?id=89868
Reviewed by Pavel Feldman.
Source/WebCore:
Extensions API is now based on both ScriptsPanel acting as a UISourceCodeProvider and ResourceTreeModel.
Extensions API resource could be for any content provider now.
Extensions API resource.setContent implementation is now based on UISourceCode editing methods.
Drive-by StyleSource insremental editing timeout fix.
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._makeResource):
(WebInspector.ExtensionServer.prototype._onGetPageResources):
(WebInspector.ExtensionServer.prototype._getResourceContent):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype._notifyResourceContentCommitted):
- inspector/front-end/JavaScriptSource.js:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.uiSourceCodes):
(WebInspector.ScriptsPanel.prototype.uiSourceCodeForURL):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
- inspector/front-end/StylesPanel.js:
(WebInspector.StyleSource.prototype.workingCopyCommitted):
(WebInspector.StyleSource.prototype.workingCopyChanged):
(WebInspector.StyleSource.prototype._callOrSetTimeout):
(WebInspector.StyleSource.prototype._commitIncrementalEdit):
(WebInspector.StyleSource.prototype._clearIncrementalUpdateTimer):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.workingCopy):
(WebInspector.UISourceCode.prototype.setWorkingCopy):
(WebInspector.UISourceCode.prototype.isDirty):
LayoutTests:
- http/tests/inspector/extensions-test.js:
(initialize_ExtensionsTest):
(initialize_ExtensionsTest.completeTest):
(initialize_ExtensionsTest.InspectorTest.runExtensionTests):
- http/tests/inspector/resources/extension-main.js:
- inspector/extensions/extensions-resources.html:
- inspector/styles/styles-history.html:
- 10:49 AM Changeset in webkit [121791] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 10:47 AM Changeset in webkit [121790] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Anonymous scripts (evals) should not be added to Workspace.
https://bugs.webkit.org/show_bug.cgi?id=90467
Reviewed by Pavel Feldman.
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
- 10:41 AM Changeset in webkit [121789] by
-
- 7 edits43 adds in trunk
CSS 2.1 failure: floats-wrap-top-below-inline-* fail
https://bugs.webkit.org/show_bug.cgi?id=88171
Reviewed by Eric Seidel.
Source/WebCore:
When shifting a line or element left or right to avoid a float use the height
of the line or element to determine whether the float is inside the element or
if it overlaps the bottom of the element.
Do this by passing the height of the element to the interval tree used to detect
the overlap with it's containing block's floats. The height is zero by default so
callers to logical[Left|Right]OffsetForLine will need to pass the height if they
want to use it to detect floats to avoid.
Tests: css2.1/20110323/floats-wrap-top-below-bfc-001l.htm
css2.1/20110323/floats-wrap-top-below-bfc-001r.htm
css2.1/20110323/floats-wrap-top-below-bfc-002l.htm
css2.1/20110323/floats-wrap-top-below-bfc-002r.htm
css2.1/20110323/floats-wrap-top-below-bfc-003l.htm
css2.1/20110323/floats-wrap-top-below-bfc-003r.htm
css2.1/20110323/floats-wrap-top-below-inline-001l.htm
css2.1/20110323/floats-wrap-top-below-inline-001r.htm
css2.1/20110323/floats-wrap-top-below-inline-002l.htm
css2.1/20110323/floats-wrap-top-below-inline-002r.htm
css2.1/20110323/floats-wrap-top-below-inline-003l.htm
css2.1/20110323/floats-wrap-top-below-inline-003r.htm
css2.1/20110323/floats-zero-height-wrap-001.htm
css2.1/20110323/floats-zero-height-wrap-002.htm
fast/block/float/floats-wrap-inside-inline-001.htm
fast/block/float/floats-wrap-inside-inline-002.htm
fast/block/float/floats-wrap-inside-inline-003.htm
fast/block/float/floats-wrap-inside-inline-004.htm
fast/block/float/floats-wrap-inside-inline-005.htm
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::getClearDelta):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::startOffsetForLine):
(WebCore::RenderBlock::endOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(RenderBlock):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(FloatIntervalSearchAdapter):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::logicalBottomForLine):
(WebCore):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
LayoutTests:
- css2.1/20110323/floats-wrap-top-below-001l-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-001r-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-002l-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-002r-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-003l-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-003r-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-bfc-001l-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-bfc-001l.htm: Added.
- css2.1/20110323/floats-wrap-top-below-bfc-001r-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-bfc-001r.htm: Added.
- css2.1/20110323/floats-wrap-top-below-bfc-002l-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-bfc-002l.htm: Added.
- css2.1/20110323/floats-wrap-top-below-bfc-002r-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-bfc-002r.htm: Added.
- css2.1/20110323/floats-wrap-top-below-bfc-003l-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-bfc-003l.htm: Added.
- css2.1/20110323/floats-wrap-top-below-bfc-003r-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-bfc-003r.htm: Added.
- css2.1/20110323/floats-wrap-top-below-inline-001l-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-inline-001l.htm: Added.
- css2.1/20110323/floats-wrap-top-below-inline-001r-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-inline-001r.htm: Added.
- css2.1/20110323/floats-wrap-top-below-inline-002l-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-inline-002l.htm: Added.
- css2.1/20110323/floats-wrap-top-below-inline-002r-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-inline-002r.htm: Added.
- css2.1/20110323/floats-wrap-top-below-inline-003l-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-inline-003l.htm: Added.
- css2.1/20110323/floats-wrap-top-below-inline-003r-expected.html: Added.
- css2.1/20110323/floats-wrap-top-below-inline-003r.htm: Added.
- css2.1/20110323/floats-zero-height-wrap-001-expected.html: Added.
- css2.1/20110323/floats-zero-height-wrap-001.htm: Added.
- css2.1/20110323/floats-zero-height-wrap-002.htm: Added.
- css2.1/20110323/floats-zero-height-wrap-002-expected.html: Added.
All of these are taken from the CSS test suite, including the expected.html files which have been renamed
from *-ref.html so that new-run-webkit-tests will parse use them.
- fast/block/float/floats-wrap-inside-inline-001-expected.html: Added.
- fast/block/float/floats-wrap-inside-inline-001.htm: Added.
The span should avoid a float even when its top and bottom does not overlap with the top of the span.
In this test the float starts and ends inside the span's first linebox.
- fast/block/float/floats-wrap-inside-inline-002-expected.html: Added.
- fast/block/float/floats-wrap-inside-inline-002.htm: Added.
The span should avoid a float even when its top and bottom does not overlap with the top of the span.
In this test the float overlaps the bottom of the span, but is below the span's first linebox.
- fast/block/float/floats-wrap-inside-inline-003-expected.html: Added.
- fast/block/float/floats-wrap-inside-inline-003.htm: Added.
An inline span should avoid a float even when its top and bottom does not overlap with the top of the span.
In this test the float starts and ends inside the span's first linebox.
- fast/block/float/floats-wrap-inside-inline-004-expected.html: Added.
- fast/block/float/floats-wrap-inside-inline-004.htm: Added.
The span should avoid a float even when its top and bottom does not overlap with the top of the span.
In this test the float overlaps inside the span and the span has height set by its style.
- fast/block/float/floats-wrap-inside-inline-005-expected.html: Added.
- fast/block/float/floats-wrap-inside-inline-005.htm: Added.
In this test the float starts and ends inside the span's second linebox, so only the second linebox should avoid the float.
- platform/chromium-win/css1/formatting_model/floating_elements-expected.txt:
This is a progression due to lineboxes now avoiding floats they overlap.
- 10:36 AM Changeset in webkit [121788] by
-
- 4 edits in trunk/Tools
[Qt][WTR] Get rid of using DumpRenderTreeSupportQt
https://bugs.webkit.org/show_bug.cgi?id=90262
Unreviewed build fix.
Reverting r121550 manually because it caused build
break on ARM and Mac. It turned out that the Qt build
system is too broken for this change now, first we have
to address two issues:
- symbol hiding was forbidden accidentally on x86 Linux
- Qt lacks a separate library for test support
- Tools.pro:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::didClearWindowForFrame):
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
- 10:30 AM Changeset in webkit [121787] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
Unreviewed chromium rebaseline for r121728.
- platform/chromium-mac/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
- platform/chromium-win/fast/multicol/vertical-rl/rules-with-border-before-expected.png:
- platform/chromium/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
- 10:30 AM Changeset in webkit [121786] by
-
- 4 edits in branches/chromium/1132/Source/WebCore
Merge 119548 - Special layout handler should be done on top frame being printed.
https://bugs.webkit.org/show_bug.cgi?id=88201
Merge approved at http://crbug.com/109412. See also http://crbug.com/135563
Patch by Vitaly Buka <vitalybuka@chromium.org> on 2012-06-05
Reviewed by Brady Eidson.
No new tests. Root case is already covered by tests.
Case described in the issue can be reproduced only by direct call
to Frame::setPrinting of subframe. Probably it's not possible with
layout tests.
- page/Frame.cpp:
(WebCore::Frame::setPrinting):
Use shouldUsePrintingLayout to choose proper version of forceLayout().
(WebCore::Frame::shouldUsePrintingLayout):
Checks if current frame is the top frame being printed.
- rendering/RenderView.cpp:
(WebCore::RenderView::shouldUsePrintingLayout): Forward to Frame.
TBR=Darin Adler
Review URL: https://chromiumcodereview.appspot.com/10700087
- 10:28 AM Changeset in webkit [121785] by
-
- 2 edits in trunk/Tools
[chromium] Handle trailing backslash on %VSINSTALLDIR%
https://bugs.webkit.org/show_bug.cgi?id=90410
Reviewed by Ojan Vafai.
- Scripts/webkitdirs.pm:
(buildChromiumVisualStudioProject): Handle VSINSTALLDIR ending in a backslash, the backslash escapes the closing double quote.
- 10:21 AM Changeset in webkit [121784] by
-
- 5 edits in trunk/Tools
Make the skia_test_expectations.txt file optional.
https://bugs.webkit.org/show_bug.cgi?id=90400
Reviewed by Dirk Pranke.
It used to be optional. This regressed at some point. It's important that it be
optional so that webkit-patch commands work in a pure-webkit checkout for chromium bots.
Specifically, this was breaking webkit-patch rebaseline-test when it would go to update
TestExpectations.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.expectations_files):
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_expectations_dict):
- 10:17 AM Changeset in webkit [121783] by
-
- 4 edits5 adds in trunk/LayoutTests
Unreviewed chromium rebaseline.
- platform/chromium-linux-x86/fast/line-grid: Added.
- platform/chromium-linux-x86/fast/line-grid/line-grid-into-columns-expected.txt: Added.
- platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.png:
- platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.txt: Added.
- platform/chromium-win-xp/fast/line-grid: Added.
- platform/chromium-win-xp/fast/line-grid/line-grid-into-columns-expected.txt: Added.
- platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.png:
- platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.txt:
- 10:15 AM Changeset in webkit [121782] by
-
- 2 edits in trunk/Tools
[jhbuild][EFL] Bump libffi dependency.
https://bugs.webkit.org/show_bug.cgi?id=85373
Reviewed by Gustavo Noronha Silva.
Update libffi to 3.0.11, which fixes the build on some platforms
where 3.0.10 had problems.
- efl/jhbuild.modules:
- 10:14 AM Changeset in webkit [121781] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium TestExpectations update, marked a couple of tests as flaky on windows.
- platform/chromium/TestExpectations:
- 9:55 AM Changeset in webkit [121780] by
-
- 9 edits1 delete in trunk/LayoutTests
Unreviewed chromium mac rebaseline.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
- platform/chromium-mac/http/tests/misc/acid3-expected.txt:
- platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
- platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
- platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
- platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
- platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
- 9:34 AM Changeset in webkit [121779] by
-
- 4 edits in trunk
[BlackBerry] Enable microdata support for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=90429
Reviewed by Rob Buis.
.:
- Source/cmake/OptionsBlackBerry.cmake:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 9:29 AM Changeset in webkit [121778] by
-
- 8 edits1 add in trunk/Source/WebCore
Web Inspector: Introduce Workspace make it UISourceCode provider for ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=90466
Reviewed by Pavel Feldman.
Introduced WebInspector.Workspace as a model (UISourceCode provider) behind ScriptsPanel.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/Workspace.js: Added.
(WebInspector.CompositeUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._registerUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeAdded):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeReplaced):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeRemoved):
(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.registerUISourceCodeProvider):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
- 9:22 AM Changeset in webkit [121777] by
-
- 29 edits1 add in trunk
[Qt] Make use of .qmake.cache for caching features
Instead of loading() features from the files that need them (and re-running
a bunch of checks), we now run feature detection as part of configure.pro,
and have build-webkit write the computed feature-defines and CONFIG to
.qmake.cache, which is then loaded by qmake _before_ even defaults_pre
when building WebKit.pro.
At some point we'll be able to selectivly prevent running of config tests
in configure.pro, which means we don't need a separate code-path for
the build-webkit --help case.
We should also move the code in build-webkit that now uses .webkit.config
to detect clean builds, to use .qmake.cache, since we now store the same
thing there.
Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
https://bugs.webkit.org/show_bug.cgi?id=90461
Reviewed by Tor Arne Vestbø.
- 9:15 AM Changeset in webkit [121776] by
-
- 5 edits in trunk/Tools
-Wunused-private-field cleanup, linux edition
https://bugs.webkit.org/show_bug.cgi?id=90463
Reviewed by Stephen White.
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- DumpRenderTree/chromium/GamepadController.h:
(GamepadController):
- DumpRenderTree/chromium/NotificationPresenter.h:
(NotificationPresenter::NotificationPresenter):
(NotificationPresenter):
- 9:04 AM Changeset in webkit [121775] by
-
- 29 edits1 delete in trunk
Unreviewed, rolling out r121766.
http://trac.webkit.org/changeset/121766
https://bugs.webkit.org/show_bug.cgi?id=90465
It caused flakey build errors on the bots (Requested by Ossy
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-03
.:
- Source/QtWebKit.pro:
- Source/api.pri:
- Source/tests.pri:
- WebKit.pro:
Source/WebCore:
- DerivedSources.pri:
- WebCore.pri:
Source/WebKit/qt:
- declarative/declarative.pro:
- declarative/public.pri:
- tests/qgraphicswebview/qgraphicswebview.pro:
Source/WebKit2:
- DerivedSources.pri:
- Target.pri:
Source/WTF:
- WTF.pri:
Tools:
- DumpRenderTree/qt/DumpRenderTree.pro:
- QtTestBrowser/QtTestBrowser.pro:
- Scripts/webkitdirs.pm:
(qtFeatureDefaults):
(buildQMakeProjects):
- Tools.pro:
- WebKitTestRunner/InjectedBundle/DerivedSources.pri:
- WebKitTestRunner/InjectedBundle/Target.pri:
- WebKitTestRunner/Target.pri:
- qmake/.qmake.conf: Removed.
- qmake/configure.pro:
- qmake/mkspecs/features/default_post.prf:
- qmake/mkspecs/features/default_pre.prf:
- qmake/mkspecs/features/features.prf:
- 9:00 AM Changeset in webkit [121774] by
-
- 9 edits in trunk
[BlackBerry] Enable Custom Scheme Handlers for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=90422
Reviewed by Rob Buis.
.:
- Source/cmake/OptionsBlackBerry.cmake:
Source/WebCore:
- page/NavigatorRegisterProtocolHandler.cpp:
(WebCore::initProtocolHandlerWhitelist): Disable the overrides as
they're undesired by BlackBerry
Source/WebKit/blackberry:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
(WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
(WebCore::ChromeClientBlackBerry::unregisterProtocolHandler):
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 8:53 AM Changeset in webkit [121773] by
-
- 7 edits in trunk
[BlackBerry] Enable RegisterProtocolHandler for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=90422
Reviewed by Rob Buis.
.:
- Source/cmake/OptionsBlackBerry.cmake:
Source/WebKit/blackberry:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
(WebCore::ChromeClientBlackBerry::registerProtocolHandler):
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 8:48 AM Changeset in webkit [121772] by
-
- 2 edits in trunk
[GTK] Need to bump libsoup requirements (for
soup_cookie_jar_get_cookie_list
)
https://bugs.webkit.org/show_bug.cgi?id=90332
Patch by Priit Laes <plaes@plaes.org> on 2012-07-03
Reviewed by Gustavo Noronha Silva.
- configure.ac: Bump libsoup requirements to 2.39.2
- 8:43 AM Changeset in webkit [121771] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add WebKitWebView::context-menu-dismissed signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=90386
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init): Add context-menu-dismissed signal.
(contextMenuDismissed): Emit context-menu-dismissed signal.
(webkitWebViewPopulateContextMenu): Connect to deactivate signal
of the GtkMenu and emit WebKitWebView::context-menu-dismissed when
the gtk menu is deactivated.
- UIProcess/API/gtk/WebKitWebView.h:
(_WebKitWebViewClass): Add virtual methos for
context-menu-dismissed signal.
- UIProcess/API/gtk/tests/TestContextMenu.cpp:
(testContextMenuDismissed):
(beforeAll):
- UIProcess/gtk/WebContextMenuProxyGtk.h:
(WebKit::WebContextMenuProxyGtk::gtkMenu): Get the GtkMenu built
for the context menu proxy.
- 8:40 AM Changeset in webkit [121770] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Added missing WebPageProxy::ViewIsFocused flag to WebPageProxy::viewStateDidChange()
call in _ewk_view_smart_focus_out() function.
https://bugs.webkit.org/show_bug.cgi?id=89877
Patch by Piotr Roguski <p.roguski@samsung.com> on 2012-07-03
Reviewed by Andreas Kling.
Although name of the flag suggest it should be used only on focus in,
omitting it in case of focus out will prevent WebPageProxy::viewStateDidChange()
from sending Messages::WebPage::SetFocused(false).
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_focus_out):
- 8:34 AM Changeset in webkit [121769] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] API tests randomly asserts in QQuickWebPage::setContentsScale(qreal)
https://bugs.webkit.org/show_bug.cgi?id=88679
Reviewed by Csaba Osztrogonác.
Viewport parameters cannot be calculated while viewport is not visible and
viewport size is 0, so let's delay calculation of viewport parameters until view
becomes visible.
- UIProcess/qt/QtViewportHandler.cpp:
(WebKit::QtViewportHandler::pageContentsSizeChanged):
- 8:28 AM Changeset in webkit [121768] by
-
- 2 edits1 add in trunk/Tools
[EFL] Add run API tests as a step on the build bots
https://bugs.webkit.org/show_bug.cgi?id=87252
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-03
Reviewed by Daniel Bates.
Run EFL API test suite on the build bots.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunEflAPITests):
(TestFactory.init):
(BuildAndTestFactory.init):
- Scripts/run-efl-tests: Added.
- 8:27 AM Changeset in webkit [121767] by
-
- 11 edits2 adds in trunk
Web Inspector: Forward message loop instrumentation data to frontend.
https://bugs.webkit.org/show_bug.cgi?id=89584
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-07-03
Reviewed by Yury Semikhatsky.
Transmit collected message loop tasks to inspector frontend.
Now "Program" should be a top-level event on browsers that
support message loop instrumentation.
Frontend was changed so that user will not see any changes.
Source/WebCore:
- inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
Added new event type - "Program"
(WebCore::InspectorTimelineAgent::willProcessTask):
Begin "Program" event.
(WebCore::InspectorTimelineAgent::didProcessTask):
Finish "Program" event.
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
Do not add counters to "Program" events.
(WebCore):
(WebCore::InspectorTimelineAgent::innerSetHeapSizeStatistic):
Renamed from "setHeapSizeStatistic"
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._onRecordAdded):
Unwraps "Program" events.
(WebInspector.MemoryStatistics.prototype._innerRecordAdded):
Renamed from "_onRecordAdded"
- inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._addRecord):
Unwraps "Program" events.
(WebInspector.TimelineFrameController.prototype._innerAddRecord):
Renamed from "_addRecord"
- inspector/front-end/TimelineModel.js:
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineCategoryStrips.prototype.update.appendRecord):
Filter out "Program" category.
(WebInspector.TimelineCategoryStrips.prototype.update):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
Filter out "Program" category.
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
Unwraps "Program" events.
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.categories):
Added "Program" category.
(WebInspector.TimelinePresentationModel.recordStyle):
Ditto.
(WebInspector.TimelinePresentationModel.prototype.addRecord):
Unwraps "Program" events.
(WebInspector.TimelinePresentationModel.prototype._addRecord):
Renamed from "addRecord"
LayoutTests:
- inspector/timeline/timeline-enum-stability-expected.txt:
- 8:23 AM Changeset in webkit [121766] by
-
- 29 edits1 add in trunk
[Qt] Make use of .qmake.cache for caching features
Instead of loading() features from the files that need them (and re-running
a bunch of checks), we now run feature detection as part of configure.pro,
and have build-webkit write the computed feature-defines and CONFIG to
.qmake.cache, which is then loaded by qmake _before_ even defaults_pre
when building WebKit.pro.
At some point we'll be able to selectivly prevent running of config tests
in configure.pro, which means we don't need a separate code-path for
the build-webkit --help case.
We should also move the code in build-webkit that now uses .webkit.config
to detect clean builds, to use .qmake.cache, since we now store the same
thing there.
Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
https://bugs.webkit.org/show_bug.cgi?id=90461
Reviewed by Tor Arne Vestbø.
- 8:00 AM Changeset in webkit [121765] by
-
- 5 edits1 copy in trunk
inspector/debugger/script-snippet-model.html fails
https://bugs.webkit.org/show_bug.cgi?id=90385
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/ScriptSnippetModel.js:
LayoutTests:
- inspector/debugger/script-snippet-model-expected.txt:
- platform/chromium/inspector/debugger/script-snippet-model-expected.txt: Copied from LayoutTests/inspector/debugger/script-snippet-model-expected.txt.
- platform/qt/Skipped:
- 7:44 AM Changeset in webkit [121764] by
-
- 6 edits in trunk
[REGRESSION] Crash when copying a StyleRuleMedia with a NULL m_mediaQueries
https://bugs.webkit.org/show_bug.cgi?id=90459
Reviewed by Andreas Kling.
Source/WebCore:
Create StyleRuleMedia with a non-NULL MediaQuerySet. The respective NULL checks for it were all over the code,
except the copy constructor. Added the check, just in case.
- css/CSSParser.cpp:
(WebCore::CSSParser::createMediaRule):
- css/StyleRule.cpp:
(WebCore::StyleRuleMedia::StyleRuleMedia):
LayoutTests:
- inspector/styles/get-set-stylesheet-text-expected.txt:
- inspector/styles/resources/get-set-stylesheet-text.css:
(@media):
- 6:47 AM Changeset in webkit [121763] by
-
- 9 edits in trunk
Web Inspector: display time intervals measured with console.time() and console.timeEnd() in Timeline
https://bugs.webkit.org/show_bug.cgi?id=90442
Reviewed by Pavel Feldman.
Source/WebCore:
- added Time and TimeEnd record types produced by console.time() and console.timeEnd()
- connect Time to TimeEnd in "glue" mode to better visualize the interval;
- always make Time a top-level record;
- English.lproj/localizedStrings.js:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::startConsoleTimingImpl):
(WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
- inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::didStartTiming):
(WebCore):
(WebCore::InspectorTimelineAgent::didStopTiming):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- inspector/front-end/TimelineModel.js:
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.recordStyle):
(WebInspector.TimelinePresentationModel.categoryForRecord):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.addRecord):
(WebInspector.TimelinePresentationModel.prototype._findParentRecord):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
LayoutTests:
- added Time & TimeEnd;
- inspector/timeline/timeline-enum-stability-expected.txt:
- 6:43 AM Changeset in webkit [121762] by
-
- 11 edits in trunk
[Qt][Win] Fix broken QtWebKit5.lib linking
https://bugs.webkit.org/show_bug.cgi?id=88321
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> Joel Dillon <joel.dillon@codethink.co.uk> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
Source/JavaScriptCore:
The goal is to have different ports build systems define STATICALLY_LINKED_WITH_WTF
when building JavaScriptCore, if both are packaged in the same DLL, instead
of relying on the code to handle this.
The effects of BUILDING_* and STATICALLY_LINKED_WITH_* are currently the same
except for a check in Source/JavaScriptCore/config.h.
Keeping the old way for the WX port as requested by the port's contributors.
For non-Windows ports there is no difference between IMPORT and EXPORT, no
change is needed.
- API/JSBase.h: JS symbols shouldn't be included by WTF objects anymore. Remove the export when BUILDING_WTF.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Make sure that JavaScriptCore uses import symbols of WTF for the Win port.
- runtime/JSExportMacros.h:
Source/WebCore:
- platform/PlatformExportMacros.h:
Source/WTF:
Instead of letting a module's headers know which other modules depend on them,
have depending modules define explicitely that they want its symbols exported too.
JavaScriptCore should then be compiled with both BUILDING_JavaScriptCore and
STATICALLY_LINKED_WITH_WTF.
- wtf/ExportMacros.h:
Tools:
On windows the import/export definition is part of the symbol's signature.
Define STATICALLY_LINKED_WITH_$$library for each dependend module
that is being linked statically to make sure that they can be linked together
later on.
Also do not compile Assertions.cpp in DumpRenderTree anymore since all the
used symbols are exported and it would cause a duplicate symbols error.
- DumpRenderTree/qt/DumpRenderTree.pro:
- qmake/mkspecs/features/default_post.prf:
- 6:32 AM Changeset in webkit [121761] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] When calling accept() on the FilePickerContextObject with an empty list, early return and call reject().
https://bugs.webkit.org/show_bug.cgi?id=89755
Reviewed by Simon Hausmann.
When calling accept with an empty list of files we can just bailout
and call reject(). Any other processing is pointless.
- UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml:
- UIProcess/qt/QtDialogRunner.cpp:
(WebKit::FilePickerContextObject::accept):
- 6:00 AM Changeset in webkit [121760] by
-
- 2 edits in trunk/Tools
master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
https://bugs.webkit.org/show_bug.cgi?id=89001
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-07-03
Reviewed by Csaba Osztrogonác.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(UploadBuiltProduct.init):
(UploadTestResults.init):
(ExtractTestResults.init):
(Factory.init):
(BuildFactory.init):
(TestFactory.init):
(BuildAndTestFactory.init):
(BuildAndPerfTestFactory.init):
(BuildAndPerfTestWebKit2Factory.init):
(DownloadAndPerfTestFactory.init):
- 5:38 AM Changeset in webkit [121759] by
-
- 2 edits in trunk/Tools
Update unit test after r121724.
https://bugs.webkit.org/show_bug.cgi?id=90444
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-03
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline_new_port):
- 5:37 AM Changeset in webkit [121758] by
-
- 27 edits1 copy17 adds in trunk/LayoutTests
[EFL] Add new baselines after r121697, r121722 and r121728
https://bugs.webkit.org/show_bug.cgi?id=90446
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-03
- platform/efl/fast/dom/Element/getBoundingClientRect-expected.txt:
- platform/efl/fast/multicol/column-break-with-balancing-expected.png:
- platform/efl/fast/multicol/column-break-with-balancing-expected.txt: Added.
- platform/efl/fast/multicol/column-rules-expected.png:
- platform/efl/fast/multicol/column-rules-expected.txt: Added.
- platform/efl/fast/multicol/column-rules-stacking-expected.txt: Added.
- platform/efl/fast/multicol/columns-shorthand-parsing-expected.txt: Added.
- platform/efl/fast/multicol/nested-columns-expected.png:
- platform/efl/fast/multicol/nested-columns-expected.txt: Added.
- platform/efl/fast/multicol/shadow-breaking-expected.png:
- platform/efl/fast/multicol/shadow-breaking-expected.txt:
- platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png:
- platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
- platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
- platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
- platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
- platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
- platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
- platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
- platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
- platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.png:
- platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
- platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
- platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
- platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.png:
- platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
- platform/efl/fast/multicol/span/span-margin-collapsing-expected.png:
- platform/efl/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
- platform/efl/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
- platform/efl/fast/multicol/vertical-lr/column-rules-expected.png:
- platform/efl/fast/multicol/vertical-lr/column-rules-expected.txt:
- platform/efl/fast/multicol/vertical-lr/float-avoidance-expected.png:
- platform/efl/fast/multicol/vertical-lr/float-avoidance-expected.txt:
- platform/efl/fast/multicol/vertical-lr/nested-columns-expected.png:
- platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt: Copied from LayoutTests/platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt.
- platform/efl/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
- platform/efl/fast/multicol/vertical-rl/column-rules-expected.png:
- platform/efl/fast/multicol/vertical-rl/column-rules-expected.txt:
- platform/efl/fast/multicol/vertical-rl/float-avoidance-expected.png:
- platform/efl/fast/multicol/vertical-rl/float-avoidance-expected.txt:
- platform/efl/fast/multicol/vertical-rl/nested-columns-expected.png:
- platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt:
- platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
- platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
- 4:40 AM Changeset in webkit [121757] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, updating one baseline modified in r121745
to more suitable content.
- platform/gtk/fast/multicol/nested-columns-expected.txt:
- 3:29 AM Changeset in webkit [121756] by
-
- 3 edits2 adds in trunk
Fix text positioning with non-bmp characters.
https://bugs.webkit.org/show_bug.cgi?id=87681
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Previously when constructing metrics for tspans with non-bmp characters,
each non-bmp character treated as a skipped character in the same way that
spaces are ignored.
This made sense because the initial SVGCharacterDataMap for <text> is
indexed by character index (not string length) so the high portion of a
non-bmp character was treated as a skipped space. Unfortunately, this
led to a bug because skipped spaces lead to an offset in the positioning
values list but non-bmp characters do not.
This change switches the code to use a new offset for non-bmp characters,
surrogatePairCharacters, which does not affect the positioning values list.
Tests: svg/text/non-bmp-tspans-expected.svg
svg/text/non-bmp-tspans.svg
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
LayoutTests:
- svg/text/non-bmp-tspans-expected.svg: Added.
- svg/text/non-bmp-tspans.svg: Added.
- 3:25 AM Changeset in webkit [121755] by
-
- 2 edits in trunk/Source/WebKit/win
[CSS Regions] Enabling regions on Windows lead to crash-on-launch for WebKit.exe
https://bugs.webkit.org/show_bug.cgi?id=90435
Patch by Mihai Balan <mibalan@adobe.com> on 2012-07-03
Reviewed by Csaba Osztrogonác.
Initial patch for enabling regions led to WebKit crashing on launch. Moving the
IDL declarations for CSS regions getter/setter at the end of the file solves the
problem. As per http://trac.webkit.org/changeset/95650 seems it has to do with
binary compatibility.
- Interfaces/IWebPreferences.idl: Mover getter/setter for CSS regions at the end of file
- 3:12 AM Changeset in webkit [121754] by
-
- 13 edits in trunk
Improve test cases for network information APIs
https://bugs.webkit.org/show_bug.cgi?id=90162
Reviewed by Adam Barth.
Existing implementation doesn't test port implementation in network info APIs.
This patch lets test cases use bandwidth and metered functions implemented by port layer.
In addition, expected results need to check return type instead of property name.
Source/WebCore:
No new tests. Covered by existing tests.
- Modules/networkinfo/NetworkInfoConnection.cpp:
(WebCore::NetworkInfoConnection::bandwidth):
(WebCore::NetworkInfoConnection::metered):
LayoutTests:
- networkinformation/add-listener-from-callback-expected.txt:
- networkinformation/basic-all-types-of-events-expected.txt:
- networkinformation/basic-operation-expected.txt:
- networkinformation/multiple-frames-expected.txt:
- networkinformation/script-tests/add-listener-from-callback.js:
(checkNetworkInformation):
- networkinformation/script-tests/basic-all-types-of-events.js:
(checkNetworkInformation):
- networkinformation/script-tests/basic-operation.js:
- networkinformation/script-tests/multiple-frames.js:
(checkNetworkInformation):
(checkChildNetworkInformation):
- networkinformation/script-tests/updates.js:
(checkNetworkInformation):
- networkinformation/updates-expected.txt:
- 3:07 AM Changeset in webkit [121753] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r121749.
http://trac.webkit.org/changeset/121749
https://bugs.webkit.org/show_bug.cgi?id=90441
Tests crash on the paralel NRWT Qt bot (Requested by Ossy on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-03
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._build_driver):
- Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):
- 3:04 AM Changeset in webkit [121752] by
-
- 2 edits in trunk/Source/WebCore
[EFL] [WK2] Don't call eina_iterator_free() if iterator is NULL
https://bugs.webkit.org/show_bug.cgi?id=90076
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
Add a null check to prevent calling eina_iterator_free() when
iterator is NULL.
No new tests. This patch doesn't change behavior.
- platform/efl/FileSystemEfl.cpp:
(WebCore::listDirectory): Early return when iterator is NULL.
- 2:49 AM Changeset in webkit [121751] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Elements] Text formatting is not retained when editing <script> or <style> contents as text
https://bugs.webkit.org/show_bug.cgi?id=90440
Reviewed by Vsevolod Vlasov.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
- 2:28 AM Changeset in webkit [121750] by
-
- 9 edits in trunk
Web Inspector: Save scroll selection and cursor position of SourceFrames in sources panel.
https://bugs.webkit.org/show_bug.cgi?id=90294
Reviewed by Yury Semikhatsky.
Source/WebCore:
Scroll and selection change handling is now delegated from TextViewer to SourceFrame.
SourceFrame now dispatches ScrollChanged and SelectionChanged events.
TabbedEditorContainer now saves scroll and selection information together
with the url history and restores scroll and selection on resource opening.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.highlightLine):
(WebInspector.SourceFrame.prototype._innerHighlightLineIfNeeded):
(WebInspector.SourceFrame.prototype._clearLineHighlight):
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype._innerRevealLineIfNeeded):
(WebInspector.SourceFrame.prototype._clearLineToReveal):
(WebInspector.SourceFrame.prototype.scrollToLine):
(WebInspector.SourceFrame.prototype._innerScrollToLineIfNeeded):
(WebInspector.SourceFrame.prototype._clearLineToScrollTo):
(WebInspector.SourceFrame.prototype.setSelection):
(WebInspector.SourceFrame.prototype._innerSetSelectionIfNeeded):
(WebInspector.SourceFrame.prototype._wasShownOrLoaded):
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype.selectionChanged):
(WebInspector.SourceFrame.prototype.scrollChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.selectionChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.scrollChanged):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._addScrollAndSelectionListeners):
(WebInspector.TabbedEditorContainer.prototype._removeScrollAndSelectionListeners):
(WebInspector.TabbedEditorContainer.prototype._scrollChanged):
(WebInspector.TabbedEditorContainer.prototype._selectionChanged):
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.HistoryItem):
(WebInspector.TabbedEditorContainer.HistoryItem.fromObject):
(WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
(WebInspector.TabbedEditorContainer.History):
(WebInspector.TabbedEditorContainer.History.fromObject):
(WebInspector.TabbedEditorContainer.History.prototype.index):
(WebInspector.TabbedEditorContainer.History.prototype.selectionRange):
(WebInspector.TabbedEditorContainer.History.prototype.updateSelectionRange):
(WebInspector.TabbedEditorContainer.History.prototype.scrollLineNumber):
(WebInspector.TabbedEditorContainer.History.prototype.updateScrollLineNumber):
(WebInspector.TabbedEditorContainer.History.prototype.update):
(WebInspector.TabbedEditorContainer.History.prototype.remove):
(WebInspector.TabbedEditorContainer.History.prototype.save):
(WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextRange.fromObject):
(WebInspector.TextRange.prototype.clone):
(WebInspector.TextRange.prototype.serializeToObject):
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._handleScrollChanged):
(WebInspector.TextViewer.prototype.scrollToLine):
(WebInspector.TextViewer.prototype._handleSelectionChange):
(WebInspector.TextViewer.prototype.setSelection):
(WebInspector.TextViewer.prototype.wasShown):
(WebInspector.TextViewer.prototype._handleFocused):
(WebInspector.TextViewer.prototype.willHide):
(WebInspector.TextViewerDelegate.prototype.selectionChanged):
(WebInspector.TextViewerDelegate.prototype.scrollChanged):
(WebInspector.TextEditorChunkedPanel.prototype.scrollToLine):
LayoutTests:
- inspector/tabbed-editors-history-expected.txt:
- inspector/tabbed-editors-history.html:
- 2:26 AM Changeset in webkit [121749] by
-
- 3 edits in trunk/Tools
[NRWT] XvfbDriver should choose the next free display
https://bugs.webkit.org/show_bug.cgi?id=88414
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._driver_class):
- Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver.init):
(XvfbDriver._start):
(XvfbDriver._start.next_free_id):
(XvfbDriver.stop):
- 2:17 AM Changeset in webkit [121748] by
-
- 6 edits in trunk
Web Inspector: Make DirectoryContentView sortable
https://bugs.webkit.org/show_bug.cgi?id=90361
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-03
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorFileSystemAgent.cpp:
(WebCore):
- inspector/front-end/DirectoryContentView.js:
(WebInspector.DirectoryContentView):
(WebInspector.DirectoryContentView.prototype.showEntries):
(WebInspector.DirectoryContentView.prototype._sort):
(WebInspector.DirectoryContentView.Node.comparator.isDirectoryCompare):
(WebInspector.DirectoryContentView.Node.comparator.nameCompare):
(WebInspector.DirectoryContentView.Node.comparator.typeCompare):
(WebInspector.DirectoryContentView.Node.comparator.sizeCompare):
(WebInspector.DirectoryContentView.Node.comparator):
(WebInspector.DirectoryContentView.Node.prototype._metadataReceived):
LayoutTests:
- http/tests/inspector/filesystem/get-metadata-expected.txt:
- 1:58 AM Changeset in webkit [121747] by
-
- 2 edits1 copy in trunk/LayoutTests
[Chromium] Rebaseline: fast/box-sizing/box-sizing.html
- platform/chromium-mac-snowleopard/fast/box-sizing/box-sizing-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/box-sizing/box-sizing-expected.txt.
- platform/chromium-mac/fast/box-sizing/box-sizing-expected.txt:
- 1:45 AM Changeset in webkit [121746] by
-
- 18 edits2 moves in trunk
Web Inspector: WebInspector.TextViewer should be renamed WebInspector.TextEditor
https://bugs.webkit.org/show_bug.cgi?id=89939
Patch by Jan Keromnes <janx@linux.com> on 2012-07-03
Reviewed by Vsevolod Vlasov.
PerformanceTests:
- inspector/first-open-scripts.html.broken:
Source/WebCore:
Fixed LayoutTests and PerformanceTests accordingly.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition.finishEditing):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):
(WebInspector.JavaScriptSourceFrame.prototype.toggleBreakpointOnCurrentLine):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype.defaultFocusedElement):
(WebInspector.SourceFrame.prototype.get textEditor):
(WebInspector.SourceFrame.prototype.clearMessages):
(WebInspector.SourceFrame.prototype.highlightLine):
(WebInspector.SourceFrame.prototype._clearLineHighlight):
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype.setSelection):
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.onTextEditorContentLoaded):
(WebInspector.SourceFrame.prototype._setTextEditorDecorations):
(WebInspector.SourceFrame.prototype.searchCanceled):
(WebInspector.SourceFrame.prototype.jumpToSearchResult):
(WebInspector.SourceFrame.prototype.addMessageToSource):
(WebInspector.SourceFrame.prototype.removeMessageFromSource):
(WebInspector.SourceFrame.prototype.inheritScrollPositions):
(WebInspector.TextEditorDelegateForSourceFrame):
- inspector/front-end/TextViewer.js: Removed.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/textViewer.css: Removed.
Source/WebKit/blackberry:
- WebCoreSupport/inspectorBB.html:
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- http/tests/inspector/live-edit-test.js:
(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest):
- http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback):
(initialize_ResourceTest.InspectorTest.showResource):
- inspector/debugger/pause-in-inline-script.html:
- 1:37 AM Changeset in webkit [121745] by
-
- 9 edits19 adds in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines after r121697 and r121728
and adding text and pixel baselines required after r121722.
- platform/gtk/fast/dom/Element/getBoundingClientRect-expected.txt:
- platform/gtk/fast/multicol/column-break-with-balancing-expected.txt: Added.
- platform/gtk/fast/multicol/column-rules-expected.txt: Added.
- platform/gtk/fast/multicol/column-rules-stacking-expected.txt: Added.
- platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt: Added.
- platform/gtk/fast/multicol/nested-columns-expected.txt: Added.
- platform/gtk/fast/multicol/shadow-breaking-expected.txt:
- platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
- platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
- platform/gtk/fast/multicol/span/generated-child-split-flow-crash-expected.txt:
- platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
- platform/gtk/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
- platform/gtk/fast/multicol/vertical-lr/column-rules-expected.txt:
- platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
- platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
- platform/gtk/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
- platform/gtk/fast/multicol/vertical-rl/column-rules-expected.txt:
- platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
- platform/gtk/fast/multicol/vertical-rl/nested-columns-expected.txt:
- platform/gtk/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
- platform/gtk/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
- 1:31 AM Changeset in webkit [121744] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update text expectation for timeline-receive-response-event.html
- platform/chromium/TestExpectations: Add "TEXT"
- 1:28 AM Changeset in webkit [121743] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
platform/chromium/permissionclient/storage-permission.html consistently
passes
- platform/chromium/TestExpectations:
- 1:28 AM Changeset in webkit [121742] by
-
- 13 edits in trunk/Source
IndexedDB: should make the LevelDB persistant to the directory indicated in PageGroupSettings::indexedDBDataBasePath
https://bugs.webkit.org/show_bug.cgi?id=88338
Reviewed by David Levin.
Source/WebCore:
If the indexedDB runs in main thread it can access the GroupSettings via the document;
otherwise, we need to pass the page GroupSettings to the worker thread so that accessible
to the indexedDB running in WorkerContext.
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
- workers/DedicatedWorkerThread.h:
(DedicatedWorkerThread):
- workers/DefaultSharedWorkerRepository.cpp:
(SharedWorkerProxy):
(WebCore::SharedWorkerProxy::groupSettings):
(WebCore):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
- workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
- workers/SharedWorkerThread.h:
(SharedWorkerThread):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
(WorkerThreadStartupData):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::groupSettings):
(WebCore):
- workers/WorkerThread.h:
(WorkerThread):
Source/WebKit/chromium:
- src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::startWorkerContext):
- src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):
- 1:24 AM Changeset in webkit [121741] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r121728. Updated expectations to
fast/multicol/span/span-as-immediate-child-generated-content.html.
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-07-03
- platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
- platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- 1:22 AM Changeset in webkit [121740] by
-
- 6 edits in trunk
[Qt][WK2] fast/viewport/viewport-91.html still fails after r121555 and r121661
https://bugs.webkit.org/show_bug.cgi?id=90376
Reviewed by Csaba Osztrogonác.
Source/WebCore:
No new tests, this is only a build alignment.
Export ViewportArguments::deprecatedTargetDPI since it is used in WebKit2.
- WebCore.exp.in:
Source/WebKit2:
layoutTestController.dumpConfigurationForViewport still need
to use the constant target DPI of 160.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewportConfigurationAsText):
LayoutTests:
Unskip passing test.
- platform/qt-5.0-wk2/Skipped:
- 1:20 AM Changeset in webkit [121739] by
-
- 1 edit1 delete in trunk/LayoutTests
[Chromium] Rebaseline for Mac10.6
- platform/chromium-mac-snowleopard/fast/events/offsetX-offsetY-expected.txt: Removed.
- 1:17 AM Changeset in webkit [121738] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Tests still crashing for Linux Release as well.
https://bugs.webkit.org/show_bug.cgi?id=89979
Patch by Michael Starzinger <mstarzinger@chromium.org> on 2012-07-03
Reviewed by Tony Chang.
- platform/chromium/TestExpectations:
- 1:10 AM Changeset in webkit [121737] by
-
- 1 edit8 adds in trunk/LayoutTests
[Chromium] Rebaseline: Add missing expectation files introduced by r121722
- platform/chromium-mac-snowleopard/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
- platform/chromium-mac/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
- platform/chromium-mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
- platform/chromium-win-xp/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
- platform/chromium-win-xp/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
- platform/chromium-win/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
- platform/chromium-win/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
- 12:49 AM Changeset in webkit [121736] by
-
- 5 edits in trunk/LayoutTests
[Qt] Unreviewed Gardening after r121697. Updated expected files.
Patch by János Badics <János Badics> on 2012-07-03
- platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
- platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
- platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
- platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
- 12:47 AM BuildingGtk edited by
- ruby is now needed to compile WebKit (diff)
- 12:06 AM Changeset in webkit [121735] by
-
- 3 edits1 delete in trunk/LayoutTests
Calculate client positions from offsets.
https://bugs.webkit.org/show_bug.cgi?id=73640
Reviewed by Tony Chang.
This change calculates client positions from offset positions at run time to
remove platform-dependent constants from this test.
- fast/events/offsetX-offsetY-expected.txt:
- fast/events/offsetX-offsetY.html:
- platform/chromium-win/fast/events/offsetX-offsetY-expected.txt: Removed.
- 12:01 AM Changeset in webkit [121734] by
-
- 6 edits in trunk
[EFL] Enable MICRODATA support
https://bugs.webkit.org/show_bug.cgi?id=90377
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
.:
Turn on MICRODATA support by default for EFL port.
- Source/cmake/OptionsEfl.cmake:
Tools:
Turn on MICRODATA flag for EFL port by default.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Unskip microdata test cases now that support has been
enabled for EFL port.
- platform/efl/Skipped:
Jul 2, 2012:
- 11:54 PM Changeset in webkit [121733] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Add API to deliver a Web Intent to a frame
https://bugs.webkit.org/show_bug.cgi?id=90067
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
Add ewk_view_intent_deliver() method on the Ewk_View
to deliver a Web Intent to the view's main frame.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_intent_deliver):
- UIProcess/API/efl/ewk_view.h:
- 11:27 PM Changeset in webkit [121732] by
-
- 7 edits3 adds in trunk/Source/WebKit2
[EFL][WK2] Add API to inspect a Web Intent service
https://bugs.webkit.org/show_bug.cgi?id=90066
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-02
Reviewed by Kenneth Rohde Christiansen.
Add EFL API to inspect a Web Intent Service and emit
a signal on the view when a new intent service
registers.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_intent_service.cpp: Added.
(_Ewk_Intent_Service):
(ewk_intent_service_ref):
(ewk_intent_service_unref):
(ewk_intent_service_action_get):
(ewk_intent_service_type_get):
(ewk_intent_service_href_get):
(ewk_intent_service_title_get):
(ewk_intent_service_disposition_get):
(ewk_intent_service_new):
- UIProcess/API/efl/ewk_intent_service.h: Added.
- UIProcess/API/efl/ewk_intent_service_private.h: Copied from Source/WebKit2/UIProcess/API/efl/ewk_view_loader_client.cpp.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_intent_service_register):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_loader_client.cpp:
(registerIntentServiceForFrame):
(ewk_view_loader_client_attach):
- UIProcess/API/efl/ewk_view_private.h:
- 11:24 PM Changeset in webkit [121731] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] Free Ewk_Intent calloc'd memory with free() instead of delete
https://bugs.webkit.org/show_bug.cgi?id=90433
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-02
Reviewed by Kenneth Rohde Christiansen.
Free calloc'd memory with free() instead of delete in Ewk_Intent.
Add blank lines before return statements for consistency.
- UIProcess/API/efl/ewk_intent.cpp:
(ewk_intent_unref):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):
(ewk_intent_new):
- 9:42 PM Changeset in webkit [121730] by
-
- 2 edits in trunk/LayoutTests
Layout Test inspector/timeline/timeline-receive-response-event.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90430
Unreviewd build fix
- platform/chromium/TestExpectations: Mark timeline-receive-response-event.html flaky
- 9:25 PM Changeset in webkit [121729] by
-
- 12 edits in trunk/Source
[TextureMapper] The TextureMapper should support edge-distance anti-antialiasing
https://bugs.webkit.org/show_bug.cgi?id=90308
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-07-02
Reviewed by Noam Rosenthal.
Source/WebCore:
Add an edge-distance anti-aliasing implementation for the TextureMapper. Currently
this implementation is not active for tiled layers. This implementation is based
on the one in the Chromium compositor originally written by David Raveman.
When a layer is transformed in a way that leaves its edge dimensions across pixel
boundaries, edge distance anti-aliasing will do a cheaper form of anti-aliasing
than full-scene anti-aliasing to make the transition from the layer pixel
to the background pixel smoother.
No new tests. This will be covered by pixel tests for Qt and GTK+ accelerated
compositing and 3D transforms, when those test harnesses are capable of
producing pixel output (in progress).
- platform/graphics/texmap/TextureMapper.h: Add an enum which is used to tell
the texture mapper what edges of a texture are exposed. This will be used for
properly dealing with tiled layers in the future.
- platform/graphics/texmap/TextureMapperBackingStore.cpp: Properly pass information
about exposed layer edges to the TextureMapper while painting.
- platform/graphics/texmap/TextureMapperBackingStore.h:
(TextureMapperTile): Modified arguments include exposed edges.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawQuad): Renamed from drawRect, this method can now
draw quads that have non unit-rect texture coordinates. This is necessary because
the edge distance approach draws such quad.
(WebCore::TextureMapperGL::drawBorder): Call drawQuad now instead of drawRect.
(WebCore::TextureMapperGL::drawTexture): Pass the exposedEdges argument down.
(WebCore::TextureMapperGL::drawTextureRectangleARB): Call drawQuad now instead of
drawRect.
(WebCore::viewportMatrix): Added this helper which can calculate the viewport
transform based on the current OpenGL viewport settings.
(WebCore::scaleLineEquationCoeffecientsToOptimizeDistanceCalculation): Added this
helper which optimizes the fragment shader by precalculating some constant parts
of the distance calculation.
(WebCore::getStandardEquationCoeffecientsForLine): Given two end points of line segment
get the coeffecients of the line in the standard form of the line equation.
(WebCore::quadToEdgeArray): Converts a FloatQuad to an array of four sets of pre-scaled
line coefficients so that they can be passed to OpenGL.
(WebCore::scaledVectorDifference): Helper which helps expand a quad of arbitrary
orientation.
(WebCore::inflateQuad): Inflate a quad of arbitrary orientation. The transform may
flip it so we have to look at neighboring points to expand the quad.
(WebCore::TextureMapperGL::drawTextureWithAntialiasing): Activate the anti-aliasing
program and set up all uniforms.
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram): Abstract out common operations
from drawTexture to be used with drawTextureWithAntialiasing.
- platform/graphics/texmap/TextureMapperGL.h:
(WebCore::TextureMapperGL::DrawQuad::DrawQuad): Add this small type which stores information
necessary to draw a quad -- it's original destination rect and the final size mapped to
texture coordinates.
(TextureMapperGL):
- platform/graphics/texmap/TextureMapperImageBuffer.cpp: Add the new exposedEdges argument.
- platform/graphics/texmap/TextureMapperImageBuffer.h: Ditto.
- platform/graphics/texmap/TextureMapperShaderManager.cpp: Add the new fragment shader for
doing edge-distance AA and a program which uses that shader.
- platform/graphics/texmap/TextureMapperShaderManager.h: Ditto.
Source/WebKit2:
- UIProcess/texmap/LayerBackingStore.cpp:
(WebKit::LayerBackingStore::paintToTextureMapper): Update the method to call paint with
the new argument.
- 9:08 PM Changeset in webkit [121728] by
-
- 4 edits2 adds in trunk
Column height and count calculation ignores most overflow
https://bugs.webkit.org/show_bug.cgi?id=90392
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/multicol/overflow-content.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::relayoutForPagination): Changed to compute the overflow from children
and use the layout overflow height rather the content height.
LayoutTests:
- fast/multicol/overflow-content-expected.html: Added.
- fast/multicol/overflow-content.html: Added.
- fast/multicol/vertical-rl/rules-with-border-before-expected.png:
- 8:43 PM Changeset in webkit [121727] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Refactor : move the implementation of getMIMETypeForExtension and getPreferredExtensionForMIMEType into BlackBerry platform
https://bugs.webkit.org/show_bug.cgi?id=90360
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-07-02
Reviewed by Antonio Gomes.
We should have one implementation for getMIMETypeForExtension
and getPreferredExtensionForMIMEType for both webkit and platform,
so I move this implementation to BlackBerry platform.
No new test cases , because no behavior changed.
- platform/blackberry/MIMETypeRegistryBlackBerry.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
- 8:40 PM Changeset in webkit [121726] by
-
- 5 edits in trunk
[BlackBerry] Enable scoped style for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=90418
Reviewed by Rob Buis.
.:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmakeconfig.h.cmake:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 8:38 PM Changeset in webkit [121725] by
-
- 10 edits in trunk
[BlackBerry] Use PUBLIC_BUILD to enable/disable DRT
https://bugs.webkit.org/show_bug.cgi?id=90271
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-07-02
Reviewed by George Staikos.
RIM PR #154707
Currently DRT code will be compiled only if ENABLE_DRT is set, and it's not
defined by default.
We should enable DRT by default unless PUBLIC_BUILD is set. In this way we don't
need to rebuild webkit before running DRT.
.:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebKit:
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::runLayoutTests):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::addMessageToConsole):
(WebCore::ChromeClientBlackBerry::runJavaScriptAlert):
(WebCore::ChromeClientBlackBerry::runJavaScriptConfirm):
(WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
(WebCore::ChromeClientBlackBerry::createWindow):
(WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
(WebCore::ChromeClientBlackBerry::setStatusbarText):
(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
(WebCore::ChromeClientBlackBerry::keyboardUIMode):
Tools:
- Scripts/webkitdirs.pm:
(blackberryCMakeArguments):
- 8:36 PM Changeset in webkit [121724] by
-
- 5 edits in trunk/Tools
webkit-patch rebaseline-expectations should share code with rebaseline-all
https://bugs.webkit.org/show_bug.cgi?id=90413
Reviewed by Dirk Pranke.
Make them share code. In addition to reducing code duplication this makes
rebaseline-expectations considerably faster by rebaselining in parallel.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand):
(AbstractParallelRebaselineCommand._run_webkit_patch):
(AbstractParallelRebaselineCommand._rebaseline):
(RebaselineJson):
(RebaselineJson.execute):
(RebaselineExpectations):
(RebaselineExpectations._update_expectations_file):
(RebaselineExpectations._tests_to_rebaseline):
(RebaselineExpectations._add_tests_to_rebaseline_for_port):
(RebaselineExpectations.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_all):
(test_rebaseline_expectations.run_in_parallel):
(test_rebaseline_expectations):
- 8:23 PM Changeset in webkit [121723] by
-
- 3 edits in trunk/Tools
[BlackBerry] Update DumpRenderTree to have it work interactively in parallel
https://bugs.webkit.org/show_bug.cgi?id=88326
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-07-02
Reviewed by Rob Buis.
- Test name is sent to torch-launcher via PPS message(from host machine). So we get test list by monitoring and receiving PPS message instead of reading file index.drt.
- Torch-launcher create a <test file>.done file when it finished a test.
- We don't need to search for Ref-tests in DumpRenderTree.cpp any more. NRWT will get them for us.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
(BlackBerry::WebKit::DumpRenderTree::doneDrt):
(BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
(BlackBerry::WebKit::DumpRenderTree::ensurePPS):
(WebKit):
(BlackBerry::WebKit::DumpRenderTree::handlePPSData):
(BlackBerry::WebKit::DumpRenderTree::waitForTest):
(BlackBerry::WebKit::DumpRenderTree::runTests):
(BlackBerry::WebKit::DumpRenderTree::dump):
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(DumpRenderTree):
- 7:22 PM Changeset in webkit [121722] by
-
- 8 edits3 adds in trunk
Position replaced elements on pixel bounds
https://bugs.webkit.org/show_bug.cgi?id=90354
Reviewed by Eric Seidel.
To avoid sizing and repaint issues we should layout replaced elements on
pixel bounds. We already ensure that replaced elements are sized in full
pixels and that they are painted on pixel bounds. By also ensuring that
they are placed on pixel bounds we avoid pixel having the size be
expanded by pixel snapping and repainting/invalidation rect issues when
scrolling.
Test: fast/repaint/repaint-during-scroll-with-zoom.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
- 7:19 PM Changeset in webkit [121721] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-02
- DEPS:
- 7:04 PM Changeset in webkit [121720] by
-
- 4 edits in trunk/Source/WebCore
Fix new -Wunused-private-field violations
https://bugs.webkit.org/show_bug.cgi?id=90417
Reviewed by Ryosuke Niwa.
No intended behavior change.
- inspector/InspectorFileSystemAgent.cpp:
(WebCore):
- platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:
(WebCore::CCPrioritizedTextureManager::CCPrioritizedTextureManager):
- platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:
(CCPrioritizedTextureManager):
- 6:34 PM Changeset in webkit [121719] by
-
- 2 edits in trunk/LayoutTests
Build fix for Chromium
Fix webkit-lint failure.
- platform/chromium/TestExpectations: Got rid of "SLOW" modifier from fast/overflow/lots-of-sibling-inline-boxes.html
- 6:28 PM Changeset in webkit [121718] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Implement cancelVibration, and make sure it's canceled on
destruction.
https://bugs.webkit.org/show_bug.cgi?id=90406
Reviewed by Rob Buis.
- WebCoreSupport/VibrationClientBlackBerry.cpp:
(WebCore::VibrationClientBlackBerry::cancelVibration):
(WebCore::VibrationClientBlackBerry::vibrationDestroyed):
- 6:27 PM Changeset in webkit [121717] by
-
- 32 edits10 adds in trunk/Source/JavaScriptCore
DFG OSR exit value recoveries should be computed lazily
https://bugs.webkit.org/show_bug.cgi?id=82155
Reviewed by Gavin Barraclough.
This change aims to reduce one aspect of DFG compile times: the fact
that we currently compute the value recoveries for each local and
argument on every speculation check. We compile many speculation checks,
so this can add up quick. The strategy that this change takes is to
have the DFG save just enough information about how the compiler is
choosing to represent state, that the DFG::OSRExitCompiler can reify
the value recoveries lazily.
This appears to be an 0.3% SunSpider speed-up and is neutral elsewhere.
I also took the opportunity to fix the sampling regions profiler (it
was missing an export macro) and to put in more sampling regions in
the DFG (which are disabled so long as ENABLE(SAMPLING_REGIONS) is
false).
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC):
(JSC::CodeBlock::shrinkDFGDataToFit):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::minifiedDFG):
(JSC::CodeBlock::variableEventStream):
(DFGData):
- bytecode/Operands.h:
(JSC::Operands::hasOperand):
(Operands):
(JSC::Operands::size):
(JSC::Operands::at):
(JSC::Operands::operator[]):
(JSC::Operands::isArgument):
(JSC::Operands::isVariable):
(JSC::Operands::argumentForIndex):
(JSC::Operands::variableForIndex):
(JSC::Operands::operandForIndex):
(JSC):
(JSC::dumpOperands):
- bytecode/SamplingTool.h:
(SamplingRegion):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::parse):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::performCFA):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::performCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::performFixup):
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::GenerationInfo):
(JSC::DFG::GenerationInfo::initConstant):
(JSC::DFG::GenerationInfo::initInteger):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initCell):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::initDouble):
(JSC::DFG::GenerationInfo::initStorage):
(GenerationInfo):
(JSC::DFG::GenerationInfo::noticeOSRBirth):
(JSC::DFG::GenerationInfo::use):
(JSC::DFG::GenerationInfo::spill):
(JSC::DFG::GenerationInfo::setSpilled):
(JSC::DFG::GenerationInfo::fillJSValue):
(JSC::DFG::GenerationInfo::fillCell):
(JSC::DFG::GenerationInfo::fillInteger):
(JSC::DFG::GenerationInfo::fillBoolean):
(JSC::DFG::GenerationInfo::fillDouble):
(JSC::DFG::GenerationInfo::fillStorage):
(JSC::DFG::GenerationInfo::appendFill):
(JSC::DFG::GenerationInfo::appendSpill):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGMinifiedGraph.h: Added.
(DFG):
(MinifiedGraph):
(JSC::DFG::MinifiedGraph::MinifiedGraph):
(JSC::DFG::MinifiedGraph::at):
(JSC::DFG::MinifiedGraph::append):
(JSC::DFG::MinifiedGraph::prepareAndShrink):
(JSC::DFG::MinifiedGraph::setOriginalGraphSize):
(JSC::DFG::MinifiedGraph::originalGraphSize):
- dfg/DFGMinifiedNode.cpp: Added.
(DFG):
(JSC::DFG::MinifiedNode::fromNode):
- dfg/DFGMinifiedNode.h: Added.
(DFG):
(JSC::DFG::belongsInMinifiedGraph):
(MinifiedNode):
(JSC::DFG::MinifiedNode::MinifiedNode):
(JSC::DFG::MinifiedNode::index):
(JSC::DFG::MinifiedNode::op):
(JSC::DFG::MinifiedNode::hasChild1):
(JSC::DFG::MinifiedNode::child1):
(JSC::DFG::MinifiedNode::hasConstant):
(JSC::DFG::MinifiedNode::hasConstantNumber):
(JSC::DFG::MinifiedNode::constantNumber):
(JSC::DFG::MinifiedNode::hasWeakConstant):
(JSC::DFG::MinifiedNode::weakConstant):
(JSC::DFG::MinifiedNode::getIndex):
(JSC::DFG::MinifiedNode::compareByNodeIndex):
(JSC::DFG::MinifiedNode::hasChild):
- dfg/DFGNode.h:
(Node):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExit.h:
(OSRExit):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler.h:
(OSRExitCompiler):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::performPredictionPropagation):
- dfg/DFGRedundantPhiEliminationPhase.cpp:
(JSC::DFG::performRedundantPhiElimination):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(DFG):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::noticeOSRBirth):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(DFG):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::recordSetLocal):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValueRecoveryOverride.h: Added.
(DFG):
(ValueRecoveryOverride):
(JSC::DFG::ValueRecoveryOverride::ValueRecoveryOverride):
- dfg/DFGValueSource.cpp: Added.
(DFG):
(JSC::DFG::ValueSource::dump):
- dfg/DFGValueSource.h: Added.
(DFG):
(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):
(JSC::DFG::isInRegisterFile):
(ValueSource):
(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueSource::forDataFormat):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::kind):
(JSC::DFG::ValueSource::isInRegisterFile):
(JSC::DFG::ValueSource::dataFormat):
(JSC::DFG::ValueSource::valueRecovery):
(JSC::DFG::ValueSource::nodeIndex):
(JSC::DFG::ValueSource::nodeIndexFromKind):
(JSC::DFG::ValueSource::kindFromNodeIndex):
- dfg/DFGVariableEvent.cpp: Added.
(DFG):
(JSC::DFG::VariableEvent::dump):
(JSC::DFG::VariableEvent::dumpFillInfo):
(JSC::DFG::VariableEvent::dumpSpillInfo):
- dfg/DFGVariableEvent.h: Added.
(DFG):
(VariableEvent):
(JSC::DFG::VariableEvent::VariableEvent):
(JSC::DFG::VariableEvent::reset):
(JSC::DFG::VariableEvent::fillGPR):
(JSC::DFG::VariableEvent::fillPair):
(JSC::DFG::VariableEvent::fillFPR):
(JSC::DFG::VariableEvent::spill):
(JSC::DFG::VariableEvent::death):
(JSC::DFG::VariableEvent::setLocal):
(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::kind):
(JSC::DFG::VariableEvent::nodeIndex):
(JSC::DFG::VariableEvent::dataFormat):
(JSC::DFG::VariableEvent::gpr):
(JSC::DFG::VariableEvent::tagGPR):
(JSC::DFG::VariableEvent::payloadGPR):
(JSC::DFG::VariableEvent::fpr):
(JSC::DFG::VariableEvent::virtualRegister):
(JSC::DFG::VariableEvent::operand):
(JSC::DFG::VariableEvent::variableRepresentation):
- dfg/DFGVariableEventStream.cpp: Added.
(DFG):
(JSC::DFG::VariableEventStream::logEvent):
(MinifiedGenerationInfo):
(JSC::DFG::MinifiedGenerationInfo::MinifiedGenerationInfo):
(JSC::DFG::MinifiedGenerationInfo::update):
(JSC::DFG::VariableEventStream::reconstruct):
- dfg/DFGVariableEventStream.h: Added.
(DFG):
(VariableEventStream):
(JSC::DFG::VariableEventStream::appendAndLog):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::performVirtualRegisterAllocation):
- 6:24 PM Changeset in webkit [121716] by
-
- 2 edits in trunk/Tools
Remove flashplugin-installer from the EWS image because it causes some tests to crash
https://bugs.webkit.org/show_bug.cgi?id=90403
Reviewed by Tony Chang.
- EWSTools/cold-boot.sh:
- 6:21 PM Changeset in webkit [121715] by
-
- 2 edits in trunk/Source/WebCore
Build fix for Chromimum
r121710 removed WebCore/platform/qt/GraphicsLayerQt.{cpp,h}.
However, that patch didn't remove them from WebCore.gypi.
- WebCore.gypi: Removed GraphicsLayerQt.{cpp,h}
- 6:08 PM Changeset in webkit [121714] by
-
- 18 edits in trunk/Source/WebCore
IDL overloads should not treat wrapper types as nullable by default
https://bugs.webkit.org/show_bug.cgi?id=90218
Reviewed by Kentaro Hara.
Wrapper types were being treated as Nullable by default during overloaded
method dispatching, which deviates from the WebIDL specification. This change
introduces the "?" type suffix into the parser, and treats wrapper types
only nullable if specified. (The behavior of array types and other non-wrapper
types are not changed, and only overloaded methods are checked.)
IDL files with affected overloads are modified to include the "?" suffix
so that no behavior changes are introduced by this patch - the JS and V8
generator results before/after the change show no diffs.
Test: bindings/scripts/test/TestObj.idl (a non-nullable overload)
- Modules/indexeddb/IDBDatabase.idl: Added "?" where necessary.
- Modules/indexeddb/IDBIndex.idl: Added "?" where necessary.
- Modules/indexeddb/IDBObjectStore.idl: Added "?" where necessary.
- Modules/webaudio/AudioContext.idl: Added "?" where necessary.
- Modules/webaudio/AudioNode.idl: Added "?" where necessary.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheckExpression): Add isNullable check.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheckExpression): Add isNullable check.
- bindings/scripts/IDLParser.pm: Parse/set isNullable.
(parseParameters):
- bindings/scripts/IDLStructure.pm: Add basic type suffix parsing.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod8):
(WebCore):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
- bindings/scripts/test/TestObj.idl: Mark previous overload params with ?, add new one without.
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::overloadedMethodCallback):
- dom/DataTransferItemList.idl: Added "?" where necessary.
- fileapi/WebKitBlobBuilder.idl: Added "?" where necessary.
- html/DOMURL.idl: Added "?" where necessary.
- html/canvas/CanvasRenderingContext2D.idl: Added "?" where necessary.
- html/canvas/WebGLRenderingContext.idl: Added "?" where necessary.
- 5:53 PM Changeset in webkit [121713] by
-
- 7 edits3 adds in trunk
[Chromium] Implement a Layout Test for editing/SurroundingText
https://bugs.webkit.org/show_bug.cgi?id=82461
Reviewed by Ryosuke Niwa.
Source/WebKit/chromium:
Allow passing nodes as arguments for layout test methods.
- public/WebBindings.h:
(WebBindings):
- src/WebBindings.cpp:
(WebKit::getNodeImpl):
(WebKit):
(WebKit::WebBindings::getNode):
Tools:
Add a new method to the layout test controller in order to retrieve the
text surrounding a provided element.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::textSurroundingElement):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
LayoutTests:
Add a new layout test for the surrounding text feature.
- platform/chromium/editing/surrounding-text/surrounding-text-expected.txt: Added.
- platform/chromium/editing/surrounding-text/surrounding-text.html: Added.
- 5:10 PM Changeset in webkit [121712] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::ArgumentsSimplificationPhase should assert that the PhantomArguments nodes it creates are not shouldGenerate()
https://bugs.webkit.org/show_bug.cgi?id=90407
Reviewed by Mark Hahnenberg.
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- 5:02 PM EFLWebKit edited by
- Bump libsoup and glib-networking version (diff)
- 4:44 PM Changeset in webkit [121711] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed chromium rebaseline.
- platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
- platform/chromium-mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
- 3:44 PM Changeset in webkit [121710] by
-
- 15 edits2 deletes in trunk/Source
[Qt] Get rid of GraphicsLayerQt
https://bugs.webkit.org/show_bug.cgi?id=78598
Reviewed by Luiz Agostini.
Source/WebCore:
Remove GraphicsLayerQt.h/cpp, as well as references to the non-TextureMapper code paths
in GraphicsContext3DQt and MediaPlayerPrivateQt.
No new tests, removing unused code paths.
- Target.pri:
- platform/graphics/PlatformLayer.h:
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore):
- platform/graphics/qt/GraphicsLayerQt.cpp: Removed.
- platform/graphics/qt/GraphicsLayerQt.h: Removed.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore):
- platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::platformStart):
Source/WebKit/qt:
Removed all references to GraphicsLayerQt, including #ifdef code paths that only apply
when TEXTURE_MAPPER is disabled.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::paint):
- Api/qwebframe.cpp:
(QWebFramePrivate::renderFromTiledBackingStore):
(QWebFramePrivate::renderRelativeCoords):
- Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
(QWebFramePrivate):
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
- WebCoreSupport/PageClientQt.cpp:
(WebCore):
(WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget):
(WebCore::PageClientQGraphicsWidget::update):
(WebCore::PageClientQGraphicsWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
- WebCoreSupport/PageClientQt.h:
(WebCore):
(WebCore::PageClientQWidget::PageClientQWidget):
(PageClientQWidget):
(PageClientQGraphicsWidget):
- 3:41 PM Changeset in webkit [121709] by
-
- 2 edits in trunk/Source/WebCore
LayoutUnit::epsilon() is wrong
https://bugs.webkit.org/show_bug.cgi?id=90083
Patch by Behdad Esfahbod <behdad@behdad.org> on 2012-07-02
Reviewed by Eric Seidel.
Do division in floats, not integers.
No new tests. No code using the affected function.
- platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::epsilon):
- 3:14 PM Changeset in webkit [121708] by
-
- 3 edits in trunk/Source/WebCore
Compositing layer sync should cause deferred repaints to be fired immediately
https://bugs.webkit.org/show_bug.cgi?id=90401
<rdar://problem/11792028>
Reviewed by Simon Fraser and Antti Koivisto.
If we sync compositing layers and allow the repaint to be deferred, there is time for a
visible flash to occur. Instead, stop the deferred repaint timer and repaint immediately.
No new tests, configuration and timing dependent.
- page/FrameView.cpp:
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::checkStopDelayingDeferredRepaints):
(WebCore::FrameView::stopDelayingDeferredRepaints): Split off from checkStopDelayingDeferredRepaints.
- page/FrameView.h:
(FrameView): Add stopDelayingDeferredRepaints.
- 3:08 PM WebKit Team edited by
- (diff)
- 2:47 PM Changeset in webkit [121707] by
-
- 39 edits in trunk/Source
Do not do any logging initialization when logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=90228
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-02
Reviewed by Simon Fraser.
Source/WebCore:
Initializating of the logging channels was taking time on startup. When logging is disabled
(and the LOG macro does nothing), we should aslo disable logging channels and initialization.
This patch #ifdef the Logging initialization with the macro LOG_DISABLED.
- WebCore.exp.in:
- make-export-file-generator: Explicitely adds Assertions.h so that LOG_DISABLED is defined.
- platform/Logging.cpp:
- platform/Logging.h:
- platform/blackberry/LoggingBlackBerry.cpp:
- platform/efl/LoggingEfl.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/gtk/LoggingGtk.cpp:
- platform/mac/LoggingMac.mm:
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ensureSessionIsInitialized):
- platform/qt/LoggingQt.cpp:
- platform/win/LoggingWin.cpp:
- platform/wx/LoggingWx.cpp:
Source/WebKit/blackberry:
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):
Source/WebKit/chromium:
- src/WebKit.cpp:
(WebKit::enableLogChannel):
Source/WebKit/efl:
- ewk/ewk_main.cpp:
(_ewk_init_body):
Source/WebKit/gtk:
- webkit/webkitglobals.cpp:
(webkitInit):
Source/WebKit/mac:
- Misc/WebIconDatabase.mm:
(-[WebIconDatabase _scaleIcon:toSize:]):
- Misc/WebKitLogging.h:
- Misc/WebKitLogging.m:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _attributeStringFromDOMRange:]):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WebKit/qt:
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
Source/WebKit/win:
- WebView.cpp:
(WebView::initWithFrame):
Source/WebKit/wx:
- WebView.cpp:
(WebKit::WebView::Create):
Source/WebKit2:
- Platform/Logging.cpp:
- Platform/Logging.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- 2:27 PM Changeset in webkit [121706] by
-
- 3 edits in trunk/Tools
Delete unused rebaseline method in gardeningserver.py
https://bugs.webkit.org/show_bug.cgi?id=90396
Reviewed by Eric Seidel.
As best I can tell, the only usage was in this unittest.
- Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.updateexpectations):
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline_new_port):
- 1:48 PM Changeset in webkit [121705] by
-
- 2 edits in trunk/LayoutTests
Another crashing test on the EWS. We think this is because of the flash
package we have installed.
- platform/chromium/TestExpectations:
- 1:44 PM Changeset in webkit [121704] by
-
- 9 edits9 adds2 deletes in trunk/LayoutTests
Unreviewed chromium rebaseline for r121697.
- platform/chromium-linux-x86/fast/multicol/vertical-lr: Added.
- platform/chromium-linux-x86/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
- platform/chromium-linux-x86/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
- platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
- platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
- platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
- platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/float-avoidance-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/float-avoidance-expected.png: Removed.
- platform/chromium-mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
- platform/chromium-mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
- platform/chromium-win-xp/fast/multicol/vertical-lr: Added.
- platform/chromium-win-xp/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
- platform/chromium-win-xp/fast/multicol/vertical-rl: Added.
- platform/chromium-win-xp/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
- platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
- platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
- platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
- platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:
- 12:56 PM Changeset in webkit [121703] by
-
- 4 edits in trunk/LayoutTests
fast/box-decoration-break/box-decoration-break-rendering.html failing on mac bots
https://bugs.webkit.org/show_bug.cgi?id=89620
Reviewed by Simon Fraser.
Remove the border-radius from the test case as it can produce differences between
the test case and the reference html. At first we thought the 3 pixels difference
was only happening on Mac but after investigation it also happens in Qt (at least).
It was not triggered because ImageDiff was called with some tolerance. Turning the
tolerance to 0 on Qt also trigger some pixel differences.
The differences on how the radius is drawn can be explained by the fact that
the reference html and the test case uses two different paths for drawing the border.
The reference on the slice case only draw three borders which leads into the contruction
of three different drawing paths that we use to clip and clip out. We then draw the border with
antialiasing off as we have constructed the outer and inner paths pretty accurately.
The test case in the other hand uses the fast path for drawing the borders. The slice effect
is in fact is happening because the graphics context is clipped to the current InlineFlowBox rect but still
the border has 4 edges and its drawing will happen using the following : create a path with
an outer rounded rectangle and an inner rounded rectangle. The path is then filled with RULE_EVENODD
and anti-aliasing turn on to achieve a nice looking effect.
To conclude the pixel differences are the fact of the two different drawing techniques used here. Fast
drawing and anti-aliasing to get a decent result or more accurate algorithm but slower. The original test
was not about testing the radiuses of the borders but rather if the borders are cloned or sliced. Even
removing the radius still cover the feature.
- fast/box-decoration-break/box-decoration-break-rendering-expected.html:
- fast/box-decoration-break/box-decoration-break-rendering.html:
- platform/mac/Skipped:
- 12:46 PM Changeset in webkit [121702] by
-
- 4 edits in trunk
[EFL][CMake] Integrate API unit tests with CTest
https://bugs.webkit.org/show_bug.cgi?id=87251
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-02
Reviewed by Daniel Bates.
.:
Enable CTest on the root CMakeLists.txt as it is expected
to be here. This will create a new build target ("make test")
to run all the API unit tests.
- CMakeLists.txt:
Source/WebKit:
Add every test to the test runner build target.
- PlatformEfl.cmake:
- 12:45 PM Changeset in webkit [121701] by
-
- 4 edits in trunk/Tools
REGRESSION(r121497): It switched off and broke many unittests
https://bugs.webkit.org/show_bug.cgi?id=90371
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2012-07-02
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest): Use snowleopard as os_version instead of leopard, because it isn't supported anymore.
- Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_all_test_configurations): Remove leopard testcases, because it isn't supported anymore.
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase): Inherit class PortTestCase from unittest.TestCase instead of object.
- 12:25 PM Changeset in webkit [121700] by
-
- 2 edits in trunk/Source/JavaScriptCore
Array.prototype.pop should throw if property is not configurable
https://bugs.webkit.org/show_bug.cgi?id=75788
Rubber Stamped by Oliver Hunt.
No real bug here any more, but the error we throw sometimes has a misleading message.
- runtime/JSArray.cpp:
(JSC::JSArray::pop):
- 12:22 PM Changeset in webkit [121699] by
-
- 9 edits in trunk/Tools
Move rebaseline-all command from the gardening-server down into webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=90395
Reviewed by Adam Barth.
This is just moving code. It it in preparation for making rebaseline-expectations
use the same code in order to get the parallelism benefits and reduces the amount
of code we have for doing rebaselines.
- Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CheckoutTest.test_apply_patch):
Updated due to the change to executive_mock.
- Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.run_command):
Update to print out the input passed to stdin.
- Scripts/webkitpy/tool/commands/download_unittest.py:
Updated due to executive_mock change.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineAll):
(RebaselineAll._run_webkit_patch):
(RebaselineAll._builders_to_fetch_from):
(RebaselineAll._rebaseline_commands):
(RebaselineAll._files_to_add):
(RebaselineAll._optimize_baselines):
(RebaselineAll._rebaseline):
(RebaselineAll.execute):
All this code is just copy-pasted except for mechanical changes
(e.g. self.server.tool --> self._tool) and the reading in of the
JSON from stdin instead of the post body.
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_all):
Copied the test-case out of gardeningserver_unittest.py.
- Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler):
(GardeningHTTPRequestHandler.rebaseline):
(GardeningHTTPRequestHandler.rebaselineall):
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaselineall):
(GardeningServerTest.test_rebaselineall.run_command):
- 12:12 PM Changeset in webkit [121698] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] New API tests introduced in r121620 fail
https://bugs.webkit.org/show_bug.cgi?id=90372
Reviewed by Luiz Agostini.
Updated the pixel comparison to produce more predictable results.
- UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:
(compareImages):
- 12:11 PM Changeset in webkit [121697] by
-
- 7 edits2 adds in trunk
<rdar://problem/11787030> In vertical writing modes, child following float-clearing block has incorrect logical top
https://bugs.webkit.org/show_bug.cgi?id=90359
Reviewed by Anders Carlsson.
Source/WebCore:
Test: fast/writing-mode/logical-height-after-clear.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloatsIfNeeded): Changed to use logicalTop() and logicalHeight()
instead of y() and height().
LayoutTests:
- fast/writing-mode/logical-height-after-clear-expected.html: Added.
- fast/writing-mode/logical-height-after-clear.html: Added.
- platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
- platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt:
- platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
- platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt:
- 11:25 AM Changeset in webkit [121696] by
-
- 5 edits in trunk/Tools
Remove Leopard support from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=90390
Reviewed by Adam Barth.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(nonChromiumPlatform):
(chromiumPlatform):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
- TestResultServer/static-dashboards/run-embedded-unittests.html:
- TestResultServer/static-dashboards/run-unittests.html:
- 11:08 AM Changeset in webkit [121695] by
-
- 2 edits in trunk/Tools
Fix posting from garden-o-matic. This broke in moving away from jquery's ajax method
in http://trac.webkit.org/changeset/121617.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
- 10:56 AM Changeset in webkit [121694] by
-
- 2 edits in trunk/LayoutTests
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591
Reviewed by Martin Robinson.
Create a new category for test failures that only fail on specific architecture. Tests
under this category are essentially marked as flaky, but in reality only fail on the
build architecture under which they are listed. This is a convenient workaround for
keeping tests from being recognized as newly-passing on architectures where the failure
does not occur.
- platform/gtk/TestExpectations:
- 10:50 AM Changeset in webkit [121693] by
-
- 2 edits in trunk/LayoutTests
Clean up slow HTTP tests on GTK platform
Rubber-stamped by Martin Robinson.
Skip the HTTP tests that take half a minute to run, most oftenly failing
as well. These tests only extend the overall testing time.
Also group the tests failing due to missing authentication handling in DRT,
missing multipart/x-mixed-replace support in libsoup and open a new bug
for the failing http/tests/plugins/plugin-document-has-focus.html test.
- platform/gtk/TestExpectations:
- 10:30 AM Changeset in webkit [121692] by
-
- 3 edits in trunk/Source/WebCore
Microdata: Fix build failure after r121580.
https://bugs.webkit.org/show_bug.cgi?id=90378
Reviewed by Ryosuke Niwa.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::properties):
- html/HTMLElement.h:
- 10:24 AM Changeset in webkit [121691] by
-
- 22 edits3 copies2 adds in trunk
MediaStream API: Update MediaStreamTrackList to match the specification
https://bugs.webkit.org/show_bug.cgi?id=90171
Reviewed by Adam Barth.
Source/Platform:
The latest update to the specification added add and remove methods with corresponding callbacks.
The callbacks can be triggered both from JS and from the platform layer.
- chromium/public/WebMediaStreamCenterClient.h:
(WebKit):
(WebMediaStreamCenterClient):
Source/WebCore:
The latest update to the specification added add and remove methods with corresponding callbacks.
The callbacks can be triggered both from JS and from the platform layer.
Test: fast/mediastream/MediaStreamTrackList.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::streamEnded):
(WebCore::MediaStream::addTrack):
(WebCore):
(WebCore::MediaStream::removeTrack):
- Modules/mediastream/MediaStream.h:
(MediaStream):
- Modules/mediastream/MediaStreamTrackEvent.cpp: Copied from Source/WebCore/Modules/mediastream/MediaStreamTrackList.cpp.
(WebCore):
(WebCore::MediaStreamTrackEvent::create):
(WebCore::MediaStreamTrackEvent::MediaStreamTrackEvent):
(WebCore::MediaStreamTrackEvent::~MediaStreamTrackEvent):
(WebCore::MediaStreamTrackEvent::track):
(WebCore::MediaStreamTrackEvent::interfaceName):
- Modules/mediastream/MediaStreamTrackEvent.h: Copied from Source/WebCore/Modules/mediastream/MediaStreamTrackList.h.
(WebCore):
(MediaStreamTrackEvent):
- Modules/mediastream/MediaStreamTrackEvent.idl: Copied from Source/WebCore/Modules/mediastream/MediaStreamTrackList.idl.
- Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::create):
(WebCore::MediaStreamTrackList::MediaStreamTrackList):
(WebCore::MediaStreamTrackList::detachOwner):
(WebCore):
(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):
(WebCore::MediaStreamTrackList::stop):
(WebCore::MediaStreamTrackList::interfaceName):
(WebCore::MediaStreamTrackList::scriptExecutionContext):
(WebCore::MediaStreamTrackList::eventTargetData):
(WebCore::MediaStreamTrackList::ensureEventTargetData):
- Modules/mediastream/MediaStreamTrackList.h:
(MediaStreamTrackList):
- Modules/mediastream/MediaStreamTrackList.idl:
- WebCore.gypi:
- dom/EventNames.h:
(WebCore):
- dom/EventNames.in:
- dom/EventTargetFactory.in:
- platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::addMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenter::removeMediaStreamTrack):
- platform/mediastream/MediaStreamCenter.h:
(MediaStreamCenter):
- platform/mediastream/MediaStreamDescriptor.h:
(MediaStreamDescriptorOwner):
- platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
(WebCore::MediaStreamCenterChromium::didAddMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenterChromium::didRemoveMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::addMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::removeMediaStreamTrack):
- platform/mediastream/chromium/MediaStreamCenterChromium.h:
(WebKit):
(MediaStreamCenterChromium):
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
(WebCore::MediaStreamCenterGStreamer::didAddMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenterGStreamer::didRemoveMediaStreamTrack):
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
(MediaStreamCenterGStreamer):
LayoutTests:
- fast/mediastream/MediaStreamTrackList-expected.txt: Added.
- fast/mediastream/MediaStreamTrackList.html: Added.
- 10:20 AM Changeset in webkit [121690] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: incorrect height of main timeline pane after switching to memory mode
https://bugs.webkit.org/show_bug.cgi?id=90387
Reviewed by Pavel Feldman.
- update cached container height when setting vertical splitter position.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.set _setSplitterPosition):
- 9:59 AM Changeset in webkit [121689] by
-
- 2 edits in trunk/Source/WebCore
[MICRODATA] Build failure in html/HTMLPropertiesCollection.h
https://bugs.webkit.org/show_bug.cgi?id=90379
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-02
Reviewed by Ryosuke Niwa.
Switch HTMLCollection::append() visibility from private
to protected so that HTMLPropertiesCollection subclass
can call it. This fixes build when MICRODATA flag is
turned on.
No new tests, build fix.
- html/HTMLCollection.h:
(HTMLCollectionCacheBase):
- 9:50 AM Changeset in webkit [121688] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectations update.
- platform/chromium/TestExpectations:
- 9:42 AM Changeset in webkit [121687] by
-
- 6 edits in trunk/LayoutTests
Unreviewed: Fix a flexbox reftest that was failing on most platforms.
Remove the test case that caused the image diff. I'll try to come up
with a different way to test this.
- css3/flexbox/anonymous-block-expected.html:
- css3/flexbox/anonymous-block.html:
- platform/chromium/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/Skipped:
- 9:31 AM Changeset in webkit [121686] by
-
- 3 edits2 adds in trunk/Source/WebKit2
[Qt] Fix WebProcess crash on Mac when accessing a site with video tag.
https://bugs.webkit.org/show_bug.cgi?id=90384
Reviewed by Jocelyn Turcotte.
We need to initialize the private symbols used by MediaPlayerPrivateQTKit
otherwise they will be null and it will lead to a crash. We copy WebSystemInterface
files for WK2 just like the Mac port as WK2 may have different needs than WK1 layer (we
may add or remove symbols in here). It doesn't fix the video rendering yet but it's
first step.
- Target.pri:
- WebProcess/WebCoreSupport/qt/WebSystemInterface.h: Added.
- WebProcess/WebCoreSupport/qt/WebSystemInterface.mm: Added.
(InitWebCoreSystemInterfaceForWK2):
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
- 9:22 AM Changeset in webkit [121685] by
-
- 2 edits in trunk/LayoutTests
This test is a flaky crash on the cr-linux-ews, which is causing the
bot to be very slow in processing patches and to spam bugs with false
failures. Mark this test as flaky while we investigate.
- platform/chromium/TestExpectations:
- 9:10 AM Changeset in webkit [121684] by
-
- 3 edits in trunk/Tools
[GTK] Read fonts path when running layout tests from alternative fonts dir when main dir doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=89437
Reviewed by Martin Robinson.
If main fonts directory doesn't exist, try with an alternative
fonts directory at build directory.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(getOutputDir):
(getFontsPath):
(initializeFonts):
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::getOutputDir):
(WTR):
(WTR::getFontsPath):
(WTR::inititializeFontConfigSetting):
- 9:08 AM Changeset in webkit [121683] by
-
- 2 edits in trunk/Source/WebCore
A start "body" tag in the "in body" insertion mode is a parse error
https://bugs.webkit.org/show_bug.cgi?id=90373
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-02
Reviewed by Eric Seidel.
According to HTML5 specification (http://www.w3.org/TR/html5/tree-construction.html#parsing-main-inbody),
a start "body" tag in the "in body" insertion mode is a parse error. So parseError(token) is required here.
No behavior change because parseError(token) is just a marker.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
- 8:59 AM Changeset in webkit [121682] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] [WK2] Remove content sniffer and decoder initialization from WebProcess
https://bugs.webkit.org/show_bug.cgi?id=90275
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-02
Reviewed by Martin Robinson.
Do not initialize content sniffer and decoder in the WebProcess
because the initialization is now done in WebCore.
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):
- 8:54 AM Changeset in webkit [121681] by
-
- 2 edits in trunk/Tools
[GTK] Don't run the tests with jhbuild wrapper if it's already running under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=89435
Reviewed by Martin Robinson.
- Scripts/new-run-webkit-tests: Don't run the tests with the
jhbuild wrapper if there isn't a Dependencies directory inside the
build directory.
- 8:32 AM Changeset in webkit [121680] by
-
- 5 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, update expected files, skip new failing tests.
- platform/qt-5.0-wk2/Skipped: Skip fast/viewport/viewport-91.html because of bug90376.
- platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Updated after r121599.
- platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Updated after r121599.
- platform/qt/Skipped: Skip inspector/debugger/script-snippet-model.html because of bug90385.
- 8:21 AM Changeset in webkit [121679] by
-
- 4 edits2 moves in trunk/Source/WebKit
[EFL] Rename NotificationPresenterEfl with NotificationClientEfl
https://bugs.webkit.org/show_bug.cgi?id=90370
Reviewed by Csaba Osztrogonác.
Source/WebKit:
Bug 80488 renamed NotificationPresenter with NotificationClient. So, EFL port needs to adjust
it as well.
- PlatformEfl.cmake:
Source/WebKit/efl:
Bug 80488 renamed NotificationPresenter with NotificationClient. So, EFL port needs to adjust it as well.
- WebCoreSupport/ChromeClientEfl.cpp:
- WebCoreSupport/NotificationClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp.
(WebCore):
(WebCore::NotificationClientEfl::NotificationClientEfl):
(WebCore::NotificationClientEfl::~NotificationClientEfl):
(WebCore::NotificationClientEfl::show):
(WebCore::NotificationClientEfl::cancel):
(WebCore::NotificationClientEfl::notificationObjectDestroyed):
(WebCore::NotificationClientEfl::notificationControllerDestroyed):
(WebCore::NotificationClientEfl::requestPermission):
(WebCore::NotificationClientEfl::checkPermission):
(WebCore::NotificationClientEfl::cancelRequestsForPermission):
- WebCoreSupport/NotificationClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h.
(WebCore):
(NotificationClientEfl):
- 7:20 AM Changeset in webkit [121678] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Unreviewed build fix with ENABLE_NETSCAPE_PLUGIN_API after r121467.
- plugins/efl/PluginPackageEfl.cpp:
(WebCore::PluginPackage::load): Move the declaration of `err'
before the first `goto' statement.
- 7:18 AM Changeset in webkit [121677] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: replace recursion with a stack in DOM nodes snapshot traversal.
https://bugs.webkit.org/show_bug.cgi?id=89889
Number of DOM nodes native snapshots can handle was limited
by the process stack size because of recursion used to traverse the nodes.
The patch changes the recursion to a stack based algorithm.
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-02
Reviewed by Yury Semikhatsky.
- dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(InstrumentedPointerBase):
(WebCore::MemoryInstrumentation::InstrumentedPointerBase::~InstrumentedPointerBase):
(InstrumentedPointer):
(WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer):
(WebCore::MemoryInstrumentation::reportInstrumentedPointer):
(WebCore):
(WebCore::::process):
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
- 7:12 AM Changeset in webkit [121676] by
-
- 6 edits2 adds in trunk
Web Inspector: Add requestFileContent command and fileContentReceived event
https://bugs.webkit.org/show_bug.cgi?id=89642
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-02
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: http/tests/inspector/filesystem/read-file.html
- inspector/Inspector.json:
- inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileContent):
- inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype.requestMetadata):
(WebInspector.FileSystemModel.prototype.requestFileContent):
(WebInspector.FileSystemModel.File.prototype.get resourceType):
(WebInspector.FileSystemModel.File.prototype.requestFileContent):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototype._metadataReceived):
(WebInspector.FileSystemRequestManager.prototype.requestFileContent.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestFileContent):
(WebInspector.FileSystemRequestManager.prototype._fileContentReceived):
(WebInspector.FileSystemDispatcher.prototype.metadataReceived):
(WebInspector.FileSystemDispatcher.prototype.fileContentReceived):
LayoutTests:
- http/tests/inspector/filesystem/read-file-expected.txt: Added.
- http/tests/inspector/filesystem/read-file.html: Added.
- 6:10 AM Changeset in webkit [121675] by
-
- 4 edits in trunk
Web Inspector: Add refresh button to FileSystemView status bar
https://bugs.webkit.org/show_bug.cgi?id=90244
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-02
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView):
(WebInspector.FileSystemView.prototype.get statusBarItems):
(WebInspector.FileSystemView.prototype.showView):
(WebInspector.FileSystemView.prototype._refresh):
(WebInspector.FileSystemView.EntryTreeElement.prototype._directoryContentReceived):
LayoutTests:
- http/tests/inspector/filesystem/directory-tree.html:
- 5:56 AM Changeset in webkit [121674] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed GTK gardening, removing GTK-specific baseline that's
not required anymore after r121661.
- platform/gtk/fast/viewport/viewport-91-expected.txt: Removed.
- 5:51 AM Changeset in webkit [121673] by
-
- 11 edits in trunk
Web Inspector: Implement snippets evaluation.
https://bugs.webkit.org/show_bug.cgi?id=88707
Reviewed by Pavel Feldman.
Source/WebCore:
Implemented snippet evaluation and adjusted breakpoints behavior when editing snippet.
Snippets are evaluated using separate compile and run.
Breakpoints are updated after compilation (once scriptId is available they can be set in debugger).
If separate compile and run is not supported by port or debugger is paused we fall back to evaluation in console.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.runScript.runCallback):
(WebInspector.ConsoleView.prototype.runScript):
(WebInspector.ConsoleView.prototype._printResult):
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.supportsEnabledBreakpointsWhileEditing):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointsBeforeEditing):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype.deleteScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._setScriptSnippetContent):
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet.compileCallback):
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._rawLocationToUILocation):
(WebInspector.ScriptSnippetModel.prototype._removeBreakpoints):
(WebInspector.ScriptSnippetModel.prototype._restoreBreakpoints):
(WebInspector.ScriptSnippetModel.prototype._evaluationSourceURL):
(WebInspector.SnippetJavaScriptSource.prototype.isDivergedFromVM):
(WebInspector.SnippetJavaScriptSource.prototype.workingCopyCommitted):
(WebInspector.SnippetJavaScriptSource.prototype.workingCopyChanged):
(WebInspector.SnippetJavaScriptSource.prototype.evaluate):
(WebInspector.SnippetJavaScriptSource.prototype.supportsEnabledBreakpointsWhileEditing):
(WebInspector.SnippetJavaScriptSource.prototype.breakpointStorageId):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
LayoutTests:
- inspector/debugger/script-snippet-model-expected.txt:
- inspector/debugger/script-snippet-model.html:
- 5:13 AM Changeset in webkit [121672] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: StyleSource should set content using CSSStyleModelResourceBinding directly.
https://bugs.webkit.org/show_bug.cgi?id=89891
Reviewed by Pavel Feldman.
StyleSource now calls CSS resource binding directly.
CSS resource binding now adds resource revision only after setStyleSheetText call returns from backend.
Resource.revertAndClearHistory is now clearing history asynchronously
since Resource.setContent adds revision that should be removed as well.
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getViaInspectorResourceForRule):
(WebInspector.CSSStyleModel.prototype.resourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype.setStyleContent.innerCallback):
(WebInspector.CSSStyleModelResourceBinding.prototype.setStyleContent):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.revertAndClearHistory):
(WebInspector.Resource.prototype.revertAndClearHistory.clearHistory):
- inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView.prototype._createResourceItem):
- inspector/front-end/StylesPanel.js:
(WebInspector.StyleSource.prototype.workingCopyCommitted):
(WebInspector.StyleSource.prototype.workingCopyChanged):
- 5:07 AM Changeset in webkit [121671] by
-
- 7 edits1 add in trunk/Source/WebCore
Web Inspector: Add DirectoryContentView for FileSystemView
https://bugs.webkit.org/show_bug.cgi?id=89961
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-02
Reviewed by Vsevolod Vlasov.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/DirectoryContentView.js: Added.
- inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView):
(WebInspector.FileSystemView.EntryTreeElement.prototype.onattach):
(WebInspector.FileSystemView.EntryTreeElement.prototype.onselect):
(WebInspector.FileSystemView.EntryTreeElement.prototype._directoryContentReceived):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 4:27 AM Changeset in webkit [121670] by
-
- 2 edits in trunk/Tools
[Qt] Simplify detection of non-installed module file
Has the additional advantage that we do not rely on additional information.
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-29
Reviewed by Tor Arne Vestbø.
- qmake/qt_webkit.pri:
- 3:55 AM Changeset in webkit [121669] by
-
- 7 edits1 add in trunk/LayoutTests
[EFL] Rebaseline needed after r121296 and r121599
https://bugs.webkit.org/show_bug.cgi?id=90364
Unreviewed EFL gardening. Update baselines for a few
test cases after r121296 and r121599.
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-02
- platform/efl/TestExpectations:
- platform/efl/fast/backgrounds/size/zero-expected.png:
- platform/efl/fast/backgrounds/size/zero-expected.txt:
- platform/efl/fast/transforms/bounding-rect-zoom-expected.png:
- platform/efl/fast/transforms/bounding-rect-zoom-expected.txt: Added.
- platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
- platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- 3:44 AM Changeset in webkit [121668] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Fix compilation error in GamepadsEfl.cpp in debug mode
https://bugs.webkit.org/show_bug.cgi?id=90369
Unreviewed, EFL build fix.
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-02
- platform/efl/GamepadsEfl.cpp:
(WebCore::GamepadsEfl::registerDevice):
(WebCore::GamepadsEfl::unregisterDevice):
- 3:30 AM Changeset in webkit [121667] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip fast/js/navigator-language.html
https://bugs.webkit.org/show_bug.cgi?id=90365
Unreviewed EFL gardening.
Skip fast/js/navigator-language.html until
Bug 89639 is fixed.
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-02
- platform/efl/TestExpectations:
- 2:50 AM Changeset in webkit [121666] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Design WebSockets panel
https://bugs.webkit.org/show_bug.cgi?id=89461
Use DataGrid to display the data.
Put "Data" column first. Make it wider.
Remove "Mask" column since it appears to be always true for outgoing frames,
and false for incoming.
Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-07-02
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView): Don't show Preview, Response, Cookies
and Timing tabs for succefuly established WebSocket connection.
- inspector/front-end/ResourceWebSocketFrameView.js:
(WebInspector.ResourceWebSocketFrameView):
- inspector/front-end/networkPanel.css:
(.resource-websocket):
(.resource-websocket, .resource-websocket .data-grid):
(.resource-websocket .data-grid .data):
(.resource-websocket td):
(.resource-websocket .data-column div):
(.resource-websocket-row-outcoming):
(.resource-websocket-row-outcoming:not(.selected) td):
(.resource-websocket-row-outcoming:not(.selected) td, .resource-websocket-row-outcoming:not(.selected) + tr td):
(.resource-websocket-row-opcode):
(.resource-websocket-row-opcode td):
(.resource-websocket-row-opcode td, .resource-websocket-row-opcode + tr td):
(.resource-websocket-row-error):
- 2:31 AM Changeset in webkit [121665] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed, rolling out r120329, r121113, and r121138.
http://trac.webkit.org/changeset/120329
http://trac.webkit.org/changeset/121113
http://trac.webkit.org/changeset/121138
https://bugs.webkit.org/show_bug.cgi?id=90368
Introduced noticeable keyboard-related spins due to
synchronous IPC. (Requested by kling on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-02
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::didReceiveEvent):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::keyEvent):
- 2:07 AM Changeset in webkit [121664] by
-
- 2 edits in trunk/LayoutTests
Add some expectations for the top flaky tests on chromium-linux.
- platform/chromium/TestExpectations:
- 1:42 AM Changeset in webkit [121663] by
-
- 4 edits in trunk/Source/WebCore
[V8Binding] Merging v8NumberArray()/v8NumberArrayToVector() to v8Array()/toNativeArray() respectively.
https://bugs.webkit.org/show_bug.cgi?id=90338
Patch by Vineet Chaudhary <Vineet> on 2012-07-02
Reviewed by Kentaro Hara.
We can remove v8NumberArray() and v8NumberArrayToVector() implementaion
merging them to current v8Array() and toNativeArray() traits.
Tests: TestObj.idl
Shouldn't cause any behavioural changes.
- bindings/scripts/CodeGeneratorV8.pm: Removed float[]/double[] specific binding code.
(IsRefPtrType):
(GetNativeType):
(JSValueToNative):
(NativeToJSValue):
- bindings/scripts/test/V8/V8TestObj.cpp: Rebased binding test.
(WebCore::TestObjV8Internal::floatArrayAttrGetter):
(WebCore::TestObjV8Internal::floatArrayAttrSetter):
(WebCore::TestObjV8Internal::doubleArrayAttrGetter):
(WebCore::TestObjV8Internal::doubleArrayAttrSetter):
- bindings/v8/V8Binding.h: Added templates for float and double.
(WebCore::v8Array):
(WebCore::toNativeArray):
- 12:50 AM Changeset in webkit [121662] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Updated Chromium test expectations. Added a missing bug
number to the expectations.
- platform/chromium/TestExpectations:
- 12:35 AM Changeset in webkit [121661] by
-
- 7 edits in trunk
[EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
https://bugs.webkit.org/show_bug.cgi?id=90286
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-07-02
Reviewed by Daniel Bates.
Source/WebCore:
Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result
was truncated. Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes.
- dom/ViewportArguments.h:
(ViewportArguments):
LayoutTests:
Unskip now passing tests.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- 12:10 AM Changeset in webkit [121660] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing test.
- platform/qt/Skipped:
- 12:07 AM Changeset in webkit [121659] by
-
- 5 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r121599.
- platform/qt/fast/transforms/bounding-rect-zoom-expected.txt:
- platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- 12:04 AM Changeset in webkit [121658] by
-
- 12 edits in trunk/Source/WebCore
Web Inspector: add v8 bindings memory info to the native memory graph
https://bugs.webkit.org/show_bug.cgi?id=90149
Reviewed by Pavel Feldman.
Size of V8 binding maps is now reported on the memory chart.
- bindings/js/ScriptProfiler.h:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
(WebCore):
- bindings/v8/DOMDataStore.h:
(WebCore):
(DOMDataStore):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::ChunkedTable::reportMemoryUsage):
(ChunkedTable):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
(WebCore):
- bindings/v8/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
- bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore):
(WebCore::StringCache::reportMemoryUsage):
- bindings/v8/V8Binding.h:
(WebCore):
(StringCache):
(V8BindingPerIsolateData):
- bindings/v8/V8DOMMap.h:
(WebCore):
(AbstractWeakReferenceMap):
- dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore):
(WebCore::MemoryInstrumentation::reportHashMap): added a method for reporting
size of a HashMap.
- inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
(WebCore::domTreeInfo):
Jul 1, 2012:
- 11:22 PM Changeset in webkit [121657] by
-
- 13 edits1 add in trunk
[EFL] Add Gamepad support
https://bugs.webkit.org/show_bug.cgi?id=90170
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-01
Reviewed by Kenneth Rohde Christiansen.
.:
- Source/cmake/FindEFL.cmake: Bump EFL libs dependencies.
- Source/cmake/OptionsEfl.cmake: Turn on GAMEPAD flag on EFL port.
- Source/cmakeconfig.h.cmake: Add GAMEPAD flag to CMake.
Source/WebCore:
Add support for the Gamepad feature on the EFL port.
The implementation of this class relies on the Linux
kernel joystick API.
Gamepad devices are recognized through the GamepadsEfl
class, of which implementation is based on Eeze
library. This way devices are properly registered on
connection as objects of the GamepadDeviceEfl class
which inherits GamepadDeviceLinux. GamepadDeviceEfl
reads the joystick data through an Ecore_Fd_Handler
and updates the device state accordingly. The
GamepadsEfl object is then polled for gamepads data
through the sampleGamepads method.
No new tests - already tested by gamepad/*
- CMakeLists.txt:
- PlatformEfl.cmake:
- platform/efl/GamepadsEfl.cpp: Added.
(WebCore):
(GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::create):
(WebCore::GamepadDeviceEfl::GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::~GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::readCallback):
(GamepadsEfl):
(WebCore::GamepadsEfl::onGamePadChange):
(WebCore::GamepadsEfl::GamepadsEfl):
(WebCore::GamepadsEfl::~GamepadsEfl):
(WebCore::GamepadsEfl::registerDevice):
(WebCore::GamepadsEfl::unregisterDevice):
(WebCore::GamepadsEfl::updateGamepadList):
(WebCore::sampleGamepads):
Tools:
- Scripts/webkitperl/FeatureList.pm: Turn on GAMEPAD flag
by default for EFL port.
- efl/jhbuild.modules: Bump dependency versions of EFL libs
since the latest Eeze is required for gamepad support.
LayoutTests:
Unskip gamepad/gamepad-api.html now that Gamepad
support is enabled on EFL port.
gamepad/gamepad-polling-access.html is still
skipped because it requires additional test
infrastructure.
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- 10:21 PM Changeset in webkit [121656] by
-
- 1 edit2 adds2 deletes in trunk/LayoutTests
Move platform/qt/fast/jsnavigator-language.html to fast/js
https://bugs.webkit.org/show_bug.cgi?id=90261
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-01
Reviewed by Ryosuke Niwa.
Efl needs a test case for navigator.language.
This test case is modified for all ports.
- fast/js/navigator-language-expected.txt: Copied from LayoutTests/platform/qt/fast/js/navigator-language-expected.txt.
- fast/js/navigator-language.html: Copied from LayoutTests/platform/qt/fast/js/navigator-language.html.
- platform/qt/fast/js/navigator-language-expected.txt: Removed.
- platform/qt/fast/js/navigator-language.html: Removed.
- 10:11 PM Changeset in webkit [121655] by
-
- 5 edits14 deletes in trunk/Source
Unreviewed, rolling out r121650.
http://trac.webkit.org/changeset/121650
https://bugs.webkit.org/show_bug.cgi?id=90303
runhooks is failing for chromium win bots and
WebAnimationTest.DefaultSettings is crashing
Source/Platform:
- Platform.gypi:
- chromium/public/WebAnimation.h: Removed.
- chromium/public/WebAnimationCurve.h: Removed.
- chromium/public/WebFloatAnimationCurve.h: Removed.
- chromium/public/WebFloatKeyframe.h: Removed.
- chromium/public/WebTransformAnimationCurve.h: Removed.
- chromium/public/WebTransformKeyframe.h: Removed.
Source/WebKit/chromium:
- WebKit.gyp:
- WebKit.gypi:
- src/WebAnimation.cpp: Removed.
- src/WebAnimationCurveCommon.cpp: Removed.
- src/WebAnimationCurveCommon.h: Removed.
- src/WebFloatAnimationCurve.cpp: Removed.
- src/WebTransformAnimationCurve.cpp: Removed.
- tests/WebAnimationTest.cpp: Removed.
- tests/WebFloatAnimationCurveTest.cpp: Removed.
- tests/WebTransformAnimationCurveTest.cpp: Removed.
- 10:07 PM Changeset in webkit [121654] by
-
- 4 edits in branches/safari-536-branch/Source
Versioning.
- 9:32 PM Changeset in webkit [121653] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Fix TestExpectations error caused in r121652.
Unreviewed.
- platform/chromium/TestExpectations:
- 9:15 PM Changeset in webkit [121652] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Removing LEOPARD from TestExpectations so the tests run.
Caused by r121595
Unreviewed.
- platform/chromium/TestExpectations:
- 7:55 PM Changeset in webkit [121651] by
-
- 6 edits in trunk
Unreviewed, rolling out r121635.
http://trac.webkit.org/changeset/121635
https://bugs.webkit.org/show_bug.cgi?id=90286
Breaks compile on clang error: in-class initializer for static
data member of type 'const float' is a GNU extension
[-Werror,-Wgnu]
Source/WebCore:
- dom/ViewportArguments.h:
(ViewportArguments):
LayoutTests:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- 7:21 PM Changeset in webkit [121650] by
-
- 5 edits14 adds in trunk/Source
[chromium] Create a WebKit::Web* wrapper for the cc animation classes
https://bugs.webkit.org/show_bug.cgi?id=90303
Patch by Ian Vollick <vollick@chromium.org> on 2012-07-01
Reviewed by James Robinson.
Source/Platform:
- Platform.gypi:
- chromium/public/WebAnimation.h: Added.
(WebCore):
(WebKit):
(WebAnimation):
(WebKit::WebAnimation::WebAnimation):
(WebKit::WebAnimation::~WebAnimation):
- chromium/public/WebAnimationCurve.h: Added.
(WebCore):
(WebKit):
(WebAnimationCurve):
(WebKit::WebAnimationCurve::~WebAnimationCurve):
(WebKit::WebAnimationCurve::WebAnimationCurve):
- chromium/public/WebFloatAnimationCurve.h: Added.
(WebCore):
(WebKit):
(WebFloatAnimationCurve):
(WebKit::WebFloatAnimationCurve::WebFloatAnimationCurve):
(WebKit::WebFloatAnimationCurve::~WebFloatAnimationCurve):
- chromium/public/WebFloatKeyframe.h: Added.
(WebKit):
(WebKit::WebFloatKeyframe::WebFloatKeyframe):
(WebFloatKeyframe):
- chromium/public/WebTransformAnimationCurve.h: Added.
(WebCore):
(WebKit):
(WebTransformAnimationCurve):
(WebKit::WebTransformAnimationCurve::WebTransformAnimationCurve):
(WebKit::WebTransformAnimationCurve::~WebTransformAnimationCurve):
- chromium/public/WebTransformKeyframe.h: Added.
(WebKit):
(WebKit::WebTransformKeyframe::WebTransformKeyframe):
(WebTransformKeyframe):
Source/WebKit/chromium:
- WebKit.gyp:
- WebKit.gypi:
- src/WebAnimation.cpp: Added.
(WebKit):
(WebKit::WebAnimation::iterations):
(WebKit::WebAnimation::setIterations):
(WebKit::WebAnimation::startTime):
(WebKit::WebAnimation::setStartTime):
(WebKit::WebAnimation::timeOffset):
(WebKit::WebAnimation::setTimeOffset):
(WebKit::WebAnimation::alternatesDirection):
(WebKit::WebAnimation::setAlternatesDirection):
(WebKit::WebAnimation::toCCActiveAnimation):
(WebKit::WebAnimation::initialize):
(WebKit::WebAnimation::destroy):
- src/WebAnimationCurveCommon.cpp: Added.
(WebKit):
(WebKit::createTimingFunction):
- src/WebAnimationCurveCommon.h: Added.
(WebCore):
(WebKit):
- src/WebFloatAnimationCurve.cpp: Added.
(WebKit):
(WebKit::WebFloatAnimationCurve::add):
(WebKit::WebFloatAnimationCurve::toCCAnimationCurve):
(WebKit::WebFloatAnimationCurve::initialize):
(WebKit::WebFloatAnimationCurve::destroy):
- src/WebTransformAnimationCurve.cpp: Added.
(WebKit):
(WebKit::WebTransformAnimationCurve::add):
(WebKit::WebTransformAnimationCurve::toCCAnimationCurve):
(WebKit::WebTransformAnimationCurve::initialize):
(WebKit::WebTransformAnimationCurve::destroy):
- tests/WebAnimationTest.cpp: Added.
- tests/WebFloatAnimationCurveTest.cpp: Added.
- tests/WebTransformAnimationCurveTest.cpp: Added.
- 7:12 PM Changeset in webkit [121649] by
-
- 7 edits1 copy2 adds in trunk/Source/WebKit2
[EFL][WK2] Add API to inspect a Web Intent
https://bugs.webkit.org/show_bug.cgi?id=89749
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-01
Reviewed by Kenneth Rohde Christiansen.
Add EFL API to inspect a Web Intent and emit a signal
on the view when a new intent request is made.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_intent.cpp: Added.
(_Ewk_Intent):
(ewk_intent_ref):
(ewk_intent_unref):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):
(ewk_intent_new):
- UIProcess/API/efl/ewk_intent.h: Added.
- UIProcess/API/efl/ewk_intent_private.h: Copied from Source/WebKit2/UIProcess/API/efl/ewk_view_loader_client.cpp.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_intent_request_new):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_loader_client.cpp:
(didReceiveIntentForFrame):
(ewk_view_loader_client_attach):
- UIProcess/API/efl/ewk_view_private.h:
- 5:40 PM Changeset in webkit [121648] by
-
- 1 copy in tags/Safari-536.25
New Tag.
- 5:34 PM Changeset in webkit [121647] by
-
- 2 edits in trunk/Tools
Unreviewed.
Using the default start cylinder for fdisk causes a warning about the
partition not starting on physical sector boundary. The Ubuntu forums
recommend using a number that's divisible by 8, which is what we do in
this patch.
- EWSTools/cold-boot.sh:
- 5:27 PM Changeset in webkit [121646] by
-
- 4 edits in trunk/Source
Make the "Inspect Element" context menu item appear in nightly builds again.
rdar://problem/11702613
https://webkit.org/b/89323
Reviewed by Dan Bernstein.
Source/WebCore:
- platform/ContextMenuItem.h:
Fix the order of the ContextMenuAction enum to be binary compatible with
older versions of WebKit.
Source/WebKit/mac:
- WebView/WebUIDelegatePrivate.h:
Add missing enums that were added in ContextMenuItem.h but left out here.
- 5:08 PM Changeset in webkit [121645] by
-
- 3 edits3 adds in trunk
<rdar://problem/11785743> [mac] Non-BMP characters in vertical text appear as missing glyphs
https://bugs.webkit.org/show_bug.cgi?id=90349
Reviewed by Dean Jackson.
Source/WebCore:
Test: platform/mac/fast/text/vertical-surrogate-pair.html
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::GlyphPage::fill): When calling wkGetVerticalGlyphsForCharacters or
CTFontGetGlyphsForCharacters with a buffer consisting of surrogate pair, account for those
functions’ behavior of placing glyphs at indices corresponding to the first character of
each pair.
LayoutTests:
- platform/mac/fast/text/vertical-surrogate-pair.html: Added.
- platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Added.
- platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Added.
- 5:08 PM Changeset in webkit [121644] by
-
- 3 edits in trunk/Tools
Unreviewed.
It turns out we need to use Ubuntu 10.04 to get the right image results
for chromium-linux. This patch updates our scripts to be compatible
with Ubuntu 10.04.
- EWSTools/cold-boot.sh:
- fdisk doesn't have p and 1 as default commands in 10.04.
- EWSTools/start-queue.sh:
- git doesn't understanding the -B argument in 10.04. We've been using this change locally on the EC2 bots for a while.
- 4:08 PM Changeset in webkit [121643] by
-
- 3 edits2 adds in trunk
Arabic shaping is incorrect if ZWNJ exist
https://bugs.webkit.org/show_bug.cgi?id=89843
Reviewed by Dan Bernstein.
Source/WebCore:
mac port treats ZWJ (zero-width-joiner) and ZWNJ (zero-width-non-joiner) as a part of combining
character sequence. This could cause a problem when the font doesn't have glyph mapping of ZWJ and ZWNJ.
Suppose the text to be rendered is "U+0645(MEEM) U+06CC(FARSI YEH) U+200C(ZWNJ)". In this case, U+0645
and U+06CC are rendered in isolated form if the font doesn't have a glyph for ZWNJ. They should be joined.
This patch changes handling of ZWJ and ZWNJ. Treats ZWJ and ZWNJ as base characters so that a complex text
run isn't separate at the point of ZWJ and ZWNJ even the font doesn't contain glyphs for them.
If ComplexTextController finds ZWJ, it doesn't split the current complex text run.
Test: platform/mac/fast/text/arabic-zwj-and-zwnj.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::advanceByCombiningCharacterSequence): Don't treat ZWJ and ZWNJ as a part of combining character sequence.
(WebCore::ComplexTextController::collectComplexTextRuns): Set fontData to nextFontData if the baseCharacter is ZWJ.
LayoutTests:
- platform/mac/fast/text/arabic-zwj-and-zwnj-expected.html: Added.
- platform/mac/fast/text/arabic-zwj-and-zwnj.html: Added.
- 3:54 PM Changeset in webkit [121642] by
-
- 3 edits in trunk/LayoutTests
Unreviewed rebaseline for mac post r121599.
- platform/mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- 3:49 PM Changeset in webkit [121641] by
-
- 2 edits in trunk/Tools
Unreviewed.
- EWSTools/boot.sh:
- We need to start the screen in detached mode so that we can run it remotely via ssh.
- 3:44 PM Changeset in webkit [121640] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations update for chromium.
- platform/chromium/TestExpectations:
- 3:40 PM Changeset in webkit [121639] by
-
- 2 edits in branches/safari-536-branch/Source/WebKit2
Merged r120377
- 3:37 PM Changeset in webkit [121638] by
-
- 5 edits in branches/safari-536-branch/Source/WebKit2
Merged r121167
- 3:34 PM Changeset in webkit [121637] by
-
- 2 edits in branches/safari-536-branch/Source/WebKit2
Rollout r121168
- 2:30 PM Changeset in webkit [121636] by
-
- 2 edits in trunk/Tools
Unreviewed.
- EWSTools/cold-boot.sh:
- Turns out we need to sudo this command in order for it to actually dimiss the EULA screen. :)
- 2:16 PM WebInspector edited by
- (diff)
- 2:01 PM Changeset in webkit [121635] by
-
- 6 edits in trunk
[EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
https://bugs.webkit.org/show_bug.cgi?id=90286
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-07-01
Reviewed by Daniel Bates.
Source/WebCore:
Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result
was truncated. Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes.
- dom/ViewportArguments.h:
(ViewportArguments):
LayoutTests:
Unskip now passing tests.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- 10:09 AM Changeset in webkit [121634] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Clear visited links when clearing history.
https://bugs.webkit.org/show_bug.cgi?id=90345
Reviewed by Antonio Gomes.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::clearHistory):