Timeline



Jul 25, 2012:

11:37 PM Changeset in webkit [123710] by dgrogan@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

IndexedDB: WebKit API interfaces for "upgradeneeded" methods and events
https://bugs.webkit.org/show_bug.cgi?id=92203

Reviewed by Adam Barth.

This is the beginning of our typical three-sided-patch process.

  • public/WebIDBCallbacks.h:

(WebKit::WebIDBCallbacks::onBlocked):
(WebKit::WebIDBCallbacks::onUpgradeNeeded):

  • public/WebIDBDatabaseCallbacks.h:

(WebKit::WebIDBDatabaseCallbacks::onVersionChange):

  • public/WebIDBFactory.h:

(WebIDBFactory):
(WebKit::WebIDBFactory::open):

  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::open):
(WebKit):

  • src/WebIDBFactoryImpl.h:

(WebIDBFactoryImpl):

11:30 PM Changeset in webkit [123709] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

Upstream declaration of WebGraphicsContext3D::createStreamTextureCHROMIUM() for android
https://bugs.webkit.org/show_bug.cgi?id=92308

Patch by Min Qin <qinmin@chromium.org> on 2012-07-25
Reviewed by Adam Barth.

For android, we need 2 calls to create and destroy the stream texture.
This change adds the interface for these 2 calls.
The actual implementation will be in webgraphicscontext3d_in_process_impl and webgraphicscontext3d_command_buffer_impl.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::createStreamTextureCHROMIUM):
(WebKit::WebGraphicsContext3D::destroyStreamTextureCHROMIUM):

11:06 PM Changeset in webkit [123708] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for 32-bit after r123682

  • runtime/JSObject.h: Need to pad out JSObjects on 32-bit so that they're the correct size since

we only removed one 4-byte word and we need to be 8-byte aligned.
(JSObject):

9:02 PM Changeset in webkit [123707] by tkent@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebKit/chromium/src/WebPagePopupImpl.cpp

Merge 123619 - [chromium] Calendar picker popup displays at wrong scale when deviceScaleFactor != 1.
https://bugs.webkit.org/show_bug.cgi?id=92177

Manually tested at deviceScaleFactor = 1 and 2.

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-25
Reviewed by Kent Tamura.

The device scale factor was not being set for the calendar popup.
As a result, the popup was rendered too small on hidpi displays.
This patch sets the device scale factor for any page popup.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initPage):

TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829030

8:26 PM Changeset in webkit [123706] by morrita@google.com
  • 7 edits in trunk

[Chromium][Win] <progress> animation on RTL direction is reverse
https://bugs.webkit.org/show_bug.cgi?id=92236

Reviewed by Kent Tamura.

Source/WebCore:

This change modfies the way to handle RTL progress bar painting.
Originally it computes the flipped coordinates. This change uses transformation for the flip.
DirectionFlippingScope handles it.

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::RenderThemeChromiumLinux::paintProgressBar): Applied DirectionFlippingScope

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::determinateProgressValueRectFor):

  • Deleted RTL handling in favor of DirectionFlippingScope

(WebCore::RenderThemeChromiumSkia::DirectionFlippingScope::DirectionFlippingScope):
(WebCore):
(WebCore::RenderThemeChromiumSkia::DirectionFlippingScope::~DirectionFlippingScope):

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):
(DirectionFlippingScope): Added.

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::paintProgressBar): Applied DirectionFlippingScope

LayoutTests:

Updated the expectation file which went slightly different.

  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
8:24 PM Changeset in webkit [123705] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=92260
Repalce "int" with "long" from WebCore/*.idls

Patch by Vineet Chaudhary <Vineet> on 2012-07-25
Reviewed by Adam Barth.

As per the WebIDL spec IDL shouldn't have int attributes but long instead.
Repalced attributes types int with long from WebCore/*.idls.

No new tests. TestObj.idl already covers this.
There should be no behavioural changes.

  • dom/Touch.idl: Repalce int with long.
  • dom/WebKitNamedFlow.idl: Ditto.
  • html/canvas/ArrayBuffer.idl: Ditto.
  • html/canvas/WebGLActiveInfo.idl: Ditto.
  • html/canvas/WebGLShaderPrecisionFormat.idl: Ditto.
  • page/WebKitAnimation.idl: Ditto.
8:10 PM Changeset in webkit [123704] by shinyak@chromium.org
  • 3 edits
    4 adds in trunk

The elements in ShadowDOM of meter or progress should not be modifiable.
https://bugs.webkit.org/show_bug.cgi?id=92199

Reviewed by Hajime Morita.

Source/WebCore:

A user can set -webkit-user-modify: read-write to the elements in Shadow DOM in a meter or progress element.
This might cause a undesired crash like Bug 65738. They should be unmodifiable.

We add default css values to elements in ShadowDOM of meter or progress to prohibit editing them.

Tests: fast/html/meter-user-modify.html

fast/html/progress-user-modify.html

  • css/html.css:

Added -webkit-user-modify: read-only !important; for these elements so that they won't be
changed by a user.
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimum-value):
(meter::-webkit-meter-even-less-good-value):
(progress::-webkit-progress-bar):
(progress::-webkit-progress-value):

LayoutTests:

  • fast/html/meter-user-modify.html: Added.
  • fast/html/meter-user-modify-expected.txt: Added.
  • fast/html/progress-user-modify.html: Added.
  • fast/html/progress-user-modify-expected.txt: Added.
8:02 PM Changeset in webkit [123703] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Implement the inspector for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=92213

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-25
Reviewed by Ryosuke Niwa.

Partial Implementation of WebInspectorProxyEfl for WebkitTestRunner.
And Web Inspector resources installation.

  • PlatformEfl.cmake:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

7:52 PM Changeset in webkit [123702] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] GraphicsContext3D::paintToCanvas should not swap 0th and 2nd components of color
https://bugs.webkit.org/show_bug.cgi?id=92314

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

No new tests, because it corrects existing functionality, but it makes BlackBerry
pass canvas-text.html and others.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::paintToCanvas):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):

7:46 PM Changeset in webkit [123701] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] GraphicsContext3D::reshapeFBOs does not report when bound FBOs should be restored
https://bugs.webkit.org/show_bug.cgi?id=92304

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

No new tests, because it corrects existing functionality, but it makes BlackBerry
pass framebuffer-bindings-unaffected-on-resize.html.

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs):

7:36 PM Changeset in webkit [123700] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] readPixels should set alpha to 255 instead of 0 when alpha is disabled
https://bugs.webkit.org/show_bug.cgi?id=92303

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

No new tests, because it corrects existing functionality, but it makes BlackBerry
pass context-attributes-alpha-depth-stencil-antialias.html.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::readPixels):

7:32 PM Changeset in webkit [123699] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WebGL] fast/canvas/webgl/framebuffer-object-attachment.html fails on certain platforms
https://bugs.webkit.org/show_bug.cgi?id=92296

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

No new tests, because it introduces no new functionality, only fixes the above mentioned test.

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::checkStatus):

7:30 PM Changeset in webkit [123698] by commit-queue@webkit.org
  • 8 edits in trunk

IndexedDB: IDBTransaction::abort() should throw DOMException
https://bugs.webkit.org/show_bug.cgi?id=92069

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-07-25
Reviewed by Kentaro Hara.

Source/WebCore:

Keep aligned with the W3C spec.
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBTransaction-abort-void

Test: storage/indexeddb/transaction-abort.html.

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::abort):
(WebCore):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

Add the exception test for IDBTransaction::abort().

  • storage/indexeddb/resources/transaction-abort.js:

(transactionAborted):

  • storage/indexeddb/transaction-abort-expected.txt:
7:28 PM Changeset in webkit [123697] by commit-queue@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

[BlackBerry] Update fast/canvas/webgl expectations
https://bugs.webkit.org/show_bug.cgi?id=92309

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

Add the css-webkit-canvas-* files, because we render them correctly.

There is nothing we can do about running out of memory on draw-elements-out-of-bounds,
so make that expected.

Our output for framebuffer-object-attachement-expected.txt is valid.

  • platform/blackberry/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
  • platform/blackberry/fast/canvas/webgl/css-webkit-canvas-expected.txt: Added.
  • platform/blackberry/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
  • platform/blackberry/fast/canvas/webgl/css-webkit-canvas-repaint-expected.txt: Added.
  • platform/blackberry/fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Added.
  • platform/blackberry/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
7:24 PM Changeset in webkit [123696] by tony@chromium.org
  • 3 edits
    2 adds in trunk

flexitems can overflow the flexbox due to rounding
https://bugs.webkit.org/show_bug.cgi?id=92163

Reviewed by Levi Weintraub.

Source/WebCore:

Don't round flex item sizes and use LayoutPoint for the location of flex items.

Test: css3/flexbox/flex-rounding.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):

LayoutTests:

Tests for dividing space in non-integral amounts.

  • css3/flexbox/flex-rounding-expected.txt: Added.
  • css3/flexbox/flex-rounding.html: Added.
7:19 PM Changeset in webkit [123695] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/Tools

TestRunner.a should contain a TestRunner object
https://bugs.webkit.org/show_bug.cgi?id=92313

Reviewed by Kent Tamura.

This patch adds a stub implementation of TestRunner, which is the new
home for our implementation of window.testRunner. A future patch will
migrate functions from LayoutTestController to TestRunner.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestRunner/TestRunner.cpp: Added.
  • DumpRenderTree/chromium/TestRunner/TestRunner.h: Added.
7:16 PM Changeset in webkit [123694] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Integrate certmgr with CredentialBackingStore
https://bugs.webkit.org/show_bug.cgi?id=92183

Patch by Jonathan Dong <Jonathan Dong> on 2012-07-25
Reviewed by George Staikos.

Integrated BlackBerry::Platform::CertMgrWrapper with
CredentialBackingStore, when certmgr is ready we save
the password in certmgr and retrieve it from certmgr.

RIM PR: 171991
Internally reviewed by Joe Mason <jmason@rim.com>.

No new tests since there's no functional change.

  • platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::hashCredentialInfo):
(WebCore):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::getLogin):

  • platform/network/blackberry/CredentialBackingStore.h:

(CredentialBackingStore):

7:14 PM Changeset in webkit [123693] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Support RTSP in browser
https://bugs.webkit.org/show_bug.cgi?id=92233

Patch by Jonathan Dong <Jonathan Dong> on 2012-07-25
Reviewed by Rob Buis.

Handle URL scheme "rtsp://" before creating the DocumentLoader
and send the request to webkit. As we don't have any application
which can deal with rtsp invocation for now, we need to create
a media document to wrap the rtsp url within a video tag which
makes it load as a normal video clip.

RIM PR: 169669
Internally reviewed by Charles Wei <charles.wei@torchmobile.com.cn>.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):

7:05 PM Changeset in webkit [123692] by yosin@chromium.org
  • 4 edits in trunk/LayoutTests

[Tests] Re-factor fast/forms/number/number-spinbutton-change-and-input-events.html
https://bugs.webkit.org/show_bug.cgi?id=92206

Reviewed by Kent Tamura.

For ease of maintenance and improving test coverage with low cost, I
would like to make a test script of number-spinbutton-change-and-inputs.html
sharable with other input types which have spin button.

This patch moves JavaScript codes from test HTML file to shared JavaScript
file, common-spinbutton-change-and-input-events.html with parametrized
entry point for specifying input type.

  • fast/forms/number/number-spinbutton-change-and-input-events-expected.txt: Changed "numnber" to "number", and "numberInput" to "testInput".
  • fast/forms/number/number-spinbutton-change-and-input-events.html: Removed JavaScript code.
  • fast/forms/resources/common-spinbutton-change-and-input-events.js: Removed HTML code. Made entry point. Changed to support testing without maximum value.
6:36 PM Changeset in webkit [123691] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r121420): Performance regression of form state saving for pages with multiple forms
https://bugs.webkit.org/show_bug.cgi?id=91804

Reviewed by Hajime Morita.

The complexity of FormKeyGenerator::formKey() was O(N) where N is the
number form elements with an identical action URL, and formKey() is
called for every form. So, it's O(N2). A page in www.reddit.com
contains hundreds of form elements with action="#". So FormController::
formElementsState() took a few seconds on a slow machine.

In order to avoid O(N2) operation, storing a map from form signatures
to next index numbers, instead of storing existing formKey strings.

No new tests. Just a performance improvement.

Note: This is a re-landing of r123191. We rolled it out because of
suspicion of a performance regression. However it was innocent.

  • html/FormController.cpp:

(FormKeyGenerator): Remove m_existingKeys. Add a map from a form
signature string to the next index number.
(WebCore::formSignature): Returns a signature string for a form, without
an index number. This is like "actionURL [name1 name2 ]"
(WebCore::FormKeyGenerator::formKey):
Creates a formKey string by concatenating a formSignature and #n. N is
obtained from m_formSignatureToNextIndexMap in O(1).
(WebCore::FormKeyGenerator::willDeleteForm):
Remove the code for m_existingKeys.

6:22 PM Changeset in webkit [123690] by fpizlo@apple.com
  • 7 edits
    1 add in trunk/Source/JavaScriptCore

JSC GC object copying APIs should allow for greater flexibility
https://bugs.webkit.org/show_bug.cgi?id=92316

Reviewed by Mark Hahnenberg.

It's now the case that visitChildren() methods can directly pin and allocate in new space during copying.
They can also do the copying and marking themselves. This new API is only used for JSObjects for now.

(JSC::SlotVisitor::allocateNewSpaceSlow):
(JSC::SlotVisitor::allocateNewSpaceOrPin):
(JSC):
(JSC::SlotVisitor::copyAndAppend):

  • heap/MarkStack.h:

(MarkStack):
(JSC::MarkStack::appendUnbarrieredValue):
(JSC):

  • heap/SlotVisitor.h:
  • heap/SlotVisitorInlineMethods.h: Added.

(JSC):
(JSC::SlotVisitor::checkIfShouldCopyAndPinOtherwise):
(JSC::SlotVisitor::allocateNewSpace):

  • runtime/JSObject.cpp:

(JSC::JSObject::visitOutOfLineStorage):
(JSC):
(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):

  • runtime/JSObject.h:

(JSObject):

6:05 PM Changeset in webkit [123689] by benjamin@webkit.org
  • 9 edits in trunk/Source

Initialize QualifiedName's strings from the read only data segment
https://bugs.webkit.org/show_bug.cgi?id=92226

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-25
Reviewed by Anders Carlsson.

Source/WebCore:

Modify the initialization of static QualifiedName to initialize the AtomicString
with the data from the read only memory.

Overall, HTMLNames::init() gets 10% faster.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::QualifiedName):

  • dom/QualifiedName.h:

(QualifiedName):
Remove the useless constructor taking a char* and get rid of the init() function.
The AtomicString representing the name should be constructed by the caller of QualifiedName.

Because the init() code is relatively large and is only executed once, it is important to
keep the AtomicString construction separate. The function createQualifiedName() was added
to improve the cache use. The short version let us reduce the code one more instruction per
call.

  • dom/make_names.pl:

(printQualifiedNameMaker):
(printShortQualifiedNameMaker):
(printNamesCppFile):
(printDefinitions):

Source/WTF:

Add constructors for StringImpl and AtomicString to be able to create
the strings from the literal in read only memory.

  • wtf/text/AtomicString.cpp:

(HashTranslatorCharBuffer):
(WTF::LCharBufferFromLiteralDataTranslator::hash):
(LCharBufferFromLiteralDataTranslator):
(WTF::LCharBufferFromLiteralDataTranslator::equal):
(WTF::LCharBufferFromLiteralDataTranslator::translate):
(WTF::AtomicString::addFromLiteralData):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):
(AtomicString):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::createFromLiteral):

  • wtf/text/StringImpl.h:

(WTF):
(StringImpl):
(WTF::StringImpl::createFromLiteral):

6:01 PM Changeset in webkit [123688] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/win

Changes to the WebFrame API cause dependent apps to crash.
https://bugs.webkit.org/show_bug.cgi?id=91656
<rdar://problem/11904605>

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-25
Reviewed by Jon Honeycutt.

Changes to the WebFrame API cause certain apps to crash because of inconsistencies in the COM interface.
The resumeAnimations and suspendAnimations are removed, which are still needed.
The counterValueByElementId method was also removed, although is not needed there.
However, for all of these methods, no method stubs were added where appropriate after removal.

  • Interfaces/IWebFramePrivate.idl:

Added resumeAnimations() and suspendAnimations() methods back in. Added unused method stub for counterValueByElementId method.

  • WebFrame.cpp:

(WebFrame::resumeAnimations):
Added this method back in.
(WebFrame::suspendAnimations):
Added this method back in.

  • WebFrame.h:

(Re)added methods and unused method stubs.

6:01 PM Changeset in webkit [123687] by yosin@chromium.org
  • 9 edits in trunk/Source/WebCore

[Forms] Move HTMLInputElement::updateInnerTextValue to InputType class
https://bugs.webkit.org/show_bug.cgi?id=92230

Reviewed by Kent Tamura.

This patch moves implementaion of HTMLInputElement::updateInnerTextValue()
into input type classes, removes updateInnerTextValue() from HTMLInputElement,
and updates call site of updateInnerTextValue().

No new tests. This patch doesn't change behavior.

  • html/DateInputType.cpp:

(WebCore::DateInputType::handleBlurEvent): Updated call site of updateInnerTextValue().

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType): Updated call site of updateInnerTextValue().
(WebCore::HTMLInputElement::parseAttribute): Updated call site of updateInnerTextValue().
(WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement): Updated call site of updateInnerTextValue().
(WebCore::HTMLInputElement::setSuggestedValue): Updated call site of updateInnerTextValue().

  • html/HTMLInputElement.h:

(HTMLInputElement): Removed updateInnerTextValue().

  • html/InputType.cpp:

(WebCore::InputType::updateInnerTextValue): Added default implementaion.

  • html/InputType.h:

(InputType): Added declaration of updateInnerTextValue().

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::handleBlurEvent): Updated call site of updateInnerTextValue().

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue): Updated call site of updateInnerTextValue().
(WebCore::TextFieldInputType::updateInnerTextValue): Moved implementaion from HTMLInputElement.

  • html/TextFieldInputType.h:

(TextFieldInputType): Added declaration of updateInnerTextValue().

5:57 PM Changeset in webkit [123686] by danakj@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Move ephemeral data for a single frame in LayerRendererChromium into a structure with a scoped lifetime equal to the frame
https://bugs.webkit.org/show_bug.cgi?id=92294

Reviewed by Adrienne Walker.

The LayerRendererChromium class has a number of member variables that are used
while drawing a single frame. Because they are member variables, their lifetimes
are not clear, and some are even updated between frames, which is not needed.

This change creates a LRC::DrawingFrame structure that holds the data used
while drawing the current frame, and an instance of this structure is held
and passed around to functions in LayerRendererChromium, moving all of the
data out from being member variables on the class to being function
arguments on the relevant methods.

The projection and window matrices are a part of this frame data, and are not
used externally, so they are removed from the CCRenderer interface and included
within the DrawingFrame structure.

Covered by existing tests, no change in behaviour intended.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::clearFramebuffer):
(WebCore::LayerRendererChromium::drawFrame):
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawIOSurfaceQuad):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::drawTexturedQuad):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):
(WebCore::LayerRendererChromium::isCurrentRenderPass):
(WebCore::LayerRendererChromium::useRenderPass):
(WebCore::LayerRendererChromium::useScopedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawFramebufferRect):

  • platform/graphics/chromium/LayerRendererChromium.h:

(DrawingFrame):
(WebCore::LayerRendererChromium::DrawingFrame::DrawingFrame):
(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

5:53 PM Changeset in webkit [123685] by enne@google.com
  • 8 edits in trunk/Source

[chromium] Make all compositor screen space transforms operate on content rects
https://bugs.webkit.org/show_bug.cgi?id=91807

Reviewed by Kenneth Russell.

Source/WebCore:

Previously, surface screen space transforms operated on surface
content space but layer screen space transforms operated on layer
space. For the purpose of consistency, unify these two so that they
both operate on content space.

No tests, because no change in behavior expected. Just a refactoring.

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCDebugRectHistory.cpp:

(WebCore::CCDebugRectHistory::savePaintRects):
(WebCore::CCDebugRectHistory::savePropertyChangedRects):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsInternal):
(WebCore::CCLayerTreeHostCommon::findLayerThatIsHitByPoint):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::markOccludedBehindLayer):
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

Source/WebKit/chromium:

Update tests that deal with screen space transforms to reflect this change.

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
5:30 PM Changeset in webkit [123684] by mitz@apple.com
  • 3 edits
    4 adds in trunk

Hit testing in one column or in the gap between cloumns along the block axis can return a result from the wrong column
https://bugs.webkit.org/show_bug.cgi?id=92311

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: fast/multicol/hit-test-end-of-column.html

fast/multicol/hit-test-gap-block-axis.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPointWithInlineChildren): To prevent hits after the last
line on a given column from returning the next line in the next column, added a check if
the hit occurred within the pagination strut of a line. Covered by the first test.
(WebCore::RenderBlock::adjustPointToColumnContents): Added clamp-to-column logic for the
block-axis case. This prevents hits near the bottom of the top half of the gap from bleeding
into the top of the next column. Covered by the second test.

LayoutTests:

  • fast/multicol/hit-test-end-of-column-expected.txt: Added.
  • fast/multicol/hit-test-end-of-column.html: Added.
  • fast/multicol/hit-test-gap-block-axis-expected.txt: Added.
  • fast/multicol/hit-test-gap-block-axis.html: Added.
5:24 PM Changeset in webkit [123683] by dgrogan@chromium.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Make db.version return an integer if appropriate
https://bugs.webkit.org/show_bug.cgi?id=92195

Reviewed by Tony Chang.

Make use of the existing IDBAny mechanism to return an integer if
integer versions have been used.

No new tests - no change in behavior expected.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::version):
(WebCore):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabase.idl:
5:12 PM Changeset in webkit [123682] by mhahnenberg@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove JSObject::m_inheritorID
https://bugs.webkit.org/show_bug.cgi?id=88378

Reviewed by Filip Pizlo.

This is rarely used, and not performance critical (the commonly accessed copy is cached on JSFunction),
and most objects don't need an inheritorID (this value is only used if the object is used as a prototype).
Instead use a private named value in the object's property storage.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject): No need m_inheritorID to initialize!

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject): No need m_inheritorID to initialize!

  • llint/LowLevelInterpreter.asm: No need m_inheritorID to initialize!
  • runtime/JSGlobalData.h:

(JSGlobalData): Added private name 'm_inheritorIDKey'.

  • runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::setUnwrappedObject): resetInheritorID is now passed a JSGlobalData&.

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren): No m_inheritorID to be marked.
(JSC::JSFinalObject::visitChildren): No m_inheritorID to be marked.
(JSC::JSObject::createInheritorID): Store the newly created inheritorID in the property map. Make sure
it's got the DontEnum attribute!!

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::resetInheritorID): Remove the inheritorID from property storage.
(JSC):
(JSC::JSObject::inheritorID): Read the inheritorID from property storage.

5:05 PM Changeset in webkit [123681] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Chromium] Fix infinite loop issue for chromium android layout test
https://bugs.webkit.org/show_bug.cgi?id=92197

Patch by Wei James <james.wei@intel.com> on 2012-07-25
Reviewed by Adam Barth.

The change brought in by r123530 will cause infinite loop when running
Chromium Android Layout Test.
Revert the change for this line only.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort._build_path):

4:48 PM Changeset in webkit [123680] by atwilson@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed chromium change to disable failing WebViewTest.AutoResizeInBetweenSizes.
https://bugs.webkit.org/show_bug.cgi?id=92318

  • tests/WebViewTest.cpp:
4:42 PM Changeset in webkit [123679] by msaboff@apple.com
  • 12 edits in trunk/Source

Convert HTML parser to handle 8-bit resources without converting to UChar*
https://bugs.webkit.org/show_bug.cgi?id=90321

Reviewed by Geoffrey Garen.

Source/WebCore:

No new tests, no new functionality therefore covered by existing tests.

Changed the parsing of HTML to handle 8-bit strings without converting the
whole string to 16-bits. Primary change was to use the appropriate
character pointer type (LChar* or UChar*) depending on the source string.
This access is abstracted in SegmentedSubstring by getCurrentChar{8,16} and
incrementAndGetCurrentChar{8,16} methods. In SegmentedString, the advance()
and advanceAndUpdateLineNumber() methods have been refactored into a
state machine managed pair of function pointers. The possible functions
have not only the 8 and 16 bitness factored out, they also have the
"exclude line numbers" logic factored out for advanceAndUpdateLineNumber().
This provides a net speed-up even with the 8/16 bit testing.
Other changes involve using String methods to access and compare with the
source data.

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::append): Changed to use currentChar()
instead of SegmentedString '*' operator.

  • html/parser/HTMLEntityParser.cpp: Changed to use currentChar() instead of

SegmentedString '*' operator.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces): Added 8-bit fast path.

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken): Changed to use currentChar() instead of
SegmentedString '*' operator.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script): Updated to use new String::dataSize() method.

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance): Changed to be a wrapper that invokes current
advance function.
(WebCore::SegmentedString::advance8): Fast path advance function for 8 bit data.
(WebCore::SegmentedString::advance16): Fast path advance function for 16 bit data.
(WebCore::SegmentedString::advanceAndUpdateLineNumber8IncludeLineNumbers): Fast
path advanceAndUpdateLineNumber for 8 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceAndUpdateLineNumber16IncludeLineNumbers): Fast
path advanceAndUpdateLineNumber for 16 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceSlowCase): Slow case advance function for both
8 and 16 bit advance.
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase): Slow case
advanceAndUpdateLineNumber function for both 8 and 16 bit data.
(WebCore::SegmentedString::advanceEmpty): Advance function when input has been exhausted.

  • platform/text/SegmentedString.h:

(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(SegmentedSubstring):
(WebCore::SegmentedSubstring::is8Bit): New getter.
(WebCore::SegmentedSubstring::appendTo):
(WebCore::SegmentedSubstring::getCurrentChar8): New getter for the 8 bit case.
(WebCore::SegmentedSubstring::getCurrentChar16): New getter for the 16 bit case.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar8): New wrapper functions
that pre-increments the 8 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar16): New wrapper functions
that pre-increments the 16 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::currentSubString):
(WebCore::SegmentedSubstring::getCurrentChar):
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(WebCore::SegmentedString::currentChar):
(WebCore::SegmentedString::setSlowCase): Set advance function pointers to slow case
functions.
(WebCore::SegmentedString::decrementAndCheckLength): Decrement substring length and
change to slow case functions when only one character left.
(WebCore::SegmentedString::setAdvanceFunctionPointers): Select appropriate advance
functions based on current substring.
(WebCore::SegmentedString::lookAheadInline): Changed to use String::startsWith().
(WebCore::SegmentedString::lookAheadSlowCase):

  • xml/parser/CharacterReferenceParserInlineMethods.h:

(WebCore::consumeCharacterReference): Changed to use currentChar() instead of
SegmentedString '*' operator.

  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek): Changed to use
currentChar() instead of SegmentedString '*' operator.
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):

Source/WTF:

  • wtf/text/WTFString.h:

(WTF::String::dataSize): New method to return the number of bytes
the string requires. This replaces a harcoded calculation based on
length and sizeof(UChar).

4:41 PM Changeset in webkit [123678] by rniwa@webkit.org
  • 3 edits
    1 move
    2 deletes in trunk/LayoutTests

Improve the output of editing/pasteboard/paste-noscript-xhtml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=92307

Reviewed by Tony Chang.

Use dump-as-markup to improve the readability of output, and removed replaced the call to sayHello in iframe's src
content attribute by a call to alert("hello") so that reference error doesn't show up on the result, and moved
the resource from editing/resources to editing/pasteboard/resources as it's not used elsewhere.

  • editing/pasteboard/paste-noscript-xhtml-expected.txt:
  • editing/pasteboard/paste-noscript-xhtml.xhtml:
  • editing/pasteboard/resources/paste-noscript-content.html: Copied from LayoutTests/editing/resources/htmlcontent.html.
  • editing/resources/htmlcontent.html: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-noscript-xhtml-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-noscript-xhtml-expected.txt: Removed.
4:39 PM Changeset in webkit [123677] by kareng@chromium.org
  • 8 edits in branches/chromium/1180/Source/WebCore

Merge 123495 - Files from drag and file <input> should use getMIMETypeForExtension to determine content type.
https://bugs.webkit.org/show_bug.cgi?id=91702

Reviewed by Jian Li.

Awhile back, we changed File to only use getWellKnownMIMETypeForExtension to prevent web
pages from being able to detect what applications a user has installed indirectly through
the MIME types. However, some sites like YouTube's drag and drop uploader use MIME types
that aren't in WebKit's internal list, so we relax the restriction for Files that originate
from an user action.

  • fileapi/File.cpp:

(WebCore::getContentTypeFromFileName):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):
(WebCore::createBlobDataForFileWithMetadata):
(WebCore::File::createWithRelativePath):
(WebCore::File::File):

  • fileapi/File.h:

(File):
(WebCore::File::create):
(WebCore::File::createWithName):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createFileList):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::addFilename):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::files):

  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::files):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::files):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::files):

TBR=dcheng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10821032

4:32 PM Changeset in webkit [123676] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] fix double->float warnings in CCLayerTreeHostCommonTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=92271

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-25
Reviewed by Adrienne Walker.

Fix compile warnings on Windows.

  • tests/CCLayerTreeHostCommonTest.cpp:
4:29 PM Changeset in webkit [123675] by rniwa@webkit.org
  • 23 edits in trunk/Source/WebCore

Unreviewed, rolling out r123625 and r123672.
http://trac.webkit.org/changeset/123625
http://trac.webkit.org/changeset/123672
https://bugs.webkit.org/show_bug.cgi?id=92315

Broke Windows and gcc builds (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-25

  • platform/AutodrainedPool.h:

(AutodrainedPool):

  • platform/ContentType.h:

(ContentType):

  • platform/ContextMenu.h:

(ContextMenu):

  • platform/ContextMenuItem.h:

(ContextMenuItem):

  • platform/Cursor.h:

(WebCore::SharedCursor::SharedCursor):
(Cursor):

  • platform/KURL.h:

(WebCore::KURL::KURL):
(KURL):

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree):

  • platform/Pasteboard.h:

(Pasteboard):

  • platform/PlatformEvent.h:

(WebCore::PlatformEvent::PlatformEvent):

  • platform/PlatformKeyboardEvent.h:

(PlatformKeyboardEvent):

  • platform/PlatformMouseEvent.h:

(PlatformMouseEvent):

  • platform/PlatformPasteboard.h:

(PlatformPasteboard):

  • platform/PlatformTouchEvent.h:

(PlatformTouchEvent):

  • platform/PlatformWheelEvent.h:

(PlatformWheelEvent):

  • platform/RunLoop.h:

(TimerBase):

  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/SharedBuffer.h:

(SharedBuffer):

  • platform/WheelFlingPlatformGestureCurve.h:

(WheelFlingPlatformGestureCurve):

  • platform/Widget.h:

(Widget):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdateResourceRequest):

4:16 PM Changeset in webkit [123674] by psolanki@apple.com
  • 6 edits in trunk/Source/WebKit/mac

Remove catchesDelegateExceptions from WebViewData and related accessor methods
https://bugs.webkit.org/show_bug.cgi?id=90898

Reviewed by Darin Adler.

Remove catchesDelegateException ivar from WebViewData and all its accesor methods from
WebView. All uses of this flag in WebKit set it to YES and no one calls
_setCatchesDelegateExceptions with NO.

  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::startDrag):

  • WebView/WebDelegateImplementationCaching.mm:

(CallDelegate):
(CallDelegateReturningFloat):
(CallDelegateReturningBoolean):
(CallResourceLoadDelegateReturningBoolean):
(CallFormDelegate):
(CallFormDelegateReturningBoolean):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _policyDelegateForwarder]):
(-[WebView _UIDelegateForwarder]):
(-[WebView _editingDelegateForwarder]):
(-[_WebSafeForwarder initWithTarget:defaultTarget:]):
(-[_WebSafeForwarder forwardInvocation:]):

  • WebView/WebViewData.h:
  • WebView/WebViewPrivate.h:
4:14 PM Changeset in webkit [123673] by jpetsovits@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Rephrase suspend/resume condition to guard against crashes
https://bugs.webkit.org/show_bug.cgi?id=92300
PR 182125

Reviewed by George Staikos.

When the compositor is removed from a WebPage, it might
already have unset its context, and issuing a call to
BackingStore::buffer() would therefore cause a crash.
Just guarding buffer() from this crash isn't fully
correct, because then we wouldn't suspend rendering
for a compositor that had been previously enabled.

Instead, change the condition to suspend/resume in
WebPagePrivate::setCompositor() to focus on the
object that delivers us the buffer. If we can't
listen to the context or buffer being set, better
just take the compositor object itself to determine
whether we have something valid or not... and hope
that they give us a valid context & buffer in all
situations when we can actually be rendering.

Also check compositor->context() in buffer() to be
non-zero before accessing the context's buffer,
because more defensive coding can't hurt here.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::buffer):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setCompositor):

4:04 PM Changeset in webkit [123672] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Windows build fix attempt after r123625.

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdateResourceRequest):

3:59 PM Changeset in webkit [123671] by kseo@webkit.org
  • 3 edits in trunk/Source/WebCore

Read tag names and attributes from the saved tokens in HTMLTreeBuilder::resetInsertionModeAppropriately.
https://bugs.webkit.org/show_bug.cgi?id=92240

Reviewed by Adam Barth.

This is a follow-up patch for r123577. Added ItemType enum to HTMLStackItem to handle
the context element case.

No new tests, covered by existing tests.

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::create):
(WebCore::HTMLStackItem::HTMLStackItem):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):

3:41 PM Changeset in webkit [123670] by rafael.lobo@openbossa.org
  • 51 edits in trunk/LayoutTests

[Qt] platform/qt/tables/mozilla tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91242

Unreviewed gardening.

  • platform/qt-5.0/Skipped:
  • platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug102145-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug102145-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug102145-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug102145-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug10269-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug10296-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug103533-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1067-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1067-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug106795-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug11321-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug133948-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug154780-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug15933-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1818-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1818-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1818-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug219693-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug219693-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug221784-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug221784-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug22513-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug23072-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug23994-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug25074-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug25367-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3037-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3037-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug32447-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3309-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug34538-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug45350-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug53690-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug53690-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug55789-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56201-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug641-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug641-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8361-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug88524-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug9072-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug97383-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug98196-expected.txt:
  • platform/qt/tables/mozilla/marvin/tfoot_char-expected.png:
  • platform/qt/tables/mozilla/marvin/tfoot_char-expected.txt:
3:27 PM Changeset in webkit [123669] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

3:19 PM Changeset in webkit [123668] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium/mac] Remove mac_bundle_resources section from WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=92207

Reviewed by Tony Chang.

It's no longer needed after http://crrev.com/148290 and
http://crrev.com/148187.

  • WebCore.gyp/WebCore.gyp:
3:15 PM Changeset in webkit [123667] by caio.oliveira@openbossa.org
  • 11 edits in trunk/Source

Source/JavaScriptCore: Create a specialized pair for use in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=92137

Reviewed by Ryosuke Niwa.

Update a couple of sites that relied on the fact that "contents" of iterators were
std::pairs.

  • profiler/Profile.cpp:

(JSC): This code kept a vector of the pairs that were the "contents" of the iterators. This
is changed to use a KeyValuePair. We make use HashCount's ValueType (which represents only
the key) to get the proper key parameter for KeyValuePair.

  • tools/ProfileTreeNode.h:

(ProfileTreeNode): Use HashMap::ValueType to declare the type of the contents of the hash
instead of declaring it manually. This will make use of the new KeyValuePair.

Source/WebKit2: Create a specialized struct for use in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=92137

Reviewed by Ryosuke Niwa.

  • Platform/CoreIPC/ArgumentCoders.h: Add encode/decode for KeyValuePair.

Source/WTF: Create a specialized pair for use in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=92137

Reviewed by Ryosuke Niwa.

The type used for internal storage in HashMap is exposed in its interface as iterator
"contents". Currently HashMap uses std::pair<>, which this patch replaces with
KeyValuePair.

Having this specialized structure will allow us to customize the members to be called
key/value, improving readability in code using HashMap iterators. They are still called
first/second to separate this change from the mechanical change of updating callsites.

  • wtf/HashIterators.h:

(HashTableConstKeysIterator):
(HashTableConstValuesIterator):
(HashTableKeysIterator):
(HashTableValuesIterator):
Use KeyValuePair instead of std::pair when defining the iterators.

  • wtf/HashMap.h:

(WTF):
(WTF::KeyValuePairKeyExtractor::extract):
(HashMap):
Remove PairFirstExtractor. Add and use the KeyValuePair corresponding extractor.

(WTF::HashMapValueTraits::isEmptyValue): Use KeyValuePairHashTraits for HashMaps.
(WTF::HashMapTranslator::translate):
(WTF::HashMapTranslatorAdapter::translate):
The traits of the mapped value is now called ValueTraits instead of SecondTraits.

  • wtf/HashTable.h:

(WTF::hashTableSwap): Add specialization for swapping KeyValuePairs.
(WTF): Remove now unneeded specialization for std::pairs.

  • wtf/HashTraits.h:

(KeyValuePair):
(WTF::KeyValuePair::KeyValuePair):
(WTF):
Specialized pair. In the future difference from pair should be the member names.

(KeyValuePairHashTraits):
(WTF::KeyValuePairHashTraits::emptyValue):
(WTF::KeyValuePairHashTraits::constructDeletedValue):
(WTF::KeyValuePairHashTraits::isDeletedValue):
These traits are analogous to PairHashTraits but for KeyValuePair.

  • wtf/RefPtrHashMap.h: Use KeyValuePairHashTraits.
3:07 PM Changeset in webkit [123666] by danakj@chromium.org
  • 12 edits in trunk/Source

[chromium] Move WebFilterOperations from RenderPassDrawQuad to RenderPass
https://bugs.webkit.org/show_bug.cgi?id=91885

Reviewed by Adrienne Walker.

Source/WebCore:

We move the filter operations to CCRenderPass to avoid having
variable-length data in a WebCompositorQuad in order to serialize,
and also to avoid requiring a virtual destructor for the quad
classes.

The drawFrame method now takes a CCRenderPassIdHashMap in order
to connect RenderPass quads to their source RenderPass.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
(WebCore::LayerRendererChromium::drawFrame):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore::CCRenderPass::filters):
(WebCore::CCRenderPass::setFilters):
(CCRenderPass):
(WebCore::CCRenderPass::backgroundFilters):
(WebCore::CCRenderPass::setBackgroundFilters):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):
(FakeCCRendererClient::rootRenderPass):
(FakeCCRendererClient::renderPassesInDrawOrder):
(FakeCCRendererClient::renderPasses):
(FakeCCRendererClient):
(TEST_F):
(TEST):

2:48 PM WebKit Team edited by jochen@chromium.org
moved myself from committers to reviewers (diff)
2:47 PM Changeset in webkit [123665] by reed@google.com
  • 2 edits in trunk/Source/WebCore

fix test in beginLayerClippedToImage to check for immutability if we're going to do a shallow-copy
https://bugs.webkit.org/show_bug.cgi?id=92276

Reviewed by Stephen White.

PlatformContextSkia::beginLayerClippedToImage

This function wants to apply the provided ImageBuffer as a clip. Skia does not support this natively yet,
so the code makes a "copy" of that imageBuffer, to be applied later. The old code, wanting to avoid a
deep copy if possible, checked for the presence of a SkPixelRef. If it found one, it made a shallow copy.
This is flawed, since the contents of a pixelref are not guaranteed to be immutable. The new code checks
against this attribute: if the bitmap is "immutable" then we can make a shallow-copy, else we make a
deep copy.

No new tests. Existing svg layouttests work w/ or w/out this change, but at the next Skia deps roll, we see
failures w/o this change. The change is more "correct", though the problem case does not exhibit itself until
Skia rev. 4722 or later lands.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::beginLayerClippedToImage):

2:41 PM Changeset in webkit [123664] by abarth@webkit.org
  • 2 edits in trunk/Tools

Jochen is our a newest reviewer!

  • Scripts/webkitpy/common/config/committers.py:
2:39 PM Changeset in webkit [123663] by commit-queue@webkit.org
  • 124 edits
    16 adds in trunk/LayoutTests

[Qt] fast/block/margin-collapse tests need update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92274

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-25
Reviewed by Alexis Menard.

  • platform/qt-5.0/Skipped:
  • platform/qt/fast/block/margin-collapse/001-expected.png:
  • platform/qt/fast/block/margin-collapse/001-expected.txt:
  • platform/qt/fast/block/margin-collapse/002-expected.png:
  • platform/qt/fast/block/margin-collapse/002-expected.txt:
  • platform/qt/fast/block/margin-collapse/003-expected.png:
  • platform/qt/fast/block/margin-collapse/003-expected.txt:
  • platform/qt/fast/block/margin-collapse/004-expected.png:
  • platform/qt/fast/block/margin-collapse/004-expected.txt:
  • platform/qt/fast/block/margin-collapse/005-expected.png:
  • platform/qt/fast/block/margin-collapse/005-expected.txt:
  • platform/qt/fast/block/margin-collapse/006-expected.png:
  • platform/qt/fast/block/margin-collapse/006-expected.txt:
  • platform/qt/fast/block/margin-collapse/010-expected.png:
  • platform/qt/fast/block/margin-collapse/010-expected.txt:
  • platform/qt/fast/block/margin-collapse/011-expected.png:
  • platform/qt/fast/block/margin-collapse/011-expected.txt:
  • platform/qt/fast/block/margin-collapse/012-expected.png:
  • platform/qt/fast/block/margin-collapse/012-expected.txt:
  • platform/qt/fast/block/margin-collapse/015-expected.png:
  • platform/qt/fast/block/margin-collapse/015-expected.txt:
  • platform/qt/fast/block/margin-collapse/016-expected.png:
  • platform/qt/fast/block/margin-collapse/016-expected.txt:
  • platform/qt/fast/block/margin-collapse/017-expected.png:
  • platform/qt/fast/block/margin-collapse/017-expected.txt:
  • platform/qt/fast/block/margin-collapse/018-expected.png:
  • platform/qt/fast/block/margin-collapse/018-expected.txt:
  • platform/qt/fast/block/margin-collapse/019-expected.png:
  • platform/qt/fast/block/margin-collapse/019-expected.txt:
  • platform/qt/fast/block/margin-collapse/020-expected.png:
  • platform/qt/fast/block/margin-collapse/020-expected.txt:
  • platform/qt/fast/block/margin-collapse/021-expected.png:
  • platform/qt/fast/block/margin-collapse/021-expected.txt:
  • platform/qt/fast/block/margin-collapse/022-expected.png:
  • platform/qt/fast/block/margin-collapse/022-expected.txt:
  • platform/qt/fast/block/margin-collapse/025-expected.png:
  • platform/qt/fast/block/margin-collapse/025-expected.txt:
  • platform/qt/fast/block/margin-collapse/026-expected.png:
  • platform/qt/fast/block/margin-collapse/026-expected.txt:
  • platform/qt/fast/block/margin-collapse/027-expected.png:
  • platform/qt/fast/block/margin-collapse/027-expected.txt:
  • platform/qt/fast/block/margin-collapse/028-expected.png:
  • platform/qt/fast/block/margin-collapse/028-expected.txt:
  • platform/qt/fast/block/margin-collapse/029-expected.png:
  • platform/qt/fast/block/margin-collapse/029-expected.txt:
  • platform/qt/fast/block/margin-collapse/030-expected.png:
  • platform/qt/fast/block/margin-collapse/030-expected.txt:
  • platform/qt/fast/block/margin-collapse/031-expected.png:
  • platform/qt/fast/block/margin-collapse/031-expected.txt:
  • platform/qt/fast/block/margin-collapse/032-expected.png:
  • platform/qt/fast/block/margin-collapse/032-expected.txt:
  • platform/qt/fast/block/margin-collapse/033-expected.png:
  • platform/qt/fast/block/margin-collapse/033-expected.txt:
  • platform/qt/fast/block/margin-collapse/034-expected.png:
  • platform/qt/fast/block/margin-collapse/034-expected.txt:
  • platform/qt/fast/block/margin-collapse/035-expected.png:
  • platform/qt/fast/block/margin-collapse/035-expected.txt:
  • platform/qt/fast/block/margin-collapse/037-expected.png:
  • platform/qt/fast/block/margin-collapse/037-expected.txt:
  • platform/qt/fast/block/margin-collapse/038-expected.png:
  • platform/qt/fast/block/margin-collapse/038-expected.txt:
  • platform/qt/fast/block/margin-collapse/039-expected.png:
  • platform/qt/fast/block/margin-collapse/039-expected.txt:
  • platform/qt/fast/block/margin-collapse/040-expected.png:
  • platform/qt/fast/block/margin-collapse/040-expected.txt:
  • platform/qt/fast/block/margin-collapse/041-expected.png:
  • platform/qt/fast/block/margin-collapse/041-expected.txt:
  • platform/qt/fast/block/margin-collapse/042-expected.png:
  • platform/qt/fast/block/margin-collapse/042-expected.txt:
  • platform/qt/fast/block/margin-collapse/043-expected.png:
  • platform/qt/fast/block/margin-collapse/043-expected.txt:
  • platform/qt/fast/block/margin-collapse/044-expected.png:
  • platform/qt/fast/block/margin-collapse/044-expected.txt:
  • platform/qt/fast/block/margin-collapse/045-expected.png:
  • platform/qt/fast/block/margin-collapse/045-expected.txt:
  • platform/qt/fast/block/margin-collapse/055-expected.png:
  • platform/qt/fast/block/margin-collapse/055-expected.txt:
  • platform/qt/fast/block/margin-collapse/056-expected.png:
  • platform/qt/fast/block/margin-collapse/056-expected.txt:
  • platform/qt/fast/block/margin-collapse/057-expected.png:
  • platform/qt/fast/block/margin-collapse/057-expected.txt:
  • platform/qt/fast/block/margin-collapse/058-expected.png:
  • platform/qt/fast/block/margin-collapse/058-expected.txt:
  • platform/qt/fast/block/margin-collapse/059-expected.png:
  • platform/qt/fast/block/margin-collapse/059-expected.txt:
  • platform/qt/fast/block/margin-collapse/062-expected.png:
  • platform/qt/fast/block/margin-collapse/062-expected.txt:
  • platform/qt/fast/block/margin-collapse/063-expected.png:
  • platform/qt/fast/block/margin-collapse/063-expected.txt:
  • platform/qt/fast/block/margin-collapse/100-expected.png:
  • platform/qt/fast/block/margin-collapse/100-expected.txt:
  • platform/qt/fast/block/margin-collapse/101-expected.png:
  • platform/qt/fast/block/margin-collapse/101-expected.txt:
  • platform/qt/fast/block/margin-collapse/102-expected.png:
  • platform/qt/fast/block/margin-collapse/102-expected.txt:
  • platform/qt/fast/block/margin-collapse/103-expected.png:
  • platform/qt/fast/block/margin-collapse/103-expected.txt:
  • platform/qt/fast/block/margin-collapse/104-expected.png:
  • platform/qt/fast/block/margin-collapse/104-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/002-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/003-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/021-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/022-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
  • platform/qt/fast/block/margin-collapse/negative-margins-expected.png:
  • platform/qt/fast/block/margin-collapse/negative-margins-expected.txt:
2:33 PM Changeset in webkit [123662] by commit-queue@webkit.org
  • 5 edits in trunk

It is invalid when both numberOfInputChannels and numberOfOutputChannels to be zero in JavaScriptAudioNode.
https://bugs.webkit.org/show_bug.cgi?id=91364

Patch by Li Yin <li.yin@intel.com> on 2012-07-25
Reviewed by Kenneth Russell.

Source/WebCore:

Spec: http://www.w3.org/TR/webaudio/#JavaScriptAudioNode-section
It is invalid for both numberOfInputChannels and numberOfOutputChannels to be zero.

Test: webaudio/javascriptaudionode.html

  • Modules/webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::create):

LayoutTests:

Add tests for (numberOfInputChannels, numberOfOutputChannels) to be (0, 0),(0, 1),(0, 2),(1, 0) and (2, 0).

  • webaudio/javascriptaudionode-expected.txt:
  • webaudio/javascriptaudionode.html:
2:28 PM Changeset in webkit [123661] by jochen@chromium.org
  • 9 edits in trunk/Tools

[chromium] don't use webkit_support methods directly from test runners but through the test delegate
https://bugs.webkit.org/show_bug.cgi?id=92256

Reviewed by Adam Barth.

This will allow for the content_shell to provide its own implementation
for setting the Gamepad data instead.

  • DumpRenderTree/chromium/TestRunner/GamepadController.cpp:

(GamepadController::setDelegate):
(GamepadController::reset):
(GamepadController::connect):
(GamepadController::disconnect):
(GamepadController::setId):
(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):

  • DumpRenderTree/chromium/TestRunner/GamepadController.h:

(GamepadController):

  • DumpRenderTree/chromium/TestRunner/TestDelegate.h:

(WebKit):
(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:

(TestInterfaces::Internal):
(TestInterfaces::Internal::~Internal):
(TestInterfaces::Internal::setDelegate):
(TestInterfaces::setDelegate):

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::createMainWindow):
(TestShell::~TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::setGamepadData):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

2:25 PM Changeset in webkit [123660] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update about:config lists
https://bugs.webkit.org/show_bug.cgi?id=92118

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

Remove features from list that have either been removed from WebKit
or that have been moved from one list to another.

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/AboutDataHaveFeatures.in:
  • WebCoreSupport/AboutDataUseFeatures.in:
2:19 PM Changeset in webkit [123659] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change.

  • platform/chromium/TestExpectations:
2:13 PM Changeset in webkit [123658] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when calling PluginView::pluginFocusOrWindowFocusChanged when the web page is null
https://bugs.webkit.org/show_bug.cgi?id=92289
<rdar://problem/11785352>

Reviewed by Andreas Kling.

Plug-in views that outlive their containing web page for various reasons (such as being protected from
destruction) need to null check the web page.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginFocusOrWindowFocusChanged):
(WebKit::PluginView::setComplexTextInputState):

2:08 PM Changeset in webkit [123657] by commit-queue@webkit.org
  • 17 edits
    3 deletes in trunk/LayoutTests

[Qt] fast/borders rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92146

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-25
Reviewed by Csaba Osztrogonác.

Updated patch started by Alexis. This one removes old expected results
found inside qt-5.0 directory and updates Skipped files as well.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/fast/borders/bidi-002-expected.txt: Removed.
  • platform/qt-5.0/fast/borders/bidi-009a-expected.txt: Removed.
  • platform/qt-5.0/fast/borders/bidi-012-expected.txt: Removed.
  • platform/qt/fast/borders/border-image-slice-constrained-expected.txt:
  • platform/qt/fast/borders/borderRadiusArcs01-expected.txt:
  • platform/qt/fast/borders/borderRadiusDouble01-expected.txt:
  • platform/qt/fast/borders/borderRadiusDouble02-expected.txt:
  • platform/qt/fast/borders/borderRadiusDouble03-expected.txt:
  • platform/qt/fast/borders/borderRadiusGroove01-expected.txt:
  • platform/qt/fast/borders/borderRadiusGroove02-expected.txt:
  • platform/qt/fast/borders/borderRadiusInset01-expected.txt:
  • platform/qt/fast/borders/borderRadiusOutset01-expected.txt:
  • platform/qt/fast/borders/borderRadiusRidge01-expected.txt:
  • platform/qt/fast/borders/borderRadiusSolid01-expected.txt:
  • platform/qt/fast/borders/borderRadiusSolid02-expected.txt:
  • platform/qt/fast/borders/borderRadiusSolid03-expected.txt:
  • platform/qt/fast/borders/borderRadiusSolid04-expected.txt:
  • platform/qt/fast/borders/table-borders-expected.txt:
1:59 PM Changeset in webkit [123656] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change.

  • platform/chromium/TestExpectations:
1:52 PM Changeset in webkit [123655] by rniwa@webkit.org
  • 1 edit
    60 adds in trunk/PerformanceTests

Import more replay performance tests from Mozilla's Tp5 test suite
https://bugs.webkit.org/show_bug.cgi?id=92229

Reviewed by Andreas Kling.

Add more replay tests based on Mozilla's Tp5 test suite [1]. Unfortunately,
we cannot import all URLs because some of them are not archived on archive.org
and others do not replay well on web-page-replay. Nonethless, we're still adding
60+ URLs in this patch.

[1] http://people.mozilla.org/~jmaher/tp5.manifest

  • Replay/Chinese: Added.
  • Replay/Chinese/chinaz.com.replay: Added.
  • Replay/Chinese/www.163.com.replay: Added.
  • Replay/Chinese/www.alipay.com.replay: Added.
  • Replay/Chinese/www.baidu.com.replay: Added.
  • Replay/Chinese/www.csdn.net.replay: Added.
  • Replay/Chinese/www.douban.com.replay: Added.
  • Replay/Chinese/www.hao123.com.replay: Added.
  • Replay/Chinese/www.xinhuanet.com.replay: Added.
  • Replay/Chinese/www.xunlei.com.replay: Added.
  • Replay/Chinese/www.youku.com.replay: Added.
  • Replay/English: Added.
  • Replay/English/beatonna.livejournal.com.replay: Added.
  • Replay/English/cakewrecks.blogspot.com.replay: Added.
  • Replay/English/chemistry.about.com.replay: Added.
  • Replay/English/digg.com.replay: Added.
  • Replay/English/en.wikipedia.org-rorschach_test.replay: Added.
  • Replay/English/icanhascheezburger.com.replay: Added.
  • Replay/English/imgur.com-gallery.replay: Added.
  • Replay/English/online.wsj.com.replay: Added.
  • Replay/English/stockoverflow.com-best-comment.replay: Added.
  • Replay/English/www.alibaba.com.replay: Added.
  • Replay/English/www.amazon.com-kindle.replay: Added.
  • Replay/English/www.apple.com.replay: Added.
  • Replay/English/www.cnet.com.replay: Added.
  • Replay/English/www.dailymotion.com.replay: Added.
  • Replay/English/www.ehow.com-prevent-fire.replay: Added.
  • Replay/English/www.filestube.com-amy-adams.replay: Added.
  • Replay/English/www.foxnews.replay: Added.
  • Replay/English/www.huffingtonpost.com.replay: Added.
  • Replay/English/www.imdb.com-twilight.replay: Added.
  • Replay/English/www.mozilla.com-all-order.replay: Added.
  • Replay/English/www.php.net.replay: Added.
  • Replay/English/www.reddit.com.replay: Added.
  • Replay/English/www.telegraph.co.uk.replay: Added.
  • Replay/English/www.w3.org-htmlcss.replay: Added.
  • Replay/English/www.w3schools.com-html.replay: Added.
  • Replay/English/www.youtube.com-music.replay: Added.
  • Replay/French: Added.
  • Replay/French/www.orange.fr.replay: Added.
  • Replay/German: Added.
  • Replay/Italian: Added.
  • Replay/Italian/www.repubblica.it.replay: Added.
  • Replay/Japanese/entameblog.seesaa.net.replay: Added.
  • Replay/Japanese/www.hatena.ne.jp.replay: Added.
  • Replay/Japanese/www.nicovideo.jp.replay: Added.
  • Replay/Korean: Added.
  • Replay/Korean/www.naver.com.replay: Added.
  • Replay/Persian: Added.
  • Replay/Persian/blogfa.com.replay: Added.
  • Replay/Polish: Added.
  • Replay/Polish/www.wp.pl.replay: Added.
  • Replay/Portuguese: Added.
  • Replay/Portuguese/www.uol.com.br.replay: Added.
  • Replay/Russian: Added.
  • Replay/Russian/vkontakte.ru-help.replay: Added.
  • Replay/Russian/www.rambler.ru.replay: Added.
  • Replay/Russian/www.ucoz.ru.replay: Added.
  • Replay/Russian/www.yandex.ru.replay: Added.
  • Replay/Spanish: Added.
  • Replay/Spanish/www.taringa.net.replay: Added.
1:47 PM Changeset in webkit [123654] by shawnsingh@chromium.org
  • 10 edits in trunk/Source

[chromium] Refactor CCLayerTreeHostCommon: move root layer special case initialization into internal code.
https://bugs.webkit.org/show_bug.cgi?id=88953

Reviewed by Adrienne Walker.

Source/WebCore:

This is part 1 of trying to reduce the root layer special
case. This tries to reduce the special-ness of the root layer from
the perspective of outside code.

After this patch, code that uses calcDrawTransforms() no longer
needs to initialize the root layer's surface, and no longer needs
to manually append the root layer to the renderSurfaceLayerList.

Unit tests were also updated (much cleaner!) to account for this change.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore):
(WebCore::setupRootLayerAndSurfaceForRecursion):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):

Source/WebKit/chromium:

Unit tests updated to account for the new less-special root layer setup.

  • most test cases just needed to remove root->renderSurface()->setContentBounds(), createRenderSurface(), and renderSurfaceLayerList.append().
  • some test cases originally relied on setting some awkward unconventional bounds of the rootLayer that were different than the rootLayer's renderSurface. these tests are updated.
  • a few minor cleanups otherwise.
  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::executeCalculateDrawTransformsAndVisibility):

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):

1:44 PM Changeset in webkit [123653] by commit-queue@webkit.org
  • 10 edits in trunk/Source

FileSystem should provide a way to delete filesystem.
https://bugs.webkit.org/show_bug.cgi?id=91861

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-25
Reviewed by Adam Barth.

Source/WebCore:

We will add a test when we wire-up the feature to Inspector.

  • Modules/filesystem/LocalFileSystem.cpp: Add deleteFileSystem

(WebCore::deleteFileSystem):
(WebCore):
(WebCore::LocalFileSystem::deleteFileSystem):

  • Modules/filesystem/LocalFileSystem.h:

(LocalFileSystem):

  • platform/AsyncFileSystem.cpp: Add deleteFileSystem

(WebCore):
(WebCore::AsyncFileSystem::deleteFileSystem):

  • platform/AsyncFileSystem.h:

(AsyncFileSystem):

  • platform/blackberry/AsyncFileSystemBlackBerry.cpp: Add deleteFileSystem

(WebCore::AsyncFileSystem::deleteFileSystem):
(WebCore):

  • platform/gtk/AsyncFileSystemGtk.cpp: Add deleteFileSystem

(WebCore::AsyncFileSystem::deleteFileSystem):
(WebCore):

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::deleteFileSystem):

  • src/LocalFileSystemChromium.cpp: Add deleteFileSystem

(WebCore::deleteFileSystemNotAllowed):
(WebCore):
(WebCore::LocalFileSystem::deleteFileSystem):

1:34 PM Changeset in webkit [123652] by commit-queue@webkit.org
  • 19 edits
    4 copies in trunk

[WK2][WTR] LayoutTestController.sendWebIntentResponse() needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=92227

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-25
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add new InjectedBundleIntentRequest class to wrap WebCore's
IntentRequest and use it in InjectedBundle's
didReceiveIntentForFrame callback. The WebKitTestRunner needs
to be able to reply to a Web intent request in order to
implement LayoutTestController.sendWebIntentResponse(). As
a consequence, passing a WebIntentData type in not enough.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • Shared/IntentData.cpp:

(WebKit::IntentData::IntentData):
(WebKit):

  • Shared/IntentData.h:

(WebCore):
(WebKit::IntentData::IntentData):
(IntentData):

  • Target.pri:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit):

  • WebProcess/InjectedBundle/API/c/WKBundleIntentRequest.cpp: Copied from Source/WebKit2/Shared/IntentData.cpp.

(WKBundleIntentRequestGetTypeID):
(WKBundleIntentRequestCopyIntent):
(WKBundleIntentRequestPostResult):
(WKBundleIntentRequestPostFailure):

  • WebProcess/InjectedBundle/API/c/WKBundleIntentRequest.h: Copied from Source/WebKit2/Shared/IntentData.h.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundleIntentRequest.cpp: Copied from Source/WebKit2/Shared/IntentData.cpp.

(WebKit):
(WebKit::InjectedBundleIntentRequest::create):
(WebKit::InjectedBundleIntentRequest::InjectedBundleIntentRequest):
(WebKit::InjectedBundleIntentRequest::postResult):
(WebKit::InjectedBundleIntentRequest::postFailure):
(WebKit::InjectedBundleIntentRequest::intent):

  • WebProcess/InjectedBundle/InjectedBundleIntentRequest.h: Copied from Source/WebKit2/Shared/IntentData.h.

(WebCore):
(WebKit):
(InjectedBundleIntentRequest):
(WebKit::InjectedBundleIntentRequest::type):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didReceiveIntentForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

(WebKit):
(InjectedBundlePageLoaderClient):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchIntent):

Tools:

Implement LayoutTestController.sendWebIntentResponse() so
that a test case can reply to a Web intent request and
test this functionality.

In order to support this functionality, we need to keep
a pointer to the current intent request in
InjectedBundlePage::didReceiveIntentForFrame() so that
we can reuse it later in
LayoutTestController::sendWebIntentResponse().

The following tests need this functionality:

  • webintents/web-intents-failure.html
  • webintents/web-intents-reply.html
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didReceiveIntentForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):
(WTR::InjectedBundlePage::currentIntentRequest):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::sendWebIntentResponse):
(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

1:19 PM Changeset in webkit [123651] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Add more jsdocs to InjectedScriptSource.js
https://bugs.webkit.org/show_bug.cgi?id=92255

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-07-25
Reviewed by Pavel Feldman.

  • inspector/InjectedScriptSource.js:
1:15 PM Changeset in webkit [123650] by msaboff@apple.com
  • 2 edits in trunk/LayoutTests

r123492 Changed output of msub-anonymous-child-render-crash.html LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=92284

Rubber-stamped by Beth Dakin.

Rebaselined test output.

  • mathml/msub-anonymous-child-render-crash-expected.txt:

r123492 changed the way inline-tables are rendered.

1:06 PM Changeset in webkit [123649] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when a web page is closed with outstanding scrolling thread barriers
https://bugs.webkit.org/show_bug.cgi?id=92280
<rdar://problem/11630200>

Reviewed by Andreas Kling.

There was a check in forceRepaintAsync to handle the drawing area going away before the block had
been invoked, but this check needs to be done earlier (as the FIXME suggested).
Move this check to dispatchAfterEnsuringUpdatedScrollPosition instead.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::forceRepaintAsync):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):

1:06 PM Changeset in webkit [123648] by Lucas Forschler
  • 1 copy in branches/safari-536.26-branch

New branch.

1:05 PM Changeset in webkit [123647] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2][WTR] Alt, Shift and Ctrl keys are not handled by EventSenderProxy.
https://bugs.webkit.org/show_bug.cgi?id=92241

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-25
Reviewed by Kenneth Rohde Christiansen.

Alt, Shift and Ctrl keys were not handled by EventSenderProxy.
It caused failure of fast/events/keydown-leftright-keys.html test.

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added handling of Alt, Shift and Ctrl keys.

(WTR::keyName):

12:52 PM Changeset in webkit [123646] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change to mark tests as slow.

  • platform/chromium/TestExpectations:
12:50 PM Changeset in webkit [123645] by alokp@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] WebViewBenchmarkSupport::paint API does not work with recording canvas
https://bugs.webkit.org/show_bug.cgi?id=92008

Reviewed by Darin Fisher.

Moved the ownership of canvas to WebViewBenchmarkSupport::PaintClient.

  • public/WebViewBenchmarkSupport.h:

(PaintClient):
(WebKit::WebViewBenchmarkSupport::PaintClient::willPaint):
(WebKit::WebViewBenchmarkSupport::PaintClient::didPaint):

  • src/WebViewBenchmarkSupportImpl.cpp:

(WebKit::WebViewBenchmarkSupportImpl::paintLayer):
(WebKit::WebViewBenchmarkSupportImpl::softwarePaint):

12:46 PM Changeset in webkit [123644] by danakj@chromium.org
  • 19 edits
    2 moves
    2 adds in trunk/Source

[chromium] Turn the debug HUD into a layer so that it can be drawn as a WebCompositorQuad
https://bugs.webkit.org/show_bug.cgi?id=92182

Reviewed by Adrienne Walker.

Source/WebCore:

By changing the HUD into a quad, we are able to create a HUD and pass
it to the host compositor, allowing the HUD to be used for renderers
under Ubercompositor.

This also removes the special drawing code for the HUD from
LayerRendererChromium, allowing us to move finishDrawingFrame
into LayerRendererChromium as a private method and remove it
from the CCRenderer interface.

Finally, we can remove the CCFontAtlas transport code from CCProxy
and its implementations as the atlas can be synced to impl thread
through the usual layer commit mechanism.

The debug HUD is not covered by tests.

  • WebCore.gypi:
  • platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp: Added.

(WebCore):
(WebCore::HeadsUpDisplayLayerChromium::create):
(WebCore::HeadsUpDisplayLayerChromium::HeadsUpDisplayLayerChromium):
(WebCore::HeadsUpDisplayLayerChromium::~HeadsUpDisplayLayerChromium):
(WebCore::HeadsUpDisplayLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/HeadsUpDisplayLayerChromium.h: Added.

(WebCore):
(HeadsUpDisplayLayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawFrame):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCDebugRectHistory.cpp:

(WebCore::CCDebugRectHistory::savePropertyChangedRects):

  • platform/graphics/chromium/cc/CCDebugRectHistory.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp.

(WebCore):
(WebCore::CCHeadsUpDisplayLayerImpl::CCHeadsUpDisplayLayerImpl):
(WebCore::CCHeadsUpDisplayLayerImpl::~CCHeadsUpDisplayLayerImpl):
(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):
(WebCore::CCHeadsUpDisplayLayerImpl::appendQuads):
(WebCore::CCHeadsUpDisplayLayerImpl::didDraw):
(WebCore::CCHeadsUpDisplayLayerImpl::didLoseContext):
(WebCore::CCHeadsUpDisplayLayerImpl::drawHudContents):
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounter):
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounterText):
(WebCore::CCHeadsUpDisplayLayerImpl::drawDebugRects):

  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.h.

(WebCore):
(CCHeadsUpDisplayLayerImpl):
(WebCore::CCHeadsUpDisplayLayerImpl::create):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::layerIsAlwaysDamaged):
This flag is used to mark the HUD as always damaged, so that it is
continually drawn on the impl thread. It is also used as a hint by
the CCDebugRectHistory class to not include the layer in the display
of damage, since always damaged is not interesting damage.
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::willCommit):
(WebCore::CCLayerTreeHost::didCommit):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeSettings):
(WebCore::CCLayerTreeSettings::showDebugInfo):
(WebCore::CCLayerTreeSettings::showDebugRects):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • tests/LayerRendererChromiumTest.cpp:

(TEST):

12:10 PM Changeset in webkit [123643] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL][WK2] Fix timeout issues when debugging WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=92245

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-25
Reviewed by Dirk Pranke.

Fix timeout issues when debugging the WebProcess
under valgrind or gdb.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.default_timeout_ms):

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::platformInitialize):

11:52 AM Changeset in webkit [123642] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] NRWT driver should not restart between reftests
https://bugs.webkit.org/show_bug.cgi?id=92267

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.start): Resets self._pixel_tests when the pixel_tests parameter changes.

11:49 AM Changeset in webkit [123641] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: follow up to r123612, fixing CSS value suggest.

Not reviewed, minor JS fix.

  • inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype):

11:48 AM Changeset in webkit [123640] by bweinstein@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add Mac results for media/controls-styling-strict.html.

Rubber-stamped by Michael Saboff.

  • platform/mac/media/controls-styling-strict-expected.txt: Added.
11:19 AM Changeset in webkit [123639] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r123624.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::clearGeolocationOverride):
Changed ASSERT_UNUSED() to UNUSED_PARAM().

11:16 AM Changeset in webkit [123638] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web inspector auto-completes "optimizequality" but then complains
https://bugs.webkit.org/show_bug.cgi?id=92262

Reviewed by Timothy Hatcher.

Fixed optimizeSpeed, optimizeLegibility, geometricPrecision.

  • inspector/front-end/CSSKeywordCompletions.js:
11:15 AM Changeset in webkit [123637] by Beth Dakin
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=89114
REGRESSION (r112919): Setting scrollTop after setting display from none to block
fails
-and corresponding-
<rdar://problem/11656050>

Reviewed by Simon Fraser.

Source/WebCore:

ScrollAnimatorMac::immediateScrollTo() and ScrollAnimatorMac::immediateScrollBy()
both have an optimization in place so that they do not call
notifyPositionChanged() if the new scroll offset matches the ScrollAnimator's
cached m_currentPosX and m_currentPosY. So revision 112919 caused troubled with
this optimization because it allowed RenderLayers to restore a scrollOffset from
the Element if there is one cached there. This caused the RenderLayer to have a
scrollOffset that is improperly out-of-synch with the ScrollAnimator's
currentPosition (which will just be 0,0 since it is being re-created like the
RenderLayer). This fix makes sure they are in synch by calling
setCurrentPosition() on the ScrollAnimator when the cached position is non-zero.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

LayoutTests:

  • fast/overflow/setting-scrollTop-after-hide-show-expected.txt: Added.
  • fast/overflow/setting-scrollTop-after-hide-show.html: Added.
11:14 AM Changeset in webkit [123636] by kling@webkit.org
  • 27 edits in trunk

Make ElementAttributeData a variable-sized object to reduce memory use.
<http://webkit.org/b/88240>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Take advantage of the fact that we know at ElementAttributeData construction time how many attributes
it needs to accomodate and allocate exactly as much space as needed instead of using a Vector.
For elements that never have their attribute list mutated (the vast majority), this saves a lot of
memory and removes the indirection to Vector<Attribute>'s heap-allocated storage.

Introduced a mutability flag to ElementAttributeData and sprinkled assertions all over to make sure
that nothing tries to mutate an element with a raw attribute array.

When an Element's attribute(s) are mutated, we reconstruct the ElementAttributeData, this time using
a Vector as backing instead. This is triggered when calling Element::mutableAttributeData().

This reduces memory consumption by 3.2MB when viewing the full HTML5 spec at <http://whatwg.org/c/>.
That is a ~35% reduction in DOM attribute memory use.

Furthermore, that page ends up promoting 27% of the elements to mutable attribute storage due to dynamic
adding of "class" attributes. For more static pages, savings are even greater.

Also did away with ElementAttributeData::removeAttribute(name) and do separate index lookup where
needed. Not a big deal but avoids double lookup of attributes when removing them.

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::cloneAttributesFromElement):

Sprinkle const on ElementAttributeData* pointers.
Switch to using mutableAttributeData() in code paths that modify attributes.

(WebCore::Element::normalizeAttributes):

Cleaner iteration over attributes, I removed ElementAttributeData::attributeVector() since that
was just incurring a bunch of extra Vector copying. Since ElementAttributeData already exposes
length() and attributeItem(index), use those to iterate directly over the attributes.

(WebCore::Element::createMutableAttributeData):

Added, converts existing ElementAttributeData to a mutable object. Otherwise creates a new
ElementAttributeData (mutable and empty.)

  • dom/Element.h:

(WebCore::Element::attributeData):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):

Made all of these return "const ElementAttributeData*" to ensure at compile-time that nothing
attempts to modify an ElementAttributeData that may be immutable.

ensureUpdatedAttributeData() is still const, despite possibly calling mutableAttributeData().
The goal of having methods be const is to prevent conversion from one ElementAttributeData
object to another, so that pointers remain intact and no unnecessary work gets done.

(WebCore::Element::mutableAttributeData):

Added, returns a guaranteed mutable ElementAttributeData* pointer.

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::createImmutable):

Creates a new ElementAttributeData tailored to fit the provided Vector<Attribute>.

(WebCore::ElementAttributeData::ElementAttributeData):

Moved constructors out-of-line, getting too complex for header files.

ElementAttributeData(const Vector<Attribute>&) creates an immutable ElementAttributeData
containing the provided attributes in an array tacked onto the end of the object.

(WebCore::ElementAttributeData::~ElementAttributeData):

Free the attribute vector if mutable.
For immutable objects, manually invoke destructor on each Attribute object,
since these won't be destroyed automatically by ~ElementAttributeData.

(WebCore::ElementAttributeData::attrIfExists):

(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):

Make these const, as they should always have been- they don't affect the ElementAttributeData,
only the global DOM Attr <-> ElementAttributeData mappings.

(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):

Sprinkle ASSERT(isMutable()). This doesn't mean that all Elements with inline styles automatically
have mutable attribute data. There's still inlineStyle() for that, which may return null.
These are only for use where you need a valid StylePropertySet*, even if there is no inline style
attribute, e.g in editing code that wants to add style.

(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):
(WebCore::ElementAttributeData::destroyInlineStyle):

Make these const. While destroyInlineStyle() doesn't sound very const-y, immutable objects that
contain a style attribute will have a valid inlineStyle() with that style data. This is just
an interface for ~StyledElement to destroy the style object.
It'd be nice to do that in ~ElementAttributeData(), but we need a StyledElement* pointer to
clean up properly and we don't store one in this class.

(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute):

Sprinkle ASSERT(isMutable()).
Always go straight for m_mutableAttributeVector since we know that's the storage being used.

(WebCore::ElementAttributeData::isEquivalent):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):

Use length() and attributeItem(index) to iterate over the attributes.

(WebCore::ElementAttributeData::cloneDataFrom):

Sprinkle ASSERT(isMutable()). Added a FIXME that cloning elements could create immutable
attribute data. I'm not sure this optimization is worthwhile, as cloning elements is already
a semi-rare occurrence.

Updated code to handle both immutable and mutable source objects. This could

(WebCore::ElementAttributeData::getAttributeNode):

Const correctness.

  • dom/ElementAttributeData.h:

(ElementAttributeData):

Turn attribute storage into what's effectively union { OwnPtr<Vector<Attribute>>; Attribute[]; }
The new m_isMutable bit determines which union member should be used for access.

(WebCore::ElementAttributeData::create):
(WebCore::ElementAttributeData::createImmutable):

Added createImmutable(const Vector<Attribute>&) as a complement to create().

(WebCore::ElementAttributeData::setClass):
(WebCore::ElementAttributeData::setIdForStyleResolution):
(WebCore::ElementAttributeData::inlineStyle):
(WebCore::ElementAttributeData::setAttributeStyle):

Make these const, and their data member counterparts 'mutable'.
An immutable ElementAttributeData object still has m_classNames, m_idForStyleResolution,
m_inlineStyleDecl and m_attributeStyle.

(WebCore::ElementAttributeData::reportMemoryUsage):

Updated for isMutable().

(WebCore::ElementAttributeData::makeMutable):

Returns a mutable clone of itself.

(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::attributeItem):

Check isMutable() to know how to access attribute storage.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::style):
(WebCore::StyledElement::setInlineStyleProperty):

Simplify by using StyledElement::ensureInlineStyle().

(WebCore::StyledElement::classAttributeChanged):

Use mutableAttributeData() if the attribute is being removed completely.
In other cases, tiptoe around without causing the attribute data to go mutable.

(WebCore::StyledElement::removeInlineStyleProperty):

Use mutableAttributeData() if/when actually removing something.

(WebCore::StyledElement::addSubresourceAttributeURLs):

Const correctness.

  • dom/StyledElement.h:

(WebCore::StyledElement::ensureInlineStyle):

This now implies conversion to mutable attribute data. Used by codepaths that add/remove
properties, so conversion is inevitable.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • svg/properties/SVGAnimatedPropertyMacros.h:

(WebCore::SVGSynchronizableAnimatedProperty::synchronize):

Use mutableAttributeData() as appropriate.

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

Const correctness.

LayoutTests:

Extended this test to cover the case where setAttributeNode() returns a lazily serialized value.

  • fast/dom/attr-style-too-lazy-expected.txt:
  • fast/dom/attr-style-too-lazy.html:
11:12 AM Changeset in webkit [123635] by atwilson@chromium.org
  • 12 edits in trunk/Source

Unreviewed, rolling out r123560.
http://trac.webkit.org/changeset/123560
https://bugs.webkit.org/show_bug.cgi?id=90321

Breaks chromium valgrind tests.

Source/WebCore:

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::append):

  • html/parser/HTMLEntityParser.cpp:

(WebCore::HTMLEntityParser::consumeNamedEntity):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces):

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceSlowCase):
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase):

  • platform/text/SegmentedString.h:

(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(WebCore::SegmentedSubstring::appendTo):
(SegmentedSubstring):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(SegmentedString):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(WebCore::SegmentedString::operator*):
(WebCore::SegmentedString::operator->):
(WebCore::SegmentedString::current):
(WebCore::SegmentedString::equalsLiterally):
(WebCore::SegmentedString::equalsIgnoringCase):
(WebCore::SegmentedString::lookAheadInline):
(WebCore::SegmentedString::lookAheadSlowCase):

  • xml/parser/CharacterReferenceParserInlineMethods.h:

(WebCore::consumeCharacterReference):

  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):

Source/WTF:

  • wtf/text/WTFString.h:
10:50 AM Changeset in webkit [123634] by kpiascik@rim.com
  • 14 edits
    6 adds in trunk

Web Inspector: Geolocation override
https://bugs.webkit.org/show_bug.cgi?id=89365

Reviewed by Pavel Feldman.

Source/WebCore:

Re-added the m_page member variable for GeolocationController since
it's now being used by InspectorInstrumentaiton.

Added a way to override the GeolocationPosition and GeolocationError
using Web Inspector. Curretnly only PositionError can be set.

This will be hidden behind the experiments flag for now.

Tests: inspector/geolocation-error.html

inspector/geolocation-success.html
inspector/geolocation-watchPosition.html

  • English.lproj/localizedStrings.js:
  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::positionChanged):

  • Modules/geolocation/GeolocationController.h:

(GeolocationController):

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::overrideGeolocationPositionImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::overrideGeolocationPosition):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::setGeolocationOverride):
(WebCore):
(WebCore::InspectorPageAgent::clearGeolocationOverride):
(WebCore::InspectorPageAgent::canOverrideGeolocation):
(WebCore::InspectorPageAgent::overrideGeolocationPosition):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.UserAgentSettingsTab):
(WebInspector.UserAgentSettingsTab.prototype._createDeviceMetricsElement):
(WebInspector.UserAgentSettingsTab.prototype._onGeolocationOverrideCheckboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._applyGeolocationUserInput):
(WebInspector.UserAgentSettingsTab.prototype._setGeolocationPosition.set if):
(WebInspector.UserAgentSettingsTab.prototype._setGeolocationPosition):
(WebInspector.UserAgentSettingsTab.prototype._createGeolocationOverrideElement.createInput):
(WebInspector.UserAgentSettingsTab.prototype._createGeolocationOverrideElement):

  • inspector/front-end/UserAgentSupport.js:

(WebInspector.UserAgentSupport.GeolocationPosition):
(WebInspector.UserAgentSupport.GeolocationPosition.prototype.toSetting):
(WebInspector.UserAgentSupport.GeolocationPosition.parseSetting):
(WebInspector.UserAgentSupport.GeolocationPosition.parseUserInput):
(WebInspector.UserAgentSupport.GeolocationPosition.clearGeolocationOverride):

  • inspector/front-end/inspector.js:

(WebInspector.doLoadedDone):

LayoutTests:

Added new tests.

  • inspector/geolocation-error-expected.txt: Added.
  • inspector/geolocation-error.html: Added.
  • inspector/geolocation-success-expected.txt: Added.
  • inspector/geolocation-success.html: Added.
  • inspector/geolocation-watchPosition-expected.txt: Added.
  • inspector/geolocation-watchPosition.html: Added.
10:43 AM Changeset in webkit [123633] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Build fix for clang builds after r123628
https://bugs.webkit.org/show_bug.cgi?id=92266

Reviewed by Adrienne Walker.

An un-used variable was causing build failures for clang builds
after the refactoring in r123628. It is correct to simply remove
this value.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsInternal):

10:41 AM Changeset in webkit [123632] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

Speech JavaScript API: extract function from SpeechRecognitionResult::emma()
https://bugs.webkit.org/show_bug.cgi?id=92232

Reviewed by Adam Barth.

Extract code for creating emma-qualified names to a helper function.

Just a refactoring; covered by the existing test.

  • Modules/speech/SpeechRecognitionResult.cpp:

(WebCore::emmaQualifiedName):
(WebCore):
(WebCore::SpeechRecognitionResult::emma):

10:39 AM Changeset in webkit [123631] by caio.oliveira@openbossa.org
  • 152 edits
    20 deletes in trunk/LayoutTests

[Qt] css2.1/t* tests needs rebaseline after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91999

Unreviewed.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Removed.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c414-flt-02-c-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c414-flt-03-c-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c414-flt-04-c-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltblck-01-d-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltwrap-00-b-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t090501-c414-flt-01-b-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t090501-c414-flt-03-b-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt: Removed.
  • platform/qt/css2.1/t010403-shand-border-00-c-expected.png:
  • platform/qt/css2.1/t010403-shand-border-00-c-expected.txt:
  • platform/qt/css2.1/t010403-shand-font-00-b-expected.png:
  • platform/qt/css2.1/t010403-shand-font-00-b-expected.txt:
  • platform/qt/css2.1/t010403-shand-font-01-b-expected.png:
  • platform/qt/css2.1/t010403-shand-font-01-b-expected.txt:
  • platform/qt/css2.1/t010403-shand-font-02-b-expected.png:
  • platform/qt/css2.1/t010403-shand-font-02-b-expected.txt:
  • platform/qt/css2.1/t010403-shand-font-03-b-expected.png:
  • platform/qt/css2.1/t010403-shand-font-03-b-expected.txt:
  • platform/qt/css2.1/t050201-c12-grouping-00-b-expected.png:
  • platform/qt/css2.1/t050201-c12-grouping-00-b-expected.txt:
  • platform/qt/css2.1/t0505-c16-descendant-00-e-expected.png:
  • platform/qt/css2.1/t0505-c16-descendant-00-e-expected.txt:
  • platform/qt/css2.1/t0505-c16-descendant-01-e-expected.png:
  • platform/qt/css2.1/t0505-c16-descendant-01-e-expected.txt:
  • platform/qt/css2.1/t0505-c16-descendant-02-e-expected.png:
  • platform/qt/css2.1/t0505-c16-descendant-02-e-expected.txt:
  • platform/qt/css2.1/t050803-c14-classes-00-e-expected.png:
  • platform/qt/css2.1/t050803-c14-classes-00-e-expected.txt:
  • platform/qt/css2.1/t0509-c15-ids-00-a-expected.png:
  • platform/qt/css2.1/t0509-c15-ids-00-a-expected.txt:
  • platform/qt/css2.1/t0509-c15-ids-01-e-expected.png:
  • platform/qt/css2.1/t0509-c15-ids-01-e-expected.txt:
  • platform/qt/css2.1/t0509-id-sel-syntax-01-f-expected.png:
  • platform/qt/css2.1/t0509-id-sel-syntax-01-f-expected.txt:
  • platform/qt/css2.1/t0509-id-sel-syntax-02-b-expected.png:
  • platform/qt/css2.1/t0509-id-sel-syntax-02-b-expected.txt:
  • platform/qt/css2.1/t0510-c25-pseudo-elmnt-00-c-expected.png:
  • platform/qt/css2.1/t0510-c25-pseudo-elmnt-00-c-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-anch-00-e-i-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-anch-00-e-i-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-link-00-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-00-e-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-link-01-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-01-e-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-link-02-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-02-e-expected.txt:
  • platform/qt/css2.1/t0511-c21-pseud-link-03-e-expected.png:
  • platform/qt/css2.1/t0511-c21-pseud-link-03-e-expected.txt:
  • platform/qt/css2.1/t051103-c21-activ-ln-00-e-i-expected.png:
  • platform/qt/css2.1/t051103-c21-activ-ln-00-e-i-expected.txt:
  • platform/qt/css2.1/t051103-c21-focus-ln-00-e-i-expected.png:
  • platform/qt/css2.1/t051103-c21-focus-ln-00-e-i-expected.txt:
  • platform/qt/css2.1/t051103-c21-hover-ln-00-e-i-expected.png:
  • platform/qt/css2.1/t051103-c21-hover-ln-00-e-i-expected.txt:
  • platform/qt/css2.1/t051103-dom-hover-01-c-io-expected.png:
  • platform/qt/css2.1/t051103-dom-hover-01-c-io-expected.txt:
  • platform/qt/css2.1/t051103-dom-hover-02-c-io-expected.png:
  • platform/qt/css2.1/t051103-dom-hover-02-c-io-expected.txt:
  • platform/qt/css2.1/t051202-c24-first-lttr-00-b-expected.png:
  • platform/qt/css2.1/t051202-c24-first-lttr-00-b-expected.txt:
  • platform/qt/css2.1/t051202-c26-psudo-nest-00-c-expected.png:
  • platform/qt/css2.1/t051202-c26-psudo-nest-00-c-expected.txt:
  • platform/qt/css2.1/t0602-c13-inh-underlin-00-e-expected.png:
  • platform/qt/css2.1/t0602-c13-inh-underlin-00-e-expected.txt:
  • platform/qt/css2.1/t0602-c13-inheritance-00-e-expected.png:
  • platform/qt/css2.1/t0602-c13-inheritance-00-e-expected.txt:
  • platform/qt/css2.1/t0602-inherit-bdr-pad-b-00-expected.png:
  • platform/qt/css2.1/t0602-inherit-bdr-pad-b-00-expected.txt:
  • platform/qt/css2.1/t0603-c11-import-00-b-expected.png:
  • platform/qt/css2.1/t0603-c11-import-00-b-expected.txt:
  • platform/qt/css2.1/t060401-c32-cascading-00-b-expected.png:
  • platform/qt/css2.1/t060401-c32-cascading-00-b-expected.txt:
  • platform/qt/css2.1/t060402-c31-important-00-b-expected.png:
  • platform/qt/css2.1/t060402-c31-important-00-b-expected.txt:
  • platform/qt/css2.1/t060403-c21-pseu-cls-00-e-i-expected.png:
  • platform/qt/css2.1/t060403-c21-pseu-cls-00-e-i-expected.txt:
  • platform/qt/css2.1/t060403-c21-pseu-id-00-e-i-expected.png:
  • platform/qt/css2.1/t060403-c21-pseu-id-00-e-i-expected.txt:
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/qt/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.png:
  • platform/qt/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-00-d-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-00-d-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-01-d-g-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-02-c-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-03-c-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-04-c-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-fit-00-d-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-fit-00-d-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-wrap-00-e-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltblck-01-d-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltclr-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-flthw-00-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-flthw-00-c-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltinln-00-c-ag-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltinln-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltmult-00-d-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-01-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-01-c-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
  • platform/qt/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
  • platform/qt/css2.1/t0905-c5526-fltclr-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0905-c5526-flthw-00-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5526-flthw-00-c-g-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-00-d-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-00-d-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-01-b-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-01-b-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-02-d-g-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-ln-00-d-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-ln-00-d-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-ln-01-d-g-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-ln-02-d-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-ln-02-d-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-ln-03-d-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-ln-03-d-expected.txt:
  • platform/qt/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/qt/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
  • platform/qt/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/qt/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
  • platform/qt/css2.1/t1503-c522-font-family-00-b-expected.png:
  • platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-03-b-expected.png:
  • platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-06-b-expected.png:
  • platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
10:22 AM Changeset in webkit [123630] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Chinese IM receives incorrect/duplicated key events in text fields in webpages in Safari.
https://bugs.webkit.org/show_bug.cgi?id=89048
<rdar://problem/11786384>

Reviewed by Andreas Kling.

Cannot test text input from UI process side.

Stop relying on IPC to handle key events in order. There are too many complications
where out of order delivery is performed. Instead, queue the events at UI process
side.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleKeyboardEvent): (WebKit::WebPageProxy::didReceiveEvent):
10:21 AM Changeset in webkit [123629] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] clock_gettime() in BackingStore.cpp should use CLOCK_MONOTONIC
https://bugs.webkit.org/show_bug.cgi?id=91898

Reviewed by Yong Li.
Patch by Jacky Jiang <zhajiang@rim.com>

Let pthread condition variable in BackingStore.cpp use monotonic clock
to fix a regression caused by r123266.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):

10:07 AM Changeset in webkit [123628] by enne@google.com
  • 19 edits in trunk/Source

[chromium] Unify compositor quadTransform/drawTransform/originTransform
https://bugs.webkit.org/show_bug.cgi?id=91417

Reviewed by Kenneth Russell.

Source/WebCore:

drawTransform used to operate on centered layer rects. To unify quad
transforms, draw transforms, and origin transforms, make draw
transforms operate on content rects with the origin in the top left.

This essentially eliminates the need for surface origin transforms,
which will be eliminated in a future patch.

Also, remove the unused CCLayerImpl::getDrawRect function.

No-op refactoring. Tested by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPassQuad):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::drawableContentRect):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForLayer):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::createSharedQuadState):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::createGraphNodes):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateVisibleContentRect):
(WebCore::calculateDrawTransformsInternal):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::markOccludedBehindLayer):
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsToFillScreen):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawableContentRect):

Source/WebKit/chromium:

Clean up tests to refer to the new draw transform semantics.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::createTestTreeWithOneSurface):
(WebKitTests::createTestTreeWithTwoSurfaces):
(WebKitTests::TEST_F):

  • tests/CCLayerSorterTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):

  • tests/CCQuadCullerTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
9:52 AM Changeset in webkit [123627] by tommyw@google.com
  • 22 edits
    2 copies
    3 adds in trunk

MediaStream API: Update MediaStreamTrack to match the specification
https://bugs.webkit.org/show_bug.cgi?id=90180

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebMediaStreamDescriptor.h:

(WebMediaStreamDescriptor):

  • chromium/public/WebMediaStreamSource.h:

(WebMediaStreamSource):

Source/WebCore:

MediaStreamTracks are now required to show the status of the underlying source,
and trigger events when that status changes.

Test: fast/mediastream/MediaStreamTrack.html

  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::setEnabled):
(WebCore::MediaStreamTrack::readyState):
(WebCore):
(WebCore::MediaStreamTrack::sourceChangedState):
(WebCore::MediaStreamTrack::stop):
(WebCore::MediaStreamTrack::interfaceName):
(WebCore::MediaStreamTrack::scriptExecutionContext):
(WebCore::MediaStreamTrack::eventTargetData):
(WebCore::MediaStreamTrack::ensureEventTargetData):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • platform/chromium/support/WebMediaStreamDescriptor.cpp:
  • platform/chromium/support/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::setReadyState):
(WebKit):
(WebKit::WebMediaStreamSource::readyState):

  • platform/mediastream/MediaStreamSource.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamSource.h.

(WebCore):
(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::MediaStreamSource):
(WebCore::MediaStreamSource::setReadyState):
(WebCore::MediaStreamSource::addObserver):
(WebCore::MediaStreamSource::removeObserver):

  • platform/mediastream/MediaStreamSource.h:

(Observer):
(WebCore::MediaStreamSource::Observer::~Observer):
(MediaStreamSource):
(WebCore::MediaStreamSource::readyState):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didCreateMediaStream):

Tools:

Adding a Mock WebMediaStreamCenter to enable better LayoutTests.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::createMediaStreamCenter):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.

(WebKit):
(WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
(WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
(WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
(WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
(WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
(WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
(WebKit::MockWebMediaStreamCenter::constructSDP):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.

(WebKit):
(MockWebMediaStreamCenter):
(WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):

LayoutTests:

  • fast/mediastream/MediaStreamTrack-expected.txt: Added.
  • fast/mediastream/MediaStreamTrack.html: Added.
9:45 AM Changeset in webkit [123626] by allan.jensen@nokia.com
  • 4 edits in trunk/Source/WebCore

Incorrect rounding in ceiledLayoutUnit and roundedLayoutUnit.
https://bugs.webkit.org/show_bug.cgi?id=91061

Reviewed by Adam Barth.

The two functions are currently both returning the flooredLayoutUnit when subpixel
layout is enabled. This patch changes them to return the correct fractional rounded
value.

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::fromFloatCeil):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::fromFloatRound):

  • rendering/LayoutTypes.h:

(WebCore::roundedLayoutUnit):
(WebCore::ceiledLayoutUnit):

  • rendering/RenderBlock.cpp:

(WebCore::updatePreferredWidth):

9:34 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
9:13 AM Changeset in webkit [123625] by gyuyoung.kim@samsung.com
  • 22 edits in trunk/Source/WebCore

Add *explicit* keyword to constructors in WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=92238

Reviewed by Kentaro Hara.

As a step to let *explicit* keyword add to constructors which have a parameter,
*explicit* keyword is added to Source/WebCore/platform in order to avoid implicit
type conversion.

Some files in platform directory can't use explicit keyword because of build breaks.

No new tests. Covered by existing tests.

  • platform/AutodrainedPool.h:

(AutodrainedPool):

  • platform/ContentType.h:

(ContentType):

  • platform/ContextMenu.h:

(ContextMenu):

  • platform/ContextMenuItem.h:

(ContextMenuItem):

  • platform/Cursor.h:

(WebCore::SharedCursor::SharedCursor):
(Cursor):

  • platform/KURL.h:

(WebCore::KURL::KURL):
(KURL):

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree):

  • platform/Pasteboard.h:

(Pasteboard):

  • platform/PlatformEvent.h:

(WebCore::PlatformEvent::PlatformEvent):

  • platform/PlatformKeyboardEvent.h:

(PlatformKeyboardEvent):

  • platform/PlatformMouseEvent.h:

(PlatformMouseEvent):

  • platform/PlatformPasteboard.h:

(PlatformPasteboard):

  • platform/PlatformTouchEvent.h:

(PlatformTouchEvent):

  • platform/PlatformWheelEvent.h:

(PlatformWheelEvent):

  • platform/RunLoop.h:

(TimerBase):

  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/SharedBuffer.h:

(SharedBuffer):

  • platform/WheelFlingPlatformGestureCurve.h:

(WheelFlingPlatformGestureCurve):

  • platform/Widget.h:

(Widget):

9:09 AM Changeset in webkit [123624] by allan.jensen@nokia.com
  • 12 edits
    4 adds in trunk

NodesFromRect and area-based hit-testing can not handle CSS transforms.
https://bugs.webkit.org/show_bug.cgi?id=85792

Reviewed by Eric Seidel.

Source/WebCore:

To support the combination of CSS transforms and rect based hit testing,
we need to test against the transformed rect, instead of the original rect.

This patch makes HitTestPoint store the exact transformed FloatPoint and
FloatQuad, and modifies the intersection methods so that they will use a
new FloatQuad based intersection when transforms requires it.

Tests: fast/dom/nodesFromRect/nodesFromRect-rotate.html

fast/dom/nodesFromRect/nodesFromRect-scale.html

  • platform/graphics/FloatQuad.cpp:

(WebCore::determinant):
(WebCore::rightMostCornerToVector):
(WebCore::FloatQuad::intersectsRect):
(WebCore::FloatQuad::isCounterclockwise):

  • platform/graphics/FloatQuad.h:

(FloatQuad):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestPoint::HitTestPoint):
(WebCore::HitTestPoint::operator=):
(WebCore::HitTestPoint::move):
(WebCore::HitTestPoint::intersectsRect):
(WebCore::HitTestPoint::intersects):

  • rendering/HitTestResult.h:

(HitTestPoint):
(WebCore::HitTestPoint::isRectilinear):
(WebCore::HitTestPoint::transformedPoint):
(WebCore::HitTestPoint::transformedRect):

  • rendering/HitTestingTransformState.cpp:

(WebCore::HitTestingTransformState::flattenWithTransform):
(WebCore::HitTestingTransformState::mappedArea):
(WebCore::HitTestingTransformState::boundsOfMappedArea):

  • rendering/HitTestingTransformState.h:

(WebCore::HitTestingTransformState::create):
(WebCore::HitTestingTransformState::HitTestingTransformState):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestRegion):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestChildLayerColumns):

  • rendering/RenderLayer.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::nodeAtFloatPoint):

LayoutTests:

Adds nodesFromRect tests that tests the API under the CSS transforms
scale and rotate.

  • fast/dom/nodesFromRect/nodesFromRect-rotate-expected.txt: Added.
  • fast/dom/nodesFromRect/nodesFromRect-rotate.html: Added.
  • fast/dom/nodesFromRect/nodesFromRect-scale-expected.txt: Added.
  • fast/dom/nodesFromRect/nodesFromRect-scale.html: Added.
8:51 AM Changeset in webkit [123623] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Add HTMLStackItem.h to project files
https://bugs.webkit.org/show_bug.cgi?id=92221

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-25
Reviewed by Adam Barth.

Added HTMLStackItem.h introduced in r123399 to project files.

Project file changes only, no change in behavior thus no new tests.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
8:40 AM Changeset in webkit [123622] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add "SelectAll" to WebPage
https://bugs.webkit.org/show_bug.cgi?id=92246

Patch by Andy Chen <andchen@rim.com> on 2012-07-25
Reviewed by Antonio Gomes.

Add "Select All" editor command to WebPage.
Internally reviewed by Mike Fenton.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::selectAll):
(WebKit):

  • Api/WebPage.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::selectAll):
(WebKit):

  • WebKitSupport/InputHandler.h:
8:14 AM Changeset in webkit [123621] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r123606.
http://trac.webkit.org/changeset/123606
https://bugs.webkit.org/show_bug.cgi?id=92247

broke Windows build of Chromium (Requested by tomhudson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-25

.:

  • ManualTests/forms/color-suggestion-picker.html: Removed.

Source/WebCore:

  • Resources/colorSuggestionPicker.css: Removed.
  • Resources/colorSuggestionPicker.js: Removed.
  • WebCore.gyp/WebCore.gyp:
8:14 AM Changeset in webkit [123620] by caio.oliveira@openbossa.org
  • 176 edits
    57 adds
    7 deletes in trunk/LayoutTests

[Qt] css2.1/t1* tests needs rebaseline after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92250

Unreviewed.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t1202-counter-03-b-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t1202-counter-04-b-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t1202-counters-03-b-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Removed.
  • platform/qt/css2.1/t1001-abs-pos-cb-01-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-01-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-02-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-02-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-03-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-03-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-04-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-04-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-05-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-05-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-06-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-06-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-07-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-07-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-08-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-08-b-expected.txt:
  • platform/qt/css2.1/t1001-abs-pos-cb-09-b-expected.png:
  • platform/qt/css2.1/t1001-abs-pos-cb-09-b-expected.txt:
  • platform/qt/css2.1/t1002-c5523-width-00-b-g-expected.png:
  • platform/qt/css2.1/t1002-c5523-width-00-b-g-expected.txt:
  • platform/qt/css2.1/t1002-c5523-width-01-b-g-expected.png:
  • platform/qt/css2.1/t1002-c5523-width-01-b-g-expected.txt:
  • platform/qt/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/qt/css2.1/t1002-c5523-width-02-b-g-expected.txt:
  • platform/qt/css2.1/t100303-c412-blockw-00-d-ag-expected.png:
  • platform/qt/css2.1/t100303-c412-blockw-00-d-ag-expected.txt:
  • platform/qt/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png:
  • platform/qt/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.txt:
  • platform/qt/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/qt/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
  • platform/qt/css2.1/t1004-c43-rpl-bbx-00-d-ag-expected.png:
  • platform/qt/css2.1/t1004-c43-rpl-bbx-00-d-ag-expected.txt:
  • platform/qt/css2.1/t1004-c5524-width-00-b-g-expected.png:
  • platform/qt/css2.1/t1004-c5524-width-00-b-g-expected.txt:
  • platform/qt/css2.1/t1005-c5524-width-00-b-g-expected.png:
  • platform/qt/css2.1/t1005-c5524-width-00-b-g-expected.txt:
  • platform/qt/css2.1/t1005-c5524-width-01-b-g-expected.png:
  • platform/qt/css2.1/t1005-c5524-width-01-b-g-expected.txt:
  • platform/qt/css2.1/t1008-c44-ln-box-00-d-ag-expected.png:
  • platform/qt/css2.1/t1008-c44-ln-box-00-d-ag-expected.txt:
  • platform/qt/css2.1/t1008-c44-ln-box-01-d-ag-expected.png:
  • platform/qt/css2.1/t1008-c44-ln-box-01-d-ag-expected.txt:
  • platform/qt/css2.1/t1008-c44-ln-box-03-d-ag-expected.png:
  • platform/qt/css2.1/t1008-c44-ln-box-03-d-ag-expected.txt:
  • platform/qt/css2.1/t100801-c42-ibx-ht-00-d-a-expected.png:
  • platform/qt/css2.1/t100801-c42-ibx-ht-00-d-a-expected.txt:
  • platform/qt/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
  • platform/qt/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
  • platform/qt/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • platform/qt/css2.1/t100801-c544-valgn-02-d-agi-expected.txt:
  • platform/qt/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/qt/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/qt/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
  • platform/qt/css2.1/t100801-c544-valgn-04-d-agi-expected.txt:
  • platform/qt/css2.1/t100801-c548-leadin-00-d-a-expected.png:
  • platform/qt/css2.1/t100801-c548-leadin-00-d-a-expected.txt:
  • platform/qt/css2.1/t100801-c548-ln-ht-00-c-a-expected.png:
  • platform/qt/css2.1/t100801-c548-ln-ht-00-c-a-expected.txt:
  • platform/qt/css2.1/t100801-c548-ln-ht-01-b-ag-expected.png: Removed.
  • platform/qt/css2.1/t100801-c548-ln-ht-01-b-ag-expected.txt: Removed.
  • platform/qt/css2.1/t100801-c548-ln-ht-03-d-ag-expected.png:
  • platform/qt/css2.1/t100801-c548-ln-ht-03-d-ag-expected.txt:
  • platform/qt/css2.1/t100801-c548-ln-ht-04-d-ag-expected.png:
  • platform/qt/css2.1/t100801-c548-ln-ht-04-d-ag-expected.txt:
  • platform/qt/css2.1/t1202-counter-00-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-00-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-01-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-02-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-02-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-03-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-03-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-04-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-04-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-05-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-05-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-06-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-06-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-07-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-07-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-08-b-expected.png:
  • platform/qt/css2.1/t1202-counter-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-11-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-11-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-12-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-12-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-13-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-13-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-14-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-14-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-16-f-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-16-f-expected.txt:
  • platform/qt/css2.1/t1202-counters-00-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-00-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-01-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-02-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-02-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-03-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-03-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-05-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-05-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-06-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-06-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-07-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-07-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-08-b-expected.png:
  • platform/qt/css2.1/t1202-counters-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-11-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-11-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-12-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-12-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-13-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-13-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-14-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-14-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-16-c-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-16-c-expected.txt:
  • platform/qt/css2.1/t1202-counters-17-d-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-17-d-expected.txt:
  • platform/qt/css2.1/t1202-counters-18-f-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-18-f-expected.txt:
  • platform/qt/css2.1/t1204-implied-00-b-expected.png:
  • platform/qt/css2.1/t1204-implied-00-b-expected.txt:
  • platform/qt/css2.1/t1204-implied-01-c-expected.png:
  • platform/qt/css2.1/t1204-implied-01-c-expected.txt:
  • platform/qt/css2.1/t1204-implied-02-d-expected.png:
  • platform/qt/css2.1/t1204-implied-02-d-expected.txt:
  • platform/qt/css2.1/t1204-multiple-00-c-expected.png:
  • platform/qt/css2.1/t1204-multiple-00-c-expected.txt:
  • platform/qt/css2.1/t1204-multiple-01-c-expected.png:
  • platform/qt/css2.1/t1204-multiple-01-c-expected.txt:
  • platform/qt/css2.1/t1204-order-00-c-expected.png:
  • platform/qt/css2.1/t1204-order-00-c-expected.txt:
  • platform/qt/css2.1/t1204-order-01-d-expected.png:
  • platform/qt/css2.1/t1204-order-01-d-expected.txt:
  • platform/qt/css2.1/t1204-root-e-expected.png:
  • platform/qt/css2.1/t1204-root-e-expected.txt:
  • platform/qt/css2.1/t120401-scope-00-b-expected.png:
  • platform/qt/css2.1/t120401-scope-00-b-expected.txt:
  • platform/qt/css2.1/t120401-scope-01-c-expected.png:
  • platform/qt/css2.1/t120401-scope-01-c-expected.txt:
  • platform/qt/css2.1/t120401-scope-02-c-expected.png:
  • platform/qt/css2.1/t120401-scope-02-c-expected.txt:
  • platform/qt/css2.1/t120401-scope-03-c-expected.png:
  • platform/qt/css2.1/t120401-scope-03-c-expected.txt:
  • platform/qt/css2.1/t120401-scope-04-d-expected.png:
  • platform/qt/css2.1/t120401-scope-04-d-expected.txt:
  • platform/qt/css2.1/t120403-content-none-00-c-expected.png:
  • platform/qt/css2.1/t120403-content-none-00-c-expected.txt:
  • platform/qt/css2.1/t120403-display-none-00-c-expected.png:
  • platform/qt/css2.1/t120403-display-none-00-c-expected.txt:
  • platform/qt/css2.1/t120403-visibility-00-c-expected.png:
  • platform/qt/css2.1/t120403-visibility-00-c-expected.txt:
  • platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.png: Added.
  • platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c563-list-type-00-b-expected.png: Added.
  • platform/qt/css2.1/t1205-c563-list-type-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c563-list-type-01-b-expected.png: Added.
  • platform/qt/css2.1/t1205-c563-list-type-01-b-expected.txt:
  • platform/qt/css2.1/t1205-c564-list-img-00-b-g-expected.png: Added.
  • platform/qt/css2.1/t1205-c564-list-img-00-b-g-expected.txt:
  • platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.png: Added.
  • platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • platform/qt/css2.1/t1205-c566-list-stl-00-e-ag-expected.png: Added.
  • platform/qt/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
  • platform/qt/css2.1/t1205-c566-list-stl-01-c-g-expected.png: Added.
  • platform/qt/css2.1/t1205-c566-list-stl-01-c-g-expected.txt:
  • platform/qt/css2.1/t1401-c531-color-00-a-expected.png:
  • platform/qt/css2.1/t1401-c531-color-00-a-expected.txt:
  • platform/qt/css2.1/t1402-c45-bg-canvas-00-b-expected.png:
  • platform/qt/css2.1/t1402-c45-bg-canvas-00-b-expected.txt:
  • platform/qt/css2.1/t140201-c532-bgcolor-00-a-expected.png: Added.
  • platform/qt/css2.1/t140201-c532-bgcolor-00-a-expected.txt:
  • platform/qt/css2.1/t140201-c532-bgcolor-01-b-expected.png: Added.
  • platform/qt/css2.1/t140201-c532-bgcolor-01-b-expected.txt:
  • platform/qt/css2.1/t140201-c533-bgimage-00-a-expected.png: Added.
  • platform/qt/css2.1/t140201-c533-bgimage-00-a-expected.txt:
  • platform/qt/css2.1/t140201-c533-bgimage-01-b-g-expected.png: Added.
  • platform/qt/css2.1/t140201-c533-bgimage-01-b-g-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgre-00-b-ag-expected.png: Added.
  • platform/qt/css2.1/t140201-c534-bgre-00-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c534-bgre-01-b-ag-expected.png:
  • platform/qt/css2.1/t140201-c534-bgre-01-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Added.
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
  • platform/qt/css2.1/t140201-c536-bgpos-00-b-ag-expected.png: Added.
  • platform/qt/css2.1/t140201-c536-bgpos-00-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c536-bgpos-01-b-ag-expected.png:
  • platform/qt/css2.1/t140201-c536-bgpos-01-b-ag-expected.txt:
  • platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.txt:
  • platform/qt/css2.1/t1504-c523-font-style-00-b-expected.png: Added.
  • platform/qt/css2.1/t1504-c523-font-style-00-b-expected.txt:
  • platform/qt/css2.1/t1505-c524-font-var-00-b-expected.png:
  • platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
  • platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.png: Added.
  • platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-00-b-expected.png: Added.
  • platform/qt/css2.1/t1507-c526-font-sz-00-b-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.png: Added.
  • platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
  • platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.png: Added.
  • platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-00-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-01-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-01-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-02-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-02-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-04-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-05-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-07-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-08-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-09-b-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-09-b-expected.txt: Added.
  • platform/qt/css2.1/t1508-c527-font-10-c-expected.png: Added.
  • platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
  • platform/qt/css2.1/t1601-c547-indent-01-d-expected.png:
  • platform/qt/css2.1/t1601-c547-indent-01-d-expected.txt:
  • platform/qt/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/qt/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png:
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt:
  • platform/qt/css2.1/t1606-c562-white-sp-00-b-ag-expected.png:
  • platform/qt/css2.1/t1606-c562-white-sp-00-b-ag-expected.txt:
8:09 AM Changeset in webkit [123619] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Calendar picker popup displays at wrong scale when deviceScaleFactor != 1.
https://bugs.webkit.org/show_bug.cgi?id=92177

Manually tested at deviceScaleFactor = 1 and 2.

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-25
Reviewed by Kent Tamura.

The device scale factor was not being set for the calendar popup.
As a result, the popup was rendered too small on hidpi displays.
This patch sets the device scale factor for any page popup.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initPage):

8:05 AM Changeset in webkit [123618] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: disabling property should remove "overriden" decoration from overriden UA shorthand.
https://bugs.webkit.org/show_bug.cgi?id=92253

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Bug fix with a test and more compilation markup.

Test: inspector/styles/styles-disable-then-enable-overriden-ua.html

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.update):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • inspector/styles/styles-disable-then-enable-overriden-ua-expected.txt: Added.
  • inspector/styles/styles-disable-then-enable-overriden-ua.html: Added.
7:59 AM Changeset in webkit [123617] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Don't touch a tile buffer while it's still on its way to the GPU
https://bugs.webkit.org/show_bug.cgi?id=91992

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-25
Reviewed by Adam Treat.

PR: 141439
The copyPreviousContentsToBackSurfaceOfTile() call will also modify
buffer contents, move it after the blit generation condvar to make sure
we've waited for the buffer to become available first.

This is done as part of some general BackingStorePrivate::render()
cleanup in PR 141439.

Internally reviewed by Jakob Petsovits.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):

7:55 AM Changeset in webkit [123616] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Improve ObjectPropertiesSection UI by adding a tooltip for the value.
https://bugs.webkit.org/show_bug.cgi?id=92225

Reviewed by Pavel Feldman.

Added tooltip with property value description on the property's valueElement.

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

7:12 AM Changeset in webkit [123615] by caio.oliveira@openbossa.org
  • 63 edits
    55 adds
    1 delete in trunk/LayoutTests

[Qt] css2.1/t040* rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92248

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt/css2.1/t040102-keywords-00-b-expected.png: Added.
  • platform/qt/css2.1/t040102-keywords-00-b-expected.txt:
  • platform/qt/css2.1/t040102-keywords-01-b-expected.png: Added.
  • platform/qt/css2.1/t040102-keywords-01-b-expected.txt:
  • platform/qt/css2.1/t040103-case-00-b-expected.png: Added.
  • platform/qt/css2.1/t040103-case-00-b-expected.txt:
  • platform/qt/css2.1/t040103-case-01-c-expected.png: Added.
  • platform/qt/css2.1/t040103-case-01-c-expected.txt:
  • platform/qt/css2.1/t040103-escapes-00-b-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-00-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-01-b-expected.png:
  • platform/qt/css2.1/t040103-escapes-01-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-02-d-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-02-d-expected.txt:
  • platform/qt/css2.1/t040103-escapes-03-b-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-03-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-04-b-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-04-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-05-c-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-05-c-expected.txt:
  • platform/qt/css2.1/t040103-escapes-06-b-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-06-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-07-b-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-07-b-expected.txt:
  • platform/qt/css2.1/t040103-escapes-08-b-expected.png: Added.
  • platform/qt/css2.1/t040103-escapes-08-b-expected.txt:
  • platform/qt/css2.1/t040103-ident-00-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-00-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-01-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-01-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-02-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-02-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-03-c-expected.txt: Removed.
  • platform/qt/css2.1/t040103-ident-04-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-04-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-05-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-05-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-06-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-06-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-07-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-07-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-08-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-08-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-09-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-09-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-10-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-10-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-11-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-11-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-12-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-12-c-expected.txt:
  • platform/qt/css2.1/t040103-ident-13-c-expected.png: Added.
  • platform/qt/css2.1/t040103-ident-13-c-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-00-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atkeyw-00-b-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-01-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atkeyw-01-b-expected.txt:
  • platform/qt/css2.1/t040105-atkeyw-02-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atkeyw-02-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-00-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atrule-00-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-01-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atrule-01-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-02-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atrule-02-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-03-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atrule-03-b-expected.txt:
  • platform/qt/css2.1/t040105-atrule-04-b-expected.png: Added.
  • platform/qt/css2.1/t040105-atrule-04-b-expected.txt:
  • platform/qt/css2.1/t040105-import-00-b-expected.png: Added.
  • platform/qt/css2.1/t040105-import-00-b-expected.txt:
  • platform/qt/css2.1/t040105-import-01-b-expected.png: Added.
  • platform/qt/css2.1/t040105-import-01-b-expected.txt:
  • platform/qt/css2.1/t040105-import-10-b-expected.png:
  • platform/qt/css2.1/t040105-import-10-b-expected.txt:
  • platform/qt/css2.1/t040109-c17-comments-00-b-expected.png: Added.
  • platform/qt/css2.1/t040109-c17-comments-00-b-expected.txt:
  • platform/qt/css2.1/t040109-c17-comments-01-b-expected.png: Added.
  • platform/qt/css2.1/t040109-c17-comments-01-b-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.png: Added.
  • platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-01-f-expected.png: Added.
  • platform/qt/css2.1/t0402-c71-fwd-parsing-01-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-02-f-expected.png: Added.
  • platform/qt/css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-03-f-expected.png: Added.
  • platform/qt/css2.1/t0402-c71-fwd-parsing-03-f-expected.txt:
  • platform/qt/css2.1/t0402-c71-fwd-parsing-04-f-expected.png: Added.
  • platform/qt/css2.1/t0402-c71-fwd-parsing-04-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-01-f-expected.png: Added.
  • platform/qt/css2.1/t0402-syntax-01-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-02-f-expected.png: Added.
  • platform/qt/css2.1/t0402-syntax-02-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-03-f-expected.png: Added.
  • platform/qt/css2.1/t0402-syntax-03-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-04-f-expected.png: Added.
  • platform/qt/css2.1/t0402-syntax-04-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-05-f-expected.png: Added.
  • platform/qt/css2.1/t0402-syntax-05-f-expected.txt:
  • platform/qt/css2.1/t0402-syntax-06-f-expected.png: Added.
  • platform/qt/css2.1/t0402-syntax-06-f-expected.txt:
  • platform/qt/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Added.
  • platform/qt/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
  • platform/qt/css2.1/t040302-c61-phys-len-00-b-expected.png: Added.
  • platform/qt/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/qt/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Added.
  • platform/qt/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt:
  • platform/qt/css2.1/t040303-c62-percent-00-b-ag-expected.png:
  • platform/qt/css2.1/t040303-c62-percent-00-b-ag-expected.txt:
  • platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.png: Added.
  • platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
  • platform/qt/css2.1/t040306-c63-color-00-b-ag-expected.png: Added.
  • platform/qt/css2.1/t040306-c63-color-00-b-ag-expected.txt:
  • platform/qt/css2.1/t040306-syntax-01-f-expected.png: Added.
  • platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
  • platform/qt/css2.1/t040307-syntax-01-b-expected.png: Added.
  • platform/qt/css2.1/t040307-syntax-01-b-expected.txt:
6:58 AM Changeset in webkit [123614] by kkristof@inf.u-szeged.hu
  • 6 edits in trunk/Tools

[NRWT] Rename baseline_search_path() to default_baseline_search_path()
https://bugs.webkit.org/show_bug.cgi?id=92122

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_version_dir):
(Port.baseline_search_path):
(Port):
(Port.default_baseline_search_path):
(Port.expected_baselines):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_additional_platform_directory):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.default_baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.default_baseline_search_path):

6:52 AM Changeset in webkit [123613] by caio.oliveira@openbossa.org
  • 3 edits
    1 delete in trunk/LayoutTests

[Qt] Fix rebaseline for two tests in svg/hixie
https://bugs.webkit.org/show_bug.cgi?id=92244

Reviewed by Alexis Menard.

  • platform/qt-5.0/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/qt/svg/hixie/error/017-expected.txt:
  • platform/qt/svg/hixie/intrinsic/003-expected.png:
6:48 AM Changeset in webkit [123612] by pfeldman@chromium.org
  • 18 edits
    2 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=91931

Reviewed by Vsevolod Vlasov.

  • Synthetic shorthand values are now only returned for source-less styles
  • CSSAgents reports longhands along with the property names in getSupportedCSSProperties
  • StylesSidebarPane now has two paths: for source-enabled styles and for CSSOM-based ones (UA styles)
  • CSSStyleModel uses style metainfo as a source of shorthand / longhand relationship now

Test: inspector/styles/styles-overriden-properties.html

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getSupportedCSSProperties):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::styleWithProperties):

  • inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions):
(WebInspector.CSSCompletions.requestCSSNameCompletions):
(WebInspector.CSSCompletions.prototype._closest):
(WebInspector.CSSCompletions.prototype.longhands):
(WebInspector.CSSCompletions.prototype.shorthands):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleDeclaration):
(WebInspector.CSSStyleDeclaration.prototype.longhandProperties):
(WebInspector.CSSStyleDeclaration.prototype.shorthandValue):
(WebInspector.CSSStyleDeclaration.prototype.newBlankProperty):
(WebInspector.CSSProperty):
(WebInspector.CSSProperty.parsePayload):

  • inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer):

  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
(WebInspector.StylePropertiesSection.prototype.update):
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests: Web Inspector: Redundant Style Declarations Missing in Styles Section
https://bugs.webkit.org/show_bug.cgi?id=91931

Reviewed by Vsevolod Vlasov.

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpStyleTreeItem):

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/styles/force-pseudo-state-expected.txt:
  • inspector/styles/inject-stylesheet-expected.txt:
  • inspector/styles/lazy-computed-style-expected.txt:
  • inspector/styles/styles-overriden-properties-expected.txt: Added.
  • inspector/styles/styles-overriden-properties.html: Added.
  • inspector/styles/styles-update-from-js-expected.txt:
  • platform/chromium/inspector/styles/inject-stylesheet-expected.txt: Removed.
6:31 AM Changeset in webkit [123611] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip 2 more tests because of minor 32/64 bit differences.
6:18 AM Changeset in webkit [123610] by jpetsovits@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] notifyContentRendered() call missing in two spots
https://bugs.webkit.org/show_bug.cgi?id=92153
RIM PR 173340

Reviewed by Antonio Gomes.

In dispatchDidFirstVisualLayout() and repaint() in
immediate mode, we render but don't notify the
WebPageClient that the content was modified.

In the long run, we should probably keep track of
the modified reason from within render() itself
and use this to automatically notify the client
from within blitContents() and/or invalidateWindow(),
depending on the rendering path. That's somewhat of
a medium-size undertaking though; for now, adding
the call directly to the renderVisibleContents()
call sites will do.

This patch also adds a blitVisibleContents() to
dispatchDidFirstVisualLayout() where it was
inexplicably missing, probably on account of
old code that was never updated.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::repaint):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):

6:00 AM Changeset in webkit [123609] by alexis.menard@openbossa.org
  • 27 edits
    2 adds in trunk/LayoutTests

[Qt] svg/dom, svg/filters, svg/foreignObject rebaseline after new test fonts.
https://bugs.webkit.org/show_bug.cgi?id=92243

Unreviewed gardening.

These tests have been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.txt:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt:
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.png: Added.
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.png:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.png:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/filters/filter-width-update-expected.png:
  • platform/qt/svg/filters/filter-width-update-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.png: Added.
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-display-changes-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-display-none-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png:
  • platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.png:
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.txt:
5:32 AM Changeset in webkit [123608] by alexis.menard@openbossa.org
  • 69 edits
    2 adds in trunk/LayoutTests

[Qt] svg/hixie rebaseline after new test fonts.
https://bugs.webkit.org/show_bug.cgi?id=92242

Unreviewed gardening.

These tests have been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/hixie/dynamic/002-expected.txt:
  • platform/qt/svg/hixie/error/002-expected.txt:
  • platform/qt/svg/hixie/error/003-expected.png:
  • platform/qt/svg/hixie/error/003-expected.txt:
  • platform/qt/svg/hixie/error/010-expected.png:
  • platform/qt/svg/hixie/error/010-expected.txt:
  • platform/qt/svg/hixie/error/011-expected.png:
  • platform/qt/svg/hixie/error/011-expected.txt:
  • platform/qt/svg/hixie/error/013-expected.png:
  • platform/qt/svg/hixie/error/013-expected.txt:
  • platform/qt/svg/hixie/error/017-expected.png:
  • platform/qt/svg/hixie/error/017-expected.txt:
  • platform/qt/svg/hixie/intrinsic/001-expected.png:
  • platform/qt/svg/hixie/intrinsic/001-expected.txt:
  • platform/qt/svg/hixie/intrinsic/002-expected.png:
  • platform/qt/svg/hixie/intrinsic/002-expected.txt:
  • platform/qt/svg/hixie/intrinsic/003-expected.png:
  • platform/qt/svg/hixie/intrinsic/003-expected.txt:
  • platform/qt/svg/hixie/links/002-expected.png:
  • platform/qt/svg/hixie/links/002-expected.txt:
  • platform/qt/svg/hixie/mixed/003-expected.png:
  • platform/qt/svg/hixie/mixed/003-expected.txt:
  • platform/qt/svg/hixie/mixed/004-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/005-expected.txt: Added.
  • platform/qt/svg/hixie/mixed/006-expected.png:
  • platform/qt/svg/hixie/mixed/006-expected.txt:
  • platform/qt/svg/hixie/mixed/007-expected.txt:
  • platform/qt/svg/hixie/mixed/008-expected.png:
  • platform/qt/svg/hixie/mixed/008-expected.txt:
  • platform/qt/svg/hixie/mixed/009-expected.png:
  • platform/qt/svg/hixie/mixed/009-expected.txt:
  • platform/qt/svg/hixie/mixed/010-expected.png:
  • platform/qt/svg/hixie/mixed/010-expected.txt:
  • platform/qt/svg/hixie/mixed/011-expected.png:
  • platform/qt/svg/hixie/mixed/011-expected.txt:
  • platform/qt/svg/hixie/perf/001-expected.txt:
  • platform/qt/svg/hixie/perf/002-expected.txt:
  • platform/qt/svg/hixie/perf/003-expected.png:
  • platform/qt/svg/hixie/perf/003-expected.txt:
  • platform/qt/svg/hixie/perf/004-expected.png:
  • platform/qt/svg/hixie/perf/004-expected.txt:
  • platform/qt/svg/hixie/perf/005-expected.png:
  • platform/qt/svg/hixie/perf/005-expected.txt:
  • platform/qt/svg/hixie/perf/006-expected.png:
  • platform/qt/svg/hixie/perf/006-expected.txt:
  • platform/qt/svg/hixie/perf/007-expected.png:
  • platform/qt/svg/hixie/perf/007-expected.txt:
  • platform/qt/svg/hixie/processing-model/003-expected.png:
  • platform/qt/svg/hixie/processing-model/003-expected.txt:
  • platform/qt/svg/hixie/processing-model/004-expected.png:
  • platform/qt/svg/hixie/processing-model/004-expected.txt:
  • platform/qt/svg/hixie/rendering-model/003-expected.png:
  • platform/qt/svg/hixie/rendering-model/003-expected.txt:
  • platform/qt/svg/hixie/rendering-model/004-expected.png:
  • platform/qt/svg/hixie/rendering-model/004-expected.txt:
  • platform/qt/svg/hixie/text/002-expected.png:
  • platform/qt/svg/hixie/text/002-expected.txt:
  • platform/qt/svg/hixie/text/003-expected.png:
  • platform/qt/svg/hixie/text/003-expected.txt:
  • platform/qt/svg/hixie/text/003a-expected.png:
  • platform/qt/svg/hixie/text/003a-expected.txt:
  • platform/qt/svg/hixie/text/003b-expected.png:
  • platform/qt/svg/hixie/text/003b-expected.txt:
  • platform/qt/svg/hixie/viewbox/002-expected.txt:
  • platform/qt/svg/hixie/viewbox/003-expected.txt:
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.png:
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
5:28 AM Changeset in webkit [123607] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-4.8/Skipped: Unskip now passing tests. (bug85203)
  • platform/qt/Skipped: Skip new tests without expected files.
4:57 AM Changeset in webkit [123606] by keishi@webkit.org
  • 3 edits
    3 adds in trunk

Implement ColorSuggestionPicker page popup
https://bugs.webkit.org/show_bug.cgi?id=92109

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/color-suggestion-picker.html: Added. Tests colorSuggestionPicker.{js,css}

Source/WebCore:

Implements ColorSuggestionPicker page popup. This will be used in
certain ports as the datalist UI for <input type=color>.

No new tests because there is no way to open the popup yet.

  • Resources/colorSuggestionPicker.css: Added.

(body):
(#main):
(.color-swatch):
(.color-swatch:hover):
(.color-swatch-container):
(.other-color):

  • Resources/colorSuggestionPicker.js: Added.

(getScrollbarWidth):When there are more than 20 colors we need to
increase the window width to accommodate the scroll bar.
(createElement):
(handleMessage):
(initialize):
(handleArgumentsTimeout):
(validateArguments):
(submitValue): Calls setValueAndClosePopup with a numValue of 0.
(handleCancel): Calls setValueAndClosePopup with a numValue of -1.
(chooseOtherColor): Calls setValueAndClosePopup with a numValue of -2.
(ColorPicker):
(ColorPicker.prototype._layout): Lays out the color swatches in a 5x4
grid.
(ColorPicker.prototype._handleSwatchClick):

  • WebCore.gyp/WebCore.gyp:
4:54 AM Changeset in webkit [123605] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebCore

Fix arithmetic composite filter for auto-vectorization
https://bugs.webkit.org/show_bug.cgi?id=92123

Reviewed by Nikolas Zimmermann.

Since only clamping of the result prevents GCC from auto-vectorizing the inner loop, this patch
adds a faster version of the inner loop to handle cases where clamping is unnecessary,

  • platform/graphics/filters/FEComposite.cpp:

(WebCore::computeArithmeticPixelsUnclamped):
(WebCore::arithmeticSoftware):

4:46 AM Changeset in webkit [123604] by gyuyoung.kim@samsung.com
  • 19 edits in trunk

[EFL] Use eina_stringshare_add instead of strdup.
https://bugs.webkit.org/show_bug.cgi?id=92072

Reviewed by Kentaro Hara.

Eina of EFL libraries supports a string functionality that replaces strdup. So, EFL port needs
to replace strdup with eina_stringshare_add function.

Source/WebKit/efl:

In addition, some API descriptions need to be modified according to ewk APIs's parameter and
return type change.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::runJavaScriptPrompt):

  • ewk/ewk_cookies.cpp:

(ewk_cookies_get_all):
(ewk_cookies_cookie_free):

  • ewk/ewk_cookies.h:
  • ewk/ewk_frame.cpp:

(ewk_frame_script_execute):
(ewk_frame_selection_get):
(ewk_frame_resources_location_get):
(ewk_frame_plain_text_get):

  • ewk/ewk_frame.h:
  • ewk/ewk_intent.cpp:

(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):

  • ewk/ewk_intent.h:
  • ewk/ewk_js.cpp:

(ewk_js_variant_to_npvariant):
(ewk_js_object_new):

  • ewk/ewk_view.cpp:

(_ewk_view_smart_run_javascript_prompt):
(ewk_view_selection_get):
(ewk_view_run_javascript_prompt):
(ewk_view_run_open_panel):

  • ewk/ewk_view.h:
  • ewk/ewk_view_private.h:

Source/WebKit2:

  • UIProcess/API/efl/ewk_intent.cpp:

(ewk_intent_suggestions_get):
(ewk_intent_extra_get):

  • UIProcess/API/efl/ewk_intent.h:

Tools:

DumpRenderTree also needs to be modified according to ewk APIs's parameter change.

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(dumpFramesAsText):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onFrameIntentNew):

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onJavaScriptPrompt):

4:28 AM Changeset in webkit [123603] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] Rebaseline for changed mathml dump after r123492
https://bugs.webkit.org/show_bug.cgi?id=92234

Unreviewed, EFL rebaseline.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-25

  • platform/efl/mathml/msub-anonymous-child-render-crash-expected.txt: Added.
4:15 AM Changeset in webkit [123602] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebCore

Fix blend filter for autovectorizing
https://bugs.webkit.org/show_bug.cgi?id=91398

Reviewed by Nikolas Zimmermann.

Get rid of wrapper classes, and use functions directly as template argument.

  • platform/graphics/filters/FEBlend.cpp:

(WebCore::feBlendNormal):
(WebCore::feBlendMultiply):
(WebCore::feBlendScreen):
(WebCore::feBlendDarken):
(WebCore::feBlendLighten):
(WebCore::feBlendUnknown):
(WebCore::platformApply):
(WebCore::FEBlend::platformApplyGeneric):

4:03 AM Changeset in webkit [123601] by keishi@webkit.org
  • 5 edits in trunk/Source/WebCore

Add methods to ColorChooserClient so the color chooser can show suggestions
https://bugs.webkit.org/show_bug.cgi?id=92114

Reviewed by Kent Tamura.

Added methods to ColorChooserClient so the color chooser can ask the
client for suggestions and current color.

No new tests. The methods are not used yet.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::currentColor): Returns what color the color
chooser should display.
(WebCore):
(WebCore::ColorInputType::shouldShowSuggestions): Returns if the UI for
suggestions should be shown.
(WebCore::ColorInputType::suggestions): Returns a list of colors to be
suggested to the user.

  • html/ColorInputType.h:

(ColorInputType):

  • html/HTMLInputElement.h:

(HTMLInputElement): Made dataList() public.

  • platform/ColorChooserClient.h:

(ColorChooserClient):

3:35 AM Changeset in webkit [123600] by haraken@chromium.org
  • 11 edits in trunk/Source/WebCore

Replace int with long in test IDL files
https://bugs.webkit.org/show_bug.cgi?id=92181

Reviewed by Adam Barth.

int is not a valid type in WebIDL. It should be long.
We should replace int with long in bindings/scripts/test/*.idl.
This is a follow-up patch for r123550.

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::readOnlyLongAttr):
(WebDOMTestObj::Attr):
(WebDOMTestObj::setAttr):
(WebDOMTestObj::voidMethodWithArgs):
(WebDOMTestObj::Method):
(WebDOMTestObj::MethodWithArgs):
(WebDOMTestObj::objMethodWithArgs):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_void_method_with_args):
(webkit_dom_test_obj_method):
(webkit_dom_test_obj_method_with_args):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_get_read_only_long_attr):
(webkit_dom_test_obj_get_attr):
(webkit_dom_test_obj_set_attr):
(webkit_dom_test_obj_get_strawberry):
(webkit_dom_test_obj_set_strawberry):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjReadOnlyLongAttr):
(WebCore::jsTestObjConstructorStaticReadOnlyLongAttr):
(WebCore::jsTestObjAttr):
(WebCore::setJSTestObjAttr):
(WebCore::setJSTestObjStrawberry):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethod):
(WebCore::jsTestObjPrototypeFunctionMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj readOnlyLongAttr]):
(-[DOMTestObj Attr]):
(-[DOMTestObj setAttr:]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj Method]):
(-[DOMTestObj MethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetter):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetter):
(WebCore::TestObjV8Internal::AttrAttrGetter):
(WebCore::TestObjV8Internal::AttrAttrSetter):
(WebCore::TestObjV8Internal::strawberryAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::MethodCallback):
(WebCore::TestObjV8Internal::MethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

3:26 AM Changeset in webkit [123599] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[WTR][EFL] Wheel events are not emitted
https://bugs.webkit.org/show_bug.cgi?id=92094

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-07-25
Reviewed by Csaba Osztrogonác.

Wheel events are not emitted, therefore, layout tests that use mouseScrollBy method are failing.

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::dispatchMouseScrollByEvent):
(WTR::EventSenderProxy::mouseScrollBy):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::focus):

3:09 AM Changeset in webkit [123598] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

A validation bubble should not be modifiable.
https://bugs.webkit.org/show_bug.cgi?id=92217

Reviewed by Kent Tamura.

Source/WebCore:

A user can set -webkit-user-modify: read-write to validation message elements.
This might cause a undesired crash like Bug 65738. They should be unmodifiable.

Test: fast/forms/validation-user-modify.html

  • css/html.css:

Added -webkit-user-modify: read-only !important; for these elements so that they won't be
changed by a user.
(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-text-block):
(::-webkit-validation-bubble-heading):
(::-webkit-validation-bubble-arrow):
(::-webkit-validation-bubble-arrow-clipper):

LayoutTests:

  • fast/forms/validation-message-user-modify-expected.txt: Added.
  • fast/forms/validation-message-user-modify.html: Added.
3:00 AM Changeset in webkit [123597] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk/Source/WebKit

[EFL] Add File Chooser API
https://bugs.webkit.org/show_bug.cgi?id=91957

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-25
Reviewed by Hajime Morita.

Source/WebKit:

Add ewk_file_chooser source and header.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Add APIs for file chooser. These APIs allow an application(like a browser) queries informations
about multiple files allowed, directory upload allowed, accept mimetypes list,
accept file extentions list, selected files list and capture to support HTML media capture.

  • ewk/EWebKit.h:
  • ewk/ewk_file_chooser.cpp: Added.

(_Ewk_File_Chooser):
(ewk_file_chooser_allows_multiple_files_get):
(ewk_file_chooser_allows_directory_upload_get):
(ewk_file_chooser_accept_mimetypes_get):
(ewk_file_chooser_accept_file_extentions_get):
(ewk_file_chooser_selected_files_get):
(ewk_file_chooser_capture_get):
(ewk_file_chooser_new):
(ewk_file_chooser_free):

  • ewk/ewk_file_chooser.h: Added.
  • ewk/ewk_file_chooser_private.h: Added.

(WebCore):

2:54 AM Changeset in webkit [123596] by Csaba Osztrogonác
  • 3 edits
    15 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, update Qt5 specific test results.

  • platform/qt-5.0-wk1/fast/text/whitespace/028-expected.png: Added.
  • platform/qt-5.0-wk1/fast/text/whitespace/028-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/text/whitespace/028-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/whitespace/028-expected.txt: Added.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Added.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Added.
  • platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
  • platform/qt-5.0/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/qt-5.0/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
  • platform/qt-5.0/svg/batik/text/longTextOnPath-expected.png: Added.
  • platform/qt-5.0/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/qt-5.0/svg/carto.net/tabgroup-expected.png: Added.
  • platform/qt-5.0/svg/carto.net/tabgroup-expected.txt: Added.
2:43 AM Changeset in webkit [123595] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-25

  • platform/qt/Skipped:
2:30 AM Changeset in webkit [123594] by zandobersek@gmail.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed GTK gardening, updating one mathml test baseline after r123492.

  • platform/gtk/mathml/msub-anonymous-child-render-crash-expected.txt: Added.
2:16 AM Changeset in webkit [123593] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add ewk_view_cursor_set to change cursor.
https://bugs.webkit.org/show_bug.cgi?id=89140

Reviewed by Hajime Morita.

Implement ewk_view_cursor_set to support cursor changes.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursor): Called ewk_view_cursor_set.

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(_ewk_view_priv_new): Check whether ecore_x can be used.
(_ewk_view_smart_add):
Change order of initialization to use base structure in _ewk_view_priv_new.
(ewk_view_cursor_set): Added to set cursor.

  • UIProcess/API/efl/ewk_view_private.h:
2:05 AM Changeset in webkit [123592] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-25

  • platform/qt/Skipped:
2:03 AM Changeset in webkit [123591] by ryuan.choi@samsung.com
  • 6 edits
    1 add in trunk/Source/WebKit2

[EFL][WK2] Update uri when the active URI is changed while loading.
https://bugs.webkit.org/show_bug.cgi?id=92001

Reviewed by Hajime Morita.

For now, ewk_view_uri_get just return the last uri of setter.
This patch updates the uri of ewk_view when it is changed while loading.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_uri_update):
Added to check whether current active URI has changed and send uri,changed
signal if it has changed.
(ewk_view_uri_set):
Called ewk_view_uri_update to make sure the active uri is updated when the
load operation is started.
(ewk_view_reload): Ditto.
(ewk_view_reload_bypass_cache): Ditto.
(ewk_view_load_finished): Ditto.
(ewk_view_load_provisional_redirect): Ditto.
(ewk_view_load_provisional_started): Ditto.
(ewk_view_html_string_load): Ditto.

  • UIProcess/API/efl/ewk_view.h: Updated comment for uri,changed signal.
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::urlForResource):
Added to get url of custom resource for test.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
  • UIProcess/API/efl/tests/resources/redirect_uri_to_default.html:

Added to test ewk_view_uri_get when the page is redirected.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp: Ditto.

(onLoadFinishedForRedirection):
(TEST_F): Added new test case whether ewk_view_uri_get returns correct uri when
the page is redirected.

2:00 AM Changeset in webkit [123590] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

[Qt] There are parallel GC related crashes regularly
https://bugs.webkit.org/show_bug.cgi?id=90957

Rubber-stamped by Zoltan Herczeg.

  • wtf/Platform.h: Disable parallel GC temporarily on Qt until proper fix.
1:55 AM EFLWebKit edited by dominik.rottsches@intel.com
harfbuzz dependency (diff)
1:42 AM Changeset in webkit [123589] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Another unreviewed win build fix against r123569.

  • tests/IDBAbortOnCorruptTest.cpp:
1:35 AM Changeset in webkit [123588] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Disable CopyToTexture for GraphicsSurfaceMac.
https://bugs.webkit.org/show_bug.cgi?id=92159

Disable CopyToTexture feature for GraphicsSurface on Mac.
While this is actually working, it is currently used for Tiles
that are single buffered, and therefore requires a call to glFlush.
This call blocks the GPU for about 40ms which would make smooth animations impossible.

Reviewed by Noam Rosenthal.

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):

1:30 AM Changeset in webkit [123587] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[EFL][WK2] Add ewk_main.{cpp,h} to EFL WK2
https://bugs.webkit.org/show_bug.cgi?id=92101

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-25
Reviewed by Kenneth Rohde Christiansen.

Added a centralized place for general initialization in UI process for EFL WK2.

Source/WebKit2:

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_main.cpp: Added.

(ewk_init): General initialization.
(ewk_shutdown): General freeing.
(_ewk_init_body): An aux function.

  • UIProcess/API/efl/ewk_main.h: Added.

Tools:

  • MiniBrowser/efl/main.c: Added using of newly added ewk_init() and ewk_shutdown() functions.

(main):

  • WebKitTestRunner/efl/main.cpp: Ditto.

(main):

1:18 AM Changeset in webkit [123586] by bashi@chromium.org
  • 7 edits in trunk/Source/WebCore

[Chromium] Fix up includes in HarfBuzzNGFace.h
https://bugs.webkit.org/show_bug.cgi?id=92127

Reviewed by Hajime Morita.

Move constructors of FontPlatformData from headers to corresponding cpp files
so that we can use forward declaration for HarfBuzzNGFace instead of including HarfBuzzNGFace.h.
This way we can include hb.h in HarfBuzzNGFace.h.

No new tests. No changes in behavior.

  • platform/graphics/FontPlatformData.cpp:

(WebCore::FontPlatformData::FontPlatformData): Moved from header file.
(WebCore):

  • platform/graphics/FontPlatformData.h:

(WebCore):
(FontPlatformData): Moved to cpp file.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: Include HarfBuzzNGFace.h
  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::FontPlatformData): Moved from header file.
(WebCore):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(WebCore):
(FontPlatformData): Moved to cpp file.

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h: Include hb.h.
1:00 AM Changeset in webkit [123585] by morrita@google.com
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed win build fix against r123569.

  • tests/IDBAbortOnCorruptTest.cpp:
  • tests/IDBDatabaseBackendTest.cpp:
12:42 AM Changeset in webkit [123584] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r123505): Date.getYear() returns the same as Date.getFullYear()
https://bugs.webkit.org/show_bug.cgi?id=92218

Reviewed by Csaba Osztrogonác.

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncGetYear): Added the missing offset of 1900 to the return value.

12:32 AM Changeset in webkit [123583] by zandobersek@gmail.com
  • 2 edits
    1 add
    6 deletes in trunk/LayoutTests

fast/events/panScroll-click-hyperlink.html test should be put in platform/win
https://bugs.webkit.org/show_bug.cgi?id=92111

Reviewed by Daniel Bates.

Move the test into platform/win directory where other pan scrolling tests reside,
and remove other ports' baselines as they just indicated that pan scrolling is not
supported on those platforms. chromium-win and qt-win platforms still pass the test
but should cope with the default baseline just fine.

  • platform/chromium-linux/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/efl/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/gtk/TestExpectations:
  • platform/mac/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/qt/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
  • platform/win/fast/events/panScroll-click-hyperlink.html: Renamed from LayoutTests/fast/events/panScroll-click-hyperlink.html.
12:22 AM Changeset in webkit [123582] by benjamin@webkit.org
  • 7 edits
    1 add in trunk

QualifiedName's HashSet should be big enough to hold at least all the static names
https://bugs.webkit.org/show_bug.cgi?id=91891

Patch by Benjamin Poulain <bpoulain@apple.com> && Joseph Pecoraro <Joseph Pecoraro> on 2012-07-24
Reviewed by Darin Adler.

Source/WebCore:

QualifiedName's table has a standard size of 64 buckets. When initializing WebKit,
we create 850 static QualifiedName for the standard names (HTMLNames, SVGNames etc).

The small base size forces us to grow and rehash the table several time on startup.

This patch solves the issue by defining the initial table size to the minimum size that
can hold all the static QualifiedName.

  • dom/QualifiedName.cpp:

(QualifiedNameHashTraits):

  • dom/make_names.pl:

(printNamesHeaderFile):

Source/WTF:

Add a static struct to compute the HashTable capacity for any given size at compile time.
This allow us to create HashTraits giving the minimumSize without hardcoding the values.

  • wtf/HashTable.h:

(OneifyLowBits):
(UpperPowerOfTwoBound):
(HashTableCapacityForSize): Compute the HashTable capacity at compile time.

Tools:

Add a test for WTF::hashTableCapacityForSize.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/HashSet.cpp: Added.

(InitialCapacityTestHashTraits):
(TestWebKitAPI::testInitialCapacity):
(TestWebKitAPI::generateTestCapacityUpToSize):
(TestWebKitAPI::TEST):

Jul 24, 2012:

11:52 PM Changeset in webkit [123581] by kseo@webkit.org
  • 9 edits in trunk/Source/WebCore

Remove anonymous namespace and make functions static.
https://bugs.webkit.org/show_bug.cgi?id=92214

Reviewed by Adam Barth.

Mark functions as static instead of enclosing them in anonymous namespaces.
One exception to this rule is when a function is passed as a template argument.
In this case, the function must have an external linkage.

No functional change. Covered by existing tests.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::hasImpliedEndTag):
(WebCore::causesFosterParenting):
(WebCore::isAllWhitespace):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore):
(WebCore::tokenizerStateForContextElement):

  • html/parser/HTMLElementStack.cpp:

(WebCore::isNumberedHeaderElement):
(WebCore::isRootNode):
(WebCore):

  • html/parser/HTMLEntityParser.cpp:

(WebCore::isAlphaNumeric):

  • html/parser/HTMLEntitySearch.cpp:

(WebCore::halfway):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::toLowerCase):
(WebCore::vectorEqualsString):
(WebCore::isEndTagBufferingState):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore):
(WebCore::uninitializedPositionValue1):
(WebCore::isAllWhitespace):
(WebCore::isAllWhitespaceOrReplacementCharacters):
(WebCore::isNumberedHeaderTag):
(WebCore::isCaptionColOrColgroupTag):
(WebCore::isTableCellContextTag):
(WebCore::isTableBodyContextTag):
(WebCore::isSpecialNode):
(WebCore::isNonAnchorNonNobrFormattingTag):
(WebCore::isNonAnchorFormattingTag):
(WebCore::isFormattingTag):
(WebCore::closestFormAncestor):
(WebCore::mapLoweredLocalNameToName):
(WebCore::adjustSVGTagNameCase):
(WebCore::adjustAttributes):
(WebCore::adjustSVGAttributes):
(WebCore::adjustMathMLAttributes):
(WebCore::addNamesWithPrefix):
(WebCore::adjustForeignAttributes):

11:40 PM Changeset in webkit [123580] by abarth@webkit.org
  • 3 edits in trunk/Tools

The EWS bots get flaky when we hit the failure limit
https://bugs.webkit.org/show_bug.cgi?id=92212

Reviewed by Eric Seidel.

Previously we were missing some failure types, which means we didn't
notice that the bots were hitting the failure limit.

  • Scripts/webkitpy/common/net/layouttestresults.py:

(LayoutTestResults.failing_test_results):

  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:

(LayoutTestResultsTest.test_results_from_string):
(LayoutTestResultsTest.test_tests_matching_failure_types):

11:01 PM Changeset in webkit [123579] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed r123494 follow-up: fixed inspector undock icon.

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
10:53 PM Changeset in webkit [123578] by yosin@chromium.org
  • 1 edit
    1 copy in trunk/LayoutTests

[Tests] Copy fast/forms/number/number-spinbutton-change-and-input-events.html to fast/forms/js/resources
https://bugs.webkit.org/show_bug.cgi?id=92209

Reviewed by Kent Tamura.

This patch copies test file fast/forms/number/number-spinbutton-change-and-input-events.html
to JavaScript code directory fast/forms/resources as common-spinbutton-change-and-input-events.js
for sharing code with other input types.

This patch is preparation of re-factoring.

  • fast/forms/resources/common-spinbutton-change-and-input-events.js: Copied from LayoutTests/fast/forms/number/number-spinbutton-change-and-input-events.html.
10:47 PM Changeset in webkit [123577] by kseo@webkit.org
  • 8 edits in trunk/Source/WebCore

Read tag names and attributes from the saved tokens where possible.
https://bugs.webkit.org/show_bug.cgi?id=92079

Reviewed by Adam Barth.

Read tag names and attributes from the saved tokens, not from the DOM.
Also added convenient methods such as hasLocalName, hasTagName, localName,
isElementNode and isDocumentFragmentNode to HTMLStackItem class.

No new tests, covered by existing tests.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLNames::hasImpliedEndTag):
(WebCore::HTMLNames::causesFosterParenting):
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
(WebCore::HTMLConstructionSite::generateImpliedEndTags):
(WebCore::HTMLConstructionSite::shouldFosterParent):

  • html/parser/HTMLConstructionSite.h:

(WebCore::HTMLConstructionSite::currentStackItem):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isNumberedHeaderElement):
(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isListItemScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
(WebCore::HTMLNames::isTableBodyScopeMarker):
(WebCore::HTMLNames::isTableRowScopeMarker):
(WebCore::HTMLNames::isForeignContentScopeMarker):
(WebCore::HTMLNames::isButtonScopeMarker):
(WebCore::HTMLNames::isSelectScopeMarker):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
(WebCore::HTMLElementStack::popUntilTableScopeMarker):
(WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
(WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
(WebCore::HTMLElementStack::isMathMLTextIntegrationPoint):
(WebCore::HTMLElementStack::isHTMLIntegrationPoint):
(WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
(WebCore::HTMLElementStack::pushRootNode):
(WebCore::HTMLElementStack::oneBelowTop):
(WebCore::HTMLElementStack::topmost):
(WebCore):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
(WebCore::HTMLElementStack::inScope):

  • html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::topStackItem):
(HTMLElementStack):
(WebCore::isInHTMLNamespace):

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::isDocumentFragmentNode):
(WebCore::HTMLStackItem::isElementNode):
(HTMLStackItem):
(WebCore::HTMLStackItem::hasLocalName):
(WebCore::HTMLStackItem::hasTagName):
(WebCore::HTMLStackItem::HTMLStackItem):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore):
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

  • html/parser/HTMLTreeBuilder.h:
10:28 PM Changeset in webkit [123576] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

  • DEPS:
10:18 PM Changeset in webkit [123575] by yosin@chromium.org
  • 4 edits
    2 moves in trunk/LayoutTests

[Tests] Rename fast/number/number-events.html to number-spinbutton-change-and-input-events.html
https://bugs.webkit.org/show_bug.cgi?id=92208

Reviewed by Kent Tamura.

This patch renames fast/forms/number/number-events.html to number-spinbutton-change-and-input-events.html
to make file name explains what test will be done.

  • fast/forms/number/number-events-expected.txt: Removed.
  • fast/forms/number/number-events.html: Removed.
  • fast/forms/number/number-spinbutton-change-and-input-events-expected.txt: Copied from LayoutTests/fast/forms/number/number-events-expected.txt.
  • fast/forms/number/number-spinbutton-change-and-input-events.html: Copied from LayoutTests/fast/forms/number/number-events.html.
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
10:04 PM Changeset in webkit [123574] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Move renderingStats from WebView to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=92184

Patch by Dave Tu <dtu@chromium.org> on 2012-07-24
Reviewed by Adam Barth.

We are going to add some rendering stats that work in non-composited mode, so the renderingStats() method should be moved from WebView to WebWidget.

  • public/WebView.h:

(WebKit):
(WebView):

  • public/WebWidget.h:

(WebKit):
(WebWidget):
(WebKit::WebWidget::renderingStats):

  • src/WebViewImpl.h:

(WebViewImpl):

10:00 PM Changeset in webkit [123573] by yosin@chromium.org
  • 4 edits
    2 deletes in trunk/LayoutTests

[Tests] Remove duplicated fast/forms/number/number-spinbutton-events.html
https://bugs.webkit.org/show_bug.cgi?id=92205

Reviewed by Kent Tamura.

This patch removes fast/forms/number/number-spinbutton-events.html
because fast/forms/number/number-events.html covers and checked more.

r108955 is an evidence of coverage.

  • fast/forms/number/number-spinbutton-events-expected.txt: Removed.
  • fast/forms/number/number-spinbutton-events.html: Removed.
  • platform/efl/Skipped:
  • platform/qt-arm/TestExpectations:
  • platform/win/Skipped:
9:51 PM Changeset in webkit [123572] by hbono@chromium.org
  • 12 edits
    2 adds in trunk

Avoid moving child objects multiple times when vertical scrollbar are shown at the left side.
https://bugs.webkit.org/show_bug.cgi?id=91756

Reviewed by Tony Chang.

Source/WebCore:

My r123067 moves the top-left origin of an RTL element right when its vertical
scrollbar is shown at its left side. (That is, r123067 moves all child objects
in the RTL element right.) This change also increases RenderBox::clientLeft()
at the same time, i.e. it also moves child objects right. Furthermore, my r109512
moves positioned objects in an RTL element right at the same time. This makes
WebKit move objects in an RTL element up to three times by the scrollbar width.
(Moving an absolute object right increases the scrollWidth value and it causes
this bug.) This change removes unnecessary code that moves objects right in my
r109512 and RenderBox::clientLeft().

Test: scrollbars/rtl/div-absolute.html

fast/block/float/026.html
fast/block/float/028.html
fast/overflow/unreachable-overflow-rtl-bug.html

  • dom/Element.cpp:

(WebCore::Element::clientLeft): Increase clientLeft value by the width of a vertical scrollbar as written in the CSSOM specification.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromPositionedObjects): Removed unnecessary code.
(WebCore::RenderBlock::determineLogicalLeftPositionForChild): Removed unnecessary code.

  • rendering/RenderBox.h:

(WebCore::RenderBox::clientLeft): Removed unnecessary code.

LayoutTests:

This change adds a test that compares CSSOM properties of an RTL element which
includes positioned objects with the CSSOM properties of an LTR one. This change
also uses clientLeft properties in offsetX-offsetY.html to remove a hard-coded
value in the test and adds rebaselined results for Windows.

  • fast/events/offsetX-offsetY.html: Replaced a hard-coded value 'borderLeft' with clientLeft.
  • platform/chromium-linux/fast/block/float/026-expected.png:
  • platform/chromium-linux/fast/block/float/028-expected.png:
  • platform/chromium-win/fast/block/float/026-expected.png:
  • platform/chromium-win/fast/block/float/028-expected.png:
  • platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
  • scrollbars/rtl/div-absolute-expected.txt: Added.
  • scrollbars/rtl/div-absolute.html: Added.
9:42 PM Changeset in webkit [123571] by mitz@apple.com
  • 3 edits
    2 adds in trunk

RenderBlock::positionForPoint can fail when the block or its children have a vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=92202

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/writing-mode/positionForPoint.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPoint): Fixed two issues, each of which are covered by
one of the sub-tests in the new regression test: (1) changed to compare children’s logical
bounds against pointInLogicalContents, i.e. compare childern’s horizontal bounds to the
point’s horizontal component; and (2) changed to use logicalTopForChild and
logicalHeightForChild, which account for this block’s writing mode, instead of logicalTop
and logicalBottom, which are based on the child’s writing mode.

LayoutTests:

  • fast/writing-mode/positionForPoint-expected.txt: Added.
  • fast/writing-mode/positionForPoint.html: Added.
9:13 PM Changeset in webkit [123570] by morrita@google.com
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=89179
Rendering LI having Shadow DOM seems weird

Reviewed by Dimitri Glazkov.

Source/WebCore:

This incorrect rendering happend because HTMLLIElement::attach()
wasn't aware of composed shadow subtree. This change makes it
aware of that using ComposedShadowTreeParentWalker.

Test: fast/dom/shadow/shadow-and-list-elements.html

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

LayoutTests:

  • fast/dom/shadow/shadow-and-list-elements-expected.html: Added.
  • fast/dom/shadow/shadow-and-list-elements.html: Added.
8:25 PM Changeset in webkit [123569] by commit-queue@webkit.org
  • 9 edits in trunk/Source

IndexedDB: fix #include dependencies so IDBRequest isn't an include root
https://bugs.webkit.org/show_bug.cgi?id=92167

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-24
Reviewed by Tony Chang.

Source/WebCore:

Remove implicit dependencies due to using IDBRequest.h, and fix all
places that break as a result.

  • Modules/indexeddb/IDBCallbacks.h:

(WebCore):

  • Modules/indexeddb/IDBObjectStore.cpp:
  • Modules/indexeddb/IDBRequest.h:
  • inspector/InspectorIndexedDBAgent.cpp:

Source/WebKit/chromium:

Remove implicit dependencies due to using IDBRequest.h, and fix all
places that break as a result.

  • src/IDBCallbacksProxy.cpp:
  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBTransactionImpl.cpp:
7:35 PM Changeset in webkit [123568] by keishi@webkit.org
  • 4 edits
    1 add in trunk/Source/WebCore

Move PagePopupClient helper functions so they can be shared
https://bugs.webkit.org/show_bug.cgi?id=92096

Reviewed by Kent Tamura.

Move PagePopupClient helper functions to a separate file,
so they can be shared with new PagePopupClients.

No new tests. Covered by fast/forms/date/calendar-picker-appearance.html

  • WebCore.gypi: Added PagePopupClient.cpp
  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::writeDocument): Modified to use PagePopupClient.

  • page/PagePopupClient.cpp: Added.

(WebCore):
(WebCore::PagePopupClient::addJavaScriptString):
(WebCore::PagePopupClient::addProperty):

  • page/PagePopupClient.h:

(WebCore::PagePopupClient::addString):

7:31 PM Changeset in webkit [123567] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

setting playbackRate on a MediaController doesn't change the playbackRate for slaved media
https://bugs.webkit.org/show_bug.cgi?id=92035

Reviewed by Darin Adler.

Source/WebCore:

Allow updatePlaybackRate() to change the MediaPlayer rate when the media element has a
current media controller.

Test: media/media-controller-playbackrate.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updatePlaybackRate):

LayoutTests:

  • media/media-controller-playbackrate-expected.txt: Added.
  • media/media-controller-playbackrate.html: Added.
7:13 PM Changeset in webkit [123566] by alexis.menard@openbossa.org
  • 25 edits
    3 adds in trunk/LayoutTests

[Qt] svg/as-border-image, svg/as-image, svg/as-object, svg/css rebaseline after new test fonts.
https://bugs.webkit.org/show_bug.cgi?id=92193

Unreviewed gardening.

These tests have been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/qt/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/qt/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/qt/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/qt/svg/as-image/animated-svg-as-image-expected.png: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-expected.txt:
  • platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt:
  • platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt:
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.txt:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
  • platform/qt/svg/as-image/same-image-two-instances-expected.txt:
  • platform/qt/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/qt/svg/as-image/svg-image-change-content-size-expected.txt:
  • platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • platform/qt/svg/css/composite-shadow-text-expected.png:
  • platform/qt/svg/css/composite-shadow-text-expected.txt:
  • platform/qt/svg/css/css-box-min-width-expected.png:
  • platform/qt/svg/css/css-box-min-width-expected.txt:
  • platform/qt/svg/css/text-shadow-multiple-expected.png:
  • platform/qt/svg/css/text-shadow-multiple-expected.txt:
7:08 PM Changeset in webkit [123565] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

Rename FocusScope to FocusNavigationScope.
https://bugs.webkit.org/show_bug.cgi?id=92062

Reviewed by Dimitri Glazkov.

FocusNavagationScope is better name than FocusScope since the
class is only used for controlling focus navigation.

No new tests - no functional changes.

  • page/FocusController.cpp:

(WebCore::FocusNavigationScope::FocusNavigationScope):
(WebCore::FocusNavigationScope::rootNode):
(WebCore::FocusNavigationScope::owner):
(WebCore::FocusNavigationScope::focusNavigationScopeOf):
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByShadowHost):
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByIFrame):
(WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableNodeAcrossFocusScope):
(WebCore::FocusController::findFocusableNodeRecursively):
(WebCore::FocusController::findFocusableNode):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

  • page/FocusController.h:

(FocusNavigationScope):
(FocusController):

6:57 PM Changeset in webkit [123564] by caio.oliveira@openbossa.org
  • 220 edits
    7 deletes in trunk/LayoutTests

[Qt] css2.1/t080* rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92191

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Removed.
  • platform/qt/css2.1/t0801-c412-hz-box-00-b-a-expected.png:
  • platform/qt/css2.1/t0801-c412-hz-box-00-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-00-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-01-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-01-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-02-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-02-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-03-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-03-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-04-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-04-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-05-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-05-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-06-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-06-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-03-c-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-03-c-expected.txt:
  • platform/qt/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-00-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-01-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-01-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-03-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-03-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-04-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-04-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-05-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-05-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-06-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-06-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.png:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.txt:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-02-c-expected.png:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-02-c-expected.txt:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-03-c-expected.png:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-03-c-expected.txt:
  • platform/qt/css2.1/t0803-c5505-imrgn-00-a-ag-expected.png:
  • platform/qt/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-01-e-a-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-01-e-a-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-02-c-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-02-c-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-03-c-ag-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-03-c-ag-expected.txt:
  • platform/qt/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/qt/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-00-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-00-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-01-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-01-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-02-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-02-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5506-padn-t-00-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-01-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-01-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-02-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-02-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-03-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-03-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-04-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-04-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-01-c-a-expected.png:
  • platform/qt/css2.1/t0804-c5507-padn-r-01-c-a-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-02-f-expected.png:
  • platform/qt/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-03-f-expected.png:
  • platform/qt/css2.1/t0804-c5507-padn-r-03-f-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-00-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-00-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-01-f-a-expected.png:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-01-f-a-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-01-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-01-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-03-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-03-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-04-f-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-04-f-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-01-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5509-padn-l-01-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-02-f-expected.png:
  • platform/qt/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
  • platform/qt/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/qt/css2.1/t0804-c5510-ipadn-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5510-ipadn-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5510-padn-01-e-a-expected.png:
  • platform/qt/css2.1/t0804-c5510-padn-01-e-a-expected.txt:
  • platform/qt/css2.1/t0804-c5510-padn-02-f-expected.png:
  • platform/qt/css2.1/t0804-c5510-padn-02-f-expected.txt:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-03-b-expected.png:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-03-b-expected.txt:
  • platform/qt/css2.1/t0805-c5511-ibrdr-tw-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5511-ibrdr-tw-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-03-b-expected.png:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-03-b-expected.txt:
  • platform/qt/css2.1/t0805-c5512-ibrdr-rw-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5512-ibrdr-rw-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-03-b-expected.png:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-03-b-expected.txt:
  • platform/qt/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-03-b-expected.png:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-03-b-expected.txt:
  • platform/qt/css2.1/t0805-c5514-ibrdr-lw-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5514-ibrdr-lw-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5515-brdr-w-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5515-brdr-w-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5515-brdr-w-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5515-brdr-w-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5515-brdr-w-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5515-brdr-w-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5515-ibrdr-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5515-ibrdr-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5516-brdr-c-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5516-brdr-c-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5516-ibrdr-c-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5516-ibrdr-c-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/qt/css2.1/t0805-c5517-brdr-s-00-c-expected.txt:
  • platform/qt/css2.1/t0805-c5517-ibrdr-s-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5517-ibrdr-s-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5518-brdr-t-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5518-brdr-t-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5518-ibrdr-t-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5518-ibrdr-t-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/qt/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5520-brdr-b-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5520-ibrdr-b-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • platform/qt/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/qt/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5522-brdr-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5522-brdr-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5522-brdr-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5522-brdr-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5522-brdr-02-e-expected.png:
  • platform/qt/css2.1/t0805-c5522-brdr-02-e-expected.txt:
  • platform/qt/css2.1/t0805-c5522-ibrdr-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5522-ibrdr-00-a-expected.txt:
6:45 PM Changeset in webkit [123563] by yosin@chromium.org
  • 5 edits in trunk/LayoutTests

[Tests] Re-factor some tests in fast/forms/number for sharing with other input types
https://bugs.webkit.org/show_bug.cgi?id=92081

Reviewed by Kent Tamura.

This patch moves JavaScript code from test HTML files into JavaScript
files for sharing JavaScript code with other input types.

  • fast/forms/number/number-change-type-on-focus.html: Removed JavaScript code and changed to load JavaScript code from fast/forms/resources/common-change-type-on-focus.js.
  • fast/forms/number/number-losing-renderer-on-click.html: Removed JavaScript code and changed to load JavaScript code from fast/forms/resources/common-losing-renderer-on-click.js.
  • fast/forms/resources/common-change-type-on-focus.js: Remove HTML markup text.
  • fast/forms/resources/common-losing-renderer-on-click.js: Remove HTML markup text.
6:23 PM Changeset in webkit [123562] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL] Unreviewed build fix.

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Include unistd.h

for usleep(3).

6:14 PM Changeset in webkit [123561] by caio.oliveira@openbossa.org
  • 160 edits
    42 adds in trunk/LayoutTests

[Qt] css2.1/t170602* rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92188

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-50-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-50-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-51-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-53-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-55-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-56-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-57-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-58-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-60-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-60-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-61-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-62-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-63-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-66-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-67-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-68-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-69-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-70-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-70-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-72-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-73-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-75-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-76-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-77-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-78-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-79-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-80-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-80-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-81-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-82-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-83-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-86-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-87-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-88-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-89-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-90-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-90-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-91-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-91-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-92-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-92-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-93-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-93-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-94-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-94-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-95-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-96-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-97-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-98-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-99-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-99-d-expected.txt:
6:11 PM Changeset in webkit [123560] by msaboff@apple.com
  • 12 edits in trunk/Source

Convert HTML parser to handle 8-bit resources without converting to UChar*
https://bugs.webkit.org/show_bug.cgi?id=90321

Reviewed by Geoffrey Garen.

Source/WebCore:

No new tests, no new functionality therefore covered by existing tests.

Changed the parsing of HTML to handle 8-bit strings without converting the
whole string to 16-bits. Primary change was to use the appropriate
character pointer type (LChar* or UChar*) depending on the source string.
This access is abstracted in SegmentedSubstring by getCurrentChar{8,16} and
incrementAndGetCurrentChar{8,16} methods. In SegmentedString, the advance()
and advanceAndUpdateLineNumber() methods have been refactored into a
state machine managed pair of function pointers. The possible functions
have not only the 8 and 16 bitness factored out, they also have the
"exclude line numbers" logic factored out for advanceAndUpdateLineNumber().
This provides a net speed-up even with the 8/16 bit testing.
Other changes involve using String methods to access and compare with the
source data.

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::append): Changed to use currentChar()
instead of SegmentedString '*' operator.

  • html/parser/HTMLEntityParser.cpp: Changed to use currentChar() instead of

SegmentedString '*' operator.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces): Added 8-bit fast path.

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken): Changed to use currentChar() instead of
SegmentedString '*' operator.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script): Updated to use new String::dataSize() method.

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance): Changed to be a wrapper that invokes current
advance function.
(WebCore::SegmentedString::advance8): Fast path advance function for 8 bit data.
(WebCore::SegmentedString::advance16): Fast path advance function for 16 bit data.
(WebCore::SegmentedString::advanceAndUpdateLineNumber8IncludeLineNumbers): Fast
path advanceAndUpdateLineNumber for 8 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceAndUpdateLineNumber16IncludeLineNumbers): Fast
path advanceAndUpdateLineNumber for 16 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceSlowCase): Slow case advance function for both
8 and 16 bit advance.
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase): Slow case
advanceAndUpdateLineNumber function for both 8 and 16 bit data.
(WebCore::SegmentedString::advanceEmpty): Advance function when input has been exhausted.

  • platform/text/SegmentedString.h:

(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(SegmentedSubstring):
(WebCore::SegmentedSubstring::is8Bit): New getter.
(WebCore::SegmentedSubstring::appendTo):
(WebCore::SegmentedSubstring::getCurrentChar8): New getter for the 8 bit case.
(WebCore::SegmentedSubstring::getCurrentChar16): New getter for the 16 bit case.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar8): New wrapper functions
that pre-increments the 8 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar16): New wrapper functions
that pre-increments the 16 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::currentSubString):
(WebCore::SegmentedSubstring::getCurrentChar):
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(WebCore::SegmentedString::currentChar):
(WebCore::SegmentedString::setSlowCase): Set advance function pointers to slow case
functions.
(WebCore::SegmentedString::decrementAndCheckLength): Decrement substring length and
change to slow case functions when only one character left.
(WebCore::SegmentedString::setAdvanceFunctionPointers): Select appropriate advance
functions based on current substring.
(WebCore::SegmentedString::lookAheadInline): Changed to use String::startsWith().
(WebCore::SegmentedString::lookAheadSlowCase):

  • xml/parser/CharacterReferenceParserInlineMethods.h:

(WebCore::consumeCharacterReference): Changed to use currentChar() instead of
SegmentedString '*' operator.

  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek): Changed to use
currentChar() instead of SegmentedString '*' operator.
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):

Source/WTF:

  • wtf/text/WTFString.h:

(WTF::String::dataSize): New method to return the number of bytes
the string requires. This replaces a harcoded calculation based on
length and sizeof(UChar).

6:07 PM Changeset in webkit [123559] by weinig@apple.com
  • 2 edits in trunk/Source/WTF

Add per-HashTable stats
https://bugs.webkit.org/show_bug.cgi?id=92185

Reviewed by Anders Carlsson.

Add per-HashTable stats, so we can look at the effectiveness of an individual HashTable.

  • wtf/HashTable.h:

(WTF::HashTable::Stats::Stats):
Add a HashTable::Stats to hold the stats.

(WTF::HashTable::Stats::recordCollisionAtCount):
(WTF::HashTable::Stats::dumpStats):
Add versions of recordCollisionAtCount and dumpStats for per-HashTable version.

(WTF::HashTable):
Keep the stats, if enabled, in an OwnPtr, to not blow JSCell max size restrictions.

(WTF::lookup):
(WTF::lookupForWriting):
(WTF::fullLookupForWriting):
(WTF::add):
(WTF::reinsert):
(WTF::remove):
(WTF::rehash):
Keep track of the stats as the table is used.

5:48 PM Changeset in webkit [123558] by zmo@google.com
  • 1 edit
    55 adds in trunk/LayoutTests

Gardening stuff, rebaseline.

Unreviewed.

  • platform/chromium-mac/fast/hidpi: Added.
  • platform/chromium-mac/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-as-background-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-border-image-simple-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-out-of-order-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-simple-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-without-specified-width-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/resize-corner-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi: Added.
  • platform/chromium-win/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/chromium-win/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-as-background-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-as-background-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-without-size-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-comparison-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-simple-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-simple-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-out-of-order-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-out-of-order-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-simple-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-simple-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-without-specified-width-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-without-specified-width-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/resize-corner-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
5:46 PM Changeset in webkit [123557] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WKContextGetGlobalStatistics() assigns wrong value to wkFrameCount in WKContextStatistics
https://bugs.webkit.org/show_bug.cgi?id=92173

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-07-24
Reviewed by John Sullivan.

In WKContextGetGlobalStatistics(), wkViewCount in WebContext::Statistics
is assigned to wkFrameCount in WKContextStatistics.
wkFrameCount in WebContext:Statistics should be assigned to wkFrameCount in WKContextStatistics.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetGlobalStatistics):

5:37 PM Changeset in webkit [123556] by kbr@google.com
  • 7 edits
    2 adds in trunk

[chromium] Hint garbage collector to run if page uses Canvas contexts
https://bugs.webkit.org/show_bug.cgi?id=76225

Reviewed by Kentaro Hara.

Source/WebCore:

Upon creating a canvas context, set a hint in the current isolate
indicating that a full GC should be done upon the next page
navigation.

This improves Chrome's robustness on some WebGL stress tests which
simulate real-world behavior by repeatedly navigating among
several samples. More general measures are being investigated, but
this change makes V8 behave the same as JSC on these stress tests.
JSC doesn't currently use generational garbage collection, so it
has more opportunities to discover unreferenced canvas contexts.

Test: fast/canvas/webgl/context-creation-and-destruction.html

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):

Initialize per-isolate low memory hint.

  • bindings/v8/V8Binding.h:

(V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::setLowMemoryNotificationHint):

Set a per-isolate hint to signal a low memory condition upon the next page navigation.

(WebCore::V8BindingPerIsolateData::clearLowMemoryNotificationHint):

Clear the previously set hint.

(WebCore::V8BindingPerIsolateData::isLowMemoryNotificationHint):

Get the previously set hint.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::hintForGCIfNecessary):

If necessary, send V8 a hint that it should GC.

(WebCore):
(WebCore::V8Proxy::clearForClose):
(WebCore::V8Proxy::clearForNavigation):

Call hintForGCIfNecessary.

  • bindings/v8/V8Proxy.h:

(V8Proxy):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

Set a hint that we should GC upon the next page navigation.

LayoutTests:

This test doesn't directly exercise this code path yet, but it
needs to work regardless and also needs to be expanded.

  • fast/canvas/webgl/context-creation-and-destruction-expected.txt: Added.
  • fast/canvas/webgl/context-creation-and-destruction.html: Added.
5:28 PM Changeset in webkit [123555] by alexis.menard@openbossa.org
  • 18 edits
    3 adds in trunk/LayoutTests

[Qt] svg/as-background-image rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92180

Unreviewed gardening.

These tests have been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/as-background-image/animated-svg-as-background-expected.png: Added.
  • platform/qt/svg/as-background-image/animated-svg-as-background-expected.txt:
  • platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-1-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-2-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-3-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-4-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-as-background-4-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-5-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-as-background-5-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-6-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-with-viewBox-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-tiled-background-expected.txt:
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.txt:
  • platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.txt:
5:27 PM Changeset in webkit [123554] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Support scrolling and zooming to focused input elements
https://bugs.webkit.org/show_bug.cgi?id=91661

Reviewed by Darin Fisher.

This patch introduces saveScrollAndScaleState and
restoreScrollAndScaleState, which can be used to save and restore the
scroll and scale state of the WebView, respectively. These functions
will be used by Chromium on Android to save the scale and scrolls state
before zoom into a text field so that we can "undo" the zoom if the
user didn't mean to zoom into the text field.

I wanted to write unit tests for these functions, but it wasn't clear
to me how to write the test because startPageScaleAnimation appears to
complete asynchronously.

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::saveScrollAndScaleState):
(WebKit):
(WebKit::WebViewImpl::restoreScrollAndScaleState):
(WebKit::WebViewImpl::resetSavedScrollAndScaleState):
(WebKit::WebViewImpl::didCommitLoad):

  • src/WebViewImpl.h:

(WebViewImpl):

5:25 PM Changeset in webkit [123553] by commit-queue@webkit.org
  • 34 edits in trunk/Source

[chromium] Add time spent painting to GPU benchmarking renderingStats() API.
https://bugs.webkit.org/show_bug.cgi?id=90019

Patch by Dave Tu <dtu@chromium.org> on 2012-07-24
Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebRenderingStats.h:

(WebRenderingStats):
(WebKit::WebRenderingStats::WebRenderingStats):

Source/WebCore:

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::paintContentsRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(BitmapSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:

(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:

(CanvasLayerTextureUpdater):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::update):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::update):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(WebCore::LayerChromium::update):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore):
(WebCore::LayerTextureUpdater::Texture::prepareRect):
(WebCore::LayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::updatePart):
(WebCore::ScrollbarLayerChromium::update):

  • platform/graphics/chromium/ScrollbarLayerChromium.h:

(ScrollbarLayerChromium):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:

(SkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::updateContentRect):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::updateAnimations):
(WebCore::CCLayerTreeHost::renderingStats):
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCRenderingStats.h:

(CCRenderingStats):
(WebCore::CCRenderingStats::CCRenderingStats):

Source/WebKit/chromium:

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::renderingStats):

  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::Texture::prepareRect):
(WebKitTests::FakeTiledLayerChromium::update):

  • tests/CCTiledLayerTestCommon.h:

(Texture):
(FakeTiledLayerChromium):

  • tests/Canvas2DLayerBridgeTest.cpp:
  • tests/ContentLayerChromiumTest.cpp:

(WebKit::TEST):

  • tests/TiledLayerChromiumTest.cpp:
5:16 PM Changeset in webkit [123552] by caio.oliveira@openbossa.org
  • 131 edits
    41 copies
    8 adds in trunk/LayoutTests

[Qt] fast/block/positioning rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92174

Unreviewed.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/fast/block/positioning/003-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/004-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/005-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/006-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/007-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/008-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/009-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/010-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/011-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/012-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/013-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/014-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/015-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/016-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/017-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/018-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/019-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/020-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/021-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/022-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/023-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/024-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/025-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/026-expected.png: Added.
  • platform/qt/fast/block/positioning/027-expected.png: Added.
  • platform/qt/fast/block/positioning/028-expected.png: Added.
  • platform/qt/fast/block/positioning/029-expected.png: Added.
  • platform/qt/fast/block/positioning/030-expected.png: Added.
  • platform/qt/fast/block/positioning/031-expected.png: Added.
  • platform/qt/fast/block/positioning/032-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/033-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/034-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/035-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/036-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/037-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/038-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/039-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/040-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/041-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/042-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/043-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/044-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/045-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/046-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/047-expected.png:
  • platform/qt/fast/block/positioning/047-expected.txt:
  • platform/qt/fast/block/positioning/048-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/050-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/052-expected.txt:
  • platform/qt/fast/block/positioning/053-expected.png:
  • platform/qt/fast/block/positioning/053-expected.txt:
  • platform/qt/fast/block/positioning/054-expected.txt:
  • platform/qt/fast/block/positioning/055-expected.png:
  • platform/qt/fast/block/positioning/055-expected.txt:
  • platform/qt/fast/block/positioning/057-expected.png:
  • platform/qt/fast/block/positioning/057-expected.txt:
  • platform/qt/fast/block/positioning/058-expected.png:
  • platform/qt/fast/block/positioning/058-expected.txt:
  • platform/qt/fast/block/positioning/059-expected.png:
  • platform/qt/fast/block/positioning/059-expected.txt:
  • platform/qt/fast/block/positioning/060-expected.png:
  • platform/qt/fast/block/positioning/060-expected.txt:
  • platform/qt/fast/block/positioning/061-expected.txt:
  • platform/qt/fast/block/positioning/062-expected.png: Added.
  • platform/qt/fast/block/positioning/abs-inside-inline-rel-expected.png:
  • platform/qt/fast/block/positioning/abs-inside-inline-rel-expected.txt:
  • platform/qt/fast/block/positioning/absolute-in-inline-ltr-3-expected.png:
  • platform/qt/fast/block/positioning/absolute-in-inline-ltr-3-expected.txt:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-ltr-expected.png:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-ltr-expected.txt:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-rtl-expected.png:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
  • platform/qt/fast/block/positioning/absolute-length-of-neg-666666-expected.png:
  • platform/qt/fast/block/positioning/absolute-length-of-neg-666666-expected.txt:
  • platform/qt/fast/block/positioning/absolute-position-direction-expected.png:
  • platform/qt/fast/block/positioning/absolute-position-direction-expected.txt:
  • platform/qt/fast/block/positioning/absolute-positioned-overconstrained-expected.png:
  • platform/qt/fast/block/positioning/absolute-positioned-overconstrained-expected.txt:
  • platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Added.
  • platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt:
  • platform/qt/fast/block/positioning/absolute-with-html-border-quirks-expected.png:
  • platform/qt/fast/block/positioning/absolute-with-html-border-quirks-expected.txt:
  • platform/qt/fast/block/positioning/absolute-with-html-border-strict-expected.png:
  • platform/qt/fast/block/positioning/absolute-with-html-border-strict-expected.txt:
  • platform/qt/fast/block/positioning/auto-height-with-top-and-bottom-expected.png:
  • platform/qt/fast/block/positioning/auto-height-with-top-and-bottom-expected.txt:
  • platform/qt/fast/block/positioning/auto/001-expected.png:
  • platform/qt/fast/block/positioning/auto/001-expected.txt:
  • platform/qt/fast/block/positioning/auto/002-expected.png:
  • platform/qt/fast/block/positioning/auto/002-expected.txt:
  • platform/qt/fast/block/positioning/auto/003-expected.png:
  • platform/qt/fast/block/positioning/auto/003-expected.txt:
  • platform/qt/fast/block/positioning/auto/004-expected.png:
  • platform/qt/fast/block/positioning/auto/004-expected.txt:
  • platform/qt/fast/block/positioning/auto/005-expected.png:
  • platform/qt/fast/block/positioning/auto/005-expected.txt:
  • platform/qt/fast/block/positioning/auto/006-expected.png:
  • platform/qt/fast/block/positioning/auto/006-expected.txt:
  • platform/qt/fast/block/positioning/auto/007-expected.png:
  • platform/qt/fast/block/positioning/auto/007-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/001-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/001-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/002-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/002-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/003-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/003-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/004-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/004-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/006-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/006-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/007-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/001-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/001-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/002-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/002-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/003-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/003-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/004-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/004-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/006-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/006-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/007-expected.txt:
  • platform/qt/fast/block/positioning/child-of-absolute-with-auto-height-expected.png:
  • platform/qt/fast/block/positioning/child-of-absolute-with-auto-height-expected.txt:
  • platform/qt/fast/block/positioning/differing-writing-modes-expected.png:
  • platform/qt/fast/block/positioning/differing-writing-modes-expected.txt:
  • platform/qt/fast/block/positioning/differing-writing-modes-replaced-expected.png:
  • platform/qt/fast/block/positioning/differing-writing-modes-replaced-expected.txt:
  • platform/qt/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png:
  • platform/qt/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
  • platform/qt/fast/block/positioning/height-change-expected.png:
  • platform/qt/fast/block/positioning/height-change-expected.txt:
  • platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png:
  • platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt:
  • platform/qt/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/qt/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/qt/fast/block/positioning/leftmargin-topmargin-expected.png:
  • platform/qt/fast/block/positioning/leftmargin-topmargin-expected.txt:
  • platform/qt/fast/block/positioning/negative-right-pos-expected.png:
  • platform/qt/fast/block/positioning/negative-right-pos-expected.txt:
  • platform/qt/fast/block/positioning/padding-percent-expected.png:
  • platform/qt/fast/block/positioning/padding-percent-expected.txt:
  • platform/qt/fast/block/positioning/pref-width-change-expected.txt:
  • platform/qt/fast/block/positioning/relative-overconstrained-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/relative-overflow-block-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-block-expected.txt:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-expected.txt:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.txt:
  • platform/qt/fast/block/positioning/relayout-on-position-change-expected.png:
  • platform/qt/fast/block/positioning/relayout-on-position-change-expected.txt:
  • platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/qt/fast/block/positioning/rtl-fixed-positioning-expected.png:
  • platform/qt/fast/block/positioning/rtl-static-positioning-expected.png:
  • platform/qt/fast/block/positioning/rtl-static-positioning-expected.txt:
  • platform/qt/fast/block/positioning/rtl-static-positioning-inline-block-expected.png:
  • platform/qt/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt:
  • platform/qt/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png:
  • platform/qt/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt:
  • platform/qt/fast/block/positioning/table-cell-static-position-expected.png:
  • platform/qt/fast/block/positioning/table-cell-static-position-expected.txt:
  • platform/qt/fast/block/positioning/trailing-space-test-expected.png:
  • platform/qt/fast/block/positioning/trailing-space-test-expected.txt:
  • platform/qt/fast/block/positioning/vertical-lr/001-expected.png:
  • platform/qt/fast/block/positioning/vertical-lr/001-expected.txt:
  • platform/qt/fast/block/positioning/vertical-rl/001-expected.png:
  • platform/qt/fast/block/positioning/vertical-rl/001-expected.txt:
  • platform/qt/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
  • platform/qt/fast/block/positioning/window-height-change-expected.png:
  • platform/qt/fast/block/positioning/window-height-change-expected.txt:
4:58 PM Changeset in webkit [123551] by commit-queue@webkit.org
  • 130 edits
    1 add in trunk/LayoutTests

[Qt] fast/block/float needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92150

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-24
Reviewed by Alexis Menard.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/fast/block/float/001-expected.txt:
  • platform/qt/fast/block/float/002-expected.png:
  • platform/qt/fast/block/float/002-expected.txt:
  • platform/qt/fast/block/float/003-expected.png:
  • platform/qt/fast/block/float/003-expected.txt:
  • platform/qt/fast/block/float/004-expected.png:
  • platform/qt/fast/block/float/004-expected.txt:
  • platform/qt/fast/block/float/005-expected.png:
  • platform/qt/fast/block/float/005-expected.txt:
  • platform/qt/fast/block/float/006-expected.png:
  • platform/qt/fast/block/float/006-expected.txt:
  • platform/qt/fast/block/float/007-expected.png:
  • platform/qt/fast/block/float/007-expected.txt:
  • platform/qt/fast/block/float/010-expected.png:
  • platform/qt/fast/block/float/010-expected.txt:
  • platform/qt/fast/block/float/011-expected.png:
  • platform/qt/fast/block/float/011-expected.txt:
  • platform/qt/fast/block/float/012-expected.png:
  • platform/qt/fast/block/float/012-expected.txt:
  • platform/qt/fast/block/float/013-expected.png:
  • platform/qt/fast/block/float/013-expected.txt:
  • platform/qt/fast/block/float/014-expected.png:
  • platform/qt/fast/block/float/014-expected.txt:
  • platform/qt/fast/block/float/015-expected.png:
  • platform/qt/fast/block/float/015-expected.txt:
  • platform/qt/fast/block/float/016-expected.png:
  • platform/qt/fast/block/float/016-expected.txt:
  • platform/qt/fast/block/float/017-expected.png:
  • platform/qt/fast/block/float/017-expected.txt:
  • platform/qt/fast/block/float/018-expected.png:
  • platform/qt/fast/block/float/018-expected.txt:
  • platform/qt/fast/block/float/020-expected.png:
  • platform/qt/fast/block/float/020-expected.txt:
  • platform/qt/fast/block/float/021-expected.png:
  • platform/qt/fast/block/float/021-expected.txt:
  • platform/qt/fast/block/float/022-expected.png:
  • platform/qt/fast/block/float/022-expected.txt:
  • platform/qt/fast/block/float/023-expected.png:
  • platform/qt/fast/block/float/023-expected.txt:
  • platform/qt/fast/block/float/024-expected.png:
  • platform/qt/fast/block/float/024-expected.txt:
  • platform/qt/fast/block/float/025-expected.png:
  • platform/qt/fast/block/float/025-expected.txt:
  • platform/qt/fast/block/float/027-expected.png:
  • platform/qt/fast/block/float/027-expected.txt:
  • platform/qt/fast/block/float/029-expected.png:
  • platform/qt/fast/block/float/029-expected.txt:
  • platform/qt/fast/block/float/030-expected.png:
  • platform/qt/fast/block/float/030-expected.txt:
  • platform/qt/fast/block/float/031-expected.png:
  • platform/qt/fast/block/float/031-expected.txt:
  • platform/qt/fast/block/float/032-expected.png:
  • platform/qt/fast/block/float/032-expected.txt:
  • platform/qt/fast/block/float/avoidance-percent-width-compat-expected.png: Added.
  • platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt:
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.png:
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
  • platform/qt/fast/block/float/avoiding-float-centered-expected.png:
  • platform/qt/fast/block/float/avoiding-float-centered-expected.txt:
  • platform/qt/fast/block/float/br-with-clear-expected.txt:
  • platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.png:
  • platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.txt:
  • platform/qt/fast/block/float/clamped-right-float-expected.png:
  • platform/qt/fast/block/float/clamped-right-float-expected.txt:
  • platform/qt/fast/block/float/clear-element-too-wide-for-containing-block-expected.png:
  • platform/qt/fast/block/float/clear-element-too-wide-for-containing-block-expected.txt:
  • platform/qt/fast/block/float/dynamic-unfloat-pref-width-expected.png:
  • platform/qt/fast/block/float/dynamic-unfloat-pref-width-expected.txt:
  • platform/qt/fast/block/float/editable-text-overlapping-float-expected.png:
  • platform/qt/fast/block/float/editable-text-overlapping-float-expected.txt:
  • platform/qt/fast/block/float/fit_line_below_floats-expected.png:
  • platform/qt/fast/block/float/fit_line_below_floats-expected.txt:
  • platform/qt/fast/block/float/float-avoidance-expected.png:
  • platform/qt/fast/block/float/float-avoidance-expected.txt:
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.png:
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/qt/fast/block/float/float-in-float-painting-expected.png:
  • platform/qt/fast/block/float/float-in-float-painting-expected.txt:
  • platform/qt/fast/block/float/floats-and-text-indent-expected.png:
  • platform/qt/fast/block/float/floats-and-text-indent-expected.txt:
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.png:
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.txt:
  • platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt:
  • platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt:
  • platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt:
  • platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt:
  • platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt:
  • platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt:
  • platform/qt/fast/block/float/intruding-painted-twice-expected.png:
  • platform/qt/fast/block/float/intruding-painted-twice-expected.txt:
  • platform/qt/fast/block/float/marquee-shrink-to-avoid-floats-expected.png:
  • platform/qt/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
  • platform/qt/fast/block/float/multiple-float-positioning-expected.png:
  • platform/qt/fast/block/float/multiple-float-positioning-expected.txt:
  • platform/qt/fast/block/float/nested-clearance-expected.png:
  • platform/qt/fast/block/float/nested-clearance-expected.txt:
  • platform/qt/fast/block/float/nestedAnonymousBlocks-expected.png:
  • platform/qt/fast/block/float/nestedAnonymousBlocks-expected.txt:
  • platform/qt/fast/block/float/nestedAnonymousBlocks2-expected.png:
  • platform/qt/fast/block/float/nestedAnonymousBlocks2-expected.txt:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction-expected.png:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction-expected.txt:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction2-expected.png:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction2-expected.txt:
  • platform/qt/fast/block/float/overhanging-after-height-decrease-expected.png:
  • platform/qt/fast/block/float/overhanging-after-height-decrease-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png:
  • platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png:
  • platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.png:
  • platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/qt/fast/block/float/shrink-to-fit-width-expected.png:
  • platform/qt/fast/block/float/shrink-to-fit-width-expected.txt:
  • platform/qt/fast/block/float/table-relayout-expected.png:
  • platform/qt/fast/block/float/table-relayout-expected.txt:
  • platform/qt/fast/block/float/vertical-move-relayout-expected.png:
  • platform/qt/fast/block/float/vertical-move-relayout-expected.txt:
  • platform/qt/fast/block/float/width-update-after-clear-expected.png:
  • platform/qt/fast/block/float/width-update-after-clear-expected.txt:
4:51 PM Changeset in webkit [123550] by jianli@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Correct WebIDL type should be used in the testing IDL file
https://bugs.webkit.org/show_bug.cgi?id=92168

Reviewed by Kentaro Hara.

Updated bindings test.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_strict_function):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionStrictFunction):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):

4:38 PM Changeset in webkit [123549] by tkent@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp

Merge 123187 - [Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
https://bugs.webkit.org/show_bug.cgi?id=91824

Reviewed by Hajime Morita.

No new tests. This code is used only in Chromium browser.

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::hostInput):
Use shadowHost(), and allow to return 0.
(WebCore::TextFieldDecorationElement::defaultEventHandler):
Check 0.

TBR=tkent@chromium.org
BUG=crbug.com/136145
Review URL: https://chromiumcodereview.appspot.com/10809092

4:34 PM Changeset in webkit [123548] by tkent@chromium.org
  • 3 edits in branches/chromium/1180/Source/WebCore

Merge 123180 - Introduce Node::shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=91814

Reviewed by Hajime Morita.

Introduce Node::shadowHost(), which return the host element, or 0.
Node::shadowAncestorNode() is used to obtain a shadow host. However it
is confusing because it returns 'this' if this is not in a shadow tree.

Replaces one callsite of shadowAncestorNode() with shadowHost().

No behavior change.

  • dom/Node.cpp:

(WebCore::Node::shadowHost): Added.

  • dom/Node.h:

(Node): Declare shadowHost(), and add a comment to shadowAncestorNode().

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::hostInput):
Replace shadowAncestorNode() with shaodwHost().

TBR=tkent@chromium.org
BUG=crbug.com/136145
Review URL: https://chromiumcodereview.appspot.com/10823003

4:12 PM Changeset in webkit [123547] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r123191.
http://trac.webkit.org/changeset/123191
https://bugs.webkit.org/show_bug.cgi?id=91804

It might cause another performance regression.
http://code.google.com/p/chromium/issues/detail?id=138410

  • html/FormController.cpp:

(FormKeyGenerator):
(WebCore::createKey):
(WebCore::FormKeyGenerator::formKey):
(WebCore::FormKeyGenerator::willDeleteForm):

3:55 PM Changeset in webkit [123546] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

[JSBinding] Merging jsUnsignedLongArrayToVector() to toNativeArray() using traits.
https://bugs.webkit.org/show_bug.cgi?id=90381

Patch by Vineet Chaudhary <Vineet> on 2012-07-24
Reviewed by Kentaro Hara.

We can remove jsUnsignedLongArrayToVector() implementaion
merging it to current and toNativeArray() traits.

Tests: TestObj.idl
There should be no behavoiral changes as just refactoring.

  • Modules/vibration/NavigatorVibration.idl: Use sequence<T> as method param than T[]
  • bindings/js/JSDOMBinding.cpp: Moved toJSSequence() to header file.
  • bindings/js/JSDOMBinding.h:

(WebCore::toJSSequence): Moved toJSSequence() to header file.
(WebCore::jsArray): Renamed Traits to JSValueTraits
(WebCore::toNativeArray): Using traits.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::fillMessagePortArray):

  • bindings/scripts/CodeGeneratorJS.pm: Removed unsigned long[] specific binding code.

(AddIncludesForType):
(GenerateParametersCheckExpression):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheckExpression): Added check sequence<T> check for overloaded methods.

  • bindings/scripts/test/JS/JSTestObj.cpp: Rebased binding test.

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod10):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence):

  • bindings/scripts/test/JS/JSTestObj.h: Rebased binding test.
  • bindings/scripts/test/TestObj.idl: Added test for sequence<T> as method parameter.
  • bindings/scripts/test/V8/V8TestObj.cpp: Rebased binding test.

(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::overloadedMethodCallback):

3:54 PM Changeset in webkit [123545] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Add unit tests for custom text encoding setting
https://bugs.webkit.org/show_bug.cgi?id=91983

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-24
Reviewed by Dirk Pranke.

Add unit tests for get and set custom text encoding methods. Also, fix
a style nit for r123177.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_setting_encoding_custom_set): Fix a style nit - add newline
before return.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

3:51 PM Changeset in webkit [123544] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

WinCairo build fix attempt.

  • win/WebKit2CFLite.def:
3:34 PM Changeset in webkit [123543] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

Windows build fix attempt.

3:34 PM Changeset in webkit [123542] by kseo@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove an invalid assertion introduced in r123536. Unreviewed.

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):

3:33 PM Changeset in webkit [123541] by zmo@google.com
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r123504.
http://trac.webkit.org/changeset/123504
https://bugs.webkit.org/show_bug.cgi?id=92169

broke a bunch of text-related tests in chromium mac debug
(Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

  • platform/text/cf/StringCF.cpp:

(WTF::String::createCFString):

  • platform/text/cf/StringImplCF.cpp:

(WTF::StringImpl::createCFString):

3:26 PM Changeset in webkit [123540] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change stop ignoring fast/hidpi changes.

  • platform/chromium/TestExpectations:
3:22 PM Changeset in webkit [123539] by simonjam@chromium.org
  • 3 edits
    2 copies in branches/chromium/1180

Merge 123121 - Regression(120096): Protect the element used by ImageLoader until the end of notifyFinished().
https://bugs.webkit.org/show_bug.cgi?id=90471

Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/security/video-poster-cross-origin-crash.html

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::notifyFinished): Hang on to the element until we're done.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::setImage): No behavior change.
(WebCore):
(WebCore::ImageLoader::setImageWithoutConsideringPendingLoadEvent): Split off from old setImage, minus calling updatedHasPendingLoadEvent().
(WebCore::ImageLoader::notifyFinished): Invoke updatedHasPendingLoadEvent when done with cross origin errors.

  • loader/ImageLoader.h:

(ImageLoader):

LayoutTests:

  • http/tests/security/video-poster-cross-origin-crash-expected.txt: Added.
  • http/tests/security/video-poster-cross-origin-crash.html: Added. From fuzzer.

TBR=simonjam@chromium.org

3:20 PM Changeset in webkit [123538] by dpranke@chromium.org
  • 4 edits
    1 copy in trunk/Tools

make test-webkitpy at least kinda work in parallel on win32
https://bugs.webkit.org/show_bug.cgi?id=91700

Reviewed by Adam Barth.

This change makes the hoop-jumping we have to do to make running
new-run-webkit-tests in parallel on win32 generic so that we can
re-use it for test-webkitpy as well.

  • Scripts/new-run-webkit-tests:
  • Scripts/test-webkitpy:
  • Scripts/webkitpy/common/multiprocessing_bootstrap.py: Copied from Tools/Scripts/new-run-webkit-tests.

(run):

  • Scripts/webkitpy/test/main.py:

(main):
(Tester._log_exception):

3:19 PM Changeset in webkit [123537] by kseo@webkit.org
  • 4 edits in trunk/Source/WebCore

Ensure Noah's ark without reading the DOM tree.
https://bugs.webkit.org/show_bug.cgi?id=92065

Reviewed by Adam Barth.

Technically we shouldn't read attributes back from the DOM. If JavaScript changes
the attributes values, we could get a slightly wrong output here.

Read attributes from tokens saved in the active formatting element list.

No new tests, covered by existing tests.

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::attributeCount):
(WebCore::HTMLFormattingElementList::append):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):

  • html/parser/HTMLFormattingElementList.h:

(HTMLFormattingElementList):

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::localName):
(HTMLStackItem):

3:12 PM Changeset in webkit [123536] by kseo@webkit.org
  • 3 edits in trunk/Source/WebCore

Clear the external characters pointer of an AtomicHTMLToken before the raw token is cleared.
https://bugs.webkit.org/show_bug.cgi?id=92056

Reviewed by Adam Barth.

AtomicHTMLToken keeps a pointer to the HTMLToken's buffer instead of copying the
characters for performance. Clear the external characters pointer before the raw token
is cleared to make sure that we won't have a dangling pointer.

No new tests - no functional changes.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::constructTreeFromToken):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):
(AtomicMarkupTokenBase):

3:08 PM Changeset in webkit [123535] by jianli@chromium.org
  • 12 edits in trunk/Source

Add per-context setting for html notifications
https://bugs.webkit.org/show_bug.cgi?id=91295

Reviewed by Adam Barth.

Source/WebCore:

Added a new per-context setting to control the enabling of html notifications.
For chromium port, we're going to disable html notifications for web
pages, but still keep it enabled for extensions.

Also enhance V8 code generator to support V8EnabledPerContext attribute
for methods.

Updated the binding tests.

  • Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::document): Expose document for being used by installPerContextProperties.
(WebCore):

  • Modules/notifications/NotificationCenter.h:

(NotificationCenter):

  • Modules/notifications/NotificationCenter.idl: Add V8EnabledPerContext attribute.
  • bindings/scripts/CodeGeneratorV8.pm: V8EnabledPerContext now supports methods.

(GenerateHeader):
(IsStandardFunction):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateToV8Converters):
(GetContextEnableFunction):

  • bindings/scripts/test/TestObj.idl: Add test case for V8EnabledPerContext methods.
  • bindings/scripts/test/V8/V8TestObj.cpp: Update test result.

(WebCore::TestObjV8Internal::enabledAtContextMethod1Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::enabledAtContextMethod2Callback):
(WebCore::V8TestObj::installPerContextProperties):
(WebCore::V8TestObj::wrapSlow):

  • dom/ContextFeatures.cpp: Add a new per-context feature.

(WebCore::ContextFeatures::htmlNotificationsEnabled):
(WebCore):

  • dom/ContextFeatures.h: Add a new per-context feature.

Source/WebKit/chromium:

Add new per-context feature for chromium port.

  • public/WebPermissionClient.h:

(WebPermissionClient):
(WebKit::WebPermissionClient::allowHTMLNotifications):

  • src/ContextFeaturesClientImpl.cpp:

(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

3:07 PM Changeset in webkit [123534] by inferno@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp

Revert 123529 - Merge 123187 - [Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
https://bugs.webkit.org/show_bug.cgi?id=91824
BUG=136145
Review URL: https://chromiumcodereview.appspot.com/10818041

TBR=inferno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10819007

3:07 PM Changeset in webkit [123533] by zmo@google.com
  • 23 edits
    5 deletes in trunk

Unreviewed, rolling out r123499.
http://trac.webkit.org/changeset/123499
https://bugs.webkit.org/show_bug.cgi?id=92161

Android fails to compile (Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

Source/Platform:

  • chromium/public/WebMediaStreamDescriptor.h:

(WebMediaStreamDescriptor):

  • chromium/public/WebMediaStreamSource.h:

(WebMediaStreamSource):

Source/WebCore:

  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::setEnabled):

  • Modules/mediastream/MediaStreamTrack.h:

(MediaStreamTrack):

  • Modules/mediastream/MediaStreamTrack.idl:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • platform/chromium/support/WebMediaStreamDescriptor.cpp:

(WebKit):
(WebKit::WebMediaStreamDescriptor::sources):

  • platform/chromium/support/WebMediaStreamSource.cpp:
  • platform/mediastream/MediaStreamSource.cpp: Removed.
  • platform/mediastream/MediaStreamSource.h:

(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::muted):
(WebCore::MediaStreamSource::setMuted):
(WebCore::MediaStreamSource::MediaStreamSource):
(MediaStreamSource):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didCreateMediaStream):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::createMediaStreamCenter):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.h:

(MockWebKitPlatformSupport):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Removed.
  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Removed.

LayoutTests:

  • fast/mediastream/MediaStreamTrack-expected.txt: Removed.
  • fast/mediastream/MediaStreamTrack.html: Removed.
3:01 PM Changeset in webkit [123532] by atwilson@chromium.org
  • 1 edit
    20 adds in trunk/LayoutTests

Unreviewed chromium expectations update from r123490.

  • platform/chromium-mac-snowleopard/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-as-background-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-simple-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-out-of-order-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-simple-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-without-specified-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/resize-corner-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
2:48 PM Changeset in webkit [123531] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/1180

Merge 122918 - Fix an assertion failure in CalendarPickerElement::hostInput().
https://bugs.webkit.org/show_bug.cgi?id=91568
BUG=137671
Review URL: https://chromiumcodereview.appspot.com/10795098

2:44 PM Changeset in webkit [123530] by dpranke@chromium.org
  • 11 edits in trunk/Tools

nrwt: never finds binaries in the 'out' dir on chromium win
https://bugs.webkit.org/show_bug.cgi?id=91890

Reviewed by Tony Chang.

Attempt to fix this bug yet again; it turns out that --root and
--build-directory don't have the same meaning (--root should
include the configuration, --build-directory should not).

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._build_path):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort):
(ChromiumPort._build_path_with_configuration):
(ChromiumPort._build_path_with_configuration.does):
(ChromiumPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort):
(ChromiumAndroidPort._build_path_with_configuration):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_build_path):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

2:37 PM Changeset in webkit [123529] by inferno@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp

Merge 123187 - [Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
https://bugs.webkit.org/show_bug.cgi?id=91824
BUG=136145
Review URL: https://chromiumcodereview.appspot.com/10818041

2:35 PM Changeset in webkit [123528] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/1180

Merge 123128 - Crash in WebCore::StyleResolver::collectMatchingRulesForList
https://bugs.webkit.org/show_bug.cgi?id=90803
BUG=136235
Review URL: https://chromiumcodereview.appspot.com/10809085

2:26 PM Changeset in webkit [123527] by caio.oliveira@openbossa.org
  • 60 edits
    11 deletes in trunk/LayoutTests

[Qt] svg/batik rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92162

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/batik/text/smallFonts-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/smallFonts-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textAnchor-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/textAnchor-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textEffect-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/textEffect-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textEffect3-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/textEffect3-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textPosition-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textPosition2-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/textPosition2-expected.txt: Removed.
  • platform/qt/svg/batik/filters/filterRegions-expected.png:
  • platform/qt/svg/batik/filters/filterRegions-expected.txt:
  • platform/qt/svg/batik/masking/maskRegions-expected.png:
  • platform/qt/svg/batik/masking/maskRegions-expected.txt:
  • platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/qt/svg/batik/paints/patternRegionA-expected.png:
  • platform/qt/svg/batik/paints/patternRegionA-expected.txt:
  • platform/qt/svg/batik/paints/patternRegions-expected.png:
  • platform/qt/svg/batik/paints/patternRegions-expected.txt:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/qt/svg/batik/text/longTextOnPath-expected.png:
  • platform/qt/svg/batik/text/longTextOnPath-expected.txt:
  • platform/qt/svg/batik/text/smallFonts-expected.png:
  • platform/qt/svg/batik/text/smallFonts-expected.txt:
  • platform/qt/svg/batik/text/textAnchor-expected.png:
  • platform/qt/svg/batik/text/textAnchor-expected.txt:
  • platform/qt/svg/batik/text/textAnchor2-expected.png:
  • platform/qt/svg/batik/text/textAnchor2-expected.txt:
  • platform/qt/svg/batik/text/textAnchor3-expected.png:
  • platform/qt/svg/batik/text/textAnchor3-expected.txt:
  • platform/qt/svg/batik/text/textDecoration-expected.png:
  • platform/qt/svg/batik/text/textDecoration-expected.txt:
  • platform/qt/svg/batik/text/textDecoration2-expected.png:
  • platform/qt/svg/batik/text/textDecoration2-expected.txt:
  • platform/qt/svg/batik/text/textEffect-expected.png:
  • platform/qt/svg/batik/text/textEffect-expected.txt:
  • platform/qt/svg/batik/text/textEffect2-expected.png:
  • platform/qt/svg/batik/text/textEffect2-expected.txt:
  • platform/qt/svg/batik/text/textEffect3-expected.png:
  • platform/qt/svg/batik/text/textEffect3-expected.txt:
  • platform/qt/svg/batik/text/textFeatures-expected.png:
  • platform/qt/svg/batik/text/textFeatures-expected.txt:
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/qt/svg/batik/text/textLayout2-expected.png:
  • platform/qt/svg/batik/text/textLayout2-expected.txt:
  • platform/qt/svg/batik/text/textLength-expected.png:
  • platform/qt/svg/batik/text/textLength-expected.txt:
  • platform/qt/svg/batik/text/textOnPath-expected.png:
  • platform/qt/svg/batik/text/textOnPath-expected.txt:
  • platform/qt/svg/batik/text/textOnPath2-expected.png:
  • platform/qt/svg/batik/text/textOnPath2-expected.txt:
  • platform/qt/svg/batik/text/textOnPath3-expected.png:
  • platform/qt/svg/batik/text/textOnPath3-expected.txt:
  • platform/qt/svg/batik/text/textPCDATA-expected.png:
  • platform/qt/svg/batik/text/textPCDATA-expected.txt:
  • platform/qt/svg/batik/text/textPosition-expected.png:
  • platform/qt/svg/batik/text/textPosition-expected.txt:
  • platform/qt/svg/batik/text/textPosition2-expected.png:
  • platform/qt/svg/batik/text/textPosition2-expected.txt:
  • platform/qt/svg/batik/text/textProperties-expected.png:
  • platform/qt/svg/batik/text/textProperties-expected.txt:
  • platform/qt/svg/batik/text/textProperties2-expected.png:
  • platform/qt/svg/batik/text/textProperties2-expected.txt:
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
2:09 PM Changeset in webkit [123526] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not call settings setters twice on page construction
https://bugs.webkit.org/show_bug.cgi?id=92157

Reviewed by Yong Li.

The WebPagePrivate init method sets some settings value that were
already set in didChangeSettings.
Also call didChangeSettings explicitly from init, before that we are
not calling it since the delegate is not set yet.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

1:59 PM Changeset in webkit [123525] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

Crash in RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=92145

Reviewed by Abhishek Arya.

Source/WebCore:

The crash came from the insertChildNode logic being confused and choosing the wrong
renderer for insertion. This is because after r123159, table anonymous wrappers can
be created as 'inline-table' and wouldn't pass the isAnonymousBlock() check.

This change also aligns the ancestor iteration with RenderBlock::addChildToAnonymousColumnBlocks.

Test: fast/table/crash-table-section-layoutRows.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::insertChildNode):
Changed the code to always get the right child. There is no justification to not
walking up to the |owner|'s direct child in all cases.

LayoutTests:

  • fast/table/crash-table-section-layoutRows-expected.txt: Added.
  • fast/table/crash-table-section-layoutRows.html: Added.
1:53 PM Changeset in webkit [123524] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Make RenderBlock::paintChildren virtual so sub classes can change the paint order
https://bugs.webkit.org/show_bug.cgi?id=92042

Reviewed by Ojan Vafai.

The flexbox spec says that the order property should change the paint order of flex children.
To make that possible, make paintChildren virtual so RenderFlexibleBox can override it.

No new tests, this is just a refactoring.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContents): Move some code out of paintChildren into paintContents.
(WebCore::RenderBlock::paintChildren): Make virtual and just have it be a simple for loop.
(WebCore::RenderBlock::paintChild): Move code out of paintChildren so subclasses can reuse.

  • rendering/RenderBlock.h:

(RenderBlock): Make paintChildren virtual and protected so sub classes can call paintChild.

1:46 PM Changeset in webkit [123523] by caio.oliveira@openbossa.org
  • 16 edits
    4 deletes in trunk/LayoutTests

[Qt] svg/clip-path rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92158

Unreviewed.

Create a separate bug to track two tests that had wrong expected results before
the font change.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/clip-path/clip-path-pixelation-expected.png:
  • platform/qt/svg/clip-path/clip-path-pixelation-expected.txt:
  • platform/qt/svg/clip-path/clip-path-text-and-shape-expected.png:
  • platform/qt/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/qt/svg/clip-path/clip-path-text-and-stroke-expected.png:
  • platform/qt/svg/clip-path/clip-path-text-and-stroke-expected.txt:
  • platform/qt/svg/clip-path/clip-path-text-expected.png:
  • platform/qt/svg/clip-path/clip-path-text-expected.txt:
  • platform/qt/svg/clip-path/clip-path-tspan-and-stroke-expected.png:
  • platform/qt/svg/clip-path/clip-path-tspan-and-stroke-expected.txt:
  • platform/qt/svg/clip-path/clip-path-with-text-clipped-expected.png:
  • platform/qt/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
1:44 PM Changeset in webkit [123522] by annacc@chromium.org
  • 18 edits
    7 adds in trunk/Source/WebCore

Create SourceBuffer and SourceBufferList objects
https://bugs.webkit.org/show_bug.cgi?id=91771

Reviewed by Eric Carlson.

SourceBuffer and SourceBufferList objects are needed in order to
implement the new object-oriented MediaSource API:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

No new tests - will be able to test after landing BUGWK91775

Adding new files to build files:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:

New objects:

  • Modules/mediasource/SourceBuffer.cpp: Added.
  • Modules/mediasource/SourceBuffer.h: Added.
  • Modules/mediasource/SourceBuffer.idl: Added.
  • Modules/mediasource/SourceBufferList.cpp: Added.
  • Modules/mediasource/SourceBufferList.h: Added.
  • Modules/mediasource/SourceBufferList.idl: Added.

New events:

  • dom/EventNames.h:

(WebCore):

  • dom/EventTarget.h:

(WebCore):

  • dom/EventTargetFactory.in:

Object constructors:

  • page/DOMWindow.idl:
1:33 PM Changeset in webkit [123521] by zmo@google.com
  • 36 edits
    8 deletes in trunk/LayoutTests

Rebaseline - gardening stuff.

Unreviewed.

  • fast/canvas/webgl/framebuffer-object-attachment-expected.txt:
  • fast/canvas/webgl/framebuffer-object-attachment.html:
  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils):

  • platform/chromium-linux-x86/css3/selectors3/html: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xhtml: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xml: Removed.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Removed.
  • platform/chromium-linux/compositing/overflow/theme-affects-visual-overflow-expected.png:
  • platform/chromium-linux/css1/box_properties/acid_test-expected.png:
  • platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/chromium-linux/fast/block/basic/011-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png:
  • platform/chromium-linux/fast/forms/001-expected.png:
  • platform/chromium-linux/fast/forms/basic-inputs-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/formmove-expected.png:
  • platform/chromium-linux/fast/forms/formmove2-expected.png:
  • platform/chromium-linux/fast/forms/indeterminate-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium-linux/fast/inline/positionedLifetime-expected.png:
  • platform/chromium-linux/fast/parser/bad-xml-slash-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.
  • platform/chromium-win-xp/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Removed.
  • platform/mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.
  • platform/mac/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.
1:32 PM Changeset in webkit [123520] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Add a bounding box member in WebGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=92144

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-07-24
Reviewed by Adam Barth.

The new |boundingBox| member will be used to store the touch region for a WebGestureEvent.
This will be useful for gesture target fuzzing across multiple different gesture types
(tap, long press, scroll, etc.)

  • public/WebInputEvent.h:

(WebGestureEvent):

  • src/WebInputEvent.cpp:

(SameSizeAsWebGestureEvent):

1:29 PM Changeset in webkit [123519] by commit-queue@webkit.org
  • 55 edits in trunk/LayoutTests

[Qt] fast/block/basic needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92149

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-24
Reviewed by Alexis Menard.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/fast/block/basic/001-expected.png:
  • platform/qt/fast/block/basic/001-expected.txt:
  • platform/qt/fast/block/basic/002-expected.png:
  • platform/qt/fast/block/basic/002-expected.txt:
  • platform/qt/fast/block/basic/003-expected.png:
  • platform/qt/fast/block/basic/003-expected.txt:
  • platform/qt/fast/block/basic/004-expected.png:
  • platform/qt/fast/block/basic/004-expected.txt:
  • platform/qt/fast/block/basic/005-expected.png:
  • platform/qt/fast/block/basic/005-expected.txt:
  • platform/qt/fast/block/basic/006-expected.png:
  • platform/qt/fast/block/basic/006-expected.txt:
  • platform/qt/fast/block/basic/007-expected.png:
  • platform/qt/fast/block/basic/007-expected.txt:
  • platform/qt/fast/block/basic/008-expected.png:
  • platform/qt/fast/block/basic/008-expected.txt:
  • platform/qt/fast/block/basic/009-expected.png:
  • platform/qt/fast/block/basic/009-expected.txt:
  • platform/qt/fast/block/basic/010-expected.png:
  • platform/qt/fast/block/basic/010-expected.txt:
  • platform/qt/fast/block/basic/011-expected.png:
  • platform/qt/fast/block/basic/011-expected.txt:
  • platform/qt/fast/block/basic/012-expected.png:
  • platform/qt/fast/block/basic/012-expected.txt:
  • platform/qt/fast/block/basic/013-expected.png:
  • platform/qt/fast/block/basic/013-expected.txt:
  • platform/qt/fast/block/basic/014-expected.png:
  • platform/qt/fast/block/basic/014-expected.txt:
  • platform/qt/fast/block/basic/015-expected.png:
  • platform/qt/fast/block/basic/015-expected.txt:
  • platform/qt/fast/block/basic/016-expected.png:
  • platform/qt/fast/block/basic/016-expected.txt:
  • platform/qt/fast/block/basic/018-expected.png:
  • platform/qt/fast/block/basic/018-expected.txt:
  • platform/qt/fast/block/basic/019-expected.png:
  • platform/qt/fast/block/basic/019-expected.txt:
  • platform/qt/fast/block/basic/020-expected.txt:
  • platform/qt/fast/block/basic/021-expected.png:
  • platform/qt/fast/block/basic/021-expected.txt:
  • platform/qt/fast/block/basic/adding-near-anonymous-block-expected.png:
  • platform/qt/fast/block/basic/adding-near-anonymous-block-expected.txt:
  • platform/qt/fast/block/basic/minheight-expected.png:
  • platform/qt/fast/block/basic/minheight-expected.txt:
  • platform/qt/fast/block/basic/percent-height-inside-anonymous-block-expected.png:
  • platform/qt/fast/block/basic/percent-height-inside-anonymous-block-expected.txt:
  • platform/qt/fast/block/basic/quirk-height-expected.png:
  • platform/qt/fast/block/basic/quirk-height-expected.txt:
  • platform/qt/fast/block/basic/truncation-rtl-expected.png:
  • platform/qt/fast/block/basic/truncation-rtl-expected.txt:
  • platform/qt/fast/block/basic/white-space-pre-wraps-expected.png:
  • platform/qt/fast/block/basic/white-space-pre-wraps-expected.txt:
1:22 PM Changeset in webkit [123518] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium/mac] Add cursor resource pngs to the pak file.
https://bugs.webkit.org/show_bug.cgi?id=92148

Reviewed by Tony Chang.

Once https://chromiumcodereview.appspot.com/10817031/ has landed, they can be
removed from WebCore.gyp's mac_bundle_resources. Part of http://crbug.com/137588

  • WebKit.grd:
1:20 PM Changeset in webkit [123517] by caio.oliveira@openbossa.org
  • 19 edits
    2 deletes in trunk/LayoutTests

[Qt] svg/carto.net rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92152

Unreviewed.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/carto.net/window-expected.png: Removed.
  • platform/qt-5.0/svg/carto.net/window-expected.txt: Removed.
  • platform/qt/svg/carto.net/button-expected.png:
  • platform/qt/svg/carto.net/button-expected.txt:
  • platform/qt/svg/carto.net/colourpicker-expected.png:
  • platform/qt/svg/carto.net/colourpicker-expected.txt:
  • platform/qt/svg/carto.net/scrollbar-expected.png:
  • platform/qt/svg/carto.net/scrollbar-expected.txt:
  • platform/qt/svg/carto.net/selectionlist-expected.png:
  • platform/qt/svg/carto.net/selectionlist-expected.txt:
  • platform/qt/svg/carto.net/slider-expected.png:
  • platform/qt/svg/carto.net/slider-expected.txt:
  • platform/qt/svg/carto.net/tabgroup-expected.png:
  • platform/qt/svg/carto.net/tabgroup-expected.txt:
  • platform/qt/svg/carto.net/textbox-expected.png:
  • platform/qt/svg/carto.net/textbox-expected.txt:
  • platform/qt/svg/carto.net/window-expected.png:
  • platform/qt/svg/carto.net/window-expected.txt:
1:17 PM Changeset in webkit [123516] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Make sure that an AC sync is triggered when the canvas contents is updated.
https://bugs.webkit.org/show_bug.cgi?id=92128

Reviewed by Kenneth Rohde Christiansen.

This would cause missed frames when animating an accelerated 2D canvas without
touching the document.

  • WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):

1:15 PM Changeset in webkit [123515] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac WK2] Improve text input logging
https://bugs.webkit.org/show_bug.cgi?id=92147

Reviewed by Andreas Kling.

  • UIProcess/API/mac/WKView.mm:

(-[WKView insertText:replacementRange:]):
(-[WKView keyUp:]):
(-[WKView keyDown:]):
(-[WKView flagsChanged:]):
(-[WKView _executeSavedKeypressCommands]):
(-[WKView _notifyInputContextAboutDiscardedComposition]):
(-[WKView _interpretKeyEvent:savingCommandsTo:WebCore::]):
(-[WKView _updateSecureInputState]):

1:11 PM Changeset in webkit [123514] by commit-queue@webkit.org
  • 20 edits
    3 adds in trunk/LayoutTests

[Qt] platform, plugins and printing need rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92016

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-24
Reviewed by Alexis Menard.

Updating skipped tests inside platform, plugins and printing. The following tests
remain skipped:
/platform/qt/plugins/qt-qwidget-plugin.html (bug #92141)
/plugins/netscape-dom-access.html (already skipped inside qt/Skipped)

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/platform/qt/fast/forms/button-line-break-expected.png:
  • platform/qt/platform/qt/fast/forms/button-line-break-expected.txt:
  • platform/qt/platform/qt/plugins/application-plugin-plugins-disabled-expected.png: Added.
  • platform/qt/platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • platform/qt/platform/qt/plugins/qt-qwidget-plugin-expected.png: Added.
  • platform/qt/platform/qt/plugins/qt-qwidget-plugin-expected.txt:
  • platform/qt/plugins/iframe-plugin-bgcolor-expected.txt:
  • platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/qt/printing/compositing-layer-printing-expected.png:
  • platform/qt/printing/compositing-layer-printing-expected.txt:
  • platform/qt/printing/iframe-print-expected.png:
  • platform/qt/printing/iframe-print-expected.txt:
  • platform/qt/printing/media-queries-print-expected.png:
  • platform/qt/printing/media-queries-print-expected.txt:
  • platform/qt/printing/page-rule-in-media-query-expected.png:
  • platform/qt/printing/page-rule-in-media-query-expected.txt:
  • platform/qt/printing/simultaneous-position-float-change-expected.txt:
  • platform/qt/printing/width-overflow-expected.png:
  • platform/qt/printing/width-overflow-expected.txt:
1:04 PM Changeset in webkit [123513] by jchaffraix@webkit.org
  • 3 edits
    2 copies in branches/chromium/1180

Merge 123062 - Crash in RenderTableSection::addCell.
http://webkit.org/b/89496

Reviewed by Abhishek Arya.

Source/WebCore:

The issue comes from RenderBox::splitAnonymousBoxesAroundChild that would move sections
across tables but didn't force the table to do a synchronous section recalc. This opened
the way for race conditions where we would query the table column structure while it's dirty
(this is not uncommon but as usually the table's column representation is always bigger or
more split than a section's, it's usually harmless).

The fix is to force a synchronous section recalc.

Test: fast/table/split-table-no-section-update-crash.html

  • rendering/RenderBox.cpp:

(WebCore::markBoxForRelayoutAfterSplit):
Changed to call forceSectionsRecalc ie force a section recalc.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::recalcSections):
Added missing ASSERT for unneeded calls.

  • rendering/RenderTable.h:

(WebCore::RenderTable::forceSectionsRecalc):
Added this helper function.

LayoutTests:

The test is still pretty complex as it involves lots of generated content. It should
be possible to get a smaller test case based on the conditions for the crash. However
this test is a pretty good stress test so I decided against creating a more simple test
case.

  • fast/table/split-table-no-section-update-crash-expected.txt: Added.
  • fast/table/split-table-no-section-update-crash.html: Added.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10809080

12:59 PM Changeset in webkit [123512] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

Throttle calls to request the virtual keyboard be shown.
https://bugs.webkit.org/show_bug.cgi?id=92138

Reviewed by Rob Buis.

PR 178465.

Do not request keyboard visibility change when
we are actively processing an input event.

Reviewed Internally by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):

12:48 PM Changeset in webkit [123511] by leandrogracia@chromium.org
  • 2 edits in trunk/Source/Platform

[Chromium] Enable conversion between WebFloatRect and gfx::RectF.
https://bugs.webkit.org/show_bug.cgi?id=92117

Reviewed by Adam Barth.

Introduce WebFloatRect <--> gfx::RectF conversion as we already do with WebRect <--> gfx::Rect.

  • chromium/public/WebFloatRect.h:

(WebKit::WebFloatRect::WebFloatRect):
(WebFloatRect):
(WebKit::WebFloatRect::operator=):
(WebKit::WebFloatRect::operator gfx::RectF):

12:47 PM Changeset in webkit [123510] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r123417): It made tests assert/crash on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=92088

Reviewed by Mark Hahnenberg.

The pointer arithmetic was wrong, because negative numbers are hard to think about.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::emitPutTransitionStub):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

12:45 PM Changeset in webkit [123509] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Provide more useful output when an injected bundle cannot be loaded
https://bugs.webkit.org/show_bug.cgi?id=92136

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Call eina_error_get() in case an injected bundle cannot be
loaded in order to print more information about the error.

  • WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:

(WebKit::InjectedBundle::load):

12:40 PM Changeset in webkit [123508] by fmalita@chromium.org
  • 1 edit
    2 copies in branches/chromium/1180

Merge 122755 - SVGAnimationElement::currentValuesForValuesAnimation crash
https://bugs.webkit.org/show_bug.cgi?id=91326

Reviewed by Simon Fraser.

SVGSMILElement::progress() assumes that seekToIntervalCorrespondingToTime() always
lands inside a defined interval, but one can force arbitrary time offsets using
setCurrentTime(). This patch adds logic for handling non-interval time offsets
gracefully.

Source/WebCore:

Test: svg/animations/smil-setcurrenttime-crash.svg

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::progress):

LayoutTests:

  • svg/animations/smil-setcurrenttime-crash-expected.txt: Added.
  • svg/animations/smil-setcurrenttime-crash.svg: Added.

TBR=fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10802091

12:40 PM Changeset in webkit [123507] by peter@chromium.org
  • 4 edits in trunk/Tools

Android-chromium layout tests failing with GPU related crash
https://bugs.webkit.org/show_bug.cgi?id=92126

Reviewed by Adam Barth.

Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
as it's not being used by any port anymore, and neither is being passed
on to the test runner. Instead, append the flag directly to DRT for the
Chromium Android port, which does rely on this functionality.

The ChromiumAndroidUnitTest tests didn't catch this as the property was
set to True, but it's unable to detect whether they'll actually be used.
No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest.test_attributes):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

12:32 PM Changeset in webkit [123506] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
https://bugs.webkit.org/show_bug.cgi?id=92107

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Fixes mouse click events in EventSenderProxyEfl.

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::dispatchMouseDownEvent):
(WTR::EventSenderProxy::dispatchEvent):

12:25 PM Changeset in webkit [123505] by Patrick Gansterer
  • 10 edits in trunk/Source

Store the full year in GregorianDateTime
https://bugs.webkit.org/show_bug.cgi?id=92067

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Use the full year instead of the offset from year 1900
for the year member variable of GregorianDateTime.

  • runtime/DateConstructor.cpp:

(JSC::constructDate):
(JSC::dateUTC):

  • runtime/DateConversion.cpp:

(JSC::formatDate):
(JSC::formatDateUTCVariant):

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncSetYear):

  • runtime/JSDateMath.cpp:

(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):

Source/WebCore:

Use the full year instead of the offset from year 1900
for the year member variable of GregorianDateTime.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

Source/WTF:

Use the full year instead of the offset from year 1900
for the year member variable of GregorianDateTime.

  • wtf/GregorianDateTime.h:

(WTF::GregorianDateTime::operator tm):

12:12 PM Changeset in webkit [123504] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Do not perform 8 to 16bits characters conversion when converting a WTFString to NSString/CFString
https://bugs.webkit.org/show_bug.cgi?id=90720

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-24
Reviewed by Geoffrey Garen.

In most String to CFString conversion, we should be able to use the "NoCopy" constructor and have
a relatively cheap conversion from WTF::String to CFString.

When the String is 8 bits, it was converted to 16 bits by getData16SlowCase() because of the call
to String::characters().

This patch adds a path for creating a CFString from a 8bits string using CFStringCreateWithBytes.

This is covered by existing tests.

  • platform/text/cf/StringCF.cpp:

(WTF::String::createCFString): CFSTR() create static CFString, it is unecessary to retain it.

  • platform/text/cf/StringImplCF.cpp:

(WTF::StringImpl::createCFString): The logic to avoid the StringWrapperCFAllocator has also been simplified.
The allocator creation is now closer to where it is useful.

12:03 PM Changeset in webkit [123503] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[WIN] Build fix after r123417.

11:55 AM Changeset in webkit [123502] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Re-skip failing tests for Qt 4.8 platform
https://bugs.webkit.org/show_bug.cgi?id=92119

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-24
Reviewed by Alexis Menard.

The following tests, after unskipping, are now passing on Qt-5.0 build bot
variations, but still failing for Qt-4.8 ones:

Regressions: Unexpected text diff mismatch : (1)

http/tests/misc/acid3.html = TEXT

Regressions: Unexpected image mismatch : (2)

fast/css/tab-size.html = IMAGE
fast/text/international/bdi-dir-default-to-auto.html = IMAGE

This patch adds these to Skipped list of qt-4.8 platform.

  • platform/qt-4.8/Skipped: Added 3 layout tests.
11:43 AM Changeset in webkit [123501] by kareng@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp

Merge 121510 - [Chromium] CTFontCopyTable of MacOSX10.5 SDK doesn't work for layout tables
https://bugs.webkit.org/show_bug.cgi?id=90235

Reviewed by Kent Tamura.

Use CGFontCopyTableForTag instead.

No new tests. css3/font-feature-settings-rendering.html should pass. I'll rebase expectations once bots get the result.

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp:

(WebCore::harfbuzzCoreTextGetTable):

TBR=bashi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10815078

11:42 AM Changeset in webkit [123500] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] String wrappers should be marked Independent
https://bugs.webkit.org/show_bug.cgi?id=91251

Reviewed by Adam Barth.

Currently V8 String wrappers are not marked Independent.
By marking them Independent, they can be reclaimed by the scavenger GC.
Although I couldn't find a case where this change reduces memory usage,
this change would be important for upcoming changes in string conversion
between V8 and WebKit (https://bugs.webkit.org/show_bug.cgi?id=91850).

'm_lastStringImpl = 0' in StringCache::remove() is important.
Look at the following code:

static void cachedStringCallback(v8::Persistent<v8::Value> wrapper, void* parameter)
{

...;
stringCache()->remove(stringImpl);
wrapper.Dispose();

}

void StringCache::remove(StringImpl* stringImpl)
{

...
if (m_lastStringImpl.get() == stringImpl)

m_lastStringImpl = 0;

}

v8::Local<v8::String> v8ExternalString(StringImpl* stringImpl, v8::Isolate* isolate)
{

if (m_lastStringImpl.get() == stringImpl) {

return v8::Local<v8::String>::New(m_lastV8String); m_lastV8String points to a wrapper object that was accessed most recently.

}
return v8ExternalStringSlow(stringImpl, isolate);

}

Without 'm_lastStringImpl = 0', already disposed m_lastV8String can be used
in v8ExternalString(). This was a cause of the crashes of r122614.

Tests: At the initial commit of this patch (r122614),

the following tests had been broken due to missing 'm_lastStringImpl = 0'.
fast/workers/worker-location.html
Dromaeo/cssquery-jquery.html
Dromaeo/jslib-event-jquery.html
Dromaeo/jslib-style-jquery.html
Dromaeo/jslib-style-prototype.html

  • bindings/v8/V8Binding.cpp:

(WebCore::StringCache::remove):
(WebCore::StringCache::v8ExternalStringSlow):

11:33 AM Changeset in webkit [123499] by tommyw@google.com
  • 22 edits
    2 copies
    3 adds in trunk

MediaStream API: Update MediaStreamTrack to match the specification
https://bugs.webkit.org/show_bug.cgi?id=90180

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebMediaStreamDescriptor.h:

(WebMediaStreamDescriptor):

  • chromium/public/WebMediaStreamSource.h:

(WebMediaStreamSource):

Source/WebCore:

MediaStreamTracks are now required to show the status of the underlying source,
and trigger events when that status changes.

Test: fast/mediastream/MediaStreamTrack.html

  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::setEnabled):
(WebCore::MediaStreamTrack::readyState):
(WebCore):
(WebCore::MediaStreamTrack::sourceChangedState):
(WebCore::MediaStreamTrack::stop):
(WebCore::MediaStreamTrack::interfaceName):
(WebCore::MediaStreamTrack::scriptExecutionContext):
(WebCore::MediaStreamTrack::eventTargetData):
(WebCore::MediaStreamTrack::ensureEventTargetData):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • platform/chromium/support/WebMediaStreamDescriptor.cpp:
  • platform/chromium/support/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::setReadyState):
(WebKit):
(WebKit::WebMediaStreamSource::readyState):

  • platform/mediastream/MediaStreamSource.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamSource.h.

(WebCore):
(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::MediaStreamSource):
(WebCore::MediaStreamSource::setReadyState):
(WebCore::MediaStreamSource::addObserver):
(WebCore::MediaStreamSource::removeObserver):

  • platform/mediastream/MediaStreamSource.h:

(Observer):
(WebCore::MediaStreamSource::Observer::~Observer):
(MediaStreamSource):
(WebCore::MediaStreamSource::readyState):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didCreateMediaStream):

Tools:

Adding a Mock WebMediaStreamCenter to enable better LayoutTests.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::createMediaStreamCenter):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.

(WebKit):
(WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
(WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
(WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
(WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
(WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
(WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
(WebKit::MockWebMediaStreamCenter::constructSDP):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.

(WebKit):
(MockWebMediaStreamCenter):
(WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):

LayoutTests:

  • fast/mediastream/MediaStreamTrack-expected.txt: Added.
  • fast/mediastream/MediaStreamTrack.html: Added.
11:30 AM Changeset in webkit [123498] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Fix regressions in replay performance tests
https://bugs.webkit.org/show_bug.cgi?id=92052

Reviewed by Dirk Pranke.

Fix regression that accumulated over time to make replay tests work again.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::willSendRequest): Use the main document URL in the request since the main frame's
URL hadn't been updated yet When requesting a new URL on the main frame.

  • Scripts/webkitpy/performance_tests/perftest.py:

(ReplayServer.wait_until_ready): Waiting for 6 seconds (3 tries) seems enough.
(ReplayPerfTest.prepare): Pass self._archive_path to run_signle as that is the current contract.
(ReplayPerfTest.run_single): Use the archive path to generate -expected.png path.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestReplayPerfTest.test_run_single):
(TestReplayPerfTest.test_prepare):
(TestReplayPerfTest.test_prepare_calls_run_single.run_single):
(TestReplayPerfTest):

11:25 AM Changeset in webkit [123497] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations change for chromium to address lint error from r90190.

  • platform/chromium/TestExpectations:
11:23 AM Changeset in webkit [123496] by tony@chromium.org
  • 5 edits in trunk/Source/WebCore

Use native (non-cygwin) binaries for perl, gperf, and bison in Chromium
https://bugs.webkit.org/show_bug.cgi?id=91667

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-24
Reviewed by Tony Chang.

Using native tools instead of cygwin version improves build time
performance by roughly 50% (on top of previous cl-instead-of-gcc
change).

Also, use - instead of / for cl flags, otherwise preprocessing fails
very slowly (due to retry loop). And, replace \ with / in gperf
command line. Without this, gperf emits the filename literally in
#line directives which causes VS to error with "unescaped \ in
string". Bizarrely, building ColorData.cpp with those \ in place
causes the IDE to exit with no error message, which was the cause of
the previous canary failures.

No new tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_bison.py:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

  • make-hash-tools.pl:
11:17 AM Changeset in webkit [123495] by dcheng@chromium.org
  • 9 edits in trunk/Source/WebCore

Files from drag and file <input> should use getMIMETypeForExtension to determine content type.
https://bugs.webkit.org/show_bug.cgi?id=91702

Reviewed by Jian Li.

Awhile back, we changed File to only use getWellKnownMIMETypeForExtension to prevent web
pages from being able to detect what applications a user has installed indirectly through
the MIME types. However, some sites like YouTube's drag and drop uploader use MIME types
that aren't in WebKit's internal list, so we relax the restriction for Files that originate
from an user action.

  • fileapi/File.cpp:

(WebCore::getContentTypeFromFileName):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):
(WebCore::createBlobDataForFileWithMetadata):
(WebCore::File::createWithRelativePath):
(WebCore::File::File):

  • fileapi/File.h:

(File):
(WebCore::File::create):
(WebCore::File::createWithName):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createFileList):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::addFilename):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::files):

  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::files):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::files):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::files):

11:05 AM Changeset in webkit [123494] by vsevik@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: Snippets UI polish
https://bugs.webkit.org/show_bug.cgi?id=92142

Reviewed by Pavel Feldman.

Changed snippets context menu items.
Added run snippet status bar button.
Removed unused edit source button.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.SnippetJavaScriptSourceFrame):
(WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.SnippetsNavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.statusBarItems):

  • inspector/front-end/inspector.css:
  • inspector/front-end/scriptsPanel.css:

(.evaluate-snippet-status-bar-item .glyph):
(.evaluate-snippet-status-bar-item.toggled .glyph):

10:47 AM Changeset in webkit [123493] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium/mac] Remove webcore_resource_files from WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=92129

Reviewed by Adam Barth.

It was added in http://trac.webkit.org/changeset/81706/trunk/Source/WebCore/WebCore.gypi .
The changes in that revision were mostly reverted in http://trac.webkit.org/changeset/119921 ,
but this block was forgotten. Since it just confused me for a bit, remove it.

  • WebCore.gyp/WebCore.gyp:
10:44 AM Changeset in webkit [123492] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

inline-table wrapper should be generated for display: inline element only
https://bugs.webkit.org/show_bug.cgi?id=92054

Reviewed by Abhishek Arya.

Source/WebCore:

CSS 2.1 only takes into account the display when determining if we should generate
an inline-table. My misreading of the spec would make us generate an inline-table
wrapper for any inline formatting context.

Test: fast/table/inline-block-generates-table-wrapper.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::createAnonymousWithParentRenderer):
Changed to use display instead of isInline to properly match the spec.

LayoutTests:

For some reason, using dumpAsText didn't dump the 2 lines properly so the test
is a reftest to work-around that.

  • fast/table/inline-block-generates-table-wrapper-expected.html: Added.
  • fast/table/inline-block-generates-table-wrapper.html: Added.
10:19 AM Changeset in webkit [123491] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r123472.
http://trac.webkit.org/changeset/123472
https://bugs.webkit.org/show_bug.cgi?id=92134

Revert roll to v8 version that crashes sporadically (Requested
by atwilson on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

  • DEPS:
10:16 AM Changeset in webkit [123490] by commit-queue@webkit.org
  • 2 edits
    35 adds in trunk/LayoutTests

[chromium] Unskip tests in fast/hidpi
https://bugs.webkit.org/show_bug.cgi?id=90190

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-07-24
Reviewed by Adam Barth.

Adding cr-linux baselines so that the EWS will go green. Will be adding new
baselines for the chromium ports with WebKit gardener atwilson@.

  • platform/chromium-linux/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-as-background-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-as-background-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-background-repeat-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-background-repeat-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-background-repeat-without-size-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-border-image-comparison-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-border-image-simple-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-border-image-simple-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-out-of-order-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-out-of-order-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-simple-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-simple-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-without-specified-width-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-without-specified-width-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/resize-corner-hidpi-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
  • platform/chromium/TestExpectations:
10:11 AM Changeset in webkit [123489] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Temporarily continue generating backend keys for empty key lists
https://bugs.webkit.org/show_bug.cgi?id=92012

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-24
Reviewed by Tony Chang.

Temporarily change key behavior to allow chromium in_process_webkit
to call putWithIndexKeys without inadvertently preventing index
key generation. Note this is temporary until frontend key generation
patch lands.

No new tests, this is part of a refactor that doesn't change behavior.

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):

10:09 AM Changeset in webkit [123488] by pfeldman@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Web Inspector: introduce UISourceCodeFrame.
https://bugs.webkit.org/show_bug.cgi?id=92124

Reviewed by Vsevolod Vlasov.

Generic implementation of SourceFrame over UISourceCode added.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._createSourceFrame):

  • inspector/front-end/StylesPanel.js:
  • inspector/front-end/UISourceCodeFrame.js: Added.

(WebInspector.UISourceCodeFrame):
(WebInspector.UISourceCodeFrame.prototype.canEditSource):
(WebInspector.UISourceCodeFrame.prototype.commitEditing):
(WebInspector.UISourceCodeFrame.prototype.afterTextChanged):
(WebInspector.UISourceCodeFrame.prototype._didEditContent):
(WebInspector.UISourceCodeFrame.prototype._onContentChanged):
(WebInspector.UISourceCodeFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
10:05 AM Changeset in webkit [123487] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update about:config lists
https://bugs.webkit.org/show_bug.cgi?id=92118

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-24
Reviewed by Rob Buis.

We want to have all flags which could be used / have been used by any platform. These lists were created by running:

  • WebCoreSupport/AboutDataEnableFeatures.in: git grep "ENABLE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u
  • WebCoreSupport/AboutDataHaveFeatures.in: git grep "HAVE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u
  • WebCoreSupport/AboutDataUseFeatures.in: git grep "USE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u
9:17 AM Changeset in webkit [123486] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/11945102> REGRESSION (r109451): Overlay scrollbars always use the default style, regardless of background color
https://bugs.webkit.org/show_bug.cgi?id=92115

Reviewed by Mark Rowe.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::scrollbarOverlayStyle): Reversed an incorrect null check.

9:13 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
9:00 AM Changeset in webkit [123485] by atwilson@chromium.org
  • 2 edits in trunk/Source/WebCore

Another prospective build fix for Chromium. Unreviewed.

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:
8:51 AM Changeset in webkit [123484] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove unused variable in BackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=91987

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-24
Reviewed by Antonio Gomes.

PR: 141439
This is done as part of some general BackingStorePrivate::render()
cleanup in PR 141439.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):

8:44 AM Changeset in webkit [123483] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[chromium] Add pixel expectations for new test scrollbar-tickmarks-styled.html
https://bugs.webkit.org/show_bug.cgi?id=92116

Unreviewed.

Patch by Nico Weber <nicolasweber@gmx.de> on 2012-07-24

  • platform/chromium-win/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Added.
  • platform/chromium/TestExpectations:
8:40 AM Changeset in webkit [123482] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add vibration client
https://bugs.webkit.org/show_bug.cgi?id=91371

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-24
Reviewed by Antonio Gomes.

Implement Vibration provider for WebKit2 EFL and add an API to set
vibration client callbacks by application to handle the tactile
feedback in the application when the page content ask for vibration.

  • CMakeLists.txt: Add WebCore/Modules/vibration to include path.
  • PlatformEfl.cmake: Add VibrationProvider.cpp file to the build

system.

  • UIProcess/API/efl/VibrationProvider.cpp: Added.

(_Ewk_Vibration_Client): Structure contains the vibration client
callbacks.
(_Ewk_Vibration_Client::_Ewk_Vibration_Client):
(toVibrationProvider): Helper function to cast the clientinfo to
VibrationProvider.
(vibrateCallback):
(cancelVibrationCallback):
(VibrationProvider::create):
(VibrationProvider::VibrationProvider):
(VibrationProvider::~VibrationProvider):
(VibrationProvider::vibrate):
(VibrationProvider::cancelVibration):
(VibrationProvider::setVibrationClientCallbacks):

  • UIProcess/API/efl/VibrationProvider.h: Added.

(VibrationProvider):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context):
(createDefaultEwkContext):
(ewk_context_vibration_client_callbacks_set): API to set vibration
client callbacks.

  • UIProcess/API/efl/ewk_context.h:
8:38 AM Changeset in webkit [123481] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening of failing and flaky tests
https://bugs.webkit.org/show_bug.cgi?id=92105

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-24

  • platform/efl/TestExpectations:
8:37 AM Changeset in webkit [123480] by atwilson@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed prospective build fix for Chromium. Changed include of hb.h in HarfBuzzNGFace.h

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:
8:31 AM Changeset in webkit [123479] by keishi@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Page popup should close on mouse down
https://bugs.webkit.org/show_bug.cgi?id=92092

Reviewed by Kent Tamura.

Page popup should close on mouse down because some elements(e.g. <input type=color>) don't have a blur event that
we can hook to hide the page popup when the user clicks on the page.

  • src/WebPagePopupImpl.h:

(WebKit::WebPagePopupImpl::hasSamePopupClient): Returns true if the given WebPagePopupImpl have the same popup client.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseDown): Close all popups when the page is clicked. Checks if the
mouse down event opened the same popup we just closed.

8:25 AM Changeset in webkit [123478] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unskip layout test after monospace-font fix
https://bugs.webkit.org/show_bug.cgi?id=86179

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-24
Reviewed by Alexis Menard.

This test has been skipped because monospace fonts weren't properly to
HTML tags like <pre>, for instance. After r121971, the test results are
normal again.

  • platform/qt/Skipped: Unskipped fast/css/tab-size.html.
7:58 AM Changeset in webkit [123477] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

7:47 AM Changeset in webkit [123476] by Csaba Osztrogonác
  • 7 edits in trunk/Source/WebKit2

[Qt] Fix compilation after QtQuick API changes
https://bugs.webkit.org/show_bug.cgi?id=91822

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

QQuickCanvas is now QQuickWindow, QQuickItem::canvas() is window() and rootItem()
is contentItem(). Also QQuickWindow::grabFrameBuffer() is now grabWindow().

  • UIProcess/API/qt/qquickwebpage.cpp:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::updateIcon):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::multipleWebViews):
(tst_QQuickWebView::basicRenderingSanity):
(tst_QQuickWebView::transparentWebViews):

  • UIProcess/API/qt/tests/testwindow.h:

(TestWindow::TestWindow):

  • UIProcess/qt/QtPageClient.cpp:

(WebKit::QtPageClient::isViewVisible):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::startDrag):

7:40 AM Changeset in webkit [123475] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

HarfBuzzFaceNG.h forward declarations conflict with newer versions of Harfbuzz
https://bugs.webkit.org/show_bug.cgi?id=92103

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-24
Reviewed by Philippe Normand.

As preparation for enabling harfbuzz-ng for EFL, I would like to include the header
here since the forward declarations are conflicting with the harfbuzz version
we will use for EFL.

No new tests, no change in behavior.

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:
7:33 AM Changeset in webkit [123474] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Updated acid3 layout test results after monospace fix
https://bugs.webkit.org/show_bug.cgi?id=87501

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-24
Reviewed by Alexis Menard.

Updated Qt (same for WK1 and WK2) layout test results for
http/tests/misc/acid3.html after monospace font fix landed in r121971.

  • platform/qt/Skipped: Unskip http/tests/misc/acid3.html.
  • platform/qt/http/tests/misc/acid3-expected.png: Added.
  • platform/qt/http/tests/misc/acid3-expected.txt: Added.
7:17 AM Changeset in webkit [123473] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unskip layout test after monospace-font fix
https://bugs.webkit.org/show_bug.cgi?id=81899

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-24
Reviewed by Alexis Menard.

This test has been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

  • platform/qt/Skipped: Unskipped layout test.
7:07 AM Changeset in webkit [123472] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
6:50 AM Changeset in webkit [123471] by kkristof@inf.u-szeged.hu
  • 2 edits
    9 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r123100. Added baseline to tests that have been unskipped.
https://bugs.webkit.org/show_bug.cgi?id=91739

Patch by János Badics <János Badics> on 2012-07-24

  • platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
  • platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
  • platform/qt-5.0/fast/events/onload-re-entry-expected.png: Added.
  • platform/qt-5.0/fast/events/onload-re-entry-expected.txt: Added.
  • platform/qt-5.0/fast/events/touch/touch-slider-expected.txt: Added.
  • platform/qt-5.0/fast/events/touch/touch-slider-no-js-touch-listener-expected.txt: Added.
  • platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
6:42 AM Changeset in webkit [123470] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r123463.
http://trac.webkit.org/changeset/123463
https://bugs.webkit.org/show_bug.cgi?id=92110

Broke Android build (Requested by keishi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

  • src/WebPagePopupImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseDown):

6:41 AM Changeset in webkit [123469] by kkristof@inf.u-szeged.hu
  • 1 edit
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r123432. Added baseline to fast/text/whitespace/028.html
after is has been unskipped.
https://bugs.webkit.org/show_bug.cgi?id=91971

Patch by János Badics <János Badics> on 2012-07-24

  • platform/qt.5-0/fast/text/whitespace/028-expected.png: Added.
  • platform/qt.5-0/fast/text/whitespace/028-expected.txt: Added.
6:40 AM Changeset in webkit [123468] by rniwa@webkit.org
  • 1 edit
    10 adds in trunk/PerformanceTests

Add some Japanese and Swedish websites to replay tests
https://bugs.webkit.org/show_bug.cgi?id=92076

Reviewed by Andreas Kling.

Added new replay tests as follows.

  • Replay/Japanese: Added.
  • Replay/Japanese/2ch.net-newsplus.replay: Added.
  • Replay/Japanese/ja.wikipedia.org.replay: Added.
  • Replay/Japanese/www.livedoor.com.replay: Added.
  • Replay/Japanese/www.rakuten.co.jp.replay: Added.
  • Replay/Japanese/www.yahoo.co.jp.replay: Added.
  • Replay/Swedish: Added.
  • Replay/Swedish/www.flashback.se.replay: Added.
  • Replay/Swedish/www.tradera.com.replay: Added.
  • Replay/www.techcrunch.com.replay: Added.
6:37 AM Changeset in webkit [123467] by allan.jensen@nokia.com
  • 3 edits in trunk/Source/WebCore

Fix blend filter for autovectorizing
https://bugs.webkit.org/show_bug.cgi?id=91398

Reviewed by Nikolas Zimmermann.

To support auto-vectorizing, the loop had to be unswitched, and regular arrays used that
did not do boundary-checks in the inner loop. Finally the integer division by 255
was optimized not use integer division intrinsics.

On a X86-64 architechture using GCC -O3 on the file, this gives a speed-up of 2.9x.

  • platform/graphics/filters/FEBlend.cpp:

(WebCore::fastDivideBy255):
(BlendNormal):
(WebCore::BlendNormal::apply):
(BlendMultiply):
(WebCore::BlendMultiply::apply):
(BlendScreen):
(WebCore::BlendScreen::apply):
(BlendDarken):
(WebCore::BlendDarken::apply):
(BlendLighten):
(WebCore::BlendLighten::apply):
(BlendUnknown):
(WebCore::BlendUnknown::apply):
(WebCore::platformApply):
(WebCore::FEBlend::platformApplyGeneric):
(WebCore::FEBlend::platformApplySoftware):

  • platform/graphics/filters/FEBlend.h:

(FEBlend):

6:33 AM Changeset in webkit [123466] by kkristof@inf.u-szeged.hu
  • 1 edit
    7 adds
    1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening. Update expectations after r122988 and r122712.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-24

  • platform/qt-5.0-wk2/editing/deleting/5144139-2-expected.txt: Added after r122712.
  • platform/qt-5.0/editing/deleting/5144139-2-expected.txt: Removed.
  • platform/qt-5.0/http/tests/misc/location-replace-crossdomain-expected.png: Added after r122988.
  • platform/qt-5.0/http/tests/misc/location-replace-crossdomain-expected.txt: Added after r122988.
  • platform/qt-5.0/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added after r122988.
  • platform/qt-5.0/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added after r122988.
6:24 AM Changeset in webkit [123465] by Simon Hausmann
  • 3 edits in trunk/Tools

[Qt] MSVC: unresolved external symbol DllMainCRTStartup@12
https://bugs.webkit.org/show_bug.cgi?id=91229

Reviewed by Jocelyn Turcotte.

In order to successfully link a DLL on Windows we need to have at least
one object file (or compilation unit). The forward export header files were
supposed to be that, but unfortunately the rule in win32/default_post.prf for
creating the header files had some bugs, among others that it did an exists()
check on the depending static library. At the time qmake is ran those libraries
do not exist yet and therefore the corresponding extra compiler rules were never
created, resulting in empty OBJECTS/SOURCES.

Even without such an exists() check, qmake extra compilers require the files
referred to in the .input variable to exist at qmake time. In this case the input
files were the static libraries, which do not exist yet.

This patch solves this by using a qmake extra target instead of extra
compiler, which does not have this limitation. The target is referenced
through the extension of GENERATED_SOURCES.

The patch also adds a d/_debug suffix for debug builds, do allow for separate
symbol exports if necessary.

  • Scripts/generate-win32-export-forwards: Support multiple input files, i.e.

consider the last argument to be the output file and everything else input.

  • qmake/mkspecs/features/win32/default_post.prf:
6:14 AM Changeset in webkit [123464] by kbalazs@webkit.org
  • 5 edits in trunk

[Qt] Add quirks for running the web process in a profiler shell, like valgrind
https://bugs.webkit.org/show_bug.cgi?id=87672

Reviewed by Jocelyn Turcotte.

Source/WebKit2:

If environment variables QT_WEBKIT_WEB_PROCESS_COMMAND_PREFIX
and/or QT_WEBKIT_PLUGIN_PROCESS_COMMAND_PREFIX are set, use their
values as the prefix of the command when launching the child process.
Example usage:

export QT_WEB_PROCESS_COMMAND_PREFIX="valgrind --smc-check=all"
./MiniBrowser http://somepage.html
./WebKitTestRunner --no-timeout-at-all some_layouttest.html

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

Tools:

Add --no-timeout-at-all command line switch to not time out no matter how
long the web process does it's job. --no-timeout is not enough for profiling
purposes because it only affects the timeout when we are waiting for the end
of the test. We use another timeout to control how much we wait for the web
process to initialize before and reset after the test and it could also easily
expire when running under valgrind. We should keep the behavior of --no-timeout
to not disable this timout check because --no-timeout is used by performace tests
and those should not wait for the web process to initialize and reset more than
normal tests.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runUntil):

  • WebKitTestRunner/TestController.h:
5:38 AM Changeset in webkit [123463] by keishi@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Page popup should close on mouse down
https://bugs.webkit.org/show_bug.cgi?id=92092

Reviewed by Kent Tamura.

Page popup should close on mouse down because some elements(e.g. <input type=color>) don't have a blur event that
we can hook to hide the page popup when the user clicks on the page.

  • src/WebPagePopupImpl.h:

(WebKit::WebPagePopupImpl::hasSamePopupClient): Returns true if the given WebPagePopupImpl have the same popup client.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseDown): Close all popups when the page is clicked. Checks if the
mouse down event opened the same popup we just closed.

5:26 AM Changeset in webkit [123462] by caio.oliveira@openbossa.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/css/text-transform-select.html should be rebaselined for WK1 and WK2 on Qt 5.0
https://bugs.webkit.org/show_bug.cgi?id=77377

Reviewed by Simon Hausmann.

Test now pass in both WK1 and WK2.

  • platform/qt-5.0/Skipped:
5:25 AM Changeset in webkit [123461] by hans@chromium.org
  • 6 edits
    1 copy
    2 adds in trunk

Speech JavaScript API: Add the SpeechRecognitionResult.emma attribute
https://bugs.webkit.org/show_bug.cgi?id=91743

Reviewed by Adam Barth.

Source/WebCore:

Implement the 'emma' attribute as described in the spec draft at
http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html

Test: fast/speech/scripted/emma.html

  • Modules/speech/SpeechRecognitionResult.cpp:

(WebCore::SpeechRecognitionResult::~SpeechRecognitionResult):
(WebCore):
(WebCore::SpeechRecognitionResult::emma):

  • Modules/speech/SpeechRecognitionResult.h:

(WebCore):
(SpeechRecognitionResult):

  • Modules/speech/SpeechRecognitionResult.idl:
  • WebCore.gypi:
  • bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp:

(WebCore):
(WebCore::V8SpeechRecognitionResult::visitDOMWrapper):

We need to add an implicit reference from the result object to the
emma object to keep the latters DOM tree alive across
garbage-collection.

LayoutTests:

Add layout test for the SpeechRecognitionResult.emma attribute.

  • fast/speech/scripted/emma.html: Added.
  • fast/speech/scripted/emma-expected.txt: Added.
5:09 AM Changeset in webkit [123460] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Skipping tests added in r123343 and adding a test expectation for
an accessibility test added in r123428.

  • platform/gtk/TestExpectations:
5:00 AM Changeset in webkit [123459] by commit-queue@webkit.org
  • 8 edits
    2 adds
    2 deletes in trunk

Web Inspector: Protocol Extension: add getFlowByName command
https://bugs.webkit.org/show_bug.cgi?id=91855

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-07-24
Reviewed by Pavel Feldman.

Source/WebCore:

The "getFlowByName" command should return a NamedFlow for a given document and name.

Test: inspector/styles/protocol-css-regions-commands.html

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayload):

LayoutTests:

Created a single test suite for the WebInspector protocol extension for CSS Regions.

  • inspector/styles/protocol-css-regions-commands-expected.txt: Added.
  • inspector/styles/protocol-css-regions-commands.html: Added.
  • inspector/styles/protocol-getNamedFlowCollection-command-expected.txt: Removed.
  • inspector/styles/protocol-getNamedFlowCollection-command.html: Removed.
  • platform/efl/TestExpectations:
  • platform/qt/Skipped:
4:48 AM Changeset in webkit [123458] by pierre.rossi@gmail.com
  • 4 edits in trunk/Source/WebKit/qt

[Qt][WK1] color input type support
https://bugs.webkit.org/show_bug.cgi?id=91998

Reviewed by Simon Hausmann.

Using QColorDialog. This is private for now, but
it could be exposed via a virtual function in
QWebPage at a later point in a Qt 5 minor release
if there are requests for that.

  • Api/qwebpage.cpp:

(QWebPagePrivate::colorSelectionRequested):

  • Api/qwebpage_p.h:

(QWebPagePrivate):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::createColorChooser):

4:37 AM Changeset in webkit [123457] by peter@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
https://bugs.webkit.org/show_bug.cgi?id=92097

Unreviewed build fix.

WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
but TestDelegate.h forward declares it as a class.

  • DumpRenderTree/chromium/TestRunner/TestDelegate.h:

(WebKit):

4:33 AM Changeset in webkit [123456] by Simon Hausmann
  • 29 edits in trunk

[Qt] Fix compilation against namespaced Qt

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-23
Reviewed by Simon Hausmann.

Source/WebCore:

  • platform/graphics/Font.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/qt/ThirdPartyCookiesQt.h:

Source/WebKit/qt:

  • WebCoreSupport/GeolocationClientQt.h:
  • examples/platformplugin/WebPlugin.h:

Source/WebKit2:

  • Platform/CoreIPC/Connection.h:
  • Platform/PlatformProcessIdentifier.h:
  • Platform/WorkQueue.h:
  • Shared/qt/QtNetworkRequestData.h:
  • Shared/qt/WebEventFactoryQt.h:
  • UIProcess/API/C/qt/WKNativeEvent.h:
  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebnavigationhistory_p.h:
  • UIProcess/API/qt/raw/qrawwebview_p.h:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/Launcher/ThreadLauncher.h:
  • UIProcess/LayerTreeCoordinatorProxy.h:
  • UIProcess/qt/QtViewportHandler.h:
  • UIProcess/qt/QtWebPageSGNode.h:
  • UIProcess/qt/WebColorChooserProxyQt.h:
  • UIProcess/qt/WebGeolocationProviderQt.h:
  • UIProcess/qt/WebPopupMenuProxyQt.h:
  • WebProcess/WebProcess.h:

Tools:

  • QtTestBrowser/launcherwindow.h:
  • WebKitTestRunner/PlatformWebView.h:
4:23 AM Changeset in webkit [123455] by peter@chromium.org
  • 2 edits in trunk/Tools

Update a few Chromium Android contributors in committers.py
https://bugs.webkit.org/show_bug.cgi?id=92090

Reviewed by Kent Tamura.

Add Sami Kyostila, who has been doing significant work on Chromium's
compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and
remove John Grabowski who changed projects, and add my webkit.org alias.

  • Scripts/webkitpy/common/config/committers.py:
4:18 AM Changeset in webkit [123454] by commit-queue@webkit.org
  • 2 edits
    8 deletes in trunk/Source/WebKit2

[EFL][WK2] Remove unneeded WebURLRequestEfl and WebURLResponseEfl
https://bugs.webkit.org/show_bug.cgi?id=92087

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Remove WebURLRequestEfl and WebURLResponseEfl classes
and their corresponding C APIs since we don't need / use
them.

  • Shared/API/c/efl/WKURLRequestEfl.cpp: Removed.
  • Shared/API/c/efl/WKURLRequestEfl.h: Removed.
  • Shared/API/c/efl/WKURLResponseEfl.cpp: Removed.
  • Shared/API/c/efl/WKURLResponseEfl.h: Removed.
  • Shared/efl/WebURLRequestEfl.cpp: Removed.
  • Shared/efl/WebURLRequestEfl.h: Removed.
  • Shared/efl/WebURLResponseEfl.cpp: Removed.
  • Shared/efl/WebURLResponseEfl.h: Removed.
  • UIProcess/API/efl/ewk_url_request.cpp:
4:08 AM Changeset in webkit [123453] by pierre.rossi@gmail.com
  • 4 edits in trunk

[Qt] Enable touch slider when touch events are enabled
https://bugs.webkit.org/show_bug.cgi?id=91013

Reviewed by Kenneth Rohde Christiansen.

TOUCH_SLIDER guards are used in WebCore, so we should really
be setting the corresponding ENABLE define in features.prf.

Source/WebKit2:

  • Target.pri:

Tools:

  • qmake/mkspecs/features/features.prf:
3:33 AM Changeset in webkit [123452] by commit-queue@webkit.org
  • 11 edits
    1 delete in trunk

Web Inspector [JSC]: Enable initiator column in network panel.
https://bugs.webkit.org/show_bug.cgi?id=65533

Patch by Anthony Scian <ascian@rim.com> on 2012-07-24
Reviewed by Vsevolod Vlasov.

Source/WebCore:

With 40118 fixed for webkit, Preferences.displayInitiator should be set to true.
Removed references to it since the optionality is no longer required.

Test: http/tests/inspector/network/network-initiator.html

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshRequest):

  • inspector/front-end/Settings.js:

Source/WebKit/chromium:

With 40118 fixed for webkit, Preferences.displayInitiator should be set to true.
Removed references to it since the optionality is no longer required.

Test: http/tests/inspector/network/network-initiator.html

  • src/js/DevTools.js:

LayoutTests:

Bug https://bugs.webkit.org/show_bug.cgi?id=65105 caused
network-initiator.html to be disabled due to caching CSS information.
Tweaked the test so that reloads could be forced to avoid the cache
copy (thanks to Vsevolod Vlasov for help on this); test works now and
is updated for availability of stack traces fixed in 40118. Consolidated
results into common expected results output.

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.hardReloadPage):
(initialize_InspectorTest.InspectorTest.reloadPage):
(initialize_InspectorTest.InspectorTest._innerReloadPage):

  • http/tests/inspector/network/network-initiator-expected.txt:
  • http/tests/inspector/network/network-initiator.html:
  • platform/chromium/TestExpectations:
  • platform/chromium/http/tests/inspector/network/network-initiated-expected.txt: Removed.
  • platform/mac/TestExpectations:
3:27 AM Changeset in webkit [123451] by gyuyoung.kim@samsung.com
  • 52 edits in trunk/Source/WebCore

Missing *explicit* keyword in dom and page.
https://bugs.webkit.org/show_bug.cgi?id=92074

Reviewed by Kentaro Hara.

Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.

Some files in dom directory can't use explicit keyword because of build breaks.

No new tests. Covered by existing tests.

  • dom/BeforeLoadEvent.h:

(WebCore::BeforeLoadEvent::BeforeLoadEvent):

  • dom/BeforeTextInsertedEvent.h:

(BeforeTextInsertedEvent):

  • dom/ChildListMutationScope.h:

(WebCore::ChildListMutationScope::ChildListMutationScope):

  • dom/ChildNodeList.h:

(ChildNodeList):

  • dom/ClientRect.h:

(ClientRect):

  • dom/ClientRectList.h:

(ClientRectList):

  • dom/ComposedShadowTreeWalker.h:

(ComposedShadowTreeParentWalker):

  • dom/DOMCoreException.h:

(WebCore::DOMCoreException::DOMCoreException):

  • dom/DOMImplementation.h:

(DOMImplementation):

  • dom/DatasetDOMStringMap.h:

(WebCore::DatasetDOMStringMap::DatasetDOMStringMap):

  • dom/DeviceMotionController.h:

(DeviceMotionController):

  • dom/DeviceOrientationController.h:

(DeviceOrientationController):

  • dom/DocumentParser.h:

(DocumentParser):

  • dom/EventException.h:

(WebCore::EventException::EventException):

  • dom/EventListener.h:

(WebCore::EventListener::EventListener):

  • dom/ExceptionBase.h:

(ExceptionBase):

  • dom/GenericEventQueue.h:

(GenericEventQueue):

  • dom/KeyboardEvent.h:

(WebCore::KeypressCommand::KeypressCommand):

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryObjectInfo::MemoryObjectInfo):

  • dom/MessageChannel.h:

(MessageChannel):

  • dom/MessagePort.h:

(MessagePort):

  • dom/MessagePortChannel.h:

(MessagePortChannel):

  • dom/MutationObserver.h:
  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::NamedNodeMap):

  • dom/NodeFilter.h:

(WebCore::NodeFilter::NodeFilter):

  • dom/NodeWithIndex.h:

(WebCore::NodeWithIndex::NodeWithIndex):

  • dom/Range.h:
  • dom/RangeException.h:

(WebCore::RangeException::RangeException):

  • dom/RawDataDocumentParser.h:

(WebCore::RawDataDocumentParser::RawDataDocumentParser):

  • dom/ScriptRunner.h:

(ScriptRunner):

  • dom/SelectorQuery.h:

(SelectorQuery):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/SpaceSplitString.h:

(SpaceSplitStringData):

  • dom/StaticHashSetNodeList.h:

(StaticHashSetNodeList):

  • dom/StaticNodeList.h:

(WebCore::StaticNodeList::StaticNodeList):

  • dom/TransformSource.h:

(TransformSource):

  • dom/TreeScope.h:

(TreeScope):

  • dom/WebKitNamedFlowCollection.h:

(WebKitNamedFlowCollection):

  • page/EventHandler.h:

(EventHandler):

  • page/FocusController.h:

(FocusController):

  • page/FrameView.h:

(FrameView):

  • page/MemoryInfo.h:

(MemoryInfo):

  • page/Page.h:

(Page):

  • page/PageGroup.h:

(PageGroup):

  • page/PrintContext.h:

(PrintContext):

  • page/Settings.h:

(Settings):

  • page/SpeechInput.h:

(SpeechInput):

  • page/SpeechInputResultList.h:

(SpeechInputResultList):

  • page/WebKitAnimation.h:
  • page/WindowFeatures.h:

(WindowFeatures):

  • page/WorkerNavigator.h:

(WorkerNavigator):

3:27 AM Changeset in webkit [123450] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

[EFL] EWebLauncher should not require config.h in the style check
https://bugs.webkit.org/show_bug.cgi?id=92070

Reviewed by Kentaro Hara.

  • Scripts/webkitpy/style/checker.py:

Remove the include rules from the style-check for EWebLauncher because
EWebLauncher is simple EFL application.

3:23 AM Changeset in webkit [123449] by jochen@chromium.or
  • 6 edits
    1 add in trunk/Tools

[Chromium] EventSender shouldn't know about TestShell
https://bugs.webkit.org/show_bug.cgi?id=91449

Reviewed by Adam Barth.

Original patch by Adam Barth.

This patch removes the dependency from EventSender to TestShell. Most
of EventSender works directly with a WebView, but there are a handful
of references to WebViewHost. We don't want to re-use WebViewHost in
ContentShell because we want to use the multi-process embedding
environment for WebViews.

To avoid the dependency on WebViewHost, this patch introduces
TestDelegate, which is an abstract base class for WebViewHost. In
ContentShell, we'll need another object to implement these functions.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::keyDown):
(makeMenuItemStringsFor):
(EventSender::contextClick):

  • DumpRenderTree/chromium/EventSender.h:

(EventSender):
(EventSender::setDelegate):
(EventSender::setWebView):
(EventSender::webview):

  • DumpRenderTree/chromium/TestRunner/TestDelegate.h: Added.

(WebKit):
(TestDelegate):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::fillSpellingSuggestionList):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

2:50 AM Changeset in webkit [123448] by yosin@chromium.org
  • 1 edit
    2 copies in trunk/LayoutTests

[Tests] Copy fast/forms/number/number-change-type-on-focus.html and number-losing-renderer-on-click.html to fast/forms/resources
https://bugs.webkit.org/show_bug.cgi?id=92083

Reviewed by Kent Tamura.

This patch copies two test HTML files in fast/forms/number into JavaScript code directory,
fast/forms/resources:

  • number-change-type-on-focus.html -> common-change-type-on-focus.js
  • number-losing-renderer-on-click.html -> common-losing-renderer-on-click.js
  • fast/forms/resources/common-change-type-on-focus.js: Copied from LayoutTests/fast/forms/number/number-change-type-on-focus.html.
  • fast/forms/resources/common-losing-renderer-on-click.js: Copied from LayoutTests/fast/forms/number/number-losing-renderer-on-click.html.
2:48 AM Changeset in webkit [123447] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Make WebIntents and WebIntentsTag a build option for the build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=91841

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-24
Reviewed by Philippe Normand.

And it will also be disabled when building with --minimal.

  • Scripts/webkitperl/FeatureList.pm:
2:38 AM Changeset in webkit [123446] by yosin@chromium.org
  • 1 edit
    2 moves in trunk/LayoutTests

[Tests] Rename fast/forms/number/number-crash.html to number-losing-renderer-on-click.html
https://bugs.webkit.org/show_bug.cgi?id=92085

Reviewed by Kent Tamura.

This patch renames test file fast/forms/number/number-crash.html to number-losing-renderer-on-click.html
to make test name denotes what test will be done.

  • fast/forms/number/number-crash-expected.txt: Removed.
  • fast/forms/number/number-crash.html: Removed.
  • fast/forms/number/number-losing-renderer-on-click-expected.txt: Copied from LayoutTests/fast/forms/number/number-crash-expected.txt.
  • fast/forms/number/number-losing-renderer-on-click.html: Copied from LayoutTests/fast/forms/number/number-crash.html.
2:25 AM Changeset in webkit [123445] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
2:21 AM Changeset in webkit [123444] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Fix possible crash in didSendRequestForResource
https://bugs.webkit.org/show_bug.cgi?id=92077

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Add NULL check for wkRedirectResponse in
didSendRequestForResource() before using it. The
argument may be NULL if there was no redirection.

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:

(didSendRequestForResource):

2:17 AM Changeset in webkit [123443] by tkent@chromium.org
  • 12 edits in trunk/Source/WebCore

Replace some callsites of shadowAncestorNode() with shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=92060

Reviewed by Hajime Morita.

shadowAncestorNode() is deprecated.

No new tests. This shouldn't change behaviors.

  • html/shadow/MediaControlElements.cpp:

(WebCore::toParentMediaElement):

  • html/shadow/TextControlInnerElements.h:

(WebCore::SpinButtonElement::isEnabledFormControl):
(WebCore::SpinButtonElement::isReadOnlyFormControl):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
(WebCore::RenderThemeEfl::paintMediaMuteButton):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::getMediaElementFromRenderObject):
(WebCore::centerRectVerticallyInParentInputElement):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
Removed an ASSERT() because nullness of o->node() is already asserted.

  • rendering/RenderInputSpeech.cpp:

(WebCore::RenderInputSpeech::paintInputFieldSpeechButton):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaSliderThumb):
Passing shadowHost() to toParentMediaElement(), which accepts 0 and will return 0.
(WebCore::paintMediaVolumeSliderThumb): ditto.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
Remove an ASSERT(input) because input never be null unless o->node() is
null. If o->node() is null, this function crashes.
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
It's ok to ignore "node is a media element" case because this function
works only if node->isMediaControlElement().
(WebCore::RenderThemeMac::paintMediaPlayButton): ditto.
(WebCore::RenderThemeMac::paintMediaSliderTrack): ditto.

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintSearchFieldCancelButton):
Remove an ASSERT(input) because input never be null unless o->node() is
null. If o->node() is null, this function crashes.
(WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): ditto.
(WebCore::RenderThemeSafari::paintSearchFieldResultsButton): ditto.

  • rendering/RenderThemeWinCE.cpp:

(WebCore::mediaElementParent):

2:13 AM Changeset in webkit [123442] by commit-queue@webkit.org
  • 3 edits
    1 move
    1 delete in trunk/Source/WebKit2

[WK2][EFL][GTK] Share WebCoreArgumentCoders for soup-related types
https://bugs.webkit.org/show_bug.cgi?id=92073

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Move WebCoreArgumentCoders for soup-related types such as
ResourceRequest, ResourceResponse and ResourceError from
port specific file to Shared/soup/WebCoreArgumentCodersSoup.cpp.
This way, the different ports using libsoup can share
code and avoid duplication.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • Shared/efl/WebCoreArgumentCodersEfl.cpp: Removed.
  • Shared/soup/WebCoreArgumentCodersSoup.cpp: Renamed from Source/WebKit2/Shared/gtk/WebCoreArgumentCodersGtk.cpp.

(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):

2:09 AM Changeset in webkit [123441] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r123379. Newly added fast/css/sticky/parsing-position-sticky.html fails.
https://bugs.webkit.org/show_bug.cgi?id=92080

Patch by János Badics <János Badics> on 2012-07-24

  • platform/qt/Skipped:
1:55 AM Changeset in webkit [123440] by peter@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Build fix for Android after r123424
https://bugs.webkit.org/show_bug.cgi?id=92082

Unreviewed build fix.

Mark removed the PlatformSupport.h header from ScrollbarThemeChromiumAndroid.cpp
in r123424, while there still are two references left to another method and a
constant. Re-add the include directive.

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
1:44 AM Changeset in webkit [123439] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[JSC] REGRESSION(r122912): CodeGeneratorJS.pm generates wrong code
for static attributes in supplemental IDL files
https://bugs.webkit.org/show_bug.cgi?id=91925

Reviewed by Adam Barth.

r122912 implemented static attributes in CodeGeneratorJS.pm.
However, it generates wrong code for static attributes in supplemental
IDL files. This patch fixes it as shown in JSTestInterface.cpp.
This fix aligns with the fix in CodeGeneratorV8.pm (r123308).

Test: bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):

1:42 AM Changeset in webkit [123438] by gyuyoung.kim@samsung.com
  • 18 edits in trunk/Source/WebCore

Add *explicit* keyword to constructor which has a parameter in bridge, history, loader and plugins.
https://bugs.webkit.org/show_bug.cgi?id=92064

Reviewed by Kentaro Hara.

Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.

No new tests. Covered by existing tests.

  • bridge/IdentifierRep.h:

(WebCore::IdentifierRep::IdentifierRep):

  • history/BackForwardListImpl.h:

(BackForwardListImpl):

  • history/CachedFrame.h:

(CachedFrame):

  • history/HistoryItem.h:

(HistoryItem):

  • loader/DocumentWriter.h:

(DocumentWriter):

  • loader/FrameNetworkingContext.h:

(WebCore::FrameNetworkingContext::FrameNetworkingContext):

  • loader/HistoryController.h:
  • loader/ImageLoader.h:

(ImageLoader):

  • loader/LinkLoader.h:

(LinkLoader):

  • loader/MainResourceLoader.h:

(MainResourceLoader):

  • loader/NavigationAction.h:

(NavigationAction):

  • loader/NavigationScheduler.h:

(NavigationScheduler):

  • loader/PolicyChecker.h:

(PolicyChecker):

  • loader/SubframeLoader.h:

(SubframeLoader):

  • loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):

  • plugins/PluginData.h:

(PluginData):

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::PluginViewBase):

1:24 AM Changeset in webkit [123437] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreview gardening.

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-07-24

  • platform/qt/Skipped:
1:21 AM Changeset in webkit [123436] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipped a test because of a missing feature.

Patch by János Badics <János Badics> on 2012-07-24

  • platform/qt/Skipped:
1:02 AM Changeset in webkit [123435] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

[Qt] Fix conversion from GregorianDateTime to QTime
https://bugs.webkit.org/show_bug.cgi?id=92068

Reviewed by Simon Hausmann.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::convertValueToQVariant):

12:37 AM Changeset in webkit [123434] by arko@motorola.com
  • 26 edits
    14 adds in trunk

Microdata: Implement PropertyNodeList interface.
https://bugs.webkit.org/show_bug.cgi?id=80269

Reviewed by Ryosuke Niwa.

Source/WebCore:

Added support for PropertyNodeList interface. Currently HTMLPropertiesCollection.namedItem(name)
returns NodeList object. Made changes so that it will return PropertyNodeList object.

Implemented propertyNodeList.getValues() method. It returns an array of various values. Its
values are obtained from the "itemValue" DOM property of each of the elements represented by
the object, in tree order.

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#propertynodelist

Tests: fast/dom/MicroData/nameditem-returns-propertynodelist.html

fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element.html
fast/dom/MicroData/propertynodelist-getvalues-test.html
fast/dom/MicroData/propertynodelist-test-add-remove-element.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSMicroDataItemValueCustom.cpp: Added.

(WebCore):
(WebCore::toJS): Added toJS() custom method. Returns Node if itemValue is node else returns String.

  • bindings/v8/custom/V8MicroDataItemValueCustom.cpp: Added.

(WebCore):
(WebCore::toV8): Added toV8 custom code.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::rootNode): Return document if owner node has itemref attribute specified.
(WebCore):
(WebCore::DynamicNodeListCacheBase::ownerNodeHasItemRefAttribute): Returns true if owner node has itemref attribute
specified with root type NodeListRootedAtDocumentIfOwnerHasItemrefAttr.
(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeList::itemWithName): Update itemrefElements cache if root type is
NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr.

  • dom/DynamicNodeList.h: Added m_hasItemRefElements in DynamicNodeListCacheBase to check if itemRefElmenets cache

is valid.
(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::isRootedAtDocument):
(DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::isItemRefElementsCacheValid):
(WebCore::DynamicNodeListCacheBase::setItemRefElementsCacheValid):
(WebCore::DynamicNodeListCacheBase::rootType): Returns cached root type.
(WebCore::DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange): Invalidate NodeListCache on itemref
attribute change.

  • dom/Node.cpp:

(WebCore::Node::propertyNodeList):

  • dom/Node.h:

(WebCore):
(Node):

  • dom/PropertyNodeList.cpp: Added.

(WebCore):
(WebCore::PropertyNodeList::PropertyNodeList):
(WebCore::PropertyNodeList::~PropertyNodeList):
(WebCore::PropertyNodeList::elementIsPropertyOfRefElement): Checks if the testElement is a property of Microdata
item.
(WebCore::PropertyNodeList::updateRefElements):
(WebCore::PropertyNodeList::nodeMatches):
(WebCore::PropertyNodeList::getValues): Returns PropertyValueArray whose values are obtained from the
itemValue DOM property of each of the elements represented by the object, in tree order.

  • dom/PropertyNodeList.h: Added.

(WebCore):
(PropertyNodeList):
(WebCore::PropertyNodeList::create):

  • dom/PropertyNodeList.idl: Added.
  • html/HTMLCollection.cpp:

(WebCore::DynamicNodeListCacheBase::itemCommon): Update itemrefElements cache if its a NodeListCollectionType with
root type NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::properties):
(WebCore):
(WebCore::HTMLElement::getItemRefElements): Returns the ItemRefElements list of given element. Added this
method to share the code between HTMLPropertiesCollection and PropertyNodeList to update itemRefElements.

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::updateRefElements):
(WebCore::HTMLPropertiesCollection::updateNameCache):
(WebCore::HTMLPropertiesCollection::namedItem): Return PropertyNodeList object instead of NodeList.
(WebCore::HTMLPropertiesCollection::hasNamedItem): Return true if it finds an item with given
name in the properties collection.

  • html/HTMLPropertiesCollection.h: Removed m_hasItemRefElements member variable, now DynamicNodeListCacheBase

has isItemRefElementsCacheValid. Also removed m_hasPropertyNameCache, as DynamicNodeListCacheBase already has
hasNameCache() and setHasNameCache().
(WebCore):
(HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::invalidateCache):
(WebCore::HTMLPropertiesCollection::updatePropertyCache):

  • html/HTMLPropertiesCollection.idl:
  • html/MicroDataItemValue.idl: Added.
  • page/DOMWindow.idl:

LayoutTests:

Added test cases for PropertyNodeList interface and PropertyNodeList.getValues() method.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#propertynodelist

  • fast/dom/MicroData/nameditem-returns-propertynodelist-expected.txt: Added.
  • fast/dom/MicroData/nameditem-returns-propertynodelist.html: Added.
  • fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element-expected.txt: Added.
  • fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element.html: Added.
  • fast/dom/MicroData/propertynodelist-getvalues-test-expected.txt: Added.
  • fast/dom/MicroData/propertynodelist-getvalues-test.html: Added.
  • fast/dom/MicroData/propertynodelist-test-add-remove-element-expected.txt: Added.
  • fast/dom/MicroData/propertynodelist-test-add-remove-element.html: Added.
12:21 AM Changeset in webkit [123433] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[JSC] REGRESSION(r122912): CodeGeneratorJS.pm should not
implicitly assume ScriptExecutionContext for static attributes
https://bugs.webkit.org/show_bug.cgi?id=91924

Reviewed by Adam Barth.

r122912 implemented static attributes in CodeGeneratorJS.pm.
However, the generated code assumes that static attributes
always require ScriptExecutionContext, which is wrong.
If we need a ScriptExecutionContext, we should specify
[CallWith=ScriptExecutionContext].

This patch fixes CodeGeneratorJS.pm so that static attributes
do not assume ScriptExecutionContext. This fix aligns with
the fix in CodeGeneratorV8.pm in r123308.

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjConstructorStaticReadOnlyIntAttr):
(WebCore::jsTestObjConstructorStaticStringAttr):
(WebCore::setJSTestObjConstructorStaticStringAttr):

12:11 AM Changeset in webkit [123432] by kkristof@inf.u-szeged.hu
  • 467 edits
    5 copies
    77 adds in trunk/LayoutTests

[Qt] from platform/qt/fast/overflow to platform/qt/fast/xsl tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91971

Unreviewed rebaseline.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-23

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/fast/overflow/001-expected.png: Added.
  • platform/qt/fast/overflow/001-expected.txt:
  • platform/qt/fast/overflow/002-expected.png: Added.
  • platform/qt/fast/overflow/002-expected.txt:
  • platform/qt/fast/overflow/004-expected.png:
  • platform/qt/fast/overflow/004-expected.txt:
  • platform/qt/fast/overflow/006-expected.png: Added.
  • platform/qt/fast/overflow/006-expected.txt:
  • platform/qt/fast/overflow/007-expected.png:
  • platform/qt/fast/overflow/007-expected.txt:
  • platform/qt/fast/overflow/008-expected.png: Added.
  • platform/qt/fast/overflow/008-expected.txt:
  • platform/qt/fast/overflow/border-radius-clipping-expected.png: Added.
  • platform/qt/fast/overflow/border-radius-clipping-expected.txt:
  • platform/qt/fast/overflow/childFocusRingClip-expected.png: Added.
  • platform/qt/fast/overflow/childFocusRingClip-expected.txt:
  • platform/qt/fast/overflow/dynamic-hidden-expected.png: Added.
  • platform/qt/fast/overflow/dynamic-hidden-expected.txt:
  • platform/qt/fast/overflow/float-in-relpositioned-expected.png: Added.
  • platform/qt/fast/overflow/float-in-relpositioned-expected.txt:
  • platform/qt/fast/overflow/hidden-scrollbar-resize-expected.png: Added.
  • platform/qt/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/qt/fast/overflow/hit-test-overflow-controls-expected.png: Added.
  • platform/qt/fast/overflow/hit-test-overflow-controls-expected.txt:
  • platform/qt/fast/overflow/image-selection-highlight-expected.png:
  • platform/qt/fast/overflow/image-selection-highlight-expected.txt:
  • platform/qt/fast/overflow/infiniteRecursion-expected.png:
  • platform/qt/fast/overflow/infiniteRecursion-expected.txt:
  • platform/qt/fast/overflow/line-clamp-expected.png:
  • platform/qt/fast/overflow/line-clamp-expected.txt:
  • platform/qt/fast/overflow/overflow-auto-position-absolute-expected.png: Added.
  • platform/qt/fast/overflow/overflow-auto-position-absolute-expected.txt:
  • platform/qt/fast/overflow/overflow-auto-table-expected.png:
  • platform/qt/fast/overflow/overflow-auto-table-expected.txt:
  • platform/qt/fast/overflow/overflow-float-stacking-expected.png: Added.
  • platform/qt/fast/overflow/overflow-float-stacking-expected.txt:
  • platform/qt/fast/overflow/overflow-focus-ring-expected.png:
  • platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/qt/fast/overflow/overflow-rtl-inline-scrollbar-expected.png: Added.
  • platform/qt/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt:
  • platform/qt/fast/overflow/overflow-stacking-expected.png: Added.
  • platform/qt/fast/overflow/overflow-stacking-expected.txt:
  • platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
  • platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
  • platform/qt/fast/overflow/scrollbar-position-update-expected.png: Added.
  • platform/qt/fast/overflow/scrollbar-position-update-expected.txt:
  • platform/qt/fast/overflow/table-overflow-float-expected.png:
  • platform/qt/fast/overflow/table-overflow-float-expected.txt:
  • platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
  • platform/qt/fast/parser/001-expected.png:
  • platform/qt/fast/parser/001-expected.txt:
  • platform/qt/fast/parser/bad-xml-slash-expected.png: Copied from LayoutTests/platform/qt/fast/text/whitespace/023-expected.png.
  • platform/qt/fast/parser/bad-xml-slash-expected.txt:
  • platform/qt/fast/parser/broken-comments-vs-parsing-mode-expected.png: Added.
  • platform/qt/fast/parser/broken-comments-vs-parsing-mode-expected.txt:
  • platform/qt/fast/parser/document-write-option-expected.png: Added.
  • platform/qt/fast/parser/document-write-option-expected.txt:
  • platform/qt/fast/parser/entity-comment-in-style-expected.png: Added.
  • platform/qt/fast/parser/entity-comment-in-style-expected.txt:
  • platform/qt/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/qt/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/qt/fast/parser/nofoo-tags-inside-paragraph-expected.png: Added.
  • platform/qt/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
  • platform/qt/fast/parser/open-comment-in-style-expected.png: Added.
  • platform/qt/fast/parser/open-comment-in-style-expected.txt:
  • platform/qt/fast/parser/open-comment-in-textarea-expected.png:
  • platform/qt/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/qt/fast/parser/title-error-test-expected.png: Added.
  • platform/qt/fast/parser/title-error-test-expected.txt:
  • platform/qt/fast/reflections/abs-position-in-reflection-expected.png: Added.
  • platform/qt/fast/reflections/abs-position-in-reflection-expected.txt:
  • platform/qt/fast/reflections/inline-crash-expected.png: Added.
  • platform/qt/fast/reflections/inline-crash-expected.txt:
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.png:
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.txt:
  • platform/qt/fast/reflections/reflection-nesting-expected.png: Added.
  • platform/qt/fast/reflections/reflection-nesting-expected.txt:
  • platform/qt/fast/reflections/reflection-overflow-hidden-expected.png: Added.
  • platform/qt/fast/reflections/reflection-overflow-hidden-expected.txt:
  • platform/qt/fast/reflections/transparent-reflected-sublayers-expected.png: Added.
  • platform/qt/fast/reflections/transparent-reflected-sublayers-expected.txt:
  • platform/qt/fast/repaint/4774354-expected.png:
  • platform/qt/fast/repaint/4774354-expected.txt:
  • platform/qt/fast/repaint/4776765-expected.png:
  • platform/qt/fast/repaint/4776765-expected.txt:
  • platform/qt/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/qt/fast/repaint/backgroundSizeRepaint-expected.txt:
  • platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/qt/fast/repaint/body-background-image-expected.png:
  • platform/qt/fast/repaint/body-background-image-expected.txt:
  • platform/qt/fast/repaint/border-fit-lines-expected.png:
  • platform/qt/fast/repaint/border-fit-lines-expected.txt:
  • platform/qt/fast/repaint/border-radius-repaint-expected.png:
  • platform/qt/fast/repaint/border-radius-repaint-expected.txt:
  • platform/qt/fast/repaint/border-repaint-glitch-expected.png:
  • platform/qt/fast/repaint/border-repaint-glitch-expected.txt:
  • platform/qt/fast/repaint/box-shadow-dynamic-expected.png:
  • platform/qt/fast/repaint/box-shadow-dynamic-expected.txt:
  • platform/qt/fast/repaint/bugzilla-3509-expected.png:
  • platform/qt/fast/repaint/bugzilla-3509-expected.txt:
  • platform/qt/fast/repaint/bugzilla-5699-expected.png:
  • platform/qt/fast/repaint/bugzilla-5699-expected.txt:
  • platform/qt/fast/repaint/bugzilla-6278-expected.png:
  • platform/qt/fast/repaint/bugzilla-6278-expected.txt:
  • platform/qt/fast/repaint/bugzilla-6388-expected.png:
  • platform/qt/fast/repaint/bugzilla-6388-expected.txt:
  • platform/qt/fast/repaint/bugzilla-6473-expected.png:
  • platform/qt/fast/repaint/bugzilla-6473-expected.txt:
  • platform/qt/fast/repaint/bugzilla-7235-expected.png:
  • platform/qt/fast/repaint/bugzilla-7235-expected.txt:
  • platform/qt/fast/repaint/caret-outside-block-expected.png:
  • platform/qt/fast/repaint/caret-outside-block-expected.txt:
  • platform/qt/fast/repaint/change-transform-expected.png:
  • platform/qt/fast/repaint/change-transform-expected.txt:
  • platform/qt/fast/repaint/clipped-relative-expected.png:
  • platform/qt/fast/repaint/clipped-relative-expected.txt:
  • platform/qt/fast/repaint/containing-block-position-change-expected.png:
  • platform/qt/fast/repaint/containing-block-position-change-expected.txt:
  • platform/qt/fast/repaint/control-clip-expected.png:
  • platform/qt/fast/repaint/control-clip-expected.txt:
  • platform/qt/fast/repaint/create-layer-repaint-expected.png:
  • platform/qt/fast/repaint/create-layer-repaint-expected.txt:
  • platform/qt/fast/repaint/delete-into-nested-block-expected.png:
  • platform/qt/fast/repaint/delete-into-nested-block-expected.txt:
  • platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt:
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/float-move-during-layout-expected.png:
  • platform/qt/fast/repaint/float-move-during-layout-expected.txt:
  • platform/qt/fast/repaint/focus-layers-expected.png:
  • platform/qt/fast/repaint/focus-layers-expected.txt:
  • platform/qt/fast/repaint/inline-color-change-expected.png:
  • platform/qt/fast/repaint/inline-color-change-expected.txt:
  • platform/qt/fast/repaint/inline-outline-repaint-expected.png:
  • platform/qt/fast/repaint/inline-outline-repaint-expected.txt:
  • platform/qt/fast/repaint/layout-state-relative-expected.png:
  • platform/qt/fast/repaint/layout-state-relative-expected.txt:
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/qt/fast/repaint/line-overflow-expected.png:
  • platform/qt/fast/repaint/line-overflow-expected.txt:
  • platform/qt/fast/repaint/list-marker-2-expected.png:
  • platform/qt/fast/repaint/list-marker-2-expected.txt:
  • platform/qt/fast/repaint/make-children-non-inline-expected.png:
  • platform/qt/fast/repaint/make-children-non-inline-expected.txt:
  • platform/qt/fast/repaint/multicol-repaint-expected.png:
  • platform/qt/fast/repaint/multicol-repaint-expected.txt:
  • platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png:
  • platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt:
  • platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.png:
  • platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.txt:
  • platform/qt/fast/repaint/outline-child-repaint-expected.png:
  • platform/qt/fast/repaint/outline-child-repaint-expected.txt:
  • platform/qt/fast/repaint/outline-inset-expected.png:
  • platform/qt/fast/repaint/outline-inset-expected.txt:
  • platform/qt/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/qt/fast/repaint/outline-repaint-glitch-expected.txt:
  • platform/qt/fast/repaint/outline-shrinking-expected.png:
  • platform/qt/fast/repaint/outline-shrinking-expected.txt:
  • platform/qt/fast/repaint/overflow-delete-line-expected.png:
  • platform/qt/fast/repaint/overflow-delete-line-expected.txt:
  • platform/qt/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/qt/fast/repaint/overflow-scroll-body-appear-expected.txt:
  • platform/qt/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/qt/fast/repaint/overflow-scroll-delete-expected.txt:
  • platform/qt/fast/repaint/positioned-document-element-expected.png:
  • platform/qt/fast/repaint/positioned-document-element-expected.txt:
  • platform/qt/fast/repaint/reflection-redraw-expected.png:
  • platform/qt/fast/repaint/reflection-redraw-expected.txt:
  • platform/qt/fast/repaint/region-painting-invalidation-expected.png:
  • platform/qt/fast/repaint/region-painting-invalidation-expected.txt:
  • platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
  • platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt:
  • platform/qt/fast/repaint/repaint-resized-overflow-expected.png:
  • platform/qt/fast/repaint/repaint-resized-overflow-expected.txt:
  • platform/qt/fast/repaint/scale-page-shrink-expected.png:
  • platform/qt/fast/repaint/scale-page-shrink-expected.txt:
  • platform/qt/fast/repaint/search-field-cancel-expected.png:
  • platform/qt/fast/repaint/search-field-cancel-expected.txt:
  • platform/qt/fast/repaint/select-option-background-color-expected.png:
  • platform/qt/fast/repaint/select-option-background-color-expected.txt:
  • platform/qt/fast/repaint/selected-replaced-expected.png:
  • platform/qt/fast/repaint/selected-replaced-expected.txt:
  • platform/qt/fast/repaint/selection-after-delete-expected.png:
  • platform/qt/fast/repaint/selection-after-delete-expected.txt:
  • platform/qt/fast/repaint/selection-after-remove-expected.png:
  • platform/qt/fast/repaint/selection-after-remove-expected.txt:
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
  • platform/qt/fast/repaint/selection-rl-expected.png:
  • platform/qt/fast/repaint/selection-rl-expected.txt:
  • platform/qt/fast/repaint/stacked-diacritics-expected.png:
  • platform/qt/fast/repaint/stacked-diacritics-expected.txt:
  • platform/qt/fast/repaint/subtree-layoutstate-transform-expected.png:
  • platform/qt/fast/repaint/subtree-layoutstate-transform-expected.txt:
  • platform/qt/fast/repaint/subtree-root-skipped-expected.png:
  • platform/qt/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/qt/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/qt/fast/repaint/table-cell-collapsed-border-expected.txt:
  • platform/qt/fast/repaint/table-cell-move-expected.png:
  • platform/qt/fast/repaint/table-cell-move-expected.txt:
  • platform/qt/fast/repaint/table-collapsed-border-expected.png:
  • platform/qt/fast/repaint/table-collapsed-border-expected.txt:
  • platform/qt/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/qt/fast/repaint/table-extra-bottom-grow-expected.txt:
  • platform/qt/fast/repaint/text-append-dirty-lines-expected.png:
  • platform/qt/fast/repaint/text-append-dirty-lines-expected.txt:
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
  • platform/qt/fast/repaint/transform-relative-position-expected.png:
  • platform/qt/fast/repaint/transform-relative-position-expected.txt:
  • platform/qt/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/qt/fast/repaint/transform-repaint-descendants-expected.txt:
  • platform/qt/fast/repaint/transform-translate-expected.png:
  • platform/qt/fast/repaint/transform-translate-expected.txt:
  • platform/qt/fast/replaced/001-expected.png:
  • platform/qt/fast/replaced/001-expected.txt:
  • platform/qt/fast/replaced/002-expected.png:
  • platform/qt/fast/replaced/002-expected.txt:
  • platform/qt/fast/replaced/003-expected.png:
  • platform/qt/fast/replaced/003-expected.txt:
  • platform/qt/fast/replaced/004-expected.png:
  • platform/qt/fast/replaced/004-expected.txt:
  • platform/qt/fast/replaced/005-expected.png:
  • platform/qt/fast/replaced/005-expected.txt:
  • platform/qt/fast/replaced/006-expected.png:
  • platform/qt/fast/replaced/006-expected.txt:
  • platform/qt/fast/replaced/007-expected.png:
  • platform/qt/fast/replaced/007-expected.txt:
  • platform/qt/fast/replaced/absolute-image-sizing-expected.png:
  • platform/qt/fast/replaced/absolute-image-sizing-expected.txt:
  • platform/qt/fast/replaced/absolute-position-percentage-height-expected.png:
  • platform/qt/fast/replaced/absolute-position-percentage-height-expected.txt:
  • platform/qt/fast/replaced/absolute-position-percentage-width-expected.png:
  • platform/qt/fast/replaced/absolute-position-percentage-width-expected.txt:
  • platform/qt/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/qt/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.txt:
  • platform/qt/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/qt/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.txt:
  • platform/qt/fast/replaced/applet-disabled-positioned-expected.png:
  • platform/qt/fast/replaced/applet-disabled-positioned-expected.txt:
  • platform/qt/fast/replaced/applet-display-none-expected.png:
  • platform/qt/fast/replaced/applet-display-none-expected.txt:
  • platform/qt/fast/replaced/applet-rendering-java-disabled-expected.png:
  • platform/qt/fast/replaced/applet-rendering-java-disabled-expected.txt:
  • platform/qt/fast/replaced/border-radius-clip-expected.png:
  • platform/qt/fast/replaced/border-radius-clip-expected.txt:
  • platform/qt/fast/replaced/embed-display-none-expected.png:
  • platform/qt/fast/replaced/embed-display-none-expected.txt:
  • platform/qt/fast/replaced/image-resize-width-expected.png:
  • platform/qt/fast/replaced/image-resize-width-expected.txt:
  • platform/qt/fast/replaced/image-sizing-expected.png:
  • platform/qt/fast/replaced/image-sizing-expected.txt:
  • platform/qt/fast/replaced/inline-box-wrapper-handover-expected.png:
  • platform/qt/fast/replaced/inline-box-wrapper-handover-expected.txt:
  • platform/qt/fast/replaced/max-width-percent-expected.png:
  • platform/qt/fast/replaced/max-width-percent-expected.txt:
  • platform/qt/fast/replaced/maxheight-percent-expected.png:
  • platform/qt/fast/replaced/maxheight-percent-expected.txt:
  • platform/qt/fast/replaced/maxheight-pxs-expected.png:
  • platform/qt/fast/replaced/maxheight-pxs-expected.txt:
  • platform/qt/fast/replaced/maxwidth-percent-expected.png:
  • platform/qt/fast/replaced/maxwidth-percent-expected.txt:
  • platform/qt/fast/replaced/maxwidth-pxs-expected.png:
  • platform/qt/fast/replaced/maxwidth-pxs-expected.txt:
  • platform/qt/fast/replaced/minheight-percent-expected.png:
  • platform/qt/fast/replaced/minheight-percent-expected.txt:
  • platform/qt/fast/replaced/minheight-pxs-expected.png:
  • platform/qt/fast/replaced/minheight-pxs-expected.txt:
  • platform/qt/fast/replaced/minwidth-percent-expected.png:
  • platform/qt/fast/replaced/minwidth-percent-expected.txt:
  • platform/qt/fast/replaced/minwidth-pxs-expected.png:
  • platform/qt/fast/replaced/minwidth-pxs-expected.txt:
  • platform/qt/fast/replaced/object-align-hspace-vspace-expected.png:
  • platform/qt/fast/replaced/object-align-hspace-vspace-expected.txt:
  • platform/qt/fast/replaced/object-display-none-expected.png:
  • platform/qt/fast/replaced/object-display-none-expected.txt:
  • platform/qt/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png:
  • platform/qt/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/qt/fast/replaced/percent-height-in-anonymous-block-widget-expected.png:
  • platform/qt/fast/replaced/percent-height-in-anonymous-block-widget-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/qt/fast/replaced/replaced-child-of-absolute-with-auto-height-expected.png:
  • platform/qt/fast/replaced/replaced-child-of-absolute-with-auto-height-expected.txt:
  • platform/qt/fast/replaced/selection-rect-in-table-cell-expected.png:
  • platform/qt/fast/replaced/selection-rect-in-table-cell-expected.txt:
  • platform/qt/fast/replaced/selection-rect-transform-expected.png:
  • platform/qt/fast/replaced/selection-rect-transform-expected.txt:
  • platform/qt/fast/replaced/three-selects-break-expected.png:
  • platform/qt/fast/replaced/three-selects-break-expected.txt:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.txt:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.txt:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.txt:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.txt:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.txt:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.txt:
  • platform/qt/fast/replaced/width100percent-button-expected.png:
  • platform/qt/fast/replaced/width100percent-button-expected.txt:
  • platform/qt/fast/replaced/width100percent-checkbox-expected.png:
  • platform/qt/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/qt/fast/replaced/width100percent-image-expected.png:
  • platform/qt/fast/replaced/width100percent-image-expected.txt:
  • platform/qt/fast/replaced/width100percent-radio-expected.png: Added.
  • platform/qt/fast/replaced/width100percent-radio-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.png:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/qt/fast/replaced/width100percent-textfield-expected.png:
  • platform/qt/fast/replaced/width100percent-textfield-expected.txt:
  • platform/qt/fast/ruby/ruby-inline-table-expected.png:
  • platform/qt/fast/ruby/ruby-inline-table-expected.txt:
  • platform/qt/fast/ruby/ruby-text-before-after-content-expected.png:
  • platform/qt/fast/ruby/ruby-text-before-after-content-expected.txt:
  • platform/qt/fast/runin/001-expected.png:
  • platform/qt/fast/runin/001-expected.txt:
  • platform/qt/fast/runin/generated-expected.png:
  • platform/qt/fast/runin/generated-expected.txt:
  • platform/qt/fast/runin/generated2-expected.png:
  • platform/qt/fast/runin/generated2-expected.txt:
  • platform/qt/fast/runin/generated3-expected.png:
  • platform/qt/fast/runin/generated3-expected.txt:
  • platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.png:
  • platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt:
  • platform/qt/fast/text/atsui-kerning-and-ligatures-expected.png: Added.
  • platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png:
  • platform/qt/fast/text/backslash-to-yen-sign-dynamic-expected.png:
  • platform/qt/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/qt/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/qt/fast/text/backslash-to-yen-sign-expected.png:
  • platform/qt/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/qt/fast/text/basic/001-expected.png:
  • platform/qt/fast/text/basic/002-expected.png: Added.
  • platform/qt/fast/text/basic/003-expected.png:
  • platform/qt/fast/text/basic/003-expected.txt:
  • platform/qt/fast/text/basic/004-expected.png: Added.
  • platform/qt/fast/text/basic/005-expected.png: Added.
  • platform/qt/fast/text/basic/006-expected.png: Added.
  • platform/qt/fast/text/basic/007-expected.png: Added.
  • platform/qt/fast/text/basic/008-expected.png: Added.
  • platform/qt/fast/text/basic/009-expected.png:
  • platform/qt/fast/text/basic/011-expected.png: Added.
  • platform/qt/fast/text/basic/012-expected.png: Added.
  • platform/qt/fast/text/basic/generic-family-changes-expected.png:
  • platform/qt/fast/text/basic/generic-family-reset-expected.png:
  • platform/qt/fast/text/break-word-expected.png:
  • platform/qt/fast/text/capitalize-empty-generated-string-expected.png: Added.
  • platform/qt/fast/text/capitalize-preserve-nbsp-expected.png: Added.
  • platform/qt/fast/text/cg-vs-atsui-expected.png:
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.png:
  • platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png:
  • platform/qt/fast/text/complex-text-opacity-expected.png:
  • platform/qt/fast/text/complex-text-opacity-expected.txt:
  • platform/qt/fast/text/delete-hard-break-character-expected.png: Added.
  • platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.png:
  • platform/qt/fast/text/fake-italic-expected.png: Added.
  • platform/qt/fast/text/fallback-traits-fixup-expected.png: Added.
  • platform/qt/fast/text/fallback-traits-fixup-expected.txt:
  • platform/qt/fast/text/firstline/001-expected.png: Added.
  • platform/qt/fast/text/firstline/002-expected.png: Added.
  • platform/qt/fast/text/firstline/003-expected.png: Added.
  • platform/qt/fast/text/font-initial-expected.png: Added.
  • platform/qt/fast/text/hyphenate-limit-before-after-expected.png:
  • platform/qt/fast/text/hyphenate-limit-lines-expected.png:
  • platform/qt/fast/text/international/arabic-justify-expected.png: Added.
  • platform/qt/fast/text/international/arabic-justify-expected.txt:
  • platform/qt/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/qt/fast/text/international/hindi-whitespace-expected.txt:
  • platform/qt/fast/text/international/text-spliced-font-expected.png:
  • platform/qt/fast/text/international/text-spliced-font-expected.txt:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/qt/fast/text/justified-selection-at-edge-expected.png: Added.
  • platform/qt/fast/text/justified-selection-expected.png: Added.
  • platform/qt/fast/text/large-text-composed-char-expected.png:
  • platform/qt/fast/text/large-text-composed-char-expected.txt:
  • platform/qt/fast/text/letter-spacing-negative-opacity-expected.png:
  • platform/qt/fast/text/letter-spacing-negative-opacity-expected.txt:
  • platform/qt/fast/text/line-breaks-after-white-space-expected.png:
  • platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/multicol-repaint-expected.png.
  • platform/qt/fast/text/midword-break-hang-expected.png: Added.
  • platform/qt/fast/text/reset-emptyRun-expected.png: Added.
  • platform/qt/fast/text/selection-hard-linebreak-expected.png:
  • platform/qt/fast/text/shadow-no-blur-expected.png:
  • platform/qt/fast/text/shadow-translucent-fill-expected.png: Added.
  • platform/qt/fast/text/should-use-atsui-expected.png: Added.
  • platform/qt/fast/text/softHyphen-expected.png: Added.
  • platform/qt/fast/text/softHyphen-expected.txt:
  • platform/qt/fast/text/stroking-decorations-expected.png: Added.
  • platform/qt/fast/text/stroking-expected.png: Added.
  • platform/qt/fast/text/text-letter-spacing-expected.png:
  • platform/qt/fast/text/text-letter-spacing-expected.txt:
  • platform/qt/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/qt/fast/text/textIteratorNilRenderer-expected.png:
  • platform/qt/fast/text/unicode-variation-selector-expected.png:
  • platform/qt/fast/text/wbr-expected.png: Added.
  • platform/qt/fast/text/wbr-in-pre-crash-expected.png: Added.
  • platform/qt/fast/text/wbr-pre-expected.png:
  • platform/qt/fast/text/wbr-styled-expected.png:
  • platform/qt/fast/text/whitespace/002-expected.png:
  • platform/qt/fast/text/whitespace/003-expected.png:
  • platform/qt/fast/text/whitespace/006-expected.png: Added.
  • platform/qt/fast/text/whitespace/007-expected.png: Added.
  • platform/qt/fast/text/whitespace/008-expected.png: Added.
  • platform/qt/fast/text/whitespace/009-expected.png: Added.
  • platform/qt/fast/text/whitespace/012-expected.png:
  • platform/qt/fast/text/whitespace/013-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/multicol-repaint-expected.png.
  • platform/qt/fast/text/whitespace/014-expected.png: Copied from LayoutTests/platform/qt/fast/replaced/three-selects-break-expected.png.
  • platform/qt/fast/text/whitespace/018-expected.png: Added.
  • platform/qt/fast/text/whitespace/020-expected.png: Added.
  • platform/qt/fast/text/whitespace/021-expected.png: Added.
  • platform/qt/fast/text/whitespace/022-expected.png:
  • platform/qt/fast/text/whitespace/023-expected.png:
  • platform/qt/fast/text/whitespace/025-expected.png: Added.
  • platform/qt/fast/text/whitespace/026-expected.png: Added.
  • platform/qt/fast/text/whitespace/027-expected.png: Added.
  • platform/qt/fast/text/whitespace/030-expected.png:
  • platform/qt/fast/text/whitespace/nbsp-mode-and-linewraps-expected.png: Added.
  • platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/qt/fast/text/whitespace/nowrap-clear-float-expected.png: Added.
  • platform/qt/fast/text/whitespace/pre-break-word-expected.png:
  • platform/qt/fast/text/whitespace/pre-newline-box-test-expected.png:
  • platform/qt/fast/text/whitespace/pre-wrap-last-char-expected.png: Added.
  • platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png:
  • platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
  • platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • platform/qt/fast/text/whitespace/span-in-word-space-causes-overflow-expected.png: Added.
  • platform/qt/fast/text/word-break-expected.png:
  • platform/qt/fast/text/word-break-expected.txt:
  • platform/qt/fast/text/zero-font-size-expected.png:
  • platform/qt/fast/text/zero-font-size-expected.txt:
  • platform/qt/fast/tokenizer/001-expected.png:
  • platform/qt/fast/tokenizer/001-expected.txt:
  • platform/qt/fast/tokenizer/003-expected.png:
  • platform/qt/fast/tokenizer/003-expected.txt:
  • platform/qt/fast/transforms/bounding-rect-zoom-expected.png: Added.
  • platform/qt/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/qt/fast/transforms/diamond-expected.png:
  • platform/qt/fast/transforms/diamond-expected.txt:
  • platform/qt/fast/transforms/identity-matrix-expected.png:
  • platform/qt/fast/transforms/identity-matrix-expected.txt:
  • platform/qt/fast/transforms/overflow-with-transform-expected.png:
  • platform/qt/fast/transforms/overflow-with-transform-expected.txt:
  • platform/qt/fast/transforms/skew-with-unitless-zero-expected.png:
  • platform/qt/fast/transforms/skew-with-unitless-zero-expected.txt:
  • platform/qt/fast/transforms/transform-on-inline-expected.png:
  • platform/qt/fast/transforms/transform-on-inline-expected.txt:
  • platform/qt/fast/transforms/transform-overflow-expected.png:
  • platform/qt/fast/transforms/transform-overflow-expected.txt:
  • platform/qt/fast/transforms/transform-positioned-ancestor-expected.png:
  • platform/qt/fast/transforms/transform-positioned-ancestor-expected.txt:
  • platform/qt/fast/transforms/transform-table-row-expected.png:
  • platform/qt/fast/transforms/transform-table-row-expected.txt:
  • platform/qt/fast/transforms/transformed-caret-expected.png:
  • platform/qt/fast/transforms/transformed-caret-expected.txt:
  • platform/qt/fast/transforms/transformed-document-element-expected.png:
  • platform/qt/fast/transforms/transformed-document-element-expected.txt:
  • platform/qt/fast/transforms/transforms-with-opacity-expected.png:
  • platform/qt/fast/transforms/transforms-with-opacity-expected.txt:
  • platform/qt/fast/transforms/transforms-with-zoom-expected.png:
  • platform/qt/fast/transforms/transforms-with-zoom-expected.txt:
  • platform/qt/fast/writing-mode/background-horizontal-bt-expected.png:
  • platform/qt/fast/writing-mode/background-horizontal-bt-expected.txt:
  • platform/qt/fast/writing-mode/background-vertical-lr-expected.png:
  • platform/qt/fast/writing-mode/background-vertical-lr-expected.txt:
  • platform/qt/fast/writing-mode/background-vertical-rl-expected.png:
  • platform/qt/fast/writing-mode/background-vertical-rl-expected.txt:
  • platform/qt/fast/writing-mode/basic-vertical-line-expected.png:
  • platform/qt/fast/writing-mode/basic-vertical-line-expected.txt:
  • platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
  • platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.txt:
  • platform/qt/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-horizontal-bt-expected.txt:
  • platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.txt:
  • platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.txt:
  • platform/qt/fast/writing-mode/english-bt-text-expected.png:
  • platform/qt/fast/writing-mode/english-bt-text-expected.txt:
  • platform/qt/fast/writing-mode/english-lr-text-expected.png:
  • platform/qt/fast/writing-mode/english-lr-text-expected.txt:
  • platform/qt/fast/writing-mode/english-rl-text-expected.png:
  • platform/qt/fast/writing-mode/english-rl-text-expected.txt:
  • platform/qt/fast/writing-mode/fallback-orientation-expected.png:
  • platform/qt/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/qt/fast/writing-mode/fieldsets-expected.png:
  • platform/qt/fast/writing-mode/fieldsets-expected.txt:
  • platform/qt/fast/writing-mode/horizontal-bt-replaced-selection-expected.png:
  • platform/qt/fast/writing-mode/horizontal-bt-replaced-selection-expected.txt:
  • platform/qt/fast/writing-mode/vertical-lr-replaced-selection-expected.png:
  • platform/qt/fast/writing-mode/vertical-lr-replaced-selection-expected.txt:
  • platform/qt/fast/writing-mode/vertical-rl-replaced-selection-expected.png:
  • platform/qt/fast/writing-mode/vertical-rl-replaced-selection-expected.txt:
  • platform/qt/fast/xsl/document-function-expected.png: Added.
  • platform/qt/fast/xsl/document-function-expected.txt:
  • platform/qt/fast/xsl/xslt-entity-expected.png: Copied from LayoutTests/platform/qt/fast/text/whitespace/023-expected.png.
  • platform/qt/fast/xsl/xslt-entity-expected.txt:

Jul 23, 2012:

11:43 PM Changeset in webkit [123431] by tkent@chromium.org
  • 2 edits in trunk

[GTK] Remove unnecessary trailing space in the previous commit.

  • Source/autotools/symbols.filter:
11:35 PM Changeset in webkit [123430] by tkent@chromium.org
  • 2 edits in trunk

[GTK] Attempt to fix build

  • Source/autotools/symbols.filter: Export DocumentMarkerController::addTextMatchMarker.
11:33 PM Changeset in webkit [123429] by gyuyoung.kim@samsung.com
  • 20 edits in trunk/Source/WebCore

Missing *explicit* keyword in editing.
https://bugs.webkit.org/show_bug.cgi?id=92055

Reviewed by Ryosuke Niwa.

Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.

No new tests. Covered by existing tests.

  • editing/AlternativeTextController.h:

(WebCore::AlternativeTextController::UNLESS_ENABLED):

  • editing/BreakBlockquoteCommand.h:

(BreakBlockquoteCommand):

  • editing/DeleteButton.h:

(DeleteButton):

  • editing/DeleteButtonController.h:

(DeleteButtonController):

  • editing/EditCommand.h:

(EditCommand):
(WebCore::SimpleEditCommand::SimpleEditCommand):

  • editing/EditingBehavior.h:

(WebCore::EditingBehavior::EditingBehavior):

  • editing/EditingStyle.h:

(EditingStyle):

  • editing/Editor.h:

(Editor):

  • editing/FrameSelection.h:

(FrameSelection):

  • editing/InsertLineBreakCommand.h:

(InsertLineBreakCommand):

  • editing/ModifySelectionListLevel.h:

(ModifySelectionListLevelCommand):
(DecreaseSelectionListLevelCommand):

  • editing/RemoveFormatCommand.h:

(RemoveFormatCommand):

  • editing/RemoveNodeCommand.h:

(RemoveNodeCommand):

  • editing/RemoveNodePreservingChildrenCommand.h:

(RemoveNodePreservingChildrenCommand):

  • editing/ReplaceNodeWithSpanCommand.h:

(ReplaceNodeWithSpanCommand):

  • editing/TextInsertionBaseCommand.h:

(TextInsertionBaseCommand):

  • editing/UndoManager.h:

(UndoManager):

  • editing/UnlinkCommand.h:

(UnlinkCommand):

  • editing/WrapContentsInDummySpanCommand.h:

(WrapContentsInDummySpanCommand):

11:26 PM Changeset in webkit [123428] by dmazzoni@google.com
  • 27 edits
    4 adds in trunk

AX: Need AccessibilityObjects for nodes without renderers in canvas subtree
https://bugs.webkit.org/show_bug.cgi?id=87899

Reviewed by Chris Fleizach.

Source/WebCore:

Refactors AccessibilityRenderObject so that it inherits from a new class,
AccessibilityNodeObject, that can be constructed from a Node without a
renderer. Modifies AXObjectCache so that it automatically creates an
AccessibilityNodeObject for elements in a canvas subtree but not otherwise.
A new layout test verifies that this correctly exposes an accessibility
tree with appropriate roles for elements in a canvas subtree.

This patch does not try to complete the implementation of
AccessibilityNodeObject. Most AX methods are still unimplemented and need
to be migrated from AccessibilityRenderObject to AccessibilityNodeObject
in a future patch.

This patch also doesn't change anything outside of WebCore/accessibility, so
the rest of WebCore only calls AXObjectCache when there are changes to a
RenderObject, not to a Node. Accessible notifications on nodes without
renderers need to be implemented in a future patch.

Test: accessibility/canvas-accessibilitynodeobject.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::get):
(WebCore):
(WebCore::createFromNode):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):

  • accessibility/AXObjectCache.h:

(AXObjectCache):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid):
(WebCore):
(WebCore::AccessibilityARIAGrid::~AccessibilityARIAGrid):
(WebCore::AccessibilityARIAGrid::init):
(WebCore::AccessibilityARIAGrid::create):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::create):

  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::create):

  • accessibility/AccessibilityAllInOne.cpp:
  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::create):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::create):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::create):
(WebCore::AccessibilityMediaControlsContainer::create):
(WebCore::AccessibilityMediaTimeline::create):
(WebCore::AccessibilityMediaTimeDisplay::create):

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::create):
(WebCore):

  • accessibility/AccessibilityMenuList.h:

(AccessibilityMenuList):

  • accessibility/AccessibilityNodeObject.cpp: Added.

(WebCore):
(WebCore::AccessibilityNodeObject::AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::~AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::init):
(WebCore::AccessibilityNodeObject::create):
(WebCore::AccessibilityNodeObject::detach):
(WebCore::AccessibilityNodeObject::childrenChanged):
(WebCore::AccessibilityNodeObject::updateAccessibilityRole):
(WebCore::AccessibilityNodeObject::firstChild):
(WebCore::AccessibilityNodeObject::lastChild):
(WebCore::AccessibilityNodeObject::previousSibling):
(WebCore::AccessibilityNodeObject::nextSibling):
(WebCore::AccessibilityNodeObject::parentObjectIfExists):
(WebCore::AccessibilityNodeObject::parentObject):
(WebCore::AccessibilityNodeObject::elementRect):
(WebCore::AccessibilityNodeObject::setNode):
(WebCore::AccessibilityNodeObject::document):
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::accessibilityIsIgnored):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):
(WebCore::AccessibilityNodeObject::determineAriaRoleAttribute):
(WebCore::AccessibilityNodeObject::ariaRoleAttribute):
(WebCore::AccessibilityNodeObject::remapAriaRoleDueToParent):

  • accessibility/AccessibilityNodeObject.h: Added.

(WebCore):
(AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::isAccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::node):
(WebCore::AccessibilityNodeObject::isDetached):
(WebCore::toAccessibilityNodeObject):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isAccessibilityNodeObject):

  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::create):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::init):
(WebCore):
(WebCore::AccessibilityRenderObject::create):
(WebCore::AccessibilityRenderObject::detach):
(WebCore::AccessibilityRenderObject::setRenderer):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::addCanvasChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::create):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::AccessibilityTable):
(WebCore):
(WebCore::AccessibilityTable::~AccessibilityTable):
(WebCore::AccessibilityTable::init):
(WebCore::AccessibilityTable::create):

  • accessibility/AccessibilityTable.h:

(AccessibilityTable):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::create):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::create):

LayoutTests:

This new test adds a bunch of elements to a normal container and the same elements to
a canvas subtree, then it iterates over all of the accessible objects within each
container and makes sure they have identical roles. Because we know the nodes in the
canvas subtree don't have renderers, this successfully tests that AccessibilityNodeObjects
are getting created for these nodes.

  • accessibility/canvas-accessibilitynodeobject-expected.txt: Added.
  • accessibility/canvas-accessibilitynodeobject.html: Added.
10:53 PM FeatureFlags edited by tkent@chromium.org
Add OPENTYPE_VERTICAL (diff)
10:46 PM Changeset in webkit [123427] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix ENABLE_CSS_IMAGE_ORIENTATION compile flag
https://bugs.webkit.org/show_bug.cgi?id=91961

Patch by David Barr <davidbarr@chromium.org> on 2012-07-23
Reviewed by Tony Chang.

https://bugs.webkit.org/show_bug.cgi?id=89055
A rule was missed implementing the ENABLE_CSS_IMAGE_ORIENTATION compile flag.

https://bugs.webkit.org/show_bug.cgi?id=90046
Half of the missing rule was inadvertently added together with ENABLE_CSS_STICKY_POSITION.

No new tests; build configuration fix.

  • Configurations/FeatureDefines.xcconfig:
10:34 PM Changeset in webkit [123426] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Null-pointer crash when a derived color like -webkit-activelink is set in a gradient stop
https://bugs.webkit.org/show_bug.cgi?id=89148

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-23
Reviewed by Simon Fraser.

Source/WebCore:

CSSGradientValue attempted to resolve colors during paint, this crashed
when a derived color like -webkit-activelink was encountered because the
corresponding element was no longer available in the StyleResolver.
Instead, by adding a field to CSSGradientColorStop we can resolve and
then cache the resolved colors at the correct time. To avoid sharing
cached derived colors between elements we clone the gradient values when
needed.

Test: fast/css/crash-on-gradient-with-derived-color.html

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::gradientWithStylesResolved): Added. Resolve and cache
resolved colors, clone if colors are derived from the element.
(WebCore):
(WebCore::CSSGradientValue::addStops):
(WebCore::CSSGradientValue::isCacheable): Defer to new logic in
StyleResolver.

  • css/CSSGradientValue.h:

(CSSGradientColorStop): Added cache of resolved color.
(CSSGradientValue):
(CSSLinearGradientValue):
(CSSRadialGradientValue):

  • css/CSSImageGeneratorValue.h:

(WebCore):

  • css/CSSValue.h:

(WebCore::CSSValue::isGradientValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(StyleResolver):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::image): Revert change from r96449. This
is no longer necessary as the gradient colors are now resolved at a
time when the style is set on StyleResolver.

LayoutTests:

  • fast/css/crash-on-gradient-with-derived-color-expected.txt: Added.
  • fast/css/crash-on-gradient-with-derived-color.html: Added.
10:19 PM Changeset in webkit [123425] by Patrick Gansterer
  • 18 edits
    1 add in trunk/Source

Move GregorianDateTime from JSC to WTF namespace
https://bugs.webkit.org/show_bug.cgi?id=91948

Reviewed by Geoffrey Garen.

Moving GregorianDateTime into the WTF namespace allows us to us to
use it in WebCore too. The new class has the same behaviour as the
old struct. Only the unused timeZone member has been removed.

Source/JavaScriptCore:

  • runtime/DateConstructor.cpp:
  • runtime/DateConversion.cpp:
  • runtime/DateConversion.h:
  • runtime/DateInstance.h:
  • runtime/DatePrototype.cpp:
  • runtime/JSDateMath.cpp:
  • runtime/JSDateMath.h:

Source/WebCore:

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

Source/WTF:

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/GregorianDateTime.h: Added.

(GregorianDateTime):

10:05 PM Changeset in webkit [123424] by pilgrim@chromium.org
  • 21 edits
    2 adds in trunk/Source

[Chromium] Move layoutTestMode to WebCore
https://bugs.webkit.org/show_bug.cgi?id=92010

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • platform/LayoutTestSupport.cpp: Added.

(WebCore):
(WebCore::isRunningLayoutTest):
(WebCore::setIsRunningLayoutTest):

  • platform/LayoutTestSupport.h: Added.

(WebCore):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):

  • platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore):
(WebCore::LookupAltName):
(WebCore::fontContainsCharacter):
(WebCore::FillLogFont):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::drawGlyphs):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::systemColor):
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::caretBlinkInterval):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumWin::systemColor):
(WebCore::menuListButtonWidth):
(WebCore::RenderThemeChromiumWin::determineClassicState):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

  • src/WebKit.cpp:

(WebKit::setLayoutTestMode):
(WebKit::layoutTestMode):

9:57 PM Changeset in webkit [123423] by joone@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed GTK/EFL gardening after r123379
Marked fast/css/sticky/parsing-position-sticky.html as known failure
tracked by the bug 92063

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
9:22 PM Changeset in webkit [123422] by yosin@chromium.org
  • 1 edit
    12 moves in trunk/LayoutTests

[Tests] Rename fast/forms/time/*.html to time-*.html
https://bugs.webkit.org/show_bug.cgi?id=92058

Reviewed by Kent Tamura.

This patch renames test scripts and expected text to same naming
scheme(name starts with "time-"), for fast/forms/time.

  • fast/forms/time/ValidityState-rangeOverflow-time-expected.txt: Removed.
  • fast/forms/time/ValidityState-rangeOverflow-time.html: Removed.
  • fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt: Removed.
  • fast/forms/time/ValidityState-rangeUnderflow-time.html: Removed.
  • fast/forms/time/ValidityState-stepMismatch-time-expected.txt: Removed.
  • fast/forms/time/ValidityState-stepMismatch-time.html: Removed.
  • fast/forms/time/ValidityState-typeMismatch-time-expected.txt: Removed.
  • fast/forms/time/ValidityState-typeMismatch-time.html: Removed.
  • fast/forms/time/input-valueasdate-time-expected.txt: Removed.
  • fast/forms/time/input-valueasdate-time.html: Removed.
  • fast/forms/time/input-valueasnumber-time-expected.txt: Removed.
  • fast/forms/time/input-valueasnumber-time.html: Removed.
  • fast/forms/time/time-validity-state-range-overflow-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-rangeOverflow-time-expected.txt.
  • fast/forms/time/time-validity-state-range-overflow.html: Copied from LayoutTests/fast/forms/time/ValidityState-rangeOverflow-time.html.
  • fast/forms/time/time-validity-state-range-underflow-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt.
  • fast/forms/time/time-validity-state-range-underflow.html: Copied from LayoutTests/fast/forms/time/ValidityState-rangeUnderflow-time.html.
  • fast/forms/time/time-validity-state-step-mismatch-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-stepMismatch-time-expected.txt.
  • fast/forms/time/time-validity-state-step-mismatch.html: Copied from LayoutTests/fast/forms/time/ValidityState-stepMismatch-time.html.
  • fast/forms/time/time-validity-state-type-mismatch-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-typeMismatch-time-expected.txt.
  • fast/forms/time/time-validity-state-type-mismatch.html: Copied from LayoutTests/fast/forms/time/ValidityState-typeMismatch-time.html.
  • fast/forms/time/time-valueasdate-expected.txt: Copied from LayoutTests/fast/forms/time/input-valueasdate-time-expected.txt.
  • fast/forms/time/time-valueasdate.html: Copied from LayoutTests/fast/forms/time/input-valueasdate-time.html.
  • fast/forms/time/time-valueasnumber-expected.txt: Copied from LayoutTests/fast/forms/time/input-valueasnumber-time-expected.txt.
  • fast/forms/time/time-valueasnumber.html: Copied from LayoutTests/fast/forms/time/input-valueasnumber-time.html.
9:17 PM Changeset in webkit [123421] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[chromium] Add droppedFrameCount to renderingStats.
https://bugs.webkit.org/show_bug.cgi?id=91694

Patch by Dave Tu <dtu@chromium.org> on 2012-07-23
Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebRenderingStats.h:

(WebRenderingStats):
(WebKit::WebRenderingStats::WebRenderingStats):

Source/WebCore:

  • platform/graphics/chromium/cc/CCFrameRateCounter.cpp:

(WebCore):
(WebCore::CCFrameRateCounter::frameInterval):
(WebCore::CCFrameRateCounter::frameIndex):
(WebCore::CCFrameRateCounter::CCFrameRateCounter):
(WebCore::CCFrameRateCounter::markBeginningOfFrame):
(WebCore::CCFrameRateCounter::isBadFrame):

  • platform/graphics/chromium/cc/CCFrameRateCounter.h:

(WebCore::CCFrameRateCounter::droppedFrameCount):
(CCFrameRateCounter):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::renderingStats):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderingStats.h:

(CCRenderingStats):
(WebCore::CCRenderingStats::CCRenderingStats):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::implSideRenderingStats):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::implSideRenderingStatsOnImplThread):

Source/WebKit/chromium:

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::renderingStats):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):

7:55 PM Changeset in webkit [123420] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed the build after r123418.

  • WebCore.exp.in: Added DocumentMarkerController::addTextMatchMarker.
7:44 PM Changeset in webkit [123419] by mikelawther@chromium.org
  • 3 edits in trunk/Source/WebCore

CSS3 calc: optimise blending expression
https://bugs.webkit.org/show_bug.cgi?id=90037

Reviewed by Tony Chang.

Introduce a new calc expression node - a BlendLength node. Given two Lengths and a progress
this blends them together when evaluated.

An alternative and more general approach of being able to blend two CalcExpressionNodes was
tested, but involves more memory allocations, was measurably slower, and nothing currently
would make use of the generality.

No functional change. Covered by existing tests.

  • platform/CalculationValue.h:

(CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::operator==):
(WebCore::CalcExpressionBlendLength::evaluate):
(WebCore):

  • platform/Length.cpp:

(WebCore::Length::blendCalculation):

7:19 PM Changeset in webkit [123418] by thakis@chromium.org
  • 16 edits
    4 adds in trunk

[chromium] Show search tickmarks on css-styled scrollbars
https://bugs.webkit.org/show_bug.cgi?id=91949

Reviewed by Adrienne Walker.

This is done by letting RenderScrollbarTheme::paintTickmarks()
delegate to the native ScrollbarTheme. To make this possible,
move paintTickmarks() from ScrollbarThemeComposite to the
superclass ScrollbarTheme.

For testing, add internals.addTextMatchMarker() and add a pixel test.

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::paintTickmarks):
Moved paintTickmarks() from ScrollbarThemeComposite to here.

  • platform/ScrollbarThemeComposite.h:

Remove paintTickmarks().

  • platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::paintTickmarks):
Switch to drawing tickmarks as vectors, so they can be arbitrarily wide.

  • platform/chromium/ScrollbarThemeChromiumMac.h:

(ScrollbarThemeChromiumMac):
Implement paintTickmarks(), so that css-styled scrollbars get tickmarks on mac.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
Implement paintTickmarks(), so that css-styled scrollbars get tickmarks on mac.

  • rendering/RenderScrollbarTheme.cpp:

(WebCore::RenderScrollbarTheme::paintTickmarks):
Delegate to the native ScrollbarTheme for tickmark drawing.
(WebCore):

  • rendering/RenderScrollbarTheme.h:

(RenderScrollbarTheme):
Override paintTickmarks().

7:13 PM Changeset in webkit [123417] by fpizlo@apple.com
  • 29 edits in trunk/Source/JavaScriptCore

Property storage should grow in reverse address direction, to support butterflies
https://bugs.webkit.org/show_bug.cgi?id=91788

Reviewed by Geoffrey Garen.

Changes property storage to grow to the left, and changes the property storage pointer to point
one 8-byte word (i.e. JSValue) to the right of the first value in the storage.

Also improved debug support somewhat, by adding a describe() function to the jsc command-line,
and a slow mode of object access in LLInt.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::repatchCompact):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::isCompactPtrAlignedAddressOffset):
(JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::isCompactPtrAlignedAddressOffset):
(JSC::MacroAssemblerX86Common::repatchCompact):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::repatchCompact):

  • bytecode/CodeBlock.cpp:

(JSC::dumpStructure):

  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):
(JSC::DFG::emitPutTransitionStub):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::genericAddPointer):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::pinIfNecessary):
(JSC):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetDirectOffset):

  • jit/JITStubs.cpp:

(JSC::JITThunks::tryCacheGetByID):

  • jsc.cpp:

(GlobalObject::finishCreation):
(functionDescribe):

  • llint/LLIntCommon.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):
(JSC::JSObject::growOutOfLineStorage):

  • runtime/JSObject.h:

(JSC::JSObject::getDirectLocation):
(JSC::JSObject::offsetForLocation):

  • runtime/JSValue.h:

(JSValue):

  • runtime/PropertyOffset.h:

(JSC::offsetInOutOfLineStorage):

7:03 PM Changeset in webkit [123416] by commit-queue@webkit.org
  • 11 edits in trunk/Source

[chromium] Use shallow flushes that don't glFlush
https://bugs.webkit.org/show_bug.cgi?id=90325

Patch by Brian Anderson <brianderson@chromium.org> on 2012-07-23
Reviewed by Kenneth Russell.

Source/Platform:

Adds shallowFlushCHROMIUM to WebGraphicsContext3D.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::shallowFlushCHROMIUM):

Source/WebCore:

Adds plumbing for the shallowFlushCHROMIUM extension and uses
shallow flushes instead of normal flushes when uploading textures.
Shallow flushes allow us to initiate command buffer flushes to
the GPU thread/process without the overhead of a true glFlush.

CCTextureUpdaterTest updated to recognize shallow flushes.

  • platform/chromium/support/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::shallowFlushCHROMIUM):
(WebCore):

  • platform/graphics/chromium/Extensions3DChromium.h:

(Extensions3DChromium):

  • platform/graphics/chromium/cc/CCGraphicsContext.h:
  • platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::shallowFlushIfSupported):
(WebCore):
(WebCore::CCResourceProvider::CCResourceProvider):
(WebCore::CCResourceProvider::initialize):

  • platform/graphics/chromium/cc/CCResourceProvider.h:

(CCResourceProvider):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::update):

Source/WebKit/chromium:

Changed CCTextureUpdaterTest to recognize shallowFlushCHROMIUM().

  • tests/CCTextureUpdaterTest.cpp:
6:59 PM Changeset in webkit [123415] by commit-queue@webkit.org
  • 4 edits in trunk

Disable flexbox on Windows
https://bugs.webkit.org/show_bug.cgi?id=92047
<rdar://problem/11570384>

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Darin Adler.

Disabled Flexbox CSS3 syntax on Mac, need to do the same for Windows.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

Disable ENABLE_CSS3_FLEXBOX property.

LayoutTests:

  • platform/win/Skipped:

Add related CSS3 Flexbox tests to skip list.

6:14 PM Changeset in webkit [123414] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: When using TextureMapper, WebKit does not retain final value of opacity in animations, unless it is specified on the last key frame.
https://bugs.webkit.org/show_bug.cgi?id=91322

Patch by Hanyee Kim <choco@company100.net> on 2012-07-23
Reviewed by Noam Rosenthal.

When -webkit-fill-mode is forwards, GraphicsLayerAnimation::apply does not apply
the property values defined in the last executing keyframe after the final iteration of animation.

This patch does not return right after the end of animation, but it keeps applying
the property values defined in the last executing keyframe.
Add normalizedAnimationValueForFillsForwards function that returns a normalized value of the
last executing keyframe.

Link to CSS Animations spec: http://www.w3.org/TR/css3-animations/#animation-fill-mode-property

Test: animations/fill-mode-forwards2.html

  • platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::normalizedAnimationValueForFillsForwards):
(WebCore):
(WebCore::GraphicsLayerAnimation::apply):

LayoutTests: WebKit does not retain final value of opacity in animations, unless it is specified on the last key frame
https://bugs.webkit.org/show_bug.cgi?id=91322

Patch by Hanyee Kim <choco@company100.net> on 2012-07-23
Reviewed by Noam Rosenthal.

Added a test to check if the opacity has the right value after animation.

  • animations/fill-mode-forwards2-expected.txt: Added.
  • animations/fill-mode-forwards2.html: Added.
6:13 PM FeatureFlags edited by tkent@chromium.org
Add CSS_STICKY_POSITION (diff)
5:57 PM Changeset in webkit [123413] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add more compositor unit tests for high DPI transforms
https://bugs.webkit.org/show_bug.cgi?id=91917

Reviewed by Kenneth Russell.

The current set of high DPI tests only deal with layers in a render
surface. Add some extra tests for non-surface layers. Also add a test
to make sure that an owning layer in a surface doesn't differ from a
non-owning layer in high DPI circumstances.

  • tests/CCLayerTreeHostCommonTest.cpp:
5:53 PM Changeset in webkit [123412] by commit-queue@webkit.org
  • 20 edits in trunk

Unreviewed, rolling out r123184, r123195, and r123197.
http://trac.webkit.org/changeset/123184
http://trac.webkit.org/changeset/123195
http://trac.webkit.org/changeset/123197
https://bugs.webkit.org/show_bug.cgi?id=92049

pagecycler regression (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::suggestedMIMEType):

  • dom/Document.h:

(WebCore):
(WebCore::Node::isDocumentNode):
(WebCore::Node::Node):

  • dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::setDocument):
(WebCore):
(WebCore::Node::setTreeScope):
(WebCore::Node::treeScope):
(WebCore::Node::isInShadowTree):
(WebCore::Node::reportMemoryUsage):

  • dom/Node.h:

(Node):
(WebCore::Node::document):
(WebCore::Node::inDocument):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::treeScope):
(WebCore::NodeRareData::setTreeScope):
(NodeRareData):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::setParentTreeScope):

  • dom/TreeScope.h:

(WebCore):
(WebCore::TreeScope::idTargetObserverRegistry):
(TreeScope):

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

  • editing/MoveSelectionCommand.cpp:
  • editing/RemoveNodeCommand.cpp:
  • editing/RemoveNodePreservingChildrenCommand.cpp:
  • inspector/PageConsoleAgent.cpp:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
5:48 PM Changeset in webkit [123411] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

.: If select element in Windows is off screen horizontally,
menu is either inappropriately resized or positioned offscreen.
https://bugs.webkit.org/show_bug.cgi?id=91913
<rdar://problem/7611229>

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Tim Horton.

Add a manual test to verify that popup menus render in the correct place.

  • ManualTests/win/select-menu-off-screen.html: Added.

Source/WebCore: On Windows, if select element is off screen horizontally,
menu is either inappropriately resized or positioned offscreen.
https://bugs.webkit.org/show_bug.cgi?id=91913
<rdar://problem/7611229>

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Tim Horton.

If the select element is positioned off the edge of the screen to the left,
the menu is resized. It should not be resized, just shifted to remain on the screen.
If the select element is positioned off the edge of the screen to the right,
the menu goes off screen instead of being shifted over to appear on screen.
This problem only occurs on Windows.

Test: ManualTests/win/select-menu-off-screen.html

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):
Modified final horizontal position calculation code to position
popup menu on screen if it would otherwise go off.

5:42 PM Changeset in webkit [123410] by Lucas Forschler
  • 1 copy in tags/Safari-537.2

New Tag.

5:37 PM Changeset in webkit [123409] by commit-queue@webkit.org
  • 5 edits in trunk

Fixed crash in webkitAddKey() when key parameter is null.
https://bugs.webkit.org/show_bug.cgi?id=85444

Patch by David Dorwin <ddorwin@chromium.org> on 2012-07-23
Reviewed by Kentaro Hara.

Reference: Step 1 of http://dvcs.w3.org/hg/html-media/raw-file/5f76a0b43836/encrypted-media/encrypted-media.html#dom-addkey

Source/WebCore:

Tests: media/encrypted-media/encrypted-media-syntax.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::webkitAddKey):

LayoutTests:

  • media/encrypted-media/encrypted-media-syntax-expected.txt:
  • media/encrypted-media/encrypted-media-syntax.html:
5:36 PM Changeset in webkit [123408] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

http/tests/multipart/policy-ignore-crash.php is failing on Chromium
https://bugs.webkit.org/show_bug.cgi?id=92046

Reviewed by Adam Barth.

Chromium's network layer now shows most text/* mime types. This test was using text/random to
try to trigger a crash when multipart content switch from a text type to a non-text type.
Change the test to use a text type that we don't render.

  • http/tests/multipart/policy-ignore-crash.php: Use text/rtf instead of text/random.
  • platform/chromium/TestExpectations: Test should be passing again.
5:12 PM Changeset in webkit [123407] by hayato@chromium.org
  • 4 edits
    2 adds in trunk

A FocusScope for a distributed node should not be its TreeScope.
https://bugs.webkit.org/show_bug.cgi?id=91829

Reviewed by Dimitri Glazkov.

Source/WebCore:

Current implementation of FocusScope::focusScopeOf(Node*) returns
the given node's treeScope(). That does not apply if the node is
a distributed node. We should calculate a FocusScope for a
distributed node by traversing ancestor nodes in Composed Shadow
Tree.

Test: fast/dom/shadow/focus-navigation-with-distributed-nodes.html

  • page/FocusController.cpp:

(WebCore::FocusScope::focusScopeOf):

LayoutTests:

  • fast/dom/shadow/focus-navigation-with-distributed-nodes-expected.txt: Added.
  • fast/dom/shadow/focus-navigation-with-distributed-nodes.html: Added.
  • fast/dom/shadow/resources/shadow-dom.js:

(shouldNavigateFocus):

5:06 PM Changeset in webkit [123406] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Null-pointer crash when parsing border-image
https://bugs.webkit.org/show_bug.cgi?id=91963

Patch by Douglas Stockwell <dstockwell@google.com> on 2012-07-23
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/border-image-fill-crash.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseBorderImageRepeat): Handle the case where
parseBorderImageRepeat is called when the value list is empty.

LayoutTests:

  • fast/css/border-image-fill-crash-expected.txt: Added.
  • fast/css/border-image-fill-crash.html: Added.
4:56 PM Changeset in webkit [123405] by commit-queue@webkit.org
  • 5 edits in trunk

[CSS Exclusions] SVG shape errors should invalidate exclusion shapes
https://bugs.webkit.org/show_bug.cgi?id=91761

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2012-07-23
Reviewed by Andreas Kling.

Source/WebCore:

CSS exclusion shapes that are specified with negative radiuses or
height/width are now considered invalid and ignored.

Tests added to
LayoutTests/fast/exclusions/parsing-wrap-shape-lengths.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseExclusionShapeRectangle):
(WebCore::CSSParser::parseExclusionShapeCircle):
(WebCore::CSSParser::parseExclusionShapeEllipse):

LayoutTests:

Test that negative heights. widths, and radiuses are ignored.

  • fast/exclusions/parsing-wrap-shape-lengths-expected.txt:
  • fast/exclusions/parsing-wrap-shape-lengths.html:
4:46 PM Changeset in webkit [123404] by caio.oliveira@openbossa.org
  • 12 edits in trunk/LayoutTests

[Qt] css3/selectors3 rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92038

Reviewed by Alexis Menard.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped: These tests are failing because of <input> default size in

WK2, which is different than the expected results generated from WK1. Moved them to
appropriate block in skipped list.

  • platform/qt-5.0/Skipped:
  • platform/qt/css3/selectors3/html/css3-modsel-21c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-21c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-21c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-21c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-148-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-148-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-21c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-21c-expected.txt:
4:40 PM Changeset in webkit [123403] by tony@chromium.org
  • 2 edits
    1 move
    1 add
    2 deletes in trunk/LayoutTests

Unreviewed gardening. Land pixel results for fast/frames/valid.html on chromium mac snowleopard.

  • fast/frames/valid-expected.txt: Renamed from LayoutTests/platform/efl/fast/frames/valid-expected.txt.
  • platform/chromium-mac-snowleopard/fast/frames/valid-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/gtk/fast/frames/valid-expected.txt: Removed.
  • platform/mac/fast/frames/valid-expected.txt: Removed.
4:38 PM Changeset in webkit [123402] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] Implement scrollbar theme for Android
https://bugs.webkit.org/show_bug.cgi?id=91674

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-07-23
Reviewed by Adam Barth.

Previously the scrollbar for Android was implemented as an extra
drawing pass in the compositor. Now we switch to use the standard
ScrollbarTheme mechanism.

No new tests. We use mock scrollbars during layout test to share
pixel results with Linux.

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::thumbPosition):
(WebCore::ScrollbarThemeChromiumAndroid::thumbLength):
(WebCore::ScrollbarThemeChromiumAndroid::backButtonRect):
(WebCore::ScrollbarThemeChromiumAndroid::forwardButtonRect):
(WebCore::ScrollbarThemeChromiumAndroid::trackRect):
(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::paintThumb):
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):

  • platform/chromium/ScrollbarThemeChromiumAndroid.h:

(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
(ScrollbarThemeChromiumAndroid):
(WebCore::ScrollbarThemeChromiumAndroid::hasButtons):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb):

4:37 PM Changeset in webkit [123401] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change to mark test as slow: fast/forms/select-set-length-with-mutation-remove.html.

  • platform/chromium/TestExpectations:
4:33 PM Changeset in webkit [123400] by wsiegrist@apple.com
  • 1 edit in trunk/Websites/webkit.org/blog/wp-config.php

Update website for new hardware.

4:15 PM Changeset in webkit [123399] by kseo@webkit.org
  • 10 edits
    1 add in trunk

Use the original token to create an element in "reconstruct the active formatting elements" and "call the adoption agency"
https://bugs.webkit.org/show_bug.cgi?id=91703

Reviewed by Adam Barth.

Source/WebCore:

The current WebKit HTML5 parser implementation does not hold the original token
in the stack of open elements and the active formatting elements. This is
problematic because the original token is used to create an element in
"reconstruct the active formatting elements" and "call the adoption agency".

As a workaround, WebKit uses the saved element instead of the original token
to create an element. But this causes us to fail examples like this:
<b id="1"><p><script>document.getElementById("1").id = "2"</script></p>TEXT</b>
reconstructTheActiveFormattingElements calls this method to open a second <b>
tag to wrap TEXT, it will have id "2", even though the HTML5 spec implies it
should be "1".

Created a ref-counted container class, HTMLStackItem to hold the original token
and the namespace URI as well as the element. Changed HTMLElementStack and
HTMLFormattingElementList to use HTMLStackItem.
Changed HTMLConstructionSite::reconstructTheActiveFormattingElements and
HTMLTreeBuilder::callTheAdoptionAgency to create an element from the saved token
instead of the saved element.

Updated test expectation for html5lib/runner-expected.txt
because now resources/scripted/adoption01.dat passes.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElementFromSavedToken):
(WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements):

  • html/parser/HTMLConstructionSite.h:

(HTMLConstructionSite):
(WebCore::HTMLConstructionSite::currentElementRecord):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::pushRootNode):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::pushRootNodeCommon):
(WebCore::HTMLElementStack::pushHTMLHeadElement):
(WebCore::HTMLElementStack::pushHTMLBodyElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::pushCommon):

  • html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::ElementRecord::element):
(WebCore::HTMLElementStack::ElementRecord::node):
(WebCore::HTMLElementStack::ElementRecord::stackItem):
(ElementRecord):
(HTMLElementStack):

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::swapTo):
(WebCore::HTMLFormattingElementList::append):

  • html/parser/HTMLFormattingElementList.h:

(WebCore::HTMLFormattingElementList::Entry::Entry):
(WebCore::HTMLFormattingElementList::Entry::isMarker):
(WebCore::HTMLFormattingElementList::Entry::stackItem):
(WebCore::HTMLFormattingElementList::Entry::element):
(WebCore::HTMLFormattingElementList::Entry::replaceElement):
(WebCore::HTMLFormattingElementList::Entry::operator==):
(WebCore::HTMLFormattingElementList::Entry::operator!=):
(Entry):
(HTMLFormattingElementList):

  • html/parser/HTMLStackItem.h: Added.

(WebCore):
(HTMLStackItem):
(WebCore::HTMLStackItem::create):
(WebCore::HTMLStackItem::element):
(WebCore::HTMLStackItem::node):
(WebCore::HTMLStackItem::token):
(WebCore::HTMLStackItem::namespaceURI):
(WebCore::HTMLStackItem::HTMLStackItem):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

LayoutTests:

Updated test expectation for html5lib/runner-expected.txt
because now resources/scripted/adoption01.dat passes.

  • html5lib/runner-expected.txt:
4:12 PM Writing Reftests edited by hayato@chromium.org
(diff)
4:06 PM Changeset in webkit [123398] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix unit tests in debug mode after r123375
https://bugs.webkit.org/show_bug.cgi?id=92030

Reviewed by Adrienne Walker.

Fixed two unit tests that were causing debug assertions because
they gave calcDrawTransforms an empty sized root layer.

  • tests/CCLayerTreeHostCommonTest.cpp:
3:57 PM Changeset in webkit [123397] by rafael.lobo@openbossa.org
  • 24 edits
    2 copies
    5 adds
    2 deletes in trunk/LayoutTests

[Qt] svg/{in-html,overflow,repaint,wicd} needs update after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92023

Unreviewed gardening.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/qt/Skipped:
  • platform/qt/svg/in-html/by-reference-expected.txt:
  • platform/qt/svg/in-html/circle-expected.png:
  • platform/qt/svg/in-html/circle-expected.txt:
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
  • platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.png.
  • platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
  • platform/qt/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
  • platform/qt/svg/repaint/inner-svg-change-viewBox-expected.txt: Added.
  • platform/qt/svg/repaint/inner-svg-change-viewPort-relative-expected.txt:
  • platform/qt/svg/repaint/mask-clip-target-transform-expected.png: Added.
  • platform/qt/svg/repaint/text-mask-update-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.png.
  • platform/qt/svg/repaint/text-mask-update-expected.txt: Added.
  • platform/qt/svg/wicd/rightsizing-grid-expected.png:
  • platform/qt/svg/wicd/rightsizing-grid-expected.txt:
  • platform/qt/svg/wicd/sizing-flakiness-expected.txt:
  • platform/qt/svg/wicd/test-rightsizing-a-expected.png:
  • platform/qt/svg/wicd/test-rightsizing-a-expected.txt:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.png:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/qt/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/qt/svg/wicd/test-scalable-background-image1-expected.txt:
  • platform/qt/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/qt/svg/wicd/test-scalable-background-image2-expected.txt:
3:56 PM Changeset in webkit [123396] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Report the extra memory used by immutable StylePropertySet objects.
<http://webkit.org/b/92032>

Reviewed by Anders Carlsson.

Add an optional parameter to the MemoryClassInfo constructor for passing in additional base object
size on top of sizeof(T).

Use this in StylePropertySet::reportMemoryUsage() to properly account for the CSSProperty array
tacked onto the end of the object when m_isMutable == false.

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::reportMemoryUsage):

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):

3:53 PM Changeset in webkit [123395] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Fix WebGL texSubImage2D for cube maps
https://bugs.webkit.org/show_bug.cgi?id=91927

Patch by Gregg Tavares <gman@google.com> on 2012-07-23
Reviewed by Kenneth Russell.

Source/WebCore:

Fixes texSubImage2D so any size rectangle can be passed in
for cube maps.

Test: fast/canvas/webgl/tex-sub-image-cube-maps.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

LayoutTests:

Tests for WebGL texSubImage2D for cube maps.

  • fast/canvas/webgl/tex-sub-image-cube-maps-expected.txt: Added.
  • fast/canvas/webgl/tex-sub-image-cube-maps.html: Added.
3:46 PM Changeset in webkit [123394] by fpizlo@apple.com
  • 4 edits
    6 adds in trunk

DFG is too aggressive in performing the specific value optimization on loads
https://bugs.webkit.org/show_bug.cgi?id=92034

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

This ensures that we don't do optimizations based on a structure having a specific
value, if there is no way to detect that the value is despecified. This is the
case for dictionaries, since despecifying a value in a dictionary does not lead to
a transition and so cannot be caught by either structure checks or structure
transition watchpoints.

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

  • bytecode/ResolveGlobalStatus.cpp:

(JSC::computeForStructure):

LayoutTests:

  • fast/js/dfg-resolve-global-polymorphic-non-dictionary-expected.txt: Added.
  • fast/js/dfg-resolve-global-polymorphic-non-dictionary.html: Added.
  • fast/js/dfg-resolve-global-specific-dictionary-expected.txt: Added.
  • fast/js/dfg-resolve-global-specific-dictionary.html: Added.
  • fast/js/script-tests/dfg-resolve-global-polymorphic-non-dictionary.js: Added.

(description.foo):

  • fast/js/script-tests/dfg-resolve-global-specific-dictionary.js: Added.

(description.foo):
(x):

3:38 PM Changeset in webkit [123393] by fpizlo@apple.com
  • 4 edits in trunk

REGRESSION(r123169): It made fast/js/dfg-inline-arguments-use-from-uninlined-code.html fail on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=92002

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

In the process of changing the nature of local variable typing, I forgot to modify one of the places where
we glue the DFG's notion of variable prediction to the runtime's notion of variable tagging.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Unskip test that this change fixes, as requested by Ossy.

  • platform/qt/Skipped:
3:36 PM Changeset in webkit [123392] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r123387.
http://trac.webkit.org/changeset/123387
https://bugs.webkit.org/show_bug.cgi?id=92036

Broke chromium win build (Requested by tonywork on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_bison.py:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

  • make-hash-tools.pl:
3:34 PM Changeset in webkit [123391] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Move about: URL handling out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91541

Patch by Yong Li <yoli@rim.com> on 2012-07-23
Reviewed by Rob Buis.

PR# 181304.
Move about: URL handling to the right place (FrameLoaderClientBlackBerry::createDocumentLoader), so
reload and history navigation can work.
Other changes: Remove about:version which makes little sense. Make about:memory partially visible.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::load): Remove the call to loadAbout()

  • Api/WebPage_p.h: Remove loadAbout()

(WebPagePrivate):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::createDocumentLoader): Construct about: data here.

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::numberToHTMLTr): Make it static
(BlackBerry::WebKit::configPage): Make it static
(BlackBerry::WebKit::memoryPage): Make it static
(BlackBerry::WebKit::cachePage):
(BlackBerry::WebKit::buildPage):
(BlackBerry::WebKit::creditsPage):
(BlackBerry::WebKit::cookiePage):
(BlackBerry::WebKit::aboutData): The only export function that returns HTML source for a given about: URL.
(WebKit):

  • WebKitSupport/AboutData.h:

(WebKit):

3:09 PM Changeset in webkit [123390] by dpranke@chromium.org
  • 9 edits in trunk/Tools

Unreviewed, rolling out r123360.
http://trac.webkit.org/changeset/123360
https://bugs.webkit.org/show_bug.cgi?id=91890

broke the chromium bots

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_build_path):

3:02 PM Changeset in webkit [123389] by kseo@webkit.org
  • 7 edits in trunk/Source/WebCore

Ref-count AtomicHTMLToken
https://bugs.webkit.org/show_bug.cgi?id=91981

Reviewed by Adam Barth.

Ref-count AtomicHTMLToken to avoid copying AtomicHTMLToken in Bug 91703.

No new tests - no functional changes.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • html/parser/HTMLConstructionSite.h:

(HTMLConstructionSite):

  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::create):
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::constructTreeFromToken):
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
(WebCore::HTMLTreeBuilder::parseError):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

2:54 PM Changeset in webkit [123388] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

More unreviewed chromium expectation changes to mark tests as failing/slow.

  • platform/chromium/TestExpectations:
2:52 PM Changeset in webkit [123387] by tony@chromium.org
  • 5 edits in trunk/Source/WebCore

Use native (non-cygwin) binaries for perl, gperf, and bison in Chromium
https://bugs.webkit.org/show_bug.cgi?id=91667

Patch by Scott Graham <scottmg@google.com> on 2012-07-23
Reviewed by Tony Chang.

Using native tools instead of cygwin version improves build time
performance by roughly 50% (on top of previous cl-instead-of-gcc
change).

Also, use - instead of / for cl flags because a layer of project
generator converts them to \ otherwise, which causes the preprocessing
to fail (very slowly because of the cygwin-loop with a sleep 1).

No new tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_bison.py:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

  • make-hash-tools.pl:
2:39 PM Changeset in webkit [123386] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

MediaController.currentTime should be kept stable during script execution.
https://bugs.webkit.org/show_bug.cgi?id=88555

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-controller-time-constant.html

To keep MediaController.currentTime stable, add a new m_position variable and
a new m_clearPositionTimer timer. Both must be mutable variables as they will
be updated from within const functions. Calls to currentTime() will result in
stable values until the next runloop iteration.

  • html/MediaController.cpp:

(MediaController::MediaController):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::clearPositionTimerFired):

  • html/MediaController.h:

LayoutTests:

  • media/media-controller-time-constant-expected.txt: Added.
  • media/media-controller-time-constant.html: Added.
2:38 PM Changeset in webkit [123385] by kseo@webkit.org
  • 3 edits in trunk/Source/WebCore

Destroy CSS decoded data more eagerly once they become dead caches.
https://bugs.webkit.org/show_bug.cgi?id=91733

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-23
Reviewed by Geoffrey Garen.

Internal review by Kwang Yul Seo.

There are three CachedResources with decoded data: CachedImage, CachedScript
and CachedCSSStyleSheet. In the cases of CachedImage and CachedScript, we
eagerly destroy the decoded data using Timer in CacehdResource::allClientsRemoved().
We must apply the same policy here in CachedCSSStyleSheet because priority
inversion can occur. For example, we can't destroy the decoded data of CachedImages
when they are referenced by CachedCSSStyleSheet as background, mask or border
images.

No new tests - no new testable functionality.

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::allClientsRemoved):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore):
(WebCore::CachedCSSStyleSheet::decodedDataDeletionTimerFired):

  • loader/cache/CachedCSSStyleSheet.h:

(CachedCSSStyleSheet):

2:24 PM Changeset in webkit [123384] by abarth@webkit.org
  • 5 edits in trunk/Tools

[Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
https://bugs.webkit.org/show_bug.cgi?id=91459

Reviewed by Ryosuke Niwa.

Rather than having TestShell own and bind each of these JavaScript APIs
individually, TestShell should delegate that work to TestInterfaces.
This patch moves AccessibilityController and TextInputController to be
the responsibility of TestInterfaces.

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:

(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::setWebView):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.h:

(WebKit):
(TestInterfaces):
(TestInterfaces::accessibilityController):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::accessibilityController):
(TestShell):

2:23 PM Changeset in webkit [123383] by caio.oliveira@openbossa.org
  • 15 edits in trunk/LayoutTests

[Qt] dom/xhtml/level3/core rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92028

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt:
  • platform/qt/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt:
  • platform/qt/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodelookupprefix19-expected.txt:
2:21 PM Changeset in webkit [123382] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

nrwt swallows early exceptions
https://bugs.webkit.org/show_bug.cgi?id=91884

Reviewed by Dirk Pranke.

Put everything in a try block so we won't miss any error.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):
(main):

2:07 PM Changeset in webkit [123381] by scherkus@chromium.org
  • 3 edits in branches/chromium/1180

Merge 123272 - [chromium] Don't display fullscreen button for video elements not containing video
https://bugs.webkit.org/show_bug.cgi?id=91811

Reviewed by Eric Carlson.

Covered by media/media-document-audio-repaint.html

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::reset):

TBR=scherkus@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10800085

2:04 PM Changeset in webkit [123380] by scherkus@chromium.org
  • 4 edits
    1 copy in branches/chromium/1180

Merge 123259 - [chromium] CSS tweaks to media controls to prevent styles from being overridden
https://bugs.webkit.org/show_bug.cgi?id=91802

Reviewed by Eric Carlson.

Source/WebCore:

Having the buttons declared as inline caused them to not be included in the box layout,
resulting in styles set outside the media element to affect the position of the buttons.

In a similar vein, it was also possible to override the font-style attribute for the time
display.

Test: media/controls-styling-strict.html

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):

LayoutTests:

  • media/controls-styling-strict.html: Added.
  • platform/chromium-linux/media/controls-styling-strict-expected.png: Added.
  • platform/chromium-linux/media/controls-styling-strict-expected.txt: Added.

TBR=scherkus@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10807077

2:03 PM Changeset in webkit [123379] by Simon Fraser
  • 17 edits
    5 adds in trunk

Part 2 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

Turn on ENABLE_CSS_STICKY_POSITION.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Turn on ENABLE_CSS_STICKY_POSITION. Add support for parsing the new '-webkit-sticky'
value for position, returning it from getComputedStyle(), and storing it in RenderStyle.

Test: fast/css/sticky/parsing-position-sticky.html

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getPositionOffsetValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EPosition):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

Source/WebKit/chromium:

Turn on ENABLE_CSS_STICKY_POSITION.

  • features.gypi:

Source/WebKit/mac:

Turn on ENABLE_CSS_STICKY_POSITION.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Turn on ENABLE_CSS_STICKY_POSITION.

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

Test for parsing and returning fro getComputedStyle() the new
-webkit-sticky value for position.

  • fast/css/sticky/parsing-position-sticky-expected.txt: Added.
  • fast/css/sticky/parsing-position-sticky.html: Added.
  • fast/css/sticky/resources/parsing-position-sticky.js: Added.

(test):

2:03 PM Changeset in webkit [123378] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change to mark media/media-fragments/TC0010-TC0019.html as flaky/crashy.

  • platform/chromium/TestExpectations:
1:57 PM Changeset in webkit [123377] by schenney@chromium.org
  • 3 edits
    2 adds in trunk

Crash when setting empty class name on a new element
https://bugs.webkit.org/show_bug.cgi?id=92024

Reviewed by Andreas Kling.

Source/WebCore:

Add a check for null attributeData() when setting the className to an
empty string on a newly created element. New SVG elements have null
attributeData() on baseVal upon creation.

Test: svg/custom/empty-className-baseVal-crash.html

  • dom/StyledElement.cpp:

(WebCore::StyledElement::classAttributeChanged): Add check for null attributeData()

LayoutTests:

Add a check for null attributeData() when setting the className to an
empty string on a newly created element.

  • svg/custom/empty-className-baseVal-crash-expected.txt: Added.
  • svg/custom/empty-className-baseVal-crash.html: Added.
1:53 PM Changeset in webkit [123376] by Patrick Gansterer
  • 5 edits in trunk/Source/JavaScriptCore

Move JSC::parseDate() from DateConversion to JSDateMath
https://bugs.webkit.org/show_bug.cgi?id=91982

Reviewed by Geoffrey Garen.

Moveing this function into the other files removes the dependency
on JSC spcific classes in DateConversion.{cpp|h}.

  • runtime/DateConversion.cpp:
  • runtime/DateConversion.h:

(JSC):

  • runtime/JSDateMath.cpp:

(JSC::parseDate):
(JSC):

  • runtime/JSDateMath.h:

(JSC):

1:46 PM Changeset in webkit [123375] by shawnsingh@chromium.org
  • 19 edits in trunk/Source

[chromium] Refactor CCLayerTreeHostCommon: clean up clipRect and drawableContentRect design
https://bugs.webkit.org/show_bug.cgi?id=80622

Reviewed by Adrienne Walker.

Source/WebCore:

clipRect(), usesLayerClipping(), and drawableContentRect() have been
very confusing in CCLayerTreeHostCommon for a while. This patch
refactors it so that (1) clipping is only done locally in
calcDrawTransforms, and (2) the layer's drawableContentRect value
is now meaningful value outside of calcDrawTransforms.
Additionally, the layer is now always clipped to the root
surface's contentBounds (which are set to the viewport bounds).
This refactor not only makes calcDrawTransforms far more readable and intuitive, but
this patch enables more upcoming beneficial refactors, including
the pending refactor in https://bugs.webkit.org/show_bug.cgi?id=88953.

Tests are also significantly updated to keep up with this refactoring change.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
Removed m_usesLayerClipping and m_clipRect and associated accessors.

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):
Updated comment

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
Removed m_usesLayerClipping and m_clipRect and associated accessors.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):
removed setClipRect code that no longer applies

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateLayerScissorRect):
scissor rect is now a little bit tighter, the intersection between damage and layer's new drawableContentRect.

(WebCore::calculateSurfaceScissorRect):
scissor rect is now a little bit tighter, except when filters are involved.

(WebCore::layerClipsSubtree):
new helper function

(WebCore):
(WebCore::calculateVisibleContentRect):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsInternal):

  • added drawableContentRectOfSubtree to the function args, it is valid only after recursion returns,
  • added clipRectFromAncestor and bool ancestorClipsSubtree to function args, this replaces the layer's clipRect and usesLayerClipping.
  • removed the boolean return value, which was redundant with drawableContentRectOfSubtree.
  • replaced all the "setDrawableContentRect" logic with more intuitive, clear logic.
  • now, layer's drawableContentRect represents the clipped bounds of the layer expressed in the target surface space.

(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):
(WebCore::pointIsClippedBySurfaceOrClipRect):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::layerScissorRectInTargetSurface):
Updated this accessor. It could be removed in the future, but not appropriate for this patch.

  • platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

Many tests needed to be updated because the semantics of the layer tree have changed:

  • a few tests that were no longer applicable were removed.
  • many tests needed to have fixed initialization, properly setting surface contentRect and rootLayer bounds.
  • because clipRect and usesLayerClipping no longer exists, those places in code had to be removed/changed
  • the scissorRect tests needed to have updated expectations because after this patch, the rootLayer Surface now clips to its contentBounds.
  • the clipRect tests were changed to test the layer's new semantics for the drawableContentRect instead.
  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):

  • tests/LayerChromiumTest.cpp:
1:37 PM Changeset in webkit [123374] by commit-queue@webkit.org
  • 20 edits
    4 moves in trunk

[WK2] WebKitTestRunner needs to print information about Web intents
https://bugs.webkit.org/show_bug.cgi?id=90873

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
Reviewed by Anders Carlsson.

Source/WebKit2:

Add Bundle API for Web Intents. This is needed by the WebKitTestRunner
to print information about the new intent requests and the intent
service registrations.

  • CMakeLists.txt: Move WebIntentData and WebIntentServiceInfo from

UIProcess/ to Shared/.

  • GNUmakefile.list.am: Move WebIntentData and WebIntentServiceInfo from

UIProcess/ to Shared/.

  • Shared/APIClientTraits.h:
  • Shared/WebIntentData.cpp: Renamed from Source/WebKit2/UIProcess/WebIntentData.cpp.

(WebKit):
(WebKit::WebIntentData::WebIntentData):
(WebKit::WebIntentData::data):
(WebKit::WebIntentData::suggestions):
(WebKit::WebIntentData::extra):
(WebKit::WebIntentData::extras):

  • Shared/WebIntentData.h: Renamed from Source/WebKit2/UIProcess/WebIntentData.h.

(WebKit):
(WebIntentData):
(WebKit::WebIntentData::create):
(WebKit::WebIntentData::~WebIntentData):
(WebKit::WebIntentData::action):
(WebKit::WebIntentData::payloadType):
(WebKit::WebIntentData::service):
(WebKit::WebIntentData::store):
(WebKit::WebIntentData::type):

  • Shared/WebIntentServiceInfo.cpp: Renamed from Source/WebKit2/UIProcess/WebIntentServiceInfo.cpp.

(WebKit):
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):

  • Shared/WebIntentServiceInfo.h: Renamed from Source/WebKit2/UIProcess/WebIntentServiceInfo.h.

(WebKit):
(WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::create):
(WebKit::WebIntentServiceInfo::~WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::action):
(WebKit::WebIntentServiceInfo::payloadType):
(WebKit::WebIntentServiceInfo::href):
(WebKit::WebIntentServiceInfo::title):
(WebKit::WebIntentServiceInfo::disposition):
(WebKit::WebIntentServiceInfo::type):

  • Target.pri: Move WebIntentData and WebIntentServiceInfo from

UIProcess/ to Shared/.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didReceiveIntentForFrame):
(registerIntentServiceForFrame):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didReceiveIntentForFrame):
(WebKit::WebLoaderClient::registerIntentServiceForFrame):

  • UIProcess/WebLoaderClient.h:

(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::registerIntentServiceForFrame):
(WebKit::WebPageProxy::didReceiveIntentForFrame):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit):
(WebKit::InjectedBundlePageLoaderClient::didReceiveIntentForFrame):
(WebKit::InjectedBundlePageLoaderClient::registerIntentServiceForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

(WebKit):
(InjectedBundlePageLoaderClient):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchIntent):
(WebKit::WebFrameLoaderClient::registerIntentService):

  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

Tools:

Print out information about new intents requests and intent
services registrations in WebKitTestRunner. This is expected
by tests under webintents/*.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didReceiveIntentForFrame):
(WTR):
(WTR::InjectedBundlePage::registerIntentServiceForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):

1:32 PM Changeset in webkit [123373] by caio.oliveira@openbossa.org
  • 3 edits in trunk/LayoutTests

[Qt] tables/mozilla_expected_failures rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92013

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
1:26 PM Changeset in webkit [123372] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk/Source/WebKit2

[EFL][WK2] Add unit tests for Ewk_Cookie_Manager
https://bugs.webkit.org/show_bug.cgi?id=91639

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
Reviewed by Antonio Gomes.

Add unit tests for Ewk_Cookie_Manager.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_cookie_manager.h: Fix "accept policy" documentation

to indicate that only cookies set by the main document are accepted by default.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp: Added.

(EWK2UnitTestServer::EWK2UnitTestServer): Add HTTP server similar to the one
used by GTK port unit tests.
(EWK2UnitTestServer::~EWK2UnitTestServer):
(EWK2UnitTestServer::run):
(EWK2UnitTestServer::getURIForPath):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h: Added.

(EWK2UnitTestServer):
(EWK2UnitTestServer::baseURI):

  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp: Added.

(serverCallback):
(getAcceptPolicyCallback):
(getAcceptPolicy):
(getHostnamesWithCookiesCallback):
(getHostnamesWithCookies):
(freeHostNames):
(countHostnamesWithCookies):
(TEST_F):
(cleanUpCookieFiles):

1:23 PM Changeset in webkit [123371] by Patrick Gansterer
  • 3 edits in trunk/Source/WebKit/win

Build fix if NOMINMAX is defined by the build system.

  • COMEnumVariant.h: Added #ifndef NOMINMAX around #define NOMINMAX.
  • COMPropertyBag.h: Ditto.
1:22 PM Changeset in webkit [123370] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix build on Ubuntu Precise.
https://bugs.webkit.org/show_bug.cgi?id=92021

Reviewed by Adrienne Walker.

Remove an array that's written but never read.

  • tests/CCResourceProviderTest.cpp:

(WebKit::TEST_F):

1:16 PM Changeset in webkit [123369] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[CMAKE] Added missing RenderLayerFilterInfo.cpp to build system.

  • CMakeLists.txt:
1:06 PM Changeset in webkit [123368] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017

Patch by Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> on 2012-07-23
Reviewed by Alexis Menard.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
1:01 PM Changeset in webkit [123367] by caio.oliveira@openbossa.org
  • 11 edits
    2 adds in trunk/LayoutTests

[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017

Reviewed by Alexis Menard.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
12:54 PM Changeset in webkit [123366] by rafael.lobo@openbossa.org
  • 42 edits
    8 adds
    2 deletes in trunk/LayoutTests

[Qt] svg/zoom needs update after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92007

Reviewed by Alexis Menard.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
  • platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/qt/Skipped:
  • platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-background-images-expected.png:
  • platform/qt/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/qt/svg/zoom/page/zoom-foreign-content-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
12:49 PM Changeset in webkit [123365] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change to ignore DEBUG failures for policy-ignore-crash.php.

  • platform/chromium/TestExpectations:
12:44 PM Changeset in webkit [123364] by caio.oliveira@openbossa.org
  • 20 edits
    3 deletes in trunk/LayoutTests

Unreviewed, rolling out r123362.
http://trac.webkit.org/changeset/123362
https://bugs.webkit.org/show_bug.cgi?id=92020

uploaded wrong expectations :( bad caio (Requested by cmarcelo
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23

  • platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Removed.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Removed.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
12:38 PM Changeset in webkit [123363] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change to mark inline-plaintext-relayout-with-leading-neutrals.html flaky.
https://bugs.webkit.org/show_bug.cgi?id=92019

  • platform/chromium/TestExpectations:
12:32 PM Changeset in webkit [123362] by caio.oliveira@openbossa.org
  • 20 edits
    1 copy
    2 adds in trunk/LayoutTests

[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017

Reviewed by Alexis Menard.

  • platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Copied from LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
12:31 PM Changeset in webkit [123361] by Nate Chapin
  • 3 edits in trunk/Source/WebKit/chromium

Add WebTextInputType enum values for text areas and
content-editable.
https://bugs.webkit.org/show_bug.cgi?id=91654

Reviewed by Adam Barth.

No new tests, no behavior change without corresponding chromium.org changes.

  • public/WebTextInputType.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputType):

12:26 PM Changeset in webkit [123360] by dpranke@chromium.org
  • 9 edits in trunk/Tools

nrwt: never finds binaries in the 'out' dir on chromium win
https://bugs.webkit.org/show_bug.cgi?id=91890

Reviewed by Tony Chang.

We were figuring out which directory look in for binaries by
testing for the base directory (the directory above
Debug/Release). In chromium-win's case, we look in src/build,
which always exists because there are checked-in files in it,
which means we'd always pick that directory over src/out. All of
the other ports' build_path() implementation was including
Debug/Release. If we matched that, we wouldn't have a problem,
so this change fixes that and updates all of the callers of the
chromium ports' implementation to not pass configuration as part
of the path to look up; we still need to pass configuration in
some cases (to test if the build is out of date between debug
and release) so the implementation gets slightly more
complicated.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_build_path):

12:26 PM Changeset in webkit [123359] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r123281): childNodes sometimes returns wrong nodes
https://bugs.webkit.org/show_bug.cgi?id=92014

Reviewed by Anders Carlsson.

Source/WebCore:

The bug was caused by a typo in itemBeforeOrAfter. Namely, it should have been calling firstNode as
firstNode(forward, rootNode(), shouldOnlyIncludeDirectChildren()),
NOT firstNode(forward, rootNode(), previous)
as evident from the argument list of the function.

Test: fast/dom/NodeList/childNodes-reverse-iteration.html

  • html/HTMLCollection.cpp:

(WebCore::DynamicNodeListCacheBase::itemBeforeOrAfter):

LayoutTests:

Added an integration regression test that caught this bug.

  • fast/dom/NodeList/childNodes-reverse-iteration-expected.txt: Added.
  • fast/dom/NodeList/childNodes-reverse-iteration.html: Added.
11:58 AM Changeset in webkit [123358] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk/LayoutTests

[Qt] animations needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=91997

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-23
Reviewed by Noam Rosenthal.

Updating skipped tests inside animations directory.

  • platform/qt-5.0/Skipped:
  • platform/qt/animations/3d/change-transform-in-end-event-expected.txt: Added.
  • platform/qt/animations/3d/state-at-end-event-transform-expected.txt:
  • platform/qt/animations/additive-transform-animations-expected.txt:
  • platform/qt/animations/cross-fade-background-image-expected.txt:
  • platform/qt/animations/cross-fade-border-image-source-expected.txt:
  • platform/qt/animations/cross-fade-list-style-image-expected.txt:
  • platform/qt/animations/cross-fade-webkit-mask-box-image-expected.txt:
  • platform/qt/animations/cross-fade-webkit-mask-image-expected.txt:
  • platform/qt/animations/missing-values-first-keyframe-expected.txt:
  • platform/qt/animations/missing-values-last-keyframe-expected.txt:
  • platform/qt/animations/state-at-end-event-expected.txt:
11:54 AM Changeset in webkit [123357] by pfeldman@chromium.org
  • 3 edits in branches/chromium/1180/Source/WebCore/inspector/front-end

Merge 122979 - Web Inspector: [Regression] Save as file is missing in Network panel preview/response tabs.
https://bugs.webkit.org/show_bug.cgi?id=91625

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/HandlerRegistry.js:
  • inspector/front-end/NetworkPanel.js:

TBR=pfeldman@chromium.org
BUG=137863
Review URL: https://chromiumcodereview.appspot.com/10796093

11:48 AM Changeset in webkit [123356] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Chrome/Skia: PDF print output does not have clickable links.
https://bugs.webkit.org/show_bug.cgi?id=91171

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2012-07-23
Reviewed by Stephen White.

Connect GraphicsContext::setURLForRect to Skia's new API for annotations.

Printing is not generally testable.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setURLForRect):

11:45 AM Changeset in webkit [123355] by pierre.rossi@gmail.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Enable touch slider when touch events are enabled
https://bugs.webkit.org/show_bug.cgi?id=91013

Reviewed by Antonio Gomes.

Take advantage of the logic introduced in r122286.

  • Target.pri:
11:31 AM Changeset in webkit [123354] by pierre.rossi@gmail.com
  • 37 edits in trunk

Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client
https://bugs.webkit.org/show_bug.cgi?id=91006

Reviewed by Ryosuke Niwa.

Source/WebCore:

The rationale here is that the client doesn't need to know about the touch
event handler count. needTouchEvents was already used for that purpose.

Test: fast/events/touch/touch-handler-count.html

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didAddTouchEventHandler): Only notify the client if needed.
(WebCore::Document::didRemoveTouchEventHandler): Ditto. Also unset the TOUCH_LISTENER
flag for the document if we reach a count of zero. The rationale being that
hasListenerType() is relied upon in other places in combination with TOUCH_LISTENER for
the same purpose.

  • dom/Document.h:

(Document):
(WebCore::Document::touchEventHandlerCount):

  • loader/EmptyClients.h:
  • page/ChromeClient.h:

(ChromeClient):

  • page/Frame.cpp: Removed notifyChromeClientTouchEventHandlerCountChanged.

(WebCore::Frame::setDocument): call needsTouchEvents directly.

  • page/Frame.h: Ditto.

(Frame):

  • testing/Internals.cpp:

(WebCore::Internals::hasTouchEventListener): expose Document::hasListenerType indirectly
for additional testing.
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/blackberry:

Removed numTouchEventHandlersChanged stub.

  • WebCoreSupport/ChromeClientBlackBerry.h:

Source/WebKit/chromium:

Rename the functions to follow a more boolean logic.

  • public/WebViewClient.h:

(WebKit::WebViewClient::hasTouchEventHandlers):

  • src/ChromeClientImpl.cpp:

(WebKit):
(WebKit::ChromeClientImpl::needTouchEvents):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::hasTouchEventHandlers):

  • src/WebViewImpl.h:

(WebViewImpl):

Source/WebKit/efl:

Removed numTouchEventHandlersChanged stub.

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

Remove numTouchEventHandlersChanged stub.

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/mac:

Remove numTouchEventHandlersChanged stub.

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/qt:

Remove numTouchEventHandlersChanged stub.

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

Remove numTouchEventHandlersChanged stub.

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

Remove numTouchEventHandlersChanged stub.

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

Remove numTouchEventHandlersChanged stub.

  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

Remove numTouchEventHandlersChanged stub.

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

LayoutTests:

Extend the touch-handler-count test to also cover the hasListenerType logic.

  • fast/events/touch/touch-handler-count-expected.txt:
  • fast/events/touch/touch-handler-count.html:
11:23 AM Changeset in webkit [123353] by caio.oliveira@openbossa.org
  • 8 edits in trunk/Source

[Qt] RenderThemeQtMobile highlight colors are not being used
https://bugs.webkit.org/show_bug.cgi?id=92004

Reviewed by Noam Rosenthal.

Source/WebCore:

The issue here is that setPaletteFromPageClientIfExists() is being used as a
virtual function, but it isn't, so when platformActiveSelectionBackgroundColor()
runs, it doesn't pick the right palette.

Besides fixing this virtual behavior, the patch changes the structure a bit,
because setPaletteFromPageClientIfExists() was being "overriden" in mobile theme
to set the palette, which isn't exactly what the function name says.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformFocusRingColor):
(WebCore::RenderThemeQt::systemColor):
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
Use the virtual colorPalette() to get the palette.

(WebCore::RenderThemeQt::colorPalette):
(WebCore): Removed the code for getting the page client from here since it is
used only by the QStyle variant.

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::colorPalette):
(WebCore):

  • platform/qt/RenderThemeQtMobile.h:

(RenderThemeQtMobile):

Source/WebKit/qt:

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists): Moved here since
it's used only by RenderThemeQStyle. Remove unnecessary check for m_page->chrome().
(WebCore):
(WebCore::RenderThemeQStyle::colorPalette):

  • WebCoreSupport/RenderThemeQStyle.h:

(RenderThemeQStyle):

11:17 AM Changeset in webkit [123352] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change to mark fast/frames/frameset-frameborder-boolean-values.html as slow on snowleopard.
https://bugs.webkit.org/show_bug.cgi?id=24182

  • platform/chromium/TestExpectations:
11:06 AM Changeset in webkit [123351] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium change to mark sandboxed-iframe-navigation-parent.html as slow on Windows.
https://bugs.webkit.org/show_bug.cgi?id=24182

  • platform/chromium/TestExpectations:
10:45 AM Changeset in webkit [123350] by Simon Fraser
  • 13 edits in trunk

Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

  • features.gypi:

Source/WebKit/mac: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.

  • Configurations/FeatureDefines.xcconfig:
10:44 AM Changeset in webkit [123349] by atwilson@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed chromium expectations change after r123302.
https://bugs.webkit.org/show_bug.cgi?id-91806

  • platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.png:
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
10:27 AM Changeset in webkit [123348] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change to ignore failures for policy-ignore-crash.php.

  • platform/chromium/TestExpectations:
10:25 AM WebKit Team edited by leo.yang@torchmobile.com.cn
(diff)
9:25 AM Changeset in webkit [123347] by scheib@chromium.org
  • 6 edits in trunk/LayoutTests

Skip http/tests/pointer-lock on ports that do not support pointer lock.

Unreviewed.

  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
9:25 AM Changeset in webkit [123346] by Philippe Normand
  • 7 edits in trunk

Unreviewed, rolling out r123339.
http://trac.webkit.org/changeset/123339
https://bugs.webkit.org/show_bug.cgi?id=92006

massive media tests failure (Requested by philn on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23

Source/WebCore:

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(setGstElementClassMetadata):

  • platform/graphics/gstreamer/GStreamerVersioning.h:

Tools:

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

  • gtk/jhbuild.modules:
9:15 AM Changeset in webkit [123345] by tommyw@google.com
  • 6 edits in trunk

[chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown
https://bugs.webkit.org/show_bug.cgi?id=91857

Reviewed by Adam Barth.

Source/Platform:

Made Platforms destructor virtual.

  • chromium/public/Platform.h:

(WebKit::Platform::~Platform):

Tools:

Made a few changes so that the destructor could be called at shutdown.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
(WebKitSupportTestEnvironment):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::create):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.h:

(MockWebKitPlatformSupport):
(MockWebKitPlatformSupport::~MockWebKitPlatformSupport):

8:59 AM Changeset in webkit [123344] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WTF

[BlackBerry] Merge createThreadInternal implementations
https://bugs.webkit.org/show_bug.cgi?id=91899

Reviewed by Yong Li.

PR 111675

Remove our implementation since the default thread stack size on QNX is fine.

  • wtf/ThreadingPthreads.cpp:

(WTF::createThreadInternal):
(WTF::initializeCurrentThreadInternal): make sure we set the thread name.

8:50 AM Changeset in webkit [123343] by scheib@chromium.org
  • 8 edits
    12 adds in trunk

webkitFullscreenElement, webkitCurrentFullScreenElement, webkitPointerLockElement block cross origin access.
https://bugs.webkit.org/show_bug.cgi?id=91892

Reviewed by Adam Barth.

Source/WebCore:

PointerLockElement only returned when requested from the document that owns it.

Tests: http/tests/fullscreen/fullscreenelement-different-origin.html

http/tests/fullscreen/fullscreenelement-same-origin.html
http/tests/pointer-lock/pointerlockelement-different-origin.html
http/tests/pointer-lock/pointerlockelement-same-origin.html

  • dom/Document.cpp:

(WebCore::Document::webkitPointerLockElement):

LayoutTests:

Tests verifying the behavior of accessing
webkitFullscreenElement, webkitCurrentFullScreenElement, webkitPointerLockElement
from different origins.

  • http/tests/fullscreen/fullscreenelement-different-origin-expected.txt: Added.
  • http/tests/fullscreen/fullscreenelement-different-origin.html: Added.
  • http/tests/fullscreen/fullscreenelement-same-origin-expected.txt: Added.
  • http/tests/fullscreen/fullscreenelement-same-origin.html: Added.
  • http/tests/pointer-lock/pointerlockelement-different-origin-expected.txt: Added.
  • http/tests/pointer-lock/pointerlockelement-different-origin.html: Added.
  • http/tests/pointer-lock/pointerlockelement-same-origin-expected.txt: Added.
  • http/tests/pointer-lock/pointerlockelement-same-origin.html: Added.
  • http/tests/resources/pointer-lock/iframe-common.js: Added.

(thisFileName):
(window.onmessage):

  • http/tests/resources/pointer-lock/inner-iframe.html: Added.
  • http/tests/resources/pointer-lock/pointer-lock-test-harness.js:

(runOnKeyPress.keypressHandler):

  • pointer-lock/locked-element-iframe-removed-from-dom-expected.txt:
  • pointer-lock/locked-element-iframe-removed-from-dom.html:
  • pointer-lock/locked-element-removed-from-dom-expected.txt:
  • pointer-lock/locked-element-removed-from-dom.html:
8:49 AM Changeset in webkit [123342] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[BlackBerry] Implement GCActivityCallback with platform timer
https://bugs.webkit.org/show_bug.cgi?id=90175

Patch by Yong Li <yoli@rim.com> on 2012-07-23
Reviewed by Rob Buis.

Use JSLock when performing GC to avoid assertions.

  • runtime/GCActivityCallbackBlackBerry.cpp:

(JSC::DefaultGCActivityCallback::doWork):

8:49 AM Changeset in webkit [123341] by commit-queue@webkit.org
  • 6 edits
    5 adds in trunk/Source/WebKit2

[EFL][WK2] Add request manager client
https://bugs.webkit.org/show_bug.cgi?id=91193

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Add a URL request manager client and attach it
to the Ewk_Context.

The client application can now register a URL scheme
via the Ewk_Context API and provide a callback handler
that will get called whenever a URL request with this
scheme is made.

A new Ewk_Url_Scheme_Request type is introduced to
provide information about the request to the client
and to allow the client to finish it by setting its
contents.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Url_Scheme_Handler):
(_Ewk_Url_Scheme_Handler::_Ewk_Url_Scheme_Handler):
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(ewk_context_request_manager_get):
(ewk_context_url_scheme_request_received):
(createDefaultEwkContext):
(ewk_context_uri_scheme_register):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_private.h:
  • UIProcess/API/efl/ewk_context_request_manager_client.cpp: Added.

(toEwkContext):
(didReceiveURIRequest):
(ewk_context_request_manager_client_attach):

  • UIProcess/API/efl/ewk_context_request_manager_client_private.h: Added.
  • UIProcess/API/efl/ewk_url_scheme_request.cpp: Added.

(_Ewk_Url_Scheme_Request):
(_Ewk_Url_Scheme_Request::_Ewk_Url_Scheme_Request):
(_Ewk_Url_Scheme_Request::~_Ewk_Url_Scheme_Request):
(ewk_url_scheme_request_ref):
(ewk_url_scheme_request_unref):
(ewk_url_scheme_request_scheme_get):
(ewk_url_scheme_request_url_get):
(ewk_url_scheme_request_path_get):
(ewk_url_scheme_request_id_get):
(ewk_url_scheme_request_finish):
(ewk_url_scheme_request_new):

  • UIProcess/API/efl/ewk_url_scheme_request.h: Added.
  • UIProcess/API/efl/ewk_url_scheme_request_private.h: Added.
8:39 AM Changeset in webkit [123340] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding the WONTFIX modifier to a few more tests,
moving them to the top of the expected failures section.

  • platform/gtk/TestExpectations:
8:39 AM Changeset in webkit [123339] by Philippe Normand
  • 7 edits in trunk

[GTK][jhbuild] Switch to GStreamer 0.11 build
https://bugs.webkit.org/show_bug.cgi?id=91727

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Add a new function to encapsulate the GStreamer API removal of
GST_OBJECT_IS_FLOATING in the upcoming 1.0 release. Use of this
macro can now be replaced by calling the g_object_is_floating
function.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(gstObjectIsFloating):

  • platform/graphics/gstreamer/GStreamerVersioning.h:

Tools:

Switch build-webkit --gtk to GStreamer 0.11 support and build the
necessary GStreamer git modules from JHBuild.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.

  • gtk/jhbuild.modules: GStreamer build support.
8:01 AM Changeset in webkit [123338] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the failing tests.

  • platform/qt/Skipped:
7:17 AM Changeset in webkit [123337] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] DumpRenderTree does not use 'monospace' font when directed
https://bugs.webkit.org/show_bug.cgi?id=85203

Unreviewed gardening.

  • platform/qt-4.8/Skipped: Unskip now passing tests.
7:15 AM Changeset in webkit [123336] by caio.oliveira@openbossa.org
  • 2 edits
    2 deletes in trunk/LayoutTests

[Qt] editing/inserting/multiple-lines-selected.html fails
https://bugs.webkit.org/show_bug.cgi?id=91993

Reviewed by Simon Hausmann.

Removing wrong expected results, adding it to the skipped list.

  • platform/qt-5.0/Skipped:
  • platform/qt/editing/inserting/multiple-lines-selected-expected.png: Removed.
  • platform/qt/editing/inserting/multiple-lines-selected-expected.txt: Removed.
6:53 AM Changeset in webkit [123335] by caio.oliveira@openbossa.org
  • 10 edits
    2 adds
    15 deletes in trunk/LayoutTests

[Qt] editing/inserting rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=91985

Unreviewed.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.png: Removed.
  • platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.txt: Removed.
  • platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.png: Removed.
  • platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.txt: Removed.
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/editing/inserting/5549929-2-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/5549929-3-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-001-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-002-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-003-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-tab-001-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-tab-002-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-tab-004-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-001-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-002-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-003-expected.txt: Removed.
  • platform/qt/editing/inserting/4960120-1-expected.png:
  • platform/qt/editing/inserting/before-after-input-element-expected.png:
  • platform/qt/editing/inserting/insert-3654864-fix-expected.txt:
  • platform/qt/editing/inserting/insert-3851164-fix-expected.txt:
  • platform/qt/editing/inserting/insert-div-009-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-009-expected.txt:
  • platform/qt/editing/inserting/insert-div-010-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-010-expected.txt:
6:30 AM Changeset in webkit [123334] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] media/controls-styling.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91984

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
Reviewed by Eric Carlson.

Source/WebCore:

Make sure that the CSS properties letter-spacing, word-spacing,
line-height, text-transform, text-indent, text-shadow,
text-decoration and color do not affect the media element controls,
that display text.

No new tests. Already tested by media/controls-styling.html and
media/controls-styling-strict.html

  • css/mediaControlsEfl.css:

(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):

LayoutTests:

Rebaseline media controls styling tests now that the
EFL port properly ensures that overriding CSS
properties won't affect the media controls.

  • platform/efl/media/controls-styling-expected.png:
  • platform/efl/media/controls-styling-expected.txt:
  • platform/efl/media/controls-styling-strict-expected.png:
  • platform/efl/media/controls-styling-strict-expected.txt:
5:15 AM Changeset in webkit [123333] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] fast/layers/video-layer.html needs rebasing after r123320
https://bugs.webkit.org/show_bug.cgi?id=91978

Unreviewed EFL gardening, regenerate baseline for
fast/layers/video-layer.html after r123320.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23

  • platform/efl/fast/layers/video-layer-expected.txt:
4:44 AM Changeset in webkit [123332] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped:
4:37 AM Changeset in webkit [123331] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit2

[EFL][WK2] ProcessExecutablePath is required
https://bugs.webkit.org/show_bug.cgi?id=89719

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Added executablePathOfWebProcess and executablePathOfPluginProcess.
It's used for getting the location of WebProcess and PluginProcess.

  • PlatformEfl.cmake: Added LIBEXECDIR definition
  • Shared/efl/ProcessExecutablePathEfl.cpp: Added.

(WebKit):
(WebKit::findWebKitProcess):
(WebKit::executablePathOfWebProcess): Get the absolute path of WebProcess
(WebKit::executablePathOfPluginProcess): Get the absolute path of PluginProcess

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess): Modified to use above routines

4:27 AM Changeset in webkit [123330] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing header files.
4:19 AM Changeset in webkit [123329] by tkent@chromium.org
  • 10 edits in trunk/Source/WebCore

Replace some instances of shadowAncestorNode() with shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=91966

Reviewed by Hajime Morita.

shadowAncestorNode() is deprecated. We should use shadowHost().
No new tests. This doesn't change any behavior.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

  • dom/TreeScope.cpp:

(WebCore::listTreeScopes):

  • html/HTMLSummaryElement.cpp:

(WebCore::isClickableControl):

  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::summaryElement):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::meterElement):

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressShadowElement::progressElement):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderThumb::layout):
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::hostInput):
(WebCore::TrackLimiterElement::shadowPseudoId):
(WebCore::SliderContainerElement::shadowPseudoId):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::customStyleForRenderer):
(WebCore::TextControlInnerTextElement::defaultEventHandler):
(WebCore::TextControlInnerTextElement::createRenderer):
(WebCore::TextControlInnerTextElement::customStyleForRenderer):
(WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::step):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setState):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlInnerBlock::positionForPoint):

4:18 AM Changeset in webkit [123328] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

[WK2] REGRESSION r122966: Crash when closing tab with Web Inspector open in WebKit::PageOverlay
https://bugs.webkit.org/show_bug.cgi?id=91782

Reviewed by Yury Semikhatsky.

hideHighlight was never called once user hovered over a node.

  • inspector/DOMNodeHighlighter.cpp:

(WebCore::InspectorOverlay::update):

4:07 AM Changeset in webkit [123327] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] new test introduced in r123205 fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=91967

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Skipped WebInspector test that needs CSS Regions enabled.

  • platform/qt/Skipped:
3:54 AM Changeset in webkit [123326] by peter@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Build fix for the Windows builder following r123311
https://bugs.webkit.org/show_bug.cgi?id=91979

Unreviewed build fix.

Changeset r123311 moved the TextCodecWinCE.{cpp,h} files to the Windows
directory. Update Chromium's references to these files to fix the build.

  • WebCore.gypi:
3:36 AM Changeset in webkit [123325] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Buildfix for fixing gclient on the Chromium Windows bot
https://bugs.webkit.org/show_bug.cgi?id=91977

Unreviewed build fix.

Add the tools/isolate directory to the Windows checkout as these files
currently are missing during gyp generation. maruel introduced the need
for these in this isolate refactoring, specifically this Chromium CL:
http://src.chromium.org/viewvc/chrome?view=rev&revision=147689

  • DEPS:
3:05 AM Changeset in webkit [123324] by Patrick Gansterer
  • 5 edits in trunk

[WINCE] Define NOMINMAX in the build system instead of Platform.h
https://bugs.webkit.org/show_bug.cgi?id=91938

Reviewed by Ryosuke Niwa.

.:

Define it in OptionsWindows.cmake, since NOMINMAX
should to be defined for all windows ports.

  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmake/OptionsWindows.cmake:

Source/WTF:

  • wtf/Platform.h:
2:58 AM Changeset in webkit [123323] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[WIN] Remove ICU dependencies from UniscribeController
https://bugs.webkit.org/show_bug.cgi?id=91921

Reviewed by Ryosuke Niwa.

Replace ICU specific functions and macros with the corresponding code from WTF::Unicode.
This allows us to use UniscribeController with an other Unicode implementation too.

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::advance):

2:47 AM Changeset in webkit [123322] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Build fix for Windows after r123317.

  • wtf/DateMath.cpp: Added missing header include.
2:47 AM Changeset in webkit [123321] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Marking more svg/W3C-SVG-1.1/animate-elem-* tests as flaky.

  • platform/gtk/TestExpectations:
2:23 AM Changeset in webkit [123320] by commit-queue@webkit.org
  • 18 edits
    2 adds in trunk

[EFL] media/controls-styling-strict.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91960

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use "display: -webkit-box;" instead of inline-block
for current-time control. This is needed because
inline-block behaves differently in strict mode.

No new test, already tested by media/controls-styling-strict.html

  • css/mediaControlsEfl.css:

(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):

LayoutTests:

Update test expectations for media tests now that
we use "display: -webkit-box;" for the current-time
control.

  • platform/efl/media/audio-controls-rendering-expected.txt:
  • platform/efl/media/audio-repaint-expected.png:
  • platform/efl/media/audio-repaint-expected.txt:
  • platform/efl/media/controls-layout-direction-expected.png:
  • platform/efl/media/controls-strict-expected.png:
  • platform/efl/media/controls-strict-expected.txt:
  • platform/efl/media/controls-styling-expected.txt:
  • platform/efl/media/controls-styling-strict-expected.png: Added.
  • platform/efl/media/controls-styling-strict-expected.txt: Added.
  • platform/efl/media/media-controls-clone-expected.png:
  • platform/efl/media/media-controls-clone-expected.txt:
  • platform/efl/media/video-aspect-ratio-expected.png:
  • platform/efl/media/video-layer-crash-expected.png:
  • platform/efl/media/video-transformed-expected.png:
  • platform/efl/media/video-zoom-controls-expected.png:
  • platform/efl/media/video-zoom-controls-expected.txt:
  • platform/efl/media/video-zoom-expected.png:
1:43 AM Changeset in webkit [123319] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

Unreviewed. Fix GTK+ build with ENABLE_DATALIST_ELEMENT.

Add an implementation for virtual pure methods sliderTickSize()
and sliderTickOffsetFromTrackCenter() when HTML5 datalist element
is enabled.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore):
(WebCore::RenderThemeGtk::sliderTickSize):
(WebCore::RenderThemeGtk::sliderTickOffsetFromTrackCenter):

  • platform/gtk/RenderThemeGtk.h:
1:36 AM Changeset in webkit [123318] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip http/tests/inspector-enabled/injected-script-discard.html
https://bugs.webkit.org/show_bug.cgi?id=91959

Unreviewed EFL gardening. Skip flaky Web Inspector test case.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23

  • platform/efl/TestExpectations:
1:34 AM Changeset in webkit [123317] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

[WIN] Use GetTimeZoneInformation() for calculateUTCOffset()
https://bugs.webkit.org/show_bug.cgi?id=91935

Reviewed by Ryosuke Niwa.

GetTimeZoneInformation() returns the offset directly. Using it
avoids unnecessary calculations and remove dependencies on
other time related function, which do not exist on WinCE.

  • wtf/DateMath.cpp:

(WTF::calculateUTCOffset):

1:33 AM Changeset in webkit [123316] by commit-queue@webkit.org
  • 9 edits in trunk

WebKit2 needs layoutTestController.setAlwaysAcceptCookies
https://bugs.webkit.org/show_bug.cgi?id=42778

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add setAlwaysAcceptCookies() method to InjectedBundle
so that we can use it in LayoutTestController.
The method uses WebCookieManager::setHTTPCookieAcceptPolicy()
internally.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetAlwaysAcceptCookies):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setAlwaysAcceptCookies):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Add support for layoutTestController.setAlwaysAcceptCookies()
since it is required by some tests.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setAlwaysAcceptCookies):
(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

1:30 AM Changeset in webkit [123315] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebKit2

[WK2] SQL Database cannot be disabled at build time
https://bugs.webkit.org/show_bug.cgi?id=91837

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

WebKit2 had no #ifdefs for SQL Database. This patch adds these
statments and it can now be disabled at build time.

  • Shared/OriginAndDatabases.cpp:
  • Shared/OriginAndDatabases.h:
  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC):

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetDatabaseManager):

  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerGetTypeID):
(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):
(WKDatabaseManagerSetClient):
(WKDatabaseManagerGetDatabasesByOrigin):
(callGetDatabasesByOriginBlockAndDispose):
(WKDatabaseManagerGetDatabasesByOrigin_b):
(WKDatabaseManagerGetDatabaseOrigins):
(callGetDatabaseOriginsBlockBlockAndDispose):
(WKDatabaseManagerGetDatabaseOrigins_b):
(WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
(WKDatabaseManagerDeleteDatabasesForOrigin):
(WKDatabaseManagerDeleteAllDatabases):
(WKDatabaseManagerSetQuotaForOrigin):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebDatabaseManagerProxy.cpp:
  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.messages.in:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::clearAllDatabases):
(WebKit::InjectedBundle::setDatabaseQuota):

  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):

1:24 AM Changeset in webkit [123314] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Replace getCurrentLocalTime() with GetLocalTime() in LocaleWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=91937

Reviewed by Ryosuke Niwa.

The windows function returns the required year directly and
removes one additonal dependecy on getCurrentLocalTime().

  • platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::LocaleWin):

1:18 AM Changeset in webkit [123313] by vsevik@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: Drag and drop should not be started on right mouse click.
https://bugs.webkit.org/show_bug.cgi?id=91728

Reviewed by Pavel Feldman.

Introduced WebInspector.installDragHandle method to control drag and drop support, checking whichg mouse button is pressed.
Simplified WebInspector._elementDragStart, removed "element" parameter.
Simplified tab moving support in TabbedPane, removed "mousemove" handler.
Removed while loop determining which element was dragged in TimelineOverviewPane, each drag support is now installed independently.
Drive-by: fixed TimelineOverviewPane window moving on resources-dividers-label-bar drang-and-drop.
Drive-by: fixed CSSStyleModel compilation.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._positionResizers):
(WebInspector.DataGrid.prototype._startResizerDragging):
(WebInspector.DataGrid.prototype._endResizerDragging):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer):
(WebInspector.Drawer.prototype._animationDuration):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._endStatusBarDragging):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._startRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._endRetainersHeaderDragging):

  • inspector/front-end/SidebarOverlay.js:

(WebInspector.SidebarOverlay.prototype.set _startResizerDragging):
(WebInspector.SidebarOverlay.prototype._endResizerDragging):
(WebInspector.SidebarOverlay.prototype._installResizer):

  • inspector/front-end/Spectrum.js:
  • inspector/front-end/SplitView.js:

(WebInspector.SplitView.prototype._startResizerDragging):
(WebInspector.SplitView.prototype._endResizerDragging):
(WebInspector.SplitView.prototype.installResizer):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabMouseDown):
(WebInspector.TabbedPaneTab.prototype._startTabDragging):
(WebInspector.TabbedPaneTab.prototype._endTabDragging):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype._leftResizeElementDragging):
(WebInspector.TimelineOverviewWindow.prototype._rightResizeElementDragging):
(WebInspector.TimelineOverviewWindow.prototype._startWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._startWindowDragging):
(WebInspector.TimelineOverviewWindow.prototype._windowDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowDragging):
(WebInspector.TimelineOverviewWindow.prototype._moveWindow):
(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._startSplitterDragging):
(WebInspector.TimelinePanel.prototype._endSplitterDragging):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDragEnd):

  • inspector/front-end/UIUtils.js:

(WebInspector.installDragHandle):
(WebInspector._elementDragStart):
(WebInspector._elementDragEnd):

  • inspector/front-end/timelinePanel.css:

(#timeline-overview-grid .resources-dividers-label-bar):

1:08 AM Changeset in webkit [123312] by hayato@chromium.org
  • 6 edits in trunk

ComposedShadowTreeWalker should skip an empty insertion points.
https://bugs.webkit.org/show_bug.cgi?id=91826

Reviewed by Hajime Morita.

Source/WebCore:

ComposedShadowTreeWalker wrongly returns 'null' if it encounters
an insertion point into where no nodes are distributed. We should
skip such an insertion point and continue walking using the next
possible node, which might be a next sibling or a next distributed
node, and resolve the next node recursively.

Test: fast/dom/shadow/composed-shadow-tree-walker.html

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseLightChildren):
(WebCore):
(WebCore::ComposedShadowTreeWalker::traverseSiblings):
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseDistributedeNodes):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseSiblingInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseBackToYoungerShadowRoot):

  • dom/ComposedShadowTreeWalker.h:

(ComposedShadowTreeWalker):

LayoutTests:

  • fast/dom/shadow/composed-shadow-tree-walker-expected.txt:
  • fast/dom/shadow/composed-shadow-tree-walker.html:
1:06 AM Changeset in webkit [123311] by Patrick Gansterer
  • 3 edits
    2 moves in trunk/Source/WebCore

Rename TextCodecWinCE to TextCodecWin
https://bugs.webkit.org/show_bug.cgi?id=91947

Reviewed by Ryosuke Niwa.

Since TextCodecWinCE is used by other (non-upstreamed) windows ports too,
TextCodecWin is a better name for the implementation.
Also remove the dependency on WinCE FontCache to make it more usable.

  • PlatformWinCE.cmake:
  • platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps):

  • platform/text/win/TextCodecWin.cpp: Renamed from Source/WebCore/platform/text/wince/TextCodecWinCE.cpp.
  • platform/text/win/TextCodecWin.h: Renamed from Source/WebCore/platform/text/wince/TextCodecWinCE.h.
1:00 AM Changeset in webkit [123310] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the new failing tests.

  • platform/qt/Skipped:
12:53 AM Changeset in webkit [123309] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Improve AudioChannelSplitter test
https://bugs.webkit.org/show_bug.cgi?id=91962

Patch by Li Yin <li.yin@intel.com> on 2012-07-23
Reviewed by Kentaro Hara.

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioChannelSplitter-section
The numberOfOutputs parameter determines the number of outputs.
Values of up to 32 must be supported. If not specified, then 6 will be used.

  • webaudio/audiochannelsplitter-expected.txt:
  • webaudio/audiochannelsplitter.html:

Jul 22, 2012:

9:55 PM Changeset in webkit [123308] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

[V8] CodeGeneratorV8.pm should support static attributes
https://bugs.webkit.org/show_bug.cgi?id=91764

Reviewed by Adam Barth.

CodeGeneratorJS.pm already supports static attributes.
CodeGeneratorV8.pm should also support them.

Tests: bindings/scripts/test/TestObj.idl

bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):

  • bindings/scripts/test/TestObj.idl: Added defined(TESTING_V8).
  • bindings/scripts/test/TestSupplemental.idl: Added test cases for static attributes in supplemental IDL files.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.

(WebCore):
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
The generated code is wrong since CodeGeneratorJS.pm does not support static attributes for
supplemental IDL files. I will fix it in a follow-up patch.
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Updated run-bindings-tests results.

(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetter):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::staticReadOnlyIntAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
(WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
(WebCore):

8:55 PM Changeset in webkit [123307] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium-Mac] Fix a build error.

  • DEPS: Add third_party/GTM.
8:33 PM FeatureFlags edited by tkent@chromium.org
Rename some flags to _ELEMENT (diff)
7:11 PM Changeset in webkit [123306] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Improve BiquadFilterNode test case
https://bugs.webkit.org/show_bug.cgi?id=90937

Patch by Li Yin <li.yin@intel.com> on 2012-07-22
Reviewed by Kentaro Hara.

Spec: http://www.w3.org/TR/webaudio/#BiquadFilterNode
Improve BiquadFilterNode test to cover constant value and number of inputs and outputs.

  • webaudio/biquadfilternode-basic-expected.txt:
  • webaudio/biquadfilternode-basic.html:
6:27 PM Changeset in webkit [123305] by gyuyoung.kim@samsung.com
  • 10 edits in trunk/Source/WebCore

Missing *explicit* keyword in storage and workers.
https://bugs.webkit.org/show_bug.cgi?id=91934

Reviewed by Kentaro Hara.

Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.

No new tests. Convered by existing tests.

  • storage/StorageAreaImpl.h:

(StorageAreaImpl):

  • storage/StorageMap.h:

(StorageMap):

  • storage/StorageSyncManager.h:

(StorageSyncManager):

  • storage/StorageTask.h:

(StorageTask):

  • storage/StorageTracker.h:

(StorageTracker):

  • workers/SharedWorker.h:

(SharedWorker):

  • workers/Worker.h:

(Worker):

  • workers/WorkerLocation.h:

(WebCore::WorkerLocation::WorkerLocation):

  • workers/WorkerMessagingProxy.h:

(WorkerMessagingProxy):

6:17 PM Changeset in webkit [123304] by yosin@chromium.org
  • 48 edits in trunk/LayoutTests/platform

Unreviewed. Set missing SVN property svn:mime-type=image/png to PNG files in
/LayoutTests/fast/forms/ and LayoutTests/platfrom/*fast/forms

6:08 PM Changeset in webkit [123303] by commit-queue@webkit.org
  • 3 edits in trunk

Unreviewed, rolling out r123298 and r123301.
http://trac.webkit.org/changeset/123298
http://trac.webkit.org/changeset/123301
https://bugs.webkit.org/show_bug.cgi?id=91953

We need to think some more about the intricacies of exposing a
CMake option for ENABLE_DFG_JIT as this option is specific to
the port and architecture. (Requested by dydx on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-22

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
6:00 PM Changeset in webkit [123302] by yosin@chromium.org
  • 11 edits
    98 moves in trunk/LayoutTests

[Tests] Rename fast/forms/number/*.html to number-*.html
https://bugs.webkit.org/show_bug.cgi?id=91806

Reviewed by Kent Tamura.

This patch renames test scripts and expected text/images to same
naming scheme(name starts with "number-"), for fast/forms/number.

This patch also updates TestExpectations and Skipped files in platform
directory for test name change.

This patch is a part of forms input type test arrangement.
https://bugs.webkit.org/show_bug.cgi?id=91805

  • fast/forms/number/ValidityState-rangeOverflow-number-expected.txt: Removed.
  • fast/forms/number/ValidityState-rangeOverflow-number.html: Removed.
  • fast/forms/number/ValidityState-rangeUnderflow-number-expected.txt: Removed.
  • fast/forms/number/ValidityState-rangeUnderflow-number.html: Removed.
  • fast/forms/number/ValidityState-stepMismatch-number-expected.txt: Removed.
  • fast/forms/number/ValidityState-stepMismatch-number.html: Removed.
  • fast/forms/number/ValidityState-typeMismatch-number-expected.txt: Removed.
  • fast/forms/number/ValidityState-typeMismatch-number.html: Removed.
  • fast/forms/number/input-appearance-number-rtl.html: Removed.
  • fast/forms/number/input-appearance-spinbutton-disabled-readonly.html: Removed.
  • fast/forms/number/input-appearance-spinbutton-layer.html: Removed.
  • fast/forms/number/input-appearance-spinbutton-visibility-expected.html: Removed.
  • fast/forms/number/input-appearance-spinbutton-visibility.html: Removed.
  • fast/forms/number/input-number-blur-twice-expected.txt: Removed.
  • fast/forms/number/input-number-blur-twice.html: Removed.
  • fast/forms/number/input-number-change-type-on-focus-expected.txt: Removed.
  • fast/forms/number/input-number-change-type-on-focus.html: Removed.
  • fast/forms/number/input-number-commit-valid-only-expected.txt: Removed.
  • fast/forms/number/input-number-commit-valid-only.html: Removed.
  • fast/forms/number/input-number-crash-expected.txt: Removed.
  • fast/forms/number/input-number-crash.html: Removed.
  • fast/forms/number/input-number-events-expected.txt: Removed.
  • fast/forms/number/input-number-events.html: Removed.
  • fast/forms/number/input-number-keyoperation-expected.txt: Removed.
  • fast/forms/number/input-number-keyoperation.html: Removed.
  • fast/forms/number/input-number-large-padding-expected.txt: Removed.
  • fast/forms/number/input-number-large-padding.html: Removed.
  • fast/forms/number/input-number-outofrange-expected.txt: Removed.
  • fast/forms/number/input-number-outofrange.html: Removed.
  • fast/forms/number/input-number-size-expected.txt: Removed.
  • fast/forms/number/input-number-size.html: Removed.
  • fast/forms/number/input-number-spinbutton-crash-expected.txt: Removed.
  • fast/forms/number/input-number-spinbutton-crash.html: Removed.
  • fast/forms/number/input-number-unacceptable-style-expected.txt: Removed.
  • fast/forms/number/input-number-unacceptable-style.html: Removed.
  • fast/forms/number/input-number-validation-message-expected.txt: Removed.
  • fast/forms/number/input-number-validation-message.html: Removed.
  • fast/forms/number/input-number-wheel-expected.txt: Removed.
  • fast/forms/number/input-number-wheel.html: Removed.
  • fast/forms/number/input-spinbutton-capturing-expected.txt: Removed.
  • fast/forms/number/input-spinbutton-capturing.html: Removed.
  • fast/forms/number/input-valueasnumber-number-expected.txt: Removed.
  • fast/forms/number/input-valueasnumber-number.html: Removed.
  • fast/forms/number/number-appearance-rtl.html: Copied from LayoutTests/fast/forms/number/input-appearance-number-rtl.html.
  • fast/forms/number/number-appearance-spinbutton-disabled-readonly.html: Copied from LayoutTests/fast/forms/number/input-appearance-spinbutton-disabled-readonly.html.
  • fast/forms/number/number-appearance-spinbutton-layer.html: Copied from LayoutTests/fast/forms/number/input-appearance-spinbutton-layer.html.
  • fast/forms/number/number-appearance-spinbutton-visibility-expected.html: Copied from LayoutTests/fast/forms/number/input-appearance-spinbutton-visibility-expected.html.
  • fast/forms/number/number-appearance-spinbutton-visibility.html: Copied from LayoutTests/fast/forms/number/input-appearance-spinbutton-visibility.html.
  • fast/forms/number/number-blur-twice-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-blur-twice-expected.txt.
  • fast/forms/number/number-blur-twice.html: Copied from LayoutTests/fast/forms/number/input-number-blur-twice.html.
  • fast/forms/number/number-change-type-on-focus-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-change-type-on-focus-expected.txt.
  • fast/forms/number/number-change-type-on-focus.html: Copied from LayoutTests/fast/forms/number/input-number-change-type-on-focus.html.
  • fast/forms/number/number-commit-valid-only-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-commit-valid-only-expected.txt.
  • fast/forms/number/number-commit-valid-only.html: Copied from LayoutTests/fast/forms/number/input-number-commit-valid-only.html.
  • fast/forms/number/number-crash-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-crash-expected.txt.
  • fast/forms/number/number-crash.html: Copied from LayoutTests/fast/forms/number/input-number-crash.html.
  • fast/forms/number/number-events-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-events-expected.txt.
  • fast/forms/number/number-events.html: Copied from LayoutTests/fast/forms/number/input-number-events.html.
  • fast/forms/number/number-keyoperation-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-keyoperation-expected.txt.
  • fast/forms/number/number-keyoperation.html: Copied from LayoutTests/fast/forms/number/input-number-keyoperation.html.
  • fast/forms/number/number-large-padding-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-large-padding-expected.txt.
  • fast/forms/number/number-large-padding.html: Copied from LayoutTests/fast/forms/number/input-number-large-padding.html.
  • fast/forms/number/number-outofrange-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-outofrange-expected.txt.
  • fast/forms/number/number-outofrange.html: Copied from LayoutTests/fast/forms/number/input-number-outofrange.html.
  • fast/forms/number/number-size-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-size-expected.txt.
  • fast/forms/number/number-size.html: Copied from LayoutTests/fast/forms/number/input-number-size.html.
  • fast/forms/number/number-spinbutton-capturing-expected.txt: Copied from LayoutTests/fast/forms/number/input-spinbutton-capturing-expected.txt.
  • fast/forms/number/number-spinbutton-capturing.html: Copied from LayoutTests/fast/forms/number/input-spinbutton-capturing.html.
  • fast/forms/number/number-spinbutton-crash-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-spinbutton-crash-expected.txt.
  • fast/forms/number/number-spinbutton-crash.html: Copied from LayoutTests/fast/forms/number/input-number-spinbutton-crash.html.
  • fast/forms/number/number-spinbutton-events-expected.txt: Copied from LayoutTests/fast/forms/number/spin-button-events-expected.txt.
  • fast/forms/number/number-spinbutton-events.html: Copied from LayoutTests/fast/forms/number/spin-button-events.html.
  • fast/forms/number/number-spinbutton-gets-disabled-or-readonly-expected.txt: Copied from LayoutTests/fast/forms/number/spin-button-gets-disabled-or-readonly-expected.txt.
  • fast/forms/number/number-spinbutton-gets-disabled-or-readonly.html: Copied from LayoutTests/fast/forms/number/spin-button-gets-disabled-or-readonly.html.
  • fast/forms/number/number-spinbutton-in-multi-column-expected.txt: Copied from LayoutTests/fast/forms/number/spin-in-multi-column-expected.txt.
  • fast/forms/number/number-spinbutton-in-multi-column.html: Copied from LayoutTests/fast/forms/number/spin-in-multi-column.html.
  • fast/forms/number/number-spinbutton-state-expected.txt: Copied from LayoutTests/fast/forms/number/spin-button-state-expected.txt.
  • fast/forms/number/number-spinbutton-state.html: Copied from LayoutTests/fast/forms/number/spin-button-state.html.
  • fast/forms/number/number-unacceptable-style-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-unacceptable-style-expected.txt.
  • fast/forms/number/number-unacceptable-style.html: Copied from LayoutTests/fast/forms/number/input-number-unacceptable-style.html.
  • fast/forms/number/number-validation-message-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-validation-message-expected.txt.
  • fast/forms/number/number-validation-message.html: Copied from LayoutTests/fast/forms/number/input-number-validation-message.html.
  • fast/forms/number/number-validity-state-range-underflow-expected.txt: Copied from LayoutTests/fast/forms/number/ValidityState-rangeUnderflow-number-expected.txt.
  • fast/forms/number/number-validity-state-range-underflow.html: Copied from LayoutTests/fast/forms/number/ValidityState-rangeUnderflow-number.html.
  • fast/forms/number/number-validity-state-step-mismatch-expected.txt: Copied from LayoutTests/fast/forms/number/ValidityState-stepMismatch-number-expected.txt.
  • fast/forms/number/number-validity-state-step-mismatch.html: Copied from LayoutTests/fast/forms/number/ValidityState-stepMismatch-number.html.
  • fast/forms/number/number-validity-state-type-mismatch-expected.txt: Copied from LayoutTests/fast/forms/number/ValidityState-typeMismatch-number-expected.txt.
  • fast/forms/number/number-validity-state-type-mismatch.html: Copied from LayoutTests/fast/forms/number/ValidityState-typeMismatch-number.html.
  • fast/forms/number/number-validitystate-range-overflow-expected.txt: Copied from LayoutTests/fast/forms/number/ValidityState-rangeOverflow-number-expected.txt.
  • fast/forms/number/number-validitystate-range-overflow.html: Copied from LayoutTests/fast/forms/number/ValidityState-rangeOverflow-number.html.
  • fast/forms/number/number-valueasnumber-expected.txt: Copied from LayoutTests/fast/forms/number/input-valueasnumber-number-expected.txt.
  • fast/forms/number/number-valueasnumber.html: Copied from LayoutTests/fast/forms/number/input-valueasnumber-number.html.
  • fast/forms/number/number-wheel-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-wheel-expected.txt.
  • fast/forms/number/number-wheel.html: Copied from LayoutTests/fast/forms/number/input-number-wheel.html.
  • fast/forms/number/spin-button-events-expected.txt: Removed.
  • fast/forms/number/spin-button-events.html: Removed.
  • fast/forms/number/spin-button-gets-disabled-or-readonly-expected.txt: Removed.
  • fast/forms/number/spin-button-gets-disabled-or-readonly.html: Removed.
  • fast/forms/number/spin-button-state-expected.txt: Removed.
  • fast/forms/number/spin-button-state.html: Removed.
  • fast/forms/number/spin-in-multi-column-expected.txt: Removed.
  • fast/forms/number/spin-in-multi-column.html: Removed.
  • platform/chromium-linux/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-linux/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt.
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/efl/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/efl/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt.
  • platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
  • platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/gtk/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt.
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/mac/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/mac/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt.
  • platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
  • platform/qt-4.8/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.txt.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
  • platform/qt-arm/TestExpectations:
  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/qt/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/qt/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt.
  • platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
  • platform/win-wk2/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
5:00 PM Changeset in webkit [123301] by dbates@webkit.org
  • 2 edits in trunk

Fix the Windows CE build after <http://trac.webkit.org/changeset/123298>
(https://bugs.webkit.org/show_bug.cgi?id=91939)

Disable the DFG JIT across all CMake ports (by default) (*). Enabling DFG JIT
breaks the Windows CE build as the Windows CE port builds with the JIT disabled
(ENABLE_JIT := 0) and hence ENABLE_ASSEMBLER := 0.

(*) We should look to further discuss with CMake port maintainers about enabling
the DFG JIT by default.

  • Source/cmake/WebKitFeatures.cmake:
4:23 PM Changeset in webkit [123300] by tkent@chromium.org
  • 77 edits in trunk

Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
https://bugs.webkit.org/show_bug.cgi?id=91941

Reviewed by Kentaro Hara.

A flag name for an elmement should be ENABLE_*_ELEMENT.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • accessibility/AXObjectCache.cpp:

(WebCore::createFromRenderer):

  • accessibility/AccessibilityProgressIndicator.cpp:
  • accessibility/AccessibilityProgressIndicator.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/html.css:
  • html/HTMLMeterElement.cpp:
  • html/HTMLMeterElement.h:
  • html/HTMLMeterElement.idl:
  • html/HTMLProgressElement.cpp:
  • html/HTMLProgressElement.h:
  • html/HTMLProgressElement.idl:
  • html/HTMLTagNames.in:
  • html/shadow/MeterShadowElement.cpp:
  • html/shadow/MeterShadowElement.h: Wrap with #if ENABLE(METER_ELEMENT).
  • html/shadow/ProgressShadowElement.cpp:
  • html/shadow/ProgressShadowElement.h: Wrap with #if ENABLE(PROGRESS_ELEMENT).
  • page/DOMWindow.idl:
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::edjeGroupFromFormType):
(WebCore):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore):

  • platform/gtk/RenderThemeGtk.h:

(RenderThemeGtk):

  • platform/gtk/RenderThemeGtk2.cpp:

(WebCore):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore):

  • platform/qt/RenderThemeQt.cpp:

(WebCore):

  • platform/qt/RenderThemeQt.h:

(WebCore):
(RenderThemeQt):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore):

  • platform/qt/RenderThemeQtMobile.h:

(RenderThemeQtMobile):

  • rendering/RenderMeter.cpp:
  • rendering/RenderMeter.h:
  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderProgress.cpp:
  • rendering/RenderProgress.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore):

  • rendering/RenderTheme.h:

(WebCore):
(RenderTheme):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore):

  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore):

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):

  • rendering/RenderThemeChromiumWin.h:

(RenderThemeChromiumWin):

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore):

Source/WebKit:

  • PlatformEfl.cmake:

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/efl:

  • DefaultTheme/default.edc:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/qt:

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore):

  • WebCoreSupport/RenderThemeQStyle.h:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • fast/dom/wrapper-classes.html:
11:06 AM Changeset in webkit [123299] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

Shamed into removing some BUGSENORBLANCOs from previous gardening
stints.

  • platform/chromium/TestExpectations:
9:36 AM Changeset in webkit [123298] by Patrick Gansterer
  • 3 edits in trunk

[CMake] Add option for ENABLE_DFG_JIT
https://bugs.webkit.org/show_bug.cgi?id=91939

Reviewed by Daniel Bates.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
9:24 AM Changeset in webkit [123297] by senorblanco@chromium.org
  • 7 edits in trunk/LayoutTests

[chromium] Test result gardening; unreviewed.

  • platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium/TestExpectations:
3:59 AM Changeset in webkit [123296] by tkent@chromium.org
  • 31 edits in trunk

Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT
https://bugs.webkit.org/show_bug.cgi?id=91928

Reviewed by Kentaro Hara.

A flag name for an elmement should be ENABLE_*_ELEMENT.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • html/HTMLDetailsElement.cpp:
  • html/HTMLDetailsElement.idl:
  • html/HTMLSummaryElement.cpp:
  • html/HTMLTagNames.in:
  • html/shadow/DetailsMarkerControl.cpp:
  • rendering/RenderDetailsMarker.cpp:
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
1:04 AM Changeset in webkit [123295] by zandobersek@gmail.com
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening, adding baselines for the media/controls-styling-strict.html
test and skip a subpixel layout test that's crashing on debug builds (the
feature is disabled at the moment so the failure is somewhat acceptable).

  • platform/gtk/TestExpectations:
  • platform/gtk/media/controls-styling-strict-expected.png: Added.
  • platform/gtk/media/controls-styling-strict-expected.txt: Added.

Jul 21, 2012:

2:54 PM Changeset in webkit [123294] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/11928576> SVG-as-image (constrained) intrinsic size calculation is wrong in vertical writing modes
https://bugs.webkit.org/show_bug.cgi?id=91918

Reviewed by Anders Carlsson.

Source/WebCore:

Test: svg/as-image/svg-intrinsic-size-rectangular-vertical.html

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox): When there is a content
renderer, it returns a physical intrinsic size and aspect ratio. The code was already
accounting for this by taking the reciprocal of the aspect ratio in the vertical case. Made
it also transpose the size itself, turning it from physical to logical. Moved this code
after setting m_intrinsicSize, since that member variable is always physical.

LayoutTests:

  • svg/as-image/svg-intrinsic-size-rectangular-vertical-expected.html: Added.
  • svg/as-image/svg-intrinsic-size-rectangular-vertical.html: Added.
2:22 PM Changeset in webkit [123293] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[WIN] Use GetDateFormat and GetTimeFormat instead of strftime
https://bugs.webkit.org/show_bug.cgi?id=83436

Reviewed by Brent Fulgham.

The MS CRT implementation of strftime calls the same two functions.
Using them directly avoids the overhead of parsing the format string and removes
the dependency on strftime() for WinCE where this function does not exist.

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

11:33 AM Changeset in webkit [123292] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-21

  • DEPS:
7:50 AM Changeset in webkit [123291] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

Cleanup TextEncoding USE(XXX_UNICODE) macros
https://bugs.webkit.org/show_bug.cgi?id=91923

Reviewed by Andreas Kling.

Replace PLATFORM(QT) with USE(QT4_UNICODE) and OS(WINCE) with USE(WINCE_UNICODE).
This gives us more flexibility in choosing the unicode backend for a port.

  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps):

4:10 AM Changeset in webkit [123290] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Remove unnecessary ICU header includes from SimpleFontDataWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=91922

Reviewed by Kentaro Hara.

This allows us to use SimpleFontDataWin with an other Unicode implementation too.

  • platform/graphics/win/SimpleFontDataWin.cpp:
1:01 AM Changeset in webkit [123289] by kseo@webkit.org
  • 4 edits in trunk/Source/WebCore

A start tag whose tag name is "html" in the "in body" insertion mode is a parse error
https://bugs.webkit.org/show_bug.cgi?id=91916

Reviewed by Eric Seidel.

According to the HTML5 spec, a start tag whose tag name is "html" in the "in body"
insertion mode is a parse error.

Added HTMLTreeBuilder::processHtmlStartTagForInBody(AtomicHTMLToken&) to call parseError(token).
Removed "FIXME: parse error" from HTMLConstructionSite::insertHTMLHtmlStartTagInBody and
HTMLConstructionSite::insertHTMLBodyStartTagInBody because we already marked the call sites
of these two methods with parseError(token).

No behavior change because parseError(token) is just a marker.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):

  • html/parser/HTMLTreeBuilder.h:
Note: See TracTimeline for information about the timeline view.