Context Navigation

← Previous Period
Next Period →

Timeline

Jul 30, 2012:

11:55 PM Changeset in webkit [124178] by commit-queue@webkit.org

10 edits in trunk/Source

[Texmap] Remove the backing store after 'style.visibility' for an element sets 'hidden'.
https://bugs.webkit.org/show_bug.cgi?id=92492

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-30
Reviewed by Noam Rosenthal.

Source/WebCore:

This patch's purpose is to save vram memory.
When visibility of the element sets hidden, we do not need to draw the element,
so we do not need to keep a texture of the backing store.
Currently, Texmap does not draw the element with visibility:hidden because
RenderLayerBacking::paintIntoLayer does not draw anything.
This patch just removes unused textures.

No new tests - no new testable functionality.

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsVisible):
(WebCore):

platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):

platform/graphics/texmap/TextureMapperLayer.h:

(State):
(WebCore::TextureMapperLayer::State::State):

Source/WebKit2:

Texmap handles visibility:hidden in this patch, so WebGraphicsLayer
sends the LayerTreeCoordinatorProxyMessages with additional infomation
to UIProcess.

Shared/WebLayerTreeInfo.h:
UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::setLayerState):

WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setContentsVisible):
(WebCore):
(WebCore::WebGraphicsLayer::syncLayerState):

WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.h:

(WebGraphicsLayer):

11:52 PM Changeset in webkit [124177] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/gtk

[GTK] New lines automatically and repeatedly added to list items in Etherpad
https://bugs.webkit.org/show_bug.cgi?id=89971

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-07-30
Reviewed by Ryosuke Niwa.

Disable the deletion UI by default. This UI, which was enabled as a side-effect
of the addition of the private editing API, seems to expose a bug in Etherpad
which causes the continuous insertion of bullet points.

WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::shouldShowDeleteInterface): Disable the deletion UI by default.

11:41 PM EFLWebKit edited by tmpsantos@gmail.com

(diff)

11:27 PM Changeset in webkit [124176] by keishi@webkit.org

11 edits
1 move
4 adds
3 deletes in trunk

Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075

Reviewed by Kent Tamura.

Source/Platform:

chromium/public/WebLocalizedString.h: Added OtherColorLabel.

Source/WebCore:

Test: platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html

rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Added color to types supporting datalist.

Source/WebKit/chromium:

Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController.
ColorChooserUIController can control whether to open the color suggestion picker
popup or the color chooser depending on the responses from ColorChooserClient.

WebKit.gyp:
src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser.
(WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium.

src/ChromeClientImpl.h:

(WebKit):
(ChromeClientImpl):

src/ColorChooserProxy.cpp: Removed.
src/ColorChooserProxy.h: Removed.
src/ColorChooserUIController.cpp: Added.

(WebKit):
(WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient.
(WebKit::ColorChooserUIController::~ColorChooserUIController):
(WebKit::ColorChooserUIController::setSelectedColor):
(WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser.
(WebKit::ColorChooserUIController::didChooseColor):
(WebKit::ColorChooserUIController::didEndChooser):
(WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size.
(WebKit::ColorChooserUIController::writeDocument):
(WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue.
(WebKit::ColorChooserUIController::didClosePopup):
(WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup.
(WebKit::ColorChooserUIController::closePopup):
(WebKit::ColorChooserUIController::openColorChooser): Opens color chooser.

src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h.

(WebCore):
(WebKit):
(ColorChooserUIController):

src/WebColorChooserClientImpl.cpp: Removed.

LayoutTests:

platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
platform/chromium/TestExpectations:
platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Added.
platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Added. Tests color suggestion picker popup appearance.
platform/chromium/fast/forms/datalist/input-list-expected.txt:

11:19 PM Changeset in webkit [124175] by rniwa@webkit.org

2 edits in trunk

/api/test/runs/chart expires on perf-o-matic
https://bugs.webkit.org/show_bug.cgi?id=92714

Reviewed by Hajime Morita.

Don't update the entire JSON while generating the dashboard images.
This is a bug and not doing this will reduce the server load significantly.

Websites/webkit-perf.appspot.com/controller.py:

(RunsChartHandler.post):

10:46 PM Changeset in webkit [124174] by commit-queue@webkit.org

10 edits in trunk/Source/WebCore

Unreviewed, rolling out r124171.
http://trac.webkit.org/changeset/124171
https://bugs.webkit.org/show_bug.cgi?id=92712

Start failing fast/css/square-button-appearance.html
(Requested by yosin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

dom/Element.cpp:
dom/Element.h:

(Element):
(WebCore::Element::isReadOnlyFormControl):

html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElement::isReadOnlyFormControl):

html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::isReadOnlyFormControl):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):

html/shadow/SliderThumbElement.h:

(SliderThumbElement):

html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents):
(WebCore::SpinButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):

html/shadow/TextControlInnerElements.h:

(WebCore::SpinButtonElement::isReadOnlyFormControl):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isReadOnlyControl):

10:28 PM Changeset in webkit [124173] by tkent@chromium.org

3 edits in trunk/LayoutTests

[Chromium] Layout Test fast/forms/date/calendar-picker-appearance.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=92710

fast/forms/date/calendar-picker-appearance.html: Attempt to fix the flakiness.
platform/chromium/TestExpectations: Add an entry for calendar-picker-appearance.html.

9:20 PM Changeset in webkit [124172] by pkasting@chromium.org

13 edits
25 adds
2 deletes in trunk/LayoutTests

[Chromium] Baseline and expectation followups after r124142.
https://bugs.webkit.org/show_bug.cgi?id=62754
https://bugs.webkit.org/show_bug.cgi?id=80531
http://crbug.com/47826

Unreviewed, test updates.

platform/chromium-linux-x86/css2.1/20110323: Added.
platform/chromium-linux-x86/css2.1/20110323/block-replaced-width-001-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/block-replaced-width-001-expected.png: Added.
platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.txt: Removed.
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png: Removed.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.png: Added.
platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.txt:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
platform/chromium-win-xp/css2.1/20110323/block-replaced-width-001-expected.png: Added.
platform/chromium-win/css2.1/20110323/block-replaced-width-001-expected.png: Added.
platform/chromium-win/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
platform/chromium/TestExpectations:

9:19 PM Changeset in webkit [124171] by yosin@chromium.org

10 edits in trunk/Source/WebCore

[CSS] Change Element::isReadOnlyFormControl to shouldMatchReadWriteSelector or HTMLTextFormControlElement::readOnly
https://bugs.webkit.org/show_bug.cgi?id=92602

Reviewed by Kent Tamura.

This patch renames Element::isReadOnlyFormControl() to Element::shouldMatchReadWriteSelector()
or HTMLTextFormControlElement::readOnly() to make intention of
shouldMatchReadWriteSelector(was isReadOnlyFormControl) self descriptive.

No new tests. This patch doesn't change behavior.

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().

dom/Element.cpp:

(WebCore::Element::shouldMatchReadWriteSelector): Added default implementation.

dom/Element.h:

(WebCore::Element::shouldMatchReadWriteSelector): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().

html/HTMLFormControlElement.h:
html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::shouldMatchReadWriteSelector): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SliderThumbElement::willRespondToMouseClickEvents): ditto.

html/shadow/SliderThumbElement.h:

(SliderThumbElement): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().

html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().

html/shadow/TextControlInnerElements.h:
rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isReadOnlyControl): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().

8:49 PM Changeset in webkit [124170] by tkent@chromium.org

3 edits
6 adds in trunk/LayoutTests

[Chromium] Add baseline files for calendar-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=84827

platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png: Added.
platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png: Added.
platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png: Added.
platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png: Added.
platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png: Added.
platform/chromium/TestExpectations:

8:39 PM Changeset in webkit [124169] by weinig@apple.com

2 edits
1 add in trunk/Source/WebKit2

Add a proper umbrella header for the public WebKit2 API headers
https://bugs.webkit.org/show_bug.cgi?id=92708
<rdar://problem/11970825>

Reviewed by Dan Bernstein.

Create a new umbrella WebKit2.h and add the currently public (as decided by their
status in Xcode) Objective-C headers.

UIProcess/API/mac/WebKit2.h: Added.
WebKit2.xcodeproj/project.pbxproj:

While we are here, make WebKit2_C.h a private header.

8:38 PM Changeset in webkit [124168] by jchaffraix@webkit.org

6 edits in trunk/Source/WebCore

Remove overflow: scroll handling in block flow layout methods
https://bugs.webkit.org/show_bug.cgi?id=92689

Reviewed by Simon Fraser.

The overflow: scroll scrollbars creation was done at layout time for all RenderBlocks and
descendants. This was not only wrong ('overflow' only changes at style change time) but it
was also introducing some code duplication.

The gist of this change is to share the code by moving it to RenderLayer::updateScrollbarsAfterStyleChange,
this includes the code from bug 69993 to special case list box part.

Covered by existing tests:

All fast/overflow ones.
For the list box change:

fast/forms/select-overflow-scroll-inherited.html
fast/forms/select-overflow-scroll.html

For the flexbox:

css3/flexbox/preferred-widths-orthogonal.html
css3/flexbox/preferred-widths.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
Removed the common code here.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
Changed to an ASSERT now that the right scrollbars are created. This is
fine as overflow-x/y are physical coordinates and our access was following that.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::invalidateScrollbarRect):
Added an early return here if we are not attached yet as RenderLayer::styleChanged
is called at attachment time before we are inserted in the tree. This is fine as the
scrollbars are part of the object which will be painted after the first layout.

(WebCore::overflowRequiresAScrollbar):
(WebCore::overflowDefinesAutomaticScrollbar):
Split the logic in those 2 functions.

(WebCore::RenderLayer::updateScrollbarsAfterLayout):
Updated to use the require / can-have functions. Also added
an early return for list box parts as required by bug 69993.

(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):
Added an early return for list box parts as required by bug 69993,
also removed some unneeded NULL-checks that were added for list box parts.

8:36 PM Changeset in webkit [124167] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Roll out the DEPS roll (r124164) for now since it broke Chromium Mac builds.

DEPS:

8:31 PM Changeset in webkit [124166] by abarth@webkit.org

1 delete in branches/components

Removed old branch that is no longer needed (according to dglazkov).

8:22 PM Changeset in webkit [124165] by rniwa@webkit.org

2 edits in trunk/Tools

Revert r124153 and land the "right" build fix per ap's comment on the bug 92676.

MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

8:17 PM Changeset in webkit [124164] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

DEPS:

8:15 PM Changeset in webkit [124163] by weinig@apple.com

19 edits
1 move in trunk

Rename WebKit2.h to WebKit2_C.h
https://bugs.webkit.org/show_bug.cgi?id=92704

Reviewed by Dan Bernstein.

Source/WebKit2:

GNUmakefile.list.am:
Target.pri:
UIProcess/API/C/WebKit2_C.h: Renamed from Source/WebKit2/UIProcess/API/C/WebKit2.h.
UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
UIProcess/API/gtk/WebKitPolicyDecisionPrivate.h:
UIProcess/API/gtk/WebKitPrivate.h:
UIProcess/API/gtk/WebKitSettingsPrivate.h:
UIProcess/API/gtk/WebKitWebViewPrivate.h:
WebKit2.xcodeproj/project.pbxproj:
win/WebKit2.vcproj:
win/WebKit2Generated.make:

Update for changed header file name.

Tools:

MiniBrowser/mac/MiniBrowser_Prefix.pch:
MiniBrowser/win/BrowserView.h:
TestWebKitAPI/config.h:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
WebKitTestRunner/WebKitTestRunnerPrefix.h:
WebKitTestRunner/config.h:

Update for changed header file name.

8:15 PM Changeset in webkit [124162] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

fillWithEmptyClients method should also initialize chromeClient with EmptyChromeClient
https://bugs.webkit.org/show_bug.cgi?id=92703

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-30
Reviewed by Kent Tamura.

fillWithEmptyClients should also intialize PageClients.chromeClient with EmptyChromeClient
as its required for creating a Empty page and to minimize the exported symbols.

No new tests as no change in functionality.

loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):

8:10 PM Changeset in webkit [124161] by mitz@apple.com

4 copies
1 add in releases/Apple/Safari 6.0

Added a tag for the Safari 6.0 release.

Safari 6.0 includes JavaScriptCore-x536.24, WebCore-x536.24, WebKit-x536.25, and WebKit2-x536.25.

8:02 PM Changeset in webkit [124160] by enne@google.com

6 edits
2 adds in trunk/Source

[chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer
https://bugs.webkit.org/show_bug.cgi?id=91032

Reviewed by James Robinson.

Source/Platform:

Add WebScrollbarLayer class to the Platform API.

Platform.gypi:
chromium/public/WebScrollbarLayer.h: Added.

(WebCore):
(WebKit):
(WebScrollbarLayer):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::~WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):

Source/WebCore:

Modify ScrollingCoordinatorChromium to operate on WebScrollbarLayer
instead of ScrollbarLayerChromium. This removes the dependency on
ScrollbarLayerChromium.

No change in functionality, so no new tests.

page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):

Source/WebKit/chromium:

Add implementation of WebScrollbarLayer to the client API.

WebKit.gyp:
src/WebScrollbarLayer.cpp: Added.

(WebKit):
(WebKit::WebScrollbarLayer::setScrollLayer):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>):

7:57 PM Changeset in webkit [124159] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Another Qt build fix attempt after r124098.
"interface" is a keyword. Don't use it.

dom/GestureEvent.cpp:

(WebCore::GestureEvent::interfaceName):

7:56 PM Changeset in webkit [124158] by dpranke@chromium.org

1 edit
1 delete in trunk/Tools

chromium win compile broken after removing webkit.py
https://bugs.webkit.org/show_bug.cgi?id=92549

Reviewed by Ryosuke Niwa.

Remove the stub file for webkit.py now that it's no longer
necessary.

Scripts/webkitpy/layout_tests/port/webkit.py: Removed.

7:56 PM Changeset in webkit [124157] by commit-queue@webkit.org

8 edits
2 adds in trunk

Make QuotesData use a Vector of pairs
https://bugs.webkit.org/show_bug.cgi?id=92448

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-07-30
Reviewed by Julien Chaffraix.

Source/WebCore:

QuotesData::create returned an array of memory that contained in place instantiations
of a QuotesData and then String instances. This changes the code to use a Vector of
pairs making it safer and ensuring that quotes are always balanced. This also uses a
HashMap directly in the QuoteRenderer instead of building it on first access reducing
the amount of code needed for picking quotes by language.

Test: fast/css-generated-content/close-quote-negative-depth.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Create pairs and use the new QuotesData API.

rendering/RenderQuote.cpp:

(WebCore):
(WebCore::quotesDataLanguageMap): New function that returns the HashMap of languages.
(WebCore::basicQuotesData): Returns the simple form of quotes, " and '.
(WebCore::defaultQuotes): Changed to use the new map.
(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::originalText): Changed to use the new getOpenQuote and getCloseQuote which ensure bounds checks.

rendering/style/QuotesData.cpp:

(WebCore::QuotesData::create): Now returns a plain instance of QuotesData without the in place allocation.
(WebCore):
(WebCore::QuotesData::addPair): Adds an std::pair of strings ensuring quotes are always balanced.
(WebCore::QuotesData::getOpenQuote):
(WebCore::QuotesData::getCloseQuote):
(WebCore::QuotesData::equals): Renamed equals (added the s).

rendering/style/QuotesData.h:

(WebCore::QuotesData::create):
(QuotesData):
(WebCore::QuotesData::QuotesData):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setQuotes):

rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::operator==):

LayoutTests:

Test that when quote depths go negative we do not output quotes. The expected result
is wrong right now because we output quotes in this case when we should not.

fast/css-generated-content/close-quote-negative-depth-expected.html: Added.
fast/css-generated-content/close-quote-negative-depth.html: Added.

7:48 PM Changeset in webkit [124156] by morrita@google.com

3 edits
2 adds in trunk

Node::replaceChild() can create bad DOM topology with MutationEvent
https://bugs.webkit.org/show_bug.cgi?id=92619

Reviewed by Ryosuke Niwa.

Source/WebCore:

Node::replaceChild() calls insertBeforeCommon() after dispatching
a MutationEvent event for removeChild(). But insertBeforeCommon()
expects call sites to check the invariant and doesn't have
suffient check. So a MutationEvent handler can let some bad tree
topology to slip into insertBeforeCommon().

This change adds a guard for checking the invariant using
checkReplaceChild() between removeChild() and insertBeforeCommon().

Test: fast/events/mutation-during-replace-child.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceChild): Added a guard.

LayoutTests:

fast/events/mutation-during-replace-child-expected.txt: Added.
fast/events/mutation-during-replace-child.html: Added.

7:46 PM Changeset in webkit [124155] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Qt Windows build fix attempt after r124098.

dom/GestureEvent.cpp:

7:46 PM Changeset in webkit [124154] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Chromium] Enable web audio IPP for x86 chromium android
https://bugs.webkit.org/show_bug.cgi?id=91973

Patch by Wei James <james.wei@intel.com> on 2012-07-30
Reviewed by Tony Chang.

Include the IPP libraries at link-time for Android builds when
compiling the Web Audio API with IPP support.

WebCore.gyp/WebCore.gyp:

7:43 PM Changeset in webkit [124153] by rniwa@webkit.org

2 edits in trunk/Tools

Windows build fix attempt after r124092.

MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

7:17 PM Changeset in webkit [124152] by Lucas Forschler

2 edits in branches/safari-536.26-branch/Source/WebKit2

Merged r123658. <rdar://problem/11961131>

7:15 PM Changeset in webkit [124151] by Lucas Forschler

2 edits in branches/safari-536.26-branch/Source/WebKit2

Merged r123649. <rdar://problem/11961125>

7:13 PM Changeset in webkit [124150] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r123637. <rdar://problem/11961127>

7:08 PM Changeset in webkit [124149] by Lucas Forschler

2 edits in branches/safari-536.26-branch/Source/WebKit2

Merged r123630. <rdar://problem/11961135>

7:06 PM Changeset in webkit [124148] by rniwa@webkit.org

2 edits in trunk/Tools

Remove erroneously committed debugging print call from a test.

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_generates_results_page):

7:05 PM Changeset in webkit [124147] by Lucas Forschler

2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r123486. <rdar://problem/11954337>

7:01 PM Changeset in webkit [124146] by yosin@chromium.org

7 edits in trunk/Source

[Forms] Get rid of Element::isReadOnlyFormControl other than CSS related
https://bugs.webkit.org/show_bug.cgi?id=92612

Reviewed by Kent Tamura.

Source/WebCore:

This patch replaces Element::isReadOnlyFormControl() not related to
CSS selector matching to HTMLFormControlElement::readOnly() for
preparation of introducing Element::shouldMatchReadWriteSelector(), bug 92602.

No new tests. This patch doesn't change behavior.

html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::defaultEventHandler): Changed isReadOnlyFormControl() to readOnly().

html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Changed isReadOnlyFormControl() to readOnly().
(WebCore::SpinButtonElement::defaultEventHandler): ditto.
(WebCore::SpinButtonElement::step): ditto.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler): ditto.
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult): ditto.

rendering/RenderTextControl.cpp:

(updateUserModifyProperty): Changed isReadOnlyFormControl() to readOnly().

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton): Changed isReadOnlyFormControl() to readOnly().

Source/WebKit/blackberry:

This patch replaces Element::isReadOnlyFormControl() to
HTMLFormControlElement::readOnly() for preparation of introducing
Element::shouldMatchReadWriteSelector(), bug 92602.

WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement): Replaced isReadOnlyFormControl() by HTMLTextFormControlElement::readOnly().

7:00 PM Changeset in webkit [124145] by Lucas Forschler

4 edits in branches/safari-536.26-branch

Merged r123415. <rdar://problem/11954336>

6:57 PM Changeset in webkit [124144] by tkent@chromium.org

2 edits in trunk/LayoutTests

Fix a popup position issue of fast/forms/date/calendar-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=92609

Reviewed by Hajime Morita.

Force to lay out the document before opening a popup.

fast/forms/date/calendar-picker-appearance.html:

6:53 PM Changeset in webkit [124143] by Lucas Forschler

3 edits
1 copy in branches/safari-536.26-branch

Merged r123411. <rdar://problem/11954334>

6:50 PM Changeset in webkit [124142] by pkasting@chromium.org

418 edits
165 adds
7 deletes in trunk/LayoutTests

Unreviewed, test updates.

Most of the baselines here are for
http://trac.webkit.org/changeset/119431 and
http://trac.webkit.org/changeset/119748 , as well as some changes to
antialiasing (generally to improve it) for which I couldn't find a CL;
when these were originally landed and new baselines committed, a
Chromium test expectation override file was masking the fact that the
tests here needed new baselines as well.

There is also a small number of other changes mixed in.

platform/chromium-linux-x86/css1: Added.
platform/chromium-linux-x86/css1/basic: Added.
platform/chromium-linux-x86/css1/basic/class_as_selector-expected.png: Added.
platform/chromium-linux-x86/css1/basic/id_as_selector-expected.png: Added.
platform/chromium-linux-x86/css1/box_properties: Added.
platform/chromium-linux-x86/css1/box_properties/border_bottom-expected.png: Added.
platform/chromium-linux-x86/css1/box_properties/margin_left-expected.png: Added.
platform/chromium-linux-x86/css1/box_properties/padding_right-expected.png: Added.
platform/chromium-linux-x86/css1/pseudo: Added.
platform/chromium-linux-x86/css1/pseudo/anchor-expected.png: Added.
platform/chromium-linux-x86/editing/input: Added.
platform/chromium-linux-x86/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
platform/chromium-linux-x86/editing/selection: Removed.
platform/chromium-linux-x86/fast/backgrounds/repeat: Added.
platform/chromium-linux-x86/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
platform/chromium-linux-x86/fast/block/float: Added.
platform/chromium-linux-x86/fast/block/float/float-avoidance-expected.png: Added.
platform/chromium-linux-x86/fast/canvas/image-pattern-rotate-expected.png: Added.
platform/chromium-linux-x86/fast/events: Added.
platform/chromium-linux-x86/fast/events/autoscroll-expected.png: Added.
platform/chromium-linux-x86/fast/events/reveal-link-when-focused-expected.png: Added.
platform/chromium-linux-x86/fast/forms/textarea: Added.
platform/chromium-linux-x86/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
platform/chromium-linux-x86/fast/overflow: Added.
platform/chromium-linux-x86/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
platform/chromium-linux-x86/fast/selectors: Added.
platform/chromium-linux-x86/fast/selectors/166-expected.png: Added.
platform/chromium-linux-x86/fast/selectors/unqualified-hover-strict-expected.png: Added.
platform/chromium-linux-x86/fast/selectors/unqualified-hover-strict-expected.txt: Added.
platform/chromium-linux-x86/fast/transforms: Added.
platform/chromium-linux-x86/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
platform/chromium-linux-x86/fonts: Added.
platform/chromium-linux-x86/fonts/monospace-expected.png: Added.
platform/chromium-linux-x86/http/tests/navigation: Added.
platform/chromium-linux-x86/http/tests/navigation/javascriptlink-frames-expected.png: Added.
platform/chromium-linux-x86/ietestcenter: Added.
platform/chromium-linux-x86/ietestcenter/css3: Added.
platform/chromium-linux-x86/ietestcenter/css3/bordersbackgrounds: Added.
platform/chromium-linux-x86/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
platform/chromium-linux-x86/svg/as-image: Added.
platform/chromium-linux-x86/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
platform/chromium-linux-x86/svg/dom: Added.
platform/chromium-linux-x86/svg/dom/SVGTransformList-basics-expected.png: Added.
platform/chromium-linux-x86/svg/dom/css-transforms-expected.png: Added.
platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
platform/chromium-linux-x86/svg/wicd: Added.
platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.png: Added.
platform/chromium-linux-x86/tables/mozilla/marvin: Added.
platform/chromium-linux-x86/tables/mozilla/marvin/backgr_index-expected.png: Added.
platform/chromium-linux-x86/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
platform/chromium-linux-x86/transforms: Added.
platform/chromium-linux-x86/transforms/2d: Added.
platform/chromium-linux-x86/transforms/2d/hindi-rotated-expected.png: Added.
platform/chromium-linux-x86/transforms/2d/hindi-rotated-expected.txt: Added.
platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
platform/chromium-linux/css1/basic/class_as_selector-expected.png:
platform/chromium-linux/css1/basic/id_as_selector-expected.png:
platform/chromium-linux/css1/box_properties/border_bottom-expected.png:
platform/chromium-linux/css1/box_properties/margin_left-expected.png:
platform/chromium-linux/css1/box_properties/padding_right-expected.png:
platform/chromium-linux/css1/pseudo/anchor-expected.png:
platform/chromium-linux/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
platform/chromium-linux/editing/selection/iframe-expected.png:
platform/chromium-linux/editing/selection/select-all-001-expected.png:
platform/chromium-linux/editing/selection/select-all-002-expected.png:
platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png:
platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
platform/chromium-linux/fast/borders/border-radius-valid-border-clipping-expected.png:
platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-linux/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-linux/fast/canvas/image-pattern-rotate-expected.png:
platform/chromium-linux/fast/events/autoscroll-expected.png:
platform/chromium-linux/fast/events/reveal-link-when-focused-expected.png:
platform/chromium-linux/fast/forms/fieldset-align-expected.png:
platform/chromium-linux/fast/forms/input-appearance-selection-expected.png:
platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png:
platform/chromium-linux/fast/forms/input-table-expected.png:
platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png:
platform/chromium-linux/fast/forms/placeholder-position-expected.png:
platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png:
platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png:
platform/chromium-linux/fast/forms/textarea-scrollbar-expected.png:
platform/chromium-linux/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:
platform/chromium-linux/fast/html/details-position-expected.png:
platform/chromium-linux/fast/html/details-writing-mode-expected.png:
platform/chromium-linux/fast/overflow/overflow-update-transform-expected.png:
platform/chromium-linux/fast/overflow/overflow-with-local-background-attachment-expected.png:
platform/chromium-linux/fast/replaced/width100percent-radio-expected.png: Added.
platform/chromium-linux/fast/selectors/166-expected.png:
platform/chromium-linux/fast/selectors/unqualified-hover-strict-expected.png:
platform/chromium-linux/fast/selectors/unqualified-hover-strict-expected.txt: Added.
platform/chromium-linux/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
platform/chromium-linux/fonts/monospace-expected.png:
platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.png:
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
platform/chromium-linux/svg/as-image/image-respects-pageScaleFactor-expected.png:
platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
platform/chromium-linux/svg/custom/pattern-rotate-expected.png:
platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.png:
platform/chromium-linux/svg/dom/css-transforms-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png:
platform/chromium-linux/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
platform/chromium-linux/tables/mozilla/marvin/backgr_index-expected.png:
platform/chromium-linux/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
platform/chromium-linux/transforms/2d/hindi-rotated-expected.png:
platform/chromium-linux/transforms/2d/hindi-rotated-expected.txt:
platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
platform/chromium-mac-snowleopard/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Added.
platform/chromium-mac-snowleopard/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac-snowleopard/fast/canvas/image-pattern-rotate-expected.png:
platform/chromium-mac-snowleopard/svg/as-border-image: Removed.
platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png: Removed.
platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Removed.
platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
platform/chromium-mac-snowleopard/transforms/2d/hindi-rotated-expected.png:
platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
platform/chromium-mac/fast/borders/border-radius-valid-border-clipping-expected.png:
platform/chromium-mac/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png:
platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png:
platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png:
platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
platform/chromium-mac/transforms/2d/hindi-rotated-expected.png: Added.
platform/chromium-mac/transforms/2d/hindi-rotated-expected.txt: Added.
platform/chromium-win-xp/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
platform/chromium-win-xp/css1: Added.
platform/chromium-win-xp/css1/basic: Added.
platform/chromium-win-xp/css1/basic/class_as_selector-expected.png: Added.
platform/chromium-win-xp/css1/basic/containment-expected.png: Added.
platform/chromium-win-xp/css1/basic/id_as_selector-expected.png: Added.
platform/chromium-win-xp/css1/box_properties: Added.
platform/chromium-win-xp/css1/box_properties/border_bottom-expected.png: Added.
platform/chromium-win-xp/css1/box_properties/border_left-expected.png: Added.
platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Added.
platform/chromium-win-xp/css1/box_properties/border_top-expected.png: Added.
platform/chromium-win-xp/css1/box_properties/clear_float-expected.png: Added.
platform/chromium-win-xp/css1/box_properties/margin_left-expected.png: Added.
platform/chromium-win-xp/css1/box_properties/margin_right-expected.png: Added.
platform/chromium-win-xp/css1/box_properties/padding_left-expected.png: Added.
platform/chromium-win-xp/css1/box_properties/padding_right-expected.png: Added.
platform/chromium-win-xp/css1/cascade: Added.
platform/chromium-win-xp/css1/cascade/cascade_order-expected.png: Added.
platform/chromium-win-xp/css1/classification: Added.
platform/chromium-win-xp/css1/classification/list_style_type-expected.png: Added.
platform/chromium-win-xp/css1/pseudo: Added.
platform/chromium-win-xp/css1/pseudo/anchor-expected.png: Added.
platform/chromium-win-xp/css3/selectors3: Added.
platform/chromium-win-xp/css3/selectors3/html: Added.
platform/chromium-win-xp/css3/selectors3/html/css3-modsel-161-expected.png: Added.
platform/chromium-win-xp/css3/selectors3/xhtml: Added.
platform/chromium-win-xp/css3/selectors3/xhtml/css3-modsel-161-expected.png: Added.
platform/chromium-win-xp/css3/selectors3/xml: Added.
platform/chromium-win-xp/css3/selectors3/xml/css3-modsel-161-expected.png: Added.
platform/chromium-win-xp/editing/input: Added.
platform/chromium-win-xp/editing/input/caret-at-the-edge-of-input-expected.png: Added.
platform/chromium-win-xp/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
platform/chromium-win-xp/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
platform/chromium-win-xp/fast/backgrounds/repeat: Removed.
platform/chromium-win-xp/fast/block/float: Added.
platform/chromium-win-xp/fast/block/float/float-avoidance-expected.png: Added.
platform/chromium-win-xp/fast/block/margin-collapse: Added.
platform/chromium-win-xp/fast/block/margin-collapse/103-expected.png: Added.
platform/chromium-win-xp/fast/events: Added.
platform/chromium-win-xp/fast/events/autoscroll-expected.png: Added.
platform/chromium-win-xp/fast/events/context-no-deselect-expected.png: Added.
platform/chromium-win-xp/fast/events/reveal-link-when-focused-expected.png: Added.
platform/chromium-win-xp/fast/forms/date: Added.
platform/chromium-win-xp/fast/forms/date/date-appearance-expected.png: Added.
platform/chromium-win-xp/fast/forms/select: Added.
platform/chromium-win-xp/fast/forms/select/optgroup-rendering-expected.png: Added.
platform/chromium-win-xp/fast/forms/textarea: Added.
platform/chromium-win-xp/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
platform/chromium-win-xp/fast/frames: Added.
platform/chromium-win-xp/fast/frames/take-focus-from-iframe-expected.png: Added.
platform/chromium-win-xp/fast/gradients: Added.
platform/chromium-win-xp/fast/gradients/background-clipped-expected.png: Added.
platform/chromium-win-xp/fast/html: Removed.
platform/chromium-win-xp/fast/html/details-writing-mode-expected.png: Removed.
platform/chromium-win-xp/fast/invalid: Added.
platform/chromium-win-xp/fast/invalid/014-expected.png: Added.
platform/chromium-win-xp/fast/layers: Added.
platform/chromium-win-xp/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
platform/chromium-win-xp/fast/layers/scroll-with-transform-layer-expected.png: Added.
platform/chromium-win-xp/fast/lists: Added.
platform/chromium-win-xp/fast/lists/008-expected.png: Added.
platform/chromium-win-xp/fast/lists/008-vertical-expected.png: Added.
platform/chromium-win-xp/fast/lists/dynamic-marker-crash-expected.png: Added.
platform/chromium-win-xp/fast/overflow: Added.
platform/chromium-win-xp/fast/overflow/overflow-rtl-expected.png: Added.
platform/chromium-win-xp/fast/overflow/overflow-rtl-vertical-expected.png: Added.
platform/chromium-win-xp/fast/selectors: Added.
platform/chromium-win-xp/fast/selectors/166-expected.png: Added.
platform/chromium-win-xp/fast/selectors/unqualified-hover-strict-expected.png: Added.
platform/chromium-win-xp/fast/selectors/unqualified-hover-strict-expected.txt: Added.
platform/chromium-win-xp/fast/speech: Added.
platform/chromium-win-xp/fast/speech/input-appearance-numberandspeech-expected.png: Added.
platform/chromium-win-xp/fast/speech/input-appearance-searchandspeech-expected.png: Added.
platform/chromium-win-xp/fast/speech/input-appearance-speechbutton-expected.png: Added.
platform/chromium-win-xp/fast/speech/speech-bidi-rendering-expected.png: Added.
platform/chromium-win-xp/fast/text/drawBidiText-expected.png:
platform/chromium-win-xp/fast/transforms: Added.
platform/chromium-win-xp/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
platform/chromium-win-xp/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
platform/chromium-win-xp/fast/transforms/transformed-focused-text-input-expected.png: Added.
platform/chromium-win-xp/fonts: Added.
platform/chromium-win-xp/fonts/monospace-expected.png: Added.
platform/chromium-win-xp/http/tests/misc: Added.
platform/chromium-win-xp/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
platform/chromium-win-xp/http/tests/navigation: Added.
platform/chromium-win-xp/http/tests/navigation/javascriptlink-frames-expected.png: Added.
platform/chromium-win-xp/plugins: Added.
platform/chromium-win-xp/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
platform/chromium-win-xp/svg/as-image/image-respects-pageScaleFactor-expected.png: Removed.
platform/chromium-win-xp/svg/dom: Removed.
platform/chromium-win-xp/svg/hixie/mixed: Added.
platform/chromium-win-xp/svg/hixie/mixed/003-expected.png: Added.
platform/chromium-win-xp/svg/in-html: Added.
platform/chromium-win-xp/svg/in-html/circle-expected.png: Added.
platform/chromium-win-xp/svg/transforms: Added.
platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
platform/chromium-win-xp/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png:
platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
platform/chromium-win-xp/tables/mozilla/core: Added.
platform/chromium-win-xp/tables/mozilla/core/margins-expected.png: Added.
platform/chromium-win-xp/tables/mozilla/dom: Added.
platform/chromium-win-xp/tables/mozilla/dom/tableDom-expected.png: Added.
platform/chromium-win-xp/tables/mozilla/other: Added.
platform/chromium-win-xp/tables/mozilla/other/move_row-expected.png: Added.
platform/chromium-win-xp/tables/mozilla_expected_failures: Added.
platform/chromium-win-xp/tables/mozilla_expected_failures/bugs: Added.
platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
platform/chromium-win-xp/tables/mozilla_expected_failures/marvin: Added.
platform/chromium-win-xp/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
platform/chromium-win-xp/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png: Added.
platform/chromium-win-xp/transforms/2d/hindi-rotated-expected.png:
platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
platform/chromium-win/css1/basic/class_as_selector-expected.png:
platform/chromium-win/css1/basic/containment-expected.png:
platform/chromium-win/css1/basic/id_as_selector-expected.png:
platform/chromium-win/css1/box_properties/border_bottom-expected.png:
platform/chromium-win/css1/box_properties/border_left-expected.png:
platform/chromium-win/css1/box_properties/border_right_inline-expected.png:
platform/chromium-win/css1/box_properties/border_top-expected.png:
platform/chromium-win/css1/box_properties/clear_float-expected.png:
platform/chromium-win/css1/box_properties/margin_left-expected.png:
platform/chromium-win/css1/box_properties/margin_right-expected.png:
platform/chromium-win/css1/box_properties/padding_left-expected.png:
platform/chromium-win/css1/box_properties/padding_right-expected.png:
platform/chromium-win/css1/cascade/cascade_order-expected.png:
platform/chromium-win/css1/classification/list_style_type-expected.png:
platform/chromium-win/css1/pseudo/anchor-expected.png:
platform/chromium-win/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
platform/chromium-win/css3/selectors3/html/css3-modsel-161-expected.png:
platform/chromium-win/css3/selectors3/xhtml/css3-modsel-161-expected.png:
platform/chromium-win/css3/selectors3/xml/css3-modsel-161-expected.png:
platform/chromium-win/editing/deleting/delete-after-span-ws-001-expected.png:
platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.png:
platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.png:
platform/chromium-win/editing/deleting/delete-line-end-ws-001-expected.png:
platform/chromium-win/editing/deleting/delete-line-end-ws-002-expected.png:
platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.png:
platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.png:
platform/chromium-win/editing/inserting/4960120-1-expected.png:
platform/chromium-win/editing/inserting/before-after-input-element-expected.png:
platform/chromium-win/editing/pasteboard/4806874-expected.png:
platform/chromium-win/editing/pasteboard/4944770-1-expected.png:
platform/chromium-win/editing/pasteboard/4944770-2-expected.png:
platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.png:
platform/chromium-win/editing/pasteboard/input-field-1-expected.png:
platform/chromium-win/editing/pasteboard/pasting-tabs-expected.png:
platform/chromium-win/editing/selection/3690703-2-expected.png:
platform/chromium-win/editing/selection/3690703-expected.png:
platform/chromium-win/editing/selection/3690719-expected.png:
platform/chromium-win/editing/selection/4397952-expected.png:
platform/chromium-win/editing/selection/4895428-3-expected.png:
platform/chromium-win/editing/selection/4975120-expected.png:
platform/chromium-win/editing/selection/caret-before-select-expected.png:
platform/chromium-win/editing/selection/drag-select-1-expected.png:
platform/chromium-win/editing/selection/iframe-expected.png:
platform/chromium-win/editing/selection/replaced-boundaries-3-expected.png:
platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.png:
platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.png:
platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.png:
platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.png:
platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.png:
platform/chromium-win/editing/selection/select-all-001-expected.png:
platform/chromium-win/editing/selection/select-all-002-expected.png:
platform/chromium-win/editing/selection/select-box-expected.png:
platform/chromium-win/editing/selection/select-element-paragraph-boundary-expected.png:
platform/chromium-win/editing/selection/unrendered-001-expected.png:
platform/chromium-win/editing/selection/unrendered-002-expected.png:
platform/chromium-win/editing/selection/unrendered-003-expected.png:
platform/chromium-win/editing/selection/unrendered-004-expected.png:
platform/chromium-win/editing/selection/unrendered-005-expected.png:
platform/chromium-win/fast/backgrounds/background-inherit-color-bug-expected.png:
platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
platform/chromium-win/fast/block/float/float-avoidance-expected.png:
platform/chromium-win/fast/block/margin-collapse/103-expected.png:
platform/chromium-win/fast/borders/border-radius-valid-border-clipping-expected.png:
platform/chromium-win/fast/borders/mixed-border-styles-radius2-expected.png:
platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-win/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
platform/chromium-win/fast/canvas/canvas-text-alignment-expected.png:
platform/chromium-win/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-win/fast/canvas/image-pattern-rotate-expected.png:
platform/chromium-win/fast/css/input-search-padding-expected.png:
platform/chromium-win/fast/css/line-height-expected.png:
platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.png:
platform/chromium-win/fast/css/text-overflow-input-expected.png:
platform/chromium-win/fast/css/text-transform-select-expected.png:
platform/chromium-win/fast/dom/52776-expected.png:
platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
platform/chromium-win/fast/dom/focus-contenteditable-expected.png:
platform/chromium-win/fast/dom/isindex-001-expected.png:
platform/chromium-win/fast/dom/isindex-002-expected.png:
platform/chromium-win/fast/events/autoscroll-expected.png:
platform/chromium-win/fast/events/context-no-deselect-expected.png:
platform/chromium-win/fast/events/reveal-link-when-focused-expected.png:
platform/chromium-win/fast/forms/001-expected.png:
platform/chromium-win/fast/forms/003-expected.png:
platform/chromium-win/fast/forms/004-expected.png:
platform/chromium-win/fast/forms/HTMLOptionElement_label01-expected.png:
platform/chromium-win/fast/forms/HTMLOptionElement_label02-expected.png:
platform/chromium-win/fast/forms/HTMLOptionElement_label03-expected.png:
platform/chromium-win/fast/forms/HTMLOptionElement_label04-expected.png:
platform/chromium-win/fast/forms/HTMLOptionElement_label05-expected.png:
platform/chromium-win/fast/forms/HTMLOptionElement_label06-expected.png:
platform/chromium-win/fast/forms/HTMLOptionElement_label07-expected.png:
platform/chromium-win/fast/forms/basic-buttons-expected.png:
platform/chromium-win/fast/forms/basic-inputs-expected.png:
platform/chromium-win/fast/forms/basic-selects-expected.png:
platform/chromium-win/fast/forms/button-generated-content-expected.png:
platform/chromium-win/fast/forms/button-inner-block-reuse-expected.png:
platform/chromium-win/fast/forms/control-clip-overflow-expected.png:
platform/chromium-win/fast/forms/control-restrict-line-height-expected.png:
platform/chromium-win/fast/forms/date/date-appearance-expected.png:
platform/chromium-win/fast/forms/disabled-select-change-index-expected.png:
platform/chromium-win/fast/forms/encoding-test-expected.png:
platform/chromium-win/fast/forms/fieldset-align-expected.png:
platform/chromium-win/fast/forms/floating-textfield-relayout-expected.png:
platform/chromium-win/fast/forms/form-element-geometry-expected.png:
platform/chromium-win/fast/forms/input-align-expected.png:
platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.png:
platform/chromium-win/fast/forms/input-appearance-disabled-expected.png:
platform/chromium-win/fast/forms/input-appearance-focus-expected.png:
platform/chromium-win/fast/forms/input-appearance-height-expected.png:
platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.png:
platform/chromium-win/fast/forms/input-appearance-readonly-expected.png:
platform/chromium-win/fast/forms/input-appearance-selection-expected.png:
platform/chromium-win/fast/forms/input-appearance-visibility-expected.png:
platform/chromium-win/fast/forms/input-appearance-width-expected.png:
platform/chromium-win/fast/forms/input-baseline-expected.png:
platform/chromium-win/fast/forms/input-disabled-color-expected.png:
platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.png:
platform/chromium-win/fast/forms/input-field-text-truncated-expected.png:
platform/chromium-win/fast/forms/input-placeholder-paint-order-expected.png:
platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png:
platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png:
platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.png:
platform/chromium-win/fast/forms/input-readonly-dimmed-expected.png:
platform/chromium-win/fast/forms/input-readonly-empty-expected.png:
platform/chromium-win/fast/forms/input-spaces-expected.png:
platform/chromium-win/fast/forms/input-table-expected.png:
platform/chromium-win/fast/forms/input-text-click-inside-expected.png:
platform/chromium-win/fast/forms/input-text-click-outside-expected.png:
platform/chromium-win/fast/forms/input-text-double-click-expected.png:
platform/chromium-win/fast/forms/input-text-option-delete-expected.png:
platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.png:
platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.png:
platform/chromium-win/fast/forms/input-text-word-wrap-expected.png:
platform/chromium-win/fast/forms/input-type-text-min-width-expected.png:
platform/chromium-win/fast/forms/input-value-expected.png:
platform/chromium-win/fast/forms/input-width-expected.png:
platform/chromium-win/fast/forms/listbox-bidi-align-expected.png:
platform/chromium-win/fast/forms/listbox-clip-expected.png:
platform/chromium-win/fast/forms/listbox-scrollbar-incremental-load-expected.png:
platform/chromium-win/fast/forms/listbox-width-change-expected.png:
platform/chromium-win/fast/forms/menulist-deselect-update-expected.png:
platform/chromium-win/fast/forms/menulist-narrow-width-expected.png:
platform/chromium-win/fast/forms/menulist-no-overflow-expected.png:
platform/chromium-win/fast/forms/menulist-restrict-line-height-expected.png:
platform/chromium-win/fast/forms/menulist-separator-painting-expected.png:
platform/chromium-win/fast/forms/menulist-style-color-expected.png:
platform/chromium-win/fast/forms/menulist-width-change-expected.png:
platform/chromium-win/fast/forms/minWidthPercent-expected.png:
platform/chromium-win/fast/forms/option-script-expected.png:
platform/chromium-win/fast/forms/option-strip-whitespace-expected.png:
platform/chromium-win/fast/forms/option-text-clip-expected.png:
platform/chromium-win/fast/forms/placeholder-position-expected.png:
platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.png:
platform/chromium-win/fast/forms/plaintext-mode-2-expected.png:
platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.png:
platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.png:
platform/chromium-win/fast/forms/search-rtl-expected.png:
platform/chromium-win/fast/forms/searchfield-heights-expected.png:
platform/chromium-win/fast/forms/select-align-expected.png:
platform/chromium-win/fast/forms/select-background-none-expected.png:
platform/chromium-win/fast/forms/select-baseline-expected.png:
platform/chromium-win/fast/forms/select-block-background-expected.png:
platform/chromium-win/fast/forms/select-change-listbox-size-expected.png:
platform/chromium-win/fast/forms/select-change-listbox-to-popup-expected.png:
platform/chromium-win/fast/forms/select-change-popup-to-listbox-expected.png:
platform/chromium-win/fast/forms/select-dirty-parent-pref-widths-expected.png:
platform/chromium-win/fast/forms/select-disabled-appearance-expected.png:
platform/chromium-win/fast/forms/select-initial-position-expected.png:
platform/chromium-win/fast/forms/select-list-box-with-height-expected.png:
platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png:
platform/chromium-win/fast/forms/select-overflow-scroll-expected.png:
platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png:
platform/chromium-win/fast/forms/select-selected-expected.png:
platform/chromium-win/fast/forms/select-size-expected.png:
platform/chromium-win/fast/forms/select-style-expected.png:
platform/chromium-win/fast/forms/select-visual-hebrew-expected.png:
platform/chromium-win/fast/forms/select-writing-direction-natural-expected.png:
platform/chromium-win/fast/forms/select/optgroup-rendering-expected.png:
platform/chromium-win/fast/forms/selectlist-minsize-expected.png:
platform/chromium-win/fast/forms/stuff-on-my-optgroup-expected.png:
platform/chromium-win/fast/forms/tabbing-input-iframe-expected.png:
platform/chromium-win/fast/forms/text-style-color-expected.png:
platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png:
platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png:
platform/chromium-win/fast/forms/textarea-scrollbar-expected.png:
platform/chromium-win/fast/forms/textarea-scrolled-type-expected.png:
platform/chromium-win/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:
platform/chromium-win/fast/forms/textfield-focus-ring-expected.png:
platform/chromium-win/fast/forms/textfield-overflow-expected.png:
platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.png:
platform/chromium-win/fast/frames/take-focus-from-iframe-expected.png:
platform/chromium-win/fast/gradients/background-clipped-expected.png:
platform/chromium-win/fast/html/details-no-summary4-expected.png:
platform/chromium-win/fast/html/details-open-javascript-expected.png:
platform/chromium-win/fast/html/details-open2-expected.png:
platform/chromium-win/fast/html/details-open4-expected.png:
platform/chromium-win/fast/html/details-position-expected.png:
platform/chromium-win/fast/html/details-replace-summary-child-expected.png:
platform/chromium-win/fast/html/details-replace-text-expected.png:
platform/chromium-win/fast/html/details-writing-mode-expected.png:
platform/chromium-win/fast/html/keygen-expected.png:
platform/chromium-win/fast/invalid/014-expected.png:
platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png:
platform/chromium-win/fast/layers/scroll-with-transform-layer-expected.png:
platform/chromium-win/fast/lists/008-expected.png:
platform/chromium-win/fast/lists/008-vertical-expected.png:
platform/chromium-win/fast/lists/dynamic-marker-crash-expected.png:
platform/chromium-win/fast/overflow/overflow-rtl-expected.png:
platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png:
platform/chromium-win/fast/overflow/overflow-update-transform-expected.png:
platform/chromium-win/fast/overflow/overflow-with-local-background-attachment-expected.png:
platform/chromium-win/fast/parser/document-write-option-expected.png:
platform/chromium-win/fast/repaint/control-clip-expected.png:
platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
platform/chromium-win/fast/repaint/select-option-background-color-expected.png:
platform/chromium-win/fast/repaint/subtree-root-skipped-expected.png:
platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
platform/chromium-win/fast/replaced/replaced-breaking-expected.png:
platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.png:
platform/chromium-win/fast/replaced/three-selects-break-expected.png:
platform/chromium-win/fast/replaced/width100percent-searchfield-expected.png:
platform/chromium-win/fast/replaced/width100percent-textfield-expected.png:
platform/chromium-win/fast/selectors/166-expected.png:
platform/chromium-win/fast/selectors/unqualified-hover-strict-expected.png:
platform/chromium-win/fast/selectors/unqualified-hover-strict-expected.txt:
platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png:
platform/chromium-win/fast/table/003-expected.png:
platform/chromium-win/fast/table/colspanMinWidth-expected.png:
platform/chromium-win/fast/table/spanOverlapRepaint-expected.png:
platform/chromium-win/fast/table/text-field-baseline-expected.png:
platform/chromium-win/fast/text/drawBidiText-expected.png:
platform/chromium-win/fast/text/international/bidi-listbox-atsui-expected.png:
platform/chromium-win/fast/text/international/bidi-listbox-expected.png:
platform/chromium-win/fast/text/international/bidi-menulist-expected.png:
platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
platform/chromium-win/fast/text/textIteratorNilRenderer-expected.png:
platform/chromium-win/fast/text/updateNewFont-expected.png:
platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.png:
platform/chromium-win/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
platform/chromium-win/fast/writing-mode/box-shadow-vertical-lr-expected.png:
platform/chromium-win/fast/writing-mode/box-shadow-vertical-rl-expected.png:
platform/chromium-win/fonts/monospace-expected.png:
platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png:
platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.png:
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.png:
platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.png:
platform/chromium-win/svg/css/composite-shadow-example-expected.png:
platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png:
platform/chromium-win/svg/css/stars-with-shadow-expected.png:
platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
platform/chromium-win/svg/custom/object-sizing-no-width-height-expected.png:
platform/chromium-win/svg/custom/pattern-rotate-expected.png:
platform/chromium-win/svg/dom/SVGTransformList-basics-expected.png:
platform/chromium-win/svg/dom/css-transforms-expected.png:
platform/chromium-win/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
platform/chromium-win/svg/hixie/mixed/003-expected.png:
platform/chromium-win/svg/in-html/circle-expected.png:
platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
platform/chromium-win/svg/wicd/rightsizing-grid-expected.png:
platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png:
platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
platform/chromium-win/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
platform/chromium-win/tables/mozilla/bugs/45621-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug12384-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug18359-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug24200-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug28928-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug29326-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug30692-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug33855-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug4382-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug44505-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug51037-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug55545-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug59354-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug7342-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug96334-expected.png:
platform/chromium-win/tables/mozilla/core/margins-expected.png:
platform/chromium-win/tables/mozilla/dom/tableDom-expected.png:
platform/chromium-win/tables/mozilla/marvin/backgr_index-expected.png:
platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
platform/chromium-win/tables/mozilla/other/move_row-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
platform/chromium-win/transforms/2d/hindi-rotated-expected.png:
platform/chromium-win/transforms/2d/hindi-rotated-expected.txt:
platform/chromium-win/transforms/2d/zoom-menulist-expected.png:
platform/chromium/TestExpectations:
platform/efl/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
platform/gtk/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.

6:48 PM Changeset in webkit [124141] by commit-queue@webkit.org

11 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r124123.
http://trac.webkit.org/changeset/124123
https://bugs.webkit.org/show_bug.cgi?id=92700

ASSERT crashes terminate webkit Layout tests (Requested by
msaboff on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

heap/Heap.cpp:
heap/Heap.h:

(Heap):

heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::doSweep):
(JSC::IncrementalSweeper::startSweeping):
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC):

heap/IncrementalSweeper.h:

(IncrementalSweeper):

heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::addBlock):

heap/MarkedAllocator.h:

(JSC::MarkedAllocator::zapFreeList):

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweepHelper):

heap/MarkedSpace.cpp:
heap/MarkedSpace.h:

(JSC::MarkedSpace::sweep):
(JSC):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::~JSGlobalData):

6:45 PM Changeset in webkit [124140] by commit-queue@webkit.org

3 edits in trunk/Tools

webkit-patch: system keyring is not used to read my password
https://bugs.webkit.org/show_bug.cgi?id=92532

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-30
Reviewed by Dirk Pranke.

In case no username can be fetched from environment, git or keychain,
prompt for username, and try to get password from keyring associated
with that username.

Scripts/webkitpy/common/net/credentials.py:

(Credentials.read_credentials):

Scripts/webkitpy/common/net/credentials_unittest.py:

(test_keyring_without_git_repo_nor_keychain):
(test_keyring_without_git_repo_nor_keychain.MockKeyring):
(test_keyring_without_git_repo_nor_keychain.MockKeyring.get_password):
(test_keyring_without_git_repo_nor_keychain.FakeCredentials):
(test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_keychain):
(test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_environment):
(test_keyring_without_git_repo_nor_keychain.FakeUser):
(test_keyring_without_git_repo_nor_keychain.FakeUser.prompt):
(test_keyring_without_git_repo_nor_keychain.FakeUser.prompt_password):

6:40 PM Changeset in webkit [124139] by dpranke@chromium.org

3 edits in trunk/Tools

nrwt: move the code that identifies the chunk of tests to run into finder
https://bugs.webkit.org/show_bug.cgi?id=92694

Reviewed by Ryosuke Niwa.

Another patch to make manager.py smaller and clearer; this patch moves
the handling of breaking the list of tests into chunks (--run-part,
--run-chunk) from manager.py to finder.py.

There are no functional changes and this is covered by existing tests.

Scripts/webkitpy/layout_tests/controllers/finder.py:

(Finder.init):
(Finder._read_test_files):
(Finder):
(Finder.split_into_chunks_if_necessary):

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager._collect_tests):
(Manager._parse_expectations):
(Manager.prepare_lists_and_print_output):

6:34 PM Changeset in webkit [124138] by Lucas Forschler

1 edit
2 copies in branches/safari-536.26-branch/LayoutTests

Merged r122300. <rdar://problem/11932360>

6:26 PM Changeset in webkit [124137] by Lucas Forschler

3 edits in branches/safari-536.26-branch

Merged r122271. <rdar://problem/11932360>

6:21 PM Changeset in webkit [124136] by Lucas Forschler

3 edits in branches/safari-536.26-branch/Source/WebKit2

Merged r122520. <rdar://problem/11932354>

6:14 PM Changeset in webkit [124135] by eric@webkit.org

15 edits in trunk/Source/WebCore

Grid Demo spends 1.5% of total time allocating Path objects in RenderBoxModelObject::paintBorderSides
https://bugs.webkit.org/show_bug.cgi?id=92252

Reviewed by Simon Fraser.

This change introduces the concept of a "null Path" very similar to a null WTF::String.
Just like String functions as a RefPtr around a StringImpl, Path (for most ports)
functions as an OwnPtr around a PlatformPathPtr.

In various places in the code, we declare a local Path variable, but don't necessarily
use that Path variable in all code paths, or might pass that Path variable along to GraphicsContext
functions, without ever actually adding points to that Path.
On most platforms, this Path default constructor was causing a malloc!
In some of these case, the code-path in question (like paintBorderSides) can be quite hot.
Introducing this null-Path and delaying instantiation of the PlatformPath object
until it's actually needed, saves a malloc for these hot paths.

To test this, I loaded a few popular pages, and added printfs to both the Path constructor
and destructor, logging during construction and destruction when the path was still null at destruction time.

This simple testing showed this to be a small win (avoiding mallocs) on many sites and a huge win for Google Spreadsheets:
apple.com: 147 Paths created, 9 (6%) destroyed null.
google.com: 58 Paths created, 26 (44%) destroyed null (google seems creating 5 paths every second after load? 1 of which is destroyed empty.)
amazon.com: 130 Paths created, 130 (100%) destroyed null.
Loading an empty spreadsheet from drive.google.com: 5237 created, 4861 destroyed null (92%!) :)

platform/graphics/Path.h:

(Path):
(WebCore::Path::isNull):
(WebCore::Path::ensurePlatformPath):

platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::appendWebCorePathToCairoContext):

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clip):

platform/graphics/cairo/PathCairo.cpp:

(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::ensurePlatformPath):
(WebCore):
(WebCore::Path::operator=):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::currentPoint):
(WebCore::Path::translate):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addRect):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArc):
(WebCore::Path::addArcTo):
(WebCore::Path::addEllipse):
(WebCore::Path::closeSubpath):
(WebCore::Path::boundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::apply):
(WebCore::Path::transform):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clipOut):

platform/graphics/cg/PathCG.cpp:

(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore):
(WebCore::Path::ensurePlatformPath):
(WebCore::Path::operator=):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::fastBoundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::platformAddPathForRoundedRect):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::currentPoint):
(WebCore::Path::apply):

platform/graphics/gpu/LoopBlinnPathProcessor.cpp:

(WebCore):
(WebCore::LoopBlinnPathProcessor::buildContours):

platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawFocusRing):

platform/graphics/openvg/PainterOpenVG.cpp:

(WebCore::PainterOpenVG::drawPath):

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):

platform/graphics/skia/PathSkia.cpp:

(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore):
(WebCore::Path::ensurePlatformPath):
(WebCore::Path::operator=):
(WebCore::Path::isEmpty):
(WebCore::Path::hasCurrentPoint):
(WebCore::Path::currentPoint):
(WebCore::Path::contains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::clear):
(WebCore::Path::apply):
(WebCore::Path::transform):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::strokeContains):

platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):

platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):

platform/graphics/wx/PathWx.cpp:

(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::boundingRect):
(WebCore::Path::operator=):
(WebCore::Path::ensurePlatformPath):
(WebCore):
(WebCore::Path::clear):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::transform):
(WebCore::Path::currentPoint):

6:13 PM Changeset in webkit [124134] by Patrick Gansterer

2 edits in trunk/Source/WTF

Add WTF_EXPORT_PRIVATE to deleteOwnedPtr()
https://bugs.webkit.org/show_bug.cgi?id=92668

Reviewed by Hajime Morita.

When using export macros all non-inlined deleteOwnedPtr()
functions need to be declared with WTF_EXPORT_PRIVATE.

wtf/OwnPtrCommon.h:

(WTF):

6:07 PM Changeset in webkit [124133] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r122228. <rdar://problem/11932475>

6:02 PM Changeset in webkit [124132] by Lucas Forschler

6 edits in branches/safari-536.26-branch

Merged r122152. <rdar://problem/11932481>

6:02 PM Changeset in webkit [124131] by dpranke@chromium.org

3 edits
1 add in trunk/Tools

nrwt: split test-finding code out from manager.py
https://bugs.webkit.org/show_bug.cgi?id=92693

Reviewed by Ryosuke Niwa.

In the interest of making manager.py smaller, this patch moves
the code that actually takes the command line arguments and
--test-file lists of tests to run and expands them into an
actual list of tests out into a separate module.

Scripts/webkitpy/layout_tests/controllers/finder.py: Added.

(LayoutTestFinder):
(LayoutTestFinder.init):
(LayoutTestFinder.find_tests):
(LayoutTestFinder._strip_test_dir_prefixes):
(LayoutTestFinder._strip_test_dir_prefix):
(LayoutTestFinder._read_test_names_from_file):

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._collect_tests):
(Manager._handle_finished_test):

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(strip_comments):

5:58 PM Changeset in webkit [124130] by Lucas Forschler

7 edits
2 copies in branches/safari-536.26-branch

Merged r122082. <rdar://problem/11942018>

5:53 PM Changeset in webkit [124129] by Lucas Forschler

4 edits
2 copies in branches/safari-536.26-branch

Merged r121912. <rdar://problem/11932362>

5:49 PM Changeset in webkit [124128] by abarth@webkit.org

2 edits in trunk/Tools

commit-queue is corrupting ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=92681

Reviewed by Tony Chang.

Some commits made with the commit-queue are ending up with duplicate
ChangeLog entries. I've hot-patched the servers to not use a special
merge driver for ChangeLogs, which should fix this issue. This patch
removes the merge driver from our cold-boot.sh script so that we won't
use it on new commit-queue instances.

EWSTools/cold-boot.sh:

5:48 PM Changeset in webkit [124127] by Lucas Forschler

4 edits in branches/safari-536.26-branch/Source

Merged r121646. <rdar://problem/11932486> & <rdar://problem/11932354>

5:46 PM Changeset in webkit [124126] by msaboff@apple.com

2 edits in trunk/LayoutTests

inspector/profiler/heap-snapshot-containment-show-all.html test crashing during WebView closing
<rdar://problem/11991881>

platform/mac-lion/Skipped:

5:42 PM Changeset in webkit [124125] by Lucas Forschler

3 edits
3 copies in branches/safari-536.26-branch

Merged r121645. <rdar://problem/11932384>

5:35 PM Changeset in webkit [124124] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r121643. <rdar://problem/11942168>

5:33 PM Changeset in webkit [124123] by mhahnenberg@apple.com

11 edits in trunk/Source/JavaScriptCore

Structures should be swept after all other objects
https://bugs.webkit.org/show_bug.cgi?id=92679

Reviewed by Filip Pizlo.

In order to get rid of ClassInfo from our objects, we need to be able to safely get the
ClassInfo during the destruction of objects. We'd like to get the ClassInfo out of the
Structure, but currently it is not safe to do so because the order of destruction of objects
is not guaranteed to sweep objects before their corresponding Structure. We can fix this by
sweeping Structures after everything else.

heap/Heap.cpp:

(JSC::Heap::isSafeToSweepStructures): Add a function that checks if it is safe to sweep Structures.
If the Heap's IncrementalSweeper member is null, that means we're shutting down this VM and it is
safe to sweep structures since we'll always do Structures last anyways due to the ordering of
MarkedSpace::forEachBlock.
(JSC):
(JSC::Heap::didStartVMShutdown): Add this intermediate function to the Heap that ~JSGlobalData now
calls rather than calling the two HeapTimer objects individually. This allows the Heap to null out
these pointers after it has invalidated them to prevent accidental use-after-free in the sweep()
calls during lastChanceToFinalize().

heap/Heap.h:

(Heap):

heap/HeapTimer.h:

(HeapTimer):

heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::structuresCanBeSwept): Determines if it is currently safe to sweep Structures.
This decision is based on whether we have gotten to the end of the vector of blocks that need sweeping
the first time.
(JSC):
(JSC::IncrementalSweeper::doSweep): We add a second pass over the vector to sweep Structures after we
make our first pass. We now null out the slots as we sweep them so that we can quickly find the
Structures during the second pass.
(JSC::IncrementalSweeper::startSweeping): Initialize our new Structure sweeping index.
(JSC::IncrementalSweeper::willFinishSweeping): Callback that is called by MarkedSpace::sweep to notify
the IncrementalSweeper that we are going to sweep all of the remaining blocks in the Heap so it can
assume that everything is taken care of in the correct order. Since MarkedSpace::forEachBlock
iterates over the Structure blocks after all other blocks, the ordering property for sweeping Structures holds.
(JSC::IncrementalSweeper::IncrementalSweeper): Initialize Structure sweeping index.

heap/IncrementalSweeper.h: Add declarations for new stuff.

(IncrementalSweeper):

heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper): We now check if the current block only contains structures and
if so and it isn't safe to sweep Structures according to the Heap, we just return early instead of doing
the normal lazy sweep. If this proves to be too much of a waste in the future we can add an extra clause that
will sweep some number of other blocks in place of the current block to mitigate the cost of the floating
Structure garbage.
(JSC::MarkedAllocator::addBlock):

heap/MarkedAllocator.h:

(JSC::MarkedAllocator::zapFreeList): When we zap the free list in the MarkedAllocator, the current block is no
longer valid to allocate from, so we set the current block to null.

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweepHelper): Added a couple assertions to make sure that we weren't trying to sweep Structures
at an unsafe time.

heap/MarkedSpace.cpp:

(JSC::MarkedSpace::sweep): Notify the IncrementalSweeper that the MarkedSpace will finish all currently remaining sweeping.
(JSC):

heap/MarkedSpace.h:

(JSC):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::~JSGlobalData): Call the new Heap::didStartVMShutdown.

5:28 PM Changeset in webkit [124122] by Lucas Forschler

4 edits in branches/safari-536.26-branch/Source/WebKit2

Merged r121482. <rdar://problem/11932427>

5:24 PM Changeset in webkit [124121] by weinig@apple.com

5 edits in trunk

Add ability to load from a string to the ObjC WK API
https://bugs.webkit.org/show_bug.cgi?id=92590

Reviewed by Dan Bernstein.

Source/WebKit2:

This adds an often used method to the new Objective-C API and will
be helpful for writing API tests.

UIProcess/API/mac/WKBrowsingContextController.h:
UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadHTMLString:baseURL:]):
Implement via calling down to WKPageLoadHTMLString.

Tools:

Add tests for [WKBrowsingContextController loadHTMLString:baseURL:]. We will be able
to greatly improve these tests (to test more than just not crashing) when methods to
access page content are added (soon!).

Adds:

Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString
Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilBaseURL
Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL

TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:

Adds tests and refactors delegates to not use global state.

5:20 PM Changeset in webkit [124120] by abarth@webkit.org

1 delete in branches/1018

This branch was created in error. kareng confirms it is safe to remove.

5:14 PM Changeset in webkit [124119] by Lucas Forschler

3 edits
3 copies in branches/safari-536.26-branch

Merged r121391. <rdar://problem/11932432>

5:11 PM Changeset in webkit [124118] by commit-queue@webkit.org

2 edits in trunk/Tools

[CMake] TestWebKitAPI bundle should link with WTF
https://bugs.webkit.org/show_bug.cgi?id=92616

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-30
Reviewed by Antonio Gomes.

Fixes build when shared core is disabled.

TestWebKitAPI/CMakeLists.txt:

5:11 PM Changeset in webkit [124117] by Lucas Forschler

7 edits
2 copies in branches/safari-536.26-branch

Merge 121299. <rdar://problem/11932473>

5:01 PM Changeset in webkit [124116] by dpranke@chromium.org

9 edits in trunk/Tools

nrwt: clean up handling of 'expected' stats
https://bugs.webkit.org/show_bug.cgi?id=92527

Reviewed by Tony Chang.

This patch alters the way we compute and log the "expected"
results and how we treat skipped tests; we will now log the
number of skipped tests separately from the categories, e.g.:

Found 31607 tests; running 24464.
Expect: 23496 passes (23496 now, 0 wontfix)
Expect: 548 failures ( 543 now, 5 wontfix)
Expect: 420 flaky ( 245 now, 175 wontfix)

(so that the "expect" totals add up to the "running" totals);
in addition, the totals in the one-line-progress reflect the
number of tests we will actually run. If --iterations or
--repeat-each are specified, the number of tests we run are
multiplied as appropriate, but the "expect" numbers are
unchanged, since we don't count multiple invocations of the same
test multiple times. In addition, if we are using --run-part or
--run-chunk, the tests we don't run are treated as skipped
for consistency. We will also log the values for --iterations
and --repeat each as part of the found/running line.

Previously the code had parsed and re-parsed the
TestExpectations files several times in an attempt to come up
with some sane statistics, but this was expensive and lead to
confusing layer; treating files as skipped in the way described
above is more consistent and cleaner.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._split_into_chunks_if_necessary):
(Manager.prepare_lists_and_print_output):
(Manager.run):

Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_interrupt_if_at_failure_limits):
(ManagerTest.test_update_summary_with_result):
(ManagerTest.test_look_for_new_crash_logs):
(ResultSummaryTest.get_result_summary):

Scripts/webkitpy/layout_tests/models/result_summary.py:

(ResultSummary.init):

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser.expectation_for_skipped_test):
(TestExpectations.init):
(TestExpectations.add_skipped_tests):

Here we make add_skipped_tests() public, so that we can update
the expectations for tests that we are skipping due to
--run-part or --run-chunk; we use the wontfix flag so that
the tests that are intentionally skipped aren't considered
"fixable".

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(SkippedTests.check):

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_found):
(Printer):
(Printer.print_expected):
(Printer._print_result_summary):
(Printer._print_result_summary_entry):

Here we split out printing the number of tests found and run
from the expected results, to be clearer and so that we don't
have to reparse the expectations to update the stats.

Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.get_result_summary):

4:53 PM Changeset in webkit [124115] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

atomicDecrement() never reach 0 on Android so no deref() will be called
https://bugs.webkit.org/show_bug.cgi?id=92635

Patch by Wei James <james.wei@intel.com> on 2012-07-30
Reviewed by Adam Barth.

With Android NDK 7b and later, atomic_dec() is implemented by
sync_fetch_and_sub(), which will result in that atomicDecrement()
returns the old value instead of new one.

wtf/Atomics.h:

(WTF):
(WTF::atomicIncrement):
(WTF::atomicDecrement):

4:34 PM Changeset in webkit [124114] by rafael.lobo@openbossa.org

2 edits in trunk/Source/WebKit2

[WK2] Kill the concept of secondary shared process
https://bugs.webkit.org/show_bug.cgi?id=92676

Reviewed by Alexey Proskuryakov.

Build fix after r124092.

UIProcess/qt/QtWebContext.cpp: Build fix for Qt. In exchange of the

method removed, I've used WebContext::create(String()).

4:19 PM Changeset in webkit [124113] by Lucas Forschler

2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r120954. <rdar://problem/11932588>

4:16 PM Changeset in webkit [124112] by Lucas Forschler

3 edits
1 copy in branches/safari-536.26-branch

Merged r120662. <rdar://problem/11942166>

4:13 PM Changeset in webkit [124111] by commit-queue@webkit.org

4 edits
1 add in trunk

Avoid Assertion Failure in HarfBuzzRun::characterIndexForXPosition
https://bugs.webkit.org/show_bug.cgi?id=92376

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-30
Reviewed by Tony Chang.

Added manual test to reliably reproduce assertion failure which is solved by this patch.

ManualTests/harfbuzz-mouse-selection-crash.html: Added.

Source/WebCore:

Previously, the if condition in offsetForPosition gating the call to
characterIndexForXPosition was comparing a different value than what was actually used
as the argument to calling it. In some cases, this can lead to a minuscule difference
when comparing the two floats - enough to trigger the assertion. To resolve this,
the accuracy of the index calculation is improved by changing the types from int
to floats and rephrasing the if condition to be exactly the same as what is checked
for in the assertion.

Manual test ManualTests/harfbuzz-mouse-selection-crash.html added
which reliably reproduces the assertion failure before this change.

platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition): Types changed to float.
(WebCore::HarfBuzzShaper::offsetForPosition): Types changed to float, if condition rephrased.

platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:

(HarfBuzzRun):

4:12 PM Changeset in webkit [124110] by Lucas Forschler

3 edits
4 copies in branches/safari-536.26-branch

Merged r119409. <rdar://problem/11942162>

4:09 PM Changeset in webkit [124109] by Lucas Forschler

4 edits
2 copies in branches/safari-536.26-branch

Merged r119227. <rdar://problem/11942165>

4:06 PM Changeset in webkit [124108] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r119184. <rdar://problem/11942161>

3:45 PM Changeset in webkit [124107] by Lucas Forschler

2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r118542. <rdar://problem/11942034>

3:42 PM Changeset in webkit [124106] by Lucas Forschler

6 edits
2 adds in branches/safari-536.26-branch

Merged r118478. <rdar://problem/11942156>

3:37 PM Changeset in webkit [124105] by jamesr@google.com

8 edits in trunk/Source

[chromium] Remove WebTransformationMatrix::mapPoint overrides
https://bugs.webkit.org/show_bug.cgi?id=90329

Reviewed by Adrienne Walker.

Source/Platform:

Remove clipping-unaware mapPoint functions from the WebTransformationMatrix interface.

chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

Source/WebCore:

Add more functionality for mapping points to CCMathUtil and use it in CCLayerSorter / drawTileQuad. These
mappings should never clip.

platform/chromium/support/WebTransformationMatrix.cpp:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTileQuad):

platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::LayerShape::LayerShape):

platform/graphics/chromium/cc/CCMathUtil.cpp:

(WebCore::mapHomogeneousPoint):
(WebCore::CCMathUtil::mapPoint):
(WebCore):

platform/graphics/chromium/cc/CCMathUtil.h:

(WebCore::HomogeneousCoordinate::cartesianPoint3d):
(HomogeneousCoordinate):
(CCMathUtil):

3:33 PM Changeset in webkit [124104] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r118471. <rdar://problem/11942141>

3:29 PM Changeset in webkit [124103] by Lucas Forschler

5 edits
2 copies in branches/safari-536.26-branch

Merged r118420. <rdar://problem/11961148>

3:27 PM Changeset in webkit [124102] by andersca@apple.com

2 edits in trunk/Source/WebCore

Crash in logging code if MIME type is null
https://bugs.webkit.org/show_bug.cgi?id=92683
<rdar://problem/11985295>

Reviewed by Dan Bernstein.

If the MIME type is null, try to figure it out from the URL extension. If this fails, return early instead of crashing
trying to insert the null string into a hash set.

loader/SubframeLoader.cpp:

(WebCore::logPluginRequest):

3:26 PM Changeset in webkit [124101] by Lucas Forschler

3 edits
4 copies in branches/safari-536.26-branch

Merged r118316. <rdar://problem/11942151>

3:21 PM Changeset in webkit [124100] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r118248. <rdar://problem/11942129>

3:18 PM Changeset in webkit [124099] by alexis.menard@openbossa.org

5 edits in trunk/Source/WebCore

Build fix with newer bison 2.6.
https://bugs.webkit.org/show_bug.cgi?id=92264

Reviewed by Adam Barth.

As stated in http://www.gnu.org/software/bison/manual/html_node/Table-of-Symbols.html
YYLEX_PARAM and YYPARSE_PARAM are depecreated since version 1.875. So far all Mac OS
version I had access to as well as recent Linux runs at least version 2.3 so it's safe
to use the replacement of these deprecated macros in favor of %lex-param and %parse-param.
As announced http://lists.gnu.org/archive/html/info-gnu/2012-07/msg00011.html with the release
of version 2.6 YYLEX_PARAM and YYPARSE_PARAM are not supported anymore.

No new tests : build fix and the patch should not trigger any regressions

css/CSSGrammar.y:
css/CSSParser.cpp:
xml/XPathGrammar.y: Refactored a bit to not use an intermediate PARSER define.
xml/XPathParser.cpp: bison 2.6 declare xpathyyparse in the .h file now, i.e. XPathGrammar.h

therefore including this file within the namespace {} declarations leads to xpathyyparse being
defined part of WebCore::XPath namespaces but the actual implementation of xpathyyparse is in XPathGrammar.cpp
(generated) and not implemented within the WebCore::XPath so it lead to linking issues. Last, XPathGrammar.h needs
to be included after the other includes as it uses some XPath types. It breaks the style but CSSParser.cpp is doing the same.

3:13 PM Changeset in webkit [124098] by commit-queue@webkit.org

20 edits
4 adds in trunk

Propagate gesture events to plugins.
https://bugs.webkit.org/show_bug.cgi?id=92281

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-07-30
Reviewed by Adam Barth.

Source/WebCore:

Propagate gesture events to plugins. This change does not expose the gesture events
to JavaScript, since there is no spec for that at the moment. Exposing gesture events
to JavaScript will be done separately, once there is a spec for it.

Test: platform/chromium/plugins/gesture-events.html

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
dom/EventNames.h:

(WebCore):
(WebCore::EventNames::isGestureEventType):
(EventNames):

dom/GestureEvent.cpp: Added.

(WebCore):
(WebCore::GestureEvent::create):
(WebCore::GestureEvent::initGestureEvent):
(WebCore::GestureEvent::interfaceName):
(WebCore::GestureEvent::GestureEvent):
(WebCore::GestureEventDispatchMediator::GestureEventDispatchMediator):
(WebCore::GestureEventDispatchMediator::event):
(WebCore::GestureEventDispatchMediator::dispatchEvent):

dom/GestureEvent.h: Added.

(WebCore):
(GestureEvent):
(WebCore::GestureEvent::~GestureEvent):
(WebCore::GestureEvent::deltaX):
(WebCore::GestureEvent::deltaY):
(WebCore::GestureEvent::GestureEvent):
(GestureEventDispatchMediator):
(WebCore::GestureEventDispatchMediator::create):

dom/Node.cpp:

(WebCore):
(WebCore::Node::dispatchGestureEvent):

dom/Node.h:

(WebCore):
(Node):

page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):

page/EventHandler.h:

Source/WebKit/chromium:

Propagate gesture events to plugins.

src/WebInputEventConversion.cpp:

(WebKit):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

src/WebInputEventConversion.h:

(WebCore):
(WebKit):
(WebGestureEventBuilder):

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleEvent):

src/WebPluginContainerImpl.h:

(WebCore):
(WebPluginContainerImpl):

Tools:

Update TestWebPlugin to receive events, and output logs for the events.

DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::handleInputEvent):

DumpRenderTree/chromium/TestWebPlugin.h:

(TestWebPlugin::acceptsInputEvents):
(TestWebPlugin):

LayoutTests:

Added a layout test to show that the plugins receive the gesture events correctly.

platform/chromium/plugins/gesture-events-expected.txt: Added.
platform/chromium/plugins/gesture-events.html: Added.

3:04 PM Changeset in webkit [124097] by commit-queue@webkit.org

15 edits in trunk/Source

Plumb vsync-enabled flag up to compositor thread and support disable-vsync
https://bugs.webkit.org/show_bug.cgi?id=92323

Patch by John Bates <jbates@google.com> on 2012-07-30
Reviewed by James Robinson.

Source/Platform:

chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::CCFrameRateController):
(WebCore::CCFrameRateController::disableTimeSourceThrottling):
(WebCore):
(WebCore::CCFrameRateController::setActive):
(WebCore::CCFrameRateController::postManualTick):
(WebCore::CCFrameRateController::onTimerFired):
(WebCore::CCFrameRateController::didBeginFrame):
(WebCore::CCFrameRateController::didFinishFrame):

platform/graphics/chromium/cc/CCFrameRateController.h:

(WebCore):
(CCFrameRateController):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::initializeImplOnImplThread):

platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

public/WebSettings.h:
tests/CCFrameRateControllerTest.cpp:
src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):

src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setRenderVSyncEnabled):
(WebKit):

src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::renderVSyncEnabled):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

3:02 PM Changeset in webkit [124096] by Lucas Forschler

4 edits
2 copies in branches/safari-536.26-branch

Merged r118213. <rdar://problem/11942131>

2:53 PM Changeset in webkit [124095] by Patrick Gansterer

2 edits in trunk/Source/WTF

Add function to calculate the day in year from a date
https://bugs.webkit.org/show_bug.cgi?id=92671

Reviewed by Ryosuke Niwa.

Replace monthToDayInYear() with dayInYear() which takes a whole
date for calculation and will be used for bug 92286 later.

wtf/DateMath.cpp:

(WTF::dayInYear):
(WTF::dateToDaysFrom1970):

2:35 PM Changeset in webkit [124094] by rakuco@webkit.org

3 edits in trunk/Tools

[jhbuild] gnutls 2.12.14 does not build with glibc 2.16.0
https://bugs.webkit.org/show_bug.cgi?id=90643

Reviewed by Gustavo Noronha Silva.

The 2.x series of gnutls has a version of Gnulib that is
incompatible with glibc 2.16.0, which now does not define gets()
by default.

After talking to kov, mrobinson and philn, it looks like it makes
sense to simply remove gnutls from jhbuild.modules and rely on the
version installed on the system being recent enough.

This means at least version 2.12.8 for PKCS11 support, or at the
very least 2.11.0 (these are the minimum versions enforced by
glib-networking's configure.ac).

efl/jhbuild.modules: Do not build gnutls anymore, make

glib-networking depend on glib instead, and move the libgcrypt
dependency to eet, which is what currently needs it.

gtk/jhbuild.modules: Do not build gnutls anymore.

2:33 PM Changeset in webkit [124093] by jamesr@google.com

6 edits in trunk/Source/WebCore

[chromium] Add miscellaneous missing includes and OVERRIDE declarations in compositor code
https://bugs.webkit.org/show_bug.cgi?id=92680

Reviewed by Adrienne Walker.

platform/graphics/chromium/TextureCopier.h:

(AcceleratedTextureCopier):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:
platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
platform/graphics/chromium/cc/CCResourceProvider.h:

(WebCore):

2:31 PM Changeset in webkit [124092] by ap@apple.com

7 edits in trunk/Source/WebKit2

[WK2] Kill the concept of secondary shared process
https://bugs.webkit.org/show_bug.cgi?id=92676

Reviewed by Sam Weinig.

UIProcess/API/C/WKContext.cpp:
UIProcess/API/C/WKContext.h:
UIProcess/WebContext.cpp:
UIProcess/WebContext.h: Deleted shared process related code. We don't need to build the singleton into the cross-platform C API, platform-specific API wrappers are perfectly capable of doing that.

UIProcess/API/efl/ewk_context.cpp: (createDefaultEwkContext):
UIProcess/API/gtk/WebKitWebContext.cpp: (createDefaultWebContext): Use WKContextCreate() when creating default context.

2:19 PM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org

(diff)

2:11 PM Changeset in webkit [124091] by enne@google.com

19 edits
1 copy
7 adds in trunk

[chromium] Remove dependency on ScrollbarTheme from the compositor
https://bugs.webkit.org/show_bug.cgi?id=90528

Reviewed by James Robinson.

Source/Platform:

Flesh out WebScrollbar functions enough to be able to implement
the parts of ScrollbarThemeClient that Chromium uses.

Wrap ScrollbarThemeComposite in the Platform API via two different
classes: WebScrollbarThemePainter is the non-threadsafe version that
is used to paint parts of a scrollbar into a context. This is intended
to only be used on the main thread. WebScrollbarThemeGeometry is the
threadsafe version, used to get the location and sizes of scrollbar
parts on both threads, so they can be painted on the main thread and
composited on the compositor thread.

Unfortunately, there is no way to enforce these thread safety issues,
as other ports use the ScrollbarTheme hierarchy differently than
Chromium does. On the bright side, other than painting, the
ScrollbarTheme code is largely functional and we can enforce this
internally for the Chromium port.

Platform.gypi:
chromium/public/WebScrollbar.h:

(WebCore):
(WebKit):
(WebScrollbar):

chromium/public/WebScrollbarThemeGeometry.h: Added.

(WebCore):
(WebKit):
(WebScrollbarThemeGeometry):
(WebKit::WebScrollbarThemeGeometry::WebScrollbarThemeGeometry):
(WebKit::WebScrollbarThemeGeometry::~WebScrollbarThemeGeometry):
(WebKit::WebScrollbarThemeGeometry::operator=):
(WebKit::WebScrollbarThemeGeometry::isNull):

chromium/public/WebScrollbarThemePainter.h: Added.

(WebCore):
(WebKit):
(WebScrollbarThemePainter):
(WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter):
(WebKit::WebScrollbarThemePainter::~WebScrollbarThemePainter):
(WebKit::WebScrollbarThemePainter::operator=):
(WebKit::WebScrollbarThemePainter::isNull):

Source/WebCore:

Tested by existing layout tests.

ScrollbarLayerChromium is modified to use the Platform API for
WebScrollbar, WebScrollbarThemePainter, and WebScrollbarThemeGeometry.
This prevents API dependencies from the compositor code into WebCore
scrollbar and theme code.

CCScrollbarLayerImpl::CCScrollbar now implements the WebScrollbar API
instead of the ScrollbarThemeClient API.

Also, CCScrollbarLayerImpl now no longer gets the theme from a static
accessor. It now gets a "copy" of the theme from the main thread via
WebScrollbarThemeGeometry, which is more correct for render theme
scrollbars which were previously using the native theme to get part
geometry. Using the correct theme unfortunately causes crashes due to
bad casts in RenderScrollbarTheme, so this patch turns back off the
use of ScrollbarLayerChromium for themed scrollbars until that can be
resolved.

page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::createScrollbarLayer):

platform/ScrollbarThemeClient.h:

(ScrollbarThemeClient):

platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::create):
(WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(WebCore::ScrollbarBackgroundPainter::create):
(WebCore::ScrollbarBackgroundPainter::ScrollbarBackgroundPainter):
(ScrollbarBackgroundPainter):
(WebCore::ScrollbarThumbPainter::create):
(WebCore::ScrollbarThumbPainter::ScrollbarThumbPainter):
(ScrollbarThumbPainter):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
(WebCore::ScrollbarLayerChromium::setTexturePriorities):
(WebCore::ScrollbarLayerChromium::update):

platform/graphics/chromium/ScrollbarLayerChromium.h:

(ScrollbarLayerChromium):

platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::setScrollbarData):
(WebCore::toUVRect):
(WebCore::CCScrollbarLayerImpl::appendQuads):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isOverlay):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::value):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::location):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::size):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::enabled):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::maximum):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::totalSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollViewScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollableAreaActive):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::getTickmarks):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::controlSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::pressedPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::hoveredPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::scrollbarOverlayStyle):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::orientation):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isCustomScrollbar):

platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):
(CCScrollbar):

Source/WebKit/chromium:

Add implementations for WebScrollbarThemeGeometry and
WebScrollbarThemePainter. Fill out additional API calls for
WebPluginScrollbarImpl since it derives from WebScrollbar.

Add WebScrollbarImpl to the client API to wrap and own an existing
WebCore Scrollbar object and provide the WebScrollbar interface.

By keeping WebScrollbar separate from WebScrollbarThemeGeometry, the
compositor thread can create its own thread-safe data bag version of a
WebScrollbar (CCScrollbarLayerImpl::CCScrollbar), but this requires
WebScrollbarThemeClientImpl.

WebScrollbarThemeClientImpl does the reverse of WebScrollbarImpl; it
wraps a WebScrollbar and provides the ScrollbarThemeClient interface.
This is so that a WebScrollbar can be passed to the geometry and
painter functions. Then, internally the WebScrollbarThemeClientImpl
can be used to adapt the WebScrollbar to the ScrollbarThemeClient
interface so the geometry and painter functions can call direct
functions on ScrollbarThemeComposite.

WebKit.gyp:
src/AssertMatchingEnums.cpp:
src/ExternalPopupMenu.h:

(WebKit):

src/WebPluginScrollbarImpl.cpp:

(WebKit::WebPluginScrollbarImpl::WebPluginScrollbarImpl):
(WebKit::WebPluginScrollbarImpl::location):
(WebKit):
(WebKit::WebPluginScrollbarImpl::size):
(WebKit::WebPluginScrollbarImpl::enabled):
(WebKit::WebPluginScrollbarImpl::maximum):
(WebKit::WebPluginScrollbarImpl::totalSize):
(WebKit::WebPluginScrollbarImpl::isScrollViewScrollbar):
(WebKit::WebPluginScrollbarImpl::isScrollableAreaActive):
(WebKit::WebPluginScrollbarImpl::getTickmarks):
(WebKit::WebPluginScrollbarImpl::controlSize):
(WebKit::WebPluginScrollbarImpl::pressedPart):
(WebKit::WebPluginScrollbarImpl::hoveredPart):
(WebKit::WebPluginScrollbarImpl::scrollbarOverlayStyle):
(WebKit::WebPluginScrollbarImpl::orientation):
(WebKit::WebPluginScrollbarImpl::isCustomScrollbar):
(WebKit::WebPluginScrollbarImpl::onMouseUp):
(WebKit::WebPluginScrollbarImpl::onMouseMove):
(WebKit::WebPluginScrollbarImpl::onMouseLeave):

src/WebPluginScrollbarImpl.h:

(WebPluginScrollbarImpl):

src/WebScrollbarImpl.cpp: Added.

(WebKit):
(WebKit::WebScrollbar::create):
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::isOverlay):
(WebKit::WebScrollbarImpl::value):
(WebKit::WebScrollbarImpl::location):
(WebKit::WebScrollbarImpl::size):
(WebKit::WebScrollbarImpl::enabled):
(WebKit::WebScrollbarImpl::maximum):
(WebKit::WebScrollbarImpl::totalSize):
(WebKit::WebScrollbarImpl::isScrollViewScrollbar):
(WebKit::WebScrollbarImpl::isScrollableAreaActive):
(WebKit::WebScrollbarImpl::getTickmarks):
(WebKit::WebScrollbarImpl::controlSize):
(WebKit::WebScrollbarImpl::pressedPart):
(WebKit::WebScrollbarImpl::hoveredPart):
(WebKit::WebScrollbarImpl::scrollbarOverlayStyle):
(WebKit::WebScrollbarImpl::orientation):
(WebKit::WebScrollbarImpl::isCustomScrollbar):

src/WebScrollbarImpl.h: Copied from Source/Platform/chromium/public/WebScrollbar.h.

(WebCore):
(WebKit):
(WebScrollbarImpl):

src/WebScrollbarThemeClientImpl.cpp: Added.

(WebKit):
(WebKit::WebScrollbarThemeClientImpl::WebScrollbarThemeClientImpl):
(WebKit::WebScrollbarThemeClientImpl::x):
(WebKit::WebScrollbarThemeClientImpl::y):
(WebKit::WebScrollbarThemeClientImpl::width):
(WebKit::WebScrollbarThemeClientImpl::height):
(WebKit::WebScrollbarThemeClientImpl::size):
(WebKit::WebScrollbarThemeClientImpl::location):
(WebKit::WebScrollbarThemeClientImpl::parent):
(WebKit::WebScrollbarThemeClientImpl::root):
(WebKit::WebScrollbarThemeClientImpl::setFrameRect):
(WebKit::WebScrollbarThemeClientImpl::frameRect):
(WebKit::WebScrollbarThemeClientImpl::invalidate):
(WebKit::WebScrollbarThemeClientImpl::invalidateRect):
(WebKit::WebScrollbarThemeClientImpl::scrollbarOverlayStyle):
(WebKit::WebScrollbarThemeClientImpl::getTickmarks):
(WebKit::WebScrollbarThemeClientImpl::isScrollableAreaActive):
(WebKit::WebScrollbarThemeClientImpl::isScrollViewScrollbar):
(WebKit::WebScrollbarThemeClientImpl::convertFromContainingWindow):
(WebKit::WebScrollbarThemeClientImpl::isCustomScrollbar):
(WebKit::WebScrollbarThemeClientImpl::orientation):
(WebKit::WebScrollbarThemeClientImpl::value):
(WebKit::WebScrollbarThemeClientImpl::currentPos):
(WebKit::WebScrollbarThemeClientImpl::visibleSize):
(WebKit::WebScrollbarThemeClientImpl::totalSize):
(WebKit::WebScrollbarThemeClientImpl::maximum):
(WebKit::WebScrollbarThemeClientImpl::controlSize):
(WebKit::WebScrollbarThemeClientImpl::lineStep):
(WebKit::WebScrollbarThemeClientImpl::pageStep):
(WebKit::WebScrollbarThemeClientImpl::pressedPart):
(WebKit::WebScrollbarThemeClientImpl::hoveredPart):
(WebKit::WebScrollbarThemeClientImpl::styleChanged):
(WebKit::WebScrollbarThemeClientImpl::enabled):
(WebKit::WebScrollbarThemeClientImpl::setEnabled):
(WebKit::WebScrollbarThemeClientImpl::isOverlayScrollbar):

src/WebScrollbarThemeClientImpl.h: Added.

(WebCore):
(WebKit):
(WebScrollbarThemeClientImpl):

src/WebScrollbarThemeGeometry.cpp: Added.

(WebKit):
(WebKit::WebScrollbarThemeGeometry::assign):
(WebKit::WebScrollbarThemeGeometry::thumbPosition):
(WebKit::WebScrollbarThemeGeometry::thumbLength):
(WebKit::WebScrollbarThemeGeometry::trackPosition):
(WebKit::WebScrollbarThemeGeometry::trackLength):
(WebKit::WebScrollbarThemeGeometry::hasButtons):
(WebKit::WebScrollbarThemeGeometry::hasThumb):
(WebKit::WebScrollbarThemeGeometry::trackRect):
(WebKit::WebScrollbarThemeGeometry::thumbRect):
(WebKit::WebScrollbarThemeGeometry::minimumThumbLength):
(WebKit::WebScrollbarThemeGeometry::scrollbarThickness):
(WebKit::WebScrollbarThemeGeometry::backButtonStartRect):
(WebKit::WebScrollbarThemeGeometry::backButtonEndRect):
(WebKit::WebScrollbarThemeGeometry::forwardButtonStartRect):
(WebKit::WebScrollbarThemeGeometry::forwardButtonEndRect):
(WebKit::WebScrollbarThemeGeometry::constrainTrackRectToTrackPieces):
(WebKit::WebScrollbarThemeGeometry::splitTrack):
(WebKit::WebScrollbarThemeGeometry::WebScrollbarThemeGeometry):

src/WebScrollbarThemePainter.cpp: Added.

(WebKit):
(WebKit::WebScrollbarThemePainter::assign):
(WebKit::WebScrollbarThemePainter::paintScrollbarBackground):
(WebKit::WebScrollbarThemePainter::paintTrackBackground):
(WebKit::WebScrollbarThemePainter::paintBackTrackPart):
(WebKit::WebScrollbarThemePainter::paintForwardTrackPart):
(WebKit::WebScrollbarThemePainter::paintBackButtonStart):
(WebKit::WebScrollbarThemePainter::paintBackButtonEnd):
(WebKit::WebScrollbarThemePainter::paintForwardButtonStart):
(WebKit::WebScrollbarThemePainter::paintForwardButtonEnd):
(WebKit::WebScrollbarThemePainter::paintTickmarks):
(WebKit::WebScrollbarThemePainter::paintThumb):
(WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter):

tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::MockScrollbar::convertFromContainingWindow):
(WebCore::MockScrollbar::isOverlayScrollbar):
(MockScrollbar):
(WebCore::TEST):

LayoutTests:

Mark custom-composited-different-track-parts.html as failing because
custom scrollbars no longer create ScrollbarLayerChromiums. This is
due to the unsafe casts in RenderThemeScrollbar.

platform/chromium/TestExpectations:

2:07 PM Changeset in webkit [124090] by dpranke@chromium.org

3 edits in trunk/Tools

nrwt: --verbose logging does not work right on windows
https://bugs.webkit.org/show_bug.cgi?id=92673

Unreviewed, build fix.

The --verbose log level is not being propagated to the worker
processes on windows properly; this has been broken ever since I
refactored logging into the message pool directly :(.

Also, fixing this revealed that outputcapture wasn't saving and
restoring log levels correctly, so I had to fix that as well.

Scripts/webkitpy/common/message_pool.py:

(_MessagePool._start_workers):
(_MessagePool._worker_log_level):
(_Worker.init):
(_Worker._set_up_logging):
(_WorkerLogHandler.init):

Scripts/webkitpy/common/system/outputcapture.py:

(OutputCapture.capture_output):
(OutputCapture.restore_output):

2:06 PM Changeset in webkit [124089] by kling@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION(r123636): Heap-use-after-free in StyleResolver::collectMatchingRules.
<http://webkit.org/b/92430>

Reviewed by Antti Koivisto.

Don't hold on to a reference to StyledElement::classNames() as that may become
invalid after mutating the element's attribute data.

In this case it was happening below Element::hasAttributes() which is unfortunately
naive enough to always serialize lazy attributes. That is a minor inefficiency that
can be addressed in a separate patch.

Covered by valgrind on existing tests.

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRules):

2:02 PM Changeset in webkit [124088] by tomhudson@google.com

1 edit
2 adds
1 delete in trunk/LayoutTests

Baselines on additional platforms for fast/table/table-row-focus-ring-paint.
https://bugs.webkit.org/show_bug.cgi?id=85348

Unreviewed gardening.

platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Removed.
platform/chromium-mac/fast/table/table-row-focus-ring-paint-expected.png: Added.
platform/chromium-win/fast/table/table-row-focus-ring-paint-expected.png: Added.

1:57 PM Changeset in webkit [124087] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] critical warning: gdk_window_get_cursor() called on a NULL window
https://bugs.webkit.org/show_bug.cgi?id=92651

Patch by Claudio Saavedra <Claudio Saavedra> on 2012-07-30
Reviewed by Martin Robinson.

PageClientImpl::setCursor() might get called before the
window is realized, so safeguard against it.

UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursor): early return if the window is
not realized.

1:52 PM Changeset in webkit [124086] by rakuco@webkit.org

2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Fix r124028 by adding the missing expectations to the added lines.

platform/efl/TestExpectations:

1:49 PM Changeset in webkit [124085] by senorblanco@chromium.org

5 edits
1 delete in trunk/LayoutTests

[chromium] Unreviewed gardening. Add new baselines for tests
affected by r124042.

platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png:
platform/chromium-win-xp/fast/backgrounds/repeat: Removed.
platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:

1:45 PM Changeset in webkit [124084] by pkasting@chromium.org

2 edits in trunk/LayoutTests

Force Mac editing mode on new test so other platforms will pass it.
https://bugs.webkit.org/show_bug.cgi?id=92662

Reviewed by Ryosuke Niwa.

fast/writing-mode/flipped-blocks-hit-test-line-edges.html:

1:42 PM Changeset in webkit [124083] by Lucas Forschler

2 edits in branches/safari-536.26-branch/LayoutTests

Merged r117801. <rdar://problem/11942076>

1:41 PM Changeset in webkit [124082] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r117792. <rdar://problem/11942076>

1:37 PM Changeset in webkit [124081] by Lucas Forschler

1 edit
2 copies
2 deletes in branches/safari-536.26-branch/LayoutTests

Merged r116665. <rdar://problem/11942038>

1:35 PM Changeset in webkit [124080] by Lucas Forschler

7 edits
2 copies in branches/safari-536.26-branch

Merged r116653. <rdar://problem/11942038>

1:19 PM Changeset in webkit [124079] by Csaba Osztrogonác

2 edits
2 adds
1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt-5.0/Skipped: Unskip now passing tests. (bug85203)
platform/qt-5.0/fast/js/global-constructors-expected.txt: Added. Same as platform/qt/...expected.txt, but has more attribute because of enabled SVG_FONTS.
platform/qt/fast/js/global-constructors-expected.png: Removed, it is text only test.

1:13 PM Changeset in webkit [124078] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r118005. <rdar://problem/11942082>

1:05 PM Changeset in webkit [124077] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[chromium] CCThreadTask should not depend on CrossThreadTask and does not need to depend on CrossThreadCopier
https://bugs.webkit.org/show_bug.cgi?id=90132

Patch by James Robinson <jamesr@chromium.org> on 2012-07-30
Reviewed by David Levin.

CrossThreadTask is defined in WebCore/dom/ and depends on concepts like ScriptExecutionConcept. CCThreadTask,
being in WebCore/platform/, should not depend on /dom/ or anything from that layer.

CrossThreadCopier is not a layering violation per se, but it's also not at all helpful for CCThreadTask - we
never use any types for which it would be useful.

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::setVisible):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::implSideRenderingStats):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::forceSerializeOnSwapBuffers):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::acquireLayerTextures):

platform/graphics/chromium/cc/CCThreadTask.h:

(CCThreadTask1):
(WebCore::CCThreadTask1::create):
(WebCore::CCThreadTask1::CCThreadTask1):
(CCThreadTask2):
(WebCore::CCThreadTask2::create):
(WebCore::CCThreadTask2::CCThreadTask2):
(CCThreadTask3):
(WebCore::CCThreadTask3::create):
(WebCore::CCThreadTask3::CCThreadTask3):
(CCThreadTask4):
(WebCore::CCThreadTask4::create):
(WebCore::CCThreadTask4::CCThreadTask4):
(CCThreadTask5):
(WebCore::CCThreadTask5::create):
(WebCore::CCThreadTask5::CCThreadTask5):
(WebCore::createCCThreadTask):

1:04 PM Changeset in webkit [124076] by schenney@chromium.org

1 edit
2 copies in branches/chromium/1180

Merge 123377 - Crash when setting empty class name on a new element
https://bugs.webkit.org/show_bug.cgi?id=92024

Reviewed by Andreas Kling.

Source/WebCore:

Add a check for null attributeData() when setting the className to an
empty string on a newly created element. New SVG elements have null
attributeData() on baseVal upon creation.

Test: svg/custom/empty-className-baseVal-crash.html

dom/StyledElement.cpp:

(WebCore::StyledElement::classAttributeChanged): Add check for null attributeData()

LayoutTests:

Add a check for null attributeData() when setting the className to an
empty string on a newly created element.

svg/custom/empty-className-baseVal-crash-expected.txt: Added.
svg/custom/empty-className-baseVal-crash.html: Added.

TBR=schenney@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824091

12:51 PM Changeset in webkit [124075] by senorblanco@chromium.org

5 edits
1 delete in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaseline another test affected by
r124042.

platform/chromium-linux-x86/fast/gradients: Removed.
platform/chromium-linux/fast/gradients/background-clipped-expected.png:
platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png:
platform/chromium-mac/fast/gradients/background-clipped-expected.png:
platform/chromium/TestExpectations:

12:49 PM Changeset in webkit [124074] by Lucas Forschler

4 edits
2 copies in branches/safari-536.26-branch

Merged r117957. <rdar://problem/11942079>

12:32 PM Changeset in webkit [124073] by Lucas Forschler

3 edits in branches/safari-536.26-branch/Source/WebCore

Merged r117376. <rdar://problem/11942074>

12:26 PM Changeset in webkit [124072] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r117309. <rdar://problem/11942073>

12:24 PM WebKit Team edited by apavlov@chromium.org

Add apavlov to the reviewers list (diff)

11:55 AM Changeset in webkit [124071] by dpranke@chromium.org

2 edits in trunk/Tools

After r123895, new-run-webkit-tests can fail with TypeError when a test crashes
https://bugs.webkit.org/show_bug.cgi?id=92664

Reviewed by Michael Saboff.

Updated to handle crash_logs being returned as a tuple of (stderr, crash_log).

Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.look_for_new_crash_logs):

11:54 AM Changeset in webkit [124070] by pkasting@chromium.org

19 edits
1 delete in trunk/LayoutTests

[Chromium] Rebaseline tests for Skia changes.
http://crbug.com/130283
http://crbug.com/131188

Unreviewed, test expectations update.

platform/chromium-linux/css3/filters/effect-combined-hw-expected.png:
platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png:
platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
platform/chromium-mac/css3/filters/effect-combined-hw-expected.png:
platform/chromium-mac/css3/filters/effect-grayscale-hw-expected.png:
platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png:
platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png:
platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Removed.
platform/chromium-win/css3/filters/effect-combined-hw-expected.png:
platform/chromium-win/css3/filters/effect-grayscale-hw-expected.png:
platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.png:
platform/chromium-win/css3/filters/effect-saturate-hw-expected.png:
platform/chromium-win/css3/filters/effect-sepia-hw-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:

11:53 AM Changeset in webkit [124069] by Patrick Gansterer

5 edits in trunk/Source/WTF

Add special export macro for string related functions
https://bugs.webkit.org/show_bug.cgi?id=92624

Reviewed by Hajime Morita.

The windows port compiles string related code into every binary for performance reasons (see r59187).
Add the WTF_EXPORT_STRING_API define to allow this behaviour with export macros too.

wtf/ExportMacros.h:
wtf/text/AtomicString.h:

(AtomicString):

wtf/text/StringImpl.h:

(StringImpl):
(WTF):

wtf/text/WTFString.h:

(WTF):
(String):

11:49 AM Changeset in webkit [124068] by Patrick Gansterer

3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r123983.
http://trac.webkit.org/changeset/123983
https://bugs.webkit.org/show_bug.cgi?id=92663

EFL build is broken when unit tests are enabled (Requested by
paroga on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

CMakeLists.txt:
PlatformEfl.cmake:

11:49 AM Changeset in webkit [124067] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Web Inspector: Rename Databases to Web SQL
https://bugs.webkit.org/show_bug.cgi?id=92646

Patch by Paul Irish <paul.irish@gmail.com> on 2012-07-30
Reviewed by Pavel Feldman.

Renamed Databases to Web SQL. Drive-by fix for EmptyView
selection.

English.lproj/localizedStrings.js:
inspector/front-end/EmptyView.js:
inspector/front-end/ResourcesPanel.js:

11:46 AM Changeset in webkit [124066] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r117304. <rdar://problem/11942070>

11:44 AM Changeset in webkit [124065] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r117289. <rdar://problem/11932472>

11:39 AM Changeset in webkit [124064] by tony@chromium.org

3 edits
2 adds in trunk

new flexbox should ignore float set on flexitems
https://bugs.webkit.org/show_bug.cgi?id=70792

Reviewed by Ojan Vafai.

Source/WebCore:

Force flex items to not float.

Test: css3/flexbox/floated-flexitem.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): Force NoFloat on flex items.

LayoutTests:

Make an example in the spec into a ref test. Add some styles to make it a bit more clear what's happening.

css3/flexbox/floated-flexitem-expected.html: Added.
css3/flexbox/floated-flexitem.html: Added.

11:37 AM Changeset in webkit [124063] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r117161. <rdar://problem/11942062>

11:35 AM Changeset in webkit [124062] by Lucas Forschler

6 edits
4 copies in branches/safari-536.26-branch

Merged r117007. <rdar://problem/11942085>

11:33 AM Changeset in webkit [124061] by pkasting@chromium.org

2 edits
1 add in trunk/LayoutTests

[Chromium] New baselines and test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=88939
https://bugs.webkit.org/show_bug.cgi?id=91485
http://crbug.com/139162

Unreviewed, test expectations update.

platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added.
platform/chromium/TestExpectations:

11:30 AM Changeset in webkit [124060] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r116860. <rdar://problem/11942084>

11:27 AM Changeset in webkit [124059] by Lucas Forschler

4 edits
4 copies in branches/safari-536.26-branch

Merged r116827. <rdar://problem/11961140>

11:24 AM Changeset in webkit [124058] by Lucas Forschler

2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r116717. <rdar://problem/11942052>

11:22 AM Changeset in webkit [124057] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r116698. <rdar://problem/11942088>

11:20 AM Changeset in webkit [124056] by senorblanco@chromium.org

6 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Add new mac baselines for tests
affected by r124042. Fix a typo in TestExpectations.

platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
platform/chromium/TestExpectations:

11:17 AM Changeset in webkit [124055] by Lucas Forschler

4 edits
2 copies in branches/safari-536.26-branch

Merged r116683. <rdar://problem/11942090>

11:15 AM Changeset in webkit [124054] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r116669. <rdar://problem/11942055>

11:01 AM Changeset in webkit [124053] by zandobersek@gmail.com

1 edit
6 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Adding platform-specific baselines that are required after r123793, r123912 and r123914.

platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.txt: Added.
platform/gtk/fast/table/table-row-outline-paint-expected.png: Added.
platform/gtk/fast/table/table-row-outline-paint-expected.txt: Added.
platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.

11:00 AM Changeset in webkit [124052] by enne@google.com

2 edits in trunk/Source/WebCore

[chromium] Turn back on ScrollbarLayerChromium for Windows
https://bugs.webkit.org/show_bug.cgi?id=92409

Reviewed by James Robinson.

This reverts r122791. As GDI issues were addressed in Chromium via
http://src.chromium.org/viewvc/chrome?view=rev&revision=148215,
scrollbar parts can now be composited on the thread.

page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::createScrollbarLayer):

10:56 AM Changeset in webkit [124051] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Marking two accelerated painting
tests as crashing intermittently.
https://bugs.webkit.org/show_bug.cgi?id=92660

platform/chromium/TestExpectations:

10:48 AM Changeset in webkit [124050] by mifenton@rim.com

5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Optimize the generation of selection details generation.
https://bugs.webkit.org/show_bug.cgi?id=92522

Reviewed by Antonio Gomes.

PR 179264.

Reduce the number of times we generate selection details notifications.

This removes several notifications that are handled by the standard
notification path and makes skipping duplicate notifications the default
so that only those that must generate a response do.

Reviewed Internally by Gen Mak.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
(BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementUnfocused):

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

WebKitSupport/SelectionHandler.h:

(SelectionHandler):

10:46 AM Changeset in webkit [124049] by commit-queue@webkit.org

11 edits
3 copies
1 move
4 deletes in trunk

Unreviewed, rolling out r124025.
http://trac.webkit.org/changeset/124025
https://bugs.webkit.org/show_bug.cgi?id=92658

Causes color-suggestion-picker-appearance layout test to time
out on all Chromium platforms (Requested by tomhudson_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

Source/Platform:

chromium/public/WebLocalizedString.h:

Source/WebCore:

rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsDataListUI):

Source/WebKit/chromium:

WebKit.gyp:
src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::createColorChooser):

src/ChromeClientImpl.h:

(WebCore):
(ChromeClientImpl):

src/ColorChooserProxy.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.

(WebKit):
(WebKit::ColorChooserProxy::ColorChooserProxy):
(WebKit::ColorChooserProxy::~ColorChooserProxy):
(WebKit::ColorChooserProxy::setSelectedColor):
(WebKit::ColorChooserProxy::endChooser):

src/ColorChooserProxy.h: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.

(WebKit):
(ColorChooserProxy):

src/ColorChooserUIController.cpp: Removed.
src/WebColorChooserClientImpl.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.

(WebKit):
(WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::didChooseColor):
(WebKit::WebColorChooserClientImpl::didEndChooser):

src/WebColorChooserClientImpl.h: Renamed from Source/WebKit/chromium/src/ColorChooserUIController.h.

(WebCore):
(WebKit):
(WebColorChooserClientImpl):

LayoutTests:

platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
platform/chromium/TestExpectations:
platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Removed.
platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Removed.
platform/chromium/fast/forms/datalist/input-list-expected.txt:

10:44 AM Changeset in webkit [124048] by zandobersek@gmail.com

3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Skipping a test that utilizes unsupported isolated worlds and updating
one baseline after r123988.

platform/gtk/TestExpectations:
platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:

10:41 AM Changeset in webkit [124047] by commit-queue@webkit.org

1 edit
4 adds in trunk/LayoutTests

REGRESSION: Focused TR element draws its focus outline in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=85348

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-30
Reviewed by Julien Chaffraix.

The focus ring used to be drawn around the first row of the table section irrespective of the row in focus.
The issue was fixed by the bug http://www.webkit.org/b/92389 .
Adding a regression test case.

fast/table/table-row-focus-ring-paint-expected.txt: Added.
fast/table/table-row-focus-ring-paint.html: Added.
platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Added.
platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Added.

10:40 AM Changeset in webkit [124046] by senorblanco@chromium.org

2 edits in trunk/Tools

Added a SkiaGraphics definition to the watchlist file; cc'ed myself
to that group. Unreviewed.

Scripts/webkitpy/common/config/watchlist:

10:27 AM Changeset in webkit [124045] by commit-queue@webkit.org

15 edits
4 deletes in trunk

Unreviewed, rolling out r123966 and r123967.
http://trac.webkit.org/changeset/123966
http://trac.webkit.org/changeset/123967
https://bugs.webkit.org/show_bug.cgi?id=92656

This patch is causing assertion failures on the debug bot
(also rolling out a dependent patch) (Requested by mrobinson
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

Source/WebCore:

GNUmakefile.am:
GNUmakefile.list.am:
platform/text/gtk/TextCheckerEnchant.cpp: Removed.
platform/text/gtk/TextCheckerEnchant.h: Removed.

Source/WebKit/gtk:

webkit/webkitspellcheckerenchant.cpp:

(_WebKitSpellCheckerEnchantPrivate):
(createEnchantBrokerIfNeeded):
(freeSpellCheckingLanguage):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(wordEndIsAContractionApostrophe):
(checkSpellingOfString):
(getGuessesForWord):
(getAvailableDictionariesCallback):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):

Source/WebKit2:

GNUmakefile.am:
GNUmakefile.list.am:
UIProcess/API/gtk/WebKitPrivate.h:
UIProcess/API/gtk/WebKitTextChecker.cpp: Removed.
UIProcess/API/gtk/WebKitTextChecker.h: Removed.
UIProcess/API/gtk/WebKitWebContext.cpp:

(_WebKitWebContextPrivate):
(createDefaultWebContext):

UIProcess/API/gtk/WebKitWebContext.h:
UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(beforeAll):

Tools:

gtk/generate-gtkdoc:

(get_webkit2_options):

10:24 AM Changeset in webkit [124044] by jchaffraix@webkit.org

3 edits
4 adds in trunk

ASSERTION FAILED: !rect.isEmpty() : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect &)
https://bugs.webkit.org/show_bug.cgi?id=92187

Reviewed by Simon Fraser.

Source/WebCore:

The border painting logic (RenderBoxModelObject::paintOneBorderSide) would pass a rect with a 0px length
to RenderObject::drawLineForBoxSide. We do check the width (thickness) but not the length so we would pass
the rect to GraphicsContext and hit the ASSERT. This change adds a check for the length too as it is the safest
way, it means that we may still do unneeded operations before bailing out but that's an existing problem in the code.

Tests: fast/borders/0px-borders-no-line-height.html

fast/borders/double-1px-border-assert.html

rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
Added a 0px length check. While renaming confusing variables and re-using others,
I also found a potential empty border that I fixed (tested by the 2nd case above).

LayoutTests:

fast/borders/0px-borders-no-line-height-expected.html: Added.
fast/borders/0px-borders-no-line-height.html: Added.
fast/borders/double-1px-border-assert-expected.html: Added.
fast/borders/double-1px-border-assert.html: Added.

10:24 AM Changeset in webkit [124043] by Lucas Forschler

5 edits
1 copy in branches/safari-536.26-branch

Merged r116647. <rdar://problem/11942030>

10:22 AM Changeset in webkit [124042] by senorblanco@chromium.org

4 edits in trunk

[chromium] Refactor the computation of resampled bitmap size in
drawImage and drawPattern.
https://bugs.webkit.org/show_bug.cgi?id=92408

Reviewed by Adrienne Walker.

Source/WebCore:

We used to have a special-purpose function called TransformDimensions()
which did pretty much the same thing as SkRect::mapRect() does. This
change unifies the drawPattern code to use mapRect() in the same way
that drawImage() does.

Covered by existing tests, e.g., fast/backgrounds/size/*.

platform/graphics/skia/ImageSkia.cpp:

(WebCore):
(WebCore::Image::drawPattern):
Note: we're now doing using the original (float) source rect, and
converting to int only after applying the matrix transform. This
might result in different decisions about resampling mode, but it's
more correct anyway.

LayoutTests:

Mark a test as expected to fail (will need rebaseline).

platform/chromium/TestExpectations:

10:19 AM Changeset in webkit [124041] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][DRT] fast/text/font-variant-ligatures.html fails with missing rendering output
https://bugs.webkit.org/show_bug.cgi?id=85606

Unreviewed, EFL gardening.

Unskip test that's passing after r123864 due to complex font support.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-30

platform/efl/TestExpectations: font-variant-ligatures.html unskipped.

10:18 AM Changeset in webkit [124040] by Lucas Forschler

3 edits in branches/safari-536.26-branch/Source/WebCore

Merged r116642. <rdar://problem/11942097>

10:17 AM Changeset in webkit [124039] by Martin Robinson

4 edits
1 add
1 delete in trunk/Tools

[GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=92626

Reviewed by Gustavo Noronha Silva.

Instead of always shelling out to enter a jhbuild environment, add a Python
hook for entering a jhbuild environment directly. This avoids requiring a
script to be wrapped in jhbuild.

GNUmakefile.am: Remove gtk/run-api-tests from the distribution list.
Scripts/run-gtk-tests: Move most of the logic from run-api-tests here

with additional code for entering a jhbuild environment directly.

gtk/run-api-tests: Removed.
jhbuild/jhbuild-wrapper: Use the new helper methods defined in jhbuildutils.py.
jhbuild/jhbuildutils.py: Add some new helper methods here including

a method which can transform the current environment into a jhbuild-ified one.

10:12 AM Changeset in webkit [124038] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r116551. <rdar://problem/11942093>

10:07 AM Changeset in webkit [124037] by Lucas Forschler

3 edits
2 copies in branches/safari-536.26-branch

Merged r116545. <rdar://problem/11942059>

10:04 AM Changeset in webkit [124036] by Lucas Forschler

11 edits
2 copies in branches/safari-536.26-branch

Merged r116476. <rdar://problem/11942023>

9:35 AM Changeset in webkit [124035] by apavlov@chromium.org

2 edits in trunk/Tools

Unreviewed, upgrade apavlov to reviewer.
http://lists.webkit.org/mailman/private/webkit-committers/2012-July/000184.html

Scripts/webkitpy/common/config/committers.py:

9:32 AM Changeset in webkit [124034] by commit-queue@webkit.org

9 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=92642
[Bindings]Remove custom JS/V8 bindings for WebSocket::close() using [Clamp]

Patch by Vineet Chaudhary <Vineet> on 2012-07-30
Reviewed by Kentaro Hara.

With support of [Clamp] as extended attribute we can replace custom bindings from WebSocket::close().
Spec for WebSocket::close() : http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#websocket

No new tests. There should be no behavioural changes
Existing tests under http/websocket/tests/hybi/ should cover this.

Modules/websockets/WebSocket.h:

(WebCore::WebSocket::close):

Modules/websockets/WebSocket.idl: Used [Clamp].
bindings/js/JSWebSocketCustom.cpp: Removed custom call close().

(WebCore):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::classMethodWithClampCallback):

bindings/v8/custom/V8WebSocketCustom.cpp: Removed custom call close().

(WebCore):

9:19 AM Changeset in webkit [124033] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unkskip more passing tests after bug85203.

platform/qt-5.0-wk1/Skipped:
platform/qt-5.0-wk2/Skipped:

8:58 AM Changeset in webkit [124032] by vsevik@chromium.org

24 edits
4 adds in trunk

Web Inspector: Resource agent's reference to cached resources should be weak.
https://bugs.webkit.org/show_bug.cgi?id=92108

Reviewed by Pavel Feldman.

Source/autotools/symbols.filter:

Source/WebCore:

NetworkResourcesData now stores a raw pointer to CachedResource.
CachedResource now notifies InspectorInstrumentation that it will be destroyed.
InspectorInstrumentation stores a set of InstrumentingAgents and broadcasts willDestroyCachedResource event to all available resourceAgents.
Destroyed resources content is saved to NetworkResourcesData.

Tests: http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html

http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html

WebCore.exp.in:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willDestroyCachedResourceImpl):
(WebCore::InspectorInstrumentation::registerInstrumentingAgents):
(WebCore::InspectorInstrumentation::unregisterInstrumentingAgents):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDestroyCachedResource):
(WebCore):

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::willDestroyCachedResource):
(WebCore):
(WebCore::InspectorResourceAgent::getResponseBody):

inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

inspector/NetworkResourcesData.cpp:

inspector/NetworkResourcesData.h:

(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::base64Encoded):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):
(WebCore):

loader/cache/CachedResource.h:

(CachedResource):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::clearPreloads):

loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::evict):

testing/InternalSettings.cpp:
testing/Internals.cpp:

(WebCore::Internals::garbageCollectDocumentResources):
(WebCore):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Added.
http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Added.
http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Added.
http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Added.

8:54 AM Changeset in webkit [124031] by commit-queue@webkit.org

7 edits in trunk

[BlackBerry] Adapt to changes in the SharedArray platform API
https://bugs.webkit.org/show_bug.cgi?id=92631

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-07-30
Reviewed by Rob Buis.

Adapt to changes in the SharedArray platform API. No behavioural change.

Source/WebKit/blackberry:

Reviewed internally by Joe Mason.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::getBackForwardList):

Api/WebPage.h:
Api/WebPageClient.h:
WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::runOpenPanel):

Tools:

DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::webHistoryItemCount):

8:47 AM Changeset in webkit [124030] by Csaba Osztrogonác

3 edits
1 add in trunk/LayoutTests

[Qt] Gardening. Skip failing tests and add a Qt specific expected file.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-07-30
Reviewed by Csaba Osztrogonác.

platform/qt-4.8/Skipped: Skip svg/custom/svg-features.html.
platform/qt/Skipped: Skip http/tests/security/contentSecurityPolicy/object-src-none-blocked.html.
platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added because of a whitespace difference.

8:43 AM Changeset in webkit [124029] by Csaba Osztrogonác

4 edits
2 deletes in trunk/LayoutTests

[Qt] Default sizes for input-text and text-area are different when running DRT/WTR
https://bugs.webkit.org/show_bug.cgi?id=91990

Unreviewed gardening.

platform/qt-5.0-wk2/Skipped: Skip tests.
platform/qt-5.0/Skipped: Unskip accidentally skipped tests.
platform/qt.5-0/fast/text/whitespace/028-expected.png: Remove accidentally committed file.
platform/qt.5-0/fast/text/whitespace/028-expected.txt: Remove accidentally committed file.
platform/qt/Skipped: Unskip non-existing tests.

8:39 AM Changeset in webkit [124028] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Skip new compositing tests for EFL port
https://bugs.webkit.org/show_bug.cgi?id=92633

Unreviewed EFL gardening.

Skip new compositing layout tests until accelerated compositing is enabled.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-07-30

platform/efl/TestExpectations:

8:16 AM Changeset in webkit [124027] by shinyak@chromium.org

18 edits in trunk

Prohibit having AuthorShadowDOM of input or textarea element for a while and having a flag to enable it in Internals.
https://bugs.webkit.org/show_bug.cgi?id=92611

Reviewed by Hajime Morita.

Source/autotools/symbols.filter:

Source/WebCore:

Prohibit having AuthorShadowDOM of input elemnet unless a flag in RuntimeEnabledFeatures is not enabled.
The flag can be enabled in Internals.

The elements in UserAgentShadowDOM of input element assume that they have a renderer when the input
element has a renderer. However, this does not hold when AuthorShadowDOM is added to input element.
So until we fix the issue, we should disable to have AuthorShadowDOM for input element, because it may
cause crashes and security problems.

Tests: fast/dom/shadow/input-with-validation-without-shadow.html

fast/dom/shadow/input-with-validation.html
fast/dom/shadow/shadow-disable.html

bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::authorShadowDOMForAnyElementEnabled):
(WebCore::RuntimeEnabledFeatures::setAuthorShadowDOMForAnyElementEnabled):

dom/ShadowRoot.cpp:

(WebCore::allowsAuthorShadowRoot): The input element or textarea element does not allow to have a ShadowDOM unless
is a flag in RuntimeEnabledFeatures is not enabled.

html/HTMLInputElement.h:

(WebCore::isHTMLInputElement):
(WebCore):

html/HTMLTextAreaElement.h:

(WebCore::isHTMLTextAreaElement):
(WebCore):

testing/Internals.cpp:

(WebCore::Internals::setAuthorShadowDOMForAnyElementEnabled):
(WebCore):

testing/Internals.h:

(Internals):

testing/Internals.idl:

LayoutTests:

fast/dom/shadow/input-with-validation-without-shadow.html: Make the test runs even if

new WebKitShadowRoot() throws an exception.

fast/dom/shadow/input-with-validation.html: Sets a flag to make AuthorShadowDOM available.
fast/dom/shadow/shadow-disable-expected.txt:
fast/dom/shadow/shadow-disable.html: Makes it unavailable for input and textarea to have an AuthorShadowDOM.

8:12 AM Changeset in webkit [124026] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: support --line-numbers mapping for SASS
https://bugs.webkit.org/show_bug.cgi?id=92400

Reviewed by Vsevolod Vlasov.

There is --debug-info and --line-numbers ways of referencing the source scss file, adding support for --line-numbers here.

inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
(WebInspector.SASSSourceMapping.prototype._resourceAdded):
(_bindUISourceCode):

7:32 AM Changeset in webkit [124025] by keishi@webkit.org

11 edits
1 move
4 adds
3 deletes in trunk

Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075

Reviewed by Kent Tamura.

Source/Platform:

chromium/public/WebLocalizedString.h: Added OtherColorLabel.

Source/WebCore:

Test: platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html

rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Added color to types supporting datalist.

Source/WebKit/chromium:

WebKit.gyp:
src/ChromeClientImpl.cpp:

src/ChromeClientImpl.h:

(WebKit):
(ChromeClientImpl):

src/ColorChooserProxy.cpp: Removed.
src/ColorChooserProxy.h: Removed.
src/ColorChooserUIController.cpp: Added.

src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h.

(WebCore):
(WebKit):
(ColorChooserUIController):

src/WebColorChooserClientImpl.cpp: Removed.

LayoutTests:

platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
platform/chromium/TestExpectations:
platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Added.
platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Added. Tests color suggestion picker popup appearance.
platform/chromium/fast/forms/datalist/input-list-expected.txt:

7:23 AM Changeset in webkit [124024] by allan.jensen@nokia.com

2 edits in trunk/Source/WebCore

Wheel events on a page with frames are not handled in fixed layout
https://bugs.webkit.org/show_bug.cgi?id=90550

Reviewed by Antonio Gomes.

Based on patch by Andras Becsi.

Frame-rect size is not the right value to check against to see if the document
can be contained within the full visible content rect, since it does not handle
fixedVisibleContentRect. Instead visibleContentRect(true) should be used which
returns the full visible content rect disregarding scrollbars, and which is
the same a frame-rect size when fixedVisibleContentRect is not set.

platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

7:11 AM Changeset in webkit [124023] by allan.jensen@nokia.com

6 edits in trunk

Source/WebCore: There is no way to tell whether an element can be activated or not
https://bugs.webkit.org/show_bug.cgi?id=92093

Reviewed by Antonio Gomes.

This patch adds the willRespondToMouseClickEvents and willRespondToMouseMoveEvents
functions, named after similar functions in the iOS fork of WebKit.

Touch-adjustment will now use these two functions, which improves accuracy when
targeting shadow-dom elements, and also means touch adjustment will prefer enabled
form-elements over disabled ones.

Test: touchadjustment/disabled-formelements.html

dom/Node.cpp:

(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):

dom/Node.h:

(Node):

editing/DeleteButton.h:
html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::willRespondToMouseClickEvents):

html/HTMLAnchorElement.h:

(HTMLAnchorElement):

html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::willRespondToMouseClickEvents):

html/HTMLButtonElement.h:

(HTMLButtonElement):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::willRespondToMouseClickEvents):

html/HTMLInputElement.h:

(HTMLInputElement):

html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::willRespondToMouseClickEvents):

html/HTMLLabelElement.h:

(HTMLLabelElement):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::willRespondToMouseClickEvents):

html/HTMLMediaElement.h:
html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::willRespondToMouseClickEvents):

html/HTMLSummaryElement.h:

(HTMLSummaryElement):

html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::willRespondToMouseClickEvents):

html/shadow/CalendarPickerElement.h:

(CalendarPickerElement):

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTimelineElement::willRespondToMouseClickEvents):
(WebCore::MediaControlTimelineElement::setPosition):
(WebCore::MediaControlVolumeSliderElement::willRespondToMouseMoveEvents):
(WebCore::MediaControlVolumeSliderElement::willRespondToMouseClickEvents):

html/shadow/MediaControlElements.h:

(MediaControlTimelineElement):
(MediaControlVolumeSliderElement):

html/shadow/MediaControlRootElement.h:
html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):

html/shadow/SliderThumbElement.h:

(SliderThumbElement):

html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::willRespondToMouseClickEvents):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents):
(WebCore::SpinButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):

html/shadow/TextControlInnerElements.h:

(SearchFieldResultsButtonElement):
(SearchFieldCancelButtonElement):
(SpinButtonElement):

html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::willRespondToMouseClickEvents):

html/shadow/TextFieldDecorationElement.h:

(TextFieldDecorationElement):

page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::nodeRespondsToTapGesture):

Source/WebKit/gtk: [Gtk] Add WK1 API for snapshot retrieval
https://bugs.webkit.org/show_bug.cgi?id=92261

Reviewed by Martin Robinson.

Add API to WebKitWebView to retrieve a snapshot of its
visible contents as a cairo_surface_t.

docs/webkitgtk-sections.txt: Add new symbols.
webkit/webkitwebview.cpp:

(webkit_web_view_get_snapshot): New
method to paint a webview snapshot.

webkit/webkitwebview.h: Ditto.

LayoutTests: There is no way to tell whether an element can be activated or not
https://bugs.webkit.org/show_bug.cgi?id=92093

Reviewed by Antonio Gomes.

Tests that enabled formelements are now preferred over disabled formelements.

touchadjustment/disabled-formelements-expected.txt: Added.
touchadjustment/disabled-formelements.html: Added.

6:33 AM Changeset in webkit [124022] by allan.jensen@nokia.com

29 edits
2 adds in trunk

There is no way to tell whether an element can be activated or not
https://bugs.webkit.org/show_bug.cgi?id=92093

Reviewed by Antonio Gomes.

Source/WebCore:

This patch adds the willRespondToMouseClickEvents and willRespondToMouseMoveEvents
functions, named after similar functions in the iOS fork of WebKit.

Touch-adjustment will now use these two functions, which improves accuracy when
targeting shadow-dom elements, and also means touch adjustment will prefer enabled
form-elements over disabled ones.

Test: touchadjustment/disabled-formelements.html

dom/Node.cpp:

(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):

dom/Node.h:

(Node):

editing/DeleteButton.h:
html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::willRespondToMouseClickEvents):

html/HTMLAnchorElement.h:

(HTMLAnchorElement):

html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::willRespondToMouseClickEvents):

html/HTMLButtonElement.h:

(HTMLButtonElement):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::willRespondToMouseClickEvents):

html/HTMLInputElement.h:

(HTMLInputElement):

html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::willRespondToMouseClickEvents):

html/HTMLLabelElement.h:

(HTMLLabelElement):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::willRespondToMouseClickEvents):

html/HTMLMediaElement.h:
html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::willRespondToMouseClickEvents):

html/HTMLSummaryElement.h:

(HTMLSummaryElement):

html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::willRespondToMouseClickEvents):

html/shadow/CalendarPickerElement.h:

(CalendarPickerElement):

html/shadow/MediaControlElements.cpp:

html/shadow/MediaControlElements.h:

(MediaControlTimelineElement):
(MediaControlVolumeSliderElement):

html/shadow/MediaControlRootElement.h:
html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):

html/shadow/SliderThumbElement.h:

(SliderThumbElement):

html/shadow/TextControlInnerElements.cpp:

html/shadow/TextControlInnerElements.h:

(SearchFieldResultsButtonElement):
(SearchFieldCancelButtonElement):
(SpinButtonElement):

html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::willRespondToMouseClickEvents):

html/shadow/TextFieldDecorationElement.h:

(TextFieldDecorationElement):

page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::nodeRespondsToTapGesture):

LayoutTests:

Tests that enabled formelements are now preferred over disabled formelements.

touchadjustment/disabled-formelements-expected.txt: Added.
touchadjustment/disabled-formelements.html: Added.

6:29 AM Changeset in webkit [124021] by vsevik@chromium.org

8 edits in trunk

Web Inspector: Content size variables in NetworkResourcesData should have size_t type instead of int.
https://bugs.webkit.org/show_bug.cgi?id=92618

Reviewed by Yury Semikhatsky.

Source/WebCore:

Changed content size variables type in NetworkResourcesData from int to size_t.
Drive-by: Switched String length calculation to recently added StringImpl's sizeInBytes.

inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::removeContent):
(WebCore::NetworkResourcesData::ResourceData::dataLength):
(WebCore::NetworkResourcesData::ResourceData::appendData):
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
(WebCore::NetworkResourcesData::ensureFreeSpace):

inspector/NetworkResourcesData.h:

(ResourceData):
(NetworkResourcesData):

LayoutTests:

http/tests/inspector/network/network-content-replacement-embed-expected.txt:
http/tests/inspector/network/network-content-replacement-embed.html:
http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
http/tests/inspector/network/network-content-replacement-xhr.html:

6:21 AM Changeset in webkit [124020] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work
https://bugs.webkit.org/show_bug.cgi?id=92627

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2012-07-30
Reviewed by Noam Rosenthal.

Remove the default behavior I added in r123729 so that we run all tests as pixel
test with -p. It was intentional but it seems like we don't have consensus on
that we want it.

Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._supports_switching_pixel_tests_per_test):

6:20 AM Changeset in webkit [124019] by hayato@chromium.org

3 edits in trunk/Source/WebCore

Remove an useless member variable, m_shouldPreventDispatch, from EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=92625

Reviewed by Hajime Morita.

EventDispatcher::m_shouldPreventDispatch does not have any effects. We can remove that.

No new tests, no behavior change.

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEvent):

dom/EventDispatcher.h:

(EventDispatcher):

6:17 AM Changeset in webkit [124018] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt][WK1] Gardening after r123988. It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail
https://bugs.webkit.org/show_bug.cgi?id=92636

Patch by János Badics <János Badics> on 2012-07-30
Reviewed by Csaba Osztrogonác.

platform/qt-4.8/Skipped:
platform/qt-5.0-wk1/Skipped:

5:59 AM Changeset in webkit [124017] by yurys@chromium.org

10 edits
1 add in trunk/Source/WebCore

Web Inspector: make MemoryInstrumentation methods private
https://bugs.webkit.org/show_bug.cgi?id=92379

Reviewed by Vsevolod Vlasov.

MemoryInstrumentation was refactored.

All reporting methods on MemoryInstrumentation except add*Object are private to enforce MemoryClassInfo usage.
MemoryInstrumentation::Add*Member methods renamed to Add*Object
String reporting is implemented directly in the MemoryInstrumentation, not in its descendants.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::collectBindingMemoryInfo):

dom/MemoryInstrumentation.cpp: Added.

(WebCore):
(WebCore::MemoryInstrumentation::addString):

dom/MemoryInstrumentation.h:

(WebCore::MemoryInstrumentation::addInstrumentedObject):
(WebCore::MemoryInstrumentation::addObject):
(MemoryInstrumentation):
(InstrumentedPointerBase):
(WebCore::MemoryInstrumentation::InstrumentedPointerBase::~InstrumentedPointerBase):
(InstrumentedPointer):
(WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer):
(WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedObject):
(WebCore::MemoryInstrumentation::OwningTraits::addObject):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(WebCore::MemoryClassInfo::addInstrumentedMember):
(WebCore::MemoryClassInfo::addMember):
(WebCore):
(WebCore::MemoryInstrumentation::addObjectImpl):
(WebCore::MemoryInstrumentation::addInstrumentedCollection):
(WebCore::MemoryInstrumentation::calculateContainerSize):

inspector/InspectorMemoryAgent.cpp:

(WebCore):

5:51 AM Changeset in webkit [124016] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Styles] No color swatch for the SVG "fill" and "stroke" property values
https://bugs.webkit.org/show_bug.cgi?id=92638

Reviewed by Vsevolod Vlasov.

Added the "fill" and "stroke" properties to the list of color-aware properties.

inspector/front-end/CSSKeywordCompletions.js:

5:21 AM Changeset in webkit [124015] by vsevik@chromium.org

24 edits
4 deletes in trunk

Unreviewed, rolling out r124000.
http://trac.webkit.org/changeset/124000
https://bugs.webkit.org/show_bug.cgi?id=92632

seems to have broken chromium Range_InstanceSizeUnknown unit
test across many platforms (Requested by tomhudson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

Source/autotools/symbols.filter:

Source/WebCore:

WebCore.exp.in:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):

inspector/InspectorInstrumentation.cpp:

(WebCore):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::getResponseBody):

inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::setContent):
(WebCore::NetworkResourcesData::setResourceContent):

inspector/NetworkResourcesData.h:

(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):
(WebCore):

loader/cache/CachedResource.h:

(CachedResource):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::clearPreloads):

loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::evict):

testing/InternalSettings.cpp:
testing/Internals.cpp:
testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Removed.
http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Removed.
http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Removed.
http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Removed.

4:38 AM Changeset in webkit [124014] by hayato@chromium.org

2 edits in trunk/Source/WebCore

Remove an unused member variable, m_originalTarget, from EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=92614

Reviewed by Andreas Kling.

No one uses EventDispatcher::m_originalTarget.

No new tests, no behavior change.

dom/EventDispatcher.h:

(EventDispatcher):

4:33 AM Changeset in webkit [124013] by jocelyn.turcotte@nokia.com

11 edits in trunk/Source/WebKit2

[Qt] Remove accurateVisibleContentsPosition and use a FloatRect for visibleContentsRect instead
https://bugs.webkit.org/show_bug.cgi?id=92536

Reviewed by Noam Rosenthal.

AccurateVisibleContentsPosition carries the same information as visibleContentsRect.location() and
is needed for fixed layer position updates.
This patch instead uses a FloatRect for the visible contents rect from the web view down to the
LayerCoordinatorProxy, and converts it to an IntRect at this moment, before sending it to the
web process.
This also moves the check to prevent sending the same rect to the moment of the conversion
in LayerTreeCoordinatorProxy to fix a bug where the fixed layer deltas wouldn't be updated
unless the integer part of position components changed.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):

UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::setVisibleContentsRect):

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):

UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

UIProcess/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::LayerTreeCoordinatorProxy):
(WebKit::LayerTreeCoordinatorProxy::setVisibleContentsRect):

UIProcess/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::setVisibleContentsRect):
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):

UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

UIProcess/qt/QtViewportHandler.cpp:

(WebKit::QtViewportHandler::visibleContentsRect):
(WebKit::QtViewportHandler::informVisibleContentChange):

UIProcess/qt/QtViewportHandler.h:

(QtViewportHandler):

4:31 AM Changeset in webkit [124012] by jocelyn.turcotte@nokia.com

5 edits in trunk/Source

[Qt] Fix issues remaining with fixed positioned layers
https://bugs.webkit.org/show_bug.cgi?id=92528

Reviewed by Noam Rosenthal.

Source/WebCore:

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::syncCompositingStateSelf):
Make sure that the delta is used when syncCompositingStateSelf is called afterward.
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):

platform/graphics/texmap/TextureMapperLayer.h:

Use a FloatSize instead of an IntPoint for the delta.
(TextureMapperLayer):
(WebCore::TextureMapperLayer::adjustedPosition):

Source/WebKit2:

This partially fixes jittering of fixed layers when zoomed in and the
blurriness of rendered tiles of the non-composited contents layer.

UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::boundedScrollPosition):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
Remove the adjustment on the root layer. This cancels setPixelAligned and causes the blurriness.
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
Use m_accurateVisibleContentsPosition to calculate the delta.
(WebKit::WebLayerTreeRenderer::didChangeScrollPosition):

3:33 AM Changeset in webkit [124011] by Kaustubh Atrawalkar

4 edits in trunk/Source/WebKit/chromium

[DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Hajime Morita.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

public/WebFrame.h:

(WebFrame):

src/WebFrameImpl.cpp:

(WebKit):

src/WebFrameImpl.h:

(WebFrameImpl):

3:25 AM Changeset in webkit [124010] by Patrick Gansterer

13 edits
3 adds
2 deletes in trunk

Replace UnicodeWinCE with UnicodeWchar https://bugs.webkit.org/show_bug.cgi?id=92539

Reviewed by Ryosuke Niwa.

UnicodeWinCE never contained WinCE specific code. UnicodeWchar
is a replacement for it, which is mainly based on the functions
from <wchar.h>. It is ment as a minimal Unicode backend, which
can be used very easy and has no external dependencies.

Source/cmake/OptionsWinCE.cmake:

Source/WebCore:

platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode):

platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps):

Source/WebKit/blackberry:

WebCoreSupport/AboutDataUseFeatures.in:

Source/WTF:

WTF.gyp/WTF.gyp:
WTF.gypi:
wtf/Platform.h:
wtf/PlatformWinCE.cmake:
wtf/unicode/Unicode.h:
wtf/unicode/wchar/UnicodeWchar.cpp: Added.

(Unicode):
(WTF::Unicode::category):
(WTF::Unicode::combiningClass):
(WTF::Unicode::direction):
(WTF::Unicode::decompositionType):
(WTF::Unicode::hasLineBreakingPropertyComplexContext):
(WTF::Unicode::mirroredChar):
(WTF::Unicode::convertWithFunction):
(WTF::Unicode::foldCase):
(WTF::Unicode::toLower):
(WTF::Unicode::toUpper):

wtf/unicode/wchar/UnicodeWchar.h: Added.

(Unicode):
(WTF::Unicode::isAlphanumeric):
(WTF::Unicode::isDigit):
(WTF::Unicode::isLetter):
(WTF::Unicode::isLower):
(WTF::Unicode::isPrintableChar):
(WTF::Unicode::isPunct):
(WTF::Unicode::isSpace):
(WTF::Unicode::isUpper):
(WTF::Unicode::isArabicChar):
(WTF::Unicode::isSeparatorSpace):
(WTF::Unicode::foldCase):
(WTF::Unicode::toLower):
(WTF::Unicode::toUpper):
(WTF::Unicode::toTitleCase):
(WTF::Unicode::umemcasecmp):

wtf/unicode/wince/UnicodeWinCE.cpp: Removed.
wtf/unicode/wince/UnicodeWinCE.h: Removed.

2:45 AM Changeset in webkit [124009] by hayato@chromium.org

2 edits in trunk/Source/WebCore

Remove unnecessary code which set event's target from EventDispatcher::dispatchEvent.
https://bugs.webkit.org/show_bug.cgi?id=92613

Reviewed by Hajime Morita.

EventContext::handleLocalEvents does all required jobs so we don't
need to set target in EventDispacher::dispatchEvent() for TARGET phase.

No new tests, no behavior change.

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

2:29 AM Changeset in webkit [124008] by commit-queue@webkit.org

11 edits
3 copies
1 move
4 deletes in trunk

Unreviewed, rolling out r124004.
http://trac.webkit.org/changeset/124004
https://bugs.webkit.org/show_bug.cgi?id=92622

Broke Android build (Requested by keishi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

Source/Platform:

chromium/public/WebLocalizedString.h:

Source/WebCore:

rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsDataListUI):

Source/WebKit/chromium:

WebKit.gyp:
src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::createColorChooser):

src/ChromeClientImpl.h:

(WebCore):
(ChromeClientImpl):

src/ColorChooserProxy.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.

(WebKit):
(WebKit::ColorChooserProxy::ColorChooserProxy):
(WebKit::ColorChooserProxy::~ColorChooserProxy):
(WebKit::ColorChooserProxy::setSelectedColor):
(WebKit::ColorChooserProxy::endChooser):

src/ColorChooserProxy.h: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.

(WebKit):
(ColorChooserProxy):

src/ColorChooserUIController.cpp: Removed.
src/WebColorChooserClientImpl.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.

src/WebColorChooserClientImpl.h: Renamed from Source/WebKit/chromium/src/ColorChooserUIController.h.

(WebCore):
(WebKit):
(WebColorChooserClientImpl):

LayoutTests:

platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
platform/chromium/TestExpectations:
platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Removed.
platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Removed.
platform/chromium/fast/forms/datalist/input-list-expected.txt:

2:25 AM Changeset in webkit [124007] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: element tag disappears after editing
https://bugs.webkit.org/show_bug.cgi?id=92385

Reviewed by Vsevolod Vlasov.

This has regressed when we started hiding elements panel upon
batch updates. Narrowing hiding cases, updating selection
in on-screen mode only.

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.updateSelection):

2:05 AM Changeset in webkit [124006] by yurys@chromium.org

5 edits in trunk/Source

Web Inspector: move StringImpl size calculation to StringImpl
https://bugs.webkit.org/show_bug.cgi?id=92359

Reviewed by Pavel Feldman.

Moved stringSize(StringImpl*) implementation from InspectorMemoryAgent to
StringImpl::sizeInBytes();

Source/WebCore:

inspector/InspectorMemoryAgent.cpp:

(WebCore):

Source/WTF:

wtf/text/StringImpl.cpp:

(WTF::StringImpl::sizeInBytes):
(WTF):

wtf/text/StringImpl.h:

(StringImpl):

1:57 AM Changeset in webkit [124005] by pfeldman@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: workers inspector is broken in the remote debugging mode
https://bugs.webkit.org/show_bug.cgi?id=92540

Reviewed by Yury Semikhatsky.

The problem was that worker manager re-used complete url with query parameters
for spin-off worker front-ends. As a result, in case of remote debugging, newly
created front-ends were connecting to the same web socket (because of the ws parameter).

inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.isDedicatedWorkerFrontend):

inspector/front-end/inspector.js:

1:33 AM Changeset in webkit [124004] by keishi@webkit.org

11 edits
1 move
7 adds
3 deletes in trunk

Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075

Reviewed by Kent Tamura.

Source/Platform:

chromium/public/WebLocalizedString.h: Added OtherColorLabel.

Source/WebCore:

Test: platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html

rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Added color to types supporting datalist.

Source/WebKit/chromium:

WebKit.gyp:
src/ChromeClientImpl.cpp:

src/ChromeClientImpl.h:

(WebKit):
(ChromeClientImpl):

src/ColorChooserProxy.cpp: Removed.
src/ColorChooserProxy.h: Removed.
src/ColorChooserUIController.cpp: Added.

src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h.

(WebCore):
(WebKit):
(ColorChooserUIController):

src/WebColorChooserClientImpl.cpp: Removed.

LayoutTests:

platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
platform/chromium/TestExpectations:
platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Added.
platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Added. Tests color suggestion picker popup appearance.
platform/chromium/fast/forms/datalist/input-list-expected.txt:

1:28 AM Changeset in webkit [124003] by mario@webkit.org

4 edits in trunk

REGRESSION (r123767): platform/gtk/accessibility/object-with-title.html failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=92477

Reviewed by Chris Fleizach.

Source/WebCore:

Consider title and accessibilityDescription together with helpText to
decide whether an object should be exposed in the accessibility tree.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests:

Remove passing test from TestExpectations.

platform/gtk/TestExpectations:

1:18 AM Changeset in webkit [124002] by Simon Hausmann

2 edits in trunk/Source/WebKit

Unreviewed Qt/Mac build fix: Use libWebKitSystemInterfaceMountainLion.a
on Mountain Lion.

WebKit1.pri:

12:58 AM Changeset in webkit [124001] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.
https://bugs.webkit.org/show_bug.cgi?id=92366

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-30
Reviewed by Antonio Gomes.

Add SHIFT modifier for capital letters as VK_
codes do not distinguish between lows and caps and also to be consistent
with other ports which send caps as lowercase letters with the shift key down.

WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::EventSenderProxy::keyDown):

12:54 AM Changeset in webkit [124000] by vsevik@chromium.org

24 edits
4 adds in trunk

Web Inspector: Resource agent's reference to cached resources should be weak.
https://bugs.webkit.org/show_bug.cgi?id=92108

Reviewed by Pavel Feldman.

Source/autotools/symbols.filter:

Source/WebCore:

Tests: http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html

http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html

WebCore.exp.in:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):

inspector/InspectorInstrumentation.cpp:

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDestroyCachedResource):
(WebCore):

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::willDestroyCachedResource):
(WebCore):
(WebCore::InspectorResourceAgent::getResponseBody):

inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

inspector/NetworkResourcesData.cpp:

inspector/NetworkResourcesData.h:

(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::base64Encoded):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):
(WebCore):

loader/cache/CachedResource.h:

(CachedResource):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::clearPreloads):

loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::evict):

testing/InternalSettings.cpp:
testing/Internals.cpp:

(WebCore::Internals::garbageCollectDocumentResources):
(WebCore):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Added.
http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Added.
http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Added.
http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Added.

12:29 AM WebKitIDL edited by haraken@chromium.org

(diff)

12:10 AM WebKitIDL edited by Vineet

Support for [Clamp] extended attribute. (diff)

Jul 29, 2012:

11:25 PM Changeset in webkit [123999] by commit-queue@webkit.org

11 edits in trunk/Source/WebCore

[WK2][EFL] Accelerated compositing support using TextureMapper on Efl WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91583

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-29
Reviewed by Noam Rosenthal.

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
This patch adds Texture Mapper related files to PlatformEfl.cmake.
And wrapped TextureMapperLayer and TextureMapperBackingStore with USE(ACCELERATED_COMPOSITING) for fixing building error when disable ACCELERATED_COMPOSITING.

CMakeLists.txt:
PlatformEfl.cmake:
platform/graphics/GraphicsLayer.cpp:

(WebCore):

platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

platform/graphics/GraphicsLayerAnimation.cpp:
platform/graphics/GraphicsLayerAnimation.h:
platform/graphics/PlatformLayer.h:

(WebCore):

platform/graphics/texmap/TextureMapperBackingStore.cpp:
platform/graphics/texmap/TextureMapperBackingStore.h:
platform/graphics/texmap/TextureMapperLayer.h:

11:09 PM Changeset in webkit [123998] by commit-queue@webkit.org

10 edits in trunk/Source

[WK2][EFL] TILED_BACKING_STORE support on Efl WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91582

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-29
Reviewed by Noam Rosenthal.

Source/WebCore:

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
This patch adds TILED_BACKING_STORE related files to CMakeLists.txt and PlatformEfl.cmake

CMakeLists.txt:
PlatformEfl.cmake:

Source/WebKit/efl:

Add a dummy function for fixing building error when enabling TILED_BACKING_STORE.

WebCoreSupport/ChromeClientEfl.cpp:

(WebCore):
(WebCore::ChromeClientEfl::delegatedScrollRequested):

WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit2:

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
Add a dummy function for fixing building error when enabling TILED_BACKING_STORE.

UIProcess/API/efl/PageClientImpl.cpp:

(WebKit):
(WebKit::PageClientImpl::pageDidRequestScroll):

UIProcess/API/efl/PageClientImpl.h:

(PageClientImpl):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

10:49 PM Changeset in webkit [123997] by keishi@webkit.org

3 edits in trunk/Source/WebCore

Fix removing invalid values from color input suggestions
https://bugs.webkit.org/show_bug.cgi?id=92502

Reviewed by Kent Tamura.

Make ColorInputType::typeMismatchFor() return false for invalid color
values so that they don't appear in the list of suggestions that
ColorInputType::suggestions() returns.

No new tests. Tests to be added in Bug 92075.

html/ColorInputType.cpp:

(WebCore::ColorInputType::typeMismatchFor):
(WebCore):

html/ColorInputType.h:

(ColorInputType):

10:28 PM Changeset in webkit [123996] by commit-queue@webkit.org

5 edits
2 adds in trunk

getChannelData should raise exception when index is more than numberOfChannels.
https://bugs.webkit.org/show_bug.cgi?id=92223

Patch by Li Yin <li.yin@intel.com> on 2012-07-29
Reviewed by Kentaro Hara.

Source/WebCore:

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioBuffer-section
In getChannelData function, the index value MUST be less than numberOfChannels
or an exception will be thrown.

Test: webaudio/audiobuffer.html

Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::getChannelData):
(WebCore):

Modules/webaudio/AudioBuffer.h:

(WebCore):
(AudioBuffer):

Modules/webaudio/AudioBuffer.idl: raise exception when index is not less than numberOfChannels.

LayoutTests:

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioBuffer-section
Add test to cover basic attributes of AudioBuffer.

webaudio/audiobuffer-expected.txt: Added.
webaudio/audiobuffer.html: Added.

10:22 PM Changeset in webkit [123995] by commit-queue@webkit.org

3 edits
2 adds in trunk

forward-delete in the last cell of a table moves the caret after the table
https://bugs.webkit.org/show_bug.cgi?id=24250

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-07-29
Reviewed by Ryosuke Niwa.

Source/WebCore:

The ForwardDelete command moved the cursor after the table when it's invoked
in an empty cell that is the last cell of a table. It also removed the break
element when invoked in an empty cell that is not the last cell of a table.
Make it do nothing inside an empty table cell.

Test: editing/deleting/forward-delete-empty-table-cell.html

editing/TypingCommand.cpp:

(WebCore::TypingCommand::forwardDeleteKeyPressed):

LayoutTests:

editing/deleting/forward-delete-empty-table-cell-expected.txt: Added.
editing/deleting/forward-delete-empty-table-cell.html: Added.

10:17 PM Changeset in webkit [123994] by tkent@chromium.org

3 edits in trunk/LayoutTests

REGRESSION(r123993): fast/forms/date/calendar-picker-type-change-onclick.html fails

fast/forms/date/calendar-picker-appearance-expected.txt:
fast/forms/date/calendar-picker-appearance.html:

Clear webkitTransitionEnd event handler before notifyDone().

9:19 PM Changeset in webkit [123993] by tkent@chromium.org

2 edits in trunk/LayoutTests

Fix opacity issue of fast/forms/date/calendar-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=92605

Reviewed by Hajime Morita.

We need to wait for pixel dumping until CSS transition completion for
the 'main' element, which has transition from opacity:0 to opacity:1.

fast/forms/date/calendar-picker-appearance.html:

6:58 PM Changeset in webkit [123992] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove unused method HTMLConstructionSiteTask::take(HTMLConstructionSiteTask&)
https://bugs.webkit.org/show_bug.cgi?id=92601

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-29
Reviewed by Adam Barth.

This method was introduced in r104000, but has never been used from the beginning.

No functional change.

html/parser/HTMLConstructionSite.h:

6:46 PM Changeset in webkit [123991] by bashi@chromium.org

5 edits in trunk/Source/WebCore

[Chromium] HarfBuzzShaper can't handle segmented text run
https://bugs.webkit.org/show_bug.cgi?id=92445

Reviewed by Tony Chang.

Pass the range to be displayed to HarfBuzzShaper. The shaper calculates positions and advances of each glyph
regardless of the range, but only add glyphs which are in the range.

No new tests. platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html should
work as expected once we move to use harfbuzz-ng on linux. Note that the current expectation will need to be rebaselined
because the old hb shaper (ComplexTextController) mishandles the range. |to| should be exclusive. I'll rebaseline
the expectation later.

platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::drawComplexText): Call shaper.setDrawRange().

platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setDrawRange): Added.
(WebCore):
(WebCore::HarfBuzzShaper::shouldDrawCharacterAt): Added.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Added variables that hold pending advances.
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun): Add only glyphs which are in the given range to glyphBuffer.

platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:

(HarfBuzzShaper):

platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::drawComplexText): Call shaper.setDrawRange().

6:17 PM UsingGitHub edited by morrita@google.com

(diff)

6:13 PM FeatureFlags edited by tkent@chromium.org

Add CSS_COMPOSITING (diff)

5:44 PM Changeset in webkit [123990] by mitz@apple.com

5 edits
2 adds in trunk

Hit testing in the gap between pages returns incorrect results in flipped blocks writing modes
https://bugs.webkit.org/show_bug.cgi?id=92600

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/multicol/hit-test-gap-between-pages-flipped.html

rendering/RenderBlock.h:

(WebCore::RenderBlock): Promoted offsetForContents() from private to protected, and demoted
adjustPointToColumnContents() back to private.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest): Changed to flip the point passed to updateHitTestResults().

rendering/RenderView.cpp:

(WebCore::RenderView::updateHitTestResult): Changed to call offsetForContents(), which, as
of r123977, correctly accounts for flippedness.

LayoutTests:

fast/multicol/hit-test-gap-between-pages-flipped-expected.txt: Added.
fast/multicol/hit-test-gap-between-pages-flipped.html: Added.

4:15 PM Changeset in webkit [123989] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

PropertyNameArray::m_shouldCache is only assigned and never used
https://bugs.webkit.org/show_bug.cgi?id=92598

Reviewed by Dan Bernstein.

runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::PropertyNameArray):
(PropertyNameArray):

3:55 PM Changeset in webkit [123988] by mitz@apple.com

9 edits in trunk

In flipped blocks, a point on the top edge of a text box is considered outside the box (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=92597

Reviewed by Ryosuke Niwa.

Source/WebCore:

This is similar to <http://webkit.org/b/92593> except for RenderText. Fixing this required
fixing some code that creates a point inside a box by setting its y coordinate to the
logical top of the box. In a flipped block, this would be just outside the box.

Enhanced fast/writing-mode/flipped-blocks-hit-test-line-edges.html to cover this.

editing/visible_units.cpp:

(WebCore::absoluteLineDirectionPointToLocalPointInBlock): Changed to use
RootInlineBox::blockDirectionPointInLine in the vertical case as well.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPointWithInlineChildren): Changed to use
RootInlineBox::blockDirectionPointInLine.

rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint): Changed the strictness of y inequalities based on
the flippedness of the block. This fixes the bug.

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::blockDirectionPointInLine): Moved the implementation here from the
header, and made it return the bottom in the flipped block case, so that the returned point
is inside the line in that case as well.

rendering/RootInlineBox.h:

LayoutTests:

Added hits inside the text to this test.

fast/writing-mode/flipped-blocks-hit-test-line-edges-expected.txt:
fast/writing-mode/flipped-blocks-hit-test-line-edges.html:

3:36 PM Changeset in webkit [123987] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] pass acceleratePainting info to settings
https://bugs.webkit.org/show_bug.cgi?id=92467

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-07-29
Reviewed by Eric Seidel.

The acceleratePainting info is not passed into settings correctly so
that GPU composition would not use the code path of accelerated painting.

src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):

3:26 PM Changeset in webkit [123986] by rakuco@webkit.org

2 edits in trunk/Tools

[EFL][jhbuild] Make run-with-jhbuild become the jhbuild process itself.
https://bugs.webkit.org/show_bug.cgi?id=92592

Reviewed by Eric Seidel.

Adapt to the changes made to GTK+'s run-with-jhbuild in r123979
and make EFL's run-with-jhbuild call os.execve() instead of
launching a subprocess as well.

This should make it possible to interrupt execution of jhbuild
cleanly.

efl/run-with-jhbuild:

3:03 PM Changeset in webkit [123985] by rniwa@webkit.org

4 edits
1 add in trunk

run-perf-tests should generate a results page
https://bugs.webkit.org/show_bug.cgi?id=92575

Reviewed by Eric Seidel.

PerformanceTests:

Add a results page template. This page includes flot and flot.fillbetween.
jQuery and the json that contains test results are injected by run-perf-tests.

resources/results-template.html: Added.

Tools:

Added the ability to generate a results page that summarizes performance test results from
multiple runs of run-perf-tests when --output-json-path is specified and --test-results-server
is not specified. We cannot generate a results page when --test-results-server is specified
because perf-o-matic cannot parse the new JSON format.

The new JSON format is simply an array of the old JSON output. This JSON is then merged into
results-template.html along with jQuery and copied as a HTML file of the same filename as
the output JSON file with a .html extension.

We merge all scripts and the JSON output into the results page as opposed to including them
with the src content attribute to make it standalone so that we may post it on Bugzilla or
e-mail it to someone else without breaking it.

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.run):
(PerfTestsRunner._generate_json): Merge "contents" with the existing JSON file when generating
a results page, and generate the results page from results-template.html merged with jQuery and
the generated JSON output.

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(_test_run_with_json_output): Extracted from test_run_with_upload_json to be shared with
several test cases.
(_test_run_with_json_output.mock_upload_json): Ditto.
(test_run_with_json_output): Refactored to use _test_run_with_json_output.
(test_run_generates_results_page): Added. Tests the new feature.
(test_run_with_json_source): Refactored to use _test_run_with_json_output.
(test_run_with_multiple_repositories): Ditto.
(test_run_with_upload_json): Ditto.

2:59 PM Changeset in webkit [123984] by commit-queue@webkit.org

18 edits in trunk

.: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553