Timeline
Aug 13, 2012:
- 11:49 PM Changeset in webkit [125510] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed GTK gardening.
Adding an empty platform baseline for r125462 just to avoid exceptions
in the layout-test step on the buildbots. The baseline will be updated
accordingly later.
- platform/gtk/svg/filters/color-interpolation-filters-expected.txt: Added.
- 10:39 PM WebKitIDL edited by
- (diff)
- 10:35 PM Changeset in webkit [125509] by
-
- 1 edit1 add in trunk/LayoutTests
[EFL] Unreviewed gardening, rebaselining after r125462.
Add a new test result to avoid layout-test exception
- platform/efl/svg/filters/color-interpolation-filters-expected.txt: Added.
- 9:58 PM Changeset in webkit [125508] by
-
- 39 edits12 moves in trunk/Tools
Rename files that declare and define LayoutTestController in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=93899
Reviewed by Tony Chang.
Renamed files and fixed style errors.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/LayoutTestController.cpp: Removed.
- DumpRenderTree/LayoutTestController.h: Removed.
- DumpRenderTree/PixelDumpSupport.cpp:
- DumpRenderTree/StorageTrackerDelegate.mm:
- DumpRenderTree/TestRunner.cpp: Copied from Tools/DumpRenderTree/LayoutTestController.cpp.
- DumpRenderTree/TestRunner.h: Copied from Tools/DumpRenderTree/LayoutTestController.h.
(LayoutTestController):
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Removed.
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Copied from Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp.
- DumpRenderTree/chromium/DRTTestRunner.cpp: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.cpp.
- DumpRenderTree/chromium/DRTTestRunner.h: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.h.
- DumpRenderTree/chromium/LayoutTestController.cpp: Removed.
- DumpRenderTree/chromium/LayoutTestController.h: Removed.
- DumpRenderTree/chromium/TestShell.cpp:
- DumpRenderTree/chromium/TestShell.h:
- DumpRenderTree/chromium/WebPermissions.cpp:
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/efl/CMakeLists.txt:
- DumpRenderTree/efl/DumpRenderTree.cpp:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
- DumpRenderTree/efl/EditingCallbacks.cpp:
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Removed.
- DumpRenderTree/efl/TestRunnerEfl.cpp: Copied from Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
- DumpRenderTree/gtk/EditingCallbacks.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed.
- DumpRenderTree/gtk/TestRunnerGtk.cpp: Copied from Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp.
- DumpRenderTree/mac/DumpRenderTree.mm:
- DumpRenderTree/mac/DumpRenderTreeWindow.mm:
- DumpRenderTree/mac/EditingDelegate.mm:
- DumpRenderTree/mac/FrameLoadDelegate.mm:
- DumpRenderTree/mac/HistoryDelegate.mm:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed.
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
- DumpRenderTree/mac/PolicyDelegate.mm:
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
- DumpRenderTree/mac/TestRunnerMac.mm: Copied from Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm.
- DumpRenderTree/mac/UIDelegate.mm:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: Removed.
- DumpRenderTree/qt/LayoutTestControllerQt.h: Removed.
- DumpRenderTree/qt/TestRunnerQt.cpp: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp.
- DumpRenderTree/qt/TestRunnerQt.h: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.h.
(WebCore):
(LayoutTestController):
(LayoutTestController::setCloseRemainingWindowsWhenComplete):
(LayoutTestController::dumpSelectionRect):
(LayoutTestController::setCallCloseOnWebViews):
(LayoutTestController::addDisallowedURL):
(LayoutTestController::abortModal):
- DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
- DumpRenderTree/win/DumpRenderTree.cpp:
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/EditingDelegate.cpp:
- DumpRenderTree/win/FrameLoadDelegate.cpp:
- DumpRenderTree/win/HistoryDelegate.cpp:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed.
- DumpRenderTree/win/PolicyDelegate.cpp:
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
- DumpRenderTree/win/TestRunnerWin.cpp: Copied from Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp.
(LayoutTestController::setUserStyleSheetEnabled):
(resolveCygwinPath):
- DumpRenderTree/win/UIDelegate.cpp:
- DumpRenderTree/wscript:
- DumpRenderTree/wx/DumpRenderTreeWx.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: Removed.
- DumpRenderTree/wx/TestRunnerWx.cpp: Copied from Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp.
- 9:29 PM Changeset in webkit [125507] by
-
- 3 edits in trunk/Source/WebCore
Remove fade in transition from calendar picker
https://bugs.webkit.org/show_bug.cgi?id=93816
Reviewed by Kent Tamura.
The fade in transition was incomplete because it was only fading in the
popup content and not the popup itself. Removing the effect for now.
No new tests. Can't test animation.
- Resources/calendarPicker.css:
(#main):
- Resources/calendarPicker.js:
(initialize):
(fixWindowSize):
- 8:32 PM Changeset in webkit [125506] by
-
- 6 edits in trunk/Source/WebCore
WPARAM and LPARAM are incorrectly defined for x64
https://bugs.webkit.org/show_bug.cgi?id=89902
Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-08-13
Reviewed by Brent Fulgham.
Include WindowsExtras.h for PLATFORM(WIN) to define WPARAM and LPARAM correctly
- platform/PlatformKeyboardEvent.h:
- platform/PlatformMouseEvent.h:
- platform/PlatformWheelEvent.h:
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
- platform/win/WindowMessageListener.h:
- 8:20 PM Changeset in webkit [125505] by
-
- 3 edits in trunk/Tools
Windows 64 bit compliance
https://bugs.webkit.org/show_bug.cgi?id=93275
Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-08-13
Reviewed by Brent Fulgham.
Fixed a few compile and link problems for Win64
- WinLauncher/WinLauncher.cpp:
- win/DLLLauncher/DLLLauncherMain.cpp:
- 7:53 PM Changeset in webkit [125504] by
-
- 4 edits in trunk/Source/WebCore
[Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler
https://bugs.webkit.org/show_bug.cgi?id=93918
Patch by John Bates <jbates@google.com> on 2012-08-13
Reviewed by James Robinson.
Also, update some trace events.
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
(WebCore::CCDelayBasedTimeSource::setActive):
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::setActive):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::onVSyncParametersChanged):
- 7:52 PM Changeset in webkit [125503] by
-
- 3 edits2 adds in trunk
Crash in WebCore::RenderBlock::LineBreaker::nextLineBreak
https://bugs.webkit.org/show_bug.cgi?id=93806
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-08-13
Reviewed by Abhishek Arya.
Source/WebCore:
When looking for line breaks on the first line, existing code was
checking for text-combine only in the first-line style. Since
text-combine isn't inherited this resulted in a line break being
chosen before combineText was called. When this happened and then
combineText was called subsequently, the position of the line break
iterator would be invalid.
This patch changes the check to use the regular style as in
skipLeadingWhitespace and textWidth.
Test: fast/text/text-combine-first-line-crash.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Don't use the
first-line style when checking text-combine.
LayoutTests:
- fast/text/text-combine-first-line-crash-expected.txt: Added.
- fast/text/text-combine-first-line-crash.html: Added.
- 7:49 PM EFLWebKitCodingStyle edited by
- (diff)
- 7:49 PM Changeset in webkit [125502] by
-
- 1 edit1 move1 add in trunk/LayoutTests
[Chromium] Unreviewed. Rebaseline test results for add-table-overpaint.html.
- platform/chromium-mac/fast/repaint/add-table-overpaint-expected.png: Added.
- platform/chromium-win/fast/repaint/add-table-overpaint-expected.png: Renamed from LayoutTests/platform/chromium/fast/repaint/add-table-overpaint-expected.png.
- 7:44 PM EFLWebKitCodingStyle edited by
-
Add #!cpp in
...(diff) - 7:43 PM Changeset in webkit [125501] by
-
- 3 edits in trunk/Source/WebCore
Remove unused method HTMLDocumentParser::script()
https://bugs.webkit.org/show_bug.cgi?id=93916
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-13
Reviewed by Eric Seidel.
The use of HTMLDocumentParser::script() was removed in r61640 and has never been used since then.
No behavior change, so no new tests.
- html/parser/HTMLDocumentParser.cpp:
- html/parser/HTMLDocumentParser.h:
- 7:37 PM Changeset in webkit [125500] by
-
- 20 edits in trunk/Source
[chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
https://bugs.webkit.org/show_bug.cgi?id=93283
Reviewed by Eric Seidel.
Source/WebCore:
Chromium has a refptr that needs to be NULLed at this point.
The approach is to change the client redirectDataToPlugin method(s) to expect
the possibility of a NULL argument, and the use this to clear the refptr on
the chromium platform. Other platforms can merely ignore the NULL case, thereby
maintaining the existing behaviour.
Formal testing is nearly impossible without some chrome-specific plugins.
- html/PluginDocument.cpp:
(WebCore::PluginDocument::detach):
Source/WebKit/blackberry:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):
Source/WebKit/chromium:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, NULLing Chromium's refptr that needs to be NULLed.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::redirectDataToPlugin):
Source/WebKit/efl:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::redirectDataToPlugin):
Source/WebKit/gtk:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::redirectDataToPlugin):
Source/WebKit/qt:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::redirectDataToPlugin):
Source/WebKit/win:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::redirectDataToPlugin):
Source/WebKit/wince:
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::redirectDataToPlugin):
Source/WebKit/wx:
Chromium has a refptr that needs to be NULLed at this point.
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::redirectDataToPlugin):
Source/WebKit2:
Chromium has a refptr that needs to be NULLed at this point.
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::redirectDataToPlugin):
- 7:31 PM EFLWebKitCodingStyle edited by
- Add a better explanation about the usage of !!s (diff)
- 7:17 PM Changeset in webkit [125499] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, update test expectations to reflect the recent results and
remove lint errors.
- platform/chromium/TestExpectations:
- 7:14 PM Changeset in webkit [125498] by
-
- 6 edits in trunk/Source
[chromium] Paint animated layers immediately to avoid animation hiccups.
https://bugs.webkit.org/show_bug.cgi?id=93028
Patch by Eric Penner <epenner@google.com> on 2012-08-13
Reviewed by Adrienne Walker.
Source/WebCore:
This is a technique used on Android, which is very prone
to hiccups in animations. Paint the entire layer if it is
of reasonable size such that there is no hiccups when the
animation reaches unpainted content. The reasonable size
is choosen for page-transitions specifically, as this was
the problem case (animations would just jump to the end).
Since we already have a special case this just modifies it
and replaces the unit test with a new one. This can be
improved/simplified further when distances/directions are
available for the animated layers.
Replaced one test.
Fixed bugs in and improved idlePaintNonVisibleLayers test.
- platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::UpdatableTile::resetUpdateState):
(WebCore::UpdatableTile::markForUpdate):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::markOcclusionsAndRequestTextures):
(WebCore::TiledLayerChromium::haveTexturesForTiles):
(WebCore::TiledLayerChromium::markTilesForUpdate):
(WebCore::TiledLayerChromium::updateTileTextures):
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateContentRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
- platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::contentRectToTileIndices):
- platform/graphics/chromium/cc/CCPriorityCalculator.h:
(WebCore::CCPriorityCalculator::maxPriority):
Source/WebKit/chromium:
Replaced one test. Test painting full animated layer.
- tests/TiledLayerChromiumTest.cpp:
- 7:10 PM Changeset in webkit [125497] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Simple refactoring that I forgot to apply in r125495.
- bindings/v8/V8ThrowException.cpp:
(WebCore::domExceptionStackGetter):
(WebCore::domExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):
- bindings/v8/V8ThrowException.h:
- 7:09 PM Changeset in webkit [125496] by
-
- 2 edits in trunk/Source/WebCore
[CMAKE][EFL] Fix build break with --tiled-backing-store
https://bugs.webkit.org/show_bug.cgi?id=93487
Unreviewed build fix for Efl with --tiled-backing-store.
- CMakeLists.txt:
Checked bison version and selected proper glslang files.
- 7:04 PM Changeset in webkit [125495] by
-
- 71 edits1 copy1 add in trunk/Source/WebCore
[V8] Factor out exception related methods of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93792
Reviewed by Adam Barth.
To remove V8Proxy, this patch factors out exception related methods of V8Proxy
to a separate file.
(1) Move exception related methods from V8Proxy.{h,cpp} to V8ThrowException.{h,cpp}.
(2) To avoid writing V8ThrowException::throwError() here and there in V8 binding,
implement WebCore::throwError() in V8Binding.{h,cpp}. Ideally, we want to list up
all V8 binding APIs in V8Binding.h.
(3) Replace all V8Proxy::throwError() with throwError().
Nit: I couldn't write the definition of WebCore::throwError() in V8BInding.h
due to circular dependency issues. Either way, these methods wouldn't be
performance-critical.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateArgumentsCountCheck):
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateFunctionCallString):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooCallback):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::MethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::serializedValueCallback):
(WebCore::TestObjV8Internal::idbKeyCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod5Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert3Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::constructorCallback):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
- bindings/v8/DateExtension.cpp:
(WebCore::DateExtension::OnSleepDetected):
- bindings/v8/NPV8Object.cpp:
(_NPN_SetException):
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::SerializedScriptValue):
- bindings/v8/V8Binding.cpp:
(WebCore::setDOMException):
(WebCore):
(WebCore::throwError):
(WebCore::throwTypeError):
(WebCore::throwNotEnoughArgumentsError):
- bindings/v8/V8Binding.h:
(WebCore):
(WebCore::toV8Sequence):
- bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
- bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectPropertyEnumerator):
- bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
- bindings/v8/V8Proxy.cpp:
(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::V8Proxy::checkNewLegal):
- bindings/v8/V8Proxy.h:
(V8Proxy):
(WebCore):
- bindings/v8/V8ThrowException.cpp: Added.
(WebCore):
(WebCore::DOMExceptionStackGetter):
(WebCore::DOMExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):
(WebCore::V8ThrowException::throwError):
(WebCore::V8ThrowException::throwTypeError):
(WebCore::V8ThrowException::throwNotEnoughArgumentsError):
- bindings/v8/V8ThrowException.h: Added.
(WebCore):
(V8ThrowException):
- bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
(WebCore::getMessagePortArray):
(WebCore::setTypeMismatchException):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
- bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback):
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
- bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):
- bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertySetter):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):
- bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallback):
(WebCore::V8DOMFormData::appendCallback):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertySetter):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallback):
(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8DirectoryEntryCustom.cpp:
(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):
- bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
(WebCore::V8DirectoryEntrySync::getDirectoryCallback):
(WebCore::V8DirectoryEntrySync::getFileCallback):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::toDataURLCallback):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::V8HTMLElement::itemValueAccessorSetter):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionStartAccessorGetter):
(WebCore::V8HTMLInputElement::selectionStartAccessorSetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorGetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorSetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter):
(WebCore::V8HTMLInputElement::setSelectionRangeCallback):
- bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAccessorSetter):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addCallback):
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectedObjectCallback):
- bindings/v8/custom/V8IntentConstructor.cpp:
(WebCore::V8Intent::constructorCallback):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::protocolAccessorSetter):
- bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback):
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallback):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
- bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::valueAccessorGetter):
(WebCore::V8SVGLength::valueAccessorSetter):
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
- bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageSetter):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
- bindings/v8/custom/V8WebKitPointConstructor.cpp:
(WebCore::V8WebKitPoint::constructorCallback):
- bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
(WebCore::V8WebSocket::sendCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::importScriptsCallback):
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
(WebCore::V8XMLHttpRequest::openCallback):
(WebCore::V8XMLHttpRequest::sendCallback):
- 6:48 PM EFLWebKitCodingStyle edited by
- (diff)
- 6:45 PM Changeset in webkit [125494] by
-
- 5 edits in trunk/Source/WebCore
[V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h
https://bugs.webkit.org/show_bug.cgi?id=93818
Reviewed by Adam Barth.
(1) This patch moves GCEventData class from V8Binding.h to ScriptGCEvent.h.
(2) This patch makes GCEventData::startTime and GCEventData::usedHeapSize
private members.
(3) This patch removes unused forward declarations from V8Binding.h.
No tests. No change in behavior.
- bindings/v8/ScriptGCEvent.cpp:
(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):
- bindings/v8/ScriptGCEvent.h:
(GCEventData):
(WebCore::GCEventData::GCEventData):
(WebCore::GCEventData::clear):
(WebCore::GCEventData::listeners):
(WebCore::GCEventData::startTime):
(WebCore::GCEventData::setStartTime):
(WebCore::GCEventData::usedHeapSize):
(WebCore::GCEventData::setUsedHeapSize):
(WebCore):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8PerIsolateData.cpp:
- 6:39 PM Changeset in webkit [125493] by
-
- 7 edits1 add in trunk/Source/WebCore
[V8] Move checkNewLegal() from V8Proxy.h to SafeAllocation.h
https://bugs.webkit.org/show_bug.cgi?id=93830
Reviewed by Adam Barth.
This patch moves checkNewLegal() from V8Proxy.h to SafeAllocation.h.
In addition, this patch renames checkNewLegal() to isValidConstructorMode()
for clarification.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/SafeAllocation.cpp: Added.
- bindings/v8/SafeAllocation.h:
(WebCore::SafeAllocation::newInstance):
(WebCore):
- bindings/v8/V8Binding.cpp:
(WebCore::createRawTemplate):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 6:38 PM EFLWebKitCodingStyle edited by
- Add new coding style related to double not operator(!!) (diff)
- 6:34 PM Changeset in webkit [125492] by
-
- 2 edits in trunk/Source/WebCore
[V8] Remove unused methods from V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=93836
Reviewed by Adam Barth.
enableStringImplCache() and v8UndetectableString() are not used by anybody.
No tests. No change in behavior.
- bindings/v8/V8Binding.h:
- 6:32 PM Changeset in webkit [125491] by
-
- 5 edits in trunk/Source/WebCore
[V8] Move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h
https://bugs.webkit.org/show_bug.cgi?id=93834
Reviewed by Adam Barth.
This patch moves hintForGCIfNecessary() from V8Proxy.h to V8GCController.h.
No tests. No change in behavior.
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::hintForGCIfNecessary):
- bindings/v8/V8GCController.h:
(V8GCController):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::clearForClose):
(WebCore::V8Proxy::clearForNavigation):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 6:29 PM Changeset in webkit [125490] by
-
- 4 edits in trunk/LayoutTests
Unreviewed rebaseline after r125193.
- platform/chromium-mac/compositing/masks/layer-mask-placement-expected.png:
- platform/chromium-win/compositing/masks/layer-mask-placement-expected.png:
- platform/chromium/TestExpectations:
- 6:27 PM Changeset in webkit [125489] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r124970.
http://trac.webkit.org/changeset/124970
https://bugs.webkit.org/show_bug.cgi?id=93495
Postponing the merge in a clearer context (Requested by
Michelangelo on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransform):
- css/CSSParser.h:
- 6:24 PM Changeset in webkit [125488] by
-
- 1 edit4 adds in trunk/LayoutTests
Add test to demonstrate overpainting seen in bug 92800
https://bugs.webkit.org/show_bug.cgi?id=93901
Reviewed by Levi Weintraub.
Bug 92800 is a rather complicated change to fix this overpainting bug.
Adding the test before the change so that it's easier for me to track as I change
this behavior and for reviewers to see that I'm fixing this overpainting.
- fast/repaint/add-table-overpaint-expected.png: Added.
- fast/repaint/add-table-overpaint-expected.txt: Added.
- fast/repaint/add-table-overpaint.html: Added.
- 6:04 PM Changeset in webkit [125487] by
-
- 2 edits in trunk/Tools
Unreviewed update for webcomponents-bugzilla address.
- Scripts/webkitpy/common/config/committers.py:
- 6:03 PM Changeset in webkit [125486] by
-
- 4 edits in trunk/Source
[chromium] renderSurface in incorrect space if owning layer has empty but non-zero bounds
https://bugs.webkit.org/show_bug.cgi?id=93795
Reviewed by Adrienne Walker.
Source/WebCore:
If a renderSurface is created by a layer that had zero
area (empty) but non-zero bounds (either width or height was
non-zero), then one translation transform was accidentally being
skipped, causing the renderSurface drawTransform to be incorrect.
The fix is simply to move that transform outside of the
if-statement so it is not skipped.
Unit test added:
CCLayerTreeHostCommonTest.verifyTransformsForDegenerateIntermediateLayer()
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):
Source/WebKit/chromium:
- tests/CCLayerTreeHostCommonTest.cpp:
- 5:57 PM Changeset in webkit [125485] by
-
- 2 edits in trunk/WebKitLibraries
Enable CSS Sticky Position on Windows.
https://bugs.webkit.org/show_bug.cgi?id=93905
Patch by Roger Fong <roger_fong@apple.com> on 2012-08-13
Reviewed by Tim Horton.
As per https://bugs.webkit.org/show_bug.cgi?id=90046, the ENABLE_CSS_STICKY_POSITION needs to be turned on for Windows as well.
- win/tools/vsprops/FeatureDefines.vsprops:
Include ENABLE_CSS_STICKY_POSITION flag.
- 5:55 PM Changeset in webkit [125484] by
-
- 18 edits in trunk/Source/WebCore
[V8] Remove [TreatReturnedNullAs=False]
https://bugs.webkit.org/show_bug.cgi?id=93835
Reviewed by Adam Barth.
[TreatReturnedNullAs=False] is neither defined in the Web IDL spec
nor used in any WebKit IDL file.
No tests. No change in behavior.
- WebCore.order:
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h:
(WebCore):
- bindings/scripts/CodeGeneratorJS.pm:
(NativeToJSValue):
- bindings/scripts/CodeGeneratorV8.pm:
(NativeToJSValue):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
- bindings/v8/V8Binding.h:
- 5:53 PM Changeset in webkit [125483] by
-
- 5 edits in trunk/Source/WebCore
[V8] Rename v8ValueToWebCoreDOMStringList() to toDOMStringList()
https://bugs.webkit.org/show_bug.cgi?id=93839
Reviewed by Adam Barth.
For naming consistency with toWebCoreString() and toWebCoreAtomicString(),
this patch renames v8ValueToWebCoreDOMStringList() to toDOMStringList().
("WebCore" wouldn't be needed because it's clear from "DOMStringList".)
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(JSValueToNative):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
- bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
- bindings/v8/V8Binding.h:
(WebCore):
- 5:51 PM Changeset in webkit [125482] by
-
- 14 edits in trunk/Source/WebCore
[V8] Rename v8ValueToAtomicWebCoreString() to toWebCoreAtomicString()
https://bugs.webkit.org/show_bug.cgi?id=93824
Reviewed by Adam Barth.
For naming consistency with toWebCoreString(), we can rename
v8ValueToAtomicWebCoreString() to toWebCoreAtomicString().
Also we can rename v8ValueToAtomicWebCoreStringWithNullCheck()
to toWebCoreAtomicStringWithNullCheck().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):
- bindings/v8/V8Binding.cpp:
(WebCore::toWebCoreAtomicString):
- bindings/v8/V8Binding.h:
(WebCore::toWebCoreStringWithNullOrUndefinedCheck):
(WebCore::toWebCoreAtomicStringWithNullCheck):
- bindings/v8/V8Collection.h:
(WebCore::getNamedPropertyOfCollection):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::getter):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::namedPropertyGetter):
- bindings/v8/custom/V8HTMLFormElementCustom.cpp:
(WebCore::V8HTMLFormElement::namedPropertyGetter):
- bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
- bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::namedPropertyGetter):
- 5:49 PM Changeset in webkit [125481] by
-
- 7 edits in trunk/Source/WebCore
[V8] Remove v8ValueToWebCoreString()
https://bugs.webkit.org/show_bug.cgi?id=93822
Reviewed by Adam Barth.
There are two equivalent ways to convert a V8 value to a WebCore String;
i.e. v8ValueToWebCoreString() and toWebCoreString(). We can remove the former.
In a follow-up patch, I will replace v8ValueToAtomicWebCoreString()
with toWebCoreAtomicString(), for consistency with toWebCoreString().
No tests. No change in behavior.
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
(WebCore::Dictionary::getWithUndefinedOrNullCheck):
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
- bindings/v8/V8Binding.cpp:
(WebCore::toWebCoreString):
(WebCore::v8ValueToWebCoreDOMStringList):
- bindings/v8/V8Binding.h:
(WebCore::toWebCoreStringWithNullCheck):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventCallback):
- 5:47 PM Changeset in webkit [125480] by
-
- 4 edits in trunk/Source/WebCore
[V8] Move the ConstructorMode class from V8Binding.h to SafeAllocation.h
https://bugs.webkit.org/show_bug.cgi?id=93821
Reviewed by Adam Barth.
This patch factors out the ConstructorMode class from V8Binding.h to SafeAllocation.h.
No tests. No change in behavior.
- bindings/v8/SafeAllocation.h:
(ConstructorMode):
(WebCore::ConstructorMode::ConstructorMode):
(WebCore::ConstructorMode::~ConstructorMode):
(WebCore::ConstructorMode::current):
(WebCore):
- bindings/v8/V8Binding.h:
- bindings/v8/V8RecursionScope.h:
- 5:44 PM Changeset in webkit [125479] by
-
- 5 edits2 deletes in trunk/Source/WebCore
[V8] Remove V8BindingHelpers
https://bugs.webkit.org/show_bug.cgi?id=93807
Reviewed by Adam Barth.
V8BindingHelpers contains toV8Context() and toV8Proxy(), which are used
by NPV8Object.cpp only.
(1) Move these methods to NPV8Object.cpp as static methods.
(2) Remove V8BindingHelpers.{h,cpp}.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/NPV8Object.cpp:
(WebCore::toV8Context):
(WebCore):
(WebCore::toV8Proxy):
- bindings/v8/V8Binding.h:
- bindings/v8/V8BindingHelpers.cpp: Removed.
- bindings/v8/V8BindingHelpers.h: Removed.
- 5:42 PM Changeset in webkit [125478] by
-
- 3 edits in trunk/Source/WebCore
[V8] Remove unused methods and headers from V8Utilities
https://bugs.webkit.org/show_bug.cgi?id=93805
Reviewed by Adam Barth.
This patch removes unused methods, forward declarations and
headers from V8Utilities.{h,cpp}.
No tests. No change in behavior.
- bindings/v8/V8Utilities.cpp:
- bindings/v8/V8Utilities.h:
(WebCore):
- 5:40 PM Changeset in webkit [125477] by
-
- 3 edits in trunk/Source/WebCore
[V8] Move V8PerIsolateData::visitExternalStrings() to V8PerIsolateData.cpp
https://bugs.webkit.org/show_bug.cgi?id=93803
Reviewed by Adam Barth.
In r125015, I forgot to move V8PerIsolateData::visitExternalStrings()
to V8PerIsolateData.cpp. This patch moves it.
No tests. No change in behavior.
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8PerIsolateData.cpp:
(WebCore):
(WebCore::V8PerIsolateData::visitExternalStrings):
- 5:38 PM Changeset in webkit [125476] by
-
- 6 edits2 adds in trunk
Expand list of supported languages for RenderQuote to match WHATWG spec
https://bugs.webkit.org/show_bug.cgi?id=93424
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-08-13
Reviewed by Eric Seidel.
Source/WebCore:
Expand the table of quotes to include the 148 lang values and associated quotes
from the WHATWG web-apps recommended styling spec.
Test: fast/css-generated-content/quotes-lang-case-insensitive.html
- rendering/RenderQuote.cpp: Added missing copyright.
(WebCore::quotesDataLanguageMap): Expanded the table of quotes.
(WebCore::basicQuotesData): Added a FIXME to switch to using stylized "en" quotes.
- rendering/RenderQuote.h: Added missing copyright.
LayoutTests:
Update quote language test to include the 148 languages in the WHATWG web-apps
recommended styling table.
http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#quotes
Add a new test that ensures language matching for quotes is case insensitive.
- fast/css-generated-content/quotes-lang-case-insensitive-expected.html: Added.
- fast/css-generated-content/quotes-lang-case-insensitive.html: Added.
- fast/css-generated-content/quotes-lang-expected.html:
- fast/css-generated-content/quotes-lang.html:
- 5:36 PM Changeset in webkit [125475] by
-
- 5 edits in trunk/Source/WebCore
[V8] Remove evaluateInIsolatedWorld() from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93679
Reviewed by Adam Barth.
To remove V8Proxy, this patch moves V8Proxy::evaluateInIsolatedWorld()
to ScriptController.
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluateInIsolatedWorld):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::precompileScript):
- 5:33 PM Changeset in webkit [125474] by
-
- 8 edits4 copies in branches/chromium/1229
Merge 125193 - [chromium] Pass mask scale and offset to shaders for correct masking
https://bugs.webkit.org/show_bug.cgi?id=93558
Reviewed by Adrienne Walker.
Source/WebCore:
In chromium compositor code, the mask was accidentally mapped 1:1
to the layer's renderSurface, rather than the layer itself. This
patch adds a layout test that reproduces the error and fixes the
problem. The solution we opted for in this patch is to pass a
scale and offset to the fragment shader, so that the correct
texture coordinate lookup is computed by the fragment shader.
Test: compositing/masks/mask-of-clipped-layer.html
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRenderPassQuad):
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::FragmentShaderRGBATexAlphaMask::FragmentShaderRGBATexAlphaMask):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderRGBATexAlphaMask::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::FragmentShaderRGBATexAlphaMaskAA):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):
- platform/graphics/chromium/ShaderChromium.h:
(WebCore::FragmentShaderRGBATexAlphaMask::maskTexCoordScaleLocation):
(WebCore::FragmentShaderRGBATexAlphaMask::maskTexCoordOffsetLocation):
(FragmentShaderRGBATexAlphaMask):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskTexCoordScaleLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskTexCoordOffsetLocation):
(FragmentShaderRGBATexAlphaMaskAA):
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::maskTexCoordScaleX):
(WebCore::CCRenderPassDrawQuad::maskTexCoordScaleY):
(WebCore::CCRenderPassDrawQuad::maskTexCoordOffsetX):
(WebCore::CCRenderPassDrawQuad::maskTexCoordOffsetY):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::appendQuads):
Source/WebKit/chromium:
Updated one unit test that needed additional args in a
constructor, but no change in behavior of the test.
- tests/CCLayerTreeHostImplTest.cpp:
LayoutTests:
Added a layout test that checks the mask does not accidentally get
resized when it is inside of an overflow div.
- compositing/masks/mask-of-clipped-layer-expected.png: Added.
- compositing/masks/mask-of-clipped-layer-expected.txt: Added.
- compositing/masks/mask-of-clipped-layer.html: Added.
- compositing/resources/alpha-blocks.png: Added.
- 5:22 PM Changeset in webkit [125473] by
-
- 3 edits in trunk/Source/WebCore
[CSS Exclusions] Remove unused CSSWrapShapes header includes
https://bugs.webkit.org/show_bug.cgi?id=93395
Patch by Bear Travis <betravis@adobe.com> on 2012-08-13
Reviewed by Kentaro Hara.
Removing the #include "CSSWrapShapes.h" lines from StyleBuilder.cpp and
RenderStyle.cpp. Both files now use the length-based WrapShapes.h classes.
- css/StyleBuilder.cpp:
- rendering/style/RenderStyle.cpp:
- 5:11 PM Changeset in webkit [125472] by
-
- 3 edits2 adds in trunk
Bad cast in RenderBox::computeReplacedLogicalHeightUsing
https://bugs.webkit.org/show_bug.cgi?id=93875
Patch by Pravin D <pravind.2k4@gmail.com> on 2012-08-13
Reviewed by Abhishek Arya.
Source/WebCore:
Pointer to the container of a replaced element was being type casted to renderbox
without checking if the container is a renderbox or not.
Test: fast/replaced/render-inline-cast-to-render-box-crash.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
Scrollbar height is retrieved only if the container is a renderBox. Otherwise scrollbar is taken as zero.
LayoutTests:
- fast/replaced/render-inline-cast-to-render-box-crash-expected.txt: Added.
- fast/replaced/render-inline-cast-to-render-box-crash.html: Added.
- 5:05 PM Changeset in webkit [125471] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r125450): 4 canvas/philip/tests tests failing on Apple Lion Release WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93910
Unreviewed test expectations update. Temporarily skipping tests.
- platform/mac/TestExpectations:
- 4:49 PM Changeset in webkit [125470] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Unreviewed bot fix after r125467.
- PlatformEfl.cmake: Make the WK2 tests link against glib, gobject
and gio as well.
- 4:45 PM Changeset in webkit [125469] by
-
- 11 edits1 move1 add in trunk/Source
[chromium] Make WebAnimation a pure virtual interface to hide implementation and avoid unresolved symbols
https://bugs.webkit.org/show_bug.cgi?id=93907
Reviewed by Darin Fisher.
Source/Platform:
This makes WebAnimation a pure virtual interface with instances returned by a factory function. Currently the
factory is a static function on WebAnimation, but it will likely move to a platform support interface. This
provides better isolation of the implementation from the interface and in particular allows for implementing the
WebAnimation interface outside of WebKit.dll without having unresolved external symbols in WebKit.dll.
- chromium/public/WebAnimation.h:
(WebKit::WebAnimation::~WebAnimation):
(WebAnimation):
- chromium/public/WebLayer.h:
(WebLayer):
Source/WebCore:
Updates WebAnimation users for interface changes.
- platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::createWebAnimation):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::addAnimation):
Source/WebKit/chromium:
Adds a WebAnimationImpl implementation of the WebAnimation interface.
- WebKit.gyp:
- src/WebAnimationImpl.cpp: Renamed from Source/WebKit/chromium/src/WebAnimation.cpp.
(WebKit):
(WebKit::WebAnimation::create):
(WebKit::WebAnimationImpl::targetProperty):
(WebKit::WebAnimationImpl::iterations):
(WebKit::WebAnimationImpl::setIterations):
(WebKit::WebAnimationImpl::startTime):
(WebKit::WebAnimationImpl::setStartTime):
(WebKit::WebAnimationImpl::timeOffset):
(WebKit::WebAnimationImpl::setTimeOffset):
(WebKit::WebAnimationImpl::alternatesDirection):
(WebKit::WebAnimationImpl::setAlternatesDirection):
(WebKit::WebAnimationImpl::cloneToCCAnimation):
- src/WebAnimationImpl.h: Added.
(WebCore):
(WebKit):
(WebAnimationImpl):
(WebKit::WebAnimationImpl::WebAnimationImpl):
(WebKit::WebAnimationImpl::~WebAnimationImpl):
- src/WebLayer.cpp:
(WebKit::WebLayer::addAnimation):
- tests/WebAnimationTest.cpp:
(WebKit::TEST):
- 4:41 PM Changeset in webkit [125468] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Unreviewed attempt at fixing the bots after r125467.
- PlatformEfl.cmake: Link against GIO and GObject due to the usage
of libsoup.
- 4:30 PM Changeset in webkit [125467] by
-
- 15 edits1 add1 delete in trunk
[CMake] Rewrite FindLibSoup2.cmake.
https://bugs.webkit.org/show_bug.cgi?id=93191
Reviewed by Rob Buis.
.:
The existing LibSoup2 was imported from somewhere else and not
only did it contain a lot of unnecessary cruft to look for libsoup
2.2 (which we do not support anyway), but it also relied on the
paths returned by pkg-config for setting the library and include
paths.
For one, this meant "-lsoup-2.4" was passed to the linked instead
of "-L/path/to/libsoup-2.4.so", which would sometimes make a
system version of libsoup to be picked up instead of the one
installed by, say, jhbuild.
The new FindLibSoup.cmake now only looks for libsoup 2.4 and
relies on pkg-config solely for retrieving the current LibSoup
version.
- Source/cmake/FindLibSoup.cmake: Added.
- Source/cmake/FindLibSoup2.cmake: Removed.
- Source/cmake/OptionsEfl.cmake: Look for LibSoup instead of
LibSoup2, look for the GObject component of Glib.
Source/WebCore:
- PlatformEfl.cmake: Use LIBSOUP_FOO instead of LIBSOUP24_FOO,
also link against GObject, which is needed by libsoup.
Source/WebKit:
- PlatformEfl.cmake: Use LIBSOUP_FOO instead of LIBSOUP24_FOO.
Source/WebKit2:
- PlatformEfl.cmake: Use LIBSOUP_FOO instead of LIBSOUP24_FOO, and
do not use LIBSOUP24_LDFLAGS, as it is not needed anymore.
Tools:
- DumpRenderTree/efl/CMakeLists.txt: Use LIBSOUP_FOO instead of
LIBSOUP24_FOO, and do not use LIBSOUP24_LDFLAGS, as it is not
needed anymore.
- EWebLauncher/CMakeLists.txt: Ditto.
- MiniBrowser/efl/CMakeLists.txt: Ditto.
- TestWebKitAPI/PlatformEfl.cmake: Ditto.
- WebKitTestRunner/CMakeLists.txt: Ditto.
- WebKitTestRunner/PlatformEfl.cmake: Ditto.
- 3:46 PM Changeset in webkit [125466] by
-
- 12 edits2 adds in trunk/Source
[chromium] Clean up dependencies for Canvas2DLayerBridgeTest and GraphicsLayerChromiumTest unit tests
https://bugs.webkit.org/show_bug.cgi?id=93757
Reviewed by Adrienne Walker.
Source/Platform:
Exposes a function to check for active animations on a layer.
- chromium/public/WebLayer.h:
(WebLayer):
Source/WebCore:
Exposes the current contentsScale for tests.
- platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
Source/WebKit/chromium:
Breaks up some unit tests and removes unused code to avoid unit tests depending on both non-compositor WebCore
logic and compositor internals. Canvas2DLayerBridgeTest had some vestigal includes and local variables that
weren't being used, those are removed. GraphicsLayerChromiumTest was reaching into CC types, but could mostly
use Platform API types for testing.
GraphicsLayerChromiumTest had some tests that were verifying that we could correctly translate WebCore
animation lists into CCAnimation types - these have been moved into AnimationTranslationUtilTest.cpp, since the
logic under test is in AnimationTranslationUtil. Currently these only test that we accept / reject animations as
expected. They could be expanded to verify that the animation was translated faithfully, but that would require
expanding the information exposed on WebAnimation.
- WebKit.gypi:
- src/WebLayer.cpp:
(WebKit::WebLayer::hasActiveAnimation):
(WebKit):
- tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
- tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(GraphicsLayerChromiumTest):
(WebKit::TEST_F):
- tests/WebLayerTreeViewTest.cpp:
- tests/WebLayerTreeViewTestCommon.h: Added.
(WebKit):
(MockWebLayerTreeViewClient):
- 3:44 PM Changeset in webkit [125465] by
-
- 3 edits in trunk/Source/WebCore
Reduce the size of empty NinePieceImage objects.
<http://webkit.org/b/93747>
Reviewed by Antti Koivisto.
Move the members of NinePieceImage into a NinePieceImageData class, leaving NinePieceImage
with a single OwnPtr<NinePieceImageData> member. The constant NinePieceImage::defaultData()
provides default values for objects with null m_data.
RenderStyle's "StyleSurroundData" member has a BorderData, which in turn holds a NinePieceImage.
This means that anything with left/right/top/bottom, margin, padding or border style but *no*
border-image will save 104 bytes (assuming their RenderStyle is unshared, which is fairly common.)
This reduces the size of StyleSurroundData by 104 bytes, effectively reducing memory consumption
by 1.72MB when viewing the full HTML5 spec at <http://whatwg.org/c>
- rendering/style/NinePieceImage.cpp:
(WebCore::NinePieceImageData::operator==):
(WebCore::NinePieceImage::defaultData):
(WebCore):
- rendering/style/NinePieceImage.h:
(WebCore::NinePieceImageData::NinePieceImageData):
(NinePieceImageData):
(WebCore::NinePieceImageData::operator!=):
(WebCore):
(NinePieceImage):
(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImage::operator=):
(WebCore::NinePieceImage::operator==):
(WebCore::NinePieceImage::operator!=):
(WebCore::NinePieceImage::hasImage):
(WebCore::NinePieceImage::image):
(WebCore::NinePieceImage::setImage):
(WebCore::NinePieceImage::imageSlices):
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::fill):
(WebCore::NinePieceImage::setFill):
(WebCore::NinePieceImage::borderSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::outset):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::horizontalRule):
(WebCore::NinePieceImage::setHorizontalRule):
(WebCore::NinePieceImage::verticalRule):
(WebCore::NinePieceImage::setVerticalRule):
(WebCore::NinePieceImage::copyImageSlicesFrom):
(WebCore::NinePieceImage::copyBorderSlicesFrom):
(WebCore::NinePieceImage::copyOutsetFrom):
(WebCore::NinePieceImage::copyRepeatFrom):
(WebCore::NinePieceImage::setMaskDefaults):
(WebCore::NinePieceImage::ensureData):
(WebCore::NinePieceImage::data):
- 3:42 PM Changeset in webkit [125464] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=93883
More Windows build fixing.
- UIProcess/WebContext.cpp: (WebKit::WebContext::dummy):
- 3:39 PM Changeset in webkit [125463] by
-
- 6 edits16 deletes in branches/safari-536.26-branch
Merge fix for <rdar://problem/12050793>.
- 3:37 PM Changeset in webkit [125462] by
-
- 41 edits3 adds in trunk
WebKit+SVG does not support color-interpolation-filters or draw filters in correct colorspace
https://bugs.webkit.org/show_bug.cgi?id=6033
Reviewed by Dirk Schulze.
Source/WebCore:
This patch adds support for SVG color-interpolation-filters. All non-CG plarforms now
perform color space conversions as needed (CG performs color space adjustments internally),
and the new default color space for filters is linearRGB
(http://www.w3.org/TR/SVG/filters.html#FilterPrimitivesOverviewIntro).
FilterEffect tracks the color-interpolation-filters attribute (m_colorSpace) and the
current result color space (m_resultColorSpace). When applying, the input results are
converted to the current FilterEffect's color space, and at the end of the filter effect
chain the result is finally converted to ColorSpaceDeviceRGB.
FilterEffect::transformResultColorSpace() handles non-CG color space converion (CG has
built in support for different color spaces) by first converting the result to an image
buffer, and then using the platform specific ImageBuffer::transformColorSpace(). This can
be expensive for filter chains with alternating color-interpolation-filters, but can be
optimized if/when color space support is added to all the graphics backends similarly to CG.
As expected, lots of filter-related pixel results will require rebaselining after this lands.
Test: svg/filters/color-interpolation-filters.svg
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::apply):
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::transformResultColorSpace):
(WebCore):
- platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::colorSpace):
(WebCore::FilterEffect::setColorSpace):
(FilterEffect):
- platform/graphics/filters/SourceGraphic.h:
(WebCore::SourceGraphic::SourceGraphic):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::apply):
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::postApplyResource):
LayoutTests:
- platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
- platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
- platform/chromium-linux/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
- platform/chromium-linux/css3/filters/custom/filter-repaint-custom-expected.png:
- platform/chromium-linux/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-expected.png:
- platform/chromium-linux/svg/filters/color-interpolation-filters-expected.png: Added.
- platform/chromium-linux/svg/filters/color-interpolation-filters-expected.txt: Added.
- platform/chromium-win/css3/filters/add-filter-rendering-expected.png:
- platform/chromium-win/css3/filters/crash-filter-change-expected.png:
- platform/chromium-win/css3/filters/effect-blur-expected.png:
- platform/chromium-win/css3/filters/effect-combined-expected.png:
- platform/chromium-win/css3/filters/effect-contrast-expected.png:
- platform/chromium-win/css3/filters/effect-drop-shadow-expected.png:
- platform/chromium-win/css3/filters/effect-grayscale-expected.png:
- platform/chromium-win/css3/filters/effect-hue-rotate-expected.png:
- platform/chromium-win/css3/filters/effect-invert-expected.png:
- platform/chromium-win/css3/filters/effect-opacity-expected.png:
- platform/chromium-win/css3/filters/effect-reference-expected.png:
- platform/chromium-win/css3/filters/effect-reference-external-expected.png:
- platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-win/css3/filters/effect-reference-ordering-expected.png:
- platform/chromium-win/css3/filters/effect-saturate-expected.png:
- platform/chromium-win/css3/filters/effect-sepia-expected.png:
- platform/chromium-win/css3/filters/filtered-inline-expected.png:
- platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png:
- platform/chromium-win/css3/filters/nested-filters-expected.png:
- platform/chromium-win/css3/filters/regions-expanding-expected.png:
- platform/chromium-win/css3/filters/simple-filter-rendering-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/css3/filters/blur-filter-page-scroll-expected.png:
- platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- svg/filters/color-interpolation-filters.svg: Added.
- 3:35 PM Changeset in webkit [125461] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebCore
Merged r125104. <rdar://problem/12082988>
- 3:16 PM Changeset in webkit [125460] by
-
- 7 edits in trunk
Oscillator node should throw exception if type is assigned an invalid value
https://bugs.webkit.org/show_bug.cgi?id=93490
Patch by Raymond Toy <Raymond Toy> on 2012-08-13
Reviewed by Chris Rogers.
Source/WebCore:
New tests added to oscillator-basic to catch exceptions.
- Modules/webaudio/Oscillator.cpp:
(WebCore::Oscillator::Oscillator):
(WebCore::Oscillator::setType): Return exception
- Modules/webaudio/Oscillator.h:
(Oscillator): Update setType declaration
- Modules/webaudio/Oscillator.idl: setType can raise exception.
LayoutTests:
Add tests for invalid oscillator types.
- webaudio/oscillator-basic-expected.txt: Updated
- webaudio/oscillator-basic.html: Test CUSTOM and invalid
oscillator type.
- 3:16 PM Changeset in webkit [125459] by
-
- 5 edits3 copies in branches/safari-536.26-branch
Merged r125086. <rdar://problem/12082988>
- 3:07 PM Changeset in webkit [125458] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=93883
More Windows build fix
- UIProcess/WebContext.cpp: (WebKit::WebPage::dummy):
- UIProcess/WebContext.h: (WebContext):
- UIProcess/WebContext.messages.in: Add a dummy sync message - the same workaround is already used in WebPage.
- 3:04 PM Changeset in webkit [125457] by
-
- 10 edits3 adds in trunk
With asynchronous plug-in initialization, WebProcess and PluginProcess can deadlock
<rdar://problem/12062125> and https://bugs.webkit.org/show_bug.cgi?id=93894
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
A few things were in play here:
- The WebProcess thought the plug-in was done initializing but it wasn't.
- The sync message out from the PluginProcess was not being handled by the WebProcess.
Expose the ability for the PluginProcess to act as if it is handling a sync message and needs messages dispatched:
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::incrementDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount):
(CoreIPC::Connection::decrementDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount):
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::setInitializationReply): Save the delayed reply for synchronous initialization.
(WebKit::PluginControllerProxy::takeInitializationReply): Give back the delayed reply for initialization completion.
(WebKit::PluginControllerProxy::initialize):
- PluginProcess/PluginControllerProxy.h:
(WebKit::PluginControllerProxy::isInitializing): Accessor so WebProcessConnection knows whether or not to store the
delayed reply for later.
- PluginProcess/WebProcessConnection.messages.in: Make the synchronous form of "CreatePlugin" have a delayed reply.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPlugin): Store away the delayed reply message so it can be responded to after
asynchronous initialization completes.
(WebKit::WebProcessConnection::createPluginAsynchronously): If there is a stored away delayed reply message, respond to
it instead of sending the asynchronously reply.
- PluginProcess/WebProcessConnection.h:
(WebProcessConnection):
Tools:
Add a test that calls out to NPP_Evaluate for some JS inside of NPP_New.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp: Added.
(EvaluteJSWithinNPP_New):
(EvaluteJSWithinNPP_New::EvaluteJSWithinNPP_New):
(EvaluteJSWithinNPP_New::NPP_New):
LayoutTests:
- platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate-expected.txt: Added.
- platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate.html: Added.
- 3:03 PM Changeset in webkit [125456] by
-
- 4 edits in trunk/Source/WebCore
AudioContext::createMediaStreamSource() must create a provider for local MediaStreams
https://bugs.webkit.org/show_bug.cgi?id=93756
Reviewed by Eric Carlson.
There are two main kinds of MediaStreams (local and from remote peers).
Internally we need to know the difference so a MediaStreamAudioSourceNode will "just work".
Tested by existing test: mediastreamaudiosourcenode.html
Full testing can only be verified by manual tests.
- Modules/mediastream/LocalMediaStream.h:
(LocalMediaStream):
- Modules/mediastream/MediaStream.h:
(WebCore::MediaStream::isLocal):
(MediaStream):
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource):
- 2:51 PM Changeset in webkit [125455] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebCore
Merged r123013. <rdar://problem/12087344>
- 2:49 PM Changeset in webkit [125454] by
-
- 5 edits in trunk
Unreviewed, rolling out r125422.
http://trac.webkit.org/changeset/125422
https://bugs.webkit.org/show_bug.cgi?id=93902
Broke the Android canary build (Requested by fmalita on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13
Source/WebKit/chromium:
- WebKitUnitTests.gyp:
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
- 2:42 PM Changeset in webkit [125453] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=93883
Windows build fix.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): (WebKit::WebProcess::clearPluginSiteData): Use WebProcessProxy for the message here, too.
- 2:37 PM Changeset in webkit [125452] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r125444.
http://trac.webkit.org/changeset/125444
https://bugs.webkit.org/show_bug.cgi?id=93872
Broke some tests
Source/JavaScriptCore:
- Target.pri:
Source/WebCore:
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
- bridge/qt/qt_runtime.h:
(QtRuntimeMethod):
- 2:29 PM Changeset in webkit [125451] by
-
- 10 edits in trunk/Source/WebKit2
[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=93883
Reviewed by Sam Weinig.
There was one plug-in message renaming. Moving it, and also other plug-in messages
for consistency.
- UIProcess/WebContext.cpp: (WebKit): Got rid of the last MESSAGE_CHECK in this file. (WebKit::WebContext::WebContext): Moved m_pluginWorkQueue to a singleton. We don't need more than one queue (all it does is read plug-in info), and if we needed, it would have been per-process, not per-context. (WebKit::WebContext::~WebContext): No more work queue. (WebKit::WebContext::processDidFinishLaunching): Ditto.
- UIProcess/WebContext.h: No longer needs to be a QueueClient.
- UIProcess/WebContext.messages.in:
- UIProcess/WebProcessProxy.messages.in: Moved plug-in related messages.
- UIProcess/WebProcessProxy.cpp: (WebKit::pluginWorkQueue): Moved from WebContext to a singleton. (WebKit::WebProcessProxy::sendDidGetPlugins): Moved from WebContext. (WebKit::WebProcessProxy::handleGetPlugins): Ditto. (WebKit::WebProcessProxy::getPlugins): Ditto. (WebKit::WebProcessProxy::getPluginPath): Ditto. (WebKit::WebProcessProxy::getPluginProcessConnection): Ditto. (WebKit::WebProcessProxy::didGetSitesWithPluginData): Ditto. (WebKit::WebProcessProxy::didClearPluginSiteData): Ditto.
- UIProcess/WebProcessProxy.h: Process proxy needs to be thread safe ref counted now, since it sends messages to itself on a work queue and back.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::populatePluginCache): Updated for new receiver.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Ditto.
- WebProcess/WebProcess.cpp: (WebKit::canPluginHandleResponse): Ditto.
- 2:15 PM Changeset in webkit [125450] by
-
- 9 edits2 deletes in trunk
CanvasRenderContext2D::font() does not re-serialize the font
https://bugs.webkit.org/show_bug.cgi?id=50859
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Added proper serialization for the font property.
No new tests, unskipped the existing ones.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::font):
LayoutTests:
Unskip tests that will now pass and remove wrong/duplicated
expectations. canvas-font-ex-units-crash has now the wrong
expectations until we fix the issue on 93840.
- fast/canvas/canvas-font-ex-units-crash-expected.txt:
- fast/canvas/script-tests/canvas-font-ex-units-crash.js:
Even though we are setting a value on this test case (and verifying),
the font is not being effectiviely set as the serialization reveled. This
is going to be fixed in another bug.
- platform/chromium/TestExpectations:
- platform/chromium/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Removed.
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- platform/mac/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Removed.
- platform/qt/Skipped:
- 2:09 PM Changeset in webkit [125449] by
-
- 8 edits in branches/safari-536.26-branch
Merged r118725 for <rdar://problem/11942136>
- 2:06 PM Changeset in webkit [125448] by
-
- 6 edits2 adds in trunk
CSS quotes output quotes when depth is negative
https://bugs.webkit.org/show_bug.cgi?id=92690
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-08-13
Reviewed by Eric Seidel.
Source/WebCore:
Previously if the quote depth would go negative we would output the close quote from the
first pair of quotes again instead of outputting no quotes as required by the spec.
See: http://www.w3.org/TR/CSS21/generate.html#quotes-insert
Test: fast/css-generated-content/nested-quote-more-than-pairs.html
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::originalText): Allow the value passed to getOpenQuote to go negative by removing std::max.
- rendering/style/QuotesData.cpp:
(WebCore::QuotesData::getOpenQuote): Bounds check for negative values for safety.
(WebCore::QuotesData::getCloseQuote): Allow index to be >= -1 and return an empty string for -1.
LayoutTests:
Make the expected output of close-quote-negative-depth.html follow the spec and
add another test that ensures the last quote pair is repeated when the depth is
greater than the number of quote pairs.
- fast/css-generated-content/close-quote-negative-depth-expected.html:
- fast/css-generated-content/close-quote-negative-depth.html:
- fast/css-generated-content/nested-quote-more-than-pairs-expected.html: Added.
- fast/css-generated-content/nested-quote-more-than-pairs.html: Added.
- 2:01 PM Changeset in webkit [125447] by
-
- 2 edits in trunk/LayoutTests
Unreviewed skip: Skip faling test after r125428.
The fix will be tracked in https://bugs.webkit.org/show_bug.cgi?id=93897
- platform/qt/Skipped:
- 2:01 PM Changeset in webkit [125446] by
-
- 5 edits2 copies in branches/safari-536.26-branch
Merged r118721 for <rdar://problem/11942136>
- 1:48 PM Changeset in webkit [125445] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Clear HUD canvas contents before drawing into it.
https://bugs.webkit.org/show_bug.cgi?id=93759
Reviewed by Adrienne Walker.
Not clearing the bitmaps before drawing into it results into
random noise. This patch also caches the SkCanvas used by the HUD
to avoid reallocating it every frame.
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:
- 1:44 PM Changeset in webkit [125444] by
-
- 5 edits in trunk/Source
[Qt] Replace use of internal Weak smart pointer with JSWeakObjectMap
https://bugs.webkit.org/show_bug.cgi?id=93872
Reviewed by Kenneth Rohde Christiansen.
Source/JavaScriptCore:
- Target.pri: Add missing JSWeakObjectMap file to build.
Source/WebCore:
The intention of this patch series is to replace use of internal JSC
API with use of the stable and public C API.
The JSC::Weak template is internal API and the only part of the C API
that exposes similar functionality is the JSWeakObjectMap. It is
special in the sense that its life-time is tied to the life-time of the
JS global object, which in turn is subject to garbage collection. In
order to maximize re-use of the same map across different JSContextRef
instances, we use the associated global context ref as owner of the
weak maps. The key in the weak map is the identity (pointer) of the
runtime method object itself. The iteration through the maps is
tedious, but should usually not go beyond just a few.
- bridge/qt/qt_runtime.cpp:
(Bindings):
(JSC::Bindings::methodMapCleaner):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
- bridge/qt/qt_runtime.h:
(QtRuntimeMethod):
- 1:38 PM Changeset in webkit [125443] by
-
- 17 edits1 add3 deletes in trunk
[CMake] Remove glib-related Find modules and write single new one instead.
https://bugs.webkit.org/show_bug.cgi?id=93786
Reviewed by Rob Buis.
.:
As part of the ongoing effort to write proper Find modules that use
absolute include and library paths instead of the short ones from
pkg-config, replace Find{GIO,Glib,Gthread}.cmake with a single
FindGLIB.cmake that optionally detects components such as GIO and
GObject.
Library paths are now defined as "/full/path/to/libfoo.so" instead of
simply "foo", so that the linker receives a full path and we can then
avoid accidentally picking up a libfoo.so installed into /usr/lib
instead of a local one built with jhbuild.
- Source/cmake/FindGIO.cmake: Removed.
- Source/cmake/FindGLIB.cmake: Added.
- Source/cmake/FindGlib.cmake: Removed.
- Source/cmake/FindGthread.cmake: Removed.
- Source/cmake/OptionsEfl.cmake: Look for GLIB with the GIO component.
Source/JavaScriptCore:
- shell/PlatformEfl.cmake: Use GLIB_* instead of Glib_*.
Source/WebCore:
No new tests, build system plumbing.
- PlatformEfl.cmake: Use GLIB_* instead of Glib_*, and link
directly against GIO, as code in the soup network backend uses
that.
Source/WebKit:
- PlatformEfl.cmake: Use GLIB_* instead of Glib_*.
Source/WebKit2:
- PlatformEfl.cmake: Use GLIB_* instead of Glib_*.
Source/WTF:
- wtf/PlatformEfl.cmake: Use GLIB_* instead of Glib_*, and link directly to GIO, as wtf/gobject uses functions from it.
Tools:
- DumpRenderTree/efl/CMakeLists.txt: Use GLIB_* instead of Glib_*.
- EWebLauncher/CMakeLists.txt: Ditto.
- MiniBrowser/efl/CMakeLists.txt: Ditto.
- WebKitTestRunner/PlatformEfl.cmake: Ditto.
- 1:33 PM Changeset in webkit [125442] by
-
- 3 edits in trunk/Source/WebCore
[Qt] Simplify storage and reduce size of QtConnectionObject
https://bugs.webkit.org/show_bug.cgi?id=93868
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.
The connection object is a child of the sender QObject, so we can use parent()
whenever we need the sender instead of keeping an extra QObject pointer. Also
QtConnectionObject kept a RefPtr to the Instance, but actually only needed the
root object, so we can store a pointer to that instead.
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::QtConnectionObject):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):
- bridge/qt/qt_runtime.h:
(QtConnectionObject):
- 1:23 PM Changeset in webkit [125441] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Update API for spell checking suggestions again.
https://bugs.webkit.org/show_bug.cgi?id=93877
Reviewed by Antonio Gomes.
PR 163283.
Update the spell checking options request API
to include the caret positions.
Reviewed internally by Nima Ghanavatian.
- Api/WebPageClient.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
(WebKit):
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- WebKitSupport/InputHandler.h:
(Platform):
(InputHandler):
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- WebKitSupport/TouchEventHandler.h:
(TouchEventHandler):
- 1:17 PM Changeset in webkit [125440] by
-
- 4 edits in trunk/Source/WebCore
Media(Stream|Element)AudioSourceNode should be guarded by the WEB_AUDIO condition as well
https://bugs.webkit.org/show_bug.cgi?id=93864
Reviewed by Eric Carlson.
Add the WEB_AUDIO to the Conditional attribute in MediaElementAudioSourceNode
IDL file and the ENABLE(WEB_AUDIO) compilation guard to the header files for both
MediaStreamAudioSourceNode and MediaElementAudioSourceNode.
No new tests - no new functionality.
- Modules/webaudio/MediaElementAudioSourceNode.h:
- Modules/webaudio/MediaStreamAudioSourceNode.h:
- Modules/webaudio/MediaStreamAudioSourceNode.idl:
- 1:12 PM Changeset in webkit [125439] by
-
- 4 edits in trunk/Source/WebCore
[Qt] Clean up exception handling
https://bugs.webkit.org/show_bug.cgi?id=93880
Reviewed by Kenneth Rohde Christiansen.
The JSC C API uses a JSValueRef* exception parameter to indicate to the
caller that an exception was thrown. Naturally the caller must store
that ValueRef on the stack in order to get seen and marked by the
garbage collector, otherwise the callee would have to use
JSValueProtect on it.
This patch fixes one such case where in fact the exception pointer was passed as zero to the
callee and thus ignored. The patch also removes an unused exception parameter.
- bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
- bridge/qt/qt_runtime.h:
- 1:05 PM Changeset in webkit [125438] by
-
- 5 edits in trunk
Web Inspector: remove commitEditing from the text editor delegate.
https://bugs.webkit.org/show_bug.cgi?id=93858
Reviewed by Vsevolod Vlasov.
This should be up to the source frame.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._registerShortcuts):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.scrollChanged):
(WebInspector.SourceFrame.prototype._handleKeyDown):
(WebInspector.SourceFrame.prototype._commitEditing):
- inspector/front-end/TextEditor.js:
- 12:49 PM Changeset in webkit [125437] by
-
- 16 edits14 adds24 deletes in trunk
Unreviewed, rolling out r125430.
http://trac.webkit.org/changeset/125430
https://bugs.webkit.org/show_bug.cgi?id=93881
Caused css2.1/t1604-c541-word-sp-00-b-a.html to regress on Mac
builds (Requested by mwenge on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13
Source/WebCore:
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance):
- platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::isWordEnd):
- platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
(HarfBuzzShaperBase):
(WebCore::HarfBuzzShaperBase::isCodepointSpace):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
- rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache):
LayoutTests:
- css2.1/20110323/c541-word-sp-001-expected.html: Removed.
- css2.1/20110323/c541-word-sp-001.htm: Removed.
- css2.1/20110323/word-spacing-characters-002-expected.html: Removed.
- css2.1/20110323/word-spacing-characters-002.htm: Removed.
- css2.1/20110323/word-spacing-characters-003-expected.html: Removed.
- css2.1/20110323/word-spacing-characters-003.htm: Removed.
- css2.1/20110323/word-spacing-remove-space-001-expected.html: Removed.
- css2.1/20110323/word-spacing-remove-space-001.htm: Removed.
- css2.1/20110323/word-spacing-remove-space-002-expected.html: Removed.
- css2.1/20110323/word-spacing-remove-space-002.htm: Removed.
- css2.1/20110323/word-spacing-remove-space-003-expected.html: Removed.
- css2.1/20110323/word-spacing-remove-space-003.htm: Removed.
- css2.1/20110323/word-spacing-remove-space-004-expected.html: Removed.
- css2.1/20110323/word-spacing-remove-space-004.htm: Removed.
- css2.1/20110323/word-spacing-remove-space-005-expected.html: Removed.
- css2.1/20110323/word-spacing-remove-space-005.htm: Removed.
- css2.1/20110323/word-spacing-remove-space-006-expected.html: Removed.
- css2.1/20110323/word-spacing-remove-space-006.htm: Removed.
- css2.1/t1604-c541-word-sp-01-b-a.html: Added.
- fast/css/word-spacing-characters-complex-text-expected.html: Removed.
- fast/css/word-spacing-characters-complex-text.html: Removed.
- fast/css/word-spacing-characters-expected.html: Removed.
- fast/css/word-spacing-characters.html: Removed.
- fast/css/word-spacing-linebreak-expected.html: Removed.
- fast/css/word-spacing-linebreak.html: Removed.
- platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/chromium-linux/fast/css/word-space-extra-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
- platform/chromium-win/fast/css/word-space-extra-expected.txt:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
- platform/gtk/TestExpectations:
- platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
- platform/mac/TestExpectations:
- platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
- platform/qt/TestExpectations:
- platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
- platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
- platform/win/Skipped:
- 12:30 PM Changeset in webkit [125436] by
-
- 2 edits in trunk/Source/WebCore
FrameLoader::receivedMainResourceError doesn't handle GET cancellations well.
https://bugs.webkit.org/show_bug.cgi?id=93850
Patch by Mike West <mkwst@chromium.org> on 2012-08-13
Reviewed by Adam Barth.
'FrameLoader::cancel' should reset the loader's state, and it mostly
does. In the case of a GET form submission, however, the submitted form
URL that's stored doesn't match the URL that's requested (query string).
This leads to the loader getting a bit confused about what's going on,
and not clearing the stored form submission URL.
This patch moves to storing the form submission's actual request URL
as opposed to the form action URL.
None of the current tests should break, and when issue 93777 lands, it
won't be broken either.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
Switched to using 'FormSubmission::requestURL', as that matches the
URL that's actually requested during a form submission via GET.
- 12:25 PM Changeset in webkit [125435] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Hardware accelerated scrolling of <select> content
https://bugs.webkit.org/show_bug.cgi?id=93856
Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Matthew Staikos.
- Resources/blackberry/selectControlBlackBerry.css: add -webkit-overflow-scrolling: touch (EOM).
(.select-area):
- 12:24 PM Changeset in webkit [125434] by
-
- 6 edits in trunk/Source
[BlackBerry] Rounding error somewhere when translating CompositingLayer 's for in-region scrolling
https://bugs.webkit.org/show_bug.cgi?id=93848
PR #190986
Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>
Patch adds a WebKit thread setScrollPosition-like API to InRegionScroller.
It fixes a mismatch we had of setting a layer's scroll positing directly via
::setScrollPosition on the UI thread, but dispatching a coalesceable
scrollBy(delta) message to WebKit thread.
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScroller::setScrollPositionCompositingThread):
Changed the API name to match other thread specific methods naming.
(WebKit):
(BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
Added a setScrollPosition-like method to InRegionScroller public API. Used
together with its UI-thread counterpart, it can fix some rounding
errors we have due to mixing ::setScrollPosition and ::scrollBy methods.
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
Method renamed. See reasons above.
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
Calls fowards the call to ::setLayerScrollPosition (below).
(BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
Sets the scroll position of a given RenderLayer.
- Api/InRegionScroller.h:
(InRegionScroller):
- Api/InRegionScroller_p.h:
(WebCore):
(InRegionScrollerPrivate):
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
Cache the RenderLayer object associated to a given scrollable area
instead of its LayerCompositingThread. This way we can use it for
scrolling from both Compositing/UI and WebKit threads.
- 12:24 PM Changeset in webkit [125433] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Assertion in RenderObject::offsetFromAncestorContainer
https://bugs.webkit.org/show_bug.cgi?id=93845
Reviewed by Kenneth Rohde Christiansen.
Do not attempt to clip using layers that are not containers of the renderer.
- page/GestureTapHighlighter.cpp:
- 12:09 PM Changeset in webkit [125432] by
-
- 5 edits in trunk
[Cairo] canvas/philip/tests/2d.drawImage.self.2.html test failing on ports using Cairo
https://bugs.webkit.org/show_bug.cgi?id=93244
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Similar to Skia's and Qt's ImageBuffer implementation we need to make sure that buffers
for images are copied when the destination canvas is identical to the
image buffer's context. This happens mostly in JS calls to canvas' drawImage method.
For now fixing the drawImage case, drawPattern case is handled in bug 93854.
No new tests, covered by canvas/philip/tests/2d.drawImage.self.2.html
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::draw): Making sure buffer is copied when source and destination contexts are identical.
LayoutTests:
Unskipping canvas/philip/tests/2d.drawImage.self.2.html for GTK and EFL now that it's working.
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- 12:07 PM Changeset in webkit [125431] by
-
- 2 edits in trunk/LayoutTests
[Qt] new test css3/flexbox/line-wrapping.html failing
https://bugs.webkit.org/show_bug.cgi?id=72490
Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.
Gardening. Unskip now passing test.
- platform/qt/Skipped:
- 11:55 AM Changeset in webkit [125430] by
-
- 16 edits24 adds14 deletes in trunk
CSS 2.1 failure: Word-spacing affects each space and non-breaking space
https://bugs.webkit.org/show_bug.cgi?id=89826
Reviewed by Eric Seidel.
Source/WebCore:
Add word spacing to consecutive spaces in a run per http://www.w3.org/TR/CSS21/text.html#spacing-props.
Test: fast/css/word-spacing-characters.html
fast/css/word-spacing-characters-complex-text.html
fast/css/word-spacing-characters-linebreak.html
css2.1/20110323/word-spacing-characters-002.htm
css2.1/20110323/word-spacing-characters-003.htm
css2.1/20110323/word-spacing-remove-space-001.htm
css2.1/20110323/word-spacing-remove-space-002.htm
css2.1/20110323/word-spacing-remove-space-003.htm
css2.1/20110323/word-spacing-remove-space-004.htm
css2.1/20110323/word-spacing-remove-space-005.htm
css2.1/20110323/word-spacing-remove-space-006.htm
css2.1/20110323/c541-word-sp-001.htm
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance): All spaces (ordinary space or ) get word-spacing added, even
if they are consecutive.
- platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::isWordEnd): ditto, but for the complex text case on Chromium. Had to use
m_run rather than m_normalizedBuffer here as m_normalizedBuffer turns tabs into spaces! Unlike the simple
text path, '\n' gets word-spacing - I observed this from fast/text/atsui-spacing-features.html but can't
find it specified anywhere.
- platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
(WebCore::HarfBuzzShaperBase::isCodepointSpace):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): ditto, but for the complext text case on Mac.
The change to this file is speculative, I don't have a Mac build.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Tested by word-spacing-linebreak.html
- rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache): This code-path is not covered by any existing layout tests!
I've tried to come up with a test to hit it but have failed.
LayoutTests:
- css2.1/20110323/c541-word-sp-001-expected.html: Added.
- css2.1/20110323/c541-word-sp-001.htm: Added. Replaces t1604-c541-word-sp-01-b-a.html below.
- css2.1/20110323/word-spacing-characters-002-expected.html: Added.
- css2.1/20110323/word-spacing-characters-002.htm: Added.
- css2.1/20110323/word-spacing-characters-003-expected.html: Added.
- css2.1/20110323/word-spacing-characters-003.htm: Added. These passed already.
- css2.1/20110323/word-spacing-remove-space-001-expected.html: Added.
- css2.1/20110323/word-spacing-remove-space-001.htm: Added.
- css2.1/20110323/word-spacing-remove-space-002-expected.html: Added.
- css2.1/20110323/word-spacing-remove-space-002.htm: Added.
- css2.1/20110323/word-spacing-remove-space-003-expected.html: Added.
- css2.1/20110323/word-spacing-remove-space-003.htm: Added.
- css2.1/20110323/word-spacing-remove-space-004-expected.html: Added.
- css2.1/20110323/word-spacing-remove-space-004.htm: Added.
- css2.1/20110323/word-spacing-remove-space-005-expected.html: Added.
- css2.1/20110323/word-spacing-remove-space-005.htm: Added.
- css2.1/20110323/word-spacing-remove-space-006-expected.html: Added.
- css2.1/20110323/word-spacing-remove-space-006.htm: Added. These 6 tests are fixed by this patch.
- css2.1/t1604-c541-word-sp-01-b-a.html: Removed. Per http://lists.w3.org/Archives/Public/public-css-testsuite/2010Jan/0029.html t1604-c541-word-sp-01-b-a.htm is now invalid and has been replaced by c541-word-sp-001.htm above.
- fast/css/word-spacing-characters-complex-text-expected.html: Added.
- fast/css/word-spacing-characters-complex-text.html: Added. This is a complex text version of word-spacing-characters-001.htm
- fast/css/word-spacing-characters-expected.html: Added.
- fast/css/word-spacing-characters.html: Added. The original test (word-spacing-characters-001.htm) has two spaces between the non-breaking spaces in the second last case. This causes WebKit to split the text into two-runs and drop the second of the two spaces. This entire test can be replaced with word-spacing-characters-001.htm from the css test suite when https://bugs.webkit.org/show_bug.cgi?id=89827 is fixed.
- fast/css/word-spacing-linebreak-expected.html: Added.
- fast/css/word-spacing-linebreak.html: Added.
- platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/chromium-linux/fast/css/word-space-extra-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
- platform/chromium-win/fast/css/word-space-extra-expected.txt:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
- platform/gtk/TestExpectations:
- platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
- platform/mac/TestExpectations:
- platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
- platform/qt/TestExpectations:
- platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
- platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
- 11:45 AM Changeset in webkit [125429] by
-
- 5 edits in trunk
Remove webkitMediaSourceURL from HTMLMediaElement.idl
https://bugs.webkit.org/show_bug.cgi?id=93619
Reviewed by Adam Barth.
The webkitMediaSourceURL attribute is no longer needed now that we use
createObjectURL() to generate a media source URL.
Source/WebCore:
Test: update http/test/media/media-source/media-source.js
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
LayoutTests:
- http/tests/media/media-source/media-source.js:
(MediaSourceTest.setSrcToMediaSourceTestURL):
- 10:53 AM Changeset in webkit [125428] by
-
- 8 edits in trunk/Source
[Qt] Port meta method/signal/slot handling in run-time bridge to use JSC C API
https://bugs.webkit.org/show_bug.cgi?id=93476
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Based on patch by No'am Rosenthal and lots of good suggestions by Caio Marcelo.
Ported the code that mapped invokable methods (and signals/slots) as
well as the code that provides the connect() and disconnect() functions
over to use the JSC C API. In the process one behavioural change was
implemented: Previously meta methods were actually function objects
that through Function.prototype allowed calling via
object.method.call(object). Through the use of plain JS objects that is
not possible anymore.
If we tried to continue to use function objects (JSObjectMakeFunction)
then we would loose the ability to store the private pointer. An
alternative approach would be to use a regular object and install the
Function prototype (Function.prototype), but unfortunately we cannot do
that without loosing the common prototype for signals and slots.
- bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::~QtInstance):
(JSC::Bindings::QtInstance::newRuntimeObject):
- bridge/qt/qt_instance.h:
(Bindings):
(QtInstance):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::connect):
(JSC::Bindings::QtRuntimeMethod::disconnect):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
(Bindings):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
- bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::name):
(QtRuntimeMethod):
(QtConnectionObject):
Source/WebKit/qt:
Changed semantics of some test expectations. Similarly to r125032 when generating
error exceptions for connect/disconnect, we cannot generate explicit type error
exceptions but only generic errors. Another change is that the meta-method wrapper
doesn't support the call() through Function.prototype anymore. See WebCore changelog
for details.
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::connectAndDisconnect):
(tst_QObjectBridge::objectDeleted):
(tst_QObjectBridge::introspectQtMethods):
- 10:42 AM Changeset in webkit [125427] by
-
- 4 edits in trunk/Source
[Chromium] Fix nits in the find-in-page match rects API
https://bugs.webkit.org/show_bug.cgi?id=93817
Reviewed by Adam Barth.
This patch fixes a few pending nits from 93111.
Source/WebCore:
Tests: existing WebKit unit test WebFrameTest.FindInPageMatchRects
- dom/Range.cpp:
(WebCore::Range::transformFriendlyBoundingBox): add call to updateLayoutIgnorePendingStylesheets.
Source/WebKit/chromium:
- src/FindInPageCoordinates.cpp: replace a pointer by a reference in an output argument.
(WebKit::toNormalizedRect):
(WebKit::findInPageRectFromAbsoluteRect):
- 10:35 AM EFLWebKit edited by
- (diff)
- 9:49 AM Changeset in webkit [125426] by
-
- 9 edits in trunk
Web Inspector: get rid of beforeTextChanged
https://bugs.webkit.org/show_bug.cgi?id=93851
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Merged beforeTextChanged and afterTextChanged into a single
onTextChanged event.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.editRange):
(WebInspector.CodeMirrorTextEditor.prototype._onChange):
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._enterInternalTextChangeMode):
(WebInspector.DefaultTextEditor.prototype._exitInternalTextChangeMode):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.onTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointsBeforeEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.onTextChanged):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.onTextChanged):
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditorDelegate.prototype.onTextChanged):
- inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype.onTextChanged):
LayoutTests:
- http/tests/inspector/live-edit-test.js:
(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest):
- 9:47 AM Changeset in webkit [125425] by
-
- 2 edits in trunk/Source/WebCore
[css] Remove "default" switch case from CSS primitive value mappings
https://bugs.webkit.org/show_bug.cgi?id=93781
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-13
Reviewed by Alexey Proskuryakov.
Removing the "default" switch case allows compile-time early warning check,
specially useful for newly added or removed enumeration values.
- css/CSSPrimitiveValueMappings.h:
- 9:45 AM Changeset in webkit [125424] by
-
- 5 edits in trunk/Source/WebCore
Cap the number of SourceBuffers that may be added to a MediaSource.
https://bugs.webkit.org/show_bug.cgi?id=93406
Reviewed by Eric Carlson.
Make sure that no more SourceBuffer objects are added to a MediaSource
than can fit into the sourceBuffers SourceBufferList (internally stored
as a Vector). Also, make sure that new SourceBuffers are added with a
unique id even if the variable we are using to generate id wraps around.
No new tests. It would not be realistic to add so many SourceBuffers to
test the id variable wrapping. Existing tests should not be affected.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::addSourceBuffer): Obtain a unique id before creating
a new SourceBuffer.
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::SourceBufferList):
(WebCore::SourceBufferList::generateUniqueId): Search for and generate a
unique id.
(WebCore):
(WebCore::SourceBufferList::contains): Check if a SourceBuffer with a
given id already exists in this SourceBufferList.
- Modules/mediasource/SourceBufferList.h:
(SourceBufferList):
- 9:41 AM Changeset in webkit [125423] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Update TestExpectations to make bot green
https://bugs.webkit.org/show_bug.cgi?id=93852
Unreviewed EFL gardening. Update wk2-efl TestExpectations
to make the bot green.
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
- platform/efl-wk2/TestExpectations:
- 9:40 AM Changeset in webkit [125422] by
-
- 5 edits in trunk
[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841
Reviewed by Dimitri Glazkov.
APK generation was broken as the configuration file assumed compilation
would only occur in the Chromium tree. Pass the path to Chromium's source
base directory as a property to ant.
Source/WebKit/chromium:
- WebKitUnitTests.gyp:
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
- 9:36 AM Changeset in webkit [125421] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP][WK2] Missing LocalTerminationDisabler in WebCookieManager::setCookiePersistentStorage()
https://bugs.webkit.org/show_bug.cgi?id=93837
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
Reviewed by Carlos Garcia Campos.
Add missing WebCore::LocalTerminationDisabler in
WebCookieManager::setCookiePersistentStorage() to
temporarily disable process termination.
- WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:
(WebKit::WebCookieManager::setCookiePersistentStorage):
- 8:50 AM Changeset in webkit [125420] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 7:54 AM Changeset in webkit [125419] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: when status bar is too narrow, cut panel status bar, not main status bar items
https://bugs.webkit.org/show_bug.cgi?id=93814
Reviewed by Pavel Feldman.
- set shrink factor of bottom-status-bar-container to 1;
- set bottom-status-bar-container's width to 0 to workaround for flex-basis being ignored;
- inspector/front-end/inspector.css:
(#bottom-status-bar-container):
- 7:19 AM Changeset in webkit [125418] by
-
- 2 edits in trunk/Tools
[WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
https://bugs.webkit.org/show_bug.cgi?id=93825
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-13
Reviewed by Antonio Gomes.
Corrected from didFinishLoadForResource() invoke to didFailLoadForResource() invoke.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailLoadForResource):
- 6:43 AM Changeset in webkit [125417] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, updating test expectation for
canvas/philip/tests/2d.drawImage.self.2.html to note that
bug #93244 tracks the regression.
- platform/gtk/TestExpectations:
- 6:31 AM Changeset in webkit [125416] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip a failing test.
- platform/qt/Skipped:
- platform/qt/TestExpectations:
- 6:24 AM Changeset in webkit [125415] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: add memory instrumentation for Attribute
https://bugs.webkit.org/show_bug.cgi?id=93827
Reviewed by Pavel Feldman.
Attribute's name and value footprint is counted as part of the DOM
component.
- dom/Attribute.h:
(WebCore::Attribute::reportMemoryUsage):
(Attribute):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):
- 6:19 AM Changeset in webkit [125414] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13
- DEPS:
- 5:58 AM Changeset in webkit [125413] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Polish search/replace toolbar buttons style.
https://bugs.webkit.org/show_bug.cgi?id=93826
Reviewed by Pavel Feldman.
- inspector/front-end/inspector.css:
(.toolbar-search button):
- 5:35 AM Changeset in webkit [125412] by
-
- 4 edits1 add in trunk/LayoutTests
[EFL] fast/box-sizing/box-sizing.html needs new baseline after r124347
https://bugs.webkit.org/show_bug.cgi?id=93823
Unreviewed EFL gardening.
Provide new baseline for fast/box-sizing/box-sizing.html,
needed after r124347.
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/fast/box-sizing/box-sizing-expected.png:
- platform/efl/fast/box-sizing/box-sizing-expected.txt: Added.
- 5:07 AM Changeset in webkit [125411] by
-
- 6 edits1 add in trunk
[Qt] Add gprof.prf to build WebKit with gprof enabled
https://bugs.webkit.org/show_bug.cgi?id=90283
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-13
Reviewed by Eric Seidel.
Source/WebCore:
No behavior change, so no new tests.
- WebCore.pri:
-ffunction-sections conflicts with -pg option, so don't use
-ffunction-sections option when gprof is enabled.
Source/WebKit/qt:
- tests/MIMESniffing/MIMESniffing.pro:
Don't build MIMESniffing.cpp because MIMESniffing test links
WebKitQt statically when gprof is enabled.
Tools:
- qmake/mkspecs/features/functions.prf:
gprof does not support profiling a shared library.
To profile WebKit, applications must link QtWebKit statically.
- qmake/mkspecs/features/gprof.prf: Added.
Add -pg option to both QMAKE_CXXFLAGS and QMAKE_LFLAGS.
- 5:00 AM Changeset in webkit [125410] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r125408, removing another usage of SVG_FEATURES.
- GNUmakefile.am:
- 4:54 AM Changeset in webkit [125409] by
-
- 3 edits in trunk/LayoutTests
[EFL][WK2] Skip inspector tests that hit assertion in WebCore::SuspendableTimer::resume()
https://bugs.webkit.org/show_bug.cgi?id=93815
Unreviewed EFL gardening.
Update TestExpectations for several flaky Web Inspector
test cases.
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:42 AM Changeset in webkit [125408] by
-
- 4 edits in trunk
[Gtk] Remove SVG_FEATURES and HTML_FEATURES from Source/WebCore/GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=90693
Reviewed by Philippe Normand.
.:
Remove exportation of SVG_FLAGS and HTML_FLAGS as Automake conditionals
as they are not required anymore.
- configure.ac:
Source/WebCore:
Remove SVG_FEATURES and HTML_FEATURES variables. They can be replaced by the
FEATURE_DEFINES variable wherever they are used.
No new tests - no new functionality.
- GNUmakefile.am:
- 4:38 AM WebKitGTK/1.8.x edited by
- (diff)
- 3:35 AM Changeset in webkit [125407] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
https://bugs.webkit.org/show_bug.cgi?id=93600
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-08-13
Reviewed by Xan Lopez.
Instead of using the default editing signal handler for ::should-show-delete-interface-for-element,
do not use a default signal handler. This means that the result of the signal defaults to FALSE,
which is the expected value to ensure that the delete interface is not shown.
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init): Do not install a default signal handler.
- 3:16 AM Changeset in webkit [125406] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 3:15 AM Changeset in webkit [125405] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Wrong TestExpectations for 2 webintents tests
https://bugs.webkit.org/show_bug.cgi?id=93811
Unreviewed EFL gardening.
Update expected state for the following webintents tests
to make the tree green:
webintents/web-intents-invoke-port.html
webintents/web-intents-obj-constructor.html
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
- platform/efl-wk2/TestExpectations:
- 3:01 AM Changeset in webkit [125404] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing/crashing tests.
- platform/qt/Skipped:
- platform/qt/TestExpectations:
- 2:42 AM Changeset in webkit [125403] by
-
- 4 edits in trunk/Source
[GTK] Implementation of atk_editable_text_insert_text ignores 'length' parameter
https://bugs.webkit.org/show_bug.cgi?id=93804
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Use the 'length' parameter to insert a substring of the full
string passed to this method from AtkEditableText interface.
- accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp:
(webkitAccessibleEditableTextInsertText): Don't ignore 'length'.
Source/WebKit/gtk:
Update unit tests to also check inserting a partial string.
- tests/testatk.c:
(testWebkitAtkTextChangedNotifications): Update test.
- 2:33 AM Changeset in webkit [125402] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Feature Request - Adding mouse gesture for editing attribute values in elements/css panel
https://bugs.webkit.org/show_bug.cgi?id=93581
Patch by Sam D <dsam2912@gmail.com> on 2012-08-13
Reviewed by Alexander Pavlov.
Added functionality to modify valuesAdding support for updating number values in attributes in element
panel/ css panel using mouse gestures as well.
No new tests.
- inspector/front-end/StylesSidebarPane.js:
handling mousewheel event
- inspector/front-end/TextPrompt.js:
adding mouse event listener
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype.onMouseWheel):
- inspector/front-end/UIUtils.js:
handling mouse event gesture and updating number based on mouse wheel
scroll direction as well.
(WebInspector._valueModificationDirection):
(WebInspector._modifiedHexValue):
(WebInspector._modifiedFloatNumber):
(WebInspector.handleElementValueModifications):
- 2:29 AM Changeset in webkit [125401] by
-
- 2 edits in trunk/Tools
[TestNetscapePlugin][X11] Additional key up event handler routine is required
https://bugs.webkit.org/show_bug.cgi?id=91357
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-13
Reviewed by Eric Seidel.
Fixed key up event handler routine to pass http/tests/plugins/plugin-document-
has-focus.html on X11 architecture. The test can not be done without this patch.
All other ports implemented it already.
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventX11): Modified key up event handler for X11
- 2:28 AM Changeset in webkit [125400] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix make distcheck.
- GNUmakefile.list.am: Add missing header file.
- 2:06 AM Changeset in webkit [125399] by
-
- 16 edits in trunk
Web Inspector: [Protocol] Force elements pseudo state via a separate InspectorCSSAgent method
https://bugs.webkit.org/show_bug.cgi?id=93721
Reviewed by Pavel Feldman.
Source/WebCore:
Introduce InspectorCSSAgent::forcePseudoState() to modify the element's forced pseudo state.
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.forcePseudoState):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._setPseudoClassForNodeId):
- inspector/front-end/MetricsSidebarPane.js:
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
LayoutTests:
- http/tests/inspector/modify-cross-domain-rule.html:
- inspector/styles/get-set-stylesheet-text.html:
- inspector/styles/styles-formatting.html:
- inspector/styles/styles-new-API.html:
- inspector/styles/styles-new-API-expected.txt:
- 1:26 AM Changeset in webkit [125398] by
-
- 3 edits1 add1 delete in trunk
[EFL][WK2] Replace Skipped list by TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=93796
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.
Tools:
Enable cascaded TestExpectations for EFL port so
that we can use TestExpectations in WK2-EFL.
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._search_paths):
(EflPort):
(EflPort.expectations_files):
LayoutTests:
Replace efl-wk2 Skipped file by TestExpectations now
that we support cascaded TestExpectations in EFL
port.
- platform/efl-wk2/Skipped: Removed.
- platform/efl-wk2/TestExpectations: Added.
- 1:22 AM Changeset in webkit [125397] by
-
- 5 edits2 adds in trunk
Cannot select the AuthorShadowDOM inner element of an img element
https://bugs.webkit.org/show_bug.cgi?id=91591
Reviewed by Dimitri Glazkov.
Source/WebCore:
Since HTMLImageElement::canStartSelection always returns false, we cannot start selection
from any children (including shadow dom) of an img element. When the img element has a shadow dom,
we should be able to start selection.
Test: fast/dom/shadow/select-image-with-shadow.html
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::canStartSelection):
(WebCore):
- html/HTMLImageElement.h:
(HTMLImageElement):
- html/shadow/ImageInnerElement.h:
(WebCore::ImageInnerElement::canStartSelection): Since ImageInnerElement is really an image,
this should return always false to obey the exising behavior.
(ImageInnerElement):
LayoutTests:
- fast/dom/shadow/select-image-with-shadow-expected.txt: Added.
- fast/dom/shadow/select-image-with-shadow.html: Added.
- 1:11 AM Changeset in webkit [125396] by
-
- 2 edits in trunk/Tools
REGRESSION(r125153): It broke the 'Unexpected no expected results' case
https://bugs.webkit.org/show_bug.cgi?id=93789
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-08-13
Reviewed by Csaba Osztrogonác.
Fix the regex, so the text won't be a capturing group.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests._parseNewRunWebKitTestsOutput):
- 12:52 AM Changeset in webkit [125395] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening. Add expectations for flaky tests.
- platform/chromium/TestExpectations:
- 12:19 AM Changeset in webkit [125394] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r124723-r124741): 5 inspector/debugger tests failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93387
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-13
Reviewed by Pavel Feldman.
Now the front-end has problem when setting the positon of breakpoint, so remove the comparing
of "column" to make the behavior back to the time as JSC cannot provide "column" info.
Refer to https://bugs.webkit.org/show_bug.cgi?id=93473.
No new test case for this bug.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::hasBreakpoint):
Aug 12, 2012:
- 11:55 PM Changeset in webkit [125393] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r125392.
http://trac.webkit.org/changeset/125392
https://bugs.webkit.org/show_bug.cgi?id=93797
Simple rebaseline won't work. Need further investigation.
(Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-12
- inspector/console/console-format-collections-expected.txt:
- 11:48 PM Changeset in webkit [125392] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: rebaselined inspector/console/console-format-collections.html after r125284.
https://bugs.webkit.org/show_bug.cgi?id=93748
- inspector/console/console-format-collections-expected.txt:
- 11:21 PM Changeset in webkit [125391] by
-
- 21 edits in trunk/Source
Support creating File object from FileSystem URL for files in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=93706
Reviewed by Darin Fisher.
Source/Platform:
- chromium/public/WebBlobData.h:
- chromium/public/WebHTTPBody.h:
(WebHTTPBody):
Source/WebCore:
Current File code assumes the existence of local file (i.e. requires a platform local file path) but for FileSystem
files it may not be always the case. For example some implementation may want to use in-memory filesystem to realize
sandboxed filesystem, or others may have the filesystem in remote servers.
This patch adds basic support for making File object constructible not only from a file path but from a FileSystem URL.
Since File can be appended to FormData or included in another Blob this patch also extends BlobData and FormData to support URL.
FileChooser and Drag-and-drop changes are not included in this patch.
No new tests: will add tests when we implement the platform side changes to wire this change.
- Modules/filesystem/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createFile):
- Modules/filesystem/DOMFileSystemSync.cpp:
(WebCore::DOMFileSystemSync::createFile):
- fileapi/Blob.cpp:
(WebCore::Blob::sliceInternal):
- fileapi/File.cpp:
(WebCore::createBlobDataForFileSystemURL): Added.
(WebCore::File::File):
- fileapi/File.h:
(WebCore::File::createForFileSystemFile):
(WebCore::File::fileSystemURL): Added.
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):
- platform/chromium/support/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendURL): Added.
(WebKit::WebHTTPBody::appendURLRange): Added.
(WebKit::WebHTTPBody::appendBlob):
- platform/network/BlobData.cpp:
(WebCore::BlobData::appendURL):
- platform/network/BlobData.h:
(BlobDataItem):
(WebCore::BlobDataItem::BlobDataItem):
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::BlobRegistryImpl::registerBlobURL):
- platform/network/FormData.cpp:
(WebCore::FormData::deepCopy):
(WebCore::FormData::appendURL): Added.
(WebCore::FormData::appendURLRange): Added.
(WebCore::FormData::appendKeyValuePairItems):
- platform/network/FormData.h:
(WebCore::FormDataElement::FormDataElement):
(FormDataElement):
(WebCore::operator==):
Source/WebKit/chromium:
- src/WebBlobData.cpp:
(WebKit::WebBlobData::itemAt):
- 10:21 PM Changeset in webkit [125390] by
-
- 2 edits in trunk/Tools
Unreviewed, added a proxy address to contributors_who_are_not_committers.
- Scripts/webkitpy/common/config/committers.py:
- 9:36 PM Changeset in webkit [125389] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/11442485> off-screen or inactive pages can change the mouse pointer
Reviewed by Adele Peterson.
- page/EventHandler.cpp:
(WebCore::EventHandler::fakeMouseMoveEventTimerFired): Added a check that the page is
on-screen and active before dispatching the fake mouse event.
- 9:35 PM Changeset in webkit [125388] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] use MediaPlayer::userAgent() in MediaPlayerPrivateBlackBerry to avoid layering violation
https://bugs.webkit.org/show_bug.cgi?id=93588
Patch by Jonathan Dong <Jonathan Dong> on 2012-08-12
Reviewed by Antonio Gomes.
Removed helper function MediaPlayerPrivate::userAgent() which has
introduced abstraction layering violation and replaced with
MediaPlayer::userAgent().
No new tests since there's no functional change.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::load):
- 9:23 PM Changeset in webkit [125387] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed. Update TestExpectations so it matches the recent results.
- platform/chromium/TestExpectations:
- 9:16 PM Changeset in webkit [125386] by
-
- 5 edits in trunk/Source/WebCore
Record metrics to measure the usage of WebKitBlobBuilder to eventually deprecate it
https://bugs.webkit.org/show_bug.cgi?id=90535
Reviewed by Eric Seidel.
No new tests as this has no functional changes.
- bindings/js/JSBlobCustom.cpp:
(WebCore::JSBlobConstructor::constructJSBlob):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::getBlob):
- fileapi/WebKitBlobBuilder.h:
(WebKitBlobBuilder):
- 8:55 PM Changeset in webkit [125385] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Fix Chromium's Android build.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::find): Needs parentheses for a function call.
- 5:14 PM Changeset in webkit [125384] by
-
- 3 edits in trunk/Source/WebCore
Remove unnecessary null checks from pseudoStyleForElement and adjustRenderStyle
https://bugs.webkit.org/show_bug.cgi?id=93730
Reviewed by Tony Chang.
All the callers of both methods make sure to pass in a non-null parentStyle.
No change in behavior.
- css/StyleResolver.cpp:
- css/StyleResolver.h:
- 4:13 PM Changeset in webkit [125383] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new tests without expected results.
- platform/qt/Skipped:
- 4:01 PM Changeset in webkit [125382] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Tap highlight flashes checkerboard after pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=93601
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-12
Reviewed by Antonio Gomes.
Since the tap highlight is usually rather small, we can reimplement
GraphicsLayerClient::contentsVisible() to always return true in order
to keep all AC layer tiles cached all the time.
PR 189895
- WebKitSupport/DefaultTapHighlight.cpp:
(BlackBerry::WebKit::DefaultTapHighlight::contentsVisible):
(WebKit):
- WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):
- 3:59 PM Changeset in webkit [125381] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Tap highlight sometimes doesn't disappear
https://bugs.webkit.org/show_bug.cgi?id=93711
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-12
Reviewed by Antonio Gomes.
The WebOverlayOverride implementation just changes properties of a
LayerCompositingThread directly, which means the changes will
immediately be overwritten on the next commit. Therefore, when the tap
highlight implementation adds a fade out animation, that animation will
instantly be removed again if a commit happens for any reason.
The reason is I totally botched the implementation of
WebOverlayOverride, it's not wrapping WebCore::LayerOverride at all,
instead for some reason it's manipulating the LayerCompositingThread
directly.
Fixed by actually mapping WebOverlayOverride calls to the corresponding
WebCore::LayerOverride method, and scheduling a compositing run to make
the change visible and kick off animations.
Reviewed internally by Sean Wang.
PR 188453
- Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivate::override):
- Api/WebOverlayOverride.cpp:
(BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::~WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::setPosition):
(BlackBerry::WebKit::WebOverlayOverride::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayOverride::setSize):
(BlackBerry::WebKit::WebOverlayOverride::setTransform):
(BlackBerry::WebKit::WebOverlayOverride::setOpacity):
(BlackBerry::WebKit::WebOverlayOverride::addAnimation):
(BlackBerry::WebKit::WebOverlayOverride::removeAnimation):
- Api/WebOverlayOverride.h:
- Api/WebOverlay_p.h:
(WebOverlayPrivate):
(WebOverlayPrivateWebKitThread):
(WebOverlayPrivateCompositingThread):
- 11:14 AM Changeset in webkit [125380] by
-
- 4 edits2 adds in trunk
table cell.cellIndex should return -1 if there is no parent table
https://bugs.webkit.org/show_bug.cgi?id=93738
Patch by Pravin D <pravind.2k4@gmail.com> on 2012-08-12
Reviewed by Eric Seidel.
Source/WebCore:
According to the HTML5 spec the cellIndex of a table cell(td/th) whose parent is not a table row
must be -1. Currently we are returning zero. This patch fixes this behavior.
Test: fast/table/cellIndex-of-cell-with-different-parents.html
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::cellIndex):
If the parent of the cell is not a table row, -1 is returned. Otherwise a value greater
than or equal to zero is return.
- rendering/RenderTableCell.h:
(RenderTableCell):
Removed dead code and made minor webkit style related fix.
LayoutTests:
- fast/table/cellIndex-of-cell-with-different-parents-expected.txt: Added.
- fast/table/cellIndex-of-cell-with-different-parents.html: Added.
- 11:05 AM Changeset in webkit [125379] by
-
- 9 edits4 adds in trunk/Source
[Chromium] Implement the find-in-page match rects API
https://bugs.webkit.org/show_bug.cgi?id=93111
Reviewed by Adam Barth.
Source/WebCore:
Introduce the find-in-page coordinate system. This system tries to solve
the unintuitive tickmark results presented in pages with multiple frames
and scrolled contents where the find results might not be in the visible
area of a frame, which might lead to tickmarks below the container frame.
To achieve this, this coordinate system goes up the render tree
normalizing the coordinates by the actual contents size of its container.
This leads to tickmarks scaled to the visible size of their frame
independently of its scroll. This coordinate system supports also CSS
scroll:overflow, transforms and the different positions.
Also add an auxiliary method to Range in order to provide a transform
friendly way to retrieve the absolute coordinates of the enclosing
bounding box without the adjustment operations that the existing
enclosingRect method does.
Tested by WebFrameTest WebKit unit test.
- dom/Range.cpp:
(WebCore::Range::transformFriendlyBoundingBox): add a transform-friendly equivalent of boundingBox.
(WebCore):
- dom/Range.h: move boundingBox to the group of non-transform-friendly methods.
(Range):
Source/WebKit/chromium:
Implement the funcionality of the find-in-page match rects API in WebFrame.
These methods keep a cache of the match rects in a special coordinate system
(find-in-page coordinates) and update them on size changes. They also allow
to recover the match closest to a given point, therefore enabling to move
to find matches when tapping on their corresponding tickmarks.
- WebKit.gyp: add FindInPageCoordinates.h / cpp.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::contentsSizeChanged): propagate didChangeContentsSize to WebFrameImpl.
- src/FindInPageCoordinates.cpp: Added.
(WebKit):
(WebKit::toNormalizedRect): auxiliary internal function.
(WebKit::findInPageRectFromAbsoluteRect): main coordinate conversion function.
(WebKit::findInPageRectFromRange): convenience conversion function for Ranges.
- src/FindInPageCoordinates.h: Added.
(WebCore):
(WebKit):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::FindMatch::FindMatch): find matches cache constructor.
(WebKit):
(WebKit::WebFrameImpl::find): clear match cache when appropriate and zoom into results on the Android port.
(WebKit::WebFrameImpl::stopFinding): clear matches cache.
(WebKit::WebFrameImpl::scopeStringMatches): add new results to the matches cache.
(WebKit::WebFrameImpl::increaseMatchCount): update the matches cache version.
(WebKit::WebFrameImpl::resetMatchCount): update the matches cache version.
(WebKit::WebFrameImpl::findMatchMarkersVersion): new API providing the matches cache version.
(WebKit::WebFrameImpl::clearFindMatchesCache): internal utility method to reset the matches cache.
(WebKit::WebFrameImpl::isActiveMatchFrameValid): internal utility method to check if the local frame is still in the frame tree.
(WebKit::WebFrameImpl::updateFindMatchRects): internal utility method to update the match result rects if required.
(WebKit::WebFrameImpl::activeFindMatchRect): new API providing the active find match rect in find-in-page coordinates.
(WebKit::WebFrameImpl::findMatchRects): new API returning the valid match rects in find-in-page coordinates.
(WebKit::WebFrameImpl::appendFindMatchRects): internal utility method to concatenate the match results of multiple frames.
(WebKit::WebFrameImpl::selectNearestFindMatch): new API selecting the find match closer to a point in find-in-page coordinates.
(WebKit::WebFrameImpl::nearestFindMatch): internal utility method to find the nearest find match to a point in a frame.
(WebKit::WebFrameImpl::selectFindMatch): internal utility method to select a match in the cache.
(WebKit::WebFrameImpl::WebFrameImpl): initialization of new variables.
(WebKit::WebFrameImpl::didChangeContentsSize): invalidate the cached match rect coordinates on frame content size changes.
- src/WebFrameImpl.h:
(WebCore):
(WebFrameImpl):
(WebKit::WebFrameImpl::activeMatchFrame): remove unrequired const.
(WebKit::WebFrameImpl::activeMatch): expose the range of the active match to allow testing.
(FindMatch): cache structure for find matches.
- tests/WebFrameTest.cpp: new test case for find-in-page match rects.
- tests/data/find_in_page.html: Added. Test case layout.
- tests/data/find_in_page_frame.html: Added. Test case layout.
- 10:40 AM Changeset in webkit [125378] by
-
- 2 edits in trunk/Source/WebCore
Stop Y-flipping CROS/ARM video textures
https://bugs.webkit.org/show_bug.cgi?id=93769
Reviewed by Eric Seidel.
No new tests; there's no cros/arm bot yet, sadly.
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads): drop the single-platform Y-flipping in prep for the platform doing the flip natively.
- 9:52 AM Changeset in webkit [125377] by
-
- 16 edits in trunk
[Qt] Make it possible to build without QtTest/QtPrintSupport
https://bugs.webkit.org/show_bug.cgi?id=93492
Patch by Loïc Yhuel <loic.yhuel@softathome.com> on 2012-08-12
Reviewed by Tor Arne Vestbø.
.:
- Source/QtWebKit.pro: Disable tests if no testlib
Source/WebKit:
- WebKit1.pri: Optional printsupport
Source/WebKit/qt:
- Api/qwebframe.cpp:
(QWebFrame::print): Does nothing if no printsupport
- Api/qwebview.cpp:
(QWebView::print): Does nothing if no printsupport
Tools:
- DumpRenderTree/qt/DumpRenderTree.pro: Optional printsupport
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore):
(WebCore::DumpRenderTree::dryRunPrint): Does nothing if no printsupport
- QtTestBrowser/QtTestBrowser.pro: Optional printsupport
- QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome): No print menu if no printsupport
(LauncherWindow::print): Does nothing if no printsupport
- QtTestBrowser/launcherwindow.h:
- Tools.pro: Disable DRT/WTR if QtTest not present
- qmake/mkspecs/features/default_pre.prf: printsupport no more mandatory
- qmake/mkspecs/features/features.prf: Qt module availability tests
- 8:57 AM Changeset in webkit [125376] by
-
- 6 edits2 adds in trunk
CSSRegions: Crash when using style in region for removed element.
https://bugs.webkit.org/show_bug.cgi?id=93276
Reviewed by Abhishek Arya.
Source/WebCore:
When a RenderInline object from within a render flow thread is split, the cloned
hierarchy built during the split process does not have the inRenderFlowThread bit
set properly. If the cloned hierarchy is flowed into a region with region style rules,
we compute the style in region also for objects that do not have inRenderFlowThread bit
set and we store the computed style in region for caching purposes. But we only remove
an object style in region information if that object has the inRenderFlowThread bit set.
Under these circumstances, it is possible to remove a object with cached style in region
and without inRenderFlowThread bit set from the render tree and leave the associated cached
information un-removed. Such information will be accesses during the next paint phase of
the region, thus resulting a crash.
The fix is to modify RenderBlock::clone() and RenderInline::clone() functions to also copy the inRenderFlowThread bit
from the source into the clone, therefore the cloned hierarchies will have the inRenderFlowThread
bit set properly.
Test: fast/regions/removed-element-style-in-region-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clone): Replace former static RenderInline::cloneInline with member RenderInline::clone.
(WebCore::RenderInline::splitInlines):
- rendering/RenderInline.h:
(RenderInline):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setObjectStyleInRegion):
Added an assert to make sure that when we are computing style in region, we are doing for objects
with inRenderFlowThread set. Also, bail out early in this case to prevent further crashes.
LayoutTests:
Added test reproducing the problem.
- fast/regions/removed-element-style-in-region-crash-expected.txt: Added.
- fast/regions/removed-element-style-in-region-crash.html: Added.
- 8:46 AM Changeset in webkit [125375] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Skip webintents/web-intents-obj-constructor.html test
https://bugs.webkit.org/show_bug.cgi?id=93778
Unreviewed EFL gardening.
Skip webintents/web-intents-obj-constructor.html for
WebKit2 EFL until WTR can print information about the
MessagePorts in a Web Intent (Bug 89072).
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-12
- platform/efl-wk2/Skipped:
- 5:12 AM Changeset in webkit [125374] by
-
- 3 edits in trunk/Source/WebCore
Set the access qualifier of two methods to query frame specific info of BitmapImage to protected.
https://bugs.webkit.org/show_bug.cgi?id=90505
Patch by Huang Dongsung <luxtella@company100.net> on 2012-08-12
Reviewed by Eric Seidel.
Following 4 methods are protected.
size_t frameCount();
NativeImagePtr frameAtIndex(size_t);
bool frameIsCompleteAtIndex(size_t);
float frameDurationAtIndex(size_t);
So, 2 methds also should be protected because the frame info is only specific of
BitmapImage.
bool frameHasAlphaAtIndex(size_t);
ImageOrientation frameOrientationAtIndex(size_t);
On the other hand, this patch amended GraphicsContext3DCG.
- static_cast<BitmapImage*>(image)->frameHasAlphaAtIndex(0)
+ image->currentFrameHasAlpha()
This patch does not affect PNG, JPEG, BMP, and WEBP because those images
have only 0 indexed frame.
Thus, GIF, and ICO are affected. However, an above query to get Alpha
is for the image that is created by image->nativeImageForCurrentFrame(), so it
is proper to use image->currentFrameHasAlpha() instead of
image->frameHasAlphaAtIndex(0).
No new tests, because it is hard to test. We need an animated GIF that
one frame has alpha and another frame does not have alpha. However, I
cannot find the animated GIF file that suffices the requirement.
- platform/graphics/BitmapImage.h:
(BitmapImage):
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::getImageData):
- 4:47 AM Changeset in webkit [125373] by
-
- 3 edits in trunk/Source/JavaScriptCore
Doesn't build with ENABLE_JIT=0
https://bugs.webkit.org/show_bug.cgi?id=85042
Reviewed by Eric Seidel.
Include headers without which CallFrame.h does not build, and
fix gcc warning about comparing unsigned int with 0.
- dfg/DFGDriver.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::isOpcode):
- 4:38 AM Changeset in webkit [125372] by
-
- 2 edits in trunk/Tools
master.cfg unittest cleanup: Show DeprecationWarnings with python >= 2.7 too
https://bugs.webkit.org/show_bug.cgi?id=90161
Reviewed by Eric Seidel.
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
- 4:38 AM Changeset in webkit [125371] by
-
- 4 edits2 deletes in trunk
webkit fails IETC namespaces/prefix-007.xml
https://bugs.webkit.org/show_bug.cgi?id=86137
Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-12
Reviewed by Eric Seidel.
Source/WebCore:
If a namespace prefix or default namespace is declared more than once
only the last declaration shall be used.
parseAddNamespace doesn't check return value of WTF::HashMap<>::add.
If the return value's isNewEntry is true, the new entry is added with
the specified value. However, if isNewEntry is false, it is required
to update the store value.
No new tests. ietestcenter/css3/namespaces/prefix-007.xml and
ietestcenter/css3/namespaces/prefix-010.xml covers this change.
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parserAddNamespace):
Modified to check m_namespaces.add's return value.
If the result says not a new entry, updated the value stored in
m_namespaces by using iterator in the result.
LayoutTests:
- platform/chromium/TestExpectations:
Enabled the layout tests, ietestcenter/css3/namespaces/prefix-007.xml
and ietestcenter/css3/namespaces/prefix-010.xml.
- platform/win/ietestcenter/css3/namespaces/prefix-007-expected.txt: Removed.
- platform/win/ietestcenter/css3/namespaces/prefix-010-expected.txt: Removed.
Removed old expectations.
- 4:29 AM Changeset in webkit [125370] by
-
- 4 edits in trunk/Source/WebKit2
Fix build with recent clang.
https://bugs.webkit.org/show_bug.cgi?id=90701
Patch by Nuno Lopes <nlopes@apple.com> on 2012-08-12
Reviewed by Eric Seidel.
- Shared/CommandLine.h:
(CommandLine):
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::NotificationPermissionRequestManager):
- WebProcess/Notifications/NotificationPermissionRequestManager.h:
(NotificationPermissionRequestManager):
- 4:26 AM Changeset in webkit [125369] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL][UT] Delete shutdown method.
https://bugs.webkit.org/show_bug.cgi?id=90785
Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-08-12
Reviewed by Eric Seidel.
EWKTestBase class already has a shutdownAll method that can be used instead of shutdown.
- tests/UnitTestUtils/EWKTestBase.cpp:
- tests/UnitTestUtils/EWKTestBase.h:
(EWKTestBase):
- 3:39 AM Changeset in webkit [125368] by
-
- 2 edits in trunk/Source/WebCore
Move CSS's propertyNameStrings[] to from the header to the cpp file
https://bugs.webkit.org/show_bug.cgi?id=93771
Reviewed by Eric Seidel.
The names of propertyNameStrings[] should never be accessed directly. The function getPropertyName()
return the correct string of propertyNameStrings.
To ensure the values are not accessed by mistake, move them from the header to the implementation.
- css/makeprop.pl:
- 3:37 AM Changeset in webkit [125367] by
-
- 2 edits in trunk/Source/WebCore
CSSComputedStyleDeclaration::cssText() should use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=93776
Reviewed by Eric Seidel.
String::append() is fairly inefficient when used to create a long string by appending a lot of small
pieces. StringBuilder is more approriate for the kind of operations done by CSSComputedStyleDeclaration::cssText().
This changes makes CSSComputedStyleDeclaration::cssText() about 6 times faster.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::cssText):
- 12:32 AM Changeset in webkit [125366] by
-
- 4 edits in branches/safari-536.26-branch/Source
Versioning.
- 12:18 AM Changeset in webkit [125365] by
-
- 4 edits in trunk/Tools
[Qt] Unreviewed trivial build fix: Newer Qt versions don't implicitly include qwindowsysteminterface.h
through the QTestLib headers anymore.
- DumpRenderTree/qt/EventSenderQt.cpp:
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
Aug 11, 2012:
- 11:10 PM Changeset in webkit [125364] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build.
- Platform/CoreIPC/Connection.h:
Add missing include.
- 11:09 PM Changeset in webkit [125363] by
-
- 14 edits7 deletes in trunk/Source/WebKit2
[WK2] Get rid of ProcessModelSharedSecondaryThread
https://bugs.webkit.org/show_bug.cgi?id=93652
Reviewed by Dan Bernstein.
The threaded model for WebKit2 has been broken a long time and its continued existence in
the code only serves to confuse. It's time to say good bye to it.
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/WKContextPrivate.h:
Remove WKContextGetSharedThreadContext().
- UIProcess/ProcessModel.h:
Remove ProcessModelSharedSecondaryThread from the ProcessModel enum.
- UIProcess/WebContext.cpp:
- UIProcess/WebContext.h:
Remove WebContext::sharedThreadContext().
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::connect):
(WebKit::WebProcessProxy::isLaunching):
- UIProcess/WebProcessProxy.h:
Remove the ThreadLauncher member and stop deriving from ThreadLauncher::Client.
- UIProcess/Launcher/ThreadLauncher.cpp: Removed.
- UIProcess/Launcher/ThreadLauncher.h: Removed.
- UIProcess/Launcher/efl/ThreadLauncherEfl.cpp: Removed.
- UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp: Removed.
- UIProcess/Launcher/mac/ThreadLauncherMac.mm: Removed.
- UIProcess/Launcher/qt/ThreadLauncherQt.cpp: Removed.
- UIProcess/Launcher/win/ThreadLauncherWin.cpp: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- CMakeLists.txt:
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- Target.pri:
Remove ThreadLauncher files.
- 10:56 PM Changeset in webkit [125362] by
-
- 7 edits3 deletes in trunk/Tools
Remove ability to run MiniBrowser in threaded mode, it hasn't worked for a long time
https://bugs.webkit.org/show_bug.cgi?id=93774
Reviewed by Dan Bernstein.
Remove support for opening windows using the shared thread WKContextRef. WKContextGetSharedThreadContext()
is going away, due to not working for a long time, and the first step is removing all the callers.
While here, remove the BrowserStatisticsWindow, which was not providing interesting information.
- MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
- MiniBrowser/mac/AppDelegate.h:
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
- MiniBrowser/mac/BrowserStatisticsWindow.xib: Removed.
- MiniBrowser/mac/BrowserStatisticsWindowController.h: Removed.
- MiniBrowser/mac/BrowserStatisticsWindowController.m: Removed.
- MiniBrowser/mac/MainMenu.xib:
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
- 10:29 PM Changeset in webkit [125361] by
-
- 7 edits in trunk
Enable XPC Service based WebProcess with runtime flag
https://bugs.webkit.org/show_bug.cgi?id=93773
Reviewed by Dan Bernstein.
Source/WebKit2:
Use the XPC Service for WebProcess code path if WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS
is set in the environment.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::launchXPCService):
Fix issue that was causing this code not to compile. This was not caught before since
the code was not being built.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connect):
Switch from hard coding always using the XPC Service code path if
HAVE(XPC) was true, to doing it conditionally on an environment variable.
Source/WTF:
- wtf/Platform.h:
Define HAVE_XPC on 10.7 and later.
Tools:
Convert --use-web-process-xpc-service passed to run-safari (and similar scripts)
to setting WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS=YES in the environment and setting
up XPC_DYLD_FRAMEWORK_PATH and XPC_DYLD_INSERT_LIBRARIES variables. NOTE: using
the XPC service is not the default code path.
- Scripts/webkitdirs.pm:
(shouldUseXPCServiceForWebProcess):
(determineShouldUseXPCServiceForWebProcess):
Add functions to extract --use-web-process-xpc-service from ARGV and set a
global variable.
(printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
Add help text for --use-web-process-xpc-service.
(runMacWebKitApp):
Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
if --use-web-process-xpc-service was passed on the command line.
(execMacWebKitAppForDebugging):
Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
if --use-web-process-xpc-service was passed on the command line. Also, bail
if both --use-web-process-xpc-service and --target-web-process are passed on
the command line, as we don't currently support using both.
- 9:52 PM Changeset in webkit [125360] by
-
- 1 copy in tags/Safari-536.26.5
New Tag.
- 9:51 PM Changeset in webkit [125359] by
-
- 4 edits in branches/safari-536.26-branch/Source
Versioning.
- 5:00 PM Changeset in webkit [125358] by
-
- 13 edits1 move4 adds in trunk/Source/WebKit2
Make it possible to run the WebProcess as an XPC service
https://bugs.webkit.org/show_bug.cgi?id=92814
Reviewed by Anders Carlsson.
In this initial implementation, we are only using the XPC service
to launch the WebProcess, and then using the xpc_connection to send
over a mach_port to the WebProcess which is then used for creating
the CoreIPC connection. In the future, we will switch to using the
xpc_connection for all messaging.
When the XPC service is enabled (it is compiled out by default for now), both
the XPC service and the old spawned process are runtime choosable. This allows
the connect to pre-existing process workflow to continue to work.
There are a few additional caveats of this initial implementation:
- It is only set up for the WebProcess (not for the PluginProcess)
- The WebProcess shim does not work.
- It requires a new environment variable to be set when launching to find the right service to launch (XPC_DYLD_FRAMEWORK_PATH).
- Configurations/WebKit2Service.xcconfig: Added.
Add new configuration file for the service.
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::Identifier::Identifier):
(CoreIPC::Connection::identifierIsNull):
Added to encapsulate the concept of a null identifier, now that it
is not possible to just compare to null.
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::platformInitialize):
Change Connection::Identifier on the Mac to be a struct instead of
a typedef to a mach_port. This allows for the Connection to get both
the listening port and a reference to the xpc_connection (if it
compiled in). For now, all we do is retain the xpc_connection when it
is given to us, and release on Connection invalidation.
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::createWebProcessConnection):
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Use the Connection::Identifier constructor.
- UIProcess/Launcher/ProcessLauncher.h:
(LaunchOptions):
Add a UseXPC option to the LaunchOptions so we can dynamically choose whether to use it.
(ProcessLauncher):
Make processTypeAsString public to allow better factoring in the implementation file
using static functions.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
Factor out the different launching options into helper functions. Always start by
trying to connect to a pre-existing process.
(WebKit::launchXPCService):
Create a new xpc_connection to our service, and give it a unique instance UUID.
Then, send a bootstrap message with a mach_port and wait for a reply to complete
the launch procedure.
(WebKit::tryPreexistingProcess):
Move the code to connect to a preexisting process to its own helper function.
(WebKit::ProcessLauncher::launchProcess):
Clean up a bit, calling the helper functions and adding call to launch the XPC service
if it is enabled.
- UIProcess/Launcher/mac/ThreadLauncherMac.mm:
(WebKit::webThreadBody):
(WebKit::ThreadLauncher::createWebThread):
Switch to using the constructor version of Identifier.
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy):
Don't try to use the XPC service for plugins yet.
(WebKit::PluginProcessProxy::didFinishLaunching):
Use Connection::identifierIsNull instead of explicit null check.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connect):
If XPC is compiled in (it currently is not) enable it by default.
- WebKit2.xcodeproj/project.pbxproj:
Add the new files and targets.
- WebKit2Service: Added.
- WebKit2Service/Info.plist: Added.
Add the paper work needed for an XPC service. Importantly, set up the XPC
service to be an Application service type, use NSApplicationMain as its run
loop, and allow for multiple instantiations. Also make sure the service acts
like the WebProcess binary by making it a LSUIElement, enabling LSFileQuarantine,
and setting the principle class to NSApplication.
- WebKit2Service/MainMacService.mm: Added.
(WebKit2ServiceEventHandler):
(main):
The initialization of the XPC service is quite a bit different than the
WebProcess version, since we don't get passed parameters in argv. Instead,
we initiate the XPC service via xpc_main, and wait for the bootstrap message
we sent in ProcessLauncherMac.mm. When we receive that message we can load
WebKit2 framework and initialize the WebProcess normally (we also get the mach_port
for the CoreIPC connection in that bootstrap message).
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMainXPC):
Add a variant of WebProcessMain that is used for the XPC service case, where we don't
have command line arguments and don't need to talk to the mach bootstrap server.
(WebKit::WebProcessMain):
- mac/MainMac.cpp: Removed.
- mac/MainMacProcess.cpp: Copied from Source/WebKit2/mac/MainMac.cpp.
Rename MainMac to MainMacProcess to signify that it is different from the XPC
service main.
- 2:17 PM Changeset in webkit [125357] by
-
- 11 edits in trunk/Source
Do the DecimalNumber to String conversion on 8 bits
https://bugs.webkit.org/show_bug.cgi?id=93683
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-11
Reviewed by Andreas Kling.
Source/WebCore:
Numbers converted to string for CSS are unlikely to ever be concatenated with a 16bits string.
This patch change the conversion to be done to 8bits string in order to reduce memory allocations.
- css/CSSPrimitiveValue.cpp:
(WebCore::formatNumber):
- inspector/InspectorValues.cpp:
(WebCore::InspectorBasicValue::writeJSON):
- platform/graphics/Color.cpp:
(WebCore::Color::serialized): Instead of allocating a static WTF::String, we can simply append the
string literal to the output vector.
Source/WTF:
Modify DecimalNumber to do the conversion to string on LChar instead of UChar.
- wtf/DecimalNumber.cpp:
(WTF::DecimalNumber::toStringDecimal):
(WTF::DecimalNumber::toStringExponential):
- wtf/DecimalNumber.h:
(DecimalNumber):
- wtf/dtoa.h:
- wtf/text/StringBuffer.h:
(WTF::StringBuffer::operator[]): StringBuffer::operator[] was incorrectly typed to UChar, making
the method impossible to instanciate with LChar.
- wtf/text/WTFString.h:
(String):
(WTF::String::adopt): String::adopt() is modified to work with both LChar and UChar. StringImpl
already support that.
(WTF::appendNumber): Add support for any type that can instanciate the template.
- 2:12 PM Changeset in webkit [125356] by
-
- 6 edits in trunk/Source
WebCore::findAtomicString(PropertyName) always convert the name to 16bits
https://bugs.webkit.org/show_bug.cgi?id=93685
Reviewed by Geoffrey Garen.
Source/WebCore:
- bindings/js/JSDOMBinding.cpp:
(WebCore::findAtomicString):
Use the new AtomicString::find() to avoid calling StringImpl::characters().
Source/WTF:
Previously, WebCore::findAtomicString() was causing a conversion for the 8bit property name
to a 16bits due to the call to StringImpl::character16().
This patch fixes the issue by adding support for both 8bits and 16bits string in AtomicString::find().
- wtf/text/AtomicString.cpp:
(HashAndCharacters):
(WTF::HashAndCharactersTranslator::hash):
(WTF::HashAndCharactersTranslator::equal):
(WTF::HashAndCharactersTranslator::translate):
Use a template to make the struct and the translator independant of the CharacterType.
(WTF::AtomicString::add):
(WTF::findString):
(WTF::AtomicString::find): Change the API to take a StringImpl*. AtomicString can use
it efficiently to find the right string.
- wtf/text/AtomicString.h:
(AtomicString):
- wtf/text/StringImpl.h:
(StringImpl): Adapt the friends translator to support the template.
- 1:01 PM Changeset in webkit [125355] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Remove QtSenderStack now we do not support qt_sender anymore in Qt bridge
https://bugs.webkit.org/show_bug.cgi?id=93767
Reviewed by Kenneth Rohde Christiansen.
Dead code after patch of bug 93649.
- bridge/qt/qt_instance.h:
(QtInstance):
- 12:41 PM Changeset in webkit [125354] by
-
- 1 edit1 move in trunk/LayoutTests
webarchive/ignore-noscript-if-scripting.html expected results should use .webarchive extension
https://bugs.webkit.org/show_bug.cgi?id=93736
<rdar://problem/12077654>
Reviewed by Eric Seidel.
Because the test uses dumpDOMAsWebArchive(), the expected results extension should be .webarchive instead of .txt.
- webarchive/ignore-noscript-if-scripting-enabled-expected.webarchive: Renamed from LayoutTests/webarchive/ignore-noscript-if-scripting-enabled-expected.txt.
- 9:07 AM Changeset in webkit [125353] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed.
Removing newly added assert in r125351 since it is exposing
legitimate layout bugs in few tests. We will re-add the assert
after fixing those bugs. Failures are tracked in webkit bug 93766.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFromTrackedRendererMaps):
- 6:26 AM Changeset in webkit [125352] by
-
- 4 edits in trunk/Source/WebKit/qt
[Qt] Add support for HTML5 state object history API in FrameLoaderClientQt
https://bugs.webkit.org/show_bug.cgi?id=93648
Reviewed by Kenneth Rohde Christiansen.
Add support for push/replace/pop by implementing dispatchDidNavigateWithinPage.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidNavigateWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidPushStateWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidReplaceStateWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidPopStateWithinPage):
- WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):
- tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame):
(tst_QWebFrame::setUrlUsingStateObject): Added. Tests that the urlChanged signal is fired.
- 3:44 AM Changeset in webkit [125351] by
-
- 8 edits2 adds in trunk
Source/WebCore: Track block's positioned objects like percent-height descendants
https://bugs.webkit.org/show_bug.cgi?id=89848
Reviewed by Abhishek Arya.
The previous method for tracking a RenderBlock's out-of-flow positioned descendants was error prone,
subject to becoming inconsistent, and in the case of removePositionedObjects, inefficient. This patch
extracts the algorithm used for percent height descendants and re-uses it for positioned objects. This same
method could further be re-used for floats.
This change removes the m_positionedObjects pointer, which brings RenderBlock's size down (yay!).
Test: fast/block/positioning/relayout-nested-positioned-elements-crash-2.html
- rendering/RenderBlock.cpp:
(SameSizeAsRenderBlock):
(WebCore):
(WebCore::removeBlockFromDescendantAndContainerMaps):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addOverflowFromPositionedObjects):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::markPositionedObjectsForLayout):
(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertIntoTrackedRendererMaps):
(WebCore::RenderBlock::removeFromTrackedRendererMaps):
(WebCore::RenderBlock::positionedObjects):
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
(WebCore::RenderBlock::removePositionedObjects):
(WebCore::RenderBlock::addPercentHeightDescendant):
(WebCore::RenderBlock::removePercentHeightDescendant):
(WebCore::RenderBlock::percentHeightDescendants):
(WebCore::RenderBlock::checkPositionedObjectsNeedLayout):
- rendering/RenderBlock.h:
(WebCore):
(RenderBlock):
(WebCore::RenderBlock::hasPositionedObjects):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildTo): Changing the fixme to reflect the assumption that the caller
has taken care of updating the positioned renderer maps is a decision not a bug. The ASSERT should help
assure this.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
- rendering/RenderView.cpp:
(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
LayoutTests: Track block's positioned objects like percent-height children
https://bugs.webkit.org/show_bug.cgi?id=89848
Reviewed by Abhishek Arya.
Adding another test to confirm that RenderBlock's positioned children lists don't become
inconsistent.
- fast/block/positioning/relayout-nested-positioned-elements-crash-2-expected.txt: Added.
- fast/block/positioning/relayout-nested-positioned-elements-crash-2.html: Added.
- 2:37 AM Changeset in webkit [125350] by
-
- 2 edits in trunk/Tools
[EFL] Bump harfbuzz dependency to v0.9.2
https://bugs.webkit.org/show_bug.cgi?id=93762
Reviewed by Eric Seidel.
EFL port has used harfbuzz 0.9.0 ver. However, the 0.9.2 version was released on 10th Aug 2012.
In addition, 0.9.0 ver. was disappeared. So, EFL port needs to use 0.9.2 ver. from now on.
- efl/jhbuild.modules:
Aug 10, 2012:
- 7:45 PM Changeset in webkit [125349] by
-
- 15 edits in trunk/Source
[WebGL] Add support for EXT_robustness
https://bugs.webkit.org/show_bug.cgi?id=93379
Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-08-10
Reviewed by George Staikos.
Source/WebCore:
Take advantage of EXT robustness in WebKit.
This commit makes WebKit use readnPixelsEXT, getnUniformfvEXT and
getnUniformivEXT instead of readPixels, getUniformfv and getUniformiv
when possible, and sets up the reset notification behaviour for
GLES platforms.
The reset behaviour has not yet been implemented in the BlackBerry
compositing thread, so for now on BlackBerry we just abort when
the context has been reset. This prevents undefined behaviour, but
can be improved in the future.
No new tests are needed because no new functionality is introduced.
Support for ARB robustness reset notification behaviour is already
in WebKit, and EXT robustness' reset notifcation behaviour is the
same. readnPixelsEXT replaces WebKit's existing mechanisms of
preventing buffer overflows.
RIM PR# 147510
Internally reviewed by Arvid Nilsson.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::setupFlags):
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::readPixels):
- html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
- platform/chromium/support/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::readnPixelsEXT):
(WebCore):
(WebCore::Extensions3DChromium::getnUniformfvEXT):
(WebCore::Extensions3DChromium::getnUniformivEXT):
- platform/graphics/Extensions3D.h:
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::setContextLostCallback):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::makeContextCurrent):
- platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderer):
- platform/graphics/chromium/Extensions3DChromium.h:
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::readnPixelsEXT):
(WebCore):
(WebCore::Extensions3DOpenGLCommon::getnUniformfvEXT):
(WebCore::Extensions3DOpenGLCommon::getnUniformivEXT):
- platform/graphics/opengl/Extensions3DOpenGLCommon.h:
(Extensions3DOpenGLCommon):
- platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::getGraphicsResetStatusARB):
(WebCore):
(WebCore::Extensions3DOpenGLES::setEXTContextLostCallback):
(WebCore::Extensions3DOpenGLES::readnPixelsEXT):
(WebCore::Extensions3DOpenGLES::getnUniformfvEXT):
(WebCore::Extensions3DOpenGLES::getnUniformivEXT):
(WebCore::Extensions3DOpenGLES::supportsExtension):
- platform/graphics/opengl/Extensions3DOpenGLES.h:
(Extensions3DOpenGLES):
Source/WebKit:
RIM PR# 147510
Internally reviewed by Arvid Nilsson.
- CMakeLists.txt: Build system adaptation.
- 7:33 PM Changeset in webkit [125348] by
-
- 4 edits4 adds in trunk
Microdata: item with itemprop attribute should not include the item itself in the HTMLPropertiesCollection.
https://bugs.webkit.org/show_bug.cgi?id=93717
Reviewed by Ryosuke Niwa.
Source/WebCore:
Tests: fast/dom/MicroData/item-with-itemprop-attr.html
fast/dom/MicroData/item-with-itemref-pointing-to-itself.html
- dom/PropertyNodeList.cpp:
(WebCore::PropertyNodeList::nodeMatches): Do not process the testElement if it is the owner node.
- html/HTMLPropertiesCollection.cpp:
(WebCore::nextNodeWithProperty): Traverse the next node only if previous node is microdata item
i.e, ownerNode or previous element does not have itemscope attribute specified.
(WebCore::HTMLPropertiesCollection::virtualItemAfter): Try to find the next property if current
is ownerNode.
LayoutTests:
Added test to ensure that item with itemprop attribute should not include
itself in its HTMLPropetiesCollection.
- fast/dom/MicroData/item-with-itemprop-attr-expected.txt: Added.
- fast/dom/MicroData/item-with-itemprop-attr.html: Added.
- fast/dom/MicroData/item-with-itemref-pointing-to-itself-expected.txt: Added.
- fast/dom/MicroData/item-with-itemref-pointing-to-itself.html: Added.
- 7:20 PM Changeset in webkit [125347] by
-
- 2 edits in trunk/LayoutTests
Layout Test: plugins/nested-plugin-objects.html passes but causes subsequent test to fail on Windows.
https://bugs.webkit.org/show_bug.cgi?id=93741
Patch by Roger Fong <roger_fong@apple.com> on 2012-08-10
Reviewed by Tim Horton.
plugins/nested-plugin-objects.html passes but causes subsequent test to fail on Windows.
plugins/netscape-dom-access-and-reload.html fails as a result.
Or if I skip that test, then plugins/netscape-dom-access.html fails (the next test in the list).
- platform/win/Skipped:
Added plugins/nested-plugin-objects.html to skip list.
- 7:02 PM Changeset in webkit [125346] by
-
- 8 edits5 deletes in trunk/Source/WebCore
[BlackBerry][EFL][GTK][WIN][WX] Remove ScriptControllerXXX.cpp to reduce duplication
https://bugs.webkit.org/show_bug.cgi?id=61424
Reviewed by Rob Buis.
ScriptControllerBlackBerry, ScriptControllerEfl, ScriptControllerGtk,
ScriptControllerWin and ScriptControllerWx are almost same.
In order to reduce duplication, this patch moves codes to ScriptController
and removes them.
No behavior change. Just a refactoring.
- GNUmakefile.list.am:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
- WebCore.gypi:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/ScriptController.cpp:
(WebCore):
(WebCore::ScriptController::createScriptInstanceForWidget):
Moved from ScriptControllerXXX.cpp
- bindings/js/ScriptControllerBlackBerry.cpp: Removed.
- bindings/js/ScriptControllerEfl.cpp: Removed.
- bindings/js/ScriptControllerGtk.cpp: Removed.
- bindings/js/ScriptControllerWin.cpp: Removed.
- bindings/js/ScriptControllerWx.cpp: Removed.
- 6:55 PM Changeset in webkit [125345] by
-
- 2 edits in trunk/LayoutTests
LayoutTest: fast/forms/basic-selects.html rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=93751
Patch by Roger Fong <roger_fong@apple.com> on 2012-08-10
Reviewed by Tim Horton.
As per https://bugs.webkit.org/show_bug.cgi?id=92833,
this test needs to be rebaselined for other platforms.
Rebaselining for Windows.
- platform/win/fast/forms/basic-selects-expected.txt:
Rebaselining.
- 6:49 PM Changeset in webkit [125344] by
-
- 9 edits in branches/safari-536.26-branch
Merged r124799. <rdar://problem/12043772>
- 6:49 PM Changeset in webkit [125343] by
-
- 3 edits2 adds in trunk
RenderQuote corrupts doubly linked list on insertion before head of list
https://bugs.webkit.org/show_bug.cgi?id=93750
Patch by Elliott Sprehn <Elliott Sprehn> on 2012-08-10
Reviewed by Abhishek Arya.
Source/WebCore:
Fix bug where moving a RenderQuote instance before the first one in
the document would not update the m_previous pointer of the original
first RenderQuote to point back at the new one.
Test: fast/css-generated-content/quote-crash-93750.html
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::attachQuote):
LayoutTests:
Test for moving around RenderQuote nodes before each other in an
existing document to catch corruption in the linked list of RenderQuote.
- fast/css-generated-content/quote-crash-93750-expected.txt: Added.
- fast/css-generated-content/quote-crash-93750.html: Added.
- 6:45 PM Changeset in webkit [125342] by
-
- 4 edits in trunk/LayoutTests
REGRESSION (r124416): fast/forms/basic-selects.html failing on Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=93538
Unreviewed gardening. Rebaseline of this test for Mac ports, and
remove expected failure.
- platform/mac/TestExpectations:
- platform/mac/fast/forms/basic-selects-expected.png:
- platform/mac/fast/forms/basic-selects-expected.txt:
- 6:33 PM Changeset in webkit [125341] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed gardening. Missing platform expectations for this test. Results
are identical to chromium-mac at present.
- platform/mac/svg/repaint/text-mask-update-expected.txt: Added.
- 5:59 PM Changeset in webkit [125340] by
-
- 2 edits in trunk/LayoutTests
(r125185) http/tests/images/jpg-img-partial-load.html timeout on Lion
https://bugs.webkit.org/show_bug.cgi?id=93636
Unreviewed test expectation update for Mac.
- platform/mac/TestExpectations:
- 5:55 PM Changeset in webkit [125339] by
-
- 19 edits8 deletes in trunk
[chromium] Remove forwarding headers for compositor-related WebKit API and update includes
https://bugs.webkit.org/show_bug.cgi?id=93669
Reviewed by Adam Barth.
Source/Platform:
Removes a no-longer-necessary transitional define.
- chromium/public/WebCompositor.h:
Source/WebCore:
Updates all includes for compositor-related headers to refer consistently to the Platform API location.
- platform/chromium/support/WebCompositorImpl.h:
Source/WebKit/chromium:
This updates all includes for compositor-related headers to refer consistently to the Platform API location and
removes the now-unneeded forwarding headers in the client API location. I also updated and resorted other
platform API includes in modified header blocks.
- WebKit.gyp:
- public/WebCompositor.h: Removed.
- public/platform/WebContentLayer.h: Removed.
- public/platform/WebContentLayerClient.h: Removed.
- public/platform/WebExternalTextureLayer.h: Removed.
- public/platform/WebLayer.h: Removed.
- public/platform/WebLayerTreeView.h: Removed.
- public/platform/WebLayerTreeViewClient.h: Removed.
- public/platform/WebSolidColorLayer.h: Removed.
- src/WebCompositorInputHandlerImpl.h:
- src/WebContentLayerImpl.cpp:
- src/WebLayer.cpp:
- src/WebLayerTreeView.cpp:
- src/WebLayerTreeViewImpl.cpp:
- src/WebLayerTreeViewImpl.h:
- src/WebSolidColorLayer.cpp:
- src/WebViewImpl.h:
- tests/Canvas2DLayerBridgeTest.cpp:
- tests/GraphicsLayerChromiumTest.cpp:
- tests/TextureLayerChromiumTest.cpp:
- 5:32 PM Changeset in webkit [125338] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
r125337 added a call to WTF::currentTime() in MediaController.cpp, but that file didn't #include
<wtf/CurrentTime.h>. This file is indirectly picked up on the include paths for some ports, but not all.
- html/MediaController.cpp:
- 4:50 PM Changeset in webkit [125337] by
-
- 4 edits2 adds in trunk
no timeupdate events emitted for media controller
https://bugs.webkit.org/show_bug.cgi?id=93745
Reviewed by Eric Carlson.
Source/WebCore:
Generate timeupdate events while the current position is changing.
Test: media/media-controller-timeupdate.html
Enforce the spec requirement that the timeupdate event is fired no more often
than every 250ms.
- html/MediaController.cpp:
(MediaController::scheduleTimeupdateEvent):
Add a periodic firing timer to generate timeupdate events during playback.
- html/MediaController.cpp:
(MediaController::startTimeupdateTimer):
(MediaController::timeupdateTimerFired):
- html/MediaController.cpp:
(MediaController::MediaController): Initialize m_previousTimeupdateTime.
(MediaController::setCurrentTime): Call scheduleTimeUpdateEvent.
(MediaController::updatePlaybackState): Start and stop the timeupdate timer.
- html/MediaController.h:
LayoutTests:
New test checking that the timeupdate event is emmitted correctly during playback.
- media/media-controller-timeupdate-expected.txt: Added.
- media/media-controller-timeupdate.html: Added.
- 4:33 PM Changeset in webkit [125336] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-10
- DEPS:
- 4:13 PM Changeset in webkit [125335] by
-
- 9 edits13 adds in trunk
Allow blocking of third-party localStorage and sessionStorage
https://bugs.webkit.org/show_bug.cgi?id=93390
Reviewed by Adam Barth.
Source/WebCore:
Add checks for if a page is third-party and third-party storage blocking is enabled while accessing storage.
Tests: http/tests/security/cross-origin-local-storage-allowed.html
http/tests/security/cross-origin-local-storage.html
http/tests/security/cross-origin-session-storage-allowed.html
http/tests/security/cross-origin-session-storage.html
http/tests/security/same-origin-document-domain-storage-allowed.html
- dom/Document.cpp:
(WebCore::Document::initSecurityContext): Initialize securityOrigin with knowledge of if we should block third-party storage.
- page/DOMWindow.cpp: Check if the origin trying to access storage is third-party relative to the top document.
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
- page/SecurityOrigin.cpp: Add a call in Security origin to see if another origin counts as a third-party.
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::canAccessLocalStorage):
(WebCore):
(WebCore::SecurityOrigin::isThirdParty):
- page/SecurityOrigin.h:
(WebCore::SecurityOrigin::blockThirdPartyStorage):
(SecurityOrigin):
- testing/InternalSettings.cpp: Add an internals.settings hook for setting third-party storage blocking enabled.
(WebCore::InternalSettings::setThirdPartyStorageBlockingEnabled):
(WebCore):
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl:
LayoutTests:
Created tests for testing accessing localStorage and selfStorage from a third party and first party when third-party blocking is on and off.
- http/tests/security/cross-origin-local-storage-allowed-expected.txt: Added.
- http/tests/security/cross-origin-local-storage-allowed.html: Added.
- http/tests/security/cross-origin-local-storage-expected.txt: Added.
- http/tests/security/cross-origin-local-storage.html: Added.
- http/tests/security/cross-origin-session-storage-allowed-expected.txt: Added.
- http/tests/security/cross-origin-session-storage-allowed.html: Added.
- http/tests/security/cross-origin-session-storage-expected.txt: Added.
- http/tests/security/cross-origin-session-storage.html: Added.
- http/tests/security/same-origin-document-domain-storage-allowed-expected.html: Added.
- http/tests/security/same-origin-document-domain-storage-allowed.html: Added.
- http/tests/security/resources/document-domain-iframe-for-local-storage.html: Added.
- http/tests/security/resources/cross-origin-iframe-for-local-storage.html: Added.
- http/tests/security/resources/cross-origin-iframe-for-session-storage.html: Added.
- 3:52 PM Changeset in webkit [125334] by
-
- 3 edits2 adds in trunk
Source/WebCore: REGRESSION(r125159): ASSERTION FAILED: m_listsInvalidatedAtDocument.contains(list) in Document::unregisterNodeListCache.
https://bugs.webkit.org/show_bug.cgi?id=93729
Reviewed by Ryosuke Niwa.
In Document::registerNodeListCache() it was not adding PropertyNodeList
cache to m_listsInvalidatedAtDocument the as node list currently not rooted
at the document. Where in Document::unregisterNodeListCache() it was trying
to remove PropertyNodeList cache from m_listsInvalidatedAtDocument. Hence it
caused the assertion failure.
We need to check if m_rootType is NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr,
not that it's currently rooted at the document.
Test: fast/dom/MicroData/propertynodelist-crash.html
- dom/DynamicNodeList.h:
(WebCore::DynamicNodeListCacheBase::isRootedAtDocument):
LayoutTests: REGRESSION(r125159): ASSERTION FAILED: m_listsInvalidatedAtDocument.contains(list) in Document::unregisterNodeListCache.
https://bugs.webkit.org/show_bug.cgi?id=93729
Reviewed by Ryosuke Niwa.
Added a test to ensure that it does not crash in Document::unregisterNodeListCache.
- fast/dom/MicroData/propertynodelist-crash-expected.txt: Added.
- fast/dom/MicroData/propertynodelist-crash.html: Added.
- 3:41 PM Changeset in webkit [125333] by
-
- 2 edits in trunk/Source/WebCore
Improved RuleData packing on some 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=93737
Reviewed by Andreas Kling.
Certain 32-bit plarforms use an 8-byte alignment for uint64_t. We can save 4 bytes per
object on these platforms by using two naturally-aligning unsigned ints instead.
- css/StyleResolver.cpp:
(RuleData):
(SameSizeAsRuleData):
- 3:17 PM Changeset in webkit [125332] by
-
- 4 edits in trunk/Tools
run-perf-tests should upload memory statistics to perf-o-matic
https://bugs.webkit.org/show_bug.cgi?id=93690
Reviewed by Dirk Pranke.
Upload JS Heap and FastMalloc results for a test X/Y as: X/Y:JSHeap and X/Y:FastMalloc.
Note "JS Heap" is converted to the CamelCase JSHeap.
Also did some refactoring in PerfTest.parse_output and PerfTestRunnerTest and updated
some helps in PerfTest.parse_output per arv's comments.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output): Include JSHeap and FastMalloc statistics in results as well as of Time.
Also refactored it to avoid hard-coding indices in _result_classes and moved complied regular
exressions out of the function to avoid re-compiling them every time the method runs.
(PerfTest.output_statistics): Convert ':' to ': ' as well as '/'.
(ChromiumStylePerfTest.parse_output): Removed an unused variable.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args): Uploaded some helps per arv's feedback.
(PerfTestsRunner._output_json_path): Extracted from _generate_and_show_results to be used in
PerfTestRunnerTest.create_runner.
(PerfTestsRunner._generate_and_show_results):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(create_runner): Extracted runner.load_output_json from various tests.
(test_run_memory_test): Added.
(PerfTestRunner): Extracted _event_target_wrapper_and_inspector_results from various tests.
(test_run_with_json_output):
(test_run_with_description):
(test_run_generates_json_by_default):
(test_run_generates_and_show_results_page):
(test_run_with_json_source):
(test_run_with_multiple_repositories):
- 3:15 PM Changeset in webkit [125331] by
-
- 5 edits in trunk/Source/WebCore
[CSS Shaders] Add blend mode and composite op to compiled program cache key
https://bugs.webkit.org/show_bug.cgi?id=93623
Patch by Max Vujovic <mvujovic@adobe.com> on 2012-08-10
Reviewed by Dirk Schulze.
Right now, only the vertex shader string and the fragment shader string are hashed
to create a key for the compiled program. However, in a future patch, WebKit will
rewrite the fragment shader based on the blend mode and composite op specified by
the author. This means that the unique key for a compiled program is (original
vertex shader string, original fragment shader string, blend mode, composite
operator). This patch adds blend mode and composite operator in the hash for the
key.
No new tests. The state of the compiled program cache is not exposed to a web
page. Existing tests should ensure this change doesn't break current
functionality. Additional tests will be added in a future patch that implements
shader rewriting based on blend mode and composite op.
- platform/graphics/filters/CustomFilterProgram.cpp:
(WebCore::CustomFilterProgram::programInfo):
- platform/graphics/filters/CustomFilterProgram.h:
(WebCore):
- platform/graphics/filters/CustomFilterProgramInfo.cpp:
(WebCore::CustomFilterProgramInfo::CustomFilterProgramInfo):
(WebCore::CustomFilterProgramInfo::hash):
(WebCore::CustomFilterProgramInfo::operator==):
- platform/graphics/filters/CustomFilterProgramInfo.h:
(WebCore::CustomFilterProgramMixSettings::CustomFilterProgramMixSettings):
(CustomFilterProgramMixSettings):
(WebCore::CustomFilterProgramMixSettings::operator==):
(WebCore):
(CustomFilterProgramInfo):
- 2:48 PM Changeset in webkit [125330] by
-
- 8 edits2 adds in trunk
Part 1 of: Extend -webkit-user-select with a new value "all"
<rdar://problem/10161404>
https://bugs.webkit.org/show_bug.cgi?id=93562
Patch by Alice Cheng <alice_cheng@apple.com> on 2012-08-10
Reviewed by Dan Bernstein.
Source/WebCore:
Parse the new "all" value for -webkit-user-select
Test: editing/selection/user-select-all-parsing.html
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue): Add new value all
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Add new value all
(WebCore::CSSPrimitiveValue::operator EUserSelect): Add one more bit to store the new property value
- rendering/style/RenderStyleConstants.h: Add new value all
- rendering/style/StyleRareInheritedData.h: Add new value all
(StyleRareInheritedData):
Source/WebKit/gtk:
Modify the enum to resolve ambiguous reference
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init): Modify the ambiguous enum
(webkit_web_view_select_all): Modify the ambiguous enum
LayoutTests:
Add a test to verify that the new "all" value is parsed correctly.
- editing/selection/user-select-all-parsing-expected.txt: Added.
- editing/selection/user-select-all-parsing.html: Added.
- 2:45 PM Changeset in webkit [125329] by
-
- 4 edits in trunk/Source
[chromium] Upstream Android changes to WebFrameImpl::selectRange
https://bugs.webkit.org/show_bug.cgi?id=92513
Patch by Iain Merrick <husky@google.com> on 2012-08-10
Reviewed by Ryosuke Niwa.
Source/WebCore:
Make this function public we so can call it from the WebKit layer.
- page/EventHandler.h:
(EventHandler):
Source/WebKit/chromium:
This change is driven by the Chromium port on the Android platform,
but it should be suitable for other touch-based platforms. We reuse
selectionExtentRespectingEditingBoundary (extracted from EventHandler
into VisibleSelection).
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::selectRange):
(WebKit::WebFrameImpl::visiblePositionForWindowPoint):
- 2:42 PM Changeset in webkit [125328] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Updated results for fast/borders/border-shadow-large-radius.html.
Unreviewed gardening.
- platform/chromium-win/fast/borders/border-shadow-large-radius-expected.png: Added.
- 2:34 PM Changeset in webkit [125327] by
-
- 3 edits3 copies in branches/safari-536.26-branch
Merged r125124. <rdar://problem/12062368>
- 2:09 PM Changeset in webkit [125326] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Broken implementation of AtkText and AtkEditableText for password fields
https://bugs.webkit.org/show_bug.cgi?id=93621
Rubber-stamped by Ryosuke Niwa.
Fix Apple Win build, by avoiding to generate unreachable sections
of code in AccessibilityRenderObject::passwordFieldValue().
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::passwordFieldValue):
- 1:40 PM Changeset in webkit [125325] by
-
- 6 edits in trunk/Source
[chromium] Remove targetSurface pointer from CCRenderPass
https://bugs.webkit.org/show_bug.cgi?id=93734
Reviewed by Adrienne Walker.
Source/WebCore:
This removes the CCRenderSurface pointer from the CCRenderPass
structure, allowing it to be serialized and used across processes
freely.
No new tests; no intended change in behaviour.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::CCRenderPass):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
Source/WebKit/chromium:
Use the RenderPass's damageRect instead of the surface's damageRect
directly to test the same things without requiring a pointer to
the surface that generated the RenderPass.
- tests/CCLayerTreeHostImplTest.cpp:
- 1:40 PM Changeset in webkit [125324] by
-
- 5 edits3 adds in trunk/Source/WebKit
Introduce JavaScriptVariant object.
https://bugs.webkit.org/show_bug.cgi?id=93644
The JavaScriptVariant can be used for functions that return results from
JavaScript such as executeJavaScript or functions that take arguments
to pass a variable to JavaScript and they want to make sure the type
is correct.
Convert executeJavaScriptFunction() to use this data type as the
example, other functions will be converted in the future.
PR 14929
Internally reviewed by Joe Mason
Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-08-10
Reviewed by Adam Treat
Source/WebKit:
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
- Api/JavaScriptVariant.cpp: Added.
(WebKit):
(BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
(BlackBerry::WebKit::BlackBerryJavaScriptVariantToJSValueRef):
(BlackBerry::WebKit::JavaScriptVariant::JavaScriptVariant):
(BlackBerry::WebKit::JavaScriptVariant::~JavaScriptVariant):
(BlackBerry::WebKit::JavaScriptVariant::operator=):
(BlackBerry::WebKit::JavaScriptVariant::setType):
(BlackBerry::WebKit::JavaScriptVariant::type):
(BlackBerry::WebKit::JavaScriptVariant::setDouble):
(BlackBerry::WebKit::JavaScriptVariant::doubleValue):
(BlackBerry::WebKit::JavaScriptVariant::setString):
(BlackBerry::WebKit::JavaScriptVariant::stringValue):
(BlackBerry::WebKit::JavaScriptVariant::setBoolean):
(BlackBerry::WebKit::JavaScriptVariant::booleanValue):
- Api/JavaScriptVariant.h: Added.
(WebKit):
- Api/JavaScriptVariant_p.h: Added.
(WebKit):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
- Api/WebPage.h:
- 1:30 PM Changeset in webkit [125323] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r125310.
http://trac.webkit.org/changeset/125310
https://bugs.webkit.org/show_bug.cgi?id=93739
The DEPS roll broke Android. One does not simply break
Android. (Requested by fmalita_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-10
- DEPS:
- 1:21 PM Changeset in webkit [125322] by
-
- 2 edits in trunk
[BlackBerry] Enable relro link option for JSC executable
https://bugs.webkit.org/show_bug.cgi?id=93726
Reviewed by Yong Li.
Enable relro link option for JSC executable.
- Source/cmake/OptionsBlackBerry.cmake:
- 1:20 PM Changeset in webkit [125321] by
-
- 7 edits in trunk/Source
[GTK] Broken implementation of AtkText and AtkEditableText for password fields
https://bugs.webkit.org/show_bug.cgi?id=93621
Reviewed by Chris Fleizach.
Source/WebCore:
Fix broken implementation of AtkText and AtkEditableText
interfaces in the GTK port for password input fields.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue): Call the new
function passwordFieldValue() for password input fields.
(WebCore::AccessibilityRenderObject::text): Ditto.
(WebCore::AccessibilityRenderObject::textLength): Return the
actual length of the password in the field for GTK, return -1
otherwise (not to break current behavior in other platforms).
(WebCore::AccessibilityRenderObject::doAXStringForRange): Don't
early return for password fields in GTK (will rely on text()).
(WebCore::AccessibilityRenderObject::passwordFieldValue): New, it
returns the text being actually rendered for a password input
field (normally a masked string) in GTK. It returns String() in
the rest of platforms, to ensure we don't break anything there.
(WebCore):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::passwordFieldValue): Default
implementation of this new method, returning an empty string.
(AccessibilityObject):
Ensure the 'text-insert' and 'text-remove' signals for the AtkText
interface are properly emitted for password input fields.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::nodeTextChangePlatformNotification): Make
sure we never emit the password value for an input field in plain
text when inserting or removing text. Emit the masked text instead.
Source/WebKit/gtk:
Update unit test to ensure that password input fields behave
as expected when inserting and removing characters in them.
- tests/testatk.c:
(testWebkitAtkTextChangedNotifications): Updated unit test to
cover the special case of password input fields.
- 1:18 PM Changeset in webkit [125320] by
-
- 8 edits1 add in trunk
Add support for String initialization from literal to WTFString
https://bugs.webkit.org/show_bug.cgi?id=93426
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-10
Reviewed by Anders Carlsson.
Source/WTF:
This patch adds two constructor to WTF::String in order to support fast initialization from literal:
-String(ASCIILiteral): Constructor similar to String(const char*) while being faster. This constructor
does not incur any overhead over String(const char*).
-String(char[], ConstructFromLiteralTag): Template constructor that encode explicitely the size of the
string.
String(ASCIILiteral) is expected to be used in most cases to avoid regressions. This constructor was
added because of what we have learned from r124922: inlining the string length in the code causes a code bloat
that is not always welcome.
Regarding performance of string initialization, the constructors performance are (6 characters string):
-String(ASCIILiteral): 16% faster.
-String(char[], ConstructFromLiteralTag): 33% faster (the delta increases with the string length).
In addition, no memory is allocated for the characters.
- wtf/text/StringImpl.cpp:
- wtf/text/StringImpl.h:
(WTF::StringImpl::createFromLiteral): Extend StringImpl::createFromLiteral to have a version
with strlen() which avoids loading one extra argument.
- wtf/text/WTFString.cpp:
(WTF::String::String):
- wtf/text/WTFString.h:
(WTF::String::String):
(ASCIILiteral): This class is aimed at making the construction of WTFString from a literal very easy.
By using the explicit constructor ASCIILiteral(char *), one can expect the implicit conversion to String
when needed.
(WTF::ASCIILiteral::ASCIILiteral):
(WTF::ASCIILiteral::operator const char*):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/WTFString.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp.
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- 1:16 PM Changeset in webkit [125319] by
-
- 2 edits in trunk/Source/WebKit2
Crash exiting from HTML5 FS mode to normal mode via ESC key
https://bugs.webkit.org/show_bug.cgi?id=93663
Reviewed by Eric Carlson.
Crash is due to a refcount underrun with _watchdogTimer due to adopting an autoreleased NSTimer.
Use the non-autoreleased NSTimer creation method and manually add to the main NSRunLoop.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController cancelOperation:]):
- 1:13 PM Changeset in webkit [125318] by
-
- 4 edits in trunk/Source/WebCore
Use the new AVPlayerItemVideoOutput API in MediaPlayerPrivateAVFoundation.
https://bugs.webkit.org/show_bug.cgi?id=93591
Reviewed by Eric Carlson.
Support the new AVPlayerItemVideoOutput API from Mountain Lion, which has much increased performance over
AVAssetImageGenerator.
No new tests; Performance change only, no net change in functionality.
AVPlayerItemVideoOutput requires an attached CALayer for rendering to occur. Make the rendering modes non-exclusive,
so layer-rendering and context-rendering can exist simultaneously:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Make the MediaRenderingMode enum
a bitfield.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::currentRenderingModes): Renamed from currentRenderingMode().
(WebCore::MediaPlayerPrivateAVFoundation::setUpVideoRendering): Check for the presence of the MediaRenderingToLayer bit.
(WebCore::MediaPlayerPrivateAVFoundation::prepareForRendering): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Ditto.
Pull out existing the AVAssetImageGenerator into its own functions:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator):
Add new AVPlayerItemVideoOutput equivalent functions:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
Switch between the AVAssetImageGenerator and AVPlayerItemVideoOutput functions from
within the original functions:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasContextRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect): Call the
AVAssetImageGenerator creation function directly.
- 1:10 PM Changeset in webkit [125317] by
-
- 2 edits in trunk/PerformanceTests
Unreviewed; fix an insanely silly typo.
- resources/results-template.html:
- 12:49 PM Changeset in webkit [125316] by
-
- 2 edits in trunk/Tools
NRWT crashes when DRT with --encode-binary crashes just before it dumps pixels
https://bugs.webkit.org/show_bug.cgi?id=93728
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/driver.py:
(ContentBlock.decode_content): Check self.content is not None before calling base64.b64decode().
- 12:41 PM Changeset in webkit [125315] by
-
- 2 edits in trunk/Source/WebCore
Crash on accessing a removed layout root in FrameView::scheduleRelayout.
https://bugs.webkit.org/show_bug.cgi?id=91368
Reviewed by Levi Weintraub.
We were calling setNeedsLayoutAndPrefWidthsRecalc() in RenderBlock::collapseAnonymousBoxChild
even when documentBeingDestroyed() was true. This ends up accessing stale layout root and bypasses
mitigation added in r109406. There is no need to waste time merging up anonymous blocks in
RenderBlock::removeChild when documentBeingDestroyed() is true.
No new tests. The test is time sensitive, requires a bunch of reloads, and only reproduces on chromium linux.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseAnonymousBoxChild):
(WebCore::RenderBlock::removeChild):
- 12:38 PM Changeset in webkit [125314] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/11855229> When in paginated mode, the layout timer fires continually
https://bugs.webkit.org/show_bug.cgi?id=91038
Reviewed by Simon Fraser.
- page/Page.cpp:
(WebCore::Page::pageCount): Changed to only trigger layout if needed.
- 12:22 PM Changeset in webkit [125313] by
-
- 7 edits45 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Updating or adding newly-generated pixel baselines for tests in animations,
dom/xhtml/level3/core, scrollbars, transforms and transitions directories.
- platform/gtk/animations/3d/change-transform-in-end-event-expected.png: Added.
- platform/gtk/animations/3d/matrix-transform-type-animation-expected.png: Added.
- platform/gtk/animations/3d/replace-filling-transform-expected.png: Added.
- platform/gtk/animations/3d/state-at-end-event-transform-expected.png: Added.
- platform/gtk/animations/additive-transform-animations-expected.png: Added.
- platform/gtk/animations/cross-fade-background-image-expected.png: Added.
- platform/gtk/animations/cross-fade-border-image-source-expected.png: Added.
- platform/gtk/animations/cross-fade-list-style-image-expected.png: Added.
- platform/gtk/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/gtk/animations/cross-fade-webkit-mask-image-expected.png: Added.
- platform/gtk/animations/missing-values-last-keyframe-expected.png: Added.
- platform/gtk/animations/opacity-transform-animation-expected.png: Added.
- platform/gtk/animations/state-at-end-event-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/canonicalform08-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/canonicalform09-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/documentgetinputencoding03-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/entitygetinputencoding02-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/entitygetxmlversion02-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri05-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri07-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri09-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri10-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri11-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri15-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri17-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri18-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png: Added.
- platform/gtk/dom/xhtml/level3/core/nodelookupprefix19-expected.png: Added.
- platform/gtk/scrollbars/basic-scrollbar-expected.png: Added.
- platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
- platform/gtk/scrollbars/disabled-scrollbar-expected.png: Added.
- platform/gtk/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
- platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
- platform/gtk/scrollbars/scrollbar-buttons-expected.png: Added.
- platform/gtk/scrollbars/scrollbar-orientation-expected.png: Added.
- platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.png:
- platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.png: Added.
- platform/gtk/transforms/2d/hindi-rotated-expected.png:
- platform/gtk/transforms/2d/transform-borderbox-expected.png: Added.
- platform/gtk/transforms/2d/transform-fixed-container-expected.png:
- platform/gtk/transforms/2d/transform-origin-borderbox-expected.png: Added.
- platform/gtk/transforms/2d/zoom-menulist-expected.png:
- platform/gtk/transforms/svg-vs-css-expected.png: Added.
- platform/gtk/transitions/cross-fade-background-image-expected.png: Added.
- platform/gtk/transitions/cross-fade-border-image-expected.png: Added.
- platform/gtk/transitions/default-timing-function-expected.png:
- platform/gtk/transitions/move-after-transition-expected.png: Added.
- platform/gtk/transitions/opacity-transition-zindex-expected.png: Added.
- platform/gtk/transitions/suspend-transform-transition-expected.png: Added.
- platform/gtk/transitions/svg-text-shadow-transition-expected.png: Added.
- platform/gtk/transitions/transition-end-event-rendering-expected.png: Added.
- 12:10 PM Changeset in webkit [125312] by
-
- 2 edits in trunk/Source/WebCore
[CMAKE] Fix wrong idl include path in CMakeList.txt
https://bugs.webkit.org/show_bug.cgi?id=93715
Reviewed by Rob Buis.
No new tests. No change in behavior.
- CMakeLists.txt: Fix notifications path.
- 12:06 PM Changeset in webkit [125311] by
-
- 6 edits in branches/safari-536.26-branch/Source/WebKit2
Rollout r124944. <rdar://problem/12043765>
- 11:59 AM Changeset in webkit [125310] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-10
- DEPS:
- 11:49 AM Changeset in webkit [125309] by
-
- 8 edits in branches/safari-536.26-branch
Rollout r124956. <rdar://problem/12043765>
- 11:47 AM Changeset in webkit [125308] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebKit2
Rollout r124959. <rdar://problem/12043765>
- 11:42 AM Changeset in webkit [125307] by
-
- 32 edits2 deletes in branches/safari-536.26-branch
Rollout r124961. <rdar://problem/12043765>
- 11:42 AM Changeset in webkit [125306] by
-
- 5 edits2 adds in trunk
[Transforms] Hit test issue with large scale() transform
https://bugs.webkit.org/show_bug.cgi?id=23170
Reviewed by Simon Fraser.
Source/WebCore:
By using normal rounding to determine the top-left corner of the
hit-tested rectangle, we end up offsetting the hit test by up to
half a pixel, once scaled to x60, this creates a 30px error.
Normal rounding is replaced with floored rounding which means the
hit-tested pixel will now always be the pixel containing the
point.
Test: fast/transforms/hit-test-large-scale.html
- rendering/HitTestResult.cpp:
(WebCore::HitTestPoint::HitTestPoint):
(WebCore::HitTestPoint::intersectsRect):
(WebCore::HitTestPoint::rectForPoint):
LayoutTests:
New test checking that we can hit the bottom-right part of an element with
a large scale transformation.
Modified test-input on perspective-clipped.html, since it was mathematically
0.1px inside the transformed target, but used to miss due to bad rounding.
- fast/transforms/hit-test-large-scale-expected.txt: Added.
- fast/transforms/hit-test-large-scale.html: Added.
- transforms/3d/hit-testing/perspective-clipped-expected.txt:
- transforms/3d/hit-testing/perspective-clipped.html:
- 11:40 AM Changeset in webkit [125305] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed gardening: build fix for 32bit platforms after 125294.
- css/StyleResolver.cpp:
(RuleData):
- 11:35 AM Changeset in webkit [125304] by
-
- 5 edits4 adds in trunk
Source/WebCore: box-shadow creates incorrect shadow when border-radius is too large
https://bugs.webkit.org/show_bug.cgi?id=72103
Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-10
Reviewed by Simon Fraser.
Added a code for adjusting a rounded rect before paintBoxShadow in
a similar way to getRoundedRectFor.
Test: fast/borders/border-shadow-large-radius.html
- platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::adjustRadii):
Added a new method to set radii's scale to fit into rect.
- platform/graphics/RoundedRect.h:
(RoundedRect):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
A rounded rect for box-shadow is not checked whether the raii matches
the rect or not. Added the code to adjust radii's scale if the rounded
rect is not renderable, the case: RoundedRect::isRenderable is false.
LayoutTests: box-shadow creates incorrect shadow when border-radius is too large.
https://bugs.webkit.org/show_bug.cgi?id=72103
Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-10
Reviewed by Simon Fraser.
- fast/borders/border-shadow-large-radius.html: Added.
- fast/borders/border-shadow-large-radius-expected.txt: Added.
- platform/chromium-linux/fast/borders/border-shadow-large-radius-expected.png: Added.
- platform/chromium-mac/fast/borders/border-shadow-large-radius-expected.png: Added.
- 11:31 AM Changeset in webkit [125303] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Removing expectation for css3/flexbox/inline-flex-crash2.html after
the fix for it was landed in r125302.
- platform/gtk/TestExpectations:
- 11:24 AM Changeset in webkit [125302] by
-
- 3 edits in trunk/LayoutTests
New test introduced in r125262 css3/flexbox/inline-flex-crash2.html fails
https://bugs.webkit.org/show_bug.cgi?id=93718
Test uses layoutTestController instead of testRunner.
- css3/flexbox/inline-flex-crash2.html:
- platform/qt/Skipped:
- 11:21 AM Changeset in webkit [125301] by
-
- 2 edits in trunk/Source/WebCore
Wrap INLINE_FLEX in a #if ENABLE(CSS3_FLEXBOX).
Unreviewed build fix.
- rendering/style/RenderStyle.h:
- 10:57 AM Changeset in webkit [125300] by
-
- 2 edits in trunk/Source/WebKit
[BlackBerry] Fix wrong include path for notifications.
https://bugs.webkit.org/show_bug.cgi?id=93714
Reviewed by Rob Buis.
- PlatformBlackBerry.cmake: Change path from notifications to Modules/notifications.
- 10:52 AM Changeset in webkit [125299] by
-
- 2 edits in trunk/Tools
[Chromium-Android][NRWT] Executable might not be pushed correctly when there are multiple builds
https://bugs.webkit.org/show_bug.cgi?id=93688
Reviewed by Dirk Pranke.
There might be other better methods, but this change is the smallest.
I think the chance of equal timestamp can be ignored because we flock
to avoid concurrent linkers.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._push_executable): Changed '<' to '!=' to compare the timestamp.
- 10:42 AM Changeset in webkit [125298] by
-
- 2 edits in trunk/Source/WebCore
Renamed the “Modules/webaudio” group in the Xcode project to “webaudio” and moved it into
the Modules group.
Rubber-stamped by Simon Fraser.
- WebCore.xcodeproj/project.pbxproj:
- 10:35 AM Changeset in webkit [125297] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for failures introduced in r125133 and r125262.
- platform/gtk/TestExpectations:
- 10:05 AM Changeset in webkit [125296] by
-
- 4 edits1 add in trunk
[V8] Enable es5_readonly
https://bugs.webkit.org/show_bug.cgi?id=91031
Reviewed by Adam Barth.
This turns on the es5_readonly flag for V8. This makes V8 match the ES5 spec regarding
non writable properties on the prototype chain. JSC already behaves the right so this
just makes V8 behave the same.
Source/WebCore:
Updated test expectations.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initIsolate):
LayoutTests:
- platform/chromium/media/network-no-source-const-shadow-expected.txt: Added.
- 10:03 AM Changeset in webkit [125295] by
-
- 17 edits2 adds2 deletes in trunk/Source/WebCore
[V8] Introduce V8DOMConfiguration class and make batchConfigureXXX() methods static
https://bugs.webkit.org/show_bug.cgi?id=93615
Reviewed by Adam Barth.
Per the discussion in bug 93239,
(1) Rename V8ConfigureDOMAttributesAndMethods to V8DOMConfiguration.
(2) Introduce V8DOMConfiguration class and make batchConfigureXXX() methods static.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore):
(WebCore::ConfigureV8TestExceptionTemplate):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::ConfigureV8TestNamedConstructorTemplate):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
- bindings/v8/V8Binding.h:
- bindings/v8/V8ConfigureDOMAttributesAndMethods.h: Removed.
- bindings/v8/V8DOMConfiguration.cpp: Renamed from Source/WebCore/bindings/v8/V8ConfigureDOMAttributesAndMethods.cpp.
(WebCore):
(WebCore::V8DOMConfiguration::batchConfigureAttributes):
(WebCore::V8DOMConfiguration::batchConfigureConstants):
(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):
- bindings/v8/V8DOMConfiguration.h: Added.
(WebCore):
(V8DOMConfiguration):
(BatchedAttribute):
(WebCore::V8DOMConfiguration::configureAttribute):
(BatchedConstant):
(BatchedCallback):
- 10:00 AM Changeset in webkit [125294] by
-
- 4 edits in trunk/Source/WebCore
CSS: Shrink RuleData by storing selector as index rather than pointer.
<http://webkit.org/b/93712>
Reviewed by Antti Koivisto.
Pack the selector's index in the rule in the RuleData bitfield, effectively
shrinking each RuleData by 8 bytes.
- css/CSSSelectorList.h:
(WebCore::CSSSelectorList::selectorAt):
(WebCore::CSSSelectorList::indexOfNextSelectorAfter):
Add helpers to CSSSelectorList to iterate by index.
- css/StyleResolver.cpp:
(RuleData):
(WebCore::RuleData::selector):
(WebCore::RuleData::selectorIndex):
(SameSizeAsRuleData):
(RuleSet):
(WebCore::makeRuleSet):
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleResolver.h:
(WebCore::StyleResolver::RuleFeature::RuleFeature):
(RuleFeature):
Store selector indices instead of CSSSelector* pointers.
- 9:48 AM Changeset in webkit [125293] by
-
- 12 edits1 delete in trunk/Source/WebCore
Remove custom bindings from WaveShaperNode.
https://bugs.webkit.org/show_bug.cgi?id=93613
Patch by Vineet Chaudhary <Vineet> on 2012-08-10
Reviewed by Kentaro Hara.
We should remove custom bindings as CodeGenerator uses UNUSED_PARAM macro.
TestObj.idl
No behavioural changes.
All tests under webaudio/* should behave same.
- GNUmakefile.list.am: Removed JSWaveShaperNodeCustom.cpp from builds.
- Modules/webaudio/WaveShaperNode.idl: Removed [JSCustomSetter].
- UseJSC.cmake: Removed JSWaveShaperNodeCustom.cpp from builds.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSWaveShaperNodeCustom.cpp: Removed.
- bindings/scripts/CodeGeneratorCPP.pm:
(SkipAttribute): Skip TypedArray attribute.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute): Skip TypedArray attribute.
- bindings/scripts/CodeGeneratorObjC.pm:
(SkipAttribute): Skip TypedArray attribute.
- bindings/scripts/test/JS/JSTestObj.cpp: Bindings tests.
(WebCore::jsTestObjTypedArrayAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjTypedArrayAttr):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/TestObj.idl: Test.
- bindings/scripts/test/V8/V8TestObj.cpp: Bindings tests.
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
- 9:35 AM Changeset in webkit [125292] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r123848): Heap-use-after-free in WebCore::CachedResource::didAddClient.
https://bugs.webkit.org/show_bug.cgi?id=93632
-and corresponding-
<http://crbug.com/140656>
Patch by Huang Dongsung <luxtella@company100.net> on 2012-08-10
Reviewed by Antti Koivisto.
CachedCSSStyleSheet::didAddClient() calls CachedStyleSheetClient::setCSSStyleSheet
and HTMLLnkElement can be CachedStyleSheetClient.
HTMLLinkElement::setCSSStyleSheet may cause scripts to be executed, which could
destroy the HTMLLinkElement instance. After calliing
CachedStyleSheetClient::setCSSStyleSheet, using the CachedStyleSheetClient
instance can cause Heap-use-after-free.
r115625 prevents HTMLLinkElement from being destroyed during
HTMLLinkElement::setCSSStyleSheet, but r115625 doesn't prevent HTMLLinkElement
from being destroyed after HTMLLinkElement::setCSSStyleSheet.
So this patch calls CachedResource::didAddClient() before calling
setCSSStyleSheet() to make sure its client is not destroyed.
No new tests. it's covered by fast/css/cached-sheet-restore-crash.html.
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::didAddClient):
- 9:30 AM Changeset in webkit [125291] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] WebViewLoadFavIcon::test_favIconLoad() fails
https://bugs.webkit.org/show_bug.cgi?id=91888
Reviewed by Simon Hausmann.
- UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:
We should wait for iconChanged signal instead of loadFinished,
there was no guarantee that at that point we would get it already.
- 9:21 AM Changeset in webkit [125290] by
-
- 2 edits in trunk/Source/JavaScriptCore
[BlackBerry] GCActivityCallback should always schedule GC even allocated bytes is a small number
https://bugs.webkit.org/show_bug.cgi?id=93650
Patch by Yong Li <yoli@rim.com> on 2012-08-10
Reviewed by Rob Buis.
Even a small number of allocated JS objects could hold expensive resources.
- runtime/GCActivityCallbackBlackBerry.cpp:
(JSC::DefaultGCActivityCallback::didAllocate):
- 9:15 AM Changeset in webkit [125289] by
-
- 3 edits in trunk/Source/WebCore
Horizontal scrollbar appears in the month-year selector of input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=93517
Patch by Kevin Ellis <kevers@chromium.org> on 2012-08-10
Reviewed by Kent Tamura.
Update size of the month-year selector popup to account for the
width of the vertical scrollbar being platform dependent.
- Resources/calendarPicker.css:
(.month-selector-popup): Suppress horizontal scrolling.
- Resources/calendarPicker.js:
(YearMonthController.prototype.attachTo): Add a sizer element to facilitate determining the scrollbar width.
(YearMonthController.prototype._showPopup): Use computed scrollbar width for popup resizing.
- 9:08 AM Changeset in webkit [125288] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Uninitialized flags in CoordinatedGraphicsLayer
https://bugs.webkit.org/show_bug.cgi?id=93719
Reviewed by Kenneth Rohde Christiansen.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
- 9:06 AM Changeset in webkit [125287] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Unreviewed, fix frontend compilability after r125268.
- inspector/front-end/CSSStyleModel.js:
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):
- 9:00 AM Changeset in webkit [125286] by
-
- 2 edits in branches/safari-536.26-branch/Source/JavaScriptCore
Windows build fix after merging radar 12050720.
Add missing symbols.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 8:56 AM Changeset in webkit [125285] by
-
- 50 edits in trunk
[Qt] Dotted borders not drawn with rounded dots
https://bugs.webkit.org/show_bug.cgi?id=92383
Patch by Martin Leutelt <martin.leutelt@basyskom.com> on 2012-08-10
Reviewed by Noam Rosenthal.
The dots in borders with dotted style were previously drawn with
rectangular dots. The CSS spec specifies that the dots should be
rounded dots. This patch fixes this behavior for the Qt port.
No new tests, existing ones have been updated with new expected
results.
Source/WebCore:
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::adjustPointsForDottedLine):
(WebCore):
(WebCore::drawLineEndpointsForStyle):
(WebCore::GraphicsContext::drawLine):
LayoutTests:
- platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-94-d-expected.png:
- platform/qt/editing/inserting/editing-empty-divs-expected.png:
- platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
- platform/qt/fast/css/margin-top-bottom-dynamic-expected.png:
- platform/qt/fast/layers/opacity-outline-expected.png:
- platform/qt/fast/lists/ordered-list-with-no-ol-tag-expected.png:
- platform/qt/fast/multicol/progression-reverse-expected.png:
- platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.png:
- platform/qt/fast/table/border-collapsing/001-expected.png:
- platform/qt/fast/table/border-collapsing/001-vertical-expected.png:
- platform/qt/svg/custom/no-inherited-dashed-stroke-expected.png:
- platform/qt/svg/transforms/svg-css-transforms-expected.png:
- platform/qt/tables/mozilla/bugs/bug22019-expected.png:
- platform/qt/tables/mozilla/bugs/bug2947-expected.png:
- platform/qt/tables/mozilla/bugs/bug6674-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_position-table-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
- platform/qt/transforms/svg-vs-css-expected.png:
- 8:42 AM Changeset in webkit [125284] by
-
- 12 edits in trunk
Web Inspector: render arrays as dir in case they were logged into console prior to the front-end opening.
https://bugs.webkit.org/show_bug.cgi?id=93713
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Dumping potentially outdated arrays using the "dir" representation.
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessageImpl.prototype.clone):
- inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleModel.prototype.enableAgent.callback):
(WebInspector.ConsoleModel.prototype.enablingConsole):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.create):
LayoutTests:
- inspector/console/console-dirxml-expected.txt:
- inspector/console/console-external-array-expected.txt:
- inspector/console/console-format-collections-expected.txt:
- inspector/console/console-format-expected.txt:
- inspector/console/console-format.html:
- inspector/console/console-tests-expected.txt:
- platform/chromium/inspector/console/console-format-collections-expected.txt:
- 8:36 AM Changeset in webkit [125283] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Fix the colors in the debugging HUD
https://bugs.webkit.org/show_bug.cgi?id=93656
Reviewed by Adrienne Walker.
The R and B channels became swapped in our compositor debug HUD when
wkb.ug/92182 happened. This corrects the problem by swizzling the
color channels when we draw to the SkCanvas, so that it matches the
expectations of the shader.
Chromium bug: crbug.com/139908
- platform/graphics/chromium/cc/CCFontAtlas.cpp:
(WebCore::CCFontAtlas::drawText):
(WebCore::CCFontAtlas::drawOneLineOfTextInternal):
- platform/graphics/chromium/cc/CCFontAtlas.h:
(CCFontAtlas):
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
(WebCore::createPaint):
(WebCore):
(WebCore::CCHeadsUpDisplayLayerImpl::drawHudContents):
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounter):
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounterText):
(WebCore::CCHeadsUpDisplayLayerImpl::drawDebugRects):
- 8:29 AM Changeset in webkit [125282] by
-
- 6 edits in trunk/Source
[chromium] Remove scissor from the namings in CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=93630
Reviewed by Adrienne Walker.
Source/WebCore:
As a followup to wkb.ug/91800 which stops using partial-swap scissor
in the occlusion tracker, this does a large rename to the occlusion
tracker and affected tests to remove "scissor" from the names of its
variables and methods, instead reflecting their new behaviour.
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::CCOcclusionTrackerBase):
(WebCore::addOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::::occluded):
(WebCore::computeUnoccludedContentRect):
(WebCore::::unoccludedContentRect):
(WebCore::::unoccludedContributingSurfaceContentRect):
(WebCore::::layerClipRectInTarget):
(WebCore):
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::computeVisibleRegionInScreen):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::TestCCOcclusionTrackerWithClip::TestCCOcclusionTrackerWithClip):
(WebKitTests::TestCCOcclusionTrackerWithClip::setLayerClipRect):
(WebKitTests::TestCCOcclusionTrackerWithClip::useDefaultLayerClipRect):
(WebKitTests::TestCCOcclusionTrackerWithClip::layerClipRectInTarget):
(TestCCOcclusionTrackerWithClip):
(WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerClipRectOutsideChild::runMyTest):
(WebKitTests):
(WebKitTests::CCOcclusionTrackerTestViewportRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerClipRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestViewportRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerClipRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestViewportRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerClipRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestViewportRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerClipRectForLayerOffOrigin::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestUnsorted3dLayers::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToViewport::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestMinimumTrackingSize::runMyTest):
- tests/TiledLayerChromiumTest.cpp:
- 8:21 AM Changeset in webkit [125281] by
-
- 2 edits in branches/safari-536.26-branch/Source/JavaScriptCore
Windows build fix after merging radar 12050720.
Part 2 - removing symbols.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 8:20 AM Changeset in webkit [125280] by
-
- 6 edits2 adds in trunk
Change Notification.permissionLevel() to Notification.permission
https://bugs.webkit.org/show_bug.cgi?id=88919
<rdar://problem/11650319>
Reviewed by Kentaro Hara.
Source/WebCore:
Retrieving the permission level has changed to Notification.permission, per this discussion:
http://lists.w3.org/Archives/Public/public-web-notification/2012Jun/0000.html
Test: fast/notifications/notifications-permission.html
- Modules/notifications/Notification.cpp: Rename to match attribute name.
(WebCore::Notification::permission):
- Modules/notifications/Notification.h: Rename to match attribute name.
(Notification):
- Modules/notifications/Notification.idl: Change to static readonly attribute.
LayoutTests:
- fast/notifications/notifications-permission-expected.txt: Added.
- fast/notifications/notifications-permission.html: Added.
- platform/chromium/TestExpectations: V8 does not properly support IDL static
attributes. This is tracked in bug 93488.
- 8:16 AM Changeset in webkit [125279] by
-
- 4 edits in trunk/Source/WebCore
[V8] Remove collectIsolatedContexts() from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93682
Reviewed by Adam Barth.
We want to remove V8Proxy. This patch removes V8Proxy::collectIsolatedContexts().
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::collectIsolatedContexts):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::collectIsolatedContexts):
- 7:12 AM Changeset in webkit [125278] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Unreviewed trivial build fix: Avoid passing a non-existance WebCore/websockets directory
to the generators, which produces unnecessary warnings. The module lives now in WebCore/Modules/websockets.
- DerivedSources.pri:
- 6:42 AM Changeset in webkit [125277] by
-
- 10 edits1 delete in trunk
Web Inspector: add frame ids to TimeStamp, Time and TimeEnd records in Timeline
https://bugs.webkit.org/show_bug.cgi?id=93699
Reviewed by Pavel Feldman.
Source/WebCore:
- plumb Frame from Console to TimelineAgent and use it to add frameId to 3 timeline records;
- inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::startConsoleTiming):
(WebCore::InspectorInstrumentation::stopConsoleTiming):
(WebCore::InspectorInstrumentation::consoleTimeStamp):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::startConsoleTimingImpl):
(WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
(WebCore::InspectorInstrumentation::consoleTimeStampImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::time):
(WebCore::InspectorTimelineAgent::timeEnd):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- page/Console.cpp:
(WebCore::Console::markTimeline):
(WebCore::Console::time):
(WebCore::Console::timeEnd):
(WebCore::Console::timeStamp):
LayoutTests:
- rebased expectations to include frameId field;
- removed platform overrides for chromium as these are identical to the default ones;
- inspector/timeline/timeline-mark-timeline-expected.txt:
- inspector/timeline/timeline-time-stamp-expected.txt:
- platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt: Removed.
- platform/chromium/inspector/timeline/timeline-time-stamp-expected.txt: Removed.
- 6:40 AM Changeset in webkit [125276] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix failing assertions when using JSC C API in QObject bridge
https://bugs.webkit.org/show_bug.cgi?id=93720
Reviewed by Kenneth Rohde Christiansen.
Avoid calling JSValueProtect and JSValueIsEqual with null JSValueRefs, as in debug
builds they trigger failing assertions about the arguments being non-null.
In these signal & slot connections the receiver can be null, when the signal is connected
just to a function, for example using obj.mySignal.connect(function() { .... }).
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::QtConnectionObject):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
(JSC::Bindings::QtConnectionObject::match):
- 6:37 AM Changeset in webkit [125275] by
-
- 4 edits in trunk/Source
[Qt] Remove QRegExp <> JS RegExp conversion
https://bugs.webkit.org/show_bug.cgi?id=93716
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Removed automatic conversion between QRegExp and JS regular expressions. The semantics
between the expressions are totally different, which can cause data loss and unexpected
behaviour. QJSEngine/Value doesn't have this conversion anymore neither.
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::operator<<):
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
Source/WebKit/qt:
Removed tests that cover the automatic QRegExp <> JS RegExp conversion. See WebCore
ChangeLog for details.
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(MyQObject::emitMySignalWithDateTimeArg):
(MyQObject):
(tst_QObjectBridge::overloadedSlots):
(tst_QObjectBridge::typeConversion):
- 6:35 AM Changeset in webkit [125274] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviwed gardening.
https://bugs.webkit.org/show_bug.cgi?id=93718
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-10
- platform/qt/Skipped: xmlviewer/extensions-api.html moved, skip new failing test after r125262.
- 6:29 AM Changeset in webkit [125273] by
-
- 1 edit2 adds in trunk/LayoutTests
[EFL][WK2] Add Skipped file for EFL WK2
https://bugs.webkit.org/show_bug.cgi?id=93645
Unreviewed gardening.
Added LayoutTests/platform/efl-wk2/Skipped file, so that it will be possible to keep EFL WK2 bot green.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-10
- platform/efl-wk2/Skipped: Added.
- 6:24 AM Changeset in webkit [125272] by
-
- 6 edits1 delete in trunk
Web Inspector: console.timeStamp() marked are not shown in Timeline overview
https://bugs.webkit.org/show_bug.cgi?id=93697
Reviewed by Pavel Feldman.
Source/WebCore:
- ignore frameId on TimeStamp records, consider it's always an event divider.
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.isEventDivider):
LayoutTests:
- add support for dumpting timestamp records to timeline test suite;
- dump timestamp records for TimeStamp tests;
- inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.stopTimeline):
(initialize_Timeline.InspectorTest.performActionsAndPrint.step3):
(initialize_Timeline.InspectorTest.performActionsAndPrint):
(initialize_Timeline.InspectorTest.printTimelineRecords):
(initialize_Timeline.InspectorTest.printTimestampRecords):
(initialize_Timeline.InspectorTest.innerPrintTimelineRecords):
- inspector/timeline/timeline-time-stamp-expected.txt:
- inspector/timeline/timeline-time-stamp.html:
- platform/chromium/inspector/timeline/timeline-time-stamp-expected.txt: Removed.
- 6:10 AM WebInspector edited by
- (diff)
- 4:46 AM Changeset in webkit [125271] by
-
- 4 edits in trunk
[CSS Regions] region-overflow: break still renders the content that does not fit in the last region.
https://bugs.webkit.org/show_bug.cgi?id=92996
Reviewed by Julien Chaffraix.
Source/WebCore:
Flow content that follows the last break in the last region, if any, should not be rendered
for the regions with region-overflow: break.
http://www.w3.org/TR/css3-regions/#the-region-overflow-property
Modified the expected result for existing test fast/regions/region-overflow-break.html
to reflect the correct behavior.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOversetRect):
LayoutTests:
Modified expected result for original test to match the behavior described in the regions spec.
- fast/regions/region-overflow-break-expected.html:
- 4:27 AM Changeset in webkit [125270] by
-
- 2 edits in branches/safari-536.26-branch/Source/JavaScriptCore
Windows build fix after merging radar 12050720.
- 3:09 AM Changeset in webkit [125269] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=93700
Unreviewed EFL gardening.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-10
- platform/efl/Skipped: Test extensions-api.html moved out of
the http directory in r125222.
- platform/efl/TestExpectations: Add failing tests to the Test
Expectations and unskip passing test.
- 2:58 AM Changeset in webkit [125268] by
-
- 12 edits in trunk
Web Inspector: Protocol Extension: Refactor protocol extension for CSS Regions
https://bugs.webkit.org/show_bug.cgi?id=92089
Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-08-10
Reviewed by Pavel Feldman.
Source/WebCore:
Replaced "WebKitNamedFlowCollection::namedFlowsNames" with "WebKitNamedFlowCollection::namedFlows" to return a Vector of "WebKitNamedFlow"s,
instead of a Vector of Strings.
Added the "Region" type to Inspector.json.
Changed the "NamedFlow" type and the "getNamedFlowCollection" function in Inspector.json.
Modified existing test: inspector/styles/protocol-css-regions-commands.html
- dom/WebKitNamedFlowCollection.cpp:
(WebCore::WebKitNamedFlowCollection::namedFlows):
- dom/WebKitNamedFlowCollection.h:
(WebKitNamedFlowCollection):
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore::InspectorCSSAgent::buildArrayForRegions):
(WebCore):
(WebCore::InspectorCSSAgent::buildObjectForNamedFlow):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushNodeToFrontend):
(WebCore):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):
LayoutTests:
Changed the test to validate the changes made to the protocol.
- inspector/styles/protocol-css-regions-commands-expected.txt:
- inspector/styles/protocol-css-regions-commands.html:
- 2:57 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 2:51 AM Changeset in webkit [125267] by
-
- 5 edits in trunk/Source/WebKit2
[WK2][GTK] Implement new API to save a web page using MHTML
https://bugs.webkit.org/show_bug.cgi?id=89873
Reviewed by Carlos Garcia Campos.
Implemented new asynchronous API in WebKitWebView for saving a web
page to a GInputStream or to a file, using MHTML as the only
supported method at the moment.
- UIProcess/API/gtk/WebKitWebView.cpp:
(ViewSaveAsyncData):
(webViewFileSavedCallback):
(webViewMHTMLDataGotCallback):
(webkit_web_view_save):
(webkit_web_view_save_finish):
(webkit_web_view_save_to_file):
(webkit_web_view_save_to_file_finish):
- UIProcess/API/gtk/WebKitWebView.h:
Added new unit test.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSave):
(beforeAll):
(afterAll):
Updated documentation files with new symbols.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- 2:46 AM Changeset in webkit [125266] by
-
- 3 edits in trunk/Source/WebCore
Resize calandar and color suggestion popups to show error message
https://bugs.webkit.org/show_bug.cgi?id=93695
Reviewed by Kent Tamura.
r125169 made PagePopupClient::contentSize() return zero size and so to
see the error message, we need to resize the page popup.
No new tests. Not user facing.
- Resources/calendarPicker.js:
(resizeWindow): Resizes popup window to given size.
(showMain): Initiates transition to show the main element.
(initialize):
(fixWindowSize):
- Resources/colorSuggestionPicker.js:
(resizeWindow):
(initialize):
(ColorPicker.prototype._layout):
- 2:43 AM Changeset in webkit [125265] by
-
- 16 edits1 copy in trunk/Source/WebCore
Web Inspector: further ResourceLoader memory instrumentation
https://bugs.webkit.org/show_bug.cgi?id=93692
Reviewed by Vsevolod Vlasov.
Added missing parts to ResourceLoader and its descendants memory instrumentation.
Added special logic for KURL and report the urls where we have them in instrumented classes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/MemoryInstrumentation.cpp:
(WebCore::MemoryInstrumentation::addObject):
(WebCore):
- dom/MemoryInstrumentation.h:
(WebCore):
(MemoryInstrumentation):
(WebCore::MemoryClassInfo::addMember):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore):
- loader/MainResourceLoader.h:
(MainResourceLoader):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::reportMemoryUsage):
(WebCore):
- loader/SubresourceLoader.h:
(SubresourceLoader):
- loader/SubstituteData.cpp: Copied from Source/WebCore/dom/MemoryInstrumentation.cpp.
(WebCore):
(WebCore::SubstituteData::reportMemoryUsage):
- loader/SubstituteData.h:
(WebCore):
(SubstituteData):
- 2:30 AM Changeset in webkit [125264] by
-
- 6 edits in trunk/LayoutTests
Unreviewed gardening, rebaselining marked tests from r125167.
- platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.txt:
- platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
- 2:24 AM Changeset in webkit [125263] by
-
- 2 edits10 adds in trunk/Source/WebCore
[Forms] Introduce shadow elements for multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=92960
Reviewed by Kent Tamura.
This patch introduces shadow elements for multiple fields time input UI:
- DateTimeAMPMFieldElement - field UI for AM/PM
- DateTimeEditElement - container of multiple DateTimeFieldElement
- DateTimeFieldElement - base class of field UI
- DateTimeHourFieldElement - field UI for hour
- DateTimeMillisecondFieldElement - field UI for millisecond
- DateTimeMinuteFieldElement - field UI for minute
- DateTimeNumericFieldElement - base class of numeric field UI.
- DateTimeSecondFieldElement - field UI for second
- DateTimeSymbolicFieldElement - base class for symbolic field UI
inside of ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS build flag.
No new tests. This patch doesn't change behavior.
- WebCore.gypi: Changed to include html/shadow/DateTimeEditElement.cpp,
html/shadow/DateTimeEdditElement.h, html/shadow/DateTimeFieldElement.cpp,
html/shadow/DateTimeFieldElement.h, html/shadow/DateTimeFieldElements.cpp,
html/shadow/DateTimeFieldElements.h, html/shadow/DateTimeNumericFieldElement.cpp,
html/shadow/DateTimeNumericFieldElement.h, html/shadow/DateTimeSymbolicFieldElement.cpp,
and html/shadow/DateTimeSymbolicFieldElement.h.
- html/shadow/DateTimeEditElement.cpp: Added.
(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::build):
(WebCore::DateTimeEditBuilder::needMillisecondField):
(WebCore::DateTimeEditBuilder::needMinuteField):
(WebCore::DateTimeEditBuilder::needSecondField):
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldReadOnly):
(WebCore::DateTimeEditBuilder::shouldMinuteFieldReadOnly):
(WebCore::DateTimeEditBuilder::shouldSecondFieldReadOnly):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::EditControlOwner::~EditControlOwner):
(WebCore::DateTimeEditElement::DateTimeEditElement):
(WebCore::DateTimeEditElement::~DateTimeEditElement):
(WebCore::DateTimeEditElement::addField):
(WebCore::DateTimeEditElement::create):
(WebCore::DateTimeEditElement::disabledStateChanged): Called when owner's disabled state is changed.
(WebCore::DateTimeEditElement::fieldAt):
(WebCore::DateTimeEditElement::focusFieldAt):
(WebCore::DateTimeEditElement::handleKeyboardEvent):
(WebCore::DateTimeEditElement::fieldValueChanged):
(WebCore::DateTimeEditElement::focusOnNextField):
(WebCore::DateTimeEditElement::handleMouseEvent):
(WebCore::DateTimeEditElement::isDisabled):
(WebCore::DateTimeEditElement::isReadOnly):
(WebCore::DateTimeEditElement::layout):
(WebCore::DateTimeEditElement::nextFieldIndex):
(WebCore::DateTimeEditElement::previousFieldIndex):
(WebCore::DateTimeEditElement::readOnlyStateChanged): Called when owner's readOnly state is changed.
(WebCore::DateTimeEditElement::resetLayout):
(WebCore::DateTimeEditElement::defaultEventHandler):
(WebCore::DateTimeEditElement::setValueAsDate):
(WebCore::DateTimeEditElement::setEmptyValue):
(WebCore::DateTimeEditElement::spinButtonStepDown):
(WebCore::DateTimeEditElement::spinButtonStepUp):
(WebCore::DateTimeEditElement::updateUIState):
(WebCore::DateTimeEditElement::valueAsDouble):
- html/shadow/DateTimeEditElement.h: Added.
(DateTimeEditElement):
(EditControlOwner):
(WebCore::DateTimeEditElement::removeEditControlOwner):
- html/shadow/DateTimeFieldElement.cpp: Added.
(WebCore::DateTimeFieldElement::FieldEventHandler::~FieldEventHandler):
(WebCore::DateTimeFieldElement::DateTimeFieldElement):
(WebCore::DateTimeFieldElement::defaultEventHandler):
(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
(WebCore::DateTimeFieldElement::focusOnNextField):
(WebCore::DateTimeFieldElement::initialize):
(WebCore::DateTimeFieldElement::isReadOnly):
(WebCore::DateTimeFieldElement::setReadOnly):
(WebCore::DateTimeFieldElement::updateVisibleValue):
(WebCore::DateTimeFieldElement::valueAsDouble):
- html/shadow/DateTimeFieldElement.h: Added.
(DateTimeFieldElement):
(FieldEventHandler):
(WebCore::DateTimeFieldElement::removeEventHandler):
- html/shadow/DateTimeFieldElements.cpp: Added.
(WebCore::DateTimeAMPMFieldElement::DateTimeAMPMFieldElement):
(WebCore::DateTimeAMPMFieldElement::create):
(WebCore::DateTimeAMPMFieldElement::setValueAsDate):
(WebCore::DateTimeAMPMFieldElement::unitInMillisecond):
(WebCore::DateTimeHourFieldElement::DateTimeHourFieldElement):
(WebCore::DateTimeHourFieldElement::create):
(WebCore::DateTimeHourFieldElement::setValueAsDate):
(WebCore::DateTimeHourFieldElement::setValueAsInteger):
(WebCore::DateTimeHourFieldElement::unitInMillisecond):
(WebCore::DateTimeHourFieldElement::valueAsInteger):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::setValueAsDate):
(WebCore::DateTimeMillisecondFieldElement::unitInMillisecond):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::setValueAsDate):
(WebCore::DateTimeMinuteFieldElement::unitInMillisecond):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeSecondFieldElement::setValueAsDate):
(WebCore::DateTimeSecondFieldElement::unitInMillisecond):
- html/shadow/DateTimeFieldElements.h: Added.
(DateTimeAMPMFieldElement):
(DateTimeHourFieldElement):
(DateTimeMillisecondFieldElement):
(DateTimeMinuteFieldElement):
(DateTimeSecondFieldElement):
- html/shadow/DateTimeNumericFieldElement.cpp: Added.
(WebCore::displaySizeOfNumber):
(WebCore::DateTimeNumericFieldElement::Range::Range):
(WebCore::DateTimeNumericFieldElement::Range::clumpValue):
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::hasValue):
(WebCore::DateTimeNumericFieldElement::setEmptyValue):
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::stepDown):
(WebCore::DateTimeNumericFieldElement::stepUp):
(WebCore::DateTimeNumericFieldElement::value):
(WebCore::DateTimeNumericFieldElement::valueAsInteger):
(WebCore::DateTimeNumericFieldElement::visibleValue):
- html/shadow/DateTimeNumericFieldElement.h: Added.
(DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::clumpValue):
(WebCore::DateTimeNumericFieldElement::range):
- html/shadow/DateTimeSymbolicFieldElement.cpp: Added.
(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
(WebCore::DateTimeSymbolicFieldElement::handleKeyboardEvent):
(WebCore::DateTimeSymbolicFieldElement::hasValue):
(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
(WebCore::DateTimeSymbolicFieldElement::setValueAsInteger):
(WebCore::DateTimeSymbolicFieldElement::stepDown):
(WebCore::DateTimeSymbolicFieldElement::stepUp):
(WebCore::DateTimeSymbolicFieldElement::value):
(WebCore::DateTimeSymbolicFieldElement::valueAsInteger):
(WebCore::DateTimeSymbolicFieldElement::visibleValue):
- html/shadow/DateTimeSymbolicFieldElement.h: Added.
(DateTimeSymbolicFieldElement):
- 2:06 AM Changeset in webkit [125262] by
-
- 4 edits6 adds in trunk
implement display: -webkit-inline-flex
https://bugs.webkit.org/show_bug.cgi?id=77772
Reviewed by Ojan Vafai.
Source/WebCore:
The crashes last time were because we were marking too much of the tree for relayout. During some editing
operations, this causes a layout when we're in an inconsistent state.
Tests: css3/flexbox/inline-flex-crash.html
css3/flexbox/inline-flex-crash2.html
css3/flexbox/inline-flex.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Only layout the child.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Only layout the child.
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Only layout the child.
- rendering/style/RenderStyle.h: Include INLINE_FLEX as an inline and replaced display type.
LayoutTests:
Include 2 crash tests that caused this to be reverted the last time.
- css3/flexbox/inline-flex-crash-expected.txt: Added.
- css3/flexbox/inline-flex-crash.html: Added.
- css3/flexbox/inline-flex-crash2-expected.txt: Added.
- css3/flexbox/inline-flex-crash2.html: Added.
- css3/flexbox/inline-flex-expected.html: Added.
- css3/flexbox/inline-flex.html: Added.
- 1:46 AM Changeset in webkit [125261] by
-
- 4 edits in trunk/Source/WebCore
Moving the common code from CodegeneratorJS/V8.pm to Codegenerator.pm
https://bugs.webkit.org/show_bug.cgi?id=93616
Patch by Vineet Chaudhary <Vineet> on 2012-08-10
Reviewed by Adam Barth.
IsArrayType() IsConstructorTemplate() IsTypedArrayType() these methods
has the common implementaion for both V8 and JS and can be moved to
common place Codegenerator.pm
No new tests. There should be no behavioural changes.
- bindings/scripts/CodeGenerator.pm: Moved common code here.
(IsArrayType):
(IsConstructorTemplate):
(IsSVGTypeWithWritablePropertiesNeedingTearOff):
(IsTypedArrayType):
- bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(AddClassForwardIfNeeded):
(GenerateHeader):
(GenerateParametersCheckExpression):
(GenerateImplementation):
(NativeToJSValue):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
(IsConstructable):
- bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):
(GenerateHeader):
(GetHeaderClassInclude):
(GenerateParametersCheckExpression):
(GenerateImplementation):
(GetTypeNameOfExternalTypedArray):
- 1:16 AM Changeset in webkit [125260] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r125230 and r125238.
http://trac.webkit.org/changeset/125230
http://trac.webkit.org/changeset/125238
https://bugs.webkit.org/show_bug.cgi?id=93698
Broke ChromiumOS browser tests. (Requested by yutak on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-10
Source/WebCore:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
(WebCore::TiledLayerChromium::updateContentRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):
- platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::contentRectToTileIndices):
(WebCore::CCLayerTilingData::setBounds):
- platform/graphics/chromium/cc/CCPriorityCalculator.h:
Source/WebKit/chromium:
- tests/TiledLayerChromiumTest.cpp:
- 1:08 AM Changeset in webkit [125259] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, rebaselining after r125167.
- platform/gtk/fast/block/float/overhanging-tall-block-expected.txt:
- 12:46 AM Changeset in webkit [125258] by
-
- 14 edits in trunk/Source
Handle SSL errors for SOUP
https://bugs.webkit.org/show_bug.cgi?id=90267
Reviewed by Martin Robinson.
Source/WebCore:
No new tests, this is covered by existing tests.
- platform/LocalizedStrings.h:
(WebCore): Add unacceptableTLSCertificate() for SOUP.
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::unacceptableTLSCertificate):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::unacceptableTLSCertificate):
- platform/network/ResourceHandle.h:
- platform/network/soup/ResourceError.h:
(WebCore::ResourceError::ResourceError): Add new constructor for
SSL errors that receives a certificate and TLS errors.
(WebCore::ResourceError::tlsErrors): Return TLS errors.
(WebCore::ResourceError::certificate): Return the certificate.
- platform/network/soup/ResourceHandleSoup.cpp:
(HostTLSCertificates): Helper class to store certificates for a
host.
(WebCore::HostTLSCertificateSet::add): Add a new certificate.
(WebCore::HostTLSCertificateSet::contains): Check whether
certificate is stored.
(WebCore::HostTLSCertificateSet::computeCertificateHash): Compute
the SHA1 of the certificate data.
(WebCore::allowsAnyHTTPSCertificateHosts): Global set to store
hostnames for which SSL errors should be ignored.
(WebCore::clientCertificates): Global map to store client
certificates.
(WebCore::hasUnignoredTLSErrors): Helper function to check whether
current message contains TLS errors that shouldn't be ignored and
certificate hasn't been approved already.
(WebCore::sendRequestCallback): Finish the load with an error in
case of SSL errors not handled by the SoupSession.
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate): Add
the given hostname to the list of hosts for which SSL errors are
ignored.
(WebCore::ResourceHandle::setClientCertificate): Store the client
certificate for the given host.
(WebCore::ResourceHandle::setIgnoreSSLErrors): Set whether all SSL
errors should be ignored.
Source/WebKit/efl:
Ignore SSL errors by default for compatibility.
- ewk/ewk_main.cpp:
(_ewk_init_body):
Source/WebKit/gtk:
Ignore SSL errors by default for compatibility.
- webkit/webkitglobals.cpp:
(webkitInit):
Source/WebKit2:
Ignore SSL errors by default for compatibility.
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
- 12:42 AM Changeset in webkit [125257] by
-
- 8 edits2 adds in trunk
itemType.add should treat \t as a space.
https://bugs.webkit.org/show_bug.cgi?id=92991
Reviewed by Ryosuke Niwa.
Source/WebCore:
Earlier we used to append a space character i.e, ' ' to the string builder
if the last character of input string is not a space character in addToken()
method. We should add an space character if the last character of input is
not a HTML Space character like, '\n', '\r', '\t', '\f' or ' '.
We can observe the same behavior in FireFox, Opera and IE. They also treat
HTML space character as a space.
Test: fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html
- html/DOMTokenList.cpp:
(WebCore::DOMTokenList::addToken):
LayoutTests:
Added test to verifiy itemtype, itemref, itemprop attributes behavior on adding
a token in presence of trailing space characters.
Rebased existing test cases.
- fast/dom/HTMLElement/class-list-expected.txt:
- fast/dom/HTMLElement/class-list-quirks-expected.txt:
- fast/dom/HTMLElement/script-tests/class-list.js:
- fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
- fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:
- fast/dom/MicroData/domsettabletokenlist-attributes-add-token-expected.txt: Added.
- fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html: Added.
- 12:34 AM Changeset in webkit [125256] by
-
- 4 edits in trunk/Source/WebCore
Remove unused isFlexingChildren and make m_flexingChildren a local variable
https://bugs.webkit.org/show_bug.cgi?id=93689
Reviewed by Ojan Vafai.
isFlexingChildren() is never called, so we can remove it.
m_flexingChildren is now only used locally, so remove the member variable and use a local variable.
No new tests, this is just a refactoring.
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): Make flexingChildren a local.
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): Make flexingChildren a local.
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp): No need to set m_flexingChildren since it's not used
outside of RenderDeprecatedFlexibleBox.
- rendering/RenderDeprecatedFlexibleBox.h:
(RenderDeprecatedFlexibleBox): Remove m_flexingChildren and don't bit pack the remaining bool since it doesn't
do anything for 1 bool.
- rendering/RenderObject.h:
- 12:28 AM Changeset in webkit [125255] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Search matches count view is flaky.
https://bugs.webkit.org/show_bug.cgi?id=93451
Patch by Sam D <dsam2912@gmail.com> on 2012-08-10
Reviewed by Pavel Feldman.
Modified css properties for aligning search panel.
No new tests.UI change.
- inspector/front-end/inspector.css:
(.search-results-matches):
Aug 9, 2012:
- 11:34 PM Changeset in webkit [125254] by
-
- 1 edit30 moves in trunk/LayoutTests
Move some CSS -webkit-locale tests out of fast/text/
https://bugs.webkit.org/show_bug.cgi?id=93571
Patch by Matt Falkenhagen <falken@chromium.org> on 2012-08-09
Reviewed by Alexey Proskuryakov.
Move the tests from fast/text/ to fast/css/, as they are not text-related.
- fast/css/content-language-case-insensitivity-expected.txt: Renamed from LayoutTests/fast/text/content-language-case-insensitivity-expected.txt.
- fast/css/content-language-case-insensitivity.html: Renamed from LayoutTests/fast/text/content-language-case-insensitivity.html.
- fast/css/content-language-comma-separated-list-expected.txt: Renamed from LayoutTests/fast/text/content-language-comma-separated-list-expected.txt.
- fast/css/content-language-comma-separated-list.html: Renamed from LayoutTests/fast/text/content-language-comma-separated-list.html.
- fast/css/content-language-dynamically-added-expected.txt: Renamed from LayoutTests/fast/text/content-language-dynamically-added-expected.txt.
- fast/css/content-language-dynamically-added.html: Renamed from LayoutTests/fast/text/content-language-dynamically-added.html.
- fast/css/content-language-dynamically-changed-expected.txt: Renamed from LayoutTests/fast/text/content-language-dynamically-changed-expected.txt.
- fast/css/content-language-dynamically-changed.html: Renamed from LayoutTests/fast/text/content-language-dynamically-changed.html.
- fast/css/content-language-dynamically-removed-expected.txt: Renamed from LayoutTests/fast/text/content-language-dynamically-removed-expected.txt.
- fast/css/content-language-dynamically-removed.html: Renamed from LayoutTests/fast/text/content-language-dynamically-removed.html.
- fast/css/content-language-empty-expected.txt: Renamed from LayoutTests/fast/text/content-language-empty-expected.txt.
- fast/css/content-language-empty.html: Renamed from LayoutTests/fast/text/content-language-empty.html.
- fast/css/content-language-late-expected.txt: Renamed from LayoutTests/fast/text/content-language-late-expected.txt.
- fast/css/content-language-late.html: Renamed from LayoutTests/fast/text/content-language-late.html.
- fast/css/content-language-mapped-to-webkit-locale-expected.txt: Renamed from LayoutTests/fast/text/content-language-mapped-to-webkit-locale-expected.txt.
- fast/css/content-language-mapped-to-webkit-locale.html: Renamed from LayoutTests/fast/text/content-language-mapped-to-webkit-locale.html.
- fast/css/content-language-multiple-expected.txt: Renamed from LayoutTests/fast/text/content-language-multiple-expected.txt.
- fast/css/content-language-multiple.html: Renamed from LayoutTests/fast/text/content-language-multiple.html.
- fast/css/content-language-no-content-expected.txt: Renamed from LayoutTests/fast/text/content-language-no-content-expected.txt.
- fast/css/content-language-no-content.html: Renamed from LayoutTests/fast/text/content-language-no-content.html.
- fast/css/content-language-only-whitespace-expected.txt: Renamed from LayoutTests/fast/text/content-language-only-whitespace-expected.txt.
- fast/css/content-language-only-whitespace.html: Renamed from LayoutTests/fast/text/content-language-only-whitespace.html.
- fast/css/content-language-with-whitespace-expected.txt: Renamed from LayoutTests/fast/text/content-language-with-whitespace-expected.txt.
- fast/css/content-language-with-whitespace.html: Renamed from LayoutTests/fast/text/content-language-with-whitespace.html.
- fast/css/lang-mapped-to-webkit-locale-dynamic-expected.txt: Renamed from LayoutTests/fast/text/lang-mapped-to-webkit-locale-dynamic-expected.txt.
- fast/css/lang-mapped-to-webkit-locale-dynamic.xhtml: Renamed from LayoutTests/fast/text/lang-mapped-to-webkit-locale-dynamic.xhtml.
- fast/css/lang-mapped-to-webkit-locale-expected.txt: Renamed from LayoutTests/fast/text/lang-mapped-to-webkit-locale-expected.txt.
- fast/css/lang-mapped-to-webkit-locale.xhtml: Renamed from LayoutTests/fast/text/lang-mapped-to-webkit-locale.xhtml.
- fast/css/xml-lang-ignored-in-html-expected.txt: Renamed from LayoutTests/fast/text/xml-lang-ignored-in-html-expected.txt.
- fast/css/xml-lang-ignored-in-html.html: Renamed from LayoutTests/fast/text/xml-lang-ignored-in-html.html.
- 10:45 PM Changeset in webkit [125253] by
-
- 8 edits in trunk/Source
[Qt] Remove support for qt_sender in QObject bridge
https://bugs.webkit.org/show_bug.cgi?id=93649
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-08-09
Reviewed by Kenneth Rohde Christiansen.
Support for qt_sender has also been removed from QtScript/QJSEngine. The right
JavaScript solution to the problem is Function.prototype.bind.
Source/WebCore:
- bridge/qt/qt_instance.cpp:
(Bindings):
- bridge/qt/qt_instance.h:
- bridge/qt/qt_runtime.cpp:
(Bindings):
(JSC::Bindings::QtConnectionObject::execute):
Source/WebKit/qt:
- Api/qwebframe.cpp:
(QWebFramePrivate::didClearWindowObject):
- Api/qwebframe_p.h:
(QWebFramePrivate):
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::connectAndDisconnect):
- 10:21 PM BuildingGtk edited by
- (diff)
- 10:14 PM Changeset in webkit [125252] by
-
- 11 edits in trunk/Source/WebCore
Convert CSSParser's m_reusableSelectorVector to OwnPtr and rename to m_selectorVector.
https://bugs.webkit.org/show_bug.cgi?id=93574
Patch by Shane Stephens <shanestephens@google.com> on 2012-08-09
Reviewed by Ojan Vafai.
This is preparatory work for CSS Hierarchies (see wkb.ug/79939).
CSS Hierarchies works by pushing selectorVectors onto a stack while nested selectorVectors are parsed.
For this reason, the selectorVector in CSSParser can't be re-used between selector parses within a set of
nested selectors. This patch wraps the selectorVector in an OwnPtr but does not otherwise modify its use.
Similarly, CSSParser::m_parsedProperties is converted from a direct ParsedPropertyVector included
as a member of CSSParser to an OwnPtr.
Once Hierarchies are introduced, when a selectorVector is stacked a new one will be created
and stored in m_selectorVector (see wkb.ug/79939 for context). However, an accompanying unstacking
mechanism ensures that selectorVectors will be reused in all circumstances where they currently are.
This patch also introduces a CSSSelectorVector typedef to simplify and improve readability of
type signatures in and around CSSParser.
No new tests as this patch doesn't introduce new functionality.
- css/CSSGrammar.y:
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseDeclaration):
(WebCore):
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::rollbackLastProperties):
(WebCore::CSSParser::clearProperties):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::createFloatingSelectorVector):
(WebCore::CSSParser::sinkFloatingSelectorVector):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::setReusableRegionSelectorVector):
(WebCore::CSSParser::startDeclarationsForMarginBox):
(WebCore::CSSParser::endDeclarationsForMarginBox):
(WebCore::CSSParser::deleteFontFaceOnlyValues):
m_reusableSelectorVector renamed to m_selectorVector and wrapped in OwnPtr.
m_parsedProperties wrapped in OwnPtr.
- css/CSSParser.h:
(WebCore::CSSParser::hasProperties):
(WebCore::CSSParser::selectorVector): function renamed from reusableSelectorVector
(CSSParser):
(WebCore::CSSParser::reusableRegionSelectorVector):
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::adoptSelectorVector):
- css/CSSParserValues.h: CSSSelectorVector typedef added
(WebCore):
(CSSParserSelector):
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::adoptSelectorVector):
- css/CSSSelectorList.h:
(CSSSelectorList):
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- css/StyleRule.cpp:
(WebCore::StyleRuleRegion::StyleRuleRegion):
- css/StyleRule.h:
(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRuleRegion::create):
(StyleRuleRegion):
- 10:12 PM Changeset in webkit [125251] by
-
- 14 edits in trunk/Source/WebCore
SVGElementInstance should have EventTarget on the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=88232
Reviewed by Adam Barth.
SVG 1.1 specifies that SVGElementInstance has EventTarget as its
parent interface:
<http://www.w3.org/TR/SVG/struct.html#InterfaceSVGElementInstance>
Match the spec by putting EventTarget on the prototype chain of
SVGElementInstance instead of redundantly declaring
addEventListener, removeEventListener and dispatchEvent on the
SVGElementInstance interface. This is an incremental step to make
all EventTargets do it this way, being tracked in bug 67312.
Covered by existing tests, eg
svg/custom/use-instanceRoot-as-event-target.xhtml
- CMakeLists.txt: Finding base interface types requires
searching directories with the IDLs of base interfaces.
- DerivedSources.cpp: Add generated JSEventTarget.cpp.
- DerivedSources.make: (Search paths again -- see CMakeLists.txt)
- DerivedSources.pri: "
- bindings/js/JSEventTargetCustom.cpp:
(WebCore::toEventTarget): Try to unwrap EventTargets simply as
EventTargets. When all EventTargets do this consistently this
function will be simplified.
- bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::visitChildren): SVGElementInstance
skips walking its event listener list because it forwards
listeners to its corresponding element.
- bindings/scripts/CodeGenerator.pm:
(IsStrictSubtype): For finding what is an EventTarget based on
parent interface.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Extend the heuristic for what is an
EventTarget. When all EventTargets are handled consistently this
will be simplified.
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm: Extend the heuristic for
what is an EventTarget, and remove some of the special-casing for
EventTarget.
(GenerateHeader):
(GetInternalFields):
(GenerateImplementation):
(BaseInterfaceName):
(GenerateToV8Converters):
(GetNativeType):
(JSValueToNative):
(GetV8HeaderName):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow): Add assertions.
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
- svg/SVGElementInstance.h: Must extend EventTarget first so that
static_cast<EventTarget*>(elementInstance) is the same pointer as
elementInstance, similar to how static_cast<Node*>(element) is the
same pointer as element.
- svg/SVGElementInstance.idl: Extend EventTarget; no longer need
to declare add/removeEventListener and dispatchEvent.
- 10:00 PM Changeset in webkit [125250] by
-
- 1 edit1 move1 add3 deletes in trunk/LayoutTests
Add DOMString reflection test
https://bugs.webkit.org/show_bug.cgi?id=93681
Reviewed by Hajime Morita.
Introduce fast/dom/domstring-atribute-reflection.html, which
should have tess for all of reflected DOMString IDL attribute,
like fast/dom/boolean-attribute-reflection.html and
URL-attribute-reflectin.html.
As the first step, integrate fast/forms/input-step.html and
fast/form/name-attribute.html into
domstring-attribute-reflection.html.
- fast/dom/domstring-attribute-reflection-expected.txt: Renamed from LayoutTests/fast/forms/name-attribute-expected.txt.
- fast/dom/domstring-attribute-reflection.html: Added.
- fast/forms/input-step-expected.txt: Removed.
- fast/forms/input-step.html: Removed.
- fast/forms/name-attribute.html: Removed.
- 9:53 PM Changeset in webkit [125249] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove unused method InspectorResourceAgent::clearCache from Resource Agent.
https://bugs.webkit.org/show_bug.cgi?id=93675
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-08-09
Reviewed by Pavel Feldman.
Removing unused method declaration for clearCache in InspectorResourceAgent. It's marked as FIXME.
Hence cleaning up.
No new tests as cleanup.
- inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
- 9:51 PM Changeset in webkit [125248] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: add complete support for TypeBuilder::Array
https://bugs.webkit.org/show_bug.cgi?id=93559
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-08-09
Reviewed by Pavel Feldman.
Missing binding methods are added to templates. Core assert methods are declared in a helper class now.
- inspector/CodeGeneratorInspector.py:
(RawTypes.BaseType.generate_validate_method):
(RawTypes.BaseType.get_raw_validator_call_text):
(RawTypes.generate_validate_methods):
(RawTypes.Int.generate_validate_method):
(RawTypes.Int.get_raw_validator_call_text):
(RawTypes.Number.get_validate_method_params.ValidateMethodParams):
(RawTypes.Any.generate_validate_method):
(RawTypes.Any.get_raw_validator_call_text):
(RawTypes.Array.get_validate_method_params.ValidateMethodParams):
(RawTypes.Array.get_validate_method_params):
(PlainObjectBinding.get_validator_call_text):
(RuntimeCastHelper):
(Generator):
(Generator.go):
- 9:45 PM Changeset in webkit [125247] by
-
- 18 edits2 adds in trunk
Mouse-select then Cut, results in preceding character being lost
https://bugs.webkit.org/show_bug.cgi?id=60830
Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-09
Reviewed by Ryosuke Niwa.
Source/WebCore:
This bug happened only in text fields and text areas, not in other
content-editable elements. That's because when we cut or copied text
in a text control, we called Pasteboard::writePlainText instead of
Pasteboard::writeSelection. writePlainText did not record the smart replace
information. Make writePlainText record the smart replace information.
Test: editing/pasteboard/smart-paste-in-text-control.html
- editing/Editor.cpp:
(WebCore::Editor::cut):
(WebCore::Editor::copy):
- inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::copyText):
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::copyText):
- platform/Pasteboard.h:
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::writePlainText):
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writePlainText):
- platform/efl/PasteboardEfl.cpp:
(WebCore::Pasteboard::writePlainText):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writePlainText):
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::writePlainText):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writePlainText):
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writePlainText):
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writePlainText):
- platform/wince/PasteboardWinCE.cpp:
(WebCore::Pasteboard::writePlainText):
- platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::writePlainText):
- platform/wx/PasteboardWx.cpp:
(WebCore::Pasteboard::writePlainText):
LayoutTests:
- editing/pasteboard/smart-paste-in-text-control-expected.txt: Added.
- editing/pasteboard/smart-paste-in-text-control.html: Added.
- platform/chromium/TestExpectations:
- 9:42 PM Changeset in webkit [125246] by
-
- 1 edit3 adds in trunk/LayoutTests
[EFL] Unreviewed gardening
Rebaseline compositing/repaint/newly-composited-on-scroll.html on EFL after r125086.
Rebaseline fast/forms/datalist/range-snap-to-datalist.html on EFL after r125048.
- platform/efl/compositing/repaint/newly-composited-on-scroll-expected.png: Added.
- platform/efl/compositing/repaint/newly-composited-on-scroll-expected.txt: Added.
- platform/efl/fast/forms/datalist/range-snap-to-datalist-expected.txt: Added.
- 9:35 PM Changeset in webkit [125245] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening.
Unskip tests that are now non-flaky (see fix in http://trac.webkit.org/changeset/121506)
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- 8:50 PM Changeset in webkit [125244] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Updated run-binding-tests results.
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::TestActiveDOMObjectDomainSafeFunctionSetter):
- 8:37 PM Changeset in webkit [125243] by
-
- 3 edits2 adds in trunk
Fix null pointer deref in RenderFileUploadControl::computePreferredLogicalWidth().
https://bugs.webkit.org/show_bug.cgi?id=93579
Reviewed by Kent Tamura.
Source/WebCore:
Checks the upload control has a non-null button renderer before dereferencing.
Test: fast/forms/file/file-crash-by-display-none-button.html
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
LayoutTests:
Exercise code path that causes an upload button to exist without a renderer.
- fast/forms/file/file-crash-by-display-none-button.html: Added.
- fast/forms/file/file-crash-by-display-none-button-expected.txt: Added.
- 8:05 PM Changeset in webkit [125242] by
-
- 13 edits2 moves in trunk/Source/WebCore
[V8] Rename V8BindingPerContextData to V8PerContextData
https://bugs.webkit.org/show_bug.cgi?id=93595
Reviewed by Adam Barth.
For a better name. See discussion in bug 93333.
No tests. No change in behavior.
- UseV8.cmake: Added V8PerContextData.cpp. The fact that missing V8BindingPerContextData.cpp
has not caused any problem indicates that UseV8.cmake is not used at all?
- WebCore.gypi:
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8DOMWindowShell.h:
(WebCore::V8DOMWindowShell::perContextData):
(V8DOMWindowShell):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::constructorForType):
(WebCore::V8DOMWrapper::perContextData):
(WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8DOMWrapper.h:
(WebCore):
(V8DOMWrapper):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8IsolatedContext.h:
(WebCore):
(WebCore::V8IsolatedContext::perContextData):
(V8IsolatedContext):
- bindings/v8/V8PerContextData.cpp: Renamed from Source/WebCore/bindings/v8/V8BindingPerContextData.cpp.
(WebCore):
(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::init):
(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8PerContextData::constructorForTypeSlowCase):
- bindings/v8/V8PerContextData.h: Renamed from Source/WebCore/bindings/v8/V8BindingPerContextData.h.
(WebCore):
(V8PerContextData):
(WebCore::V8PerContextData::create):
(WebCore::V8PerContextData::~V8PerContextData):
(WebCore::V8PerContextData::createWrapperFromCache):
(WebCore::V8PerContextData::constructorForType):
(WebCore::V8PerContextData::V8PerContextData):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::retrievePerContextData):
- bindings/v8/V8Proxy.h:
(WebCore):
(V8Proxy):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
- bindings/v8/WorkerContextExecutionProxy.h:
(WebCore):
(WebCore::WorkerContextExecutionProxy::perContextData):
(WorkerContextExecutionProxy):
- 7:47 PM Changeset in webkit [125241] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Remove duplicate test expectation entry causing a lint error.
- platform/chromium/TestExpectations:
- 7:28 PM Changeset in webkit [125240] by
-
- 4 edits in trunk
[Chromium-Android] Skip layout tests directories that are not applicable
https://bugs.webkit.org/show_bug.cgi?id=93670
Reviewed by Dirk Pranke.
Tools:
Added back ChromiumAndroidPort.skipped_layout_tests to skip some whole directories.
The method is more convenient to skip whole directories than SKIP in TestExpectations
because its higher priority. Will still use TestExpectations to skip individual tests.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.skipped_layout_tests):
LayoutTests:
Removed 'WONTFIX ANDROID SKIP' lines for whole directories added in r125094.
Use ChromiumAndroidPort.skipped_layout_tests() instead.
- platform/chromium/TestExpectations:
- 7:26 PM Changeset in webkit [125239] by
-
- 7 edits in trunk
HTMLElement.classList cannot remove classnames with uppercase characters
https://bugs.webkit.org/show_bug.cgi?id=93628
Reviewed by Alexey Proskuryakov.
Before this patch we were trying to be smart and determine whether we needed the update m_classNamesForQuirksMode
based on whether m_classNamesForQuirksMode.isNull(), however, m_classNamesForQuirksMode.isNull() is true when the
class name is the empty string.
We also did not update m_classNamesForQuirksMode when the class attribute was cleared.
Source/WebCore:
Updated tests.
- dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged):
- html/ClassList.cpp:
(WebCore::ClassList::reset):
(WebCore::ClassList::classNames):
LayoutTests:
- fast/dom/HTMLElement/class-list-expected.txt:
- fast/dom/HTMLElement/class-list-quirks-expected.txt:
- fast/dom/HTMLElement/script-tests/class-list.js:
- 7:19 PM Changeset in webkit [125238] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, Chromium-mac (clang) build fix for r125230.
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore):
- 7:15 PM Changeset in webkit [125237] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=93587
Node::replaceChild() can create bad DOM topology with MutationEvent, Part 2
Reviewed by Kent Tamura.
Source/WebCore:
This is a followup of r124156. replaceChild() has yet another hidden
MutationEvent trigger. This change added a guard for it.
Test: fast/events/mutation-during-replace-child-2.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild):
LayoutTests:
- fast/events/mutation-during-replace-child-2-expected.txt: Added.
- fast/events/mutation-during-replace-child-2.html: Added.
- 7:13 PM Changeset in webkit [125236] by
-
- 3 edits in trunk/Source/WebCore
[V8] V8Utilities::throwTypeMismatchException() should use setDOMException()
https://bugs.webkit.org/show_bug.cgi?id=93610
Reviewed by Adam Barth.
Given that V8Utilities::throwTypeMismatchException() throws a DOM exception,
we should use setDOMException() instead of throwError().
This patch also renames throwTypeMismatchException() to setTypeMismatchException().
No tests. I couldn't figure out how to trigger the call path.
Either way this is just a minor change of error message.
- bindings/v8/V8Utilities.cpp:
(WebCore::setTypeMismatchException):
- bindings/v8/V8Utilities.h:
(WebCore::createFunctionOnlyCallback):
- 7:11 PM Changeset in webkit [125235] by
-
- 4 edits in trunk
http/tests/security/mixedContent/blob-url-in-iframe.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=88736
Reviewed by Alexey Proskuryakov.
Source/WebKit/mac:
WebView::_canHandleRequest should return true for "blob:" URL so that it can be shown in iframe.
- WebView/WebView.mm:
(+[WebView _canHandleRequest:forMainFrame:]):
LayoutTests:
Remove security/mixedContent/blob-url-in-iframe.html as it should pass with this patch.
- platform/mac/Skipped:
- 7:04 PM Changeset in webkit [125234] by
-
- 3 edits2 adds in trunk
Crash in WebCore::RenderTable::cellBefore
https://bugs.webkit.org/show_bug.cgi?id=91160
Reviewed by Abhishek Arya.
Source/WebCore:
The issue was that we wouldn't properly set the row index on row in a newly split table. When inserting
the cell into the new row, we would try to repaint the cell which would access the row index and crash.
This came from splitAnonymousBoxesAroundChild calling RenderObjectChildList::insertChildNode directly
which doesn't invoke the row setting logic (RenderTableSection::addChild for example but we cannot call
addChild due to concern over splitting flows in the general case).
Test: fast/table/split-anonymous-boxes-around-table-repaint-crash.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::splitAnonymousBoxesAroundChild):
Dirty our parent box, which forces a cell recomputation which will set the row index. This needs to
be done *before* we insert the child to avoid crashing when repainting the new child.
LayoutTests:
- fast/table/split-anonymous-boxes-around-table-repaint-crash-expected.txt: Added.
- fast/table/split-anonymous-boxes-around-table-repaint-crash.html: Added.
- 6:54 PM Changeset in webkit [125233] by
-
- 2 edits in trunk/LayoutTests
LayoutTest: fast/forms/select/menulist-popup-crash.html timeout on Windows.
https://bugs.webkit.org/show_bug.cgi?id=93667
Patch by Roger Fong <roger_fong@apple.com> on 2012-08-09
Reviewed by Tim Horton.
Test times out and was added to Mac skiplist: http://trac.webkit.org/changeset/102884.
Adding to Windows skip list as well.
- platform/win/Skipped:
Add test to skip list.
- 6:52 PM Changeset in webkit [125232] by
-
- 3 edits in trunk/Source/WebCore
[V8] Fix issues with [DoNotCheckSecurity] which depended on non ES5 compliant behavior
https://bugs.webkit.org/show_bug.cgi?id=93555
Reviewed by Kentaro Hara.
Before this change we were relying on a V8 bug where instance properties could be shadow
read only properties on the prototype. With this change we no longer depend on this incorrect
V8 behavior and instead use a hidden v8 property that is only returned if the code can access
the frame.
No new tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateNonStandardFunction):
(GenerateImplementation):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::TestActiveDOMObjectV8Internal::TestActiveDOMObjectDomainSafeFunctionSetter):
(TestActiveDOMObjectV8Internal):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
- 6:32 PM Changeset in webkit [125231] by
-
- 6 edits in trunk
IndexedDB: intversion-long-queue.html fails an assert
https://bugs.webkit.org/show_bug.cgi?id=92783
Reviewed by Tony Chang.
Source/WebCore:
onBlocked needs the same shouldEnqueueEvent check that the other
event generators have.
Tests: intversion-long-queue is no longer skipped.
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
- Modules/indexeddb/IDBVersionChangeRequest.cpp:
(WebCore::IDBVersionChangeRequest::onBlocked):
LayoutTests:
- platform/chromium/TestExpectations:
- storage/indexeddb/intversion-long-queue-expected.txt:
Add some FAIL lines that will be fixed when patch from 92897 lands.
This patch doesn't actually change any behavior,
intversion-long-queue-expected.txt was generated with 92897 patched in
and the test was skipped so it didn't matter.
- 6:21 PM Changeset in webkit [125230] by
-
- 6 edits in trunk/Source
[chromium] Paint animated layers immediately to avoid animation hiccups.
https://bugs.webkit.org/show_bug.cgi?id=93028
Patch by Eric Penner <epenner@google.com> on 2012-08-09
Reviewed by Adrienne Walker.
Source/WebCore:
This is a technique used on Android, which is very prone
to hiccups in animations. Paint the entire layer if it is
of reasonable size such that there is no hiccups when the
animation reaches unpainted content. The reasonable size
is choosen for page-transitions specifically, as this was
the problem case (animations would just jump to the end).
Since we already have a special case this just modifies it
and replaces the unit test with a new one. This can be
improved/simplified further when distances/directions are
available for the animated layers.
Replaced one test.
- platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::UpdatableTile::resetUpdateState):
(WebCore::UpdatableTile::markForUpdate):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::markOcclusionsAndRequestTextures):
(WebCore::TiledLayerChromium::haveTexturesForTiles):
(WebCore::TiledLayerChromium::markTilesForUpdate):
(WebCore::TiledLayerChromium::updateTileTextures):
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateContentRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
- platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::contentRectToTileIndices):
- platform/graphics/chromium/cc/CCPriorityCalculator.h:
(WebCore::CCPriorityCalculator::maxPriority):
Source/WebKit/chromium:
Replaced one test. Test painting full animated layer.
- tests/TiledLayerChromiumTest.cpp:
- 6:05 PM Changeset in webkit [125229] by
-
- 4 edits4 adds in trunk
REGRESSION(r117339): cell in block-level table in inline-block are aligned with their last line box
https://bugs.webkit.org/show_bug.cgi?id=91137
Reviewed by Tony Chang.
Source/WebCore:
Fixed the code to properly ignore any inline-table's baseline for the purpose of 'inline-block' baseline computation.
See http://lists.w3.org/Archives/Public/www-style/2012Jul/0721.html about the discussion.
While touching the code, properly fixed the table baseline logic that was wrong because it wrongly piggy-backed
on the inline-block baseline logic.
Tests: fast/table/anonymous-table-no-baseline-align.html
fast/table/inline-table-in-inline-block-last-baseline-align.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::baselinePosition):
Overrode this function: this is needed as RenderBlock assumes that isReplaced() == true
means it is handling an inline-block, not a table.
(WebCore::RenderTable::lastLineBoxBaseline):
Table are ignored for the purpose of inline-block baseline determination.
(WebCore::RenderTable::firstLineBoxBaseline):
Inlined the code from getLineBoxBaseline. Added some comments to explain
why this code works as expected in the 'table' case.
- rendering/RenderTable.h:
Added baselinePosition.
LayoutTests:
- fast/table/anonymous-table-no-baseline-align-expected.html: Added.
- fast/table/anonymous-table-no-baseline-align.html: Added.
- fast/table/inline-table-in-inline-block-last-baseline-align-expected.html: Added.
- fast/table/inline-table-in-inline-block-last-baseline-align.html: Added.
- 5:58 PM Changeset in webkit [125228] by
-
- 2 edits in trunk
[CMake] Bump minimum required version to 2.8.3.
https://bugs.webkit.org/show_bug.cgi?id=93450
Reviewed by Daniel Bates.
Following the discussion in bug 93189, it was decided that bumping
the minimum required version from 2.8.0 to 2.8.3 was a good thing
due to additional features, such as improved
FIND_PACKAGE_HANDLE_STANDARD_ARGS() support and better argument
handling in the PKG_CHECK_MODULES() call.
CMake 2.8.3 was released almost two years ago, so people are
expected to have it or a later version installed.
- CMakeLists.txt:
- 5:52 PM Changeset in webkit [125227] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove missing files from WebKit.gyp introduced by r125219
https://bugs.webkit.org/show_bug.cgi?id=93671
Unreviewed. Fixing windows build.
- WebKit.gyp:
- 5:52 PM Changeset in webkit [125226] by
-
- 2 edits in trunk/Tools
Add myself to the Contributor list.
https://bugs.webkit.org/show_bug.cgi?id=93653
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-08-09
Reviewed by Dirk Pranke.
Add my email to the contributor list.
- Scripts/webkitpy/common/config/committers.py:
- 5:44 PM Changeset in webkit [125225] by
-
- 2 edits in trunk/Source/WebKit/chromium
IndexedDB: add AssertMatchingEnums for Direction and TaskType
https://bugs.webkit.org/show_bug.cgi?id=93618
Patch by Alec Flett <alecflett@chromium.org> on 2012-08-09
Reviewed by Tony Chang.
These chromium enums were introduced in a separate patch.
- src/AssertMatchingEnums.cpp:
- 5:14 PM WikiStart edited by
- (diff)
- 5:13 PM Changeset in webkit [125224] by
-
- 4 edits in trunk/Source
Versioning.
- 5:08 PM Changeset in webkit [125223] by
-
- 1 copy in tags/Safari-537.5
New Tag.
- 4:59 PM Changeset in webkit [125222] by
-
- 2 edits2 moves in trunk
Sandboxing view source documents is ineffective
https://bugs.webkit.org/show_bug.cgi?id=93660
Reviewed by Eric Seidel.
Prior to this patch, Document::setIsViewSource changed the
SecurityOrigin object on Document but didn't update the copy on
DOMWindow. As a consequence, the security checks that use the copy on
DOMWindow didn't notice the change and acted as if the document wasn't
sandboxed.
This bug wasn't present for most view source documents because
HTMLViewSourceDocument sets the flag in its constructor. However, for
view source documents created by the XMLTreeViewer, the bit was set at
the end of parsing rather than during construction.
This mechansim is really more of a mitigation than an important
security check, and I was tempted to remove the sandboxing entirely
given that sandboxing a document at the end of parsing isn't overly
effective anyway. However, we can worry about that issue in a future
patch.
For the time being, this patch just synchronizes DOMWindow and
Document's copy of the SecurityOrigin. The long-term solution here, of
course, is to keep working on fixing
https://bugs.webkit.org/show_bug.cgi?id=75793, which this patch gets us
one (small) step closer to fixing.
- dom/Document.cpp:
(WebCore::Document::setIsViewSource):
- 4:49 PM Changeset in webkit [125221] by
-
- 2 edits in trunk/Source/WebCore
Append the unit in place when generating the text value of a CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=93572
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-09
Reviewed by Andreas Kling.
Previously, the units were added to the formatted number by the operator+. This would create
a new WTF::String for the unit, then use String::append() to add it to the number.
This was ineffective because it required one malloc for the unit, followed by a realloc + copying
the bytes.
This patch adds handling for the unit directly in formatNumber() so that we only do one malloc
and append the units in place.
Avoiding the intermediate string is both more efficient (9% faster as seen from JavaScript)
and generate more compact code (~8kb less code on x86_64).
- css/CSSPrimitiveValue.cpp:
(WebCore::formatNumber):
(WebCore::CSSPrimitiveValue::customCssText):
- 4:34 PM Changeset in webkit [125220] by
-
- 7 edits in trunk/Source/WebCore
Reimplement RenderQuote placement algorithm
https://bugs.webkit.org/show_bug.cgi?id=93056
Patch by Elliott Sprehn <Elliott Sprehn> on 2012-08-09
Reviewed by Eric Seidel.
Greatly simplify the code that maintains the linked list of RenderQuotes. Now RenderQuote
is placed into the linked list in computePreferredLogicalWidths on first access and is
detached when destroyed (or explicitly removed).
The new algorithm doesn't require walking up the tree of renderers when there are no
RenderQuotes in the tree yet, and also removes the need to walk over every subtree
when inserting in rendererSubtreeAttached.
No new tests because this patch doesn't change any behavior.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode): Call detachQuote when removing from a child list.
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::willBeDestroyed): Call detachQuote to ensure all destroyed quotes are detached.
(WebCore::RenderQuote::originalText):
(WebCore::RenderQuote::computePreferredLogicalWidths): Attach quote before computing the width.
(WebCore):
(WebCore::RenderQuote::attachQuote): Puts the RenderQuote in the linked list of quotes and computes the depth.
(WebCore::RenderQuote::detachQuote): Removes the quote from the linked list.
(WebCore::RenderQuote::updateDepth):
- rendering/RenderQuote.h:
(RenderQuote):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff): Return StyleDifferenceLayout if quotes change and remove check in styleDidChange in RenderQuote.
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
- rendering/RenderView.h:
(WebCore):
(WebCore::RenderView::setRenderQuoteHead):
(WebCore::RenderView::renderQuoteHead): Stores the first quote in the document.
(RenderView):
- 4:30 PM Changeset in webkit [125219] by
-
- 40 edits2 copies1 add in trunk/Source
[chromium] Expose CCGraphicsContext as WebCompositorOutputSurface
https://bugs.webkit.org/show_bug.cgi?id=92890
Reviewed by James Robinson.
Source/Platform:
The CCGraphicsContext was introduced as a wrapper around the 2D
and 3D output for the compositor. However, it is a CC only
concept. We want to be able to make 2D and ubercomp-mode IPCs on
behalf of the compositor. This patch allows this by pushing this
abstraction out to the Chrome-visible layer of the compositor,
changing the name to OutputSurface based on discussions on
wkb.ug/90736. A future patch will rename the CCGraphicsContext to
CCOutputSurface.
- Platform.gypi:
- chromium/public/WebCompositorOutputSurface.h: Added.
(WebKit):
(WebCompositorOutputSurface):
(WebKit::WebCompositorOutputSurface::~WebCompositorOutputSurface):
(WebKit::WebCompositorOutputSurface::Capabilities::Capabilities):
(Capabilities):
- chromium/public/WebCompositorOutputSurfaceClient.h: Added.
(WebKit):
(WebCompositorOutputSurfaceClient):
(WebKit::WebCompositorOutputSurfaceClient::~WebCompositorOutputSurfaceClient):
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
- chromium/public/WebLayerTreeViewClient.h:
(WebKit):
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::createContext3D):
(WebKit::WebLayerTreeViewClient::createOutputSurface):
Source/WebCore:
- platform/graphics/chromium/cc/CCGraphicsContext.h:
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::recreateContext):
(WebCore::CCLayerTreeHost::createContext):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
(CCLayerTreeHostClient):
(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::onVSyncParametersChanged):
(WebCore):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImplClient):
- platform/graphics/chromium/cc/CCProxy.h:
(WebKit):
(WebCore):
- platform/graphics/chromium/cc/CCRenderer.h:
(CCRendererClient):
(WebCore::CCRendererClient::~CCRendererClient):
- platform/graphics/chromium/cc/CCResourceProvider.cpp:
- platform/graphics/chromium/cc/CCResourceProvider.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::onVSyncParametersChanged):
(WebCore):
(WebCore::CCThreadProxy::beginFrame):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- WebKit.gyp:
- WebKit.gypi:
- public/WebSettings.h:
- public/WebViewClient.h:
(WebKit):
(WebViewClient):
(WebKit::WebViewClient::createOutputSurface):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):
- src/WebLayerTreeViewImpl.cpp:
(WebKit):
(WebGraphicsContextToOutputSurfaceAdapter):
(WebKit::WebGraphicsContextToOutputSurfaceAdapter::WebGraphicsContextToOutputSurfaceAdapter):
(WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createOutputSurface):
(WebKit):
(WebKit::WebViewImpl::didRebindGraphicsContext):
(WebKit::WebViewImpl::didRecreateOutputSurface):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/CCLayerTreeHostImplTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(WTF::CCLayerTreeHostTestSetSingleLostContext::didRecreateOutputSurface):
(WTF::CCLayerTreeHostTestSetRepeatedLostContext::didRecreateOutputSurface):
- tests/CCResourceProviderTest.cpp:
(WebKit::CCResourceProviderTest::CCResourceProviderTest):
- tests/CCTextureUpdateControllerTest.cpp:
- tests/CCThreadedTest.cpp:
(WebKitTests::TestHooks::createOutputSurface):
- tests/CCThreadedTest.h:
(WebKitTests::TestHooks::didRecreateOutputSurface):
- tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
- tests/FakeCCGraphicsContext.h:
(WebKit::createFakeCCGraphicsContext):
- tests/FakeCCLayerTreeHostClient.h:
- tests/FakeWebCompositorOutputSurface.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCGraphicsContext.h.
(WebKit):
(FakeWebCompositorOutputSurface):
(WebKit::FakeWebCompositorOutputSurface::create):
(WebKit::FakeWebCompositorOutputSurface::FakeWebCompositorOutputSurface):
- tests/LayerRendererChromiumTest.cpp:
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):
- tests/WebLayerTest.cpp:
- tests/WebLayerTreeViewTest.cpp:
- 4:03 PM Changeset in webkit [125218] by
-
- 40 edits3 deletes in trunk/Source
Unreviewed, rolling out r125212.
http://trac.webkit.org/changeset/125212
https://bugs.webkit.org/show_bug.cgi?id=92890
Compile failure on mac dbg builder
Source/Platform:
- Platform.gypi:
- chromium/public/WebCompositorOutputSurface.h: Removed.
- chromium/public/WebCompositorOutputSurfaceClient.h: Removed.
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
- chromium/public/WebLayerTreeViewClient.h:
(WebKit):
(WebLayerTreeViewClient):
Source/WebCore:
- platform/graphics/chromium/cc/CCGraphicsContext.h:
(WebCore):
(CCGraphicsContext):
(WebCore::CCGraphicsContext::create2D):
(WebCore::CCGraphicsContext::create3D):
(WebCore::CCGraphicsContext::context3D):
(WebCore::CCGraphicsContext::CCGraphicsContext):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::recreateContext):
(WebCore::CCLayerTreeHost::createContext):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
(CCLayerTreeHostClient):
(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImplClient):
- platform/graphics/chromium/cc/CCProxy.h:
(WebCore):
- platform/graphics/chromium/cc/CCRenderer.h:
(CCRendererClient):
- platform/graphics/chromium/cc/CCResourceProvider.cpp:
- platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::beginFrame):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- WebKit.gyp:
- WebKit.gypi:
- public/WebSettings.h:
- public/WebViewClient.h:
(WebKit):
(WebViewClient):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setForceSoftwareCompositing):
(WebKit):
- src/WebSettingsImpl.h:
(WebKit::WebSettingsImpl::forceSoftwareCompositing):
(WebSettingsImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createCompositorGraphicsContext3D):
(WebKit::WebViewImpl::createContext3D):
(WebKit::WebViewImpl::didRebindGraphicsContext):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/CCLayerTreeHostImplTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(WTF::CCLayerTreeHostTestSetSingleLostContext::didRecreateContext):
(WTF::CCLayerTreeHostTestSetRepeatedLostContext::didRecreateContext):
- tests/CCResourceProviderTest.cpp:
(WebKit::CCResourceProviderTest::CCResourceProviderTest):
- tests/CCTextureUpdateControllerTest.cpp:
- tests/CCThreadedTest.cpp:
(WebKitTests::TestHooks::createContext):
- tests/CCThreadedTest.h:
(WebKitTests::TestHooks::didRecreateContext):
- tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
- tests/FakeCCGraphicsContext.h:
(WebKit::createFakeCCGraphicsContext):
- tests/FakeCCLayerTreeHostClient.h:
- tests/FakeWebCompositorOutputSurface.h: Removed.
- tests/LayerRendererChromiumTest.cpp:
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):
- tests/WebLayerTest.cpp:
- tests/WebLayerTreeViewTest.cpp:
- 4:02 PM Changeset in webkit [125217] by
-
- 13 edits in trunk/Source/WebCore
[V8] Remove V8Proxy::throwError(ExceptionCode&)
https://bugs.webkit.org/show_bug.cgi?id=93605
Reviewed by Adam Barth.
(1) Pass Isolate around to V8Utilities::extractTransferables().
(2) Replace throwError(ExceptionCode&) in V8Utilities::extractTransferables()
with setDOMException(ExceptionCode&, Isolate*), which completely removes
V8Proxy::throwError(ExceptionCode&) from the code base.
(3) Remove V8Proxy::throwError(ExceptionCode&).
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
- bindings/v8/V8Proxy.h:
(WebCore):
- bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
(WebCore::getMessagePortArray):
- bindings/v8/V8Utilities.h:
(WebCore):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8IntentConstructor.cpp:
(WebCore::V8Intent::constructorCallback):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventCallback):
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
- 3:52 PM Changeset in webkit [125216] by
-
- 37 edits2 moves in trunk/Source
[V8] Rename V8BindingPerIsolateData to V8PerIsolateData
https://bugs.webkit.org/show_bug.cgi?id=93592
Reviewed by Adam Barth.
For a better name. See discussion in bug 93333.
No tests. No change in behavior.
Source/WebCore:
- UseV8.cmake:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::GetRawTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::GetRawTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::GetRawTemplate):
(WebCore::V8TestInterface::GetTemplate):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::GetRawTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::GetRawTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::GetRawTemplate):
(WebCore::V8TestNode::GetTemplate):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::GetRawTemplate):
(WebCore::V8TestObj::GetTemplate):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
- bindings/v8/DOMData.cpp:
(WebCore::DOMData::getCurrentStore):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::allStores):
- bindings/v8/ScriptGCEvent.cpp:
(WebCore::isolateGCEventData):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::visitExternalStrings):
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
- bindings/v8/StaticDOMDataStore.cpp:
(WebCore::StaticDOMDataStore::StaticDOMDataStore):
(WebCore::StaticDOMDataStore::~StaticDOMDataStore):
- bindings/v8/V8Binding.cpp:
(WebCore::V8PerIsolateData::visitExternalStrings):
(WebCore::getToStringName):
(WebCore::getToStringTemplate):
- bindings/v8/V8Binding.h:
(WebCore::ConstructorMode::ConstructorMode):
(WebCore::ConstructorMode::~ConstructorMode):
(WebCore::ConstructorMode::current):
(WebCore::v8ExternalString):
(WebCore::v8Integer):
(WebCore::v8UnsignedInteger):
- bindings/v8/V8DOMMap.cpp:
(WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
(WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8GCController.cpp:
(WebCore::currentGlobalHandleMap):
(WebCore::V8GCController::gcPrologue):
- bindings/v8/V8HiddenPropertyName.cpp:
(WebCore):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8PerIsolateData.cpp: Renamed from Source/WebCore/bindings/v8/V8BindingPerIsolateData.cpp.
(WebCore):
(WebCore::V8PerIsolateData::V8PerIsolateData):
(WebCore::V8PerIsolateData::~V8PerIsolateData):
(WebCore::V8PerIsolateData::create):
(WebCore::V8PerIsolateData::ensureInitialized):
(WebCore::V8PerIsolateData::dispose):
(WebCore::V8PerIsolateData::reportMemoryUsage):
- bindings/v8/V8PerIsolateData.h: Renamed from Source/WebCore/bindings/v8/V8BindingPerIsolateData.h.
(WebCore):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::current):
(WebCore::V8PerIsolateData::rawTemplateMap):
(WebCore::V8PerIsolateData::templateMap):
(WebCore::V8PerIsolateData::toStringName):
(WebCore::V8PerIsolateData::toStringTemplate):
(WebCore::V8PerIsolateData::lazyEventListenerToStringTemplate):
(WebCore::V8PerIsolateData::stringCache):
(WebCore::V8PerIsolateData::integerCache):
(WebCore::V8PerIsolateData::allStores):
(WebCore::V8PerIsolateData::hiddenPropertyName):
(WebCore::V8PerIsolateData::auxiliaryContext):
(WebCore::V8PerIsolateData::registerDOMDataStore):
(WebCore::V8PerIsolateData::unregisterDOMDataStore):
(WebCore::V8PerIsolateData::domDataStore):
(WebCore::V8PerIsolateData::setDOMDataStore):
(WebCore::V8PerIsolateData::recursionLevel):
(WebCore::V8PerIsolateData::incrementRecursionLevel):
(WebCore::V8PerIsolateData::decrementRecursionLevel):
(WebCore::V8PerIsolateData::globalHandleMap):
(WebCore::V8PerIsolateData::internalScriptRecursionLevel):
(WebCore::V8PerIsolateData::incrementInternalScriptRecursionLevel):
(WebCore::V8PerIsolateData::decrementInternalScriptRecursionLevel):
(WebCore::V8PerIsolateData::gcEventData):
(WebCore::V8PerIsolateData::setShouldCollectGarbageSoon):
(WebCore::V8PerIsolateData::clearShouldCollectGarbageSoon):
(WebCore::V8PerIsolateData::shouldCollectGarbageSoon):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::hintForGCIfNecessary):
- bindings/v8/V8RecursionScope.h:
(WebCore::V8RecursionScope::V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):
(WebCore::V8RecursionScope::recursionLevel):
(WebCore::V8RecursionScope::properlyUsed):
(WebCore::V8RecursionScope::MicrotaskSuppression::MicrotaskSuppression):
(WebCore::V8RecursionScope::MicrotaskSuppression::~MicrotaskSuppression):
- bindings/v8/V8Utilities.cpp:
(WebCore::V8AuxiliaryContext::auxiliaryContext):
- bindings/v8/V8ValueCache.cpp:
(WebCore::cachedStringCallback):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initIsolate):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
Source/WebKit/chromium:
- src/WebKit.cpp:
(WebKit::initialize):
- 3:51 PM Changeset in webkit [125215] by
-
- 2 edits in trunk/LayoutTests
[WK2] Unskip tests requiring layoutTestController.dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=93638
Unreviewed. Unskip tests requiring layoutTestController.dumpResourceResponseMIMETypes.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-09
- platform/wk2/Skipped:
- 3:39 PM Changeset in webkit [125214] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, typo fix.
- platform/qt-5.0-wk2/Skipped:
- 3:36 PM Changeset in webkit [125213] by
-
- 6 edits2 adds in trunk
Invalid Content Security Policy sources should generate console warnings.
https://bugs.webkit.org/show_bug.cgi?id=93599
Patch by Mike West <mkwst@chromium.org> on 2012-08-09
Reviewed by Adam Barth.
Source/WebCore:
Given a Content Security Policy directive, we're currently correctly
ignoring sources that we can't parse: "'slef'", "http:///", etc. have
no effect on the protected resource's active policy. We're not, however
telling the developer what we're doing, which can lead to confusion.
This patch adds a console warning whenever an invalid source expression
is encountered while parsing a directive in order to make WebKit's
behavior more transparent to the developer.
There should be no functional change as a result of this patch: the
policy should be parsed exactly as before, it should simply be more
verbose.
Test: http/tests/security/contentSecurityPolicy/source-list-parsing-07.html
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPSourceList::parse):
Two changes: First, if 'parseSource' returns false, then log a
warning to the developer's console. Second, if both the source and
host are empty, but parsing succeeded, then we know we're dealing
with either a wildcard- or keyword-source that was properly handled
inside 'parseSource', so jump to the next source.
(WebCore::CSPSourceList::parseSource):
Wildcard- and keyword-sources now return 'true'. They parsed
correctly, after all.
(WebCore::ContentSecurityPolicy::reportInvalidSourceExpression):
Log a console warning if an invalid source expression is present in
a CSP directive's value.
(WebCore):
- page/ContentSecurityPolicy.h:
LayoutTests:
- http/tests/security/contentSecurityPolicy/source-list-parsing-02-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-02.html:
Move two invalid source tests out into 07.
- http/tests/security/contentSecurityPolicy/source-list-parsing-07-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-07.html: Added.
Many invalid source tests, all of which should generate warnings.
- 3:28 PM QtWebKitBuildBots edited by
- more udate (diff)
- 3:24 PM Changeset in webkit [125212] by
-
- 40 edits2 copies1 add in trunk/Source
[chromium] Expose CCGraphicsContext as WebCompositorOutputSurface
https://bugs.webkit.org/show_bug.cgi?id=92890
Reviewed by James Robinson.
Source/Platform:
The CCGraphicsContext was introduced as a wrapper around the 2D
and 3D output for the compositor. However, it is a CC only
concept. We want to be able to make 2D and ubercomp-mode IPCs on
behalf of the compositor. This patch allows this by pushing this
abstraction out to the Chrome-visible layer of the compositor,
changing the name to OutputSurface based on discussions on
wkb.ug/90736. A future patch will rename the CCGraphicsContext to
CCOutputSurface.
- Platform.gypi:
- chromium/public/WebCompositorOutputSurface.h: Added.
(WebKit):
(WebCompositorOutputSurface):
(WebKit::WebCompositorOutputSurface::~WebCompositorOutputSurface):
(WebKit::WebCompositorOutputSurface::Capabilities::Capabilities):
(Capabilities):
- chromium/public/WebCompositorOutputSurfaceClient.h: Added.
(WebKit):
(WebCompositorOutputSurfaceClient):
(WebKit::WebCompositorOutputSurfaceClient::~WebCompositorOutputSurfaceClient):
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
- chromium/public/WebLayerTreeViewClient.h:
(WebKit):
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::createContext3D):
(WebKit::WebLayerTreeViewClient::createOutputSurface):
Source/WebCore:
- platform/graphics/chromium/cc/CCGraphicsContext.h:
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::recreateContext):
(WebCore::CCLayerTreeHost::createContext):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
(CCLayerTreeHostClient):
(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::onVSyncParametersChanged):
(WebCore):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImplClient):
- platform/graphics/chromium/cc/CCProxy.h:
(WebKit):
(WebCore):
- platform/graphics/chromium/cc/CCRenderer.h:
(CCRendererClient):
(WebCore::CCRendererClient::~CCRendererClient):
- platform/graphics/chromium/cc/CCResourceProvider.cpp:
- platform/graphics/chromium/cc/CCResourceProvider.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::onVSyncParametersChanged):
(WebCore):
(WebCore::CCThreadProxy::beginFrame):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- WebKit.gyp:
- WebKit.gypi:
- public/WebSettings.h:
- public/WebViewClient.h:
(WebKit):
(WebViewClient):
(WebKit::WebViewClient::createOutputSurface):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):
- src/WebLayerTreeViewImpl.cpp:
(WebKit):
(WebGraphicsContextToOutputSurfaceAdapter):
(WebKit::WebGraphicsContextToOutputSurfaceAdapter::WebGraphicsContextToOutputSurfaceAdapter):
(WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createOutputSurface):
(WebKit):
(WebKit::WebViewImpl::didRebindGraphicsContext):
(WebKit::WebViewImpl::didRebindOutputSurface):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/CCLayerTreeHostImplTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(WTF::CCLayerTreeHostTestSetSingleLostContext::didRecreateOutputSurface):
(WTF::CCLayerTreeHostTestSetRepeatedLostContext::didRecreateOutputSurface):
- tests/CCResourceProviderTest.cpp:
(WebKit::CCResourceProviderTest::CCResourceProviderTest):
- tests/CCTextureUpdateControllerTest.cpp:
- tests/CCThreadedTest.cpp:
(WebKitTests::TestHooks::createOutputSurface):
- tests/CCThreadedTest.h:
(WebKitTests::TestHooks::didRecreateOutputSurface):
- tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
- tests/FakeCCGraphicsContext.h:
(WebKit::createFakeCCGraphicsContext):
- tests/FakeCCLayerTreeHostClient.h:
- tests/FakeWebCompositorOutputSurface.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCGraphicsContext.h.
(WebKit):
(FakeWebCompositorOutputSurface):
(WebKit::FakeWebCompositorOutputSurface::create):
(WebKit::FakeWebCompositorOutputSurface::FakeWebCompositorOutputSurface):
- tests/LayerRendererChromiumTest.cpp:
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):
- tests/WebLayerTest.cpp:
- tests/WebLayerTreeViewTest.cpp:
- 3:20 PM QtWebKitBuildBots edited by
- Update Qt versions on the bots, remove obsolete bots (diff)
- 3:10 PM Changeset in webkit [125211] by
-
- 3 edits in trunk/Source/WebKit/chromium
IndexedDB: additional chromium signature for openCursor
https://bugs.webkit.org/show_bug.cgi?id=93637
Patch by Alec Flett <alecflett@chromium.org> on 2012-08-09
Reviewed by Adam Barth.
Stub out the TaskType-based openCursor in the chromium API.
- src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::openCursor):
- src/WebIDBObjectStoreImpl.h:
(WebKit::WebIDBObjectStoreImpl::openCursor):
(WebIDBObjectStoreImpl):
- 2:59 PM Changeset in webkit [125210] by
-
- 2 edits in trunk/Websites/webkit.org
Address one more review comment.
- building/checkout.html:
- 2:57 PM Changeset in webkit [125209] by
-
- 18 edits5 deletes in branches/chromium/1229
Revert 117339 - CSS 2.1 failure: inline-table-001 fails
https://bugs.webkit.org/show_bug.cgi?id=84167
Reviewed by Julien Chaffraix.
Source/WebCore:
Override lastLineBoxBaseline() in RenderTable so that it picks up the baseline
of the text in the first row of the table. This allows inline tables to find the
correct baseline to align to.
Tests:
css2.1/20110323/inline-table-001.htm
css2.1/20110323/inline-table-002a.htm
css2.1/20110323/inline-table-003.htm
fast/css/empty-cell-baseline.html
- rendering/RenderTable.cpp:
(WebCore::getLineBoxBaseline):
(WebCore):
(WebCore::RenderTable::lastLineBoxBaseline):
(WebCore::RenderTable::firstLineBoxBaseline):
- rendering/RenderTable.h:
(RenderTable):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstLineBoxBaseline): if a cell is empty it cannot provide a
baseline. Tested by fast/css/empty-cell-baseline.html
LayoutTests:
- css2.1/20110323/inline-table-001.htm: Added.
- css2.1/20110323/inline-table-002a.htm: Added.
- css2.1/20110323/inline-table-003.htm: Added. From the CSS 2.1 test suite.
- fast/css/empty-cell-baseline-expected.html: Added.
- fast/css/empty-cell-baseline.html: Added. This ensures we don't take a baseline from an empty cell.
- fast/inline-block/001.html: Modified to make expected results clearer.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.txt: Added.
- platform/chromium-linux/editing/pasteboard/innerText-inline-table-expected.png:
Progression, the baseline of the text in each cell has moved up to where it should be.
- platform/chromium-linux/editing/selection/iframe-expected.png:
Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.
- platform/chromium-linux/editing/selection/inline-table-expected.png:
Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.
- platform/chromium-linux/editing/selection/table-caret-3-expected.png:
Progression, 'foo' and 'baz' line up with the first row of the inline table.
- platform/chromium-linux/fast/css-generated-content/inline-display-types-expected.png:
Progression, 'Test' and 'content' now line up.
- platform/chromium-linux/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
Progression, the two boxes now line up.
- platform/chromium-linux/fast/inline-block/001-expected.png:
Progression, the boxes now line up in the same way as FF and Opera.
- platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
Progression, the baseline of the text in each cell has moved up to where it should be.
- platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.txt:
- platform/chromium-win/editing/selection/iframe-expected.txt:
- platform/chromium-win/editing/selection/inline-table-expected.txt:
- platform/chromium-win/editing/selection/table-caret-3-expected.txt:
- platform/chromium-win/fast/css-generated-content/inline-display-types-expected.txt:
- platform/chromium-win/fast/inline-block/001-expected.txt:
- platform/chromium-win/fast/repaint/float-overflow-expected.txt:
- platform/chromium-win/fast/repaint/float-overflow-right-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/win/Skipped:
Text rebaselines.
TBR=robert@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10855085
- 2:57 PM Changeset in webkit [125208] by
-
- 2 edits in trunk/Websites/webkit.org
Recommend the use of https and mention git on building/checkout.html
https://bugs.webkit.org/show_bug.cgi?id=93657
Reviewed by Mark Rowe.
This page was quite out-dated. Stop mentioning about how to install subversion on OS X 10.4
because the paragraph right above it refers to buliding/tools.html for that.
Recommend the use of HTTPS connection for the Subversion checkout and also mention how to
checkout using a Git client.
- building/checkout.html:
- 2:56 PM Changeset in webkit [125207] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Export InRegionScroller to fix build
https://bugs.webkit.org/show_bug.cgi?id=93635
Patch by Leo Yang <leoyang@rim.com> on 2012-08-09
Reviewed by Antonio Gomes.
Build fix.
- Api/InRegionScroller.h:
- 2:51 PM Changeset in webkit [125206] by
-
- 3 edits3 adds in trunk/LayoutTests
[Qt] Unreviewed gardening, paint the bots green.
- platform/qt-5.0-wk2/Skipped: Skip failing tests.
- platform/qt-5.0-wk2/fast/forms/mailto/advanced-get-expected.txt: Added because of whitespace differenced.
- platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt: Added because of whitespace differenced.
- platform/qt/TestExpectations: Mark an asserting test as crash.
- 2:49 PM Changeset in webkit [125205] by
-
- 13 edits2 adds in trunk
[css3-text] Add suport for -webkit-text-decoration-line
https://bugs.webkit.org/show_bug.cgi?id=90959
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-09
Reviewed by Kenneth Rohde Christiansen.
This patch implements the "text-decoration-line" property specified in CSS3
working draft, with "-webkit-" prefix. The specification can be found below:
http://dev.w3.org/csswg/css3-text/#text-decoration-line
Additionally, Mozilla implementation details can be found here:
https://developer-dev.allizom.org/en-US/docs/CSS/text-decoration-line
It is important to notice that "-webkit-text-decoration-line" and
"text-decoration" properties shares the same property handlers, however, the
former resets the latter if value from latter doesn't have "important" value
set (same behavior as Firefox). In a rare case where both properties have
"important" value set, the text decoration gets value from the last parsed
property.
Source/WebCore:
Test: fast/css/text-decoration-line.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::parseTextDecoration):
- css/CSSParser.h:
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
LayoutTests:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/resources/property-names.js:
- fast/css/text-decoration-line-expected.html: Added.
- fast/css/text-decoration-line.html: Added.
- svg/css/getComputedStyle-basic-expected.txt:
- 2:35 PM Changeset in webkit [125204] by
-
- 5 edits in trunk/Tools
nrwt: should log progress like ninja does
https://bugs.webkit.org/show_bug.cgi?id=93563
Reviewed by Ojan Vafai.
This change modifies the output of nrwt in the
non--debug-rwt-logging modes.
In non-verbose mode, the output changes from:
"Testing (50%): 96 ran as expected, 4 didn't, 100 left"
to:
"[100/200] foo.html (+4)"
or:
"[100/200] foo.html failed unexpectedly (text diff)"
which indicates the earliest test currently running (optionally plus the
count of other currently-executing tests if we're running tests in parallel)
or the result of said test.
If the test produces unexpected results, that line is flushed
rather than erased (so we no longer need the %d didn't running
tally).
In --verbose mode, the output is similar, but every test gets a
line (and tests are logged in order of them being started, not
order of them being completed) (and in --details mode, the
first line of each test matches --verbose but the other lines
are unchanged).
The overall result should be easier to read and is simpler to
implement as well (apart from managing the number of tests that
have started but not completed, which is slightly annoying).
This also matches the output style for test-webkitpy, more-or-less.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.run_tests):
(LayoutTestRunner._update_summary_with_result):
(LayoutTestRunner._handle_started_test):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(FakePrinter):
(FakePrinter.print_started_test):
(FakePrinter.print_finished_test):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.init):
(Printer.print_started_test):
(Printer.print_finished_test):
(Printer._print_test_trace):
(Printer._print_progress):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(test_details):
- 2:25 PM Changeset in webkit [125203] by
-
- 10 edits1 add in trunk/Source/WebCore
Extract the definition of NativeImagePtr from ImageSource.h into NativeImagePtr.h.
https://bugs.webkit.org/show_bug.cgi?id=93466
Patch by Huang Dongsung <luxtella@company100.net> on 2012-08-09
Reviewed by Adam Barth.
Image.h includes ImageSource.h in order to know the definition of NativeImagePtr.
But Image does not need to know the definition of ImageSource. So, this patch
extracts the definition of NativeImagePtr from ImageSource.h into NativeImagePtr.h.
This is a preparation for asynchronous image decoding. Async decoding
will need a callback function, which sends a NativeImagePtr to clients, and the
callback must know the definition of NativeImagePtr, not ImageSource.
No new tests, behavior is unchanged.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/BitmapImage.h:
- platform/graphics/Image.h:
- platform/graphics/ImageSource.h:
(WebCore):
- platform/graphics/NativeImagePtr.h: Added.
(WebCore):
- 2:12 PM Changeset in webkit [125202] by
-
- 3 edits14 adds in trunk
CSS 2.1 failure: 'Text-indent' only affects a line if it is the first formatted line of an element
https://bugs.webkit.org/show_bug.cgi?id=63185
Reviewed by Eric Seidel.
Source/WebCore:
Per CSS 2.1 (http://www.w3.org/TR/CSS21/text.html) : "'Text-indent' only affects a line if it is the
first formatted line of an element. For example, the first line of an anonymous block box is only
affected if it is the first child of its parent element."
Tests: fast/css/text-indent-first-line-001.html
fast/css/text-indent-first-line-002.html
fast/css/text-indent-first-line-003.html
fast/css/text-indent-first-line-004.html
fast/css/text-indent-first-line-005.html
fast/css/text-indent-first-line-006.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): As well as being the first line under a parent block,
check that this is also the first *formatted* line of an element by ensuring that we are at the start of a
formatting context and not just a continuation of a previous anonymous block in an existing formatting context.
LayoutTests:
- css2.1/20110323/text-indent-014-expected.html: Added.
- css2.1/20110323/text-indent-014.htm: Added.
- fast/css/text-indent-first-line-001-expected.html: Added.
- fast/css/text-indent-first-line-001.html: Added.
- fast/css/text-indent-first-line-002-expected.html: Added.
- fast/css/text-indent-first-line-002.html: Added.
- fast/css/text-indent-first-line-003-expected.html: Added.
- fast/css/text-indent-first-line-003.html: Added.
- fast/css/text-indent-first-line-004-expected.html: Added.
- fast/css/text-indent-first-line-004.html: Added.
- fast/css/text-indent-first-line-005-expected.html: Added.
- fast/css/text-indent-first-line-005.html: Added. Text-indent in the span here is inherited from the div. CSS 2.1: "Since the 'text-indent' property inherits, when specified on a block element, it will affect descendant inline-block elements."
- fast/css/text-indent-first-line-006-expected.html: Added.
- fast/css/text-indent-first-line-006.html: Added.
- 2:00 PM Changeset in webkit [125201] by
-
- 10 edits2 adds in trunk/Source/WebCore
Web Inspector: replace the Web Inspector editor with CodeMirror
https://bugs.webkit.org/show_bug.cgi?id=92769
Patch by Jan Keromnes <janx@linux.com> on 2012-08-09
Reviewed by Pavel Feldman.
Integrating CodeMirror as a devtools experiment. Currently supporting
basic editing, search/replacing, and saving. Missing proper breakpoints
wiring, debugging, message bubbles, popovers and context menus. WIP.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CodeMirrorTextEditor.js: Added.
(WebInspector.CodeMirrorTextEditor.this._codeMirror.CodeMirror):
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.set mimeType):
(WebInspector.CodeMirrorTextEditor.prototype.setReadOnly):
(WebInspector.CodeMirrorTextEditor.prototype.readOnly):
(WebInspector.CodeMirrorTextEditor.prototype.defaultFocusedElement):
(WebInspector.CodeMirrorTextEditor.prototype.focus):
(WebInspector.CodeMirrorTextEditor.prototype.revealLine):
(WebInspector.CodeMirrorTextEditor.prototype.addDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.removeDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.markAndRevealRange):
(WebInspector.CodeMirrorTextEditor.prototype.highlightLine):
(WebInspector.CodeMirrorTextEditor.prototype.clearLineHighlight):
(WebInspector.CodeMirrorTextEditor.prototype.freeCachedElements):
(WebInspector.CodeMirrorTextEditor.prototype.elementsToRestoreScrollPositionsFor):
(WebInspector.CodeMirrorTextEditor.prototype.inheritScrollPositions):
(WebInspector.CodeMirrorTextEditor.prototype.beginUpdates):
(WebInspector.CodeMirrorTextEditor.prototype.endUpdates):
(WebInspector.CodeMirrorTextEditor.prototype.onResize):
(WebInspector.CodeMirrorTextEditor.prototype.editRange):
(WebInspector.CodeMirrorTextEditor.prototype._onChange):
(WebInspector.CodeMirrorTextEditor.prototype._commitEditing):
(WebInspector.CodeMirrorTextEditor.prototype.scrollToLine):
(WebInspector.CodeMirrorTextEditor.prototype.selection):
(WebInspector.CodeMirrorTextEditor.prototype.lastSelection):
(WebInspector.CodeMirrorTextEditor.prototype.setSelection):
(WebInspector.CodeMirrorTextEditor.prototype.setText):
(WebInspector.CodeMirrorTextEditor.prototype.text):
(WebInspector.CodeMirrorTextEditor.prototype.range):
(WebInspector.CodeMirrorTextEditor.prototype.line):
(WebInspector.CodeMirrorTextEditor.prototype.get linesCount):
(WebInspector.CodeMirrorTextEditor.prototype.setAttribute):
(WebInspector.CodeMirrorTextEditor.prototype.getAttribute):
(WebInspector.CodeMirrorTextEditor.prototype.removeAttribute):
(WebInspector.CodeMirrorTextEditor.prototype.wasShown):
(WebInspector.CodeMirrorTextEditor.prototype.willHide):
(WebInspector.CodeMirrorTextEditor.prototype._textChanged):
(WebInspector.CodeMirrorTextEditor.prototype._toPos):
(WebInspector.CodeMirrorTextEditor.prototype._toRange):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/cmdevtools.css: Added.
- inspector/front-end/inspector.html:
- 1:58 PM Changeset in webkit [125200] by
-
- 2 edits4 deletes in trunk/LayoutTests
Gardening LayoutTests/platform/win/fast/canvas tests folder.
https://bugs.webkit.org/show_bug.cgi?id=93633
Patch by Roger Fong <roger_fong@apple.com> on 2012-08-09
Reviewed by Tim Horton.
These tests pass now.
Adjusting expected results.
Removing other failing results.
- platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt:
This test is now passing. Modifying to passing results since Mac fallback results are failing.
- platform/win/fast/canvas/canvas-scale-drawImage-shadow-expected.txt: Removed.
- platform/win/fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Removed.
- platform/win/fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Removed.
- platform/win/fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Removed.
- 1:38 PM Changeset in webkit [125199] by
-
- 2 edits in trunk/Source/JavaScriptCore
[QNX] Implement getCPUTime() for OS(QNX)
https://bugs.webkit.org/show_bug.cgi?id=93516
Patch by Yong Li <yoli@rim.com> on 2012-08-09
Reviewed by George Staikos.
Implement getCPUTime() with CLOCK_THREAD_CPUTIME_ID so it will tell
exactly how long the current thread has spent without being impacted
by other things.
- runtime/TimeoutChecker.cpp:
(JSC::getCPUTime):
- 1:35 PM Changeset in webkit [125198] by
-
- 4 edits in trunk/Source
Versioning.
- 1:31 PM Changeset in webkit [125197] by
-
- 6 edits in trunk
[WK2] Add a process model constant for multiple processes
https://bugs.webkit.org/show_bug.cgi?id=93642
Reviewed by Anders Carlsson.
- UIProcess/ProcessModel.h: Added ProcessModelMultipleSecondaryProcesses. Deleted ProcessModelSecondaryProcess in favor of more descriptive ProcessModelSharedSecondaryProcess - these used to behave the same.
- UIProcess/WebContext.cpp: (WebKit::WebContext::create): Changed to use ProcessModelSharedSecondaryProcess.
- UIProcess/WebProcessProxy.h: Removed an unncessary include of ProcessModel.h.
- 1:15 PM Changeset in webkit [125196] by
-
- 35 edits in trunk/Source
[chromium] Do partial-swap scissoring on quads during draw instead of on layers
https://bugs.webkit.org/show_bug.cgi?id=91800
Reviewed by Adrienne Walker.
Source/WebCore:
Computing the scissor rect for each render pass is now done in
LayerRendererChromium::drawRenderPass() instead of being done for each
layer and then copied into the quads. This allows us to always push a
full frame of quads (and include damage rects) from a child compositor,
and do partial-swap scissoring in the host compositor.
This also make partial-swap functionality completely contained within
LayerRendererChromium!
The scissorRect is removed from all layers, and the concept of
scissorRect is now misplaced in CCOcclusionTracker, so the variables
and methods in the tracker should be renamed to more appropriate
things.
Covered by existing tests, as well as: CCLayerTreeHostImplTest.textureCachingWithScissor
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::clearFramebuffer):
(WebCore::LayerRendererChromium::renderPassTextureSize):
(WebCore::LayerRendererChromium::drawFrame):
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::swapBuffers):
(WebCore::LayerRendererChromium::useRenderPass):
(WebCore::LayerRendererChromium::setScissorToRect):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
(DrawingFrame):
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
- platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
- platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore::CCDrawQuad::clippedRectInTarget):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::createSharedQuadState):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintLayerContents):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateVisibleRectsInternal):
(WebCore::CCLayerTreeHostCommon::calculateVisibleRects):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(CCLayerTreeHostCommon):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::swapBuffers):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::layerScissorRectInTargetSurface):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::CCRenderPass):
(WebCore::CCRenderPass::appendQuadsToFillScreen):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
(WebCore::CCRenderPass::transformToRootTarget):
(WebCore::CCRenderPass::outputRect):
(WebCore::CCRenderPass::damageRect):
(WebCore::CCRenderPass::setDamageRect):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::computeClippedRectInTarget):
(WebCore):
(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
- platform/graphics/chromium/cc/CCRenderer.h:
(CCRenderer):
- platform/graphics/chromium/cc/CCSharedQuadState.cpp:
(WebCore::CCSharedQuadState::create):
(WebCore::CCSharedQuadState::CCSharedQuadState):
- platform/graphics/chromium/cc/CCSharedQuadState.h:
(CCSharedQuadState):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::executeCalculateDrawTransformsAndVisibility):
- tests/CCLayerIteratorTest.cpp:
- tests/CCLayerTreeHostCommonTest.cpp:
Removed tests of the scissor rect here, as they are no longer
computed within CCLayerTreeHostCommon. Verify that the scissor
does not affect texture caching in CCLayerTreeHostImplTest now.
Previous scissor would affect the texture cache decisions, but
this was incorrect, as damaged areas are always inside the
scissor rect, and anything outside the scissor rect should
be considered as valid and complete (assuming no external
occlusion, which is computed outside the scissor rect now also).
- tests/CCLayerTreeHostImplTest.cpp:
Removed didDrawNotCalledOnScissoredLayer test, as this no longer
applies. didDraw will be called on layers that are outside the
partial swap rect, regardless.
Removed partialSwapNoUpdate test, and merged its functionality into
the partialSwap test while updating its expectations.
Added textureCachingWithScissor, which is loosely based on the
CCLayerTreeHostCommonTest.scissorRectWithClip test.
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
- tests/CCQuadCullerTest.cpp:
- tests/CCRenderSurfaceTest.cpp:
- tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
- tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::createLayer):
- tests/LayerRendererChromiumTest.cpp:
(LayerRendererChromiumTest::swapBuffers):
(TEST_F):
(TEST):
- tests/TiledLayerChromiumTest.cpp:
- 1:08 PM Changeset in webkit [125195] by
-
- 3 edits2 adds in trunk
Source/WebCore: Content Security Policy directives that begin with an invalid character should log a console warning.
https://bugs.webkit.org/show_bug.cgi?id=93622
Patch by Mike West <mkwst@chromium.org> on 2012-08-09
Reviewed by Adam Barth.
CSP directives containing unrecognized characters somewhere in the
middle were caught and logged by the current algorithm. We additionally
caught the case in which the directive begins with an invalid character,
but we silently ignored it. Now we're slightly more vocal.
This change also exits 'parseDirective' early in the case where the
directive text is empty, or filled only with whitespace. There doesn't
seem to be any value in flagging that case, as it has no impact on the
way the policy would have been interpreted (that is, 'img-src *;;...'
doesn't change in meaning by ignoring the empty directive between the
semicolons).
Test: http/tests/security/contentSecurityPolicy/directive-parsing-05.html
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::parseDirective):
Two changes: first, we now exit early if the entire directive text
is empty (e.g. ';;;' or '; ;'); second, if the directive begins
with a character that doesn't match 'isDirectiveNameCharacter', then
we advance either to the next space, or the end of the value, and
report an unrecognized directive to the policy.
LayoutTests: Content Security Policy directives with an invalid character should log a console warning.
https://bugs.webkit.org/show_bug.cgi?id=93622
Patch by Mike West <mkwst@chromium.org> on 2012-08-09
Reviewed by Adam Barth.
- http/tests/security/contentSecurityPolicy/directive-parsing-05-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/directive-parsing-05.html: Added.
- 1:01 PM Changeset in webkit [125194] by
-
- 5 edits in trunk
PerformanceTests: Another build fix after r125178.
- resources/runner.js:
LayoutTests: Fix a test after r125178.
- fast/harness/perftests/runs-per-second-log-expected.txt:
- fast/harness/perftests/runs-per-second-log.html:
- 12:39 PM Changeset in webkit [125193] by
-
- 11 edits4 adds in trunk
[chromium] Pass mask scale and offset to shaders for correct masking
https://bugs.webkit.org/show_bug.cgi?id=93558
Reviewed by Adrienne Walker.
Source/WebCore:
In chromium compositor code, the mask was accidentally mapped 1:1
to the layer's renderSurface, rather than the layer itself. This
patch adds a layout test that reproduces the error and fixes the
problem. The solution we opted for in this patch is to pass a
scale and offset to the fragment shader, so that the correct
texture coordinate lookup is computed by the fragment shader.
Test: compositing/masks/mask-of-clipped-layer.html
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRenderPassQuad):
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::FragmentShaderRGBATexAlphaMask::FragmentShaderRGBATexAlphaMask):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderRGBATexAlphaMask::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::FragmentShaderRGBATexAlphaMaskAA):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):
- platform/graphics/chromium/ShaderChromium.h:
(WebCore::FragmentShaderRGBATexAlphaMask::maskTexCoordScaleLocation):
(WebCore::FragmentShaderRGBATexAlphaMask::maskTexCoordOffsetLocation):
(FragmentShaderRGBATexAlphaMask):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskTexCoordScaleLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskTexCoordOffsetLocation):
(FragmentShaderRGBATexAlphaMaskAA):
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::maskTexCoordScaleX):
(WebCore::CCRenderPassDrawQuad::maskTexCoordScaleY):
(WebCore::CCRenderPassDrawQuad::maskTexCoordOffsetX):
(WebCore::CCRenderPassDrawQuad::maskTexCoordOffsetY):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::appendQuads):
Source/WebKit/chromium:
Updated one unit test that needed additional args in a
constructor, but no change in behavior of the test.
- tests/CCLayerTreeHostImplTest.cpp:
LayoutTests:
Added a layout test that checks the mask does not accidentally get
resized when it is inside of an overflow div.
- compositing/masks/mask-of-clipped-layer-expected.png: Added.
- compositing/masks/mask-of-clipped-layer-expected.txt: Added.
- compositing/masks/mask-of-clipped-layer.html: Added.
- compositing/resources/alpha-blocks.png: Added.
- 12:13 PM Changeset in webkit [125192] by
-
- 5 edits2 adds in trunk
CSSRegions: Crash when attaching a region to the removed named flow
https://bugs.webkit.org/show_bug.cgi?id=93204
Reviewed by Abhishek Arya.
Source/WebCore:
The crash happens because the flow thread reference is passed to the RenderRegion object
when the RenderRegion object is created. However, it is only in RenderRegion::attachRegion method
when the region is taken into account and stored in flow thread regions list. Under these circumstances,
it is possible that the flow thread passed to the region at the moment of region creation be destroyed
before the region gets the chance to be attached to the flow thread and a crash will occur.
This patch moves the moment when the RenderRegion object stores its 'weak' reference to the flow thread
from RenderRegion constructor to attachRegion method, preventing the situation in which the region is attached
to a wrong flow thread object.
Test: fast/regions/region-attached-wrong-flow-crash.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject): Pass 0 instead of a reference to the flow thread.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::checkRegionStyle): Added this function to check whether the region has region style rules attached.
(WebCore):
(WebCore::RenderRegion::styleDidChange): Use checkRegionStyle.
(WebCore::RenderRegion::attachRegion): Store the reference to the flow thread. If the flow thread does not exist, it will be created.
Also, check whether the region has region style rules attached, since at this moment the region has a flow thread. Checking whether
the region has region style rules is not enough in styleDidChange, because styleDidChange is sometimes triggered before attachRegion.
- rendering/RenderRegion.h:
(RenderRegion):
LayoutTests:
Add test reproducing the crash.
- fast/regions/region-attached-wrong-flow-crash-expected.txt: Added.
- fast/regions/region-attached-wrong-flow-crash.html: Added.
- 11:53 AM Changeset in webkit [125191] by
-
- 2 edits in trunk/LayoutTests
(r125185) http/tests/images/jpg-img-partial-load.html timeout on Lion
https://bugs.webkit.org/show_bug.cgi?id=93636
Unreviewed test expectations update.
- platform/mac/TestExpectations:
- 11:46 AM Changeset in webkit [125190] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Updated expectations for script-change-externalResourcesRequired-while-loading.svg
Unreviewed gardening.
Patch by Florin Malita <fmalita@chromium.org> on 2012-08-09
- platform/chromium/TestExpectations:
- 11:41 AM Changeset in webkit [125189] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Enable kerning on Android
https://bugs.webkit.org/show_bug.cgi?id=92737
Patch by Iain Merrick <husky@chromium.org> on 2012-08-09
Reviewed by Adam Barth.
This #ifdef was incorrectly copied from our forked WebKit repository
while unforking our Android-specific changes. Kerning works without
any known problems.
Covered by existing tests (layout and instrumentation tests).
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
(WebCore::ComplexTextController::ComplexTextController):
- 11:27 AM Changeset in webkit [125188] by
-
- 4 edits in trunk/Tools
Build fix after r125178.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.parse_output): Don't include non-time results in the JSON output.
- Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated the test outputs so to match
actual test outputs.
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Ditto.
- 11:07 AM Changeset in webkit [125187] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening after r125102
https://bugs.webkit.org/show_bug.cgi?id=93593
Unreviewed gardening.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-09
- platform/efl/TestExpectations: Included newly added compositing/plugins/no-backing-store.html test.
- 10:56 AM Changeset in webkit [125186] by
-
- 4 edits in trunk
Web Inspector: follow up to r125174 - fix subtype use.
Source/WebCore:
Not reviewed, trivial fix.
- inspector/InjectedScriptSource.js:
(.):
LayoutTests:
Not reviewed.
- inspector/console/console-format-expected.txt:
- 10:37 AM Changeset in webkit [125185] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: DocumentEventQueue memory instrumentation
https://bugs.webkit.org/show_bug.cgi?id=93604
Reviewed by Pavel Feldman.
Provided DocumentEventQueue:: reportMemoryUsage implementation.
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::reportMemoryUsage):
(WebCore):
- dom/DocumentEventQueue.h:
(WebCore):
- dom/Event.cpp:
(WebCore::Event::reportMemoryUsage):
(WebCore):
- dom/Event.h:
(WebCore):
(Event):
- 10:26 AM Changeset in webkit [125184] by
-
- 6 edits8 adds in trunk/Source
Web Inspector: add codemirror library as an experiment
https://bugs.webkit.org/show_bug.cgi?id=93620
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change adds codemirror, deploys it, but does not include it into the inspector.html. Clients need to fetch it
using XHR and eval into the inspector's context to use as a part of their experiments.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/cm/LICENSE: Added.
- inspector/front-end/cm/codemirror.css: Added.
(.CodeMirror):
- inspector/front-end/cm/xml.js: Added.
(CodeMirror.defineMode.):
(CodeMirror.defineMode):
Source/WebKit/chromium:
- WebKit.gyp:
- 10:19 AM Changeset in webkit [125183] by
-
- 2 edits in trunk/Source/WebCore
1.9.6 drops symbols, breaking compatibility
https://bugs.webkit.org/show_bug.cgi?id=93477
Patch by Xan Lopez <xlopez@igalia.com> on 2012-08-09
Reviewed by Carlos Garcia Campos.
Expose documentURI as writable again for the GObject DOM
bindings. DOM4 makes it read-only, but we need to revert to the
old state for compatibility reasons, just like Objective C.
- dom/Document.idl: ditto.
- 10:15 AM Changeset in webkit [125182] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/forms/autocomplete-off-with-default-value-does-not-clear.html is failing (on Chromium)
https://bugs.webkit.org/show_bug.cgi?id=93586
Not reviewed (fixing a test failure).
This test is only valid for platforms with the page cache enabled.
- platform/chromium/TestExpectations: Skip fast/forms/autocomplete-off-with-default-value-does-not-clear.html
- 10:11 AM Changeset in webkit [125181] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r124997): Flaky crashes in two tests
https://bugs.webkit.org/show_bug.cgi?id=93501
Reviewed by Martin Robinson.
Add missing null check to make sure we early return if the
accessibility object does not have a valid parent exposed in the
accessibility hierarchy.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::emitTextChanged): Add missing null check.
- 10:10 AM Changeset in webkit [125180] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening: updated expectations for console-format-collections.html.
Patch by Florin Malita <fmalita@chromium.org> on 2012-08-09
- platform/chromium/TestExpectations:
- 9:22 AM Changeset in webkit [125179] by
-
- 3 edits in trunk/PerformanceTests
Add memory measurement to balls.html and dromaeorunner.js
https://bugs.webkit.org/show_bug.cgi?id=93617
Reviewed by Adam Barth.
Since we added memory measurement support to performance tests we need to modify these tests.
- Animation/balls.html:
- Dromaeo/resources/dromaeorunner.js:
- 9:21 AM Changeset in webkit [125178] by
-
- 4 edits in trunk
JSHeap and FastMallocStatistics based memory measurement for performance-tests
https://bugs.webkit.org/show_bug.cgi?id=90858
PerformanceTests:
Reviewed Ryosuke Niwa.
Measure the memory usage of the performancetests with the help of the windows.memory.usedJSHeapSize
object and the window.internals.fastMallocStatistics() function call.
- resources/runner.js:
(PerfTestRunner.logStatistics):
(PerfTestRunner.printStatistics):
(PerfTestRunner.storeHeapResults):
(PerfTestRunner.getUsedFastMallocHeap):
(PerfTestRunner.getUsedJSHeap):
(PerfTestRunner.getAndPrintMemoryStatistics):
(PerfTestRunner.ignoreWarmUpAndLog):
(PerfTestRunner.initAndStartLoop):
Tools:
Reviewed by Ryosuke Niwa.
Measure the memory usage of the performancetests with the help of the windows.memory.usedJSHeapSize
object and the window.internals.fastMallocStatistics() function call.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output):
(PerfTest.output_statistics):
- 9:11 AM Changeset in webkit [125177] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening: updated Win results for 125160.
Patch by Florin Malita <fmalita@chromium.org> on 2012-08-09
- platform/chromium-win/svg/custom/use-detach-expected.png:
- 9:10 AM Changeset in webkit [125176] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/12035637> 32-bit PluginProcess launches without appropriate DYLD environment variables if UI process is 64-bit only
https://bugs.webkit.org/show_bug.cgi?id=93596
Reviewed by Mark Rowe.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Changed to pass the current architecture, rather than
the intended child process architecture, to the DynamicLinkerEnvironmentExtractor constructor.
- 8:49 AM Changeset in webkit [125175] by
-
- 5 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening: updated results for 125167.
Patch by Florin Malita <fmalita@chromium.org> on 2012-08-09
- platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
- platform/chromium-mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
- platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
- platform/chromium/TestExpectations:
- 8:13 AM Changeset in webkit [125174] by
-
- 34 edits3 deletes in trunk
2012-08-09 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: generate preview for the objects dumped into the console upon logging.
https://bugs.webkit.org/show_bug.cgi?id=35801
Reviewed by Vsevolod Vlasov.
As of today, dumping an object (array) into console will result in objects' properties being
read upon console object expansion (i.e. lazily). This means that dumping the same object while
mutating it will be hard to debug using the console.
This change starts generating abbreviated previews for objects / arrays at the moment of their
logging and passes this information along into the front-end. This only happens when the front-end
is already opened, it only works for console.log(), not live console interaction.
Covered by the existing console tests + collections test has been expanded to capture both: pre and post-
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
- inspector/ConsoleMessage.h: (ConsoleMessage):
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::wrapObject):
- inspector/InjectedScript.h: (InjectedScript):
- inspector/InjectedScriptSource.js: (.):
- inspector/Inspector.json:
- inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::enable): (WebCore::InspectorConsoleAgent::addConsoleMessage):
- inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessageImpl.prototype._format): (WebInspector.ConsoleMessageImpl.prototype._formatParameter): (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject): (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArrayOrObject): (WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview): (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode): (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray): (WebInspector.ConsoleMessageImpl.prototype._printArray): (WebInspector.ConsoleMessageImpl.prototype._formatAsArrayEntry): (WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
- inspector/front-end/DOMExtension.js: (Element.prototype.createTextChild):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection):
- inspector/front-end/PropertiesSection.js:
- inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject): (WebInspector.RemoteObject.fromPayload): (WebInspector.RemoteObject.prototype.get preview):
- inspector/front-end/Section.js:
- inspector/front-end/inspector.css: (.console-group-messages .section .header .title): (.section .console-formatted-node): (.console-object-preview): (.section .properties .name, .event-properties .name, .console-formatted-object .name):
2012-08-09 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: generate preview for the objects dumped into the console upon logging.
https://bugs.webkit.org/show_bug.cgi?id=35801
Reviewed by Vsevolod Vlasov.
- inspector/console/command-line-api-inspect-expected.txt:
- inspector/console/console-dir-expected.txt:
- inspector/console/console-eval-global-expected.txt:
- inspector/console/console-eval-global.html:
- inspector/console/console-format-collections-expected.txt:
- inspector/console/console-format-collections.html:
- inspector/console/console-format-expected.txt:
- inspector/console/console-format.html:
- inspector/console/console-log-document-proto-expected.txt:
- inspector/console/console-log-document-proto.html:
- inspector/console/console-log-toString-object-expected.txt:
- inspector/debugger/watch-expressions-panel-switch-expected.txt:
- inspector/elements/event-listener-sidebar-expected.txt:
- inspector/elements/event-listeners-about-blank-expected.txt:
- platform/chromium/inspector/console/console-dir-expected.txt:
- platform/chromium/inspector/console/console-eval-global-expected.txt: Removed.
- platform/chromium/inspector/console/console-format-collections-expected.txt:
- platform/chromium/inspector/console/console-format-expected.txt: Removed.
- platform/chromium/inspector/console/console-log-document-proto-expected.txt:
- platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt:
- platform/chromium/inspector/elements/event-listener-sidebar-expected.txt: Removed.
- 8:05 AM Changeset in webkit [125173] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r125171.
http://trac.webkit.org/changeset/125171
Broke the Chromium Android build.
- DEPS:
- 7:17 AM Changeset in webkit [125172] by
-
- 4 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0/fast/js/global-constructors-expected.txt:
- platform/qt/Skipped:
- platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
- platform/qt/fast/events/keyevent-iframe-removed-crash-expected.txt: Added.
- 7:05 AM Changeset in webkit [125171] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 7:03 AM Changeset in webkit [125170] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update TestExpectations with one more test to rebase after r125167
- platform/chromium/TestExpectations:
- 5:49 AM WebKitGTK/1.8.x edited by
- (diff)
- 5:48 AM WebKitGTK/1.8.x edited by
- (diff)
- 5:43 AM WebKitGTK/1.8.x edited by
- (diff)
- 5:43 AM Changeset in webkit [125169] by
-
- 6 edits in trunk/Source
Page popups can show up at wrong locations
https://bugs.webkit.org/show_bug.cgi?id=93556
Reviewed by Kent Tamura.
Source/WebCore:
No new tests. Cannot test popup position.
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::contentSize):
Source/WebKit/chromium:
We were showing the popup at wrong positions. When there isn't enough
room below and above the element it adjusts the position but we weren't
resetting the adjustment when we resize the popup. This patch will make
the popup adjust the popup position each time we resize.
- src/ColorChooserUIController.cpp:
(WebKit::ColorChooserUIController::contentSize):
- src/WebPagePopupImpl.cpp:
(WevKit::PagePopupChromeClient::setWindowRect):
(WebKit::WebPagePopupImpl::init): Use reposition().
(WebKit::WebPagePopupImpl::reposition): Repositions the page popup based on the popup size.
(WebKit):
(WebKit::WebPagePopupImpl::resize): Use reposition().
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- 5:24 AM Changeset in webkit [125168] by
-
- 7 edits in trunk
Web Inspector: display progress bar while loading timeline data
https://bugs.webkit.org/show_bug.cgi?id=92762
Reviewed by Pavel Feldman.
Source/WebCore:
- display progress while loading timeline data;
- disable status bar buttons while operation is in progress;
- ignore save/load/record while operation is in progress;
- disable context menu items while operation is in progress;
- misc. compilation warning fixes;
- inspector/front-end/ProgressBar.js:
(WebInspector.CompositeProgress.prototype.createSubProgress):
- inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype._loadNextChunk):
(WebInspector.TimelineModel.prototype.loadFromFile.parseAndImportData):
(WebInspector.TimelineModel.prototype.loadFromFile.onLoad):
(WebInspector.TimelineModel.prototype.loadFromFile.onError):
(WebInspector.TimelineModel.prototype.loadFromFile.onProgress):
(WebInspector.TimelineModel.prototype.loadFromFile):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusBarItems):
(WebInspector.TimelinePanel.prototype._setOperationInProgress):
(WebInspector.TimelinePanel.prototype._contextMenu):
(WebInspector.TimelinePanel.prototype._saveToFile):
(WebInspector.TimelinePanel.prototype._loadFromFile):
(WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):
(WebInspector.TimelinePanel.prototype.sidebarResized):
- inspector/front-end/utilities.js: added Array.prototype.select(field) to map array of objects to array containing particular field of each object.
LayoutTests:
- fix loading tests to pass mock progress indicator;
- inspector/timeline/timeline-load-incompatible.html:
- inspector/timeline/timeline-load.html:
- 5:20 AM Changeset in webkit [125167] by
-
- 15 edits in trunk
Floored and truncated rounded confused.
https://bugs.webkit.org/show_bug.cgi?id=93475
Reviewed by Levi Weintraub.
Source/WebCore:
Fix the common mistake of confusing truncating (round towards zero) and
flooring (round down). They are only identical for positive numbers,
not for negative numbers.
This patch fixes instances of misimplemented or misused floor in the
layout and geometric code. And also uses the new correct implementations
to clean up the code for enclosingRect.
- platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::fromFloatFloor):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::ceil):
(WebCore::FractionalLayoutUnit::floor):
- platform/graphics/FloatPoint.h:
(WebCore::FloatPoint::FloatPoint):
(WebCore::roundedIntPoint):
(WebCore::flooredIntPoint):
(WebCore::ceiledIntPoint):
(WebCore::flooredIntSize):
- platform/graphics/FloatRect.cpp:
(WebCore::enclosingIntRect):
(WebCore::enclosedIntRect):
- platform/graphics/FloatSize.h:
(WebCore::roundedIntSize):
(WebCore::flooredIntSize):
(WebCore::flooredIntPoint):
- platform/graphics/FractionalLayoutPoint.h:
(WebCore::flooredIntPoint):
(WebCore::flooredFractionalLayoutPoint):
(WebCore::ceiledFractionalLayoutPoint):
- platform/graphics/FractionalLayoutRect.cpp:
(WebCore::enclosingIntRect):
(WebCore::enclosingFractionalLayoutRect):
- platform/graphics/FractionalLayoutSize.h:
(WebCore::flooredIntSize):
- platform/graphics/IntRect.cpp:
(WebCore::IntRect::IntRect):
- rendering/LayoutTypes.h:
(WebCore::flooredLayoutPoint):
(WebCore::floorToInt):
(WebCore::isIntegerValue):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::convertToLayerCoords):
LayoutTests:
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 5:18 AM Changeset in webkit [125166] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: use WebInspector.ProgressIndicator in AdvancedSearchController
https://bugs.webkit.org/show_bug.cgi?id=93362
Reviewed by Vsevolod Vlasov.
- drop custom status bar used in AdvancedSearchController, use WebInspector.ProgressIndicator;
- perform additional cancelation check after invoking searchResultCallback to account for stopSearch called from within callback;
- fix compilation warnings in ProgressBar;
- inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView):
(WebInspector.SearchView.prototype.searchStarted):
(WebInspector.SearchView.prototype.addSearchResult):
(WebInspector.SearchView.prototype.searchFinished):
(WebInspector.SearchView.prototype._onCancel):
- inspector/front-end/ProgressBar.js:
(WebInspector.CompositeProgress.prototype.createSubProgress):
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
- inspector/front-end/inspector.css:
(.progress-bar-container progress):
(body.platform-mac .progress-bar-container progress):
- 5:08 AM Changeset in webkit [125165] by
-
- 5 edits in trunk
Web Inspector: improve large array logging experience
https://bugs.webkit.org/show_bug.cgi?id=93499
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Group elements in chunks of 100, not smaller.
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.FunctionScopeMainTreeElement):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):
(WebInspector.ArrayGroupingTreeElement._populateRanges):
LayoutTests:
- inspector/console/console-big-array-expected.txt:
- inspector/console/console-big-array.html:
- 4:34 AM Changeset in webkit [125164] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Pull in the android_tools directory for Android
https://bugs.webkit.org/show_bug.cgi?id=84843
Reviewed by Jochen Eisinger.
Pull in the android_tools directory for Chromium Android checkouts. This
repository, living in Chromium's, contains checked in versions of the
Android NDK and SDK meant to make builds and updates easier.
- DEPS:
- 4:00 AM Changeset in webkit [125163] by
-
- 2 edits in trunk/Tools
[Qt][Win] Build system bug revealed by r124835
https://bugs.webkit.org/show_bug.cgi?id=93339
Reviewed by Tor Arne Vestbø.
Don't add "LC_ALL=c" on Windows in svnRevisionForDirectory() and in pathRelativeToSVNRepositoryRootForPath().
- Scripts/VCSUtils.pm:
(isWindows): Copied from webkitdirs.pm.
(svnRevisionForDirectory):
(pathRelativeToSVNRepositoryRootForPath):
- 1:16 AM Changeset in webkit [125162] by
-
- 5 edits4 adds in trunk
DOMCharacterDataModified should not be fired inside shadows
https://bugs.webkit.org/show_bug.cgi?id=93427
Reviewed by Ryosuke Niwa.
Source/WebCore:
CharacterData::dispatchModifiedEvent() fires DOMCharacterDataModified event even if
the node is in shadow. But it shouldn't. Check dispatchChildInsertionEvents() and
dispatchChildRemovalEvents() to see how other MutationEvents are suppressed behind shadows.
This change follows the same path to suppress DOMCharacterDataModified.
Tests: fast/dom/shadow/suppress-mutation-events-in-shadow-characterdata.html
fast/forms/textarea-and-mutation-events-appending-text.html
- dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):
LayoutTests:
Added two tests. This also fixes existing test, which cover the wrong behavior.
- fast/dom/shadow/suppress-mutation-events-in-shadow-characterdata-expected.txt: Added.
- fast/dom/shadow/suppress-mutation-events-in-shadow-characterdata.html: Added.
- fast/events/dom-character-data-modified-textarea-crash.html:
- DOMCharacterDataModified shouldn't be fired in this case. Fixed to allow test to terminate without the event. Note that The event was fired by <textarea>, which is fixed by this change.
- fast/forms/textarea-and-mutation-events-appending-text-expected.txt: Added.
- fast/forms/textarea-and-mutation-events-appending-text.html: Added.
- svg/custom/tref-nested-events-crash.svg:
- DOMCharacterDataModified shouldn't be fired in this case. Fixed to allow test to terminate without the event. Note that The event was fired by SVGShadowText, which is just an implentation detail and should not be exposed.
- 1:09 AM Changeset in webkit [125161] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update TestExpectations for chromium gardening.
https://bugs.webkit.org/show_bug.cgi?id=93589
Mark svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg as slow for Mac10.6 (dbg).
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-09
- platform/chromium/TestExpectations:
- 12:58 AM Changeset in webkit [125160] by
-
- 8 edits in trunk
Use m_everHadLayout in RenderObject::checkForRepaintDuringLayout()
https://bugs.webkit.org/show_bug.cgi?id=20885
Reviewed by Dan Bernstein.
Source/WebCore:
Fix FIXME in checkForRepaintDuringLayout, making RenderObjects
no longer paint on first layout, but instead require their
parent containers to paint them.
This appears to have fixed one minor SVG overpainting issue
in svg/use-detach-expected.png.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::checkForRepaintDuringLayout):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
LayoutTests:
Updated result. Appears to be a progression. I suspect
we were over-drawing the <g> container before and now we're
just drawing the two objects which change.
- platform/chromium-mac/svg/custom/use-detach-expected.png:
- platform/chromium-linux/svg/custom/use-detach-expected.png:
- platform/mac/svg/custom/use-detach-expected.png:
- 12:47 AM Changeset in webkit [125159] by
-
- 4 edits2 adds in trunk
Microdata: PropertyNodeList cache should be invalidated on id attribute change.
https://bugs.webkit.org/show_bug.cgi?id=93485
Reviewed by Ryosuke Niwa.
Source/WebCore:
Invalidate PropertyNodeList cache when id attribute of an element changed/modified.
Test: fast/dom/MicroData/propertiescollection-on-changing-id-attr.html
- dom/DynamicNodeList.cpp: Moved ownerNodeHasItemRefAttribute() method to DynamicNodeList.h
(WebCore):
- dom/DynamicNodeList.h:
(WebCore):
(WebCore::DynamicNodeListCacheBase::isRootedAtDocument): Return true if owner has itemref
attribute specified with root type NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr.
(WebCore::DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange): Return true if
attrName is id attribute in case of InvalidateOnItemAttrChange.
(WebCore::DynamicNodeListCacheBase::ownerNodeHasItemRefAttribute):
LayoutTests:
Added test to verify HTMLPropertiesCollection and PropertyNodeList interfaces
behavior on changing id attribute.
- fast/dom/MicroData/propertiescollection-on-changing-id-attr-expected.txt: Added.
- fast/dom/MicroData/propertiescollection-on-changing-id-attr.html: Added.
- 12:45 AM Changeset in webkit [125158] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, TestExpectations update for a newly added test
https://bugs.webkit.org/show_bug.cgi?id=93586
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-09
- platform/chromium/TestExpectations:
- 12:28 AM Changeset in webkit [125157] by
-
- 4 edits6 adds in trunk
Microdata: HTMLPropertiesCollection does not contain all properties when item is not attached to the DOM tree.
https://bugs.webkit.org/show_bug.cgi?id=93456
Reviewed by Ryosuke Niwa.
Source/WebCore:
HTMLPropertiesCollection does not contain the item properties added through
itemref attribute when item is not attached to the DOM tree. We need to
find the root node of the item if its not attached in the document.
It is also possible that itemref attribute of item refers to the root node.
Made changes in getItemRefElements() method so that the traversal should
start from the root node.
Tests: fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree.html
fast/dom/MicroData/item-not-attached-to-domtree.html
fast/dom/MicroData/itemref-pointing-to-root-node.html
- dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeListCacheBase::rootNode):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::getItemRefElements):
LayoutTests:
Added tests to ensure that HTMLPropertiesCollection contains all item properties
when item is not attached to the DOM tree.
- fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree-expected.txt: Added.
- fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree.html: Added.
- fast/dom/MicroData/item-not-attached-to-domtree-expected.txt: Added.
- fast/dom/MicroData/item-not-attached-to-domtree.html: Added.
- fast/dom/MicroData/itemref-pointing-to-root-node-expected.txt: Added.
- fast/dom/MicroData/itemref-pointing-to-root-node.html: Added.
- 12:26 AM Changeset in webkit [125156] by
-
- 23 edits in trunk/Source
Add optional debug logging for tiled scrolling
https://bugs.webkit.org/show_bug.cgi?id=93305
Reviewed by Simon Fraser.
Add scrolling performance logging to ScrollingTreeNodeMac and WebTileLayer, which will log
the amount of unpainted area exposed during scrolling and painting, respectively.
The logging output looks like this:
SCROLLING: Exposed tileless area. Time: 1344464850.154839 Unfilled Pixels: 1122008
SCROLLING: Filled visible fresh tile. Time: 1344464850.575303 Unfilled Pixels: 1078272
SCROLLING: Filled visible fresh tile. Time: 1344464850.676569 Unfilled Pixels: 823808
SCROLLING: Filled visible fresh tile. Time: 1344464850.795877 Unfilled Pixels: 569344
SCROLLING: Filled visible fresh tile. Time: 1344464850.846940 Unfilled Pixels: 524288
SCROLLING: Filled visible fresh tile. Time: 1344464850.984113 Unfilled Pixels: 262144
SCROLLING: Filled visible fresh tile. Time: 1344464851.027985 Unfilled Pixels: 0
No new tests, as this is just debugging logging.
- WebCore.exp.in:
- page/FrameView.cpp:
(WebCore::FrameView::setScrollingPerformanceLoggingEnabled):
Added setScrollingPerformanceLoggingEnabled, passes flag into TiledBacking.
- page/FrameView.h:
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setScrollingPerformanceLoggingEnabled):
Added setScrollingPerformanceLoggingEnabled, passes flag into FrameView.
- page/Settings.h:
(WebCore::Settings::scrollingPerformanceLoggingEnabled):
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::setScrollingPerformanceLoggingEnabled):
(WebCore::ScrollingTree::scrollingPeformanceLoggingEnabled):
Added ScrollingPerformanceLoggingEnabled setter/getter; this is where it's accessed from ScrollingTreeNodeMac.
- page/scrolling/ScrollingTree.h:
- page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
When updating scroll position, conditionally log the amount of unpainted area that was just exposed.
(WebCore::ScrollingTreeNodeMac::logExposedTilelessArea):
- platform/graphics/TiledBacking.h:
(WebCore::TiledBacking::TiledBacking):
(WebCore::TiledBacking::setScrollingPerformanceLoggingEnabled):
(WebCore::TiledBacking::scrollingPerformanceLoggingEnabled):
Added ScrollingPerformanceLoggingEnabled setter/getter; this is where it's accessed from WebTileLayer.
- platform/graphics/ca/mac/TileCache.h:
(WebCore::TileCache::visibleRect):
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::blankPixelCount):
(WebCore::TileCache::blankPixelCountForTiles):
Compute the exposed, unpainted area of the tile cache by iterating over the layers,
checking if they've been painted, and subtracting painted layers from the total visible area.
- platform/graphics/ca/mac/WebTileLayer.h:
- platform/graphics/ca/mac/WebTileLayer.mm:
(-[WebTileLayer drawInContext:]):
(-[WebTileLayer repaintCount]):
(-[WebTileLayer logFilledFreshTile]):
When painting a WebTileLayer, conditionally log the amount of unpainted area remaining after painting said tile.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
Plumb ScrollingPerformanceLoggingEnabled through to TiledBacking.
Add a new boolean preference, ScrollingPerformanceLoggingEnabled, which will be used to toggle
the WebCore parts of this change.
- Shared/WebPreferencesStore.h: Add ScrollingPerformanceLoggingEnabled.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetScrollingPerformanceLoggingEnabled): Added.
(WKPreferencesGetScrollingPerformanceLoggingEnabled): Added.
- UIProcess/API/C/WKPreferencesPrivate.h: Add getters and setters for ScrollingPerformanceLoggingEnabled.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Add ScrollingPerformanceLoggingEnabled.
(WebKit::WebPage::updatePreferences): Add ScrollingPerformanceLoggingEnabled.
(WebKit::WebPage::setScrollingPerformanceLoggingEnabled): Propagate settings changes through to FrameView.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::scrollingPerformanceLoggingEnabled): Add a getter for the setting so that TiledCoreAnimationDrawingArea can access it.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences): Pass ScrollingPerformanceLoggingEnabled down into the scrolling thread.
