Timeline



Aug 16, 2012:

11:59 PM WikiStart edited by toyoshim@chromium.org
(diff)
11:32 PM Changeset in webkit [125862] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[jhbuild] EFL now runs jhbuild update for every build
https://bugs.webkit.org/show_bug.cgi?id=94267

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2012-08-16
Reviewed by Dirk Pranke.

This change makes EFL's approach to jhbuild more in line with the one
used by WebKitGTK+. update-webkitefl-libs will only be called by build-
webkit if --update-efl is given explicitly. The EWS bot will do that
from now on.

  • Scripts/webkitdirs.pm:

(jhbuildWrapperPrefixIfNeeded): return jhbuild wrapper only if the
Dependencies directory exists also for EFL
(generateBuildSystemFromCMakeProject): no longer run update-webkitefl-libs
(buildCMakeProjectOrExit): build update-webkitefl-libs if --update-efl is
given

  • Scripts/webkitpy/common/config/ports.py:

(EflPort.build_webkit_command): make EWS bots pass --update-efl to build-webkit

  • Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_efl_port): add unit testing for EFL port

11:23 PM Changeset in webkit [125861] by enne@google.com
  • 5 edits in trunk/LayoutTests

[chromium] Rebaseline media-document-audio-repaint after Chromium r151988

Unreviewed gardening.

  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
11:15 PM Changeset in webkit [125860] by vsevik@chromium.org
  • 12 edits
    1 delete in trunk

Web Inspector: Snippet script mapping should not load snippets until workspace reset event is dispatched on scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=94218

Reviewed by Pavel Feldman.

Source/WebCore:

Scripts panel does not load uiSourceCodes in workspace reset handler anymore.
Snippet script mapping does not start reloading snippets after reset until WorkspaceReset event is dispatched.

  • inspector/front-end/JavaScriptSourceFrame.js: Simplified isComittingEditing to be reset synchronously.

(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._reset):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._reset):

  • inspector/front-end/UISourceCodeFrame.js: Simplified isComittingEditing to be reset synchronously.

(WebInspector.UISourceCodeFrame.prototype.commitEditing):
(WebInspector.UISourceCodeFrame.prototype._didEditContent):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/script-snippet-model-expected.txt:
  • inspector/debugger/script-snippet-model.html: added a check that snippet uiSourceCode is correctly recreated after workspace reset.
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • platform/chromium/inspector/debugger/script-snippet-model-expected.txt: Removed.
11:10 PM Changeset in webkit [125859] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Failure to build with --no-inspector
https://bugs.webkit.org/show_bug.cgi?id=94148

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-16
Reviewed by Noam Rosenthal.

Add guards around usage of inspector functions.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::remoteInspectorUrl):

11:02 PM Changeset in webkit [125858] by enne@google.com
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r125829.
http://trac.webkit.org/changeset/125829
https://bugs.webkit.org/show_bug.cgi?id=94299

Maybe causing Chromium AutomationTabHelperBrowserTest failures
(Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-16

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::detachFromParent):

  • loader/FrameLoader.h:

(FrameLoader):

10:51 PM Changeset in webkit [125857] by yosin@chromium.org
  • 2 edits in trunk/LayoutTests

[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=94297

Unreviewed. Temporary disabled time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows

  • platform/chromium/TestExpectations:
10:32 PM Changeset in webkit [125856] by enne@google.com
  • 2 edits
    1 copy in trunk/LayoutTests

Rebaseline overflow-scroll-overlap to pass on both Mac and Chromium

Unreviewed expectation gardening.

  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Copied from LayoutTests/compositing/layer-creation/overflow-scroll-overlap-expected.txt.
10:24 PM Changeset in webkit [125855] by tkent@chromium.org
  • 2 edits in trunk/Source/WTF

Build fix for Chromium-mac.

  • wtf/text/WTFString.cpp: Remove unnecessary includes.
10:21 PM Changeset in webkit [125854] by yosin@chromium.org
  • 3 edits in trunk/LayoutTests

[Tests] Remove redundant text from fast/forms/resources/common-change-type-on-focus.js
https://bugs.webkit.org/show_bug.cgi?id=94293

Reviewed by Kent Tamura.

This patch removes bug number text in description for sharing code
among input types.

  • fast/forms/number/number-change-type-on-focus-expected.txt:
  • fast/forms/resources/common-change-type-on-focus.js:
10:17 PM Changeset in webkit [125853] by thakis@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium/mac] Remove RenderThemeChromiumMac::paintTextField override
https://bugs.webkit.org/show_bug.cgi?id=94276

Reviewed by Eric Seidel.

The comment says this can go once 10.5 goes away. Besides, the
superclass implementation has the same hack anyway.

No behavior change.

  • rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):

  • rendering/RenderThemeChromiumMac.mm:
9:51 PM Changeset in webkit [125852] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

@import url("#foo") causes stack overflow
https://bugs.webkit.org/show_bug.cgi?id=93687

Patch by David Barr <davidbarr@chromium.org> on 2012-08-16
Reviewed by Tony Chang.

Source/WebCore:

Test: http/tests/css/css-imports-url-fragment.html

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet): Ignore the fragment identifier in cycle detection.

LayoutTests:

  • http/tests/css/css-imports-url-fragment-expected.txt: Added.
  • http/tests/css/css-imports-url-fragment.css: Added.
  • http/tests/css/css-imports-url-fragment.html: Added.
9:25 PM Changeset in webkit [125851] by piman@chromium.org
  • 5 edits in trunk/Source

[chromium] Add resource transfer functions to CCResourceProvider
https://bugs.webkit.org/show_bug.cgi?id=93524

Reviewed by James Robinson.

This adds methods to CCResourceProvider to be able to transport
resources from a child to a parent.

Added test to CCResourceProviderTest.

Source/WebCore:

  • platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::inUseByConsumer):
(WebCore::CCResourceProvider::createResource):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::CCResourceProvider):
(WebCore::CCResourceProvider::createChild):
(WebCore):
(WebCore::CCResourceProvider::destroyChild):
(WebCore::CCResourceProvider::getChildToParentMap):
(WebCore::CCResourceProvider::prepareSendToParent):
(WebCore::CCResourceProvider::prepareSendToChild):
(WebCore::CCResourceProvider::receiveFromChild):
(WebCore::CCResourceProvider::receiveFromParent):
(WebCore::CCResourceProvider::transferResource):

  • platform/graphics/chromium/cc/CCResourceProvider.h:

(Mailbox):
(TransferableResource):
(TransferableResourceList):
(CCResourceProvider):
(Resource):
(Child):

Source/WebKit/chromium:

  • tests/CCResourceProviderTest.cpp:

(WebKit::textureSize):
(WebKit):
(WebKit::Texture::Texture):
(Texture):
(ContextSharedData):
(WebKit::ContextSharedData::create):
(WebKit::ContextSharedData::insertSyncPoint):
(WebKit::ContextSharedData::genMailbox):
(WebKit::ContextSharedData::produceTexture):
(WebKit::ContextSharedData::consumeTexture):
(WebKit::ContextSharedData::ContextSharedData):
(WebKit::ResourceProviderContext::create):
(ResourceProviderContext):
(WebKit::ResourceProviderContext::insertSyncPoint):
(WebKit::ResourceProviderContext::waitSyncPoint):
(WebKit::ResourceProviderContext::genMailboxCHROMIUM):
(WebKit::ResourceProviderContext::produceTextureCHROMIUM):
(WebKit::ResourceProviderContext::consumeTextureCHROMIUM):
(WebKit::ResourceProviderContext::ResourceProviderContext):
(PendingProduceTexture):
(WebKit::CCResourceProviderTest::CCResourceProviderTest):
(CCResourceProviderTest):
(WebKit::TEST_F):

9:21 PM Changeset in webkit [125850] by dgrogan@chromium.org
  • 51 edits
    5 copies
    1 add in trunk

IndexedDB: Frontend and plumbing for integer versions
https://bugs.webkit.org/show_bug.cgi?id=92897

Source/WebCore:

Reviewed by Tony Chang.

This patch exposes integer versions and the upgradeneeded event to
script.

The events surrounding an IDBOpenDBRequest follow a new pattern
compared to other idb requests. An open request can receive a blocked
event, an upgradeneeded event, and then a success event. When
dispatching the upgradeneeded and success events the request has its
readyState set to DONE and its result property set to an IDBDatabase.
We usually think of IDBRequests firing one event with one result,
cursors being the big exception. There are some minor changes around
enqueuing and dispatching events to support this.

There's also some funkiness in
IDBRequest::onSuccess(PassRefPtr<IDBDatabaseBackendInterface>) so that
the IDBDatabase object delivered in upgradeneeded is reused for the
success event.

Tests - expectations are updated in this patch.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::onVersionChange):
(WebCore):
(WebCore::IDBDatabase::registerFrontendCallbacks):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseCallbacks.h:

(IDBDatabaseCallbacks):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:

(WebCore::IDBDatabaseCallbacksImpl::onVersionChange):
(WebCore):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.h:

(IDBDatabaseCallbacksImpl):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):
(WebCore):

  • Modules/indexeddb/IDBFactory.h:

(IDBFactory):

  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendInterface.h:

(IDBFactoryBackendInterface):

  • Modules/indexeddb/IDBOpenDBRequest.cpp: Added.

(WebCore):
(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::~IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::interfaceName):
(WebCore::IDBOpenDBRequest::onBlocked):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::shouldEnqueueEvent):

  • Modules/indexeddb/IDBOpenDBRequest.h: Copied from Source/WebCore/Modules/indexeddb/IDBDatabaseCallbacksImpl.h.

(WebCore):
(IDBOpenDBRequest):

  • Modules/indexeddb/IDBOpenDBRequest.idl: Copied from Source/WebCore/Modules/indexeddb/IDBDatabaseCallbacks.h.
  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::shouldEnqueueEvent):
(WebCore::IDBRequest::onSuccess):
This function works with WebIDBCallbacksImpl::onSuccess to reuse its
IDBDatabaseBackendInterface that it got during
IDBOpenDBRequest::onUpgradeNeeded.

(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::transactionDidDispatchCompleteOrAbort):
(WebCore):
(WebCore::IDBRequest::enqueueEvent):

  • Modules/indexeddb/IDBRequest.h:

(WebCore::IDBRequest::onBlocked):
(IDBRequest):

  • Modules/indexeddb/IDBTransaction.cpp:

We now take a pointer to the openDBRequest if this is a version
change transaction as a result of an open-with-version call so that we
can clear the transaction property on the openDBRequest as soon as the
upgradeneeded event is dispatched per the spec ("... set request's
transaction property to null... ", currently 4.8.12).

(WebCore::IDBTransaction::create):
(WebCore):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::setActive):
(WebCore::IDBTransaction::onComplete):
(WebCore::IDBTransaction::dispatchEvent):

  • Modules/indexeddb/IDBTransaction.h:

(WebCore):
(IDBTransaction):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::commit):

  • Modules/indexeddb/IDBUpgradeNeededEvent.cpp: Copied from Source/WebCore/Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp.

(WebCore):
(WebCore::IDBUpgradeNeededEvent::create):
(WebCore::IDBUpgradeNeededEvent::IDBUpgradeNeededEvent):
(WebCore::IDBUpgradeNeededEvent::~IDBUpgradeNeededEvent):
(WebCore::IDBUpgradeNeededEvent::oldVersion):
(WebCore::IDBUpgradeNeededEvent::newVersion):
(WebCore::IDBUpgradeNeededEvent::interfaceName):

  • Modules/indexeddb/IDBUpgradeNeededEvent.h: Copied from Source/WebKit/chromium/src/WebIDBDatabaseCallbacksImpl.h.

(WebCore):
(IDBUpgradeNeededEvent):

  • Modules/indexeddb/IDBUpgradeNeededEvent.idl: Copied from Source/WebCore/Modules/indexeddb/IDBDatabaseCallbacks.h.
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/EventNames.in:
  • dom/EventTargetFactory.in:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onBlocked):
(WebKit):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):

  • src/IDBCallbacksProxy.h:

(IDBCallbacksProxy):

  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::setVersion):

  • src/IDBDatabaseCallbacksProxy.cpp:

(WebKit::IDBDatabaseCallbacksProxy::onVersionChange):
(WebKit):

  • src/IDBDatabaseCallbacksProxy.h:

(IDBDatabaseCallbacksProxy):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::open):

  • src/IDBFactoryBackendProxy.h:

(IDBFactoryBackendProxy):

  • src/IDBTransactionCallbacksProxy.cpp:

(WebKit::IDBTransactionCallbacksProxy::onComplete):

  • src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::WebIDBCallbacksImpl):
(WebKit::WebIDBCallbacksImpl::onSuccess):
We don't want to create IDBDatabaseBackendProxy again if we've already
created it during upgradeNeeded. This makes
IDBRequest::onSuccess(IDBDatabaseBackend) reuse its previous
IDBDatabaseBackendInterface if it has one.

(WebKit::WebIDBCallbacksImpl::onBlocked):
(WebKit):
(WebKit::WebIDBCallbacksImpl::onUpgradeNeeded):

  • src/WebIDBCallbacksImpl.h:

(WebIDBCallbacksImpl):

  • src/WebIDBDatabaseCallbacksImpl.cpp:

(WebKit::WebIDBDatabaseCallbacksImpl::onVersionChange):
(WebKit):

  • src/WebIDBDatabaseCallbacksImpl.h:

(WebIDBDatabaseCallbacksImpl):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
(WebKit::WebIDBDatabaseImpl::close):
(WebKit::WebIDBDatabaseImpl::open):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::open):

  • src/WebIDBFactoryImpl.h:

(WebIDBFactoryImpl):

  • src/WebIDBTransactionCallbacksImpl.cpp:

(WebKit::WebIDBTransactionCallbacksImpl::onComplete):

  • tests/IDBAbortOnCorruptTest.cpp:

(WebCore::TEST):

  • tests/IDBDatabaseBackendTest.cpp:

LayoutTests:

This patch exposes integer versions and the upgradeneeded event to
script so upgradeneeded events are now fired mostly per expectations.
This is the bulk of changes to the expected files, further intversion
patches will change the behavior of a test or two, nothing wholesale.

Reviewed by Tony Chang.

  • storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt:
  • storage/indexeddb/intversion-and-setversion-expected.txt:
  • storage/indexeddb/intversion-blocked-expected.txt:
  • storage/indexeddb/intversion-close-between-events-expected.txt:
  • storage/indexeddb/intversion-close-in-oncomplete-expected.txt:
  • storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
  • storage/indexeddb/intversion-gated-on-delete-expected.txt:
  • storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
  • storage/indexeddb/intversion-long-queue-expected.txt:
  • storage/indexeddb/intversion-open-with-version-expected.txt:
9:10 PM Changeset in webkit [125849] by yosin@chromium.org
  • 4 edits
    17 adds in trunk

[Forms] Cleanup CSS selectors for multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=94287

Reviewed by Kent Tamura.

Source/WebCore:

This patch cleans CSS selectors for multiple fields time input UI:

  • Removed "width" from fields: we use monospace font for field.
  • Use "em" instead of "px" for unit.
  • Add left margin to spin button.

Changes of this patch affect only both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS are enabled.

Tests: fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html

fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html

  • css/html.css:

(input::-webkit-datetime-edit-ampm-field):
(input::-webkit-datetime-edit-hour-field):
(input::-webkit-datetime-edit-millisecond-field):
(input::-webkit-datetime-edit-minute-field):
(input::-webkit-datetime-edit-second-field):
(input[type=time]::-webkit-inner-spin-button):

LayoutTests:

This patch introduces tests for multiple fields time input UI appearance
when both ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
are enabled.

Note: We need to do rebaseline for Chromium-Mac and Chromium-Win.

  • fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.css: Added.
  • fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: Added.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
  • platform/chromium/TestExpectations: Added MISSING entries for Chromium-Mac and Chromium-Win.
8:34 PM Changeset in webkit [125848] by tkent@chromium.org
  • 2 edits in trunk/Tools

Add forms-bugs@chromium.org as a contributor.

  • Scripts/webkitpy/common/config/committers.py:
7:52 PM Changeset in webkit [125847] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix vsync-disabled Null pointer crash bug
https://bugs.webkit.org/show_bug.cgi?id=94280

Patch by John Bates <jbates@google.com> on 2012-08-16
Reviewed by Kentaro Hara.

The m_timeSource member is NULL for vsync-disabled path, need to check for that.

Tests: Covered by Chromium throughput tests. All the compositor thread throughput tests are crashing.

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::setTimebaseAndInterval):

7:44 PM Changeset in webkit [125846] by msaboff@apple.com
  • 9 edits in trunk/Source

HTML Parser should produce 8bit substrings for inline style and script elements
https://bugs.webkit.org/show_bug.cgi?id=93742

Reviewed by Benjamin Poulain.

Source/WebCore:

Currently all data associated with a token is stored and processed as UChars.
Added code to determine that the contents of token data is all 8 bit by keeping
the logical OR value of all prior characters. Also added a flag that the parser
can set to indicate when the token data is converted to a String that we want
to make an 8 bit string if possible. Enabled this handling for script, style,
iframe, noembed, noframes, noscript and xmp tags.

No new tests. Existing tests provide coverage.

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::isAll8BitData):
(HTMLTreeBuilder::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemaining):

  • xml/parser/MarkupTokenBase.h:

(WebCore::MarkupTokenBase::clear):
(WebCore::MarkupTokenBase::appendToCharacter):
(MarkupTokenBase):
(WebCore::MarkupTokenBase::eraseCharacters):
(WebCore::MarkupTokenBase::setConvertTo8Bit):
(WebCore::MarkupTokenBase::isAll8BitData):
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::isAll8BitData):
(AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):

Source/WTF:

Added 8 bit path to String::isAllSpecialCharacters(). Added new String creator
that takes a pointer to a UChar array that is known to contain only 8 bit
characters (LChar's). Added new helper method to copy contents of a
UChar buffer to a LChar buffer. The helper method includes X86-64 intrinsics
of SSE family instructions for performance.

  • wtf/Alignment.h:

(WTF::isAlignedTo):

  • wtf/text/ASCIIFastPath.h:

(WTF::copyLCharsFromUCharSource):

  • wtf/text/WTFString.cpp:

(WTF::String::make8BitFrom16BitSource):

  • wtf/text/WTFString.h:

(String):
(WTF::isAllSpecialCharacters):
(WTF::String::isAllSpecialCharacters):

7:17 PM EFLWebKitCodingStyle edited by gyuyoung.kim@samsung.com
Remove by … (diff)
7:04 PM Changeset in webkit [125845] by Michelangelo De Simone
  • 9 edits in trunk

[Part 3] Parse the custom() function in -webkit-filter: parse the 3d-transforms parameters
https://bugs.webkit.org/show_bug.cgi?id=71443

Reviewed by Dirk Schulze.

Source/WebCore:

custom() now correctly parses the 3d-tranforms parameters. In order to do that the parseTransform() method
has been refactored and split to reuse already present code.

  • css/CSSParser.cpp:

(WebCore::parseTranslateTransformValue): Renamed from parseTransformValue()
(WebCore::CSSParser::parseValue): Reference updated from parseTransformValue() to parseTranslateTransformValue()
(WebCore::CSSParser::parseTransform): This method has been split in two to reuse already present code
(WebCore):
(WebCore::CSSParser::parseTransformValue): New method to parse single transform values
(WebCore::CSSParser::parseCustomFilter): Updated to parse the transform parameters
(WebCore::CSSParser::parseCustomFilterTransform): New method to parse custom() transforms

  • css/CSSParser.h:

LayoutTests:

New round of tests for custom() to assess the correct parsing of the 3d-transform parameters.

  • css3/filters/custom/custom-filter-property-parsing-expected.txt:
  • css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
  • css3/filters/script-tests/custom-filter-property-parsing.js:
  • platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:
6:46 PM Changeset in webkit [125844] by enne@google.com
  • 5 edits in trunk/Source

Unreviewed, rolling out r125838.
http://trac.webkit.org/changeset/125838
https://bugs.webkit.org/show_bug.cgi?id=94283

Breaks Mac compile due to bug 74625 (Requested by enne on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-16

Source/WebCore:

  • platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::inUseByConsumer):
(WebCore::CCResourceProvider::createResource):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::deleteOwnedResources):
(WebCore::CCResourceProvider::CCResourceProvider):

  • platform/graphics/chromium/cc/CCResourceProvider.h:

(CCResourceProvider):
(Resource):

Source/WebKit/chromium:

  • tests/CCResourceProviderTest.cpp:

(WebKit::ResourceProviderContext::create):
(WebKit::ResourceProviderContext::textureSize):
(ResourceProviderContext):
(WebKit::ResourceProviderContext::ResourceProviderContext):
(WebKit::ResourceProviderContext::Texture::Texture):
(Texture):
(WebKit::CCResourceProviderTest::CCResourceProviderTest):
(CCResourceProviderTest):
(WebKit::TEST_F):

6:43 PM Changeset in webkit [125843] by kbr@google.com
  • 13 edits in trunk/Source

Unreviewed, rolling out r125800.
http://trac.webkit.org/changeset/125800
https://bugs.webkit.org/show_bug.cgi?id=84281

Hypothesis that this change caused gpu_throughput_tests to
start timing out on all platforms on the Chromium GPU
canaries.

Source/WebCore:

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:
  • platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateController):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCSchedulerClient):

  • platform/graphics/chromium/cc/CCTextureUpdateController.cpp:

(WebCore::CCTextureUpdateController::maxPartialTextureUpdates):
(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::updateMoreTextures):
(WebCore::CCTextureUpdateController::updateMoreTexturesSize):

  • platform/graphics/chromium/cc/CCTextureUpdateController.h:

(WebCore::CCTextureUpdateController::create):
(CCTextureUpdateController):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

  • tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCTimeSource::FakeCCTimeSource):
(FakeCCTimeSource):

  • tests/CCTextureUpdateControllerTest.cpp:
6:37 PM Changeset in webkit [125842] by enne@google.com
  • 1 edit in branches/chromium/1229/Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp

Merge 125702 - [chromium] Must account for empty transformation lists when checking for big rotations.
https://bugs.webkit.org/show_bug.cgi?id=93975

Reviewed by James Robinson.

Source/WebCore:

AnimationTranslationUtil.cpp is supposed to reject large rotations
(>= 180 degrees between keyframes). The current code assumes that if
the lists of transforms at two consecutive keyframes do not match
(i.e., are different types), then do not need to reject. The rationale
is that we will revert to matrix blending -- we will collapse the lists
of transform operations to matrices at each keyframe and blend those.
Unfortunately, this is not true if a list is empty. It can be the case
that we transition from no transform to a rotation about the z axis of
360 degrees. In this case, the first list of transform operations will
be empty and the second will have a single rotation of 360 degrees. An
empty list should be treated as a rotation of zero degrees.

Unit tested in: GraphicsLayerChromiumTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList

  • platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::causesRotationOfAtLeast180Degrees):

Source/WebKit/chromium:

Adds a test to check that creating an animation with a big (> 180
degree) rotation, where the transform operations list in the 1st
keyframe is empty fails as expected.

  • tests/AnimationTranslationUtilTest.cpp:

(WebKit::TEST):
(WebKit):

TBR=vollick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836307

6:34 PM Changeset in webkit [125841] by kbr@google.com
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r125833.
http://trac.webkit.org/changeset/125833
https://bugs.webkit.org/show_bug.cgi?id=94234

Was not the cause of the test failures. Per
http://crbug.com/143311 , it is probably WebKit r125800.

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::deferredCanvas):
(WebCore):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::skCanvas):

  • platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):

  • platform/graphics/skia/ImageBufferSkia.cpp:
6:31 PM Changeset in webkit [125840] by Lucas Forschler
  • 1 copy in tags/Safari-537.6

New Tag.

6:24 PM Changeset in webkit [125839] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Remove test expectations for fast/overflow/line-clamp-and-columns.html on mac
https://bugs.webkit.org/show_bug.cgi?id=94270

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-16
Reviewed by Brady Eidson.

Unmark fast/overflow/line-clamp-and-columns.html as an expected failure, since
it passes after the fix for https://bugs.webkit.org/show_bug.cgi?id=94080.

  • platform/mac/TestExpectations:
6:16 PM Changeset in webkit [125838] by piman@chromium.org
  • 5 edits in trunk/Source

[chromium] Add resource transfer functions to CCResourceProvider
https://bugs.webkit.org/show_bug.cgi?id=93524

Reviewed by James Robinson.

This adds methods to CCResourceProvider to be able to transport
resources from a child to a parent.

Added test to CCResourceProviderTest.

Source/WebCore:

  • platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::inUseByConsumer):
(WebCore::CCResourceProvider::createResource):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::CCResourceProvider):
(WebCore::CCResourceProvider::createChild):
(WebCore):
(WebCore::CCResourceProvider::destroyChild):
(WebCore::CCResourceProvider::getChildToParentMap):
(WebCore::CCResourceProvider::prepareSendToParent):
(WebCore::CCResourceProvider::prepareSendToChild):
(WebCore::CCResourceProvider::receiveFromChild):
(WebCore::CCResourceProvider::receiveFromParent):
(WebCore::CCResourceProvider::transferResource):

  • platform/graphics/chromium/cc/CCResourceProvider.h:

(Mailbox):
(TransferableResource):
(TransferableResourceList):
(CCResourceProvider):
(Resource):
(Child):

Source/WebKit/chromium:

  • tests/CCResourceProviderTest.cpp:

(WebKit::textureSize):
(WebKit):
(WebKit::Texture::Texture):
(Texture):
(ContextSharedData):
(WebKit::ContextSharedData::create):
(WebKit::ContextSharedData::insertSyncPoint):
(WebKit::ContextSharedData::genMailbox):
(WebKit::ContextSharedData::produceTexture):
(WebKit::ContextSharedData::consumeTexture):
(WebKit::ContextSharedData::ContextSharedData):
(WebKit::ResourceProviderContext::create):
(ResourceProviderContext):
(WebKit::ResourceProviderContext::insertSyncPoint):
(WebKit::ResourceProviderContext::waitSyncPoint):
(WebKit::ResourceProviderContext::genMailboxCHROMIUM):
(WebKit::ResourceProviderContext::produceTextureCHROMIUM):
(WebKit::ResourceProviderContext::consumeTextureCHROMIUM):
(WebKit::ResourceProviderContext::ResourceProviderContext):
(PendingProduceTexture):
(WebKit::CCResourceProviderTest::CCResourceProviderTest):
(CCResourceProviderTest):
(WebKit::TEST_F):

6:06 PM Changeset in webkit [125837] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium-win] Use native digits in a case of "context" substitution setting too.
https://bugs.webkit.org/show_bug.cgi?id=94210

Reviewed by Hajime Morita.

Use native digits in a case of "context" substitution setting, not only
"native" substitution. IE10's input[type=number] always show native
digits even if the system setting is "context". We had better follow
this behavior.

No new tests. This behavior depends on the system locale setting.

  • platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::initializeNumberLocalizerData):
Uses 0-9 only if the substitution setting is "0 to 9". It measn we apply
native digits if the substitution setting is "context" or "native".

6:06 PM Changeset in webkit [125836] by leviw@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed gardening.

r125694 incorrectly updated mac expectations for the below test instead of
Chromium Mac. Moving the updated expectations to Chromium and reverting the
incorrect Mac expectations.

  • platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt: Added.
  • platform/mac/tables/mozilla/bugs/bug55527-expected.txt:
6:03 PM Changeset in webkit [125835] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/forms/file/selected-files-from-history-state.html as failing
https://bugs.webkit.org/show_bug.cgi?id=94278

Unreviewed gardening.

  • platform/chromium/TestExpectations:
5:49 PM Changeset in webkit [125834] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Texmap] Render gif animation well.
https://bugs.webkit.org/show_bug.cgi?id=93458

Patch by Huang Dongsung <luxtella@company100.net> on 2012-08-16
Reviewed by Noam Rosenthal.

GraphicsLayerTextureMapper::setContentsToImage() checks the pointer to the
image, not nativeImagePtr, so Texmap currently draws only the first frame of gif
animations. This patch makes Texmap draw gif animations.

No new tests, could not write a test due to DRT limitation, see Bug 93458.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

5:47 PM Changeset in webkit [125833] by kbr@google.com
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r125804.
http://trac.webkit.org/changeset/125804
https://bugs.webkit.org/show_bug.cgi?id=94234

Made threaded tests in performance_browser_tests start timing
out on Chromium GPU bots

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(WebCore):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::skCanvas):

  • platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):

  • platform/graphics/skia/ImageBufferSkia.cpp:
5:29 PM Changeset in webkit [125832] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Rename DOMWindow::clear to something more descriptive
https://bugs.webkit.org/show_bug.cgi?id=93993

Reviewed by Eric Seidel.

As requested by Eric Seidel. In WebKit, we typically use "clear" to
mean zeroing out a pointer (e.g., OwnPtr::clear). For DOMWindow, it's
more like we're resetting the DOMWindow to a known state (i.e., its
initial state), modulo a wrinkle w.r.t. the PageCache. The new name
attempts to clarify the situation.

  • dom/Document.cpp:

(WebCore::Document::~Document):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::frameDestroyed):
(WebCore::DOMWindow::resetUnlessSuspendedForPageCache):
(WebCore::DOMWindow::resetDOMWindowProperties):

  • page/DOMWindow.h:

(DOMWindow):

5:18 PM Changeset in webkit [125831] by enne@google.com
  • 8 edits
    2 copies in trunk/Source/WebCore

Unreviewed, rolling out r125717.
http://trac.webkit.org/changeset/125717
https://bugs.webkit.org/show_bug.cgi?id=94272

Likely to be causing Chromium Win Debug extensions browser
tests to fail (Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-16

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::mainThreadNormalWorld):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore):
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(DOMWrapperWorld):

  • bindings/v8/IsolatedWorld.cpp: Copied from Source/WebCore/bindings/v8/DOMWrapperWorld.cpp.

(WebCore):
(WebCore::IsolatedWorld::IsolatedWorld):
(WebCore::IsolatedWorld::~IsolatedWorld):

  • bindings/v8/IsolatedWorld.h: Copied from Source/WebCore/bindings/v8/DOMWrapperWorld.h.

(WebCore):
(IsolatedWorld):
(WebCore::IsolatedWorld::create):
(WebCore::IsolatedWorld::count):
(WebCore::IsolatedWorld::id):
(WebCore::IsolatedWorld::domDataStore):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

  • bindings/v8/V8IsolatedContext.h:

(WebCore::V8IsolatedContext::getEntered):
(WebCore::V8IsolatedContext::world):
(V8IsolatedContext):

5:10 PM Changeset in webkit [125830] by thakis@chromium.org
  • 4 edits
    2 deletes in trunk/Source/WebCore

Delete ThemeChromiumMac, use ThemeMac in chromium/mac instead
https://bugs.webkit.org/show_bug.cgi?id=94260

Reviewed by James Robinson.

ThemeChromiumMac was introduced when ThemeMac assumed that an
in-process Cocoa view existed. With WebKit2, that's no longer true,
and the files can now be merged.

No behavior change.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ThemeChromiumMac.h: Removed.
  • platform/chromium/ThemeChromiumMac.mm: Removed.
  • platform/mac/ThemeMac.mm:

(WebCore::paintStepper):
(WebCore::ThemeMac::ensuredView):

5:02 PM Changeset in webkit [125829] by Nate Chapin
  • 3 edits in trunk/Source/WebCore

ProgressTracker never completes if iframe detached during parsing
https://bugs.webkit.org/show_bug.cgi?id=92272

Reviewed by Adam Barth.

Add a simple helper class to FrameLoader to ensure progressStarted/progressCompleted calls are matched,
and balance the calls when the Frame is detached.

No new tests, as this behavior has only been producing reliably by setting a breakpoint in a specific place.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):
(WebCore::FrameLoader::FrameProgressTracker::progressStarted):
(WebCore::FrameLoader::FrameProgressTracker::progressCompleted):
(WebCore::FrameLoader::FrameProgressTracker::~FrameProgressTracker):
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::detachFromParent):

  • loader/FrameLoader.h:

(FrameProgressTracker):
(WebCore::FrameLoader::FrameProgressTracker::create):
(WebCore::FrameLoader::FrameProgressTracker::FrameProgressTracker):

4:53 PM Changeset in webkit [125828] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Update TypedArrays to throw RangeError or similar instead of INDEX_SIZE_ERR
https://bugs.webkit.org/show_bug.cgi?id=45118

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-08-16
Reviewed by Kenneth Russell.

Source/WebCore:

Update TypedArrays to raise JavaScript RangeError instead of dom
INDEX_SIZE_ERR exceptions. Also, update TypedArrays to raise TypeError
instead of JavaScript SyntaxError or dom exceptions SYNTAX_ERR when
calling set method with invalid arguments.

Specification does not define the type of exceptions to raise, but
other browsers raise JavaScript errors, so those changes will improve
compatibility.

New Test: fast/canvas/webgl/array-set-invalid-arguments.html

Updated Tests expectations:

fast/canvas/webgl/array-set-out-of-bounds.html
fast/canvas/webgl/data-view-crash.html
fast/canvas/webgl/data-view-test.html

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore):
(WebCore::setWebGLArrayWithTypedArrayArgument):
(WebCore::setWebGLArrayHelper):
(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore::constructArrayBufferViewWithArrayBufferArgument):
(WebCore::constructArrayBufferView):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore):
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::setWebGLArrayHelper):

LayoutTests:

New test to test invalid arguments to TypedArray set method

Update array-set-out-of-bounds.html, data-view-crash.html and
data-view-test.html test expectations no match new exceptions thrown.

  • fast/canvas/webgl/array-set-invalid-arguments-expected.txt: Added.
  • fast/canvas/webgl/array-set-invalid-arguments.html: Added.
  • fast/canvas/webgl/array-set-out-of-bounds-expected.txt:
  • fast/canvas/webgl/data-view-crash-expected.txt:
  • fast/canvas/webgl/data-view-test-expected.txt:
4:43 PM Changeset in webkit [125827] by commit-queue@webkit.org
  • 28 edits in trunk/Source

[chromium] Replace destRect with destOffset in texture upload
https://bugs.webkit.org/show_bug.cgi?id=94154

Patch by Alexandre Elias <aelias@google.com> on 2012-08-16
Reviewed by James Robinson.

Previously, texture upload code implicitly assumed that sourceRect and
destRect have the same size. The behavior is undefined if they are
different, since they are used interchangeably and there's no support
for scaling from one rect to the other. This patch enforces that
constraint at the interface level by replacing all instances of
"IntRect destRect" by "IntSize destOffset".

Source/WebCore:

No new tests (no-op refactoring).

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(Texture):
(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(FrameBufferSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerTextureSubImage.cpp:

(WebCore::LayerTextureSubImage::upload):
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):

  • platform/graphics/chromium/LayerTextureSubImage.h:

(LayerTextureSubImage):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(Texture):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::updatePart):

  • platform/graphics/chromium/TextureUploader.h:

(Parameters):

  • platform/graphics/chromium/ThrottledTextureUploader.cpp:

(WebCore::ThrottledTextureUploader::uploadTexture):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTileTextures):

  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:

(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):

  • platform/graphics/chromium/cc/CCPrioritizedTexture.cpp:

(WebCore::CCPrioritizedTexture::upload):

  • platform/graphics/chromium/cc/CCPrioritizedTexture.h:

(CCPrioritizedTexture):

  • platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::upload):

  • platform/graphics/chromium/cc/CCResourceProvider.h:

(CCResourceProvider):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::copyPlaneData):

Source/WebKit/chromium:

  • tests/CCResourceProviderTest.cpp:

(WebKit::TEST_F):

  • tests/CCTextureUpdateControllerTest.cpp:
  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::Texture::updateRect):

  • tests/CCTiledLayerTestCommon.h:

(Texture):
(WebKitTests::FakeTextureUploader::uploadTexture):

4:39 PM Changeset in webkit [125826] by kov@webkit.org
  • 2 edits in trunk

Unreviewed speculative 32 bits build fix.

  • Source/autotools/symbols.filter: add symbol version that gets

generated in 32 bits build.

4:35 PM Changeset in webkit [125825] by kov@webkit.org
  • 2 edits in trunk/Tools

Unreviewed warning fix, sys.argv is a python construct.

  • Scripts/update-webkitefl-libs:
4:27 PM Changeset in webkit [125824] by enne@google.com
  • 3 edits
    1 delete in trunk/LayoutTests

Remove text output from overflow-hidden-canvas-layer test
https://bugs.webkit.org/show_bug.cgi?id=94050

Unreviewed gardening.

This was added in r125758 and doesn't need a text dump.

  • compositing/overflow/overflow-hidden-canvas-layer-expected.txt:
  • compositing/overflow/overflow-hidden-canvas-layer.html:
  • platform/chromium-linux/compositing/overflow/overflow-hidden-canvas-layer-expected.txt: Removed.
4:17 PM Changeset in webkit [125823] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Structure check hoisting should be less expensive
https://bugs.webkit.org/show_bug.cgi?id=94201

Reviewed by Mark Hahnenberg.

This appears like a broad win on short-running programs.

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::compareAndSwap):
(Graph):
(JSC::DFG::Graph::substitute):
(JSC::DFG::Graph::substituteGetLocal):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

4:11 PM Changeset in webkit [125822] by jamesr@google.com
  • 7 edits in trunk/Source

[chromium] Remove unnecessary tree hierarchy inspection APIs from WebLayer
https://bugs.webkit.org/show_bug.cgi?id=94229

Reviewed by Adrienne Walker.

Source/Platform:

As it turns out, these APIs are needed. Without them, there is no way to re-wrap an existing layer so we can
know that when all WebLayer wrappers of a given layer go away that layer will never be exposed to the public API
again and run appropriate cleanup code.

  • chromium/public/WebLayer.h:

(WebLayer):

Source/WebCore:

Tweak updateLayerPreserves3D() logic to use the existing GraphicsLayer tree hierarchy instead of pulling the
hierarchy off of WebLayer.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

Source/WebKit/chromium:

Remove dead WebLayer function implementations and tests of same.

  • src/WebLayer.cpp:
  • tests/WebLayerTest.cpp:
4:07 PM Changeset in webkit [125821] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

4:04 PM Changeset in webkit [125820] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.7

New Tag.

3:50 PM Changeset in webkit [125819] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark http/tests/inspector/indexeddb/resources-panel.html as debug crasher
https://bugs.webkit.org/show_bug.cgi?id=94261

Unreviewed gardening.

  • platform/chromium/TestExpectations:
3:48 PM Changeset in webkit [125818] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Let XCode have its own way.

  • WebCore.xcodeproj/project.pbxproj:
3:44 PM Changeset in webkit [125817] by commit-queue@webkit.org
  • 4 edits in trunk

Refactor CSPDirective to support non-sourcelist types.
https://bugs.webkit.org/show_bug.cgi?id=94252

Patch by Mike West <mkwst@chromium.org> on 2012-08-16
Reviewed by Adam Barth.

Source/WebCore:

The 'CSPDirective' was built to support source list Content Security
Policy directives like 'script-src' or 'object-src'. It doesn't support
new directive types like 'script-nonce' or 'plugin-types'. That
functionality has been implemented by hanging state off of
CSPDirectiveList, which isn't a great solution.

This patch pulls the source list functionality out of CSPDirective and
into SourceListDirective, and likewise pulls the nonce and media list
functionality into NonceDirective and MediaListDirective.

No new tests have been added; this refactoring should be externally
transparent, and the current CSP tests should continue to pass.

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirective::CSPDirective):
(CSPDirective):
(WebCore::CSPDirective::text):
(WebCore::CSPDirective::policy):

CSPDirective is now a parent class for NonceDirective,
MediaListDirective, and SourceListDirective. It stores a pointer
to the ContentSecurityPolicy object in order to facilitate logging,
which now needs to happen at this level, rather than higher up in
CSPDirectiveList.

(WebCore):
(NonceDirective):
(WebCore::NonceDirective::NonceDirective):
(WebCore::NonceDirective::allows):
(WebCore::NonceDirective::parse):

Pull the nonce parsing code and state out of CSPDirectiveList
and into this new class.

(MediaListDirective):
(WebCore::MediaListDirective::MediaListDirective):
(WebCore::MediaListDirective::allows):
(WebCore::MediaListDirective::parse):

Pull the media list parsing code and state out of CSPDirectiveList
and into this new class.

(SourceListDirective):
(WebCore::SourceListDirective::SourceListDirective):
(WebCore::SourceListDirective::allows):

Pull the source list functionality out of CSPDirective
and into this new class.

(CSPDirectiveList):
(WebCore::CSPDirectiveList::checkEval):
(WebCore::CSPDirectiveList::checkInline):
(WebCore::CSPDirectiveList::checkNonce):
(WebCore::CSPDirectiveList::checkSource):
(WebCore::CSPDirectiveList::checkMediaType):
(WebCore::CSPDirectiveList::operativeDirective):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkNonceAndReportViolation):
(WebCore::CSPDirectiveList::checkMediaTypeAndReportViolation):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowScriptNonce):
(WebCore::CSPDirectiveList::allowPluginType):
(WebCore::CSPDirectiveList::setCSPDirective):
(WebCore::CSPDirectiveList::addDirective):

Use the new classes rather than CSPDirective (or no directive
at all, in the case of nonces and plugin types).

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce-expected.txt:

This test was buggy. Now it writes out the full directive text as it
ought to.

3:42 PM Changeset in webkit [125816] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Update test expectations for fast/overflow/line-clamp-and-columns.html on mac
https://bugs.webkit.org/show_bug.cgi?id=94251

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-16
Reviewed by Brady Eidson.

Mark layout test fast/overflow/line-clamp-and-columns.html as an expected failure
on mac until https://bugs.webkit.org/show_bug.cgi?id=94080 is fixed.

  • platform/mac/TestExpectations:
3:29 PM Changeset in webkit [125815] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Null checks of m_frame->document()->domWindow() aren't needed
https://bugs.webkit.org/show_bug.cgi?id=94052

Reviewed by Eric Seidel.

If a document is attached to a frame, then its DOMWindow is necessarily
non-0. Checking for 0 is needless.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::checkLoadComplete):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::prepareForCachedPageRestore):

3:18 PM Changeset in webkit [125814] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Update expectations.

  • platform/chromium/TestExpectations:
3:01 PM Changeset in webkit [125813] by ojan@chromium.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

Fix test added in r125635. The test failed on non-chromium ports due
to the column sizing 1px differently. I'm not really sure what was going on,
but this was a fix for a crash anyways. Just marking the test dumpAsText.

  • fast/overflow/line-clamp-and-columns-expected.html: Removed.
  • fast/overflow/line-clamp-and-columns-expected.txt: Added.
  • fast/overflow/line-clamp-and-columns.html:
2:45 PM Changeset in webkit [125812] by dpranke@chromium.org
  • 14 edits in trunk/Tools

NRWT cutting off the output from LayoutTest run under Valgrind
https://bugs.webkit.org/show_bug.cgi?id=94011

Reviewed by Ojan Vafai.

Make NRWT work with valgrind again ... I needed to rework the
driver infrastructure so that we could get the stderr written
between a test completing and a process being stopped and
associate it with the DriverOutput for the test; this meant that
run_test() needed to stop the driver at the end of the test
directly if/when appropriate. This also entailed reworking
run_test() so that we would gather stderr and stdout
consistently regardless of whether this was a normal test, or
stop_when_done, or a crash or timeout.

Also, I had to rework the process_stop_time() (and renamed it to
driver_stop_timeout) so that it would be longer if --time-out-ms
was long as well (so that valgrind would get enough time to
run), and I reworked driver.stop(kill_directly=True) to just
driver.stop(timeout=0.0).

Lastly, adding the new stop_when_done parameter entailed
touching a lot of test mock functions :(.

This change appeared to be well-covered by existing tests.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(Worker._run_test):
(Worker._run_test_with_timeout):
(Worker._run_test_in_another_thread):
(Worker._run_test_in_another_thread.SingleTestThread.run):
(Worker._run_test_in_this_thread):
(Worker._run_single_test):

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(run_single_test):
(SingleTestRunner.init):
(SingleTestRunner._run_compare_test):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._run_reftest):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.driver_stop_timeout):
(Port.variable.default_configuration):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.driver_stop_timeout):
(ChromiumAndroidDriver.stop):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test):
(Driver.stop):
(DriverProxy.run_test):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.write):
(ServerProcess._wait_for_data_and_update_buffers_using_select):
(ServerProcess.stop):
(ServerProcess.kill):
(ServerProcess):
(ServerProcess._kill):

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.init):
(MockProc.wait):
(TestServerProcess.test_basic):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestDriver.run_test):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(get_tests_run.RecordingTestDriver.run_test):

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest.run_single):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPageLoadingPerfTest.MockDriver.run_test):
(TestReplayPerfTest.ReplayTestPort.init.ReplayTestDriver.run_test):
(TestReplayPerfTest.test_run_single.run_test):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
(TestReplayPerfTest.test_prepare.run_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.TestDriver.run_test):

1:54 PM Changeset in webkit [125811] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

[BlackBerry] Some media controls are mispositioned for dynamic live streams (HLS)
https://bugs.webkit.org/show_bug.cgi?id=94176

Patch by Max Feil <mfeil@rim.com> on 2012-08-16
Reviewed by Antonio Gomes.

.:

An automated layout test is not possible for this patch because
dynamic live streams require a special dedicated web server.
Putting an external video URL into an automated test is not
correct either. So I have created a manual test that points to
an external HLS video that works today.

  • ManualTests/blackberry/video-hls-controls.html: Added.

Source/WebCore:

The default HTML5 media controls for dynamic live streams have
no timeline or timeline container, which for BlackBerry results
in mispositioning of the buttons that are supposed to be to
the right of the timeline (fullscreen and mute). Instead of
being right justified they incorrectly appear on the left next
to the play button. The fix is to explicitly position these 2
buttons whenever the media duration is infinite (indicating a
live stream).

Manual test: ManualTests/blackberry/video-hls-controls.html

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):

1:50 PM Changeset in webkit [125810] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Regression(r118248): Replaced element not layout
https://bugs.webkit.org/show_bug.cgi?id=85804

Reviewed by Levi Weintraub.

Source/WebCore:

r118248 moved the layout call of replaced elements to nextLineBreak.
This was intended to delay the layout after all the lineboxes are cleared
in RenderBlock::layoutInlineChildren. However, this caused the end line
object to not layout at all. We revert to the old planned way to just
keep a local vector of replaced elements to layout and then layout all of them
after the lineboxes are cleared.

Test: fast/replaced/replaced-last-line-layout.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

  • fast/replaced/replaced-last-line-layout-expected.html: Added.
  • fast/replaced/replaced-last-line-layout.html: Added.
1:48 PM Changeset in webkit [125809] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Do not perform 8 to 16bits characters conversion when converting a WTFString to NSString/CFString
https://bugs.webkit.org/show_bug.cgi?id=90720

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-16
Reviewed by Geoffrey Garen.

In most String to CFString conversion, we should be able to use the "NoCopy" constructor and have
a relatively cheap conversion from WTF::String to CFString.

When the String is 8 bits, it was converted to 16 bits by getData16SlowCase() because of the call
to String::characters().

This patch adds a path for creating a CFString from a 8bits string using CFStringCreateWithBytes.

This is covered by existing tests.

  • platform/text/cf/StringCF.cpp:

(WTF::String::createCFString): CFSTR() create static CFString, it is unecessary to retain it.

  • platform/text/cf/StringImplCF.cpp:

(WTF::StringImpl::createCFString): The logic to avoid the StringWrapperCFAllocator has also been simplified.
The allocator creation is now closer to where it is useful.

The function CFStringCreateWithBytesNoCopy() does not necessarilly allocate a new string, it can reuse
existing strings. In those cases, the allocator is not used. For that reason, the assertion regarding
currentString is moved to the branch that always allocate new strings.

1:47 PM Changeset in webkit [125808] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use form state to determine the VKB enter key.
https://bugs.webkit.org/show_bug.cgi?id=94239

Reviewed by Rob Buis.

PR 188234.

If the enter key for the VKB is not explicitly set, use
submit if we are in a single line input and a default
button exists for the form.

Reviewed Internally by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementFocused):

1:44 PM Changeset in webkit [125807] by abarth@webkit.org
  • 21 edits
    1 move
    4 deletes in trunk

DirectoryEntry should use Dictionary rather than custom bindings code
https://bugs.webkit.org/show_bug.cgi?id=94207

Reviewed by Eric Seidel.

Source/WebCore:

Since this code was written, we added native support for WebIDL
Dictionary objects. This patch moves DirectoryEntry to use this
automatic facility instead of custom code.

I've also renamed and simplified WebKitFlags. This is possible because
this object was no longer exposed via IDL (even before to this patch).

  • GNUmakefile.list.am:
  • Modules/filesystem/DOMFileSystemBase.cpp:

(WebCore::DOMFileSystemBase::getFile):
(WebCore::DOMFileSystemBase::getDirectory):

  • Modules/filesystem/DOMFileSystemBase.h:

(DOMFileSystemBase):

  • Modules/filesystem/DirectoryEntry.cpp:

(WebCore::DirectoryEntry::getFile):
(WebCore::DirectoryEntry::getDirectory):

  • Modules/filesystem/DirectoryEntry.h:

(DirectoryEntry):

  • Modules/filesystem/DirectoryEntry.idl:
  • Modules/filesystem/DirectoryEntrySync.cpp:

(WebCore::DirectoryEntrySync::getFile):
(WebCore::DirectoryEntrySync::getDirectory):

  • Modules/filesystem/DirectoryEntrySync.h:

(DirectoryEntrySync):

  • Modules/filesystem/DirectoryEntrySync.idl:
  • Modules/filesystem/FileSystemCallbacks.cpp:

(WebCore):
(WebCore::ResolveURICallbacks::didOpenFileSystem):

  • Modules/filesystem/FileSystemFlags.h: Renamed from Source/WebCore/Modules/filesystem/WebKitFlags.h.

(WebCore):
(WebCore::FileSystemFlags::FileSystemFlags):
(FileSystemFlags):

  • Modules/filesystem/WorkerContextFileSystem.cpp:

(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemSyncURL):

  • Target.pri:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDirectoryEntryCustom.cpp: Removed.
  • bindings/js/JSDirectoryEntrySyncCustom.cpp: Removed.
  • bindings/v8/custom/V8DirectoryEntryCustom.cpp: Removed.
  • bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp: Removed.

LayoutTests:

This patch changes our behavior slightly in that passing a non-object
as a flags Dictionary throws an exception rather than being treated as
an empty dictionary. This new behavior matches the WebIDL spec and
hopefully won't cause compat problems.

  • fast/filesystem/flags-passing-expected.txt:
  • fast/filesystem/script-tests/flags-passing.js:

(runNullTest):
(runNonObjectTest):

1:35 PM Changeset in webkit [125806] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

All op_resolve_global instructions should end up in the list of global resolve instructions
https://bugs.webkit.org/show_bug.cgi?id=94247
<rdar://problem/12103500>

Reviewed by Mark Hahnenberg.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolveWithBase):

1:30 PM Changeset in webkit [125805] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Remove StyleSheetContents::m_finalURL
https://bugs.webkit.org/show_bug.cgi?id=94140

Reviewed by Andreas Kling.

It is equal (or empty in case of inline stylesheets) to the baseURL passed in CSSParserContext.
Removing it simplifies the constructors and the related code.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::createInline):
(WebCore::CSSStyleSheet::canAccessRules):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::cssRules):

  • factor access check to a function
  • allow document always access rules of its inline stylesheets
  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::StyleSheetContents):
(WebCore::StyleSheetContents::parseAuthorStyleSheet):

  • css/StyleSheetContents.h:

(WebCore::StyleSheetContents::create):
(WebCore::StyleSheetContents::originalURL):
(StyleSheetContents):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::setCSSStyleSheet):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::styleSheetURL):

  • xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::loadSheet):

1:11 PM Changeset in webkit [125804] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Chromium] Changing Canvas2DLayerBridge to use SkDeferredCanvas's notification client API
https://bugs.webkit.org/show_bug.cgi?id=94234

Patch by Justin Novosad <junov@chromium.org> on 2012-08-16
Reviewed by James Robinson.

The existing DeviceContext API in skia's SkDeferredCanvas is being
deprecated in favor of the new NotificationClient interface, which is
designed to allow WebKit to control deferred canvas global memory
consumption.

No new tests: this patch does not fix any bug and does not add new
functionality. It is just a transition to a new skia interface.
Coverage is assured by existing tests.

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore):
Removed the AcceleratedDeviceContext class completely and mixed it
into Canvas2DLayerBridge by inheriting
SkDeferredCanvas::NotificationClient
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::deferredCanvas):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::skCanvas):

  • platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):

  • platform/graphics/skia/ImageBufferSkia.cpp:

Cleaning up unnecessary include of SkDeferredCanvas.h

12:55 PM Changeset in webkit [125803] by kpiascik@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Reload valid page from Error Page keeps history ViewState and zoom.
https://bugs.webkit.org/show_bug.cgi?id=94123

Reviewed by Antonio Gomes.

Reviewed internally by Leo Yang, Jacky Jiang.
PR 178305

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):Reset the scales and
the user scalable flag if we're reloading from an error page.
(BlackBerry::WebKit::WebPagePrivate::updateViewportSize): Don't update the
viewport size if we're still in the WebPagePrivate::init method.
(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
Properly set the shouldZoom flag if we're not going to restore the
view state.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad): Set the
ViewState's shouldSaveViewState flag if we're coming from an error page.
(WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem): Set the
new member variable m_shouldRestoreViewState based on the ViewState's
shouldSaveViewState flag.
(WebCore::FrameLoaderClientBlackBerry::restoreViewState): Added early
return if m_shouldRestoreViewState is false.

  • WebCoreSupport/FrameLoaderClientBlackBerry.h: Add new method to have

the client track whether we should restore the view state.
(WebCore::FrameLoaderClientBlackBerry::shouldRestoreViewState):
(FrameLoaderClientBlackBerry):

12:54 PM Changeset in webkit [125802] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Chromium] Avoid aliasing global symbol monotonicallyIncreasingTime().
https://bugs.webkit.org/show_bug.cgi?id=94233

Patch by David Reveman <reveman@chromium.org> on 2012-08-16
Reviewed by James Robinson.

Source/WebCore:

Rename virtual function CCDelayBasedTimeSource::monotonicallyIncreasingTime()
that exist for testing purposes to CCDelayBasedTimeSource::monotonicTimeNow().

No new tests.

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:

(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::onTimerFired):
(WebCore::CCDelayBasedTimeSource::monotonicTimeNow):

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:

Source/WebKit/chromium:

  • tests/CCDelayBasedTimeSourceTest.cpp:

(WebKitTests::TEST):

  • tests/CCFrameRateControllerTest.cpp:

(WebKitTests::TEST):

  • tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicTimeNow):
(WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource):
(FakeCCDelayBasedTimeSource):

12:50 PM Changeset in webkit [125801] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Typo in old-run-webkit-tests script from https://bugs.webkit.org/show_bug.cgi?id=93904.
https://bugs.webkit.org/show_bug.cgi?id=94228

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-16
Reviewed by Tim Horton.

I previously made the change but made a typo that causes the script not ignore mismatch ref tests.

  • Scripts/old-run-webkit-tests:

(isUsedInReftest):

12:42 PM Changeset in webkit [125800] by commit-queue@webkit.org
  • 13 edits in trunk/Source

[Chromium] Schedule texture uploads based on hard-coded timer and vsync.
https://bugs.webkit.org/show_bug.cgi?id=84281

Patch by David Reveman <reveman@chromium.org> on 2012-08-16
Reviewed by James Robinson.

Source/WebCore:

Improve interaction between vsync and texture uploads by performing
uploads in smaller batches and use a hard-coded timer to emulate
upload completion. This greatly reduces the chance of the compositor
missing a vsync due to being busy with texture uploads.

The CCScheduler client is now given a time limit when told to update
more resources. This time limit is passed to an instance of the
CCTextureUpdateController class, which is responsible for performing
texture updates until the limit is reached.

Unit tests: CCSchedulerTest.RequestCommit

CCTextureUpdateControllerTest.UpdateMoreTextures
CCTextureUpdateControllerTest.HasMoreUpdates

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::nextTickTime):
(WebCore):

  • platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateController):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCSchedulerClient):

  • platform/graphics/chromium/cc/CCTextureUpdateController.cpp:

(WebCore::CCTextureUpdateController::maxPartialTextureUpdates):
(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::updateMoreTextures):
(WebCore):
(WebCore::CCTextureUpdateController::onTimerFired):
(WebCore::CCTextureUpdateController::monotonicTimeNow):
(WebCore::CCTextureUpdateController::updateMoreTexturesTime):
(WebCore::CCTextureUpdateController::updateMoreTexturesSize):
(WebCore::CCTextureUpdateController::updateMoreTexturesIfEnoughTimeRemaining):
(WebCore::CCTextureUpdateController::updateMoreTexturesNow):

  • platform/graphics/chromium/cc/CCTextureUpdateController.h:

(WebCore::CCTextureUpdateController::create):
(CCTextureUpdateController):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

  • tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCTimeSource::FakeCCTimeSource):
(WebKitTests::FakeCCTimeSource::setNextTickTime):
(FakeCCTimeSource):

  • tests/CCTextureUpdateControllerTest.cpp:
12:35 PM Changeset in webkit [125799] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Impl scrolling crashes when the renderer's initialization failed
https://bugs.webkit.org/show_bug.cgi?id=94232

Reviewed by James Robinson.

Source/WebCore:

CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be
called when there is no renderer present or it will crash.

Chromium bug: crbug.com/125482

Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):

Source/WebKit/chromium:

Also updated the finishAllRenderingAfterContextLost to properly fail
renderer initialization.

  • tests/CCLayerTreeHostImplTest.cpp:
12:31 PM Changeset in webkit [125798] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html fails (results weren't updated in r125772)
https://bugs.webkit.org/show_bug.cgi?id=94236

Unreviewed (test gardening)

  • http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Update results here, like the rest of 125772 did.
12:28 PM Changeset in webkit [125797] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Use initialization from literals for StringStatics
https://bugs.webkit.org/show_bug.cgi?id=94185

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-16
Reviewed by Geoffrey Garen.

  • wtf/text/StringStatics.cpp:

Remove the arguments for DEFINE_GLOBAL. They are no longer used by the macro.
(WTF::AtomicString::init):
Use ConstructFromLiteral to initialize the strings faster and to save memory.

11:46 AM Changeset in webkit [125796] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove Mobile mode from WebPage.cpp and WebPage_p.h
https://bugs.webkit.org/show_bug.cgi?id=94223
PR #192773

Patch by Leo Yang <leoyang@rim.com> on 2012-08-16
Reviewed by Rob Buis.
Reviewed internally by Arvid Nilsson.

Remove Mobile mode as it's not been used. Also remove code that
handle top-level SVG document because now we can handle it in Desktop mode.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):

  • Api/WebPage_p.h:
11:23 AM Companies and Organizations that have contributed to WebKit edited by Bruno de Oliveira Abinader
Adding basyKom work. (diff)
11:07 AM Changeset in webkit [125795] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] SurfacePool::waitForBuffer() sometimes waits for deleted EGLSyncKHR object
https://bugs.webkit.org/show_bug.cgi?id=94208

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-16
Reviewed by Rob Buis.

SurfacePool::notifyBuffersComposited() adds a tile's previous
sync object to the garbage list before replacing it with a new one.
However, it failed to thoroughly clear all tiles that were referencing
the old sync object.

Thus it could happen that if a set of tiles A was composited, then
another set of tiles B was composited, only the intersection of A and B
was cleared of the soon-to-be-deleted sync object, and the subtraction
A - B would reference an invalid sync object in case the BackingStore
decided to render to one of the tiles in A - B before they were
composited again.

Fixed by storing each individual sync object in only one place so we
don't have to rummage through all tiles and remove stale references to
sync objects that are about to be destroyed.

A new reference counted Fence class is added for this purpose, to store
a sync object. Tiles refer to Fence instances instead of holding a sync
object directly. Since Fence is reference counted, several tiles can
refer to the same Fence instance, and clearing its sync object will
instantly remove it from the grasp of all tiles that depend on that
Fence.

Since there's no point in waiting for the same Fence twice, the only
operation provided on Fence is takePlatformSync() which returns the
sync object and clears the Fence of its sync object.

Reviewed internally by Filip Spacek.

PR 193610

  • WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::TileBuffer::TileBuffer):

  • WebKitSupport/BackingStoreTile.h:

(BlackBerry):
(Fence):
(BlackBerry::Fence::create):
(BlackBerry::Fence::takePlatformSync):
(BlackBerry::Fence::Fence):
(BlackBerry::WebKit::TileBuffer::fence):
(BlackBerry::WebKit::TileBuffer::setFence):
(TileBuffer):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::waitForBuffer):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):

  • WebKitSupport/SurfacePool.h:

(SurfacePool):

11:00 AM Changeset in webkit [125794] by leviw@chromium.org
  • 47 edits
    4 adds in trunk

Accumulate sub-pixel offsets through layers and transforms
https://bugs.webkit.org/show_bug.cgi?id=89238

Reviewed by Eric Seidel.

Source/WebCore:

Pixel snapping logic makes use of sub-pixel offsets accumulated when walking down
the render tree. When we align RenderLayers to paint on pixel boundaries, we were
also losing that accumulated value. This preserves the fractional offset and passes
it to the RenderLayer's RenderObjects so they paint the proper size and offset.

This also necessitates a new mode of mapLocalToContainer whereby we pixel snap the
offset used in transforms. Otherwise, they wouldn't account for the pixel snapping
done elsewhere in the render tree.

Test: fast/sub-pixel/sub-pixel-accumulates-to-layers.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::pixelSnappedSizingBox): The LayoutUnit version of sizingBox returns a
LayoutRect with the location zeroed out. This leads to incorrect pixel snapping, so
we shouldn't put these numbers into a transform. Sadly, I couldn't figure out a
test for this without the rest of the patch.
(WebCore):
(WebCore::computedTransform): Using pixel-snapped values when generating transforms.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer): Adding a mode whereby the values inputed
into the transform are properly pixel snapped.
(WebCore::RenderBox::computeRectForRepaint): Using pixel snapped values for the transform.

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::mapToAbsolute):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateTransform): Using pixel snapped values for the transform.
(WebCore::RenderLayer::currentTransform): Ditto.
(WebCore::RenderLayer::perspectiveTransform): Ditto.
(WebCore::RenderLayer::paint): Support passing along the accumulated sub-pixel offset instead
of rounding and use enclosingIntRect for the damageRect.
(WebCore::RenderLayer::paintOverlayScrollbars): Updating to the new paintLayer contract
(WebCore::RenderLayer::paintLayer): Adding a sub-pixel accumulation LayoutSize. We pass this
delta to the Layer's RenderObject when we paint, but align the graphics context to the proper
pixel value.
(WebCore::RenderLayer::paintLayerContentsAndReflection): Ditto.
(WebCore::RenderLayer::paintLayerContents): Ditto.
(WebCore::RenderLayer::paintList): Ditto.
(WebCore::RenderLayer::paintChildLayerIntoColumns): Ditto.
(WebCore::RenderLayer::calculateClipRects): Avoid unnecessary rounding when sub-pixel is enabled.
(WebCore::RenderLayer::calculateRects): Remove unnecessary pixel snapping.

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateLayerTransform): Use pixel-snapped values for transforms.
(WebCore::RenderLayerBacking::paintIntoLayer): Update to new paintLayer contract.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::localToContainerQuad): Adding a mode for optionally pixel snapping.
(WebCore::RenderObject::localToContainerPoint): Ditto.

  • rendering/RenderObject.h:

(WebCore::RenderObject::localToAbsoluteQuad): Ditto.
(RenderObject):

  • rendering/RenderReplica.cpp:

(WebCore::RenderReplica::paint): Updating to new paintLayer contract.

  • rendering/RenderView.h:

(RenderView):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::mapLocalToContainer):

  • rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::mapLocalToContainer):

  • rendering/svg/RenderSVGInline.h:

(RenderSVGInline):

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::mapLocalToContainer):

  • rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::mapLocalToContainer):

  • rendering/svg/RenderSVGText.h:

(RenderSVGText):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer):

  • rendering/svg/SVGRenderSupport.h:

(SVGRenderSupport):

LayoutTests:

  • fast/sub-pixel/sub-pixel-accumulates-to-layers.html: Added.
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
  • platform/chromium-mac/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
  • platform/chromium-mac/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Added.
  • platform/chromium-mac/fast/transforms/transformed-document-element-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/svg/transforms/svg-css-transforms-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
10:47 AM Changeset in webkit [125793] by annacc@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test media/track/track-active-cues.html frequently times out on Windows.
https://bugs.webkit.org/show_bug.cgi?id=81402

Reviewed by Eric Carlson.

This patch changes the test to use captions-fast.vtt to see if several cuechange
events available at different times helps the test not timeout.

  • media/track/track-active-cues.html:
10:45 AM Changeset in webkit [125792] by peter@chromium.org
  • 5 edits in trunk

[Chromium] Pass the --strip-binary argument to the apk test generator
https://bugs.webkit.org/show_bug.cgi?id=94224

Reviewed by Adam Barth.

The native test generator currently relies on the $STRIP environment
variable to be available, which it shouldn't do. Instead, pass it as an
argument to the script. The $STRIP variable is being deprecated.

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
10:33 AM Changeset in webkit [125791] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Bad utf8 data is being passed to enchant_dict_check
https://bugs.webkit.org/show_bug.cgi?id=94202

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-08-16
Reviewed by Martin Robinson.

Pass the number of bytes instead of the number of UTF8 characters
when calling enchant_dict_check.

  • platform/text/gtk/TextCheckerEnchant.cpp:

(TextCheckerEnchant::checkSpellingOfString): Use 'bytes' instead
of 'wordLength'.

10:22 AM Changeset in webkit [125790] by commit-queue@webkit.org
  • 9 edits
    9 adds in trunk

Web Inspector: added Paint events for Images to TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90277

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-08-16
Reviewed by Pavel Feldman.

Source/WebCore:

  • add DecodeImage & ResizeImage timeline events;
  • implement {will,did}DecodeImage and {will,did}ResizeImage methods of Timeline agent;

Test: inspector/timeline/timeline-decode-resize.html

  • English.lproj/localizedStrings.js:
  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore::InspectorTimelineAgent::willDecodeImage):
(WebCore::InspectorTimelineAgent::didDecodeImage):
(WebCore::InspectorTimelineAgent::willResizeImage):
(WebCore::InspectorTimelineAgent::didResizeImage):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createDecodeImageData):
(WebCore):
(WebCore::TimelineRecordFactory::createResizeImageData):

  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

  • inspector/front-end/TimelineModel.js:
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.initRecordStyles_):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):

LayoutTests:

Added a test and fixed enum-stabitily because of a new Timeline Event.

  • inspector/timeline/resources/big.png: Added.
  • inspector/timeline/resources/test.bmp: Added.
  • inspector/timeline/resources/test.gif: Added.
  • inspector/timeline/resources/test.ico: Added.
  • inspector/timeline/resources/test.jpg: Added.
  • inspector/timeline/resources/test.png: Added.
  • inspector/timeline/resources/test.webp: Added.
  • inspector/timeline/timeline-decode-resize-expected.txt: Added.
  • inspector/timeline/timeline-decode-resize.html: Added.
  • inspector/timeline/timeline-enum-stability-expected.txt:
10:20 AM Changeset in webkit [125789] by enne@google.com
  • 4 edits
    1 delete in trunk/LayoutTests

Make compositing/layer-creation/overflow-scroll-overlap non-flaky
https://bugs.webkit.org/show_bug.cgi?id=94162

Reviewed by James Robinson.

This test has been failing flakily in Chromium with the scrollbar
layer sometimes being composited and sometimes not. This is likely due
to the video flakily being accelerated depending on whether it has
loaded or not.

Fix this test by making it always have a vertical scrollbar and remove
the video with an always-composited div.

  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap.html:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
10:16 AM Changeset in webkit [125788] by jamesr@google.com
  • 8 edits in trunk/Source

[chromium] Remove alwaysReserveTextures code - it doesn't do anything
https://bugs.webkit.org/show_bug.cgi?id=94183

Reviewed by Dimitri Glazkov.

Source/Platform:

Remove deprecated setAlwaysReserveTextures() call from WebLayer.

  • chromium/public/WebLayer.h:

(WebLayer):

Source/WebCore:

LayerChromium::setAlwaysReservesTextures doesn't do anything and hasn't since the prioritized texture manager
landed. This deletes the associated code.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

Source/WebKit/chromium:

Stops attempting to find the scrollbar layers and call setAlwaysReserveTextures() on them since the call doesn't
do anything.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setViewport):

  • src/WebLayer.cpp:
10:06 AM Changeset in webkit [125787] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Sort the xcodeproj file.

  • WebCore.xcodeproj/project.pbxproj:
10:05 AM Changeset in webkit [125786] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Update bindings tests results from my recent VoidCallback
patch. The new result is correct.

  • bindings/scripts/test/V8/V8TestCallback.cpp:
9:06 AM Changeset in webkit [125785] by caseq@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: CPU profiler status bar is broken.
https://bugs.webkit.org/show_bug.cgi?id=94212

Reviewed by Pavel Feldman.

  • properly compute floating status bar buttons offset for profile and timeline panels,

taking actual number of panel status bar buttons and panel sidebar offset into account;

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.get statusBarItems):
(WebInspector.ProfilesPanel.prototype.sidebarResized):
(WebInspector.ProfilesPanel.prototype.onResize):

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView.prototype.sidebarWidth):

  • inspector/front-end/StatusBarButton.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype.onResize):

9:02 AM Changeset in webkit [125784] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebCore

Fix the Mac build.

Unreviewed build fix.

  • WebCore.exp.in: Export FrameView::didFirstLayout()
8:33 AM Changeset in webkit [125783] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] Remove an unused variable

Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

8:31 AM Changeset in webkit [125782] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Change the default cache model to enable the page cache
https://bugs.webkit.org/show_bug.cgi?id=94221

Reviewed by Simon Hausmann.

The default CacheModelDocumentViewer disables the memory back-forward page cache.
As uses of applications using QQuickWebView might vary, I'm setting the default to
CacheModelDocumentBrowser.
We should eventually expose this in the API to allow serious Web browsers setting it
to CacheModelPrimaryWebBrowser or to CacheModelDocumentViewer for application tight
on memory with limited page navigations.

  • UIProcess/qt/QtWebContext.cpp:

(WebKit::QtWebContext::defaultContext):

8:30 AM Changeset in webkit [125781] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Make sure that we don't prematurely force the first layout during loading.
https://bugs.webkit.org/show_bug.cgi?id=94106

Reviewed by Kenneth Rohde Christiansen.

This would have the nasty effect that the frame loader would report the first layout
before loadCommitted was reported. This would resume the rendering engine prematurely,
showing blank content and reporting an empty contents size.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFixedLayoutSize):

8:23 AM Changeset in webkit [125780] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
7:58 AM Changeset in webkit [125779] by kpiascik@rim.com
  • 2 edits in trunk/Source/WebCore

Add BB10 User Agent String to Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=94217

Reviewed by George Staikos.

Add the new BlackBerry 10 User Agent String and device metrics for
emulation.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.get const):

7:54 AM Changeset in webkit [125778] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebKit/blackberry: [BlackBerry] Suppress non DRT JS Console output.
https://bugs.webkit.org/show_bug.cgi?id=94058

Patch by Rob Buis <rbuis@rim.com> on 2012-08-16
Reviewed by Yong Li.
Reviewed internally by Ming Xie.

Some actual test results show JS Console showing up twice, for
instance traversal/moz-bug559526.html. Only print the DRT specific
Console message.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::addMessageToConsole):

Tools: [BlackBerry] Update format of JS console message to keep consistent with other ports.
https://bugs.webkit.org/show_bug.cgi?id=94058

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-08-16
Reviewed by Yong Li.
Reviewed internally by George Staikos.

  1. Remove line number if it's zero.
  2. Print only file name for "file://" URL.
  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):

7:27 AM Changeset in webkit [125777] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Qt] Input method hints are not being set.
https://bugs.webkit.org/show_bug.cgi?id=92386

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-08-16
Reviewed by Kenneth Rohde Christiansen.

Input method hints for an editable element must be obtained from a proper
HTML element. If the editable element is a complex one, it will have elements
in the Shadow DOM, and it's one of those that will be returned as the root
editable element. This works for editable DIVs, but not for INPUT elements.
Using Element::shadowHost() on the root editable element will provide the
needed HTML element, and for further clarity a method that does this was added
to FrameSelection.

Source/WebCore:

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::rootEditableElementRespectingShadowTree): Similar to
WebCore::FrameSelection::rootEditableElement, but returns the first ancestor of
the editable element outside the shadow tree.
(WebCore):

  • editing/FrameSelection.h:

(FrameSelection):

Source/WebKit2:

Added an API test to the Qt port regarding the correct setting
of input method hints information on INPUT HTML tags.

  • UIProcess/API/qt/tests/html/inputmethod.html:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::inputMethodHints):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

7:17 AM Changeset in webkit [125776] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Make DRT results more reliable on X11

Reviewed by Jocelyn Turcotte.

Disable desktop setting awareness, to prevent QApplication on X11 from reading palette settings from
the running desktop environment.

  • DumpRenderTree/qt/main.cpp:

(main):

7:16 AM Changeset in webkit [125775] by zandobersek@gmail.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a platform-specific baseline after r125772.

  • platform/gtk/http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Added.
6:57 AM Changeset in webkit [125774] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r125758, r125759
https://bugs.webkit.org/show_bug.cgi?id=94215

Unreviewed, gardening.

Newly added tests: compositing/overflow/overflow-hidden-canvas-layer.html,
fast/forms/file/selected-files-from-history-state.html fail on EFL and need gardening.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-16

  • platform/efl/TestExpectations:
6:24 AM Changeset in webkit [125773] by zeno.albisser@nokia.com
  • 20 edits in trunk/Source

Make GraphicsSurface double buffered by default.
https://bugs.webkit.org/show_bug.cgi?id=93252

Create only a single GraphicsSurface per canvas
on both supported platforms Mac/Linux.
The GraphicsSurface on Mac internally uses two IOSurface
to provide a front and a back buffer.
The GLX implementation of GraphicsSurface uses
an XWindow which already provides a front and a back buffer.

Reviewed by Noam Rosenthal.

Source/WebCore:

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(GraphicsContext3DPrivate):

Remove creation of second GraphicsSurface.

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
(WebCore):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):

  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::create):

Adjust token type to uint64_t.

(WebCore::GraphicsSurface::exportToken):

Adjust return type to uint64_t.

(WebCore::GraphicsSurface::frontBuffer):
(WebCore):
(WebCore::GraphicsSurface::swapBuffers):

Add forwarding function to swap buffers inside GraphicsSurface.

  • platform/graphics/surfaces/GraphicsSurface.h:

(GraphicsSurface):

Add SupportsSingleBuffered flag to allow for single buffered implementations.
Currently single buffered surfaces are either not implemented or disabled.

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

Move implementation details into GraphicsSurfacePrivate.
This way the platform specific code can be hidden in the specific cpp file
instead of polluting the global GraphicsSurface header.

(WebCore::createTexture):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::token):
(WebCore::GraphicsSurfacePrivate::frontBufferTextureID):
(WebCore::GraphicsSurfacePrivate::backBufferTextureID):
(WebCore::GraphicsSurfacePrivate::frontBuffer):
(WebCore::GraphicsSurfacePrivate::backBuffer):
(WebCore):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromFramebuffer):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::ioSurfaceLockOptions):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::OffScreenRootWindow::get):
(WebCore::GraphicsSurfacePrivate::swapBuffers):

Make sure that framebuffer bindings remain consistent
after swapping buffers on the XWindow.

(WebCore::GraphicsSurface::platformExport):

Make sure the GLXPixmap is only bound to the texture once.

(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyFromFramebuffer):
(WebCore):
(WebCore::GraphicsSurface::platformFrontBuffer):

The GLX surface does not know how to destinguish between
the front and the back buffer by an id. This is not necessary
for GraphicsSurfaceGLX, because the texture can just be
read from the XWindow at any time.

(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

Remove code that was used for switching between two GraphicsSurfaces,
as this is now handled directly inside GraphicsSurface.

(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):
(WebCore::TextureMapperSurfaceBackingStore::setSurface):
(WebCore):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

Remove GraphicsSurfaceData struct. This class is not needed anymore
as we do not keep track of more than one GraphicsSurface at the time.

(WebCore):
(TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::graphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::TextureMapperSurfaceBackingStore):

  • platform/graphics/texmap/TextureMapperPlatformLayer.h:

(WebCore::TextureMapperPlatformLayer::graphicsSurfaceToken):

Source/WebKit2:

  • Shared/ShareableSurface.h:

(Handle):

Change the type of GraphicsSurface token to uint64_t.

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::syncCanvas):

Add a parameter that denotes the current front buffer of the
GraphicsSurface.

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::syncCanvas):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::syncCanvas):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::syncCanvas):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

5:42 AM Changeset in webkit [125772] by commit-queue@webkit.org
  • 13 edits
    14 adds in trunk

Implement the form-action Content Security Policy directive.
https://bugs.webkit.org/show_bug.cgi?id=93777

Patch by Mike West <mkwst@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

Source/WebCore:

The CSP 1.1 editor's draft defines the 'form-action' directive as a
mechanism for whitelisting valid targets for form submission from a
protected resource. A web author might desire to restrict form
submissions to the same origin as the protected resource itself via
a Content Security Policy of "form-action 'self'", or ensure that all
submissions were sent over an SSL connection via "form-action https:".

Specification details available at: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#form-action--experimental

This experimental directive is gated on the ENABLE_CSP_NEXT flag, which
is currently only enabled in Chromium.

Tests: http/tests/security/contentSecurityPolicy/1.1/form-action-src-allowed.html

http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-default-ignored.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-allowed.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkIfFormActionAllowedByCSP):

Adding a callback to FrameLoader in order to allow the
MainResourceLoader to check the relevant CSP status without knowing
anything about CSP.

(WebCore):

  • loader/FrameLoader.h:

(FrameLoader):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::willSendRequest):

Check against the protected resource's Content Security Policy when
presented with a request that is itself a form submission, or is the
result of a redirect in response to a form submission. If CSP would
block the target, cancel the request.

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):

Added explanatory text to the source violation console warning that
specifically calls out sending form data (as opposed to "connect to"
or "load the").

(WebCore::CSPDirectiveList::allowFormAction):

Check a URL against a directive list's the 'form-action' source list.

(WebCore):
(WebCore::CSPDirectiveList::addDirective):

Recognize the 'form-action' CSP directive.

(WebCore::ContentSecurityPolicy::allowFormAction):

Public interface to check a form action.

  • page/ContentSecurityPolicy.h:

LayoutTests:

  • http/tests/navigation/resources/redirection-response.php:

Allow for the specification of alternate hosts for the redirect. We
need this capability in order to check that an initial submission
followed by a blocked redirect results in the correct behavior.

  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-default-ignored-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-default-ignored.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html: Added.
5:20 AM Changeset in webkit [125771] by jochen@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebKit/chromium/features.gypi

Disable wip ContentSecurityPolicy features on M22

BUG=142415

5:12 AM Changeset in webkit [125770] by commit-queue@webkit.org
  • 14 edits in trunk/Source

[BlackBerry] WebGL and Canvas fail to display after being restored from page cache
https://bugs.webkit.org/show_bug.cgi?id=94105

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-16
Reviewed by George Staikos.

The EGLImage was being destroyed when releasing layer resources on the
compositing thread, but the WebKit thread layer never found out and
failed to create a new image.

Fixed by extending the release layer resources mechanism to also make a
pass on the WebKit thread so that thread's layers have a chance to
delete their textures and related resources.

Source/WebCore:

WebGL and canvas layers now take this opportunity to release their
textures so the EGLImage gets recreated when compositing commits
resume.

The only detail that deserves extra explanation is the ownership of the
EGLImage.

Since the EGLImage is created in updateTextureContentsIfNeeded() and
that one is always followed by commitPendingTextureUploads() which
transfers the EGLImage to the compositing thread layer's custody, the
EGLImage currently referenced by EGLImageLayerWebKitThread::m_image
should never be deleted by the WebKit thread layer.

Thus all we have to do in deleteFrontBuffer() is to set the m_image
member to 0 so the image gets recreated on the next commit. It will be
deleted by the part of releaseLayerResources() that executes on the
compositing thread (which, if you recall, was the original source of
this bug).

Reviewed internally by Filip Spacek.

PR 192899

Not currently testable by the BlackBerry testing infrastructure.

  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(WebCore::CanvasLayerWebKitThread::deleteTextures):
(WebCore):

  • platform/graphics/blackberry/CanvasLayerWebKitThread.h:

(CanvasLayerWebKitThread):

  • platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:

(WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::deleteFrontBuffer):

  • platform/graphics/blackberry/EGLImageLayerWebKitThread.h:

(EGLImageLayerWebKitThread):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::releaseLayerResources):
(WebCore):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(LayerWebKitThread):
(WebCore::LayerWebKitThread::deleteTextures):

  • platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:

(WebCore::WebGLLayerWebKitThread::~WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::deleteTextures):
(WebCore):

  • platform/graphics/blackberry/WebGLLayerWebKitThread.h:

(WebGLLayerWebKitThread):

Source/WebKit/blackberry:

Reviewed internally by Filip Spacek.

PR 192899

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::releaseLayerResources):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):
(BlackBerry::WebKit::WebPagePrivate::suspendRootLayerCommit):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/FrameLayers.cpp:

(BlackBerry::WebKit::FrameLayers::releaseLayerResources):
(WebKit):

  • WebKitSupport/FrameLayers.h:

(FrameLayers):

5:06 AM Changeset in webkit [125769] by caseq@chromium.org
  • 18 edits
    2 adds in trunk/Source/WebCore

Web Inspector: enable instrumentation of platform code
https://bugs.webkit.org/show_bug.cgi?id=94125

Reviewed by Pavel Feldman.

  • add PlatformInstrumentation class that exposes instrumentation methods that may be used by code under WebCore/platform;
  • move TRACE_EVENT_XXX() macros into PlatformInstrumentation.h to minimize instrumentation hassle in the client code;
  • implement PlatformInstrumentationClient by InspectorTimelineAgent;
  • only install PlatformInstrumentationClient when we have outer events for which we expect low-level details
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willDecodeImage): to be implemented by subsequent change;
(WebCore::InspectorTimelineAgent::didDecodeImage): to be implemented by subsequent change;
(WebCore::InspectorTimelineAgent::willResizeImage): to be implemented by subsequent change;
(WebCore::InspectorTimelineAgent::didResizeImage): to be implemented by subsequent change;
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::clearRecordStack):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • platform/PlatformInstrumentation.cpp: Added.

(WebCore):
(WebCore::PlatformInstrumentation::setClient):

  • platform/PlatformInstrumentation.h: Added.

(WebCore):
(PlatformInstrumentationClient):
(PlatformInstrumentation):
(WebCore::PlatformInstrumentation::hasClient):
(WebCore::PlatformInstrumentation::willDecodeImage):
(WebCore::PlatformInstrumentation::didDecodeImage):
(WebCore::PlatformInstrumentation::willResizeImage):
(WebCore::PlatformInstrumentation::didResizeImage):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::resizedBitmap): added calls to PlatformInstrumentation, removed TRACE_EVENT();

  • platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::BMPImageDecoder::decode): removed TRACE_EVENT()

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::GIFImageDecoder::decode): removed TRACE_EVENT()

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::ICOImageDecoder::decode): removed TRACE_EVENT()

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::JPEGImageDecoder::decode): removed TRACE_EVENT()

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::WEBPImageDecoder::decode): removed TRACE_EVENT();

  • inspector/InspectorInstrumentation.cpp: removed orphan event support;

(WebCore):

  • inspector/InspectorInstrumentation.h: ditto.
4:54 AM Changeset in webkit [125768] by commit-queue@webkit.org
  • 31 edits in trunk/LayoutTests

[EFL] Update pixel test expectations for layout test fast/dom/
https://bugs.webkit.org/show_bug.cgi?id=94177

Unreviewed, rebaseline.

Some tests have wrong pixel test results. They should be replaced.

And, two tests related image seem to fail. Alt text should be displayed
if src attribute is not set.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-16

  • platform/efl/TestExpectations: Added two tests related to display alt text without src.
  • platform/efl/fast/dom/34176-expected.png:
  • platform/efl/fast/dom/Element/class-attribute-whitespace-expected.png:
  • platform/efl/fast/dom/HTMLElement/bdo-expected.png:
  • platform/efl/fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png:
  • platform/efl/fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png:
  • platform/efl/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/efl/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/efl/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/efl/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/efl/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/efl/fast/dom/HTMLObjectElement/vspace-hspace-as-number-expected.png:
  • platform/efl/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/efl/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/efl/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/efl/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/efl/fast/dom/Range/surroundContents-1-expected.png:
  • platform/efl/fast/dom/Window/open-existing-pop-up-blocking-expected.png:
  • platform/efl/fast/dom/blur-contenteditable-expected.png:
  • platform/efl/fast/dom/children-nodes-expected.png:
  • platform/efl/fast/dom/clone-contents-0-end-offset-expected.png:
  • platform/efl/fast/dom/css-rule-functions-expected.png:
  • platform/efl/fast/dom/focus-contenteditable-expected.png:
  • platform/efl/fast/dom/gc-10-expected.png:
  • platform/efl/fast/dom/importNodeHTML-expected.png:
  • platform/efl/fast/dom/importNodeXML-expected.png:
  • platform/efl/fast/dom/row-inner-text-expected.png:
  • platform/efl/fast/dom/scroll-reveal-left-overflow-expected.png:
  • platform/efl/fast/dom/scroll-reveal-top-overflow-expected.png:
4:42 AM Changeset in webkit [125767] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: Breakpoints are not correctly restored on reload.
https://bugs.webkit.org/show_bug.cgi?id=94209

Reviewed by Pavel Feldman.

Source/WebCore:

BreakpointManager now resets uiLocations on workspace reset (was doing it on GlobalObjectCleared).
Breakpoint manager now calls restoreBreakpoints automatically when uiSourceCode is added to workspace.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype._workspaceReset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

  • inspector/front-end/inspector.js:

LayoutTests:

restoreBreakpoints is not called inside the test anymore to test that it is called automatically.

  • inspector/debugger/breakpoint-manager-expected.txt:
  • inspector/debugger/breakpoint-manager.html:
3:53 AM Changeset in webkit [125766] by pierre.rossi@gmail.com
  • 21 edits
    1 delete in trunk

[Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
https://bugs.webkit.org/show_bug.cgi?id=93960

Reviewed by Simon Hausmann.

Following the removal of Qt 4 support from trunk in r124879.

Source/WebCore:

No new tests. Simple cleanup job.

  • Target.pri:
  • platform/graphics/Font.cpp:

(WebCore::Font::codePath):

  • platform/graphics/Font.h:

(Font):

  • platform/graphics/GraphicsContext.cpp:

(WebCore):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit):
(WebCore::SimpleFontData::glyphForCharacter):

  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::rawFontForCharacters):
(WebCore::FontCache::getFontDataForCharacters):

  • platform/graphics/qt/FontCustomPlatformData.h:

(FontCustomPlatformData):

  • platform/graphics/qt/FontCustomPlatformDataQt.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/qt/FontPlatformData.h:

(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
(FontPlatformDataPrivate):
(FontPlatformData):
(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::hash):

  • platform/graphics/qt/FontQt4.cpp: Removed.
  • platform/graphics/qt/GlyphPageTreeNodeQt.cpp:

(WebCore::GlyphPage::fill):

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText):
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataHaveFeatures.in: Remove all traces of HAVE_QRAWFONT's existence.

Source/WebKit2:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWebCoreStatistics):

Tools:

  • qmake/mkspecs/features/features.prf:
3:02 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
Moving the openssl note to the top with other dependencies. (diff)
2:56 AM Changeset in webkit [125765] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r125592, r125635
https://bugs.webkit.org/show_bug.cgi?id=94197

Unreviewed gardening.

Gardening of fast/overflow/line-clamp-and-columns.html and
http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-16

  • platform/efl/TestExpectations:
2:56 AM BuildingQtOnWindows edited by kevin.funk@kdab.com
Add note about ICU (diff)
2:53 AM BuildingQtOnWindows edited by kevin.funk@kdab.com
Add grep dependency (diff)
2:28 AM Changeset in webkit [125764] by keishi@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

DOMWindowPagePopup needs to be installed before loading the html inside the page popup
https://bugs.webkit.org/show_bug.cgi?id=94193

Reviewed by Kent Tamura.

We are using window.pagePopupController.localizeNumberString while loading so we need to install DOMWindowPagePopup before loading the html.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initPage):

2:18 AM Changeset in webkit [125763] by yurys@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: memory instrumentation for Resource{Request/Response}Base
https://bugs.webkit.org/show_bug.cgi?id=94109

Reviewed by Vsevolod Vlasov.

Added reportMemoryUsage methods to ResourceRequestBase, ResourceResponseBase
and several related classes.

  • dom/MemoryInstrumentation.cpp:

(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl): added overrides
for String, StringImpl and AtomicString object types so that we can reuse
existing addInstrumentedCollection method instead of adding a counterpart
that would operate on not instrumented content. Next step would be to get
rid od addObject overrides for these types so that all kinds of Strings are
considered as instrumented classes despite they don't have reportMemoryUsage
method.
(WebCore):

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(MemoryInstrumentation):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • platform/network/FormData.cpp:

(WebCore::FormData::reportMemoryUsage):
(WebCore):

  • platform/network/FormData.h:

(WebCore):
(FormData):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::reportMemoryUsage):
(WebCore):

  • platform/network/ResourceRequestBase.h:

(ResourceRequestBase):

  • platform/network/ResourceResponseBase.cpp:

(WebCore):
(WebCore::ResourceResponseBase::reportMemoryUsage):

  • platform/network/ResourceResponseBase.h:

(WebCore):
(ResourceResponseBase):

2:12 AM Changeset in webkit [125762] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add unit tests for Web intent registration
https://bugs.webkit.org/show_bug.cgi?id=94133

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-16
Reviewed by Kenneth Rohde Christiansen.

Add unit tests for Web Intent service registration.
This tests the "intent,service,register" signaling
on the Ewk_View as well as Ewk_Intent_Service.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/tests/resources/intent-service.html: Added.
  • UIProcess/API/efl/tests/test_ewk2_intents.cpp: Added.

(onIntentServiceRegistration):
(TEST_F):

2:09 AM Changeset in webkit [125761] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

Delete DOMWindow::securityOrigin()
https://bugs.webkit.org/show_bug.cgi?id=93991

Reviewed by Eric Seidel.

DOMWindow::securityOrigin() just calls through to
document()->securityOrigin(). This patch updates all the callers to do
that work themselves, making it clearer what's going on at each call
site.

  • bindings/generic/BindingSecurity.cpp:

(WebCore::canAccessDocument):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::allowsAccessFrom):

  • bindings/js/JSDOMWindowCustom.h:

(WebCore::JSDOMWindowBase::allowsAccessFromPrivate):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::collectIsolatedContexts):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::isInsecureScriptAccess):
(WebCore::DOMWindow::createWindow):

  • page/DOMWindow.h:

(DOMWindow):

  • page/Location.cpp:

(WebCore::Location::reload):

1:54 AM Changeset in webkit [125760] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r125751.
http://trac.webkit.org/changeset/125751
https://bugs.webkit.org/show_bug.cgi?id=94206

we shouldn't be rolling out this patch without a formal
review. (Requested by rniwa_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-16

  • dom/CharacterData.cpp:

(WebCore::CharacterData::setDataAndUpdate):

  • editing/FrameSelection.cpp:

(WebCore::updatePositionAfterAdoptingTextReplacement):
(WebCore::FrameSelection::textWasReplaced):

  • editing/FrameSelection.h:

(FrameSelection):

1:52 AM Changeset in webkit [125759] by commit-queue@webkit.org
  • 19 edits
    2 adds in trunk

.: FormController, WebHistoryItem: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

  • Source/autotools/symbols.filter: Exported FormController::getReferencedFilePaths and HistoryController::saveDocumentAndScrollState.

Source/WebCore: FormController, FileInputType: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

Test: fast/forms/file/selected-files-from-history-state.html

  • WebCore.exp.in: Exported FormController::getReferencedFilePaths.
  • html/FileInputType.cpp:

(WebCore::FileInputType::filesFromFormControlState): Added. Extracts FileChooserFileInfos from a FormControlState.
(WebCore):
(WebCore::FileInputType::restoreFormControlState): Refactored to use filesFromFormControlState.

  • html/FileInputType.h:

(FileInputType): Added filesFromFormControlState.

  • html/FormController.cpp:

(SavedFormState): Added getReferencedFilePaths.
(WebCore::SavedFormState::getReferencedFilePaths): Added. Extracts selected file paths from SavedFormState.
(WebCore):
(WebCore::FormController::setStateForNewFormElements): Refactored to use formStatesFromStateVector.
(WebCore::FormController::formStatesFromStateVector):
(WebCore::FormController::getReferencedFilePaths): Added. Static. Extracts selected file paths from a document state.

  • html/FormController.h:

(FormController): Added getReferencedFilePaths and formStatesFromStateVector.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::filesFromFileInputFormControlState): Added. Delegates to FileInputType::filesFromFormControlState.
(WebCore):

  • html/HTMLInputElement.h: Added filesFromFileInputFormControlState.

(HTMLInputElement):

  • testing/Internals.cpp:

(WebCore::Internals::getReferencedFilePaths): Calls FormController::getReferencedFilePaths.
(WebCore):

  • testing/Internals.h:

(Internals): Added getReferencedFilePaths.

  • testing/Internals.idl: Added binding for getReferencedFilePaths.

Source/WebKit/chromium: WebHistoryItem: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

  • public/WebHistoryItem.h:

(WebHistoryItem): Added getReferencedFilePaths.

  • src/WebHistoryItem.cpp:

(WebKit::WebHistoryItem::getReferencedFilePaths): Extracts selected and posted file paths from a document state.
(WebKit):

Source/WebKit2: FormController, WebHistoryItem: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

  • win/WebKit2.def: Exported FormController::getReferencedFilePaths and HistoryController::saveDocumentAndScrollState.

LayoutTests: FormController: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

  • fast/forms/file/selected-files-from-history-state-expected.txt: Added.
  • fast/forms/file/selected-files-from-history-state.html: Added.
1:50 AM Changeset in webkit [125758] by shawnsingh@chromium.org
  • 5 edits
    4 adds in trunk

[chromium] set scissorRect per quad so that quads are correctly clipped
https://bugs.webkit.org/show_bug.cgi?id=94050

Reviewed by Adrienne Walker.

Source/WebCore:

Certain quad types rely on scissoring to do correct
clipping. Refactoring the quad types to remove this assumption
will be done in a later patch, but for now, we have to apply the
scissor rect to every quad to ensure that those quads are
correctly clipped.

Test: compositing/overflow/overflow-hidden-canvas-layer.html

Also updated two unit tests to reflect the change in semantics.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawQuad):

Source/WebKit/chromium:

Updated two unit tests to reflect that we need to always scissor,
until we refactor so that quads do not depend on scissoring.

  • tests/CCLayerTreeHostImplTest.cpp:

LayoutTests:

  • compositing/overflow/overflow-hidden-canvas-layer-expected.png: Added.
  • compositing/overflow/overflow-hidden-canvas-layer-expected.txt: Added.
  • compositing/overflow/overflow-hidden-canvas-layer.html: Added.
1:42 AM EFLWebKitCodingStyle edited by kenneth@webkit.org
(diff)
1:07 AM Changeset in webkit [125757] by hbono@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Prevent showing suggestions when right-clicking a selection range.
https://bugs.webkit.org/show_bug.cgi?id=94189

Reviewed by Hajime Morita.

To emulate Safari, my r120810 changes selection when right-clicking a misspelled
word. Unfortunately, this change somehow uses VisibleSelection::isCaretOrRange
and it changes the existing selection when right-clicking a selection which
includes a misspelled word. This change uses VisibleSelection::isCaret to
prevent showing suggestions when right-clicking a selection range. (Neither does
Safari show suggestions when there is a selection range.)

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

12:57 AM Changeset in webkit [125756] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectations for two accessibility tests introduced in r125710.

Rebaselining fast/css/word-space-extra.html after r125578.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/css/word-space-extra-expected.txt:
12:54 AM Changeset in webkit [125755] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Add deleteFileSystem support to DumpRenderTree for chromium
https://bugs.webkit.org/show_bug.cgi?id=94071

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-16
Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::deleteFileSystem): Added

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

12:34 AM Changeset in webkit [125754] by yosin@chromium.org
  • 3 edits
    3 adds in trunk

[Forms] Wheel event support in multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=94166

Reviewed by Kent Tamura.

Source/WebCore:

This patch makes multiple fields time input UI to handle wheel event
on spin button.

This patch affects if ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_TYPE_MULTIPLE_FIELDS
are enabled.

Test: fast/forms/time-multiple-fields/time-multiple-fields-wheel-event.html

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::defaultEventHandler): Changed to forward
event to spin button if available.

LayoutTests:

This patch adds a test for wheel event handling in multiple fields
time input UI.

  • fast/forms/time-multiple-fields/time-multiple-fields-wheel-event-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-wheel-event.html: Added.
12:28 AM Changeset in webkit [125753] by vsevik@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebCore/inspector/front-end/HandlerRegistry.js

Merge 125668 - Web Inspector: [REGRESSION] "save as" of edited source in developer mode fails to update saved file
https://bugs.webkit.org/show_bug.cgi?id=94074

Reviewed by Pavel Feldman.

Added dirty flag check when saving uiSourceCode to save working copy in this case.

  • inspector/front-end/HandlerRegistry.js:

(WebInspector.HandlerRegistry.prototype.appendApplicableItems.save):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems):

BUG=141180
TBR=vsevik@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10828339

12:18 AM Changeset in webkit [125752] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

TextureMapperGL::beginPainting has a duplicate call to get GL_FRAMEBUFFER_BINDING.
https://bugs.webkit.org/show_bug.cgi?id=94180

Patch by Zhigang Gong <zhigang.gong@linux.intel.com> on 2012-08-16
Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::beginPainting):

12:06 AM Changeset in webkit [125751] by inferno@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r119705.
http://trac.webkit.org/changeset/119705
https://bugs.webkit.org/show_bug.cgi?id=94192

Causing crash on ClusterFuzz due to incorrect layout ordering
change (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-16

  • dom/CharacterData.cpp:

(WebCore::CharacterData::setDataAndUpdate):

  • editing/FrameSelection.cpp:

(WebCore::updatePositionAfterAdoptingTextReplacement):
(WebCore::FrameSelection::textWillBeReplaced):

  • editing/FrameSelection.h:

(FrameSelection):

Aug 15, 2012:

11:20 PM Changeset in webkit [125750] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-15

  • DEPS:
11:01 PM Changeset in webkit [125749] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Refactoring: Introduce a new function for some part of PopupContainer::layoutAndCalculateWidgetRect()
https://bugs.webkit.org/show_bug.cgi?id=94087

Reviewed by Hajime Morita.

Move some part of PopupContainer::layoutAndCalculateWidgetRect() to a
new function which is not a member of PopupContainer because we'd like
to add a unit test for the position calculation code, and to reduce the
dependency.

No new tests. Popup positioning code is not testable in WebKit.

  • platform/chromium/PopupContainer.cpp:

(WebCore::layoutAndCalculateWidgetRectInternal):
Added. Move the code from PopupContainer::layoutAndCalculateWidgetRect.
In order to avoid to call member functions of PopupContainer, we
don't call layoutAndGetRTLOffset() and height(). Use
PopupListBox::layout() to recalculate the popup content size, and use
PopupListBox::height() + kBorderSize * 2 instead of height(). We
resize the view after finishing layoutAndCalculateWidgetRectInternal
in PopupContainer::layoutAndCalculateWidgetRect.
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
Move some code to layoutAndCalculateWidgetRectInternal.
(WebCore::PopupContainer::fitToListBox):
Added. Move the code from PopupContainer::layoutAndGetRTLOffset.
(WebCore::PopupContainer::layoutAndGetRTLOffset):
Move some code to fitToListBox.

  • platform/chromium/PopupContainer.h:

(PopupContainer): Added fitToListBox.

10:59 PM Changeset in webkit [125748] by yosin@chromium.org
  • 8 edits in trunk/LayoutTests

[Tests] Disable fast/forms/time-multiple-fields tests for port which don't enable multiple fields time input UI feature
https://bugs.webkit.org/show_bug.cgi?id=94186

Reviewed by Kent Tamura.

This patch disables tests in fast/forms/time-multiple-fields.
These tests are enabled if both ENABLE_INPUT_TYPE_TIME and
ENABLED_INPUT_TYPE_TIME_MULTIPLE_FIELDS enabled.

  • platform/chromium/TestExpectations:
  • platform/efl/tExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
10:37 PM Changeset in webkit [125747] by yosin@chromium.org
  • 3 edits in trunk/LayoutTests

[Forms] Re-factor fast/forms/number/number-wheel-event.html
https://bugs.webkit.org/show_bug.cgi?id=94172

Reviewed by Kent Tamura.

This patch moves test code from number-wheel-event.html to common-wheel-event.js
for sharing test code among input types.

  • fast/forms/number/number-wheel-event.html:
  • fast/forms/resources/common-wheel-event.js:

(testWheelEvent):

10:21 PM Changeset in webkit [125746] by shinyak@chromium.org
  • 6 edits in trunk/LayoutTests

REGRESSION (r125659): 4 HTMLMeterElement tests fail on Mac.
https://bugs.webkit.org/show_bug.cgi?id=94157

Unreviewed, unskip failing tests and rebaseline after r125659.

  • platform/mac/Skipped:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
10:01 PM Changeset in webkit [125745] by abarth@webkit.org
  • 25 edits
    1 move
    1 add
    5 deletes in trunk/Source/WebCore

VoidCallback should not be a special snowflake
https://bugs.webkit.org/show_bug.cgi?id=94119

Reviewed by Eric Seidel.

VoidCallback is the oldest of the callbacks and it predates our ability
to autogenerate callback objects. The existing implementation of
VoidCallback is wrong because it doesn't call
ActiveDOMCallback::canInvokeCallback. The net result of that is that
void callbacks can race with navigations and occationally execute after
the Frame has navigated to a new Document, which was causing the
flakiness.

This patch changes VoidCallback to no longer be a unique snowflake.
Instead, we autogenerate the implementation, just like every other
callback in WebCore.

Tests: storage/websql/database-lock-after-reload.html is no longer flaky.

  • DerivedSources.make:
  • GNUmakefile.list.am:
  • Modules/filesystem/SyncCallbackHelper.h:

(WebCore::SyncCallbackHelper::SuccessCallbackImpl::handleEvent):

  • Target.pri:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/cpp/WebDOMCustomVoidCallback.cpp: Removed.
  • bindings/cpp/WebDOMCustomVoidCallback.h: Removed.
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCustomVoidCallback.cpp: Removed.
  • bindings/js/JSCustomVoidCallback.h: Removed.
  • bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotificationCenter::requestPermission):

  • bindings/scripts/CodeGeneratorCPP.pm:

(GetClassName):
(AddIncludesForType):

  • bindings/scripts/CodeGeneratorJS.pm:

(GetCallbackClassName):
(GenerateCallbackImplementation):
(JSValueToNative):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackImplementation):
(TypeCanFailConversion):
(GetCallbackClassName):

  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::callbackWithNoParam):

  • bindings/scripts/test/V8/V8TestCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
  • bindings/v8/custom/V8CustomVoidCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomVoidCallback.h: Removed.
  • bindings/v8/custom/V8MutationCallbackCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::requestPermissionCallback):

  • html/VoidCallback.h:

(VoidCallback):

  • html/VoidCallback.idl:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore):

9:51 PM Changeset in webkit [125744] by hayato@chromium.org
  • 5 edits in trunk

[Shadow] Stop 'load' and 'error' events at shadow boundaries
https://bugs.webkit.org/show_bug.cgi?id=93425

Reviewed by Dimitri Glazkov.

Source/WebCore:

The shadow DOM spec has added these events as 'always-be-stopped' events at shadow boundaries.
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events-that-are-always-stopped

Test: fast/dom/shadow/events-stopped-at-shadow-boundary.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::determineDispatchBehavior):

LayoutTests:

  • fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
  • fast/dom/shadow/events-stopped-at-shadow-boundary.html:
9:21 PM Changeset in webkit [125743] by yosin@chromium.org
  • 1 edit
    1 copy in trunk/LayoutTests

[Tests] Copy to fast/forms/resources/common-wheel-event.js from fast/forms/number/number-wheel-event.html
https://bugs.webkit.org/show_bug.cgi?id=94184

Reviewed by Kent Tamura.

This patch copies fast/forms/number/number-wheel-event.html
to fast/forms/resources/common-wheel-event.js for sharing
test code among input types.

  • fast/forms/resources/common-wheel-event.js: Copied from LayoutTests/fast/forms/number/number-wheel-event.html.
8:56 PM Changeset in webkit [125742] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

(r125629): Newly added test css3/filters/custom/filter-fallback-to-software.html failing on mac
https://bugs.webkit.org/show_bug.cgi?id=94169

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-15
Reviewed by Sam Weinig.

Update TestExpecatations of failing test to make the bot green.

  • platform/mac/TestExpectations:
8:54 PM Changeset in webkit [125741] by tkent@chromium.org
  • 7 edits in trunk

Calendar Picker: Localize numbers in a calendar picker
https://bugs.webkit.org/show_bug.cgi?id=93704

Reviewed by Hajime Morita.

.:

  • ManualTests/forms/calendar-picker.html:

Add a mock pagePopupController.localizeNumberString().

Source/WebCore:

Because Number.toLocaleString() of V8 returns no localized
numbers, we provide a localization function via
PagePopupController.

No new tests. We have no ways to change the locale in layout tests.

  • Resources/pagepopups/calendarPicker.js:

(localizeNumber): Added. A wrapper for pagePopupController.localizeNumberString().
(formatJapaneseImperialEra): Use localizeNumber().
(formatYearMonth): ditto.
(DaysTable.prototype._renderMonth): ditto.

  • page/PagePopupController.cpp:

(WebCore::PagePopupController::localizeNumberString):
Added. Just calls WebCore::convertToLocalizedNumber().

  • page/PagePopupController.h:

(PagePopupController): Declare localizeNumberString().

  • page/PagePopupController.idl: Add localizeNumberString().
8:45 PM Changeset in webkit [125740] by yosin@chromium.org
  • 1 edit
    2 moves in trunk/LayoutTests

[Forms] Rename LayoutTests/fast/forms/number/number-wheel.html to number-wheel-event.html
https://bugs.webkit.org/show_bug.cgi?id=94173

Reviewed by Kent Tamura.

This patch renames LayoutTest/fast/forms/number/number-wheel.html to
number-wheel-event.html to indicate the test checks wheel event
handling.

  • fast/forms/number/number-wheel-event-expected.txt: Copied from LayoutTests/fast/forms/number/number-wheel-expected.txt.
  • fast/forms/number/number-wheel-event.html: Copied from LayoutTests/fast/forms/number/number-wheel.html.
  • fast/forms/number/number-wheel-expected.txt: Removed.
  • fast/forms/number/number-wheel.html: Removed.
8:05 PM Changeset in webkit [125739] by morrita@google.com
  • 3 edits
    2 adds in trunk

Regression(121518) TextFieldDecorationElement formatting is broken.
https://bugs.webkit.org/show_bug.cgi?id=90913

Reviewed by Dimitri Glazkov.

Source/WebCore:

NodeRenderingContext::nextRenderer() has a problem which cannot retrieve the renderer
across an insertion point in some case. That is because ad-hoc composed tree traversal on
NodeRenderingContext is broken. The problem is hidden before r121518 though.

This change rewrite nextRenderer() using ComposedShadowTreeWalker to eliminate the ad-hoc
traversal. previousRenderer() is also rewritten in the same way.

Test: fast/dom/shadow/shadow-div-reflow.html

  • dom/NodeRenderingContext.cpp:

(WebCore):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

LayoutTests:

  • fast/dom/shadow/shadow-div-reflow-expected.html: Added.
  • fast/dom/shadow/shadow-div-reflow.html: Added.
7:40 PM Changeset in webkit [125738] by rniwa@webkit.org
  • 14 edits in trunk

Update manual tests and comments to refer to TestRunner instead of LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=94168

Reviewed by Kent Tamura.

.:

  • ManualTests/resources/multiFileResources/post-echo-and-notify-done.cgi:

Source/WebKit:

  • PlatformBlackBerry.cmake:

Source/WebKit/chromium:

  • public/WebDevToolsAgent.h:

(WebDevToolsAgent):

  • public/WebView.h:

(WebView):

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(convertJSValueToWebElementVariant):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

  • Interfaces/IWebPreferencesPrivate.idl:

Source/WebKit2:

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::getBoolValueForKey):

7:35 PM Changeset in webkit [125737] by jchaffraix@webkit.org
  • 10 edits in trunk/Source/WebCore

Add a was-inserted-into-tree notification to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=93874

Reviewed by Eric Seidel.

This change adds insertedIntoTree to RenderObject so that renderers
can now do their post-insertion task inside this function.

Our current architecture has 2 ways of doing post-insertion tasks:

  • overriding RenderObject::addChild
  • RenderObjectChildList::insertChildNode / appendChildNode

Because the former is not guaranteed to be called for each insertion
(on top of being called on the parent and not the inserted child), the
2 latter functions are the one that have been mostly used recently. This
led to code duplication between the functions but also doesn't scale as
other renderers need to hop on this notification and currently don't (for
example, table parts). The other renderer's migration will be done in
follow-up patches.

Refactoring covered by existing tests.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingRenderNamedFlowThread):
Moved the code from renderNamedFlowThreadContainer to RenderObject::enclosingRenderNamedFlowThread.
This is needed as now 2 classes need to access the function.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Moved the code duplicated from those 2 functions into
the instances of insertedIntoTree below.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::insertedIntoTree):
Base function that needs to be called from all the other
specialized functions below.

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::insertedIntoTree):

  • rendering/RenderListItem.h:
  • rendering/RenderObject.h:
  • rendering/RenderObjectChildList.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::insertedIntoTree):

  • rendering/RenderRegion.h:

Added the overriden insertedIntoTree function.

  • rendering/RenderQuote.h:

Moved the comment from RenderObjectChildList about RenderQuote here.

7:19 PM FeatureFlags edited by Bruno de Oliveira Abinader
Added CSS3_TEXT_DECORATION feature flag information (diff)
7:14 PM Changeset in webkit [125736] by jpfau@apple.com
  • 5 edits
    5 adds in trunk

Allow blocking of Web SQL databases in third-party documents
https://bugs.webkit.org/show_bug.cgi?id=94057

Reviewed by Adam Barth.

Source/WebCore:

Add a check for pages in third-party pages to allow third-party storage blocking of Web SQL databases.

Tests: http/tests/security/cross-origin-websql-allowed.html

http/tests/security/cross-origin-websql.html

  • Modules/webdatabase/DOMWindowWebDatabase.cpp:

(WebCore::DOMWindowWebDatabase::openDatabase): Pass top origin to canAccessDatabase

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canAccessStorage): Common method for various types of storage that use the same criteria

  • page/SecurityOrigin.h:

(WebCore::SecurityOrigin::canAccessDatabase): Use canAccessStorage
(WebCore::SecurityOrigin::canAccessLocalStorage): Change to using canAccessStorage
(SecurityOrigin):

LayoutTests:

Created tests for accessing openDatabase from a third party and first party context when third-party blocking is on and off.

  • http/tests/security/cross-origin-websql-allowed-expected.txt: Added.
  • http/tests/security/cross-origin-websql-allowed.html: Added.
  • http/tests/security/cross-origin-websql-expected.txt: Added.
  • http/tests/security/cross-origin-websql.html: Added.
  • http/tests/security/resources/cross-origin-iframe-for-websql.html: Added.
6:48 PM Changeset in webkit [125735] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Fix TestExpectations line format for two fast/css tests failing on mac
https://bugs.webkit.org/show_bug.cgi?id=94160

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-15
Reviewed by Sam Weinig.

Remove "MAC" modifier, which seems to prevent the expectations from taking effect.

  • platform/mac/TestExpectations:
6:41 PM Changeset in webkit [125734] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Improve Document.h compile time - reduce includes of ScriptCallStack.h
https://bugs.webkit.org/show_bug.cgi?id=94161

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-15
Reviewed by Eric Seidel.

ScriptCallStack.h no longer included from ScriptExecutionContext. It's
relatively expensive to compile and gets compiled a ton because
Document.h indirectly includes it.

No new tests. Functionality should remain the same

  • Modules/indexeddb/IDBDatabase.cpp:
  • Modules/indexeddb/IDBIndex.cpp:
  • Modules/indexeddb/IDBObjectStore.cpp:
  • bindings/js/ScriptController.cpp:
  • dom/ScriptElement.cpp:
  • dom/ScriptExecutionContext.h:

(WebCore):

  • fileapi/Blob.cpp:
  • fileapi/WebKitBlobBuilder.cpp:
  • html/HTMLTrackElement.cpp:
  • loader/TextTrackLoader.cpp:
  • page/DOMSecurityPolicy.cpp:
6:27 PM Changeset in webkit [125733] by tkent@chromium.org
  • 1 edit
    2 copies in branches/chromium/1180

Merge 123637 - https://bugs.webkit.org/show_bug.cgi?id=89114
REGRESSION (r112919): Setting scrollTop after setting display from none to block
fails
-and corresponding-
<rdar://problem/11656050>

Reviewed by Simon Fraser.

Source/WebCore:

ScrollAnimatorMac::immediateScrollTo() and ScrollAnimatorMac::immediateScrollBy()
both have an optimization in place so that they do not call
notifyPositionChanged() if the new scroll offset matches the ScrollAnimator's
cached m_currentPosX and m_currentPosY. So revision 112919 caused troubled with
this optimization because it allowed RenderLayers to restore a scrollOffset from
the Element if there is one cached there. This caused the RenderLayer to have a
scrollOffset that is improperly out-of-synch with the ScrollAnimator's
currentPosition (which will just be 0,0 since it is being re-created like the
RenderLayer). This fix makes sure they are in synch by calling
setCurrentPosition() on the ScrollAnimator when the cached position is non-zero.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

LayoutTests:

  • fast/overflow/setting-scrollTop-after-hide-show-expected.txt: Added.
  • fast/overflow/setting-scrollTop-after-hide-show.html: Added.

TBR=karen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10823356

6:22 PM Changeset in webkit [125732] by rniwa@webkit.org
  • 12 edits
    8 moves in trunk/Tools

Rename LayoutTestController to TestRunner in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=93942

Reviewed by Simon Fraser.

Renamed the class and relevant files.

  • WebKitTestRunner/CMakeLists.txt:
  • WebKitTestRunner/DerivedSources.make:
  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl.
  • WebKitTestRunner/InjectedBundle/DerivedSources.pri:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::testRunner):
(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Removed.
  • WebKitTestRunner/InjectedBundle/Target.pri:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp.
  • WebKitTestRunner/InjectedBundle/TestRunner.h: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h.

(TestRunner):

  • WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Removed.
  • WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp.

(WTR::waitToDumpWatchdogTimerCallback):
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):

  • WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Removed.
  • WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp.

(WTR::waitToDumpWatchdogTimerCallback):
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):

  • WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: Removed.
  • WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm.

(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::waitUntilDoneWatchdogTimerFired):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):

  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Removed.
  • WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp.

(WTR::WatchdogTimerHelper::timerFired):
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):

  • WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: Removed.
  • WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp.

(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::waitToDumpWatchdogTimerFired):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):

  • WebKitTestRunner/PlatformEfl.cmake:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
6:03 PM Changeset in webkit [125731] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Update test expectations for css3/filters/custom/invalid-custom-filter-shader.html failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=94067

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-15
Reviewed by Brady Eidson.

Add to the list of tests needing rebaselining after https://bugs.webkit.org/show_bug.cgi?id=6033

  • platform/mac/TestExpectations:
5:57 PM Changeset in webkit [125730] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

IndexedDB: IDB*::keyPath should return IDBKeyPath, not IDBAny
https://bugs.webkit.org/show_bug.cgi?id=92434

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-15
Reviewed by Tony Chang.

Clean up IDBKeyPath conversion to IDBAny objects. This gets rid of
some implicit conversion from IDBKeyPath to IDBAny.

No new tests, just changing method signatures.

  • Modules/indexeddb/IDBAny.cpp:

(WebCore::IDBAny::set):
(WebCore):

  • Modules/indexeddb/IDBAny.h:

(WebCore):
(WebCore::IDBAny::create):
(IDBAny):

  • Modules/indexeddb/IDBIndex.h:

(WebCore::IDBIndex::keyPathAny):
(WebCore::IDBIndex::keyPath):

  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBKeyPath.cpp:
  • Modules/indexeddb/IDBKeyPath.h:
  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::keyPathAny):
(WebCore::IDBObjectStore::keyPath):

  • Modules/indexeddb/IDBObjectStore.idl:
5:52 PM Changeset in webkit [125729] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

EFL build fix attempt after r125711. Touch an IDL file to regenerate derived sources.

  • html/HTMLAllCollection.idl:
5:50 PM Changeset in webkit [125728] by commit-queue@webkit.org
  • 27 edits
    2 adds in trunk

IndexedDB: generate index keys for existing data in createIndex in front end
https://bugs.webkit.org/show_bug.cgi?id=91125

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-15
Reviewed by Tony Chang.

Source/WebCore:

Make createIndex() do index key generation in the frontend, rather
than the backend. When an index is created, the frontend uses the
cursor API to iterate through the values in the backend to
generate keys, sending them back to the backend using
IDBObjectStore::setIndexKeys()

This confines all key injection/extraction to the frontend.

The new test verifies the implemented behavior with respect to
error handling in degenerate uses of put(), though that behavior
is still in discussion as the spec is vague on the proper error
behavior.

Test: storage/indexeddb/lazy-index-population.html

  • Modules/indexeddb/IDBCursorBackendImpl.cpp: Make sure that the

TaskType propagates throught the cursor and all subsequent
continue() calls.
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::prefetchContinue):

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):

  • Modules/indexeddb/IDBObjectStore.cpp: Add an IndexPopulator

class to run a cursor from the frontend.
(WebCore):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBObjectStore.idl: Pass along ScriptContext

so that openCursor can be called from createIndex.

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReadyInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::iterIndexesBegin):
(WebCore::IDBObjectStoreBackendImpl::iterIndexesEnd):
(WebCore::IDBObjectStoreBackendImpl::backingStore):
(WebCore::IDBObjectStoreBackendImpl::databaseId):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • Modules/indexeddb/IDBRequest.cpp:

Allow requests to keep their own TaskType, to give certain
requests priority over others.
(WebCore::IDBRequest::create):
(WebCore):
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::abort):

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):
(WebCore::IDBRequest::taskType):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

Introduce a second, higher priority event queue, m_preemptiveTaskQueue,
which takes priority over the regular task queue.
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(WebCore::IDBTransactionBackendImpl::isTaskQueueEmpty):
(WebCore):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
(WebCore::IDBTransactionBackendImpl::taskEventTimerFired):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::scheduleTask):
(IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::addEarlyEvent):
(WebCore::IDBTransactionBackendImpl::didCompleteEarlyEvent):

  • Modules/indexeddb/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::IDBVersionChangeRequest):

Source/WebKit/chromium:

Add Chromium API methods to let the renderer process tell the
browser process about indexing progress.

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::openCursor):

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::openCursor):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::setIndexKeys):
(WebKit):
(WebKit::WebIDBObjectStoreImpl::setIndexesReady):
(WebKit::WebIDBObjectStoreImpl::openCursor):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

LayoutTests:

The transaction should be aborted when existing data in an
objectStore causes uniqueness errors during index creation.

  • storage/indexeddb/lazy-index-population-expected.txt: Added.
  • storage/indexeddb/lazy-index-population.html: Added.
5:43 PM Changeset in webkit [125727] by hayato@chromium.org
  • 4 edits
    2 adds in trunk

A 'load' event should be fired on the shadow host directly, not on an inner image element of shadow dom subtree.
https://bugs.webkit.org/show_bug.cgi?id=93920

Reviewed by Dimitri Glazkov.

Source/WebCore:

A 'load' event is a must-stoppable event at shadow boundary. So we
should fire a 'load' event on a shadow host directly, not on an
inner image element.

Test: fast/dom/shadow/shadowdom-for-image-event.html

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::dispatchLoadEvent):

  • loader/ImageLoaderClient.h:

(WebCore::ImageLoaderClient::eventTarget):

LayoutTests:

  • fast/dom/shadow/shadowdom-for-image-event-expected.txt: Added.
  • fast/dom/shadow/shadowdom-for-image-event.html: Added.
5:38 PM Changeset in webkit [125726] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
https://bugs.webkit.org/show_bug.cgi?id=94155

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.create_driver): Force no_timeout=True

5:18 PM Changeset in webkit [125725] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Add a hyperlink to perf-o-matic from build.webkit.org/root.html
https://bugs.webkit.org/show_bug.cgi?id=93749

Reviewed by Csaba Osztrogonác.

Added the hyperlink to webkit-perf.appspot.com. Also added hyperlinks to the waterfall display
of performance tests.

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
5:05 PM Changeset in webkit [125724] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] new test fast/forms/radio/radio-group.html introduced in r104668 fails
https://bugs.webkit.org/show_bug.cgi?id=76051

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-15
Reviewed by Csaba Osztrogonác.

Unskip now working test.

  • platform/qt/Skipped:
4:43 PM Changeset in webkit [125723] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a layout test for :lang() selector observing dynamic changes to lang
https://bugs.webkit.org/show_bug.cgi?id=94092

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-08-15
Reviewed by Alexey Proskuryakov.

This patch adds a test that dynamic changes to the lang attribute are seen by the :lang selector.
This behavior was first added in an earlier patch (probably http://trac.webkit.org/changeset/103608)
but there was no layout test for it yet.

  • fast/selectors/lang-dynamic-expected.html: Added.
  • fast/selectors/lang-dynamic.html: Added.
4:38 PM Changeset in webkit [125722] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (125659): 4 HTMLMeterElement tests fail on Mac
https://bugs.webkit.org/show_bug.cgi?id=94157

Skipping these 4 tests until the perpetrator can fix.

Not reviewed (Bot gardening).

  • platform/mac/Skipped:
4:34 PM Changeset in webkit [125721] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] When there is an exception we want to check if the ref is 0, not the
value as JSObjectCallAsFunction returns 0 in that case.
https://bugs.webkit.org/show_bug.cgi?id=94153

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-08-15
Reviewed by Yong Li.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):

4:32 PM Changeset in webkit [125720] by commit-queue@webkit.org
  • 5 edits
    13 adds in trunk/LayoutTests

[EFL] Some late night gardening
https://bugs.webkit.org/show_bug.cgi?id=94151

Unreviewed, EFL gardening.

Moving the autoscroll test out, adding platform specific baselines for the HTMLMeterElement tests.

Patch by Dominik Röttsches <d-r@roettsches.de> on 2012-08-15

  • platform/efl/TestExpectations:
  • platform/efl/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/efl/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/efl/fast/dom/HTMLMeterElement/meter-clone-expected.txt: Added.
  • platform/efl/fast/dom/HTMLMeterElement/meter-element-crash-expected.txt: Added.
  • platform/efl/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/efl/fast/dom/HTMLMeterElement/meter-element-form-expected.txt: Added.
  • platform/efl/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: Added.
  • platform/efl/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
  • platform/efl/fast/dom/HTMLMeterElement/meter-element-with-child-crash-expected.txt: Added.
  • platform/efl/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/efl/fast/dom/HTMLMeterElement/meter-percent-size-expected.txt: Added.
  • platform/efl/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/efl/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
  • platform/efl/fast/dom/HTMLMeterElement/set-meter-properties-expected.txt: Added.
3:54 PM Changeset in webkit [125719] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark canvas-fallback-content tests as asserting in debug builds
https://bugs.webkit.org/show_bug.cgi?id=94156

Unreviewed gardening. Update expectations.

  • platform/chromium/TestExpectations:
3:42 PM Changeset in webkit [125718] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Show custom error page when 407 is received
https://bugs.webkit.org/show_bug.cgi?id=94138

Reviewed by George Staikos.
Internally reviewed by Lianghui Chen

Adding a new custom error page when the browser receieves
a Wifi proxy authentication error. The previous behaviour
is to ask for user credentials everytime, and silently fails
when the username and password fields in the Wifi settings
are not empty. UX suggests modifying the behaviour to simply
asks the user to change their credentials in the Wifi settings
when we receive such an error.

The fix is to prevent notifyAuthReceived from sending another
networkjob when authCallbacks are called, and to listen to any 407
calls in notifyStatusReceived. Once we hit a 407, tell the frame we
failed and should load the custom error page.

Also removed checking functions in sendRequestWithCredentials because
proxy auth requests won't get into that function anymore.

#PR163400

Tested by loading on device and loading/reloading pages under
these scenarios:

  • Connected to wifi (no proxy)
  • Connected to wifi (proxy with no credentials)
  • Connected to wifi (proxy with invalid credentials)
  • Connected to wifi (proxy with valid credentials)
  • platform/network/blackberry/NetworkJob.cpp: (WebCore::NetworkJob::handleNotifyStatusReceived): (WebCore::NetworkJob::notifyAuthReceived): (WebCore::NetworkJob::sendRequestWithCredentials):

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-08-15

3:37 PM Changeset in webkit [125717] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk/Source/WebCore

Refactor away IsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=93971

Patch by Dan Carney <dcarney@google.com> on 2012-08-15
Reviewed by Adam Barth.

Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld.
This paves the way towards a JSC-like use of DOMWrapperWorld.

No tests. No change in functionality.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore):
(WebCore::mainThreadNormalWorld):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore):
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::count):
(WebCore::DOMWrapperWorld::worldId):
(WebCore::DOMWrapperWorld::domDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):

  • bindings/v8/IsolatedWorld.cpp: Removed.
  • bindings/v8/IsolatedWorld.h: Removed.
  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

  • bindings/v8/V8IsolatedContext.h:

(WebCore::V8IsolatedContext::getEntered):
(WebCore::V8IsolatedContext::world):
(V8IsolatedContext):

3:31 PM Changeset in webkit [125716] by commit-queue@webkit.org
  • 38 edits
    2 moves
    1 add in trunk

[css3-text] Add CSS3 Text decoration compile flag
https://bugs.webkit.org/show_bug.cgi?id=93863

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-15
Reviewed by Julien Chaffraix.

This patch handles the compile flag implementation, which will come disabled by
default, thus not exposing the CSS3 text decoration features to the web, unless
when explicitly enabling it with "--css3-text-decoration" build parameter.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Changeset r125205 added "-webkit-text-decoration-line" support without proper
compile flag. I am fixing this on this patch by adding #ifdef's along the added
code and reverting getComputedStyle* layout test changes until further notice.
The text-decoration-line.html layout test is now moved to
fast/css3-text-decoration directory, which is skipped on all platforms until
feature is sound and ready to be exposed to web.

Test: fast/css3-text-decoration/text-decoration-line.html

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::parseTextDecoration):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):
Added #ifdefs to enable/disable CSS3 Text Decoration code implemented by r125205.

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Changeset r125205 added "-webkit-text-decoration-line" support without proper
compile flag. I am fixing this on this patch by adding #ifdef's along the added
code and reverting getComputedStyle* layout test changes until further notice.
The text-decoration-line.html layout test is now moved to
fast/css3-text-decoration directory, which is skipped on all platforms until
feature is sound and ready to be exposed to web.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/resources/property-names.js:
  • svg/css/getComputedStyle-basic-expected.txt:

Avoid regression by reverting changes from r125205.

  • fast/css3-text-decoration/text-decoration-line-expected.html: Renamed from LayoutTests/fast/css/text-decoration-line-expected.html.
  • fast/css3-text-decoration/text-decoration-line.html: Renamed from LayoutTests/fast/css/text-decoration-line.html.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:

fast/css3-text-decoration directory is skipped until feature is enabled by default.

3:14 PM Changeset in webkit [125715] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Refactoring: move EventHandler::targetNode into HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=94107

Patch by Iain Merrick <husky@chromium.org> on 2012-08-15
Reviewed by Dimitri Glazkov.

Source/WebCore:

This static helper method in EventHandler was made public so that
WebFrameImpl can call it. That's untidy because EventHandler isn't
really involved. This patch turns it into an instance method of
HitTestResult (with a wrapper in MouseEventWithHitTestResult for
convenience).

Pure refactoring, no behavior change, no new test needed.

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectClosestWordFromMouseEvent):
(WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
(WebCore::EventHandler::handleMousePressEventTripleClick):
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::subframeForHitTestResult):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::sendContextMenuEvent):

  • page/EventHandler.h:

(EventHandler):

  • page/MouseEventWithHitTestResults.h:

(WebCore::MouseEventWithHitTestResults::targetNode):

  • page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):

  • page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):

  • page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passSubframeEventToSubframe):

  • page/wx/EventHandlerWx.cpp:

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::targetNode):
(WebCore):

  • rendering/HitTestResult.h:

(HitTestResult):

Source/WebKit/chromium:

This static helper method in EventHandler was made public so that
WebFrameImpl can call it. That's untidy because EventHandler isn't
really involved. This patch turns it into an instance method of
HitTestResult (with a wrapper in MouseEventWithHitTestResult for
convenience).

Pure refactoring, no behavior change, no new test needed.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::visiblePositionForWindowPoint):

3:07 PM Changeset in webkit [125714] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Upstream FrameLoaderClientBlackBerry::securityOriginForNewDocument()
https://bugs.webkit.org/show_bug.cgi?id=94139

Patch by Yong Li <yoli@rim.com> on 2012-08-15
Reviewed by Antonio Gomes.

Keep same security origin when a file URL automatically redirects to its child folder.
This patch will be reverted when we finish the better solution.
PR# 172333 and PR# 180590.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidStartProvisionalLoad):
(WebCore::FrameLoaderClientBlackBerry::securityOriginForNewDocument):
(WebCore):

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

2:54 PM Changeset in webkit [125713] by dgrogan@chromium.org
  • 6 edits in trunk/Source

IndexedDB: Add some ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=94055

Reviewed by Ojan Vafai.

Source/WebCore:

These are just some additional ASSERTS and some ASSERT_WITH_MESSAGE in
place of ASSERT. They are from the patch in
https://bugs.webkit.org/show_bug.cgi?id=92897

No new tests - we should never hit this behavior.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::registerFrontendCallbacks):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::setActive):

Source/WebKit/chromium:

  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::setVersion):

2:41 PM Changeset in webkit [125712] by leviw@chromium.org
  • 10 edits
    5 deletes in trunk/LayoutTests

More unreviewed updated expectations from r125694.

  • platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
  • platform/chromium-linux/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Removed.
  • platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.png:
  • platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
2:35 PM Changeset in webkit [125711] by commit-queue@webkit.org
  • 61 edits
    3 deletes in trunk

Unreviewed, rolling out r125687.
http://trac.webkit.org/changeset/125687
https://bugs.webkit.org/show_bug.cgi?id=94147

It broke the whole world (Requested by Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-15

Source/JavaScriptCore:

  • API/JSValueRef.cpp:

(JSValueToBoolean):

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • bytecode/Watchpoint.h:

(WatchpointSet):

  • debugger/DebuggerCallFrame.h:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncSome):

  • runtime/BooleanConstructor.cpp:

(JSC::constructBoolean):
(JSC::callBooleanConstructor):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

  • runtime/JSString.h:

(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

  • runtime/JSValue.h:
  • runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

  • runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):

  • runtime/Operations.h:

(JSC):
(JSC::JSValue::equalSlowCaseInline):

  • runtime/RegExpConstructor.cpp:

(JSC::setRegExpConstructorMultiline):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

  • runtime/Structure.h:

Source/WebCore:

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

  • bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDirectoryEntryCustom.cpp:

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

  • bindings/js/JSDirectoryEntrySyncCustom.cpp:

(WebCore::getFlags):

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::dataFunctionMatrix):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

  • bindings/js/JavaScriptCallFrame.cpp:
  • bindings/js/JavaScriptCallFrame.h:

(JavaScriptCallFrame):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateEventListenerCall):
(GenerateHeader):
(JSValueToNative):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):

  • bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::create):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertValueToJObject):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

LayoutTests:

  • fast/js/document-all-between-frames-expected.txt: Removed.
  • fast/js/document-all-between-frames.html: Removed.
  • fast/js/resources/document-all-between-frames-subframe.html: Removed.
  • platform/chromium/TestExpectations:
2:31 PM Changeset in webkit [125710] by dmazzoni@google.com
  • 30 edits
    6 adds in trunk

AX: Calls to AXObjectCache should prefer Node over Renderer
https://bugs.webkit.org/show_bug.cgi?id=91794

Reviewed by Chris Fleizach.

Source/WebCore:

Now that it's possible for nodes inside a canvas subtree to be focused and
represent accessible content, accessibility notifications should be triggered
with a Node* rather than with a RenderObject* whenever possible.

Every public API in AXObjectCache that took a RenderObject* before now either
takes a Node* instead, or has a parallel method that takes a Node*.

Tests: accessibility/accessibility-node-memory-management.html

accessibility/accessibility-node-reparent.html
accessibility/canvas-fallback-content.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedImageMapUIElement):
(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::contentChanged):
(WebCore):
(WebCore::AXObjectCache::updateCacheAfterNodeIsAttached):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::nodeTextChangeNotification):
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
(WebCore::AXObjectCache::rootAXEditableElement):
(WebCore::AXObjectCache::nodeIsTextControl):

  • accessibility/AXObjectCache.h:

(AXObjectCache):
(WebCore::AXObjectCache::setNodeInUse):
(WebCore::AXObjectCache::removeNodeForUse):
(WebCore::AXObjectCache::isNodeInUse):
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::contentChanged):
(WebCore::AXObjectCache::updateCacheAfterNodeIsAttached):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::nodeTextChangeNotification):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::selectedChildrenChanged):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::parentObject):

  • accessibility/AccessibilityObject.cpp:

(WebCore::appendAccessibilityObject):
(WebCore::replacedNodeNeedsCharacter):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::menuForMenuButton):
(WebCore::AccessibilityRenderObject::menuButtonForMenu):
(WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::titleUIElement):
(WebCore::AccessibilityRenderObject::isTabItemSelected):
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
(WebCore::AccessibilityRenderObject::nodeIsTextControl):
(WebCore::AccessibilityRenderObject::activeDescendant):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
(WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):

  • bindings/cpp/WebDOMCustomVoidCallback.cpp:

(toWebCore):

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::attach):

  • editing/AppendNodeCommand.cpp:

(WebCore::sendAXTextChangedIgnoringLineBreaks):

  • editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):

  • editing/Editor.cpp:

(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):

  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

  • editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

  • editing/chromium/FrameSelectionChromium.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childrenChanged):
(WebCore::HTMLSelectElement::optionElementChildrenChanged):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setInnerTextValue):

  • html/InputType.cpp:

(WebCore::InputType::applyStep):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

  • page/FocusController.cpp:

(WebCore::FocusController::setInitialFocus):

LayoutTests:

New tests:

  • canvas-fallback-content tests that objects in a canvas subtree can be focused and then you can retrieve the role of the accessible object.
  • accessibility-node-memory-management ensures that an AccessibilityNodeObject is detached when its node is destroyed.
  • accessibility-node-reparent ensures that if an AccessibilityNodeObject is created for a node without a renderer, but the node later gets a renderer, the AccessibilityNodeObject is detached and an AccessibilityRenderObject is created instead.
  • accessibility/accessibility-node-memory-management-expected.txt: Added.
  • accessibility/accessibility-node-memory-management.html: Added.
  • accessibility/accessibility-node-reparent-expected.txt: Added.
  • accessibility/accessibility-node-reparent.html: Added.
  • accessibility/canvas-fallback-content-expected.txt: Added.
  • accessibility/canvas-fallback-content.html: Added.
  • platform/gtk/TestExpectations:
2:24 PM Changeset in webkit [125709] by zandobersek@gmail.com
  • 5 edits
    6 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Updating baselines for <meter> tests after r125659.

Marking fullscreen/full-screen-iframe-legacy.html and
storage/websql/database-lock-after-reload.html as flaky.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
2:22 PM Changeset in webkit [125708] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

NinePieceImage: Avoid unnecessary duplication of default data in assignment operator.
<http://webkit.org/b/94046>

Reviewed by Geoffrey Garen.

If copying a NinePieceImage with a null m_data, don't create a copy of it's data()
as that will point to the default NinePieceImageData. ~200kB progression on Membuster.

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::operator=):

2:20 PM Changeset in webkit [125707] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] unskip passing fast/text tests.
https://bugs.webkit.org/show_bug.cgi?id=94127

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-15
Reviewed by Csaba Osztrogonác.

Three fast/text tests are working for Qt5 (WK1 and WK2).

  • platform/qt-5.0/Skipped:
2:19 PM Changeset in webkit [125706] by leviw@chromium.org
  • 27 edits
    9 adds
    16 deletes in trunk/LayoutTests

Unreviewed gardening. Updating test expectations after r125694.

  • fast/table/rowindex-expected.txt: Added.
  • fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
  • fast/text/international/bidi-override-expected.txt: Added.
  • fast/transforms/bounding-rect-zoom-expected.txt: Replaced.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
  • platform/chromium-linux/fast/transforms/bounding-rect-zoom-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/rowindex-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/rowindex-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-mac/fast/table/rowindex-expected.txt: Removed.
  • platform/chromium-mac/fast/text/international/bidi-override-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/efl/fast/table/rowindex-expected.txt: Removed.
  • platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
  • platform/efl/fast/text/international/bidi-override-expected.txt: Removed.
  • platform/efl/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
  • platform/gtk/fast/table/rowindex-expected.txt: Removed.
  • platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
  • platform/gtk/fast/text/international/bidi-override-expected.txt: Removed.
  • platform/gtk/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
2:13 PM Changeset in webkit [125705] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Should not keep recreating GeoTracker in setEnableHighAccuracy()
https://bugs.webkit.org/show_bug.cgi?id=94136

Patch by Yong Li <yoli@rim.com> on 2012-08-15
Reviewed by Rob Buis.
Internally reviewed by Lyon Chen.

PR# 192401.

  1. The prototype of GeoTracker::create() has changed.
  2. Fix the issue that it could recreate tracker unnecessarily when setEnableHighAccuracy() is called but accuracy requirment hasn't changed.
  3. Fix the issue setEnableHighAccuracy() could start tracking when tracker was suspended.
  • WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::startUpdating):
(GeolocationControllerClientBlackBerry::setEnableHighAccuracy):

2:09 PM Changeset in webkit [125704] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Buildfix after r125541
https://bugs.webkit.org/show_bug.cgi?id=94097

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-08-15
Reviewed by Filip Pizlo.

r125541 has broken the traditional ARM port build of JSC.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::neg32):
(JSC::MacroAssemblerARM::xor32):

1:51 PM Changeset in webkit [125703] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Mark Skia and Compositor Contexts
https://bugs.webkit.org/show_bug.cgi?id=94129

Patch by Gregg Tavares <gman@google.com> on 2012-08-15
Reviewed by James Robinson.

Marks the Skia and Compositor contexts to aid in debugging.

No new tests as no new functionality.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

1:50 PM Changeset in webkit [125702] by vollick@chromium.org
  • 4 edits in trunk/Source

[chromium] Must account for empty transformation lists when checking for big rotations.
https://bugs.webkit.org/show_bug.cgi?id=93975

Reviewed by James Robinson.

Source/WebCore:

AnimationTranslationUtil.cpp is supposed to reject large rotations
(>= 180 degrees between keyframes). The current code assumes that if
the lists of transforms at two consecutive keyframes do not match
(i.e., are different types), then do not need to reject. The rationale
is that we will revert to matrix blending -- we will collapse the lists
of transform operations to matrices at each keyframe and blend those.
Unfortunately, this is not true if a list is empty. It can be the case
that we transition from no transform to a rotation about the z axis of
360 degrees. In this case, the first list of transform operations will
be empty and the second will have a single rotation of 360 degrees. An
empty list should be treated as a rotation of zero degrees.

Unit tested in: GraphicsLayerChromiumTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList

  • platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::causesRotationOfAtLeast180Degrees):

Source/WebKit/chromium:

Adds a test to check that creating an animation with a big (> 180
degree) rotation, where the transform operations list in the 1st
keyframe is empty fails as expected.

  • tests/AnimationTranslationUtilTest.cpp:

(WebKit::TEST):
(WebKit):

1:40 PM Changeset in webkit [125701] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use the unconverted attribute instead of composing when deciding to how to handle key input.
https://bugs.webkit.org/show_bug.cgi?id=94132

Reviewed by Rob Buis.

PR 139838.

Switch direct key input handling to be based on the unconverted
attribute being present. Converted keys, even during composition
are now input directly.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setText):

12:58 PM Changeset in webkit [125700] by Beth Dakin
  • 12 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=93693
[WK2] REGRESSION(125091): pixel results don't sow scrollbars
anymore

Reviewed by Sam Weinig.

Source/WebCore:

This is a regression from http://trac.webkit.org/changeset/125091
in which I failed to noticed that
WKBundlePageCreateSnapshotInViewCoordinates() did actually do
something different than
WKBundlePageCreateSnapshotInDocumentCoordinates(). Specifically,
it used ScrollView::paint() to paint instead of
FrameView::paintContents(). So this patch restores that
functionality by adding a value to SnapshotOptions indicating
whether the snapshot should be taken in ViewCoordinates
(otherwise it defaults to DocumentCoordinates).

FrameView:: paintContentsForSnapshot() now takes a new parameter
that indicates whether to take the snapshot in document
coordinates or view coordinates.

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::paintContentsForSnapshot):

  • page/FrameView.h:

Source/WebKit2:

This is a regression from http://trac.webkit.org/changeset/125091
in which I failed to noticed that
WKBundlePageCreateSnapshotInViewCoordinates() did actually do
something different than
WKBundlePageCreateSnapshotInDocumentCoordinates(). Specifically,
it used ScrollView::paint() to paint instead of
FrameView::paintContents(). So this patch restores that
functionality by adding a value to SnapshotOptions indicating
whether the snapshot should be taken in ViewCoordinates
(otherwise it defaults to DocumentCoordinates).

  • Shared/API/c/WKImage.h:
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toSnapshotOptions):

  • Shared/ImageOptions.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaledSnapshotWithOptions):

Even though we plan to deprecate this API, it should keep doing
the right thing until it's gone.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCreateSnapshotInViewCoordinates):

Tools:

Use new API WKBundlePageCreateSnapshotWithOptions().

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):

12:54 PM Changeset in webkit [125699] by piman@chromium.org
  • 10 edits in branches/chromium/1229/Source

Merge 125577 - [chromium] race between CCLayerTreeHostImpl::releaseContentsTextures and CCThreadProxy::beginFrameCompleteOnImplThread
https://bugs.webkit.org/show_bug.cgi?id=93684

Reviewed by James Robinson.

This keeps track of whether we're between the beginFrame post and the
commit when releaseContentsTextures comes, and if that is the case, we
prune the texture uploads, keep the "textures purged" flag on and kick a
new commit.

Added CCLayerTreeHostTestEvictTextures test.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::beginFramePosted):
(WebCore):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::contentsTexturesPurged):
(WebCore::CCLayerTreeHostImpl::contentsTexturesWerePurgedSinceLastBeginFrame):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCTextureUpdateController.h:

(CCTextureUpdateController):

  • platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp:

(WebCore::CCTextureUpdateQueue::clearUploads):
(WebCore):

  • platform/graphics/chromium/cc/CCTextureUpdateQueue.h:

(CCTextureUpdateQueue):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):

TBR=piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836250

12:39 PM Changeset in webkit [125698] by ap@apple.com
  • 2 edits in trunk/Tools

Add rfong to Bugzilla CC "contributor" list.

  • Scripts/webkitpy/common/config/committers.py:
12:38 PM Changeset in webkit [125697] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Use literal initialization for CSS's pseudo types
https://bugs.webkit.org/show_bug.cgi?id=94066

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-15
Reviewed by Kenneth Rohde Christiansen.

Initialize CSS pseudo type strings with the new initialization from literal.

The first invocation of nameToPseudoTypeMap() becomes 20% faster and we use
less memory to store the strings.

  • css/CSSSelector.cpp:

(WebCore::nameToPseudoTypeMap):

12:36 PM Changeset in webkit [125696] by jsbell@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] IndexedDB: Delete unused WebKit API cursor accessors
https://bugs.webkit.org/show_bug.cgi?id=94134

Reviewed by Adam Barth.

Last bit of refactor work from http://webkit.org/b/92278 that ships the
cursor key/primaryKey/value to the front end via success messages, eliminating
the need for these accessors and the old success messages.

  • public/WebIDBCallbacks.h:
  • public/WebIDBCursor.h:
12:33 PM Changeset in webkit [125695] by beidson@apple.com
  • 10 edits
    2 adds in trunk

Removing a plug-in element from a page opened in a background tab in Safari crashes
<rdar://problem/12057991> and https://bugs.webkit.org/show_bug.cgi?id=93913

Reviewed by Beth Dakin.

.:

  • Source/autotools/symbols.filter: Allow this symbol through for DRT's sake.

Source/WebCore:

Expose Page::setCanStartMedia to regression tests so they can pretend to be in a non-windowed WebView.

Test: platform/mac-wk2/plugins/asynchronous-destroy-before-initialization.html

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setCanStartMedia):
(WebCore):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

This only happens in WebKit2 with asynchronous plug-in initialization enabled.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::destroy): Null-check m_connection, as it might not have been created yet.

  • win/WebKit2.def: Export Page::setCanStartMedia for InternalSettings/DRT use.

LayoutTests:

Using internal setting setCanStartMedia, pretend the page is in an unwindowed WebView then remove
the plug-in element.

  • platform/mac-wk2/plugins/asynchronous-destroy-before-initialization-expected.txt: Added.
  • platform/mac-wk2/plugins/asynchronous-destroy-before-initialization.html: Added.
12:32 PM Changeset in webkit [125694] by leviw@chromium.org
  • 51 edits
    2 adds in trunk

AutoTableLayout truncates preferred widths for cells when it needs to ceil them to contain the contents
https://bugs.webkit.org/show_bug.cgi?id=93911

Reviewed by Eric Seidel.

Source/WebCore:

Avoiding truncation of sub-pixel accumulated values when determining the preferred width of a table cell
in AutoTableLayout. Since we continue to layout tables using integers, we need to ceil the contents to
prevent premature wrapping of the contents.

This only affects ports with sub-pixel layout enabled, and fixes regressions of a handful of tests that
were missed when updating expectations when sub-pixel was enabled.

Test: fast/sub-pixel/auto-table-layout-should-avoid-text-wrapping.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

LayoutTests:

This only affects ports with sub-pixel layout enabled, and fixes regressions of a handful of tests that
were missed when updating expectations when sub-pixel was enabled.

  • fast/sub-pixel/auto-table-layout-should-avoid-text-wrapping-expected.txt: Added.
  • fast/sub-pixel/auto-table-layout-should-avoid-text-wrapping.html: Added.
  • platform/chromium-mac/editing/deleting/5144139-2-expected.txt:
  • platform/chromium-mac/fast/forms/001-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.txt:
  • platform/chromium-mac/fast/forms/button-white-space-expected.txt:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/formmove3-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.txt:
  • platform/chromium-mac/fast/table/rowindex-expected.png:
  • platform/chromium-mac/fast/table/rowindex-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-override-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-override-expected.txt:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/mac/tables/mozilla/bugs/bug55527-expected.txt:
12:28 PM Changeset in webkit [125693] by ojan@chromium.org
  • 4 edits
    2 adds in trunk

z-index should work without position on flexitems
https://bugs.webkit.org/show_bug.cgi?id=91405

Reviewed by Tony Chang.

Source/WebCore:

Require a layer on any RenderBox that has a non-auto z-index.
Statically positioned, non-flex-item's have their z-index coerced to auto,
so it's safe to check z-index unconditionally.

Test: css3/flexbox/z-index.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
-Don't coerce z-index to auto on statically positioned flex-items.
-Use the parentStyle to determine if the parent is a flexbox instead of
looking at the element's parentNode's renderer.

  • rendering/RenderBox.h:

-Add having a non-auto z-index to the list of things that require a layer.

LayoutTests:

  • css3/flexbox/z-index-expected.html: Added.
  • css3/flexbox/z-index.html: Added.

Use a ref-test since we want to be sure that the elements get painted in the right order.

12:18 PM Changeset in webkit [125692] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Gtk] atk_text_set_caret_offset() fails for table cells
https://bugs.webkit.org/show_bug.cgi?id=83501

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-15
Reviewed by Chris Fleizach.

Source/WebCore:

Allow using text ranges in accessible table cells.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::allowsTextRanges):
Add table cells to the list of accessibility objects supporting text ranges.

Source/WebKit/gtk:

Update unit test to include setting the caret in a table cell via the AtkText interface.

  • tests/testatk.c:

(testWebkitAtkCaretOffsets): Add setting the caret inside the text of a table cell.

12:08 PM Changeset in webkit [125691] by commit-queue@webkit.org
  • 22 edits
    2 moves in trunk

Rename window.internals.fastMallocStatistics to mallocStatistics
https://bugs.webkit.org/show_bug.cgi?id=94033

Patch by Scott Graham <scottmg@chromium.org> on 2012-08-15
Reviewed by Adam Barth.

PerformanceTests:

  • resources/runner.js:

(PerfTestRunner.storeHeapResults):
(PerfTestRunner.getUsedMallocHeap):
(PerfTestRunner.getAndPrintMemoryStatistics):
(PerfTestRunner.initAndStartLoop):

Source/WebCore:

Mechanical rename. In preparation for plumbing allocation information
from allocators that aren't "fastMalloc".

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCoreTestSupport.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::didTellClientAboutLoad):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::loadResource):

  • testing/FastMallocStatistics.h: Removed.
  • testing/FastMallocStatistics.idl: Removed.
  • testing/Internals.cpp:

(WebCore::Internals::mallocStatistics):

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:
  • testing/MallocStatistics.h: Added.
  • testing/MallocStatistics.idl: Added.

Tools:

  • GNUmakefile.am:
  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_memory_test):

LayoutTests:

  • fast/harness/fastmallocstatistics-object.html:
11:54 AM Changeset in webkit [125690] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[BlackBerry] Upstream BlackBerry build fixes
https://bugs.webkit.org/show_bug.cgi?id=94121

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-08-15
Reviewed by Rob Buis.

This includes several build fixes due to incorrect upstream patches.
These mistakes were never present downstream.

No new tests, because no new functionality is added.

Source/WebCore:

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):

  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):
(WebCore::GraphicsContext3D::ShaderSourceEntry::ShaderSourceEntry):

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRendererAction::LayerFilterRendererAction):

  • platform/graphics/blackberry/LayerFilterRenderer.h:

(LayerFilterRendererAction):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/AboutTemplate.html.cpp:

(writeHeader):

11:44 AM Changeset in webkit [125689] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Update expectations to match the bots. This test hasn't timed out in over 500 runs.

  • platform/chromium/TestExpectations:
11:44 AM Changeset in webkit [125688] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

JSDOMWrapper should ASSERT that it has an associated ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=94053

Reviewed by Sam Weinig.

Previously we were unable have this ASSERT because DOMWindow needed a
Frame to find Document. Now that we can find the Document without a
Frame, we can include the ASSERT and sanity will rein across the land.

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::JSDOMWrapper):

11:32 AM Changeset in webkit [125687] by mhahnenberg@apple.com
  • 61 edits
    3 adds in trunk

Change behavior of MasqueradesAsUndefined to better accommodate DFG changes
https://bugs.webkit.org/show_bug.cgi?id=93884

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

With some upcoming changes to the DFG to remove uses of ClassInfo, we will be changing the behavior of
MasqueradesAsUndefined. In order to make this change consistent across all of our execution engines,
we will make this change to MasqueradesAsUndefined as a separate patch. After this patch, MasqueradesAsUndefined
objects will only masquerade as undefined in their original context (i.e. their original JSGlobalObject).
For example, if an object that masquerades as undefined in frame A is passed to frame B, it will not
masquerade as undefined within frame B, but it will continue to masquerade in frame A.

There are two primary changes that are taking place here. One is to thread the ExecState* through
JSValue::toBoolean and JSCell::toBoolean so that JSCell::toBoolean can check the object's
JSGlobalObject to compare it to the lexical JSGlobalObject of the currently running code. If the two
are distinct, then the object cannot MasqueradeAsUndefined.

The other change is to perform this comparison of JSGlobalObjects everywhere where the MasqueradesAsUndefined
flag in the Structure is checked. For C++ code, this check has been factored into its own function in
Structure::masqueradesAsUndefined. We only perform this check in the DFG if the current JSGlobalObject has
had a MasqueradesAsUndefined object allocated within its context. This conditional compilation is managed
through the use of a WatchpointSet in each JSGlobalObject and alternate create() functions for JS DOM wrappers
that are MasqueradesAsUndefined.

  • API/JSValueRef.cpp:

(JSValueToBoolean):

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • bytecode/Watchpoint.h:

(WatchpointSet):

  • debugger/DebuggerCallFrame.h:

(JSC::DebuggerCallFrame::callFrame):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncSome):

  • runtime/BooleanConstructor.cpp:

(JSC::constructBoolean):
(JSC::callBooleanConstructor):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::masqueradesAsUndefinedWatchpoint):

  • runtime/JSString.h:

(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

  • runtime/JSValue.h:
  • runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

  • runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):

  • runtime/Operations.h:

(JSC):
(JSC::JSValue::equalSlowCaseInline):

  • runtime/RegExpConstructor.cpp:

(JSC::setRegExpConstructorMultiline):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

  • runtime/Structure.h:

(Structure):
(JSC::Structure::globalObjectOffset):
(JSC::Structure::masqueradesAsUndefined):
(JSC):

Source/WebCore:

With some upcoming changes to the DFG to remove uses of ClassInfo, we will be changing the behavior of
MasqueradesAsUndefined. In order to make this change consistent across all of our execution engines,
we will make this change to MasqueradesAsUndefined as a separate patch. After this patch, MasqueradesAsUndefined
objects will only masquerade as undefined in their original context (i.e. their original JSGlobalObject).
For example, if an object that masquerades as undefined in frame A is passed to frame B, it will not
masquerade as undefined within frame B, but it will continue to masquerade in frame A.

Test: fast/js/document-all-between-frames.html

All of the changes in WebCore are simply passing the additional ExecState argument to JSValue::toBoolean.

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

  • bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDirectoryEntryCustom.cpp:

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

  • bindings/js/JSDirectoryEntrySyncCustom.cpp:

(WebCore::getFlags):

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::dataFunctionMatrix):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

  • bindings/js/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::exec):
(WebCore):

  • bindings/js/JavaScriptCallFrame.h:

(JavaScriptCallFrame):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):

  • bindings/scripts/CodeGeneratorJS.pm: Also add the custom create function for MasqueradesAsUndefined JS DOM wrappers.

(GenerateEventListenerCall):
(GenerateHeader):
(JSValueToNative):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):

  • bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::create):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertValueToJObject):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

Source/WebKit/mac:

With some upcoming changes to the DFG to remove uses of ClassInfo, we will be changing the behavior of
MasqueradesAsUndefined. In order to make this change consistent across all of our execution engines,
we will make this change to MasqueradesAsUndefined as a separate patch. After this patch, MasqueradesAsUndefined
objects will only masquerade as undefined in their original context (i.e. their original JSGlobalObject).
For example, if an object that masquerades as undefined in frame A is passed to frame B, it will not
masquerade as undefined within frame B, but it will continue to masquerade in frame A.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray): Passing ExecState to toBoolean call.

Source/WebKit2:

With some upcoming changes to the DFG to remove uses of ClassInfo, we will be changing the behavior of
MasqueradesAsUndefined. In order to make this change consistent across all of our execution engines,
we will make this change to MasqueradesAsUndefined as a separate patch. After this patch, MasqueradesAsUndefined
objects will only masquerade as undefined in their original context (i.e. their original JSGlobalObject).
For example, if an object that masquerades as undefined in frame A is passed to frame B, it will not
masquerade as undefined within frame B, but it will continue to masquerade in frame A.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant): Passing ExecState to toBoolean call.

LayoutTests:

Added a test that uses a variety of ways of checking whether something is correctly
masquerading as undefined (or not) in a subframe.

  • fast/js/document-all-between-frames-expected.txt: Added.
  • fast/js/document-all-between-frames.html: Added.
  • fast/js/resources/document-all-between-frames-subframe.html: Added.
  • platform/chromium/TestExpectations: Chromium treats document.all differently, so skip our new test.
11:31 AM Changeset in webkit [125686] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update TestExpectations entry to refer to an actual bug.

  • platform/chromium/TestExpectations:
11:13 AM Changeset in webkit [125685] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for paragraphs in list items whose text wraps
https://bugs.webkit.org/show_bug.cgi?id=83435

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-15
Reviewed by Chris Fleizach.

Source/WebCore:

Fix a logic error when checking if an object is a list marker.

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(textForRenderer):

Source/WebKit/gtk:

Updated unit test to include a paragraph in a list item when testing atk_text_get_text_at_offset().

  • tests/testatk.c:

(testWebkitAtkGetTextAtOffsetWithSpecialCharacters):

11:01 AM Changeset in webkit [125684] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

There is additional space not belonged to a table between the table cells
https://bugs.webkit.org/show_bug.cgi?id=74864

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-08-15
Reviewed by Julien Chaffraix.

Source/WebCore:

Hittest for a point on the edge, i.e. between two table columns, currently
does not return any matching underlying element.

A hittest on such a point (on the edge of two table columns) should return
the column that lies either on the logical right/bottom of the said point.

Tests: fast/table/hittest-tablecell-bottom-edge.html

fast/table/hittest-tablecell-right-edge.html
fast/table/hittest-tablecell-with-borders-bottom-edge.html
fast/table/hittest-tablecell-with-borders-right-edge.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::spannedRows):
Removed the FIXME regarding the correctness of the usage of the upper_bound algorithm
since that is now verified by the testcases in this patch. Also, the comment
regarding the inconsistency between the algorithms used in spannedRows and spannedColumns
is no longer valid.

(WebCore::RenderTableSection::spannedColumns):
Changed lower_bound() algorithm to upper_bound() for obtaining the next column.
This is now similar to what is used for obtaining the next row in spannedRows().

LayoutTests:

  • fast/table/hittest-tablecell-bottom-edge-expected.txt: Added.
  • fast/table/hittest-tablecell-bottom-edge.html: Added.
  • fast/table/hittest-tablecell-right-edge-expected.txt: Added.
  • fast/table/hittest-tablecell-right-edge.html: Added.

Testcases added for verifying that the proper node is returned upon hit test
carried out at a point lying on the edge of two table cells.

  • fast/table/hittest-tablecell-with-borders-bottom-edge-expected.txt: Added.
  • fast/table/hittest-tablecell-with-borders-bottom-edge.html: Added.
  • fast/table/hittest-tablecell-with-borders-right-edge-expected.txt: Added.
  • fast/table/hittest-tablecell-with-borders-right-edge.html: Added.

These testcases verify the aforementioned behavior when the table cells
also have border specified for them.

10:59 AM Changeset in webkit [125683] by peter@chromium.org
  • 2 edits in trunk/Tools

Fix a warning in TestWebKitAPI's MediaTime test-suite
https://bugs.webkit.org/show_bug.cgi?id=94096

Reviewed by Adam Barth.

This warning is visible when building the file with certain GCC versions,
including the one used by Chromium for Android. The warning is visible in
the cr-android build bot output:

MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90

  • TestWebKitAPI/Tests/WTF/MediaTime.cpp:

(TestWebKitAPI::TEST):

9:58 AM Changeset in webkit [125682] by annacc@chromium.org
  • 16 edits in trunk

Add the timestampOffset attribute to SourceBuffer.
https://bugs.webkit.org/show_bug.cgi?id=93303

Reviewed by Dimitri Glazkov.

On the 30 July 2012 version of the Media Source Extensions spec, a timestampOffset
attribute was added to the SourceBuffer object:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#dom-timestampoffset

Source/WebCore:

Tests: additions to http/tests/media/media-source/video-media-source-objects.html

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setTimestampOffset): Set the timestampOffset on MediaPlayer.
(WebCore):

  • Modules/mediasource/MediaSource.h:

(MediaSource):

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer): Let the timestampOffset be 0 initially
(WebCore::SourceBuffer::timestampOffset): Return the last value set.
(WebCore):
(WebCore::SourceBuffer::setTimestampOffset): Forward the call onto MediaSouce.

  • Modules/mediasource/SourceBuffer.h:

(SourceBuffer):

  • Modules/mediasource/SourceBuffer.idl: Create the new timestampOffset attr.
  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::sourceSetTimestampOffset): A null media player

should just return false (nothing to set).

(WebCore):
(WebCore::MediaPlayer::sourceSetTimestampOffset): Forward the call.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::sourceSetTimestampOffset):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::sourceSetTimestampOffset): Add the new method.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit):
(WebKit::WebMediaPlayerClientImpl::sourceSetTimestampOffset): Forward the call.

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

  • http/tests/media/media-source/video-media-source-objects-expected.txt:
  • http/tests/media/media-source/video-media-source-objects.html:
9:50 AM Changeset in webkit [125681] by vsevik@chromium.org
  • 17 edits
    3 adds in trunk

Source/WebCore: Web Inspector: Incorrect XHR responses when two async xhrs are sent synchronously
https://bugs.webkit.org/show_bug.cgi?id=91630

Patch by Pavel Chadnov <chadnov@google.com> on 2012-08-15
Reviewed by Vsevolod Vlasov.

CachedResource object for XHR response is now taken from ResourceLoader (if it's possible).

Test: http/tests/inspector/network/network-xhr-async-double.html

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseButCanceledImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didReceiveResourceResponse):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):

  • inspector/InspectorResourceAgent.h:

(WebCore):
(InspectorResourceAgent):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse):

  • loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::didReceiveResponse):
(WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):

  • loader/ResourceLoadNotifier.h:

(ResourceLoadNotifier):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::isSubresourceLoader):
(WebCore):

  • loader/ResourceLoader.h:

(ResourceLoader):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::cachedResource):
(WebCore):
(WebCore::SubresourceLoader::isSubresourceLoader):

  • loader/SubresourceLoader.h:

(SubresourceLoader):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponse):

LayoutTests: Web Inspector: Incorrect XHR responses when two async xhrs are sent synchronously
https://bugs.webkit.org/show_bug.cgi?id=91630

Patch by Pavel Chadnov <chadnov@google.com> on 2012-08-15
Reviewed by Vsevolod Vlasov.

New test for two async XHRs sent synchronously.

  • http/tests/inspector/network-test.js:

(doXHR):
(doXHRWithPayload.xhr.onreadystatechange):
(doXHRWithPayload):

  • http/tests/inspector/network/network-xhr-async-double-expected.txt: Added.
  • http/tests/inspector/network/network-xhr-async-double.html: Added.
  • http/tests/inspector/network/resources/echo-payload.php: Added.
  • platform/chromium/http/tests/inspector/console-xhr-logging-async-expected.txt:
  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
9:20 AM Changeset in webkit [125680] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use nested layout when rotating
https://bugs.webkit.org/show_bug.cgi?id=94117

Partially patched by Arvid Nilsson.

Patch by Leo Yang <leoyang@rim.com> on 2012-08-15
Reviewed by George Staikos.
Reviewed internally by Arvid Nilsson.

When rotating the content width used for fixedLayoutSize is not
correct because we are changing the rotation and the content with
should be determined after layout. So we set the with to 0 if we
are rotating and beginning the nested layout. And in setViewportSize
we need a nested layout loop to trigger zoom-to-fit.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

9:06 AM Changeset in webkit [125679] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Stop copying ScrollViewBase vector all over
https://bugs.webkit.org/show_bug.cgi?id=94021

Reviewed by Rob Buis.

It outlives long enough in WebKit that we can
just pass a const+ref of it.

Internally reviewed by Gen Mak.

  • Api/WebPageClient.h:
9:05 AM Changeset in webkit [125678] by tonikitoo@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

Robust-fy the LayerWebKitThread ownership with InRegionScroller
https://bugs.webkit.org/show_bug.cgi?id=93983
PR #191737

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>

Patch changes the way we currently keep track of the active scrollable area
objects: before, we acquired the scrollable areas and just passed them in a vector up
to the client, copying it over and over again. Also, it was a client responsability to
delete stuff (BAD!).
Now, we keep track of vector within InRegionScroller, as a class member, which allows us to
avoid copies (in follow up patch), and control until when these objects outlive.

Patch also changes InRegionScrollableArea to "retptr" the composited layer
associated to it (if any). This ensure we have a non-null scrollable element always.

As mentioned, InRegionScroller is now responsible for deleting and vector of scrollable areas.

Internally reviewed by Arvid Nilsson.

  • Api/InRegionScroller.cpp:

(WebKit):
(BlackBerry::WebKit::InRegionScrollerPrivate::reset): Method is now responsible for
deleting the tracked scrollable areas.
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
Renamed from 'inRegionScrollableAreasForPoint'. It was changed in order to store the
scrollable area objects instead of just pass a copy of them up to the client.
(BlackBerry::WebKit::InRegionScrollerPrivate::activeInRegionScrollableAreas): Getter.
(BlackBerry::WebKit::InRegionScrollerPrivate::pushBackInRegionScrollable): It was
promoted to a class method instead of a local helper.

  • Api/InRegionScroller_p.h:

(WebKit):
(InRegionScrollerPrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint): Adjustments needed due to the
above changed.

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::~InRegionScrollableArea): Clear up the cached layer.
(WebKit):
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

  • WebKitSupport/InRegionScrollableArea.h:

(InRegionScrollableArea):

8:56 AM Changeset in webkit [125677] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Use default parameter on reportResult in InspectorFileSystemAgent
https://bugs.webkit.org/show_bug.cgi?id=93930

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-15
Reviewed by Vsevolod Vlasov.

No functional change.

  • inspector/InspectorFileSystemAgent.cpp:

(WebCore):

8:50 AM Changeset in webkit [125676] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Check for valid field focus before processing a spellcheck request
https://bugs.webkit.org/show_bug.cgi?id=94115

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-08-15
Reviewed by Rob Buis.

PR192891
Checking for valid field focus before processing the spellcheck
request.

Internally reviewed by Mike Fenton.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):

8:46 AM Changeset in webkit [125675] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Fix the 'git log' call in VCSUtils.pm for Windows
https://bugs.webkit.org/show_bug.cgi?id=94113

Patch by Kevin Funk <kevin.funk@kdab.com> on 2012-08-15
Reviewed by Kenneth Rohde Christiansen.

Failed because of invalid enquoting characters.

  • Scripts/VCSUtils.pm:
7:17 AM Changeset in webkit [125674] by kov@webkit.org
  • 4 edits in trunk/Tools

[jhbuild] move md5sum checking to update-webkit-libs-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=93208

Reviewed by Martin Robinson.

This change makes the md5sum check and saving be done by the script
that performs the dependencies update. build-webkit no longer prefixes
calls to commands with jhbuild-wrapper if jhbuild has not been
bootstrapped by the developer and --update-gtk is not given.

  • Scripts/update-webkit-libs-jhbuild:

(getMD5HashForFile): moved from webkitdirs.
(jhbuildConfigurationChanged): ditto.
(saveJhbuildMd5): ditto.
(cleanJhbuild): ditto, and changed to run jhbuild clean before removing
jhbuild.

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary): use jhbuildWrapperPrefixIfNeeded.
(buildAutotoolsProject): ditto.
(jhbuildWrapperPrefixIfNeeded): add a code branch for GTK+.
(generateBuildSystemFromCMakeProject): call update-webkitefl-libs
unconditionally for EFL.

  • jhbuild/jhbuild-wrapper:

(update_webkit_libs_jhbuild): removed, jhbuild-wrapper no longer runs the
update script itself
(ensure_jhbuild): remove update call.

6:58 AM Changeset in webkit [125673] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: TabbedEditorContainer Doens't show '*' near modified file name sometimes.
https://bugs.webkit.org/show_bug.cgi?id=94095

Reviewed by Pavel Feldman.

TabbedEditorContainer now correctly updates event listeners on UISourceCodeReplaced event.

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._addUISourceCodeListeners):
(WebInspector.TabbedEditorContainer.prototype._removeUISourceCodeListeners):

6:53 AM Changeset in webkit [125672] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Scroll/selection are not saved in sources panel editors sometimes.
https://bugs.webkit.org/show_bug.cgi?id=94098

Reviewed by Pavel Feldman.

SourceFrame listeners and _currentFile field are now cleared only when currently open tab is closed.

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._tabClosed):

6:50 AM Changeset in webkit [125671] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebKit2

[EFL][WK2] Refactoring: start using WKEinaSharedString in ewk_ classes
https://bugs.webkit.org/show_bug.cgi?id=93964

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-15
Reviewed by Kenneth Rohde Christiansen.

Started using WKEinaSharedString where it is advisable.

  • UIProcess/API/cpp/efl/WKEinaSharedString.cpp:

(WKEinaSharedString::operator==):

  • UIProcess/API/cpp/efl/WKEinaSharedString.h:
  • UIProcess/API/efl/ewk_download_job.cpp:

(_Ewk_Download_Job):
(_Ewk_Download_Job::_Ewk_Download_Job):
(_Ewk_Download_Job::~_Ewk_Download_Job):
(ewk_download_job_destination_set):
(ewk_download_job_suggested_filename_set):

  • UIProcess/API/efl/ewk_intent.cpp:

(_Ewk_Intent):
(_Ewk_Intent::_Ewk_Intent):
(_Ewk_Intent::~_Ewk_Intent):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):

  • UIProcess/API/efl/ewk_intent_service.cpp:

(_Ewk_Intent_Service):
(_Ewk_Intent_Service::_Ewk_Intent_Service):
(_Ewk_Intent_Service::~_Ewk_Intent_Service):
(ewk_intent_service_action_get):
(ewk_intent_service_type_get):
(ewk_intent_service_href_get):
(ewk_intent_service_title_get):
(ewk_intent_service_disposition_get):

  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::~_Ewk_Navigation_Policy_Decision):

  • UIProcess/API/efl/ewk_url_request.cpp:

(_Ewk_Url_Request):
(_Ewk_Url_Request::_Ewk_Url_Request):
(_Ewk_Url_Request::~_Ewk_Url_Request):
(ewk_url_request_url_get):
(ewk_request_cookies_first_party_get):
(ewk_url_request_http_method_get):

  • UIProcess/API/efl/ewk_url_response.cpp:

(_Ewk_Url_Response):
(_Ewk_Url_Response::_Ewk_Url_Response):
(_Ewk_Url_Response::~_Ewk_Url_Response):
(ewk_url_response_url_get):
(ewk_url_response_mime_type_get):

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(ewk_view_uri_update):
(ewk_view_title_get):
(ewk_view_theme_set):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):

  • UIProcess/API/efl/ewk_web_error.cpp:

(_Ewk_Web_Error):
(_Ewk_Web_Error::_Ewk_Web_Error):
(_Ewk_Web_Error::~_Ewk_Web_Error):
(ewk_web_error_url_get):
(ewk_web_error_description_get):

  • UIProcess/API/efl/ewk_web_resource.cpp:

(_Ewk_Web_Resource):
(_Ewk_Web_Resource::_Ewk_Web_Resource):
(_Ewk_Web_Resource::~_Ewk_Web_Resource):

6:03 AM Changeset in webkit [125670] by commit-queue@webkit.org
  • 35 edits
    4 copies in trunk

[WK2] Add support for Web Intents MessagePorts
https://bugs.webkit.org/show_bug.cgi?id=89072

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add support for WebIntents MessagePorts in WebKit2.
MessagePorts can be passed with a Web Intent in
order to open a direct communication channel
between the Web application and the intent service.

This functionality is already supported by WebKit 1.

This patch introduces a new InjectedBundleIntent
class which wraps a WebCore::Intent. This way
information regarding the MessagePorts in a Web
Intent is kept when using an injected bundle.

For the UIProcess, WebIntentData now carries
identifiers for the MessagePorts which can go over
IPC. Those identifiers map to actual MessagePorts
stored in the Web process. This way, when the UI
delivers an intent to a frame, we can get back the
corresponding MessagePorts from the Web process
before delivering the intent to the DOMWindow.

This functionality is already tested by:

  • webintents/web-intents-invoke-port.html
  • webintents/web-intents-obj-constructor.html
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • Shared/IntentData.cpp: Add MessagePort identifiers.

(WebKit::IntentData::IntentData):
(WebKit::IntentData::encode):
(WebKit::IntentData::decode):

  • Shared/IntentData.h:

(IntentData):

  • Target.pri:
  • UIProcess/API/C/WKIntentData.cpp: Rename WKIntentDataCopyExtra() to

WKIntentDataCopyExtraValue() for clarity.
(WKIntentDataCopyExtraValue):

  • UIProcess/API/C/WKIntentData.h: Remove WKIntentDataCreate() function now

that WTR uses WKBundleIntentCreate() instead.

  • UIProcess/API/efl/ewk_intent.cpp:

(ewk_intent_extra_get): Use WKIntentDataCopyExtraValue() instead of
WKIntentDataCopyExtra() since it was renamed.

  • UIProcess/WebIntentData.cpp:

(WebKit::WebIntentData::WebIntentData):
(WebKit::WebIntentData::~WebIntentData): Remove MessagePorts from WebProcess upon
WebIntentData destruction.
(WebKit):
(WebKit::WebIntentData::extras):

  • UIProcess/WebIntentData.h:

(WebKit):
(WebKit::WebIntentData::create):
(WebIntentData):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveIntentForFrame):

  • UIProcess/WebProcessProxy.cpp:

(WebKit):
(WebKit::WebProcessProxy::removeMessagePortChannel):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit):

  • WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKIntentData.cpp.

(WKBundleIntentGetTypeID):
(WKBundleIntentCreate):
(WKBundleIntentCopyAction):
(WKBundleIntentCopyType):
(WKBundleIntentCopyService):
(WKBundleIntentCopySuggestions):
(WKBundleIntentCopyExtraValue):
(WKBundleIntentCopyExtras):
(WKBundleIntentMessagePortCount):

  • WebProcess/InjectedBundle/API/c/WKBundleIntent.h: Copied from Source/WebKit2/UIProcess/API/C/WKIntentData.h.
  • WebProcess/InjectedBundle/API/c/WKBundleIntentRequest.cpp:

(WKBundleIntentRequestCopyIntent):

  • WebProcess/InjectedBundle/API/c/WKBundleIntentRequest.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageDeliverIntentToFrame):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundleIntent.cpp: Copied from Source/WebKit2/UIProcess/WebIntentData.cpp.

(WebKit):
(WebKit::InjectedBundleIntent::create):
(WebKit::InjectedBundleIntent::InjectedBundleIntent):
(WebKit::InjectedBundleIntent::action):
(WebKit::InjectedBundleIntent::payloadType):
(WebKit::InjectedBundleIntent::service):
(WebKit::InjectedBundleIntent::data):
(WebKit::InjectedBundleIntent::extra):
(WebKit::InjectedBundleIntent::extras):
(WebKit::InjectedBundleIntent::suggestions):

  • WebProcess/InjectedBundle/InjectedBundleIntent.h: Copied from Source/WebKit2/UIProcess/WebIntentData.h.

(WebKit):
(InjectedBundleIntent):
(WebKit::InjectedBundleIntent::coreIntent):
(WebKit::InjectedBundleIntent::type):

  • WebProcess/InjectedBundle/InjectedBundleIntentRequest.cpp:

(WebKit::InjectedBundleIntentRequest::intent):

  • WebProcess/InjectedBundle/InjectedBundleIntentRequest.h:

(WebKit):
(InjectedBundleIntentRequest):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::deliverIntent):
(WebKit):

  • WebProcess/WebPage/WebFrame.h:

(WebCore):
(WebFrame):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit):
(WebKit::WebPage::deliverCoreIntentToFrame):

  • WebProcess/WebPage/WebPage.h:

(WebCore):
(WebPage):

  • WebProcess/WebProcess.cpp: Store MessagePorts in WebProcess and keep mapping with

their identifiers.
(WebKit):
(WebKit::WebProcess::addMessagePortChannel):
(WebKit::WebProcess::messagePortChannel):
(WebKit::WebProcess::removeMessagePortChannel):

  • WebProcess/WebProcess.h:

(WebCore):
(WebProcess):

  • WebProcess/WebProcess.messages.in:

Tools:

Use WKBundleIntent instead of WebIntentData in
WebKitTestRunner. WTR now prints the number of
MessagePorts in received Web intents as
expected by the following layout tests:
webintents/web-intents-invoke-port.html
webintents/web-intents-obj-constructor.html

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didReceiveIntentForFrame):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::deliverWebIntent):

LayoutTests:

Unskip webintents/web-intents-invoke-port.html and
webintents/web-intents-obj-constructor.html for
WebKit2 EFL now that information about message ports
is correctly displayed by WebKitTestRunner.

  • platform/efl-wk2/TestExpectations:
5:11 AM Changeset in webkit [125669] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

[EFL] Remove image expectation added for a ref test
https://bugs.webkit.org/show_bug.cgi?id=94090

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-15

  • platform/efl/TestExpectations:
  • platform/efl/fast/css-generated-content/quotes-lang-expected.png: Removed.
5:06 AM Changeset in webkit [125668] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] "save as" of edited source in developer mode fails to update saved file
https://bugs.webkit.org/show_bug.cgi?id=94074

Reviewed by Pavel Feldman.

Added dirty flag check when saving uiSourceCode to save working copy in this case.

  • inspector/front-end/HandlerRegistry.js:

(WebInspector.HandlerRegistry.prototype.appendApplicableItems.save):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems):

4:55 AM Changeset in webkit [125667] by kkristof@inf.u-szeged.hu
  • 1 edit
    8 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platfrom specific expected results after r125593.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-08-15

  • platform/qt-5.0-wk2/http/tests/misc/window-dot-stop-expected.txt: Added.
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
  • platform/qt-5.0-wk2/http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.
4:17 AM Changeset in webkit [125666] by shinyak@chromium.org
  • 4 edits
    1 move
    1 delete in trunk/LayoutTests

[Chromium Mac] Unreviewed, rebaseline after r125659.

  • fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
4:02 AM Changeset in webkit [125665] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Roll WebKit Chromium DEPS to r151672
https://bugs.webkit.org/show_bug.cgi?id=94091

Unreviewed DEPS roll.

This also adds the new dependency on third_party/skia/gyp/, as was
introduced in Chromium's revision 151463.

  • DEPS:
3:45 AM Changeset in webkit [125664] by Csaba Osztrogonác
  • 11 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r125659.

  • platform/qt/Skipped: Skip new tests because of disabled SHADOW_DOM
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
3:27 AM Changeset in webkit [125663] by commit-queue@webkit.org
  • 12 edits
    4 deletes in trunk

Relative units are not set when the canvas has not parent
https://bugs.webkit.org/show_bug.cgi?id=93840

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Set the default font when no parent style is set. It will make
possible to apply relative units when a parent is not set.

No new tests, unskipped the existing ones.

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyFontSize::applyValue):
Make it possible to apply relative units if a parent style exist but
not a parent node. It works like this for em and ex, but not for
percent units.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore):
(WebCore::CanvasRenderingContext2D::setFont):

LayoutTests:

Unskipped tests that will now pass, removed wrong expectations
and updated test case which was fixed by the W3C.

  • canvas/philip/tests/2d.text.font.parse.size.percentage.default.html:

This test case was fixed on W3C upstream:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=18522

  • fast/canvas/canvas-font-ex-units-crash-expected.txt:
  • fast/canvas/script-tests/canvas-font-ex-units-crash.js:
  • platform/chromium/TestExpectations:
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Removed.
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Removed.
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/mac/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Removed.
  • platform/qt/Skipped:
3:15 AM Changeset in webkit [125662] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewd gardening. Readd removed expectations in r125658 with some modification.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-15

  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.
3:10 AM Changeset in webkit [125661] by pfeldman@chromium.org
  • 4 edits
    2 adds
    1 delete in trunk

Web Inspector: split standalone test runner, test scanner and test stub.
https://bugs.webkit.org/show_bug.cgi?id=94001

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change starts sending loacCompleted message to the embedder.

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.loadCompleted):

  • inspector/front-end/test-runner.html: Added.

LayoutTests:

This change allows opening a) test runner, b) layout tests and c) inspector front-end off different
hosts. It is one more step towards extension-driven runner.

  • http/tests/inspector/inspector-test.js:
  • http/tests/inspector/resources/test-runner.html: Removed.
  • http/tests/inspector/resources/test-scanner.html: Added.
2:51 AM Changeset in webkit [125660] by shinyak@chromium.org
  • 3 edits in trunk/Source/WebCore

[Refactoring] The debug version and release version of toHTMLSelectElement can be merged without any penalty
https://bugs.webkit.org/show_bug.cgi?id=94084

Reviewed by Kent Tamura.

We have two versions of toHTMLSelectElement. One has ASSERT() and the other one does not have ASSERT().
We can merge them without any penalty.

No new tests, no change in behavior.

  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:

(WebCore::isHTMLSelectElement):
(WebCore::toHTMLSelectElement):
(WebCore):

2:37 AM Changeset in webkit [125659] by shinyak@chromium.org
  • 24 edits
    12 adds in trunk

AuthorShadowDOM for meter element
https://bugs.webkit.org/show_bug.cgi?id=91970

Reviewed by Hajime Morita.

Source/WebCore:

We add support for AuthorShadowDOM for a meter element.

According to the Shadow DOM spec, a meter element should behave like having a UserAgentShadowRoot and
an element in UserAgentShadowRoot draws a real 'meter' bar. In this patch, we change the inner structure
of a meter element so that we can distribute an element having RenderMeter to AuthorShadowDOM.

Before this patch, a meter element has the following inner structure.

<meter>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot

|
+-- MeterBarElement
|
+-- MeterValueElement

After this patch, a meter element will have the following inner structure.

<meter>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot

|
+-- MeterInnerElement

|
+-- MeterBarElement
|
+-- MeterValueElement

However, if RenderTheme supports rendering meter, MeterInnerElement will not create a renderer
unless an AuthorShadowDOM is attached to it so that we can keep the current rendering style.

Tests: fast/dom/shadow/shadowdom-for-meter-dynamic.html

fast/dom/shadow/shadowdom-for-meter-multiple.html
fast/dom/shadow/shadowdom-for-meter-with-style.html
fast/dom/shadow/shadowdom-for-meter-without-appearance.html
fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html
fast/dom/shadow/shadowdom-for-meter.html

  • css/html.css:

(meter): Changed the display type. inline-box is not supported WebKit. inline-block is true.
(meter::-webkit-meter-inner-element):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::createRenderer):
(WebCore):
(WebCore::HTMLMeterElement::attach): Added didElementStateChange.
(WebCore::HTMLMeterElement::didElementStateChange):
(WebCore::HTMLMeterElement::willAddAuthorShadowRoot):
(WebCore::HTMLMeterElement::renderMeter):
(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLMeterElement.h:

(WebCore):
(WebCore::HTMLMeterElement::hasAuthorShadowRoot):
(HTMLMeterElement):
(WebCore::isHTMLMeterElement):
(WebCore::toHTMLMeterElement):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::meterElement):
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore):
(WebCore::MeterInnerElement::MeterInnerElement): We introduce a new element having RenderMeter
so that we can distribute an element having RenderMeter to AuthorShadowDOM.
(WebCore::MeterInnerElement::rendererIsNeeded): Different from a progress element, meter element will not be
rendered using a theme. So we don't need to check the style appearance.
(WebCore::MeterInnerElement::createRenderer):
(WebCore::MeterInnerElement::shadowPseudoId):

  • html/shadow/MeterShadowElement.h:

(WebCore):
(MeterInnerElement):
(WebCore::MeterInnerElement::create):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::meterElement):
(WebCore):
(WebCore::RenderMeter::valueRatio):

  • rendering/RenderMeter.h:

(RenderMeter):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::levelIndicatorFor):

LayoutTests:

Contains the following tests:

(1) meter element with AuthorShadowDOM
(2) meter element with multiple AuthorShadowDOM with a shadow element
(3) meter element with multiple AuthorShadowDOM without a shadow element
(4) meter element with AuthorShadowDOM with dynamic value update
(5) meter element with AuthorShadowDOM with style
(6) meter element with AuthorShadowDOM with -webkit-appearance: none

  • fast/dom/HTMLMeterElement/meter-clone-expected.txt:
  • fast/dom/HTMLMeterElement/meter-clone.html:
  • fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
  • fast/dom/shadow/resources/replaced-element-styles.css:

(.meter-like):
(.meter-inner-element-like):

  • fast/dom/shadow/shadowdom-for-meter-dynamic-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-dynamic.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-multiple-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-multiple.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-with-style-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-with-style.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-without-appearance-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-without-appearance.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-without-shadow-element-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html: Added.
  • fast/dom/shadow/shadowdom-for-meter.html: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
  • platform/mac/TestExpectations:
2:00 AM Changeset in webkit [125658] by kkristof@inf.u-szeged.hu
  • 2 edits
    2 deletes in trunk/LayoutTests

[Qt] Unreviwed gardening. Skip failing tests and remove obsolete test expectations.
https://bugs.webkit.org/show_bug.cgi?id=94076

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-15

  • platform/qt/Skipped: skip fast/events/autoscroll-in-textarea.html.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed after r125615.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Removed after r125615.
1:48 AM QtWebKitBuildBots edited by Csaba Osztrogonác
update Qt Mac bot (diff)
1:41 AM Changeset in webkit [125657] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding image failure expectation for fast/overflow/line-clamp-and-columns.html,
the reftest is failing since it was introduced in r125635.

Skipping media/video-controls-fullscreen-volume.html for the moment after
it's been failing since introduced in r125590, the failure is probably expected
and will be marked as WONTFIX when confirmed.

Marking fast/js/random-array-gc-stress.html as a flaky crasher. The crashing
occurs due to parallel GC being enabled.

  • platform/gtk/TestExpectations:
1:26 AM Changeset in webkit [125656] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

[Chromium] fast/dom/Window/dom-access-from-closure-window.html is flaky on Linux
https://bugs.webkit.org/show_bug.cgi?id=94060

Reviewed by Kentaro Hara.

Source/WebCore:

Previously, the V8 garbage collector might have collected the Document
wrapper before the DOMWindow wrapper because we overwrite the
"document" property of the DOMWindow during navigation.

This patch adds a hidden document property on the global object to
ensure that the Document wrapper lives at least as long as the
DOMWindow wrapper, ensuring that DOMWindows that we obtain from V8
always have non-null Document objects.

The JavaScriptCore bindings already have this behavior.

Test: fast/dom/Window/dom-access-from-closure-window-with-gc.html

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::updateDocumentWrapperCache):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

LayoutTests:

Ensure that collecting garbage doesn't change the behavior of this test
(compared with dom-access-from-closure-window.html).

  • fast/dom/Window/dom-access-from-closure-window-with-gc-expected.txt: Added.
  • fast/dom/Window/dom-access-from-closure-window-with-gc.html: Added.
1:17 AM Changeset in webkit [125655] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Add one more flaky test to test expectations.

  • platform/chromium/TestExpectations:
1:10 AM Changeset in webkit [125654] by caseq@chromium.org
  • 6 edits
    1 copy in trunk

Web Inspector: Calling getEventListeners() on element with malformed javascript event listeners crashes
https://bugs.webkit.org/show_bug.cgi?id=93937

Reviewed by Pavel Feldman.

Source/WebCore:

  • check listener function to be non-null (happens upon an exception while compiling attribute listeners)
  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::getJSListenerFunctions):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::getJSListenerFunctions):

LayoutTests:

  • added test for crash on invalid syntax in an attribute JS listener;
  • added custom expectation for chrome due to JS error logged to console by JSC while compiling attribute listener;
  • inspector/console/command-line-api-getEventListeners-expected.txt:
  • inspector/console/command-line-api-getEventListeners.html:
  • platform/chromium/inspector/console/command-line-api-getEventListeners-expected.txt: Copied from LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt.
12:14 AM Changeset in webkit [125653] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Update expectations for canvas/philip tests that require space collapsing
https://bugs.webkit.org/show_bug.cgi?id=94072

Unreviewed EFL gardening.

Move canvas/philip tests that require space collapsing
from Skipped file to TestExpectations and indicate
that the tests are outdated with corresponding bug
number.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-15

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
12:06 AM Changeset in webkit [125652] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update. Tests named dfg-*array.html are
known to be slow on debug bots.

  • platform/chromium/TestExpectations:

Aug 14, 2012:

11:28 PM Changeset in webkit [125651] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r125516. Revert the erroneous rename since we need to keep exposing
layoutTestController in Chromium port as explained r124785.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::bindJSObjectsToWindow):

11:25 PM Changeset in webkit [125650] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeMirrorTextEditor doesn't clear execution line
https://bugs.webkit.org/show_bug.cgi?id=94069

Patch by Jan Keromnes <janx@linux.com> on 2012-08-14
Reviewed by Pavel Feldman.

Make CodeMirrorTextEditor use line handles instead of numbers, remove
typeof == "number" checks.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.clearExecutionLine):
(WebInspector.CodeMirrorTextEditor.prototype.highlightLine):
(WebInspector.CodeMirrorTextEditor.prototype.clearLineHighlight):

10:53 PM Changeset in webkit [125649] by yutak@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix Chromium-Android builds.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::TimeInputType):
Declare the function as a constructor.

10:20 PM Changeset in webkit [125648] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Text selection in text area in auto scroll mode goes wrong.
https://bugs.webkit.org/show_bug.cgi?id=74346

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-14
Reviewed by Ojan Vafai.

Source/WebCore:

WebKit triggers autoscroll in text area when the user drags the cursor from inside
the text area to the outside. When that happens, it gets the local cursor position
relative to the node under the cursor from hit-testing, converts it to
the absolute position, and then converts it to the local position relative to the
text area. However, the hit-testing method of text area did not take scrolling
offset into account. This caused it to give an incorrect value of the local cursor
position. Make the hit-testing take scrolling offset into account.

Test: fast/events/autoscroll-in-textarea.html

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerTextElement::createRenderer):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::hitInnerTextElement):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore):

  • rendering/RenderTextControlSingleLine.h:

(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):

LayoutTests:

  • fast/events/autoscroll-in-textarea-expected.txt: Added.
  • fast/events/autoscroll-in-textarea.html: Added.
10:07 PM Changeset in webkit [125647] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Remove obsolete test expectations, and mark
slow tests as such.

  • platform/chromium/TestExpectations:
10:06 PM EfficientStrings created by benjamin@webkit.org
Some advice on the use of strings
9:27 PM Changeset in webkit [125646] by annacc@chromium.org
  • 19 edits
    5 deletes in branches/chromium/1229/Source/WebCore

Revert 124780 - Create a MediaSource object.
https://bugs.webkit.org/show_bug.cgi?id=91773

Reviewed by Eric Carlson.

MediaSource object is needed in order to implement the new
object-oriented MediaSource API:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

No new tests - will be able to test after landing:
https://bugs.webkit.org/show_bug.cgi?id=91775

Adding new files to build files:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

New MediaSource object:

  • Modules/mediasource/MediaSource.cpp: Added.
  • Modules/mediasource/MediaSource.h: Added.
  • Modules/mediasource/MediaSource.idl: Added.

Create a registry for the blob storage and lookup:

  • Modules/mediasource/MediaSourceRegistry.cpp: Added.
  • Modules/mediasource/MediaSourceRegistry.h: Added.

Connect SourceBuffer to MediaSource:

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::buffered): Forward call to MediaSource.
(WebCore::SourceBuffer::append): Ditto.
(WebCore::SourceBuffer::abort): Ditto.

  • Modules/mediasource/SourceBuffer.h:

(WebCore::SourceBuffer::create): Add a MediaSource to the constructor.
(WebCore::SourceBuffer::clear): Clear the MediaSource.
(SourceBuffer):

  • Modules/mediasource/SourceBufferList.cpp: include SourceBuffer.h
  • Modules/mediasource/SourceBufferList.h:

Make MediaSource an EventTarget:

  • dom/EventTarget.h:

(WebCore):

  • dom/EventTargetFactory.in:

Enable creation of MediaSource object URL from JavaScript:

  • html/DOMURL.cpp:

(WebCore):
(WebCore::DOMURL::createObjectURL):

  • html/DOMURL.h:

(WebCore):
(DOMURL):

  • html/DOMURL.idl:

New MediaSource constructor:

  • page/DOMWindow.idl:

TBR=annacc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834324

9:22 PM Changeset in webkit [125645] by annacc@chromium.org
  • 2 edits in branches/chromium/1229/Source/WebCore/html

Revert 124798 - MediaSource should use it's own list of source URLs
https://bugs.webkit.org/show_bug.cgi?id=93285

Reviewed by Eric Carlson.

r124780 added MediaSource objects to PublicURLManager's streamURLs list,
piggy-backing on MEDIA_STREAM. This patch creates a sourceURLs list so
that MediaSource can stand on its own.

Test: builds on Andriod even when MEDIA_STREAM is disabled.

  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • html/PublicURLManager.h:

(WebCore::PublicURLManager::contextDestroyed):
(PublicURLManager):
(WebCore::PublicURLManager::sourceURLs):

TBR=annacc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836255

9:02 PM Changeset in webkit [125644] by shinyak@chromium.org
  • 5 edits in trunk/Source/WebCore

[Refactoring] RenderMenuList and RenderListBox should have a method to return HTMLSelectElement.
https://bugs.webkit.org/show_bug.cgi?id=94061

Reviewed by Kent Tamura.

This is a preparation patch for Bug 91487. Since RenderMenuList::node() and RenderListBox::node()
will not return HTMLSelectElement to fix Bug 91487, it would be good to have a method to HTMLSelectElement.

No new tests, no change in behavior.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::selectElement):
(WebCore):
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::scrollToRevealSelection):
(WebCore::RenderListBox::size):
(WebCore::RenderListBox::numItems):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::autoscroll):
(WebCore::RenderListBox::stopAutoscroll):
(WebCore::RenderListBox::valueChanged):
(WebCore::RenderListBox::nodeAtPoint):

  • rendering/RenderListBox.h:

(WebCore):
(RenderListBox):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::selectElement):
(WebCore):
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::updateFromElement):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::valueChanged):
(WebCore::RenderMenuList::listBoxSelectItem):
(WebCore::RenderMenuList::multiple):
(WebCore::RenderMenuList::didSetSelectedIndex):
(WebCore::RenderMenuList::didUpdateActiveOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemAccessibilityText):
(WebCore::RenderMenuList::itemToolTip):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::itemBackgroundColor):
(WebCore::RenderMenuList::listSize):
(WebCore::RenderMenuList::selectedIndex):
(WebCore::RenderMenuList::itemIsSeparator):
(WebCore::RenderMenuList::itemIsLabel):
(WebCore::RenderMenuList::itemIsSelected):
(WebCore::RenderMenuList::setTextFromItem):

  • rendering/RenderMenuList.h:

(WebCore):
(RenderMenuList):

9:00 PM Changeset in webkit [125643] by kinuko@chromium.org
  • 3 edits
    5 adds in trunk

FileWriter fails with assertion when trying to write empty Blob
https://bugs.webkit.org/show_bug.cgi?id=93694

Reviewed by Kent Tamura.

if the given data size is zero (i.e. m_bytesToWrite is zero) the assertion 'bytes + m_bytesWritten > 0' should not be tested.

Source/WebCore:

Tests: fast/filesystem/file-writer-empty-blob.html

fast/filesystem/workers/file-writer-empty-blob.html

  • Modules/filesystem/FileWriter.cpp:

(WebCore::FileWriter::didWrite):

LayoutTests:

  • fast/filesystem/file-writer-empty-blob-expected.txt: Added.
  • fast/filesystem/file-writer-empty-blob.html: Added.
  • fast/filesystem/resources/file-writer-empty-blob.js: Added.
  • fast/filesystem/workers/file-writer-empty-blob-expected.txt: Added.
  • fast/filesystem/workers/file-writer-empty-blob.html: Added.
8:45 PM Changeset in webkit [125642] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, another gardening. Add one slow test.

  • platform/chromium/TestExpectations:
8:34 PM Changeset in webkit [125641] by keishi@webkit.org
  • 10 edits
    2 adds in trunk

Share common code between calendar picker and color suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=93802

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html:
  • ManualTests/forms/color-suggestion-picker.html:

Source/WebCore:

We want to share common code like utility functions between picker page popups.

No new tests because no behavior change. Covered by existing tests, color-suggestion-picker-appearance.html and calendar-picker-apeparance.html.

  • Resources/pagepopups/calendarPicker.js:

(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._showPopup):

  • Resources/pagepopups/colorSuggestionPicker.js:

(handleMessage):
(handleArgumentsTimeout):

  • Resources/pagepopups/pickerCommon.css: Added.

(body):

  • Resources/pagepopups/pickerCommon.js: Added.

(createElement):
(resizeWindow):
(getScrollbarWidth):

  • WebCore.gyp/WebCore.gyp: Add actions for pickerCommon.{css,js}
  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::writeDocument):

Source/WebKit/chromium:

  • src/ColorChooserUIController.cpp:

(WebKit::ColorChooserUIController::writeDocument):

8:24 PM Changeset in webkit [125640] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Add new test expectation for nested-rounded-corners.html.

  • platform/chromium/TestExpectations:
8:10 PM Changeset in webkit [125639] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for !ENABLE(DFG_JIT)

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
7:52 PM Changeset in webkit [125638] by mitz@apple.com
  • 2 edits in trunk/Tools

fast/events/overflow-scroll-fake-mouse-move.html and fast/events/frame-scroll-fake-mouse-move.html are failing in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=94045

Reviewed by Geoff Garen.

  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow _hasKeyAppearance]): Added. Returns [self isKeyWindow]. This is
needed now that WebView uses -_hasKeyAppearance instead of -isKeyWindow.

7:48 PM Changeset in webkit [125637] by fpizlo@apple.com
  • 30 edits
    2 adds in trunk/Source/JavaScriptCore

Array checks should use the structure, not the class info
https://bugs.webkit.org/show_bug.cgi?id=93150

Reviewed by Mark Hahnenberg.

This changes all array checks used in array accesses (get, put, get length,
push, pop) to use the structure, not the class info. Additionally, these
checks in the LLInt and baseline JIT record the structure in an ArrayProfile,
so that the DFG can know exactly what structure to check for.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/ArrayProfile.cpp: Added.

(JSC):
(JSC::ArrayProfile::computeUpdatedPrediction):

  • bytecode/ArrayProfile.h: Added.

(JSC):
(JSC::arrayModeFromStructure):
(ArrayProfile):
(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::bytecodeOffset):
(JSC::ArrayProfile::addressOfLastSeenStructure):
(JSC::ArrayProfile::observeStructure):
(JSC::ArrayProfile::expectedStructure):
(JSC::ArrayProfile::structureIsPolymorphic):
(JSC::ArrayProfile::hasDefiniteStructure):
(JSC::ArrayProfile::observedArrayModes):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::getArrayProfile):
(JSC):
(JSC::CodeBlock::getOrAddArrayProfile):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::executionEntryCount):
(JSC::CodeBlock::numberOfArrayProfiles):
(JSC::CodeBlock::arrayProfiles):
(JSC::CodeBlock::addArrayProfile):
(CodeBlock):

  • bytecode/Instruction.h:

(JSC):
(JSC::Instruction::Instruction):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetArgumentByVal):
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::emitPutByVal):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::StructureAbstractValue::hasSingleton):
(StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::singleton):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateArray):
(DFG):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • llint/LLIntOffsetsExtractor.cpp:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/Structure.h:

(Structure):
(JSC::Structure::classInfoOffset):

7:33 PM Changeset in webkit [125636] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation update. Address new flakiness
and slow tests.

  • platform/chromium/TestExpectations:
7:14 PM Changeset in webkit [125635] by ojan@chromium.org
  • 5 edits
    2 adds in trunk

Fix access to m_markupBox in WebCore::EllipsisBox::paint
https://bugs.webkit.org/show_bug.cgi?id=91138

Reviewed by Abhishek Arya.

Source/WebCore:

EllipsisBox would hold on to m_markupBox, which would then get destroyed during
the followup layoutIfNeeded in layoutVerticalBox. Instead, have EllipsisBox
dynamically grab to pointer to the markup box during paint since there's no
straightforward way to notify the EllipsisBox that the markupBox has been destroyed
and/or point it at the new markupBox.

Test: fast/overflow/line-clamp-and-columns.html

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore):
(WebCore::EllipsisBox::paintMarkupBox):

  • rendering/EllipsisBox.h:

(WebCore::EllipsisBox::EllipsisBox):
Just store a boolean that we have a markup box that needs painting.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
Clearing the override size right after setting it was incorrect because
there are cases where we'll do a followup layout in layoutVerticalBox, at which
point we'll still need the override size.
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):
Clear the override size here to handle cases where line clamp is removed since
we don't call applyLineClamp in those cases.

LayoutTests:

  • fast/overflow/line-clamp-and-columns-expected.html: Added.
  • fast/overflow/line-clamp-and-columns.html: Added.
7:08 PM Changeset in webkit [125634] by yosin@chromium.org
  • 5 edits
    3 adds in trunk

[Forms] Make input type "time" to use multiple field time input UI
https://bugs.webkit.org/show_bug.cgi?id=93929

Reviewed by Kent Tamura.

Source/WebCore:

This patch changes input type "time" UI to use multiple field time
input UI when build flag ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
enabled.

No new tests. This patch doesn't change behavior for users, however,
this patch changes behavior on layout tests. Tests will be added
in another patch with runtime enabled feature flag is enabled.

Test expectations for following tests are updated:

  • fast/forms/time/time-input-visible-string.html
  • fast/forms/time/time-stepup-stepdown-from-renderer.html
  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType): Exposed serialize() to derived classes.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::DateTimeEditControlOwnerImpl):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::~DateTimeEditControlOwnerImpl):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlMouseFocus):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerDisabled):
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerReadOnly):
(WebCore::TimeInputType::TimeInputType):
(WebCore::TimeInputType::~TimeInputType):
(WebCore::TimeInputType::createRenderer):
(WebCore::TimeInputType::createShadowSubtree):
(WebCore::TimeInputType::destroyShadowSubtree):
(WebCore::TimeInputType::forwardEvent):
(WebCore::TimeInputType::disabledAttributeChanged):
(WebCore::TimeInputType::handleKeydownEvent):
(WebCore::TimeInputType::handleDOMActivateEvent):
(WebCore::TimeInputType::isKeyboardFocusable):
(WebCore::TimeInputType::isMouseFocusable):
(WebCore::TimeInputType::minOrMaxAttributeChanged):
(WebCore::TimeInputType::readonlyAttributeChanged):
(WebCore::TimeInputType::isTextField):
(WebCore::TimeInputType::setValue):
(WebCore::TimeInputType::shouldUseInputMethod):
(WebCore::TimeInputType::stepAttributeChanged):
(WebCore::TimeInputType::updateEditElementLayout):
(WebCore::TimeInputType::updateInnerTextValue):
(WebCore::TimeInputType):

  • html/TimeInputType.h:

(TimeInputType):
(DateTimeEditControlOwnerImpl):

LayoutTests:

This patch added test expectations for multiple fields time input UI
testing which are different behavior from single field time input UI
for Chromium which enables multiple fields time input UI.

  • platform/chromium/fast/forms/time/time-input-visible-string-expected.txt: Select all in a field doesn't select text.
  • platform/chromium/fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Fields don't change value on Up/Down keyboard events when they don't have focus and Up/Down keyboard increment/decrement value on hour field rather than minute field.
6:51 PM Changeset in webkit [125633] by dino@apple.com
  • 3 edits
    2 adds in trunk

Initial call to webkitRequestAnimationFrame returns 0, Spec indicates the handle should always be > 0
https://bugs.webkit.org/show_bug.cgi?id=85819

Reviewed by James Robinson.

Source/WebCore:

The callback id returned by requestAnimationFrame was beginning at zero, when the spec
says it should be above one. Use a pre-increment rather than a post-increment.

Test: fast/animation/request-animation-frame-callback-id.html

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::registerCallback): Pre-increment rather than post-increment.

LayoutTests:

  • fast/animation/request-animation-frame-callback-id-expected.txt: Added.
  • fast/animation/request-animation-frame-callback-id.html: Added.
6:39 PM Changeset in webkit [125632] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

r125591 broke tests with SUBPIXEL_LAYOUT disabled
https://bugs.webkit.org/show_bug.cgi?id=94027

Reviewed by Eric Seidel.

The previous patch to fix block preferred widths for subpixel layout broke ports
without the flag enabled. This patch adds a static inline function --
adjustFloatForSubPixelLayout -- that truncates with sub-pixel layout disabled, and
ceil's to the nearest FractionalLayoutUnit when sub-pixel layout is enabled.

A block's max preferred width should be enough to layout the entire line without
wrapping. r125591 addressed a bug whereby converting floats to LayoutUnits with sub-
pixel layout enabled lost precision in certain cases, and could result in a line
being layed out to slightly over the max preferred width of the block.

This patch reverts the behavior when sub-pixel layout is disabled to truncating
sub-pixel values (such as those that originate in Length) when assigning them to
LayoutUnits, and ceiling the length of the entire line to the next largest integer.

Covered by existing tests.

  • rendering/RenderBlock.cpp:

(WebCore):
(WebCore::adjustFloatForSubPixelLayout):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

6:28 PM Changeset in webkit [125631] by cevans@google.com
  • 3 edits
    2 adds in trunk

Handle the XPath / (root) operator correctly for nodes that aren't attached to the document.
https://bugs.webkit.org/show_bug.cgi?id=36427

Reviewed by Abhishek Arya.

Source/WebCore:

We now behave the same as Firefox 14.
The consensus seems to be that the XPath spec is ambiguous for the case of detached nodes, and that using the fragment root is more intuitive than the document root for the case of detached nodes.
For example, http://www.w3.org/TR/xpath/ section 2 "Location Paths" is only clear for attached nodes: "A / by itself selects the root node of the document containing the context node. If it is followed by a relative location path, then the location path selects the set of nodes that would be selected by the relative location path relative to the root node of the document containing the context node."

Test: fast/xpath/xpath-detached-nodes.html

  • xml/XPathPath.cpp:

(WebCore::XPath::LocationPath::evaluate): Jump to the root of the detached subtree instead of the parent document if the node isn't attached to the document.

LayoutTests:

  • fast/xpath/xpath-detached-nodes-expected.txt: Added.
  • fast/xpath/xpath-detached-nodes.html: Added.
6:23 PM Changeset in webkit [125630] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

6:21 PM Changeset in webkit [125629] by Alexandru Chiculita
  • 3 edits
    2 adds in trunk

[CSS Shaders][Chromium] Filters area applied twice when CustomFilterOperation is in the list
https://bugs.webkit.org/show_bug.cgi?id=93900

Reviewed by James Robinson.

Source/WebCore:

Whenever the platform cannot render a shader in hardware it will fallback to software.
In such cases, the platform should remove any old filters applied, so that the filters do not apply twice.

Test: css3/filters/custom/filter-fallback-to-software.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setFilters):

LayoutTests:

Added a test that first applies a blur and then switches to a CSS Shader plus a blur.
The test was failing on Chromium by not removing the old blur filter from the platform layer.

  • css3/filters/custom/filter-fallback-to-software-expected.html: Added.
  • css3/filters/custom/filter-fallback-to-software.html: Added.
6:19 PM Changeset in webkit [125628] by ap@apple.com
  • 3 edits in trunk/Tools

[WK2] Fix some typos in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=94047

Reviewed by Jon Honeycutt.

  • MiniBrowser/mac/AppDelegate.m:

(didReceiveMessageFromInjectedBundle): (-[BrowserAppDelegate init]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(didReceiveMessage):
(WKBundleInitialize):

6:18 PM Changeset in webkit [125627] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

IndexedDB: add tracing to IDBLevelDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=93914

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-14
Reviewed by Tony Chang.

Add a bunch of trace events to the lower level
database layer, to separate database slowness
from core IDB slowness.

Also moving findKeyInIndex into IDBLevelDBBackingStore to
eventually make it const.

No new tests, just adding debug logging.

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::open):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
(WebCore):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::clearObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):
(WebCore::IDBLevelDBBackingStore::Transaction::rollback):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):

5:56 PM Changeset in webkit [125626] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Refactor EventDispatcher, moving code to make actual changes easier to review later.
https://bugs.webkit.org/show_bug.cgi?id=93959

Reviewed by Dimitri Glazkov.

No new tests - no new functionality.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore):
(WebCore::EventDispatcher::dispatchSimulatedClick):

5:33 PM Changeset in webkit [125625] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Fix warnings on Windows build
https://bugs.webkit.org/show_bug.cgi?id=93997

Patch by Scott Graham <scottmg@chromium.org> on 2012-08-14
Reviewed by Kentaro Hara.

Fixes truncation from 'double' to 'float' warnings on Chromium Windows
build.

  • tests/CCRenderSurfaceFiltersTest.cpp:

(WebKit::TEST):

  • tests/CCScrollbarAnimationControllerLinearFadeTest.cpp:

(WebCore::TEST_F):

5:10 PM Changeset in webkit [125624] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Clear pattern to prevent timing problem between cancelVibration and vibrate
https://bugs.webkit.org/show_bug.cgi?id=93957

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-14
Reviewed by Kentaro Hara.

There is a timing issue in the cancelVibration.
Since vibrate works based on timer, cancelVibration might be called
eariler than vibrate when cancelVibration is called just after vibrate call.
It can be prevented from clearing m_pattern in the cancelVibration.

  • Modules/vibration/Vibration.cpp:

(WebCore::Vibration::cancelVibration):

5:08 PM Changeset in webkit [125623] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.6

New Tag.

4:40 PM Changeset in webkit [125622] by commit-queue@webkit.org
  • 12 edits in trunk

/SAFESEH should not be a common linker option
https://bugs.webkit.org/show_bug.cgi?id=89372

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-08-14
Reviewed by Darin Adler.

  • win/tools/vsprops/common.vsprops:

removed /SAFESEH as a default option for the linker (doesn't work for x64)

4:28 PM Changeset in webkit [125621] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/JavaScriptCore

Merged r124272. <rdar://problem/12002610>

4:25 PM Changeset in webkit [125620] by Lucas Forschler
  • 14 edits in branches/safari-536.26-branch/Source

Merged r124268. <rdar://problem/12002610>

4:21 PM Changeset in webkit [125619] by enne@google.com
  • 3 edits
    8 adds in trunk/LayoutTests

[chromium] Add baselines for video-controls-layer-creation layout test

Unreviewed expectation update.

  • compositing/video/video-controls-layer-creation-expected.txt: Added.
  • platform/chromium-linux/compositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/mac/TestExpectations:
4:17 PM Changeset in webkit [125618] by crogers@google.com
  • 3 edits in trunk/Source/WebKit/chromium

Implement new synchronized audio I/O render method in chromium
https://bugs.webkit.org/show_bug.cgi?id=93510

Reviewed by Kenneth Russell.

The chromium implementation of AudioDestination is being upgraded to
support synchronized audio I/O. Other changes on the chromium-side
can then be tested against something that works in WebKit.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::render):
(WebCore):
(WebCore::AudioDestinationChromium::provideInput):

  • src/AudioDestinationChromium.h:

(WebCore):
(AudioDestinationChromium):

4:16 PM Changeset in webkit [125617] by Alexandru Chiculita
  • 7 edits in trunk

Layout Test css3/filters/custom/custom-filter-animation.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91769

Reviewed by Dean Jackson.

Source/WebCore:

Mountain Lion added support for accelerated filter animations, but CSS Shaders are still
rendered in software mode. The setFilters method is using PlatformCALayer::filtersCanBeComposited to check
if the filters can be handled in hardwawre, so I've reused that in the createFilterAnimationsFromKeyframes
to check if the animations can also run in hardware.

Also the GraphicsContext3D doesn't update its own internal m_boundFBO when a framebuffer is deleted,
so I've added that to the FECustomFilter. Otherwise, if the next framebuffer is created using the same
identifier, bindFramebuffer will just return without calling the glBindFramebuffer because of this optimization.

The documentation for glDeleteFramebuffer says that the bound framebuffer is unbound before deleting it.
This is not reproduceable from WebGL, because WebGLRenderingContext::deleteFramebuffer
already knows to unbind the framebuffer when needed. However, I'm also adding that in GraphicsContext3DOpenGLCommon.cpp
and efl/GraphicsContext3DPrivate.cpp, to make sure that m_boundFBO is not used for other purposes.

No new tests, this patch fixes a failing test.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::deleteFramebuffer):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::deleteRenderBuffers):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::deleteFramebuffer):

LayoutTests:

The test should be passing on Mountain Lion now, so I'm removing it from the list.

  • platform/mac/TestExpectations:
3:47 PM Changeset in webkit [125616] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Merged r125319. <rdar://problem/12092509>

3:34 PM Changeset in webkit [125615] by abarth@webkit.org
  • 64 edits in trunk/Source

Delete Frame::domWindow() and Frame::existingDOMWindow()
https://bugs.webkit.org/show_bug.cgi?id=93990

Reviewed by Eric Seidel.

Source/WebCore:

These functions just call through to document()->domWindow(). This
patch updates the callers so it's clearer what's going on.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::shouldAllowAccessToFrame):
(WebCore::printErrorMessageForFrame):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::location):
(WebCore::JSDocument::setLocation):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createWindowShell):

  • bindings/objc/DOMAbstractView.mm:

(core):

  • bindings/v8/NPV8Object.cpp:

(WebCore::toV8Context):

  • bindings/v8/ScriptController.cpp:

(WebCore::createScriptObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::retrieveFrame):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):
(WebCore::V8Document::locationAccessorSetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

  • dom/Document.cpp:

(WebCore::printNavigationErrorMessage):

  • dom/ViewportArguments.cpp:

(WebCore::reportViewportWarning):

  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::insertDictatedText):

  • editing/Editor.cpp:

(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::pasteAsFragment):
(WebCore::Editor::setComposition):

  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::contentWindow):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::storageId):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::checkLoadComplete):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::checkIfDisplayInsecureContent):
(WebCore::FrameLoader::checkIfRunInsecureContent):
(WebCore::FrameLoader::reportLocalLoadFailed):
(WebCore::FrameLoader::prepareForCachedPageRestore):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::fireBeforeUnloadEvent):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::abort):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):
(WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::printAccessDeniedMessage):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::isCurrentlyDisplayedInFrame):
(WebCore::DOMWindow::self):
(WebCore::DOMWindow::opener):
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):

  • page/DOMWindowProperty.cpp:

(WebCore::DOMWindowProperty::DOMWindowProperty):
(WebCore::DOMWindowProperty::reconnectFrameFromPageCache):

  • page/DragController.cpp:

(WebCore::DragController::dispatchTextInputEventFor):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTextInputEvent):

  • page/Frame.cpp:
  • page/Frame.h:

(Frame):

  • page/Location.cpp:

(WebCore::Location::replace):
(WebCore::Location::reload):
(WebCore::Location::setLocation):

  • storage/StorageEventDispatcher.cpp:

(WebCore::StorageEventDispatcher::dispatch):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::reportMessage):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::parseString):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::docLoaderFunc):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTMessageHandler::handleMessage):

Source/WebKit/blackberry:

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::toOriginString):
(WebCore::ChromeClientBlackBerry::runJavaScriptAlert):
(WebCore::ChromeClientBlackBerry::runJavaScriptConfirm):
(WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
(WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
(WebCore::ChromeClientBlackBerry::requestWebGLPermission):

Source/WebKit/chromium:

  • src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::dispatchLocalStorageEvent):
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent):

  • src/WebDOMMessageEvent.cpp:

(WebKit::WebDOMMessageEvent::initMessageEvent):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::performance):
(WebKit::WebFrameImpl::addMessageToConsole):
(WebKit::WebFrameImpl::unloadListenerCount):
(WebKit::WebFrameImpl::addEventListener):
(WebKit::WebFrameImpl::removeEventListener):
(WebKit::WebFrameImpl::dispatchEvent):
(WebKit::WebFrameImpl::dispatchMessageEventWithOriginCheck):
(WebKit::WebFrameImpl::deliverIntent):

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initPage):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::pendingUnloadEventCount):

  • ewk/ewk_frame.cpp:

(ewk_frame_intent_deliver):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::getPendingUnloadEventCount):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _pendingFrameUnloadEventCount]):
(-[WebFrame _cacheabilityDictionary]):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::DOMWindow):
(WebFrame::pendingFrameUnloadEventCount):

Source/WebKit2:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::deliverIntent):
(WebKit::WebFrame::pendingUnloadCount):

3:27 PM Changeset in webkit [125614] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Tighten up parsing the 'script-nonce' CSP directive value.
https://bugs.webkit.org/show_bug.cgi?id=93783

Patch by Mike West <mkwst@chromium.org> on 2012-08-14
Reviewed by Adam Barth.

Source/WebCore:

Currently we're accepting any non-whitespace character. This patch
limits the valid characters to VCHAR minus ',' and ';', and pulls the
validity check out into a named function for clarity.

Test: http/tests/security/contentSecurityPolicy/1.1/scriptnonce-separators-allowed.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::parseScriptNonce):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-separators-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-separators-allowed.html: Added.
3:14 PM Changeset in webkit [125613] by abarth@webkit.org
  • 8 edits in trunk

Delete DOMWindow::m_url
https://bugs.webkit.org/show_bug.cgi?id=93989

Reviewed by Eric Seidel.

Source/WebCore:

There's no reason for DOMWindow to keep a separate copy of the
Document's URL now that there is a predictable way to get a Document
from a DOMWindow.

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::crossDomainAccessErrorMessage):

  • page/DOMWindow.h:

(DOMWindow):

LayoutTests:

The error messages for these tests now relect the document's updated
URL after document.write has changed the URL. Previously, we failed to
sync these changes to DOMWindow::m_url, which is why the error messages
showed the wrong URL.

  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
3:05 PM Changeset in webkit [125612] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

De-inline stuff from RenderStyle.h
https://bugs.webkit.org/show_bug.cgi?id=94019

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-14
Reviewed by Eric Seidel.

De-inline things from RenderStyle.h in preparation of fixing a series of
errant includes.

No new tests. Doesn't change functionality

  • WebCore.exp.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::listStyleImage):
(WebCore::RenderStyle::setListStyleImage):
(WebCore):
(WebCore::RenderStyle::color):
(WebCore::RenderStyle::visitedLinkColor):
(WebCore::RenderStyle::setColor):
(WebCore::RenderStyle::setVisitedLinkColor):
(WebCore::RenderStyle::horizontalBorderSpacing):
(WebCore::RenderStyle::verticalBorderSpacing):
(WebCore::RenderStyle::setHorizontalBorderSpacing):
(WebCore::RenderStyle::setVerticalBorderSpacing):
(WebCore::RenderStyle::font):
(WebCore::RenderStyle::fontMetrics):
(WebCore::RenderStyle::fontDescription):
(WebCore::RenderStyle::fontSize):
(WebCore::RenderStyle::wordSpacing):
(WebCore::RenderStyle::letterSpacing):
(WebCore::RenderStyle::setFontDescription):
(WebCore::RenderStyle::lineHeight):
(WebCore::RenderStyle::setLineHeight):
(WebCore::RenderStyle::computedLineHeight):
(WebCore::RenderStyle::setWordSpacing):
(WebCore::RenderStyle::setLetterSpacing):

  • rendering/style/RenderStyle.h:
3:02 PM Changeset in webkit [125611] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Checkerboard flashes on Go Back
https://bugs.webkit.org/show_bug.cgi?id=94018

Patch by Leo Yang <leoyang@rim.com> on 2012-08-14
Reviewed by Yong Li.
Reviewed internally by Yong Li.

The backing store need to be suspended before the
WebPagePrivate::restoreHistoryViewState() is called to avoid UI thread
drawing checkerboard.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

2:36 PM Changeset in webkit [125610] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

[CSSRegions]Region overset property is incorectly computed when content has negative letter spacing and is flowed near to the edge of a region
https://bugs.webkit.org/show_bug.cgi?id=92506

Patch by Andrei Onea <onea@adobe.com> on 2012-08-14
Reviewed by Eric Seidel.

Source/WebCore:

When the content which is flowed inside a region creates visual overflow in
the writing direction, the overflow rect is also extended in the other direction, and
that forces regionOverset to become "fit" for all regions.

Tests: fast/regions/element-region-overset-state-negative-letter-spacing.html

fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeOverflowStateForRegions):

LayoutTests:

Added tests for incorrect regionOverset computation when visual overflow in the writing direction creates
overset for all regions.

  • fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt: Added.
  • fast/regions/element-region-overset-state-negative-letter-spacing.html: Added.
  • fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Added.
  • fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing.html: Added.
2:35 PM Changeset in webkit [125609] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove unnecessary \n's from InputHandler log messages.
https://bugs.webkit.org/show_bug.cgi?id=94015

Reviewed by Rob Buis.

Remove many unnecessary \n's from the end of log messages.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertStringToWcharVector):
(BlackBerry::WebKit::convertSpannableStringToString):
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::setText):
(BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):

2:33 PM Changeset in webkit [125608] by fmalita@chromium.org
  • 4 edits
    2 adds in trunk

beginElement() does not observe updated animation attributes
https://bugs.webkit.org/show_bug.cgi?id=93972

Reviewed by Dirk Schulze.

Source/WebCore:

The SVG animation attributes 'from', 'to' and 'by' should be registered as supported
SVGSMILElement attributes in order to trigger animationAttributeChanged() on dynamic
updates.

Test: svg/animations/updated-attributes.html

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::updateAnimation):
Minor optimization - avoid recalculating animationMode().

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::isSupportedAttribute):
Register 'from', 'to' and 'by' as supported SVGSMILElement attributes.

LayoutTests:

  • svg/animations/updated-attributes-expected.txt: Added.
  • svg/animations/updated-attributes.html: Added.
2:33 PM Changeset in webkit [125607] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/1180

Merge 123822 - [Chromium] Regression: Global-buffer-overflow in WebCore::mediaControlElementType
BUG=132270
Review URL: https://chromiumcodereview.appspot.com/10827333

2:23 PM Changeset in webkit [125606] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Rebaseline fast/box-sizing/box-sizing.html and compositing/overflow/clip-descendents.html.
https://bugs.webkit.org/show_bug.cgi?id=93909

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-14
Reviewed by Tim Horton.

As per https://bugs.webkit.org/show_bug.cgi?id=92904 rebaselining those tests.

  • compositing/overflow/clip-descendents-expected.txt: Rebaselined.
  • platform/mac/TestExpectations: Removed tests from expectations list.
  • platform/mac/fast/box-sizing/box-sizing-expected.txt: Rebaselined.
2:20 PM Changeset in webkit [125605] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Don't crash on OOM in AC
https://bugs.webkit.org/show_bug.cgi?id=93999

Patch by Filip Spacek <fspacek@rim.com> on 2012-08-14
Reviewed by George Staikos.

Internally reviewed by George Staikos.

Fail gracefully in case we fail to allocate the bitmap
for the AC layer contents.

  • platform/graphics/blackberry/InstrumentedPlatformCanvas.h:

(WebCore::InstrumentedPlatformCanvas::InstrumentedPlatformCanvas):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::paintContents):

2:16 PM Changeset in webkit [125604] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

old-run-webkit-tests should skip all file extensions for ref tests, not just .html.
https://bugs.webkit.org/show_bug.cgi?id=93904

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-14
Reviewed by Tim Horton.

old-run-webkit-tests ref test only skipped .html test.
They need to skip .html, .shtml, .xml, .xhtml, .pl, .htm, .php, .svg, .mht.

  • Scripts/old-run-webkit-tests:

(isUsedInReftest): Skip all extensions for ref tests.

2:11 PM Changeset in webkit [125603] by commit-queue@webkit.org
  • 71 edits in trunk

Convert signals/slots to Q_* macros.

[Qt] Use Q_SLOTS and Q_SIGNALS instead of slots and signals
https://bugs.webkit.org/show_bug.cgi?id=93996

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Change usage of keyword-conflicting 'signals' and 'slots' for
Q_SIGNALS and Q_SLOTS macro.

Source/WebCore:

  • bridge/testqtbindings.cpp:

(MyObject):

  • platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:

(MediaPlayerPrivateQt):

  • platform/network/qt/DnsPrefetchHelper.h:

(DnsPrefetchHelper):

  • platform/network/qt/NetworkStateNotifierPrivate.h:

(NetworkStateNotifierPrivate):

  • platform/network/qt/QNetworkReplyHandler.h:

(QNetworkReplyHandler):

  • platform/network/qt/QtMIMETypeSniffer.h:

(QtMIMETypeSniffer):

  • platform/network/qt/SocketStreamHandlePrivate.h:

(SocketStreamHandlePrivate):

  • platform/qt/GamepadsQt.cpp:

(GamepadDeviceLinuxQt):
(GamepadsQt):

  • platform/qt/SharedTimerQt.cpp:

(SharedTimerQt):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

  • WebCoreSupport/FullScreenVideoQt.h:

(FullScreenVideoQt):

  • WebCoreSupport/FullScreenVideoWidget.h:

(FullScreenVideoWidget):

  • WebCoreSupport/IconDatabaseClientQt.h:

(IconDatabaseClientQt):

  • WebCoreSupport/InspectorClientQt.cpp:

(InspectorClientWebPage):

  • WebCoreSupport/InspectorServerQt.h:

(InspectorServerQt):
(InspectorServerRequestHandlerQt):

  • WebCoreSupport/PopupMenuQt.h:

(PopupMenuQt):

  • WebCoreSupport/QtFallbackWebPopup.h:

(QtFallbackWebPopup):

  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp:

(wrapInFunction):

  • docs/webkitsnippets/webpage/main.cpp:

(Thumbnailer):

  • examples/platformplugin/WebPlugin.h:

(Popup):
(WebPopup):

  • tests/benchmarks/webgl/tst_webgl.cpp:

(tst_WebGlPerformance):

  • tests/hybridPixmap/tst_hybridPixmap.cpp:

(tst_hybridPixmap):

  • tests/hybridPixmap/widget.h:

(Widget):

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView):

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView):
(WebPage):
(ResizeSpy):

  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(MyWebElementSlotOnlyObject):
(tst_QObjectBridge):
(TestPluginWidget):

  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement):

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame):
(FakeReply):

  • tests/qwebhistory/tst_qwebhistory.cpp:
  • tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp:

(tst_QWebHistoryInterface):

  • tests/qwebinspector/tst_qwebinspector.cpp:

(tst_QWebInspector):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage):
(JSTestPage):
(RepaintRequestedRenderer):
(SpyForLoadSignalsOrder):

  • tests/qwebplugindatabase/tst_qwebplugindatabase.cpp:

(tst_QWebPluginDatabase):

  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView):
(WebViewCrashTest):

Source/WebKit2:

  • UIProcess/API/qt/qwebkittest_p.h:
  • UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp:

(tst_InspectorServer):

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:

(tst_publicapi):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):

  • UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:

(WebView):
(tst_qrawwebview):

  • UIProcess/API/qt/tests/util.cpp:

(LoadSpy):

  • UIProcess/API/qt/tests/util.h:

(LoadStartedCatcher):

  • UIProcess/InspectorServer/qt/WebSocketServerQt.h:

(QtTcpServerHandler):

  • UIProcess/qt/QtDialogRunner.cpp:

(DialogContextBase):
(DialogContextObject):
(BaseAuthenticationContextObject):
(CertificateVerificationDialogContextObject):
(FilePickerContextObject):
(DatabaseQuotaDialogContextObject):

  • UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

  • WebProcess/Downloads/qt/QtFileDownloader.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(NetworkAccessManager):
(WebPage):

  • DumpRenderTree/qt/EventSenderQt.h:

(EventSender):

  • DumpRenderTree/qt/GCControllerQt.h:

(GCController):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/qt/TextInputControllerQt.h:

(TextInputController):

  • MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions):

  • MiniBrowser/qt/UrlLoader.h:

(UrlLoader):

  • QtTestBrowser/cookiejar.h:

(TestBrowserCookieJar):

  • QtTestBrowser/fpstimer.h:

(FpsTimer):

  • QtTestBrowser/launcherwindow.h:

(LauncherWindow):

  • QtTestBrowser/locationedit.h:

(LocationEdit):

  • QtTestBrowser/mainwindow.h:

(MainWindow):

  • QtTestBrowser/urlloader.h:

(UrlLoader):

  • QtTestBrowser/webinspector.h:

(WebInspector):

  • QtTestBrowser/webpage.h:

(WebPage):

  • QtTestBrowser/webview.h:

(WebViewGraphicsBased):

  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:

(WatchdogTimerHelper):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WrapperWindow):

  • WebKitTestRunner/qt/main.cpp:

(Launcher):

2:06 PM Changeset in webkit [125602] by ap@apple.com
  • 6 edits in trunk/Source/WebKit2

[WK2] Track multiple Web Processes per context
https://bugs.webkit.org/show_bug.cgi?id=93915

Reviewed by Sam Weinig.

  • UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::didReceiveAuthenticationChallenge): Downloads don't work yet, added a FIXME.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::deprecatedSharedProcess): Renamed from process(), added an assertion that this is only used in single proces mode. (WebKit::WebContext::textCheckerStateChanged): Abstract out access to web processes. (WebKit::WebContext::ensureSharedWebProcess): Renamed ensureWebProcess() for clarity. (WebKit::WebContext::createNewWebProcess): Extracted code for creating a process from ensureWebProcess(). (WebKit::WebContext::warmInitialProcess): Create the process more explicitly. (WebKit::WebContext::enableProcessTermination): Iterate over all processes. (WebKit::WebContext::shouldTerminate): Updated assertion. (WebKit::WebContext::processDidFinishLaunching): Changed to use process argument instead of m_process. (WebKit::WebContext::disconnectProcess): Updated code forto use m_processes. (WebKit::WebContext::createWebPage): Handle both process policies (initial support for multi-process). (WebKit::WebContext::relaunchProcessIfNecessary): Added cases for both policies. (WebKit::WebContext::download): Ditto. (WebKit::WebContext::postMessageToInjectedBundle): Ditto. (WebKit::WebContext::didReceiveSyncMessage): Fixed whitespace. (WebKit::WebContext::getWebCoreStatistics): Added cases for both policies.
  • UIProcess/WebContext.h: (WebKit::WebContext::sendToAllProcesses): (WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary): Send to all processes. Changed return type to void, since no caller checked it.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::createWebPage): Removed an assertion that assumed one process per context.
  • UIProcess/WebTextChecker.cpp: (WebKit::updateStateForAllWebProcesses): Updated to use a WebContext method.
2:02 PM Changeset in webkit [125601] by tsepez@chromium.org
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION r125500: 7 tests crashing on Mac bots
https://bugs.webkit.org/show_bug.cgi?id=93970

Reviewed by Eric Seidel.

Make WebFrameLoaderClient::redirectDataToPlugin expect the now real possibility
of a NULL pluginWidget argument.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::redirectDataToPlugin)

1:53 PM Changeset in webkit [125600] by commit-queue@webkit.org
  • 7 edits in trunk

[CSSRegions]regionOverset is computed as "overset" even though the region is not the last in the chain
https://bugs.webkit.org/show_bug.cgi?id=93102

Patch by Andrei Onea <onea@adobe.com> on 2012-08-14
Reviewed by Eric Seidel.

Source/WebCore:

Making Element.webkitRegionOverset return "overset" only for the last region in a region chain,
if the content cannot fit inside it, to reflect current spec. http://www.w3.org/TR/css3-regions/#dom-region-regionoverset

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeOverflowStateForRegions):

LayoutTests:

Modified existing tests to reflect spec, where Element.webkitRegionOverset can be
"overset" only for the last region in a region chain, if the content cannot fit inside it.

  • fast/regions/element-region-overset-state-expected.txt:
  • fast/regions/element-region-overset-state-vertical-rl-expected.txt:
  • fast/regions/element-region-overset-state-vertical-rl.html:
  • fast/regions/element-region-overset-state.html:
1:47 PM Changeset in webkit [125599] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Render breakpoint gutter markers and execution line in CodeMirrorTextEditor
https://bugs.webkit.org/show_bug.cgi?id=93686

Patch by Jan Keromnes <janx@linux.com> on 2012-08-14
Reviewed by Pavel Feldman.

Divided TextEditor.addDecoration into addBreakpoint, setExecutionLine
and addDecoration. Same for removeDecoration. Render breakpoint
markers and execution line in CodeMirrorTextEditor.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype._onGutterClick):
(WebInspector.CodeMirrorTextEditor.prototype.addBreakpoint):
(WebInspector.CodeMirrorTextEditor.prototype.removeBreakpoint):
(WebInspector.CodeMirrorTextEditor.prototype.setExecutionLine):
(WebInspector.CodeMirrorTextEditor.prototype.clearExecutionLine):
(WebInspector.CodeMirrorTextEditor.prototype.addDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.removeDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.highlightLine):
(WebInspector.CodeMirrorTextEditor.prototype.clearLineHighlight):
(WebInspector.CodeMirrorTextEditor.prototype.removeAttribute):

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._onMouseDown):
(WebInspector.DefaultTextEditor.prototype.addBreakpoint):
(WebInspector.DefaultTextEditor.prototype.removeBreakpoint):
(WebInspector.DefaultTextEditor.prototype.setExecutionLine):
(WebInspector.DefaultTextEditor.prototype.clearExecutionLine):
(WebInspector.DefaultTextEditor.prototype.addDecoration):
(WebInspector.DefaultTextEditor.prototype.removeDecoration):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype._handleGutterClick):

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.addBreakpoint):
(WebInspector.TextEditor.prototype.removeBreakpoint):
(WebInspector.TextEditor.prototype.setExecutionLine):
(WebInspector.TextEditor.prototype.clearExecutionLine):
(WebInspector.TextEditor.prototype.addDecoration):
(WebInspector.TextEditor.prototype.removeDecoration):

  • inspector/front-end/cmdevtools.css:

(.CodeMirror):
(.cm-highlight):
(@-webkit-keyframes fadeout):
(to):
(.cm-breakpoint):
(.cm-breakpoint-disabled):
(.cm-breakpoint-conditional):
(.cm-execution-line):
(.webkit-html-message-bubble):
(.webkit-html-warning-message):
(.webkit-html-error-message):
(.webkit-html-message-line):
(.webkit-html-message-line-hover):

1:45 PM Changeset in webkit [125598] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Queue spellcheck requests with char-count limitations
https://bugs.webkit.org/show_bug.cgi?id=93866

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-08-14
Reviewed by Rob Buis.

PR184196
Making spellcheck a little more granular so as to work around
the limitations of the inputservice.
Also, spellcheck the entire field on focus only if
spellcheck="on" is explicitly set.

Internally reviewed by Mike Fenton.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):

1:44 PM Changeset in webkit [125597] by enne@google.com
  • 5 edits
    1 add in trunk

REGRESSION (r109851): Video controls do not render
https://bugs.webkit.org/show_bug.cgi?id=93859

Reviewed by Simon Fraser.

Source/WebCore:

Because video layers can't act as an ancestor composited layer whose
backing can be shared by child layers, any child layer of a video
layer needs to be put into its own composited layer. Because this is
technically overlap, the "overlap" indirect compositing reason is
reused for this case.

Test: compositing/video/video-controls-layer-creation.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

LayoutTests:

Convert jernoble's test into a layout test.

  • compositing/video/video-controls-layer-creation.html: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
1:30 PM Changeset in webkit [125596] by robert@webkit.org
  • 5 edits in trunk/LayoutTests

Update Test Expectations to consolidate bug refs for new tests added
with r125578.

Unreviewed gardening.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
1:06 PM Changeset in webkit [125595] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark css2.1/20110323/c541-word-sp-000.htm as failing on Windows Chromium
https://bugs.webkit.org/show_bug.cgi?id=94017

Unreviewed gardening. Expectation update.

  • platform/chromium/TestExpectations:
1:02 PM Changeset in webkit [125594] by robert@webkit.org
  • 5 edits in trunk/LayoutTests

Update Test Expectations after r125578

Unreviewed gardening.

  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
12:49 PM Changeset in webkit [125593] by commit-queue@webkit.org
  • 17 edits in trunk

WebKitTestRunner needs layoutTestController.dumpResourceLoadCallbacks
https://bugs.webkit.org/show_bug.cgi?id=42332

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Provide build for mac.

  • WebCore.exp.in: Added ZNK7WebCore19ResourceRequestBase20firstPartyForCookiesEv.

Source/WebKit2:

Added new getters to WKURL, WKURLRequest, WKURLResponse so that it is possible
to dump information necessary for the tests passing.

  • Shared/API/c/WKURL.cpp:

(WKURLCopyPath):

  • Shared/API/c/WKURL.h:
  • Shared/API/c/WKURLRequest.cpp:

(WKURLRequestCopyFirstPartyForCookies):
(WKURLRequestCopyHTTPMethod):

  • Shared/API/c/WKURLRequest.h:
  • Shared/API/c/WKURLResponse.cpp:

(WKURLResponseHTTPStatusCode):

  • Shared/API/c/WKURLResponse.h:
  • Shared/WebURL.h:

(WebKit::WebURL::path):
(WebURL):

Tools:

Added Resource Callbacks logging. Several aux dumping functions are added.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::isFileScheme):
(WTR):
(WTR::pathSuitableForTestResult):
(WTR::urlSuitableForTestResult):
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::dumpRequestDescriptionSuitableForTestResult):
(WTR::dumpResponseDescriptionSuitableForTestResult):
(WTR::dumpErrorDescriptionSuitableForTestResult):
(WTR::InjectedBundlePage::didInitiateLoadForResource):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::didReceiveResponseForResource):
(WTR::InjectedBundlePage::didFinishLoadForResource):
(WTR::InjectedBundlePage::didFailLoadForResource):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpResourceLoadCallbacks):
(WTR::LayoutTestController::shouldDumpResourceLoadCallbacks):
(LayoutTestController):

LayoutTests:

Unskipped correspondong test cases.

  • platform/wk2/Skipped:
12:47 PM Changeset in webkit [125592] by abarth@webkit.org
  • 29 edits
    1 delete in trunk

DOMWindow::document() should not reach through Frame
https://bugs.webkit.org/show_bug.cgi?id=27640

Reviewed by Eric Seidel.

Source/WebCore:

Originally, the lifetime of DOMWindow was similar to that of Frame in
that it was reused for each document that was displayed in the Frame.
To fix some tricky security issues, all modern browsers use a "split
window" architecture whereby the DOMWindow is not reused by each
Document in a Frame. Instead a JavaScript "window shell" object
redirects JavaScript references to the active Document's DOMWindow.

When we implemented split windows, we left DOMWindow attached to the
Frame and attempted to keep it in sync with the Document via a lot of
delicate code. One of the main problems with this approach is that
finding the DOMWindow associated with a Document or the Document
associated with a DOMWindow required traversing through the Frame.
Because there is a many-to-one relationship between both Documents and
Frames (as well as DOMWindows and Frames), this traversal is error
prone and not always available (e.g., for inactive documents).

This patch moves the "owning" reference for DOMWindow to Document so
that we can directly traverse from Document to DOMWindow. For
traversing from DOMWindow to Document, each DOMWindow keeps a Document
pointer via a ContextDestructionObserver base class.

The main sublties in this patch are related to situations in which
there isn't precisely a one-to-one relationship between Documents and
DOMWindows. Previously, these situations were handled implicitly by the
"flex and slop" of having separate Document and DOMWindow pointers in
Frame. In this patch, these sublties are made explicit via
Document::takeDOMWindowFrom, which explicitly transfers the DOMWindow
(as well as ASSERTs that all the relevant objects exist in a sensible
constellation).

  • WebCore.exp.in:
    • These functions are no longer exported because they're inline.
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::clearWindowShell):

  • bindings/js/ScriptController.h:

(ScriptController):

  • clearWindowShell now explicitly takes the new DOMWindow that will be pointed to by the WindowShell. Previously, clearWindowShell would implicitly create the new DOMWindow by accessing Frame::domWindow (which used to lazily create the DOMWindow).
  • bindings/v8/BindingState.cpp:

(WebCore::currentDocument):

  • bindings/v8/BindingState.h:

(WebCore):

  • currentDocument provides a directly path from the current v8::Context to the Document (by way of DOMWindow). Previously, code transited via the Frame using currentFrame.
  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearWindowShell):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • Mirror JSC changes to clearWindowShell.
  • bindings/v8/V8Utilities.cpp:

(WebCore::getScriptExecutionContext):

  • Update getScriptExecutionContext to transit directly from the DOMWindow to the Document rather than detouring via the Frame.
  • dom/ContextDestructionObserver.cpp:

(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore):
(WebCore::ContextDestructionObserver::observeContext):

  • dom/ContextDestructionObserver.h:

(ContextDestructionObserver):

  • When we transfer a DOMWindow from one Document to another, we need to update the Document pointer in the DOMWindow to point to the new Document. The DOMWindow holds the Document pointer via ContextDestructionObserver, so this patch teaches ContextDestructionObserver how to change which ScriptExecutionContext it is observing. This code mirrors similar code in FrameDestructionObserver.
  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::detach):
(WebCore::Document::createDOMWindow):

  • createDOMWindow now explicitly creates the DOMWindow. Previously, we created the DOMWindow implicitly in Frame::domWindow when it was first accessed.

(WebCore::Document::takeDOMWindowFrom):

  • takeDOMWindowFrom explicitly transfers the DOMWindow from one Document to another. The main benefit of this function is the ASSERTs that ensure that the Document, DOMWindow, and Frame all point to each other the correct configuration.

(WebCore::Document::didUpdateSecurityOrigin):

  • We no longer need to keep the SecurityOrigin pointer in DOMWindow in sync with the Document because DOMWindow no longer has a SecurityOrigin object.
  • dom/Document.h:

(Document):
(WebCore::Document::domWindow):

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::destroy):

  • history/CachedFrame.h:

(CachedFrameBase):

  • Previously, CachedFrame held the Document and the DOMWindow with separate pointers. Now, the CachedFrame holds the DOMWnidow via the Document, which makes adding and removing Documents from the PageCache simpler because we don't need to keep the Frame's DOMWindow pointer synchronized.
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • begin now explicitly creates the DOMWindow and transfers DOMWindow when performing a "secure transition." Previously, both of these processes were handled implicitly: the DOMWindow was created implicitly by Frame::domWindow, and the DOMWindow was reused during navigation by not clearing Frame::m_domWindow.
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::cancelAndClear):
(WebCore::FrameLoader::clear):

  • These functions now pass the new Document so that we have access to the new DOMWindow in clearDOMWindowShell.

(WebCore::FrameLoader::setOpener):

  • We no longer need to keep the DOMWindow's SecurityOrigin in sync with the Document's SecurityOrigin because DOMWindow no longer has a duplicate SecurityOrigin pointer.

(WebCore::FrameLoader::open):

  • We no longer need to keep the Frame::m_domWindow in sync with the Document because the Document carries its own DOMWindow.
  • loader/FrameLoader.h:

(FrameLoader):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::DOMWindow):

  • DOMWindow now uses Document as its primary context object. In a future patch, we should remove the FrameDestructionObserver base class and instead access the frame via DOMWindow::document().

(WebCore::DOMWindow::didSecureTransitionTo):

  • Notify the DOMWindow that it is now associated with a new Document.

(WebCore::DOMWindow::scriptExecutionContext):
(WebCore::DOMWindow::document):
(WebCore::DOMWindow::securityOrigin):

  • These functions now retrieve the Document directly rather than transiting via the Frame.
  • page/DOMWindow.h:

(WebCore::DOMWindow::create):
(DOMWindow):

  • page/Frame.cpp:

(WebCore::Frame::setDocument):

  • Add more ASSERTs that the Document and its DOMWindow are properly wired up to this Frame.

(WebCore::Frame::domWindow):

  • Rather than lazily creating the DOMWindow, this function now just accesses the already-created DOMWindow on Document. Eventually, all callers should retreive the DOMWindow from the Document directly.
  • page/Frame.h:

(WebCore::Frame::existingDOMWindow):

  • The DOMWindow always exists, so there is no distinction between domWindow() and existingDOMWindow().
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):

  • Previously, open would exit early if it was unable to find its ScriptExecutionContext (e.g., if the ScriptExecutionContext was inactive). Now we can always locate the ScriptExecutionContext and so we need to test whether the ScriptExecutionContext is still attached to the Page before accessing Settings. Tests verify that the platform-visible behaviors of XMLHttpRequest are unchanged, even for XMLHttpRequest constructors associated with inactive Documents.
  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

  • Make it explicit that XSLT re-uses the DOMWindow from the source Document in the transformed Document.

LayoutTests:

  • fast/dom/Window/timer-null-script-execution-context.html:
    • This test was assuming that we'd throw an exception when we failed to find the script execution context. Now that we are always able to find the script execution context, we never throw that exception, even after GC. As far as I can tell, the original intent of the test was to make sure we don't crash in that case, which of course we don't.
  • fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt:
    • Remove warning message about not being able to find the script execution context. We can now always find the script execution context.
  • http/tests/security/MessagePort/event-listener-context-expected.txt:
  • http/tests/security/MessagePort/event-listener-context.html:
    • This test is attempting to check that MessagePorts behave in a reasonable way when created in inactive documents. The test relies on us throwing an exception in the inactive case because we're unable to find the script execution context. We are now able to find the script execution context (as above), so we no longer throw the exception. It's not clear whether this test is valuable any more, but I've converted it to be a test that we don't crash in this situation.
  • platform/chromium/fast/dom/xmlhttprequest-constructor-in-detached-document-expected.txt: Removed.
    • Remove platform-specific result as it now matches the cross-platform result.
12:45 PM Changeset in webkit [125591] by leviw@chromium.org
  • 4 edits
    2 adds in trunk

Accumulating LayoutUnits with floats for determining block preferred width can lead to wrapping
https://bugs.webkit.org/show_bug.cgi?id=93513

Reviewed by Eric Seidel.

Source/WebCore:

Sub-pixel values from floats are subject to small losses in precision when accumulated with
floating point values, as we do in RenderBlock. This patch adds a new method to FractionalLayoutUnit --
ceilToFloat -- which guarantees us a floating point value at least as big as our original LayoutUnit
value, and uses it along with ceiledLayoutUnit to avoid underprovisioning RenderBlock's preferred
widths due to lost precision.

Test: fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::ceilToFloat): Returns a float value the same or larger than the
FractionalLayoutUnit value.
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::epsilon): Now returns 0 when sub-pixel is disabled.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat): Adding a LayoutUnit::epsilon fudge factor
for fitting floats. This is probably necessary due to precision being lost elsewhere.
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths): Ensure no precision is lost due to conversion
when accumulating our min/max width with floats.

LayoutTests:

Ensuring floats with sub-pixel values don't unnecessarily wrap.

  • fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats-expected.txt: Added.
  • fast/sub-pixel/block-preferred-widths-with-sub-pixel-floats.html: Added.
12:38 PM Changeset in webkit [125590] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

Fullscreen/normal volume sliders don't stay in sync
https://bugs.webkit.org/show_bug.cgi?id=93867

Reviewed by Eric Carlson.

Source/WebCore:

Change the full screen volume slider, if present, when the media element's volume
changes.

Test: media/video-controls-fullscreen-volume.html

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::changedVolume):

LayoutTests:

New test checking that volume changes in the media element are reflected in the full
screen volume slider.

  • media/video-controls-fullscreen-volume-expected.txt: Added.
  • media/video-controls-fullscreen-volume.html: Added.
  • platform/chromium/TestExpectations: Skip this test on chromium.
12:17 PM Changeset in webkit [125589] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused yyparse method in CSSParser
https://bugs.webkit.org/show_bug.cgi?id=93986

Patch by Olivier Blin <Olivier Blin> on 2012-08-14
Reviewed by Darin Adler.

This method is unused and not even declared.

No new tests, it just removes unused code.

  • css/CSSParser.h:
12:02 PM Changeset in webkit [125588] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use Form helper functions to determine state in DOMSupport::isTextBasedContentEditableElement
https://bugs.webkit.org/show_bug.cgi?id=93992

Reviewed by Antonio Gomes.

Use form control helper functions to determine the editable state
of the input field.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):

11:54 AM Changeset in webkit [125587] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/regex/unicodeCaseInsensitive.html expectation as crashing
https://bugs.webkit.org/show_bug.cgi?id=94010

Unreviewed gardening. Update expectations.

  • platform/chromium/TestExpectations:
11:53 AM Changeset in webkit [125586] by robert@webkit.org
  • 6 edits in trunk/LayoutTests

Update Test Expectations after r125578

Unreviewed gardening.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/Skipped:
  • platform/qt/TestExpectations:
11:28 AM Changeset in webkit [125585] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use constructor to initialize rect in TouchEventHandler::drawTapHighlight()
https://bugs.webkit.org/show_bug.cgi?id=93988

Reviewed by Antonio Gomes.

Use constructor to initialize rect in TouchEventHandler::drawTapHighlight()

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

11:23 AM Changeset in webkit [125584] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix use of endsWith to use string instead of char.
https://bugs.webkit.org/show_bug.cgi?id=93994

Reviewed by Antonio Gomes.

Regex comparison should use string instead of char comparison.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::elementPatternMatches):

10:58 AM Changeset in webkit [125583] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

[Gtk] Include all files guarded by ENABLE_* guards in Source/WebCore/GNUmakefile.list.am into the build
https://bugs.webkit.org/show_bug.cgi?id=90696

Reviewed by Philippe Normand.

Include all files in the Autotools build that are currently guarded by ENABLE_* guards in
the WebCore GNUmakefile.list.am, regardless of the feature being enabled. Compilation should
rely on proper use of guards inside source files and preprocessor work to keep the disabled
features out.

The only exception left is the ENABLE_WEBGL guard that includes the ANGLE into compilation
only if WebGL feature is enabled.

No new tests - no new functionality.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • bindings/gobject/GNUmakefile.am: Add StorageInfo to the DOM bindings, despite

the feature being currently disabled.

10:58 AM Changeset in webkit [125582] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark inspector/debugger tests as flaky timeout on Win7
https://bugs.webkit.org/show_bug.cgi?id=94002

Unreviewed gardening. Update expectations.

  • platform/chromium/TestExpectations:
10:55 AM Changeset in webkit [125581] by commit-queue@webkit.org
  • 2 edits
    4 adds in trunk/Source/WebKit/chromium

[chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint.
https://bugs.webkit.org/show_bug.cgi?id=93108

Patch by Iain Merrick <husky@chromium.org> on 2012-08-14
Reviewed by Adam Barth.

Adds a new test WebFrameTest.SelectRange. This tests WebFrameImpl::selectRange,
and also serves to test WebFrameImpl::visiblePositionForWindowPoint as it is
used by selectRange.

The test uses sample files that contain selected text on load. The test uses
WebViewImpl::selectionBounds to get the coordinates, deselects all, then
calls WebFrameImpl::selectRange to attempt to reselect the same text.

Four cases are tested:

  • the basic case
  • the case where the selected text is offscreen due to a scroll
  • the case where the selected text is in an iframe
  • the case where the selected text is in an editable element
  • tests/WebFrameTest.cpp:
  • tests/data/select_range_basic.html: Added.
  • tests/data/select_range_editable.html: Added.
  • tests/data/select_range_iframe.html: Added.
  • tests/data/select_range_scroll.html: Added.
10:51 AM Changeset in webkit [125580] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Plumb through EXT_debug_marker entry points
https://bugs.webkit.org/show_bug.cgi?id=93860

Patch by Gregg Tavares <gman@google.com> on 2012-08-14
Reviewed by Kenneth Russell.

Source/Platform:

insertEventMarkerEXT, pushGroupMarkerEXT, popGroupMarkerEXT are
all entry points exposed by the OpenGL ES EXT_debug_marker
extension.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::insertEventMarkerEXT):
(WebKit::WebGraphicsContext3D::pushGroupMarkerEXT):
(WebKit::WebGraphicsContext3D::popGroupMarkerEXT):

Source/WebCore:

insertEventMarkerEXT, pushGroupMarkerEXT, popGroupMarkerEXT,
are all entry points exposed by the OpenGL ES
EXT_debug_marker extension

No new tests as no new functionality exposed to web.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

  • platform/chromium/support/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::insertEventMarkerEXT):
(WebCore):
(WebCore::Extensions3DChromium::pushGroupMarkerEXT):
(WebCore::Extensions3DChromium::popGroupMarkerEXT):

  • platform/graphics/Extensions3D.h:

(Extensions3D):

  • platform/graphics/chromium/Extensions3DChromium.h:

(Extensions3DChromium):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::insertEventMarkerEXT):
(WebCore):
(WebCore::Extensions3DOpenGL::pushGroupMarkerEXT):
(WebCore::Extensions3DOpenGL::popGroupMarkerEXT):

  • platform/graphics/opengl/Extensions3DOpenGL.h:

(Extensions3DOpenGL):

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:

(WebCore::Extensions3DOpenGLES::insertEventMarkerEXT):
(WebCore):
(WebCore::Extensions3DOpenGLES::pushGroupMarkerEXT):
(WebCore::Extensions3DOpenGLES::popGroupMarkerEXT):

  • platform/graphics/opengl/Extensions3DOpenGLES.h:

(Extensions3DOpenGLES):

10:46 AM Changeset in webkit [125579] by shawnsingh@chromium.org
  • 2 edits in branches/chromium/1229/Source

Merge 125486 - [chromium] renderSurface in incorrect space if owning layer has empty but non-zero bounds
https://bugs.webkit.org/show_bug.cgi?id=93795

Reviewed by Adrienne Walker.

Source/WebCore:

If a renderSurface is created by a layer that had zero
area (empty) but non-zero bounds (either width or height was
non-zero), then one translation transform was accidentally being
skipped, causing the renderSurface drawTransform to be incorrect.
The fix is simply to move that transform outside of the
if-statement so it is not skipped.

Unit test added:

CCLayerTreeHostCommonTest.verifyTransformsForDegenerateIntermediateLayer()

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829322

10:36 AM Changeset in webkit [125578] by robert@webkit.org
  • 14 edits
    1 move
    25 adds
    27 deletes in trunk

CSS 2.1 failure: Word-spacing affects each space and non-breaking space
https://bugs.webkit.org/show_bug.cgi?id=89826

Reviewed by Eric Seidel.

Source/WebCore:

Add word spacing to consecutive spaces in a run per http://www.w3.org/TR/CSS21/text.html#spacing-props.

Test: fast/css/word-spacing-characters.html

fast/css/word-spacing-characters-complex-text.html
fast/css/word-spacing-characters-linebreak.html
css2.1/20110323/word-spacing-characters-002.htm
css2.1/20110323/word-spacing-characters-003.htm
css2.1/20110323/word-spacing-remove-space-001.htm
css2.1/20110323/word-spacing-remove-space-002.htm
css2.1/20110323/word-spacing-remove-space-003.htm
css2.1/20110323/word-spacing-remove-space-004.htm
css2.1/20110323/word-spacing-remove-space-005.htm
css2.1/20110323/word-spacing-remove-space-006.htm
css2.1/20110323/c541-word-sp-001.htm
css2.1/20110323/c541-word-sp-000.htm

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance): All spaces (ordinary space or &nbsp;) get word-spacing added, even

if they are consecutive.

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::HarfBuzzShaperBase::isWordEnd): ditto, but for the complex text case on Chromium. Had to use

m_run rather than m_normalizedBuffer here as m_normalizedBuffer turns tabs into spaces! Unlike the simple
text path, '\n' gets word-spacing - I observed this from fast/text/atsui-spacing-features.html but can't
find it specified anywhere.

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.h:

(WebCore::HarfBuzzShaperBase::isCodepointSpace):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Tested by word-spacing-linebreak.html

LayoutTests:

  • css2.1/20110323/c541-word-sp-000-expected.html: Added.
  • css2.1/20110323/c541-word-sp-000.htm: Renamed from LayoutTests/css2.1/t1604-c541-word-sp-00-b-a.html.
  • css2.1/20110323/c541-word-sp-001-expected.html: Added.
  • css2.1/20110323/c541-word-sp-001.htm: Added. Replaces t1604-c541-word-sp-01-b-a.html below.
  • css2.1/20110323/word-spacing-characters-002-expected.html: Added.
  • css2.1/20110323/word-spacing-characters-002.htm: Added.
  • css2.1/20110323/word-spacing-characters-003-expected.html: Added.
  • css2.1/20110323/word-spacing-characters-003.htm: Added. These passed already.
  • css2.1/20110323/word-spacing-remove-space-001-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-001.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-002-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-002.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-003-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-003.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-004-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-004.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-005-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-005.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-006-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-006.htm: Added. These 6 tests are fixed by this patch.
  • css2.1/t1604-c541-word-sp-01-b-a.html: Removed. Per http://lists.w3.org/Archives/Public/public-css-testsuite/2010Jan/0029.html t1604-c541-word-sp-01-b-a.htm is now invalid and has been replaced by c541-word-sp-001.htm above.
  • fast/css/word-spacing-characters-complex-text-expected.html: Added.
  • fast/css/word-spacing-characters-complex-text.html: Added. This is a complex text version of word-spacing-characters-001.htm
  • fast/css/word-spacing-characters-expected.html: Added.
  • fast/css/word-spacing-characters.html: Added. The original test (word-spacing-characters-001.htm) has two spaces between the non-breaking spaces in the second last case. This causes WebKit to split the text into two-runs and drop the second of the two spaces. This entire test can be replaced with word-spacing-characters-001.htm from the css test suite when https://bugs.webkit.org/show_bug.cgi?id=89827 is fixed.
  • fast/css/word-spacing-linebreak-expected.html: Added.
  • fast/css/word-spacing-linebreak.html: Added.
  • platform/chromium-linux/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/chromium-linux/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
  • platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-linux/fast/css/word-space-extra-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/chromium-win/fast/css/word-space-extra-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/efl/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
  • platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/gtk/TestExpectations:
  • platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
  • platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/qt/TestExpectations:
  • platform/qt/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/win/Skipped:
10:25 AM Changeset in webkit [125577] by piman@chromium.org
  • 11 edits in trunk/Source

[chromium] race between CCLayerTreeHostImpl::releaseContentsTextures and CCThreadProxy::beginFrameCompleteOnImplThread
https://bugs.webkit.org/show_bug.cgi?id=93684

Reviewed by James Robinson.

This keeps track of whether we're between the beginFrame post and the
commit when releaseContentsTextures comes, and if that is the case, we
prune the texture uploads, keep the "textures purged" flag on and kick a
new commit.

Added CCLayerTreeHostTestEvictTextures test.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::beginFramePosted):
(WebCore):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::contentsTexturesPurged):
(WebCore::CCLayerTreeHostImpl::contentsTexturesWerePurgedSinceLastBeginFrame):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCTextureUpdateController.h:

(CCTextureUpdateController):

  • platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp:

(WebCore::CCTextureUpdateQueue::clearUploads):
(WebCore):

  • platform/graphics/chromium/cc/CCTextureUpdateQueue.h:

(CCTextureUpdateQueue):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):

10:19 AM Changeset in webkit [125576] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

[BlackBerry] Pass URL String's 8-bit buffer directly to platform layer when possible
https://bugs.webkit.org/show_bug.cgi?id=93861

Patch by Yong Li <yoli@rim.com> on 2012-08-14
Reviewed by Rob Buis.

PR# 187605.
URL strings and HTTP header strings usually use 8-bit buffers internally. We can
just pass the buffers to platform calls when only Latin1 strings are needed.

  • platform/blackberry/ReadOnlyLatin1String.h: Added.

(WebCore):
(ReadOnlyLatin1String): A utility class that uses either WTF::CString or WTF::String's 8-bit buffer.
(WebCore::ReadOnlyLatin1String::ReadOnlyLatin1String): Can only be constructed with WTF::String for now.
(WebCore::ReadOnlyLatin1String::data):
(WebCore::ReadOnlyLatin1String::length):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

  • platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):

10:16 AM Changeset in webkit [125575] by commit-queue@webkit.org
  • 7 edits
    1 delete in trunk

Fix LayoutTests/canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html
https://bugs.webkit.org/show_bug.cgi?id=92974

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Replace space characters by U+0020 SPACE characters in
CanvasRenderingContext2D::drawTextInternal() in order to
comply with the HTML Canvas 2D Context specification:

No new tests, already tested by canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::replaceCharacterInString):
(WebCore):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

Unskip canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html for
all the ports now that space characters are correctly replaced in
the text passed to fillText() and strokeText().

  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt: Removed.
  • platform/qt/Skipped:
10:09 AM Changeset in webkit [125574] by zhajiang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Double-tap zoom on blocks on cnn.com desktop page doesn't work
https://bugs.webkit.org/show_bug.cgi?id=93895

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 188232
When adjusting block zoom node, don't choose a node if the width of the
node size is very close to the width of the actual visible size as
block zoom can do nothing on such kind of node. This condition is more
restrictive than the one based on area and can bail out early.
In this way, we can get a better node for double-tap zoom.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::bestNodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomAndExpandingRatioLimits):

  • Api/WebPage_p.h:

(WebPagePrivate):

10:01 AM Changeset in webkit [125573] by kpiascik@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Change the call to setUserScalable to use the setting.
https://bugs.webkit.org/show_bug.cgi?id=93974

Reviewed by Rob Buis.

We should be using the WebSetting and not the current value of m_userScalable.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

9:52 AM Changeset in webkit [125572] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding image failure expectation for fast/css-generated-content/quotes-lang.html.

  • platform/gtk/TestExpectations:
9:47 AM Changeset in webkit [125571] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updated the GTK WK2 Skipped file with well-known
failures in the WK2 bot.

  • platform/gtk-wk2/Skipped:
9:36 AM Changeset in webkit [125570] by staikos@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Avoid assertion failure in App Cache.
https://bugs.webkit.org/show_bug.cgi?id=93926

Reviewed by Rob Buis.

Short-circuit data url decoding if we know it's not a data URL to
avoid an assertion failure in debug mode. No functional change.

No new tests since this is just a debug mode assertion failure.

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

9:12 AM Changeset in webkit [125569] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Do not warn when the default theme is not found
https://bugs.webkit.org/show_bug.cgi?id=93968

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Even if you are using a custom theme, we always try to load first the
theme at the default path (that may or may not exist). In the case it
doesn't exist and you have a custom theme, we were always getting a
misleading error message.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::createEdje):

9:06 AM Changeset in webkit [125568] by jsbell@chromium.org
  • 26 edits in trunk/Source

IndexedDB: Pass cursor continue results back in callback
https://bugs.webkit.org/show_bug.cgi?id=92278

Reviewed by Tony Chang.

Supply the updated cursor key/primaryKey/value in the success callback,
rather than forcing the callee to make three calls into the back end to
fetch them. Callbacks onSuccess(cursor) and onSuccessWithContinuation()
are given the three new payload parameters (and the latter is renamed.)

Source/WebCore:

No new tests - no behavioral changes.

  • Modules/indexeddb/IDBCallbacks.h: Updated callbacks.

(IDBCallbacks):

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::setValueReady): Takes values rather than fetching them.

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp: Delete accessors.

(WebCore::IDBCursorBackendImpl::advanceInternal): Pass along updated cursor state.
(WebCore::IDBCursorBackendImpl::continueFunctionInternal): Ditto.

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(IDBCursorBackendImpl): Delete accessors from interface...
(WebCore::IDBCursorBackendImpl::key): ...but keep them for use within back-end.
(WebCore::IDBCursorBackendImpl::primaryKey):
(WebCore::IDBCursorBackendImpl::value):

  • Modules/indexeddb/IDBCursorBackendInterface.h: Delete accessors.
  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursorInternal): Pass along new cursor state.

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::openCursorInternal): Ditto.

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::setResultCursor): Stash updated cursor state until dispatch.
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent): Update cursor with new state.

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

  • inspector/InspectorIndexedDBAgent.cpp: Update iteration code to use new callbacks.

(WebCore):

Source/WebKit/chromium:

  • public/WebIDBCallbacks.h:

(WebIDBCallbacks):
(WebKit::WebIDBCallbacks::onSuccess): Replace with no-op stub.
(WebKit::WebIDBCallbacks::onSuccessWithContinuation): Ditto.

  • public/WebIDBCursor.h:

(WebIDBCursor): Methods can be removed once Chromium is cleaned up.

  • src/IDBCallbacksProxy.cpp: Updated callbacks.

(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit):

  • src/IDBCallbacksProxy.h: Updated callbacks.

(IDBCallbacksProxy):

  • src/IDBCursorBackendProxy.cpp: Remove back end accessors.
  • src/IDBCursorBackendProxy.h:

(IDBCursorBackendProxy):

  • src/WebIDBCallbacksImpl.cpp: Updated callbacks.

(WebKit::WebIDBCallbacksImpl::onSuccess):

  • src/WebIDBCallbacksImpl.h: Updated callbacks.

(WebIDBCallbacksImpl):

  • src/WebIDBCursorImpl.cpp: Remove back end accessors.
  • src/WebIDBCursorImpl.h: Remove back end accessors.

(WebIDBCursorImpl):

  • tests/IDBAbortOnCorruptTest.cpp: Update test stubs.

(WebCore::MockIDBCallbacks::onSuccess):

  • tests/IDBDatabaseBackendTest.cpp: Ditto.
  • tests/IDBRequestTest.cpp: Ditto.
8:53 AM Changeset in webkit [125567] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=93967

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-14

  • platform/efl/TestExpectations:
  • platform/efl/fast/css-generated-content/quotes-lang-expected.png: Added.
8:48 AM Changeset in webkit [125566] by fmalita@chromium.org
  • 45 edits
    1 copy
    1 move
    1 add
    8 deletes in trunk/LayoutTests

[Chromium] Rebaseline filter results after 125462
https://bugs.webkit.org/show_bug.cgi?id=93969

Unreviewed gardening.

  • platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Removed.
  • platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac/css3/filters/add-filter-rendering-expected.png:
  • platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
  • platform/chromium-mac/css3/filters/effect-blur-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-expected.png:
  • platform/chromium-mac/css3/filters/effect-combined-expected.png:
  • platform/chromium-mac/css3/filters/effect-contrast-expected.png:
  • platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-mac/css3/filters/effect-invert-expected.png:
  • platform/chromium-mac/css3/filters/effect-opacity-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-external-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png:
  • platform/chromium-mac/css3/filters/effect-saturate-expected.png:
  • platform/chromium-mac/css3/filters/effect-sepia-expected.png:
  • platform/chromium-mac/css3/filters/filtered-inline-expected.png:
  • platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png:
  • platform/chromium-mac/css3/filters/nested-filters-expected.png:
  • platform/chromium-mac/css3/filters/regions-expanding-expected.png:
  • platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png:
  • platform/chromium-mac/svg/filters/color-interpolation-filters-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png.
  • platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Removed.
  • platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-expected.png: Removed.
  • platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Removed.
  • platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-win/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-win/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-win/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-win/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
  • platform/chromium-win/css3/filters/custom/filter-repaint-custom-expected.png:
  • platform/chromium-win/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
  • platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png:
  • platform/chromium-win/css3/filters/effect-brightness-expected.png:
  • platform/chromium-win/svg/filters/color-interpolation-filters-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/svg/filters/color-interpolation-filters-expected.txt: Removed.
  • platform/gtk/svg/filters/color-interpolation-filters-expected.txt: Removed.
  • svg/filters/color-interpolation-filters-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/filters/color-interpolation-filters-expected.txt.
8:09 AM Changeset in webkit [125565] by charles.wei@torchmobile.com.cn
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Some callback of Select onchange doesn't work
https://bugs.webkit.org/show_bug.cgi?id=93944

Reviewed by George Staikos.

The Selection element is implemented with PagePopup, an HTML-based WebView with
some Javascripts to make the UI of the select and option lists; The selection
change is initiated from the javascript code in the Select Webview, and back to
the native code of SelectPopupClient, which now in turn dispatches
FormControlChangeEvent to the select element directly, and that causes the
javascript callback been invoked in the same cycle as the javascript in the
Popup View, and causes some Javascript Context problem.

The solution is to send the FormControlChangeEvent asynchronously by a timer,
when the JavaScript in the Popup view finishes execution, we then send the
FormControlChangeEvent to the select element in the content page, that avoids
the concurrent Javascript context issue.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::SelectPopupClient):
(WebCore::SelectPopupClient::setValueAndClosePopup):
(WebCore):
(WebCore::SelectPopupClient::notifySelectionChange):

  • WebCoreSupport/SelectPopupClient.h:

(SelectPopupClient):

7:52 AM Changeset in webkit [125564] by alexis.menard@openbossa.org
  • 2 edits in trunk/Tools

Update INdT build bot to Mountain Lion.
https://bugs.webkit.org/show_bug.cgi?id=93963

Reviewed by Csaba Osztrogonác.

We updated the machine as well as the OS as the Qt port is now running
on top of Qt5.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
7:33 AM Changeset in webkit [125563] by commit-queue@webkit.org
  • 17 edits
    4 adds in trunk/Source

[BlackBerry] Get rid of glCopyTexImage2D in Canvas and WebGL code paths
https://bugs.webkit.org/show_bug.cgi?id=93614

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-14
Reviewed by Antonio Gomes.

We used to set up resource sharing between the compositing thread
context and the Canvas and WebGL contexts, and use glCopyTexImage2D to
get a copy of the framebuffer to use as front buffer for compositing
purposes.

Now we instead create an EGLImage and blit the Canvas/WebGL output to
it. The compositing thread creates a texture from the EGLImage in order
to composite the output.

Source/WebCore:

Created a new EGLImageLayerWebKitThread base class that handles the
EGLImage and does the blitting. CanvasLayerWebKitThread and
WebGLLayerWebKitThread now inherit from this new base class.

However, we need to be careful to restore state after the blit because
it's done using the Canvas/WebGL context.

The BlackBerry implementation of GraphicsContext3D::prepareTexture()
was changed to no longer call glCopyTexImage, and
GraphicsContext3D::platformLayer() now returns the target texture
directly.

Reviewed internally by Filip Spacek.

PR 188472

No change in behavior, new tests.

  • PlatformBlackBerry.cmake:
  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::setDevice):
(WebCore::CanvasLayerWebKitThread::makeContextCurrent):
(WebCore::CanvasLayerWebKitThread::textureSize):
(WebCore):
(WebCore::CanvasLayerWebKitThread::textureID):

  • platform/graphics/blackberry/CanvasLayerWebKitThread.h:

(CanvasLayerWebKitThread):

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp: Added.

(WebCore):
(WebCore::EGLImageLayerCompositingThreadClient::~EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::uploadTexturesIfNeeded):
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
(WebCore::EGLImageLayerCompositingThreadClient::deleteTextures):
(WebCore::EGLImageLayerCompositingThreadClient::bindContentsTexture):
(WebCore::EGLImageLayerCompositingThreadClient::setImage):

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h: Added.

(WebCore):
(EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::create):
(WebCore::EGLImageLayerCompositingThreadClient::layerCompositingThreadDestroyed):
(WebCore::EGLImageLayerCompositingThreadClient::layerVisibilityChanged):
(WebCore::EGLImageLayerCompositingThreadClient::EGLImageLayerCompositingThreadClient):

  • platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp: Added.

(WebCore):
(WebCore::EGLImageLayerWebKitThread::EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::setNeedsDisplay):
(WebCore::EGLImageLayerWebKitThread::makeContextCurrent):
(WebCore::EGLImageLayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::EGLImageLayerWebKitThread::commitPendingTextureUploads):
(WebCore::EGLImageLayerWebKitThread::createImageIfNeeded):
(WebCore::EGLImageLayerWebKitThread::createShaderIfNeeded):
(WebCore::EGLImageLayerWebKitThread::drawTexture):

  • platform/graphics/blackberry/EGLImageLayerWebKitThread.h: Copied from Source/WebCore/platform/graphics/blackberry/CanvasLayerWebKitThread.h.

(WebCore):
(EGLImageLayerWebKitThread):

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::prepareTexture):
(WebCore):
(WebCore::GraphicsContext3D::platformTexture):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::releaseTextureResources):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerCompositingThread::setClient):
(LayerCompositingThread):

  • platform/graphics/blackberry/LayerData.h:

(WebCore::LayerData::LayerData):
(LayerData):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::LayerWebKitThread::commitPendingTextureUploads):
(WebCore::LayerWebKitThread::commitOnCompositingThread):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(LayerWebKitThread):

  • platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:

(WebCore::WebGLLayerWebKitThread::WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::WebGLLayerWebKitThread::makeContextCurrent):
(WebCore):
(WebCore::WebGLLayerWebKitThread::textureSize):
(WebCore::WebGLLayerWebKitThread::textureID):

  • platform/graphics/blackberry/WebGLLayerWebKitThread.h:

(WebGLLayerWebKitThread):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore):
(WebCore::GraphicsContext3D::prepareTexture):

Source/WebKit/blackberry:

This allows us to turn off resource sharing, so the WebPageCompositor
no longer needs to pass the compositing thread context to the webkit
thread.

Reviewed internally by Filip Spacek.

PR 188472

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::setCompositorHelper):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):

  • Api/WebPage_p.h:

(WebPagePrivate):

7:31 AM Changeset in webkit [125562] by tkent@chromium.org
  • 6 edits
    1 add in trunk/LayoutTests

[Chromium] Update expectation files for fast/forms/date/calendar-picker-appearance.html

  • platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png: Added.
  • platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png:
7:26 AM Changeset in webkit [125561] by peter@chromium.org
  • 6 edits in trunk

[Chromium] Remove unneeded build logic for Android
https://bugs.webkit.org/show_bug.cgi?id=93962

Reviewed by Dimitri Glazkov.

The Android SDK and NDK have been checked in to the Chromium tree, which
allows WebKit to leverage those as well. They will already be pulled in
through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
environment variable, the envsetup.sh will set the project files up
appropriately for us.

Source/WebKit/chromium:

  • DEPS:

Tools:

  • Scripts/webkitdirs.pm:
7:05 AM Changeset in webkit [125560] by commit-queue@webkit.org
  • 2 edits
    4 deletes in trunk/LayoutTests

REGRESSION (r125450): 4 canvas/philip/tests tests failing on Apple Lion Release WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93910

Unreviewed gardening.

Removed wrong and duplicated expectations. Mac port should use the
global expectations since this test is now passing.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-14

  • platform/chromium/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Removed.
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Removed.
7:00 AM Changeset in webkit [125559] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
6:53 AM Changeset in webkit [125558] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Texture cache must adapt to HashMap changes
https://bugs.webkit.org/show_bug.cgi?id=93955

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-14
Reviewed by Rob Buis.

This was fixed locally, but not upstreamed yet.

Based on an original patch by Konrad Piascik.

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::textureForTiledContents):

6:37 AM Changeset in webkit [125557] by allan.jensen@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed, Qt gardening

Unmark tests that has been passing since they were fixed generally in r125371.

  • platform/qt/TestExpectations:
6:30 AM Changeset in webkit [125556] by allan.jensen@nokia.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening for Qt, rebaselining marked test from r125167.

Changelog and commit mixed with entry below.

  • platform/qt/TestExpectations:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt:
6:27 AM Changeset in webkit [125555] by allan.jensen@nokia.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening for Qt, rebaselining marked test from r125167.

  • platform/qt/TestExpectations:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
6:16 AM Changeset in webkit [125554] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] LayerCompositingThread.h doesn't compile
https://bugs.webkit.org/show_bug.cgi?id=93956

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-14
Reviewed by Rob Buis.

I forgot to upstream this local change.

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerOverride::setBounds):
(WebCore::LayerOverride::setOpacity):

5:59 AM WebInspector edited by doris.greys@gmail.com
(diff)
5:52 AM Changeset in webkit [125553] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[Qt] QNX build fails due to reference to MADV_FREE_REUSE and MADV_FREE_REUSABLE
https://bugs.webkit.org/show_bug.cgi?id=93843

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-14
Reviewed by Simon Hausmann.

QNX does not implement MADV_FREE_REUSE nor MADV_FREE_REUSABLE.
The Blackberry port already sets the define to use the system
malloc, which is now also done for QNX in general.

  • wtf/Platform.h:
5:39 AM Changeset in webkit [125552] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[BlackBerry] LayerAnimation is not immutable, which makes dereferencing an expensive operation
https://bugs.webkit.org/show_bug.cgi?id=93946

Patch by Ed Baker <edbaker@rim.com> on 2012-08-14
Reviewed by Antonio Gomes.

Make LayerAnimation immutable so it can be dereferenced from the main
WebKit thread without having to dispatch to the compositing thread,
which is an expensive operation.

TransformOperation and TimingFunction need to be made thread safe as
they are referenced in LayerAnimation, but that effort is being tracked
by a separate bug, #86483.

Reviewed internally by Arvid Nilsson.

No change in behavior, no new tests.

  • platform/graphics/blackberry/LayerAnimation.h:

(WebCore::LayerAnimation::name):
(LayerAnimation):
(WebCore::LayerAnimation::LayerAnimation):
(WebCore::LayerAnimation::setName):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::~LayerWebKitThread):

5:34 AM Changeset in webkit [125551] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] GraphicsLayerBlackBerry::willBeDestroyed() must call superclass implementation
https://bugs.webkit.org/show_bug.cgi?id=93947

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-14
Reviewed by Rob Buis.

This was fixed locally, but not upstreamed yet.

Based on an original patch by Konrad Piascik.

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::willBeDestroyed):

5:10 AM Changeset in webkit [125550] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk/Source/WebCore

Remove custom JSC bindings from ConvolverNode.idl
https://bugs.webkit.org/show_bug.cgi?id=93952

Patch by Vineet Chaudhary <Vineet> on 2012-08-14
Reviewed by Kentaro Hara.

We should remove custom bindings as CodeGenerator uses UNUSED_PARAM macro.

No new tests. No behavioural changes.
All tests under webaudio/* should behave same.

  • GNUmakefile.list.am: Removed JSConvolverNodeCustom.cpp from builds.
  • Modules/webaudio/ConvolverNode.idl: Removed [JSCustomSetter].
  • UseJSC.cmake: Removed JSConvolverNodeCustom.cpp from builds.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto
  • bindings/js/JSConvolverNodeCustom.cpp: Removed.
4:56 AM Changeset in webkit [125549] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix failing tst_QWebPage::findText unit test
https://bugs.webkit.org/show_bug.cgi?id=93951

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Adjust the expected text, as the HTML editing code improved to avoid unnecessary tags.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::findText):

4:52 AM Changeset in webkit [125548] by pfeldman@chromium.org
  • 4 edits
    1 add in trunk

Web Inspector: add external test runner for running inspector front-end tests with no TestRunner infrastructure.
https://bugs.webkit.org/show_bug.cgi?id=93833

Reviewed by Yury Semikhatsky.

Source/WebCore:

Added mock test runner that allows running front-end layout tests.
InspectorFrontendAPI can now dispatch whatever it receives from its embedder (opener).

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.evaluateForTest):
(InspectorFrontendAPI.dispatch):
(InspectorFrontendAPI.loadCompleted):
(.onMessageFromOpener):

LayoutTests:

  • http/tests/inspector/inspector-test.js:
  • http/tests/inspector/resources/test-runner.html: Added.
4:47 AM Changeset in webkit [125547] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Incomplete repaint of link underline
https://bugs.webkit.org/show_bug.cgi?id=66034

Reviewed by Kenneth Rohde Christiansen.

When trying to point a line of width 30, we end up painting on of width 31, because Qt
interprets the line as end-inclusive. So adjust for end-include/exclusive difference
before requesting the draw from Qt.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawLine):

4:46 AM Changeset in webkit [125546] by sergio@webkit.org
  • 2 edits in trunk/Tools

[WK2] [GTK] Plugin tests failing in WK2 bot
https://bugs.webkit.org/show_bug.cgi?id=93954

Reviewed by Carlos Garcia Campos.

Plugin tests are failing in the WK2 bot because we aren't exporting
the Netscape plugin when creating the product archive.

  • BuildSlaveSupport/built-product-archive: added TestNetscapePlugin

to the list of directories to export.
(archiveBuiltProduct):

4:43 AM Changeset in webkit [125545] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fix test calendar-picker-appearance.html after r125507

Unreviewed.

  • fast/forms/date/calendar-picker-appearance.html: Use resize event instead of transitionEnd.
4:42 AM Changeset in webkit [125544] by commit-queue@webkit.org
  • 2 edits in trunk

[Qt] QtWebKit linking fails for QNX cross build
https://bugs.webkit.org/show_bug.cgi?id=93460

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-14
Reviewed by Simon Hausmann.

The GCC 4.4.2 used by the QNX BBNDK 2.0.1 fails to link QtWebKit.
Apparently it does not properly support the linker invokation using
-Wl,-whole-archive -l... -Wl,-no-whole-archive
yielding a "cc: no files to process" error. This patch works around
this issue by adding an empty dummy file (and thus object file) to
the linking stage.

  • Source/api.pri:
4:39 AM Changeset in webkit [125543] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix crash in http/tests/plugins/plugin-document-has-focus
https://bugs.webkit.org/show_bug.cgi?id=93949

Patch by Mike West <mkwst@chromium.org> on 2012-08-14
Reviewed by Jochen Eisinger.

Covered by http/tests/plugins/plugin-document-has-focus.html. If that
doesn't crash, we're good!

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::pluginIsLoadable):

Check the PluginDocument's ownerElement before derefing.

4:32 AM Changeset in webkit [125542] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841

Unreviewed build fix (step 2).

The path from webkit_unit_tests isn't robust enough. Use the same
convention as the Chromium side, i.e. walk up from the ant_build_out path.
One-line Android-only gyp change.

  • WebKitUnitTests.gyp:
4:28 AM Changeset in webkit [125541] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Rename functions in the ARM port of DFG-JIT for better code readability.
https://bugs.webkit.org/show_bug.cgi?id=93609

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-08-14
Reviewed by Zoltan Herczeg.

Rename functions in the ARM port of DFG-JIT for better code
readability, and for following the WebKit coding style
wherever it is possible.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::genInt):
(JSC::ARMAssembler::getImm):
(JSC::ARMAssembler::moveImm):
(JSC::ARMAssembler::encodeComplexImm):
(JSC::ARMAssembler::dataTransfer32):
(JSC::ARMAssembler::baseIndexTransfer32):
(JSC::ARMAssembler::dataTransfer16):
(JSC::ARMAssembler::baseIndexTransfer16):
(JSC::ARMAssembler::dataTransferFloat):
(JSC::ARMAssembler::baseIndexTransferFloat):

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::bitAnd):
(JSC::ARMAssembler::bitAnds):
(JSC::ARMAssembler::eor):
(JSC::ARMAssembler::eors):
(JSC::ARMAssembler::sub):
(JSC::ARMAssembler::subs):
(JSC::ARMAssembler::rsb):
(JSC::ARMAssembler::rsbs):
(JSC::ARMAssembler::add):
(JSC::ARMAssembler::adds):
(JSC::ARMAssembler::adc):
(JSC::ARMAssembler::adcs):
(JSC::ARMAssembler::sbc):
(JSC::ARMAssembler::sbcs):
(JSC::ARMAssembler::rsc):
(JSC::ARMAssembler::rscs):
(JSC::ARMAssembler::tst):
(JSC::ARMAssembler::teq):
(JSC::ARMAssembler::cmp):
(JSC::ARMAssembler::cmn):
(JSC::ARMAssembler::orr):
(JSC::ARMAssembler::orrs):
(JSC::ARMAssembler::mov):
(JSC::ARMAssembler::movw):
(JSC::ARMAssembler::movt):
(JSC::ARMAssembler::movs):
(JSC::ARMAssembler::bic):
(JSC::ARMAssembler::bics):
(JSC::ARMAssembler::mvn):
(JSC::ARMAssembler::mvns):
(JSC::ARMAssembler::mul):
(JSC::ARMAssembler::muls):
(JSC::ARMAssembler::mull):
(JSC::ARMAssembler::vmov_f64):
(JSC::ARMAssembler::vadd_f64):
(JSC::ARMAssembler::vdiv_f64):
(JSC::ARMAssembler::vsub_f64):
(JSC::ARMAssembler::vmul_f64):
(JSC::ARMAssembler::vcmp_f64):
(JSC::ARMAssembler::vsqrt_f64):
(JSC::ARMAssembler::vabs_f64):
(JSC::ARMAssembler::vneg_f64):
(JSC::ARMAssembler::ldrImmediate):
(JSC::ARMAssembler::ldrUniqueImmediate):
(JSC::ARMAssembler::dtrUp):
(JSC::ARMAssembler::dtrUpRegister):
(JSC::ARMAssembler::dtrDown):
(JSC::ARMAssembler::dtrDownRegister):
(JSC::ARMAssembler::halfDtrUp):
(JSC::ARMAssembler::halfDtrUpRegister):
(JSC::ARMAssembler::halfDtrDown):
(JSC::ARMAssembler::halfDtrDownRegister):
(JSC::ARMAssembler::doubleDtrUp):
(JSC::ARMAssembler::doubleDtrDown):
(JSC::ARMAssembler::push):
(JSC::ARMAssembler::pop):
(JSC::ARMAssembler::poke):
(JSC::ARMAssembler::peek):
(JSC::ARMAssembler::vmov_vfp64):
(JSC::ARMAssembler::vmov_arm64):
(JSC::ARMAssembler::vmov_vfp32):
(JSC::ARMAssembler::vmov_arm32):
(JSC::ARMAssembler::vcvt_f64_s32):
(JSC::ARMAssembler::vcvt_s32_f64):
(JSC::ARMAssembler::vcvt_u32_f64):
(JSC::ARMAssembler::vcvt_f64_f32):
(JSC::ARMAssembler::vcvt_f32_f64):
(JSC::ARMAssembler::clz):
(JSC::ARMAssembler::lslRegister):
(JSC::ARMAssembler::lsrRegister):
(JSC::ARMAssembler::asrRegister):
(JSC::ARMAssembler::align):
(JSC::ARMAssembler::loadBranchTarget):
(JSC::ARMAssembler::vmov):

  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::add32):
(JSC::MacroAssemblerARM::and32):
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::mul32):
(JSC::MacroAssemblerARM::or32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::sub32):
(JSC::MacroAssemblerARM::xor32):
(JSC::MacroAssemblerARM::countLeadingZeros32):
(JSC::MacroAssemblerARM::convertibleLoadPtr):
(JSC::MacroAssemblerARM::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerARM::store32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::pop):
(JSC::MacroAssemblerARM::push):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::swap):
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::branchTest32):
(JSC::MacroAssemblerARM::mull32):
(JSC::MacroAssemblerARM::branchSub32):
(JSC::MacroAssemblerARM::compare32):
(JSC::MacroAssemblerARM::test32):
(JSC::MacroAssemblerARM::load32):
(JSC::MacroAssemblerARM::relativeTableJump):
(JSC::MacroAssemblerARM::moveWithPatch):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::moveDouble):
(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::sqrtDouble):
(JSC::MacroAssemblerARM::absDouble):
(JSC::MacroAssemblerARM::negateDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::convertFloatToDouble):
(JSC::MacroAssemblerARM::convertDoubleToFloat):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerARM::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerARM::truncateDoubleToInt32):
(JSC::MacroAssemblerARM::truncateDoubleToUint32):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
(JSC::MacroAssemblerARM::branchDoubleNonZero):
(JSC::MacroAssemblerARM::branchDoubleZeroOrNaN):

4:22 AM Changeset in webkit [125540] by allan.jensen@nokia.com
  • 7 edits
    2 adds in trunk/Source/WebKit2

[Qt] UpdateAtlas is wasting memory
https://bugs.webkit.org/show_bug.cgi?id=93606

Reviewed by Jocelyn Turcotte.

Imported and QAreaAllocator from Qt3D and ported it to WebCore style,
and use this new area allocator to replace old one from UpdateAtlas.

  • CMakeLists.txt:
  • Target.pri:
  • WebProcess/WebPage/AreaAllocator.cpp: Added.

(WebKit::AreaAllocator::AreaAllocator):
(WebKit::AreaAllocator::~AreaAllocator):
(WebKit::AreaAllocator::expand):
(WebKit::AreaAllocator::expandBy):
(WebKit::AreaAllocator::release):
(WebKit::AreaAllocator::overhead):
(WebKit::AreaAllocator::roundAllocation):
(WebKit::GeneralAreaAllocator::GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::~GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::freeNode):
(WebKit::GeneralAreaAllocator::expand):
(WebKit::fitsWithin):
(WebKit::GeneralAreaAllocator::allocate):
(WebKit::GeneralAreaAllocator::allocateFromNode):
(WebKit::GeneralAreaAllocator::splitNode):
(WebKit::GeneralAreaAllocator::updateLargestFree):
(WebKit::GeneralAreaAllocator::release):
(WebKit::GeneralAreaAllocator::overhead):

  • WebProcess/WebPage/AreaAllocator.h: Added.

(WebCore::nextPowerOfTwo):
(AreaAllocator):
(WebKit::AreaAllocator::size):
(WebKit::AreaAllocator::minimumAllocation):
(WebKit::AreaAllocator::setMinimumAllocation):
(WebKit::AreaAllocator::margin):
(WebKit::AreaAllocator::setMargin):
(GeneralAreaAllocator):
(Node):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::renderNextFrame):
(WebKit::LayerTreeCoordinator::beginContentUpdate):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::buildLayoutIfNeeded):
(WebKit::UpdateAtlas::didSwapBuffers):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):

  • WebProcess/WebPage/UpdateAtlas.h:

(UpdateAtlas):

4:14 AM Changeset in webkit [125539] by Csaba Osztrogonác
  • 1 edit
    108 deletes in trunk/LayoutTests

[Qt] Remove duplicated platform test expectations
https://bugs.webkit.org/show_bug.cgi?id=93351

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-10
Reviewed by Csaba Osztrogonác.

Remove platform test expectations that are the same as the global
expectations.

  • platform/qt-5.0-wk2/compositing/iframes/fixed-position-iframe-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/invisible-iframe-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/layout-on-compositing-change-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/nested-composited-iframe-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/nested-iframe-scrolling-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-iframe-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/remove-iframe-crash-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/scroll-fixed-transformed-element-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/scroll-grandchild-iframe-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/become-simple-composited-reflection-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/empty-reflection-with-mask-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/remove-add-reflection-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/remove-reflection-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-relative-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/events/overflow-viewport-renderer-deleted-expected.txt: Removed.
  • platform/qt-5.0-wk2/plugins/document-open-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceMotion/no-page-cache-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceMotion/optional-event-properties-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceMotion/window-property-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceOrientation/no-page-cache-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceOrientation/optional-event-properties-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceOrientation/window-property-expected.txt: Removed.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
  • platform/qt-mac/plugins/plugin-javascript-access-expected.txt: Removed.
  • platform/qt/compositing/geometry/composited-in-columns-expected.txt: Removed.
  • platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/qt/compositing/iframes/composited-iframe-scroll-expected.txt: Removed.
  • platform/qt/compositing/iframes/iframe-content-flipping-expected.txt: Removed.
  • platform/qt/editing/execCommand/format-block-with-trailing-br-expected.txt: Removed.
  • platform/qt/editing/pasteboard/4242293-1-expected.txt: Removed.
  • platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
  • platform/qt/editing/selection/drag-start-event-client-x-y-expected.txt: Removed.
  • platform/qt/editing/selection/hit-test-on-text-with-line-height-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-mask-expected.txt: Removed.
  • platform/qt/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusSolid01-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusSolid02-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusSolid03-expected.txt: Removed.
  • platform/qt/fast/borders/borderRadiusSolid04-expected.txt: Removed.
  • platform/qt/fast/box-shadow/box-shadow-radius-expected.txt: Removed.
  • platform/qt/fast/box-shadow/scaled-box-shadow-expected.txt: Removed.
  • platform/qt/fast/css/font-face-descending-unicode-range-expected.txt: Removed.
  • platform/qt/fast/css/font-face-font-family-descriptor-expected.txt: Removed.
  • platform/qt/fast/css/font-family-pictograph-expected.txt: Removed.
  • platform/qt/fast/css/hsla-color-expected.txt: Removed.
  • platform/qt/fast/css/rgba-custom-text-expected.txt: Removed.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
  • platform/qt/fast/dom/icon-url-change-expected.txt: Removed.
  • platform/qt/fast/dom/icon-url-list-expected.txt: Removed.
  • platform/qt/fast/inline/inline-fixed-position-boundingbox-expected.txt: Removed.
  • platform/qt/fast/inline/inline-relative-offset-boundingbox-expected.txt: Removed.
  • platform/qt/fast/multicol/hit-test-gap-between-pages-expected.txt: Removed.
  • platform/qt/fast/reflections/reflection-masks-expected.txt: Removed.
  • platform/qt/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
  • platform/qt/fast/repaint/repaint-svg-after-style-change-expected.txt: Removed.
  • platform/qt/fast/writing-mode/background-horizontal-bt-expected.txt: Removed.
  • platform/qt/fast/writing-mode/background-vertical-lr-expected.txt: Removed.
  • platform/qt/fast/writing-mode/background-vertical-rl-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/qt/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
  • platform/qt/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
  • platform/qt/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
  • platform/qt/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
  • platform/qt/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
  • platform/qt/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
  • platform/qt/svg/custom/bug86119-expected.txt: Removed.
  • platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/custom/svg-features-expected.txt: Removed.
  • platform/qt/svg/custom/use-instanceRoot-event-listeners-expected.txt: Removed.
  • platform/qt/svg/custom/use-setAttribute-crash-expected.txt: Removed.
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
  • platform/qt/svg/hixie/viewbox/002-expected.txt: Removed.
  • platform/qt/svg/hixie/viewbox/003-expected.txt: Removed.
  • platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Removed.
  • platform/qt/svg/repaint/inner-svg-change-viewBox-expected.txt: Removed.
  • platform/qt/svg/text/text-viewbox-rescale-expected.txt: Removed.
  • platform/qt/svg/zoom/page/zoom-foreign-content-expected.txt: Removed.
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/qt/tables/mozilla/bugs/bug26553-expected.txt: Removed.
  • platform/qt/tables/mozilla/bugs/bug83786-expected.txt: Removed.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.
4:02 AM Changeset in webkit [125538] by peter@chromium.org
  • 5 edits in trunk

[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841

Unreviewed build fix.

APK generation was broken as the configuration file assumed compilation
would only occur in the Chromium tree. Pass the path to Chromium's source
base directory as a property to ant.

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3:24 AM Changeset in webkit [125537] by commit-queue@webkit.org
  • 5 edits
    5 deletes in trunk/LayoutTests

Unreviewed, rolling out r125525.
http://trac.webkit.org/changeset/125525
https://bugs.webkit.org/show_bug.cgi?id=93950

rebaseline revert after r125526... (Requested by philn on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-14

  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
3:13 AM Changeset in webkit [125536] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fixed displaying buffering progress in the media control.
https://bugs.webkit.org/show_bug.cgi?id=75681

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

It is required "rangeRect" instead of "rect" to display buffering
progress properly.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaSliderTrack):

3:12 AM Changeset in webkit [125535] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after r125516.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-08-14
Reviewed by Csaba Osztrogonác.

Added baseline to fast/text/zero-font-size.html.

  • platform/qt/fast/text/zero-font-size-expected.txt:
2:56 AM Changeset in webkit [125534] by yosin@chromium.org
  • 1 edit
    2 copies in trunk/Source/WebCore

[Forms] Copy Source/WebCore/html/shadow/TextControlInnerElements.{cpp,h} to SpinButtonElement.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=93943

Reviewed by Kent Tamura.

This patch copys html/shadow/TextControlInnerElement.{cpp,h} to SpinButtonElement.{cpp,h} for
preparation of bug 93941, Set SpinButtonElement free from HTMLInputElement.

No new tests. This patch doesn't change behavior.

  • html/shadow/SpinButtonElement.cpp: Copied from Source/WebCore/html/shadow/TextControlInnerElements.cpp.
  • html/shadow/SpinButtonElement.h: Copied from Source/WebCore/html/shadow/TextControlInnerElements.h.
2:38 AM WebInspector edited by toybabyyou@gmail.com
(diff)
2:28 AM Changeset in webkit [125533] by sergio@webkit.org
  • 4 edits in trunk

[GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
https://bugs.webkit.org/show_bug.cgi?id=91083

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

After r122428 search_next()/search_prev() should return just 1 match
if the text is found.

  • UIProcess/API/gtk/tests/TestWebKitFindController.cpp:

(testFindControllerNext):
(testFindControllerPrevious):

Tools:

Unskipped a couple of API tests that should work fine from now on.

  • Scripts/run-gtk-tests:

(TestRunner):

2:25 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
2:21 AM Changeset in webkit [125532] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/TestExpectations: Skip media-source tests, the GTK

port doesn't support this feature yet and the tests time out.

2:16 AM Changeset in webkit [125531] by commit-queue@webkit.org
  • 8 edits
    20 adds in trunk

Implement the plugin-types Content Security Policy directive.
https://bugs.webkit.org/show_bug.cgi?id=91919

Patch by Mike West <mkwst@chromium.org> on 2012-08-14
Reviewed by Adam Barth.

Source/WebCore:

The CSP 1.1 editor's draft defines the 'plugin-types' directive as a
mechanism for whitelisting only specific types of plugin content on a
page. A protected resource might trust only Flash content, for instance,
and could enforce that preference via a Content Security Policy of
'plugin-types application/x-shockwave-flash'. Flash would load, no other
plugin type would.

Specification details available at: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#plugin-types--experimental

This experimental directive is gated on the ENABLE_CSP_NEXT flag, which
is currently only enabled in Chromium.

Tests: http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html

http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-allowed.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01.html
http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02.html

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::pluginIsLoadable):

Adding a check against 'allowPluginType', and passing in both the
MIME type of the plugin, as well as the declared MIME type from the
object/embed element (ensuring that we do this correctly, even if
we're inside a PluginDocument).

(WebCore::SubframeLoader::createJavaAppletWidget):

Same as 'pluginIsLoadable', but hard-coded to
'application/x-java-applet'.

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::logInvalidPluginTypes):

Plugin types that don't match the grammar ('not/a/mime/type') are
logged to the console, and ignored for purposes of matching.

(WebCore):
(WebCore::CSPDirectiveList::checkPluginType):

Given both the plugin type and the declared type attribute, returns
true if both types match, and are contained in the list of accepted
plugin types.

(WebCore::CSPDirectiveList::checkPluginTypeAndReportViolation):

Calls out to checkPluginType, and reports a violation if that check
fails.

(WebCore::CSPDirectiveList::allowPluginType):

Analog to the other 'CSPDirectiveList::allowXXX' methods, this
branches between simply checking the type against the policy, and
checking against the policy and then reporting violations.

(WebCore::CSPDirectiveList::parsePluginTypes):

Given a directive value, parse out the media types contained within
by splitting on spaces, and validating each token. Valid tokens are
added to 'm_pluginTypes' for use in 'checkPluginType'.

(WebCore::CSPDirectiveList::addDirective):

Wire up 'plugin-types' as a valid directive (if the ENABLE_CSP_NEXT
flag is set). This has been combined with the other implemented 1.1
header, 'script-nonce'.

(WebCore::ContentSecurityPolicy::allowPluginType):

The public interface to this set of functionality.

  • page/ContentSecurityPolicy.h:

LayoutTests:

  • http/tests/plugins/resources/mock-plugin-unknown-type.pl:

Adding a mock plugin resource that is served with a type that WebKit
doesn't understand. Using it to test a confusion attack in
plugintypes-url-02.

  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02.html: Added.
  • http/tests/security/contentSecurityPolicy/object-src-none-allowed.html:
  • http/tests/security/contentSecurityPolicy/object-src-none-blocked.html:

Renaming the q parameter to plugin in these two tests.

  • http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl:

Add output of explicit MIME types to the object data renderer, and
changed the q parameter to be slightly less confusingly named.
It's now plugin.

  • http/tests/security/contentSecurityPolicy/resources/multiple-iframe-plugin-test.js: Added.

Copy multiple-iframe-test.js, and add in plugin-specific details,
like plugin, log, and type.

(test):
(finishTesting):

2:16 AM BuildingGtk edited by Csaba Osztrogonác
typo fix (diff)
2:12 AM Changeset in webkit [125530] by charles.wei@torchmobile.com.cn
  • 5 edits
    1 copy in trunk/Source

[BlackBerry] Enable DNS prefetch
https://bugs.webkit.org/show_bug.cgi?id=93846

Reviewed by George Staikos.

Source/WebCore:

No new tests.

  • PlatformBlackBerry.cmake:
  • platform/blackberry/TemporaryLinkStubs.cpp:
  • platform/network/blackberry/DNSBlackBerry.cpp: Copied from Source/WebCore/platform/blackberry/TemporaryLinkStubs.cpp.

(WebCore):
(WebCore::prefetchDNS):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

2:06 AM Changeset in webkit [125529] by hans@chromium.org
  • 5 edits
    2 adds in trunk

Speech Input: wrong position was reported for scolled-down elements
https://bugs.webkit.org/show_bug.cgi?id=93634

Reviewed by Kent Tamura.

Source/WebCore:

When clicking on a speech-enabled input element, WebKit reports
the position of the element to the embedder, so that it can show
a bubble indicating that speech recognition is in progress for
the element that the user clicked on.

On a page that was scrolled, this position was being reported
erroneously: it was given relative to the frame content as opposed to
the root view, and the in-progress bubble would be shown in the wrong
place.

Test: fast/speech/bubble-position-scrolled.html

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

LayoutTests:

Test that the position of the speech element is passed to the embedder
corectly, i.e. where the user clicked, when the page is scrolled down.

  • fast/speech/bubble-position-scrolled-expected.txt: Added.
  • fast/speech/bubble-position-scrolled.html: Added.
2:06 AM Changeset in webkit [125528] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Implement smart separators for context menu in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=90449

Reviewed by Martin Robinson.

Don't add to the context menu separators that are at the very
beginning or end of the menu. Once the context menu is shown,
monitor menu items visibility to hide or show separators to make
sure they never appear in the context menu unless they are between
two visible items.

  • UIProcess/API/gtk/tests/TestContextMenu.cpp:

(testContextMenuSmartSeparators):
(beforeAll):

  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::contextMenuItemVisibilityChanged):
(WebKit):
(WebKit::WebContextMenuProxyGtk::append):
(WebKit::WebContextMenuProxyGtk::populate):

2:04 AM Changeset in webkit [125527] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Drop "Loading..." message from FileContentView
https://bugs.webkit.org/show_bug.cgi?id=91732

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-14
Reviewed by Vsevolod Vlasov.

  • inspector/front-end/FileContentView.js:

(WebInspector.FileContentView.prototype.wasShown):

1:56 AM Changeset in webkit [125526] by commit-queue@webkit.org
  • 23 edits
    12 deletes in trunk

Unreviewed, rolling out r125519.
http://trac.webkit.org/changeset/125519
https://bugs.webkit.org/show_bug.cgi?id=93945

New ref-tests caused image failures on chromium-mac bots.
(Requested by yutak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-14

Source/WebCore:

  • css/html.css:

(meter):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::createRenderer):
(WebCore::HTMLMeterElement::didElementStateChange):
(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLMeterElement.h:

(WebCore):
(HTMLMeterElement):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::meterElement):
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore):

  • html/shadow/MeterShadowElement.h:

(WebCore):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::valueRatio):

  • rendering/RenderMeter.h:

(RenderMeter):

LayoutTests:

  • fast/dom/HTMLMeterElement/meter-clone-expected.txt:
  • fast/dom/HTMLMeterElement/meter-clone.html:
  • fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
  • fast/dom/shadow/resources/replaced-element-styles.css:

(.progress-inner-element-like):

  • fast/dom/shadow/shadowdom-for-meter-dynamic-expected.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-dynamic.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-expected.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-multiple-expected.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-multiple.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-with-style-expected.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-with-style.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-without-appearance-expected.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-without-appearance.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-without-shadow-element-expected.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html: Removed.
  • fast/dom/shadow/shadowdom-for-meter.html: Removed.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
  • platform/mac/TestExpectations:
1:53 AM Changeset in webkit [125525] by Philippe Normand
  • 5 edits
    5 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r125519.

  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
1:48 AM Changeset in webkit [125524] by kkristof@inf.u-szeged.hu
  • 3 edits in trunk/Tools

[NRWT] Compare results between different platforms
https://bugs.webkit.org/show_bug.cgi?id=90555

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_search_path):
(Port):
(Port.compare_baseline):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

1:48 AM Changeset in webkit [125523] by keishi@webkit.org
  • 5 edits
    5 moves
    1 add in trunk

Move page popup resources to separate directory
https://bugs.webkit.org/show_bug.cgi?id=93932

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html:
  • ManualTests/forms/color-suggestion-picker.html:

Source/WebCore:

Keeping the resources organized.

No new tests.

  • Resources/pagepopups/calendarPicker.css: Renamed from Source/WebCore/Resources/calendarPicker.css.
  • Resources/pagepopups/calendarPicker.js: Renamed from Source/WebCore/Resources/calendarPicker.js.
  • Resources/pagepopups/calendarPickerMac.css: Renamed from Source/WebCore/Resources/calendarPickerMac.css.
  • Resources/pagepopups/colorSuggestionPicker.css: Renamed from Source/WebCore/Resources/colorSuggestionPicker.css.
  • Resources/pagepopups/colorSuggestionPicker.js: Renamed from Source/WebCore/Resources/colorSuggestionPicker.js.
  • WebCore.gyp/WebCore.gyp:
1:44 AM Changeset in webkit [125522] by yosin@chromium.org
  • 12 edits in trunk/Source/WebCore

[Forms] Move wheel event handler to spin button class
https://bugs.webkit.org/show_bug.cgi?id=93928

Reviewed by Kent Tamura.

This patch moves implmentation of wheel event handling from TextFieldInput
class to SpinButtonElement class to share implementation in TextFieldInput
class, and DateTimeEditElement.

No new tests. This patch doesn't change behavior. fast/orms/number/number-wheel.html
covers this change.

  • html/BaseDateAndTimeInputType.cpp: Removed handleWheelEvent() implementation.
  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType): Removed handleWheelEvent() declaration.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler): Removed wheel event handling.

  • html/InputType.cpp: Removed handleWheelEvent() implementation.
  • html/InputType.h:

(InputType): Removed handleWheelEvent() declaration.

  • html/NumberInputType.cpp: Removed handleWheelEvent() implementation.
  • html/NumberInputType.h:

(NumberInputType): Removed handleWheelEvent() declaration.

  • html/TextFieldInputType.cpp: Removed handleWheelEventForSpinButton() declaration.

(WebCore::TextFieldInputType::forwardEvent): Changed to call SpinButtonElement::forwardEvent().

  • html/TextFieldInputType.h:

(TextFieldInputType): Removed handleWheelEventForSpinButton() declaration.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::forwardEvent): Moved implementation of wheel event handling code
from TextFieldInputType::handleWheelEventForSpinButton().

  • html/shadow/TextControlInnerElements.h:

(SpinButtonElement): Added forwardEvent() declaration.

1:23 AM Changeset in webkit [125521] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK baseline for test introduced in r125462.

  • platform/gtk/svg/filters/color-interpolation-filters-expected.txt:
12:53 AM Changeset in webkit [125520] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Add expectations for recent flakiness.

  • platform/chromium/TestExpectations:
12:48 AM Changeset in webkit [125519] by shinyak@chromium.org
  • 23 edits
    12 adds in trunk

AuthorShadowDOM for meter element
https://bugs.webkit.org/show_bug.cgi?id=91970

Reviewed by Hajime Morita.

Source/WebCore:

We add support for AuthorShadowDOM for a meter element.

According to the Shadow DOM spec, a meter element should behave like having a UserAgentShadowRoot and
an element in UserAgentShadowRoot draws a real 'meter' bar. In this patch, we change the inner structure
of a meter element so that we can distribute an element having RenderMeter to AuthorShadowDOM.

Before this patch, a meter element has the following inner structure.

<meter>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot

|
+-- MeterBarElement
|
+-- MeterValueElement

After this patch, a meter element will have the following inner structure.

<meter>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot

|
+-- MeterInnerElement

|
+-- MeterBarElement
|
+-- MeterValueElement

However, if RenderTheme supports rendering meter, MeterInnerElement will not create a renderer
unless an AuthorShadowDOM is attached to it so that we can keep the current rendering style.

Tests: fast/dom/shadow/shadowdom-for-meter-dynamic.html

fast/dom/shadow/shadowdom-for-meter-multiple.html
fast/dom/shadow/shadowdom-for-meter-with-style.html
fast/dom/shadow/shadowdom-for-meter-without-appearance.html
fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html
fast/dom/shadow/shadowdom-for-meter.html

  • css/html.css:

(meter): Changed the display type. inline-box is not supported WebKit. inline-block is true.
(meter::-webkit-meter-inner-element):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::createRenderer):
(WebCore):
(WebCore::HTMLMeterElement::didElementStateChange):
(WebCore::HTMLMeterElement::willAddAuthorShadowRoot):
(WebCore::HTMLMeterElement::renderMeter):
(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLMeterElement.h:

(WebCore):
(WebCore::HTMLMeterElement::hasAuthorShadowRoot):
(HTMLMeterElement):
(WebCore::isHTMLMeterElement):
(WebCore::toHTMLMeterElement):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::meterElement):
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore):
(WebCore::MeterInnerElement::MeterInnerElement): We introduce a new element having RenderMeter
so that we can distribute an element having RenderMeter to AuthorShadowDOM.
(WebCore::MeterInnerElement::rendererIsNeeded): Different from a progress element, meter element will not be
rendered using a theme. So we don't need to check the style appearance.
(WebCore::MeterInnerElement::createRenderer):
(WebCore::MeterInnerElement::shadowPseudoId):

  • html/shadow/MeterShadowElement.h:

(WebCore):
(MeterInnerElement):
(WebCore::MeterInnerElement::create):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::meterElement):
(WebCore):
(WebCore::RenderMeter::valueRatio):

  • rendering/RenderMeter.h:

(RenderMeter):

LayoutTests:

Contains the following tests:

(1) meter element with AuthorShadowDOM
(2) meter element with multiple AuthorShadowDOM with a shadow element
(3) meter element with multiple AuthorShadowDOM without a shadow element
(4) meter element with AuthorShadowDOM with dynamic value update
(5) meter element with AuthorShadowDOM with style
(6) meter element with AuthorShadowDOM with -webkit-appearance: none

  • fast/dom/HTMLMeterElement/meter-clone-expected.txt:
  • fast/dom/HTMLMeterElement/meter-clone.html:
  • fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
  • fast/dom/shadow/resources/replaced-element-styles.css:

(.meter-like):
(.meter-inner-element-like):

  • fast/dom/shadow/shadowdom-for-meter-dynamic-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-dynamic.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-multiple-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-multiple.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-with-style-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-with-style.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-without-appearance-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-without-appearance.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-without-shadow-element-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html: Added.
  • fast/dom/shadow/shadowdom-for-meter.html: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
  • platform/mac/TestExpectations:
12:46 AM Changeset in webkit [125518] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] inspector/debugger/debugger-pause-on-exception.html is duplicated in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=93936

Unreviewed EFL gardening. Remove duplicated test
in WK2-EFL TestExpectations.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-14

  • platform/efl-wk2/TestExpectations:
12:37 AM Changeset in webkit [125517] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip passing inspector tests after r125394.
https://bugs.webkit.org/show_bug.cgi?id=93228

  • platform/qt/Skipped:
12:36 AM Changeset in webkit [125516] by rniwa@webkit.org
  • 53 edits in trunk/Tools

Rename LayoutTestController to TestRunner in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=93758

Reviewed by Tony Chang.

Renamed LayoutTestController to TestRunner. For Chromium port, it's renamed to DRTTestRunner
since it already has TestRunner class shared between DumpRenderTree and content_shell.

  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/PixelDumpSupport.cpp:
  • DumpRenderTree/StorageTrackerDelegate.h:
  • DumpRenderTree/StorageTrackerDelegate.mm:
  • DumpRenderTree/TestRunner.cpp:
  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/blackberry/DumpRenderTree.cpp:
  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/chromium/DRTTestRunner.cpp:
  • DumpRenderTree/chromium/DRTTestRunner.h:
  • DumpRenderTree/chromium/DumpRenderTree.cpp:
  • DumpRenderTree/chromium/NotificationPresenter.h:
  • DumpRenderTree/chromium/TestShell.cpp:
  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/WebPermissions.cpp:
  • DumpRenderTree/chromium/WebPermissions.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
  • DumpRenderTree/efl/DumpRenderTree.cpp:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  • DumpRenderTree/efl/DumpRenderTreeView.cpp:
  • DumpRenderTree/efl/EditingCallbacks.cpp:
  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/DumpRenderTree.cpp:
  • DumpRenderTree/gtk/EditingCallbacks.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  • DumpRenderTree/mac/EditingDelegate.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/mac/HistoryDelegate.mm:
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
  • DumpRenderTree/mac/PolicyDelegate.h:
  • DumpRenderTree/mac/PolicyDelegate.mm:
  • DumpRenderTree/mac/ResourceLoadDelegate.mm:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:
  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
  • DumpRenderTree/win/DumpRenderTree.cpp:
  • DumpRenderTree/win/EditingDelegate.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/HistoryDelegate.cpp:
  • DumpRenderTree/win/PolicyDelegate.h:
  • DumpRenderTree/win/ResourceLoadDelegate.cpp:
  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/win/UIDelegate.cpp:
  • DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
12:31 AM Changeset in webkit [125515] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] String returned by g_path_get_dirname() must be freed
https://bugs.webkit.org/show_bug.cgi?id=93885

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-14
Reviewed by Philippe Normand.

Fix a memory leak in GTK's DRT code.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(pathFromSoupURI): Free the string returned by g_path_get_dirname().

12:25 AM Changeset in webkit [125514] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[EFL] undefined reference to 'g_type_init' with gold linker
https://bugs.webkit.org/show_bug.cgi?id=93935

Unreviewed build fix. Link against glib-gobject to
fix linking error with gold linker.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-14

  • PlatformEfl.cmake:
12:22 AM Changeset in webkit [125513] by commit-queue@webkit.org
  • 6 edits in trunk

regression(r124510) webintents/web-intents-obj-constructor.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=93096

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-14
Reviewed by Kentaro Hara.

Source/WebCore:

Add null-check for JSC::ExecState pointer in JSDictionary constructor
before using it. The exec may indeed be null, thus causing crashes.

No new test, already tested by webintents/web-intents-obj-constructor.html

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::tryGetProperty):
(WebCore::JSDictionary::getWithUndefinedOrNullCheck):

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::JSDictionary):

LayoutTests:

Unskip webintents/web-intents-obj-constructor.html now that the
crash is fixed in WebCore.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
12:17 AM Changeset in webkit [125512] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[WK2] Add getter for capture attribute of input element
https://bugs.webkit.org/show_bug.cgi?id=93710

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-14
Reviewed by Antonio Gomes.

Add getter for capture attribute to WKOpenPanelParameters to support HTML Media Capture.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebOpenPanelParameters.cpp:

(WebKit):
(WebKit::WebOpenPanelParameters::capture):

  • Shared/WebOpenPanelParameters.h:

(WebOpenPanelParameters):

  • UIProcess/API/C/WKOpenPanelParameters.cpp:

(WKOpenPanelParametersCopyCapture):

  • UIProcess/API/C/WKOpenPanelParameters.h:
12:14 AM Changeset in webkit [125511] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed GTK build fix after r125508.

Do the renaming in GNUmakefile.am as well, LayoutTestController -> TestRunner.

  • GNUmakefile.am:

Aug 13, 2012:

11:49 PM Changeset in webkit [125510] by zandobersek@gmail.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Adding an empty platform baseline for r125462 just to avoid exceptions
in the layout-test step on the buildbots. The baseline will be updated
accordingly later.

  • platform/gtk/svg/filters/color-interpolation-filters-expected.txt: Added.
10:39 PM WebKitIDL edited by Vineet
(diff)
10:35 PM Changeset in webkit [125509] by joone@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] Unreviewed gardening, rebaselining after r125462.

Add a new test result to avoid layout-test exception

  • platform/efl/svg/filters/color-interpolation-filters-expected.txt: Added.
9:58 PM Changeset in webkit [125508] by rniwa@webkit.org
  • 39 edits
    12 moves in trunk/Tools

Rename files that declare and define LayoutTestController in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=93899

Reviewed by Tony Chang.

Renamed files and fixed style errors.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/LayoutTestController.cpp: Removed.
  • DumpRenderTree/LayoutTestController.h: Removed.
  • DumpRenderTree/PixelDumpSupport.cpp:
  • DumpRenderTree/StorageTrackerDelegate.mm:
  • DumpRenderTree/TestRunner.cpp: Copied from Tools/DumpRenderTree/LayoutTestController.cpp.
  • DumpRenderTree/TestRunner.h: Copied from Tools/DumpRenderTree/LayoutTestController.h.

(LayoutTestController):

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:
  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Removed.
  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Copied from Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp.
  • DumpRenderTree/chromium/DRTTestRunner.cpp: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.cpp.
  • DumpRenderTree/chromium/DRTTestRunner.h: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.h.
  • DumpRenderTree/chromium/LayoutTestController.cpp: Removed.
  • DumpRenderTree/chromium/LayoutTestController.h: Removed.
  • DumpRenderTree/chromium/TestShell.cpp:
  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/WebPermissions.cpp:
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/efl/CMakeLists.txt:
  • DumpRenderTree/efl/DumpRenderTree.cpp:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  • DumpRenderTree/efl/DumpRenderTreeView.cpp:
  • DumpRenderTree/efl/EditingCallbacks.cpp:
  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Removed.
  • DumpRenderTree/efl/TestRunnerEfl.cpp: Copied from Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp.
  • DumpRenderTree/gtk/DumpRenderTree.cpp:
  • DumpRenderTree/gtk/EditingCallbacks.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed.
  • DumpRenderTree/gtk/TestRunnerGtk.cpp: Copied from Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp.
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  • DumpRenderTree/mac/EditingDelegate.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/mac/HistoryDelegate.mm:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed.
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
  • DumpRenderTree/mac/PolicyDelegate.mm:
  • DumpRenderTree/mac/ResourceLoadDelegate.mm:
  • DumpRenderTree/mac/TestRunnerMac.mm: Copied from Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm.
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Removed.
  • DumpRenderTree/qt/LayoutTestControllerQt.h: Removed.
  • DumpRenderTree/qt/TestRunnerQt.cpp: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp.
  • DumpRenderTree/qt/TestRunnerQt.h: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.h.

(WebCore):
(LayoutTestController):
(LayoutTestController::setCloseRemainingWindowsWhenComplete):
(LayoutTestController::dumpSelectionRect):
(LayoutTestController::setCallCloseOnWebViews):
(LayoutTestController::addDisallowedURL):
(LayoutTestController::abortModal):

  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
  • DumpRenderTree/win/DumpRenderTree.cpp:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/EditingDelegate.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/HistoryDelegate.cpp:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed.
  • DumpRenderTree/win/PolicyDelegate.cpp:
  • DumpRenderTree/win/ResourceLoadDelegate.cpp:
  • DumpRenderTree/win/TestRunnerWin.cpp: Copied from Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp.

(LayoutTestController::setUserStyleSheetEnabled):
(resolveCygwinPath):

  • DumpRenderTree/win/UIDelegate.cpp:
  • DumpRenderTree/wscript:
  • DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: Removed.
  • DumpRenderTree/wx/TestRunnerWx.cpp: Copied from Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp.
9:29 PM Changeset in webkit [125507] by keishi@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove fade in transition from calendar picker
https://bugs.webkit.org/show_bug.cgi?id=93816

Reviewed by Kent Tamura.

The fade in transition was incomplete because it was only fading in the
popup content and not the popup itself. Removing the effect for now.

No new tests. Can't test animation.

  • Resources/calendarPicker.css:

(#main):

  • Resources/calendarPicker.js:

(initialize):
(fixWindowSize):

8:32 PM Changeset in webkit [125506] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

WPARAM and LPARAM are incorrectly defined for x64
https://bugs.webkit.org/show_bug.cgi?id=89902

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-08-13
Reviewed by Brent Fulgham.

Include WindowsExtras.h for PLATFORM(WIN) to define WPARAM and LPARAM correctly

  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
  • platform/win/WindowMessageListener.h:
8:20 PM Changeset in webkit [125505] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Windows 64 bit compliance
https://bugs.webkit.org/show_bug.cgi?id=93275

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-08-13
Reviewed by Brent Fulgham.

Fixed a few compile and link problems for Win64

  • WinLauncher/WinLauncher.cpp:
  • win/DLLLauncher/DLLLauncherMain.cpp:
7:53 PM Changeset in webkit [125504] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler
https://bugs.webkit.org/show_bug.cgi?id=93918

Patch by John Bates <jbates@google.com> on 2012-08-13
Reviewed by James Robinson.

Also, update some trace events.

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:

(WebCore::CCDelayBasedTimeSource::setActive):

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::setActive):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::onVSyncParametersChanged):

7:52 PM Changeset in webkit [125503] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash in WebCore::RenderBlock::LineBreaker::nextLineBreak
https://bugs.webkit.org/show_bug.cgi?id=93806

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-08-13
Reviewed by Abhishek Arya.

Source/WebCore:

When looking for line breaks on the first line, existing code was
checking for text-combine only in the first-line style. Since
text-combine isn't inherited this resulted in a line break being
chosen before combineText was called. When this happened and then
combineText was called subsequently, the position of the line break
iterator would be invalid.

This patch changes the check to use the regular style as in
skipLeadingWhitespace and textWidth.

Test: fast/text/text-combine-first-line-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Don't use the
first-line style when checking text-combine.

LayoutTests:

  • fast/text/text-combine-first-line-crash-expected.txt: Added.
  • fast/text/text-combine-first-line-crash.html: Added.
7:49 PM EFLWebKitCodingStyle edited by gyuyoung.kim@samsung.com
(diff)
7:49 PM Changeset in webkit [125502] by yutak@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

[Chromium] Unreviewed. Rebaseline test results for add-table-overpaint.html.

  • platform/chromium-mac/fast/repaint/add-table-overpaint-expected.png: Added.
  • platform/chromium-win/fast/repaint/add-table-overpaint-expected.png: Renamed from LayoutTests/platform/chromium/fast/repaint/add-table-overpaint-expected.png.
7:44 PM EFLWebKitCodingStyle edited by gyuyoung.kim@samsung.com
Add #!cpp in ... (diff)
7:43 PM Changeset in webkit [125501] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused method HTMLDocumentParser::script()
https://bugs.webkit.org/show_bug.cgi?id=93916

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-13
Reviewed by Eric Seidel.

The use of HTMLDocumentParser::script() was removed in r61640 and has never been used since then.

No behavior change, so no new tests.

  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
7:37 PM Changeset in webkit [125500] by tsepez@chromium.org
  • 20 edits in trunk/Source

[chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
https://bugs.webkit.org/show_bug.cgi?id=93283

Reviewed by Eric Seidel.

Source/WebCore:

Chromium has a refptr that needs to be NULLed at this point.

The approach is to change the client redirectDataToPlugin method(s) to expect
the possibility of a NULL argument, and the use this to clear the refptr on
the chromium platform. Other platforms can merely ignore the NULL case, thereby
maintaining the existing behaviour.

Formal testing is nearly impossible without some chrome-specific plugins.

  • html/PluginDocument.cpp:

(WebCore::PluginDocument::detach):

Source/WebKit/blackberry:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):

Source/WebKit/chromium:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, NULLing Chromium's refptr that needs to be NULLed.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::redirectDataToPlugin):

Source/WebKit/efl:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::redirectDataToPlugin):

Source/WebKit/gtk:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::redirectDataToPlugin):

Source/WebKit/qt:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::redirectDataToPlugin):

Source/WebKit/win:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::redirectDataToPlugin):

Source/WebKit/wince:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::redirectDataToPlugin):

Source/WebKit/wx:

Chromium has a refptr that needs to be NULLed at this point.

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::redirectDataToPlugin):

Source/WebKit2:

Chromium has a refptr that needs to be NULLed at this point.

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::redirectDataToPlugin):

7:31 PM EFLWebKitCodingStyle edited by rakuco@webkit.org
Add a better explanation about the usage of !!s (diff)
7:17 PM Changeset in webkit [125499] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations to reflect the recent results and
remove lint errors.

  • platform/chromium/TestExpectations:
7:14 PM Changeset in webkit [125498] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] Paint animated layers immediately to avoid animation hiccups.
https://bugs.webkit.org/show_bug.cgi?id=93028

Patch by Eric Penner <epenner@google.com> on 2012-08-13
Reviewed by Adrienne Walker.

Source/WebCore:

This is a technique used on Android, which is very prone
to hiccups in animations. Paint the entire layer if it is
of reasonable size such that there is no hiccups when the
animation reaches unpainted content. The reasonable size
is choosen for page-transitions specifically, as this was
the problem case (animations would just jump to the end).

Since we already have a special case this just modifies it
and replaces the unit test with a new one. This can be
improved/simplified further when distances/directions are
available for the animated layers.

Replaced one test.
Fixed bugs in and improved idlePaintNonVisibleLayers test.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::UpdatableTile::resetUpdateState):
(WebCore::UpdatableTile::markForUpdate):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::markOcclusionsAndRequestTextures):
(WebCore::TiledLayerChromium::haveTexturesForTiles):
(WebCore::TiledLayerChromium::markTilesForUpdate):
(WebCore::TiledLayerChromium::updateTileTextures):
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateContentRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::contentRectToTileIndices):

  • platform/graphics/chromium/cc/CCPriorityCalculator.h:

(WebCore::CCPriorityCalculator::maxPriority):

Source/WebKit/chromium:

Replaced one test. Test painting full animated layer.

  • tests/TiledLayerChromiumTest.cpp:
7:10 PM Changeset in webkit [125497] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Simple refactoring that I forgot to apply in r125495.

  • bindings/v8/V8ThrowException.cpp:

(WebCore::domExceptionStackGetter):
(WebCore::domExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):

  • bindings/v8/V8ThrowException.h:
7:09 PM Changeset in webkit [125496] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[CMAKE][EFL] Fix build break with --tiled-backing-store
https://bugs.webkit.org/show_bug.cgi?id=93487

Unreviewed build fix for Efl with --tiled-backing-store.

  • CMakeLists.txt:

Checked bison version and selected proper glslang files.

7:04 PM Changeset in webkit [125495] by haraken@chromium.org
  • 71 edits
    1 copy
    1 add in trunk/Source/WebCore

[V8] Factor out exception related methods of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93792

Reviewed by Adam Barth.

To remove V8Proxy, this patch factors out exception related methods of V8Proxy
to a separate file.

(1) Move exception related methods from V8Proxy.{h,cpp} to V8ThrowException.{h,cpp}.
(2) To avoid writing V8ThrowException::throwError() here and there in V8 binding,
implement WebCore::throwError() in V8Binding.{h,cpp}. Ideally, we want to list up
all V8 binding APIs in V8Binding.h.
(3) Replace all V8Proxy::throwError() with throwError().

Nit: I couldn't write the definition of WebCore::throwError() in V8BInding.h
due to circular dependency issues. Either way, these methods wouldn't be
performance-critical.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateArgumentsCountCheck):
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateFunctionCallString):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::constructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::MethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::serializedValueCallback):
(WebCore::TestObjV8Internal::idbKeyCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod5Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert3Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::constructorCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

  • bindings/v8/DateExtension.cpp:

(WebCore::DateExtension::OnSleepDetected):

  • bindings/v8/NPV8Object.cpp:

(_NPN_SetException):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::SerializedScriptValue):

  • bindings/v8/V8Binding.cpp:

(WebCore::setDOMException):
(WebCore):
(WebCore::throwError):
(WebCore::throwTypeError):
(WebCore::throwNotEnoughArgumentsError):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::toV8Sequence):

  • bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectPropertyEnumerator):

  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8Proxy.cpp:

(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::V8Proxy::checkNewLegal):

  • bindings/v8/V8Proxy.h:

(V8Proxy):
(WebCore):

  • bindings/v8/V8ThrowException.cpp: Added.

(WebCore):
(WebCore::DOMExceptionStackGetter):
(WebCore::DOMExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):
(WebCore::V8ThrowException::throwError):
(WebCore::V8ThrowException::throwTypeError):
(WebCore::V8ThrowException::throwNotEnoughArgumentsError):

  • bindings/v8/V8ThrowException.h: Added.

(WebCore):
(V8ThrowException):

  • bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):
(WebCore::getMessagePortArray):
(WebCore::setTypeMismatchException):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::evaluate):

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallback):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertySetter):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallback):
(WebCore::V8DOMFormData::appendCallback):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertySetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):
(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):
(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DirectoryEntryCustom.cpp:

(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):

  • bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:

(WebCore::V8DirectoryEntrySync::getDirectoryCallback):
(WebCore::V8DirectoryEntrySync::getFileCallback):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::toDataURLCallback):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::openCallback):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::V8HTMLElement::itemValueAccessorSetter):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionStartAccessorGetter):
(WebCore::V8HTMLInputElement::selectionStartAccessorSetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorGetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorSetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter):
(WebCore::V8HTMLInputElement::setSelectionRangeCallback):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAccessorSetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addCallback):
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::inspectedObjectCallback):

  • bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallback):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::protocolAccessorSetter):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallback):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::valueAccessorGetter):
(WebCore::V8SVGLength::valueAccessorSetter):
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageSetter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

  • bindings/v8/custom/V8WebKitPointConstructor.cpp:

(WebCore::V8WebKitPoint::constructorCallback):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):
(WebCore::V8WebSocket::sendCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::importScriptsCallback):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
(WebCore::V8XMLHttpRequest::openCallback):
(WebCore::V8XMLHttpRequest::sendCallback):

6:48 PM EFLWebKitCodingStyle edited by eunmi15.lee@samsung.com
(diff)
6:45 PM Changeset in webkit [125494] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h
https://bugs.webkit.org/show_bug.cgi?id=93818

Reviewed by Adam Barth.

(1) This patch moves GCEventData class from V8Binding.h to ScriptGCEvent.h.
(2) This patch makes GCEventData::startTime and GCEventData::usedHeapSize
private members.
(3) This patch removes unused forward declarations from V8Binding.h.

No tests. No change in behavior.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):

  • bindings/v8/ScriptGCEvent.h:

(GCEventData):
(WebCore::GCEventData::GCEventData):
(WebCore::GCEventData::clear):
(WebCore::GCEventData::listeners):
(WebCore::GCEventData::startTime):
(WebCore::GCEventData::setStartTime):
(WebCore::GCEventData::usedHeapSize):
(WebCore::GCEventData::setUsedHeapSize):
(WebCore):

  • bindings/v8/V8Binding.h:

(WebCore):

  • bindings/v8/V8PerIsolateData.cpp:
6:39 PM Changeset in webkit [125493] by haraken@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

[V8] Move checkNewLegal() from V8Proxy.h to SafeAllocation.h
https://bugs.webkit.org/show_bug.cgi?id=93830

Reviewed by Adam Barth.

This patch moves checkNewLegal() from V8Proxy.h to SafeAllocation.h.
In addition, this patch renames checkNewLegal() to isValidConstructorMode()
for clarification.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/SafeAllocation.cpp: Added.
  • bindings/v8/SafeAllocation.h:

(WebCore::SafeAllocation::newInstance):
(WebCore):

  • bindings/v8/V8Binding.cpp:

(WebCore::createRawTemplate):

  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:

(V8Proxy):

6:38 PM EFLWebKitCodingStyle edited by gyuyoung.kim@samsung.com
Add new coding style related to double not operator(!!) (diff)
6:34 PM Changeset in webkit [125492] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove unused methods from V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=93836

Reviewed by Adam Barth.

enableStringImplCache() and v8UndetectableString() are not used by anybody.

No tests. No change in behavior.

  • bindings/v8/V8Binding.h:
6:32 PM Changeset in webkit [125491] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h
https://bugs.webkit.org/show_bug.cgi?id=93834

Reviewed by Adam Barth.

This patch moves hintForGCIfNecessary() from V8Proxy.h to V8GCController.h.

No tests. No change in behavior.

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::hintForGCIfNecessary):

  • bindings/v8/V8GCController.h:

(V8GCController):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::clearForClose):
(WebCore::V8Proxy::clearForNavigation):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

6:29 PM Changeset in webkit [125490] by shawnsingh@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed rebaseline after r125193.

  • platform/chromium-mac/compositing/masks/layer-mask-placement-expected.png:
  • platform/chromium-win/compositing/masks/layer-mask-placement-expected.png:
  • platform/chromium/TestExpectations:
6:27 PM Changeset in webkit [125489] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r124970.
http://trac.webkit.org/changeset/124970
https://bugs.webkit.org/show_bug.cgi?id=93495

Postponing the merge in a clearer context (Requested by
Michelangelo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransform):

  • css/CSSParser.h:
6:24 PM Changeset in webkit [125488] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add test to demonstrate overpainting seen in bug 92800
https://bugs.webkit.org/show_bug.cgi?id=93901

Reviewed by Levi Weintraub.

Bug 92800 is a rather complicated change to fix this overpainting bug.
Adding the test before the change so that it's easier for me to track as I change
this behavior and for reviewers to see that I'm fixing this overpainting.

  • fast/repaint/add-table-overpaint-expected.png: Added.
  • fast/repaint/add-table-overpaint-expected.txt: Added.
  • fast/repaint/add-table-overpaint.html: Added.
6:04 PM Changeset in webkit [125487] by morrita@google.com
  • 2 edits in trunk/Tools

Unreviewed update for webcomponents-bugzilla address.

  • Scripts/webkitpy/common/config/committers.py:
6:03 PM Changeset in webkit [125486] by shawnsingh@chromium.org
  • 4 edits in trunk/Source

[chromium] renderSurface in incorrect space if owning layer has empty but non-zero bounds
https://bugs.webkit.org/show_bug.cgi?id=93795

Reviewed by Adrienne Walker.

Source/WebCore:

If a renderSurface is created by a layer that had zero
area (empty) but non-zero bounds (either width or height was
non-zero), then one translation transform was accidentally being
skipped, causing the renderSurface drawTransform to be incorrect.
The fix is simply to move that transform outside of the
if-statement so it is not skipped.

Unit test added:

CCLayerTreeHostCommonTest.verifyTransformsForDegenerateIntermediateLayer()

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:
5:57 PM Changeset in webkit [125485] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

Enable CSS Sticky Position on Windows.
https://bugs.webkit.org/show_bug.cgi?id=93905

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-13
Reviewed by Tim Horton.

As per https://bugs.webkit.org/show_bug.cgi?id=90046, the ENABLE_CSS_STICKY_POSITION needs to be turned on for Windows as well.

  • win/tools/vsprops/FeatureDefines.vsprops:

Include ENABLE_CSS_STICKY_POSITION flag.

5:55 PM Changeset in webkit [125484] by haraken@chromium.org
  • 18 edits in trunk/Source/WebCore

[V8] Remove [TreatReturnedNullAs=False]
https://bugs.webkit.org/show_bug.cgi?id=93835

Reviewed by Adam Barth.

[TreatReturnedNullAs=False] is neither defined in the Web IDL spec
nor used in any WebKit IDL file.

No tests. No change in behavior.

  • WebCore.order:
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:

(WebCore):

  • bindings/scripts/CodeGeneratorJS.pm:

(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(NativeToJSValue):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • bindings/v8/V8Binding.h:
5:53 PM Changeset in webkit [125483] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Rename v8ValueToWebCoreDOMStringList() to toDOMStringList()
https://bugs.webkit.org/show_bug.cgi?id=93839

Reviewed by Adam Barth.

For naming consistency with toWebCoreString() and toWebCoreAtomicString(),
this patch renames v8ValueToWebCoreDOMStringList() to toDOMStringList().
("WebCore" wouldn't be needed because it's clear from "DOMStringList".)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(JSValueToNative):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):

  • bindings/v8/V8Binding.h:

(WebCore):

5:51 PM Changeset in webkit [125482] by haraken@chromium.org
  • 14 edits in trunk/Source/WebCore

[V8] Rename v8ValueToAtomicWebCoreString() to toWebCoreAtomicString()
https://bugs.webkit.org/show_bug.cgi?id=93824

Reviewed by Adam Barth.

For naming consistency with toWebCoreString(), we can rename
v8ValueToAtomicWebCoreString() to toWebCoreAtomicString().
Also we can rename v8ValueToAtomicWebCoreStringWithNullCheck()
to toWebCoreAtomicStringWithNullCheck().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):

  • bindings/v8/V8Binding.cpp:

(WebCore::toWebCoreAtomicString):

  • bindings/v8/V8Binding.h:

(WebCore::toWebCoreStringWithNullOrUndefinedCheck):
(WebCore::toWebCoreAtomicStringWithNullCheck):

  • bindings/v8/V8Collection.h:

(WebCore::getNamedPropertyOfCollection):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

5:49 PM Changeset in webkit [125481] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] Remove v8ValueToWebCoreString()
https://bugs.webkit.org/show_bug.cgi?id=93822

Reviewed by Adam Barth.

There are two equivalent ways to convert a V8 value to a WebCore String;
i.e. v8ValueToWebCoreString() and toWebCoreString(). We can remove the former.

In a follow-up patch, I will replace v8ValueToAtomicWebCoreString()
with toWebCoreAtomicString(), for consistency with toWebCoreString().

No tests. No change in behavior.

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):
(WebCore::Dictionary::getWithUndefinedOrNullCheck):
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):

  • bindings/v8/V8Binding.cpp:

(WebCore::toWebCoreString):
(WebCore::v8ValueToWebCoreDOMStringList):

  • bindings/v8/V8Binding.h:

(WebCore::toWebCoreStringWithNullCheck):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::initMessageEventCallback):

5:47 PM Changeset in webkit [125480] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Move the ConstructorMode class from V8Binding.h to SafeAllocation.h
https://bugs.webkit.org/show_bug.cgi?id=93821

Reviewed by Adam Barth.

This patch factors out the ConstructorMode class from V8Binding.h to SafeAllocation.h.

No tests. No change in behavior.

  • bindings/v8/SafeAllocation.h:

(ConstructorMode):
(WebCore::ConstructorMode::ConstructorMode):
(WebCore::ConstructorMode::~ConstructorMode):
(WebCore::ConstructorMode::current):
(WebCore):

  • bindings/v8/V8Binding.h:
  • bindings/v8/V8RecursionScope.h:
5:44 PM Changeset in webkit [125479] by haraken@chromium.org
  • 5 edits
    2 deletes in trunk/Source/WebCore

[V8] Remove V8BindingHelpers
https://bugs.webkit.org/show_bug.cgi?id=93807

Reviewed by Adam Barth.

V8BindingHelpers contains toV8Context() and toV8Proxy(), which are used
by NPV8Object.cpp only.

(1) Move these methods to NPV8Object.cpp as static methods.
(2) Remove V8BindingHelpers.{h,cpp}.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/NPV8Object.cpp:

(WebCore::toV8Context):
(WebCore):
(WebCore::toV8Proxy):

  • bindings/v8/V8Binding.h:
  • bindings/v8/V8BindingHelpers.cpp: Removed.
  • bindings/v8/V8BindingHelpers.h: Removed.
5:42 PM Changeset in webkit [125478] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Remove unused methods and headers from V8Utilities
https://bugs.webkit.org/show_bug.cgi?id=93805

Reviewed by Adam Barth.

This patch removes unused methods, forward declarations and
headers from V8Utilities.{h,cpp}.

No tests. No change in behavior.

  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/V8Utilities.h:

(WebCore):

5:40 PM Changeset in webkit [125477] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Move V8PerIsolateData::visitExternalStrings() to V8PerIsolateData.cpp
https://bugs.webkit.org/show_bug.cgi?id=93803

Reviewed by Adam Barth.

In r125015, I forgot to move V8PerIsolateData::visitExternalStrings()
to V8PerIsolateData.cpp. This patch moves it.

No tests. No change in behavior.

  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8PerIsolateData.cpp:

(WebCore):
(WebCore::V8PerIsolateData::visitExternalStrings):

5:38 PM Changeset in webkit [125476] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Expand list of supported languages for RenderQuote to match WHATWG spec
https://bugs.webkit.org/show_bug.cgi?id=93424

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-08-13
Reviewed by Eric Seidel.

Source/WebCore:

Expand the table of quotes to include the 148 lang values and associated quotes
from the WHATWG web-apps recommended styling spec.

Test: fast/css-generated-content/quotes-lang-case-insensitive.html

  • rendering/RenderQuote.cpp: Added missing copyright.

(WebCore::quotesDataLanguageMap): Expanded the table of quotes.
(WebCore::basicQuotesData): Added a FIXME to switch to using stylized "en" quotes.

  • rendering/RenderQuote.h: Added missing copyright.

LayoutTests:

Update quote language test to include the 148 languages in the WHATWG web-apps
recommended styling table.
http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#quotes

Add a new test that ensures language matching for quotes is case insensitive.

  • fast/css-generated-content/quotes-lang-case-insensitive-expected.html: Added.
  • fast/css-generated-content/quotes-lang-case-insensitive.html: Added.
  • fast/css-generated-content/quotes-lang-expected.html:
  • fast/css-generated-content/quotes-lang.html:
5:36 PM Changeset in webkit [125475] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Remove evaluateInIsolatedWorld() from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93679

Reviewed by Adam Barth.

To remove V8Proxy, this patch moves V8Proxy::evaluateInIsolatedWorld()
to ScriptController.

No tests. No change in behavior.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::evaluateInIsolatedWorld):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::precompileScript):

5:33 PM Changeset in webkit [125474] by shawnsingh@chromium.org
  • 8 edits
    4 copies in branches/chromium/1229

Merge 125193 - [chromium] Pass mask scale and offset to shaders for correct masking
https://bugs.webkit.org/show_bug.cgi?id=93558

Reviewed by Adrienne Walker.

Source/WebCore:

In chromium compositor code, the mask was accidentally mapped 1:1
to the layer's renderSurface, rather than the layer itself. This
patch adds a layout test that reproduces the error and fixes the
problem. The solution we opted for in this patch is to pass a
scale and offset to the fragment shader, so that the correct
texture coordinate lookup is computed by the fragment shader.

Test: compositing/masks/mask-of-clipped-layer.html

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPassQuad):

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentShaderRGBATexAlphaMask::FragmentShaderRGBATexAlphaMask):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderRGBATexAlphaMask::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::FragmentShaderRGBATexAlphaMaskAA):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::FragmentShaderRGBATexAlphaMask::maskTexCoordScaleLocation):
(WebCore::FragmentShaderRGBATexAlphaMask::maskTexCoordOffsetLocation):
(FragmentShaderRGBATexAlphaMask):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskTexCoordScaleLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskTexCoordOffsetLocation):
(FragmentShaderRGBATexAlphaMaskAA):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::maskTexCoordScaleX):
(WebCore::CCRenderPassDrawQuad::maskTexCoordScaleY):
(WebCore::CCRenderPassDrawQuad::maskTexCoordOffsetX):
(WebCore::CCRenderPassDrawQuad::maskTexCoordOffsetY):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendQuads):

Source/WebKit/chromium:

Updated one unit test that needed additional args in a
constructor, but no change in behavior of the test.

  • tests/CCLayerTreeHostImplTest.cpp:

LayoutTests:

Added a layout test that checks the mask does not accidentally get
resized when it is inside of an overflow div.

  • compositing/masks/mask-of-clipped-layer-expected.png: Added.
  • compositing/masks/mask-of-clipped-layer-expected.txt: Added.
  • compositing/masks/mask-of-clipped-layer.html: Added.
  • compositing/resources/alpha-blocks.png: Added.

TBR=shawnsingh@chromium.org

5:22 PM Changeset in webkit [125473] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Exclusions] Remove unused CSSWrapShapes header includes
https://bugs.webkit.org/show_bug.cgi?id=93395

Patch by Bear Travis <betravis@adobe.com> on 2012-08-13
Reviewed by Kentaro Hara.

Removing the #include "CSSWrapShapes.h" lines from StyleBuilder.cpp and
RenderStyle.cpp. Both files now use the length-based WrapShapes.h classes.

  • css/StyleBuilder.cpp:
  • rendering/style/RenderStyle.cpp:
5:11 PM Changeset in webkit [125472] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Bad cast in RenderBox::computeReplacedLogicalHeightUsing
https://bugs.webkit.org/show_bug.cgi?id=93875

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-08-13
Reviewed by Abhishek Arya.

Source/WebCore:

Pointer to the container of a replaced element was being type casted to renderbox
without checking if the container is a renderbox or not.

Test: fast/replaced/render-inline-cast-to-render-box-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

Scrollbar height is retrieved only if the container is a renderBox. Otherwise scrollbar is taken as zero.

LayoutTests:

  • fast/replaced/render-inline-cast-to-render-box-crash-expected.txt: Added.
  • fast/replaced/render-inline-cast-to-render-box-crash.html: Added.
5:05 PM Changeset in webkit [125471] by dino@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r125450): 4 canvas/philip/tests tests failing on Apple Lion Release WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93910

Unreviewed test expectations update. Temporarily skipping tests.

  • platform/mac/TestExpectations:
4:49 PM Changeset in webkit [125470] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Unreviewed bot fix after r125467.

  • PlatformEfl.cmake: Make the WK2 tests link against glib, gobject

and gio as well.

4:45 PM Changeset in webkit [125469] by jamesr@google.com
  • 11 edits
    1 move
    1 add in trunk/Source

[chromium] Make WebAnimation a pure virtual interface to hide implementation and avoid unresolved symbols
https://bugs.webkit.org/show_bug.cgi?id=93907

Reviewed by Darin Fisher.

Source/Platform:

This makes WebAnimation a pure virtual interface with instances returned by a factory function. Currently the
factory is a static function on WebAnimation, but it will likely move to a platform support interface. This
provides better isolation of the implementation from the interface and in particular allows for implementing the
WebAnimation interface outside of WebKit.dll without having unresolved external symbols in WebKit.dll.

  • chromium/public/WebAnimation.h:

(WebKit::WebAnimation::~WebAnimation):
(WebAnimation):

  • chromium/public/WebLayer.h:

(WebLayer):

Source/WebCore:

Updates WebAnimation users for interface changes.

  • platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::createWebAnimation):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::addAnimation):

Source/WebKit/chromium:

Adds a WebAnimationImpl implementation of the WebAnimation interface.

  • WebKit.gyp:
  • src/WebAnimationImpl.cpp: Renamed from Source/WebKit/chromium/src/WebAnimation.cpp.

(WebKit):
(WebKit::WebAnimation::create):
(WebKit::WebAnimationImpl::targetProperty):
(WebKit::WebAnimationImpl::iterations):
(WebKit::WebAnimationImpl::setIterations):
(WebKit::WebAnimationImpl::startTime):
(WebKit::WebAnimationImpl::setStartTime):
(WebKit::WebAnimationImpl::timeOffset):
(WebKit::WebAnimationImpl::setTimeOffset):
(WebKit::WebAnimationImpl::alternatesDirection):
(WebKit::WebAnimationImpl::setAlternatesDirection):
(WebKit::WebAnimationImpl::cloneToCCAnimation):

  • src/WebAnimationImpl.h: Added.

(WebCore):
(WebKit):
(WebAnimationImpl):
(WebKit::WebAnimationImpl::WebAnimationImpl):
(WebKit::WebAnimationImpl::~WebAnimationImpl):

  • src/WebLayer.cpp:

(WebKit::WebLayer::addAnimation):

  • tests/WebAnimationTest.cpp:

(WebKit::TEST):

4:41 PM Changeset in webkit [125468] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Unreviewed attempt at fixing the bots after r125467.

  • PlatformEfl.cmake: Link against GIO and GObject due to the usage

of libsoup.

4:30 PM Changeset in webkit [125467] by rakuco@webkit.org
  • 15 edits
    1 add
    1 delete in trunk

[CMake] Rewrite FindLibSoup2.cmake.
https://bugs.webkit.org/show_bug.cgi?id=93191

Reviewed by Rob Buis.

.:

The existing LibSoup2 was imported from somewhere else and not
only did it contain a lot of unnecessary cruft to look for libsoup
2.2 (which we do not support anyway), but it also relied on the
paths returned by pkg-config for setting the library and include
paths.

For one, this meant "-lsoup-2.4" was passed to the linked instead
of "-L/path/to/libsoup-2.4.so", which would sometimes make a
system version of libsoup to be picked up instead of the one
installed by, say, jhbuild.

The new FindLibSoup.cmake now only looks for libsoup 2.4 and
relies on pkg-config solely for retrieving the current LibSoup
version.

  • Source/cmake/FindLibSoup.cmake: Added.
  • Source/cmake/FindLibSoup2.cmake: Removed.
  • Source/cmake/OptionsEfl.cmake: Look for LibSoup instead of

LibSoup2, look for the GObject component of Glib.

Source/WebCore:

  • PlatformEfl.cmake: Use LIBSOUP_FOO instead of LIBSOUP24_FOO,

also link against GObject, which is needed by libsoup.

Source/WebKit:

  • PlatformEfl.cmake: Use LIBSOUP_FOO instead of LIBSOUP24_FOO.

Source/WebKit2:

  • PlatformEfl.cmake: Use LIBSOUP_FOO instead of LIBSOUP24_FOO, and

do not use LIBSOUP24_LDFLAGS, as it is not needed anymore.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt: Use LIBSOUP_FOO instead of

LIBSOUP24_FOO, and do not use LIBSOUP24_LDFLAGS, as it is not
needed anymore.

  • EWebLauncher/CMakeLists.txt: Ditto.
  • MiniBrowser/efl/CMakeLists.txt: Ditto.
  • TestWebKitAPI/PlatformEfl.cmake: Ditto.
  • WebKitTestRunner/CMakeLists.txt: Ditto.
  • WebKitTestRunner/PlatformEfl.cmake: Ditto.
3:46 PM Changeset in webkit [125466] by jamesr@google.com
  • 12 edits
    2 adds in trunk/Source

[chromium] Clean up dependencies for Canvas2DLayerBridgeTest and GraphicsLayerChromiumTest unit tests
https://bugs.webkit.org/show_bug.cgi?id=93757

Reviewed by Adrienne Walker.

Source/Platform:

Exposes a function to check for active animations on a layer.

  • chromium/public/WebLayer.h:

(WebLayer):

Source/WebCore:

Exposes the current contentsScale for tests.

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

Source/WebKit/chromium:

Breaks up some unit tests and removes unused code to avoid unit tests depending on both non-compositor WebCore
logic and compositor internals. Canvas2DLayerBridgeTest had some vestigal includes and local variables that
weren't being used, those are removed. GraphicsLayerChromiumTest was reaching into CC types, but could mostly
use Platform API types for testing.

GraphicsLayerChromiumTest had some tests that were verifying that we could correctly translate WebCore
animation lists into CCAnimation types - these have been moved into AnimationTranslationUtilTest.cpp, since the
logic under test is in AnimationTranslationUtil. Currently these only test that we accept / reject animations as
expected. They could be expanded to verify that the animation was translated faithfully, but that would require
expanding the information exposed on WebAnimation.

  • WebKit.gypi:
  • src/WebLayer.cpp:

(WebKit::WebLayer::hasActiveAnimation):
(WebKit):

  • tests/Canvas2DLayerBridgeTest.cpp:

(Canvas2DLayerBridgeTest::fullLifecycleTest):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(GraphicsLayerChromiumTest):
(WebKit::TEST_F):

  • tests/WebLayerTreeViewTest.cpp:
  • tests/WebLayerTreeViewTestCommon.h: Added.

(WebKit):
(MockWebLayerTreeViewClient):

3:44 PM Changeset in webkit [125465] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Reduce the size of empty NinePieceImage objects.
<http://webkit.org/b/93747>

Reviewed by Antti Koivisto.

Move the members of NinePieceImage into a NinePieceImageData class, leaving NinePieceImage
with a single OwnPtr<NinePieceImageData> member. The constant NinePieceImage::defaultData()
provides default values for objects with null m_data.

RenderStyle's "StyleSurroundData" member has a BorderData, which in turn holds a NinePieceImage.
This means that anything with left/right/top/bottom, margin, padding or border style but *no*
border-image will save 104 bytes (assuming their RenderStyle is unshared, which is fairly common.)

This reduces the size of StyleSurroundData by 104 bytes, effectively reducing memory consumption
by 1.72MB when viewing the full HTML5 spec at <http://whatwg.org/c>

  • rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImageData::operator==):
(WebCore::NinePieceImage::defaultData):
(WebCore):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImageData::NinePieceImageData):
(NinePieceImageData):
(WebCore::NinePieceImageData::operator!=):
(WebCore):
(NinePieceImage):
(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImage::operator=):
(WebCore::NinePieceImage::operator==):
(WebCore::NinePieceImage::operator!=):
(WebCore::NinePieceImage::hasImage):
(WebCore::NinePieceImage::image):
(WebCore::NinePieceImage::setImage):
(WebCore::NinePieceImage::imageSlices):
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::fill):
(WebCore::NinePieceImage::setFill):
(WebCore::NinePieceImage::borderSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::outset):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::horizontalRule):
(WebCore::NinePieceImage::setHorizontalRule):
(WebCore::NinePieceImage::verticalRule):
(WebCore::NinePieceImage::setVerticalRule):
(WebCore::NinePieceImage::copyImageSlicesFrom):
(WebCore::NinePieceImage::copyBorderSlicesFrom):
(WebCore::NinePieceImage::copyOutsetFrom):
(WebCore::NinePieceImage::copyRepeatFrom):
(WebCore::NinePieceImage::setMaskDefaults):
(WebCore::NinePieceImage::ensureData):
(WebCore::NinePieceImage::data):

3:42 PM Changeset in webkit [125464] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=93883

More Windows build fixing.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::dummy):
3:39 PM Changeset in webkit [125463] by Lucas Forschler
  • 6 edits
    16 deletes in branches/safari-536.26-branch

Merge fix for <rdar://problem/12050793>.

3:37 PM Changeset in webkit [125462] by fmalita@chromium.org
  • 41 edits
    3 adds in trunk

WebKit+SVG does not support color-interpolation-filters or draw filters in correct colorspace
https://bugs.webkit.org/show_bug.cgi?id=6033

Reviewed by Dirk Schulze.

Source/WebCore:

This patch adds support for SVG color-interpolation-filters. All non-CG plarforms now
perform color space conversions as needed (CG performs color space adjustments internally),
and the new default color space for filters is linearRGB
(http://www.w3.org/TR/SVG/filters.html#FilterPrimitivesOverviewIntro).

FilterEffect tracks the color-interpolation-filters attribute (m_colorSpace) and the
current result color space (m_resultColorSpace). When applying, the input results are
converted to the current FilterEffect's color space, and at the end of the filter effect
chain the result is finally converted to ColorSpaceDeviceRGB.

FilterEffect::transformResultColorSpace() handles non-CG color space converion (CG has
built in support for different color spaces) by first converting the result to an image
buffer, and then using the platform specific ImageBuffer::transformColorSpace(). This can
be expensive for filter chains with alternating color-interpolation-filters, but can be
optimized if/when color space support is added to all the graphics backends similarly to CG.

As expected, lots of filter-related pixel results will require rebaselining after this lands.

Test: svg/filters/color-interpolation-filters.svg

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::apply):
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::transformResultColorSpace):
(WebCore):

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::colorSpace):
(WebCore::FilterEffect::setColorSpace):
(FilterEffect):

  • platform/graphics/filters/SourceGraphic.h:

(WebCore::SourceGraphic::SourceGraphic):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::apply):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::postApplyResource):

LayoutTests:

  • platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-linux/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
  • platform/chromium-linux/css3/filters/custom/filter-repaint-custom-expected.png:
  • platform/chromium-linux/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
  • platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png:
  • platform/chromium-linux/css3/filters/effect-brightness-expected.png:
  • platform/chromium-linux/svg/filters/color-interpolation-filters-expected.png: Added.
  • platform/chromium-linux/svg/filters/color-interpolation-filters-expected.txt: Added.
  • platform/chromium-win/css3/filters/add-filter-rendering-expected.png:
  • platform/chromium-win/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-win/css3/filters/effect-blur-expected.png:
  • platform/chromium-win/css3/filters/effect-combined-expected.png:
  • platform/chromium-win/css3/filters/effect-contrast-expected.png:
  • platform/chromium-win/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-win/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-win/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-win/css3/filters/effect-invert-expected.png:
  • platform/chromium-win/css3/filters/effect-opacity-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-external-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-ordering-expected.png:
  • platform/chromium-win/css3/filters/effect-saturate-expected.png:
  • platform/chromium-win/css3/filters/effect-sepia-expected.png:
  • platform/chromium-win/css3/filters/filtered-inline-expected.png:
  • platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png:
  • platform/chromium-win/css3/filters/nested-filters-expected.png:
  • platform/chromium-win/css3/filters/regions-expanding-expected.png:
  • platform/chromium-win/css3/filters/simple-filter-rendering-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/css3/filters/blur-filter-page-scroll-expected.png:
  • platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • svg/filters/color-interpolation-filters.svg: Added.
3:35 PM Changeset in webkit [125461] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r125104. <rdar://problem/12082988>

3:16 PM Changeset in webkit [125460] by commit-queue@webkit.org
  • 7 edits in trunk

Oscillator node should throw exception if type is assigned an invalid value
https://bugs.webkit.org/show_bug.cgi?id=93490

Patch by Raymond Toy <Raymond Toy> on 2012-08-13
Reviewed by Chris Rogers.

Source/WebCore:

New tests added to oscillator-basic to catch exceptions.

  • Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::Oscillator):
(WebCore::Oscillator::setType): Return exception

  • Modules/webaudio/Oscillator.h:

(Oscillator): Update setType declaration

  • Modules/webaudio/Oscillator.idl: setType can raise exception.

LayoutTests:

Add tests for invalid oscillator types.

  • webaudio/oscillator-basic-expected.txt: Updated
  • webaudio/oscillator-basic.html: Test CUSTOM and invalid

oscillator type.

3:16 PM Changeset in webkit [125459] by Lucas Forschler
  • 5 edits
    3 copies in branches/safari-536.26-branch

Merged r125086. <rdar://problem/12082988>

3:07 PM Changeset in webkit [125458] by ap@apple.com
  • 4 edits in trunk/Source/WebKit2

[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=93883

More Windows build fix

  • UIProcess/WebContext.cpp: (WebKit::WebPage::dummy):
  • UIProcess/WebContext.h: (WebContext):
  • UIProcess/WebContext.messages.in: Add a dummy sync message - the same workaround is already used in WebPage.
3:04 PM Changeset in webkit [125457] by beidson@apple.com
  • 10 edits
    3 adds in trunk

With asynchronous plug-in initialization, WebProcess and PluginProcess can deadlock
<rdar://problem/12062125> and https://bugs.webkit.org/show_bug.cgi?id=93894

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

A few things were in play here:

  • The WebProcess thought the plug-in was done initializing but it wasn't.
  • The sync message out from the PluginProcess was not being handled by the WebProcess.

Expose the ability for the PluginProcess to act as if it is handling a sync message and needs messages dispatched:

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::incrementDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount):
(CoreIPC::Connection::decrementDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount):

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::setInitializationReply): Save the delayed reply for synchronous initialization.
(WebKit::PluginControllerProxy::takeInitializationReply): Give back the delayed reply for initialization completion.
(WebKit::PluginControllerProxy::initialize):

  • PluginProcess/PluginControllerProxy.h:

(WebKit::PluginControllerProxy::isInitializing): Accessor so WebProcessConnection knows whether or not to store the

delayed reply for later.

  • PluginProcess/WebProcessConnection.messages.in: Make the synchronous form of "CreatePlugin" have a delayed reply.
  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPlugin): Store away the delayed reply message so it can be responded to after

asynchronous initialization completes.

(WebKit::WebProcessConnection::createPluginAsynchronously): If there is a stored away delayed reply message, respond to

it instead of sending the asynchronously reply.

  • PluginProcess/WebProcessConnection.h:

(WebProcessConnection):

Tools:

Add a test that calls out to NPP_Evaluate for some JS inside of NPP_New.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp: Added.

(EvaluteJSWithinNPP_New):
(EvaluteJSWithinNPP_New::EvaluteJSWithinNPP_New):
(EvaluteJSWithinNPP_New::NPP_New):

LayoutTests:

  • platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate-expected.txt: Added.
  • platform/mac-wk2/plugins/asychronous-deadlock-with-timer-and-evaluate.html: Added.
3:03 PM Changeset in webkit [125456] by crogers@google.com
  • 4 edits in trunk/Source/WebCore

AudioContext::createMediaStreamSource() must create a provider for local MediaStreams
https://bugs.webkit.org/show_bug.cgi?id=93756

Reviewed by Eric Carlson.

There are two main kinds of MediaStreams (local and from remote peers).
Internally we need to know the difference so a MediaStreamAudioSourceNode will "just work".

Tested by existing test: mediastreamaudiosourcenode.html
Full testing can only be verified by manual tests.

  • Modules/mediastream/LocalMediaStream.h:

(LocalMediaStream):

  • Modules/mediastream/MediaStream.h:

(WebCore::MediaStream::isLocal):
(MediaStream):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource):

2:51 PM Changeset in webkit [125455] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r123013. <rdar://problem/12087344>

2:49 PM Changeset in webkit [125454] by fmalita@chromium.org
  • 5 edits in trunk

Unreviewed, rolling out r125422.
http://trac.webkit.org/changeset/125422
https://bugs.webkit.org/show_bug.cgi?id=93902

Broke the Android canary build (Requested by fmalita on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2:42 PM Changeset in webkit [125453] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=93883

Windows build fix.

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): (WebKit::WebProcess::clearPluginSiteData): Use WebProcessProxy for the message here, too.
2:37 PM Changeset in webkit [125452] by Simon Hausmann
  • 5 edits in trunk/Source

Unreviewed, rolling out r125444.
http://trac.webkit.org/changeset/125444
https://bugs.webkit.org/show_bug.cgi?id=93872

Broke some tests

Source/JavaScriptCore:

  • Target.pri:

Source/WebCore:

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):

  • bridge/qt/qt_runtime.h:

(QtRuntimeMethod):

2:29 PM Changeset in webkit [125451] by ap@apple.com
  • 10 edits in trunk/Source/WebKit2

[WK2] Move a remaining per-process message from WebContext to WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=93883

Reviewed by Sam Weinig.

There was one plug-in message renaming. Moving it, and also other plug-in messages
for consistency.

  • UIProcess/WebContext.cpp: (WebKit): Got rid of the last MESSAGE_CHECK in this file. (WebKit::WebContext::WebContext): Moved m_pluginWorkQueue to a singleton. We don't need more than one queue (all it does is read plug-in info), and if we needed, it would have been per-process, not per-context. (WebKit::WebContext::~WebContext): No more work queue. (WebKit::WebContext::processDidFinishLaunching): Ditto.
  • UIProcess/WebContext.h: No longer needs to be a QueueClient.
  • UIProcess/WebContext.messages.in:
  • UIProcess/WebProcessProxy.messages.in: Moved plug-in related messages.
  • UIProcess/WebProcessProxy.cpp: (WebKit::pluginWorkQueue): Moved from WebContext to a singleton. (WebKit::WebProcessProxy::sendDidGetPlugins): Moved from WebContext. (WebKit::WebProcessProxy::handleGetPlugins): Ditto. (WebKit::WebProcessProxy::getPlugins): Ditto. (WebKit::WebProcessProxy::getPluginPath): Ditto. (WebKit::WebProcessProxy::getPluginProcessConnection): Ditto. (WebKit::WebProcessProxy::didGetSitesWithPluginData): Ditto. (WebKit::WebProcessProxy::didClearPluginSiteData): Ditto.
  • UIProcess/WebProcessProxy.h: Process proxy needs to be thread safe ref counted now, since it sends messages to itself on a work queue and back.
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::populatePluginCache): Updated for new receiver.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Ditto.
  • WebProcess/WebProcess.cpp: (WebKit::canPluginHandleResponse): Ditto.
2:15 PM Changeset in webkit [125450] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk

CanvasRenderContext2D::font() does not re-serialize the font
https://bugs.webkit.org/show_bug.cgi?id=50859

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Added proper serialization for the font property.

No new tests, unskipped the existing ones.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::font):

LayoutTests:

Unskip tests that will now pass and remove wrong/duplicated
expectations. canvas-font-ex-units-crash has now the wrong
expectations until we fix the issue on 93840.

  • fast/canvas/canvas-font-ex-units-crash-expected.txt:
  • fast/canvas/script-tests/canvas-font-ex-units-crash.js:

Even though we are setting a value on this test case (and verifying),
the font is not being effectiviely set as the serialization reveled. This
is going to be fixed in another bug.

  • platform/chromium/TestExpectations:
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Removed.
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Removed.
  • platform/qt/Skipped:
2:09 PM Changeset in webkit [125449] by Lucas Forschler
  • 8 edits in branches/safari-536.26-branch

Merged r118725 for <rdar://problem/11942136>

2:06 PM Changeset in webkit [125448] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

CSS quotes output quotes when depth is negative
https://bugs.webkit.org/show_bug.cgi?id=92690

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-08-13
Reviewed by Eric Seidel.

Source/WebCore:

Previously if the quote depth would go negative we would output the close quote from the
first pair of quotes again instead of outputting no quotes as required by the spec.

See: http://www.w3.org/TR/CSS21/generate.html#quotes-insert

Test: fast/css-generated-content/nested-quote-more-than-pairs.html

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::originalText): Allow the value passed to getOpenQuote to go negative by removing std::max.

  • rendering/style/QuotesData.cpp:

(WebCore::QuotesData::getOpenQuote): Bounds check for negative values for safety.
(WebCore::QuotesData::getCloseQuote): Allow index to be >= -1 and return an empty string for -1.

LayoutTests:

Make the expected output of close-quote-negative-depth.html follow the spec and
add another test that ensures the last quote pair is repeated when the depth is
greater than the number of quote pairs.

  • fast/css-generated-content/close-quote-negative-depth-expected.html:
  • fast/css-generated-content/close-quote-negative-depth.html:
  • fast/css-generated-content/nested-quote-more-than-pairs-expected.html: Added.
  • fast/css-generated-content/nested-quote-more-than-pairs.html: Added.
2:01 PM Changeset in webkit [125447] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

Unreviewed skip: Skip faling test after r125428.
The fix will be tracked in https://bugs.webkit.org/show_bug.cgi?id=93897

  • platform/qt/Skipped:
2:01 PM Changeset in webkit [125446] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-536.26-branch

Merged r118721 for <rdar://problem/11942136>

1:48 PM Changeset in webkit [125445] by vangelis@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] Clear HUD canvas contents before drawing into it.
https://bugs.webkit.org/show_bug.cgi?id=93759

Reviewed by Adrienne Walker.

Not clearing the bitmaps before drawing into it results into
random noise. This patch also caches the SkCanvas used by the HUD
to avoid reallocating it every frame.

  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:

(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):

  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:
1:44 PM Changeset in webkit [125444] by Simon Hausmann
  • 5 edits in trunk/Source

[Qt] Replace use of internal Weak smart pointer with JSWeakObjectMap
https://bugs.webkit.org/show_bug.cgi?id=93872

Reviewed by Kenneth Rohde Christiansen.

Source/JavaScriptCore:

  • Target.pri: Add missing JSWeakObjectMap file to build.

Source/WebCore:

The intention of this patch series is to replace use of internal JSC
API with use of the stable and public C API.

The JSC::Weak template is internal API and the only part of the C API
that exposes similar functionality is the JSWeakObjectMap. It is
special in the sense that its life-time is tied to the life-time of the
JS global object, which in turn is subject to garbage collection. In
order to maximize re-use of the same map across different JSContextRef
instances, we use the associated global context ref as owner of the
weak maps. The key in the weak map is the identity (pointer) of the
runtime method object itself. The iteration through the maps is
tedious, but should usually not go beyond just a few.

  • bridge/qt/qt_runtime.cpp:

(Bindings):
(JSC::Bindings::methodMapCleaner):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):

  • bridge/qt/qt_runtime.h:

(QtRuntimeMethod):

1:38 PM Changeset in webkit [125443] by rakuco@webkit.org
  • 17 edits
    1 add
    3 deletes in trunk

[CMake] Remove glib-related Find modules and write single new one instead.
https://bugs.webkit.org/show_bug.cgi?id=93786

Reviewed by Rob Buis.

.:

As part of the ongoing effort to write proper Find modules that use
absolute include and library paths instead of the short ones from
pkg-config, replace Find{GIO,Glib,Gthread}.cmake with a single
FindGLIB.cmake that optionally detects components such as GIO and
GObject.

Library paths are now defined as "/full/path/to/libfoo.so" instead of
simply "foo", so that the linker receives a full path and we can then
avoid accidentally picking up a libfoo.so installed into /usr/lib
instead of a local one built with jhbuild.

  • Source/cmake/FindGIO.cmake: Removed.
  • Source/cmake/FindGLIB.cmake: Added.
  • Source/cmake/FindGlib.cmake: Removed.
  • Source/cmake/FindGthread.cmake: Removed.
  • Source/cmake/OptionsEfl.cmake: Look for GLIB with the GIO component.

Source/JavaScriptCore:

  • shell/PlatformEfl.cmake: Use GLIB_* instead of Glib_*.

Source/WebCore:

No new tests, build system plumbing.

  • PlatformEfl.cmake: Use GLIB_* instead of Glib_*, and link

directly against GIO, as code in the soup network backend uses
that.

Source/WebKit:

  • PlatformEfl.cmake: Use GLIB_* instead of Glib_*.

Source/WebKit2:

  • PlatformEfl.cmake: Use GLIB_* instead of Glib_*.

Source/WTF:

  • wtf/PlatformEfl.cmake: Use GLIB_* instead of Glib_*, and link directly to GIO, as wtf/gobject uses functions from it.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt: Use GLIB_* instead of Glib_*.
  • EWebLauncher/CMakeLists.txt: Ditto.
  • MiniBrowser/efl/CMakeLists.txt: Ditto.
  • WebKitTestRunner/PlatformEfl.cmake: Ditto.
1:33 PM Changeset in webkit [125442] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Simplify storage and reduce size of QtConnectionObject
https://bugs.webkit.org/show_bug.cgi?id=93868

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

The connection object is a child of the sender QObject, so we can use parent()
whenever we need the sender instead of keeping an extra QObject pointer. Also
QtConnectionObject kept a RefPtr to the Instance, but actually only needed the
root object, so we can store a pointer to that instead.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtConnectionObject::QtConnectionObject):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):

  • bridge/qt/qt_runtime.h:

(QtConnectionObject):

1:23 PM Changeset in webkit [125441] by mifenton@rim.com
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update API for spell checking suggestions again.
https://bugs.webkit.org/show_bug.cgi?id=93877

Reviewed by Antonio Gomes.

PR 163283.

Update the spell checking options request API
to include the caret positions.

Reviewed internally by Nima Ghanavatian.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
(WebKit):
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

  • WebKitSupport/InputHandler.h:

(Platform):
(InputHandler):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

  • WebKitSupport/TouchEventHandler.h:

(TouchEventHandler):

1:17 PM Changeset in webkit [125440] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

Media(Stream|Element)AudioSourceNode should be guarded by the WEB_AUDIO condition as well
https://bugs.webkit.org/show_bug.cgi?id=93864

Reviewed by Eric Carlson.

Add the WEB_AUDIO to the Conditional attribute in MediaElementAudioSourceNode
IDL file and the ENABLE(WEB_AUDIO) compilation guard to the header files for both
MediaStreamAudioSourceNode and MediaElementAudioSourceNode.

No new tests - no new functionality.

  • Modules/webaudio/MediaElementAudioSourceNode.h:
  • Modules/webaudio/MediaStreamAudioSourceNode.h:
  • Modules/webaudio/MediaStreamAudioSourceNode.idl:
1:12 PM Changeset in webkit [125439] by Simon Hausmann
  • 4 edits in trunk/Source/WebCore

[Qt] Clean up exception handling
https://bugs.webkit.org/show_bug.cgi?id=93880

Reviewed by Kenneth Rohde Christiansen.

The JSC C API uses a JSValueRef* exception parameter to indicate to the
caller that an exception was thrown. Naturally the caller must store
that ValueRef on the stack in order to get seen and marked by the
garbage collector, otherwise the callee would have to use
JSValueProtect on it.

This patch fixes one such case where in fact the exception pointer was passed as zero to the
callee and thus ignored. The patch also removes an unused exception parameter.

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):

  • bridge/qt/qt_runtime.h:
1:05 PM Changeset in webkit [125438] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: remove commitEditing from the text editor delegate.
https://bugs.webkit.org/show_bug.cgi?id=93858

Reviewed by Vsevolod Vlasov.

This should be up to the source frame.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._registerShortcuts):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.scrollChanged):
(WebInspector.SourceFrame.prototype._handleKeyDown):
(WebInspector.SourceFrame.prototype._commitEditing):

  • inspector/front-end/TextEditor.js:
12:49 PM Changeset in webkit [125437] by commit-queue@webkit.org
  • 16 edits
    14 adds
    24 deletes in trunk

Unreviewed, rolling out r125430.
http://trac.webkit.org/changeset/125430
https://bugs.webkit.org/show_bug.cgi?id=93881

Caused css2.1/t1604-c541-word-sp-00-b-a.html to regress on Mac
builds (Requested by mwenge on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13

Source/WebCore:

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::HarfBuzzShaperBase::isWordEnd):

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.h:

(HarfBuzzShaperBase):
(WebCore::HarfBuzzShaperBase::isCodepointSpace):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache):

LayoutTests:

  • css2.1/20110323/c541-word-sp-001-expected.html: Removed.
  • css2.1/20110323/c541-word-sp-001.htm: Removed.
  • css2.1/20110323/word-spacing-characters-002-expected.html: Removed.
  • css2.1/20110323/word-spacing-characters-002.htm: Removed.
  • css2.1/20110323/word-spacing-characters-003-expected.html: Removed.
  • css2.1/20110323/word-spacing-characters-003.htm: Removed.
  • css2.1/20110323/word-spacing-remove-space-001-expected.html: Removed.
  • css2.1/20110323/word-spacing-remove-space-001.htm: Removed.
  • css2.1/20110323/word-spacing-remove-space-002-expected.html: Removed.
  • css2.1/20110323/word-spacing-remove-space-002.htm: Removed.
  • css2.1/20110323/word-spacing-remove-space-003-expected.html: Removed.
  • css2.1/20110323/word-spacing-remove-space-003.htm: Removed.
  • css2.1/20110323/word-spacing-remove-space-004-expected.html: Removed.
  • css2.1/20110323/word-spacing-remove-space-004.htm: Removed.
  • css2.1/20110323/word-spacing-remove-space-005-expected.html: Removed.
  • css2.1/20110323/word-spacing-remove-space-005.htm: Removed.
  • css2.1/20110323/word-spacing-remove-space-006-expected.html: Removed.
  • css2.1/20110323/word-spacing-remove-space-006.htm: Removed.
  • css2.1/t1604-c541-word-sp-01-b-a.html: Added.
  • fast/css/word-spacing-characters-complex-text-expected.html: Removed.
  • fast/css/word-spacing-characters-complex-text.html: Removed.
  • fast/css/word-spacing-characters-expected.html: Removed.
  • fast/css/word-spacing-characters.html: Removed.
  • fast/css/word-spacing-linebreak-expected.html: Removed.
  • fast/css/word-spacing-linebreak.html: Removed.
  • platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/chromium-linux/fast/css/word-space-extra-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
  • platform/chromium-win/fast/css/word-space-extra-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
  • platform/qt/TestExpectations:
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
  • platform/win/Skipped:
12:30 PM Changeset in webkit [125436] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

FrameLoader::receivedMainResourceError doesn't handle GET cancellations well.
https://bugs.webkit.org/show_bug.cgi?id=93850

Patch by Mike West <mkwst@chromium.org> on 2012-08-13
Reviewed by Adam Barth.

'FrameLoader::cancel' should reset the loader's state, and it mostly
does. In the case of a GET form submission, however, the submitted form
URL that's stored doesn't match the URL that's requested (query string).
This leads to the loader getting a bit confused about what's going on,
and not clearing the stored form submission URL.

This patch moves to storing the form submission's actual request URL
as opposed to the form action URL.

None of the current tests should break, and when issue 93777 lands, it
won't be broken either.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):

Switched to using 'FormSubmission::requestURL', as that matches the
URL that's actually requested during a form submission via GET.

12:25 PM Changeset in webkit [125435] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Hardware accelerated scrolling of <select> content
https://bugs.webkit.org/show_bug.cgi?id=93856

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

Internally reviewed by Matthew Staikos.

  • Resources/blackberry/selectControlBlackBerry.css: add -webkit-overflow-scrolling: touch (EOM).

(.select-area):

12:24 PM Changeset in webkit [125434] by tonikitoo@webkit.org
  • 6 edits in trunk/Source

[BlackBerry] Rounding error somewhere when translating CompositingLayer 's for in-region scrolling
https://bugs.webkit.org/show_bug.cgi?id=93848
PR #190986

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>

Patch adds a WebKit thread setScrollPosition-like API to InRegionScroller.
It fixes a mismatch we had of setting a layer's scroll positing directly via
::setScrollPosition on the UI thread, but dispatching a coalesceable
scrollBy(delta) message to WebKit thread.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScroller::setScrollPositionCompositingThread):
Changed the API name to match other thread specific methods naming.
(WebKit):
(BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
Added a setScrollPosition-like method to InRegionScroller public API. Used
together with its UI-thread counterpart, it can fix some rounding
errors we have due to mixing ::setScrollPosition and ::scrollBy methods.
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
Method renamed. See reasons above.
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
Calls fowards the call to ::setLayerScrollPosition (below).
(BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
Sets the scroll position of a given RenderLayer.

  • Api/InRegionScroller.h:

(InRegionScroller):

  • Api/InRegionScroller_p.h:

(WebCore):
(InRegionScrollerPrivate):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
Cache the RenderLayer object associated to a given scrollable area
instead of its LayerCompositingThread. This way we can use it for
scrolling from both Compositing/UI and WebKit threads.

12:24 PM Changeset in webkit [125433] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Assertion in RenderObject::offsetFromAncestorContainer
https://bugs.webkit.org/show_bug.cgi?id=93845

Reviewed by Kenneth Rohde Christiansen.

Do not attempt to clip using layers that are not containers of the renderer.

  • page/GestureTapHighlighter.cpp:
12:09 PM Changeset in webkit [125432] by commit-queue@webkit.org
  • 5 edits in trunk

[Cairo] canvas/philip/tests/2d.drawImage.self.2.html test failing on ports using Cairo
https://bugs.webkit.org/show_bug.cgi?id=93244

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Similar to Skia's and Qt's ImageBuffer implementation we need to make sure that buffers
for images are copied when the destination canvas is identical to the
image buffer's context. This happens mostly in JS calls to canvas' drawImage method.
For now fixing the drawImage case, drawPattern case is handled in bug 93854.

No new tests, covered by canvas/philip/tests/2d.drawImage.self.2.html

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw): Making sure buffer is copied when source and destination contexts are identical.

LayoutTests:

Unskipping canvas/philip/tests/2d.drawImage.self.2.html for GTK and EFL now that it's working.

  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
12:07 PM Changeset in webkit [125431] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] new test css3/flexbox/line-wrapping.html failing
https://bugs.webkit.org/show_bug.cgi?id=72490

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

Gardening. Unskip now passing test.

  • platform/qt/Skipped:
11:55 AM Changeset in webkit [125430] by robert@webkit.org
  • 16 edits
    24 adds
    14 deletes in trunk

CSS 2.1 failure: Word-spacing affects each space and non-breaking space
https://bugs.webkit.org/show_bug.cgi?id=89826

Reviewed by Eric Seidel.

Source/WebCore:

Add word spacing to consecutive spaces in a run per http://www.w3.org/TR/CSS21/text.html#spacing-props.

Test: fast/css/word-spacing-characters.html

fast/css/word-spacing-characters-complex-text.html
fast/css/word-spacing-characters-linebreak.html
css2.1/20110323/word-spacing-characters-002.htm
css2.1/20110323/word-spacing-characters-003.htm
css2.1/20110323/word-spacing-remove-space-001.htm
css2.1/20110323/word-spacing-remove-space-002.htm
css2.1/20110323/word-spacing-remove-space-003.htm
css2.1/20110323/word-spacing-remove-space-004.htm
css2.1/20110323/word-spacing-remove-space-005.htm
css2.1/20110323/word-spacing-remove-space-006.htm
css2.1/20110323/c541-word-sp-001.htm

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance): All spaces (ordinary space or &nbsp;) get word-spacing added, even

if they are consecutive.

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::HarfBuzzShaperBase::isWordEnd): ditto, but for the complex text case on Chromium. Had to use

m_run rather than m_normalizedBuffer here as m_normalizedBuffer turns tabs into spaces! Unlike the simple
text path, '\n' gets word-spacing - I observed this from fast/text/atsui-spacing-features.html but can't
find it specified anywhere.

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.h:

(WebCore::HarfBuzzShaperBase::isCodepointSpace):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances): ditto, but for the complext text case on Mac.

The change to this file is speculative, I don't have a Mac build.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak): Tested by word-spacing-linebreak.html

  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache): This code-path is not covered by any existing layout tests!

I've tried to come up with a test to hit it but have failed.

LayoutTests:

  • css2.1/20110323/c541-word-sp-001-expected.html: Added.
  • css2.1/20110323/c541-word-sp-001.htm: Added. Replaces t1604-c541-word-sp-01-b-a.html below.
  • css2.1/20110323/word-spacing-characters-002-expected.html: Added.
  • css2.1/20110323/word-spacing-characters-002.htm: Added.
  • css2.1/20110323/word-spacing-characters-003-expected.html: Added.
  • css2.1/20110323/word-spacing-characters-003.htm: Added. These passed already.
  • css2.1/20110323/word-spacing-remove-space-001-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-001.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-002-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-002.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-003-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-003.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-004-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-004.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-005-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-005.htm: Added.
  • css2.1/20110323/word-spacing-remove-space-006-expected.html: Added.
  • css2.1/20110323/word-spacing-remove-space-006.htm: Added. These 6 tests are fixed by this patch.
  • css2.1/t1604-c541-word-sp-01-b-a.html: Removed. Per http://lists.w3.org/Archives/Public/public-css-testsuite/2010Jan/0029.html t1604-c541-word-sp-01-b-a.htm is now invalid and has been replaced by c541-word-sp-001.htm above.
  • fast/css/word-spacing-characters-complex-text-expected.html: Added.
  • fast/css/word-spacing-characters-complex-text.html: Added. This is a complex text version of word-spacing-characters-001.htm
  • fast/css/word-spacing-characters-expected.html: Added.
  • fast/css/word-spacing-characters.html: Added. The original test (word-spacing-characters-001.htm) has two spaces between the non-breaking spaces in the second last case. This causes WebKit to split the text into two-runs and drop the second of the two spaces. This entire test can be replaced with word-spacing-characters-001.htm from the css test suite when https://bugs.webkit.org/show_bug.cgi?id=89827 is fixed.
  • fast/css/word-spacing-linebreak-expected.html: Added.
  • fast/css/word-spacing-linebreak.html: Added.
  • platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-linux/fast/css/word-space-extra-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/chromium-win/fast/css/word-space-extra-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/gtk/TestExpectations:
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
  • platform/qt/TestExpectations:
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
  • platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
11:45 AM Changeset in webkit [125429] by annacc@chromium.org
  • 5 edits in trunk

Remove webkitMediaSourceURL from HTMLMediaElement.idl
https://bugs.webkit.org/show_bug.cgi?id=93619

Reviewed by Adam Barth.

The webkitMediaSourceURL attribute is no longer needed now that we use
createObjectURL() to generate a media source URL.

Source/WebCore:

Test: update http/test/media/media-source/media-source.js

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:

LayoutTests:

  • http/tests/media/media-source/media-source.js:

(MediaSourceTest.setSrcToMediaSourceTestURL):

10:53 AM Changeset in webkit [125428] by Simon Hausmann
  • 8 edits in trunk/Source

[Qt] Port meta method/signal/slot handling in run-time bridge to use JSC C API
https://bugs.webkit.org/show_bug.cgi?id=93476

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Based on patch by No'am Rosenthal and lots of good suggestions by Caio Marcelo.

Ported the code that mapped invokable methods (and signals/slots) as
well as the code that provides the connect() and disconnect() functions
over to use the JSC C API. In the process one behavioural change was
implemented: Previously meta methods were actually function objects
that through Function.prototype allowed calling via
object.method.call(object). Through the use of plain JS objects that is
not possible anymore.

If we tried to continue to use function objects (JSObjectMakeFunction)
then we would loose the ability to store the private pointer. An
alternative approach would be to use a regular object and install the
Function prototype (Function.prototype), but unfortunately we cannot do
that without loosing the common prototype for signals and slots.

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::~QtInstance):
(JSC::Bindings::QtInstance::newRuntimeObject):

  • bridge/qt/qt_instance.h:

(Bindings):
(QtInstance):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::connect):
(JSC::Bindings::QtRuntimeMethod::disconnect):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
(Bindings):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMethod::name):
(QtRuntimeMethod):
(QtConnectionObject):

Source/WebKit/qt:

Changed semantics of some test expectations. Similarly to r125032 when generating
error exceptions for connect/disconnect, we cannot generate explicit type error
exceptions but only generic errors. Another change is that the meta-method wrapper
doesn't support the call() through Function.prototype anymore. See WebCore changelog
for details.

  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::connectAndDisconnect):
(tst_QObjectBridge::objectDeleted):
(tst_QObjectBridge::introspectQtMethods):

10:42 AM Changeset in webkit [125427] by leandrogracia@chromium.org
  • 4 edits in trunk/Source

[Chromium] Fix nits in the find-in-page match rects API
https://bugs.webkit.org/show_bug.cgi?id=93817

Reviewed by Adam Barth.

This patch fixes a few pending nits from 93111.

Source/WebCore:

Tests: existing WebKit unit test WebFrameTest.FindInPageMatchRects

  • dom/Range.cpp:

(WebCore::Range::transformFriendlyBoundingBox): add call to updateLayoutIgnorePendingStylesheets.

Source/WebKit/chromium:

  • src/FindInPageCoordinates.cpp: replace a pointer by a reference in an output argument.

(WebKit::toNormalizedRect):
(WebKit::findInPageRectFromAbsoluteRect):

10:35 AM EFLWebKit edited by michalolczak@gmail.com
(diff)
9:49 AM Changeset in webkit [125426] by pfeldman@chromium.org
  • 9 edits in trunk

Web Inspector: get rid of beforeTextChanged
https://bugs.webkit.org/show_bug.cgi?id=93851

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Merged beforeTextChanged and afterTextChanged into a single
onTextChanged event.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.editRange):
(WebInspector.CodeMirrorTextEditor.prototype._onChange):

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._enterInternalTextChangeMode):
(WebInspector.DefaultTextEditor.prototype._exitInternalTextChangeMode):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.onTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointsBeforeEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.onTextChanged):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.onTextChanged):

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditorDelegate.prototype.onTextChanged):

  • inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame.prototype.onTextChanged):

LayoutTests:

  • http/tests/inspector/live-edit-test.js:

(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest):

9:47 AM Changeset in webkit [125425] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[css] Remove "default" switch case from CSS primitive value mappings
https://bugs.webkit.org/show_bug.cgi?id=93781

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-13
Reviewed by Alexey Proskuryakov.

Removing the "default" switch case allows compile-time early warning check,
specially useful for newly added or removed enumeration values.

  • css/CSSPrimitiveValueMappings.h:
9:45 AM Changeset in webkit [125424] by annacc@chromium.org
  • 5 edits in trunk/Source/WebCore

Cap the number of SourceBuffers that may be added to a MediaSource.
https://bugs.webkit.org/show_bug.cgi?id=93406

Reviewed by Eric Carlson.

Make sure that no more SourceBuffer objects are added to a MediaSource
than can fit into the sourceBuffers SourceBufferList (internally stored
as a Vector). Also, make sure that new SourceBuffers are added with a
unique id even if the variable we are using to generate id wraps around.

No new tests. It would not be realistic to add so many SourceBuffers to
test the id variable wrapping. Existing tests should not be affected.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::addSourceBuffer): Obtain a unique id before creating

a new SourceBuffer.

  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/SourceBufferList.cpp:

(WebCore::SourceBufferList::SourceBufferList):
(WebCore::SourceBufferList::generateUniqueId): Search for and generate a

unique id.

(WebCore):
(WebCore::SourceBufferList::contains): Check if a SourceBuffer with a

given id already exists in this SourceBufferList.

  • Modules/mediasource/SourceBufferList.h:

(SourceBufferList):

9:41 AM Changeset in webkit [125423] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Update TestExpectations to make bot green
https://bugs.webkit.org/show_bug.cgi?id=93852

Unreviewed EFL gardening. Update wk2-efl TestExpectations
to make the bot green.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13

  • platform/efl-wk2/TestExpectations:
9:40 AM Changeset in webkit [125422] by peter@chromium.org
  • 5 edits in trunk

[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841

Reviewed by Dimitri Glazkov.

APK generation was broken as the configuration file assumed compilation
would only occur in the Chromium tree. Pass the path to Chromium's source
base directory as a property to ant.

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
9:36 AM Changeset in webkit [125421] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[SOUP][WK2] Missing LocalTerminationDisabler in WebCookieManager::setCookiePersistentStorage()
https://bugs.webkit.org/show_bug.cgi?id=93837

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
Reviewed by Carlos Garcia Campos.

Add missing WebCore::LocalTerminationDisabler in
WebCookieManager::setCookiePersistentStorage() to
temporarily disable process termination.

  • WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:

(WebKit::WebCookieManager::setCookiePersistentStorage):

8:50 AM Changeset in webkit [125420] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
7:54 AM Changeset in webkit [125419] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: when status bar is too narrow, cut panel status bar, not main status bar items
https://bugs.webkit.org/show_bug.cgi?id=93814

Reviewed by Pavel Feldman.

  • set shrink factor of bottom-status-bar-container to 1;
  • set bottom-status-bar-container's width to 0 to workaround for flex-basis being ignored;
  • inspector/front-end/inspector.css:

(#bottom-status-bar-container):

7:19 AM Changeset in webkit [125418] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
https://bugs.webkit.org/show_bug.cgi?id=93825

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-13
Reviewed by Antonio Gomes.

Corrected from didFinishLoadForResource() invoke to didFailLoadForResource() invoke.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didFailLoadForResource):

6:43 AM Changeset in webkit [125417] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, updating test expectation for
canvas/philip/tests/2d.drawImage.self.2.html to note that
bug #93244 tracks the regression.

  • platform/gtk/TestExpectations:
6:31 AM Changeset in webkit [125416] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a failing test.

  • platform/qt/Skipped:
  • platform/qt/TestExpectations:
6:24 AM Changeset in webkit [125415] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add memory instrumentation for Attribute
https://bugs.webkit.org/show_bug.cgi?id=93827

Reviewed by Pavel Feldman.

Attribute's name and value footprint is counted as part of the DOM
component.

  • dom/Attribute.h:

(WebCore::Attribute::reportMemoryUsage):
(Attribute):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::reportMemoryUsage):

6:19 AM Changeset in webkit [125414] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13

  • DEPS:
5:58 AM Changeset in webkit [125413] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Polish search/replace toolbar buttons style.
https://bugs.webkit.org/show_bug.cgi?id=93826

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:

(.toolbar-search button):

5:35 AM Changeset in webkit [125412] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

[EFL] fast/box-sizing/box-sizing.html needs new baseline after r124347
https://bugs.webkit.org/show_bug.cgi?id=93823

Unreviewed EFL gardening.

Provide new baseline for fast/box-sizing/box-sizing.html,
needed after r124347.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/fast/box-sizing/box-sizing-expected.png:
  • platform/efl/fast/box-sizing/box-sizing-expected.txt: Added.
5:07 AM Changeset in webkit [125411] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

[Qt] Add gprof.prf to build WebKit with gprof enabled
https://bugs.webkit.org/show_bug.cgi?id=90283

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-13
Reviewed by Eric Seidel.

Source/WebCore:

No behavior change, so no new tests.

  • WebCore.pri:

-ffunction-sections conflicts with -pg option, so don't use
-ffunction-sections option when gprof is enabled.

Source/WebKit/qt:

  • tests/MIMESniffing/MIMESniffing.pro:

Don't build MIMESniffing.cpp because MIMESniffing test links
WebKitQt statically when gprof is enabled.

Tools:

  • qmake/mkspecs/features/functions.prf:

gprof does not support profiling a shared library.
To profile WebKit, applications must link QtWebKit statically.

  • qmake/mkspecs/features/gprof.prf: Added.

Add -pg option to both QMAKE_CXXFLAGS and QMAKE_LFLAGS.

5:00 AM Changeset in webkit [125410] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r125408, removing another usage of SVG_FEATURES.

  • GNUmakefile.am:
4:54 AM Changeset in webkit [125409] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][WK2] Skip inspector tests that hit assertion in WebCore::SuspendableTimer::resume()
https://bugs.webkit.org/show_bug.cgi?id=93815

Unreviewed EFL gardening.

Update TestExpectations for several flaky Web Inspector
test cases.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
4:42 AM Changeset in webkit [125408] by zandobersek@gmail.com
  • 4 edits in trunk

[Gtk] Remove SVG_FEATURES and HTML_FEATURES from Source/WebCore/GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=90693

Reviewed by Philippe Normand.

.:

Remove exportation of SVG_FLAGS and HTML_FLAGS as Automake conditionals
as they are not required anymore.

  • configure.ac:

Source/WebCore:

Remove SVG_FEATURES and HTML_FEATURES variables. They can be replaced by the
FEATURE_DEFINES variable wherever they are used.

No new tests - no new functionality.

  • GNUmakefile.am:
4:38 AM WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
3:35 AM Changeset in webkit [125407] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
https://bugs.webkit.org/show_bug.cgi?id=93600

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-08-13
Reviewed by Xan Lopez.

Instead of using the default editing signal handler for ::should-show-delete-interface-for-element,
do not use a default signal handler. This means that the result of the signal defaults to FALSE,
which is the expected value to ensure that the delete interface is not shown.

  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init): Do not install a default signal handler.

3:16 AM Changeset in webkit [125406] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
3:15 AM Changeset in webkit [125405] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Wrong TestExpectations for 2 webintents tests
https://bugs.webkit.org/show_bug.cgi?id=93811

Unreviewed EFL gardening.

Update expected state for the following webintents tests
to make the tree green:
webintents/web-intents-invoke-port.html
webintents/web-intents-obj-constructor.html

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13

  • platform/efl-wk2/TestExpectations:
3:01 AM Changeset in webkit [125404] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing/crashing tests.

  • platform/qt/Skipped:
  • platform/qt/TestExpectations:
2:42 AM Changeset in webkit [125403] by mario@webkit.org
  • 4 edits in trunk/Source

[GTK] Implementation of atk_editable_text_insert_text ignores 'length' parameter
https://bugs.webkit.org/show_bug.cgi?id=93804

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Use the 'length' parameter to insert a substring of the full
string passed to this method from AtkEditableText interface.

  • accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp:

(webkitAccessibleEditableTextInsertText): Don't ignore 'length'.

Source/WebKit/gtk:

Update unit tests to also check inserting a partial string.

  • tests/testatk.c:

(testWebkitAtkTextChangedNotifications): Update test.

2:33 AM Changeset in webkit [125402] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Feature Request - Adding mouse gesture for editing attribute values in elements/css panel
https://bugs.webkit.org/show_bug.cgi?id=93581

Patch by Sam D <dsam2912@gmail.com> on 2012-08-13
Reviewed by Alexander Pavlov.

Added functionality to modify valuesAdding support for updating number values in attributes in element
panel/ css panel using mouse gestures as well.

No new tests.

  • inspector/front-end/StylesSidebarPane.js:

handling mousewheel event

  • inspector/front-end/TextPrompt.js:

adding mouse event listener
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype.onMouseWheel):

  • inspector/front-end/UIUtils.js:

handling mouse event gesture and updating number based on mouse wheel
scroll direction as well.
(WebInspector._valueModificationDirection):
(WebInspector._modifiedHexValue):
(WebInspector._modifiedFloatNumber):
(WebInspector.handleElementValueModifications):

2:29 AM Changeset in webkit [125401] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[TestNetscapePlugin][X11] Additional key up event handler routine is required
https://bugs.webkit.org/show_bug.cgi?id=91357

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-13
Reviewed by Eric Seidel.

Fixed key up event handler routine to pass http/tests/plugins/plugin-document-
has-focus.html on X11 architecture. The test can not be done without this patch.
All other ports implemented it already.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(handleEventX11): Modified key up event handler for X11

2:28 AM Changeset in webkit [125400] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing header file.
2:06 AM Changeset in webkit [125399] by apavlov@chromium.org
  • 16 edits in trunk

Web Inspector: [Protocol] Force elements pseudo state via a separate InspectorCSSAgent method
https://bugs.webkit.org/show_bug.cgi?id=93721

Reviewed by Pavel Feldman.

Source/WebCore:

Introduce InspectorCSSAgent::forcePseudoState() to modify the element's forced pseudo state.

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.forcePseudoState):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._setPseudoClassForNodeId):

  • inspector/front-end/MetricsSidebarPane.js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):

LayoutTests:

  • http/tests/inspector/modify-cross-domain-rule.html:
  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-formatting.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-new-API-expected.txt:
1:26 AM Changeset in webkit [125398] by commit-queue@webkit.org
  • 3 edits
    1 add
    1 delete in trunk

[EFL][WK2] Replace Skipped list by TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=93796

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-13
Reviewed by Kenneth Rohde Christiansen.

Tools:

Enable cascaded TestExpectations for EFL port so
that we can use TestExpectations in WK2-EFL.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._search_paths):
(EflPort):
(EflPort.expectations_files):

LayoutTests:

Replace efl-wk2 Skipped file by TestExpectations now
that we support cascaded TestExpectations in EFL
port.

  • platform/efl-wk2/Skipped: Removed.
  • platform/efl-wk2/TestExpectations: Added.
1:22 AM Changeset in webkit [125397] by shinyak@chromium.org
  • 5 edits
    2 adds in trunk

Cannot select the AuthorShadowDOM inner element of an img element
https://bugs.webkit.org/show_bug.cgi?id=91591

Reviewed by Dimitri Glazkov.

Source/WebCore:

Since HTMLImageElement::canStartSelection always returns false, we cannot start selection
from any children (including shadow dom) of an img element. When the img element has a shadow dom,
we should be able to start selection.

Test: fast/dom/shadow/select-image-with-shadow.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::canStartSelection):
(WebCore):

  • html/HTMLImageElement.h:

(HTMLImageElement):

  • html/shadow/ImageInnerElement.h:

(WebCore::ImageInnerElement::canStartSelection): Since ImageInnerElement is really an image,
this should return always false to obey the exising behavior.
(ImageInnerElement):

LayoutTests:

  • fast/dom/shadow/select-image-with-shadow-expected.txt: Added.
  • fast/dom/shadow/select-image-with-shadow.html: Added.
1:11 AM Changeset in webkit [125396] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

REGRESSION(r125153): It broke the 'Unexpected no expected results' case
https://bugs.webkit.org/show_bug.cgi?id=93789

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-08-13
Reviewed by Csaba Osztrogonác.

Fix the regex, so the text won't be a capturing group.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests._parseNewRunWebKitTestsOutput):

12:52 AM Changeset in webkit [125395] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Add expectations for flaky tests.

  • platform/chromium/TestExpectations:
12:19 AM Changeset in webkit [125394] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION (r124723-r124741): 5 inspector/debugger tests failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93387

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-13
Reviewed by Pavel Feldman.

Now the front-end has problem when setting the positon of breakpoint, so remove the comparing
of "column" to make the behavior back to the time as JSC cannot provide "column" info.
Refer to https://bugs.webkit.org/show_bug.cgi?id=93473.

No new test case for this bug.

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):

Aug 12, 2012:

11:55 PM Changeset in webkit [125393] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r125392.
http://trac.webkit.org/changeset/125392
https://bugs.webkit.org/show_bug.cgi?id=93797

Simple rebaseline won't work. Need further investigation.
(Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-12

  • inspector/console/console-format-collections-expected.txt:
11:48 PM Changeset in webkit [125392] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: rebaselined inspector/console/console-format-collections.html after r125284.
https://bugs.webkit.org/show_bug.cgi?id=93748

  • inspector/console/console-format-collections-expected.txt:
11:21 PM Changeset in webkit [125391] by kinuko@chromium.org
  • 21 edits in trunk/Source

Support creating File object from FileSystem URL for files in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=93706

Reviewed by Darin Fisher.

Source/Platform:

  • chromium/public/WebBlobData.h:
  • chromium/public/WebHTTPBody.h:

(WebHTTPBody):

Source/WebCore:

Current File code assumes the existence of local file (i.e. requires a platform local file path) but for FileSystem
files it may not be always the case. For example some implementation may want to use in-memory filesystem to realize
sandboxed filesystem, or others may have the filesystem in remote servers.

This patch adds basic support for making File object constructible not only from a file path but from a FileSystem URL.
Since File can be appended to FormData or included in another Blob this patch also extends BlobData and FormData to support URL.

FileChooser and Drag-and-drop changes are not included in this patch.

No new tests: will add tests when we implement the platform side changes to wire this change.

  • Modules/filesystem/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::createFile):

  • Modules/filesystem/DOMFileSystemSync.cpp:

(WebCore::DOMFileSystemSync::createFile):

  • fileapi/Blob.cpp:

(WebCore::Blob::sliceInternal):

  • fileapi/File.cpp:

(WebCore::createBlobDataForFileSystemURL): Added.
(WebCore::File::File):

  • fileapi/File.h:

(WebCore::File::createForFileSystemFile):
(WebCore::File::fileSystemURL): Added.

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::WebKitBlobBuilder::append):

  • platform/chromium/support/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendURL): Added.
(WebKit::WebHTTPBody::appendURLRange): Added.
(WebKit::WebHTTPBody::appendBlob):

  • platform/network/BlobData.cpp:

(WebCore::BlobData::appendURL):

  • platform/network/BlobData.h:

(BlobDataItem):
(WebCore::BlobDataItem::BlobDataItem):

  • platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::BlobRegistryImpl::registerBlobURL):

  • platform/network/FormData.cpp:

(WebCore::FormData::deepCopy):
(WebCore::FormData::appendURL): Added.
(WebCore::FormData::appendURLRange): Added.
(WebCore::FormData::appendKeyValuePairItems):

  • platform/network/FormData.h:

(WebCore::FormDataElement::FormDataElement):
(FormDataElement):
(WebCore::operator==):

Source/WebKit/chromium:

  • src/WebBlobData.cpp:

(WebKit::WebBlobData::itemAt):

10:21 PM Changeset in webkit [125390] by morrita@google.com
  • 2 edits in trunk/Tools

Unreviewed, added a proxy address to contributors_who_are_not_committers.

  • Scripts/webkitpy/common/config/committers.py:
9:36 PM Changeset in webkit [125389] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/11442485> off-screen or inactive pages can change the mouse pointer

Reviewed by Adele Peterson.

  • page/EventHandler.cpp:

(WebCore::EventHandler::fakeMouseMoveEventTimerFired): Added a check that the page is
on-screen and active before dispatching the fake mouse event.

9:35 PM Changeset in webkit [125388] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] use MediaPlayer::userAgent() in MediaPlayerPrivateBlackBerry to avoid layering violation
https://bugs.webkit.org/show_bug.cgi?id=93588

Patch by Jonathan Dong <Jonathan Dong> on 2012-08-12
Reviewed by Antonio Gomes.

Removed helper function MediaPlayerPrivate::userAgent() which has
introduced abstraction layering violation and replaced with
MediaPlayer::userAgent().

No new tests since there's no functional change.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::load):

9:23 PM Changeset in webkit [125387] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Update TestExpectations so it matches the recent results.

  • platform/chromium/TestExpectations:
9:16 PM Changeset in webkit [125386] by kinuko@chromium.org
  • 5 edits in trunk/Source/WebCore

Record metrics to measure the usage of WebKitBlobBuilder to eventually deprecate it
https://bugs.webkit.org/show_bug.cgi?id=90535

Reviewed by Eric Seidel.

No new tests as this has no functional changes.

  • bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::WebKitBlobBuilder::getBlob):

  • fileapi/WebKitBlobBuilder.h:

(WebKitBlobBuilder):

8:55 PM Changeset in webkit [125385] by yutak@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Fix Chromium's Android build.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::find): Needs parentheses for a function call.

5:14 PM Changeset in webkit [125384] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove unnecessary null checks from pseudoStyleForElement and adjustRenderStyle
https://bugs.webkit.org/show_bug.cgi?id=93730

Reviewed by Tony Chang.

All the callers of both methods make sure to pass in a non-null parentStyle.

No change in behavior.

  • css/StyleResolver.cpp:
  • css/StyleResolver.h:
4:13 PM Changeset in webkit [125383] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new tests without expected results.

  • platform/qt/Skipped:
4:01 PM Changeset in webkit [125382] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Tap highlight flashes checkerboard after pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=93601

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-12
Reviewed by Antonio Gomes.

Since the tap highlight is usually rather small, we can reimplement
GraphicsLayerClient::contentsVisible() to always return true in order
to keep all AC layer tiles cached all the time.

PR 189895

  • WebKitSupport/DefaultTapHighlight.cpp:

(BlackBerry::WebKit::DefaultTapHighlight::contentsVisible):
(WebKit):

  • WebKitSupport/DefaultTapHighlight.h:

(DefaultTapHighlight):

3:59 PM Changeset in webkit [125381] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Tap highlight sometimes doesn't disappear
https://bugs.webkit.org/show_bug.cgi?id=93711

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-12
Reviewed by Antonio Gomes.

The WebOverlayOverride implementation just changes properties of a
LayerCompositingThread directly, which means the changes will
immediately be overwritten on the next commit. Therefore, when the tap
highlight implementation adds a fade out animation, that animation will
instantly be removed again if a commit happens for any reason.

The reason is I totally botched the implementation of
WebOverlayOverride, it's not wrapping WebCore::LayerOverride at all,
instead for some reason it's manipulating the LayerCompositingThread
directly.

Fixed by actually mapping WebOverlayOverride calls to the corresponding
WebCore::LayerOverride method, and scheduling a compositing run to make
the change visible and kick off animations.

Reviewed internally by Sean Wang.

PR 188453

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivate::override):

  • Api/WebOverlayOverride.cpp:

(BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::~WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::setPosition):
(BlackBerry::WebKit::WebOverlayOverride::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayOverride::setSize):
(BlackBerry::WebKit::WebOverlayOverride::setTransform):
(BlackBerry::WebKit::WebOverlayOverride::setOpacity):
(BlackBerry::WebKit::WebOverlayOverride::addAnimation):
(BlackBerry::WebKit::WebOverlayOverride::removeAnimation):

  • Api/WebOverlayOverride.h:
  • Api/WebOverlay_p.h:

(WebOverlayPrivate):
(WebOverlayPrivateWebKitThread):
(WebOverlayPrivateCompositingThread):

11:14 AM Changeset in webkit [125380] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

table cell.cellIndex should return -1 if there is no parent table
https://bugs.webkit.org/show_bug.cgi?id=93738

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-08-12
Reviewed by Eric Seidel.

Source/WebCore:

According to the HTML5 spec the cellIndex of a table cell(td/th) whose parent is not a table row
must be -1. Currently we are returning zero. This patch fixes this behavior.

Test: fast/table/cellIndex-of-cell-with-different-parents.html

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::cellIndex):

If the parent of the cell is not a table row, -1 is returned. Otherwise a value greater
than or equal to zero is return.

  • rendering/RenderTableCell.h:

(RenderTableCell):

Removed dead code and made minor webkit style related fix.

LayoutTests:

  • fast/table/cellIndex-of-cell-with-different-parents-expected.txt: Added.
  • fast/table/cellIndex-of-cell-with-different-parents.html: Added.
11:05 AM Changeset in webkit [125379] by leandrogracia@chromium.org
  • 9 edits
    4 adds in trunk/Source

[Chromium] Implement the find-in-page match rects API
https://bugs.webkit.org/show_bug.cgi?id=93111

Reviewed by Adam Barth.

Source/WebCore:

Introduce the find-in-page coordinate system. This system tries to solve
the unintuitive tickmark results presented in pages with multiple frames
and scrolled contents where the find results might not be in the visible
area of a frame, which might lead to tickmarks below the container frame.

To achieve this, this coordinate system goes up the render tree
normalizing the coordinates by the actual contents size of its container.
This leads to tickmarks scaled to the visible size of their frame
independently of its scroll. This coordinate system supports also CSS
scroll:overflow, transforms and the different positions.

Also add an auxiliary method to Range in order to provide a transform
friendly way to retrieve the absolute coordinates of the enclosing
bounding box without the adjustment operations that the existing
enclosingRect method does.

Tested by WebFrameTest WebKit unit test.

  • dom/Range.cpp:

(WebCore::Range::transformFriendlyBoundingBox): add a transform-friendly equivalent of boundingBox.
(WebCore):

  • dom/Range.h: move boundingBox to the group of non-transform-friendly methods.

(Range):

Source/WebKit/chromium:

Implement the funcionality of the find-in-page match rects API in WebFrame.
These methods keep a cache of the match rects in a special coordinate system
(find-in-page coordinates) and update them on size changes. They also allow
to recover the match closest to a given point, therefore enabling to move
to find matches when tapping on their corresponding tickmarks.

  • WebKit.gyp: add FindInPageCoordinates.h / cpp.
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::contentsSizeChanged): propagate didChangeContentsSize to WebFrameImpl.

  • src/FindInPageCoordinates.cpp: Added.

(WebKit):
(WebKit::toNormalizedRect): auxiliary internal function.
(WebKit::findInPageRectFromAbsoluteRect): main coordinate conversion function.
(WebKit::findInPageRectFromRange): convenience conversion function for Ranges.

  • src/FindInPageCoordinates.h: Added.

(WebCore):
(WebKit):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::FindMatch::FindMatch): find matches cache constructor.
(WebKit):
(WebKit::WebFrameImpl::find): clear match cache when appropriate and zoom into results on the Android port.
(WebKit::WebFrameImpl::stopFinding): clear matches cache.
(WebKit::WebFrameImpl::scopeStringMatches): add new results to the matches cache.
(WebKit::WebFrameImpl::increaseMatchCount): update the matches cache version.
(WebKit::WebFrameImpl::resetMatchCount): update the matches cache version.
(WebKit::WebFrameImpl::findMatchMarkersVersion): new API providing the matches cache version.
(WebKit::WebFrameImpl::clearFindMatchesCache): internal utility method to reset the matches cache.
(WebKit::WebFrameImpl::isActiveMatchFrameValid): internal utility method to check if the local frame is still in the frame tree.
(WebKit::WebFrameImpl::updateFindMatchRects): internal utility method to update the match result rects if required.
(WebKit::WebFrameImpl::activeFindMatchRect): new API providing the active find match rect in find-in-page coordinates.
(WebKit::WebFrameImpl::findMatchRects): new API returning the valid match rects in find-in-page coordinates.
(WebKit::WebFrameImpl::appendFindMatchRects): internal utility method to concatenate the match results of multiple frames.
(WebKit::WebFrameImpl::selectNearestFindMatch): new API selecting the find match closer to a point in find-in-page coordinates.
(WebKit::WebFrameImpl::nearestFindMatch): internal utility method to find the nearest find match to a point in a frame.
(WebKit::WebFrameImpl::selectFindMatch): internal utility method to select a match in the cache.
(WebKit::WebFrameImpl::WebFrameImpl): initialization of new variables.
(WebKit::WebFrameImpl::didChangeContentsSize): invalidate the cached match rect coordinates on frame content size changes.

  • src/WebFrameImpl.h:

(WebCore):
(WebFrameImpl):
(WebKit::WebFrameImpl::activeMatchFrame): remove unrequired const.
(WebKit::WebFrameImpl::activeMatch): expose the range of the active match to allow testing.
(FindMatch): cache structure for find matches.

  • tests/WebFrameTest.cpp: new test case for find-in-page match rects.
  • tests/data/find_in_page.html: Added. Test case layout.
  • tests/data/find_in_page_frame.html: Added. Test case layout.
10:40 AM Changeset in webkit [125378] by fischman@chromium.org
  • 2 edits in trunk/Source/WebCore

Stop Y-flipping CROS/ARM video textures
https://bugs.webkit.org/show_bug.cgi?id=93769

Reviewed by Eric Seidel.

No new tests; there's no cros/arm bot yet, sadly.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads): drop the single-platform Y-flipping in prep for the platform doing the flip natively.

9:52 AM Changeset in webkit [125377] by commit-queue@webkit.org
  • 16 edits in trunk

[Qt] Make it possible to build without QtTest/QtPrintSupport
https://bugs.webkit.org/show_bug.cgi?id=93492

Patch by Loïc Yhuel <loic.yhuel@softathome.com> on 2012-08-12
Reviewed by Tor Arne Vestbø.

.:

  • Source/QtWebKit.pro: Disable tests if no testlib

Source/WebKit:

  • WebKit1.pri: Optional printsupport

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFrame::print): Does nothing if no printsupport

  • Api/qwebview.cpp:

(QWebView::print): Does nothing if no printsupport

Tools:

  • DumpRenderTree/qt/DumpRenderTree.pro: Optional printsupport
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore):
(WebCore::DumpRenderTree::dryRunPrint): Does nothing if no printsupport

  • QtTestBrowser/QtTestBrowser.pro: Optional printsupport
  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::createChrome): No print menu if no printsupport
(LauncherWindow::print): Does nothing if no printsupport

  • QtTestBrowser/launcherwindow.h:
  • Tools.pro: Disable DRT/WTR if QtTest not present
  • qmake/mkspecs/features/default_pre.prf: printsupport no more mandatory
  • qmake/mkspecs/features/features.prf: Qt module availability tests
8:57 AM Changeset in webkit [125376] by mihnea@adobe.com
  • 6 edits
    2 adds in trunk

CSSRegions: Crash when using style in region for removed element.
https://bugs.webkit.org/show_bug.cgi?id=93276

Reviewed by Abhishek Arya.

Source/WebCore:

When a RenderInline object from within a render flow thread is split, the cloned
hierarchy built during the split process does not have the inRenderFlowThread bit
set properly. If the cloned hierarchy is flowed into a region with region style rules,
we compute the style in region also for objects that do not have inRenderFlowThread bit
set and we store the computed style in region for caching purposes. But we only remove
an object style in region information if that object has the inRenderFlowThread bit set.
Under these circumstances, it is possible to remove a object with cached style in region
and without inRenderFlowThread bit set from the render tree and leave the associated cached
information un-removed. Such information will be accesses during the next paint phase of
the region, thus resulting a crash.

The fix is to modify RenderBlock::clone() and RenderInline::clone() functions to also copy the inRenderFlowThread bit
from the source into the clone, therefore the cloned hierarchies will have the inRenderFlowThread
bit set properly.

Test: fast/regions/removed-element-style-in-region-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clone): Replace former static RenderInline::cloneInline with member RenderInline::clone.
(WebCore::RenderInline::splitInlines):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setObjectStyleInRegion):
Added an assert to make sure that when we are computing style in region, we are doing for objects
with inRenderFlowThread set. Also, bail out early in this case to prevent further crashes.

LayoutTests:

Added test reproducing the problem.

  • fast/regions/removed-element-style-in-region-crash-expected.txt: Added.
  • fast/regions/removed-element-style-in-region-crash.html: Added.
8:46 AM Changeset in webkit [125375] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Skip webintents/web-intents-obj-constructor.html test
https://bugs.webkit.org/show_bug.cgi?id=93778

Unreviewed EFL gardening.

Skip webintents/web-intents-obj-constructor.html for
WebKit2 EFL until WTR can print information about the
MessagePorts in a Web Intent (Bug 89072).

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-12

  • platform/efl-wk2/Skipped:
5:12 AM Changeset in webkit [125374] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Set the access qualifier of two methods to query frame specific info of BitmapImage to protected.
https://bugs.webkit.org/show_bug.cgi?id=90505

Patch by Huang Dongsung <luxtella@company100.net> on 2012-08-12
Reviewed by Eric Seidel.

Following 4 methods are protected.

size_t frameCount();
NativeImagePtr frameAtIndex(size_t);
bool frameIsCompleteAtIndex(size_t);
float frameDurationAtIndex(size_t);

So, 2 methds also should be protected because the frame info is only specific of
BitmapImage.

bool frameHasAlphaAtIndex(size_t);
ImageOrientation frameOrientationAtIndex(size_t);

On the other hand, this patch amended GraphicsContext3DCG.

  • static_cast<BitmapImage*>(image)->frameHasAlphaAtIndex(0)

+ image->currentFrameHasAlpha()

This patch does not affect PNG, JPEG, BMP, and WEBP because those images
have only 0 indexed frame.
Thus, GIF, and ICO are affected. However, an above query to get Alpha
is for the image that is created by image->nativeImageForCurrentFrame(), so it
is proper to use image->currentFrameHasAlpha() instead of
image->frameHasAlphaAtIndex(0).

No new tests, because it is hard to test. We need an animated GIF that
one frame has alpha and another frame does not have alpha. However, I
cannot find the animated GIF file that suffices the requirement.

  • platform/graphics/BitmapImage.h:

(BitmapImage):

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::getImageData):

4:47 AM Changeset in webkit [125373] by allan.jensen@nokia.com
  • 3 edits in trunk/Source/JavaScriptCore

Doesn't build with ENABLE_JIT=0
https://bugs.webkit.org/show_bug.cgi?id=85042

Reviewed by Eric Seidel.

Include headers without which CallFrame.h does not build, and
fix gcc warning about comparing unsigned int with 0.

  • dfg/DFGDriver.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::isOpcode):

4:38 AM Changeset in webkit [125372] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

master.cfg unittest cleanup: Show DeprecationWarnings with python >= 2.7 too
https://bugs.webkit.org/show_bug.cgi?id=90161

Reviewed by Eric Seidel.

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4:38 AM Changeset in webkit [125371] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

webkit fails IETC namespaces/prefix-007.xml
https://bugs.webkit.org/show_bug.cgi?id=86137

Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-12
Reviewed by Eric Seidel.

Source/WebCore:

If a namespace prefix or default namespace is declared more than once
only the last declaration shall be used.

parseAddNamespace doesn't check return value of WTF::HashMap<>::add.
If the return value's isNewEntry is true, the new entry is added with
the specified value. However, if isNewEntry is false, it is required
to update the store value.

No new tests. ietestcenter/css3/namespaces/prefix-007.xml and
ietestcenter/css3/namespaces/prefix-010.xml covers this change.

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAddNamespace):
Modified to check m_namespaces.add's return value.
If the result says not a new entry, updated the value stored in
m_namespaces by using iterator in the result.

LayoutTests:

  • platform/chromium/TestExpectations:

Enabled the layout tests, ietestcenter/css3/namespaces/prefix-007.xml
and ietestcenter/css3/namespaces/prefix-010.xml.

  • platform/win/ietestcenter/css3/namespaces/prefix-007-expected.txt: Removed.
  • platform/win/ietestcenter/css3/namespaces/prefix-010-expected.txt: Removed.

Removed old expectations.

4:29 AM Changeset in webkit [125370] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Fix build with recent clang.
https://bugs.webkit.org/show_bug.cgi?id=90701

Patch by Nuno Lopes <nlopes@apple.com> on 2012-08-12
Reviewed by Eric Seidel.

  • Shared/CommandLine.h:

(CommandLine):

  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::NotificationPermissionRequestManager):

  • WebProcess/Notifications/NotificationPermissionRequestManager.h:

(NotificationPermissionRequestManager):

4:26 AM Changeset in webkit [125369] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL][UT] Delete shutdown method.
https://bugs.webkit.org/show_bug.cgi?id=90785

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-08-12
Reviewed by Eric Seidel.

EWKTestBase class already has a shutdownAll method that can be used instead of shutdown.

  • tests/UnitTestUtils/EWKTestBase.cpp:
  • tests/UnitTestUtils/EWKTestBase.h:

(EWKTestBase):

3:39 AM Changeset in webkit [125368] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Move CSS's propertyNameStrings[] to from the header to the cpp file
https://bugs.webkit.org/show_bug.cgi?id=93771

Reviewed by Eric Seidel.

The names of propertyNameStrings[] should never be accessed directly. The function getPropertyName()
return the correct string of propertyNameStrings.

To ensure the values are not accessed by mistake, move them from the header to the implementation.

  • css/makeprop.pl:
3:37 AM Changeset in webkit [125367] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSComputedStyleDeclaration::cssText() should use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=93776

Reviewed by Eric Seidel.

String::append() is fairly inefficient when used to create a long string by appending a lot of small
pieces. StringBuilder is more approriate for the kind of operations done by CSSComputedStyleDeclaration::cssText().

This changes makes CSSComputedStyleDeclaration::cssText() about 6 times faster.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::cssText):

12:32 AM Changeset in webkit [125366] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

12:18 AM Changeset in webkit [125365] by Simon Hausmann
  • 4 edits in trunk/Tools

[Qt] Unreviewed trivial build fix: Newer Qt versions don't implicitly include qwindowsysteminterface.h
through the QTestLib headers anymore.

  • DumpRenderTree/qt/EventSenderQt.cpp:
  • WebKitTestRunner/Target.pri:
  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:
Note: See TracTimeline for information about the timeline view.