Timeline



Aug 28, 2012:

11:50 PM Changeset in webkit [126964] by Martin Robinson
  • 4 edits in trunk/Source

[GTK] Enable the edge distance anti-aliasing for accelerated compositing layers
https://bugs.webkit.org/show_bug.cgi?id=95272

Reviewed by No'am Rosenthal.

Source/WebKit/gtk:

Turn on edge-distance anti-aliasing for GTK+ WebKit1. This
improves the quality of layer rendering.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::initialize):

Source/WebKit2:

Turn on edge-distance anti-aliasing for GTK+ WebKit2. This
improves the quality of layer rendering.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):

11:45 PM Changeset in webkit [126963] by yosin@chromium.org
  • 5 edits in trunk/Source/WebCore

[Forms] Make HTMLInputElement::blur()/focus() override-able by input type
https://bugs.webkit.org/show_bug.cgi?id=95279

Reviewed by Hajime Morrita.

This patch allows HTMLInputElement::focus() and blur() functions to be
override-able.

This patch is part of Shift+Tab focus navigation change for multiple
field time input UI, bug 95168.

No new tests. This patch doesn't change behavior.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::blur): Added to call InputType::blur().
(WebCore::HTMLInputElement::defaultBlur): Added for default implementation of blur().
(WebCore::HTMLInputElement::defaultFocus): Added for default implementation of focus().
(WebCore::HTMLInputElement::focus): Added to call InputType::focus()

  • html/HTMLInputElement.h:

(HTMLInputElement): Added declarations of blur(), defaultBlur(), defaultFocus() and focus().

  • html/InputType.cpp:

(WebCore::InputType::blur): Added to call HTMLInputElement::defaultBlur() as default implementation.
(WebCore::InputType::focus): Added to call HTMLInputElement::defaultFocus() as default implementation.

  • html/InputType.h:

(InputType): Added declarations of blur(), and focus().

11:40 PM Changeset in webkit [126962] by ggaren@apple.com
  • 12 edits in trunk/Source

Added JSScope::objectInScope(), and refactored callers to use it
https://bugs.webkit.org/show_bug.cgi?id=95281

Reviewed by Gavin Barraclough.

../JavaScriptCore:

This is a step toward removing ScopeChainNode. We need a layer of
indirection so that 'with' scopes can proxy for an object.
JSScope::objectInScope() will be that layer.

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl): . vs ->

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::execute):

  • runtime/JSScope.cpp:

(JSC::JSScope::resolve):
(JSC::JSScope::resolveSkip):
(JSC::JSScope::resolveGlobalDynamic):
(JSC::JSScope::resolveBase):
(JSC::JSScope::resolveWithBase):
(JSC::JSScope::resolveWithThis): Added JSScope::objectAtScope() calls.

  • runtime/JSScope.h:

(JSScope):
(JSC::JSScope::objectAtScope):
(JSC):
(ScopeChainIterator):
(JSC::ScopeChainIterator::ScopeChainIterator):
(JSC::ScopeChainIterator::get):
(JSC::ScopeChainIterator::operator->):
(JSC::ScopeChainIterator::operator++):
(JSC::ScopeChainIterator::operator==):
(JSC::ScopeChainIterator::operator!=):
(JSC::ScopeChainNode::begin):
(JSC::ScopeChainNode::end): I moved ScopeChainIterator to this file
to resolve a circular #include problem. Eventually, I'll probably rename
it to JSScope::iterator, so I think it belongs here.

  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::print):
(JSC::ScopeChainNode::localDepth): . vs ->

  • runtime/ScopeChain.h:

(ScopeChainNode): I made the 'object' data member private because it's
no longer safe to access -- you need to call JSScope::objectAtScope()
instead.

The JITs need to be friends because of the private declaration.

Subtly, JIT/LLInt code is correct without any changes because JIT/LLInt
code never compiles direct access to a with scope.

../WebCore:

  • bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::scopeChain):
(WebCore::JSJavaScriptCallFrame::scopeType):

../WebKit/mac:

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame scopeChain]):

11:29 PM Changeset in webkit [126961] by commit-queue@webkit.org
  • 14 edits
    2 deletes in trunk/Source/WebCore

Layout Test fast/repaint/japanese-rl-selection-repaint-in-regions.html is failing after r126304
https://bugs.webkit.org/show_bug.cgi?id=94730

Patch by Andrei Bucur <abucur@adobe.com> on 2012-08-28
Reviewed by Adam Barth.

Having an intermediary node between the named flow renderers and the view may introduce subtle bugs that are hard to track. Also it doesn't fix
the pointless destruction of a RenderNamedFlowThread in some special cases (e.g. region->detach, destroy flow thread, region->attach, recreate flow
thread).
This patch proposes a new way of lazily destroying the renderers for NULL named flows, at layout time. When a renderer has no content nodes or regions
attached, its named flow is considered to be in the NULL state. When starting a layout process it is a good time to go through the renderers of the
NULL named flows and destroy them.

Tests: No functional change, the old tests should pass without issues.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::getRegionsByContent):
(WebCore::WebKitNamedFlow::getRegions):
(WebCore::WebKitNamedFlow::setRenderer):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):

  • rendering/FlowThreadController.h:

(WebCore):
(FlowThreadController):

  • rendering/RenderFlowThreadContainer.cpp: Removed.
  • rendering/RenderFlowThreadContainer.h: Removed.
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::addRegionToThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentNode):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentNode):
(WebCore::RenderNamedFlowThread::setMarkForDestruction):
(WebCore):
(WebCore::RenderNamedFlowThread::resetMarkForDestruction):
(WebCore::RenderNamedFlowThread::isMarkedForDestruction):

  • rendering/RenderNamedFlowThread.h:

(RenderNamedFlowThread):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::markContainingBlocksForLayout):

  • rendering/RenderObject.h:
10:54 PM Changeset in webkit [126960] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add support for localization to the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=92961

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-08-28
Reviewed by Gyuyoung Kim.

Implement InspectorFrontendClientEfl::localizedStringsURL()
to return the URL of the localizedStrings.js.

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::openInspectorFrontend):
(WebCore::InspectorClientEfl::inspectorFilesPath):
(WebCore::InspectorFrontendClientEfl::localizedStringsURL):

10:11 PM Changeset in webkit [126959] by bashi@chromium.org
  • 4 edits in trunk

style->fontMetrics() should be available when setting line-height
https://bugs.webkit.org/show_bug.cgi?id=93327

Reviewed by Darin Adler.

Source/WebCore:

Setting line-height assumes the fontMetrics are available for the affected font, but
the fontMetrics won't be available immediately after setting other properties like
font-size. Call styleResolver->updateFont() before setting line-height to update fontMetrics.

Added a test case to fast/canvas/crash-set-font.html.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):
Call styleResolver->updateFont() before styleResolver->applyPropertyToCurrentStyle(CSSPropertyLineHeight,...)

LayoutTests:

  • fast/canvas/crash-set-font.html: Add a test case that sets both font-size and line-height.
10:10 PM Changeset in webkit [126958] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2] Use explicit constructor in PageClientImpl.
https://bugs.webkit.org/show_bug.cgi?id=95170

Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-28
Reviewed by Darin Adler.

Added explicit keyword in constructor of PageClientImpl in order to avoid implicit type conversion.

  • UIProcess/API/gtk/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/mac/PageClientImpl.h:

(PageClientImpl):

10:09 PM Changeset in webkit [126957] by pdr@google.com
  • 10 edits
    7 adds
    23 deletes in trunk/LayoutTests

Unreviewed rebaseline after r126683

Unreviewed rebaseline of 8 test expectations after r126683.

Common baselines: (http/tests/misc/acid2-pixel-expected.txt already existed)

  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
  • ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
  • ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.

Chromium-specific baselines:

  • platform/chromium-win/http/tests/misc/acid2-pixel-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:

Removed entries that no longer need to be rebaselined:

  • platform/chromium/TestExpectations:

Removed these baselines so that they fall back to the common ones:

  • platform/chromium-linux-x86/http/tests/misc: Removed.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Removed.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Removed.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Removed.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Removed.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Removed.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Removed.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Removed.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Removed.
  • platform/mac-lion/http/tests/misc: Removed.
  • platform/mac-lion/http/tests/misc/acid2-pixel-expected.txt: Removed.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds: Removed.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Removed.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Removed.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Removed.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Removed.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Removed.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Removed.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Removed.
9:25 PM Changeset in webkit [126956] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[Chromium] Scheduler will never process a commit until it receives a vsync tick.
https://bugs.webkit.org/show_bug.cgi?id=94721

Patch by David Reveman <reveman@chromium.org> on 2012-08-28
Reviewed by James Robinson.

Source/WebCore:

Add updateResourcesComplete callback to CCScheduler and use this to
indicate completion of texture updates instead of calling
CCSchedulerClient::hasMoreResourceUpdates when receiving a vsync tick.

Unit tests: CCTextureUpdateControllerTest.UpdateMoreTextures

CCTextureUpdateControllerTest.HasMoreUpdates
CCTextureUpdateControllerTest.UpdatesCompleteInFiniteTime

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::beginFrameComplete):
(WebCore::CCScheduler::vsyncTick):
(WebCore::CCScheduler::updateResourcesComplete):
(WebCore):
(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCSchedulerClient):
(CCScheduler):

  • platform/graphics/chromium/cc/CCTextureUpdateController.cpp:

(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::updateMoreTextures):
(WebCore::CCTextureUpdateController::discardUploads):
(WebCore::CCTextureUpdateController::onTimerFired):
(WebCore::CCTextureUpdateController::updateMoreTexturesIfEnoughTimeRemaining):

  • platform/graphics/chromium/cc/CCTextureUpdateController.h:

(CCTextureUpdateControllerClient):
(WebCore::CCTextureUpdateControllerClient::~CCTextureUpdateControllerClient):
(WebCore):
(WebCore::CCTextureUpdateController::create):
(CCTextureUpdateController):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::didLoseContextOnImplThread):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionCommit):
(WebCore::CCThreadProxy::updateTexturesCompleted):
(WebCore):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(WebCore):

Source/WebKit/chromium:

  • tests/CCSchedulerTest.cpp:

(WebKitTests::FakeCCSchedulerClient::reset):
(WebKitTests::TEST):

  • tests/CCTextureUpdateControllerTest.cpp:
8:57 PM Changeset in webkit [126955] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/Source/JavaScriptCore

Adding support for adding LLInt opcode extensions. This will be needed
by the LLInt C loop interpreter later.
https://bugs.webkit.org/show_bug.cgi?id=95277.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-28
Reviewed by Geoffrey Garen.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Opcode.h:
  • llint/LLIntOpcode.h: Added.
  • llint/LowLevelInterpreter.h:
8:55 PM Changeset in webkit [126954] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Update some compositor trace events
https://bugs.webkit.org/show_bug.cgi?id=95275

Patch by John Bates <jbates@google.com> on 2012-08-28
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::setActive):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::onVSyncParametersChanged):

8:53 PM Changeset in webkit [126953] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

crypto.getRandomValues should throw an exception when given a big array
https://bugs.webkit.org/show_bug.cgi?id=95269

Reviewed by Eric Seidel.

Source/WebCore:

The W3C Web Cryptography Working Group has taken up specifying
window.crypto. The latest draft calls for getRandomValues to throw an
exception when given an array that's large.

Test: security/crypto-random-values-limits.html

  • page/Crypto.cpp:

(WebCore::Crypto::getRandomValues):

LayoutTests:

  • security/crypto-random-values-limits-expected.txt: Added.
  • security/crypto-random-values-limits.html: Added.
8:09 PM Changeset in webkit [126952] by eric@webkit.org
  • 3 edits in trunk/Tools

cr-ews bot doesn't set CWD correctly when zipping layout test results
https://bugs.webkit.org/show_bug.cgi?id=91265

Reviewed by Kenneth Russell.

This should make the zips slightly less cumbersome to deal with.

  • Scripts/webkitpy/common/system/workspace.py:

(Workspace.create_zip):

  • Scripts/webkitpy/common/system/workspace_unittest.py:

(WorkspaceTest.test_create_zip):
(WorkspaceTest.test_create_zip_exception):

7:36 PM Changeset in webkit [126951] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Fix ASSERT in fast/events/touch/gesture/context-menu-on-two-finger-tap.html

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::detectContentOnTouch):

7:34 PM Changeset in webkit [126950] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Fix the Commiters script

Unreviewed.

Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.

  • Scripts/webkitpy/common/config/committers.py:
7:16 PM Changeset in webkit [126949] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself to committers list.

  • Scripts/webkitpy/common/config/committers.py:
6:56 PM Changeset in webkit [126948] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Add minires to list of required cygwin install packages.
https://bugs.webkit.org/show_bug.cgi?id=76936

Reviewed by Tim Horton.

  • CygwinDownloader/cygwin-downloader.py:
6:16 PM Changeset in webkit [126947] by abarth@webkit.org
  • 9 edits
    6 adds in trunk

CSP doesn't turn off eval, etc. in Web Workers
https://bugs.webkit.org/show_bug.cgi?id=93392

Patch by Tom Sepez <tsepez@chromium.org> on 2012-08-28
Reviewed by Adam Barth.

On the JSC side, the blocking of eval() in workers was handled correctly, so it is
a matter of adding calls check the policy for setTimeout and SetInterval. On the v8
side, it is a matter of handling the above, plus eval().

Source/WebCore:

On the v8 side, the v8 context isn't available when the callers want to disable eval.
Rather than creating it earlier, which is problematic, remember the setting in the
WorkerContextExecutionProxy and apply before the next call to its evaluate() method.

Tests: http/tests/security/contentSecurityPolicy/worker-eval-blocked.html

http/tests/security/contentSecurityPolicy/worker-function-function-blocked.html

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::setInterval):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::setEvalAllowed):
(WebCore):

  • bindings/v8/WorkerContextExecutionProxy.h:

(WorkerContextExecutionProxy):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::disableEval):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::SetTimeoutOrInterval):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/resources/worker-eval.js: Added.
  • http/tests/security/contentSecurityPolicy/resources/worker-function-function.js: Added.

(fn):

  • http/tests/security/contentSecurityPolicy/resources/worker-set-timeout.js:
  • http/tests/security/contentSecurityPolicy/worker-eval-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-eval-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/worker-function-function-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-function-function-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/worker-set-timeout-blocked-expected.txt:
6:07 PM Changeset in webkit [126946] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

Make MediaSource event dispatch asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=95217

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-08-28
Reviewed by Eric Carlson.

Source/WebCore:

Update MediaSource & SourceBufferList to use a GenericEventQueue to dispatch events
instead of using synchronous dispatch.

Test: http/tests/media/media-source/video-media-source-async-events.html

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::MediaSource): Create GenericEventQueue & pass a pointer to SourceBufferList.
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::setReadyState): Updated to use new scheduleEvent() helper method.
(WebCore::MediaSource::scheduleEvent): New method for creating events and adding them to the event queue.
(WebCore):

  • Modules/mediasource/MediaSource.h: Added GenericEventQueue member and scheduleEvent() signature.

(MediaSource):

  • Modules/mediasource/SourceBufferList.cpp:

(WebCore::SourceBufferList::SourceBufferList):
(WebCore::SourceBufferList::remove):
(WebCore::SourceBufferList::createAndFireEvent): Updated to queue events instead of synchronously dispatch them.

  • Modules/mediasource/SourceBufferList.h:

(WebCore):
(WebCore::SourceBufferList::create):
(SourceBufferList):

LayoutTests:

  • Added a test to verify that MediaSource & SourceBufferList events are dispatched asynchronously.
  • Updated a few existing tests that were relying on the old synchronous dispatch.
  • http/tests/media/media-source/video-media-source-async-events-expected.txt: Added.
  • http/tests/media/media-source/video-media-source-async-events.html: Added.
  • http/tests/media/media-source/video-media-source-event-attributes.html:
  • http/tests/media/media-source/video-media-source-objects.html:
  • http/tests/media/media-source/video-media-source-seek-expected.txt:
  • http/tests/media/media-source/video-media-source-state-changes-expected.txt:
6:05 PM Changeset in webkit [126945] by leandrogracia@chromium.org
  • 6 edits
    1 add in trunk/Source

Content detection should not disrupt the page behaviour
https://bugs.webkit.org/show_bug.cgi?id=94727

Reviewed by Adam Barth.

Source/WebCore:

Tested by WebViewTest::DetectContentAroundPosition.

  • dom/Node.cpp:

(WebCore::Node::willRespondToTouchEvents): checks if a node listens to touch events. Very similar to willRespondToMouseClickEvents.
(WebCore):

  • dom/Node.h:

(Node):

Source/WebKit/chromium:

Triggers content detection in the embedder on tap gestures and
add checks for the appropriate event listeners in order to prevent
triggering content detection when it would disrupt the page's behaviour.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::detectContentOnTouch):

  • tests/WebViewTest.cpp:
  • tests/data/content_listeners.html: Added.
5:47 PM Changeset in webkit [126944] by jchaffraix@webkit.org
  • 49 edits
    7 copies
    24 moves
    2 adds
    68 deletes in trunk/LayoutTests

Unreviewed penultimate rebaseline after r126683.

  • platform/chromium/TestExpectations:

Removed 38 tests that got rebaselined.

  • editing/execCommand/4580583-1-expected.txt: Renamed from LayoutTests/platform/efl/editing/execCommand/4580583-1-expected.txt.
  • editing/execCommand/4580583-2-expected.txt: Renamed from LayoutTests/platform/efl/editing/execCommand/4580583-2-expected.txt.
  • fast/block/float/012-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/012-expected.txt.
  • fast/block/float/013-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/013-expected.txt.
  • fast/block/float/016-expected.txt:
  • fast/block/margin-collapse/041-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/margin-collapse/041-expected.txt.
  • fast/block/margin-collapse/043-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/margin-collapse/043-expected.txt.
  • fast/block/margin-collapse/057-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/margin-collapse/057-expected.txt.
  • fast/css/acid2-expected.txt:
  • fast/css/acid2-pixel-expected.txt:
  • fast/css/border-height-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/border-height-expected.txt.
  • fast/frames/viewsource-attribute-expected.txt: Renamed from LayoutTests/platform/efl/fast/frames/viewsource-attribute-expected.txt.
  • fast/frames/viewsource-on-image-file-expected.txt: Renamed from LayoutTests/platform/efl/fast/frames/viewsource-on-image-file-expected.txt.
  • fast/inline/inline-padding-disables-text-quirk-expected.txt: Renamed from LayoutTests/platform/efl/fast/inline/inline-padding-disables-text-quirk-expected.txt.
  • fast/inline/inline-text-quirk-bpm-expected.txt: Renamed from LayoutTests/platform/efl/fast/inline/inline-text-quirk-bpm-expected.txt.
  • fast/layers/scroll-rect-to-visible-expected.txt: Renamed from LayoutTests/platform/efl/fast/layers/scroll-rect-to-visible-expected.txt.
  • fast/lists/007-expected.txt: Renamed from LayoutTests/platform/efl/fast/lists/007-expected.txt.
  • fast/multicol/block-axis-horizontal-bt-expected.txt: Renamed from LayoutTests/platform/efl/fast/multicol/block-axis-horizontal-bt-expected.txt.
  • fast/multicol/block-axis-vertical-lr-expected.txt: Renamed from LayoutTests/platform/efl/fast/multicol/block-axis-vertical-lr-expected.txt.
  • fast/multicol/block-axis-vertical-rl-expected.txt: Renamed from LayoutTests/platform/efl/fast/multicol/block-axis-vertical-rl-expected.txt.
  • fast/overflow/overflow-rtl-expected.txt:
  • fast/overflow/overflow-rtl-inline-scrollbar-expected.txt: Renamed from LayoutTests/platform/efl/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt.
  • fast/table/border-collapsing/003-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/border-collapsing/003-expected.txt.
  • fast/table/border-collapsing/003-vertical-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/border-collapsing/003-vertical-expected.txt.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/border-collapsing/rtl-border-collapsing-expected.txt.
  • fast/table/colgroup-spanning-groups-rules-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/colgroup-spanning-groups-rules-expected.txt.
  • fast/text/basic/015-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/basic/015-expected.txt.
  • http/tests/misc/acid2-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/acid2-expected.txt.

Common baselines.

  • platform/efl/fast/block/float/016-expected.txt: Removed.
  • platform/efl/fast/css/acid2-pixel-expected.txt: Removed.
  • platform/efl/fast/overflow/overflow-rtl-expected.txt: Removed.
  • platform/efl/http/tests/misc/acid2-expected.txt: Removed.
  • platform/gtk/editing/execCommand/4580583-1-expected.txt: Removed.
  • platform/gtk/editing/execCommand/4580583-2-expected.txt: Removed.
  • platform/gtk/fast/block/float/012-expected.txt: Removed.
  • platform/gtk/fast/block/float/013-expected.txt: Removed.
  • platform/gtk/fast/block/float/016-expected.txt: Removed.
  • platform/gtk/fast/block/margin-collapse/041-expected.txt: Removed.
  • platform/gtk/fast/block/margin-collapse/043-expected.txt: Removed.
  • platform/gtk/fast/block/margin-collapse/057-expected.txt: Removed.
  • platform/gtk/fast/css/acid2-expected.txt: Removed.
  • platform/gtk/fast/css/acid2-pixel-expected.txt: Removed.
  • platform/gtk/fast/css/border-height-expected.txt: Removed.
  • platform/gtk/fast/frames/viewsource-attribute-expected.txt: Removed.
  • platform/gtk/fast/frames/viewsource-on-image-file-expected.txt: Removed.
  • platform/gtk/fast/inline/inline-padding-disables-text-quirk-expected.txt: Removed.
  • platform/gtk/fast/inline/inline-text-quirk-bpm-expected.txt: Removed.
  • platform/gtk/fast/layers/scroll-rect-to-visible-expected.txt: Removed.
  • platform/gtk/fast/lists/007-expected.txt: Removed.
  • platform/gtk/fast/multicol/block-axis-horizontal-bt-expected.txt: Removed.
  • platform/gtk/fast/multicol/block-axis-vertical-lr-expected.txt: Removed.
  • platform/gtk/fast/multicol/block-axis-vertical-rl-expected.txt: Removed.
  • platform/gtk/fast/overflow/overflow-rtl-expected.txt: Removed.
  • platform/gtk/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt: Removed.
  • platform/gtk/fast/table/border-collapsing/003-expected.txt: Removed.
  • platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt: Removed.
  • platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-expected.txt: Removed.
  • platform/gtk/fast/table/colgroup-spanning-groups-rules-expected.txt: Removed.
  • platform/gtk/fast/text/basic/015-expected.txt: Removed.
  • platform/gtk/http/tests/misc/acid2-expected.txt: Removed.
  • platform/mac-lion/editing/deleting/type-delete-after-quote-expected.txt: Removed.
  • platform/mac-lion/editing/execCommand/4580583-1-expected.txt: Removed.
  • platform/mac-lion/editing/execCommand/4580583-2-expected.txt: Removed.
  • platform/mac-lion/editing/inserting/5418891-expected.txt: Removed.
  • platform/mac-lion/editing/inserting/5510537-expected.txt: Removed.
  • platform/mac-lion/editing/inserting/6703873-expected.txt: Removed.
  • platform/mac-lion/editing/inserting/break-blockquote-after-delete-expected.txt: Removed.
  • platform/mac-lion/editing/pasteboard/5006779-expected.txt: Removed.
  • platform/mac-lion/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Removed.
  • platform/mac-lion/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Removed.
  • platform/mac-lion/fast/block/float/012-expected.txt: Removed.
  • platform/mac-lion/fast/block/float/013-expected.txt: Removed.
  • platform/mac-lion/fast/block/margin-collapse/041-expected.txt: Removed.
  • platform/mac-lion/fast/block/margin-collapse/043-expected.txt: Removed.
  • platform/mac-lion/fast/block/margin-collapse/057-expected.txt: Removed.
  • platform/mac-lion/fast/css/acid2-expected.txt: Removed.
  • platform/mac-lion/fast/css/acid2-pixel-expected.txt: Removed.
  • platform/mac-lion/fast/css/border-height-expected.txt: Removed.
  • platform/mac-lion/fast/frames/viewsource-attribute-expected.txt: Removed.
  • platform/mac-lion/fast/frames/viewsource-on-image-file-expected.txt: Removed.
  • platform/mac-lion/fast/inline/inline-padding-disables-text-quirk-expected.txt: Removed.
  • platform/mac-lion/fast/inline/inline-text-quirk-bpm-expected.txt: Removed.
  • platform/mac-lion/fast/layers/scroll-rect-to-visible-expected.txt: Removed.
  • platform/mac-lion/fast/lists/007-expected.txt: Removed.
  • platform/mac-lion/fast/multicol/block-axis-horizontal-bt-expected.txt: Removed.
  • platform/mac-lion/fast/multicol/block-axis-vertical-lr-expected.txt: Removed.
  • platform/mac-lion/fast/multicol/block-axis-vertical-rl-expected.txt: Removed.
  • platform/mac-lion/fast/overflow/overflow-rtl-expected.txt: Removed.
  • platform/mac-lion/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt: Removed.
  • platform/mac-lion/fast/table/border-collapsing/003-expected.txt: Removed.
  • platform/mac-lion/fast/table/border-collapsing/003-vertical-expected.txt: Removed.
  • platform/mac-lion/fast/table/border-collapsing/rtl-border-collapsing-expected.txt: Removed.
  • platform/mac-lion/fast/table/colgroup-spanning-groups-rules-expected.txt: Removed.
  • platform/mac-lion/fast/text/basic/015-expected.txt: Removed.
  • platform/mac-lion/http/tests/misc/acid2-expected.txt: Removed.

Removed those baselines so that they properly fallback to the correct ones.

  • platform/chromium-linux-x86/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
  • platform/chromium-linux-x86/fast/text/monospace-width-cache-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/text/monospace-width-cache-expected.txt.
  • platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
  • platform/chromium-linux/fast/text/monospace-width-cache-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/text/monospace-width-cache-expected.txt.
  • platform/chromium-mac-snowleopard/editing/inserting/break-blockquote-after-delete-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
  • platform/chromium-mac-snowleopard/fast/text/monospace-width-cache-expected.txt: Added.
  • platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/chromium-mac/fast/block/float/013-expected.txt:
  • platform/chromium-mac/fast/block/float/016-expected.txt:
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.txt:
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/chromium-mac/fast/text/monospace-width-cache-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
  • platform/chromium-win-xp/fast/text/monospace-width-cache-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/text/monospace-width-cache-expected.txt.
  • platform/chromium-win/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/chromium-win/editing/execCommand/4580583-1-expected.txt:
  • platform/chromium-win/editing/execCommand/4580583-2-expected.txt:
  • platform/chromium-win/editing/inserting/5418891-expected.txt:
  • platform/chromium-win/editing/inserting/5510537-expected.txt:
  • platform/chromium-win/editing/inserting/6703873-expected.txt:
  • platform/chromium-win/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/chromium-win/editing/pasteboard/5006779-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/chromium-win/fast/block/float/012-expected.txt:
  • platform/chromium-win/fast/block/float/013-expected.txt:
  • platform/chromium-win/fast/block/float/016-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/041-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/043-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/057-expected.txt:
  • platform/chromium-win/fast/css/acid2-expected.txt:
  • platform/chromium-win/fast/css/acid2-pixel-expected.txt:
  • platform/chromium-win/fast/css/border-height-expected.txt:
  • platform/chromium-win/fast/frames/viewsource-attribute-expected.txt:
  • platform/chromium-win/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/chromium-win/fast/inline/inline-padding-disables-text-quirk-expected.txt:
  • platform/chromium-win/fast/inline/inline-text-quirk-bpm-expected.txt:
  • platform/chromium-win/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/chromium-win/fast/lists/007-expected.txt:
  • platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.txt:
  • platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.txt:
  • platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-rtl-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/003-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/chromium-win/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/chromium-win/fast/text/basic/015-expected.txt:
  • platform/chromium-win/fast/text/monospace-width-cache-expected.txt:
  • platform/chromium-win/http/tests/misc/acid2-expected.txt:

Chromium specific updates.

5:38 PM Changeset in webkit [126943] by Simon Fraser
  • 3 edits
    2 adds in trunk

Handle sticky that overflows its container
https://bugs.webkit.org/show_bug.cgi?id=95260

Reviewed by Ojan Vafai.

Source/WebCore:

When an element with position:sticky overflows its container,
don't have the sticky code push it back inside that container.
It will just never get offset in the sticky direction.

Test: fast/css/sticky/sticky-overflowing.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::stickyPositionOffset):

LayoutTests:

Testcase with sticky elements that overflow their containers.

  • fast/css/sticky/sticky-overflowing-expected.html: Added.
  • fast/css/sticky/sticky-overflowing.html: Added.
5:28 PM Changeset in webkit [126942] by wangxianzhu@chromium.org
  • 4 edits in trunk

[Chromium-Android] Upstream layout test expectations (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=95212

Reviewed by Adam Barth.

Tools:

  • Now run both gpu path and non-gpu path of 2d canvas layout tests

because both are used in chromium-android.

  • Exclude all webgl tests because webgl is not enabled yet.
  • Removed 'win' from the baseline fallback list. This was a mistake.
  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort):
(ChromiumAndroidPort.skipped_layout_tests):

LayoutTests:

Update test expectations for Android:

  • 2d canvas tests (both gpu and non-gpu path)
  • compositing tests
  • more WONTFIXes for control behavior tests
  • skip features not enabled on Android
  • platform/chromium/TestExpectations:
4:47 PM Changeset in webkit [126941] by commit-queue@webkit.org
  • 6 edits in trunk

Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
https://bugs.webkit.org/show_bug.cgi?id=95185

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-28
Reviewed by Chris Fleizach.

Tools:

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::titleUIElement): Implemented
Gets the ATK_RELATION_LABELLED_BY target.
(AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
bug 95180 is fixed.

LayoutTests:

Updated layout test expected results. In all three cases below:
1) Remove objects from the tree representation which did not belong,
but were included as a side effect of AccessibilityUIElement::stringValue()
not having been implemented.
2) Add the stringValue() return value to the tree representation.
Note that the implementation of AccessibilityUIElement::titleUIElement()
will be tested by the existing legend.html layout text. See bug 84137.

  • platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Updated.
  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated.
  • platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Updated.
4:35 PM Changeset in webkit [126940] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r126933.
http://trac.webkit.org/changeset/126933
https://bugs.webkit.org/show_bug.cgi?id=95261

Turns out we do need this! (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-28

  • public/WebWidget.h:

(WebKit::WebWidget::paint):

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::paint):

  • src/WebPagePopupImpl.h:

(WebPagePopupImpl):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::paint):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):

  • src/WebViewImpl.h:

(WebViewImpl):

4:30 PM Changeset in webkit [126939] by pilgrim@chromium.org
  • 5 edits in trunk/Source

[Chromium] Remove decodeAudioFileData from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=95250

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/audio/chromium/AudioBusChromium.cpp:

(WebCore::decodeAudioFileData):
(WebCore):
(WebCore::AudioBus::loadPlatformResource):
(WebCore::createBusFromInMemoryAudioFile):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

4:27 PM Changeset in webkit [126938] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rolled out r126928, this broke stuff :'-(

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::resetPatchPutById):

4:07 PM Changeset in webkit [126937] by timothy@apple.com
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

3:59 PM Changeset in webkit [126936] by commit-queue@webkit.org
  • 2 edits in trunk

Add directory generated by Eclipse to .gitignore
https://bugs.webkit.org/show_bug.cgi?id=95231

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-08-28
Reviewed by Andreas Kling.

  • .gitignore: Ignore .settings directory.
3:53 PM Changeset in webkit [126935] by timothy@apple.com
  • 1 copy in tags/Safari-536.26.10

New tag.

3:31 PM Changeset in webkit [126934] by jchaffraix@webkit.org
  • 4 edits
    1 delete in trunk/LayoutTests

Unreviewed gardening, more rebaselining after r126911.

  • platform/chromium-win-xp/fast/inline: Removed.
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:
  • platform/chromium-win/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png:
3:14 PM Changeset in webkit [126933] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r126344.
http://trac.webkit.org/changeset/126344
https://bugs.webkit.org/show_bug.cgi?id=95253

This change is no longer needed (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-28

  • public/WebWidget.h:

(WebKit::WebWidget::paint):

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::paint):

  • src/WebPagePopupImpl.h:

(WebPagePopupImpl):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::paint):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):

  • src/WebViewImpl.h:

(WebViewImpl):

2:58 PM Changeset in webkit [126932] by dmazzoni@google.com
  • 5 edits in trunk

AX: Crash due to object getting deleted inside updateBackingStore
https://bugs.webkit.org/show_bug.cgi?id=94619

Reviewed by Chris Fleizach.

Source/WebKit/chromium:

Chromium now calls updateBackingStoreAndCheckValidity explicitly,
so we can now get rid of calls to updateBackingStore in the
method implementations, and just make sure we're checking isDetached.

  • public/WebAccessibilityObject.h:

(WebAccessibilityObject):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::axID):
(WebKit::WebAccessibilityObject::accessibilityDescription):
(WebKit::WebAccessibilityObject::actionVerb):
(WebKit::WebAccessibilityObject::canSetFocusAttribute):
(WebKit::WebAccessibilityObject::canSetValueAttribute):
(WebKit::WebAccessibilityObject::childCount):
(WebKit::WebAccessibilityObject::childAt):
(WebKit::WebAccessibilityObject::firstChild):
(WebKit::WebAccessibilityObject::focusedChild):
(WebKit::WebAccessibilityObject::lastChild):
(WebKit::WebAccessibilityObject::nextSibling):
(WebKit::WebAccessibilityObject::parentObject):
(WebKit::WebAccessibilityObject::previousSibling):
(WebKit::WebAccessibilityObject::canSetSelectedAttribute):
(WebKit::WebAccessibilityObject::isAnchor):
(WebKit::WebAccessibilityObject::isAriaReadOnly):
(WebKit::WebAccessibilityObject::isButtonStateMixed):
(WebKit::WebAccessibilityObject::isChecked):
(WebKit::WebAccessibilityObject::isCollapsed):
(WebKit::WebAccessibilityObject::isControl):
(WebKit::WebAccessibilityObject::isEnabled):
(WebKit::WebAccessibilityObject::isFocused):
(WebKit::WebAccessibilityObject::isHovered):
(WebKit::WebAccessibilityObject::isIndeterminate):
(WebKit::WebAccessibilityObject::isLinked):
(WebKit::WebAccessibilityObject::isLoaded):
(WebKit::WebAccessibilityObject::isMultiSelectable):
(WebKit::WebAccessibilityObject::isOffScreen):
(WebKit::WebAccessibilityObject::isPasswordField):
(WebKit::WebAccessibilityObject::isPressed):
(WebKit::WebAccessibilityObject::isReadOnly):
(WebKit::WebAccessibilityObject::isRequired):
(WebKit::WebAccessibilityObject::isSelected):
(WebKit::WebAccessibilityObject::isSelectedOptionActive):
(WebKit::WebAccessibilityObject::isVertical):
(WebKit::WebAccessibilityObject::isVisible):
(WebKit::WebAccessibilityObject::isVisited):
(WebKit::WebAccessibilityObject::accessKey):
(WebKit::WebAccessibilityObject::ariaHasPopup):
(WebKit::WebAccessibilityObject::ariaLiveRegionAtomic):
(WebKit::WebAccessibilityObject::ariaLiveRegionBusy):
(WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
(WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
(WebKit::WebAccessibilityObject::boundingBoxRect):
(WebKit::WebAccessibilityObject::estimatedLoadingProgress):
(WebKit::WebAccessibilityObject::helpText):
(WebKit::WebAccessibilityObject::headingLevel):
(WebKit::WebAccessibilityObject::hierarchicalLevel):
(WebKit::WebAccessibilityObject::hitTest):
(WebKit::WebAccessibilityObject::keyboardShortcut):
(WebKit::WebAccessibilityObject::performDefaultAction):
(WebKit::WebAccessibilityObject::roleValue):
(WebKit::WebAccessibilityObject::selectionEnd):
(WebKit::WebAccessibilityObject::selectionStart):
(WebKit::WebAccessibilityObject::stringValue):
(WebKit::WebAccessibilityObject::title):
(WebKit::WebAccessibilityObject::titleUIElement):
(WebKit::WebAccessibilityObject::url):
(WebKit::WebAccessibilityObject::valueDescription):
(WebKit::WebAccessibilityObject::valueForRange):
(WebKit::WebAccessibilityObject::maxValueForRange):
(WebKit::WebAccessibilityObject::minValueForRange):
(WebKit::WebAccessibilityObject::node):
(WebKit::WebAccessibilityObject::document):
(WebKit::WebAccessibilityObject::accessibilityIsIgnored):
(WebKit::WebAccessibilityObject::lineBreaks):
(WebKit::WebAccessibilityObject::columnCount):
(WebKit::WebAccessibilityObject::rowCount):
(WebKit::WebAccessibilityObject::cellForColumnAndRow):
(WebKit::WebAccessibilityObject::cellColumnIndex):
(WebKit::WebAccessibilityObject::cellColumnSpan):
(WebKit::WebAccessibilityObject::cellRowIndex):
(WebKit::WebAccessibilityObject::cellRowSpan):
(WebKit::WebAccessibilityObject::scrollToMakeVisible):
(WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebKit::WebAccessibilityObject::scrollToGlobalPoint):

Tools:

Change isValid to !isDetached after deleting isValid from
chromium WebAccessibilityObject as being redundant.

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(AccessibilityUIElement::isValidGetterCallback):

2:56 PM Changeset in webkit [126931] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Add ENABLE_CSS_COMPOSITING flag to WebKit2 project
https://bugs.webkit.org/show_bug.cgi?id=95227

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-08-28
Reviewed by Dirk Schulze.

The WebKit2 project was not updated to compile with the CSS_COMPOSITING flag.
This caused crashes when the webkit2 code had to use that flag.

  • Configurations/FeatureDefines.xcconfig:
2:51 PM Changeset in webkit [126930] by pdr@google.com
  • 2 edits in trunk/LayoutTests

Rebaseline crash-hw-sw-switch.html for Chromium Snow Leopard.

Unreviewed update of test expectations.

The purpose of this test is to track crash regressions so it is still
passing even with the slightly different pixel results.

  • platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
2:39 PM Changeset in webkit [126929] by pdr@google.com
  • 2 edits in trunk/LayoutTests

Mark filesystem-url-in-iframe as flaky
https://bugs.webkit.org/show_bug.cgi?id=95246

Marking a test as flaky without review.

This test is flaky, producing different text output once every few runs.
This patch temporarily marks it as flaky until the test can be fixed.

  • platform/chromium/TestExpectations:
2:21 PM Changeset in webkit [126928] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

PutById uses DataLabel32, not DataLabelCompact
https://bugs.webkit.org/show_bug.cgi?id=95245

Reviewed by Geoff Garen.

JIT::resetPatchPutById calls the the wrong thing on x86-64 – this is moot right now,
since they currently both do the same thing, but if we were to ever make compact mean
8-bit this could be a real problem. Also, don't rely on the object still being in eax
on entry to the transition stub – this isn't very robust.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

  • DataLabelCompact -> DataLabel32

(JSC::JIT::resetPatchPutById):

  • reload regT0 from the stack
2:02 PM Changeset in webkit [126927] by Alexandru Chiculita
  • 83 edits
    3 copies
    15 adds in trunk

[CSS Filters] Filters should render using sRGB until the specification says how it works
https://bugs.webkit.org/show_bug.cgi?id=94372

Reviewed by Dirk Schulze.

Source/WebCore:

The short-hand version of the CSS Filters should render using sRGB until a CSS property is added
to allow choosing the color space to be used when computing the filters.
For now I've just made all the CSS filters use sRGB by defualt. Note that this change has no effect on SVG filters.

Test: css3/filters/null-effect-check.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

LayoutTests:

Added test to check that blur(0) grayscale(0) is the same as grayscale(0) blur(0).
Also rebaselined expected results on Safari Mac, Chromium Mac/Linux.

  • css3/filters/filter-change-repaint-composited-expected.png:
  • css3/filters/filter-change-repaint-expected.png:
  • css3/filters/filter-repaint-blur-expected.png:
  • css3/filters/filter-repaint-child-layers-expected.png:
  • css3/filters/filter-repaint-composited-fallback-crash-expected.png:
  • css3/filters/filter-repaint-composited-fallback-expected.png:
  • css3/filters/filter-repaint-sepia-expected.png:
  • css3/filters/filter-repaint-shadow-clipped-expected.png:
  • css3/filters/filter-repaint-shadow-expected.png:
  • css3/filters/filter-repaint-shadow-rotated-expected.png:
  • css3/filters/null-effect-check-expected.html: Added.
  • css3/filters/null-effect-check.html: Added.
  • css3/filters/remove-filter-rendering-expected.png:
  • platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-linux/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
  • platform/chromium-linux/css3/filters/custom/filter-repaint-custom-expected.png:
  • platform/chromium-linux/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
  • platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png:
  • platform/chromium-linux/css3/filters/effect-brightness-expected.png:
  • platform/chromium-linux/css3/filters/filter-empty-element-crash-expected.png:
  • platform/chromium-mac/css3/filters/add-filter-rendering-expected.png:
  • platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
  • platform/chromium-mac/css3/filters/effect-blur-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-expected.png:
  • platform/chromium-mac/css3/filters/effect-combined-expected.png:
  • platform/chromium-mac/css3/filters/effect-contrast-expected.png:
  • platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-mac/css3/filters/effect-invert-expected.png:
  • platform/chromium-mac/css3/filters/effect-opacity-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-external-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png:
  • platform/chromium-mac/css3/filters/effect-saturate-expected.png:
  • platform/chromium-mac/css3/filters/effect-sepia-expected.png:
  • platform/chromium-mac/css3/filters/filter-repaint-blur-expected.png: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-blur-expected.txt: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.png: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.txt: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.txt: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.txt: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-expected.png:
  • platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png.
  • platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.txt: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png.
  • platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.txt: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.png: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.txt: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png.
  • platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.txt: Added.
  • platform/chromium-mac/css3/filters/filtered-inline-expected.png:
  • platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png:
  • platform/chromium-mac/css3/filters/nested-filters-expected.png:
  • platform/chromium-mac/css3/filters/regions-expanding-expected.png:
  • platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png:
  • platform/chromium-win/css3/filters/add-filter-rendering-expected.png:
  • platform/chromium-win/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-win/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-win/css3/filters/effect-blur-expected.png:
  • platform/chromium-win/css3/filters/effect-combined-expected.png:
  • platform/chromium-win/css3/filters/effect-contrast-expected.png:
  • platform/chromium-win/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-win/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-win/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-win/css3/filters/effect-invert-expected.png:
  • platform/chromium-win/css3/filters/effect-opacity-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-external-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-ordering-expected.png:
  • platform/chromium-win/css3/filters/effect-saturate-expected.png:
  • platform/chromium-win/css3/filters/effect-sepia-expected.png:
  • platform/chromium-win/css3/filters/filter-repaint-expected.png:
  • platform/chromium-win/css3/filters/filtered-inline-expected.png:
  • platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png:
  • platform/chromium-win/css3/filters/nested-filters-expected.png:
  • platform/chromium-win/css3/filters/regions-expanding-expected.png:
  • platform/chromium-win/css3/filters/simple-filter-rendering-expected.png:
  • platform/chromium/TestExpectations: css3/filters directory needs rebaseline on Windows.
  • platform/chromium/css3/filters/blur-filter-page-scroll-expected.png:
  • platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png:
  • platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.png:
  • platform/mac/TestExpectations: Unskipped old failing tests.
1:54 PM Changeset in webkit [126926] by commit-queue@webkit.org
  • 402 edits in trunk

Unreviewed, rolling out r126914.
http://trac.webkit.org/changeset/126914
https://bugs.webkit.org/show_bug.cgi?id=95239

it breaks everything and fixes nothing (Requested by pizlo on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-28

Source/JavaScriptCore:

  • API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren):

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyNames):

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::contextData):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::EvalCodeCache::visitAggregate):
(JSC::CodeBlock::nameForRegister):

  • bytecode/JumpTable.h:

(JSC::StringJumpTable::offsetForValue):
(JSC::StringJumpTable::ctiForValue):

  • bytecode/LazyOperandValueProfile.cpp:

(JSC::LazyOperandValueProfileParser::getIfPresent):

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::dump):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitLazyNewFunction):

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • debugger/Debugger.cpp:
  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):

  • dfg/DFGAssemblyHelpers.cpp:

(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):

  • dfg/DFGByteCodeCache.h:

(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):
(JSC::DFG::StructureCheckHoistingPhase::noticeStructureCheck):
(JSC::DFG::StructureCheckHoistingPhase::noticeClobber):

  • heap/Heap.cpp:

(JSC::Heap::markProtectedObjects):

  • heap/Heap.h:

(JSC::Heap::forEachProtectedCell):

  • heap/JITStubRoutineSet.cpp:

(JSC::JITStubRoutineSet::markSlow):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):

  • heap/MarkStack.cpp:

(JSC::MarkStack::internalAppend):

  • heap/Weak.h:

(JSC::weakRemove):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::ctiStub):

  • parser/Parser.cpp:

(JSC::::parseStrictObjectLiteral):

  • profiler/Profile.cpp:

(JSC::functionNameCountPairComparator):
(JSC::Profile::debugPrintDataSampleStyle):

  • runtime/Identifier.cpp:

(JSC::Identifier::add):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::put):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayValueMap::visitChildren):
(JSC::JSArray::enterDictionaryMode):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::setLength):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::checkConsistency):

  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::getOwnPropertyNames):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::invalidateCode):

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::clear):
(JSC::WeakGCMap::set):

  • tools/ProfileTreeNode.h:

(JSC::ProfileTreeNode::sampleChild):
(JSC::ProfileTreeNode::childCount):
(JSC::ProfileTreeNode::dumpInternal):
(JSC::ProfileTreeNode::compareEntries):

Source/WebCore:

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::Watchers::find):
(WebCore::Geolocation::Watchers::remove):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::objectStoreNames):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::metadata):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
(WebCore::IDBFactoryBackendImpl::open):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::objectStoreDeleted):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::dispatchEvent):

  • Modules/webdatabase/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::performOpenAndVerify):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

  • Modules/webdatabase/OriginUsageRecord.cpp:

(WebCore::OriginUsageRecord::diskUsage):

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):

  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

  • Modules/webdatabase/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):
(WebCore::QuotaTracker::updateDatabaseSize):

  • Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketExtensionDeflateFrame::processResponse):

  • Modules/websockets/WebSocketExtensionDispatcher.cpp:

(WebCore::WebSocketExtensionDispatcher::appendAcceptedExtension):

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache):

  • bindings/gobject/DOMObjectCache.cpp:

(WebKit::DOMObjectCache::clearByFrame):

  • bindings/js/DOMObjectHashTableMap.h:

(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::cacheDOMStructure):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::getDOMConstructor):

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::clearScriptObjects):

  • bindings/js/ScriptController.h:

(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::checkForDuplicate):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::GetRawTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::GetRawTemplate):
(WebCore::V8TestEventTarget::GetTemplate):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::GetRawTemplate):
(WebCore::V8TestInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetRawTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetRawTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetRawTemplate):
(WebCore::V8TestNode::GetTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::GetRawTemplate):
(WebCore::V8TestObj::GetTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::deallocate):
(WebCore::DOMWrapperWorld::getOrCreateIsolatedWorld):

  • bindings/v8/NPV8Object.cpp:

(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8DOMMap.h:

(WebCore::WeakReferenceMap::removeIfPresent):
(WebCore::WeakReferenceMap::visit):

  • bindings/v8/V8GCController.cpp:

(WebCore::enumerateGlobalHandles):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::dispose):

  • bindings/v8/npruntime.cpp:
  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • bridge/NP_jsobject.cpp:

(ObjectMap::add):
(ObjectMap::remove):

  • bridge/jni/jsc/JavaClassJSC.cpp:

(JavaClass::~JavaClass):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::WeakMap::set):

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::invalidate):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::counterToCSSValue):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::crossfadeChanged):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::getImage):

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::parsePseudoType):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createFontFamilyValue):
(WebCore::CSSValuePool::createFontFaceValue):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::ruleSetForScope):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAddNamespace):
(WebCore::StyleSheetContents::determineNamespace):

  • dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationScope::MutationAccumulationRouter::childAdded):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::decrementScopingLevel):

  • dom/Document.cpp:

(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::getCSSCanvasElement):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
(WebCore::DocumentMarkerController::showMarkers):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::remove):

  • dom/ElementAttributeData.cpp:

(WebCore::ensureAttrListForElement):

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):

  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::eventTypes):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::nextListener):

  • dom/IdTargetObserverRegistry.cpp:

(WebCore::IdTargetObserverRegistry::addObserver):
(WebCore::IdTargetObserverRegistry::removeObserver):

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryInstrumentation::addInstrumentedMapEntries):
(WebCore::MemoryInstrumentation::addInstrumentedMapValues):

  • dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::clearRareData):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::Node::collectMatchingObserversForMutation):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
(WebCore::NodeListsNodeData::adoptTreeScope):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::adjustMinimumTimerInterval):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCache::add):

  • dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitStringData::create):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

  • editing/mac/AlternativeTextUIController.mm:

(WebCore::AlternativeTextUIController::AlernativeTextContextController::alternativesForContext):

  • html/FormController.cpp:

(WebCore::SavedFormState::serializeTo):
(WebCore::SavedFormState::appendControlState):
(WebCore::SavedFormState::takeControlState):
(WebCore::SavedFormState::getReferencedFilePaths):
(WebCore::FormKeyGenerator::formKey):
(WebCore::FormController::createSavedFormStateMap):
(WebCore::FormController::formElementsState):
(WebCore::FormController::takeStateForFormElement):
(WebCore::FormController::getReferencedFilePaths):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollectionCacheBase::append):

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeAttachments):

  • inspector/CodeGeneratorInspector.py:
  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):

  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptIdFor):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
(WebCore::InjectedScriptManager::releaseObjectGroup):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::commitSelector):
(WebCore::SelectorProfile::commitSelectorTime):
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::didModifyDOMAttr):
(WebCore::InspectorCSSAgent::resetPseudoStates):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::count):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::nodeForId):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::memoryBytesUsedByStorageCache):

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::databaseId):
(WebCore::InspectorDatabaseAgent::findByFileName):
(WebCore::InspectorDatabaseAgent::databaseForId):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

  • inspector/InspectorPageAgent.cpp:

(WebCore::cachedResourcesForFrame):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameDetached):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getProfile):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForHeaders):
(WebCore::InspectorResourceAgent::willSendRequest):

  • inspector/InspectorState.cpp:

(WebCore::InspectorState::getBoolean):
(WebCore::InspectorState::getString):
(WebCore::InspectorState::getLong):
(WebCore::InspectorState::getDouble):
(WebCore::InspectorState::getObject):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::styleWithProperties):
(WebCore::InspectorStyleSheet::inspectorStyleForId):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorObjectBase::get):
(WebCore::InspectorObjectBase::writeJSON):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore::NetworkResourcesData::clear):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isSimpleCrossOriginAccessRequest):
(WebCore::createAccessControlPreflightRequest):

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::getSubresources):
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::servePendingRequests):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::removeResource):
(WebCore::ApplicationCache::clearStorageID):
(WebCore::ApplicationCache::dump):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::startLoadingEntry):
(WebCore::ApplicationCacheGroup::addEntry):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::fillResourceList):

  • loader/appcache/ApplicationCacheResource.cpp:

(WebCore::ApplicationCacheResource::estimatedSizeInStorage):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::empty):
(WebCore::ApplicationCacheStorage::storeCopyOfCache):

  • loader/archive/ArchiveFactory.cpp:

(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::canReuse):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::switchClientsToRevalidatedResource):
(WebCore::CachedResource::updateResponseAfterRevalidation):

  • loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::removeCachedResource):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::reportMemoryUsage):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeResourcesWithOrigin):
(WebCore::MemoryCache::getOriginsWithCache):
(WebCore::MemoryCache::getStatistics):
(WebCore::MemoryCache::reportMemoryUsage):
(WebCore::MemoryCache::setDisabled):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::removeAllIcons):
(WebCore::IconDatabase::iconRecordCountWithData):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScripts):

  • page/PageGroup.cpp:

(WebCore::PageGroup::pageGroup):
(WebCore::PageGroup::closeLocalStorage):
(WebCore::PageGroup::clearLocalStorageForAllOrigins):
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore::PageGroup::syncLocalStorage):
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::urlForBlankFrame):

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

  • page/Settings.cpp:

(WebCore::setGenericFontFamilyMap):
(WebCore::getGenericFontFamilyForScript):

  • page/SpeechInput.cpp:

(WebCore::SpeechInput::registerListener):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::boolFeature):
(WebCore::WindowFeatures::floatFeature):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::numberOfActiveAnimations):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::clearRenderer):
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):
(WebCore::CompositeAnimation::getAnimatedStyle):
(WebCore::CompositeAnimation::setAnimating):
(WebCore::CompositeAnimation::timeToNextService):
(WebCore::CompositeAnimation::getAnimationForProperty):
(WebCore::CompositeAnimation::suspendAnimations):
(WebCore::CompositeAnimation::resumeAnimations):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::CompositeAnimation::isAnimatingProperty):
(WebCore::CompositeAnimation::numberOfActiveAnimations):

  • platform/Language.cpp:

(WebCore::languageDidChange):

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

  • platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore::CookieManager::removeAllCookies):

  • platform/blackberry/CookieMap.cpp:

(WebCore::CookieMap::removeOldestCookie):
(WebCore::CookieMap::getAllChildCookies):

  • platform/cf/BinaryPropertyList.cpp:

(WebCore::BinaryPropertyListPlan::writeIntegerArray):

  • platform/chromium/support/WebHTTPLoadInfo.cpp:

(WebKit::addHeader):

  • platform/chromium/support/WebURLRequest.cpp:

(WebKit::WebURLRequest::visitHTTPHeaderFields):

  • platform/chromium/support/WebURLResponse.cpp:

(WebKit::WebURLResponse::addHTTPHeaderField):
(WebKit::WebURLResponse::visitHTTPHeaderFields):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::unregisterClient):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getVerticalData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::treeGlyphPageCount):
(WebCore::GlyphPageTreeNode::pageCount):
(WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
(WebCore::GlyphPageTreeNode::pruneTreeFontData):
(WebCore::GlyphPageTreeNode::pruneCustomFontData):
(WebCore::GlyphPageTreeNode::pruneFontData):
(WebCore::GlyphPageTreeNode::showSubtree):
(showGlyphPageTrees):

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::resizeEdgeTiles):
(WebCore::TiledBackingStore::setKeepRect):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::avfWrapperForCallbackContext):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::bindContentsTexture):

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::textureForColor):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::pauseAnimation):
(WebCore::GraphicsLayerCA::layerDidDisplay):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateTransform):
(WebCore::GraphicsLayerCA::updateChildrenTransform):
(WebCore::GraphicsLayerCA::updateMasksToBounds):
(WebCore::GraphicsLayerCA::updateContentsVisibility):
(WebCore::GraphicsLayerCA::updateContentsOpaque):
(WebCore::GraphicsLayerCA::updateBackfaceVisibility):
(WebCore::GraphicsLayerCA::updateFilters):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsRect):
(WebCore::GraphicsLayerCA::updateMaskLayer):
(WebCore::GraphicsLayerCA::updateLayerAnimations):
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::removeCAAnimationFromLayer):
(WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer):
(WebCore::GraphicsLayerCA::suspendAnimations):
(WebCore::GraphicsLayerCA::resumeAnimations):
(WebCore::GraphicsLayerCA::findOrMakeClone):
(WebCore::GraphicsLayerCA::setOpacityInternal):
(WebCore::GraphicsLayerCA::updateOpacityOnLayer):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::~TileCache):
(WebCore::TileCache::setNeedsDisplay):
(WebCore::TileCache::setScale):
(WebCore::TileCache::setAcceleratesDrawing):
(WebCore::TileCache::setTileDebugBorderWidth):
(WebCore::TileCache::setTileDebugBorderColor):
(WebCore::TileCache::revalidateTiles):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::animationStarted):
(resubmitAllAnimations):
(PlatformCALayer::animationForKey):

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::LookupAltName):
(WebCore::fontContainsCharacter):

  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:

(WebCore::getDerivedFontData):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::invalidateContentRect):
(WebCore::TiledLayerChromium::setTexturePriorities):
(WebCore::TiledLayerChromium::resetUpdateState):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::trackDamageFromLeftoverRects):

  • platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::setBounds):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::stopRateLimiter):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::findRenderPassById):

  • platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::inUseByConsumer):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::deleteOwnedResources):
(WebCore::CCResourceProvider::resourceType):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::destroyChild):
(WebCore::CCResourceProvider::getChildToParentMap):
(WebCore::CCResourceProvider::prepareSendToParent):
(WebCore::CCResourceProvider::prepareSendToChild):
(WebCore::CCResourceProvider::receiveFromChild):
(WebCore::CCResourceProvider::receiveFromParent):
(WebCore::CCResourceProvider::transferResource):
(WebCore::CCResourceProvider::trimMailboxDeque):

  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::getCompiledProgram):
(WebCore::CustomFilterGlobalContext::removeCompiledProgram):

  • platform/graphics/filters/CustomFilterProgram.cpp:

(WebCore::CustomFilterProgram::notifyClients):

  • platform/graphics/harfbuzz/HarfBuzzSkia.cpp:

(WebCore::getCachedHarfbuzzFace):
(WebCore::releaseCachedHarfbuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp:

(WebCore::HarfBuzzNGFace::HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::~HarfBuzzNGFace):

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):

  • platform/graphics/openvg/EGLDisplayOpenVG.cpp:

(WebCore::EGLDisplayOpenVG::~EGLDisplayOpenVG):
(WebCore::EGLDisplayOpenVG::destroySurface):
(WebCore::EGLDisplayOpenVG::contextForSurface):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

  • platform/graphics/wince/FontPlatformData.cpp:

(WebCore::FixedSizeFontData::create):

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::forClipboard):

  • platform/gtk/GtkDragAndDropHelper.cpp:

(WebCore::GtkDragAndDropHelper::handleGetDragData):
(WebCore::GtkDragAndDropHelper::handleDragLeave):
(WebCore::GtkDragAndDropHelper::handleDragMotion):
(WebCore::GtkDragAndDropHelper::handleDragDataReceived):
(WebCore::GtkDragAndDropHelper::handleDragDrop):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::gtkStyleChangedCallback):
(WebCore::getStyleContext):

  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):

  • platform/network/CredentialStorage.cpp:

(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::get):

  • platform/network/MIMEHeader.cpp:

(WebCore::MIMEHeader::parseHeader):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::addHTTPHeaderField):
(WebCore::ResourceRequestBase::addHTTPHeaderFields):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::targetTypeFromMimeType):
(WebCore::ResourceRequest::initializePlatformRequest):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::setClientCertificate):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::toSoupMessage):

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::toSoupMessage):

  • platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::start):

  • platform/qt/RunLoopQt.cpp:

(WebCore::RunLoop::TimerBase::timerFired):

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::scriptNameToCode):
(WebCore::localeToScriptCodeForFontSelection):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::pruneBlacklistedCodecs):
(WebCore::dumpTextEncodingNameMap):

  • platform/text/transcoder/FontTranscoder.cpp:

(WebCore::FontTranscoder::converterType):

  • platform/text/win/TextCodecWin.cpp:

(WebCore::LanguageManager::LanguageManager):
(WebCore::getCodePage):
(WebCore::TextCodecWin::registerExtendedEncodingNames):
(WebCore::TextCodecWin::registerExtendedCodecs):
(WebCore::TextCodecWin::enumerateSupportedEncodings):

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::getDataMapItem):
(WebCore::getClipboardData):
(WebCore::setClipboardData):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::types):

  • platform/win/FileSystemWin.cpp:

(WebCore::cachedStorageDirectory):

  • platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::TimerBase::timerFired):

  • platform/win/WCDataObject.cpp:

(WebCore::WCDataObject::createInstance):

  • platform/wince/MIMETypeRegistryWinCE.cpp:

(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

  • platform/wx/ContextMenuWx.cpp:

(WebCore::ContextMenu::appendItem):

  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::MIMETypeForExtension):
(WebCore::PluginDatabase::remove):

  • plugins/PluginMainThreadScheduler.cpp:

(WebCore::PluginMainThreadScheduler::scheduleCall):
(WebCore::PluginMainThreadScheduler::dispatchCalls):

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::startStream):

  • plugins/blackberry/PluginDataBlackBerry.cpp:

(WebCore::PluginData::initPlugins):

  • plugins/wx/PluginDataWx.cpp:

(WebCore::PluginData::initPlugins):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::unregisterNamedFlowContentNode):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::requiresIdeographicBaseline):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::highQualityRepaintTimerFired):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::performOverlapTests):

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayerFilterInfo::filterInfoForRenderLayer):
(WebCore::RenderLayerFilterInfo::createFilterInfoForRenderLayerIfNeeded):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::RenderNamedFlowThread::pushDependencies):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::cachedCollapsedBorder):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor):

  • rendering/RenderView.cpp:

(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::setSelection):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::resumeWidgetHierarchyUpdates):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/VerticalPositionCache.h:

(WebCore::VerticalPositionCache::get):

  • rendering/WrapShapeInfo.cpp:

(WebCore::WrapShapeInfo::ensureWrapShapeInfoForRenderBlock):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::characterStartsNewTextChunk):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::resourceDestroyed):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::swapItemsInLayoutAttributes):

  • rendering/svg/SVGTextLayoutAttributes.cpp:

(WebCore::SVGTextLayoutAttributes::dump):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildCharacterDataMap):
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::performImport):
(WebCore::StorageAreaSync::sync):

  • storage/StorageMap.cpp:

(WebCore::StorageMap::key):
(WebCore::StorageMap::setItem):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::localStorageNamespace):
(WebCore::StorageNamespaceImpl::copy):
(WebCore::StorageNamespaceImpl::close):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget):
(WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::effectReferences):
(WebCore::SVGFilterBuilder::addBuiltinEffects):

  • svg/properties/SVGAnimatedProperty.h:

(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):

  • svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::addProperties):
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::hasPendingActivity):

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::close):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setRequestHeaderInternal):
(WebCore::XMLHttpRequest::getAllResponseHeaders):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::createFunction):

  • xml/XPathParser.cpp:

(isAxisName):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::xsltParamArrayFromParameterMap):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTProcessor::transformToString):

Source/WebKit/blackberry:

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):

  • WebCoreSupport/NotificationPresenterImpl.cpp:

(WebCore::NotificationPresenterImpl::cancel):
(WebCore::NotificationPresenterImpl::onPermission):
(WebCore::NotificationPresenterImpl::notificationClicked):

  • WebCoreSupport/UserMediaClientImpl.cpp:

(WebCore::UserMediaClientImpl::cancelUserMediaRequest):

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):

  • WebKitSupport/FrameLayers.cpp:

(BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
(BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
(BlackBerry::WebKit::FrameLayers::calculateRootLayer):

Source/WebKit/chromium:

  • src/WebGeolocationPermissionRequestManager.cpp:

(WebGeolocationPermissionRequestManager::remove):

  • src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):

  • src/WebIntent.cpp:

(WebKit::WebIntent::extrasValue):

  • tests/WebSocketExtensionDispatcherTest.cpp:

(WebCore::TEST_F):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):

  • WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::getPluginInfo):

  • ewk/ewk_intent.cpp:

(ewk_intent_extra_get):

Source/WebKit/gtk:

  • WebCoreSupport/PlatformStrategiesGtk.cpp:

(PlatformStrategiesGtk::getPluginInfo):

  • webkit/webkitfavicondatabase.cpp:

(webkitFaviconDatabaseImportFinished):

  • webkit/webkitwebplugin.cpp:

(webkit_web_plugin_get_mimetypes):

Source/WebKit/mac:

  • History/WebHistory.mm:

(-[WebHistoryPrivate removeItemFromDateCaches:]):
(-[WebHistoryPrivate orderedLastVisitedDays]):
(WebHistoryWriter::WebHistoryWriter):

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
(+[WebCoreStatistics javaScriptObjectTypeCounts]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::hostForPlugin):
(WebKit::NetscapePluginHostManager::pluginHostDied):
(WebKit::NetscapePluginHostManager::didCreateWindow):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::pluginHostDied):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
(WebKit::NetscapePluginInstanceProxy::destroy):
(WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason):
(WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView stopTimers]):
(-[WebNetscapePluginView startTimers]):

  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):

  • WebView/WebHTMLView.mm:

(commandNameForSelector):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(extractContentTypeFromPluginVector):

  • Api/qwebplugindatabase.cpp:

(QWebPluginInfo::mimeTypes):

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::getPluginInfo):

Source/WebKit/win:

  • COMPropertyBag.h:

(::Read):
(::GetPropertyInfo):

  • WebCoreStatistics.cpp:

(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::getPluginInfo):

  • WebHistory.cpp:

(WebHistory::removeItemFromDateCaches):

  • WebKitCOMAPI.cpp:

(classFactory):

  • WebKitStatistics.cpp:

(WebKitStatistics::comClassNameCounts):

  • WebNotificationCenter.cpp:

(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::removeObserver):

Source/WebKit/wince:

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::getPluginInfo):

Source/WebKit2:

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SyncMessageState::getOrCreate):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::registerEventSourceHandler):
(WorkQueue::unregisterEventSourceHandler):

  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::unregisterMachPortEventHandler):

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::pluginDestroyed):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

  • Shared/WebPreferencesStore.cpp:

(WebKit::valueForKey):
(WebKit::WebPreferencesStore::getBoolValueForKey):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::decode):

  • Shared/qt/ArgumentCodersQt.cpp:

(CoreIPC::::decode):

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::decode):

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(_Ewk_Back_Forward_List::~_Ewk_Back_Forward_List):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context::~_Ewk_Context):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_priv_loading_resources_clear):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_subresources):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseContainerForall):

  • UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _expectedPreviewCallbackForRect:]):
(pageDidDrawToPDF):
(-[WKPrintingView _drawPreview:]):

  • UIProcess/API/mac/WKView.mm:

(commandNameForSelector):
(-[WKView validateUserInterfaceItem:]):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::updateTile):
(WebKit::CoordinatedBackingStore::texture):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
(WebKit::CoordinatedBackingStore::commitTileOperations):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::LayerTreeRenderer::syncCanvas):
(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::setLayerFilters):
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::assignImageToLayer):

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests):

  • UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit::WebInspectorServer::~WebInspectorServer):
(WebKit::WebInspectorServer::registerPage):

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):

  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:

(WebKit::WebInspectorServer::buildPageList):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):

  • UIProcess/WebContext.cpp:

(WebKit::createDictionaryFromHashMap):

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::didFinishURLImport):

  • UIProcess/WebIntentData.cpp:

(WebKit::WebIntentData::extras):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
(WebKit::WebProcessProxy::addBackForwardItem):
(WebKit::WebProcessProxy::frameCountInPage):

  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:

(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::didReceiveGeolocationPermissionDecision):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):

  • WebProcess/InjectedBundle/InjectedBundleIntent.cpp:

(WebKit::InjectedBundleIntent::extras):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::removeNotificationFromContextMap):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::destroyStream):
(WebKit::NetscapePlugin::unscheduleTimer):
(WebKit::NetscapePlugin::frameDidFinishLoading):
(WebKit::NetscapePlugin::frameDidFail):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::buildHTTPHeaders):
(WebKit::PluginView::~PluginView):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::layerByID):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::removeItem):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::commandNameForSelectorName):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
(WebKit::WebProcess::focusedWebPage):
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::webPageGroup):
(WebKit::fromCountedSetToHashMap):
(WebKit::WebProcess::setTextCheckerState):

Source/WTF:

  • wtf/HashCountedSet.h:

(WTF::::add):
(WTF::::remove):
(WTF::copyToVector):

  • wtf/HashIterators.h:

(WTF::HashTableConstKeysIterator::get):
(WTF::HashTableConstValuesIterator::get):
(WTF::HashTableKeysIterator::get):
(WTF::HashTableValuesIterator::get):

  • wtf/HashMap.h:

(WTF::KeyValuePairKeyExtractor::extract):
(WTF::HashMapValueTraits::isEmptyValue):
(WTF::HashMapTranslator::translate):
(WTF::HashMapTranslatorAdapter::translate):
(WTF::::set):
(WTF::::get):
(WTF::::take):
(WTF::operator==):
(WTF):
(WTF::deleteAllPairSeconds):
(WTF::deleteAllValues):
(WTF::deleteAllPairFirsts):
(WTF::deleteAllKeys):

  • wtf/HashTable.h:

(WTF::hashTableSwap):
(WTF::::checkTableConsistencyExceptSize):

  • wtf/HashTraits.h:

(WTF::KeyValuePair::KeyValuePair):
(KeyValuePair):
(WTF::KeyValuePairHashTraits::constructDeletedValue):
(WTF::KeyValuePairHashTraits::isDeletedValue):

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::addFreeSpace):
(WTF::MetaAllocator::incrementPageOccupancy):
(WTF::MetaAllocator::decrementPageOccupancy):

  • wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::~RefCountedLeakCounter):

  • wtf/RefPtrHashMap.h:

(WTF::::set):
(WTF::::get):
(WTF::::inlineGet):
(WTF::::take):

  • wtf/Spectrum.h:

(WTF::Spectrum::add):
(WTF::Spectrum::get):
(WTF::Spectrum::buildList):

  • wtf/ThreadingPthreads.cpp:

(WTF::identifierByPthreadHandle):

Tools:

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(MockWebSpeechInputController::addMockRecognitionResult):

  • DumpRenderTree/chromium/NotificationPresenter.cpp:

(NotificationPresenter::simulateClick):
(NotificationPresenter::show):

  • DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:

(CppBoundClass::~CppBoundClass):
(CppBoundClass::invoke):
(CppBoundClass::getProperty):
(CppBoundClass::setProperty):
(CppBoundClass::bindCallback):
(CppBoundClass::bindProperty):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(applyFontMap):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printResourceDescription):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(worldIDForWorld):
(TestRunner::evaluateScriptInIsolatedWorld):

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::~AccessibilityController):
(AccessibilityController::winNotificationReceived):

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::descriptionSuitableForTestResult):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(worldIDForWorld):
(TestRunner::evaluateScriptInIsolatedWorld):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::worldIDForWorld):
(WTR::TestRunner::evaluateScriptInIsolatedWorld):

1:46 PM Changeset in webkit [126925] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Spellcheck should be enabled if undefined in content.
https://bugs.webkit.org/show_bug.cgi?id=95139

Currently we only enable spellcheck if it is defined as such in
the web content explicitly.
Making this change to enable by default, and only turn off if it is
explicitly set, or if we expect the field to be a username, email or
url.

Internally reviewed by Mike Fenton.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-08-28
Reviewed by Rob Buis.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::unlockSequenceMap):
(WebKit):
(BlackBerry::WebKit::InputHandler::shouldSpellCheckElement):

  • WebKitSupport/InputHandler.h:

(InputHandler):

1:44 PM Changeset in webkit [126924] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

LLInt should not rely on ordering of global labels
https://bugs.webkit.org/show_bug.cgi?id=95221

Reviewed by Oliver Hunt.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
1:36 PM Changeset in webkit [126923] by pdr@google.com
  • 6 edits
    6 adds
    6 deletes in trunk/LayoutTests

Rebaseline details-nested-2.html and clone-anonymous-block-non-inline-child-crash.html after 126789
https://bugs.webkit.org/show_bug.cgi?id=95226

Reviewed by Abhishek Arya.

  • fast/html/details-nested-2-expected.txt: Added.
  • fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Replaced.
  • platform/chromium-linux/fast/html/details-nested-2-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-nested-2-expected.txt:
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/efl/fast/html/details-nested-2-expected.txt: Removed.
  • platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
  • platform/gtk/fast/html/details-nested-2-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
  • platform/win-future: Added.
  • platform/win-future/fast: Added.
  • platform/win-future/fast/multicol: Added.
  • platform/win-future/fast/multicol/span: Added.
  • platform/win-future/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
1:33 PM Changeset in webkit [126922] by jchaffraix@webkit.org
  • 6 edits
    3 adds in trunk/LayoutTests

Unreviewed rebaseline after r126911.

  • platform/chromium/TestExpectations:

Removed the 3 rebaselined tests.

  • platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
  • platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:
  • platform/chromium-mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
  • platform/chromium-mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png:
  • platform/chromium-mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.

Added new baselines matching the ones landed for mac.

1:19 PM Changeset in webkit [126921] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::logPluginRequest + 183
https://bugs.webkit.org/show_bug.cgi?id=95218

Reviewed by Oliver Hunt.

Crash is within findPluginMIMETypeFromURL, caused by a null-dereference of
page()->pluginData(). Add a null-check and return an empty string.

  • loader/SubframeLoader.cpp:

(WebCore::findPluginMIMETypeFromURL):

1:12 PM Changeset in webkit [126920] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Second build fix to r126909.

Added needed #else clause.

  • WebView/WebView.mm:

(-[WebView _notificationIDForTesting:]):

1:10 PM Changeset in webkit [126919] by Simon Fraser
  • 3 edits
    2 adds in trunk

Regression (r126774): Crash when scrolling after removing sticky element.
https://bugs.webkit.org/show_bug.cgi?id=95174

Reviewed by Abhishek Arya.

Source/WebCore:

RenderBox::willBeDestroyed() needs to check for both fixed and sticky
position to determine whether to remove an object from FrameView's
set of fixed objects.

Test: fast/css/sticky/remove-sticky-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed):

LayoutTests:

Testcase with JS that removes a position:sticky element, then scrolls.

  • fast/css/sticky/remove-sticky-crash-expected.txt: Added.
  • fast/css/sticky/remove-sticky-crash.html: Added.
1:10 PM Changeset in webkit [126918] by ap@apple.com
  • 6 edits in trunk/Source/WebKit2

[WK2] Expose process model as API
https://bugs.webkit.org/show_bug.cgi?id=95228

Reviewed by Jon Honeycutt.

  • UIProcess/API/C/WKAPICast.h: (WebKit::toProcessModel): (WebKit::toAPI): Convert ProcessModel values.
  • UIProcess/API/C/WKContext.cpp: (WKContextSetProcessModel): (WKContextGetProcessModel):
  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::setProcessModel):
  • UIProcess/WebContext.h: Added a setter and a getter. Setting process model is only allowed when there are no processes yet - that's checked with a CRASH to guarantee that clients using production builds of WebKit2 don't misstep.
12:59 PM Changeset in webkit [126917] by wjmaclean@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[unreviewed] Compile fix: windows compiler expects float but find double.

Need to specify a float literal when initialising the highlight animation duration.

  • src/LinkHighlight.cpp:

(WebKit::LinkHighlight::startHighlightAnimation):

12:55 PM Changeset in webkit [126916] by robert@webkit.org
  • 3 edits in trunk/LayoutTests

Fix up ref-tests added in r126911 to make them more port-friendly.

Unreviewed, gardening.

  • fast/css/center-align-absolute-position-inline-block.html:
  • fast/css/center-align-absolute-position.html:
12:50 PM Changeset in webkit [126915] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Build fix to r126909.

Needed ENABLE(NOTIFICATIONS) guards.

  • WebView/WebView.mm:

(-[WebView _notificationIDForTesting:]):

12:41 PM Changeset in webkit [126914] by caio.oliveira@openbossa.org
  • 402 edits in trunk

Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784

Reviewed by Eric Seidel.

Source/JavaScriptCore:

  • API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren):

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyNames):

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::contextData):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::EvalCodeCache::visitAggregate):
(JSC::CodeBlock::nameForRegister):

  • bytecode/JumpTable.h:

(JSC::StringJumpTable::offsetForValue):
(JSC::StringJumpTable::ctiForValue):

  • bytecode/LazyOperandValueProfile.cpp:

(JSC::LazyOperandValueProfileParser::getIfPresent):

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::dump):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitLazyNewFunction):

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • debugger/Debugger.cpp:
  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):

  • dfg/DFGAssemblyHelpers.cpp:

(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):

  • dfg/DFGByteCodeCache.h:

(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):
(JSC::DFG::StructureCheckHoistingPhase::noticeStructureCheck):
(JSC::DFG::StructureCheckHoistingPhase::noticeClobber):

  • heap/Heap.cpp:

(JSC::Heap::markProtectedObjects):

  • heap/Heap.h:

(JSC::Heap::forEachProtectedCell):

  • heap/JITStubRoutineSet.cpp:

(JSC::JITStubRoutineSet::markSlow):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):

  • heap/MarkStack.cpp:

(JSC::MarkStack::internalAppend):

  • heap/Weak.h:

(JSC::weakRemove):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::ctiStub):

  • parser/Parser.cpp:

(JSC::::parseStrictObjectLiteral):

  • profiler/Profile.cpp:

(JSC::functionNameCountPairComparator):
(JSC::Profile::debugPrintDataSampleStyle):

  • runtime/Identifier.cpp:

(JSC::Identifier::add):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::put):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayValueMap::visitChildren):
(JSC::JSArray::enterDictionaryMode):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::setLength):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::checkConsistency):

  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::getOwnPropertyNames):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::invalidateCode):

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::clear):
(JSC::WeakGCMap::set):

  • tools/ProfileTreeNode.h:

(JSC::ProfileTreeNode::sampleChild):
(JSC::ProfileTreeNode::childCount):
(JSC::ProfileTreeNode::dumpInternal):
(JSC::ProfileTreeNode::compareEntries):

Source/WebCore:

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::Watchers::find):
(WebCore::Geolocation::Watchers::remove):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::objectStoreNames):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::metadata):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
(WebCore::IDBFactoryBackendImpl::open):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::objectStoreDeleted):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::dispatchEvent):

  • Modules/webdatabase/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::performOpenAndVerify):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

  • Modules/webdatabase/OriginUsageRecord.cpp:

(WebCore::OriginUsageRecord::diskUsage):

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):

  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

  • Modules/webdatabase/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):
(WebCore::QuotaTracker::updateDatabaseSize):

  • Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketExtensionDeflateFrame::processResponse):

  • Modules/websockets/WebSocketExtensionDispatcher.cpp:

(WebCore::WebSocketExtensionDispatcher::appendAcceptedExtension):

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache):

  • bindings/gobject/DOMObjectCache.cpp:

(WebKit::DOMObjectCache::clearByFrame):

  • bindings/js/DOMObjectHashTableMap.h:

(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::cacheDOMStructure):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::getDOMConstructor):

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::clearScriptObjects):

  • bindings/js/ScriptController.h:

(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::checkForDuplicate):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::GetRawTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::GetRawTemplate):
(WebCore::V8TestEventTarget::GetTemplate):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::GetRawTemplate):
(WebCore::V8TestInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetRawTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetRawTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetRawTemplate):
(WebCore::V8TestNode::GetTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::GetRawTemplate):
(WebCore::V8TestObj::GetTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::deallocate):
(WebCore::DOMWrapperWorld::getOrCreateIsolatedWorld):

  • bindings/v8/NPV8Object.cpp:

(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8DOMMap.h:

(WebCore::WeakReferenceMap::removeIfPresent):
(WebCore::WeakReferenceMap::visit):

  • bindings/v8/V8GCController.cpp:

(WebCore::enumerateGlobalHandles):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::dispose):

  • bindings/v8/npruntime.cpp:
  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • bridge/NP_jsobject.cpp:

(ObjectMap::add):
(ObjectMap::remove):

  • bridge/jni/jsc/JavaClassJSC.cpp:

(JavaClass::~JavaClass):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::WeakMap::set):

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::invalidate):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::counterToCSSValue):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::crossfadeChanged):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::getImage):

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::parsePseudoType):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createFontFamilyValue):
(WebCore::CSSValuePool::createFontFaceValue):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::ruleSetForScope):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAddNamespace):
(WebCore::StyleSheetContents::determineNamespace):

  • dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationScope::MutationAccumulationRouter::childAdded):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::decrementScopingLevel):

  • dom/Document.cpp:

(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::getCSSCanvasElement):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
(WebCore::DocumentMarkerController::showMarkers):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::remove):

  • dom/ElementAttributeData.cpp:

(WebCore::ensureAttrListForElement):

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):

  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::eventTypes):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::nextListener):

  • dom/IdTargetObserverRegistry.cpp:

(WebCore::IdTargetObserverRegistry::addObserver):
(WebCore::IdTargetObserverRegistry::removeObserver):

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryInstrumentation::addInstrumentedMapEntries):
(WebCore::MemoryInstrumentation::addInstrumentedMapValues):

  • dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::clearRareData):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::Node::collectMatchingObserversForMutation):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
(WebCore::NodeListsNodeData::adoptTreeScope):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::adjustMinimumTimerInterval):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCache::add):

  • dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitStringData::create):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

  • editing/mac/AlternativeTextUIController.mm:

(WebCore::AlternativeTextUIController::AlernativeTextContextController::alternativesForContext):

  • html/FormController.cpp:

(WebCore::SavedFormState::serializeTo):
(WebCore::SavedFormState::appendControlState):
(WebCore::SavedFormState::takeControlState):
(WebCore::SavedFormState::getReferencedFilePaths):
(WebCore::FormKeyGenerator::formKey):
(WebCore::FormController::createSavedFormStateMap):
(WebCore::FormController::formElementsState):
(WebCore::FormController::takeStateForFormElement):
(WebCore::FormController::getReferencedFilePaths):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollectionCacheBase::append):

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeAttachments):

  • inspector/CodeGeneratorInspector.py:
  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):

  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptIdFor):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
(WebCore::InjectedScriptManager::releaseObjectGroup):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::commitSelector):
(WebCore::SelectorProfile::commitSelectorTime):
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::didModifyDOMAttr):
(WebCore::InspectorCSSAgent::resetPseudoStates):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::count):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::nodeForId):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::memoryBytesUsedByStorageCache):

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::databaseId):
(WebCore::InspectorDatabaseAgent::findByFileName):
(WebCore::InspectorDatabaseAgent::databaseForId):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

  • inspector/InspectorPageAgent.cpp:

(WebCore::cachedResourcesForFrame):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameDetached):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getProfile):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForHeaders):
(WebCore::InspectorResourceAgent::willSendRequest):

  • inspector/InspectorState.cpp:

(WebCore::InspectorState::getBoolean):
(WebCore::InspectorState::getString):
(WebCore::InspectorState::getLong):
(WebCore::InspectorState::getDouble):
(WebCore::InspectorState::getObject):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::styleWithProperties):
(WebCore::InspectorStyleSheet::inspectorStyleForId):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorObjectBase::get):
(WebCore::InspectorObjectBase::writeJSON):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore::NetworkResourcesData::clear):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isSimpleCrossOriginAccessRequest):
(WebCore::createAccessControlPreflightRequest):

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::getSubresources):
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::servePendingRequests):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::removeResource):
(WebCore::ApplicationCache::clearStorageID):
(WebCore::ApplicationCache::dump):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::startLoadingEntry):
(WebCore::ApplicationCacheGroup::addEntry):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::fillResourceList):

  • loader/appcache/ApplicationCacheResource.cpp:

(WebCore::ApplicationCacheResource::estimatedSizeInStorage):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::empty):
(WebCore::ApplicationCacheStorage::storeCopyOfCache):

  • loader/archive/ArchiveFactory.cpp:

(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::canReuse):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::switchClientsToRevalidatedResource):
(WebCore::CachedResource::updateResponseAfterRevalidation):

  • loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::removeCachedResource):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::reportMemoryUsage):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeResourcesWithOrigin):
(WebCore::MemoryCache::getOriginsWithCache):
(WebCore::MemoryCache::getStatistics):
(WebCore::MemoryCache::reportMemoryUsage):
(WebCore::MemoryCache::setDisabled):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::removeAllIcons):
(WebCore::IconDatabase::iconRecordCountWithData):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScripts):

  • page/PageGroup.cpp:

(WebCore::PageGroup::pageGroup):
(WebCore::PageGroup::closeLocalStorage):
(WebCore::PageGroup::clearLocalStorageForAllOrigins):
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore::PageGroup::syncLocalStorage):
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::urlForBlankFrame):

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

  • page/Settings.cpp:

(WebCore::setGenericFontFamilyMap):
(WebCore::getGenericFontFamilyForScript):

  • page/SpeechInput.cpp:

(WebCore::SpeechInput::registerListener):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::boolFeature):
(WebCore::WindowFeatures::floatFeature):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::numberOfActiveAnimations):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::clearRenderer):
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):
(WebCore::CompositeAnimation::getAnimatedStyle):
(WebCore::CompositeAnimation::setAnimating):
(WebCore::CompositeAnimation::timeToNextService):
(WebCore::CompositeAnimation::getAnimationForProperty):
(WebCore::CompositeAnimation::suspendAnimations):
(WebCore::CompositeAnimation::resumeAnimations):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::CompositeAnimation::isAnimatingProperty):
(WebCore::CompositeAnimation::numberOfActiveAnimations):

  • platform/Language.cpp:

(WebCore::languageDidChange):

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

  • platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore::CookieManager::removeAllCookies):

  • platform/blackberry/CookieMap.cpp:

(WebCore::CookieMap::removeOldestCookie):
(WebCore::CookieMap::getAllChildCookies):

  • platform/cf/BinaryPropertyList.cpp:

(WebCore::BinaryPropertyListPlan::writeIntegerArray):

  • platform/chromium/support/WebHTTPLoadInfo.cpp:

(WebKit::addHeader):

  • platform/chromium/support/WebURLRequest.cpp:

(WebKit::WebURLRequest::visitHTTPHeaderFields):

  • platform/chromium/support/WebURLResponse.cpp:

(WebKit::WebURLResponse::addHTTPHeaderField):
(WebKit::WebURLResponse::visitHTTPHeaderFields):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::unregisterClient):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::getVerticalData):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::treeGlyphPageCount):
(WebCore::GlyphPageTreeNode::pageCount):
(WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
(WebCore::GlyphPageTreeNode::pruneTreeFontData):
(WebCore::GlyphPageTreeNode::pruneCustomFontData):
(WebCore::GlyphPageTreeNode::pruneFontData):
(WebCore::GlyphPageTreeNode::showSubtree):
(showGlyphPageTrees):

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::resizeEdgeTiles):
(WebCore::TiledBackingStore::setKeepRect):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::avfWrapperForCallbackContext):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::bindContentsTexture):

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::textureForColor):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::pauseAnimation):
(WebCore::GraphicsLayerCA::layerDidDisplay):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateTransform):
(WebCore::GraphicsLayerCA::updateChildrenTransform):
(WebCore::GraphicsLayerCA::updateMasksToBounds):
(WebCore::GraphicsLayerCA::updateContentsVisibility):
(WebCore::GraphicsLayerCA::updateContentsOpaque):
(WebCore::GraphicsLayerCA::updateBackfaceVisibility):
(WebCore::GraphicsLayerCA::updateFilters):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsRect):
(WebCore::GraphicsLayerCA::updateMaskLayer):
(WebCore::GraphicsLayerCA::updateLayerAnimations):
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::removeCAAnimationFromLayer):
(WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer):
(WebCore::GraphicsLayerCA::suspendAnimations):
(WebCore::GraphicsLayerCA::resumeAnimations):
(WebCore::GraphicsLayerCA::findOrMakeClone):
(WebCore::GraphicsLayerCA::setOpacityInternal):
(WebCore::GraphicsLayerCA::updateOpacityOnLayer):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::~TileCache):
(WebCore::TileCache::setNeedsDisplay):
(WebCore::TileCache::setScale):
(WebCore::TileCache::setAcceleratesDrawing):
(WebCore::TileCache::setTileDebugBorderWidth):
(WebCore::TileCache::setTileDebugBorderColor):
(WebCore::TileCache::revalidateTiles):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::animationStarted):
(resubmitAllAnimations):
(PlatformCALayer::animationForKey):

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::LookupAltName):
(WebCore::fontContainsCharacter):

  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:

(WebCore::getDerivedFontData):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::invalidateContentRect):
(WebCore::TiledLayerChromium::setTexturePriorities):
(WebCore::TiledLayerChromium::resetUpdateState):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::trackDamageFromLeftoverRects):

  • platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::setBounds):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::stopRateLimiter):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::findRenderPassById):

  • platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::inUseByConsumer):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::deleteOwnedResources):
(WebCore::CCResourceProvider::resourceType):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::destroyChild):
(WebCore::CCResourceProvider::getChildToParentMap):
(WebCore::CCResourceProvider::prepareSendToParent):
(WebCore::CCResourceProvider::prepareSendToChild):
(WebCore::CCResourceProvider::receiveFromChild):
(WebCore::CCResourceProvider::receiveFromParent):
(WebCore::CCResourceProvider::transferResource):
(WebCore::CCResourceProvider::trimMailboxDeque):

  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::getCompiledProgram):
(WebCore::CustomFilterGlobalContext::removeCompiledProgram):

  • platform/graphics/filters/CustomFilterProgram.cpp:

(WebCore::CustomFilterProgram::notifyClients):

  • platform/graphics/harfbuzz/HarfBuzzSkia.cpp:

(WebCore::getCachedHarfbuzzFace):
(WebCore::releaseCachedHarfbuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp:

(WebCore::HarfBuzzNGFace::HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::~HarfBuzzNGFace):

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):

  • platform/graphics/openvg/EGLDisplayOpenVG.cpp:

(WebCore::EGLDisplayOpenVG::~EGLDisplayOpenVG):
(WebCore::EGLDisplayOpenVG::destroySurface):
(WebCore::EGLDisplayOpenVG::contextForSurface):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

  • platform/graphics/wince/FontPlatformData.cpp:

(WebCore::FixedSizeFontData::create):

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::forClipboard):

  • platform/gtk/GtkDragAndDropHelper.cpp:

(WebCore::GtkDragAndDropHelper::handleGetDragData):
(WebCore::GtkDragAndDropHelper::handleDragLeave):
(WebCore::GtkDragAndDropHelper::handleDragMotion):
(WebCore::GtkDragAndDropHelper::handleDragDataReceived):
(WebCore::GtkDragAndDropHelper::handleDragDrop):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::gtkStyleChangedCallback):
(WebCore::getStyleContext):

  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):

  • platform/network/CredentialStorage.cpp:

(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::get):

  • platform/network/MIMEHeader.cpp:

(WebCore::MIMEHeader::parseHeader):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::addHTTPHeaderField):
(WebCore::ResourceRequestBase::addHTTPHeaderFields):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::targetTypeFromMimeType):
(WebCore::ResourceRequest::initializePlatformRequest):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::setClientCertificate):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::toSoupMessage):

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::toSoupMessage):

  • platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::start):

  • platform/qt/RunLoopQt.cpp:

(WebCore::RunLoop::TimerBase::timerFired):

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::scriptNameToCode):
(WebCore::localeToScriptCodeForFontSelection):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::pruneBlacklistedCodecs):
(WebCore::dumpTextEncodingNameMap):

  • platform/text/transcoder/FontTranscoder.cpp:

(WebCore::FontTranscoder::converterType):

  • platform/text/win/TextCodecWin.cpp:

(WebCore::LanguageManager::LanguageManager):
(WebCore::getCodePage):
(WebCore::TextCodecWin::registerExtendedEncodingNames):
(WebCore::TextCodecWin::registerExtendedCodecs):
(WebCore::TextCodecWin::enumerateSupportedEncodings):

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::getDataMapItem):
(WebCore::getClipboardData):
(WebCore::setClipboardData):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::types):

  • platform/win/FileSystemWin.cpp:

(WebCore::cachedStorageDirectory):

  • platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::TimerBase::timerFired):

  • platform/win/WCDataObject.cpp:

(WebCore::WCDataObject::createInstance):

  • platform/wince/MIMETypeRegistryWinCE.cpp:

(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

  • platform/wx/ContextMenuWx.cpp:

(WebCore::ContextMenu::appendItem):

  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::MIMETypeForExtension):
(WebCore::PluginDatabase::remove):

  • plugins/PluginMainThreadScheduler.cpp:

(WebCore::PluginMainThreadScheduler::scheduleCall):
(WebCore::PluginMainThreadScheduler::dispatchCalls):

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::startStream):

  • plugins/blackberry/PluginDataBlackBerry.cpp:

(WebCore::PluginData::initPlugins):

  • plugins/wx/PluginDataWx.cpp:

(WebCore::PluginData::initPlugins):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::unregisterNamedFlowContentNode):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::requiresIdeographicBaseline):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::highQualityRepaintTimerFired):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::performOverlapTests):

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayerFilterInfo::filterInfoForRenderLayer):
(WebCore::RenderLayerFilterInfo::createFilterInfoForRenderLayerIfNeeded):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::RenderNamedFlowThread::pushDependencies):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::cachedCollapsedBorder):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor):

  • rendering/RenderView.cpp:

(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::setSelection):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::resumeWidgetHierarchyUpdates):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/VerticalPositionCache.h:

(WebCore::VerticalPositionCache::get):

  • rendering/WrapShapeInfo.cpp:

(WebCore::WrapShapeInfo::ensureWrapShapeInfoForRenderBlock):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::characterStartsNewTextChunk):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::resourceDestroyed):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::swapItemsInLayoutAttributes):

  • rendering/svg/SVGTextLayoutAttributes.cpp:

(WebCore::SVGTextLayoutAttributes::dump):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildCharacterDataMap):
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::performImport):
(WebCore::StorageAreaSync::sync):

  • storage/StorageMap.cpp:

(WebCore::StorageMap::key):
(WebCore::StorageMap::setItem):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::localStorageNamespace):
(WebCore::StorageNamespaceImpl::copy):
(WebCore::StorageNamespaceImpl::close):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget):
(WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::effectReferences):
(WebCore::SVGFilterBuilder::addBuiltinEffects):

  • svg/properties/SVGAnimatedProperty.h:

(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):

  • svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::addProperties):
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::hasPendingActivity):

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::close):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setRequestHeaderInternal):
(WebCore::XMLHttpRequest::getAllResponseHeaders):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::createFunction):

  • xml/XPathParser.cpp:

(isAxisName):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::xsltParamArrayFromParameterMap):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTProcessor::transformToString):

Source/WebKit/blackberry:

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):

  • WebCoreSupport/NotificationPresenterImpl.cpp:

(WebCore::NotificationPresenterImpl::cancel):
(WebCore::NotificationPresenterImpl::onPermission):
(WebCore::NotificationPresenterImpl::notificationClicked):

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):

  • WebKitSupport/FrameLayers.cpp:

(BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
(BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
(BlackBerry::WebKit::FrameLayers::calculateRootLayer):

  • WebCoreSupport/UserMediaClientImpl.cpp:

(WebCore::UserMediaClientImpl::cancelUserMediaRequest):

Source/WebKit/chromium:

  • src/WebGeolocationPermissionRequestManager.cpp:

(WebGeolocationPermissionRequestManager::remove):

  • src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):

  • src/WebIntent.cpp:

(WebKit::WebIntent::extrasValue):

  • tests/WebSocketExtensionDispatcherTest.cpp:

(WebCore::TEST_F):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):

  • WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::getPluginInfo):

  • ewk/ewk_intent.cpp:

(ewk_intent_extra_get):

Source/WebKit/gtk:

  • WebCoreSupport/PlatformStrategiesGtk.cpp:

(PlatformStrategiesGtk::getPluginInfo):

  • webkit/webkitfavicondatabase.cpp:

(webkitFaviconDatabaseImportFinished):

  • webkit/webkitwebplugin.cpp:

(webkit_web_plugin_get_mimetypes):

Source/WebKit/mac:

  • History/WebHistory.mm:

(-[WebHistoryPrivate removeItemFromDateCaches:]):
(-[WebHistoryPrivate orderedLastVisitedDays]):
(WebHistoryWriter::WebHistoryWriter):

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
(+[WebCoreStatistics javaScriptObjectTypeCounts]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::hostForPlugin):
(WebKit::NetscapePluginHostManager::pluginHostDied):
(WebKit::NetscapePluginHostManager::didCreateWindow):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::pluginHostDied):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
(WebKit::NetscapePluginInstanceProxy::destroy):
(WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason):
(WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView stopTimers]):
(-[WebNetscapePluginView startTimers]):

  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):

  • WebView/WebHTMLView.mm:

(commandNameForSelector):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(extractContentTypeFromPluginVector):

  • Api/qwebplugindatabase.cpp:

(QWebPluginInfo::mimeTypes):

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::getPluginInfo):

Source/WebKit/win:

  • COMPropertyBag.h:

(::Read):
(::GetPropertyInfo):

  • WebCoreStatistics.cpp:

(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::getPluginInfo):

  • WebHistory.cpp:

(WebHistory::removeItemFromDateCaches):

  • WebKitCOMAPI.cpp:

(classFactory):

  • WebKitStatistics.cpp:

(WebKitStatistics::comClassNameCounts):

  • WebNotificationCenter.cpp:

(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::removeObserver):

Source/WebKit/wince:

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::getPluginInfo):

Source/WebKit2:

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SyncMessageState::getOrCreate):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::registerEventSourceHandler):
(WorkQueue::unregisterEventSourceHandler):

  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::unregisterMachPortEventHandler):

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::pluginDestroyed):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

  • Shared/WebPreferencesStore.cpp:

(WebKit::valueForKey):
(WebKit::WebPreferencesStore::getBoolValueForKey):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::decode):

  • Shared/qt/ArgumentCodersQt.cpp:

(CoreIPC::::decode):

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::decode):

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(_Ewk_Back_Forward_List::~_Ewk_Back_Forward_List):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context::~_Ewk_Context):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_priv_loading_resources_clear):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_subresources):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseContainerForall):

  • UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _expectedPreviewCallbackForRect:]):
(pageDidDrawToPDF):
(-[WKPrintingView _drawPreview:]):

  • UIProcess/API/mac/WKView.mm:

(commandNameForSelector):
(-[WKView validateUserInterfaceItem:]):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::updateTile):
(WebKit::CoordinatedBackingStore::texture):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
(WebKit::CoordinatedBackingStore::commitTileOperations):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::LayerTreeRenderer::syncCanvas):
(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::setLayerFilters):
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::assignImageToLayer):

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests):

  • UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit::WebInspectorServer::~WebInspectorServer):
(WebKit::WebInspectorServer::registerPage):

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):

  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:

(WebKit::WebInspectorServer::buildPageList):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):

  • UIProcess/WebContext.cpp:

(WebKit::createDictionaryFromHashMap):

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::didFinishURLImport):

  • UIProcess/WebIntentData.cpp:

(WebKit::WebIntentData::extras):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
(WebKit::WebProcessProxy::addBackForwardItem):
(WebKit::WebProcessProxy::frameCountInPage):

  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:

(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::didReceiveGeolocationPermissionDecision):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):

  • WebProcess/InjectedBundle/InjectedBundleIntent.cpp:

(WebKit::InjectedBundleIntent::extras):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::removeNotificationFromContextMap):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::destroyStream):
(WebKit::NetscapePlugin::unscheduleTimer):
(WebKit::NetscapePlugin::frameDidFinishLoading):
(WebKit::NetscapePlugin::frameDidFail):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::buildHTTPHeaders):
(WebKit::PluginView::~PluginView):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::layerByID):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::removeItem):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::commandNameForSelectorName):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
(WebKit::WebProcess::focusedWebPage):
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::webPageGroup):
(WebKit::fromCountedSetToHashMap):
(WebKit::WebProcess::setTextCheckerState):

Source/WTF:

  • wtf/HashCountedSet.h:

(WTF::::add):
(WTF::::remove):
(WTF::copyToVector):

  • wtf/HashIterators.h:

(WTF::HashTableConstKeysIterator::get):
(WTF::HashTableConstValuesIterator::get):
(WTF::HashTableKeysIterator::get):
(WTF::HashTableValuesIterator::get):

  • wtf/HashMap.h:

(WTF::KeyValuePairKeyExtractor::extract):
(WTF::HashMapValueTraits::isEmptyValue):
(WTF::HashMapTranslator::translate):
(WTF::HashMapTranslatorAdapter::translate):
(WTF::::set):
(WTF::::get):
(WTF::::take):
(WTF::operator==):
(WTF::deleteAllValues):
(WTF::deleteAllKeys):
Remove deleteAllPairFirsts/Seconds.

  • wtf/HashTable.h:

(WTF::hashTableSwap):
(WTF::::checkTableConsistencyExceptSize):

  • wtf/HashTraits.h:

(WTF::KeyValuePair::KeyValuePair):
(KeyValuePair):
(WTF::KeyValuePairHashTraits::constructDeletedValue):
(WTF::KeyValuePairHashTraits::isDeletedValue):

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::addFreeSpace):
(WTF::MetaAllocator::incrementPageOccupancy):
(WTF::MetaAllocator::decrementPageOccupancy):

  • wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::~RefCountedLeakCounter):

  • wtf/RefPtrHashMap.h:

(WTF::::set):
(WTF::::get):
(WTF::::inlineGet):
(WTF::::take):

  • wtf/Spectrum.h:

(WTF::Spectrum::add):
(WTF::Spectrum::get):
(WTF::Spectrum::buildList):

  • wtf/ThreadingPthreads.cpp:

(WTF::identifierByPthreadHandle):

Tools:

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(MockWebSpeechInputController::addMockRecognitionResult):

  • DumpRenderTree/chromium/NotificationPresenter.cpp:

(NotificationPresenter::simulateClick):
(NotificationPresenter::show):

  • DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:

(CppBoundClass::~CppBoundClass):
(CppBoundClass::invoke):
(CppBoundClass::getProperty):
(CppBoundClass::setProperty):
(CppBoundClass::bindCallback):
(CppBoundClass::bindProperty):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(applyFontMap):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printResourceDescription):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(worldIDForWorld):
(TestRunner::evaluateScriptInIsolatedWorld):

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::~AccessibilityController):
(AccessibilityController::winNotificationReceived):

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::descriptionSuitableForTestResult):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(worldIDForWorld):
(TestRunner::evaluateScriptInIsolatedWorld):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::worldIDForWorld):
(WTR::TestRunner::evaluateScriptInIsolatedWorld):

12:32 PM Changeset in webkit [126913] by pdr@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

Rebaseline webgl-repaint for slightly different mac results.

Unreviewed rebaseline of test expectations.

The mac results have a slightly different shade of green but
it is still a passing result.

  • platform/chromium-mac/compositing/webgl/webgl-repaint-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/webgl: Added.
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/webgl/webgl-repaint-expected.png: Added.
12:26 PM Changeset in webkit [126912] by jpfau@apple.com
  • 5 edits
    6 adds in trunk

Make shared workers respect third-party storage blocking setting
https://bugs.webkit.org/show_bug.cgi?id=94559

Reviewed by Adam Barth.

Source/WebCore:

Shared workers can fundamentally leak information between pages in
different contexts if the workers can be accessed from a third-party
context. Thus, if third-party storage blocking is enabled, shared
workers should be disallowed in third-party contexts.

Tests: http/tests/security/cross-origin-shared-worker-allowed.html

http/tests/security/cross-origin-shared-worker.html

  • page/SecurityOrigin.h: Add canAccessSharedWorkers function

(WebCore::SecurityOrigin::canAccessSharedWorkers):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create): Ensure that we can access shared workers before creating the worker.

LayoutTests:

Created tests for accessing shared workers from a third party and first party when third-party blocking is on and off.

  • http/tests/security/cross-origin-shared-worker-allowed-expected.txt: Added.
  • http/tests/security/cross-origin-shared-worker-allowed.html: Added.
  • http/tests/security/cross-origin-shared-worker-expected.txt: Added.
  • http/tests/security/cross-origin-shared-worker.html: Added.
  • http/tests/security/resources/cross-origin-iframe-for-shared-worker.html: Added.
  • http/tests/security/resources/shared-worker.js: Added.

(self.addEventListener):

  • platform/chromium/TestExpectations: Shared workers are not supported in chromium DRT
12:18 PM Changeset in webkit [126911] by robert@webkit.org
  • 18 edits
    4 adds
    10 deletes in trunk

REGRESSION (r94492): Unstable layout of static block inside text-align: center div
https://bugs.webkit.org/show_bug.cgi?id=77754

Reviewed by David Hyatt.

Source/WebCore:

Text-align of 'center' on an out-of-flow element determines its x-position in the line - it
doesn't mean that the element should be centred in the line as though it were a block of text.

This is a partial revert of http://trac.webkit.org/changeset/113584 and a correction to
http://trac.webkit.org/changeset/94492.

Tests: fast/css/center-align-absolute-position-inline-block.html

fast/css/center-align-absolute-position.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutPositionedObjects): Remove an update to the static position when

it depended on the child's width. Reverts code added in r113584.

  • rendering/RenderBlock.h:

(RenderBlock): Remove child parameter from startAlignedOffsetForLine()

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setStaticPositions): ditto
(WebCore::RenderBlock::startAlignedOffsetForLine): No need to account for the child's width when calculating

the offset for the line.

LayoutTests:

  • fast/css/align-positioned-object-on-resize-expected.txt: Removed.
  • fast/css/align-positioned-object-on-resize.html: Removed.
  • fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Removed.
  • fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Removed.
  • fast/css/bug4860-absolute-inline-child-inherits-alignment.html: Removed.

These tests are no longer valid. They expect an out-of-flow block to align with the
center of their parent. The valid behaviour for an out-of-flow element with a center-align
parent is take the center of the parent as their start position. The expected behaviour is
now covered by center-align-absolute-position.html below.

  • fast/css/center-align-absolute-position-expected.html: Added.
  • fast/css/center-align-absolute-position-inline-block-expected.html: Added.
  • fast/css/center-align-absolute-position-inline-block.html: Added.
  • fast/css/center-align-absolute-position.html: Added.
  • fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html:
  • platform/chromium-linux/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:
  • platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png:

This isn't a very helpful test - but note that the alignment of LTR-RTL centers on an axis. The behaviour
now matches FF.

  • platform/chromium-mac/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Removed.
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-win/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Removed.
  • platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
  • platform/chromium-win/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
  • platform/chromium/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Removed.
  • platform/qt/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Removed.

The rebaselined results on each of these now matches FF.

12:18 PM Changeset in webkit [126910] by wjmaclean@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Drastically shorten the link highlight duration.
https://bugs.webkit.org/show_bug.cgi?id=95216

Reviewed by James Robinson.

Parameter change; covered by existing layout tests.

  • src/LinkHighlight.cpp:

(WebKit::LinkHighlight::startHighlightAnimation):

12:08 PM Changeset in webkit [126909] by jonlee@apple.com
  • 36 edits in trunk

Source/WebCore: [Mac] Add SPI to WK1 to retrieve internal IDs for web notifications
https://bugs.webkit.org/show_bug.cgi?id=95099
<rdar://problem/12180186>

Reviewed by Jessie Berlin.

This is work toward providing Mac support for web notifications in DRT and WTR (77969).

Expose functions to convert JSValue to Notification, and to get the NotificationController from a page.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj: Promote NotificationController.h and JSNotification.h to private headers.

Source/WebKit/mac: [Mac] Add SPI to WK1 to retrieve internal IDs for web notifications
https://bugs.webkit.org/show_bug.cgi?id=95099
<rdar://problem/12180186>

Reviewed by Jessie Berlin.

This is work toward providing Mac support for web notifications in DRT and WTR (77969).

Add function to retrieve the internal ID for a notification. This is needed by layout tests to support simulating
a user click on a notification.

  • WebCoreSupport/WebNotificationClient.h:

(WebNotificationClient):

  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::notificationIDForTesting): Converts the JS notification to a WebCore notification, and passes
that to [WebView _notificationIDForTesting:].

  • WebView/WebView.mm:

(-[WebView _notificationIDForTesting:]): Retrieves the notification ID based on the WebCore notification instance.

  • WebView/WebViewPrivate.h:

Tools: Update TestRunner API for web notifications
https://bugs.webkit.org/show_bug.cgi?id=95093
<rdar://problem/12179649>

Reviewed by Jessie Berlin.

This is work toward providing Mac support for web notifications in DRT and WTR (77969).

Some of the legacy APIs are less than ideal, and not tenable with the WTR infrastructure.
This first patch renames the TestRunner calls to use the term "web notifications" instead of
"desktop notifications", deprecates a couple API calls that are not used by anyone, and adds
additional calls that will be used in the tests that test the standard API.

  • DumpRenderTree/TestRunner.h:

(TestRunner): For consistency, rename a couple member variables. Remove unused checkDesktopNotificationPermission()
and areDesktopNotificationPermissionRequestsIgnored(). Remove origin mapping since each port implements its own solution.

  • DumpRenderTree/TestRunner.cpp: Push grantWebNotificationPermission() to individual ports.

(TestRunner::TestRunner):
(ignoreLegacyWebNotificationPermissionRequestsCallback): Renamed.
(simulateLegacyWebNotificationClickCallback): Renamed.
(grantWebNotificationPermissionCallback): Renamed.
(denyWebNotificationPermissionCallback): Added.
(removeAllWebNotificationPermissionsCallback): Added.
(simulateWebNotificationClickCallback): Added.
(TestRunner::staticFunctions):
(TestRunner::ignoreLegacyWebNotificationPermissionRequests):

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner): Added bindings for new APIs.
(DRTTestRunner::grantWebNotificationPermission):
(DRTTestRunner::denyWebNotificationPermission): Stub.
(DRTTestRunner::removeAllWebNotificationPermissions): Stub.
(DRTTestRunner::simulateWebNotificationClick): Stub.
(DRTTestRunner::simulateLegacyWebNotificationClick):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

Added stubs.

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm: Later patch will contain implementation of this API.
  • DumpRenderTree/qt/TestRunnerQt.cpp: Added Qt-based stubs.
  • DumpRenderTree/win/TestRunnerWin.cpp:

LayoutTests: Update TestRunner API for web notifications
https://bugs.webkit.org/show_bug.cgi?id=95093
<rdar://problem/12179649>

Reviewed by Jessie Berlin.

This is work toward providing Mac support for web notifications in DRT and WTR (77969).

Refactor the tests to use the renamed legacy API calls.

  • fast/notifications/notifications-check-permission.html:
  • fast/notifications/notifications-click-event-focus.html:
  • fast/notifications/notifications-click-event.html:
  • fast/notifications/notifications-display-close-events.html:
  • fast/notifications/notifications-document-close-crash.html: Also, convert from Windows to UNIX line endings.
  • fast/notifications/notifications-double-show.html:
  • fast/notifications/notifications-event-stop-propagation.html-disabled:
  • fast/notifications/notifications-multi-events.html-disabled:
  • fast/notifications/notifications-no-icon.html:
  • fast/notifications/notifications-replace.html:
  • fast/notifications/notifications-rtl.html:
  • fast/notifications/notifications-with-permission.html:
  • fast/notifications/notifications-without-permission.html:
  • fast/notifications/resources/notifications-cancel-request-permission.html:
  • platform/qt-5.0-wk2/Skipped:
12:05 PM Changeset in webkit [126908] by dmazzoni@google.com
  • 3 edits
    2 adds in trunk

AX: Should be able to tab to focus a link in a canvas subtree
https://bugs.webkit.org/show_bug.cgi?id=94967

Reviewed by Chris Fleizach.

Source/WebCore:

Skips the hasNonEmptyBoundingBox check in isKeyboardFocusable
when in a canvas subtree.

Test: fast/events/tab-focus-link-in-canvas.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isKeyboardFocusable):

LayoutTests:

Adds a test to make sure you can tab to a link inside a canvas
subtree.

  • fast/events/tab-focus-link-in-canvas-expected.txt: Added.
  • fast/events/tab-focus-link-in-canvas.html: Added.
11:52 AM Changeset in webkit [126907] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

OPENTYPE_VERTICAL support for Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=94822

Patch by Koji Ishii <Koji Ishii> on 2012-08-28
Reviewed by Tony Chang.

To fix bug 51450 - Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows,
this patch adds support of OPENTYPE_VERTICAL feature for Chromium Windows.
Since enabling OPENTYPE_VERTICAL feature would require rather a big number of tests to rebaseline,
the actual fix is separated into this patch, and the feature will be enabled in bug 51450,
so that it is easier to revert on any perf regressions, as suggested by Tony in comment #50 of bug 51450.

All changes in this patch are behind #if ENABLE(OPENTYPE_VERTICAL) and therefore no tests are included in this patch.
All tests in fast/writing-modes currently skipped will be enabled in bug 51450.

  • WebCore.gyp/WebCore.gyp: Added platform/graphics/opentype/OpenType*.
  • WebCore.gypi: Ditto.
  • platform/graphics/FontCache.h: SKia uses uint32_t as FontFileKey.
  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::fill): Replace vertical alternate glyphs if vertical flow.

  • platform/graphics/SimpleFontData.cpp: Added m_verticalData.

(WebCore::SimpleFontData::SimpleFontData):

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::verticalData):
(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawGlyphs): Draw glyphs verticaly if font->verticalData().

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

(WebCore::FontPlatformData::verticalData): Added.
(WebCore):
(WebCore::FontPlatformData::openTypeTable): Added.

  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:

(WebCore):
(FontPlatformData): Added verticalData() and openTypeTable().

11:42 AM Changeset in webkit [126906] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

GCC warning in JSActivation is causing Mac EWS errors
https://bugs.webkit.org/show_bug.cgi?id=95103

Reviewed by Sam Weinig.

Try to fix a strict aliasing violation by using bitwise_cast. The
union in the cast should signal to the compiler that aliasing between
types is happening.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):

11:36 AM Changeset in webkit [126905] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
https://bugs.webkit.org/show_bug.cgi?id=94700

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-08-28
Reviewed by Eric Seidel.

Interrupting download with a timeout would be a possible solution.
I imported the socket module and used the setdefaulttimeout() method.
Fixing it is important, because EWS bots need to be restarted regularly
because of this bug.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._get_browser):
(Bugzilla.setdefaulttimeout):

11:36 AM Changeset in webkit [126904] by roger_fong@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

3 composited-during-animation/compositied-during-transition test results on Windows now match Mac results.
https://bugs.webkit.org/show_bug.cgi?id=95162

Reviewed by Jessie Berlin.

Failing test results previously checked in here: https://bugs.webkit.org/show_bug.cgi?id=88024.
3 of these tests now match Mac test results. Removing failing test results.

  • platform/win/css3/filters/composited-during-animation-expected.txt: Removed.
  • platform/win/css3/filters/composited-during-animation-layertree-expected.txt: Removed.
  • platform/win/css3/filters/composited-during-transition-layertree-expected.txt: Removed.
11:31 AM Changeset in webkit [126903] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Bugs in maintenance of internal state when user decides whether to grant notification permissions
https://bugs.webkit.org/show_bug.cgi?id=95220
<rdar://problem/12189895>

Reviewed by Jessie Berlin.

A couple of the maps maintained by the request manager should have been cleaned up when the user decided on
whether to grant a website permission to post notifications.

Also, the web process' copy of the permissions was not updated appropriately. This meant that in the
permission callback, Notification.permission was not the same value as the permission value included as
the first parameter of the callback.

This first surfaced as part of the work to bring Mac support for web notifications. I have a test that
will check for regressions in this area, once all of that has been checked in (bug 77969).

  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):

11:25 AM Changeset in webkit [126902] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Add header guards to WebTileCacheLayer.h.
https://bugs.webkit.org/show_bug.cgi?id=95171

Reviewed by Simon Hausmann.

Headers love include guards.

  • platform/graphics/ca/mac/WebTileCacheLayer.h:
11:22 AM Changeset in webkit [126901] by danakj@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Be robust to WebCore popping an empty GraphicsContext stack
https://bugs.webkit.org/show_bug.cgi?id=95152

Reviewed by James Robinson.

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::popCanvasLayer):

11:14 AM Changeset in webkit [126900] by pdr@google.com
  • 2 edits in trunk/LayoutTests

Rebaselining chromium-mac test results with scrollbars.

Unreviewed update of test results.

  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
11:11 AM Changeset in webkit [126899] by jonlee@apple.com
  • 9 edits in trunk/Source/WebKit2

[WK2] Add SPI for injected bundle to manually set permissions
https://bugs.webkit.org/show_bug.cgi?id=95127
<rdar://problem/12182635>

Reviewed by Jessie Berlin.

This is work toward providing Mac support for web notifications in DRT and WTR (77969).

Add support functions to WebKit2 which maintain the map of permissions to origins for web notifications.
For WebKit1 the map is managed by DumpRenderTree.

  • WebProcess/InjectedBundle/InjectedBundle.h: Add TestRunner SPI.
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setWebNotificationPermission):
(WebKit::InjectedBundle::removeAllWebNotificationPermissions):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Expose as WK API. Also, rearrange the ordering of the

functions so that it reflects the same order found in InjectedBundle.h.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:
  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::setPermissionLevelForTesting): Manually set the permission
level for an origin.
(WebKit::NotificationPermissionRequestManager::removeAllPermissionsForTesting):

  • WebProcess/Notifications/NotificationPermissionRequestManager.h:

(NotificationPermissionRequestManager):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::removeAllPermissionsForTesting): Clear the permission map.

  • WebProcess/Notifications/WebNotificationManager.h: Promote didUpdateNotificationDecision message as public

function, so that NotificationPermissionRequestManager can update the permission map.

11:09 AM Changeset in webkit [126898] by roger_fong@apple.com
  • 1 edit
    4 deletes in trunk/LayoutTests

Remove Windows specific object-sizing test results.
https://bugs.webkit.org/show_bug.cgi?id=95160

Reviewed by NOBODY (OOPS!).

These test results now match the general LayoutTest results, removing failing platform specific results.

  • platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
11:05 AM Changeset in webkit [126897] by ggaren@apple.com
  • 1 edit
    2 adds in trunk/Source/JavaScriptCore

2012-08-28 Geoffrey Garen <ggaren@apple.com>

Build fix: svn add two files I forgot in my last patch.

11:03 AM Changeset in webkit [126896] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening of the WK2 Debug Bot failing tests
https://bugs.webkit.org/show_bug.cgi?id=95210

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-28

  • platform/efl-wk2/TestExpectations:
10:59 AM Changeset in webkit [126895] by hyatt@apple.com
  • 7 edits in trunk/Source/WebCore

[New Multicolumn] Rename some flow thread methods and region methods/members to make them
more accurate and also change some function signatures so they can be used by RenderMultiColumnSet.
https://bugs.webkit.org/show_bug.cgi?id=95213

Reviewed by Simon Fraser.

Rename regionRect()/setRegionRect()/m_regionRect on RenderRegion to be flowThreadPortionRect instead.
The term regionRect() makes it sound like you're painting a rect in the region's coordinate space,
but regionRect() actually represents the portion of the flow thread in the flow thread's coordinate space
that this region "owns."

Also fix paintIntoRegion and hitTestRegion to take specific flow thread portion rects to paint. This
allows a region set to paint a portion of a portion, i.e., if a multicolumn set owns part of the flow thread
it has to be able to further break up that part into individual columns and issue multiple paint calls, one
for each column.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalTopForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):
(WebCore::RenderFlowThread::regionLogicalHeightForLine):
(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):

  • rendering/RenderFlowThread.h:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::columnCount):
(WebCore::RenderMultiColumnSet::paintColumnContents):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::flowThreadPortionOverflowRect):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::layout):
(WebCore::RenderRegion::offsetFromLogicalTopOfFirstPage):

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::setFlowThreadPortionRect):
(WebCore::RenderRegion::flowThreadPortionRect):
(RenderRegion):

  • rendering/RenderRegionSet.cpp:

(WebCore::RenderRegionSet::expandToEncompassFlowThreadContentsIfNeeded):

10:53 AM Changeset in webkit [126894] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update the TestExpectations to match what the cr-linux-ews
bot sees.

  • platform/chromium/TestExpectations:
10:52 AM Changeset in webkit [126893] by ggaren@apple.com
  • 26 edits
    2 copies in trunk/Source/JavaScriptCore

Refactored and consolidated variable resolution functions
https://bugs.webkit.org/show_bug.cgi?id=95166

Reviewed by Filip Pizlo.

This patch does a few things:

(1) Introduces a new class, JSScope, which is the base class for all
objects that represent a scope in the scope chain.

(2) Refactors and consolidates duplicate implementations of variable
resolution into the JSScope class.

(3) Renames JSStaticScopeObject to JSNameScope because, as distinct from
something like a 'let' scope, JSStaticScopeObject only has storage for a
single name.

These changes makes logical sense to me as-is. I will also use them in an
upcoming optimization.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri: Build!
  • bytecode/CodeBlock.cpp:

(JSC): Build fix for LLInt-only builds.

  • bytecode/GlobalResolveInfo.h:

(GlobalResolveInfo): Use PropertyOffset to be consistent with other parts
of the engine.

  • bytecompiler/NodesCodegen.cpp:
  • dfg/DFGOperations.cpp: Use the shared code in JSScope instead of rolling

our own.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h: Use the shared code in JSScope instead of rolling

our own.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION): Use the shared code in JSScope instead of rolling
our own.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(LLInt): Use the shared code in JSScope instead of rolling our own. Note
that one of these slow paths calls the wrong helper function. I left it
that way to avoid a behavior change in a refactoring patch.

  • parser/Nodes.cpp: Updated for rename.
  • runtime/CommonSlowPaths.h:

(CommonSlowPaths): Removed resolve slow paths because were duplicative.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData): Updated for renames.

  • runtime/JSNameScope.cpp: Copied from Source/JavaScriptCore/runtime/JSStaticScopeObject.cpp.

(JSC):
(JSC::JSNameScope::visitChildren):
(JSC::JSNameScope::toThisObject):
(JSC::JSNameScope::put):
(JSC::JSNameScope::getOwnPropertySlot):

  • runtime/JSNameScope.h: Copied from Source/JavaScriptCore/runtime/JSStaticScopeObject.h.

(JSC):
(JSC::JSNameScope::create):
(JSC::JSNameScope::createStructure):
(JSNameScope):
(JSC::JSNameScope::JSNameScope):
(JSC::JSNameScope::isDynamicScope): Used do-webcore-rename script here.
It is fabulous!

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::isNameScopeObject): More rename.

  • runtime/JSScope.cpp: Added.

(JSC):
(JSC::JSScope::isDynamicScope):
(JSC::JSScope::resolve):
(JSC::JSScope::resolveSkip):
(JSC::JSScope::resolveGlobal):
(JSC::JSScope::resolveGlobalDynamic):
(JSC::JSScope::resolveBase):
(JSC::JSScope::resolveWithBase):
(JSC::JSScope::resolveWithThis):

  • runtime/JSScope.h: Added.

(JSC):
(JSScope):
(JSC::JSScope::JSScope): All the code here is a port from the
Interpreter.cpp implementations of this functionality.

  • runtime/JSStaticScopeObject.cpp: Removed.
  • runtime/JSStaticScopeObject.h: Removed.
  • runtime/JSSymbolTableObject.cpp:

(JSC):

  • runtime/JSSymbolTableObject.h:

(JSSymbolTableObject):

  • runtime/JSType.h: Updated for rename.
  • runtime/Operations.h:

(JSC::resolveBase): Removed because it was duplicative.

10:48 AM Changeset in webkit [126892] by hclam@chromium.org
  • 8 edits in trunk/Source/WebCore

Report frame bytes by platform ImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=94241

Reviewed by James Robinson.

Decoded frame bytes should be reported by the platform ImageSource and
ImageDecoder. BitmapImage used to guess system memory used by a frame
but this is no longer true if a frame is backed by an accelerated
surface or defer-decoded.

Adds ImageSource::frameBytesAtIndex and ImageDecoder::frameBytesAtIndex
such that platform can report memory usage correctly.

No new tests. Refactoring without change of behavior.
Tested on Chromium port with pixel tests without any crash or failure.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
(WebCore::BitmapImage::destroyMetadataAndNotify):
(WebCore::BitmapImage::cacheFrame):
(WebCore::BitmapImage::dataChanged):

  • platform/graphics/BitmapImage.h:

(WebCore::FrameData::FrameData):
(FrameData):
(BitmapImage):

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::frameBytesAtIndex):
(WebCore):

  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::frameBytesAtIndex):
(WebCore):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::frameBytesAtIndex):
(WebCore):

  • platform/image-decoders/ImageDecoder.h:

(ImageDecoder):

10:40 AM Changeset in webkit [126891] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Does not regenerate CSS-related sources when configuration changes
https://bugs.webkit.org/show_bug.cgi?id=94927

Reviewed by Eric Seidel.

In bug 94094 the gtk EWS consistently failed to build the patch. The
reason that happens is the .in files have not been touched, so the CSS
property names and value keywords sources are not regenerated. By
adding an explicit dependency on configure.ac and GNUmakefile.am the
problem is fixed (see bug 82465, attachment 160265).

  • GNUmakefile.am: add explicit dependency from the CSS-related .in files

on configure.ac and WebCore's GNUmakefile.am

9:53 AM Changeset in webkit [126890] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r126813.
http://trac.webkit.org/changeset/126813
https://bugs.webkit.org/show_bug.cgi?id=95211

Broke Chromium debug builds (Requested by beverloo on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-28

  • WebCore.gypi:
9:49 AM Changeset in webkit [126889] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Split some ASSERT(a && b && c) statements into separate lines.
https://bugs.webkit.org/show_bug.cgi?id=95206

Patch by Iain Merrick <husky@chromium.org> on 2012-08-28
Reviewed by James Robinson.

This makes for easier debugging, as you can immediately see which clause
has failed.

No change in behavior, no new tests needed.

  • platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::transferResource):

9:30 AM Changeset in webkit [126888] by zandobersek@gmail.com
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Adding platform-specific baselines required after r126840.

Adding a platform-specific baseline for a window.performance test
and a failure expectation for a Canvas text drawing test, both required
after r126846 when memory cache started being cleared between tests
for the GTK port.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
  • platform/gtk/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
  • platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object-expected.txt: Added.
9:30 AM Changeset in webkit [126887] by annacc@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chrome] Enable track by default.
https://bugs.webkit.org/show_bug.cgi?id=95153

Reviewed by Eric Carlson.

This change turns <track> and TextTrack API on by default for Chrome.

Existing Tests: media/track/*

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

9:02 AM Changeset in webkit [126886] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[GTK] LLint build fails with -g -02
https://bugs.webkit.org/show_bug.cgi?id=90098

Patch by Alban Browaeys <prahal@yahoo.com> on 2012-08-28
Reviewed by Filip Pizlo.

Avoid duplicate offsets for llint, discarding them.

  • offlineasm/offsets.rb:
8:58 AM Changeset in webkit [126885] by anilsson@rim.com
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Checkerboard observed after pinch zooming page with AC layers
https://bugs.webkit.org/show_bug.cgi?id=95192

PR 199177
The LayerTiler was passing transformed ("pixel") coordinates to
GraphicsLayerClient::contentsVisible(), and that method expects
untransformed ("document") coordinates. When the scale was not 1.0,
this was comparing apples and oranges.

Fixed by packaging up the transformation code into a reusable method
and mapping the "pixel" tile rect to "document" coordinates before the
visibility testing.

Reviewed by Antonio Gomes.

Not currently testable by the BlackBerry testing infrastructure.

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::shouldPerformRenderJob):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::mapFromTransformed):
(WebCore):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(LayerWebKitThread):

8:57 AM WebKitGTK/1.8.x edited by dsd@laptop.org
(diff)
8:46 AM Changeset in webkit [126884] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] WebKit EFL updates view on HTTP 204 response
https://bugs.webkit.org/show_bug.cgi?id=95199

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-28
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

Ignore HTTP responses which have status code equal
to 204 (No Content).

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):

Source/WebKit2:

Ignore HTTP responses which have status code equal
to 204 (No Content).

  • UIProcess/API/efl/ewk_view_policy_client.cpp:

(decidePolicyForResponseCallback):

LayoutTests:

Unskip http/tests/navigation/response204.html now
that EFL port properly ignores responses with
HTTP status 204 (No content).

  • platform/efl-wk2/TestExpectations:
  • platform/efl/Skipped:
8:46 AM Changeset in webkit [126883] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Range boundaries should use endOfBlock instead of endOfLine.
https://bugs.webkit.org/show_bug.cgi?id=95135

The original implementation used nextLinePosition to iterate
through the field from the start of each line, and was bounded in
comparison to the endOfLine. This works fine as long as there aren't any
empty lines between paragraphs of text, since these will have
startOfLine == endOfLine and break out.

Also, protect map access with a mutex in case we get a response
before updating the map. Further, we should check the Range pointer
before using it, since its not guaranteed to be valid.

Internally reviewed by Mike Fenton.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-08-28
Reviewed by Antonio Gomes.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spellCheckBlock):

8:44 AM Changeset in webkit [126882] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt][WK1] Gardening after r126873. Skip a newly added failing test.

Patch by János Badics <János Badics> on 2012-08-28
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk1/Skipped:
8:28 AM Changeset in webkit [126881] by commit-queue@webkit.org
  • 11 edits
    5 adds
    7 deletes in trunk/LayoutTests

[EFL] Gardening of failing tests and new baselines
https://bugs.webkit.org/show_bug.cgi?id=95195

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-28

  • platform/efl/TestExpectations:

All CSS Sticky tests after r126774 since we don't support it
yet. WebGL inspector also added to the list after r126857 for the same
reason.

  • platform/efl/fast/html/details-nested-2-expected.txt:
  • platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.

Needs new baselines after r126787.

  • platform/efl/fast/block/float/float-avoidance-expected.png:
  • platform/efl/fast/block/float/float-avoidance-expected.txt:
  • platform/efl/fast/forms/validation-message-appearance-expected.png:
  • platform/efl/fast/forms/validation-message-appearance-expected.txt:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.png:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt:

Updated baselines after r126750.

  • platform/efl/fast/dom/HTMLMeterElement/meter-clone-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-element-crash-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-element-form-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-element-with-child-crash-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-percent-size-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/set-meter-properties-expected.txt: Removed.

Removed since they are the same as global expectations.

  • platform/efl/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
  • platform/efl/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
  • platform/efl/fast/overflow/paged-x-with-column-gap-expected.png: Added.
  • platform/efl/fast/overflow/paged-x-with-column-gap-expected.txt: Added.

New baselines after r126840.

8:24 AM Changeset in webkit [126880] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[EFL] Unskip http/tests/misc/acid3.html test case
https://bugs.webkit.org/show_bug.cgi?id=95201

Unreviewed EFL gardening.

Unskip http/tests/misc/acid3.html since it is
passing consistently for EFL port.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-28

  • platform/efl/Skipped:
  • platform/efl/http/tests/misc/acid3-expected.png: Added.
  • platform/efl/http/tests/misc/acid3-expected.txt: Added.
8:22 AM Changeset in webkit [126879] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Update TestExpectations for fast/canvas/canvas*-shadow.html tests
https://bugs.webkit.org/show_bug.cgi?id=95196

Unreviewed EFL gardening.

Unskip fast/canvas/canvas-strokePath-shadow.html since it is passing
consistently now and already unskip for GTK in r116122.

Move fast/canvas/canvas-fillPath-shadow.html from Skipped file to
TestExpectations.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-28

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
8:12 AM Changeset in webkit [126878] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] One shot drawing synchronization broken
https://bugs.webkit.org/show_bug.cgi?id=95179

Patch by Andrew Lo <anlo@rim.com> on 2012-08-28
Reviewed by Antonio Gomes.
Internally reviewed by Arvid Nilsson.

Make sure no backing store blits happen during one shot drawing
synchronization.
Since we always blit during commit now, make sure we don't blit if
we commit after a render.
We no longer need a deferred blit since we don't commit during renderContents
now. Instead, we only commit & blit once after a full render job.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
(BlackBerry::WebKit::BackingStorePrivate::renderJob):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
(BlackBerry::WebKit::BackingStorePrivate::didRenderContent):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(WebKit):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::renderAllCurrentRegularRenderJobs):
(BlackBerry::WebKit::RenderQueue::renderRegularRenderJob):
(BlackBerry::WebKit::RenderQueue::visibleScrollJobsCompleted):

8:03 AM Changeset in webkit [126877] by zeno.albisser@nokia.com
  • 4 edits in trunk/Source/WebKit2

LayerTreeCoordinatorProxy should use uint64_t for surface key.
https://bugs.webkit.org/show_bug.cgi?id=95175

GraphicsSurface tokens are of type uint64_t.
Therefore LayerTreeCoordinatorProxy must use the same type to
identify a GraphicsSurface/ShareableSurface.

Reviewed by Noam Rosenthal.

  • Shared/ShareableSurface.h:

(WebKit::ShareableSurface::Handle::graphicsSurfaceToken):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

7:51 AM Changeset in webkit [126876] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT
https://bugs.webkit.org/show_bug.cgi?id=95194

Reviewed by Simon Hausmann.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.setup_environ_for_server):

7:41 AM Changeset in webkit [126875] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[BlackBerry] Removing unnecessary include of Class BlackBerryPlatformClient
https://bugs.webkit.org/show_bug.cgi?id=95113

Patch by Parth Patel <parpatel@rim.com> on 2012-08-28
Reviewed by Kentaro Hara.

Refactoring has lead to relocation of many or all methods from Class
BlackBerryPlatformClient to other classes. Some files include
BlackBerryPlatformClient but does not use its instance thus these
includes has to be removed.

Source/WebCore:

No new tests as there are no logical modifications done.

  • platform/network/blackberry/NetworkManager.cpp:

Source/WebKit/blackberry:

  • Api/BackingStore.cpp:
7:18 AM Changeset in webkit [126874] by commit-queue@webkit.org
  • 2 edits
    51 adds in trunk/LayoutTests

[EFL][WK2][WTR] Rebaseline newly added SVG text test cases
https://bugs.webkit.org/show_bug.cgi?id=95190

Unreviewed, EFL rebaselining.

Rebaselined svg text test cases.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-28

  • platform/efl/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacing-stretch-1-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacing-stretch-2-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacing-stretch-3-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacing-stretch-4-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Added.
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Added.
  • platform/efl/svg/text/select-x-list-1-expected.txt: Added.
  • platform/efl/svg/text/select-x-list-2-expected.txt: Added.
  • platform/efl/svg/text/select-x-list-3-expected.txt: Added.
  • platform/efl/svg/text/select-x-list-4-expected.txt: Added.
  • platform/efl/svg/text/select-x-list-with-tspans-1-expected.txt: Added.
  • platform/efl/svg/text/select-x-list-with-tspans-2-expected.txt: Added.
  • platform/efl/svg/text/select-x-list-with-tspans-3-expected.txt: Added.
  • platform/efl/svg/text/select-x-list-with-tspans-4-expected.txt: Added.
  • platform/efl/svg/text/selection-doubleclick-expected.txt: Added.
  • platform/wk2/Skipped:
7:11 AM Changeset in webkit [126873] by Hugo Parente Lima
  • 4 edits
    2 adds in trunk

[WK2] Send click events to WebCore when the user clicked on a non-special node with TOUCH_ADJUSTMENT enabled.
https://bugs.webkit.org/show_bug.cgi?id=91012

Reviewed by Antonio Gomes.

Source/WebCore:

Don't abort the gesture tap handling when the tap hits a non user
interactable node like a text node.

Test: touchadjustment/focusout-on-touch.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureTap):

LayoutTests:

  • touchadjustment/focusout-on-touch-expected.txt: Added.
  • touchadjustment/focusout-on-touch.html: Added.
6:16 AM Changeset in webkit [126872] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Simplify cloning of inline style (below Node.cloneNode)
<http://webkit.org/b/95095>

Reviewed by Eric Seidel.

Just use StylePropertySet::copy() instead of copying the properties and CSS parser mode manually
when cloning an element that has inline style.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):

  • css/StylePropertySet.h:

(StylePropertySet):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::cloneDataFrom):

6:02 AM Changeset in webkit [126871] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] UpdateViewport uses wrong size for frameView
https://bugs.webkit.org/show_bug.cgi?id=95138

Patch by Andy Chen <andchen@rim.com> on 2012-08-28
Reviewed by Antonio Gomes.
Internally reviewed by Jakob Petsovits.

Use actual visible size instead of screen size when updating viewport size,
otherwise, frameView size would be too big.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateViewportSize):

6:00 AM Changeset in webkit [126870] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Pseudo class "active" is broken
https://bugs.webkit.org/show_bug.cgi?id=95142

Patch by Andy Chen <andchen@rim.com> on 2012-08-28
Reviewed by Antonio Gomes.

Check if an element is affected by active rule before cancelling
the touch event.
PR 198544.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::touchEventCancel):

5:50 AM Changeset in webkit [126869] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Datalist RTL test fails on ports that have progress indicator on the range groove
https://bugs.webkit.org/show_bug.cgi?id=95074

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-28
Reviewed by Kent Tamura.

Updated test case to draw a black box covering the range slider. The
ticks can still be seen and hopefully we can keep this test case a ref
test.

  • fast/forms/datalist/input-appearance-range-with-datalist-rtl-expected.html:
  • fast/forms/datalist/input-appearance-range-with-datalist-rtl.html:
  • platform/efl/TestExpectations:
5:25 AM Changeset in webkit [126868] by commit-queue@webkit.org
  • 4 edits
    4 moves in trunk/Source/WebKit

[EFL] Rename knob images to thumb on the default theme
https://bugs.webkit.org/show_bug.cgi?id=95186

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-28
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit:

Updated buildsystem after renaming theme images.

  • PlatformEfl.cmake:

Source/WebKit/efl:

WebKit reefers to these handles as thumb instead of knob. Let's make
it coherent on EFL.

  • DefaultTheme/widget/slider/slider.edc:
  • DefaultTheme/widget/slider/slider_thumb_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_h.png.
  • DefaultTheme/widget/slider/slider_thumb_press_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_press_h.png.
  • DefaultTheme/widget/slider/slider_thumb_press_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_press_v.png.
  • DefaultTheme/widget/slider/slider_thumb_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_v.png.
5:10 AM Changeset in webkit [126867] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-28
Reviewed by Kenneth Rohde Christiansen.

SVG animation pause API has been replaced by manual call.
Therefore, it is not needed anymore.

  • platform/wk2/Skipped:
4:31 AM Changeset in webkit [126866] by ryuan.choi@samsung.com
  • 12 edits
    5 adds in trunk

[EFL][WK2] Implement WebPopupMenuProxyEfl to support <select>
https://bugs.webkit.org/show_bug.cgi?id=88616

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Implemented popup menu proxy and interface for Efl.

Applications should implement popup menu by overriding
smart class function to support select tag.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h: Included ewk_popup_menu_item.h
  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::createPopupMenuProxy):

  • UIProcess/API/efl/ewk_popup_menu_item.cpp: Added.

(_Ewk_Popup_Menu_Item):
(_Ewk_Popup_Menu_Item::_Ewk_Popup_Menu_Item):
(ewk_popup_menu_item_new):
(ewk_popup_menu_item_free):
(ewk_popup_menu_item_type_get): Added API to retrieve type of item.
(ewk_popup_menu_item_text_get): Added API to retrieve text of item.

  • UIProcess/API/efl/ewk_popup_menu_item.h: Added.
  • UIProcess/API/efl/ewk_popup_menu_item_private.h: Added.
  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(ewk_view_popup_menu_request): Added to call popup_menu_show, smart class function.
(ewk_view_popup_menu_close): Added API to call popup_menu_hide, smart class function.
(ewk_view_popup_menu_select): Added API to change selected index.

  • UIProcess/API/efl/ewk_view.h:

Added smart class function for applications to override.

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::EWK2UnitTestBase):
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilLoadFinished):
Extracted from loadUrlSync for tests using ewk_view_html_string_load to
share onLoadFinished.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTest::EWK2UnitTestBase::ewkViewClass):
Added ewkViewClass to test smart methods such as popup_menu_show.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(popup_menu_show):
(TEST_F): Added a test case for ewk_view_popup_menu_select and related codes.

  • UIProcess/efl/WebPopupMenuProxyEfl.cpp: Added.

(WebKit):
(WebKit::WebPopupMenuProxyEfl::WebPopupMenuProxyEfl):
(WebKit::WebPopupMenuProxyEfl::showPopupMenu):
(WebKit::WebPopupMenuProxyEfl::hidePopupMenu):
(WebKit::WebPopupMenuProxyEfl::valueChanged):

  • UIProcess/efl/WebPopupMenuProxyEfl.h: Added.

(WebPopupMenuProxyEfl):
(WebKit::WebPopupMenuProxyEfl::create):

LayoutTests:

  • platform/efl-wk2/TestExpectations: Unskip fast/forms/select/menulist-popup-crash.html
4:13 AM Changeset in webkit [126865] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash in EditingStyle::mergeStyle
https://bugs.webkit.org/show_bug.cgi?id=94740

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2012-08-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

This bug happened when we selected "1<progress><a style>2</a></progress>"
and executed a create link command because

  1. The selection ended at <progress>, not the text node inside it, because <progress> is an atomic node.
  2. We called removeInlineStyle() to remove conflicting styles. Since the selection started at the text node "1" and ended at <progress>, we did not get to remove <a>.
  3. We called fixRangeAndApplyInlineStyle(), which in turn called applyInlineStyleToNodeRange(). This method split the node range into smaller runs. In this case, the run was the whole "1<progress><a style>2</a></progress>".
  4. We called removeStyleFromRunBeforeApplyingStyle(). This method tried to remove <a> by calling removeInlineStyleFromElement() on <a> with extractedStyle = 0. But the method expected that extractedStyle was not null. So, it crashed.

This bug doesn't happen with non-atomic nodes because if <a> is inside a non-atomic
node, <a> will be covered by the selection. Therefore, it will be removed in
step #2 and we will never call removeInlineStyleFromElement() on <a>
again. Thus, the assertion that extractedStyle is not null is reasonable.
Hence, this patch fixes this bug by skipping over atomic nodes when we apply style.

Test: editing/style/apply-style-atomic.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle):
(WebCore::ApplyStyleCommand::removeInlineStyle):

LayoutTests:

  • editing/style/apply-style-atomic-expected.txt: Added.
  • editing/style/apply-style-atomic.html: Added.
4:11 AM Changeset in webkit [126864] by commit-queue@webkit.org
  • 31 edits
    1 add in trunk

[EFL] Range input ignores padding
https://bugs.webkit.org/show_bug.cgi?id=94595

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-28
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

We do not constrain the slider size anymore since it was ignoring the
padding. Also paint the slider thumb on the step it was suppose
to be painted. WebKit will now take care of the positioning of the
thumb, the behavior will be now more coherent with other ports.

As side effect, this patch also fixes setting a slider RTL that wasn't
working before and can be verified by the existing tests. Also
datalist will stop at tick marks.

No new tests, rebaselined the existing ones and unskipping failures.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::edjeGroupFromFormType):
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbSize):
(WebCore::RenderThemeEfl::paintSliderThumb):

  • platform/efl/RenderThemeEfl.h:

Source/WebKit/efl:

Updated default theme to paint the slider thumb in a different step.
This was done by splitting the thumb into a separated group.

  • DefaultTheme/widget/slider/slider.edc:

LayoutTests:

Updated test expectations. We now report the correct thumb size and
respect the defined padding. Two tests were skipped because they
assume a certain thumb size and hit tests fails because of that.

  • platform/efl/TestExpectations:
  • platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.png:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/datalist/range-snap-to-datalist-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.png:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/range/input-appearance-range-expected.png:
  • platform/efl/fast/forms/range/input-appearance-range-expected.txt:
  • platform/efl/fast/forms/range/slider-mouse-events-expected.txt: Added.
  • platform/efl/fast/forms/range/slider-padding-expected.png:
  • platform/efl/fast/forms/range/slider-padding-expected.txt:
  • platform/efl/fast/forms/range/slider-thumb-shared-style-expected.png:
  • platform/efl/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/efl/fast/layers/video-layer-expected.png:
  • platform/efl/fast/layers/video-layer-expected.txt:
  • platform/efl/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/efl/media/audio-controls-rendering-expected.png:
  • platform/efl/media/audio-controls-rendering-expected.txt:
  • platform/efl/media/audio-repaint-expected.txt:
  • platform/efl/media/controls-styling-strict-expected.png:
  • platform/efl/media/controls-styling-strict-expected.txt:
  • platform/efl/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/efl/media/track/track-cue-rendering-horizontal-expected.txt:
  • platform/efl/media/track/track-cue-rendering-vertical-expected.png:
  • platform/efl/media/track/track-cue-rendering-vertical-expected.txt:
3:42 AM Changeset in webkit [126863] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Compile fix: use fabs() instead of abs() for doubles
https://bugs.webkit.org/show_bug.cgi?id=95184

Patch by Kevin Funk <kevin.funk@kdab.com> on 2012-08-28
Reviewed by Kentaro Hara.

Simple compilation fix.

  • platform/ScrollAnimatorNone.cpp:
3:36 AM Changeset in webkit [126862] by commit-queue@webkit.org
  • 85 edits in trunk

REGRESSION (r124512): Failures in MathML Presentation tests on GTK and EFL
https://bugs.webkit.org/show_bug.cgi?id=93073

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-28
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Provide SimpleFontData::platformBoundsForGlyph() implementation
for FreeType backend. This fixes several CSS line-box-contain
test cases as well as the MathML tests for ports using
FreeType.

No new tests, already covered by:
fast/block/lineboxcontain/block-glyphs-replaced.html
fast/block/lineboxcontain/glyphs.html
mathml/*

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):

LayoutTests:

Rebaseline MathML presentation tests and several CSS line-box-contain
tests for EFL and GTK port.

Unskip mathml test cases for both ports now that their result
looks correct.

  • platform/efl/TestExpectations:
  • platform/efl/fast/block/lineboxcontain/block-glyphs-replaced-expected.png:
  • platform/efl/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
  • platform/efl/fast/block/lineboxcontain/glyphs-expected.png:
  • platform/efl/fast/block/lineboxcontain/glyphs-expected.txt:
  • platform/efl/mathml/presentation/attributes-expected.png:
  • platform/efl/mathml/presentation/attributes-expected.txt:
  • platform/efl/mathml/presentation/fenced-expected.png:
  • platform/efl/mathml/presentation/fenced-expected.txt:
  • platform/efl/mathml/presentation/fenced-mi-expected.png:
  • platform/efl/mathml/presentation/fenced-mi-expected.txt:
  • platform/efl/mathml/presentation/fractions-expected.png:
  • platform/efl/mathml/presentation/fractions-expected.txt:
  • platform/efl/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/efl/mathml/presentation/mo-stretch-expected.png:
  • platform/efl/mathml/presentation/mo-stretch-expected.txt:
  • platform/efl/mathml/presentation/mroot-pref-width-expected.png:
  • platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
  • platform/efl/mathml/presentation/roots-expected.png:
  • platform/efl/mathml/presentation/roots-expected.txt:
  • platform/efl/mathml/presentation/row-alignment-expected.png:
  • platform/efl/mathml/presentation/row-alignment-expected.txt:
  • platform/efl/mathml/presentation/sub-expected.png:
  • platform/efl/mathml/presentation/sub-expected.txt:
  • platform/efl/mathml/presentation/subsup-expected.png:
  • platform/efl/mathml/presentation/subsup-expected.txt:
  • platform/efl/mathml/presentation/sup-expected.png:
  • platform/efl/mathml/presentation/sup-expected.txt:
  • platform/efl/mathml/presentation/tables-expected.png:
  • platform/efl/mathml/presentation/tables-expected.txt:
  • platform/efl/mathml/presentation/tokenElements-expected.txt:
  • platform/efl/mathml/presentation/under-expected.png:
  • platform/efl/mathml/presentation/under-expected.txt:
  • platform/efl/mathml/presentation/underover-expected.png:
  • platform/efl/mathml/presentation/underover-expected.txt:
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.png:
  • platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.txt:
  • platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.png:
  • platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
  • platform/gtk/fast/block/lineboxcontain/glyphs-expected.png:
  • platform/gtk/fast/block/lineboxcontain/glyphs-expected.txt:
  • platform/gtk/mathml/presentation/attributes-expected.png:
  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fenced-expected.png:
  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/fenced-mi-expected.png:
  • platform/gtk/mathml/presentation/fenced-mi-expected.txt:
  • platform/gtk/mathml/presentation/fractions-expected.png:
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.png:
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/mo-stretch-expected.png:
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
  • platform/gtk/mathml/presentation/mroot-pref-width-expected.png:
  • platform/gtk/mathml/presentation/mroot-pref-width-expected.txt:
  • platform/gtk/mathml/presentation/over-expected.png:
  • platform/gtk/mathml/presentation/over-expected.txt:
  • platform/gtk/mathml/presentation/roots-expected.png:
  • platform/gtk/mathml/presentation/roots-expected.txt:
  • platform/gtk/mathml/presentation/row-alignment-expected.png:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.png:
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.png:
  • platform/gtk/mathml/presentation/style-expected.txt:
  • platform/gtk/mathml/presentation/sub-expected.png:
  • platform/gtk/mathml/presentation/sub-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.png:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
  • platform/gtk/mathml/presentation/sup-expected.png:
  • platform/gtk/mathml/presentation/sup-expected.txt:
  • platform/gtk/mathml/presentation/tables-expected.png:
  • platform/gtk/mathml/presentation/tables-expected.txt:
  • platform/gtk/mathml/presentation/tokenElements-expected.txt:
  • platform/gtk/mathml/presentation/under-expected.png:
  • platform/gtk/mathml/presentation/under-expected.txt:
  • platform/gtk/mathml/presentation/underover-expected.png:
  • platform/gtk/mathml/presentation/underover-expected.txt:
3:19 AM Changeset in webkit [126861] by abecsi@webkit.org
  • 2 edits in trunk/Tools

[watchlist] Unreviewed, subscribe to Qt bugs.

  • Scripts/webkitpy/common/config/watchlist:
2:51 AM Changeset in webkit [126860] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new failing test.

  • platform/qt/Skipped:
2:41 AM Changeset in webkit [126859] by allan.jensen@nokia.com
  • 60 edits in trunk/Source/WebCore

Rename HitTestPoint and pointInContainer
https://bugs.webkit.org/show_bug.cgi?id=90992

Reviewed by Eric Seidel.

The former hitTestPoint is not just a point. It can be either a point or an area being
hit tested. This patches renames 'point' to 'location' to make it more obvious that the
code does not only handle points.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::nodeAtPoint):

  • rendering/EllipsisBox.h:

(EllipsisBox):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestLocation::~HitTestLocation):
(WebCore::HitTestLocation::operator=):
(WebCore::HitTestLocation::move):
(WebCore::HitTestLocation::intersectsRect):
(WebCore::HitTestLocation::intersects):
(WebCore::HitTestLocation::rectForPoint):
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
(WebCore::HitTestResult::dictationAlternatives):

  • rendering/HitTestResult.h:

(HitTestLocation):
(HitTestResult):
(WebCore::HitTestResult::hitTestLocation):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::nodeAtPoint):

  • rendering/InlineBox.h:

(InlineBox):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):

  • rendering/InlineFlowBox.h:

(InlineFlowBox):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::nodeAtPoint):

  • rendering/InlineTextBox.h:

(InlineTextBox):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isPointInOverflowControl):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::adjustForColumnRect):
(WebCore::RenderBlock::hitTestContents):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::nodeAtPoint):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::nodeAtPoint):

  • rendering/RenderEmbeddedObject.h:

(RenderEmbeddedObject):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestRegion):

  • rendering/RenderFlowThread.h:
  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::nodeAtPoint):

  • rendering/RenderFrameSet.h:

(RenderFrameSet):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::nodeAtPoint):

  • rendering/RenderImage.h:

(RenderImage):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::nodeAtPoint):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderLayer.cpp:

(WebCore::ClipRect::intersects):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestContents):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::hitTestPaginatedChildLayer):
(WebCore::RenderLayer::hitTestChildLayerColumns):

  • rendering/RenderLayer.h:

(ClipRect):
(RenderLayer):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::hitTest):

  • rendering/RenderLineBoxList.h:

(RenderLineBoxList):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::isPointInOverflowControl):
(WebCore::RenderListBox::nodeAtPoint):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::hitTest):
(WebCore::RenderObject::nodeAtPoint):

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::nodeAtPoint):

  • rendering/RenderRegion.h:

(RenderRegion):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::nodeAtPoint):

  • rendering/RenderTable.h:

(RenderTable):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::nodeAtPoint):

  • rendering/RenderTableRow.h:

(RenderTableRow):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):

  • rendering/RenderTableSection.h:

(RenderTableSection):

  • rendering/RenderText.h:
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::nodeAtPoint):

  • rendering/RenderTextControlMultiLine.h:

(RenderTextControlMultiLine):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::nodeAtPoint):

  • rendering/RenderTextControlSingleLine.h:

(RenderTextControlSingleLine):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::nodeAtPoint):

  • rendering/RenderWidget.h:

(RenderWidget):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::nodeAtPoint):

  • rendering/RootInlineBox.h:

(RootInlineBox):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
(WebCore::RenderSVGForeignObject::nodeAtPoint):

  • rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::nodeAtPoint):

  • rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::nodeAtFloatPoint):
(WebCore::RenderSVGText::nodeAtPoint):

  • rendering/svg/RenderSVGText.h:

(RenderSVGText):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::nodeAtPoint):

  • rendering/svg/SVGInlineTextBox.h:

(SVGInlineTextBox):

2:03 AM Changeset in webkit [126858] by Simon Hausmann
  • 6 edits in trunk

[Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
https://bugs.webkit.org/show_bug.cgi?id=95054

Reviewed by Eric Seidel.

Source/WebCore:

Add missing files to the build for CSS_IMAGE_SET.

  • Target.pri:

Tools:

Enable CSS_IMAGE_SET for the Qt build.

  • qmake/mkspecs/features/features.pri:

LayoutTests:

Unskip layout tests for CSS_IMAGE_SET.

  • platform/qt/Skipped:
1:52 AM Changeset in webkit [126857] by pfeldman@chromium.org
  • 13 edits
    1 add in trunk/Source/WebCore

Web Inspector: introduce overlay page and migrate "paused in debugger" to it.
https://bugs.webkit.org/show_bug.cgi?id=95080

Reviewed by Yury Semikhatsky.

Separate page instance is now used to render overlay. Paused in debugger is migrated to the new overlay.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::~InspectorOverlay):
(WebCore):
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::drawOutline):
(WebCore::InspectorOverlay::setPausedInDebuggerMessage):
(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore::InspectorOverlay::drawRectHighlight):
(WebCore::InspectorOverlay::drawOverlayPage):
(WebCore::InspectorOverlay::overlayPage):
(WebCore::InspectorOverlay::evaluateInOverlay):

  • inspector/InspectorOverlay.h:

(InspectorOverlay):

  • inspector/InspectorOverlayPage.html: Added.
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didPaint):

1:42 AM Changeset in webkit [126856] by caseq@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Web Inspector: [WebGL] Add a test to catch new WebGL context states parameters
https://bugs.webkit.org/show_bug.cgi?id=94941

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-28
Reviewed by Kenneth Russell.

Adds a test to catch changes in WebGL API so that we don't miss new WebGL state parameters
and could update WebGL state saving/restoring logic in the InjectedScriptWebGLModuleSource.js

  • inspector/profiler/webgl-profiler-api-changes-expected.txt: Added.
  • inspector/profiler/webgl-profiler-api-changes.html: Added.
1:32 AM Changeset in webkit [126855] by caseq@chromium.org
  • 7 edits
    2 adds in trunk/Source/WebCore

Web Inspector: [WebGL] Simple experimental frontend implementation
https://bugs.webkit.org/show_bug.cgi?id=94696

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-28
Reviewed by Vsevolod Vlasov.

A simple experimental frontend for WebGL instrumentation.
This is a draft unpolished UI just to start with. Iterations on the UI will follow.

  • WebCore.gypi:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/WebGLPanel.js: Added.

(WebInspector.WebGLPanel):
(WebInspector.WebGLPanel.prototype.get toolbarItemLabel):
(WebInspector.WebGLPanel.prototype.get statusBarItems):
(WebInspector.WebGLPanel.prototype.wasShown):
(WebInspector.WebGLPanel.prototype.willHide):
(WebInspector.WebGLPanel.prototype._toggleWebGLInspection):
(WebInspector.WebGLPanel.prototype._onCaptureFrameButtonClick):
(WebInspector.WebGLPanel.prototype._onTraceLogListItemClick):
(WebInspector.WebGLPanel.prototype._onFunctionCallItemClick):
(WebInspector.WebGLManager):
(WebInspector.WebGLManager.prototype.start):
(WebInspector.WebGLManager.prototype.stop):
(WebInspector.WebGLManager.prototype.dropTraceLog):
(WebInspector.WebGLManager.prototype.captureFrame):
(WebInspector.WebGLManager.prototype.getTraceLog):
(WebInspector.WebGLManager.prototype.replayTraceLog):
(WebInspector.WebGLManager.prototype._started):
(WebInspector.WebGLManager.prototype._stopped):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):

  • inspector/front-end/webGLPanel.css: Added.

(.webgl-toggle-status-bar-item .glyph):
(.webgl-toggle-status-bar-item.toggled-on .glyph):
(.webgl-trace-logs-list):
(.webgl-trace-log):
(.webgl-trace-logs-list div, .webgl-trace-log div):
(#webgl-capture-frame-button):
(#webgl-replay-image-container):
(#webgl-replay-image):

12:59 AM Changeset in webkit [126854] by haraken@chromium.org
  • 9 edits
    6 deletes in trunk

Unreviewed, rolling out r126852.
http://trac.webkit.org/changeset/126852
https://bugs.webkit.org/show_bug.cgi?id=94433

broke qt and mac tests

Source/WebCore:

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initScript):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::allowEval):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore):
(WebCore::isAllowedByAllWithCallStack):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::logToConsole):

  • page/ContentSecurityPolicy.h:

(WebCore):

  • page/DOMSecurityPolicy.cpp:

(WebCore::DOMSecurityPolicy::allowsEval):

LayoutTests:

  • http/tests/inspector/csp-injected-content-warning-contains-stacktrace-expected.txt: Removed.
  • http/tests/inspector/csp-injected-content-warning-contains-stacktrace.html: Removed.
  • http/tests/inspector/csp-inline-warning-contains-stacktrace-expected.txt: Removed.
  • http/tests/inspector/csp-inline-warning-contains-stacktrace.html: Removed.
  • http/tests/inspector/resources/csp-inline-test.js: Removed.
  • http/tests/inspector/resources/csp-test.js: Removed.
12:56 AM Changeset in webkit [126853] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests.

  • platform/qt/Skipped:
12:11 AM Changeset in webkit [126852] by commit-queue@webkit.org
  • 9 edits
    6 adds in trunk

Add call stacks to Content Security Policy checks when relevant.
https://bugs.webkit.org/show_bug.cgi?id=94433

Patch by Mike West <mkwst@chromium.org> on 2012-08-28
Reviewed by Adam Barth.

Source/WebCore:

Previously, we generated stack traces only for eval-related CSP
violations. As it turns out, we can call createScriptCallStack from
practically anywhere. This patch takes advantage of that to generate
stack traces whenever a warning is logged to the console. If we're in
a JavaScript stack, brilliant: we get a detailed warning. If not, the
stack trace is empty, and we don't pass it into the console logging
method.

This has the advantage of giving us good developer-facing logging for
any and all violations that result from script-based injection of
resources. Yay!

Tests: http/tests/inspector/csp-injected-content-warning-contains-stacktrace.html

http/tests/inspector/csp-inline-warning-contains-stacktrace.html

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initScript):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

Dropping stack trace from call to ContentSecurityPolicy::allowEval.

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::allowEval):

No longer piping a stack trace through CSPDirectiveList::allowEval
to reportViolation.

(WebCore::ContentSecurityPolicy::didReceiveHeader):

Dropping stack trace from call to ContentSecurityPolicy::allowEval.

(WebCore):
(WebCore::isAllowedByAll):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::logToConsole):

No longer piping a stack trace through ContentSecurityPolicy down to
the point where it would be logged. Instead, we simply generate the
stack trace just before logging it, and only pass it to
addConsoleMessage if it's non-empty.

  • page/ContentSecurityPolicy.h:

(WebCore):

  • page/DOMSecurityPolicy.cpp:

(WebCore::DOMSecurityPolicy::allowsEval):

Dropping stack trace from call to ContentSecurityPolicy::allowEval.

LayoutTests:

  • http/tests/inspector/csp-injected-content-warning-contains-stacktrace-expected.txt: Added.
  • http/tests/inspector/csp-injected-content-warning-contains-stacktrace.html: Added.
  • http/tests/inspector/csp-inline-warning-contains-stacktrace-expected.txt: Added.
  • http/tests/inspector/csp-inline-warning-contains-stacktrace.html: Added.
  • http/tests/inspector/resources/csp-inline-test.js: Added.

(thisTest):

  • http/tests/inspector/resources/csp-test.js: Added.

(test.addMessage):
(test):

12:01 AM Changeset in webkit [126851] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: persist the state of glue records to parents button of Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=95091

Reviewed by Vsevolod Vlasov.

Add a setting for "Glue records" button on the timeline, use it to persist the state of the button.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createStatusBarItems.get this):
(WebInspector.TimelinePanel.prototype._createStatusBarItems):

Aug 27, 2012:

11:58 PM Changeset in webkit [126850] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Skipping the tests in fast/css/sticky. CSS Sticky Position
feature is not yet enabled on the GTK port.

  • platform/gtk/TestExpectations:
11:51 PM Changeset in webkit [126849] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Gardening after r126789. Update expectations and skip a test
because of disabled SHADOW_DOM feature.

Patch by János Badics <János Badics> on 2012-08-27
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
  • platform/qt/fast/html/details-nested-2-expected.txt:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
11:48 PM Changeset in webkit [126848] by Csaba Osztrogonác
  • 4 edits in trunk

[Qt] Enable CSS sticky position
https://bugs.webkit.org/show_bug.cgi?id=95172

Reviewed by Simon Hausmann.

Tools:

  • qmake/mkspecs/features/features.pri:

LayoutTests:

  • platform/qt/Skipped: Unskip a now passing test, skip still failing sticky tests.
11:41 PM Changeset in webkit [126847] by kinuko@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: Add delete button to FileSystemView
https://bugs.webkit.org/show_bug.cgi?id=93940

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-27
Reviewed by Vsevolod Vlasov.

Adding status bar button to allow user to delete entries in FileSystem
for debugging use.

Source/WebCore:

Test: http/tests/inspector/filesystem/delete-entry.html

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype.requestFileContent):
(WebInspector.FileSystemModel.prototype.deleteEntry.hookFileSystemDeletion):
(WebInspector.FileSystemModel.prototype.deleteEntry):
(WebInspector.FileSystemModel.prototype._removeFileSystem):
(WebInspector.FileSystemModel.Entry.prototype.deleteEntry):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototype.deleteEntry.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.deleteEntry):
(WebInspector.FileSystemRequestManager.prototype._deletionCompleted):
(WebInspector.FileSystemDispatcher.prototype.deletionCompleted):

  • inspector/front-end/FileSystemView.js:

(WebInspector.FileSystemView):
(WebInspector.FileSystemView.prototype.get statusBarItems):
(WebInspector.FileSystemView.prototype._refresh):
(WebInspector.FileSystemView.prototype._confirmDelete):
(WebInspector.FileSystemView.prototype._delete):
(WebInspector.FileSystemView.EntryTreeElement.prototype.deleteEntry):
(WebInspector.FileSystemView.EntryTreeElement.prototype._deletionCompleted):

LayoutTests:

  • http/tests/inspector/filesystem/delete-entry-expected.txt: Added.
  • http/tests/inspector/filesystem/delete-entry.html: Added.
11:33 PM Changeset in webkit [126846] by zandobersek@gmail.com
  • 5 edits in trunk

[GTK] Memory cache should be cleared in between test runs
https://bugs.webkit.org/show_bug.cgi?id=95105

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add a DumpRenderTreeSupportGtk helper method that clears the
memory cache when called.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::clearMemoryCache):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Call the new DumpRenderTreeSupportGtk helper method after every test
to clear the memory cache.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(runTest):

11:29 PM Changeset in webkit [126845] by zandobersek@gmail.com
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining two tests after r126789.

Skipping one FileSystem API test that was added in r126785.

Momentarily suppressing all test failures in fast/css/sticky
without proper bug handle.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/html/details-nested-2-expected.txt:
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
11:28 PM Changeset in webkit [126844] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Fix PageClientImpl layer violation
https://bugs.webkit.org/show_bug.cgi?id=94906

Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-27
Reviewed by Gyuyoung Kim.

Given WK2 hierarchy, current PageClientImpl has violated API layer by having WebPageProxy.
Subsequently, it has been given WebContext, static singleton object, in its argument unnecessarily.
Therefore, this patch moved WebPageProxy from PageClientImpl to Ewk_View_Private_Data.
Plus, WebContext was removed from PageClientImpl since it is not needed anymore.
As a result, EFL has same form of PageClientImpl with other ports, i.e. gtk+ and mac.
From API point of view, nothing has been changed because all things done locally.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::createDrawingAreaProxy):

  • UIProcess/API/efl/PageClientImpl.h:

(WebKit::PageClientImpl::create):
(PageClientImpl):

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_smart_calculate):
(_ewk_view_smart_color_set):
(_ewk_view_initialize):
(ewk_view_uri_update):
(ewk_view_uri_set):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_title_get):
(ewk_view_load_progress_get):
(ewk_view_scale_set):
(ewk_view_scale_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
(ewk_view_theme_set):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_html_string_load):
(ewk_view_page_get):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):

11:13 PM Changeset in webkit [126843] by yosin@chromium.org
  • 2 edits
    13 adds in trunk/LayoutTests

[Tests] Using ref image instead ref HTML for fast/forms/time-multiple-fields/time-multiple-fields-appearance-{basic,pseudo-element}.html
https://bugs.webkit.org/show_bug.cgi?id=95055

Unreviewed. Rebaseline for multiple fields time input UI of Chromium-Mac and Chromium-Win.

  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • platform/chromium/TestExpectations:
10:41 PM Changeset in webkit [126842] by yosin@chromium.org
  • 12 edits in trunk/Source/WebCore

[ShadowDOM] Shadow elements in the input element should be focusable.
https://bugs.webkit.org/show_bug.cgi?id=95169

Reviewed by Kent Tamura.

This patch introduces new virtual function HTMLElement::hasCustomFocusLogic()
to allow input type implementations to use shadow element with focus
navigation.

No new tests. This patch doesn't change behavior.

(WebCore::HTMLElement::hasCustomFocusLogic): Added to return false as
default value.

  • html/HTMLElement.h:

(HTMLElement): Added a declaration of hasCustomFocusLogic().

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::hasCustomFocusLogic): Added to call InputType::hasCustomFocusLogic(),

  • html/HTMLInputElement.h:

(HTMLInputElement): Added a declaration of hasCustomFocusLogic().

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::hasCustomFocusLogic): Added to return true for "audio" and "video" elements.

  • html/HTMLMediaElement.h:

(HTMLMediaElement): Add a declaration of hasCustomFocusLogic()

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::hasCustomFocusLogic): Added to return true.

  • html/HTMLTextAreaElement.h:

(HTMLTextAreaElement): Add a declaration of hasCustomFocusLogic().

  • page/FocusController.cpp:

(WebCore::hasCustomFocusLogic): Changed to call HTMLElement::hasCustomFocusLogic()
rather than checking tag names.

  • html/InputType.cpp:

(WebCore::InputType::hasCustomFocusLogic): Added to return true as default value.

  • html/InputType.h:

(InputType): Added a declaration of hasCustomFocusLogic().

10:15 PM Changeset in webkit [126841] by commit-queue@webkit.org
  • 5 edits
    1 delete in trunk/Source/WebKit/chromium

[Chromium] Remove stub for WebView::getTouchHighlightQuads()
https://bugs.webkit.org/show_bug.cgi?id=95164

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-08-27
Reviewed by Adam Barth.

Reverts https://bugs.webkit.org/show_bug.cgi?id=92997
We're uploading a new implementation that no longer uses this API.
See https://bugs.webkit.org/show_bug.cgi?id=94182

  • WebKit.gyp:
  • public/WebTouchCandidatesInfo.h: Removed.
  • public/WebView.h:

(WebKit):

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

(WebViewImpl):

9:26 PM Changeset in webkit [126840] by Beth Dakin
  • 6 edits
    6 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=94848
When paged-x/y is specified on the root, columnGap is ignored, and garbage pixels
are likely

Source/WebCore:

Reviewed by Dan Bernstein.

We used to call setPagination() from applyOverflowToViewport(), but that is too
late. We want to setPagination() before we actually lay anything out so that all
of the styles (including columnGap!) will be properly set on the RenderView.

No longer handle pagination here since we take care of it in
applyPaginationToViewport()

  • page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):

New function to call setPagination(). This function gets the appropriate renderer
and uses its RenderStyle to determine if pagination should be set.
(WebCore::FrameView::applyPaginationToViewport):
(WebCore):

Call applyPaginationToViewport() before the call to updateStyleIfNeeded().
(WebCore::FrameView::layout):

This code was meant to prevent garbage pixels in column gaps for pagination on the
RenderView, but paintContents() does not always get called when we paint into
tiles, so I moved this code to RenderView.
(WebCore::FrameView::paintContents):

  • page/FrameView.h:

(FrameView):

The code from RenderView::paintContents() to prevent garbage pixels is moved here.

  • rendering/RenderView.cpp:

(WebCore::RenderView::paint):

LayoutTests:

Reviewed by Dan Bernsetin.

New tests.

  • fast/overflow/paged-x-div-with-column-gap.html: Added.
  • fast/overflow/paged-x-with-column-gap.html: Added.
  • platform/mac/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
  • platform/mac/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
  • platform/mac/fast/overflow/paged-x-with-column-gap-expected.png: Added.
  • platform/mac/fast/overflow/paged-x-with-column-gap-expected.txt: Added.

Updated results needed for Chromium.

  • platform/chromium/TestExpectations:
9:20 PM Changeset in webkit [126839] by tkent@chromium.org
  • 5 edits
    3 adds in trunk

REGRESSION(r109480): Form state for iframe content is not restored
https://bugs.webkit.org/show_bug.cgi?id=90870

Reviewed by Jochen Eisinger.

Source/WebCore:

Since r109480, we have restored form state only for documents
loaded by FrameLoader::loadItem(). However we should restore form
state for documents in sub-frames of documents loaded by
FrameLoader::loadItem().

Test: fast/loader/form-state-restore-with-frames.html

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::isAncestorOf):
Added. A function to search descendants for the specified
HistoryItem. This is used by isAssociatedToRequestedHistoryItem().

  • history/HistoryItem.h:

(HistoryItem): Declare isAncestorOf().

  • loader/HistoryController.cpp:

(WebCore::HistoryController::saveDocumentState):
Don't save form state for detached document.
This is needed because saveDocumentState() is called twice; before
document detach and after document detach. We need to avoid the
latter call because formElementsState() for a detached document
produces an empty state.
(WebCore::isAssociatedToRequestedHistoryItem):
Added. This function checks the current HistoryItem is associated
to the HistoryItem specified to FrameLoader::loadItem().
(WebCore::HistoryController::restoreDocumentState):
Uses isAssociatedToRequestedHistoryItem().

LayoutTests:

  • fast/loader/form-state-restore-with-frames.html: Added.
  • fast/loader/form-state-restore-with-frames-expected.txt: Added.
  • fast/loader/resources/form-state-restore-with-frames-1.html: Added.
8:39 PM Changeset in webkit [126838] by vollick@chromium.org
  • 8 edits in trunk/Source

[chromium] Should accelerate rotations of >= 180 degrees
https://bugs.webkit.org/show_bug.cgi?id=94860

Reviewed by James Robinson.

Source/Platform:

When generalizing the keyframe interpolation, it became useful to append an identity transform operation,
and to ask a WebTransformOperations object if it isIdentity().

  • chromium/public/WebTransformOperations.h:

(WebTransformOperations):

Source/WebCore:

WebTransformOperation now stores enough information to interpolate
without resorting to WebTransformationMatrix::blend which is both
expensive, and in the case of big rotations, error prone. For example,
we now store the axis and angle for rotations, so if two rotations are
interpolated, and they are about the same axis, we can simply
interpolate the angles.

Unit tests:

WebTransformOperationTest.transformTypesAreUnique
WebTransformOperationTest.matchTypesSameLength
WebTransformOperationTest.identityAlwaysMatches
WebTransformOperationTest.largeRotationsWithSameAxis
WebTransformOperationTest.largeRotationsWithSameAxisInDifferentDirection
WebTransformOperationTest.largeRotationsWithDifferentAxes
WebTransformOperationTest.blendRotationFromIdentity
WebTransformOperationTest.blendTranslationFromIdentity
WebTransformOperationTest.blendScaleFromIdentity
WebTransformOperationTest.blendSkewFromIdentity
WebTransformOperationTest.blendPerspectiveFromIdentity
WebTransformOperationTest.blendRotationToIdentity
WebTransformOperationTest.blendTranslationToIdentity
WebTransformOperationTest.blendScaleToIdentity
WebTransformOperationTest.blendSkewToIdentity
WebTransformOperationTest.blendPerspectiveToIdentity
AnimationTranslationUtilTest.createTransformAnimationWithBigRotation
AnimationTranslationUtilTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList

  • platform/chromium/support/WebTransformOperations.cpp:

(std):
(WebKit::WebTransformOperation::WebTransformOperation):
(WebTransformOperation):

Added x y z and angle.

(WebKit::WebTransformOperation::isIdentity):

Returns true if this->matrix.isIdentity()

(WebKit::isIdentity):

Returns true if the argument is null or ->isIdentity()

(WebKit):
(WebKit::shareSameAxis):

A helper function that determines if two transform operations
share the same axis. Also returns the axis and 'from' angle
to use in the interpolation (in case the axes point in different
directions).

(WebKit::blendDoubles):

Linearly interpolates doubles.

(WebKit::blendTransformOperations):

Blends two WebTransformOperation objects.

(WebKit::WebTransformOperations::blend):

Blends two WebTransformOperations objects, taking special care
when either isIdentity().

(WebKit::WebTransformOperations::matchesTypes):

Was changed to reflect the fact that identity transform operations
match anything.

(WebKit::WebTransformOperations::appendTranslate):
(WebKit::WebTransformOperations::appendRotate):
(WebKit::WebTransformOperations::appendScale):
(WebKit::WebTransformOperations::appendSkew):
(WebKit::WebTransformOperations::appendPerspective):
(WebKit::WebTransformOperations::appendIdentity):

The 'append' functions all populate the new members in
WebTransformOperation.

(WebKit::WebTransformOperations::isIdentity):

Returns false iff any of its transform operations !isIdentity().

  • platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::toWebTransformOperations):
(WebCore::WebTransformAnimationCurve):

Removed the >= 180 degree restriction.

Source/WebKit/chromium:

Added new unit tests:

WebTransformOperationTest.transformTypesAreUnique
WebTransformOperationTest.matchTypesSameLength
WebTransformOperationTest.identityAlwaysMatches
WebTransformOperationTest.largeRotationsWithSameAxis
WebTransformOperationTest.largeRotationsWithSameAxisInDifferentDirection
WebTransformOperationTest.largeRotationsWithDifferentAxes
WebTransformOperationTest.blendRotationFromIdentity
WebTransformOperationTest.blendTranslationFromIdentity
WebTransformOperationTest.blendScaleFromIdentity
WebTransformOperationTest.blendSkewFromIdentity
WebTransformOperationTest.blendPerspectiveFromIdentity
WebTransformOperationTest.blendRotationToIdentity
WebTransformOperationTest.blendTranslationToIdentity
WebTransformOperationTest.blendScaleToIdentity
WebTransformOperationTest.blendSkewToIdentity
WebTransformOperationTest.blendPerspectiveToIdentity
AnimationTranslationUtilTest.createTransformAnimationWithBigRotation
AnimationTranslationUtilTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList

  • tests/AnimationTranslationUtilTest.cpp:

(WebKit::TEST):

  • tests/WebTransformOperationsTest.cpp:

(TEST):
(getIdentityOperations):

7:39 PM Changeset in webkit [126837] by tkent@chromium.org
  • 400 edits in trunk

Unreviewed, rolling out r126836.
http://trac.webkit.org/changeset/126836
https://bugs.webkit.org/show_bug.cgi?id=95163

Broke all Apple ports, EFL, and Qt. (Requested by tkent on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-27

Source/JavaScriptCore:

  • API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren):

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyNames):

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::contextData):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::EvalCodeCache::visitAggregate):
(JSC::CodeBlock::nameForRegister):

  • bytecode/JumpTable.h:

(JSC::StringJumpTable::offsetForValue):
(JSC::StringJumpTable::ctiForValue):

  • bytecode/LazyOperandValueProfile.cpp:

(JSC::LazyOperandValueProfileParser::getIfPresent):

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::dump):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitLazyNewFunction):

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • debugger/Debugger.cpp:
  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):

  • dfg/DFGAssemblyHelpers.cpp:

(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):

  • dfg/DFGByteCodeCache.h:

(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):
(JSC::DFG::StructureCheckHoistingPhase::noticeStructureCheck):
(JSC::DFG::StructureCheckHoistingPhase::noticeClobber):

  • heap/Heap.cpp:

(JSC::Heap::markProtectedObjects):

  • heap/Heap.h:

(JSC::Heap::forEachProtectedCell):

  • heap/JITStubRoutineSet.cpp:

(JSC::JITStubRoutineSet::markSlow):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):

  • heap/MarkStack.cpp:

(JSC::MarkStack::internalAppend):

  • heap/Weak.h:

(JSC::weakRemove):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::ctiStub):

  • parser/Parser.cpp:

(JSC::::parseStrictObjectLiteral):

  • profiler/Profile.cpp:

(JSC::functionNameCountPairComparator):
(JSC::Profile::debugPrintDataSampleStyle):

  • runtime/Identifier.cpp:

(JSC::Identifier::add):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::put):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayValueMap::visitChildren):
(JSC::JSArray::enterDictionaryMode):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::setLength):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::checkConsistency):

  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::getOwnPropertyNames):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::invalidateCode):

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::clear):
(JSC::WeakGCMap::set):

  • tools/ProfileTreeNode.h:

(JSC::ProfileTreeNode::sampleChild):
(JSC::ProfileTreeNode::childCount):
(JSC::ProfileTreeNode::dumpInternal):
(JSC::ProfileTreeNode::compareEntries):

Source/WebCore:

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::Watchers::find):
(WebCore::Geolocation::Watchers::remove):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::objectStoreNames):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::metadata):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
(WebCore::IDBFactoryBackendImpl::open):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::objectStoreDeleted):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::dispatchEvent):

  • Modules/webdatabase/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::performOpenAndVerify):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

  • Modules/webdatabase/OriginUsageRecord.cpp:

(WebCore::OriginUsageRecord::diskUsage):

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):

  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

  • Modules/webdatabase/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):
(WebCore::QuotaTracker::updateDatabaseSize):

  • Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketExtensionDeflateFrame::processResponse):

  • Modules/websockets/WebSocketExtensionDispatcher.cpp:

(WebCore::WebSocketExtensionDispatcher::appendAcceptedExtension):

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache):

  • bindings/gobject/DOMObjectCache.cpp:

(WebKit::DOMObjectCache::clearByFrame):

  • bindings/js/DOMObjectHashTableMap.h:

(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::cacheDOMStructure):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::getDOMConstructor):

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::clearScriptObjects):

  • bindings/js/ScriptController.h:

(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::checkForDuplicate):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::GetRawTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::GetRawTemplate):
(WebCore::V8TestEventTarget::GetTemplate):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::GetRawTemplate):
(WebCore::V8TestInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetRawTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetRawTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetRawTemplate):
(WebCore::V8TestNode::GetTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::GetRawTemplate):
(WebCore::V8TestObj::GetTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::deallocate):
(WebCore::DOMWrapperWorld::getOrCreateIsolatedWorld):

  • bindings/v8/NPV8Object.cpp:

(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8DOMMap.h:

(WebCore::WeakReferenceMap::removeIfPresent):
(WebCore::WeakReferenceMap::visit):

  • bindings/v8/V8GCController.cpp:

(WebCore::enumerateGlobalHandles):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::dispose):

  • bindings/v8/npruntime.cpp:
  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • bridge/NP_jsobject.cpp:

(ObjectMap::add):
(ObjectMap::remove):

  • bridge/jni/jsc/JavaClassJSC.cpp:

(JavaClass::~JavaClass):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::WeakMap::set):

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::invalidate):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::counterToCSSValue):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::crossfadeChanged):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::getImage):

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::parsePseudoType):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createFontFamilyValue):
(WebCore::CSSValuePool::createFontFaceValue):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::ruleSetForScope):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAddNamespace):
(WebCore::StyleSheetContents::determineNamespace):

  • dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationScope::MutationAccumulationRouter::childAdded):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::decrementScopingLevel):

  • dom/Document.cpp:

(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::getCSSCanvasElement):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
(WebCore::DocumentMarkerController::showMarkers):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::remove):

  • dom/ElementAttributeData.cpp:

(WebCore::ensureAttrListForElement):

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):

  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::eventTypes):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::nextListener):

  • dom/IdTargetObserverRegistry.cpp:

(WebCore::IdTargetObserverRegistry::addObserver):
(WebCore::IdTargetObserverRegistry::removeObserver):

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryInstrumentation::addInstrumentedMapEntries):
(WebCore::MemoryInstrumentation::addInstrumentedMapValues):

  • dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::clearRareData):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::Node::collectMatchingObserversForMutation):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
(WebCore::NodeListsNodeData::adoptTreeScope):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::adjustMinimumTimerInterval):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCache::add):

  • dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitStringData::create):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

  • editing/mac/AlternativeTextUIController.mm:

(WebCore::AlternativeTextUIController::AlernativeTextContextController::alternativesForContext):

  • html/FormController.cpp:

(WebCore::SavedFormState::serializeTo):
(WebCore::SavedFormState::appendControlState):
(WebCore::SavedFormState::takeControlState):
(WebCore::SavedFormState::getReferencedFilePaths):
(WebCore::FormKeyGenerator::formKey):
(WebCore::FormController::createSavedFormStateMap):
(WebCore::FormController::formElementsState):
(WebCore::FormController::takeStateForFormElement):
(WebCore::FormController::getReferencedFilePaths):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollectionCacheBase::append):

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeAttachments):

  • inspector/CodeGeneratorInspector.py:
  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):

  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptIdFor):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
(WebCore::InjectedScriptManager::releaseObjectGroup):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::commitSelector):
(WebCore::SelectorProfile::commitSelectorTime):
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::didModifyDOMAttr):
(WebCore::InspectorCSSAgent::resetPseudoStates):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::count):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::nodeForId):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::memoryBytesUsedByStorageCache):

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::databaseId):
(WebCore::InspectorDatabaseAgent::findByFileName):
(WebCore::InspectorDatabaseAgent::databaseForId):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

  • inspector/InspectorPageAgent.cpp:

(WebCore::cachedResourcesForFrame):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameDetached):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getProfile):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForHeaders):
(WebCore::InspectorResourceAgent::willSendRequest):

  • inspector/InspectorState.cpp:

(WebCore::InspectorState::getBoolean):
(WebCore::InspectorState::getString):
(WebCore::InspectorState::getLong):
(WebCore::InspectorState::getDouble):
(WebCore::InspectorState::getObject):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::styleWithProperties):
(WebCore::InspectorStyleSheet::inspectorStyleForId):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorObjectBase::get):
(WebCore::InspectorObjectBase::writeJSON):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore::NetworkResourcesData::clear):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isSimpleCrossOriginAccessRequest):
(WebCore::createAccessControlPreflightRequest):

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::getSubresources):
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::servePendingRequests):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::removeResource):
(WebCore::ApplicationCache::clearStorageID):
(WebCore::ApplicationCache::dump):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::startLoadingEntry):
(WebCore::ApplicationCacheGroup::addEntry):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::fillResourceList):

  • loader/appcache/ApplicationCacheResource.cpp:

(WebCore::ApplicationCacheResource::estimatedSizeInStorage):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::empty):
(WebCore::ApplicationCacheStorage::storeCopyOfCache):

  • loader/archive/ArchiveFactory.cpp:

(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::canReuse):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::switchClientsToRevalidatedResource):
(WebCore::CachedResource::updateResponseAfterRevalidation):

  • loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::removeCachedResource):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::reportMemoryUsage):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeResourcesWithOrigin):
(WebCore::MemoryCache::getOriginsWithCache):
(WebCore::MemoryCache::getStatistics):
(WebCore::MemoryCache::reportMemoryUsage):
(WebCore::MemoryCache::setDisabled):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::removeAllIcons):
(WebCore::IconDatabase::iconRecordCountWithData):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScripts):

  • page/PageGroup.cpp:

(WebCore::PageGroup::pageGroup):
(WebCore::PageGroup::closeLocalStorage):
(WebCore::PageGroup::clearLocalStorageForAllOrigins):
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore::PageGroup::syncLocalStorage):
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::urlForBlankFrame):

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

  • page/Settings.cpp:

(WebCore::setGenericFontFamilyMap):
(WebCore::getGenericFontFamilyForScript):

  • page/SpeechInput.cpp:

(WebCore::SpeechInput::registerListener):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::boolFeature):
(WebCore::WindowFeatures::floatFeature):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::numberOfActiveAnimations):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::clearRenderer):
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):
(WebCore::CompositeAnimation::getAnimatedStyle):
(WebCore::CompositeAnimation::setAnimating):
(WebCore::CompositeAnimation::timeToNextService):
(WebCore::CompositeAnimation::getAnimationForProperty):
(WebCore::CompositeAnimation::suspendAnimations):
(WebCore::CompositeAnimation::resumeAnimations):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::CompositeAnimation::isAnimatingProperty):
(WebCore::CompositeAnimation::numberOfActiveAnimations):

  • platform/Language.cpp:

(WebCore::languageDidChange):

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

  • platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore::CookieManager::removeAllCookies):

  • platform/blackberry/CookieMap.cpp:

(WebCore::CookieMap::removeOldestCookie):
(WebCore::CookieMap::getAllChildCookies):

  • platform/cf/BinaryPropertyList.cpp:

(WebCore::BinaryPropertyListPlan::writeIntegerArray):

  • platform/chromium/support/WebHTTPLoadInfo.cpp:

(WebKit::addHeader):

  • platform/chromium/support/WebURLRequest.cpp:

(WebKit::WebURLRequest::visitHTTPHeaderFields):

  • platform/chromium/support/WebURLResponse.cpp:

(WebKit::WebURLResponse::addHTTPHeaderField):
(WebKit::WebURLResponse::visitHTTPHeaderFields):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::unregisterClient):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::treeGlyphPageCount):
(WebCore::GlyphPageTreeNode::pageCount):
(WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
(WebCore::GlyphPageTreeNode::pruneTreeFontData):
(WebCore::GlyphPageTreeNode::pruneCustomFontData):
(WebCore::GlyphPageTreeNode::pruneFontData):
(WebCore::GlyphPageTreeNode::showSubtree):
(showGlyphPageTrees):

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::resizeEdgeTiles):
(WebCore::TiledBackingStore::setKeepRect):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::avfWrapperForCallbackContext):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::bindContentsTexture):

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::textureForColor):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::pauseAnimation):
(WebCore::GraphicsLayerCA::layerDidDisplay):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateTransform):
(WebCore::GraphicsLayerCA::updateChildrenTransform):
(WebCore::GraphicsLayerCA::updateMasksToBounds):
(WebCore::GraphicsLayerCA::updateContentsVisibility):
(WebCore::GraphicsLayerCA::updateContentsOpaque):
(WebCore::GraphicsLayerCA::updateBackfaceVisibility):
(WebCore::GraphicsLayerCA::updateFilters):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsRect):
(WebCore::GraphicsLayerCA::updateMaskLayer):
(WebCore::GraphicsLayerCA::updateLayerAnimations):
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::removeCAAnimationFromLayer):
(WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer):
(WebCore::GraphicsLayerCA::suspendAnimations):
(WebCore::GraphicsLayerCA::resumeAnimations):
(WebCore::GraphicsLayerCA::findOrMakeClone):
(WebCore::GraphicsLayerCA::setOpacityInternal):
(WebCore::GraphicsLayerCA::updateOpacityOnLayer):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplay):
(WebCore::TileCache::setScale):
(WebCore::TileCache::setAcceleratesDrawing):
(WebCore::TileCache::setTileDebugBorderWidth):
(WebCore::TileCache::setTileDebugBorderColor):
(WebCore::TileCache::revalidateTiles):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::animationStarted):
(resubmitAllAnimations):
(PlatformCALayer::animationForKey):

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::LookupAltName):
(WebCore::fontContainsCharacter):

  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:

(WebCore::getDerivedFontData):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::invalidateContentRect):
(WebCore::TiledLayerChromium::setTexturePriorities):
(WebCore::TiledLayerChromium::resetUpdateState):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::trackDamageFromLeftoverRects):

  • platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::setBounds):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::stopRateLimiter):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::findRenderPassById):

  • platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::inUseByConsumer):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::deleteOwnedResources):
(WebCore::CCResourceProvider::resourceType):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::destroyChild):
(WebCore::CCResourceProvider::getChildToParentMap):
(WebCore::CCResourceProvider::prepareSendToParent):
(WebCore::CCResourceProvider::prepareSendToChild):
(WebCore::CCResourceProvider::receiveFromChild):
(WebCore::CCResourceProvider::receiveFromParent):
(WebCore::CCResourceProvider::transferResource):
(WebCore::CCResourceProvider::trimMailboxDeque):

  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::getCompiledProgram):

  • platform/graphics/filters/CustomFilterProgram.cpp:

(WebCore::CustomFilterProgram::notifyClients):

  • platform/graphics/harfbuzz/HarfBuzzSkia.cpp:

(WebCore::getCachedHarfbuzzFace):
(WebCore::releaseCachedHarfbuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp:

(WebCore::HarfBuzzNGFace::HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::~HarfBuzzNGFace):

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):

  • platform/graphics/openvg/EGLDisplayOpenVG.cpp:

(WebCore::EGLDisplayOpenVG::~EGLDisplayOpenVG):
(WebCore::EGLDisplayOpenVG::destroySurface):
(WebCore::EGLDisplayOpenVG::contextForSurface):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

  • platform/graphics/wince/FontPlatformData.cpp:

(WebCore::FixedSizeFontData::create):

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::forClipboard):

  • platform/gtk/GtkDragAndDropHelper.cpp:

(WebCore::GtkDragAndDropHelper::handleGetDragData):
(WebCore::GtkDragAndDropHelper::handleDragLeave):
(WebCore::GtkDragAndDropHelper::handleDragMotion):
(WebCore::GtkDragAndDropHelper::handleDragDataReceived):
(WebCore::GtkDragAndDropHelper::handleDragDrop):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::gtkStyleChangedCallback):
(WebCore::getStyleContext):

  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):

  • platform/network/CredentialStorage.cpp:

(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::get):

  • platform/network/MIMEHeader.cpp:

(WebCore::MIMEHeader::parseHeader):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::addHTTPHeaderField):
(WebCore::ResourceRequestBase::addHTTPHeaderFields):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::targetTypeFromMimeType):
(WebCore::ResourceRequest::initializePlatformRequest):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::setClientCertificate):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::toSoupMessage):

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::toSoupMessage):

  • platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::start):

  • platform/qt/RunLoopQt.cpp:

(WebCore::RunLoop::TimerBase::timerFired):

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::scriptNameToCode):
(WebCore::localeToScriptCodeForFontSelection):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::pruneBlacklistedCodecs):
(WebCore::dumpTextEncodingNameMap):

  • platform/text/transcoder/FontTranscoder.cpp:

(WebCore::FontTranscoder::converterType):

  • platform/text/win/TextCodecWin.cpp:

(WebCore::LanguageManager::LanguageManager):
(WebCore::getCodePage):
(WebCore::TextCodecWin::registerExtendedEncodingNames):
(WebCore::TextCodecWin::registerExtendedCodecs):
(WebCore::TextCodecWin::enumerateSupportedEncodings):

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::getDataMapItem):
(WebCore::getClipboardData):
(WebCore::setClipboardData):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::types):

  • platform/win/FileSystemWin.cpp:

(WebCore::cachedStorageDirectory):

  • platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::TimerBase::timerFired):

  • platform/win/WCDataObject.cpp:

(WebCore::WCDataObject::createInstance):

  • platform/wince/MIMETypeRegistryWinCE.cpp:

(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

  • platform/wx/ContextMenuWx.cpp:

(WebCore::ContextMenu::appendItem):

  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::MIMETypeForExtension):
(WebCore::PluginDatabase::remove):

  • plugins/PluginMainThreadScheduler.cpp:

(WebCore::PluginMainThreadScheduler::scheduleCall):
(WebCore::PluginMainThreadScheduler::dispatchCalls):

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::startStream):

  • plugins/blackberry/PluginDataBlackBerry.cpp:

(WebCore::PluginData::initPlugins):

  • plugins/wx/PluginDataWx.cpp:

(WebCore::PluginData::initPlugins):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::unregisterNamedFlowContentNode):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::requiresIdeographicBaseline):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::highQualityRepaintTimerFired):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::performOverlapTests):

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayerFilterInfo::filterInfoForRenderLayer):
(WebCore::RenderLayerFilterInfo::createFilterInfoForRenderLayerIfNeeded):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::RenderNamedFlowThread::pushDependencies):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::cachedCollapsedBorder):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor):

  • rendering/RenderView.cpp:

(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::setSelection):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::resumeWidgetHierarchyUpdates):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/VerticalPositionCache.h:

(WebCore::VerticalPositionCache::get):

  • rendering/WrapShapeInfo.cpp:

(WebCore::WrapShapeInfo::ensureWrapShapeInfoForRenderBlock):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::characterStartsNewTextChunk):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::resourceDestroyed):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::swapItemsInLayoutAttributes):

  • rendering/svg/SVGTextLayoutAttributes.cpp:

(WebCore::SVGTextLayoutAttributes::dump):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildCharacterDataMap):
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::performImport):
(WebCore::StorageAreaSync::sync):

  • storage/StorageMap.cpp:

(WebCore::StorageMap::key):
(WebCore::StorageMap::setItem):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::localStorageNamespace):
(WebCore::StorageNamespaceImpl::copy):
(WebCore::StorageNamespaceImpl::close):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget):
(WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::effectReferences):
(WebCore::SVGFilterBuilder::addBuiltinEffects):

  • svg/properties/SVGAnimatedProperty.h:

(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):

  • svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::addProperties):
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::hasPendingActivity):

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::close):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setRequestHeaderInternal):
(WebCore::XMLHttpRequest::getAllResponseHeaders):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::createFunction):

  • xml/XPathParser.cpp:

(isAxisName):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::xsltParamArrayFromParameterMap):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTProcessor::transformToString):

Source/WebKit/blackberry:

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):

  • WebCoreSupport/NotificationPresenterImpl.cpp:

(WebCore::NotificationPresenterImpl::cancel):
(WebCore::NotificationPresenterImpl::onPermission):
(WebCore::NotificationPresenterImpl::notificationClicked):

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):

  • WebKitSupport/FrameLayers.cpp:

(BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
(BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
(BlackBerry::WebKit::FrameLayers::calculateRootLayer):

Source/WebKit/chromium:

  • src/WebGeolocationPermissionRequestManager.cpp:

(WebGeolocationPermissionRequestManager::remove):

  • src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):

  • src/WebIntent.cpp:

(WebKit::WebIntent::extrasValue):

  • tests/WebSocketExtensionDispatcherTest.cpp:

(WebCore::TEST_F):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):

  • WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::getPluginInfo):

  • ewk/ewk_intent.cpp:

(ewk_intent_extra_get):

Source/WebKit/gtk:

  • WebCoreSupport/PlatformStrategiesGtk.cpp:

(PlatformStrategiesGtk::getPluginInfo):

  • webkit/webkitfavicondatabase.cpp:

(webkitFaviconDatabaseImportFinished):

  • webkit/webkitwebplugin.cpp:

(webkit_web_plugin_get_mimetypes):

Source/WebKit/mac:

  • History/WebHistory.mm:

(-[WebHistoryPrivate removeItemFromDateCaches:]):
(-[WebHistoryPrivate orderedLastVisitedDays]):
(WebHistoryWriter::WebHistoryWriter):

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
(+[WebCoreStatistics javaScriptObjectTypeCounts]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::hostForPlugin):
(WebKit::NetscapePluginHostManager::pluginHostDied):
(WebKit::NetscapePluginHostManager::didCreateWindow):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::pluginHostDied):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
(WebKit::NetscapePluginInstanceProxy::destroy):
(WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason):
(WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView stopTimers]):
(-[WebNetscapePluginView startTimers]):

  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):

  • WebView/WebHTMLView.mm:

(commandNameForSelector):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(extractContentTypeFromPluginVector):

  • Api/qwebplugindatabase.cpp:

(QWebPluginInfo::mimeTypes):

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::getPluginInfo):

Source/WebKit/win:

  • COMPropertyBag.h:

(::Read):
(::GetPropertyInfo):

  • WebCoreStatistics.cpp:

(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::getPluginInfo):

  • WebHistory.cpp:

(WebHistory::removeItemFromDateCaches):

  • WebKitCOMAPI.cpp:

(classFactory):

  • WebKitStatistics.cpp:

(WebKitStatistics::comClassNameCounts):

  • WebNotificationCenter.cpp:

(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::removeObserver):

Source/WebKit/wince:

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::getPluginInfo):

Source/WebKit2:

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SyncMessageState::getOrCreate):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::registerEventSourceHandler):
(WorkQueue::unregisterEventSourceHandler):

  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::unregisterMachPortEventHandler):

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::pluginDestroyed):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

  • Shared/WebPreferencesStore.cpp:

(WebKit::valueForKey):
(WebKit::WebPreferencesStore::getBoolValueForKey):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::decode):

  • Shared/qt/ArgumentCodersQt.cpp:

(CoreIPC::::decode):

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::decode):

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(_Ewk_Back_Forward_List::~_Ewk_Back_Forward_List):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context::~_Ewk_Context):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_priv_loading_resources_clear):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_subresources):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseContainerForall):

  • UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _expectedPreviewCallbackForRect:]):
(pageDidDrawToPDF):
(-[WKPrintingView _drawPreview:]):

  • UIProcess/API/mac/WKView.mm:

(commandNameForSelector):
(-[WKView validateUserInterfaceItem:]):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::updateTile):
(WebKit::CoordinatedBackingStore::texture):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
(WebKit::CoordinatedBackingStore::commitTileOperations):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::LayerTreeRenderer::syncCanvas):
(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::setLayerFilters):
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::assignImageToLayer):

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests):

  • UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit::WebInspectorServer::~WebInspectorServer):
(WebKit::WebInspectorServer::registerPage):

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):

  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:

(WebKit::WebInspectorServer::buildPageList):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):

  • UIProcess/WebContext.cpp:

(WebKit::createDictionaryFromHashMap):

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::didFinishURLImport):

  • UIProcess/WebIntentData.cpp:

(WebKit::WebIntentData::extras):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
(WebKit::WebProcessProxy::addBackForwardItem):
(WebKit::WebProcessProxy::frameCountInPage):

  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:

(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::didReceiveGeolocationPermissionDecision):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):

  • WebProcess/InjectedBundle/InjectedBundleIntent.cpp:

(WebKit::InjectedBundleIntent::extras):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::removeNotificationFromContextMap):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::destroyStream):
(WebKit::NetscapePlugin::unscheduleTimer):
(WebKit::NetscapePlugin::frameDidFinishLoading):
(WebKit::NetscapePlugin::frameDidFail):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::buildHTTPHeaders):
(WebKit::PluginView::~PluginView):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::layerByID):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::removeItem):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::commandNameForSelectorName):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
(WebKit::WebProcess::focusedWebPage):
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::webPageGroup):
(WebKit::fromCountedSetToHashMap):
(WebKit::WebProcess::setTextCheckerState):

Source/WTF:

  • wtf/HashCountedSet.h:

(WTF::::add):
(WTF::::remove):
(WTF::copyToVector):

  • wtf/HashIterators.h:

(WTF::HashTableConstKeysIterator::get):
(WTF::HashTableConstValuesIterator::get):
(WTF::HashTableValuesIterator::get):

  • wtf/HashMap.h:

(WTF::KeyValuePairKeyExtractor::extract):
(WTF::HashMapValueTraits::isEmptyValue):
(WTF::HashMapTranslator::translate):
(WTF::HashMapTranslatorAdapter::translate):
(WTF::::set):
(WTF::::get):
(WTF::::take):
(WTF::operator==):
(WTF):
(WTF::deleteAllPairSeconds):
(WTF::deleteAllValues):
(WTF::deleteAllPairFirsts):
(WTF::deleteAllKeys):

  • wtf/HashTable.h:

(WTF::hashTableSwap):
(WTF::::checkTableConsistencyExceptSize):

  • wtf/HashTraits.h:

(WTF::KeyValuePair::KeyValuePair):
(KeyValuePair):
(WTF::KeyValuePairHashTraits::constructDeletedValue):
(WTF::KeyValuePairHashTraits::isDeletedValue):

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::addFreeSpace):
(WTF::MetaAllocator::incrementPageOccupancy):
(WTF::MetaAllocator::decrementPageOccupancy):

  • wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::~RefCountedLeakCounter):

  • wtf/RefPtrHashMap.h:

(WTF::::set):
(WTF::::get):
(WTF::::inlineGet):
(WTF::::take):

  • wtf/Spectrum.h:

(WTF::Spectrum::add):
(WTF::Spectrum::get):
(WTF::Spectrum::buildList):

  • wtf/ThreadingPthreads.cpp:

(WTF::identifierByPthreadHandle):

Tools:

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(MockWebSpeechInputController::addMockRecognitionResult):

  • DumpRenderTree/chromium/NotificationPresenter.cpp:

(NotificationPresenter::simulateClick):
(NotificationPresenter::show):

  • DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:

(CppBoundClass::~CppBoundClass):
(CppBoundClass::invoke):
(CppBoundClass::getProperty):
(CppBoundClass::setProperty):
(CppBoundClass::bindCallback):
(CppBoundClass::bindProperty):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(applyFontMap):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printResourceDescription):

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::~AccessibilityController):
(AccessibilityController::winNotificationReceived):

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::descriptionSuitableForTestResult):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(worldIDForWorld):
(TestRunner::evaluateScriptInIsolatedWorld):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::worldIDForWorld):
(WTR::TestRunner::evaluateScriptInIsolatedWorld):

7:14 PM Changeset in webkit [126836] by caio.oliveira@openbossa.org
  • 400 edits in trunk

Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784

Reviewed by Eric Seidel.

Source/JavaScriptCore:

  • API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren):

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyNames):

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::contextData):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::EvalCodeCache::visitAggregate):
(JSC::CodeBlock::nameForRegister):

  • bytecode/JumpTable.h:

(JSC::StringJumpTable::offsetForValue):
(JSC::StringJumpTable::ctiForValue):

  • bytecode/LazyOperandValueProfile.cpp:

(JSC::LazyOperandValueProfileParser::getIfPresent):

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::dump):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitLazyNewFunction):

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • debugger/Debugger.cpp:
  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):

  • dfg/DFGAssemblyHelpers.cpp:

(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):

  • dfg/DFGByteCodeCache.h:

(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):
(JSC::DFG::StructureCheckHoistingPhase::noticeStructureCheck):
(JSC::DFG::StructureCheckHoistingPhase::noticeClobber):

  • heap/Heap.cpp:

(JSC::Heap::markProtectedObjects):

  • heap/Heap.h:

(JSC::Heap::forEachProtectedCell):

  • heap/JITStubRoutineSet.cpp:

(JSC::JITStubRoutineSet::markSlow):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):

  • heap/MarkStack.cpp:

(JSC::MarkStack::internalAppend):

  • heap/Weak.h:

(JSC::weakRemove):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::ctiStub):

  • parser/Parser.cpp:

(JSC::::parseStrictObjectLiteral):

  • profiler/Profile.cpp:

(JSC::functionNameCountPairComparator):
(JSC::Profile::debugPrintDataSampleStyle):

  • runtime/Identifier.cpp:

(JSC::Identifier::add):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::put):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayValueMap::visitChildren):
(JSC::JSArray::enterDictionaryMode):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::setLength):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::checkConsistency):

  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::getOwnPropertyNames):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::invalidateCode):

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::clear):
(JSC::WeakGCMap::set):

  • tools/ProfileTreeNode.h:

(JSC::ProfileTreeNode::sampleChild):
(JSC::ProfileTreeNode::childCount):
(JSC::ProfileTreeNode::dumpInternal):
(JSC::ProfileTreeNode::compareEntries):

Source/WebCore:

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::Watchers::find):
(WebCore::Geolocation::Watchers::remove):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::objectStoreNames):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::metadata):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
(WebCore::IDBFactoryBackendImpl::open):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::objectStoreDeleted):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::dispatchEvent):

  • Modules/webdatabase/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::performOpenAndVerify):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

  • Modules/webdatabase/OriginUsageRecord.cpp:

(WebCore::OriginUsageRecord::diskUsage):

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):

  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

  • Modules/webdatabase/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):
(WebCore::QuotaTracker::updateDatabaseSize):

  • Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketExtensionDeflateFrame::processResponse):

  • Modules/websockets/WebSocketExtensionDispatcher.cpp:

(WebCore::WebSocketExtensionDispatcher::appendAcceptedExtension):

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache):

  • bindings/gobject/DOMObjectCache.cpp:

(WebKit::DOMObjectCache::clearByFrame):

  • bindings/js/DOMObjectHashTableMap.h:

(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::cacheDOMStructure):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::getDOMConstructor):

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::clearScriptObjects):

  • bindings/js/ScriptController.h:

(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::checkForDuplicate):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::GetRawTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::GetRawTemplate):
(WebCore::V8TestEventTarget::GetTemplate):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::GetRawTemplate):
(WebCore::V8TestInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetRawTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetRawTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetRawTemplate):
(WebCore::V8TestNode::GetTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::GetRawTemplate):
(WebCore::V8TestObj::GetTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::deallocate):
(WebCore::DOMWrapperWorld::getOrCreateIsolatedWorld):

  • bindings/v8/NPV8Object.cpp:

(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8DOMMap.h:

(WebCore::WeakReferenceMap::removeIfPresent):
(WebCore::WeakReferenceMap::visit):

  • bindings/v8/V8GCController.cpp:

(WebCore::enumerateGlobalHandles):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::dispose):

  • bindings/v8/npruntime.cpp:
  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • bridge/NP_jsobject.cpp:

(ObjectMap::add):
(ObjectMap::remove):

  • bridge/jni/jsc/JavaClassJSC.cpp:

(JavaClass::~JavaClass):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::WeakMap::set):

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::invalidate):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::counterToCSSValue):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::crossfadeChanged):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::getImage):

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::parsePseudoType):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createFontFamilyValue):
(WebCore::CSSValuePool::createFontFaceValue):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::ruleSetForScope):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAddNamespace):
(WebCore::StyleSheetContents::determineNamespace):

  • dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationScope::MutationAccumulationRouter::childAdded):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::incrementScopingLevel):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::decrementScopingLevel):

  • dom/Document.cpp:

(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::getCSSCanvasElement):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
(WebCore::DocumentMarkerController::showMarkers):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::remove):

  • dom/ElementAttributeData.cpp:

(WebCore::ensureAttrListForElement):

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):

  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::eventTypes):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::nextListener):

  • dom/IdTargetObserverRegistry.cpp:

(WebCore::IdTargetObserverRegistry::addObserver):
(WebCore::IdTargetObserverRegistry::removeObserver):

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryInstrumentation::addInstrumentedMapEntries):
(WebCore::MemoryInstrumentation::addInstrumentedMapValues):

  • dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::clearRareData):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::Node::collectMatchingObserversForMutation):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
(WebCore::NodeListsNodeData::adoptTreeScope):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::adjustMinimumTimerInterval):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCache::add):

  • dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitStringData::create):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

  • editing/mac/AlternativeTextUIController.mm:

(WebCore::AlternativeTextUIController::AlernativeTextContextController::alternativesForContext):

  • html/FormController.cpp:

(WebCore::SavedFormState::serializeTo):
(WebCore::SavedFormState::appendControlState):
(WebCore::SavedFormState::takeControlState):
(WebCore::SavedFormState::getReferencedFilePaths):
(WebCore::FormKeyGenerator::formKey):
(WebCore::FormController::createSavedFormStateMap):
(WebCore::FormController::formElementsState):
(WebCore::FormController::takeStateForFormElement):
(WebCore::FormController::getReferencedFilePaths):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollectionCacheBase::append):

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeAttachments):

  • inspector/CodeGeneratorInspector.py:
  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):

  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptIdFor):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
(WebCore::InjectedScriptManager::releaseObjectGroup):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::commitSelector):
(WebCore::SelectorProfile::commitSelectorTime):
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::didModifyDOMAttr):
(WebCore::InspectorCSSAgent::resetPseudoStates):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::count):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::nodeForId):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::memoryBytesUsedByStorageCache):

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::databaseId):
(WebCore::InspectorDatabaseAgent::findByFileName):
(WebCore::InspectorDatabaseAgent::databaseForId):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

  • inspector/InspectorPageAgent.cpp:

(WebCore::cachedResourcesForFrame):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameDetached):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getProfile):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForHeaders):
(WebCore::InspectorResourceAgent::willSendRequest):

  • inspector/InspectorState.cpp:

(WebCore::InspectorState::getBoolean):
(WebCore::InspectorState::getString):
(WebCore::InspectorState::getLong):
(WebCore::InspectorState::getDouble):
(WebCore::InspectorState::getObject):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::styleWithProperties):
(WebCore::InspectorStyleSheet::inspectorStyleForId):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorObjectBase::get):
(WebCore::InspectorObjectBase::writeJSON):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore::NetworkResourcesData::clear):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isSimpleCrossOriginAccessRequest):
(WebCore::createAccessControlPreflightRequest):

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::getSubresources):
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::servePendingRequests):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::removeResource):
(WebCore::ApplicationCache::clearStorageID):
(WebCore::ApplicationCache::dump):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::startLoadingEntry):
(WebCore::ApplicationCacheGroup::addEntry):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::fillResourceList):

  • loader/appcache/ApplicationCacheResource.cpp:

(WebCore::ApplicationCacheResource::estimatedSizeInStorage):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::empty):
(WebCore::ApplicationCacheStorage::storeCopyOfCache):

  • loader/archive/ArchiveFactory.cpp:

(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::canReuse):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::switchClientsToRevalidatedResource):
(WebCore::CachedResource::updateResponseAfterRevalidation):

  • loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::removeCachedResource):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::reportMemoryUsage):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeResourcesWithOrigin):
(WebCore::MemoryCache::getOriginsWithCache):
(WebCore::MemoryCache::getStatistics):
(WebCore::MemoryCache::reportMemoryUsage):
(WebCore::MemoryCache::setDisabled):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::removeAllIcons):
(WebCore::IconDatabase::iconRecordCountWithData):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScripts):

  • page/PageGroup.cpp:

(WebCore::PageGroup::pageGroup):
(WebCore::PageGroup::closeLocalStorage):
(WebCore::PageGroup::clearLocalStorageForAllOrigins):
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore::PageGroup::syncLocalStorage):
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::urlForBlankFrame):

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

  • page/Settings.cpp:

(WebCore::setGenericFontFamilyMap):
(WebCore::getGenericFontFamilyForScript):

  • page/SpeechInput.cpp:

(WebCore::SpeechInput::registerListener):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::boolFeature):
(WebCore::WindowFeatures::floatFeature):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::numberOfActiveAnimations):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::clearRenderer):
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):
(WebCore::CompositeAnimation::getAnimatedStyle):
(WebCore::CompositeAnimation::setAnimating):
(WebCore::CompositeAnimation::timeToNextService):
(WebCore::CompositeAnimation::getAnimationForProperty):
(WebCore::CompositeAnimation::suspendAnimations):
(WebCore::CompositeAnimation::resumeAnimations):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::CompositeAnimation::isAnimatingProperty):
(WebCore::CompositeAnimation::numberOfActiveAnimations):

  • platform/Language.cpp:

(WebCore::languageDidChange):

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

  • platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore::CookieManager::removeAllCookies):

  • platform/blackberry/CookieMap.cpp:

(WebCore::CookieMap::removeOldestCookie):
(WebCore::CookieMap::getAllChildCookies):

  • platform/cf/BinaryPropertyList.cpp:

(WebCore::BinaryPropertyListPlan::writeIntegerArray):

  • platform/chromium/support/WebHTTPLoadInfo.cpp:

(WebKit::addHeader):

  • platform/chromium/support/WebURLRequest.cpp:

(WebKit::WebURLRequest::visitHTTPHeaderFields):

  • platform/chromium/support/WebURLResponse.cpp:

(WebKit::WebURLResponse::addHTTPHeaderField):
(WebKit::WebURLResponse::visitHTTPHeaderFields):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::unregisterClient):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::treeGlyphPageCount):
(WebCore::GlyphPageTreeNode::pageCount):
(WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
(WebCore::GlyphPageTreeNode::pruneTreeFontData):
(WebCore::GlyphPageTreeNode::pruneCustomFontData):
(WebCore::GlyphPageTreeNode::pruneFontData):
(WebCore::GlyphPageTreeNode::showSubtree):
(showGlyphPageTrees):

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::resizeEdgeTiles):
(WebCore::TiledBackingStore::setKeepRect):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::avfWrapperForCallbackContext):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::bindContentsTexture):

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::textureForColor):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::pauseAnimation):
(WebCore::GraphicsLayerCA::layerDidDisplay):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateTransform):
(WebCore::GraphicsLayerCA::updateChildrenTransform):
(WebCore::GraphicsLayerCA::updateMasksToBounds):
(WebCore::GraphicsLayerCA::updateContentsVisibility):
(WebCore::GraphicsLayerCA::updateContentsOpaque):
(WebCore::GraphicsLayerCA::updateBackfaceVisibility):
(WebCore::GraphicsLayerCA::updateFilters):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsRect):
(WebCore::GraphicsLayerCA::updateMaskLayer):
(WebCore::GraphicsLayerCA::updateLayerAnimations):
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::removeCAAnimationFromLayer):
(WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer):
(WebCore::GraphicsLayerCA::suspendAnimations):
(WebCore::GraphicsLayerCA::resumeAnimations):
(WebCore::GraphicsLayerCA::findOrMakeClone):
(WebCore::GraphicsLayerCA::setOpacityInternal):
(WebCore::GraphicsLayerCA::updateOpacityOnLayer):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplay):
(WebCore::TileCache::setScale):
(WebCore::TileCache::setAcceleratesDrawing):
(WebCore::TileCache::setTileDebugBorderWidth):
(WebCore::TileCache::setTileDebugBorderColor):
(WebCore::TileCache::revalidateTiles):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::animationStarted):
(resubmitAllAnimations):
(PlatformCALayer::animationForKey):

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::LookupAltName):
(WebCore::fontContainsCharacter):

  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:

(WebCore::getDerivedFontData):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::invalidateContentRect):
(WebCore::TiledLayerChromium::setTexturePriorities):
(WebCore::TiledLayerChromium::resetUpdateState):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::trackDamageFromLeftoverRects):

  • platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::setBounds):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::stopRateLimiter):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::findRenderPassById):

  • platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::inUseByConsumer):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::deleteOwnedResources):
(WebCore::CCResourceProvider::resourceType):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::destroyChild):
(WebCore::CCResourceProvider::getChildToParentMap):
(WebCore::CCResourceProvider::prepareSendToParent):
(WebCore::CCResourceProvider::prepareSendToChild):
(WebCore::CCResourceProvider::receiveFromChild):
(WebCore::CCResourceProvider::receiveFromParent):
(WebCore::CCResourceProvider::transferResource):
(WebCore::CCResourceProvider::trimMailboxDeque):

  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::getCompiledProgram):

  • platform/graphics/filters/CustomFilterProgram.cpp:

(WebCore::CustomFilterProgram::notifyClients):

  • platform/graphics/harfbuzz/HarfBuzzSkia.cpp:

(WebCore::getCachedHarfbuzzFace):
(WebCore::releaseCachedHarfbuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp:

(WebCore::HarfBuzzNGFace::HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::~HarfBuzzNGFace):

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):

  • platform/graphics/openvg/EGLDisplayOpenVG.cpp:

(WebCore::EGLDisplayOpenVG::~EGLDisplayOpenVG):
(WebCore::EGLDisplayOpenVG::destroySurface):
(WebCore::EGLDisplayOpenVG::contextForSurface):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

  • platform/graphics/wince/FontPlatformData.cpp:

(WebCore::FixedSizeFontData::create):

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::forClipboard):

  • platform/gtk/GtkDragAndDropHelper.cpp:

(WebCore::GtkDragAndDropHelper::handleGetDragData):
(WebCore::GtkDragAndDropHelper::handleDragLeave):
(WebCore::GtkDragAndDropHelper::handleDragMotion):
(WebCore::GtkDragAndDropHelper::handleDragDataReceived):
(WebCore::GtkDragAndDropHelper::handleDragDrop):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::gtkStyleChangedCallback):
(WebCore::getStyleContext):

  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):

  • platform/network/CredentialStorage.cpp:

(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::get):

  • platform/network/MIMEHeader.cpp:

(WebCore::MIMEHeader::parseHeader):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::addHTTPHeaderField):
(WebCore::ResourceRequestBase::addHTTPHeaderFields):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::targetTypeFromMimeType):
(WebCore::ResourceRequest::initializePlatformRequest):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::setClientCertificate):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::toSoupMessage):

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::toSoupMessage):

  • platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::start):

  • platform/qt/RunLoopQt.cpp:

(WebCore::RunLoop::TimerBase::timerFired):

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::scriptNameToCode):
(WebCore::localeToScriptCodeForFontSelection):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::pruneBlacklistedCodecs):
(WebCore::dumpTextEncodingNameMap):

  • platform/text/transcoder/FontTranscoder.cpp:

(WebCore::FontTranscoder::converterType):

  • platform/text/win/TextCodecWin.cpp:

(WebCore::LanguageManager::LanguageManager):
(WebCore::getCodePage):
(WebCore::TextCodecWin::registerExtendedEncodingNames):
(WebCore::TextCodecWin::registerExtendedCodecs):
(WebCore::TextCodecWin::enumerateSupportedEncodings):

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::getDataMapItem):
(WebCore::getClipboardData):
(WebCore::setClipboardData):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::types):

  • platform/win/FileSystemWin.cpp:

(WebCore::cachedStorageDirectory):

  • platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::TimerBase::timerFired):

  • platform/win/WCDataObject.cpp:

(WebCore::WCDataObject::createInstance):

  • platform/wince/MIMETypeRegistryWinCE.cpp:

(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

  • platform/wx/ContextMenuWx.cpp:

(WebCore::ContextMenu::appendItem):

  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::MIMETypeForExtension):
(WebCore::PluginDatabase::remove):

  • plugins/PluginMainThreadScheduler.cpp:

(WebCore::PluginMainThreadScheduler::scheduleCall):
(WebCore::PluginMainThreadScheduler::dispatchCalls):

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::startStream):

  • plugins/blackberry/PluginDataBlackBerry.cpp:

(WebCore::PluginData::initPlugins):

  • plugins/wx/PluginDataWx.cpp:

(WebCore::PluginData::initPlugins):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::unregisterNamedFlowContentNode):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::requiresIdeographicBaseline):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::highQualityRepaintTimerFired):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::performOverlapTests):

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayerFilterInfo::filterInfoForRenderLayer):
(WebCore::RenderLayerFilterInfo::createFilterInfoForRenderLayerIfNeeded):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::RenderNamedFlowThread::pushDependencies):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::cachedCollapsedBorder):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor):

  • rendering/RenderView.cpp:

(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::setSelection):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::resumeWidgetHierarchyUpdates):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/VerticalPositionCache.h:

(WebCore::VerticalPositionCache::get):

  • rendering/WrapShapeInfo.cpp:

(WebCore::WrapShapeInfo::ensureWrapShapeInfoForRenderBlock):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::characterStartsNewTextChunk):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::resourceDestroyed):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::swapItemsInLayoutAttributes):

  • rendering/svg/SVGTextLayoutAttributes.cpp:

(WebCore::SVGTextLayoutAttributes::dump):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildCharacterDataMap):
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::performImport):
(WebCore::StorageAreaSync::sync):

  • storage/StorageMap.cpp:

(WebCore::StorageMap::key):
(WebCore::StorageMap::setItem):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::localStorageNamespace):
(WebCore::StorageNamespaceImpl::copy):
(WebCore::StorageNamespaceImpl::close):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget):
(WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::effectReferences):
(WebCore::SVGFilterBuilder::addBuiltinEffects):

  • svg/properties/SVGAnimatedProperty.h:

(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):

  • svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::addProperties):
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::hasPendingActivity):

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::close):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setRequestHeaderInternal):
(WebCore::XMLHttpRequest::getAllResponseHeaders):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::createFunction):

  • xml/XPathParser.cpp:

(isAxisName):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::xsltParamArrayFromParameterMap):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTProcessor::transformToString):

Source/WebKit/blackberry:

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):

  • WebCoreSupport/NotificationPresenterImpl.cpp:

(WebCore::NotificationPresenterImpl::cancel):
(WebCore::NotificationPresenterImpl::onPermission):
(WebCore::NotificationPresenterImpl::notificationClicked):

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):

  • WebKitSupport/FrameLayers.cpp:

(BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
(BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
(BlackBerry::WebKit::FrameLayers::calculateRootLayer):

Source/WebKit/chromium:

  • src/WebGeolocationPermissionRequestManager.cpp:

(WebGeolocationPermissionRequestManager::remove):

  • src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):

  • src/WebIntent.cpp:

(WebKit::WebIntent::extrasValue):

  • tests/WebSocketExtensionDispatcherTest.cpp:

(WebCore::TEST_F):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):

  • WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::getPluginInfo):

  • ewk/ewk_intent.cpp:

(ewk_intent_extra_get):

Source/WebKit/gtk:

  • WebCoreSupport/PlatformStrategiesGtk.cpp:

(PlatformStrategiesGtk::getPluginInfo):

  • webkit/webkitfavicondatabase.cpp:

(webkitFaviconDatabaseImportFinished):

  • webkit/webkitwebplugin.cpp:

(webkit_web_plugin_get_mimetypes):

Source/WebKit/mac:

  • History/WebHistory.mm:

(-[WebHistoryPrivate removeItemFromDateCaches:]):
(-[WebHistoryPrivate orderedLastVisitedDays]):
(WebHistoryWriter::WebHistoryWriter):

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
(+[WebCoreStatistics javaScriptObjectTypeCounts]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::hostForPlugin):
(WebKit::NetscapePluginHostManager::pluginHostDied):
(WebKit::NetscapePluginHostManager::didCreateWindow):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::pluginHostDied):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
(WebKit::NetscapePluginInstanceProxy::destroy):
(WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason):
(WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView stopTimers]):
(-[WebNetscapePluginView startTimers]):

  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):

  • WebView/WebHTMLView.mm:

(commandNameForSelector):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(extractContentTypeFromPluginVector):

  • Api/qwebplugindatabase.cpp:

(QWebPluginInfo::mimeTypes):

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::getPluginInfo):

Source/WebKit/win:

  • COMPropertyBag.h:

(::Read):
(::GetPropertyInfo):

  • WebCoreStatistics.cpp:

(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::getPluginInfo):

  • WebHistory.cpp:

(WebHistory::removeItemFromDateCaches):

  • WebKitCOMAPI.cpp:

(classFactory):

  • WebKitStatistics.cpp:

(WebKitStatistics::comClassNameCounts):

  • WebNotificationCenter.cpp:

(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::removeObserver):

Source/WebKit/wince:

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::getPluginInfo):

Source/WebKit2:

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SyncMessageState::getOrCreate):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::registerEventSourceHandler):
(WorkQueue::unregisterEventSourceHandler):

  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::unregisterMachPortEventHandler):

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::pluginDestroyed):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

  • Shared/WebPreferencesStore.cpp:

(WebKit::valueForKey):
(WebKit::WebPreferencesStore::getBoolValueForKey):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::decode):

  • Shared/qt/ArgumentCodersQt.cpp:

(CoreIPC::::decode):

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::decode):

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(_Ewk_Back_Forward_List::~_Ewk_Back_Forward_List):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context::~_Ewk_Context):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_priv_loading_resources_clear):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_subresources):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseContainerForall):

  • UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _expectedPreviewCallbackForRect:]):
(pageDidDrawToPDF):
(-[WKPrintingView _drawPreview:]):

  • UIProcess/API/mac/WKView.mm:

(commandNameForSelector):
(-[WKView validateUserInterfaceItem:]):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::updateTile):
(WebKit::CoordinatedBackingStore::texture):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
(WebKit::CoordinatedBackingStore::commitTileOperations):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::LayerTreeRenderer::syncCanvas):
(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::setLayerFilters):
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::assignImageToLayer):

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests):

  • UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit::WebInspectorServer::~WebInspectorServer):
(WebKit::WebInspectorServer::registerPage):

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):

  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:

(WebKit::WebInspectorServer::buildPageList):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):

  • UIProcess/WebContext.cpp:

(WebKit::createDictionaryFromHashMap):

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::didFinishURLImport):

  • UIProcess/WebIntentData.cpp:

(WebKit::WebIntentData::extras):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
(WebKit::WebProcessProxy::addBackForwardItem):
(WebKit::WebProcessProxy::frameCountInPage):

  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:

(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::didReceiveGeolocationPermissionDecision):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):

  • WebProcess/InjectedBundle/InjectedBundleIntent.cpp:

(WebKit::InjectedBundleIntent::extras):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::removeNotificationFromContextMap):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::destroyStream):
(WebKit::NetscapePlugin::unscheduleTimer):
(WebKit::NetscapePlugin::frameDidFinishLoading):
(WebKit::NetscapePlugin::frameDidFail):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::buildHTTPHeaders):
(WebKit::PluginView::~PluginView):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::layerByID):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::removeItem):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::commandNameForSelectorName):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
(WebKit::WebProcess::focusedWebPage):
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::webPageGroup):
(WebKit::fromCountedSetToHashMap):
(WebKit::WebProcess::setTextCheckerState):

Source/WTF:

  • wtf/HashCountedSet.h:

(WTF::::add):
(WTF::::remove):
(WTF::copyToVector):

  • wtf/HashIterators.h:

(WTF::HashTableConstKeysIterator::get):
(WTF::HashTableConstValuesIterator::get):
(WTF::HashTableValuesIterator::get):

  • wtf/HashMap.h:

(WTF::KeyValuePairKeyExtractor::extract):
(WTF::HashMapValueTraits::isEmptyValue):
(WTF::HashMapTranslator::translate):
(WTF::HashMapTranslatorAdapter::translate):
(WTF::::set):
(WTF::::get):
(WTF::::take):
(WTF::operator==):
(WTF::deleteAllValues):
(WTF::deleteAllKeys):
Remove deleteAllPairFirsts/Seconds.

  • wtf/HashTable.h:

(WTF::hashTableSwap):
(WTF::::checkTableConsistencyExceptSize):

  • wtf/HashTraits.h:

(WTF::KeyValuePair::KeyValuePair):
(KeyValuePair):
(WTF::KeyValuePairHashTraits::constructDeletedValue):
(WTF::KeyValuePairHashTraits::isDeletedValue):

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::addFreeSpace):
(WTF::MetaAllocator::incrementPageOccupancy):
(WTF::MetaAllocator::decrementPageOccupancy):

  • wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::~RefCountedLeakCounter):

  • wtf/RefPtrHashMap.h:

(WTF::::set):
(WTF::::get):
(WTF::::inlineGet):
(WTF::::take):

  • wtf/Spectrum.h:

(WTF::Spectrum::add):
(WTF::Spectrum::get):
(WTF::Spectrum::buildList):

  • wtf/ThreadingPthreads.cpp:

(WTF::identifierByPthreadHandle):

Tools:

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(MockWebSpeechInputController::addMockRecognitionResult):

  • DumpRenderTree/chromium/NotificationPresenter.cpp:

(NotificationPresenter::simulateClick):
(NotificationPresenter::show):

  • DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:

(CppBoundClass::~CppBoundClass):
(CppBoundClass::invoke):
(CppBoundClass::getProperty):
(CppBoundClass::setProperty):
(CppBoundClass::bindCallback):
(CppBoundClass::bindProperty):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(applyFontMap):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printResourceDescription):

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::~AccessibilityController):
(AccessibilityController::winNotificationReceived):

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::descriptionSuitableForTestResult):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(worldIDForWorld):
(TestRunner::evaluateScriptInIsolatedWorld):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::worldIDForWorld):
(WTR::TestRunner::evaluateScriptInIsolatedWorld):

7:00 PM Changeset in webkit [126835] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Chromium] Stop texture updates when context is lost.
https://bugs.webkit.org/show_bug.cgi?id=94983

Patch by David Reveman <reveman@chromium.org> on 2012-08-27
Reviewed by James Robinson.

Source/WebCore:

Free m_currentTextureUpdateController when
CCThreadProxy::didLoseContextOnImplThread() is called.

Unit test: CCLayerTreeHostTestLostContextWhileUpdatingResources.runMultiThread

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::didLoseContextOnImplThread):
(WebCore::CCThreadProxy::scheduledActionCommit):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext):
(CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::create):
(CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::setContextLostCallback):
(CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::isContextLost):
(CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::beginQueryEXT):
(CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::endQueryEXT):
(CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::getQueryObjectuivEXT):
(CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext):
(CCLayerTreeHostTestLostContextWhileUpdatingResources):
(CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources):
(CCLayerTreeHostTestLostContextWhileUpdatingResources::createOutputSurface):
(CCLayerTreeHostTestLostContextWhileUpdatingResources::beginTest):
(CCLayerTreeHostTestLostContextWhileUpdatingResources::commitCompleteOnCCThread):
(CCLayerTreeHostTestLostContextWhileUpdatingResources::layout):
(CCLayerTreeHostTestLostContextWhileUpdatingResources::afterTest):
(TEST_F):

6:53 PM Changeset in webkit [126834] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed attempted build fix for Mac.

After https://bugs.webkit.org/show_bug.cgi?id=95155 and the subsequent r126831
LayoutTypesInlineMethods.h needed to be added to the WebCore target.

  • WebCore.xcodeproj/project.pbxproj:
6:26 PM Changeset in webkit [126833] by jchaffraix@webkit.org
  • 6 edits
    2 adds in trunk

Crash in RenderTable::removeCaption
https://bugs.webkit.org/show_bug.cgi?id=95090

Reviewed by Abhishek Arya.

Source/WebCore:

The issue came from the caption addition logic not being called when
we move the caption due to being hooked on RenderTable::addChild
and not RenderTableCaption::insertedIntoTree. This change implemented
the previous hook and simplified our caption handling.

Test: fast/table/table-caption-moved-crash.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):
Removed the add-a-caption code as it is now executed from RenderTableCaption::insertedIntoTree.

(WebCore::RenderTable::addCaption):
Added this helper method.

(WebCore::RenderTable::removeCaption):
Changed this function to be more bullet-proof. The old code was checking |index| as it wasn't
bullet proof so let's keep it.

(WebCore::RenderTable::recalcSections):
Removed the caption handling code as we should properly handle them now.

  • rendering/RenderTable.h:

Added addCaption.

  • rendering/RenderTableCaption.cpp:

(WebCore::RenderTableCaption::insertedIntoTree):

  • rendering/RenderTableCaption.h:

Added insertedIntoTree.

LayoutTests:

  • fast/table/table-caption-moved-crash-expected.txt: Added.
  • fast/table/table-caption-moved-crash.html: Added.
6:14 PM Changeset in webkit [126832] by jchaffraix@webkit.org
  • 33 edits
    2 copies
    29 moves
    2 adds
    58 deletes in trunk/LayoutTests

Even more unreviewed rebaselining after r126683.

  • platform/chromium/TestExpectations:

Rebaselined 30 tests (see the new common baselines below).

  • animations/cross-fade-border-image-source-expected.txt: Renamed from LayoutTests/platform/efl/animations/cross-fade-border-image-source-expected.txt.
  • css1/box_properties/border_bottom-expected.txt: Renamed from LayoutTests/platform/efl/css1/box_properties/border_bottom-expected.txt.
  • css1/box_properties/border_bottom_inline-expected.txt: Renamed from LayoutTests/platform/efl/css1/box_properties/border_bottom_inline-expected.txt.
  • css1/box_properties/border_left-expected.txt: Renamed from LayoutTests/platform/efl/css1/box_properties/border_left-expected.txt.
  • css1/box_properties/border_left_inline-expected.txt: Renamed from LayoutTests/platform/efl/css1/box_properties/border_left_inline-expected.txt.
  • css1/box_properties/border_right-expected.txt: Renamed from LayoutTests/platform/efl/css1/box_properties/border_right-expected.txt.
  • css1/box_properties/border_right_inline-expected.txt: Renamed from LayoutTests/platform/efl/css1/box_properties/border_right_inline-expected.txt.
  • css1/units/length_units-expected.txt: Renamed from LayoutTests/platform/efl/css1/units/length_units-expected.txt.
  • css2.1/20110323/absolute-replaced-height-036-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/absolute-replaced-height-036-expected.txt.
  • css2.1/20110323/block-non-replaced-height-007-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-007-expected.txt.
  • css2.1/20110323/block-non-replaced-height-008-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-008-expected.txt.
  • css2.1/20110323/block-non-replaced-height-009-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-009-expected.txt.
  • css2.1/20110323/block-non-replaced-height-010-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-010-expected.txt.
  • css2.1/20110323/block-non-replaced-width-001-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-width-001-expected.txt.
  • css2.1/20110323/block-non-replaced-width-002-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-width-002-expected.txt.
  • css2.1/20110323/block-non-replaced-width-003-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-width-003-expected.txt.
  • css2.1/20110323/block-non-replaced-width-004-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-width-004-expected.txt.
  • css2.1/20110323/block-non-replaced-width-008-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-width-008-expected.txt.
  • css2.1/20110323/margin-applies-to-008-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/margin-applies-to-008-expected.txt.
  • css2.1/20110323/width-non-replaced-inline-001-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/width-non-replaced-inline-001-expected.txt.
  • css2.1/t040302-c61-phys-len-00-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t040302-c61-phys-len-00-b-expected.txt.
  • css2.1/t0804-c5507-padn-r-02-f-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0804-c5507-padn-r-02-f-expected.txt.
  • css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt.
  • css2.1/t0804-c5509-padn-l-02-f-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0804-c5509-padn-l-02-f-expected.txt.
  • css2.1/t0805-c5519-brdr-r-02-e-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5519-brdr-r-02-e-expected.txt.
  • css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt.
  • css2.1/t0805-c5520-brdr-b-00-a-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5520-brdr-b-00-a-expected.txt.
  • css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt.
  • css2.1/t0805-c5521-brdr-l-02-e-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5521-brdr-l-02-e-expected.txt.

Common baselines for the tests.

  • platform/gtk/animations/cross-fade-border-image-source-expected.txt: Removed.
  • platform/gtk/css1/box_properties/border_bottom-expected.txt: Removed.
  • platform/gtk/css1/box_properties/border_bottom_inline-expected.txt: Removed.
  • platform/gtk/css1/box_properties/border_left-expected.txt: Removed.
  • platform/gtk/css1/box_properties/border_left_inline-expected.txt: Removed.
  • platform/gtk/css1/box_properties/border_right-expected.txt: Removed.
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt: Removed.
  • platform/gtk/css1/units/length_units-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-007-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-008-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-009-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-010-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-002-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-003-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-004-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/margin-applies-to-008-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/width-non-replaced-inline-001-expected.txt: Removed.
  • platform/gtk/css2.1/t040302-c61-phys-len-00-b-expected.txt: Removed.
  • platform/gtk/css2.1/t0804-c5507-padn-r-02-f-expected.txt: Removed.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt: Removed.
  • platform/gtk/css2.1/t0804-c5509-padn-l-02-f-expected.txt: Removed.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-02-e-expected.txt: Removed.
  • platform/gtk/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt: Removed.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-00-a-expected.txt: Removed.
  • platform/gtk/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt: Removed.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-02-e-expected.txt: Removed.
  • platform/mac-lion/animations/cross-fade-border-image-source-expected.txt: Removed.
  • platform/mac-lion/css1/box_properties/border_bottom-expected.txt: Removed.
  • platform/mac-lion/css1/box_properties/border_bottom_inline-expected.txt: Removed.
  • platform/mac-lion/css1/box_properties/border_left-expected.txt: Removed.
  • platform/mac-lion/css1/box_properties/border_left_inline-expected.txt: Removed.
  • platform/mac-lion/css1/box_properties/border_right-expected.txt: Removed.
  • platform/mac-lion/css1/box_properties/border_right_inline-expected.txt: Removed.
  • platform/mac-lion/css1/units/length_units-expected.txt: Removed.
  • platform/mac-lion/css2.1/20110323/absolute-replaced-height-036-expected.txt: Removed.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-height-007-expected.txt: Removed.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-height-008-expected.txt: Removed.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-height-009-expected.txt: Removed.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-height-010-expected.txt: Removed.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-001-expected.txt: Removed.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-002-expected.txt: Removed.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-003-expected.txt: Removed.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-004-expected.txt: Removed.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-008-expected.txt: Removed.
  • platform/mac-lion/css2.1/20110323/margin-applies-to-008-expected.txt: Removed.
  • platform/mac-lion/css2.1/20110323/width-non-replaced-inline-001-expected.txt: Removed.
  • platform/mac-lion/css2.1/t040302-c61-phys-len-00-b-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0804-c5507-padn-r-02-f-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0804-c5509-padn-l-02-f-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0805-c5519-brdr-r-02-e-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0805-c5520-brdr-b-00-a-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0805-c5521-brdr-l-02-e-expected.txt: Removed.

Removed those baselines as they are properly covered by the fallbacks.

  • platform/chromium-linux-x86/fast/css/line-height-determined-by-primary-font-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.txt.
  • platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
  • platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
  • platform/chromium-win-xp/fast/css/line-height-determined-by-primary-font-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.txt.
  • platform/chromium-win/animations/cross-fade-border-image-source-expected.txt:
  • platform/chromium-win/css1/box_properties/border_bottom-expected.txt:
  • platform/chromium-win/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/chromium-win/css1/box_properties/border_left-expected.txt:
  • platform/chromium-win/css1/box_properties/border_left_inline-expected.txt:
  • platform/chromium-win/css1/box_properties/border_right-expected.txt:
  • platform/chromium-win/css1/box_properties/border_right_inline-expected.txt:
  • platform/chromium-win/css1/units/length_units-expected.txt:
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-036-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-007-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-009-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-001-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-002-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-003-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-004-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/chromium-win/css2.1/20110323/margin-applies-to-008-expected.txt:
  • platform/chromium-win/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
  • platform/chromium-win/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.txt:

Updated Chromium baselines as after r126683 the top border is always dumped.

6:10 PM Changeset in webkit [126831] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add new file to xcode project -- Update to Bug 95107
https://bugs.webkit.org/show_bug.cgi?id=95155

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-27
Reviewed by Tim Horton.

Add LayoutTypesInlineMethods.h to xcode project file.

  • WebCore.xcodeproj/project.pbxproj:
6:02 PM Changeset in webkit [126830] by jamesr@google.com
  • 4 edits in trunk/Source/WebCore

[chromium] Add some #includes that were implicitly picked up to CCScrollbarGeometry*
https://bugs.webkit.org/show_bug.cgi?id=95158

Reviewed by Adrienne Walker.

These includes are picked up implicitly, better to #include them explicitly to be more robust to refactors.

  • platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp:
  • platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h:
  • platform/graphics/chromium/cc/CCScrollbarGeometryStub.h:
5:50 PM Changeset in webkit [126829] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] V8DOMWindowShell::installDOMWindow is subtle and should explain itself more
https://bugs.webkit.org/show_bug.cgi?id=95151

Reviewed by Kentaro Hara.

This patch adds some text to V8DOMWindowShell::installDOMWindow that
explaining what this code is doing. I've also renamed some variables
and created a helper function in an attempt to make it clearer what's
going on.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::toInnerGlobalObject):
(WebCore):
(WebCore::V8DOMWindowShell::installDOMWindow):
(WebCore::V8DOMWindowShell::updateDocumentProperty):

5:45 PM Changeset in webkit [126828] by macpherson@chromium.org
  • 3 edits
    2 adds in trunk

Fix CSSParserValue::createCSSValue() for viewport based units.
https://bugs.webkit.org/show_bug.cgi?id=94772

Reviewed by Tony Chang.

Source/WebCore:

Viewport units were not added to CSSParserValue::createCSSValue(). This patch handles that case.
Patch also converts from list of if clauses to a switch statement to catch future errors.

Test: fast/css/variables/calc-vw-crash.html

  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):

LayoutTests:

Add test that uses variables, calc and viewport units together.

  • fast/css/variables/calc-vw-crash-expected.txt: Added.
  • fast/css/variables/calc-vw-crash.html: Added.
5:42 PM Changeset in webkit [126827] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] V8DOMWindowShell::setContext has no callers
https://bugs.webkit.org/show_bug.cgi?id=95147

Reviewed by Kentaro Hara.

Dead code is dead.

  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

5:40 PM Changeset in webkit [126826] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Structure check hoisting should abstain if the OSR entry's must-handle value for the respective variable has a different structure
https://bugs.webkit.org/show_bug.cgi?id=95141
<rdar://problem/12170401>

Reviewed by Mark Hahnenberg.

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

5:29 PM Changeset in webkit [126825] by jchaffraix@webkit.org
  • 1 edit
    3 copies in branches/chromium/1229

Merge 126591 - Crash in RenderTableCell::borderTop() due to custom scrollbars after r124168
https://bugs.webkit.org/show_bug.cgi?id=93903

Reviewed by Tony Chang.

Source/WebCore:

r124168 changed when we create scrollbars so that it happens (rightly) at style change time.
However the RenderScrollbar code assumes that any overflow: scroll RenderScrollbar would be
created at layout time as it directly tries to layout to scrollbar parts. The big issues with
the move is that the first style change operates on a detached renderer which means that we
could crash in some situation.

Test: scrollbars/custom-scrollbar-table-cell.html

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
Fixed the crash by using style information instead of calling the renderer. This is guaranteed
to be safe but it also means that custom scrollbars sizing is not right on table cells with
collapsing borders. The existing logic was querying layout information at style change so I
wouldn't bet on it working properly anyway.

LayoutTests:

  • scrollbars/custom-scrollbar-table-cell-expected.png: Added.
  • scrollbars/custom-scrollbar-table-cell-expected.txt: Added.
  • scrollbars/custom-scrollbar-table-cell.html: Added.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10875081

5:14 PM Changeset in webkit [126824] by Dimitri Glazkov
  • 3 edits in trunk/Source/WebCore

Rename ContentDistributor::distributeShadowChildrenTo to distributeNodeChildrenTo.
https://bugs.webkit.org/show_bug.cgi?id=95150

Reviewed by Hajime Morita.

Also, made the function take ContainerNode, which decouples it from the callsite's context.

No new tests, simple rename.

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute): Changed the callsite.
(WebCore::ContentDistributor::distributeNodeChildrenTo): Renamed from distributeShadowChildrenTo.

  • html/shadow/ContentDistributor.h:

(WebCore): Added forward decl for ContainerNode.
(ContentDistributor): Changed the decl name.

5:04 PM Changeset in webkit [126823] by vangelis@chromium.org
  • 2 edits in branches/chromium/1229/Source/WebCore

Merge 125961 - [chromium] Fix random noise around text in FPS HUD.
https://bugs.webkit.org/show_bug.cgi?id=94400

Reviewed by James Robinson.

This was the result of an incorrect clear operation on the canvas
that stores the font atlas used by the HUD.

  • platform/graphics/chromium/CompositorHUDFontAtlas.cpp:

(WebCore::CompositorHUDFontAtlas::generateFontAtlas):

TBR=vangelis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10873100

5:02 PM Changeset in webkit [126822] by vangelis@chromium.org
  • 3 edits in branches/chromium/1229/Source/WebCore

Merge 125445 - [chromium] Clear HUD canvas contents before drawing into it.
https://bugs.webkit.org/show_bug.cgi?id=93759

Reviewed by Adrienne Walker.

Not clearing the bitmaps before drawing into it results into
random noise. This patch also caches the SkCanvas used by the HUD
to avoid reallocating it every frame.

  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:

(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):

  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:

TBR=vangelis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10873098

5:02 PM Changeset in webkit [126821] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Gardening: skipping tests due to WebCore::JSEventListener::jsFunction(WebCore::ScriptExecutionContext*) crashes.
https://bugs.webkit.org/show_bug.cgi?id=95144.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-27
Reviewed by Stephanie Lewis.

fast/events/keyevent-iframe-removed-crash.html
fullscreen/full-screen-iframe-zIndex.html
fullscreen/full-screen-restrictions.html
http/tests/security/MessagePort/event-listener-context.html
platform/mac/accessibility/search-with-frames.html
svg/custom/use-instanceRoot-as-event-target.xhtml

  • platform/mac/Skipped:
4:52 PM Changeset in webkit [126820] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] Inline V8DOMWindowShell::clearDocumentWrapper
https://bugs.webkit.org/show_bug.cgi?id=95133

Reviewed by Eric Seidel.

Now that we use ScopedPersistent for m_document, clearDocumentWrapper
is just one line. It's clearer to just inline it into its callers.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::clearForClose):
(WebCore::V8DOMWindowShell::clearForNavigation):
(WebCore::V8DOMWindowShell::updateDocumentWrapper):

  • Notice that ScopedPersistent::set already calls clear, so there's no reason to call clear redundantly.
  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

4:39 PM Changeset in webkit [126819] by danakj@chromium.org
  • 33 edits
    1 copy in trunk/Source

[chromium] A general mechanism for passing data into and out of appendQuads and quadCuller via CCAppendQuadsData
https://bugs.webkit.org/show_bug.cgi?id=95109

Reviewed by Adrienne Walker.

Source/WebCore:

The appendQuads() method has a number of out-parameters that are needed
by different steps in the append process:

  • hadMissingTiles is needed by the layers to report checkerboards.
  • hadOcclusionFromOutsideTargetSurface is needed by CCQuadCuller to

report occlusion.

Currently one is plumbed through function arguments, and one is
plumbed as a member variable on the CCQuadCuller instance.

We will also need an in-parameter for the DelegatedRendererLayer for
ubercomp. Instead of continuously adding more plumbing for these
parameters, we create a general machanism to get data to and from the
right places.

Covered by existing tests; no change in behaviour. Specifically,
CCLayerTreeHostImpl tests for missing/checkerboard tiles and
surface-external occlusion.

  • platform/graphics/chromium/cc/CCAppendQuadsData.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.h.

(WebCore):
(WebCore::CCAppendQuadsData::CCAppendQuadsData):
(CCAppendQuadsData):

  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:

(WebCore::CCHeadsUpDisplayLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:

(CCHeadsUpDisplayLayerImpl):

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:

(WebCore::CCIOSurfaceLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.h:

(CCIOSurfaceLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::appendDebugBorderQuad):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):
(WebCore::CCLayerImpl::appendQuads):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(WebCore):
(CCQuadCuller):

  • platform/graphics/chromium/cc/CCQuadSink.h:

(WebCore):
(CCQuadSink):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:

(WebCore::CCSolidColorLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:

(WebCore::CCTextureLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.h:

(CCTextureLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

Update tests to use the new data structure.

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCQuadCullerTest.cpp:
  • tests/CCRenderSurfaceTest.cpp:
  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):

  • tests/MockCCQuadCuller.h:
4:31 PM Changeset in webkit [126818] by jchaffraix@webkit.org
  • 14 edits
    6 adds
    18 deletes in trunk/LayoutTests

More unreviewed rebaselining after r126683.

  • platform/chromium/TestExpectations:

Removed 5 tests rebaselined in css2.1.

  • platform/chromium-linux/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:

Updated Chromium specific baseline now that we always dump the border top.

  • css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Added.
  • css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Added.
  • css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Added.
  • css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Added.
  • css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Added.
  • css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Added.
  • platform/efl/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Removed.
  • platform/efl/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
  • platform/efl/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Removed.
  • platform/efl/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Removed.
  • platform/efl/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Removed.
  • platform/efl/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Removed.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Removed.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Removed.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Removed.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Removed.
  • platform/gtk/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Removed.

Removed efl + gtk baselines, replaced by the common one.

  • platform/mac-lion/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Removed.
  • platform/mac-lion/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Removed.

Removed Mac Lion baseline as it was a duplicate of mac.

4:29 PM Changeset in webkit [126817] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

Delete checks for impossible conditions in V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=95145

Reviewed by Eric Seidel.

These situations do not occur. We don't need to check for them.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::updateDocument):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::createNewContext):
(WebCore::V8DOMWindowShell::updateDocumentProperty):
(WebCore::V8DOMWindowShell::setSecurityToken):
(WebCore::V8DOMWindowShell::updateDocument):

  • page/Frame.cpp:

(WebCore::Frame::setDocument):

  • updateDocument used to just return early when m_doc was 0. Now we don't even bother to call it.
4:13 PM Changeset in webkit [126816] by commit-queue@webkit.org
  • 28 edits
    1 copy in trunk/Source/WebCore

Split LayoutTypes.h to improve compile time
https://bugs.webkit.org/show_bug.cgi?id=95107

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-27
Reviewed by Eric Seidel.

The inlines from LayoutTypes.h are moved to LayoutTypesInlineMethods.h.
Files that only need the types to be forward declared, don't need to
include definitions for FractionalLayout items (those are expensive to
include)

No new tests. Functionality should be the same.

  • WebCore.gypi:
  • accessibility/AccessibilityObject.h:
  • css/LengthFunctions.cpp:
  • dom/DocumentMarkerController.h:
  • dom/Node.h:
  • inspector/InspectorOverlay.h:
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.h:
  • loader/SubframeLoader.h:
  • page/FocusController.h:
  • page/Page.h:
  • platform/Length.h:
  • platform/PopupMenuClient.h:
  • platform/graphics/transforms/TransformationMatrix.cpp:
  • platform/graphics/transforms/TransformationMatrix.h:
  • rendering/AutoTableLayout.h:
  • rendering/FixedTableLayout.h:
  • rendering/HitTestingTransformState.cpp:
  • rendering/LayoutTypes.h:
  • rendering/LayoutTypesInlineMethods.h: Added.

(WebCore):

  • rendering/RenderMenuList.h:
  • rendering/RenderThemeChromiumCommon.h:
  • rendering/TextAutosizer.h:
  • rendering/style/ShadowData.cpp:
  • rendering/style/ShadowData.h:
  • rendering/style/WrapShapes.h:
  • rendering/svg/SVGRenderSupport.h:
  • rendering/svg/SVGRenderingContext.h:
  • svg/graphics/SVGImage.h:
4:05 PM Changeset in webkit [126815] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove use of ClassInfo from SpeculativeJIT::compileGetByValOnArguments
https://bugs.webkit.org/show_bug.cgi?id=95131

Reviewed by Filip Pizlo.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments): We don't need this speculation check. We can replace it
with an assert to guarantee this.

4:03 PM Changeset in webkit [126814] by oliver@apple.com
  • 4 edits
    5 deletes in trunk/Source/JavaScriptCore

Remove opcode definition autogen for now
https://bugs.webkit.org/show_bug.cgi?id=95148

Reviewed by Mark Hahnenberg.

This isn't worth doing at the moment.

  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/OpcodeDefinitions.h: Removed.
  • bytecode/opcodes: Removed.
  • opcode_definition_generator.py: Removed.
  • opcode_generator.py: Removed.
  • opcode_parser.py: Removed.
4:01 PM Changeset in webkit [126813] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Put CCThreadImpl / WebCompositorImpl in webcore_chromium_compositor_files gyp section
https://bugs.webkit.org/show_bug.cgi?id=94995

Patch by James Robinson <jamesr@chromium.org> on 2012-08-27
Reviewed by Adrienne Walker.

These need to be controllable by use_libcc_for_compositor

  • WebCore.gypi:
3:58 PM Changeset in webkit [126812] by Simon Fraser
  • 3 edits
    2 adds in trunk

If both left and right (or top and bottom) are specified for sticky, use left (or top)
https://bugs.webkit.org/show_bug.cgi?id=95146

Reviewed by Dan Bernstein.

Source/WebCore:

Remove the incorrect FIXME comment, and swap the left and right,
and top and bottom constraints so that left and top win out,
as they do for position:relative.

Test: fast/css/sticky/sticky-both-sides.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::stickyPositionOffset):

LayoutTests:

Ref tests for stickies with left and right, or top and bottom specified.

  • fast/css/sticky/sticky-both-sides-expected.html: Added.
  • fast/css/sticky/sticky-both-sides.html: Added.
3:45 PM Changeset in webkit [126811] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] Improve the names of some private functions of V8DOMWindowShell.cpp
https://bugs.webkit.org/show_bug.cgi?id=95132

Reviewed by Eric Seidel.

V8DOMWindowShell has a concept of a "DocumentWrapperCache", but that's
more easily understood as the "document" property of the Window. This
patch renames a couple functions to make this clearer.

This patch as renames disposeContextHandles to disposeContext because
that's what's actually happening.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::isContextInitialized):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::clearForClose):
(WebCore::V8DOMWindowShell::clearForNavigation):
(WebCore):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::updateDocumentProperty):
(WebCore::V8DOMWindowShell::clearDocumentProperty):
(WebCore::V8DOMWindowShell::updateDocument):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

3:42 PM Changeset in webkit [126810] by jamesr@google.com
  • 7 edits
    3 adds in trunk

WebGL should not flip textures on presentation if contents are unchanged
https://bugs.webkit.org/show_bug.cgi?id=94961

Reviewed by Kenneth Russell.

Source/WebCore:

For WebGL contexts where antialias and preserveDrawingBuffer are false, chromium implements DrawingBuffer using
two textures and flips them on presentation. If the page hasn't actually rendered anything into the WebGL
context since the last presentation, this makes an old frame available. This fixes the bug by marking the
DrawingBuffer when its contents change.

Test: compositing/webgl/webgl-repaint.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::markContextChanged):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::prepareBackBuffer):

  • platform/graphics/gpu/DrawingBuffer.h:

(WebCore::DrawingBuffer::markContentsChanged):
(DrawingBuffer):

Tools:

Run some compositing webgl tests in threaded mode to catch regressions specific to that mode.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.virtual_test_suites):

LayoutTests:

Adds a test to make sure multiple displays without any WebGL draw calls leave the WebGL output alone.

  • compositing/webgl/webgl-repaint-expected.png: Added.
  • compositing/webgl/webgl-repaint-expected.txt: Added.
  • compositing/webgl/webgl-repaint.html: Added.
3:36 PM Changeset in webkit [126809] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Clean up V8DOMWindowShell's findFrame
https://bugs.webkit.org/show_bug.cgi?id=95130

Reviewed by Eric Seidel.

This patch just deletes a bunch of unneeded variables from findFrame
and adds an ASSERT for what a comment claims to be true.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::findFrame):

3:34 PM Changeset in webkit [126808] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[BlackBerry] Test expectation for fast/js/constructor-length.html
https://bugs.webkit.org/show_bug.cgi?id=95125

Patch by Leo Yang <leoyang@rim.com> on 2012-08-27
Reviewed by Yong Li.

  • platform/blackberry/fast/js/constructor-length-expected.txt: Added.
3:33 PM Changeset in webkit [126807] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Unreviewed, rolling out r126772.
http://trac.webkit.org/changeset/126772
https://bugs.webkit.org/show_bug.cgi?id=95137

"This change breaks news.qq.com" (Requested by leoyang on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-27

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):

3:27 PM Changeset in webkit [126806] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations:

Marked some position: sticky tests as failing due to sub-pixel layout.

3:19 PM Changeset in webkit [126805] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Hook procedure should check to see if hook has already been removed before attempting removal.
https://bugs.webkit.org/show_bug.cgi?id=95118

Reviewed by Simon Fraser.

When the hookFired method in LayerChangesFlusher.cpp gets called in response to a message posted to the message queue
it calls CallNextHook to pass the message to the next hook procedure in the hook chain.

Sometimes, the message can get passed to another hook procedure that can dispatch another message.
This message gets passed back through the hook chain and we eventually re-enter the hookFired method.

When that hookFired call completes, it may remove the hook.
When CallNextHook returns, the original call to hookFired may try to remove the hook as well.
However, there is no need as the hook as already been removed.
This results in an assertion failure, assert(m_hook), when we call removeHook.

  • platform/graphics/ca/win/LayerChangesFlusher.cpp:

(WebCore::LayerChangesFlusher::hookFired):
Simply check to see if the hook has already been removed before actually trying to remove it.

3:09 PM Changeset in webkit [126804] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove uses of TypedArray ClassInfo from SpeculativeJIT::checkArgumentTypes
https://bugs.webkit.org/show_bug.cgi?id=95112

Reviewed by Filip Pizlo.

Removing these checks since we no longer need them.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

3:01 PM Changeset in webkit [126803] by jamesr@google.com
  • 10 edits
    2 moves in trunk/Source

[chromium] Clean up dependencies of WebScrollbar and WebScrollbarLayer
https://bugs.webkit.org/show_bug.cgi?id=94996

Reviewed by Adrienne Walker.

Source/Platform:

This moves the WebScrollbarLayer::create factory out of #if WEBKIT_IMPLEMENTATION and expresses it in API terms
only so anyone who can get a handle on a WebScrollbar can construct the layer. Also removes the ::create() from
WebScrollbar, anyone who currently has access to a WebCore::Scrollbar also has access to WebScrollbarImpl.

  • chromium/public/WebScrollbar.h:

(WebScrollbar):

  • chromium/public/WebScrollbarLayer.h:

(WebScrollbarLayer):

Source/WebCore:

Moves WebScrollbarImpl into WebCore/platform/support to make it accessible to chromium-specific WebCore code and
uses it to construct WebScrollbar instances around WebCore::Scrollbars.

  • WebCore.gypi:
  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::createScrollbarLayer):

  • platform/chromium/support/WebScrollbarImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarImpl.cpp.

(WebKit):
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::isOverlay):
(WebKit::WebScrollbarImpl::value):
(WebKit::WebScrollbarImpl::location):
(WebKit::WebScrollbarImpl::size):
(WebKit::WebScrollbarImpl::enabled):
(WebKit::WebScrollbarImpl::maximum):
(WebKit::WebScrollbarImpl::totalSize):
(WebKit::WebScrollbarImpl::isScrollViewScrollbar):
(WebKit::WebScrollbarImpl::isScrollableAreaActive):
(WebKit::WebScrollbarImpl::getTickmarks):
(WebKit::WebScrollbarImpl::controlSize):
(WebKit::WebScrollbarImpl::pressedPart):
(WebKit::WebScrollbarImpl::hoveredPart):
(WebKit::WebScrollbarImpl::scrollbarOverlayStyle):
(WebKit::WebScrollbarImpl::orientation):
(WebKit::WebScrollbarImpl::isCustomScrollbar):

  • platform/chromium/support/WebScrollbarImpl.h: Renamed from Source/WebKit/chromium/src/WebScrollbarImpl.h.

(WebCore):
(WebKit):
(WebScrollbarImpl):

Source/WebKit/chromium:

Fix up tests for API changes.

  • WebKit.gyp:
  • src/WebScrollbarLayerImpl.cpp:

(WebKit::WebScrollbarLayer::create):

  • tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::TEST):

2:57 PM Changeset in webkit [126802] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Make RenderBox::computePositionedLogicalHeight const
https://bugs.webkit.org/show_bug.cgi?id=94984

Reviewed by Ojan Vafai.

This is step 1 in making computeLogical{Height,Width} const.
computeLogicalHeight calls computePositionedLogicalHeight, so this patch
makes that const first.

No new tests, just refactoring. Covered by fast/block/positioning/differing-writing-modes-replaced.html
and others.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight): Call const version of computePositionedLogicalHeight.
(WebCore::RenderBox::computePositionedLogicalHeight): Make const, fills in struct instead.
(WebCore::RenderBox::computePositionedLogicalHeightUsing): Make const
and pass in a LogicalExtentComputedValues struct instead of 4 separate args for the results.
(WebCore::RenderBox::computePositionedLogicalHeightReplaced): Make const, fills in struct instead.

  • rendering/RenderBox.h:

(WebCore::RenderBox::MarginsComputedValues::MarginsComputedValues):
(MarginsComputedValues): Struct of just margins. Not used yet, but will be for
computeInlineDirectionMargins and computeBlockDirectionMargins.
(WebCore::RenderBox::LogicalExtentComputedValues::LogicalExtentComputedValues):
(LogicalExtentComputedValues): Struct to be used by computeLogical{Width,Height}. Only used by
computeLogicalHeight so far.

2:53 PM Changeset in webkit [126801] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Gardening: Skipping tests due to JSC::Bindings::Instance::createRuntimeObject(JSC::ExecState*) crashes.
https://bugs.webkit.org/show_bug.cgi?id=95116.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-27
Reviewed by Sam Weinig.

editing/pasteboard/paste-TIFF.html
platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html

  • platform/mac/Skipped:
2:52 PM Changeset in webkit [126800] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix compiler warnings in TextureMapperLayer.cpp
https://bugs.webkit.org/show_bug.cgi?id=95128

Reviewed by Noam Rosenthal.

Fix the warnings caused by -Wsign-compare.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::shouldKeepContentTexture):

2:49 PM Changeset in webkit [126799] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Clean up reportFatalError in V8DOMWindowShell.cpp
https://bugs.webkit.org/show_bug.cgi?id=95124

Reviewed by Eric Seidel.

We don't need a PLATFORM(CHROMIUM) ifdef because MemoryUsageSupport has
a stub implementation on non-Chromium platforms. These comments are out
of date. We've been "temporarily" calling CRASH here for as long as the
bindings have existed and we don't plan to stop.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::reportFatalError):

2:37 PM Changeset in webkit [126798] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Clean up V8DOMWindowShell's reportUncaughtException
https://bugs.webkit.org/show_bug.cgi?id=95126

Reviewed by Eric Seidel.

This patch changes reportUncaughtException to operate in terms of a
DOMWindow rather than a Frame. In general, the bindings should use
DOMWindows rather than Frames because a DOMWindow is specific to a
given Document whereas a Frame displays many Documents over its
lifetime.

I've also updated some variable names to be more consistent with WebKit
naming conventions.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::reportUncaughtException):

2:29 PM Changeset in webkit [126797] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

The static functions in V8DOMWindowShell.cpp are poorly named
https://bugs.webkit.org/show_bug.cgi?id=95122

Reviewed by Eric Seidel.

This patch cleans up the naming of the static functions in
V8DOMWindowShell.cpp.

I've inlined handleFatalErrorInV8 into its one caller.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::reportFatalError):

  • Removed V8 from the name becaues this entire file is about V8.

(WebCore::reportUncaughtException):

  • Ditto.

(WebCore::findFrame):

  • Remove the "get" prefix because it's a weak verb.

(WebCore::reportUnsafeJavaScriptAccess):
(WebCore::initializeV8IfNeeded):
(WebCore::checkDocumentWrapper):

  • Move this function up to the top of the file with the rest of the static functions.

(WebCore):

2:24 PM Changeset in webkit [126796] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

[V8] initContextIfNeeded is overly specific
https://bugs.webkit.org/show_bug.cgi?id=95120

Reviewed by Eric Seidel.

This patch is part of a series to clean up V8DOMWindowShell. This
patch renames initContextIfNeeded to initializeIfNeeded because callers
shouldn't need to worry about what V8DOMWindow needs to initialize.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::mainWorldContext):
(WebCore::ScriptController::matchesCurrentContext):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::updateDocument):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initializeIfNeeded):
(WebCore::WorkerContextExecutionProxy::evaluate):

  • bindings/v8/WorkerContextExecutionProxy.h:

(WorkerContextExecutionProxy):

2:22 PM Changeset in webkit [126795] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Skia/Chromium] Remove use of deprecated Skia names
https://bugs.webkit.org/show_bug.cgi?id=95108

Patch by Brian Salomon <bsalomon@google.com> on 2012-08-27
Reviewed by Eric Seidel.

kSkia8888_PM_GrPixelConfig has been deprecated in favor of kSkia8888_GrPixelConfig.
SkGrTexturePixelRef has been deprecated in favor of SkGrPixelRef.

Covered by existing tests (image filter and canvas tests).

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::createAcceleratedCanvas):

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

2:20 PM Changeset in webkit [126794] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Unreviewed, remove OVERRIDE from non-virtual function.
https://bugs.webkit.org/show_bug.cgi?id=94859

Unreviewed build fix.

  • platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h:

(CCScrollbarGeometryFixedThumb):

2:11 PM Changeset in webkit [126793] by jchaffraix@webkit.org
  • 2 edits
    4 adds
    18 deletes in trunk/LayoutTests

Unreviewed rebaselining after r126683.

  • platform/chromium/TestExpectations:

Removed 4 entries that were rebaselined.

  • fast/block/float/avoidance-rtl-expected.txt: Replaced.
  • fast/borders/border-radius-wide-border-01-expected.txt: Replaced.
  • fast/borders/only-one-border-with-width-expected.txt: Replaced.
  • fast/multicol/progression-reverse-expected.txt: Replaced.

Common baseline updates now that we always dump the first border.

  • platform/efl/fast/block/float/avoidance-rtl-expected.txt: Removed.
  • platform/efl/fast/borders/border-radius-wide-border-01-expected.txt: Removed.
  • platform/efl/fast/borders/only-one-border-with-width-expected.txt: Removed.
  • platform/efl/fast/multicol/progression-reverse-expected.txt: Removed.
  • platform/gtk/fast/block/float/avoidance-rtl-expected.txt: Removed.
  • platform/gtk/fast/borders/border-radius-wide-border-01-expected.txt: Removed.
  • platform/gtk/fast/borders/only-one-border-with-width-expected.txt: Removed.
  • platform/gtk/fast/multicol/progression-reverse-expected.txt: Removed.
  • platform/mac-lion/fast/block/float/avoidance-rtl-expected.txt: Removed.
  • platform/mac-lion/fast/borders: Removed.
  • platform/mac-lion/fast/borders/border-radius-wide-border-01-expected.txt: Removed.
  • platform/mac-lion/fast/borders/only-one-border-with-width-expected.txt: Removed.
  • platform/mac-lion/fast/multicol/progression-reverse-expected.txt: Removed.
  • platform/mac/fast/block/float/avoidance-rtl-expected.txt: Removed.
  • platform/mac/fast/borders/border-radius-wide-border-01-expected.txt: Removed.
  • platform/mac/fast/borders/only-one-border-with-width-expected.txt: Removed.
  • platform/mac/fast/multicol/progression-reverse-expected.txt: Removed.
  • platform/qt/fast/block/float/avoidance-rtl-expected.txt: Removed.
  • platform/qt/fast/borders/border-radius-wide-border-01-expected.txt: Removed.
  • platform/qt/fast/borders/only-one-border-with-width-expected.txt: Removed.

Removed those baselines now that they can be shared with the common one above.

1:59 PM Changeset in webkit [126792] by gavinp@chromium.org
  • 3 edits in trunk/Tools

[webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up.
https://bugs.webkit.org/show_bug.cgi?id=95104

Reviewed by Adam Barth.

Today I found out this command was broken by the new iOS platform showing up on omahaproxy. Now the webkit-patch chrome-channels command gracefully handles new, previously unknown platforms. Also, it prints iOS in the proper mixed case.

  • Scripts/webkitpy/common/net/omahaproxy.py:

(OmahaProxy):
(OmahaProxy.get_revisions):

  • Scripts/webkitpy/common/net/omahaproxy_unittest.py:

(OmahaProxyTest):
(OmahaProxyTest.test_get_revisions):

1:48 PM Changeset in webkit [126791] by enne@google.com
  • 7 edits
    4 adds in trunk/Source

[chromium] Prevent scrollbar thumb size from changing during compositor zoom
https://bugs.webkit.org/show_bug.cgi?id=94859

Reviewed by James Robinson.

Source/WebCore:

During a pinch zoom, the total size of a scrollable area will change,
causing the thumb to become a different size. This will cause the
thumb texture (painted at a specific size) to stretch. To fix this,
add a new CCScrollbarGeometryFixedThumb class which behaves just like
a normal WebScrollbarThemeGeometry class, but constrains the thumb to
be a fixed size.

  • WebCore.gypi:
  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp: Added.

(WebCore):
(WebCore::CCScrollbarGeometryFixedThumb::create):
(WebCore::CCScrollbarGeometryFixedThumb::~CCScrollbarGeometryFixedThumb):
(WebCore::CCScrollbarGeometryFixedThumb::update):
(WebCore::CCScrollbarGeometryFixedThumb::clone):
(WebCore::CCScrollbarGeometryFixedThumb::thumbLength):
(WebCore::CCScrollbarGeometryFixedThumb::thumbPosition):
(WebCore::CCScrollbarGeometryFixedThumb::splitTrack):
(WebCore::CCScrollbarGeometryFixedThumb::CCScrollbarGeometryFixedThumb):

  • platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h: Added.

(WebCore):
(CCScrollbarGeometryFixedThumb):

  • platform/graphics/chromium/cc/CCScrollbarGeometryStub.cpp: Added.

(WebCore):
(WebCore::CCScrollbarGeometryStub::CCScrollbarGeometryStub):
(WebCore::CCScrollbarGeometryStub::~CCScrollbarGeometryStub):
(WebCore::CCScrollbarGeometryStub::clone):
(WebCore::CCScrollbarGeometryStub::thumbPosition):
(WebCore::CCScrollbarGeometryStub::thumbLength):
(WebCore::CCScrollbarGeometryStub::trackPosition):
(WebCore::CCScrollbarGeometryStub::trackLength):
(WebCore::CCScrollbarGeometryStub::hasButtons):
(WebCore::CCScrollbarGeometryStub::hasThumb):
(WebCore::CCScrollbarGeometryStub::trackRect):
(WebCore::CCScrollbarGeometryStub::thumbRect):
(WebCore::CCScrollbarGeometryStub::minimumThumbLength):
(WebCore::CCScrollbarGeometryStub::scrollbarThickness):
(WebCore::CCScrollbarGeometryStub::backButtonStartRect):
(WebCore::CCScrollbarGeometryStub::backButtonEndRect):
(WebCore::CCScrollbarGeometryStub::forwardButtonStartRect):
(WebCore::CCScrollbarGeometryStub::forwardButtonEndRect):
(WebCore::CCScrollbarGeometryStub::constrainTrackRectToTrackPieces):
(WebCore::CCScrollbarGeometryStub::splitTrack):

  • platform/graphics/chromium/cc/CCScrollbarGeometryStub.h: Added.

(WebCore):
(CCScrollbarGeometryStub):
(WebCore::CCScrollbarGeometryStub::update):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::setScrollbarGeometry):
(WebCore::CCScrollbarLayerImpl::setScrollbarData):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(WebCore::CCScrollbarLayerImpl::scrollbarGeometry):
(CCScrollbarLayerImpl):

Source/WebKit/chromium:

Update test.

  • tests/CCLayerTreeHostImplTest.cpp:
1:46 PM Changeset in webkit [126790] by danakj@chromium.org
  • 8 edits
    1 add in trunk/Source

[chromium] Have RenderSurface create and add its own generated RenderPass
https://bugs.webkit.org/show_bug.cgi?id=94957

Reviewed by Adrienne Walker.

Source/WebCore:

Have CCRenderSurface create and add its RenderPass to the appropriate
data structures. Previously CCLayerTreeHostImpl had this responsibility
but this limits us to a single RenderPass per RenderSurface. In ubercomp
we have layers that generate many RenderPasses that all contribute to a
single RenderSurface. This target RenderSurface can create all the needed
RenderPasses in the correct order for itself when asked to now.

We invent CCRenderPassSink and make FrameData implement it, so that the
RenderSurface does not need to know the details of how the RenderPasses
it generates will be stored.

Test: CCRenderSurfaceTest.sanityCheckSurfaceCreatesCorrectRenderPass

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::FrameData::appendRenderPass):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(FrameData):

  • platform/graphics/chromium/cc/CCRenderPassSink.h: Added.

(WebCore):
(CCRenderPassSink):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendRenderPasses):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

Source/WebKit/chromium:

Test that a RenderSurface generates the RenderPass that we expect.

  • tests/CCRenderSurfaceTest.cpp:
1:39 PM Changeset in webkit [126789] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

ShadowRoot insertion point change aborts css transition
https://bugs.webkit.org/show_bug.cgi?id=93755

Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-27
Reviewed by Hajime Morita.

Source/WebCore:

ElementShadow always detaches shadow hosts when distribution is
changed, i.e. select attribute's value is changed. However it clears
the style of the shadow host. So when distribution is changed,
no css transition can be started at the same time. To avoid this
problem, invalidateDistribution, i.e. a method for invalidating current
distribution, should not make shadow host reattach. Instead, it should
make distribute nodes reattached and set needsRecalcStyle flag of
shadow host.

Test: transitions/transition-on-shadow-host-with-distributed-node.html

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::addShadowRoot):
To support replaced elements, i.e. IMG, and so on, shadow host's
renderer must be updated when author shadow roots are addded.
So invoke shadow host's reattach instead of shadowRoot's attach.
(WebCore::ElementShadow::invalidateDistribution):
Remove shadow host's lazy reattach (detach and lazyAttach). Instead, do
distributed nodes' lazy reattach and set shadow host's needsRecalcStyle
flag.

  • dom/Node.h:

(WebCore::Node::lazyReattach):
Newly added. The method works like Node::reattach, but use
lazyAttach instead of attach.
(WebCore):

LayoutTests:

  • fast/dom/shadow/transition-on-shadow-host-with-distributed-node-expected.txt: Added.
  • fast/dom/shadow/transition-on-shadow-host-with-distributed-node.html: Added.
  • platform/chromium-linux/fast/html/details-nested-2-expected.txt: Added, because of changing the code about adding shadow root.
  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/mac/fast/html/details-nested-2-expected.txt: Rebased, because of changing the code about adding shadow root.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Rebased.
1:32 PM Changeset in webkit [126788] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Free Url_Bar on program exit
https://bugs.webkit.org/show_bug.cgi?id=95086

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-27
Reviewed by Eric Seidel.

Fix a memory leak by freeing the Url_Bar on program exit.

  • MiniBrowser/efl/main.c:

(main): Call url_bar_del() to free the Url_Bar.

1:20 PM Changeset in webkit [126787] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[Chromium] Fixing infinite recursion in Canvas2DLayerManager
https://bugs.webkit.org/show_bug.cgi?id=95110

Patch by Justin Novosad <junov@chromium.org> on 2012-08-27
Reviewed by Stephen White.

Source/WebCore:

Fixed infinite recursion by not reporting a change in memory allocation
when Canvas2DLayerBridge::freeMemoryIfPossible fails to free memory.
Also modified Canvas2DLayerManager::layerAllocatedStorageChanged to
only initiate a memory eviction pass if memory consumption has
increased.

Test: webkit_unit_tests Canvas2DLayerManagerTest*

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::freeMemoryIfPossible):

  • platform/graphics/chromium/Canvas2DLayerManager.cpp:

(WebCore::Canvas2DLayerManager::layerAllocatedStorageChanged):

Source/WebKit/chromium:

Breaking recursion cycle by not reporting a change in memory allocation
when no memory is freed in FakeCanvas2DLayer::freeMemoryIfPossible.

  • tests/Canvas2DLayerManagerTest.cpp:
1:12 PM Changeset in webkit [126786] by annacc@chromium.org
  • 23 edits in trunk

TextTrack modes are strings
https://bugs.webkit.org/show_bug.cgi?id=85050

Reviewed by Eric Carlson.

The spec recently changed away from enumeration to string for the type
of TextTrack mode.
http://dev.w3.org/html5/spec/media-elements.html#texttrackmode

Source/WebCore:

No new tests. Updates to existing tests.

  • html/HTMLMediaElement.cpp:

Use the new string mode rather than the old enum. Also, TextTrack::setMode()
no longer requires an ExceptionCode:
(WebCore::HTMLMediaElement::loadInternal):
(WebCore::HTMLMediaElement::textTrackModeChanged):
(WebCore::HTMLMediaElement::textTrackKindChanged):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::showingTrackWithSameKind):
(WebCore::HTMLMediaElement::configureTextTrackGroup):
(WebCore::HTMLMediaElement::configureNewTextTracks):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):

  • html/track/TextTrack.cpp:

Update these methods to use ConstructFromLiteral for efficiency:
(WebCore::TextTrack::subtitlesKeyword):
(WebCore::TextTrack::captionsKeyword):
(WebCore::TextTrack::descriptionsKeyword):
(WebCore::TextTrack::chaptersKeyword):
(WebCore::TextTrack::metadataKeyword):

New methods to use for the mode string (replacing the enum):
(WebCore::TextTrack::disabledKeyword):
(WebCore::TextTrack::hiddenKeyword):
(WebCore::TextTrack::showingKeyword):

(WebCore::TextTrack::TextTrack): Initialize mode to disabled.
(WebCore::TextTrack::setMode): Remove ExceptionCode and no longer throw an
INVALID_ACCESS_ERR.
(WebCore::TextTrack::mode): Return a keyword string instead of an enum.

Use the new string mode rather than the old enum:
(WebCore::TextTrack::cues):
(WebCore::TextTrack::activeCues):
(WebCore::TextTrack::isRendered):

  • html/track/TextTrack.h: Remove old enum, add new string keyword methods,

and update mode() and setMode() accordingly.

  • html/track/TextTrack.idl: Remove old enum and make mode attribute be a string.

Use the new string mode rather than the old enum:

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::dispatchEvent):
(WebCore::TextTrackCue::isActive):

LayoutTests:

Remove check for mode constants as we are no longer using an enum:

  • media/track/track-constants-expected.txt:
  • media/track/track-constants.html:

Update tests to use the new strings rather than the enums:

  • media/track/track-delete-during-setup-expected.txt:
  • media/track/track-delete-during-setup.html:
  • media/track/track-element-dom-change-crash-expected.txt:
  • media/track/track-element-dom-change-crash.html:
  • media/track/track-load-from-src-readyState.html:
  • media/track/track-mode-expected.txt:
  • media/track/track-mode-not-changed-by-new-track-expected.txt:
  • media/track/track-mode-not-changed-by-new-track.html:
  • media/track/track-mode-triggers-loading-expected.txt:
  • media/track/track-mode-triggers-loading.html:
  • media/track/track-mode.html:
  • media/track/track-texttracks-expected.txt:
  • media/track/track-texttracks.html:
  • media/video-test.js:

(enableAllTextTracks):

1:08 PM Changeset in webkit [126785] by commit-queue@webkit.org
  • 10 edits
    6 adds in trunk

'self' in a CSP directive should match blob: and filesystem: URLs.
https://bugs.webkit.org/show_bug.cgi?id=94918

Patch by Mike West <mkwst@chromium.org> on 2012-08-27
Reviewed by Adam Barth.

Source/WebCore:

'blob:' and 'filesystem:' URLs are same-origin with the page on which
they were created. Currently, we're using the wrong URL for comparison
when matching against CSP directive source lists. This patch adjusts the
matching logic to compare against the blob's inner URL, rather than
directly against the blob itself.

Tests: http/tests/security/contentSecurityPolicy/blob-urls-match-self.html

http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html
http/tests/security/contentSecurityPolicy/source-list-parsing-08.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPSourceList::matches):

If we should use the inner URL of a given resource, extract it into
a local variable, and pass that into CSPSource for comparison.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::shouldUseInnerURL):
(WebCore::SecurityOrigin::extractInnerURL):

Move shouldUseInnerURL and extractInnerURL to SecurityOrigin's
public signature.

(WebCore::shouldTreatAsUniqueOrigin):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::isSecure):

shouldUseInnerURL and extractInnerURL are now static methods of
SecurityOrigin: updating calls to mathc.

  • page/SecurityOrigin.h:

LayoutTests:

  • http/tests/security/contentSecurityPolicy/blob-urls-match-self-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/blob-urls-match-self.html: Added.
  • http/tests/security/contentSecurityPolicy/filesystem-urls-match-self-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html: Added.

Test the new functionality.

  • http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:

(test):

Adding support for data: URLs.

  • http/tests/security/contentSecurityPolicy/source-list-parsing-08-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/source-list-parsing-08.html: Added.

Adding data: URL tests to ensure that grabbing the inner URL of the
URL to test doesn't inadvertently regress that behavior.

  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

Skipping filessytem test on ports where it's not enabled.

12:23 PM EfficientStrings edited by benjamin@webkit.org
(diff)
12:16 PM Changeset in webkit [126784] by jamesr@google.com
  • 2 edits in trunk/Tools

[chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
https://bugs.webkit.org/show_bug.cgi?id=95115

Reviewed by Adam Barth.

Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
code if the unit tests crash.

  • Scripts/run-chromium-webkit-unit-tests:
12:06 PM Changeset in webkit [126783] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix compilation when both OS(WINCE) and PLATFORM(QT) are true
https://bugs.webkit.org/show_bug.cgi?id=95050

Patch by Kevin Funk <kevin.funk@kdab.com> on 2012-08-27
Reviewed by Simon Hausmann.

The compilation of NativeImagePtr.h breaks when both OS(WINCE) and PLATFORM(QT) are enabled.
This patch fixes this.

  • platform/graphics/NativeImagePtr.h:
12:01 PM Changeset in webkit [126782] by Simon Fraser
  • 4 edits in trunk/LayoutTests

Fix some more sticky ref tests; avoid wrapping at the 800px
window width, and remove a margin:auto from a reference.

  • fast/css/sticky/sticky-margins-expected.html:
  • fast/css/sticky/sticky-margins.html:
  • fast/css/sticky/sticky-writing-mode-vertical-lr-expected.html:
11:57 AM Changeset in webkit [126781] by benjamin@webkit.org
  • 12 edits in trunk

Add ECMAScript Number to String conversion to WTF::String
https://bugs.webkit.org/show_bug.cgi?id=95016

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Rename UString::number(double) to UString::numberToStringECMAScript(double) to
differenciate it from the fixed-width conversion performed by String::number().

  • parser/ParserArena.h:

(JSC::IdentifierArena::makeNumericIdentifier):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):

  • runtime/NumericStrings.h:

(JSC::NumericStrings::add):

  • runtime/UString.cpp:

(JSC::UString::numberToStringECMAScript):

  • runtime/UString.h:

(UString):

Source/WTF:

  • wtf/text/WTFString.cpp:

(WTF::String::numberToStringECMAScript):

  • wtf/text/WTFString.h:

Add the implementation of numberToStringECMAScript(double) from UString to String.
This will make it easier to replace UString in the future.

Tools:

  • TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::testNumberToStringECMAScript):
(TestWebKitAPI): Add tests for String's ECMAString number conversion.

11:55 AM Changeset in webkit [126780] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Even up WTF::String to CString functions
https://bugs.webkit.org/show_bug.cgi?id=95008

Reviewed by Sam Weinig.

Apply advantages from UString to WTF::String.

  • wtf/text/WTFString.cpp:

(WTF::String::ascii): There is no need to special case the null length, both
following branches use CString::newUninitialized(), which create empty string
for null length.
(WTF::String::latin1): Use characters16() instead of characters() to avoid
testing is8Bit() a second time.

11:54 AM Changeset in webkit [126779] by tommyw@google.com
  • 12 edits in trunk

MediaStream API: Fix review comments from patch #93119
https://bugs.webkit.org/show_bug.cgi?id=95064

Reviewed by Adam Barth.

Source/WebCore:

Adding const to accessors.

Change covered by exisiting tests..

  • Modules/mediastream/RTCIceCandidate.cpp:

(WebCore::RTCIceCandidate::candidate):
(WebCore::RTCIceCandidate::sdpMid):
(WebCore::RTCIceCandidate::sdpMLineIndex):

  • Modules/mediastream/RTCIceCandidate.h:

(RTCIceCandidate):

  • Modules/mediastream/RTCSessionDescription.cpp:

(WebCore::RTCSessionDescription::create):
(WebCore::RTCSessionDescription::type):
(WebCore::RTCSessionDescription::sdp):

  • Modules/mediastream/RTCSessionDescription.h:

(RTCSessionDescription):

LayoutTests:

  • fast/mediastream/RTCIceCandidate-expected.txt:
  • fast/mediastream/RTCIceCandidate.html:
  • fast/mediastream/RTCSessionDescription-expected.txt:
  • fast/mediastream/RTCSessionDescription.html:
  • fast/mediastream/constructors-expected.txt:
  • fast/mediastream/constructors.html:
11:38 AM Changeset in webkit [126778] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Fix sticky-position test to hide scrollbars.

  • fast/css/sticky/sticky-side-margins-expected.html:
  • fast/css/sticky/sticky-side-margins.html:
11:36 AM Changeset in webkit [126777] by Simon Fraser
  • 7 edits in trunk/Source

Make Force Repaint work with tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=95102

Reviewed by Dan Bernstein.

Source/WebCore:

forceRepaint() didn't work correctly with tiled backing
store, because it never actually caused a repaint on the tiles.

Fix by having the drawing area call forceRepaint() on
the TileCache (via the TiledBacking interface), which
just ends up as a setNeedsDisplay().

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::forceRepaint):

Source/WebKit2:

Have forceRepaint() call down to the tiled backing of each FrameView,
so they can repaint.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::forceRepaint):

11:05 AM Changeset in webkit [126776] by victor@rosedu.org
  • 3 edits
    2 adds in trunk

Crash when trying to render empty cues
https://bugs.webkit.org/show_bug.cgi?id=94776

Reviewed by Eric Carlson.

Added extra safety checks.

Source/WebCore:

Test: media/track/track-cue-rendering-empty-cue-crash.html

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::getCueAsHTML):
(WebCore::TextTrackCue::updateDisplayTree):

LayoutTests:

  • media/track/track-cue-rendering-empty-cue-crash-expected.txt: Added.
  • media/track/track-cue-rendering-empty-cue-crash.html: Added.
10:56 AM Changeset in webkit [126775] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

  • platform/chromium/TestExpectations:

Marked fast/text/atsui-bidi-control.html as timing out on SnowLeopard.

10:39 AM Changeset in webkit [126774] by Simon Fraser
  • 17 edits
    30 adds in trunk

Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Source/WebCore:

Initial implementation of position: -webkit-sticky, which
constrains an element to be positioned inside the intersection
of its container box, and the viewport. Sticky elements create
stacking context.

A stickily positioned element behaves like position:relative
(space is reserved for it in-flow), but with an offset that is
determined by the sticky position. Changed isInFlowPositioned()
to cover relative and sticky.

Added a convenience isPositioned() to RenderObject(), which
is true for an object with any non-static position value.

Tests: fast/css/sticky/inflow-sticky.html

fast/css/sticky/inline-sticky-abspos-child.html
fast/css/sticky/inline-sticky.html
fast/css/sticky/replaced-sticky.html
fast/css/sticky/sticky-as-positioning-container.html
fast/css/sticky/sticky-left-percentage.html
fast/css/sticky/sticky-left.html
fast/css/sticky/sticky-margins.html
fast/css/sticky/sticky-side-margins.html
fast/css/sticky/sticky-stacking-context.html
fast/css/sticky/sticky-top-margins.html
fast/css/sticky/sticky-top.html
fast/css/sticky/sticky-writing-mode-horizontal-bt.html
fast/css/sticky/sticky-writing-mode-vertical-lr.html
fast/css/sticky/sticky-writing-mode-vertical-rl.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): Have position:sticky
create stacking context from the get-go, to make scrolling optimizations easier later.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath): Use hasViewportConstrainedPosition().

  • page/FrameView.h: FrameView's "fixed" objects contains both fixed and sticky objects now.
  • rendering/RenderBlock.cpp: Use isPositioned().

(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::renderName):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange): Need to look for both stick and fixed positioning to
determine whether to add something to FrameView's fixed object set.
(WebCore::RenderBox::computeRectForRepaint): Need to take the sticky offset into account
when computing repaint rects.

  • rendering/RenderBox.h: Implement frameRectForStickyPositioning() for boxes.
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):
(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):
(WebCore::RenderBoxModelObject::stickyPositionOffset): Compute the sticky position
offset by taking into account the viewport rect, and the conteriner's contentRect
inset by its margins.
(WebCore::RenderBoxModelObject::offsetForInFlowPosition): Convenience wrapper
for getting relative or sticky offset.

  • rendering/RenderBoxModelObject.h: Have requiresLayer() use isPositioned().

(WebCore::RenderBoxModelObject::stickyPositionLogicalOffset):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::styleWillChange): Need to implement this to
add/remove objects from FrameView's fixed object list, since, prior to sticky,
only boxes could be fixed.
(WebCore::RenderInline::renderName):
(WebCore::RenderInline::positionForPoint):
(WebCore::RenderInline::computeRectForRepaint):

  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Have to look for fixed or sticky.
(WebCore::RenderLayer::calculateClipRects): Use isPositioned().
(WebCore::RenderLayer::shouldBeNormalFlowOnly): Ditto.

  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::propagateStyleToAnonymousChildren): Should use isInFlowPositioned(),
not just isRelPositioned().
(WebCore::RenderObject::offsetParent): Use isPositioned().

  • rendering/RenderObject.h:

(WebCore::RenderObject::isInFlowPositioned):
(WebCore::RenderObject::isStickyPositioned):
(WebCore::RenderObject::setStickyPositioned):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):

  • rendering/RenderStyle.h: add hasViewportConstrainedPosition() for fixed or sticky position.

LayoutTests:

Various ref tests for sticky positioning.

  • fast/css/sticky/inflow-sticky-expected.html: Added.
  • fast/css/sticky/inflow-sticky.html: Added.
  • fast/css/sticky/inline-sticky-abspos-child-expected.html: Added.
  • fast/css/sticky/inline-sticky-abspos-child.html: Added.
  • fast/css/sticky/inline-sticky-expected.html: Added.
  • fast/css/sticky/inline-sticky.html: Added.
  • fast/css/sticky/replaced-sticky-expected.html: Added.
  • fast/css/sticky/replaced-sticky.html: Added.
  • fast/css/sticky/sticky-as-positioning-container-expected.html: Added.
  • fast/css/sticky/sticky-as-positioning-container.html: Added.
  • fast/css/sticky/sticky-left-expected.html: Added.
  • fast/css/sticky/sticky-left-percentage-expected.html: Added.
  • fast/css/sticky/sticky-left-percentage.html: Added.
  • fast/css/sticky/sticky-left.html: Added.
  • fast/css/sticky/sticky-margins-expected.html: Added.
  • fast/css/sticky/sticky-margins.html: Added.
  • fast/css/sticky/sticky-side-margins-expected.html: Added.
  • fast/css/sticky/sticky-side-margins.html: Added.
  • fast/css/sticky/sticky-stacking-context-expected.html: Added.
  • fast/css/sticky/sticky-stacking-context.html: Added.
  • fast/css/sticky/sticky-top-expected.html: Added.
  • fast/css/sticky/sticky-top-margins-expected.html: Added.
  • fast/css/sticky/sticky-top-margins.html: Added.
  • fast/css/sticky/sticky-top.html: Added.
  • fast/css/sticky/sticky-writing-mode-horizontal-bt-expected.html: Added.
  • fast/css/sticky/sticky-writing-mode-horizontal-bt.html: Added.
  • fast/css/sticky/sticky-writing-mode-vertical-lr-expected.html: Added.
  • fast/css/sticky/sticky-writing-mode-vertical-lr.html: Added.
  • fast/css/sticky/sticky-writing-mode-vertical-rl-expected.html: Added.
  • fast/css/sticky/sticky-writing-mode-vertical-rl.html: Added.
10:09 AM Changeset in webkit [126773] by timothy@apple.com
  • 2 edits in branches/safari-536.26-branch/Source/WTF

Log-to-a-file should not be enabled
<rdar://problem/12172462>

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-08-24
Reviewed by Mark Hahnenberg.

  • wtf/DataLog.cpp:
10:06 AM Changeset in webkit [126772] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Not using absoluteVisibleOverSize when rotating
https://bugs.webkit.org/show_bug.cgi?id=95092
PR #190469

Patch by Leo Yang <leoyang@rim.com> on 2012-08-27
Reviewed by Antonio Gomes.
Reviewed internally by Arvid Nilsson.

When we are rotating don't count absolute overflow visible size
into fixed layout size because we are in a transient state. The
absolute overflow visible size remains old size during rotation.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):

10:04 AM Changeset in webkit [126771] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix typo in CoordinatedGraphicsLayer::syncAnimatedProperties
https://bugs.webkit.org/show_bug.cgi?id=95085

Reviewed by Noam Rosenthal.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp: The flag should be disabled

once we process the sync for animated properties. Previously, it was never disabling it once enabled.

9:16 AM Changeset in webkit [126770] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed Mac Chromium build fix after r126763.

  • platform/graphics/Font.cpp:
8:51 AM Changeset in webkit [126769] by rwlbuis@webkit.org
  • 2 edits in trunk

[BlackBerry] remove -fno-rtti option in CMAKE_C_FLAGS
https://bugs.webkit.org/show_bug.cgi?id=95089

Reviewed by Antonio Gomes.

This option does not make sense for compiling C and gives a warning.

  • Source/cmake/OptionsBlackBerry.cmake:
8:50 AM Changeset in webkit [126768] by tonikitoo@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove the 'in region scrollable starting node' concept from InRegionScroller
https://bugs.webkit.org/show_bug.cgi?id=95020

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

'In-region start scrolling node' is an obsolete concept, and we can remove it
in favor of using the information from the cached layers.

  • Api/InRegionScroller.cpp:

(WebKit):
(BlackBerry::WebKit::InRegionScrollerPrivate::reset): Adjusted as it used to clear
the cached 'node'.
(BlackBerry::WebKit::InRegionScrollerPrivate::isActive): Added method to be
checked directly instead of only null-checking the previously cached 'node'.
(BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData): New method to
clear the cached resources if its document is done.
(BlackBerry::WebKit::InRegionScrollerPrivate::pushBackInRegionScrollable): Adjusted
to not care about the cached 'node' anymore.

  • Api/InRegionScroller_p.h:

(InRegionScrollerPrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped): Check ::isActive instead
of ::hasNode, since the later is gone.
(BlackBerry::WebKit::WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableAreaAfterInRegionScrolling):
Changed the method signature, given that we do have a cached 'node' to pass in as parameter anymore.
(BlackBerry::WebKit::WebPagePrivate::clearDocumentData): Delegate all the related work to InRegionScroller.

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

8:49 AM Changeset in webkit [126767] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

BlackBerry] Shrink the in-region nested scrollable list as soon as we can
https://bugs.webkit.org/show_bug.cgi?id=95019

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

We cache all possible nested scrollable in-region layers given a point.
It is up to the client to pick a view, based on the scroll position and limits
of each layer, and on the diretion user swipes its finger.
From the point we pick a view on, we stick with it, and any other
possibly cached layer can be uncached, as it won't be needed.
Patch providesa simple solution to that.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::InRegionScrollerPrivate):
(BlackBerry::WebKit::InRegionScrollerPrivate::reset):
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateActiveAndShrinkCachedScrollableAreas):
(WebKit):
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):

  • Api/InRegionScroller_p.h:

(InRegionScrollerPrivate):

8:49 AM Changeset in webkit [126766] by tonikitoo@webkit.org
  • 4 edits in trunk/Source

For convenience, make RenderLayer::enclosingElement a public method.
https://bugs.webkit.org/show_bug.cgi?id=95018

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

Source/WebCore:
It can be useful for outsiders of this class.

No new tests needed.

  • rendering/RenderLayer.h:

(RenderLayer):

Source/WebKit/blackberry:

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea): Make use
of the new public RenderLayer::enclosingElement method and remove duplicated code.

8:46 AM Changeset in webkit [126765] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: display a dimmed warning icon on a timeline record if it has children with warning
https://bugs.webkit.org/show_bug.cgi?id=95087

Reviewed by Yury Semikhatsky.

Propagate warning from child timeline records to the top, display a dimmed warning icons for records
that have children with warnings.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineRecordListRow.prototype.update):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.get aggregatedStats):
(WebInspector.TimelinePresentationModel.Record.prototype.setHasWarning):

  • inspector/front-end/timelinePanel.css:

(.timeline-tree-item.child-warning::after):

8:43 AM Changeset in webkit [126764] by vsevik@chromium.org
  • 9 edits
    2 adds in trunk

Web Inspector: Debugger should break on failed assertions in Break on exceptions mode.
https://bugs.webkit.org/show_bug.cgi?id=95088

Reviewed by Yury Semikhatsky.

Source/WebCore:

Debugger now breaks when assert message is added to console from console API.

Test: inspector/debugger/debugger-pause-on-failed-assertion.html

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::addMessageToConsole):
(WebCore):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):

  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/ScriptsPanel.js:

LayoutTests:

  • inspector/debugger/debugger-pause-on-failed-assertion-expected.txt: Added.
  • inspector/debugger/debugger-pause-on-failed-assertion.html: Added.
8:31 AM Changeset in webkit [126763] by mitz@apple.com
  • 8 edits in trunk/Source/WebCore

Improve line breaking performance for complex text
https://bugs.webkit.org/show_bug.cgi?id=83045

Patch by Ned Holbrook <nholbrook@apple.com> on 2012-08-27
Reviewed by Darin Adler.

Currently RenderBlock::LineBreaker::nextLineBreak assumes that measuring individual words is as cheap
as free. This is not the case when dealing with complex text, which benefits from laying out as much
text as possible and by reusing that layout when feasible: by doing so this patch improves line
breaking by 25% as measured with a simple test app.

The bulk of this change is modifying ComplexTextController::advance, which previously required the
text offset to be strictly increasing and assumed unidirectional text; now it supports random seeking
in a naive fashion (by restarting to the beginning) and traverses glyphs in logical order. In the
latter case, the presence of any non-LTR runs triggers the population of a mapping from logical to
visual run indices. Finally, a new flag has been added which inhibits glyph advances from being split
across ligatures (thus causing spurious line breaks).

A ComplexTextController and its associated TextRun and Font are encapsulated in a TextLayout object,
which is instantiated as an opaque object via functions that are no-ops unless building for Mac. A
static member function (isNeeded) checks to see whether a TextRun is complex, in order to avoid
needless instantiation. It also bails if tabs would be enabled since positional effects are not yet
handled in this mode.

No behavioral changes are expected due to this change, so no new tests.

  • platform/graphics/Font.cpp:

(WTF): Define deleteOwnedPtr for TextLayout as calling through destroyLayout; relying on operator delete is not workable as the class does not exist on all platforms.
(WTF::WebCore::TextLayout):
(WebCore): Implement no-op TextLayout wrappers for non-Mac platforms.
(WebCore::Font::createLayout):
(WebCore::Font::deleteLayout):
(WebCore::Font::width):

  • platform/graphics/Font.h:

(WebCore): Add forward declarations for RenderText and TextLayout.
(Font): Add functions for dealing with pointer to TextLayout implementation.
(WTF): Declare deleteOwnedPtr for TextLayout.

  • platform/graphics/mac/ComplexTextController.cpp:

(TextLayout): An instance of this class corresponds to a ComplexTextController for a particular TextRun.
(WebCore::TextLayout::isNeeded): Used by wrapper to avoid instantiation when complex layout is not required.
(WebCore::TextLayout::TextLayout):
(WebCore::TextLayout::width):
(WebCore::TextLayout::fontWithNoWordSpacing): Helper function to allow initialization of member variable.
(WebCore::TextLayout::constructTextRun): Ditto.
(WebCore): Implement real TextLayout wrappers for Mac.
(WebCore::Font::createLayout):
(WebCore::Font::deleteLayout):
(WebCore::Font::width):
(WebCore::ComplexTextController::ComplexTextController): Initialize m_ltrOnly and reserve initial capacity for m_runIndices.
(WebCore::ComplexTextController::indexOfCurrentRun): Return (visual) m_complexTextRuns index corresponding to (logical) m_currentRun, lazily constructing m_runIndices if needed.
(WebCore::ComplexTextController::incrementCurrentRun): Return next m_complexTextRuns index in logical order.
(WebCore::ComplexTextController::advance): Allow restarting, support for bidi reordering, and option to measure only whole glyphs rather than dividing advances.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Clear m_ltrOnly on detecting a RTL run.

  • platform/graphics/mac/ComplexTextController.h:

(ComplexTextController): Add m_ltrOnly indicating no bidi reordering, and m_runIndices mapping from runs (logical order) to m_complexTextRuns (visual order).
(WebCore::ComplexTextController::ComplexTextRun::indexBegin):
(WebCore::ComplexTextController::ComplexTextRun::isLTR):
(ComplexTextRun): Add helper functions returning values pertinent to individual runs as opposed to the entire containing line.
(WebCore::ComplexTextController::stringBegin): Return first string index.
(WebCore::ComplexTextController::stringEnd): Return one past last string index.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm: Initialize m_indexBegin and m_ltr.

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_indexBegin and m_ltr.

  • rendering/RenderBlock.h:

(RenderTextInfo): Add single mapping from RenderText to LazyLineBreakIterator and (possibly null) TextLayout since they are recreated under the same circumstances.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::RenderTextInfo::RenderTextInfo): Make non-inline to avoid compilation errors.
(WebCore::RenderBlock::RenderTextInfo::~RenderTextInfo): Ditto.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Allow RenderTextInfo to be reused across calls to nextLineBreak.
(WebCore::textWidth): Use TextLayout when supplied for measuring.
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

7:52 AM Changeset in webkit [126762] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

Add two missing variable initializers to RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=95048

Reviewed by Julien Chaffraix.

The m_dispatchRegionLayoutUpdateEvent change is needed to fix this
valgrind warning:
Conditional jump or move depends on uninitialised value(s)

WebCore::RenderFlowThread::layout() (third_party/WebKit/Source/WebCore/rendering/RenderFlowThread.cpp:189)
WebCore::RenderObject::layoutIfNeeded() (third_party/WebKit/Source/WebCore/rendering/RenderObject.h:647)
WebCore::FlowThreadController::layoutRenderNamedFlowThreads() (third_party/WebKit/Source/WebCore/rendering/FlowThreadController.cpp:124)
WebCore::RenderView::layout() (third_party/WebKit/Source/WebCore/rendering/RenderView.cpp:159)
WebCore::FrameView::layout(bool) (third_party/WebKit/Source/WebCore/page/FrameView.cpp:1154)
WebCore::FrameView::layoutTimerFired(WebCore::Timer<WebCore::FrameView>*) (third_party/WebKit/Source/WebCore/page/FrameView.cpp:2074)
WebCore::Timer<WebCore::FrameView>::fired() (third_party/WebKit/Source/WebCore/platform/Timer.h:100)
WebCore::ThreadTimers::sharedTimerFiredInternal() (third_party/WebKit/Source/WebCore/platform/ThreadTimers.cpp:115)
WebCore::ThreadTimers::sharedTimerFired() (third_party/WebKit/Source/WebCore/platform/ThreadTimers.cpp:93)
webkit_glue::WebKitPlatformSupportImpl::DoTimeout() (./webkit/glue/webkitplatformsupport_impl.h:163)

The report came from the fast/regions/absolute-pos-elem-in-named-flow.html'--pixel-test test.

m_dispatchRegionLayoutUpdateEvent was added in https://bugs.webkit.org/show_bug.cgi?id=88778
by abucur, reviewed by abarth.

While here, also initialize m_hasRegionsWithStyling, added in https://bugs.webkit.org/show_bug.cgi?id=85633
by mihnea, reviewed by hyatt.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):

7:50 AM Changeset in webkit [126761] by Hugo Parente Lima
  • 3 edits
    1 move
    1 add in trunk/LayoutTests

[Qt] fast/url/path.html with Qt5 differ results on both WK1 and WK2
https://bugs.webkit.org/show_bug.cgi?id=77380

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt-4.8/fast/url/path-expected.txt: Renamed from LayoutTests/platform/qt/fast/url/path-expected.txt.
  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0/Skipped:
7:27 AM Changeset in webkit [126760] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk/Source

[Chromium] Implementing a global limit on memory consumed by deferred 2D canvases
https://bugs.webkit.org/show_bug.cgi?id=94386

Patch by Justin Novosad <junov@chromium.org> on 2012-08-27
Reviewed by Stephen White.

Source/WebCore:

Before this change, there was no global bound on memory that could be
consumed for the purpose of recording 2d canvas deferred draw commands.
There was only a per canvas limit. It is possible for canvases to get
dereferenced without flushing pending draw commands, which may lock
resources until the canvas element is garbage collected. This makes
it possible to grow memory consumption indefinitely by hitting reload
successively on some canvas-intensive web pages.

The solution implemented in this change consists in maintaining a
global registry of deferred canvas layers and tracking the sum of
memory allocated by all canvases for the purpose of storing deferred
draw commands. When memory consumption reaches the allowed limit,
caches are cleared and draw operations are flushed on one or several
canvases, starting with the least recently used, until memory
consumption is below a target level.

New tests: webkit_unit_tests DeferredLayerManagerTest*

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecordingChanged):
Overloaded from SkDeferredCanvas::NotificationClient. Called when
there is a change in the number of bytes allocated by the deferred
canvas.
(WebCore):
(WebCore::Canvas2DLayerBridge::flushedDrawCommands):
Overloaded from SkDeferredCanvas::NotificationClient. Called when
pending draw commands are flush by the deferred canvas.
(WebCore::Canvas2DLayerBridge::freeMemoryIfPossible):
Called by the Canvas2DLayerManager to request the release of unlocked
memory resources (caches). Request is relayed to SkDeferredCanvas.
returns number of bytes freed.
(WebCore::Canvas2DLayerBridge::flush):
Requests that pending draw commands be flushed immediately from the
deferred canvas queue. Request is relayed to SkDeferredCanvas.
(WebCore::Canvas2DLayerBridge::contextAcquired):

  • platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::bytesAllocated):
(WebCore::Canvas2DLayerBridge::updateBytesAllocated):

  • platform/graphics/chromium/Canvas2DLayerManager.cpp: Added.

(WebCore):
(WebCore::Canvas2DLayerManager::Canvas2DLayerManager):
(WebCore::Canvas2DLayerManager::~Canvas2DLayerManager):
(WebCore::Canvas2DLayerManager::init):
Sets the global limit for the maximum total number of bytes allocated
by deferred layers.
(WebCore::Canvas2DLayerManager::get):
Singleton accessor
(WebCore::Canvas2DLayerManager::layerDidDraw):
Called by Canvas2DLayerBridge to indicate that the layer was drawn to.
(WebCore::Canvas2DLayerManager::addLayerToList):
(WebCore::Canvas2DLayerManager::layerAllocatedStorageChanged):
Called by Canvas2DLayerBridge to indicate thet the memory consumed by
the layer has changed.
(WebCore::Canvas2DLayerManager::layerDidFlush):
Called by Canvas2DLayerBridge to indicated that the pending draw
commands of the layer were flushed.
(WebCore::Canvas2DLayerManager::layerToBeDestroyed):
Called by Canvas2DLayerBridge upon destruction.
(WebCore::Canvas2DLayerManager::freeMemoryIfNecessary):
Called internally. Check that current memory consumption is below
the tolerated limit. If check fails, intiates resource releases.
(WebCore::Canvas2DLayerManager::removeLayerFromList):
(WebCore::Canvas2DLayerManager::isInList):
(WebCore::Canvas2DLayerManager::updateBytesAllocated):

  • platform/graphics/chromium/Canvas2DLayerManager.h: Added.

(WebCore):
(Canvas2DLayerManager):

Source/WebKit/chromium:

Adding unit tests for WebCore::Canvas2DLayerManager

  • WebKit.gypi:
7:20 AM Changeset in webkit [126759] by zeno.albisser@nokia.com
  • 6 edits in trunk/Source/WebCore

Implement GraphicsSurface::paintToTextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=95077

Forward paintToTextureMapper call directly into
GraphicsSurface. This allows getting rid of platform
specific code in TextureMapperSurfaceBackingStore.

Reviewed by Noam Rosenthal.

  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::paintToTextureMapper):
(WebCore):

  • platform/graphics/surfaces/GraphicsSurface.h:

(WebCore):
(GraphicsSurface):

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore):

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):

7:15 AM Changeset in webkit [126758] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: filter out weak references from retainers tree
https://bugs.webkit.org/show_bug.cgi?id=95082

Reviewed by Yury Semikhatsky.

Weak references don't retain objects.

  • inspector/front-end/HeapSnapshotGridNodes.js:
7:08 AM Changeset in webkit [126757] by Philippe Normand
  • 1 edit
    2 adds in trunk/Source/WebCore

[GStreamer][Qt] WebAudio support
https://bugs.webkit.org/show_bug.cgi?id=94806

Reviewed by Simon Hausmann.

Build fix after r126756 in which I forgot to add the new
AudioBusQt.cpp file.

  • platform/audio/qt/AudioBusQt.cpp: Added.

(WebCore):
(WebCore::AudioBus::loadPlatformResource):

7:01 AM Changeset in webkit [126756] by Philippe Normand
  • 13 edits in trunk

[GStreamer][Qt] WebAudio support
https://bugs.webkit.org/show_bug.cgi?id=94806

Reviewed by Simon Hausmann.

Source/WebCore:

Build system changes to support WebAudio and its GStreamer
backend. A new AudioBusQt implementation is also needed to locate
and load local .wav files. Note: WebAudio is still disabled by default in
build-webkit. Use --web-audio to explicitely enable it at build time.

  • DerivedSources.pri:
  • Target.pri:
  • WebCore.pri:
  • WebCore.qrc:
  • platform/audio/HRTFElevation.cpp:

(WebCore): Use concatenated HRTF impulse response for increased
performance, just like GTK, Mac and EFL ports.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp: Undef the

signals macro so gio.h can be properly included.

  • platform/audio/qt/AudioBusQt.cpp: Added.

(WebCore):
(WebCore::AudioBus::loadPlatformResource):

Source/WebKit2:

New boolean webAudioEnabled WebSetting to be used at runtime to
toggle WebAudio support on or off.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::webAudioEnabled):
(QWebPreferences::setWebAudioEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:

Tools:

  • MiniBrowser/qt/qml/BrowserWindow.qml: Enable WebAudio support.
6:59 AM Changeset in webkit [126755] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r126524): Heap-buffer-overflow in WebCore::StylePropertySet::copyPropertiesFrom
<http://webkit.org/b/95005>

Reviewed by Antti Koivisto.

Remove incorrect assertion that the StylePropertySet is empty before properties are copied
into it, as this is no guarantee in editing code.
This regressed when splitting the code into mutable/immutable paths. Covered by assertions
on existing tests.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::copyPropertiesFrom):

6:52 AM Changeset in webkit [126754] by caseq@chromium.org
  • 14 edits in trunk

Web Inspector: display cause for style recalculation and layout on Timeline
https://bugs.webkit.org/show_bug.cgi?id=95000

Reviewed by Pavel Feldman.

Source/WebCore:

Added instrumentation for didInvalidateLayout and didScheduleStyleRecalculation;
Dispaly stacks of the above records in Layout and Recalculate Style as "call site" stacks (need a better wording?);
Display synchronous Layout records in red, provide a warning that these may affect performance;

  • English.lproj/localizedStrings.js: +"Note" and a warning test for sync layout;
  • inspector/InspectorInstrumentation.cpp: Plumbing new instrumentation methods through to timeline;

(WebCore):
(WebCore::InspectorInstrumentation::didInvalidateLayoutImpl):
(WebCore::InspectorInstrumentation::didScheduleStyleRecalculationImpl):

  • inspector/InspectorInstrumentation.h: ditto.

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didInvalidateLayout):
(WebCore):

  • inspector/InspectorTimelineAgent.cpp: ditto.

(TimelineRecordType):
(WebCore::InspectorTimelineAgent::didInvalidateLayout):
(WebCore):
(WebCore::InspectorTimelineAgent::didScheduleStyleRecalculation):

  • inspector/InspectorTimelineAgent.h: ditto.

(InspectorTimelineAgent):

  • inspector/front-end/TimelineModel.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineRecordListRow.prototype.update): Display records with warnings in their own style;

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel._initRecordStyles): Renamed, added new records;
(WebInspector.TimelinePresentationModel.recordStyle): Added new records;
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype._innerAddRecord): Add support for new records, make 'em hidden;
(WebInspector.TimelinePresentationModel.Record): Add support for hidden records;
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyTopCallFrame): Linkify originator's top frame if no own stack is present;

  • inspector/front-end/timelinePanel.css:

(.timeline-tree-item.warning): Reddish text for records with warnings;

  • page/FrameView.cpp:

(WebCore::FrameView::scheduleRelayout): Added call to InspectorInstrumentation::didInvalidateLayout()
(WebCore::FrameView::scheduleRelayoutOfSubtree): Ditto.

LayoutTests:

  • added new events (ScheduleStyleRecalculation and InvlidateLayout)
  • rebaselined a test due to a new event;
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • inspector/timeline/timeline-script-tag-1-expected.txt:
6:22 AM Changeset in webkit [126753] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviwed gardening. Skip test that fails on 32bit release.
https://bugs.webkit.org/show_bug.cgi?id=95070

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-27

  • platform/qt/Skipped: skip inspector/styles/media-queries.html after r126717.
6:22 AM Changeset in webkit [126752] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-27

  • DEPS:
5:55 AM Changeset in webkit [126751] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewd gardening. Skip failing compositing tests.
https://bugs.webkit.org/show_bug.cgi?id=95076.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-27

  • platform/qt-5.0-wk2/Skipped:
5:39 AM Changeset in webkit [126750] by commit-queue@webkit.org
  • 56 edits in trunk

[EFL] Wrong button height on CSS tests
https://bugs.webkit.org/show_bug.cgi?id=85494

Source/WebCore:

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-08-27
Reviewed by Gyuyoung Kim.

The codes for overriding styles for buttons must be removed
for passing the layout test 'fast/css/button-height.html'.

The 'resetBorder' reset border style for a button (2px outset) to the initial value,
and it makes the size of <input type=button> different from the size of <button>.
('fast/css/button-height.html' checks whether they are same.)

The 'setWhiteSpace' is not needed because the white space already set to 'PRE'.

The 'setHeight' reset the 'height' style that should not be reset.
('fast/css/buttons-height.html' set the button's height style.)

Tests : fast/css/button-height.html

fast/css/continuationCrash.html
fast/css/margin-top-bottom-dynamic.html
fast/css/rtl-ordering.html
fast/dom/HTMLTextAreaElement/reset-textarea.html
fast/forms/basic-buttons.html
fast/forms/blankbuttons.html
fast/forms/box-shadow-override.html
fast/forms/button-positioned.html
fast/forms/button-sizes.html
fast/forms/button-style-color.html
fast/forms/button-table-styles.html
fast/forms/button-text-transform.html
fast/forms/control-restrict-line-height.html
fast/forms/file/file-input-direction.html
fast/forms/file/file-input-disabled.html
fast/forms/formmove3.html
fast/forms/input-appearance-height.html
fast/forms/input-button-sizes.html
fast/forms/input-value.html
fast/forms/targeted-frame-submission.html
fast/html/details-replace-summary-child.html
fast/html/details-replace-text.html
fast/overflow/scroll-nested-positioned-layer-in-overflow.html
fast/overflow/scrollRevealButton.html
fast/replaced/replaced-breaking.html
fast/replaced/width100percent-button.html
fast/text/textIteratorNilRenderer.html

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustButtonStyle): No longer override CSS properties for button styling.

LayoutTests:

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-08-27
Reviewed by Gyuyoung Kim.

This patch changes styles of buttons (not to reset border style).
Update baselines for tests include buttons.

  • platform/efl/TestExpectations:
  • platform/efl/fast/css/continuationCrash-expected.png:
  • platform/efl/fast/css/continuationCrash-expected.txt:
  • platform/efl/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/efl/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/efl/fast/css/rtl-ordering-expected.png:
  • platform/efl/fast/css/rtl-ordering-expected.txt:
  • platform/efl/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/efl/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/efl/fast/forms/basic-buttons-expected.png:
  • platform/efl/fast/forms/basic-buttons-expected.txt:
  • platform/efl/fast/forms/blankbuttons-expected.png:
  • platform/efl/fast/forms/blankbuttons-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.png:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/button-positioned-expected.png:
  • platform/efl/fast/forms/button-positioned-expected.txt:
  • platform/efl/fast/forms/button-sizes-expected.png:
  • platform/efl/fast/forms/button-sizes-expected.txt:
  • platform/efl/fast/forms/button-style-color-expected.png:
  • platform/efl/fast/forms/button-style-color-expected.txt:
  • platform/efl/fast/forms/button-table-styles-expected.png:
  • platform/efl/fast/forms/button-table-styles-expected.txt:
  • platform/efl/fast/forms/button-text-transform-expected.png:
  • platform/efl/fast/forms/button-text-transform-expected.txt:
  • platform/efl/fast/forms/control-restrict-line-height-expected.png:
  • platform/efl/fast/forms/control-restrict-line-height-expected.txt:
  • platform/efl/fast/forms/file/file-input-direction-expected.png:
  • platform/efl/fast/forms/file/file-input-direction-expected.txt:
  • platform/efl/fast/forms/file/file-input-disabled-expected.png:
  • platform/efl/fast/forms/file/file-input-disabled-expected.txt:
  • platform/efl/fast/forms/formmove3-expected.png:
  • platform/efl/fast/forms/formmove3-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.png:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/input-button-sizes-expected.png:
  • platform/efl/fast/forms/input-button-sizes-expected.txt:
  • platform/efl/fast/forms/input-value-expected.png:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/forms/targeted-frame-submission-expected.png:
  • platform/efl/fast/forms/targeted-frame-submission-expected.txt:
  • platform/efl/fast/html/details-replace-summary-child-expected.png:
  • platform/efl/fast/html/details-replace-summary-child-expected.txt:
  • platform/efl/fast/html/details-replace-text-expected.png:
  • platform/efl/fast/html/details-replace-text-expected.txt:
  • platform/efl/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/efl/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/efl/fast/overflow/scrollRevealButton-expected.png:
  • platform/efl/fast/overflow/scrollRevealButton-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-expected.png:
  • platform/efl/fast/replaced/replaced-breaking-expected.txt:
  • platform/efl/fast/replaced/width100percent-button-expected.png:
  • platform/efl/fast/replaced/width100percent-button-expected.txt:
4:56 AM Changeset in webkit [126749] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: DOM tree search issue with quotation marks
https://bugs.webkit.org/show_bug.cgi?id=95065

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced the exact match mode for attributes (query enclosed in double quotes) where only entire attribute values
are matched against the search query (with the double quotes trimmed).

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

LayoutTests:

  • inspector/elements/elements-panel-search-expected.txt:
  • inspector/elements/elements-panel-search.html:
4:49 AM Changeset in webkit [126748] by dominicc@chromium.org
  • 2 edits
    1 copy in trunk/LayoutTests

[Chromium] Unreviewed gardening.

More rebaselines to account for font aliasing differences.

  • platform/chromium-mac-snowleopard/compositing/overflow/nested-scrolling-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/overflow/nested-scrolling-expected.png.
  • platform/chromium-mac/compositing/overflow/nested-scrolling-expected.png:
4:38 AM Changeset in webkit [126747] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Implement serializing WebGL state and replaying it later
https://bugs.webkit.org/show_bug.cgi?id=94933

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-27
Reviewed by Pavel Feldman.

This will allow us to save the WebGL state at any arbitrary point in order to replay a trace log later on another canvas.
Main points of the change:

  • Allow every Resource and Call instances be serialized to a Replayable, and resurrected back during a replay on another canvas.
  • Before executing an original WebGL call and saving it to a trace log, first serialize all the Resources that will be involved in this call, if they are not yet serialized. The latter part is implemented with a Cache instance, checking that we convert a Resource to a Replayable only once: the first time it was used in the trace log being collected. We do not need to serialize the subsequent changes to this Resource's state (if any), since they will be saved in the trace log being collected and replayed automatically.
  • Some information about the WebGL state may be requested in the runtime (e.g. with the gl.getParameter method). We use this wherever possible instead of collecting Calls in a Resource log. Otherwise, we have to collect WebGL calls (like gl.texImage2D) in order to replay them later.
  • Later the Replayable objects hierarchy (the TraceLog) may be serialized further for cross-device transmission, for example.
  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

4:32 AM Changeset in webkit [126746] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: HeapSnapshot: filter weak links in markQueriableHeapObjects and two other minor fixes.
https://bugs.webkit.org/show_bug.cgi?id=95068

Reviewed by Yury Semikhatsky.

  • count shortcuts as normal links in distance;

shortcuts help us to show object properties without exposing internal scope object

  • set initial distance to 1 instead of 0

the initial value for window was 0 and bfs counted the window object as not visited.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

4:09 AM Changeset in webkit [126745] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Mark inspector/styles/media-queries.html as flaky for WK1 as well
https://bugs.webkit.org/show_bug.cgi?id=95067

Unreviewed EFL gardening. Mark inspector/styles/media-queries.html as
flaky for WK1 as well.

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-27

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
4:02 AM Changeset in webkit [126744] by dominicc@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaseline to account for font antialiasing differences.

  • platform/chromium-mac-snowleopard/compositing/overflow/remove-overflow-crash2-expected.png: Added.
3:58 AM Changeset in webkit [126743] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r126694 and r126731.
http://trac.webkit.org/changeset/126694
http://trac.webkit.org/changeset/126731
https://bugs.webkit.org/show_bug.cgi?id=95069

Causes all pages to be rendered as a completely black page in
Qt WebKit2 (Requested by carewolf on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-27

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::getCurrentGLContext):
(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
(WebCore::TextureMapperGLData::sharedGLData):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore::scissorClip):
(WebCore::TextureMapperGL::ClipStack::apply):
(WebCore::TextureMapperGLData::initializeStencil):
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawQuad):
(WebCore::TextureMapperGL::drawBorder):
(WebCore):
(WebCore::TextureMapperGL::drawTextureRectangleARB):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::viewportMatrix):
(WebCore::TextureMapperGL::drawTextureWithAntialiasing):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bind):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::TextureMapperGL::bindDefaultSurface):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):
(WebCore::TextureMapperGL::createTexture):

  • platform/graphics/texmap/TextureMapperGL.h:

(TextureMapperGL):
(ClipStack):
(WebCore::BitmapTextureGL::textureTarget):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore):
(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderProgram::TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::initializeProgram):
(WebCore::TextureMapperShaderProgram::getUniformLocation):
(WebCore::TextureMapperShaderProgram::~TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):
(WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple):
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::TextureMapperShaderProgramRectOpacityAndMask):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::TextureMapperShaderProgramAntialiasingNoMask):
(WebCore::TextureMapperShaderManager::TextureMapperShaderManager):
(WebCore::StandardFilterProgram::~StandardFilterProgram):
(WebCore::StandardFilterProgram::StandardFilterProgram):
(WebCore::StandardFilterProgram::create):
(WebCore::StandardFilterProgram::prepare):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore::TextureMapperShaderProgram::id):
(WebCore::TextureMapperShaderProgram::vertexAttrib):
(TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::matrixLocation):
(WebCore::TextureMapperShaderProgram::flipLocation):
(WebCore::TextureMapperShaderProgram::textureSizeLocation):
(WebCore::TextureMapperShaderProgram::sourceTextureLocation):
(WebCore::TextureMapperShaderProgram::maskTextureLocation):
(WebCore::TextureMapperShaderProgram::opacityLocation):
(WebCore::TextureMapperShaderProgram::isValidUniformLocation):
(StandardFilterProgram):
(WebCore::StandardFilterProgram::vertexAttrib):
(WebCore::StandardFilterProgram::texCoordAttrib):
(WebCore::StandardFilterProgram::textureUniform):
(WebCore::TextureMapperShaderProgramSimple::create):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramRectSimple::create):
(WebCore::TextureMapperShaderProgramOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramSolidColor::create):
(WebCore::TextureMapperShaderProgramSolidColor::colorLocation):
(TextureMapperShaderProgramSolidColor):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::create):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::expandedQuadVerticesInTextureCoordinatesLocation):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::expandedQuadEdgesInScreenSpaceLocation):
(TextureMapperShaderProgramAntialiasingNoMask):

3:50 AM Changeset in webkit [126742] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Update expectations for inspector/styles/media-queries.html which
started failing on Linux (dbg) at r126717 and flaky on Linux, Win
at or right after that revision.

  • platform/chromium/TestExpectations:
3:33 AM Changeset in webkit [126741] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening

Fix test expectation lint errors.

3:28 AM FeatureFlags edited by tkent@chromium.org
(diff)
3:25 AM FeatureFlags edited by tkent@chromium.org
Rename REGISTER_PROTOCOL_HANDLER to NAVIGATOR_CONTENT_UTILS (diff)
2:58 AM Changeset in webkit [126740] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] REGRESSION(r126067): It made qmltests::DoubleTapToZoom::test_basic() fail
https://bugs.webkit.org/show_bug.cgi?id=94949

Reviewed by Kenneth Rohde Christiansen.

Use JSON to serialize the client rect for the async evaluateJavaScript call.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:
2:58 AM Changeset in webkit [126739] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit2

[Qt] Fix failing QML2 auto tests due to conflicting signal declaration
https://bugs.webkit.org/show_bug.cgi?id=95059

Reviewed by Kenneth Rohde Christiansen.

Don't define a scaleChanged signal when QQuickItem already declares one to notify about changes
in the scale property. As it turns out there is not need for declaring a signal in the test case
at all.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml:
2:45 AM Changeset in webkit [126738] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Regression(r126721): bindings-tests results need to be updated
https://bugs.webkit.org/show_bug.cgi?id=95060

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-27
Reviewed by Kentaro Hara.

Regenerate bindings-tests results after r126721. This change
removed the NULL checks from visitChildren functions.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::visitChildren):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::visitChildren):

2:36 AM Changeset in webkit [126737] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: Incorrect property override computation when !important is involved
https://bugs.webkit.org/show_bug.cgi?id=94923

Reviewed by Vsevolod Vlasov.

Source/WebCore:

The cascade of !important properties was totally wrong if a property was listed as !important first and as non-!important later on.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
(WebInspector.StylesSidebarPane.prototype._markUsedProperties):

LayoutTests:

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/elements/resources/elements-panel-styles.css:

(.foo, .foo::before):

2:26 AM Changeset in webkit [126736] by yosin@chromium.org
  • 3 edits
    4 adds
    4 deletes in trunk/LayoutTests

[Tests] Using ref image instead ref HTML for fast/forms/time-multiple-fields/time-multiple-fields-appearance-{basic,pseudo-element}.html
https://bugs.webkit.org/show_bug.cgi?id=95055

Reviewed by Kent Tamura.

This patch changes test expectations of time-multiple-fields-appearance-basic.html
and time-multiple-fields-appearance-pseudo-elements.html to images
rather than HTML for ease of maintenance. There were unexpected image
differences between actual images and HTML reference images. It seems
rebaseline is easier than updating JavaScript code and CSS style sheet
of reference HTML.

Note: This patch contains Chromium-Linux images only. We need to do
rebaseline for Chromium-Mac and Chromium-Win later.

  • fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.css: Removed.
  • fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Changed not to use external style sheet.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Added.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • platform/chromium/TestExpectations: Updates entries for rebaseline
2:19 AM Changeset in webkit [126735] by commit-queue@webkit.org
  • 48 edits
    9 moves
    1 add in trunk

Rename RegisterProtocolHandler API to NavigatorContentUtils
https://bugs.webkit.org/show_bug.cgi?id=94920

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-27
Reviewed by Adam Barth.

.:

Modified configuration files so that they contain renamed NavigatorContentUtils-prefixed files.

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

ENABLE_REGISTER_PROTOCOL_HANDLER is renamed to ENABLE_NAVIGATOR_CONTENT_UTILS.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
Module 'protocolhandler' is renamed to 'navigatorcontentutils'.

No new tests as there is no new functionality.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.features.am:
  • GNUmakefile.list.am:
  • Modules/navigatorcontentutils/NavigatorContentUtils.cpp: Renamed from Source/WebCore/Modules/protocolhandler/NavigatorRegisterProtocolHandler.cpp.

(WebCore):
(WebCore::initProtocolHandlerWhitelist):
(WebCore::verifyCustomHandlerURL):
(WebCore::isProtocolWhitelisted):
(WebCore::verifyProtocolHandlerScheme):
(WebCore::NavigatorContentUtils::from):
(WebCore::NavigatorContentUtils::~NavigatorContentUtils):
(WebCore::NavigatorContentUtils::create):
(WebCore::NavigatorContentUtils::registerProtocolHandler):
(WebCore::customHandlersStateString):
(WebCore::NavigatorContentUtils::isProtocolHandlerRegistered):
(WebCore::NavigatorContentUtils::unregisterProtocolHandler):
(WebCore::NavigatorContentUtils::supplementName):
(WebCore::provideNavigatorContentUtilsTo):

  • Modules/navigatorcontentutils/NavigatorContentUtils.h: Renamed from Source/WebCore/Modules/protocolhandler/NavigatorRegisterProtocolHandler.h.

(WebCore):
(NavigatorContentUtils):
(WebCore::NavigatorContentUtils::NavigatorContentUtils):
(WebCore::NavigatorContentUtils::client):

  • Modules/navigatorcontentutils/NavigatorContentUtils.idl: Renamed from Source/WebCore/Modules/protocolhandler/NavigatorRegisterProtocolHandler.idl.
  • Modules/navigatorcontentutils/NavigatorContentUtilsClient.h: Renamed from Source/WebCore/Modules/protocolhandler/RegisterProtocolHandlerClient.h.

(WebCore):
(NavigatorContentUtilsClient):
(WebCore::NavigatorContentUtilsClient::~NavigatorContentUtilsClient):

  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:

Source/WebKit:

Modified PlatformEfl.cmake so that it includes the renamed files.

  • PlatformEfl.cmake:

Source/WebKit/blackberry:

Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore):
(WebCore::ChromeClientBlackBerry::registerProtocolHandler):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

Source/WebKit/chromium:

Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
RegisterProtocolHandlerClientImpl is renamed to NavigatorContentUtilsClientImpl.

  • features.gypi:
  • src/ChromeClientImpl.cpp:

(WebKit):
(WebKit::NavigatorContentUtilsClientImpl::create):
(WebKit::NavigatorContentUtilsClientImpl::NavigatorContentUtilsClientImpl):
(WebKit::NavigatorContentUtilsClientImpl::registerProtocolHandler):

  • src/ChromeClientImpl.h:

(NavigatorContentUtilsClientImpl):
(WebKit::NavigatorContentUtilsClientImpl::~NavigatorContentUtilsClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

Source/WebKit/efl:

Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
RegisterProtocolHandlerClientEfl is renamed to NavigatorContentUtilsClientEfl.

  • WebCoreSupport/NavigatorContentUtilsClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp.

(WebCore):
(WebCore::customHandlerDataCreate):
(WebCore::customHandlerDataDelete):
(WebCore::NavigatorContentUtilsClientEfl::create):
(WebCore::NavigatorContentUtilsClientEfl::NavigatorContentUtilsClientEfl):
(WebCore::NavigatorContentUtilsClientEfl::registerProtocolHandler):
(WebCore::NavigatorContentUtilsClientEfl::isProtocolHandlerRegistered):
(WebCore::NavigatorContentUtilsClientEfl::unregisterProtocolHandler):

  • WebCoreSupport/NavigatorContentUtilsClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/RegisterProtocolHandlerClientEfl.h.

(NavigatorContentUtilsClientEfl):
(WebCore::NavigatorContentUtilsClientEfl::~NavigatorContentUtilsClientEfl):

  • ewk/ewk_custom_handler.cpp:
  • ewk/ewk_custom_handler_private.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Source/WebKit/gtk:

Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
RegisterProtocolHandlerClientGtk is renamed to NavigatorContentUtilsClientGtk.

  • GNUmakefile.am:
  • WebCoreSupport/NavigatorContentUtilsClientGtk.cpp: Renamed from Source/WebKit/gtk/WebCoreSupport/RegisterProtocolHandlerClientGtk.cpp.

(WebKit):
(WebKit::NavigatorContentUtilsClient::create):
(WebKit::NavigatorContentUtilsClient::NavigatorContentUtilsClient):
(WebKit::NavigatorContentUtilsClient::registerProtocolHandler):

  • WebCoreSupport/NavigatorContentUtilsClientGtk.h: Renamed from Source/WebKit/gtk/WebCoreSupport/RegisterProtocolHandlerClientGtk.h.

(WebKit):
(NavigatorContentUtilsClient):
(WebKit::NavigatorContentUtilsClient::~NavigatorContentUtilsClient):

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

  • webkit/webkitwebviewprivate.h:

Source/WebKit/mac:

ENABLE_REGISTER_PROTOCOL_HANDLER is renamed to ENABLE_NAVIGATOR_CONTENT_UTILS.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebNavigatorContentUtilsClient.h: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/WebRegisterProtocolHandlerClient.h.

(WebKit):
(WebNavigatorContentUtilsClient):
(WebKit::WebNavigatorContentUtilsClient::~WebNavigatorContentUtilsClient):
(WebKit::WebNavigatorContentUtilsClient::isProtocolHandlerRegistered):
(WebKit::WebNavigatorContentUtilsClient::unregisterProtocolHandler):

Tools:

Renamed 'register-protocol-handler' feature to 'navigator-content-utils'.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:
1:10 AM Changeset in webkit [126734] by dominicc@chromium.org
  • 4 edits
    4 moves
    8 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Add missing baselines and rebaseline some minor font rendering
differences.

  • platform/chromium-linux/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium-linux/compositing/overflow/nested-scrolling-expected.txt:
  • platform/chromium-mac/compositing/overflow/nested-scrolling-expected.png: Added.
  • platform/chromium-mac/compositing/overflow/nested-scrolling-expected.txt: Added.
  • platform/chromium-mac/compositing/overflow/remove-overflow-crash2-expected.png: Added.
  • platform/chromium-mac/compositing/overflow/remove-overflow-crash2-expected.txt: Added.
  • platform/chromium-win/compositing/overflow/nested-scrolling-expected.png: Added.
  • platform/chromium-win/compositing/overflow/nested-scrolling-expected.txt: Added.
  • platform/chromium-win/compositing/overflow/remove-overflow-crash2-expected.png: Added.
  • platform/chromium-win/compositing/overflow/remove-overflow-crash2-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.png.
  • platform/chromium/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt: Renamed from LayoutTests/platform/chromium-linux/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt.
  • platform/chromium/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor-expected.png.
  • platform/chromium/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor-expected.txt: Renamed from LayoutTests/platform/chromium-linux/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor-expected.txt.
12:59 AM Changeset in webkit [126733] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html.
https://bugs.webkit.org/show_bug.cgi?id=95054

Unreviewed gardeing.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-08-27

  • platform/qt/Skipped:
12:41 AM Changeset in webkit [126732] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip several compositing/overflow test cases
https://bugs.webkit.org/show_bug.cgi?id=95047

Unreviewed EFL gardening. Skip several compositing/overflow
test cases which are failing due to incomplete support
for accelerated compositing or missing support for
layerTreeAsText().

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-27

  • platform/efl/TestExpectations:
12:31 AM Changeset in webkit [126731] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r126694): It broke the debug build
https://bugs.webkit.org/show_bug.cgi?id=95037

Unreviewed trivial build fix for debug builds.

Don't pass WTFStrings through printf, use .ascii().data().

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::StandardFilterProgram::StandardFilterProgram):

12:27 AM Changeset in webkit [126730] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Update expectations for
fast/writing-mode/broken-ideographic-font.html after r126683.

  • platform/chromium/TestExpectations:
12:04 AM Changeset in webkit [126729] by jnd@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium-Android]Move webkit_unit_tests_apk and TestWebKitAPI_apk into a
condition block:OS=="android" and gtest_target_type == "shared_library"?.
https://bugs.webkit.org/show_bug.cgi?id=95049

Reviewed by Adam Barth.

Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of gtest_target_type == "shared_library"

  • All.gyp:

Aug 26, 2012:

11:52 PM Changeset in webkit [126728] by yosin@chromium.org
  • 3 edits
    2 adds in trunk

[Forms] Focus style of millisecond field in multiple fields time input UI is different from other fields
https://bugs.webkit.org/show_bug.cgi?id=95046

Reviewed by Kent Tamura.

Source/WebCore:

This patch fixes typo for input::-webkit-datetime-edit-millisecond-field:focus
selector to make all fields of multiple fields time input UI have same
style on focus.

Test: fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html

  • css/html.css: Fix typo for selector input::-webkit-datetime-edit-millisecond-field:focus

LayoutTests:

This patch adds a new test for checking focus style of all fields in
multiple fields time input UI.

We check appearance of focus field in fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html

  • fast/forms/time-multiple-fields/time-multiple-fields-focus-style-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html: Added.
11:50 PM Changeset in webkit [126727] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

Initialized m_hasNonEmptyList to fix a valgrind uninitialized read
https://bugs.webkit.org/show_bug.cgi?id=95045

Reviewed by Kent Tamura.

Conditional jump or move depends on uninitialised value(s)
WebCore::HTMLInputElement::dataList() const (third_party/WebKit/Source/WebCore/html/HTMLInputElement.cpp:1523)
WebCore::RangeInputType::updateTickMarkValues() (third_party/WebKit/Source/WebCore/html/RangeInputType.cpp:351)
WebCore::RangeInputType::findClosestTickMarkValue(WebCore::Decimal const&) (third_party/WebKit/Source/WebCore/html/RangeInputType.cpp:370)
WebCore::HTMLInputElement::findClosestTickMarkValue(WebCore::Decimal const&) (third_party/WebKit/Source/WebCore/html/HTMLInputElement.cpp:324)
WebCore::SliderThumbElement::setPositionFromPoint(WebCore::FractionalLayoutPoint const&) (third_party/WebKit/Source/WebCore/html/shadow/SliderThumbElement.cpp:296)
WebCore::SliderThumbElement::dragFrom(WebCore::FractionalLayoutPoint const&) (third_party/WebKit/Source/WebCore/html/shadow/SliderThumbElement.cpp:246)
WebCore::RangeInputType::handleMouseDownEvent(WebCore::MouseEvent*) (third_party/WebKit/Source/WebCore/html/RangeInputType.cpp:159)
WebCore::HTMLInputElement::defaultEventHandler(WebCore::Event*) (third_party/WebKit/Source/WebCore/html/HTMLInputElement.cpp:1163)
WebCore::MediaControlTimelineElement::defaultEventHandler(WebCore::Event*) (third_party/WebKit/Source/WebCore/html/shadow/MediaControlElements.cpp:916)
WebCore::EventDispatcher::dispatchEventPostProcess(WTF::PassRefPtr<WebCore::Event>, void*) (third_party/WebKit/Source/WebCore/dom/EventDispatcher.cpp:357)
WebCore::EventDispatcher::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) (third_party/WebKit/Source/WebCore/dom/EventDispatcher.cpp:263)
WebCore::MouseEventDispatchMediator::dispatchEvent(WebCore::EventDispatcher*) const (third_party/WebKit/Source/WebCore/dom/MouseEvent.cpp:238)
WebCore::EventDispatcher::dispatchEvent(WebCore::Node*, WTF::PassRefPtr<WebCore::EventDispatchMediator>) (third_party/WebKit/Source/WebCore/dom/EventDispatcher.cpp:129)
...
The report came from the media/audio-delete-while-slider-thumb-clicked.html'--pixel-test test.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::dataList):

11:22 PM Changeset in webkit [126726] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping http/tests/security/local-user-CSS-from-remote.html to green mac WK2 bots.
https://bugs.webkit.org/show_bug.cgi?id=95043.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-26
Reviewed by Kentaro Hara.

  • platform/mac-wk2/Skipped:
11:10 PM Changeset in webkit [126725] by hbono@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

Merge 125757 - Prevent showing suggestions when right-clicking a selection range.
https://bugs.webkit.org/show_bug.cgi?id=94189

Reviewed by Hajime Morita.

To emulate Safari, my r120810 changes selection when right-clicking a misspelled
word. Unfortunately, this change somehow uses VisibleSelection::isCaretOrRange
and it changes the existing selection when right-clicking a selection which
includes a misspelled word. This change uses VisibleSelection::isCaret to
prevent showing suggestions when right-clicking a selection range. (Neither does
Safari show suggestions when there is a selection range.)

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

TBR=hbono@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10868101

10:55 PM Changeset in webkit [126724] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping fast/forms/validation-message-user-modify.html to green mac WK2 bots.
https://bugs.webkit.org/show_bug.cgi?id=95042.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-26
Reviewed by Kentaro Hara.

  • platform/mac-wk2/Skipped:
9:23 PM Changeset in webkit [126723] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix for builds without VALUE_PROFILING. I had forgotten that shouldEmitProfiling()
is designed to return true if DFG_JIT is disabled. I should be using canBeOptimized() instead.

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

9:12 PM Changeset in webkit [126722] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Don't allocate space for arguments and call frame if arguments aren't captured
https://bugs.webkit.org/show_bug.cgi?id=95024

Reviewed by Phil Pizlo.

27% on v8-real-earley.

  • runtime/JSActivation.h:

(JSC::JSActivation::registerOffset): The offset is zero if we're skipping
the arguments and call frame because "offset" means space reserved for
those things.

(JSC::JSActivation::tearOff): Don't copy the scope chain and callee. We
don't need them for anything, and we're no longer guaranteed to have
space for them.

8:57 PM Changeset in webkit [126721] by ggaren@apple.com
  • 21 edits in trunk/Source

Removed the NULL checks from visitChildren functions
https://bugs.webkit.org/show_bug.cgi?id=95021

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

As of http://trac.webkit.org/changeset/126624, all values are NULL-checked
during GC, so explicit NULL checks aren't needed anymore.

Source/WebCore:

As of http://trac.webkit.org/changeset/126624, all values are NULL-checked
during GC, so explicit NULL checks aren't needed anymore.

8:48 PM Changeset in webkit [126720] by ggaren@apple.com
  • 5 edits in trunk/Source

Removed a JSC-specific hack from the web inspector
https://bugs.webkit.org/show_bug.cgi?id=95033

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added support for what the web inspector really wanted instead.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut): Added some explanation for these
checks, which were non-obvious to me.

(JSC::JSActivation::getOwnPropertySlot): It's impossible to access the
arguments property of an activation after it's been torn off, since the
only way to tear off an activation is to instantiate a new function,
which has its own arguments property in scope. However, the inspector
get special access to activations, and may try to perform this access,
so we need a special guard to maintain coherence and avoid crashing in
case the activation optimized out the arguments property.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::getOwnPropertyDescriptor): Provide getOwnPropertyNames
and getOwnPropertyDescriptor implementations, to meet the web inspector's
needs. (User code can never call these.)

Source/WebCore:

The hack was never reviewed. If it had been, I suspect it would have
gotten an r- for making weird assumptions about the engine's implimentation.

  • inspector/InjectedScriptSource.js: It's not sound to assume that an

object has no properties except for "arguments" if and only if it's an
activation: non-activations can have a property named "arguments", and
activations can optimize out "arguments".

7:49 PM Changeset in webkit [126719] by commit-queue@webkit.org
  • 3 edits in trunk/Source

[chromium] Fix a bug where CCThreadProxy::canDraw() gets stuck at false on tab switch
https://bugs.webkit.org/show_bug.cgi?id=94903

Patch by Christopher Cameron <ccameron@chromium.org> on 2012-08-26
Reviewed by James Robinson.

Suppose the impl thread deletes all textures via
releaseContentsTextures(). The impl thread will not be able to draw
again until resetContentsTexturesPurged() is called in
scheduledActionCommit(). When deleting the textures, the function
releaseContentsTextures() calls setNeedsCommitOnImplThread() to ensure
that a commit will come along to allow drawing again. If this commit
is aborted, then the page will not draw until a commit is scheduled,
which may be never.

Make beginFrameAborted() call setNeedsCommit(), so that the requested
commit will eventually occur.

No new tests, update to CCSchedulerStateMachineTest's
TestGoesInvisibleBeforeBeginFrameCompletes to require new
functionality (new test fails with old behavior).

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::beginFrameAborted):

5:49 PM Changeset in webkit [126718] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

Finally inlining should correctly track the catch context
https://bugs.webkit.org/show_bug.cgi?id=94986
<rdar://problem/11753784>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This fixes two behaviors:

1) Throwing from a finally block. Previously, we would seem to reenter the finally

block - though only once.


2) Executing a finally block from some nested context, for example due to a

'continue', 'break', or 'return' in the try. This would execute the finally
block in the context of of the try block, which could lead to either scope depth
mismatches or reexecutions of the finally block on throw, similarly to (1) but
for different reasons.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC):
(JSC::BytecodeGenerator::pushFinallyContext):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
(JSC::BytecodeGenerator::pushTry):
(JSC::BytecodeGenerator::popTryAndEmitCatch):

  • bytecompiler/BytecodeGenerator.h:

(FinallyContext):
(TryData):
(JSC):
(TryContext):
(TryRange):
(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::TryNode::emitBytecode):

LayoutTests:

  • fast/js/jsc-test-list:
  • fast/js/script-tests/throw-from-finally.js: Added.
  • fast/js/throw-from-finally.html: Added.
  • fast/js/throw-from-finally-expected.txt: Added.
4:48 PM Changeset in webkit [126717] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Remove parent pointer from StyleSheetContents and StyleRuleImport
https://bugs.webkit.org/show_bug.cgi?id=94926

Reviewed by Andreas Kling.

To be able to cache and share @imported stylesheets in the future there must not be any parent
pointers in the stylesheet tree.

Parent pointers are used during loading to invoke load completion callbacks and for
accessing document context information (like the security origin). They are not used after
the sheet load is complete. Instead of keeping the parent pointers around indefinitely as part of the
stylesheet data structure we just keep a pointer to the root CSSStyleSheet for the duration of the load.

This patch doesn't enable any new caching or generally change the behavior.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::rootStyleSheet):
(WebCore):
(WebCore::CSSStyleSheet::ownerDocument):

  • css/CSSStyleSheet.h:

(CSSStyleSheet):

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::LoadContext::LoadContext):

Simplify by making StyleRuleImport CachedStyleSheetClient directly. LoadContext contains
fields that can be thrown away after load completes.

(WebCore):
(WebCore::StyleRuleImport::StyleRuleImport):
(WebCore::StyleRuleImport::~StyleRuleImport):
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::isLoading):
(WebCore::StyleRuleImport::hadLoadError):
(WebCore::StyleRuleImport::requestStyleSheet):

  • css/StyleRuleImport.h:

(StyleRuleImport):
(LoadContext):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::StyleSheetContents):

Remove now unnecessary constructor.

(WebCore::StyleSheetContents::isCacheable):
(WebCore::StyleSheetContents::parserAppendRule):
(WebCore::StyleSheetContents::clearRules):
(WebCore::StyleSheetContents::wrapperInsertRule):
(WebCore::StyleSheetContents::wrapperDeleteRule):
(WebCore::StyleSheetContents::requestImportedStyleSheets):
(WebCore):
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseStringAtLine):
(WebCore::StyleSheetContents::checkImportedSheetLoadCompleted):
(WebCore::StyleSheetContents::checkLoadCompleted):
(WebCore::StyleSheetContents::getAncestors):
(WebCore::StyleSheetContents::hasImportCycle):

Move the cycle checking to the root stylesheet so we don't need to pass the entire chain around.
The extra work here is unlikely to cause problems, massive import trees don't really occur in
practice.

  • css/StyleSheetContents.h:

(WebCore::StyleSheetContents::create):
(StyleSheetContents):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

3:38 PM Changeset in webkit [126716] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid pointless string/number round-trip in applyRelativeFontStyleChange().
<http://webkit.org/b/95031>

Reviewed by Dan Bernstein.

Create a CSS_PX primitive value directly instead of passing String::number(foo) + "px" to the CSS parser.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):

3:35 PM Changeset in webkit [126715] by fpizlo@apple.com
  • 25 edits in trunk/Source/JavaScriptCore

Array type checks and storage accesses should be uniformly represented and available to CSE
https://bugs.webkit.org/show_bug.cgi?id=95013

Reviewed by Oliver Hunt.

This uniformly breaks up all array accesses into up to three parts:

1) The type check, using a newly introduced CheckArray node, in addition to possibly

a CheckStructure node. We were already inserting the CheckStructure prior to this
patch. The CheckArray node will be automatically eliminated if the thing it was
checking for had already been checked for, either intentionally (a CheckStructure
inserted based on the array profile of this access) or accidentally (some checks,
typically a CheckStructure, inserted for some unrelated operations). The
CheckArray node may not be inserted if the array type is non-specific (Generic or
ForceExit).


2) The storage load using GetIndexedPropertyStorage. Previously, this only worked for

GetByVal. Now it works for all array accesses. The storage load may not be
inserted if the mode of array access does not permit CSE of storage loads (like
non-specific modes or Arguments).


3) The access itself: one of GetByVal, PutByVal, PutByValAlias, ArrayPush, ArrayPop,

GetArrayLength, StringCharAt, or StringCharCodeAt.


This means that the type check can be subjected to CSE even if the CFA isn't smart
enough to reason about it (yet!). It also means that the storage load can always be
subjected to CSE; previously CSE on storage load only worked for array loads and not
other forms of access. Finally, it removes the bizarre behavior that
GetIndexedPropertyStorage previously had: previously, it was responsible for the type
check in some cases, but not others; this made reasoning about the CFA really
confusing.

This change also disables late refinement of array mode, since I decided that
supporting that feature is both confusing and likely unprofitable. The array modes are
now locked in in the first fixup run after prediction propagation. Of course,
refinements from Generic to something else would not have been a problem; we could
reenable those if we thought we really needed to.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::fromStructure):
(DFG):
(JSC::DFG::refineArrayMode):

  • dfg/DFGArrayMode.h:

(DFG):
(JSC::DFG::modeIsJSArray):
(JSC::DFG::lengthNeedsStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayMode):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::checkStructureElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::performCSE):

  • dfg/DFGCSEPhase.h:

(DFG):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(FixupPhase):
(JSC::DFG::FixupPhase::blessArrayOperation):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(DFG):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::collectGarbage):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::vote):
(JSC::DFG::Graph::substitute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArrayMode):
(JSC::DFG::Node::setArrayMode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

3:15 PM Changeset in webkit [126714] by gavinp@chromium.org
  • 5 edits in trunk/Source/WebCore

Prerenderering should gracefully handle no PrerendererClient or PrerenderingPlatform being provided.
https://bugs.webkit.org/show_bug.cgi?id=95036

Reviewed by Adam Barth.

Some assertions made sure there was a prerendering platform and client, and this change should make prerendering just be a NOP when no platform is provided, and just continue without a client when there is no client provided. These assertions were causing crashes in chromium's content_shell target, and really for no good reason.

No new tests, because DumpRenderTree provides both a PrerenderingPlatform and a PrerendererClient. But there is a new layout test in chromium's WebKitBrowserTest for this behaviour, see http://codereview.chromium.org/10869068/

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::Prerenderer):
(WebCore::Prerenderer::render):
(WebCore::Prerenderer::client):

  • loader/Prerenderer.h:
  • loader/PrerendererClient.cpp:

(WebCore::PrerendererClient::from):

  • platform/chromium/Prerender.cpp:

(WebCore::Prerender::cancel):

2:11 PM Changeset in webkit [126713] by Dave Barton
  • 2 edits in trunk/Source/WebCore

Streamline mathml.css
https://bugs.webkit.org/show_bug.cgi?id=95039

Reviewed by Dan Bernstein.

Remove 3 no-op { margin: 0px } declarations, and combine several { display: inline-block } ones.

Tested by existing tests.

  • css/mathml.css:

(math):
(mo, mrow, mfenced, mfrac, msub, msup, msubsup, munder, mover, munderover, msqrt, mroot):
(mrow, mfenced):
(msubsup > *):
(mo, mn, mi, mtext):
(annotation, annotation-xml):
(msqrt):
(mroot):

12:53 PM Changeset in webkit [126712] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFGGraph.h has a bogus comment about the nature of StorageAccessData
https://bugs.webkit.org/show_bug.cgi?id=95035

Reviewed by Oliver Hunt.

The comment is both wrong (storage access instructions don't reference CheckStructure)
and highly redundant: of course it's the case that two structures may have the same
identifier. Our interference analyses currently don't care about this and make the
conservative assumptions when necessary (same identifier, same object -> must be same
property; same identifier, may be same object -> may be the same property). Better to
remove the bogus comment since the code that operates over this data structure is
fairly self-explanatory already.

  • dfg/DFGGraph.h:

(StorageAccessData):

12:41 PM Changeset in webkit [126711] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Suppress Mac test requiring rebaseline after r126683.

Unreviewed gardening.

fast/repaint/control-clip.html was suppressed and failing already so remove it from
the tests requiring rebaseline after r126683.

  • platform/chromium/TestExpectations:
12:34 PM Changeset in webkit [126710] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Suppress test requiring rebaseline after r126683

Unreviewed, gardening.

  • platform/chromium/TestExpectations:
11:42 AM Changeset in webkit [126709] by pfeldman@chromium.org
  • 10 edits in trunk

Web Inspector: make ConsoleView listen to the JavaScriptContextManager
https://bugs.webkit.org/show_bug.cgi?id=94940

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Otherwise, model is pushing data into the UI.

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.clone):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._contextAdded):
(WebInspector.ConsoleView.prototype._addContext):
(WebInspector.ConsoleView.prototype._contextRemoved):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager):
(WebInspector.JavaScriptContextManager.prototype.contexts):
(WebInspector.JavaScriptContextManager.prototype._frameAdded):
(WebInspector.JavaScriptContextManager.prototype._frameDetached):

  • inspector/front-end/ParsedURL.js:

(WebInspector.ParsedURL.completeURL):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.createLink):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/elements/elements-panel-rewrite-href-expected.txt:
  • inspector/styles/styles-url-linkify-expected.txt:
11:23 AM Changeset in webkit [126708] by fpizlo@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

Don't allocate space for arguments and call frame if arguments aren't captured
https://bugs.webkit.org/show_bug.cgi?id=95024

Reviewed by Geoffrey Garen.

Test coverage for the case where an argument was legitimately captured.

  • fast/js/jsc-test-list:
  • fast/js/legitimately-captured-argument-expected.txt: Added.
  • fast/js/legitimately-captured-argument.html: Added.
  • fast/js/script-tests/legitimately-captured-argument.js: Added.
7:35 AM Changeset in webkit [126707] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Suppress 6 failing tests on Qt.

Unreviewed gardening.

  • platform/qt/TestExpectations:
6:58 AM Changeset in webkit [126706] by pfeldman@chromium.org
  • 11 edits
    1 copy in trunk/Source/WebCore

Web Inspector: provide "show function definition" and "reveal in elements panel" using context menu provider.
https://bugs.webkit.org/show_bug.cgi?id=94932

Reviewed by Vsevolod Vlasov.

Moved corresponding context menu providers into scripts and elements panels.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.revealAndSelectNode):
(WebInspector.ElementsPanel.prototype.appendApplicableItems.selectNode):
(WebInspector.ElementsPanel.prototype.appendApplicableItems.revealElement):
(WebInspector.ElementsPanel.prototype.appendApplicableItems):

  • inspector/front-end/ElementsPanelDescriptor.js: Copied from Source/WebCore/inspector/front-end/ScriptsPanelDescriptor.js.

(WebInspector.ElementsPanelDescriptor):
(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection.prototype._contextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuFired):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.appendApplicableItems):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._appendFunctionItems.didGetDetails):
(WebInspector.ScriptsPanel.prototype._appendFunctionItems.revealFunction):
(WebInspector.ScriptsPanel.prototype._appendFunctionItems):

  • inspector/front-end/ScriptsPanelDescriptor.js:

(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):

6:48 AM Changeset in webkit [126705] by anilsson@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ASSERT failed in WebPagePrivate::commitRootLayerIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=94921

PR 104676
As visibility changed due to WebPage::setVisible(true),
resumeRootLayerCommit() would call commitRootLayerIfNeeded(), without
layouting or rendering. If a one shot drawing sync was pending at this
time, it would cause the condition
ASSERT(!needsOneShotDrawingSynchronization()) to fail.

The comment immediately before the assert states that "In case of one
shot drawing synchronization, you should first layoutIfNeeded, render,
then commit and draw the layers". However, resumeRootLayerCommit() did
no such thing.

Fixed by removing the call to commitRootLayerIfNeeded() from
resumeRootLayerCommit(), because the latter is only called in a code
path where we're going to layout, render and then commit anyway. These
operations will be performed from resumeBackingStore() which is called
at the end of setVisible().

Reviewed by George Staikos.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):

6:30 AM Changeset in webkit [126704] by robert@webkit.org
  • 134 edits
    128 copies
    71 adds in trunk/LayoutTests

Rebaseline Mac test results after r126683.

Unreviewed gardening.

  • platform/mac-lion/animations/cross-fade-border-image-source-expected.txt: Copied from LayoutTests/platform/mac/animations/cross-fade-border-image-source-expected.txt.
  • platform/mac-lion/css1/box_properties/border_bottom-expected.txt: Copied from LayoutTests/platform/mac/css1/box_properties/border_bottom-expected.txt.
  • platform/mac-lion/css1/box_properties/border_bottom_inline-expected.txt: Copied from LayoutTests/platform/mac/css1/box_properties/border_bottom_inline-expected.txt.
  • platform/mac-lion/css1/box_properties/border_left-expected.txt: Copied from LayoutTests/platform/mac/css1/box_properties/border_left-expected.txt.
  • platform/mac-lion/css1/box_properties/border_left_inline-expected.txt: Copied from LayoutTests/platform/mac/css1/box_properties/border_left_inline-expected.txt.
  • platform/mac-lion/css1/box_properties/border_right-expected.txt: Copied from LayoutTests/platform/mac/css1/box_properties/border_right-expected.txt.
  • platform/mac-lion/css1/box_properties/border_right_inline-expected.txt: Copied from LayoutTests/platform/mac/css1/box_properties/border_right_inline-expected.txt.
  • platform/mac-lion/css1/units/length_units-expected.txt: Copied from LayoutTests/platform/mac/css1/units/length_units-expected.txt.
  • platform/mac-lion/css2.1/20110323/absolute-replaced-height-036-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/absolute-replaced-height-036-expected.txt.
  • platform/mac-lion/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
  • platform/mac-lion/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-height-007-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-height-007-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-height-008-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-height-008-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-height-009-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-height-009-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-height-010-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-height-010-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-001-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-width-001-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-002-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-width-002-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-003-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-width-003-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-004-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-width-004-expected.txt.
  • platform/mac-lion/css2.1/20110323/block-non-replaced-width-008-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt.
  • platform/mac-lion/css2.1/20110323/margin-applies-to-008-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/margin-applies-to-008-expected.txt.
  • platform/mac-lion/css2.1/20110323/width-non-replaced-inline-001-expected.txt: Copied from LayoutTests/platform/mac/css2.1/20110323/width-non-replaced-inline-001-expected.txt.
  • platform/mac-lion/css2.1/t040302-c61-phys-len-00-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t040302-c61-phys-len-00-b-expected.txt.
  • platform/mac-lion/css2.1/t0804-c5507-padn-r-02-f-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0804-c5507-padn-r-02-f-expected.txt.
  • platform/mac-lion/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt.
  • platform/mac-lion/css2.1/t0804-c5509-padn-l-02-f-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0804-c5509-padn-l-02-f-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5519-brdr-r-01-e-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5519-brdr-r-02-e-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5519-brdr-r-02-e-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5520-brdr-b-00-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5520-brdr-b-00-a-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5521-brdr-l-02-e-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5521-brdr-l-02-e-expected.txt.
  • platform/mac-lion/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt.
  • platform/mac-lion/css3/selectors3/html/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt.
  • platform/mac-lion/css3/selectors3/html/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt.
  • platform/mac-lion/css3/selectors3/xhtml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt.
  • platform/mac-lion/css3/selectors3/xhtml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt.
  • platform/mac-lion/css3/selectors3/xml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt.
  • platform/mac-lion/css3/selectors3/xml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt.
  • platform/mac-lion/editing/deleting/type-delete-after-quote-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/type-delete-after-quote-expected.txt.
  • platform/mac-lion/editing/execCommand/4580583-1-expected.txt: Copied from LayoutTests/platform/mac/editing/execCommand/4580583-1-expected.txt.
  • platform/mac-lion/editing/execCommand/4580583-2-expected.txt: Copied from LayoutTests/platform/mac/editing/execCommand/4580583-2-expected.txt.
  • platform/mac-lion/editing/inserting/5418891-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/5418891-expected.txt.
  • platform/mac-lion/editing/inserting/5510537-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/5510537-expected.txt.
  • platform/mac-lion/editing/inserting/6703873-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/6703873-expected.txt.
  • platform/mac-lion/editing/inserting/break-blockquote-after-delete-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt.
  • platform/mac-lion/editing/pasteboard/5006779-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/5006779-expected.txt.
  • platform/mac-lion/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt.
  • platform/mac-lion/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt.
  • platform/mac-lion/fast/block/float/012-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/012-expected.txt.
  • platform/mac-lion/fast/block/float/013-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/013-expected.txt.
  • platform/mac-lion/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/mac-lion/fast/block/margin-collapse/041-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/041-expected.txt.
  • platform/mac-lion/fast/block/margin-collapse/043-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/043-expected.txt.
  • platform/mac-lion/fast/block/margin-collapse/057-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/057-expected.txt.
  • platform/mac-lion/fast/block/positioning/inline-block-relposition-expected.txt: Copied from LayoutTests/platform/mac/fast/block/positioning/inline-block-relposition-expected.txt.
  • platform/mac-lion/fast/borders/border-radius-wide-border-01-expected.txt: Added.
  • platform/mac-lion/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/mac-lion/fast/css/acid2-expected.txt: Copied from LayoutTests/platform/mac/http/tests/misc/acid2-expected.txt.
  • platform/mac-lion/fast/css/acid2-pixel-expected.txt: Copied from LayoutTests/platform/mac/fast/css/acid2-pixel-expected.txt.
  • platform/mac-lion/fast/css/border-height-expected.txt: Copied from LayoutTests/platform/mac/fast/css/border-height-expected.txt.
  • platform/mac-lion/fast/css/caption-width-absolute-position-expected.txt: Copied from LayoutTests/platform/mac/fast/css/caption-width-absolute-position-expected.txt.
  • platform/mac-lion/fast/css/caption-width-absolute-position-offset-top-expected.txt: Copied from LayoutTests/platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt.
  • platform/mac-lion/fast/css/caption-width-fixed-position-expected.txt: Copied from LayoutTests/platform/mac/fast/css/caption-width-fixed-position-expected.txt.
  • platform/mac-lion/fast/css/caption-width-fixed-position-offset-top-expected.txt: Copied from LayoutTests/platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt.
  • platform/mac-lion/fast/css/line-height-determined-by-primary-font-expected.txt: Copied from LayoutTests/platform/mac/fast/css/line-height-determined-by-primary-font-expected.txt.
  • platform/mac-lion/fast/css/pseudo-first-line-border-width-expected.txt: Copied from LayoutTests/platform/mac/fast/css/pseudo-first-line-border-width-expected.txt.
  • platform/mac-lion/fast/css/rtl-ordering-expected.txt: Copied from LayoutTests/platform/mac/fast/css/rtl-ordering-expected.txt.
  • platform/mac-lion/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt.
  • platform/mac-lion/fast/dynamic/positioned-movement-with-positioned-children-expected.txt: Copied from LayoutTests/platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.txt.
  • platform/mac-lion/fast/forms/basic-buttons-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-buttons-expected.txt.
  • platform/mac-lion/fast/forms/box-shadow-override-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/box-shadow-override-expected.txt.
  • platform/mac-lion/fast/forms/button-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-align-expected.txt.
  • platform/mac-lion/fast/forms/button-cannot-be-nested-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-cannot-be-nested-expected.txt.
  • platform/mac-lion/fast/forms/button-generated-content-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-generated-content-expected.txt.
  • platform/mac-lion/fast/forms/button-inner-block-reuse-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-inner-block-reuse-expected.txt.
  • platform/mac-lion/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
  • platform/mac-lion/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
  • platform/mac-lion/fast/forms/button-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-style-color-expected.txt.
  • platform/mac-lion/fast/forms/button-text-transform-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-text-transform-expected.txt.
  • platform/mac-lion/fast/forms/button-white-space-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-white-space-expected.txt.
  • platform/mac-lion/fast/forms/control-clip-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.txt.
  • platform/mac-lion/fast/forms/select-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-baseline-expected.txt.
  • platform/mac-lion/fast/frames/viewsource-attribute-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/viewsource-attribute-expected.txt.
  • platform/mac-lion/fast/frames/viewsource-on-image-file-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/viewsource-on-image-file-expected.txt.
  • platform/mac-lion/fast/hidpi/image-set-border-image-comparison-expected.txt: Copied from LayoutTests/platform/mac/fast/hidpi/image-set-border-image-comparison-expected.txt.
  • platform/mac-lion/fast/hidpi/image-set-border-image-dynamic-expected.txt: Copied from LayoutTests/platform/mac/fast/hidpi/image-set-border-image-dynamic-expected.txt.
  • platform/mac-lion/fast/inline/inline-padding-disables-text-quirk-expected.txt: Copied from LayoutTests/platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.txt.
  • platform/mac-lion/fast/inline/inline-text-quirk-bpm-expected.txt: Copied from LayoutTests/platform/mac/fast/inline/inline-text-quirk-bpm-expected.txt.
  • platform/mac-lion/fast/invalid/residual-style-expected.txt: Copied from LayoutTests/platform/mac/fast/invalid/residual-style-expected.txt.
  • platform/mac-lion/fast/layers/scroll-rect-to-visible-expected.txt: Copied from LayoutTests/platform/mac/fast/layers/scroll-rect-to-visible-expected.txt.
  • platform/mac-lion/fast/lists/007-expected.txt: Copied from LayoutTests/platform/mac/fast/lists/007-expected.txt.
  • platform/mac-lion/fast/multicol/block-axis-horizontal-bt-expected.txt: Copied from LayoutTests/platform/mac/fast/multicol/block-axis-horizontal-bt-expected.txt.
  • platform/mac-lion/fast/multicol/block-axis-vertical-lr-expected.txt: Copied from LayoutTests/platform/mac/fast/multicol/block-axis-vertical-lr-expected.txt.
  • platform/mac-lion/fast/multicol/block-axis-vertical-rl-expected.txt: Copied from LayoutTests/platform/mac/fast/multicol/block-axis-vertical-rl-expected.txt.
  • platform/mac-lion/fast/multicol/progression-reverse-expected.txt: Added.
  • platform/mac-lion/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
  • platform/mac-lion/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
  • platform/mac-lion/fast/overflow/overflow-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/overflow-rtl-expected.txt.
  • platform/mac-lion/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt.
  • platform/mac-lion/fast/repaint/control-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/control-clip-expected.txt.
  • platform/mac-lion/fast/replaced/replaced-breaking-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt.
  • platform/mac-lion/fast/selectors/064-expected.txt: Copied from LayoutTests/platform/mac/fast/selectors/064-expected.txt.
  • platform/mac-lion/fast/table/append-cells2-expected.txt: Copied from LayoutTests/platform/mac/fast/table/append-cells2-expected.txt.
  • platform/mac-lion/fast/table/border-collapsing/003-expected.txt: Copied from LayoutTests/platform/mac/fast/table/border-collapsing/003-expected.txt.
  • platform/mac-lion/fast/table/border-collapsing/003-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/table/border-collapsing/003-vertical-expected.txt.
  • platform/mac-lion/fast/table/border-collapsing/equal-precedence-resolution-expected.txt: Copied from LayoutTests/platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt.
  • platform/mac-lion/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt.
  • platform/mac-lion/fast/table/border-collapsing/rtl-border-collapsing-expected.txt: Copied from LayoutTests/platform/mac/fast/table/border-collapsing/rtl-border-collapsing-expected.txt.
  • platform/mac-lion/fast/table/colgroup-spanning-groups-rules-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colgroup-spanning-groups-rules-expected.txt.
  • platform/mac-lion/fast/table/remove-td-display-none-expected.txt: Copied from LayoutTests/platform/mac/fast/table/remove-td-display-none-expected.txt.
  • platform/mac-lion/fast/text/apply-start-width-after-skipped-text-expected.txt: Copied from LayoutTests/platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt.
  • platform/mac-lion/fast/text/basic/015-expected.txt: Copied from LayoutTests/platform/mac/fast/text/basic/015-expected.txt.
  • platform/mac-lion/fast/text/monospace-width-cache-expected.txt: Copied from LayoutTests/platform/mac/fast/text/monospace-width-cache-expected.txt.
  • platform/mac-lion/fast/writing-mode/broken-ideographic-font-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/broken-ideographic-font-expected.txt.
  • platform/mac-lion/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/mac-lion/http/tests/misc/acid2-expected.txt: Copied from LayoutTests/platform/mac/http/tests/misc/acid2-expected.txt.
  • platform/mac-lion/http/tests/misc/acid2-pixel-expected.txt: Copied from LayoutTests/platform/mac/fast/css/acid2-pixel-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt.
  • platform/mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Copied from LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt.
  • platform/mac-lion/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt.
  • platform/mac-lion/tables/mozilla/bugs/bug68912-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug68912-expected.txt.
  • platform/mac-lion/tables/mozilla/core/table_rules-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/core/table_rules-expected.txt.
  • platform/mac-lion/tables/mozilla/marvin/x_table_rules_groups-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/x_table_rules_groups-expected.txt.
  • platform/mac-lion/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt.
  • platform/mac-lion/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt.
  • platform/mac-lion/transforms/2d/transform-borderbox-expected.txt: Copied from LayoutTests/platform/mac/transforms/2d/transform-borderbox-expected.txt.
  • platform/mac-lion/transforms/2d/transform-origin-borderbox-expected.txt: Copied from LayoutTests/platform/mac/transforms/2d/transform-origin-borderbox-expected.txt.
  • platform/mac-lion/transitions/cross-fade-border-image-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/mac/animations/cross-fade-border-image-source-expected.txt:
  • platform/mac/css1/box_properties/border_bottom-expected.txt:
  • platform/mac/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/mac/css1/box_properties/border_left-expected.txt:
  • platform/mac/css1/box_properties/border_left_inline-expected.txt:
  • platform/mac/css1/box_properties/border_right-expected.txt:
  • platform/mac/css1/box_properties/border_right_inline-expected.txt:
  • platform/mac/css1/units/length_units-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-036-expected.txt:
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-height-009-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-001-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-002-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-003-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-004-expected.txt:
  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/mac/css2.1/20110323/margin-applies-to-008-expected.txt:
  • platform/mac/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
  • platform/mac/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/mac/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/mac/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/mac/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/mac/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt:
  • platform/mac/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/mac/editing/execCommand/4580583-1-expected.txt:
  • platform/mac/editing/execCommand/4580583-2-expected.txt:
  • platform/mac/editing/inserting/5418891-expected.txt:
  • platform/mac/editing/inserting/5510537-expected.txt:
  • platform/mac/editing/inserting/6703873-expected.txt:
  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/mac/editing/pasteboard/5006779-expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/mac/fast/block/float/012-expected.txt:
  • platform/mac/fast/block/float/013-expected.txt:
  • platform/mac/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/mac/fast/block/margin-collapse/041-expected.txt:
  • platform/mac/fast/block/margin-collapse/043-expected.txt:
  • platform/mac/fast/block/margin-collapse/057-expected.txt:
  • platform/mac/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/mac/fast/borders/border-radius-wide-border-01-expected.txt: Added.
  • platform/mac/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/mac/fast/css/acid2-expected.txt:
  • platform/mac/fast/css/acid2-pixel-expected.txt:
  • platform/mac/fast/css/border-height-expected.txt:
  • platform/mac/fast/css/caption-width-absolute-position-expected.txt:
  • platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt:
  • platform/mac/fast/css/caption-width-fixed-position-expected.txt:
  • platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt:
  • platform/mac/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/mac/fast/css/pseudo-first-line-border-width-expected.txt:
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
  • platform/mac/fast/forms/basic-buttons-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/button-align-expected.txt:
  • platform/mac/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/mac/fast/forms/button-generated-content-expected.txt:
  • platform/mac/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/mac/fast/forms/button-positioned-expected.txt:
  • platform/mac/fast/forms/button-sizes-expected.txt:
  • platform/mac/fast/forms/button-style-color-expected.txt:
  • platform/mac/fast/forms/button-text-transform-expected.txt:
  • platform/mac/fast/forms/button-white-space-expected.txt:
  • platform/mac/fast/forms/control-clip-overflow-expected.txt:
  • platform/mac/fast/forms/select-baseline-expected.txt:
  • platform/mac/fast/frames/viewsource-attribute-expected.txt:
  • platform/mac/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/mac/fast/hidpi/image-set-border-image-comparison-expected.txt:
  • platform/mac/fast/hidpi/image-set-border-image-dynamic-expected.txt:
  • platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.txt:
  • platform/mac/fast/inline/inline-text-quirk-bpm-expected.txt:
  • platform/mac/fast/invalid/residual-style-expected.txt:
  • platform/mac/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/mac/fast/lists/007-expected.txt:
  • platform/mac/fast/multicol/block-axis-horizontal-bt-expected.txt:
  • platform/mac/fast/multicol/block-axis-vertical-lr-expected.txt:
  • platform/mac/fast/multicol/block-axis-vertical-rl-expected.txt:
  • platform/mac/fast/multicol/progression-reverse-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
  • platform/mac/fast/overflow/overflow-rtl-expected.txt:
  • platform/mac/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/mac/fast/repaint/control-clip-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/selectors/064-expected.txt:
  • platform/mac/fast/table/append-cells2-expected.txt:
  • platform/mac/fast/table/border-collapsing/003-expected.txt:
  • platform/mac/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
  • platform/mac/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/mac/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/mac/fast/table/remove-td-display-none-expected.txt:
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt:
  • platform/mac/fast/text/basic/015-expected.txt:
  • platform/mac/fast/text/monospace-width-cache-expected.txt:
  • platform/mac/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/mac/http/tests/misc/acid2-expected.txt:
  • platform/mac/http/tests/misc/acid2-pixel-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug68912-expected.txt:
  • platform/mac/tables/mozilla/core/table_rules-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/mac/transforms/2d/transform-borderbox-expected.txt:
  • platform/mac/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/mac/transitions/cross-fade-border-image-expected.txt: Added.
5:00 AM Changeset in webkit [126703] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Stop leaking a pthread_attr in CookieDatabaseBackingStore
https://bugs.webkit.org/show_bug.cgi?id=95029

Patch by Joe Mason <jmason@rim.com> on 2012-08-26
Reviewed by Rob Buis.

No new tests (no behaviour change)
RIM PR 198519

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::CookieDatabaseBackingStore): use pthread_attr_default
instead of pthread_attr_init

4:18 AM Changeset in webkit [126702] by robert@webkit.org
  • 87 edits
    9 adds in trunk/LayoutTests

Rebaseline Qt test results after r126683.

Unreviewed gardening.

  • platform/qt-4.8/TestExpectations:
  • platform/qt-linux/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/animations/cross-fade-border-image-source-expected.txt:
  • platform/qt/css1/box_properties/border_bottom-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/qt/css1/box_properties/border_left-expected.txt:
  • platform/qt/css1/box_properties/border_left_inline-expected.txt:
  • platform/qt/css1/box_properties/border_right-expected.txt:
  • platform/qt/css1/box_properties/border_right_inline-expected.txt:
  • platform/qt/css1/units/length_units-expected.txt:
  • platform/qt/css2.1/20110323/absolute-replaced-height-036-expected.txt:
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-007-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-009-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-001-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-002-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-003-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-004-expected.txt:
  • platform/qt/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/qt/css2.1/20110323/margin-applies-to-008-expected.txt:
  • platform/qt/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
  • platform/qt/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/qt/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/qt/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/qt/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/qt/editing/execCommand/4580583-1-expected.txt:
  • platform/qt/editing/execCommand/4580583-2-expected.txt:
  • platform/qt/editing/inserting/5418891-expected.txt:
  • platform/qt/editing/inserting/5510537-expected.txt:
  • platform/qt/editing/inserting/6703873-expected.txt:
  • platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/qt/editing/pasteboard/5006779-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/qt/fast/block/float/012-expected.txt:
  • platform/qt/fast/block/float/013-expected.txt:
  • platform/qt/fast/block/float/016-expected.txt:
  • platform/qt/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/qt/fast/block/margin-collapse/041-expected.txt:
  • platform/qt/fast/block/margin-collapse/043-expected.txt:
  • platform/qt/fast/block/margin-collapse/057-expected.txt:
  • platform/qt/fast/borders/border-radius-wide-border-01-expected.txt: Added.
  • platform/qt/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/qt/fast/css/acid2-expected.txt:
  • platform/qt/fast/css/acid2-pixel-expected.txt:
  • platform/qt/fast/css/border-height-expected.txt:
  • platform/qt/fast/css/caption-width-absolute-position-expected.txt:
  • platform/qt/fast/css/caption-width-absolute-position-offset-top-expected.txt:
  • platform/qt/fast/css/caption-width-fixed-position-expected.txt:
  • platform/qt/fast/css/caption-width-fixed-position-offset-top-expected.txt:
  • platform/qt/fast/css/pseudo-first-line-border-width-expected.txt: Added.
  • platform/qt/fast/frames/viewsource-attribute-expected.txt:
  • platform/qt/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/qt/fast/inline/inline-padding-disables-text-quirk-expected.txt:
  • platform/qt/fast/inline/inline-text-quirk-bpm-expected.txt:
  • platform/qt/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/qt/fast/lists/007-expected.txt:
  • platform/qt/fast/multicol/block-axis-horizontal-bt-expected.txt:
  • platform/qt/fast/multicol/block-axis-vertical-lr-expected.txt:
  • platform/qt/fast/multicol/block-axis-vertical-rl-expected.txt:
  • platform/qt/fast/multicol/progression-reverse-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
  • platform/qt/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/qt/fast/table/border-collapsing/003-expected.txt:
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/qt/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/qt/fast/text/apply-start-width-after-skipped-text-expected.txt:
  • platform/qt/http/tests/misc/acid2-expected.txt:
  • platform/qt/http/tests/misc/acid2-pixel-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
  • platform/qt/tables/mozilla/core/table_rules-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/qt/transforms/2d/transform-borderbox-expected.txt:
  • platform/qt/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/qt/transitions/cross-fade-border-image-expected.txt:
3:47 AM Changeset in webkit [126701] by robert@webkit.org
  • 87 edits
    2 copies
    8 adds in trunk/LayoutTests

Rebaseline EFL test results after r126683.

Unreviewed gardening.

  • platform/efl/TestExpectations:
  • platform/efl/animations/cross-fade-border-image-source-expected.txt:
  • platform/efl/css1/box_properties/border_bottom-expected.txt:
  • platform/efl/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/efl/css1/box_properties/border_left-expected.txt:
  • platform/efl/css1/box_properties/border_left_inline-expected.txt:
  • platform/efl/css1/box_properties/border_right-expected.txt:
  • platform/efl/css1/box_properties/border_right_inline-expected.txt:
  • platform/efl/css1/units/length_units-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-036-expected.txt:
  • platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-height-009-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-width-001-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-width-002-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-width-003-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-width-004-expected.txt:
  • platform/efl/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/efl/css2.1/20110323/margin-applies-to-008-expected.txt:
  • platform/efl/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
  • platform/efl/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/efl/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/efl/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/efl/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/efl/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/efl/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/efl/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/efl/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/efl/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/efl/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/efl/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/efl/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/efl/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/efl/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/efl/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/efl/editing/execCommand/4580583-1-expected.txt:
  • platform/efl/editing/execCommand/4580583-2-expected.txt:
  • platform/efl/fast/block/float/012-expected.txt:
  • platform/efl/fast/block/float/013-expected.txt:
  • platform/efl/fast/block/float/016-expected.txt: Added.
  • platform/efl/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/efl/fast/block/margin-collapse/041-expected.txt:
  • platform/efl/fast/block/margin-collapse/043-expected.txt:
  • platform/efl/fast/block/margin-collapse/057-expected.txt:
  • platform/efl/fast/borders/border-radius-wide-border-01-expected.txt: Added.
  • platform/efl/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/efl/fast/css/acid2-expected.txt: Copied from LayoutTests/platform/efl/http/tests/misc/acid2-expected.txt.
  • platform/efl/fast/css/acid2-pixel-expected.txt: Copied from LayoutTests/platform/efl/http/tests/misc/acid2-expected.txt.
  • platform/efl/fast/css/border-height-expected.txt:
  • platform/efl/fast/css/caption-width-absolute-position-expected.txt:
  • platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt:
  • platform/efl/fast/css/caption-width-fixed-position-expected.txt:
  • platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt:
  • platform/efl/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/efl/fast/css/pseudo-first-line-border-width-expected.txt:
  • platform/efl/fast/frames/viewsource-attribute-expected.txt:
  • platform/efl/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/efl/fast/inline/inline-padding-disables-text-quirk-expected.txt:
  • platform/efl/fast/inline/inline-text-quirk-bpm-expected.txt:
  • platform/efl/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/efl/fast/lists/007-expected.txt:
  • platform/efl/fast/multicol/block-axis-horizontal-bt-expected.txt:
  • platform/efl/fast/multicol/block-axis-vertical-lr-expected.txt:
  • platform/efl/fast/multicol/block-axis-vertical-rl-expected.txt:
  • platform/efl/fast/multicol/progression-reverse-expected.txt: Added.
  • platform/efl/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
  • platform/efl/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
  • platform/efl/fast/overflow/overflow-rtl-expected.txt: Added.
  • platform/efl/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/efl/fast/table/border-collapsing/003-expected.txt:
  • platform/efl/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/efl/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
  • platform/efl/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
  • platform/efl/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/efl/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/efl/fast/text/apply-start-width-after-skipped-text-expected.txt:
  • platform/efl/fast/text/basic/015-expected.txt:
  • platform/efl/fast/text/monospace-width-cache-expected.txt:
  • platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
  • platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/efl/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/efl/http/tests/misc/acid2-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
  • platform/efl/transforms/2d/transform-borderbox-expected.txt:
  • platform/efl/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/efl/transitions/cross-fade-border-image-expected.txt:
1:40 AM Changeset in webkit [126700] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping fast/block/float/016.html to green the platform mac bots.
https://bugs.webkit.org/show_bug.cgi?id=95028.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-26
Reviewed by Filip Pizlo.

  • platform/mac/Skipped:
12:16 AM Changeset in webkit [126699] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Added test-generated expected results file for a few compositing
overflow tests.
https://bugs.webkit.org/show_bug.cgi?id=95023.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-26
Reviewed by Filip Pizlo.

  • platform/mac/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt: Added.
  • platform/mac/compositing/overflow/nested-scrolling-expected.txt: Added.
  • platform/mac/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor-expected.txt: Added.
  • platform/mac/compositing/overflow/remove-overflow-crash2-expected.txt: Added.

Aug 25, 2012:

9:03 PM Changeset in webkit [126698] by Dave Barton
  • 6 edits in trunk

Remove { vertical-align: baseline } declarations from mathml.css
https://bugs.webkit.org/show_bug.cgi?id=95015

Reviewed by Eric Seidel.

Source/WebCore:

The { vertical-align: baseline } declarations in mathml.css had no positive effect, and could
wrongly override a previous { vertical-align: sub } or { vertical-align: super } declaration.

Added 1 test to mathml/presentation/subsup.xhtml.

  • css/mathml.css:

(math):
(mrow, mfenced):
(msub, msup):
(msubsup):
(munder, mover, munderover):

  • Remove { vertical-align: baseline } declarations

LayoutTests:

Added 1 test to mathml/presentation/subsup.xhtml.

  • mathml/presentation/subsup.xhtml:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
8:58 PM Changeset in webkit [126697] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2012-08-25 Geoffrey Garen <ggaren@apple.com>

Try a little harder to fix the Linux build.

  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
8:53 PM Changeset in webkit [126696] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-08-25 Geoffrey Garen <ggaren@apple.com>

Try to fix the Linux build.

  • runtime/JSActivation.cpp:
8:25 PM Changeset in webkit [126695] by ggaren@apple.com
  • 30 edits in trunk/Source/JavaScriptCore

Don't use malloc / destructors for activation objects
https://bugs.webkit.org/show_bug.cgi?id=94897

Reviewed by Oliver Hunt.

65% faster on v8-real-earley.

Lots of boilerplate here, but the jist is this:

(1) Use CopiedSpace instead of malloc to allocate the activation's
backing store.

(2) Use MarkedSpace instead of ref-counting to allocate the symbol table.

(3) ==> No more destructor.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::stronglyVisitStrongReferences):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::symbolTable):
(CodeBlock):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(FunctionCodeBlock): SymbolTable is a GC object now, so it gets a write
barrier and visit calls instead of ref-counting. I changed all CodeBlocks
to use shared symbol tables because the distinction between shared and
unshared hurt my head.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
(JSC::BytecodeGenerator::emitPutStaticVar):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Sometimes, a period just wants
to be an arrow. And then C++ is there to accommodate.

  • jit/JITDriver.h:

(JSC::jitCompileFunctionIfAppropriate):

  • runtime/Arguments.h:

(ArgumentsData):
(JSC::Arguments::setRegisters):
(Arguments):
(JSC::Arguments::argument):
(JSC::Arguments::finishCreation):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
(JSC::FunctionExecutable::visitChildren):

  • runtime/Executable.h:

(JSC::FunctionExecutable::symbolTable):
(FunctionExecutable):

  • runtime/ExecutionHarness.h:

(JSC::prepareFunctionForExecution): I changed from WriteBarrier to
WriteBarrierBase so activations could reuse StorageBarrier and PropertyStorage.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):
(JSC::JSActivation::finishCreation): Allocate the symbol table here,
after we're fully constructed, to avoid GC during initialization.

(JSC::JSActivation::visitChildren):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

  • runtime/JSActivation.h:

(JSC::JSActivation::create):
(JSActivation):
(JSC::JSActivation::registerOffset):
(JSC):
(JSC::JSActivation::registerArraySize):
(JSC::JSActivation::registerArraySizeInBytes):
(JSC::JSActivation::tearOff): Tear-off zero-initializes all uncopied
registers. This makes it safe to copyAndAppend the full buffer in
visitChildren, without any extra checks.

  • runtime/JSCell.h:

(JSCell): Moved a shared default set of flags into this base class, so
I could use it in a few places.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData): New structure for symbol tables.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::addStaticGlobals):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::symbolTableHasProperty): We don't need an inline
symbol table -- JSSymbolTableObject will GC allocate one for us.

  • runtime/JSObject.h:

(JSObject):

  • runtime/JSSegmentedVariableObject.h:

(JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):

  • runtime/JSStaticScopeObject.cpp:

(JSC):
(JSC::JSStaticScopeObject::visitChildren): NULL check our register store
because finishCreation allocates an object now, so we may get marked
before we've assigned to our register store.

  • runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::finishCreation):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
(JSStaticScopeObject): No more destructor for this object, either, since
it no longer embeds a hash table.

  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::visitChildren):
(JSC::JSSymbolTableObject::deleteProperty):
(JSC::JSSymbolTableObject::getOwnPropertyNames):

  • runtime/JSSymbolTableObject.h:

(JSC::JSSymbolTableObject::symbolTable):
(JSSymbolTableObject):
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):
(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes): SymbolTableObject allocates a symbol
table automatically if one isn't provided. (Activations provide their
own, which they get from compiled code.)

  • runtime/JSVariableObject.cpp:

(JSC):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::registerAt):
(JSC::JSVariableObject::addressOfRegisters):
(JSVariableObject):
(JSC::JSVariableObject::JSVariableObject):
(JSC::JSVariableObject::finishCreation): Removed a bunch of obsolete code.
Activations manage their registers directly now.

  • runtime/StorageBarrier.h:

(StorageBarrier):
(JSC::StorageBarrier::operator!):

  • runtime/SymbolTable.cpp:

(JSC):
(JSC::SharedSymbolTable::destroy):

  • runtime/SymbolTable.h:

(JSC::SharedSymbolTable::create):
(SharedSymbolTable):
(JSC::SharedSymbolTable::createStructure):
(JSC::SharedSymbolTable::SharedSymbolTable): Boilerplat code to
make shared symbol table GC-allocated.

6:51 PM Changeset in webkit [126694] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[Texmap] Move TextureMapperGL to use GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=78672

Patch by Roland Takacs <rtakacs@inf.u-szeged.hu>, Helder Correia <Helder Correia> on 2012-08-25
Reviewed by Noam Rosenthal.

It is based on a previous patch by Helder Correia.

TextureMapperGL (TMGL) includes direct GL calls and
GraphicsContext3D (GC3D) offers many conveniences over the
former approach: using existing CSS shader code, ANGLE for
shader compilation, reusing WebCore::Texture, having shaders and
textures that can delete themselves.

A GC3D object is created by TMGL with the newly introduced
builder createForCurrentGLContext(), which in turn uses
the new RenderToCurrentGLContext flag underneath.

TMGL's dependency on OpenGLShims.h was completely removed.
However, GC3D does not map every single GL constant. Thus, it's
important to document the following:

  • GL_FALSE was mapped to false.
  • GL_UNPACK_ROW_LENGTH, GL_UNPACK_SKIP_PIXELS, GL_UNPACK_SKIP_ROWS, GL_TEXTURE_RECTANGLE_ARB, and GL_UNSIGNED_INT_8_8_8_8_REV were locally defined in TMGL.

The patch was originally developed by Helder Correia and finished
by Roland Takacs.

No new tests, refactoring.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
(WebCore::TextureMapperGLData::sharedGLData):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore::scissorClip):
(WebCore::TextureMapperGL::ClipStack::apply):
(WebCore::TextureMapperGLData::initializeStencil):
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawQuad):
(WebCore::TextureMapperGL::drawBorder):
(WebCore):
(WebCore::TextureMapperGL::drawTextureRectangleARB):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::viewportMatrix):
(WebCore::TextureMapperGL::drawTextureWithAntialiasing):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bind):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::TextureMapperGL::bindDefaultSurface):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):
(WebCore::TextureMapperGL::createTexture):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::TextureMapperGL::graphicsContext3D):
(TextureMapperGL):
(ClipStack):
(WebCore::BitmapTextureGL::textureTarget):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore):
(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderProgram::TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::initializeProgram):
(WebCore::TextureMapperShaderProgram::getUniformLocation):
(WebCore::TextureMapperShaderProgram::~TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):
(WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple):
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::TextureMapperShaderProgramRectOpacityAndMask):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::TextureMapperShaderProgramAntialiasingNoMask):
(WebCore::TextureMapperShaderManager::TextureMapperShaderManager):
(WebCore::StandardFilterProgram::~StandardFilterProgram):
(WebCore::StandardFilterProgram::StandardFilterProgram):
(WebCore::StandardFilterProgram::create):
(WebCore::StandardFilterProgram::prepare):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore::TextureMapperShaderProgram::id):
(WebCore::TextureMapperShaderProgram::vertexAttrib):
(TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::matrixLocation):
(WebCore::TextureMapperShaderProgram::flipLocation):
(WebCore::TextureMapperShaderProgram::textureSizeLocation):
(WebCore::TextureMapperShaderProgram::sourceTextureLocation):
(WebCore::TextureMapperShaderProgram::maskTextureLocation):
(WebCore::TextureMapperShaderProgram::opacityLocation):
(WebCore::TextureMapperShaderProgram::isValidUniformLocation):
(StandardFilterProgram):
(WebCore::StandardFilterProgram::vertexAttrib):
(WebCore::StandardFilterProgram::texCoordAttrib):
(WebCore::StandardFilterProgram::textureUniform):
(WebCore::TextureMapperShaderProgramSimple::create):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramRectSimple::create):
(TextureMapperShaderProgramRectSimple):
(WebCore::TextureMapperShaderProgramOpacityAndMask::create):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::create):
(TextureMapperShaderProgramRectOpacityAndMask):
(WebCore::TextureMapperShaderProgramSolidColor::create):
(WebCore::TextureMapperShaderProgramSolidColor::colorLocation):
(TextureMapperShaderProgramSolidColor):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::create):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::expandedQuadVerticesInTextureCoordinatesLocation):
(WebCore::TextureMapperShaderProgramAntialiasingNoMask::expandedQuadEdgesInScreenSpaceLocation):
(TextureMapperShaderProgramAntialiasingNoMask):
(WebCore::TextureMapperShaderManager::TextureMapperShaderManager):
(TextureMapperShaderManager):

6:16 PM Changeset in webkit [126693] by pdr@google.com
  • 5 edits in trunk

Roll out r126056 and r126626
https://bugs.webkit.org/show_bug.cgi?id=95017

Reviewed by Dirk Schulze.

Source/WebCore:

This patch rolls out r126056 which regressed a test.
The getBBox() code removed turns out to be required for tight bounding
boxes in SVGPathElement::getBBox().

When this regression occurred the relevant test was skipped in r126626. This
patch reverts that skip.

No new tests.

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::getBBox):
(WebCore):

  • svg/SVGPathElement.h:

(SVGPathElement):

LayoutTests:

Removing skipped test.

  • platform/mac/Skipped:
4:58 PM Changeset in webkit [126692] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

op_call should have ArrayProfiling for the benefit of array intrinsics
https://bugs.webkit.org/show_bug.cgi?id=95014

Reviewed by Sam Weinig.

This is a performance-neutral change that just adds the profiling but does not
use it, yet. If in the future we wanted to make this kind of profiling cheaper
we could move it into specialized thunks for the relevant array intrinsics, but
I figure that if this much simpler change gives us what we need without any
discernable performance penalty then that's for the best.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
4:45 PM Changeset in webkit [126691] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping 4 compositing/overflow tests for gardening.
https://bugs.webkit.org/show_bug.cgi?id=95011.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-25
Reviewed by Sam Weinig.

compositing/overflow/overflow-auto-with-touch.html
compositing/overflow/overflow-overlay-with-touch.html
compositing/overflow/scrolling-content-clip-to-viewport.html
compositing/overflow/textarea-scroll-touch.html

  • platform/mac/Skipped:
4:06 PM Changeset in webkit [126690] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] V8NodeFilterCondition should use ScopedPersistent
https://bugs.webkit.org/show_bug.cgi?id=95010

Reviewed by Eric Seidel.

V8NodeFilterCondition just re-implements ScopedPersistent by hand.

  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::~V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8NodeFilterCondition.h:

(WebCore):
(V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::create):

3:34 PM Changeset in webkit [126689] by fpizlo@apple.com
  • 6 edits
    2 deletes in trunk/Source/JavaScriptCore

The redundant phi elimination phase is not used and should be removed
https://bugs.webkit.org/show_bug.cgi?id=95006

Reviewed by Dan Bernstein.

Just removing dead code.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGDriver.cpp:
  • dfg/DFGRedundantPhiEliminationPhase.cpp: Removed.
  • dfg/DFGRedundantPhiEliminationPhase.h: Removed.
3:26 PM Changeset in webkit [126688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WinCairo Build Broken due to missing export definitions
https://bugs.webkit.org/show_bug.cgi?id=95007

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-08-25
Reviewed by Ryosuke Niwa.

Export symbols were missing from the def file for WinCairo port. Added
these missing symbols to avoid build break

  • win/WebKit2CFLite.def:
2:40 PM Changeset in webkit [126687] by Dave Barton
  • 2 edits in trunk/LayoutTests

Re-unskip 2 previously fixed tests that were accidentally re-skipped in r119192.

Unreviewed, gardening.

  • platform/mac/Skipped:
1:18 PM Changeset in webkit [126686] by zandobersek@gmail.com
  • 120 edits
    10 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining after the changes made in r126683.

  • platform/gtk/TestExpectations:
  • platform/gtk/animations/cross-fade-border-image-source-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left-expected.txt:
  • platform/gtk/css1/box_properties/border_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right-expected.txt:
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt:
  • platform/gtk/css1/units/length_units-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.txt:
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-height-009-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-width-001-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-width-002-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-width-003-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-width-004-expected.txt:
  • platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/gtk/css2.1/20110323/margin-applies-to-008-expected.txt:
  • platform/gtk/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
  • platform/gtk/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/gtk/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/gtk/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/gtk/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/gtk/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/gtk/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/gtk/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/gtk/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/gtk/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/gtk/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/gtk/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/gtk/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/gtk/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/gtk/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/gtk/editing/execCommand/4580583-1-expected.txt:
  • platform/gtk/editing/execCommand/4580583-2-expected.txt:
  • platform/gtk/editing/inserting/5418891-expected.txt:
  • platform/gtk/editing/inserting/5510537-expected.txt:
  • platform/gtk/editing/inserting/6703873-expected.txt:
  • platform/gtk/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/gtk/editing/pasteboard/5006779-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/gtk/fast/block/float/012-expected.txt:
  • platform/gtk/fast/block/float/013-expected.txt:
  • platform/gtk/fast/block/float/016-expected.txt: Added.
  • platform/gtk/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/041-expected.txt:
  • platform/gtk/fast/block/margin-collapse/043-expected.txt:
  • platform/gtk/fast/block/margin-collapse/057-expected.txt:
  • platform/gtk/fast/borders/border-radius-wide-border-01-expected.txt: Added.
  • platform/gtk/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/gtk/fast/css/acid2-expected.txt: Added.
  • platform/gtk/fast/css/acid2-pixel-expected.txt: Added.
  • platform/gtk/fast/css/border-height-expected.txt:
  • platform/gtk/fast/css/caption-width-absolute-position-expected.txt:
  • platform/gtk/fast/css/caption-width-absolute-position-offset-top-expected.txt:
  • platform/gtk/fast/css/caption-width-fixed-position-expected.txt:
  • platform/gtk/fast/css/caption-width-fixed-position-offset-top-expected.txt:
  • platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt:
  • platform/gtk/fast/frames/viewsource-attribute-expected.txt:
  • platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/gtk/fast/hidpi/image-set-border-image-comparison-expected.txt:
  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/gtk/fast/inline/inline-padding-disables-text-quirk-expected.txt:
  • platform/gtk/fast/inline/inline-text-quirk-bpm-expected.txt:
  • platform/gtk/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/fast/lists/007-expected.txt:
  • platform/gtk/fast/multicol/block-axis-horizontal-bt-expected.txt:
  • platform/gtk/fast/multicol/block-axis-vertical-lr-expected.txt:
  • platform/gtk/fast/multicol/block-axis-vertical-rl-expected.txt:
  • platform/gtk/fast/multicol/progression-reverse-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
  • platform/gtk/fast/overflow/overflow-rtl-expected.txt: Added.
  • platform/gtk/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/gtk/fast/table/border-collapsing/003-expected.txt:
  • platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
  • platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
  • platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/gtk/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/gtk/fast/text/apply-start-width-after-skipped-text-expected.txt:
  • platform/gtk/fast/text/basic/015-expected.txt:
  • platform/gtk/fast/text/monospace-width-cache-expected.txt:
  • platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
  • platform/gtk/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/gtk/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/gtk/http/tests/misc/acid2-expected.txt:
  • platform/gtk/http/tests/misc/acid2-pixel-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-styling-strict-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/track/track-cue-rendering-horizontal-expected.txt:
  • platform/gtk/media/track/track-cue-rendering-vertical-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-volume-slider-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
  • platform/gtk/tables/mozilla/core/table_rules-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/gtk/transforms/2d/transform-borderbox-expected.txt:
  • platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/gtk/transitions/cross-fade-border-image-expected.txt:
11:42 AM Changeset in webkit [126685] by Dave Barton
  • 1 edit
    10 deletes in trunk/LayoutTests

Remove custom mac-snowleopard mathml test baselines
https://bugs.webkit.org/show_bug.cgi?id=95004

Reviewed by Eric Seidel.

These custom baselines are no longer needed, since the mac lion bots were upgraded to
OS X 10.7.4 in the fix for https://bugs.webkit.org/show_bug.cgi?id=94393.

  • platform/mac-snowleopard/mathml: Removed.
  • platform/mac-snowleopard/mathml/presentation: Removed.
  • platform/mac-snowleopard/mathml/presentation/attributes-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/fenced-mi-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/fractions-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/mo-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/over-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/roots-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/row-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/sub-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/tokenElements-expected.txt: Removed.
  • platform/mac-snowleopard/mathml/presentation/underover-expected.txt: Removed.
10:25 AM Changeset in webkit [126684] by robert@webkit.org
  • 6 edits in trunk/LayoutTests

Update TestExpectations for Qt, EFL, GTK, Apple Win and Chromium after r126683.

Unreviewed, gardening.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
9:20 AM Changeset in webkit [126683] by robert@webkit.org
  • 10 edits
    2 adds in trunk

Tables with just border-style set on the cells do not get a grid
https://bugs.webkit.org/show_bug.cgi?id=84286

Reviewed by Julien Chaffraix.

Source/WebCore:

This is happening because every cell gets a zero-width border in createSharedCellStyle() if the table border is not explictly set.
FF and Opera don't do this, so leave the cell's border alone if there is no table border explicitly set.

Test: fast/css/table-rules-attribute-none-with-cell-borders.html

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::createSharedCellStyle):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject): Without this we would end up rebaselining a bunch of tests to report 'border: []'

rather than 'border: [none]'. The problem here was that writeRenderObject would only report the first border if it differed from
BorderValue(). What we want is for it to report the first border always and then any borders after that if they differ.

LayoutTests:

With the exception of the new test table-rules-attribute-none-with-cell-borders.html all
of these are rebaselines due to RenderTreeAsText now reporting the first border, even if it
is a default border.

  • fast/block/float/avoidance-rtl-expected.txt:
  • fast/borders/border-radius-wide-border-01-expected.txt:
  • fast/borders/only-one-border-with-width-expected.txt:
  • fast/css/table-rules-attribute-none-with-cell-borders-expected.html: Added.
  • fast/css/table-rules-attribute-none-with-cell-borders.html: Added.
  • fast/multicol/progression-reverse-expected.txt:
  • fast/multicol/vertical-lr/rules-with-border-before-expected.txt:
  • fast/multicol/vertical-rl/rules-with-border-before-expected.txt:
  • platform/chromium-linux/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/chromium-linux/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/chromium-win/animations/cross-fade-border-image-source-expected.txt:
  • platform/chromium-win/css1/box_properties/border_bottom-expected.txt:
  • platform/chromium-win/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/chromium-win/css1/box_properties/border_left-expected.txt:
  • platform/chromium-win/css1/box_properties/border_left_inline-expected.txt:
  • platform/chromium-win/css1/box_properties/border_right-expected.txt:
  • platform/chromium-win/css1/box_properties/border_right_inline-expected.txt:
  • platform/chromium-win/css1/units/length_units-expected.txt:
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-036-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-007-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-008-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-009-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-010-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-001-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-002-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-003-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-004-expected.txt:
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt:
  • platform/chromium-win/css2.1/20110323/margin-applies-to-008-expected.txt:
  • platform/chromium-win/css2.1/20110323/width-non-replaced-inline-001-expected.txt:
  • platform/chromium-win/css2.1/t040302-c61-phys-len-00-b-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/chromium-win/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/chromium-win/editing/execCommand/4580583-1-expected.txt:
  • platform/chromium-win/editing/execCommand/4580583-2-expected.txt:
  • platform/chromium-win/editing/inserting/5418891-expected.txt:
  • platform/chromium-win/editing/inserting/5510537-expected.txt:
  • platform/chromium-win/editing/inserting/6703873-expected.txt:
  • platform/chromium-win/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/chromium-win/editing/pasteboard/5006779-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/chromium-win/fast/block/float/012-expected.txt:
  • platform/chromium-win/fast/block/float/013-expected.txt:
  • platform/chromium-win/fast/block/float/016-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/041-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/043-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/057-expected.txt:
  • platform/chromium-win/fast/css/acid2-expected.txt:
  • platform/chromium-win/fast/css/acid2-pixel-expected.txt:
  • platform/chromium-win/fast/css/border-height-expected.txt:
  • platform/chromium-win/fast/frames/viewsource-attribute-expected.txt:
  • platform/chromium-win/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/chromium-win/fast/inline/inline-padding-disables-text-quirk-expected.txt:
  • platform/chromium-win/fast/inline/inline-text-quirk-bpm-expected.txt:
  • platform/chromium-win/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/chromium-win/fast/lists/007-expected.txt:
  • platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.txt:
  • platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.txt:
  • platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-rtl-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/003-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/chromium-win/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/chromium-win/fast/text/basic/015-expected.txt:
  • platform/chromium-win/fast/text/monospace-width-cache-expected.txt:
  • platform/chromium-win/http/tests/misc/acid2-expected.txt:
  • platform/chromium-win/http/tests/misc/acid2-pixel-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
  • platform/chromium-win/tables/mozilla/core/table_rules-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/chromium-win/transforms/2d/transform-borderbox-expected.txt:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/chromium-win/transitions/cross-fade-border-image-expected.txt:
  • platform/chromium/fast/css/pseudo-first-line-border-width-expected.txt:
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
  • platform/mac/fast/css/caption-width-absolute-position-expected.txt:
  • platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt:
  • platform/mac/fast/css/caption-width-fixed-position-expected.txt:
  • platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt:
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt:
6:33 AM Changeset in webkit [126682] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: missing time ruler in Timeline and Network panels
https://bugs.webkit.org/show_bug.cgi?id=95001

Reviewed by Pavel Feldman.

Fixed a call site for Calculator.boundarySpan(), which is now a function rather than a property.

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

2:23 AM Changeset in webkit [126681] by Michelangelo De Simone
  • 5 edits in trunk

[Crash] Null pointer in CSSParser::parseMixFunction()
https://bugs.webkit.org/show_bug.cgi?id=94998

Reviewed by Benjamin Poulain.

Source/WebCore:

parseMixFunction() may try to access invalid memory when the arguments of the
mix() function are comma-terminated.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseMixFunction):

LayoutTests:

New test cases added to check invalid comma-terminated values within mix().

  • css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:

Aug 24, 2012:

11:25 PM EfficientStrings edited by benjamin@webkit.org
Use appendLiteral instead of append with StringBuilder (diff)
10:33 PM Changeset in webkit [126680] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Skipping a test added in r126611 that requires CSS image-set support.
That feature is not currently enabled on the GTK port.

  • platform/gtk/TestExpectations:
10:13 PM EfficientStrings edited by dbates@webkit.org
Remove extraneous semicolon. (diff)
10:10 PM EfficientStrings edited by dbates@webkit.org
Remove extraneous parenthesis (diff)
9:55 PM Changeset in webkit [126679] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/12157689> REGRESSION: WebProcessProxy destructor is sometimes called recursively
https://bugs.webkit.org/show_bug.cgi?id=94997

Reviewed by Dan Bernstein.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::disconnectProcess): Make sure that

we don't try to delete WebProcessProxy while the vector still contains it. Previously,
we used RefPtr::clear, which zeroes out the value before destructing, but doing that
in every RefPtr destructor would be bad for performance.

8:42 PM Changeset in webkit [126678] by psolanki@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Don't create a new ResourceRequest if delegate returns the same NSURLRequest we passed it
https://bugs.webkit.org/show_bug.cgi?id=94962

Reviewed by Geoffrey Garen.

If the NSURLRequest returned from the delegate callback is the same as the one we passed to
it, then avoid creating a new ResourceRequest object. This reduces the number of calls to
ResourceRequest::doUpdateResourceRequest().

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchWillSendRequest):

7:59 PM WikiStart edited by benjamin@webkit.org
(diff)
7:35 PM Changeset in webkit [126677] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/1229

Merge 126131
BUG=143551
Review URL: https://chromiumcodereview.appspot.com/10875067

7:27 PM Changeset in webkit [126676] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1229

Merge 125988
BUG=141564
Review URL: https://chromiumcodereview.appspot.com/10874075

7:26 PM Changeset in webkit [126675] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Texmap] Move TextureMapperGL to use GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=78672

Patch by Helder Correia <Helder Correia> on 2012-08-24
Reviewed by Noam Rosenthal.

Introducing a new GraphicsContext3D::texImage2DDirect() to allow
initialization of textures without allocation. The existing
textImage2D() refuses a null pixel buffer, and
texImage2DResourceSafe() allows it but performs memory
allocation and zeroes the bits. This was not fast enough for
BitmapTextureGL frequent setting up.

No new tests, refactoring.

  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::texImage2D):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::texImage2DDirect):
(WebCore):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::texImage2D):

7:07 PM Changeset in webkit [126674] by cevans@google.com
  • 1 edit in branches/chromium/1229/Source/WebCore/rendering/RenderBlock.cpp

Merge 125315
BUG=137409
Review URL: https://chromiumcodereview.appspot.com/10867075

6:57 PM Changeset in webkit [126673] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 125234
BUG=137147
Review URL: https://chromiumcodereview.appspot.com/10875066

6:41 PM Changeset in webkit [126672] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1229

Merge 126205
BUG=143656
Review URL: https://chromiumcodereview.appspot.com/10868094

6:29 PM Changeset in webkit [126671] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 125472
BUG=142395
Review URL: https://chromiumcodereview.appspot.com/10883044

6:25 PM Changeset in webkit [126670] by cevans@google.com
  • 1 edit in branches/chromium/1229/Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp

Merge 125292
BUG=140656
Review URL: https://chromiumcodereview.appspot.com/10868093

6:16 PM Changeset in webkit [126669] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 124843
BUG=139690
Review URL: https://chromiumcodereview.appspot.com/10867074

6:04 PM Changeset in webkit [126668] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 125237
BUG=139168
Review URL: https://chromiumcodereview.appspot.com/10868092

6:02 PM WebKit Team edited by kpiascik@rim.com
Added myself to the committers list (diff)
5:58 PM Changeset in webkit [126667] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 124914
BUG=138915
Review URL: https://chromiumcodereview.appspot.com/10878069

5:50 PM Changeset in webkit [126666] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

-webkit-font-smoothing: antialiased should use CG font rendering code path, not GDI
https://bugs.webkit.org/show_bug.cgi?id=54004
<rdar://problem/8971429>

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-24
Reviewed by Dan Bernstein.

When specifying -webkit-font-smoothing: antialised; the code path ends up using GDI to draw the text.
GDI ends up drawing subpixel antialiased text, not aliased text anyways.
The CG code path also has the capability of drawing antialiased text. The reason that the GDI path was
used in the first place is no longer a concern here so we can stop using the GDI code path.

  • platform/graphics/win/FontCGWin.cpp: Removing GDI font drawing code path.

(WebCore):
(WebCore::Font::drawGlyphs):

5:40 PM Changeset in webkit [126665] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1229

Merge 125052
BUG=136182
Review URL: https://chromiumcodereview.appspot.com/10870090

5:40 PM Changeset in webkit [126664] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Touch Platform.h to solve a build dependency issue

Unreviewed.

  • wtf/Platform.h:
5:35 PM Changeset in webkit [126663] by commit-queue@webkit.org
  • 10 edits
    34 adds in trunk

Add support for compositing the contents of overflow:scroll areas
https://bugs.webkit.org/show_bug.cgi?id=91117

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-08-24
Reviewed by Simon Fraser.

Patch by Simon Fraser with modifications by Sami Kyostila and Ian Vollick.

Allow a RenderLayer which exists for overflow scrolling
to use a composited layer for the scrolled contents, which
allows for compositing-accelerated overflow scrolling.

Tests:

compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html
compositing/overflow/iframe-inside-overflow-clipping.html
compositing/overflow/nested-scrolling.html
compositing/overflow/overflow-auto-with-touch-no-overflow.html
compositing/overflow/overflow-auto-with-touch.html
compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html
compositing/overflow/overflow-hidden-with-touch.html
compositing/overflow/overflow-overlay-with-touch-no-overflow.html
compositing/overflow/overflow-overlay-with-touch.html
compositing/overflow/overflow-scroll-with-touch-no-overflow.html
compositing/overflow/overflow-visible-with-touch.html
compositing/overflow/remove-overflow-crash.html
compositing/overflow/remove-overflow-crash2.html
compositing/overflow/scrolling-content-clip-to-viewport.html
compositing/overflow/textarea-scroll-touch.html

  • platform/graphics/GraphicsLayerClient.h: New paint phase flag

used for scrolled contents. Provide a typedef for the flags
so that they can be ORed together.

  • rendering/RenderLayer.h:

(WebCore::ClipRectsCache::ClipRectsCache):
(ClipRectsCache): In debug builds, store a m_respectingOverflowClip
flag so we can ASSERT later that we're fetching clip rects with the
same setting the rects were generated with.
Add new PaintLayerPaintingOverflowContents painting flag.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::usesCompositedScrolling): New method returns
true if this layer is using composited overflow scrolling.
(WebCore::RenderLayer::scrollTo): Don't repaint if we're doing
a composited scroll.
(WebCore::RenderLayer::paintLayer): Pass the right flags to backgroundClipRect();
if we're painting scrolled contents, we don't want to take the overflow clip rect
into account.
(WebCore::RenderLayer::paintLayerContents): Ditto. Also don't do the intersectsDamageRect()
check if we're painting scrolled contents.
(WebCore::RenderLayer::updateClipRects): New parameter to tell whether to respect overflow clipping.
Assert if we're fetching cached rects with a different 'respect clip' flag to the one they were generated
with.
(WebCore::RenderLayer::calculateClipRects): Take the 'respectOverflowClip' flag into account
when computing clip rects.
(WebCore::RenderLayer::parentClipRects): Ditto
(WebCore::RenderLayer::backgroundClipRect): Ditto
(WebCore::RenderLayer::calculateRects): Ditto
(WebCore::RenderLayer::childrenClipRect): This function is called from widget code, so may use a different
'respect clip rects' setting than that used for painting, so it has to compute clip rects on the fly.
(WebCore::RenderLayer::shouldBeNormalFlowOnly): Composited scrolling makes a layer not normal-flow only.

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking): New member variables for the layers for scrolled contents, and the scrolling
layer which handles the scroll offset.
(WebCore::RenderLayerBacking::hasScrollingLayer):
(WebCore::RenderLayerBacking::scrollingLayer):
(WebCore::RenderLayerBacking::scrollingContentsLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::destroyGraphicsLayers): Tear down the scrolling layers, if any.
(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling): Renamed from layerOrAncestorIsTransformed,
since it has to look for composited scrolling layers too.
(WebCore::RenderLayerBacking::shouldClipCompositedBounds): We don't want the contents of scrolling layers
to get clipped to the viewport.
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Create scrolling layers if necessary.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Set scrolling layer geometry.
(WebCore::RenderLayerBacking::updateInternalHierarchy): Hook up scrolling layers.
(WebCore::RenderLayerBacking::updateDrawsContent): Scrolling layers affect whether the main graphics layer
needs to draw content.
(WebCore::RenderLayerBacking::updateScrollingLayers): Create or destroy scrolling layers.
(WebCore::RenderLayerBacking::paintingPhaseForPrimaryLayer): If we have a scrolled contents layer,
the main layer should not paint the foreground.
(WebCore::RenderLayerBacking::parentForSublayers): Sublayers are parented in the scrolling contents
layer if one exists.
(WebCore::RenderLayerBacking::setContentsNeedDisplay): Need to dirty the scrolling contents layer.
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Ditto.
(WebCore::RenderLayerBacking::paintIntoLayer): Set the right painting flags.
(WebCore::RenderLayerBacking::paintContents): Only clip to the bounds if we're not painting overflow contents.

5:34 PM Changeset in webkit [126662] by dmazzoni@google.com
  • 3 edits in trunk/Source/WebKit/chromium

Chromium: WebAccessibilityObject should expose updateBackingStore
https://bugs.webkit.org/show_bug.cgi?id=94611

Reviewed by Chris Fleizach.

This change just exposes a method, with no new tests. Next, Chromium
will be modified to call this new method, and this will be followed
by a change that gets rid of calls to updateBackingStore under the
hood. That last change may add a test or update an existing test.

  • public/WebAccessibilityObject.h:

(WebAccessibilityObject):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::updateBackingStoreAndCheckValidity):
(WebKit):

5:32 PM Changeset in webkit [126661] by cevans@google.com
  • 1 edit in branches/chromium/1229/Source/WebCore/rendering/RenderBlock.cpp

Merge 125353
BUG=134324
Review URL: https://chromiumcodereview.appspot.com/10868091

5:31 PM Changeset in webkit [126660] by cevans@google.com
  • 6 edits
    2 copies in branches/chromium/1229

Merge 125351
BUG=134324
Review URL: https://chromiumcodereview.appspot.com/10882045

5:15 PM Changeset in webkit [126659] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 124888
BUG=132019
Review URL: https://chromiumcodereview.appspot.com/10879084

5:13 PM Changeset in webkit [126658] by benjamin@webkit.org
  • 19 edits
    3 adds in trunk

Unify Number to StringImpl conversion
https://bugs.webkit.org/show_bug.cgi?id=94879

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-24
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/UString.cpp:
  • runtime/UString.h:

(JSC::UString::number):
Update UString to directly use the common NumberToString implementation.

Source/WebKit2:

  • win/WebKit2.def: Update the exported symbols.

Source/WTF:

Previously, UString::number() and String::number() used different implementations.

WTF::String::number() was simply forwarding to String::format().
UString::number() had an optimized version of the conversion.

This patch replace both implementation by a new version, faster than the two previous versions.

The new functions numberToStringImpl improvements are:
-about 3 times faster than String::number().
-14% faster than UString::number() on signed numbers.
-9% faster than UString::number() on unsigned numbers.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/text/IntegerToStringConversion.cpp: Added.

(WTF::numberToStringImplSigned):
(WTF::numberToStringImpl):
(WTF::numberToStringImplUnsigned):

  • wtf/text/IntegerToStringConversion.h: Added.
  • wtf/text/WTFString.cpp:

(WTF::String::format):

  • wtf/text/WTFString.h:

(WTF::String::number):

Tools:

Add testing for the new IntegerToStringConversion.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp: Added.
5:06 PM Changeset in webkit [126657] by fmalita@chromium.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: !attached() in WebCore::Node::attach()
https://bugs.webkit.org/show_bug.cgi?id=94650

Reviewed by Abhishek Arya.

Source/WebCore:

Prevent SVGTests::handleAttributeChange() from attaching elements with detached parents.

Test: svg/custom/system-language-crash.html

  • svg/SVGTests.cpp:

(WebCore::SVGTests::handleAttributeChange):

LayoutTests:

  • svg/custom/system-language-crash-expected.txt: Added.
  • svg/custom/system-language-crash.html: Added.
4:58 PM Changeset in webkit [126656] by commit-queue@webkit.org
  • 86 edits
    4 adds in trunk

CSSStyleDeclaration.cssText should not contain extraneous whitespace in final delimiter
https://bugs.webkit.org/show_bug.cgi?id=94633

Patch by Glenn Adams <glenn@skynav.com> on 2012-08-24
Reviewed by Benjamin Poulain.

Ensure cssText final delimiter does not contain extraneous space character after semicolon.

Source/WebCore:

Test: cssom/cssstyledeclaration-csstext-final-delimiter.html

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::cssText):
Conditionally add SPACE in serialized rule since asText() no longer
contains extra space.
Construct result using StringBuilder.

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::cssText):
Conditionally add SPACE in serialized rule since asText() no longer
contains extra space.
Construct result using StringBuilder.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::cssText):
Ensure serialized property does longer contains extra space in cssText.
Construct result using StringBuilder.

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::cssText):
Conditionally add SPACE in serialized rule since asText() no longer
contains extra space.
Construct result using StringBuilder.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::addRule):
Conditionally add SPACE in reserialized rule in case passed style no
longer contains extra space. Note that if it does already contain an
extra space that inserting an extra space here is harmless (i.e., is
effectively normalized during parse).
Construct result using StringBuilder.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::asText):
Ensure serialized property set does longer contains extra space in final
delimiter.
Construct result using StringBuilder.

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::cssText):
Conditionally add SPACE in serialized rule since asText() no longer
contains extra space.
Construct result using StringBuilder.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::addBlockStyle):
Conditionally add SPACE in block style since cssText no longer contains
extra space.
Construct result using StringBuilder.
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
Conditionally add SPACE in pre-existing inline style since cssText no
longer contains extra space.
Construct result using StringBuilder.

LayoutTests:

  • cssom/README.txt: Added.
  • cssom/cssstyledeclaration-csstext-final-delimiter-expected.txt: Added.
  • cssom/cssstyledeclaration-csstext-final-delimiter.html: Added.
  • editing/deleting/delete-line-break-before-underlined-content-expected.txt: Remove extraneous space.
  • editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt: ditto
  • editing/deleting/deleting-line-break-preserves-underline-color-expected.txt: ditto
  • editing/deleting/merge-paragraph-from-h6-with-style-2-expected.txt: ditto
  • editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: ditto
  • editing/deleting/merge-paragraph-from-p-with-style-3-expected.txt: ditto
  • editing/deleting/merge-paragraph-from-p-with-style-expected.txt: ditto
  • editing/deleting/paste-with-transparent-background-color-expected.txt: ditto
  • editing/execCommand/insert-list-with-noneditable-content-expected.txt: ditto
  • editing/execCommand/script-tests/toggle-link.js: ditto
  • editing/execCommand/script-tests/toggle-unlink.js: ditto
  • editing/execCommand/toggle-link-expected.txt: ditto
  • editing/execCommand/toggle-unlink-expected.txt: ditto
  • editing/inserting/page-zoom-font-size-expected.txt: ditto
  • editing/pasteboard/19644-2-expected.txt: ditto
  • editing/pasteboard/5761530-1-expected.txt: ditto
  • editing/pasteboard/5780697-2-expected.txt: ditto
  • editing/pasteboard/copy-null-characters-expected.txt: ditto
  • editing/pasteboard/copy-paste-bidi-expected.txt: ditto
  • editing/pasteboard/copy-text-with-backgroundcolor-expected.txt: ditto
  • editing/pasteboard/data-transfer-items-expected.txt: ditto
  • editing/pasteboard/display-block-on-spans-expected.txt: ditto
  • editing/pasteboard/do-not-copy-unnecessary-styles-2-expected.txt: ditto
  • editing/pasteboard/do-not-copy-unnecessary-styles-expected.txt: ditto
  • editing/pasteboard/drag-drop-url-with-style-expected.txt: ditto
  • editing/pasteboard/onpaste-text-html-expected.txt: ditto
  • editing/pasteboard/paste-4039777-fix-expected.txt: ditto
  • editing/pasteboard/paste-and-sanitize-expected.txt: ditto
  • editing/pasteboard/paste-and-sanitize.html: ditto
  • editing/pasteboard/paste-list-003-expected.txt: ditto
  • editing/pasteboard/paste-noscript-expected.txt: ditto
  • editing/pasteboard/paste-noscript-xhtml-expected.txt: ditto
  • editing/pasteboard/paste-table-002-expected.txt: ditto
  • editing/pasteboard/paste-text-with-style-4-expected.txt: ditto
  • editing/pasteboard/paste-text-with-style-5-expected.txt: ditto
  • editing/pasteboard/paste-with-redundant-style-expected.txt: ditto
  • editing/pasteboard/preserve-underline-color-expected.txt: ditto
  • editing/pasteboard/style-from-rules-expected.txt: ditto
  • editing/pasteboard/testcase-9507-expected.txt: ditto
  • editing/style/non-inheritable-styles-expected.txt: ditto
  • editing/style/push-down-font-styles-expected.txt: ditto
  • editing/style/push-down-implicit-styles-around-list-expected.txt: ditto
  • editing/style/push-down-implicit-styles-expected.txt: ditto
  • editing/style/push-down-inline-styles-expected.txt: ditto
  • editing/style/script-tests/push-down-font-styles.js: ditto
  • editing/style/script-tests/push-down-implicit-styles-around-list.js: ditto
  • editing/style/script-tests/push-down-implicit-styles.js: ditto
  • editing/style/script-tests/push-down-inline-styles.js: ditto
  • editing/undo/remove-css-property-and-remove-style-expected.txt: ditto
  • editing/undo/replace-by-span-then-remove-expected.txt: ditto
  • editing/undo/replace-by-span-then-remove.html: ditto
  • fast/css/background-position-serialize.html: ditto
  • fast/css/counters/counter-cssText-expected.txt: ditto
  • fast/css/counters/counter-cssText.html: ditto
  • fast/css/parse-border-image-repeat-null-crash-expected.txt: ditto
  • fast/css/remove-shorthand.html: ditto
  • fast/dom/Element/scrollWidth.html: ditto
  • fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: ditto
  • fast/dom/HTMLProgressElement/progress-element-markup-expected.txt: ditto
  • fast/dom/attr-style-too-lazy-expected.txt: ditto
  • fast/dom/attr-style-too-lazy.html: ditto
  • fast/dom/css-set-property-exception-expected.txt: ditto
  • fast/fast/events/ondrop-text-html-expected.txt: ditto
  • fast/mutation/observe-attributes-expected.txt: ditto
  • fast/mutation/observe-attributes.html: ditto
  • inspector/elements/insert-node-expected.txt: ditto
  • inspector/styles/styles-update-from-js-expected.txt: ditto
  • platform/chromium-win/editing/pasteboard/5780697-2-expected.txt: ditto
  • platform/efl/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: ditto
  • platform/mac/editing/pasteboard/5761530-1-expected.txt: ditto
  • platform/qt/editing/pasteboard/5761530-1-expected.txt: ditto
  • platform/qt/editing/pasteboard/5780697-2-expected.txt: ditto
  • svg/webarchive/svg-script-subresouces-expected.webarchive: ditto
  • webarchive/test-link-rel-icon-beforeload-expected.webarchive: ditto
4:56 PM Changeset in webkit [126655] by jchaffraix@webkit.org
  • 2 edits
    6 adds
    2 deletes in trunk/LayoutTests

More unreviewed Chromium rebaselining.

  • fast/repaint/bugzilla-6473-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/bugzilla-6473-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/bugzilla-6473-expected.png: Added.
  • platform/chromium-mac/fast/repaint/bugzilla-6473-expected.png: Added.
  • platform/chromium-win/fast/repaint/bugzilla-6473-expected.png: Added.
  • platform/chromium-win/fast/repaint/bugzilla-6473-expected.txt: Added.
  • platform/efl/fast/repaint/bugzilla-6473-expected.txt: Removed.
  • platform/gtk/fast/repaint/bugzilla-6473-expected.txt: Removed.

Rebaseline this test as it was deflaked by Simon in r79661. The new baseline
matches Mac and Mitz's expectations (see bug 21536).

  • platform/chromium/TestExpectations:

Removed fast/repaint/bugzilla-6473.html now that it's rebaselined.
Removed fast/table/frame-and-rules.html as it hasn't been failing for a week.

4:50 PM Changeset in webkit [126654] by wjmaclean@chromium.org
  • 3 edits
    3 adds in trunk

[chromium] WebViewImpl::enableTouchHighlight() should always clear any existing highlight when invoked.
https://bugs.webkit.org/show_bug.cgi?id=94978

Reviewed by James Robinson.

Modified WebViewImpl::enableTouchHighlight() so it always clears any existing highlight, even if no new
highlight target is found.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::enableTouchHighlight):

LayoutTests:

  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel.html: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel-expected.txt: Added.
4:50 PM Changeset in webkit [126653] by piman@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp

Reverting change in test file that broke the build

4:47 PM Changeset in webkit [126652] by jamesr@google.com
  • 23 edits
    2 copies
    1 delete in trunk

[chromium] Convert WebLayerTreeView interface into pure virtual
https://bugs.webkit.org/show_bug.cgi?id=94866

Reviewed by Adrienne Walker.

Source/Platform:

This makes the WebLayerTreeView interface pure virtual to provide better insulation from the implementation.

  • chromium/public/WebLayerTreeView.h:

(WebKit):
(Settings):
(WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):

Source/WebCore:

Renames CCLayerTreeHostClient::updateAnimations -> CCLayerTreeHostClient::animate to avoid a naming collision
and to better match the other imperative-sounding calls (like layout).

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateAnimations):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHostClient):

Source/WebKit/chromium:

Updates WebLayerTreeView implementation and callers to new interface. The createGraphicsContext3D() wrapper
stuff can just go away now since downstream has updated to createOutputSurface().

  • WebKit.gypi:
  • src/WebLayerTreeView.cpp: Removed.
  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeView::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::initialize):
(WebKit):
(WebKit::WebLayerTreeViewImpl::setSurfaceReady):
(WebKit::WebLayerTreeViewImpl::setRootLayer):
(WebKit::WebLayerTreeViewImpl::clearRootLayer):
(WebKit::WebLayerTreeViewImpl::compositorIdentifier):
(WebKit::WebLayerTreeViewImpl::setViewportSize):
(WebKit::WebLayerTreeViewImpl::layoutViewportSize):
(WebKit::WebLayerTreeViewImpl::deviceViewportSize):
(WebKit::WebLayerTreeViewImpl::setDeviceScaleFactor):
(WebKit::WebLayerTreeViewImpl::deviceScaleFactor):
(WebKit::WebLayerTreeViewImpl::setBackgroundColor):
(WebKit::WebLayerTreeViewImpl::setHasTransparentBackground):
(WebKit::WebLayerTreeViewImpl::setVisible):
(WebKit::WebLayerTreeViewImpl::setPageScaleFactorAndLimits):
(WebKit::WebLayerTreeViewImpl::startPageScaleAnimation):
(WebKit::WebLayerTreeViewImpl::setNeedsAnimate):
(WebKit::WebLayerTreeViewImpl::setNeedsRedraw):
(WebKit::WebLayerTreeViewImpl::commitRequested):
(WebKit::WebLayerTreeViewImpl::composite):
(WebKit::WebLayerTreeViewImpl::updateAnimations):
(WebKit::WebLayerTreeViewImpl::compositeAndReadback):
(WebKit::WebLayerTreeViewImpl::finishAllRendering):
(WebKit::WebLayerTreeViewImpl::renderingStats):
(WebKit::WebLayerTreeViewImpl::setFontAtlas):
(WebKit::WebLayerTreeViewImpl::loseCompositorContext):
(WebKit::WebLayerTreeViewImpl::willBeginFrame):
(WebKit::WebLayerTreeViewImpl::didBeginFrame):
(WebKit::WebLayerTreeViewImpl::animate):
(WebKit::WebLayerTreeViewImpl::layout):
(WebKit::WebLayerTreeViewImpl::applyScrollAndScale):
(WebKit::WebLayerTreeViewImpl::createOutputSurface):
(WebKit::WebLayerTreeViewImpl::didRecreateOutputSurface):
(WebKit::WebLayerTreeViewImpl::willCommit):
(WebKit::WebLayerTreeViewImpl::didCommit):
(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):
(WebKit::WebLayerTreeViewImpl::scheduleComposite):

  • src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::renderingStats):
(WebKit::WebViewImpl::startPageScaleAnimation):
(WebKit::WebViewImpl::setCompositorSurfaceReady):
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setNeedsRedraw):
(WebKit::WebViewImpl::isInputThrottled):
(WebKit::WebViewImpl::loseCompositorContext):
(WebKit::WebViewImpl::setDeviceScaleFactor):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::setIsTransparent):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::scheduleCompositingLayerSync):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::WebViewImpl::setBackgroundColor):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
(WebKit::WebViewImpl::updateLayerTreeViewport):
(WebKit::WebViewImpl::setVisibilityState):

  • src/WebViewImpl.h:

(WebKit):

  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCThreadedTest.cpp:
  • tests/CCThreadedTest.h:

(WebKitTests::TestHooks::animate):

  • tests/FakeCCLayerTreeHostClient.h:
  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(GraphicsLayerChromiumTest):

  • tests/WebLayerTest.cpp:
  • tests/WebLayerTreeViewTest.cpp:
  • tests/WebLayerTreeViewTestCommon.h:

(MockWebLayerTreeViewClient):

Tools:

Updates DumpRenderTree's WebViewHost to vend a WebCompositorOutputSurface so DumpRenderTree can run compositing
tests.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

  • DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.

(WebKit):
(WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
(WebKit::WebViewHostOutputSurface::~WebViewHostOutputSurface):
(WebKit::WebViewHostOutputSurface::bindToClient):
(WebKit::WebViewHostOutputSurface::capabilities):
(WebKit::WebViewHostOutputSurface::context3D):
(WebKit::WebViewHostOutputSurface::sendFrameToParentCompositor):

  • DumpRenderTree/chromium/WebViewHostOutputSurface.h: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.

(WebKit):
(WebViewHostOutputSurface):

4:36 PM Changeset in webkit [126651] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-24

  • DEPS:
4:25 PM Changeset in webkit [126650] by jamesr@google.com
  • 13 edits
    2 deletes in trunk/Source

[chromium] Clean up WebAnimation animationId/groupId generation
https://bugs.webkit.org/show_bug.cgi?id=94973

Reviewed by Adrienne Walker.

Source/Platform:

This removes the unused groupId from the public interface and makes the implicit animation id generation a bit
clearer.

  • chromium/public/WebAnimation.h:

(WebAnimation):

Source/WebCore:

This gets rid of AnimationIdVendor and simplifies GraphicsLayerChromium's name<->id mapping. We only have to
track the IDs of animations that we have started and can let WebAnimation generate new IDs if we haven't seen
the name before.

  • WebCore.gypi:
  • platform/graphics/chromium/AnimationIdVendor.cpp: Removed.
  • platform/graphics/chromium/AnimationIdVendor.h: Removed.
  • platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::createWebAnimation):

  • platform/graphics/chromium/AnimationTranslationUtil.h:

(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

Source/WebKit/chromium:

  • src/WebAnimationImpl.cpp:

(WebKit::WebAnimation::create):
(WebKit::WebAnimationImpl::WebAnimationImpl):
(WebKit::WebAnimationImpl::id):
(WebKit):

  • src/WebAnimationImpl.h:

(WebAnimationImpl):

  • tests/AnimationTranslationUtilTest.cpp:

(WebKit::animationCanBeTranslated):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F):

4:23 PM Changeset in webkit [126649] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 125631
BUG=124924
Review URL: https://chromiumcodereview.appspot.com/10869059

4:18 PM Changeset in webkit [126648] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Populate DatabaseTracker's origins lazily on demand
https://bugs.webkit.org/show_bug.cgi?id=94649

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-24
Reviewed by Brady Eidson.

Previously, we would populate m_quotaMap on startup when initialializing DatabaseTracker.
This takes a significant amount of time and memory and it is not needed in many cases.

This patch change DatabaseTracker to invoke populateOrigins() only when needed.
This saves:
-7-15ms on startup.
-96Kbytes of SQLite page cache
-the size of m_quotaMap on that particular system.

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::hasEntryForOriginNoLock):
(WebCore::DatabaseTracker::populateOriginsIfNeeded):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::quotaForOriginNoLock):
(WebCore::DatabaseTracker::addDatabase):
(WebCore::DatabaseTracker::deleteOrigin):

  • Modules/webdatabase/DatabaseTracker.h:

(DatabaseTracker):

4:08 PM Changeset in webkit [126647] by pilgrim@chromium.org
  • 5 edits in trunk/Source

[Chromium] Remove visitedLinkHash from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=94965

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/LinkHashChromium.cpp:

(WebCore):
(WebCore::visitedLinkHash):

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

4:07 PM Changeset in webkit [126646] by cevans@google.com
  • 2 edits in branches/chromium/1180/Source/WebCore/platform/network/chromium

Merge 124682
BUG=136881
Review URL: https://chromiumcodereview.appspot.com/10868088

4:06 PM Changeset in webkit [126645] by scheib@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebCore/rendering/RenderWidget.cpp

Merge 126042 - [chromium] pepper plugins sometimes are shifted by 1 pixel
https://bugs.webkit.org/show_bug.cgi?id=94257

Patch by Yuzhu Shen <yzshen@chromium.com> on 2012-08-20
Reviewed by Levi Weintraub.

Change RenderWidget::updateWidgetGeometry() to use LayoutRect instead of IntRect to avoid unwanted truncation
(when converting from FloatRect to IntRect).

This makes sure that the optimized rendering code path of Pepper plugin
(PluginInstance::GetBitmapForOptimizedPluginPaint) has consistent coordinates with the normal WebKit rendering
code path.

No new tests because we don't have Pepper plugin tests in WebKit.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetGeometry):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10867067

4:06 PM Changeset in webkit [126644] by jchaffraix@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed rebaseline after r126622.

  • platform/chromium-mac-snowleopard/fast/repaint/delete-into-nested-block-expected.png: Added.
4:04 PM WebKit Team edited by victor@rosedu.org
Added myself to the committers list (diff)
4:02 PM Changeset in webkit [126643] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Reduce padding on popup menu entries when used on a touch screen.
https://bugs.webkit.org/show_bug.cgi?id=94953

Patch by Kevin Ellis <kevers@chromium.org> on 2012-08-24
Reviewed by Adam Barth.

Prior to the patch, the height of entries in a popup menu was 44px,
which is excessive. Reduced the padding to make the menu entries
30px tall to match the wrench menu.

No new tests required.

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore):

4:02 PM Changeset in webkit [126642] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1180

Merge 124645
BUG=139240

3:57 PM Changeset in webkit [126641] by cevans@google.com
  • 1 edit in branches/chromium/1180/Source/WebCore/rendering/RenderBlock.cpp

Merge 124580
BUG=136116
Review URL: https://chromiumcodereview.appspot.com/10867066

3:54 PM Changeset in webkit [126640] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1180

Merge 124564
BUG=136116
Review URL: https://chromiumcodereview.appspot.com/10880056

3:53 PM Changeset in webkit [126639] by timothy@apple.com
  • 1 delete in tags/Safari-536.26.10

Removing bad tag.

3:49 PM Changeset in webkit [126638] by timothy@apple.com
  • 1 copy in tags/Safari-536.26.10

New tag.

3:38 PM Changeset in webkit [126637] by fpizlo@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

We should have tests for the DFG CFA's handling of structure clobbering and basic blocks
https://bugs.webkit.org/show_bug.cgi?id=94977

Reviewed by Mark Hahnenberg.

  • fast/js/dfg-multi-basic-block-structure-clobber-expected.txt: Added.
  • fast/js/dfg-multi-basic-block-structure-clobber.html: Added.
  • fast/js/script-tests/dfg-multi-basic-block-structure-clobber.js: Added.

(bar):
(foo):

  • fast/js/jsc-test-list:
3:37 PM Changeset in webkit [126636] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Web pages are zoomed out to much on initial load
https://bugs.webkit.org/show_bug.cgi?id=94830

The previous patch caused a slight regression to the calculation we do
for the default splitting factor in the render queue. The default value
we use to represent the max area should be the tile size. This was true
with the old calculation of default max layout width since it was the
screen size. The fix is to be explicit and use the tile size directly.

Patch by Adam Treat <atreat@rim.com> on 2012-08-24
Reviewed by George Staikos.

  • WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::splittingFactor):

3:30 PM Changeset in webkit [126635] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

[Texmap] Move TextureMapperGL to use GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=78672

Patch by Helder Correia <Helder Correia>, Roland Takacs <rtakacs@inf.u-szeged.hu> on 2012-08-24
Reviewed by Noam Rosenthal.

This is part of a several patch-refactoring.

Introduce additional logic in GraphicsContext3DQt to support a
new RenderToCurrentGLContext RenderStyle. This is necessary to
use GC3D for other things than WebGL, like TextureMapper.

The GC3D constructor now accepts a RenderStyle instead of the
boolean renderDirectlyToHostWindow and thus mimics create()'s
signature. This has been changed for all ports in this patch.

A new GC3D::createForCurrentGLContext() builder was
introduced to better abstract the goal of using GC3D with the
current context.

The patch was originally developed by Helder Correia and finished
by Roland Takacs.

No new tests, refactoring.

3:24 PM Changeset in webkit [126634] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 125503
BUG=121347
Review URL: https://chromiumcodereview.appspot.com/10869057

3:22 PM Changeset in webkit [126633] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1180

Merge 125503
BUG=121347
Review URL: https://chromiumcodereview.appspot.com/10883035

3:16 PM Changeset in webkit [126632] by cevans@google.com
  • 15 edits
    4 copies in branches/chromium/1180

Merge 124556
BUG=134897
Review URL: https://chromiumcodereview.appspot.com/10871074

3:15 PM Changeset in webkit [126631] by commit-queue@webkit.org
  • 6 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r126620.
http://trac.webkit.org/changeset/126620
https://bugs.webkit.org/show_bug.cgi?id=94976

ASSERT((intptr_t)m_bytesAllocated + deltaBytes > 0) is
triggering on the bots (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-24

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::contextAcquired):

  • platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):

  • platform/graphics/chromium/Canvas2DLayerManager.cpp: Removed.
  • platform/graphics/chromium/Canvas2DLayerManager.h: Removed.

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/Canvas2DLayerManagerTest.cpp: Removed.
3:08 PM Changeset in webkit [126630] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 125810
BUG=140495
Review URL: https://chromiumcodereview.appspot.com/10869055

3:07 PM Changeset in webkit [126629] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1180

Merge 125810
BUG=140495
Review URL: https://chromiumcodereview.appspot.com/10871072

3:05 PM Changeset in webkit [126628] by wangxianzhu@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium-Android] Reapply "Upstream layout test expectations (Part 1)"
https://bugs.webkit.org/show_bug.cgi?id=94884

Reviewed by Adam Barth.

This part include:

  • Removed ANDROID tag for passing tests and tests that should be covered by other Android specific rules
  • Added android rules for fast/js and jquery/ tests
  • crbug.com/144536
  • Several other rules with public bugs
  • platform/chromium/TestExpectations:
2:46 PM Changeset in webkit [126627] by rniwa@webkit.org
  • 21 edits
    2 moves
    5 adds in trunk

[CSSRegions]Expose WebKitNamedFlowCollection interface through document.getNamedFlows()
https://bugs.webkit.org/show_bug.cgi?id=93368

Patch by Andrei Onea <onea@adobe.com> on 2012-08-24
Reviewed by Ryosuke Niwa.

Source/WebCore:

The WebKitNamedFlowCollection already implemented was being used by Document to store all
the named flows - regardless of state - so we need to use another class to expose to JS.
WebKitNamedFlowCollection was renamed to NamedFlowCollection since it is used only internally,
and the C++ class used to expose to JS is DOMNamedFlowCollection (with the interface name
WebKitNamedFlowCollection). DOMNamedFlowCollection is exposed via Document::webKitGetFlows(),
and it itself exposes the length property, the indexed getter, and the named getter.
http://dev.w3.org/csswg/css3-regions/#document-getnamedflows

Test: fast/regions/webkit-named-flow-collection.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
We need to use same trick as with HTMLPropertiesCollection, to make NamedGetter generate required code.

  • dom/DOMAllInOne.cpp:
  • dom/DOMNamedFlowCollection.cpp:

(WebCore):
(WebCore::DOMNamedFlowCollection::DOMNamedFlowCollection):
(WebCore::DOMNamedFlowCollection::length):
(WebCore::DOMNamedFlowCollection::item):
(WebCore::DOMNamedFlowCollection::namedItem):
(WebCore::DOMNamedFlowCollection::hasNamedItem):

  • dom/DOMNamedFlowCollection.h:

(WebCore):
(DOMNamedFlowCollection):
(WebCore::DOMNamedFlowCollection::create):

  • dom/DOMNamedFlowCollection.idl:
  • dom/Document.cpp:

(WebCore):
(WebCore::Document::webkitGetNamedFlows):
(WebCore::Document::namedFlows):

  • dom/Document.h:

(WebCore):
(Document):

  • dom/Document.idl:
  • dom/NamedFlowCollection.cpp:

Renamed from Source/WebCore/dom/WebKitNamedFlowCollection.cpp.
(WebCore):
(WebCore::NamedFlowCollection::NamedFlowCollection):
(WebCore::NamedFlowCollection::namedFlows):
(WebCore::NamedFlowCollection::flowByName):
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
(WebCore::NamedFlowCollection::documentDestroyed):
(WebCore::NamedFlowCollection::createCSSOMSnapshot):
Used to create a snapshot of current named flows in CREATED state.

  • dom/NamedFlowCollection.h:

Renamed from Source/WebCore/dom/WebKitNamedFlowCollection.h.
(WebCore):
(NamedFlowCollection):
(WebCore::NamedFlowCollection::create):
(WebCore::NamedFlowCollection::document):
(WebCore::NamedFlowCollection::~NamedFlowCollection):
(WebCore::NamedFlowCollection::NamedFlowHashFunctions::hash):
(WebCore::NamedFlowCollection::NamedFlowHashFunctions::equal):
(NamedFlowCollection::NamedFlowHashFunctions):
(WebCore::NamedFlowCollection::NamedFlowHashTranslator::hash):
(WebCore::NamedFlowCollection::NamedFlowHashTranslator::equal):
Moved NamedFlowHashFunctions and NamedFlowHashTranslator definitions to .h
and made them public, so they can be used in DOMNamedFlow as well.

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::WebKitNamedFlow):
(WebCore::WebKitNamedFlow::create):

  • dom/WebKitNamedFlow.h:

(WebCore):
(WebKitNamedFlow):

  • inspector/InspectorCSSAgent.cpp:
  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):

LayoutTests:

Added test for WebKitNamedFlowCollection interface.

  • fast/regions/webkit-named-flow-collection-expected.txt: Added.
  • fast/regions/webkit-named-flow-collection.html: Added.
2:39 PM Changeset in webkit [126626] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping svg/custom/getBBox-path.svg on platform mac.
https://bugs.webkit.org/show_bug.cgi?id=94971.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-24
Reviewed by Sam Weinig.

  • platform/mac/Skipped:
2:37 PM Changeset in webkit [126625] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty/ANGLE

[CSS Shaders] [ANGLE] RenameFunction::RenameFunction may store references to temporary string
https://bugs.webkit.org/show_bug.cgi?id=94736
http://code.google.com/p/angleproject/issues/detail?id=360

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-08-24
Reviewed by George Staikos.

When RenameFunction::RenameFunction(const TString& oldFunctionName, const TString&
newFunctionName) is called from TCompiler::rewriteCSSShader(TIntermNode*), references to
the temporaries oldFunctionName and newFunctionName are stored as mOldFunctionName and
mNewFunctionName. This results in undefined behaviour in visitAggregate.

This same patch is being applied in upstream ANGLE, and is needed for CSS Shader
sanitization.

  • src/compiler/RenameFunction.h:

(RenameFunction::visitAggregate):
(RenameFunction):

2:23 PM Changeset in webkit [126624] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Always null check cells before marking
https://bugs.webkit.org/show_bug.cgi?id=94968

Reviewed by Geoffrey Garen.

Originally we tried to minimise null checks by only null checking values
that we knew could be null, however given that we can't ever guarantee
when a GC will happen, we're better off just always assuming that a null
check will be necessary. This results in a much less fragile code base
as we can add GC allocations to object initialisers without having to
subsequently worry about whether the object we are initialising will need
to add a bunch of null checks in its visitChildren implementation.

  • heap/MarkStack.cpp:

(JSC::MarkStack::internalAppend):

  • heap/MarkStackInlineMethods.h:

(JSC::MarkStack::append):
(JSC::MarkStack::appendUnbarrieredPointer):

  • runtime/Structure.h:

(JSC::MarkStack::internalAppend):

2:23 PM Changeset in webkit [126623] by piman@chromium.org
  • 3 edits in branches/chromium/1229/Source

Merge 126540 - [chromium] Fix lost context when textures are evicted
https://bugs.webkit.org/show_bug.cgi?id=94892

Reviewed by James Robinson.

After eviction, the CCPrioritizedTextureManager is in a limbo state
where all its resources are invalid. If we try to release them we will
double-destroy them.

New test: CCLayerTreeHostTestLostContextAfterEvictTextures.

Source/WebCore:

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTestLostContextAfterEvictTextures):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::CCLayerTreeHostTestLostContextAfterEvictTextures):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::beginTest):
(EvictTexturesAndLoseContextTask):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::EvictTexturesAndLoseContextTask):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::~EvictTexturesAndLoseContextTask):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::run):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::postEvictTexturesAndLoseContext):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didRecreateOutputSurface):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::afterTest):
(WTF):
(WTF::TEST_F):

TBR=piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10883032

2:05 PM Changeset in webkit [126622] by jchaffraix@webkit.org
  • 3 edits
    48 adds in trunk/LayoutTests

Unreviewed Chromium gardening.

Rebaselined a bunch of repaint tests on Mac. The failures or differences fell in
the following categories:

  • small alpha difference on the repaint tests' background. This issue has been known for

some time now but is not being worked on AFAICT.

  • Chromium unions the invalidation rects when Mac doesn't.
  • font difference.
  • platform/chromium-mac-snowleopard/fast/repaint/box-shadow-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-dynamic-expected.png: Added.

This test was using Mac's expectation which is wrong (they have some beige rectangles that
are not in the page). Those new baselines matches the other ports and the expected result.

  • platform/chromium-mac-snowleopard/fast/repaint/4774354-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/4776765-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/border-fit-lines-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/border-repaint-glitch-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/bugzilla-3509-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/bugzilla-6388-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/bugzilla-7235-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/change-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/containing-block-position-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/dynamic-table-vertical-alignment-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/float-move-during-layout-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/inline-color-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/layout-state-relative-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/outline-shrinking-expected.png: Added.
  • platform/chromium-mac/fast/repaint/4774354-expected.png: Added.
  • platform/chromium-mac/fast/repaint/4776765-expected.png: Added.
  • platform/chromium-mac/fast/repaint/block-selection-gap-in-table-cell-expected.png: Added.
  • platform/chromium-mac/fast/repaint/border-fit-lines-expected.png: Added.
  • platform/chromium-mac/fast/repaint/border-repaint-glitch-expected.png: Added.
  • platform/chromium-mac/fast/repaint/bugzilla-3509-expected.png: Added.
  • platform/chromium-mac/fast/repaint/bugzilla-6388-expected.png: Added.
  • platform/chromium-mac/fast/repaint/bugzilla-7235-expected.png: Added.
  • platform/chromium-mac/fast/repaint/button-spurious-layout-hint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/change-transform-expected.png: Added.
  • platform/chromium-mac/fast/repaint/clip-with-layout-delta-expected.png: Added.
  • platform/chromium-mac/fast/repaint/containing-block-position-change-expected.png: Added.
  • platform/chromium-mac/fast/repaint/delete-into-nested-block-expected.png:
  • platform/chromium-mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.png: Added.
  • platform/chromium-mac/fast/repaint/erase-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
  • platform/chromium-mac/fast/repaint/float-move-during-layout-expected.png: Added.
  • platform/chromium-mac/fast/repaint/inline-block-resize-expected.png: Added.
  • platform/chromium-mac/fast/repaint/inline-color-change-expected.png: Added.
  • platform/chromium-mac/fast/repaint/inline-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layer-full-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layer-hide-when-needs-layout-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layer-visibility-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layout-state-relative-expected.png: Added.
  • platform/chromium-mac/fast/repaint/outline-shrinking-expected.png: Added.
  • platform/chromium/TestExpectations:
1:51 PM Changeset in webkit [126621] by cevans@google.com
  • 5 edits in trunk

Source/WebCore: Update comment regarding root node handling in XPath for detached trees.
https://bugs.webkit.org/show_bug.cgi?id=36427

Reviewed by Alexey Proskuryakov.

  • xml/XPathPath.cpp:

(WebCore::XPath::LocationPath::evaluate): Update XPath root node comment.

LayoutTests: Improve xpath-detached-nodes.html test.
https://bugs.webkit.org/show_bug.cgi?id=36427

Reviewed by Alexey Proskuryakov.

  • fast/xpath/xpath-detached-nodes-expected.txt:
  • fast/xpath/xpath-detached-nodes.html: Increase coverage and improve log messages.
1:47 PM Changeset in webkit [126620] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk/Source

[Chromium] Implementing a global limit on memory consumed by deferred 2D canvases
https://bugs.webkit.org/show_bug.cgi?id=94386

Patch by Justin Novosad <junov@chromium.org> on 2012-08-24
Reviewed by Stephen White.

Source/WebCore:

Before this change, there was no global bound on memory that could be
consumed for the purpose of recording 2d canvas deferred draw commands.
There was only a per canvas limit. It is possible for canvases to get
dereferenced without flushing pending draw commands, which may lock
resources until the canvas element is garbage collected. This makes
it possible to grow memory consumption indefinitely by hitting reload
successively on some canvas-intensive web pages.

The solution implemented in this change consists in maintaining a
global registry of deferred canvas layers and tracking the sum of
memory allocated by all canvases for the purpose of storing deferred
draw commands. When memory consumption reaches the allowed limit,
caches are cleared and draw operations are flushed on one or several
canvases, starting with the least recently used, until memory
consumption is below a target level.

New tests: webkit_unit_tests DeferredLayerManagerTest*

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecordingChanged):
Overloaded from SkDeferredCanvas::NotificationClient. Called when
there is a change in the number of bytes allocated by the deferred
canvas.
(WebCore):
(WebCore::Canvas2DLayerBridge::flushedDrawCommands):
Overloaded from SkDeferredCanvas::NotificationClient. Called when
pending draw commands are flush by the deferred canvas.
(WebCore::Canvas2DLayerBridge::freeMemoryIfPossible):
Called by the Canvas2DLayerManager to request the release of unlocked
memory resources (caches). Request is relayed to SkDeferredCanvas.
returns number of bytes freed.
(WebCore::Canvas2DLayerBridge::flush):
Requests that pending draw commands be flushed immediately from the
deferred canvas queue. Request is relayed to SkDeferredCanvas.
(WebCore::Canvas2DLayerBridge::contextAcquired):

  • platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::bytesAllocated):
(WebCore::Canvas2DLayerBridge::updateBytesAllocated):

  • platform/graphics/chromium/Canvas2DLayerManager.cpp: Added.

(WebCore):
(WebCore::Canvas2DLayerManager::Canvas2DLayerManager):
(WebCore::Canvas2DLayerManager::~Canvas2DLayerManager):
(WebCore::Canvas2DLayerManager::init):
Sets the global limit for the maximum total number of bytes allocated
by deferred layers.
(WebCore::Canvas2DLayerManager::get):
Singleton accessor
(WebCore::Canvas2DLayerManager::layerDidDraw):
Called by Canvas2DLayerBridge to indicate that the layer was drawn to.
(WebCore::Canvas2DLayerManager::addLayerToList):
(WebCore::Canvas2DLayerManager::layerAllocatedStorageChanged):
Called by Canvas2DLayerBridge to indicate thet the memory consumed by
the layer has changed.
(WebCore::Canvas2DLayerManager::layerDidFlush):
Called by Canvas2DLayerBridge to indicated that the pending draw
commands of the layer were flushed.
(WebCore::Canvas2DLayerManager::layerToBeDestroyed):
Called by Canvas2DLayerBridge upon destruction.
(WebCore::Canvas2DLayerManager::freeMemoryIfNecessary):
Called internally. Check that current memory consumption is below
the tolerated limit. If check fails, intiates resource releases.
(WebCore::Canvas2DLayerManager::removeLayerFromList):
(WebCore::Canvas2DLayerManager::isInList):
(WebCore::Canvas2DLayerManager::updateBytesAllocated):

  • platform/graphics/chromium/Canvas2DLayerManager.h: Added.

(WebCore):
(Canvas2DLayerManager):

Source/WebKit/chromium:

Adding unit tests for WebCore::Canvas2DLayerManager

  • WebKit.gypi:
  • tests/Canvas2DLayerManagerTest.cpp: Added.

(FakeCanvas2DLayerBridge):
(FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):
(FakeCanvas2DLayerBridge::fakeFreeableBytes):
(Canvas2DLayerManagerTest):
(Canvas2DLayerManagerTest::storageAllocationTrackingTest):
(Canvas2DLayerManagerTest::evictionTest):
(Canvas2DLayerManagerTest::flushEvictionTest):

1:27 PM Changeset in webkit [126619] by jhoneycutt@apple.com
  • 1 edit
    5 adds
    1 delete in branches/safari-536.26-branch/LayoutTests

2012-08-24 Mark Lam <mark.lam@apple.com>

Re-merge test expectations from r126219. Fixes previous bad merge.
Patch by Mark Lam. Unreviewed.

  • platform/mac-lion/platform/mac: Added.
  • platform/mac-lion/platform/mac-lion: Removed.
  • platform/mac-lion/platform/mac-lion/platform: Removed.
  • platform/mac-lion/platform/mac-lion/platform/mac: Removed.
  • platform/mac-lion/platform/mac-lion/platform/mac/fast: Removed.
  • platform/mac-lion/platform/mac-lion/platform/mac/fast/text: Removed.
  • platform/mac-lion/platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Removed.
  • platform/mac-lion/platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Removed.
  • platform/mac-lion/platform/mac/fast: Added.
  • platform/mac-lion/platform/mac/fast/text: Added.
  • platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Added.
  • platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Added.
1:22 PM Changeset in webkit [126618] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r126606.
http://trac.webkit.org/changeset/126606
https://bugs.webkit.org/show_bug.cgi?id=94970

The change broke TestExpectations.txt (Requested by jchaffraix
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-24

  • platform/chromium/TestExpectations:
1:21 PM Changeset in webkit [126617] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[BlackBerry] Changes resulting from moving network related methods
from platform client to platform settings.
https://bugs.webkit.org/show_bug.cgi?id=94963

Patch by Parth Patel <parpatel@rim.com> on 2012-08-24
Reviewed by Yong Li.

Changes in response to Network methods moved from
class BlackBerryPlatformClient to class BlackBerryPlatformSettings
in platform repository.

Source/WebCore:

No new tests as there are no logical modifications.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::storeCredentials):

  • platform/network/blackberry/NetworkStateNotifierBlackBerry.cpp:

(WebCore::NetworkStateNotifier::NetworkStateNotifier):

Source/WebKit/blackberry:

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::cachePage):

1:19 PM Changeset in webkit [126616] by senorblanco@chromium.org
  • 3 edits
    1 add in trunk/Source/WebCore

Enable accelerated Skia implementation of feBlend filter.
https://bugs.webkit.org/show_bug.cgi?id=94954

Reviewed by James Robinson.

Will be covered by existing tests in svg/ when tests are run with
accelerated painting.

  • WebCore.gypi:
  • platform/graphics/filters/FEBlend.h:

(FEBlend):

  • platform/graphics/filters/skia/FEBlendSkia.cpp: Added.

(WebCore):
(WebCore::toSkiaMode):
(WebCore::FEBlend::platformApplySkia):

12:55 PM Changeset in webkit [126615] by rjkroege@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] CCLayerTreeHostImpl::scrollBy always assumes screen space deltas
https://bugs.webkit.org/show_bug.cgi?id=94946

Reviewed by James Robinson.

Multiply scrollBy deltas in CCLayerTreeHostImpl to correctly support
scrolling on devices that send deltas in DIP (as opposed to screen)
space. Change is a nop on platforms that have not setDeviceScaleFactor
to a non-unity value.

Tested by existing unit tests.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::scrollBy):

12:44 PM Changeset in webkit [126614] by kareng@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/rendering/RenderWidget.cpp

Merge 126042 - [chromium] pepper plugins sometimes are shifted by 1 pixel
https://bugs.webkit.org/show_bug.cgi?id=94257

Patch by Yuzhu Shen <yzshen@chromium.com> on 2012-08-20
Reviewed by Levi Weintraub.

Change RenderWidget::updateWidgetGeometry() to use LayoutRect instead of IntRect to avoid unwanted truncation
(when converting from FloatRect to IntRect).

This makes sure that the optimized rendering code path of Pepper plugin
(PluginInstance::GetBitmapForOptimizedPluginPaint) has consistent coordinates with the normal WebKit rendering
code path.

No new tests because we don't have Pepper plugin tests in WebKit.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetGeometry):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10870077

12:37 PM Changeset in webkit [126613] by oliver@apple.com
  • 4 edits
    5 adds in trunk/Source/JavaScriptCore

Autogenerate Opcode definitions
https://bugs.webkit.org/show_bug.cgi?id=94840

Reviewed by Gavin Barraclough.

Start the process of autogenerating the code emission for the bytecode.
We'll just start with automatic generation of the list of Opcodes as that
requires the actual definition of the opcodes, and the logic for parsing
them.

Due to some rather annoying dependency cycles, this initial version has
the OpcodeDefinitions.h file checked into the tree, although with some
work I hope to be able to fix that.

  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Opcode.h: Include OpcodeDefinitions.h as our definitive source of info about the opcodes.
  • bytecode/OpcodeDefinitions.h: Added. Autogenerated file
  • bytecode/opcodes: Added. The new opcode definition file
  • opcode_definition_generator.py: Added.

(generateOpcodeDefinition):
(generate):

Module that generates the content for OpcodeDefinitions.h

  • opcode_generator.py: Added.

(printUsage):
(main):

Driver script

  • opcode_parser.py: Added. Simple parser for the opcode definitions.
12:19 PM Changeset in webkit [126612] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Debug assertion fires in BackingStorePrivate::renderJob()
https://bugs.webkit.org/show_bug.cgi?id=94960

Patch by Liam Quinn <lquinn@rim.com> on 2012-08-24
Reviewed by Adam Treat.

Change the assertion into an early return as recommended by Adam Treat.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::renderJob):

12:17 PM Changeset in webkit [126611] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

webkit-image-set() function not showing up when computing background property
https://bugs.webkit.org/show_bug.cgi?id=94536

Patch by Anish Bhayani <anish.bhayani@gmail.com> on 2012-08-24
Reviewed by Simon Fraser.

Source/WebCore:

Added isBaseValueList() to ensure ImageSetClass is not displaying shorthand notation.
Tests to make sure background shows '-webkit-image-set('.

Test: fast/css/image-set-setting.html

  • css/CSSValue.h:

(CSSValue):
(WebCore::CSSValue::isBaseValueList):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getLayeredShorthandValue):

LayoutTests:

Used same tests from image-set-parsing to show consistency between CSS background
value and backgroundImage value when setting -webkit-image-set(...).

  • fast/css/image-set-setting-expected.txt: Added.
  • fast/css/image-set-setting.html: Added.
  • fast/css/script-tests/image-set-setting.js: Added.

(testComputedStyle):
(testImageSetRule):

12:15 PM Changeset in webkit [126610] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove unnecessary CSS selector text generation
https://bugs.webkit.org/show_bug.cgi?id=94857

Reviewed by Ojan Vafai.

When setting the selector text, there was some old code that would
check to see if it was unchanged. That got removed, but the code
to generate the previous selector text is still there.

Covered by fast/css/css-set-selector-text.html and
fast/css/css-set-selector-text-crash.html.

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText): Remove unused oldSelectorText.

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText): Remove unused oldSelectorText
and rather than update the cache, just invalidate the previous entry since
we may not need the new selector text.

12:01 PM Changeset in webkit [126609] by cdn@chromium.org
  • 7 edits in trunk/Source

Source/WebCore: Add support for consumable user gestures
https://bugs.webkit.org/show_bug.cgi?id=94867

Reviewed by Adam Barth.

Adds a static counter of the number of consumable gestures. This is decremented either when
a gestures falls out of scope or is consumed via a call to consumeUserGesture().

Planned usage in Chromium is to prevent the piggybacking of multiple popup windows on a
single user gesture.

No new tests as this should not change behavior. The platform must implement consumable
gestures for this to do anything.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::consumeUserGesture):
(WebCore):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • dom/UserGestureIndicator.cpp:

(WebCore):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::~UserGestureIndicator):
(WebCore::UserGestureIndicator::consumeUserGesture):

  • dom/UserGestureIndicator.h:

(WebCore::UserGestureIndicator::processingUserGesture):
(UserGestureIndicator):

Source/WebKit/chromium: Plumb consumeUserGesture() to the chromium platform layer.
https://bugs.webkit.org/show_bug.cgi?id=9475294867

Reviewed by Adam Barth.

  • public/WebFrame.h:

(WebFrame):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::consumeUserGesture):
(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

11:59 AM Changeset in webkit [126608] by wjmaclean@chromium.org
  • 3 edits
    3 adds in trunk

[chromium] gestureTapDown should not select a RenderView node as target.
https://bugs.webkit.org/show_bug.cgi?id=94956

Reviewed by James Robinson.

Add check to prevent selecting a RenderView node as a highlight target.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::bestTouchLinkNode):

LayoutTests:

  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background-expected.txt: Added.
11:55 AM Changeset in webkit [126607] by wangxianzhu@chromium.org
  • 3 edits in trunk/Tools

[Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
https://bugs.webkit.org/show_bug.cgi?id=94865

Reviewed by Dirk Pranke.

Android detects crash of test by checking if the return value of read() is None.
Added a parameter 'treat_no_data_as_crash' to let ServerProcess know the special requirement of Android.
If set, ServerProcess will set _crashed unconditionaly when there is no data.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort):
(ChromiumAndroidPort._android_server_process_constructor):
(ChromiumAndroidDriver._start_once):

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.init):
(ServerProcess._wait_for_data_and_update_buffers_using_select):

11:51 AM Changeset in webkit [126606] by wangxianzhu@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium-Android] Upstream layout test expectations (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=94884

Reviewed by Adam Barth.

This part include:

  • Removed ANDROID tag for passing tests and tests that should be covered by other Android specific rules
  • Added android rules for fast/js and jquery/ tests
  • crbug.com/144536
  • Several other rules with public bugs
  • platform/chromium/TestExpectations:
11:48 AM Changeset in webkit [126605] by commit-queue@webkit.org
  • 12 edits
    13 adds in trunk

[CSS Exclusions] Enable shape-inside for simple rectangles
https://bugs.webkit.org/show_bug.cgi?id=89259

Patch by Bear Travis <betravis@adobe.com> on 2012-08-24
Reviewed by Levi Weintraub.

Source/WebCore:

This patch is the first in a series enabling shape-inside. It adds
support for inline layout within a single render block with a
rectangular shape-inside.
Each RenderBlock with a valid shape-inside maintains a WrapShapeInfo,
which can calculate the areas, or LineSegments, where inline content
can flow on a line. The WrapShapeInfo class maintains a static map of
RenderBlocks to WrapShapeInfos. The basic algorithm involves three stages:

  1. Determine if the RenderBlock has a valid shape-inside, and store it

in a WrapShapeInfo if necessary.

  1. If the inline content is affected by a shape-inside, use the

corresponding WrapShapeInfo to break the content into line segments.

  1. Lay out the line segments.

Tests: fast/exclusions/shape-inside/shape-inside-floats-simple.html

fast/exclusions/shape-inside/shape-inside-inline-elements.html
fast/exclusions/shape-inside/shape-inside-overflow.html
fast/exclusions/shape-inside/shape-inside-percentage-auto.html
fast/exclusions/shape-inside/shape-inside-text.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed): Remove WrapShapeInfo when destroyed.
(WebCore::RenderBlock::styleDidChange): Detect modifications to style()->wrapShapeInside.
(WebCore):
(WebCore::RenderBlock::updateWrapShapeInfoAfterStyleChange): Update WrapShapeInfo
when style()->wrapShapeInside changes.
(WebCore::RenderBlock::layoutBlock): Notify WrapShapeInfo of changes in logicalWidth
and logicalHeight before laying out inline content.

  • rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::wrapShapeInfo): Return the wrapShapeInfo associated with a
RenderBlock.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::LineWidth): Determine the WrapShapeInfo::LineSegment this LineWidth
corresponds to, if any.
(LineWidth):
(WebCore::LineWidth::updateAvailableWidth): The width's LineSegment boundaries affect
the available width.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): The current LineSegment
affects the left & right positioning of inline boxes.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Move to the top of the inside wrap
shape before beginning inline layout, and update the line segments for each line.

  • rendering/WrapShapeInfo.cpp: Added.

(WebCore):
(WebCore::WrapShapeInfo::WrapShapeInfo): Create an empty WrapShapeInfo.
(WebCore::WrapShapeInfo::~WrapShapeInfo): No additional cleanup.
(WebCore::WrapShapeInfo::create): Create a WrapShapeInfo reference.
(WebCore::WrapShapeInfo::ensureWrapShapeInfoForRenderBlock): Create a WrapShapeInfo
for a RenderBlock with an inside WrapShape and place it in the WrapShapeInfo map.
(WebCore::WrapShapeInfo::wrapShapeInfoForRenderBlock): Lookup the WrapShapeInfo for
a RenderBlock in the WrapShapeInfo map.
(WebCore::WrapShapeInfo::isWrapShapeInfoEnabledForBlock): Determine if a RenderBlock
has an inside wrap shape that we can use for inline layout.
(WebCore::WrapShapeInfo::removeWrapShapeInfoForRenderBlock): Remove a RenderBlock's
WrapShapeInfo from the WrapShapeInfo map.
(WebCore::WrapShapeInfo::hasSegments): Returns true if there are any line segments
for the current line.
(WebCore::WrapShapeInfo::computeShapeSize): Compute the dimensions of the wrap shape
based on a block's logical width & height.
(WebCore::WrapShapeInfo::computeSegmentsForLine): Sets the current line and computes
its line segments.

  • rendering/WrapShapeInfo.h: Added.

(WebCore):
(LineSegment):
(WrapShapeInfo):
(WebCore::WrapShapeInfo::shapeTop): The top of a wrap shape, where the inline content
area begins.
(WebCore::WrapShapeInfo::segments): The list of line segments for the current line.
(WebCore::WrapShapeInfo::wrapShapeSizeNeedsRecomputing): Mark a WrapShapeInfo as
needing to recompute its WrapShape dimensions.
(WebCore::WrapShapeInfo::lineState): The current line state: above, inside, or below
the wrap shape.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Changes to shape inside require relayout.

LayoutTests:

Test that inline content correctly wraps for a simple rectangular
shape-inside. Text and inline content should wrap inside the
rectangular shape-inside, and overflow to its containing block.
Inline content inside a shape-inside should also avoid floats.

  • fast/exclusions/shape-inside/shape-inside-floats-simple-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-floats-simple.html: Added.
  • fast/exclusions/shape-inside/shape-inside-inline-elements-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-inline-elements.html: Added.
  • fast/exclusions/shape-inside/shape-inside-overflow-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-overflow.html: Added.
  • fast/exclusions/shape-inside/shape-inside-percentage-auto-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-percentage-auto.html: Added.
  • fast/exclusions/shape-inside/shape-inside-text-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-text.html: Added.
11:43 AM Changeset in webkit [126604] by jchaffraix@webkit.org
  • 2 edits
    16 adds in trunk/LayoutTests

Unreviewed Chromium rebaseline.

  • platform/chromium-mac/fast/table/border-collapsing/cached-69296-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-cell-append-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-cell-remove-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-cell-border-color-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-cell-border-width-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-col-border-color-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-col-border-width-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-row-border-color-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-table-border-color-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-table-border-width-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
  • platform/chromium/TestExpectations:

Rebaselined the border-collapsing tests on Mac. They have required a different baseline for several months
now and the root cause (small alpha difference) doesn't seem to be worked on.

11:00 AM Changeset in webkit [126603] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp

Fix build bustage on android.

10:49 AM Changeset in webkit [126602] by hyatt@apple.com
  • 8 edits in trunk/Source/WebCore

[New Multicolumn] Plumbing to prepare for contents painting and hit testing implementation.
https://bugs.webkit.org/show_bug.cgi?id=94945

Reviewed by Dan Bernstein.

Make some improvements to how column sets interact with flow threads. Make sure the last column set
always expands to hold all of the remaining flow thread contents (including overflow). Rename the
column height, count and width variables to have "computed" in front of them to indicate that they
just represent what the multi-column algorithm computed so that there is no confusion between the
computed column count and the actual number of columns in the set.

Implement the ability to get the actual column count based off the logical height of the flow thread
portion contained within the column set.

Fix gap painting to use the actual column count rather than the computed column count.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
After a flow thread is done laying out, have it tell the last region to expand to
encompass all the remaining contents if it wants to do so. Column and page sets will always do this.

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):
Override computeLogicalHeight() to do nothing. We want the flow thread to just keep its intrinsic
height, since the last column set is always going to expand to encompass the flow thread's contents
anyway. Unlike CSS Regions, we don't ever "run out of room."

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::computeLogicalWidth):
(WebCore::RenderMultiColumnSet::computeLogicalHeight):
(WebCore::RenderMultiColumnSet::columnCount):
(WebCore::RenderMultiColumnSet::columnRectAt):
(WebCore::RenderMultiColumnSet::paintColumnRules):
(WebCore::RenderMultiColumnSet::paintColumnContents):
Rename count, width and height for columns to have "computed" in front of the members and functions.
In particular, this lets us distinguish the computed column count from the actual column count.

  • rendering/RenderMultiColumnSet.h:

(WebCore::RenderMultiColumnSet::computedColumnCount):
(WebCore::RenderMultiColumnSet::computedColumnWidth):
(WebCore::RenderMultiColumnSet::computedColumnHeight):
(WebCore::RenderMultiColumnSet::setComputedColumnWidthAndCount):
(WebCore::RenderMultiColumnSet::setComputedColumnHeight):
Rename count, width and height for columns to have "computed" in front of the members and functions.
In particular, this lets us distinguish the computed column count from the actual column count.

  • rendering/RenderRegion.h:

(RenderRegion):
(WebCore::RenderRegion::expandToEncompassFlowThreadContentsIfNeeded):

  • rendering/RenderRegionSet.cpp:

(WebCore::RenderRegionSet::expandToEncompassFlowThreadContentsIfNeeded):
(WebCore):

  • rendering/RenderRegionSet.h:

(RenderRegionSet):
Make sure region sets expand to encompass all the remaining flow thread contents. We are always
able to generate more columns or pages, so in effect the amount of the flow thread we can
consume is unlimited.

10:48 AM Changeset in webkit [126601] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Range input progress indicator is upside down when vertical and RTL is set
https://bugs.webkit.org/show_bug.cgi?id=94948

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-24
Reviewed by Kenneth Rohde Christiansen.

RTL should not affect vertical sliders, but on Qt it was changing the
direction of the progress indicator, making it flow in the opposite
direction of the knob.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::paintSliderTrack):

10:47 AM Changeset in webkit [126600] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding expectations for a few failing tests that popped up on the debug
builder after it was brought back into a working state.

Removing failure expectation for fast/dom/Window/window-postmessage-clone.html
after the test was fixed in r126464.

  • platform/gtk/TestExpectations:
10:38 AM Changeset in webkit [126599] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations:

Marked fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html as failing following r126534.

10:21 AM Changeset in webkit [126598] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Animation & UI lag when rendering
https://bugs.webkit.org/show_bug.cgi?id=94943

Patch by Andrew Lo <anlo@rim.com> on 2012-08-24
Reviewed by Rob Buis.

Schedule a backing store blit & composite when commiting root layer.
This results in compositing not having to wait until after a long render
operation, increasing responsiveness & fixing animations which skip to
the last frame due to lag.

This can cause a blit during a "one shot drawing synchronization", which is
a render & commit on the AC layers, which may result in flashing.
However, this can happen in other situations as well, and we feel that
the responsiveness, reduced lag, and smoothness of animations is
more important.

Internal PR194209
Internally reviewed by: George Staikos.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::commitRootLayer):

10:21 AM Changeset in webkit [126597] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

build-webkit --gtk fails with Can't exec ""
https://bugs.webkit.org/show_bug.cgi?id=94944

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-08-24
Reviewed by Martin Robinson.

When jhbuild wrapper is not needed, do unshift a blank string to build
arguments.

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):

10:12 AM Changeset in webkit [126596] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[BlackBerry] Changes resulting from moving application directory methods from platform client to platform settings.
https://bugs.webkit.org/show_bug.cgi?id=94249

Patch by Parth Patel <parpatel@rim.com> on 2012-08-24
Reviewed by Rob Buis.

Source/WebCore:

PR 170160

Changes in response to Application Directory methods moved from
Class BlackBerryPlatformClient to BlackBerryPlatformSettings in
platform respository since these methods are more appropriate in
class BlackBerryPlatformSettings.

No new tests as there are no logical modifications.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::CookieManager):

  • platform/blackberry/FileSystemBlackBerry.cpp:

(WebCore::homeDirectoryPath):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::load):

  • platform/network/blackberry/AutofillBackingStore.cpp:

(WebCore::autofillBackingStore):

  • platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::credentialBackingStore):

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::isPreferredPluginDirectory):

Source/WebKit/blackberry:

PR# 170160
Changes in response to Application Directory methods moved from
Class BlackBerryPlatformClient to BlackBerryPlatformSettings in
platform respository since these methods are more appropriate in
class BlackBerryPlatformSettings.

  • WebCoreSupport/IconDatabaseClientBlackBerry.cpp:

(WebCore::IconDatabaseClientBlackBerry::initIconDatabase):

10:10 AM Changeset in webkit [126595] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: do not count weak and shortcut edges.
https://bugs.webkit.org/show_bug.cgi?id=94947

Reviewed by Yury Semikhatsky.

When calculating distance from an object to Window in heap profiler we should only
take into account strong real references. This means that shortcuts and weak edges should be ignored.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._bfs):

9:49 AM Changeset in webkit [126594] by vsevik@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/inspector/front-end/HandlerRegistry.js

Merge 125668 - Web Inspector: [REGRESSION] "save as" of edited source in developer mode fails to update saved file
https://bugs.webkit.org/show_bug.cgi?id=94074

Reviewed by Pavel Feldman.

Added dirty flag check when saving uiSourceCode to save working copy in this case.

  • inspector/front-end/HandlerRegistry.js:

(WebInspector.HandlerRegistry.prototype.appendApplicableItems.save):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems):

BUG=141180
TBR=vsevik@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10883027

9:47 AM Changeset in webkit [126593] by commit-queue@webkit.org
  • 1 edit
    13 adds in trunk/LayoutTests

[EFL] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=94942

Unreviewed EFL gardening. Add platform specific baselines required
after r126343 and r126372.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-24

  • platform/efl/fast/overflow/paged-x-div-expected.png: Added.
  • platform/efl/fast/overflow/paged-x-div-expected.txt: Added.
  • platform/efl/fast/overflow/paged-x-on-root-expected.png: Added.
  • platform/efl/fast/overflow/paged-x-on-root-expected.txt: Added.
  • platform/efl/fast/overflow/paged-y-div-expected.png: Added.
  • platform/efl/fast/overflow/paged-y-div-expected.txt: Added.
  • platform/efl/fast/overflow/paged-y-on-root-expected.png: Added.
  • platform/efl/fast/overflow/paged-y-on-root-expected.txt: Added.
  • platform/efl/media/track/track-cue-rendering-horizontal-expected.png: Added.
  • platform/efl/media/track/track-cue-rendering-horizontal-expected.txt: Added.
  • platform/efl/media/track/track-cue-rendering-vertical-expected.png: Added.
  • platform/efl/media/track/track-cue-rendering-vertical-expected.txt: Added.
9:42 AM Changeset in webkit [126592] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] fast/dom/navigator-vibration.html is failing after r126562
https://bugs.webkit.org/show_bug.cgi?id=94939

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-24
Reviewed by Kentaro Hara.

Update expected results for fast/dom/navigator-vibration.html now that
NotEnoughArguments is thrown instead of TypeError if the actual argument
count is less than the least mandatory argument count.

  • fast/dom/navigator-vibration-expected.txt:
9:39 AM Changeset in webkit [126591] by jchaffraix@webkit.org
  • 3 edits
    3 adds in trunk

Crash in RenderTableCell::borderTop() due to custom scrollbars after r124168
https://bugs.webkit.org/show_bug.cgi?id=93903

Reviewed by Tony Chang.

Source/WebCore:

r124168 changed when we create scrollbars so that it happens (rightly) at style change time.
However the RenderScrollbar code assumes that any overflow: scroll RenderScrollbar would be
created at layout time as it directly tries to layout to scrollbar parts. The big issues with
the move is that the first style change operates on a detached renderer which means that we
could crash in some situation.

Test: scrollbars/custom-scrollbar-table-cell.html

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
Fixed the crash by using style information instead of calling the renderer. This is guaranteed
to be safe but it also means that custom scrollbars sizing is not right on table cells with
collapsing borders. The existing logic was querying layout information at style change so I
wouldn't bet on it working properly anyway.

LayoutTests:

  • scrollbars/custom-scrollbar-table-cell-expected.png: Added.
  • scrollbars/custom-scrollbar-table-cell-expected.txt: Added.
  • scrollbars/custom-scrollbar-table-cell.html: Added.
9:37 AM Changeset in webkit [126590] by jchaffraix@webkit.org
  • 7 edits in trunk/Source/WebCore

Remove RenderTableSection::removeChild
https://bugs.webkit.org/show_bug.cgi?id=94883

Reviewed by Abhishek Arya.

This change removed removeChild, replaced by willBeRemoved calls in the children
class. This is done to ensure that post-removal invalidations are properly done
in table rows and table cells.

Refactoring covered by existing tests.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::removeChild):

  • rendering/RenderTableSection.h:

Removed this function...

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::willBeRemovedFromTree):

  • rendering/RenderTableCell.h:

(RenderTableCell):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::willBeRemovedFromTree):

  • rendering/RenderTableRow.h:

... and moved the invalidation into the willBeRemovedFromTree functions.
The willBeRemovedFromTree replaced the willBeDestroyed functions in the
2 classes as the invalidation really represented tree removal updates,
not death updates.

8:40 AM Changeset in webkit [126589] by apavlov@chromium.org
  • 6 edits in trunk/LayoutTests

Web Inspector: Unreviewed, fix test flakiness due to the recently introduced lazy panel loading.

  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/step-through-event-listeners.html:
  • inspector/elements/edit-dom-actions.html:
  • inspector/elements/edit-style-attribute.html:
  • inspector/timeline/timeline-enum-stability.html:
8:30 AM Changeset in webkit [126588] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Touch cancel can cause huge and needless invalidations
https://bugs.webkit.org/show_bug.cgi?id=94938
PR #198051

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Gen Mak.

In order to remove the possible hover effect on touch_cancel, we always
invalidate the node under the fat finger, being the fat finger valid or not.

Point is: having a valid fat finger node does not mean the original touch
position was actually adjust for clicking or that the fat finger is actually
valid. We set the fat finger node to be the result of the point-based hit-test
regardless if it is a click target or not (in order to make our mouse-move
machinery to work).

We should can less aggressively invalidate the fat finger node, since it can
be rather an expensive call (longer than 1s in the worst scenario).

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::touchEventCancel):

8:12 AM Changeset in webkit [126587] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Extend LayerFilterRenderer in preparation for CSS Shaders
https://bugs.webkit.org/show_bug.cgi?id=94724

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-08-24
Reviewed by George Staikos.

LayerFilterRenderer defines a CSS Filter in terms of one or more Actions.
A LayerFilterRendererAction holds a vertex shader, a fragment shader, and
zero or more Parameters. A Parameter is a uniform, varying, or other
information which is needed to render a filter.

This patch implements certain new Parameter types, including vertex/element
buffers and vertex attributes which are needed to implement composited
CSS Shaders on BB10. In addition, a new drawing mode is required in order
to draw CSS Shaders meshes from vertex/element buffers.

No new tests, because this patch introduces no new functionality. When
the patch which enables CSS Shaders on BB10 in upstreamed, tests for
CSS Shaders will prove this code to be correct.

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::operationTypeToProgramID):
(WebCore::Uniform::Uniform):
(WebCore::Uniform1f::create):
(WebCore::Uniform1f::Uniform1f):
(WebCore):
(WebCore::Uniform1i::apply):
(WebCore::Uniform1i::create):
(WebCore::Uniform1i::Uniform1i):
(WebCore::Uniform2f::create):
(WebCore::Uniform2f::Uniform2f):
(WebCore::Uniform3f::create):
(WebCore::Uniform3f::Uniform3f):
(WebCore::Uniform4f::apply):
(WebCore::Uniform4f::create):
(WebCore::Uniform4f::Uniform4f):
(WebCore::Matrix4fv::apply):
(WebCore::Matrix4fv::create):
(WebCore::Matrix4fv::Matrix4fv):
(WebCore::Matrix4fv::~Matrix4fv):
(WebCore::Buffer::apply):
(WebCore::Buffer::restoreState):
(WebCore::Buffer::create):
(WebCore::Buffer::Buffer):
(WebCore::VertexAttribf::apply):
(WebCore::VertexAttribf::restoreState):
(WebCore::VertexAttribf::create):
(WebCore::VertexAttribf::VertexAttribf):
(WebCore::LayerFilterRendererAction::LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::useActionOn):
(WebCore::LayerFilterRendererAction::restoreState):
(WebCore::LayerFilterRenderer::LayerFilterRenderer):
(WebCore::LayerFilterRenderer::actionsForOperations):
(WebCore::LayerFilterRenderer::applyActions):

  • platform/graphics/blackberry/LayerFilterRenderer.h:

(Parameter):
(WebCore::Parameter::restoreState):
(WebCore::Parameter::~Parameter):
(WebCore::Parameter::Parameter):
(WebCore):
(Uniform):
(WebCore::Uniform::~Uniform):
(Uniform1f):
(Uniform1i):
(Uniform2f):
(Uniform3f):
(Uniform4f):
(Matrix4fv):
(Buffer):
(VertexAttribf):
(WebCore::LayerFilterRendererAction::appendParameter):
(LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::drawingMode):
(WebCore::LayerFilterRendererAction::setDrawingMode):
(WebCore::LayerFilterRendererAction::drawingModeParameter):
(WebCore::LayerFilterRendererAction::setDrawingModeParameter):

8:10 AM Changeset in webkit [126586] by tommyw@google.com
  • 18 edits
    2 adds in trunk

MediaStream API: Add readyState functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=94813

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCPeerConnectionHandlerClient.h:

(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

This patch adds readyState functionality to RTCPeerConnection together with related callbacks and methods.

Test: fast/mediastream/RTCPeerConnection-state.html

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::readyState):
(WebCore):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::didChangeReadyState):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeReadyState):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::stop):
(WebCore):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(RTCPeerConnectionHandler):

  • platform/mediastream/RTCPeerConnectionHandlerClient.h:

(RTCPeerConnectionHandlerClient):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::RTCPeerConnectionHandlerChromium):
(WebCore::RTCPeerConnectionHandlerChromium::stop):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::didChangeReadyState):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::stop):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-state-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-state.html: Added.
7:39 AM Changeset in webkit [126585] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] A follow up to simplify code with nested closures
https://bugs.webkit.org/show_bug.cgi?id=94931

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-24
Reviewed by Pavel Feldman.

Simplifies the code with nested closures.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

7:05 AM Changeset in webkit [126584] by vsevik@chromium.org
  • 6 edits in trunk

Web Inspector: Get rid of frontendReused logic on front-end.
https://bugs.webkit.org/show_bug.cgi?id=94929

Reviewed by Pavel Feldman.

Source/WebCore:

Removed frontendReused method from ResourceTreeModel.

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._frameNavigated):

  • inspector/front-end/Workspace.js:

(WebInspector.Workspace): workspace doesn't need to listen for CachedResourcesLoaded event anymore.

  • inspector/front-end/inspector.js: removed unused method.

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-events.html:
7:02 AM Changeset in webkit [126583] by g.czajkowski@samsung.com
  • 5 edits
    2 moves
    1 add in trunk/Source/WebCore

Share WebKit-Gtk's Enchant implementation with others WebKit ports.
https://bugs.webkit.org/show_bug.cgi?id=94320

Reviewed by Carlos Garcia Campos.

The main reason of this change is to share WebKit-Gtk implementation of spelling
with others ports that use the Enchant library.
This is the first step to enable spelling for WebKit-Efl (https://bugs.webkit.org/show_bug.cgi?id=91854)

Files that implement spelling were moved to platform/text/enchant directory.

This patch stops using Pango backend to find the beginning/end of the word.
Those information are delivered through ICU interface by using TextBreakIterator.

  • GNUmakefile.am: Added newly created 'enchant' directory to WebKit-Gtk's sources.
  • GNUmakefile.list.am: Updated location of TextCheckerEnchant.{h,cpp} files.
  • editing/visible_units.cpp: Removed 'static' modifier for 'isLogicalStartOfWord' and 'islogicalEndOfWord' functions.

(WebCore::isLogicalStartOfWord):
(WebCore::islogicalEndOfWord):

  • editing/visible_units.h: Added isLogicalStartOfWord' and 'islogicalEndOfWord' functions to header as they are used by TextCheckerEnchant.cpp
  • platform/text/enchant/TextCheckerEnchant.cpp: Renamed from Source/WebCore/platform/text/gtk/TextCheckerEnchant.cpp.

(enchantDictDescribeCallback): Added comments.
(TextCheckerEnchant::TextCheckerEnchant):
(TextCheckerEnchant::~TextCheckerEnchant):
(TextCheckerEnchant::ignoreWord):
(TextCheckerEnchant::learnWord):
(TextCheckerEnchant::checkSpellingOfString): Using ICU instead of Pango to find out the beginning/end of the word.
(TextCheckerEnchant::getGuessesForWord): Replaced gchar type to char.
(TextCheckerEnchant::updateSpellCheckingLanguages): Using WebCore::defaulLanguage() instead of Pango backend.
(TextCheckerEnchant::getSpellCheckingLanguages):
(TextCheckerEnchant::freeEnchantBrokerDictionaries):

  • platform/text/enchant/TextCheckerEnchant.h: Renamed from Source/WebCore/platform/text/gtk/TextCheckerEnchant.h.

(WebCore):
(TextCheckerEnchant):
(WebCore::TextCheckerEnchant::create):

6:50 AM Changeset in webkit [126582] by abecsi@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit2

[Qt][WK2] Fix custom device pixel ratio propagation and add QML API tests
https://bugs.webkit.org/show_bug.cgi?id=88531

Reviewed by Kenneth Rohde Christiansen.

Defer setting the custom device pixel ratio until the page item has
a valid size to make sure that the scale factor reaches the web process.

QML test based on patch by Alexander Færøy.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
(QQuickWebViewExperimental::devicePixelRatio):
(QQuickWebViewExperimental::setDevicePixelRatio):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml: Added. Test case for the QML device pixel ratio API.
6:46 AM Changeset in webkit [126581] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Fix compile warning
https://bugs.webkit.org/show_bug.cgi?id=94930

Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-24
Reviewed by Kenneth Rohde Christiansen.

Fixed compile warning.

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(ewk_back_forward_list_n_back_items_copy): NULL used in arithmetic [-Wpointer-arith]
(ewk_back_forward_list_n_forward_items_copy): NULL used in arithmetic [-Wpointer-arith]

6:30 AM Changeset in webkit [126580] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: do not send profile headers to the front-end until explicitly requested.
https://bugs.webkit.org/show_bug.cgi?id=94928

Reviewed by Vsevolod Vlasov.

Simple flag is added.

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

6:25 AM Changeset in webkit [126579] by pfeldman@chromium.org
  • 14 edits in trunk

Web Inspector: make ui component compile
https://bugs.webkit.org/show_bug.cgi?id=94827

Reviewed by Vsevolod Vlasov.

Moved buildImagePreviewContents into the sdk-aware code.
Drive-by more compilation fixes.

  • inspector/compile-front-end.py:
  • inspector/front-end/DOMPresentationUtils.js:

(WebInspector.DOMPresentationUtils.buildImagePreviewContents.errorCallback):
(WebInspector.DOMPresentationUtils.buildImagePreviewContents.buildContent):
(WebInspector.DOMPresentationUtils.buildImagePreviewContents):

  • inspector/front-end/Database.js:
  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._createLink):

  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):

  • inspector/front-end/ParsedURL.js:

(WebInspector.ParsedURL.prototype.get displayName):

  • inspector/front-end/ResourceUtils.js:
  • inspector/front-end/SourceFrame.js:

(WebInspector.TextEditorDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.createLink):

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditorDelegate.prototype.populateTextAreaContextMenu):
(WebInspector.TextEditorDelegate.prototype.createLink):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):

  • inspector/front-end/UIUtils.js:
6:21 AM Changeset in webkit [126578] by anilsson@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add WebPage API to reset block zoom
https://bugs.webkit.org/show_bug.cgi?id=94863

PR 187478
This is an alternative to WebPage::blockZoomAnimationFinished() when
it's desirable to avoid rerendering of the whole web page at the end
of block zoom. This is the case when the planned "incremental zoom
factor" is used instead of zoomAboutPoint and it's relatives.

Ideally, the block zoom algorithm would be clever enough not to need
a reset or any form of callback when the animation finishes, but that
requires the implementation of said incremental zoom factor, which is
not done yet.

Reviewed by Antonio Gomes.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::resetBlockZoom):
(WebKit):

  • Api/WebPage.h:
6:18 AM Changeset in webkit [126577] by Michael Brüning
  • 2 edits in trunk/Tools

Unreviewed. Adding myself to committers list.

Also updated email information.

  • Scripts/webkitpy/common/config/committers.py:
6:14 AM Changeset in webkit [126576] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: fixing inspector/elements/iframe-load-event.html broken by r126572.

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.resolveURL):

6:04 AM Changeset in webkit [126575] by abecsi@webkit.org
  • 2 edits in trunk/Source/WTF

[Qt] Be more explicit about the ICU dependency in the error message

Rubber-stamped by Simon Hausmann.

When building QtWebKit with a Qt5 which was not configured with libICU support
the error message is somewhat ambiguous about the indirect dependency.

  • WTF.pri:
5:57 AM EFLWebKit edited by rafael.lobo@openbossa.org
Adding one more dependency (libffi-dev), required to compile glib-2.33.2 (diff)
5:23 AM Changeset in webkit [126574] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Implement custom wrap functions on GL context
https://bugs.webkit.org/show_bug.cgi?id=94799

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-24
Reviewed by Pavel Feldman.

Implement custom wrap functions on WebGL rendering context for WebGL instrumentation.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

5:20 AM Changeset in webkit [126573] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Web Inspector: three layout tests crashing with assertion failure
https://bugs.webkit.org/show_bug.cgi?id=94829

Not reviewed: updating test expectations.

  • platform/chromium/TestExpectations:
5:10 AM Changeset in webkit [126572] by pfeldman@chromium.org
  • 19 edits in trunk

Web Inspector: resolve URLs upon creation, get rid of populateHrefContextMenu
https://bugs.webkit.org/show_bug.cgi?id=94900

Reviewed by Vsevolod Vlasov.

  • This change makes sure we resolve URLs upon adding the to the UI. Then we treat them as absolute links in context menu, etc.
  • There is no need to override context menu for links anymore - system menu will do.
  • inspector/front-end/AuditResultView.js:

(WebInspector.AuditResultView):

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.descendantUserPropertyCount):
(WebInspector.DOMNode.prototype.resolveURL):

  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):

  • inspector/front-end/HandlerRegistry.js:

(WebInspector.HandlerRegistry.prototype.appendApplicableItems):
(WebInspector.HandlerRegistry.prototype._appendContentProviderItems):
(WebInspector.HandlerRegistry.prototype._appendHrefItems):

  • inspector/front-end/ParsedURL.js:

(WebInspector.ParsedURL.completeURL):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyRequestAsNode):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):

  • inspector/front-end/UIUtils.js:
4:47 AM Changeset in webkit [126571] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Back-forward list API needs extension
https://bugs.webkit.org/show_bug.cgi?id=94582

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-24
Reviewed by Kenneth Rohde Christiansen.

Added several new functions wrapping existing WK2 C back-forward list API
and returning list of items preceding or following the current one.
Corresponding API unit tests are also added.

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(createEinaList):
(ewk_back_forward_list_n_back_items_copy):
(ewk_back_forward_list_n_forward_items_copy):

  • UIProcess/API/efl/ewk_back_forward_list.h:
  • UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:

(freeEinaList):
(TEST_F):

4:27 AM Changeset in webkit [126570] by Michael Brüning
  • 6 edits in trunk

[Qt][WK2] Make viewport related experimental.test properties encapsulated.
https://bugs.webkit.org/show_bug.cgi?id=88320

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Introducing a new viewport attribute to QWebKitTest to group the viewport related
attributes into one QJsonObject. Also adding a static method to convert a QSizeF to
a QJsonObject.

  • UIProcess/API/qt/qwebkittest.cpp:

(qSizeFToJsonObject):
(QWebKitTest::viewport):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::contentsScale):

  • UIProcess/API/qt/qwebkittest_p.h:
  • UIProcess/qt/QtViewportHandler.cpp:

(WebKit::QtViewportHandler::viewportAttributesChanged):

Tools:

Changed the access to the viewport attributes to use the viewport object that is introduced by this change.

  • MiniBrowser/qt/qml/ViewportInfoItem.qml:
4:24 AM Changeset in webkit [126569] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Use the new 'feature_defines' variable to generate DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=94919

Patch by Xan Lopez <xlopez@igalia.com> on 2012-08-24
Reviewed by Carlos Garcia Campos.

Update to use the new 'feature_defines' variable, otherwise the
bindings will be broken.

  • bindings/gobject/GNUmakefile.am: ditto.
3:19 AM Changeset in webkit [126568] by zandobersek@gmail.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed GTK gardening.

Updating baselines for css3/flexbox/flexitem.html after r126503.

  • platform/gtk/css3/flexbox: Removed.
  • platform/gtk/css3/flexbox/flexitem-expected.txt: Removed.
3:08 AM Changeset in webkit [126567] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove RefPtr from HTMLTextAreaElement::m_placeholder
https://bugs.webkit.org/show_bug.cgi?id=94338

Reviewed by Kent Tamura.

To avoid reference cycles of RefPtr<Node>s, we want to remove
unnecessary RefPtr<Node>s. The rationale is described in bug 94324.

HTMLTextAreaElement::m_placeholder does not need to be a RefPtr<Node>,
because it is guaranteed to point to a shadow DOM tree of the
HTMLTextAreaElement node, which is guaranteed to exist in the subtree
of the HTMLTextAreaElement node.

No tests. No change in behavior.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
(WebCore::HTMLTextAreaElement::placeholderElement):
(WebCore::HTMLTextAreaElement::attach):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/HTMLTextAreaElement.h:

(HTMLTextAreaElement):

2:40 AM Changeset in webkit [126566] by commit-queue@webkit.org
  • 14 edits
    2 deletes in trunk/Source

[V8] Refactor away IsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=93971

Patch by Dan Carney <dcarney@google.com> on 2012-08-24
Reviewed by Kentaro Hara.

Source/WebCore:

Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld.
This paves the way towards a JSC-like use of DOMWrapperWorld.

No new tests. No change in functionality.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore):
(WebCore::DOMWrapperWorld::createUninitializedWorld):
(WebCore::DOMWrapperWorld::createMainWorld):
(WebCore::mainThreadNormalWorld):
(WebCore::isolatedWorldMap):
(WebCore::DOMWrapperWorld::deallocate):
(WebCore::DOMWrapperWorld::getOrCreateIsolatedWorld):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolatedWorldsExist):
(WebCore::DOMWrapperWorld::isMainWorld):
(WebCore::DOMWrapperWorld::worldId):
(WebCore::DOMWrapperWorld::extensionGroup):
(WebCore::DOMWrapperWorld::domDataStore):
(WebCore::DOMWrapperWorld::deref):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):

  • bindings/v8/IsolatedWorld.cpp: Removed.
  • bindings/v8/IsolatedWorld.h: Removed.
  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::evaluateInIsolatedWorld):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
(WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):

  • bindings/v8/V8DOMMap.h:

(DOMDataStoreHandle):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):

  • bindings/v8/V8IsolatedContext.h:

(V8IsolatedContext):
(WebCore::V8IsolatedContext::getEntered):
(WebCore::V8IsolatedContext::world):

  • bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::registerDOMDataStore):
(WebCore::V8PerIsolateData::unregisterDOMDataStore):

Source/WebKit/chromium:

Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld.

  • src/WebViewImpl.cpp:

(WebKit::WebView::addUserScript):
(WebKit::WebView::addUserStyleSheet):

2:36 AM Changeset in webkit [126565] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Added missing SKIP keyword to platform/efl/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=94781

Unreviewed. Removed unnecessary SKIP keyword.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-24

  • platform/efl/TestExpectations:
2:27 AM Changeset in webkit [126564] by abarth@webkit.org
  • 9 edits in trunk/Source/WebCore

[V8] Improve the developer ergonomics of ScopedPersistent
https://bugs.webkit.org/show_bug.cgi?id=94901

Reviewed by Kentaro Hara.

As requested by haraken, this patch adds some helper functions to
ScopedPersistent so that we don't need to call get() all the time.

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/ScopedPersistent.h:

(WebCore::ScopedPersistent::get):
(WebCore::ScopedPersistent::operator->):
(ScopedPersistent):
(WebCore::ScopedPersistent::isEmpty):

  • bindings/v8/ScriptValue.cpp:

(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):

  • bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::~V8AbstractEventListener):
(WebCore::V8AbstractEventListener::getReceiverObject):

  • bindings/v8/V8AbstractEventListener.h:

(WebCore::V8AbstractEventListener::hasExistingListenerObject):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::isContextInitialized):
(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::clearForClose):
(WebCore::V8DOMWindowShell::clearForNavigation):
(WebCore::V8DOMWindowShell::initContextIfNeeded):
(WebCore::V8DOMWindowShell::updateDocumentWrapper):
(WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
(WebCore::V8DOMWindowShell::clearDocumentWrapperCache):
(WebCore::V8DOMWindowShell::setSecurityToken):
(WebCore::V8DOMWindowShell::updateDocument):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):
(WebCore::V8DOMWindowShell::updateSecurityOrigin):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8PerContextData::constructorForTypeSlowCase):

2:23 AM Changeset in webkit [126563] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: move ResourceViews to "components" module - it is used from the Resources as well.
https://bugs.webkit.org/show_bug.cgi?id=94904

Reviewed by Vsevolod Vlasov.

  • WebCore.gypi:
  • inspector/compile-front-end.py:
  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/inspector.html:
2:02 AM Changeset in webkit [126562] by commit-queue@webkit.org
  • 19 edits
    4 deletes in trunk

Source/WebCore: Check argument count in the dispatch function for overloaded functions
https://bugs.webkit.org/show_bug.cgi?id=94790

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-08-24
Reviewed by Kentaro Hara.

Throw NotEnoughArguments exception for overloaded functions if actual argument
count is less than the least mandatory argument count among all overloaded.

Reset JS and V8 binding tests result for the change.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateFunctionParametersCheck):
(GenerateOverloadedFunction):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionParametersCheck):
(GenerateOverloadedFunctionCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):

LayoutTests: Remove platform specific expected files after the change
https://bugs.webkit.org/show_bug.cgi?id=94790

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-08-24
Reviewed by Kentaro Hara.

  1. Use the cross-platform expected files for the 2 tests in question.
  2. Update other tests for overloaded functions and their expected files

affected by the change.

  • fast/canvas/canvas-overloads-drawImage-expected.txt:
  • fast/canvas/canvas-overloads-setFillColor-expected.txt:
  • fast/canvas/canvas-overloads-setShadow-expected.txt:
  • fast/canvas/canvas-overloads-setStrokeColor-expected.txt:
  • fast/canvas/script-tests/canvas-overloads-drawImage.js:
  • fast/canvas/script-tests/canvas-overloads-setFillColor.js:
  • fast/canvas/script-tests/canvas-overloads-setShadow.js:
  • fast/canvas/script-tests/canvas-overloads-setStrokeColor.js:
  • fast/canvas/webgl/texImageTest-expected.txt:
  • platform/chromium/fast/files/create-blob-url-crash-expected.txt: Removed.
  • platform/chromium/fast/files/url-required-arguments-expected.txt: Removed.
  • platform/gtk/fast/files/create-blob-url-crash-expected.txt: Removed.
  • platform/gtk/fast/files/url-required-arguments-expected.txt: Removed.
  • storage/indexeddb/index-get-key-argument-required-expected.txt:
  • storage/indexeddb/objectStore-required-arguments-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-storeNames-required-expected.txt:
1:54 AM Changeset in webkit [126561] by jhoneycutt@apple.com
  • 2 edits in branches/safari-536.26-branch/LayoutTests

2012-08-24 Jon Honeycutt <jhoneycutt@apple.com>

Update skipped list with changes merged from r121428. Patch by Mark
Lam. Unreviewed.

  • platform/wk2/Skipped:
1:51 AM Changeset in webkit [126560] by jhoneycutt@apple.com
  • 2 edits in branches/safari-536.26-branch/LayoutTests

2012-08-24 Jon Honeycutt <jhoneycutt@apple.com>

Update skipped list with changes merged from r121440. Patch by Mark
Lam. Unreviewed.

  • platform/mac-wk2/Skipped:
1:47 AM Changeset in webkit [126559] by jhoneycutt@apple.com
  • 1 edit
    8 adds in branches/safari-536.26-branch/LayoutTests

2012-08-24 Jon Honeycutt <jhoneycutt@apple.com>

Update test expectations with changes merged from r126219. Patch by
Mark Lam. Unreviewed.

  • platform/mac-lion/platform: Added.
  • platform/mac-lion/platform/mac-lion: Added.
  • platform/mac-lion/platform/mac-lion/platform: Added.
  • platform/mac-lion/platform/mac-lion/platform/mac: Added.
  • platform/mac-lion/platform/mac-lion/platform/mac/fast: Added.
  • platform/mac-lion/platform/mac-lion/platform/mac/fast/text: Added.
  • platform/mac-lion/platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Added.
  • platform/mac-lion/platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Added.
1:44 AM Changeset in webkit [126558] by Simon Hausmann
  • 5 edits in trunk/Source

Make it possible to build WebKit with Python 3 (and 2)
https://bugs.webkit.org/show_bug.cgi?id=94814

Source/WebCore:

Exceptions need a hack to work with both.
string.join was already deprecated in Python 2.
Relative imports are no longer supported, use package name instead.

Patch by Frederik Gladhorn <gladhorn@kde.org> on 2012-08-23
Reviewed by Ryosuke Niwa.

  • inspector/CodeGeneratorInspector.py:

(EnumConstants.get_enum_constant_code):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(Generator.go):
(Generator.process_event):
(Generator.process_command):

Source/WebKit2:

Patch by Frederik Gladhorn <gladhorn@kde.org> on 2012-08-23
Reviewed by Ryosuke Niwa.

Exceptions need a hack to work with both.
string.join was already deprecated in Python 2.
Relative imports are no longer supported, use package name instead.

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/parser.py:
1:43 AM Changeset in webkit [126557] by jhoneycutt@apple.com
  • 1 edit
    13 adds in branches/safari-536.26-branch/LayoutTests

2012-08-24 Jon Honeycutt <jhoneycutt@apple.com>

Update test expectations. Patch by Mark Lam. Unreviewed.

  • platform/mac-wk2/http/tests/loading: Added.
  • platform/mac-wk2/http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt: Added.
  • platform/mac-wk2/http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt: Added.
  • platform/mac-wk2/http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt: Added.
  • platform/mac-wk2/http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt: Added.
  • platform/mac-wk2/http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt: Added.
  • platform/mac-wk2/http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt: Added.
  • platform/mac/http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt: Added.
  • platform/mac/http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt: Added.
  • platform/mac/http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt: Added.
  • platform/mac/http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt: Added.
  • platform/mac/http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt: Added.
  • platform/mac/http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt: Added.
1:40 AM Changeset in webkit [126556] by allan.jensen@nokia.com
  • 4 edits in trunk/Source/WebCore

Get rid of m_useLatchedWheelEventNode
https://bugs.webkit.org/show_bug.cgi?id=94684

Reviewed by Ryosuke Niwa.

Moves the setting of m_useLatchedWheelEventNode into PlatformWheelEvent.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::handleGestureScrollCore):

  • page/EventHandler.h:
  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::setUseLatchedEventNode):
(PlatformWheelEvent):
(WebCore::PlatformWheelEvent::hasPreciseScrollingDeltas):
(WebCore::PlatformWheelEvent::useLatchedEventNode):

1:39 AM Changeset in webkit [126555] by jhoneycutt@apple.com
  • 2 edits in branches/safari-536.26-branch/LayoutTests

2012-08-24 Jon Honeycutt <jhoneycutt@apple.com>

Merge changes to test from r125162. Patch by Mark Lam.

  • fast/events/dom-character-data-modified-textarea-crash.html:
1:39 AM Changeset in webkit [126554] by yosin@chromium.org
  • 5 edits in trunk

[Forms] Multiple fields time input UI should handle Delete key as Backspace key
https://bugs.webkit.org/show_bug.cgi?id=94902

Reviewed by Kent Tamura.

Source/WebCore:

This patch adds treating "Delete" key as same as "Backspace" key for
multiple fields time input UI. This patch affects ports which enable
both ENABLE_INPUT_TYPE_TIME and ENABLES_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch adds a test case for "Delete" key to
fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler): Changed
condition expression to check both Backspace(U+0008) key and
Delete(U+007F) key.

LayoutTests:

This patch adds a new test case for "Delete" key behavior for multiple
fields time input UI.

  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Updated expectation.
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Added "Delete" key test case.
1:29 AM Changeset in webkit [126553] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after r126442. Skip a test because of missing shadow feature.

Patch by János Badics <János Badics> on 2012-08-24
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
12:57 AM Changeset in webkit [126552] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r126546.
http://trac.webkit.org/changeset/126546
https://bugs.webkit.org/show_bug.cgi?id=94911

Caused inspector tests to timeout (Requested by dominicc on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-24

  • WebCore.gypi:
  • inspector/compile-front-end.py:
  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/inspector.html:
12:45 AM Changeset in webkit [126551] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Purge unused favicons from IconDatabase after 30 days
https://bugs.webkit.org/show_bug.cgi?id=82346

Reviewed by Gustavo Noronha Silva.

Favicons will be removed from the icon database after not being used
for more than 30 days. This will keep the database size under
control.

  • loader/icon/IconDatabase.cpp:

(WebCore):
(WebCore::IconDatabase::performURLImport): filter icons older than
30 days.

12:40 AM Changeset in webkit [126550] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Narrow expected failures to Linux.

  • platform/chromium/TestExpectations:
12:38 AM Changeset in webkit [126549] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<http://webkit.org/b/94910> Copy the entire webkit2 module in to the WebKit2 framework wrapper.

Reviewed by Dan Bernstein.

This will allow relative imports within the webkit2 module to be removed in the future without
requiring future changes to clients of the module.

  • WebKit2.xcodeproj/project.pbxproj: Remove the webkit2 group from the project, and add it back

as a folder reference. This allows the directory and its contents to be copied in to the PrivateHeaders
directory. We also need to add a script phase to clean up any .pyc files that may be present in
the module.

Note: See TracTimeline for information about the timeline view.