Timeline
Sep 5, 2012:
- 11:49 PM WebKitGTK/1.10.x edited by
- (diff)
- 11:48 PM Changeset in webkit [127700] by
-
- 12 edits in trunk
Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
https://bugs.webkit.org/show_bug.cgi?id=93443
Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-05
Reviewed by Alexander Pavlov.
Source/WebCore:
Added "regionLayoutUpdate" event to the protocol.
Removed "getFlowByName" from protocol.
The front-end keeps in sync the requested Named Flow Collections.
Modified existing test: inspector/styles/protocol-css-regions-commands.html
- dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::reset):
(WebCore):
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::scheduleFor):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::regionLayoutUpdated):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):
- inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
LayoutTests:
Validate "regionLayoutUpdate" event.
- inspector/styles/protocol-css-regions-commands-expected.txt:
- inspector/styles/protocol-css-regions-commands.html:
- 11:26 PM Changeset in webkit [127699] by
-
- 7 edits1 add in trunk/Source
[chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
https://bugs.webkit.org/show_bug.cgi?id=95374
Reviewed by Adrienne Walker.
Source/WebCore:
The ubercomp layer will hold a RenderPass full of DrawQuads, and needs
to add quads to the current frame in appendQuads(). It will do this by
copying the quads it has in its RenderPass into the frame's RenderPass.
These methods allows it to make a clone of its quads.
Test: CCDrawQuadTest.copySharedQuadState
CCDrawQuadTest.copyCheckerboardDrawQuad
CCDrawQuadTest.copyDebugBorderDrawQuad
CCDrawQuadTest.copyIOSurfaceDrawQuad
CCDrawQuadTest.copyRenderPassDrawQuad
CCDrawQuadTest.copySolidColorDrawQuad
CCDrawQuadTest.copyStreamVideoDrawQuad
CCDrawQuadTest.copyTextureDrawQuad
CCDrawQuadTest.copyTileDrawQuadcopy
CCDrawQuadTest.copyYUVVideoDrawQuad
- platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::copy):
(WebCore):
- platform/graphics/chromium/cc/CCDrawQuad.h:
(CCDrawQuad):
- platform/graphics/chromium/cc/CCSharedQuadState.cpp:
(WebCore::CCSharedQuadState::copy):
(WebCore):
- platform/graphics/chromium/cc/CCSharedQuadState.h:
(CCSharedQuadState):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/CCDrawQuadTest.cpp: Added.
(TEST):
(createSharedQuadState):
(compareDrawQuad):
- 11:17 PM Changeset in webkit [127698] by
-
- 17 edits in trunk
Named functions should not allocate scope objects for their names
https://bugs.webkit.org/show_bug.cgi?id=95659
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
In most cases, we can merge a function expression's name into its symbol
table. This reduces memory footprint per closure from three objects
(function + activation + name scope) to two (function + activation),
speeds up closure allocation, and speeds up recursive calls.
In the case of a named function expression that contains a non-strict
eval, the rules are so bat-poop crazy that I don't know how to model
them without an extra object. Since functions now default to not having
such an object, this case needs to allocate the object on function
entry.
Therefore, this patch makes the slow case a bit slower so the fast case
can be faster and more memory-efficient. (Note that the slow case already
allocates an activation on entry, and until recently also allocated a
scope chain node on entry, so adding one allocation on entry shouldn't
break the bank.)
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock): Caught a missed initializer. No behavior change.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): Put the callee in static scope
during compilation so it doesn't need to be in dynamic scope at runtime.
(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::addCallee): Helper functions for either statically
resolving the callee or adding a dynamic scope that will resolve to it,
depending on whether you're in the fast path.
We move the callee into a var location if it's captured because activations
prefer to have contiguous ranges of captured variables.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::registerFor):
(BytecodeGenerator):
- dfg/DFGOperations.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL): This is the point of the patch: remove
one allocation in the case of a named function expression.
- parser/Parser.cpp:
(JSC::::Parser):
- parser/Parser.h:
(JSC::Scope::declareCallee):
(Scope):
(Parser):
(JSC::parse):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode): Pipe the callee's name through
the parser so we get accurate information on whether the callee was captured.
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode):
- runtime/Executable.h:
(JSC::FunctionExecutable::create):
(FunctionExecutable):
(JSC::FunctionExecutable::finishCreation): I had to refactor function
creation to support the following function constructor quirk: the function
gets a name, but its name is not in lexical scope.
To simplify this, FunctionExecutable now automatically extracts all the
data it needs from the parsed node. The special "fromGlobalCode" path
used by the function constructor creates an anonymous function, and then
quirkily sets the value used by the .name property to be non-null, even
though the parsed name is null.
- runtime/JSNameScope.h:
(JSC::JSNameScope::create):
(JSC::JSNameScope::JSNameScope): Added support for explicitly specifying
your container scope. The compiler uses this for named function expressions.
LayoutTests:
Added coverage for some extra-tricky cases.
- fast/js/named-function-expression-expected.txt:
- fast/js/script-tests/named-function-expression.js:
(shouldBeTrueWithDescription): I rolled my own shouldBeTrue() here to avoid the
built-in shouldBe()'s eval scoping, which can change the variable
resolution rules I'm trying to test.
- inspector/debugger/debugger-expand-scope-expected.txt: Not sure why this
result used to miss the function name scope, but the new result is a
progression, so I've updated the expected results.
- 11:06 PM Changeset in webkit [127697] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new fasiling tests.
- platform/qt-5.0-wk2/Skipped:
- platform/qt/Skipped:
- 10:57 PM Changeset in webkit [127696] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed; revert a change to ScrollingTreeNodeMac which accidentally
slipped into http://trac.webkit.org/changeset/127474.
This change will be properly landed shortly as part of
https://bugs.webkit.org/show_bug.cgi?id=93898.
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
- 10:51 PM Changeset in webkit [127695] by
-
- 11 edits in trunk/Source/WebCore
Remove duplicate error() impls in CachedResource subclasses
https://bugs.webkit.org/show_bug.cgi?id=81161
Reviewed by Antti Koivisto.
No new tests, refactor only.
- loader/cache/CachedCSSStyleSheet.cpp:
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedFont.h:
- loader/cache/CachedImage.cpp:
- loader/cache/CachedResource.h: Make checkNotify()
virtual, so the right checkNotify() gets called in error().
- loader/cache/CachedScript.cpp:
- loader/cache/CachedScript.h:
- loader/cache/CachedXSLStyleSheet.cpp:
- loader/cache/CachedXSLStyleSheet.h:
- 10:41 PM LineBreakingCSS3Mapping edited by
- Move section on migrating to unprefixed line-break. (diff)
- 10:41 PM LineBreaking edited by
- Move section on migrating to unprefixed line-break. (diff)
- 10:37 PM Changeset in webkit [127694] by
-
- 4 edits in trunk/LayoutTests
[Qt] platform/qt/plugins/qt-qwidget-plugin.html fails
https://bugs.webkit.org/show_bug.cgi?id=92141
Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-09-05
Reviewed by Simon Hausmann.
Only Qt WK2 does not support Qt plugins. Moving skip to proper place.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
Updated test to point to a existing image.
- platform/qt/plugins/qt-qwidget-plugin.html:
- 10:28 PM Changeset in webkit [127693] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed chromium windows build fix.
Some of the rules in webcore_remaining only apply to files under WebCore/platform/. Since r127687 moved all such
files from the webcore_files variable to webcore_platform_files, these rules have to be applied to
webcore_platform instead. This also means that these files link into webcore_platform instead of
webcore_remaining, which makes a lot more sense, and we can delete several redundant rules.
- WebCore.gyp/WebCore.gyp:
- 10:10 PM Changeset in webkit [127692] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening
- tests/GraphicsLayerChromiumTest.cpp:
(WebKit::TEST_F): Disabled applyScrollToScrollableArea()
- 10:06 PM Changeset in webkit [127691] by
-
- 4 edits in trunk
[chromium] Remove dependency on webkit_user_agent
https://bugs.webkit.org/show_bug.cgi?id=95886
Reviewed by Adam Barth.
Source/WebKit/chromium:
The code isn't used by webkit_unit_tests.
- WebKitUnitTests.gyp:
Tools:
The code isn't used by DumpRenderTree.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 9:48 PM Changeset in webkit [127690] by
-
- 4 edits in trunk/Source
Source/WebCore: [chromium] Some SubstituteData loads broken after r121912
https://bugs.webkit.org/show_bug.cgi?id=91685
Reviewed by Adam Barth.
Test: WebFrameTest.ReplaceNavigationAfterHistoryNavigation in chromium's webkit_unit_tests.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData): receivedFirstData() should be called exactly once per load,
on the first commit. I had mistakely assumed in r121912 that isReplacing() was true only for multipart
loads, and only after the first commit (chromium uses it for some SubstituteData loads to ensure the error page
replaces the failed load). We need to check whether we are loading multipart content before assuming isReplacing()
will tell us what we need to know.
Source/WebKit/chromium: Test for https://bugs.webkit.org/show_bug.cgi?id=91685
Reviewed by Adam Barth.
- tests/WebFrameTest.cpp:
- 9:46 PM Changeset in webkit [127689] by
-
- 7 edits in trunk
Source/WebKit/chromium: Use new type-specific WebGestureEvent fields
https://bugs.webkit.org/show_bug.cgi?id=95573
Patch by Rick Byers <rbyers@chromium.org> on 2012-09-05
Reviewed by James Robinson.
Chromium has been updated to store gesture-type specific details in the
new WebGestureEvent fields (crrev.com/152508, crrev.com/154815 and
crrev.com/154959), so we can now rely on them.
- src/WebCompositorInputHandlerImpl.cpp:
Update the compositor scroll, pinch and fling handling to use these new fields.
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
- src/WebInputEventConversion.cpp:
Update PlatformGestureEvent/WebGestureEvent conversion to use the new
fields, storing into the existing overloaded PlatformGestureEvent
fields (which will be cleaned up in my next CL).
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
Update fling scrolling implementation for correct location of velocity.
- tests/WebCompositorInputHandlerImplTest.cpp:
(WebKit::TEST_F):
Update tests to use the new fields.
Tools: Update chromium DumpRenderTree for new WebGestureEvent fields
https://bugs.webkit.org/show_bug.cgi?id=95573
Patch by Rick Byers <rbyers@chromium.org> on 2012-09-05
Reviewed by James Robinson.
Update EventSender to write gesture details into the appropriate
type-specific WebGestureEvent fields.
- DumpRenderTree/chromium/TestRunner/EventSender.cpp:
(EventSender::gestureEvent):
(EventSender::gestureFlingStart):
- 9:37 PM Changeset in webkit [127688] by
-
- 2 edits in trunk/Tools
NRWT lies about the number of tests that it's skipping when used with --repeat-each
https://bugs.webkit.org/show_bug.cgi?id=95789
Reviewed by Ojan Vafai.
Fix miscalculation in log message.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):
- 9:27 PM Changeset in webkit [127687] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
https://bugs.webkit.org/show_bug.cgi?id=95876
Reviewed by Tony Chang.
This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 8:58 PM Changeset in webkit [127686] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Implement missing feature to support <select> tag
https://bugs.webkit.org/show_bug.cgi?id=95708
Reviewed by Gyuyoung Kim.
Added missing APIs for select tag.
This patch provides all functionality of current WebPopupItem to applications.
- UIProcess/API/efl/ewk_popup_menu_item.cpp:
(_Ewk_Popup_Menu_Item):
(_Ewk_Popup_Menu_Item::_Ewk_Popup_Menu_Item):
(ewk_popup_menu_item_new):
(ewk_popup_menu_item_text_direction_get):
(ewk_popup_menu_item_text_direction_override_get):
(ewk_popup_menu_item_tooltip_get):
(ewk_popup_menu_item_accessibility_text_get):
(ewk_popup_menu_item_enabled_get):
(ewk_popup_menu_item_is_label_get):
(ewk_popup_menu_item_selected_get):
- UIProcess/API/efl/ewk_popup_menu_item.h:
- UIProcess/API/efl/ewk_popup_menu_item_private.h:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_popup_menu_request):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(checkBasicPopupMenuItem):
(showPopupMenu): Updated test case to cover new APIs.
(TEST_F):
- 8:54 PM Changeset in webkit [127685] by
-
- 3 edits3 adds in trunk
IndexedDB: Large integer versions not persisted correctly
https://bugs.webkit.org/show_bug.cgi?id=95873
Reviewed by Tony Chang.
Source/WebCore:
Correctly encode AND decode integer versions numbers as VarInts.
Test: storage/indexeddb/intversion-encoding.html
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::getVarInt):
(WebCore):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
LayoutTests:
Verify large integer versions that encode differently as Ints vs. VarInts.
- storage/indexeddb/intversion-encoding-expected.txt: Added.
- storage/indexeddb/intversion-encoding.html: Added.
- storage/indexeddb/resources/intversion-encoding.js: Added.
(test):
(openFirstTime.request.onupgradeneeded):
(openFirstTime.request.onsuccess):
(openFirstTime):
(openSecondTime.request.onsuccess):
(openSecondTime):
- 8:20 PM Changeset in webkit [127684] by
-
- 10 edits22 deletes in trunk
Unreviewed, rolling out r127596.
http://trac.webkit.org/changeset/127596
https://bugs.webkit.org/show_bug.cgi?id=95928
newly added tests are failing (Requested by bashi1 on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-05
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth):
- rendering/RenderRegion.cpp:
- rendering/RenderRegion.h:
(RenderRegion):
LayoutTests:
- fast/regions/autowidth-abspos-expected.html: Removed.
- fast/regions/autowidth-abspos-regionchain-expected.html: Removed.
- fast/regions/autowidth-abspos-regionchain.html: Removed.
- fast/regions/autowidth-abspos.html: Removed.
- fast/regions/autowidth-float-expected.html: Removed.
- fast/regions/autowidth-float.html: Removed.
- fast/regions/autowidth-inlineblock-expected.html: Removed.
- fast/regions/autowidth-inlineblock.html: Removed.
- fast/regions/autowidth-nonreplaced-abspos-expected.html: Removed.
- fast/regions/autowidth-nonreplaced-abspos.html: Removed.
- fast/regions/autowidth-nonreplacedblock-normalflow-expected.html: Removed.
- fast/regions/autowidth-nonreplacedblock-normalflow.html: Removed.
- fast/regions/autowidth-normalflow-expected.html: Removed.
- fast/regions/autowidth-normalflow-maxwidth-expected.html: Removed.
- fast/regions/autowidth-normalflow-maxwidth.html: Removed.
- fast/regions/autowidth-normalflow-minmaxwidth-expected.html: Removed.
- fast/regions/autowidth-normalflow-minmaxwidth.html: Removed.
- fast/regions/autowidth-normalflow-minwidth-expected.html: Removed.
- fast/regions/autowidth-normalflow-minwidth.html: Removed.
- fast/regions/autowidth-normalflow-vertrl-expected.html: Removed.
- fast/regions/autowidth-normalflow-vertrl.html: Removed.
- fast/regions/autowidth-normalflow.html: Removed.
- fast/regions/bottom-overflow-out-of-first-region.html:
- fast/regions/flows-dependency-dynamic-remove.html:
- fast/regions/flows-dependency-same-flow.html:
- fast/regions/render-region-renderer-expected.html:
- fast/regions/top-overflow-out-of-second-region.html:
- 8:14 PM Changeset in webkit [127683] by
-
- 2 edits in trunk/Source/WebCore
Build failure with accelerated compositing disabled
https://bugs.webkit.org/show_bug.cgi?id=95872
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-09-05
Reviewed by James Robinson.
Define DrawingBuffer::markContextChanged even when accelerated
compositing is not used.
No functional change, so no new tests.
- platform/graphics/gpu/DrawingBuffer.h:
(WebCore::DrawingBuffer::markContentsChanged):
(DrawingBuffer):
- 7:54 PM Changeset in webkit [127682] by
-
- 16 edits2 adds in trunk
Parse the array() function for custom filters
https://bugs.webkit.org/show_bug.cgi?id=94226
Reviewed by Dirk Schulze.
Source/WebCore:
The patch adds the support for the array() function parsing;
according to the specs this function - to be used within custom
filters - accepts number (float) values. This patch parses array()
arguments using comma as separator: the spec will be updated
accordingly shortly.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseCustomFilterArrayFunction): New method to
parse the content of array() function.
(WebCore):
(WebCore::CSSParser::parseCustomFilter): parseCustomFilterArrayFunction is
called whenever a "array(" function is encountered.
- css/CSSParser.h:
(WebCore):
- css/CSSValue.cpp:
(WebCore::CSSValue::reportMemoryUsage):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
- css/CSSValue.h:
(WebCore::CSSValue::isWebKitCSSArrayFunctionValue):
- css/WebKitCSSArrayFunctionValue.cpp: Added.
(WebCore):
(WebCore::WebKitCSSArrayFunctionValue::WebKitCSSArrayFunctionValue):
(WebCore::WebKitCSSArrayFunctionValue::customCssText):
(WebCore::WebKitCSSArrayFunctionValue::cloneForCSSOM):
(WebCore::WebKitCSSArrayFunctionValue::reportDescendantMemoryUsage):
- css/WebKitCSSArrayFunctionValue.h: Added.
(WebCore):
(WebKitCSSArrayFunctionValue):
(WebCore::WebKitCSSArrayFunctionValue::create):
LayoutTests:
New negative and positive test cases have been added for the array()
function parsing.
Also a new test case has been added to further test multiple 3d-transforms.
- css3/filters/custom/custom-filter-property-parsing-expected.txt:
- css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
- css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
- css3/filters/script-tests/custom-filter-property-parsing.js:
- platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:
- 7:24 PM Changeset in webkit [127681] by
-
- 13 edits2 copies2 adds in trunk
Vertically center non-anchored <dialog> elements
https://bugs.webkit.org/show_bug.cgi?id=90670
Patch by Matt Falkenhagen <falken@chromium.org> on 2012-09-05
Reviewed by Ojan Vafai.
Source/WebCore:
This adjusts the static default position of non-anchored
dialog elements so they are vertically centered in or at the top of
the viewport, as per the spec.
The approach is to add a RenderDialog class whose layout()
function adjusts the position after normal RenderBlock::layout runs.
Test: fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::createRenderer):
(WebCore):
- html/HTMLDialogElement.h:
(HTMLDialogElement):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::mapAbsoluteToLocalPoint): Remove assertion since now absoluteToLocal is called during layout.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint): Ditto.
- rendering/RenderDialog.cpp: Added.
(WebCore):
(WebCore::RenderDialog::layout): Compute the desired top position in the absolute coordinate system, and then set top to the
corresponding local coordinate.
- rendering/RenderDialog.h: Added.
(WebCore):
(RenderDialog):
(WebCore::RenderDialog::RenderDialog):
(WebCore::RenderDialog::~RenderDialog):
(WebCore::RenderDialog::renderName):
- rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::isDialog):
- rendering/RenderingAllInOne.cpp:
LayoutTests:
- fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt: Added.
- fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html: Added.
- 7:12 PM Changeset in webkit [127680] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove feature about:cache/disable and about:cache/enable
https://bugs.webkit.org/show_bug.cgi?id=95820
Reviewed by Rob Buis.
Remove this feature since we need to add a button in settings.
- WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::cachePage):
- 7:11 PM Changeset in webkit [127679] by
-
- 25 edits9 deletes in trunk
Unreviewed, rolling out r127612, r127660, and r127664.
http://trac.webkit.org/changeset/127612
http://trac.webkit.org/changeset/127660
http://trac.webkit.org/changeset/127664
https://bugs.webkit.org/show_bug.cgi?id=95920
Source/Platform:
- Platform.gypi:
- chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
- chromium/public/WebRTCVoidRequest.h: Removed.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/RTCErrorCallback.h:
(WebCore):
(RTCErrorCallback):
- Modules/mediastream/RTCErrorCallback.idl:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createOffer):
- Modules/mediastream/RTCPeerConnection.h:
(WebCore):
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCSessionDescriptionCallback.h:
(WebCore):
(RTCSessionDescriptionCallback):
- Modules/mediastream/RTCSessionDescriptionCallback.idl:
- Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:
(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::clear):
- Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
(RTCSessionDescriptionRequestImpl):
- Modules/mediastream/RTCVoidRequestImpl.cpp: Removed.
- Modules/mediastream/RTCVoidRequestImpl.h: Removed.
- WebCore.gypi:
- platform/chromium/support/WebRTCVoidRequest.cpp: Removed.
- platform/mediastream/RTCPeerConnectionHandler.cpp:
(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::RTCPeerConnectionHandlerDummy):
- platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(WebCore::RTCPeerConnectionHandler::~RTCPeerConnectionHandler):
(RTCPeerConnectionHandler):
(WebCore::RTCPeerConnectionHandler::RTCPeerConnectionHandler):
- platform/mediastream/RTCVoidRequest.h: Removed.
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):
Tools:
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::createOffer):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):
(SuccessCallbackTask):
(FailureCallbackTask):
LayoutTests:
- fast/mediastream/RTCPeerConnection-createOffer.html:
- fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Removed.
- fast/mediastream/RTCPeerConnection-localDescription.html: Removed.
- fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Removed.
- fast/mediastream/RTCPeerConnection-remoteDescription.html: Removed.
- 7:07 PM Changeset in webkit [127678] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
https://bugs.webkit.org/show_bug.cgi?id=95819
Patch by James Robinson <jamesr@chromium.org> on 2012-09-05
Reviewed by Adam Barth.
This unit test doesn't do all that much, but it does verify that WebSolidColorLayer doesn't completely explode
upon use and also makes sure that the WebSolidColorLayer::create() symbol is referenced and not dropped from
webkit.dll in the component build.
- tests/WebLayerTest.cpp:
- 7:03 PM Changeset in webkit [127677] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove deprecated dialog connections.
https://bugs.webkit.org/show_bug.cgi?id=95868
Reviewed by Rob Buis.
PR 187481.
Remove deprecated logic for unsupported
Dialog types.
- Api/WebPageClient.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::openColorPopup):
- 7:02 PM Changeset in webkit [127676] by
-
- 3 edits3 adds in trunk
a = data[a]++; sets the wrong key in data
https://bugs.webkit.org/show_bug.cgi?id=91270
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Postfix inc/dec is unsafely using finalDestination, can trample base/subscript prior to the result being put.
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
- Remove redundant parens.
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
- Refactored to use tempDestination instead of finalDestination.
(JSC::PrefixNode::emitBracket):
(JSC::PrefixNode::emitDot):
- Should be using emitPreIncOrDec.
LayoutTests:
Added test cases.
- fast/js/post-inc-assign-overwrites-expected.txt: Added.
- fast/js/post-inc-assign-overwrites.html: Added.
- fast/js/script-tests/post-inc-assign-overwrites.js: Added.
(postIncDotAssignToBase):
(postIncBracketAssignToBase):
(postIncBracketAssignToSubscript):
- 6:58 PM Changeset in webkit [127675] by
-
- 13 edits2 adds in trunk
Add the duration attribute to MediaSource
https://bugs.webkit.org/show_bug.cgi?id=95149
Reviewed by Eric Carlson.
Add support for the duration attribute recently added to the MediaSource spec.
http://dev.w3.org/html5/spec/media-elements.html#dom-media-duration
Source/WebCore:
Test: http/tests/media/media-source/video-media-source-duration-changed.html
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::duration): Added duration method.
(WebCore):
(WebCore::MediaSource::setDuration): Added duration setter.
- Modules/mediasource/MediaSource.h:
(MediaSource):
- Modules/mediasource/MediaSource.idl:
- platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::sourceSetDuration): Add empty definition.
(WebCore::MediaPlayer::sourceSetDuration): Forward call to m_private.
(WebCore):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::sourceSetDuration): Add empty definition.
Source/WebKit/chromium:
- public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::sourceSetDuration): Add empty definition.
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::sourceSetDuration): Forward call to m_webMediaPlayer.
(WebKit):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
LayoutTests:
- http/tests/media/media-source/media-source.js:
(MediaSourceTest.SegmentHelper): Add parameter to specify whether full file should be loaded.
(MediaSourceTest.SegmentHelper.prototype.appendAllMediaSegments): Added method to append all file segments.
(MediaSourceTest.roundedEquals_): Added to see if values are equivalent after rounding.
(MediaSourceTest.expectDuration): Added to check for expected duration.
(MediaSourceTest.expectBufferedRange): Added to check for the expected buffered attribute value.
- http/tests/media/media-source/video-media-source-duration-changed-expected.txt: Added.
- http/tests/media/media-source/video-media-source-duration-changed.html: Added.
- 6:32 PM Changeset in webkit [127674] by
-
- 7 edits in trunk/Source
[Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime
https://bugs.webkit.org/show_bug.cgi?id=95865
Reviewed by Darin Fisher.
Source/WebCore:
r55549 made them be runtime-enabled (since the Chromium implementation
was not complete at the time), but they've been enabled by default
since http://crrev.com/41850
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
- page/History.idl:
Source/WebKit/chromium:
Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into
no-ops.
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enablePushState):
(WebKit::WebRuntimeFeatures::isPushStateEnabled):
- 6:31 PM Changeset in webkit [127673] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] unreviewed gardening after r127564
Added missing text expectation.
- fast/forms/datetime/datetime-interactive-validation-required-expected.txt: Added.
- 6:16 PM Changeset in webkit [127672] by
-
- 8 edits in trunk/Source
[chromium] Move static WebCompositor functions to WebCompositorSupport
https://bugs.webkit.org/show_bug.cgi?id=95785
Reviewed by Darin Fisher.
The statics on WebCompositor need to be moved to WebCompositorSupport so the embedder can inject an
implementation for these via PlatformSupport. This adds the interface for the statics to WebCompositorSupport.
After an implementation of these lands on the chromium side, I'll switch all callers over to use these and
remove the WebCompositor interface from the API.
- chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
(WebKit::WebCompositorSupport::initialize):
(WebKit::WebCompositorSupport::threadingEnabled):
(WebKit::WebCompositorSupport::shutdown):
(WebKit::WebCompositorSupport::setPerTilePaintingEnabled):
(WebKit::WebCompositorSupport::setPartialSwapEnabled):
(WebKit::WebCompositorSupport::setAcceleratedAnimationEnabled):
- 6:16 PM Changeset in webkit [127671] by
-
- 2 edits in trunk
[BlackBerry] Match th ebuild flags from the platform library
https://bugs.webkit.org/show_bug.cgi?id=95423
Reviewed by Antonio Gomes.
Unaligned build flags can cause crashes and other strange behavior.
These two were not defined here but were defined on the system.
- Source/cmake/OptionsBlackBerry.cmake:
- 6:11 PM Changeset in webkit [127670] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Assignment operators missing self-check
https://bugs.webkit.org/show_bug.cgi?id=95774
Reviewed by Rob Buis.
Add a test for self-assignment.
- Api/WebAnimation.cpp:
(BlackBerry::WebKit::WebAnimation::operator=):
- Api/WebString.cpp:
(BlackBerry::WebKit::WebString::operator=):
- 6:07 PM Changeset in webkit [127669] by
-
- 3 edits3 adds in trunk
IndexedDB: Integer version lost after first open/close/open cycle
https://bugs.webkit.org/show_bug.cgi?id=95864
Reviewed by Tony Chang.
Source/WebCore:
New backing stores were being created with an old schema version, causing migration
to occur when the backing store was re-opened, which would overwrite valid integer
version metadata. New backing stores should be created with the latest schema version
since no migration is desired.
Test: storage/indexeddb/intversion-persistence.html
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::setUpMetadata):
LayoutTests:
Ensure integer versions are persisted across open/close/open cycles.
Note that although this is a useful and valid test in general, the specific bug that
prompted adding this test will only repro if the origin has no pre-existing backing
store, which is not guaranteed by DRT or other shells. See http://webkit.org/b/92166
- storage/indexeddb/intversion-persistence-expected.txt: Added.
- storage/indexeddb/intversion-persistence.html: Added.
- storage/indexeddb/resources/intversion-persistence.js: Added.
(test):
(openFirstTime.request.onupgradeneeded):
(openFirstTime.request.onsuccess):
(openFirstTime):
(openSecondTime.request.onsuccess):
(openSecondTime):
- 6:01 PM Changeset in webkit [127668] by
-
- 1 edit2 adds in trunk/LayoutTests
[Tests] We should have mouse events test for multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=95829
Reviewed by Kent Tamura.
This patch adds test cases of mouse actions on multiple fields time
input UI.
The test checks:
- Mouse click to set focus to field under mouse pointer
- Mouse click on spin button
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
- fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html: Added.
- 6:00 PM Changeset in webkit [127667] by
-
- 2 edits in trunk/LayoutTests
[Chromium] unreviewed test expectation update
- platform/chromium/TestExpectations:
- 5:55 PM Changeset in webkit [127666] by
-
- 4 edits3 adds in trunk
Bug, assignment within subscript of prefix/postfix increment of bracket access
https://bugs.webkit.org/show_bug.cgi?id=95913
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
javascript:alert((function(){ var a = { x:1 }; var b = { x:1 }; a[a=b,"x"]++; return a.x; })())
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitBracket):
(JSC::PrefixNode::emitBracket):
- Should check for assigments in the subscript when loading the base.
- parser/Nodes.h:
(JSC::BracketAccessorNode::subscriptHasAssignments):
(BracketAccessorNode):
- Used by emitBracket methods.
LayoutTests:
Added test cases.
- fast/js/inc-bracket-assign-subscript-expected.txt: Added.
- fast/js/inc-bracket-assign-subscript.html: Added.
- fast/js/script-tests/inc-bracket-assign-subscript.js: Added.
(testPreIncBracketAccessWithAssignSubscript):
(testPostIncBracketAccessWithAssignSubscript):
- Tests a pre/post increment to a bracket access, where subscript contains assignment.
- 5:52 PM Changeset in webkit [127665] by
-
- 1 delete in tags/Safari-536.26.14
Remove Tag.
- 5:19 PM Changeset in webkit [127664] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Unreviewed, build fix attempt after r127660
Make clang happy.
- platform/mediastream/RTCPeerConnectionHandler.cpp:
(WebCore::RTCPeerConnectionHandlerDummy::RTCPeerConnectionHandlerDummy):
Use ASSERT_UNUSED() to suppress -Wunused-private-field warning
- 5:18 PM Changeset in webkit [127663] by
-
- 1 copy in tags/Safari-536.26.14
New Tag.
- 5:12 PM Changeset in webkit [127662] by
-
- 1 edit1 move in trunk/LayoutTests
Renamed a misnamed expected result.
- platform/mac/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Copied from LayoutTests/platform/mac/compositing/overflow/overflow-with-touch-toggle-expected.txt.
- platform/mac/compositing/overflow/overflow-with-touch-toggle-expected.txt: Removed.
- 4:53 PM Changeset in webkit [127661] by
-
- 2 edits in trunk/Source/WebCore
Build fix for Windows.
- rendering/RenderThemeWin.cpp: Added missing header include.
- 4:34 PM Changeset in webkit [127660] by
-
- 4 edits in trunk/Source/WebCore
[Chromium] Unreviewed, build fix attempt on win
r127612 breaks chromium win build.
- WebCore.gypi:
- platform/mediastream/RTCPeerConnectionHandler.cpp:
(WebCore::RTCPeerConnectionHandler::RTCPeerConnectionHandler):
(WebCore):
(WebCore::RTCPeerConnectionHandler::~RTCPeerConnectionHandler):
- platform/mediastream/RTCPeerConnectionHandler.h:
(RTCPeerConnectionHandler):
- 4:12 PM Changeset in webkit [127659] by
-
- 2 edits2 copies in branches/chromium/1229
Merge 126251
BUG=137413
Review URL: https://chromiumcodereview.appspot.com/10909089
- 4:10 PM Changeset in webkit [127658] by
-
- 2 edits in branches/chromium/1229/Source/WebCore/rendering
Merge 126107
BUG=137413
Review URL: https://chromiumcodereview.appspot.com/10916130
- 4:08 PM Changeset in webkit [127657] by
-
- 10 edits in branches/chromium/1229/Source/WebCore/rendering
Merge 126048
BUG=137413
Review URL: https://chromiumcodereview.appspot.com/10911116
- 4:05 PM Changeset in webkit [127656] by
-
- 9 edits in branches/chromium/1229/Source/WebCore/rendering
Merge 125737
BUG=137413
Review URL: https://chromiumcodereview.appspot.com/10914111
- 4:04 PM Changeset in webkit [127655] by
-
- 9 edits1 move1 delete in trunk
[EFL][WK2] Provide implementation for WebProcess functions
https://bugs.webkit.org/show_bug.cgi?id=95857
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Add implementation for getVolumeFreeSizeForPath()
in FileSystem which is required by soup-related
code in WebKit2.
No new tests, no behavior change.
- platform/FileSystem.h:
(WebCore):
- platform/efl/FileSystemEfl.cpp:
(WebCore::getVolumeFreeSizeForPath):
(WebCore):
Source/WebKit2:
Rename WebProcessGtk to WebProcessSoup and reuse it in
EFL port since all the code is soup-related. We now
have a proper implementation for the WebProcess
platform methods.
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- WebProcess/efl/WebProcessEfl.cpp: Removed.
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl): Enable soup cache for the soup session similarly to GTK port.
- WebProcess/soup/WebProcessSoup.cpp: Renamed from Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp.
(WebKit):
(WebKit::getCacheDiskFreeSize):
(WebKit::getMemorySize):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformClearResourceCaches):
(WebKit::buildAcceptLanguages):
(WebKit::setSoupSessionAcceptLanguage):
(WebKit::languageChanged):
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):
LayoutTests:
Unskip several test cases that are now passing on
WK2 EFL since WebProcess platform functions have been
implemented.
- platform/efl-wk2/TestExpectations:
- 4:00 PM Changeset in webkit [127654] by
-
- 5 edits in trunk/Source/JavaScriptCore
Merge prefix/postfix nodes
https://bugs.webkit.org/show_bug.cgi?id=95898
Reviewed by Geoff Garen.
Simplify the AST.
This will also mean we have access to m_subscriptHasAssignments when generating a prefix/postfix op applied to a bracket access.
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
- was PostfixResolveNode::emitBytecode
(JSC::PostfixNode::emitBracket):
- was PostfixBracketNode::emitBytecode
(JSC::PostfixNode::emitDot):
- was PostfixDotNode::emitBytecode
(JSC::PostfixNode::emitBytecode):
- was PostfixErrorNode::emitBytecode, call resolve/bracket/dot version as appropriate.
(JSC::PrefixNode::emitResolve):
- was PrefixResolveNode::emitBytecode
(JSC::PrefixNode::emitBracket):
- was PrefixBracketNode::emitBytecode
(JSC::PrefixNode::emitDot):
- was PrefixDotNode::emitBytecode
(JSC::PrefixNode::emitBytecode):
- was PrefixErrorNode::emitBytecode, call resolve/bracket/dot version as appropriate.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::makePrefixNode):
- Just makes a PrefixNode!
(JSC::ASTBuilder::makePostfixNode):
- Just makes a PostfixNode!
- parser/NodeConstructors.h:
(JSC::PostfixNode::PostfixNode):
- Added, merge of PostfixResolveNode/PostfixBracketNode/PostfixDotNode/PostfixErrorNode.
(JSC::PrefixNode::PrefixNode):
- Added, merge of PrefixResolveNode/PrefixBracketNode/PrefixDotNode/PrefixErrorNode.
- parser/Nodes.h:
(PostfixNode):
- Added, merge of PostfixResolveNode/PostfixBracketNode/PostfixDotNode/PostfixErrorNode.
(PrefixNode):
- Added, merge of PrefixResolveNode/PrefixBracketNode/PrefixDotNode/PrefixErrorNode.
- 3:55 PM Changeset in webkit [127653] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r127635.
http://trac.webkit.org/changeset/127635
https://bugs.webkit.org/show_bug.cgi?id=95905
breaks chromium win and mac build (Requested by bashi1 on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-05
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 3:33 PM Changeset in webkit [127652] by
-
- 5 edits in branches/chromium/1229/Source
Merge 126609
BUG=144704
Review URL: https://chromiumcodereview.appspot.com/10907083
- 3:26 PM Changeset in webkit [127651] by
-
- 1 edit3 deletes in branches/chromium/1229
Revert 122501 - Percentage width replaced element in zero percent/fixed width container block incorrectly rendered.
https://bugs.webkit.org/show_bug.cgi?id=9493
Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-12
Reviewed by Andy Estes.
Source/WebCore:
When the width of the container is zero percent/fixed value then the width of the replaced element must also be zero.
Test: fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
When the containing block's available width is zero there can be two cases.
The containing block is floated/positioned in which case the width of the replaced child element must be its instrinsic width.
On the other hand if the width of the container is specified to be either zero percent or fixed value then the width of the
replaced elment must be zero.
LayoutTests:
- fast/css/percent-width-img-inside-zero-percent-and-fixed-container-expected.html: Added.
- fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html: Added.
- fast/css/resources/red-box.png: Added. Image resource file for the test case.
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10918085
- 3:02 PM Changeset in webkit [127650] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Optimize BackingStorePrivate::isCurrentVisibleJob
https://bugs.webkit.org/show_bug.cgi?id=95897
Reviewed by Antonio Gomes.
Bail out the loop early if one of the not-rendered rectangle is
not current regular render job.
No behavior change, just code optimization.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
- 2:50 PM Changeset in webkit [127649] by
-
- 2 edits in trunk/Source/WebCore
Make RenderStyle::colorIncludingFallback use private getters
https://bugs.webkit.org/show_bug.cgi?id=95863
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-09-05
Reviewed by Eric Seidel.
For readibility and maintanability reasons, it is better to use getters for
visited* color variables than accessing them directly.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::colorIncludingFallback):
- 2:46 PM Changeset in webkit [127648] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove use of JSCell::classInfoOffset() from tryCacheGetByID
https://bugs.webkit.org/show_bug.cgi?id=95860
Reviewed by Oliver Hunt.
We should just do the indirection through the Structure instead.
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
- 2:44 PM Changeset in webkit [127647] by
-
- 4 edits in trunk/Source/JavaScriptCore
Throw exceptions when assigning to const in strict mode
https://bugs.webkit.org/show_bug.cgi?id=95894
Reviewed by Oliver Hunt.
Currently, this never happens; but it will start happening once the
callee is a local const register. In this patch, there's no change in
behavior.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded): Helper function
for doing the throwing.
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode): Call the helper function.
- 2:12 PM Changeset in webkit [127646] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Some flaky http/tests/security tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95803
- platform/win/Skipped:
- 2:01 PM Changeset in webkit [127645] by
-
- 1 edit1 add in trunk/LayoutTests
Added expected results for this test from r127620 for the Mac port, which does not have
OVERFLOW_SCROLLING enabled at this time.
- platform/mac/compositing/overflow/overflow-with-touch-toggle-expected.txt: Added.
- 1:58 PM Changeset in webkit [127644] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] JavaScriptVariant can crash when operator= is called with itself
https://bugs.webkit.org/show_bug.cgi?id=95859
Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-09-05
Reviewed by George Staikos.
- Api/JavaScriptVariant.cpp:
(BlackBerry::WebKit::JavaScriptVariant::operator=):
When JavaScriptVariant contains a string and operator= is
called with itself the memory will be free'd in 'this' and
then a copy will be attempted from 'that' resulting in a crash.
- 1:50 PM Changeset in webkit [127643] by
-
- 2 edits in trunk/Source/JavaScriptCore
Refactored callee access in the DFG to support it in the general case
https://bugs.webkit.org/show_bug.cgi?id=95887
Reviewed by Phil Pizlo and Gavin Barraclough.
To support named function expressions, the DFG needs to understand the
callee register being used in arbitrary expressions, and not just
create_this.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::getCallee): Remap access to the callee register
into a GetCallee node. Otherwise, we get confused and think we have a
negatively indexed argument.
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand): Inlining also
needs to remap, but to the callee in the inline frame, and not the caller's
callee.
(JSC::DFG::ByteCodeParser::parseBlock): Since we support the callee in
the general case now, there's no need to handle it in a special way for
create_this.
- 1:48 PM Changeset in webkit [127642] by
-
- 3 edits in trunk/Tools
Ignore-metrics includes scroll offsets.
https://bugs.webkit.org/show_bug.cgi?id=95845
Reviewed by Dirk Pranke.
Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
- Scripts/old-run-webkit-tests:
(stripMetrics):
- Scripts/webkitpy/layout_tests/port/driver.py:
(DriverOutput):
- 1:43 PM Changeset in webkit [127641] by
-
- 3 edits4 copies in branches/chromium/1229
Merge 125162
BUG=139530
Review URL: https://chromiumcodereview.appspot.com/10916125
- 1:40 PM Changeset in webkit [127640] by
-
- 9 edits2 copies in branches/chromium/1229
Merge 125147
BUG=139530
Review URL: https://chromiumcodereview.appspot.com/10917095
- 1:31 PM Changeset in webkit [127639] by
-
- 9 edits in trunk/Source
More fixes for String::operator+=() on Mac
https://bugs.webkit.org/show_bug.cgi?id=95880
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-05
Reviewed by Adam Barth.
Source/WebCore:
Followup for r127574, I forgot some use of strings.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue): Use String builder to construct the shorthand.
Source/WebKit/mac:
- WebView/WebRenderLayer.mm:
(+[WebRenderLayer nameForLayer:]): Use StringBuilder to concatenate the class names
efficiently.
- WebView/WebView.mm:
(+[WebView _decodeData:]): This is a legitimate use of String::append(), there
is no other concatenation done on that string.
Source/WebKit2:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage): This is a legitimate use of append(),
there is no other concatenation outside that branch.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::parseRFC822HeaderFields): Use string operators instead of +=.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::userAgent): Another legitimate use of append().
- 1:28 PM Changeset in webkit [127638] by
-
- 1 edit in branches/chromium/1229/Source/WebCore/platform/graphics/skia/OpaqueRegionSkia.cpp
Merge 126901
BUG=144899
Review URL: https://chromiumcodereview.appspot.com/10913094
- 12:52 PM Changeset in webkit [127637] by
-
- 1 edit2 copies in branches/chromium/1229
Merge 126657
BUG=143604
Review URL: https://chromiumcodereview.appspot.com/10911109
- 12:47 PM Changeset in webkit [127636] by
-
- 1 edit4 copies in branches/chromium/1229
Merge 127082
BUG=144671
Review URL: https://chromiumcodereview.appspot.com/10908101
- 12:46 PM Changeset in webkit [127635] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
https://bugs.webkit.org/show_bug.cgi?id=95876
Reviewed by Tony Chang.
This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 12:41 PM Changeset in webkit [127634] by
-
- 1 edit2 copies in branches/chromium/1229
Merge 126063
BUG=140484
Review URL: https://chromiumcodereview.appspot.com/10928003
- 12:37 PM Changeset in webkit [127633] by
-
- 10 edits in branches/chromium/1229/Source
Merge 125500
BUG=137852
Review URL: https://chromiumcodereview.appspot.com/10905105
- 12:35 PM Changeset in webkit [127632] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r127629.
http://trac.webkit.org/changeset/127629
https://bugs.webkit.org/show_bug.cgi?id=95876
Broke build
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 12:29 PM Changeset in webkit [127631] by
-
- 1 edit2 copies in branches/chromium/1229
Merge 125343
BUG=131815
Review URL: https://chromiumcodereview.appspot.com/10913091
- 12:27 PM Changeset in webkit [127630] by
-
- 1 edit2 copies in branches/chromium/1229
Merge 127117
BUG=143609
Review URL: https://chromiumcodereview.appspot.com/10909084
- 12:20 PM Changeset in webkit [127629] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
https://bugs.webkit.org/show_bug.cgi?id=95876
Reviewed by Tony Chang.
This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 12:17 PM Changeset in webkit [127628] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Rotation and then reload causes less sized webpage (PR 190469)
https://bugs.webkit.org/show_bug.cgi?id=95870
Reviewed by George Staikos.
Reviewed internally by Jacky Jiang.
Use the new zoom to fit scale if the page was zoomed to fit initial scale
When a page is reloaded the layout size may be changed. So the contents
size on which the initial scale depends may be changed. Use the new initial
scale in this case to make sure the page will be zoomed to correct scale.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- 12:15 PM Changeset in webkit [127627] by
-
- 3 edits2 copies in branches/chromium/1229
Merge 125635
BUG=137052
Review URL: https://chromiumcodereview.appspot.com/10915102
- 12:14 PM Changeset in webkit [127626] by
-
- 3 edits2 adds in trunk
[EFL] Slider progress bar goes crazy with negative ranges
https://bugs.webkit.org/show_bug.cgi?id=95753
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Now the calculation of what the current value represents in terms
of progress (from 0 to 1) is correctly done.
Test: fast/forms/range/input-range-progress-indicator.html
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
LayoutTests:
Added ref test to check if rendering results of sliders using
negative value ranges are coherent.
- fast/forms/range/input-range-progress-indicator-expected.html: Added.
- fast/forms/range/input-range-progress-indicator.html: Added.
- 12:07 PM Changeset in webkit [127625] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove use of JSCell::classInfoOffset() from virtualForThunkGenerator
https://bugs.webkit.org/show_bug.cgi?id=95821
Reviewed by Oliver Hunt.
We can replace the load of the ClassInfo from the object with a load from the Structure.
- dfg/DFGThunks.cpp:
(JSC::DFG::virtualForThunkGenerator):
- 12:06 PM Changeset in webkit [127624] by
-
- 4 edits2 copies in branches/chromium/1229
Merge 125476
BUG=135173
Review URL: https://chromiumcodereview.appspot.com/10919103
- 12:04 PM Changeset in webkit [127623] by
-
- 10 edits2 copies in trunk/Source
[Chromium] Remove getRenderStyleForStrike from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=95363
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/Platform:
- Platform.gypi:
- chromium/public/linux/WebFontInfo.h: Added.
(WebKit):
(WebFontInfo):
- chromium/public/linux/WebFontRenderStyle.h: Added.
(WebKit):
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::getRenderStyleForStrike):
(WebCore):
(WebCore::FontPlatformData::querySystemForRenderStyle):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):
Source/WebKit/chromium:
- public/linux/WebFontInfo.h:
- public/linux/WebFontRenderStyle.h:
- src/PlatformSupport.cpp:
(WebCore):
- 12:03 PM Changeset in webkit [127622] by
-
- 4 edits2 copies in branches/chromium/1229
Merge 125448
BUG=135173
Review URL: https://chromiumcodereview.appspot.com/10911108
- 11:54 AM Changeset in webkit [127621] by
-
- 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore
Merge r126551 - [GTK] Purge unused favicons from IconDatabase after 30 days
https://bugs.webkit.org/show_bug.cgi?id=82346
Reviewed by Gustavo Noronha Silva.
Favicons will be removed from the icon database after not being used
for more than 30 days. This will keep the database size under
control.
- loader/icon/IconDatabase.cpp:
(WebCore):
(WebCore::IconDatabase::performURLImport): filter icons older than
30 days.
- 11:54 AM WebKitGTK/1.10.x edited by
- (diff)
- 11:53 AM Changeset in webkit [127620] by
-
- 4 edits2 adds in trunk
Enable/disable composited scrolling based on overflow
https://bugs.webkit.org/show_bug.cgi?id=95323
Patch by Sami Kyostila <skyostil@google.com> on 2012-09-05
Reviewed by Simon Fraser.
Source/WebCore:
When an overflow:{auto,overlay} and -webkit-overflow-scrolling:touch
element gains or loses overflow, we should correspondingly enable and
disable composited scrolling depending on whether the element can be
scrolled or not.
The previous logic in RenderLayer::usesCompositedScrolling() already
checked for actual overflow, but we also need to recompute the
compositing requirements when the amount of overflow changes during
layout. Additionally, layers using composited scrolling are marked as
self-painting to ensure they are always promoted to composited layers
when needed.
Test: compositing/overflow/overflow-auto-with-touch-toggle.html
Note that the behavior for maintaining a stacking context even without
the presense of overflow is covered by platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
LayoutTests:
Added a new test for making sure composited scrolling is enabled when overflow
is introduced.
Note that this test will pass only if OVERFLOW_SCROLLING is enabled.
- compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Added.
- compositing/overflow/overflow-auto-with-touch-toggle.html: Added.
- platform/chromium/TestExpectations:
- 11:46 AM Changeset in webkit [127619] by
-
- 4 edits in releases/WebKitGTK/webkit-1.10/Source
Merge r127483 - [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
https://bugs.webkit.org/show_bug.cgi?id=95740
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.
Source/WebCore:
Added sanity check to be sure we have a render object prior to seeing if
said object is an anonymous block.
Testing via unit test because a non-flaky layout test crasher could not
be found.
- accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Sanity check for render object added.
Source/WebKit/gtk:
Updated unit test.
- tests/testatk.c:
(testWebkitAtkComboBox): Added checks that the menu popup in a combo box
has 0 links and, more importantly, that checking doesn't result in a crash.
- 11:46 AM WebKitGTK/1.10.x edited by
- (diff)
- 11:40 AM Changeset in webkit [127618] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.10
Merge r127466 - [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
https://bugs.webkit.org/show_bug.cgi?id=95618
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.
Source/WebCore:
Make sure we only emit the the signal for menu lists and list
boxes rendered from actual HTML select elements.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange): We support accessibility
ListBoxes and MenuLists only here, assuming they represent HTML
select elements, which might be not always true (e.g. ARIA). Thus,
check if that condition is true, early returning in other case.
LayoutTests:
New layout test to ensure we don't crash with ATK notifications
anymore when changing the selection in an ARIA listbox.
- platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
- platform/gtk/accessibility/aria-listbox-crash.html: Added.
- 11:40 AM Changeset in webkit [127617] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed: WebInspector: remove accidentally committed speed test.
- tests/MemoryInstrumentationTest.cpp:
- 11:40 AM WebKitGTK/1.10.x edited by
- (diff)
- 11:33 AM Changeset in webkit [127616] by
-
- 2 edits in trunk/Tools
Unreviewed test fix.
Including a plugin source file into the build that was added in r127595.
- GNUmakefile.am:
- 11:26 AM Changeset in webkit [127615] by
-
- 32 edits2 deletes in trunk/LayoutTests
[CSS Shaders] Update custom filter tests to use the new security model
https://bugs.webkit.org/show_bug.cgi?id=95760
Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-05
Reviewed by Dirk Schulze.
This patch updates the custom filter tests to not sample u_texture and not write
to gl_FragColor. Now, the tests use the new security model by writing to
css_MixColor and indirectly blending with the DOM element texture.
This patch prepares us to remove direct DOM texture access via "u_texture":
https://bugs.webkit.org/show_bug.cgi?id=93871
- css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png:
- css3/filters/custom/custom-filter-shader-cache-expected.png:
- css3/filters/custom/custom-filter-shader-cache.html:
Use the CSS mix function with the updated color-offset.fs.
- css3/filters/custom/effect-color-check-expected.png:
- css3/filters/custom/effect-color-check.html:
Use the CSS mix function with the updated color-fill.fs.
- css3/filters/custom/effect-custom-combined-missing-expected.png:
- css3/filters/custom/effect-custom-combined-missing.html:
Use the CSS mix function with the updated color-offset.fs.
- css3/filters/custom/effect-custom-expected.png:
- css3/filters/custom/effect-custom-parameters-expected.png:
- css3/filters/custom/effect-custom-parameters.html:
Use the mix-color.fs shader instead of color-offset-parameters.fs.
- css3/filters/custom/effect-custom.html:
Use the CSS mix function with the updated color-offset.fs.
- css3/filters/custom/filter-repaint-custom-clipped-expected.png:
- css3/filters/custom/filter-repaint-custom-clipped.html:
Use the mix-color.fs shader instead of color-add.fs.
- css3/filters/custom/filter-repaint-custom-expected.png:
- css3/filters/custom/filter-repaint-custom-rotated-expected.png:
- css3/filters/custom/filter-repaint-custom-rotated.html:
Use the mix-color.fs shader instead of color-add.fs. Fix a small typo in a comment.
- css3/filters/custom/filter-repaint-custom.html:
Use the mix-color.fs shader instead of color-add.fs.
- css3/filters/custom/invalid-custom-filter-shader.html:
Use the CSS mix function with the updated color-offset.fs.
- css3/filters/custom/missing-custom-filter-shader-expected.png:
- css3/filters/custom/missing-custom-filter-shader.html:
Use the CSS mix function with the updated color-offset.fs.
- css3/filters/resources/color-add.fs:
Removed. The mix-color.fs shader can perform this shader's function.
- css3/filters/resources/color-fill.fs:
Rewrote this shader to write to css_MixColor instead of sampling u_texture and writing
to gl_FragColor.
- css3/filters/resources/color-offset-parameters.fs:
Removed. The mix-color.fs shader can perform this shader's function.
- css3/filters/resources/color-offset.fs:
Rewrote this shader to write to css_MixColor instead of sampling u_texture and writing
to gl_FragColor.
- platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
- platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
- platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
- platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
- platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png:
- platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
- platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png:
- platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
- platform/chromium/TestExpectations:
- 11:21 AM Changeset in webkit [127614] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Make visited link tracking work in multi-process mode
https://bugs.webkit.org/show_bug.cgi?id=95869
Reviewed by Dan Bernstein.
- UIProcess/VisitedLinkProvider.h:
- UIProcess/VisitedLinkProvider.cpp: (WebKit::VisitedLinkProvider::VisitedLinkProvider): m_webProcessHasVisitedLinkState was making no sense in multi-process world, so it was let go. (WebKit::VisitedLinkProvider::processDidFinishLaunching): Track new processes. (WebKit::VisitedLinkProvider::processDidClose): Clean up pointers that are going to become stale. (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired): Added comments. Fixed a bug where we would churn table size in some cases. Added debug logging in failure case. Re-implemented messaging code to work with multiple web processes.
- UIProcess/WebContext.cpp: (WebKit::WebContext::processDidFinishLaunching): Pass process proxy pointer to m_visitedLinkProvider, as it now needs to track processes. (WebKit::WebContext::disconnectProcess): Ditto. Also re-enabled visited link provider cleanup in multi-process mode.
- 11:19 AM WebInspector edited by
- Removing spam links. (diff)
- 11:16 AM Changeset in webkit [127613] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize values.
https://bugs.webkit.org/show_bug.cgi?id=95773
Reviewed by Rob Buis.
Properly initialize the passed variables even
though we haven't implemented the modifier state
to ensure the values are deterministic.
- platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):
- 11:01 AM Changeset in webkit [127612] by
-
- 25 edits7 copies2 adds in trunk
MediaStream API: Add the local and remote description functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95839
Reviewed by Adam Barth.
Source/Platform:
- Platform.gypi:
- chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
- chromium/public/WebRTCVoidRequest.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.
(WebCore):
(WebKit):
(WebRTCVoidRequest):
(ExtraData):
(WebKit::WebRTCVoidRequest::ExtraData::~ExtraData):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::~WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::operator=):
(WebKit::WebRTCVoidRequest::isNull):
Source/WebCore:
As well as adding the local/remote descriptions stuff, I removed the source attribute from
RTCSessionDescriptionCallback and RTCErrorCallback since it has been removed from the draft.
Tests: fast/mediastream/RTCPeerConnection-localDescription.html
fast/mediastream/RTCPeerConnection-remoteDescription.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/RTCErrorCallback.h:
(RTCErrorCallback):
- Modules/mediastream/RTCErrorCallback.idl:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):
- Modules/mediastream/RTCPeerConnection.h:
(WebCore):
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCSessionDescriptionCallback.h:
(RTCSessionDescriptionCallback):
- Modules/mediastream/RTCSessionDescriptionCallback.idl:
- Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:
(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::clear):
- Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
(RTCSessionDescriptionRequestImpl):
- Modules/mediastream/RTCVoidRequestImpl.cpp: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp.
(WebCore):
(WebCore::RTCVoidRequestImpl::create):
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::~RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::requestSucceeded):
(WebCore::RTCVoidRequestImpl::requestFailed):
(WebCore::RTCVoidRequestImpl::stop):
(WebCore::RTCVoidRequestImpl::clear):
- Modules/mediastream/RTCVoidRequestImpl.h: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.h.
(WebCore):
(RTCVoidRequestImpl):
- WebCore.gypi:
- platform/chromium/support/WebRTCVoidRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.
(WebKit):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::assign):
(WebKit::WebRTCVoidRequest::reset):
(WebKit::WebRTCVoidRequest::requestSucceeded):
(WebKit::WebRTCVoidRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCVoidRequest::extraData):
(WebKit::WebRTCVoidRequest::setExtraData):
- platform/mediastream/RTCPeerConnectionHandler.cpp:
(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerDummy::localDescription):
(WebCore::RTCPeerConnectionHandlerDummy::remoteDescription):
- platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(RTCPeerConnectionHandler):
- platform/mediastream/RTCVoidRequest.h: Copied from Source/WebCore/Modules/mediastream/RTCErrorCallback.h.
(WebCore):
(RTCVoidRequest):
(ExtraData):
(WebCore::RTCVoidRequest::ExtraData::~ExtraData):
(WebCore::RTCVoidRequest::~RTCVoidRequest):
(WebCore::RTCVoidRequest::extraData):
(WebCore::RTCVoidRequest::setExtraData):
(WebCore::RTCVoidRequest::RTCVoidRequest):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerChromium::localDescription):
(WebCore::RTCPeerConnectionHandlerChromium::remoteDescription):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):
Tools:
In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
up the task definitions a bit. There was no need to have them in the header file.
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCVoidRequestTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(MockWebRTCPeerConnectionHandler::createOffer):
(MockWebRTCPeerConnectionHandler::setLocalDescription):
(MockWebRTCPeerConnectionHandler::setRemoteDescription):
(MockWebRTCPeerConnectionHandler::localDescription):
(MockWebRTCPeerConnectionHandler::remoteDescription):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):
LayoutTests:
- fast/mediastream/RTCPeerConnection-createOffer.html:
- fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-localDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
- fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-remoteDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
- 10:58 AM Changeset in webkit [127611] by
-
- 6 edits in branches/chromium/1229/Source/WebCore/rendering
Merge 125220 - Reimplement RenderQuote placement algorithm
BUG=135173
Review URL: https://chromiumcodereview.appspot.com/10912102
- 10:55 AM Changeset in webkit [127610] by
-
- 6 edits in branches/chromium/1229/Source/WebCore/rendering
Revert 127609 - Merge 124969
BUG=135173
TBR=cevans@google.com
Review URL: https://chromiumcodereview.appspot.com/10913088
- 10:50 AM Changeset in webkit [127609] by
-
- 6 edits in branches/chromium/1229/Source/WebCore/rendering
Merge 124969
BUG=135173
Review URL: https://chromiumcodereview.appspot.com/10911104
- 10:48 AM Changeset in webkit [127608] by
-
- 11 edits32 adds in trunk
Use -webkit-clip-path shapes to clip HTML elements
https://bugs.webkit.org/show_bug.cgi?id=95646
Reviewed by Dean Jackson.
Source/WebCore:
-webkit-clip-path creates a new layer for HTML elements now. The border,
background and content gets clipped by the clip path after any filter was
applied.
Tests: css3/masking/clip-path-circle-filter.html
css3/masking/clip-path-circle-overflow.html
css3/masking/clip-path-circle-overflow-hidden.html
css3/masking/clip-path-circle-relative-overflow.html
css3/masking/clip-path-circle.html
css3/masking/clip-path-ellipse.html
css3/masking/clip-path-polygon-evenodd.html
css3/masking/clip-path-polygon-nonzero.html
css3/masking/clip-path-polygon.html
css3/masking/clip-path-rectangle.html
- rendering/RenderBox.h: Create new layer on clip-path.
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer): Create new layer on clip-path.
- rendering/RenderInline.h:
(WebCore::RenderInline::requiresLayer): Create new layer on clip-path.
- rendering/RenderLayer.cpp: Apply clip-path on context of object.
(WebCore::RenderLayer::paintLayerContents): Create new layer on clip-path.
- rendering/RenderObject.h:
(WebCore::RenderObject::hasClipPath): Indicates that renderer needs to be clipped by clip-path.
- rendering/RenderTableRow.h: Create new layer on clip-path.
LayoutTests:
Added new tests for the -webkit-clip-path property applied to HTML content.
- css3/masking/clip-path-circle-filter.html: Added.
- css3/masking/clip-path-circle-overflow.html: Added.
- css3/masking/clip-path-circle-relative-overflow.html: Added.
- css3/masking/clip-path-circle-overflow-hidden.html: Added.
- css3/masking/clip-path-circle.html: Added.
- css3/masking/clip-path-ellipse.html: Added.
- css3/masking/clip-path-polygon-evenodd.html: Added.
- css3/masking/clip-path-polygon-nonzero.html: Added.
- css3/masking/clip-path-polygon.html: Added.
- css3/masking/clip-path-rectangle.html: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/css3/masking/clip-path-circle-expected.png: Added.
- platform/mac/css3/masking/clip-path-circle-expected.txt: Added.
- platform/mac/css3/masking/clip-path-circle-filter-expected.png: Added.
- platform/mac/css3/masking/clip-path-circle-filter-expected.txt: Added.
- platform/mac/css3/masking/clip-path-circle-overflow-expected.png: Added.
- platform/mac/css3/masking/clip-path-circle-overflow-expected.txt: Added.
- platform/mac/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
- platform/mac/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Added.
- platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
- platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.txt: Added.
- platform/mac/css3/masking/clip-path-ellipse-expected.png: Added.
- platform/mac/css3/masking/clip-path-ellipse-expected.txt: Added.
- platform/mac/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
- platform/mac/css3/masking/clip-path-polygon-evenodd-expected.txt: Added.
- platform/mac/css3/masking/clip-path-polygon-expected.png: Added.
- platform/mac/css3/masking/clip-path-polygon-expected.txt: Added.
- platform/mac/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
- platform/mac/css3/masking/clip-path-polygon-nonzero-expected.txt: Added.
- platform/mac/css3/masking/clip-path-rectangle-expected.png: Added.
- platform/mac/css3/masking/clip-path-rectangle-expected.txt: Added.
- 10:33 AM Changeset in webkit [127607] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Use explicit constructor in RenderThemeEfl.
https://bugs.webkit.org/show_bug.cgi?id=95853
Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-05
Reviewed by Kentaro Hara.
Added explicit keyword in constructor of RenderThemeEfl in order to avoid implicit type conversion.
- platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
- 10:31 AM Changeset in webkit [127606] by
-
- 7 edits2 adds in trunk
webkitPointerLockElement returns null when pointer lock request is pending.
https://bugs.webkit.org/show_bug.cgi?id=91186
Reviewed by Dimitri Glazkov.
Source/WebCore:
Script should wait for a pointerlockchange event before detecting
if it has acquired lock. However, if a script attempted to poll
pointerLockElement it could be confused when lock was still pending.
This change ensures that if lock is not yet acquired then
pointerLockElement will return null.
Test: pointer-lock/pointerlockelement-null-when-pending.html
- dom/Document.cpp:
(WebCore::Document::webkitPointerLockElement):
- page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::elementRemoved):
(WebCore::PointerLockController::documentDetached):
(WebCore::PointerLockController::lockPending):
(WebCore):
(WebCore::PointerLockController::didAcquirePointerLock):
(WebCore::PointerLockController::didNotAcquirePointerLock):
(WebCore::PointerLockController::didLosePointerLock):
(WebCore::PointerLockController::clearElement):
- page/PointerLockController.h:
(PointerLockController):
LayoutTests:
- pointer-lock/locked-element-iframe-removed-from-dom-expected.txt:
- pointer-lock/locked-element-iframe-removed-from-dom.html:
Updated to reflect new behavior of null returned when lock is pending.
- pointer-lock/pointerlockelement-null-when-pending-expected.txt: Added.
- pointer-lock/pointerlockelement-null-when-pending.html: Added.
New test specifically for testing null return when lock is pending.
- 10:25 AM Changeset in webkit [127605] by
-
- 16 edits1 add in trunk/Source
[chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium
https://bugs.webkit.org/show_bug.cgi?id=95679
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-09-05
Reviewed by James Robinson.
Source/Platform:
Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.
- Platform.gypi:
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
- chromium/public/WebLayerScrollClient.h:
Source/WebCore:
Implement scrollable sublayers in ScrollingCoordinatorChromium and introduce a
WebLayerScrollClient which is notified of scroll events on its associated
scroll layer. GraphicsLayerChromium uses it to apply scroll events targeted to
its platform layer to a ScrollableArea, i.e., the RenderLayer corresponding to
the scrollable element.
Tests: GraphicsLayerChromiumTest.applyScrollToScrollableArea
WebLayerTest.ScrollClient
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::didScroll):
(WebCore):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore):
(WebCore::GraphicsLayerChromium::setScrollableArea):
(WebCore::GraphicsLayerChromium::scrollableArea):
(GraphicsLayerChromium):
- platform/graphics/chromium/LayerChromium.cpp:
- platform/graphics/chromium/LayerChromium.h:
(WebKit):
(WebCore):
(WebCore::LayerChromium::setLayerScrollClient):
(LayerChromium):
Source/WebKit/chromium:
Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.
- src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::setMaxScrollPosition):
(WebKit):
(WebKit::WebLayerImpl::setScrollClient):
(WebKit::WebLayerImpl::scrollBy):
- src/WebLayerImpl.h:
(WebLayerImpl):
- tests/CCLayerTreeHostTest.cpp:
- tests/GraphicsLayerChromiumTest.cpp:
(MockScrollableArea):
(WebKit):
(WebKit::TEST_F):
- tests/WebLayerTest.cpp:
- 10:05 AM Changeset in webkit [127604] by
-
- 4 edits in trunk
[EFL] Remove '+=' usage in String
https://bugs.webkit.org/show_bug.cgi?id=95808
Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-05
Reviewed by Benjamin Poulain.
Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
Source/WebKit/efl:
- ewk/ewk_frame.cpp:
(ewk_frame_source_get): Removed unnecessary strlen usage.
Tools:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(descriptionSuitableForTestResult):
- 9:44 AM Changeset in webkit [127603] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: support asynchronous command implementation
https://bugs.webkit.org/show_bug.cgi?id=95649
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-09-05
Reviewed by Yury Semikhatsky.
Generator is extended to generate callback object for each asynchronous command.
- inspector/CodeGeneratorInspector.py:
(Writer.append_multiline):
(Writer):
(Writer.get_indent):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.ResolveData):
(InspectorBackendDispatcherImpl):
(CallbackBase):
(Generator.process_event):
(Generator):
(Generator.EventMethodStructTemplate):
(Generator.EventMethodStructTemplate.append_prolog):
(Generator.EventMethodStructTemplate.append_epilog):
(Generator.process_command):
(Generator.CallbackMethodStructTemplate):
(Generator.CallbackMethodStructTemplate.append_prolog):
(Generator.CallbackMethodStructTemplate.append_epilog):
(Generator.generate_send_method):
- 9:33 AM Changeset in webkit [127602] by
-
- 4 edits in trunk
[EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=95842
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.
Tools:
Provide proper implementation for TestRunner::pathToLocalResource()
in EFL WKTR, identical to the one for DumpRenderTree.
Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
/tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
are found my WebKitTestRunner.
- WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
(WTR::TestRunner::pathToLocalResource):
LayoutTests:
Unskip fast/dom/frame-loading-via-document-write.html that
was failing due to incomplete implementation for
TestRunner::pathToLocalResource() in EFL WKTR.
- platform/efl-wk2/TestExpectations:
- 9:33 AM Changeset in webkit [127601] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-1.10
Merge r127370 - [Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811
Part of the bug was due to expected accessible objects of DivRole
and ParagraphRole being ignored, in favor of including child blocks.
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.
Source/WebCore:
Test: platform/gtk/accessibility/spans-paragraphs-and-divs.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::firstAnonymousBlockChild):
(WebCore):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
New method to return the first child which is an anonymous block.
- accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Include paragraphs and divs which contain a non-nested anonymous block.
LayoutTests:
Added new test to verify that paragraphs and divs which contain anonymous
blocks are included in the accessible object hierarchy and have the correct
number of children with the expected role.
- platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt: Added.
- platform/gtk/accessibility/spans-paragraphs-and-divs.html: Added.
- 9:32 AM Changeset in webkit [127600] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Do not release shared backingstore memory prematurely
https://bugs.webkit.org/show_bug.cgi?id=95841
PR #202517
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-09-05
Reviewed by George Staikos.
The BackingStore memory is shared by all web pages. We should check if
the current backingStore is active before create/release this shared memory.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
(BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
- 9:32 AM WebKitGTK/1.10.x edited by
- (diff)
- 9:19 AM Changeset in webkit [127599] by
-
- 2 edits in releases/WebKitGTK/webkit-1.10/LayoutTests
Merge r127377 - [Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure
https://bugs.webkit.org/show_bug.cgi?id=95643
Unreviewed GTK gardening, rebaselining an accessibility test.
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Corrected.
- 9:19 AM WebKitGTK/1.10.x edited by
- (diff)
- 9:16 AM WebKitGTK/1.10.x edited by
- (diff)
- 9:15 AM Changeset in webkit [127598] by
-
- 2 edits in releases/WebKitGTK/webkit-1.10/LayoutTests
Merge r127369 - Unreviewed GTK gardening, rebaselining an accessibility test.
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
- 8:58 AM Changeset in webkit [127597] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Unify size of popup menu for touch and non-touch.
https://bugs.webkit.org/show_bug.cgi?id=95606
Patch by Kevin Ellis <kevers@chromium.org> on 2012-09-05
Reviewed by Adam Barth.
Use minimum height for popup menus entries regardless of whether the
popup menu is displayed on a touch screen. Replaces use of touch
padding. Height meets minimum size requirement for a low error rate
while still looking aesthetic for non-touch.
Covered by existing tests.
- platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::getRowHeight):
- platform/chromium/PopupMenuChromium.cpp:
(WebCore):
- platform/chromium/PopupMenuChromium.h:
(PopupMenuChromium):
- 8:56 AM Changeset in webkit [127596] by
-
- 10 edits22 adds in trunk
[CSS Regions] Auto width is not working for Regions
https://bugs.webkit.org/show_bug.cgi?id=74135
Reviewed by Julien Chaffraix.
Source/WebCore:
It was not possible to flow content into a region having { width: auto; } since in such case, the region width was computed to 0.
Now, a region having auto width, will have its width computed following the rules for calculation of widths and margins
(http://www.w3.org/TR/CSS2/visudet.html#Computing_widths_and_margins).
For those cases in which resolving the width requires measuring of content's min/max-content values, we use the associated named flow min/max-content
values (the same for all regions with width auto in a region chain).
When a region has width:auto, the computation of width should be done using normal block/box sizing code, instead of replaced element code.
Contains code contributed by Alexandru Chiculita(Alexandru Chiculita).
Tests: fast/regions/autowidth-abspos-regionchain.html
fast/regions/autowidth-abspos.html
fast/regions/autowidth-float.html
fast/regions/autowidth-inlineblock.html
fast/regions/autowidth-nonreplaced-abspos.html
fast/regions/autowidth-nonreplacedblock-normalflow.html
fast/regions/autowidth-normalflow-maxwidth.html
fast/regions/autowidth-normalflow-minmaxwidth.html
fast/regions/autowidth-normalflow-minwidth.html
fast/regions/autowidth-normalflow-vertrl.html
fast/regions/autowidth-normalflow.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth): For positioned auto-width regions, skip the code path for replaced elements.
- rendering/RenderRegion.cpp:
(WebCore): Override min/maxPreferredLogicalWidth as they are used in the process of computing width for regions with auto width.
As this moment, a region is still a RenderReplaced element, so this code needs to be revisited when the region will become a RenderBlock.
Also, for min/max-width, we support only <length> values. We will extend support for other values in a following patch.
(WebCore::RenderRegion::minPreferredLogicalWidth):
(WebCore::RenderRegion::maxPreferredLogicalWidth):
- rendering/RenderRegion.h:
(RenderRegion):
Override isInlineBlockOrInlineTable() and shouldComputeSizeAsReplaced() to ensure that computation for width auto follows the normal
block/box sizing code.
LayoutTests:
It was not possible to flow content into a region having { width: auto; } since in such case, the region width was computed to 0.
Now, a region having auto width, will have its width computed following the rules for calculation of widths and margins
(http://www.w3.org/TR/CSS2/visudet.html#Computing_widths_and_margins).
For those cases in which resolving the width requires measuring of content's min/max-content values, we use the associated named flow min/max-content
values (the same for all regions with width auto in a region chain).
Besides adding new tests, i have modified existing tests that were having regions with width:auto as they were failing after this patch.
- fast/regions/autowidth-abspos-expected.html: Added.
- fast/regions/autowidth-abspos-regionchain-expected.html: Added.
- fast/regions/autowidth-abspos-regionchain.html: Added.
- fast/regions/autowidth-abspos.html: Added.
- fast/regions/autowidth-float-expected.html: Added.
- fast/regions/autowidth-float.html: Added.
- fast/regions/autowidth-inlineblock-expected.html: Added.
- fast/regions/autowidth-inlineblock.html: Added.
- fast/regions/autowidth-nonreplaced-abspos-expected.html: Added.
- fast/regions/autowidth-nonreplaced-abspos.html: Added.
- fast/regions/autowidth-nonreplacedblock-normalflow-expected.html: Added.
- fast/regions/autowidth-nonreplacedblock-normalflow.html: Added.
- fast/regions/autowidth-normalflow-expected.html: Added.
- fast/regions/autowidth-normalflow-maxwidth-expected.html: Added.
- fast/regions/autowidth-normalflow-maxwidth.html: Added.
- fast/regions/autowidth-normalflow-minmaxwidth-expected.html: Added.
- fast/regions/autowidth-normalflow-minmaxwidth.html: Added.
- fast/regions/autowidth-normalflow-minwidth-expected.html: Added.
- fast/regions/autowidth-normalflow-minwidth.html: Added.
- fast/regions/autowidth-normalflow-vertrl-expected.html: Added.
- fast/regions/autowidth-normalflow-vertrl.html: Added.
- fast/regions/autowidth-normalflow.html: Added.
- fast/regions/bottom-overflow-out-of-first-region.html:
- fast/regions/flows-dependency-dynamic-remove.html:
- fast/regions/flows-dependency-same-flow.html:
- fast/regions/render-region-renderer-expected.html:
- fast/regions/top-overflow-out-of-second-region.html:
- 8:39 AM Changeset in webkit [127595] by
-
- 9 edits3 adds in trunk
Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
<rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
Source/WebKit2:
Patch partially by Andras Becsi <andras.becsi@nokia.com>
Reviewed by Andy Estes.
If a plug-in fails to initialize then the m_plugin pointer is cleared out.
When accessing the script object it is appropriate to unconditionally null check m_plugin.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::scriptObject): Null check m_plugin before trying to use it.
Tools:
Reviewed by Andy Estes.
Add a plug-in that always fails to initialize:
- DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
(NPPNewFails):
(NPPNewFails::NPPNewFails):
(NPPNewFails::NPP_New):
Add it to all the project files:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
LayoutTests:
Reviewed by Andy Estes.
- plugins/npp-new-fails-expected.txt: Added.
- plugins/npp-new-fails.html: Added.
- 8:38 AM Changeset in webkit [127594] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Implement number of matches and current active match index for find-on-page
https://bugs.webkit.org/show_bug.cgi?id=95801
Patch by Andy Chen <andchen@rim.com> on 2012-09-05
Reviewed by Antonio Gomes.
- Calculate current match index for find-on-page
- Notify client when number of matches and current match index update.
PR 162090 162091.
Internally reviewed by Mike Fenton and Joe Mason
- Api/WebPageClient.h:
- WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
(InPageSearchManager::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
(BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
- WebKitSupport/InPageSearchManager.h:
(InPageSearchManager):
- 8:11 AM Changeset in webkit [127593] by
-
- 115 edits in trunk/Source
Web Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation.
https://bugs.webkit.org/show_bug.cgi?id=95850
Reviewed by Yury Semikhatsky.
I'd like to extract MemoryObjectTypes into separate classes.
After that we will be able to move core NMI instrumentation code to WTF.
Source/WebCore:
- bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::ChunkedTable::reportMemoryUsage):
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/V8Binding.cpp:
(WebCore::StringCache::reportMemoryUsage):
- bindings/v8/V8DOMMap.h:
- bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
- css/CSSAspectRatioValue.cpp:
(WebCore::CSSAspectRatioValue::reportDescendantMemoryUsage):
- css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::reportDescendantMemoryUsage):
- css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
- css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportDescendantMemoryUsage):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):
- css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
- css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reportDescendantMemoryUsage):
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
- css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::reportDescendantMemoryUsage):
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::reportDescendantMemoryUsage):
- css/CSSInheritedValue.cpp:
(WebCore::CSSInheritedValue::reportDescendantMemoryUsage):
- css/CSSInitialValue.cpp:
(WebCore::CSSInitialValue::reportDescendantMemoryUsage):
- css/CSSLineBoxContainValue.cpp:
(WebCore::CSSLineBoxContainValue::reportDescendantMemoryUsage):
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportDescendantMemoryUsage):
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::reportDescendantMemoryUsage):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::reportMemoryUsage):
- css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::reportDescendantMemoryUsage):
- css/CSSRule.cpp:
(WebCore::CSSRule::reportBaseClassMemoryUsage):
- css/CSSRuleList.cpp:
(WebCore::StaticCSSRuleList::reportMemoryUsage):
- css/CSSRuleList.h:
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::reportMemoryUsage):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reportDescendantMemoryUsage):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
- css/CSSTimingFunctionValue.cpp:
(WebCore::CSSLinearTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSCubicBezierTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSStepsTimingFunctionValue::reportDescendantMemoryUsage):
- css/CSSUnicodeRangeValue.cpp:
(WebCore::CSSUnicodeRangeValue::reportDescendantMemoryUsage):
- css/CSSUnknownRule.h:
(WebCore::CSSUnknownRule::reportDescendantMemoryUsage):
- css/CSSValue.cpp:
(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::reportDescendantMemoryUsage):
- css/CSSVariableValue.h:
(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
- css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
- css/FontValue.cpp:
(WebCore::FontValue::reportDescendantMemoryUsage):
- css/MediaList.cpp:
(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):
- css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
- css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):
- css/ShadowValue.cpp:
(WebCore::ShadowValue::reportDescendantMemoryUsage):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::reportMemoryUsage):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::Features::reportMemoryUsage):
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleBlock::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):
- css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::reportDescendantMemoryUsage):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
- css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::reportDescendantMemoryUsage):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportDescendantMemoryUsage):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportDescendantMemoryUsage):
- css/WebKitCSSMixFunctionValue.cpp:
(WebCore::WebKitCSSMixFunctionValue::reportDescendantMemoryUsage):
- css/WebKitCSSRegionRule.cpp:
(WebCore::WebKitCSSRegionRule::reportDescendantMemoryUsage):
- css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
- css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
- css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::reportDescendantMemoryUsage):
- dom/Attribute.h:
(WebCore::Attribute::reportMemoryUsage):
- dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
- dom/ContainerNode.h:
(WebCore::ContainerNode::reportMemoryUsage):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::reportMemoryUsage):
- dom/Element.h:
(WebCore::Element::reportMemoryUsage):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/Event.cpp:
(WebCore::Event::reportMemoryUsage):
- dom/MemoryInstrumentation.cpp:
(WebCore):
- dom/MemoryInstrumentation.h:
(WebCore):
(GenericMemoryTypes):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCoreMemoryTypes):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::reportMemoryUsage):
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::reportMemoryUsage):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::reportMemoryUsage):
- loader/SubstituteData.cpp:
(WebCore::SubstituteData::reportMemoryUsage):
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::reportMemoryUsage):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::reportMemoryUsage):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
- loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::reportMemoryUsage):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):
- loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::reportMemoryUsage):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::reportMemoryUsage):
- loader/cache/CachedShader.cpp:
(WebCore::CachedShader::reportMemoryUsage):
- loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
- page/Frame.cpp:
(WebCore::Frame::reportMemoryUsage):
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
- platform/TreeShared.h:
(WebCore::TreeShared::reportMemoryUsage):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
- platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::reportMemoryUsage):
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::reportMemoryUsage):
- platform/graphics/Image.cpp:
(WebCore::Image::reportMemoryUsage):
- platform/network/FormData.cpp:
(WebCore::FormData::reportMemoryUsage):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::reportMemoryUsage):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
- svg/SVGColor.cpp:
(WebCore::SVGColor::reportDescendantMemoryUsage):
- svg/SVGPaint.cpp:
(WebCore::SVGPaint::reportDescendantMemoryUsage):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::reportMemoryUsage):
Source/WebKit/chromium:
- tests/MemoryInstrumentationTest.cpp:
(WebCore::Instrumented::reportMemoryUsage):
(WebCore::InstrumentedRefPtr::reportMemoryUsage):
(WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
(WebCore::InstrumentedOther::reportMemoryUsage):
(WebCore::InstrumentedDOM::reportMemoryUsage):
(WebCore::TEST):
(WebCore::NonVirtualInstrumented::reportMemoryUsage):
- 7:52 AM Changeset in webkit [127592] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: NMI: extract overloaded instrumentation members for WebCore classes from core NMI code.
https://bugs.webkit.org/show_bug.cgi?id=95834
Reviewed by Yury Semikhatsky.
I'd like to remove custom instrumentation methods from MemoryInstrumentation class
before upstreaming it to WTF. I've done it with help of MemoryInstrumentationTraits template helper.
Unfortunately it is not possible to use template class because mac-ews bot reports warning: redundant redeclaration of 'something' in same scope.
I've found that it is an old problem in gcc that is forced by -Wredundant-decls flag on the bot. See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15867
- dom/MemoryInstrumentation.cpp:
(WebCore::::addInstrumentedObject):
(WebCore):
- dom/MemoryInstrumentation.h:
(WebCore):
(MemoryInstrumentationTraits):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer):
(InstrumentedPointer):
(WebCore::MemoryInstrumentation::addObject):
(WebCore::MemoryInstrumentation::addInstrumentedObject):
(WebCore::MemoryInstrumentation::addRawBuffer):
(WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedObject):
(WebCore::MemoryInstrumentation::OwningTraits::addObject):
(WebCore::::addInstrumentedObject):
(WebCore::::addObject):
(WebCore::MemoryObjectInfo::MemoryObjectInfo):
(WebCore::MemoryObjectInfo::objectType):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(MemoryObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
(MemoryClassInfo):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(WebCore::MemoryInstrumentation::addObjectImpl):
(WebCore::MemoryInstrumentation::addHashMap):
(WebCore::MemoryInstrumentation::addHashSet):
(WebCore::MemoryInstrumentation::addInstrumentedCollection):
(WebCore::MemoryInstrumentation::addInstrumentedMapEntries):
(WebCore::MemoryInstrumentation::addInstrumentedMapValues):
(WebCore::MemoryInstrumentation::addListHashSet):
(WebCore::MemoryInstrumentation::addVector):
- inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationImpl::countObjectSize):
- inspector/MemoryInstrumentationImpl.h:
(WebCore::MemoryInstrumentationImpl::totalSize):
(MemoryInstrumentationImpl):
- 7:37 AM WebInspector edited by
- (diff)
- 7:36 AM Changeset in webkit [127591] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r127590.
http://trac.webkit.org/changeset/127590
Broke the Chromium bots because of a compile error in the compositor.
- DEPS:
- 7:23 AM Changeset in webkit [127590] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 7:18 AM Changeset in webkit [127589] by
-
- 8 edits2 adds in releases/WebKitGTK/webkit-1.10
Merge r127368 - [Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811
Part of the bug was due to extraneous accessible objects resulting
from unignored inline and block spans.
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.
Source/WebCore:
Test: platform/gtk/accessibility/spans.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Ignore objects that have spanTag tag name.
- accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore most anonymous blocks.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(roleIsTextType): Add ListItem to the roles which should implement AtkText.
LayoutTests:
Added new test, updated the results of one test to reflect the fix,
corrected a test with a mismatched element tag.
- platform/gtk/accessibility/aria-roles-unignored-expected.txt: Corrected results having fixed tag.
- platform/gtk/accessibility/aria-roles-unignored.html: Fixed mismatched element tag.
- platform/gtk/accessibility/media-element-expected.txt: Updated to reflect removal of extraneous object.
- platform/gtk/accessibility/spans-expected.txt: Added.
- platform/gtk/accessibility/spans.html: Added.
- 7:18 AM WebKitGTK/1.10.x edited by
- (diff)
- 7:11 AM Changeset in webkit [127588] by
-
- 8 edits4 adds in releases/WebKitGTK/webkit-1.10
Merge r127367 - [Gtk] Incorrect/unexpected characters in the text of certain accessibles
https://bugs.webkit.org/show_bug.cgi?id=95180
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.
Source/WebCore:
The bug was caused by failing to properly handle anonymous block text
which had object replacement characters (multibyte) in it. Calculating
the string length based on the UTF-8 string meant that we were returning
more characters than were there and in danger of splitting a multibyte
character.
Tests: platform/gtk/accessibility/entry-and-password.html
platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html
- accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetText): Convert the text returned by textForObject()
to Unicode before calculating its length.
Source/WebKit/gtk:
Corrected a unit test in which the expected accessible text was wrong as
a result of this bug. In particular, the AtkText inserted into an empty
text field is expected to be the same text atk_text_get_text() returns.
That was not happening -- and presumably not noticed as a result of the
hard to read textual representation of the multibyte password field
bullets.
- tests/testatk.c:
(testWebkitAtkTextChangedNotifications): Corrected the test and added a
comment so that one knows what the multibyte character is.
Tools:
The bug that was fixed stood in the way of fully implementing stringValue().
Testing that the bug is fixed requires stringValue() to be fully implemented
and object replacement characters to be printable.
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(replaceCharactersForResults): New method which turns object replacement
characters into "<obj>" so that the characters can be properly shown in
Layout Test results. Also turns "\n" into "<
n>" so that printing the
accessible text of a single object in the accessible tree doesn't mess up
the readibility of the results.
(AccessibilityUIElement::stringValue): Remove the code that immediately
returned upon encountering an object of ATK_ROLE_PANEL and call the new
replaceCharactersForResults() prior to returning the accessible string
value.
LayoutTests:
Two new layout tests, plus one updated one.
- platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Indicated replaced objects.
- platform/gtk/accessibility/entry-and-password-expected.txt: Added.
- platform/gtk/accessibility/entry-and-password.html: Added.
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Added.
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html: Added.
- 7:10 AM WebKitGTK/1.10.x edited by
- (diff)
- 7:04 AM Changeset in webkit [127587] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Build fix on OS X
Copy/paste-error resulted in us compiling InspectorPageOverlay.h
Reviewed by Ossy.
- 6:59 AM Changeset in webkit [127586] by
-
- 6 edits in releases/WebKitGTK/webkit-1.10
Merge r126941 - Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
https://bugs.webkit.org/show_bug.cgi?id=95185
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-28
Reviewed by Chris Fleizach.
Tools:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::titleUIElement): Implemented
Gets the ATK_RELATION_LABELLED_BY target.
(AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
bug 95180 is fixed.
LayoutTests:
Updated layout test expected results. In all three cases below:
1) Remove objects from the tree representation which did not belong,
but were included as a side effect of AccessibilityUIElement::stringValue()
not having been implemented.
2) Add the stringValue() return value to the tree representation.
Note that the implementation of AccessibilityUIElement::titleUIElement()
will be tested by the existing legend.html layout text. See bug 84137.
- platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Updated.
- platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated.
- platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Updated.
- 6:59 AM WebKitGTK/1.10.x edited by
- (diff)
- 6:47 AM Changeset in webkit [127585] by
-
- 2 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore
Merge r126886 - [GTK] LLint build fails with -g -02
https://bugs.webkit.org/show_bug.cgi?id=90098
Patch by Alban Browaeys <prahal@yahoo.com> on 2012-08-28
Reviewed by Filip Pizlo.
Avoid duplicate offsets for llint, discarding them.
- offlineasm/offsets.rb:
- 6:47 AM WebKitGTK/1.10.x edited by
- (diff)
- 6:25 AM Changeset in webkit [127584] by
-
- 1 edit1 add in trunk/LayoutTests
[EFL] Unreviewed gardening.
Adding a platform specififc baseline after r127534.
- platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
- 6:11 AM Changeset in webkit [127583] by
-
- 2 edits in trunk/Tools
[Qt] Fix makefile race condition between derived sources and target
r121966 removed too much of the old qmake logic, including the rule
that ensured that qmake_all would not trigger dual runs of qmake --
one of the derived sources -qmake-all rule, and one for making the
derived sources.
We now follow a similar pattern as before, by introducing a custom
target that explicitly depends on the derived sources' qmake-all before
doing a manual run of make. That ensures a single qmake run for the derived
sources.
https://bugs.webkit.org/show_bug.cgi?id=93847
Reviewed by Csaba Osztrogonác.
- qmake/mkspecs/features/functions.prf:
- 6:06 AM Changeset in webkit [127582] by
-
- 4 edits1 delete in trunk
[EFL][WK2] Provide implementation for WebFrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=95826
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Remove EFL-specific and empty implementation for WebFrameNetworkingContext
and use the existing soup implementation instead.
- PlatformEfl.cmake:
- WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Removed.
LayoutTests:
Unskip several cookie-related test cases for WK2 EFL
now that WebFrameNetworkingContext is implemented.
- platform/efl-wk2/TestExpectations:
- 5:34 AM Changeset in webkit [127581] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r127573.
http://trac.webkit.org/changeset/127573
https://bugs.webkit.org/show_bug.cgi?id=95844
Breaks EFL Debug bot tests. (Requested by drott on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-05
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::setThemePath):
(WebCore::RenderThemeEfl::createCanvas):
(WebCore::RenderThemeEfl::createEdje):
(WebCore::RenderThemeEfl::applyPartDescriptions):
(WebCore::RenderThemeEfl::themeChanged):
(WebCore):
- platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
- 5:09 AM Changeset in webkit [127580] by
-
- 5 edits2 adds in trunk
ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=91704
Reviewed by Kentaro Hara.
Source/WebCore:
This change implement ShadowRoot::cloneNode() which throws an exception.
This also adds an overloaded version cloneNode() to ShadowRoot.idl
which is enabled only for JavaScript instead of changing the
signature of Node::cloneNode().
Note that changing the existing signature can break GObject bindings
compatibility.
Test: fast/dom/shadow/shadowroot-clonenode.html
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):
(WebCore):
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/ShadowRoot.idl:
LayoutTests:
- fast/dom/shadow/shadowroot-clonenode-expected.txt: Added.
- fast/dom/shadow/shadowroot-clonenode.html: Added.
- 4:53 AM Changeset in webkit [127579] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Unreviewed trivial build fix: Use DOMAllInOne.cpp only if we have xslt available.
- Target.pri:
- 4:44 AM Changeset in webkit [127578] by
-
- 9 edits in trunk
WKTR doesn't implement dumpWillCacheResponse()
https://bugs.webkit.org/show_bug.cgi?id=94607
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.
Tools:
Define shouldCacheResponse() callback in resource
load client and provide implementation for
dumpWillCacheResponse() in WebKitTestRunner.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldCacheResponse):
(WTR):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::TestRunner):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::dumpWillCacheResponse):
(WTR::TestRunner::shouldDumpWillCacheResponse):
(TestRunner):
LayoutTests:
Unskip http/tests/misc/willCacheResponse-delegate-callback.html
now that WebKitTestRunner implements dumpWillCacheResponse().
- platform/efl-wk2/TestExpectations:
- platform/wk2/Skipped:
- 4:36 AM Changeset in webkit [127577] by
-
- 49 edits in trunk
[DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
https://bugs.webkit.org/show_bug.cgi?id=92735
Reviewed by Hajime Morita.
.:
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Added symbols for GTK builds for corresponding APIs.
- Source/autotools/symbols.filter:
Source/WebCore:
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Covered by existing test cases.
- testing/Internals.cpp:
(WebCore::Internals::numberOfPages):
(WebCore):
(WebCore::Internals::pageProperty):
(WebCore::Internals::pageSizeAndMarginsInPixels):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/efl:
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/qt:
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Kept the function defination and declaration to keep binary compatibility for IWebFramePrivate.idl
- WebFrame.cpp:
(WebFrame::numberOfPages):
Source/WebKit2:
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Add symbols for Mac Win builds for corresponding newly added APIs.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
Tools:
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::addUserStyleSheet):
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::hasCustomPageSizeStyle):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::evaluateScriptInIsolatedWorld):
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
(TestRunner::abortModal):
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
LayoutTests:
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Fixed test cases to use internals API instead of testRunner.
- printing/numberOfPages-expected.txt:
- printing/page-count-layout-overflow.html:
- printing/page-count-relayout-shrink.html:
- printing/page-count-with-one-word.html:
- printing/page-format-data-display-none.html:
- printing/page-format-data-expected.txt:
- printing/page-format-data.html:
- printing/page-rule-selection-expected.txt:
- printing/page-rule-selection.html:
- printing/resources/paged-media-test-utils.js:
(numberOfPagesShouldBe):
- printing/script-tests/numberOfPages.js:
- printing/zoomed-document.html:
- 4:26 AM Changeset in webkit [127576] by
-
- 3 edits1 add in trunk
[Qt] Automate the use of AllInOne files in the Qt build
https://bugs.webkit.org/show_bug.cgi?id=95837
Reviewed by Tor Arne Vestbø.
Source/WebCore:
Replace the manual use of SVGAllInOne.cpp with automated use through
the ALL_IN_ONE_SOURCES variable. This adds a few more all-in-one sources
to the build and leaves out some that do not compile yet due to various
platform-dependant pre-processor macro issues.
- Target.pri:
Tools:
New feature file that implements the all-in-one file automation by
adding the requested all-in-one files to SOURCES and removing the files
it includes from SOURCES.
- qmake/mkspecs/features/use_all_in_one_files.prf: Added.
- 4:24 AM Changeset in webkit [127575] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening after r127513
Marking plugin third-party storage tests as failing on EFL.
- platform/efl/TestExpectations:
- 4:04 AM Changeset in webkit [127574] by
-
- 6 edits in trunk/Source
Fix the uses of String::operator+=() for Mac
https://bugs.webkit.org/show_bug.cgi?id=95818
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-05
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
- jsc.cpp:
(functionJSCStack): Use StringBuilder to create the stack dump, it is faster
and avoid String::operator+=().
- parser/Parser.h:
(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
Use the String operators (and makeString) to concatenate the strings.
Source/WebCore:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::putDelegate):
This is a legitimate use of String::append(), it is the only
concatenation in this function.
- loader/appcache/ManifestParser.cpp:
(WebCore::parseManifest): Ditto.
- 4:02 AM Changeset in webkit [127573] by
-
- 3 edits in trunk/Source/WebCore
[EFL] Fuzzy load the Edje theme for HTML forms
https://bugs.webkit.org/show_bug.cgi?id=95832
Reviewed by Gyuyoung Kim.
Change the theme so that it is first loaded when actually used.
This also fixed the case that it was impossible to change theme
a second time.
Tested by current tests. API unit test coming in separate patch.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::setThemePath):
(WebCore::RenderThemeEfl::edje):
(WebCore::RenderThemeEfl::applyPartDescriptions):
- platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
- 3:56 AM Changeset in webkit [127572] by
-
- 2 edits in trunk/Source/WebCore
[Blackberry] Add document url and securityOrigin to platform request.
https://bugs.webkit.org/show_bug.cgi?id=95822
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-09-05
Reviewed by George Staikos.
Internally Reviewed by Joe Mason.
It is a webworks requirement.
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- 3:00 AM WebKitGTK/1.10.x edited by
- (diff)
- 2:19 AM Changeset in webkit [127571] by
-
- 8 edits in trunk/Source
Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers.
https://bugs.webkit.org/show_bug.cgi?id=95739
Reviewed by Yury Semikhatsky.
When we go deeper into different parts of browser like skia, chromium itself etc.
we can't use a single enum for all reported object types.
The current idea is to use plain simple strings as ObjectType identifiers.
In the future patches we will extract these identifiers into separate class or namespace
and and split it between components.
Source/WebCore:
- dom/MemoryInstrumentation.cpp:
(WebCore):
- dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::addMemoryBlockFor):
(WebCore):
- inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::countObjectSize):
- inspector/MemoryInstrumentationImpl.h:
(WebCore::MemoryInstrumentationImpl::totalSize):
(WebCore::MemoryInstrumentationImpl::reportedSizeForAllTypes):
(MemoryInstrumentationImpl):
Source/WebKit/chromium:
- tests/MemoryInstrumentationTest.cpp:
(WebCore::TEST):
(WebCore):
- 2:07 AM WebKitGTK/1.10.x edited by
- Added bug 90098 (diff)
- 1:55 AM WebKitGTK edited by
- Removed spam, updated stable release link to 1.10.x (diff)
- 1:50 AM Changeset in webkit [127570] by
-
- 1 copy in releases/WebKitGTK/webkit-1.9.91
Tagging the WebKitGTK+ 1.9.91 release
- 1:49 AM Changeset in webkit [127569] by
-
- 1 copy in releases/WebKitGTK/webkit-1.9.90
Tagging the WebKitGTK+ 1.9.90 release
- 1:41 AM Changeset in webkit [127568] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r127525.
- platform/graphics/wince/FontCustomPlatformData.h:
(WebCore):
- 1:41 AM Changeset in webkit [127567] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=95827
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-05
- platform/qt/Skipped: skip failing test after r127534.
- 1:40 AM EFLWebKit edited by
- Added debian command for dependent packages installation (diff)
- 1:29 AM Changeset in webkit [127566] by
-
- 4 edits in releases/WebKitGTK/webkit-1.10
Unreviewed. Update NEWS and configure.ac for 1.9.90 release
- 1:15 AM Changeset in webkit [127565] by
-
- 6 edits5 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining after r126911, r127163 and r127534.
Adding a platform-specific baseline for accessibility/canvas-description-and-role.html
that's required after r127084. The baseline is currently the same as Chromium's,
expecting 'AXCanvas' as the AXRole for the canvas element. The GTK port currently
reports 'image' as the AXRole - this is probably not intended so the text failure
expectation is also added for this test.
- platform/gtk/TestExpectations:
- platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.
- platform/gtk/fast/block/float/024-expected.txt:
- platform/gtk/fast/block/margin-collapse/025-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
- platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
- platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
- platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
- platform/gtk/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
- 1:05 AM Changeset in webkit [127564] by
-
- 1 edit14 adds in trunk/LayoutTests
[Tests] We should have interactive validation of required value for the "input" element
https://bugs.webkit.org/show_bug.cgi?id=95817
Reviewed by Kent Tamura.
This patch adds tests for required attribute handling on form
submission of input types. The test script is parametrized for
input type and expected type. Each test file simply call one test
script in common-interactive-validation-required.js.
The test script checks:
- Don't submit form when required value isn't presented.
- Submit form when required value is presented.
- fast/forms/date/date-interactive-validation-required-expected.txt: Added.
- fast/forms/date/date-interactive-validation-required.html: Added.
- fast/forms/datetime/datetime-interactive-validation-required-expected.txt: Added.
- fast/forms/datetime/datetime-interactive-validation-required.html: Added.
- fast/forms/datetimelocal/datetimelocal-interactive-validation-required-expected.txt: Added.
- fast/forms/datetimelocal/datetimelocal-interactive-validation-required.html: Added.
- fast/forms/month/month-interactive-validation-required-expected.txt: Added.
- fast/forms/month/month-interactive-validation-required.html: Added.
- fast/forms/number/number-interactive-validation-required-expected.txt: Added.
- fast/forms/number/number-interactive-validation-required.html: Added.
- fast/forms/resources/common-interactive-validation-required.js: Added.
- fast/forms/time/time-interactive-validation-required-expected.txt: Added.
- fast/forms/time/time-interactive-validation-required.html: Added.
- fast/forms/week/week-interactive-validation-required-expected.txt: Added.
- fast/forms/week/week-interactive-validation-required.html: Added.
- 1:00 AM Changeset in webkit [127563] by
-
- 2 edits1 copy1 add1 delete in trunk/LayoutTests
Moved mac results to be the generic results, and the existing result to be the chromium
platform result. The current result uses subpixel layout, which is not the norm.
Original results were added in r127557. Mac results were added in r127560.
- css3/calc/zoom-with-em-expected.txt:
- platform/chromium/css3/calc/zoom-with-em-expected.txt: Copied from LayoutTests/css3/calc/zoom-with-em-expected.txt.
- platform/mac/css3/calc/zoom-with-em-expected.txt: Removed.
- 12:56 AM Changeset in webkit [127562] by
-
- 3 edits in trunk/LayoutTests
Test cases for Up/Down key behavior on field which has maximum/minimum in multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=95824
Reviewed by Kent Tamura.
This patch adds test cases for Up/Down key behavior on field which has
maximum/minimum value in multiple fields time input UI.
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Updated expectation for new test cases.
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Changed to add test cases for Up key behavior for "23:59:59.999" (11:59:59.999PM in UI) and Down key behavior for "01:00:00.000" (01:00:00.000 AM in UI)
- 12:51 AM Changeset in webkit [127561] by
-
- 6 edits in trunk/Source
DFG JIT doesn't work properly on ARM hardfp
https://bugs.webkit.org/show_bug.cgi?id=95684
Reviewed by Filip Pizlo.
Add hardfp support to DFG JIT. The patch is created with the
help of Zoltan Herczeg.
Source/JavaScriptCore:
- dfg/DFGCCallHelpers.h:
(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArguments):
- dfg/DFGFPRInfo.h:
(FPRInfo):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
Source/WTF:
- wtf/Platform.h:
- 12:22 AM Changeset in webkit [127560] by
-
- 1 edit1 copy1 add in trunk/LayoutTests
Added Mac-specific expected results for a test added in r127557. The generic results are
probably from a build with subpixel layout.
- platform/mac/css3/calc: Added.
- platform/mac/css3/calc/zoom-with-em-expected.txt: Copied from LayoutTests/css3/calc/zoom-with-em-expected.txt.
- 12:16 AM Changeset in webkit [127559] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] QRawWebViewPrivate does not initialize some members
https://bugs.webkit.org/show_bug.cgi?id=95709
Reviewed by Luiz Agostini.
Don't miss initializing the bool flags.
- UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebViewPrivate::QRawWebViewPrivate):
Sep 4, 2012:
- 11:35 PM Changeset in webkit [127558] by
-
- 11 edits3 copies1 add in trunk/Source
Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=95681
Reviewed by Kent Tamura.
Source/WebCore:
We are moving calendar picker PagePopupClient to WebKit layer so ports
can use their platform native chooser UI if they have one.
DateTimeChooser, DateTimeChooserClient etc. will be reused when we
implement the week picker and month picker.
No new tests. No behavior change. Covered by existing calendar picker tests.
- WebCore.gypi:
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::CalendarPickerElement):
(WebCore::CalendarPickerElement::~CalendarPickerElement):
(WebCore::CalendarPickerElement::didChooseValue): Called when user chose a value.
(WebCore):
(WebCore::CalendarPickerElement::didEndChooser): Called when chooser has ended.
(WebCore::CalendarPickerElement::openPopup):
(WebCore::CalendarPickerElement::closePopup):
- html/shadow/CalendarPickerElement.h:
(CalendarPickerElement):
- loader/EmptyClients.cpp:
(WebCore):
(WebCore::EmptyChromeClient::openDateTimeChooser):
- loader/EmptyClients.h:
(EmptyChromeClient):
- page/ChromeClient.h:
(WebCore):
(ChromeClient):
- platform/DateTimeChooser.h:
(WebCore):
(DateTimeChooserParameters): Contains information needed to open the DateTimeChooser.
(DateTimeChooser):
(WebCore::DateTimeChooser::~DateTimeChooser):
- platform/DateTimeChooserClient.h:
(WebCore):
(DateTimeChooserClient):
(WebCore::DateTimeChooserClient::~DateTimeChooserClient):
Source/WebKit/chromium:
- WebKit.gyp:
- src/ChromeClientImpl.cpp:
(WebKit):
(WebKit::ChromeClientImpl::openDateTimeChooser):
- src/ChromeClientImpl.h:
(WebCore):
(ChromeClientImpl):
- src/DateTimeChooserImpl.cpp: Added.
(WebKit):
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::~DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::endChooser):
(WebKit::DateTimeChooserImpl::contentSize):
(WebKit::DateTimeChooserImpl::writeDocument):
(WebKit::DateTimeChooserImpl::setValueAndClosePopup):
(WebKit::DateTimeChooserImpl::didClosePopup):
- src/DateTimeChooserImpl.h:
(WebCore):
(WebKit):
(DateTimeChooserImpl):
- 11:28 PM Changeset in webkit [127557] by
-
- 3 edits2 adds in trunk
CSS3 calc: expressions with 'em' units do not zoom correctly.
https://bugs.webkit.org/show_bug.cgi?id=95705
Reviewed by Ojan Vafai.
Source/WebCore:
Each primitive value in a CSS calc expression now has (zoom) multiplier and scale factor applied
independently. Previously the multiplier and a single scale factor was applied to the expression
as a whole, but this failed to account for expressions involving font relative units. This is
because the multiplier should not be applied to font relative units.
Test: css3/calc/zoom-with-em.html
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
LayoutTests:
- css3/calc/zoom-with-em-expected.txt: Added.
- css3/calc/zoom-with-em.html: Added.
- 11:07 PM Changeset in webkit [127556] by
-
- 13 edits in trunk/Source
[chromium] Prevent compositor ticking if it can't draw
https://bugs.webkit.org/show_bug.cgi?id=95399
Patch by Brian Anderson <brianderson@chromium.org> on 2012-09-04
Reviewed by James Robinson.
Background extensions had an always ticking compositor even though
they couldn't draw. This patch disables the ticks when canDraw is false
and adds a notification mechanism for when canDraw changes states so
we can recover properly.
Tests updated for new interfaces.
Regression test added to make sure ticking stops when canDraw is false.
notifyIfCanDrawChanged test added to make sure notifications are sent
for any changes that might affect canDraw.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::notifyIfCanDrawChanged):
(WebCore):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::initializeRenderer):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImplClient):
(WebCore::CCLayerTreeHostImpl::resetContentsTexturesPurged):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setCanDraw):
(WebCore):
(WebCore::CCScheduler::processScheduledActions):
- platform/graphics/chromium/cc/CCScheduler.h:
(CCScheduler):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::toString):
(WebCore):
(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(CCSchedulerStateMachine):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::onCanDrawStateChanged):
(WebCore):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
- 10:33 PM Changeset in webkit [127555] by
-
- 2 edits in trunk/Source/WebCore
Remove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp
https://bugs.webkit.org/show_bug.cgi?id=95800
Patch by Adam Barth <abarth@chromium.org> on 2012-09-04
Reviewed by Benjamin Poulain.
This patch is a re-spin of part of the patch from
https://bugs.webkit.org/show_bug.cgi?id=95502, but with the tests
fixed. :)
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):
- 10:14 PM LineBreakingCSS3Mapping edited by
- Fix typo. (diff)
- 10:12 PM Changeset in webkit [127554] by
-
- 4 edits in trunk/Source/JavaScriptCore
Allow the YarrJIT to use the assembler even when useJIT() is false.
Introduce the useYarrJIT() option.
https://bugs.webkit.org/show_bug.cgi?id=95809.
Patch by Mark Lam <mark.lam@apple.com> on 2012-09-04
Reviewed by Geoffrey Garen.
- runtime/JSGlobalData.cpp:
(JSC::enableAssembler):
- runtime/Options.cpp:
(JSC::Options::initialize):
- runtime/Options.h:
(JSC):
- 10:12 PM LineBreakingCSS3Mapping edited by
- Fix typo. (diff)
- 10:08 PM LineBreakingCSS3Mapping edited by
- Expand "Japanse or Chinese" to "Chinese, Japanese, or Korean". (diff)
- 9:53 PM Changeset in webkit [127553] by
-
- 3 edits2 adds in trunk
REGRESSION(r126132): MediaSlider and MediaVolumeSlider thumbs don't match mouse when dragged
https://bugs.webkit.org/show_bug.cgi?id=95701
Reviewed by Kent Tamura.
Source/WebCore:
MediaSlider and MediaVolumeSlider thumbs didn't match mouse when dragged because of the negative margin applied to the thumb.
Test: platform/chromium/media/media-volume-slider-hit-test.html
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint): Account for margins when calculating the position.
LayoutTests:
- platform/chromium/media/media-volume-slider-hit-test-expected.txt: Added.
- platform/chromium/media/media-volume-slider-hit-test.html: Added.
- 9:40 PM Changeset in webkit [127552] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Use explicit constructor in InjectedBundle.
https://bugs.webkit.org/show_bug.cgi?id=95746
Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-04
Reviewed by Sam Weinig.
Added explicit keyword in constructor of InjectedBundle in order to avoid implicit type conversion.
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- 9:27 PM Changeset in webkit [127551] by
-
- 5 edits in trunk/LayoutTests
[Chromium] Update test expectation
https://bugs.webkit.org/show_bug.cgi?id=95395
- platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium/TestExpectations:
- 9:16 PM Changeset in webkit [127550] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectatino update.
- platform/chromium/TestExpectations:
japanese-ruby-vertical-*.html might be flaky on Windows too.
- 9:14 PM Changeset in webkit [127549] by
-
- 3 edits in trunk/Source/WebCore
Add a const version of RenderBox::computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=95787
Reviewed by Ojan Vafai.
After this, we can rename the old computeLogicalHeight to computeAndSetLogicalHeight
to make it clear that it is modifying values.
No new tests, this should just be a refactor.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::constrainLogicalHeightByMinMax): Make const.
(WebCore::RenderBox::computeLogicalHeight): Add a const version that takes a LogicalExtentComputedValues struct for out values.
(WebCore::RenderBox::computeLogicalHeightUsing): Make const.
(WebCore::RenderBox::computeContentLogicalHeightUsing): Make const.
(WebCore::RenderBox::computePercentageLogicalHeight): Add a const cast. I tried to
convert everything below to const, but that's not a simple task. Also, computeReplacedLogicalHeightUsing
is already using a const_cast.
- rendering/RenderBox.h:
(RenderBox): Add const to method signatures.
- 8:57 PM Changeset in webkit [127548] by
-
- 3 edits2 adds in trunk
-webkit-clip-path does not apply origin for polygon()
https://bugs.webkit.org/show_bug.cgi?id=95656
Reviewed by Tim Horton.
Source/WebCore:
The polygon() shape function did not apply origin of bouding box on created path. The shape was
not moved to the correct position.
Tests: svg/clip-path/clip-path-shape-polygon-relative-expected.svg
svg/clip-path/clip-path-shape-polygon-relative.svg
- rendering/style/BasicShapes.cpp:
(WebCore::BasicShapePolygon::path): Apply origin of bounding box.
LayoutTests:
Check that the origin of the bounding box gets applied to the clip path.
- svg/clip-path/clip-path-shape-polygon-relative-expected.svg: Added.
- svg/clip-path/clip-path-shape-polygon-relative.svg: Added.
- 8:45 PM Changeset in webkit [127547] by
-
- 2 edits in trunk/Tools
Have NRWT log more output when crash logs are missing
https://bugs.webkit.org/show_bug.cgi?id=95814
Reviewed by Dan Bernstein.
Log the stderr and stdout of the test, in order to provide slightly more
context when the WebProcess times out while running tests.
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
- 8:33 PM Changeset in webkit [127546] by
-
- 1 edit1 delete in trunk/LayoutTests
[Chromium] Unreviewed test expectations update after r127534
- platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.
- 7:48 PM Changeset in webkit [127545] by
-
- 1 edit1 copy in branches/chromium/1229
Merge 127520 - REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
https://bugs.webkit.org/show_bug.cgi?id=95776
Reviewed by Simon Fraser.
.:
- ManualTests/select-menu-list-wrongly-positioned.html: Added.
Source/WebCore:
r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.
Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.
TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10908086
- 7:36 PM Changeset in webkit [127544] by
-
- 3 edits3 adds in trunk
inc/dec behave incorrectly operating on a resolved const
https://bugs.webkit.org/show_bug.cgi?id=95815
Reviewed by Geoff Garen.
Source/JavaScriptCore:
There are two bugs here.
(1) When the value being incremented is const, and the result is ignored, we assume this cannot be observed, and emit no code.
However if the value being incremented is not a primitive & has a valueOf conversion, then this should be being called.
(2) In the case of a pre-increment of a const value where the result is not ignored, we'll move +/-1 to the destination, then
add the resolved const value being incremented to this. This is problematic if the destination is a local, and the const
value being incremented has a valueOf conversion that throws - the destination will be modified erroneously. Instead, we
need to use a temporary location.
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
- always at least perform a toNumber conversion, use tempDestination when reducing inc/dec to an add +/-1.
LayoutTests:
Added test cases.
- fast/js/inc-const-valueOf-expected.txt: Added.
- fast/js/inc-const-valueOf.html: Added.
- fast/js/script-tests/inc-const-valueOf.js: Added.
(testPostIncConstVarWithIgnoredResult.const.a.valueOf):
(testPostIncConstVarWithIgnoredResult):
test that 'a++' results in a valueOf call, where 'a' is const.
(testPreIncConstVarWithIgnoredResult.const.a.valueOf):
(testPreIncConstVarWithIgnoredResult):
test that '++a' results in a valueOf call, where 'a' is const.
(testPreIncConstVarWithAssign.const.a.valueOf):
(testPreIncConstVarWithAssign):
test that 'b = ++a' does not erroneously update 'b', where 'a' is const.
- 7:28 PM Changeset in webkit [127543] by
-
- 71 edits8 copies1 move25 adds4 deletes in trunk/LayoutTests
[Chromium] Test expectation update
Rebaseline vertical-writing tests.
- platform/chromium-linux-x86/fast/writing-mode/border-vertical-lr-expected.txt: Added.
- platform/chromium-linux-x86/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
- platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Added.
- platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
- platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Added.
- platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Added.
- platform/chromium-linux-x86/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
- platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
- platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png: Added.
- platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.txt: Added.
- platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png: Added.
- platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
- platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png: Added.
- platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
- platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.png: Added.
- platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
- platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt.
- platform/chromium-mac/fast/writing-mode/japanese-lr-selection-expected.png: Added.
- platform/chromium-mac/fast/writing-mode/japanese-rl-selection-expected.png: Added.
- platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
- platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
- platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
- platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
- platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
- platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
- platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
- platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
- platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
- platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt.
- platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
- platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
- platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
- platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt.
- platform/chromium-win-xp/fast/dynamic/text-combine-expected.png:
- platform/chromium-win-xp/fast/dynamic/text-combine-expected.txt: Added.
- platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
- platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.png:
- platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt.
- platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.png:
- platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.txt: Added.
- platform/chromium-win-xp/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- platform/chromium-win-xp/fast/writing-mode/border-vertical-lr-expected.txt: Added.
- platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt:
- platform/chromium-win-xp/fast/writing-mode/fallback-orientation-expected.png:
- platform/chromium-win-xp/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
- platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.png: Removed.
- platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
- platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.png: Removed.
- platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
- platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
- platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
- platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
- platform/chromium-win-xp/fast/writing-mode/vertical-align-table-baseline-expected.png:
- platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.png: Added.
- platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt.
- platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
- platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
- platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
- platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
- platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
- platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
- platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
- platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
- platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
- platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
- platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
- platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
- platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
- platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
- platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
- platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
- platform/chromium-win/fast/dynamic/text-combine-expected.png:
- platform/chromium-win/fast/dynamic/text-combine-expected.txt:
- platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
- platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png:
- platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt:
- platform/chromium-win/fast/text/international/text-spliced-font-expected.png:
- platform/chromium-win/fast/text/international/text-spliced-font-expected.txt:
- platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.png:
- platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.txt:
- platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.png:
- platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt:
- platform/chromium-win/fast/writing-mode/fallback-orientation-expected.png:
- platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.png:
- platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.txt:
- platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.png:
- platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.txt:
- platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.png:
- platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.txt:
- platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.png:
- platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.txt:
- platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
- platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Removed.
- platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
- platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
- platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
- platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
- platform/chromium-win/fast/writing-mode/vertical-align-table-baseline-expected.png:
- platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.png: Added.
- platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.txt:
- platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
- platform/chromium/TestExpectations:
- 6:55 PM Changeset in webkit [127542] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Some flaky media/video tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95806
- platform/win/Skipped:
- 6:45 PM Changeset in webkit [127541] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Some flaky http/tests/cookies tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95805
- platform/win/Skipped:
- 6:43 PM Changeset in webkit [127540] by
-
- 7 edits in trunk/Source
Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
https://bugs.webkit.org/show_bug.cgi?id=95798
Patch by Adam Barth <abarth@chromium.org> on 2012-09-04
Reviewed by Eric Seidel.
Source/WebCore:
This patch makes the chromium-linux port build without
WTF::String::operator+=. There are a couple places that require some
more careful study, and I've whitelisted those uses by defining
WTF_DEPRECATED_STRING_OPERATORS at the top of the files. (See
https://bugs.webkit.org/show_bug.cgi?id=95797 for an explanation of
WTF_DEPRECATED_STRING_OPERATORS.)
- css/StylePropertySet.cpp:
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::drawNodeHighlight):
- platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::rewriteMixVertexShader):
Source/WebKit/chromium:
- src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::keyboardShortcut):
- Remove use of WTF::String::operator+=
- src/WebPageSerializerImpl.cpp:
- Whitelist use of WTF::String::operator+=. Remove this use will take some more careful thought.
- 6:38 PM Changeset in webkit [127539] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Some flaky http/tests/security tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95803
- platform/win/Skipped:
- 6:31 PM Changeset in webkit [127538] by
-
- 3 edits in trunk/Source/WebCore
Use TrackedRendererListHashSet typedef for percentHeightDescendants()
https://bugs.webkit.org/show_bug.cgi?id=95791
Reviewed by Ojan Vafai.
There were a couple callers that were using ListHashSet<RenderBox*> instead of the typedef.
No new tests, this is just a refactor.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
- rendering/RenderView.cpp:
(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
- 6:30 PM Changeset in webkit [127537] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Some flaky inspector tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95802
- platform/win/Skipped:
- 6:27 PM Changeset in webkit [127536] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
https://bugs.webkit.org/show_bug.cgi?id=95717
Reviewed by Oliver Hunt.
Rolling back in after fixing the negative index case.
Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
there so we should just use it!
- bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 5:56 PM Changeset in webkit [127535] by
-
- 13 edits3 deletes in trunk/Source
IndexedDB: remove final createIndex backend glue
https://bugs.webkit.org/show_bug.cgi?id=95385
Patch by Alec Flett <alecflett@chromium.org> on 2012-09-04
Reviewed by Adam Barth.
Source/WebCore:
Remove all code that created index keys in the IndexedDB backend.
No new tests, this is just removal of dead code.
- Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Removed.
- Modules/indexeddb/IDBKeyPathBackendImpl.h: Removed.
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore):
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- storage/chromium/IDBKeyPathBackendImpl.cpp: Removed.
Source/WebKit/chromium:
Remove chromium glue for old key-generation code.
- public/WebIDBKey.h:
(WebIDBKey):
- src/WebIDBKey.cpp:
- 5:40 PM Changeset in webkit [127534] by
-
- 8 edits1 copy4 adds in trunk
Frame element doesn't always unload its child frame.
https://bugs.webkit.org/show_bug.cgi?id=94717
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2012-09-04
Reviewed by Hajime Morita.
Source/WebCore:
It's possible for a frame element that has been removed from the document
to retain an active child frame. This inconsistent state may become a source
of security vulnerabilities.
The patch adds a global HashSet to store the nodes currently processed by
ChildFrameDisconnector. Insertion into these nodes' subtrees is not allowed until
the processing is complete.
Also, the ChildFrameDisconnector call in removeChild(ren) is now immediately
followed by the actual removal.
Test: fast/frames/out-of-document-iframe-has-child-frame.html
- dom/ContainerNode.cpp:
(WebCore::willRemoveChildren): Move the ChildFrameDisconnector call out of a loop.
(WebCore::ContainerNode::removeChild): Rearrange some event firing code.
(WebCore::ContainerNode::removeChildren): Ditto.
- dom/ContainerNodeAlgorithms.cpp:
(WebCore::ChildFrameDisconnector::collectDescendant): Pass a new parameter to collectDescendant(Node*).
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(ChildFrameDisconnector): Maintain a list of nodes that have an active ChildFrameDisconnector.
(WebCore::ChildFrameDisconnector::~ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::rootNodes):
(WebCore::ChildFrameDisconnector::collectDescendant): Add ShouldIncludeRoot parameter.
(WebCore::ChildFrameDisconnector::nodeHasDisconnector):
(WebCore):
- dom/Node.cpp:
(WebCore::checkAcceptChild): Reject a parent node if it or one of its parents has an active ChildFrameDisconnector.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Check if an element is still in the document.
LayoutTests:
- fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
- fast/frames/out-of-document-iframe-has-child-frame.html: Added.
- fast/innerHTML/innerHTML-iframe-expected.txt:
- platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
- platform/chromium/fast/innerHTML: Added.
- platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
- 5:28 PM Changeset in webkit [127533] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectation update after r127457
- platform/chromium/TestExpectations:
- 5:25 PM Changeset in webkit [127532] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Adding test inspector/timeline/timeline-decode-resize.html to Windows skip list.
It fails on both Windows and Mac: https://bugs.webkit.org/show_bug.cgi?id=94374.
- platform/win/Skipped:
- 5:23 PM Changeset in webkit [127531] by
-
- 4 edits in branches/safari-536.26-branch/Source
Versioning.
- 5:21 PM Changeset in webkit [127530] by
-
- 1 copy in tags/Safari-536.26.13
New tag.
- 5:21 PM Changeset in webkit [127529] by
-
- 1 delete in tags/Safari-536.26.13
Remove tag.
- 5:18 PM Changeset in webkit [127528] by
-
- 1 edit in branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
Build fix.
- 5:09 PM Changeset in webkit [127527] by
-
- 7 edits in trunk/LayoutTests
Unreviewed. Rebaseline tests after http://trac.webkit.org/changeset/127354.
- platform/win/fast/text/international/text-spliced-font-expected.txt:
- platform/win/fast/writing-mode/border-vertical-lr-expected.txt:
- platform/win/fast/writing-mode/japanese-lr-selection-expected.txt:
- platform/win/fast/writing-mode/japanese-lr-text-expected.txt:
- platform/win/fast/writing-mode/japanese-rl-selection-expected.txt:
- platform/win/fast/writing-mode/japanese-rl-text-expected.txt:
- 5:07 PM Changeset in webkit [127526] by
-
- 2 edits in trunk/Source/Platform
[Chromium] Attempt to fix build failure on Win
Remove chromium/public/WebOfferAnswerRequest.h from Platform.gypi,
which was added in r127501, but doesn't exist. Unreviewed.
- Platform.gypi:
- 4:58 PM Changeset in webkit [127525] by
-
- 19 edits1 move in trunk/Source
Part 1 of removing PlatformString.h, move remaining functions to new homes
https://bugs.webkit.org/show_bug.cgi?id=95702
Reviewed by Beth Dakin.
Source/WebCore:
Move utf8Buffer() to SharedBuffer.h/cpp
Move numGraphemeClusters() and numCharactersInGraphemeClusters() to TextBreakIterator.h/cpp
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Update projects.
- platform/text/TextAllInOne.cpp:
Add TextBreakIterator.cpp.
- editing/Editor.h:
Forward declare SharedBuffer, now that PlatformString.h doesn't.
- html/InputType.cpp:
#include TextBreakIterator.h.
- loader/appcache/ApplicationCacheStorage.h:
Replace inclusion of PlatformString.h with WTFString.h and forward declare SharedBuffer.
- platform/LocalizedStrings.cpp:
Replace inclusion of PlatformString.h with TextBreakIterator.h
- platform/SharedBuffer.cpp:
- platform/SharedBuffer.h:
Move utf8Buffer() here.
- platform/text/PlatformString.h:
Remove everything except the #include of WTFString.h.
- platform/text/TextBreakIterator.cpp: Renamed from Source/WebCore/platform/text/String.cpp.
(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):
- platform/text/TextBreakIterator.h:
Move numGraphemeClusters() and numCharactersInGraphemeClusters() here.
Source/WebKit2:
- UIProcess/WebPageProxy.h:
Forward declare SharedBuffer.
- 4:56 PM Changeset in webkit [127524] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebKit2
Merge r127319.
- 4:56 PM Changeset in webkit [127523] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebKit2
Merge r127272.
- 4:56 PM Changeset in webkit [127522] by
-
- 9 edits2 adds in branches/safari-536.26-branch
Merge r127047.
- 4:45 PM Changeset in webkit [127521] by
-
- 1 copy in tags/Safari-536.26.13
New tag.
- 4:39 PM Changeset in webkit [127520] by
-
- 3 edits1 add in trunk
REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
https://bugs.webkit.org/show_bug.cgi?id=95776
Reviewed by Simon Fraser.
.:
- ManualTests/select-menu-list-wrongly-positioned.html: Added.
Source/WebCore:
r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.
Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.
- 4:34 PM Changeset in webkit [127519] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows since introduced in http://trac.webkit.org/changeset/126865.
Test added to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95795
- platform/win/Skipped:
- 4:34 PM Changeset in webkit [127518] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired
https://bugs.webkit.org/show_bug.cgi?id=95777
Reviewed by Tony Chang.
IDBRequests are kept alive as long as they may fire events, which includes
if the associated IDBCursor object can be advanced. When the transaction
is finished the IDBCursor is notified which in turn tells the IDBRequest
that the cursor won't be the source of more events. However, if this occurs
and no further events fire the IDBRequest doesn't clear it's "has pending
activity flag". Clear the flag on the notification if the request is
otherwise complete.
No new tests - ActiveDOMObjects and leaks are persnickety.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::finishCursor):
- 3:53 PM Changeset in webkit [127517] by
-
- 3 edits3 adds in trunk
[CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion blend modes.
https://bugs.webkit.org/show_bug.cgi?id=93870
Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-04
Reviewed by Dirk Schulze.
Source/WebCore:
Add expressions for the aforementioned blend modes. The expressions are lifted directly
from the CSS Compositing and Blending spec [1]. WebKit adds these blending expressions to
the author's shader.
[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnormal
Test: css3/filters/custom/custom-filter-blend-modes.html
- platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::blendFunctionString):
LayoutTests:
Add test to check that the DOM element texture blends correctly with the css_MixColor
variable from the author's shader for each blend mode.
- css3/filters/custom/custom-filter-blend-modes-expected.html: Added.
- css3/filters/custom/custom-filter-blend-modes.html: Added.
- css3/filters/resources/mix-color.fs: Added.
- 3:34 PM Changeset in webkit [127516] by
-
- 8 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r127503.
http://trac.webkit.org/changeset/127503
https://bugs.webkit.org/show_bug.cgi?id=95788
broke some tests (fast/js/dfg-negative-array-index, fast/js
/dfg-put-by-val-setter-then-get-by-val) (Requested by thorton
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-04
- bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 3:27 PM Changeset in webkit [127515] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] FatFingers::cachingStrategy uses incorrect enum value
https://bugs.webkit.org/show_bug.cgi?id=95783
Reviewed by Antonio Gomes.
Use the correct enum values.
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::cachingStrategy):
- 3:22 PM Changeset in webkit [127514] by
-
- 2 edits in trunk/Source/WebCore
Fix style for Event.h
https://bugs.webkit.org/show_bug.cgi?id=95779
Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-09-04
Reviewed by Eric Seidel.
Changes indenting for Event.h to match style guidelines for namespaces
- dom/Event.h:
- 3:20 PM Changeset in webkit [127513] by
-
- 6 edits12 adds in trunk
Make plugins respect third-party storage blocking setting
https://bugs.webkit.org/show_bug.cgi?id=94888
Reviewed by Brady Eidson.
Source/WebCore:
Added functions for discerning if a plugin should be able to access its storage in its current origin.
Tests: http/tests/security/cross-origin-plugin-allowed.html
http/tests/security/cross-origin-plugin.html
- WebCore.exp.in: Export FrameTree::top and SecurityOrigin::canAccessStorage
- page/SecurityOrigin.h: Added canAccessPluginStorage
(WebCore::SecurityOrigin::canAccessPluginStorage):
Source/WebKit2:
Plugins that are in a third-party context should be put into private browsing mode so their storage is temporary.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::isPrivateBrowsingEnabled): Put the plugin into private browsing mode if it is in a third-party context.
(WebKit::PluginView::privateBrowsingStateChanged): Make sure a plugin doesn't leave private browsing mode if it's in a third-party context.
LayoutTests:
Created tests for plugins in a third party and first party context when third-party blocking is on and off.
- http/tests/security/cross-origin-plugin-allowed-expected.txt: Added.
- http/tests/security/cross-origin-plugin-allowed.html: Added.
- http/tests/security/cross-origin-plugin-expected.txt: Added.
- http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed-expected.txt: Added.
- http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html: Added.
- http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.
- http/tests/security/cross-origin-plugin-private-browsing-toggled.html: Added.
- http/tests/security/cross-origin-plugin.html: Added.
- http/tests/security/resources/cross-origin-iframe-for-plugin.html: Added.
- http/tests/security/resources/cross-origin-iframe-for-plugin-async.html: Added.
- platform/mac-wk2/http/tests/security/cross-origin-plugin-expected.txt: Added.
- platform/mac-wk2/http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.
- 3:14 PM Changeset in webkit [127512] by
-
- 3 edits in trunk/Tools
[Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
https://bugs.webkit.org/show_bug.cgi?id=95770
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._log_error): Added to replace original _log.error().
(ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
(ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
(ChromiumAndroidDriver._push_executable):
(ChromiumAndroidDriver._push_fonts):
(ChromiumAndroidDriver._push_test_resources):
(ChromiumAndroidDriver._run_adb_command):
(ChromiumAndroidDriver._get_last_stacktrace):
(ChromiumAndroidDriver._get_crash_log):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._start_once):
(ChromiumAndroidDriver._start_once.deadlock_detector):
- Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidDriverTest.test_get_crash_log):
- 3:14 PM Changeset in webkit [127511] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Rebaseline Windows expected results for accessibility\canvas-description-and-role-expected.txt.
One of the results in the test now passes.
- platform/win/accessibility/canvas-description-and-role-expected.txt:
- 2:48 PM Changeset in webkit [127510] by
-
- 4 edits in trunk/LayoutTests
Unreviewed. Update test expectations for Android.
- platform/chromium-android/TestExpectations:
- platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
- platform/chromium/TestExpectations:
- 2:35 PM Changeset in webkit [127509] by
-
- 3 edits2 adds in trunk
Regression(r127163): Heap-use-after-free in WebCore::RenderBoxModelObject::hasSelfPaintingLayer
https://bugs.webkit.org/show_bug.cgi?id=95632
Reviewed by Abhishek Arya.
Source/WebCore:
Don't add floats to the floating object set of blocks that avoid floats. There's no point in doing that
and they will never get cleared out during relayout.
Tests: fast/css/intruding-floats-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloatsIfNeeded):
LayoutTests:
- fast/css/intruding-floats-crash-expected.txt: Added.
- fast/css/intruding-floats-crash.html: Added.
- 2:32 PM Changeset in webkit [127508] by
-
- 3 edits2 adds in trunk
equal() in CSSParser.cpp should check the length of characters
https://bugs.webkit.org/show_bug.cgi?id=95706
Source/WebCore:
Reviewed by Abhishek Arya.
Pass the length of string literals to CSSParser static functions equal() and
equalIgnoringCase() so that checks won't access out of bounds memory.
Added test fast/css/crash-comparing-equal.html.
- css/CSSParser.cpp:
(WebCore::equal): Use template to retrieve the length of string literal.
(WebCore::equalIgnoringCase): Ditto.
(WebCore::CSSParser::parseDashboardRegions): Use const char[] instead of const char*
LayoutTests:
Added test from duplicate defect https://bugs.webkit.org/show_bug.cgi?id=95634.
Reviewed by Abhishek Arya.
- fast/css/crash-comparing-equal-expected.txt: Added.
- fast/css/crash-comparing-equal.html: Added.
- 2:23 PM Changeset in webkit [127507] by
-
- 2 edits in trunk/Tools
Run git commands within the checkout directory
https://bugs.webkit.org/show_bug.cgi?id=95742
Reviewed by Eric Seidel.
git commands run from scm/git.py are sometimes run with cwd set to the
checkout_root and other times with whatever directory was the default cwd.
Instead all these should run with the checkout root set as the cwd
(except where we explicitly need a different path)
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git._run_git):
(Git.find_checkout_root):
(Git.discard_local_commits):
(Git.local_commits):
(Git.working_directory_is_clean):
(Git.clean_working_directory):
(Git.add_list):
(Git.delete_list):
(Git.exists):
(Git._current_branch):
(Git._changes_files_for_commit):
(Git.revisions_changing_file):
(Git.svn_revision):
(Git._run_git_svn_find_rev):
(Git.contents_at_revision):
(Git.diff_for_file):
(Git.show_head):
(Git.committer_email_for_revision):
(Git.apply_reverse_diff):
(Git.revert_files):
(Git.commit_with_message):
(Git._commit_on_branch):
(Git.svn_commit_log):
(Git.last_svn_commit_log):
(Git.svn_blame):
(Git._branch_ref_exists):
(Git.delete_branch):
(Git.remote_merge_base):
(Git.commit_locally_with_message):
(Git.push_local_commits_to_server):
(Git.commit_ids_from_commitish_arguments):
(Git.commit_message_for_local_commit):
(Git.files_changed_summary_for_commit):
- 2:21 PM Changeset in webkit [127506] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. meda/video-controls-captions.html fails on Windows after it was introduced in http://trac.webkit.org/changeset/127035.
https://bugs.webkit.org/show_bug.cgi?id=95428
- platform/win/Skipped:
- 2:19 PM Changeset in webkit [127505] by
-
- 39 edits in trunk/Source/JavaScriptCore
Improve JSC use of Strings after the UString->String change
https://bugs.webkit.org/show_bug.cgi?id=95633
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-04
Reviewed by Geoffrey Garen.
This patch improve the use of strings in the JSC runtime.
The initialization of Identifier is left for future patches.
The improvements are the following:
-5% faster to raise one of the modified exception.
-3 times faster to execute Boolean::toString()
Most of the changes are just about using the new methods
for string literals.
With the changes, the binary on x86_64 gets 176 bytes smaller.
- API/JSCallbackObjectFunctions.h:
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):
- API/JSContextRef.cpp:
(JSContextCreateBacktrace):
- API/JSObjectRef.cpp:
(JSObjectMakeFunctionWithCallback):
- bytecode/CodeBlock.cpp:
(JSC::valueToSourceString):
(JSC::CodeBlock::nameForRegister):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::addStackTraceIfNecessary):
- runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
- runtime/ArrayPrototype.cpp:
(JSC::shift):
(JSC::unshift):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
- runtime/BooleanPrototype.cpp:
(JSC::booleanProtoFuncToString): Instead of instanciating new strings, reuse the
keywords available in SmallStrings. Avoiding the creation of the JSString and StringImpl
makes the method significantly faster.
- runtime/DateConversion.cpp:
(JSC::formatDateTime):
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
(JSC::formateDateInstance):
(JSC::dateProtoFuncToISOString):
Change the way we use snprintf() for clarity and performance.
Instead of allocating one extra byte to put a zero "just in case", we use the size returned
by snprintf().
To prevent any overflow from a programming mistake, we explicitely test for overflow and
return an empty string.
(JSC::dateProtoFuncToJSON):
- runtime/Error.cpp:
(JSC::createNotEnoughArgumentsError):
(JSC::throwTypeError):
(JSC::throwSyntaxError):
- runtime/Error.h:
(JSC::StrictModeTypeErrorFunction::create):
- runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::finishCreation):
(JSC::errorProtoFuncToString):
Using a null String is correct because (8) uses jsString(), (9) tests for a length of 0.
- runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
(JSC::createStackOverflowError):
(JSC::createOutOfMemoryError):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::FunctionExecutable::paramString):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::create):
Using a null String for the name is correct because InternalFunction uses jsString()
to create the name value.
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::finishCreation):
There is no need to create an empty string for a null string, jsString() handle both
cases as empty JSString.
- runtime/JSArray.cpp:
(JSC::reject):
(JSC::SparseArrayValueMap::put):
(JSC::JSArray::put):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
- runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation): Same issue as InternalFunction::finishCreation.
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::defineOwnProperty):
- runtime/JSGlobalData.cpp:
(JSC::enableAssembler): Use CFSTR() instead of CFStringCreateWithCString().
CFStringCreateWithCString() copy the content and may choose to decode the data.
CFSTR() is much more efficient.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
JSFunction uses jsString() to create the name, we can use null strings instead
of creating empty strings.
(JSC::JSGlobalObject::createThrowTypeError): ditto.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEval):
- runtime/JSONObject.cpp:
(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::defaultValue):
(JSC::JSObject::hasInstance):
(JSC::JSObject::defineOwnProperty):
- runtime/JSString.cpp:
Return an empty JSString to avoid the creation of a temporary empty String.
(JSC::JSRopeString::getIndexSlowCase):
- runtime/JSString.h:
(JSC): Remove the versions of jsNontrivialString() taking a char*. All the callers
have been replaced by calls using ASCIILiteral.
- runtime/JSValue.cpp:
(JSC::JSValue::putToPrimitive):
- runtime/LiteralParser.cpp:
(JSC::::Lexer::lex):
(JSC::::Lexer::lexString):
(JSC::::Lexer::lexNumber):
(JSC::::parse):
- runtime/LiteralParser.h:
(JSC::LiteralParser::getErrorMessage):
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
(JSC::objectConstructorIsExtensible):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncToString):
- runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
- runtime/RegExpObject.cpp:
(JSC::reject):
(JSC::regExpObjectSource):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
- runtime/StringObject.cpp:
(JSC::StringObject::defineOwnProperty):
- runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):
- 2:16 PM Changeset in webkit [127504] by
-
- 4 edits in branches/safari-536.26-branch/Source
Versioning.
- 2:15 PM Changeset in webkit [127503] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
https://bugs.webkit.org/show_bug.cgi?id=95717
Reviewed by Oliver Hunt.
Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
there so we should just use it!
- bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 2:10 PM Changeset in webkit [127502] by
-
- 12 edits in trunk/Source
[BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
https://bugs.webkit.org/show_bug.cgi?id=95778
PR #202252
Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Arvid Nilsson.
Upstream has switch away from using the parent scroll layer's bounds origin
in order to translate contents of all its child layers. Instead now, it directly
sets the scroll position of the child scrollable contents layer.
Source/WebCore:
No new tests, since it is a catch-up with upstreaming code.
Source/WebCore:
- platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore):
- platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(GraphicsLayerBlackBerry):
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::updateAnimations):
- platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerOverride::LayerOverride):
(LayerOverride):
- platform/graphics/blackberry/LayerData.h:
(LayerData):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::updateLayersRecursive):
- platform/graphics/blackberry/LayerWebKitThread.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
Source/WebKit/blackberry:
Source/WebKit/blackberry:
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
No new tests, since it is a catch-up with upstreaming code.
- 2:02 PM Changeset in webkit [127501] by
-
- 19 edits7 copies6 adds in trunk
MediaStream API: Add the async createOffer functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95734
Reviewed by Adam Barth.
Source/Platform:
- Platform.gypi:
- chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
- chromium/public/WebRTCSessionDescriptionDescriptor.h: Added.
(WebCore):
(WebKit):
(WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::~WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::operator=):
(WebKit::WebRTCSessionDescriptionDescriptor::isNull):
- chromium/public/WebRTCSessionDescriptionRequest.h: Added.
(WebCore):
(WebKit):
(WebRTCSessionDescriptionRequest):
(ExtraData):
(WebKit::WebRTCSessionDescriptionRequest::ExtraData::~ExtraData):
(WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::~WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::operator=):
(WebKit::WebRTCSessionDescriptionRequest::isNull):
Source/WebCore:
createOffer sends a request to the platform implementer requesting it to gather up all candidates.
This can take some time, therefore the request is async.
Test: fast/mediastream/RTCPeerConnection-createOffer.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/RTCErrorCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
(WebCore):
(RTCErrorCallback):
(WebCore::RTCErrorCallback::~RTCErrorCallback):
- Modules/mediastream/RTCErrorCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createOffer):
(WebCore):
- Modules/mediastream/RTCPeerConnection.h:
(WebCore):
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCSessionDescriptionCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
(WebCore):
(RTCSessionDescriptionCallback):
(WebCore::RTCSessionDescriptionCallback::~RTCSessionDescriptionCallback):
- Modules/mediastream/RTCSessionDescriptionCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
- Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp: Added.
(WebCore):
(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::stop):
(WebCore::RTCSessionDescriptionRequestImpl::clear):
- Modules/mediastream/RTCSessionDescriptionRequestImpl.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
(WebCore):
(RTCSessionDescriptionRequestImpl):
- WebCore.gypi:
- platform/chromium/support/WebRTCSessionDescriptionDescriptor.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.
(WebKit):
(WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::assign):
(WebKit::WebRTCSessionDescriptionDescriptor::reset):
(WebKit::WebRTCSessionDescriptionDescriptor::operator WTF::PassRefPtr<WebCore::RTCSessionDescriptionDescriptor>):
(WebKit::WebRTCSessionDescriptionDescriptor::initialize):
(WebKit::WebRTCSessionDescriptionDescriptor::type):
(WebKit::WebRTCSessionDescriptionDescriptor::setType):
(WebKit::WebRTCSessionDescriptionDescriptor::sdp):
(WebKit::WebRTCSessionDescriptionDescriptor::setSDP):
- platform/chromium/support/WebRTCSessionDescriptionRequest.cpp: Added.
(WebKit):
(WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::assign):
(WebKit::WebRTCSessionDescriptionRequest::reset):
(WebKit::WebRTCSessionDescriptionRequest::requestSucceeded):
(WebKit::WebRTCSessionDescriptionRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCSessionDescriptionRequest::extraData):
(WebKit::WebRTCSessionDescriptionRequest::setExtraData):
- platform/mediastream/RTCPeerConnectionHandler.cpp:
(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::createOffer):
(WebCore):
- platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(RTCPeerConnectionHandler):
- platform/mediastream/RTCSessionDescriptionDescriptor.h:
(WebCore::RTCSessionDescriptionDescriptor::type):
(WebCore::RTCSessionDescriptionDescriptor::sdp):
- platform/mediastream/RTCSessionDescriptionRequest.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
(WebCore):
(RTCSessionDescriptionRequest):
(ExtraData):
(WebCore::RTCSessionDescriptionRequest::ExtraData::~ExtraData):
(WebCore::RTCSessionDescriptionRequest::~RTCSessionDescriptionRequest):
(WebCore::RTCSessionDescriptionRequest::extraData):
(WebCore::RTCSessionDescriptionRequest::setExtraData):
(WebCore::RTCSessionDescriptionRequest::RTCSessionDescriptionRequest):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::createOffer):
(WebCore):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):
Tools:
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::createOffer):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::taskList):
(SuccessCallbackTask):
(FailureCallbackTask):
LayoutTests:
- fast/mediastream/RTCPeerConnection-createOffer-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-createOffer.html: Added.
- 1:58 PM Changeset in webkit [127500] by
-
- 12 edits in trunk
Reverted r127468 (the fix for <http://webkit.org/b/93443>) because the test it included caused
an assertion failure in Document::updateStyleIfNeeded().
Source/WebCore:
- dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
LayoutTests:
- inspector/styles/protocol-css-regions-commands-expected.txt:
- inspector/styles/protocol-css-regions-commands.html:
- 1:41 PM Changeset in webkit [127499] by
-
- 1 copy in tags/Safari-536.26.12
New Tag.
- 1:35 PM Changeset in webkit [127498] by
-
- 9 edits2 deletes in branches/safari-536.26-branch
Rollout 127252.
- 1:34 PM Changeset in webkit [127497] by
-
- 4 edits2 adds in trunk
Regression: Heap-use-after-free in WebCore::FrameView::scrollContentsFastPath
https://bugs.webkit.org/show_bug.cgi?id=95754
Reviewed by Dave Hyatt.
Source/WebCore:
It's possible to have a renderer with position:fixed or sticky style,
but no layer, for example a RenderScrollBarPart. Don't register such
renderers with the FrameView.
Moved the code that registers/unregisters with the FrameView from
styleWillChange() to styleDidChange(), since in the latter case
we can check if we have a RenderLayer. Only register renderers with layers.
We always unregister, which required removing an assertion in
FrameView::removeFixedObject(), and replacing it with a null check of m_fixedObjects.
Test: fast/css/remove-fixed-resizer-crash.html
- page/FrameView.cpp:
(WebCore::FrameView::removeFixedObject):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleWillChange):
(WebCore::RenderBoxModelObject::styleDidChange):
LayoutTests:
Testcase with a position:fixed resizer and scrolling.
- fast/css/remove-fixed-resizer-crash-expected.txt: Added.
- fast/css/remove-fixed-resizer-crash.html: Added.
- 1:30 PM Changeset in webkit [127496] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebKit2
Rollout r127276.
- 1:30 PM Changeset in webkit [127495] by
-
- 3 edits in trunk/Source/WebCore
ResourceErrorBase needs to identify timeouts
https://bugs.webkit.org/show_bug.cgi?id=95755
Reviewed by Alexey Proskuryakov.
Adding a property to check whether this ResourceError was raised due to a timeout.
This is preparatory work for bug 74802. In order to implement XHR2 timeout functionality,
I need to identify some layers up whether the original network problem has been a timeout.
No new tests, no change in behavior yet.
- platform/network/ResourceErrorBase.cpp:
(WebCore::ResourceErrorBase::copy): Copying new member.
(WebCore::ResourceErrorBase::compare): Comparing new member.
- platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::setIsTimeout): New setter.
(WebCore::ResourceErrorBase::isTimeout): New getter.
(ResourceErrorBase),
(WebCore::ResourceErrorBase::ResourceErrorBase): Adding m_isTimeout member.
- 1:25 PM Changeset in webkit [127494] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Rename WebViewClient::handleDisambiguationPopup
https://bugs.webkit.org/show_bug.cgi?id=95529
Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-09-04
Reviewed by Adam Barth.
Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it.
- public/WebViewClient.h:
(WebKit::WebViewClient::didTapMultipleTargets):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
- tests/WebFrameTest.cpp:
- 1:22 PM Changeset in webkit [127493] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix memory leak in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=95771
Reviewed by Rob Buis.
Simply delete the arrays at function exit.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):
- 1:18 PM Changeset in webkit [127492] by
-
- 4 edits in trunk/Source
Versioning.
- 1:14 PM Changeset in webkit [127491] by
-
- 9 edits in trunk/LayoutTests
Unreviewed. Removing accidentally added executable properties on test files.
- platform/win/accessibility/canvas-description-and-role-expected.txt: Removed property svn:executable.
- platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed property svn:executable.
- platform/win/fast/css/image-resolution/image-resolution-expected.txt: Removed property svn:executable.
- platform/win/fast/css/image-set-setting-expected.txt: Removed property svn:executable.
- platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt: Removed property svn:executable.
- platform/win/fast/css/variables/build-supports-variables-expected.txt: Removed property svn:executable.
- platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Removed property svn:executable.
- platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Removed property svn:executable.
- 1:05 PM Changeset in webkit [127490] by
-
- 1 copy in tags/Safari-537.8/trunk
New Tag.
- 1:03 PM Changeset in webkit [127489] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
https://bugs.webkit.org/show_bug.cgi?id=95766
Reviewed by Rob Buis.
Passing the frame status through will allow the client to make better
decisions about how to act on the onload.
- Api/WebPageClient.h:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):
- 12:59 PM Changeset in webkit [127488] by
-
- 2 edits in trunk/Tools
[Chromium-Android] Output time and thread info in crash log
https://bugs.webkit.org/show_bug.cgi?id=95768
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
- 12:48 PM Changeset in webkit [127487] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Remove use of deprecated QInputMethod method
https://bugs.webkit.org/show_bug.cgi?id=95741
Patch by Pekka Vuorela <pvuorela@iki.fi> on 2012-09-04
Reviewed by Simon Hausmann.
Adapt from deprecated QInputMethod::visible() to isVisible().
- UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::setInputPanelVisible):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
- 12:46 PM Changeset in webkit [127486] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Provide virtual dtor for DumpRenderTreeClient
https://bugs.webkit.org/show_bug.cgi?id=95769
Reviewed by NOBODY (OOPS!).
Also remove WTF prefixes.
- Api/DumpRenderTreeClient.h:
- 12:43 PM Changeset in webkit [127485] by
-
- 16 edits in trunk
MediaStream API: Change the MediaStreamTrackList track added/removed signaling
https://bugs.webkit.org/show_bug.cgi?id=95721
Reviewed by Adam Barth.
Source/Platform:
Adding the signaling to the WebKit interface.
- chromium/public/WebMediaStreamCenter.h:
(WebKit::WebMediaStreamCenter::didAddMediaStreamTrack):
(WebKit::WebMediaStreamCenter::didRemoveMediaStreamTrack):
Source/WebCore:
This allows the platform implementor to throw an NOT_SUPPORTED_ERR exception if it doesn support these methods.
Patch covered by expanded existing test.
- Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):
- platform/mediastream/MediaStreamCenter.h:
(MediaStreamCenter):
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
(WebCore::MediaStreamCenterBlackBerry::didAddMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenterBlackBerry::didRemoveMediaStreamTrack):
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
(MediaStreamCenterBlackBerry):
- platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
(WebCore::MediaStreamCenterChromium::didAddMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::didRemoveMediaStreamTrack):
- platform/mediastream/chromium/MediaStreamCenterChromium.h:
(MediaStreamCenterChromium):
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
(WebCore::MediaStreamCenterGStreamer::didAddMediaStreamTrack):
(WebCore::MediaStreamCenterGStreamer::didRemoveMediaStreamTrack):
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
(MediaStreamCenterGStreamer):
Tools:
- DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
(MockWebMediaStreamCenter::didAddMediaStreamTrack):
(MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
- DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
(MockWebMediaStreamCenter):
LayoutTests:
- fast/mediastream/MediaStreamTrackList.html:
- 12:35 PM Changeset in webkit [127484] by
-
- 13 edits in trunk/Source
Extend the coverage of the Custom Allocation Framework in WTF and in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=95737
Reviewed by Eric Seidel.
Add WTF_MAKE_FAST_ALLOCATED macro to the following class declarations because these are instantiated by operator new.
Source/JavaScriptCore:
- wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.
- heap/MachineStackMarker.cpp:
(MachineThreads::Thread): Thread is instantiated at heap/MachineStackMarker.cpp:196.
- jit/ExecutableAllocatorFixedVMPool.cpp:
(FixedVMPoolExecutableAllocator): FixedVMPoolExecutableAllocator is instantiated at jit/ExecutableAllocatorFixedVMPool.cpp:111
- parser/SourceProviderCache.h:
(SourceProviderCache): SourceProviderCache is instantiated at parser/SourceProvider.h:49.
- parser/SourceProviderCacheItem.h:
(SourceProviderCacheItem): SourceProviderCacheItem is instantiated at parser/Parser.cpp:843.
- runtime/GCActivityCallback.h:
(GCActivityCallback): GCActivityCallback is instantiated at runtime/GCActivityCallback.h:96.
- tools/CodeProfile.h:
(CodeProfile): CodeProfile is instantiated at JavaScriptCore/tools/CodeProfiling.cpp:140.
Source/WTF:
- wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.
- wtf/MediaTime.h: MediaTime is instantiated at wtf/MediaTime.cpp:288.
- wtf/MetaAllocator.h:
(MetaAllocatorTracker): MetaAllocatorTracker is instantiated at JavaScriptCore/tools/CodeProfiling.cpp:120.
- wtf/ThreadingPthreads.cpp:
(PthreadState): PthreadState is instantiated at wtf/ThreadingPthreads.cpp:165.
- wtf/text/AtomicString.cpp:
(AtomicStringTable): AtomicStringTable is instantiated at wtf/text/AtomicString.cpp:43.
- 12:27 PM WebKitGTK/1.10.x edited by
- (diff)
- 12:23 PM Changeset in webkit [127483] by
-
- 4 edits in trunk/Source
[GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
https://bugs.webkit.org/show_bug.cgi?id=95740
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.
Source/WebCore:
Added sanity check to be sure we have a render object prior to seeing if
said object is an anonymous block.
Testing via unit test because a non-flaky layout test crasher could not
be found.
- accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Sanity check for render object added.
Source/WebKit/gtk:
Updated unit test.
- tests/testatk.c:
(testWebkitAtkComboBox): Added checks that the menu popup in a combo box
has 0 links and, more importantly, that checking doesn't result in a crash.
- 12:11 PM Changeset in webkit [127482] by
-
- 2 edits in trunk/Tools
Elide test names when running new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=95626
Patch by Tony Chang <tony@chromium.org> on 2012-09-04
Reviewed by Dirk Pranke.
When the test name exceeds the number of terminal columns, it leaves
text on the screen. Avoid this by eliding the test name when running
tests. This is similar to what ninja does when compiling.
- Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream):
(MeteredStream.number_of_columns): Helper method to get number of
terminal columns. Won't work on Win32 python, but meh.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
because stderr appears to be ascii only.
(Printer.print_started_test): Route through _test_status_line.
(Printer.print_finished_test): Route through _test_status_line.
(Printer._print_test_trace): Route through _test_status_line.
(Printer._print_baseline): Route through _test_status_line.
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(test_test_status_line): Test for _test_status_line.
- 11:58 AM Changeset in webkit [127481] by
-
- 3 edits2 moves3 adds3 deletes in trunk
Automatic features should work in sandboxed iframes if "allow-scripts" flag is set
https://bugs.webkit.org/show_bug.cgi?id=93961
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-04
Reviewed by Adam Barth.
Source/WebCore:
Allow automatic features (video autoplay and form control
autofocus) in a sandboxed iframe that has "allow-scripts"
flag set. This behavior is according to the latest
specification at:
http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin
This sandboxed automatic features browsing context flag is
relaxed by the same keyword as scripts, because when
scripts are enabled these features are trivially possible
anyway, and it would be unfortunate to force authors to
use script to do them when sandboxed rather than allowing
them to use the declarative features.
Tests: fast/forms/autofocus-in-sandbox-with-allow-scripts.html
media/auto-play-in-sandbox-with-allow-scripts.html
- dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy):
LayoutTests:
Add layout tests to check that automatic features (video
autoplay and form control autofocus) are allowed / working
in sandboxed iframes if the "allow-scripts" flag is set.
This behavior is according to the latest specification at:
http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin
The tests to check that automatic features are blocked in
sandboxed iframes have been removed since they relied on
the "allow-scripts" flag to work.
- fast/forms/autofocus-in-sandbox-with-allow-scripts-expected.txt: Added.
- fast/forms/autofocus-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/fast/forms/no-autofocus-in-sandbox.html.
- fast/forms/no-autofocus-in-sandbox-expected.txt: Removed.
- media/auto-play-in-sandbox-with-allow-scripts-expected.txt: Added.
- media/auto-play-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/media/no-auto-play-in-sandbox.html.
- media/no-auto-play-in-sandbox-expected.txt: Removed.
- media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html: Added.
- media/resources/no-auto-play-in-sandbox-iframe.html: Removed.
- 11:54 AM Changeset in webkit [127480] by
-
- 11 edits in trunk/Source/WebCore
Register scrolling layers with ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=78862
Patch by Sami Kyostila <skyostil@google.com> on 2012-09-04
Reviewed by James Robinson.
In order to allow scrollable child layers to be scrolled off the main
thread, register them with the ScrollingCoordinator. These layers are
also removed from the non-fast scrollable region.
Whenever the scroll offset or other scroll geometry related attribute of
a compositor scrolled layer changes, the ScrollingCoordinator is
informed to allow it to update its internal representation of the
scrollable layer.
No tests because the ScrollingCoordinator is currently not testable.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion): Composited scrolling layers
can be scrolled off the main thread.
(WebCore):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
Callback to ScrollingCoordinator about changes the composited scrolling layers.
- page/scrolling/ScrollingCoordinator.h:
(WebCore):
(ScrollingCoordinator):
- page/scrolling/ScrollingCoordinatorNone.cpp:
(WebCore):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::usesCompositedScrolling):
- rendering/RenderLayer.cpp:
(WebCore):
(WebCore::RenderLayer::usesCompositedScrolling):
- rendering/RenderLayer.h:
(RenderLayer):
(WebCore::RenderLayer::usesCompositedScrolling):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateScrollingLayers):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scrollingLayerDidChange):
(WebCore):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 11:46 AM Changeset in webkit [127479] by
-
- 5 edits in trunk/Source/JavaScriptCore
Remove uses of ClassInfo from SpeculativeJIT::compileObjectOrOtherLogicalNot
https://bugs.webkit.org/show_bug.cgi?id=95510
Reviewed by Oliver Hunt.
More refactoring to get rid of ClassInfo checks in the DFG.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
- 11:45 AM Changeset in webkit [127478] by
-
- 4 edits in trunk/Tools
Elide test names when running new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=95626
Reviewed by Dirk Pranke.
When the test name exceeds the number of terminal columns, it leaves
text on the screen. Avoid this by eliding the test name when running
tests. This is similar to what ninja does when compiling.
- Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream):
(MeteredStream.number_of_columns): Helper method to get number of
terminal columns. Won't work on Win32 python, but meh.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
because stderr appears to be ascii only.
(Printer.print_started_test): Route through _test_status_line.
(Printer.print_finished_test): Route through _test_status_line.
(Printer._print_test_trace): Route through _test_status_line.
(Printer._print_baseline): Route through _test_status_line.
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(test_test_status_line): Test for _test_status_line.
- 11:42 AM Changeset in webkit [127477] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebKit2
Rollout r127322.
- 11:37 AM Changeset in webkit [127476] by
-
- 6 edits in trunk/Source/WebCore
[chromium] Do not allow infinite pending frames in CCFrameRateController
https://bugs.webkit.org/show_bug.cgi?id=94254
Patch by Brian Anderson <brianderson@chromium.org> on 2012-09-04
Reviewed by James Robinson.
Removes support for infinite pending frames in CCFrameRateController
if swap acks are available.
Functionality covered by existing tests.
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::CCFrameRateController):
(WebCore::CCFrameRateController::setMaxFramesPending):
(WebCore::CCFrameRateController::setSwapBuffersCompleteSupported):
(WebCore):
(WebCore::CCFrameRateController::onTimerTick):
(WebCore::CCFrameRateController::didBeginFrame):
(WebCore::CCFrameRateController::didFinishFrame):
- platform/graphics/chromium/cc/CCFrameRateController.h:
(CCFrameRateController):
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setSwapBuffersCompleteSupported):
(WebCore):
- platform/graphics/chromium/cc/CCScheduler.h:
(CCScheduler):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeRendererOnImplThread):
- 11:33 AM Changeset in webkit [127475] by
-
- 3 edits in trunk/Tools
[GTK] Print API missing documentation when generating gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=95703
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-09-04
Reviewed by Carlos Garcia Campos.
Print out API missing documentation when generating gtkdoc. This makes it
easier to fix documentation errors.
- gtk/generate-gtkdoc:
(print_missing_api): Added.
(generate_doc): Inline the rebase step, since it now reports an error
when you try to rebase without generating documentation first.
- gtk/gtkdoc.py:
(GTKDoc.rebase_installed_docs): Raise an error when rebasing without
generating documentation first to enable a small cleanup at the caller.
(GTKDoc.api_missing_documentation): Added.
- 11:31 AM Changeset in webkit [127474] by
-
- 7 edits2 adds in trunk
ASSERTion failure when SVG element is removed from document and readded
https://bugs.webkit.org/show_bug.cgi?id=95517
<rdar://problem/12175583>
Reviewed by Brady Eidson.
Previously, SVG animations would cease to animate when their parent
<svg> element was removed and re-added to the document.
Instead, to match Firefox and Opera, we should continue the animation
with the same beginTime (i.e. the animation continues as if it had never
been removed from the document).
Test: svg/animations/reinserting-svg-into-document.html
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::insertedInto): Don't call begin() on an already-started SMILTimeContainer().
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::isStarted): Added.
- svg/animation/SMILTimeContainer.h: Add isStarted().
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedInto): Always reschedule SVGSMILElements with
their parent SMILTimeContainer when they are inserted into the document, otherwise
they are lost (and never again update) when their subtree is removed and then
readded to the document.
Add a test that ensures that removing an SVG element from the document
and readding it continues SMIL animations.
- svg/animations/reinserting-svg-into-document.html: Added.
- 11:08 AM Changeset in webkit [127473] by
-
- 8 edits in trunk
[Chromium] Allow asyncronous response of pointer lock requests in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=95628
Reviewed by James Robinson.
Tools:
Future tests need the ability to respond asynchronously that
pointer lock requests have been accepted or rejected. This patch
adds the following:
testRunner.setPointerLockWillRespondAsynchronously();
testRunner.didAcquirePointerLock();
testRunner.didNotAcquirePointerLock();
Tested in existing test:
pointerlockchange-pointerlockerror-events.html
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::didAcquirePointerLock):
(DRTTestRunner::didNotAcquirePointerLock):
(DRTTestRunner::setPointerLockWillRespondAsynchronously):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::requestPointerLock):
(WebViewHost::didAcquirePointerLock):
(WebViewHost::didNotAcquirePointerLock):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
(WebViewHost::setPointerLockWillRespondAsynchronously):
LayoutTests:
Add testing for testRunner.setPointerLockWillRespondAsynchronously().
- pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
- pointer-lock/pointerlockchange-pointerlockerror-events.html:
- 10:47 AM Changeset in webkit [127472] by
-
- 4 edits2 adds in trunk
[CSS Regions] Destroying a render named flow thread without unregistering left-over content nodes triggered an assertion.
https://bugs.webkit.org/show_bug.cgi?id=95645
Patch by Andrei Bucur <abucur@adobe.com> on 2012-09-04
Reviewed by Abhishek Arya.
Source/WebCore:
This patch cleans up the render named flow thread before destruction by unregistering left-over content nodes.
Tests: fast/regions/moved-content-node-crash.html
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):
LayoutTests:
Simple test case that triggers an ASSERT in debug mode and causes a crash in release.
The ASSERT appears in RenderFlowThreadController::unregisterNamedFlowContentNode
ASSERT(it != m_mapNamedFlowContentNodes.end());
It happens because when a content node is added to an iframe document and then moved back, the iframe's RenderNamedFlowThread is destroyed
without calling unregisterNamedFlowContentNode on the node. This triggers the before mentioned assertion after a lazyAttach and a detach
in the parent document.
- fast/regions/moved-content-node-crash-expected.txt: Added.
- fast/regions/moved-content-node-crash.html: Added.
- 9:50 AM Changeset in webkit [127471] by
-
- 2 edits in trunk/Source/WebCore
[chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium
https://bugs.webkit.org/show_bug.cgi?id=95744
Patch by Koji Ishii <Koji Ishii> on 2012-09-04
Unreviewed build fix, verified by Scott Graham.
The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant
because '/opentype/' was already included to webcore_remaining.
It was not only redundant but also breaks incremental linking.
No new tests are required because no behavior changes.
Patch by Koji Ishii <Koji Ishii> on 2012-09-04
- WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform.
- 8:47 AM Changeset in webkit [127470] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection
https://bugs.webkit.org/show_bug.cgi?id=95747
PR199729
Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-04
Reviewed by Rob Buis.
Internally Reviewed by Joe Mason.
If the browser has never saved a secure protocol cookie in its mapping before,
and it tries to set and retreive a secure cookie over a non-secure
protocol, it will not show up because the link between the secure and
non-secure mapping isn't created until a cookie (sent through secure) is set.
The fix is to also check for the linkage in getRawCookies. Note that we cannot
map the secure CookieMap to the non-secure one because getRawCookies is a const
function.
Manually tested using our Browser Test suite.
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getRawCookies):
- 8:45 AM Changeset in webkit [127469] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
https://bugs.webkit.org/show_bug.cgi?id=95751
Reviewed by Martin Robinson.
In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
gst_message_new_duration was renamed to
gst_message_new_duration_changed.
However the only place where we used this is in the HTTP source
element and only if appsrc < 0.10.27 is used at runtime. In the
case of GStreamer 1.0 this condition will be always false so we
can disable this code at build time.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didReceiveResponse):
- 8:32 AM Changeset in webkit [127468] by
-
- 12 edits in trunk
Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
https://bugs.webkit.org/show_bug.cgi?id=93443
Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-04
Reviewed by Pavel Feldman.
Source/WebCore:
Added "regionLayoutUpdate" event to the protocol.
Removed "getFlowByName" from protocol.
The front-end keeps in sync the requested Named Flow Collections.
Modified existing test: inspector/styles/protocol-css-regions-commands.html
- dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
LayoutTests:
Validate "regionLayoutUpdate" event.
- inspector/styles/protocol-css-regions-commands-expected.txt:
- inspector/styles/protocol-css-regions-commands.html:
- 8:11 AM WebKitGTK/1.10.x edited by
- (diff)
- 6:48 AM Changeset in webkit [127467] by
-
- 2 edits in trunk/Source/WebCore
Fix IDL dependency generation correctly
https://bugs.webkit.org/show_bug.cgi?id=95730
Patch by Jonathan Liu <net147@gmail.com> on 2012-09-04
Reviewed by Csaba Osztrogonác.
IDL dependency generation is still not working after
https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
added after the filename in an echo command end up being added to the
file which isn't handled correctly by preprocess-idls.pl. The problem
is fixed by removing the space after the filename.
- DerivedSources.pri:
- 6:43 AM WebKitGTK/1.10.x edited by
- (diff)
- 6:40 AM WebKitGTK/1.10.x edited by
- (diff)
- 6:38 AM WebKitGTK/1.10.x edited by
- (diff)
- 6:38 AM WebKitGTK/1.10.x edited by
- Add proposed merges for 1.9.92 (diff)
- 6:36 AM Changeset in webkit [127466] by
-
- 3 edits2 adds in trunk
[Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
https://bugs.webkit.org/show_bug.cgi?id=95618
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.
Source/WebCore:
Make sure we only emit the the signal for menu lists and list
boxes rendered from actual HTML select elements.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange): We support accessibility
ListBoxes and MenuLists only here, assuming they represent HTML
select elements, which might be not always true (e.g. ARIA). Thus,
check if that condition is true, early returning in other case.
LayoutTests:
New layout test to ensure we don't crash with ATK notifications
anymore when changing the selection in an ARIA listbox.
- platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
- platform/gtk/accessibility/aria-listbox-crash.html: Added.
- 6:34 AM Changeset in webkit [127465] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] [TextureMapper] Assertion failure in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=95713
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-09-04
Reviewed by Noam Rosenthal.
Fix an assertion failure by returning a valid context always for GraphicsContext3D::platformContext.
This is important because TextureMapperGL uses the platform context to perform hashing.
No new tests. This is covered by existing accelerated compositing tests.
- platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::platformContext): Return the current GLContext
when getting the platform context for private GraphicsContext3DPrivates that render
to the currently active context.
- 6:32 AM Changeset in webkit [127464] by
-
- 4 edits in trunk
[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
https://bugs.webkit.org/show_bug.cgi?id=86961
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Add ecore_x initialisation check before calling ecore_x_bell
to avoid crashes when X server is not running.
- platform/efl/SoundEfl.cpp:
(WebCore::systemBeep):
LayoutTests:
Unskipped two layout tests that were crashing.
- platform/efl/TestExpectations:
- 6:30 AM Changeset in webkit [127463] by
-
- 6 edits in trunk
[EFL][WK2] CSS3 Media Queries functionality is broken
https://bugs.webkit.org/show_bug.cgi?id=95680
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
In WK2, WebProcess doesn't have access to ewk_view evas object.
Methods that get screen rect or screen depth either return incorrect value or crash.
This patch removes dependency to ewk_view evas object and relies on ecore_x_* functions
to get screen rectangle or color depth of the screen.
- platform/efl/EflScreenUtilities.cpp: removed unused getPixelDepth method definition
- platform/efl/EflScreenUtilities.h: removed unsused getPixelDepth method declaration
(WebCore):
- platform/efl/PlatformScreenEfl.cpp:
(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
LayoutTests:
Unskipped passing CSS3 Media Query tests.
- platform/efl-wk2/TestExpectations:
- 6:20 AM WebKitGTK/1.10.x edited by
- (diff)
- 6:20 AM WebKitGTK/1.10.x edited by
- (diff)
- 6:19 AM WebKitGTK/1.10.x edited by
- (diff)
- 6:13 AM Changeset in webkit [127462] by
-
- 10 edits2 adds in trunk
.: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.
Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.
- Source/cmake/OptionsEfl.cmake: Turn on CONTEXT_MENUS flag for EFL port
Source/WebCore: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.
Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.
- PlatformEfl.cmake: Removed -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1
Source/WebKit: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.
Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.
- PlatformEfl.cmake: Added ContextMenuClientEfl.cpp file to sources list.
Source/WebKit/efl: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.
Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.
- WebCoreSupport/ContextMenuClientEfl.cpp: Added.
(WebCore):
(WebCore::ContextMenuClientEfl::contextMenuDestroyed):
(WebCore::ContextMenuClientEfl::getCustomMenuFromDefaultItems):
(WebCore::ContextMenuClientEfl::contextMenuItemSelected):
(WebCore::ContextMenuClientEfl::downloadURL):
(WebCore::ContextMenuClientEfl::lookUpInDictionary):
(WebCore::ContextMenuClientEfl::speak):
(WebCore::ContextMenuClientEfl::isSpeaking):
(WebCore::ContextMenuClientEfl::stopSpeaking):
(WebCore::ContextMenuClientEfl::searchWithGoogle):
- WebCoreSupport/ContextMenuClientEfl.h: Added.
(WebCore):
(ContextMenuClientEfl):
- ewk/ewk_contextmenu.cpp: Removed ewk_context_menu_customize implementation.
(ewk_context_menu_destroy): Added freeing context menu.
(ewk_context_menu_new): Added filling ewk_contextmenu list.
(ewk_context_menu_item_append):
- ewk/ewk_contextmenu_private.h: Removed ewk_context_menu_customize and changed ewk_context_menu_new definition.
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(ewk_view_context_menu_forward_event):
- 5:51 AM Changeset in webkit [127461] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: Skip inspector WebGL tests where WebGL is disabled
https://bugs.webkit.org/show_bug.cgi?id=95733
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.
This is to update Skipped and TestExpectations files.
- platform/efl/TestExpectations:
- platform/win/Skipped:
- 5:34 AM Changeset in webkit [127460] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=95725
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-04
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 5:30 AM Changeset in webkit [127459] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [WebGL] Bugfix: wrong texture binding target in replay for 3D textures
https://bugs.webkit.org/show_bug.cgi?id=95687
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.
gl.bindTexture accepts either TEXTURE_2D or TEXTURE_CUBE_MAP targets, but we tried to replay with TEXTURE_CUBE_MAP_POSITIVE_X and others for 3D textures.
- inspector/InjectedScriptWebGLModuleSource.js:
(.):
- 5:11 AM Changeset in webkit [127458] by
-
- 25 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore
Revert r127442 (Merge r126715)
Patch causes crashes and makes inspector unit tests to fail in both
WebKit1 and WebKit2
- 5:05 AM WebKitGTK/1.10.x edited by
- (diff)
- 4:56 AM Changeset in webkit [127457] by
-
- 22 edits7 adds in trunk
Allow child-frame content in hit-tests.
https://bugs.webkit.org/show_bug.cgi?id=95204
.:
Reviewed by Antonio Gomes.
Update exported symbols.
- Source/autotools/symbols.filter:
Source/WebCore:
Reviewed by Antonio Gomes.
Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
it is now handled by the hit test itself controlled by the AllowChildFrameContent
flag in HitTestRequest.
Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html
touchadjustment/iframe-boundary.html
- WebCore.exp.in:
- WebCore.order:
- dom/Document.cpp:
(WebCore::Document::nodesFromRect):
- dom/Document.h:
(Document):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- rendering/HitTestRequest.h:
(WebCore::HitTestRequest::allowChildFrameContent):
(WebCore::HitTestRequest::childFrameHitTest):
(WebCore::HitTestRequest::testChildFrameScrollBars):
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::nodeAtPoint):
(WebCore):
- rendering/RenderFrameBase.h:
(RenderFrameBase):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
- testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
Reviewed by Antonio Gomes.
Update symbols for the Windows build-system.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
Reviewed by Antonio Gomes.
Touch-Adjustment test by Kevin Ellis
Two new tests for hit-testing child frame content. One for testing it as an option to
nodesFromRect, and one testing its improvement on touch adjustment on iframe boundaries.
- fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Added.
- fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Added.
- fast/dom/nodesFromRect/resources/child-frame.html: Added.
- fast/dom/nodesFromRect/resources/nodesFromRect.js:
(check):
(checkShadowContent):
(checkRect):
(nodesFromRectAsString):
- touchadjustment/iframe-boundary-expected.txt: Added.
- touchadjustment/iframe-boundary.html: Added.
- touchadjustment/resources/inner-content-page.html: Added.
- touchadjustment/resources/inner-navigation-frame.html: Added.
- 4:52 AM Changeset in webkit [127456] by
-
- 4 edits in trunk/LayoutTests
Unreviewed tests fix.
- http/tests/inspector/workspace-test.js:
- inspector/debugger/dynamic-script-tag-expected.txt:
- inspector/debugger/dynamic-script-tag.html:
- 4:25 AM Changeset in webkit [127455] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Fix build error in NetworkStateNotifierEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=95724
Unreviewed EFL build fix.
Make sure <sys/socket.h> is included before
<linux/netlink.h> to fix build errors on some
systems (e.g. Ubuntu 11.10).
No new tests, no behavior change.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-04
- platform/network/efl/NetworkStateNotifierEfl.cpp:
- 3:48 AM Changeset in webkit [127454] by
-
- 22 edits1 move5 adds2 deletes in trunk
Web Inspector: Create JavaScriptSources based on network resources.
https://bugs.webkit.org/show_bug.cgi?id=95352
Reviewed by Pavel Feldman.
Source/WebCore:
Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
Removed rawSourceCode as it was not needed anymore.
Tests: inspector/debugger/network-uisourcecode-provider.html
inspector/debugger/resource-script-mapping.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CompilerScriptMapping.js:
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
- inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._populate):
(WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):
- inspector/front-end/RawSourceCode.js:
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._reset):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.setSourceMapping):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/Workspace.js: Drive-by: fixed duplicating uiSourceCodes in workspace.
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
LayoutTests:
Removed raw-source-code.html test as RawSourceCode was removed by this patch.
Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
Updated dynamic-script-tag.html to better match expected behavior.
- http/tests/inspector/network/network-request-revision-content.html:
- http/tests/inspector/workspace-test.js: Added.
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
(initialize_WorkspaceTest):
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/dynamic-script-tag-expected.txt:
- inspector/debugger/dynamic-script-tag.html:
- inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
- inspector/debugger/network-uisourcecode-provider.html: Added.
- inspector/debugger/raw-source-code-expected.txt: Removed.
- inspector/debugger/raw-source-code.html: Removed.
- inspector/debugger/resource-script-mapping-expected.txt: Added.
- inspector/debugger/resource-script-mapping.html: Added.
- inspector/debugger/scripts-panel.html:
- inspector/debugger/source-frame-count.html:
- 3:38 AM Changeset in webkit [127453] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r127447.
http://trac.webkit.org/changeset/127447
https://bugs.webkit.org/show_bug.cgi?id=95726
Mistake, did not reliably pass yet. (Requested by drott on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-04
- platform/efl/TestExpectations:
- 2:37 AM Changeset in webkit [127452] by
-
- 3 edits3 adds in trunk
Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards
https://bugs.webkit.org/show_bug.cgi?id=95443
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Save gl.getError() status before taking the GL snapshot and restore it afterwards.
- inspector/InjectedScriptWebGLModuleSource.js:
(.):
LayoutTests:
Adds a test to check that we properly save the WebGL getError() status while doing the instrumentation.
- inspector/profiler/webgl/webgl-profiler-get-error-expected.txt: Added.
- inspector/profiler/webgl/webgl-profiler-get-error.html: Added.
- inspector/profiler/webgl/webgl-profiler-test.js: Added.
(initialize_WebGLProfilerTest.InspectorTest.enableWebGLAgent):
(initialize_WebGLProfilerTest):
(createWebGLContext):
- 2:25 AM Changeset in webkit [127451] by
-
- 2 edits in trunk
[CMAKE] Update cmakeconfig.h.cmake
https://bugs.webkit.org/show_bug.cgi?id=95712
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-04
Reviewed by Gyuyoung Kim.
Update feature definitions which are missing compared to WebKitFeatures.cmake
- Source/cmakeconfig.h.cmake:
- 2:20 AM Changeset in webkit [127450] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] REGRESSION(r127321): It made 3 notification test timeout
https://bugs.webkit.org/show_bug.cgi?id=95638
Patch by Jon Lee <jonlee@apple.com> on 2012-09-04
Reviewed by Csaba Osztrogonác.
Dispatch show event instead of display after r127321.
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::sendDisplayEvent):
- 1:55 AM Changeset in webkit [127449] by
-
- 5 edits in trunk
Web Inspector: More directional control characters for debugging in inspector
https://bugs.webkit.org/show_bug.cgi?id=95696
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Entities for text directionality-related characters added (LRE, RLE, LRO, RLO, PDF).
- inspector/front-end/ElementsTreeOutline.js:
LayoutTests:
- inspector/elements/elements-panel-structure-expected.txt:
- inspector/elements/elements-panel-structure.html:
- 1:53 AM Changeset in webkit [127448] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: new CPU Profiles are not shown after reattach
https://bugs.webkit.org/show_bug.cgi?id=95686
Reviewed by Vsevolod Vlasov.
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::restore): set m_headersRequested flags
to true and clear all profiles on the front-end since there are no
collected profiles yet immediately after render process sitching.
- 1:53 AM EFLWebKit edited by
- (diff)
- 1:39 AM Changeset in webkit [127447] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Removing http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
from skipped crashers section, after https://bugs.webkit.org/show_bug.cgi?id=94458#c14
- platform/efl/TestExpectations: Previously crashing test removed.
- 1:38 AM Changeset in webkit [127446] by
-
- 20 edits6 adds in releases/WebKitGTK/webkit-1.10
Merge r127070 - Source/WebCore: [Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070
Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.
Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.
Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.
Test: fast/events/continuous-platform-wheelevent-in-scrolling-div.html
- platform/gtk/PlatformWheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Source/WebKit/gtk: [Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070
Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.
Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.
Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.
- webkit/webkitwebview.cpp:
(webkit_web_view_realize):
Source/WebKit2: [Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070
Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.
Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.
Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.
- Shared/gtk/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize):
Tools: [Gtk] Process Gtk 3.4 smooth scroll events properly
https://bugs.webkit.org/show_bug.cgi?id=88070
Added continousMouseScrollBy support in WebKitTestRunner, and added
implementation for gtk, and stub for Qt, mac and EFL.
Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
scroll for emulating multi-tick mouseScrollBy events.
Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.
- DumpRenderTree/gtk/EventSender.cpp:
(mouseScrollByCallback):
(continuousMouseScrollByCallback):
- WebKitTestRunner/EventSenderProxy.h:
(EventSenderProxy):
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::mouseScrollBy):
(WTR):
(WTR::EventSendingController::continuousMouseScrollBy):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
(EventSendingController):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::continuousMouseScrollBy):
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR):
(WTR::EventSenderProxy::continuousMouseScrollBy):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::continuousScrollBy):
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::continuousMouseScrollBy):
(WTR):
LayoutTests: [Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070
Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
scroll for emulating multi-tick mouseScrollBy events.
Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.
- platform/gtk-wk2/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
- platform/gtk-wk2/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
- platform/gtk/TestExpectations:
- platform/gtk/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
- platform/gtk/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
- 1:38 AM Changeset in webkit [127445] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add webplatform and browser to build info
https://bugs.webkit.org/show_bug.cgi?id=95715
Reviewed by George Staikos.
PR# 202102
- WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::buildPage):
- 1:31 AM WebKitGTK/1.10.x edited by
- (diff)
- 1:27 AM Changeset in webkit [127444] by
-
- 6 edits in trunk/Source
[EFL] Drop default theme concept
https://bugs.webkit.org/show_bug.cgi?id=94778
Reviewed by Gyuyoung Kim.
Source/WebKit/efl:
- ewk/ewk_view.h:
Updated doxygen document not to mention default theme.
Source/WebKit2:
- PlatformEfl.cmake: Removed DEFAULT_THEME_PATH definitions.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_initialize): Removed default theme concept.
- UIProcess/API/efl/ewk_view.h:
Updated doxygen document not to mention default theme.
- 1:23 AM WebKitGTK/1.10.x edited by
- (diff)
- 1:19 AM Changeset in webkit [127443] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: NMI: cosmetic change, rename m_domMemoryUsage to m_memoryInstrumentation.
https://bugs.webkit.org/show_bug.cgi?id=95716
Also m_memoryInstrumentation became a reference to external object because it has other life time than domNodeVisitor.
Reviewed by Yury Semikhatsky.
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
(WebCore::collectDomTreeInfo):
- 12:25 AM Changeset in webkit [127442] by
-
- 25 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore
Merge r126715 - Array type checks and storage accesses should be uniformly represented and available to CSE
https://bugs.webkit.org/show_bug.cgi?id=95013
Reviewed by Oliver Hunt.
This uniformly breaks up all array accesses into up to three parts:
1) The type check, using a newly introduced CheckArray node, in addition to possibly
a CheckStructure node. We were already inserting the CheckStructure prior to this
patch. The CheckArray node will be automatically eliminated if the thing it was
checking for had already been checked for, either intentionally (a CheckStructure
inserted based on the array profile of this access) or accidentally (some checks,
typically a CheckStructure, inserted for some unrelated operations). The
CheckArray node may not be inserted if the array type is non-specific (Generic or
ForceExit).
2) The storage load using GetIndexedPropertyStorage. Previously, this only worked for
GetByVal. Now it works for all array accesses. The storage load may not be
inserted if the mode of array access does not permit CSE of storage loads (like
non-specific modes or Arguments).
3) The access itself: one of GetByVal, PutByVal, PutByValAlias, ArrayPush, ArrayPop,
GetArrayLength, StringCharAt, or StringCharCodeAt.
This means that the type check can be subjected to CSE even if the CFA isn't smart
enough to reason about it (yet!). It also means that the storage load can always be
subjected to CSE; previously CSE on storage load only worked for array loads and not
other forms of access. Finally, it removes the bizarre behavior that
GetIndexedPropertyStorage previously had: previously, it was responsible for the type
check in some cases, but not others; this made reasoning about the CFA really
confusing.
This change also disables late refinement of array mode, since I decided that
supporting that feature is both confusing and likely unprofitable. The array modes are
now locked in in the first fixup run after prediction propagation. Of course,
refinements from Generic to something else would not have been a problem; we could
reenable those if we thought we really needed to.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::fromStructure):
(DFG):
(JSC::DFG::refineArrayMode):
- dfg/DFGArrayMode.h:
(DFG):
(JSC::DFG::modeIsJSArray):
(JSC::DFG::lengthNeedsStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayMode):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::checkStructureElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::performCSE):
- dfg/DFGCSEPhase.h:
(DFG):
- dfg/DFGCommon.h:
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(FixupPhase):
(JSC::DFG::FixupPhase::blessArrayOperation):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(DFG):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::collectGarbage):
- dfg/DFGGraph.h:
(Graph):
(JSC::DFG::Graph::vote):
(JSC::DFG::Graph::substitute):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasArrayMode):
(JSC::DFG::Node::setArrayMode):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGPhase.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- 12:08 AM Changeset in webkit [127441] by
-
- 28 edits2 deletes in releases/WebKitGTK/webkit-1.10
Merge r127228 - Unreviewed, rolling out r126127.
http://trac.webkit.org/changeset/126127
This breaks gobject bindings.
Source/WebCore:
- dom/Attr.cpp:
(WebCore::Attr::cloneNode):
- dom/Attr.h:
- dom/CDATASection.cpp:
(WebCore::CDATASection::cloneNode):
- dom/CDATASection.h:
(CDATASection):
- dom/Comment.cpp:
(WebCore::Comment::cloneNode):
- dom/Comment.h:
(Comment):
- dom/Document.cpp:
(WebCore::Document::cloneNode):
- dom/Document.h:
(Document):
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::cloneNode):
- dom/DocumentFragment.h:
(DocumentFragment):
- dom/DocumentType.cpp:
(WebCore::DocumentType::cloneNode):
- dom/DocumentType.h:
(DocumentType):
- dom/Element.cpp:
(WebCore::Element::cloneNode):
- dom/Element.h:
(Element):
- dom/EntityReference.cpp:
(WebCore::EntityReference::cloneNode):
- dom/EntityReference.h:
(EntityReference):
- dom/Node.h:
(Node):
- dom/Node.idl:
- dom/Notation.cpp:
(WebCore::Notation::cloneNode):
- dom/Notation.h:
(Notation):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::cloneNode):
- dom/ProcessingInstruction.h:
(ProcessingInstruction):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/Text.cpp:
(WebCore::Text::cloneNode):
- dom/Text.h:
(Text):
LayoutTests:
- fast/dom/shadow/shadowroot-clonenode-expected.txt: Removed.
- fast/dom/shadow/shadowroot-clonenode.html: Removed.
- 12:08 AM WebKitGTK/1.10.x edited by
- (diff)
Sep 3, 2012:
- 11:37 PM Changeset in webkit [127440] by
-
- 4 edits in trunk/Source/WebCore
[Qt] Port the Qt pixmap JS bindings to use the JSC C API
https://bugs.webkit.org/show_bug.cgi?id=94702
Reviewed by Kenneth Rohde Christiansen.
Based on patch by Noam Rosenthal.
The conversion uses a simple JSClassRef based binding and only a few
uses of private JSC API for the HTML element DOM bindings remain.
This is essentially used for wrapping QPixmap and QImage types in
JavaScript and the other way around, for retrieving the image data
out of a HTML image element when converting from JS/DOM to Qt.
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::copyPixels):
(JSC::Bindings::toPixmap):
(JSC::Bindings::toImage):
(JSC::Bindings::imageSizeForVariant):
(JSC::Bindings::getPixmapWidth):
(JSC::Bindings::getPixmapHeight):
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::pixmapToImageData):
(JSC::Bindings::pixmapToDataUrl):
(JSC::Bindings::pixmapToString):
(JSC::Bindings::QtPixmapRuntime::toJS):
(JSC::Bindings::QtPixmapRuntime::toQt):
(JSC::Bindings::QtPixmapRuntime::canHandle):
(JSC::Bindings::QtPixmapRuntime::getClassRef):
- bridge/qt/qt_pixmapruntime.h:
(QtPixmapRuntime):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
- 10:26 PM Changeset in webkit [127439] by
-
- 2 edits5 deletes in trunk/LayoutTests
http/tests/incremental/partial-jpeg.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82480
Reviewed by Kent Tamura.
Remove this test: we have a more robust partial load test now in
http/tests/images/jpg-img-partial-load.html
- http/tests/incremental/partial-jpeg-expected.png: Removed.
- http/tests/incremental/partial-jpeg-expected.txt: Removed.
- http/tests/incremental/partial-jpeg.html: Removed.
- http/tests/incremental/resources/checkerboard.jpg: Removed.
- http/tests/incremental/resources/partial-jpeg.php: Removed.
- platform/chromium/TestExpectations:
- 7:19 PM Changeset in webkit [127438] by
-
- 7 edits in trunk/Source/WebCore
Share immutable ElementAttributeData between elements with identical attributes.
<http://webkit.org/b/94990>
Reviewed by Antti Koivisto.
Keep a cache of ElementAttributeData objects for a given set of attributes and reuse
them in elements with identical attribute maps. ElementAttributeData is made ref-counted
to facilitate this. A copy-on-write mechanism is already in place, since mutating call
sites have to go via Element::mutableAttributeData().
The cache is held by Document and cleared in Document::finishedParsing() since the vast
majority of immutable ElementAttributeData will be constructed during parsing.
On the HTML5 spec at <http://whatwg.org/c/>, we get a cache hit rate of nearly 80%,
translating into a 3.5MB reduction in memory use.
- dom/Document.cpp:
(WebCore::Document::finishedParsing):
(ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheEntry):
(WebCore::Document::cachedImmutableAttributeData):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
- dom/Element.h:
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::ElementAttributeData):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::create):
(ElementAttributeData):
(WebCore::ElementAttributeData::makeMutable):
- 7:09 PM Changeset in webkit [127437] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: the URL of worker inspector window sometimes is invalid
https://bugs.webkit.org/show_bug.cgi?id=95334
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-09-03
Reviewed by Pavel Feldman.
In "_openInspectorWindow", before "&dedicatedWorkerId=" should have a '?' to make the whole URL valid.
No new tests case for this bug.
- inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype._openInspectorWindow):
- 6:44 PM Changeset in webkit [127436] by
-
- 5 edits in trunk/Source
[EFL] Fix e_dbus_shutdown() error when exiting the Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=95636
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.
Source/WebCore:
Check if the m_timer is active in stopUpdating()
to know the BatteryProvider is updating or not.
By checking the timer, stopUpdating() will be called
only BatteryProviderEfl is updating.
- platform/efl/BatteryProviderEfl.cpp:
(WebCore::BatteryProviderEfl::stopUpdating):
Source/WebKit/efl:
Invoke stopUpdating() in the destructor of BatteryClinetEfl()
to call e_ukit_shutdown() and e_dbus_shutdown() if and when
stopUpdating() has not been called explicitly.
- WebCoreSupport/BatteryClientEfl.cpp:
(BatteryClientEfl::~BatteryClientEfl):
- WebCoreSupport/BatteryClientEfl.h:
(BatteryClientEfl):
- 6:40 PM Changeset in webkit [127435] by
-
- 1 edit4 deletes in trunk/LayoutTests
[Chromium] Unreviewed test expectations update after r127410
Removed further platform-specific text expectations.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
- 6:21 PM Changeset in webkit [127434] by
-
- 4 edits in trunk
[WK2][WTR] Implement WebKitEnableCaretBrowsing attribute in testRunner.overridePreference
https://bugs.webkit.org/show_bug.cgi?id=95576
Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-03
Reviewed by Maciej Stachowiak.
Added a line of macro to implement WebKitEnableCaretBrowsing attribute in testRunner.overridePreference
Source/WebKit2:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
LayoutTests:
- platform/wk2/Skipped: Removed fast/repaint/no-caret-repaint-in-non-content-editable-element.html test case.
- 3:39 PM Changeset in webkit [127433] by
-
- 1 edit2 deletes in trunk/LayoutTests
[Chromium] Unreviewed test expectations update after r127410
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
- 12:14 PM Changeset in webkit [127432] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Not all activated elements highlighted, but some frames are
https://bugs.webkit.org/show_bug.cgi?id=95683
Reviewed by Kenneth Rohde Christiansen.
Use the new function Node::willRespondToMouseClickEvents to better determine if the element
can be tap-activated and avoid documents and frames completely.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):
- 12:14 PM WebKitGTK/1.10.x edited by
- r127124 merged (diff)
- 11:38 AM Changeset in webkit [127431] by
-
- 3 edits in trunk/Tools
[EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=95689
Reviewed by Kenneth Rohde Christiansen.
In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
So, there are bugs that key events are always generated in url bar although
the user clicked the web view.
This patch recovers the focus of the web view when left button is pressed and
adds for MiniBrowser to toggle the focus when middle button is pressed
like EWebLauncher already did.
- EWebLauncher/main.c:
(on_mouse_down):
- MiniBrowser/efl/main.c:
(on_mouse_down):
(browserCreate):
- 11:37 AM Changeset in webkit [127430] by
-
- 5 edits in trunk
Added ANDROID_GDBSERVER definition for Ant
https://bugs.webkit.org/show_bug.cgi?id=95265
Patch by Tao Bai <michaelbai@chromium.org> on 2012-09-03
Reviewed by Adam Barth.
ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
is only used for finding the gdbserver.
Source/WebKit/chromium:
- WebKitUnitTests.gyp:
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
- 10:16 AM Changeset in webkit [127429] by
-
- 19 edits3 adds6 deletes in trunk
Unreviewed, rolling out r127427.
http://trac.webkit.org/changeset/127427
https://bugs.webkit.org/show_bug.cgi?id=95695
Breaks some inspector/debugger tests on JSC (Requested by
vsevik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-03
Source/WebCore:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CompilerScriptMapping.js:
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
- inspector/front-end/NetworkUISourceCodeProvider.js: Removed.
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._shouldBindScriptToContentProvider):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
(WebInspector.ResourceScriptMapping.prototype._reset):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):
- inspector/front-end/StylesUISourceCodeProvider.js: Added.
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype._populate):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype._reset):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
LayoutTests:
- http/tests/inspector/network/network-request-revision-content.html:
- http/tests/inspector/workspace-test.js: Removed.
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/dynamic-script-tag-expected.txt:
- inspector/debugger/dynamic-script-tag.html:
- inspector/debugger/network-uisourcecode-provider-expected.txt: Removed.
- inspector/debugger/network-uisourcecode-provider.html: Removed.
- inspector/debugger/raw-source-code-expected.txt: Added.
- inspector/debugger/raw-source-code.html: Added.
- inspector/debugger/resource-script-mapping-expected.txt: Removed.
- inspector/debugger/resource-script-mapping.html: Removed.
- inspector/debugger/scripts-panel.html:
- 9:50 AM Changeset in webkit [127428] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 9:45 AM WebKitGTK/1.8.x edited by
- (diff)
- 9:44 AM WebKitGTK/1.8.x edited by
- (diff)
- 9:34 AM Changeset in webkit [127427] by
-
- 19 edits1 move5 adds2 deletes in trunk
Web Inspector: Create JavaScriptSources based on network resources.
https://bugs.webkit.org/show_bug.cgi?id=95352
Reviewed by Pavel Feldman.
Source/WebCore:
Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
Removed rawSourceCode as it was not needed anymore.
Tests: inspector/debugger/network-uisourcecode-provider.html
inspector/debugger/resource-script-mapping.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CompilerScriptMapping.js:
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
- inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._populate):
(WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):
- inspector/front-end/RawSourceCode.js:
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._reset):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.setSourceMapping):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
LayoutTests:
Removed raw-source-code.html test as RawSourceCode was removed by this patch.
Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
Updated dynamic-script-tag.html to better match expected behavior.
- http/tests/inspector/network/network-request-revision-content.html:
- http/tests/inspector/workspace-test.js: Added.
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
(initialize_WorkspaceTest):
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/dynamic-script-tag-expected.txt:
- inspector/debugger/dynamic-script-tag.html:
- inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
- inspector/debugger/network-uisourcecode-provider.html: Added.
- inspector/debugger/raw-source-code-expected.txt: Removed.
- inspector/debugger/raw-source-code.html: Removed.
- inspector/debugger/resource-script-mapping-expected.txt: Added.
- inspector/debugger/resource-script-mapping.html: Added.
- inspector/debugger/scripts-panel.html:
- inspector/debugger/source-frame-count.html:
- 9:09 AM Changeset in webkit [127426] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [WebGL] Make the injected resourceObject property non-enumerable
https://bugs.webkit.org/show_bug.cgi?id=95682
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-03
Reviewed by Pavel Feldman.
Make the injected auxiliary property resourceObject non-enumerable to hide it from for..in iterations.
Ideally this property should be completely hidden from the user's code.
Drive-by: Fix couple of small FIXME's.
- inspector/InjectedScriptWebGLModuleSource.js:
(.):
- 9:08 AM Changeset in webkit [127425] by
-
- 25 edits2 copies5 adds in trunk
MediaStream API: Add Ice-related functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95565
Reviewed by Adam Barth.
Source/Platform:
- Platform.gypi:
- chromium/public/WebRTCICECandidateDescriptor.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandlerClient.h.
(WebCore):
(WebKit):
(WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::~WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::operator=):
(WebKit::WebRTCICECandidateDescriptor::isNull):
- chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
- chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebKit):
(WebRTCPeerConnectionHandlerClient):
Source/WebCore:
Adds all Ice-related functionality to RTCPeerConnection, including
events, callbacks and methods.
Test: fast/mediastream/RTCPeerConnection-ice.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/RTCIceCandidateEvent.cpp: Added.
(WebCore):
(WebCore::RTCIceCandidateEvent::create):
(WebCore::RTCIceCandidateEvent::RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::~RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::candidate):
(WebCore::RTCIceCandidateEvent::interfaceName):
- Modules/mediastream/RTCIceCandidateEvent.h: Added.
(WebCore):
(RTCIceCandidateEvent):
- Modules/mediastream/RTCIceCandidateEvent.idl: Added.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::updateIce):
(WebCore):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::iceState):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::didGenerateIceCandidate):
(WebCore::RTCPeerConnection::didChangeIceState):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeIceState):
- Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- WebCore.gypi:
- dom/EventNames.h:
(WebCore):
- dom/EventNames.in:
- platform/chromium/support/WebRTCICECandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp.
(WebKit):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::assign):
(WebKit::WebRTCICECandidateDescriptor::reset):
(WebKit::WebRTCICECandidateDescriptor::initialize):
(WebKit::WebRTCICECandidateDescriptor::operator PassRefPtr<WebCore::RTCIceCandidateDescriptor>):
(WebKit::WebRTCICECandidateDescriptor::candidate):
(WebKit::WebRTCICECandidateDescriptor::sdpMid):
(WebKit::WebRTCICECandidateDescriptor::sdpMLineIndex):
- platform/mediastream/RTCIceCandidateDescriptor.h:
(WebCore::RTCIceCandidateDescriptor::candidate):
(WebCore::RTCIceCandidateDescriptor::sdpMid):
(WebCore::RTCIceCandidateDescriptor::sdpMLineIndex):
- platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(RTCPeerConnectionHandler):
- platform/mediastream/RTCPeerConnectionHandlerClient.h:
(WebCore):
(RTCPeerConnectionHandlerClient):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::updateIce):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::addIceCandidate):
(WebCore::RTCPeerConnectionHandlerChromium::didGenerateICECandidate):
(WebCore::RTCPeerConnectionHandlerChromium::didChangeICEState):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(WebKit):
(RTCPeerConnectionHandlerChromium):
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
Tools:
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::updateICE):
(MockWebRTCPeerConnectionHandler::addICECandidate):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):
LayoutTests:
- fast/mediastream/RTCPeerConnection-ice-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-ice.html: Added.
- 8:59 AM Changeset in webkit [127424] by
-
- 3 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore
Merge r127124 - 1.9.90 drops symbols, breaking compatibility
https://bugs.webkit.org/show_bug.cgi?id=93477
Patch by Xan Lopez <xlopez@igalia.com> on 2012-08-30
Reviewed by Martin Robinson.
Add a bunch of compatibility methods to the GObject DOM bindings
to cope with recent renames.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_element_get_class_list):
(webkit_dom_element_get_webkit_region_overflow):
(webkit_dom_webkit_named_flow_get_content_nodes):
(webkit_dom_webkit_named_flow_get_regions_by_content_node):
- bindings/gobject/WebKitDOMCustom.h:
- 8:19 AM WebKitGTK/1.10.x edited by
- Fix initial branch revision (diff)
- 7:57 AM Changeset in webkit [127423] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r127421
- rendering/HitTestResult.cpp:
(WebCore::HitTestLocation::HitTestLocation):
- 7:48 AM Changeset in webkit [127422] by
-
- 6 edits4 adds in trunk/Source/WebKit2
[EFL][WK2] Add ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=91206
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.
Add the ewk_settings which wraps the WKPreferencesRef.
The ewk_settings will be created by the ewk_view and it will be
destroyed when the ewk_view is destroyed. I make each view to have
its own group to make one ewk_settings sets preferences only for
one ewk_view.
The application can get the ewk_settings from ewk_view using
ewk_view_settings_get() API.
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_settings.cpp: Added.
(ewk_settings_enable_scripts_set):
(ewk_settings_enable_scripts_get):
(ewk_settings_auto_load_images_set):
(ewk_settings_auto_load_images_get):
- UIProcess/API/efl/ewk_settings.h: Added.
- UIProcess/API/efl/ewk_settings_private.h: Added.
(_Ewk_Settings):
(_Ewk_Settings::_Ewk_Settings):
- UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_initialize):
(ewk_view_settings_get):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_settings.cpp: Added.
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 7:41 AM Changeset in webkit [127421] by
-
- 17 edits in trunk/Source/WebCore
Move AllowShadowContent flag to HitTestRequest
https://bugs.webkit.org/show_bug.cgi?id=95685
Reviewed by Antonio Gomes.
Moves the flag and updates the interface for HitTestResult::addNodeToRectBasedTestResult so that
it can read the flag from HitTestRequest instead of from HitTestResult.
No change in functionality. No new tests.
- dom/Document.cpp:
(WebCore::Document::nodesFromRect):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- rendering/HitTestRequest.h:
- rendering/HitTestResult.cpp:
(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
- rendering/HitTestResult.h:
(HitTestLocation):
(HitTestResult):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::nodeAtPoint):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::nodeAtPoint):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):
- 7:15 AM Changeset in webkit [127420] by
-
- 3 edits in trunk/Source/WebKit2
Wheel-events fails temporarily after reload
https://bugs.webkit.org/show_bug.cgi?id=94934
Reviewed by Kenneth Rohde Christiansen.
Set fixed visible content rect using visibleContentBounds instead of WebPage::size. Otherwise the
content rect will be incorrectly set to the entire document size, when resizesToContents is active.
Test: UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml
- UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
- 7:01 AM Changeset in webkit [127419] by
-
- 7 edits in trunk
[EFL] Use WebKitVersion.h to get version information
https://bugs.webkit.org/show_bug.cgi?id=95669
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.
.:
WEBKIT_USER_AGENT_MAJOR_VERSION and WEBKIT_USER_AGENT_MINOR_VERSION
are defined as constant in the OptionsEfl.cmake. But we do not need
to define these here but can use the defined constant in WebKitVersion.h.
WebKitVersion.h is already generated with the version information
from the Source/WebCore/Configurations/Version.xcconfig.
- Source/cmake/OptionsEfl.cmake: Do not set WEBKIT_USER_AGENT_* variables.
- Source/cmakeconfig.h.cmake: Remove WEBKIT_USER_AGENT_* definitions
as no more port uses.
Source/WebKit/efl:
Use WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION
in the WebKitVersion.h
Relocate the StorageTracker.h to keep the sorted order.
- ewk/ewk_settings.cpp:
(ewk_settings_default_user_agent_get):
Source/WebKit2:
Use WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION
in the WebKitVersion.h
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::standardUserAgent):
- 6:22 AM Changeset in webkit [127418] by
-
- 5 edits in trunk
Web Inspector: Unhide hidden characters
https://bugs.webkit.org/show_bug.cgi?id=93888
Reviewed by Pavel Feldman.
Source/WebCore:
Certain invisible characters will be rendered as HTML entity references in the DOM tree to make them visible to the user.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
LayoutTests:
- inspector/elements/elements-panel-structure-expected.txt:
- inspector/elements/elements-panel-structure.html:
- 6:20 AM Changeset in webkit [127417] by
-
- 11 edits1 move in trunk/Source/WebCore
Web Inspector: rename JavaScriptContextManager to RuntimeModel for consistency.
https://bugs.webkit.org/show_bug.cgi?id=95677
Reviewed by Yury Semikhatsky.
- renamed the file and the usages
- renamed isolatedContextCreated to executionContextCreated for consistency.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/Inspector.json:
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::notifyContextCreated):
- inspector/compile-front-end.py:
- inspector/front-end/RuntimeModel.js: Renamed from Source/WebCore/inspector/front-end/JavaScriptContextManager.js.
(WebInspector.RuntimeModel):
(WebInspector.RuntimeModel.prototype._frameAdded):
(WebInspector.RuntimeModel.prototype._frameDetached):
(WebInspector.RuntimeModel.prototype._executionContextCreated):
(WebInspector.RuntimeDispatcher):
(WebInspector.RuntimeDispatcher.prototype.executionContextCreated):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 4:53 AM WebKitGTK/1.10.x edited by
- (diff)
- 4:17 AM WebKitGTK/1.10.x edited by
- (diff)
- 3:44 AM LineBreakingCSS3Mapping edited by
- Further update on 2010/2013. (diff)
- 3:43 AM LineBreakingCSS3Mapping edited by
- Update ICU(*) columns for BA class. Add issue needing verification. (diff)
- 3:26 AM Changeset in webkit [127416] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Unskipping message-port-close.html after bug 85811 was resolved.
- platform/efl/TestExpectations:
- 2:56 AM Changeset in webkit [127415] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying resources in Timeline
https://bugs.webkit.org/show_bug.cgi?id=95540
Reviewed by Pavel Feldman.
Linkify recource details using WebInspector.linkifyResourceAsNode(), so these bypass linkifier. Also
fix closure compiler warning.
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):
- 2:45 AM Changeset in webkit [127414] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: fixed front-end compilation warnings.
Not reviewed.
- inspector/front-end/FilteredItemSelectionDialog.js:
- inspector/front-end/HeapSnapshotView.js:
- 2:42 AM Changeset in webkit [127413] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: paint grid on top of box highlight.
https://bugs.webkit.org/show_bug.cgi?id=95676
Reviewed by Alexander Pavlov.
Otherwise, ruler numbers are not visible when selecting body.
- inspector/InspectorOverlayPage.html:
- 1:54 AM Changeset in webkit [127412] by
-
- 6 edits in trunk
Web Inspector: get rid of context execution id fallback.
https://bugs.webkit.org/show_bug.cgi?id=95567
Reviewed by Yury Semikhatsky.
Source/WebCore:
We now assign execution context id upon changes in the UI.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype._contextAdded):
(WebInspector.ConsoleView.prototype._addContextList):
(WebInspector.ConsoleView.prototype._contextListRemoved):
(WebInspector.ConsoleView.prototype._updateExecutionContextSelector):
(WebInspector.ConsoleView.prototype._appendExecutionContextOption):
(WebInspector.ConsoleView.prototype._executionContextChanged):
(WebInspector.ConsoleView.prototype._contextListUpdated):
(WebInspector.ConsoleView.prototype._addedExecutionContext):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow.evalCallback):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
(WebInspector.ConsoleView.prototype._enterKeyPressed):
- inspector/front-end/JavaScriptContextManager.js:
(WebInspector.JavaScriptContextManager):
(WebInspector.JavaScriptContextManager.prototype.contextLists):
(WebInspector.JavaScriptContextManager.prototype.contextByFrameAndSecurityOrigin):
(WebInspector.JavaScriptContextManager.prototype._frameAdded):
(WebInspector.JavaScriptContextManager.prototype._frameNavigated):
(WebInspector.JavaScriptContextManager.prototype._frameDetached):
(WebInspector.JavaScriptContextManager.prototype.isolatedContextCreated):
(WebInspector.FrameExecutionContextList):
(WebInspector.FrameExecutionContextList.prototype._frameNavigated):
(WebInspector.FrameExecutionContextList.prototype._addExecutionContext):
(WebInspector.FrameExecutionContextList.prototype.executionContexts):
(WebInspector.FrameExecutionContextList.prototype.contextBySecurityOrigin):
LayoutTests:
- http/tests/inspector/console-cd-completions.html:
- http/tests/inspector/console-cd.html:
- 1:50 AM Changeset in webkit [127411] by
-
- 5 edits in trunk/Tools
[EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=95670
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
Reviewed by Kenneth Rohde Christiansen.
Fix layout issues related to the URL bar in Minibrowser
and EWebLauncher when the window is resized.
The URL bar was not resized accordingly and the Web
page was moved behing the URL bar, hiding part of it.
- EWebLauncher/main.c:
(on_ecore_evas_resize):
(closeWindow):
- EWebLauncher/url_bar.c:
(url_bar_width_set):
(url_bar_add):
- EWebLauncher/url_bar.h:
- MiniBrowser/efl/main.c:
(on_ecore_evas_resize):
(main):
- 1:39 AM Changeset in webkit [127410] by
-
- 2 edits15 adds in trunk/LayoutTests
Unreviewed rebaseline for bug 94287.
Update Chromium-Mac and Chromium-Win images for multiple field time input UI.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
- platform/chromium/TestExpectations:
- 1:35 AM Changeset in webkit [127409] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark http/tests/incremental/slow-utf8-text.pl as flaky
https://bugs.webkit.org/show_bug.cgi?id=95673
Unreviewed EFL gardening.
Mark http/tests/incremental/slow-utf8-text.pl as flaky
as it does not always time out.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
- platform/efl/TestExpectations:
- 1:34 AM Changeset in webkit [127408] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Build fix for ENABLE(CLASSIC_INTERPRETER) after r127393.
- interpreter/Interpreter.h:
- 1:30 AM Changeset in webkit [127407] by
-
- 2 edits5 deletes in trunk/LayoutTests
Unreviewed, rolling out r127406.
http://trac.webkit.org/changeset/127406
https://bugs.webkit.org/show_bug.cgi?id=95674
Expectation images are missing (Requested by yosin1 on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-03
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
- platform/chromium/TestExpectations:
- 1:22 AM Changeset in webkit [127406] by
-
- 2 edits5 adds in trunk/LayoutTests
Unreviewed rebaseline for bug 94287.
Update Chromium-Mac and Chromium-Win images for multiple field time input UI.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
- platform/chromium/TestExpectations:
- 1:18 AM Changeset in webkit [127405] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage API test
https://bugs.webkit.org/show_bug.cgi?id=95671
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
Reviewed by Kenneth Rohde Christiansen.
Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage
API test since it is flaky on the bots.
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(TEST_F):
- 1:16 AM Changeset in webkit [127404] by
-
- 4 edits in trunk
[GTK][EFL] 'dictIter' iterator is not initialized for an inner loop
https://bugs.webkit.org/show_bug.cgi?id=95436
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
The 'checkSpellingOfString' method assumes that the given string is concatenation of words.
To properly handle spellchecking of each word we need to iterate over the all available
dictionaries ('dictIter').
To allow spellchecking for multiple words, 'dictIter' should be initialized at the beginning
of vector while spellchecking of the word. This ensures performing of spelling for word based on
at least one dictionary.
- platform/text/enchant/TextCheckerEnchant.cpp:
(TextCheckerEnchant::checkSpellingOfString): Moved initialization of 'dictIter' to an inner loop.
LayoutTests:
'checkSpellingOfString' from the TextCheckerEnchant class can not mark multiplie words that are misspelled.
It's possible to mark misspeled string only by defining its location and length.
- platform/gtk/TestExpectations: Added spelling-backspace-between-lines.html to TestExpectations.
- 1:14 AM Changeset in webkit [127403] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Mark several inspector test as flaky
https://bugs.webkit.org/show_bug.cgi?id=95667
Unreviewed EFL gardening.
Mark several inspector test cases as flaky on
WebKit2 EFL.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
- platform/efl-wk2/TestExpectations:
- 12:35 AM Changeset in webkit [127402] by
-
- 2 edits in trunk/LayoutTests
[EFL] Update TestExpectations for 2 fast/block tests
https://bugs.webkit.org/show_bug.cgi?id=95666
Unreviewed EFL gardening.
Update TestExpectations for 2 fast/block tests to
indicate that we expect TEXT only diff on the bot
since we don't run pixel tests.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
- platform/efl/TestExpectations:
Sep 2, 2012:
- 11:57 PM Changeset in webkit [127401] by
-
- 2 edits in trunk/Source/WebKit2
WK2: Build failure on SnowLeopard after r127384
https://bugs.webkit.org/show_bug.cgi?id=95665
Reviewed by Dan Bernstein.
Add SandboxExtension::consumePermanently(const Handle&) for !ENABLE(WEB_PROCESS_SANDBOX) to fix link error.
- Shared/SandboxExtension.h:
(WebKit::SandboxExtension::consumePermanently):
- 11:03 PM Changeset in webkit [127400] by
-
- 3 edits in trunk/Source/WebCore
[Forms] Empty visible value of AM/PM field of multiple fields time input UI should display variable number of "-" based on maximum number of labels
https://bugs.webkit.org/show_bug.cgi?id=95660
Reviewed by Kent Tamura.
This patch changes visible empty value of AM/PM field in multiple
fields time input UI to "-", "--", "---", and so on based on maximum
length of AM/PM labels. In current implementation, it is always "--"
regardless locale, although on Arabic, AM/PM are represented in one
character.
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(makeVisibleEmptyValue): Build visible empty value from maximum length
of labels.
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Changed to
use m_visibleEmptyValue.
- html/shadow/DateTimeSymbolicFieldElement.h:
(WebCore::DateTimeSymbolicFieldElement): Added new member variable
m_visibleEmptyValue to hold visible empty value.
- 10:51 PM Changeset in webkit [127399] by
-
- 5 edits1 delete in trunk/LayoutTests
[Chromium] Unreviewed test expectation update after r127398
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
- 9:03 PM Changeset in webkit [127398] by
-
- 4 edits in trunk/Source/WebCore
[Forms] AM/PM field of multiple fields time input UI should be fixed width
https://bugs.webkit.org/show_bug.cgi?id=95542
Reviewed by Kent Tamura.
This patch changes width of AM/PM field of multiple field time input
UI fixed as maximum width of labels or "--".
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.
- css/html.css:
(input::-webkit-datetime-edit-ampm-field): Added "display" property to "inline-block" for setting width.
Added "text-align" property to "center".
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement): Changed to call setHasCustomCallback().
(WebCore::DateTimeSymbolicFieldElement::customStyleForRenderer): Added for setting field with from maximum width of labels.
- html/shadow/DateTimeSymbolicFieldElement.h:
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Added for using visible empty value in customStyleForRenderer() and visibleValue().
(WebCore::DateTimeSymbolicFieldElement::visibleValue): Changed to call visibleEmptyValue() instead of using literal "--".
(DateTimeSymbolicFieldElement): Added a declaration of customStyleForRenderer().
- 7:04 PM Changeset in webkit [127397] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Keep activePopupMenu to call valueChangedForPopupMenu() outside showPopupMenu()
https://bugs.webkit.org/show_bug.cgi?id=95355
Reviewed by Gyuyoung Kim.
Efl does not have a proper way to support nested loop so that applications
may change value after showPopupMenu() is finished.
- UIProcess/API/efl/tests/test_ewk2_view.cpp: Improved test case to cover this bug.
(selectItemAfterDelayed):
(showPopupMenu):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
Guard with !PLATFORM(EFL) to keep the activePopupMenu valid to call valueChangedForPopupMenu
outside showPopupMenu().
- 6:05 PM Changeset in webkit [127396] by
-
- 6 edits5 adds9 deletes in trunk/LayoutTests
[Tests] fast/forms/time-multiple-fields/time-multiple-fields-appearance-*.html should dump text instead of render tree
https://bugs.webkit.org/show_bug.cgi?id=95545
Reviewed by Kent Tamura.
This patch changes test expectations to text output and pixel images
instead of structure of render tree and pixel images for multiple
fields time input UI. This patch helps us to avoid rebaseline when
we change DOM structure but keep appearance.
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Changed to call testRunner.dumpAsText().
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Changed to call testRunner.dumpAsText().
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html: Changed to call testRunner.dumpAsText().
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Changed to call testRunner.dumpAsText().
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: Changed to call testRunner.dumpAsText().
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- 5:24 PM Changeset in webkit [127395] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectation update after r127362
- platform/chromium/TestExpectations: Moved
fast/notifications/notifications-event-listener-crash.html to
http/tests/notifications.
- 4:52 PM WebKitGTK/1.10.x edited by
- (diff)
- 4:45 PM Changeset in webkit [127394] by
-
- 5 edits in trunk/Source/JavaScriptCore
Fixed failures seen on Linux bots.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_push_with_scope):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_push_with_scope):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: push_*_scope doesn't have a destination operand anymore.
Accordingly, update these places in the baseline JIT, which I missed in my last patch.
- 2:27 PM Changeset in webkit [127393] by
-
- 16 edits in trunk/Source/JavaScriptCore
Refactored scope chain opcodes to support optimization for named function expressions
https://bugs.webkit.org/show_bug.cgi?id=95658
Reviewed by Sam Weinig.
Renamed
push_scope => push_with_scope
push_new_scope => push_name_scope
to clarify the difference between them.
Changed push_with_scope and push_name_scope not to save the new scope in
a temporary register, since doing so made optimization harder.
(The old behavior was a hold-over from when the scope chain wasn't
a GC object, and wouldn't be marked otherwise. Now, the scope chain is
marked because it is a GC object pointed to by the call frame.)
Changed push_name_scope to accept an operand specifying the attributes
for the named property, instead of assuming DontDelete, because a named
function expression needs ReadOnly|DontDelete.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::highestUsedRegister): Removed this function,
which used to be related to preserving saved scope object temporaries,
because it had no callers.
- 1:26 PM Changeset in webkit [127392] by
-
- 2 edits in trunk/Source/WebCore
Improve the way we use convertedSpaceString() in convertHTMLTextToInterchangeFormat()
https://bugs.webkit.org/show_bug.cgi?id=95301
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-02
Reviewed by Darin Adler.
The static string convertedSpaceString() had a couple of annoying side effects:
-The string was 16bits due to noBreakSpace, which forced any input to be converted to 16bits.
-The string was kept in the heap for no particular reason.
This patch redefines convertedSpaceString as a constant literal so that we can use it efficiently.
The patch also make the binary a tiny bit smaller (700 bytes).
- editing/HTMLInterchange.cpp:
(WebCore::convertHTMLTextToInterchangeFormat):
- 11:57 AM Changeset in webkit [127391] by
-
- 2 edits in trunk/Source/WebCore
Build is broken when SVG is disabled.
https://bugs.webkit.org/show_bug.cgi?id=95653
Patch by Mike West <mkwst@chromium.org> on 2012-09-02
Reviewed by Dirk Schulze.
Adding CSSPropertyWebkitClipPath to the massive switch statement in StyleResolver.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- 10:43 AM Changeset in webkit [127390] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Add missing semicolon at the end of some lines.
https://bugs.webkit.org/show_bug.cgi?id=95640
Patch by Byungwoo Lee <bw80.lee@gmail.com> on 2012-09-02
Reviewed by Gyuyoung Kim.
EWK_VIEW_PRIV_GET_OR_RETURN macro and other related macro can be used
without semicolon, because it ends with a semicolon or complete block.
This can make a human mistake about missing semicolon.
Fixed the macros to require semicolon, and added missing semicolons.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_initialize):
- 10:09 AM Changeset in webkit [127389] by
-
- 4 edits1 move in trunk/LayoutTests
fast/html/marquee-alternate.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=94130
Patch by Jessie Berlin <jberlin@apple.com> on 2012-09-02
Reviewed by Simon Fraser.
Disable the test because it is flakey on so many platforms. Remove it from the Skipped and
TestExpectations files so that run-webkit-tests doesn't go looking for it.
- fast/html/marquee-alternate.html-disabled: Renamed from LayoutTests/fast/html/marquee-alternate.html.
- platform/chromium/TestExpectations:
- platform/efl/Skipped:
- platform/qt-arm/Skipped:
- 3:34 AM Changeset in webkit [127388] by
-
- 4 edits in trunk/Source/WebCore
Repaints should not be deferred after initial page load is complete
https://bugs.webkit.org/show_bug.cgi?id=95480
Reviewed by Simon Fraser
Any dynamically triggered resource loading currently sends us back to deferred paint mode, making animation choppy.
This is not the intention of this code.
This patch adds an additional condition that prevents page from re-entering deferred repaint mode after the initial
load has completed. It also cleans up the code slightly.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):
Add additional call to checkStopDelayingDeferredRepaints() after a frame load completes as the
new condition in shouldUseLoadTimeDeferredRepaintDelay() looks for this change too.
- page/FrameView.cpp:
(WebCore):
Reduced the normal delay from 25ms to 16ms to not interfere with full framerate animation.
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::checkFlushDeferredRepaintsAfterLoadComplete):
Ensure the repaint delay is reset after load completes even if we don't currently need a repaint.
(WebCore::FrameView::flushDeferredRepaints):
We had to identical functions, flushDeferredRepaints() and stopDelayingDeferredRepaints(). Remove
the latter.
(WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):
Factor the test for using load time repaint timings to a functions. The test for
initial page load having completed is new.
(WebCore::FrameView::updateDeferredRepaintDelay):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):
- page/FrameView.h:
(FrameView):
- 1:34 AM Changeset in webkit [127387] by
-
- 2 edits in trunk/Source/WebCore
Don't create access error strings if there is no access error
https://bugs.webkit.org/show_bug.cgi?id=95652
Reviewed by Adam Barth.
This undoes the 50% performance regression in pdfjs caused by
http://trac.webkit.org/changeset/126165
No new tests because behavior is unchanged.
- bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToFrame):
(WebCore::shouldAllowAccessToDOMWindow):
Sep 1, 2012:
- 10:51 PM Changeset in webkit [127386] by
-
- 2 edits in trunk/Source/WebKit2
Remove unused member variable from WebProcess.
Rubber-stamped by Dan Bernstein.
- WebProcess/WebProcess.h:
(WebProcess):
Remove m_applicationCachePathExtension.
- 9:31 PM Changeset in webkit [127385] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Refactoring the DumpRenderTreeSupportEfl
https://bugs.webkit.org/show_bug.cgi?id=95544
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-01
Reviewed by Gyuyoung Kim.
There are lots of repeated codes for getting the WebCore::Frame
and WebCore::Page. To reduce these duplications, simple macros
are added.
No new tests, just refactoring.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::activeAnimationsCount):
(DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
(DumpRenderTreeSupportEfl::clearFrameName):
(DumpRenderTreeSupportEfl::clearOpener):
(DumpRenderTreeSupportEfl::elementDoesAutoCompleteForElementWithId):
(DumpRenderTreeSupportEfl::frameChildren):
(DumpRenderTreeSupportEfl::frameParent):
(DumpRenderTreeSupportEfl::layoutFrame):
(DumpRenderTreeSupportEfl::numberOfPages):
(DumpRenderTreeSupportEfl::pageSizeAndMarginsInPixels):
(DumpRenderTreeSupportEfl::pageProperty):
(DumpRenderTreeSupportEfl::pauseAnimation):
(DumpRenderTreeSupportEfl::pauseTransition):
(DumpRenderTreeSupportEfl::pendingUnloadEventCount):
(DumpRenderTreeSupportEfl::renderTreeDump):
(DumpRenderTreeSupportEfl::responseMimeType):
(DumpRenderTreeSupportEfl::selectionRectangle):
(DumpRenderTreeSupportEfl::suitableDRTFrameName):
(DumpRenderTreeSupportEfl::setDefersLoading):
(DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting):
(DumpRenderTreeSupportEfl::addUserScript):
(DumpRenderTreeSupportEfl::clearUserScripts):
(DumpRenderTreeSupportEfl::addUserStyleSheet):
(DumpRenderTreeSupportEfl::clearUserStyleSheets):
(DumpRenderTreeSupportEfl::executeCoreCommandByName):
(DumpRenderTreeSupportEfl::findString):
(DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled):
(DumpRenderTreeSupportEfl::isCommandEnabled):
(DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled):
(DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled):
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportEfl::globalContextRefForFrame):
(DumpRenderTreeSupportEfl::setInteractiveFormValidationEnabled):
(DumpRenderTreeSupportEfl::setValidationMessageTimerMagnification):
(DumpRenderTreeSupportEfl::setAuthorAndUserStylesEnabled):
(DumpRenderTreeSupportEfl::setComposition):
(DumpRenderTreeSupportEfl::hasComposition):
(DumpRenderTreeSupportEfl::compositionRange):
(DumpRenderTreeSupportEfl::confirmComposition):
(DumpRenderTreeSupportEfl::firstRectForCharacterRange):
(DumpRenderTreeSupportEfl::selectedRange):
- 8:08 PM Changeset in webkit [127384] by
-
- 10 edits in trunk/Source/WebKit2
Use dynamic sandbox extension rather than sandbox parameters for paths provided by the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=95651
Reviewed by Dan Bernstein.
This is the first step to not relying on the initialization message to initialize
the sandbox.
- Shared/SandboxExtension.h:
(SandboxExtension):
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::consumePermanently):
Add static version of SandboxExtension::consumePermanently which takes a
SandboxExtension::Handle. There is no reason to create a SandboxExtension
just to consume it forever.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
Add SandboxExtension::Handles for paths we need access to, and remove
webInspectorBaseDirectory, which is unused.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
Create SandboxExtension::Handles for paths we need access to, and move
getting the presenterApplicationPid to platformInitializeWebProcess, since
it is Mac only.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Move setting the presenterApplicationPid to platformInitializeWebProcess.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
(WebKit::WebProcess::platformInitializeWebProcess):
Replace the use of sandbox parameters for opening access for necessary paths
with permanent consumption of sandbox extensions.
- WebProcess/com.apple.WebProcess.sb.in:
Remove sandbox rules that are now handled via extensions.
- 5:15 PM Changeset in webkit [127383] by
-
- 5 edits18 adds in trunk
Use -webkit-clip-path shapes to clip SVG elements
https://bugs.webkit.org/show_bug.cgi?id=95620
Reviewed by Rob Buis.
Source/WebCore:
This patch adds a path segment for a BasicShape to a given Path object. This
path and it's wind rule are used to clip the context of the SVG element.
Tests: svg/clip-path/clip-path-shape-circle-1-expected.svg
svg/clip-path/clip-path-shape-circle-1.svg
svg/clip-path/clip-path-shape-circle-2-expected.svg
svg/clip-path/clip-path-shape-circle-2.svg
svg/clip-path/clip-path-shape-ellipse-1-expected.svg
svg/clip-path/clip-path-shape-ellipse-1.svg
svg/clip-path/clip-path-shape-ellipse-2-expected.svg
svg/clip-path/clip-path-shape-ellipse-2.svg
svg/clip-path/clip-path-shape-polygon-1-expected.svg
svg/clip-path/clip-path-shape-polygon-1.svg
svg/clip-path/clip-path-shape-polygon-2-expected.svg
svg/clip-path/clip-path-shape-polygon-2.svg
svg/clip-path/clip-path-shape-polygon-3-expected.svg
svg/clip-path/clip-path-shape-polygon-3.svg
svg/clip-path/clip-path-shape-rounded-rect-1-expected.svg
svg/clip-path/clip-path-shape-rounded-rect-1.svg
svg/clip-path/clip-path-shape-rounded-rect-2-expected.svg
svg/clip-path/clip-path-shape-rounded-rect-2.svg
- rendering/style/BasicShapes.cpp: Added helper functions that apply path segments to a given path.
(WebCore::BasicShapeRectangle::path):
(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapePolygon::path):
- rendering/style/BasicShapes.h: Make BasicShape virtualized again, since new virtual functions were added.
(WebCore::BasicShape::~BasicShape):
(BasicShape):
(WebCore::BasicShape::windRule): Will return the wind rule of the shape - nonzero by default.
(WebCore::BasicShape::BasicShape):
(BasicShapeRectangle):
(WebCore::BasicShapeRectangle::type): Removed member variable and return type per inheriting class directly.
(WebCore::BasicShapeRectangle::BasicShapeRectangle):
(BasicShapeCircle):
(WebCore::BasicShapeCircle::type): Ditto.
(WebCore::BasicShapeCircle::BasicShapeCircle):
(BasicShapeEllipse):
(WebCore::BasicShapeEllipse::type): Ditto.
(WebCore::BasicShapeEllipse::BasicShapeEllipse):
(BasicShapePolygon):
(WebCore::BasicShapePolygon::windRule):
(WebCore::BasicShapePolygon::type): Ditto.
(WebCore::BasicShapePolygon::BasicShapePolygon):
- rendering/svg/SVGRenderingContext.cpp: If -webkit-clip-path was defined, clip the context to the shape.
Right now -webkit-clip-path overrides clip-path, so that people don't use both at the same time. Current
clip-path property will be replaced, once -webkit-clip-path gets unprefixed.
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
LayoutTests:
New tests to check behavior of -webkit-clip-path on SVG elements.
- svg/clip-path/clip-path-shape-circle-1-expected.svg: Added.
- svg/clip-path/clip-path-shape-circle-1.svg: Added.
- svg/clip-path/clip-path-shape-circle-2-expected.svg: Added.
- svg/clip-path/clip-path-shape-circle-2.svg: Added.
- svg/clip-path/clip-path-shape-ellipse-1-expected.svg: Added.
- svg/clip-path/clip-path-shape-ellipse-1.svg: Added.
- svg/clip-path/clip-path-shape-ellipse-2-expected.svg: Added.
- svg/clip-path/clip-path-shape-ellipse-2.svg: Added.
- svg/clip-path/clip-path-shape-polygon-1-expected.svg: Added.
- svg/clip-path/clip-path-shape-polygon-1.svg: Added.
- svg/clip-path/clip-path-shape-polygon-2-expected.svg: Added.
- svg/clip-path/clip-path-shape-polygon-2.svg: Added.
- svg/clip-path/clip-path-shape-polygon-3-expected.svg: Added.
- svg/clip-path/clip-path-shape-polygon-3.svg: Added.
- svg/clip-path/clip-path-shape-rounded-rect-1-expected.svg: Added.
- svg/clip-path/clip-path-shape-rounded-rect-1.svg: Added.
- svg/clip-path/clip-path-shape-rounded-rect-2-expected.svg: Added.
- svg/clip-path/clip-path-shape-rounded-rect-2.svg: Added.
- 1:29 PM Changeset in webkit [127382] by
-
- 4 edits1 add1 delete in trunk
[Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=95605
Reviewed by Dirk Pranke.
Tools:
Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.check_sys_deps):
(ChromiumAndroidPort.expectations_files):
(ChromiumAndroidPort.clean_up_test_run):
LayoutTests:
Moved the skipping rules for ANDROID into platform/chromium-android/TestExpectations.
- platform/chromium/TestExpectations:
- platform/chromium/test_expectations_android.txt: Removed.
- platform/chromium-android/TestExpectations: Added.
- 12:46 PM Changeset in webkit [127381] by
-
- 8 edits2 adds in trunk
Regression(r126763): Heap-use-after-free in WebCore::nextBreakablePosition
https://bugs.webkit.org/show_bug.cgi?id=95229
Patch by Ned Holbrook <nholbrook@apple.com> on 2012-09-01
Reviewed by Dan Bernstein.
Source/WebCore:
TextLayout and LazyLineBreakIterator cache a RenderText's string during line breaking but RenderCounter
and RenderQuote can replace that string during preferred width calculation. This patch adds a non-virtual member
function to RenderText named updateTextIfNeeded() that triggers immediate string replacement by calling
the new virtual updateText() if necessary, which in turn calls computePreferredLogicalWidths(). In this way
RenderBlock::LineBreaker::nextLineBreak() can ensure a RenderText's string is current before caching it.
Test: fast/css/content/content-quotes-crash.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer): Drive-by: replace existing code with the equivalent updateTextIfNeeded().
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Use updateTextIfNeeded() prior to caching RenderText string.
- rendering/RenderCounter.cpp:
(WebCore::RenderCounter::updateText): Call computePreferredLogicalWidths().
(WebCore):
- rendering/RenderCounter.h:
(RenderCounter):
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::updateText): Call computePreferredLogicalWidths().
(WebCore):
- rendering/RenderQuote.h:
(RenderQuote):
- rendering/RenderText.h:
(WebCore::RenderText::updateTextIfNeeded): Only call virtual updateText() if necessary.
(RenderText):
(WebCore::RenderText::updateText): Add no-op default implementation for new virtual member function.
LayoutTests:
Ensure line breaking doesn't crash due to text of RenderText being changed.
- fast/css/content/content-quotes-crash-expected.txt: Added.
- fast/css/content/content-quotes-crash.html: Added.
- 12:42 PM Changeset in webkit [127380] by
-
- 9 edits in trunk
fast/events/message-port-clone.html hits ASSERT in Debug (usually in later tests)
https://bugs.webkit.org/show_bug.cgi?id=85811
Patch by Li Yin <li.yin@intel.com> on 2012-09-01
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
When MessagePort invoked close function, the close status is needed to set,
regardless of whether the port is cloned or not.
Tests: fast/events/message-port-clone.html
fast/events/message-port-close.html
- dom/MessagePort.cpp:
(WebCore::MessagePort::close): Must set m_closed to be true.
LayoutTests:
- platform/gtk/TestExpectations:
- platform/mac/Skipped:
- platform/qt-4.8/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/Skipped:
- 12:26 PM Changeset in webkit [127379] by
-
- 2 edits2 adds2 deletes in trunk/LayoutTests
[Chromium-Android] Upstream layout test expectations (Part 4)
https://bugs.webkit.org/show_bug.cgi?id=95594
Reviewed by Adam Barth.
Remove a font boosting test which has been removed in downstream.
Update canvas test expectations.
Rebaselined one canvas test (only one space diff).
- platform/chromium-android/fast/canvas/fallback-content-expected.txt: Added.
- platform/chromium-android/fast/font-boosting/various-tricky-cases-expected.txt: Removed.
- platform/chromium-android/fast/font-boosting/various-tricky-cases.html: Removed.
- platform/chromium/TestExpectations:
- 12:06 PM Changeset in webkit [127378] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed chromium buildfix when use_libcc_for_compositor=1
This gyp target was renamed downstream.
- WebKit.gyp:
- 11:16 AM Changeset in webkit [127377] by
-
- 2 edits in trunk/LayoutTests
[Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure
https://bugs.webkit.org/show_bug.cgi?id=95643
Unreviewed GTK gardening, rebaselining an accessibility test.
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Corrected.
- 10:49 AM Changeset in webkit [127376] by
-
- 2 edits in trunk/Source/JavaScriptCore
2012-09-01 Geoffrey Garen <ggaren@apple.com>
Rolled back out a piece of <http://trac.webkit.org/changeset/127293>
because it broke inspector tests on Windows.
Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591
Reviewed by Sam Weinig.
- 10:47 AM Changeset in webkit [127375] by
-
- 4 edits in trunk/Source/WebCore
Share inline style between cloned Nodes (copy on write.)
<http://webkit.org/b/95451>
Reviewed by Antti Koivisto.
When cloning a Node, use an immutable StylePropertySet for the new Node's inline style.
If the old Node already had an immutable inline style, we now reuse that, avoiding a copy.
Copying is deferred until mutation (either via CSSOM or setting of the style attribute.)
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::cloneDataFrom):
- css/StylePropertySet.h:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::immutableCopyIfNeeded):
Added. Simply returns 'this' if the object is already immutable, otherwise creates a new one.
- 10:36 AM Changeset in webkit [127374] by
-
- 25 edits1 copy2 adds in trunk/Source
LLInt C loop backend.
https://bugs.webkit.org/show_bug.cgi?id=91052.
Patch by Mark Lam <mark.lam@apple.com> on 2012-09-01
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::bytecodeOffset):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC):
- interpreter/Interpreter.h:
- jit/JITStubs.h:
(JITStackFrame):
(JSC):
- llint/LLIntCLoop.cpp: Added.
(JSC):
(LLInt):
(JSC::LLInt::CLoop::initialize):
(JSC::LLInt::CLoop::catchRoutineFor):
(JSC::LLInt::CLoop::hostCodeEntryFor):
(JSC::LLInt::CLoop::jsCodeEntryWithArityCheckFor):
(JSC::LLInt::CLoop::jsCodeEntryFor):
- llint/LLIntCLoop.h: Added.
(JSC):
(LLInt):
(CLoop):
- llint/LLIntData.cpp:
(JSC::LLInt::initialize):
- llint/LLIntData.h:
(JSC):
- llint/LLIntOfflineAsmConfig.h:
- llint/LLIntOpcode.h:
- llint/LLIntThunks.cpp:
(LLInt):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter.cpp:
(LLInt):
(JSC::LLInt::Ints2Double):
(JSC):
(JSC::CLoop::execute):
- llint/LowLevelInterpreter.h:
(JSC):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/asm.rb:
- offlineasm/backends.rb:
- offlineasm/cloop.rb: Added.
- offlineasm/instructions.rb:
- runtime/Executable.h:
(ExecutableBase):
(JSC::ExecutableBase::hostCodeEntryFor):
(JSC::ExecutableBase::jsCodeEntryFor):
(JSC::ExecutableBase::jsCodeWithArityCheckEntryFor):
(JSC::ExecutableBase::catchRoutineFor):
(NativeExecutable):
- runtime/JSValue.h:
(JSC):
(LLInt):
(JSValue):
- runtime/JSValueInlineMethods.h:
(JSC):
(JSC::JSValue::JSValue):
- runtime/Options.cpp:
(JSC::Options::initialize):
Source/WTF:
Added configs for the llint C loop backend.
- wtf/Platform.h:
- 10:22 AM Changeset in webkit [127373] by
-
- 2 edits in trunk/Source/JavaScriptCore
Rolled back in a piece of <http://trac.webkit.org/changeset/127293>.
Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591
Reviewed by Sam Weinig.
- 9:14 AM Changeset in webkit [127372] by
-
- 2 edits in trunk/Source/WebKit/mac
Added #include <JavaScriptCore/Identifier.h>.
https://bugs.webkit.org/show_bug.cgi?id=95641.
Patch by Mark Lam <mark.lam@apple.com> on 2012-09-01
Reviewed by Dan Bernstein.
The code references JSC::Indentifier but was previously depending on
someone else to #include it. This results in build problems when
building for the llint C loop configuration.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- 7:42 AM Changeset in webkit [127371] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix the --minimal build after r127327
https://bugs.webkit.org/show_bug.cgi?id=95639
Unreviewed attempt to fix Qt minimal build.
- css/StyleBuilder.cpp:
- 7:02 AM WebKitGTK/1.8.x edited by
- (diff)
- 7:01 AM WebKitGTK/1.8.x edited by
- (diff)
- 3:51 AM Changeset in webkit [127370] by
-
- 5 edits2 adds in trunk
[Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811
Part of the bug was due to expected accessible objects of DivRole
and ParagraphRole being ignored, in favor of including child blocks.
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.
Source/WebCore:
Test: platform/gtk/accessibility/spans-paragraphs-and-divs.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::firstAnonymousBlockChild):
(WebCore):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
New method to return the first child which is an anonymous block.
- accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Include paragraphs and divs which contain a non-nested anonymous block.
LayoutTests:
Added new test to verify that paragraphs and divs which contain anonymous
blocks are included in the accessible object hierarchy and have the correct
number of children with the expected role.
- platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt: Added.
- platform/gtk/accessibility/spans-paragraphs-and-divs.html: Added.
- 3:47 AM Changeset in webkit [127369] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, rebaselining an accessibility test.
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
- 1:53 AM Changeset in webkit [127368] by
-
- 8 edits2 adds in trunk
[Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811
Part of the bug was due to extraneous accessible objects resulting
from unignored inline and block spans.
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.
Source/WebCore:
Test: platform/gtk/accessibility/spans.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Ignore objects that have spanTag tag name.
- accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore most anonymous blocks.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(roleIsTextType): Add ListItem to the roles which should implement AtkText.
LayoutTests:
Added new test, updated the results of one test to reflect the fix,
corrected a test with a mismatched element tag.
- platform/gtk/accessibility/aria-roles-unignored-expected.txt: Corrected results having fixed tag.
- platform/gtk/accessibility/aria-roles-unignored.html: Fixed mismatched element tag.
- platform/gtk/accessibility/media-element-expected.txt: Updated to reflect removal of extraneous object.
- platform/gtk/accessibility/spans-expected.txt: Added.
- platform/gtk/accessibility/spans.html: Added.
- 1:43 AM Changeset in webkit [127367] by
-
- 8 edits4 adds in trunk
[Gtk] Incorrect/unexpected characters in the text of certain accessibles
https://bugs.webkit.org/show_bug.cgi?id=95180
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.
Source/WebCore:
The bug was caused by failing to properly handle anonymous block text
which had object replacement characters (multibyte) in it. Calculating
the string length based on the UTF-8 string meant that we were returning
more characters than were there and in danger of splitting a multibyte
character.
Tests: platform/gtk/accessibility/entry-and-password.html
platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html
- accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetText): Convert the text returned by textForObject()
to Unicode before calculating its length.
Source/WebKit/gtk:
Corrected a unit test in which the expected accessible text was wrong as
a result of this bug. In particular, the AtkText inserted into an empty
text field is expected to be the same text atk_text_get_text() returns.
That was not happening -- and presumably not noticed as a result of the
hard to read textual representation of the multibyte password field
bullets.
- tests/testatk.c:
(testWebkitAtkTextChangedNotifications): Corrected the test and added a
comment so that one knows what the multibyte character is.
Tools:
The bug that was fixed stood in the way of fully implementing stringValue().
Testing that the bug is fixed requires stringValue() to be fully implemented
and object replacement characters to be printable.
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(replaceCharactersForResults): New method which turns object replacement
characters into "<obj>" so that the characters can be properly shown in
Layout Test results. Also turns "\n" into "<
n>" so that printing the
accessible text of a single object in the accessible tree doesn't mess up
the readibility of the results.
(AccessibilityUIElement::stringValue): Remove the code that immediately
returned upon encountering an object of ATK_ROLE_PANEL and call the new
replaceCharactersForResults() prior to returning the accessible string
value.
LayoutTests:
Two new layout tests, plus one updated one.
- platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Indicated replaced objects.
- platform/gtk/accessibility/entry-and-password-expected.txt: Added.
- platform/gtk/accessibility/entry-and-password.html: Added.
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Added.
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html: Added.
- 1:20 AM Changeset in webkit [127366] by
-
- 17 edits in trunk/Source/WebCore
Remove all-but-one use of WTF::String::operator+= from WebCore
https://bugs.webkit.org/show_bug.cgi?id=95508
Reviewed by Benjamin Poulain.
This patch removes all the uses of WTF::String::operator+= from
WebCore, except those in WorkerScriptLoader (which need a more delicate
patch). There were actually a handful of legitimate use cases for += in
this group. I've replaced them with calls to String::append rather than
+= so that we can remove += and encourage most contributors to use
more efficient string idioms.
(There are likely some more uses in WebCore hiding in port-specific
code---this patch covers only those call sites found when compiling the
chromium-mac port.)
- inspector/InspectorStyleTextEditor.cpp:
(WebCore::InspectorStyleTextEditor::insertProperty):
- This complicated function looks really inefficient, but I didn't have the heart to rewrite it.
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::sheetText):
(WebCore::CachedCSSStyleSheet::data):
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureSVGFontData):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::script):
- loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::data):
- This decoder/flush pattern can probably be improved by combining the decode and flush operations, but I didn't do that in this patch.
- page/FrameTree.cpp:
(WebCore::FrameTree::uniqueChildName):
- I found this code very amusing. It's worried enough about efficiency to give a big speech about why snprintf is safe, but then it implicitly performs a large number of mallocs and memcpy operations.
- page/Page.cpp:
(WebCore::Page::userStyleSheet):
- platform/chromium/support/WebHTTPLoadInfo.cpp:
(WebKit::addHeader):
- platform/chromium/support/WebURLResponse.cpp:
(WebKit::WebURLResponse::addHTTPHeaderField):
- This header-appending idiom looks like a reasonable use case for String::append.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::setRequestHeaderInternal):
- xml/XPathFunctions.cpp:
(WebCore::XPath::FunTranslate::evaluate):
- Fixes 6 year old FIXME.
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::append):
- xml/parser/XMLDocumentParser.h:
(XMLDocumentParser):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doEnd):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::doEnd):
- Changed m_originalSourceForTransform to a SegmentedString so that we don't need to malloc and copy the entire document every time we get more data from the network.
- 12:54 AM Changeset in webkit [127365] by
-
- 22 edits2 adds in trunk
MediaStream API: Add MediaStream management to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95543
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/WebMediaStreamCenter.h:
(WebMediaStreamCenter):
- chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
- chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebKit):
(WebRTCPeerConnectionHandlerClient):
Source/WebCore:
This includes addStream/removeStream to RTCPeerConnection,
as well as didAddRemoteStream/didRemoveRemoteStream to RTCPeerConnectionHandlerClient.
Test: fast/mediastream/RTCPeerConnection-AddRemoveStream.html
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::parseConfiguration):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::addStream):
(WebCore):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::localStreams):
(WebCore::RTCPeerConnection::remoteStreams):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):
- Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- bindings/js/Dictionary.cpp:
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):
- bindings/v8/Dictionary.h:
(Dictionary):
- platform/mediastream/RTCPeerConnectionHandler.cpp:
(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::addStream):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::removeStream):
- platform/mediastream/RTCPeerConnectionHandler.h:
(RTCPeerConnectionHandler):
- platform/mediastream/RTCPeerConnectionHandlerClient.h:
(WebCore):
(RTCPeerConnectionHandlerClient):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::addStream):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::removeStream):
(WebCore::RTCPeerConnectionHandlerChromium::didAddRemoteStream):
(WebCore::RTCPeerConnectionHandlerChromium::didRemoveRemoteStream):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(WebKit):
(RTCPeerConnectionHandlerChromium):
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
Tools:
Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::addStream):
(MockWebRTCPeerConnectionHandler::removeStream):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):
LayoutTests:
- fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-AddRemoveStream.html: Added.
- 12:49 AM Changeset in webkit [127364] by
-
- 1 edit4 adds in trunk/LayoutTests
[Tests] Add a test for all notification events
https://bugs.webkit.org/show_bug.cgi?id=95609
<rdar://problem/12218309>
Reviewed by Jessie Berlin.
This test tests for the onshow, onclick, and onclose events. onerror is called only if the
origin did not have permission to show the notification, and that is covered in
http/tests/notifications/{legacy,}/show.html.
- http/tests/notifications/events-expected.txt: Added.
- http/tests/notifications/events.html: Added.
- http/tests/notifications/legacy/events-expected.txt: Added.
- http/tests/notifications/legacy/events.html: Added.
- 12:45 AM Changeset in webkit [127363] by
-
- 12 edits in trunk/Source/JavaScriptCore
2012-09-01 Geoffrey Garen <ggaren@apple.com>
Rolled back in a piece of <http://trac.webkit.org/changeset/127293>.
Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591
Reviewed by Sam Weinig.
- runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation):
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::JSGlobalObject): (JSC::JSGlobalObject::setGlobalThis): (JSC): (JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h: (JSGlobalObject): (JSC::JSScope::globalThis): (JSC): (JSC::JSGlobalObject::globalThis):
- runtime/JSNameScope.h: (JSC::JSNameScope::JSNameScope):
- runtime/JSScope.cpp: (JSC::JSScope::visitChildren):
- runtime/JSScope.h: (JSScope): (JSC::JSScope::JSScope): (JSC::JSScope::globalObject): (JSC::JSScope::globalData):
- runtime/JSSegmentedVariableObject.h: (JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):
- runtime/JSSymbolTableObject.h: (JSC::JSSymbolTableObject::JSSymbolTableObject):
- runtime/JSVariableObject.h: (JSC::JSVariableObject::JSVariableObject):
- runtime/JSWithScope.h: (JSC::JSWithScope::JSWithScope):
- runtime/StrictEvalActivation.cpp: (JSC::StrictEvalActivation::StrictEvalActivation):
- 12:38 AM Changeset in webkit [127362] by
-
- 1 edit2 adds2 deletes in trunk/LayoutTests
[Tests] Move fast/notifications/notifications-event-listener-crash.html to http/tests/notifications
https://bugs.webkit.org/show_bug.cgi?id=95535
<rdar://problem/12213781>
Reviewed by Jessie Berlin.
This test is among a few that are being migrated from fast/notifications to http/tests/notifications because of permissions.
Since most notifications tests will involve permissions, it is easier to have all of them consolidated in the same directory.
This test has been slightly modified to take advantage of the new testRunner notifications API. The test itself also does not
need to be protected within the window.testRunner check since it does not use that object.
- fast/notifications/notifications-event-listener-crash-expected.txt: Removed.
- fast/notifications/notifications-event-listener-crash.html: Removed.
- http/tests/notifications/event-listener-crash-expected.txt: Added.
- http/tests/notifications/event-listener-crash.html: Added.
- 12:29 AM Changeset in webkit [127361] by
-
- 2 edits in trunk/Source/WebCore
Touch a file so that Chromium-win bots correctly re-build for OPENTYPE_VERTICAL
https://bugs.webkit.org/show_bug.cgi?id=51450
- platform/graphics/opentype/OpenTypeVerticalData.cpp:
- 12:15 AM Changeset in webkit [127360] by
-
- 2 edits in trunk/Source/JavaScriptCore
2012-09-01 Geoffrey Garen <ggaren@apple.com>
Rolled back out a piece of <http://trac.webkit.org/changeset/127293>
because it broke Window inspector tests.
Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591
Reviewed by Sam Weinig.
- runtime/JSActivation.h: (JSActivation):
