Timeline



Sep 7, 2012:

11:57 PM Changeset in webkit [127963] by dmazzoni@google.com
  • 7 edits in trunk/LayoutTests

Rebaselining accessibility test expectations

11:49 PM Changeset in webkit [127962] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove browser from the build info page
https://bugs.webkit.org/show_bug.cgi?id=96162

Patch by Ming Xie <mxie@rim.com> on 2012-09-07
Reviewed by George Staikos.
Internal reviewed by Jeff Rogers.

WebKit build should not have the build info for browser which is
built on top of webkit.

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::buildPage):

11:21 PM Changeset in webkit [127961] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the build of OpenGLShims on Windows
https://bugs.webkit.org/show_bug.cgi?id=96123

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

OpenGL functions on Windows are generally defined as stdcall, so we need to make sure
that we declare our own "copies" of those functions with the same calling convention.

This is also required for the situation where we build against ANGLE, because then we
initialize the function table entries with a direct assignment (entry = ::glMyFunction())
and the assignment does not compile if the types don't match, i.e. if RHS has a different
calling convention than LHS.

The approach chosen is basically the same as in the Khronos headers,
using a GLAPIENTRY macro.

  • platform/graphics/OpenGLShims.h:
11:16 PM Changeset in webkit [127960] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed prospective build fix.

  • tests/WebCompositorInputHandlerImplTest.cpp: Looks like someone is missing an #include.

Remove the using directive from r127959.

10:53 PM Changeset in webkit [127959] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed prospective build fix.

Use WTF namespace like in other files in the same directory to resolve unqualified
adoptPtr correctly.

  • tests/WebCompositorInputHandlerImplTest.cpp:
10:46 PM Changeset in webkit [127958] by benjamin@webkit.org
  • 47 edits in trunk

Rename the ustring() accessor to string()
https://bugs.webkit.org/show_bug.cgi?id=95919

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-07
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Rename ustring() to string() to make the accessor name more logical after
r127191.

  • API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunctionWithCallback):
(JSObjectMakeFunction):
(JSObjectCopyPropertyNames):

  • API/JSProfilerPrivate.cpp:

(JSStartProfiling):
(JSEndProfiling):

  • API/JSValueRef.cpp:

(JSValueMakeString):
(JSValueMakeFromJSONString):

  • API/OpaqueJSString.cpp:

(OpaqueJSString::string):

  • API/OpaqueJSString.h:

(OpaqueJSString):

  • bytecode/CodeBlock.cpp:

(JSC::idName):
(JSC::CodeBlock::dump):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):

  • bytecompiler/NodesCodegen.cpp:

(JSC::RegExpNode::emitBytecode):
(JSC::processClauseList):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jsc.cpp:

(GlobalObject::addFunction):
(GlobalObject::addConstructableFunction):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createRegExp):

  • parser/Parser.cpp:

(JSC::::parsePrimaryExpression):

  • parser/Parser.h:

(JSC::Scope::declareVariable):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createRegExp):

  • runtime/ExceptionHelpers.cpp:

(JSC::createUndefinedVariableError):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::paramString):

  • runtime/Executable.h:

(JSC::FunctionExecutable::finishCreation):

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):

  • runtime/Identifier.h:

(JSC::Identifier::string):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::calculatedDisplayName):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSONObject.cpp:

(JSC::PropertyNameForFunctionCall::value):
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::finishCreation):

  • runtime/JSScope.cpp:

(JSC::JSScope::resolveBase):

  • runtime/JSString.h:

(JSC::inlineJSValueNotStringtoString):

  • runtime/LiteralParser.cpp:

(JSC::::parse):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::finishCreation):

Source/WebCore:

  • bindings/js/Dictionary.cpp:

(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):

  • bindings/js/SerializedScriptValue.cpp:

Simplify a few String constructions which were still using type conversion
through StringImpl.

(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::CachedString::string):
(WebCore::CloneDeserializer::readFile):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::CloneDeserializer::deserialize):

  • bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::sendWebIntentResponse):
(DumpRenderTreeSupportEfl::deliverWebIntent):
Aslo update the code from the UString->String conversion through StringImpl.

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::enumerate):

Tools:

Update EFL's DRT.

Fix some string conversion that have been made useless
with recent changes.

  • DumpRenderTree/efl/EventSender.cpp:

(keyPadNameFromJSValue):
(keyNameFromJSValue):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::queueLoad):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setValueForUser):
(TestRunner::elementDoesAutoCompleteForElementWithId):
(TestRunner::execCommand):
(TestRunner::findString):
(TestRunner::isCommandEnabled):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::pauseAnimationAtTimeOnElementWithId):
(TestRunner::pauseTransitionAtTimeOnElementWithId):
(toInt):
(TestRunner::overridePreference):
(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::evaluateInWebInspector):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::setTextDirection):

  • DumpRenderTree/efl/WorkQueueItemEfl.cpp:

(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):

10:02 PM Changeset in webkit [127957] by commit-queue@webkit.org
  • 21 edits
    2 adds in trunk

Unreviewed, rolling out r127955.
http://trac.webkit.org/changeset/127955
https://bugs.webkit.org/show_bug.cgi?id=96174

Hits an ASSERT (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/WebCore:

  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):
(GenerateNormalAttrGetter):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::objMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContext):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::init):

  • bindings/v8/V8PerContextData.h:

(V8PerContextData):

LayoutTests:

  • platform/chromium/fast/workers/storage/test-authorizer-sync-expected.txt: Added.
7:05 PM Changeset in webkit [127956] by jpfau@apple.com
  • 28 edits
    2 copies
    4 adds in trunk

Extend third-party storage blocking API to optionally allow blocking all storage
https://bugs.webkit.org/show_bug.cgi?id=95915

Reviewed by Brady Eidson.

Source/WebCore:

Replace boolean API with tri-state API that allows for blocking no, third-party, or all storage.

Tests: http/tests/security/same-origin-shared-worker-blocked.html

http/tests/security/same-origin-storage-blocked.html
http/tests/security/same-origin-websql-blocked.html

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::canAccessStorage):

  • page/SecurityOrigin.h:

(WebCore::SecurityOrigin::setStorageBlockingPolicy):
(SecurityOrigin):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setStorageBlockingPolicy):
(WebCore::Settings::storageBlockingPolicy):
(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setStorageBlockingPolicy):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

Update WK2 API to use revised Settings API.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toStorageBlockingPolicy):
(WebKit):
(WebKit::toAPI):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetStorageBlockingPolicy):
(WKPreferencesGetStorageBlockingPolicy):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Modified API test to use new revised API.

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

LayoutTests:

Update tests to use revised API.

  • http/tests/security/cross-origin-local-storage.html:
  • http/tests/security/cross-origin-plugin-private-browsing-toggled.html:
  • http/tests/security/cross-origin-plugin.html:
  • http/tests/security/cross-origin-session-storage.html:
  • http/tests/security/cross-origin-shared-worker.html:
  • http/tests/security/cross-origin-websql.html:
  • http/tests/security/cross-origin-worker-websql.html:
  • http/tests/security/resources/document-for-cross-origin-worker-websql.html:
  • http/tests/security/same-origin-document-domain-storage-allowed.html:
  • http/tests/security/same-origin-shared-worker-blocked-expected.txt: Added.
  • http/tests/security/same-origin-shared-worker-blocked.html: Added.
  • http/tests/security/same-origin-storage-blocked-expected.txt: Added.
  • http/tests/security/same-origin-storage-blocked.html: Added.
  • http/tests/security/same-origin-websql-blocked-expected.txt: Added.
  • http/tests/security/same-origin-websql-blocked.html: Added.
  • platform/chromium/TestExpectations:
6:39 PM Changeset in webkit [127955] by abarth@webkit.org
  • 21 edits
    1 delete in trunk

[V8] DOM wrapper creation involves a bunch of sketchy code related to finding the Frame
https://bugs.webkit.org/show_bug.cgi?id=96147

Patch by Adam Barth <abarth@chromium.org> on 2012-09-07
Reviewed by Eric Seidel.

Source/WebCore:

Previously, we used the Frame when instantiating DOM wrappers. That's
sketchy because not all DOM wrappers know how to find their Frame, and
the Frame might be displaying a different document now anyway. This
patch now gets all the information directly from the creation context.

In addition, this patch gets the proper creation context in a few more
cases, including Location.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):
(GenerateNormalAttrGetter):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::objMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContext):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

  • bindings/v8/V8PerContextData.cpp:

(WebCore):
(WebCore::V8PerContextData::current):
(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::init):

  • bindings/v8/V8PerContextData.h:

(V8PerContextData):

LayoutTests:

The V8 results for this test now match the JSC results. We can remove
the chromium-specific baseline.

  • platform/chromium/fast/workers/storage/test-authorizer-sync-expected.txt: Removed.
6:36 PM Changeset in webkit [127954] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

Skip some tests that appear to be making bots unstable.

  • platform/chromium/TestExpectations:
6:33 PM Changeset in webkit [127953] by jamesr@google.com
  • 2 edits in trunk/Source/Platform

[chromium] Remove unused WebScrollbarThemePainter::isNull
https://bugs.webkit.org/show_bug.cgi?id=96169

Reviewed by Adrienne Walker.

This doesn't appear to be used anywhere and triggers MSVS C4800 in any chromium file that #includes this header.

  • chromium/public/WebScrollbarThemePainter.h:
6:32 PM Changeset in webkit [127952] by jamesr@google.com
  • 11 edits in trunk/Source

[chromium] Remove transitional WebCompositorSupport fallback code
https://bugs.webkit.org/show_bug.cgi?id=96155

Reviewed by Adrienne Walker.

Source/WebCore:

The implementation of WebCompositorSupport has rolled out everywhere and the static ::create() functions are
going way.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::createScrollbarLayer):

  • platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::createWebAnimation):

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

Source/WebKit/chromium:

  • src/LinkHighlight.cpp:

(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimation):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::readyStateChanged):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

6:30 PM Changeset in webkit [127951] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

6:30 PM Changeset in webkit [127950] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix compilation of TextureMapperShaderManager.cpp with MSVC
https://bugs.webkit.org/show_bug.cgi?id=96121

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

Named variadic parameters in macros appear to be a GCC extension. Fortunately VA_ARGS seems
to work with GCC and MSVC here.

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore):
(WebCore::StandardFilterProgram::StandardFilterProgram):

6:28 PM Changeset in webkit [127949] by vrk@chromium.org
  • 3 edits
    2 adds in trunk

Seek to end after duration change in HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=95986

Reviewed by Eric Carlson.

This seeks the media element to the end of the media resource if the current playback
position has become greater than the duration after a duration change.
http://dev.w3.org/html5/spec/media-elements.html#durationChange

Source/WebCore:

Test: http/tests/media/media-source/seek-to-end-after-duration-change.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerDurationChanged): After firing the duration change event, checks to see if current time exceeds duration and if so, seeks to duration.

LayoutTests:

  • http/tests/media/media-source/seek-to-end-after-duration-change-expected.txt: Added.
  • http/tests/media/media-source/seek-to-end-after-duration-change.html: Added.
6:22 PM Changeset in webkit [127948] by jamesr@google.com
  • 25 edits
    3 copies
    1 add in trunk/Source

[chromium] Implement WebCompositorInputHandlerImpl on top of exposed API instead of CC internals
https://bugs.webkit.org/show_bug.cgi?id=96151

Reviewed by Adrienne Walker.

Source/Platform:

This adds public input handling interfaces for the compositor.

  • chromium/public/WebInputHandler.h:

(WebKit):
(WebInputHandler):
(WebKit::WebInputHandler::~WebInputHandler):

  • chromium/public/WebInputHandlerClient.h:

(WebKit):
(WebInputHandlerClient):
(WebKit::WebInputHandlerClient::~WebInputHandlerClient):

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

  • chromium/public/WebLayerTreeViewClient.h:

(WebKit):
(WebKit::WebLayerTreeViewClient::createInputHandler):
(WebLayerTreeViewClient):

Source/WebCore:

Reworks the CC hookup for input handling to be more similar to the OutputSurface handling. If on compositor
startup we want to initialize threaded input handling, we ask the embedder for a CCInputHandler implementation
via CCLayerTreeHostClient. If the client provides one, we later bind this to a CCInputHandlerClient (actually
CCLayerTreeHostImpl) from the compositor thread.

  • platform/graphics/chromium/cc/CCInputHandler.h:

(WebCore):
(CCInputHandler):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::createInputHandler):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostClient.h:

(WebCore):
(CCLayerTreeHostClient):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore::CCThreadProxy::initializeImplOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Moves input handler setup code up to the WebKit layer instead of reaching in to CC internals.
WebLayerTreeViewImpl implements createInputHandler() by asking its embedder for a WebInputHandler. If one is
provided, it wraps the WebInputHandler in a CCInputHandler implementation to pass down to CC.

WebViewImpl implements WebLayerTreeView::createInputHandler() by constructing a WebCompositorInputHandlerImpl
and storing its identifier for the didActivateCompositor call. From this point on the setup is the same as
before.

WCIHI changes covered by unit tests, overall scrolling behavior manually tested.

  • WebKit.gypi:
  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::fromIdentifier):
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::~WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::setClient):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::bindToClient):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::identifier):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createInputHandler):
(WebKit):

  • src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

  • src/WebToCCInputHandlerAdapter.cpp: Added.

(WebKit):
(WebKit::WebToCCInputHandlerAdapter::create):
(WebKit::WebToCCInputHandlerAdapter::WebToCCInputHandlerAdapter):
(WebKit::WebToCCInputHandlerAdapter::~WebToCCInputHandlerAdapter):
(WebToCCInputHandlerAdapter::ClientAdapter):
(WebKit::WebToCCInputHandlerAdapter::ClientAdapter::ClientAdapter):
(WebKit::WebToCCInputHandlerAdapter::ClientAdapter::~ClientAdapter):
(WebKit::WebToCCInputHandlerAdapter::bindToClient):
(WebKit::WebToCCInputHandlerAdapter::animate):

  • src/WebToCCInputHandlerAdapter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostClient.h.

(WebKit):
(WebToCCInputHandlerAdapter):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
(WebKit::WebViewImpl::createInputHandler):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/CCThreadedTest.cpp:
  • tests/FakeCCLayerTreeHostClient.h:
  • tests/WebCompositorInputHandlerImplTest.cpp:

(MockWebInputHandlerClient):
(WebKit::MockWebInputHandlerClient::MockWebInputHandlerClient):
(WebKit::MockWebInputHandlerClient::~MockWebInputHandlerClient):
(WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
(WebCompositorInputHandlerImplTest):
(WebKit::TEST_F):

6:20 PM Changeset in webkit [127947] by Lucas Forschler
  • 1 copy in tags/Safari-537.9

New Tag.

6:17 PM Changeset in webkit [127946] by abarth@webkit.org
  • 88 edits in trunk/Source/WebCore

[V8] Use a v8::Object rather than a v8::Context to represent the creationContext
https://bugs.webkit.org/show_bug.cgi?id=96154

Patch by Adam Barth <abarth@chromium.org> on 2012-09-07
Reviewed by Eric Seidel.

This patch is a mechanical search-and-replace. Using a v8::Object
rather than a v8::Context lets us delay the call to CreationContext()
until we actually need to call it. This should not affect behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::toV8):
(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):
(WebCore::V8Float64Array::wrap):
(WebCore):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):
(WebCore::V8TestException::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetter):
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::mutablePointAttrGetter):
(WebCore::TestObjV8Internal::immutablePointAttrGetter):
(WebCore::TestObjV8Internal::objMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::mutablePointFunctionCallback):
(WebCore::TestObjV8Internal::immutablePointFunctionCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetter):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):

  • bindings/v8/DOMTransaction.cpp:

(WebCore::DOMTransaction::callFunction):

  • bindings/v8/IDBCustomBindings.cpp:

(WebCore::V8IDBCursorWithValue::valueAccessorGetter):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8Binding.h:

(WebCore::V8ValueTraits::arrayV8Value):

  • bindings/v8/V8Collection.h:

(WebCore::getV8Object):
(WebCore::getNamedPropertyOfCollection):
(WebCore::collectionNamedPropertyGetter):
(WebCore::getIndexedPropertyOfCollection):
(WebCore::collectionIndexedPropertyGetter):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getter):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):

  • bindings/v8/V8ThrowException.cpp:

(WebCore):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):
(WebCore::V8Blob::constructorCallback):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorGetter):
(WebCore::V8CanvasRenderingContext2D::fillStyleAccessorGetter):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::memoryAccessorGetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
(WebCore::toV8):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):
(WebCore::V8Document::getCSSCanvasContextCallback):
(WebCore::toV8):
(WebCore::V8Document::createTouchListCallback):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

  • bindings/v8/custom/V8EntryCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EntrySyncCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
(WebCore::toV8):

  • bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAccessorGetter):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::V8HTMLCollection::namedPropertyGetter):
(WebCore::V8HTMLCollection::namedItemCallback):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::getNamedProperty):
(WebCore::V8HTMLDocument::allAccessorGetter):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8):
(WebCore::V8HTMLElement::itemValueAccessorGetter):

  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAccessorGetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):

  • bindings/v8/custom/V8HTMLOutputElementCustom.cpp:

(WebCore::V8HTMLOutputElement::htmlForAccessorGetter):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertyGetter):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):

  • bindings/v8/custom/V8MicroDataItemValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):

  • bindings/v8/custom/V8PerformanceCustom.cpp:

(WebCore::V8Performance::memoryAccessorGetter):

  • bindings/v8/custom/V8PerformanceEntryCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8StyleSheetListCustom.cpp:

(WebCore::V8StyleSheetList::namedPropertyGetter):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

  • dom/make_names.pl:

(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

6:09 PM Changeset in webkit [127945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Check objects for null when recreating context
https://bugs.webkit.org/show_bug.cgi?id=95926

Patch by John Bauman <jbauman@chromium.org> on 2012-09-07
Reviewed by Dean Jackson.

Upon navigation the FrameViwe and other objects may go null, so detect
that and return rather than try to dereference them.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

5:59 PM Changeset in webkit [127944] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CALLFRAME_OFFSET and EXCEPTION_OFFSET are same in ctiTrampoline on ARM Thumb2
https://bugs.webkit.org/show_bug.cgi?id=82013

Reviewed by Geoff Garen.

Neither of these values need to be stored. At all.

  • jit/JITStubs.cpp:

(JSC):
(JSC::ctiTrampoline):
(JSC::JITThunks::JITThunks):

  • Nothing to see here. Move along.
5:48 PM Changeset in webkit [127943] by Simon Fraser
  • 5 edits
    2 adds in trunk

box-shadow causes overlay scrollbars to be in the wrong position when element is composited
https://bugs.webkit.org/show_bug.cgi?id=85647

Reviewed by James Robinson.

Test overlay scrollbars in composited layers.

  • ManualTests/scrollbars/scrollbars-in-composited-layers.html: Added.

Source/WebCore:

The code that positioned the GraphicsLayers for scrollbars failed to take
into account any offset between the origin of the compositing layer,
and the renderer. This caused scrollbar layers to be misplaced or hidden
on layers with, for example, box-shadows.

Also moved the code that positions the scrollbar layers into RendderLayerBacking,
since this is where all the rest of the GraphicsLayer-positioning code lives.

Renamed an "offsetFromLayer" param to "offsetFromRoot" which is more accurate.

Manual test, since overlay scrollbars are not enabled in DRT/WTR:

ManualTests/scrollbars/scrollbars-in-composited-layers.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::positionOverflowControls):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::positionOverflowControlsLayers):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

5:42 PM Changeset in webkit [127942] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] [WK2] Set theme for the inspector view
https://bugs.webkit.org/show_bug.cgi?id=96108

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

Set the theme for the inspector view when it is created.

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

5:32 PM Changeset in webkit [127941] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r127938.
http://trac.webkit.org/changeset/127938
https://bugs.webkit.org/show_bug.cgi?id=96166

It broke the build (Requested by smfr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/JavaScriptCore:

  • llint/LowLevelInterpreter.cpp:

(JSC):
(JSC::CLoop::execute):

  • offlineasm/cloop.rb:

Source/WTF:

  • wtf/Assertions.h:
5:25 PM Changeset in webkit [127940] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[Chromium] Multiple commits without invalidation allowed per redraw.
https://bugs.webkit.org/show_bug.cgi?id=95661

Patch by David Reveman <reveman@chromium.org> on 2012-09-07
Reviewed by James Robinson.

Source/WebCore:

Always enter COMMIT_STATE_WAITING_FOR_FIRST_DRAW after commit. This
ensures we draw before beginning a new frame.

Unit tests: CCLayerTreeHostTestContinuousCommit.runMultiThread

CCLayerTreeHostTestContinuousInvalidate.runMultiThread
CCLayerTreeHostTestContinuousAnimate.runMultiThread

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::updateState):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTestContinuousCommit):
(WebKitTests::CCLayerTreeHostTestContinuousCommit::CCLayerTreeHostTestContinuousCommit):
(WebKitTests):
(WebKitTests::TEST_F):
(CCLayerTreeHostTestContinuousInvalidate):
(WebKitTests::CCLayerTreeHostTestContinuousInvalidate::CCLayerTreeHostTestContinuousInvalidate):
(CCLayerTreeHostTestContinuousAnimate):
(WebKitTests::CCLayerTreeHostTestContinuousAnimate::CCLayerTreeHostTestContinuousAnimate):

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):

4:59 PM Changeset in webkit [127939] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Refactored bytecode generator initialization to support moving captured vars around
https://bugs.webkit.org/show_bug.cgi?id=96159

Reviewed by Gavin Barraclough.

This patch separates the stages of allocating registers, declaring identifiers
in the symbol table, and initializing registers, so you can change
allocation decisions without breaking the world.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): Call a set of helper functions
instead of inlining all the code, to help clarity.

(JSC::BytecodeGenerator::allocateCapturedVars):
(JSC::BytecodeGenerator::allocateUncapturedVars):
(JSC::BytecodeGenerator::allocateActivationVar):
(JSC::BytecodeGenerator::allocateArgumentsVars):
(JSC::BytecodeGenerator::allocateCalleeVarUndeclared):
(JSC::BytecodeGenerator::declareParameters):
(JSC::BytecodeGenerator::declareCallee):
(JSC::BytecodeGenerator::initCalleeVar):
(JSC::BytecodeGenerator::initArgumentsVars):
(JSC::BytecodeGenerator::initActivationVar):
(JSC::BytecodeGenerator::initThisParameter):
(JSC::BytecodeGenerator::initFunctionDeclarations):
(JSC::BytecodeGenerator::declareParameter):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::createActivationIfNecessary): Factored these
helper functions out from pre-existing code.

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::addVar):

  • parser/Nodes.h:

(JSC::DeclarationStacks::VarDeclaration::VarDeclaration):
(VarDeclaration):
(JSC::DeclarationStacks::FunctionDeclaration::FunctionDeclaration):
(FunctionDeclaration): Declaration stacks get a little more data now,
to support allocating registers before putting things in the symbol
table. I'm convinced that we should eventually just expand the symbol
table to understand these things.

4:58 PM Changeset in webkit [127938] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Source/JavaScriptCore: Fix a llint C++ interpreter bugs.
https://bugs.webkit.org/show_bug.cgi?id=96127.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-07
Reviewed by Filip Pizlo.

  • llint/LowLevelInterpreter.cpp:

(JSC):
(JSC::CLoop::execute):

  • offlineasm/cloop.rb:

Source/WTF: Fixed ASSERT() and ASSERT_AT() macros so that they can be used in
comma expressions.
https://bugs.webkit.org/show_bug.cgi?id=96127.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-07
Reviewed by Filip Pizlo.

  • wtf/Assertions.h:

(wtfAssert):

4:54 PM Changeset in webkit [127937] by tony@chromium.org
  • 8 edits in trunk/Source/WebCore

Add OVERRIDE to computeLogical{Width,Height} overrides
https://bugs.webkit.org/show_bug.cgi?id=96153

Reviewed by Ojan Vafai.

I plan on renaming these functions to updateLogical{Width,Height} and
I want to be extra sure that I don't mess up.

No new tests, this is just a refactoring.

  • rendering/RenderFlowThread.h: Also mark the functions virtual!
  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderMeter.h:

(RenderMeter):

  • rendering/RenderTable.h:

(RenderTable):

  • rendering/RenderTableCell.h:

(RenderTableCell):

  • rendering/RenderTextControl.h:

(RenderTextControl):

  • rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

4:46 PM Changeset in webkit [127936] by dmazzoni@google.com
  • 15 edits
    2 adds in trunk

AX: WebCore accessibility roles should be cross-platform
https://bugs.webkit.org/show_bug.cgi?id=94870

Reviewed by Chris Fleizach.

Source/WebCore:

Make 5 accessibility roles cross-platform rather than GTK-only.

Instead of mapping the HR tag to SplitterRole (which is an interactive
splitter control on Mac), create a new role HorizontalRuleRole.

Map all of the new roles to AXGroup on Mac, which matches the existing
behavior. Add a new test for these roles on Chromium.

Test: platform/chromium/accessibility/chromium-only-roles.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsARIAAttributes):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(createAccessibilityRoleMap):

Source/WebKit/chromium:

Add a new accessibility role.

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:

Tools:

Add debug strings to Chromium for new accessibility roles.

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(roleToString):

LayoutTests:

Adds a test for some new accessibility roles that aren't present on all platforms.

  • platform/chromium/accessibility/chromium-only-roles-expected.txt: Added.
  • platform/chromium/accessibility/chromium-only-roles.html: Added.
4:27 PM Changeset in webkit [127935] by ojan@chromium.org
  • 11 edits
    1 move
    1 delete in trunk/LayoutTests

Rebaselines after http://trac.webkit.org/changeset/127915.

  • fast/css/percent-top-value-with-relative-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/percent-top-value-with-relative-position-expected.txt.
  • platform/chromium-mac-snowleopard/fast/css/percent-top-value-with-relative-position-expected.png:
  • platform/chromium-mac/fast/css/percent-top-value-with-relative-position-expected.png:
  • platform/chromium-win/fast/css/percent-top-value-with-relative-position-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/css/percent-top-value-with-relative-position-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/fast/css/percent-top-value-with-relative-position-expected.txt:
  • platform/qt/TestExpectations:
  • platform/qt/fast/css/percent-top-value-with-relative-position-expected.txt:
4:19 PM Changeset in webkit [127934] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build of GraphicsContext3DOpenGLCommon.cpp with MSVC
https://bugs.webkit.org/show_bug.cgi?id=96120

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-07
Reviewed by Noam Rosenthal.

Variable stack arrays are a GCC extension. Replace their use with OwnArrayPtr, similar to
other functions in the same file.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::getActiveAttrib):

4:16 PM Changeset in webkit [127933] by eae@chromium.org
  • 17 edits
    3 adds in trunk

Prevent overflows in FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=95883

Reviewed by Eric Seidel.

Source/WebCore:

Avoid overflow in snapSizeToPixel by using the fraction of the
location instead of the full value.

Add safe versions of min/max, adjusted by half a pixel to allow
round to allow rounding without overflowing.

Avoid overflow when snapping a FractionalLayoutRect by using the
safe versions of min/max in infiniteRect.

Avoid overflow when converting from a Length to a LayoutUnit by
limiting the value to FractionalLayoutUnit min/max. This matches
the behavior of the non-subpixel code path where the values are
similarly limited.

Test: fast/sub-pixel/large-sizes.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):
Limit to FractionalLayoutUnit min/max.

  • platform/FractionalLayoutUnit.h:

(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::nearlyMax):
(WebCore::FractionalLayoutUnit::nearlyMin):
Reduce max/increase min by 1/2 to allow round to operate
without overflowing.

(WebCore::snapSizeToPixel):

  • platform/graphics/FractionalLayoutRect.h:

(WebCore::FractionalLayoutRect::infiniteRect):
Use nearlyMin/nearlyMax.

(WebCore::pixelSnappedIntRect):
Change pixelSnappedIntRect to use snapSizeToPixel.

LayoutTests:

Add test for handling of large values.

  • fast/sub-pixel/large-sizes-expected.txt: Added.
  • fast/sub-pixel/large-sizes.html: Added.
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/chromium/fast/css/large-number-round-trip-expected.txt: Added.
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
3:58 PM Changeset in webkit [127932] by commit-queue@webkit.org
  • 11 edits
    4 deletes in trunk

Unreviewed, rolling out r127920 and r127926.
http://trac.webkit.org/changeset/127920
http://trac.webkit.org/changeset/127926
https://bugs.webkit.org/show_bug.cgi?id=96152

billions and billions of assertion failures on mac debug
builds (Requested by thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/WebCore:

  • WebCore.exp.in:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::registerCustomFont):
(WebCore):
(WebCore::Document::deleteCustomFonts):
(WebCore::Document::reportMemoryUsage):

  • dom/Document.h:

(WebCore):
(Document):

  • platform/graphics/FontData.h:
  • platform/graphics/FontFallbackList.cpp:

(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::setPlatformFont):

  • platform/graphics/FontFallbackList.h:

(FontFallbackList):
(WebCore::FontFallbackList::setGlyphPageZero):
(WebCore::FontFallbackList::setGlyphPages):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::pruneFontData):

LayoutTests:

  • fast/frames/seamless/seamless-custom-font-pruning-crash-expected.txt: Removed.
  • fast/frames/seamless/seamless-custom-font-pruning-crash.html: Removed.
  • fast/frames/seamless/seamless-nested-crash-expected.txt: Removed.
  • fast/frames/seamless/seamless-nested-crash.html: Removed.
3:55 PM Changeset in webkit [127931] by dmazzoni@google.com
  • 7 edits in trunk

AX: Chromium needs access to canvasHasFallbackContent
https://bugs.webkit.org/show_bug.cgi?id=96124

Reviewed by Chris Fleizach.

Source/WebKit/chromium:

Expose canvasHasFallbackContent on Chromium.

  • public/WebAccessibilityObject.h:

(WebAccessibilityObject):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::canvasHasFallbackContent):
(WebKit):

Tools:

Distinguish between canvas roles with and without fallback
content on Chromium.

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(getRole):

LayoutTests:

Update canvas test to distinguish between canvas elements with
fallback content on Chromium.

  • platform/chromium/accessibility/canvas-description-and-role-expected.txt:
3:50 PM Changeset in webkit [127930] by barraclough@apple.com
  • 4 edits in trunk

Object.prototype.define{G,S}etter with non-callable second parameter should throw TypeError instead of SyntaxError
https://bugs.webkit.org/show_bug.cgi?id=93873

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):

  • throw TypeError instead of SyntaxError

(JSC::objectProtoFuncDefineSetter):

  • throw TypeError instead of SyntaxError

LayoutTests:

  • fast/js/property-getters-and-setters-expected.txt:
    • updated results
3:39 PM Changeset in webkit [127929] by anilsson@rim.com
  • 2 edits in trunk/Source/WebCore

[CSS Shaders] WebKitCSSMixFunctionValue.h needs forward declaration of MemoryObjectInfo
https://bugs.webkit.org/show_bug.cgi?id=96150

Reviewed by George Staikos.

Otherwise files that include it may fail to compile.

No new tests, because this patch implements no new functionality.

  • css/WebKitCSSMixFunctionValue.h:

(WebCore):

3:25 PM Changeset in webkit [127928] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

StringImpl::find(StringImpl*) doesn't handle cases where search and match strings are different bitness
https://bugs.webkit.org/show_bug.cgi?id=96125

Reviewed by Benjamin Poulain.

Changed findInner and reverseFindInner to be templated on both search and match character types.
Changed both find's and reverseFind to use all four bitness combinations of findInner and
reverseFindInner.

  • wtf/text/StringImpl.cpp:

(WTF::findInner):
(WTF::StringImpl::find):
(WTF::reverseFindInner):
(WTF::StringImpl::reverseFind):

3:22 PM Changeset in webkit [127927] by ojan@chromium.org
  • 8 edits in trunk/LayoutTests

Fix the remaining linter errors. These are all cases of paths
that don't actually exist or that are duplicated between TestExpectations
and Skipped files. I left in the Skipped file entries since those
were the ones that win out when duplicated.

  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt/Skipped:
  • platform/qt/TestExpectations:
  • platform/win/Skipped:
  • platform/win/TestExpectations:
3:13 PM Changeset in webkit [127926] by schenney@chromium.org
  • 2 edits in trunk/Source/WebCore

Mac build fix.
https://bugs.webkit.org/show_bug.cgi?id=93640

Reviewed by Abhishek Arya.

The original patch for this bug broke the mac builds.

  • WebCore.exp.in: Adding const marker
3:06 PM Changeset in webkit [127925] by ojan@chromium.org
  • 3 edits in trunk/Tools

Handle non-existant TestExpectations files gracefully
https://bugs.webkit.org/show_bug.cgi?id=96149

Reviewed by Eric Seidel.

Even when we get rid of Skipped files, we shouldn't have each port
require a TestExpectations file for each platform if it doesn't
need one.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.expectations_dict):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_nonexistant_expectations):

2:57 PM Changeset in webkit [127924] by rjkroege@chromium.org
  • 8 edits
    2 moves in trunk/Source

[chromium] Add touchscreen specific fling curve parametrization
https://bugs.webkit.org/show_bug.cgi?id=95997

Reviewed by James Robinson.

Added a new set of fling curve parameters with a good feel for touchscreen
initiated flings. Renamed TouchpadFlingPlatformGestureCurve to
TouchFlingPlatformGestureCurve to better reflect that the class
can serve for both touchscreen and touchpad flings when appropriately
parametrized. Updated build files as necessary for the rename.

No new tests - existing tests apply.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::fireUpAnAnimation):

  • platform/TouchFlingPlatformGestureCurve.cpp: Renamed from Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.cpp.

(WebCore):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchPad):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchScreen):
Added with touchscreen parameters.
(WebCore::TouchFlingPlatformGestureCurve::create):
(WebCore::position):
(WebCore::velocity):
(WebCore::TouchFlingPlatformGestureCurve::TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::~TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::debugName):
(WebCore::TouchFlingPlatformGestureCurve::apply):

  • platform/TouchFlingPlatformGestureCurve.h: Renamed from Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.h.

(WebCore):
(TouchFlingPlatformGestureCurve):

  • platform/chromium/support/PlatformGestureCurveFactory.cpp: invokes

createForTouchPad or createForTouchScreen as appropriate.
(WebKit::PlatformGestureCurveFactory::createCurve):

Source/WebKit/chromium:

  • tests/PlatformGestureCurveTest.cpp: To use the renamed curve constructor.
2:50 PM WebKit Team edited by Elliott Sprehn
David Barr doesn't work for Google anymore (diff)
2:49 PM WebKit Team edited by Elliott Sprehn
Add myself! (diff)
2:45 PM Changeset in webkit [127923] by commit-queue@webkit.org
  • 11 edits in trunk

Enter the creationContext before creating DOM wrappers
https://bugs.webkit.org/show_bug.cgi?id=96044

Patch by Adam Barth <abarth@chromium.org> on 2012-09-07
Reviewed by Eric Seidel.

Source/WebCore:

Now that we have the creationContext available when instantiating DOM
wrappers, we should use it! After this patch, we enter the creation
context so that the DOM wrapper is created in the right context (and
therefore has the right prototype chain).

This patch would have been tested by
fast/dom/prototype-inheritance.html, but that test was removed because
it was too much work to maintain. I'll post what the diff would have
been to the results for that test as an attachment to this bug.

Note: After this patch there are a number of cleanup patches to write,
but I'll do those separately.

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):

  • This patch also includes a minor bug fix to the JSC implementations of Geolocation and Notifications. Previously, JSC was using the current lexical context for the callback object, which makes very little sense as it neither cooresponds to the Geolocation (or Notification) object or the functions being used for the callback.

To be consistent with how we do callbacks elsewhere in WebKit, we
should use the context that corresponds to the Geolocation (or
Notification) object. This change happened automatically for V8
when this patch fixed the Geolocation (and Notifications) wrapper
to use the right context, but for JSC we need to change these lines
of code explicitly.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

LayoutTests:

Update the Geolocation tests to show that we now use the correct
context for these callback. Specifically, we use the context that
cooresponds to the Geolocation object itself, not whatever random
context we happened to be in when we first touched the Geolocation
object.

  • fast/dom/Geolocation/callback-to-deleted-context-expected.txt:
  • fast/dom/Geolocation/disconnected-frame-expected.txt:
  • fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt:
  • fast/dom/Geolocation/resources/callback-to-deleted-context-inner1.html:
  • fast/dom/Geolocation/script-tests/callback-to-deleted-context.js:

(onSecondIframeLoaded):

  • fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js:

(onIframeUnloaded.setTimeout):

  • fast/dom/Geolocation/script-tests/disconnected-frame.js:

(onIframeUnloaded.setTimeout):
(onIframeUnloaded):

2:28 PM Changeset in webkit [127922] by leoyang@rim.com
  • 3 edits
    3 adds in trunk

Appcache fallback URL match should use the longest candidate
https://bugs.webkit.org/show_bug.cgi?id=96126

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/appcache/multi-fallback.html

  • loader/appcache/ApplicationCache.cpp:

(WebCore::fallbackURLLongerThan):
(WebCore::ApplicationCache::setFallbackURLs):

LayoutTests:

Test with multiple candidates of fallback match.

  • http/tests/appcache/multi-fallback-expected.txt: Added.
  • http/tests/appcache/multi-fallback.html: Added.
  • http/tests/appcache/resources/multi-fallback.manifest: Added.
2:19 PM Changeset in webkit [127921] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

2:17 PM Changeset in webkit [127920] by schenney@chromium.org
  • 10 edits
    4 adds in trunk

Font data is purged while fonts are still using it
https://bugs.webkit.org/show_bug.cgi?id=93640

Reviewed by Eric Seidel.

Source/WebCore:

Move the handling of custom font pruning from Document to FontFallbackList.
The previous inplementation allowed fonts to be removed before all their
clients were done. This change moves handling of custom font purging to the
FontFallbackList class, which is the shared object that is only removed
when all clients of a font are done with it. This fixes a crash in Angry
Birds due to a seamless iframe and some failing tests in fast/frames/seamless.

The specific element that causes problems is:
<iframe id="ingame_frame0" name="ingame_frame0" frameborder="0" seamless="true"

src="http://chrome.angrybirds.com/ingame_graphic.html"
onload="this.style.opacity = 1; parent.adLoaded();" scrolling="no"
style="opacity: 1; -webkit-transition: opacity 1s ease-in-out 0s;
position: absolute; border: 0px; width: 312px; height: 320px; z-index:
300; overflow: hidden; visibility: visible;"></iframe>

The source document uses the same font as the embedding document.

Tests: fast/frames/seamless/seamless-custom-font-pruning-crash.html

fast/frames/seamless/seamless-nested-crash.html

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): Remove code to register the
font with the document.

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData): Remove code to register
the font with the document.

  • dom/Document.cpp:

(WebCore::Document::~Document): Remove code that records and purges
custom fonts.
(WebCore):
(WebCore::Document::reportMemoryUsage): Remove reference to removed
object.

  • dom/Document.h:

(Document): Remove method declarations for custom font handling.

  • platform/graphics/FontData.h: Add RefCounted to FontData. Previously, FontData

for custom fonts was owned by a Vector<OwnPtr<FontData>> in Document. Now it
is owned by FontFallbackList, and ref counting is required. A future patch will
add RefPtr code for all FontData use cases.

  • platform/graphics/FontFallbackList.cpp:

(WebCore): Add global custom font data cache, which owns the FontData pointers
used as keys.
(WebCore::FontFallbackList::appendFontData): Helper method increments
the ref count on custom FontData.
(WebCore::FontFallbackList::releaseFontData): Helper method decrements
the ref count on custom FontData.
(WebCore::FontFallbackList::fontDataAt): Add calls to register the
FontFallbackList as a client of custom fonts.

  • platform/graphics/FontFallbackList.h:

(WebCore::FontFallbackList::setGlyphPageZero): Moved this declaration.
(WebCore::FontFallbackList::setGlyphPages): Moved this declaration.
(FontFallbackList):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::pruneFontData): Removed unnecessary null check.

LayoutTests:

Tests for font purging. The seamless-custom-font-pruning-crash test
was only failing in Chromium Asan, while the seamless-nested-crash case
was only failing in Asan DumpRenderTree.

  • fast/frames/seamless/seamless-custom-font-pruning-crash-expected.txt: Added.
  • fast/frames/seamless/seamless-custom-font-pruning-crash.html: Added.
  • fast/frames/seamless/seamless-nested-crash-expected.txt: Added.
  • fast/frames/seamless/seamless-nested-crash.html: Added.
2:16 PM Changeset in webkit [127919] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.14

New Tag.

2:14 PM Changeset in webkit [127918] by jamesr@google.com
  • 10 edits
    3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r127911.
http://trac.webkit.org/changeset/127911
https://bugs.webkit.org/show_bug.cgi?id=96146

Patch breaks build with clang (Requested by rbuis on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::getValidatedProgram):

  • platform/graphics/filters/CustomFilterMesh.cpp:

(WebCore):
(MeshGenerator):
(WebCore::MeshGenerator::MeshGenerator):
(WebCore::MeshGenerator::vertices):
(WebCore::MeshGenerator::indices):
(WebCore::MeshGenerator::points):
(WebCore::MeshGenerator::pointsCount):
(WebCore::MeshGenerator::tiles):
(WebCore::MeshGenerator::tilesCount):
(WebCore::MeshGenerator::indicesCount):
(WebCore::MeshGenerator::floatsPerVertex):
(WebCore::MeshGenerator::verticesCount):
(WebCore::MeshGenerator::addTile):
(WebCore::MeshGenerator::addAttachedMeshIndex):
(WebCore::MeshGenerator::generateAttachedMesh):
(WebCore::MeshGenerator::addDetachedMeshVertexAndIndex):
(WebCore::MeshGenerator::generateDetachedMesh):
(WebCore::MeshGenerator::addPositionAttribute):
(WebCore::MeshGenerator::addTexCoordAttribute):
(WebCore::MeshGenerator::addMeshCoordAttribute):
(WebCore::MeshGenerator::addTriangleCoordAttribute):
(WebCore::MeshGenerator::addAttachedMeshVertexAttributes):
(WebCore::MeshGenerator::addDetachedMeshVertexAttributes):
(WebCore::MeshGenerator::dumpBuffers):
(WebCore::CustomFilterMesh::CustomFilterMesh):

  • platform/graphics/filters/CustomFilterMeshGenerator.cpp: Removed.
  • platform/graphics/filters/CustomFilterMeshGenerator.h: Removed.
  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):
(WebCore::CustomFilterValidatedProgram::compiledProgram):
(WebCore::CustomFilterValidatedProgram::~CustomFilterValidatedProgram):

  • platform/graphics/filters/CustomFilterValidatedProgram.h:

(CustomFilterValidatedProgram):

  • platform/graphics/filters/blackberry/CustomFilterValidatedProgramBlackBerry.cpp: Removed.
2:04 PM Changeset in webkit [127917] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

Fix linter errors. The deleted lines are all tests that are passing
or that no longer exist at that path.

  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
1:58 PM Changeset in webkit [127916] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Remove platform/chromium-linux/compositing/gestures
test skipping. All compositing tests seem to have the same failure.

  • platform/chromium/TestExpectations:
1:54 PM Changeset in webkit [127915] by ojan@chromium.org
  • 10 edits
    4 adds in trunk

Fix RenderBox::availableHeight to subtract scrollbars in the right places
https://bugs.webkit.org/show_bug.cgi?id=96031

Reviewed by Tony Chang.

Source/WebCore:

This matches Firefox 15 and IE9 rendering for the two new tests.

Tests: fast/block/positioning/percent-top-left-on-relative-position.html

fast/css/nested-percent-height-on-replaced.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):
Subtract scrollbars when recurring on percentage heights.
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
This is the wrong place to subtract scrollbars. availableLogicalHeight
should return a value that doesn't include scrollbars.
(WebCore::RenderBox::availableLogicalHeightUsing):
Subtract scrollbars from specified heights. Also, consolidate the code to
use computeContentLogicalHeightUsing. This makes percentage heights use
the right containingBlock in quirks mode and makes viewport percentage heights work.

LayoutTests:

  • fast/block/positioning/percent-top-left-on-relative-position-expected.html: Added.
  • fast/block/positioning/percent-top-left-on-relative-position.html: Added.
  • fast/css/nested-percent-height-on-replaced-expected.txt: Added.
  • fast/css/nested-percent-height-on-replaced.html: Added.
  • platform/chromium-linux/fast/css/percent-top-value-with-relative-position-expected.png:
  • platform/chromium-win/fast/css/percent-top-value-with-relative-position-expected.txt:

This is now correctly centering the 50%. It moved up 8px because that is half of the body's margin.
This matches other Firefox 15 and IE9.

1:50 PM Changeset in webkit [127914] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Make RenderBox::computeLogicalWidthInRegion const
https://bugs.webkit.org/show_bug.cgi?id=96129

Reviewed by Ojan Vafai.

Making computeLogicalWidthInRegion const allows us to get rid of the gross hack in
RenderBox::renderBoxRegionInfo.

No new tests, this is covered by existing layout tests.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax): Make const.
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats): Make const.
(WebCore::RenderBox::computeLogicalWidth): Use a LogicalExtentComputedValues when calling computeLogicalWidthInRegion.
(WebCore::RenderBox::computeLogicalWidthInRegion): Make const. Fill in a LogicalExtentComputedValues struct instead.
(WebCore::RenderBox::computeLogicalWidthInRegionUsing): Make const.
(WebCore::RenderBox::renderBoxRegionInfo): Remove hack and get region width values in a LogicalExtentComputedValues struct.

  • rendering/RenderBox.h:

(RenderBox):

1:47 PM Changeset in webkit [127913] by danakj@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Remove bad assert in CCRenderPass::Id
https://bugs.webkit.org/show_bug.cgi?id=96138

Reviewed by James Robinson.

The assert prevents HashMap from creating "deleted" and "empty" ids. We
assert that RenderPasses have correct ids already, and don't need to
assert inside the Id structure itself.

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore::CCRenderPass::Id::Id):

1:41 PM Changeset in webkit [127912] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, fix incorrect comment character(s) in Skipped list.

  • platform/mac/Skipped:
1:40 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
1:19 PM Changeset in webkit [127911] by anilsson@rim.com
  • 10 edits
    4 adds in trunk/Source/WebCore

[CSS Shaders] [BlackBerry] Refactor CustomFilterMesh and CustomFilter*Program
https://bugs.webkit.org/show_bug.cgi?id=94725

Reviewed by Rob Buis.

Separate the MeshGenerator from the CustomFilterMesh into
CustomFilterMeshGenerator.h/cpp. This allows the BlackBerry port to
reuse the mesh generator in its accelerated compositing implementation.

Also add support for creating a "PlatformCompiledProgram" from a
CustomFilterValidatedProgram, so the BlackBerry port can reuse the
shader validation code in its accelerated compositing implementation.

It turns out the GraphicsContext3D is not needed for ANGLE to function,
so this patch removes an ASSERT that required a context before
validating the shaders using ANGLE. This allows the BlackBerry port to
reuse the validation code without triggering the assert. In the future,
the validation code could be moved to a separate class to make it more
obvious that it isn't really related to GraphicsContext3D.

In general, this refactoring can be useful for any port that uses
OpenGL to implement accelerated compositing.

Inspired by an original patch by Joshua Netterfield.

No new tests, because this patch implements no new functionality.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::getValidatedProgram):

  • platform/graphics/filters/CustomFilterMesh.cpp:

(WebCore::CustomFilterMesh::CustomFilterMesh):

  • platform/graphics/filters/CustomFilterMeshGenerator.cpp: Added.

(WebCore):
(WebCore::CustomFilterMeshGenerator::CustomFilterMeshGenerator):
(WebCore::CustomFilterMeshGenerator::addAttachedMeshIndex):
(WebCore::CustomFilterMeshGenerator::generateAttachedMesh):
(WebCore::CustomFilterMeshGenerator::addDetachedMeshVertexAndIndex):
(WebCore::CustomFilterMeshGenerator::generateDetachedMesh):
(WebCore::CustomFilterMeshGenerator::addPositionAttribute):
(WebCore::CustomFilterMeshGenerator::addTexCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addMeshCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addTriangleCoordAttribute):
(WebCore::CustomFilterMeshGenerator::addAttachedMeshVertexAttributes):
(WebCore::CustomFilterMeshGenerator::addDetachedMeshVertexAttributes):
(WebCore::CustomFilterMeshGenerator::dumpBuffers):

  • platform/graphics/filters/CustomFilterMeshGenerator.h: Added.

(WebCore):
(CustomFilterMeshGenerator):
(WebCore::CustomFilterMeshGenerator::vertices):
(WebCore::CustomFilterMeshGenerator::indices):
(WebCore::CustomFilterMeshGenerator::points):
(WebCore::CustomFilterMeshGenerator::pointsCount):
(WebCore::CustomFilterMeshGenerator::tiles):
(WebCore::CustomFilterMeshGenerator::tilesCount):
(WebCore::CustomFilterMeshGenerator::indicesCount):
(WebCore::CustomFilterMeshGenerator::floatsPerVertex):
(WebCore::CustomFilterMeshGenerator::verticesCount):
(WebCore::CustomFilterMeshGenerator::addTile):

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):
(WebCore::CustomFilterValidatedProgram::compiledProgram):
(WebCore::CustomFilterValidatedProgram::~CustomFilterValidatedProgram):
(WebCore):
(WebCore::CustomFilterValidatedProgram::platformCompiledProgram):
(WebCore::CustomFilterValidatedProgram::platformDestroy):

  • platform/graphics/filters/CustomFilterValidatedProgram.h:

(WebCore):
(CustomFilterValidatedProgram):

  • platform/graphics/filters/blackberry/CustomFilterValidatedProgramBlackBerry.cpp: Added.

(WebCore):
(WebCore::CustomFilterValidatedProgram::platformCompiledProgram):
(WebCore::CustomFilterValidatedProgram::platformDestroy):

1:12 PM Changeset in webkit [127910] by tony@chromium.org
  • 4 edits in trunk/Tools

Regression: check-webkit-style no longer checks TestExpectations for syntax errors
https://bugs.webkit.org/show_bug.cgi?id=96136

Reviewed by Ojan Vafai.

When we renamed the file to TestExpectations, it was no longer considered a text file so
it was no longer being checked. Since then, test_expectations_overrides() has been removed
from the port object, so I've removed that from the check. I'm not sure what it was
supposed to do.

  • Scripts/webkitpy/style/checker.py:

(CheckerDispatcher._file_type): Mark TestExpectations as a text file.

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.check_test_expectations): Remove overrides param.
(TestExpectationsChecker.check): Remove overrides param.

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.assert_lines_lint): Remove overrides param.

1:04 PM Changeset in webkit [127909] by commit-queue@webkit.org
  • 52 edits
    1 add in trunk

[EFL] Use same default minimum logical font size in DRT and WTR
https://bugs.webkit.org/show_bug.cgi?id=96116

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-07
Reviewed by Martin Robinson.

Source/WebKit/efl:

Add DRT helper function to set the minimum logical
font size setting.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setMinimumLogicalFontSize):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit2:

Add private bundle C API to set the minimum logicial font
size setting. This is needed by WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetMinimumLogicalFontSize):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setMinimumLogicalFontSize):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
logical font size to 9 to match the value used in WTR.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting): Explicitly set the minimum
logical font size to 9 (default value in WK2)

LayoutTests:

Provide new baseline for several tests now that the minimum
logical font size setting is set to 9 in EFL's DRT.

Unskip several tests in EFL WK2 now that EFL's DRT uses
the same minimum logical font size and now that the tests
have been rebaselined.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/fast/css/bidi-override-in-anonymous-block-expected.png:
  • platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/efl/fast/ruby/nested-ruby-expected.png:
  • platform/efl/fast/ruby/nested-ruby-expected.txt:
  • platform/efl/fast/ruby/ruby-beforeafter-expected.png:
  • platform/efl/fast/ruby/ruby-beforeafter-expected.txt:
  • platform/efl/fast/ruby/ruby-empty-rt-expected.png:
  • platform/efl/fast/ruby/ruby-empty-rt-expected.txt:
  • platform/efl/fast/ruby/ruby-length-expected.png:
  • platform/efl/fast/ruby/ruby-length-expected.txt:
  • platform/efl/fast/ruby/ruby-run-break-expected.png:
  • platform/efl/fast/ruby/ruby-run-break-expected.txt:
  • platform/efl/fast/ruby/ruby-runs-expected.png:
  • platform/efl/fast/ruby/ruby-runs-expected.txt:
  • platform/efl/fast/ruby/ruby-runs-spans-expected.png:
  • platform/efl/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/efl/fast/ruby/ruby-simple-expected.png:
  • platform/efl/fast/ruby/ruby-simple-expected.txt:
  • platform/efl/fast/ruby/ruby-simple-rp-expected.png:
  • platform/efl/fast/ruby/ruby-simple-rp-expected.txt:
  • platform/efl/fast/ruby/ruby-trailing-expected.png:
  • platform/efl/fast/ruby/ruby-trailing-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/efl/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/efl/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-insert-text2-expected.png:
  • platform/efl/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-insert-text3-expected.png:
  • platform/efl/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-remove-rt1-expected.png:
  • platform/efl/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-remove-rt2-expected.png:
  • platform/efl/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-remove-text1-expected.png:
  • platform/efl/fast/ruby/rubyDOM-remove-text1-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-remove-text2-expected.png:
  • platform/efl/fast/ruby/rubyDOM-remove-text2-expected.txt:
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
12:54 PM Changeset in webkit [127908] by commit-queue@webkit.org
  • 1 edit
    3 moves in trunk/LayoutTests

[chromium] Dynamically removing preserve-3d from a layer has no effect
https://bugs.webkit.org/show_bug.cgi?id=95732

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-07
Reviewed by James Robinson.

Move preserve-3d-toggle.html to the common compositing tests directory because
it isn't Chromium-specific.

  • compositing/preserve-3d-toggle-expected.png: Renamed from LayoutTests/platform/chromium/compositing/preserve-3d-toggle-expected.png.
  • compositing/preserve-3d-toggle-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/preserve-3d-toggle-expected.txt.
  • compositing/preserve-3d-toggle.html: Renamed from LayoutTests/platform/chromium/compositing/preserve-3d-toggle.html.
12:37 PM Changeset in webkit [127907] by danakj@chromium.org
  • 18 edits in trunk/Source

[chromium] Make RenderPass ids hold both generating layer id and an index
https://bugs.webkit.org/show_bug.cgi?id=95500

Reviewed by Adrienne Walker.

Source/WebCore:

This change allows us to avoid complex renderPassId mappings between
compositors for ubercomp. The ubercomp layer needs to add a number
of RenderPasses to the frame, and these must not conflict with other
RenderPasses in the frame. By using its layer id along with an extra
value it determines, the layer can create a unique id without needing
access to any global state or id generator.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):

  • platform/graphics/chromium/cc/CCDirectRenderer.h:

(CCDirectRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore::removeRenderPassesRecursive):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(Id):
(WebCore::CCRenderPass::Id::Id):
(WebCore::CCRenderPass::Id::operator==):
(WebCore::CCRenderPass::Id::operator!=):
(WebCore::CCRenderPass::Id::operator<):
(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::renderPassId):
(WebCore):
(WebCore::CCRenderSurface::appendRenderPasses):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderer.h:

(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCRenderSurfaceTest.cpp:
  • tests/CCRendererGLTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):

12:30 PM Changeset in webkit [127906] by tommyw@google.com
  • 20 edits
    2 adds in trunk

MediaStream API: add RTCPeerConnection::createAnswer
https://bugs.webkit.org/show_bug.cgi?id=96092

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebRTCPeerConnectionHandler):

Source/WebCore:

Test: fast/mediastream/RTCPeerConnection-createAnswer.html

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createAnswer):
(WebCore):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::createAnswer):
(WebCore):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(RTCPeerConnectionHandler):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::createAnswer):
(WebCore):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

Expanding and enhancing MockWebRTCPeerConnectionHandler.

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::createOffer):
(MockWebRTCPeerConnectionHandler::createAnswer):
(MockWebRTCPeerConnectionHandler::setLocalDescription):
(MockWebRTCPeerConnectionHandler::setRemoteDescription):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-createAnswer-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-createAnswer.html: Added.
  • fast/mediastream/RTCPeerConnection-createOffer-expected.txt:
  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-localDescription-expected.txt:
  • fast/mediastream/RTCPeerConnection-localDescription.html:
  • fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt:
  • fast/mediastream/RTCPeerConnection-remoteDescription.html:
12:20 PM Changeset in webkit [127905] by wangxianzhu@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test expectation media/video-set-rate-from-pause.html on Android.

  • platform/chromium/TestExpectations:
12:15 PM Changeset in webkit [127904] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

[WK2][WTR] Unskip detached-stylesheet-without-wrapper.html test case.
https://bugs.webkit.org/show_bug.cgi?id=96069

Unreviewed EFL gardening.

fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html test case has been passed on EFL layout test.
WebKit EFL doesn't have to skip this.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-07

  • platform/gtk-wk2/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/win-wk2/Skipped:
  • platform/wk2/Skipped:
12:04 PM Changeset in webkit [127903] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB: public WebKit API changes for consolidating two-phase connect
https://bugs.webkit.org/show_bug.cgi?id=96122

Reviewed by Adam Barth.

Prep work for landing Chromium side of http://webkit.org/b/90411 - the IDBFactory
open() method now takes the "database callbacks", rather than being sent through
in a later call.

Also, delete an obsolete method.

  • public/WebIDBFactory.h:

(WebKit):
(WebIDBFactory): Delete pre-version overload of open().
(WebKit::WebIDBFactory::open): Add overload that takes WebIDBDatabaseCallbacks.

11:51 AM Changeset in webkit [127902] by vsevik@chromium.org
  • 4 edits
    3 adds in trunk

Web Inspector: [REGRESSION] Content is not available for dynamically loaded script sometimes.
https://bugs.webkit.org/show_bug.cgi?id=95954

Reviewed by Yury Semikhatsky.

Source/WebCore:

Resource now loads content from request when it is available.
Content was loaded from PageAgent before where it might be not available if the resource was already GCed.

Test: http/tests/inspector/resource-tree/resource-request-content-after-loading-and-clearing-cache.html

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype._innerRequestContent.contentLoaded):
(WebInspector.Resource.prototype._innerRequestContent.resourceContentLoaded):
(WebInspector.Resource.prototype._innerRequestContent):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-request-content-after-loading-and-clearing-cache-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-request-content-after-loading-and-clearing-cache.html: Added.
  • http/tests/inspector/resource-tree/resources/dynamic-script.js: Added.

(foo):

  • http/tests/inspector/resources-test.js:
11:44 AM Changeset in webkit [127901] by dino@apple.com
  • 2 edits in trunk/Tools

Unreviewed changes to watchlist.

  • Add new WebGL and Filters definitions
  • Add myself to OpenGL bugs
  • Scripts/webkitpy/common/config/watchlist:
11:39 AM Changeset in webkit [127900] by dmazzoni@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skip accessibility/spinbutton-value.html on win.

11:32 AM Changeset in webkit [127899] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLTokenizer should use the latest EfficientStrings hotness
https://bugs.webkit.org/show_bug.cgi?id=95276

Reviewed by Benjamin Poulain.

Using ASCIILiteral avoids memcpying the string into the heap and
therefore uses less total memory.

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):

11:31 AM Changeset in webkit [127898] by fsamuel@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed rebaseline.

Colors changed slightly, but the test's intention is to verify scaling
works as expected and it continues to do so.

  • platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
11:27 AM Changeset in webkit [127897] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Chromium Linux EWS bots and CQ bots are flaky
https://bugs.webkit.org/show_bug.cgi?id=96041

Unreviewed, trying to get the cr-linux ews into a usable state.

  • platform/chromium/TestExpectations: Revert r127883 and skip http/tests/cache/cancel-during-revalidation-succeeded.html

on the cr-ews linux bots. This is causing the following 2 tests to fail.

11:26 AM Changeset in webkit [127896] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] GraphicsLayerChromiumTest::applyScrollToScrollableArea() is failing
https://bugs.webkit.org/show_bug.cgi?id=95932

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-07
Reviewed by James Robinson.

Give the FakeScrollableArea valid geometry to allow ScrollAnimatorMac to
properly scroll it.

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F): Re-enable the test.

11:17 AM Changeset in webkit [127895] by peter@chromium.org
  • 2 edits in trunk/Tools

Actually trigger the Android Tester
https://bugs.webkit.org/show_bug.cgi?id=96118

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
11:11 AM Changeset in webkit [127894] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Initialize caret rectangle with invalid location
https://bugs.webkit.org/show_bug.cgi?id=96011

Patch by Yongxin Dai <yodai@rim.com> on 2012-09-07
Reviewed by Rob Buis.

In SelectionHandler::selectionPositionChanged() method, startCaret and
endCaret are used to notify clients about new caret positions. This patch
initializes startCaret and endCaret with location(-1. -1), and keeps them
empty before they are assigned to valid values. This would help for other
classes to check validity of the caret correctly.

Internal reviewed by Mike Fenton.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

11:09 AM Changeset in webkit [127893] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Move some CC unit tests into correct gyp variable
https://bugs.webkit.org/show_bug.cgi?id=96048

Patch by James Robinson <jamesr@chromium.org> on 2012-09-07
Reviewed by Adrienne Walker.

These tests are testing compositor internals, so they belong in the webkit_compositor_unittest_files variable.

  • WebKit.gypi:
11:08 AM Changeset in webkit [127892] by fsamuel@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed rebaseline for chromium gardening.

  • platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
10:57 AM Changeset in webkit [127891] by jamesr@google.com
  • 10 edits
    3 deletes in trunk/Source

[chromium] Remove dead CCActiveGestureAnimation code and related classes
https://bugs.webkit.org/show_bug.cgi?id=96075

Reviewed by Adrienne Walker.

Source/WebCore:

The CCGestureCurve / CCActiveGestureAnimation code isn't used and never has been used. Gesture curves are
evaluated by the CCInputHandlerClient (WebCompositorInputHandlerImpl), CC itself logically doesn't know anything
about gestures.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp: Removed.
  • platform/graphics/chromium/cc/CCActiveGestureAnimation.h: Removed.
  • platform/graphics/chromium/cc/CCGestureCurve.h: Removed.
  • platform/graphics/chromium/cc/CCInputHandler.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animate):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

Source/WebKit/chromium:

Cuts out unnecessary boilerplate in PlatformGestureCurve evaluation for handling flings. WCIHI can easily
evaluate the curve itself without intermediate classes.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):

  • src/WebCompositorInputHandlerImpl.h:

(WebCore):
(WebCompositorInputHandlerImpl):

  • tests/PlatformGestureCurveTest.cpp:
  • tests/WebCompositorInputHandlerImplTest.cpp:
10:57 AM Changeset in webkit [127890] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/security/contentSecurityPolicy/blob-urls-match-self.html fails on Windows port.
https://bugs.webkit.org/show_bug.cgi?id=96133

Test fails on Windows port since added in http://trac.webkit.org/changeset/126785.
Blobs might be completely disabled on Windows. Adding to skip list for now.

  • platform/win/Skipped:
10:52 AM Changeset in webkit [127889] by mrobinson@webkit.org
  • 6 edits
    2 adds in trunk

[GTK] Move user agent helpers to WebCore
https://bugs.webkit.org/show_bug.cgi?id=95745

Reviewed by Carlos Garcia Campos.

.:

Added an autoconf step for the new user agent shared code header in
WebCore. This is necessary so that we can use the user agent version
based on the information in the configure.ac file.

  • configure.ac:

Source/WebCore:

Moved the user agent determination code from WebKit1 to WebCore so that it can
be shared with WebKit2. Also add a method for creating the user agent given
a non-default application name.

  • GNUmakefile.list.am: Add new files to the list.
  • platform/gtk/UserAgentGtk.cpp: Added.
  • platform/gtk/UserAgentGtk.h.in: Added.

Source/WebKit/gtk:

Move the code for determining the user agent to WebCore and have WebKit1
use the new shared code.

  • webkit/webkitwebsettings.cpp: Use the WebCore code to determine the user

agent in WebKit1.

10:49 AM Changeset in webkit [127888] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Clean up dependencies in ScrollbarLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=96052

Patch by James Robinson <jamesr@chromium.org> on 2012-09-07
Reviewed by Adrienne Walker.

Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest:
*) WebScrollbarImpl.h is #included, but not use
*) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if

WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test.

  • tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::TEST):

10:46 AM Changeset in webkit [127887] by msaboff@apple.com
  • 4 edits in trunk/Source/WTF

equalIgnoringCase of two StringImpls doesn't handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=96028

Reviewed by Benjamin Poulain.

Added 8 bit checks and paths to CaseFoldingHash::equal. Also cleaned up StringHash::equal(), removing
obvious and in one case wrong comments. Moved equalIgnoringCase(UChar*, UChar*) from StringImpl.cpp
to StringImpl.h.

  • wtf/text/StringHash.h:

(WTF::StringHash::equal):
(WTF::CaseFoldingHash::equal):

  • wtf/text/StringImpl.cpp:
  • wtf/text/StringImpl.h:

(WTF::equalIgnoringCase):

10:25 AM Changeset in webkit [127886] by abarth@webkit.org
  • 26 edits in trunk/Source/WebCore

Update bindings results after https://bugs.webkit.org/show_bug.cgi?id=96039

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):
(WebCore::toV8):
(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):
(WebCore::V8Float64Array::wrap):
(WebCore):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):
(WebCore::V8TestException::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetter):
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::mutablePointAttrGetter):
(WebCore::TestObjV8Internal::immutablePointAttrGetter):
(WebCore::TestObjV8Internal::objMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::mutablePointFunctionCallback):
(WebCore::TestObjV8Internal::immutablePointFunctionCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetter):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):

10:22 AM Changeset in webkit [127885] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, fix overlapping test expectation.

  • platform/chromium/TestExpectations:
10:13 AM Changeset in webkit [127884] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source

[BlackBerry] when one of multiple tabs uses authentication, user can get the auth dialog while the other tab has focus.
https://bugs.webkit.org/show_bug.cgi?id=95488
PR: 186597.

Internally reviewed by Joe Mason.
Patch by Lianghui Chen <liachen@rim.com> on 2012-09-07
Reviewed by Yong Li.

Source/WebCore:

The fix for this PR will come as 2 patches. This is the first patch which
will make the authentication challenge asynchronous inside WebKit. The
bext patch will add an AuthenticationChallengeManager that manages these
authentication requests asynchronously.

This patch add AuthenticationChallengeClient interface to define asynchronous
authentication challenge callback. And MediaPlayerPrivateBlackBerry and
NetworkJob are changed to inherit from AuthenticationChallengeClient to
support asynchronous authentication challenge.

Note: there is also an accompanying platform patch to make our PlatformPlayer
to support asychronous authentication, see PR 186597 for details.

No new tests as this is platform specific change.

  • platform/blackberry/AuthenticationChallengeManager.h: Added.

(WebCore):
(AuthenticationChallengeClient):

  • platform/blackberry/PageClientBlackBerry.h:

(WebCore):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):
(WebCore):

  • platform/network/blackberry/NetworkJob.h:

(WebCore):
(NetworkJob):

Source/WebKit/blackberry:

Use new AuthenticationChallengeClient interface to make authentication
challenge asynchronous to NetworkJob, MediaPlayerPrivateBlackBerry, and
other module that will use HTTP authentication. WebPage itself still use
synchronous authentication though. Switching to asynchronous authentication
in WebPage will require bigger platform layer change and not very necessary
at the moment for this bug.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):

  • Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):

10:09 AM Changeset in webkit [127883] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Chromium Linux EWS bots and CQ bots are flaky
https://bugs.webkit.org/show_bug.cgi?id=96041

Unreviewed, trying to get the cr-linux ews into a usable state.

  • platform/chromium/TestExpectations: mark 2 http cache tests as flaky
10:07 AM Changeset in webkit [127882] by dmazzoni@google.com
  • 13 edits
    2 adds in trunk

Source/WebCore: AX: ARIA spin button should support range value attributes
https://bugs.webkit.org/show_bug.cgi?id=96076

Reviewed by Chris Fleizach.

Make an ARIA spin button support ARIA range attributes like
aria-valuenow, aria-valuemin, etc. - just like slider, progressbar,
and scrollbar.

Test: accessibility/spinbutton-value.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isSpinButton):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::valueDescription):
(WebCore):
(WebCore::AccessibilityRenderObject::isAriaRange):
(WebCore::AccessibilityRenderObject::valueForRange):
(WebCore::AccessibilityRenderObject::maxValueForRange):
(WebCore::AccessibilityRenderObject::minValueForRange):
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::isGenericFocusableElement):
(WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Source/WebKit/chromium: AX: ARIA spin button should support range value attributes
https://bugs.webkit.org/show_bug.cgi?id=96076

Reviewed by Chris Fleizach.

Expose supportsRangeValue to simplify Chromium logic for when to
extract a value from a range.

  • public/WebAccessibilityObject.h:

(WebAccessibilityObject):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::supportsRangeValue):
(WebKit):

Tools: New time input needs accessibility
https://bugs.webkit.org/show_bug.cgi?id=96032

Reviewed by Chris Fleizach.

Add support for valueDescription for testing.

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(getValueDescription):
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::valueDescriptionGetterCallback):

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:

(AccessibilityUIElement):

LayoutTests: AX: ARIA spin button should support range value attributes
https://bugs.webkit.org/show_bug.cgi?id=96076

Reviewed by Chris Fleizach.

Test that an ARIA spin button exposes ARIA range attributes like
aria-valuenow, aria-valuemin, etc.

  • accessibility/spinbutton-value-expected.txt: Added.
  • accessibility/spinbutton-value.html: Added.
10:02 AM Changeset in webkit [127881] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove feature about:cache/disable and about:cache/enable
https://bugs.webkit.org/show_bug.cgi?id=95820

Reviewed by Yong Li.

Fix warning that was caused by r127680.

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::cachePage):

9:58 AM Changeset in webkit [127880] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r127820.
http://trac.webkit.org/changeset/127820
https://bugs.webkit.org/show_bug.cgi?id=96117

Introduces crashes in Chromium compositing tests (Requested by
fsamuel on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::evictAllContentTextures):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::allBackingTexturesWereDeleted):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:

(CCPrioritizedTextureManager):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

9:55 AM Changeset in webkit [127879] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

[WIN] Deprecate String += operator
https://bugs.webkit.org/show_bug.cgi?id=96083

Reviewed by Adam Barth.

  • wtf/Platform.h:
9:31 AM Changeset in webkit [127878] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Unskip test cases that are now passing consistently
https://bugs.webkit.org/show_bug.cgi?id=96090

Unreviewed EFL gardening.

Remove from TestExpectations several test cases that are now
passing consistently on EFL WK2 build bot.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-07

  • platform/efl-wk2/TestExpectations:
9:27 AM Changeset in webkit [127877] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Add another all-in-one source

Rubber-stamped by Tor Arne Vestbø.

  • Target.pri: We can safely add platform/text/TextAllInOne.cpp to ALL_IN_ONE_SOURCES for

even smaller combined builds.

9:09 AM Changeset in webkit [127876] by allan.jensen@nokia.com
  • 46 edits in trunk

Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720

Reviewed by Antonio Gomes.

.:

Update exported symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

The existing API was overloaded and could be simplified by passing all the bool arguments in
a HitTestRequest argument. This should also help clarify the call as the enum values explicitely
state what they do.

  • WebCore.exp.in:
  • WebCore.order:
  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • dom/Document.h:

(Document):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::createContextMenu):

  • page/DragController.cpp:

(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateAutoscrollRenderer):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::handleTouchEvent):

  • page/EventHandler.h:

(EventHandler):

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):

  • page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):

  • page/TouchDisambiguation.cpp:

(WebCore::findGoodTouchTargets):

  • rendering/HitTestRequest.h:

(HitTestRequest):

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

Source/WebKit/blackberry:

Update calls to new API.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::nodeAtPoint):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect):
(BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Source/WebKit/chromium:

Update calls to new API.

  • src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspelledWord):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::characterIndexForPoint):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::isRectTopmost):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseUp):
(WebKit::WebViewImpl::computeBlockBounds):

Source/WebKit/efl:

Update calls to new API.

  • ewk/ewk_frame.cpp:

(ewk_frame_hit_test_new):

Source/WebKit/mac:

Update calls to new API.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::actionDictionary):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView elementAtPoint:allowShadowContent:]):

Source/WebKit/qt:

Update calls to new API.

  • Api/qwebframe.cpp:

(QWebFrame::hitTestContent):

  • Api/qwebpage.cpp:

(QWebPagePrivate::handleSoftwareInputPanel):
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
(QWebPage::updatePositionDependentActions):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

Source/WebKit/win:

Update calls to new API.

  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::Read):

  • WebView.cpp:

(WebView::handleContextMenuEvent):
(WebView::elementAtPoint):

Source/WebKit/wx:

Update calls to new API.

  • WebFrame.cpp:

(WebKit::WebFrame::HitTest):

Source/WebKit2:

Update calls to new API and update exported symbols.

  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:

(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleContextMenuEvent):
(WebKit::WebPage::highlightPotentialActivation): Corrects the misplaced arguments while converting them.
(WebKit::WebPage::findZoomableAreaForPoint):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::characterIndexForPoint):
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
9:06 AM Changeset in webkit [127875] by peter@chromium.org
  • 2 edits in trunk/Tools

Add the google-android-tests build slave to the master's config
https://bugs.webkit.org/show_bug.cgi?id=96113

Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
9:05 AM Changeset in webkit [127874] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

Build of OpenGLShims.cpp against EGL/GLES2 platforms is broken
https://bugs.webkit.org/show_bug.cgi?id=95556

Reviewed by Jocelyn Turcotte.

There were a few problems:

1) GL_ANGLE_framebuffer_blit is the name of the macro indicating the
availability of the _declaration_ of that ANGLE extension. It is not the
name of the actual function, which is glBlitFramebufferANGLE.

2) The presence of the preprocessor macros indicating the availability
of the declaration of the extension does not imply presence of the extension
prototypes at link time. Instead extensions need to be looked up dynamically
at run-time.

3) dlfcn.h was unconditionally included. We do not need it when building against
Qt (and there it breaks the Windows build)

This patch implements the dynamic lookup of glBlitFramebufferANGLE
(used in GraphicsContext3DOpenGLES.cpp) as well as the dynamic lookup of the
Angle and Apple renderbuffer multisampling extensions.

  • platform/graphics/OpenGLShims.cpp:

(WebCore):
(WebCore::initializeOpenGLShims):

9:03 AM Changeset in webkit [127873] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[WK2] [EFL] Set theme for WebKit2 API test runner
https://bugs.webkit.org/show_bug.cgi?id=96100

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

Set the theme generated by the build for the WebKit2 API test runner.

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):

9:01 AM Changeset in webkit [127872] by zandobersek@gmail.com
  • 4 edits in trunk

[GTK] Multiple feature defines in webcore_cppflags can occur
https://bugs.webkit.org/show_bug.cgi?id=95942

Reviewed by Martin Robinson.

.:

Add the feature_defines_unstable variable that should control values of feature
defines for unstable features when unstable features are not enabled (e.g. release builds).

  • GNUmakefile.am:

Source/WebCore:

Any feature define that guards a feature deemed currently unstable (is intended
to be enabled in developer builds but not in release builds) should be added to the
newly-added feature_defines_unstable variable.

This moves away from adding such feature defines to the feature_defines_overrides variable
as this can cause duplicates in the later-generated feature_defines and webcore_cppflags
variables and further warnings of duplicate macros when generating bindings.

The feature_defines generation is now done by first checking if the bare feature define
is present in feature_defines_unstable, if not then feature_defines_overrides is also
checked before using the value from feature_defines_defaults.

No new tests - no new functionality.

  • GNUmakefile.am:
9:01 AM Changeset in webkit [127871] by fsamuel@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Disabled test paste-global-selection on Chromium Linux that was failing.

  • platform/chromium/TestExpectations:
8:53 AM Changeset in webkit [127870] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Rendering issue after rotation
https://bugs.webkit.org/show_bug.cgi?id=96094
PR #201930

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-09-07
Reviewed by George Staikos.

The cause of the rendering issue is that the BackingStore tiles
are not reset after layout. This is a regression of r125680, which
overwrites a local variable that are used later in the function.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

8:36 AM Changeset in webkit [127869] by loislo@chromium.org
  • 102 edits
    1 move
    1 add in trunk/Source

Web Inspector: NMI: move WebCore specific code to separate header
https://bugs.webkit.org/show_bug.cgi?id=96101

Reviewed by Yury Semikhatsky.

I extracted WebCore related code from MemoryInstrumentation.h to WebCoreMemoryInstrumentation.h

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptWrappable.h:
  • bindings/v8/DOMDataStore.cpp:
  • bindings/v8/IntrusiveDOMWrapperMap.h:
  • bindings/v8/ScriptProfiler.cpp:
  • bindings/v8/ScriptWrappable.h:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMMap.h:
  • css/CSSAspectRatioValue.cpp:
  • css/CSSBorderImageSliceValue.cpp:
  • css/CSSCalculationValue.cpp:
  • css/CSSCanvasValue.cpp:
  • css/CSSCharsetRule.cpp:
  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSCrossfadeValue.cpp:
  • css/CSSCursorImageValue.cpp:
  • css/CSSFontFaceRule.cpp:
  • css/CSSFontFaceSrcValue.cpp:
  • css/CSSFunctionValue.cpp:
  • css/CSSGradientValue.cpp:
  • css/CSSImageGeneratorValue.cpp:
  • css/CSSImageSetValue.cpp:
  • css/CSSImageValue.cpp:
  • css/CSSImportRule.cpp:
  • css/CSSInheritedValue.cpp:
  • css/CSSInitialValue.cpp:
  • css/CSSLineBoxContainValue.cpp:
  • css/CSSMediaRule.cpp:
  • css/CSSPrimitiveValue.cpp:
  • css/CSSProperty.cpp:
  • css/CSSReflectValue.cpp:
  • css/CSSRuleList.h:
  • css/CSSSelectorList.cpp:
  • css/CSSStyleRule.cpp:
  • css/CSSStyleSheet.cpp:
  • css/CSSTimingFunctionValue.cpp:
  • css/CSSUnicodeRangeValue.cpp:
  • css/CSSUnknownRule.h:
  • css/CSSValue.cpp:
  • css/CSSValueList.cpp:
  • css/CSSVariableValue.h:
  • css/FontFeatureValue.cpp:
  • css/FontValue.cpp:
  • css/MediaList.cpp:
  • css/MediaQuery.cpp:
  • css/MediaQueryExp.cpp:
  • css/PropertySetCSSStyleDeclaration.cpp:
  • css/ShadowValue.cpp:
  • css/StyleResolver.cpp:
  • css/StyleRule.cpp:
  • css/StyleSheetContents.cpp:
  • css/WebKitCSSArrayFunctionValue.cpp:
  • css/WebKitCSSFilterValue.cpp:
  • css/WebKitCSSKeyframeRule.cpp:
  • css/WebKitCSSKeyframesRule.cpp:
  • css/WebKitCSSMixFunctionValue.cpp:
  • css/WebKitCSSSVGDocumentValue.cpp:
  • css/WebKitCSSShaderValue.cpp:
  • css/WebKitCSSTransformValue.cpp:
  • dom/CharacterData.cpp:
  • dom/Document.cpp:
  • dom/DocumentEventQueue.cpp:
  • dom/ElementAttributeData.cpp:
  • dom/Event.cpp:
  • dom/MemoryInstrumentation.h:
  • dom/Node.cpp:
  • dom/QualifiedName.h:
  • dom/WebCoreMemoryInstrumentation.cpp: Renamed from Source/WebCore/dom/MemoryInstrumentation.cpp.

(WebCore):
(WebCore::String):
(WebCore::StringImpl):
(WebCore::KURL):
(WebCore::AtomicString):

  • dom/WebCoreMemoryInstrumentation.h: Added.

(WebCore):
(WebCoreMemoryTypes):

  • loader/DocumentLoader.cpp:
  • loader/FrameLoader.cpp:
  • loader/SubresourceLoader.cpp:
  • loader/SubstituteData.cpp:
  • loader/cache/CachedCSSStyleSheet.cpp:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceHandle.cpp:
  • loader/cache/CachedScript.cpp:
  • loader/cache/CachedShader.cpp:
  • loader/cache/CachedXSLStyleSheet.cpp:
  • loader/cache/MemoryCache.cpp:
  • platform/SharedBuffer.cpp:
  • platform/graphics/BitmapImage.cpp:
  • platform/graphics/CrossfadeGeneratedImage.cpp:
  • platform/graphics/GeneratedImage.cpp:
  • platform/graphics/GeneratorGeneratedImage.h:
  • platform/graphics/Image.cpp:
  • platform/network/FormData.cpp:
  • platform/network/ResourceRequestBase.cpp:
  • platform/network/ResourceResponseBase.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/StyleRareInheritedData.cpp:
  • rendering/style/StyleRareNonInheritedData.cpp:
  • svg/SVGColor.cpp:
  • svg/SVGPaint.cpp:

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:
8:32 AM Changeset in webkit [127868] by vollick@chromium.org
  • 9 edits in trunk/Source

[chromium] We should accelerate all transformations, except when we must blend matrices that cannot be decomposed.
https://bugs.webkit.org/show_bug.cgi?id=95855

Reviewed by James Robinson.

Source/Platform:

WebTransformOperations are now able to report if they can successfully blend.
WebTransformationMatrix::blend now returns a bool if blending would fail.

  • chromium/public/WebTransformOperations.h:

(WebTransformOperations):

  • chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

Source/WebCore:

WebTransformOperations are now able to report if they can successfully blend.
WebTransformationMatrix::blend now returns a bool if blending would fail.

Unit tests:

AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform

  • platform/chromium/support/WebTransformOperations.cpp:

(WebKit::blendTransformOperations):
(WebKit::WebTransformOperations::blend):
(WebKit::WebTransformOperations::canBlendWith):
(WebKit):
(WebKit::WebTransformOperations::blendInternal):

  • platform/chromium/support/WebTransformationMatrix.cpp:

(WebKit::WebTransformationMatrix::blend):

  • platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::WebTransformAnimationCurve):

Source/WebKit/chromium:

Added the following unit tests:

AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform

  • tests/AnimationTranslationUtilTest.cpp:

(WebKit::TEST):
(WebKit):

7:06 AM WebInspector edited by lindahomes9@gmail.com
(diff)
7:00 AM Changeset in webkit [127867] by apavlov@chromium.org
  • 12 edits in trunk

Unreviewed, rolling out r127780 and r127859.
http://trac.webkit.org/changeset/127780
http://trac.webkit.org/changeset/127859
https://bugs.webkit.org/show_bug.cgi?id=96102

"inspector/styles/protocol-css-regions-commands.html crashing
on Chromium Linux Debug and timing out flakily on Release"
(Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/WebCore:

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
6:50 AM Changeset in webkit [127866] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Add passing expectations for a few specific sub-pixel and various input type
tests. These features are not yet supported by the GTK port but we're willing
to watch and monitor these tests' behavior.

  • platform/gtk/TestExpectations:
6:37 AM Changeset in webkit [127865] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[chromium] Dynamically removing preserve-3d from a layer has no effect
https://bugs.webkit.org/show_bug.cgi?id=95732

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-07
Reviewed by James Robinson.

Source/WebCore:

Fix removal of preserve-3d CSS attribute from a GraphicsLayerChromium.
It was broken by a refactor in http://trac.webkit.org/changeset/126378.

Test: platform/chromium/compositing/preserve-3d-toggle.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

LayoutTests:

Add test to verify dynamic removal of preserve-3d CSS attribute.

  • platform/chromium/compositing/preserve-3d-toggle-expected.png: Added.
  • platform/chromium/compositing/preserve-3d-toggle-expected.txt: Added.
  • platform/chromium/compositing/preserve-3d-toggle.html: Added.
6:24 AM Changeset in webkit [127864] by apavlov@chromium.org
  • 11 edits in trunk

Web Inspector: Implement SCSS source highlighter
https://bugs.webkit.org/show_bug.cgi?id=95585

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change modifies the existing CSS highlighter to support SCSS as well. The "text/x-scss" mime-type is assigned to SASSSource.

  • inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions.cssPropertiesMetainfoKeySet):

  • inspector/front-end/ContentProviders.js:

(WebInspector.StaticContentProvider): Enabled clients to supply the content mime-type.
(WebInspector.StaticContentProvider.prototype.mimeType):
(WebInspector.StaticContentProvider.prototype.requestContent): Use client-supplied content mime-type, if any.

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSource): Construct StaticContentProvider with the "text/x-scss" mime-type.

  • inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer):
(WebInspector.SourceCSSTokenizer.prototype.nextToken):

  • inspector/front-end/SourceCSSTokenizer.re2js: Extended with the SCSS syntax.
  • inspector/front-end/SourceTokenizer.js:

(WebInspector.SourceTokenizer.Registry):

  • inspector/front-end/inspectorSyntaxHighlight.css:

(.webkit-css-bang-keyword):

LayoutTests:

Test modified to cover the SCSS syntax as well.

  • inspector/syntax-highlight-css-expected.txt:
  • inspector/syntax-highlight-css.html:
5:59 AM Changeset in webkit [127863] by allan.jensen@nokia.com
  • 4 edits in trunk/LayoutTests

Layout Test touchadjustment/iframe-boundary.html is failing
https://bugs.webkit.org/show_bug.cgi?id=95799

Unreviewed, fudge the test so it has a larger margin of error.

  • platform/chromium/TestExpectations:
  • touchadjustment/iframe-boundary.html:
  • touchadjustment/resources/inner-content-page.html:
5:51 AM Changeset in webkit [127862] by allan.jensen@nokia.com
  • 27 edits
    2 adds in trunk

X11 Global Selection
https://bugs.webkit.org/show_bug.cgi?id=88238

Reviewed by Tony Chang.

Source/WebCore:

In X11 global selection is the ability to share the active selection
between applications and pasting with middle mouse-button.

This patch moves the implementations of global selection from the
separate implementations in Qt WebKit, Chromium and GTK to WebCore,
by implementing a new EditorCommand for pasting the global selection.

Test: editing/pasteboard/paste-global-selection.html

  • editing/EditorCommand.cpp:

(WebCore::executePasteGlobalSelection):
(WebCore::createCommandMap):

  • page/EditorClient.h:

(EditorClient):
(WebCore::EditorClient::supportsGlobalSelection):

  • platform/Pasteboard.h:

(WebCore::Pasteboard::isSelectionMode):
(WebCore::Pasteboard::setSelectionMode):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::isSelectionMode):
(WebCore::Pasteboard::setSelectionMode):

Source/WebKit/chromium:

Use new editor command for pasting global selection.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::supportsGlobalSelection):

  • src/EditorClientImpl.h:

(EditorClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseUp):

Source/WebKit/qt:

Use new editor command for pasting global selection, and update it using
the respondToChangedSelection callback.

  • Api/qwebpage.cpp:

(QWebPagePrivate::handleClipboard):

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::respondToChangedSelection):
(WebCore::EditorClientQt::supportsGlobalSelection):

  • WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit2:

Implements the hooks for supporting global selections in Qt WebKit2.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::updateGlobalSelection):
(WebKit::WebEditorClient::supportsGlobalSelection):

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::updateGlobalSelection):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::handleMouseReleaseEvent):

LayoutTests:

Adds a test for the new editor-command, and disables it an all platforms where it is not supported.

  • editing/pasteboard/paste-global-selection-expected.txt: Added.
  • editing/pasteboard/paste-global-selection.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt-mac/Skipped:
  • platform/win/Skipped:
5:32 AM Changeset in webkit [127861] by vsevik@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: Migrate Database to async protocol commands
https://bugs.webkit.org/show_bug.cgi?id=95983

Reviewed by Alexander Pavlov.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore):
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::setFrontend):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::executeSQL):

  • inspector/InspectorDatabaseAgent.h:

(InspectorDatabaseAgent):

  • inspector/front-end/Database.js:

(WebInspector.Database.prototype.executeSql):
(WebInspector.DatabaseDispatcher.prototype.addDatabase):

5:29 AM Changeset in webkit [127860] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed single line follow-up change for r127856.

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryClassInfo::MemoryClassInfo):

5:26 AM Changeset in webkit [127859] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector closure compilation errors fix.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.NamedFlowCollection):

5:23 AM Changeset in webkit [127858] by vsevik@chromium.org
  • 13 edits in trunk

Web Inspector: Migrate FileSystem to async protocol commands.
https://bugs.webkit.org/show_bug.cgi?id=95985

Reviewed by Alexander Pavlov.

Source/WebCore:

Migrated FileSystem domain to async protocol commands and removed boilerplate code.

  • inspector/Inspector.json:
  • inspector/InspectorFileSystemAgent.cpp:

(WebCore):
(WebCore::InspectorFileSystemAgent::~InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
(WebCore::InspectorFileSystemAgent::requestFileContent):
(WebCore::InspectorFileSystemAgent::deleteEntry):
(WebCore::InspectorFileSystemAgent::clearFrontend):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::assertEnabled):

  • inspector/InspectorFileSystemAgent.h:

(InspectorFileSystemAgent):

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel):
(WebInspector.FileSystemModel.prototype._originAdded):
(WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
(WebInspector.FileSystemModel.prototype.requestDirectoryContent):
(WebInspector.FileSystemModel.prototype._requestDirectoryContent):
(WebInspector.FileSystemModel.prototype._directoryContentReceived):
(WebInspector.FileSystemModel.prototype.requestMetadata):
(WebInspector.FileSystemModel.prototype.requestFileContent):
(WebInspector.FileSystemModel.prototype._requestFileContent):
(WebInspector.FileSystemModel.prototype._deleteEntry):

LayoutTests:

  • http/tests/inspector/filesystem/delete-entry.html:
  • http/tests/inspector/filesystem/directory-tree.html:
  • http/tests/inspector/filesystem/filesystem-test.js:

(initialize_FileSystemTest.InspectorTest.MockEntry):

  • http/tests/inspector/filesystem/request-directory-content.html:
  • http/tests/inspector/filesystem/request-file-content.html:
  • http/tests/inspector/filesystem/request-filesystem-root.html:
  • http/tests/inspector/filesystem/request-metadata.html:
5:17 AM Changeset in webkit [127857] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Update TextExpectations for http/tests/appcache/load-from-appcache-defer-resume-crash.html
https://bugs.webkit.org/show_bug.cgi?id=96091

Unreviewed EFL gardening.

Add bug number of http/tests/appcache/load-from-appcache-defer-resume-crash.html
in TestExpectations file.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-07

  • platform/efl-wk2/TestExpectations:
5:10 AM Changeset in webkit [127856] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: NMI: remove DataRef instrumentation from the core NMI code.
https://bugs.webkit.org/show_bug.cgi?id=96086

Reviewed by Yury Semikhatsky.

This patch is removing the last WebCore specific methods from core memory instrumentation code.

It is covered by webkit_unit_tests.

  • dom/MemoryInstrumentation.h:

(WebCore):
(MemoryObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):

  • rendering/style/DataRef.h:

(DataRef):
(WebCore::DataRef::reportMemoryUsage):

5:05 AM Changeset in webkit [127855] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip passing tests on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=96089

Unreviewed EFL gardening, unskip now passing tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-07

  • platform/efl/TestExpectations:
4:57 AM Changeset in webkit [127854] by vsevik@chromium.org
  • 10 edits in trunk

Web Inspector: Migrate IndexedDB to async protocol commands.
https://bugs.webkit.org/show_bug.cgi?id=95978

Reviewed by Alexander Pavlov.

Source/WebCore:

IndexedDB is now implemented using async protocol commands.
Removed boilerplate code used to emulate async commands before.

  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::InspectorIndexedDBAgent::clearFrontend):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):

  • inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._databaseRemoved):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.loadObjectStoreData):
(WebInspector.IndexedDBModel.prototype.loadIndexData):
(WebInspector.IndexedDBModel.prototype._requestData.innerCallback):
(WebInspector.IndexedDBModel.prototype._requestData):

LayoutTests:

  • http/tests/inspector/indexeddb/database-data.html:
  • http/tests/inspector/indexeddb/database-names.html:
  • http/tests/inspector/indexeddb/database-structure.html:
  • http/tests/inspector/indexeddb/resources-panel.html:
4:45 AM Changeset in webkit [127853] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed. Add Gábor Ballabás as contributor.

  • Scripts/webkitpy/common/config/committers.py:
4:04 AM Changeset in webkit [127852] by gyuyoung.kim@samsung.com
  • 9 edits in trunk/Source/WebCore

Add *explicit* keyword to constructors in WebCore/xml
https://bugs.webkit.org/show_bug.cgi?id=96071

Reviewed by Kentaro Hara.

As a step to let *explicit* add to constructors which have only one parameter,
*explicit* is added to Source/WebCore/xml in order to avoid implicit type conversion.

No new tests. Covered by existing tests.

  • xml/NativeXPathNSResolver.h:

(NativeXPathNSResolver):

  • xml/XMLHttpRequestException.h:

(WebCore::XMLHttpRequestException::XMLHttpRequestException):

  • xml/XMLHttpRequestProgressEventThrottle.h:

(XMLHttpRequestProgressEventThrottle):

  • xml/XMLHttpRequestUpload.h:

(XMLHttpRequestUpload):

  • xml/XPathException.h:

(WebCore::XPathException::XPathException):

  • xml/XPathPredicate.h:

(Number):
(StringExpression):
(Predicate):

  • xml/XPathValue.h:

(WebCore::XPath::ValueData::ValueData):

  • xml/XPathVariableReference.h:

(VariableReference):

3:44 AM Changeset in webkit [127851] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
https://bugs.webkit.org/show_bug.cgi?id=96078

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-07
Reviewed by Tor Arne Vestbø.

Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.

  • qmake/mkspecs/features/default_pre.prf:
3:26 AM Changeset in webkit [127850] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[EFL] Add TestExpectations file for efl-wk1
https://bugs.webkit.org/show_bug.cgi?id=96019

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-07
Reviewed by Gyuyoung Kim.

Tools:

Update TestExpectations cascading for EFL port
so that we use efl-wk1 -> efl search paths
for WebKit1 EFL.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._search_paths):

LayoutTests:

Add TestExpectations file for WebKit1 EFL.

  • platform/efl-wk1/TestExpectations: Added.
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
3:01 AM Changeset in webkit [127849] by zandobersek@gmail.com
  • 4 edits
    1 add in trunk/Tools

[NRWT] XvfbDriver should stop the Xvfb more aggressively
https://bugs.webkit.org/show_bug.cgi?id=95097

Reviewed by Dirk Pranke.

The Xvfb process is now killed when the XvfbDriver is stopping. Simply
terminating the process does not always work as expected, leading to timeouts
in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
as it's not removed by the killed Xvfb process.

Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
is tested in different circumstances - whether pixel tests are enabled or not,
with an arbitrary worker number or with an Xorg process already running on the system.
The stopping of the driver is tested by checking that the Xvfb process is truly killed
and then set to None.

  • BuildSlaveSupport/kill-old-processes:

Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
is left running, potentially clogging up a display at a certain position.

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.init):
The _running_pids is now a dictionary with process names as keys and pids
as values.
(MockExecutive.check_running_pid):
Check whether the passed-in pid is in the _running_pids dictionary's values.
(MockExecutive):
(MockExecutive.running_pids):
This method returns the list of all the process pids of which the name passes
through the process_name_filter.

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

Use the Executive object of the port's host to check for running pids and open
new subprocesses or kill them throughout the class.
(XvfbDriver._start):
Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
start the server process after it's created.
(XvfbDriver.stop):
Now kills the Xvfb process instead of terminating it and waiting for it to close.

  • Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.

(XvfbDriverTest):
(XvfbDriverTest.make_driver):
(XvfbDriverTest.assertDriverStartSuccessful):
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_start_existing_xorg_process):
(XvfbDriverTest.test_stop):
(XvfbDriverTest.test_stop.FakeXvfbProcess):

2:59 AM Changeset in webkit [127848] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source/WebKit/efl

Unreviewed, rolling out r127839.
http://trac.webkit.org/changeset/127839
https://bugs.webkit.org/show_bug.cgi?id=90603

This patch was landed with wrong implementation and policy.

  • WebCoreSupport/NotificationPresenterClientEfl.cpp:

(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):

  • WebCoreSupport/NotificationPresenterClientEfl.h:

(NotificationPresenterClientEfl):

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

  • ewk/ewk_view.h:
  • ewk/ewk_view_private.h:
2:20 AM Changeset in webkit [127847] by peter@chromium.org
  • 2 edits in trunk/Tools

Introduce the Chromium Android Release (Tests) bot
https://bugs.webkit.org/show_bug.cgi?id=95980

Reviewed by Adam Barth.

This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
which will be running layout tests on actual Android devices. Right now,
four Galaxy Nexus phones are attached.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
1:58 AM Changeset in webkit [127846] by nduca@chromium.org
  • 2 edits in trunk/Source/Platform

[chromium] Allow enumeration of WebRenderingStats structure
https://bugs.webkit.org/show_bug.cgi?id=94565

Reviewed by James Robinson.

  • chromium/public/WebRenderingStats.h:

(WebRenderingStats):
(Enumerator):
(WebKit::WebRenderingStats::Enumerator::~Enumerator):
(WebKit::WebRenderingStats::enumerateFields):

1:52 AM Changeset in webkit [127845] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] APIClientTraits<WKPageLoaderClient> and APIClientTraits<WKBundlePageLoaderClient> are not initialized properly
https://bugs.webkit.org/show_bug.cgi?id=96079

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

APIClientTraits<WKPageLoaderClient> was missing offset for version number 2 and
APIClientTraits<WKBundlePageLoaderClient> was missing offset for version number 3.

  • Shared/APIClientTraits.cpp:

(WebKit):

1:47 AM Changeset in webkit [127844] by annacc@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Rebaselines for windows due to r127831.

Unreviewed gardening.

  • platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
  • platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt:
1:46 AM Changeset in webkit [127843] by yosin@chromium.org
  • 6 edits in trunk/Source

We should have a localized string of empty for date time field
https://bugs.webkit.org/show_bug.cgi?id=96081

Reviewed by Kent Tamura.

Source/Platform:

This patch adds a localized string enum field for empty field value
description text for accessibility support in multiple fields date
time related input types for Chromium ports.

  • chromium/public/WebLocalizedString.h: Added AXDateTimeFieldEmptyValueText

enum field.

Source/WebCore:

This patch add a declaration of function for getting localized string
of empty field value date time field for accessibility inside
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

No new tests. This patch doesn't change behavior.

  • platform/LocalizedStrings.h:

(WebCore): Added a declaration of AXDateTimeFieldEmptyValueText().

Source/WebKit/chromium:

This patch add a function for getting localized string of empty field
value of date time fields for accessibility inside
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

  • src/LocalizedStrings.cpp:

(WebCore::AXDateTimeFieldEmptyValueText): Added.

1:28 AM Changeset in webkit [127842] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add APIs to enable or disable the mouse events of the ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=88631

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-07
Reviewed by Gyuyoung Kim.

We can turn on/off the mouse events of the ewk_view using the mouse
events enabling API. This API can be used when we want to turn off the
mouse events on the touchscreen device to process the touch events
instead of the mouse events.

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_smart_add):
(ewk_view_mouse_events_enabled_set):
(ewk_view_mouse_events_enabled_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

1:19 AM Changeset in webkit [127841] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Use ASCIILiteral for cursorStringMap.
https://bugs.webkit.org/show_bug.cgi?id=96072

Reviewed by Gyuyoung Kim.

This patch converts static strings of cursorStringMap to use ASCIILiteral
as recommended by http://trac.webkit.org/wiki/EfficientStrings.

  • platform/efl/EflScreenUtilities.cpp:

(WebCore::CursorMap::CursorMap):

1:08 AM Changeset in webkit [127840] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

Scrolling performance logging should use WTFLogAlways instead of printf
https://bugs.webkit.org/show_bug.cgi?id=96080

Reviewed by Dan Bernstein.

Use WTF logging facilities instead of printf() for scrolling performance logging.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::logExposedUnfilledArea):

  • platform/graphics/ca/mac/WebTileLayer.mm:

(-[WebTileLayer logFilledFreshTile]):

12:56 AM Changeset in webkit [127839] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/efl

[EFL] Support the permission function of the Web Notification.
https://bugs.webkit.org/show_bug.cgi?id=90603

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-09-07
Reviewed by Gyuyoung Kim.

Implement permission related functions of Web Notifications.
checkPermission for Notification.permissionLevel().
requestPermission for Notification.requestPermission().
In addition, if the application(like a browser) has permitted domains already,
it can be cached using ewk_view_notification_permissions_store.

  • WebCoreSupport/NotificationPresenterClientEfl.cpp:

(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::addToPermissionCache):
(WebCore):
(WebCore::NotificationPresenterClientEfl::setPermission):

  • WebCoreSupport/NotificationPresenterClientEfl.h:

(WebCore):
(NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_notification_permission_store):
(ewk_view_notification_permissions_set):
(ewk_view_notification_permission_request):

  • ewk/ewk_view.h:
  • ewk/ewk_view_private.h:
12:48 AM Changeset in webkit [127838] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Make CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing memory leak in the process.
https://bugs.webkit.org/show_bug.cgi?id=95938

Reviewed by Andreas Kling.

Several unit types have been added without updating the cleanup function, including CSS_VARIABLE_NAME.
I've added all the existing unit types back in and cast m_primitiveUnitType (a bitfield in CSSValue)
to the enum type to ensure the compiler catches any future errors.

No test added, but switch made to use enum type so we can't accidentally fail to update this function again.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cleanup):

12:45 AM Changeset in webkit [127837] by timothy_horton@apple.com
  • 16 edits in trunk/Source

Add optional debug logging when we fall into/out of threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=93898
<rdar://problem/12089098>

Reviewed by Simon Fraser.

Add logging when we enter and exit the threaded scrolling mode, and logs the reasons we
fall into main-thread scrolling.

The logging output looks like this:

SCROLLING: Switching to main-thread scrolling mode. Time: 15843.554718 Reason(s): viewport-constrained objects
SCROLLING: Switching to threaded scrolling mode. Time: 15844.550866
SCROLLING: Switching to main-thread scrolling mode. Time: 15845.551214 Reason(s): viewport-constrained objects
SCROLLING: Switching to threaded scrolling mode. Time: 15846.552619
SCROLLING: Switching to main-thread scrolling mode. Time: 15847.553587 Reason(s): viewport-constrained objects
SCROLLING: Switching to threaded scrolling mode. Time: 15848.554084

No new tests, as this is just debugging logging.

  • WebCore.xcodeproj/project.pbxproj:

Expose ScrollingTreeState.h as a private header.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinator::setForceMainThreadScrollLayerPositionUpdates):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThreadReason):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThreadReason):

  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::ScrollingTreeNode):
(WebCore::ScrollingTreeNode::update):

  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThreadReason):
(ScrollingTreeNode):

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setShouldUpdateScrollLayerPositionOnMainThreadReason):

  • page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::shouldUpdateScrollLayerPositionOnMainThreadReason):

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThreadReason):
Rename updateShouldUpdateScrollLayerPositionOnMainThread to updateShouldUpdateScrollLayerPositionOnMainThreadReason (and related).

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasNonLayerViewportConstrainedObjects):
Renamed from hasNonLayerFixedObjects to match the rest of the renames going on.
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThreadReason):
Construct a bitfield describing the reasons we fall into main-thread scrolling mode.

  • page/scrolling/ScrollingTreeState.h:

(ScrollingTreeState):
Add ReasonsForUpdatingScrollLayerPositionOnMainThread enum, with the current reasons that we might fallback to main-thread scrolling.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore):
(WebCore::ScrollingTreeNodeMac::update): Log every time scrolling mode changes.
(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollPositionWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
(WebCore::logThreadedScrollingMode): Pretty-print the scrolling mode and shouldUpdateScrollLayerPositionOnMainThreadReason.

Update the scrolling tree's scrollingPerformanceLoggingEnabled preference
before the early-return if we don't have layer debugging borders on.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

12:04 AM Changeset in webkit [127836] by annacc@chromium.org
  • 10 edits
    1 add in trunk/LayoutTests

Rebaselines due to r127831.

Unreviewed gardening.

  • platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Added.
  • platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt:
  • platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
  • platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt:
12:03 AM Changeset in webkit [127835] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r127801.

  • platform/graphics/wince/FontWinCE.cpp:

(WebCore::generateComponents):

Sep 6, 2012:

11:29 PM Changeset in webkit [127834] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Updating baselines for two MathML tests after r127769.

Removing failure expectations for tests fixed by changes in r127798,
rollout in r127774 and rebaseline in r127825.

  • platform/gtk/TestExpectations:
  • platform/gtk/mathml/presentation/roots-expected.txt:
  • platform/gtk/mathml/presentation/sup-expected.txt:
11:26 PM Changeset in webkit [127833] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Regression: Web Inspector tool-tips pixellated with --force-device-scale-factor=2
https://bugs.webkit.org/show_bug.cgi?id=95875

Reviewed by Vsevolod Vlasov.

The overlay canvas is scaled according to the actual devicePixelRatio of the inspected page, while retaining its original CSS size.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::reset):

  • inspector/InspectorOverlayPage.html:
11:15 PM Changeset in webkit [127832] by loislo@chromium.org
  • 18 edits in trunk/Source

Unreviewed, rolling out r127822.
http://trac.webkit.org/changeset/127822
https://bugs.webkit.org/show_bug.cgi?id=96073

It broke compilation on chromium debug bots (Requested by
loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

Source/WebCore:

  • platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):

  • platform/graphics/chromium/cc/CCDirectRenderer.h:

(CCDirectRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore::removeRenderPassesRecursive):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):
(WebCore::CCRenderPass::copy):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::copy):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(WebCore):
(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendRenderPasses):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderer.h:

(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):

Source/WebKit/chromium:

  • tests/CCDrawQuadTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCRenderPassTest.cpp:

(WebCore::TEST):

  • tests/CCRenderSurfaceTest.cpp:
  • tests/CCRendererGLTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):

10:59 PM Changeset in webkit [127831] by annacc@chromium.org
  • 5 edits in trunk/Source/WebCore

The CC button should have chrome-specific rendering for Mac.
https://bugs.webkit.org/show_bug.cgi?id=95981

Reviewed by Eric Carlson.

This patch allows RenderThemeChromiumMac to define its own behavior for the CC button.

No new tests. Button should display graphics from chromium resources.

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
Adjust styling for the chromium graphics.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaClosedCaptionsButton):
Check whether closed captions are visible to decide how to draw the button.

  • rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):
Override the paint function for the CC button.

  • rendering/RenderThemeChromiumMac.mm:

(WebCore):
(WebCore::RenderThemeChromiumMac::paintMediaToggleClosedCaptionsButton):
Call the chromium-specific painting function.

10:54 PM Changeset in webkit [127830] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Tests] Skip Dialog element tests on Win
https://bugs.webkit.org/show_bug.cgi?id=96051

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-09-06
Reviewed by Hajime Morita.

Dialog is not yet enabled except on Chromium. Dialog tests should have
been added to the Win port's skipped list as part of r122420.

  • platform/win/Skipped:
10:53 PM Changeset in webkit [127829] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

JSC should have a zombie mode
https://bugs.webkit.org/show_bug.cgi?id=96047

Reviewed by Geoffrey Garen.

To aid clients of JSC while they are debugging memory issues, we should add a zombie
mode that scribbles into objects in the MarkedSpace after they are found to be dead
to prevent a sort of "use after free" situation. As a first cut we should support a
mode that just scribbles on objects prior to their being reused (i.e. while they are
"zombies") and a mode in which, in addition to scribbling on zombies, once an object
has been marked its mark bit will never be cleared, thus giving us "immortal" zombies.

These two modes will be enabled through the use of environment variables. For now these
will be "JSZombieEnabled" and "JSImmortalZombieEnabled". Setting them to any value will
result in the use of the appropriate mode.

  • heap/Heap.cpp:

(JSC::Heap::collect): Zombifies dead objects at the end of collection if zombie mode is enabled.
(ZombifyCellFunctor):
(JSC::ZombifyCellFunctor::ZombifyCellFunctor): Sets marked bits for dead objects if in immortal mode and writes 0xbbadbeef into them.
(JSC::ZombifyCellFunctor::operator()):
(JSC):
(ZombifyBlockFunctor):
(JSC::ZombifyBlockFunctor::operator()):
(JSC::Heap::zombifyDeadObjects): Eagerly sweeps so that we don't write garbage into an object before it
is finalized/destroyed.

  • heap/Heap.h:

(Heap):

  • heap/MarkedBlock.h:

(MarkedBlock):
(JSC::MarkedBlock::forEachDeadCell): Used to iterate over dead cells at the end of collection if zombie mode is enabled.
(JSC):

  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/Options.h:

(JSC):

10:34 PM Changeset in webkit [127828] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Deploy StringBuilder in more places in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=95924

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-06
Reviewed by Benjamin Poulain.

Deploy StringBuilder to concatenate strings more efficiently.

  • Shared/WebMemorySampler.cpp:

(WebKit):
(WebKit::WebMemorySampler::WebMemorySampler):
(WebKit::WebMemorySampler::stop):
(WebKit::WebMemorySampler::writeHeaders):
(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):

  • Shared/WebMemorySampler.h:

(WebMemorySampler):

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::capitalizeRFC822HeaderFieldName):

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle):

10:32 PM Changeset in webkit [127827] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

REGRESSION(127810): It broke inspector/debugger/debugger-expand-scope.html
https://bugs.webkit.org/show_bug.cgi?id=96065

Unreviewed, reverting the expected file change.

  • inspector/debugger/debugger-expand-scope-expected.txt:
10:22 PM Changeset in webkit [127826] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Add methods to CounterDirectives to clean up StyleBuilder and RenderCounter.
https://bugs.webkit.org/show_bug.cgi?id=94587

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-09-06
Reviewed by Julien Chaffraix.

Source/WebCore:

Adds several methods to CounterDirectives and an accessor method to RenderStyle for
getting the CounterDirectives by idenfitier and uses those methods to clean up
the code in StyleBuilder and RenderCounter. This also switches to using AtomicString
directly instead of AtomicStringImpl and calling get() everywhere.

The refactor fixes the unitialized read in WKBug 94642.

Test: fast/css/counters/counter-reset-inherit-bug-94642.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::counterToCSSValue): Use new accessors.

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyCounter::applyInheritValue): Use new inherit methods.
(WebCore::ApplyPropertyCounter::applyValue): Use new setters.

  • rendering/RenderCounter.cpp:

(WebCore):
(WebCore::planCounter):
(WebCore::makeCounterNode):
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):
(showCounterRendererTree):

  • rendering/style/CounterDirectives.cpp:

(WebCore::operator==):

  • rendering/style/CounterDirectives.h: Added new accessors and switched to using AtomicString directly.

(CounterDirectives):
(WebCore::CounterDirectives::CounterDirectives):
(WebCore::CounterDirectives::isReset):
(WebCore::CounterDirectives::resetValue):
(WebCore::CounterDirectives::setResetValue):
(WebCore::CounterDirectives::clearReset):
(WebCore::CounterDirectives::inheritReset):
(WebCore::CounterDirectives::isIncrement):
(WebCore::CounterDirectives::incrementValue):
(WebCore::CounterDirectives::addIncrementValue):
(WebCore::CounterDirectives::clearIncrement):
(WebCore::CounterDirectives::inheritIncrement):
(WebCore::CounterDirectives::isDefined): If either reset or increment is used.
(WebCore::CounterDirectives::combinedValue): Combined local value of the counter.
(WebCore):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCounterDirectives): New method which always returns a CounterDirectives instance by identifier.
(WebCore):

  • rendering/style/RenderStyle.h:

LayoutTests:

Tests for bug 94642 exposing an unitialized read when using counter-reset and
counter-increment: inherit.

  • fast/css/counters/counter-reset-inherit-bug-94642-expected.html: Added.
  • fast/css/counters/counter-reset-inherit-bug-94642.html: Added.
10:09 PM Changeset in webkit [127825] by commit-queue@webkit.org
  • 4 edits in trunk

[Gtk] accessibility/canvas-description-and-role expected results needed
https://bugs.webkit.org/show_bug.cgi?id=95644

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-06
Reviewed by Martin Robinson.

Source/WebCore:

The new accessibility CanvasRole should be mapped to ATK_ROLE_CANVAS
rather than ATK_ROLE_IMAGE.

No new test because the CanvasRole came with a new layout test lacking
expected results for Gtk. The generated expected results for that test
reflect the revised mapping to ATK_ROLE_CANVAS.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

LayoutTests:

Generated expected results for Gtk. These results reflect the revised
mapping of CanvasRole to ATK_ROLE_CANVAS rather than ATK_ROLE_IMAGE.

  • platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.
10:03 PM Changeset in webkit [127824] by hbono@chromium.org
  • 4 edits in trunk/Source

A build fix for Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=96062

Reviewed by James Robinson.

Source/Platform:

This change fixes a build break on Chromium Windows (debug) caused by r127796
<http://trac.webkit.org/changeset/127796>. It removes a redundant WEBKIT_EXPORT.

  • chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

Source/WebCore:

This change fixes a build break on Chromium Windows caused by r127801
<http://trac.webkit.org/changeset/127801>. It replaces characters() with
characters16().

No new tests because this change is a build fix.

  • platform/graphics/chromium/UniscribeHelperTextRun.cpp:

(WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):

10:00 PM Changeset in webkit [127823] by ryuan.choi@samsung.com
  • 4 edits
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add API unit tests for ewk_view_theme_set.
https://bugs.webkit.org/show_bug.cgi?id=94670

Reviewed by Gyuyoung Kim.

Added unit tests for ewk_view_theme_set.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::pathForResource):
Added to get path of resource.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:

Ditto.

  • UIProcess/API/efl/tests/resources/big_button_theme.edj:

Added test theme file which has text_confinement of button as
rel1 { ... offset : 150 8; } rel2 { ... offset : -150 -11; }.

  • UIProcess/API/efl/tests/resources/empty_theme.edj:

Added test theme file which includes nothing.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

Added unit test for ewk_view_theme_set.

9:49 PM Changeset in webkit [127822] by danakj@chromium.org
  • 18 edits in trunk/Source

[chromium] Make RenderPass ids hold both generating layer id and an index
https://bugs.webkit.org/show_bug.cgi?id=95500

Reviewed by Adrienne Walker.

Source/WebCore:

This change allows us to avoid complex renderPassId mappings between
compositors for ubercomp. The ubercomp layer needs to add a number
of RenderPasses to the frame, and these must not conflict with other
RenderPasses in the frame. By using its layer id along with an extra
value it determines, the layer can create a unique id without needing
access to any global state or id generator.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCDirectRenderer.cpp:

(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):

  • platform/graphics/chromium/cc/CCDirectRenderer.h:

(CCDirectRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore::removeRenderPassesRecursive):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(Id):
(WebCore::CCRenderPass::Id::Id):
(WebCore::CCRenderPass::Id::operator==):
(WebCore::CCRenderPass::Id::operator!=):
(WebCore::CCRenderPass::Id::operator<):
(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::renderPassId):
(WebCore):
(WebCore::CCRenderSurface::appendRenderPasses):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderer.h:

(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCRenderSurfaceTest.cpp:
  • tests/CCRendererGLTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):

9:48 PM Changeset in webkit [127821] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

StringBuilder::toAtomicString() can create an 16 bit string with 8 bit contents
https://bugs.webkit.org/show_bug.cgi?id=96029

Reviewed by Benjamin Poulain.

Added 8 bit path when creating an AtomicString from a partial 8 bit buffer.

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::toAtomicString):

9:39 PM Changeset in webkit [127820] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[chromium] Do not delete texture backing structures on the main thread
https://bugs.webkit.org/show_bug.cgi?id=96018

Patch by Christopher Cameron <ccameron@chromium.org> on 2012-09-06
Reviewed by James Robinson.

Do not delete CCPrioritizedTexture::Backing structures on the main
thread. Instead, unlink them from their owning CCPrioritizedTexture
in the main thread, and have the impl thread then delete all unlinked
textures.

This is towards having the main thread not access the m_backings set,
which will allow the impl thread to traverse that set when deleting
resources in response to GPU memory management events.

Tested by existing eviction tests (CCLayerTreeHostTest's
TestEvictTextures, LostContextAfterEvictTextures)

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::unlinkAllContentTextures):
(WebCore):
(WebCore::CCLayerTreeHost::deleteUnlinkedTextures):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::unlinkAllBackings):
(WebCore):
(WebCore::CCPrioritizedTextureManager::deleteAllUnlinkedBackings):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:

(CCPrioritizedTextureManager):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

9:37 PM Changeset in webkit [127819] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Fix debug Windows build
https://bugs.webkit.org/show_bug.cgi?id=96008

Reviewed by Tor Arne Vestbø.

Add a few more files to the AllInOne configuration to reduce the number of object files
and their total size, allowing a debug build with MSVC again.

  • Target.pri:
9:21 PM Changeset in webkit [127818] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix text encoding detecting
https://bugs.webkit.org/show_bug.cgi?id=96014

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Since we rely on ICU now, we might as well use the actually implemented text encoding
detector instead of the dummy "none" one.

I could not locate any layout tests that actually cover this :(

  • Target.pri:
9:18 PM Changeset in webkit [127817] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit

[BlackBerry] Implement a color picker
https://bugs.webkit.org/show_bug.cgi?id=96001

Patch by Crystal Zhang <haizhang@rim.com> on 2012-09-06
Reviewed by Rob Buis.

Source/WebKit:

Add color picker files into building system.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Add files for color picker, replace old hook to AIR color picker.

  • WebCoreSupport/ColorPickerClient.cpp: Added.

(WebCore):
(WebCore::ColorPickerClient::ColorPickerClient):
(WebCore::ColorPickerClient::~ColorPickerClient):
(WebCore::ColorPickerClient::generateHTML):
(WebCore::ColorPickerClient::closePopup):
(WebCore::ColorPickerClient::contentSize):
(WebCore::ColorPickerClient::htmlSource):
(WebCore::ColorPickerClient::setValueAndClosePopup):
(WebCore::ColorPickerClient::didClosePopup):
(WebCore::ColorPickerClient::writeDocument):

  • WebCoreSupport/ColorPickerClient.h: Added.

(WebKit):
(WebCore):
(ColorPickerClient):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openColorPopup):

9:14 PM Changeset in webkit [127816] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
https://bugs.webkit.org/show_bug.cgi?id=96017

Unreviewed Qt-WK2 buildfix after r127783.

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::syncFixedLayers):

8:35 PM Changeset in webkit [127815] by yosin@chromium.org
  • 6 edits in trunk/Source

We should have localized strings of date time fields for accessibility
https://bugs.webkit.org/show_bug.cgi?id=96050

Reviewed by Kent Tamura.

Source/Platform:

This patch adds localized string enum fields for accessibility support
in multiple fields date time related input types for Chromium ports.

  • chromium/public/WebLocalizedString.h: Adds AXAMPMFieldText, AXDayOfMonthField,

AXHourFieldText, AXMillisecondFieldText, AXMinuteFieldText, AXMonthField,
AXSecondFieldText, AXWeekOfYearFieldText, and AXYearFieldText.

Source/WebCore:

This patch adds declarations of function for getting localized string
of date time field for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

No new tests. This patch doesn't change behavior.

  • platform/LocalizedStrings.h:

(WebCore): Added declarations of AXAMPMFieldText(), AXDayOfMonthFieldText(),
AXHourFieldText(), AXMillisecondFieldText(), AXMinuteFieldText(), AXMonthFieldText(),
AXSecondFieldText(), AXWeekOfYearFieldText(), and AXYearFieldText().

Source/WebKit/chromium:

This patch adds functions for getting localized strings of date time
fields for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

  • src/LocalizedStrings.cpp:

(WebCore::AXAMPMFieldText): Added.
(WebCore::AXDayOfMonthFieldText): Added.
(WebCore::AXHourFieldText): Added.
(WebCore::AXMillisecondFieldText): Added.
(WebCore::AXMinuteFieldText): Added.
(WebCore::AXMonthFieldText): Added.
(WebCore::AXSecondFieldText): Added.
(WebCore::AXWeekOfYearFieldText): Added.
(WebCore::AXYearFieldText): Added.

8:17 PM Changeset in webkit [127814] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r127808.
http://trac.webkit.org/changeset/127808
https://bugs.webkit.org/show_bug.cgi?id=96057

geoff rolled back in his change, but not this part (Requested
by thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

  • inspector/debugger/debugger-expand-scope-expected.txt:
7:45 PM Changeset in webkit [127813] by commit-queue@webkit.org
  • 3 edits
    2 adds
    26 deletes in trunk/LayoutTests

fast/table/empty-row-crash.html and fast/table/inline-form-assert.html should be dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=95613

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-09-06
Reviewed by Julien Chaffraix.

Modified the test cases empty-row-crash.html and inline-form-assert.html to dumpAsText tests.
As the testcases check for crash/assert and not for the correctness of content layout or painting
they can be safely modified to dumpAsText tests.

  • fast/table/empty-row-crash-expected.txt: Added. New expected file.
  • fast/table/empty-row-crash.html: Added a short description about the testcase.
  • fast/table/inline-form-assert-expected.txt: Added. New expected file.
  • fast/table/inline-form-assert.html:
  • platform/chromium-linux/fast/table/empty-row-crash-expected.png: Removed.
  • platform/chromium-linux/fast/table/inline-form-assert-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/empty-row-crash-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/inline-form-assert-expected.png: Removed.
  • platform/chromium-mac/fast/table/empty-row-crash-expected.png: Removed.
  • platform/chromium-mac/fast/table/inline-form-assert-expected.png: Removed.
  • platform/chromium-win/fast/table/empty-row-crash-expected.png: Removed.
  • platform/chromium-win/fast/table/empty-row-crash-expected.txt: Removed.
  • platform/chromium-win/fast/table/inline-form-assert-expected.png: Removed.
  • platform/chromium-win/fast/table/inline-form-assert-expected.txt: Removed.
  • platform/efl/fast/table/empty-row-crash-expected.png: Removed.
  • platform/efl/fast/table/empty-row-crash-expected.txt: Removed.
  • platform/efl/fast/table/inline-form-assert-expected.png: Removed.
  • platform/efl/fast/table/inline-form-assert-expected.txt: Removed.
  • platform/gtk/fast/table/empty-row-crash-expected.png: Removed.
  • platform/gtk/fast/table/empty-row-crash-expected.txt: Removed.
  • platform/gtk/fast/table/inline-form-assert-expected.png: Removed.
  • platform/gtk/fast/table/inline-form-assert-expected.txt: Removed.
  • platform/mac/fast/table/empty-row-crash-expected.png: Removed.
  • platform/mac/fast/table/empty-row-crash-expected.txt: Removed.
  • platform/mac/fast/table/inline-form-assert-expected.png: Removed.
  • platform/mac/fast/table/inline-form-assert-expected.txt: Removed.
  • platform/qt/fast/table/empty-row-crash-expected.png: Removed.
  • platform/qt/fast/table/empty-row-crash-expected.txt: Removed.
  • platform/qt/fast/table/inline-form-assert-expected.png: Removed.
  • platform/qt/fast/table/inline-form-assert-expected.txt: Removed. Removed obsolete baselines.
7:43 PM Changeset in webkit [127812] by tony@chromium.org
  • 4 edits in trunk/Source/WebCore

Make computePositionedLogicalWidth and computePositionedLogicalWidthReplaced const
https://bugs.webkit.org/show_bug.cgi?id=95907

Reviewed by Ojan Vafai.

This is refactoring to make RenderBox::computeLogicalWidth const. Make some methods that
get called by computeLogicalWidth const. We path in a struct that we populate with values.

No new tests, this is just a refactoring.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion): Make a LogicalExtentComputedValues to
hold results.
(WebCore::RenderBox::computePositionedLogicalWidth): Make const.
(WebCore::RenderBox::computePositionedLogicalWidthUsing): Change output to use LogicalExtentComputedValues
instead of 4 separate params.
(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Make const.

  • rendering/RenderBox.h:

(RenderBox): Add const and change out params to LogicalExtentComputedValues.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth): Make a LogicalExtentComputedValues to
hold results.

7:25 PM Changeset in webkit [127811] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

[Shadow DOM][Refactoring] Element subclasses should have a way to reject author shadows.
https://bugs.webkit.org/show_bug.cgi?id=95831

Reviewed by Dimitri Glazkov.

Originally, the availability of author shadows was decided by ShadowRoot class.
This change moves that responsibility to each Element subclasses to make future
author shadow support improvement local to each replaced elements, rather than
touching ShadowRoot.cpp for reach.

No new tests. Should have no behavioral change.

  • dom/Element.h:
  • dom/ShadowRoot.cpp:

(WebCore::allowsAuthorShadowRoot):

  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

  • svg/SVGElement.h:

(SVGElement):

6:42 PM Changeset in webkit [127810] by ggaren@apple.com
  • 17 edits
    2 adds in trunk

Source/JavaScriptCore: Rolled back in <http://trac.webkit.org/changeset/127698> with a fix for
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html, which
is to make sure that function declarations don't put their names in scope.

Reviewed by Gavin Barraclough.

Named functions should not allocate scope objects for their names
https://bugs.webkit.org/show_bug.cgi?id=95659

Reviewed by Oliver Hunt.

LayoutTests: Rolled back in <http://trac.webkit.org/changeset/127698> with a fix for
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html.

Added a more explicit test for the feature I broke in
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html.

Reviewed by Gavin Barraclough.

Named functions should not allocate scope objects for their names
https://bugs.webkit.org/show_bug.cgi?id=95659

Reviewed by Oliver Hunt.

  • fast/dom/HTMLScriptElement/script-reexecution.html:
  • fast/js/function-name-is-in-scope-expected.txt: Added.
  • fast/js/function-name-is-in-scope.html: Added.
6:29 PM Changeset in webkit [127809] by msaboff@apple.com
  • 4 edits in trunk/Source

16 bit JSRopeString up converts an 8 bit fibers to 16 bits during resolution
https://bugs.webkit.org/show_bug.cgi?id=95810

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Added 8 bit path that copies the contents of an 8 bit fiber to the 16 bit buffer
when resolving a 16 bit rope.

  • runtime/JSString.cpp:

(JSC::JSRopeString::resolveRopeSlowCase):

Source/WTF:

New copy routine that takes an 8 bit source and a 16 bit destination. Used when copying
the contents of an 8 bit fiber to the 16 bit buffer when resolving a 16 bit rope.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::copyChars):
(StringImpl):

6:29 PM Changeset in webkit [127808] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, revert part of http://trac.webkit.org/changeset/127698
which accidentally didn't get reverted in
http://trac.webkit.org/changeset/127774.

  • inspector/debugger/debugger-expand-scope-expected.txt:
6:16 PM Changeset in webkit [127807] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

[Qt] Unskip two encoding tests that pass now
https://bugs.webkit.org/show_bug.cgi?id=96013

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

The result for frame-default-enc was incorrect and we succeed in
producing the existing cross-platform result. The other test passes
just fine.

  • platform/qt/Skipped:
  • platform/qt/fast/encoding/frame-default-enc-expected.txt: Removed.
5:57 PM Changeset in webkit [127806] by abarth@webkit.org
  • 64 edits in trunk/Source/WebCore

[V8] Weave creationContext through toV8 and related functions
https://bugs.webkit.org/show_bug.cgi?id=96039

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Eric Seidel.

In order to give DOM wrappers the correct prototype chain, we need to
know what the creationContext ought to be for each wrapper. This patch
weaves that information through toV8 and related functions.

This patch doesn't yet use the information. That will take place in a
separate patch. For that reason, this patch should not have any
behavior change.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):

  • bindings/v8/DOMTransaction.cpp:

(WebCore::DOMTransaction::callFunction):

  • bindings/v8/IDBCustomBindings.cpp:

(WebCore::V8IDBCursorWithValue::valueAccessorGetter):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8Binding.h:

(WebCore::V8ValueTraits::arrayV8Value):

  • bindings/v8/V8Collection.h:

(WebCore::getV8Object):
(WebCore::getNamedPropertyOfCollection):
(WebCore::collectionNamedPropertyGetter):
(WebCore::getIndexedPropertyOfCollection):
(WebCore::collectionIndexedPropertyGetter):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getter):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore):
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):

  • bindings/v8/V8ThrowException.cpp:

(WebCore):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):
(WebCore::V8Blob::constructorCallback):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorGetter):
(WebCore::V8CanvasRenderingContext2D::fillStyleAccessorGetter):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::memoryAccessorGetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
(WebCore::toV8):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):
(WebCore::V8Document::getCSSCanvasContextCallback):
(WebCore::toV8):
(WebCore::V8Document::createTouchListCallback):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

  • bindings/v8/custom/V8EntryCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EntrySyncCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAccessorGetter):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::V8HTMLCollection::namedPropertyGetter):
(WebCore::V8HTMLCollection::namedItemCallback):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::getNamedProperty):
(WebCore::V8HTMLDocument::allAccessorGetter):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8):
(WebCore::V8HTMLElement::itemValueAccessorGetter):

  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAccessorGetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):

  • bindings/v8/custom/V8HTMLOutputElementCustom.cpp:

(WebCore::V8HTMLOutputElement::htmlForAccessorGetter):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertyGetter):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):

  • bindings/v8/custom/V8MicroDataItemValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):

  • bindings/v8/custom/V8PerformanceCustom.cpp:

(WebCore):
(WebCore::V8Performance::memoryAccessorGetter):

  • bindings/v8/custom/V8PerformanceEntryCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8StyleSheetListCustom.cpp:

(WebCore::V8StyleSheetList::namedPropertyGetter):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

  • dom/make_names.pl:

(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

5:43 PM Changeset in webkit [127805] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed fix to r127799.
https://bugs.webkit.org/show_bug.cgi?id=95807

Unreviewed fix.

Removed extraneous "static". This code is hidden behind STRING_STATS define and
therefore is not enabled by default.

  • wtf/text/StringImpl.cpp:
5:36 PM Changeset in webkit [127804] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[EFL] 2 mathml tests need rebaseline after r127769
https://bugs.webkit.org/show_bug.cgi?id=96009

Unreviewed EFL gardening.

Update baselines for 2 mathml test cases needed after
r127769.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06

  • platform/efl/mathml/presentation/roots-expected.png:
  • platform/efl/mathml/presentation/roots-expected.txt:
  • platform/efl/mathml/presentation/sup-expected.png:
  • platform/efl/mathml/presentation/sup-expected.txt:
5:21 PM Changeset in webkit [127803] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium Linux EWS bots and CQ bots are flaky
https://bugs.webkit.org/show_bug.cgi?id=96041

Reviewed by Adam Barth.

Skip platform/chromium-linux/compositing/gestures tests on the
Chromium Linux EWS and CQ bots. By marking them as flaky, they won't
be run (the bots use --skip-failing-tests which causes them to skip
these tests). These will still run on the waterfall bots.

  • platform/chromium/TestExpectations:
4:54 PM Changeset in webkit [127802] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Qt] Deprecate String += operator
https://bugs.webkit.org/show_bug.cgi?id=95895

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-09-06
Reviewed by Benjamin Poulain.

Source/WebCore:

Replaced String +=() with append.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::extraMediaControlsStyleSheet):

Source/WTF:

Remove Qt from WTF_DEPRECATED_STRING_OPERATORS guard.

  • wtf/Platform.h:
4:52 PM Changeset in webkit [127801] by msaboff@apple.com
  • 17 edits in trunk/Source/WebCore

Add 8 bit string data path to TextRun
https://bugs.webkit.org/show_bug.cgi?id=95812

Reviewed by Dan Bernstein.

Added 8 bit string path to TextRun. Refactored TextRun::data() and ::characters into
8 and 16 bit versions. Made corresponding changes to users of TextRun.
For efl, gtk, qt and win platform specific code using TextRun, only the methods have
been renamed and the creation of 8 bit TextRuns has been disabled via compilation
flags. Someone knowledgeable in those platforms will need to make corresponding changes
to enable 8 bit processing of TextRuns.

No changes to functionality - behavior covered by existing tests.

  • platform/graphics/Font.cpp:

(WebCore::normalizeSpacesInternal):
(WebCore::Font::normalizeSpaces):
(WebCore::Font:normalizeSpaces):
(WebCore::Font::codePath):
(WebCore::Font::expansionOpportunityCount):

  • platform/graphics/Font.h:

(WebCore::Font::characterRangeCodePath):
(WebCore::Font::normalizeSpaces):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawBidiText):

  • platform/graphics/TextRun.cpp:

(ExpectedTextRunSize):

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::subRun):
(WebCore::TextRun::operator[]):
(WebCore::TextRun::data8):
(WebCore::TextRun::data16):
(WebCore::TextRun::characters8):
(WebCore::TextRun::characters16):
(WebCore::TextRun::is8Bit):
(WebCore::TextRun::setText):
(WebCore::TextRun::setCharactersLength):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advance):

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzShaper):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::collectComplexTextRuns):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/pango/FontPango.cpp:

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::advance):
(WebCore::UniscribeController::shapeAndPlaceItem):

  • rendering/RenderText.cpp:

(WebCore::RenderText::computeCanUseSimpleFontCodePath):

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::SVGTextMetrics):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

4:50 PM Changeset in webkit [127800] by jamesr@google.com
  • 5 edits in trunk/Source

[chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
https://bugs.webkit.org/show_bug.cgi?id=96024

Reviewed by Adam Barth.

When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
We don't need to link anything in to WebKit.dll.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
4:41 PM Changeset in webkit [127799] by msaboff@apple.com
  • 3 edits in trunk/Source/WTF

ENH: Add Logging to StringImpl to track String Types
https://bugs.webkit.org/show_bug.cgi?id=95807

Reviewed by Benjamin Poulain.

Added StringsStats class that keeps track of the number of strings, number of 8 and 16 bit
strings as well as the number of 8 bit strings up converted to 16 bits. The number of characrters
for each type is also accumulated. These statistics are output via DataLog every 5000
calls to StringImpl destructor. The 5000 can be adjusted via s_printStringStatsFrequency.
This StringStats code is disabled by default and enabled by defining STRING_STATS in
wtf/text/StringImpl.h.

  • wtf/text/StringImpl.cpp:

(WTF::StringStats::removeString):
(WTF::StringStats::printStats):
(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::getData16SlowCase):

  • wtf/text/StringImpl.h:

(WTF::StringStats::add8BitString):
(StringStats):
(WTF::StringStats::add16BitString):
(WTF::StringStats::addUpconvertedString):
(WTF::StringImpl::StringImpl):
(StringImpl):
(WTF::StringImpl::isSubString):
(WTF::StringImpl::stringStats):

4:40 PM Changeset in webkit [127798] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

New tests introduced in r127704 fail
https://bugs.webkit.org/show_bug.cgi?id=95952

Reviewed by Dan Bernstein.

Use the testRunner rather than layoutTestController because
layoutTestControler doesn't exist anymore.

  • fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html:
  • fast/viewport/viewport-limits-adjusted-for-no-user-scale.html:
4:23 PM Changeset in webkit [127797] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

JS test suite puts incorrect limitations on Function.toString()
https://bugs.webkit.org/show_bug.cgi?id=3975

Reviewed by Geoff Garen.

The result of function toString is implementation defined;
these test cases were looking for specific whitespace formatting
that matches mozilla's, and for redundant braces to be inserted
around if/else blocks. Stop that.

  • tests/mozilla/expected.html:
  • tests/mozilla/js1_2/function/tostring-1.js:

(simplify):

  • reduce whitespace differences
  • tests/mozilla/js1_2/function/tostring-2.js:

(simplify):

  • reduce whitespace differences

(TestOr):
(TestAnd):

  • added braces to match expected output
4:21 PM Changeset in webkit [127796] by jamesr@google.com
  • 2 edits in trunk/Source/Platform

[chromium] Export public functions on WebTransformationMatrix so they can be used outside of WebKit.dll
https://bugs.webkit.org/show_bug.cgi?id=96025

Reviewed by Adrienne Walker.

  • chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

4:21 PM Changeset in webkit [127795] by Simon Fraser
  • 9 edits
    2 adds in trunk/Source/WebCore

Parcel up logic related to sticky positioning into a Constraints class that will later be used for threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=96026

Reviewed by James Robinson.

Lay some groundwork for threaded scrolling with fixed position and sticky
position objects, by packaging up logic related to how to reposition
fixed and sticky things on viewport changes into "constraints" classes.

ScrollingConstraints contains a 'ViewportConstraints' base class
that is subclassed for sticky position. These classes store
data about the constraints that govern the position of an object outside
of the render tree, and know how to compute a new position when the
viewport changes using only data in the class.

This patch changes RenderBoxModelObject to use the StickyPositionViewportConstraints
class for computing stick offsets at layout time. In the future, we'll have
the scrolling tree store copies of the constraint data for threaded scrolling.

  • CMakeLists.txt: Add ScrollingConstraints.* to the build.
  • GNUmakefile.list.am: Ditto
  • Target.pri: Ditto
  • WebCore.gypi: Ditto
  • WebCore.vcproj/WebCore.vcproj: Ditto
  • WebCore.xcodeproj/project.pbxproj: Ditto
  • page/scrolling/ScrollingConstraints.cpp: Added.

(WebCore::StickyPositionViewportConstraints::computeStickyOffset):
(WebCore::StickyPositionViewportConstraints::layerPositionForViewportRect):

  • page/scrolling/ScrollingConstraints.h: Added.

(WebCore::ViewportConstraints::ViewportConstraints):
(WebCore::ViewportConstraints::~ViewportConstraints):
(WebCore::ViewportConstraints::anchorEdges):
(WebCore::ViewportConstraints::hasAnchorEdge):
(WebCore::ViewportConstraints::addAnchorEdge):
(WebCore::ViewportConstraints::alignmentOffset):
(WebCore::ViewportConstraints::setAlignmentOffset):
(StickyPositionViewportConstraints):
(WebCore::StickyPositionViewportConstraints::StickyPositionViewportConstraints):
(WebCore::StickyPositionViewportConstraints::stickyOffsetAtLastLayout):
(WebCore::StickyPositionViewportConstraints::setStickyOffsetAtLastLayout):
(WebCore::StickyPositionViewportConstraints::layerPositionAtLastLayout):
(WebCore::StickyPositionViewportConstraints::setLayerPositionAtLastLayout):
(WebCore::StickyPositionViewportConstraints::leftOffset):
(WebCore::StickyPositionViewportConstraints::rightOffset):
(WebCore::StickyPositionViewportConstraints::topOffset):
(WebCore::StickyPositionViewportConstraints::bottomOffset):
(WebCore::StickyPositionViewportConstraints::setLeftOffset):
(WebCore::StickyPositionViewportConstraints::setRightOffset):
(WebCore::StickyPositionViewportConstraints::setTopOffset):
(WebCore::StickyPositionViewportConstraints::setBottomOffset):
(WebCore::StickyPositionViewportConstraints::setAbsoluteContainingBlockRect):
(WebCore::StickyPositionViewportConstraints::setAbsoluteStickyBoxRect):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computeStickyPositionConstraints): Fill out
data in the supplied StickyPositionViewportConstraints instance.
(WebCore::RenderBoxModelObject::stickyPositionOffset): Create a
StickyPositionViewportConstraints object on the stack and use it to
compute the sticky offset.

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

4:17 PM Changeset in webkit [127794] by jamesr@google.com
  • 26 edits
    1 add in trunk

[chromium] Use WebCompositorSupport functions instead of WebCompositor statics
https://bugs.webkit.org/show_bug.cgi?id=96007

Reviewed by Adrienne Walker.

Source/Platform:

Updates comment to reference WebCompositorSupport instead of WebCompositor.

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

Source/WebCore:

Calls WebCompositorSupport functions instead of WebCompositor statics.

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

Source/WebKit/chromium:

Updates many tests to initialize / shutdown compositing with WebCompositorSupport. Adds a
WebCompositorInitializer RAII class to simplify this somewhat tedious process.

  • WebKit.gypi:
  • public/WebCompositorInputHandlerClient.h:

(WebCompositorInputHandlerClient):

  • src/WebCompositorInputHandlerImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::scheduleComposite):

  • tests/CCPrioritizedTextureTest.cpp:

(WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
(CCPrioritizedTextureTest):

  • tests/CCRendererGLTest.cpp:

(CCRendererGLTest::CCRendererGLTest):
(CCRendererGLTest::SetUp):
(CCRendererGLTest):

  • tests/CCTextureUpdateControllerTest.cpp:
  • tests/CCThreadedTest.cpp:

(WebKitTests::CCThreadedTest::runTest):

  • tests/Canvas2DLayerBridgeTest.cpp:

(Canvas2DLayerBridgeTest::fullLifecycleTest):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):

  • tests/LayerChromiumTest.cpp:
  • tests/LinkHighlightTest.cpp:

(WebCore::TEST):

  • tests/TextureLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
  • tests/WebCompositorInitializer.h: Added.

(WebKit):
(WebKitTests):
(WebCompositorInitializer):
(WebKitTests::WebCompositorInitializer::WebCompositorInitializer):
(WebKitTests::WebCompositorInitializer::~WebCompositorInitializer):

  • tests/WebCompositorInputHandlerImplTest.cpp:

(WebKit::TEST):
(WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
(WebCompositorInputHandlerImplTest):

  • tests/WebLayerTest.cpp:
  • tests/WebLayerTreeViewTest.cpp:

Tools:

Fixes initialization / settings code to use WebCompositorSupport.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::setPerTilePaintingEnabled):

4:17 PM Changeset in webkit [127793] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
https://bugs.webkit.org/show_bug.cgi?id=95995

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Provide proper implementation for PlatformWebView::windowFrame()
in EFL's WebKitTestRunner.

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::windowFrame):

4:16 PM Changeset in webkit [127792] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

  • DEPS:
4:14 PM Changeset in webkit [127791] by commit-queue@webkit.org
  • 4 edits in trunk/Source

IndexedDB: make IDBKeyPath's string and array constructors explicit
https://bugs.webkit.org/show_bug.cgi?id=96004

Patch by Alec Flett <alecflett@chromium.org> on 2012-09-06
Reviewed by Tony Chang.

Source/WebCore:

Making these explicit to avoid accidental implicit conversions.

No new tests, existing tests cover correctness.

  • Modules/indexeddb/IDBKeyPath.h:

(IDBKeyPath):

Source/WebKit/chromium:

Fix test to use explicit constructor for IDBKeyPath.

  • tests/IDBDatabaseBackendTest.cpp:
3:48 PM Changeset in webkit [127790] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove GraphicsContext references from ContentLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=96002

Reviewed by James Robinson.

This is a compositor unit test, so it shouldn't reference things
outside of the compositor like GraphicsContext. The
OpaqueRectTrackingContentLayerDelegateTest already tests opaque
tracking right at the time of paint. This test is about verifying that
transformed canvases work properly, so can just fake the opaque rect
coming back from the paint.

  • tests/ContentLayerChromiumTest.cpp:

(WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
(WebKit::TEST):

3:23 PM Changeset in webkit [127789] by commit-queue@webkit.org
  • 17 edits in trunk/Source

[Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
https://bugs.webkit.org/show_bug.cgi?id=95094

Patch by Jeff Timanus <twiz@chromium.org> on 2012-09-06
Reviewed by Adrienne Walker.

Source/Platform:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of
contentsScale behaviour.

  • chromium/public/WebContentLayer.h:

(WebContentLayer):

Export setBoundsContainPageScale() family of routines.

Source/WebCore:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of
contentsScale behaviour.

Testing covered by existing compositor layout and unit tests.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setAppliesPageScale):
(WebCore::GraphicsLayer::appliesPageScale):

These routines are now virtual, so that they can push the notification to setDisregardsContentsScale in
LayerChromium.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore):
(WebCore::GraphicsLayerChromium::setAppliesPageScale):
(WebCore::GraphicsLayerChromium::appliesPageScale):

Now forwards the appliesPageScaleStatus to the owned layer.

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setContentsScale):
(WebCore):
(WebCore::LayerChromium::setBoundsContainPageScale):

setAppliesPageScale is renamed to setBoundsContainPageScale in LayerChromium.

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::boundsContainPageScale):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore):
(WebCore::setScale):
(WebCore::updateLayerScale):
(WebCore::CCLayerTreeHost::updateLayers):

The contents scale of a layer is now applied in this routine.

Source/WebKit/chromium:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of
contentsScale behaviour.
This change exports the disregardsPageScale() set of functions from WebContentLayer to LayerChromium.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

Inform the layer associated with the NCCH that it is to disregard the page scale factor.
Also remove now unused m_deviceScaleFactor and associated routines.

(WebKit::NonCompositedContentHost::setViewport):

  • src/NonCompositedContentHost.h:

(NonCompositedContentHost):

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::setBoundsContainPageScale):
(WebKit):
(WebKit::WebContentLayerImpl::boundsContainPageScale):

  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateLayerTreeViewport):

  • tests/CCLayerTreeHostTest.cpp:

(NoScaleContentLayerChromium):
(WebKitTests::NoScaleContentLayerChromium::create):
(WebKitTests::NoScaleContentLayerChromium::NoScaleContentLayerChromium):
(WebKitTests):
(WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):

Rebaselined to correspond to the new behaviour. Because the layers are now assigned a contentsScale, the
scale on the draw transforms remain identity.

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit): Remove now obsolete unit-test.

3:07 PM Changeset in webkit [127788] by alokp@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Remove failures for acceletared-drawing tests.

Unreviewed.

Update chromium TestExpectations to remove failures for accelerated-painting.
They were fixed in r127294.

  • platform/chromium/TestExpectations:
2:44 PM Changeset in webkit [127787] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Split platform geometry types into separate static target
https://bugs.webkit.org/show_bug.cgi?id=96021

Reviewed by Tony Chang.

This moves several WebCore/platform geometry classes out of webcore_platform into a separate static library.
This library is relatively standalone and useful to statically link against in other contexts.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
2:41 PM Changeset in webkit [127786] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Fuzzy load the Edje theme for HTML forms
https://bugs.webkit.org/show_bug.cgi?id=95832

Reviewed by Antonio Gomes.

Change the theme so that it is first loaded when actually used.
This also fixed the case that it was impossible to change theme
a second time.

Tested by current tests. API unit test coming in separate patch.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore):

Add some convenience macros.

(WebCore::applyColorCallback):

Use just one callback from the edje theme, which just calls
setColorFromThemeClass.

(WebCore::fillColorsFromEdjeClass):

Add convenience method for receiving colors from Edje and
storing them in Color's.

(WebCore::RenderThemeEfl::setColorFromThemeClass):

Set the class Color variabled with the values from the theme
color class.

(WebCore::RenderThemeEfl::setThemePath):

Don't apply the theme immediately.

(WebCore::RenderThemeEfl::loadTheme):

Load the new theme and free the current one. If it fails,
it will continue using the old one, if exists.

(WebCore::RenderThemeEfl::adjustSizeConstraints):
(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
(WebCore::RenderThemeEfl::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeEfl::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeEfl::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeEfl::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeEfl::platformFocusRingColor):

Ensure the theme is loaded.

(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):

Ensure the theme is loaded.

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):
(WebCore::RenderThemeEfl::loadThemeIfNeeded):

Remove unneeded methods and add a method for loading a theme
in the case it is not loaded yet.

2:24 PM Changeset in webkit [127785] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Classify several test cases in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=95947

Unreviewed EFL gardening.

Update TestExpectations to classify a few test case failures
as being caused by lack on undo/redo stack implementation
in EFL WK2.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06

  • platform/efl-wk2/TestExpectations:
2:23 PM Changeset in webkit [127784] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=95994

Reviewed by James Robinson.

This compositor test shouldn't depend on code outside the compositor.

  • tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::FakeWebScrollbar::create):
(FakeWebScrollbar):
(WebCore::TEST):

2:04 PM Changeset in webkit [127783] by Simon Fraser
  • 7 edits in trunk/Source/WebCore

Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
https://bugs.webkit.org/show_bug.cgi?id=96017

Reviewed by James Robinson.

FrameView already has a HashSet of RenderObjects whose position
is affected by the viewport rect; this contains fixed and sticky-postion
objects. RenderView::setFixedPositionedObjectsNeedLayout() was using
the RenderView's list of postioned objects, but this omitted sticky-position
objects whose container was not the RenderView. So it's simpler to use
FrameView's set of fixed/sticky objects.

Changed the terminology from "fixed" to "viewport-constrained" for this set
of objects.

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::setFixedVisibleContentRect):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::updateFixedElementsAfterScrolling):

  • page/FrameView.h:

(WebCore::FrameView::viewportConstrainedObjects):
(WebCore::FrameView::hasViewportConstrainedObjects):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::styleDidChange):

  • rendering/RenderView.cpp:
  • rendering/RenderView.h:
2:00 PM Changeset in webkit [127782] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

Add data-blackberry-webworks-context attribute and set the custom context when
getting context.
https://bugs.webkit.org/show_bug.cgi?id=95993

Patch by Genevieve Mak <gmak@rim.com> on 2012-09-06
Reviewed by Antonio Gomes.

PR #193726
Reviewed Internally by Mike Fenton.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

  • Check for custom WebWorks context and add it if there.
  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::webWorksContext):
(DOMSupport):

  • WebKitSupport/DOMSupport.h:
    • Add a method that checks a given element for the data-webworks-context attribute and returns its value if present.
1:55 PM Changeset in webkit [127781] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Put chromium implementations of WTF symbols in separate static library
https://bugs.webkit.org/show_bug.cgi?id=95933

Reviewed by Adam Barth.

A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
component build is a DLL. This moves these files into a static library that webkit depends on so targets can
statically link in wtf and these support files without depending directly on webkit.

  • WebKit.gyp:
1:19 PM Changeset in webkit [127780] by commit-queue@webkit.org
  • 12 edits in trunk

Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-06
Reviewed by Alexander Pavlov.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::reset):
(WebCore):
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::scheduleFor):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::regionLayoutUpdated):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):

  • inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
1:06 PM Changeset in webkit [127779] by annacc@chromium.org
  • 3 edits
    2 adds in trunk

ASSERT reached when TextTrack.mode is set to DISABLED.
https://bugs.webkit.org/show_bug.cgi?id=94651

Reviewed by Eric Carlson.

This patch ensures that cues that have already been added to the
cueTree in HTMLMediaElement, are not added again.

Source/WebCore:

Test: media/track/track-mode-disabled-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackAddCue): Do not add the cue if it already
exists in m_cueTree.

LayoutTests:

  • media/track/track-mode-disabled-crash-expected.txt: Added.
  • media/track/track-mode-disabled-crash.html: Added.
12:54 PM Changeset in webkit [127778] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Performance regressions on 32-bit platforms with revisions 125637 and 126387
https://bugs.webkit.org/show_bug.cgi?id=95953

Reviewed by Filip Pizlo.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val): Fix the typo.

12:53 PM Changeset in webkit [127777] by ggaren@apple.com
  • 3 edits in trunk/LayoutTests

Unskipped fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html
because I rolled out the patch that broke it.

  • platform/qt/Skipped:
  • platform/win/Skipped:
12:52 PM Changeset in webkit [127776] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret
https://bugs.webkit.org/show_bug.cgi?id=93998

Patch by Iain Merrick <husky@chromium.org> on 2012-09-06
Reviewed by Adam Barth.

These provide the same functionality selectRange(WebPoint, WebPoint),
with finer-grained control needed on the Android platform. By passing
allowCollapsedSelection=false, we can ensure the selection stays at
least one character wide.

I have reimplemented WebFrameImpl::selectRange(WebPoint, WebPoint) by
calling the new methods. The existing test passes, and I've added new
tests for the new methods.

  • public/WebFrame.h:

(WebFrame):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectRange):
(WebKit):
(WebKit::WebFrameImpl::moveSelectionStart):
(WebKit::WebFrameImpl::moveSelectionEnd):
(WebKit::WebFrameImpl::moveCaret):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • tests/WebFrameTest.cpp:
  • tests/data/text_selection.html: Added.
12:50 PM Changeset in webkit [127775] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Fix WTF.Lrint on 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=96003

Patch by Fady Samuel <fsamuel@chromium.org> on 2012-09-06
Reviewed by Benjamin Poulain.

Fixed failing WTF.Lrint test on 32-bit platforms.

  • TestWebKitAPI/Tests/WTF/MathExtras.cpp:

(TestWebKitAPI::TEST):

12:45 PM Changeset in webkit [127774] by ggaren@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Rolled out <http://trac.webkit.org/changeset/127698> because it broke
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html

Named functions should not allocate scope objects for their names
https://bugs.webkit.org/show_bug.cgi?id=95659

Reviewed by Oliver Hunt.

12:29 PM Changeset in webkit [127773] by commit-queue@webkit.org
  • 33 edits
    23 deletes in trunk/LayoutTests

[chromium] Need to rebaseline chromium tests after hidpi changes
https://bugs.webkit.org/show_bug.cgi?id=95579

Patch by Alex Sakhartchouk <alexst@chromium.org> on 2012-09-06
Reviewed by James Robinson.

Adding double resolution files for hidpi tests and updating expectations for broken image tests.

  • platform/chromium-linux/fast/hidpi/broken-image-icon-hidpi-expected.png: Removed.
  • platform/chromium-linux/fast/hidpi/broken-image-with-size-hidpi-expected.png: Removed.
  • platform/chromium-linux/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
  • platform/chromium-linux/fast/hidpi/focus-rings-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/broken-image-icon-hidpi-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/broken-image-with-size-hidpi-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/clip-text-in-hidpi-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/focus-rings-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-as-background-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-dynamic-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-without-size-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-comparison-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-dynamic-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-simple-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-in-content-dynamic-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-out-of-order-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-simple-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-without-specified-width-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/resize-corner-hidpi-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.png: Removed.
  • platform/chromium-mac/fast/hidpi/clip-text-in-hidpi-expected.png:
  • platform/chromium-mac/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
  • platform/chromium-mac/fast/hidpi/focus-rings-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-as-background-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-background-dynamic-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-without-size-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-border-image-comparison-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-border-image-dynamic-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-border-image-simple-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-in-content-dynamic-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-out-of-order-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-simple-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-without-specified-width-expected.png:
  • platform/chromium-mac/fast/hidpi/resize-corner-hidpi-expected.png:
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-win/fast/hidpi/clip-text-in-hidpi-expected.png:
  • platform/chromium-win/fast/hidpi/device-scale-factor-paint-expected.png:
  • platform/chromium-win/fast/hidpi/focus-rings-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-as-background-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-background-dynamic-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-without-size-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-border-image-comparison-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-border-image-dynamic-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-border-image-simple-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-in-content-dynamic-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-out-of-order-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-simple-expected.png:
  • platform/chromium-win/fast/hidpi/image-set-without-specified-width-expected.png:
  • platform/chromium-win/fast/hidpi/resize-corner-hidpi-expected.png:
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium/TestExpectations:
12:22 PM Changeset in webkit [127772] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Allow overscroll to composited scroll layers
https://bugs.webkit.org/show_bug.cgi?id=95998
PR #195305

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Gen Mak.

No need to reset the overscroll limit factor at creation to 0.
It is already 0 by default, and later on the client sets the
appropriated value.

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

12:20 PM Changeset in webkit [127771] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Another unreviewed GTK build fix.

The ENABLE_DATALIST_ELEMENT should default to 0, as it did in stable
release versions before r127760. The feature define can be switched
on later, when its stability is determined and the test results are
rebaselined.

  • GNUmakefile.features.am:
12:16 PM Changeset in webkit [127770] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping failing test: fast/forms/number/number-interactive-validation-required.html
Interactive form validation is not enabled on Windows. It's fine to skip this test.

  • platform/win/Skipped:
12:04 PM Changeset in webkit [127769] by Dave Barton
  • 9 edits in trunk

mathml.css: Add more { white-space: nowrap } declarations
https://bugs.webkit.org/show_bug.cgi?id=95404

Reviewed by Eric Seidel.

mathml.css declared { white-space: nowrap } for mrow, mfenced, msqrt. It is also needed
for other tags such as msub, msup, msubsup.

Added a test to mathml/presentation/sup.xhtml, and a regression test to roots.xhtml.

Source/WebCore:

  • css/mathml.css:

(mo, mrow, mfenced, mfrac, msub, msup, msubsup, munder, mover, munderover, msqrt, mroot):

LayoutTests:

  • mathml/presentation/roots.xhtml:
  • mathml/presentation/sup.xhtml:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.png:
  • platform/mac/mathml/presentation/sup-expected.txt:
12:02 PM Changeset in webkit [127768] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Skip failing test: fast/dom/HTMLScriptElement/script-reexecution.html
https://bugs.webkit.org/show_bug.cgi?id=95944

  • platform/win/Skipped:
11:54 AM Changeset in webkit [127767] by rjkroege@chromium.org
  • 8 edits in trunk/Source

[chromium] Enable different fling behaviour for touchscreen and touchpad
https://bugs.webkit.org/show_bug.cgi?id=95756

Reviewed by James Robinson.

Add support for a flag on WebGestureEvents that differentiates GestureFlingStart
events by their originating device and pass this flag to a factory that produces
different device specific fling curves based on the value of the flag.

Source/WebCore:

Covered by existing layout and unit tests.

  • platform/chromium/support/PlatformGestureCurveFactory.cpp: Modified factory

entry point for constructing fling curve for different devices.
(WebKit::PlatformGestureCurveFactory::createCurve):

  • platform/chromium/support/PlatformGestureCurveFactory.h:

(PlatformGestureCurveFactory):

Source/WebKit/chromium:

  • public/WebActiveWheelFlingParameters.h:

(WebActiveWheelFlingParameters): Store source device for transfer to mainthread.
(WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters):

  • public/WebInputEvent.h: Added source device flag to WebGestureEvent.
  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling): Use factory to
obtain device-appropriate fling curve.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent): Use factory to obtain device-appropriate
fling curve.
(WebKit::WebViewImpl::transferActiveWheelFlingAnimation):

11:50 AM Changeset in webkit [127766] by tommyw@google.com
  • 25 edits
    7 copies
    2 adds in trunk

MediaStream API: Add the local and remote description functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95839

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCVoidRequest.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.

(WebCore):
(WebKit):
(WebRTCVoidRequest):
(ExtraData):
(WebKit::WebRTCVoidRequest::ExtraData::~ExtraData):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::~WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::operator=):
(WebKit::WebRTCVoidRequest::isNull):

Source/WebCore:

As well as adding the local/remote descriptions stuff, I removed the source attribute from
RTCSessionDescriptionCallback and RTCErrorCallback since it has been removed from the draft.

Tests: fast/mediastream/RTCPeerConnection-localDescription.html

fast/mediastream/RTCPeerConnection-remoteDescription.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCErrorCallback.h:

(RTCErrorCallback):

  • Modules/mediastream/RTCErrorCallback.idl:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):

  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCSessionDescriptionCallback.h:

(RTCSessionDescriptionCallback):

  • Modules/mediastream/RTCSessionDescriptionCallback.idl:
  • Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:

(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::clear):

  • Modules/mediastream/RTCSessionDescriptionRequestImpl.h:

(RTCSessionDescriptionRequestImpl):

  • Modules/mediastream/RTCVoidRequestImpl.cpp: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp.

(WebCore):
(WebCore::RTCVoidRequestImpl::create):
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::~RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::requestSucceeded):
(WebCore::RTCVoidRequestImpl::requestFailed):
(WebCore::RTCVoidRequestImpl::stop):
(WebCore::RTCVoidRequestImpl::clear):

  • Modules/mediastream/RTCVoidRequestImpl.h: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.h.

(WebCore):
(RTCVoidRequestImpl):

  • WebCore.gypi:
  • platform/chromium/support/WebRTCVoidRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.

(WebKit):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::assign):
(WebKit::WebRTCVoidRequest::reset):
(WebKit::WebRTCVoidRequest::requestSucceeded):
(WebKit::WebRTCVoidRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCVoidRequest::extraData):
(WebKit::WebRTCVoidRequest::setExtraData):

  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerDummy::localDescription):
(WebCore::RTCPeerConnectionHandlerDummy::remoteDescription):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCVoidRequest.h: Copied from Source/WebCore/Modules/mediastream/RTCErrorCallback.h.

(WebCore):
(RTCVoidRequest):
(ExtraData):
(WebCore::RTCVoidRequest::ExtraData::~ExtraData):
(WebCore::RTCVoidRequest::~RTCVoidRequest):
(WebCore::RTCVoidRequest::extraData):
(WebCore::RTCVoidRequest::setExtraData):
(WebCore::RTCVoidRequest::RTCVoidRequest):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerChromium::localDescription):
(WebCore::RTCPeerConnectionHandlerChromium::remoteDescription):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
up the task definitions a bit. There was no need to have them in the header file.

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCVoidRequestTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(MockWebRTCPeerConnectionHandler::createOffer):
(MockWebRTCPeerConnectionHandler::setLocalDescription):
(MockWebRTCPeerConnectionHandler::setRemoteDescription):
(MockWebRTCPeerConnectionHandler::localDescription):
(MockWebRTCPeerConnectionHandler::remoteDescription):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-localDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
  • fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-remoteDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
11:43 AM Changeset in webkit [127765] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix one of the Qt builds.

  • dom/TransformSource.h:
11:40 AM Changeset in webkit [127764] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix.

CSS Compositing is not currently supported on the GTK port, so
the feature define should default to 0.

  • GNUmakefile.features.am:
11:16 AM Changeset in webkit [127763] by zandobersek@gmail.com
  • 2 edits
    21 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Generating required platform-specific baselines after r127608.

Adding failure expectations for regressions introduced in r127698 and r127704.

Fixing and removing duplicate expectations to get the file to pass linting.

  • platform/gtk/TestExpectations:
  • platform/gtk/css3/masking: Added.
  • platform/gtk/css3/masking/clip-path-circle-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-circle-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-circle-filter-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-circle-filter-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-circle-overflow-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-circle-overflow-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-ellipse-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-ellipse-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-polygon-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-polygon-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.txt: Added.
  • platform/gtk/css3/masking/clip-path-rectangle-expected.png: Added.
  • platform/gtk/css3/masking/clip-path-rectangle-expected.txt: Added.
11:13 AM Changeset in webkit [127762] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

SharedGraphicsContext3D shouldn't depend on CCProxy
https://bugs.webkit.org/show_bug.cgi?id=95921

Reviewed by Adrienne Walker.

This class just wants to ASSERT() that we're on or not on the main thread. There's perfectly fine cross-platform
code in WTF to do that.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::getForImplThread):
(WebCore::SharedGraphicsContext3D::haveForImplThread):
(WebCore::SharedGraphicsContext3D::createForImplThread):

11:06 AM Changeset in webkit [127761] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Fix export macros in IntegerToStringConversion.h
https://bugs.webkit.org/show_bug.cgi?id=95900

Reviewed by Benjamin Poulain.

The WTF_EXPORT_STRING_API must be used only for symbols which are compiled
on windows in "non-WTF" binaries too. Since this isn't valid for the
IntegerToStringConversion function replace it with WTF_EXPORT_PRIVATE.

  • wtf/text/IntegerToStringConversion.h:
10:58 AM Changeset in webkit [127760] by zandobersek@gmail.com
  • 5 edits in trunk

[Gtk] Remove configuration options for features that are not supported by the Gtk port
https://bugs.webkit.org/show_bug.cgi?id=87664

Reviewed by Martin Robinson.

.:

Remove configuration options for features that are completely unsupported by the GTK port.
They only bloat the configure.ac file. They should be re-added when the feature becomes
supported and introduces an external dependency that the users might want to avoid.

  • configure.ac:

Source/WebCore:

Remove addition of macros to feature_defines for features that are completely
unsupported by the Gtk port. They're not required anymore since the accompanying
configuration flags are also being removed.

No new tests - no new functionality.

  • GNUmakefile.am:
  • bindings/gobject/GNUmakefile.am:
10:52 AM Changeset in webkit [127759] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit2

Merge r127750 - [GTK] [WK2] Crash when navigating between pages
https://bugs.webkit.org/show_bug.cgi?id=95949

Reviewed by Martin Robinson.

Do not trust isMainResource parameter in
webkitWebViewResourceLoadStarted(), because it's always true for
all subresources of pages loaded from the history cache. We can
simply assume that the first resource loaded for the main frame
is the main web view resource.

  • UIProcess/API/gtk/WebKitResourceLoadClient.cpp:

(didInitiateLoadForResource):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewResourceLoadStarted):

  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
10:52 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
10:44 AM Changeset in webkit [127758] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Shaders] Vertex attributes should be unbound after a custom filter is applied
https://bugs.webkit.org/show_bug.cgi?id=95891

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-06
Reviewed by Dean Jackson.

Now we unbind the vertex attributes after a custom filter is applied.

Before this patch, Chromium's GPU process would sometimes print the following error message:
"ERROR:gles2_cmd_decoder.cc(5142)] 002CA47B: GL ERROR :GL_INVALID_OPERATION :
glDrawElements: attempt to render with no buffer attached to enabled attribute 2"

This would happen in the following situation:
1) There are two FECustomFilters on the page.
2) One FECustomFilter has a detached mesh. One FECustomFilter has an attached mesh. The

detached FECustomFilter has one more vertex attribute (a_triangleCoord) than the attached
FECustomFilter.

3) The detached FECustomFilter is destroyed, but a_triangleCoord remains bound.
4) The attached FECustomFilter tries to render, but Chromium notices that there is no buffer

attached to the a_triangleCoord attribute.

No new tests. We can't create an automated test for this because it only reproduces using
Chromium's GPU process. DRT does not use Chromium's GPU process.

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::applyShader):

Unbind the vertex attributes after the drawElements call.

(WebCore::FECustomFilter::unbindVertexAttribute):
(WebCore):
(WebCore::FECustomFilter::unbindVertexAttributes):

Unbind all of the attributes that we bound earlier.

  • platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

10:36 AM Changeset in webkit [127757] by weinig@apple.com
  • 556 edits
    1 delete in trunk/Source

Part 2 of removing PlatformString.h, remove PlatformString.h
https://bugs.webkit.org/show_bug.cgi?id=95931

Reviewed by Adam Barth.

Remove PlatformString.h

Source/WebCore:

  • GNUmakefile.list.am:
  • Modules/filesystem/AsyncFileWriter.h:
  • Modules/filesystem/DOMFilePath.h:
  • Modules/filesystem/DOMFileSystemBase.h:
  • Modules/filesystem/DirectoryEntry.h:
  • Modules/filesystem/DirectoryEntrySync.h:
  • Modules/filesystem/DirectoryReader.h:
  • Modules/filesystem/DirectoryReaderBase.h:
  • Modules/filesystem/DirectoryReaderSync.h:
  • Modules/filesystem/EntryBase.cpp:
  • Modules/filesystem/EntrySync.h:
  • Modules/filesystem/FileEntrySync.h:
  • Modules/filesystem/FileSystemCallbacks.h:
  • Modules/filesystem/LocalFileSystem.h:
  • Modules/geolocation/GeolocationError.h:
  • Modules/geolocation/Geoposition.h:
  • Modules/geolocation/PositionError.h:
  • Modules/indexeddb/IDBAny.h:
  • Modules/indexeddb/IDBDatabaseBackendInterface.h:
  • Modules/indexeddb/IDBDatabaseCallbacks.h:
  • Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
  • Modules/indexeddb/IDBDatabaseError.h:
  • Modules/indexeddb/IDBFactory.h:
  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/IDBIndex.h:
  • Modules/indexeddb/IDBIndexBackendInterface.h:
  • Modules/indexeddb/IDBKey.h:
  • Modules/indexeddb/IDBKeyPath.h:
  • Modules/indexeddb/IDBMetadata.h:
  • Modules/indexeddb/IDBObjectStore.h:
  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • Modules/indexeddb/IDBUpgradeNeededEvent.h:
  • Modules/indexeddb/IDBVersionChangeEvent.h:
  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/networkinfo/NetworkInfoConnection.h:
  • Modules/notifications/DOMWindowNotifications.h:
  • Modules/speech/SpeechGrammar.h:
  • Modules/speech/SpeechRecognition.h:
  • Modules/speech/SpeechRecognitionAlternative.h:
  • Modules/speech/SpeechRecognitionClient.h:
  • Modules/speech/SpeechRecognitionError.h:
  • Modules/webaudio/AudioContext.cpp:
  • Modules/webaudio/AudioParam.h:
  • Modules/webdatabase/AbstractDatabase.h:
  • Modules/webdatabase/ChangeVersionWrapper.h:
  • Modules/webdatabase/DOMWindowWebDatabase.h:
  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseAuthorizer.cpp:
  • Modules/webdatabase/DatabaseAuthorizer.h:
  • Modules/webdatabase/DatabaseDetails.h:
  • Modules/webdatabase/DatabaseSync.h:
  • Modules/webdatabase/DatabaseTask.h:
  • Modules/webdatabase/DatabaseTracker.h:
  • Modules/webdatabase/OriginUsageRecord.h:
  • Modules/webdatabase/SQLError.h:
  • Modules/webdatabase/SQLStatement.h:
  • Modules/webdatabase/SQLStatementSync.h:
  • Modules/webdatabase/SQLTransaction.cpp:
  • Modules/webdatabase/SQLTransactionSync.cpp:
  • Modules/webdatabase/SQLTransactionSync.h:
  • Modules/webdatabase/WorkerContextWebDatabase.h:
  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
  • Modules/webdatabase/chromium/QuotaTracker.h:
  • Modules/websockets/ThreadableWebSocketChannel.cpp:
  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
  • Modules/websockets/WebSocketHandshake.h:
  • Modules/websockets/WebSocketHandshakeResponse.h:
  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
  • Modules/websockets/WorkerThreadableWebSocketChannel.h:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/ConvertToUTF8String.cpp:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:
  • bindings/js/JSClipboardCustom.cpp:
  • bindings/js/JSImageDataCustom.cpp:
  • bindings/js/JSInspectorFrontendHostCustom.cpp:
  • bindings/js/JSLazyEventListener.h:
  • bindings/js/JSStorageCustom.cpp:
  • bindings/js/JSXSLTProcessorCustom.cpp:
  • bindings/js/JavaScriptCallFrame.cpp:
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptHeapSnapshot.h:
  • bindings/js/ScriptValue.h:
  • bindings/js/SerializedScriptValue.h:
  • bindings/objc/DOMCustomXPathNSResolver.mm:
  • bindings/objc/DOMXPath.mm:
  • bindings/objc/WebScriptObject.mm:
  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForTypeInImpl):
(AddIncludesForSVGAnimatedType):

  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

  • bindings/v8/Dictionary.h:
  • bindings/v8/JavaScriptCallFrame.h:
  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/ScriptFunctionCall.h:
  • bindings/v8/ScriptHeapSnapshot.h:
  • bindings/v8/ScriptProfile.h:
  • bindings/v8/ScriptProfileNode.h:
  • bindings/v8/ScriptProfiler.h:
  • bindings/v8/ScriptSourceCode.h:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8LazyEventListener.h:
  • bindings/v8/V8NPUtils.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bridge/IdentifierRep.cpp:
  • bridge/NP_jsobject.cpp:
  • bridge/c/c_utility.cpp:
  • css/CSSBasicShapes.h:
  • css/CSSBorderImageSliceValue.cpp:
  • css/CSSCharsetRule.h:
  • css/CSSCursorImageValue.cpp:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSGradientValue.cpp:
  • css/CSSInheritedValue.cpp:
  • css/CSSInitialValue.cpp:
  • css/CSSLineBoxContainValue.cpp:
  • css/CSSMediaRule.h:
  • css/CSSProperty.cpp:
  • css/CSSPropertySourceData.cpp:
  • css/CSSPropertySourceData.h:
  • css/CSSReflectValue.cpp:
  • css/CSSTimingFunctionValue.cpp:
  • css/CSSUnicodeRangeValue.cpp:
  • css/CSSValueList.cpp:
  • css/Counter.h:
  • css/FontFeatureValue.h:
  • css/FontValue.cpp:
  • css/MediaQuery.h:
  • css/MediaQueryEvaluator.h:
  • css/MediaQueryListListener.h:
  • css/ShadowValue.cpp:
  • css/StyleMedia.h:
  • css/StyleSheet.h:
  • css/StyleSheetList.cpp:
  • css/WebKitCSSMatrix.h:
  • css/WebKitCSSTransformValue.cpp:
  • dom/DOMStringList.h:
  • dom/DOMStringMap.h:
  • dom/DocumentMarker.h:
  • dom/ErrorEvent.h:
  • dom/ExceptionBase.h:
  • dom/MessagePortChannel.h:
  • dom/MutationRecord.h:
  • dom/TransformSource.h:
  • dom/ViewportArguments.cpp:
  • editing/DOMTransactionStep.h:
  • editing/EditingStyle.h:
  • editing/MarkupAccumulator.h:
  • editing/SmartReplaceICU.cpp:
  • editing/SpellChecker.h:
  • editing/SurroundingText.h:
  • fileapi/AsyncFileStream.cpp:
  • fileapi/Blob.h:
  • fileapi/BlobURL.cpp:
  • fileapi/File.h:
  • history/HistoryItem.h:
  • history/blackberry/HistoryItemViewState.h:
  • history/cf/HistoryPropertyList.h:
  • html/DOMFormData.cpp:
  • html/DOMURL.h:
  • html/MicroDataItemValue.h:
  • html/PublicURLManager.h:
  • html/canvas/CanvasPattern.cpp:
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasStyle.h:
  • html/canvas/WebGLActiveInfo.h:
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLRenderingContext.h:
  • html/parser/CSSPreloadScanner.h:
  • html/parser/HTMLEntitySearch.h:
  • html/parser/HTMLEntityTable.h:
  • html/parser/HTMLMetaCharsetParser.cpp:
  • inspector/CodeGeneratorInspector.py:

(InspectorFrontend_h):

  • inspector/ContentSearchUtils.h:
  • inspector/InjectedScript.cpp:
  • inspector/InjectedScriptBase.cpp:
  • inspector/InjectedScriptManager.h:
  • inspector/InjectedScriptModule.h:
  • inspector/InjectedScriptWebGLModule.h:
  • inspector/InspectorAgent.h:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorState.h:
  • inspector/InspectorStyleSheet.h:
  • inspector/InspectorStyleTextEditor.h:
  • inspector/InspectorValues.h:
  • inspector/InspectorWebGLAgent.h:
  • inspector/InspectorWorkerResource.h:
  • inspector/ScriptArguments.h:
  • inspector/ScriptBreakpoint.h:
  • inspector/ScriptCallFrame.h:
  • inspector/ScriptDebugListener.h:
  • inspector/TimelineRecordFactory.h:
  • inspector/generate-inspector-protocol-version:

(main):

  • loader/DocumentLoader.cpp:
  • loader/DocumentWriter.h:
  • loader/FTPDirectoryParser.h:
  • loader/FormState.h:
  • loader/HistoryController.h:
  • loader/PolicyChecker.h:
  • loader/ResourceLoadScheduler.h:
  • loader/SubframeLoader.h:
  • loader/SubstituteData.h:
  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/archive/ArchiveFactory.cpp:
  • loader/archive/ArchiveResourceCollection.h:
  • loader/cache/CachedResource.h:
  • loader/cache/MemoryCache.h:
  • loader/icon/IconRecord.h:
  • loader/icon/PageURLRecord.h:
  • loader/mac/LoaderNSURLExtras.mm:
  • loader/win/DocumentLoaderWin.cpp:
  • page/Console.cpp:
  • page/Coordinates.h:
  • page/DOMSelection.cpp:
  • page/EventSource.cpp:
  • page/GroupSettings.h:
  • page/NavigatorBase.cpp:
  • page/OriginAccessEntry.h:
  • page/Page.h:
  • page/SecurityOrigin.h:
  • page/SpeechInputResult.h:
  • page/UserContentURLPattern.h:
  • page/WindowFeatures.cpp:
  • page/WindowFeatures.h:
  • page/WorkerNavigator.h:
  • page/animation/AnimationControllerPrivate.h:
  • platform/AsyncFileSystem.h:
  • platform/AsyncFileSystemCallbacks.h:
  • platform/ContentType.h:
  • platform/ContextMenu.h:
  • platform/ContextMenuItem.h:
  • platform/Cookie.h:
  • platform/CrossThreadCopier.cpp:
  • platform/DateComponents.cpp:
  • platform/FileChooser.h:
  • platform/FileStream.cpp:
  • platform/FileSystem.h:
  • platform/KURL.cpp:

(WebCore):

  • platform/KURL.h:
  • platform/KURLHash.h:
  • platform/KillRing.h:
  • platform/Language.cpp:
  • platform/Length.cpp:
  • platform/LinkHash.cpp:
  • platform/Logging.cpp:
  • platform/MIMETypeRegistry.h:
  • platform/SSLKeyGenerator.h:
  • platform/SchemeRegistry.h:
  • platform/SharedBuffer.h:
  • platform/Theme.h:
  • platform/UUID.h:
  • platform/animation/Animation.h:
  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
  • platform/blackberry/CookieManager.h:
  • platform/blackberry/CookieMap.h:
  • platform/blackberry/DragDataBlackBerry.cpp:
  • platform/blackberry/KURLBlackBerry.cpp:
  • platform/blackberry/LocalizedStringsBlackBerry.cpp:
  • platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
  • platform/blackberry/TemporaryLinkStubs.cpp:
  • platform/cf/FileSystemCF.cpp:
  • platform/cf/SchedulePair.h:
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardUtilitiesChromium.cpp:
  • platform/chromium/DragDataChromium.cpp:
  • platform/chromium/FileSystemChromium.cpp:
  • platform/chromium/FileSystemChromiumMac.mm:
  • platform/chromium/LanguageChromium.cpp:
  • platform/chromium/SSLKeyGeneratorChromium.cpp:
  • platform/cocoa/KeyEventCocoa.mm:
  • platform/efl/ErrorsEfl.h:
  • platform/efl/LanguageEfl.cpp:
  • platform/efl/LocalizedStringsEfl.cpp:
  • platform/efl/LoggingEfl.cpp:
  • platform/efl/PasteboardEfl.cpp:
  • platform/efl/PlatformScreenEfl.cpp:
  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/BitmapImage.cpp:
  • platform/graphics/FontPlatformData.cpp:
  • platform/graphics/GlyphPageTreeNode.cpp:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/SegmentedFontData.cpp:
  • platform/graphics/blackberry/IconBlackBerry.cpp:
  • platform/graphics/blackberry/LayerData.h:
  • platform/graphics/blackberry/LayerFilterRenderer.cpp:
  • platform/graphics/blackberry/LayerRenderer.cpp:
  • platform/graphics/blackberry/skia/PlatformSupport.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/PlatformCALayerClient.h:
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/cg/ImageSourceCGMac.mm:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:
  • platform/graphics/chromium/IconChromium.cpp:
  • platform/graphics/chromium/IconChromiumAndroid.cpp:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:
  • platform/graphics/efl/IconEfl.cpp:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEDisplacementMap.h:
  • platform/graphics/filters/SourceAlpha.cpp:
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp:
  • platform/graphics/filters/SourceGraphic.h:
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:
  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
  • platform/graphics/mac/IconMac.mm:
  • platform/graphics/mac/ImageMac.mm:
  • platform/graphics/opentype/OpenTypeUtilities.h:
  • platform/graphics/openvg/PathOpenVG.cpp:
  • platform/graphics/pango/FontPlatformDataPango.cpp:
  • platform/graphics/qt/FontCacheQt.cpp:
  • platform/graphics/qt/FontPlatformDataQt.cpp:
  • platform/graphics/qt/IconQt.cpp:
  • platform/graphics/qt/ImageQt.cpp:
  • platform/graphics/qt/PathQt.cpp:
  • platform/graphics/skia/FontCustomPlatformData.h:
  • platform/graphics/skia/ImageSkia.cpp:
  • platform/graphics/win/FontCustomPlatformData.h:
  • platform/graphics/win/FontPlatformDataCGWin.cpp:
  • platform/graphics/win/FontPlatformDataCairoWin.cpp:
  • platform/graphics/win/FontPlatformDataWin.cpp:
  • platform/graphics/win/IconWin.cpp:
  • platform/graphics/win/ImageCGWin.cpp:
  • platform/graphics/win/ImageCairoWin.cpp:
  • platform/graphics/win/SimpleFontDataCGWin.cpp:
  • platform/graphics/wince/FontCustomPlatformData.h:
  • platform/graphics/wince/FontPlatformData.cpp:
  • platform/graphics/wince/ImageWinCE.cpp:
  • platform/graphics/wince/MediaPlayerProxy.cpp:
  • platform/graphics/wince/PathWinCE.cpp:
  • platform/graphics/wince/PlatformPathWinCE.cpp:
  • platform/graphics/wx/FontCacheWx.cpp:
  • platform/graphics/wx/FontPlatformDataWx.cpp:
  • platform/graphics/wx/IconWx.cpp:
  • platform/graphics/wx/PathWx.cpp:
  • platform/gtk/ErrorsGtk.h:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/gtk/GtkPopupMenu.h:
  • platform/gtk/KeyBindingTranslator.h:
  • platform/gtk/LanguageGtk.cpp:
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/gtk/LoggingGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/image-decoders/ImageDecoder.h:
  • platform/leveldb/LevelDBSlice.h:
  • platform/mac/FileSystemMac.mm:
  • platform/mediastream/MediaStreamSource.h:
  • platform/mock/GeolocationClientMock.h:
  • platform/network/BlobData.h:
  • platform/network/BlobRegistryImpl.h:
  • platform/network/BlobResourceHandle.h:
  • platform/network/Credential.h:
  • platform/network/FormData.h:
  • platform/network/FormDataBuilder.h:
  • platform/network/HTTPParsers.cpp:
  • platform/network/HTTPRequest.h:
  • platform/network/HTTPValidation.cpp:
  • platform/network/ProtectionSpace.h:
  • platform/network/ResourceErrorBase.h:
  • platform/network/SocketStreamErrorBase.h:
  • platform/network/blackberry/DNSBlackBerry.cpp:
  • platform/network/blackberry/DeferredData.h:
  • platform/network/blackberry/NetworkJob.h:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/curl/CookieJarCurl.cpp:
  • platform/network/curl/ResourceHandleManager.h:
  • platform/network/qt/DnsPrefetchHelper.cpp:
  • platform/network/soup/ResourceRequestSoup.cpp:
  • platform/network/soup/ResourceResponseSoup.cpp:
  • platform/network/win/CookieJarWin.cpp:
  • platform/posix/FileSystemPOSIX.cpp:
  • platform/qt/ClipboardQt.cpp:
  • platform/qt/CookieJarQt.cpp:
  • platform/qt/FileSystemQt.cpp:
  • platform/qt/LanguageQt.cpp:
  • platform/qt/LocalizedStringsQt.cpp:
  • platform/qt/LoggingQt.cpp:
  • platform/qt/PlatformSupport.h:
  • platform/sql/SQLValue.h:
  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteFileSystem.h:
  • platform/text/DecodeEscapeSequences.h:
  • platform/text/LineEnding.cpp:
  • platform/text/ParserUtilities.h:
  • platform/text/PlatformString.h: Removed.
  • platform/text/RegularExpression.h:
  • platform/text/SegmentedString.h:
  • platform/text/StringWithDirection.h:
  • platform/text/SuffixTree.h:
  • platform/text/TextBreakIteratorICU.cpp:
  • platform/text/TextCodec.cpp:
  • platform/text/TextCodec.h:
  • platform/text/TextCodecLatin1.cpp:
  • platform/text/TextCodecUTF16.cpp:
  • platform/text/TextCodecUserDefined.cpp:
  • platform/text/TextEncoding.cpp:
  • platform/text/blackberry/StringBlackBerry.cpp:
  • platform/text/cf/StringCF.cpp:
  • platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
  • platform/text/gtk/TextCodecGtk.cpp:
  • platform/text/mac/StringMac.mm:
  • platform/text/mac/TextCodecMac.cpp:
  • platform/text/qt/TextCodecQt.cpp:
  • platform/text/win/TextCodecWin.h:
  • platform/text/wince/TextBreakIteratorWinCE.cpp:
  • platform/win/BString.cpp:
  • platform/win/DragDataWin.cpp:
  • platform/win/GDIObjectCounter.h:
  • platform/win/LoggingWin.cpp:
  • platform/win/WCDataObject.cpp:
  • platform/wince/DragDataWinCE.cpp:
  • platform/wx/ClipboardWx.cpp:
  • platform/wx/FileSystemWx.cpp:
  • platform/wx/LanguageWx.cpp:
  • platform/wx/LocalizedStringsWx.cpp:
  • platform/wx/LoggingWx.cpp:
  • platform/wx/PasteboardWx.cpp:
  • platform/wx/PopupMenuWx.cpp:
  • plugins/PluginData.h:
  • plugins/PluginDatabase.h:
  • plugins/PluginDebug.cpp:
  • plugins/PluginPackage.h:
  • plugins/PluginStream.h:
  • rendering/style/StyleDashboardRegion.h:
  • storage/Storage.cpp:
  • storage/StorageArea.h:
  • storage/StorageEvent.h:
  • storage/StorageEventDispatcher.h:
  • storage/StorageMap.h:
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.h:
  • storage/StorageSyncManager.h:
  • storage/StorageTask.h:
  • storage/StorageTracker.h:
  • svg/SVGPathByteStreamBuilder.h:
  • svg/SVGPathParser.h:
  • svg/SVGPathStringSource.h:
  • svg/SVGStyledElement.cpp:
  • svg/animation/SMILTimeContainer.h:
  • svg/graphics/filters/SVGFilterBuilder.cpp:
  • svg/graphics/filters/SVGFilterBuilder.h:
  • testing/Internals.h:
  • workers/DefaultSharedWorkerRepository.cpp:
  • workers/WorkerLocation.cpp:
  • workers/WorkerThread.cpp:
  • xml/DOMParser.cpp:
  • xml/NativeXPathNSResolver.cpp:
  • xml/XMLSerializer.cpp:
  • xml/XMLSerializer.h:
  • xml/XPathExpression.cpp:
  • xml/XPathValue.h:
  • xml/XSLTUnicodeSort.cpp:

Source/WebKit/blackberry:

  • Api/DumpRenderTreeClient.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:
  • WebCoreSupport/InspectorClientBlackBerry.h:
  • WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp:
  • WebKitSupport/AboutData.h:

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::createFrontendSettings):

Source/WebKit/chromium:

  • src/ContextMenuClientImpl.cpp:
  • src/EditorClientImpl.cpp:
  • src/InspectorFrontendClientImpl.cpp:
  • src/LocalFileSystemChromium.cpp:
  • src/SpeechInputClientImpl.cpp:
  • src/SpeechRecognitionClientProxy.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsFrontendImpl.cpp:
  • src/WebDevToolsFrontendImpl.h:
  • src/WebEntities.h:
  • src/WebFrameImpl.h:
  • src/WorkerFileSystemCallbacksBridge.h:
  • tests/UniscribeHelperTest.cpp:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/InspectorClientEfl.cpp:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/InspectorClientGtk.cpp:
  • gdom/ConvertToGCharPrivate.h:
  • webkit/webkitsecurityorigin.cpp:
  • webkit/webkitwebdatasource.cpp:
  • webkit/webkitwebhistoryitem.cpp:
  • webkit/webkitwebresource.cpp:

Source/WebKit/mac:

  • History/WebHistoryItem.mm:
  • Misc/WebStringTruncator.mm:
  • Plugins/Hosted/NetscapePluginHostManager.h:

(NetscapePluginHostManager):

  • Plugins/WebPluginController.mm:
  • Storage/WebStorageTrackerClient.mm:
  • WebCoreSupport/WebChromeClient.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebCoreSupport/WebIconDatabaseClient.mm:
  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient):
(WebInspectorFrontendClient):

  • WebView/WebRenderLayer.mm:
  • WebView/WebViewData.h:

Source/WebKit/qt:

  • Api/qwebdatabase_p.h:
  • Api/qwebframe_p.h:
  • Api/qwebhistory.cpp:
  • Api/qwebhistoryinterface.cpp:
  • Api/qwebpage_p.h:
  • Api/qwebsettings.cpp:
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/InspectorClientQt.cpp:

Source/WebKit/win:

  • DOMCSSClasses.cpp:
  • DefaultPolicyDelegate.cpp:
  • MarshallingHelpers.cpp:
  • WebCoreSupport/WebInspectorClient.h:
  • WebDownload.h:
  • WebFrame.h:
  • WebHistoryItem.h:
  • WebIconDatabase.cpp:
  • WebKitDLL.h:
  • WebKitGraphics.cpp:
  • WebKitSystemBits.cpp:
  • WebLocalizableStrings.cpp:
  • WebNotificationCenter.cpp:
  • WebResource.h:

Source/WebKit/wx:

  • WebFrame.cpp:
  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/EditorClientWx.cpp:
  • WebKitSupport/FrameLoaderClientWx.cpp:
  • WebKitSupport/InspectorClientWx.cpp:
  • WebSettings.cpp:
  • WebView.cpp:
10:29 AM Changeset in webkit [127756] by danakj@chromium.org
  • 6 edits in trunk/Source

[chromium] Add a customized copy() method to CCRenderPassDrawQuad
https://bugs.webkit.org/show_bug.cgi?id=95871

Reviewed by Adrienne Walker.

Source/WebCore:

CCRenderPassDrawQuad is special because a copied quad will need to
point to a different RenderPass id, since new ids are given to copied
RenderPasses. Add a custom copy() method to CCRenderPassDrawQuad that
takes as input the new RenderPass id that should appear in the copied
quad.

Test: CCDrawQuad.copyRenderPassDrawQuad

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::copy):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::copy):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):

Source/WebKit/chromium:

  • tests/CCDrawQuadTest.cpp:

(WebCore):
(WebCore::TEST):

10:26 AM Changeset in webkit [127755] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

gradient-with-scaled-ancestor.html is not calling setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=95847

Patch by Alex Sakhartchouk <alexst@chromium.org> on 2012-09-06
Reviewed by Beth Dakin.

Setting the device scale factor in the layout test and updating expectations until we can rebase

  • fast/hidpi/gradient-with-scaled-ancestor.html:
  • platform/chromium/TestExpectations:
10:16 AM Changeset in webkit [127754] by ap@apple.com
  • 11 edits in trunk/Source/WebKit2

[WK2] Annotate multi-process FIXMEs with bug numbers
https://bugs.webkit.org/show_bug.cgi?id=95916

Reviewed by Eric Carlson.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::setProcessModel): Ensure that plug-in process is enabled. Comments in WebPluginSiteDataManager said that it's required for multi-process. (WebKit::WebContext::createNewWebProcess): Added a bug number. (WebKit::WebContext::disconnectProcess): Ditto. (WebKit::WebContext::createWebPage): Ditto. (WebKit::WebContext::download): Ditto. (WebKit::WebContext::getWebCoreStatistics): Ditto.
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData): Removed FIXMEs - some ports haven't switched to plugin process yet, but that doesn't stop others from having a multi-process model. Added an ASSERT to document this requirement (in addition to the check in WebContext).
  • UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::cancel): (WebKit::DownloadProxy::didReceiveAuthenticationChallenge): (WebKit::DownloadProxy::startTransfer):
  • UIProcess/WebApplicationCacheManagerProxy.cpp: (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
  • UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::getHostnamesWithCookies): (WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
  • UIProcess/WebDatabaseManagerProxy.cpp: (WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin): (WebKit::WebDatabaseManagerProxy::getDatabaseOrigins): (WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin): (WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin): (WebKit::WebDatabaseManagerProxy::deleteAllDatabases): (WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
  • UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::getLoadDecisionForIconURL): (WebKit::WebIconDatabase::didFinishURLImport):
  • UIProcess/WebKeyValueStorageManagerProxy.cpp: (WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins): (WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin): (WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
  • UIProcess/WebMediaCacheManagerProxy.cpp: (WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
  • UIProcess/WebResourceCacheManagerProxy.cpp: (WebKit::WebResourceCacheManagerProxy::getCacheOrigins): (WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin): (WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins): Added bug numbers.
10:14 AM Changeset in webkit [127753] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2 IPC always sends strings using 16 bit data format
https://bugs.webkit.org/show_bug.cgi?id=95811

Reviewed by Benjamin Poulain.

Changed string encoding to pass an 8bit flag and then send either 8 or 16 bit
character data.

  • Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::decodeStringText): New templatized string creation and decoder method.
(CoreIPC::::decode):

10:13 AM Changeset in webkit [127752] by commit-queue@webkit.org
  • 21 edits in trunk/Source

Remove extraneous includes (HTMLElement, SVGElement, GlyphBuffer, Clipboard)
https://bugs.webkit.org/show_bug.cgi?id=95780

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-09-06
Reviewed by Eric Seidel.

Removes extraneous includes of type HTMLElement, SVGElement, GlyphBuffer,
and Clipboard. There is a minor compile-time performance boost.

  • Modules/mediastream/MediaStreamEvent.h:
  • dom/Event.cpp:
  • dom/Event.h:

(WebCore):

  • dom/EventDispatchMediator.cpp:
  • dom/EventListenerMap.cpp:
  • dom/MouseRelatedEvent.h:
  • dom/UIEvent.cpp:
  • html/FormAssociatedElement.h:

(WebCore):

  • inspector/TimelineRecordFactory.cpp:
  • platform/graphics/FontPlatformData.h:
  • rendering/RenderLineBoxList.h:
  • rendering/style/RenderStyle.h:

(WebCore):

  • svg/SVGAnimatedType.h:
  • svg/SVGExternalResourcesRequired.cpp:
  • svg/SVGExternalResourcesRequired.h:

(WebCore):

  • svg/SVGURIReference.h:

(WebCore):

10:11 AM Changeset in webkit [127751] by mitz@apple.com
  • 8 edits in trunk

REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
https://bugs.webkit.org/show_bug.cgi?id=95972

Source/WebCore:

Reverted r127712, because it was based on the false premise that “[Optional] works the way
XMLHttpRequest expects”.

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::openCallback):
(WebCore):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
(WebCore):

  • xml/XMLHttpRequest.h:

(XMLHttpRequest):

  • xml/XMLHttpRequest.idl:

LayoutTests:

Removed the failing test from the skipped list.

  • platform/qt/Skipped:
9:57 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
9:56 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
9:53 AM Changeset in webkit [127750] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] [WK2] Crash when navigating between pages
https://bugs.webkit.org/show_bug.cgi?id=95949

Reviewed by Martin Robinson.

Do not trust isMainResource parameter in
webkitWebViewResourceLoadStarted(), because it's always true for
all subresources of pages loaded from the history cache. We can
simply assume that the first resource loaded for the main frame
is the main web view resource.

  • UIProcess/API/gtk/WebKitResourceLoadClient.cpp:

(didInitiateLoadForResource):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewResourceLoadStarted):

  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
9:49 AM Changeset in webkit [127749] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit/gtk

[GTK] Add API to get/set the security policy of a given URI scheme
https://bugs.webkit.org/show_bug.cgi?id=95549

Reviewed by Martin Robinson.

Add WebKitSecurityPolicy enum with flags that represent the
security policy of a URI scheme. Add methods to get and set the
security policy flags for a given URI scheme.

  • docs/webkitgtk-sections.txt: Add new symbols.
  • tests/testglobals.c:

(test_globals_security_policy):
(main):

  • webkit/webkitglobals.cpp:

(webkit_set_security_policy_for_uri_scheme):
(webkit_get_security_policy_for_uri_scheme):

  • webkit/webkitglobals.h:
9:41 AM Changeset in webkit [127748] by keishi@webkit.org
  • 4 edits in trunk/Source/WebCore

Use native function bind in page popups
https://bugs.webkit.org/show_bug.cgi?id=95976

Reviewed by Kent Tamura.

We should be using Function.prototype.bind instead of our own bind implementation.

No new tests. No behavior change.

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker):
(CalendarPicker.prototype._layoutButtons):
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._attachLeftButtonsTo):
(YearMonthController.prototype._attachRightButtonsTo):
(DaysTable.prototype.attachTo):

  • Resources/pagepopups/colorSuggestionPicker.js:

(ColorPicker):
(ColorPicker.prototype._layout):

  • Resources/pagepopups/pickerCommon.js:
9:25 AM Changeset in webkit [127747] by abecsi@webkit.org
  • 2 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE] Fix the build with gcc 4.7
https://bugs.webkit.org/show_bug.cgi?id=95989

Reviewed by Csaba Osztrogonác.

The build fails because of a bogus warning about the auto-generated
pplval variable. Unfortunately the warning is called -Wuninitialized
in gcc 4.6 and -Wmaybe-uninitialized in gcc 4.7 thus we also need to
ignore unknown pragmas not to break the build with compilers that do
not recognize these options.

  • src/compiler/preprocessor/new/ExpressionParser.y:
9:00 AM Changeset in webkit [127746] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Timeline: cache "filteredRecords" for better scrolling performance.
https://bugs.webkit.org/show_bug.cgi?id=95731

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-09-06
Reviewed by Yury Semikhatsky.

Now scrolling is sluggish on large datasets.
Performance degrades, because each refresh causes DFS on all recorded items.
Solution: caching/invalidation of DFS (filtering) results.

Also fixed "truncate selected record range on mode change" glitch.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
Add flag for cache invalidation.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.invalidateFilteredRecords):
Added.
(WebInspector.TimelinePresentationModel.prototype.filteredRecords):
Caching/using cached results.

8:54 AM Changeset in webkit [127745] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Crash in WebPageProxy::showPopupMenu if PageClient does not implement createPopupMenuProxy
https://bugs.webkit.org/show_bug.cgi?id=95862

Reviewed by Simon Hausmann.

Bail out early if the PageClient does not create a PopupMenuProxy for us.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):

8:42 AM Changeset in webkit [127744] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

[EFL] Gardening after r127728, r127534
https://bugs.webkit.org/show_bug.cgi?id=95975

Unreviewed gardening.

Following tests were added to TestExpectations:
http/tests/xmlhttprequest/basic-auth.html fails after r127728.
fast/innerHTML/innerHTML-iframe.html fails after r127534.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-06

  • platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.
  • platform/efl/TestExpectations:
8:40 AM Changeset in webkit [127743] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed rebaseline for Web Inspector NMI test. It was broken at r127738.

  • inspector/profiler/memory-instrumentation-cached-images-expected.txt:
  • inspector/profiler/memory-instrumentation-cached-images.html:
8:31 AM Changeset in webkit [127742] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=95200

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-06
Reviewed by Tor Arne Vestbø.

The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
10.7 and newer.

  • qmake/mkspecs/features/features.prf:
8:04 AM Changeset in webkit [127741] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed Web Inspector: test fix.

  • tests/MemoryInstrumentationTest.cpp:

(StringOwnerInstrumented):
(WebCore::StringOwnerInstrumented::StringOwnerInstrumented):
(WebCore::StringOwnerInstrumented::reportMemoryUsage):
(WebCore):
(WebCore::TEST):

7:38 AM Changeset in webkit [127740] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove unnecessary logic in ewk_frame_source_get.
https://bugs.webkit.org/show_bug.cgi?id=95828

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Removed unnecessary logic that checks if <html> tag exists in document.
WebKit automatically fill out <html></html> tags if they are not existed.

  • ewk/ewk_frame.cpp:

(ewk_frame_source_get):

7:36 AM Changeset in webkit [127739] by commit-queue@webkit.org
  • 6 edits in trunk

[WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
https://bugs.webkit.org/show_bug.cgi?id=95973

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Tools:

Correctly map "addSelectionKey" to "Control" modifier
in WKTR's EventSender on other OSes than Mac OS X,
instead of mapping it to the "Meta" modifier.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::parseModifier):

LayoutTests:

Unskip several test cases that are passing on WebKit2
now that "addSelectionKey" is properly mapped to
"Control" modifier on other OSes than Mac OS X, in
WKTR's EventSender.

  • platform/efl-wk2/TestExpectations:
  • platform/gtk-wk2/Skipped:
  • platform/win-wk2/Skipped:
7:25 AM Changeset in webkit [127738] by loislo@chromium.org
  • 11 edits in trunk/Source

Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
https://bugs.webkit.org/show_bug.cgi?id=95957

Reviewed by Yury Semikhatsky.

Source/WebCore:

Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
At a later stage, when each type of memory will be counted in MemoryInstrumentation
we will build the blocks hierarchy for the front-end automatically.

  • dom/MemoryInstrumentation.cpp:

(WebCore):

  • dom/MemoryInstrumentation.h:

(GenericMemoryTypes):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCoreMemoryTypes):

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::countObjectSize):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::reportMemoryUsage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • loader/cache/CachedResourceHandle.cpp:

(WebCore::CachedResourceHandleBase::reportMemoryUsage):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::reportMemoryUsage):

Source/WebKit/chromium:

Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
At a later stage, when each memory type is counted in MemoryInstrumentation
we will build the blocks hierarchy for the front-end automatically.

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::InstrumentedUndefined::InstrumentedUndefined):
(WebCore::InstrumentedUndefined::reportMemoryUsage):
(WebCore::InstrumentedDOM::InstrumentedDOM):
(WebCore::InstrumentedDOM::reportMemoryUsage):
(InstrumentedDOM):
(WebCore::TEST):

7:00 AM Changeset in webkit [127737] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

CSS 3 'overflow-wrap' property implementation
https://bugs.webkit.org/show_bug.cgi?id=94475

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-06
Reviewed by Ojan Vafai.

Source/WebCore:

Added 'overflow-wrap' property implementation according to
http://www.w3.org/TR/2012/WD-css3-text-20120814/#overflow-wrap.
The specification declares that 'word-wrap' as a shorthand
for the 'overflow-wrap' property. So what was basically done
is declaring of new 'overflow-wrap' property and renaming
of the internal data structures from 'WordWrap' to 'OverflowWrap'.
Both 'overflow-wrap' and 'word-wrap' properties share the same
handlers and thus have the same behaviour.

Test: fast/text/overflow-wrap.html

  • WebCore.order: Rename exported setWordWrap to setOverflowWrap.
  • css/CSSComputedStyleDeclaration.cpp: Add CSSPropertyOverflowWrap to computedProperties.

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp: Validation for the 'overflow-wrap' property.

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EOverflowWrap):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): CSSPropertyOverflowWrap is inherited.

  • css/CSSPropertyNames.in: Declare new 'overflow-wrap' property.
  • css/StyleBuilder.cpp: Assign property handler (same as for 'word-wrap').

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Renaming.

  • rendering/RenderTextControl.cpp: Ditto.

(WebCore::RenderTextControl::computeLogicalHeight):

  • rendering/RenderTextControlSingleLine.cpp: Ditto.

(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

  • rendering/style/RenderStyle.cpp: Ditto.

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h: Ditto.
  • rendering/style/RenderStyleConstants.h: Ditto.
  • rendering/style/StyleRareInheritedData.cpp: Ditto.

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h: Ditto.

(StyleRareInheritedData):

LayoutTests:

Added 'overflow-wrap' property implementation according to
http://www.w3.org/TR/2012/WD-css3-text-20120814/#overflow-wrap.
New ref-test is added to check the simularity
in behaviour of 'overflow-wrap' and 'word-wrap' properties.

  • fast/text/overflow-wrap-expected.html: Added.
  • fast/text/overflow-wrap.html: Added.
6:41 AM Changeset in webkit [127736] by anilsson@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Always log shader compilation failure
https://bugs.webkit.org/show_bug.cgi?id=95948

Reviewed by George Staikos.

Also add shader source to the logs. In addition, don't bail on the
first failure, run through all shaders so we get a complete set of
logs.

No new tests: no change in functionality.

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::loadShader):
(WebCore::LayerRenderer::initializeSharedGLObjects):

6:23 AM Changeset in webkit [127735] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Update TestExpectations for fast/events/tab-focus-link-in-canvas.html
https://bugs.webkit.org/show_bug.cgi?id=95970

Unreviewed EFL gardening.

Update WK2-EFL TestExpectations to add bug number for:
fast/events/tab-focus-link-in-canvas.html

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06

  • platform/efl-wk2/TestExpectations:
6:21 AM Changeset in webkit [127734] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

[nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
https://bugs.webkit.org/show_bug.cgi?id=95710

Reviewed by Dirk Pranke.

The stdout / stderr output can be None so make sure
we won't raise an exception in this case.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test):

6:05 AM Changeset in webkit [127733] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][WK2] Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
https://bugs.webkit.org/show_bug.cgi?id=95943

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
in EFL WK2.

  • WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

LayoutTests:

Unskip several test cases that are passing now that EFL WK2
has a proper implementation for
WebPage::performDefaultBehaviorForKeyEvent().

  • platform/efl-wk2/TestExpectations:
5:54 AM Changeset in webkit [127732] by Patrick Gansterer
  • 8 edits in trunk/Source

Remove String::operator+=() from windows platform code
https://bugs.webkit.org/show_bug.cgi?id=95904

Reviewed by Benjamin Poulain.

Use StringBuilder and operator+() to concatenate strings instead of operator+=().

Source/WebCore:

  • platform/win/ClipboardWin.cpp:

(WebCore::filesystemPathFromUrlOrTitle):

Source/WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::get_accKeyboardShortcut):

  • WebDownload.cpp:

(WebDownload::bundlePathForTargetPath):

  • WebView.cpp:

(imeCompositionArgumentNames):

Source/WebKit2:

  • UIProcess/win/WebView.cpp:

(WebKit::imeCompositionArgumentNames):

5:29 AM Changeset in webkit [127731] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CMake] Add notifications path to the WebKit2/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=95843

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-09-06
Reviewed by Laszlo Gombos.

Add WebCore/Modules/Notifications to the WebKit2_INCLUDE_DIRECTORIES of WebKit2/CMakeLists.txt.
There are some build errors when ENABLE_NOTIFICATIONS feature is enabled.

  • CMakeLists.txt:
5:21 AM Changeset in webkit [127730] by mikelawther@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Rewrite zooming test to no longer output pixel numbers
https://bugs.webkit.org/show_bug.cgi?id=95922

Reviewed by Dan Bernstein.

The original version of this test output pixel sizes, which had different results on
different ports. The test has been rewritten to suppress the pixel size output.

  • css3/calc/zoom-with-em-expected.txt:
  • css3/calc/zoom-with-em.html:
  • platform/chromium/css3/calc/zoom-with-em-expected.txt: Removed.
5:06 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
4:44 AM Changeset in webkit [127729] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Tools

[EFL] Sanitize URLs in EWebLauncher / Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=95849

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Sanitize URLs passed by the user as program
argument or typed in the URL bar in order to
be more tolerant.

  • EWebLauncher/CMakeLists.txt:
  • EWebLauncher/main.c:

(main):

  • EWebLauncher/url_bar.c:

(_url_bar_url_get_with_protocol):
(on_urlbar_key_down):

  • EWebLauncher/url_utils.c: Added.

(has_scheme):
(url_from_user_input): Add utility function to construct a
URL from user input.

  • EWebLauncher/url_utils.h: Added.
  • MiniBrowser/efl/CMakeLists.txt:
  • MiniBrowser/efl/main.c:

(main):

4:22 AM Changeset in webkit [127728] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip one more failing test,
because we like regressions in the trunk. :)

  • platform/qt/Skipped:
4:05 AM Changeset in webkit [127727] by keishi@webkit.org
  • 6 edits in trunk

Refactor CalendarPicker to not use global variables.
https://bugs.webkit.org/show_bug.cgi?id=95830

Reviewed by Kent Tamura.

Source/WebCore:

Introduce CalendarPicker so we can have multiple Pickers in one page
popup in the future.

No new tests. No behavior change.

  • Resources/pagepopups/calendarPicker.js:

(initialize):
(resetMain):
(openCalendarPicker):
(CalendarPicker):
(CalendarPicker.prototype._layout):
(CalendarPicker.prototype.handleToday):
(CalendarPicker.prototype.handleClear):
(CalendarPicker.prototype.fixWindowSize):
(CalendarPicker.prototype._layoutButtons):
(YearMonthController):
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._redraw):
(YearMonthController.prototype._handleYearMonthChange):
(YearMonthController.prototype.moveRelatively):
(DaysTable):
(DaysTable.prototype.attachTo):
(CalendarPicker.prototype.stepMismatch):
(CalendarPicker.prototype.outOfRange):
(CalendarPicker.prototype.isValidDate):
(DaysTable.prototype._renderMonth):
(DaysTable.prototype._navigateToMonth):
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
(DaysTable.prototype._handleDayClick):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):

  • Resources/pagepopups/colorSuggestionPicker.js:

(ColorPicker):
(ColorPicker.prototype._layout):
(ColorPicker.prototype._handleKeyDown):
(ColorPicker.prototype._handleSwatchClick):

  • Resources/pagepopups/pickerCommon.js:

(Picker):
(Picker.prototype.submitValue):
(Picker.prototype.handleCancel):
(Picker.prototype.chooseOtherColor):

LayoutTests:

  • fast/forms/date/calendar-picker-appearance-pre-100.html:
4:02 AM Changeset in webkit [127726] by Simon Hausmann
  • 9 edits in trunk

[Qt] Various small Windows / MSVC build fixes
https://bugs.webkit.org/show_bug.cgi?id=95934

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

  • Shared/LayerTreeContext.h: Include stdint.h due to the use of uint32_t as layer id.
  • UIProcess/API/qt/qquickwebview_p.h:

(WebKit): Fix struct vs. class forward declaration mismatch, causing linking errors.

  • UIProcess/API/qt/tests/bytearraytestdata.h: Remove export macro from internal test class

that is not used anymore. Using the export macro from a DLL when the code in question is not
part of the DLL results in the export macro expanding to dllimport, giving incorrect linkage
for the unit test.

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt): Removed explicit call to srandom(), which is not available on Windows.
The call appears to be unnecessary in the light of the WTF::initializeThreading() call below, which
in turn calls WTF::initializeRandomNumberGenerator(), which does the same thing already (and isn't
needed on Windows, as per comment in wtf/RandomNumberSeed.h)

Source/WTF:

For the Qt build on Windows, do not enable WTF_USE_UNIX_DOMAIN_SOCKETS for
WebKit2 IPC.

  • wtf/Platform.h:

Tools:

setFocus takes a boolean as argument: Don't try to implicitly convert
an enum to a boolean, MSVC doesn't like that. The intent here is to
enable focus, so just pass true.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::focus):

3:59 AM Changeset in webkit [127725] by Simon Hausmann
  • 1 edit in trunk/Source/WebKit2/Target.pri

Small typo I forgot to land as part of r127724

3:55 AM Changeset in webkit [127724] by Simon Hausmann
  • 14 edits
    5 adds in trunk

[Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
https://bugs.webkit.org/show_bug.cgi?id=95965

Reviewed by Tor Arne Vestbø.

.:

Add ANGLE as separate static library to the build and dependencies.

  • Source/api.pri:
  • WebKit.pro:

Source/ThirdParty/ANGLE:

Add build rules to build ANGLE as a static library for the Qt port.

  • ANGLE.pri: Added.
  • ANGLE.pro: Added.
  • DerivedSources.pri: Added.
  • Target.pri: Added.

Source/WebCore:

Moved all ANGLE build rules from here to Source/Thirty/ANGLE and
instead depend on the new library with a simple WEBKIT += ANGLE.

  • DerivedSources.pri:
  • Target.pri:
  • platform/graphics/ANGLEWebKitBridge.h: Simplify the include statement

for the internal shader compiler API, aligned with the other platforms.

Source/WebKit:

Depend on ANGLE if necessary, due to the use WebCore types that pull in ANGLE
headers (GraphicsContext3D.h in particular).

  • WebKit1.pro:

Source/WebKit2:

Depend on ANGLE if necessary, due to the use WebCore types that pull in ANGLE
headers (GraphicsContext3D.h in particular).

  • Target.pri:

Tools:

Add ANGLE as a static library module to the Qt WebKit build system.

  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/modules/angle.prf: Added.
3:47 AM Changeset in webkit [127723] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Keep placeholder text visible until first input from user.
https://bugs.webkit.org/show_bug.cgi?id=95851

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-06
Reviewed by Gyuyoung Kim.

Current specification, http://dev.w3.org/html5/spec/single-page.html#attr-input-placeholder, has allowed user agent to keep placeholder text until first input.
Therefore, this patch enabled it.

  • platform/efl/RenderThemeEfl.h:

(WebCore::RenderThemeEfl::shouldShowPlaceholderWhenFocused):

3:47 AM Changeset in webkit [127722] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r127620, r127698 and r127704
https://bugs.webkit.org/show_bug.cgi?id=95963

Unreviewed gardening.

Following tests were added to TestExpectations:
compositing/overflow/overflow-auto-with-touch-toggle.html fails after r127620.
fast/dom/HTMLScriptElement/script-reexecution.html fails after r127698.
fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html fails after r127704.
fast/viewport/viewport-limits-adjusted-for-no-user-scale.html fails after r127704.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-06

  • platform/efl/TestExpectations:
3:40 AM Changeset in webkit [127721] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Win build fix attempt after r127715

  • tests/CCRenderPassTest.cpp:

(WebCore::TEST):

3:36 AM Changeset in webkit [127720] by abecsi@webkit.org
  • 15 edits
    1 move
    4 adds
    1 delete in trunk

[WK2] Make [Qt]ViewportHandler cross platform
https://bugs.webkit.org/show_bug.cgi?id=91257

Source/WebKit2:

Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.

Since QtViewportHandler includes behaviour that is not platform
specific together with hooks to the QtQuick API layer, a platform
independent implementation would allow other ports to use the
viewport controlling functionality provided.

This patch removes QtViewportHandler and introduces a platform
independent PageViewportController class that is responsible
for handling requests from the web process (eg. content size
changes, viewport attributes changes and scroll position requests).
Requests from the web process are acted on by a platform specific
client class which implements the PageViewportControllerClient
interface which provides hooks to the platform specific API layer.

The PageViewportController is also responsible to notify the web
process about changes in the viewport state (eg. viewport size,
visible rect, content scale and movement trajectory).
The client is responsible to delegate these UI changes to the
PageViewportController.

For now only PageViewportControllerClientQt implements the client
interface besides providing other QQuick specific functionality
(gestures, animations, etc).

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage_p_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::~QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):

  • UIProcess/API/qt/qquickwebview_p.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(WebKit):
(QQuickWebViewPrivate::pageViewportControllerClient):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::viewport):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::contentsScale):

  • UIProcess/PageViewportController.cpp: Added.

(WebKit):
(WebKit::bound):
(WebKit::fuzzyCompare):
(WebKit::boundPosition):
(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::convertFromViewport):
(WebKit::PageViewportController::convertToViewport):
(WebKit::PageViewportController::innerBoundedContentsScale):
(WebKit::PageViewportController::outerBoundedContentsScale):
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::setViewportSize):
(WebKit::PageViewportController::setVisibleContentsRect):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::suspendContent):
(WebKit::PageViewportController::resumeContent):
(WebKit::PageViewportController::positionRangeForContentAtScale):

  • UIProcess/PageViewportController.h: Added.

(WebCore):
(WebKit):
(ViewportUpdateDeferrer):
(PageViewportController):
(WebKit::PageViewportController::~PageViewportController):
(WebKit::PageViewportController::hasSuspendedContent):
(WebKit::PageViewportController::hadUserInteraction):
(WebKit::PageViewportController::allowsUserScaling):
(WebKit::PageViewportController::contentsLayoutSize):
(WebKit::PageViewportController::devicePixelRatio):
(WebKit::PageViewportController::minimumContentsScale):
(WebKit::PageViewportController::maximumContentsScale):
(WebKit::PageViewportController::setHadUserInteraction):

  • UIProcess/PageViewportControllerClient.h: Added.

(WebKit):
(PageViewportControllerClient):
(WebKit::PageViewportControllerClient::PageViewportControllerClient):
(WebKit::PageViewportControllerClient::~PageViewportControllerClient):

  • UIProcess/qt/PageViewportControllerClientQt.cpp: Added.

(WebKit):
(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::ScaleAnimation::updateCurrentValue):
(WebKit::PageViewportControllerClientQt::~PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::setContentRectVisiblePositionAtScale):
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::pageItemPositionChanged):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::touchEnd):
(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::nearestValidVisibleContentsRect):
(WebKit::PageViewportControllerClientQt::setContentsPosition):
(WebKit::PageViewportControllerClientQt::setContentsScale):
(WebKit::PageViewportControllerClientQt::setContentsRectToNearestValidBounds):
(WebKit::PageViewportControllerClientQt::didResumeContent):
(WebKit::PageViewportControllerClientQt::allowsUserScaling):
(WebKit::PageViewportControllerClientQt::devicePixelRatio):
(WebKit::PageViewportControllerClientQt::minimumContentsScale):
(WebKit::PageViewportControllerClientQt::maximumContentsScale):
(WebKit::PageViewportControllerClientQt::currentContentsScale):
(WebKit::PageViewportControllerClientQt::contentsLayoutSize):
(WebKit::PageViewportControllerClientQt::scrollAnimationActive):
(WebKit::PageViewportControllerClientQt::panGestureActive):
(WebKit::PageViewportControllerClientQt::panGestureStarted):
(WebKit::PageViewportControllerClientQt::panGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::panGestureEnded):
(WebKit::PageViewportControllerClientQt::panGestureCancelled):
(WebKit::PageViewportControllerClientQt::scaleAnimationActive):
(WebKit::PageViewportControllerClientQt::cancelScrollAnimation):
(WebKit::PageViewportControllerClientQt::interruptScaleAnimation):
(WebKit::PageViewportControllerClientQt::pinchGestureActive):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):
(WebKit::PageViewportControllerClientQt::visibleContentsRect):
(WebKit::PageViewportControllerClientQt::didChangeContentsSize):
(WebKit::PageViewportControllerClientQt::didChangeVisibleContents):
(WebKit::PageViewportControllerClientQt::didChangeViewportAttributes):
(WebKit::PageViewportControllerClientQt::updateViewportController):
(WebKit::PageViewportControllerClientQt::scaleContent):
(WebKit::PageViewportControllerClientQt::viewportScaleForRect):

  • UIProcess/qt/PageViewportControllerClientQt.h: Added.

(WebKit):
(PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::setController):
(ScaleAnimation):
(WebKit::PageViewportControllerClientQt::ScaleAnimation::ScaleAnimation):
(WebKit::PageViewportControllerClientQt::ScaleStackItem::ScaleStackItem):
(ScaleStackItem):

  • UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::viewportController):

  • UIProcess/qt/QtGestureRecognizer.h:

(WebKit):

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::update):
(WebKit::QtPanGestureRecognizer::finish):
(WebKit::QtPanGestureRecognizer::cancel):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::update):
(WebKit::QtPinchGestureRecognizer::finish):
(WebKit::QtPinchGestureRecognizer::cancel):

  • UIProcess/qt/QtViewportHandler.cpp: Removed.
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::setViewportController):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
(WebKit::QtWebPageEventHandler::handleInputEvent):
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):
(WebKit::QtWebPageEventHandler::didFindZoomableArea):

  • UIProcess/qt/QtWebPageEventHandler.h:

(WebKit):
(QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::viewportController):

Tools:

Reviewed by Kenneth Rohde Christiansen.

Remove initial scale from viewport info item since it is
set to -1 after applied thus it does not hold any valuable
information.

  • MiniBrowser/qt/qml/ViewportInfoItem.qml:
3:13 AM Changeset in webkit [127719] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Renamed useYarrJIT() option to useRegExpJIT(). Also fixed regression in
which inadvertantly allows the ASM llint to use the baseline JIT when
useRegExpJIT() is true.
https://bugs.webkit.org/show_bug.cgi?id=95918.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-06
Reviewed by Geoffrey Garen.

  • runtime/JSGlobalData.cpp:

(JSC::enableAssembler):
(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::canUseJIT):
(JSC::JSGlobalData::canUseRegExpJIT):
(JSGlobalData):

  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/Options.h:

(JSC):

3:05 AM Changeset in webkit [127718] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source/WebCore

Add new V8DependentRetained that allows keeping a v8::Object alive as long as another v8::Object is alive
https://bugs.webkit.org/show_bug.cgi?id=95519

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-09-06
Reviewed by Adam Barth.

Add new V8DependentRetained that allows keeping a v8::Object alive as long as another
v8::Object is alive. This is useful for keeping callbacks attached to wrappers without
keeping strong references to v8::Objects in the C++ side which can result in leaks
when cycles are created.

No new tests needed, this will be used to fix MutationObservers which will have tests.

  • WebCore.gypi:
  • bindings/v8/V8DependentRetained.h: Added.

(WebCore):
(V8DependentRetained):
(WebCore::V8DependentRetained::V8DependentRetained):
(WebCore::V8DependentRetained::~V8DependentRetained):
(WebCore::V8DependentRetained::get): Gets the v8::Object value.
(WebCore::V8DependentRetained::isEmpty): Checks if the value is still alive.
(WebCore::V8DependentRetained::createPropertyName):
(WebCore::V8DependentRetained::ownerWeakCallback): Clear the value when the owner is released.
(WebCore::V8DependentRetained::valueWeakCallback):
(WebCore::V8DependentRetained::release):

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::hiddenReferenceName): Modified to allow creating hidden String or Symbol names.

  • bindings/v8/V8HiddenPropertyName.h:

(V8HiddenPropertyName):

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::V8PerIsolateData):

  • bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::nextDependentRetainedId): Returns the next available hidden property index.
(V8PerIsolateData):

2:54 AM Changeset in webkit [127717] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
2:52 AM Changeset in webkit [127716] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Removing String operator += uses in Cookie Files
https://bugs.webkit.org/show_bug.cgi?id=95884

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-06
Reviewed by Rob Buis.

Replacing all usages of String operator += in the Cookie code because it is being deprecated.
String concats are now done using + or StringBuilder.

PR 203054

Tested using Browser Test Cookie suite on browsertest01.rim.net/networking/cookies.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::upgradeTableIfNeeded):
(WebCore::CookieDatabaseBackingStore::invokeOpen):
(WebCore::CookieDatabaseBackingStore::invokeRemoveAll):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):

2:48 AM Changeset in webkit [127715] by danakj@chromium.org
  • 5 edits
    1 add in trunk/Source

[chromium] Add a copy() method to CCRenderPass
https://bugs.webkit.org/show_bug.cgi?id=95485

Reviewed by Adrienne Walker.

Source/WebCore:

This method allows the ubercomp layer to make a clone of its delegated
RenderPasses to insert into the current frame.

Tests: CCRenderPassTest.copyShouldBeIdenticalExceptIdAndQuads

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::copy):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCRenderPassTest.cpp: Added.

(CCTestRenderPass):
(CCTestRenderPass::quadList):
(CCTestRenderPass::sharedQuadStateList):
(CCRenderPassSize):
(TEST):

2:46 AM Changeset in webkit [127714] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Chromium Mac build fix after revision r127711
https://bugs.webkit.org/show_bug.cgi?id=95958

Unreviewed build fix.

This is a clear typo in the source file, so changing the function to
call locationModifiersFromWindowsKeyCode instead.

  • src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::keyboardEvent):

2:42 AM Changeset in webkit [127713] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] WebMemorySampler.cpp is included twice.
https://bugs.webkit.org/show_bug.cgi?id=95910

Reviewed by Kentaro Hara.

Now WebMemorySampler.cpp is in CMakeLists.txt and PlatformEfl.cmake.

  • PlatformEfl.cmake: Removed WebMemorySampler.cpp from source lists.
2:38 AM Changeset in webkit [127712] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

XMLHttpRequest.open does not need custom bindings
https://bugs.webkit.org/show_bug.cgi?id=95903

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Kentaro Hara.

There doesn't appear to be any reason that XMLHttpRequest.open needs
custom bindings now that [Optional] works the way XMLHttpRequest
expects.

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
(WebCore):
(WebCore::XMLHttpRequest::internalOpen):

  • xml/XMLHttpRequest.h:

(XMLHttpRequest):

  • xml/XMLHttpRequest.idl:
2:19 AM Changeset in webkit [127711] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source/WebKit/chromium

Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents
https://bugs.webkit.org/show_bug.cgi?id=94142

Patch by Raymes Khoury <raymes@chromium.org> on 2012-09-06
Reviewed by Tony Chang.

Previously we distinguished between left/right Shift/Ctrl/Alt in
WebInputEvents by using the location-specific virtual keycodes (e.g.
VK_LSHIFT instead of VK_SHIFT. However, the Windows API for key events
always returns the non-locational version (e.g. VK_SHIFT).
Furthermore, KeyboardEvent also returns
non-locational keycodes and separates the location information which
matches the behavior described in the DOM3
spec http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents. We
should be consistent with this in our representation of key events.
This patch changes WebInputEvents so they always store the
non-locational keycode and location information is stored in
modifiers. Since this only changes internal representation, no new
tests are added.

This patch also ensures that when KeyboardEvents are converted back to
WebInputEvents location information is preserved (which was not
happening before). This is important so that key location information
is passed on to plugins. A unittest is added for this.

  • WebKit.gypi:
  • public/WebInputEvent.h:

(WebKeyboardEvent):

  • src/WebInputEvent.cpp:

(WebKit):
(WebKit::WebKeyboardEvent::windowsKeyCodeWithoutLocation):
(WebKit::WebKeyboardEvent::locationModifiersFromWindowsKeyCode):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):

  • src/android/WebInputEventFactory.cpp:

(WebKit::WebInputEventFactory::keyboardEvent):

  • src/gtk/WebInputEventFactory.cpp:

(WebKit::WebInputEventFactory::keyboardEvent):

  • src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::keyboardEvent):

  • src/win/WebInputEventFactory.cpp:

(WebKit::getLocationModifier):
(WebKit::WebInputEventFactory::keyboardEvent):

  • tests/WebInputEventConversionTest.cpp: Added.
2:17 AM Changeset in webkit [127710] by commit-queue@webkit.org
  • 10 edits in trunk

Three XSLTProcessor functions don't need to be [Custom]
https://bugs.webkit.org/show_bug.cgi?id=95899

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Kentaro Hara.

Source/WebCore:

These functions are marked [Custom] because they predate our
improvements to [Optional]. Now that we have
[Optional=DefaultIsUndefined], we can autogenerate these functions.

There is a (slight!) difference in behavior. Now, in the case of a type
error, we return null instead of undefined. This change is unlikely to
cause compatibility problems because the vast majority of folks will
pass the correct arguments, and, in the few cases where folks pass the
wrong argument types, null and undefined will likely work similarly
(e.g., they're both falsy and throw when you try to access properties).

  • bindings/js/JSXSLTProcessorCustom.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::transformToDocument):
(WebCore::XSLTProcessor::transformToFragment):

  • xml/XSLTProcessor.h:

(WebCore::XSLTProcessor::importStylesheet):

  • xml/XSLTProcessor.idl:

LayoutTests:

Update results to show that we return null rather than undefined on a
type error.

  • fast/xsl/transform-xhr-doc-expected.txt:
  • fast/xsl/xslt-processor-expected.txt:
  • platform/chromium/fast/xsl/transform-xhr-doc-expected.txt:
2:02 AM Changeset in webkit [127709] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the failing tests.

  • platform/qt/Skipped:
1:56 AM Changeset in webkit [127708] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Remove String::operator+=() from plugin code
https://bugs.webkit.org/show_bug.cgi?id=95896

Reviewed by Adam Barth.

Use operator+() to concatenate strings instead of operator+=().

  • plugins/PluginView.cpp:

(WebCore::parseRFC822HeaderFields):

1:33 AM Changeset in webkit [127707] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for Interpreter after r127698.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

12:47 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt versions on the bots (diff)
12:47 AM Changeset in webkit [127706] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

More fixes for String::operator+=() in Debug mode
https://bugs.webkit.org/show_bug.cgi?id=95888

Patch by Patrick Gansterer <Patrick Gansterer> on 2012-09-06
Reviewed by Adam Barth.

Use StringBuilder to concatenate strings instead of operator+=().

  • dom/Element.cpp:

(WebCore::Element::formatForDebugger):

  • dom/Node.cpp:

(WebCore::appendAttributeDesc):
(WebCore::Node::showNode):
(WebCore::traverseTreeAndMark):
(WebCore::Node::formatForDebugger):

  • dom/Position.cpp:

(WebCore::Position::formatForDebugger):

  • dom/Range.cpp:

(WebCore):
(WebCore::Range::formatForDebugger):

  • dom/Text.cpp:

(WebCore::Text::formatForDebugger):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::formatForDebugger):

12:40 AM Changeset in webkit [127705] by vsevik@chromium.org
  • 15 edits in trunk

Web Inspector: Fix inconsistencies in NetworkUISourceCodeProvider implementation.
https://bugs.webkit.org/show_bug.cgi?id=95752

Reviewed by Alexander Pavlov.

Source/WebCore:

NetworkUISourceCodeProvider does not receive ResourceAdded event until resource is finished anymore.
StylesSourceMapping now listens for workspace event instead of being called directly by NetworkUISourceCodeProvider.
StylesSourceMapping is now created from inspector.js.
ProjectDidReset event introduced instead of setTimeout hacks in mappings.

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._projectWillReset):
(WebInspector.NetworkUISourceCodeProvider.prototype._projectDidReset):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._onRequestFinished):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._projectWillReset):
(WebInspector.ScriptSnippetModel.prototype._projectDidReset):

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.StylesSourceMapping.prototype._addUISourceCode):
(WebInspector.StylesSourceMapping.prototype._reset):

  • inspector/front-end/Workspace.js:

(WebInspector.WorkspaceController.prototype._mainFrameNavigated):
(WebInspector.Project.prototype.reset):

  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/network/network-request-revision-content-expected.txt:
  • http/tests/inspector/network/network-request-revision-content.html:
  • inspector/console/console-uncaught-exception-expected.txt:
  • inspector/debugger/network-uisourcecode-provider-expected.txt:
  • inspector/debugger/network-uisourcecode-provider.html:
  • inspector/debugger/script-snippet-model.html:
  • inspector/debugger/scripts-panel.html:
12:35 AM Changeset in webkit [127704] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly.
https://bugs.webkit.org/show_bug.cgi?id=91110

Reviewed by Tony Chang.

Source/WebKit/chromium:

Prior to this patch, we were ignoring the user-scalable property of
viewport meta tags. This patch enforces the user-scalable property by
claming the minimum-scale and maximum-scale values, effectively
preventing user scaling. This approach isn't perfect, as discussed in
https://bugs.webkit.org/show_bug.cgi?id=70609, but it is an improvement
over the status quo.

This approach is also used by EFL, GTK, and Qt.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

LayoutTests:

Test that the scale limits are clamped when user-scalable is set to no.

  • fast/viewport/viewport-limits-adjusted-for-no-user-scale-control-expected.txt: Added.
  • fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html: Added.
  • fast/viewport/viewport-limits-adjusted-for-no-user-scale-expected.txt: Added.
  • fast/viewport/viewport-limits-adjusted-for-no-user-scale.html: Added.
12:28 AM Changeset in webkit [127703] by vsevik@chromium.org
  • 12 edits in trunk

Unreviewed, rolling out r127700.
http://trac.webkit.org/changeset/127700
https://bugs.webkit.org/show_bug.cgi?id=95941

Breaks inspector closure compilation, uses not defined
variables. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

Source/WebCore:

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
12:28 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
12:21 AM Changeset in webkit [127702] by abarth@webkit.org
  • 3 edits in trunk/Source/WTF

Remove WTF::String::operator+=
https://bugs.webkit.org/show_bug.cgi?id=95797

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Sam Weinig.

This patch encloses WTF::String::operator+= in an ifdef so that we can
gradually remove it from the various port-specific files. The ifdef
lets us whitelist use of operator+= in individual files during the
transition.

  • wtf/Platform.h
  • wtf/text/WTFString.h:
12:16 AM Changeset in webkit [127701] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[V8] V8HTMLDocument has two out-of-style function names
https://bugs.webkit.org/show_bug.cgi?id=95893

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Kentaro Hara.

Just a simple style cleanup.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getter):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::wrapInShadowObject):
(WebCore::V8HTMLDocument::getNamedProperty):

Sep 5, 2012:

11:49 PM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
11:48 PM Changeset in webkit [127700] by commit-queue@webkit.org
  • 12 edits in trunk

Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-05
Reviewed by Alexander Pavlov.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::reset):
(WebCore):
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::scheduleFor):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::regionLayoutUpdated):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):

  • inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
11:26 PM Changeset in webkit [127699] by danakj@chromium.org
  • 7 edits
    1 add in trunk/Source

[chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
https://bugs.webkit.org/show_bug.cgi?id=95374

Reviewed by Adrienne Walker.

Source/WebCore:

The ubercomp layer will hold a RenderPass full of DrawQuads, and needs
to add quads to the current frame in appendQuads(). It will do this by
copying the quads it has in its RenderPass into the frame's RenderPass.

These methods allows it to make a clone of its quads.

Test: CCDrawQuadTest.copySharedQuadState

CCDrawQuadTest.copyCheckerboardDrawQuad
CCDrawQuadTest.copyDebugBorderDrawQuad
CCDrawQuadTest.copyIOSurfaceDrawQuad
CCDrawQuadTest.copyRenderPassDrawQuad
CCDrawQuadTest.copySolidColorDrawQuad
CCDrawQuadTest.copyStreamVideoDrawQuad
CCDrawQuadTest.copyTextureDrawQuad
CCDrawQuadTest.copyTileDrawQuadcopy
CCDrawQuadTest.copyYUVVideoDrawQuad

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::copy):
(WebCore):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(CCDrawQuad):

  • platform/graphics/chromium/cc/CCSharedQuadState.cpp:

(WebCore::CCSharedQuadState::copy):
(WebCore):

  • platform/graphics/chromium/cc/CCSharedQuadState.h:

(CCSharedQuadState):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCDrawQuadTest.cpp: Added.

(TEST):
(createSharedQuadState):
(compareDrawQuad):

11:17 PM Changeset in webkit [127698] by ggaren@apple.com
  • 17 edits in trunk

Named functions should not allocate scope objects for their names
https://bugs.webkit.org/show_bug.cgi?id=95659

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

In most cases, we can merge a function expression's name into its symbol
table. This reduces memory footprint per closure from three objects
(function + activation + name scope) to two (function + activation),
speeds up closure allocation, and speeds up recursive calls.

In the case of a named function expression that contains a non-strict
eval, the rules are so bat-poop crazy that I don't know how to model
them without an extra object. Since functions now default to not having
such an object, this case needs to allocate the object on function
entry.

Therefore, this patch makes the slow case a bit slower so the fast case
can be faster and more memory-efficient. (Note that the slow case already
allocates an activation on entry, and until recently also allocated a
scope chain node on entry, so adding one allocation on entry shouldn't
break the bank.)

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock): Caught a missed initializer. No behavior change.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): Put the callee in static scope
during compilation so it doesn't need to be in dynamic scope at runtime.

(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::addCallee): Helper functions for either statically
resolving the callee or adding a dynamic scope that will resolve to it,
depending on whether you're in the fast path.

We move the callee into a var location if it's captured because activations
prefer to have contiguous ranges of captured variables.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::registerFor):
(BytecodeGenerator):

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL): This is the point of the patch: remove
one allocation in the case of a named function expression.

  • parser/Parser.cpp:

(JSC::::Parser):

  • parser/Parser.h:

(JSC::Scope::declareCallee):
(Scope):
(Parser):
(JSC::parse):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode): Pipe the callee's name through
the parser so we get accurate information on whether the callee was captured.

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode):

  • runtime/Executable.h:

(JSC::FunctionExecutable::create):
(FunctionExecutable):
(JSC::FunctionExecutable::finishCreation): I had to refactor function
creation to support the following function constructor quirk: the function
gets a name, but its name is not in lexical scope.

To simplify this, FunctionExecutable now automatically extracts all the
data it needs from the parsed node. The special "fromGlobalCode" path
used by the function constructor creates an anonymous function, and then
quirkily sets the value used by the .name property to be non-null, even
though the parsed name is null.

  • runtime/JSNameScope.h:

(JSC::JSNameScope::create):
(JSC::JSNameScope::JSNameScope): Added support for explicitly specifying
your container scope. The compiler uses this for named function expressions.

LayoutTests:

Added coverage for some extra-tricky cases.

  • fast/js/named-function-expression-expected.txt:
  • fast/js/script-tests/named-function-expression.js:

(shouldBeTrueWithDescription): I rolled my own shouldBeTrue() here to avoid the
built-in shouldBe()'s eval scoping, which can change the variable
resolution rules I'm trying to test.

  • inspector/debugger/debugger-expand-scope-expected.txt: Not sure why this

result used to miss the function name scope, but the new result is a
progression, so I've updated the expected results.

11:06 PM Changeset in webkit [127697] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new fasiling tests.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt/Skipped:
10:57 PM Changeset in webkit [127696] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed; revert a change to ScrollingTreeNodeMac which accidentally
slipped into http://trac.webkit.org/changeset/127474.

This change will be properly landed shortly as part of
https://bugs.webkit.org/show_bug.cgi?id=93898.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::update):

10:51 PM Changeset in webkit [127695] by Nate Chapin
  • 11 edits in trunk/Source/WebCore

Remove duplicate error() impls in CachedResource subclasses
https://bugs.webkit.org/show_bug.cgi?id=81161

Reviewed by Antti Koivisto.

No new tests, refactor only.

  • loader/cache/CachedCSSStyleSheet.cpp:
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedResource.h: Make checkNotify()

virtual, so the right checkNotify() gets called in error().

  • loader/cache/CachedScript.cpp:
  • loader/cache/CachedScript.h:
  • loader/cache/CachedXSLStyleSheet.cpp:
  • loader/cache/CachedXSLStyleSheet.h:
10:41 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Move section on migrating to unprefixed line-break. (diff)
10:41 PM LineBreaking edited by glenn@skynav.com
Move section on migrating to unprefixed line-break. (diff)
10:37 PM Changeset in webkit [127694] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt] platform/qt/plugins/qt-qwidget-plugin.html fails
https://bugs.webkit.org/show_bug.cgi?id=92141

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-09-05
Reviewed by Simon Hausmann.

Only Qt WK2 does not support Qt plugins. Moving skip to proper place.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:

Updated test to point to a existing image.

  • platform/qt/plugins/qt-qwidget-plugin.html:
10:28 PM Changeset in webkit [127693] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed chromium windows build fix.

Some of the rules in webcore_remaining only apply to files under WebCore/platform/. Since r127687 moved all such
files from the webcore_files variable to webcore_platform_files, these rules have to be applied to
webcore_platform instead. This also means that these files link into webcore_platform instead of
webcore_remaining, which makes a lot more sense, and we can delete several redundant rules.

  • WebCore.gyp/WebCore.gyp:
10:10 PM Changeset in webkit [127692] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed gardening

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F): Disabled applyScrollToScrollableArea()

10:06 PM Changeset in webkit [127691] by tony@chromium.org
  • 4 edits in trunk

[chromium] Remove dependency on webkit_user_agent
https://bugs.webkit.org/show_bug.cgi?id=95886

Reviewed by Adam Barth.

Source/WebKit/chromium:

The code isn't used by webkit_unit_tests.

  • WebKitUnitTests.gyp:

Tools:

The code isn't used by DumpRenderTree.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
9:48 PM Changeset in webkit [127690] by Nate Chapin
  • 4 edits in trunk/Source

Source/WebCore: [chromium] Some SubstituteData loads broken after r121912
https://bugs.webkit.org/show_bug.cgi?id=91685

Reviewed by Adam Barth.

Test: WebFrameTest.ReplaceNavigationAfterHistoryNavigation in chromium's webkit_unit_tests.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData): receivedFirstData() should be called exactly once per load,

on the first commit. I had mistakely assumed in r121912 that isReplacing() was true only for multipart
loads, and only after the first commit (chromium uses it for some SubstituteData loads to ensure the error page
replaces the failed load). We need to check whether we are loading multipart content before assuming isReplacing()
will tell us what we need to know.

Source/WebKit/chromium: Test for https://bugs.webkit.org/show_bug.cgi?id=91685

Reviewed by Adam Barth.

  • tests/WebFrameTest.cpp:
9:46 PM Changeset in webkit [127689] by commit-queue@webkit.org
  • 7 edits in trunk

Source/WebKit/chromium: Use new type-specific WebGestureEvent fields
https://bugs.webkit.org/show_bug.cgi?id=95573

Patch by Rick Byers <rbyers@chromium.org> on 2012-09-05
Reviewed by James Robinson.

Chromium has been updated to store gesture-type specific details in the
new WebGestureEvent fields (crrev.com/152508, crrev.com/154815 and
crrev.com/154959), so we can now rely on them.

  • src/WebCompositorInputHandlerImpl.cpp:

Update the compositor scroll, pinch and fling handling to use these new fields.
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):

  • src/WebInputEventConversion.cpp:

Update PlatformGestureEvent/WebGestureEvent conversion to use the new
fields, storing into the existing overloaded PlatformGestureEvent
fields (which will be cleaned up in my next CL).
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
Update fling scrolling implementation for correct location of velocity.

  • tests/WebCompositorInputHandlerImplTest.cpp:

(WebKit::TEST_F):
Update tests to use the new fields.

Tools: Update chromium DumpRenderTree for new WebGestureEvent fields
https://bugs.webkit.org/show_bug.cgi?id=95573

Patch by Rick Byers <rbyers@chromium.org> on 2012-09-05
Reviewed by James Robinson.

Update EventSender to write gesture details into the appropriate
type-specific WebGestureEvent fields.

  • DumpRenderTree/chromium/TestRunner/EventSender.cpp:

(EventSender::gestureEvent):
(EventSender::gestureFlingStart):

9:37 PM Changeset in webkit [127688] by dpranke@chromium.org
  • 2 edits in trunk/Tools

NRWT lies about the number of tests that it's skipping when used with --repeat-each
https://bugs.webkit.org/show_bug.cgi?id=95789

Reviewed by Ojan Vafai.

Fix miscalculation in log message.

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_found):

9:27 PM Changeset in webkit [127687] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
https://bugs.webkit.org/show_bug.cgi?id=95876

Reviewed by Tony Chang.

This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
8:58 PM Changeset in webkit [127686] by ryuan.choi@samsung.com
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] Implement missing feature to support <select> tag
https://bugs.webkit.org/show_bug.cgi?id=95708

Reviewed by Gyuyoung Kim.

Added missing APIs for select tag.

This patch provides all functionality of current WebPopupItem to applications.

  • UIProcess/API/efl/ewk_popup_menu_item.cpp:

(_Ewk_Popup_Menu_Item):
(_Ewk_Popup_Menu_Item::_Ewk_Popup_Menu_Item):
(ewk_popup_menu_item_new):
(ewk_popup_menu_item_text_direction_get):
(ewk_popup_menu_item_text_direction_override_get):
(ewk_popup_menu_item_tooltip_get):
(ewk_popup_menu_item_accessibility_text_get):
(ewk_popup_menu_item_enabled_get):
(ewk_popup_menu_item_is_label_get):
(ewk_popup_menu_item_selected_get):

  • UIProcess/API/efl/ewk_popup_menu_item.h:
  • UIProcess/API/efl/ewk_popup_menu_item_private.h:
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_popup_menu_request):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(checkBasicPopupMenuItem):
(showPopupMenu): Updated test case to cover new APIs.
(TEST_F):

8:54 PM Changeset in webkit [127685] by jsbell@chromium.org
  • 3 edits
    3 adds in trunk

IndexedDB: Large integer versions not persisted correctly
https://bugs.webkit.org/show_bug.cgi?id=95873

Reviewed by Tony Chang.

Source/WebCore:

Correctly encode AND decode integer versions numbers as VarInts.

Test: storage/indexeddb/intversion-encoding.html

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::getVarInt):
(WebCore):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):

LayoutTests:

Verify large integer versions that encode differently as Ints vs. VarInts.

  • storage/indexeddb/intversion-encoding-expected.txt: Added.
  • storage/indexeddb/intversion-encoding.html: Added.
  • storage/indexeddb/resources/intversion-encoding.js: Added.

(test):
(openFirstTime.request.onupgradeneeded):
(openFirstTime.request.onsuccess):
(openFirstTime):
(openSecondTime.request.onsuccess):
(openSecondTime):

8:20 PM Changeset in webkit [127684] by commit-queue@webkit.org
  • 10 edits
    22 deletes in trunk

Unreviewed, rolling out r127596.
http://trac.webkit.org/changeset/127596
https://bugs.webkit.org/show_bug.cgi?id=95928

newly added tests are failing (Requested by bashi1 on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-05

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth):

  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

  • fast/regions/autowidth-abspos-expected.html: Removed.
  • fast/regions/autowidth-abspos-regionchain-expected.html: Removed.
  • fast/regions/autowidth-abspos-regionchain.html: Removed.
  • fast/regions/autowidth-abspos.html: Removed.
  • fast/regions/autowidth-float-expected.html: Removed.
  • fast/regions/autowidth-float.html: Removed.
  • fast/regions/autowidth-inlineblock-expected.html: Removed.
  • fast/regions/autowidth-inlineblock.html: Removed.
  • fast/regions/autowidth-nonreplaced-abspos-expected.html: Removed.
  • fast/regions/autowidth-nonreplaced-abspos.html: Removed.
  • fast/regions/autowidth-nonreplacedblock-normalflow-expected.html: Removed.
  • fast/regions/autowidth-nonreplacedblock-normalflow.html: Removed.
  • fast/regions/autowidth-normalflow-expected.html: Removed.
  • fast/regions/autowidth-normalflow-maxwidth-expected.html: Removed.
  • fast/regions/autowidth-normalflow-maxwidth.html: Removed.
  • fast/regions/autowidth-normalflow-minmaxwidth-expected.html: Removed.
  • fast/regions/autowidth-normalflow-minmaxwidth.html: Removed.
  • fast/regions/autowidth-normalflow-minwidth-expected.html: Removed.
  • fast/regions/autowidth-normalflow-minwidth.html: Removed.
  • fast/regions/autowidth-normalflow-vertrl-expected.html: Removed.
  • fast/regions/autowidth-normalflow-vertrl.html: Removed.
  • fast/regions/autowidth-normalflow.html: Removed.
  • fast/regions/bottom-overflow-out-of-first-region.html:
  • fast/regions/flows-dependency-dynamic-remove.html:
  • fast/regions/flows-dependency-same-flow.html:
  • fast/regions/render-region-renderer-expected.html:
  • fast/regions/top-overflow-out-of-second-region.html:
8:14 PM Changeset in webkit [127683] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build failure with accelerated compositing disabled
https://bugs.webkit.org/show_bug.cgi?id=95872

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-09-05
Reviewed by James Robinson.

Define DrawingBuffer::markContextChanged even when accelerated
compositing is not used.

No functional change, so no new tests.

  • platform/graphics/gpu/DrawingBuffer.h:

(WebCore::DrawingBuffer::markContentsChanged):
(DrawingBuffer):

7:54 PM Changeset in webkit [127682] by Michelangelo De Simone
  • 16 edits
    2 adds in trunk

Parse the array() function for custom filters
https://bugs.webkit.org/show_bug.cgi?id=94226

Reviewed by Dirk Schulze.

Source/WebCore:

The patch adds the support for the array() function parsing;
according to the specs this function - to be used within custom
filters - accepts number (float) values. This patch parses array()
arguments using comma as separator: the spec will be updated
accordingly shortly.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCustomFilterArrayFunction): New method to
parse the content of array() function.
(WebCore):
(WebCore::CSSParser::parseCustomFilter): parseCustomFilterArrayFunction is
called whenever a "array(" function is encountered.

  • css/CSSParser.h:

(WebCore):

  • css/CSSValue.cpp:

(WebCore::CSSValue::reportMemoryUsage):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

  • css/CSSValue.h:

(WebCore::CSSValue::isWebKitCSSArrayFunctionValue):

  • css/WebKitCSSArrayFunctionValue.cpp: Added.

(WebCore):
(WebCore::WebKitCSSArrayFunctionValue::WebKitCSSArrayFunctionValue):
(WebCore::WebKitCSSArrayFunctionValue::customCssText):
(WebCore::WebKitCSSArrayFunctionValue::cloneForCSSOM):
(WebCore::WebKitCSSArrayFunctionValue::reportDescendantMemoryUsage):

  • css/WebKitCSSArrayFunctionValue.h: Added.

(WebCore):
(WebKitCSSArrayFunctionValue):
(WebCore::WebKitCSSArrayFunctionValue::create):

LayoutTests:

New negative and positive test cases have been added for the array()
function parsing.

Also a new test case has been added to further test multiple 3d-transforms.

  • css3/filters/custom/custom-filter-property-parsing-expected.txt:
  • css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
  • css3/filters/script-tests/custom-filter-property-parsing.js:
  • platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:
7:24 PM Changeset in webkit [127681] by commit-queue@webkit.org
  • 13 edits
    2 copies
    2 adds in trunk

Vertically center non-anchored <dialog> elements
https://bugs.webkit.org/show_bug.cgi?id=90670

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-09-05
Reviewed by Ojan Vafai.

Source/WebCore:

This adjusts the static default position of non-anchored
dialog elements so they are vertically centered in or at the top of
the viewport, as per the spec.

The approach is to add a RenderDialog class whose layout()
function adjusts the position after normal RenderBlock::layout runs.

Test: fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::createRenderer):
(WebCore):

  • html/HTMLDialogElement.h:

(HTMLDialogElement):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapAbsoluteToLocalPoint): Remove assertion since now absoluteToLocal is called during layout.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint): Ditto.

  • rendering/RenderDialog.cpp: Added.

(WebCore):
(WebCore::RenderDialog::layout): Compute the desired top position in the absolute coordinate system, and then set top to the
corresponding local coordinate.

  • rendering/RenderDialog.h: Added.

(WebCore):
(RenderDialog):
(WebCore::RenderDialog::RenderDialog):
(WebCore::RenderDialog::~RenderDialog):
(WebCore::RenderDialog::renderName):

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::isDialog):

  • rendering/RenderingAllInOne.cpp:

LayoutTests:

  • fast/dom/HTMLDialogElement/non-anchored-dialog-positioning-expected.txt: Added.
  • fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html: Added.
7:12 PM Changeset in webkit [127680] by jason.liu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove feature about:cache/disable and about:cache/enable
https://bugs.webkit.org/show_bug.cgi?id=95820

Reviewed by Rob Buis.

Remove this feature since we need to add a button in settings.

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::cachePage):

7:11 PM Changeset in webkit [127679] by bashi@chromium.org
  • 25 edits
    9 deletes in trunk

Unreviewed, rolling out r127612, r127660, and r127664.
http://trac.webkit.org/changeset/127612
http://trac.webkit.org/changeset/127660
http://trac.webkit.org/changeset/127664
https://bugs.webkit.org/show_bug.cgi?id=95920

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCVoidRequest.h: Removed.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCErrorCallback.h:

(WebCore):
(RTCErrorCallback):

  • Modules/mediastream/RTCErrorCallback.idl:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):

  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCSessionDescriptionCallback.h:

(WebCore):
(RTCSessionDescriptionCallback):

  • Modules/mediastream/RTCSessionDescriptionCallback.idl:
  • Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:

(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::clear):

  • Modules/mediastream/RTCSessionDescriptionRequestImpl.h:

(RTCSessionDescriptionRequestImpl):

  • Modules/mediastream/RTCVoidRequestImpl.cpp: Removed.
  • Modules/mediastream/RTCVoidRequestImpl.h: Removed.
  • WebCore.gypi:
  • platform/chromium/support/WebRTCVoidRequest.cpp: Removed.
  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::RTCPeerConnectionHandlerDummy):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(WebCore::RTCPeerConnectionHandler::~RTCPeerConnectionHandler):
(RTCPeerConnectionHandler):
(WebCore::RTCPeerConnectionHandler::RTCPeerConnectionHandler):

  • platform/mediastream/RTCVoidRequest.h: Removed.
  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::createOffer):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):
(SuccessCallbackTask):
(FailureCallbackTask):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Removed.
  • fast/mediastream/RTCPeerConnection-localDescription.html: Removed.
  • fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Removed.
  • fast/mediastream/RTCPeerConnection-remoteDescription.html: Removed.
7:07 PM Changeset in webkit [127678] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
https://bugs.webkit.org/show_bug.cgi?id=95819

Patch by James Robinson <jamesr@chromium.org> on 2012-09-05
Reviewed by Adam Barth.

This unit test doesn't do all that much, but it does verify that WebSolidColorLayer doesn't completely explode
upon use and also makes sure that the WebSolidColorLayer::create() symbol is referenced and not dropped from
webkit.dll in the component build.

  • tests/WebLayerTest.cpp:
7:03 PM Changeset in webkit [127677] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove deprecated dialog connections.
https://bugs.webkit.org/show_bug.cgi?id=95868

Reviewed by Rob Buis.

PR 187481.
Remove deprecated logic for unsupported
Dialog types.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::openColorPopup):

7:02 PM Changeset in webkit [127676] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

a = data[a]++; sets the wrong key in data
https://bugs.webkit.org/show_bug.cgi?id=91270

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Postfix inc/dec is unsafely using finalDestination, can trample base/subscript prior to the result being put.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitResolve):

  • Remove redundant parens.

(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):

  • Refactored to use tempDestination instead of finalDestination.

(JSC::PrefixNode::emitBracket):
(JSC::PrefixNode::emitDot):

  • Should be using emitPreIncOrDec.

LayoutTests:

Added test cases.

  • fast/js/post-inc-assign-overwrites-expected.txt: Added.
  • fast/js/post-inc-assign-overwrites.html: Added.
  • fast/js/script-tests/post-inc-assign-overwrites.js: Added.

(postIncDotAssignToBase):
(postIncBracketAssignToBase):
(postIncBracketAssignToSubscript):

6:58 PM Changeset in webkit [127675] by vrk@chromium.org
  • 13 edits
    2 adds in trunk

Add the duration attribute to MediaSource
https://bugs.webkit.org/show_bug.cgi?id=95149

Reviewed by Eric Carlson.

Add support for the duration attribute recently added to the MediaSource spec.
http://dev.w3.org/html5/spec/media-elements.html#dom-media-duration

Source/WebCore:

Test: http/tests/media/media-source/video-media-source-duration-changed.html

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::duration): Added duration method.
(WebCore):
(WebCore::MediaSource::setDuration): Added duration setter.

  • Modules/mediasource/MediaSource.h:

(MediaSource):

  • Modules/mediasource/MediaSource.idl:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::sourceSetDuration): Add empty definition.
(WebCore::MediaPlayer::sourceSetDuration): Forward call to m_private.
(WebCore):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::sourceSetDuration): Add empty definition.

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::sourceSetDuration): Add empty definition.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::sourceSetDuration): Forward call to m_webMediaPlayer.
(WebKit):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

  • http/tests/media/media-source/media-source.js:

(MediaSourceTest.SegmentHelper): Add parameter to specify whether full file should be loaded.
(MediaSourceTest.SegmentHelper.prototype.appendAllMediaSegments): Added method to append all file segments.
(MediaSourceTest.roundedEquals_): Added to see if values are equivalent after rounding.
(MediaSourceTest.expectDuration): Added to check for expected duration.
(MediaSourceTest.expectBufferedRange): Added to check for the expected buffered attribute value.

  • http/tests/media/media-source/video-media-source-duration-changed-expected.txt: Added.
  • http/tests/media/media-source/video-media-source-duration-changed.html: Added.
6:32 PM Changeset in webkit [127674] by mihaip@chromium.org
  • 7 edits in trunk/Source

[Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime
https://bugs.webkit.org/show_bug.cgi?id=95865

Reviewed by Darin Fisher.

Source/WebCore:

r55549 made them be runtime-enabled (since the Chromium implementation
was not complete at the time), but they've been enabled by default
since http://crrev.com/41850

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • page/History.idl:

Source/WebKit/chromium:

Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into
no-ops.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enablePushState):
(WebKit::WebRuntimeFeatures::isPushStateEnabled):

6:31 PM Changeset in webkit [127673] by bashi@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] unreviewed gardening after r127564

Added missing text expectation.

  • fast/forms/datetime/datetime-interactive-validation-required-expected.txt: Added.
6:16 PM Changeset in webkit [127672] by jamesr@google.com
  • 8 edits in trunk/Source

[chromium] Move static WebCompositor functions to WebCompositorSupport
https://bugs.webkit.org/show_bug.cgi?id=95785

Reviewed by Darin Fisher.

The statics on WebCompositor need to be moved to WebCompositorSupport so the embedder can inject an
implementation for these via PlatformSupport. This adds the interface for the statics to WebCompositorSupport.
After an implementation of these lands on the chromium side, I'll switch all callers over to use these and
remove the WebCompositor interface from the API.

  • chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):
(WebKit::WebCompositorSupport::initialize):
(WebKit::WebCompositorSupport::threadingEnabled):
(WebKit::WebCompositorSupport::shutdown):
(WebKit::WebCompositorSupport::setPerTilePaintingEnabled):
(WebKit::WebCompositorSupport::setPartialSwapEnabled):
(WebKit::WebCompositorSupport::setAcceleratedAnimationEnabled):

6:16 PM Changeset in webkit [127671] by staikos@webkit.org
  • 2 edits in trunk

[BlackBerry] Match th ebuild flags from the platform library
https://bugs.webkit.org/show_bug.cgi?id=95423

Reviewed by Antonio Gomes.

Unaligned build flags can cause crashes and other strange behavior.
These two were not defined here but were defined on the system.

  • Source/cmake/OptionsBlackBerry.cmake:
6:11 PM Changeset in webkit [127670] by staikos@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Assignment operators missing self-check
https://bugs.webkit.org/show_bug.cgi?id=95774

Reviewed by Rob Buis.

Add a test for self-assignment.

  • Api/WebAnimation.cpp:

(BlackBerry::WebKit::WebAnimation::operator=):

  • Api/WebString.cpp:

(BlackBerry::WebKit::WebString::operator=):

6:07 PM Changeset in webkit [127669] by jsbell@chromium.org
  • 3 edits
    3 adds in trunk

IndexedDB: Integer version lost after first open/close/open cycle
https://bugs.webkit.org/show_bug.cgi?id=95864

Reviewed by Tony Chang.

Source/WebCore:

New backing stores were being created with an old schema version, causing migration
to occur when the backing store was re-opened, which would overwrite valid integer
version metadata. New backing stores should be created with the latest schema version
since no migration is desired.

Test: storage/indexeddb/intversion-persistence.html

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::setUpMetadata):

LayoutTests:

Ensure integer versions are persisted across open/close/open cycles.

Note that although this is a useful and valid test in general, the specific bug that
prompted adding this test will only repro if the origin has no pre-existing backing
store, which is not guaranteed by DRT or other shells. See http://webkit.org/b/92166

  • storage/indexeddb/intversion-persistence-expected.txt: Added.
  • storage/indexeddb/intversion-persistence.html: Added.
  • storage/indexeddb/resources/intversion-persistence.js: Added.

(test):
(openFirstTime.request.onupgradeneeded):
(openFirstTime.request.onsuccess):
(openFirstTime):
(openSecondTime.request.onsuccess):
(openSecondTime):

6:01 PM Changeset in webkit [127668] by yosin@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Tests] We should have mouse events test for multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=95829

Reviewed by Kent Tamura.

This patch adds test cases of mouse actions on multiple fields time
input UI.

The test checks:

  • Mouse click to set focus to field under mouse pointer
  • Mouse click on spin button

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

  • fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html: Added.
6:00 PM Changeset in webkit [127667] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] unreviewed test expectation update

  • platform/chromium/TestExpectations:
5:55 PM Changeset in webkit [127666] by barraclough@apple.com
  • 4 edits
    3 adds in trunk

Bug, assignment within subscript of prefix/postfix increment of bracket access
https://bugs.webkit.org/show_bug.cgi?id=95913

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

javascript:alert((function(){ var a = { x:1 }; var b = { x:1 }; a[a=b,"x"]++; return a.x; })())

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitBracket):
(JSC::PrefixNode::emitBracket):

  • Should check for assigments in the subscript when loading the base.
  • parser/Nodes.h:

(JSC::BracketAccessorNode::subscriptHasAssignments):
(BracketAccessorNode):

  • Used by emitBracket methods.

LayoutTests:

Added test cases.

  • fast/js/inc-bracket-assign-subscript-expected.txt: Added.
  • fast/js/inc-bracket-assign-subscript.html: Added.
  • fast/js/script-tests/inc-bracket-assign-subscript.js: Added.

(testPreIncBracketAccessWithAssignSubscript):
(testPostIncBracketAccessWithAssignSubscript):

  • Tests a pre/post increment to a bracket access, where subscript contains assignment.
5:52 PM Changeset in webkit [127665] by Lucas Forschler
  • 1 delete in tags/Safari-536.26.14

Remove Tag.

5:19 PM Changeset in webkit [127664] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed, build fix attempt after r127660

Make clang happy.

  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(WebCore::RTCPeerConnectionHandlerDummy::RTCPeerConnectionHandlerDummy):
Use ASSERT_UNUSED() to suppress -Wunused-private-field warning

5:18 PM Changeset in webkit [127663] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.14

New Tag.

5:12 PM Changeset in webkit [127662] by mitz@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Renamed a misnamed expected result.

  • platform/mac/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Copied from LayoutTests/platform/mac/compositing/overflow/overflow-with-touch-toggle-expected.txt.
  • platform/mac/compositing/overflow/overflow-with-touch-toggle-expected.txt: Removed.
4:53 PM Changeset in webkit [127661] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for Windows.

  • rendering/RenderThemeWin.cpp: Added missing header include.
4:34 PM Changeset in webkit [127660] by bashi@chromium.org
  • 4 edits in trunk/Source/WebCore

[Chromium] Unreviewed, build fix attempt on win

r127612 breaks chromium win build.

  • WebCore.gypi:
  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(WebCore::RTCPeerConnectionHandler::RTCPeerConnectionHandler):
(WebCore):
(WebCore::RTCPeerConnectionHandler::~RTCPeerConnectionHandler):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(RTCPeerConnectionHandler):

4:12 PM Changeset in webkit [127659] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1229

Merge 126251
BUG=137413
Review URL: https://chromiumcodereview.appspot.com/10909089

4:10 PM Changeset in webkit [127658] by cevans@google.com
  • 2 edits in branches/chromium/1229/Source/WebCore/rendering

Merge 126107
BUG=137413
Review URL: https://chromiumcodereview.appspot.com/10916130

4:08 PM Changeset in webkit [127657] by cevans@google.com
  • 10 edits in branches/chromium/1229/Source/WebCore/rendering

Merge 126048
BUG=137413
Review URL: https://chromiumcodereview.appspot.com/10911116

4:05 PM Changeset in webkit [127656] by cevans@google.com
  • 9 edits in branches/chromium/1229/Source/WebCore/rendering

Merge 125737
BUG=137413
Review URL: https://chromiumcodereview.appspot.com/10914111

4:04 PM Changeset in webkit [127655] by commit-queue@webkit.org
  • 9 edits
    1 move
    1 delete in trunk

[EFL][WK2] Provide implementation for WebProcess functions
https://bugs.webkit.org/show_bug.cgi?id=95857

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add implementation for getVolumeFreeSizeForPath()
in FileSystem which is required by soup-related
code in WebKit2.

No new tests, no behavior change.

  • platform/FileSystem.h:

(WebCore):

  • platform/efl/FileSystemEfl.cpp:

(WebCore::getVolumeFreeSizeForPath):
(WebCore):

Source/WebKit2:

Rename WebProcessGtk to WebProcessSoup and reuse it in
EFL port since all the code is soup-related. We now
have a proper implementation for the WebProcess
platform methods.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • WebProcess/efl/WebProcessEfl.cpp: Removed.
  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl): Enable soup cache for the soup session similarly to GTK port.

  • WebProcess/soup/WebProcessSoup.cpp: Renamed from Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp.

(WebKit):
(WebKit::getCacheDiskFreeSize):
(WebKit::getMemorySize):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformClearResourceCaches):
(WebKit::buildAcceptLanguages):
(WebKit::setSoupSessionAcceptLanguage):
(WebKit::languageChanged):
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):

LayoutTests:

Unskip several test cases that are now passing on
WK2 EFL since WebProcess platform functions have been
implemented.

  • platform/efl-wk2/TestExpectations:
4:00 PM Changeset in webkit [127654] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Merge prefix/postfix nodes
https://bugs.webkit.org/show_bug.cgi?id=95898

Reviewed by Geoff Garen.

Simplify the AST.
This will also mean we have access to m_subscriptHasAssignments when generating a prefix/postfix op applied to a bracket access.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitResolve):

  • was PostfixResolveNode::emitBytecode

(JSC::PostfixNode::emitBracket):

  • was PostfixBracketNode::emitBytecode

(JSC::PostfixNode::emitDot):

  • was PostfixDotNode::emitBytecode

(JSC::PostfixNode::emitBytecode):

  • was PostfixErrorNode::emitBytecode, call resolve/bracket/dot version as appropriate.

(JSC::PrefixNode::emitResolve):

  • was PrefixResolveNode::emitBytecode

(JSC::PrefixNode::emitBracket):

  • was PrefixBracketNode::emitBytecode

(JSC::PrefixNode::emitDot):

  • was PrefixDotNode::emitBytecode

(JSC::PrefixNode::emitBytecode):

  • was PrefixErrorNode::emitBytecode, call resolve/bracket/dot version as appropriate.
  • parser/ASTBuilder.h:

(JSC::ASTBuilder::makePrefixNode):

  • Just makes a PrefixNode!

(JSC::ASTBuilder::makePostfixNode):

  • Just makes a PostfixNode!
  • parser/NodeConstructors.h:

(JSC::PostfixNode::PostfixNode):

  • Added, merge of PostfixResolveNode/PostfixBracketNode/PostfixDotNode/PostfixErrorNode.

(JSC::PrefixNode::PrefixNode):

  • Added, merge of PrefixResolveNode/PrefixBracketNode/PrefixDotNode/PrefixErrorNode.
  • parser/Nodes.h:

(PostfixNode):

  • Added, merge of PostfixResolveNode/PostfixBracketNode/PostfixDotNode/PostfixErrorNode.

(PrefixNode):

  • Added, merge of PrefixResolveNode/PrefixBracketNode/PrefixDotNode/PrefixErrorNode.
3:55 PM Changeset in webkit [127653] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r127635.
http://trac.webkit.org/changeset/127635
https://bugs.webkit.org/show_bug.cgi?id=95905

breaks chromium win and mac build (Requested by bashi1 on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-05

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
3:33 PM Changeset in webkit [127652] by cevans@google.com
  • 5 edits in branches/chromium/1229/Source

Merge 126609
BUG=144704
Review URL: https://chromiumcodereview.appspot.com/10907083

3:26 PM Changeset in webkit [127651] by jchaffraix@webkit.org
  • 1 edit
    3 deletes in branches/chromium/1229

Revert 122501 - Percentage width replaced element in zero percent/fixed width container block incorrectly rendered.
https://bugs.webkit.org/show_bug.cgi?id=9493

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-12
Reviewed by Andy Estes.

Source/WebCore:

When the width of the container is zero percent/fixed value then the width of the replaced element must also be zero.

Test: fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

When the containing block's available width is zero there can be two cases.
The containing block is floated/positioned in which case the width of the replaced child element must be its instrinsic width.
On the other hand if the width of the container is specified to be either zero percent or fixed value then the width of the
replaced elment must be zero.

LayoutTests:

  • fast/css/percent-width-img-inside-zero-percent-and-fixed-container-expected.html: Added.
  • fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html: Added.
  • fast/css/resources/red-box.png: Added. Image resource file for the test case.

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10918085

3:02 PM Changeset in webkit [127650] by leoyang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Optimize BackingStorePrivate::isCurrentVisibleJob
https://bugs.webkit.org/show_bug.cgi?id=95897

Reviewed by Antonio Gomes.

Bail out the loop early if one of the not-rendered rectangle is
not current regular render job.

No behavior change, just code optimization.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):

2:50 PM Changeset in webkit [127649] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make RenderStyle::colorIncludingFallback use private getters
https://bugs.webkit.org/show_bug.cgi?id=95863

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-09-05
Reviewed by Eric Seidel.

For readibility and maintanability reasons, it is better to use getters for
visited* color variables than accessing them directly.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::colorIncludingFallback):

2:46 PM Changeset in webkit [127648] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove use of JSCell::classInfoOffset() from tryCacheGetByID
https://bugs.webkit.org/show_bug.cgi?id=95860

Reviewed by Oliver Hunt.

We should just do the indirection through the Structure instead.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

2:44 PM Changeset in webkit [127647] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Throw exceptions when assigning to const in strict mode
https://bugs.webkit.org/show_bug.cgi?id=95894

Reviewed by Oliver Hunt.

Currently, this never happens; but it will start happening once the
callee is a local const register. In this patch, there's no change in
behavior.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded): Helper function
for doing the throwing.

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode): Call the helper function.

2:12 PM Changeset in webkit [127646] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky http/tests/security tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95803

  • platform/win/Skipped:
2:01 PM Changeset in webkit [127645] by mitz@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Added expected results for this test from r127620 for the Mac port, which does not have
OVERFLOW_SCROLLING enabled at this time.

  • platform/mac/compositing/overflow/overflow-with-touch-toggle-expected.txt: Added.
1:58 PM Changeset in webkit [127644] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] JavaScriptVariant can crash when operator= is called with itself
https://bugs.webkit.org/show_bug.cgi?id=95859

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-09-05
Reviewed by George Staikos.

  • Api/JavaScriptVariant.cpp:

(BlackBerry::WebKit::JavaScriptVariant::operator=):
When JavaScriptVariant contains a string and operator= is
called with itself the memory will be free'd in 'this' and
then a copy will be attempted from 'that' resulting in a crash.

1:50 PM Changeset in webkit [127643] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Refactored callee access in the DFG to support it in the general case
https://bugs.webkit.org/show_bug.cgi?id=95887

Reviewed by Phil Pizlo and Gavin Barraclough.

To support named function expressions, the DFG needs to understand the
callee register being used in arbitrary expressions, and not just
create_this.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::getCallee): Remap access to the callee register
into a GetCallee node. Otherwise, we get confused and think we have a
negatively indexed argument.

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand): Inlining also
needs to remap, but to the callee in the inline frame, and not the caller's
callee.

(JSC::DFG::ByteCodeParser::parseBlock): Since we support the callee in
the general case now, there's no need to handle it in a special way for
create_this.

1:48 PM Changeset in webkit [127642] by allan.jensen@nokia.com
  • 3 edits in trunk/Tools

Ignore-metrics includes scroll offsets.
https://bugs.webkit.org/show_bug.cgi?id=95845

Reviewed by Dirk Pranke.

Strip scroll-offsets the same way scroll-height and scroll-width is stripped.

  • Scripts/old-run-webkit-tests:

(stripMetrics):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(DriverOutput):

1:43 PM Changeset in webkit [127641] by cevans@google.com
  • 3 edits
    4 copies in branches/chromium/1229

Merge 125162
BUG=139530
Review URL: https://chromiumcodereview.appspot.com/10916125

1:40 PM Changeset in webkit [127640] by cevans@google.com
  • 9 edits
    2 copies in branches/chromium/1229

Merge 125147
BUG=139530
Review URL: https://chromiumcodereview.appspot.com/10917095

1:31 PM Changeset in webkit [127639] by benjamin@webkit.org
  • 9 edits in trunk/Source

More fixes for String::operator+=() on Mac
https://bugs.webkit.org/show_bug.cgi?id=95880

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-05
Reviewed by Adam Barth.

Source/WebCore:

Followup for r127574, I forgot some use of strings.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getShorthandValue): Use String builder to construct the shorthand.

Source/WebKit/mac:

  • WebView/WebRenderLayer.mm:

(+[WebRenderLayer nameForLayer:]): Use StringBuilder to concatenate the class names
efficiently.

  • WebView/WebView.mm:

(+[WebView _decodeData:]): This is a legitimate use of String::append(), there
is no other concatenation done on that string.

Source/WebKit2:

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage): This is a legitimate use of append(),
there is no other concatenation outside that branch.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parseRFC822HeaderFields): Use string operators instead of +=.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent): Another legitimate use of append().

1:28 PM Changeset in webkit [127638] by cevans@google.com
  • 1 edit in branches/chromium/1229/Source/WebCore/platform/graphics/skia/OpaqueRegionSkia.cpp

Merge 126901
BUG=144899
Review URL: https://chromiumcodereview.appspot.com/10913094

12:52 PM Changeset in webkit [127637] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 126657
BUG=143604
Review URL: https://chromiumcodereview.appspot.com/10911109

12:47 PM Changeset in webkit [127636] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/1229

Merge 127082
BUG=144671
Review URL: https://chromiumcodereview.appspot.com/10908101

12:46 PM Changeset in webkit [127635] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
https://bugs.webkit.org/show_bug.cgi?id=95876

Reviewed by Tony Chang.

This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:41 PM Changeset in webkit [127634] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 126063
BUG=140484
Review URL: https://chromiumcodereview.appspot.com/10928003

12:37 PM Changeset in webkit [127633] by cevans@google.com
  • 10 edits in branches/chromium/1229/Source

Merge 125500
BUG=137852
Review URL: https://chromiumcodereview.appspot.com/10905105

12:35 PM Changeset in webkit [127632] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r127629.
http://trac.webkit.org/changeset/127629
https://bugs.webkit.org/show_bug.cgi?id=95876

Broke build

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:29 PM Changeset in webkit [127631] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 125343
BUG=131815
Review URL: https://chromiumcodereview.appspot.com/10913091

12:27 PM Changeset in webkit [127630] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1229

Merge 127117
BUG=143609
Review URL: https://chromiumcodereview.appspot.com/10909084

12:20 PM Changeset in webkit [127629] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
https://bugs.webkit.org/show_bug.cgi?id=95876

Reviewed by Tony Chang.

This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:17 PM Changeset in webkit [127628] by leoyang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Rotation and then reload causes less sized webpage (PR 190469)
https://bugs.webkit.org/show_bug.cgi?id=95870

Reviewed by George Staikos.
Reviewed internally by Jacky Jiang.

Use the new zoom to fit scale if the page was zoomed to fit initial scale
When a page is reloaded the layout size may be changed. So the contents
size on which the initial scale depends may be changed. Use the new initial
scale in this case to make sure the page will be zoomed to correct scale.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

12:15 PM Changeset in webkit [127627] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1229

Merge 125635
BUG=137052
Review URL: https://chromiumcodereview.appspot.com/10915102

12:14 PM Changeset in webkit [127626] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[EFL] Slider progress bar goes crazy with negative ranges
https://bugs.webkit.org/show_bug.cgi?id=95753

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Now the calculation of what the current value represents in terms
of progress (from 0 to 1) is correctly done.

Test: fast/forms/range/input-range-progress-indicator.html

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintThemePart):

LayoutTests:

Added ref test to check if rendering results of sliders using
negative value ranges are coherent.

  • fast/forms/range/input-range-progress-indicator-expected.html: Added.
  • fast/forms/range/input-range-progress-indicator.html: Added.
12:07 PM Changeset in webkit [127625] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove use of JSCell::classInfoOffset() from virtualForThunkGenerator
https://bugs.webkit.org/show_bug.cgi?id=95821

Reviewed by Oliver Hunt.

We can replace the load of the ClassInfo from the object with a load from the Structure.

  • dfg/DFGThunks.cpp:

(JSC::DFG::virtualForThunkGenerator):

12:06 PM Changeset in webkit [127624] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/1229

Merge 125476
BUG=135173
Review URL: https://chromiumcodereview.appspot.com/10919103

12:04 PM Changeset in webkit [127623] by pilgrim@chromium.org
  • 10 edits
    2 copies in trunk/Source

[Chromium] Remove getRenderStyleForStrike from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=95363

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/linux/WebFontInfo.h: Added.

(WebKit):
(WebFontInfo):

  • chromium/public/linux/WebFontRenderStyle.h: Added.

(WebKit):

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::getRenderStyleForStrike):
(WebCore):
(WebCore::FontPlatformData::querySystemForRenderStyle):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):

Source/WebKit/chromium:

  • public/linux/WebFontInfo.h:
  • public/linux/WebFontRenderStyle.h:
  • src/PlatformSupport.cpp:

(WebCore):

12:03 PM Changeset in webkit [127622] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/1229

Merge 125448
BUG=135173
Review URL: https://chromiumcodereview.appspot.com/10911108

11:54 AM Changeset in webkit [127621] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge r126551 - [GTK] Purge unused favicons from IconDatabase after 30 days
https://bugs.webkit.org/show_bug.cgi?id=82346

Reviewed by Gustavo Noronha Silva.

Favicons will be removed from the icon database after not being used
for more than 30 days. This will keep the database size under
control.

  • loader/icon/IconDatabase.cpp:

(WebCore):
(WebCore::IconDatabase::performURLImport): filter icons older than
30 days.

11:54 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
11:53 AM Changeset in webkit [127620] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Enable/disable composited scrolling based on overflow
https://bugs.webkit.org/show_bug.cgi?id=95323

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-05
Reviewed by Simon Fraser.

Source/WebCore:

When an overflow:{auto,overlay} and -webkit-overflow-scrolling:touch
element gains or loses overflow, we should correspondingly enable and
disable composited scrolling depending on whether the element can be
scrolled or not.

The previous logic in RenderLayer::usesCompositedScrolling() already
checked for actual overflow, but we also need to recompute the
compositing requirements when the amount of overflow changes during
layout. Additionally, layers using composited scrolling are marked as
self-painting to ensure they are always promoted to composited layers
when needed.

Test: compositing/overflow/overflow-auto-with-touch-toggle.html

Note that the behavior for maintaining a stacking context even without
the presense of overflow is covered by platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):

LayoutTests:

Added a new test for making sure composited scrolling is enabled when overflow
is introduced.

Note that this test will pass only if OVERFLOW_SCROLLING is enabled.

  • compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Added.
  • compositing/overflow/overflow-auto-with-touch-toggle.html: Added.
  • platform/chromium/TestExpectations:
11:46 AM Changeset in webkit [127619] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-1.10/Source

Merge r127483 - [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
https://bugs.webkit.org/show_bug.cgi?id=95740

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Added sanity check to be sure we have a render object prior to seeing if
said object is an anonymous block.

Testing via unit test because a non-flaky layout test crasher could not
be found.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Sanity check for render object added.

Source/WebKit/gtk:

Updated unit test.

  • tests/testatk.c:

(testWebkitAtkComboBox): Added checks that the menu popup in a combo box
has 0 links and, more importantly, that checking doesn't result in a crash.

11:46 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
11:40 AM Changeset in webkit [127618] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge r127466 - [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
https://bugs.webkit.org/show_bug.cgi?id=95618

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Make sure we only emit the the signal for menu lists and list
boxes rendered from actual HTML select elements.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange): We support accessibility
ListBoxes and MenuLists only here, assuming they represent HTML
select elements, which might be not always true (e.g. ARIA). Thus,
check if that condition is true, early returning in other case.

LayoutTests:

New layout test to ensure we don't crash with ATK notifications
anymore when changing the selection in an ARIA listbox.

  • platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
  • platform/gtk/accessibility/aria-listbox-crash.html: Added.
11:40 AM Changeset in webkit [127617] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed: WebInspector: remove accidentally committed speed test.

  • tests/MemoryInstrumentationTest.cpp:
11:40 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
11:33 AM Changeset in webkit [127616] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed test fix.

Including a plugin source file into the build that was added in r127595.

  • GNUmakefile.am:
11:26 AM Changeset in webkit [127615] by commit-queue@webkit.org
  • 32 edits
    2 deletes in trunk/LayoutTests

[CSS Shaders] Update custom filter tests to use the new security model
https://bugs.webkit.org/show_bug.cgi?id=95760

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-05
Reviewed by Dirk Schulze.

This patch updates the custom filter tests to not sample u_texture and not write
to gl_FragColor. Now, the tests use the new security model by writing to
css_MixColor and indirectly blending with the DOM element texture.

This patch prepares us to remove direct DOM texture access via "u_texture":
https://bugs.webkit.org/show_bug.cgi?id=93871

  • css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png:
  • css3/filters/custom/custom-filter-shader-cache-expected.png:
  • css3/filters/custom/custom-filter-shader-cache.html:

Use the CSS mix function with the updated color-offset.fs.

  • css3/filters/custom/effect-color-check-expected.png:
  • css3/filters/custom/effect-color-check.html:

Use the CSS mix function with the updated color-fill.fs.

  • css3/filters/custom/effect-custom-combined-missing-expected.png:
  • css3/filters/custom/effect-custom-combined-missing.html:

Use the CSS mix function with the updated color-offset.fs.

  • css3/filters/custom/effect-custom-expected.png:
  • css3/filters/custom/effect-custom-parameters-expected.png:
  • css3/filters/custom/effect-custom-parameters.html:

Use the mix-color.fs shader instead of color-offset-parameters.fs.

  • css3/filters/custom/effect-custom.html:

Use the CSS mix function with the updated color-offset.fs.

  • css3/filters/custom/filter-repaint-custom-clipped-expected.png:
  • css3/filters/custom/filter-repaint-custom-clipped.html:

Use the mix-color.fs shader instead of color-add.fs.

  • css3/filters/custom/filter-repaint-custom-expected.png:
  • css3/filters/custom/filter-repaint-custom-rotated-expected.png:
  • css3/filters/custom/filter-repaint-custom-rotated.html:

Use the mix-color.fs shader instead of color-add.fs. Fix a small typo in a comment.

  • css3/filters/custom/filter-repaint-custom.html:

Use the mix-color.fs shader instead of color-add.fs.

  • css3/filters/custom/invalid-custom-filter-shader.html:

Use the CSS mix function with the updated color-offset.fs.

  • css3/filters/custom/missing-custom-filter-shader-expected.png:
  • css3/filters/custom/missing-custom-filter-shader.html:

Use the CSS mix function with the updated color-offset.fs.

  • css3/filters/resources/color-add.fs:

Removed. The mix-color.fs shader can perform this shader's function.

  • css3/filters/resources/color-fill.fs:

Rewrote this shader to write to css_MixColor instead of sampling u_texture and writing
to gl_FragColor.

  • css3/filters/resources/color-offset-parameters.fs:

Removed. The mix-color.fs shader can perform this shader's function.

  • css3/filters/resources/color-offset.fs:

Rewrote this shader to write to css_MixColor instead of sampling u_texture and writing
to gl_FragColor.

  • platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
  • platform/chromium/TestExpectations:
11:21 AM Changeset in webkit [127614] by ap@apple.com
  • 4 edits in trunk/Source/WebKit2

[WK2] Make visited link tracking work in multi-process mode
https://bugs.webkit.org/show_bug.cgi?id=95869

Reviewed by Dan Bernstein.

  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/VisitedLinkProvider.cpp: (WebKit::VisitedLinkProvider::VisitedLinkProvider): m_webProcessHasVisitedLinkState was making no sense in multi-process world, so it was let go. (WebKit::VisitedLinkProvider::processDidFinishLaunching): Track new processes. (WebKit::VisitedLinkProvider::processDidClose): Clean up pointers that are going to become stale. (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired): Added comments. Fixed a bug where we would churn table size in some cases. Added debug logging in failure case. Re-implemented messaging code to work with multiple web processes.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::processDidFinishLaunching): Pass process proxy pointer to m_visitedLinkProvider, as it now needs to track processes. (WebKit::WebContext::disconnectProcess): Ditto. Also re-enabled visited link provider cleanup in multi-process mode.
11:19 AM WebInspector edited by zandobersek@gmail.com
Removing spam links. (diff)
11:16 AM Changeset in webkit [127613] by mifenton@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize values.
https://bugs.webkit.org/show_bug.cgi?id=95773

Reviewed by Rob Buis.

Properly initialize the passed variables even
though we haven't implemented the modifier state
to ensure the values are deterministic.

  • platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

11:01 AM Changeset in webkit [127612] by tommyw@google.com
  • 25 edits
    7 copies
    2 adds in trunk

MediaStream API: Add the local and remote description functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95839

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCVoidRequest.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.

(WebCore):
(WebKit):
(WebRTCVoidRequest):
(ExtraData):
(WebKit::WebRTCVoidRequest::ExtraData::~ExtraData):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::~WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::operator=):
(WebKit::WebRTCVoidRequest::isNull):

Source/WebCore:

As well as adding the local/remote descriptions stuff, I removed the source attribute from
RTCSessionDescriptionCallback and RTCErrorCallback since it has been removed from the draft.

Tests: fast/mediastream/RTCPeerConnection-localDescription.html

fast/mediastream/RTCPeerConnection-remoteDescription.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCErrorCallback.h:

(RTCErrorCallback):

  • Modules/mediastream/RTCErrorCallback.idl:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):

  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCSessionDescriptionCallback.h:

(RTCSessionDescriptionCallback):

  • Modules/mediastream/RTCSessionDescriptionCallback.idl:
  • Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:

(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::clear):

  • Modules/mediastream/RTCSessionDescriptionRequestImpl.h:

(RTCSessionDescriptionRequestImpl):

  • Modules/mediastream/RTCVoidRequestImpl.cpp: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp.

(WebCore):
(WebCore::RTCVoidRequestImpl::create):
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::~RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::requestSucceeded):
(WebCore::RTCVoidRequestImpl::requestFailed):
(WebCore::RTCVoidRequestImpl::stop):
(WebCore::RTCVoidRequestImpl::clear):

  • Modules/mediastream/RTCVoidRequestImpl.h: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.h.

(WebCore):
(RTCVoidRequestImpl):

  • WebCore.gypi:
  • platform/chromium/support/WebRTCVoidRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.

(WebKit):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::assign):
(WebKit::WebRTCVoidRequest::reset):
(WebKit::WebRTCVoidRequest::requestSucceeded):
(WebKit::WebRTCVoidRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCVoidRequest::extraData):
(WebKit::WebRTCVoidRequest::setExtraData):

  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerDummy::localDescription):
(WebCore::RTCPeerConnectionHandlerDummy::remoteDescription):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCVoidRequest.h: Copied from Source/WebCore/Modules/mediastream/RTCErrorCallback.h.

(WebCore):
(RTCVoidRequest):
(ExtraData):
(WebCore::RTCVoidRequest::ExtraData::~ExtraData):
(WebCore::RTCVoidRequest::~RTCVoidRequest):
(WebCore::RTCVoidRequest::extraData):
(WebCore::RTCVoidRequest::setExtraData):
(WebCore::RTCVoidRequest::RTCVoidRequest):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerChromium::localDescription):
(WebCore::RTCPeerConnectionHandlerChromium::remoteDescription):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
up the task definitions a bit. There was no need to have them in the header file.

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCVoidRequestTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(MockWebRTCPeerConnectionHandler::createOffer):
(MockWebRTCPeerConnectionHandler::setLocalDescription):
(MockWebRTCPeerConnectionHandler::setRemoteDescription):
(MockWebRTCPeerConnectionHandler::localDescription):
(MockWebRTCPeerConnectionHandler::remoteDescription):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-localDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
  • fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-remoteDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
10:58 AM Changeset in webkit [127611] by cevans@google.com
  • 6 edits in branches/chromium/1229/Source/WebCore/rendering

Merge 125220 - Reimplement RenderQuote placement algorithm
BUG=135173
Review URL: https://chromiumcodereview.appspot.com/10912102

10:55 AM Changeset in webkit [127610] by cevans@google.com
  • 6 edits in branches/chromium/1229/Source/WebCore/rendering

Revert 127609 - Merge 124969
BUG=135173

TBR=cevans@google.com
Review URL: https://chromiumcodereview.appspot.com/10913088

10:50 AM Changeset in webkit [127609] by cevans@google.com
  • 6 edits in branches/chromium/1229/Source/WebCore/rendering

Merge 124969
BUG=135173
Review URL: https://chromiumcodereview.appspot.com/10911104

10:48 AM Changeset in webkit [127608] by krit@webkit.org
  • 11 edits
    32 adds in trunk

Use -webkit-clip-path shapes to clip HTML elements
https://bugs.webkit.org/show_bug.cgi?id=95646

Reviewed by Dean Jackson.

Source/WebCore:

-webkit-clip-path creates a new layer for HTML elements now. The border,
background and content gets clipped by the clip path after any filter was
applied.

Tests: css3/masking/clip-path-circle-filter.html

css3/masking/clip-path-circle-overflow.html
css3/masking/clip-path-circle-overflow-hidden.html
css3/masking/clip-path-circle-relative-overflow.html
css3/masking/clip-path-circle.html
css3/masking/clip-path-ellipse.html
css3/masking/clip-path-polygon-evenodd.html
css3/masking/clip-path-polygon-nonzero.html
css3/masking/clip-path-polygon.html
css3/masking/clip-path-rectangle.html

  • rendering/RenderBox.h: Create new layer on clip-path.
  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::requiresLayer): Create new layer on clip-path.

  • rendering/RenderInline.h:

(WebCore::RenderInline::requiresLayer): Create new layer on clip-path.

  • rendering/RenderLayer.cpp: Apply clip-path on context of object.

(WebCore::RenderLayer::paintLayerContents): Create new layer on clip-path.

  • rendering/RenderObject.h:

(WebCore::RenderObject::hasClipPath): Indicates that renderer needs to be clipped by clip-path.

  • rendering/RenderTableRow.h: Create new layer on clip-path.

LayoutTests:

Added new tests for the -webkit-clip-path property applied to HTML content.

  • css3/masking/clip-path-circle-filter.html: Added.
  • css3/masking/clip-path-circle-overflow.html: Added.
  • css3/masking/clip-path-circle-relative-overflow.html: Added.
  • css3/masking/clip-path-circle-overflow-hidden.html: Added.
  • css3/masking/clip-path-circle.html: Added.
  • css3/masking/clip-path-ellipse.html: Added.
  • css3/masking/clip-path-polygon-evenodd.html: Added.
  • css3/masking/clip-path-polygon-nonzero.html: Added.
  • css3/masking/clip-path-polygon.html: Added.
  • css3/masking/clip-path-rectangle.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/css3/masking/clip-path-circle-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-filter-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-filter-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-overflow-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-overflow-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-ellipse-expected.png: Added.
  • platform/mac/css3/masking/clip-path-ellipse-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
  • platform/mac/css3/masking/clip-path-polygon-evenodd-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-polygon-expected.png: Added.
  • platform/mac/css3/masking/clip-path-polygon-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
  • platform/mac/css3/masking/clip-path-polygon-nonzero-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-rectangle-expected.png: Added.
  • platform/mac/css3/masking/clip-path-rectangle-expected.txt: Added.
10:33 AM Changeset in webkit [127607] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Use explicit constructor in RenderThemeEfl.
https://bugs.webkit.org/show_bug.cgi?id=95853

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-05
Reviewed by Kentaro Hara.

Added explicit keyword in constructor of RenderThemeEfl in order to avoid implicit type conversion.

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

10:31 AM Changeset in webkit [127606] by scheib@chromium.org
  • 7 edits
    2 adds in trunk

webkitPointerLockElement returns null when pointer lock request is pending.
https://bugs.webkit.org/show_bug.cgi?id=91186

Reviewed by Dimitri Glazkov.

Source/WebCore:

Script should wait for a pointerlockchange event before detecting
if it has acquired lock. However, if a script attempted to poll
pointerLockElement it could be confused when lock was still pending.
This change ensures that if lock is not yet acquired then
pointerLockElement will return null.

Test: pointer-lock/pointerlockelement-null-when-pending.html

  • dom/Document.cpp:

(WebCore::Document::webkitPointerLockElement):

  • page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::elementRemoved):
(WebCore::PointerLockController::documentDetached):
(WebCore::PointerLockController::lockPending):
(WebCore):
(WebCore::PointerLockController::didAcquirePointerLock):
(WebCore::PointerLockController::didNotAcquirePointerLock):
(WebCore::PointerLockController::didLosePointerLock):
(WebCore::PointerLockController::clearElement):

  • page/PointerLockController.h:

(PointerLockController):

LayoutTests:

  • pointer-lock/locked-element-iframe-removed-from-dom-expected.txt:
  • pointer-lock/locked-element-iframe-removed-from-dom.html:

Updated to reflect new behavior of null returned when lock is pending.

  • pointer-lock/pointerlockelement-null-when-pending-expected.txt: Added.
  • pointer-lock/pointerlockelement-null-when-pending.html: Added.

New test specifically for testing null return when lock is pending.

10:25 AM Changeset in webkit [127605] by commit-queue@webkit.org
  • 16 edits
    1 add in trunk/Source

[chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium
https://bugs.webkit.org/show_bug.cgi?id=95679

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-09-05
Reviewed by James Robinson.

Source/Platform:

Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.

  • Platform.gypi:
  • chromium/public/WebLayer.h:

(WebKit):
(WebLayer):

  • chromium/public/WebLayerScrollClient.h:

Source/WebCore:

Implement scrollable sublayers in ScrollingCoordinatorChromium and introduce a
WebLayerScrollClient which is notified of scroll events on its associated
scroll layer. GraphicsLayerChromium uses it to apply scroll events targeted to
its platform layer to a ScrollableArea, i.e., the RenderLayer corresponding to
the scrollable element.

Tests: GraphicsLayerChromiumTest.applyScrollToScrollableArea

WebLayerTest.ScrollClient

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::didScroll):
(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore):
(WebCore::GraphicsLayerChromium::setScrollableArea):
(WebCore::GraphicsLayerChromium::scrollableArea):
(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:

(WebKit):
(WebCore):
(WebCore::LayerChromium::setLayerScrollClient):
(LayerChromium):

Source/WebKit/chromium:

Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.

  • src/WebLayerImpl.cpp:

(WebKit::WebLayerImpl::setMaxScrollPosition):
(WebKit):
(WebKit::WebLayerImpl::setScrollClient):
(WebKit::WebLayerImpl::scrollBy):

  • src/WebLayerImpl.h:

(WebLayerImpl):

  • tests/CCLayerTreeHostTest.cpp:
  • tests/GraphicsLayerChromiumTest.cpp:

(MockScrollableArea):
(WebKit):
(WebKit::TEST_F):

  • tests/WebLayerTest.cpp:
10:05 AM Changeset in webkit [127604] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Remove '+=' usage in String
https://bugs.webkit.org/show_bug.cgi?id=95808

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-05
Reviewed by Benjamin Poulain.

Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_source_get): Removed unnecessary strlen usage.

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(descriptionSuitableForTestResult):

9:44 AM Changeset in webkit [127603] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: support asynchronous command implementation
https://bugs.webkit.org/show_bug.cgi?id=95649

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-09-05
Reviewed by Yury Semikhatsky.

Generator is extended to generate callback object for each asynchronous command.

  • inspector/CodeGeneratorInspector.py:

(Writer.append_multiline):
(Writer):
(Writer.get_indent):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.ResolveData):
(InspectorBackendDispatcherImpl):
(CallbackBase):
(Generator.process_event):
(Generator):
(Generator.EventMethodStructTemplate):
(Generator.EventMethodStructTemplate.append_prolog):
(Generator.EventMethodStructTemplate.append_epilog):
(Generator.process_command):
(Generator.CallbackMethodStructTemplate):
(Generator.CallbackMethodStructTemplate.append_prolog):
(Generator.CallbackMethodStructTemplate.append_epilog):
(Generator.generate_send_method):

9:33 AM Changeset in webkit [127602] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=95842

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Tools:

Provide proper implementation for TestRunner::pathToLocalResource()
in EFL WKTR, identical to the one for DumpRenderTree.

Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
/tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
are found my WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:

(WTR::TestRunner::pathToLocalResource):

LayoutTests:

Unskip fast/dom/frame-loading-via-document-write.html that
was failing due to incomplete implementation for
TestRunner::pathToLocalResource() in EFL WKTR.

  • platform/efl-wk2/TestExpectations:
9:33 AM Changeset in webkit [127601] by Carlos Garcia Campos
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge r127370 - [Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811

Part of the bug was due to expected accessible objects of DivRole
and ParagraphRole being ignored, in favor of including child blocks.

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/gtk/accessibility/spans-paragraphs-and-divs.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::firstAnonymousBlockChild):
(WebCore):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
New method to return the first child which is an anonymous block.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Include paragraphs and divs which contain a non-nested anonymous block.

LayoutTests:

Added new test to verify that paragraphs and divs which contain anonymous
blocks are included in the accessible object hierarchy and have the correct
number of children with the expected role.

  • platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt: Added.
  • platform/gtk/accessibility/spans-paragraphs-and-divs.html: Added.
9:32 AM Changeset in webkit [127600] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not release shared backingstore memory prematurely
https://bugs.webkit.org/show_bug.cgi?id=95841
PR #202517

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-09-05
Reviewed by George Staikos.

The BackingStore memory is shared by all web pages. We should check if
the current backingStore is active before create/release this shared memory.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
(BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):

9:32 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
9:19 AM Changeset in webkit [127599] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-1.10/LayoutTests

Merge r127377 - [Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure
https://bugs.webkit.org/show_bug.cgi?id=95643

Unreviewed GTK gardening, rebaselining an accessibility test.

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01

  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Corrected.
9:19 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
9:16 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
9:15 AM Changeset in webkit [127598] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-1.10/LayoutTests

Merge r127369 - Unreviewed GTK gardening, rebaselining an accessibility test.

  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
8:58 AM Changeset in webkit [127597] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[chromium] Unify size of popup menu for touch and non-touch.
https://bugs.webkit.org/show_bug.cgi?id=95606

Patch by Kevin Ellis <kevers@chromium.org> on 2012-09-05
Reviewed by Adam Barth.

Use minimum height for popup menus entries regardless of whether the
popup menu is displayed on a touch screen. Replaces use of touch
padding. Height meets minimum size requirement for a low error rate
while still looking aesthetic for non-touch.

Covered by existing tests.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore):

  • platform/chromium/PopupMenuChromium.h:

(PopupMenuChromium):

8:56 AM Changeset in webkit [127596] by mihnea@adobe.com
  • 10 edits
    22 adds in trunk

[CSS Regions] Auto width is not working for Regions
https://bugs.webkit.org/show_bug.cgi?id=74135

Reviewed by Julien Chaffraix.

Source/WebCore:

It was not possible to flow content into a region having { width: auto; } since in such case, the region width was computed to 0.
Now, a region having auto width, will have its width computed following the rules for calculation of widths and margins
(http://www.w3.org/TR/CSS2/visudet.html#Computing_widths_and_margins).
For those cases in which resolving the width requires measuring of content's min/max-content values, we use the associated named flow min/max-content
values (the same for all regions with width auto in a region chain).
When a region has width:auto, the computation of width should be done using normal block/box sizing code, instead of replaced element code.
Contains code contributed by Alexandru Chiculita(Alexandru Chiculita).

Tests: fast/regions/autowidth-abspos-regionchain.html

fast/regions/autowidth-abspos.html
fast/regions/autowidth-float.html
fast/regions/autowidth-inlineblock.html
fast/regions/autowidth-nonreplaced-abspos.html
fast/regions/autowidth-nonreplacedblock-normalflow.html
fast/regions/autowidth-normalflow-maxwidth.html
fast/regions/autowidth-normalflow-minmaxwidth.html
fast/regions/autowidth-normalflow-minwidth.html
fast/regions/autowidth-normalflow-vertrl.html
fast/regions/autowidth-normalflow.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth): For positioned auto-width regions, skip the code path for replaced elements.

  • rendering/RenderRegion.cpp:

(WebCore): Override min/maxPreferredLogicalWidth as they are used in the process of computing width for regions with auto width.
As this moment, a region is still a RenderReplaced element, so this code needs to be revisited when the region will become a RenderBlock.
Also, for min/max-width, we support only <length> values. We will extend support for other values in a following patch.
(WebCore::RenderRegion::minPreferredLogicalWidth):
(WebCore::RenderRegion::maxPreferredLogicalWidth):

  • rendering/RenderRegion.h:

(RenderRegion):
Override isInlineBlockOrInlineTable() and shouldComputeSizeAsReplaced() to ensure that computation for width auto follows the normal
block/box sizing code.

LayoutTests:

It was not possible to flow content into a region having { width: auto; } since in such case, the region width was computed to 0.
Now, a region having auto width, will have its width computed following the rules for calculation of widths and margins
(http://www.w3.org/TR/CSS2/visudet.html#Computing_widths_and_margins).
For those cases in which resolving the width requires measuring of content's min/max-content values, we use the associated named flow min/max-content
values (the same for all regions with width auto in a region chain).

Besides adding new tests, i have modified existing tests that were having regions with width:auto as they were failing after this patch.

  • fast/regions/autowidth-abspos-expected.html: Added.
  • fast/regions/autowidth-abspos-regionchain-expected.html: Added.
  • fast/regions/autowidth-abspos-regionchain.html: Added.
  • fast/regions/autowidth-abspos.html: Added.
  • fast/regions/autowidth-float-expected.html: Added.
  • fast/regions/autowidth-float.html: Added.
  • fast/regions/autowidth-inlineblock-expected.html: Added.
  • fast/regions/autowidth-inlineblock.html: Added.
  • fast/regions/autowidth-nonreplaced-abspos-expected.html: Added.
  • fast/regions/autowidth-nonreplaced-abspos.html: Added.
  • fast/regions/autowidth-nonreplacedblock-normalflow-expected.html: Added.
  • fast/regions/autowidth-nonreplacedblock-normalflow.html: Added.
  • fast/regions/autowidth-normalflow-expected.html: Added.
  • fast/regions/autowidth-normalflow-maxwidth-expected.html: Added.
  • fast/regions/autowidth-normalflow-maxwidth.html: Added.
  • fast/regions/autowidth-normalflow-minmaxwidth-expected.html: Added.
  • fast/regions/autowidth-normalflow-minmaxwidth.html: Added.
  • fast/regions/autowidth-normalflow-minwidth-expected.html: Added.
  • fast/regions/autowidth-normalflow-minwidth.html: Added.
  • fast/regions/autowidth-normalflow-vertrl-expected.html: Added.
  • fast/regions/autowidth-normalflow-vertrl.html: Added.
  • fast/regions/autowidth-normalflow.html: Added.
  • fast/regions/bottom-overflow-out-of-first-region.html:
  • fast/regions/flows-dependency-dynamic-remove.html:
  • fast/regions/flows-dependency-same-flow.html:
  • fast/regions/render-region-renderer-expected.html:
  • fast/regions/top-overflow-out-of-second-region.html:
8:39 AM Changeset in webkit [127595] by beidson@apple.com
  • 9 edits
    3 adds in trunk

Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
<rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026

Source/WebKit2:

Patch partially by Andras Becsi <andras.becsi@nokia.com>

Reviewed by Andy Estes.

If a plug-in fails to initialize then the m_plugin pointer is cleared out.
When accessing the script object it is appropriate to unconditionally null check m_plugin.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::scriptObject): Null check m_plugin before trying to use it.

Tools:

Reviewed by Andy Estes.

Add a plug-in that always fails to initialize:

  • DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.

(NPPNewFails):
(NPPNewFails::NPPNewFails):
(NPPNewFails::NPP_New):

Add it to all the project files:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

LayoutTests:

Reviewed by Andy Estes.

  • plugins/npp-new-fails-expected.txt: Added.
  • plugins/npp-new-fails.html: Added.
8:38 AM Changeset in webkit [127594] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Implement number of matches and current active match index for find-on-page
https://bugs.webkit.org/show_bug.cgi?id=95801

Patch by Andy Chen <andchen@rim.com> on 2012-09-05
Reviewed by Antonio Gomes.

  • Calculate current match index for find-on-page
  • Notify client when number of matches and current match index update.

PR 162090 162091.
Internally reviewed by Mike Fenton and Joe Mason

  • Api/WebPageClient.h:
  • WebKitSupport/InPageSearchManager.cpp:

(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
(InPageSearchManager::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
(BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):

  • WebKitSupport/InPageSearchManager.h:

(InPageSearchManager):

8:11 AM Changeset in webkit [127593] by loislo@chromium.org
  • 115 edits in trunk/Source

Web Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation.
https://bugs.webkit.org/show_bug.cgi?id=95850

Reviewed by Yury Semikhatsky.

I'd like to extract MemoryObjectTypes into separate classes.
After that we will be able to move core NMI instrumentation code to WTF.

Source/WebCore:

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::ChunkedTable::reportMemoryUsage):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/V8Binding.cpp:

(WebCore::StringCache::reportMemoryUsage):

  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::reportDescendantMemoryUsage):

  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::reportDescendantMemoryUsage):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):

  • css/CSSCharsetRule.cpp:

(WebCore::CSSCharsetRule::reportDescendantMemoryUsage):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::reportDescendantMemoryUsage):

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):

  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::reportDescendantMemoryUsage):

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::reportDescendantMemoryUsage):

  • css/CSSInheritedValue.cpp:

(WebCore::CSSInheritedValue::reportDescendantMemoryUsage):

  • css/CSSInitialValue.cpp:

(WebCore::CSSInitialValue::reportDescendantMemoryUsage):

  • css/CSSLineBoxContainValue.cpp:

(WebCore::CSSLineBoxContainValue::reportDescendantMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportDescendantMemoryUsage):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::reportDescendantMemoryUsage):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::reportDescendantMemoryUsage):

  • css/CSSRule.cpp:

(WebCore::CSSRule::reportBaseClassMemoryUsage):

  • css/CSSRuleList.cpp:

(WebCore::StaticCSSRuleList::reportMemoryUsage):

  • css/CSSRuleList.h:
  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::reportMemoryUsage):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::reportDescendantMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/CSSTimingFunctionValue.cpp:

(WebCore::CSSLinearTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSCubicBezierTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSStepsTimingFunctionValue::reportDescendantMemoryUsage):

  • css/CSSUnicodeRangeValue.cpp:

(WebCore::CSSUnicodeRangeValue::reportDescendantMemoryUsage):

  • css/CSSUnknownRule.h:

(WebCore::CSSUnknownRule::reportDescendantMemoryUsage):

  • css/CSSValue.cpp:

(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::reportDescendantMemoryUsage):

  • css/CSSVariableValue.h:

(WebCore::CSSVariableValue::reportDescendantMemoryUsage):

  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::reportDescendantMemoryUsage):

  • css/FontValue.cpp:

(WebCore::FontValue::reportDescendantMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):

  • css/MediaQuery.cpp:

(WebCore::MediaQuery::reportMemoryUsage):

  • css/MediaQueryExp.cpp:

(WebCore::MediaQueryExp::reportMemoryUsage):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):

  • css/ShadowValue.cpp:

(WebCore::ShadowValue::reportDescendantMemoryUsage):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::Features::reportMemoryUsage):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleBlock::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::reportDescendantMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::reportDescendantMemoryUsage):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportDescendantMemoryUsage):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportDescendantMemoryUsage):

  • css/WebKitCSSMixFunctionValue.cpp:

(WebCore::WebKitCSSMixFunctionValue::reportDescendantMemoryUsage):

  • css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::reportDescendantMemoryUsage):

  • css/WebKitCSSSVGDocumentValue.cpp:

(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):

  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::reportDescendantMemoryUsage):

  • dom/Attribute.h:

(WebCore::Attribute::reportMemoryUsage):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::reportMemoryUsage):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::reportMemoryUsage):

  • dom/Element.h:

(WebCore::Element::reportMemoryUsage):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/Event.cpp:

(WebCore::Event::reportMemoryUsage):

  • dom/MemoryInstrumentation.cpp:

(WebCore):

  • dom/MemoryInstrumentation.h:

(WebCore):
(GenericMemoryTypes):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCoreMemoryTypes):

  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::reportMemoryUsage):

  • loader/SubstituteData.cpp:

(WebCore::SubstituteData::reportMemoryUsage):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::reportMemoryUsage):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::reportMemoryUsage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • loader/cache/CachedResourceHandle.cpp:

(WebCore::CachedResourceHandleBase::reportMemoryUsage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::reportMemoryUsage):

  • loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::reportMemoryUsage):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::reportMemoryUsage):

  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::reportMemoryUsage):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::reportMemoryUsage):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::reportMemoryUsage):

  • page/Frame.cpp:

(WebCore::Frame::reportMemoryUsage):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::reportMemoryUsage):

  • platform/TreeShared.h:

(WebCore::TreeShared::reportMemoryUsage):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::reportMemoryUsage):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):

  • platform/graphics/GeneratedImage.cpp:

(WebCore::GeneratedImage::reportMemoryUsage):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::reportMemoryUsage):

  • platform/graphics/Image.cpp:

(WebCore::Image::reportMemoryUsage):

  • platform/network/FormData.cpp:

(WebCore::FormData::reportMemoryUsage):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::reportMemoryUsage):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::reportMemoryUsage):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::reportMemoryUsage):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::reportMemoryUsage):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::reportMemoryUsage):

  • svg/SVGColor.cpp:

(WebCore::SVGColor::reportDescendantMemoryUsage):

  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::reportDescendantMemoryUsage):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::reportMemoryUsage):

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::Instrumented::reportMemoryUsage):
(WebCore::InstrumentedRefPtr::reportMemoryUsage):
(WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
(WebCore::InstrumentedOther::reportMemoryUsage):
(WebCore::InstrumentedDOM::reportMemoryUsage):
(WebCore::TEST):
(WebCore::NonVirtualInstrumented::reportMemoryUsage):

7:52 AM Changeset in webkit [127592] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: NMI: extract overloaded instrumentation members for WebCore classes from core NMI code.
https://bugs.webkit.org/show_bug.cgi?id=95834

Reviewed by Yury Semikhatsky.

I'd like to remove custom instrumentation methods from MemoryInstrumentation class
before upstreaming it to WTF. I've done it with help of MemoryInstrumentationTraits template helper.

Unfortunately it is not possible to use template class because mac-ews bot reports warning: redundant redeclaration of 'something' in same scope.
I've found that it is an old problem in gcc that is forced by -Wredundant-decls flag on the bot. See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15867

  • dom/MemoryInstrumentation.cpp:

(WebCore::::addInstrumentedObject):
(WebCore):

  • dom/MemoryInstrumentation.h:

(WebCore):
(MemoryInstrumentationTraits):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer):
(InstrumentedPointer):
(WebCore::MemoryInstrumentation::addObject):
(WebCore::MemoryInstrumentation::addInstrumentedObject):
(WebCore::MemoryInstrumentation::addRawBuffer):
(WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedObject):
(WebCore::MemoryInstrumentation::OwningTraits::addObject):
(WebCore::::addInstrumentedObject):
(WebCore::::addObject):
(WebCore::MemoryObjectInfo::MemoryObjectInfo):
(WebCore::MemoryObjectInfo::objectType):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(MemoryObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
(MemoryClassInfo):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(WebCore::MemoryInstrumentation::addObjectImpl):
(WebCore::MemoryInstrumentation::addHashMap):
(WebCore::MemoryInstrumentation::addHashSet):
(WebCore::MemoryInstrumentation::addInstrumentedCollection):
(WebCore::MemoryInstrumentation::addInstrumentedMapEntries):
(WebCore::MemoryInstrumentation::addInstrumentedMapValues):
(WebCore::MemoryInstrumentation::addListHashSet):
(WebCore::MemoryInstrumentation::addVector):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::countObjectSize):

  • inspector/MemoryInstrumentationImpl.h:

(WebCore::MemoryInstrumentationImpl::totalSize):
(MemoryInstrumentationImpl):

7:37 AM WebInspector edited by janeparker991@gmail.com
(diff)
7:36 AM Changeset in webkit [127591] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r127590.
http://trac.webkit.org/changeset/127590

Broke the Chromium bots because of a compile error in the compositor.

  • DEPS:
7:23 AM Changeset in webkit [127590] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
7:18 AM Changeset in webkit [127589] by Carlos Garcia Campos
  • 8 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge r127368 - [Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811

Part of the bug was due to extraneous accessible objects resulting
from unignored inline and block spans.

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/gtk/accessibility/spans.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Ignore objects that have spanTag tag name.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore most anonymous blocks.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(roleIsTextType): Add ListItem to the roles which should implement AtkText.

LayoutTests:

Added new test, updated the results of one test to reflect the fix,
corrected a test with a mismatched element tag.

  • platform/gtk/accessibility/aria-roles-unignored-expected.txt: Corrected results having fixed tag.
  • platform/gtk/accessibility/aria-roles-unignored.html: Fixed mismatched element tag.
  • platform/gtk/accessibility/media-element-expected.txt: Updated to reflect removal of extraneous object.
  • platform/gtk/accessibility/spans-expected.txt: Added.
  • platform/gtk/accessibility/spans.html: Added.
7:18 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
7:11 AM Changeset in webkit [127588] by Carlos Garcia Campos
  • 8 edits
    4 adds in releases/WebKitGTK/webkit-1.10

Merge r127367 - [Gtk] Incorrect/unexpected characters in the text of certain accessibles
https://bugs.webkit.org/show_bug.cgi?id=95180

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

The bug was caused by failing to properly handle anonymous block text
which had object replacement characters (multibyte) in it. Calculating
the string length based on the UTF-8 string meant that we were returning
more characters than were there and in danger of splitting a multibyte
character.

Tests: platform/gtk/accessibility/entry-and-password.html

platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetText): Convert the text returned by textForObject()
to Unicode before calculating its length.

Source/WebKit/gtk:

Corrected a unit test in which the expected accessible text was wrong as
a result of this bug. In particular, the AtkText inserted into an empty
text field is expected to be the same text atk_text_get_text() returns.
That was not happening -- and presumably not noticed as a result of the
hard to read textual representation of the multibyte password field
bullets.

  • tests/testatk.c:

(testWebkitAtkTextChangedNotifications): Corrected the test and added a
comment so that one knows what the multibyte character is.

Tools:

The bug that was fixed stood in the way of fully implementing stringValue().
Testing that the bug is fixed requires stringValue() to be fully implemented
and object replacement characters to be printable.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(replaceCharactersForResults): New method which turns object replacement
characters into "<obj>" so that the characters can be properly shown in
Layout Test results. Also turns "\n" into "<
n>" so that printing the
accessible text of a single object in the accessible tree doesn't mess up
the readibility of the results.
(AccessibilityUIElement::stringValue): Remove the code that immediately
returned upon encountering an object of ATK_ROLE_PANEL and call the new
replaceCharactersForResults() prior to returning the accessible string
value.

LayoutTests:

Two new layout tests, plus one updated one.

  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Indicated replaced objects.
  • platform/gtk/accessibility/entry-and-password-expected.txt: Added.
  • platform/gtk/accessibility/entry-and-password.html: Added.
  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Added.
  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html: Added.
7:10 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
7:04 AM Changeset in webkit [127587] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Build fix on OS X

Copy/paste-error resulted in us compiling InspectorPageOverlay.h

Reviewed by Ossy.

6:59 AM Changeset in webkit [127586] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-1.10

Merge r126941 - Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
https://bugs.webkit.org/show_bug.cgi?id=95185

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-28
Reviewed by Chris Fleizach.

Tools:

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::titleUIElement): Implemented
Gets the ATK_RELATION_LABELLED_BY target.
(AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
bug 95180 is fixed.

LayoutTests:

Updated layout test expected results. In all three cases below:
1) Remove objects from the tree representation which did not belong,
but were included as a side effect of AccessibilityUIElement::stringValue()
not having been implemented.
2) Add the stringValue() return value to the tree representation.
Note that the implementation of AccessibilityUIElement::titleUIElement()
will be tested by the existing legend.html layout text. See bug 84137.

  • platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Updated.
  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated.
  • platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Updated.
6:59 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:47 AM Changeset in webkit [127585] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore

Merge r126886 - [GTK] LLint build fails with -g -02
https://bugs.webkit.org/show_bug.cgi?id=90098

Patch by Alban Browaeys <prahal@yahoo.com> on 2012-08-28
Reviewed by Filip Pizlo.

Avoid duplicate offsets for llint, discarding them.

  • offlineasm/offsets.rb:
6:47 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:25 AM Changeset in webkit [127584] by dominik.rottsches@intel.com
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] Unreviewed gardening.

Adding a platform specififc baseline after r127534.

  • platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
6:11 AM Changeset in webkit [127583] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix makefile race condition between derived sources and target

r121966 removed too much of the old qmake logic, including the rule
that ensured that qmake_all would not trigger dual runs of qmake --
one of the derived sources -qmake-all rule, and one for making the
derived sources.

We now follow a similar pattern as before, by introducing a custom
target that explicitly depends on the derived sources' qmake-all before
doing a manual run of make. That ensures a single qmake run for the derived
sources.

https://bugs.webkit.org/show_bug.cgi?id=93847

Reviewed by Csaba Osztrogonác.

  • qmake/mkspecs/features/functions.prf:
6:06 AM Changeset in webkit [127582] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk

[EFL][WK2] Provide implementation for WebFrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=95826

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Remove EFL-specific and empty implementation for WebFrameNetworkingContext
and use the existing soup implementation instead.

  • PlatformEfl.cmake:
  • WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Removed.

LayoutTests:

Unskip several cookie-related test cases for WK2 EFL
now that WebFrameNetworkingContext is implemented.

  • platform/efl-wk2/TestExpectations:
5:34 AM Changeset in webkit [127581] by dominik.rottsches@intel.com
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r127573.
http://trac.webkit.org/changeset/127573
https://bugs.webkit.org/show_bug.cgi?id=95844

Breaks EFL Debug bot tests. (Requested by drott on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-05

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::setThemePath):
(WebCore::RenderThemeEfl::createCanvas):
(WebCore::RenderThemeEfl::createEdje):
(WebCore::RenderThemeEfl::applyPartDescriptions):
(WebCore::RenderThemeEfl::themeChanged):
(WebCore):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

5:09 AM Changeset in webkit [127580] by morrita@google.com
  • 5 edits
    2 adds in trunk

ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=91704

Reviewed by Kentaro Hara.

Source/WebCore:

This change implement ShadowRoot::cloneNode() which throws an exception.
This also adds an overloaded version cloneNode() to ShadowRoot.idl
which is enabled only for JavaScript instead of changing the
signature of Node::cloneNode().

Note that changing the existing signature can break GObject bindings
compatibility.

Test: fast/dom/shadow/shadowroot-clonenode.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::cloneNode):
(WebCore):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/ShadowRoot.idl:

LayoutTests:

  • fast/dom/shadow/shadowroot-clonenode-expected.txt: Added.
  • fast/dom/shadow/shadowroot-clonenode.html: Added.
4:53 AM Changeset in webkit [127579] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed trivial build fix: Use DOMAllInOne.cpp only if we have xslt available.

  • Target.pri:
4:44 AM Changeset in webkit [127578] by commit-queue@webkit.org
  • 9 edits in trunk

WKTR doesn't implement dumpWillCacheResponse()
https://bugs.webkit.org/show_bug.cgi?id=94607

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Tools:

Define shouldCacheResponse() callback in resource
load client and provide implementation for
dumpWillCacheResponse() in WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldCacheResponse):
(WTR):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::dumpWillCacheResponse):
(WTR::TestRunner::shouldDumpWillCacheResponse):
(TestRunner):

LayoutTests:

Unskip http/tests/misc/willCacheResponse-delegate-callback.html
now that WebKitTestRunner implements dumpWillCacheResponse().

  • platform/efl-wk2/TestExpectations:
  • platform/wk2/Skipped:
4:36 AM Changeset in webkit [127577] by Kaustubh Atrawalkar
  • 49 edits in trunk

[DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
https://bugs.webkit.org/show_bug.cgi?id=92735

Reviewed by Hajime Morita.

.:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Added symbols for GTK builds for corresponding APIs.

  • Source/autotools/symbols.filter:

Source/WebCore:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

Covered by existing test cases.

  • testing/Internals.cpp:

(WebCore::Internals::numberOfPages):
(WebCore):
(WebCore::Internals::pageProperty):
(WebCore::Internals::pageSizeAndMarginsInPixels):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/efl:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/qt:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Kept the function defination and declaration to keep binary compatibility for IWebFramePrivate.idl

  • WebFrame.cpp:

(WebFrame::numberOfPages):

Source/WebKit2:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Add symbols for Mac Win builds for corresponding newly added APIs.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Tools:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::addUserStyleSheet):

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::hasCustomPageSizeStyle):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::evaluateScriptInIsolatedWorld):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:

(TestRunner::abortModal):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Fixed test cases to use internals API instead of testRunner.

  • printing/numberOfPages-expected.txt:
  • printing/page-count-layout-overflow.html:
  • printing/page-count-relayout-shrink.html:
  • printing/page-count-with-one-word.html:
  • printing/page-format-data-display-none.html:
  • printing/page-format-data-expected.txt:
  • printing/page-format-data.html:
  • printing/page-rule-selection-expected.txt:
  • printing/page-rule-selection.html:
  • printing/resources/paged-media-test-utils.js:

(numberOfPagesShouldBe):

  • printing/script-tests/numberOfPages.js:
  • printing/zoomed-document.html:
4:26 AM Changeset in webkit [127576] by Simon Hausmann
  • 3 edits
    1 add in trunk

[Qt] Automate the use of AllInOne files in the Qt build
https://bugs.webkit.org/show_bug.cgi?id=95837

Reviewed by Tor Arne Vestbø.

Source/WebCore:

Replace the manual use of SVGAllInOne.cpp with automated use through
the ALL_IN_ONE_SOURCES variable. This adds a few more all-in-one sources
to the build and leaves out some that do not compile yet due to various
platform-dependant pre-processor macro issues.

  • Target.pri:

Tools:

New feature file that implements the all-in-one file automation by
adding the requested all-in-one files to SOURCES and removing the files
it includes from SOURCES.

  • qmake/mkspecs/features/use_all_in_one_files.prf: Added.
4:24 AM Changeset in webkit [127575] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening after r127513

Marking plugin third-party storage tests as failing on EFL.

  • platform/efl/TestExpectations:
4:04 AM Changeset in webkit [127574] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Fix the uses of String::operator+=() for Mac
https://bugs.webkit.org/show_bug.cgi?id=95818

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-05
Reviewed by Dan Bernstein.

Source/JavaScriptCore:

  • jsc.cpp:

(functionJSCStack): Use StringBuilder to create the stack dump, it is faster
and avoid String::operator+=().

  • parser/Parser.h:

(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
Use the String operators (and makeString) to concatenate the strings.

Source/WebCore:

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::putDelegate):
This is a legitimate use of String::append(), it is the only
concatenation in this function.

  • loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest): Ditto.

4:02 AM Changeset in webkit [127573] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Fuzzy load the Edje theme for HTML forms
https://bugs.webkit.org/show_bug.cgi?id=95832

Reviewed by Gyuyoung Kim.

Change the theme so that it is first loaded when actually used.
This also fixed the case that it was impossible to change theme
a second time.

Tested by current tests. API unit test coming in separate patch.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::setThemePath):
(WebCore::RenderThemeEfl::edje):
(WebCore::RenderThemeEfl::applyPartDescriptions):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

3:56 AM Changeset in webkit [127572] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Blackberry] Add document url and securityOrigin to platform request.
https://bugs.webkit.org/show_bug.cgi?id=95822

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-09-05
Reviewed by George Staikos.
Internally Reviewed by Joe Mason.

It is a webworks requirement.

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

3:00 AM WebKitGTK/1.10.x edited by sergio@webkit.org
(diff)
2:19 AM Changeset in webkit [127571] by loislo@chromium.org
  • 8 edits in trunk/Source

Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers.
https://bugs.webkit.org/show_bug.cgi?id=95739

Reviewed by Yury Semikhatsky.

When we go deeper into different parts of browser like skia, chromium itself etc.
we can't use a single enum for all reported object types.
The current idea is to use plain simple strings as ObjectType identifiers.
In the future patches we will extract these identifiers into separate class or namespace
and and split it between components.

Source/WebCore:

  • dom/MemoryInstrumentation.cpp:

(WebCore):

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::addMemoryBlockFor):
(WebCore):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::countObjectSize):

  • inspector/MemoryInstrumentationImpl.h:

(WebCore::MemoryInstrumentationImpl::totalSize):
(WebCore::MemoryInstrumentationImpl::reportedSizeForAllTypes):
(MemoryInstrumentationImpl):

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::TEST):
(WebCore):

2:07 AM WebKitGTK/1.10.x edited by plaes@plaes.org
Added bug 90098 (diff)
1:55 AM WebKitGTK edited by plaes@plaes.org
Removed spam, updated stable release link to 1.10.x (diff)
1:50 AM Changeset in webkit [127570] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.9.91

Tagging the WebKitGTK+ 1.9.91 release

1:49 AM Changeset in webkit [127569] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.9.90

Tagging the WebKitGTK+ 1.9.90 release

1:41 AM Changeset in webkit [127568] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r127525.

  • platform/graphics/wince/FontCustomPlatformData.h:

(WebCore):

1:41 AM Changeset in webkit [127567] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=95827

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-05

  • platform/qt/Skipped: skip failing test after r127534.
1:40 AM EFLWebKit edited by l.slachciak@samsung.com
Added debian command for dependent packages installation (diff)
1:29 AM Changeset in webkit [127566] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-1.10

Unreviewed. Update NEWS and configure.ac for 1.9.90 release

1:15 AM Changeset in webkit [127565] by zandobersek@gmail.com
  • 6 edits
    5 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining after r126911, r127163 and r127534.

Adding a platform-specific baseline for accessibility/canvas-description-and-role.html
that's required after r127084. The baseline is currently the same as Chromium's,
expecting 'AXCanvas' as the AXRole for the canvas element. The GTK port currently
reports 'image' as the AXRole - this is probably not intended so the text failure
expectation is also added for this test.

  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.
  • platform/gtk/fast/block/float/024-expected.txt:
  • platform/gtk/fast/block/margin-collapse/025-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
  • platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
  • platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
  • platform/gtk/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
1:05 AM Changeset in webkit [127564] by yosin@chromium.org
  • 1 edit
    14 adds in trunk/LayoutTests

[Tests] We should have interactive validation of required value for the "input" element
https://bugs.webkit.org/show_bug.cgi?id=95817

Reviewed by Kent Tamura.

This patch adds tests for required attribute handling on form
submission of input types. The test script is parametrized for
input type and expected type. Each test file simply call one test
script in common-interactive-validation-required.js.

The test script checks:

  • Don't submit form when required value isn't presented.
  • Submit form when required value is presented.
  • fast/forms/date/date-interactive-validation-required-expected.txt: Added.
  • fast/forms/date/date-interactive-validation-required.html: Added.
  • fast/forms/datetime/datetime-interactive-validation-required-expected.txt: Added.
  • fast/forms/datetime/datetime-interactive-validation-required.html: Added.
  • fast/forms/datetimelocal/datetimelocal-interactive-validation-required-expected.txt: Added.
  • fast/forms/datetimelocal/datetimelocal-interactive-validation-required.html: Added.
  • fast/forms/month/month-interactive-validation-required-expected.txt: Added.
  • fast/forms/month/month-interactive-validation-required.html: Added.
  • fast/forms/number/number-interactive-validation-required-expected.txt: Added.
  • fast/forms/number/number-interactive-validation-required.html: Added.
  • fast/forms/resources/common-interactive-validation-required.js: Added.
  • fast/forms/time/time-interactive-validation-required-expected.txt: Added.
  • fast/forms/time/time-interactive-validation-required.html: Added.
  • fast/forms/week/week-interactive-validation-required-expected.txt: Added.
  • fast/forms/week/week-interactive-validation-required.html: Added.
1:00 AM Changeset in webkit [127563] by mikelawther@chromium.org
  • 2 edits
    1 copy
    1 add
    1 delete in trunk/LayoutTests

Moved mac results to be the generic results, and the existing result to be the chromium
platform result. The current result uses subpixel layout, which is not the norm.

Original results were added in r127557. Mac results were added in r127560.

  • css3/calc/zoom-with-em-expected.txt:
  • platform/chromium/css3/calc/zoom-with-em-expected.txt: Copied from LayoutTests/css3/calc/zoom-with-em-expected.txt.
  • platform/mac/css3/calc/zoom-with-em-expected.txt: Removed.
12:56 AM Changeset in webkit [127562] by yosin@chromium.org
  • 3 edits in trunk/LayoutTests

Test cases for Up/Down key behavior on field which has maximum/minimum in multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=95824

Reviewed by Kent Tamura.

This patch adds test cases for Up/Down key behavior on field which has
maximum/minimum value in multiple fields time input UI.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Updated expectation for new test cases.
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Changed to add test cases for Up key behavior for "23:59:59.999" (11:59:59.999PM in UI) and Down key behavior for "01:00:00.000" (01:00:00.000 AM in UI)
12:51 AM Changeset in webkit [127561] by rgabor@webkit.org
  • 6 edits in trunk/Source

DFG JIT doesn't work properly on ARM hardfp
https://bugs.webkit.org/show_bug.cgi?id=95684

Reviewed by Filip Pizlo.

Add hardfp support to DFG JIT. The patch is created with the
help of Zoltan Herczeg.

Source/JavaScriptCore:

  • dfg/DFGCCallHelpers.h:

(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArguments):

  • dfg/DFGFPRInfo.h:

(FPRInfo):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):

Source/WTF:

  • wtf/Platform.h:
12:22 AM Changeset in webkit [127560] by mitz@apple.com
  • 1 edit
    1 copy
    1 add in trunk/LayoutTests

Added Mac-specific expected results for a test added in r127557. The generic results are
probably from a build with subpixel layout.

  • platform/mac/css3/calc: Added.
  • platform/mac/css3/calc/zoom-with-em-expected.txt: Copied from LayoutTests/css3/calc/zoom-with-em-expected.txt.
12:16 AM Changeset in webkit [127559] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] QRawWebViewPrivate does not initialize some members
https://bugs.webkit.org/show_bug.cgi?id=95709

Reviewed by Luiz Agostini.

Don't miss initializing the bool flags.

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebViewPrivate::QRawWebViewPrivate):

Sep 4, 2012:

11:35 PM Changeset in webkit [127558] by keishi@webkit.org
  • 11 edits
    3 copies
    1 add in trunk/Source

Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=95681

Reviewed by Kent Tamura.

Source/WebCore:

We are moving calendar picker PagePopupClient to WebKit layer so ports
can use their platform native chooser UI if they have one.
DateTimeChooser, DateTimeChooserClient etc. will be reused when we
implement the week picker and month picker.

No new tests. No behavior change. Covered by existing calendar picker tests.

  • WebCore.gypi:
  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::CalendarPickerElement):
(WebCore::CalendarPickerElement::~CalendarPickerElement):
(WebCore::CalendarPickerElement::didChooseValue): Called when user chose a value.
(WebCore):
(WebCore::CalendarPickerElement::didEndChooser): Called when chooser has ended.
(WebCore::CalendarPickerElement::openPopup):
(WebCore::CalendarPickerElement::closePopup):

  • html/shadow/CalendarPickerElement.h:

(CalendarPickerElement):

  • loader/EmptyClients.cpp:

(WebCore):
(WebCore::EmptyChromeClient::openDateTimeChooser):

  • loader/EmptyClients.h:

(EmptyChromeClient):

  • page/ChromeClient.h:

(WebCore):
(ChromeClient):

  • platform/DateTimeChooser.h:

(WebCore):
(DateTimeChooserParameters): Contains information needed to open the DateTimeChooser.
(DateTimeChooser):
(WebCore::DateTimeChooser::~DateTimeChooser):

  • platform/DateTimeChooserClient.h:

(WebCore):
(DateTimeChooserClient):
(WebCore::DateTimeChooserClient::~DateTimeChooserClient):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/ChromeClientImpl.cpp:

(WebKit):
(WebKit::ChromeClientImpl::openDateTimeChooser):

  • src/ChromeClientImpl.h:

(WebCore):
(ChromeClientImpl):

  • src/DateTimeChooserImpl.cpp: Added.

(WebKit):
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::~DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::endChooser):
(WebKit::DateTimeChooserImpl::contentSize):
(WebKit::DateTimeChooserImpl::writeDocument):
(WebKit::DateTimeChooserImpl::setValueAndClosePopup):
(WebKit::DateTimeChooserImpl::didClosePopup):

  • src/DateTimeChooserImpl.h:

(WebCore):
(WebKit):
(DateTimeChooserImpl):

11:28 PM Changeset in webkit [127557] by mikelawther@chromium.org
  • 3 edits
    2 adds in trunk

CSS3 calc: expressions with 'em' units do not zoom correctly.
https://bugs.webkit.org/show_bug.cgi?id=95705

Reviewed by Ojan Vafai.

Source/WebCore:

Each primitive value in a CSS calc expression now has (zoom) multiplier and scale factor applied
independently. Previously the multiplier and a single scale factor was applied to the expression
as a whole, but this failed to account for expressions involving font relative units. This is
because the multiplier should not be applied to font relative units.

Test: css3/calc/zoom-with-em.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLengthDouble):

LayoutTests:

  • css3/calc/zoom-with-em-expected.txt: Added.
  • css3/calc/zoom-with-em.html: Added.
11:07 PM Changeset in webkit [127556] by commit-queue@webkit.org
  • 13 edits in trunk/Source

[chromium] Prevent compositor ticking if it can't draw
https://bugs.webkit.org/show_bug.cgi?id=95399

Patch by Brian Anderson <brianderson@chromium.org> on 2012-09-04
Reviewed by James Robinson.

Background extensions had an always ticking compositor even though
they couldn't draw. This patch disables the ticks when canDraw is false
and adds a notification mechanism for when canDraw changes states so
we can recover properly.

Tests updated for new interfaces.
Regression test added to make sure ticking stops when canDraw is false.
notifyIfCanDrawChanged test added to make sure notifications are sent
for any changes that might affect canDraw.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::notifyIfCanDrawChanged):
(WebCore):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::initializeRenderer):
(WebCore::CCLayerTreeHostImpl::setViewportSize):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):
(WebCore::CCLayerTreeHostImpl::resetContentsTexturesPurged):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setCanDraw):
(WebCore):
(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::toString):
(WebCore):
(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(CCSchedulerStateMachine):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::onCanDrawStateChanged):
(WebCore):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:
10:33 PM Changeset in webkit [127555] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp
https://bugs.webkit.org/show_bug.cgi?id=95800

Patch by Adam Barth <abarth@chromium.org> on 2012-09-04
Reviewed by Benjamin Poulain.

This patch is a re-spin of part of the patch from
https://bugs.webkit.org/show_bug.cgi?id=95502, but with the tests
fixed. :)

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):

10:14 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Fix typo. (diff)
10:12 PM Changeset in webkit [127554] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Allow the YarrJIT to use the assembler even when useJIT() is false.
Introduce the useYarrJIT() option.
https://bugs.webkit.org/show_bug.cgi?id=95809.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-04
Reviewed by Geoffrey Garen.

  • runtime/JSGlobalData.cpp:

(JSC::enableAssembler):

  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/Options.h:

(JSC):

10:12 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Fix typo. (diff)
10:08 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Expand "Japanse or Chinese" to "Chinese, Japanese, or Korean". (diff)
9:53 PM Changeset in webkit [127553] by keishi@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r126132): MediaSlider and MediaVolumeSlider thumbs don't match mouse when dragged
https://bugs.webkit.org/show_bug.cgi?id=95701

Reviewed by Kent Tamura.

Source/WebCore:

MediaSlider and MediaVolumeSlider thumbs didn't match mouse when dragged because of the negative margin applied to the thumb.

Test: platform/chromium/media/media-volume-slider-hit-test.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint): Account for margins when calculating the position.

LayoutTests:

  • platform/chromium/media/media-volume-slider-hit-test-expected.txt: Added.
  • platform/chromium/media/media-volume-slider-hit-test.html: Added.
9:40 PM Changeset in webkit [127552] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Use explicit constructor in InjectedBundle.
https://bugs.webkit.org/show_bug.cgi?id=95746

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-04
Reviewed by Sam Weinig.

Added explicit keyword in constructor of InjectedBundle in order to avoid implicit type conversion.

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

9:27 PM Changeset in webkit [127551] by tkent@chromium.org
  • 5 edits in trunk/LayoutTests

[Chromium] Update test expectation
https://bugs.webkit.org/show_bug.cgi?id=95395

  • platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium/TestExpectations:
9:16 PM Changeset in webkit [127550] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectatino update.

  • platform/chromium/TestExpectations:

japanese-ruby-vertical-*.html might be flaky on Windows too.

9:14 PM Changeset in webkit [127549] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Add a const version of RenderBox::computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=95787

Reviewed by Ojan Vafai.

After this, we can rename the old computeLogicalHeight to computeAndSetLogicalHeight
to make it clear that it is modifying values.

No new tests, this should just be a refactor.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalHeightByMinMax): Make const.
(WebCore::RenderBox::computeLogicalHeight): Add a const version that takes a LogicalExtentComputedValues struct for out values.
(WebCore::RenderBox::computeLogicalHeightUsing): Make const.
(WebCore::RenderBox::computeContentLogicalHeightUsing): Make const.
(WebCore::RenderBox::computePercentageLogicalHeight): Add a const cast. I tried to
convert everything below to const, but that's not a simple task. Also, computeReplacedLogicalHeightUsing
is already using a const_cast.

  • rendering/RenderBox.h:

(RenderBox): Add const to method signatures.

8:57 PM Changeset in webkit [127548] by krit@webkit.org
  • 3 edits
    2 adds in trunk

-webkit-clip-path does not apply origin for polygon()
https://bugs.webkit.org/show_bug.cgi?id=95656

Reviewed by Tim Horton.

Source/WebCore:

The polygon() shape function did not apply origin of bouding box on created path. The shape was
not moved to the correct position.

Tests: svg/clip-path/clip-path-shape-polygon-relative-expected.svg

svg/clip-path/clip-path-shape-polygon-relative.svg

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapePolygon::path): Apply origin of bounding box.

LayoutTests:

Check that the origin of the bounding box gets applied to the clip path.

  • svg/clip-path/clip-path-shape-polygon-relative-expected.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-relative.svg: Added.
8:45 PM Changeset in webkit [127547] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Have NRWT log more output when crash logs are missing
https://bugs.webkit.org/show_bug.cgi?id=95814

Reviewed by Dan Bernstein.

Log the stderr and stdout of the test, in order to provide slightly more
context when the WebProcess times out while running tests.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test):

8:33 PM Changeset in webkit [127546] by bashi@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r127534

  • platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.
7:48 PM Changeset in webkit [127545] by jchaffraix@webkit.org
  • 1 edit
    1 copy in branches/chromium/1229

Merge 127520 - REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
https://bugs.webkit.org/show_bug.cgi?id=95776

Reviewed by Simon Fraser.

.:

  • ManualTests/select-menu-list-wrongly-positioned.html: Added.

Source/WebCore:

r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.

Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10908086

7:36 PM Changeset in webkit [127544] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

inc/dec behave incorrectly operating on a resolved const
https://bugs.webkit.org/show_bug.cgi?id=95815

Reviewed by Geoff Garen.

Source/JavaScriptCore:

There are two bugs here.

(1) When the value being incremented is const, and the result is ignored, we assume this cannot be observed, and emit no code.

However if the value being incremented is not a primitive & has a valueOf conversion, then this should be being called.

(2) In the case of a pre-increment of a const value where the result is not ignored, we'll move +/-1 to the destination, then

add the resolved const value being incremented to this. This is problematic if the destination is a local, and the const
value being incremented has a valueOf conversion that throws - the destination will be modified erroneously. Instead, we
need to use a temporary location.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):

  • always at least perform a toNumber conversion, use tempDestination when reducing inc/dec to an add +/-1.

LayoutTests:

Added test cases.

  • fast/js/inc-const-valueOf-expected.txt: Added.
  • fast/js/inc-const-valueOf.html: Added.
  • fast/js/script-tests/inc-const-valueOf.js: Added.

(testPostIncConstVarWithIgnoredResult.const.a.valueOf):
(testPostIncConstVarWithIgnoredResult):

test that 'a++' results in a valueOf call, where 'a' is const.

(testPreIncConstVarWithIgnoredResult.const.a.valueOf):
(testPreIncConstVarWithIgnoredResult):

test that '++a' results in a valueOf call, where 'a' is const.

(testPreIncConstVarWithAssign.const.a.valueOf):
(testPreIncConstVarWithAssign):

test that 'b = ++a' does not erroneously update 'b', where 'a' is const.

7:28 PM Changeset in webkit [127543] by tkent@chromium.org
  • 71 edits
    8 copies
    1 move
    25 adds
    4 deletes in trunk/LayoutTests

[Chromium] Test expectation update

Rebaseline vertical-writing tests.

  • platform/chromium-linux-x86/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/chromium-linux-x86/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
  • platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt.
  • platform/chromium-mac/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/chromium-mac/fast/writing-mode/japanese-rl-selection-expected.png: Added.
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt.
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt.
  • platform/chromium-win-xp/fast/dynamic/text-combine-expected.png:
  • platform/chromium-win-xp/fast/dynamic/text-combine-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.png:
  • platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt.
  • platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.txt: Added.
  • platform/chromium-win-xp/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-win-xp/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/chromium-win-xp/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.png: Removed.
  • platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
  • platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.png: Removed.
  • platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/vertical-align-table-baseline-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt.
  • platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/chromium-win/fast/dynamic/text-combine-expected.png:
  • platform/chromium-win/fast/dynamic/text-combine-expected.txt:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png:
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/chromium-win/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-win/fast/text/international/text-spliced-font-expected.txt:
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.png:
  • platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/chromium-win/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Removed.
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/chromium-win/fast/writing-mode/vertical-align-table-baseline-expected.png:
  • platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
  • platform/chromium/TestExpectations:
6:55 PM Changeset in webkit [127542] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky media/video tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95806

  • platform/win/Skipped:
6:45 PM Changeset in webkit [127541] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky http/tests/cookies tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95805

  • platform/win/Skipped:
6:43 PM Changeset in webkit [127540] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
https://bugs.webkit.org/show_bug.cgi?id=95798

Patch by Adam Barth <abarth@chromium.org> on 2012-09-04
Reviewed by Eric Seidel.

Source/WebCore:

This patch makes the chromium-linux port build without
WTF::String::operator+=. There are a couple places that require some
more careful study, and I've whitelisted those uses by defining
WTF_DEPRECATED_STRING_OPERATORS at the top of the files. (See
https://bugs.webkit.org/show_bug.cgi?id=95797 for an explanation of
WTF_DEPRECATED_STRING_OPERATORS.)

  • css/StylePropertySet.cpp:
  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::drawNodeHighlight):

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::rewriteMixVertexShader):

Source/WebKit/chromium:

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::keyboardShortcut):

  • Remove use of WTF::String::operator+=
  • src/WebPageSerializerImpl.cpp:
    • Whitelist use of WTF::String::operator+=. Remove this use will take some more careful thought.
6:38 PM Changeset in webkit [127539] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky http/tests/security tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95803

  • platform/win/Skipped:
6:31 PM Changeset in webkit [127538] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Use TrackedRendererListHashSet typedef for percentHeightDescendants()
https://bugs.webkit.org/show_bug.cgi?id=95791

Reviewed by Ojan Vafai.

There were a couple callers that were using ListHashSet<RenderBox*> instead of the typedef.

No new tests, this is just a refactor.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderView.cpp:

(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):

6:30 PM Changeset in webkit [127537] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky inspector tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95802

  • platform/win/Skipped:
6:27 PM Changeset in webkit [127536] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
https://bugs.webkit.org/show_bug.cgi?id=95717

Reviewed by Oliver Hunt.

Rolling back in after fixing the negative index case.

Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
there so we should just use it!

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:56 PM Changeset in webkit [127535] by commit-queue@webkit.org
  • 13 edits
    3 deletes in trunk/Source

IndexedDB: remove final createIndex backend glue
https://bugs.webkit.org/show_bug.cgi?id=95385

Patch by Alec Flett <alecflett@chromium.org> on 2012-09-04
Reviewed by Adam Barth.

Source/WebCore:

Remove all code that created index keys in the IndexedDB backend.

No new tests, this is just removal of dead code.

  • Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Removed.
  • Modules/indexeddb/IDBKeyPathBackendImpl.h: Removed.
  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • storage/chromium/IDBKeyPathBackendImpl.cpp: Removed.

Source/WebKit/chromium:

Remove chromium glue for old key-generation code.

  • public/WebIDBKey.h:

(WebIDBKey):

  • src/WebIDBKey.cpp:
5:40 PM Changeset in webkit [127534] by commit-queue@webkit.org
  • 8 edits
    1 copy
    4 adds in trunk

Frame element doesn't always unload its child frame.
https://bugs.webkit.org/show_bug.cgi?id=94717

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2012-09-04
Reviewed by Hajime Morita.

Source/WebCore:

It's possible for a frame element that has been removed from the document
to retain an active child frame. This inconsistent state may become a source
of security vulnerabilities.

The patch adds a global HashSet to store the nodes currently processed by
ChildFrameDisconnector. Insertion into these nodes' subtrees is not allowed until
the processing is complete.

Also, the ChildFrameDisconnector call in removeChild(ren) is now immediately
followed by the actual removal.

Test: fast/frames/out-of-document-iframe-has-child-frame.html

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChildren): Move the ChildFrameDisconnector call out of a loop.
(WebCore::ContainerNode::removeChild): Rearrange some event firing code.
(WebCore::ContainerNode::removeChildren): Ditto.

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildFrameDisconnector::collectDescendant): Pass a new parameter to collectDescendant(Node*).

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(ChildFrameDisconnector): Maintain a list of nodes that have an active ChildFrameDisconnector.
(WebCore::ChildFrameDisconnector::~ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::rootNodes):
(WebCore::ChildFrameDisconnector::collectDescendant): Add ShouldIncludeRoot parameter.
(WebCore::ChildFrameDisconnector::nodeHasDisconnector):
(WebCore):

  • dom/Node.cpp:

(WebCore::checkAcceptChild): Reject a parent node if it or one of its parents has an active ChildFrameDisconnector.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Check if an element is still in the document.

LayoutTests:

  • fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
  • fast/frames/out-of-document-iframe-has-child-frame.html: Added.
  • fast/innerHTML/innerHTML-iframe-expected.txt:
  • platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
  • platform/chromium/fast/innerHTML: Added.
  • platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
5:28 PM Changeset in webkit [127533] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation update after r127457

  • platform/chromium/TestExpectations:
5:25 PM Changeset in webkit [127532] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Adding test inspector/timeline/timeline-decode-resize.html to Windows skip list.
It fails on both Windows and Mac: https://bugs.webkit.org/show_bug.cgi?id=94374.

  • platform/win/Skipped:
5:23 PM Changeset in webkit [127531] by mrowe@apple.com
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

5:21 PM Changeset in webkit [127530] by mrowe@apple.com
  • 1 copy in tags/Safari-536.26.13

New tag.

5:21 PM Changeset in webkit [127529] by mrowe@apple.com
  • 1 delete in tags/Safari-536.26.13

Remove tag.

5:18 PM Changeset in webkit [127528] by mrowe@apple.com
  • 1 edit in branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

Build fix.

5:09 PM Changeset in webkit [127527] by roger_fong@apple.com
  • 7 edits in trunk/LayoutTests

Unreviewed. Rebaseline tests after http://trac.webkit.org/changeset/127354.

  • platform/win/fast/text/international/text-spliced-font-expected.txt:
  • platform/win/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/win/fast/writing-mode/japanese-lr-selection-expected.txt:
  • platform/win/fast/writing-mode/japanese-lr-text-expected.txt:
  • platform/win/fast/writing-mode/japanese-rl-selection-expected.txt:
  • platform/win/fast/writing-mode/japanese-rl-text-expected.txt:
5:07 PM Changeset in webkit [127526] by bashi@chromium.org
  • 2 edits in trunk/Source/Platform

[Chromium] Attempt to fix build failure on Win

Remove chromium/public/WebOfferAnswerRequest.h from Platform.gypi,
which was added in r127501, but doesn't exist. Unreviewed.

  • Platform.gypi:
4:58 PM Changeset in webkit [127525] by weinig@apple.com
  • 19 edits
    1 move in trunk/Source

Part 1 of removing PlatformString.h, move remaining functions to new homes
https://bugs.webkit.org/show_bug.cgi?id=95702

Reviewed by Beth Dakin.

Source/WebCore:

Move utf8Buffer() to SharedBuffer.h/cpp
Move numGraphemeClusters() and numCharactersInGraphemeClusters() to TextBreakIterator.h/cpp

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Update projects.

  • platform/text/TextAllInOne.cpp:

Add TextBreakIterator.cpp.

  • editing/Editor.h:

Forward declare SharedBuffer, now that PlatformString.h doesn't.

  • html/InputType.cpp:

#include TextBreakIterator.h.

  • loader/appcache/ApplicationCacheStorage.h:

Replace inclusion of PlatformString.h with WTFString.h and forward declare SharedBuffer.

  • platform/LocalizedStrings.cpp:

Replace inclusion of PlatformString.h with TextBreakIterator.h

  • platform/SharedBuffer.cpp:
  • platform/SharedBuffer.h:

Move utf8Buffer() here.

  • platform/text/PlatformString.h:

Remove everything except the #include of WTFString.h.

  • platform/text/TextBreakIterator.cpp: Renamed from Source/WebCore/platform/text/String.cpp.

(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):

  • platform/text/TextBreakIterator.h:

Move numGraphemeClusters() and numCharactersInGraphemeClusters() here.

Source/WebKit2:

  • UIProcess/WebPageProxy.h:

Forward declare SharedBuffer.

4:56 PM Changeset in webkit [127524] by mrowe@apple.com
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Merge r127319.

4:56 PM Changeset in webkit [127523] by mrowe@apple.com
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Merge r127272.

4:56 PM Changeset in webkit [127522] by mrowe@apple.com
  • 9 edits
    2 adds in branches/safari-536.26-branch

Merge r127047.

4:45 PM Changeset in webkit [127521] by mrowe@apple.com
  • 1 copy in tags/Safari-536.26.13

New tag.

4:39 PM Changeset in webkit [127520] by jchaffraix@webkit.org
  • 3 edits
    1 add in trunk

REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
https://bugs.webkit.org/show_bug.cgi?id=95776

Reviewed by Simon Fraser.

.:

  • ManualTests/select-menu-list-wrongly-positioned.html: Added.

Source/WebCore:

r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.

Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.

4:34 PM Changeset in webkit [127519] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows since introduced in http://trac.webkit.org/changeset/126865.
Test added to skip list.

https://bugs.webkit.org/show_bug.cgi?id=95795

  • platform/win/Skipped:
4:34 PM Changeset in webkit [127518] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired
https://bugs.webkit.org/show_bug.cgi?id=95777

Reviewed by Tony Chang.

IDBRequests are kept alive as long as they may fire events, which includes
if the associated IDBCursor object can be advanced. When the transaction
is finished the IDBCursor is notified which in turn tells the IDBRequest
that the cursor won't be the source of more events. However, if this occurs
and no further events fire the IDBRequest doesn't clear it's "has pending
activity flag". Clear the flag on the notification if the request is
otherwise complete.

No new tests - ActiveDOMObjects and leaks are persnickety.

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::finishCursor):

3:53 PM Changeset in webkit [127517] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion blend modes.
https://bugs.webkit.org/show_bug.cgi?id=93870

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-04
Reviewed by Dirk Schulze.

Source/WebCore:

Add expressions for the aforementioned blend modes. The expressions are lifted directly
from the CSS Compositing and Blending spec [1]. WebKit adds these blending expressions to
the author's shader.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnormal

Test: css3/filters/custom/custom-filter-blend-modes.html

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::blendFunctionString):

LayoutTests:

Add test to check that the DOM element texture blends correctly with the css_MixColor
variable from the author's shader for each blend mode.

  • css3/filters/custom/custom-filter-blend-modes-expected.html: Added.
  • css3/filters/custom/custom-filter-blend-modes.html: Added.
  • css3/filters/resources/mix-color.fs: Added.
3:34 PM Changeset in webkit [127516] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r127503.
http://trac.webkit.org/changeset/127503
https://bugs.webkit.org/show_bug.cgi?id=95788

broke some tests (fast/js/dfg-negative-array-index, fast/js
/dfg-put-by-val-setter-then-get-by-val) (Requested by thorton
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-04

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:27 PM Changeset in webkit [127515] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] FatFingers::cachingStrategy uses incorrect enum value
https://bugs.webkit.org/show_bug.cgi?id=95783

Reviewed by Antonio Gomes.

Use the correct enum values.

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::cachingStrategy):

3:22 PM Changeset in webkit [127514] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix style for Event.h
https://bugs.webkit.org/show_bug.cgi?id=95779

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-09-04
Reviewed by Eric Seidel.

Changes indenting for Event.h to match style guidelines for namespaces

  • dom/Event.h:
3:20 PM Changeset in webkit [127513] by jpfau@apple.com
  • 6 edits
    12 adds in trunk

Make plugins respect third-party storage blocking setting
https://bugs.webkit.org/show_bug.cgi?id=94888

Reviewed by Brady Eidson.

Source/WebCore:

Added functions for discerning if a plugin should be able to access its storage in its current origin.

Tests: http/tests/security/cross-origin-plugin-allowed.html

http/tests/security/cross-origin-plugin.html

  • WebCore.exp.in: Export FrameTree::top and SecurityOrigin::canAccessStorage
  • page/SecurityOrigin.h: Added canAccessPluginStorage

(WebCore::SecurityOrigin::canAccessPluginStorage):

Source/WebKit2:

Plugins that are in a third-party context should be put into private browsing mode so their storage is temporary.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::isPrivateBrowsingEnabled): Put the plugin into private browsing mode if it is in a third-party context.
(WebKit::PluginView::privateBrowsingStateChanged): Make sure a plugin doesn't leave private browsing mode if it's in a third-party context.

LayoutTests:

Created tests for plugins in a third party and first party context when third-party blocking is on and off.

  • http/tests/security/cross-origin-plugin-allowed-expected.txt: Added.
  • http/tests/security/cross-origin-plugin-allowed.html: Added.
  • http/tests/security/cross-origin-plugin-expected.txt: Added.
  • http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed-expected.txt: Added.
  • http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html: Added.
  • http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.
  • http/tests/security/cross-origin-plugin-private-browsing-toggled.html: Added.
  • http/tests/security/cross-origin-plugin.html: Added.
  • http/tests/security/resources/cross-origin-iframe-for-plugin.html: Added.
  • http/tests/security/resources/cross-origin-iframe-for-plugin-async.html: Added.
  • platform/mac-wk2/http/tests/security/cross-origin-plugin-expected.txt: Added.
  • platform/mac-wk2/http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.
3:14 PM Changeset in webkit [127512] by wangxianzhu@chromium.org
  • 3 edits in trunk/Tools

[Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
https://bugs.webkit.org/show_bug.cgi?id=95770

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._log_error): Added to replace original _log.error().
(ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
(ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
(ChromiumAndroidDriver._push_executable):
(ChromiumAndroidDriver._push_fonts):
(ChromiumAndroidDriver._push_test_resources):
(ChromiumAndroidDriver._run_adb_command):
(ChromiumAndroidDriver._get_last_stacktrace):
(ChromiumAndroidDriver._get_crash_log):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._start_once):
(ChromiumAndroidDriver._start_once.deadlock_detector):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidDriverTest.test_get_crash_log):

3:14 PM Changeset in webkit [127511] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Rebaseline Windows expected results for accessibility\canvas-description-and-role-expected.txt.
One of the results in the test now passes.

  • platform/win/accessibility/canvas-description-and-role-expected.txt:
2:48 PM Changeset in webkit [127510] by wangxianzhu@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed. Update test expectations for Android.

  • platform/chromium-android/TestExpectations:
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
  • platform/chromium/TestExpectations:
2:35 PM Changeset in webkit [127509] by robert@webkit.org
  • 3 edits
    2 adds in trunk

Regression(r127163): Heap-use-after-free in WebCore::RenderBoxModelObject::hasSelfPaintingLayer
https://bugs.webkit.org/show_bug.cgi?id=95632

Reviewed by Abhishek Arya.

Source/WebCore:

Don't add floats to the floating object set of blocks that avoid floats. There's no point in doing that
and they will never get cleared out during relayout.

Tests: fast/css/intruding-floats-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloatsIfNeeded):

LayoutTests:

  • fast/css/intruding-floats-crash-expected.txt: Added.
  • fast/css/intruding-floats-crash.html: Added.
2:32 PM Changeset in webkit [127508] by msaboff@apple.com
  • 3 edits
    2 adds in trunk

equal() in CSSParser.cpp should check the length of characters
https://bugs.webkit.org/show_bug.cgi?id=95706

Source/WebCore:

Reviewed by Abhishek Arya.

Pass the length of string literals to CSSParser static functions equal() and
equalIgnoringCase() so that checks won't access out of bounds memory.

Added test fast/css/crash-comparing-equal.html.

  • css/CSSParser.cpp:

(WebCore::equal): Use template to retrieve the length of string literal.
(WebCore::equalIgnoringCase): Ditto.
(WebCore::CSSParser::parseDashboardRegions): Use const char[] instead of const char*

LayoutTests:

Added test from duplicate defect https://bugs.webkit.org/show_bug.cgi?id=95634.

Reviewed by Abhishek Arya.

  • fast/css/crash-comparing-equal-expected.txt: Added.
  • fast/css/crash-comparing-equal.html: Added.
2:23 PM Changeset in webkit [127507] by satish@chromium.org
  • 2 edits in trunk/Tools

Run git commands within the checkout directory
https://bugs.webkit.org/show_bug.cgi?id=95742

Reviewed by Eric Seidel.

git commands run from scm/git.py are sometimes run with cwd set to the
checkout_root and other times with whatever directory was the default cwd.
Instead all these should run with the checkout root set as the cwd
(except where we explicitly need a different path)

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git._run_git):
(Git.find_checkout_root):
(Git.discard_local_commits):
(Git.local_commits):
(Git.working_directory_is_clean):
(Git.clean_working_directory):
(Git.add_list):
(Git.delete_list):
(Git.exists):
(Git._current_branch):
(Git._changes_files_for_commit):
(Git.revisions_changing_file):
(Git.svn_revision):
(Git._run_git_svn_find_rev):
(Git.contents_at_revision):
(Git.diff_for_file):
(Git.show_head):
(Git.committer_email_for_revision):
(Git.apply_reverse_diff):
(Git.revert_files):
(Git.commit_with_message):
(Git._commit_on_branch):
(Git.svn_commit_log):
(Git.last_svn_commit_log):
(Git.svn_blame):
(Git._branch_ref_exists):
(Git.delete_branch):
(Git.remote_merge_base):
(Git.commit_locally_with_message):
(Git.push_local_commits_to_server):
(Git.commit_ids_from_commitish_arguments):
(Git.commit_message_for_local_commit):
(Git.files_changed_summary_for_commit):

2:21 PM Changeset in webkit [127506] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. meda/video-controls-captions.html fails on Windows after it was introduced in http://trac.webkit.org/changeset/127035.
https://bugs.webkit.org/show_bug.cgi?id=95428

  • platform/win/Skipped:
2:19 PM Changeset in webkit [127505] by benjamin@webkit.org
  • 39 edits in trunk/Source/JavaScriptCore

Improve JSC use of Strings after the UString->String change
https://bugs.webkit.org/show_bug.cgi?id=95633

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-04
Reviewed by Geoffrey Garen.

This patch improve the use of strings in the JSC runtime.

The initialization of Identifier is left for future patches.

The improvements are the following:
-5% faster to raise one of the modified exception.
-3 times faster to execute Boolean::toString()

Most of the changes are just about using the new methods
for string literals.

With the changes, the binary on x86_64 gets 176 bytes smaller.

  • API/JSCallbackObjectFunctions.h:

(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

  • API/JSContextRef.cpp:

(JSContextCreateBacktrace):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunctionWithCallback):

  • bytecode/CodeBlock.cpp:

(JSC::valueToSourceString):
(JSC::CodeBlock::nameForRegister):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::addStackTraceIfNecessary):

  • runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

  • runtime/ArrayPrototype.cpp:

(JSC::shift):
(JSC::unshift):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):

  • runtime/BooleanPrototype.cpp:

(JSC::booleanProtoFuncToString): Instead of instanciating new strings, reuse the
keywords available in SmallStrings. Avoiding the creation of the JSString and StringImpl
makes the method significantly faster.

  • runtime/DateConversion.cpp:

(JSC::formatDateTime):

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::formateDateInstance):
(JSC::dateProtoFuncToISOString):
Change the way we use snprintf() for clarity and performance.

Instead of allocating one extra byte to put a zero "just in case", we use the size returned
by snprintf().
To prevent any overflow from a programming mistake, we explicitely test for overflow and
return an empty string.

(JSC::dateProtoFuncToJSON):

  • runtime/Error.cpp:

(JSC::createNotEnoughArgumentsError):
(JSC::throwTypeError):
(JSC::throwSyntaxError):

  • runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::create):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::finishCreation):
(JSC::errorProtoFuncToString):
Using a null String is correct because (8) uses jsString(), (9) tests for a length of 0.

  • runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
(JSC::createStackOverflowError):
(JSC::createOutOfMemoryError):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::FunctionExecutable::paramString):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/FunctionPrototype.h:

(JSC::FunctionPrototype::create):
Using a null String for the name is correct because InternalFunction uses jsString()
to create the name value.

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):
There is no need to create an empty string for a null string, jsString() handle both
cases as empty JSString.

  • runtime/JSArray.cpp:

(JSC::reject):
(JSC::SparseArrayValueMap::put):
(JSC::JSArray::put):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation): Same issue as InternalFunction::finishCreation.

(JSC::JSFunction::callerGetter):
(JSC::JSFunction::defineOwnProperty):

  • runtime/JSGlobalData.cpp:

(JSC::enableAssembler): Use CFSTR() instead of CFStringCreateWithCString().
CFStringCreateWithCString() copy the content and may choose to decode the data.
CFSTR() is much more efficient.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
JSFunction uses jsString() to create the name, we can use null strings instead
of creating empty strings.

(JSC::JSGlobalObject::createThrowTypeError): ditto.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncEval):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::defaultValue):
(JSC::JSObject::hasInstance):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSString.cpp:

Return an empty JSString to avoid the creation of a temporary empty String.

(JSC::JSRopeString::getIndexSlowCase):

  • runtime/JSString.h:

(JSC): Remove the versions of jsNontrivialString() taking a char*. All the callers
have been replaced by calls using ASCIILiteral.

  • runtime/JSValue.cpp:

(JSC::JSValue::putToPrimitive):

  • runtime/LiteralParser.cpp:

(JSC::::Lexer::lex):
(JSC::::Lexer::lexString):
(JSC::::Lexer::lexNumber):
(JSC::::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
(JSC::objectConstructorIsExtensible):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncToString):

  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpObject.cpp:

(JSC::reject):
(JSC::regExpObjectSource):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

  • runtime/StringObject.cpp:

(JSC::StringObject::defineOwnProperty):

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):

2:16 PM Changeset in webkit [127504] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

2:15 PM Changeset in webkit [127503] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
https://bugs.webkit.org/show_bug.cgi?id=95717

Reviewed by Oliver Hunt.

Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
there so we should just use it!

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

2:10 PM Changeset in webkit [127502] by tonikitoo@webkit.org
  • 12 edits in trunk/Source

[BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
https://bugs.webkit.org/show_bug.cgi?id=95778
PR #202252

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Arvid Nilsson.

Upstream has switch away from using the parent scroll layer's bounds origin
in order to translate contents of all its child layers. Instead now, it directly
sets the scroll position of the child scrollable contents layer.

Source/WebCore:

No new tests, since it is a catch-up with upstreaming code.

Source/WebCore:

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(GraphicsLayerBlackBerry):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::updateAnimations):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerOverride::LayerOverride):
(LayerOverride):

  • platform/graphics/blackberry/LayerData.h:

(LayerData):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::updateLayersRecursive):

  • platform/graphics/blackberry/LayerWebKitThread.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Source/WebKit/blackberry:

Source/WebKit/blackberry:

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

No new tests, since it is a catch-up with upstreaming code.

2:02 PM Changeset in webkit [127501] by tommyw@google.com
  • 19 edits
    7 copies
    6 adds in trunk

MediaStream API: Add the async createOffer functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95734

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCSessionDescriptionDescriptor.h: Added.

(WebCore):
(WebKit):
(WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::~WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::operator=):
(WebKit::WebRTCSessionDescriptionDescriptor::isNull):

  • chromium/public/WebRTCSessionDescriptionRequest.h: Added.

(WebCore):
(WebKit):
(WebRTCSessionDescriptionRequest):
(ExtraData):
(WebKit::WebRTCSessionDescriptionRequest::ExtraData::~ExtraData):
(WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::~WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::operator=):
(WebKit::WebRTCSessionDescriptionRequest::isNull):

Source/WebCore:

createOffer sends a request to the platform implementer requesting it to gather up all candidates.
This can take some time, therefore the request is async.

Test: fast/mediastream/RTCPeerConnection-createOffer.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCErrorCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.

(WebCore):
(RTCErrorCallback):
(WebCore::RTCErrorCallback::~RTCErrorCallback):

  • Modules/mediastream/RTCErrorCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):
(WebCore):

  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCSessionDescriptionCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.

(WebCore):
(RTCSessionDescriptionCallback):
(WebCore::RTCSessionDescriptionCallback::~RTCSessionDescriptionCallback):

  • Modules/mediastream/RTCSessionDescriptionCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
  • Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp: Added.

(WebCore):
(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::stop):
(WebCore::RTCSessionDescriptionRequestImpl::clear):

  • Modules/mediastream/RTCSessionDescriptionRequestImpl.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.

(WebCore):
(RTCSessionDescriptionRequestImpl):

  • WebCore.gypi:
  • platform/chromium/support/WebRTCSessionDescriptionDescriptor.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.

(WebKit):
(WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::assign):
(WebKit::WebRTCSessionDescriptionDescriptor::reset):
(WebKit::WebRTCSessionDescriptionDescriptor::operator WTF::PassRefPtr<WebCore::RTCSessionDescriptionDescriptor>):
(WebKit::WebRTCSessionDescriptionDescriptor::initialize):
(WebKit::WebRTCSessionDescriptionDescriptor::type):
(WebKit::WebRTCSessionDescriptionDescriptor::setType):
(WebKit::WebRTCSessionDescriptionDescriptor::sdp):
(WebKit::WebRTCSessionDescriptionDescriptor::setSDP):

  • platform/chromium/support/WebRTCSessionDescriptionRequest.cpp: Added.

(WebKit):
(WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::assign):
(WebKit::WebRTCSessionDescriptionRequest::reset):
(WebKit::WebRTCSessionDescriptionRequest::requestSucceeded):
(WebKit::WebRTCSessionDescriptionRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCSessionDescriptionRequest::extraData):
(WebKit::WebRTCSessionDescriptionRequest::setExtraData):

  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::createOffer):
(WebCore):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCSessionDescriptionDescriptor.h:

(WebCore::RTCSessionDescriptionDescriptor::type):
(WebCore::RTCSessionDescriptionDescriptor::sdp):

  • platform/mediastream/RTCSessionDescriptionRequest.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.

(WebCore):
(RTCSessionDescriptionRequest):
(ExtraData):
(WebCore::RTCSessionDescriptionRequest::ExtraData::~ExtraData):
(WebCore::RTCSessionDescriptionRequest::~RTCSessionDescriptionRequest):
(WebCore::RTCSessionDescriptionRequest::extraData):
(WebCore::RTCSessionDescriptionRequest::setExtraData):
(WebCore::RTCSessionDescriptionRequest::RTCSessionDescriptionRequest):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::createOffer):
(WebCore):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::createOffer):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::taskList):
(SuccessCallbackTask):
(FailureCallbackTask):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-createOffer-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-createOffer.html: Added.
1:58 PM Changeset in webkit [127500] by mitz@apple.com
  • 12 edits in trunk

Reverted r127468 (the fix for <http://webkit.org/b/93443>) because the test it included caused
an assertion failure in Document::updateStyleIfNeeded().

Source/WebCore:

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
1:41 PM Changeset in webkit [127499] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.12

New Tag.

1:35 PM Changeset in webkit [127498] by Lucas Forschler
  • 9 edits
    2 deletes in branches/safari-536.26-branch

Rollout 127252.

1:34 PM Changeset in webkit [127497] by Simon Fraser
  • 4 edits
    2 adds in trunk

Regression: Heap-use-after-free in WebCore::FrameView::scrollContentsFastPath
https://bugs.webkit.org/show_bug.cgi?id=95754

Reviewed by Dave Hyatt.

Source/WebCore:

It's possible to have a renderer with position:fixed or sticky style,
but no layer, for example a RenderScrollBarPart. Don't register such
renderers with the FrameView.

Moved the code that registers/unregisters with the FrameView from
styleWillChange() to styleDidChange(), since in the latter case
we can check if we have a RenderLayer. Only register renderers with layers.
We always unregister, which required removing an assertion in
FrameView::removeFixedObject(), and replacing it with a null check of m_fixedObjects.

Test: fast/css/remove-fixed-resizer-crash.html

  • page/FrameView.cpp:

(WebCore::FrameView::removeFixedObject):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleWillChange):
(WebCore::RenderBoxModelObject::styleDidChange):

LayoutTests:

Testcase with a position:fixed resizer and scrolling.

  • fast/css/remove-fixed-resizer-crash-expected.txt: Added.
  • fast/css/remove-fixed-resizer-crash.html: Added.
1:30 PM Changeset in webkit [127496] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Rollout r127276.

1:30 PM Changeset in webkit [127495] by dominik.rottsches@intel.com
  • 3 edits in trunk/Source/WebCore

ResourceErrorBase needs to identify timeouts
https://bugs.webkit.org/show_bug.cgi?id=95755

Reviewed by Alexey Proskuryakov.

Adding a property to check whether this ResourceError was raised due to a timeout.
This is preparatory work for bug 74802. In order to implement XHR2 timeout functionality,
I need to identify some layers up whether the original network problem has been a timeout.

No new tests, no change in behavior yet.

  • platform/network/ResourceErrorBase.cpp:

(WebCore::ResourceErrorBase::copy): Copying new member.
(WebCore::ResourceErrorBase::compare): Comparing new member.

  • platform/network/ResourceErrorBase.h:

(WebCore::ResourceErrorBase::setIsTimeout): New setter.
(WebCore::ResourceErrorBase::isTimeout): New getter.
(ResourceErrorBase),
(WebCore::ResourceErrorBase::ResourceErrorBase): Adding m_isTimeout member.

1:25 PM Changeset in webkit [127494] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Rename WebViewClient::handleDisambiguationPopup
https://bugs.webkit.org/show_bug.cgi?id=95529

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-09-04
Reviewed by Adam Barth.

Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it.

  • public/WebViewClient.h:

(WebKit::WebViewClient::didTapMultipleTargets):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

  • tests/WebFrameTest.cpp:
1:22 PM Changeset in webkit [127493] by staikos@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix memory leak in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=95771

Reviewed by Rob Buis.

Simply delete the arrays at function exit.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openSelectPopup):

1:18 PM Changeset in webkit [127492] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

1:14 PM Changeset in webkit [127491] by roger_fong@apple.com
  • 9 edits in trunk/LayoutTests

Unreviewed. Removing accidentally added executable properties on test files.

  • platform/win/accessibility/canvas-description-and-role-expected.txt: Removed property svn:executable.
  • platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed property svn:executable.
  • platform/win/fast/css/image-resolution/image-resolution-expected.txt: Removed property svn:executable.
  • platform/win/fast/css/image-set-setting-expected.txt: Removed property svn:executable.
  • platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt: Removed property svn:executable.
  • platform/win/fast/css/variables/build-supports-variables-expected.txt: Removed property svn:executable.
  • platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Removed property svn:executable.
  • platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Removed property svn:executable.
1:05 PM Changeset in webkit [127490] by Lucas Forschler
  • 1 copy in tags/Safari-537.8/trunk

New Tag.

1:03 PM Changeset in webkit [127489] by staikos@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
https://bugs.webkit.org/show_bug.cgi?id=95766

Reviewed by Rob Buis.

Passing the frame status through will allow the client to make better
decisions about how to act on the onload.

  • Api/WebPageClient.h:
  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):

12:59 PM Changeset in webkit [127488] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] Output time and thread info in crash log
https://bugs.webkit.org/show_bug.cgi?id=95768

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.

12:48 PM Changeset in webkit [127487] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Remove use of deprecated QInputMethod method
https://bugs.webkit.org/show_bug.cgi?id=95741

Patch by Pekka Vuorela <pvuorela@iki.fi> on 2012-09-04
Reviewed by Simon Hausmann.

Adapt from deprecated QInputMethod::visible() to isVisible().

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::setInputPanelVisible):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):

12:46 PM Changeset in webkit [127486] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Provide virtual dtor for DumpRenderTreeClient
https://bugs.webkit.org/show_bug.cgi?id=95769

Reviewed by NOBODY (OOPS!).

Also remove WTF prefixes.

  • Api/DumpRenderTreeClient.h:
12:43 PM Changeset in webkit [127485] by tommyw@google.com
  • 16 edits in trunk

MediaStream API: Change the MediaStreamTrackList track added/removed signaling
https://bugs.webkit.org/show_bug.cgi?id=95721

Reviewed by Adam Barth.

Source/Platform:

Adding the signaling to the WebKit interface.

  • chromium/public/WebMediaStreamCenter.h:

(WebKit::WebMediaStreamCenter::didAddMediaStreamTrack):
(WebKit::WebMediaStreamCenter::didRemoveMediaStreamTrack):

Source/WebCore:

This allows the platform implementor to throw an NOT_SUPPORTED_ERR exception if it doesn support these methods.

Patch covered by expanded existing test.

  • Modules/mediastream/MediaStreamTrackList.cpp:

(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):

  • platform/mediastream/MediaStreamCenter.h:

(MediaStreamCenter):

  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:

(WebCore::MediaStreamCenterBlackBerry::didAddMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenterBlackBerry::didRemoveMediaStreamTrack):

  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:

(MediaStreamCenterBlackBerry):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::didAddMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::didRemoveMediaStreamTrack):

  • platform/mediastream/chromium/MediaStreamCenterChromium.h:

(MediaStreamCenterChromium):

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:

(WebCore::MediaStreamCenterGStreamer::didAddMediaStreamTrack):
(WebCore::MediaStreamCenterGStreamer::didRemoveMediaStreamTrack):

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:

(MediaStreamCenterGStreamer):

Tools:

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:

(MockWebMediaStreamCenter::didAddMediaStreamTrack):
(MockWebMediaStreamCenter::didRemoveMediaStreamTrack):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h:

(MockWebMediaStreamCenter):

LayoutTests:

  • fast/mediastream/MediaStreamTrackList.html:
12:35 PM Changeset in webkit [127484] by zoltan@webkit.org
  • 13 edits in trunk/Source

Extend the coverage of the Custom Allocation Framework in WTF and in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=95737

Reviewed by Eric Seidel.

Add WTF_MAKE_FAST_ALLOCATED macro to the following class declarations because these are instantiated by operator new.

Source/JavaScriptCore:

  • wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.
  • heap/MachineStackMarker.cpp:

(MachineThreads::Thread): Thread is instantiated at heap/MachineStackMarker.cpp:196.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(FixedVMPoolExecutableAllocator): FixedVMPoolExecutableAllocator is instantiated at jit/ExecutableAllocatorFixedVMPool.cpp:111

  • parser/SourceProviderCache.h:

(SourceProviderCache): SourceProviderCache is instantiated at parser/SourceProvider.h:49.

  • parser/SourceProviderCacheItem.h:

(SourceProviderCacheItem): SourceProviderCacheItem is instantiated at parser/Parser.cpp:843.

  • runtime/GCActivityCallback.h:

(GCActivityCallback): GCActivityCallback is instantiated at runtime/GCActivityCallback.h:96.

  • tools/CodeProfile.h:

(CodeProfile): CodeProfile is instantiated at JavaScriptCore/tools/CodeProfiling.cpp:140.

Source/WTF:

  • wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.
  • wtf/MediaTime.h: MediaTime is instantiated at wtf/MediaTime.cpp:288.
  • wtf/MetaAllocator.h:

(MetaAllocatorTracker): MetaAllocatorTracker is instantiated at JavaScriptCore/tools/CodeProfiling.cpp:120.

  • wtf/ThreadingPthreads.cpp:

(PthreadState): PthreadState is instantiated at wtf/ThreadingPthreads.cpp:165.

  • wtf/text/AtomicString.cpp:

(AtomicStringTable): AtomicStringTable is instantiated at wtf/text/AtomicString.cpp:43.

12:27 PM WebKitGTK/1.10.x edited by jdiggs@igalia.com
(diff)
12:23 PM Changeset in webkit [127483] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
https://bugs.webkit.org/show_bug.cgi?id=95740

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Added sanity check to be sure we have a render object prior to seeing if
said object is an anonymous block.

Testing via unit test because a non-flaky layout test crasher could not
be found.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Sanity check for render object added.

Source/WebKit/gtk:

Updated unit test.

  • tests/testatk.c:

(testWebkitAtkComboBox): Added checks that the menu popup in a combo box
has 0 links and, more importantly, that checking doesn't result in a crash.

12:11 PM Changeset in webkit [127482] by ojan@chromium.org
  • 2 edits in trunk/Tools

Elide test names when running new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=95626

Patch by Tony Chang <tony@chromium.org> on 2012-09-04
Reviewed by Dirk Pranke.

When the test name exceeds the number of terminal columns, it leaves
text on the screen. Avoid this by eliding the test name when running
tests. This is similar to what ninja does when compiling.

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream):
(MeteredStream.number_of_columns): Helper method to get number of
terminal columns. Won't work on Win32 python, but meh.

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
because stderr appears to be ascii only.
(Printer.print_started_test): Route through _test_status_line.
(Printer.print_finished_test): Route through _test_status_line.
(Printer._print_test_trace): Route through _test_status_line.
(Printer._print_baseline): Route through _test_status_line.

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(test_test_status_line): Test for _test_status_line.

11:58 AM Changeset in webkit [127481] by commit-queue@webkit.org
  • 3 edits
    2 moves
    3 adds
    3 deletes in trunk

Automatic features should work in sandboxed iframes if "allow-scripts" flag is set
https://bugs.webkit.org/show_bug.cgi?id=93961

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-04
Reviewed by Adam Barth.

Source/WebCore:

Allow automatic features (video autoplay and form control
autofocus) in a sandboxed iframe that has "allow-scripts"
flag set. This behavior is according to the latest
specification at:
http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin

This sandboxed automatic features browsing context flag is
relaxed by the same keyword as scripts, because when
scripts are enabled these features are trivially possible
anyway, and it would be unfortunate to force authors to
use script to do them when sandboxed rather than allowing
them to use the declarative features.

Tests: fast/forms/autofocus-in-sandbox-with-allow-scripts.html

media/auto-play-in-sandbox-with-allow-scripts.html

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::parseSandboxPolicy):

LayoutTests:

Add layout tests to check that automatic features (video
autoplay and form control autofocus) are allowed / working
in sandboxed iframes if the "allow-scripts" flag is set.
This behavior is according to the latest specification at:
http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin

The tests to check that automatic features are blocked in
sandboxed iframes have been removed since they relied on
the "allow-scripts" flag to work.

  • fast/forms/autofocus-in-sandbox-with-allow-scripts-expected.txt: Added.
  • fast/forms/autofocus-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/fast/forms/no-autofocus-in-sandbox.html.
  • fast/forms/no-autofocus-in-sandbox-expected.txt: Removed.
  • media/auto-play-in-sandbox-with-allow-scripts-expected.txt: Added.
  • media/auto-play-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/media/no-auto-play-in-sandbox.html.
  • media/no-auto-play-in-sandbox-expected.txt: Removed.
  • media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html: Added.
  • media/resources/no-auto-play-in-sandbox-iframe.html: Removed.
11:54 AM Changeset in webkit [127480] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Register scrolling layers with ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=78862

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-04
Reviewed by James Robinson.

In order to allow scrollable child layers to be scrolled off the main
thread, register them with the ScrollingCoordinator. These layers are
also removed from the non-fast scrollable region.

Whenever the scroll offset or other scroll geometry related attribute of
a compositor scrolled layer changes, the ScrollingCoordinator is
informed to allow it to update its internal representation of the
scrollable layer.

No tests because the ScrollingCoordinator is currently not testable.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion): Composited scrolling layers
can be scrolled off the main thread.
(WebCore):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
Callback to ScrollingCoordinator about changes the composited scrolling layers.

  • page/scrolling/ScrollingCoordinator.h:

(WebCore):
(ScrollingCoordinator):

  • page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::usesCompositedScrolling):

  • rendering/RenderLayer.cpp:

(WebCore):
(WebCore::RenderLayer::usesCompositedScrolling):

  • rendering/RenderLayer.h:

(RenderLayer):
(WebCore::RenderLayer::usesCompositedScrolling):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateScrollingLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::scrollingLayerDidChange):
(WebCore):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

11:46 AM Changeset in webkit [127479] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove uses of ClassInfo from SpeculativeJIT::compileObjectOrOtherLogicalNot
https://bugs.webkit.org/show_bug.cgi?id=95510

Reviewed by Oliver Hunt.

More refactoring to get rid of ClassInfo checks in the DFG.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):

11:45 AM Changeset in webkit [127478] by tony@chromium.org
  • 4 edits in trunk/Tools

Elide test names when running new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=95626

Reviewed by Dirk Pranke.

When the test name exceeds the number of terminal columns, it leaves
text on the screen. Avoid this by eliding the test name when running
tests. This is similar to what ninja does when compiling.

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream):
(MeteredStream.number_of_columns): Helper method to get number of
terminal columns. Won't work on Win32 python, but meh.

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
because stderr appears to be ascii only.
(Printer.print_started_test): Route through _test_status_line.
(Printer.print_finished_test): Route through _test_status_line.
(Printer._print_test_trace): Route through _test_status_line.
(Printer._print_baseline): Route through _test_status_line.

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(test_test_status_line): Test for _test_status_line.

11:42 AM Changeset in webkit [127477] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Rollout r127322.

11:37 AM Changeset in webkit [127476] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[chromium] Do not allow infinite pending frames in CCFrameRateController
https://bugs.webkit.org/show_bug.cgi?id=94254

Patch by Brian Anderson <brianderson@chromium.org> on 2012-09-04
Reviewed by James Robinson.

Removes support for infinite pending frames in CCFrameRateController
if swap acks are available.

Functionality covered by existing tests.

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::CCFrameRateController):
(WebCore::CCFrameRateController::setMaxFramesPending):
(WebCore::CCFrameRateController::setSwapBuffersCompleteSupported):
(WebCore):
(WebCore::CCFrameRateController::onTimerTick):
(WebCore::CCFrameRateController::didBeginFrame):
(WebCore::CCFrameRateController::didFinishFrame):

  • platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateController):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setSwapBuffersCompleteSupported):
(WebCore):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeRendererOnImplThread):

11:33 AM Changeset in webkit [127475] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Print API missing documentation when generating gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=95703

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-09-04
Reviewed by Carlos Garcia Campos.

Print out API missing documentation when generating gtkdoc. This makes it
easier to fix documentation errors.

  • gtk/generate-gtkdoc:

(print_missing_api): Added.
(generate_doc): Inline the rebase step, since it now reports an error
when you try to rebase without generating documentation first.

  • gtk/gtkdoc.py:

(GTKDoc.rebase_installed_docs): Raise an error when rebasing without
generating documentation first to enable a small cleanup at the caller.
(GTKDoc.api_missing_documentation): Added.

11:31 AM Changeset in webkit [127474] by timothy_horton@apple.com
  • 7 edits
    2 adds in trunk

ASSERTion failure when SVG element is removed from document and readded
https://bugs.webkit.org/show_bug.cgi?id=95517
<rdar://problem/12175583>

Reviewed by Brady Eidson.

Previously, SVG animations would cease to animate when their parent
<svg> element was removed and re-added to the document.

Instead, to match Firefox and Opera, we should continue the animation
with the same beginTime (i.e. the animation continues as if it had never
been removed from the document).

Test: svg/animations/reinserting-svg-into-document.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::insertedInto): Don't call begin() on an already-started SMILTimeContainer().

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::isStarted): Added.

  • svg/animation/SMILTimeContainer.h: Add isStarted().
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedInto): Always reschedule SVGSMILElements with
their parent SMILTimeContainer when they are inserted into the document, otherwise
they are lost (and never again update) when their subtree is removed and then
readded to the document.

Add a test that ensures that removing an SVG element from the document
and readding it continues SMIL animations.

  • svg/animations/reinserting-svg-into-document.html: Added.
11:08 AM Changeset in webkit [127473] by scheib@chromium.org
  • 8 edits in trunk

[Chromium] Allow asyncronous response of pointer lock requests in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=95628

Reviewed by James Robinson.

Tools:

Future tests need the ability to respond asynchronously that
pointer lock requests have been accepted or rejected. This patch
adds the following:

testRunner.setPointerLockWillRespondAsynchronously();
testRunner.didAcquirePointerLock();
testRunner.didNotAcquirePointerLock();

Tested in existing test:

pointerlockchange-pointerlockerror-events.html

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::didAcquirePointerLock):
(DRTTestRunner::didNotAcquirePointerLock):
(DRTTestRunner::setPointerLockWillRespondAsynchronously):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::requestPointerLock):
(WebViewHost::didAcquirePointerLock):
(WebViewHost::didNotAcquirePointerLock):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):
(WebViewHost::setPointerLockWillRespondAsynchronously):

LayoutTests:

Add testing for testRunner.setPointerLockWillRespondAsynchronously().

  • pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
10:47 AM Changeset in webkit [127472] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[CSS Regions] Destroying a render named flow thread without unregistering left-over content nodes triggered an assertion.
https://bugs.webkit.org/show_bug.cgi?id=95645

Patch by Andrei Bucur <abucur@adobe.com> on 2012-09-04
Reviewed by Abhishek Arya.

Source/WebCore:

This patch cleans up the render named flow thread before destruction by unregistering left-over content nodes.

Tests: fast/regions/moved-content-node-crash.html

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):

LayoutTests:

Simple test case that triggers an ASSERT in debug mode and causes a crash in release.
The ASSERT appears in RenderFlowThreadController::unregisterNamedFlowContentNode
ASSERT(it != m_mapNamedFlowContentNodes.end());

It happens because when a content node is added to an iframe document and then moved back, the iframe's RenderNamedFlowThread is destroyed
without calling unregisterNamedFlowContentNode on the node. This triggers the before mentioned assertion after a lazyAttach and a detach
in the parent document.

  • fast/regions/moved-content-node-crash-expected.txt: Added.
  • fast/regions/moved-content-node-crash.html: Added.
9:50 AM Changeset in webkit [127471] by peter@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium
https://bugs.webkit.org/show_bug.cgi?id=95744

Patch by Koji Ishii <Koji Ishii> on 2012-09-04
Unreviewed build fix, verified by Scott Graham.

The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant
because '/opentype/' was already included to webcore_remaining.
It was not only redundant but also breaks incremental linking.

No new tests are required because no behavior changes.

Patch by Koji Ishii <Koji Ishii> on 2012-09-04

  • WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform.
8:47 AM Changeset in webkit [127470] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection
https://bugs.webkit.org/show_bug.cgi?id=95747

PR199729

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-04
Reviewed by Rob Buis.
Internally Reviewed by Joe Mason.

If the browser has never saved a secure protocol cookie in its mapping before,
and it tries to set and retreive a secure cookie over a non-secure
protocol, it will not show up because the link between the secure and
non-secure mapping isn't created until a cookie (sent through secure) is set.

The fix is to also check for the linkage in getRawCookies. Note that we cannot
map the secure CookieMap to the non-secure one because getRawCookies is a const
function.

Manually tested using our Browser Test suite.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):

8:45 AM Changeset in webkit [127469] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
https://bugs.webkit.org/show_bug.cgi?id=95751

Reviewed by Martin Robinson.

In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
gst_message_new_duration was renamed to
gst_message_new_duration_changed.

However the only place where we used this is in the HTTP source
element and only if appsrc < 0.10.27 is used at runtime. In the
case of GStreamer 1.0 this condition will be always false so we
can disable this code at build time.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::didReceiveResponse):

8:32 AM Changeset in webkit [127468] by vsevik@chromium.org
  • 12 edits in trunk

Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-04
Reviewed by Pavel Feldman.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
8:11 AM WebKitGTK/1.10.x edited by mrobinson@webkit.org
(diff)
6:48 AM Changeset in webkit [127467] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix IDL dependency generation correctly
https://bugs.webkit.org/show_bug.cgi?id=95730

Patch by Jonathan Liu <net147@gmail.com> on 2012-09-04
Reviewed by Csaba Osztrogonác.

IDL dependency generation is still not working after
https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
added after the filename in an echo command end up being added to the
file which isn't handled correctly by preprocess-idls.pl. The problem
is fixed by removing the space after the filename.

  • DerivedSources.pri:
6:43 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:40 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:38 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:38 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
Add proposed merges for 1.9.92 (diff)
6:36 AM Changeset in webkit [127466] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
https://bugs.webkit.org/show_bug.cgi?id=95618

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Make sure we only emit the the signal for menu lists and list
boxes rendered from actual HTML select elements.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange): We support accessibility
ListBoxes and MenuLists only here, assuming they represent HTML
select elements, which might be not always true (e.g. ARIA). Thus,
check if that condition is true, early returning in other case.

LayoutTests:

New layout test to ensure we don't crash with ATK notifications
anymore when changing the selection in an ARIA listbox.

  • platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
  • platform/gtk/accessibility/aria-listbox-crash.html: Added.
6:34 AM Changeset in webkit [127465] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Cairo] [TextureMapper] Assertion failure in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=95713

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-09-04
Reviewed by Noam Rosenthal.

Fix an assertion failure by returning a valid context always for GraphicsContext3D::platformContext.
This is important because TextureMapperGL uses the platform context to perform hashing.

No new tests. This is covered by existing accelerated compositing tests.

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::platformContext): Return the current GLContext
when getting the platform context for private GraphicsContext3DPrivates that render
to the currently active context.

6:32 AM Changeset in webkit [127464] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
https://bugs.webkit.org/show_bug.cgi?id=86961

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add ecore_x initialisation check before calling ecore_x_bell
to avoid crashes when X server is not running.

  • platform/efl/SoundEfl.cpp:

(WebCore::systemBeep):

LayoutTests:

Unskipped two layout tests that were crashing.

  • platform/efl/TestExpectations:
6:30 AM Changeset in webkit [127463] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL][WK2] CSS3 Media Queries functionality is broken
https://bugs.webkit.org/show_bug.cgi?id=95680

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

In WK2, WebProcess doesn't have access to ewk_view evas object.
Methods that get screen rect or screen depth either return incorrect value or crash.
This patch removes dependency to ewk_view evas object and relies on ecore_x_* functions
to get screen rectangle or color depth of the screen.

  • platform/efl/EflScreenUtilities.cpp: removed unused getPixelDepth method definition
  • platform/efl/EflScreenUtilities.h: removed unsused getPixelDepth method declaration

(WebCore):

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):

LayoutTests:

Unskipped passing CSS3 Media Query tests.

  • platform/efl-wk2/TestExpectations:
6:20 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:20 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:19 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:13 AM Changeset in webkit [127462] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

.: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

  • Source/cmake/OptionsEfl.cmake: Turn on CONTEXT_MENUS flag for EFL port

Source/WebCore: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

  • PlatformEfl.cmake: Removed -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1

Source/WebKit: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

  • PlatformEfl.cmake: Added ContextMenuClientEfl.cpp file to sources list.

Source/WebKit/efl: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

  • WebCoreSupport/ContextMenuClientEfl.cpp: Added.

(WebCore):
(WebCore::ContextMenuClientEfl::contextMenuDestroyed):
(WebCore::ContextMenuClientEfl::getCustomMenuFromDefaultItems):
(WebCore::ContextMenuClientEfl::contextMenuItemSelected):
(WebCore::ContextMenuClientEfl::downloadURL):
(WebCore::ContextMenuClientEfl::lookUpInDictionary):
(WebCore::ContextMenuClientEfl::speak):
(WebCore::ContextMenuClientEfl::isSpeaking):
(WebCore::ContextMenuClientEfl::stopSpeaking):
(WebCore::ContextMenuClientEfl::searchWithGoogle):

  • WebCoreSupport/ContextMenuClientEfl.h: Added.

(WebCore):
(ContextMenuClientEfl):

  • ewk/ewk_contextmenu.cpp: Removed ewk_context_menu_customize implementation.

(ewk_context_menu_destroy): Added freeing context menu.
(ewk_context_menu_new): Added filling ewk_contextmenu list.
(ewk_context_menu_item_append):

  • ewk/ewk_contextmenu_private.h: Removed ewk_context_menu_customize and changed ewk_context_menu_new definition.
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(ewk_view_context_menu_forward_event):

5:51 AM Changeset in webkit [127461] by vsevik@chromium.org
  • 3 edits in trunk/LayoutTests

Web Inspector: Skip inspector WebGL tests where WebGL is disabled
https://bugs.webkit.org/show_bug.cgi?id=95733

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.

This is to update Skipped and TestExpectations files.

  • platform/efl/TestExpectations:
  • platform/win/Skipped:
5:34 AM Changeset in webkit [127460] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=95725

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-04

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
5:30 AM Changeset in webkit [127459] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Bugfix: wrong texture binding target in replay for 3D textures
https://bugs.webkit.org/show_bug.cgi?id=95687

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.

gl.bindTexture accepts either TEXTURE_2D or TEXTURE_CUBE_MAP targets, but we tried to replay with TEXTURE_CUBE_MAP_POSITIVE_X and others for 3D textures.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

5:11 AM Changeset in webkit [127458] by Carlos Garcia Campos
  • 25 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore

Revert r127442 (Merge r126715)

Patch causes crashes and makes inspector unit tests to fail in both
WebKit1 and WebKit2

5:05 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
4:56 AM Changeset in webkit [127457] by allan.jensen@nokia.com
  • 22 edits
    7 adds in trunk

Allow child-frame content in hit-tests.
https://bugs.webkit.org/show_bug.cgi?id=95204

.:

Reviewed by Antonio Gomes.

Update exported symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

Reviewed by Antonio Gomes.

Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
it is now handled by the hit test itself controlled by the AllowChildFrameContent
flag in HitTestRequest.

Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html

touchadjustment/iframe-boundary.html

  • WebCore.exp.in:
  • WebCore.order:
  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • dom/Document.h:

(Document):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::allowChildFrameContent):
(WebCore::HitTestRequest::childFrameHitTest):
(WebCore::HitTestRequest::testChildFrameScrollBars):

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::nodeAtPoint):
(WebCore):

  • rendering/RenderFrameBase.h:

(RenderFrameBase):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

Reviewed by Antonio Gomes.

Update symbols for the Windows build-system.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Reviewed by Antonio Gomes.
Touch-Adjustment test by Kevin Ellis

Two new tests for hit-testing child frame content. One for testing it as an option to
nodesFromRect, and one testing its improvement on touch adjustment on iframe boundaries.

  • fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Added.
  • fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Added.
  • fast/dom/nodesFromRect/resources/child-frame.html: Added.
  • fast/dom/nodesFromRect/resources/nodesFromRect.js:

(check):
(checkShadowContent):
(checkRect):
(nodesFromRectAsString):

  • touchadjustment/iframe-boundary-expected.txt: Added.
  • touchadjustment/iframe-boundary.html: Added.
  • touchadjustment/resources/inner-content-page.html: Added.
  • touchadjustment/resources/inner-navigation-frame.html: Added.
4:52 AM Changeset in webkit [127456] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed tests fix.

  • http/tests/inspector/workspace-test.js:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
4:25 AM Changeset in webkit [127455] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build error in NetworkStateNotifierEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=95724

Unreviewed EFL build fix.

Make sure <sys/socket.h> is included before
<linux/netlink.h> to fix build errors on some
systems (e.g. Ubuntu 11.10).

No new tests, no behavior change.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-04

  • platform/network/efl/NetworkStateNotifierEfl.cpp:
3:48 AM Changeset in webkit [127454] by vsevik@chromium.org
  • 22 edits
    1 move
    5 adds
    2 deletes in trunk

Web Inspector: Create JavaScriptSources based on network resources.
https://bugs.webkit.org/show_bug.cgi?id=95352

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
Removed rawSourceCode as it was not needed anymore.

Tests: inspector/debugger/network-uisourcecode-provider.html

inspector/debugger/resource-script-mapping.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._populate):
(WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):

  • inspector/front-end/RawSourceCode.js:
  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._reset):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.setSourceMapping):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/Workspace.js: Drive-by: fixed duplicating uiSourceCodes in workspace.
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

Removed raw-source-code.html test as RawSourceCode was removed by this patch.
Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
Updated dynamic-script-tag.html to better match expected behavior.

  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/workspace-test.js: Added.

(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
(initialize_WorkspaceTest):

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
  • inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
  • inspector/debugger/network-uisourcecode-provider.html: Added.
  • inspector/debugger/raw-source-code-expected.txt: Removed.
  • inspector/debugger/raw-source-code.html: Removed.
  • inspector/debugger/resource-script-mapping-expected.txt: Added.
  • inspector/debugger/resource-script-mapping.html: Added.
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-frame-count.html:
3:38 AM Changeset in webkit [127453] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r127447.
http://trac.webkit.org/changeset/127447
https://bugs.webkit.org/show_bug.cgi?id=95726

Mistake, did not reliably pass yet. (Requested by drott on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-04

  • platform/efl/TestExpectations:
2:37 AM Changeset in webkit [127452] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards
https://bugs.webkit.org/show_bug.cgi?id=95443

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Save gl.getError() status before taking the GL snapshot and restore it afterwards.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

LayoutTests:

Adds a test to check that we properly save the WebGL getError() status while doing the instrumentation.

  • inspector/profiler/webgl/webgl-profiler-get-error-expected.txt: Added.
  • inspector/profiler/webgl/webgl-profiler-get-error.html: Added.
  • inspector/profiler/webgl/webgl-profiler-test.js: Added.

(initialize_WebGLProfilerTest.InspectorTest.enableWebGLAgent):
(initialize_WebGLProfilerTest):
(createWebGLContext):

2:25 AM Changeset in webkit [127451] by commit-queue@webkit.org
  • 2 edits in trunk

[CMAKE] Update cmakeconfig.h.cmake
https://bugs.webkit.org/show_bug.cgi?id=95712

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-04
Reviewed by Gyuyoung Kim.

Update feature definitions which are missing compared to WebKitFeatures.cmake

  • Source/cmakeconfig.h.cmake:
2:20 AM Changeset in webkit [127450] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] REGRESSION(r127321): It made 3 notification test timeout
https://bugs.webkit.org/show_bug.cgi?id=95638

Patch by Jon Lee <jonlee@apple.com> on 2012-09-04
Reviewed by Csaba Osztrogonác.

Dispatch show event instead of display after r127321.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::sendDisplayEvent):

1:55 AM Changeset in webkit [127449] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: More directional control characters for debugging in inspector
https://bugs.webkit.org/show_bug.cgi?id=95696

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Entities for text directionality-related characters added (LRE, RLE, LRO, RLO, PDF).

  • inspector/front-end/ElementsTreeOutline.js:

LayoutTests:

  • inspector/elements/elements-panel-structure-expected.txt:
  • inspector/elements/elements-panel-structure.html:
1:53 AM Changeset in webkit [127448] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: new CPU Profiles are not shown after reattach
https://bugs.webkit.org/show_bug.cgi?id=95686

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::restore): set m_headersRequested flags
to true and clear all profiles on the front-end since there are no
collected profiles yet immediately after render process sitching.

1:53 AM EFLWebKit edited by tmpsantos@gmail.com
(diff)
1:39 AM Changeset in webkit [127447] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Removing http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
from skipped crashers section, after https://bugs.webkit.org/show_bug.cgi?id=94458#c14

  • platform/efl/TestExpectations: Previously crashing test removed.
1:38 AM Changeset in webkit [127446] by Carlos Garcia Campos
  • 20 edits
    6 adds in releases/WebKitGTK/webkit-1.10

Merge r127070 - Source/WebCore: [Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070

Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.

Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

Test: fast/events/continuous-platform-wheelevent-in-scrolling-div.html

  • platform/gtk/PlatformWheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

Source/WebKit/gtk: [Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070

Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.

Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

  • webkit/webkitwebview.cpp:

(webkit_web_view_realize):

Source/WebKit2: [Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070

Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.

Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

  • Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize):

Tools: [Gtk] Process Gtk 3.4 smooth scroll events properly
https://bugs.webkit.org/show_bug.cgi?id=88070

Added continousMouseScrollBy support in WebKitTestRunner, and added
implementation for gtk, and stub for Qt, mac and EFL.

Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
scroll for emulating multi-tick mouseScrollBy events.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/EventSender.cpp:

(mouseScrollByCallback):
(continuousMouseScrollByCallback):

  • WebKitTestRunner/EventSenderProxy.h:

(EventSenderProxy):

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::mouseScrollBy):
(WTR):
(WTR::EventSendingController::continuousMouseScrollBy):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:

(EventSendingController):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::continuousMouseScrollBy):

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR):
(WTR::EventSenderProxy::continuousMouseScrollBy):

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::continuousScrollBy):

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::continuousMouseScrollBy):
(WTR):

LayoutTests: [Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070

Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
scroll for emulating multi-tick mouseScrollBy events.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

  • platform/gtk-wk2/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/gtk-wk2/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/gtk/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
1:38 AM Changeset in webkit [127445] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add webplatform and browser to build info
https://bugs.webkit.org/show_bug.cgi?id=95715

Reviewed by George Staikos.

PR# 202102

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::buildPage):

1:31 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
1:27 AM Changeset in webkit [127444] by ryuan.choi@samsung.com
  • 6 edits in trunk/Source

[EFL] Drop default theme concept
https://bugs.webkit.org/show_bug.cgi?id=94778

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

  • ewk/ewk_view.h:

Updated doxygen document not to mention default theme.

Source/WebKit2:

  • PlatformEfl.cmake: Removed DEFAULT_THEME_PATH definitions.
  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_initialize): Removed default theme concept.

  • UIProcess/API/efl/ewk_view.h:

Updated doxygen document not to mention default theme.

1:23 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
1:19 AM Changeset in webkit [127443] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: NMI: cosmetic change, rename m_domMemoryUsage to m_memoryInstrumentation.
https://bugs.webkit.org/show_bug.cgi?id=95716

Also m_memoryInstrumentation became a reference to external object because it has other life time than domNodeVisitor.

Reviewed by Yury Semikhatsky.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):
(WebCore::collectDomTreeInfo):

12:25 AM Changeset in webkit [127442] by Carlos Garcia Campos
  • 25 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore

Merge r126715 - Array type checks and storage accesses should be uniformly represented and available to CSE
https://bugs.webkit.org/show_bug.cgi?id=95013

Reviewed by Oliver Hunt.

This uniformly breaks up all array accesses into up to three parts:

1) The type check, using a newly introduced CheckArray node, in addition to possibly

a CheckStructure node. We were already inserting the CheckStructure prior to this
patch. The CheckArray node will be automatically eliminated if the thing it was
checking for had already been checked for, either intentionally (a CheckStructure
inserted based on the array profile of this access) or accidentally (some checks,
typically a CheckStructure, inserted for some unrelated operations). The
CheckArray node may not be inserted if the array type is non-specific (Generic or
ForceExit).

2) The storage load using GetIndexedPropertyStorage. Previously, this only worked for

GetByVal. Now it works for all array accesses. The storage load may not be
inserted if the mode of array access does not permit CSE of storage loads (like
non-specific modes or Arguments).

3) The access itself: one of GetByVal, PutByVal, PutByValAlias, ArrayPush, ArrayPop,

GetArrayLength, StringCharAt, or StringCharCodeAt.

This means that the type check can be subjected to CSE even if the CFA isn't smart
enough to reason about it (yet!). It also means that the storage load can always be
subjected to CSE; previously CSE on storage load only worked for array loads and not
other forms of access. Finally, it removes the bizarre behavior that
GetIndexedPropertyStorage previously had: previously, it was responsible for the type
check in some cases, but not others; this made reasoning about the CFA really
confusing.

This change also disables late refinement of array mode, since I decided that
supporting that feature is both confusing and likely unprofitable. The array modes are
now locked in in the first fixup run after prediction propagation. Of course,
refinements from Generic to something else would not have been a problem; we could
reenable those if we thought we really needed to.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::fromStructure):
(DFG):
(JSC::DFG::refineArrayMode):

  • dfg/DFGArrayMode.h:

(DFG):
(JSC::DFG::modeIsJSArray):
(JSC::DFG::lengthNeedsStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayMode):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::checkStructureElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::performCSE):

  • dfg/DFGCSEPhase.h:

(DFG):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(FixupPhase):
(JSC::DFG::FixupPhase::blessArrayOperation):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(DFG):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::collectGarbage):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::vote):
(JSC::DFG::Graph::substitute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArrayMode):
(JSC::DFG::Node::setArrayMode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

12:08 AM Changeset in webkit [127441] by Carlos Garcia Campos
  • 28 edits
    2 deletes in releases/WebKitGTK/webkit-1.10

Merge r127228 - Unreviewed, rolling out r126127.
http://trac.webkit.org/changeset/126127

This breaks gobject bindings.

Source/WebCore:

  • dom/Attr.cpp:

(WebCore::Attr::cloneNode):

  • dom/Attr.h:
  • dom/CDATASection.cpp:

(WebCore::CDATASection::cloneNode):

  • dom/CDATASection.h:

(CDATASection):

  • dom/Comment.cpp:

(WebCore::Comment::cloneNode):

  • dom/Comment.h:

(Comment):

  • dom/Document.cpp:

(WebCore::Document::cloneNode):

  • dom/Document.h:

(Document):

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::cloneNode):

  • dom/DocumentFragment.h:

(DocumentFragment):

  • dom/DocumentType.cpp:

(WebCore::DocumentType::cloneNode):

  • dom/DocumentType.h:

(DocumentType):

  • dom/Element.cpp:

(WebCore::Element::cloneNode):

  • dom/Element.h:

(Element):

  • dom/EntityReference.cpp:

(WebCore::EntityReference::cloneNode):

  • dom/EntityReference.h:

(EntityReference):

  • dom/Node.h:

(Node):

  • dom/Node.idl:
  • dom/Notation.cpp:

(WebCore::Notation::cloneNode):

  • dom/Notation.h:

(Notation):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::cloneNode):

  • dom/ProcessingInstruction.h:

(ProcessingInstruction):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::cloneNode):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/Text.cpp:

(WebCore::Text::cloneNode):

  • dom/Text.h:

(Text):

LayoutTests:

  • fast/dom/shadow/shadowroot-clonenode-expected.txt: Removed.
  • fast/dom/shadow/shadowroot-clonenode.html: Removed.
12:08 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)

Sep 3, 2012:

11:37 PM Changeset in webkit [127440] by Simon Hausmann
  • 4 edits in trunk/Source/WebCore

[Qt] Port the Qt pixmap JS bindings to use the JSC C API
https://bugs.webkit.org/show_bug.cgi?id=94702

Reviewed by Kenneth Rohde Christiansen.

Based on patch by Noam Rosenthal.

The conversion uses a simple JSClassRef based binding and only a few
uses of private JSC API for the HTML element DOM bindings remain.

This is essentially used for wrapping QPixmap and QImage types in
JavaScript and the other way around, for retrieving the image data
out of a HTML image element when converting from JS/DOM to Qt.

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::copyPixels):
(JSC::Bindings::toPixmap):
(JSC::Bindings::toImage):
(JSC::Bindings::imageSizeForVariant):
(JSC::Bindings::getPixmapWidth):
(JSC::Bindings::getPixmapHeight):
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::pixmapToImageData):
(JSC::Bindings::pixmapToDataUrl):
(JSC::Bindings::pixmapToString):
(JSC::Bindings::QtPixmapRuntime::toJS):
(JSC::Bindings::QtPixmapRuntime::toQt):
(JSC::Bindings::QtPixmapRuntime::canHandle):
(JSC::Bindings::QtPixmapRuntime::getClassRef):

  • bridge/qt/qt_pixmapruntime.h:

(QtPixmapRuntime):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

10:26 PM Changeset in webkit [127439] by noel.gordon@gmail.com
  • 2 edits
    5 deletes in trunk/LayoutTests

http/tests/incremental/partial-jpeg.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82480

Reviewed by Kent Tamura.

Remove this test: we have a more robust partial load test now in
http/tests/images/jpg-img-partial-load.html

  • http/tests/incremental/partial-jpeg-expected.png: Removed.
  • http/tests/incremental/partial-jpeg-expected.txt: Removed.
  • http/tests/incremental/partial-jpeg.html: Removed.
  • http/tests/incremental/resources/checkerboard.jpg: Removed.
  • http/tests/incremental/resources/partial-jpeg.php: Removed.
  • platform/chromium/TestExpectations:
7:19 PM Changeset in webkit [127438] by kling@webkit.org
  • 7 edits in trunk/Source/WebCore

Share immutable ElementAttributeData between elements with identical attributes.
<http://webkit.org/b/94990>

Reviewed by Antti Koivisto.

Keep a cache of ElementAttributeData objects for a given set of attributes and reuse
them in elements with identical attribute maps. ElementAttributeData is made ref-counted
to facilitate this. A copy-on-write mechanism is already in place, since mutating call
sites have to go via Element::mutableAttributeData().

The cache is held by Document and cleared in Document::finishedParsing() since the vast
majority of immutable ElementAttributeData will be constructed during parsing.

On the HTML5 spec at <http://whatwg.org/c/>, we get a cache hit rate of nearly 80%,
translating into a 3.5MB reduction in memory use.

  • dom/Document.cpp:

(WebCore::Document::finishedParsing):
(ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheEntry):
(WebCore::Document::cachedImmutableAttributeData):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):

  • dom/Element.h:
  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::ElementAttributeData):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::create):
(ElementAttributeData):
(WebCore::ElementAttributeData::makeMutable):

7:09 PM Changeset in webkit [127437] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: the URL of worker inspector window sometimes is invalid
https://bugs.webkit.org/show_bug.cgi?id=95334

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-09-03
Reviewed by Pavel Feldman.

In "_openInspectorWindow", before "&dedicatedWorkerId=" should have a '?' to make the whole URL valid.

No new tests case for this bug.

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype._openInspectorWindow):

6:44 PM Changeset in webkit [127436] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[EFL] Fix e_dbus_shutdown() error when exiting the Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=95636

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.

Source/WebCore:

Check if the m_timer is active in stopUpdating()
to know the BatteryProvider is updating or not.
By checking the timer, stopUpdating() will be called
only BatteryProviderEfl is updating.

  • platform/efl/BatteryProviderEfl.cpp:

(WebCore::BatteryProviderEfl::stopUpdating):

Source/WebKit/efl:

Invoke stopUpdating() in the destructor of BatteryClinetEfl()
to call e_ukit_shutdown() and e_dbus_shutdown() if and when
stopUpdating() has not been called explicitly.

  • WebCoreSupport/BatteryClientEfl.cpp:

(BatteryClientEfl::~BatteryClientEfl):

  • WebCoreSupport/BatteryClientEfl.h:

(BatteryClientEfl):

6:40 PM Changeset in webkit [127435] by bashi@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r127410

Removed further platform-specific text expectations.

  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
6:21 PM Changeset in webkit [127434] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2][WTR] Implement WebKitEnableCaretBrowsing attribute in testRunner.overridePreference
https://bugs.webkit.org/show_bug.cgi?id=95576

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-03
Reviewed by Maciej Stachowiak.

Added a line of macro to implement WebKitEnableCaretBrowsing attribute in testRunner.overridePreference

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

LayoutTests:

  • platform/wk2/Skipped: Removed fast/repaint/no-caret-repaint-in-non-content-editable-element.html test case.
3:39 PM Changeset in webkit [127433] by bashi@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r127410

  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
12:14 PM Changeset in webkit [127432] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Not all activated elements highlighted, but some frames are
https://bugs.webkit.org/show_bug.cgi?id=95683

Reviewed by Kenneth Rohde Christiansen.

Use the new function Node::willRespondToMouseClickEvents to better determine if the element
can be tap-activated and avoid documents and frames completely.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

12:14 PM WebKitGTK/1.10.x edited by Carlos Garcia Campos
r127124 merged (diff)
11:38 AM Changeset in webkit [127431] by ryuan.choi@samsung.com
  • 3 edits in trunk/Tools

[EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=95689

Reviewed by Kenneth Rohde Christiansen.

In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
So, there are bugs that key events are always generated in url bar although
the user clicked the web view.

This patch recovers the focus of the web view when left button is pressed and
adds for MiniBrowser to toggle the focus when middle button is pressed
like EWebLauncher already did.

  • EWebLauncher/main.c:

(on_mouse_down):

  • MiniBrowser/efl/main.c:

(on_mouse_down):
(browserCreate):

11:37 AM Changeset in webkit [127430] by commit-queue@webkit.org
  • 5 edits in trunk

Added ANDROID_GDBSERVER definition for Ant
https://bugs.webkit.org/show_bug.cgi?id=95265

Patch by Tao Bai <michaelbai@chromium.org> on 2012-09-03
Reviewed by Adam Barth.

ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
is only used for finding the gdbserver.

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
10:16 AM Changeset in webkit [127429] by commit-queue@webkit.org
  • 19 edits
    3 adds
    6 deletes in trunk

Unreviewed, rolling out r127427.
http://trac.webkit.org/changeset/127427
https://bugs.webkit.org/show_bug.cgi?id=95695

Breaks some inspector/debugger tests on JSC (Requested by
vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-03

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/NetworkUISourceCodeProvider.js: Removed.
  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._shouldBindScriptToContentProvider):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
(WebInspector.ResourceScriptMapping.prototype._reset):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/StylesUISourceCodeProvider.js: Added.

(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype._populate):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype._reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/workspace-test.js: Removed.
  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
  • inspector/debugger/network-uisourcecode-provider-expected.txt: Removed.
  • inspector/debugger/network-uisourcecode-provider.html: Removed.
  • inspector/debugger/raw-source-code-expected.txt: Added.
  • inspector/debugger/raw-source-code.html: Added.
  • inspector/debugger/resource-script-mapping-expected.txt: Removed.
  • inspector/debugger/resource-script-mapping.html: Removed.
  • inspector/debugger/scripts-panel.html:
9:50 AM Changeset in webkit [127428] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
9:45 AM WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
9:44 AM WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
9:34 AM Changeset in webkit [127427] by vsevik@chromium.org
  • 19 edits
    1 move
    5 adds
    2 deletes in trunk

Web Inspector: Create JavaScriptSources based on network resources.
https://bugs.webkit.org/show_bug.cgi?id=95352

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
Removed rawSourceCode as it was not needed anymore.

Tests: inspector/debugger/network-uisourcecode-provider.html

inspector/debugger/resource-script-mapping.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._populate):
(WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):

  • inspector/front-end/RawSourceCode.js:
  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._reset):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.setSourceMapping):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

Removed raw-source-code.html test as RawSourceCode was removed by this patch.
Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
Updated dynamic-script-tag.html to better match expected behavior.

  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/workspace-test.js: Added.

(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
(initialize_WorkspaceTest):

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
  • inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
  • inspector/debugger/network-uisourcecode-provider.html: Added.
  • inspector/debugger/raw-source-code-expected.txt: Removed.
  • inspector/debugger/raw-source-code.html: Removed.
  • inspector/debugger/resource-script-mapping-expected.txt: Added.
  • inspector/debugger/resource-script-mapping.html: Added.
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-frame-count.html:
9:09 AM Changeset in webkit [127426] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Make the injected resourceObject property non-enumerable
https://bugs.webkit.org/show_bug.cgi?id=95682

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-03
Reviewed by Pavel Feldman.

Make the injected auxiliary property resourceObject non-enumerable to hide it from for..in iterations.
Ideally this property should be completely hidden from the user's code.
Drive-by: Fix couple of small FIXME's.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

9:08 AM Changeset in webkit [127425] by tommyw@google.com
  • 25 edits
    2 copies
    5 adds in trunk

MediaStream API: Add Ice-related functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95565

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCICECandidateDescriptor.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandlerClient.h.

(WebCore):
(WebKit):
(WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::~WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::operator=):
(WebKit::WebRTCICECandidateDescriptor::isNull):

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCPeerConnectionHandlerClient.h:

(WebKit):
(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

Adds all Ice-related functionality to RTCPeerConnection, including
events, callbacks and methods.

Test: fast/mediastream/RTCPeerConnection-ice.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCIceCandidateEvent.cpp: Added.

(WebCore):
(WebCore::RTCIceCandidateEvent::create):
(WebCore::RTCIceCandidateEvent::RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::~RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::candidate):
(WebCore::RTCIceCandidateEvent::interfaceName):

  • Modules/mediastream/RTCIceCandidateEvent.h: