Timeline
Sep 22, 2012:
- 11:56 PM Changeset in webkit [129314] by
-
- 3 edits in trunk/Source/WTF
Add explicit conversion operator to RetainPtr for easier use in C++11 environments
https://bugs.webkit.org/show_bug.cgi?id=97403
Reviewed by Dan Bernstein.
- wtf/Compiler.h:
Add support for COMPILER_SUPPORTS(CXX_EXPLICIT_CONVERSIONS)
- wtf/RetainPtr.h:
(RetainPtr):
(WTF::RetainPtr::get):
(WTF::RetainPtr::operator PtrType):
Add the explicit conversion operator and group all the underlying
pointer accessors together.
- 11:31 PM Changeset in webkit [129313] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding a failure expectation for http/tests/loading/redirect-with-no-location-crash.html,
the test started failing on the WebKit2 builder after it was unskipped in r129213.
- platform/gtk-wk2/TestExpectations:
- 6:03 PM MinimalFileStorage edited by
- (diff)
- 5:56 PM MinimalFileStorage edited by
- (diff)
- 5:53 PM MinimalFileStorage edited by
- (diff)
- 5:52 PM MinimalFileStorage edited by
- (diff)
- 5:50 PM MinimalFileStorage edited by
- (diff)
- 5:49 PM MinimalFileStorage edited by
- (diff)
- 5:47 PM MinimalFileStorage edited by
- (diff)
- 5:46 PM MinimalFileStorage edited by
- (diff)
- 5:45 PM MinimalFileStorage created by
- 5:29 PM Changeset in webkit [129312] by
-
- 4 edits in trunk/Source/WebKit2
Install WebProcess XPC services into the right places
https://bugs.webkit.org/show_bug.cgi?id=97385
Reviewed by Anders Carlsson.
- Configurations/WebProcessService.xcconfig:
Update INSTALL_PATH to go into WebKit2.framework/Versions/A/XPCServices.
- Configurations/WebProcessServiceForWebKitDevelopment.xcconfig:
Since this config file is almost identical to WebProcessService.xcconfig,
just #include it and change the one thing that is different, the INFOPLIST_FILE
- WebKit2.xcodeproj/project.pbxproj:
Follow XPC procedure and copy the services into the right place, WebKit2.framework/Versions/A/XPCServices
in all builds except production builds where it is not necessary. Also add a symlink like everyone else
does.
- 5:19 PM Changeset in webkit [129311] by
-
- 4 copies1 add in releases/Apple/OS X Lion Update 10.7.5
Added a tag for the OS X Lion Update 10.7.5 release.
OS X Lion v10.7.5 includes JavaScriptCore-7534.57.3, WebCore-7534.57.7, WebKit-7534.57.7, and WebKit2-7534.57.7.
- 5:12 PM Changeset in webkit [129310] by
-
- 4 copies1 add in releases/Apple/Safari 6.0.1
Added a tag for the Safari 6.0.1 release.
Safari 6.0.1 includes JavaScriptCore-x536.26.7, WebCore-x536.26.14, WebKit-x536.26.14, and WebKit2-x536.26.14.
- 3:18 PM Changeset in webkit [129309] by
-
- 5 edits in trunk/Source/WebKit2
Allow setting a custom path to where the plug-in sandbox profiles are being kept
https://bugs.webkit.org/show_bug.cgi?id=97399
Reviewed by Anders Carlsson.
Add a new default to allow controlling where to look for plug-in sandbox profiles
called "PlugInSandboxProfileDirectoryPath".
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initializeSandbox):
Use the passed in sandboxProfileDirectoryPath instead of hard coding /usr/share/sandbox/.
(WebKit::PluginProcess::platformInitialize):
- Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):
- Shared/Plugins/PluginProcessCreationParameters.h:
(PluginProcessCreationParameters):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
Grab the sandboxProfileDirectoryPath from standardUserDefaults and pass it to
the plug-in.
- 9:17 AM Changeset in webkit [129308] by
-
- 21 edits4 copies in trunk
AX: Layout tests would be easier to write if AccessibilityController could find an element by id
https://bugs.webkit.org/show_bug.cgi?id=97301
Reviewed by Chris Fleizach.
Source/WebCore:
Add a method to get the DOM "id" attribute from an accessible object, only for layout tests.
Makes existing test more cross-platform:
Tests: accessibility/aria-hidden-with-elements.html
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Adds a new accessibleElementById method to AccessibilityController, to make it
easier to write cross-platform layout tests.
Implemented for Chromium and for Mac (DRT and WKTR).
- DumpRenderTree/AccessibilityController.cpp:
(getAccessibleElementByIdCallback):
(AccessibilityController::getJSClass):
- DumpRenderTree/AccessibilityController.h:
(AccessibilityController):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::findAccessibleElementByIdRecursive):
(AccessibilityController::getAccessibleElementById):
(AccessibilityController::accessibleElementByIdGetterCallback):
- DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h:
(AccessibilityController):
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::accessibleElementById):
- DumpRenderTree/mac/AccessibilityCommonMac.h: added
- DumpRenderTree/mac/AccessibilityCommonMac.mm: added
(+[NSString stringWithJSStringRef:]):
(-[NSString createJSStringRef]):
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(findAccessibleObjectById):
(AccessibilityController::accessibleElementById):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::accessibleElementById):
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::accessibleElementById):
- WebKitTestRunner/InjectedBundle/AccessibilityController.h:
(AccessibilityController):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h: added
- WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm: added
(+[NSString stringWithJSStringRef:]):
(-[NSString createJSStringRef]):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::findAccessibleObjectById):
(WTR):
(WTR::AccessibilityController::accessibleElementById):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
LayoutTests:
Modifies an existing test to use the new accessibleElementById
method of AccessibilityController, enabling the test to pass on
both Mac and Chromium.
- accessibility/aria-hidden-with-elements.html:
- platform/chromium/TestExpectations:
- 5:10 AM Changeset in webkit [129307] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, unskip now passing tests.
- platform/qt/TestExpectations:
- 4:50 AM Changeset in webkit [129306] by
-
- 2 edits in trunk/LayoutTests
[EFL] Garden IETestCenter Bugs
https://bugs.webkit.org/show_bug.cgi?id=97392
Unreviewed EFL gardening.
Unskip a couple of IETestCenter bugs now that they pass.
- platform/efl/TestExpectations:
- 4:33 AM QtWebKitGardening edited by
- add more info to how to build QtWebKit section, fix the URL of the PPA (diff)
- 4:32 AM Changeset in webkit [129305] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Build is broken with GLib Unicode backend
https://bugs.webkit.org/show_bug.cgi?id=97308.
Patch by Thierry Reding <thierry.reding@avionic-design.de> on 2012-09-22
Reviewed by Carlos Garcia Campos.
The TextBreakIteratorGtk implementation uses ubrk_close() to delete
the iterator. However that function is ICU specific and not declared
when using the GLib backend. Instead the iterator can simply be freed
using the delete operator.
This commit is based on work by Martin Schlemmer who posted a fix for
this here:
http://permalink.gmane.org/gmane.os.opendarwin.webkit.gtk/1210
No new tests.
- platform/text/gtk/TextBreakIteratorGtk.cpp:
(WebCore::NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator):
Free iterator using delete instead of ubrk_close().
- 3:31 AM Changeset in webkit [129304] by
-
- 8 edits3 adds in trunk/LayoutTests
[CSSRegions]Add test for accelerating compositing of elements in RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=97387
Reviewed by Dirk Schulze.
At this moment, accelerated compositing is disabled for elements inside a RenderFlowThread. This patch adds
a specific test in compositing/regions that is expected to fail until https://bugs.webkit.org/show_bug.cgi?id=84900
is fixed. The code for the new test is taken out of the existing fast/regions/webkit-flow-renderer-layer.html.
- compositing/regions/webkit-flow-renderer-layer-compositing-expected.html: Added.
- compositing/regions/webkit-flow-renderer-layer-compositing.html: Added.
- fast/regions/webkit-flow-renderer-layer-expected.html:
- fast/regions/webkit-flow-renderer-layer.html:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/Skipped:
- 1:10 AM Changeset in webkit [129303] by
-
- 5 edits in trunk/Tools
Unexpected reftest passes are only reported when pixel testing is enabled
https://bugs.webkit.org/show_bug.cgi?id=97242
Reviewed by Dirk Pranke.
LayoutTestRunner should know whether the finished test it's handling is
a reftest. This is necessary when updating result summary for reftests
when pixel testing is not enabled - in these circumstances an unexpectedly
passing reftest was not reported as such due to pixel testing then being
determined by searching for reftest failures in failures list, which were
not found in an empty failure list of a passing test. Now the TestResult
objects have a member variable indicating the test is a reftest whenever
that's the case.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner._update_summary_with_result):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LayoutTestRunnerTests.test_update_summary_with_result):
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.run):
(SingleTestRunner._run_reftest):
- Scripts/webkitpy/layout_tests/models/test_results.py:
(TestResult.init):
- 1:00 AM Changeset in webkit [129302] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Marking mathml/presentation/subsup.xhtml as flaky, the flakiness
being observable after r128837.
Adding image failure expectation for fast/text/word-space-with-kerning-2.html,
introduced in r129233.
- platform/gtk/TestExpectations:
- 12:26 AM Changeset in webkit [129301] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, unskip now passing tests.
- platform/qt-5.0-wk1/Skipped:
- platform/qt/Skipped:
- 12:01 AM Changeset in webkit [129300] by
-
- 1 edit2 moves in trunk/LayoutTests
[Qt] New fast/text/kerning-with-TextLayout.html fails
https://bugs.webkit.org/show_bug.cgi?id=97388
Moved this test into platform/mac, as it is not platform-independent, and TextLayout is currently
used only on OS X.
- fast/text/kerning-with-TextLayout-expected.html: Removed.
- fast/text/kerning-with-TextLayout.html: Removed.
- platform/mac/fast/text/kerning-with-TextLayout-expected.html: Copied from LayoutTests/fast/text/kerning-with-TextLayout-expected.html.
- platform/mac/fast/text/kerning-with-TextLayout.html: Copied from LayoutTests/fast/text/kerning-with-TextLayout.html.
- 12:00 AM Changeset in webkit [129299] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip new failing tests.
- platform/qt-5.0-wk2/Skipped:
- platform/qt/Skipped:
Sep 21, 2012:
- 11:43 PM Changeset in webkit [129298] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolled out a line I committed by accident.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- 11:34 PM Changeset in webkit [129297] by
-
- 18 edits in trunk
Optimized closures that capture arguments
https://bugs.webkit.org/show_bug.cgi?id=97358
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Previously, the activation object was responsible for capturing all
arguments in a way that was convenient for the arguments object. Now,
we move all captured variables into a contiguous region in the stack,
allocate an activation for exactly that size, and make the arguments
object responsible for knowing all the places to which arguments could
have moved.
This seems like the right tradeoff because
(a) Closures are common and long-lived, so we want them to be small.
(b) Our primary strategy for optimizing the arguments object is to make
it go away. If you're allocating arguments objects, you're already having
a bad time.
(c) It's common to use either the arguments object or named argument
closure, but not both.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::argumentsRegister):
(JSC::CodeBlock::activationRegister):
(JSC::CodeBlock::isCaptured):
(JSC::CodeBlock::argumentIndexAfterCapture): m_numCapturedVars is gone
now -- we have an explicit range instead.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): Move captured arguments
into the captured region of local variables for space efficiency. Record
precise data about where they moved for the sake of the arguments object.
Some of this data was previously wrong, but it didn't cause any problems
because the arguments weren't actually moving.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flushArgumentsAndCapturedVariables): Don't
assume that captured vars are in any particular location -- always ask
the CodeBlock. This is better encapsulation.
(JSC::DFG::ByteCodeParser::parseCodeBlock):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): I rename things sometimes.
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff): Account for a particularly nasty edge case.
(JSC::Arguments::didTearOffActivation): Don't allocate our slow arguments
data on tear-off. We need to allocate it eagerly instead, since we need
to know about displaced, captured arguments during access before tear-off.
- runtime/Arguments.h:
(JSC::Arguments::allocateSlowArguments):
(JSC::Arguments::argument): Tell our slow arguments array where all arguments
are, even if they are not captured. This simplifies some things, so we don't
have to account explicitly for the full matrix of (not torn off, torn off)
- (captured, not captured).
(JSC::Arguments::finishCreation): Allocate our slow arguments array eagerly
because we need to know about displaced, captured arguments during access
before tear-off.
- runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- runtime/Executable.h:
(JSC::FunctionExecutable::parameterCount):
(FunctionExecutable):
- runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
- runtime/JSActivation.h:
(JSActivation):
(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::registerOffset):
(JSC::JSActivation::tearOff):
(JSC::JSActivation::allocationSize):
(JSC::JSActivation::isValid): This is really the point of the patch. All
the pointer math in Activations basically boils away, since we always
copy a contiguous region of captured variables now.
- runtime/SymbolTable.h:
(JSC::SlowArgument::SlowArgument):
(SlowArgument):
(SharedSymbolTable):
(JSC::SharedSymbolTable::captureCount):
(JSC::SharedSymbolTable::SharedSymbolTable): AllOfTheThings capture mode
is gone now -- that's the point of the patch. indexIfCaptured gets renamed
to index because we always have an index, even if not captured. (The only
time when the index is meaningless is when we're Deleted.)
LayoutTests:
- fast/js/dfg-arguments-alias-activation-expected.txt:
- fast/js/dfg-arguments-alias-activation.html:
- 9:44 PM Changeset in webkit [129296] by
-
- 3 edits1 add in trunk
HTMLMediaElement isn't garbage collected between document reloads
https://bugs.webkit.org/show_bug.cgi?id=97020
Reviewed by Eric Carlson.
.:
Manual test added: ManualTests/audio-freed-during-reload.html
- ManualTests/audio-freed-during-reload.html:
Source/WebCore:
JS-created (as opposed to DOM-created) Audio nodes never got collected, because they
appear to always hasPendingActivity(), because m_playing is never set to false.
Manual test added: ManualTests/audio-freed-during-reload.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::stop): set m_playing = false; explicitly.
- 8:18 PM Changeset in webkit [129295] by
-
- 2 edits in trunk/Source/WebKit2
Fix the Lion and Snow Leopard builds.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToWebProcessServiceForWebKitDevelopment):
(WebKit::createWebProcessServiceForWebKitDevelopment):
(WebKit::createWebProcessService):
- 8:04 PM Changeset in webkit [129294] by
-
- 3 edits in trunk/Source/WebCore
RenderMarquee causes ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()) : WebCore::FloatRect WebCore::RenderGeometryMap::absoluteRect(const WebCore::FloatRect &) const
https://bugs.webkit.org/show_bug.cgi?id=92464
Reviewed by Sam Weinig.
Marquees could cause an updateCompositingLayersAfterScroll() to be called when
we're in the middle of updating layer positions. updateCompositingLayersAfterScroll()
does a full RenderLayer tree walk, but its use of RenderGeomeryMap reveals that
it's using layers whose positions haven't been updated yet.
Fix by avoiding the updateCompositingLayersAfterScroll() if we're in the process
of updating a marquee when updating layer positions. We'll do a compositing update
soon anyway.
Tested by fast/events/tabindex-focus-blur-all.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::scrollTo):
- rendering/RenderLayer.h:
(RenderLayer):
- 7:22 PM Changeset in webkit [129293] by
-
- 7 edits2 copies5 moves3 adds in trunk
WebProcess XPC services need have their environment set without disrupting all other XPC services
https://bugs.webkit.org/show_bug.cgi?id=95161
Reviewed by Anders Carlsson.
Source/WebKit2:
Replace the WebKit2Service with two new XPC services, the WebProcessService, which is only used
when installed on the system, and the WebProcessServiceForWebKitDevelopment which is used at all
other times. We need both services because XPC can't in general be configured to have a custom
environment at runtime, and thus WebProcessServiceForWebKitDevelopment has the ability to re-exec
itself into a desired state. That capability is rather undesirable for installed usage, where we
don't want to allow arbitrary changes to the environment of the service, which would allow breaking
the App Sandbox.
- Configurations/WebProcessService.xcconfig: Copied from Source/WebKit2/Configurations/WebKit2Service.xcconfig.
- Configurations/WebProcessServiceForWebKitDevelopment.xcconfig: Renamed from Source/WebKit2/Configurations/WebKit2Service.xcconfig.
Add new configuration files.
- Platform/mac/WorkQueueMac.cpp:
(WorkQueue::registerMachPortEventHandler):
(WorkQueue::unregisterMachPortEventHandler):
Add helpful assertions. Without them, we confusingly crash a bit later in HashTable code.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
Factor out environment additions to this helper function.
(WebKit::connectToWebProcessServiceForWebKitDevelopment):
(WebKit::createWebProcessServiceForWebKitDevelopment):
Add functionality to setup the webkit development service via re-exec.
(WebKit::createWebProcessService):
Add functionality to connect to the installed WebProcess service.
(WebKit::createProcess):
Factor out posix_spawn based launching into this helper function.
(WebKit::ProcessLauncher::launchProcess):
Call the correct process creation function based on launch data and install state.
- WebKit2.xcodeproj/project.pbxproj:
Add new files to the project.
- WebProcess/mac/WebProcessServiceEntryPoints.h: Renamed from Source/WebKit2/WebProcess/mac/WebProcessXPCServiceMain.h.
- WebProcess/mac/WebProcessServiceEntryPoints.mm: Renamed from Source/WebKit2/WebProcess/mac/WebProcessXPCServiceMain.mm.
(WebKit::WebProcessServiceEventHandler):
(WebProcessServiceMain):
(InitializeWebProcessForWebProcessServiceForWebKitDevelopment):
Rename to WebProcessServiceEntryPoints since this is now used for both the WebProcessService and the
WebProcessServiceForWebKitDevelopment.
- WebProcessService/Info.plist: Copied from Source/WebKit2/WebKit2Service/Info.plist.
- WebProcessService/WebProcessServiceMain.mm: Renamed from Source/WebKit2/WebKit2Service/MainMacService.mm.
Add main for the WebProcessService which just calls into the WebProcessServiceEntryPoints in WebKit2.framework.
- WebProcessServiceForWebKitDevelopment/Info.plist: Renamed from Source/WebKit2/WebKit2Service/Info.plist.
- WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm: Added.
Add main for the WebProcessServiceForWebKitDevelopment, which can't just call directly into WebProcessServiceEntryPoints
as the framework path might not be set up correctly. This is also where we re-exec ourselves when required.
Tools:
Remove setting the XPC_* environment variables.
- Scripts/webkitdirs.pm:
(setUpGuardMallocIfNeeded):
(runMacWebKitApp):
(execMacWebKitAppForDebugging):
- 7:06 PM Changeset in webkit [129292] by
-
- 2 edits in trunk/Source/JavaScriptCore
Eeeep - broke early boyer in bug#97382
https://bugs.webkit.org/show_bug.cgi?id=97383
Rubber stamped by Sam Weinig.
missed a child3 -> child2!
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
- 6:50 PM Changeset in webkit [129291] by
-
- 2 edits in trunk/Tools
Fix typo in additional-platform-directory patch just landed
https://bugs.webkit.org/show_bug.cgi?id=97380
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.relative_test_filename):
(Port.relative_perf_test_filename):
- 6:35 PM Changeset in webkit [129290] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 6:34 PM Changeset in webkit [129289] by
-
- 5 edits in trunk/Source/JavaScriptCore
Pedantic test in Mozilla's JavaScript test suite fails. function-001.js function-001-n.js
https://bugs.webkit.org/show_bug.cgi?id=27219
Reviewed by Sam Weinig.
These tests are just wrong.
See ECMA 262 A.5, FunctionDelcaration does not require a semicolon.
- tests/mozilla/expected.html:
- tests/mozilla/js1_2/function/function-001-n.js:
- tests/mozilla/js1_3/Script/function-001-n.js:
- tests/mozilla/js1_3/regress/function-001-n.js:
- 6:27 PM Changeset in webkit [129288] by
-
- 4 edits4 adds in trunk
Remove bogus assertions from ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=97372
Reviewed by Ryosuke Niwa.
Source/WebCore:
Some asserts (and their accompanying comment) were trying to enforce
proper usage of ChildListMutationScope from WebCore, but in the
presence of MutationEvents they could fail due to arbitrary script
execution.
This change gets rid of those asserts and adds tests exercising
the (pre-existing) codepaths for handling these out-of-order cases.
Without this patch, these tests ASSERT in debug builds.
Tests: fast/mutation/added-out-of-order.html
fast/mutation/removed-out-of-order.html
- dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::childAdded):
(WebCore::ChildListMutationAccumulator::willRemoveChild):
- dom/ChildListMutationScope.h:
(WebCore):
LayoutTests:
- fast/mutation/added-out-of-order-expected.txt: Added.
- fast/mutation/added-out-of-order.html: Added.
- fast/mutation/removed-out-of-order-expected.txt: Added.
- fast/mutation/removed-out-of-order.html: Added.
- 6:18 PM Changeset in webkit [129287] by
-
- 16 edits in trunk/Source/JavaScriptCore
Remove redundant argument to op_instanceof
https://bugs.webkit.org/show_bug.cgi?id=97382
Reviewed by Geoff Garen.
No longer needed after my last change.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitInstanceOf):
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
- bytecompiler/NodesCodegen.cpp:
(JSC::InstanceOfNode::emitBytecode):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 6:13 PM Changeset in webkit [129286] by
-
- 3 edits in trunk/Source/WebKit2
Fix WebKit2 sandbox profile.
Instead of using #pragmas, just disable all warnings in DerivedSources.make. I suspect
that passing -traditional to the preprocessor disables support for #pragmas but I'm afraid
to change it to something else.
- DerivedSources.make:
- WebProcess/com.apple.WebProcess.sb.in:
- 6:00 PM Changeset in webkit [129285] by
-
- 5 edits in trunk/Tools
nrwt: don't require additional-platform-directory to be an abspath or live under LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=97380
Reviewed by Ojan Vafai.
There doesn't seem to be a good reason for this restriction and
it's useful to be able to point to directories outside the
checkout for results (e.g., for local failures due to a 10.7.4
install ;).
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.relative_test_filename):
(Port.relative_perf_test_filename):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._command_from_driver_input):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_additional_platform_directory):
- 6:00 PM Changeset in webkit [129284] by
-
- 3 edits2 adds in trunk
REGRESSION (r129176): Incorrect line breaking when kerning occurs between a space and the following character
https://bugs.webkit.org/show_bug.cgi?id=97377
Reviewed by Enrica Casucci.
Source/WebCore:
Test: fast/text/kerning-with-TextLayout.html
When kerning is enabled, the last character in a word may have its advance shortened because
of its trailing space. To account for that, words are measured along with the trailing space,
then the width of a space is subtracted from the result. This doesn’t work when the trailing
space itself has its advance shortened due to the character following it, which can happen
when using the TextLayout optimization. However, when the optimization is used, the advance
of the last character of the word is already adjusted for the trailing space, so there is no
need to measure with that space and subtract its advance.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Changed to not use the trailingSpaceWidth
mechanism when TextLayout is being used.
LayoutTests:
- fast/text/kerning-with-TextLayout-expected.html: Added.
- fast/text/kerning-with-TextLayout.html: Added.
- 5:53 PM Changeset in webkit [129283] by
-
- 2 edits in trunk/Source/Platform
[chromium] Forward-declare WebSize as a struct
https://bugs.webkit.org/show_bug.cgi?id=97381
Reviewed by James Robinson.
The mismatched "class" forward-declaration for WebSize in this file
will cause a Clang error when it's included in Chromium.
- chromium/public/WebCompositorSoftwareOutputDevice.h:
(WebKit):
- 5:46 PM Changeset in webkit [129282] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 5:43 PM Changeset in webkit [129281] by
-
- 29 edits in trunk
instanceof should not get the prototype for non-default HasInstance
https://bugs.webkit.org/show_bug.cgi?id=68656
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Instanceof is currently implemented as a sequance of three opcodes:
check_has_instance
get_by_id(prototype)
op_instanceof
There are three interesting types of base value that instanceof can be applied to:
(A) Objects supporting default instanceof behaviour (functions, other than those created with bind)
(B) Objects overriding the default instancecof behaviour with a custom one (API objects, bound functions)
(C) Values that do not respond to the HasInstance? trap.
Currently check_has_instance handles case (C), leaving the op_instanceof opcode to handle (A) & (B). There are
two problems with this apporach. Firstly, this is suboptimal for case (A), since we have to check for
hasInstance support twice (once in check_has_instance, then for default behaviour in op_instanceof). Secondly,
this means that in cases (B) we also perform the get_by_id, which is both suboptimal and an observable spec
violation.
The fix here is to move handing of non-default instanceof (cases (B)) to the check_has_instance op, leaving
op_instanceof to handle only cases (A).
- API/JSCallbackObject.h:
(JSCallbackObject):
- API/JSCallbackObjectFunctions.h:
(JSC::::customHasInstance):
- API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
- renamed hasInstance to customHasInstance
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- added additional parameters to check_has_instance opcode
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- added additional parameters to check_has_instance opcode
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCheckHasInstance):
- added additional parameters to check_has_instance opcode
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
- added additional parameters to check_has_instance opcode
- bytecompiler/NodesCodegen.cpp:
(JSC::InstanceOfNode::emitBytecode):
- added additional parameters to check_has_instance opcode
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- added additional parameters to check_has_instance opcode
- interpreter/Interpreter.cpp:
(JSC::isInvalidParamForIn):
(JSC::Interpreter::privateExecute):
- Add handling for non-default instanceof to op_check_has_instance
- jit/JITInlineMethods.h:
(JSC::JIT::emitArrayProfilingSiteForBytecodeIndex):
- Fixed no-LLInt no_DFG build
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emitSlow_op_check_has_instance):
- check for ImplementsDefaultHasInstance, handle additional arguments to op_check_has_instance.
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
- no need to check for ImplementsDefaultHasInstance.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emitSlow_op_check_has_instance):
- check for ImplementsDefaultHasInstance, handle additional arguments to op_check_has_instance.
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
- no need to check for ImplementsDefaultHasInstance.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- Add handling for non-default instanceof to op_check_has_instance
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- move check for ImplementsDefaultHasInstance, handle additional arguments to op_check_has_instance.
- runtime/ClassInfo.h:
(MethodTable):
(JSC):
- renamed hasInstance to customHasInstance
- runtime/CommonSlowPaths.h:
(CommonSlowPaths):
- removed opInstanceOfSlow (this was whittled down to one function call!)
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::customHasInstance):
- runtime/JSBoundFunction.h:
(JSBoundFunction):
- renamed hasInstance to customHasInstance, reimplemented.
- runtime/JSCell.cpp:
(JSC::JSCell::customHasInstance):
- runtime/JSCell.h:
(JSCell):
- runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
(JSC):
(JSC::JSObject::defaultHasInstance):
- runtime/JSObject.h:
(JSObject):
LayoutTests:
- fast/js/function-bind-expected.txt:
- check in passing result.
- 5:31 PM DeprecatingFeatures edited by
- (diff)
- 5:31 PM DeprecatingFeatures edited by
- (diff)
- 5:30 PM Changeset in webkit [129280] by
-
- 4 edits in trunk/Source/WebCore
Simplify and optimize ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=97352
Reviewed by Ryosuke Niwa.
ChildListMutationScope is one of the most complicated bits of
MutationObserver implementation. This patch aims to simplify it for
clarity and improve its performance (mostly by just doing less).
The big change is to remove the MutationAccumulatorRouter class,
replacing it with lifetime-management logic in ChildListMutationAccumulator
ChildListMutationScope is expected to call getOrCreate() in
its constructor, and each scope holds a RefPtr to the accumulator.
When the last scope holding such a RefPtr is destroyed,
ChildListMutationAccumulator's destructor enqueues the accumulated record.
This greatly reduces the number of lines of code, and condenses
two HashMaps into one. It also reduces hash lookups, which now
occur only on scope creation and when the refcount for a given
accumulator reaches 0 (previously, each childAdded and willRemoveChild
call could result in two hash lookups each).
There are some minor changes as well: the ChildListMutationAccumulator::clear()
method is gone, as it was doing more work than necessary;
DEFINE_STATIC_LOCAL is now used instead of hand-rolled static-management
code; ChildListMutationAccumulator::m_lastAdded is no longer a RefPtr, since it
always points at a Node that's already being ref'd by the accumulator.
Also various minor syntactic cleanups.
No new tests, no change in behavior.
- dom/ChildListMutationScope.cpp:
(WebCore::accumulatorMap): Reduced two maps to one, and manage its lifetime with DEFINE_STATIC_LOCAL.
(WebCore::ChildListMutationAccumulator::ChildListMutationAccumulator): Remove unnecessary call to clear() (which itself has been removed).
(WebCore::ChildListMutationAccumulator::~ChildListMutationAccumulator): Enqueue record if not empty at destruction, and have the accumulator
remove itself from the map.
(WebCore::ChildListMutationAccumulator::getOrCreate): Replaces half of MutationAccumulatorRouter's job.
(WebCore::ChildListMutationAccumulator::childAdded): Minor RefPtr usage improvements.
(WebCore::ChildListMutationAccumulator::isRemovedNodeInOrder): Simplify RefPtr syntax.
(WebCore::ChildListMutationAccumulator::willRemoveChild): Minor RefPtr usage improvements.
(WebCore::ChildListMutationAccumulator::enqueueMutationRecord): Replace call to clear() with clearing m_lastAdded,
since it's the only bit not cleared by the MutationRecord creation call. Also remove
isEmpty check and replace with asserts now that it's a private method.
(WebCore::ChildListMutationAccumulator::isEmpty): Added more assertions about emptiness.
- dom/ChildListMutationScope.h:
(WebCore):
(ChildListMutationAccumulator): Extract the inner class to make everything easier to read.
(WebCore::ChildListMutationScope::ChildListMutationScope): Store m_accumulator rather than m_target.
(WebCore::ChildListMutationScope::~ChildListMutationScope): ditto
(WebCore::ChildListMutationScope::childAdded): ditto
(WebCore::ChildListMutationScope::willRemoveChild): ditto
(ChildListMutationScope):
- html/HTMLElement.cpp: Remove unused ChildListMutationScope.h #include.
- 5:16 PM Changeset in webkit [129279] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip this test because it relies on sandboxed-iframe-origin-add.html which was removed in http://trac.webkit.org/changeset/129262.
- platform/win/Skipped:
- 5:13 PM Changeset in webkit [129278] by
-
- 4 edits in trunk
fast/dom/Geolocation/disconnected-frame.html test asserts
https://bugs.webkit.org/show_bug.cgi?id=97376
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-21
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
In GeolocationPermissionRequestManager::cancelRequestForGeolocation, we access an iterator
after its value has been removed from the table.
There are two problems with that:
-The iterator is no longer valid after the container has been modified.
-If it was the last element, the table has been freed and the iterator points to deleted memory.
We solve the issue by keeping a copy of the ID. We could have inverted the order of the calls
but that would make the issue less visible for future change.
Testing covered by fast/dom/Geolocation/disconnected-frame.html.
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):
LayoutTests:
- platform/wk2/Skipped:
- 4:58 PM Changeset in webkit [129277] by
-
- 4 edits in trunk/Source/WebCore
BiquadFilterNode must take audio-rate parameter changes into account
https://bugs.webkit.org/show_bug.cgi?id=97369
Reviewed by Kenneth Russell.
BiquadFilterNode is currently ignoring any timeline or audio-rate changes to its parameters.
We now check if any of its parameters have timeline or audio-rate changes and, if so, take
them into account. Otherwise, we use ordinary parameter smoothing/de-zippering which is
the case when the parameters are adjusted, for example, from a knob or slider in the UI.
- Modules/webaudio/BiquadDSPKernel.cpp:
(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):
- Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::checkForDirtyCoefficients):
- Modules/webaudio/BiquadProcessor.h:
(WebCore::BiquadProcessor::hasSampleAccurateValues):
(BiquadProcessor):
- 4:58 PM Changeset in webkit [129276] by
-
- 5 edits in trunk/LayoutTests
Unreviewed. Fix Windows specific accessibility test results.
Missed some new lines in http://trac.webkit.org/changeset/129255.
- platform/win/accessibility/aria-toggle-button-with-title-expected.txt:
- platform/win/accessibility/canvas-fallback-content-2-expected.txt:
- platform/win/accessibility/img-fallsback-to-title-expected.txt:
- platform/win/accessibility/svg-image-expected.txt:
- 4:47 PM Changeset in webkit [129275] by
-
- 13 edits2 adds in trunk
Add support for OES_vertex_array_object in chromium
https://bugs.webkit.org/show_bug.cgi?id=96578
Patch by Brandon Jones <bajones@google.com> on 2012-09-21
Reviewed by Kenneth Russell.
Source/Platform:
Added code to allow calls to the OES_vertex_array_object extension to interface
properly with the chromium WebGL implementation.
- chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::createVertexArrayOES):
(WebKit::WebGraphicsContext3D::deleteVertexArrayOES):
(WebKit::WebGraphicsContext3D::isVertexArrayOES):
(WebKit::WebGraphicsContext3D::bindVertexArrayOES):
Source/WebCore:
Adding basic reference counting to WebGLBuffer objects to satisfy spec requirements
for the OES_vertex_array_object extension. Added code to allow calls to the
OES_vertex_array_object extension to interface properly with the chromium WebGL
implementation.
Test: fast/canvas/webgl/oes-vertex-array-object.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::deleteBuffer):
(WebCore::WebGLRenderingContext::vertexAttribPointer):
- html/canvas/WebGLVertexArrayObjectOES.cpp:
(WebCore::WebGLVertexArrayObjectOES::setElementArrayBuffer):
(WebCore):
- html/canvas/WebGLVertexArrayObjectOES.h:
(WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::getVertexAttribStateSize):
- platform/chromium/support/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::createVertexArrayOES):
(WebCore::Extensions3DChromium::deleteVertexArrayOES):
(WebCore::Extensions3DChromium::isVertexArrayOES):
(WebCore::Extensions3DChromium::bindVertexArrayOES):
LayoutTests:
Brought over KHRONOS conformance test for OES_vertex_array_object
- fast/canvas/webgl/oes-vertex-array-object-expected.txt: Added.
- fast/canvas/webgl/oes-vertex-array-object.html: Added.
- platform/efl/Skipped:
- platform/gtk-wk2/Skipped:
- platform/mac/Skipped:
- platform/wk2/Skipped:
- 4:40 PM Changeset in webkit [129274] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, fix ARM build.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::store8):
(MacroAssemblerARMv7):
- offlineasm/armv7.rb:
- 4:35 PM Changeset in webkit [129273] by
-
- 28 edits in trunk
[Chromium] Use OpenTypeVerticalData on Linux
https://bugs.webkit.org/show_bug.cgi?id=97277
Reviewed by Tony Chang.
Source/WebCore:
Remove HarfBuzz dependency from GlyphPageTreeNodeSkia. Use OpenTypeVerticalData instead.
No new tests. Rebaselined existing tests.
- WebCore.gyp/WebCore.gyp: Added OpenTypeTypes.h and OpenTypeVerticalData.(cpp|h) for linux and android.
- platform/graphics/FontCache.cpp:
Inserted a space between > and > in typedef of FontVerticalDataCache so that making some compilers happy.
(WebCore):
- platform/graphics/SimpleFontData.h:
(SimpleFontData): Moved declaration of m_verticalData to avoid compile warnings.
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore):
(WebCore::FontPlatformData::verticalData): Added.
(WebCore::FontPlatformData::openTypeTable): Added.
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(WebCore):
(FontPlatformData):
- platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Removed substituteWithVerticalGlyphs().
(WebCore::GlyphPage::fill):
Source/WebKit/chromium:
- features.gypi: Enable OPENTYPE_VERTICAL on linux and android.
LayoutTests:
Rebaselined vertical writing test expectations.
- platform/chromium-linux/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
- platform/chromium-linux/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
- platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
- platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
- platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
- platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
- platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
- platform/chromium-linux/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
- platform/chromium-linux/fast/dynamic/text-combine-expected.png:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/chromium-linux/fast/text/international/text-spliced-font-expected.png:
- platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-lr-text-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-rl-text-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
- 4:30 PM DeprecatingFeatures edited by
- (diff)
- 4:29 PM Changeset in webkit [129272] by
-
- 4 edits in trunk/Source/JavaScriptCore
REGRESSION (r128400): Opening Google Web Fonts page hangs or crashes
https://bugs.webkit.org/show_bug.cgi?id=97328
Reviewed by Mark Hahnenberg.
It's a bad idea to emit stub code that reallocates property storage when we're in indexed
storage mode. DFGRepatch.cpp knew this and had the appropriate check in one of the places,
but it didn't have it in all of the places.
This change also adds some more handy disassembly support, which I used to find the bug.
- assembler/LinkBuffer.h:
(JSC):
- dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
- jit/JITStubRoutine.h:
(JSC):
- 4:22 PM Changeset in webkit [129271] by
-
- 1 edit in branches/chromium/1229/Source/WebCore/dom/Document.cpp
Merge 129270 - Crash in WebCore::Document::fullScreenChangeDelayTimerFired
BUG=147700
Review URL: https://codereview.chromium.org/10969052
- 4:21 PM DeprecatingFeatures edited by
- (diff)
- 4:20 PM Changeset in webkit [129270] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::Document::fullScreenChangeDelayTimerFired
https://bugs.webkit.org/show_bug.cgi?id=97367
Patch by Jeremy Apthorp <jeremya@chromium.org> on 2012-09-21
Reviewed by Abhishek Arya.
The document could be destroyed during the processing of the
fullscreenchange event, if the document was destroyed as a result of
one of the dispatchEvent calls.
This bug isn't reliably reproducible, so no new tests.
- dom/Document.cpp:
(WebCore::Document::fullScreenChangeDelayTimerFired):
- 4:18 PM Changeset in webkit [129269] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r120361) Warnings while preprocessing com.apple.WebProcess.sb.in
https://bugs.webkit.org/show_bug.cgi?id=91079
<rdar://problem/12332660>
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb.in:
Add pragma to ignore the invalid preprocessor warnings.
- 4:16 PM DeprecatingFeatures edited by
- (diff)
- 4:15 PM Changeset in webkit [129268] by
-
- 2 edits in trunk/LayoutTests
Skip fast/dom/Geolocation/disconnected-frame.html until the assertion is fixed
Unreviewed. The test assert in Debug, skip it until this has been fixed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-21
- platform/wk2/Skipped:
- 4:07 PM Changeset in webkit [129267] by
-
- 2 edits in trunk/Source/WebCore
No need to pass order file for WebCoreTestSupport build
https://bugs.webkit.org/show_bug.cgi?id=97363
Reviewed by David Kilzer.
No new tests because no functional change.
- Configurations/WebCoreTestSupport.xcconfig:
- 3:59 PM Changeset in webkit [129266] by
-
- 5 edits3 adds in trunk
DFG CSE assumes that a holy PutByVal does not interfere with GetArrayLength, when it clearly does
https://bugs.webkit.org/show_bug.cgi?id=97373
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGGraph.h:
(Graph):
LayoutTests:
- fast/js/dfg-holy-put-by-val-interferes-with-get-array-length-expected.txt: Added.
- fast/js/dfg-holy-put-by-val-interferes-with-get-array-length.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-holy-put-by-val-interferes-with-get-array-length.js: Added.
(foo):
- 3:51 PM DeprecatingFeatures edited by
- (diff)
- 3:47 PM TestExpectations edited by
- delete description of the old syntax (diff)
- 3:39 PM DeprecatingFeatures edited by
- (diff)
- 3:35 PM Changeset in webkit [129265] by
-
- 3 edits in trunk/Tools
webkitpy: drop support for old TestExpectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97364
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._collect_matching_tests):
(TestExpectationParser):
(TestExpectationParser._tokenize_line):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(SkippedTests.test_skipped_entry_dont_exist):
(ExpectationSyntaxTests.assert_tokenize_exp):
(ExpectationSyntaxTests.test_bare_name):
(ExpectationSyntaxTests.test_bare_name_and_bugs):
(ExpectationSyntaxTests.test_comments):
(ExpectationSyntaxTests.test_config_modifiers):
(ExpectationSyntaxTests.test_unknown_config):
(ExpectationSyntaxTests.test_unknown_expectation):
(ExpectationSyntaxTests.test_skip):
(ExpectationSyntaxTests.test_slow):
(ExpectationSyntaxTests.test_wontfix):
(ExpectationSyntaxTests.test_blank_line):
(ExpectationSyntaxTests.test_warnings):
(RebaseliningTest.test_no_get_rebaselining_failures):
- 3:33 PM Changeset in webkit [129264] by
-
- 2 edits in trunk/Tools
Improve WTR unresponsiveness output a little
https://bugs.webkit.org/show_bug.cgi?id=97370
Reviewed by Timothy Horton.
Distinguish between conditions that already set the errorMessage,
and unresponsiveness due to slow about:blank loads when WTR
reports unresponsiveness.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
- 3:30 PM Changeset in webkit [129263] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS to r158095 to pick up typo fix in test_expectations.txt
Unreviewed, rolled DEPS.
- DEPS:
- 3:27 PM Changeset in webkit [129262] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skipping http/tests/security/sandboxed-iframe-origin-add.html.
https://bugs.webkit.org/show_bug.cgi?id=97271
- platform/win/Skipped:
- 3:26 PM DeprecatingFeatures edited by
- (diff)
- 3:22 PM Changeset in webkit [129261] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS to r158060
Unreviewed, rolled DEPS.
- DEPS:
- 3:13 PM DeprecatingFeatures edited by
- (diff)
- 3:12 PM Changeset in webkit [129260] by
-
- 27 edits in trunk
Add Web Audio support for deprecated/legacy APIs
https://bugs.webkit.org/show_bug.cgi?id=97050
Reviewed by Eric Carlson.
.:
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
The Web Audio API specification has undergone much review and some small API changes
have been made (mostly naming-related changes). This patch adds an ENABLE_LEGACY_WEB_AUDIO
build option to allow ports to support the old names.
Tests changed:
audiobuffersource-playbackrate.html
audiobuffersource.html
note-grain-on-testing.js
oscillator-testing.js
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.features.am:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::startGrain):
(WebCore):
(WebCore::AudioBufferSourceNode::noteGrainOn):
- Modules/webaudio/AudioBufferSourceNode.h:
(AudioBufferSourceNode):
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::start):
(WebCore::AudioScheduledSourceNode::stop):
(WebCore):
(WebCore::AudioScheduledSourceNode::noteOn):
(WebCore::AudioScheduledSourceNode::noteOff):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/Oscillator.idl:
- page/FeatureObserver.h:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
- webaudio/audiobuffersource-playbackrate.html:
- webaudio/audiobuffersource.html:
- webaudio/resources/note-grain-on-testing.js:
(playGrain):
- webaudio/resources/oscillator-testing.js:
(generateExponentialOscillatorSweep):
- 3:04 PM DeprecatingFeatures edited by
- (diff)
- 3:02 PM Changeset in webkit [129259] by
-
- 4 edits in trunk/Tools
webkitpy: update remaining tests to use the new expectation syntax
https://bugs.webkit.org/show_bug.cgi?id=97362
Reviewed by Ojan Vafai.
This patch updates all the unit tests that were still using the
old TestExpectations syntax to use the new syntax *except* for
the tests that were specifically testing that we parsed the old
syntax correctly.
Also, a block of tests for the new syntax were duplicated, so
I've deleted the duplicate.
Note that the old syntax is still supported so this change should
produce no visible changes.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(MiscTests.test_multiple_results):
(MiscTests.test_category_expectations):
(MiscTests.test_error_on_different_platform):
(MiscTests.test_error_on_different_build_type):
(MiscTests.test_overrides):
(MiscTests.test_overridesdirectory):
(MiscTests.test_overridesduplicate):
(MiscTests.test_more_specific_override_resets_skip):
(SkippedTests.check):
(SkippedTests.test_duplicate_skipped_test_fails_lint):
(SkippedTests.test_skipped_file_overrides_expectations):
(SkippedTests.test_skipped_dir_overrides_expectations):
(SkippedTests.test_skipped_file_overrides_overrides):
(SkippedTests.test_skipped_dir_overrides_overrides):
(ExpectationSyntaxTests.disabled_test_missing_expectation):
(ExpectationSyntaxTests.disabled_test_missing_colon):
(ExpectationSyntaxTests.disabled_test_too_many_colons):
(ExpectationSyntaxTests.disabled_test_too_many_equals_signs):
(ExpectationSyntaxTests):
(ExpectationSyntaxTests.test_unrecognized_expectation):
(ExpectationSyntaxTests.test_macro):
(SemanticTests.test_bug_format):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_missing_bugid):
(SemanticTests.test_slow_and_timeout):
(SemanticTests.test_rebaseline):
(test_missing_file):
(test_ambiguous):
(test_more_modifiers):
(test_order_in_file):
(test_macro_overrides):
(OldExpectationParserTests):
(OldExpectationParserTests._tokenize):
(OldExpectationParserTests.test_tokenize_extra_colon):
(OldExpectationParserTests.test_tokenize_missing_equal):
(OldExpectationParserTests.test_tokenize_extra_equal):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_skip_failing_tests):
(MainTest.test_additional_expectations):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_valid_expectations):
(TestExpectationsTestCase.test_invalid_expectations):
(TestExpectationsTestCase.test_tab):
- 2:57 PM DeprecatingFeatures edited by
- (diff)
- 2:57 PM Changeset in webkit [129258] by
-
- 1 edit4 adds in trunk/LayoutTests
Unreviewed. As in https://bugs.webkit.org/show_bug.cgi?id=92916, Windows specific results need to be added for various accessibility tests.
- platform/win/accessibility/aria-toggle-button-with-title-expected.txt: Added.
- platform/win/accessibility/canvas-fallback-content-2-expected.txt: Added.
- platform/win/accessibility/img-fallsback-to-title-expected.txt: Added.
- platform/win/accessibility/svg-image-expected.txt: Added.
- 2:46 PM DeprecatingFeatures edited by
- (diff)
- 2:43 PM Changeset in webkit [129257] by
-
- 11 edits2 adds in trunk/Source
[Chromium] remove getFontFamilyForCharacters from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96282
Reviewed by Tony Chang.
Migrating away from PlatformSupport. getFontFamilyForCharacters is
moved to FontCache.h and overridden by the two platforms that
need it (Chromium Linux and Blackberry). New files for the overrides.
Part of a larger refactoring series. See tracking bug 82948.
Source/WebCore:
- PlatformBlackBerry.cmake:
- WebCore.gypi:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/graphics/FontCache.h:
(SimpleFontFamily):
(FontCache):
- platform/graphics/blackberry/FontCacheBlackberry.cpp: Added.
(WebCore):
(WebCore::FontCache::getFontFamilyForCharacters):
- platform/graphics/blackberry/skia/PlatformSupport.cpp:
(WebCore):
- platform/graphics/blackberry/skia/PlatformSupport.h:
(PlatformSupport):
- platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/chromium/FontCacheChromiumLinux.cpp: Added.
(WebCore):
(WebCore::FontCache::getFontFamilyForCharacters):
- platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::getFontDataForCharacters):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 2:40 PM Changeset in webkit [129256] by
-
- 2 edits in branches/safari-536.27-branch/Source/JavaScriptCore
Enable opportunistic garbage collecting on Windows.
Patch by Roger Fong <roger_fong@apple.com> on 2012-09-20
Reviewed by Mark Hahnenberg
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 2:39 PM Changeset in webkit [129255] by
-
- 1 edit4 adds in trunk/LayoutTests
Unreviewed. Creating some Windows specific tests.
http://trac.webkit.org/changeset/128652 changed results for these tests on Mac but Windows results should stay the same.
- platform/win/fast/block/positioning: Added.
- platform/win/fast/block/positioning/016-expected.txt: Added.
- platform/win/fast/block/positioning/025-expected.txt: Added.
- platform/win/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
- 2:27 PM Changeset in webkit [129254] by
-
- 6 edits2 adds in trunk
Source/WebCore: AX: WebKit exposes incorrect bounds for embedded SVG in HTML
https://bugs.webkit.org/show_bug.cgi?id=96168
Reviewed by Eric Seidel.
Override absoluteFocusRingQuads() for SVG objects because the default
implementation relies on addFocusRingRects(). In addFocusRingRects(), SVG
objects adds local positions for its rects instead of absolute positions.
Test: accessibility/svg-bounds.html
- rendering/RenderObject.h:
(RenderObject):
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore):
(WebCore::RenderSVGModelObject::absoluteFocusRingQuads):
- rendering/svg/RenderSVGModelObject.h:
(RenderSVGModelObject):
LayoutTests: WebKit exposes incorrect bounds for embedded SVG in HTML
https://bugs.webkit.org/show_bug.cgi?id=96168
Reviewed by Eric Seidel.
- accessibility/svg-bounds.html: Added.
- platform/chromium/TestExpectations:
- platform/mac/accessibility/svg-bounds-expected.txt: Added.
- 2:24 PM Changeset in webkit [129253] by
-
- 1 edit in branches/chromium/1271/Source/WebKit/chromium/features.gypi
Merge 125155 - Disable iframe seamless for m23.
Review URL: https://codereview.chromium.org/10970046
- 2:06 PM Changeset in webkit [129252] by
-
- 22 edits2 adds in trunk
[WK2] Add basic testing support for Geolocation
https://bugs.webkit.org/show_bug.cgi?id=97278
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
- Shared/API/c/WKNumber.h: Fix an unfortunate copy-paste :)
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
Remove the code forcing the Geolocation permissions. It was working around the normal
Geolocation code and updating all the GeolocationController, which is a terrible idea.
Tools:
Update the Geolocation testing to use the proper API in the UIProcess.
- WebKitTestRunner/CMakeLists.txt:
- WebKitTestRunner/GNUmakefile.am:
- WebKitTestRunner/GeolocationProviderMock.cpp: Added.
(WTR::startUpdatingCallback):
(WTR::stopUpdatingCallback):
(WTR::GeolocationProviderMock::GeolocationProvierMock):
(WTR::GeolocationProviderMock::setMockGeolocationPosition):
(WTR::GeolocationProviderMock::startUpdating):
(WTR::GeolocationProviderMock::stopUpdating):
(GeolocationProviderMock):
The GeolocationProvider store the location update and deliver them as needed.
WebCore GeolocationController do not support asynchronous update on start/stop. This is not
a problem in this case because all the messages between the WebProcess and the UIProcess are
asynchronous. Because of this, unlike GeolocationClientMock, we do not use a timer for event
delivery.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::setGeolocationPermission):
(WTR::InjectedBundle::setMockGeolocationPosition):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setGeolocationPermission):
(WTR::TestRunner::setMockGeolocationPosition):
From the InjectedBundle, we now pass the information to the UIProcess so that
GeolocationProvider and the TestController can respond appropriately.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::decidePolicyForGeolocationPermissionRequest):
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
(WTR::TestController::setMockGeolocationPosition):
- WebKitTestRunner/TestController.h:
(TestController):
(WTR::TestController::setGeolocationPermission):
(WTR::TestController::isGeolocationPermissionAllowed):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/win/WebKitTestRunner.vcproj:
LayoutTests:
- platform/wk2/Skipped: Unskip the passing tests.
- 2:02 PM Changeset in webkit [129251] by
-
- 12 edits1 add in trunk/Source
[BlackBerry] Really fix bug 95488 that user can get the authentication challenge dialog while the other tab has focus.
https://bugs.webkit.org/show_bug.cgi?id=97348
Internal PR: 186597.
Internally reviewed by Yong Li, Joe Mason.
Patch by Lianghui Chen <liachen@rim.com> on 2012-09-21
Reviewed by Yong Li.
Source/WebCore:
Add a singleton AuthenticationChallengeManager to manage authentication
challenge dialog. It does following things:
Record page creation/deletion, so it knows what page is present or not.
Record page visibility change so it knows when to display a dialog or not.
Accept authentication challenge, and decide whether to postpone the
challenge dialog based on whether there is active authentication challenge
dialog already and whether its page is visible or not.
When a challenge result comes back, notify the result to all clients
authenticating for the same protection space, and then start the next
authentication challenge from the same page, if there is one.
When a page becomes visible, start the first authentication challenge
dialog that has been blocked before.
And to support this new AuthenticationChallengeManager, and making the
challenge really asynchronous, NetworkJob has been updated to support
the concept of "freeze", which means buffering all network loading status
change but don't send them to NetworkJob clients.
This is necessary when authentication challenge is asynchronous, as the
previous network loading status will likely come before user make any
decision.
No new tests for platform specific internal change.
- PlatformBlackBerry.cmake:
- platform/blackberry/AuthenticationChallengeManager.cpp: Added.
(WebCore):
(ChallengeInfo):
(WebCore::ChallengeInfo::ChallengeInfo):
(AuthenticationChallengeManagerPrivate):
(WebCore::AuthenticationChallengeManagerPrivate::AuthenticationChallengeManagerPrivate):
(WebCore::AuthenticationChallengeManagerPrivate::resumeAuthenticationChallenge):
(WebCore::AuthenticationChallengeManagerPrivate::startAuthenticationChallenge):
(WebCore::AuthenticationChallengeManagerPrivate::pageExists):
(WebCore::AuthenticationChallengeManager::AuthenticationChallengeManager):
(WebCore::AuthenticationChallengeManager::pageCreated):
(WebCore::AuthenticationChallengeManager::pageDeleted):
(WebCore::AuthenticationChallengeManager::pageVisibilityChanged):
(WebCore::AuthenticationChallengeManager::authenticationChallenge):
(WebCore::AuthenticationChallengeManager::cancelAuthenticationChallenge):
(WebCore::AuthenticationChallengeManager::notifyChallengeResult):
(WebCore::AuthenticationChallengeManager::instance):
(WebCore::AuthenticationChallengeManager::init):
- platform/blackberry/AuthenticationChallengeManager.h:
(WebCore):
(AuthenticationChallengeManager):
- platform/blackberry/PageClientBlackBerry.h:
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::~NetworkJob):
(WebCore):
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
Source/WebKit/blackberry:
Update WebPage to use new AuthenticationChallengeManager.
Register page creation/deletion and visibility change to the new
AuthenticationChallengeManager.
Initialize AuthenticationChallengeManager in GlobalInitialize() function.
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::setVisible):
- Api/WebPage_p.h:
(WebPagePrivate):
- 1:32 PM Changeset in webkit [129250] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Make Web Inspector work in multiple web process mode
https://bugs.webkit.org/show_bug.cgi?id=97354
Reviewed by Timothy Hatcher.
- UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage):
Tell WKView that it's related to original page, making inspector page be in the same process.
- 1:16 PM Changeset in webkit [129249] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r129248.
http://trac.webkit.org/changeset/129248
https://bugs.webkit.org/show_bug.cgi?id=96000
Broke win build
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- rendering/RenderingAllInOne.cpp:
- 1:10 PM WebKitGTK/1.10.x edited by
- (diff)
- 1:09 PM Changeset in webkit [129248] by
-
- 4 edits in trunk/Source/WebCore
Make RenderingAllInOne.cpp usable for ports other than Apple/Win
https://bugs.webkit.org/show_bug.cgi?id=96000
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-21
Reviewed by Ryosuke Niwa.
RenderingAllInOne.cpp unconditionally includes RenderThemeWin. This patch separates
it out from the file.
- Target.pri: Add RenderingAllInOne.cpp to the list of supported all-in-one files.
- WebCore.vcproj/WebCore.vcproj: Compile RenderThemeWin.cpp separately.
- rendering/RenderingAllInOne.cpp: Don't include RenderThemeWin.cpp here.
- 1:03 PM Changeset in webkit [129247] by
-
- 6 edits1 add in trunk
REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=96196
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-21
Reviewed by Martin Robinson.
The "regression" is that a new test was added but the support was missing
in the Gtk port for spin buttons.
Source/WebCore:
No new tests. Instead the new test which had been skipped was unskipped
as part of this fix.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Map SpinButtonRole to ATK_ROLE_SPIN_BUTTON
(getInterfaceMaskFromObject): Add SpinButtonRole to the roles implementing
the AtkValue interface.
Tools:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::valueDescription): Updated the FIXME comment to
indicate that this cannot be implemented until it is implemented in ATK.
URL of the newly-filed ATK bug included for reference.
LayoutTests:
- platform/gtk/TestExpectations: Unskip the new test.
- platform/gtk/accessibility/spinbutton-value-expected.txt: Added.
- 12:40 PM Changeset in webkit [129246] by
-
- 3 edits2 adds in trunk
[GTK] [Stable] Infinite recursion in WebCore::AXObjectCache::getOrCreate
https://bugs.webkit.org/show_bug.cgi?id=96932
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-21
Reviewed by Martin Robinson.
Source/WebCore:
Make the decision based on RenderObjects rather than AccessibilityObjects
to avoid the infinite recursion which occurs when remapAriaRoleDueToParent
gets called.
Test: platform/gtk/accessibility/remapped-aria-crash.html
- accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
LayoutTests:
Added a new test which replicates the recursion and crash.
- platform/gtk/accessibility/remapped-aria-crash-expected.txt: Added.
- platform/gtk/accessibility/remapped-aria-crash.html: Added.
- 12:35 PM Changeset in webkit [129245] by
-
- 2 edits in trunk/Tools
Fix test_skip_and_wontfix failure
https://bugs.webkit.org/show_bug.cgi?id=97225
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(SemanticTests.test_skip_and_wontfix):
- 12:24 PM Changeset in webkit [129244] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] HTML5 media does not handle SSL certificate failures
https://bugs.webkit.org/show_bug.cgi?id=93324
Patch by Jonathan Dong <Jonathan Dong> on 2012-09-21
Reviewed by Eric Carlson.
RIM PR: 116205
Passed FrameLoaderClientBlackBerry's playerId to MMRPlayer::load()
because MMRPlayer::load() added playerId as a new parameter, which
is required to initiate a MediaSSLHandlerStream to deal with
certificate failure when loading a "https" media url.
Internally reviewed by Joe Mason <jmason@rim.com>.
No new tests since there's no functional change.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::load):
- 11:47 AM Changeset in webkit [129243] by
-
- 4 edits in trunk/Source
[chromium] Add setters to WebFilterOperation for IPC pickling
https://bugs.webkit.org/show_bug.cgi?id=97147
Reviewed by James Robinson.
Source/Platform:
These methods allow us to restore a WebFilterOperation from a blob
of opaque data. The pickling code needs to be able to create an
empty object and then fill in the pieces, so these setters allow it
to do so.
Test: WebFilterOperationsTest.saveAndRestore
- chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::dropShadowOffset):
(WebKit::WebFilterOperation::matrix):
(WebKit::WebFilterOperation::zoomRect):
(WebFilterOperation):
(WebKit::WebFilterOperation::createEmptyFilter):
(WebKit::WebFilterOperation::setType):
(WebKit::WebFilterOperation::setAmount):
(WebKit::WebFilterOperation::setDropShadowOffset):
(WebKit::WebFilterOperation::setDropShadowColor):
(WebKit::WebFilterOperation::setMatrix):
(WebKit::WebFilterOperation::setZoomRect):
- chromium/src/WebFilterOperation.cpp:
Source/WebKit/chromium:
- tests/FilterOperationsTest.cpp:
(WebKit):
(WebKit::TEST):
- 11:13 AM Changeset in webkit [129242] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Unreviewed, remove duplicate section of WebKit.gyp pointed out by Nico.
- WebKit.gyp:
- 11:09 AM Changeset in webkit [129241] by
-
- 5 edits in trunk
Global Math object should be configurable but isn't
https://bugs.webkit.org/show_bug.cgi?id=55343
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This has no performance impact.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- Make 'Math' a regular property.
LayoutTests:
Added test case.
- fast/js/math-expected.txt:
- fast/js/script-tests/math.js:
- Added test case.
- 10:43 AM Changeset in webkit [129240] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-21
- DEPS:
- 10:28 AM Changeset in webkit [129239] by
-
- 3 edits in trunk/Source/WebCore
[WebSocket] Receiving a large message is really slow
https://bugs.webkit.org/show_bug.cgi?id=97237
Patch by Evan Wallace <evan.exe@gmail.com> on 2012-09-21
Reviewed by Alexey Proskuryakov.
WebSocketChannel always reallocates its internal buffer when it receives
and appends new data which causes dramatic slowdowns for messages over
2 MB in size. This patch changes the internal buffer of WebSocketChannel
from a raw char array to a Vector<char> and uses its amortized append()
method. This brings the time to receive a 5 MB message from 5.2 seconds
to 0.25 seconds.
This patch is only for optimization. No new tests are needed.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::~WebSocketChannel):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::resume):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::appendToBuffer):
(WebCore::WebSocketChannel::skipBuffer):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::resumeTimerFired):
(WebCore::WebSocketChannel::processFrame):
- Modules/websockets/WebSocketChannel.h:
- 9:50 AM Changeset in webkit [129238] by
-
- 9 edits1 copy in trunk
[GTK] Implement ViewState methods in PageClientImpl in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=97202
Reviewed by Martin Robinson.
Source/WebKit2:
Implement isViewWindowActive(), isViewFocused(), isViewVisible()
and isViewInWindow() in PageClientImpl.
- GNUmakefile.list.am: Add new files to compilation.
- UIProcess/API/C/gtk/WKView.cpp:
(WKViewSetFocus): New private method used by WTR to focus the
WebView.
- UIProcess/API/C/gtk/WKViewPrivate.h: Added.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::isViewWindowActive): Return
webkitWebViewBaseIsInWindowActive().
(WebKit::PageClientImpl::isViewFocused): Return
webkitWebViewBaseIsFocused().
(WebKit::PageClientImpl::isViewVisible): Return
webkitWebViewBaseIsVisible().
(WebKit::PageClientImpl::isViewInWindow): Return
webkitWebViewBaseIsInWindow().
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseNotifyResizerSize): Updated to not receive the
window as parameter since it's now saved in the instance struct.
(toplevelWindowResizeGripVisibilityChanged): Update to
webkitWebViewBaseNotifyResizerSize() API change.
(toplevelWindowFocusInEvent): Update ViewWindowIsActive flag and
notify the WebPageProxy if it changed.
(toplevelWindowFocusOutEvent): Ditto.
(webkitWebViewBaseSetToplevelOnScreenWindow): Set the toplevel
on-screen window where the view is currently added and notify
WebPageProxy if it changed.
(webkitWebViewBaseRealize): Call
webkitWebViewBaseSetToplevelOnScreenWindow() if the view has been
added to an on-screen window.
(webkitWebViewBaseFinalize): Reset the toplevel on-screen window
to make sure all signals are disconnected when the view is
destroyed.
(webkit_web_view_base_init): Remove unneeded initialization.
(resizeWebKitWebViewBaseFromAllocation): Update to
webkitWebViewBaseNotifyResizerSize() API change.
(webkitWebViewBaseMap): Update ViewIsVisible flag and notify
WebPageProxy if it changed.
(webkitWebViewBaseUnmap): Ditto.
(webkitWebViewBaseFocusInEvent): Call webkitWebViewBaseSetFocus()
passing true to focus the view.
(webkitWebViewBaseFocusOutEvent): Call webkitWebViewBaseSetFocus()
passing false to unfocus the view.
(webkitWebViewBaseParentSet): Reset the toplevel on-screen window
if the view is re-parented.
(webkit_web_view_base_class_init): Add implementations for map and
parent-set virtual functions.
(webkitWebViewBaseSetFocus): Update the ViewIsFocused and notify
WebPageProxy if it changed.
(webkitWebViewBaseIsInWindowActive):
(webkitWebViewBaseIsFocused):
(webkitWebViewBaseIsVisible):
(webkitWebViewBaseIsInWindow):
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget): Use a GTK_WINDOW_TOPLEVEL instead of
POPUP for this test to make sure the view receives focus change
events.
Tools:
- WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::focus): Focus the view.
- 9:45 AM WebKitGTK/1.10.x edited by
- (diff)
- 9:44 AM Changeset in webkit [129237] by
-
- 52 edits in branches/safari-534.58-branch
Source/WebCore: Update Localizable.strings after merging plug-in blacklisting changes.
- English.lproj/Localizable.strings:
Source/WebKit/mac: Merge r119543.
2012-06-05 Anders Carlsson <andersca@apple.com>
Build fix.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
The error constant has been renamed.
Source/WebKit/win: Merge r116687.
2012-05-10 Anders Carlsson <andersca@apple.com>
Rename the missing plug-in indicator to the unavailable plug-in indicator
https://bugs.webkit.org/show_bug.cgi?id=86136
Reviewed by Sam Weinig.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
Source/WebKit2: Merge r117634.
2012-05-18 Anders Carlsson <andersca@apple.com>
Missing plugin msg becomes "insecure plugin version" after Real Player page refresh
https://bugs.webkit.org/show_bug.cgi?id=86903
<rdar://problem/11477163>
Reviewed by Andreas Kling.
Set blocked to false before returning early when the plug-in doesn't exist.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::getPluginPath):
Tools: Merge r116716.
2012-05-10 Anders Carlsson <andersca@apple.com>
WebKit2: Add a way to blacklist specific plug-ins/plug-in versions
https://bugs.webkit.org/show_bug.cgi?id=86164
<rdar://problem/9551196>
Reviewed by Sam Weinig.
Update for WK2 API changes.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
WebKitLibraries: Merge r116695.
2012-05-10 Anders Carlsson <andersca@apple.com>
WebKit1: Add a way to blacklist specific plug-ins/plug-in versions
https://bugs.webkit.org/show_bug.cgi?id=86150
<rdar://problem/9551196>
Reviewed by Sam Weinig.
Add WKShouldBlockPlugin.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 9:41 AM Changeset in webkit [129236] by
-
- 2 edits in trunk/Source/WebCore
Fix build with ENABLE_WEBGL=false
https://bugs.webkit.org/show_bug.cgi?id=97309
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-21
Reviewed by Eric Seidel.
WebKit no longer builds when WEBGL is not enabled.
- rendering/FilterEffectRenderer.h:
(FilterEffectRenderer):
- 9:32 AM Changeset in webkit [129235] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Media player won't resize for the following source when first source fail to load
https://bugs.webkit.org/show_bug.cgi?id=97342
Patch by Jonathan Dong <Jonathan Dong> on 2012-09-21
Reviewed by Yong Li.
As platformPlayer will notify MediaPlayerPrivate for size change
when loading metadata failed (in this case hasVideo() is false),
we should prevent MediaPlayerPrivate to set width and height
attribute of media element, otherwise we won't get the correct
dimension for the following media sources.
Internally reviewed by Max Feil.
Test case: media/video-size.html
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::resizeSourceDimensions):
- 9:26 AM Changeset in webkit [129234] by
-
- 6 edits1 add in trunk/LayoutTests
[Qt] REGRESSION: 5 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=90687
Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-21
Reviewed by Luiz Agostini.
When sending null data via POST method in XMLHttpRequest the
expected Content-Type "application/x-www-form-urlencoded",
instead of "application/octet-stream". In fact that was the previously
expected value for Qt, but was changed to conform to Qt 4.8 results.
The cookie test result was updated to follow RFC 6265 behavior, as
already does chromium, gtk, and efl.
- platform/qt-5.0/Skipped:
- platform/qt/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
- platform/qt/http/tests/xmlhttprequest/methods-expected.txt:
- platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt:
- platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt:
- platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt:
- 9:21 AM Changeset in webkit [129233] by
-
- 3 edits2 adds in trunk
REGRESSION (r126763): Incorrect line breaking when both kerning and word spacing are enabled
https://bugs.webkit.org/show_bug.cgi?id=97280
Reviewed by Adele Peterson.
Source/WebCore:
Font::width() never applies word spacing to the first character in the TextRun. The
TextLayout optimization tried to achieve this behavior by not applying word spacing to
any character, which led to this bug.
Test: fast/text/word-space-with-kerning-2.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::TextLayout::TextLayout): Changed to use the given font rather than a version
without word spacing.
(WebCore::TextLayout::width): Added a check if the run starts with a space at a non-zero
offset. If that is the case, then the ComplexTextController has added word spacing to that
space, so subtract it here in order to maintain the behavior described above.
LayoutTests:
- fast/text/word-space-with-kerning-2-expected.html: Added.
- fast/text/word-space-with-kerning-2.html: Added.
- 9:14 AM Changeset in webkit [129232] by
-
- 2 edits in trunk/Tools
[WTR] Memory leaks in InjectedBundleController::initialize()
https://bugs.webkit.org/show_bug.cgi?id=97329
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-21
Reviewed by Alexey Proskuryakov.
Fix leaks in InjectedBundleController::initialize() by adopting
strings created with WKStringCreateWithUTF8CString().
- TestWebKitAPI/InjectedBundleController.cpp:
(TestWebKitAPI::InjectedBundleController::initialize):
- 9:11 AM Changeset in webkit [129231] by
-
- 2 edits in trunk/Tools
[Qt][WK2] Removed duplicated code from EventSenderProxy::keyDown
https://bugs.webkit.org/show_bug.cgi?id=97235
Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-21
Reviewed by Luiz Agostini.
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::keyDown):
- 8:37 AM Changeset in webkit [129230] by
-
- 3 edits in trunk/LayoutTests
[EFL] Skip flaky tests to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=97340
Unreviewed EFL gardening. Skip flaky tests
in order to make the bots green.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-21
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- 8:33 AM Changeset in webkit [129229] by
-
- 2 edits in trunk/Tools
Add MIPS build slave to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=96713
Patch by Gergely Kis <Gergely Kis> on 2012-09-21
Reviewed by Csaba Osztrogonác.
Added a build slave for MIPS, and enabled a builder for
Qt Linux MIPS32R2 little-endian release build.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 7:59 AM Changeset in webkit [129228] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Wrong seperator for viewport meta in Popup scripts
https://bugs.webkit.org/show_bug.cgi?id=97313
Reviewed by Yong Li.
The valid seperator for viewport meta is ',' instead of ';'.
- WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::PagePopupBlackBerry::generateHTML):
- 7:32 AM Changeset in webkit [129227] by
-
- 9 edits in trunk/Source/WebCore
Unreviewed, rolling out r129219.
http://trac.webkit.org/changeset/129219
https://bugs.webkit.org/show_bug.cgi?id=97338
Presumably broke Apple Mac compilation (Requested by yurys_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-21
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
- inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore):
- inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
- inspector/InspectorCanvasAgent.cpp:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorCanvasInstrumentation.h:
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
- 7:25 AM Changeset in webkit [129226] by
-
- 3 edits in trunk/Tools
[Chromium] Switch back to a fixed fifo path for Android
https://bugs.webkit.org/show_bug.cgi?id=97230
Reviewed by Tony Chang.
Because not all external storage cards will be formated using a file
system that supports named pipes, Chromium has been changed to creating
the pipes in a temporary folder on the internal storage. Adapt this in
WebKit so we can continue to run layout tests.
This also includes an *unreviewed* fix for a breakage in the webkitpy
tests I made in r129221. Two lines and related to this code, so I decided
to include it in this change.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._update_version):
- 7:11 AM Changeset in webkit [129225] by
-
- 4 edits5 adds in trunk/Source
[chromium] Add test for ScrollingCoordinatorChromium
https://bugs.webkit.org/show_bug.cgi?id=96657
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-09-21
Reviewed by James Robinson.
Add tests for ScrollingCoordinatorChromium. These tests mainly verify that
fast (non-main thread) scrolling is enabled when necessary and that a proper
compositing layer structure is created for fixed position and accelerated
scrolling layers.
Tests: ScrollingCoordinatorChromiumTest.fastScrollingByDefault
ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition
ScrollingCoordinatorChromiumTest.nonFastScrollableRegion
ScrollingCoordinatorChromiumTest.wheelEventHandler
ScrollingCoordinatorChromiumTest.touchOverflowScrolling
- WebKit.gypi:
- tests/ScrollingCoordinatorChromiumTest.cpp: Added.
(WebKit):
(MockWebViewClient):
(ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::createCompositedWebViewImpl):
(WebKit::ScrollingCoordinatorChromiumTest::registerMockedHttpURLLoad):
(WebKit::ScrollingCoordinatorChromiumTest::getRootScrollLayer):
(WebKit::TEST_F):
- tests/data/fixed_position.html: Added.
- tests/data/non_fast_scrollable.html: Added.
- tests/data/touch_overflow_scrolling.html: Added.
- tests/data/wheel_event_handler.html: Added.
- 7:05 AM Changeset in webkit [129224] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Skip a test because layoutTestController.setBackingScaleFactor() is missing
on Qt. This test timeouts at the moment, which considerably increase the testing time.
- platform/qt/Skipped:
- 6:51 AM Changeset in webkit [129223] by
-
- 6 edits in trunk/Source/WebKit2
[GTK] Add WebKitWebView:is-loading property to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=97330
Reviewed by Xan Lopez.
WebKitWebView:is-loading property allows to monitor when the view
is loading something without having to deal with load-changed
signal and all the details of the load status. This also allows to
know when a new load is started before it goes to STARTED status.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetProperty): Implement getter for is-loading
property.
(webkit_web_view_class_init): Add is-loading property.
(webkitWebViewSetIsLoading): Set whether web view is loading a
page and emit notify signal if the is-loading property has
changed. Also update the active URI when a new load operation has
started.
(webkitWebViewEmitLoadChanged): Set is-loading to FALSE when load
finishes.
(webkitWebViewLoadFailed): Set is-loading to FALSE when load fails.
(webkit_web_view_load_uri): Set is-loading to TRUE.
(webkit_web_view_load_html): Ditto.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_load_plain_text): Ditto.
(webkit_web_view_load_request): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_is_loading): Return whether the view is loading a
page.
(webkit_web_view_go_back): Set is-loading to TRUE.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
- UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(loadChangedCallback):
(loadFailedCallback):
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
(testWebViewIsLoading):
(beforeAll):
- 6:38 AM Changeset in webkit [129222] by
-
- 11 edits2 deletes in trunk/Source/WebKit
[BlackBerry] Remove obsolete compositing surface code
https://bugs.webkit.org/show_bug.cgi?id=97314
Reviewed by Antonio Gomes.
Source/WebKit:
Remove compositing surface code from build system.
PR 208038.
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
The removed code allowed rendering of sublayers to a separate offscreen
surface.
Now that we composite root layer and all sublayers to the window
surface, this code is not needed anymore. In addition, we save some
memory by not allocating the unused offscreen surface.
PR 208038.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
- Api/BackingStore_p.h:
(BackingStorePrivate):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
(BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebKitSupport/BackingStoreCompositingSurface.cpp: Removed.
- WebKitSupport/BackingStoreCompositingSurface.h: Removed.
- WebKitSupport/GLES2Context.cpp:
(BlackBerry::WebKit::GLES2Context::buffer):
(BlackBerry::WebKit::GLES2Context::surfaceSize):
(BlackBerry::WebKit::GLES2Context::swapBuffers):
- WebKitSupport/GLES2Context.h:
(GLES2Context):
- WebKitSupport/SurfacePool.cpp:
(WebKit):
(BlackBerry::WebKit::SurfacePool::SurfacePool):
(BlackBerry::WebKit::SurfacePool::initialize):
- WebKitSupport/SurfacePool.h:
(SurfacePool):
- 6:36 AM Changeset in webkit [129221] by
-
- 8 edits2 deletes in trunk
Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
https://bugs.webkit.org/show_bug.cgi?id=97227
Reviewed by Tony Chang.
Source/WebKit/chromium:
Remove all fifo-related code together with the io_stream_forwarder_android
target defined in WebKitUnitTests.gyp.
- WebKitUnitTests.gyp:
- tests/ForwardIOStreamsAndroid.cpp: Removed.
- tests/ForwardIOStreamsAndroid.h: Removed.
- tests/RunAllTests.cpp:
(main):
Tools:
We switched Chromium to using FIFOs in order to achieve better consistency,
which was done by Marcus in r157541. Remove all custom WebKit code in
favor of Chromium's implementation.
Remove more FIFO code in the test runner itself, including the code in
DumpRenderTree that invoked it. We can now switch to Chromium's brand
new FIFO-creating code, which is being set-up for all test targets build
for Android, including DumpRenderTree, TestWebKitAPI and webkit_unit_tests.
This also changes the ChromiumAndroidDriver._remove_all_pipes method to
delete the files individually. "rm" would fail if one of the earlier files
does not exist, and the "-f" argument doesn't seem to be reliable.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/chromium/TestShellAndroid.cpp:
(platformInit):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._get_external_storage):
(ChromiumAndroidDriver._drt_cmd_line):
(ChromiumAndroidDriver._remove_all_pipes):
(ChromiumAndroidDriver.stop):
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
- 6:16 AM Changeset in webkit [129220] by
-
- 10 edits in trunk
[WK2][WKTR] EventSender needs to implement scheduleAsynchronousClick
https://bugs.webkit.org/show_bug.cgi?id=97326
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.
Tools:
Implement scheduleAsynchronousClick() in WebKitTestRunner's
EventSender by sending a "MouseDown" and a "MouseUp" message
asynchronously to the WebProcess.
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::createMouseMessageBody):
(WTR):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::scheduleAsynchronousClick):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
(EventSendingController):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle):
LayoutTests:
Unskip fast/events/popup-blocking-click-in-iframe.html for
WebKit2 now that WKTR's EventSender implements
scheduleAsynchronousClick.
- platform/efl-wk2/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/mac-wk2/Skipped:
- platform/qt-5.0-wk2/Skipped:
- 5:52 AM Changeset in webkit [129219] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++ code
https://bugs.webkit.org/show_bug.cgi?id=97203
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-21
Reviewed by Yury Semikhatsky.
Implements wrapping a 2D canvas context through the injected canvas module script facility.
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
- inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::wrapCanvas2DContext):
(WebCore):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::callWrapContextFunction):
- inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):
- inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
- inspector/InspectorCanvasInstrumentation.h:
(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
- 5:49 AM Changeset in webkit [129218] by
-
- 10 edits in trunk
Web Inspector: [refactoring] simplify interface to FileOutputStream
https://bugs.webkit.org/show_bug.cgi?id=97226
Reviewed by Yury Semikhatsky.
Source/WebCore:
- change OutputStream interface to match that of stream;
- fix OutputStream implementations (FileOutputStream and those in heap profiler);
- fix usages in Timeline and HeapProfiler.
- inspector/front-end/FileUtils.js:
(WebInspector.OutputStream.prototype.write):
(WebInspector.OutputStream.prototype.close):
(WebInspector.ChunkedFileReader.prototype.start):
(WebInspector.ChunkedFileReader.prototype._onChunkLoaded):
(WebInspector.ChunkedXHRReader.prototype.start):
(WebInspector.ChunkedXHRReader.prototype._onProgress):
(WebInspector.ChunkedXHRReader.prototype._onLoad):
(WebInspector.FileOutputStream):
(WebInspector.FileOutputStream.prototype.open.callbackWrapper):
(WebInspector.FileOutputStream.prototype.open):
(WebInspector.FileOutputStream.prototype.write):
(WebInspector.FileOutputStream.prototype.close):
(WebInspector.FileOutputStream.prototype._onAppendDone):
- inspector/front-end/HeapSnapshotLoader.js:
(WebInspector.HeapSnapshotLoader.prototype.close):
(WebInspector.HeapSnapshotLoader.prototype.write):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotLoaderProxy.prototype.startTransfer):
(WebInspector.HeapSnapshotLoaderProxy.prototype.write):
(WebInspector.HeapSnapshotLoaderProxy.prototype.close):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
(WebInspector.HeapProfileHeader.prototype.dispose):
(WebInspector.HeapProfileHeader.prototype.transferChunk.callback):
(WebInspector.HeapProfileHeader.prototype.transferChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.saveToFile.onOpen):
(WebInspector.HeapProfileHeader.prototype.saveToFile):
- inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype._createFileWriter):
(WebInspector.TimelineModel.prototype.saveToFile.callback):
(WebInspector.TimelineModel.prototype.saveToFile):
(WebInspector.TimelineModelLoader):
(WebInspector.TimelineModelLoader.prototype.write):
(WebInspector.TimelineModelLoader.prototype.close):
(WebInspector.TimelineSaver):
(WebInspector.TimelineSaver.prototype.save):
(WebInspector.TimelineSaver.prototype._writeNextChunk):
LayoutTests:
- adjust tests to new FileOutputStream interface;
- inspector/profiler/heap-snapshot-loader.html:
- inspector/timeline/timeline-load.html:
- inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.start):
(initialize_Timeline.InspectorTest.StringOutputStream):
(initialize_Timeline.InspectorTest.StringOutputStream.prototype.write):
(initialize_Timeline.InspectorTest.StringOutputStream.prototype.close):
(initialize_Timeline):
- 5:49 AM Changeset in webkit [129217] by
-
- 4 edits in trunk
[Qt] Error out early if we don't have ICU available
Reviewed by Tor Arne Vestbø.
Source/WTF:
- WTF.pri:
Tools:
- qmake/mkspecs/features/configure.prf:
- 5:16 AM Changeset in webkit [129216] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 5:08 AM Changeset in webkit [129215] by
-
- 10 edits2 adds in trunk
-webkit-clip-path is applied on elements that are not descendant of the container
https://bugs.webkit.org/show_bug.cgi?id=97217
Reviewed by Dirk Schulze.
Source/WebCore:
The clip-path was set on the GraphicsContext, but was never restored, thus making all the layers
rendered in the same "group" of save/restore state use the same clip-path.
Test: css3/masking/clip-path-restore.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
clip-path property should create a stacking-context, otherwise the RenderLayers will not be nested,
meaning that the clip-path of the parent is not going to apply correctly.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
LayoutTests:
Added a test to check that the clip-path is removed from the GraphicsContext in the second paint call.
clip-path-circle-relative-overflow had incorrect result before, so I've udpated the results on Mac
and added test expectations for the others.
- css3/masking/clip-path-restore-expected.html: Added.
- css3/masking/clip-path-restore.html: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.png:
- platform/qt/TestExpectations:
- platform/win/Skipped:
- 5:05 AM Changeset in webkit [129214] by
-
- 4 edits in trunk
[Qt] Bail out when trying to build WebKit with Qt != 5
Reviewed by Tor Arne Vestbø.
Moved check for Qt version out of default_pre into top-level WebKit.pro,
because we never reach default_pre.prf due to the lack of .qmake.conf support
in older versions of Qt/QMake.
.:
- WebKit.pro:
Tools:
- qmake/mkspecs/features/default_pre.prf:
- 5:00 AM Changeset in webkit [129213] by
-
- 6 edits in trunk
WebKitTestRunner needs to print frame load delegate information
https://bugs.webkit.org/show_bug.cgi?id=42705
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.
Tools:
Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
LayoutTests:
Unskipped corresponding test cases from wk2/Skipped, put those which still fail to an appropriate
group in wk2/Skipped.
Moved couple of http/tests/loading tests from platform/efl-wk1/TestExpectations to
platform/efl/TestExpectations as they actually fail for both WK1 EFL and WK2 EFL.
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- platform/wk2/Skipped:
- 4:35 AM Changeset in webkit [129212] by
-
- 9 edits in trunk
[EFL] EventSender should mimic CTRL+o emacs shortcut
https://bugs.webkit.org/show_bug.cgi?id=97224
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit/efl:
Fix bad use of temporary object causing wrong editing
callback dumping.
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::shouldInsertText):
Tools:
Add support for mimicking CTRL+o emacs shortcut in EFL's
EventSender in DumpRenderTree and WebKitTestRunner.
- DumpRenderTree/efl/EventSender.cpp:
(sendKeyDown):
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::keyDown):
LayoutTests:
Rebaseline editing/input/emacs-ctrl-o.html test now
that EFL's EventSender supports mimicking CTRL+o
emacs keyboard shortcut and unskip the test for
EFL WK2 now that the output matches the one for
EFL WK1.
- platform/efl-wk2/TestExpectations:
- platform/efl/editing/input/emacs-ctrl-o-expected.png:
- platform/efl/editing/input/emacs-ctrl-o-expected.txt:
- 3:43 AM BadContent edited by
- add one more spammer (diff)
- 3:31 AM Changeset in webkit [129211] by
-
- 4 edits in trunk/LayoutTests
[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=97317
Unreviewed EFL gardening.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-21
- platform/efl/TestExpectations:
- platform/efl/fast/text/atsui-rtl-override-selection-expected.png:
- platform/efl/fast/text/atsui-rtl-override-selection-expected.txt:
- 3:23 AM Changeset in webkit [129210] by
-
- 3 edits in trunk/Tools
[Qt] Re-fix clean builds
Reviewed by Tor Arne Vestbø.
Re-introduce the sanitization for LIBS when creating a module to use
LIBS_PRIVATE and otherwise do _not_ use LIBS_PRIVATE. We decided to
continue to use QT, LIBS and PKGCONFIG instead of their _PRIVATE variants
throughout the code base, so just using LIBS_PRIVATE in linkAgainstLibrary()
causes build issues when depending system libraries end up in LIBS before
LIBS_PRIVATE.
- qmake/mkspecs/features/default_post.prf:
- qmake/mkspecs/features/functions.prf:
- 3:17 AM Changeset in webkit [129209] by
-
- 3 edits24 adds in trunk/LayoutTests
[EFL] Move frame flattening tests to WK1 specific TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97315
Unreviewed EFL gardening.
Generate baselines for frame flattening tests using WK2 since the tests
are passing with it, and move the tests to WebKit1-specific
TestExpectations.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-21
- platform/efl-wk1/TestExpectations:
- platform/efl/Skipped:
- platform/efl/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
- platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
- platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.
- 3:13 AM Changeset in webkit [129208] by
-
- 6 edits in trunk/Source/WebCore
Remove unused functions of LocalizedDate.h
https://bugs.webkit.org/show_bug.cgi?id=97311
Reviewed by Kentaro Hara.
WebCore::localizedTimeFormatText, WebCore::localizedShortTimeFormatText,
and WebCore::timeAMPMLabels are not used any more because we switched to
the corresponding functions of Localizer.
No new tests because of no behavior changes.
- platform/text/Localizer.h:
(Localizer): Moved comments from LocalizedDate.h.
- platform/text/LocalizedDate.h:
(WebCore): Removed localizedTimeFormatText,
localizedShortTimeFormatText, and timeAMPMLabels.
- platform/text/LocalizedDateICU.cpp:
(WebCore): ditto.
- platform/text/LocalizedDateWin.cpp:
(WebCore): ditto.
- platform/text/mac/LocalizedDateMac.cpp:
(WebCore): ditto.
- 3:08 AM Changeset in webkit [129207] by
-
- 5 edits in trunk/Source
Add datalist suggestions into DateTimeChooserParameters
https://bugs.webkit.org/show_bug.cgi?id=97292
Reviewed by Kent Tamura.
Source/WebCore:
We read datalist suggestions, add them to DateTimeChooserParameters,
and pass them to the page popup.
No new tests. No behavior change yet.
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::openPopup): Read datalist suggestions and add them to DateTimeChooserParameters
- platform/DateTimeChooser.h:
(DateTimeChooserParameters): Added localizedSuggestionValues so we can show localized values inside the page popup.
Source/WebKit/chromium:
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Add the necessary parameters for SuggestionPicker.
- 3:06 AM Changeset in webkit [129206] by
-
- 4 edits in trunk/Source/WebCore
[Forms] DateTimeEditElement::layout() should take date time format as a parameter
https://bugs.webkit.org/show_bug.cgi?id=97300
Reviewed by Kent Tamura.
This patch introduces DateTimeEditElement::LayoutParameters struct for
passing four parameters to DateTimeEditElement::layout() for passing
date time format from client of DateTimeEditElement instead of
DateTimeEditElement::layout() takes time or short time format.
This patch is a part of preparation of introducing multiple fields
date/datetime/month/week input UI.
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
No new tests. This patch doesn't change behavior.
- html/TimeInputType.cpp:
(WebCore::TimeInputType::updateInnerTextValue): Changed to use LayoutParmeters.
- html/shadow/DateTimeEditElement.cpp: Removed unused include files, LocalizedDate.h and LocalizedNumber.h.
(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Changed parameters to LayoutParmeters.
(WebCore::DateTimeEditElement::LayoutParameters::shouldHaveSecondField): Moved from DateTimeEditBuilder::needSecondField().
(WebCore::DateTimeEditElement::layout): Changed to take LayoutParameters.
(WebCore::DateTimeEditElement::setValueAsDate): ditto
(WebCore::DateTimeEditElement::setEmptyValue): ditto
- html/shadow/DateTimeEditElement.h: Removed unused classe declarations DateComponents and DateTimeEditLayouter.
(LayoutParameters): Added to bundle parameters for layout().
(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters): Added.
- 2:44 AM Changeset in webkit [129205] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: render grid scale to the right / at bottom in case box is close to 0 on that axis.
https://bugs.webkit.org/show_bug.cgi?id=97219
Reviewed by Vsevolod Vlasov.
Otherwise, it is hard to inspect objects close to (0, 0)
- inspector/InspectorOverlayPage.html:
- 2:22 AM Changeset in webkit [129204] by
-
- 9 edits in trunk/Source/WebCore
Unreviewed, rolling out r129086.
http://trac.webkit.org/changeset/129086
https://bugs.webkit.org/show_bug.cgi?id=97312
Broke input rendering (Requested by shinyak on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-21
- html/BaseButtonInputType.cpp:
(WebCore):
- html/BaseButtonInputType.h:
(WebCore::BaseButtonInputType::BaseButtonInputType):
(BaseButtonInputType):
- html/FileInputType.cpp:
(WebCore::UploadButtonElement::create):
(WebCore::UploadButtonElement::createForMultiple):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
- html/InputType.cpp:
- html/InputType.h:
(InputType):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::styleDidChange):
(WebCore::RenderButton::updateFromElement):
(WebCore):
(WebCore::RenderButton::setText):
(WebCore::RenderButton::text):
- rendering/RenderButton.h:
(RenderButton):
- 2:16 AM Changeset in webkit [129203] by
-
- 2 edits in trunk/Source/WebCore
Remove useless class prototypes from Vibration.h
https://bugs.webkit.org/show_bug.cgi?id=97304
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-09-21
Reviewed by Kentaro Hara.
Remove two useless class prototype statements in the Vibration.h
- Modules/vibration/Vibration.h:
- 1:01 AM Changeset in webkit [129202] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Changed fast/text/international/hebrew-selection.html expectation
from Failure to ImageOnlyFailure to match the actual results.
- platform/chromium/TestExpectations:
- 12:58 AM Changeset in webkit [129201] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add MIPS or32 function
https://bugs.webkit.org/show_bug.cgi?id=97157
Patch by Chao-ying Fu <fu@mips.com> on 2012-09-21
Reviewed by Gavin Barraclough.
Add a missing or32 function.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::or32): New function.
(MacroAssemblerMIPS):
- 12:45 AM Changeset in webkit [129200] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Mark accessibility/loading-iframe-updates-axtree.html as crashing
intermittently on Linux in addition to Win and Mac.
- platform/chromium/TestExpectations:
- 12:31 AM Changeset in webkit [129199] by
-
- 39 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining MathML tests after r129146.
- platform/gtk/mathml/presentation/attributes-expected.png:
- platform/gtk/mathml/presentation/attributes-expected.txt:
- platform/gtk/mathml/presentation/fenced-expected.png:
- platform/gtk/mathml/presentation/fenced-expected.txt:
- platform/gtk/mathml/presentation/fenced-mi-expected.png:
- platform/gtk/mathml/presentation/fenced-mi-expected.txt:
- platform/gtk/mathml/presentation/fractions-expected.png:
- platform/gtk/mathml/presentation/fractions-expected.txt:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/gtk/mathml/presentation/mo-expected.png:
- platform/gtk/mathml/presentation/mo-expected.txt:
- platform/gtk/mathml/presentation/mo-stretch-expected.png:
- platform/gtk/mathml/presentation/mo-stretch-expected.txt:
- platform/gtk/mathml/presentation/mroot-pref-width-expected.png:
- platform/gtk/mathml/presentation/mroot-pref-width-expected.txt:
- platform/gtk/mathml/presentation/over-expected.png:
- platform/gtk/mathml/presentation/over-expected.txt:
- platform/gtk/mathml/presentation/roots-expected.png:
- platform/gtk/mathml/presentation/roots-expected.txt:
- platform/gtk/mathml/presentation/row-alignment-expected.png:
- platform/gtk/mathml/presentation/row-alignment-expected.txt:
- platform/gtk/mathml/presentation/row-expected.png:
- platform/gtk/mathml/presentation/row-expected.txt:
- platform/gtk/mathml/presentation/style-expected.png:
- platform/gtk/mathml/presentation/style-expected.txt:
- platform/gtk/mathml/presentation/sub-expected.txt:
- platform/gtk/mathml/presentation/subsup-expected.png:
- platform/gtk/mathml/presentation/subsup-expected.txt:
- platform/gtk/mathml/presentation/sup-expected.png:
- platform/gtk/mathml/presentation/sup-expected.txt:
- platform/gtk/mathml/presentation/tokenElements-expected.png:
- platform/gtk/mathml/presentation/tokenElements-expected.txt:
- platform/gtk/mathml/presentation/under-expected.txt:
- platform/gtk/mathml/presentation/underover-expected.png:
- platform/gtk/mathml/presentation/underover-expected.txt:
- platform/gtk/mathml/xHeight-expected.png:
- platform/gtk/mathml/xHeight-expected.txt:
- 12:02 AM Changeset in webkit [129198] by
-
- 4 edits in trunk/Source/WebCore
Prepare CalendarPicker so we can add another picker, SuggetionPicker
https://bugs.webkit.org/show_bug.cgi?id=97193
Reviewed by Kent Tamura.
Preparation so we can add another picker to CalendarPicker and switch
between them.
No new tests. No behavior change.
- Resources/pagepopups/calendarPicker.css:
(.calendar-picker): Added so we can apply these styles just to calendar picker.
- Resources/pagepopups/calendarPicker.js:
(CalendarPicker.validateConfig): Renamed so each picker can validate the config object.
(initialize):
(closePicker): Call Picker.cleanup().
(openCalendarPicker):
(CalendarPicker):
(CalendarPicker.prototype.cleanup): Cleanup event listener on document.body.
- Resources/pagepopups/pickerCommon.js:
(Picker.prototype.cleanup):
Sep 20, 2012:
- 11:32 PM Changeset in webkit [129197] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectation update.
- platform/chromium/TestExpectations: Assigned new bug entry for
fast/text/international/hebrew-selection.html
- 11:23 PM Changeset in webkit [129196] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Add API to feed touch event.
https://bugs.webkit.org/show_bug.cgi?id=96903
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.
The applications will use this API to feed touch event to the view
when they want to generate touch event from their own event processor.
WTR also will use this API to generate touch event with multiple touch
points for passing test cases of touch event in the WebKit2/EFL.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_feed_touch_event):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 11:20 PM Changeset in webkit [129195] by
-
- 42 edits1 copy11 adds in trunk
Text Autosizing: Cluster text at flow roots, for consistency and to avoid autosizing headers/footers.
https://bugs.webkit.org/show_bug.cgi?id=97025
Patch by John Mellor <johnme@chromium.org> on 2012-09-20
Reviewed by Julien Chaffraix.
Source/WebCore:
This patch has 3 main changes:
- All text within a "cluster" (roughly equivalent to a CSS flow root / block formatting context) must have a uniform textAutosizingMultiplier, except for subtrees which are themselves clusters. This improves the consistency of the final output, since sibling blocks are now more likely to have the same multiplier (hence grow in proportion).
- Clusters must contain a minimum amount of text in order to be autosized (4 lines of text, assuming each char is 1em wide, so about 2 lines of text in practice). This is to reduce the likelihood of autosizing things like headers and footers, which can be quite visually distracting. The rationale is that if a cluster contains very few lines of text then it's ok to have to zoom in and pan from side to side to read each line, since if there are very few lines of text you'll only need to pan across once or twice.
- To avoid adding a 3rd tree traversal, processSubtree/processBox were refactored such that all of Text Autosizing now happens as a single tree traversal (hence halving the number of tree traversals done).
Tests: fast/text-autosizing/cluster-narrow-in-wide.html
fast/text-autosizing/cluster-wide-in-narrow.html
fast/text-autosizing/clusters-insufficient-text.html
fast/text-autosizing/clusters-insufficient-width.html
fast/text-autosizing/clusters-sufficient-text-except-in-root.html
fast/text-autosizing/clusters-sufficient-width.html
- rendering/TextAutosizer.cpp:
(TextAutosizingWindowInfo):
Added this struct to bundle together the various sizes that
processSubtree needs to pass to every recursive call to
processCluster and processContainer.
(WebCore::TextAutosizer::processSubtree):
- Bundle windowSize and minLayoutSize together as a single struct, TextAutosizingWindowInfo, rather than passing them separately.
- Walk up the tree to find the current cluster and container, rather than (incorrectly) assuming that the layoutRoot is always a container.
- Call processCluster instead of traversing the tree.
(WebCore::TextAutosizer::processCluster):
Calculates the multiplier based on the width of the cluster (moved
the calculation here from processBox, since now the multiplier is
fixed per cluster), and delegates to processContainer for the actual
tree traversal (since clusters are also containers).
(WebCore::contentHeightIsConstrained):
Changed parameter to RenderBlock.
(WebCore::TextAutosizer::processContainer):
This now takes care of the whole tree traversal, recursively calling
processCluster/processContainer when it encounters such an object,
and setMultiplier on RenderText objects (as processBox used to).
Also added a check that the RenderText's multiplier is not already
equal to the target multiplier (to save needlessly setting it).
(WebCore::TextAutosizer::isContainer):
- Changed to be a positive (is) instead of negative (isNot) check.
- Require objects to be RenderBlocks so it's easier to find them using containingBlock, and there don't seem to be many interesting RenderBoxes that aren't RenderBlocks.
(WebCore::TextAutosizer::isAutosizingCluster):
A container that is also a flow root / block formatting context
(approximately), hence demarcates an independent region of the page,
within which we want consistent autosizing.
(WebCore::TextAutosizer::clusterShouldBeAutosized):
Uses measureDescendantTextWidth and to check whether the cluster
contains enough text to be worth autosizing.
(WebCore::TextAutosizer::measureDescendantTextWidth):
Recursively traverse the cluster, skipping constrained height
containers as processContainer does, to measure how much autosizable
text it contains. Early out as soon as the minimum text width is
reached.
(WebCore::TextAutosizer::nextInPreOrderSkippingDescendantsOfContainers):
Replaces nextInPreOrderMatchingFilter. The filter is now fixed to
isContainer (we no longer need an isAutosizingCluster filter, since
I consolidated the tree traversal), and filtered objects are
actually returned (so they can in turn be recursively traversed),
it's just their descendants that get skipped.
- rendering/TextAutosizer.h:
(TextAutosizer):
- Deleted RenderObjectFilterFunctor, since the filter of nextInPreOrderSkippingDescendantsOfContainers is now fixed.
LayoutTests:
Added 6 tests (cluster*.html). Updated various other tests to have
enough text so that they continue to pass, or that if they fail, it's
for the reason that was being tested, not just because clustering
decided they had insufficient text.
- fast/text-autosizing/cluster-narrow-in-wide-expected.html: Added.
- fast/text-autosizing/cluster-narrow-in-wide.html: Copied from LayoutTests/fast/text-autosizing/em-margin-border-padding.html.
- fast/text-autosizing/cluster-wide-in-narrow-expected.html: Added.
- fast/text-autosizing/cluster-wide-in-narrow.html: Added.
- fast/text-autosizing/clusters-insufficient-text-expected.html: Added.
- fast/text-autosizing/clusters-insufficient-text.html: Added.
- fast/text-autosizing/clusters-insufficient-width-expected.html: Added.
- fast/text-autosizing/clusters-insufficient-width.html: Added.
- fast/text-autosizing/clusters-sufficient-text-except-in-root-expected.html: Added.
- fast/text-autosizing/clusters-sufficient-text-except-in-root.html: Added.
- fast/text-autosizing/clusters-sufficient-width-expected.html: Added.
- fast/text-autosizing/clusters-sufficient-width.html: Added.
- fast/text-autosizing/constrained-and-overflow-auto-ancestor-expected.html:
- fast/text-autosizing/constrained-and-overflow-auto-ancestor.html:
- fast/text-autosizing/constrained-and-overflow-hidden-ancestor-expected.html:
- fast/text-autosizing/constrained-and-overflow-hidden-ancestor.html:
- fast/text-autosizing/constrained-and-overflow-paged-x-ancestor-expected.html:
- fast/text-autosizing/constrained-and-overflow-paged-x-ancestor.html:
- fast/text-autosizing/constrained-and-overflow-scroll-ancestor-expected.html:
- fast/text-autosizing/constrained-and-overflow-scroll-ancestor.html:
- fast/text-autosizing/constrained-height-ancestor-expected.html:
- fast/text-autosizing/constrained-height-ancestor.html:
- fast/text-autosizing/constrained-maxheight-ancestor-expected.html:
- fast/text-autosizing/constrained-maxheight-ancestor.html:
- fast/text-autosizing/constrained-maxheight-expected.html:
- fast/text-autosizing/constrained-maxheight.html:
- fast/text-autosizing/constrained-percent-maxheight-expected.html:
- fast/text-autosizing/constrained-percent-maxheight.html:
- fast/text-autosizing/constrained-percent-of-viewport-maxheight-expected.html:
- fast/text-autosizing/constrained-percent-of-viewport-maxheight.html:
- fast/text-autosizing/constrained-then-overflow-ancestors-expected.html:
- fast/text-autosizing/constrained-then-overflow-ancestors.html:
- fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors-expected.html:
- fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors.html:
- fast/text-autosizing/constrained-then-position-absolute-ancestors-expected.html:
- fast/text-autosizing/constrained-then-position-absolute-ancestors.html:
- fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
- fast/text-autosizing/constrained-then-position-fixed-ancestors.html:
- fast/text-autosizing/constrained-within-overflow-ancestor-expected.html:
- fast/text-autosizing/constrained-within-overflow-ancestor.html:
- fast/text-autosizing/em-margin-border-padding-expected.html:
- fast/text-autosizing/em-margin-border-padding.html:
- fast/text-autosizing/narrow-child-expected.html:
- fast/text-autosizing/narrow-child.html:
- fast/text-autosizing/wide-child-expected.html:
- fast/text-autosizing/wide-child.html:
- fast/text-autosizing/wide-iframe-expected.html:
- fast/text-autosizing/wide-iframe.html:
- 11:16 PM Changeset in webkit [129194] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Mark fast/text/international/hebrew-selection.html as failing
on Windows in addition to Linux. The test was introduced in r129175 and
marked as failing on Linux from the very beginning.
- platform/chromium/TestExpectations:
- 11:14 PM Changeset in webkit [129193] by
-
- 35 edits in trunk/LayoutTests
[EFL] Several MathML tests need rebaseline after r129146
https://bugs.webkit.org/show_bug.cgi?id=97293
Unreviewed EFL gardening.
Rebaseline several MathML tests due to r129146.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-20
- platform/efl/mathml/presentation/attributes-expected.png:
- platform/efl/mathml/presentation/attributes-expected.txt:
- platform/efl/mathml/presentation/fenced-expected.png:
- platform/efl/mathml/presentation/fenced-expected.txt:
- platform/efl/mathml/presentation/fenced-mi-expected.png:
- platform/efl/mathml/presentation/fenced-mi-expected.txt:
- platform/efl/mathml/presentation/fractions-expected.png:
- platform/efl/mathml/presentation/fractions-expected.txt:
- platform/efl/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/efl/mathml/presentation/mo-stretch-expected.png:
- platform/efl/mathml/presentation/mo-stretch-expected.txt:
- platform/efl/mathml/presentation/mroot-pref-width-expected.png:
- platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
- platform/efl/mathml/presentation/roots-expected.png:
- platform/efl/mathml/presentation/roots-expected.txt:
- platform/efl/mathml/presentation/row-alignment-expected.png:
- platform/efl/mathml/presentation/row-alignment-expected.txt:
- platform/efl/mathml/presentation/style-expected.png:
- platform/efl/mathml/presentation/style-expected.txt:
- platform/efl/mathml/presentation/sub-expected.png:
- platform/efl/mathml/presentation/sub-expected.txt:
- platform/efl/mathml/presentation/subsup-expected.png:
- platform/efl/mathml/presentation/subsup-expected.txt:
- platform/efl/mathml/presentation/sup-expected.png:
- platform/efl/mathml/presentation/sup-expected.txt:
- platform/efl/mathml/presentation/tokenElements-expected.png:
- platform/efl/mathml/presentation/tokenElements-expected.txt:
- platform/efl/mathml/presentation/under-expected.png:
- platform/efl/mathml/presentation/under-expected.txt:
- platform/efl/mathml/presentation/underover-expected.png:
- platform/efl/mathml/presentation/underover-expected.txt:
- platform/efl/mathml/xHeight-expected.png:
- platform/efl/mathml/xHeight-expected.txt:
- 11:02 PM Changeset in webkit [129192] by
-
- 7 edits in trunk/LayoutTests
Unreviewed. Provided Chromium-specific test expectations after r129176.
- platform/chromium-mac-snowleopard/fast/text/emphasis-expected.png:
- platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.txt:
- platform/chromium-mac/fast/text/emphasis-expected.png:
- platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.png:
- platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.txt:
- 9:44 PM Changeset in webkit [129191] by
-
- 2 edits in trunk/Source/WebCore
[Platform] There are memory leak in LocaleICU
https://bugs.webkit.org/show_bug.cgi?id=97289
Reviewed by Kent Tamura.
This patch adds udt_close() calls for medium time format and short
time format data used in LocaleICU class to avoid memory leak.
This memory leak is found by external tool Valgrind and reported in
Chromium bug repositry(http://crbug.com/151006) with stack trace of
call path of leaked memory.
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
No new tests. External tool such as Valgrind will check this memory leak.
- platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::~LocaleICU): Added to call udt_close() for m_mediumTimeFormat
and m_shortTimeFormat which have UDateFormat objects.
- 9:42 PM Changeset in webkit [129190] by
-
- 2 edits in trunk/Source/WebCore
Chromium mac cannot display AppleColorEmoji
https://bugs.webkit.org/show_bug.cgi?id=97286
Reviewed by Kent Tamura.
Disable AppleColorEmoji for now. We will re-enable it after Skia supports CTFontDrawGlyphs().
No new tests. Fallback fonts should be used for emoji codepoints.
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):
- 9:15 PM Changeset in webkit [129189] by
-
- 4 edits2 adds in trunk
Source/WebCore: Fix use-after free when using a variable to specify a -webkit-filter.
https://bugs.webkit.org/show_bug.cgi?id=97153
Reviewed by Abhishek Arya.
Make StyleResolver's m_pendingSVGDocuments a hashmap of RefPtr instead of raw pointers such that the document values cannot be freed prematurely.
Present assumption is that storing raw pointers is ok because CSSValues will live as long as the StyleResolver instance, however that it no longer
true when variables are used, so we must ensure we increment the reference counter to ensure the CSSValues are not freed prematurely.
Test: fast/css/variables/var-filter.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleResolver.h:
(StyleResolver):
LayoutTests: Fix bug when using a variable to specify a -webkit-filter.
https://bugs.webkit.org/show_bug.cgi?id=97153
Reviewed by Abhishek Arya.
Use a variable in a -webkit-filter css property.
- fast/css/variables/var-filter-expected.txt: Added.
- fast/css/variables/var-filter.html: Added.
- 9:00 PM Changeset in webkit [129188] by
-
- 2 edits in trunk/Tools
Comment out a failing webkitpy unit test until Dirk can fix it.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(SemanticTests.test_skip_and_wontfix):
- 7:58 PM Changeset in webkit [129187] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations edit.
- platform/mac/TestExpectations: Expectations format change.
- 7:38 PM TestExpectations edited by
- clarify the need to actually type the brackets as delimiters on a … (diff)
- 6:38 PM Changeset in webkit [129186] by
-
- 6 edits in trunk/Source/WebCore
Prevent reading stale data from InlineTextBoxes
https://bugs.webkit.org/show_bug.cgi?id=94750
Reviewed by Abhishek Arya.
Text from dirty InlineTextBoxes should never be read or used. This change
enforces this design goal by forcefully zero-ing out the start and length
of InlineTextBoxes when they're being marked dirty. Ideally, we'd also
add asserts to the accessors for this data, but there are still several
places in editing that cause this. https://bugs.webkit.org/show_bug.cgi?id=97264
tracks these cases.
This change involves making markDirty virtual. Running the line-layout
performance test as well as profiling resizing the html5 spec showed
negligable impact with this change.
No new tests as this doesn't change any proper behavior.
- dom/Position.cpp:
(WebCore::Position::downstream): Adding a FIXME.
- rendering/InlineBox.h:
(WebCore::InlineBox::markDirty): Marking virtual to allow InlineTextBox to
overload and zero out its start and length.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::markDirty): Zeroing out the start and length when
we mark the box dirty.
- rendering/InlineTextBox.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset): Adding a FIXME.
- 6:35 PM Changeset in webkit [129185] by
-
- 2 edits in trunk/LayoutTests
Updated Lion-specific results after r129176.
- platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.txt:
- 6:33 PM Changeset in webkit [129184] by
-
- 8 edits in trunk/Tools
make Skip, WontFix be the only expectations on a line
https://bugs.webkit.org/show_bug.cgi?id=97225
Reviewed by Ojan Vafai.
It is now incorrect in the new syntax to have a line like:
foo.html [ WontFix Crash ]
This will generate a lint warning and be treated as an invalid
line. Fixing this caused a whole bunch of unit tests to need updating
to no longer be marked as WontFix :). Also, this patch adjusts
the warnings so that missing Bug() identifiers will cause lint
warnings but will *not* cause the line to be treated as invalid.
Fixing these issues also revealed that test_hung_thread was no
longer testing the right logic, so I adjusted the timeouts in
test.py to make that test work again.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(Worker._run_test_in_another_thread):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_summarized_results_wontfix):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._parse_modifiers):
(TestExpectationParser._tokenize_line_using_new_format):
(TestExpectationLine.is_invalid):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(BasicTests.test_basic):
(test_get_test_set):
(test_parse_warning):
(test_pixel_tests_flag):
(SemanticTests.test_missing_bugid):
(SemanticTests):
(SemanticTests.test_skip_and_wontfix):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.run_test):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_hung_thread):
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_basic):
(PrintExpectationsTest.test_multiple):
(PrintExpectationsTest.test_full):
(PrintExpectationsTest.test_exclude):
(PrintExpectationsTest.test_csv):
- 6:24 PM Changeset in webkit [129183] by
-
- 2 edits in trunk/LayoutTests
[Win] Update test expectation
https://bugs.webkit.org/show_bug.cgi?id=97274
- platform/win/Skipped:
Add fast/forms/number/number-spinbutton-click-in-iframe.html because
Apple Win port doesn't have spin button in testing.
- 6:20 PM Changeset in webkit [129182] by
-
- 4 edits in trunk/Source/WebCore
Measure how often web pages use Worker and SharedWorker
https://bugs.webkit.org/show_bug.cgi?id=97273
Reviewed by Ojan Vafai.
We're not considering removing these features, but it will give us a
baseline idea of how often they're used.
- page/FeatureObserver.h:
- workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
- workers/Worker.cpp:
(WebCore::Worker::create):
- 6:04 PM Changeset in webkit [129181] by
-
- 2 edits in trunk/Tools
Unreviewed. Start running tests on the mac-ews.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):
- 4:52 PM Changeset in webkit [129180] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Unreviewed build fix. webkit_unit_tests have global constructors.
- WebKitUnitTests.gyp: Remove -Wglobal-constructors.
- 4:38 PM Changeset in webkit [129179] by
-
- 9 edits in trunk/Source/JavaScriptCore
CHECK_ARRAY_CONSISTENCY isn't being used or tested, so we should remove it
https://bugs.webkit.org/show_bug.cgi?id=97260
Rubber stamped by Geoffrey Garen.
Supporting it will become difficult as we add more indexing types. It makes more
sense to kill, especially since we don't appear to use it or test it, ever.
- runtime/ArrayConventions.h:
(JSC):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSplice):
- runtime/ArrayStorage.h:
(JSC::ArrayStorage::copyHeaderFromDuringGC):
(ArrayStorage):
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncBind):
- runtime/JSArray.cpp:
(JSC::createArrayButterflyInDictionaryIndexingMode):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
- runtime/JSArray.h:
(JSArray):
(JSC::createArrayButterfly):
(JSC::JSArray::tryCreateUninitialized):
(JSC::constructArray):
- runtime/JSObject.cpp:
(JSC::JSObject::putByIndex):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::deletePropertyByIndex):
(JSC):
- runtime/JSObject.h:
(JSC::JSObject::initializeIndex):
(JSObject):
- 4:38 PM Changeset in webkit [129178] by
-
- 7 edits in trunk
[chromium] Enable more clang warnings
https://bugs.webkit.org/show_bug.cgi?id=97257
Reviewed by James Robinson.
Source/WebCore:
Add -Wunused-parameter to WebCore targets. Apple's Mac compile already
warns on this and it's a common source of error for Chromium patches.
No new tests, should compile cleanly.
- WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
- WebKit.gyp: Add -Wglobal-constructors. Don't add -Wunused-parameter because many of our API interfaces have named parameters with empty implementations.
- WebKitUnitTests.gyp: Add -Wglobal-constructors and -Wunused-parameter.
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
there are lots of violations in these files.
- 4:31 PM Changeset in webkit [129177] by
-
- 1 edit in branches/chromium/1229/Source/WebKit/chromium/src/WebFrameImpl.cpp
Merge 128972 - [Chromium] Fix crash in WebFrameImpl::loadHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=96352
Reviewed by Adam Barth.
We have some crash reports with the following stack:
- HistoryItem::shouldDoSameDocumentNavigationTo.
- WebFrameImpl::loadHistoryItem ...
We don't have reproducible steps, and not sure what's the root
cause. Anyway we should check nullness of currentItem because
HistoryController::m_currentItem can be 0.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadHistoryItem):
Check nullness of currentItem.
TBR=tkent@chromium.org
Review URL: https://codereview.chromium.org/10960021
- 4:19 PM Changeset in webkit [129176] by
-
- 11 edits in trunk
Kerning never occurs between a space and the following glyph
https://bugs.webkit.org/show_bug.cgi?id=97269
Reviewed by Tim Horton.
Source/WebCore:
Covered by several existing tests.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Changed to not reset the advance
of a space, and added a comment about how this also needs to be fixed for other characters
that are treated as spaces.
LayoutTests:
- platform/mac/fast/text/emphasis-expected.png:
- platform/mac/fast/text/emphasis-expected.txt:
- platform/mac/fast/text/sticky-typesetting-features-expected.png:
- platform/mac/fast/text/sticky-typesetting-features-expected.txt:
- platform/mac/fast/text/thai-combining-mark-positioning-expected.png:
- platform/mac/fast/text/thai-combining-mark-positioning-expected.txt:
- platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
- platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:
- 4:16 PM Changeset in webkit [129175] by
-
- 5 edits2 adds in trunk
[Chromium] Improve glyph selection of HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=97164
Reviewed by Tony Chang.
Source/WebCore:
Take into account clusters for selection.
Test: fast/text/international/hebrew-selection.html
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult): Removed m_logClusters.
m_logCluster is no longer used.
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
- If targetX is in the left side of the first cluster, return the leftmost character index.
- If targetX is in the right side of the last cluster, return the rightmost character index.
- If targetX is between the right side of the cluster N and the left side of the cluster N+1, then:
- return N+1 for LTR.
- return N for RTL.
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset):
Find the cluster of index in question, then:
- return the left side boundary of the cluster for LTR.
- return the right side boundary of the cluster for RTL.
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(HarfBuzzRun):
LayoutTests:
Added a test for complex text selection.
- fast/text/international/hebrew-selection-expected.html: Added.
- fast/text/international/hebrew-selection.html: Added.
- 4:11 PM Changeset in webkit [129174] by
-
- 4 edits in trunk/Source/WebCore
Replace RenderListBox::updateLogicalHeight with RenderListBox::computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=97263
Reviewed by Ojan Vafai.
This is part of making computeLogicalHeight virtual so with any RenderBox pointer, one
can compute the logical height without mutating the RenderBox.
No new tests, this is a refactor and existing list box tests should pass.
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::layout): Move layout related logic here.
(WebCore::RenderListBox::computeLogicalHeight): Use const version and remove layout related code.
- rendering/RenderListBox.h:
(RenderListBox): Override computeLogicalHeight.
- 3:30 PM Changeset in webkit [129173] by
-
- 4 edits in trunk/Source
Versioning
- 3:24 PM Changeset in webkit [129172] by
-
- 1 copy in tags/Safari-537.11
New Tag.
- 3:00 PM Changeset in webkit [129171] by
-
- 11 edits in trunk/LayoutTests
make Skip, WontFix be the only expectations on a line
https://bugs.webkit.org/show_bug.cgi?id=97225
Unreviewed, expectations change.
This change updates all of the expectations files, but doesn't
actually change the code to issue warnings in this case (that
will come in a subsequent patch).
- platform/chromium-android/TestExpectations:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-4.8/TestExpectations:
- platform/qt-arm/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
- 2:45 PM Changeset in webkit [129170] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix IndexedDB unit tests
https://bugs.webkit.org/show_bug.cgi?id=97149
Reviewed by Tony Chang.
- tests/IDBDatabaseBackendTest.cpp:
Specify a desired version of -1 so that no version change transaction
is run.
- 2:36 PM Changeset in webkit [129169] by
-
- 2 edits in trunk/LayoutTests
[Qt] Remove entries for deleted tests from Skipped list
https://bugs.webkit.org/show_bug.cgi?id=97213
Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-20
Reviewed by Simon Hausmann.
- platform/qt/Skipped:
- 2:25 PM Changeset in webkit [129168] by
-
- 8 edits in trunk
CSP reports should send an empty "blocked-uri" rather than nothing.
https://bugs.webkit.org/show_bug.cgi?id=97256
Patch by Mike West <mkwst@chromium.org> on 2012-09-20
Reviewed by Adam Barth.
Source/WebCore:
In cases where a Content Security Policy violation report is generated
without blocking a resource at a particular URI (inline scripts, for
example), we currently leave the "blocked-uri" attribute out of the
report entirely. For the same reason that we included the "referrer"
attribute in webkit.org/b/97233, we should include an explicitly empty
"blocked-uri" in these cases.
This new behavior is covered by updates to existing test expectations
around the reporting functionality.
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
If the 'blocked-uri' is invalid, add a "blocked-uri" attribute that
is explicitly empty.
LayoutTests:
- http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
Updating test expectations to include an explicitly empty
"blocked-uri" as opposed to leaving it off entirely.
- 2:16 PM Changeset in webkit [129167] by
-
- 2 edits in trunk/Source/WebKit/chromium
roll Chromium to r157829.
Unreviewed, deps change.
- DEPS:
- 2:14 PM Changeset in webkit [129166] by
-
- 2 edits in trunk/Source/WebKit/chromium
2012-09-20 Nate Chapin <Nate Chapin>
Unreviewed, chromium win build fix.
Remove spurious reference to the non-existent
tests/LayerPainterChromium.h in WebKit.gypi.
- WebKit.gypi:
- 2:03 PM Changeset in webkit [129165] by
-
- 8 edits in trunk/Source
Source/WebCore: Add String::numberToFixedPrecisionString()
https://bugs.webkit.org/show_bug.cgi?id=96330
Reviewed by Benjamin Poulain.
- platform/text/TextStream.cpp:
(WebCore::TextStream::operator<<): Use the new function instead of String::number() with flags.
Source/WebKit2: Add String::numberToStringFixedWidth()
https://bugs.webkit.org/show_bug.cgi?id=96330
Reviewed by Benjamin Poulain.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
Source/WTF: Add String::numberToStringFixedWidth()
https://bugs.webkit.org/show_bug.cgi?id=96330
Reviewed by Benjamin Poulain.
Add this new function as replacement for the ShouldRoundDecimalPlaces flag of String::number()
and remove the now unnecessary branch in String::number() for the old flags.
- wtf/text/WTFString.cpp:
(WTF::String::number):
(WTF::String::numberToStringFixedWidth):
- wtf/text/WTFString.h:
- 1:47 PM Changeset in webkit [129164] by
-
- 14 edits in trunk/Source/WebCore
Rename ContainerNode::parserAddChild "parserAppendChild" for consistency
https://bugs.webkit.org/show_bug.cgi?id=97254
Reviewed by Adam Barth.
No functional change, all the below changes are simple renames.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::parserAppendChild):
- dom/ContainerNode.h:
(ContainerNode):
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- editing/markup.cpp:
(WebCore::createFragmentForTransformToFragment):
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::createContainingTable):
(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
(WebCore::HTMLViewSourceDocument::addLine):
(WebCore::HTMLViewSourceDocument::finishLine):
(WebCore::HTMLViewSourceDocument::addText):
(WebCore::HTMLViewSourceDocument::addBase):
(WebCore::HTMLViewSourceDocument::addLink):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::executeTask):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken):
- xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::enterText):
(WebCore::XMLDocumentParser::parseDocumentFragment):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::internalSubset):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseProcessingInstruction):
(WebCore::XMLDocumentParser::parseCdata):
(WebCore::XMLDocumentParser::parseComment):
(WebCore::XMLDocumentParser::parseDtd):
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::processStartTag):
(WebCore::XMLTreeBuilder::add):
- 1:46 PM Changeset in webkit [129163] by
-
- 2 edits in trunk/LayoutTests
media/track/track-cue-rendering-inner-timestamps.html times out.
https://bugs.webkit.org/show_bug.cgi?id=97259
- platform/mac/TestExpectations:
- 1:40 PM Changeset in webkit [129162] by
-
- 1 delete in trunk/Source/WebCore/platform/graphics/chromium/cc
Remove empty directory.
- 1:35 PM Changeset in webkit [129161] by
-
- 2 edits in trunk/PerformanceTests
Results page should show indivisual value
https://bugs.webkit.org/show_bug.cgi?id=97178
Reviewed by Tony Chang.
Show indivisual values instead of statistics (min, max, stdev).
- resources/results-template.html:
- 1:34 PM Changeset in webkit [129160] by
-
- 11 edits297 deletes in trunk/Source
[chromium] Remove unused copy of chromium compositor implementation files
https://bugs.webkit.org/show_bug.cgi?id=97255
Reviewed by Adam Barth.
Source/WebCore:
Now that use_libcc_for_compositor is set to 1 these files aren't used anywhere.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/support/CCThreadImpl.cpp: Removed.
- platform/chromium/support/CCThreadImpl.h: Removed.
- platform/chromium/support/WebCompositorImpl.cpp: Removed.
- platform/chromium/support/WebCompositorImpl.h: Removed.
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp: Removed.
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h: Removed.
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp: Removed.
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h: Removed.
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
- platform/graphics/chromium/CanvasLayerTextureUpdater.cpp: Removed.
- platform/graphics/chromium/CanvasLayerTextureUpdater.h: Removed.
- platform/graphics/chromium/ContentLayerChromium.cpp: Removed.
- platform/graphics/chromium/ContentLayerChromium.h: Removed.
- platform/graphics/chromium/ContentLayerChromiumClient.h: Removed.
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp: Removed.
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h: Removed.
- platform/graphics/chromium/GeometryBinding.cpp: Removed.
- platform/graphics/chromium/GeometryBinding.h: Removed.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
- platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp: Removed.
- platform/graphics/chromium/HeadsUpDisplayLayerChromium.h: Removed.
- platform/graphics/chromium/IOSurfaceLayerChromium.cpp: Removed.
- platform/graphics/chromium/IOSurfaceLayerChromium.h: Removed.
- platform/graphics/chromium/ImageLayerChromium.cpp: Removed.
- platform/graphics/chromium/ImageLayerChromium.h: Removed.
- platform/graphics/chromium/LayerChromium.cpp: Removed.
- platform/graphics/chromium/LayerChromium.h: Removed.
- platform/graphics/chromium/LayerTextureSubImage.cpp: Removed.
- platform/graphics/chromium/LayerTextureSubImage.h: Removed.
- platform/graphics/chromium/LayerTextureUpdater.h: Removed.
- platform/graphics/chromium/PlatformColor.h: Removed.
- platform/graphics/chromium/ProgramBinding.cpp: Removed.
- platform/graphics/chromium/ProgramBinding.h: Removed.
- platform/graphics/chromium/RateLimiter.cpp: Removed.
- platform/graphics/chromium/RateLimiter.h: Removed.
- platform/graphics/chromium/RenderSurfaceChromium.cpp: Removed.
- platform/graphics/chromium/RenderSurfaceChromium.h: Removed.
- platform/graphics/chromium/ScrollbarLayerChromium.cpp: Removed.
- platform/graphics/chromium/ScrollbarLayerChromium.h: Removed.
- platform/graphics/chromium/ShaderChromium.cpp: Removed.
- platform/graphics/chromium/ShaderChromium.h: Removed.
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp: Removed.
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h: Removed.
- platform/graphics/chromium/SolidColorLayerChromium.cpp: Removed.
- platform/graphics/chromium/SolidColorLayerChromium.h: Removed.
- platform/graphics/chromium/TextureCopier.cpp: Removed.
- platform/graphics/chromium/TextureCopier.h: Removed.
- platform/graphics/chromium/TextureLayerChromium.cpp: Removed.
- platform/graphics/chromium/TextureLayerChromium.h: Removed.
- platform/graphics/chromium/TextureLayerChromiumClient.h: Removed.
- platform/graphics/chromium/ThrottledTextureUploader.cpp: Removed.
- platform/graphics/chromium/ThrottledTextureUploader.h: Removed.
- platform/graphics/chromium/TiledLayerChromium.cpp: Removed.
- platform/graphics/chromium/TiledLayerChromium.h: Removed.
- platform/graphics/chromium/TreeSynchronizer.cpp: Removed.
- platform/graphics/chromium/TreeSynchronizer.h: Removed.
- platform/graphics/chromium/UnthrottledTextureUploader.h: Removed.
- platform/graphics/chromium/VideoLayerChromium.cpp: Removed.
- platform/graphics/chromium/VideoLayerChromium.h: Removed.
- platform/graphics/chromium/cc/CCActiveAnimation.cpp: Removed.
- platform/graphics/chromium/cc/CCActiveAnimation.h: Removed.
- platform/graphics/chromium/cc/CCAnimationCurve.cpp: Removed.
- platform/graphics/chromium/cc/CCAnimationCurve.h: Removed.
- platform/graphics/chromium/cc/CCAnimationEvents.h: Removed.
- platform/graphics/chromium/cc/CCAppendQuadsData.h: Removed.
- platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp: Removed.
- platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h: Removed.
- platform/graphics/chromium/cc/CCCompletionEvent.h: Removed.
- platform/graphics/chromium/cc/CCDamageTracker.cpp: Removed.
- platform/graphics/chromium/cc/CCDamageTracker.h: Removed.
- platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp: Removed.
- platform/graphics/chromium/cc/CCDebugBorderDrawQuad.h: Removed.
- platform/graphics/chromium/cc/CCDebugRectHistory.cpp: Removed.
- platform/graphics/chromium/cc/CCDebugRectHistory.h: Removed.
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp: Removed.
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.h: Removed.
- platform/graphics/chromium/cc/CCDirectRenderer.cpp: Removed.
- platform/graphics/chromium/cc/CCDirectRenderer.h: Removed.
- platform/graphics/chromium/cc/CCDrawQuad.cpp: Removed.
- platform/graphics/chromium/cc/CCDrawQuad.h: Removed.
- platform/graphics/chromium/cc/CCFontAtlas.cpp: Removed.
- platform/graphics/chromium/cc/CCFontAtlas.h: Removed.
- platform/graphics/chromium/cc/CCFrameRateController.cpp: Removed.
- platform/graphics/chromium/cc/CCFrameRateController.h: Removed.
- platform/graphics/chromium/cc/CCFrameRateCounter.cpp: Removed.
- platform/graphics/chromium/cc/CCFrameRateCounter.h: Removed.
- platform/graphics/chromium/cc/CCGraphicsContext.h: Removed.
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp: Removed.
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h: Removed.
- platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.cpp: Removed.
- platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.h: Removed.
- platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp: Removed.
- platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.h: Removed.
- platform/graphics/chromium/cc/CCInputHandler.h: Removed.
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp: Removed.
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h: Removed.
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerAnimationController.h: Removed.
- platform/graphics/chromium/cc/CCLayerImpl.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerImpl.h: Removed.
- platform/graphics/chromium/cc/CCLayerIterator.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerIterator.h: Removed.
- platform/graphics/chromium/cc/CCLayerQuad.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerQuad.h: Removed.
- platform/graphics/chromium/cc/CCLayerSorter.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerSorter.h: Removed.
- platform/graphics/chromium/cc/CCLayerTilingData.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerTilingData.h: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHost.h: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHostClient.h: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.h: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Removed.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Removed.
- platform/graphics/chromium/cc/CCMathUtil.cpp: Removed.
- platform/graphics/chromium/cc/CCMathUtil.h: Removed.
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Removed.
- platform/graphics/chromium/cc/CCOcclusionTracker.h: Removed.
- platform/graphics/chromium/cc/CCOverdrawMetrics.cpp: Removed.
- platform/graphics/chromium/cc/CCOverdrawMetrics.h: Removed.
- platform/graphics/chromium/cc/CCPageScaleAnimation.cpp: Removed.
- platform/graphics/chromium/cc/CCPageScaleAnimation.h: Removed.
- platform/graphics/chromium/cc/CCPrioritizedTexture.cpp: Removed.
- platform/graphics/chromium/cc/CCPrioritizedTexture.h: Removed.
- platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp: Removed.
- platform/graphics/chromium/cc/CCPrioritizedTextureManager.h: Removed.
- platform/graphics/chromium/cc/CCPriorityCalculator.cpp: Removed.
- platform/graphics/chromium/cc/CCPriorityCalculator.h: Removed.
- platform/graphics/chromium/cc/CCProxy.cpp: Removed.
- platform/graphics/chromium/cc/CCProxy.h: Removed.
- platform/graphics/chromium/cc/CCQuadCuller.cpp: Removed.
- platform/graphics/chromium/cc/CCQuadCuller.h: Removed.
- platform/graphics/chromium/cc/CCQuadSink.h: Removed.
- platform/graphics/chromium/cc/CCRenderPass.cpp: Removed.
- platform/graphics/chromium/cc/CCRenderPass.h: Removed.
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp: Removed.
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.h: Removed.
- platform/graphics/chromium/cc/CCRenderPassSink.h: Removed.
- platform/graphics/chromium/cc/CCRenderSurface.cpp: Removed.
- platform/graphics/chromium/cc/CCRenderSurface.h: Removed.
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp: Removed.
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.h: Removed.
- platform/graphics/chromium/cc/CCRenderer.h: Removed.
- platform/graphics/chromium/cc/CCRendererGL.cpp: Removed.
- platform/graphics/chromium/cc/CCRendererGL.h: Removed.
- platform/graphics/chromium/cc/CCRenderingStats.h: Removed.
- platform/graphics/chromium/cc/CCResourceProvider.cpp: Removed.
- platform/graphics/chromium/cc/CCResourceProvider.h: Removed.
- platform/graphics/chromium/cc/CCScheduler.cpp: Removed.
- platform/graphics/chromium/cc/CCScheduler.h: Removed.
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Removed.
- platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Removed.
- platform/graphics/chromium/cc/CCScopedTexture.cpp: Removed.
- platform/graphics/chromium/cc/CCScopedTexture.h: Removed.
- platform/graphics/chromium/cc/CCScopedThreadProxy.h: Removed.
- platform/graphics/chromium/cc/CCScrollbarAnimationController.cpp: Removed.
- platform/graphics/chromium/cc/CCScrollbarAnimationController.h: Removed.
- platform/graphics/chromium/cc/CCScrollbarAnimationControllerLinearFade.cpp: Removed.
- platform/graphics/chromium/cc/CCScrollbarAnimationControllerLinearFade.h: Removed.
- platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp: Removed.
- platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h: Removed.
- platform/graphics/chromium/cc/CCScrollbarGeometryStub.cpp: Removed.
- platform/graphics/chromium/cc/CCScrollbarGeometryStub.h: Removed.
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp: Removed.
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h: Removed.
- platform/graphics/chromium/cc/CCSettings.cpp: Removed.
- platform/graphics/chromium/cc/CCSettings.h: Removed.
- platform/graphics/chromium/cc/CCSharedQuadState.cpp: Removed.
- platform/graphics/chromium/cc/CCSharedQuadState.h: Removed.
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: Removed.
- platform/graphics/chromium/cc/CCSingleThreadProxy.h: Removed.
- platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp: Removed.
- platform/graphics/chromium/cc/CCSolidColorDrawQuad.h: Removed.
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp: Removed.
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.h: Removed.
- platform/graphics/chromium/cc/CCStreamVideoDrawQuad.cpp: Removed.
- platform/graphics/chromium/cc/CCStreamVideoDrawQuad.h: Removed.
- platform/graphics/chromium/cc/CCTexture.cpp: Removed.
- platform/graphics/chromium/cc/CCTexture.h: Removed.
- platform/graphics/chromium/cc/CCTextureDrawQuad.cpp: Removed.
- platform/graphics/chromium/cc/CCTextureDrawQuad.h: Removed.
- platform/graphics/chromium/cc/CCTextureLayerImpl.cpp: Removed.
- platform/graphics/chromium/cc/CCTextureLayerImpl.h: Removed.
- platform/graphics/chromium/cc/CCTextureUpdateController.cpp: Removed.
- platform/graphics/chromium/cc/CCTextureUpdateController.h: Removed.
- platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp: Removed.
- platform/graphics/chromium/cc/CCTextureUpdateQueue.h: Removed.
- platform/graphics/chromium/cc/CCThread.h: Removed.
- platform/graphics/chromium/cc/CCThreadProxy.cpp: Removed.
- platform/graphics/chromium/cc/CCThreadProxy.h: Removed.
- platform/graphics/chromium/cc/CCThreadTask.h: Removed.
- platform/graphics/chromium/cc/CCTileDrawQuad.cpp: Removed.
- platform/graphics/chromium/cc/CCTileDrawQuad.h: Removed.
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: Removed.
- platform/graphics/chromium/cc/CCTiledLayerImpl.h: Removed.
- platform/graphics/chromium/cc/CCTimeSource.h: Removed.
- platform/graphics/chromium/cc/CCTimer.cpp: Removed.
- platform/graphics/chromium/cc/CCTimer.h: Removed.
- platform/graphics/chromium/cc/CCTimingFunction.cpp: Removed.
- platform/graphics/chromium/cc/CCTimingFunction.h: Removed.
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: Removed.
- platform/graphics/chromium/cc/CCVideoLayerImpl.h: Removed.
- platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp: Removed.
- platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h: Removed.
Source/WebKit/chromium:
- WebKit.gyp:
- WebKit.gypi:
- WebKitUnitTests.gyp:
- src/WebAnimationCurveCommon.cpp: Removed.
- src/WebAnimationCurveCommon.h: Removed.
- src/WebAnimationImpl.cpp: Removed.
- src/WebAnimationImpl.h: Removed.
- src/WebContentLayerImpl.cpp: Removed.
- src/WebContentLayerImpl.h: Removed.
- src/WebExternalTextureLayerImpl.cpp: Removed.
- src/WebExternalTextureLayerImpl.h: Removed.
- src/WebFloatAnimationCurveImpl.cpp: Removed.
- src/WebFloatAnimationCurveImpl.h: Removed.
- src/WebIOSurfaceLayerImpl.cpp: Removed.
- src/WebIOSurfaceLayerImpl.h: Removed.
- src/WebImageLayerImpl.cpp: Removed.
- src/WebImageLayerImpl.h: Removed.
- src/WebLayerImpl.cpp: Removed.
- src/WebLayerImpl.h: Removed.
- src/WebLayerTreeViewImpl.cpp: Removed.
- src/WebLayerTreeViewImpl.h: Removed.
- src/WebScrollbarLayerImpl.cpp: Removed.
- src/WebScrollbarLayerImpl.h: Removed.
- src/WebSolidColorLayerImpl.cpp: Removed.
- src/WebSolidColorLayerImpl.h: Removed.
- src/WebToCCInputHandlerAdapter.cpp: Removed.
- src/WebToCCInputHandlerAdapter.h: Removed.
- src/WebTransformAnimationCurveImpl.cpp: Removed.
- src/WebTransformAnimationCurveImpl.h: Removed.
- src/WebVideoLayerImpl.cpp: Removed.
- src/WebVideoLayerImpl.h: Removed.
- tests/CCActiveAnimationTest.cpp: Removed.
- tests/CCAnimationTestCommon.cpp: Removed.
- tests/CCAnimationTestCommon.h: Removed.
- tests/CCDamageTrackerTest.cpp: Removed.
- tests/CCDelayBasedTimeSourceTest.cpp: Removed.
- tests/CCDrawQuadTest.cpp: Removed.
- tests/CCFrameRateControllerTest.cpp: Removed.
- tests/CCGeometryTestUtils.cpp: Removed.
- tests/CCGeometryTestUtils.h: Removed.
- tests/CCHeadsUpDisplayTest.cpp: Removed.
- tests/CCKeyframedAnimationCurveTest.cpp: Removed.
- tests/CCLayerAnimationControllerTest.cpp: Removed.
- tests/CCLayerImplTest.cpp: Removed.
- tests/CCLayerIteratorTest.cpp: Removed.
- tests/CCLayerQuadTest.cpp: Removed.
- tests/CCLayerSorterTest.cpp: Removed.
- tests/CCLayerTestCommon.cpp: Removed.
- tests/CCLayerTestCommon.h: Removed.
- tests/CCLayerTreeHostCommonTest.cpp: Removed.
- tests/CCLayerTreeHostImplTest.cpp: Removed.
- tests/CCLayerTreeHostTest.cpp: Removed.
- tests/CCMathUtilTest.cpp: Removed.
- tests/CCOcclusionTrackerTest.cpp: Removed.
- tests/CCOcclusionTrackerTestCommon.h: Removed.
- tests/CCPrioritizedTextureTest.cpp: Removed.
- tests/CCQuadCullerTest.cpp: Removed.
- tests/CCRenderPassTest.cpp: Removed.
- tests/CCRenderSurfaceFiltersTest.cpp: Removed.
- tests/CCRenderSurfaceTest.cpp: Removed.
- tests/CCRendererGLTest.cpp: Removed.
- tests/CCResourceProviderTest.cpp: Removed.
- tests/CCSchedulerStateMachineTest.cpp: Removed.
- tests/CCSchedulerTest.cpp: Removed.
- tests/CCSchedulerTestCommon.h: Removed.
- tests/CCScopedTextureTest.cpp: Removed.
- tests/CCScrollbarAnimationControllerLinearFadeTest.cpp: Removed.
- tests/CCSolidColorLayerImplTest.cpp: Removed.
- tests/CCTestCommon.h: Removed.
- tests/CCTextureUpdateControllerTest.cpp: Removed.
- tests/CCThreadTaskTest.cpp: Removed.
- tests/CCThreadedTest.cpp: Removed.
- tests/CCThreadedTest.h: Removed.
- tests/CCTiledLayerImplTest.cpp: Removed.
- tests/CCTiledLayerTestCommon.cpp: Removed.
- tests/CCTiledLayerTestCommon.h: Removed.
- tests/CCTimerTest.cpp: Removed.
- tests/ContentLayerChromiumTest.cpp: Removed.
- tests/FakeCCLayerTreeHostClient.h: Removed.
- tests/FakeGraphicsContext3DTest.cpp: Removed.
- tests/FakeWebScrollbarThemeGeometry.h: Removed.
- tests/FloatQuadTest.cpp: Removed.
- tests/GraphicsLayerChromiumTest.cpp:
- tests/ImageLayerChromiumTest.cpp:
- tests/LayerChromiumTest.cpp: Removed.
- tests/MockCCQuadCuller.h: Removed.
- tests/ScrollbarLayerChromiumTest.cpp: Removed.
- tests/TextureCopierTest.cpp: Removed.
- tests/TextureLayerChromiumTest.cpp: Removed.
- tests/ThrottledTextureUploaderTest.cpp: Removed.
- tests/TiledLayerChromiumTest.cpp: Removed.
- tests/TreeSynchronizerTest.cpp: Removed.
- tests/WebAnimationTest.cpp: Removed.
- tests/WebFloatAnimationCurveTest.cpp: Removed.
- tests/WebLayerTest.cpp: Removed.
- tests/WebLayerTreeViewTest.cpp: Removed.
- tests/WebTransformAnimationCurveTest.cpp: Removed.
- tests/WebTransformOperationsTest.cpp: Removed.
- tests/WebTransformationMatrixTest.cpp: Removed.
- 1:31 PM Changeset in webkit [129159] by
-
- 2 edits in trunk/LayoutTests
Mark plugins/netscape-dom-access-and-reload.html as flakey
https://bugs.webkit.org/show_bug.cgi?id=82752
- platform/mac/TestExpectations:
- 1:04 PM Changeset in webkit [129158] by
-
- 9 edits in trunk
run-perf-tests should record individual value instead of statistics
https://bugs.webkit.org/show_bug.cgi?id=97155
Reviewed by Hajime Morita.
PerformanceTests:
Report the list of values as "values" so that run-perf-tests can parse them.
- resources/runner.js:
(PerfTestRunner.computeStatistics):
(PerfTestRunner.printStatistics):
Tools:
Parse the list of individual value reported by tests and include them as "values".
We strip "values" from the output JSON when uploading it to the perf-o-matic
since it doesn't know how to parse "values" or ignore it.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output): Parse and report "values".
(PageLoadingPerfTest.run): Report indivisual page loading time in "values".
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_and_show_results): Strip "values" from each result
until we update perf-o-matic.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_memory_test):
(test_run_with_json_output):
(test_run_with_description):
(test_run_with_slave_config_json):
(test_run_with_multiple_repositories):
LayoutTests:
The expected result now contains individual value.
- fast/harness/perftests/runs-per-second-log-expected.txt:
- 12:54 PM Changeset in webkit [129157] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fixed a missing semicolon in the C++ llint backend.
https://bugs.webkit.org/show_bug.cgi?id=97252.
Reviewed by Geoff Garen.
- offlineasm/cloop.rb:
- 12:51 PM Changeset in webkit [129156] by
-
- 12 edits2 adds in trunk
Refactored the interpreter and JIT so they don't dictate closure layout
https://bugs.webkit.org/show_bug.cgi?id=97221
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Capture may change the location of an argument for space efficiency. This
patch removes static assumptions about argument location from the interpreter
and JIT.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::argumentIndexAfterCapture):
(JSC::ExecState::argumentAfterCapture): Factored out a helper function
so the compiler could share this logic.
- bytecompiler/NodesCodegen.cpp:
(JSC::BracketAccessorNode::emitBytecode): Don't emit optimized bracket
access on arguments if a parameter has been captured by name. This case is
rare and, where I've seen it in the wild, the optimization mostly failed
anyway due to arguments escape, so I didn't feel like writing and testing
five copies of the code that would handle it in the baseline engines.
The DFG can still synthesize this optimization even if we don't emit the
optimized bytecode for it.
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::symbolTableFor):
(AssemblyHelpers): Use the right helper function to account for the fact
that a parameter may have been captured by name and moved.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock): ASSERT that we haven't inlined
a .apply on captured arguments. Once we do start inlining such things,
we'll need to do a little bit of math here to get them right.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Added support for bracket access on
an arguments object where arguments have also been captured by name. We
load the true index of the argument from a side vector. Arguments elision
is very powerful in the DFG, so I wanted to keep it working, even in this
rare case.
- interpreter/Interpreter.cpp:
(JSC::loadVarargs): Use the right helper function to account for the fact
that a parameter may have been captured by name and moved.
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs): Don't use the inline copy loop if some
of our arguments have moved, since it would copy stale values. (We still
optimize the actual call, and elide the arguments object.)
LayoutTests:
- fast/js/dfg-arguments-alias-activation-expected.txt: Added.
- fast/js/dfg-arguments-alias-activation.html: Added.
- 12:49 PM Changeset in webkit [129155] by
-
- 2 edits in trunk/Tools
[Qt] Fix production builds
Unreviewed trivial fix: Follow up r129119 and avoid clobbering LIBS through the use of LIBS_PRIVATE.
Otherwise the libQtWebKit.prl file for example contains -lWebKit1 -lWebCore, etc.
- qmake/mkspecs/features/functions.prf:
- 12:29 PM Changeset in webkit [129154] by
-
- 7 edits2 adds in trunk
Implement absolutely positioned flex items
https://bugs.webkit.org/show_bug.cgi?id=93798
Reviewed by Ojan Vafai.
Source/WebCore:
Previously, we treated absolutely positioned flex items as a 0x0 placeholder element.
Now we position the 0x0 placeholder where the next item would go. This causes the
following changes:
- justify-content: space-{around,between} no longer change due to the existence of absolutely positioned flex items.
- alignment doesn't change the placement of absolutely positioned flex items.
- auto margins in the alignment direction don't do anything on absolutely positioned flex items.
Test: css3/flexbox/position-absolute-children.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Absolutely positioned flex items should not use this.
(WebCore::RenderFlexibleBox::updateAutoMarginsInCrossAxis): Absolutely positioned flex items should not use this.
(WebCore::initialJustifyContentOffset): If there are no flex items, space-around should center an absolutely positioned flex item.
(WebCore::RenderFlexibleBox::numberOfInFlowPositionedChildren): Helper method for helping to compute space-between and space-around.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Fix spacing when space-between or space-around.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Fix spacing when space-between or space-around.
(WebCore::RenderFlexibleBox::alignChildren): Treat absolutely positioned children like flex-start.
- rendering/RenderFlexibleBox.h: numberOfInFlowPositionedChildren method.
LayoutTests:
Fix position of absolute flex items and add some additional tests.
- css3/flexbox/align-absolute-child-expected.txt:
- css3/flexbox/align-absolute-child.html: New test cases and update expectations.
- css3/flexbox/position-absolute-child.html: Update expectations.
- css3/flexbox/position-absolute-children-expected.txt: Added.
- css3/flexbox/position-absolute-children.html: Added. Tests having only absolutely positioned children.
- 12:24 PM Changeset in webkit [129153] by
-
- 2 edits in trunk/LayoutTests
Remove now passing test.
- platform/chromium/TestExpectations:
- 12:09 PM Changeset in webkit [129152] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r129144.
http://trac.webkit.org/changeset/129144
https://bugs.webkit.org/show_bug.cgi?id=97244
causing lots of assertions in tests (Requested by smfr on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-20
- rendering/InlineBox.h:
(WebCore::InlineBox::markDirty):
- rendering/InlineTextBox.cpp:
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::start):
(WebCore::InlineTextBox::end):
(WebCore::InlineTextBox::len):
(WebCore::InlineTextBox::offsetRun):
- 11:55 AM Changeset in webkit [129151] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/media/video-referer.html as flakey in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=34331
- platform/mac/TestExpectations:
- 11:52 AM Changeset in webkit [129150] by
-
- 9 edits in trunk
CSP reports should send an empty 'referrer' rather than nothing.
https://bugs.webkit.org/show_bug.cgi?id=97233
Patch by Mike West <mkwst@chromium.org> on 2012-09-20
Reviewed by Adam Barth.
Source/WebCore:
Currently, if a protected resource doesn't have a referrer, then any
Content Security Policy violations send a report that doesn't contain
a referrer attribute. It's arguably friendlier to developers to include
an explicitly empty attribute.
This new behavior is covered by updates to existing test expectations
around the reporting functionality.
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
Drop the 'if', and always write out a referrer.
LayoutTests:
- http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
Adding the empty 'referrer' attribute to the expectations.
- 11:42 AM Changeset in webkit [129149] by
-
- 1 edit2 adds in trunk/LayoutTests
Add WK2-specific result for this frame-flattening test (seems to be a scrollbars difference).
Tracked by https://bugs.webkit.org/show_bug.cgi?id=97240.
- platform/mac-wk2/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
- 11:41 AM Changeset in webkit [129148] by
-
- 5 edits in trunk/Tools
REGRESSION: layout test results doesn't show diffs
https://bugs.webkit.org/show_bug.cgi?id=97182
Reviewed by Ojan Vafai.
Go back to storing TEXT, AUDIO, and IMAGE+TEXT in results.json
so that results.html (and hopefully garden-o-matic) can
determine which things actually failed. However, we keep mapping
these results to Failure so that we still only have a single
expectation type for them.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
(TestExpectations):
(TestExpectations.result_was_expected):
- Scripts/webkitpy/layout_tests/models/test_failures.py:
(determine_result_type):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_retrying_and_flaky_tests):
- 11:27 AM Changeset in webkit [129147] by
-
- 3 edits in branches/chromium/1229/Source/WebCore/rendering
Merge 129144 - Prevent reading stale data from InlineTextBoxes
https://bugs.webkit.org/show_bug.cgi?id=94750
Reviewed by Eric Seidel.
Text from dirty InlineTextBoxes should never be read or used. This change enforces this
design goal by forcefully zero-ing out the start and length of InlineTextBoxes when
they're being marked dirty. It also adds asserts to accessors for those members.
This change involves making markDirty virtual. Running the line-layout performance test
as well as profiling resizing the html5 spec showed negligable impact with this change.
No new tests as this doesn't change any proper behavior.
- rendering/InlineBox.h:
(WebCore::InlineBox::markDirty): Making virtual to allow InlineTextBox to overload and
zero out its start and length.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::markDirty): Zeroing out start and length when we mark the box dirty.
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::start): Adding an assert when we hit this case.
(WebCore::InlineTextBox::end): Ditto.
(WebCore::InlineTextBox::len): Ditto.
(WebCore::InlineTextBox::offsetRun): Ditto.
TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/10970020
- 11:27 AM Changeset in webkit [129146] by
-
- 45 edits in trunk
[MathML] Increase visual space around fraction parts, italic variables, and operators
https://bugs.webkit.org/show_bug.cgi?id=97228
Reviewed by Eric Seidel.
Source/WebCore:
This makes MathML more readable, and more in agreement with Firefox and TeX.
Tested by existing tests.
- css/mathml.css:
(mfrac > :first-child):
(mfrac > :last-child):
(mfrac):
(mi):
(msub > mi:first-child, msubsup > mi:first-child):
- Subscripts don't need to move right after an italic <mi>.
(msubsup > mi:first-child + * + *):
- Superscripts do need to move right after an italic <mi>.
(math > mo, mrow > mo, msqrt > mo, mtd > mo):
- These are ok values for now. It will be better to use different values for different operators, as the FIXME says.
(math > mo:last-child, mrow > mo:last-child, msqrt > mo:last-child, mtd > mo:last-child):
- Prefix and postfix operators, including fences, generally get less spacing than infix operators.
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::createMathMLOperator):
- Usually the separator is a comma or semicolon, so we only put space after it for now.
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
(WebCore::RenderMathMLFenced::styleDidChange):
- rendering/mathml/RenderMathMLFenced.h:
(RenderMathMLFenced):
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore):
(WebCore::RenderMathMLFraction::updateFromElement):
- gDenominatorPad is now handled by mathml.css.
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore):
(WebCore::RenderMathMLSubSup::fixScriptsStyle):
- gSubsupScriptMargin is now handled by mathml.css.
LayoutTests:
- platform/mac/mathml/presentation/attributes-expected.png:
- platform/mac/mathml/presentation/attributes-expected.txt:
- platform/mac/mathml/presentation/fenced-expected.png:
- platform/mac/mathml/presentation/fenced-expected.txt:
- platform/mac/mathml/presentation/fenced-mi-expected.png:
- platform/mac/mathml/presentation/fenced-mi-expected.txt:
- platform/mac/mathml/presentation/fractions-expected.png:
- platform/mac/mathml/presentation/fractions-expected.txt:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/mac/mathml/presentation/mo-expected.png:
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/mo-stretch-expected.png:
- platform/mac/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/mathml/presentation/mroot-pref-width-expected.png:
- platform/mac/mathml/presentation/mroot-pref-width-expected.txt:
- platform/mac/mathml/presentation/over-expected.png:
- platform/mac/mathml/presentation/over-expected.txt:
- platform/mac/mathml/presentation/roots-expected.png:
- platform/mac/mathml/presentation/roots-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.png:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/row-expected.png:
- platform/mac/mathml/presentation/row-expected.txt:
- platform/mac/mathml/presentation/style-expected.png:
- platform/mac/mathml/presentation/style-expected.txt:
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.png:
- platform/mac/mathml/presentation/subsup-expected.txt:
- platform/mac/mathml/presentation/sup-expected.png:
- platform/mac/mathml/presentation/sup-expected.txt:
- platform/mac/mathml/presentation/tokenElements-expected.png:
- platform/mac/mathml/presentation/tokenElements-expected.txt:
- platform/mac/mathml/presentation/under-expected.txt:
- platform/mac/mathml/presentation/underover-expected.png:
- platform/mac/mathml/presentation/underover-expected.txt:
- platform/mac/mathml/xHeight-expected.png:
- platform/mac/mathml/xHeight-expected.txt:
- 11:23 AM Changeset in webkit [129145] by
-
- 8 edits in trunk
MediaStream API: Extend UserMediaRequest with a ownerDocument method
https://bugs.webkit.org/show_bug.cgi?id=97095
Reviewed by Adam Barth.
Source/WebCore:
Chromium need to know exactly which frame called getUserMedia so that it can
clean away the stream when the frame goes away.
Since that information is available in webkit add an accessor method.
Chromium mock class extended to test the added method.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::ownerDocument):
(WebCore):
- Modules/mediastream/UserMediaRequest.h:
(WebCore):
(UserMediaRequest):
Source/WebKit/chromium:
Chromium need to know exactly which frame called getUserMedia so that it can clean
away the stream when the frame goes away.
Since that information is available in webkit add an accessor method.
Also taking the opportunity to remove an unused deprecated method,
and adding asserts in case the object is empty.
- public/WebUserMediaRequest.h:
(WebKit):
(WebUserMediaRequest):
- src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::ownerDocument):
Tools:
Extending WebUserMediaClientMock to check that the owning document is valid,
and that the document has a frame.
- DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(WebKit::WebUserMediaClientMock::requestUserMedia):
- 11:20 AM Changeset in webkit [129144] by
-
- 4 edits in trunk/Source/WebCore
Prevent reading stale data from InlineTextBoxes
https://bugs.webkit.org/show_bug.cgi?id=94750
Reviewed by Eric Seidel.
Text from dirty InlineTextBoxes should never be read or used. This change enforces this
design goal by forcefully zero-ing out the start and length of InlineTextBoxes when
they're being marked dirty. It also adds asserts to accessors for those members.
This change involves making markDirty virtual. Running the line-layout performance test
as well as profiling resizing the html5 spec showed negligable impact with this change.
No new tests as this doesn't change any proper behavior.
- rendering/InlineBox.h:
(WebCore::InlineBox::markDirty): Making virtual to allow InlineTextBox to overload and
zero out its start and length.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::markDirty): Zeroing out start and length when we mark the box dirty.
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::start): Adding an assert when we hit this case.
(WebCore::InlineTextBox::end): Ditto.
(WebCore::InlineTextBox::len): Ditto.
(WebCore::InlineTextBox::offsetRun): Ditto.
- 11:11 AM Changeset in webkit [129143] by
-
- 8 edits4 adds in trunk
Support paths in Content Security Policy directives.
https://bugs.webkit.org/show_bug.cgi?id=89750
Patch by Mike West <mkwst@chromium.org> on 2012-09-20
Reviewed by Adam Barth.
Source/WebCore:
In CSP 1.0, paths are simply ignored: 'script-src
http://example.com/path/to/a/file' would allow script to be loaded from
http://example.com/path/to/a/file/javascript.js, but also from
http://example.com/javascript.js.
This patch is an experimental implementation of more granular path
support in CSP source lists as proposed in the current editor's draft of
CSP 1.1. Paths are treated as specifying directories in which resources
can be found, and are implicitly terminated with a '/': in other words,
'script-src http://a.com/path' is the same as
'script-src http://a.com/path/'. Moreover, paths cannot contain either
'?' or '#' characters.
This is implemented outside the CSP_NEXT flag. All ports will be
effected.
Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#matching
Tests: http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html
http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02.html
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPSource::CSPSource):
Store a path along with each CSP source.
(WebCore::CSPSource::matches):
Check the path when comparing a URL to the source.
(WebCore::CSPSource::pathMatches):
Compare the URL-decoded version of the resource to validate against
the source's stored path. If the resource's path begins with the
stored path, then it matches! If not, it doesn't.
(CSPSource):
Store a path along with each CSP source.
(WebCore::CSPSourceList::parse):
Pass a 'path' in when creating CSPSource objects.
(WebCore::CSPSourceList::parsePath):
Actually parse the path, flagging errors if '?' or '#' are present,
URL-decoding the result, and ensuring that a terminal '/' is
added if necessary.
(WebCore::CSPSourceList::addSourceSelf):
Ensure that 'self' sources have an empty path.
- page/ContentSecurityPolicy.h:
Dropping the "ignored path component" console warning.
LayoutTests:
- http/tests/security/contentSecurityPolicy/source-list-parsing-05-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-05.html:
- http/tests/security/contentSecurityPolicy/source-list-parsing-06-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-06.html:
The behavior of these tests changes based on the new functionality.
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02.html: Added.
New tests for various path cases.
- 11:00 AM Changeset in webkit [129142] by
-
- 5 edits in trunk/LayoutTests
IndexedDB: Rewrite confusing call sequence layout tests
https://bugs.webkit.org/show_bug.cgi?id=97051
Reviewed by Tony Chang.
Rewrite some convoluted and hard to understand/maintain tests in a more idiomatic fashion.
This patch maintains the bulk of the non-standard output to verify that the tests have not
changed in behavior; follow-ups will make the output more standard and split the tests
into separate files.
- storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
- storage/indexeddb/open-close-version-expected.txt:
- storage/indexeddb/resources/factory-deletedatabase-interactions.js:
- storage/indexeddb/resources/open-close-version.js:
- 10:56 AM Changeset in webkit [129141] by
-
- 3 edits2 adds in trunk
[GTK] ControlsPanel string is not localized in LocalizedStringsGtk
https://bugs.webkit.org/show_bug.cgi?id=96502
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-20
Reviewed by Chris Fleizach.
Source/WebCore:
Adds the ControlsPanel string to the strings localized in LocalizedStringsGtk.
Test: platform/gtk/accessibility/media-controls-panel-title.html
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaControlElementString):
LayoutTests:
Added a new test to verify that the accessible object associated with the
MediaControlsPanel has the expected accessible name.
- platform/gtk/accessibility/media-controls-panel-title-expected.txt: Added.
- platform/gtk/accessibility/media-controls-panel-title.html: Added.
- 10:49 AM Changeset in webkit [129140] by
-
- 3 edits5 adds in trunk
Safari 6 notifications' onclick handlers can't call window.open()
https://bugs.webkit.org/show_bug.cgi?id=96959
<rdar://problem/12132427>
Reviewed by Darin Adler.
Source/WebKit2:
The click is not being treated as a user gesture when the message is sent to the web process.
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::didClickNotification): Gets called when the user clicks on the
platform notification. Set UserGestureIndicator to show the click event is due to user gesture.
LayoutTests:
The test shows and clicks a platform notification. The onclick handler calls window.open(),
which in turn calls a function on the main page to confirm that a window was opened.
- http/tests/notifications/legacy/window-show-on-click-expected.txt: Added.
- http/tests/notifications/legacy/window-show-on-click.html: Added.
- http/tests/notifications/resources/window-show-on-click.html: Added.
- http/tests/notifications/window-show-on-click-expected.txt: Added.
- http/tests/notifications/window-show-on-click.html: Added.
- 10:20 AM EFLWebKit edited by
- add ruby to the cli command as well after the change introduced in rev 71 (diff)
- 8:57 AM Changeset in webkit [129139] by
-
- 2 edits in trunk/Tools
[Chromium] DRT does not support --dump-all-pixels flag
https://bugs.webkit.org/show_bug.cgi?id=95098
Reviewed by Dirk Pranke.
Add support for the --pixel-tests and shorthand -p option in Chromium DumpRenderTree. Use
of this flag causes pixel results to be created for all tests, regardless of
individual test options. If an individual test provides a pixel hash it will be used,
otherwise the hash will be empty. This replaces a previously defined but unused option
--dump-all-pixels, and is useful primarily when debugging DRT instances.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(runTest): Add a parameter and code to force pixel results for the test.
(main): Add parameter handling for --pixels-test and -p, and remove --dump-all-pixels.
- 8:48 AM Changeset in webkit [129138] by
-
- 3 edits in trunk/Tools
[GTK] run-api-tests should not buffer test stdout
https://bugs.webkit.org/show_bug.cgi?id=88474
Reviewed by Philippe Normand.
- Scripts/run-gtk-tests:
(TestRunner._run_test_command): Use os.forkpty() instead of
subprocess.Popen() so that gtest sends the output with colors to
stdout. Use common.parse_output_lines() to parse the output and
write it to stdout while it's read.
(TestRunner._run_test_command.parse_line): Parse the line to get
the test pid and write the line to stdout.
(TestRunner._run_test_command.waitpid): Helper function to call
waitpid handling EINTR.
(TestRunner._run_test_command.return_code_from_exit_status):
Helper function to convert exit status of test commands to a
return code.
- gtk/common.py:
(parse_output_lines): Helper function that uses select to read
the given file descriptor and call the given callback for every
line read.
- 8:25 AM Changeset in webkit [129137] by
-
- 1 edit in branches/chromium/1271/Source/WebKit/chromium/features.gypi
Disable CSP_NEXT on Chromium M23 branch.
BUG=148060
- 8:05 AM Changeset in webkit [129136] by
-
- 2 edits in trunk/Source/WebCore
Remove isStartColumn in the border collapsing code
https://bugs.webkit.org/show_bug.cgi?id=97024
Reviewed by Abhishek Arya.
isStartColumn is embedding the same information as prevCell. As we need to compute it
in most of the cases, we may as well just reuse them.
While touching this code, I cleaned up the code by removing some unneeded checks and renaming
some variables in preparation for bug 79272.
Refactoring covered by existing collapsing borders tests.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeCollapsedStartBorder):
Removed |isStartColumn|.
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Added a comment about why |isEndColumn| is needed. Also cleaned up this code to be
consistent with computeCollapsedStartBorder.
- 7:57 AM EFLWebKitBuildBots edited by
- And now fix the table (diff)
- 7:57 AM EFLWebKitBuildBots edited by
- Add Kenneth to the people list (diff)
- 7:55 AM EFLWebKitBuildBots edited by
- Sort the people table alphabetically (diff)
- 7:54 AM EFLWebKitBuildBots edited by
- Update the information here (diff)
- 7:50 AM Changeset in webkit [129135] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskip fast/exclusions tests, because they pass now.
- platform/qt/Skipped:
- 7:40 AM WebKitGTK/1.10.x edited by
- (diff)
- 7:39 AM Changeset in webkit [129134] by
-
- 12 edits2 adds in trunk/Source/WebKit2
[EFL][WK2] Add APIs to create, delete and get ewk_context.
https://bugs.webkit.org/show_bug.cgi?id=89186
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.
Provide APIs to create ewk_context with or without injected bundle path
and delete created ewk_context.
Additionally, the ewk_view can be created with ewk_context which is not
default context, so we have to get ewk_context from ewk_view.
- PlatformEfl.cmake:
- UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::handleDownloadRequest):
- UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(ewk_context_ref):
(ewk_context_unref):
(ewk_context_new):
(ewk_context_new_with_injected_bundle_path):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_priv_del):
(_ewk_view_initialize):
(ewk_view_context_get):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/InjectedBundle/injected_bundle_sample.cpp: Added.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:
(EWK2UnitTest::EWK2UnitTestEnvironment::injectedBundleSample):
(EWK2UnitTest):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
(EWK2UnitTestEnvironment):
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 7:38 AM WebKitGTK/1.10.x edited by
- Use the actual revision for easy copy-paste (diff)
- 7:37 AM Changeset in webkit [129133] by
-
- 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore
Merger r128996 - [GTK] REGRESSION(r128907): it broke several WebKit2 API tests
https://bugs.webkit.org/show_bug.cgi?id=97092
Reviewed by Martin Robinson.
Calling resizeLater() from the constructor of
RedirectedXCompositeWindow can cause the callback to be called
later by the main loop after the RedirectedXCompositeWindow object
has been destroyed. Instead of calling resizeLater(), initialize
the usable size to the given initial size.
- platform/gtk/RedirectedXCompositeWindow.cpp:
(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
- 7:34 AM Changeset in webkit [129132] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviwed gardening. Skip test failing with timeout.
https://bugs.webkit.org/show_bug.cgi?id=96397
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-20
- platform/qt-5.0-wk2/Skipped: skip fast/spatial-navigation/snav-media-elements.html.
- 7:33 AM Changeset in webkit [129131] by
-
- 15 edits in releases/WebKitGTK/webkit-1.10/Source
Merge r128907 - [GTK] [WebKit2] Use XComposite window for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=94417
Reviewed by Carlos Garcia Campos.
Instead of rendering directly to the widget's native window, render to an
offscreen window redirected to a Pixmap with XComposite.
Source/WebCore:
No new tests. This will be covered by the existing accelerated compositing tests,
which should now give correct pixel results.
- platform/gtk/RedirectedXCompositeWindow.cpp:
(WebCore::RedirectedXCompositeWindow::resize): Add a call to XFlush which ensures
that pending X11 operations complete.
- platform/gtk/RedirectedXCompositeWindow.h:
(WebCore::RedirectedXCompositeWindow::windowId): Added this accessor.
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate): Added a few members necessary to track the
offscreen window.
(webkit_web_view_base_init):
(renderAcceleratedCompositingResults): Added this helper functions which renders
the results of the accelerated compositing operations during the GTK+ draw loop.
(webkitWebViewBaseDraw): Call renderAcceleratedCompositingResults when appropriate.
(resizeWebKitWebViewBaseFromAllocation): Resize the offscreen window when appropriate.
(webkitWebViewBaseSizeAllocate): Do not call resizeWebKitWebViewBaseFromAllocation when
the actual size of the widget does not change. This prevents destroying and recreating
the offscreen window pixmap when it isn't necessary.
(webkitWebViewBaseMap): We no longer send the window id during map, instead it's sent
as soon as there is WebPageProxy.
(webkitWebViewBaseCreateWebPage): Send the window id of the redirected window to
the WebProcess.
(queueAnotherDrawOfAcceleratedCompositingResults): Added this helper which works
around the issue of slow updates of the pixmap backing the redirected XComposite window.
(webkitWebViewBaseQueueDrawOfAcceleratedCompositingResults): Added this method which
is what the WebProcess uses to force a redraw on the UIProcess side.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Added new method to the list of private methods.
- UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode): Exposed this method publically
so that it can be used from WebKitWebViewBase.
- UIProcess/WebPageProxy.h:
(WebPageProxy): Renamed widgetMapped to setAcceleratedCompositingWindowId.
- UIProcess/WebPageProxy.messages.in: Ditto.
- UIProcess/gtk/WebPageProxyGtk.cpp: Ditto.
(WebKit::WebPageProxy::setAcceleratedCompositingWindowId):
- WebProcess/WebPage/WebPage.h:
(WebPage): Ditto.
- WebProcess/WebPage/WebPage.messages.in: Ditto.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::sizeDidChange): Force a composite to the resized window right
away so that the new window pixmap is updated before the first draw.
(WebKit::LayerTreeHostGtk::compositeLayersToContext): If the composition is for a resize,
first clear the entire GL context so that we don't see black artifacts during resize.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk): Update the signature of compositeLayersToContext.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::setAcceleratedCompositingWindowId): Added.
- 7:25 AM Changeset in webkit [129130] by
-
- 4 edits1 add in trunk/LayoutTests
[EFL] Rebase and move compositing/geometry/fixed-position.html
https://bugs.webkit.org/show_bug.cgi?id=97207
Unreviewed EFL gardening.
Rebase and move fixed-position.html to efl-wk1 TestExpectations
since it does not fail on the WebKit2 bots with rebased.
- platform/efl-wk1/TestExpectations:
- platform/efl/Skipped:
- platform/efl/compositing/geometry/fixed-position-expected.png: Added.
- platform/efl/compositing/geometry/fixed-position-expected.txt: Rebased.
- 7:11 AM Changeset in webkit [129129] by
-
- 2 edits in trunk/Tools
[Qt] Fix initial build
Reviewed by Tor Arne Vestbø.
When building QtWebKit the first time there is no qt_webkit.pri module pri file, and therefore
$$QT.webkit.name isn't set and so creating_module isn't set. That has all sorts of implications
causing incorrect linking for Makefile.api, etc.
Fix the determination by simply checking if MODULE is set, which only happens in api.pri.
- qmake/mkspecs/features/webkit_modules.prf:
- 7:01 AM Changeset in webkit [129128] by
-
- 2 edits in trunk/LayoutTests
[chromium] Skip tests that will be broken by an upcoming V8 roll.
https://bugs.webkit.org/show_bug.cgi?id=97206
Unreviewed preemptive gardening.
These three tests will be broken by an upcoming V8 roll. I plan on
rebaselining them along with webkit.org/b/94332.
Patch by Mike West <mkwst@google.com> on 2012-09-20
- platform/chromium/TestExpectations:
- 6:25 AM Changeset in webkit [129127] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] r129045 broke the ARM build
https://bugs.webkit.org/show_bug.cgi?id=97195
Reviewed by Zoltan Herczeg.
Implementing missing store8 function.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::store8):
(MacroAssemblerARM):
- 6:20 AM Changeset in webkit [129126] by
-
- 5 edits65 adds in trunk
[Qt] Enable CSS regions by default
https://bugs.webkit.org/show_bug.cgi?id=97196
Source/WebKit/qt:
Reviewed by Dirk Schulze.
- Api/qwebsettings.cpp:
(QWebSettings::QWebSettings):
LayoutTests:
Add Qt specific expected results for non-reftests,
results are compared to Mac results manually.
Reviewed by Dirk Schulze.
- platform/qt/Skipped: Unskip passing fast/regions tests, skip 3 failing reftest.
- platform/qt/fast/regions/autoheight-regions-mark-expected.png: Added.
- platform/qt/fast/regions/autoheight-regions-mark-expected.txt: Added.
- platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
- platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
- platform/qt/fast/regions/flow-content-basic-expected.png: Added.
- platform/qt/fast/regions/flow-content-basic-expected.txt: Added.
- platform/qt/fast/regions/flow-content-basic-vertical-expected.png: Added.
- platform/qt/fast/regions/flow-content-basic-vertical-expected.txt: Added.
- platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
- platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
- platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
- platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
- platform/qt/fast/regions/flows-dependency-same-flow-expected.png: Added.
- platform/qt/fast/regions/flows-dependency-same-flow-expected.txt: Added.
- platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
- platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
- platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
- platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
- platform/qt/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
- platform/qt/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
- platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
- platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
- platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
- platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
- platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
- platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
- platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
- platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
- platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
- platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
- platform/qt/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
- platform/qt/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
- platform/qt/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
- platform/qt/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
- platform/qt/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
- platform/qt/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
- platform/qt/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
- platform/qt/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
- platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
- platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
- platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
- platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
- platform/qt/fast/regions/region-style-block-background-color-expected.png: Added.
- platform/qt/fast/regions/region-style-block-background-color-expected.txt: Added.
- platform/qt/fast/regions/region-style-block-background-color2-expected.png: Added.
- platform/qt/fast/regions/region-style-block-background-color2-expected.txt: Added.
- platform/qt/fast/regions/text-region-split-small-pagination-expected.png: Added.
- platform/qt/fast/regions/text-region-split-small-pagination-expected.txt: Added.
- platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
- platform/qt/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
- platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
- platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
- platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
- platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
- platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
- platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
- platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
- platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
- platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
- platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
- platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
- platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
- platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
- platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
- 6:18 AM Changeset in webkit [129125] by
-
- 2 edits in trunk/Source/Platform
[Chromium ] Add new localized string, OtherDateLabel, to be used in input type=date datalist UI
https://bugs.webkit.org/show_bug.cgi?id=97200
Reviewed by Kent Tamura.
Adding new localized string to be used in the SuggestionPicker for input type=date.
- chromium/public/WebLocalizedString.h:
- 6:14 AM Changeset in webkit [129124] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Adding the 'google_apis' directory to .gitignore.
https://bugs.webkit.org/show_bug.cgi?id=97187
Patch by Mike West <mkwst@google.com> on 2012-09-20
Reviewed by Jochen Eisinger.
'chromium/google_apis' should be ignored, as it's not in the git repo.
- .gitignore:
- 6:11 AM Changeset in webkit [129123] by
-
- 9 edits in trunk
Unreviewed, rolling out r129091.
http://trac.webkit.org/changeset/129091
https://bugs.webkit.org/show_bug.cgi?id=97205
It broke perf tests everywhere (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-20
PerformanceTests:
- resources/runner.js:
(PerfTestRunner.computeStatistics):
(PerfTestRunner.printStatistics):
Tools:
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output):
(PageLoadingPerfTest.run):
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_and_show_results):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_memory_test):
(test_run_with_json_output):
(test_run_with_description):
(test_run_with_slave_config_json):
(test_run_with_multiple_repositories):
LayoutTests:
- fast/harness/perftests/runs-per-second-log-expected.txt:
- 5:44 AM Changeset in webkit [129122] by
-
- 5 edits in trunk
Web Inspector: setPropertyValue does not work for non-finite numbers
https://bugs.webkit.org/show_bug.cgi?id=97016
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-20
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Fix: setting a property to NaN, Infinity or -Infinity numbers did not work.
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
LayoutTests:
Expands the test with non-finite numbers case.
- inspector/runtime/runtime-setPropertyValue-expected.txt:
- inspector/runtime/runtime-setPropertyValue.html:
- 5:09 AM Changeset in webkit [129121] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Implemented color picker API
https://bugs.webkit.org/show_bug.cgi?id=91832
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.
Add support for color picker API for EFL port in WebKit2.
The external application can implement input picker by overriding
smart class function.
- UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(ewk_view_color_picker_request):
(ewk_view_color_picker_dismiss):
(ewk_view_color_picker_color_set):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_private.h:
- UIProcess/API/efl/ewk_view_ui_client.cpp:
(showColorPicker):
(hideColorPicker):
(ewk_view_ui_client_attach):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(onColorPickerDone):
(setColorPickerColor):
(showColorPicker):
(hideColorPicker):
(TEST_F):
- 5:07 AM WebKitGTK/1.10.x edited by
- More git-svn branching details (diff)
- 5:05 AM Changeset in webkit [129120] by
-
- 5 edits6 deletes in trunk/LayoutTests
[Qt] [WK1] Spaces missing in output of fast/forms/mailto/advanced-{get,put}.html
https://bugs.webkit.org/show_bug.cgi?id=92551
Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-20
Reviewed by Adam Barth.
The problem here is that the text input boxes are rendered differently
in chromium and qt/gtk/efl, causing the text dump to also differ.
There are 4 adjacent input boxes in a page 800 pixel wide, the width
of these inputs is unspecified, as it should since this is unrelated
to purpose of the test, and left for the port to decide. Chromium puts
the four in the same line, qt/gtk/efl breaks the line before the fourth
input, causing an extra space to appear in the text dump.
The test was corrected by defining a fixed width for the input
elements, ensuring the text dumps will be identical in all platforms,
eliminating the need for special expected files.
- fast/forms/mailto/advanced-get.html:
- fast/forms/mailto/advanced-put.html:
- platform/efl/fast/forms/mailto/advanced-get-expected.txt: Removed.
- platform/efl/fast/forms/mailto/advanced-put-expected.txt: Removed.
- platform/gtk/fast/forms/mailto/advanced-get-expected.txt: Removed.
- platform/gtk/fast/forms/mailto/advanced-put-expected.txt: Removed.
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk2/fast/forms/mailto/advanced-get-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt: Removed.
- platform/qt-mac/Skipped:
- 4:58 AM Changeset in webkit [129119] by
-
- 5 edits in trunk
[Qt] QtWebKit module header includes private dependencies
Reviewed by Tor Arne Vestbø.
.:
Moved loading of webkit_modules.prf a few lines down after the definition
of QT_API_DEPENDS, because webkit_modules.prf does the sanitization of the
QT variable now and therefore needs QT_API_DEPENDS.
- Source/api.pri:
Tools:
- qmake/mkspecs/features/default_post.prf: Don't try to sanitize LIBS, because we can make sure
that LIBS_PRIVATE is set from the beginning. Moved the creating_module and PKGCONFIG/QT(_PRIVATE)
sanitization into webkit_modules.prf. creating_module determination requires TARGET to be set, so
we can't do it in default_pre.
- qmake/mkspecs/features/webkit_modules.prf:
- 4:45 AM WebKitGTK/1.10.x edited by
- Added a note how to use git-svn to clone webkit-1.10 branch (diff)
- 4:34 AM Changeset in webkit [129118] by
-
- 4 edits in trunk
Web Inspector: Cookie info in Network Resources Cookies tab are incorrect
https://bugs.webkit.org/show_bug.cgi?id=95491
Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-20
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Web Inspector: Cookie info in Network Resources Cookies tab are incorrect
https://bugs.webkit.org/show_bug.cgi?id=95491
Fixing a typo that causes cookies to appear as a "Session"
cookie in the Networking panel because it can never find a properly named
"expired" header.
This bug exposes another bug where the cookie GMT strings are inproperly
parsed, causing an "invalid date" error to show up in the cookies tab in
the Networking panel.
Also changed test expectations in LayoutTests/inspector/cookie-parser-expected.txt
- inspector/front-end/CookieParser.js:
(WebInspector.Cookie.prototype.get session):
LayoutTests:
Changed test expectation. If a cookie has an expired value, session should
return false.
- inspector/cookie-parser-expected.txt:
- 4:22 AM Changeset in webkit [129117] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Elements] Word wrap disablement in the DOM tree broken
https://bugs.webkit.org/show_bug.cgi?id=97185
Reviewed by Pavel Feldman.
Restored the effective "white-space: nowrap" for the tree elements.
- inspector/front-end/inspector.css:
(.nowrap):
- 4:14 AM Changeset in webkit [129116] by
-
- 2 edits in trunk/Source/WebKit2
[CoordinatedGraphics] Don't reset m_shouldSyncFrame in flushPendingLayerChanges
https://bugs.webkit.org/show_bug.cgi?id=97108
Reviewed by Noam Rosenthal.
Stop ignoring if m_shouldSyncFrame has been set between the two
layer flush. It can be set during layout in several situations,
for example when a layer is deleted or changed state. We want to
send the DidRenderFrame message at the next flush in those situations
so the UI process will apply the changes as soon as possible.
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
- 4:06 AM Changeset in webkit [129115] by
-
- 2 edits in trunk/Tools
[Qt] Fix build with MingW
Reviewed by Tor Arne Vestbø.
Don't try to compile WebCore, etc. with debug symbols for production
builds, it's just too big.
- qmake/mkspecs/features/production_build.prf:
- 3:54 AM Changeset in webkit [129114] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Unskip fast/frames/flattening/iframe-tiny.html
https://bugs.webkit.org/show_bug.cgi?id=97191
Unreviewed gardening.
Test fast/frames/flattening/iframe-tiny.html shall be unskipped as it was fixed in r129046.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-20
- platform/efl-wk2/TestExpectations:
- 3:40 AM Changeset in webkit [129113] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for tests added in r129068 and r129106.
Removing flaky crasher expectations for tests that were fixed in
r129065.
- platform/gtk/TestExpectations:
- 3:38 AM Changeset in webkit [129112] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
https://bugs.webkit.org/show_bug.cgi?id=96077
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-09-20
Reviewed by Pavel Feldman.
A minor modification to make the inspecting results more accurate.
Internally reviewd by Arvid, Robin.C, and Konrad.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderJob):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::render):
- 3:27 AM Changeset in webkit [129111] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Check timeout on waitUntilLoadFinished() and waitUntilTitleChangedTo().
https://bugs.webkit.org/show_bug.cgi?id=97081
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-20
Reviewed by Gyuyoung Kim.
Add assertion to check timeout on waitUntilLoadFinished() and
waitUntilTitleChangedTo().
Set the default timeout for the functions as 10 seconds.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
- UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 3:16 AM Changeset in webkit [129110] by
-
- 4 edits in trunk
[EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
https://bugs.webkit.org/show_bug.cgi?id=97087
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-20
Reviewed by Gyuyoung Kim.
Tools:
Add focusing a main frame on settings reset.
After editing/undo/undo-iframe-location-change was executed a frame
was left in unfocused state. This caused flakiness in two tests results.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
LayoutTests:
Remove two flaky tests from TestExpectations as they pass after setting focus
on settings reset.
- platform/efl-wk1/TestExpectations:
- 2:52 AM BadContent edited by
- Add 12 spammers to the BadContent list. (diff)
- 1:47 AM Changeset in webkit [129109] by
-
- 3 edits in trunk/LayoutTests
[EFL] Rebaseline after r129074
https://bugs.webkit.org/show_bug.cgi?id=97181
Unreviewed rebaseline.
Following tests are rebased after r129074
svg/W3C-I18N/text-dirRTL-ubNone.svg
svg/W3C-I18N/tspan-direction-rtl.svg
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-20
- platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
- 1:44 AM Changeset in webkit [129108] by
-
- 4 edits in trunk/Source/WebCore
[TouchAdjustment] Simplify and improve hybrid distance function.
https://bugs.webkit.org/show_bug.cgi?id=96519
Reviewed by Antonio Gomes.
The current distance function is a combination of two functions. One measuring the distance from
the hot-spot in the touch-area to the centerline of the target, and one measuring how much of the
target is covered.
The distance to the center-line was used instead of just the distance to the target, to make it
easier to hit small targets near big targets. The very same feature is however also the reason
measuring how much the target is covered is added. Using the distance to center-line is therefore
redundant now, and can be replaced with the simpler 'distance the hot-spot needs to be adjusted'.
Tested by existing touchadjustment tests.
- page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::hybridDistanceFunction):
- platform/graphics/IntRect.cpp:
- platform/graphics/IntRect.h:
(IntRect):
- 1:42 AM BadContent edited by
- Add three spammers to the BadContent list. (diff)
- 1:41 AM Changeset in webkit [129107] by
-
- 6 edits in trunk/Source/WebCore
[Forms] HTMLSelectElement should call formStateDidChange on both menulist and lisbox mode
https://bugs.webkit.org/show_bug.cgi?id=97177
Reviewed by Kent Tamura.
This patch makes listbox mode select element to call formStateDidChange()
when selected options are changed.
For this change, this patch moves notifyFormStateChanged() to
HTMLFormControlElementWithState class from HTMLTextFormControlElement
for sharing code HTMLSelectElement class and HTMLInputElement/HTMLTextAreaElement
derived from HTMLTextFormControlElement.
No new tests. We can't test this change in WebKit test tools. Test script
will be implemented in Chromium side.
- html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::notifyFormStateChanged):
(WebCore):
- html/HTMLFormControlElementWithState.h: Moved a declaration of notifyFormStateChanged() from HTMLTextFormControlElement.
(HTMLFormControlElementWithState): Moved an implemented of notifyFormStateChanged() from HTMLTextFormControlElement.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectOption): Changed to call notifyFormStateChanged() instead of formStateDidChange().
(WebCore::HTMLSelectElement::updateListBoxSelection): Changed to call notifyFormStateChanged().
- html/HTMLTextFormControlElement.cpp: Moved an implemented of notifyFormStateChanged() to HTMLFormControlElementWithState class.
- html/HTMLTextFormControlElement.h: Moved a declaration of notifyFormStateChanged() to HTMLFormControlElementWithState class.
- 1:41 AM WebInspector edited by
- Removing spam. (diff)
- 1:40 AM WebKitIDL edited by
- Removing spam. (diff)
- 1:36 AM Drosera edited by
- Removing spam. (diff)
- 1:35 AM Changeset in webkit [129106] by
-
- 3 edits2 adds in trunk
REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
https://bugs.webkit.org/show_bug.cgi?id=97166
Reviewed by Kent Tamura.
Source/WebCore:
Fixing bug in r127727 so arrow keys work properly.
Test: fast/forms/date/calendar-picker-key-operations.html
- Resources/pagepopups/calendarPicker.js:
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
LayoutTests:
- fast/forms/date/calendar-picker-key-operations-expected.txt: Added.
- fast/forms/date/calendar-picker-key-operations.html: Added.
- 1:33 AM Changeset in webkit [129105] by
-
- 12 edits in trunk/Source/WebCore
Web Inspector: Use and process the actual ScriptId in the protocol EventListener object
https://bugs.webkit.org/show_bug.cgi?id=93271
Reviewed by Yury Semikhatsky.
- Use the actual script identifier in the "location" object's "scriptId" field for the DOM.EventListener protocol type, but send the script URL in the new "sourceName" field.
- Use 0-based lines in the "location" object's "lineNumber" field for linkifyRawLocation() to work correctly.
- Fixed formatting of links to listener locations to contain "(program)" rather than empty string.
- bindings/js/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerLocation):
- bindings/js/ScriptEventListener.h:
(WebCore):
- bindings/v8/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerLocation):
- bindings/v8/ScriptEventListener.h:
(WebCore):
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
- inspector/front-end/BreakpointsSidebarPane.js:
- inspector/front-end/EventListenersSidebarPane.js:
- inspector/front-end/Linkifier.js:
(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):
- inspector/front-end/ResourceUtils.js:
(WebInspector.formatLinkText): Use "(program)" if URL is empty.
- 1:31 AM Changeset in webkit [129104] by
-
- 4 edits in trunk/LayoutTests
[EFL] Rebaseline after r129050
https://bugs.webkit.org/show_bug.cgi?id=97180
Unreviewed rebaseline.
Rebase of following tests after r129050
fast/text/atsui-multiple-renderers.html
fast/text/atsui-spacing-features.html
fast/text/wide-zero-width-space.html
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-20
- platform/efl/fast/text/atsui-multiple-renderers-expected.txt:
- platform/efl/fast/text/atsui-spacing-features-expected.txt:
- platform/efl/fast/text/wide-zero-width-space-expected.txt:
- 1:24 AM Drosera edited by
- (diff)
- 1:22 AM Changeset in webkit [129103] by
-
- 3 edits in trunk/LayoutTests
[Qt][WK2] fast/spatial-navigation/snav-media-elements.html timeouts
https://bugs.webkit.org/show_bug.cgi?id=96397
Reviewed by Antonio Gomes.
Use the js-test-post.js as intended to protect against race-conditions.
- fast/spatial-navigation/snav-media-elements.html:
- platform/qt-5.0-wk2/Skipped:
- 1:19 AM Changeset in webkit [129102] by
-
- 6 edits in trunk
[Qt] Add eventSender.gestureTap
https://bugs.webkit.org/show_bug.cgi?id=66173
Patch by Allan Sandfeld Jensen <allan.jensen@digia.com> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.
Tools:
Implement support for sending raw QGesture events.
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::gestureTap):
- DumpRenderTree/qt/EventSenderQt.h:
(EventSender):
LayoutTests:
Change test to only being skipped in Qt WebKit2.
- platform/qt-5.0-wk2/Skipped:
- platform/qt/Skipped:
- 1:14 AM Changeset in webkit [129101] by
-
- 12 edits in trunk/Source
[EFL] Change the log macro names to be more consistent with EINA LOG
https://bugs.webkit.org/show_bug.cgi?id=97158
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit/efl:
Some log macro names in WebKit1 are inconsistent with EINA LOG names
such as WRN/INF not WARN/INFO.
#define WRN(...) EINA_LOG_DOM_WARN(_ewk_log_dom, VA_ARGS)
#define INF(...) EINA_LOG_DOM_INFO(_ewk_log_dom, VA_ARGS)
This patch changes the such names to be consistent with EINA LOG's names.
- ewk/ewk_frame.cpp:
(_ewk_frame_smart_resize):
(ewk_frame_source_get):
(ewk_frame_uri_changed):
- ewk/ewk_main.cpp:
(_ewk_init_body):
- ewk/ewk_private.h:
- ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_render):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(ewk_tiled_backing_store_pre_render_relative_radius):
- ewk/ewk_tiled_matrix.cpp:
(ewk_tile_matrix_free):
(ewk_tile_matrix_tile_exact_get):
(_ewk_tile_matrix_slicer_setup):
- ewk/ewk_view.cpp:
(_ewk_view_smart_add_console_message):
(_ewk_view_smart_run_javascript_alert):
(_ewk_view_smart_run_javascript_confirm):
(_ewk_view_smart_should_interrupt_javascript):
(_ewk_view_smart_run_javascript_prompt):
(_ewk_view_smart_pre_render_region):
(_ewk_view_smart_pre_render_relative_radius):
(_ewk_view_smart_pre_render_start):
(_ewk_view_smart_pre_render_cancel):
(_ewk_view_smart_disable_render):
(_ewk_view_smart_enable_render):
(ewk_view_bg_color_set):
(ewk_view_zoom_set):
(ewk_view_zoom_weak_set):
(ewk_view_zoom_animated_set):
(ewk_view_statusbar_text_set):
(ewk_view_exceeded_application_cache_quota):
(ewk_view_exceeded_database_quota):
(ewk_view_scroll):
(ewk_view_popup_new):
(ewk_view_popup_destroy):
(ewk_view_popup_selected_set):
(ewk_view_color_chooser_new):
(ewk_view_color_chooser_destroy):
(ewk_view_color_chooser_color_set):
(ewk_view_color_chooser_changed):
(ewk_view_zoom_range_set):
- ewk/ewk_view_private.h:
Source/WebKit2:
Some log macro names in WebKit2 are inconsistent with EINA LOG names
such as WRN/INF not WARN/INFO.
#define WRN(...) EINA_LOG_DOM_WARN(_ewk_log_dom, VA_ARGS)
#define INF(...) EINA_LOG_DOM_INFO(_ewk_log_dom, VA_ARGS)
This patch changes the such names to be consistent with EINA LOG's names.
- UIProcess/API/efl/ewk_main.cpp:
(ewk_init):
- UIProcess/API/efl/ewk_private.h:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_webprocess_crashed):
- 1:01 AM Changeset in webkit [129100] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Mark http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html
as flaky.
- platform/chromium/TestExpectations:
- 12:16 AM Changeset in webkit [129099] by
-
- 6 edits1 add in trunk/Source/WebKit2
[EFL][WK2] Same page navigation does not update view URI
https://bugs.webkit.org/show_bug.cgi?id=97094
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.
Handle didSameDocumentNavigationForFrame callback in
WKPageLoaderClient in order to update the view URI.
This fixes issues with the view URI not being updated
in case of a same page navigation.
- UIProcess/API/efl/ewk_view_loader_client.cpp:
(didSameDocumentNavigationForFrame):
(ewk_view_loader_client_attach):
- UIProcess/API/efl/ewk_view_private.h:
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(CallbackDataTimer):
(EWK2UnitTest::CallbackDataTimer::CallbackDataTimer):
(EWK2UnitTest::CallbackDataTimer::~CallbackDataTimer):
(EWK2UnitTest::CallbackDataTimer::isDone):
(EWK2UnitTest::CallbackDataTimer::setDone):
(EWK2UnitTest::CallbackDataTimer::didTimeOut):
(EWK2UnitTest::CallbackDataTimer::setTimedOut):
(EWK2UnitTest):
(CallbackDataExpectedValue):
(EWK2UnitTest::CallbackDataExpectedValue::CallbackDataExpectedValue):
(EWK2UnitTest::CallbackDataExpectedValue::expectedValue):
(EWK2UnitTest::onLoadFinished):
(EWK2UnitTest::timeOutWhileWaitingUntilLoadFinished):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilLoadFinished):
(EWK2UnitTest::onTitleChanged):
(EWK2UnitTest::timeOutWhileWaitingUntilTitleChangedTo):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTitleChangedTo):
(EWK2UnitTest::onURIChanged):
(EWK2UnitTest::timeOutWhileWaitingUntilURIChangedTo):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilURIChangedTo): Add convenience function to test
framework in order to wait until the view URI changes to a given value.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
- UIProcess/API/efl/tests/resources/same_page_navigation.html: Added.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F): Add corresponding unit test to verify fix and prevent regressions
in the future.
Sep 19, 2012:
- 11:56 PM Changeset in webkit [129098] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip JS tests that are no longer crashing after r129065
https://bugs.webkit.org/show_bug.cgi?id=97174
Unreviewed EFL gardening.
Unskip several JS tests that are no longer crashing now that
the fix has landed.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
- platform/efl/TestExpectations:
- 11:55 PM Changeset in webkit [129097] by
-
- 15 edits in trunk/Source
Source/WebCore: WebCore part of adding a setting and API for disabling screen font substitution
https://bugs.webkit.org/show_bug.cgi?id=97168
Reviewed by Tim Horton.
- WebCore.exp.in: Added an entry for Settings::setScreenFontSubstitutionEnabled.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use printer fonts if
screen font substitution is not enabled.
- page/Settings.cpp:
(WebCore::Settings::Settings): Added initializer for new m_screenFontSubstitutionEnabled
member variable. The initial value is true, matching existing behavior.
(WebCore::Settings::setScreenFontSubstitutionEnabled): Added this setter, which updated the
member variable and forces a style recalc in all pages using this Settings.
- page/Settings.h:
(Settings): Added m_screenFontSubstitutionEnabled boolean member variable.
(WebCore::Settings::screenFontSubstitutionEnabled): Added this getter.
Source/WebKit/mac: WebKit/mac part of adding a setting and API for disabling screen font substitution
https://bugs.webkit.org/show_bug.cgi?id=97168
Reviewed by Tim Horton.
- WebView/WebPreferenceKeysPrivate.h: Defined WebKitScreenFontSubstitutionEnabledKey.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Added a default value of YES for the new preference key.
(-[WebPreferences setScreenFontSubstitutionEnabled:]): Added this setter.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Added a call to Settings::setScreenFontSubstitutionEnabled
to push the preference down to Settings.
Source/WebKit2: WebKit2 part of adding a setting and API for disabling screen font substitution
https://bugs.webkit.org/show_bug.cgi?id=97168
Reviewed by Tim Horton.
- Shared/WebPreferencesStore.h:
(WebKit): Defined ScreenFontSubstitutionEnabled key with a default value of true.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetScreenFontSubstitutionEnabled): Added this setter.
(WKPreferencesGetScreenFontSubstitutionEnabled): Added this getter.
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Added a call to Settings::setScreenFontSubstitutionEnabled
to push the preference into Settings.
- 11:52 PM Changeset in webkit [129096] by
-
- 68 edits in trunk/Source
Fix unused parameter compile warnings in WebKit/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=96742
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-19
Reviewed by Gyuyoung Kim.
Source/WebKit/efl:
Fix unused parameter compile warning messages(-Wunused-parameter) in WebKit during EFL build.
WebCore's warning messages were fixed in r128570.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::createWindow):
(WebCore::ChromeClientEfl::mouseDidMoveOverElement):
(WebCore::ChromeClientEfl::print):
(WebCore::ChromeClientEfl::reachedMaxAppCacheSize):
(WebCore::ChromeClientEfl::invalidateContents):
(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore::ChromeClientEfl::invalidateContentsAndRootView):
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::handleInputMethodKeydown):
(WebCore::EditorClientEfl::getGuessesForWord):
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveAuthenticationChallenge):
(WebCore::FrameLoaderClientEfl::dispatchDidCancelAuthenticationChallenge):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::createFrame):
(WebCore::FrameLoaderClientEfl::createJavaAppletWidget):
(WebCore::FrameLoaderClientEfl::shouldStopLoadingForHistoryItem):
(WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML):
(WebCore::FrameLoaderClientEfl::setTitle):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveContentLength):
(WebCore::FrameLoaderClientEfl::dispatchDidLoadResourceFromMemoryCache):
(WebCore::FrameLoaderClientEfl::setMainDocumentError):
- WebCoreSupport/FullscreenVideoControllerEfl.cpp:
(FullscreenVideoController::showHud):
(FullscreenVideoController::setVolume):
(FullscreenVideoController::setCurrentTime):
- WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::notifyWebInspectorDestroy):
(WebCore::InspectorFrontendSettingsEfl::getProperty):
(WebCore::InspectorFrontendSettingsEfl::setProperty):
- WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::getPluginInfo):
- ewk/ewk_auth_soup.cpp:
(ewk_auth_soup_dialog_class_init):
(ewk_auth_soup_dialog_init):
(ewk_auth_soup_dialog_session_feature_init):
(session_authenticate):
- ewk/ewk_file_chooser.cpp:
(ewk_file_chooser_allows_directory_upload_get):
- ewk/ewk_frame.cpp:
(ewk_frame_feed_focus_out):
(ewk_frame_view_state_save):
(ewk_frame_plugin_create):
- ewk/ewk_js.cpp:
(ewk_js_object_new):
(ewk_js_object_free):
(ewk_js_object_view_get):
(ewk_js_object_properties_get):
(ewk_js_object_name_get):
(ewk_js_object_invoke):
(ewk_js_object_type_get):
(ewk_js_object_type_set):
(ewk_js_variant_free):
(ewk_js_variant_array_free):
- ewk/ewk_tiled_model.cpp:
(tile_account):
(_ewk_tile_account_allocated):
(_ewk_tile_account_freed):
- ewk/ewk_view.cpp:
(_ewk_view_smart_add_console_message):
(_ewk_view_smart_run_javascript_alert):
(_ewk_view_smart_run_javascript_confirm):
(_ewk_view_smart_should_interrupt_javascript):
(_ewk_view_smart_run_javascript_prompt):
(_ewk_view_smart_move):
(_ewk_view_smart_contents_resize):
(_ewk_view_editor_command_string_get):
(ewk_view_popup_new):
(ewk_view_js_object_add):
(ewk_view_accelerated_compositing_object_create):
(ewk_view_accelerated_compositing_context_get):
(ewk_view_setting_web_audio_get):
(ewk_view_setting_web_audio_set):
- ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_bg_color_set):
- ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_updates_process_pre):
(_ewk_view_tiled_contents_size_changed_cb):
(_ewk_view_tiled_smart_bg_color_set):
Source/WebKit2:
Fix unused parameter compile warning messages(-Wunused-parameter) in WebKit2 during EFL build.
WebCore's warning messages were fixed in r128570.
- Shared/FontInfo.cpp:
(WebKit::FontInfo::encode):
(WebKit::FontInfo::decode):
- Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
- Shared/SandboxExtension.h:
(WebKit::SandboxExtension::createHandleForTemporaryFile):
- Shared/ShareableSurface.cpp:
(WebKit::ShareableSurface::create):
- Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):
- UIProcess/API/C/WKPage.cpp:
(WKPageGetContentsAsMHTMLData):
- UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetHixie76WebSocketProtocolEnabled):
(WKPreferencesGetHixie76WebSocketProtocolEnabled):
- UIProcess/API/efl/BatteryProvider.cpp:
(startUpdatingCallback):
(stopUpdatingCallback):
- UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::doneWithTouchEvent):
- UIProcess/API/efl/VibrationProvider.cpp:
(vibrateCallback):
(cancelVibrationCallback):
- UIProcess/API/efl/ewk_context_download_client.cpp:
(decideDestinationWithSuggestedFilename):
(didCreateDestination):
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_on_focus_in):
(_ewk_view_on_focus_out):
(_ewk_view_on_mouse_wheel):
(_ewk_view_on_mouse_down):
(_ewk_view_on_mouse_up):
(_ewk_view_on_mouse_move):
(_ewk_view_on_key_down):
(_ewk_view_on_key_up):
(_ewk_view_smart_move):
(ewk_view_contents_size_changed):
- UIProcess/API/efl/ewk_view_find_client.cpp:
(didFindString):
- UIProcess/API/efl/ewk_view_form_client.cpp:
(willSubmitForm):
- UIProcess/API/efl/ewk_view_loader_client.cpp:
(didReceiveIntentForFrame):
(registerIntentServiceForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didChangeBackForwardList):
- UIProcess/API/efl/ewk_view_policy_client.cpp:
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(decidePolicyForResponseCallback):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::update):
(WebKit::DrawingAreaProxy::didUpdateBackingStoreState):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::updateAcceleratedCompositingMode):
- UIProcess/FindIndicator.cpp:
(WebKit::FindIndicator::draw):
- UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision):
- UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::shouldUsePlugin):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::setHTTPPipeliningEnabled):
- UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::supportsFullScreen):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sessionStateData):
(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
- UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::standardUserAgent):
(WebKit::WebPageProxy::getEditorCommandsForKeyEvent):
- WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::didDecideDestination):
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
- WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::didChangePosition):
- WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconDataKnownForIconURL):
(WebKit::WebIconDatabaseProxy::synchronousLoadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::iconDataForIconURL):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyWebArchiveFilteringSubframes):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKAccessibilityRootObject):
(WKAccessibilityFocusedObject):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setGeoLocationPermission):
(WebKit::InjectedBundle::didReceiveMessage):
(WebKit::InjectedBundle::webNotificationID):
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::initialize):
(WebKit::WebNotificationManager::didUpdateNotificationDecision):
(WebKit::WebNotificationManager::didRemoveNotificationDecisions):
(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::notificationIDForTesting):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):
(WebKit::WebNotificationManager::didShowNotification):
(WebKit::WebNotificationManager::didClickNotification):
(WebKit::WebNotificationManager::didCloseNotifications):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::addMessageToConsole):
(WebKit::WebChromeClient::contentsSizeChanged):
(WebKit::WebChromeClient::customHighlightRect):
(WebKit::WebChromeClient::paintCustomHighlight):
(WebKit::WebChromeClient::supportsFullScreenForElement):
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::downloadURL):
- WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::dragSourceActionMaskForPoint):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
(WebKit::WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
(WebKit::WebFrameLoaderClient::shouldStopLoadingForHistoryItem):
(WebKit::WebFrameLoaderClient::canShowMIMEType):
(WebKit::WebFrameLoaderClient::canShowMIMETypeAsHTML):
(WebKit::WebFrameLoaderClient::representationExistsForURLScheme):
(WebKit::WebFrameLoaderClient::generatedMIMETypeForURLScheme):
(WebKit::WebFrameLoaderClient::createFrame):
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
(WebKit::WebFrameLoaderClient::registerForIconNotification):
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::drawRect):
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::forceRepaintAsync):
(WebKit::DrawingArea::updateBackingStoreState):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::mouseEvent):
- WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
- WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::forceRepaintAsync):
- WebProcess/WebPage/TapHighlightController.cpp:
(WebKit::TapHighlightController::drawRect):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getWebArchiveOfFrame):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):
- WebProcess/soup/WebKitSoupRequestGeneric.cpp:
(webkitSoupRequestGenericSendFinish):
- WebProcess/soup/WebKitSoupRequestInputStream.cpp:
(webkitSoupRequestInputStreamReadAsync):
(webkitSoupRequestInputStreamReadFinish):
- 11:13 PM Changeset in webkit [129095] by
-
- 2 edits in trunk/Source/WebCore
[Forms] multiple fields time input UI should call notifyFormStateChanged() when value of field is changed
https://bugs.webkit.org/show_bug.cgi?id=97169
Reviewed by Kent Tamura.
This patch makes multiple fields time input UI calls notifyFormStateChanged()
when field value is changed as other input types do.
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
No new tests. We can't test this change in WebKit test tools. Test script
will be implemented in Chromium side.
- html/TimeInputType.cpp:
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged):
- 11:02 PM Changeset in webkit [129094] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r127727): Calendar picker focus ring should be hidden until key event
https://bugs.webkit.org/show_bug.cgi?id=97165
Reviewed by Kent Tamura.
The regression was caused because NoFocusRing class was being removed
from then main element inside resetMain().
No new tests. Covered by calendar-picker-appearance.html.
- Resources/pagepopups/calendarPicker.js:
(initialize):
(CalendarPicker):
(CalendarPicker.prototype._layout):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):
(CalendarPicker.prototype.maybeUpdateFocusStyle): Make this a method of CalendarPicker because we don't use it for other pickers.
- 10:52 PM Changeset in webkit [129093] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations update.
- platform/mac/TestExpectations: Change bug number reference.
- 10:50 PM Changeset in webkit [129092] by
-
- 3 edits1 delete in trunk/Tools
Unreviewed, rolling out r129007.
http://trac.webkit.org/changeset/129007
https://bugs.webkit.org/show_bug.cgi?id=97172
It broke the build on the Qt bots (Requested by Ossy on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-19
- qmake/config.tests/gccdepends/empty.cpp:
- qmake/config.tests/gccdepends/gccdepends.pro:
- qmake/mkspecs/features/default_pre.prf:
- 10:14 PM Changeset in webkit [129091] by
-
- 9 edits in trunk
run-perf-tests should record indivisual value instead of statistics
https://bugs.webkit.org/show_bug.cgi?id=97155
Reviewed by Hajime Morita.
PerformanceTests:
Report the list of values as "values" so that run-perf-tests can parse them.
- resources/runner.js:
(PerfTestRunner.computeStatistics):
(PerfTestRunner.printStatistics):
Tools:
Parse the list of indivisual value reported by tests and include them as "values".
We strip "values" from the output JSON when uploading it to the perf-o-matic
since it doesn't know how to parse "values" or ignore it.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output): Parse and report "values".
(PageLoadingPerfTest.run): Report indivisual page loading time in "values".
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_and_show_results): Strip "values" from each result
until we update perf-o-matic.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_memory_test):
(test_run_with_json_output):
(test_run_with_description):
(test_run_with_slave_config_json):
(test_run_with_multiple_repositories):
LayoutTests:
The expected result now contains indivisual value.
- fast/harness/perftests/runs-per-second-log-expected.txt:
- 9:49 PM Changeset in webkit [129090] by
-
- 160 edits in trunk
IndexedDB: Print console warning about setVersion
https://bugs.webkit.org/show_bug.cgi?id=96575
Reviewed by Tony Chang.
Source/WebCore:
setVersion has been out of the spec for almost a year but there are
still a lot of users.
We show the warning once per database object as an approximation for
once per page.
No new tests, but 150-something rebaselines.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::setVersion):
- Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
LayoutTests:
- http/tests/inspector/indexeddb/database-data-expected.txt:
- http/tests/inspector/indexeddb/database-structure-expected.txt:
- http/tests/inspector/indexeddb/resources-panel-expected.txt:
- storage/indexeddb/create-and-remove-object-store-expected.txt:
- storage/indexeddb/create-object-store-options-expected.txt:
- storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
- storage/indexeddb/createObjectStore-null-name-expected.txt:
- storage/indexeddb/cursor-added-bug-expected.txt:
- storage/indexeddb/cursor-advance-expected.txt:
- storage/indexeddb/cursor-continue-dir-expected.txt:
- storage/indexeddb/cursor-continue-expected.txt:
- storage/indexeddb/cursor-continue-validity-expected.txt:
- storage/indexeddb/cursor-delete-expected.txt:
- storage/indexeddb/cursor-inconsistency-expected.txt:
- storage/indexeddb/cursor-index-delete-expected.txt:
- storage/indexeddb/cursor-key-order-expected.txt:
- storage/indexeddb/cursor-overloads-expected.txt:
- storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
- storage/indexeddb/cursor-primary-key-order-expected.txt:
- storage/indexeddb/cursor-reverse-bug-expected.txt:
- storage/indexeddb/cursor-skip-deleted-expected.txt:
- storage/indexeddb/cursor-update-expected.txt:
- storage/indexeddb/cursor-update-value-argument-required-expected.txt:
- storage/indexeddb/cursor-value-expected.txt:
- storage/indexeddb/data-corruption-expected.txt:
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-close-expected.txt:
- storage/indexeddb/database-closepending-flag-expected.txt:
- storage/indexeddb/database-deletepending-flag-expected.txt:
- storage/indexeddb/delete-closed-database-object-expected.txt:
- storage/indexeddb/delete-range-expected.txt:
- storage/indexeddb/deleteIndex-expected.txt:
- storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
- storage/indexeddb/deleteObjectStore-null-name-expected.txt:
- storage/indexeddb/deleted-objects-expected.txt:
- storage/indexeddb/deletedatabase-transaction-expected.txt:
- storage/indexeddb/duplicates-expected.txt:
- storage/indexeddb/error-causes-abort-by-default-expected.txt:
- storage/indexeddb/exception-in-event-aborts-expected.txt:
- storage/indexeddb/exceptions-expected.txt:
- storage/indexeddb/factory-deletedatabase-expected.txt:
- storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
- storage/indexeddb/get-keyrange-expected.txt:
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics-workers-expected.txt:
- storage/indexeddb/index-count-expected.txt:
- storage/indexeddb/index-cursor-expected.txt:
- storage/indexeddb/index-duplicate-keypaths-expected.txt:
- storage/indexeddb/index-get-key-argument-required-expected.txt:
- storage/indexeddb/index-multientry-expected.txt:
- storage/indexeddb/index-population-expected.txt:
- storage/indexeddb/index-unique-expected.txt:
- storage/indexeddb/intversion-and-setversion-expected.txt:
- storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
- storage/indexeddb/intversion-long-queue-expected.txt:
- storage/indexeddb/invalid-keys-expected.txt:
- storage/indexeddb/key-generator-expected.txt:
- storage/indexeddb/key-sort-order-across-types-expected.txt:
- storage/indexeddb/key-sort-order-date-expected.txt:
- storage/indexeddb/key-type-array-expected.txt:
- storage/indexeddb/key-type-infinity-expected.txt:
- storage/indexeddb/keypath-arrays-expected.txt:
- storage/indexeddb/keypath-basics-expected.txt:
- storage/indexeddb/keypath-edges-expected.txt:
- storage/indexeddb/keypath-fetch-key-expected.txt:
- storage/indexeddb/keypath-intrinsic-properties-expected.txt:
- storage/indexeddb/lazy-index-population-expected.txt:
- storage/indexeddb/legacy-constants-expected.txt:
- storage/indexeddb/list-ordering-expected.txt:
- storage/indexeddb/metadata-expected.txt:
- storage/indexeddb/mozilla/add-twice-failure-expected.txt:
- storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
- storage/indexeddb/mozilla/bad-keypath-expected.txt:
- storage/indexeddb/mozilla/clear-expected.txt:
- storage/indexeddb/mozilla/create-index-unique-expected.txt:
- storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
- storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
- storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
- storage/indexeddb/mozilla/cursor-mutation-expected.txt:
- storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
- storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
- storage/indexeddb/mozilla/cursors-expected.txt:
- storage/indexeddb/mozilla/delete-result-expected.txt:
- storage/indexeddb/mozilla/event-source-expected.txt:
- storage/indexeddb/mozilla/global-data-expected.txt:
- storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
- storage/indexeddb/mozilla/indexes-expected.txt:
- storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
- storage/indexeddb/mozilla/key-requirements-expected.txt:
- storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
- storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
- storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
- storage/indexeddb/mozilla/object-cursors-expected.txt:
- storage/indexeddb/mozilla/object-identity-expected.txt:
- storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
- storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
- storage/indexeddb/mozilla/objectstorenames-expected.txt:
- storage/indexeddb/mozilla/odd-result-order-expected.txt:
- storage/indexeddb/mozilla/put-get-values-expected.txt:
- storage/indexeddb/mozilla/readonly-transactions-expected.txt:
- storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
- storage/indexeddb/mozilla/readyState-expected.txt:
- storage/indexeddb/mozilla/remove-index-expected.txt:
- storage/indexeddb/mozilla/remove-objectstore-expected.txt:
- storage/indexeddb/mozilla/versionchange-abort-expected.txt:
- storage/indexeddb/mozilla/versionchange-expected.txt:
- storage/indexeddb/mutating-cursor-expected.txt:
- storage/indexeddb/noblobs-expected.txt:
- storage/indexeddb/objectStore-required-arguments-expected.txt:
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics-workers-expected.txt:
- storage/indexeddb/objectstore-clear-expected.txt:
- storage/indexeddb/objectstore-count-expected.txt:
- storage/indexeddb/objectstore-cursor-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/odd-strings-expected.txt:
- storage/indexeddb/open-close-version-expected.txt:
- storage/indexeddb/open-cursor-expected.txt:
- storage/indexeddb/open-during-transaction-expected.txt:
- storage/indexeddb/opencursor-key-expected.txt:
- storage/indexeddb/pending-activity-expected.txt:
- storage/indexeddb/pending-activity-workers-expected.txt:
- storage/indexeddb/pending-version-change-on-exit-expected.txt:
- storage/indexeddb/persistence-expected.txt:
- storage/indexeddb/prefetch-bugfix-108071-expected.txt:
- storage/indexeddb/queued-commands-expected.txt:
- storage/indexeddb/readonly-expected.txt:
- storage/indexeddb/readonly-properties-expected.txt:
- storage/indexeddb/request-continue-abort-expected.txt:
- storage/indexeddb/request-event-propagation-expected.txt:
- storage/indexeddb/setVersion-null-expected.txt:
- storage/indexeddb/set_version_blocked-expected.txt:
- storage/indexeddb/set_version_queue-expected.txt:
- storage/indexeddb/structured-clone-expected.txt:
- storage/indexeddb/three-setversion-calls-expected.txt:
- storage/indexeddb/transaction-abort-expected.txt:
- storage/indexeddb/transaction-active-flag-expected.txt:
- storage/indexeddb/transaction-after-close-expected.txt:
- storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
- storage/indexeddb/transaction-basics-expected.txt:
- storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
- storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
- storage/indexeddb/transaction-complete-workers-expected.txt:
- storage/indexeddb/transaction-crash-on-abort-expected.txt:
- storage/indexeddb/transaction-error-expected.txt:
- storage/indexeddb/transaction-event-propagation-expected.txt:
- storage/indexeddb/transaction-read-only-expected.txt:
- storage/indexeddb/transaction-rollback-expected.txt:
- storage/indexeddb/transaction-storeNames-required-expected.txt:
- storage/indexeddb/tutorial-expected.txt:
- storage/indexeddb/two-version-changes-expected.txt:
- storage/indexeddb/value-undefined-expected.txt:
- storage/indexeddb/values-odd-types-expected.txt:
- storage/indexeddb/version-change-abort-expected.txt:
- storage/indexeddb/version-change-exclusive-expected.txt:
- storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
- 9:44 PM Changeset in webkit [129089] by
-
- 8 edits in trunk/Source
OSR exit sometimes neglects to create the arguments object
https://bugs.webkit.org/show_bug.cgi?id=97162
Reviewed by Filip Pizlo.
No performance change.
I don't know of any case where this is a real problem in TOT, but it
will become a problem if we start compiling eval, with, or catch, and/or
sometimes stop doing arguments optimizations in the bytecode.
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run): Account for a
CreateArguments that has transformed into PhantomArguments. We used to
clear our reference to the CreateArguments node, but now we hold onto it,
so we need to account for it transforming.
Don't replace a SetLocal(CreateArguments) with a SetLocal(JSValue())
because that doesn't leave enough information behind for OSR exit to do
the right thing. Instead, maintain our reference to CreateArguments, and
rely on CreateArguments transforming into PhantomArguments after
optimization. SetLocal(PhantomArguments) is efficient, and it's a marker
for OSR exit to create the arguments object.
Don't ASSERT that all PhantomArguments are unreferenced because we now
leave them in the graph as SetLocal(PhantomArguments), and that's harmless.
- dfg/DFGArgumentsSimplificationPhase.h:
(NullableHashTraits):
(JSC::DFG::NullableHashTraits::emptyValue): Export our special hash table
for inline call frames so the OSR exit compiler can use it.
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit): Don't load the 'arguments'
register to decide if we need to create the arguments object. Optimization
may have eliminated the initializing store to this register, in which
case we'll load garbage. Instead, use the global knowledge that all call
frames that optimized out 'arguments' now need to create it, and use a hash
table to make sure we do so only once per call frame.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): SetLocal(PhantomArguments) is unique
because we haven't just changed a value's format or elided a load or store;
instead, we've replaced an object with JSValue(). We could try to account
for this in a general way, but for now it's a special-case optimization,
so we give it a specific OSR hint instead.
../WTF:
- wtf/HashTraits.h:
(NullableHashTraits):
(WTF::NullableHashTraits::emptyValue):
(WTF):
- 9:27 PM Changeset in webkit [129088] by
-
- 2 edits5 adds in trunk/LayoutTests
Add partial load test for PNG images with no alpha
https://bugs.webkit.org/show_bug.cgi?id=96064
Reviewed by Simon Fraser.
Partial load test for a PNG image with no alpha: receive a partial number of image
bytes and stall forever. The partial image should be decoded and drawn and the green
<img> background should be visible.
- fast/images/resources/lenna.png: Added: this PNG image has no alpha.
- http/tests/images/png-partial-load-no-alpha-expected.png: Added.
- http/tests/images/png-partial-load-no-alpha-expected.txt: Added.
- http/tests/images/png-partial-load-no-alpha.html: Added.
- platform/chromium/http/tests/images/png-partial-load-no-alpha-expected.png: Added.
- platform/mac/TestExpectations: Add an IMAGE failure for the mac port.
- 7:34 PM Changeset in webkit [129087] by
-
- 7 edits in trunk/Source
[BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
https://bugs.webkit.org/show_bug.cgi?id=96362
Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-09-19
Reviewed by Rob Buis.
Source/WebCore:
This patch enable reading credentials from the persistent credential storage
when it is not private browsing mode and there is not a credential in the RAM
for the requested resource.
Since we don't load persistent stored credentials into RAM at the starting time,
even we have saved the credentials at the last browsing, after restarting the browser,
it will still challenge for credentials for the requesting resources.
No new tests, it uses the original authentication tests. There is no way to
clear all credentials or restarting browsers to test this feature.
- platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::getProtectionSpace):
(WebCore):
- platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
Source/WebKit/blackberry:
Make the FrameLoaderClient use credential storage according to the macro
BLACKBERRY_CREDENTIAL_PERSIST
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
(WebCore):
- WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
- 7:07 PM Changeset in webkit [129086] by
-
- 9 edits in trunk/Source/WebCore
[Refactoring] ButtonInputType of <input> element should have innerElement to make <input> AuthorShadowDOM-ready
https://bugs.webkit.org/show_bug.cgi?id=95939
Reviewed by Dimitri Glazkov.
We had 2 ways to show text in RenderButton. One is to use RenderButton::setText() and the other is to add renderer
as a child of RenderButton. <input type="button"> used the former one, and <button> used the latter one.
The former makes RenderButton a bit messy, and also prevents from making <input> AuthorShadowDOM ready.
So we remove RenderButton::setText() and refactor <input type="button"> to use a Shadow DOM to show text.
Since the text in <input type="button"> should create RenderTextFragment, we introduce TextForButtonInputType
class. RenderText will allow us to select the inner text of <input>, but it should not.
No new tests, existing tests should cover the change.
- html/BaseButtonInputType.cpp:
(TextForButtonInputType): Special Text node which creates RenderTextFragment.
(WebCore):
(WebCore::TextForButtonInputType::create):
(WebCore::TextForButtonInputType::TextForButtonInputType):
(WebCore::TextForButtonInputType::createRenderer):
(WebCore::BaseButtonInputType::BaseButtonInputType):
(WebCore::BaseButtonInputType::createShadowSubtree):
(WebCore::BaseButtonInputType::destroyShadowSubtree):
(WebCore::BaseButtonInputType::valueAttributeChanged): When a button value is changed, we reflect the value to
the text node in ShadowDOM.
- html/BaseButtonInputType.h:
(BaseButtonInputType):
- html/FileInputType.cpp:
(WebCore::UploadButtonElement::create): Creates Shadow DOM subtree.
(WebCore::UploadButtonElement::createForMultiple): Creates Shadow DOM subtree.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
- html/InputType.cpp:
(WebCore::InputType::valueAttributeChanged):
(WebCore):
- html/InputType.h:
(InputType):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::styleDidChange): Removed unnecessary text related code.
- rendering/RenderButton.h:
(RenderButton):
- 7:05 PM Changeset in webkit [129085] by
-
- 2 edits in trunk/Source/WebKit/chromium
Remove webkitPostMessage
https://bugs.webkit.org/show_bug.cgi?id=96577
Reviewed by Ojan Vafai.
Actually disable webkitPostMessage. See
http://trac.webkit.org/changeset/128658 for more information.
- features.gypi:
- 7:05 PM Changeset in webkit [129084] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Get infinite amount of requests after attempting re-authentication basic.
https://bugs.webkit.org/show_bug.cgi?id=96994
Reviewed by Rob Buis.
We should remove the wrong credentials before calling sendRequestWithCredentials again.
#PR 200226
Reviewed internally by Jonathan Dong.
No new tests. It is covered by ManualTests/blackberry/http-auth-challenge.html.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):
- 6:52 PM Changeset in webkit [129083] by
-
- 2 edits in trunk/Tools
Fix regex groups for bug matching in flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=97152
Unreviewed, build fix.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(htmlForBugs):
- 6:41 PM Changeset in webkit [129082] by
-
- 6 edits in trunk/Source/WebCore
Remove Blob.webkitSlice
https://bugs.webkit.org/show_bug.cgi?id=96715
Reviewed by Darin Fisher.
Based on these usage metrics, it appears that it is safe to remove
Blob.webkitSlice. Folks that were previously calling webkitSlice should
just call slice instead. They do the same thing.
Ratio of Blob.webkitSlice calls to Blob.slice: 14.87%
Ratio of Blob.webkitSlice calls to Document creation: 0.0053%
- fileapi/Blob.cpp:
(WebCore::Blob::slice):
- fileapi/Blob.h:
(Blob):
- fileapi/Blob.idl:
- fileapi/File.h:
(File):
- inspector/front-end/FileUtils.js:
(WebInspector.ChunkedFileReader.prototype._loadChunk):
- 6:34 PM Changeset in webkit [129081] by
-
- 2 edits in trunk/Tools
nrwt: print unexpected results using new TestExpectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97159
Unreviewed, build fix.
Change new-run-webkit-tests to print out failures using the new
syntax when there are unexpected results, e.g.:
52 tests ran as expected, 19 didn't:
Regressions: Unexpected failures : (2)
failures/flaky/text.html [ Failure ]
failures/unexpected/text-image-checksum.html [ Failure ]
and so forth
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._print_unexpected_results):
- 6:22 PM TestExpectations edited by
- note that the new syntax is now being used. (diff)
- 6:13 PM Changeset in webkit [129080] by
-
- 3 edits in trunk/Tools
update flakiness dashboard after cutover to new test expectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97152
Unreviewed, build fix.
Handle (??) the new Bug notations as well. Hopefully we don't
still need the old ones.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(filterBugs):
(htmlForBugs):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- 5:59 PM Changeset in webkit [129079] by
-
- 3 edits in trunk/Tools
update flakiness dashboard after cutover to new test expectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97152
Reviewed by Ryosuke Niwa.
This change clones the TestExpectation parsing state machine
from python into javascript.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(parsedExpectations.lines.forEach):
(parsedExpectations):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- 5:58 PM Changeset in webkit [129078] by
-
- 11 edits in trunk/Source/WebCore
The collapsing border code needs direction-aware border getters
https://bugs.webkit.org/show_bug.cgi?id=96710
Reviewed by Ojan Vafai.
This refactoring is needed to extend our collapsing border support for mixed directionality
at the table cell level (we currently wrongly ignore any direction below the row-group). For
now, the new helpers are dumb and return exactly the old result but they will be made
direction-aware in a follow-up change.
Refactoring covered by existing tests.
- rendering/RenderBox.h:
(WebCore::RenderBox::hasSameDirectionAs):
Added this helper function. For now, it's only used to compare against
the table direction but we will reuse it to compare the current cell
direction against the other table parts.
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Transitioned those 2 functions to using the new direction-aware functions.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::tableStartBorderAdjoiningCell):
(WebCore::RenderTable::tableEndBorderAdjoiningCell):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):
- rendering/RenderTableSection.h:
(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
Updated those call sites to use RenderBox::hasSameDirectionAs.
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::borderAdjoiningNextCell):
(WebCore::RenderTableCell::borderAdjoiningPreviousCell):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::borderAdjoiningCellStartBorder):
(WebCore::RenderTableCol::borderAdjoiningCellEndBorder):
(WebCore::RenderTableCol::borderAdjoiningCellBefore):
(WebCore::RenderTableCol::borderAdjoiningCellAfter):
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::borderAdjoiningStartCell):
(WebCore::RenderTableRow::borderAdjoiningEndCell):
- rendering/RenderTableRow.h:
(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::borderAdjoiningStartCell):
(WebCore::RenderTableSection::borderAdjoiningEndCell):
New direction-aware functions. Added some ASSERT to ensure
we don't call them with the wrong parameters.
- 5:41 PM Changeset in webkit [129077] by
-
- 2 edits in trunk/Source/WebCore
[V8] ScriptController::compileAndRunScript() can crash
https://bugs.webkit.org/show_bug.cgi?id=96567
Reviewed by Adam Barth.
See chromium bug: http://code.google.com/p/chromium/issues/detail?id=146776
The root cause is that v8::PreCompile() can return 0 when the stack of
V8's parser overflows (c.f. http://code.google.com/codesearch#OAMlx_jo-ck/src/v8/src/parser.cc&exact_package=chromium&q=kPreParseStackOverflow&type=cs&l=6021).
This patch adds the 0 check to the caller side. Given that precompileScript()
is just trying to speculatively precompile a script, it's OK to give up
precompiling for such edge cases.
Manually tested with the html generated by the following shell script:
echo '<script language="JavaScript" type="text/javascript" src="asan-crash.js"></script>' > asan-crash.html
echo 'if(wURLF.search("")>=0) {}' > asan-crash.js
for i inseq 14830
do
echo 'else if(wURLF.search("")>=0) {}' >> asan-crash.js
done
I didn't add the test because '14380' depends on an environment
and because we don't want to add a huge html test.
- bindings/v8/ScriptSourceCode.cpp:
(WebCore::ScriptSourceCode::precompileScript):
- 5:12 PM Changeset in webkit [129076] by
-
- 3 edits in trunk/Source/WebCore
IndexedDB: Pending call cleanup
https://bugs.webkit.org/show_bug.cgi?id=96952
Reviewed by Tony Chang.
Replace RefPtr usage with OwnPtr for PendingXXXCalls (since they're never referenced twice)
and replace queue of "second half open" calls with a single item.
No new tests - no functional changes.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::close):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- 5:06 PM Changeset in webkit [129075] by
-
- 18 edits in trunk/LayoutTests
Attempt to unskip some tests by removing them from the Skipped list.
Added new baselines for those that need them.
- platform/mac/Skipped:
- platform/mac/fast/block/float/float-in-float-hit-testing-expected.txt:
- platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
- platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt:
- platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
- platform/mac/fast/layers/video-layer-expected.txt:
- platform/mac/fast/table/cell-pref-width-invalidation-expected.txt:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/mac/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
- platform/mac/media/video-empty-source-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2123-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2509-expected.txt:
- platform/mac/tables/mozilla/bugs/bug34176-expected.txt:
- platform/mac/tables/mozilla/bugs/bug44505-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- 5:00 PM Changeset in webkit [129074] by
-
- 3 edits in trunk/Source/WebCore
[Chromium] Improve glyph positioning of HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=97093
Reviewed by Tony Chang.
For proper positioning, HarfBuzzShaper requires the positions(offsets and advance)
of the previous glyph. This mean we need to shape all HarfBuzzRuns before glyph positioning.
Collect and shape HarfBuzzRuns, then set positions of glyphs.
No new tests. Tests that uses spacing for complex text (e.g. fast/text/atsui-negative-spacing-features.html)
should close in the expectations. (not the identical, maybe there are subtle differences between
harfbuzz old and harfbuzz ng)
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult): Allocate m_offsets.
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions): Renamed and set offset too.
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::shape): Call fillGlyphBuffer() if we need to fill glyphBuffer.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Removed glyph positioning code.
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun): Ditto.
(WebCore::HarfBuzzShaper::fillGlyphBufferFromHarfBuzzRun): Added.
(WebCore):
(WebCore::HarfBuzzShaper::fillGlyphBuffer): Added.
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::offsets): Added.
(WebCore::HarfBuzzShaper::HarfBuzzRun::glyphToCharacterIndexes): Added.
(HarfBuzzShaper):
- 4:59 PM Changeset in webkit [129073] by
-
- 2 edits in trunk/Tools
Add backer@chromium.org as contributor
https://bugs.webkit.org/show_bug.cgi?id=97150
- Scripts/webkitpy/common/config/committers.py:
- 4:58 PM Changeset in webkit [129072] by
-
- 2 edits in trunk/LayoutTests
[chromium] Fix expectation conflict on fast/hidpi/video-controls-in-hidpi.html
Unreviewed, exepectations change.
- platform/chromium/TestExpectations:
- 4:55 PM Changeset in webkit [129071] by
-
- 2 edits in trunk/LayoutTests
Fix v8 bug urls after syntax conversion
Unreviewed, expectations change.
- platform/chromium/TestExpectations:
- 4:53 PM Changeset in webkit [129070] by
-
- 4 edits3 adds in trunk
[Chromium] Disable resource load scheduling
https://bugs.webkit.org/show_bug.cgi?id=97131
Reviewed by Nate Chapin.
Source/WebCore:
We'll use Chrome's network stack for scheduling instead.
No new tests.
- loader/ResourceLoadScheduler.cpp:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload):
LayoutTests:
The preload scanner loads resources sooner and these tests are affected.
- platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
- platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Added.
- 4:49 PM Changeset in webkit [129069] by
-
- 9 edits in trunk
fix MISSING after TestExpectations conversion
https://bugs.webkit.org/show_bug.cgi?id=97148
Tools:
Unreviewed, expectations change / build fix.
- Scripts/convert-test-expectations:
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
LayoutTests:
Unreviewed, expectations change.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-4.8/TestExpectations:
- platform/qt-mac/TestExpectations:
- 4:37 PM Changeset in webkit [129068] by
-
- 3 edits2 adds in trunk
When kerning is enabled, word spacing is doubly accounted for in RenderText::computePreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=97146
Reviewed by Anders Carlsson.
Source/WebCore:
Test: fast/text/word-space-with-kerning.html
- rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths): When kerning is enabled, words are
measured with their trailing space, if there is one, then the width of a space is subtracted.
Changed that width, stored in the local variable wordTrailingSpaceWidth, to include the
word spacing, since it is included in the result of widthFromCache().
LayoutTests:
- fast/text/word-space-with-kerning-expected.html: Added.
- fast/text/word-space-with-kerning.html: Added.
- 4:29 PM Changeset in webkit [129067] by
-
- 2 edits in trunk/LayoutTests
Fix lines missed (??) in mac-wk2/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97143
Unreviewed, expectations change.
- platform/mac-wk2/TestExpectations:
- 4:27 PM Changeset in webkit [129066] by
-
- 13 edits in trunk/Source
IndexedDB: Remove "current transaction" concept from backing store
https://bugs.webkit.org/show_bug.cgi?id=96663
Reviewed by Tony Chang.
Source/WebCore:
IndexedDB should allow multiple transactions to run in parallel within and
across databases within an origin. As an initial step to enabling this, the
backing store should not hold a "current transaction" - instead, operations
should be done relative to a transaction managed by the database.
No new tests - no functional changes.
- Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
(WebCore::IDBDatabaseBackendImpl::setIntVersionInternal):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
- Modules/indexeddb/IDBIndexBackendImpl.h:
(IDBIndexBackendImpl):
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
(WebCore):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::clearObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
(WebCore::IDBLevelDBBackingStore::Transaction::Transaction):
(WebCore::IDBLevelDBBackingStore::Transaction::begin):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):
(WebCore::IDBLevelDBBackingStore::Transaction::rollback):
- Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
(WebCore::IDBLevelDBBackingStore::Transaction::levelDBTransaction):
(Transaction):
(WebCore::IDBLevelDBBackingStore::Transaction::levelDBTransactionFrom):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::generateKey):
(WebCore::IDBObjectStoreBackendImpl::updateKeyGenerator):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
Source/WebKit/chromium:
Update fake class with new method signatures.
- tests/IDBFakeBackingStore.h:
- 4:27 PM Changeset in webkit [129065] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r128802): It made some JS tests crash
https://bugs.webkit.org/show_bug.cgi?id=97001
Reviewed by Mark Hahnenberg.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
- 4:25 PM Changeset in webkit [129064] by
-
- 2 edits in trunk/LayoutTests
convert chromium android TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97145
Unreviewed, expectations change.
Files converted with Tools/Scripts/convert-test-expectations.
- platform/chromium-android/TestExpectations:
- 4:23 PM Changeset in webkit [129063] by
-
- 2 edits in trunk/LayoutTests
nrwt: convert chromium TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97139
Reviewed by Ryosuke Niwa.
Actually land the file supposedly landed below :).
- platform/chromium/TestExpectations:
- 4:19 PM Changeset in webkit [129062] by
-
- 4 edits in trunk/LayoutTests
convert apple win TestExpectations files to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97144
Unreviewed, expectations change.
Files converted with Tools/Scripts/convert-test-expectations.
- platform/win-wk2/TestExpectations:
- platform/win-xp/TestExpectations:
- platform/win/TestExpectations:
- 4:17 PM Changeset in webkit [129061] by
-
- 5 edits in trunk/LayoutTests
convert apple mac TestExpectations files to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97143
Unreviewed, expectations change.
Files converted with Tools/Scripts/convert-test-expectations.
- platform/mac-lion/TestExpectations:
- platform/mac-snowleopard/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 4:15 PM Changeset in webkit [129060] by
-
- 4 edits in trunk/LayoutTests
convert Efl TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97142
Unreviewed, expectations change.
Files converted with Tools/Scripts/convert-test-expectations.
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:11 PM Changeset in webkit [129059] by
-
- 3 edits in trunk/LayoutTests
convert Gtk TestExpectations files to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97141
Unreviewed, expectations change.
Files converted with Tools/Scripts/convert-test-expectations.
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 4:02 PM Changeset in webkit [129058] by
-
- 6 edits in trunk/LayoutTests
nrwt: convert Qt TestExpectations to the new format
https://bugs.webkit.org/show_bug.cgi?id=97140
Unreviewed, expectations change.
Files were converted using Tools/Scripts/convert-test-expectations.
- platform/qt-4.8/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-arm/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
- 4:00 PM Changeset in webkit [129057] by
-
- 2 edits1 add in trunk
nrwt: convert chromium TestExpectations to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=97139
Tools:
Reviewed by Ryosuke Niwa.
Add in a file temporarily that does the conversion of
test expectations formats
- Tools/Scripts/convert-test-expectations: Added.
LayoutTests:
Reviewed by Ryosuke Niwa.
This does a wholesale change of the file from
BUGS MODIFIERS : test = EXPECTATIONS
to
Bugs [ Modifiers] test [ Expectations ]
as per the new syntax.
- platform/chromium/TestExpectations:
- 3:53 PM Changeset in webkit [129056] by
-
- 3 edits in trunk/LayoutTests
Unreviewed - remove debugging code from a pair of tests.
During development these tests had their own timers to terminate early
rather than timing out, so partial script output could be seen. Removing,
as it could cause the tests to flake under load.
- storage/indexeddb/lazy-index-population.html:
- storage/indexeddb/resources/cursor-finished.js:
- 3:48 PM Changeset in webkit [129055] by
-
- 3 edits in trunk/Tools
REGRESSION: run-perf-tests no longer reports the total test time
https://bugs.webkit.org/show_bug.cgi?id=97138
Reviewed by Tony Chang.
Report the finished time as a info-level log as opposed to a debug level log.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._run_single_test):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_run_memory_test):
(_test_run_with_json_output):
- 3:43 PM Changeset in webkit [129054] by
-
- 10 edits in trunk
[chromium] Store the contents scale factor in PlatformContextSkia on initialization
https://bugs.webkit.org/show_bug.cgi?id=96137
Patch by Terry Anderson <tdanderson@chromium.org> on 2012-09-19
Reviewed by Stephen White.
Source/WebCore:
When the compositor creates a PlatformContextSkia, the scale on |canvas| will
be equal to the content scale factor (which, without pinch-to-zoom, will be
the same as the device scale factor). Set this value as a member on PlatformContextSkia,
which will be used to correctly render glyphs when hinting is used and the device
scale factor is not 1.
Tests: added two new unit tests.
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setupPaintCommon):
- platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
(WebCore::PlatformContextSkia::setHintingScaleFactor):
(WebCore::PlatformContextSkia::hintingScaleFactor):
Source/WebKit/chromium:
Define SK_SUPPORT_HINTING_SCALE_FACTOR by default. This is also used
for the skia patch here: https://codereview.appspot.com/6506099/.
Also added two new unit tests.
- features.gypi:
- tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore):
(WebCore::HintingScaleCallback::HintingScaleCallback):
(HintingScaleCallback):
(WebCore::HintingScaleCallback::operator()):
(WebCore::TEST_F):
- tests/PlatformContextSkiaTest.cpp:
(WebCore):
(WebCore::TEST):
LayoutTests:
These tests will fail due to a font hinting/rasterization issue with
chromium DRT pixel tests having a page/device scale factor of 2.
See crbug.com/150682.
- platform/chromium/TestExpectations:
- 3:36 PM Changeset in webkit [129053] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG should not assume that a ByVal access is generic just because it was unprofiled
https://bugs.webkit.org/show_bug.cgi?id=97088
Reviewed by Geoffrey Garen.
We were not disambiguating between "Undecided" in the sense that the array profile
has no useful information versus "Undecided" in the sense that the array profile
knows that the access has not executed. That's an important distinction, since
the former form of "Undecided" means that we should consult value profiling, while
the latter means that we should force exit unless the value profiling indicates
that the access must be generic (base is not cell or property is not int).
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::fromObserved):
(JSC::DFG::refineArrayMode):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):
- dfg/DFGArrayMode.h:
(JSC::DFG::canCSEStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):
(JSC::DFG::benefitsFromStructureCheck):
- 3:36 PM Changeset in webkit [129052] by
-
- 7 edits in trunk/Tools
Support new TestExpectations format alongside old one
https://bugs.webkit.org/show_bug.cgi?id=96588
Reviewed by Ojan Vafai.
This patch adds support for actually reading in lines formatted
in the new style, and when we re-serialize/write out the file,
all lines will be written in the new style. Note that reading in
the old style is still supported, and no updates are being made
to the actual TestExpectations files as part of this change.
This change updates most but not all of the unit tests to use
the new syntax. I will update the rest when (or before where
possible) I drop support for the old format.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
(TestExpectationParser._tokenize_line):
(TestExpectationParser._tokenize_line_using_new_format):
(TestExpectationLine.to_string):
(TestExpectationLine._format_line):
(TestExpectations):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_warning):
(SkippedTests.test_skipped_entry_dont_exist):
(NewExpectationSyntaxTests.test_warnings):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
(RebaseliningTest.test_remove):
(RebaseliningTest.test_no_get_rebaselining_failures):
(TestExpectationParserTests.test_tokenize_blank):
(TestExpectationParserTests.test_tokenize_extra_colon):
(TestExpectationParserTests.test_tokenize_missing_equal):
(TestExpectationParserTests.test_tokenize_extra_equal):
(TestExpectationSerializationTests.test_unparsed_to_string):
(TestExpectationSerializationTests.test_unparsed_list_to_string):
(TestExpectationSerializationTests.test_parsed_to_string):
(TestExpectationSerializationTests.test_format_line):
(TestExpectationSerializationTests.test_string_roundtrip):
(TestExpectationSerializationTests.test_list_roundtrip):
(TestExpectationSerializationTests.test_reconstitute_only_these):
(TestExpectationSerializationTests.test_string_whitespace_stripping):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(LintTest.test_lint_test_fileserrors):
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_basic):
(PrintExpectationsTest.test_multiple):
(PrintExpectationsTest.test_full):
(PrintExpectationsTest.test_exclude):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_expectations_noop):
(test_overrides_are_included_correctly):
- 3:29 PM Changeset in webkit [129051] by
-
- 3 edits in trunk/Tools
implement first part of support for the new TestExpectations syntax
https://bugs.webkit.org/show_bug.cgi?id=96569
Reviewed by Ryosuke Niwa.
This patch implements support for parsing a line of the new
format for the TestExpectations file and converting it back into
the old format for compatibility. This routine is not yet used
by anything.
The new format is documented at:
but, in short:
[bugs] [ "modifiers?" ] test_name [ "expectations?" ]
- Comments are indicated with "#" instead of ""
- If no expectations are specified we default to Skip for compatibility with the Skipped files (these two changes make Skipped files a subset of TestExpectations files)
- All of the tokens are now CamelCase instead of ALLCAPS.
- FAIL -> Failure
- IMAGE -> ImageOnlyFailure
- WONTFIX -> WontFix
- modifiers refer to just the platforms and configurations (release/debug) that the line applies to.
- WontFix, Rebaseline, Slow, and Skip move to the right-hand side as expectations
- expectations will typically be written out in lexicographic order
- We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke) instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
(TestExpectationParser._tokenize_line_using_new_format):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(NewExpectationSyntaxTests):
(NewExpectationSyntaxTests.assert_exp):
(NewExpectationSyntaxTests.test_bare_name):
(NewExpectationSyntaxTests.test_bare_name_and_bugs):
(NewExpectationSyntaxTests.test_comments):
(NewExpectationSyntaxTests.test_config_modifiers):
(NewExpectationSyntaxTests.test_unknown_config):
(NewExpectationSyntaxTests.test_unknown_expectation):
(NewExpectationSyntaxTests.test_skip):
(NewExpectationSyntaxTests.test_slow):
(NewExpectationSyntaxTests.test_wontfix):
(NewExpectationSyntaxTests.test_blank_line):
(NewExpectationSyntaxTests.test_warnings):
- 3:29 PM Changeset in webkit [129050] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] HarfBuzzShaper should take into account combining characters
https://bugs.webkit.org/show_bug.cgi?id=97069
Reviewed by Tony Chang.
When dividing a text run into HarfBuzzRuns, try to find suitable SimpleFontData for
combining character sequence if there are one or more mark characters are followed.
If there is no combined glyphs in the font, use fallback font for mark characters.
No new tests.
In platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html,
U+0947 (devanagari vowel sign e) should be displayed.
In fast/text/wide-zero-width-space.html, é and eĭ should look identical.
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore):
(WebCore::fontDataForCombiningCharacterSequence): Added.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns): See above description.
- 3:23 PM Changeset in webkit [129049] by
-
- 2 edits in trunk/Source/WebKit2
Warning in SandboxExtension.h if WEB_PROCESS_SANDBOX is not enabled
https://bugs.webkit.org/show_bug.cgi?id=97137
Reviewed by Benjamin Poulain.
m_size is only used when WEB_PROCESS_SANDBOX is enabled, so move its declaration inside
#if ENABLE(WEB_PROCESS_SANDBOX).
- Shared/SandboxExtension.h:
(HandleArray):
- 3:01 PM Changeset in webkit [129048] by
-
- 2 edits in trunk/Source/WebKit/chromium
Disable some failing IDB tests
https://bugs.webkit.org/show_bug.cgi?id=97135
Reviewed by Nate Chapin.
They were broken in r129037.
- tests/IDBDatabaseBackendTest.cpp:
- 2:51 PM Changeset in webkit [129047] by
-
- 28 edits in trunk
nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
https://bugs.webkit.org/show_bug.cgi?id=96845
Reviewed by Ojan Vafai.
In preparation for the new TestExpectations syntax, we replace
all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
make switching to the new syntax lossless (i.e., we lose
information now, not then).
Tools:
Note that we can still parse in results.json files that have the
old data for backwards compatibility.
- Scripts/webkitpy/common/net/resultsjsonparser.py:
(JSONTestResult._failure_types_from_actual_result):
- Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
(ResultsJSONParserTest):
(test_basic):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_summarized_results_wontfix):
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations):
(TestExpectations.remove_pixel_failures):
(TestExpectations.has_pixel_failures):
(TestExpectations.suffixes_for_expectations):
(TestExpectations.get_rebaselining_failures):
(TestExpectations.remove_configuration_from_test):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(assert_bad_expectations):
(BasicTests):
(BasicTests.test_basic):
(MiscTests):
(MiscTests.test_multiple_results):
(MiscTests.test_result_was_expected):
(MiscTests.test_remove_pixel_failures):
(MiscTests.test_suffixes_for_expectations):
(test_get_expectations_string):
(test_parse_warning):
(test_error_on_different_platform):
(test_error_on_different_build_type):
(test_overrides):
(test_overridesdirectory):
(test_overridesduplicate):
(test_pixel_tests_flag):
(test_more_specific_override_resets_skip):
(SkippedTests.test_skipped_file_overrides_expectations):
(SkippedTests.test_skipped_dir_overrides_expectations):
(SkippedTests.test_skipped_file_overrides_overrides):
(SkippedTests.test_skipped_dir_overrides_overrides):
(ExpectationSyntaxTests.test_missing_colon):
(ExpectationSyntaxTests.test_too_many_equals_signs):
(SemanticTests.test_bug_format):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_missing_bugid):
(SemanticTests.test_rebaseline):
(test_missing_file):
(test_more_modifiers):
(test_order_in_file):
(test_macro_overrides):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
(RebaseliningTest.test_remove):
(TestExpectationSerializationTests.test_serialize_parsed_expectations):
- Scripts/webkitpy/layout_tests/models/test_failures.py:
(determine_result_type):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(test_test_expectations):
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_retrying_and_flaky_tests):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_valid_expectations):
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_basic):
(PrintExpectationsTest.test_multiple):
(PrintExpectationsTest.test_full):
(PrintExpectationsTest.test_exclude):
(PrintExpectationsTest.test_csv):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_does_not_include_overrides):
(test_overrides_are_included_correctly):
LayoutTests:
- platform/chromium-android/TestExpectations:
- platform/chromium/TestExpectations:
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-4.8/TestExpectations:
- platform/qt-arm/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
- 2:47 PM Changeset in webkit [129046] by
-
- 3 edits in trunk/Source/WebCore
Remove RenderIFrame::updateLogicalHeight and RenderIFrame::updateLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=97049
Reviewed by Ojan Vafai.
This is an incremental step in making updateLogicalHeight non-virtual so it's
possible to call computeLogicalHeight on any RenderBox and get the right
version of the function.
The code in RenderIFrame::layout was calling flattenFrame(), which would
query it's bounding box size. Since we hadn't done a layout yet, the size
is unknown. The fix is to only call flattenFrame() after calling
updateLogicalWidth and updateLogicalHeight. We can then fixup the size of
the iframe.
No new tests, existing tests in fast/frames/flattening should continue to pass.
- rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::layout):
- rendering/RenderIFrame.h:
(RenderIFrame):
- 2:43 PM Changeset in webkit [129045] by
-
- 16 edits in trunk/Source/JavaScriptCore
DFG should not emit PutByVal hole case unless it has to
https://bugs.webkit.org/show_bug.cgi?id=97080
Reviewed by Geoffrey Garen.
This causes us to generate less code for typical PutByVal's. But if profiling tells us
that the hole case is being hit, we generate the same code as we would have generated
before. This seems like a slight speed-up across the board.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::store8):
(MacroAssemblerARMv7):
- assembler/MacroAssemblerX86.h:
(MacroAssemblerX86):
(JSC::MacroAssemblerX86::store8):
- assembler/MacroAssemblerX86_64.h:
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::store8):
- assembler/X86Assembler.h:
(X86Assembler):
(JSC::X86Assembler::movb_i8m):
- bytecode/ArrayProfile.h:
(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::addressOfMayStoreToHole):
(JSC::ArrayProfile::mayStoreToHole):
(ArrayProfile):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::fromObserved):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):
- dfg/DFGArrayMode.h:
(DFG):
(JSC::DFG::mayStoreToHole):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JIT.h:
(JIT):
- jit/JITInlineMethods.h:
(JSC::JIT::emitArrayProfileStoreToHoleSpecialCase):
(JSC):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_val):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 2:35 PM Changeset in webkit [129044] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] After zooming into an input field, zoom out when focus is lost.
https://bugs.webkit.org/show_bug.cgi?id=97128
Reviewed by Rob Buis.
When the page has automatically zoomed in for input
focus, unzoom it when input focus is lost or keyboard hidden.
Reviewed Internally by Gen Mak.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 2:10 PM Changeset in webkit [129043] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Clean up the SpellingLog output
https://bugs.webkit.org/show_bug.cgi?id=97129
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-09-19
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- 2:09 PM Changeset in webkit [129042] by
-
- 3 edits in trunk/LayoutTests
[chromium] compositing/geometry/fixed-position-iframe-composited-page-scale-down test needs rebaseline for r129023.
https://bugs.webkit.org/show_bug.cgi?id=97130
Patch by Robert Flack <flackr@chromium.org> on 2012-09-19
Reviewed by Nate Chapin.
Rebaseline compositing/geometry/fixed-position-iframe-composited-page-scale-down.html.
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- 1:52 PM Changeset in webkit [129041] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Fix vertical positioning problem for 'X' in search field
https://bugs.webkit.org/show_bug.cgi?id=97126
Reviewed by Antonio Gomes.
We have the same problem as described in bug 30245, so integrate that code.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::convertToPaintingRect):
(WebCore):
(WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):
- 1:43 PM Changeset in webkit [129040] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add SpellingLog for spell checking options request.
https://bugs.webkit.org/show_bug.cgi?id=97125
Reviewed by Rob Buis.
Add spell checking log to indicate the calculated
text position for spell checking option requests.
Reviewed Internally by Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
- 1:35 PM Changeset in webkit [129039] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Unreviewed. Build fix.
Not building WebImageTest.cpp for component build.
- WebKit.gyp:
- 1:35 PM Changeset in webkit [129038] by
-
- 6 edits3 adds in trunk
IndexedDB: Free up resources used by completed cursors earlier
https://bugs.webkit.org/show_bug.cgi?id=97023
Reviewed by Tony Chang.
Source/WebCore:
Prior to this patch, IDBCursor objects are kept around by their parent
IDBTransaction until the transaction finishes. It's possible to release
references to them earlier, when the cursor has been "run to the end",
as no further events will fire and all calls to continue() etc should fail.
This change tells the cursor it's done when "null" finally comes through in
the IDBRequest, and the cursor then lets transaction know it can be
forgotten.
The added test doesn't distinguish the new behavior, but does exercise
"finished" cursors and apparently we didn't have tests for these before.
Test: storage/indexeddb/cursor-finished.html
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::close): Make idempotent; notify transaction.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess): Tell cursor it's finished before releasing.
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::OpenCursorNotifier::~OpenCursorNotifier):
(WebCore):
(WebCore::IDBTransaction::OpenCursorNotifier::cursorFinished): New method for explicit notification.
- Modules/indexeddb/IDBTransaction.h:
(OpenCursorNotifier):
LayoutTests:
Test to exercise cursor methods after the cursor has been run to the end.
- storage/indexeddb/cursor-finished-expected.txt: Added.
- storage/indexeddb/cursor-finished.html: Added.
- storage/indexeddb/resources/cursor-finished.js: Added.
(test):
(prepareDatabase):
(onDeleteSuccess):
(onUpgradeNeeded):
(onOpenSuccess):
(onCursorSuccess):
- 1:28 PM Changeset in webkit [129037] by
-
- 27 edits1 move2 adds2 deletes in trunk
IndexedDB: fire upgradeneeded even without an explicit integer version
https://bugs.webkit.org/show_bug.cgi?id=96444
Reviewed by Tony Chang.
Source/WebCore:
Also of note:
- New databases now get a default version of 1 instead of
the empty string when they are opened.
- We now allow databases with an integer version to revert to a string
version by calling setVersion.
Implementation detail: we store both an integer version and string
version for a particular database. If both are set we give preference
to the integer version and assume the db is on the integer track.
Test: storage/indexeddb/intversion-two-opens-no-versions.html
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
Now that this can be called even after an int version is set we have
to make it revoke the int version.
(WebCore::IDBDatabaseBackendImpl::openConnection):
Nested ifs were getting deep, so refactor to return early instead.
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::resetVersion):
Now that an int version could have been set before setVersion was
called we have to reset the int version on abort.
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
0 is now a valid integer version to store to leveldb if an idb
database is reverting to a string version.
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
If the open request did not specify an integer version but
upgradeneeded is called, it means the database was given the default
version of 1.
LayoutTests:
Mostly updating expectations about getting an upgradeneeded on a new
database and the default version being 1 instead of "".
- http/tests/inspector/indexeddb/database-structure-expected.txt:
- storage/indexeddb/cursor-overloads-expected.txt:
- storage/indexeddb/cursor-overloads.html:
- storage/indexeddb/dont-commit-on-blocked-expected.txt:
- storage/indexeddb/dont-commit-on-blocked.html:
- storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
- storage/indexeddb/intversion-and-setversion-expected.txt:
Remove test that setVersion fires an error if an int version is set.
Change it to testing that an int version can replace a string version
that replaced an int version.
- storage/indexeddb/intversion-bad-parameters-expected.txt:
- storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt: Removed.
setVersion is no longer invalid so this test can be deleted.
- storage/indexeddb/intversion-omit-parameter-expected.txt:
We now fully pass this test.
- storage/indexeddb/intversion-two-opens-no-versions-expected.txt: Added.
- storage/indexeddb/intversion-two-opens-no-versions.html: Renamed from LayoutTests/storage/indexeddb/intversion-invalid-setversion-has-no-side-effects.html.
- storage/indexeddb/list-ordering-expected.txt:
- storage/indexeddb/noblobs-expected.txt:
- storage/indexeddb/noblobs.html:
- storage/indexeddb/open-during-transaction-expected.txt:
This test had a bug in it AND its behavior is changed. It was trying
to open one database twice and another once but was actually opening
three different databases. The behavior change is that now the
transaction finishes while the last call to open is firing
upgradeneeded.
- storage/indexeddb/pending-activity-expected.txt:
- storage/indexeddb/pending-activity-workers-expected.txt:
- storage/indexeddb/resources/intversion-and-setversion.js:
(deleteSuccess):
(initialUpgradeNeeded):
(openSuccess):
(firstUpgradeNeeded):
(transactionCompleted):
(firstOpenWithVersion):
(secondSetVersionCallback):
(setIntVersion2):
(versionChangeGoingFromStringToInt):
(version2ConnectionBlocked):
(version2ConnectionSuccess):
(errorWhenTryingLowVersion):
- storage/indexeddb/resources/intversion-invalid-setversion-has-no-side-effects.js: Removed.
- storage/indexeddb/resources/intversion-two-opens-no-versions.js: Added.
(test):
(deleteSuccess):
(connection1UpgradeNeeded):
(connection1OpenSuccess):
(connection2UpgradeNeeded):
(connection2OpenSuccess):
- storage/indexeddb/resources/list-ordering.js:
- storage/indexeddb/resources/open-during-transaction.js:
(startTransaction.trans.oncomplete):
(startTransaction):
(tryOpens.openreq3.onsuccess):
(tryOpens):
- storage/indexeddb/resources/pending-activity.js:
- storage/indexeddb/structured-clone-expected.txt:
- storage/indexeddb/structured-clone.html:
- 12:55 PM Changeset in webkit [129036] by
-
- 6 edits4 adds in trunk
AX: A few control types are returning the wrong answer for isReadOnly
https://bugs.webkit.org/show_bug.cgi?id=96735
Reviewed by Chris Fleizach.
Source/WebCore:
All input types should be read-only except ones that
are text fields. The previous logic was marking things like
checkboxes as not read-only.
Tests: platform/chromium/accessibility/readonly.html
platform/mac/accessibility/form-control-value-settable.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isReadOnly):
Tools:
Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
- DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isReadOnlyGetterCallback):
- DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
(AccessibilityUIElement):
LayoutTests:
Adds a new test to make sure that readonly is exposed correctly on
all elements.
- platform/chromium/accessibility/readonly-expected.txt: Added.
- platform/chromium/accessibility/readonly.html: Added.
- platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
- platform/mac/accessibility/form-control-value-settable.html: Added.
- 12:49 PM Changeset in webkit [129035] by
-
- 2 edits in trunk/LayoutTests
2012-09-19 Nate Chapin <Nate Chapin>
Chromium gardening.
A test is mistakenly marked as both SLOW and TIMEOUT.
- platform/chromium/TestExpectations:
- 12:33 PM Changeset in webkit [129034] by
-
- 2 edits in trunk/LayoutTests
[WinCairo] Unreviewed build correction to update Skipped list
to match current Windows list.
- platform/wincairo/Skipped: Updated to match Apple build.
- 12:19 PM Changeset in webkit [129033] by
-
- 16 edits3 copies in branches/chromium/1229
Merge 128346 - Inline repainting can be off-by-one with sub-pixel enabled
https://bugs.webkit.org/show_bug.cgi?id=95882
Reviewed by Eric Seidel.
Source/WebCore:
With sub-pixel layout enabled, context accumulated from containing renderers is used to properly
pixel snap. Selection repaint rects are stored outside the affected renderers, and are handed to
the embedder without the context to correctly determine the snapped values. This can result in
repaint areas smaller than what's needed.
This could be fixed three ways:
- by changing selection repaint rects to an IntRect and pixel snapping the values before storing them outside the render tree. This is the narrowest solution.
- by adapting layout to store pixel snapping hints along with the size/location of the renderer. This is the best possible solution, as it would help solve a lot of pixel snapping issues and reduce complexity of handling. I eventually intend on implementing this.
- by reverting repaintUsingContainer to IntRects and using pixel snapping when possible, and enclosingIntRect where we lack context.
This implements the last solution, as it's the least invasive, but can potentially fix numerous
sub-pixel repaint issues.
Test: fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::repaintIncludingNonCompositingDescendants):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/RenderObject.h:
(RenderObject):
- rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfo::repaint):
(WebCore::RenderBlockSelectionInfo::repaint):
LayoutTests:
Test that we properly repaint selection gaps inside tables with sub-pixel offsets.
- fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added.
- fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html: Added.
- platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/mac-lion/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-wk2/Skipped:
- platform/mac/Skipped:
- platform/qt-4.8/Skipped:
- platform/qt/Skipped:
- platform/win-wk2/Skipped:
- platform/win-xp/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 12:17 PM Changeset in webkit [129032] by
-
- 3 edits3 adds in trunk/Source/WebKit/chromium
[chromium] WebImage should use ImageDecoder directly
https://bugs.webkit.org/show_bug.cgi?id=96135
Reviewed by Adam Barth.
This patch is for preparation of deferred image decoding.
ImageSource will be used as a portal to access deferred image decoder
by BitmapImage, it should not be accessible through WebKit APIs.
WebImage now calls ImageDecoder directly which is the actual
implementation of an image decoder.
Tests: WebImageTest.PNGImage
WebImageTest.ICOImage
WebImageTest.BadImage
- WebKit.gypi:
- src/WebImageSkia.cpp:
(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):
- tests/WebImageTest.cpp: Added.
(WebKit):
(WebKit::readFile):
(WebKit::TEST):
- tests/data/black-and-white.ico: Added.
- tests/data/white-1x1.png: Added.
- 12:15 PM Changeset in webkit [129031] by
-
- 2 edits in trunk/LayoutTests
2012-09-19 Nate Chapin <Nate Chapin>
Chromium gardening.
Mark a consistently passing test as such, tweak flakiness
of several tests based on recent build results.
- platform/chromium/TestExpectations:
- 12:12 PM Changeset in webkit [129030] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Remove unused PlatformSupport reference in V8GCController
https://bugs.webkit.org/show_bug.cgi?id=97118
Reviewed by Ryosuke Niwa.
Part of a refactoring series. See tracking bug 82948.
- bindings/v8/V8GCController.cpp:
- 12:07 PM Changeset in webkit [129029] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Add a method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.
https://bugs.webkit.org/show_bug.cgi?id=96112
Patch by Oli Lan <olilan@chromium.org> on 2012-09-19
Reviewed by Adam Barth.
Adds a new method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.
This will be used by the Android port to implement platform-specific gesture behaviour.
This is tested by the new test WebViewTest.ClientTapHandlers.
- public/WebViewClient.h:
(WebViewClient):
(WebKit::WebViewClient::didHandleGestureEvent):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
- tests/WebViewTest.cpp:
- 12:03 PM Changeset in webkit [129028] by
-
- 8 edits in branches/chromium/1229
Merge 126110 - [Sub-pixel Layout] Block selection gap repainting can leave one pixel gaps
https://bugs.webkit.org/show_bug.cgi?id=94526
Reviewed by Eric Seidel.
Source/WebCore:
Reverting RenderLayer's m_blockSelectionGapsBounds to be an IntRect and applying enclosingIntRect to the
gapRects added to the bounds. Previously, we'd end multiple block gaps and pixel snap the result, which
can yield results one pixel off in width and height.
Covered by existing tests. This undoes some of the rebaselining from when sub-pixel was enabled for Chromium.
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h:
LayoutTests:
Correcting pixel gap repainting reverts a bunch of chromium expectations to their pre-sub-pixel layout
versions. This largely triggers 1-pixel image diffs in input fields.
- platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
- platform/chromium-mac/editing/pasteboard/4806874-expected.png:
- platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-mac/editing/selection/3690703-2-expected.png:
- platform/chromium-mac/editing/selection/3690703-expected.png:
- platform/chromium-mac/editing/selection/3690719-expected.png:
- platform/chromium-mac/editing/selection/4895428-3-expected.png:
- platform/chromium-mac/editing/selection/4975120-expected.png:
- platform/chromium-mac/editing/selection/drag-select-1-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
- platform/chromium-mac/fast/css/input-search-padding-expected.png:
- platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.png:
- platform/chromium-mac/fast/css/line-height-expected.png:
- platform/chromium-mac/fast/css/square-button-appearance-expected.png:
- platform/chromium-mac/fast/css/text-overflow-input-expected.png:
- platform/chromium-mac/fast/dom/isindex-001-expected.png:
- platform/chromium-mac/fast/dom/isindex-002-expected.png:
- platform/chromium-mac/fast/events/autoscroll-expected.png:
- platform/chromium-mac/fast/events/context-no-deselect-expected.png:
- platform/chromium-mac/fast/forms/basic-buttons-expected.png:
- platform/chromium-mac/fast/forms/basic-inputs-expected.png:
- platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
- platform/chromium-mac/fast/forms/button-sizes-expected.png:
- platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
- platform/chromium-mac/fast/forms/encoding-test-expected.png:
- platform/chromium-mac/fast/forms/fieldset-align-expected.png:
- platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
- platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac/fast/forms/input-align-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
- platform/chromium-mac/fast/forms/input-baseline-expected.png:
- platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-empty-expected.png:
- platform/chromium-mac/fast/forms/input-spaces-expected.png:
- platform/chromium-mac/fast/forms/input-table-expected.png:
- platform/chromium-mac/fast/forms/input-text-click-inside-expected.png:
- platform/chromium-mac/fast/forms/input-text-click-outside-expected.png:
- platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
- platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
- platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.png:
- platform/chromium-mac/fast/forms/input-width-expected.png:
- platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/chromium-mac/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-mac/fast/forms/text-style-color-expected.png:
- platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
- platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
- platform/chromium-mac/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac/fast/html/details-open2-expected.png:
- platform/chromium-mac/fast/html/details-open4-expected.png:
- platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-mac/fast/table/003-expected.png:
- platform/chromium-mac/fast/table/colspanMinWidth-expected.png:
- platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
- platform/chromium-mac/fast/table/text-field-baseline-expected.png:
- platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
- platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
- platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac/svg/hixie/mixed/003-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/45621-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/chromium/TestExpectations:
- 11:56 AM Changeset in webkit [129027] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Remove unused PlatformSupport reference in V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=97117
Reviewed by Ryosuke Niwa.
Part of a refactoring series. See tracking bug 82948.
- bindings/v8/V8DOMWindowShell.cpp:
- 11:52 AM Changeset in webkit [129026] by
-
- 5 edits in trunk/Source/WebCore
[V8] Remove WorkerContextExecutionProxy::runScript()
https://bugs.webkit.org/show_bug.cgi?id=97060
Reviewed by Adam Barth.
To kill WorkerContextExecutionProxy, this patch removes
WorkerContextExecutionProxy::runScript() by replacing it
with ScriptRunner::runCompiledScript().
For the replacement, this patch moves TryCatch logic in
runCompiledScript() to the caller side. The reason why
we have to avoid nesting TryCatches is a V8 bug:
http://code.google.com/p/v8/issues/detail?id=2166
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::compileAndRunScript):
- bindings/v8/ScriptRunner.cpp:
(WebCore::ScriptRunner::runCompiledScript):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
- bindings/v8/WorkerContextExecutionProxy.h:
(WorkerContextExecutionProxy):
- 11:04 AM Changeset in webkit [129025] by
-
- 2 edits in trunk/LayoutTests
2012-09-19 Nate Chapin <Nate Chapin>
Chromium gardening, remove flaky tests that don't appear to
actually be flaky.
https://bugs.webkit.org/show_bug.cgi?id=78725
- platform/chromium/TestExpectations:
- 11:03 AM Changeset in webkit [129024] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Remove custom painting code for searchCancel
https://bugs.webkit.org/show_bug.cgi?id=97119
Reviewed by Antonio Gomes.
Remove the dynamic painting code for searchCancel, we use a png file now.
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::Image::loadPlatformResource):
- 10:58 AM Changeset in webkit [129023] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Support high DPI scroll bar on top level web frame.
https://bugs.webkit.org/show_bug.cgi?id=95134
Patch by Robert Flack <flackr@chromium.org> on 2012-09-19
Reviewed by Adrienne Walker.
Calls setAppliesPageScale(true) on root scrollbar layers as these are not scaled.
- src/NonCompositedContentHost.cpp:
(WebKit::setScrollbarBoundsContainPageScale):
(WebKit):
(WebKit::NonCompositedContentHost::setViewport):
- 10:57 AM Changeset in webkit [129022] by
-
- 4 edits in trunk
[WTR] Memory leaks in TestRunner::deliverWebIntent()
https://bugs.webkit.org/show_bug.cgi?id=97111
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Fix memory leaks in WKBundleIntentCreate() by adopting strings
created with WKStringCreateWithUTF8CString().
- WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp:
(WKBundleIntentCreate):
Tools:
Fix memory leaks in deliverWebIntent() by adopting strings
created with WKStringCreateWithUTF8CString().
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::deliverWebIntent):
- 10:56 AM Changeset in webkit [129021] by
-
- 2 edits in trunk/LayoutTests
2012-09-19 Nate Chapin <Nate Chapin>
Chromium gardening.
fast/filesystem/workers/detached-frame-crash.html does not appear to be
flakily crashing anymore.
- platform/chromium/TestExpectations:
- 10:53 AM Changeset in webkit [129020] by
-
- 8 edits in trunk/Source
[Chromium] Move notifyJSOutOfMemory out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97116
Reviewed by Adam Barth.
Source/WebCore:
Part of a refactoring series. See tracking bug 82948.
- bindings/v8/V8Binding.cpp:
(WebCore::handleOutOfMemory):
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::didExhaustMemoryAvailableForScript):
(FrameLoaderClient):
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
Part of a refactoring series. See tracking bug 82948.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didExhaustMemoryAvailableForScript):
(WebKit):
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
- src/PlatformSupport.cpp:
(WebCore):
- 10:52 AM Changeset in webkit [129019] by
-
- 5 edits in trunk
[EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
https://bugs.webkit.org/show_bug.cgi?id=97082
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
WebChromeClient::selectItemWritingDirectionIsNatural() now returns
true for EFL-WK2, consistently with EFL-WK1, so that the style
is properly adjusted in RenderMenuList::adjustInnerStyle().
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
LayoutTests:
Rebaseline fast/forms/select-writing-direction-natural.html and
unskip it for efl-wk2.
- platform/efl-wk2/TestExpectations:
- platform/efl/fast/forms/select-writing-direction-natural-expected.png:
- 10:50 AM Changeset in webkit [129018] by
-
- 16 edits9 adds in trunk
Implement 'mask-type' for <mask>
https://bugs.webkit.org/show_bug.cgi?id=97011
Reviewed by Andreas Kling.
Source/WebCore:
The CSS Masking specification defines the presentation attribute 'mask-type' to
switch between luminance and alpha masking. 'mask-type' just affects the SVG
mask element. The luminance masking is the current behavior of of SVG masking.
Alpha masking is simular to '-webkit-mask-image'.
This patch implements this property and make it possible to switch between both
masking modes. Since the default value is 'luminance', this does not break
exisiting content which is tested with exisiting tests.
http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html#the-mask-type
Tests: svg/css/mask-type.html
svg/masking/mask-type-alpha-expected.svg
svg/masking/mask-type-alpha.svg
svg/masking/mask-type-luminance-expected.svg
svg/masking/mask-type-luminance.svg
svg/masking/mask-type-not-set-expected.svg
svg/masking/mask-type-not-set.svg
- css/CSSComputedStyleDeclaration.cpp: Add mask-type property.
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EMaskType):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- css/SVGCSSPropertyNames.in: Add mask-type.
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/SVGCSSValueKeywords.in:
- rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::diff):
- rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialMaskType):
(WebCore::SVGRenderStyle::setMaskType):
(SVGRenderStyle):
(WebCore::SVGRenderStyle::maskType):
(WebCore::SVGRenderStyle::setBitDefaults):
- rendering/style/SVGRenderStyleDefs.h:
- rendering/svg/RenderSVGResourceMasker.cpp:
Switch between the two masking modes according to the
computed value of mask-type.
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
(WebCore::cssPropertyToTypeMap):
- svg/svgattrs.in: Add the new attribute to the attribute list.
LayoutTests:
Added new tests for switching the masking mode on <mask> element with 'mask-type'.
- svg/css/mask-type-expected.txt: Added.
- svg/css/mask-type.html: Added.
- svg/masking/mask-type-alpha-expected.svg: Added.
- svg/masking/mask-type-alpha.svg: Added.
- svg/masking/mask-type-luminance-expected.svg: Added.
- svg/masking/mask-type-luminance.svg: Added.
- svg/masking/mask-type-not-set-expected.svg: Added.
- svg/masking/mask-type-not-set.svg: Added.
- 10:47 AM Changeset in webkit [129017] by
-
- 1 add in branches/chromium/1271/codereview.settings
adding for easy droverin
- 10:45 AM Changeset in webkit [129016] by
-
- 5 edits in trunk/Source
[Chromium] Remove unused popupsAllowed function from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96521
Reviewed by Eric Seidel.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- bindings/v8/NPV8Object.cpp:
(WebCore::v8ObjectToNPObject):
(_NPN_Evaluate):
(_NPN_GetProperty):
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 10:45 AM Changeset in webkit [129015] by
-
- 1 copy in branches/chromium/1271
creating chromium branch for m23
- 10:37 AM Changeset in webkit [129014] by
-
- 2 edits in trunk/LayoutTests
2012-09-19 Nate Chapin <Nate Chapin>
chromium TestExpectations update.
fast/filesystem/file-writer-write-overlapped.html and
fast/filesystem/workers/file-writer-write-overlapped.html
are flaky in WIN DEBUG only.
- platform/chromium/TestExpectations:
- 10:25 AM Changeset in webkit [129013] by
-
- 2 edits in trunk/LayoutTests
2012-09-19 Nate Chapin <Nate Chapin>
TextExpectations update, remove entries for consistently passing tests.
https://bugs.webkit.org/show_bug.cgi?id=74746
- platform/chromium/TestExpectations:
- 10:14 AM Changeset in webkit [129012] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding another flaky crasher expectation after r128802.
- platform/gtk/TestExpectations:
- 9:49 AM Changeset in webkit [129011] by
-
- 7 edits in trunk/Source/WebKit/efl
Unreviewed, rolling out r128995.
http://trac.webkit.org/changeset/128995
https://bugs.webkit.org/show_bug.cgi?id=97114
Causes the api tests to segfault. (Requested by rakuco on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-19
- tests/UnitTestUtils/EWKTestBase.cpp:
(EWKUnitTests::EWKTestBase::init):
(EWKUnitTests::EWKTestBase::shutdownAll):
(EWKUnitTests::EWKTestBase::startTest):
(EWKUnitTests::EWKTestBase::endTest):
(EWKUnitTests::EWKTestBase::createTest):
(EWKUnitTests):
(EWKUnitTests::EWKTestBase::runTest):
- tests/UnitTestUtils/EWKTestBase.h:
(EWKUnitTests):
(EWKTestBase):
- tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestEcoreEvas::EWKTestEcoreEvas):
(EWKUnitTests::EWKTestEcoreEvas::evas):
(EWKUnitTests):
(EWKUnitTests::EWKTestEcoreEvas::show):
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init):
(EWKUnitTests::EWKTestView::show):
(EWKUnitTests::EWKTestView::mainFrame):
(EWKUnitTests::EWKTestView::evas):
(EWKUnitTests::EWKTestView::bindEvents):
- tests/UnitTestUtils/EWKTestView.h:
(EWKTestEcoreEvas):
(EWKUnitTests):
(EWKTestView):
- tests/test_ewk_view.cpp:
(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):
- tests/test_runner.cpp:
(main):
- 8:54 AM Changeset in webkit [129010] by
-
- 6 edits in trunk/Source
[BlackBerry] Add function playerId() in class PageClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=97099
Patch by Jonathan Dong <Jonathan Dong> on 2012-09-19
Reviewed by Yong Li.
Source/WebCore:
Added function playerID() in class PageClientBlackBerry.
Internally reviewed by Charles Wei.
No new tests since there's no functional change.
- platform/blackberry/PageClientBlackBerry.h:
Source/WebKit/blackberry:
Implemented PageClientBlackBerry::playerID() in class WebPagePrivate,
and replaced the implementation of FrameLoaderClientBlackBerry::playerId().
Internally reviewed by Charles Wei.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::playerID):
(WebKit):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::playerId):
- 8:30 AM Changeset in webkit [129009] by
-
- 5 edits in trunk/Source/WebCore
[CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined
https://bugs.webkit.org/show_bug.cgi?id=96300
Patch by Raul Hudea <rhudea@adobe.com> on 2012-09-19
Reviewed by Yury Semikhatsky.
All CSS Regions APIs should be exposed only if CSS_REGIONS is enabled
No new tests because of no behavior changes.
- css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage): Fix compile without CSS_REGIONS enabled and added an ASSERT_NOT_REACHED as in other functions
- dom/Element.cpp: Compile webkitRegionOverset only if CSS_REGIONS is enabled
(WebCore):
- dom/Element.h:
- dom/Element.idl: Expose webkitRegionOverset only if CSS_REGIONS is enabled
- 8:12 AM Changeset in webkit [129008] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Adding another flaky crasher expectation after r128802.
Adding platform-specific baselines after r128861.
- platform/gtk/TestExpectations:
- platform/gtk/fast/regions/autoheight-regions-mark-expected.png: Added.
- platform/gtk/fast/regions/autoheight-regions-mark-expected.txt: Added.
- 8:05 AM Changeset in webkit [129007] by
-
- 4 edits in trunk/Tools
[Qt] Fix incremental builds with all-in-one-files and gccdepends
Reviewed by Tor Arne Vestbø.
Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
are not only created for header files but also for .cpp files. AllInOne.cpp files
include other .cpp files, and when those are removed we need those dummy rules to
avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
- qmake/config.tests/gccdepends/empty.cpp:
(main):
- qmake/config.tests/gccdepends/gccdepends.pro:
- qmake/mkspecs/features/default_pre.prf:
- 7:52 AM Changeset in webkit [129006] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
Added a missing 'if' statement.
https://bugs.webkit.org/show_bug.cgi?id=96925
PR #180866
Internally Reviewed by Antonio Gomes.
Adding an 'if' statement which should have been in PR # 180866 (SHA:b9c06af395c22e)
Patch by Abbas Sherawala <asherawala@rim.com> on 2012-09-19
Reviewed by Antonio Gomes.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
- 7:42 AM Changeset in webkit [129005] by
-
- 7 edits in trunk/Source/WebCore
Remove all usages of M_PI from WebCore
https://bugs.webkit.org/show_bug.cgi?id=93109
Reviewed by Dirk Schulze.
<wtf/MathExtras.h> implements many functions dealing with M_PI.
Use them in WebCore instead of duplicating the functionality.
- platform/blackberry/PlatformTouchEventBlackBerry.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setFilters):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
- platform/graphics/wx/FontPlatformDataWxMac.mm:
- platform/mac/WebWindowAnimation.mm:
(-[WebWindowScaleAnimation currentValue]):
- platform/wx/wxcode/gdiplus/non-kerned-drawing.cpp:
(DegToRad):
(RadToDeg):
- 7:37 AM Changeset in webkit [129004] by
-
- 21 edits in trunk/LayoutTests
[EFL] Rebaseline a few mozilla/table/bugs tests that were missed
https://bugs.webkit.org/show_bug.cgi?id=97107
Unreviewed EFL rebaseline.
Rebaseline a few tables/mozilla/bugs tests that
were forgotten during my massive tables/mozilla
rebaseline.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
- platform/efl/TestExpectations:
- platform/efl/tables/mozilla/bugs/45621-expected.png:
- platform/efl/tables/mozilla/bugs/bug9072-expected.png:
- platform/efl/tables/mozilla/bugs/bug9123-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug9123-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug92143-expected.png:
- platform/efl/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug9271-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug9271-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug92868-expected.png:
- platform/efl/tables/mozilla/bugs/bug93363-expected.png:
- platform/efl/tables/mozilla/bugs/bug963-expected.png:
- platform/efl/tables/mozilla/bugs/bug96334-expected.png:
- platform/efl/tables/mozilla/bugs/bug96343-expected.png:
- platform/efl/tables/mozilla/bugs/bug965-expected.png:
- platform/efl/tables/mozilla/bugs/bug97138-expected.png:
- platform/efl/tables/mozilla/bugs/bug98196-expected.png:
- platform/efl/tables/mozilla/bugs/bug9879-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug99923-expected.png:
- platform/efl/tables/mozilla/bugs/bug99948-expected.png:
- 7:26 AM Changeset in webkit [129003] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Network request headers text fallback has typo.
https://bugs.webkit.org/show_bug.cgi?id=96280
Reviewed by Pavel Feldman.
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):
- 7:12 AM Changeset in webkit [129002] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update test expectation for indexeddb test that is currently only run using content_browsertests
Unreviewed gardening.
- storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt:
- 7:11 AM Changeset in webkit [129001] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] remove static_cast which will cause video crash
https://bugs.webkit.org/show_bug.cgi?id=97070
Patch by Jonathan Dong <Jonathan Dong> on 2012-09-19
Reviewed by Antonio Gomes.
Removed the static_cast to avoid layering violation which
will cause a runtime crash.
We won't create a real MediaPlayerPrivate object before we call
MediaPlayer::load(), so if we use player()->implementation()
before calling load() in some cases, it points to a
NullMediaPlayerPrivate object. Here we should not use static_cast,
instead we should use HTMLMediaElement::percentLoaded() to
avoid layering violation as we don't have the buffering bug which
the deleted comment refers to.
Internally reviewed by Max Feil.
Test case: media/video-size.html
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
- 7:09 AM Changeset in webkit [129000] by
-
- 4 edits in trunk/Source/WebKit/gtk
[gtk] add enable-media-stream to websettings
https://bugs.webkit.org/show_bug.cgi?id=94361
Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2012-09-19
Reviewed by Martin Robinson.
Applications should be allowed to enable/disable MediaStream on webkitwebsettings.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
- 7:08 AM Changeset in webkit [128999] by
-
- 7 edits2 adds in trunk
Do touch adjustment on GestureTapDown
https://bugs.webkit.org/show_bug.cgi?id=96677
Patch by Rick Byers <rbyers@chromium.org> on 2012-09-19
Reviewed by Antonio Gomes.
Source/WebCore:
Do touch adjustment on GestureTapDown exactly as for GestureTap today.
Test: touchadjustment/touch-links-active.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::adjustGesturePosition):
Tools:
Allow radius to be set for GestureTapDown events.
- DumpRenderTree/chromium/TestRunner/EventSender.cpp:
(EventSender::gestureEvent):
LayoutTests:
Make a few tweaks to the touchadjustment.js infrastructure to make it
simpler and easier to use. Add a test for touch-adjustment of
GestureTapDown events (based on touch-links-longpress).
- touchadjustment/resources/touchadjustment.js:
(touchPoint.return.left.x.radiusX.top.y.radiusY.width.radiusX.2.height.radiusY.2.get x):
(touchPoint.return.get y):
(touchPoint):
(offsetTouchPoint):
- touchadjustment/touch-links-active-expected.txt: Added.
- touchadjustment/touch-links-active.html: Added.
- 7:04 AM Changeset in webkit [128998] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip fast/dom/message-port-deleted-by-accessor.html
https://bugs.webkit.org/show_bug.cgi?id=97105
Unreviewed EFL gardening.
Add fast/dom/message-port-deleted-by-accessor.html to
TestExpectations because it sometimes crashes on debug
build bots after r128802.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
- platform/efl/TestExpectations:
- 7:03 AM Changeset in webkit [128997] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed another follow up Apple Win build fix for r128992.
- inspector/InspectorAllInOne.cpp:
- 7:00 AM Changeset in webkit [128996] by
-
- 2 edits in trunk/Source/WebCore
[GTK] REGRESSION(r128907): it broke several WebKit2 API tests
https://bugs.webkit.org/show_bug.cgi?id=97092
Reviewed by Martin Robinson.
Calling resizeLater() from the constructor of
RedirectedXCompositeWindow can cause the callback to be called
later by the main loop after the RedirectedXCompositeWindow object
has been destroyed. Instead of calling resizeLater(), initialize
the usable size to the given initial size.
- platform/gtk/RedirectedXCompositeWindow.cpp:
(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
- 6:53 AM Changeset in webkit [128995] by
-
- 7 edits in trunk/Source/WebKit/efl
[EFL][UT] Refactoring an implementation of testing framework for wk1.
https://bugs.webkit.org/show_bug.cgi?id=94925
Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-09-19
Reviewed by Gyuyoung Kim.
The reason of changing, was to adjust current implementation to use gtest features
related to cleaning (SetUp, TearDown), cleaning code in terms of useless methods
and lastly to make framework easier to use.
- tests/UnitTestUtils/EWKTestBase.cpp:
(EWKUnitTests::EWKTestBase::EWKTestBase): Added to initialize test view.
(EWKUnitTests::EWKTestBase::webView): Returns current webview.
(EWKUnitTests::EWKTestBase::SetUp):
Before test is started, SetUp is called.
Used this to initialize efl and test view.
(EWKUnitTests::EWKTestBase::TearDown):
TearDown is called as soon as test is completed.
Used this to properly shutdown efl and clean test view.
(EWKUnitTests::EWKTestBase::onLoadFinished):
(EWKUnitTests::EWKTestBase::waitUntilLoadFinished): It waits till test page will be properly loaded.
(EWKUnitTests::EWKTestBase::loadUrl): Starts loading test page.
- tests/UnitTestUtils/EWKTestBase.h:
- tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init): Initialize test view.
- tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):
- tests/test_ewk_view.cpp:
(TEST_F):
- tests/test_runner.cpp:
(main):
- 6:50 AM Changeset in webkit [128994] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed follow up Apple Win build fix for r128992.
- inspector/InspectorAllInOne.cpp:
- 6:32 AM Changeset in webkit [128993] by
-
- 15 edits2 adds in trunk
[EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
https://bugs.webkit.org/show_bug.cgi?id=97100
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
Reviewed by Gyuyoung Kim.
Source/WebKit/efl:
Add DumpRenderTree support method to set the
'WebKitCSSRegionsEnabled' preference.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setCSSRegionsEnabled):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
preference, in order to match WebKitTestRunner functionality.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::overridePreference):
LayoutTests:
Rebaseline and unskip several test cases now that EFL's DRT
supports overriding 'WebKitCSSRegionsEnabled' preference.
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
- platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png:
- platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
- platform/efl/fast/repaint/region-painting-invalidation-expected.png: Added.
- platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Added.
- platform/efl/fast/repaint/region-painting-via-layout-expected.txt:
- 6:07 AM Changeset in webkit [128992] by
-
- 25 edits8 moves in trunk
Web Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent
https://bugs.webkit.org/show_bug.cgi?id=96917
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-19
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Rename WebGLAgent* and WebGLInstrumentation* files to Canvas* as we will support both 2D and 3D/WebGL canvas instrumentation.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLCanvasElementCustom.cpp:
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
- inspector/CodeGeneratorInspector.py:
- inspector/InjectedScriptCanvasModule.cpp: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModule.cpp.
(WebCore):
(WebCore::InjectedScriptCanvasModule::InjectedScriptCanvasModule):
(WebCore::InjectedScriptCanvasModule::moduleForState):
(WebCore::InjectedScriptCanvasModule::source):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::captureFrame):
(WebCore::InjectedScriptCanvasModule::dropTraceLog):
(WebCore::InjectedScriptCanvasModule::traceLog):
(WebCore::InjectedScriptCanvasModule::replayTraceLog):
- inspector/InjectedScriptCanvasModule.h: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModule.h.
(WebCore):
(InjectedScriptCanvasModule):
- inspector/InjectedScriptCanvasModuleSource.js: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js.
(.):
- inspector/Inspector.json:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorCanvasAgent.cpp: Renamed from Source/WebCore/inspector/InspectorWebGLAgent.cpp.
(WebCore):
(CanvasAgentState):
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::~InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::setFrontend):
(WebCore::InspectorCanvasAgent::clearFrontend):
(WebCore::InspectorCanvasAgent::restore):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
(WebCore::InspectorCanvasAgent::dropTraceLog):
(WebCore::InspectorCanvasAgent::captureFrame):
(WebCore::InspectorCanvasAgent::getTraceLog):
(WebCore::InspectorCanvasAgent::replayTraceLog):
(WebCore::InspectorCanvasAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::injectedScriptCanvasModuleForTraceLogId):
- inspector/InspectorCanvasAgent.h: Renamed from Source/WebCore/inspector/InspectorWebGLAgent.h.
(WebCore):
(InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::create):
(WebCore::InspectorCanvasAgent::enabled):
- inspector/InspectorCanvasInstrumentation.h: Renamed from Source/WebCore/inspector/InspectorWebGLInstrumentation.h.
(WebCore):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InstrumentingAgents.h:
(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorCanvasAgent):
(WebCore::InstrumentingAgents::setInspectorCanvasAgent):
(InstrumentingAgents):
- inspector/compile-front-end.py:
- inspector/front-end/CanvasProfileView.js: Renamed from Source/WebCore/inspector/front-end/WebGLProfileView.js.
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype.get statusBarItems):
(WebInspector.CanvasProfileView.prototype.get profile):
(WebInspector.CanvasProfileView.prototype.wasShown):
(WebInspector.CanvasProfileView.prototype.willHide):
(WebInspector.CanvasProfileView.prototype._showTraceLog):
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick):
(WebInspector.CanvasProfileType):
(WebInspector.CanvasProfileType.prototype.get buttonTooltip):
(WebInspector.CanvasProfileType.prototype.buttonClicked.didStartCapturingFrame):
(WebInspector.CanvasProfileType.prototype.buttonClicked):
(WebInspector.CanvasProfileType.prototype.get treeItemTitle):
(WebInspector.CanvasProfileType.prototype.get description):
(WebInspector.CanvasProfileType.prototype.reset):
(WebInspector.CanvasProfileType.prototype.createTemporaryProfile):
(WebInspector.CanvasProfileType.prototype.createProfile):
(WebInspector.CanvasProfileHeader):
(WebInspector.CanvasProfileHeader.prototype.traceLogId):
(WebInspector.CanvasProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.CanvasProfileHeader.prototype.createView):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/canvasProfiler.css: Renamed from Source/WebCore/inspector/front-end/webGLProfiler.css.
(.canvas-profile-view):
(.canvas-trace-log):
(.canvas-trace-log div):
(#canvas-replay-image-container):
(#canvas-replay-image):
LayoutTests:
- inspector/profiler/webgl/webgl-profiler-get-error.html:
- inspector/profiler/webgl/webgl-profiler-test.js:
(initialize_CanvasWebGLProfilerTest.InspectorTest.enableCanvasAgent):
(initialize_CanvasWebGLProfilerTest):
- 5:56 AM Changeset in webkit [128991] by
-
- 136 edits in trunk/LayoutTests
[EFL] tables/mozilla tests need rebaseline (Part 6)
https://bugs.webkit.org/show_bug.cgi?id=97098
Unreviewed EFL rebaseline.
Rebaseline remaining tables/mozilla tests.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
- platform/efl/tables/mozilla/bugs/bug40828-expected.png:
- platform/efl/tables/mozilla/bugs/bug4093-expected.png:
- platform/efl/tables/mozilla/bugs/bug41890-expected.png:
- platform/efl/tables/mozilla/bugs/bug42187-expected.png:
- platform/efl/tables/mozilla/bugs/bug42443-expected.png:
- platform/efl/tables/mozilla/bugs/bug4284-expected.png:
- platform/efl/tables/mozilla/bugs/bug43039-expected.png:
- platform/efl/tables/mozilla/bugs/bug43204-expected.png:
- platform/efl/tables/mozilla/bugs/bug4382-expected.png:
- platform/efl/tables/mozilla/bugs/bug4385-expected.png:
- platform/efl/tables/mozilla/bugs/bug43854-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug43854-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug4427-expected.png:
- platform/efl/tables/mozilla/bugs/bug4429-expected.png:
- platform/efl/tables/mozilla/bugs/bug44505-expected.png:
- platform/efl/tables/mozilla/bugs/bug44523-expected.png:
- platform/efl/tables/mozilla/bugs/bug4501-expected.png:
- platform/efl/tables/mozilla/bugs/bug45055-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug45055-expected.png:
- platform/efl/tables/mozilla/bugs/bug4520-expected.png:
- platform/efl/tables/mozilla/bugs/bug4523-expected.png:
- platform/efl/tables/mozilla/bugs/bug4527-expected.png:
- platform/efl/tables/mozilla/bugs/bug45350-expected.png:
- platform/efl/tables/mozilla/bugs/bug45486-expected.png:
- platform/efl/tables/mozilla/bugs/bug4576-expected.png:
- platform/efl/tables/mozilla/bugs/bug46268-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug46268-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug46268-3-expected.png:
- platform/efl/tables/mozilla/bugs/bug46268-5-expected.png:
- platform/efl/tables/mozilla/bugs/bug46268-expected.png:
- platform/efl/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug46480-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug46480-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug46623-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug46623-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug46924-expected.png:
- platform/efl/tables/mozilla/bugs/bug46944-expected.png:
- platform/efl/tables/mozilla/bugs/bug4739-expected.png:
- platform/efl/tables/mozilla/bugs/bug47432-expected.png:
- platform/efl/tables/mozilla/bugs/bug48028-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug48028-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug4803-expected.png:
- platform/efl/tables/mozilla/bugs/bug4849-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug4849-expected.png:
- platform/efl/tables/mozilla/bugs/bug48827-expected.png:
- platform/efl/tables/mozilla/bugs/bug50695-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug51037-expected.png:
- platform/efl/tables/mozilla/bugs/bug51140-expected.png:
- platform/efl/tables/mozilla/bugs/bug51727-expected.png:
- platform/efl/tables/mozilla/bugs/bug5188-expected.png:
- platform/efl/tables/mozilla/bugs/bug52505-expected.png:
- platform/efl/tables/mozilla/bugs/bug52506-expected.png:
- platform/efl/tables/mozilla/bugs/bug53690-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug53891-expected.png:
- platform/efl/tables/mozilla/bugs/bug54450-expected.png:
- platform/efl/tables/mozilla/bugs/bug5538-expected.png:
- platform/efl/tables/mozilla/bugs/bug55527-expected.png:
- platform/efl/tables/mozilla/bugs/bug55545-expected.png:
- platform/efl/tables/mozilla/bugs/bug55694-expected.png:
- platform/efl/tables/mozilla/bugs/bug55789-expected.png:
- platform/efl/tables/mozilla/bugs/bug56201-expected.png:
- platform/efl/tables/mozilla/bugs/bug56405-expected.png:
- platform/efl/tables/mozilla/bugs/bug56563-expected.png:
- platform/efl/tables/mozilla/bugs/bug57300-expected.png:
- platform/efl/tables/mozilla/bugs/bug57378-expected.png:
- platform/efl/tables/mozilla/bugs/bug57828-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug57828-expected.png:
- platform/efl/tables/mozilla/bugs/bug5797-expected.png:
- platform/efl/tables/mozilla/bugs/bug5798-expected.png:
- platform/efl/tables/mozilla/bugs/bug5799-expected.png:
- platform/efl/tables/mozilla/bugs/bug5835-expected.png:
- platform/efl/tables/mozilla/bugs/bug5838-expected.png:
- platform/efl/tables/mozilla/bugs/bug58402-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug59354-expected.png:
- platform/efl/tables/mozilla/bugs/bug60013-expected.png:
- platform/efl/tables/mozilla/bugs/bug60749-expected.png:
- platform/efl/tables/mozilla/bugs/bug60804-expected.png:
- platform/efl/tables/mozilla/bugs/bug60807-expected.png:
- platform/efl/tables/mozilla/bugs/bug60992-expected.png:
- platform/efl/tables/mozilla/bugs/bug6184-expected.png:
- platform/efl/tables/mozilla/bugs/bug625-expected.png:
- platform/efl/tables/mozilla/bugs/bug6304-expected.png:
- platform/efl/tables/mozilla/bugs/bug63785-expected.png:
- platform/efl/tables/mozilla/bugs/bug6404-expected.png:
- platform/efl/tables/mozilla/bugs/bug641-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug641-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug650-expected.png:
- platform/efl/tables/mozilla/bugs/bug6674-expected.png:
- platform/efl/tables/mozilla/bugs/bug67864-expected.png:
- platform/efl/tables/mozilla/bugs/bug67915-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug68912-expected.png:
- platform/efl/tables/mozilla/bugs/bug68998-expected.png:
- platform/efl/tables/mozilla/bugs/bug69187-expected.png:
- platform/efl/tables/mozilla/bugs/bug69382-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug69382-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug709-expected.png:
- platform/efl/tables/mozilla/bugs/bug7112-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug7112-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug7121-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug72359-expected.png:
- platform/efl/tables/mozilla/bugs/bug727-expected.png:
- platform/efl/tables/mozilla/bugs/bug73321-expected.png:
- platform/efl/tables/mozilla/bugs/bug7342-expected.png:
- platform/efl/tables/mozilla/bugs/bug7471-expected.png:
- platform/efl/tables/mozilla/bugs/bug75250-expected.png:
- platform/efl/tables/mozilla/bugs/bug7714-expected.png:
- platform/efl/tables/mozilla/bugs/bug78162-expected.png:
- platform/efl/tables/mozilla/bugs/bug8032-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug80762-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug81934-expected.png:
- platform/efl/tables/mozilla/bugs/bug82946-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug82946-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug8361-expected.png:
- platform/efl/tables/mozilla/bugs/bug83786-expected.png:
- platform/efl/tables/mozilla/bugs/bug8381-expected.png:
- platform/efl/tables/mozilla/bugs/bug8411-expected.png:
- platform/efl/tables/mozilla/bugs/bug86220-expected.png:
- platform/efl/tables/mozilla/bugs/bug86708-expected.png:
- platform/efl/tables/mozilla/bugs/bug88035-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug88035-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug88524-expected.png:
- platform/efl/tables/mozilla/bugs/bug8858-expected.png:
- platform/efl/tables/mozilla/bugs/bug8950-expected.png:
- platform/efl/tables/mozilla/other/body_col-expected.png:
- platform/efl/tables/mozilla/other/cell_widths-expected.png:
- platform/efl/tables/mozilla/other/cellspacing-expected.png:
- platform/efl/tables/mozilla/other/move_row-expected.png:
- platform/efl/tables/mozilla/other/ms-expected.png:
- platform/efl/tables/mozilla/other/nested2-expected.png:
- platform/efl/tables/mozilla/other/nestedTables-expected.png:
- platform/efl/tables/mozilla/other/padding-expected.png:
- platform/efl/tables/mozilla/other/test3-expected.png:
- platform/efl/tables/mozilla/other/test6-expected.png:
- platform/efl/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
- 5:46 AM Changeset in webkit [128990] by
-
- 212 edits1 add in trunk/LayoutTests
[EFL] tables/mozilla tests need rebaseline (Part 5)
https://bugs.webkit.org/show_bug.cgi?id=97096
Unreviewed EFL rebaseline.
Rebaseline part of tables/mozilla/bugs/ test cases
for EFL port.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
- platform/efl/tables/mozilla/bugs/bug10009-expected.png:
- platform/efl/tables/mozilla/bugs/bug100334-expected.png:
- platform/efl/tables/mozilla/bugs/bug10036-expected.png:
- platform/efl/tables/mozilla/bugs/bug10039-expected.png:
- platform/efl/tables/mozilla/bugs/bug101201-expected.png:
- platform/efl/tables/mozilla/bugs/bug101674-expected.png:
- platform/efl/tables/mozilla/bugs/bug102145-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug102145-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug102145-3-expected.png:
- platform/efl/tables/mozilla/bugs/bug102145-4-expected.png:
- platform/efl/tables/mozilla/bugs/bug10269-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug10269-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug10296-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug10296-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug1055-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug10565-expected.png:
- platform/efl/tables/mozilla/bugs/bug106158-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug106158-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug10633-expected.png:
- platform/efl/tables/mozilla/bugs/bug1067-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug1067-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug106816-expected.png:
- platform/efl/tables/mozilla/bugs/bug108340-expected.png:
- platform/efl/tables/mozilla/bugs/bug109043-expected.png:
- platform/efl/tables/mozilla/bugs/bug11026-expected.png:
- platform/efl/tables/mozilla/bugs/bug110566-expected.png:
- platform/efl/tables/mozilla/bugs/bug11321-expected.png:
- platform/efl/tables/mozilla/bugs/bug113235-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug113235-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug113235-3-expected.png:
- platform/efl/tables/mozilla/bugs/bug113424-expected.png:
- platform/efl/tables/mozilla/bugs/bug11384q-expected.png:
- platform/efl/tables/mozilla/bugs/bug11384s-expected.png:
- platform/efl/tables/mozilla/bugs/bug1163-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug1188-expected.png:
- platform/efl/tables/mozilla/bugs/bug11944-expected.png:
- platform/efl/tables/mozilla/bugs/bug119786-expected.png:
- platform/efl/tables/mozilla/bugs/bug12008-expected.png:
- platform/efl/tables/mozilla/bugs/bug120364-expected.png:
- platform/efl/tables/mozilla/bugs/bug1220-expected.png:
- platform/efl/tables/mozilla/bugs/bug1224-expected.png:
- platform/efl/tables/mozilla/bugs/bug12268-expected.png:
- platform/efl/tables/mozilla/bugs/bug12384-expected.png:
- platform/efl/tables/mozilla/bugs/bug123862-expected.png:
- platform/efl/tables/mozilla/bugs/bug1261-expected.png:
- platform/efl/tables/mozilla/bugs/bug126742-expected.png:
- platform/efl/tables/mozilla/bugs/bug12709-expected.png:
- platform/efl/tables/mozilla/bugs/bug127267-expected.png:
- platform/efl/tables/mozilla/bugs/bug128229-expected.png:
- platform/efl/tables/mozilla/bugs/bug12908-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug12910-expected.png:
- platform/efl/tables/mozilla/bugs/bug1296-expected.png:
- platform/efl/tables/mozilla/bugs/bug1302-expected.png:
- platform/efl/tables/mozilla/bugs/bug131020-expected.png:
- platform/efl/tables/mozilla/bugs/bug131020_iframe-expected.png:
- platform/efl/tables/mozilla/bugs/bug13105-expected.png:
- platform/efl/tables/mozilla/bugs/bug13118-expected.png:
- platform/efl/tables/mozilla/bugs/bug1318-expected.png:
- platform/efl/tables/mozilla/bugs/bug13196-expected.png:
- platform/efl/tables/mozilla/bugs/bug133756-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug13484-expected.png:
- platform/efl/tables/mozilla/bugs/bug13526-expected.png:
- platform/efl/tables/mozilla/bugs/bug137388-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug138725-expected.png:
- platform/efl/tables/mozilla/bugs/bug139524-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug139524-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug139524-3-expected.png:
- platform/efl/tables/mozilla/bugs/bug139524-4-expected.png:
- platform/efl/tables/mozilla/bugs/bug14159-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug14159-3-expected.png:
- platform/efl/tables/mozilla/bugs/bug1430-expected.png:
- platform/efl/tables/mozilla/bugs/bug14323-expected.png:
- platform/efl/tables/mozilla/bugs/bug145572-expected.png:
- platform/efl/tables/mozilla/bugs/bug1474-expected.png:
- platform/efl/tables/mozilla/bugs/bug149275-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug149275-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug14929-expected.png:
- platform/efl/tables/mozilla/bugs/bug15247-expected.png:
- platform/efl/tables/mozilla/bugs/bug154780-expected.png:
- platform/efl/tables/mozilla/bugs/bug15544-expected.png:
- platform/efl/tables/mozilla/bugs/bug157890-expected.png:
- platform/efl/tables/mozilla/bugs/bug159108-expected.png:
- platform/efl/tables/mozilla/bugs/bug15933-expected.png:
- platform/efl/tables/mozilla/bugs/bug16012-expected.png:
- platform/efl/tables/mozilla/bugs/bug16252-expected.png:
- platform/efl/tables/mozilla/bugs/bug17130-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug17130-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug17138-expected.png:
- platform/efl/tables/mozilla/bugs/bug17168-expected.png:
- platform/efl/tables/mozilla/bugs/bug175455-4-expected.png:
- platform/efl/tables/mozilla/bugs/bug17548-expected.png:
- platform/efl/tables/mozilla/bugs/bug17587-expected.png:
- platform/efl/tables/mozilla/bugs/bug1800-expected.png:
- platform/efl/tables/mozilla/bugs/bug1802-expected.png:
- platform/efl/tables/mozilla/bugs/bug1802s-expected.png:
- platform/efl/tables/mozilla/bugs/bug1809-expected.png:
- platform/efl/tables/mozilla/bugs/bug1818-5-expected.png:
- platform/efl/tables/mozilla/bugs/bug1828-expected.png:
- platform/efl/tables/mozilla/bugs/bug18359-expected.png:
- platform/efl/tables/mozilla/bugs/bug18558-expected.png:
- platform/efl/tables/mozilla/bugs/bug18664-expected.png:
- platform/efl/tables/mozilla/bugs/bug18955-expected.png:
- platform/efl/tables/mozilla/bugs/bug19061-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug19061-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug19356-expected.png:
- platform/efl/tables/mozilla/bugs/bug194024-expected.png:
- platform/efl/tables/mozilla/bugs/bug19599-expected.png:
- platform/efl/tables/mozilla/bugs/bug2050-expected.png:
- platform/efl/tables/mozilla/bugs/bug20579-expected.png:
- platform/efl/tables/mozilla/bugs/bug2065-expected.png:
- platform/efl/tables/mozilla/bugs/bug20804-expected.png:
- platform/efl/tables/mozilla/bugs/bug2123-expected.png:
- platform/efl/tables/mozilla/bugs/bug21299-expected.png:
- platform/efl/tables/mozilla/bugs/bug215629-expected.png:
- platform/efl/tables/mozilla/bugs/bug21918-expected.png:
- platform/efl/tables/mozilla/bugs/bug22019-expected.png:
- platform/efl/tables/mozilla/bugs/bug220536-expected.png:
- platform/efl/tables/mozilla/bugs/bug221784-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug221784-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug22246-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug22246-2a-expected.png:
- platform/efl/tables/mozilla/bugs/bug22246-3-expected.png:
- platform/efl/tables/mozilla/bugs/bug22246-3a-expected.png:
- platform/efl/tables/mozilla/bugs/bug222846-expected.png:
- platform/efl/tables/mozilla/bugs/bug22513-expected.png:
- platform/efl/tables/mozilla/bugs/bug2267-expected.png:
- platform/efl/tables/mozilla/bugs/bug227123-expected.png:
- platform/efl/tables/mozilla/bugs/bug2296-expected.png:
- platform/efl/tables/mozilla/bugs/bug23072-expected.png:
- platform/efl/tables/mozilla/bugs/bug23151-expected.png:
- platform/efl/tables/mozilla/bugs/bug23235-expected.png:
- platform/efl/tables/mozilla/bugs/bug23299-expected.png:
- platform/efl/tables/mozilla/bugs/bug24200-expected.png:
- platform/efl/tables/mozilla/bugs/bug24503-expected.png:
- platform/efl/tables/mozilla/bugs/bug24627-expected.png:
- platform/efl/tables/mozilla/bugs/bug24661-expected.png:
- platform/efl/tables/mozilla/bugs/bug2469-expected.png:
- platform/efl/tables/mozilla/bugs/bug2479-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/efl/tables/mozilla/bugs/bug2479-4-expected.png:
- platform/efl/tables/mozilla/bugs/bug24880-expected.png:
- platform/efl/tables/mozilla/bugs/bug25004-expected.png:
- platform/efl/tables/mozilla/bugs/bug25074-expected.png:
- platform/efl/tables/mozilla/bugs/bug25086-expected.png:
- platform/efl/tables/mozilla/bugs/bug2509-expected.png:
- platform/efl/tables/mozilla/bugs/bug2516-expected.png:
- platform/efl/tables/mozilla/bugs/bug25367-expected.png:
- platform/efl/tables/mozilla/bugs/bug25663-expected.png:
- platform/efl/tables/mozilla/bugs/bug2585-expected.png:
- platform/efl/tables/mozilla/bugs/bug26178-expected.png:
- platform/efl/tables/mozilla/bugs/bug26553-expected.png: Added.
- platform/efl/tables/mozilla/bugs/bug2684-expected.png:
- platform/efl/tables/mozilla/bugs/bug27038-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug27038-3-expected.png:
- platform/efl/tables/mozilla/bugs/bug275625-expected.png:
- platform/efl/tables/mozilla/bugs/bug2757-expected.png:
- platform/efl/tables/mozilla/bugs/bug2763-expected.png:
- platform/efl/tables/mozilla/bugs/bug2773-expected.png:
- platform/efl/tables/mozilla/bugs/bug278266-expected.png:
- platform/efl/tables/mozilla/bugs/bug278385-expected.png:
- platform/efl/tables/mozilla/bugs/bug27993-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug28341-expected.png:
- platform/efl/tables/mozilla/bugs/bug2886-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug2886-expected.png:
- platform/efl/tables/mozilla/bugs/bug28928-expected.png:
- platform/efl/tables/mozilla/bugs/bug29058-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug29058-3-expected.png:
- platform/efl/tables/mozilla/bugs/bug29157-expected.png:
- platform/efl/tables/mozilla/bugs/bug29314-expected.png:
- platform/efl/tables/mozilla/bugs/bug29326-expected.png:
- platform/efl/tables/mozilla/bugs/bug29429-expected.png:
- platform/efl/tables/mozilla/bugs/bug2947-expected.png:
- platform/efl/tables/mozilla/bugs/bug2962-expected.png:
- platform/efl/tables/mozilla/bugs/bug2973-expected.png:
- platform/efl/tables/mozilla/bugs/bug2981-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug2981-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug2997-expected.png:
- platform/efl/tables/mozilla/bugs/bug30273-expected.png:
- platform/efl/tables/mozilla/bugs/bug30332-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug30332-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug3037-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug3037-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug30418-expected.png:
- platform/efl/tables/mozilla/bugs/bug30559-expected.png:
- platform/efl/tables/mozilla/bugs/bug30692-expected.png:
- platform/efl/tables/mozilla/bugs/bug30985-expected.png:
- platform/efl/tables/mozilla/bugs/bug3103-expected.png:
- platform/efl/tables/mozilla/bugs/bug3191-expected.png:
- platform/efl/tables/mozilla/bugs/bug32205-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug32205-3-expected.png:
- platform/efl/tables/mozilla/bugs/bug32205-5-expected.png:
- platform/efl/tables/mozilla/bugs/bug32447-expected.png:
- platform/efl/tables/mozilla/bugs/bug3260-expected.png:
- platform/efl/tables/mozilla/bugs/bug3263-expected.png:
- platform/efl/tables/mozilla/bugs/bug32841-expected.png:
- platform/efl/tables/mozilla/bugs/bug3309-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug3309-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug33137-expected.png:
- platform/efl/tables/mozilla/bugs/bug33855-expected.png:
- platform/efl/tables/mozilla/bugs/bug34176-expected.png:
- platform/efl/tables/mozilla/bugs/bug34538-expected.png:
- platform/efl/tables/mozilla/bugs/bug3454-expected.png:
- platform/efl/tables/mozilla/bugs/bug35662-expected.png:
- platform/efl/tables/mozilla/bugs/bug3681-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug3681-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug3718-expected.png:
- platform/efl/tables/mozilla/bugs/bug38916-expected.png:
- platform/efl/tables/mozilla/bugs/bug39209-expected.png:
- platform/efl/tables/mozilla/bugs/bug3977-expected.png:
- 5:03 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 4:32 AM Changeset in webkit [128989] by
-
- 17 edits3 adds in trunk/Source
[GTK] Add API to get/set the security policy of a given URI scheme to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=96497
Reviewed by Martin Robinson.
Source/WebCore:
- WebCore.exp.in: Add new exported symbols.
Source/WebKit2:
Add WebKitSecurityManager object associated to a WebKitWebContext
to get/set the security policy of a URI scheme.
- GNUmakefile.list.am: Add new files to compilation.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode): Encode the list of
schemes to be reigstered as Local, NoAccess, DisplayIsolated and
CORSEnabled.
(WebKit::WebProcessCreationParameters::decode): Decode the list of
schemes to be reigstered as Local, NoAccess, DisplayIsolated and
CORSEnabled.
- Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters): Add new parameters to be able to
register schemes as Local, NoAccess, DisplayIsolated and
CORSEnabled.
- UIProcess/API/gtk/WebKitSecurityManager.cpp: Added.
(webkit_security_manager_init):
(webkitSecurityManagerFinalize):
(webkit_security_manager_class_init):
(webkitSecurityManagerCreate): Private function to create the
WebKitSecurityManager object associated to the given
WebKitWebContext.
(registerSecurityPolicyForURIScheme):
(checkSecurityPolicyForURIScheme):
(webkit_security_manager_register_uri_scheme_as_local):
(webkit_security_manager_uri_scheme_is_local):
(webkit_security_manager_register_uri_scheme_as_no_access):
(webkit_security_manager_uri_scheme_is_no_access):
(webkit_security_manager_register_uri_scheme_as_display_isolated):
(webkit_security_manager_uri_scheme_is_display_isolated):
(webkit_security_manager_register_uri_scheme_as_secure):
(webkit_security_manager_uri_scheme_is_secure):
(webkit_security_manager_register_uri_scheme_as_cors_enabled):
(webkit_security_manager_uri_scheme_is_cors_enabled):
(webkit_security_manager_register_uri_scheme_as_empty_document):
(webkit_security_manager_uri_scheme_is_empty_document):
- UIProcess/API/gtk/WebKitSecurityManager.h: Added.
- UIProcess/API/gtk/WebKitSecurityManagerPrivate.h: Added.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_get_security_manager): Return the
WebKitSecurityManager object, creating it before if it doesn't exist.
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitSecurityManager.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextSecurityPolicy):
(beforeAll):
- UIProcess/API/gtk/webkit2.h: Add WebKitSecurityManager.h.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess): Copy new vector
schemes.
(WebKit::WebContext::registerURLSchemeAsLocal): Send a message to
WebProcess to register the given URL scheme as Local.
(WebKit::WebContext::registerURLSchemeAsNoAccess): Send a message
to WebProcess to register the given URL scheme as NoAccess.
(WebKit::WebContext::registerURLSchemeAsDisplayIsolated): Send a
message to WebProcess to register the given URL scheme as
DisplayIsolated.
(WebKit::WebContext::registerURLSchemeAsCORSEnabled): Send a
message to WebProcess to register the given URL scheme as
CORSEnabled.
- UIProcess/WebContext.h:
(WebContext):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::registerURLSchemeAsLocal): Register the
given URL scheme as Local in the SchemeRegistry.
(WebKit::WebProcess::registerURLSchemeAsNoAccess): Register the
given URL scheme as NoAccess in the SchemeRegistry.
(WebKit::WebProcess::registerURLSchemeAsDisplayIsolated): Register
the given URL scheme as DisplayIsolated in the SchemeRegistry.
(WebKit::WebProcess::registerURLSchemeAsCORSEnabled): Register the
given URL scheme as CORSEnabled in the SchemeRegistry.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: Add new messages.
- 4:15 AM Changeset in webkit [128988] by
-
- 14 edits in trunk/Source
[WIN] Use BString in favour of BSTR to improve memory management
https://bugs.webkit.org/show_bug.cgi?id=93128
Reviewed by Anders Carlsson.
BString automatically calls SysFreeString() in its destructor which helps
avoiding memory leaks. So it should be used instead of BSTR directly.
Add operator& to BString to allow its usage for out parameters too (like COMPtr).
This fixes already a few memory leaks in the existing code.
Source/WebCore:
- platform/win/BString.cpp:
(WebCore::BString::~BString):
(WebCore::BString::adoptBSTR):
(WebCore::BString::clear):
(WebCore):
- platform/win/BString.h:
(BString):
(WebCore::BString::operator&):
Source/WebKit/win:
- DefaultPolicyDelegate.cpp:
(DefaultPolicyDelegate::decidePolicyForNavigationAction):
(DefaultPolicyDelegate::decidePolicyForMIMEType):
(DefaultPolicyDelegate::unableToImplementPolicyWithError):
- MarshallingHelpers.cpp:
(MarshallingHelpers::KURLToBSTR):
(MarshallingHelpers::CFStringRefToBSTR):
(MarshallingHelpers::stringArrayToSafeArray):
(MarshallingHelpers::safeArrayToStringArray):
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::runJavaScriptPrompt):
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::checkGrammarOfString):
(WebEditorClient::getGuessesForWord):
- WebFrame.cpp:
(WebFrame::canProvideDocumentSource):
- WebHistory.cpp:
(WebHistory::removeItem):
(WebHistory::addItem):
- WebIconDatabase.cpp:
(WebIconDatabase::startUpIconDatabase):
- WebNotificationCenter.cpp:
(WebNotificationCenter::postNotification):
- WebPreferences.cpp:
(WebPreferences::setStringValue):
- WebView.cpp:
(toAtomicString):
(toString):
(toKURL):
(PreferencesChangedOrRemovedObserver::onNotify):
(WebView::close):
(WebView::canShowMIMEType):
(WebView::initWithFrame):
(WebView::setApplicationNameForUserAgent):
(WebView::setCustomUserAgent):
(WebView::userAgentForURL):
(WebView::setCustomTextEncodingName):
(WebView::customTextEncodingName):
(WebView::setPreferences):
(WebView::searchFor):
(WebView::executeCoreCommandByName):
(WebView::markAllMatchesForText):
(WebView::setGroupName):
(WebView::registerURLSchemeAsLocal):
(WebView::replaceSelectionWithText):
(WebView::onNotify):
(WebView::notifyPreferencesChanged):
(WebView::MIMETypeForExtension):
(WebView::standardUserAgentWithApplicationName):
(WebView::addAdditionalPluginDirectory):
(WebView::registerEmbeddedViewMIMEType):
(WebView::addOriginAccessWhitelistEntry):
(WebView::removeOriginAccessWhitelistEntry):
(WebView::geolocationDidFailWithError):
(WebView::setDomainRelaxationForbiddenForURLScheme):
(WebView::setCompositionForTesting):
(WebView::confirmCompositionForTesting):
- 4:12 AM Changeset in webkit [128987] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Link failure with bfd linker on --minimal build
https://bugs.webkit.org/show_bug.cgi?id=97075
Reviewed by Tor Arne Vestbø.
Fix two dependency errors triggered by --minimal:
- GStreamerVersioning.cpp uses functions from libgstvideo (gst_video_format_parse_caps), so we need to pull
that module not only when video is enabled by generally when using gstreamer.
- GraphicsSurfaceGLX depends on Xlib (XOpenDisplay, etc.), so we need to do CONFIG += x11 to get that and not
implicitly rely on x11 netscape plugins being enabled.
- WebCore.pri:
- 3:55 AM Changeset in webkit [128986] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Updated expectations for the WK2 GTK bot.
- platform/gtk-wk2/TestExpectations:
- 3:52 AM Changeset in webkit [128985] by
-
- 140 edits in trunk/LayoutTests
[EFL] tables/mozilla tests need rebaseline (Part 3)
https://bugs.webkit.org/show_bug.cgi?id=97090
Unreviewed EFL gardening.
Rebaseline pixel tests expectations for tables/mozilla/marvin/x_*
tests.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
- platform/efl/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/x_caption_align_top-expected.png:
- platform/efl/tables/mozilla/marvin/x_caption_class-expected.png:
- platform/efl/tables/mozilla/marvin/x_caption_id-expected.png:
- platform/efl/tables/mozilla/marvin/x_caption_style-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_span-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_width_pct-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_width_px-expected.png:
- platform/efl/tables/mozilla/marvin/x_col_width_rel-expected.png:
- platform/efl/tables/mozilla/marvin/x_colgroup_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/x_colgroup_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/x_colgroup_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/x_colgroup_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/x_colgroup_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/x_colgroup_span-expected.png:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/x_colgroup_width_pct-expected.png:
- platform/efl/tables/mozilla/marvin/x_colgroup_width_rel-expected.png:
- platform/efl/tables/mozilla/marvin/x_table-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_border-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_border_none-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_border_px-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_cellpadding-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_cellspacing-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_class-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_id-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_rules_groups-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_rules_none-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_style-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_width_pct-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_width_px-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_class-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_id-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_style-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_class-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_colspan-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_height-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_id-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_nowrap-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_rowspan-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_style-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/x_td_width-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_class-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_colspan-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_height-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_id-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_nowrap-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_rowspan-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_style-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/x_th_width-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_class-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_id-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_style-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_class-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_id-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_style-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/x_tr_valign_top-expected.png:
- 3:45 AM Changeset in webkit [128984] by
-
- 175 edits in trunk/LayoutTests
[EFL] tables/mozilla tests need rebaseline (Part 4)
https://bugs.webkit.org/show_bug.cgi?id=97091
Unreviewed EFL gardening.
Rebaseline remaining pixel test expectations for
tables/mozilla/marvin/ tests.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
- platform/efl/tables/mozilla/marvin/backgr_index-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_position-table-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
- platform/efl/tables/mozilla/marvin/body_col-expected.png:
- platform/efl/tables/mozilla/marvin/body_tbody-expected.png:
- platform/efl/tables/mozilla/marvin/body_tfoot-expected.png:
- platform/efl/tables/mozilla/marvin/body_thead-expected.png:
- platform/efl/tables/mozilla/marvin/col_span-expected.png:
- platform/efl/tables/mozilla/marvin/colgroup_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/colgroup_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/colgroup_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/colgroup_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/colgroup_span-expected.png:
- platform/efl/tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/colgroup_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/colgroup_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/colgroup_width_pct-expected.png:
- platform/efl/tables/mozilla/marvin/colgroup_width_px-expected.png:
- platform/efl/tables/mozilla/marvin/table_frame_border-expected.png:
- platform/efl/tables/mozilla/marvin/table_frame_box-expected.png:
- platform/efl/tables/mozilla/marvin/table_overflow_hidden_td-expected.png:
- platform/efl/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.png:
- platform/efl/tables/mozilla/marvin/table_row_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/table_row_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/table_row_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/table_rules_all-expected.png:
- platform/efl/tables/mozilla/marvin/table_rules_groups-expected.png:
- platform/efl/tables/mozilla/marvin/table_rules_none-expected.png:
- platform/efl/tables/mozilla/marvin/tables_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/tables_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/tables_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_aqua-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_black-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_blue-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_gray-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_green-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_lime-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_maroon-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_navy-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_olive-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_purple-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_red-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_silver-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_teal-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_white-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_yellow-expected.png:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tables_border_0-expected.png:
- platform/efl/tables/mozilla/marvin/tables_border_1-expected.png:
- platform/efl/tables/mozilla/marvin/tables_border_2-expected.png:
- platform/efl/tables/mozilla/marvin/tables_border_3-expected.png:
- platform/efl/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
- platform/efl/tables/mozilla/marvin/tables_caption_align_top-expected.png:
- platform/efl/tables/mozilla/marvin/tables_cellpadding-expected.png:
- platform/efl/tables/mozilla/marvin/tables_cellpadding_pct-expected.png:
- platform/efl/tables/mozilla/marvin/tables_cellspacing-expected.png:
- platform/efl/tables/mozilla/marvin/tables_class-expected.png:
- platform/efl/tables/mozilla/marvin/tables_default-expected.png:
- platform/efl/tables/mozilla/marvin/tables_id-expected.png:
- platform/efl/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
- platform/efl/tables/mozilla/marvin/tables_style-expected.png:
- platform/efl/tables/mozilla/marvin/tables_td_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/tables_td_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/tables_td_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/tables_td_colspan-expected.png:
- platform/efl/tables/mozilla/marvin/tables_td_height-expected.png:
- platform/efl/tables/mozilla/marvin/tables_td_nowrap-expected.png:
- platform/efl/tables/mozilla/marvin/tables_td_rowspan-expected.png:
- platform/efl/tables/mozilla/marvin/tables_td_width-expected.png:
- platform/efl/tables/mozilla/marvin/tables_th_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/tables_th_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/tables_th_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/tables_th_colspan-expected.png:
- platform/efl/tables/mozilla/marvin/tables_th_height-expected.png:
- platform/efl/tables/mozilla/marvin/tables_th_rowspan-expected.png:
- platform/efl/tables/mozilla/marvin/tables_th_width-expected.png:
- platform/efl/tables/mozilla/marvin/tables_width_percent-expected.png:
- platform/efl/tables/mozilla/marvin/tables_width_px-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_char-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_char-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/thead_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/thead_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/thead_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/thead_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/thead_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/thead_char-expected.png:
- platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_black-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_blue-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_gray-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_green-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_lime-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_maroon-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_navy-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_olive-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_purple-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_red-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_silver-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_teal-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_white-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_yellow-expected.png:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.png:
- platform/efl/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/tr_valign_top-expected.png:
- 3:17 AM Changeset in webkit [128983] by
-
- 93 edits87 adds in trunk/LayoutTests
[EFL] tables/mozilla tests need rebaseline (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=97089
Unreviewed EFL gardening.
Rebaseline remaining tables/mozilla/ tests and unskip
them.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
- platform/efl/Skipped:
- platform/efl/tables/mozilla/bugs/45621-expected.txt:
- platform/efl/tables/mozilla/bugs/bug101674-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10269-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1055-1-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug10565-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug10633-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug106816-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug11026-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug113235-1-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug113424-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug11384q-expected.txt:
- platform/efl/tables/mozilla/bugs/bug11384s-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1163-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1188-expected.txt:
- platform/efl/tables/mozilla/bugs/bug119786-expected.txt:
- platform/efl/tables/mozilla/bugs/bug120107-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug12384-expected.txt:
- platform/efl/tables/mozilla/bugs/bug126742-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug1271-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug12908-1-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug12908-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug1296-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug1302-expected.txt:
- platform/efl/tables/mozilla/bugs/bug131020-expected.txt:
- platform/efl/tables/mozilla/bugs/bug13118-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug13169-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug1318-expected.txt:
- platform/efl/tables/mozilla/bugs/bug138725-expected.txt:
- platform/efl/tables/mozilla/bugs/bug139524-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug1430-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug14929-expected.txt:
- platform/efl/tables/mozilla/bugs/bug154780-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug15544-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug159108-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug17130-1-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug17130-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug17138-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug18359-expected.txt:
- platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug194024-expected.txt:
- platform/efl/tables/mozilla/bugs/bug196870-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug2123-expected.txt:
- platform/efl/tables/mozilla/bugs/bug215629-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug222846-expected.txt:
- platform/efl/tables/mozilla/bugs/bug24200-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2479-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2509-expected.txt:
- platform/efl/tables/mozilla/bugs/bug26178-expected.txt:
- platform/efl/tables/mozilla/bugs/bug26553-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug2886-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug28928-expected.txt:
- platform/efl/tables/mozilla/bugs/bug29058-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug29157-expected.txt:
- platform/efl/tables/mozilla/bugs/bug29314-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug29326-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2947-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2981-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug30559-expected.txt:
- platform/efl/tables/mozilla/bugs/bug30692-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3309-1-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug3309-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug33137-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug33855-expected.txt:
- platform/efl/tables/mozilla/bugs/bug34176-expected.txt:
- platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
- platform/efl/tables/mozilla/bugs/bug39209-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4093-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug42187-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug4284-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug4382-expected.txt:
- platform/efl/tables/mozilla/bugs/bug43854-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug4427-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug4429-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46480-1-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug46480-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug48028-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug48028-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug50695-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug51037-expected.txt:
- platform/efl/tables/mozilla/bugs/bug51727-expected.txt:
- platform/efl/tables/mozilla/bugs/bug52505-expected.txt:
- platform/efl/tables/mozilla/bugs/bug52506-expected.txt:
- platform/efl/tables/mozilla/bugs/bug5538-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug55527-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug55545-expected.txt:
- platform/efl/tables/mozilla/bugs/bug56563-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug5797-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug5838-expected.txt:
- platform/efl/tables/mozilla/bugs/bug59354-expected.txt:
- platform/efl/tables/mozilla/bugs/bug60749-expected.txt:
- platform/efl/tables/mozilla/bugs/bug625-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug6304-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6404-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug67915-1-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug69187-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug7112-1-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug7112-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug73321-expected.txt:
- platform/efl/tables/mozilla/bugs/bug7342-expected.txt:
- platform/efl/tables/mozilla/bugs/bug8032-1-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug82946-2-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug83786-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug8381-expected.txt:
- platform/efl/tables/mozilla/bugs/bug86708-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9271-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9271-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug96334-expected.txt:
- platform/efl/tables/mozilla/bugs/bug99948-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/backgr_index-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/efl/tables/mozilla/marvin/table_frame_border-expected.txt:
- platform/efl/tables/mozilla/marvin/table_frame_box-expected.txt:
- platform/efl/tables/mozilla/marvin/table_rules_all-expected.txt:
- platform/efl/tables/mozilla/marvin/table_rules_none-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/td_valign_baseline-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/td_valign_bottom-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/td_valign_middle-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/td_valign_top-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/th_valign_baseline-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/th_valign_bottom-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/th_valign_middle-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/th_valign_top-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/tr_valign_baseline-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/tr_valign_bottom-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/tr_valign_middle-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/tr_valign_top-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_caption_class-expected.txt:
- platform/efl/tables/mozilla/marvin/x_caption_id-expected.txt:
- platform/efl/tables/mozilla/marvin/x_caption_style-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_align_center-expected.txt: Added.
- platform/efl/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/other/cell_widths-expected.txt: Added.
- platform/efl/tables/mozilla/other/move_row-expected.txt:
- platform/efl/tables/mozilla/other/test3-expected.txt:
- platform/efl/tables/mozilla/other/test6-expected.txt:
- platform/efl/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- 2:43 AM Changeset in webkit [128982] by
-
- 7 edits in trunk
MediaStream API: Rename the RTCIceServer uri parameter to url.
https://bugs.webkit.org/show_bug.cgi?id=97086
Reviewed by Hajime Morita.
Source/WebCore:
Either the standard has changed or I can't read.
http://dev.w3.org/2011/webrtc/editor/webrtc.html#dictionary-rtciceserver-members
Existing tests changed to cover this patch.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::parseConfiguration):
LayoutTests:
- fast/mediastream/RTCPeerConnection-expected.txt:
- fast/mediastream/RTCPeerConnection.html:
- fast/mediastream/constructors-expected.txt:
- fast/mediastream/constructors.html:
- 2:39 AM Changeset in webkit [128981] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION(r128910): inspector/extensions/extensions-panel.html fails
https://bugs.webkit.org/show_bug.cgi?id=97084
Unreviewed gardeing.
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-09-19
- platform/qt/Skipped:
- 2:10 AM Changeset in webkit [128980] by
-
- 3 edits in trunk/Source/WebKit2
[Texmap] Potential crash in TextureMapperLayer because of referencing deleted mask/replica layer
https://bugs.webkit.org/show_bug.cgi?id=96919
Reviewed by Noam Rosenthal.
Delay syncing deleted layers until flushPendingLayerChanges so the UI side state
will contain all changes related to the deletion of a layer. This saves us from
referencing a deleted layer.
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::detachLayer):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- 2:07 AM EFLWebKit edited by
- (diff)
- 2:04 AM EFLHistoryApiTutorial created by
- Initial version of the page.
- 1:50 AM Changeset in webkit [128979] by
-
- 25 edits8 moves in trunk
Unreviewed, rolling out r128976.
http://trac.webkit.org/changeset/128976
https://bugs.webkit.org/show_bug.cgi?id=97083
Breaks compilation on QT, Apple WIn (Requested by vsevik on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-19
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLCanvasElementCustom.cpp:
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
- inspector/CodeGeneratorInspector.py:
- inspector/InjectedScriptWebGLModule.cpp: Renamed from Source/WebCore/inspector/InjectedScriptCanvasModule.cpp.
(WebCore):
(WebCore::InjectedScriptWebGLModule::InjectedScriptWebGLModule):
(WebCore::InjectedScriptWebGLModule::moduleForState):
(WebCore::InjectedScriptWebGLModule::source):
(WebCore::InjectedScriptWebGLModule::wrapWebGLContext):
(WebCore::InjectedScriptWebGLModule::captureFrame):
(WebCore::InjectedScriptWebGLModule::dropTraceLog):
(WebCore::InjectedScriptWebGLModule::traceLog):
(WebCore::InjectedScriptWebGLModule::replayTraceLog):
- inspector/InjectedScriptWebGLModule.h: Renamed from Source/WebCore/inspector/InjectedScriptCanvasModule.h.
(WebCore):
(InjectedScriptWebGLModule):
- inspector/InjectedScriptWebGLModuleSource.js: Renamed from Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js.
(.):
- inspector/Inspector.json:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorWebGLAgent.cpp: Renamed from Source/WebCore/inspector/InspectorCanvasAgent.cpp.
(WebCore):
(WebGLAgentState):
(WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::~InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::setFrontend):
(WebCore::InspectorWebGLAgent::clearFrontend):
(WebCore::InspectorWebGLAgent::restore):
(WebCore::InspectorWebGLAgent::enable):
(WebCore::InspectorWebGLAgent::disable):
(WebCore::InspectorWebGLAgent::dropTraceLog):
(WebCore::InspectorWebGLAgent::captureFrame):
(WebCore::InspectorWebGLAgent::getTraceLog):
(WebCore::InspectorWebGLAgent::replayTraceLog):
(WebCore::InspectorWebGLAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorWebGLAgent::injectedScriptWebGLModuleForTraceLogId):
- inspector/InspectorWebGLAgent.h: Renamed from Source/WebCore/inspector/InspectorCanvasAgent.h.
(WebCore):
(InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::create):
(WebCore::InspectorWebGLAgent::enabled):
- inspector/InspectorWebGLInstrumentation.h: Renamed from Source/WebCore/inspector/InspectorCanvasInstrumentation.h.
(WebCore):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):
- inspector/InstrumentingAgents.h:
(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorWebGLAgent):
(WebCore::InstrumentingAgents::setInspectorWebGLAgent):
- inspector/compile-front-end.py:
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/WebGLProfileView.js: Renamed from Source/WebCore/inspector/front-end/CanvasProfileView.js.
(WebInspector.WebGLProfileView):
(WebInspector.WebGLProfileView.prototype.dispose):
(WebInspector.WebGLProfileView.prototype.get statusBarItems):
(WebInspector.WebGLProfileView.prototype.get profile):
(WebInspector.WebGLProfileView.prototype.wasShown):
(WebInspector.WebGLProfileView.prototype.willHide):
(WebInspector.WebGLProfileView.prototype._showTraceLog):
(WebInspector.WebGLProfileView.prototype._onTraceLogItemClick.didReplayTraceLog):
(WebInspector.WebGLProfileView.prototype._onTraceLogItemClick):
(WebInspector.WebGLProfileType):
(WebInspector.WebGLProfileType.prototype.get buttonTooltip):
(WebInspector.WebGLProfileType.prototype.buttonClicked.didStartCapturingFrame):
(WebInspector.WebGLProfileType.prototype.buttonClicked):
(WebInspector.WebGLProfileType.prototype.get treeItemTitle):
(WebInspector.WebGLProfileType.prototype.get description):
(WebInspector.WebGLProfileType.prototype.reset):
(WebInspector.WebGLProfileType.prototype.createTemporaryProfile):
(WebInspector.WebGLProfileType.prototype.createProfile):
(WebInspector.WebGLProfileHeader):
(WebInspector.WebGLProfileHeader.prototype.traceLogId):
(WebInspector.WebGLProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.WebGLProfileHeader.prototype.createView):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/webGLProfiler.css: Renamed from Source/WebCore/inspector/front-end/canvasProfiler.css.
(.webgl-profile-view):
(.webgl-trace-log):
(.webgl-trace-log div):
(#webgl-replay-image-container):
(#webgl-replay-image):
LayoutTests:
- inspector/profiler/webgl/webgl-profiler-get-error.html:
- inspector/profiler/webgl/webgl-profiler-test.js:
(initialize_WebGLProfilerTest.InspectorTest.enableWebGLAgent):
(initialize_WebGLProfilerTest):
- 1:43 AM Changeset in webkit [128978] by
-
- 2 edits in trunk/Source/WebCore
[Qt][Win] Fix rendering of flash content when scrolling
https://bugs.webkit.org/show_bug.cgi?id=92905
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-09-19
Reviewed by Jocelyn Turcotte.
Fix rendering offset similar to r121441.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paint):
(WebCore::PluginView::setNPWindowRect):
- 1:30 AM Changeset in webkit [128977] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Updated the recently added TestExpectations file for WK2 with the
actual failures from the bot.
- platform/gtk-wk2/TestExpectations:
- 1:08 AM Changeset in webkit [128976] by
-
- 25 edits8 moves in trunk
Web Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent
https://bugs.webkit.org/show_bug.cgi?id=96917
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-19
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Rename WebGLAgent* and WebGLInstrumentation* files to Canvas* as we will support both 2D and 3D/WebGL canvas instrumentation.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLCanvasElementCustom.cpp:
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
- inspector/CodeGeneratorInspector.py:
- inspector/InjectedScriptCanvasModule.cpp: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModule.cpp.
(WebCore):
(WebCore::InjectedScriptCanvasModule::InjectedScriptCanvasModule):
(WebCore::InjectedScriptCanvasModule::moduleForState):
(WebCore::InjectedScriptCanvasModule::source):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::captureFrame):
(WebCore::InjectedScriptCanvasModule::dropTraceLog):
(WebCore::InjectedScriptCanvasModule::traceLog):
(WebCore::InjectedScriptCanvasModule::replayTraceLog):
- inspector/InjectedScriptCanvasModule.h: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModule.h.
(WebCore):
(InjectedScriptCanvasModule):
- inspector/InjectedScriptCanvasModuleSource.js: Renamed from Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js.
(.):
- inspector/Inspector.json:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorCanvasAgent.cpp: Renamed from Source/WebCore/inspector/InspectorWebGLAgent.cpp.
(WebCore):
(CanvasAgentState):
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::~InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::setFrontend):
(WebCore::InspectorCanvasAgent::clearFrontend):
(WebCore::InspectorCanvasAgent::restore):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
(WebCore::InspectorCanvasAgent::dropTraceLog):
(WebCore::InspectorCanvasAgent::captureFrame):
(WebCore::InspectorCanvasAgent::getTraceLog):
(WebCore::InspectorCanvasAgent::replayTraceLog):
(WebCore::InspectorCanvasAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::injectedScriptCanvasModuleForTraceLogId):
- inspector/InspectorCanvasAgent.h: Renamed from Source/WebCore/inspector/InspectorWebGLAgent.h.
(WebCore):
(InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::create):
(WebCore::InspectorCanvasAgent::enabled):
- inspector/InspectorCanvasInstrumentation.h: Renamed from Source/WebCore/inspector/InspectorWebGLInstrumentation.h.
(WebCore):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InstrumentingAgents.h:
(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorCanvasAgent):
(WebCore::InstrumentingAgents::setInspectorCanvasAgent):
(InstrumentingAgents):
- inspector/compile-front-end.py:
- inspector/front-end/CanvasProfileView.js: Renamed from Source/WebCore/inspector/front-end/WebGLProfileView.js.
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype.get statusBarItems):
(WebInspector.CanvasProfileView.prototype.get profile):
(WebInspector.CanvasProfileView.prototype.wasShown):
(WebInspector.CanvasProfileView.prototype.willHide):
(WebInspector.CanvasProfileView.prototype._showTraceLog):
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick):
(WebInspector.CanvasProfileType):
(WebInspector.CanvasProfileType.prototype.get buttonTooltip):
(WebInspector.CanvasProfileType.prototype.buttonClicked.didStartCapturingFrame):
(WebInspector.CanvasProfileType.prototype.buttonClicked):
(WebInspector.CanvasProfileType.prototype.get treeItemTitle):
(WebInspector.CanvasProfileType.prototype.get description):
(WebInspector.CanvasProfileType.prototype.reset):
(WebInspector.CanvasProfileType.prototype.createTemporaryProfile):
(WebInspector.CanvasProfileType.prototype.createProfile):
(WebInspector.CanvasProfileHeader):
(WebInspector.CanvasProfileHeader.prototype.traceLogId):
(WebInspector.CanvasProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.CanvasProfileHeader.prototype.createView):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/canvasProfiler.css: Renamed from Source/WebCore/inspector/front-end/webGLProfiler.css.
(.canvas-profile-view):
(.canvas-trace-log):
(.canvas-trace-log div):
(#canvas-replay-image-container):
(#canvas-replay-image):
LayoutTests:
- inspector/profiler/webgl/webgl-profiler-get-error.html:
- inspector/profiler/webgl/webgl-profiler-test.js:
(initialize_CanvasWebGLProfilerTest.InspectorTest.enableCanvasAgent):
(initialize_CanvasWebGLProfilerTest):
- 1:04 AM Changeset in webkit [128975] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] waitUntilTitleChangedTo() and waitUntilLoadFinished() needs timeout.
https://bugs.webkit.org/show_bug.cgi?id=96910
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.
Currently, the waitUntilTitleChangedTo() and waitUntilLoadFinished()
functions doesn't handle timeout by itself.
And if there are some failed cases that loading is not finished or
title is not changed to the expected string, test case just stopped
with timeout and there is no more information about this such as line
number.
To handle timeout status more properly, timeout parameter is added to
these functions.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::LoadFinishedData::LoadFinishedData):
(LoadFinishedData):
(EWK2UnitTest::LoadFinishedData::~LoadFinishedData):
(EWK2UnitTest):
(EWK2UnitTest::onLoadFinished):
(EWK2UnitTest::timeOutWhileWaitingUntilLoadFinished):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilLoadFinished):
(EWK2UnitTest::TitleChangedData::TitleChangedData):
(TitleChangedData):
(EWK2UnitTest::TitleChangedData::~TitleChangedData):
(EWK2UnitTest::onTitleChanged):
(EWK2UnitTest::timeOutWhileWaitingUntilTitleChangedTo):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTitleChangedTo):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
- 1:00 AM Changeset in webkit [128974] by
-
- 68 edits4 adds in trunk/LayoutTests
[EFL] tables/mozilla tests need rebaseline (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=97079
Unreviewed EFL gardening.
Rebaseline a first part of the tables/mozilla tests
and unskip them.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
- platform/efl/Skipped:
- platform/efl/tables/mozilla/collapsing_borders/bug127040-expected.png:
- platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/efl/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/efl/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/efl/tables/mozilla/core/bloomberg-expected.png:
- platform/efl/tables/mozilla/core/bloomberg-expected.txt: Added.
- platform/efl/tables/mozilla/core/borders-expected.png:
- platform/efl/tables/mozilla/core/box_sizing-expected.png:
- platform/efl/tables/mozilla/core/captions-expected.png:
- platform/efl/tables/mozilla/core/captions-expected.txt:
- platform/efl/tables/mozilla/core/cell_heights-expected.png:
- platform/efl/tables/mozilla/core/cell_heights-expected.txt:
- platform/efl/tables/mozilla/core/col_span-expected.png:
- platform/efl/tables/mozilla/core/col_widths_auto_auto-expected.png:
- platform/efl/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/efl/tables/mozilla/core/col_widths_auto_autoFix-expected.txt: Added.
- platform/efl/tables/mozilla/core/col_widths_auto_autoFixPer-expected.png:
- platform/efl/tables/mozilla/core/col_widths_auto_autoPer-expected.png:
- platform/efl/tables/mozilla/core/col_widths_auto_fix-expected.png:
- platform/efl/tables/mozilla/core/col_widths_auto_fixPer-expected.png:
- platform/efl/tables/mozilla/core/col_widths_auto_per-expected.png:
- platform/efl/tables/mozilla/core/col_widths_fix_auto-expected.png:
- platform/efl/tables/mozilla/core/col_widths_fix_autoFix-expected.png:
- platform/efl/tables/mozilla/core/col_widths_fix_autoPer-expected.png:
- platform/efl/tables/mozilla/core/col_widths_fix_fix-expected.png:
- platform/efl/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
- platform/efl/tables/mozilla/core/col_widths_fix_per-expected.png:
- platform/efl/tables/mozilla/core/margins-expected.png:
- platform/efl/tables/mozilla/core/margins-expected.txt:
- platform/efl/tables/mozilla/core/misc-expected.png:
- platform/efl/tables/mozilla/core/misc-expected.txt: Added.
- platform/efl/tables/mozilla/core/nested1-expected.png:
- platform/efl/tables/mozilla/core/one_row-expected.png:
- platform/efl/tables/mozilla/core/row_span-expected.png:
- platform/efl/tables/mozilla/core/row_span-expected.txt: Added.
- platform/efl/tables/mozilla/core/table_frame-expected.png:
- platform/efl/tables/mozilla/core/table_heights-expected.png:
- platform/efl/tables/mozilla/core/table_rules-expected.png:
- platform/efl/tables/mozilla/core/table_rules-expected.txt:
- platform/efl/tables/mozilla/core/table_widths-expected.png:
- platform/efl/tables/mozilla/dom/appendCol2-expected.png:
- platform/efl/tables/mozilla/dom/appendRowsExpand1-expected.png:
- platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.png:
- platform/efl/tables/mozilla/dom/deleteCellsRebuild1-expected.png:
- platform/efl/tables/mozilla/dom/deleteCellsShrink1-expected.png:
- platform/efl/tables/mozilla/dom/deleteCellsShrink2-expected.png:
- platform/efl/tables/mozilla/dom/deleteCol1-expected.png:
- platform/efl/tables/mozilla/dom/deleteCol2-expected.png:
- platform/efl/tables/mozilla/dom/deleteCol3-expected.png:
- platform/efl/tables/mozilla/dom/deleteColGroup1-expected.png:
- platform/efl/tables/mozilla/dom/deleteColGroup2-expected.png:
- platform/efl/tables/mozilla/dom/deleteRowsRebuild1-expected.png:
- platform/efl/tables/mozilla/dom/deleteRowsShrink1-expected.png:
- platform/efl/tables/mozilla/dom/deleteTbodyExpand1-expected.png:
- platform/efl/tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
- platform/efl/tables/mozilla/dom/insertCellsExpand1-expected.png:
- platform/efl/tables/mozilla/dom/insertCellsExpand2-expected.png:
- platform/efl/tables/mozilla/dom/insertCellsRebuild1-expected.png:
- platform/efl/tables/mozilla/dom/insertCellsRebuild2-expected.png:
- platform/efl/tables/mozilla/dom/insertColGroups1-expected.png:
- platform/efl/tables/mozilla/dom/insertColGroups2-expected.png:
- platform/efl/tables/mozilla/dom/insertCols1-expected.png:
- platform/efl/tables/mozilla/dom/insertCols2-expected.png:
- platform/efl/tables/mozilla/dom/insertCols3-expected.png:
- platform/efl/tables/mozilla/dom/insertCols4-expected.png:
- platform/efl/tables/mozilla/dom/insertCols5-expected.png:
- platform/efl/tables/mozilla/dom/insertRowsExpand1-expected.png:
- platform/efl/tables/mozilla/dom/insertRowsRebuild1-expected.png:
- platform/efl/tables/mozilla/dom/tableDom-expected.png:
- platform/efl/tables/mozilla/dom/tableDom-expected.txt:
- 12:26 AM Changeset in webkit [128973] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip inspector/extensions/extensions-panel.html
https://bugs.webkit.org/show_bug.cgi?id=97078
Unreviewed EFL gardening.
Skip inspector/extensions/extensions-panel.html for
EFL port since it started failing after r128910.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
- platform/efl-wk1/TestExpectations:
- 12:20 AM Changeset in webkit [128972] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Fix crash in WebFrameImpl::loadHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=96352
Reviewed by Adam Barth.
We have some crash reports with the following stack:
- HistoryItem::shouldDoSameDocumentNavigationTo.
- WebFrameImpl::loadHistoryItem ...
We don't have reproducible steps, and not sure what's the root
cause. Anyway we should check nullness of currentItem because
HistoryController::m_currentItem can be 0.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadHistoryItem):
Check nullness of currentItem.
- 12:00 AM Changeset in webkit [128971] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip several JS tests that crash after r128802
https://bugs.webkit.org/show_bug.cgi?id=97074
Unreviewed EFL gardening.
Move several JS test cases to TestExpectations because
they are consistently crashing on our debug bots
after r128802.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18
- platform/efl/TestExpectations:
Sep 18, 2012:
- 11:56 PM Changeset in webkit [128970] by
-
- 1 edit1 add in trunk/LayoutTests
[EFL] Generate baseline for media/video-controls-visible-audio-only.html
https://bugs.webkit.org/show_bug.cgi?id=97073
Unreviewed EFL gardening.
Generate missing baseline for media/video-controls-visible-audio-only.html
on EFL port.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18
- platform/efl/media/video-controls-visible-audio-only-expected.txt: Added.
- 11:48 PM WebKitGTK/WebKit2Roadmap edited by
- User agent done! (diff)
- 11:35 PM Changeset in webkit [128969] by
-
- 3 edits in trunk/LayoutTests
[EFL] Move several test cases to efl-wk1 TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97072
Unreviewed EFL gardening.
Move several test cases to efl-wk1 TestExpectations
since they don't fail on the WebKit2 bots.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 11:19 PM Changeset in webkit [128968] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] SkiaGetGlyphWidthAndExtents() should invert y-axis
https://bugs.webkit.org/show_bug.cgi?id=97067
Reviewed by Yuta Kitamura.
Invert skBounds.fTop and skBounds.height(). Don't call hb_font_set_ppem().
No new tests. Arabic shadda (U+0651) should be placed more higher when Arabic lam (U+0644) follows it.
Tests under svg/W3C-I18N contain such sequences so these tests cover this change.
- platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp:
(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::HarfBuzzNGFace::createFont):
- 10:57 PM Changeset in webkit [128967] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Add javascript popup API.
https://bugs.webkit.org/show_bug.cgi?id=95672
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-18
Reviewed by Gyuyoung Kim.
Add smart class member function for javascript alert(), confirm() and prompt().
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_run_javascript_alert):
(ewk_view_run_javascript_confirm):
(ewk_view_run_javascript_prompt):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_private.h:
- UIProcess/API/efl/ewk_view_ui_client.cpp:
(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(ewk_view_ui_client_attach):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
Added unit test for javascript popup smart class member function.
(checkAlert):
(TEST_F):
(checkConfirm):
(checkPrompt):
- 10:41 PM Changeset in webkit [128966] by
-
- 2 edits in trunk/Tools
[WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
https://bugs.webkit.org/show_bug.cgi?id=96181
Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-18
Reviewed by Daniel Bates.
This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
- WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
(new):
(_parseLicenseBlock):
(_parseLicenseBlockFromFile):
(_defaultLicenseBlock):
(_licenseBlock):
(_generateHeaderFile):
(_generateImplementationFile):
- 10:26 PM Changeset in webkit [128965] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Don't treat tab as spaces for word-end in HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=97068
Reviewed by Yuta Kitamura.
No new tests. fast/text/wide-zero-width-space.html should cover this change.
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::normalizeCharacters): Don't treat tab as space.
- 9:21 PM Changeset in webkit [128964] by
-
- 2 edits in trunk/Source/WebCore
Check settings before registering AVFoundation media engine.
https://bugs.webkit.org/show_bug.cgi?id=97048
<rdar://problem/12313594>
Reviewed by Dan Bernstein.
Fix the bug introduced in r122676.
- platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Uncomment the call to check AVFoundation settings.
- 8:39 PM Changeset in webkit [128963] by
-
- 32 edits2 adds in trunk
Chromium: Scrollbar with tickmarks doesn't respond to clicks
https://bugs.webkit.org/show_bug.cgi?id=96049
Patch by Sailesh Agrawal <sail@chromium.org> on 2012-09-18
Reviewed by Beth Dakin.
.:
Update exported symbols.
- Source/autotools/symbols.filter:
Source/Platform:
Added isAlphaLocked and setIsAlphaLocked.
- chromium/public/WebScrollbar.h:
(WebScrollbar):
Source/WebCore:
Currently when a scrollbar has tickmarks its forced to be visible by setting its alpha to 1.0. The alpha value is reset to its old value at the end of the drawing routine. This approach doesn't work with the hit testing code which relies on the scrollbar's alpha value
Unfortunately there doesn't seem to be anyway to force a scrollbar to be visible. The closest API is -[NSScrollerImpPair lockOverlayScrollerState:]. Unfortunately this locks both the horizontal and vertical scrollbar. It also doesn't expand the knob width.
My fix simply adds a new alphaLocked attribute to the scrollbar. If this attribute is set to true then hit testing will return true.
Test: fast/scrolling/scrollbar-tickmarks-hittest.html
- WebCore.exp.in:
- WebCore.order:
- page/Settings.cpp:
(WebCore):
(WebCore::Settings::setUsesOverlayScrollbars): Sets the usesOverlayScrollbars flag.
(WebCore::Settings::usesOverlayScrollbars): Gets the usesOverlayScrollbars flag.
- page/Settings.h:
(Settings):
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar):
- platform/Scrollbar.h:
(WebCore::Scrollbar::isAlphaLocked):
(WebCore::Scrollbar::setIsAlphaLocked):
(Scrollbar):
- platform/ScrollbarThemeClient.h:
(ScrollbarThemeClient):
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint): Updated to set and unset the alphaLocked attribute.
- platform/chromium/support/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::isAlphaLocked):
(WebKit):
(WebKit::WebScrollbarImpl::setIsAlphaLocked):
- platform/chromium/support/WebScrollbarImpl.h:
(WebScrollbarImpl):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isAlphaLocked):
(WebCore):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::setIsAlphaLocked):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbar):
(CCScrollbarLayerImpl):
- platform/mac/NSScrollerImpDetails.mm:
(WebCore::recommendedScrollerStyle): Check the usesOverlayScrollbars setting to see if overlay scrollbars should be forced on.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::shouldScrollbarParticipateInHitTesting): Updated to check the alphaLocked attribute.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::reset): Resets the usesOverlayScrollbars setting.
(WebCore::InternalSettings::setUsesOverlayScrollbars): Sets the usesOverlayScrollbars setting.
(WebCore):
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl: Add a new setUsesOverlayScrollbars function.
Source/WebKit/chromium:
Pipe isAlphaLocked and setIsAlphaLocked.
- src/WebPluginScrollbarImpl.cpp:
(WebKit::WebPluginScrollbarImpl::isAlphaLocked):
(WebKit):
(WebKit::WebPluginScrollbarImpl::setIsAlphaLocked):
- src/WebPluginScrollbarImpl.h:
(WebPluginScrollbarImpl):
- src/WebScrollbarThemeClientImpl.cpp:
(WebKit::WebScrollbarThemeClientImpl::isAlphaLocked):
(WebKit):
(WebKit::WebScrollbarThemeClientImpl::setIsAlphaLocked):
- src/WebScrollbarThemeClientImpl.h:
(WebScrollbarThemeClientImpl):
- tests/ScrollbarLayerChromiumTest.cpp:
Source/WebKit2:
Update exported symbols.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- fast/scrolling/scrollbar-tickmarks-hittest-expected.txt: Added.
- fast/scrolling/scrollbar-tickmarks-hittest.html: Added.
- 8:33 PM Changeset in webkit [128962] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Add log macros for EINA_LOG_DOM_XXX series
https://bugs.webkit.org/show_bug.cgi?id=97061
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-18
Reviewed by Gyuyoung Kim.
EFL Webkit2 is using the EINA_LOG_DOM_XXX series in several places to log a message on the specified domain and format.
This patch adds log macros to simplify these logging codes.
- UIProcess/API/efl/ewk_main.cpp:
(ewk_init):
- UIProcess/API/efl/ewk_private.h:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_webprocess_crashed):
- 8:08 PM Changeset in webkit [128961] by
-
- 1 edit10 adds in trunk/LayoutTests
Add partial load tests for PNG images
https://bugs.webkit.org/show_bug.cgi?id=95707
Reviewed by Adam Barth.
Partial load test: receive a partial number of image bytes and stall forever. The
partial image should be decoded and drawn and the blue <img> background should be
visible.
Progressive load test: receive a partial number of image bytes, stall for 1 second
and then continue to receive all the image bytes. The entire test image should be
decoded and drawn and the blue <img> background should be visible.
- fast/images/resources/dice.png: Added: test image has alpha transparency.
- http/tests/images/png-partial-load-expected.png: Added.
- http/tests/images/png-partial-load-expected.txt: Added.
- http/tests/images/png-partial-load.html: Added.
- http/tests/images/png-progressive-load-expected.png: Added.
- http/tests/images/png-progressive-load-expected.txt: Added.
- http/tests/images/png-progressive-load.html: Added.
- platform/chromium/http/tests/images/png-partial-load-expected.png: Added.
- platform/mac/http/tests/images/png-partial-load-expected.png: Added.
- 7:37 PM Changeset in webkit [128960] by
-
- 7 edits in trunk/Source/WebKit2
[WebKit2] [GTK] Add API for controlling the user agent
https://bugs.webkit.org/show_bug.cgi?id=95697
Reviewed by Carlos Garcia Campos.
Add API for changing the user agent in WebKit2. This adds two styles of
setting the user agent: complete override and a method that just inserts
the application name and version, but preserves the carefully crafted user agent
in the library.
- UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate): Added a new field to store the user agent.
This is stored in the private data structure, because we can only
set the user agent when attaching the settings to the page.
(webKitSettingsSetProperty): Add hooks for the new user agent property.
(webKitSettingsGetProperty): Ditto.
(webkit_settings_class_init): Ditto.
(webkitSettingsAttachSettingsToPage): Ditto.
(webkit_settings_get_user_agent): Added.
(webkit_settings_set_user_agent): Added.
(webkit_settings_set_user_agent_with_application_name): Added.
- UIProcess/API/gtk/WebKitSettings.h: Added new methods.
- UIProcess/API/gtk/WebKitWebView.cpp: Update the glue for the settings
when attaching and detaching from WebViews.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new methods to
the documentation.
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp: Test the new user agent
property.
(testWebKitSettingsUserAgent): Ditto.
(beforeAll): Ditto.
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::standardUserAgent): Now use the shared WebCore
code when setting the user agent.
- 6:36 PM WebKitIDL edited by
- (diff)
- 6:36 PM Changeset in webkit [128959] by
-
- 3 edits2 adds in trunk
[V8] Notification.requestPermission(function() {alert();}) crashes
https://bugs.webkit.org/show_bug.cgi?id=94462
Reviewed by Adam Barth.
Source/WebCore:
Since Notification.requestPermission() is a static method,
we need to use getExecutionContext() instead of retrieving a context
from a DOM object.
Test: http/tests/notifications/notification-request-permission.html
- bindings/v8/custom/V8NotificationCustom.cpp:
(WebCore::V8Notification::requestPermissionCallback):
LayoutTests:
The added test checks if Notification.requestPermission() does not crash.
- http/tests/notifications/notification-request-permission-expected.txt: Added.
- http/tests/notifications/notification-request-permission.html: Added.
- 6:34 PM Drosera edited by
- (diff)
- 6:33 PM Changeset in webkit [128958] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Implement PageClientImpl::isViewFocused.
https://bugs.webkit.org/show_bug.cgi?id=97015
Reviewed by Gyuyoung Kim.
WebKit2/Efl always returns true for PageClientImpl::isViewFocused.
So window.onblur events will not be generated when webview lost focus.
This patch implements isViewFocused to return the current focus of webview.
- UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::isViewFocused):
- 6:32 PM WebInspector edited by
- (diff)
- 6:20 PM Changeset in webkit [128957] by
-
- 24 edits in trunk/Source/JavaScriptCore
DFG should not call out to C++ every time that it tries to put to an object that doesn't yet have array storage
https://bugs.webkit.org/show_bug.cgi?id=96983
Reviewed by Oliver Hunt.
Introduce more polymorphism into the DFG's array mode support. Use that to
introduce the notion of effectul array modes, where the check for the mode
will perform actions necessary to ensure that we have the mode we want, if
the object is not already in that mode. Also added profiling support for
checking if an object is of a type that would not allow us to create array
storage (like a typed array or a string for example).
This is a ~2x speed-up on loops that transform an object that did not have
indexed storage into one that does.
- JSCTypedArrayStubs.h:
(JSC):
- bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::computeUpdatedPrediction):
- bytecode/ArrayProfile.h:
(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::mayInterceptIndexedAccesses):
(ArrayProfile):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::fromObserved):
(DFG):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):
- dfg/DFGArrayMode.h:
(DFG):
(JSC::DFG::modeUsesButterfly):
(JSC::DFG::isSlowPutAccess):
(JSC::DFG::benefitsFromStructureCheck):
(JSC::DFG::isEffectful):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::byValIsPure):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasArrayMode):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/Arguments.h:
(Arguments):
- runtime/JSNotAnObject.h:
(JSNotAnObject):
- runtime/JSObject.h:
(JSObject):
(JSC::JSObject::ensureArrayStorage):
- runtime/JSString.h:
(JSC::JSString::createStructure):
- 6:04 PM Changeset in webkit [128956] by
-
- 3 edits in trunk/Source/WebCore
[Refactoring] ContentDistributor::distributeSelectionsTo should not change ContentDistribution pool.
https://bugs.webkit.org/show_bug.cgi?id=96993
Reviewed by Dimitri Glazkov.
Since we would like to reuse ContentDistribution pool, it should not be updated in
ContentDistributor::distributeSelectionsTo. Instead, we should have Vector<bool> to indicate an element is
distributed or not.
No new tests, simple refactoring.
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::distributeSelectionsTo):
- html/shadow/ContentDistributor.h:
(ContentDistributor):
- 6:03 PM Changeset in webkit [128955] by
-
- 2 edits in trunk/LayoutTests
Adjust expectation for fast/workers/storage/interrupt-database.html
https://bugs.webkit.org/show_bug.cgi?id=84696
Unreviewed, expectations change.
It looks like this test is just kinda slow and probably won't timeout if we mark it SLOW.
- platform/chromium/TestExpectations:
- 5:44 PM Changeset in webkit [128954] by
-
- 2 edits in trunk/LayoutTests
[chromium] word-spacing-characters{,-complex} no longer fail on Mac.
https://bugs.webkit.org/show_bug.cgi?id=94008
https://bugs.webkit.org/show_bug.cgi?id=94003
Unreviewed, expectations change.
- platform/chromium/TestExpectations:
- 5:41 PM Changeset in webkit [128953] by
-
- 2 edits in trunk/LayoutTests
[chromium] gradient-with-scaled-ancestor passes on mac lion gpu
http://bugs.webkit.org/show_bug.cgi?id=96441
Unreviewed, expectations change.
- platform/chromium/TestExpectations:
- 5:38 PM Changeset in webkit [128952] by
-
- 2 edits in trunk/LayoutTests
[chromium] Adjust expectation for fast/css/sticky/sticky-left-percentage.html
http://webkit.org/b/95136
Unreviewed, expectations change.
The test is only failing on win and linux now.
- platform/chromium/TestExpectations:
- 5:35 PM Changeset in webkit [128951] by
-
- 2 edits in trunk/LayoutTests
[chromium] overflow-auto-with-touch-toggle is no longer failing.
https://bugs.webkit.org/show_bug.cgi?id=94353
Unreviewed, expectations change.
- platform/chromium/TestExpectations:
- 5:32 PM Changeset in webkit [128950] by
-
- 2 edits in trunk/LayoutTests
[chromium] fast/css/nested-rounded-corners.html is no longer failing.
https://bugs.webkit.org/show_bug.cgi?id=94063
Unreviewed, expectations change.
- platform/chromium/TestExpectations:
- 5:26 PM Changeset in webkit [128949] by
-
- 2 edits in trunk/LayoutTests
[chromium] font-scale-factor.html and simple-paragraph.html are no longer failing.
https://bugs.webkit.org/show_bug.cgi?id=90741
Unreviewed, expectations change.
- platform/chromium/TestExpectations:
- 5:23 PM Changeset in webkit [128948] by
-
- 2 edits in trunk/LayoutTests
[chromium] fast/table/border-collapsing/cached-69296.html is no longer failing.
https://bugs.webkit.org/show_bug.cgi?id=70298
Unreviewed, expectations change.
- platform/chromium/TestExpectations:
- 5:20 PM Changeset in webkit [128947] by
-
- 2 edits in trunk/LayoutTests
[chromium] fast/js/kde/GlobalObject.html is no longer failing.
https://bugs.webkit.org/show_bug.cgi?id=75468
Unreviewed, expectations change.
- platform/chromium/TestExpectations:
- 5:15 PM Changeset in webkit [128946] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark LayoutTests/fullscreen/exit-full-screen-iframe.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=90704
Unreviewed, expectations change.
- platform/chromium/TestExpectations:
- 5:11 PM Changeset in webkit [128945] by
-
- 2 edits in trunk/LayoutTests
[chromium] 2d.imageData.object.round and canvas-ImageData-behavior are no longer failing
https://bugs.webkit.org/show_bug.cgi?id=94246
Unreviewed, expectations change.
[chromium] The following suppressions appear to be no longer needed
(the tests are passing), so I'm removing them:
BUGWK94246 : canvas/philip/tests/2d.imageData.object.round.html = TEXT
BUGWK94246 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.imageData.object.round.html = TEXT
BUGWK94246 : fast/canvas/canvas-ImageData-behaviour.html = TEXT
BUGWK94246 : platform/chromium/virtual/gpu/fast/canvas/canvas-ImageData-behaviour.html = TEXT
- platform/chromium/TestExpectations:
- 5:06 PM Changeset in webkit [128944] by
-
- 2 edits in trunk/LayoutTests
fast/dom/Window/anonymous-slot-with-changes.html is no longer failing.
http://code.google.com/p/chromium/issues/detail?id=33538
Unreviewed, expectations change.
- platform/chromium/TestExpectations:
- 4:49 PM Changeset in webkit [128943] by
-
- 18 edits2 adds in trunk
Title string should be changed when document.title is set to .
https://bugs.webkit.org/show_bug.cgi?id=96793
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-18
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
DocumentLoader::setTitle() function returns without anything (changing
m_pageTitle and calling FrameLoaderClient::setTitle()) when new title
string is empty.
So, when document.title is set to , title string of a browser cannot
be changed.
For applying the change of document.title properly, empty string check
should be removed.
Test: fast/dom/title-text-property-assigning-empty-string.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setTitle):
Source/WebKit2:
Added unit test for setting document.title and checking the title
string with title,changed signal and ewk_view_title_get() function.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
Tools:
Change dump format of dumpTitleChanges more understandable.
Uses single quotation marks for the title string.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didReceiveTitle):
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onFrameTitleChanged):
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewTitleChanged):
- DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::titleChanged):
- DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::didReceiveTitle):
- DumpRenderTree/wx/DumpRenderTreeWx.cpp:
(LayoutWebViewEventHandler::OnReceivedTitleEvent):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
LayoutTests:
Added layout tests for assigning empty string to title text.
And modified expected results according to the change of
dumpTitleChanges.
- fast/dom/title-text-property-2-expected.txt: Modified expected result.
- fast/dom/title-text-property-assigning-empty-string-expected.txt: Added.
- fast/dom/title-text-property-assigning-empty-string.html: Added.
- fast/dom/title-text-property-expected.txt: Modified expected result.
- fast/dom/title-text-property.html: Apply modified dumpTitleChanges.
- 4:19 PM Changeset in webkit [128942] by
-
- 3 edits3 deletes in trunk/Source/WebKit/chromium
Unreviewed, rolling out r128939.
http://trac.webkit.org/changeset/128939
https://bugs.webkit.org/show_bug.cgi?id=96135
Failing test_shell_tests.
- WebKit.gypi:
- src/WebImageSkia.cpp:
(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):
- tests/WebImageTest.cpp: Removed.
- tests/data/black-and-white.ico: Removed.
- tests/data/white-1x1.png: Removed.
- 3:43 PM Changeset in webkit [128941] by
-
- 3 edits in trunk/Source/WebCore
fast/forms/search-event-delay.html is asserting in markAllMisspellingsAndBadGrammarInRanges()
https://bugs.webkit.org/show_bug.cgi?id=82761
Reviewed by Ryosuke Niwa.
Speculative fix for this assertion: have InternalSettings save
and restore the value of the "unifiedTextCheckerEnabled" setting
between tests, so that tests change the value of this setting don't
affect later tests.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
- testing/InternalSettings.h:
(Backup):
- 3:38 PM Changeset in webkit [128940] by
-
- 1 copy in branches/safari-534.58-branch
New Branch.
- 3:29 PM Changeset in webkit [128939] by
-
- 3 edits3 adds in trunk/Source/WebKit/chromium
[chromium] WebImage should use ImageDecoder directly
https://bugs.webkit.org/show_bug.cgi?id=96135
Reviewed by Adam Barth.
This patch is for preparation of deferred image decoding.
ImageSource will be used as a portal to access deferred image decoder
by BitmapImage, it should not be accessible through WebKit APIs.
WebImage now calls ImageDecoder directly which is the actual
implementation of an image decoder.
Tests: WebImageTest.PNGImage
WebImageTest.ICOImage
- WebKit.gypi:
- src/WebImageSkia.cpp:
(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):
- tests/WebImageTest.cpp: Added.
(WebKit):
(WebKit::readFile):
(WebKit::TEST):
- tests/data/black-and-white.ico: Added.
- tests/data/white-1x1.png: Added.
- 3:26 PM Changeset in webkit [128938] by
-
- 2 edits in branches/safari-536.27-branch/Source/WebCore
Merged r128845.
- 3:26 PM Changeset in webkit [128937] by
-
- 2 edits in trunk/Source/JavaScriptCore
Include PhantomArguments in DFGDisassembly
https://bugs.webkit.org/show_bug.cgi?id=97043
Reviewed by Geoffrey Garen.
- dfg/DFGNode.h:
(JSC::DFG::Node::willHaveCodeGenOrOSR):
- 3:03 PM Changeset in webkit [128936] by
-
- 2 edits in branches/safari-536.27-branch/Source/WebCore
Merged r126666. <rdar://problem/12030952>
- 3:00 PM Changeset in webkit [128935] by
-
- 3 edits in trunk/Source/WebKit2
Division by zero crash in BackingStore::scroll
https://bugs.webkit.org/show_bug.cgi?id=97046
<rdar://problem/11722564>
Reviewed by Dan Bernstein.
It appears that DrawingAreaImpl::scroll can be called with an empty scroll rect. Do nothing
if that's the case. Also, assert that the scrolling rect in BackingStoreMac is never empty.
- UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::scroll):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scroll):
- 2:39 PM Changeset in webkit [128934] by
-
- 4 edits in branches/safari-536.27-branch/Source
Versioning.
- 2:38 PM Changeset in webkit [128933] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use didCancel and didSucceed instead of didCheckCancel and didCheckSucceed
https://bugs.webkit.org/show_bug.cgi?id=97033
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-09-18
Reviewed by Rob Buis.
Using these preferred public methods (the latter has a note to be made private) ensures that
the right SpellChecker object is being called during the callback in spellCheckingRequestProcessed
and spellCheckingRequestCancelled.
Internally reviewed by Mike Fenton.
By referencing the TextCheckingRequest object's methods, we don't need to keep track of the associated
SpellChecker for each request. Removing much of the code that was put in place incorrectly to achieve this.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::getSpellChecker):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 2:37 PM Changeset in webkit [128932] by
-
- 2 edits2 adds in trunk/LayoutTests
More unreviewed rebaseline after r128906.
- platform/chromium-mac/fast/invalid/residual-style-expected.txt:
- platform/chromium-win-xp/fast/invalid/residual-style-expected.txt: Added.
- platform/chromium-win-xp/tables/mozilla/bugs/bug56563-expected.png: Added.
- 2:31 PM Changeset in webkit [128931] by
-
- 1 edit5 adds in trunk/LayoutTests
http://trac.webkit.org/changeset/128912 caused these tests to start failing.
Looks like a garden-o-matic/webkit-patch bug.
- platform/chromium-linux/css3/filters/filter-change-repaint-composited-expected.png: Added.
- platform/chromium-linux/css3/filters/filter-change-repaint-expected.png: Added.
- platform/chromium-linux/css3/filters/filter-repaint-child-layers-expected.png: Added.
- platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png: Added.
- platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-expected.png: Added.
- 2:28 PM Changeset in webkit [128930] by
-
- 1 copy in branches/safari-536.27-branch
New Branch.
- 2:27 PM Changeset in webkit [128929] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening after http://trac.webkit.org/changeset/128928
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/Skipped:
- 2:17 PM Changeset in webkit [128928] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r128802): It made some JS tests crash
https://bugs.webkit.org/show_bug.cgi?id=97001
Reviewed by Mark Hahnenberg.
IndexingHeaderInlineMethods was incorrectly assuming that if the HasArrayStorage bit is clear, then that means that indexing payload capacity is zero.
- runtime/IndexingHeaderInlineMethods.h:
(JSC::IndexingHeader::preCapacity):
(JSC::IndexingHeader::indexingPayloadSizeInBytes):
- 1:40 PM Changeset in webkit [128927] by
-
- 7 edits2 copies1 move3 adds1 delete in trunk
Text Autosizing: Ignore constrained heights in certain circumstances.
https://bugs.webkit.org/show_bug.cgi?id=96848
Patch by John Mellor <johnme@chromium.org> on 2012-09-18
Reviewed by Julien Chaffraix.
Source/WebCore:
Ignore constrained heights on html and body elements, as some sites
(e.g. wikipedia) set height:100% on these, without intending to
constrain the height of descendants.
Also ignore constrained heights on ancestors of floats and out-of-flow
positioned elements with no height set, since the height of these is
determined independently from their ancestors.
Test: fast/text-autosizing/constrained-height-body.html
fast/text-autosizing/constrained-out-of-flow.html
fast/text-autosizing/constrained-then-float-ancestors.html
fast/text-autosizing/constrained-then-position-absolute-ancestors.html
fast/text-autosizing/constrained-then-position-fixed-ancestors.html
- rendering/TextAutosizer.cpp:
(WebCore::contentHeightIsConstrained):
Adjusted constrainedness algorithm.
LayoutTests:
Added 3 tests, updated 2, and removed 1. See below.
- fast/text-autosizing/constrained-height-body-expected.html: Added.
- fast/text-autosizing/constrained-height-body.html: Added.
Checks that constrained height html & body are ignored.
- fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors-expected.html: Removed.
- fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors.html: Removed.
Removed because this situation is no longer possible now that
heightless position:absolute elements are always unconstrained.
- fast/text-autosizing/constrained-out-of-flow-expected.html: Added.
- fast/text-autosizing/constrained-out-of-flow.html: Added.
Checks that floats and out-of-flow positioned elements do not ignore
constraints on themselves.
- fast/text-autosizing/constrained-then-float-ancestors-expected.html: Added.
- fast/text-autosizing/constrained-then-float-ancestors.html: Added.
Checks that floats ignore constraints on ancestors.
- fast/text-autosizing/constrained-then-position-absolute-ancestors-expected.html:
- fast/text-autosizing/constrained-then-position-absolute-ancestors.html:
Added position:relative to emphasize that the ancestor's constrained
height is actually being ignored, not just skipped over; and updated
explanation.
- fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
- fast/text-autosizing/constrained-then-position-fixed-ancestors.html:
Updated explanation (since the test still passes, but for a
different reason).
- 1:35 PM Changeset in webkit [128926] by
-
- 1 edit in branches/chromium/1229/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp
Merge 128415
BUG=147592
Review URL: https://codereview.chromium.org/10951014
- 1:34 PM Changeset in webkit [128925] by
-
- 1 edit2 copies in branches/chromium/1229
Merge 128263
BUG=147592
Review URL: https://codereview.chromium.org/10948013
- 1:07 PM Changeset in webkit [128924] by
-
- 6 edits in trunk/Source
MediaStream API: Create a flag to enable PeerConnection00
https://bugs.webkit.org/show_bug.cgi?id=96989
Reviewed by Adam Barth.
Adding the functionality to separately enable/disable PeerConnection00.
For now it is enabled by default.
Source/WebCore:
Not testable, nor likely to cause issues.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::deprecatedPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setDeprecatedPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPeerConnection00Enabled):
(RuntimeEnabledFeatures):
Source/WebKit/chromium:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableDeprecatedPeerConnection):
(WebKit):
(WebKit::WebRuntimeFeatures::isDeprecatedPeerConnectionEnabled):
- 12:55 PM Changeset in webkit [128923] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Date picker isn't inputting after 'OK'
https://bugs.webkit.org/show_bug.cgi?id=97031
PR208052
Patch by Jessica Cao <jecao@rim.com> on 2012-09-18
Reviewed by Rob Buis
Checking for !values.contains("-1") will match valid strings like "2012-09-18". Use value != "-1" instead.
- WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::setValueAndClosePopup):
- 12:37 PM Changeset in webkit [128922] by
-
- 2 edits in trunk/LayoutTests
Layout Test svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=93589
- platform/mac/Skipped: Skipping the test on Mac.
- 12:26 PM Changeset in webkit [128921] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Popup page should reference the client with a weak pointer
https://bugs.webkit.org/show_bug.cgi?id=97028
Reviewed by Rob Buis.
RIM PR# 209847.
Internally reviewed by Mike Fenton.
Store the pointer in a ref-coutned shared object, and clear the pointer
when the client is going to be destroyed, so it won't be accessed by
the JS function afterwards.
- WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
(WebCore::PagePopupBlackBerry::~PagePopupBlackBerry):
(WebCore::PagePopupBlackBerry::init):
(WebCore::setValueAndClosePopupCallback):
(WebCore::popUpExtensionFinalize):
(WebCore::PagePopupBlackBerry::installDOMFunction):
(WebCore::PagePopupBlackBerry::closePopup):
- WebCoreSupport/PagePopupBlackBerry.h:
(PagePopupBlackBerry):
(SharedClientPointer):
(WebCore::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
(WebCore::PagePopupBlackBerry::SharedClientPointer::clear):
(WebCore::PagePopupBlackBerry::SharedClientPointer::get):
- 12:09 PM Changeset in webkit [128920] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, add missing newline to expectation for test only run
as part of chromium's content_browsertests.
- storage/indexeddb/basics-shared-workers-expected.txt:
- 11:58 AM Changeset in webkit [128919] by
-
- 2 edits in trunk/LayoutTests
Remove lines for tests that haven't failed on any Chromium bot for the last 500 runs.
- platform/chromium/TestExpectations:
- 11:56 AM Changeset in webkit [128918] by
-
- 1 add in branches/chromium/1270/codereview.settings
adding for easy drover
- 11:54 AM Changeset in webkit [128917] by
-
- 1 copy in branches/chromium/1270
creating m23 chrome branch for webkit
- 11:52 AM Changeset in webkit [128916] by
-
- 5 edits in trunk/LayoutTests
Rebaseline after r128906. All the differences were expected.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56563-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png:
- platform/gtk/fast/invalid/residual-style-expected.txt:
- platform/mac/fast/invalid/residual-style-expected.txt:
- 11:26 AM Changeset in webkit [128915] by
-
- 6 edits8 moves in trunk/LayoutTests
Complete some forgotten rebaselines. The new results match other ports/platforms.
- fast/block/float/024-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/024-expected.txt.
- fast/block/margin-collapse/025-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/margin-collapse/025-expected.txt.
- fast/block/margin-collapse/block-inside-inline/025-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt.
- fast/block/margin-collapse/empty-clear-blocks-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt.
- platform/chromium-mac-snowleopard/fast/block/float/024-expected.png:
- platform/chromium-mac-snowleopard/fast/block/margin-collapse/empty-clear-blocks-expected.png:
- platform/chromium-mac/fast/block/float/024-expected.png:
- platform/chromium-mac/fast/block/float/024-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/float/024-expected.txt.
- platform/chromium-mac/fast/block/margin-collapse/025-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/margin-collapse/025-expected.txt.
- platform/chromium-mac/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt.
- platform/chromium-mac/fast/block/margin-collapse/empty-clear-blocks-expected.png:
- platform/chromium-mac/fast/block/margin-collapse/empty-clear-blocks-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt.
- platform/chromium/TestExpectations:
- 11:18 AM Changeset in webkit [128914] by
-
- 25 edits8 deletes in trunk
Revert 128780, 128676, 128645
https://bugs.webkit.org/show_bug.cgi?id=97022
Patch by Bo Liu <boliu@chromium.org> on 2012-09-18
Reviewed by Adam Barth.
I made these revisions to add in-place reload behavior to ImagesEnabled setting.
Reverting this for now due to them causing performance regression in
chromium, possibly caused by increased calls to
PermissionClient::imageAllowed.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- WebCore.exp.in:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::load):
- loader/cache/CachedImage.h:
(WebCore::CachedImage::stillNeedsLoad):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::didAddClient):
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
- loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
- page/Settings.cpp:
(WebCore::setLoadsImagesAutomaticallyInAllFrames):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::loadsImagesAutomaticallyTimerFired):
(WebCore::Settings::setImagesEnabled):
- page/Settings.h:
(Settings):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
- testing/InternalSettings.h:
(Backup):
(InternalSettings):
- testing/InternalSettings.idl:
Source/WebKit2:
- win/WebKit2.def:
LayoutTests:
- fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Removed.
- fast/loader/display-image-unset-allows-cached-image-load.html: Removed.
- fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
- fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Removed.
- fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
- fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Removed.
- fast/loader/resources/image1.html: Removed.
- fast/loader/resources/image2.html: Removed.
- platform/chromium/http/tests/permissionclient/image-permissions-expected.txt:
- platform/chromium/permissionclient/image-permissions-expected.txt:
- platform/chromium/permissionclient/image-permissions.html:
- platform/chromium/permissionclient/resources/image.html:
- platform/wk2/Skipped:
- 11:15 AM Changeset in webkit [128913] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
[GTK] [WK2] Replace Skipped with TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97029
Reviewed by Martin Robinson.
Replace the Skipped file with a TestExpectations file which adds
lots of semantics.
- platform/gtk-wk2/Skipped: Removed.
- platform/gtk-wk2/TestExpectations: Added.
- 11:12 AM Changeset in webkit [128912] by
-
- 5 edits5 adds in trunk/LayoutTests
Rebaseline tests. Mostly failing due to slight pixel differences.
- platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png:
- platform/chromium-win/css3/filters/effect-brightness-expected.png:
These two results are darker now, but this matches the mac/linux results.
- platform/chromium-win/css3/filters/filter-change-repaint-composited-expected.png: Added.
- platform/chromium-win/css3/filters/filter-change-repaint-expected.png: Added.
- platform/chromium-win/css3/filters/filter-repaint-child-layers-expected.png: Added.
- platform/chromium-win/css3/filters/filter-repaint-composited-fallback-crash-expected.png: Added.
- platform/chromium-win/css3/filters/filter-repaint-composited-fallback-expected.png: Added.
- platform/chromium/TestExpectations:
- 11:09 AM Changeset in webkit [128911] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skipping large number of tests that have been failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=97026
Due to the state of the windows bots a large number of tests have been failing for quite some time and it is difficult to tell when the failure started.
For now I'm adding these tests to the skip list to get the bots greener and will come back to them later.
- platform/win/Skipped:
- 11:02 AM Changeset in webkit [128910] by
-
- 6 edits in trunk
Web Inspector: Set focus on the ExtensionPanel's iframe when it is selected
https://bugs.webkit.org/show_bug.cgi?id=96148
Patch by John J. Barton <johnjbarton@chromium.org> on 2012-09-18
Reviewed by Vsevolod Vlasov.
Source/WebCore:
ExtensionView ctor calls setDefaultFocusedElement with its iframe,
ExtensionPanel ctor calls setDefaultFocusedElement with the extensionView
and ExtensionPanel's setDefaultFocusedElement calls its grandparent impl
Tests: Added hasFocus test to extensions/extension-panel.html
- inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionPanel.prototype.defaultFocusedElement):
- inspector/front-end/ExtensionView.js:
(WebInspector.ExtensionView):
LayoutTests:
Add one line to verify that the panel's document has focus after show
- inspector/extensions/extensions-panel-expected.txt:
- inspector/extensions/extensions-panel.html:
- 11:00 AM Changeset in webkit [128909] by
-
- 35 edits in trunk/LayoutTests
Rebaseline tests failing due to expected slight pixel differences.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac/css3/filters/effect-combined-expected.png:
- platform/chromium-mac/css3/filters/effect-opacity-expected.png:
- platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-win/css3/filters/effect-combined-expected.png:
- platform/chromium-win/css3/filters/effect-opacity-expected.png:
- platform/chromium-win/css3/filters/effect-reference-ordering-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium/TestExpectations:
- 10:57 AM Changeset in webkit [128908] by
-
- 2 edits in trunk/Source/WTF
WTFString::show doesn't dump non-ASCII characters in a readable manner
https://bugs.webkit.org/show_bug.cgi?id=96749
Patch by Glenn Adams <glenn@skynav.com> on 2012-09-18
Reviewed by Benjamin Poulain.
Dump non-ASCII characters in a useful form for debugging.
- wtf/text/WTFString.cpp:
(asciiDebug):
Dump non-ASCII characters (i.e., UTF-16 code elements) as well as non-printable ASCII characters
using \uXXXX format. Also escape \ as
in order to remove ambiguity.
- 10:54 AM Changeset in webkit [128907] by
-
- 15 edits in trunk/Source
[GTK] [WebKit2] Use XComposite window for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=94417
Reviewed by Carlos Garcia Campos.
Instead of rendering directly to the widget's native window, render to an
offscreen window redirected to a Pixmap with XComposite.
Source/WebCore:
No new tests. This will be covered by the existing accelerated compositing tests,
which should now give correct pixel results.
- platform/gtk/RedirectedXCompositeWindow.cpp:
(WebCore::RedirectedXCompositeWindow::resize): Add a call to XFlush which ensures
that pending X11 operations complete.
- platform/gtk/RedirectedXCompositeWindow.h:
(WebCore::RedirectedXCompositeWindow::windowId): Added this accessor.
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate): Added a few members necessary to track the
offscreen window.
(webkit_web_view_base_init):
(renderAcceleratedCompositingResults): Added this helper functions which renders
the results of the accelerated compositing operations during the GTK+ draw loop.
(webkitWebViewBaseDraw): Call renderAcceleratedCompositingResults when appropriate.
(resizeWebKitWebViewBaseFromAllocation): Resize the offscreen window when appropriate.
(webkitWebViewBaseSizeAllocate): Do not call resizeWebKitWebViewBaseFromAllocation when
the actual size of the widget does not change. This prevents destroying and recreating
the offscreen window pixmap when it isn't necessary.
(webkitWebViewBaseMap): We no longer send the window id during map, instead it's sent
as soon as there is WebPageProxy.
(webkitWebViewBaseCreateWebPage): Send the window id of the redirected window to
the WebProcess.
(queueAnotherDrawOfAcceleratedCompositingResults): Added this helper which works
around the issue of slow updates of the pixmap backing the redirected XComposite window.
(webkitWebViewBaseQueueDrawOfAcceleratedCompositingResults): Added this method which
is what the WebProcess uses to force a redraw on the UIProcess side.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Added new method to the list of private methods.
- UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode): Exposed this method publically
so that it can be used from WebKitWebViewBase.
- UIProcess/WebPageProxy.h:
(WebPageProxy): Renamed widgetMapped to setAcceleratedCompositingWindowId.
- UIProcess/WebPageProxy.messages.in: Ditto.
- UIProcess/gtk/WebPageProxyGtk.cpp: Ditto.
(WebKit::WebPageProxy::setAcceleratedCompositingWindowId):
- WebProcess/WebPage/WebPage.h:
(WebPage): Ditto.
- WebProcess/WebPage/WebPage.messages.in: Ditto.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::sizeDidChange): Force a composite to the resized window right
away so that the new window pixmap is updated before the first draw.
(WebKit::LayerTreeHostGtk::compositeLayersToContext): If the composition is for a resize,
first clear the entire GL context so that we don't see black artifacts during resize.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk): Update the signature of compositeLayersToContext.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::setAcceleratedCompositingWindowId): Added.
- 10:51 AM Changeset in webkit [128906] by
-
- 58 edits4 adds in trunk
Tables without any descendant and auto logical width should have a 0px logical width
https://bugs.webkit.org/show_bug.cgi?id=95521
Reviewed by Abhishek Arya.
Source/WebCore:
The code would wrongly add the border-spacing in the row direction to the table's logical
width even if we didn't have a column. The new behavior matches FireFox and Opera. IE
matches our old behavior for inline tables but our new behavior for normal tables which
is a bug on their side.
Tests: fast/table/empty-table-should-take-no-space.html
fast/table/fixed-table-layout/empty-table-should-take-no-space-fixed-layout.html
- rendering/RenderTable.h:
(WebCore::RenderTable::borderSpacingInRowDirection):
Added this new helper function to return the right border-spacing. Added a FIXME as the code always
return the horizontal dimension which is wrong in vertical-writing mode.
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):
Changed to call borderSpacingInRowDirection. Added a comment as to why we don't add border-spacing on
border-collapse: separate tables.
LayoutTests:
- fast/table/empty-table-should-take-no-space-expected.html: Added.
- fast/table/empty-table-should-take-no-space.html: Added.
- fast/table/fixed-table-layout/empty-table-should-take-no-space-fixed-layout-expected.html: Added.
- fast/table/fixed-table-layout/empty-table-should-take-no-space-fixed-layout.html: Added.
2 new tests to check that empty tables have 0px logical width.
- platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug56563-expected.txt:
- platform/mac/tables/mozilla/bugs/bug56563-expected.txt:
- platform/qt/tables/mozilla/bugs/bug56563-expected.txt:
- tables/mozilla/bugs/bug56563-expected.txt:
Progression. The table now is 2px wide as it has a 1px right & left border.
- platform/chromium-linux/fast/invalid/residual-style-expected.txt:
Progression. The changes are due to the tables shrinking which is expected.
- platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt:
- platform/chromium-mac/fast/forms/file/file-input-disabled-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/chromium-win-xp/fast/forms/file-input-disabled-expected.txt:
- platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt:
- platform/chromium-win/fast/invalid/017-expected.txt:
- platform/chromium-win/fast/invalid/018-expected.txt:
- platform/chromium-win/fast/invalid/020-expected.txt:
- platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug23994-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug56405-expected.txt:
- platform/efl/fast/forms/file/file-input-disabled-expected.txt:
- platform/efl/fast/invalid/017-expected.txt:
- platform/efl/fast/invalid/018-expected.txt:
- platform/efl/fast/invalid/020-expected.txt:
- platform/efl/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/efl/fast/invalid/table-residual-style-crash-expected.txt:
- platform/efl/tables/mozilla/bugs/bug23994-expected.txt:
- platform/efl/tables/mozilla/bugs/bug56405-expected.txt:
- platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
- platform/gtk/fast/invalid/017-expected.txt:
- platform/gtk/fast/invalid/018-expected.txt:
- platform/gtk/fast/invalid/020-expected.txt:
- platform/gtk/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/gtk/fast/invalid/table-residual-style-crash-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug23994-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug56405-expected.txt:
- platform/mac/fast/forms/file/file-input-disabled-expected.txt:
- platform/mac/fast/invalid/017-expected.txt:
- platform/mac/fast/invalid/018-expected.txt:
- platform/mac/fast/invalid/020-expected.txt:
- platform/mac/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug23994-expected.txt:
- platform/mac/tables/mozilla/bugs/bug56405-expected.txt:
- platform/qt/fast/forms/file/file-input-disabled-expected.txt:
- platform/qt/fast/invalid/017-expected.txt:
- platform/qt/fast/invalid/018-expected.txt:
- platform/qt/fast/invalid/020-expected.txt:
- platform/qt/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/qt/fast/invalid/table-residual-style-crash-expected.txt:
- platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug23994-expected.txt:
- platform/qt/tables/mozilla/bugs/bug56405-expected.txt:
- platform/win/fast/forms/file-input-disabled-expected.txt:
- platform/win/fast/forms/file/file-input-disabled-expected.txt:
- tables/mozilla/bugs/bug113235-2-expected.txt:
Progression. The tables now have a 0px logical width. In some cases, we add the border-spacing in the
block-flow direction if we have a row. This is not consistently handled by browsers and not very well
defined in CSS.
- 10:43 AM Changeset in webkit [128905] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Build is broken without option --enable-unstable-features
https://bugs.webkit.org/show_bug.cgi?id=96996
Reviewed by Martin Robinson.
When searching for the bare feature define in feature_defines_unstable or
feature_defines_overrides, search for the bare define followed by = character.
This avoids incorrectly matching the ENABLE_VIDEO define to the ENABLE_VIDEO_TRACK
overriding define (and works as well for other similarly named feature defines).
No new tests - no new functionality.
- GNUmakefile.am:
- 10:42 AM Changeset in webkit [128904] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding expectations for flakily-crashing tests, these failures
are a regression from r128802.
- platform/gtk/TestExpectations:
- 10:23 AM Changeset in webkit [128903] by
-
- 8 edits in trunk/Source/WebKit/chromium
[Chromium] Merge moveSelectionStart, moveSelectionEnd, and moveCaret into selectRange
https://bugs.webkit.org/show_bug.cgi?id=96508
Patch by Iain Merrick <husky@google.com> on 2012-09-18
Reviewed by Ryosuke Niwa.
These methods had "start" and "end" parameters, but this is incorrect.
selectRange() actually takes base and extent (where the user actually
touched), and selectionBounds() returns anchor and focus (base and extent
expanded to account for the selection granularity).
This patch fixes the parameter names, and updates selectRange, its test
and its documentation to reflect the correct usage. It also removes
moveSelectionStart/moveSelectionEnd/moveCaret (which aren't being used
yet), and updates WebFrameTest to show how these can be implemented via
selectRange.
- public/WebFrame.h:
(WebFrame):
- public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::selectionBounds):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::selectRange):
- src/WebFrameImpl.h:
(WebFrameImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::selectionBounds):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
- 9:51 AM Changeset in webkit [128902] by
-
- 1 edit4 copies in branches/chromium/1229
Merge 128514 - Hide all ancestors of the full screen element when going full screen
https://bugs.webkit.org/show_bug.cgi?id=96332
Reviewed by James Robinson.
Source/WebCore:
Since fixed position elements can now sometimes become stacking
contexts, explicitly set position: static on full-screen ancestors so
that there are no stacking context ancestors that could cause the full
screen element to become incorrectly sorted.
Test: fullscreen/full-screen-fixed-pos-parent.html
- css/fullscreen.css:
(:-webkit-full-screen-ancestor:not(iframe)):
LayoutTests:
This test has an all red image that (without this patch) incorrectly
sorts on top of the full screen element. With this patch, the all
green full screen element appears on top.
- fullscreen/full-screen-fixed-pos-parent-expected.png: Added.
- fullscreen/full-screen-fixed-pos-parent-expected.txt: Added.
- fullscreen/full-screen-fixed-pos-parent.html: Added.
- fullscreen/resources/green.html: Added.
TBR=enne@google.com
- 9:21 AM Changeset in webkit [128901] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll chromium DEPS to r157342
https://bugs.webkit.org/show_bug.cgi?id=96963
Patch by Terry Anderson <tdanderson@chromium.org> on 2012-09-18
Reviewed by Stephen White.
Roll chromium DEPS to r157342. Also include the top-level directory
google_apis as a dependency, which was required for r157130.
- DEPS:
- 9:13 AM Changeset in webkit [128900] by
-
- 4 edits in trunk/Source
Use WTF::HasTrivialDestructor instead of compiler-specific versions in JSC::NeedsDestructor
https://bugs.webkit.org/show_bug.cgi?id=96980
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- runtime/JSCell.h:
(JSC):
(NeedsDestructor):
Source/WTF:
- wtf/TypeTraits.h:
(WTF):
- 8:30 AM Changeset in webkit [128899] by
-
- 3 edits in trunk/Tools
EWS shouldn't sleep if there are new patches in its queue
https://bugs.webkit.org/show_bug.cgi?id=83038
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-09-18
Reviewed by Eric Seidel.
EWS tries to process a security patch. Of course it can't, because the EWS isn't
the member of the security group. But the problem is that after it can't process
the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
and push the security patch to the end of the queue.
Now it stays in the loop until it finds a patch or the queue gets empty.
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractPatchQueue._next_patch):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(AbstractPatchQueueTest.test_next_patch):
- 8:22 AM Changeset in webkit [128898] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFGOperations doesn't use NativeCallFrameTracer in enough places
https://bugs.webkit.org/show_bug.cgi?id=96987
Reviewed by Mark Hahnenberg.
Anything that can GC should use it.
- dfg/DFGOperations.cpp:
- 8:14 AM Changeset in webkit [128897] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening.
Move fast/events/dont-loose-last-event.html from Skipped to
TestExpectations now that it has a proper bug tracking the
failure.
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- 8:02 AM Changeset in webkit [128896] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Avoid using a deprecated extension API parameter in test to avoid console warning,
that break expectations on EFL due to EFL's DRT logging inspector console output to test
expectations.
- inspector/extensions/extensions-audits-api.html:
- platform/efl/TestExpectations:
- 8:00 AM Changeset in webkit [128895] by
-
- 2 edits in trunk/Tools
[WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
https://bugs.webkit.org/show_bug.cgi?id=97014
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-18
Reviewed by Kenneth Rohde Christiansen.
According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
be used for literals rather than WTF::StringBuilder::append().
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::booleanForKey):
- 7:57 AM Changeset in webkit [128894] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening.
- platform/efl/TestExpectations: Skip
inspector/extensions/extensions-audits-api.html while we do not
solve the associated bug.
- 7:44 AM Changeset in webkit [128893] by
-
- 3 edits in trunk/LayoutTests
[EFL] Unreviewed daily gardening.
Re-skip a few tests which were unskipped in r128880 and r128882
and still fail both on my machine and on the bots.
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- 7:14 AM Changeset in webkit [128892] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Extensions API] postpone requests to add extensions until extension server is initialized
https://bugs.webkit.org/show_bug.cgi?id=97012
Reviewed by Vsevolod Vlasov.
- queue extensions being added unless initialization is complete;
- add queued extensions upon completion of initialization;
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.initExtensions):
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._addExtension):
(WebInspector.ExtensionServer.prototype._innerAddExtension):
- 7:11 AM Changeset in webkit [128891] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip the right ietestcenter tests after r128802.
- platform/efl/TestExpectations:
- 7:08 AM Changeset in webkit [128890] by
-
- 2 edits in trunk/Tools
Update my e-mail address.
- Scripts/webkitpy/common/config/committers.py:
- 7:05 AM Changeset in webkit [128889] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Use UndoStep::editingAction() to set the text of undo/redo actions
https://bugs.webkit.org/show_bug.cgi?id=96921
Reviewed by Ryosuke Niwa.
Set the text of QUndoCommands we create for undo/redo actions based on the
editing action from UndoStep.
This change is visible using QtTestBrowser, and looking at the Edit menu after
doing HTML editing changes. I've used http://simple-rte.rniwa.com for testing.
- WebCoreSupport/UndoStepQt.cpp:
(undoNameForEditAction): This function returns a localized name of the action.
(UndoStepQt::UndoStepQt): Set the text based on UndoStep::editingAction.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage):
(tst_QWebPage::undoActionHaveCustomText): Create a new test to verify that the text
describing the undo action after inserting a text and indenting the text is different.
- 7:03 AM Changeset in webkit [128888] by
-
- 2 edits in trunk/Tools
Update my e-mail address.
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 6:58 AM Changeset in webkit [128887] by
-
- 2 edits in trunk/Tools
[Qt] qt_webkit.pri should not be listed in Tools.pro
Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
Since r128751 the module pri file is auto-generated
but it was still listed in OTHER_FILES.
Patch by Andras Becsi <andras.becsi@digia.com> on 2012-09-18
- Tools.pro: Remove unneeded line.
- 6:51 AM Changeset in webkit [128886] by
-
- 2 edits3 adds in trunk/Tools
[Qt] Fix build with some versions of the gold linker
Reviewed by Tor Arne Vestbø.
Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
Instead run a compile/link test first to see if it works.
- qmake/config.tests/gnuld/gnuld.pro: Added.
- qmake/config.tests/gnuld/main.cpp: Added.
(main):
- qmake/mkspecs/features/unix/default_post.prf:
- 6:37 AM Changeset in webkit [128885] by
-
- 2 edits in trunk/Tools
[Qt] Remove forced use of gold.
Reviewed by Tor Arne Vestbø.
The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
- qmake/mkspecs/features/unix/default_post.prf:
- 6:29 AM Changeset in webkit [128884] by
-
- 2 edits in trunk/Tools
[Qt] Prospective Qt/Windows cross-compiling fix
Reviewed by Tor Arne Vestbø.
The win32 scope is not set when cross-compiling from Linux to Windows.
- qmake/mkspecs/features/functions.prf:
- 6:23 AM Changeset in webkit [128883] by
-
- 6 edits in trunk/Source/WebKit2
Unreviewed, rolling out r128849.
http://trac.webkit.org/changeset/128849
https://bugs.webkit.org/show_bug.cgi?id=97007
Causes test_ewk2_view to time out. (Requested by rakuco on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-18
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_webprocess_crashed):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_private.h:
- UIProcess/API/efl/ewk_view_ui_client.cpp:
(ewk_view_ui_client_attach):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 6:02 AM Changeset in webkit [128882] by
-
- 81 edits17 adds1 delete in trunk/LayoutTests
[EFL] Rebaseline several test cases in Skipped list
https://bugs.webkit.org/show_bug.cgi?id=97000
Unreviewed EFL gardening.
Rebaseline several test cases an unskip them.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- platform/efl/animations/additive-transform-animations-expected.txt: Added.
- platform/efl/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
- platform/efl/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
- platform/efl/fast/events/offsetX-offsetY-expected.txt: Removed.
- platform/efl/fast/events/pointer-events-2-expected.png:
- platform/efl/fast/events/pointer-events-2-expected.txt:
- platform/efl/fast/forms/001-expected.png:
- platform/efl/fast/forms/001-expected.txt:
- platform/efl/fast/forms/float-before-fieldset-expected.png:
- platform/efl/fast/forms/float-before-fieldset-expected.txt:
- platform/efl/fast/forms/form-element-geometry-expected.png:
- platform/efl/fast/forms/form-element-geometry-expected.txt:
- platform/efl/fast/forms/input-baseline-expected.png:
- platform/efl/fast/forms/input-baseline-expected.txt:
- platform/efl/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/efl/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/efl/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/efl/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/efl/fast/forms/mailto/advanced-get-expected.txt: Added.
- platform/efl/fast/forms/mailto/advanced-put-expected.txt: Added.
- platform/efl/fast/forms/placeholder-position-expected.png:
- platform/efl/fast/forms/placeholder-position-expected.txt:
- platform/efl/fast/forms/placeholder-pseudo-style-expected.png:
- platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/efl/fast/forms/textarea-placeholder-pseudo-style-expected.png:
- platform/efl/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/efl/fast/gradients/generated-gradients-expected.png:
- platform/efl/fast/gradients/generated-gradients-expected.txt:
- platform/efl/fast/gradients/radial-centered-expected.png:
- platform/efl/fast/gradients/radial-centered-expected.txt:
- platform/efl/fast/inline-block/contenteditable-baseline-expected.png:
- platform/efl/fast/inline-block/contenteditable-baseline-expected.txt:
- platform/efl/fast/inline/continuation-outlines-with-layers-2-expected.png:
- platform/efl/fast/inline/continuation-outlines-with-layers-2-expected.txt:
- platform/efl/fast/inline/inline-box-background-expected.png:
- platform/efl/fast/inline/inline-box-background-expected.txt:
- platform/efl/fast/inline/inline-box-background-long-image-expected.png:
- platform/efl/fast/inline/inline-box-background-long-image-expected.txt:
- platform/efl/fast/inline/inline-box-background-repeat-x-expected.png:
- platform/efl/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/efl/fast/inline/inline-box-background-repeat-y-expected.png:
- platform/efl/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/efl/fast/invalid/nestedh3s-expected.png:
- platform/efl/fast/invalid/nestedh3s-expected.txt:
- platform/efl/fast/overflow/overflow-float-stacking-expected.png:
- platform/efl/fast/overflow/overflow-float-stacking-expected.txt:
- platform/efl/fast/overflow/overflow-stacking-expected.png:
- platform/efl/fast/overflow/overflow-stacking-expected.txt:
- platform/efl/fast/repaint/block-layout-inline-children-replaced-expected.png:
- platform/efl/fast/repaint/block-layout-inline-children-replaced-expected.txt:
- platform/efl/fast/repaint/japanese-rl-selection-clear-expected.png:
- platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt:
- platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt:
- platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png:
- platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/efl/fast/repaint/moving-shadow-on-path-expected.png:
- platform/efl/fast/repaint/moving-shadow-on-path-expected.txt:
- platform/efl/fast/repaint/repaint-svg-after-style-change-expected.png: Added.
- platform/efl/fast/repaint/repaint-svg-after-style-change-expected.txt: Added.
- platform/efl/fast/repaint/table-section-repaint-expected.txt:
- platform/efl/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- platform/efl/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
- platform/efl/fast/replaced/width100percent-searchfield-expected.png:
- platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
- platform/efl/fast/table/027-expected.png:
- platform/efl/fast/table/027-expected.txt:
- platform/efl/fast/table/027-vertical-expected.png:
- platform/efl/fast/table/027-vertical-expected.txt:
- platform/efl/fast/table/032-expected.png:
- platform/efl/fast/table/032-expected.txt:
- platform/efl/fast/table/040-expected.png:
- platform/efl/fast/table/040-expected.txt:
- platform/efl/fast/table/040-vertical-expected.png:
- platform/efl/fast/table/040-vertical-expected.txt:
- platform/efl/fast/table/absolute-table-at-bottom-expected.png:
- platform/efl/fast/table/absolute-table-at-bottom-expected.txt:
- platform/efl/fast/table/border-collapsing/004-expected.png:
- platform/efl/fast/table/border-collapsing/004-expected.txt:
- platform/efl/fast/table/border-collapsing/004-vertical-expected.png:
- platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/efl/fast/table/dynamic-caption-add-before-child-expected.png:
- platform/efl/fast/table/dynamic-caption-add-before-child-expected.txt:
- platform/efl/fast/table/frame-and-rules-expected.png:
- platform/efl/fast/table/frame-and-rules-expected.txt:
- platform/efl/fast/table/multiple-captions-display-expected.png: Added.
- platform/efl/fast/table/multiple-captions-display-expected.txt:
- platform/efl/media/video-colorspace-yuv420-expected.png: Added.
- platform/efl/media/video-colorspace-yuv420-expected.txt: Added.
- platform/efl/media/video-colorspace-yuv422-expected.png: Added.
- platform/efl/media/video-colorspace-yuv422-expected.txt: Added.
- platform/efl/perf/nested-combined-selectors-expected.txt: Added.
- platform/efl/userscripts/script-run-at-end-expected.txt: Added.
- 5:56 AM Changeset in webkit [128881] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening after r128802.
- platform/efl/TestExpectations: Temporarily skip a few JS tests
which are crashing after r128802.
- 5:55 AM Changeset in webkit [128880] by
-
- 4 edits in trunk
[EFL] min-device-width failures in media tests
https://bugs.webkit.org/show_bug.cgi?id=96920
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Return a realistic value (800x600) for screen resolution if
it cannot be detected, instead of returning (0x0).
This allows for some tests to pass on the build bots
where X is not running.
No new tests, already covered by existing tests.
- platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenRect):
LayoutTests:
Unskip several test cases which should pass on the
build bots now that we return a realistic screen
resolution whenever it cannot be detected.
- platform/efl/TestExpectations:
- 5:51 AM Changeset in webkit [128879] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Clarify TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=97003
Unreviewed EFL gardening.
Slight reorganization and bug numbers updating
in EFL WK2 TestExpectations for clarity.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18
- platform/efl-wk2/TestExpectations:
- 5:39 AM Changeset in webkit [128878] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r128802): It made some JS tests crash
https://bugs.webkit.org/show_bug.cgi?id=97001
Unreviewed gardening, skip the new _crashing_ tests to paint the bots green.
- platform/qt/Skipped:
- 5:21 AM Changeset in webkit [128877] by
-
- 2 edits in trunk/Source/WebCore
Fix compilation with Qt 5 on MeeGo 1.2 Harmattan
https://bugs.webkit.org/show_bug.cgi?id=96937
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-09-18
Reviewed by Jocelyn Turcotte.
The gl2ext.h header file on the platform is outdated. Instead use the newer copy from Qt
through implicit inclusion of qopengl.h. Since Qt's declarations are based on newer Khronos
headers, the multi sampling extensions do have the PROC suffix, we need the same workaround
as QNX.
- platform/graphics/opengl/Extensions3DOpenGLES.h:
- 5:05 AM Changeset in webkit [128876] by
-
- 3 edits in trunk/Tools
[EFL] Remove background view on EWebLauncher and MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=96905
Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-09-18
Reviewed by Gyuyoung Kim.
The size of webview was changed after adding url bar.
And the background view is not necessary anymore, since it was used for debugging back in the day.
- EWebLauncher/main.c:
(_ELauncher):
(on_ecore_evas_resize):
(browserCreate):
- MiniBrowser/efl/main.c:
(_MiniBrowser):
(on_ecore_evas_resize):
(browserCreate):
- 4:41 AM Changeset in webkit [128875] by
-
- 11 edits in trunk
Web Inspector: [Extensions API] explicitly manage extension audit progress
https://bugs.webkit.org/show_bug.cgi?id=96803
Reviewed by Alexander Pavlov.
Source/WebCore:
- create a sub-progress per audit category;
- manage audit category progress within the category, not in the panel logic;
- consider audit is done when all categories are done;
- expose AuditResults.updateProgress(worked, totalWork) in the extensions API;
- retain old magic for computing audit progress if extension specifies extension results count.
- inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditCategory.prototype.run.callbackWrapper):
(WebInspector.AuditCategory.prototype.run):
- inspector/front-end/ExtensionAPI.js:
(defineCommonExtensionSymbols):
(injectedExtensionAPI.Audits.prototype.addCategory):
(injectedExtensionAPI.AuditResultImpl.prototype.updateProgress):
- inspector/front-end/ExtensionAuditCategory.js:
(WebInspector.ExtensionAuditCategory.prototype.run):
(WebInspector.ExtensionAuditCategoryResults):
(WebInspector.ExtensionAuditCategoryResults.prototype.done):
(WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
(WebInspector.ExtensionAuditCategoryResults.prototype.updateProgress):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onUpdateAuditProgress):
(WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun):
- inspector/front-end/ProgressBar.js:
(WebInspector.ProgressIndicator.prototype.done): Assure only first call to done() has effect.
LayoutTests:
- inspector/extensions/extensions-audits-api-expected.txt: Added AuditResults.updateProgress()
- inspector/extensions/extensions-audits.html: Added a call to updateProgress()
- 4:36 AM WebInspector edited by
- remove spam (diff)
- 4:33 AM Changeset in webkit [128874] by
-
- 2 edits in trunk/Tools
[GTK] run-webkit-tests unable to find TestExpectations for WK2
https://bugs.webkit.org/show_bug.cgi?id=96998
Reviewed by Philippe Normand.
We should look for TestExpectations files in all the locations where
we currently look for Skipped files. This will allow
run-webkit-tests to look for TestExpectations files in
platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.expectations_files):
- 4:14 AM Changeset in webkit [128873] by
-
- 10 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Update some pixel expectations after a long time.
japanese-lr-selection-expected.png now actually shows a selection
background, some shadows are displayed properly and some fonts
have had rendering adjustments.
- platform/efl/fast/writing-mode/basic-vertical-line-expected.png:
- platform/efl/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
- platform/efl/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
- platform/efl/fast/writing-mode/box-shadow-vertical-lr-expected.png:
- platform/efl/fast/writing-mode/box-shadow-vertical-rl-expected.png:
- platform/efl/fast/writing-mode/english-bt-text-expected.png:
- platform/efl/fast/writing-mode/english-rl-text-expected.png:
- platform/efl/fast/writing-mode/fieldsets-expected.png:
- platform/efl/fast/writing-mode/japanese-lr-selection-expected.png:
- 4:05 AM clutter edited by
- (diff)
- 4:04 AM clutter edited by
- (diff)
- 3:57 AM Changeset in webkit [128872] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening after r128802.
- platform/efl/TestExpectations: Unskip test that is now passing.
- 3:34 AM Changeset in webkit [128871] by
-
- 6 edits in trunk/Source/WebKit2
[GTK] Set the area of tooltips in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=96618
Reviewed by Martin Robinson.
In GTK+ tooltips are associated to a widget, if the mouse is moved
inside the widget area, the tooltip position doesn't change even
if the tooltip text changes. To support multiple tooltips for the
same widget, we need to set the area of the widget for every
tooltip.
- Shared/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::Data::encode): Encode elementBoundingBox.
(WebKit::WebHitTestResult::Data::decode): Decode elementBoundingBox.
- Shared/WebHitTestResult.h:
(Data): Add elementBoundingBox to WebHitTestResult::Data.
(WebKit::WebHitTestResult::Data::elementBoundingBoxInWindowCoordinates):
Get the bounding box of the inner non shared node of the hit test
result in window coordinates.
(WebKit::WebHitTestResult::Data::Data):
(WebKit::WebHitTestResult::elementBoundingBox):
(WebHitTestResult):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewMouseTargetChanged): Call webkitWebViewBaseSetTooltipArea.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseQueryTooltip): Use the tooltipArea if it's not empty.
(webkitWebViewBaseSetTooltipArea): Set the tooltipArea.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- 3:29 AM Changeset in webkit [128870] by
-
- 24 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Update MathML expectations after r128837.
- platform/efl/mathml/presentation/attributes-expected.txt:
- platform/efl/mathml/presentation/fenced-expected.txt:
- platform/efl/mathml/presentation/fenced-mi-expected.png:
- platform/efl/mathml/presentation/fenced-mi-expected.txt:
- platform/efl/mathml/presentation/fractions-expected.txt:
- platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/efl/mathml/presentation/mo-stretch-expected.png:
- platform/efl/mathml/presentation/mo-stretch-expected.txt:
- platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
- platform/efl/mathml/presentation/roots-expected.txt:
- platform/efl/mathml/presentation/row-alignment-expected.png:
- platform/efl/mathml/presentation/row-alignment-expected.txt:
- platform/efl/mathml/presentation/style-expected.txt:
- platform/efl/mathml/presentation/sub-expected.txt:
- platform/efl/mathml/presentation/subsup-expected.png:
- platform/efl/mathml/presentation/subsup-expected.txt:
- platform/efl/mathml/presentation/sup-expected.txt:
- platform/efl/mathml/presentation/tables-expected.png:
- platform/efl/mathml/presentation/tables-expected.txt:
- platform/efl/mathml/presentation/tokenElements-expected.txt:
- platform/efl/mathml/presentation/under-expected.txt:
- platform/efl/mathml/presentation/underover-expected.txt:
- platform/efl/mathml/xHeight-expected.txt:
- 3:28 AM Changeset in webkit [128869] by
-
- 2 edits in trunk/Source/WebCore
Revert r127457 and following fixes due to several hit-testing regressions
https://bugs.webkit.org/show_bug.cgi?id=96830
Reviewed by Antonio Gomes.
The revert misssed one related follow-up.
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
- 3:23 AM Changeset in webkit [128868] by
-
- 4 edits in trunk
[Qt] Fix build without the QtQuick module
Reviewed by Simon Hausmann.
- 2:42 AM Changeset in webkit [128867] by
-
- 2 edits in trunk/Source/JavaScriptCore
Not reviewed. Attempt at greening the WinCairo bot. Touching
LowLevelInterpreter.asm to trigger a rebuild of LLIntDesiredOffsets.
https://bugs.webkit.org/show_bug.cgi?id=96992.
- llint/LowLevelInterpreter.asm:
- 2:40 AM BuildingQtOnLinux edited by
- (diff)
- 2:32 AM Changeset in webkit [128866] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Unskip fast/js/global-constructors.html
https://bugs.webkit.org/show_bug.cgi?id=96984
Unreviewed EFL gardening.
Generate baseline for fast/js/global-constructors.html
and unskip test. The only differences in the expected
output are due to webkit prefix.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-18
- fast/js/global-constructors-expected.txt: Added.
- platform/efl/Skipped:
- 2:11 AM Changeset in webkit [128865] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] REGRESSION(r128790): It broke the ARM build
https://bugs.webkit.org/show_bug.cgi?id=96968
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-09-18
Reviewed by Filip Pizlo.
Implement the missing or32 method in the MacroAssemblerARM.h.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::or32):
(MacroAssemblerARM):
- 2:11 AM Changeset in webkit [128864] by
-
- 2 edits in trunk/Tools
Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
Unreviewed.
- DumpRenderTree/mac/DumpRenderTree.mm:
(poseAsClass):
- 1:58 AM Changeset in webkit [128863] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skipped failing tests because eventSender.gestureTap
is not implemented on Qt, ENABLE(SHADOW_DOM) is disabled and
WebKitDisplayImagesKey is not supported.
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-09-18
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 1:46 AM Changeset in webkit [128862] by
-
- 39 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining MathML tests' baselines after r128837.
- platform/gtk/mathml/presentation/attributes-expected.png:
- platform/gtk/mathml/presentation/attributes-expected.txt:
- platform/gtk/mathml/presentation/fenced-expected.txt:
- platform/gtk/mathml/presentation/fenced-mi-expected.png:
- platform/gtk/mathml/presentation/fenced-mi-expected.txt:
- platform/gtk/mathml/presentation/fractions-expected.png:
- platform/gtk/mathml/presentation/fractions-expected.txt:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/gtk/mathml/presentation/mo-expected.png:
- platform/gtk/mathml/presentation/mo-expected.txt:
- platform/gtk/mathml/presentation/mo-stretch-expected.png:
- platform/gtk/mathml/presentation/mo-stretch-expected.txt:
- platform/gtk/mathml/presentation/mroot-pref-width-expected.txt:
- platform/gtk/mathml/presentation/over-expected.png:
- platform/gtk/mathml/presentation/over-expected.txt:
- platform/gtk/mathml/presentation/roots-expected.png:
- platform/gtk/mathml/presentation/roots-expected.txt:
- platform/gtk/mathml/presentation/row-alignment-expected.png:
- platform/gtk/mathml/presentation/row-alignment-expected.txt:
- platform/gtk/mathml/presentation/row-expected.png:
- platform/gtk/mathml/presentation/row-expected.txt:
- platform/gtk/mathml/presentation/style-expected.png:
- platform/gtk/mathml/presentation/style-expected.txt:
- platform/gtk/mathml/presentation/sub-expected.png:
- platform/gtk/mathml/presentation/sub-expected.txt:
- platform/gtk/mathml/presentation/subsup-expected.png:
- platform/gtk/mathml/presentation/subsup-expected.txt:
- platform/gtk/mathml/presentation/sup-expected.png:
- platform/gtk/mathml/presentation/sup-expected.txt:
- platform/gtk/mathml/presentation/tables-expected.png:
- platform/gtk/mathml/presentation/tables-expected.txt:
- platform/gtk/mathml/presentation/tokenElements-expected.txt:
- platform/gtk/mathml/presentation/under-expected.png:
- platform/gtk/mathml/presentation/under-expected.txt:
- platform/gtk/mathml/presentation/underover-expected.png:
- platform/gtk/mathml/presentation/underover-expected.txt:
- platform/gtk/mathml/xHeight-expected.png: Added.
- platform/gtk/mathml/xHeight-expected.txt:
- 1:39 AM Changeset in webkit [128861] by
-
- 10 edits3 adds in trunk
[CSSRegions]Flag auto-height regions
https://bugs.webkit.org/show_bug.cgi?id=96267
Reviewed by Julien Chaffraix.
Source/WebCore:
The regions having auto logical height should be flagged so that their height will computed as part of a 2 pass-layout mechanism.
A valid region is flagged as having auto logical height if:
- has auto logical height and is part of the normal flow
- has auto logical height, is not part of normal flow and does not have logical top/bottom specified
An invalid region (part of circular dependency) will not be marked even if its style matches the above situations.
Test: fast/regions/autoheight-regions-mark.html
- rendering/FlowThreadController.cpp: Keep a counter of auto logical height valid regions.
(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads): Verify that the current number of auto logical height regions is correct by iterating over all the regions attached to the flow threads
and compute the number of auto logical height regions on the spot.
(WebCore):
(WebCore::FlowThreadController::isAutoLogicalHeightRegionsFlagConsistent): Helper function that is used to verify the number of auto logical height regions.
- rendering/FlowThreadController.h:
(WebCore::FlowThreadController::hasAutoLogicalHeightRegions):
(WebCore::FlowThreadController::incrementAutoLogicalHeightRegions):
(WebCore::FlowThreadController::decrementAutoLogicalHeightRegions):
(FlowThreadController):
- rendering/RenderFlowThread.cpp:
(WebCore):
(WebCore::RenderFlowThread::autoLogicalHeightRegionsCount): Helper function that is used to count the number of regions marked as having auto logical height.
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
(WebCore):
(WebCore::RenderRegion::styleDidChange): For a region that is attached to a flow thread, verify whether the style change modified its auto logical height appearance.
(WebCore::RenderRegion::attachRegion): Handle the case of attaching region to a flow thread and the detach/attach sequence when the region is moved in the render tree.
(WebCore::RenderRegion::detachRegion):
- rendering/RenderRegion.h:
(WebCore::RenderRegion::shouldHaveAutoLogicalHeight):
(WebCore::RenderRegion::hasAutoLogicalHeight):
(RenderRegion):
- rendering/RenderTreeAsText.cpp: For the regions that use auto logical height, modify the output to reflect that.
(WebCore::writeRenderNamedFlowThreads):
LayoutTests:
The regions having auto logical height should be flagged so that their height will computed as part of a 2 pass-layout mechanism.
Added a test that checks whether a region in several situations is marked properly.
- fast/regions/autoheight-regions-mark.html: Added.
- platform/mac/fast/regions/autoheight-regions-mark-expected.png: Added.
- platform/mac/fast/regions/autoheight-regions-mark-expected.txt: Added.
- platform/chromium/TestExpectations:
- 1:35 AM Changeset in webkit [128860] by
-
- 7 edits5 adds in trunk/Source/JavaScriptCore
Fix for WinCairo builds.
https://bugs.webkit.org/show_bug.cgi?id=96992.
Reviewed by Filip Pizlo.
Adding additional vcproj build targets in LLIntDesiredOffsets.vcproj,
LLIntOffsetsExtractor.vcproj, and LLIntAssembly.vcproj to match those
in jsc.vcproj.
- JavaScriptCore.vcproj/LLIntAssembly/LLIntAssembly.vcproj:
- JavaScriptCore.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.vcproj:
- JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcproj:
- JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.vsprops: Added property svn:eol-style.
- JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebug.vsprops: Added property svn:eol-style.
- JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebugAll.vsprops: Added.
- JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebugCairoCFLite.vsprops: Added.
- JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorProduction.vsprops: Added.
- JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorRelease.vsprops: Added property svn:eol-style.
- JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorReleaseCairoCFLite.vsprops: Added.
- JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorReleasePGO.vsprops: Added.
- 1:21 AM Changeset in webkit [128859] by
-
- 2 edits in trunk/Tools
Unreviewed update of email addresses for Berlin QtWebKit office.
- Scripts/webkitpy/common/config/committers.py:
- 1:17 AM Changeset in webkit [128858] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Prevent scroll adjustment of input fields when region of interest mechanism active
https://bugs.webkit.org/show_bug.cgi?id=96750
Reviewed by Antonio Gomes.
The region of interest mechanism replaces the scrolling/zooming
functionality in InputHandler::ensureFocusTextElementVisible().
We introduce a new fine-grained setting for the various adjustment
modes. The WebKit embedder can disable all scroll types in favor of the
region of interest mechanism by using the new setting.
PR #208387
Reviewed internally by Mike Fenton.
- WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::configPage):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- WebKitSupport/InputHandler.h:
- 12:29 AM Changeset in webkit [128857] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix sloppy English in comment.
- runtime/JSGlobalObject.cpp:
(JSC):
- 12:28 AM Changeset in webkit [128856] by
-
- 43 edits in trunk
Disable adding an AuthorShadowRoot to replaced elements.
https://bugs.webkit.org/show_bug.cgi?id=96978
Reviewed by Hajime Morita.
Source/WebCore:
We (people who implement Shadow DOM) have concluded that we don't support adding AuthorShadowRoot to
replaced elements in the current spec, since it turned out that a lot of difficulties exist and it brings
a lot of mess to our codebase.
For now, we just disable adding AuthorShadowRoot to these replaced elements.
Test: fast/dom/shadow/shadow-disable.html
- html/HTMLImageElement.h:
- html/HTMLKeygenElement.h:
- html/HTMLMeterElement.h:
- html/HTMLProgressElement.h:
- html/HTMLTextAreaElement.h:
LayoutTests:
Since we don't support AuthorShadowRoot for replaced elements for now, we enable a flat to
support AuthorShadowRoot in these tests.
Also, we have a test to check to reject adding ShadowRoot to repalced elements.
- fast/dom/shadow/select-image-with-shadow.html:
- fast/dom/shadow/shadow-disable-expected.txt:
- fast/dom/shadow/shadow-disable.html: Checks WebKit rejects adding ShadowRoot to repalced elements.
- fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html:
- fast/dom/shadow/shadowdom-for-image-alt-update.html:
- fast/dom/shadow/shadowdom-for-image-alt.html:
- fast/dom/shadow/shadowdom-for-image-content.html:
- fast/dom/shadow/shadowdom-for-image-dynamic.html:
- fast/dom/shadow/shadowdom-for-image-event-click.html:
- fast/dom/shadow/shadowdom-for-image-event.html:
- fast/dom/shadow/shadowdom-for-image-in-shadowdom.html:
- fast/dom/shadow/shadowdom-for-image-map.html:
- fast/dom/shadow/shadowdom-for-image-style.html:
- fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html:
- fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html:
- fast/dom/shadow/shadowdom-for-image-with-width-and-height.html:
- fast/dom/shadow/shadowdom-for-image.html:
- fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html:
- fast/dom/shadow/shadowdom-for-keygen-without-shadow.html:
- fast/dom/shadow/shadowdom-for-meter-dynamic.html:
- fast/dom/shadow/shadowdom-for-meter-multiple.html:
- fast/dom/shadow/shadowdom-for-meter-with-style.html:
- fast/dom/shadow/shadowdom-for-meter-without-appearance.html:
- fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html:
- fast/dom/shadow/shadowdom-for-meter.html:
- fast/dom/shadow/shadowdom-for-object-only-shadow.html:
- fast/dom/shadow/shadowdom-for-progress-dynamic.html:
- fast/dom/shadow/shadowdom-for-progress-multiple.html:
- fast/dom/shadow/shadowdom-for-progress-with-style.html:
- fast/dom/shadow/shadowdom-for-progress-without-appearance.html:
- fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html:
- fast/dom/shadow/shadowdom-for-progress.html:
- fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html:
- fast/dom/shadow/shadowdom-for-textarea-with-placeholder.html:
- fast/dom/shadow/shadowdom-for-textarea-without-shadow.html:
- fast/dom/shadow/shadowdom-for-textarea.html:
- 12:20 AM Changeset in webkit [128855] by
-
- 2 edits in trunk
[CMAKE] Fix build break because of memory exhausted.
https://bugs.webkit.org/show_bug.cgi?id=77327
Reviewed by Gyuyoung Kim.
Added to avoid memory exhaustion on 32bit linux debug build.
- Source/cmake/OptionsCommon.cmake:
