Timeline



Sep 27, 2012:

11:18 PM Changeset in webkit [129854] by yosin@chromium.org
  • 4 edits in trunk/Source/WebCore

[Forms] Adding placeholder feature to DateTimeNumericElement, and update its existing subclasses.
​https://bugs.webkit.org/show_bug.cgi?id=97863

Reviewed by Kent Tamura.

This patch is a part of preparation of implementing multiple fields
date/time input UI.

This patch introduces placeholder feature to DateTimeNumericElement
to display date format guide in field, e.g. displaying "dd/mm/yyyy".

Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_MULTIPLE_FIELDS_UI.

No new tests. This patch doesn't change behavior.

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeHourFieldElement::DateTimeHourFieldElement): Changed to pass placeholder class to base class.
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement): ditto
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement): ditto
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement): ditto

  • html/shadow/DateTimeNumericFieldElement.cpp: Removed no more needed static function displaySizeOfNumbre().

(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement): Changed to add new parameter to take placeholder.
(WebCore::DateTimeNumericFieldElement::visibleValue): Changed to use m_placholder.

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Changed to add a member variable m_placholder to hold placholder to DateTimeNumbericElement class.

11:10 PM Changeset in webkit [129853] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

Empty URL gets through to acceptNavigationRequest()
​https://bugs.webkit.org/show_bug.cgi?id=97076

Reviewed by George Staikos.

Invalid URLs in iframe src results in an empty URL in platform request, we should reject
such URL as early as we identify it.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):

10:21 PM Changeset in webkit [129852] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Make sure Localizer class is not copyable
​https://bugs.webkit.org/show_bug.cgi?id=97857

Reviewed by Kentaro Hara.

We don't intent Localizer obejcts are copyable.

  • platform/text/Localizer.h:

(Localizer): Add WTF_MAKE_NONCOPYABLE.

10:15 PM Changeset in webkit [129851] by thakis@chromium.org
  • 5 edits in trunk/Source/WebCore

Delete some unused code. Found by -Wunused-function.
​https://bugs.webkit.org/show_bug.cgi?id=97858

Reviewed by Anders Carlsson.

No intended behavior change.

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore):

  • platform/graphics/chromium/CrossProcessFontLoading.mm:
  • platform/graphics/skia/GraphicsContextSkia.cpp:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore):

10:03 PM Changeset in webkit [129850] by pilgrim@chromium.org
  • 23 edits in trunk/Source/WebKit/chromium

[Chromium] Update WebVector.h references
​https://bugs.webkit.org/show_bug.cgi?id=97855

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/ApplicationCacheHost.cpp:
  • src/AudioDestinationChromium.h:
  • src/AutofillPopupMenuClient.cpp:
  • src/CompositionUnderlineBuilder.h:
  • src/CompositionUnderlineVectorBuilder.h:
  • src/ContextMenuClientImpl.cpp:
  • src/ExternalPopupMenu.cpp:
  • src/FrameLoaderClientImpl.cpp:
  • src/PlatformSupport.cpp:
  • src/WebDataSourceImpl.cpp:
  • src/WebDragData.cpp:
  • src/WebFileChooserCompletionImpl.h:
  • src/WebFileSystemCallbacksImpl.h:
  • src/WebFrameImpl.cpp:
  • src/WebHistoryItem.cpp:
  • src/WebIDBKeyPath.cpp:
  • src/WebIDBMetadata.cpp:
  • src/WebNode.cpp:
  • src/WebPageSerializer.cpp:
  • src/WebPageSerializerImpl.cpp:
  • src/WebTextCheckingCompletionImpl.cpp:
  • src/WorkerFileSystemCallbacksBridge.h:
9:27 PM Changeset in webkit [129849] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] StringCache::v8ExternalString() can return a stale persistent handle
​https://bugs.webkit.org/show_bug.cgi?id=97767

Reviewed by Adam Barth.

For details, see the Chromium bug: ​http://code.google.com/p/chromium/issues/detail?id=151902

StringCache::v8ExternalString() can return a stale persistent handle
in the following scenario:

(1) Assume that StringImpl A with value "foo" is in m_stringCache.
(2) StringImpl B with value "foo" is accessed. At this point, m_lastStringImpl
points to B, and m_lastV8String points to B's handle.
(3) A minor GC is triggered and a weak callback is called back for StringImpl A.
At this point, "foo" is removed from m_stringCache. A's handle is disposed.
However, m_lastV8String is not cleared because m_lastStringImpl (i.e. StringImpl B)
is not equal to StringImpl A. As a result, m_lastV8String points to a stale
persistent handle.
(4) The persistent handle is eventually reused in V8 and made weak again.
(5) StringImpl B with value "foo" is accessed. Then StringCache::v8ExternalString()
returns the stale persistent handle, which is already used for another purpose.

To solve the problem, we need to clear m_stringImpl and m_lastV8String when any
string wrapper is disposed. Specifically, we need to change the code like this:

static void cachedStringCallback(v8::Persistent<v8::Value> wrapper, void* parameter)
{

StringImpl* stringImpl = static_cast<StringImpl*>(parameter);
V8PerIsolateData::current()->stringCache()->remove(stringImpl);
wrapper.Dispose();
stringImpl->deref();

}

void StringCache::remove(StringImpl* stringImpl)
{

m_stringCache.remove(stringImpl);
if (m_lastStringImpl.get() == stringImpl) { Remove this line.

m_lastStringImpl = 0;
m_lastV8String.Clear();

}

}

Note: Removing the line might be stronger than is needed. Instead of removing
the line, we can just replace the line with 'if (m_lastV8String == wrapper)'.
However, just in case (for correctness), I'd prefer removing the line.
Given that GC won't happen so frequently, clearing the cache in every weak callback
won't affect performance.

No tests because it depends on the GC behavior and I couldn't reproduce the bug.

  • bindings/v8/V8ValueCache.cpp:

(WebCore::StringCache::remove):

9:18 PM Changeset in webkit [129848] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Build fix after r129824.

  • DOM/resources/dom-perf.js:

(runBenchmarkSuite):

9:16 PM Changeset in webkit [129847] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Remove unused features and reduce code duplications in PerfTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=97852

Reviewed by Kentaro Hara.

Made the following refactoring changes:

  • Remove PerfTestRunner.info since it's never used.
  • Moved the js heap/malloc related functions up to where they belong.
  • Moved the initialization of _callsPerIteration, _test, and -description into _start, and stopped initializing _runFunction and _doneFunction since both test times now use _test object.
  • Made _measureTimeOnce and _measureRunsPerSecondOnce return the measured value instead of calling ignoreWarmUpAndLog and _runLoop to share the code; they're now called in _measureRunsPerSecondOnce.
  • resources/runner.js:

(PerfTestRunner.storeHeapResults): Moved.
(PerfTestRunner.getUsedMallocHeap): Moved.
(PerfTestRunner.getUsedJSHeap): Moved.
(PerfTestRunner.getAndPrintMemoryStatistics): Moved.
(PerfTestRunner._scheduleNextMeasurementOrNotifyDone): Renamed from _runLoop. Calls
ignoreWarmUpAndLog and schedules the next call.
(PerfTestRunner._measureTimeOnce): Renamed from _runner.
(PerfTestRunner._start): Renamed from initAndStartLoop.
(PerfTestRunner.measureTime):
(PerfTestRunner.runPerSecond):
(PerfTestRunner._measureRunsPerSecondOnce): Renamed from _measureRunsPerSecondOnce.
(PerfTestRunner._perSecondRunnerIterator):

9:04 PM Changeset in webkit [129846] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Update comment in WebFrameClient to point to new userAgent() function
​https://bugs.webkit.org/show_bug.cgi?id=97854

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

  • public/WebFrameClient.h:

(WebFrameClient):

8:57 PM Changeset in webkit [129845] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unused PlatformSupport reference in ChromeClientImpl
​https://bugs.webkit.org/show_bug.cgi?id=97853

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/ChromeClientImpl.cpp:
8:51 PM Changeset in webkit [129844] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

CSSComputedStyleDeclaration::getPropertyCSSValue() triggering unnecessary relayouts and style recalcs
​https://bugs.webkit.org/show_bug.cgi?id=97760

Reviewed by Andreas Kling.

Currently getPropertyCSSValue() (which is also used to implement the more common getPropertyValue())
calls Document::updateLayoutIgnorePendingStylesheets() unconditionally. However only a few properties
are actually layout dependent, making many of these relayouts unnecessary. Moreover, triggering full
style recalc is also often unnecessary as the current node may already have valid style even if some
other parts of the tree require recalc.

  • Only trigger relayouts for layout dependent properties.
  • Trigger style recalc only if the style of the current element or its ancestors is dirty.


This is a significant (several percent) progression on some real world web content based page loading
benchmarks.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::isLayoutDependentProperty):
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/StyleResolver.h:

(WebCore::StyleResolver::hasViewportDependentMediaQueries):

  • dom/Document.cpp:

(WebCore::Document::hasPendingStyleRecalc):

Renamed for consistency.

(WebCore::Document::hasPendingForcedStyleRecalc):
(WebCore):

  • dom/Document.h:

(Document):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):

8:41 PM Changeset in webkit [129843] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove unused PlatformSupport reference in DraggedIsolatedFileSystem
​https://bugs.webkit.org/show_bug.cgi?id=97851

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:
8:15 PM Changeset in webkit [129842] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client)
​https://bugs.webkit.org/show_bug.cgi?id=95360

Patch by Andrew Lo <​anlo@rim.com> on 2012-09-27
Reviewed by Simon Fraser.

Remove unnecessary code introduced in ​http://trac.webkit.org/changeset/129808.

No new tests because it's already covered by fast/animation/request-animation-frame-iframe2.html.

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::addClient):
(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):

8:14 PM Changeset in webkit [129841] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Clean up includes in DateTimeChooserImpl
​https://bugs.webkit.org/show_bug.cgi?id=97847

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/DateTimeChooserImpl.cpp:
8:05 PM Changeset in webkit [129840] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove unused PlatformSupport reference in FontCacheSkia
​https://bugs.webkit.org/show_bug.cgi?id=97850

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • platform/graphics/skia/FontCacheSkia.cpp:
8:03 PM Changeset in webkit [129839] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Clean up includes in ColorChooserUIController
​https://bugs.webkit.org/show_bug.cgi?id=97849

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/ColorChooserUIController.cpp:
8:01 PM Changeset in webkit [129838] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Clean up includes in PaintAggregator
​https://bugs.webkit.org/show_bug.cgi?id=97848

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/painting/PaintAggregator.cpp:
7:59 PM Changeset in webkit [129837] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium][Android] Remove unused PlatformSupport reference in ScrollbarThemeChromiumAndroid
​https://bugs.webkit.org/show_bug.cgi?id=97846

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
7:57 PM Changeset in webkit [129836] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Clean up includes in SocketStreamHandle
​https://bugs.webkit.org/show_bug.cgi?id=97843

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/SocketStreamHandle.cpp:
7:55 PM Changeset in webkit [129835] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Clean up includes in AudioDestinationChromium
​https://bugs.webkit.org/show_bug.cgi?id=97845

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/AudioDestinationChromium.cpp:
7:40 PM Changeset in webkit [129834] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove unused PlatformSupport reference in ClipboardChromium
​https://bugs.webkit.org/show_bug.cgi?id=97840

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • platform/chromium/ClipboardChromium.cpp:
7:37 PM Changeset in webkit [129833] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unused PlatformSupport reference in WebFrameImpl
​https://bugs.webkit.org/show_bug.cgi?id=97842

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/WebFrameImpl.cpp:
7:36 PM Changeset in webkit [129832] by tkent@chromium.org
  • 12 edits in trunk

DateTimeNumericFieldElement should use Localizer functions.
​https://bugs.webkit.org/show_bug.cgi?id=97318

Reviewed by Hajime Morita.

Source/WebCore:

Source/WebCore:

Use Localizer functions instead of functions in LocalizedNumber to test
i18n behavior. This affects only layout tests because
Document::getLocalizer() always returns a Localizer for the browser
locale.

To obtain a Localizer object for <input>'s locale from a deep shadow node,
we add localeIdentifier() function to DateTimeFieldElement::FieldOwner
and DateTimeEditElement::EditControlOwner interfaces.

Tests: fast/forms/time-multiple-fields/time-multiple-fields-localization.html

  • html/shadow/DateTimeFieldElement.h:

(FieldOwner): Add localeIdentifier callback.
(DateTimeFieldElement): Add localeIdentifier().

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::localeIdentifier):
Added. Returns FieldOwner::localeIdentifier if m_fieldOwner is available.

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Declare localizer().

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::localizer):
Returns a Localizer for DateTimeFieldElement::localeIdentifier()
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent): Use localizer().
(WebCore::DateTimeNumericFieldElement::value): Use localizer().

  • html/shadow/DateTimeEditElement.h:

(EditControlOwner): Add localeIdentifier() callback.
(DateTimeEditElement):
Declare localeIdentifier(), which implements FieldOwner::localeIdentifier().

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::localeIdentifier):
Added. Returns EditControlOwner::localeIdentifier if m_editControlOwner is available.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Declare localeIdentifier(),
which implements EditControlOwner::localeIdentifier().

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::localeIdentifier):
Added. Returns <input>'s inherited locale identifier.

LayoutTests:

  • platform/chromium/TestExpectations:

Need rebaseline for non-Mac results.

  • platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt:

Update "ar" locale result.

7:16 PM Changeset in webkit [129831] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement reviewer feedback that I missed on bug 95930.
​https://bugs.webkit.org/show_bug.cgi?id=97752

Reviewed by Alexey Proskuryakov.

This patch updates the indentation of function parameters in a few places,
and reserves an appropriate amount of space when using StringBuilder.

  • css/CSSBasicShapes.cpp:

(WebCore::buildRectangleString):
(WebCore::CSSBasicShapeRectangle::cssText):
(WebCore::CSSBasicShapeRectangle::serializeResolvingVariables):
(WebCore::CSSBasicShapeCircle::serializeResolvingVariables):
(WebCore::CSSBasicShapeEllipse::serializeResolvingVariables):
(WebCore::buildPolygonString):

  • css/Rect.h:

(WebCore::Rect::serializeResolvingVariables):
(WebCore::Quad::serializeResolvingVariables):
(WebCore::Quad::generateCSSString):

6:43 PM Changeset in webkit [129830] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Put initializeHostCallReturnValue() behind #if ENABLE(JIT).
Fixes non JIT builds.
​https://bugs.webkit.org/show_bug.cgi?id=97838.

Reviewed by John Sullivan.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

6:23 PM FeatureFlags edited by yosin@chromium.org
Remove INPUT_TYPE_TIME_MULTIPLE_FIELDS (diff)
6:16 PM FeatureFlags edited by yosin@chromium.org
Add INPUT_MULTIPLE_FIELDS_UI (diff)
6:16 PM Changeset in webkit [129829] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r129823.
​http://trac.webkit.org/changeset/129823
​https://bugs.webkit.org/show_bug.cgi?id=97837

Cause a bunch of pixel failures on Chrome Linux that look like
real regressions (Requested by ojan on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-27

  • platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::setupPaint):

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformWidthForGlyph):

5:51 PM Changeset in webkit [129828] by andersca@apple.com
  • 6 edits
    2 deletes in trunk/Source/WebKit

Get rid of more unused WK1 plug-in code
​https://bugs.webkit.org/show_bug.cgi?id=97835

Reviewed by Mark Rowe.

Source/WebKit:

Remove WebNetscapeDeprecatedFunctions.c and WebNetscapeDeprecatedFunctions.h from the Xcode project.

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Plugins/WebBasePluginPackage.mm:

Remove JavaCFMPluginFilename #define.

(-[WebBasePluginPackage initWithPath:]):
#ifndef ppc is always true now.

(-[WebBasePluginPackage isJavaPlugIn]):
Remove JavaCFMPluginFilename.

  • Plugins/WebNetscapeDeprecatedFunctions.c: Removed.
  • Plugins/WebNetscapeDeprecatedFunctions.h: Removed.

Remove functions that nobody calls anymore.

  • Plugins/WebNetscapePluginPackage.mm:

Remove +initialize call, the earliest version of Shockwave we now support doesn't
require us to have a valid CurApRefNum file anymore.

(-[WebNetscapePluginPackage _tryLoad]):
Remove more unused code.

  • Plugins/WebPluginDatabase.h:

Remove CFM from a comment.

5:50 PM Changeset in webkit [129827] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fixed CallFrameClosure::resetCallFrame() to use the valid
range of argument index values.
​https://bugs.webkit.org/show_bug.cgi?id=97836.

Reviewed by Gavin Barraclough.

  • interpreter/CallFrame.h:

(ExecState):

  • interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::resetCallFrame):

5:46 PM Changeset in webkit [129826] by aelias@chromium.org
  • 11 edits
    2 copies
    2 adds in trunk

[chromium] DumpRenderTree support for software compositing
​https://bugs.webkit.org/show_bug.cgi?id=96853

Reviewed by James Robinson.

This adds software compositor support to DumpRenderTree. The only
thing needed is a minimal OutputSurfaceSoftware that holds a
viewport-sized bitmap. Then, I added virtual test suite
platform/chromium/virtual/softwarecompositing -- a mirror of the
compositing/ directory with --enable-software-compositing, and
expectations for not yet supported tests.

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::softwareCompositingEnabled):
(TestShell::setSoftwareCompositingEnabled):
(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):

  • DumpRenderTree/chromium/WebViewHostOutputSurface.cpp:

(WebKit::WebViewHostOutputSurface::create3d):
(WebKit):
(WebKit::WebViewHostOutputSurface::createSoftware):
(WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
(WebKit::WebViewHostOutputSurface::bindToClient):
(WebKit::WebViewHostOutputSurface::surfaceSoftware):

  • DumpRenderTree/chromium/WebViewHostOutputSurface.h:

(WebKit):
(WebViewHostOutputSurface):

  • DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp: Copied from Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp.

(WebKit):
(WebKit::WebViewHostSoftwareOutputDevice::lockForWrite):
(WebKit::WebViewHostSoftwareOutputDevice::unlockForWrite):
(WebKit::WebViewHostSoftwareOutputDevice::lockForRead):
(WebKit::WebViewHostSoftwareOutputDevice::unlockForRead):
(WebKit::WebViewHostSoftwareOutputDevice::viewportChanged):

  • DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h: Copied from Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp.

(WebKit):
(WebViewHostSoftwareOutputDevice):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.virtual_test_suites):

LayoutTests:

  • platform/chromium/TestExpectations:
  • platform/chromium/virtual/softwarecompositing/README.txt: Added.
5:31 PM Changeset in webkit [129825] by pilgrim@chromium.org
  • 12 edits
    2 copies in trunk/Source

[Chromium] Remove screen-related functions from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=97474

Reviewed by Adam Barth.

Source/Platform:

Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

  • Platform.gypi:
  • chromium/public/WebScreenInfo.h: Added.

(WebKit):
(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):

Source/WebCore:

Part of a refactoring series. See tracking bug 82948.
Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

  • WebCore.gypi:
  • platform/Widget.h:
  • platform/chromium/PageClientChromium.h: Copied from Source/WebCore/platform/chromium/PlatformWidget.h.

(PageClientChromium):

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::toPlatformPageClient):
(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

  • public/WebScreenInfo.h:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::screenInfo):
(WebKit):

  • src/ChromeClientImpl.h:

(WebKit):
(WebKit::ChromeClientImpl::platformPageClient):
(ChromeClientImpl):

  • src/PlatformSupport.cpp:

(WebCore):

5:26 PM Changeset in webkit [129824] by rniwa@webkit.org
  • 16 edits in trunk/PerformanceTests

PerfTestRunner.run should take an object
​https://bugs.webkit.org/show_bug.cgi?id=97743

Reviewed by Kentaro Hara.

Rename PerfTestRunner.run to PerfTestRunner.measureTime and make it take an object instead of
5 arguments. Also get rid of PerfTestRunner._loopsPerRun since it's no longer used (it's always 1).

  • CSS/StyleSheetInsert.html:
  • DOM/resources/dom-perf.js:
  • Layout/floats_100_100.html:
  • Layout/floats_100_100_nested.html:
  • Layout/floats_20_100.html:
  • Layout/floats_20_100_nested.html:
  • Layout/floats_2_100.html:
  • Layout/floats_2_100_nested.html:
  • Layout/floats_50_100.html:
  • Layout/floats_50_100_nested.html:
  • Parser/html-parser.html:
  • Parser/html5-full-render.html:
  • SVG/SvgCubics.html:
  • SVG/SvgHitTesting.html:
  • resources/runner.js:
5:13 PM Changeset in webkit [129823] by bashi@chromium.org
  • 4 edits in trunk/Source/WebCore

[Chromium] FontHarfBuzz.cpp should not use drawTextOnPath().
​https://bugs.webkit.org/show_bug.cgi?id=97676

Reviewed by Tony Chang.

Use drawPosText() if possible for vertical text.
Use drawTextOnPath() only if the font doesn't have vhea/vmtx table.

No new tests. No change in behavior on LayoutTests.
Confirmed improvement in vertical text positioning using ipafont and Skia r5677.

  • platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::drawVerticalTextWithBrokenIdeographs): Added.
(WebCore):
(WebCore::Font::drawGlyphs): Draw vertical text by drawPosText() in a similar manner of FontSkia.cpp.
(WebCore::Font::drawComplexText): Disable setVerticalText(). Complex path doesn't support it now.

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::setupPaint): Call setVertialText().

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformWidthForGlyph): Disable setVerticalText() if the font doesn't have vertical metrics.

5:07 PM Changeset in webkit [129822] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r129806.
​http://trac.webkit.org/changeset/129806
​https://bugs.webkit.org/show_bug.cgi?id=97831

Broke windows build due to missing header (Requested by jsbell
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-27

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):

5:05 PM Changeset in webkit [129821] by commit-queue@webkit.org
  • 9 edits in trunk

Source/WebKit/chromium: Remove unused methods from Chromium WebKit API.
​https://bugs.webkit.org/show_bug.cgi?id=95254

Patch by Nasko Oskov <​nasko@chromium.org> on 2012-09-27
Reviewed by Adam Barth.

Removing methods, which are no longer in use.

  • public/WebFrame.h:
  • public/WebFrameClient.h:

(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent):

  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

(WebFrameImpl):

Tools: Move DumpRenderTree to use newer version of the name method of
WebFrame and the willCheckAndDispatchMessageEvent method of WebFrameClient
​https://bugs.webkit.org/show_bug.cgi?id=95254

Patch by Nasko Oskov <​nasko@chromium.org> on 2012-09-27
Reviewed by Adam Barth.

The WebFrame name() method is removed and replaced by better named
uniqueName() method, so DRT needs to be updated to use this new version.
Also the willCheckAndDispatchMessageEvent in WebFrameClient gained
one more parameter, which had to be added in DRT.

  • DumpRenderTree/chromium/TestShell.cpp:

(dumpFramesAsText):
(dumpFramesAsPrintedText):
(dumpFrameScrollPosition):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::unableToImplementPolicyWithError):
(WebViewHost::willCheckAndDispatchMessageEvent):
(WebViewHost::printFrameDescription):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

5:02 PM Changeset in webkit [129820] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Delete test that no longer exists.

  • platform/chromium/TestExpectations:
4:57 PM Changeset in webkit [129819] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Remove the clang pragmas to disable warnings in Noncopyable.h
​https://bugs.webkit.org/show_bug.cgi?id=97826

Reviewed by Beth Dakin.

Warnings about C++11 extensions are already disabled project-wide now so there's no need
to keep these pragmas.

  • wtf/Noncopyable.h:
4:51 PM Changeset in webkit [129818] by leviw@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp

Merge 129814 - REGRESSION(r129186): Pressing enter at the end of a line deletes the line
​https://bugs.webkit.org/show_bug.cgi?id=97763

Reviewed by Ryosuke Niwa.

r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.

This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).

  • rendering/RenderText.cpp:

(WebCore::RenderText::setTextWithOffset):

TBR=​leviw@chromium.org
Review URL: ​https://codereview.chromium.org/10993072

4:39 PM Changeset in webkit [129817] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

PerformanceTests/CSS/StyleSheetInsert.html has a time-dependent non-Gaussian distribution
​https://bugs.webkit.org/show_bug.cgi?id=97741

Reviewed by Antti Koivisto.

Reset the content in the iframe in each run so that the runtime from each run follows a normal distribution.
We can cleanup this code once my patch to replace the argument list of run by an object is landed.

  • CSS/StyleSheetInsert.html:
4:35 PM Changeset in webkit [129816] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Unreviewed. Minor appearance tweaks after r129813.

  • resources/results-template.html:
4:30 PM Changeset in webkit [129815] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

4:25 PM Changeset in webkit [129814] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r129186): Pressing enter at the end of a line deletes the line
​https://bugs.webkit.org/show_bug.cgi?id=97763

Reviewed by Ryosuke Niwa.

r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.

This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).

  • rendering/RenderText.cpp:

(WebCore::RenderText::setTextWithOffset):

4:23 PM Changeset in webkit [129813] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Results page should warn about time-dependent distributions
​https://bugs.webkit.org/show_bug.cgi?id=97818

Reviewed by Ojan Vafai.

Add a simple linear regression analysis on results page to detect time-dependent distributions.
We add a warning sign (inline SVG) when the regression gave us a slope of at least 0.01 and a R2 of at least 0.6.
Also added time-series graphs per run under the bar graphs so that humans can manually inspect them.

A nice follow up would be to add some normality test (e.g. Shapiro-Wilk) to detect bi-modal distributions
but we probably need to restructure the code to run it asynchronously since normality tests are slow.

  • resources/results-template.html:
4:05 PM Changeset in webkit [129812] by Lucas Forschler
  • 4 edits in tags/Safari-537.12/Source/WebKit2

Merge r129810.

3:48 PM Changeset in webkit [129811] by Lucas Forschler
  • 1 copy in tags/Safari-537.12

New Tag.

3:37 PM Changeset in webkit [129810] by Beth Dakin
  • 4 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=97823
Need to bump the WKBundlePageLoaderClient version after the addition of didLayout

Reviewed by Brady Eidson.

Bump the version.

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
3:33 PM Changeset in webkit [129809] by jsbell@chromium.org
  • 1 edit
    8 copies
    2 moves
    20 adds
    4 deletes in trunk/LayoutTests

IndexedDB: Split up setVersion and deleteDatabase sequencing tests
​https://bugs.webkit.org/show_bug.cgi?id=97482

Reviewed by Tony Chang.

Final chapter in the trilogy of webkit.org/b/97051 and webkit.org/b/97368 -
split up some complex multi-part tests so they are easier to understand and manage.

  • Split open-close-setversion -> setversion-*
  • Split factory-deletedatabase-interactions -> deletedatabase-*
  • storage/indexeddb/deletedatabase-blocked-expected.txt: Added.
  • storage/indexeddb/deletedatabase-blocked.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
  • storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt: Added.
  • storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
  • storage/indexeddb/deletedatabase-delayed-by-versionchange-expected.txt: Added.
  • storage/indexeddb/deletedatabase-delayed-by-versionchange.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
  • storage/indexeddb/deletedatabase-not-blocked-expected.txt: Added.
  • storage/indexeddb/deletedatabase-not-blocked.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt: Removed.
  • storage/indexeddb/open-close-version-expected.txt: Removed.
  • storage/indexeddb/resources/deletedatabase-blocked.js: Added.
  • storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js: Added.
  • storage/indexeddb/resources/deletedatabase-delayed-by-versionchange.js: Added.
  • storage/indexeddb/resources/deletedatabase-not-blocked.js: Added.
  • storage/indexeddb/resources/factory-deletedatabase-interactions.js: Removed.
  • storage/indexeddb/resources/open-close-version.js: Removed.
  • storage/indexeddb/resources/setversion-blocked-by-versionchange-close-in-blocked.js: Added.
  • storage/indexeddb/resources/setversion-blocked-by-versionchange-close.js: Added.
  • storage/indexeddb/resources/setversion-blocked.js: Added.
  • storage/indexeddb/resources/setversion-blocks-open.js: Added.
  • storage/indexeddb/resources/setversion-blocks-setversion.js: Added.
  • storage/indexeddb/resources/setversion-not-blocked.js: Added.
  • storage/indexeddb/setversion-blocked-by-versionchange-close-expected.txt: Added.
  • storage/indexeddb/setversion-blocked-by-versionchange-close-in-blocked-expected.txt: Added.
  • storage/indexeddb/setversion-blocked-by-versionchange-close-in-blocked.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
  • storage/indexeddb/setversion-blocked-by-versionchange-close.html: Renamed from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
  • storage/indexeddb/setversion-blocked-expected.txt: Added.
  • storage/indexeddb/setversion-blocked.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
  • storage/indexeddb/setversion-blocks-open-expected.txt: Added.
  • storage/indexeddb/setversion-blocks-open.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
  • storage/indexeddb/setversion-blocks-setversion-expected.txt: Added.
  • storage/indexeddb/setversion-blocks-setversion.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
  • storage/indexeddb/setversion-not-blocked-expected.txt: Added.
  • storage/indexeddb/setversion-not-blocked.html: Renamed from LayoutTests/storage/indexeddb/open-close-version.html.
3:25 PM Changeset in webkit [129808] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client)
​https://bugs.webkit.org/show_bug.cgi?id=95360

Patch by Andrew Lo <​anlo@rim.com> on 2012-09-27
Reviewed by Simon Fraser.

Source/WebCore:

DisplayRefreshMonitorManager::ensureMonitorForClient currently only adds the DisplayRefreshMonitorClient
to the appropriate DisplayRefreshMonitor when a new monitor is created.
It should also do so when it finds an existing monitor.

Test: fast/animation/request-animation-frame-iframe2.html

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::addClient):
(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):

LayoutTests:

Add a new test which does requestAnimationFrame in both a sub-frame and
main-frame, and checks that both were executed.

  • fast/animation/request-animation-frame-iframe2-expected.txt: Added.
  • fast/animation/request-animation-frame-iframe2.html: Added.
  • fast/animation/script-tests/request-animation-frame-subframe.html:

Remove element parameter from window.webkitRequestAnimationFrame.

3:15 PM Changeset in webkit [129807] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium debug build fix.

Two fixes makes one breakage

​http://trac.webkit.org/changeset/129785
​http://trac.webkit.org/changeset/129798

  • bindings/v8/V8Binding.h:

(WebCore::toNativeArguments):

3:03 PM Changeset in webkit [129806] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Optimize encodeString/decodeString
​https://bugs.webkit.org/show_bug.cgi?id=97794

Reviewed by Tony Chang.

Optimize string encoding/decoding, which showed up as a CPU hot spot during profiling.
The backing store uses big-endian ordering of 16-bit code unit strings, so a memcopy
isn't sufficient, but the code used StringBuilder::append() character-by-character
and custom byte-swapping which was slow.

Ran a test w/ DumpRenderTree (to avoid multiprocess overhead) taking a 10k character string
and putting it 20k times and getting it 20k times. On my test box, mean time before the
patch was 8.2s, mean time after the patch was 4.6s.

Tested by Chromium's webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*String*'

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):

3:01 PM Changeset in webkit [129805] by abarth@webkit.org
  • 3 edits in trunk/Tools

Add webkit_unit_tests to the flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=97814

Patch by Julie Parent <​jparent@chromium.org> on 2012-09-27
Reviewed by Dirk Pranke.

webkit_unit_tests run on the same bots as test_shell_tests.

  • TestResultServer/static-dashboards/builders.js:

(loadBuildersList):

  • TestResultServer/static-dashboards/dashboard_base.js:

(currentBuilderGroupCategory):

2:55 PM Changeset in webkit [129804] by fmalita@chromium.org
  • 2 edits in trunk/Tools

[Perftest] PerfTestRunner exception when using nested git checkouts
​https://bugs.webkit.org/show_bug.cgi?id=97796

Reviewed by Ryosuke Niwa.

In order to support separate Chromium vs. WebKit git trees, PerfTestsRunner needs to
instantiate per-repository SCM objects when collecting revision information.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_results_dict):

2:54 PM Changeset in webkit [129803] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix 32-bit build.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _initWithPath:]):
Add back the architecture check that i accidentally.

2:50 PM TestExpectations edited by dpranke@chromium.org
remove comments about ORWT and Skipped files (diff)
2:44 PM Changeset in webkit [129802] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
​https://bugs.webkit.org/show_bug.cgi?id=97805

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2012-09-27
Reviewed by Alexey Proskuryakov.

Add support for handling a string as modifier argument to keyDown().
This support has already been added to other ports, so implementing
this on Mac too, to be consistent with the other ports.

  • DumpRenderTree/mac/EventSendingController.mm:

(modifierFlags):
(buildModifierFlags):

2:36 PM Changeset in webkit [129801] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit/mac

Remove support for CFM plug-ins in WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=97822

Reviewed by Mark Rowe.

I'm pretty sure that CFM style plug-ins haven't been used for the last ten years or so,
so it's safe to remove them (especially since they're PPC only).

  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage openResourceFile]):
(-[WebNetscapePluginPackage closeResourceFile:]):
(-[WebNetscapePluginPackage _initWithPath:]):
(-[WebNetscapePluginPackage _tryLoad]):
(-[WebNetscapePluginPackage _unloadWithShutdown:]):

  • Plugins/WebPluginDatabase.mm:

(PluginPackageCandidates::PluginPackageCandidates):
(PluginPackageCandidates::update):
(PluginPackageCandidates::bestCandidate):
(PluginPackageCandidates):

2:33 PM Changeset in webkit [129800] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html is flaky on Mac debug
and is passing on all the other bots.

  • platform/chromium/TestExpectations:
2:25 PM Changeset in webkit [129799] by pilgrim@chromium.org
  • 6 edits in trunk/Source

[Chromium][Mac] Move Mac-specific theme functions out of PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=97817

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948. We're calling WebThemeEngine directly now instead of proxying through PlatformSupport.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::scrollbarStateToThemeState):
(WebCore):
(WebCore::ScrollbarThemeChromiumMac::paint):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
  • src/PlatformSupport.cpp:

(WebCore):

2:03 PM Changeset in webkit [129798] by arv@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix issue with ClassList which was hitting an assert in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=97820

Reviewed by Ojan Vafai.

​http://trac.webkit.org/changeset/129779 hit asserts in debug mode when trying to use fastGetAttribute on an SVG element.

No new tests. No change in behavior.

  • bindings/v8/V8Binding.h:

(WebCore::toNativeArguments):

  • html/ClassList.h:
1:59 PM Changeset in webkit [129797] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip a couple of passing tests.

  • platform/efl/TestExpectations:
1:49 PM Changeset in webkit [129796] by pdr@google.com
  • 7 edits
    2 adds in trunk

Rewrite multithreaded filter job dispatching
​https://bugs.webkit.org/show_bug.cgi?id=97500

Reviewed by Dean Jackson.

Source/WebCore:

This patch solves the problem of splitting up images into subregions for multithreaded
filters. This fixes the way we partition the image array into equal-sized chunks.
If we have an array of length N and want to split it into K chunks, we calculate:

int jobSize = N / K; integer division, so this is floored
int jobSizeExtra = N % K; modulus produces the remainder

We then split the array into jobSizeExtra number of jobs with size jobSize + 1
and (K - jobSizeExtra) number of jobs with size jobSize. This pattern
is used in each of the 5 filters in this patch.

This patch primarily fixes an error in FEMorphology::platformApply where
the image array was partitioned into (1 + (N / K)) pieces with the last job
taking the remainder. Unfortunately, this can cause overruns in the 2nd-to-last job.
Consider N = 2373 and K = 64 jobs. Job 0 would take indices 0...38, job 1 would take
38...76, etc. Unfortunately the 62nd job takes 2356...2394 which overruns.

To prevent similar issues elsewhere this patch updates all of the filters
to use the same pattern as FEMorphology.

Test: svg/filters/feMorphology-crash.html

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApply):

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGeneric):

  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApply):

Some special care is taken for Gaussian Blur because there is an
extraHeight parameter for sampling outside the image's dimensions.
This means we use the same partitioning algorithm but add
extraHeight padding on the lower and upper bounds.

  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

LayoutTests:

Add test that shows the morphology filter no longer crashes.
Note: this is only reliably reproducable when run with libgmalloc.

  • svg/filters/feMorphology-crash-expected.txt: Added.
  • svg/filters/feMorphology-crash.html: Added.
1:26 PM Changeset in webkit [129795] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium expectations update.

Flakey compositing tests and another flakey dom/shadow test.

  • platform/chromium/TestExpectations:
1:21 PM Changeset in webkit [129794] by dpranke@chromium.org
  • 2 edits in trunk/Tools

efl wk2 bots weren't looking at platform/wk2/TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=97815

Unreviewed, build fix.

Should clean up this logic later so that we're just using the
implementation in base ...

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._search_paths):
(EflPort.expectations_files):

12:57 PM Changeset in webkit [129793] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium expectations update.

Marking fast/dom/shadow/base-in-shadow-tree.html as timeout flakey.

  • platform/chromium/TestExpectations:
12:48 PM Changeset in webkit [129792] by pilgrim@chromium.org
  • 8 edits in trunk/Source

[Chromium] Move UNIX-specific theme functions out of PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=96516

Reviewed by Adam Barth.

Call WebThemeEngine functions and use WebThemeEngine enums
directly from the new Platform/ directly; remove all
intermediate functions and enums and conversion functions from
PlatformSupport.
Part of a refactoring series; see tracking bug 82948.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/ScrollbarThemeChromiumLinux.cpp:

(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::getWebThemeState):
(WebCore):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

12:44 PM Changeset in webkit [129791] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Cairo] Unnecessary creation of ShareableBitmap's for directly composited images
​https://bugs.webkit.org/show_bug.cgi?id=97745

Patch by Helder Correia <Helder Correia> on 2012-09-27
Reviewed by Martin Robinson.

In LayerTreeCoordinator::adoptImageBackingStore(), there is a
PLATFORM(QT) code path to check for identical images, but nothing is
done for Cairo, which results in the occurrence of avoidable resource
allocations.

The issue happens in e.g. ​http://www.webkit.org/blog-files/leaves/,
where there are many leaves flying around while they're produced out of
only four bitmaps.

This patch uses pointers to cairo_surface_t's as the key to the hashmap
that caches bitmaps. This can be safely done since we own the references.
We artificially increment the surface references in adoptImageBackingStore()
and decrement them in releaseImageBackingStore().

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):

12:33 PM Changeset in webkit [129790] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Stop using dispatch_get_current_queue
​https://bugs.webkit.org/show_bug.cgi?id=97806
<rdar://problem/12379094>

Reviewed by Mark Rowe.

  • Platform/mac/WorkQueueMac.cpp:

(WorkQueueAndFunction::WorkQueueAndFunction):
(WorkQueueAndFunction):
(WorkQueue::executeFunction):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
Keep track of the associated work queue so we can get it in WorkQueue::executeFunction.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::setUpTerminationNotificationHandler):
We don't care about which queue the termination notification is delivered on since we only want to call
waitpid on the child pid so we can just use a global queue.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]):
Use dispatch_get_main_queue here.

12:24 PM Changeset in webkit [129789] by mario@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2] IconDatabase: Add a way to notify when icon data is available
​https://bugs.webkit.org/show_bug.cgi?id=63945

Rubber stamped by Anders Carlsson.

Update version of WKIconDatabaseClient and API traits.

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKIconDatabase.h:
12:24 PM Changeset in webkit [129788] by dpranke@chromium.org
  • 17 edits
    1 move
    18 deletes in trunk/LayoutTests

merge Skipped file entries into TestExpectations, remove Skipped files
​https://bugs.webkit.org/show_bug.cgi?id=97750

Reviewed by Ojan Vafai.

Now that old-run-webkit-tests will skip any tests listed in
TestExpectations files, there is no need to have both Skipped
files and TestExpectations files. This change merges all of the
entries in the Skipped files into the TestExpectations files and
removes the Skipped files.

Subsequent changes will remove support for Skipped files from
both new-run-webkit-tests and old-run-webkit-tests to
complete the project.

  • platform/efl/Skipped: Removed.
  • platform/efl/TestExpectations:
  • platform/mac-lion/Skipped: Removed.
  • platform/mac-lion/TestExpectations:
  • platform/mac-snowleopard/Skipped: Removed.
  • platform/mac-snowleopard/TestExpectations:
  • platform/mac-wk2/Skipped: Removed.
  • platform/mac-wk2/TestExpectations:
  • platform/mac/Skipped: Removed.
  • platform/mac/TestExpectations:
  • platform/qt-4.8/Skipped: Removed.
  • platform/qt-4.8/TestExpectations:
  • platform/qt-5.0-wk1/Skipped: Removed.
  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt-5.0-wk2/Skipped: Removed.
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0/Skipped: Removed.
  • platform/qt-5.0/TestExpectations:
  • platform/qt-arm/Skipped: Removed.
  • platform/qt-arm/TestExpectations:
  • platform/qt-linux/Skipped: Removed.
  • platform/qt-mac/Skipped: Removed.
  • platform/qt-mac/TestExpectations:
  • platform/qt-win/Skipped: Removed.
  • platform/qt/Skipped: Removed.
  • platform/qt/TestExpectations:
  • platform/win-wk2/Skipped: Removed.
  • platform/win-wk2/TestExpectations:
  • platform/win-xp/Skipped: Removed.
  • platform/win-xp/TestExpectations:
  • platform/win/Skipped: Removed.
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations: Renamed from LayoutTests/platform/wincairo/Skipped.
  • platform/wk2/Skipped: Removed.
  • platform/wk2/TestExpectations:
12:23 PM Changeset in webkit [129787] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

[CSS Exclusions] Rename RenderStyle::wrapShapeInside/Outside to shapeInside/Outside
​https://bugs.webkit.org/show_bug.cgi?id=97707

Patch by Bear Travis <​betravis@adobe.com> on 2012-09-27
Reviewed by Antti Koivisto.

The exclusions specification has renamed wrap-shape-inside and wrap-shape-outside
to shape-inside and shape-outside. We should rename the getter/setter functions
in RenderStyle, and update the derived variable and function names accordingly.
For more information, see: ​http://dev.w3.org/csswg/css3-exclusions/#declaring-shapes

Covered by existing tests. No new functionality.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyExclusionShape::applyValue):
(WebCore::StyleBuilder::StyleBuilder):

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::exclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::removeExclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::computeShapeSize):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::exclusionShapeInsideInfo):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

12:04 PM Changeset in webkit [129786] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

ApplicationCacheStorage does not optimally handle 8 bit strings
​https://bugs.webkit.org/show_bug.cgi?id=97733

Reviewed by Alexey Proskuryakov.

Added 8 bit string paths.

No functional change, therefore no new tests.

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::urlHostHash):
(WebCore::ApplicationCacheStorage::store):
(WebCore::parseHeader):
(WebCore::parseHeaders):

12:03 PM Changeset in webkit [129785] by schenney@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium debug build fix.

ASSERT contains an inequality of unmatched types. A cast should do the trick.

  • bindings/v8/V8Binding.h:

(WebCore::toNativeArguments):

12:00 PM Changeset in webkit [129784] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkitpy: make warning about missing BUG identifiers per-port configurable
​https://bugs.webkit.org/show_bug.cgi?id=97751

Reviewed by Ojan Vafai.

Prior to this change linting TestExpectations files (checking their style)
would raise warnings if lines were missing a BUG modifier, even
though such a modifier is actually optional in the syntax. As we
migrate the entries over from the Skipped files, these warnings
will generate a lot of noise, and it's not yet clear that we
actually want to require the modifiers on all ports.

So, this change makes this per-port configurable so that they
will generate warnings in the Chromium TestExpectations and not
anywhere else.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._parse_modifiers):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(MiscTests.test_parse_warning):
(SemanticTests.test_missing_bugid):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.warn_if_bug_missing_in_test_expectations):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.warn_if_bug_missing_in_test_expectations):

11:47 AM Changeset in webkit [129783] by wangxianzhu@chromium.org
  • 6 edits
    2 deletes in trunk

[Chromium-Android] Push more fonts for layout tests to match chromium-linux
​https://bugs.webkit.org/show_bug.cgi?id=97746

Tools:

Reviewed by Dirk Pranke.

  • DumpRenderTree/chromium/android_fallback_fonts.xml: Added the new fonts into fallback list. Removed the Android system fallback font DroidSansFallback.ttf.
  • Scripts/webkitpy/layout_tests/port/builders.py: Add chromium-android to pass style check.
  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.check_build): Added check for md5sum and forwarder utilities to give better error message when they are missing.
(ChromiumAndroidPort.check_sys_deps): Allow host font files to come from one of multiple directories.
(ChromiumAndroidPort._path_to_md5sum):
(ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
(ChromiumAndroidDriver._push_fonts):
(ChromiumAndroidDriver._push_test_resources):

LayoutTests:

Some original rebaselines will be unnecessary after this change.
Checked some rebaselines of chromium-android under fast/text,
but there should be more. Leave them to gardening.

Reviewed by Dirk Pranke.

  • platform/chromium-android/TestExpectations: Enabled some skipped tests because now we have the fonts.
  • platform/chromium-android/fast/text/complex-text-opacity-expected.txt: Removed. No more need rebaselining.
  • platform/chromium-android/fast/text/international/hindi-spacing-expected.txt: Removed. No more need rebaselining.
11:41 AM Changeset in webkit [129782] by kbalazs@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] REGRESSION(r128980): It broke all QRawWebView API test
​https://bugs.webkit.org/show_bug.cgi?id=97561

Reviewed by Noam Rosenthal.

Make sure we always send the very first RenderNextFrame message.
Before r128980 it was working accidentally because in the common
case the web process sent a DeleteCompositingLayer message at some
point before the forced repaint would time out and we was sending
the first RenderNextFrame when reacting to that.

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebView::setActive): Set the LayerTreeRenderer to active
as well. In the QQuickWebView case it is handled by the QtWebPageSGNode.
(QRawWebView::layerTreeRenderer): Added a convenience getter
for the LayerTreeRenderer.
(QRawWebView::paint):

  • UIProcess/API/qt/raw/qrawwebview_p.h:

(WebKit):

  • UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:

(tst_qrawwebview::tst_qrawwebview): Added a call to addQtWebProcessToPath
to make my and the follower users of this test easier.

11:35 AM Changeset in webkit [129781] by adamk@chromium.org
  • 5 edits in trunk/Source/WebCore

Simplify and clarify MutationObserverRegistration interface and usage
​https://bugs.webkit.org/show_bug.cgi?id=97742

Reviewed by Ojan Vafai.

Minor cleanups in MutationObserverRegistration: make const methods explicitly const,
use C++ templates to avoid duplicating logic, improve usage of raw pointers vs PassRefPtr,
remove the declaration of a no-longer-existing method.

No change in behavior.

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach): Take a raw pointer because we don't always ref the node.
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom): Make this a const method.

  • dom/MutationObserverRegistration.h:

(MutationObserverRegistration): Removed declaration of non-existent caseInsensitiveAttributeFilter method.
(WebCore::MutationObserverRegistration::hasTransientRegistrations): const method.
(WebCore::MutationObserverRegistration::isSubtree): Remove superfluous "inline" keyword.
(WebCore::MutationObserverRegistration::observer): const method.

  • dom/Node.cpp:

(WebCore):
(WebCore::collectMatchingObserversForMutation): Add a templatized function to reduce duplicated code.
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver): Take a raw pointer because we don't always ref the observer.

  • dom/Node.h:

(Node): Remove old method, replaced by templatized static function.

11:30 AM Changeset in webkit [129780] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/WTF

Clean up HasTrivialConstructor/Destructor
​https://bugs.webkit.org/show_bug.cgi?id=97754

Reviewed by Darin Adler.

Cleaned up HasTrivialConstructor and HasTrivialDestructor by defining them in terms of
other type traits we have. Also moved some ifdefs and comments to make things more clear.

  • wtf/TypeTraits.h:
11:05 AM Changeset in webkit [129779] by arv@chromium.org
  • 28 edits in trunk

DOM4: Add support for rest parameters to DOMTokenList
​https://bugs.webkit.org/show_bug.cgi?id=97335

Reviewed by Ojan Vafai.

This adds support for rest paramaters to DOMTokenList add and remove.
​http://dom.spec.whatwg.org/#domtokenlist

The code generator has been updated to understand variadic methods.
When a method has a rest parameter the remaining arguments are collected
into a WTF::Vector.

DOMTokenList, DOMSettableTokenList and ClassList were restructured a bit to
allow code to be shared better.

Source/WebCore:

Updated existing tests and includes new binding tests.

  • bindings/js/JSDOMBinding.h:

(WebCore::toNativeArray):
(WebCore):
(WebCore::toNativeArguments): Similar to toNativeArray but extracts the arguments instead.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateArgumentsCountCheck): Updated to treat rest paramaters as optional.
(GenerateParametersCheck): Generate code for rest params.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionParametersCheck): Updated to treat rest paramaters as optional.
(GenerateArgumentsCountCheck): Ditto.
(GenerateParametersCheck): Generate code for rest params.

  • bindings/scripts/IDLParser.pm:

(parseOptionalOrRequiredArgument):

  • bindings/scripts/IDLStructure.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::variadicStringMethod):
(WebDOMTestObj::variadicDoubleMethod):
(WebDOMTestObj::variadicNodeMethod):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_variadic_string_method):
(webkit_dom_test_obj_variadic_double_method):
(webkit_dom_test_obj_variadic_node_method):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj variadicStringMethod:tail:]):
(-[DOMTestObj variadicDoubleMethod:tail:]):
(-[DOMTestObj variadicNodeMethod:tail:]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::variadicStringMethodCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::variadicDoubleMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

  • bindings/v8/V8Binding.h:

(WebCore::toNativeArray):
(WebCore):
(WebCore::toNativeArguments): Similar to toNativeArray but extracts the arguments instead.

  • html/ClassList.cpp:

(WebCore::ClassList::ClassList):

  • html/ClassList.h:

(WebCore):
(ClassList):

  • html/DOMSettableTokenList.cpp:

(WebCore::DOMSettableTokenList::containsInternal):
(WebCore::DOMSettableTokenList::add):
(WebCore::DOMSettableTokenList::addInternal):
(WebCore::DOMSettableTokenList::remove):
(WebCore::DOMSettableTokenList::removeInternal):
(WebCore::DOMSettableTokenList::setValue):

  • html/DOMSettableTokenList.h:

(DOMSettableTokenList):

  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::validateTokens):
(WebCore):
(WebCore::DOMTokenList::contains): Moved implementation to base class to allow code sharing.
(WebCore::DOMTokenList::add): Ditto.
(WebCore::DOMTokenList::remove): Ditto.
(WebCore::DOMTokenList::toggle): Ditto.
(WebCore::DOMTokenList::addInternal): Ditto.
(WebCore::DOMTokenList::removeInternal): Ditto.
(WebCore::DOMTokenList::addToken): Ditto.
(WebCore::DOMTokenList::addTokens):
(WebCore::DOMTokenList::removeToken): Ditto.
(WebCore::DOMTokenList::removeTokens):

  • html/DOMTokenList.h:

(DOMTokenList):
(WebCore::DOMTokenList::toString):

  • html/DOMTokenList.idl:

LayoutTests:

  • fast/dom/HTMLElement/class-list-expected.txt:
  • fast/dom/HTMLElement/class-list-quirks-expected.txt:
  • fast/dom/HTMLElement/script-tests/class-list.js:

(element.classList.add):
(createElement):
(shouldBeEqualToString):
(element.classList.remove):

10:52 AM Changeset in webkit [129778] by peter@chromium.org
  • 1 edit
    347 adds in trunk/LayoutTests

[Chromium] Rebaseline more test directories for Android.

Unreviewed rebaselining.

Same as previous commits. Most changes are caused by the scrollbar, text selection
color and quality differences in image quality, causing minor (but acceptable)
differences. More information is available in bug 96398.

  • platform/chromium-android/svg/: 71 new results.
  • platform/chromium-android/tables/: 250 new results.
  • platform/chromium-android/transforms/: 5 new results.
  • platform/chromium-android/transitions/: 1 new result.
10:38 AM Changeset in webkit [129777] by peter@chromium.org
  • 13 edits
    277 adds in trunk/LayoutTests

[Chromium] Rebaseline several test directories for Android/.

Unreviewed rebaselining.

Most of these changes were caused by our different scrollbars and minor
positioning issues, and therefore are safe to rebase. With Xianzhu's
patch in the tree that adds additional fonts, more pass there as well.
Actual failures include more form items. Bugs will be filed.

  • platform/chromium-android/animations/: 4 new results.
  • platform/chromium-android/compositing/: 72 new results.
  • platform/chromium-android/css2.1/: 52 new results.
  • platform/chromium-android/css3/: 5 new results.
  • platform/chromium-android/editing/: 46 new results.
  • platform/chromium-android/fast/: 42 new results.
  • platform/chromium-android/fonts/: 12 new results.
  • platform/chromium-android/http/: 5 new results.
  • platform/chromium-android/ietestcenter/: 4 new results.
  • platform/chromium-android/platform/: 13 new results.
  • platform/chromium-android/printing/: 2 new results.
  • platform/chromium-android/scrollbars/: 2 new results.
  • platform/chromium-android/svg/: 4 new results.
10:23 AM Changeset in webkit [129776] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

332kB below DocumentEventQueue::create() on Membuster3.
<​http://webkit.org/b/97712>

Reviewed by Anders Carlsson.

Give DocumentEventQueue::m_queuedEvents an inline capacity of 16 (the default is 256.)
312kB progression on Membuster3.

  • dom/DocumentEventQueue.h:
  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::pendingEventTimerFired):

10:09 AM Changeset in webkit [129775] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar pane.
​https://bugs.webkit.org/show_bug.cgi?id=97783

Reviewed by Pavel Feldman.

BreakpointSidebarPane now explicitly adds all breakpoints that are available at the moment of its creation.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._filteredBreakpointLocations):
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpointLocations):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):

10:09 AM Changeset in webkit [129774] by Patrick Gansterer
  • 3 edits in trunk/Source/JavaScriptCore

Fix usage of COMPILER() macros
​https://bugs.webkit.org/show_bug.cgi?id=97642

Reviewed by Geoffrey Garen.

Add COMPILER(GCC) around compiler specific code and remove it from generic code.
This allows us to implement the DFG code for other compilers to in a next step.

  • dfg/DFGOperations.cpp:
  • jit/HostCallReturnValue.h:
10:04 AM Changeset in webkit [129773] by kling@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

3.20MB below FunctionParameters::create() on Membuster3.
<​http://webkit.org/b/97730>

Reviewed by Anders Carlsson.

Figure out the exact space needed for parameter identifiers and use reserveInitialCapacity().
Reduces memory consumption on Membuster3 by ~1.60 MB.

  • parser/Nodes.cpp:

(JSC::FunctionParameters::FunctionParameters):

10:01 AM Changeset in webkit [129772] by caseq@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Page overlays are not updated when WebView is resized
​https://bugs.webkit.org/show_bug.cgi?id=97789

Reviewed by Vsevolod Vlasov.

Invalidate page overlays when view is resized.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::sendResizeEventAndRepaint):

9:58 AM Changeset in webkit [129771] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Dropping JSC references from InspectorInstrumentation.h by including 'ScriptState.h'
​https://bugs.webkit.org/show_bug.cgi?id=97759

Reviewed by Adam Barth.

InspectorInstrumentation.h includes two '#if USE(JSC)' blocks, which
I've been reliably informed should not appear in WebCore[1]. This patch
drops both blocks, and includes 'ScriptState.h' instead, which should
have the same practical effect.

There's no functional change, so this should be covered by existing tests.

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=94433#c55

  • inspector/InspectorInstrumentation.h:

(WebCore):

9:22 AM Changeset in webkit [129770] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-27

  • DEPS:
9:06 AM Changeset in webkit [129769] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused regular expressions from IDLStructure.pm
​https://bugs.webkit.org/show_bug.cgi?id=97790

Reviewed by Kentaro Hara.

After ​http://trac.webkit.org/changeset/129723 these regular expressions are no longer used.

No new tests, run-binding-tests generates the same output.

  • bindings/scripts/IDLStructure.pm:
8:54 AM Changeset in webkit [129768] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/profiler/apply.html fails with LLInt on 32 bit
​https://bugs.webkit.org/show_bug.cgi?id=97791

Unreviewed gardening, skip the new failing test to paint the bots green.

  • platform/qt/Skipped:
8:42 AM Changeset in webkit [129767] by schenney@chromium.org
  • 4 edits
    3 deletes in trunk/LayoutTests

Unreviewed Chromium expectations

Expectations that were lagging at the last rebaseline.

  • platform/chromium-linux-x86/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Removed.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/date: Removed.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/date: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Removed.
  • platform/chromium/TestExpectations:
8:26 AM Changeset in webkit [129766] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2][WTR] Unskip two jQuery test cases.
​https://bugs.webkit.org/show_bug.cgi?id=97787

Unreviewed EFL gardening.

'jquery/data.html' and 'jquery/offset.html' cases seem to be passed consistently now.

For more information, BUG 81606 resolved some jQuery test cases
that need several seconds to finish its running by extending timeout value like WK1.

Seemingly, mentioned two cases took around 5 seconds for each on my laptop
and it would had been flaky in different hardware condition before BUG 81606.

Therefore, this patch unskipped those cases from TestExpections.

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-09-27

  • platform/efl-wk2/TestExpectations:
8:18 AM EFLWebKit edited by Laszlo Gombos
Found no evidence that 3.0.4 version of gperf would be really required (diff)
8:08 AM Changeset in webkit [129765] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] Process touch events using mouse and multi events of Evas.
​https://bugs.webkit.org/show_bug.cgi?id=96906

Patch by Eunmi Lee <​eunmi15.lee@samsung.com> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Provide default behavior for processing touch events in the ewk_view if
application wants to use it.
We can to process touch events using mouse and multi events because the
Evas creates mouse events for first touch and multi events for second and
third touch. It can be modified when Evas starts to support event type
for touch events.

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_feed_touch_event_using_touch_point_list_of_evas):
(_ewk_view_on_touch_down):
(_ewk_view_on_touch_up):
(_ewk_view_on_touch_move):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::mouseDown):
(EWK2UnitTest):
(EWK2UnitTest::EWK2UnitTestBase::mouseUp):
(EWK2UnitTest::EWK2UnitTestBase::mouseMove):
(EWK2UnitTest::EWK2UnitTestBase::multiDown):
(EWK2UnitTest::EWK2UnitTestBase::multiUp):
(EWK2UnitTest::EWK2UnitTestBase::multiMove):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTestBase):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

7:56 AM Changeset in webkit [129764] by tommyw@google.com
  • 9 edits in trunk

MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data
​https://bugs.webkit.org/show_bug.cgi?id=97559

Reviewed by Adam Barth.

Source/Platform:

Refactored to mimic the new MediaConstraints api.

  • chromium/public/WebMediaConstraints.h:

(WebCore):
(WebKit::WebMediaConstraint::WebMediaConstraint):
(WebMediaConstraint):
(WebKit):
(WebMediaConstraints):

Source/WebCore:

Instead of just returning the names, return a pair of name and value.

Existing tests cover this patch.

  • Modules/mediastream/MediaConstraintsImpl.cpp:

(WebCore::MediaConstraintsImpl::initialize):
(WebCore::MediaConstraintsImpl::getMandatoryConstraints):
(WebCore::MediaConstraintsImpl::getOptionalConstraints):
(WebCore::MediaConstraintsImpl::getOptionalConstraintValue):

  • Modules/mediastream/MediaConstraintsImpl.h:

(MediaConstraintsImpl):

  • platform/chromium/support/WebMediaConstraints.cpp:

(WebKit::WebMediaConstraint::WebMediaConstraint):
(WebKit):
(WebKit::WebMediaConstraints::getMandatoryConstraints):
(WebKit::WebMediaConstraints::getOptionalConstraints):

  • platform/mediastream/MediaConstraints.h:

(WebCore::MediaConstraint::MediaConstraint):
(MediaConstraint):
(WebCore):
(MediaConstraints):

Tools:

Refactoring for the new WebMediaConstraints api.

  • DumpRenderTree/chromium/MockConstraints.cpp:

(MockConstraints::verify):

6:51 AM Changeset in webkit [129763] by schenney@chromium.org
  • 26 edits
    23 adds
    35 deletes in trunk/LayoutTests

Unreviewed Chromium expectations

Cleanup after a night of building. I think some of these failures are
due to premature rebaselining earlier.

  • platform/chromium-linux-x86/fast/forms/placeholder-position-expected.png: Removed.
  • platform/chromium-linux-x86/platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/date: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/3d-corners-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-twice-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/video-frame-size-change-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/webgl-loses-compositor-context-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/date: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/3d-corners-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-permanently-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-twice-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/render-surface-alpha-blending-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/video-frame-size-change-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/webgl-loses-compositor-context-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
  • platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win-xp/fast/text/line-breaks-expected.txt:
  • platform/chromium-win-xp/platform/chromium/compositing/3d-corners-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/huge-layer-rotated-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/layout-width-change-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-twice-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/tiny-layer-rotated-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/video-frame-size-change-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/compositing/webgl-loses-compositor-context-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/date: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/date: Added.
  • platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/js/eval-cross-window-expected.txt: Replaced.
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt: Replaced.
  • platform/chromium/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
  • platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
  • platform/chromium/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
6:45 AM Changeset in webkit [129762] by loislo@chromium.org
  • 8 edits in trunk/Source

Web Inspector: NMI: move visited and countObjectSize methods implementation into separate class.
​https://bugs.webkit.org/show_bug.cgi?id=97461

Reviewed by Yury Semikhatsky.

These methods and the data collected by them need to be used in the instrumentation code for other components.
As example when we are visiting bitmaps we need to visit platform specific objects.
These objects will be instrumented with help of component's own instrumentation code
but we have to keep the single set of visited objects and the map of counters.

Source/WebCore:

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):
(WebCore::collectDomTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::countObjectSize):
(WebCore):
(WebCore::MemoryInstrumentationClientImpl::visited):
(WebCore::MemoryInstrumentationImpl::selfSize):

  • inspector/MemoryInstrumentationImpl.h:

(WebCore::MemoryInstrumentationClientImpl::MemoryInstrumentationClientImpl):
(WebCore::MemoryInstrumentationClientImpl::selfSize):
(MemoryInstrumentationClientImpl):
(WebCore::MemoryInstrumentationClientImpl::visitedObjects):
(WebCore):
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::checkInstrumentedObjects):

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

(InstrumentationTestHelper):
(WebCore::InstrumentationTestHelper::InstrumentationTestHelper):
(WebCore::InstrumentationTestHelper::addRootObject):
(WebCore::InstrumentationTestHelper::reportedSizeForAllTypes):
(WebCore::InstrumentationTestHelper::visitedObjects):
(WebCore::InstrumentationTestHelper::totalSize):
(WebCore):
(WebCore::TEST):

Source/WTF:

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentationClient):
(WTF::MemoryInstrumentationClient::~MemoryInstrumentationClient):
(WTF):
(WTF::MemoryInstrumentation::MemoryInstrumentation):
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::countObjectSize):
(WTF::MemoryInstrumentation::visited):

6:44 AM Changeset in webkit [129761] by tommyw@google.com
  • 5 edits in trunk/Tools

MediaStream API: Rename MockConstraints::verify to verifyConstraints
​https://bugs.webkit.org/show_bug.cgi?id=97779

Reviewed by Csaba Osztrogonác.

The Mac OS X sdk has a macro called verify :/

  • DumpRenderTree/chromium/MockConstraints.cpp:

(MockConstraints::verifyConstraints):

  • DumpRenderTree/chromium/MockConstraints.h:

(MockConstraints):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::initialize):

  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp:

(WebUserMediaClientMock::requestUserMedia):

6:28 AM Changeset in webkit [129760] by Csaba Osztrogonác
  • 6 edits
    1 add in trunk/Source

[Qt] Enable the LLInt on Linux
​https://bugs.webkit.org/show_bug.cgi?id=95749

Patch by Csaba Osztrogonác <Csaba Osztrogonác>, Tor Arne Vestbø <​vestbo@webkit.org> on 2012-09-27
Reviewed by Simon Hausmann.

Source/JavaScriptCore:

  • DerivedSources.pri:
  • JavaScriptCore.pro:
  • LLIntOffsetsExtractor.pro: Added.
  • Target.pri:

Source/WTF:

  • wtf/Platform.h:
6:26 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:17 AM Changeset in webkit [129759] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMAKE] Remove unnecessary header files from CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=97771

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-27
Reviewed by Kentaro Hara.

Remove the header files which are added in the source file list.

  • CMakeLists.txt:
6:00 AM Changeset in webkit [129758] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Add callback functions for WKPageFindClient
​https://bugs.webkit.org/show_bug.cgi?id=97431

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-27
Reviewed by Laszlo Gombos.

Add didFailToFindString() and didCountStringMatches() for WKPageFindClient's callback functions.
The unit test for didFindString() and didFailToFindString() have beend added. The unit test for
didCountStringMatches() needs a API which wraps the WKPageCountStringMatches but it is not exists yet.
Additionaly, I changed the 'unsinged int' to 'unsigned' in the parameter type and removed unnecessary
type conversion.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_text_find):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_find_client.cpp:

(didFindString):
(didFailToFindString):
(didCountStringMatches):
(ewk_view_find_client_attach):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(onTextFound):
(TEST_F):

5:53 AM Changeset in webkit [129757] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, re-landing r129633 with the proper order of calls.
​https://bugs.webkit.org/show_bug.cgi?id=97659

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint):

5:21 AM Changeset in webkit [129756] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip now passing test.
​https://bugs.webkit.org/show_bug.cgi?id=71896.

  • platform/wk2/Skipped:
5:15 AM Changeset in webkit [129755] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r129633.
​http://trac.webkit.org/changeset/129633
​https://bugs.webkit.org/show_bug.cgi?id=97659

Breaks inspector overlay in non-composited mode

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint):

4:46 AM Changeset in webkit [129754] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEflFullscreen.css
​https://bugs.webkit.org/show_bug.cgi?id=97770

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Some CSS rules were duplicated between mediaControlsEfl.css and mediaControlsEflFullscreen.css
for no reason. This is an issue because it is easy to update mediaControlsEfl.css and forget
to make the same update to mediaControlsEflFullscreen.css. As a matter of fact, the timeline
display in fullscreen is currently off by a few pixels because its fullscreen CSS is not in
sync with what is in mediaControlsEfl.css.

We need to include in mediaControlsEflFullscreen.css only the CSS rules that are specific to
fullscreen mode, that is to say, the hiding of some controls.

No new tests, no behavior change for layout tests.

  • css/mediaControlsEflFullscreen.css:
4:39 AM Changeset in webkit [129753] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Open resource dialog should assume implicit wildcard in the beginning of the query.
​https://bugs.webkit.org/show_bug.cgi?id=97768

Reviewed by Pavel Feldman.

Source/WebCore:

Open resource dialog now assumes implicit wildcard in the beginning of the query.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):

LayoutTests:

  • inspector/filtered-item-selection-dialog-filtering-expected.txt:
  • inspector/filtered-item-selection-dialog-filtering.html:
4:22 AM Changeset in webkit [129752] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[EFL][CMAKE] Default theme files are outdated in PlatformEfl.cmake
​https://bugs.webkit.org/show_bug.cgi?id=97769

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Update Default theme files in PlatformEfl.cmake so that
changes to those files are properly picked up by CMake
when building incrementally.

  • PlatformEfl.cmake:
4:18 AM Changeset in webkit [129751] by pfeldman@chromium.org
  • 32 edits in trunk/Source/WebCore

Web Inspector: do not use InspectorInstrumentation::hasFrontends() check when collecting stacks
​https://bugs.webkit.org/show_bug.cgi?id=96730

Reviewed by Vsevolod Vlasov.

  • Introduced InspectorInstrumentation::console|timeline|runtime|canvasAgentEnabled
  • Using it all over the place instead of the hasFrontend (the latter is now only used once to guard hot path)
  • Introduced explicit "enabled" state of the console and runtime agents
  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::instrumentFunctionCall):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackForConsole):

  • bindings/js/ScriptCallStackFactory.h:

(WebCore):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallWith):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackCallback):

  • bindings/v8/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackForConsole):

  • bindings/v8/ScriptCallStackFactory.h:

(WebCore):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::callFunctionWithInstrumentation):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):

  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::callListenerFunction):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::SetTimeoutOrInterval):

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore):
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::disable):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::clearFrontend):
(WebCore::InspectorConsoleAgent::addConsoleMessage):

  • inspector/InspectorConsoleAgent.h:

(WebCore::InspectorConsoleAgent::enabled):
(InspectorConsoleAgent):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::canvasAgentEnabled):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::runtimeAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentEnabled):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::canvasAgentEnabled):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::runtimeAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentEnabled):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):

  • inspector/InspectorRuntimeAgent.h:

(WebCore::InspectorRuntimeAgent::enabled):
(WebCore::InspectorRuntimeAgent::enable):
(WebCore::InspectorRuntimeAgent::disable):
(InspectorRuntimeAgent):

  • inspector/PageRuntimeAgent.cpp:

(PageRuntimeAgentState):
(WebCore::PageRuntimeAgent::clearFrontend):
(WebCore::PageRuntimeAgent::restore):
(WebCore):
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::disable):
(WebCore::PageRuntimeAgent::didClearWindowObject):
(WebCore::PageRuntimeAgent::didCreateIsolatedContext):
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):

  • inspector/PageRuntimeAgent.h:

(PageRuntimeAgent):

  • inspector/WorkerRuntimeAgent.cpp:
  • inspector/WorkerRuntimeAgent.h:
  • inspector/front-end/RuntimeModel.js:

(WebInspector.RuntimeModel.prototype._didLoadCachedResources):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

4:12 AM Changeset in webkit [129750] by commit-queue@webkit.org
  • 17 edits in trunk/Source

Unify event handling of middle mouse button.
​https://bugs.webkit.org/show_bug.cgi?id=97690

Patch by Allan Sandfeld Jensen <​allan.jensen@digia.com> on 2012-09-27
Reviewed by Tony Chang.

Source/WebCore:

Implement a unified version of middle mouse button press that can be shared between
all the ports with X11 support.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handlePasteGlobalSelection):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

Remove port specific handling of middle mouse button press.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseUp):

Source/WebKit/gtk:

Remove port specific handling of middle mouse button press.

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::supportsGlobalSelection):

  • WebCoreSupport/EditorClientGtk.h:

(EditorClient):

  • webkit/webkitwebview.cpp:

(webkit_web_view_button_press_event):

Source/WebKit/qt:

Remove port specific handling of middle mouse button press.

  • Api/qwebpage.cpp:

(QWebPagePrivate::mouseReleaseEvent):

  • Api/qwebpage_p.h:

(QWebPagePrivate):

Source/WebKit2:

Remove Qt and GTK port specific handling of middle mouse button press.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit):

  • WebProcess/WebPage/qt/WebPageQt.cpp:
4:07 AM Changeset in webkit [129749] by tommyw@google.com
  • 21 edits
    2 copies in trunk

MediaStream API: Update getUserMedia to match the latest specification
​https://bugs.webkit.org/show_bug.cgi?id=97540

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebMediaConstraints.h:

(WebMediaConstraints):

Source/WebCore:

​http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

Existing tests expanded to cover the new change.

  • Modules/mediastream/MediaConstraintsImpl.cpp:

(WebCore::MediaConstraintsImpl::create):
(WebCore):

  • Modules/mediastream/MediaConstraintsImpl.h:

(MediaConstraintsImpl):

  • Modules/mediastream/NavigatorMediaStream.cpp:

(WebCore::NavigatorMediaStream::webkitGetUserMedia):

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::parseOptions):
(WebCore):
(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::audioConstraints):
(WebCore::UserMediaRequest::videoConstraints):

  • Modules/mediastream/UserMediaRequest.h:

(WebCore):
(UserMediaRequest):

  • platform/chromium/support/WebMediaConstraints.cpp:

(WebKit::WebMediaConstraints::WebMediaConstraints):
(WebKit):

Source/WebKit/chromium:

​http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

  • public/WebUserMediaRequest.h:

(WebKit):
(WebUserMediaRequest):

  • src/WebUserMediaRequest.cpp:

(WebKit::WebUserMediaRequest::audioConstraints):
(WebKit):
(WebKit::WebUserMediaRequest::videoConstraints):

Tools:

​http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

  • public/WebUserMediaRequest.h:

(WebKit):
(WebUserMediaRequest):

  • src/WebUserMediaRequest.cpp:

(WebKit::WebUserMediaRequest::audioConstraints):
(WebKit):
(WebKit::WebUserMediaRequest::videoConstraints):

LayoutTests:

Expanding tests to cover the new getUserMedia behaviour.

  • fast/mediastream/getusermedia-expected.txt:
  • fast/mediastream/getusermedia.html:
3:37 AM Changeset in webkit [129748] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector front-end closure compilation fix.

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):

3:05 AM Changeset in webkit [129747] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip a test again after r129712.

  • platform/qt/Skipped:
2:55 AM Changeset in webkit [129746] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

CollectingRules and QueryingRules modes of SelectorChecker miss some complex selectors with pseudo elements
​https://bugs.webkit.org/show_bug.cgi?id=78595

Reviewed by Antti Koivisto.

Source/WebCore:

Do not use the same dynamicPseudo reference when recursively invoking checkSelector() for non-SubSelector selectors.

Test: fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector): Use new NOPSEUDO dynamic pseudoId values
for each non-SubSelector selector further in the tag history.

LayoutTests:

The original issue mentioned failures on selectors like ".foo.moo > .bar:before", while things worked fine for ".foo > .bar:before".
The test checks 2 and 3 selector levels for all conventional non-SubSelector relations (Child, Descendant, DirectAdjacent, IndirectAdjacent),
each selector in all levels but the last one containing a SubSelector relation.

  • fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html: Added.
  • fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex-expected.txt: Added.
2:44 AM Changeset in webkit [129745] by commit-queue@webkit.org
  • 5 edits
    2 adds
    1 delete in trunk/Source

[EFL] No way to exit video fullscreen mode once entered
​https://bugs.webkit.org/show_bug.cgi?id=97631

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Show fullscreen media control in fullscreen so that
we now have a way to exit fullscreen mode.

No new tests, no behavior change for layout tests.

  • css/mediaControlsEflFullscreen.css:
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::emitMediaButtonSignal):
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):

Source/WebKit/efl:

Fix default theme so that we have 2 fullscreen buttons, one
to enter fullscreen mode and another to exit it.

New icon by Alexander Shalamov.

  • DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png: Added.
  • DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png: Added.
  • DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
  • DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreenbutton.png: Removed.
2:40 AM Changeset in webkit [129744] by vsevik@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed inspector test unskipped on qt, expectations updated.

  • http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
  • platform/qt/Skipped:
2:32 AM Changeset in webkit [129743] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[WK2] Injected bundle API implementation should use toWTFString()
​https://bugs.webkit.org/show_bug.cgi?id=97766

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.

Injected bundle API implementation should call toWTFString() rather than convert
WKStringRef and WKURLRef to their impls and then call string() method directly.
The rational for that are both safety (toWTFString checks the given pointer) and
code readability.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostMessage):
(WKBundlePostSynchronousMessage):
(WKBundleOverrideBoolPreferenceForTestRunner):
(WKBundleAddOriginAccessWhitelistEntry):
(WKBundleRemoveOriginAccessWhitelistEntry):
(WKBundleClearApplicationCacheForOrigin):
(WKBundleGetAppCacheUsageForOrigin):
(WKBundleSetApplicationCacheOriginQuota):
(WKBundleResetApplicationCacheOriginQuota):
(WKBundlePageNumberForElementById):
(WKBundleSetUserStyleSheetLocation):
(WKBundleSetWebNotificationPermission):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFramePauseAnimationOnElementWithId):
(WKBundleFramePauseTransitionOnElementWithId):
(WKBundleFrameAllowsFollowingLink):
(WKBundleFrameCopySuggestedFilenameForResourceWithURL):
(WKBundleFrameCopyMIMETypeForResourceWithURL):
(WKBundleFrameSetTextDirection):

  • WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:

(WKBundleInspectorEvaluateScriptForTest):

  • WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp:

(WKBundleIntentCreate):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageExecuteEditingCommand):
(WKBundlePageIsEditingCommandEnabled):
(WKBundlePageHasLocalDataForURL):
(WKBundlePageFindString):
(WKBundlePageSetComposition):
(WKBundlePageConfirmCompositionWithText):
(WKBundlePageCanShowMIMEType):

2:28 AM WebKit Team edited by abecsi@webkit.org
Update affiliation of team members (diff)
2:24 AM Changeset in webkit [129742] by mario@webkit.org
  • 8 edits in trunk/Source/WebKit2

[WK2] IconDatabase: Add a way to notify when icon data is available
​https://bugs.webkit.org/show_bug.cgi?id=63945

Reviewed by Anders Carlsson.

Provide new API to notify the API layer when icon data is
available, and use it from the implementation layer when needed,
that is, either when the data has been loaded from the network or
imported from disk.

Added new callback to WKIconDatabaseClient API.

  • UIProcess/API/C/WKIconDatabase.h: Added new callback.
  • UIProcess/WebIconDatabaseClient.cpp:

(WebKit::WebIconDatabaseClient::iconDataReadyForPageURL):
Implementation of the new callback at this level in the UI
process, by using its implementation in the API layer if present.

  • UIProcess/WebIconDatabaseClient.h:

(WebIconDatabaseClient): Added new callback.

Implemented WebFrameLoaderClient::dispatchDidReceiveIcon, so we
get notified in the UI process when loading a new icon.

  • UIProcess/WebIconDatabase.messages.in: Added new message to

notify the UI process: DidReceiveIconForPageURL.

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::notifyIconDataReadyForPageURL): New
private helper function to notify the API layer both that new icon
data is ready and that the icon has changed.
(WebKit::WebIconDatabase::didReceiveIconForPageURL):
Implementation of the new message added, by calling
notifyIconDataReadyForPageURL() to notify the API layer.
(WebKit::WebIconDatabase::didImportIconDataForPageURL): Call
notifyIconDataReadyForPageURL() from here as well.

  • UIProcess/WebIconDatabase.h: Added new prototypes.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveIcon): Send a
message to the UI process telling a new icon has been received.

1:57 AM Changeset in webkit [129741] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip fast/dom/Geolocation to make LayoutTests faster
​https://bugs.webkit.org/show_bug.cgi?id=97765

Unreviewed EFL gardening.

Skip fast/dom/Geolocation for EFL port instead of marking
them with "Failure" expectation. This makes running
LayoutTests much faster.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27

  • platform/efl/TestExpectations:
1:36 AM Changeset in webkit [129740] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip http/tests/security/xss-eval.html again.

Fix was re-landed in r129712.

  • platform/efl/TestExpectations:
1:22 AM Changeset in webkit [129739] by yosin@chromium.org
  • 3 edits in trunk/Source/WebCore

[Forms] BaseMultipleFieldsDateAndTimeInputType class should inherit DateTimeEditElement::EditControlOwner rather than containing
​https://bugs.webkit.org/show_bug.cgi?id=97756

Reviewed by Kent Tamura.

This patch changes class hierarchy of BaseMultipleFieldsDateAndTimeInputType
to inherit from DateTimeEditElement::EditControlOwner rather than
containing an instance of DateTimeEditElement::EditControlOwner for
saving memory, although one pointer, and one memory fetch on using
HTMLInputElement.

Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_MULTIPLE_FIELDS_UI.

No new tests. This patch doesn't change behavior.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp: DateTimeEditElement::EditControlOwner::DateTimeformatDateTimeFieldsState was removed. We no longer need to redirection. Each date/time input type classe implements it.

(WebCore::BaseMultipleFieldsDateAndTimeInputType::didBlurFromControl): Moved from DateTimeEditControlOwnerImpl and removed reference of m_dateTimeInputType.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::didFocusOnControl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): Changed to pass BaseMultipleFieldsDateAndTimeInputType instead of DateTimeEditControlOwnerImpl.

  • html/BaseMultipleFieldsDateAndTimeInputType.h: Changed base class to have DateTImeEditElement::EditControlOwner.

(BaseMultipleFieldsDateAndTimeInputType): Removed DateTimeEditControlOwnerImpl class and member variable m_dateTimeEditControlOwner.

1:17 AM Changeset in webkit [129738] by keishi@webkit.org
  • 13 edits
    3 adds in trunk

SuggestionPicker should support rtl
​https://bugs.webkit.org/show_bug.cgi?id=97555

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html: Added tests for Arabic with datalist.

Source/WebCore:

Add support for rtl to SuggestionPicker. We add another parameter
because text direction for the calendar picker should depend on the UI
language but the text direction for suggestion picker should depend on
the input element style.

Test: platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype._layout):

  • Resources/pagepopups/pickerCommon.css:

(.rtl): Added so we can change styles when in rtl mode.

  • Resources/pagepopups/suggestionPicker.css:

(.suggestion-list-entry .label):
(.rtl .suggestion-list-entry .label): Change float direction to left.

  • Resources/pagepopups/suggestionPicker.js:

(SuggestionPicker.prototype._layout):

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup): Set isAnchorElementRTL to true if the input element is rtl.

  • platform/DateTimeChooser.h:

(DateTimeChooserParameters): Added isAnchorElementRTL.

Source/WebKit/chromium:

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument):

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.txt: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html: Added.
1:13 AM Changeset in webkit [129737] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Follow-up to r129723 to once more allow parsing of scoped names in IDL files.

Patch by Takashi Sakamoto <​tasak@google.com> on 2012-09-27
Reviewed by Kentaro Hara.

This functionality was supported by the old IDL parser but was lost in the rewrite of the parser
in r129723. It is being reinstated to unbreak clients that currently depend on it, but will likely
be removed in the future once those clients have a chance to adopt an approach that more closely
follows the WebIDL syntax.

  • bindings/scripts/IDLParser.pm:

(parseDefinition):
(parseInheritance):
(parseImplementsStatement):
(parseExtendedAttribute):
(parseExtendedAttribute2):
(parseExtendedAttributeRest2):
(parseExtendedAttributeRest3):
(parseScopedNameListNoComma):
(parseNonAnyType):
(parseExceptionList):
(parseDefinitionOld):
(parseScopedName):
(parseAbsoluteScopedName):
(parseRelativeScopedName):
(parseScopedNameParts):
(parseScopedNameList):
(parseScopedNames):

1:12 AM Changeset in webkit [129736] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[CMake] Fix build with static JavaScriptCore library

  • shell/CMakeLists.txt: Define STATICALLY_LINKED_WITH_JavaScriptCore if

JavaScriptCore_LIBRARY_TYPE is set to STATIC.

1:11 AM Changeset in webkit [129735] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] fast/layers/video-layer.html needs rebaselining after r129687
​https://bugs.webkit.org/show_bug.cgi?id=97764

Unreviewed EFL gardening.

Rebaseline fast/layers/video-layer.html due to r129687. The volume
button is no longer shown for that test.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27

  • platform/efl/fast/layers/video-layer-expected.png:
  • platform/efl/fast/layers/video-layer-expected.txt:
12:57 AM Changeset in webkit [129734] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: expose debug memory instrumentation debug data through the protocol
​https://bugs.webkit.org/show_bug.cgi?id=97683

Reviewed by Pavel Feldman.

Memory.getProcessMemoryDistribution command now returns number of instrumented
objects that were found and the number of the objects that were counted by
the instrumentation but were not actually allocated by the memory allocator.
These numbers are only added to the response if embedder provides access to the
set of all live heap objects. These numbers are intended to be used for testing
memory instrumentation.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::collectDomTreeInfo):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::checkCountedObject):

  • inspector/MemoryInstrumentationImpl.h:

(WebCore::MemoryInstrumentationImpl::checkInstrumentedObjects):
(WebCore::MemoryInstrumentationImpl::totalCountedObjects):
(WebCore::MemoryInstrumentationImpl::totalObjectsNotInAllocatedSet):
(MemoryInstrumentationImpl):

12:53 AM Changeset in webkit [129733] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

[CSSRegions]Refactor RenderFlowThread::contentLogical(Width/Height/Left)OfFirstRegion
​https://bugs.webkit.org/show_bug.cgi?id=97577

Reviewed by Andreas Kling.

RenderFlowThread methods contentLogicalWidthOfFirstRegion, contentLogicalHeightOfFirstRegion, contentLogicalLeftOfFirstRegion
were using code to get the first valid region associated with the flow. We can use RenderFlowThread::firstRegion() method instead.

No new tests as this is just refactoring of existing code, the change is covered by existing regions tests.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
(WebCore):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore::RenderFlowThread::objectInFlowRegion):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):

12:30 AM Changeset in webkit [129732] by Patrick Gansterer
  • 2 edits in trunk

[WINCE] Enable JIT by default

  • Source/cmake/OptionsWinCE.cmake:
12:25 AM Changeset in webkit [129731] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for !USE(ICU_UNICODE) after r129662.

Convert LChar to UChar so we can call the existing function until the
other TextBreakIterator implemenations provide an overload for LChar.

  • platform/text/TextBreakIterator.cpp:

(WebCore):
(WebCore::acquireLineBreakIterator):

12:13 AM DOMInJavaScript edited by abarth@webkit.org
(diff)
12:13 AM DOMInJavaScript edited by abarth@webkit.org
(diff)
12:02 AM DOMInJavaScript edited by abarth@webkit.org
(diff)
12:02 AM DOMInJavaScript edited by abarth@webkit.org
(diff)
12:01 AM Changeset in webkit [129730] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[BlackBerry] Allow denormal floats in ARM VFP
​https://bugs.webkit.org/show_bug.cgi?id=97008

Patch by Cosmin Truta <​ctruta@rim.com> on 2012-09-26
Reviewed by Filip Pizlo.
Reviewed internally by Yong Li.

Cleared the Flush-to-Zero flag in the ARM FPSCR register on QNX.

  • wtf/ThreadingPthreads.cpp:

(WTF::enableIEEE754Denormal): Added.
(WTF::initializeThreading):
(WTF::initializeCurrentThreadInternal):

Sep 26, 2012:

11:46 PM DOMInJavaScript edited by abarth@webkit.org
(diff)
11:43 PM Changeset in webkit [129729] by yosin@chromium.org
  • 7 edits in trunk/Source/WebCore

[Forms] Move multiple fields related functions to BaseDateAndTimeInputType from TimeInputType
​https://bugs.webkit.org/show_bug.cgi?id=97521

Reviewed by Kent Tamura.

This patch introduces new class BaseMultipleFieldsDateAndTimeInputType
for sharing code among multiple fields date/time input UI.

Member functions in BaseMultipleFieldsDateAndTimeInputType are moved
from TimeInputType. BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
were copied from TimeInputType.{cpp,h} by r129721.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_MULTIPLE_FIELDS_UI.

No new tests. This patch doesn't change behavior.

  • WebCore.gypi: Changed to have html/BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType): Exposed setMillisecondToDateComponents as protected for BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState().

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::DateTimeEditControlOwnerImpl): Moved from TimeInputType::DateTimeEditControlOwnerImpl.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::~DateTimeEditControlOwnerImpl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::didBlurFromControl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::didFocusOnControl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::formatDateTimeFieldsState): Moved from TimeInputType::DateTimeEditControlOwnerImpl and changed to call formatDateTimeFieldsState() in BaseMultipleFieldsDateAndTimeInputTypeInputType class.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::hasCustomFocusLogic): Moved from TimeInputType.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerDisabled): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerReadOnly): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::blur): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createRenderer): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::focus): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::forwardEvent): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleKeydownEvent): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isKeyboardFocusable): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isMouseFocusable): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::minOrMaxAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::readonlyAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isTextField): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::saveFormControlState): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::setValue): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldUseInputMethod): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::stepAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Moved from TimeInputType and changed to call setupLayoutParameters() to set date/time format by each input type.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Added.
(DateTimeEditControlOwnerImpl): Moved from TimeInputType.

  • html/TimeInputType.cpp: Moved multiple fields UI related functions to BaseMultipleFieldsDateAndTimeInputType.

(WebCore::TimeInputType::TimeInputType): Changed base class name to BaseTimeInput.
(WebCore::TimeInputType::formatDateTimeFieldsState): Moved from TimeINput::DateTImeEditControlOwnerImpl class.
(WebCore::TimeInputType::setupLayoutParameters): Added for set time format.

  • html/TimeInputType.h:

(TimeInputType): Chaned base class to BaseTimeInput which is alias of BaseDateAndTimeInputType or BaseMultipleFieldsDateAndTimeInputType.

11:36 PM DOMInJavaScript edited by abarth@webkit.org
(diff)
11:30 PM DOMInJavaScript edited by abarth@webkit.org
(diff)
11:22 PM DOMInJavaScript edited by abarth@webkit.org
(diff)
10:52 PM DOMInJavaScript edited by abarth@webkit.org
(diff)
10:48 PM DOMInJavaScript created by abarth@webkit.org
10:47 PM Changeset in webkit [129728] by yosin@chromium.org
  • 6 edits in trunk/Source

[Forms] Adding localization texts for multiple fields date/time input UI
​https://bugs.webkit.org/show_bug.cgi?id=97633

Reviewed by Kent Tamura.

Source/Platform:

This patch adds localized string enum fields for getting localized
strings used in multiple fields date/time input UI.

  • chromium/public/WebLocalizedString.h: Added PlaceholderForDayOfMonthField,

PlaceholderForMonthField, PlaceholderForYearField, MonthFormatInLDML,
and WeekFormatInLDML.

Source/WebCore:

This patch adds function declarations for getting localized strings
used in multiple fields date/time input UI inside ENABLE_INPUT_MULTIPLE_FIELDS_UI.

New functions are:

  • placeholderForDayOfMonthField()

It returns localized placeholder text, e.g. "dd", for date field
used in multiple fields "date", "datetime", and "datetime-local"
input UI instead "--".

  • placeholderForfMonthField()

It returns localized placeholder text, e.g. "mm", for month field
used in multiple fields "date", "datetime", and "datetime-local"
input UI instead "--".

  • placeholderForYearField()

It returns localized placeholder text, e.g. "yyyy", for year field
used in multiple fields "date", "datetime", and "datetime-local"
input UI instead "----".

  • monthFormatInLDML()

It returns month and year format in LDML, Unicode technical
standard 35, Locale Data Markup Language, e.g. "MM-yyyyy" for
"month" input type.

  • monthFormatInLDML()

It returns week and year format in LDML, e.g. "WW-yyyyy" for
"week" input type.

No new tests. This patch doesn't change behavior.

  • platform/LocalizedStrings.h:

(WebCore): Added declarations of placeholderForDayOfMonthField(), placeholderForMonthField(),
placeholderForYearField(), monthFormatInLDML() and weekFormatInLDML().

Source/WebKit/chromium:

This patch adds functions for getting localized strings used in
multiple fields date/time input UI inside ENABLE_INPUT_MULTIPLE_FIELDS_UI.

These functions will be used by DateInputType, DateTimeInputType,
DateTimeLocalInputType, MonthInputTypee, and WeekInputType.

  • src/LocalizedStrings.cpp:

(WebCore::placeholderForDayOfMonthField): Added.
(WebCore::placeholderForMonthField): Added.
(WebCore::placeholderForYearField): Added.
(WebCore::monthFormatInLDML): Added.
(WebCore::weekFormatInLDML): Added.

10:45 PM Changeset in webkit [129727] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Shaders] Remove an unused member variable m_program in FECustomFilter.h
​https://bugs.webkit.org/show_bug.cgi?id=97755

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-09-26
Reviewed by Kentaro Hara.

No new tests. This patch doesn't change behavior.

  • platform/graphics/filters/FECustomFilter.h:

(WebCore):

9:27 PM Changeset in webkit [129726] by keishi@webkit.org
  • 2 edits
    11 adds in trunk/LayoutTests

Add tests for datalist UI for input type date
​https://bugs.webkit.org/show_bug.cgi?id=97551

Reviewed by Kent Tamura.

Adding tests for datalist UI for input type date.

  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium/TestExpectations: Mark as image failure for date-suggestion-picker-appearance.html
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.txt: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.txt: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-key-operations.html: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations-expected.txt: Added.
  • platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html: Added.
9:13 PM Changeset in webkit [129725] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Update my e-mail address.

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-26

  • Scripts/webkitpy/common/config/committers.py:
8:15 PM Changeset in webkit [129724] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Unreviewed build fix after 129707.

  • webkit/webkitwebview.cpp:

(webkit_web_view_forward_context_menu_event):

7:11 PM Changeset in webkit [129723] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

Move IDL extended attributes to the location specified in WebIDL
​https://bugs.webkit.org/show_bug.cgi?id=26398

Patch by Takashi Sakamoto <​tasak@google.com> on 2012-08-09
Reviewed by Kentaro Hara.

Recreated a new IDLParser based on the WebIDL spec:
​http://dev.w3.org/2006/webapi/WebIDL/

Firstly merges two grammars (editors draft and WebKit current IDL) and
generates IDL parser by using python script. The generated parser is
modified to generate the same outputs as the previous IDLParser.pm.
The new IDLParser.pm can parse both WebIDL grammar.

No new tests. Tested by comparing with sources generated by
the previous IDLParser.pm.

  • bindings/scripts/IDLParser.pm:

(new):
(assertTokenValue):
(assertTokenType):
(assertUnexpectedToken):
(Parse):
A method to start parsing a IDL file. Arguments and return values are
the same as the previous IDLParser.pm's Parse method.
(nextToken):
Implemented to see a next token, because of LL(1).
(getToken):
Returns current token, and update next and current token.
(getTokenInternal):
According to the regular expressions defined in WebIDL spec, extracts
one new token from a text string. The order of the regular expressions
to be tested is important, i.e. "0." should be considered as a float
token, but if firstly checks the integer regular expression, "0." is
considered as "0" and ".".
(parseDefinition):
(parseCallbackOrInterface):
(parseCallbackRestOrInterface):
(parseInterface):
(parsePartial):
(parsePartialDefinition):
(parsePartialInterface):
(parseInterfaceMember):
(parseDictionary):
(parseDictionaryMember):
(parsePartialDictionary):
(parseDefaultValue):
(parseException):
(parseExceptionMembers):
(parseEnum):
(parseEnumValueList):
(parseCallbackRest):
(parseTypedef):
(parseImplementsStatement):
(parseConst):
(parseConstValue):
(parseBooleanLiteral):
(parseFloatLiteral):
(parseAttributeOrOperationOrIterator):
(parseSerializer):
(parseSerializationPattern):
(parseQualifier):
(parseAttributeOrOperationRest):
(parseAttribute):
(parseAttributeRest):
(parseOperationOrIterator):
(parseSpecialOperation):
(parseSpecial):
(parseOperationOrIteratorRest):
(parseIteratorRest):
(parseOptionalIteratorInterfaceOrObject):
(parseOperationRest):
(parseArguments):
(parseArgument):
(parseOptionalOrRequiredArgument):
(parseArgumentName):
(parseExceptionMember):
(parseExceptionField):
(parseExtendedAttributeList):
(parseExtendedAttribute):
(parseExtendedAttributeRest2):
(parseArgumentNameKeyword):
(parseType):
(parseSingleType):
(parseUnionType):
(parseNonAnyType):
(parsePrimitiveType):
(parseUnrestrictedFloatType):
(parseFloatType):
(parseUnsignedIntegerType):
(parseNull):
(parseGet):
(parseInheritsGetter):
(parseSetGetRaises):
(parseGetRaises2):
(parseSetRaises):
(parseSetRaises3):
(parseDefinitionOld):
(parseModule):
(parseInterfaceOld):
(parseInterfaceMemberOld):
(parseDictionaryOld):
(parseDictionaryMemberOld):
(parseExceptionOld):
(parseEnumOld):
(parseAttributeOrOperationOrIteratorOld):
(parseAttributeOrOperationRestOld):
(parseAttributeOld):
(parseIn):
(parseOptionalSemicolon):
(applyMemberList):
(applyExtendedAttributeList):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::longAttr):
(WebDOMTestObj::setLongAttr):
(WebDOMTestObj::voidMethodWithArgs):
(WebDOMTestObj::longMethod):
(WebDOMTestObj::longMethodWithArgs):
(WebDOMTestObj::objMethodWithArgs):
(WebDOMTestObj::convert1):
(WebDOMTestObj::convert2):
(WebDOMTestObj::convert3):
(WebDOMTestObj::convert4):
(WebDOMTestObj::convert5):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_void_method_with_args):
(webkit_dom_test_obj_long_method):
(webkit_dom_test_obj_long_method_with_args):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_convert1):
(webkit_dom_test_obj_convert2):
(webkit_dom_test_obj_convert3):
(webkit_dom_test_obj_convert4):
(webkit_dom_test_obj_convert5):
(webkit_dom_test_obj_get_long_attr):
(webkit_dom_test_obj_set_long_attr):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjLongAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethod):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj longAttr]):
(-[DOMTestObj setLongAttr:]):
(-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj longMethod]):
(-[DOMTestObj longMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
(-[DOMTestObj convert1:]):
(-[DOMTestObj convert2:]):
(-[DOMTestObj convert3:]):
(-[DOMTestObj convert4:]):
(-[DOMTestObj convert5:]):

  • bindings/scripts/test/TestObj.idl:

Removed the line which has only "JSC, V8".
Added argument to convert1, ... convert5.

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::longAttrAttrGetter):
(WebCore::TestObjV8Internal::longAttrAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert3Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

  • Modules/webaudio/AudioBufferSourceNode.idl:

As only restricted extended attribute syntax is supported, modify the
idl from [...] [...] to [..., ...].

6:43 PM Changeset in webkit [129722] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix XPCServices symlink to not be to an absolute path
in the build products directory.

Reviewed by Dan Bernstein.

  • WebKit2.xcodeproj/project.pbxproj:
6:25 PM Changeset in webkit [129721] by yosin@chromium.org
  • 1 edit
    2 copies in trunk/Source/WebCore

[Forms] Copy TimeInputType.{cpp,h} to BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=97649

Reviewed by Kent Tamura.

This patch copies TimeInput.{cpp,h} to BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
for sharing code related to multiple fields date/time input UI among date/time related
input types, such as "date", "datetime", "month", "time" and "week".

No new tests. This patch doesn't change behavior.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp: Copied from Source/WebCore/html/TimeInputType.cpp.
  • html/BaseMultipleFieldsDateAndTimeInputType.h: Copied from Source/WebCore/html/TimeInputType.h.
6:20 PM Changeset in webkit [129720] by kenneth@webkit.org
  • 2 edits
    2 deletes in trunk/Source/WebCore

[Texmap][EFL] Accelerated compositing support using TextureMapper on EFL port
​https://bugs.webkit.org/show_bug.cgi?id=73111

Reviewed by Gyuyoung Kim.

Remove unneeded files

  • PlatformEfl.cmake: Do not add the files any more.
  • platform/graphics/efl/GraphicsLayerEfl.cpp: Removed.
  • platform/graphics/efl/GraphicsLayerEfl.h: Removed.
6:18 PM Changeset in webkit [129719] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Proxy the global this in JSC
​https://bugs.webkit.org/show_bug.cgi?id=97734

Reviewed by Filip Pizlo.

Eeep – fix a bug - was leaving the global this proxy's structure's globalObject as 0,
and setting the proxy's prototype as the global object, rather than its prototype.

  • jsc.cpp:

(GlobalObject::create):

  • runtime/JSProxy.h:

(JSC::JSProxy::createStructure):

6:04 PM Changeset in webkit [129718] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Speculative Windows build fix.

6:02 PM Changeset in webkit [129717] by dpranke@chromium.org
  • 2 edits in trunk/Tools

modify old-run-webkit-tests to support TestExpectations files a little
​https://bugs.webkit.org/show_bug.cgi?id=97276

Reviewed by Daniel Bates.

This patch adds minimal support to old-run-webkit-tests so that
it can read a TestExpectations file and skip the tests listed
there. It will skip *all* tests, regardless of the expectation
(even if the test is listed as [ Pass ]), and it will only look
at the TestExpectations file if there isn't a Skipped file next
to it.

This will allow us to switch to using just using
TestExpectations files without making old-run-webkit-tests
totally useless.

  • Scripts/old-run-webkit-tests:

(readSkippedFiles):
(processSkippedFileEntry): Added.
(startsWith): Added.

6:01 PM Changeset in webkit [129716] by dgrogan@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed rebaselining.

dont-commit-on-blocked.html isn't run in DRT, only in chromium's
content_browsertests.

  • storage/indexeddb/dont-commit-on-blocked-expected.txt:
5:23 PM Changeset in webkit [129715] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, 32-bit build fix.

  • llint/LowLevelInterpreter32_64.asm:
5:09 PM Changeset in webkit [129714] by dpranke@chromium.org
  • 3 edits in trunk/Tools

The style bot spams about skia_test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=97699

Reviewed by Adam Barth.

Remove the warning about a missing skia_test_expectations.txt
file for now. There are some situations where it would be
helpful to get this warning as it might indicate that the user
is going to get results different than what they're expecting,
but at the moment it looks difficult if not impossible to get
those warnings and not also get warnings that we don't care
about, so the noise is outweighing the value of the signal.

This at least will stop the false negatives we're getting on the
style bots. If it turns out people do need the warning we can
add it back in in some other more conditional way.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.expectations_files):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_expectations):
(_assert_command):

5:04 PM Changeset in webkit [129713] by fpizlo@apple.com
  • 15 edits
    2 adds in trunk/Source/JavaScriptCore

jneq_ptr shouldn't have a pointer
​https://bugs.webkit.org/show_bug.cgi?id=97739

Reviewed by Oliver Hunt.

Slamming pointers directly into bytecode is sometimes cool, but in this case it's
unwieldy and confusing. Switched the instruction to use an enum instead. This has
zero effect on code gen behavior in the JITs. In the LLInt, there is now more
indirection, but that doesn't affect benchmarks.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/Instruction.h:

(JSC::Instruction::Instruction):
(Instruction):

  • bytecode/SpecialPointer.cpp: Added.

(JSC):
(JSC::actualPointerFor):

  • bytecode/SpecialPointer.h: Added.

(JSC):
(JSC::pointerIsFunction):
(JSC::pointerIsCell):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_jneq_ptr):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_jneq_ptr):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::actualPointerFor):

4:25 PM Changeset in webkit [129712] by barraclough@apple.com
  • 11 edits in trunk

REGRESSION (r129456): http/tests/security/xss-eval.html is failing on JSC platforms
​https://bugs.webkit.org/show_bug.cgi?id=97529

Reviewed by Filip Pizlo.

A recent patch changed JSC's EvalError behaviour; bring this more into line with other browsers.

Source/JavaScriptCore:

JSC currently throws an EvalError if you try to call eval with a this object that doesn't
match the given eval function. This does not match other browsers, which generally just
ignore the this value that was passed, and eval the string in the eval function's environment.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • Remove EvalError, ignore passed this value.

LayoutTests:

  • fast/js/eval-cross-window-expected.txt:
  • fast/js/eval-cross-window.html:
    • Changed not to expect EvalErrors (this matches other browsers), and modified testThis to check that the this object is always set to the global object.
  • http/tests/security/resources/xss-eval2.html:
  • http/tests/security/resources/xss-eval3.html:
  • http/tests/security/xss-eval-expected.txt:
  • http/tests/security/xss-eval.html:
    • Updated. Access via the global environment is not a security risk, since the eval is accessing it's own document's informantion. Access via the shell attempts to access the navigated pages document, tripping an access check & throwing a TypeError.
3:50 PM Changeset in webkit [129711] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Proxy the global this in JSC
​https://bugs.webkit.org/show_bug.cgi?id=97734

Reviewed by Oliver Hunt.

Having jsc diverge from WebCore here is not beneficial; it potentially masks bugs and/or performance
problems from command line testing.

  • jsc.cpp:

(GlobalObject::create):

  • Create a this value proxy for the global object.
  • runtime/JSGlobalObject.h:

(JSGlobalObject):

  • Make setGlobalThis protected.
  • runtime/JSProxy.h:

(JSC::JSProxy::create):
(JSC::JSProxy::target):
(JSC::JSProxy::finishCreation):
(JSProxy):

  • Allow proxy target to be a JSObject, add target to create method.
3:01 PM Changeset in webkit [129710] by eae@chromium.org
  • 115 edits
    2 adds
    21 deletes in trunk/LayoutTests

Unreviewed chromium windows rebaseline for r129656.

  • platform/chromium-linux-x86/svg/wicd: Removed.
  • platform/chromium-linux/css1/formatting_model/inline_elements-expected.txt: Removed.
  • platform/chromium-linux/fast/borders/bidi-009a-expected.txt: Removed.
  • platform/chromium-linux/fast/borders/bidi-012-expected.txt: Removed.
  • platform/chromium-linux/fast/css/bidi-override-in-anonymous-block-expected.txt: Removed.
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.txt: Removed.
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.txt: Removed.
  • platform/chromium-linux/fast/flexbox/flex-hang-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/007-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-marker-style-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.txt: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.txt: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/css1/formatting_model/inline_elements-expected.txt:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-win/fast/borders/bidi-009a-expected.txt:
  • platform/chromium-win/fast/borders/bidi-012-expected.txt:
  • platform/chromium-win/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-win/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-win/fast/css/hsl-color-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-win/fast/flexbox/flex-hang-expected.txt: Removed.
  • platform/chromium-win/fast/forms/007-expected.txt:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-win/fast/html/details-add-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-marker-style-expected.png:
  • platform/chromium-win/fast/html/details-marker-style-expected.txt:
  • platform/chromium-win/fast/html/details-nested-1-expected.png:
  • platform/chromium-win/fast/html/details-nested-2-expected.png:
  • platform/chromium-win/fast/html/details-no-summary1-expected.png:
  • platform/chromium-win/fast/html/details-no-summary2-expected.png:
  • platform/chromium-win/fast/html/details-no-summary3-expected.png:
  • platform/chromium-win/fast/html/details-no-summary4-expected.png:
  • platform/chromium-win/fast/html/details-open-javascript-expected.png:
  • platform/chromium-win/fast/html/details-open1-expected.png:
  • platform/chromium-win/fast/html/details-open2-expected.png:
  • platform/chromium-win/fast/html/details-open3-expected.png:
  • platform/chromium-win/fast/html/details-open4-expected.png:
  • platform/chromium-win/fast/html/details-open5-expected.png:
  • platform/chromium-win/fast/html/details-open6-expected.png:
  • platform/chromium-win/fast/html/details-position-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-win/fast/html/details-replace-text-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-win/fast/text/line-breaks-expected.txt:
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-win/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/chromium-win/svg/custom/viewBox-hit-expected.png:
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/efl/svg/as-border-image/svg-as-border-image-2-expected.txt: Removed.
  • platform/efl/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
  • platform/gtk/svg/as-border-image/svg-as-border-image-2-expected.txt: Removed.
  • platform/gtk/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
  • svg/as-border-image/svg-as-border-image-2-expected.txt: Added.
  • svg/as-border-image/svg-as-border-image-expected.txt: Added.
2:43 PM Changeset in webkit [129709] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Stop using kCFURLHFSPathStyle
​https://bugs.webkit.org/show_bug.cgi?id=97731
<rdar://problem/12378980>

Reviewed by Tim Horton.

Stop passing Carbon style paths to the plug-in. Both WebKitPluginHost, WebKit2 and Firefox
pass POSIX style paths which makes more sense.

  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::destroyStream):

2:36 PM Changeset in webkit [129708] by Dave Barton
  • 1 edit in trunk/Source/WebCore/rendering/RenderTableCell.cpp

Compile fix for Windows.

2:13 PM Changeset in webkit [129707] by Simon Fraser
  • 9 edits in trunk/Source/WebCore

Rename Page::frameCount() to subframeCount(), and related
​https://bugs.webkit.org/show_bug.cgi?id=97729

Reviewed by Alexey Proskuryakov.

Rename member functions and variables on Page that refer to
"frame count" to use "subframe count", since the main frame is
not included in the count.

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::open):

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAllowed):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::closeAndRemoveChild):

  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::disconnectOwnerElement):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::checkSubframeCountConsistency):

  • page/Page.h:

(WebCore::Page::incrementSubframeCount):
(WebCore::Page::decrementSubframeCount):
(WebCore::Page::subframeCount):
(WebCore::Page::checkSubframeCountConsistency):

2:11 PM Changeset in webkit [129706] by jpetsovits@rim.com
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove blitContents() in favor of blitVisibleContents().
​https://bugs.webkit.org/show_bug.cgi?id=97718

Reviewed by Antonio Gomes.

After the last calling sites of blitContents() have
been removed or reworked, the actual method itself
can now retire. All blits now go through
blitVisibleContents(). The knowledge that we always
blit the full visible surface can facilitate further
optimizations; we will get to that in time.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):

  • Api/BackingStore.h:
  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):

2:10 PM Changeset in webkit [129705] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop using CFURLCreateDataAndPropertiesFromResource
​https://bugs.webkit.org/show_bug.cgi?id=97728
<rdar://problem/12379035>

Reviewed by Tim Horton.

Replace a call to CFURLCreateDataAndPropertiesFromResource with -[NSData initWithContentsOfURL:]
and add the necessary casts to make the compiler happy.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::contentsOfPropertyListAtURL):

2:03 PM Changeset in webkit [129704] by reed@google.com
  • 2 edits in trunk/LayoutTests

update expectations for feTile.svg
​https://bugs.webkit.org/show_bug.cgi?id=97727

Reviewed by NOBODY

Expectations change only.
Skia change affected feTile.svg results (crbug 152503)

  • platform/chromium/TestExpectations:
1:57 PM Changeset in webkit [129703] by davidbarr@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Upgrade myself from contributor to committer.

  • Scripts/webkitpy/common/config/committers.py:
1:57 PM Changeset in webkit [129702] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Speculative Windows build fix.

1:54 PM Changeset in webkit [129701] by ap@apple.com
  • 6 edits in trunk/Source/WebKit2

[WK2] Update WebPageProxy::reattachToWebProcess() for multi-web process mode
​https://bugs.webkit.org/show_bug.cgi?id=97726

Reviewed by Anders Carlsson.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureSharedWebProcess): createNewWebProcess() now takes care of adding the new process to m_processes. (WebKit::WebContext::createNewWebProcess): Every time we call this function, we need to add the result to m_processes. Better do it internally to avoid mistakes. (WebKit::WebContext::warmInitialProcess): Updated for the above. (WebKit::WebContext::createWebPage): Ditto. (WebKit::WebContext::relaunchProcessIfNecessary): This function makes no sense in multi-web process mode. Assert that we didnt get here accidentally.
  • UIProcess/WebContext.h: (WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary): Only call relaunchProcessIfNecessary in single process mode. The functionality that needs this behavior will be greatly refactored for multi-web process.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcess): We already know that we need a new process, "relaunch if necessary" is not the right logic. Also added a few more assertions checking that process state is as expected.


  • UIProcess/WebResourceCacheManagerProxy.cpp: (WebKit::WebResourceCacheManagerProxy::getCacheOrigins): Removed relaunchProcessIfNecessary(). It will be called inside sendToAllProcessesRelaunchingThemIfNecessary().
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::getSitesWithData): Ditto. (WebKit::WebPluginSiteDataManager::clearSiteData): Ditto.
1:51 PM Changeset in webkit [129700] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Remove deprecated code from perftestrunner.py
​https://bugs.webkit.org/show_bug.cgi?id=97724

Reviewed by Adam Barth.

Remove the code deprecated in r129580 now that we have landed r129597,
which updated master.cfg to use new options, and restarted the buildbot master.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):
(PerfTestsRunner._generate_and_show_results):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_with_slave_config_json):
(test_parse_args):

1:45 PM Changeset in webkit [129699] by cevans@google.com
  • 1 edit in branches/chromium/1271/Source/WebCore/rendering/RenderArena.cpp

Merge 129583
BUG=152354
Review URL: ​https://codereview.chromium.org/10993050

1:45 PM Changeset in webkit [129698] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed speculative build fix for clang.

Added explicit static_cast from int64_t to int32_t.

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::uTextLatin1Clone):
(WebCore::uTextLatin1Extract):
(WebCore::uTextLatin1MapNativeIndexToUTF16):

1:34 PM Changeset in webkit [129697] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r129673.
​http://trac.webkit.org/changeset/129673
​https://bugs.webkit.org/show_bug.cgi?id=97723

Causing window build breakage (Requested by alecf on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-26

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::ensureFontLoaded):

1:30 PM Changeset in webkit [129696] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1271

Merge 129469
BUG=150966
Review URL: ​https://codereview.chromium.org/10989043

1:27 PM Changeset in webkit [129695] by Dave Barton
  • 13 edits in trunk

[MathML] Implement <mtd> rowspan and columnspan attributes
​https://bugs.webkit.org/show_bug.cgi?id=97401

Reviewed by Eric Seidel.

Source/WebCore:

These should behave like rowspan and colspan for HTMLTableCell. As in that case,
RenderTableCell accesses these attributes of its element as needed.

Tested by modifications to LayoutTests/mathml/presentation/tables.xhtml.

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::colSpan):
(WebCore::MathMLElement::rowSpan):
(WebCore::MathMLElement::parseAttribute):

  • mathml/MathMLElement.h:

(MathMLElement):
(WebCore::toMathMLElement):

  • mathml/mathattrs.in:
  • mathml/mathtags.in:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):
(WebCore::isMathMLElement):
(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
(WebCore::RenderTableCell::colSpanOrRowSpanChanged):

  • rendering/RenderTableCell.h:

(RenderTableCell):

  • Changed m_hasAssociatedTableCellElement to m_hasHTMLTableCellElement.

LayoutTests:

  • mathml/presentation/tables.xhtml:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:
1:25 PM Changeset in webkit [129694] by Beth Dakin
  • 2 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=97629
http/tests/security/cross-frame-access-put.html failing on Mac WK2 bots after
being unskipped

Reviewed by Tim Horton.

The test was failing because we were failing to use the fake window origin. We
should really always use the fake origin. This patch eliminates
_shouldUseFakeOrigin in favor of always using it.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[WebKitTestRunnerWindow setFrameOrigin:]):
(-[WebKitTestRunnerWindow setFrame:display:animate:]):
(-[WebKitTestRunnerWindow setFrame:display:]):
(-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):

1:21 PM Changeset in webkit [129693] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/1271

Merge 129585
BUG=145915
Review URL: ​https://codereview.chromium.org/10993046

1:10 PM Changeset in webkit [129692] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt] load event fires on XMLHttpRequestUpload twice with Qt5
​https://bugs.webkit.org/show_bug.cgi?id=92669

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-09-26
Reviewed by Kenneth Rohde Christiansen.

When finishing, after the upload have already been done, Qt5's
QNetworkReply emits an uploadProgress signal with total bytes set to
zero. Since 0 of 0 bytes doesn't make any sense as progress, a
conditional was added to QNetworkReplyHandler::uploadProgress to make
do nothing with such values.

Unskip XMLHttpRequestUpload tests.

Source/WebCore:

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::uploadProgress):

LayoutTests:

  • platform/qt-5.0/Skipped:
1:08 PM Changeset in webkit [129691] by fpizlo@apple.com
  • 5 edits
    6 adds in trunk

JSObject::ensureArrayStorage() ignores the possibility that extensions have been prevented
​https://bugs.webkit.org/show_bug.cgi?id=97719

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::ensureArrayStorageSlow):
(JSC):

  • runtime/JSObject.h:

(JSC::JSObject::ensureArrayStorage):
(JSObject):

LayoutTests:

  • fast/js/dfg-arrayify-when-late-prevent-extensions-expected.txt: Added.
  • fast/js/dfg-arrayify-when-late-prevent-extensions.html: Added.
  • fast/js/dfg-arrayify-when-prevent-extensions-expected.txt: Added.
  • fast/js/dfg-arrayify-when-prevent-extensions.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-arrayify-when-late-prevent-extensions.js: Added.

(foo):

  • fast/js/script-tests/dfg-arrayify-when-prevent-extensions.js: Added.

(foo):

1:06 PM Changeset in webkit [129690] by tony@chromium.org
  • 4 edits in trunk/Tools

C++ style checker should warn when the indentation is wrong
​https://bugs.webkit.org/show_bug.cgi?id=97602

Reviewed by Ojan Vafai.

Rewrite the indentation checker to ensure that indentation is always a factor of 4
and that we only indent 4 spaces from the previous line.

I deleted some of the old indentation checking code since it was filtered out
and didn't match the webkit style.

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checkers/cpp.py:

(check_indentation_amount): New function that checks indentation. Intentionally runs after
other indentation checks.
(check_style): Delete the old indentation code since we were already filtering out the whitespace/labels warnings.
(CppChecker): Remove the whitespace/labels filter.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_multi_line_comments): Force 4 space indent.
(CppStyleTest.test_explicit_single_argument_constructors):
(CppStyleTest.test_explicit_single_argument_constructors.Foo):
(CppStyleTest.test_explicit_single_argument_constructors.Qualifier):
(CppStyleTest.test_slash_star_comment_on_single_line):
(CppStyleTest.test_braces):
(CppStyleTest.test_spacing_before_last_semicolon):
(CppStyleTest.test_static_or_global_stlstrings):
(CppStyleTest.test_indent): Added macro test case.
(CppStyleTest.test_build_class):
(NoNonVirtualDestructorsTest.test_no_error):
(NoNonVirtualDestructorsTest.test_no_error.Foo):
(NoNonVirtualDestructorsTest.test_no_error.Qualified):
(NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed):
(NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo):
(NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed):
(NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo):
(NoNonVirtualDestructorsTest.test_no_warn_when_derived):
(NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo):
(NoNonVirtualDestructorsTest.test_internal_braces):
(NoNonVirtualDestructorsTest.test_internal_braces.Foo):
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor):
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo):
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo):
(NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor):
(NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo):
(NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo):
(NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor):
(NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified):
(NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error):
(NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo):
(NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
(NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo):
(WebKitStyleTest.test_indentation):
(WebKitStyleTest.test_braces): Add test for call params spanning lines.

12:55 PM Changeset in webkit [129689] by commit-queue@webkit.org
  • 13 edits
    2 moves in trunk/Source/WebCore

[CSS Exclusions] Rename WrapShapeInfo to ExclusionShapeInfo
​https://bugs.webkit.org/show_bug.cgi?id=96157

Patch by Bear Travis <​betravis@adobe.com> on 2012-09-26
Reviewed by Dirk Schulze.

Rename WrapShapeInfo to the more specific ExclusionShapeInsideInfo, which is the only
information the class is currently tracking. This patch updates build files, class
instances and variable names. When shape-outside is added, there may be an additional
ExclusionShapeOutsideInfo class that shares a common parent class with
ExclusionShapeInsideInfo. This patch only changes names, there is no new functionality.

Covered by existing tests

  • CMakeLists.txt: Rename files from WrapShapeInfo to ExclusionShapeInsideInfo.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/ExclusionShapeInsideInfo.cpp: Renamed from Source/WebCore/rendering/WrapShapeInfo.cpp.

(WebCore): Renaming functions and variables to use ExclusionShapeInsideInfo rather than
WrapShapeInfo.
(WebCore::exclusionShapeInsideInfoMap):
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::~ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::ensureExclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::exclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::removeExclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::computeShapeSize):
(WebCore::ExclusionShapeInsideInfo::computeSegmentsForLine):

  • rendering/ExclusionShapeInsideInfo.h: Renamed from Source/WebCore/rendering/WrapShapeInfo.h.

(WebCore):
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::create):
(WebCore::ExclusionShapeInsideInfo::shapeLogicalTop):
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBottom):
(WebCore::ExclusionShapeInsideInfo::hasSegments):
(WebCore::ExclusionShapeInsideInfo::segments):
(WebCore::ExclusionShapeInsideInfo::dirtyShapeSize):
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds):

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/LayoutState.h:

(WebCore):
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::exclusionShapeInsideInfo):
(LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):
(WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize):
(WebCore::RenderBlock::computeExclusionShapeSize):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::exclusionShapeInsideInfo):
(RenderBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::layoutExclusionShapeInsideInfo):
(WebCore::LineWidth::LineWidth):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):

  • rendering/RenderView.h:

(WebCore::RenderView::pushLayoutState):

12:44 PM Changeset in webkit [129688] by eae@chromium.org
  • 12 edits
    2 copies in branches/chromium/1271

Merge 129370 - snapToSize rounds the incorrectly for negative locations
​https://bugs.webkit.org/show_bug.cgi?id=97265

Reviewed by Eric Seidel.

Source/WebCore:

Change snapSizeToPixel to preserve sign for location which
affects rounding.

Test: fast/sub-pixel/snap-negative-location.html

  • platform/FractionalLayoutUnit.h:

(WebCore::snapSizeToPixel):

LayoutTests:

Add test for snapSizeToPixel handling of negative locations.
Skipped on platforms that do not enable subpixel layout.

  • fast/sub-pixel/snap-negative-location-expected.html: Added.
  • fast/sub-pixel/snap-negative-location.html: Added.
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:

TBR=​eae@chromium.org
Review URL: ​https://codereview.chromium.org/10996032

12:43 PM Changeset in webkit [129687] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

[EFL] Volume button should not be shown for videos without audio
​https://bugs.webkit.org/show_bug.cgi?id=97574

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The volume control is no longer shown for videos with
no audio.

No new tests, already tested by media/video-no-audio.html.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::hasOwnDisabledStateHandlingFor):
(WebCore):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

LayoutTests:

Generate baseline for media/video-no-audio.html and unskip
it now that the volume control is no longer shown for
videos with no audio track.

Rebaseline several other media tests whose output changed
due to the fix.

  • platform/efl/Skipped:
  • platform/efl/media/media-controls-clone-expected.png:
  • platform/efl/media/media-controls-clone-expected.txt:
  • platform/efl/media/video-empty-source-expected.png:
  • platform/efl/media/video-empty-source-expected.txt:
  • platform/efl/media/video-no-audio-expected.png: Added.
  • platform/efl/media/video-no-audio-expected.txt: Added.
12:40 PM Changeset in webkit [129686] by leviw@chromium.org
  • 8 edits
    2 copies in branches/chromium/1271

Merge 129529 - [chromium] REGRESSION: Incorrect preferred width calculation for table cells
​https://bugs.webkit.org/show_bug.cgi?id=97497

Reviewed by Levi Weintraub.

Source/WebCore:

In fixing bug 93911 r125694 caused a problem with the preferred
width calculations for table cells with a fractional padding
where the logic to ensure that the cell is wide enough for the
content returns different results for cells with a fixed width
and cells with an automatic width.

Test: fast/sub-pixel/table-cells-have-stable-width.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):
Move the logic that ensures that a cell is wide enough from AutoTableLayout::recalcColumn to RenderBlock::computePreferredLogicalWidths to. This way it also applies to FixedTableLayout which had the same problem.

LayoutTests:

Added test for cell width calculation and reverted three svg tests to the results prior to r125694.

  • fast/sub-pixel/table-cells-have-stable-width-expected.txt: Added.
  • fast/sub-pixel/table-cells-have-stable-width.html: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:

TBR=​eae@chromium.org

12:39 PM Changeset in webkit [129685] by barraclough@apple.com
  • 19 edits
    3 moves in trunk/Source

Generalize JSGlobalThis as JSProxy
​https://bugs.webkit.org/show_bug.cgi?id=97716

Reviewed by Oliver Hunt.

../JavaScriptCore:

Generalize JSGlobalThis as JSProxy and move proxying functionality up from the window shell into JSProxy.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::toThisObject):

  • Hoist toThisObject from WebCore.

(JSC):

  • runtime/JSGlobalObject.h:
    • removed include.

(JSC::JSGlobalObject::finishCreation):

  • JSGlobalThis -> JSObject

(JSGlobalObject):

  • Hoist toThisObject from WebCore.
  • runtime/JSGlobalThis.cpp: Removed.
  • runtime/JSGlobalThis.h: Removed.
  • runtime/JSObject.cpp:
    • removed include.
  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::isProxy):

  • isGlobalThis -> isProxy
  • GlobalThisType -> ProxyType
  • runtime/JSProxy.cpp: Copied from Source/JavaScriptCore/runtime/JSGlobalThis.cpp.

(JSC):
(JSC::JSProxy::visitChildren):
(JSC::JSProxy::setTarget):
(JSC::JSProxy::className):
(JSC::JSProxy::getOwnPropertySlot):
(JSC::JSProxy::getOwnPropertySlotByIndex):
(JSC::JSProxy::getOwnPropertyDescriptor):
(JSC::JSProxy::put):
(JSC::JSProxy::putByIndex):
(JSC::JSProxy::putDirectVirtual):
(JSC::JSProxy::defineOwnProperty):
(JSC::JSProxy::deleteProperty):
(JSC::JSProxy::deletePropertyByIndex):
(JSC::JSProxy::getPropertyNames):
(JSC::JSProxy::getOwnPropertyNames):

  • Class cretaed from JSGlobalThis, JSDOMWindowShell.
  • runtime/JSProxy.h: Copied from Source/JavaScriptCore/runtime/JSGlobalThis.h.

(JSC::JSProxy::create):
(JSC::JSProxy::createStructure):
(JSProxy):
(JSC::JSProxy::target):
(JSC::JSProxy::JSProxy):

  • Class cretaed from JSGlobalThis, JSDOMWindowShell.
  • runtime/JSType.h:
    • GlobalThisType -> ProxyType

../WebCore:

This patch moves window shell functionality up to JSC::JSProxy.

  • ForwardingHeaders/runtime/JSGlobalThis.h: Removed.
  • ForwardingHeaders/runtime/JSProxy.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSGlobalThis.h.
  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::finishCreation):

  • JSGlobalThis -> JSObject
  • bindings/js/JSDOMGlobalObject.h:

(JSDOMGlobalObject):

  • JSGlobalThis -> JSObject
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore):

  • Hoist toThisObject up into JSC.
  • bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

  • Hoist toThisObject up into JSC.
  • bindings/js/JSDOMWindowShell.cpp:

(WebCore):

  • JSGlobalThis -> JSProxy
  • moved JSObject callbacks to JSProxy
  • bindings/js/JSDOMWindowShell.h:

(JSDOMWindowShell):

  • JSGlobalThis -> JSProxy
  • moved JSObject callbacks to JSProxy

(WebCore::JSDOMWindowShell::window):

  • unwrappedObject() -> target()

(WebCore::JSDOMWindowShell::setWindow):

  • setUnwrappedObject() -> setTarget()

(WebCore::JSDOMWindowShell::createStructure):

  • GlobalThisType -> ProxyType
12:26 PM Changeset in webkit [129684] by abarth@webkit.org
  • 3 edits in trunk/Tools

Rollout messages should be clickable in bugzilla
​https://bugs.webkit.org/show_bug.cgi?id=97711

Reviewed by Simon Fraser.

If we say Bug NNNN instead of just NNNN, bugzilla will autolink to the
actual bug.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/steps/createbug.py:

(CreateBug.run):

12:20 PM Changeset in webkit [129683] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

run-perf-tests must expand environment variables in user provided paths
​https://bugs.webkit.org/show_bug.cgi?id=97686

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-09-26
Reviewed by Ryosuke Niwa.

The run-perf-tests command line options that receive paths from the
user now expand any possible environment variables, because Python's
file handling methods do not handle those.

Examples:
run-perf-tests --platform=qt --release --output-json-path=~/perf-results
run-perf-tests --platform=qt --release --output-json-path=$HOME/perf-results

Also removed unused imports.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args._expand_path): expand environment variables in a path passed via command line
(PerfTestsRunner._parse_args):

12:10 PM Changeset in webkit [129682] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

4.95MB below RenderBlock::insertIntoTrackedRendererMaps() on Membuster3.
<​http://webkit.org/b/97687>

Reviewed by Anders Carlsson.

Give the TrackedRendererListHashSet typedef an inline capacity of 16 (the default is 256.)
Browsing around the web, I saw almost no cases with more than 20 entries in these lists,
and this simple change saves us ~4.68MB on the Membuster3 benchmark.

  • rendering/RenderBlock.h:
12:06 PM Changeset in webkit [129681] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

DelayNode must take sample-accurate delay times into account
​https://bugs.webkit.org/show_bug.cgi?id=97609

Reviewed by Kenneth Russell.

Currently DelayNode simply uses a coarse-grained k-rate smoothing of .delayTime
It should also be capable of supporting audio-rate control of .delayTime

  • Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel):
(WebCore::DelayDSPKernel::process):

  • Modules/webaudio/DelayDSPKernel.h:

(DelayDSPKernel):

11:59 AM Changeset in webkit [129680] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Reintroducing failure expectation for http/tests/security/xss-eval.html as
the fixing commit was rolled out. Also adding a flaky expectation for
mathml/presentation/msubsup-base-changed.html.

  • platform/gtk/TestExpectations:
11:57 AM Changeset in webkit [129679] by peter@chromium.org
  • 1 edit
    66 deletes in trunk/LayoutTests

Revert "[Chromium] Rebase a few of Mozilla's tests in tables/ for Android."
Unreviewed revert.

The rebaseline server hasn't been updated to rebaseline for the chromium-android/
target, and was left on the default of wk2/. Sorry for the noise! :-(.

11:50 AM Changeset in webkit [129678] by peter@chromium.org
  • 1 edit
    69 adds in trunk/LayoutTests

[Chromium] Rebase a few of Mozilla's tests in tables/ for Android.

Unreviewed rebaselining.

This rebaselines a few tests in Mozilla's suite for tables/. All of these
had differences because of Android's different scrollbar. For more context
on Android's baselining, see bug 96398.

  • platform/wk2/tables/mozilla/: 33 new results.
11:47 AM Changeset in webkit [129677] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

Unreviewed, rolling out r129521.
​http://trac.webkit.org/changeset/129521
​https://bugs.webkit.org/show_bug.cgi?id=97710

Broke autocomplete on enter_bug.cgi (Requested by abarth on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-26

  • committers-autocomplete.js:
11:36 AM Changeset in webkit [129676] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add ability for JSArray::unshiftCount to unshift in middle of an array
​https://bugs.webkit.org/show_bug.cgi?id=97691

Reviewed by Filip Pizlo.

Changed JSArray::unshiftCount and unshiftCountSlowCase to handle unshifting from the middle of an
array. Depending on where the unshift point is, either the front part of the array will be moved
"left" or the back part will be moved right. Given that unshiftCount only works on contiguous
arrays it is safe to use memmove for the moves.

This change is worth 25% performance improvement on pdfjs. It doesn't seem to have any impact on
any other benchmarks.

  • runtime/ArrayPrototype.cpp:

(JSC::unshift):

  • runtime/JSArray.cpp:

(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::unshiftCount):

  • runtime/JSArray.h:

(JSArray):

11:16 AM Changeset in webkit [129675] by eae@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed chromium mac rebaseline.

  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
11:15 AM Changeset in webkit [129674] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Do not dispatch touch-events to plugins unless they explicitly request for touch-events.
​https://bugs.webkit.org/show_bug.cgi?id=97685

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-09-26
Reviewed by Adam Barth.

Plugins need to call setIsAcceptingTouchEvents if they want to receive touch-events. So
avoid dispatching touch-events to plugins unless they have explicitly requested for them.

  • src/WebPluginContainerImpl.cpp:
11:14 AM Changeset in webkit [129673] by pilgrim@chromium.org
  • 5 edits in trunk/Source

[Chromium][Win] Remove ensureFontLoaded from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=97696

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::ensureFontLoaded):

11:11 AM Changeset in webkit [129672] by commit-queue@webkit.org
  • 17 edits
    18 deletes in trunk

Unreviewed, rolling out r129654.
​http://trac.webkit.org/changeset/129654
​https://bugs.webkit.org/show_bug.cgi?id=97702

breaks chromium windows build (Requested by schenney on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-26

Source/Platform:

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCStatsRequest.h: Removed.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCPeerConnection.cpp:
  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCStatsCallback.h: Removed.
  • Modules/mediastream/RTCStatsCallback.idl: Removed.
  • Modules/mediastream/RTCStatsElement.cpp: Removed.
  • Modules/mediastream/RTCStatsElement.h: Removed.
  • Modules/mediastream/RTCStatsElement.idl: Removed.
  • Modules/mediastream/RTCStatsReport.cpp: Removed.
  • Modules/mediastream/RTCStatsReport.h: Removed.
  • Modules/mediastream/RTCStatsReport.idl: Removed.
  • Modules/mediastream/RTCStatsRequestImpl.cpp: Removed.
  • Modules/mediastream/RTCStatsRequestImpl.h: Removed.
  • Modules/mediastream/RTCStatsResponse.cpp: Removed.
  • Modules/mediastream/RTCStatsResponse.h: Removed.
  • Modules/mediastream/RTCStatsResponse.idl: Removed.
  • WebCore.gypi:
  • platform/chromium/support/WebRTCStatsRequest.cpp: Removed.
  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCStatsRequest.h: Removed.
  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-stats-expected.txt: Removed.
  • fast/mediastream/RTCPeerConnection-stats.html: Removed.
11:01 AM Changeset in webkit [129671] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Need implement isWordTextBreak for QT, and WinCE for visual word movement functionality
​https://bugs.webkit.org/show_bug.cgi?id=81136

Patch by Tullio Lucena <​tullio.lucena@openbossa.org> on 2012-09-26
Reviewed by Csaba Osztrogonác.

Unskip some tests that are passing.

  • platform/qt/Skipped:
10:53 AM Changeset in webkit [129670] by pdr@google.com
  • 7 edits in trunk/Source/WebCore

Refactor SMILTimeContainer to maintain animation information instead of recalculating it every frame
​https://bugs.webkit.org/show_bug.cgi?id=96697

Reviewed by Eric Seidel.

SVGTimeContainer can be improved by maintaining extra information about
animations during schedule/unschedule instead of re-calculating it
every frame.

After this patch, SMILTimeContainer maintains a GroupedAnimationsMap instead of
just a Vector. This map maps a list of animations to the specific ElementAttributePair
that will be animated.

On schedule/unschedule we modify this map instead of creating it in updateAnimations.
As a result, we need to be careful about always notifying (or, re-scheduling) the
time container when either an animation's target changes or an animation's attributeName
changes. This notification is managed by tracking changes with targetElementWillChange
and setAttributeName.

After this patch, updateAnimations only iterates over m_scheduledAnimations.
Furthermore, the sorting of animations by priority is now done over each Vector of
SVGSMILElements affecting a {SVGElement*, QualifiedName} pair instead of over all the
SVGSMILElements at once.

Lastly, a guard (m_preventScheduledAnimationsChanges) has been added
to prove that we do not modify the scheduled animations map out
from under ourselves.

No new tests as this is just a refactoring.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::hasValidAttributeType):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::hasValidAttributeName):

Per the spec, AnimateMotion is not affected by attributeName. Instead
of having a special case for this in SMILTimeContainer::updateAnimations
we simply implement this method.

(WebCore):

  • svg/SVGAnimateMotionElement.h:

(SVGAnimateMotionElement):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::updateAnimation):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore):
(WebCore::SMILTimeContainer::SMILTimeContainer):
(WebCore::SMILTimeContainer::~SMILTimeContainer):

This method now cleans up the map since we have dynamically allocated
Vectors in it.

(WebCore::SMILTimeContainer::schedule):

Here we are just adding an entry to the map. There is some special handling
for creating the Vector of one does not exist.

(WebCore::SMILTimeContainer::unschedule):
(WebCore::SMILTimeContainer::notifyIntervalsChanged):
(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::startTimer):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SMILTimeContainer.h:

(WebCore::SMILTimeContainer::create):
(SMILTimeContainer):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::~SVGSMILElement):
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):
(WebCore):
(WebCore::SVGSMILElement::hasValidAttributeName):
(WebCore::SVGSMILElement::svgAttributeChanged):
(WebCore::SVGSMILElement::setAttributeName):
(WebCore::SVGSMILElement::targetElementWillChange):
(WebCore::SVGSMILElement::resetTargetElement):
(WebCore::SVGSMILElement::resolveFirstInterval):
(WebCore::SVGSMILElement::beginListChanged):
(WebCore::SVGSMILElement::endListChanged):
(WebCore::SVGSMILElement::progress):

  • svg/animation/SVGSMILElement.h:

(SVGSMILElement):

10:51 AM Changeset in webkit [129669] by rniwa@webkit.org
  • 6 edits in trunk/PerformanceTests

Use runPerSecond in PerformanceTests/Bindings/typed-array* and event-target-wrapper
​https://bugs.webkit.org/show_bug.cgi?id=97625

Reviewed by Eric Seidel.

Use PerfTestRunner.runPerSecond instead of PerfTestRunner.run. Also reduce the fixed number of
elements and iterations in these tests by a factor of 10 since runPerSecond can dynamically
adjust the number of function calls.

  • Bindings/event-target-wrapper.html:
  • Bindings/typed-array-construct-from-array.html:
  • Bindings/typed-array-construct-from-same-type.html:
  • Bindings/typed-array-construct-from-typed.html:
  • Bindings/typed-array-set-from-typed.html:
10:43 AM Changeset in webkit [129668] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Update SVGFontData for 8 bit TextRun changes
​https://bugs.webkit.org/show_bug.cgi?id=97379

Reviewed by Geoffrey Garen.

Educated applySVGGlyphSelection to be 8 / 16 bit TextRun aware.

No change in funcitonality, therefore no new tests.

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

10:41 AM Changeset in webkit [129667] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix for Chromium TestExpectations

  • platform/chromium/TestExpectations:
10:27 AM Changeset in webkit [129666] by leandrogracia@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Fix find-in-page corner case for detached frames
​https://bugs.webkit.org/show_bug.cgi?id=97688

Reviewed by Adam Barth.

Adds a check to prevent crashes when running find-in-page requests
on detached frames.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::scopeStringMatches):

10:27 AM Changeset in webkit [129665] by eae@chromium.org
  • 149 edits
    25 adds
    39 deletes in trunk/LayoutTests

Unreviewed chromium mac rebaseline for r129656.

  • css1/formatting_model/vertical_formatting-expected.txt: Added.
  • fast/box-sizing/box-sizing-expected.png: Added.
  • fast/css/hsl-color-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-styles-expected.txt: Replaced.
  • fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Replaced.
  • fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Replaced.
  • fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Replaced.
  • fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Replaced.
  • fast/multicol/span/span-as-nested-columns-child-expected.txt: Replaced.
  • fast/multicol/span/span-margin-collapsing-expected.txt: Replaced.
  • fast/text/whitespace/024-expected.txt: Added.
  • platform/chromium-linux-x86/fast/html: Removed.
  • platform/chromium-linux-x86/fast/html/details-writing-mode-expected.txt: Removed.
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.txt: Removed.
  • platform/chromium-linux/fast/parser/style-script-head-test-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/hsl-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/updateLayoutForHitTest-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/formmove-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-mac/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/inline_elements-expected.txt:
  • platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/chromium-mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-mac/fast/css/hsl-color-expected.png:
  • platform/chromium-mac/fast/css/hsl-color-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-mac/fast/events/updateLayoutForHitTest-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/formmove-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-marker-style-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac/fast/html/details-open1-expected.png:
  • platform/chromium-mac/fast/html/details-open3-expected.png:
  • platform/chromium-mac/fast/html/details-open5-expected.png:
  • platform/chromium-mac/fast/html/details-position-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac/fast/text/line-breaks-expected.txt:
  • platform/chromium-mac/fast/text/whitespace/024-expected.txt:
  • platform/chromium-mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/chromium-mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/chromium-mac/svg/custom/viewBox-hit-expected.png:
  • platform/chromium-mac/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac/svg/wicd/rightsizing-grid-expected.txt:
  • platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-1-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/chromium-mac/tables/mozilla/other/test3-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-win-xp/fast/box-sizing: Removed.
  • platform/chromium-win-xp/fast/box-sizing/box-sizing-expected.png: Removed.
  • platform/chromium-win/fast/parser/style-script-head-test-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/parser/style-script-head-test-expected.txt: Replaced.
  • platform/efl/css1/formatting_model/vertical_formatting-expected.txt: Removed.
  • platform/efl/fast/box-sizing/box-sizing-expected.png: Removed.
  • platform/efl/fast/css/hsl-color-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-margin-collapsing-expected.txt: Removed.
  • platform/efl/fast/text/whitespace/024-expected.txt: Removed.
  • platform/efl/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/efl/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug2479-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/other/test3-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt: Removed.
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt: Removed.
  • platform/gtk/fast/box-sizing/box-sizing-expected.png: Removed.
  • platform/gtk/fast/css/hsl-color-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt: Removed.
  • platform/gtk/fast/text/whitespace/024-expected.txt: Removed.
  • platform/gtk/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug2479-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/other/test3-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug91057-expected.txt: Removed.
  • platform/win-future/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
  • platform/win-future/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • platform/win-future/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • platform/win-future/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • platform/win-future/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/win-future/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
  • svg/wicd/rightsizing-grid-expected.txt: Added.
  • svg/wicd/test-rightsizing-b-expected.txt: Added.
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
  • tables/mozilla/bugs/bug2479-1-expected.txt: Added.
  • tables/mozilla/other/test3-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug91057-expected.txt: Added.
10:26 AM Changeset in webkit [129664] by msaboff@apple.com
  • 6 edits in trunk/Source

Update ComplexTextController for 8 bit TextRun changes
​https://bugs.webkit.org/show_bug.cgi?id=97378

Reviewed by Geoffrey Garen.

Source/WebCore:

Since the ComplextTextController code is primarily used for UChar data, just upconvert an 8 bit
TextRun into a new String and hold on to the String with a vector for the life of the controller.

No change in functionality, therefore no new tests.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::collectComplexTextRuns):

  • platform/graphics/mac/ComplexTextController.h:

(ComplexTextController):

Source/WTF:

Add a new create method to make a 16 bit string from 8 bit source data. This is used in
ComplexTextController when we have LChar* + length text data, but we really want 16 bit
data for the complex text rendering code.

  • wtf/text/WTFString.cpp:

(WTF::String::make16BitFrom8BitSource):
(WTF):

  • wtf/text/WTFString.h:

(String):

10:24 AM Changeset in webkit [129663] by msaboff@apple.com
  • 2 edits in trunk/Tools

Unreviewed build change.

Reverting inadvertent change to project file.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9:54 AM Changeset in webkit [129662] by msaboff@apple.com
  • 7 edits in trunk

Add Latin-1 Line Break Iterator to TextBreakIteratorICU.cpp
​https://bugs.webkit.org/show_bug.cgi?id=96935

Reviewed by Geoffrey Garen.

Added a Latin-1 UText implementation for the ICU library to use. Added a new acquireLineBreakIterator() for
8 bit strings that uses the Latin-1 UText implementation. This code path is not being called with the current
ToT code. Subsequent changes will enable calling the new code.

  • platform/text/TextBreakIterator.h:

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::string):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::uTextLatin1Clone):
(WebCore::uTextLatin1NativeLength):
(WebCore::uTextLatin1Access):
(WebCore::uTextLatin1Extract):
(WebCore::uTextLatin1MapOffsetToNative):
(WebCore::uTextLatin1MapNativeIndexToUTF16):
(WebCore::uTextLatin1Close):
(WebCore::UTextOpenLatin1):
(WebCore::acquireLineBreakIterator):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/break_lines.cpp:

(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):

9:47 AM Changeset in webkit [129661] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitJavascriptResult
​https://bugs.webkit.org/show_bug.cgi?id=96780

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitJavascriptResult.cpp:

(_WebKitJavascriptResult::_WebKitJavascriptResult):
(webkitJavascriptResultCreate):

  • UIProcess/API/gtk/WebKitJavascriptResultPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewRunJavaScriptCallback):

9:45 AM Changeset in webkit [129660] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Reverting implementation for 407 error pages
​https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-09-26
Reviewed by Rob Buis.

Last fix to NetworkJob to invoke AuthenticationChallenge by resetting
BlackBerryPlatformSettings's proxy credentials to "" if authentication
failed.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

9:44 AM Changeset in webkit [129659] by peter@chromium.org
  • 5 edits
    367 adds in trunk/LayoutTests

[Chromium] Second part of Android's fast/ rebaselining.

Unreviewed rebaselining.

Second part of baselining in fast/. Equal to the first part (r129642),
most of the tests were failing because of the scrollbar of text selection
color. Bugs will be filed for all genuine failures, and every test has
been looked at and compared with Linux individually.

General info about the initial baselining is available in bug 96398.

  • platform/chromium-android/fast/block/: 71 new results.
  • platform/chromium-android/fast/multicol/: 93 new results.
  • platform/chromium-android/fast/overflow/: 52 new results.
  • platform/chromium-android/fast/repaint/: 67 new results.
  • platform/chromium-android/fast/table/: 44 new results.
  • platform/chromium-android/fast/text/: 22 new results.
9:33 AM Changeset in webkit [129658] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update padding in ensureFocusTextElementVisible to be DPI independent.
​https://bugs.webkit.org/show_bug.cgi?id=97684

Reviewed by Rob Buis.

Update padding in ensureFocusTextElementVisible to be DPI
independent and relative to the current zoom level.

Reviewed Internally by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

9:29 AM Changeset in webkit [129657] by kenneth@webkit.org
  • 5 edits in trunk/Source/WebCore

Reorder Cairo WebCore includes
​https://bugs.webkit.org/show_bug.cgi?id=97679

Reviewed by Simon Hausmann.

  • platform/graphics/cairo/FontCairo.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cairo/TransformationMatrixCairo.cpp:
  • platform/wx/wxcode/cairo/non-kerned-drawing.cpp:
9:25 AM Changeset in webkit [129656] by eae@chromium.org
  • 98 edits
    2 adds in trunk

Change FractionalLayoutUnit denominator to 64 to reduce precision loss when converting to floating point
​https://bugs.webkit.org/show_bug.cgi?id=96139

Reviewed by Eric Seidel.

Source/WebCore:

We currently use a denominator of 60 in FractionalLayoutUnit,
this causes a loss of precision when converting to floating
point.

By changing the denominator to 64 the values can better be
represented as floating point (without loosing any precision for
many values), this in turn allows us to remove the tolerance
hack in the line break logic and avoids problems caused by this
precision for web sites that do their own layout based on
element measurements.

Test: fast/sub-pixel/float-precision.html

  • platform/FractionalLayoutUnit.h:

Change denominator to 64.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::fitsOnLine):
Remove epsilon tolerance hack.

LayoutTests:

Add new precision test and adjust expectations for existing tests as needed.

  • fast/sub-pixel/float-precision-expected.html: Added.
  • fast/sub-pixel/float-precision.html: Added.
  • fast/sub-pixel/float-wrap-with-subpixel-top-expected.html:
  • fast/sub-pixel/float-wrap-with-subpixel-top.html:
  • fast/sub-pixel/layout-boxes-with-zoom-expected.html:
  • fast/sub-pixel/layout-boxes-with-zoom.html:
  • fast/sub-pixel/size-of-box-with-zoom-expected.html:
  • fast/sub-pixel/size-of-box-with-zoom.html:
  • platform/chromium-linux/css1/formatting_model/inline_elements-expected.txt:
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-linux/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-linux/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-linux/fast/css/hsl-color-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-marker-style-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary1-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary3-expected.png:
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png:
  • platform/chromium-linux/fast/html/details-open1-expected.png:
  • platform/chromium-linux/fast/html/details-open3-expected.png:
  • platform/chromium-linux/fast/html/details-open5-expected.png:
  • platform/chromium-linux/fast/html/details-position-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-linux/fast/parser/style-script-head-test-expected.txt:
  • platform/chromium-linux/fast/text/line-breaks-expected.txt:
  • platform/chromium-linux/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/chromium-linux/svg/custom/viewBox-hit-expected.png:
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/chromium-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-win/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/chromium-win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/chromium-win/fast/css/hsl-color-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/chromium-win/fast/text/whitespace/024-expected.txt:
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-1-expected.txt:
  • platform/chromium-win/tables/mozilla/other/test3-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/chromium/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt:
9:18 AM Changeset in webkit [129655] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed buildfix after r129647.

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp: Revert incorrect include reordering.
9:16 AM Changeset in webkit [129654] by commit-queue@webkit.org
  • 17 edits
    2 copies
    16 adds in trunk

Implement the GetStats interface on PeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=95193

Source/Platform:

Patch by Harald Tveit Alvestrand <​harald@alvestrand.no> on 2012-09-26
Reviewed by Adam Barth.

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):
(WebKit::WebRTCPeerConnectionHandler::getStats):

  • chromium/public/WebRTCStatsRequest.h: added.

(WebCore):
(WebKit):
(WebRTCStatsRequest):
(WebKit::WebRTCStatsRequest::WebRTCStatsRequest):
(WebKit::WebRTCStatsRequest::~WebRTCStatsRequest):
(WebKit::WebRTCStatsRequest::operator=):

Source/WebCore:

Specification:
​http://dev.w3.org/2011/webrtc/editor/webrtc-20120920.html

Patch by Harald Tveit Alvestrand <​harald@alvestrand.no> on 2012-09-26
Reviewed by Adam Barth.

The implementation consists of a pure virtual platform object
(RTCStatsRequest) that is implemented in WebCore, and stores
its information in a straightforward data hierarchy.
This patch adds the call path and the storage structures.
It does not add filling in data.

Test: fast/mediastream/RTCPeerConnection-stats.html

  • CMakeLists.txt:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getStats):
(WebCore):

  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCStatsCallback.h: Added.

(WebCore):
(RTCStatsCallback):
(WebCore::RTCStatsCallback::~RTCStatsCallback):

  • Modules/mediastream/RTCStatsCallback.idl: Added.
  • Modules/mediastream/RTCStatsElement.cpp: Added.

(WebCore):
(WebCore::RTCStatsElement::create):
(WebCore::RTCStatsElement::RTCStatsElement):
(WebCore::RTCStatsElement::stat):

  • Modules/mediastream/RTCStatsElement.h: Added.

(WebCore):
(RTCStatsElement):

  • Modules/mediastream/RTCStatsElement.idl: Added.
  • Modules/mediastream/RTCStatsReport.cpp: Added.

(WebCore):
(WebCore::RTCStatsReport::create):
(WebCore::RTCStatsReport::RTCStatsReport):

  • Modules/mediastream/RTCStatsReport.h: Added.

(WebCore):
(RTCStatsReport):
(WebCore::RTCStatsReport::local):
(WebCore::RTCStatsReport::remote):

  • Modules/mediastream/RTCStatsReport.idl: Added.
  • Modules/mediastream/RTCStatsRequestImpl.cpp: Added.

(WebCore):
(WebCore::RTCStatsRequestImpl::create):
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::~RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::requestSucceeded):
(WebCore::RTCStatsRequestImpl::stop):
(WebCore::RTCStatsRequestImpl::clear):

  • Modules/mediastream/RTCStatsRequestImpl.h: Added.

(WebCore):
(RTCStatsRequestImpl):

  • Modules/mediastream/RTCStatsResponse.cpp: Added.

(WebCore):
(WebCore::RTCStatsResponse::create):
(WebCore::RTCStatsResponse::RTCStatsResponse):

  • Modules/mediastream/RTCStatsResponse.h: Added.

(WebCore):
(RTCStatsResponse):
(WebCore::RTCStatsResponse::result):

  • Modules/mediastream/RTCStatsResponse.idl: Added.
  • WebCore.gypi:
  • platform/chromium/support/WebRTCStatsRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.

(WebKit):
(WebKit::WebRTCStatsRequest::WebRTCStatsRequest):
(WebKit::WebRTCStatsRequest::assign):
(WebKit::WebRTCStatsRequest::reset):
(WebKit::WebRTCStatsRequest::requestSucceeded):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCStatsRequest.h: Copied from Source/WebCore/platform/mediastream/RTCPeerConnectionHandler.h.

(WebCore):
(RTCStatsRequest):
(WebCore::RTCStatsRequest::~RTCStatsRequest):
(WebCore::RTCStatsRequest::RTCStatsRequest):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::getStats):
(WebCore):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

Patch by Harald Tveit Alvestrand <​harald@alvestrand.no> on 2012-09-26
Reviewed by Adam Barth.

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(RTCStatsRequestSucceededTask):
(RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
(MockWebRTCPeerConnectionHandler::getStats):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

Patch by Harald Tveit Alvestrand <​harald@alvestrand.no> on 2012-09-26
Reviewed by Adam Barth.

  • fast/mediastream/RTCPeerConnection-stats-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-stats.html: Added.
9:12 AM Changeset in webkit [129653] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2][WTR] Policy client: dumping from decidePolicyForResponse callback
​https://bugs.webkit.org/show_bug.cgi?id=97034

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-09-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Exported WebCore::ResourceResponseBase::isAttachment() method for MAC port.

No new tests. No functionality added.

  • WebCore.exp.in:

Source/WebKit2:

Added suggested filename getter to WKURLResponse interface and also added a property showing whether the response
is attachment.

  • Shared/API/c/WKURLResponse.cpp:

(WKURLResponseSuggestedFilename):
(WKURLResponseIsAttachment):

  • Shared/API/c/WKURLResponse.h:

Tools:

Provided dumping from WTR Policy client 'decidePolicyForResponse' callback.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::decidePolicyForResponse):

LayoutTests:

Unskipped some of http/tests/download tests from wk2/Skipped, put those which still fail
to an appropriate group in wk2/Skipped file. All of the http/tests/download tests still fail
for EFL WK1.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/wk2/Skipped:
9:00 AM Changeset in webkit [129652] by beidson@apple.com
  • 8 edits in trunk/Source/WebCore

(Threaded scrolling) WebKit not scrolling to the correct location upon going back on macsurfer.com
<rdar://problem/12039913> and ​https://bugs.webkit.org/show_bug.cgi?id=97617

Reviewed by Anders Carlsson.

In the asynchronous land of threaded scrolling we lose the information about whether or not a scroll
is programmatic.

This caused all scrolls to be treated as user scrolls and to generated scroll events.

We can fix this by passing the programmatic bit to the scrolling thread and re-applying it back in the main thread.

Unable to test threaded scrolling at this time.

Include the "Is programmatic scroll" bit in the scroll state:

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setRequestedScrollPosition): Also set whether or not this represents a programmatic scroll.

  • page/scrolling/ScrollingTreeState.h:

(ScrollingTreeState):
(WebCore::ScrollingTreeState::representsProgrammaticScroll):

Pass that bit back to the ScrollingCoordinator:

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::commitNewTreeState):
(WebCore::ScrollingTree::updateMainFrameScrollPosition):

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::requestScrollPositionUpdate): Pass the "is programmatic scroll" bit to the scrolling thread.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition): Reset the "is programmatic scroll" bit on the FrameView.

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/FrameView.h:

(FrameView):
(WebCore::FrameView::inProgrammaticScroll): Expose setter/getters for the programmatic scroll flag.
(WebCore::FrameView::setInProgrammaticScroll):

8:53 AM Changeset in webkit [129651] by Martin Robinson
  • 19 edits in trunk

[GTK] Use XDamage to simplify RedirectedXCompositeWindow
​https://bugs.webkit.org/show_bug.cgi?id=97267

Reviewed by Alejandro G. Castro.

Use XDamage to queue redraws of the widget when redirecting accelerated compositing
to an offscreen window. This allows removing a finicky timer-based approach, improves
performance, and allows simplifying things greatly.

.:

  • configure.ac: Add support for finding XDamage via pkg-config.

Source/WebCore:

No new tests. This is covered by existing tests.

  • GNUmakefile.am: Add the XDamage CFLAGS in the appropriate place.
  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::getWindowHashMap): Added.
(WebCore::filterXDamageEvent): Added.
(WebCore::supportsXDamageAndXComposite): Added.
(WebCore::RedirectedXCompositeWindow::create): Fail to create the window if
the XServer doesn't support XDamage and XComposite.
(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow): Add XDamage support and
remove the m_usable size distinction. Add the window the window HashMap now.
(WebCore::RedirectedXCompositeWindow::~RedirectedXCompositeWindow): Remove the window
from the window HashMap.
(WebCore::RedirectedXCompositeWindow::resize): Now just immediately update the size.
(WebCore::RedirectedXCompositeWindow::callDamageNotifyCallback): Added.

  • platform/gtk/RedirectedXCompositeWindow.h:

(WebCore::RedirectedXCompositeWindow::setDamageNotifyCallback): Added.

Source/WebKit/gtk:

  • GNUmakefile.am: Add the XDamage CFLAGS and LIBS.
  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext): Change the signature of compositeLayersToContext
to accept an enum that explains the composite purpose.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::redirectedWindowDamagedCallback): Added.
(WebKit::AcceleratedCompositingContext::initialize): Handle the situation where
the RedirectedXCompositeWindow returns a null pointer.
(WebKit::AcceleratedCompositingContext::enabled): Ditto.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): Remove the code handling
the usable size of the RedirectedXCompositeWindow. The usable size is now always equal
to the size.
(WebKit::AcceleratedCompositingContext::compositeLayersToContext): When drawing for a
resize, first clear the entire context. Remove the double swap-buffer, as it's no
longer necessary.
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer): Handle the case that
the redirected window is null.
(WebKit::AcceleratedCompositingContext::resizeRootLayer): Instead of doing another
immediate layer flush, just recomposite the current layer state and schedule a new
flush. This should make resizing faster.
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers): We no longer need to
queue a redraw, unless we want to force one.

Source/WebKit2:

  • GNUmakefile.am: Add the XDamage CFLAGS and LIBS to the appropriate places.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Remove readyToRenderAcceleratedCompositingResults as
it's no longer necessary.
(webkit_web_view_base_init): Handle the situation where the RedirectedXCompositeWindow
is null.
(webkitWebViewRenderAcceleratedCompositingResults): Ditto.
(resizeWebKitWebViewBaseFromAllocation): Ditto.
(webkitWebViewBaseCreateWebPage): Ditto.
(redirectedWindowDamagedCallback): Added.

  • UIProcess/WebPageProxy.h: Remove InvalidateWidget message.
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • UIProcess/gtk/WebPageProxyGtk.cpp: Ditto.
  • WebProcess/WebPage/WebPage.h: Ditto.
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::compositeLayersToContext): No longer need to
trigger the invalidateWindow message.

  • WebProcess/WebPage/gtk/WebPageGtk.cpp: Ditto.
8:27 AM Changeset in webkit [129650] by schenney@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed Chromium expectations update.

  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
8:21 AM Changeset in webkit [129649] by loislo@chromium.org
  • 12 edits
    1 copy in trunk/Source

Web Inspector: NMI: replace manual JS external resources counting with MemoryInstrumentation
​https://bugs.webkit.org/show_bug.cgi?id=97662

Reviewed by Yury Semikhatsky.

Source/WebCore:

Old schema uses sizeInBytes method on StringImpl. This method works incorrect for substrings.
Also we'd like to know exact pointers to strings and buffers for verification purposes.

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCoreMemoryTypes):

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::collectDomTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

Source/WebKit/chromium:

Old schema used sizeInBytes method on StringImpl. This method works incorrect for substrings.
Also we'd like to know exact pointers to strings and buffers for verification purposes.

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::TEST):
(WebCore):

Source/WTF:

Old schema uses sizeInBytes method on StringImpl. This method works incorrect for substrings.
Also we'd like to know exact pointers to strings and buffers for verification purposes.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/MemoryInstrumentationArrayBufferView.h:

(WTF):
(WTF::reportMemoryUsage):

8:19 AM Changeset in webkit [129648] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [REGRESSION] Revision support problems: revert and apply original content cause exceptions
​https://bugs.webkit.org/show_bug.cgi?id=97669

Reviewed by Pavel Feldman.

Source/WebCore:

Added missed callback parameters.

Test: inspector/uisourcecode-revisions.html

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):

LayoutTests:

  • inspector/uisourcecode-revisions-expected.txt: Added.
  • inspector/uisourcecode-revisions.html: Added.
8:17 AM Changeset in webkit [129647] by kenneth@webkit.org
  • 23 edits in trunk/Source/WebCore

Reorder Qt WebCore includes
​https://bugs.webkit.org/show_bug.cgi?id=97678

Reviewed by Noam Rosenthal.

  • bridge/qt/qt_instance.cpp:
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_pixmapruntime.cpp:
  • bridge/qt/qt_runtime.cpp:
  • platform/graphics/qt/FontCacheQt.cpp:
  • platform/graphics/qt/FontCustomPlatformData.h:
  • platform/graphics/qt/ImageDecoderQt.cpp:
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/graphics/qt/PathQt.cpp:
  • platform/graphics/qt/TransformationMatrixQt.cpp:
  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
  • platform/network/qt/DnsPrefetchHelper.h:
  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/qt/ResourceHandleQt.cpp:
  • platform/qt/ClipboardQt.cpp:
  • platform/qt/GamepadsQt.cpp:
  • platform/qt/PasteboardQt.cpp:
  • platform/qt/PlatformScreenQt.cpp:
  • platform/qt/RenderThemeQt.cpp:
  • platform/text/qt/TextBoundariesQt.cpp:
  • plugins/qt/PluginPackageQt.cpp:
  • plugins/qt/PluginViewQt.cpp:
8:13 AM Changeset in webkit [129646] by commit-queue@webkit.org
  • 23 edits
    1 add in trunk

[EFL] mediaControlsEflFullscreen.css overrides regular media controls styling
​https://bugs.webkit.org/show_bug.cgi?id=97671

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add missing ":-webkit-full-screen" in mediaControlsEflFullscreen.css so
that regular media controls styling is not overridden by full screen
styling when switching to full screen mode. This was causing a lot of
flakiness in our media tests.

No new tests, already covered by existing media tests.

  • css/mediaControlsEflFullscreen.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen:-webkit-full-page-media::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-mute-button):
(video:-webkit-full-screen::-webkit-media-controls-play-button):
(video:-webkit-full-screen::-webkit-media-controls-timeline-container):
(video:-webkit-full-screen::-webkit-media-controls-current-time-display):
(video:-webkit-full-screen::-webkit-media-controls-time-remaining-display):
(video:-webkit-full-screen::-webkit-media-controls-timeline):
(video:-webkit-full-screen::-webkit-media-controls-volume-slider-container):
(video:-webkit-full-screen::-webkit-media-controls-volume-slider):
(video:-webkit-full-screen::-webkit-media-controls-seek-back-button):
(video:-webkit-full-screen::-webkit-media-controls-seek-forward-button):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-button):
(video:-webkit-full-screen::-webkit-media-controls-rewind-button):
(video:-webkit-full-screen::-webkit-media-controls-return-to-realtime-button):
(video:-webkit-full-screen::-webkit-media-controls-toggle-closed-captions-button):

LayoutTests:

Unskip several media tests that are no longer flaky
now that we address media controls styling issues
when switching to full screen mode.

Some tests needed rebaselining. The rebaseline is unrelated
to this change but was needed in order to unskip the tests.

  • platform/efl/TestExpectations:
  • platform/efl/media/controls-after-reload-expected.png:
  • platform/efl/media/controls-after-reload-expected.txt:
  • platform/efl/media/controls-strict-expected.png:
  • platform/efl/media/controls-strict-expected.txt:
  • platform/efl/media/controls-styling-expected.png:
  • platform/efl/media/controls-styling-expected.txt:
  • platform/efl/media/controls-without-preload-expected.png:
  • platform/efl/media/controls-without-preload-expected.txt:
  • platform/efl/media/media-controls-clone-expected.png:
  • platform/efl/media/media-controls-clone-expected.txt:
  • platform/efl/media/media-document-audio-repaint-expected.txt:
  • platform/efl/media/sources-fallback-codecs-expected.txt: Added.
  • platform/efl/media/video-controls-rendering-expected.png:
  • platform/efl/media/video-controls-rendering-expected.txt:
  • platform/efl/media/video-display-toggle-expected.png:
  • platform/efl/media/video-display-toggle-expected.txt:
  • platform/efl/media/video-empty-source-expected.png:
  • platform/efl/media/video-empty-source-expected.txt:
  • platform/efl/media/video-zoom-controls-expected.png:
  • platform/efl/media/video-zoom-controls-expected.txt:
8:04 AM Changeset in webkit [129645] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: display stack of last layout invalidation instead of first one
​https://bugs.webkit.org/show_bug.cgi?id=97677

Reviewed by Vsevolod Vlasov.

  • add a call to InspectorInstrumentation::didInvalidateLayout() when upgrading relayout root;
  • do not suppress timeline's Invalidate Layout records other than first.
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didInvalidateLayout):

  • page/FrameView.cpp:

(WebCore::FrameView::scheduleRelayoutOfSubtree):

7:52 AM Changeset in webkit [129644] by Antti Koivisto
  • 6 edits
    1 add in trunk

Optimize stylesheet insertions
​https://bugs.webkit.org/show_bug.cgi?id=97627

Reviewed by Andreas Kling.

PerformanceTests:

Add synthetic performance test for avoiding style recalcs on stylesheet inserts.

  • CSS/StyleSheetInsert.html: Added.

Source/WebCore:

We currently do scope analysis for stylesheets that are added to the end of the active stylesheet list to avoid unnecessary style
recalcs and StyleResolver rebuilding. However it is somewhat common to insert <style> elements dynamically to positions other than last.
In this case we currently simply force full style recalc. We should do scope analysis and partial style recalcs also in these cases.

PerformanceTests/CSS/StyleSheetInsert.html microbenchmark shows ~20x progression from the patch.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::resetAuthorStyle):

Add a way to reset author RuleSet without deleting the whole StyleResolver.

(WebCore):

  • css/StyleResolver.h:

(StyleResolver):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):

Check if there have been insertions to the stylesheet list. If so we need to reset
the StyleResolver (to handle rule position changes) but don't need to force full
style recalc. Do scope analysis for inserted stylesheets as well.

(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

  • dom/DocumentStyleSheetCollection.h:
7:35 AM Changeset in webkit [129643] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Gesture tap highlighting entire first line
​https://bugs.webkit.org/show_bug.cgi?id=97668

Patch by Allan Sandfeld Jensen <​allan.jensen@digia.com> on 2012-09-26
Reviewed by Kenneth Rohde Christiansen.

Keep better track if which part is the first, middle or last, and adjust the X-edges accordingly.

  • page/GestureTapHighlighter.cpp:
7:35 AM Changeset in webkit [129642] by peter@chromium.org
  • 2 edits
    408 adds in trunk/LayoutTests

[Chromium] First part of rebaselines for the fast/ directory.

Unreviewed rebaselining.

First part of the baselines for fast/. Most of these address, once again, the
different scrollbar appearance, layout size (due to overlay scrollbars) and
text selection color. Notable failures include that Kanji characters are
rendered bold and Android seems to limit styling abilities for selection text.
Bugs will be filed for these failures.

General info about the initial baselining is available in bug 96398.

  • platform/chromium-android/fast/backgrounds/: 7 new results.
  • platform/chromium-android/fast/body-propagation/: 38 new results.
  • platform/chromium-android/fast/borders/: 32 new results.
  • platform/chromium-android/fast/box-shadow/: 2 new results..
  • platform/chromium-android/fast/box-sizing/: 2 new results.
  • platform/chromium-android/fast/canvas/: 7 new results.
  • platform/chromium-android/fast/clip/: 2 new results.
  • platform/chromium-android/fast/css-generated-content/: 4 new results.
  • platform/chromium-android/fast/css/: 77 new results.
  • platform/chromium-android/fast/dom/: 20 new results.
  • platform/chromium-android/fast/dynamic/: 7 new results.
  • platform/chromium-android/fast/encoding/: 4 new results.
  • platform/chromium-android/fast/events/: 7 new results.
  • platform/chromium-android/fast/flexbox/: 6 new results.
  • platform/chromium-android/fast/forms/: 25 new results.
  • platform/chromium-android/fast/frames/: 20 new results.
  • platform/chromium-android/fast/gradients/: 5 new results.
  • platform/chromium-android/fast/hidpi/: 2 new results.
  • platform/chromium-android/fast/html/: 4 new results.
  • platform/chromium-android/fast/images/: 6 new images.
  • platform/chromium-android/fast/inline-block/: 2 new results.
  • platform/chromium-android/fast/inline/: 8 new results.
  • platform/chromium-android/fast/invalid/: 2 new results.
  • platform/chromium-android/fast/js/: 2 new results.
  • platform/chromium-android/fast/layers/: 6 new results.
  • platform/chromium-android/fast/line-grid/: 4 new results.
  • platform/chromium-android/fast/lists/: 16 new results.
  • platform/chromium-android/fast/media/: 24 new results.
  • platform/chromium-android/fast/reflections/: 2 new results.
  • platform/chromium-android/fast/replaced/: 9 new results.
  • platform/chromium-android/fast/selectors/: 3 new results.
  • platform/chromium-android/fast/sub-pixel/: 3 new results.
  • platform/chromium-android/fast/transforms/: 4 new results.
  • platform/chromium-android/fast/writing-mode/: 15 new results.
  • platform/chromium-android/platform/chromium/fast/text/: 1 new result.
7:23 AM Changeset in webkit [129641] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: DefaultTextEditor throws exception sometimes.
​https://bugs.webkit.org/show_bug.cgi?id=97681

Reviewed by Alexander Pavlov.

Added a check that line number does not exceed text model line count.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._positionToSelection):

7:23 AM Changeset in webkit [129640] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt][WTR] Build fix for MSVC.
​https://bugs.webkit.org/show_bug.cgi?id=97667

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-09-26
Reviewed by Csaba Osztrogonác.

WTR misses InjectedBundle headers. Adding $$PWD to Target.pri is required for MSVC. Clean build is necessary on Windows.

  • WebKitTestRunner/InjectedBundle/Target.pri:
7:14 AM Changeset in webkit [129639] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip http/tests/security/xss-eval.html again after r129629.

  • platform/qt/Skipped:
7:12 AM Changeset in webkit [129638] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebCore

[TextureMapper] Remove unused method
​https://bugs.webkit.org/show_bug.cgi?id=97675

Reviewed by Simon Hausmann.

  • platform/graphics/texmap/TextureMapperGL.h: Remove uidForImage()
7:10 AM Changeset in webkit [129637] by loislo@chromium.org
  • 21 edits
    2 copies in trunk/Source

Web Inspector: extract HashSet instrumentation from core NMI code and put it into MemoryInstrumentationHashSet.h
​https://bugs.webkit.org/show_bug.cgi?id=97198

Reviewed by Yury Semikhatsky.

Current implementation has overloads for HashSet.
This prevents us from instrumenting complex cases like Vector<HashSet<...> >.

Source/WebCore:

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::Features::reportMemoryUsage):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::reportMemoryUsage):

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::TEST):
(WebCore):

Source/WTF:

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/HashSet.h:

(WTF):
(HashSet):

  • wtf/HashTable.h:

(WTF):
(HashTable):

  • wtf/MemoryInstrumentation.h:

(WTF::MemoryClassInfo::addCollectionElements):
(WTF::MemoryClassInfo::addHashCountedSet):

  • wtf/MemoryInstrumentationHashSet.h: Added.

(WTF):
(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashTable.h: Added.

(WTF):
(WTF::reportMemoryUsage):

7:08 AM Changeset in webkit [129636] by dominik.rottsches@intel.com
  • 3 edits in trunk/Source/WebCore

[soup] Obey setTimeoutInterval in soup backend
​https://bugs.webkit.org/show_bug.cgi?id=94796

Reviewed by Gustavo Noronha Silva.

Implementing ResourceHandle's setTimeoutInterval support for the soup backend.
This is preparatory work for bug 74802, timeout support for XHR2. The patch
has been successfully tested in combination with my work-in-progress
for that bug.

No new tests yet, tests will be added with the patch in bug 74802.

  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal): Adding a timeout source.
(ResourceHandleInternal):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::cleanupSoupRequestOperation): Resetting the timer.
(WebCore::sendRequestCallback): Stopping the timer.
(WebCore::startHTTPRequest): Starting a timeout timer before the async request.
(WebCore::ResourceHandle::platformSetDefersLoading): Starting a timeout timer before the async request.
(WebCore::requestTimeoutCallback): Preparing a corresponding resource error and notifying clients of failure.
(WebCore::startNonHTTPRequest): Starting a timeout timer before the async request.

7:08 AM Changeset in webkit [129635] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening after r129629.

Marking http/tests/security/xss-eval.html as failing again because of the fix being rolled out.

  • platform/efl/TestExpectations:
7:07 AM Changeset in webkit [129634] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] [DRT] eventSender.keyDown() doesn't support Ctrl key modifier
​https://bugs.webkit.org/show_bug.cgi?id=97665

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2012-09-26
Reviewed by Rob Buis.

This patch fixes test fast/forms/input-text-option-delete.html.

  • DumpRenderTree/blackberry/EventSender.cpp:

(keyDownCallback):

7:05 AM Changeset in webkit [129633] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: paint inspector overlay on a transparency layer
​https://bugs.webkit.org/show_bug.cgi?id=97659

Reviewed by Pavel Feldman.

Set composite operation to copy and begin transparency layer before painting the

frame view of overlay page, so that text on transparent background is properly rendered.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint):

7:03 AM Changeset in webkit [129632] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Make use of ASCIILiteral in PlatformKeyboardEventQt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=97612

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-09-26
Reviewed by Jocelyn Turcotte.

String literals returned by keyIdentifierForQtKeyCode and
keyTextForKeyEvent now make use of more efficient ASCIILiteral.

  • platform/qt/PlatformKeyboardEventQt.cpp:

(WebCore::keyIdentifierForQtKeyCode):
(WebCore::keyTextForKeyEvent):

6:28 AM Changeset in webkit [129631] by dinu.s.jacob@intel.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
6:28 AM Changeset in webkit [129630] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Added failure expectations for fast/js tests:
fast/js/string-localeCompare.html
fast/js/dfg-array-push-bad-time.html
fast/js/dfg-array-push-slow-put.html

  • platform/chromium/TestExpectations:
6:21 AM Changeset in webkit [129629] by commit-queue@webkit.org
  • 11 edits in trunk

Unreviewed, rolling out r129592.
​http://trac.webkit.org/changeset/129592
​https://bugs.webkit.org/show_bug.cgi?id=97670

Failures in Chromium security tests (Requested by schenney on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-26

Source/JavaScriptCore:

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

LayoutTests:

  • fast/js/eval-cross-window-expected.txt:
  • fast/js/eval-cross-window.html:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/resources/xss-eval2.html:
  • http/tests/security/resources/xss-eval3.html:
  • http/tests/security/xss-eval-expected.txt:
  • http/tests/security/xss-eval.html:
6:16 AM Changeset in webkit [129628] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Roll out ​http://trac.webkit.org/changeset/129502 since it broke cookie table.
​https://bugs.webkit.org/show_bug.cgi?id=97471

  • inspector/front-end/CookieParser.js:

(WebInspector.Cookie.prototype.expires):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable.prototype._createGridNode):

5:55 AM Changeset in webkit [129627] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

[GTK] Remove color codes characters from run-gtk-tests output when not writing to a TTY
​https://bugs.webkit.org/show_bug.cgi?id=97660

Reviewed by Philippe Normand.

Remove also the '\r' characters returned by TTY output to try to fix
the double line endings of the script output in the bots.

  • Scripts/run-gtk-tests:

(TestRunner.init): Compile a regexp for color codes if stdout
it not a TTY.
(TestRunner._run_test_command.parse_line): Remove color codes and
'\r' characters from the line returned by the pseudo-terminal if
stdout is not a TTY.

  • gtk/common.py:

(parse_output_lines): Fix the last chunk check to make sure we
always send entire lines to the callback, otherwise color codes
regexp might fail if the line is not complete.

5:52 AM Changeset in webkit [129626] by vsevik@chromium.org
  • 21 edits in trunk

Web Inspector: Remove resource() getter from UISourceCode.
​https://bugs.webkit.org/show_bug.cgi?id=97557

Reviewed by Pavel Feldman.

Source/WebCore:

Resource getter removed from UISourceCode. Resource could be fetched from ResourceTreeModel directly.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModelResourceBinding.prototype.setStyleContent):

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSource):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):

  • inspector/front-end/StyleSource.js:

(WebInspector.StyleSource):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

LayoutTests:

  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/ui-source-code-display-name.html:
  • inspector/debugger/ui-source-code.html:
5:50 AM Changeset in webkit [129625] by vsevik@chromium.org
  • 12 edits in trunk/Source/WebCore

Web Inspector: Fix closure compilation errors.
​https://bugs.webkit.org/show_bug.cgi?id=97666

Reviewed by Alexander Pavlov.

Fixed closure compilation errors.
Changed contentProvider contentURL() method return type to string.
Removed redundant () in CookieTable.

  • inspector/front-end/CSSStyleModel.js:
  • inspector/front-end/ContentProvider.js:
  • inspector/front-end/ContentProviders.js:

(WebInspector.ConcatenatedScriptsContentProvider.prototype.contentURL):
(WebInspector.StaticContentProvider.prototype.contentURL):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable.prototype._createGridNode):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMDocument):

  • inspector/front-end/FileContentView.js:
  • inspector/front-end/NetworkRequest.js:
  • inspector/front-end/Resource.js:
  • inspector/front-end/Script.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/UISourceCode.js:
5:25 AM Changeset in webkit [129624] by caseq@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [chromium] add a test for inspector overlay update frequency
​https://bugs.webkit.org/show_bug.cgi?id=97567

Reviewed by Yury Semikhatsky.

Added a test for reasonable number of frames caused by inspector page overlay.
We expect changes in nodes being inspected to cause an update, while just idling
should not cause large numbers of unexpected updates.

  • src/js/Tests.js:

(.TestSuite.prototype.testPageOverlayUpdate):
(.TestSuite.prototype.testPageOverlayUpdate.innerAddRecord):
(.TestSuite.prototype.testPageOverlayUpdate.populatePage):
(.TestSuite.prototype.testPageOverlayUpdate.step2):
(.TestSuite.prototype.testPageOverlayUpdate.step4):
(.TestSuite.prototype.testPageOverlayUpdate.step5):

5:09 AM Changeset in webkit [129623] by yurys@chromium.org
  • 15 edits in trunk/Source

Web Inspector: compare objects counted by the memory instrumentation with those allocated in the heap
​https://bugs.webkit.org/show_bug.cgi?id=97641

Reviewed by Pavel Feldman.

Source/WebCore:

Added code that allows to check if all objects counted by the memory instrumentation
were allocated by the underlying memory allocator. It requires support
from the memory allocator. The code works only if the set of allocated objects
is not empty and should only be used for debugging purposes.

  • inspector/InspectorClient.h:

(InspectorClient):
(WebCore::InspectorClient::getAllocatedObjects):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::collectDomTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

  • inspector/InspectorMemoryAgent.h:

(WebCore):
(WebCore::InspectorMemoryAgent::create):
(InspectorMemoryAgent):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::countObjectSize):
(WebCore):
(WebCore::MemoryInstrumentationImpl::checkCountedObject):

  • inspector/MemoryInstrumentationImpl.h:

(MemoryInstrumentationImpl):

Source/WebKit/chromium:

Added code that allows to check if all objects counted by the memory instrumentation
were allocated by the underlying memory allocator. It requires support
from the memory allocator this is why WebDevToolsAgentClient API is extended with a
method that allows to visit pointers to all live heap objects if the memory allocator
supports that.

The code should only be used for debugging purposes.

  • public/WebDevToolsAgentClient.h:

(AllocatedObjectVisitor):
(WebKit::WebDevToolsAgentClient::AllocatedObjectVisitor::~AllocatedObjectVisitor):
(WebKit::WebDevToolsAgentClient::visitAllocatedObjects):
(WebDevToolsAgentClient):

  • src/InspectorClientImpl.cpp:

(WebKit):
(WebKit::InspectorClientImpl::getAllocatedObjects):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit):
(WebKit::WebDevToolsAgentImpl::getAllocatedObjects):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

Source/WTF:

Added a method for checking if reported object was actually allocated in the heap.

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WTF::MemoryInstrumentation::addObjectImpl):

4:50 AM Changeset in webkit [129622] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

SuggestionPicker min width is two pixels wider than it should be
​https://bugs.webkit.org/show_bug.cgi?id=97645

Reviewed by Kent Tamura.

Suggestion picker's minimum width should match inputWidth.

No new tests. Added later in Bug 97645.

  • Resources/pagepopups/suggestionPicker.js:

(SuggestionPicker.prototype._measureMaxContentWidth):
(SuggestionPicker.prototype._fixWindowSize): We shouldn't be adding ListBorder to inputWidth.

4:27 AM Changeset in webkit [129621] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectations for <style scoped> tests as the feature is
not being enabled at runtime in WebKitTestRunner.

  • platform/gtk-wk2/TestExpectations:
4:09 AM Changeset in webkit [129620] by rakuco@webkit.org
  • 142 edits in trunk/LayoutTests

[EFL] Rebaseline some remaining tables/mozilla_expected_failures tests.
​https://bugs.webkit.org/show_bug.cgi?id=95489

  • platform/efl/TestExpectations:
  • platform/efl/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/97619-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/standards1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:
4:05 AM Changeset in webkit [129619] by peter@chromium.org
  • 1 edit
    162 adds in trunk/LayoutTests

[Chromium] Rebaselines for svg/ and tables/ for Android.

Unreviewed baselining.

Most differences are caused by Android's text selection color, and a few because of
reduced image resize quality and scrollbars. Real issues include slightly different
rendering for controls (most notable <button> and <select>), bugs for which will
be filed as well. General info about the initial baselining is available in bug 96398.

  • platform/chromium-android/svg/: 135 new results.
  • platform/chromium-android/tables/: 13 new results.
3:54 AM WebKit Team edited by mkwst@chromium.org
Adding myself to the committers list. (diff)
3:08 AM Changeset in webkit [129618] by peter@chromium.org
  • 1 edit
    163 adds in trunk/LayoutTests

[Chromium] Rebaseline tests in css2.1/, css3/ and editing/ for Android

Unreviewed rebaselining.

Many differences are due to Android's scrollbars and different text selection
color. Various real failures showed up as well, I'll be filing separate bugs
for these. General info about the initial baselining is available in bug 96398.

  • platform/chromium-android/css2.1/: 3 new results.
  • platform/chromium-android/css3/: 25 new results.
  • platform/chromium-android/editing/: 123 new results.
2:44 AM Changeset in webkit [129617] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening after r126983.

  • platform/efl/TestExpectations: Marking the RefTest harness check as WontFix as in Chromium.
2:26 AM Changeset in webkit [129616] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Unskip test that seems to pass consistently on 32-bits.

It looks like the rounding issues are gone now that we use
jhbuild. While here, update the expected PNG, which was valid
before but had a different pixel hash.

  • platform/efl/TestExpectations:
  • platform/efl/fast/css/percentage-non-integer-expected.png:
2:26 AM Changeset in webkit [129615] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Mark one subpixel test added in r129529 as passing.
Reclassify fast/workers/shared-worker-load-error.html as flaky.
Remove expectations for fast/css/word-spacing-characters.html and
http/tests/security/xss-eval.html, both tests are now passing.

  • platform/gtk/TestExpectations:
2:17 AM Changeset in webkit [129614] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip test that seems to be passing now.

  • platform/efl/Skipped:
2:08 AM Changeset in webkit [129613] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: [TextEditor] fix tab unindent selection restore
​https://bugs.webkit.org/show_bug.cgi?id=97462

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-26
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Selection would be wrongly restored on tab unindent when the last line does not need to be unindented unlike the others.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._unindentLines.get var):
(WebInspector.TextEditorMainPanel.prototype._unindentLines):

LayoutTests:

Added test for an unindentation corner case.

  • inspector/editor/indentation-expected.txt:
  • inspector/editor/indentation.html:
2:01 AM Changeset in webkit [129612] by yosin@chromium.org
  • 47 edits in trunk

Source/WebCore: Rename ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS to ENABLE_INPUT_MULTIPLE_FIELDS_UI
​https://bugs.webkit.org/show_bug.cgi?id=97640

This patch renames ENABLE_INPUT_TYPE_TIME MULTIPLE_FIELDS feature
flag to ENABLE_INPUT_MULTIPLE_FIELDS_UI for implementing multiple
fields date/time input UI other than input type "time".

No new tests. This patch doesn't change behavior.

  • css/html.css:
  • css/themeWin.css:
  • html/DateTimeFieldsState.cpp:
  • html/DateTimeFieldsState.h:
  • html/TimeInputType.cpp:

(WebCore):

  • html/TimeInputType.h:

(TimeInputType):

  • html/shadow/DateTimeEditElement.cpp:
  • html/shadow/DateTimeEditElement.h:
  • html/shadow/DateTimeFieldElement.cpp:
  • html/shadow/DateTimeFieldElement.h:
  • html/shadow/DateTimeFieldElements.cpp:
  • html/shadow/DateTimeFieldElements.h:
  • html/shadow/DateTimeNumericFieldElement.cpp:
  • html/shadow/DateTimeNumericFieldElement.h:
  • html/shadow/DateTimeSymbolicFieldElement.cpp:
  • html/shadow/DateTimeSymbolicFieldElement.h:
  • platform/LocalizedStrings.h:

(WebCore):

  • platform/text/DateTimeFormat.cpp:
  • platform/text/DateTimeFormat.h:
  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::LocaleICU):
(WebCore::LocaleICU::~LocaleICU):
(WebCore):

  • platform/text/LocaleICU.h:

(LocaleICU):

  • platform/text/LocaleWin.cpp:

(WebCore):

  • platform/text/LocaleWin.h:

(LocaleWin):

  • platform/text/LocalizedNumber.h:

(WebCore):

  • platform/text/LocalizedNumberICU.cpp:

(WebCore):

  • platform/text/LocalizedNumberNone.cpp:

(WebCore):

  • platform/text/Localizer.cpp:

(WebCore):

  • platform/text/Localizer.h:

(Localizer):

  • platform/text/mac/LocaleMac.h:

(LocaleMac):

  • platform/text/mac/LocaleMac.mm:

(WebCore):

  • platform/text/mac/LocalizedNumberMac.mm:

(WebCore):

  • platform/text/win/LocalizedNumberWin.cpp:

(WebCore):

Source/WebKit/chromium: Rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to ENABLE_INPUT_MULTIPLE_FIELDS_UI
​https://bugs.webkit.org/show_bug.cgi?id=97640

Reviewed by Kent Tamura.

This patch renames ENABLE_INPUT_TYPE_TIME MULTIPLE_FIELDS feature
flag to ENABLE_INPUT_MULTIPLE_FIELDS_UI for implementing multiple
fields date/time input UI other than input type "time".

  • features.gypi:
  • src/LocalizedStrings.cpp:

(WebCore):

  • tests/DateTimeFormatTest.cpp:
  • tests/LocaleMacTest.cpp:

(LocaleMacTest):

  • tests/LocaleWinTest.cpp:

(LocaleWinTest):

  • tests/LocalizedDateICUTest.cpp:
  • tests/LocalizedNumberICUTest.cpp:

LayoutTests: Rename ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS to ENABLE_INPUT_MULTIPLE_FIELDS_UI
​https://bugs.webkit.org/show_bug.cgi?id=97640

This patch renames ENABLE_INPUT_TYPE_TIME MULTIPLE_FIELDS feature
flag to ENABLE_INPUT_MULTIPLE_FIELDS_UI for implementing multiple
fields date/time input UI other than input type "time".

  • platfrom/efl/TestExpectations: Update a comment which refers ENABLE_INPUT_TYPE_TIME MULTIPLE_FIELDS.
  • platform/mac/Skipped: ditto.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.
  • platform/wincairo/Skipped: ditto.
1:50 AM Changeset in webkit [129611] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip that passes after r125813.

  • platform/efl/TestExpectations:
1:39 AM Changeset in webkit [129610] by rakuco@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Rebaseline after r125578.

  • platform/efl/TestExpectations:
  • platform/efl/fast/css/word-space-extra-expected.png:
  • platform/efl/fast/css/word-space-extra-expected.txt:
1:38 AM Changeset in webkit [129609] by Simon Hausmann
  • 5 edits
    23 deletes in trunk

[Qt] Remove Qt Quick 1 support

Reviewed by Kenneth Rohde Christiansen.

It is being moved to the Qt5 QtQuick1 module.

.:

  • Source/tests.pri:

Source/WebKit/qt:

A circular dependency exists otherwise in Qt, where QtWebKit would depend on QtQuick1,
which in turn depends on QtTools (for designer plugin), which in turn depends on QtWebKit
(for assistant help html rendering).

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

  • declarative/public.pri:
  • declarative/qdeclarativewebview.cpp: Removed.
  • declarative/qdeclarativewebview_p.h: Removed.
  • tests/qdeclarativewebview/qdeclarativewebview.pro: Removed.
  • tests/qdeclarativewebview/resources/basic.html: Removed.
  • tests/qdeclarativewebview/resources/basic.png: Removed.
  • tests/qdeclarativewebview/resources/basic.qml: Removed.
  • tests/qdeclarativewebview/resources/elements.html: Removed.
  • tests/qdeclarativewebview/resources/elements.qml: Removed.
  • tests/qdeclarativewebview/resources/forward.html: Removed.
  • tests/qdeclarativewebview/resources/forward.png: Removed.
  • tests/qdeclarativewebview/resources/javaScript.html: Removed.
  • tests/qdeclarativewebview/resources/javaScript.qml: Removed.
  • tests/qdeclarativewebview/resources/loadError.qml: Removed.
  • tests/qdeclarativewebview/resources/newwindows.html: Removed.
  • tests/qdeclarativewebview/resources/newwindows.qml: Removed.
  • tests/qdeclarativewebview/resources/propertychanges.qml: Removed.
  • tests/qdeclarativewebview/resources/sample.html: Removed.
  • tests/qdeclarativewebview/resources/sethtml.qml: Removed.
  • tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Removed.
  • tests/qdeclarativewebview/resources/webviewtest.qml: Removed.
  • tests/qdeclarativewebview/resources/webviewtestdefault.qml: Removed.
  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Removed.
  • tests/qdeclarativewebview/tst_qdeclarativewebview.qrc: Removed.
1:34 AM Changeset in webkit [129608] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviwed gardening.

  • platform/qt/Skipped: Unskip http/tests/security/xss-eval.html after r129592.
1:21 AM Changeset in webkit [129607] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviwed gardening.

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-09-26

  • platform/qt-5.0-wk1/Skipped: skip http/tests/security/cross-origin-local-storage-wk1.html.
  • platform/qt-5.0-wk2/Skipped: skip fast/events/popup-blocked-from-fake-user-gesture.html.
1:02 AM Changeset in webkit [129606] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK1] REGRESSION(r123988) It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail
​https://bugs.webkit.org/show_bug.cgi?id=92636

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-09-26
Reviewed by Csaba Osztrogonác.

Unskip passing test.

  • platform/qt-5.0-wk1/Skipped:
12:41 AM Changeset in webkit [129605] by rakuco@webkit.org
  • 6 edits in trunk

[DRT][WTR] Support overriding the 'WebKitDisplayImagesKey' preference
​https://bugs.webkit.org/show_bug.cgi?id=96883

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Add
support for changing
WebPreferencesKey::loadsImagesAutomaticallyKey().

Tools:

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::overridePreference): Support the
'WebKitDisplayImagesKey' preference.

LayoutTests:

  • platform/efl/TestExpectations: Unskip test that only fails on

WK2.

12:38 AM Changeset in webkit [129604] by zandobersek@gmail.com
  • 12 edits in trunk

[GTK] Enable some of the unstable CSS features
​https://bugs.webkit.org/show_bug.cgi?id=97572

Reviewed by Martin Robinson.

.:

Export the required RuntimeEnabledFeatures symbol.

  • Source/autotools/symbols.filter:

Source/WebCore:

Enable the CSS sticky position, CSS3 text decoration and <style scoped>
features by default but disable them if unstable features are not meant
to be enabled.

No new tests - the related tests are being unskipped or are having failure
expectations removed.

  • GNUmakefile.am:
  • GNUmakefile.features.am:

Source/WebKit/gtk:

Add a helper DumpRenderTreeSupportGtk method for enabling
the <style scoped> support in WebCore. This is used in DumpRenderTree.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setShadowDOMEnabled): Add missing
ENABLE(SHADOW_DOM) compilation guards.
(DumpRenderTreeSupportGtk::setStyleScopedEnabled):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk): Remove the 'enabled' parameter name from both
setShadowDOMEnabled and setStyleScopedEnabled method declarations as it adds
no information and is causing style warnings.

Tools:

Enable the <style scoped> support via DumpRenderTreeSupportGtk method
whenever resetting defualts to consistent values.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests:

Remove expectations for the features being enabled and
add more specific failure expectations for tests that are
still failing.

  • platform/gtk/TestExpectations:
12:33 AM Changeset in webkit [129603] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix the typo in the ewk_view_fullscreen_exit()
​https://bugs.webkit.org/show_bug.cgi?id=97635

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-26
Reviewed by Gyuyoung Kim.

Fix the silly typo in the ewk_view_fullscreen_exit() API.

  • ewk/ewk_view.cpp:

(ewk_view_fullscreen_exit):

12:30 AM Changeset in webkit [129602] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix potential build error on LocalFileSystem::deleteFileSystem
​https://bugs.webkit.org/show_bug.cgi?id=97632

Patch by Dongwoo Joshua Im <​dw.im@samsung.com> on 2012-09-26
Reviewed by Yuta Kitamura.

Non-Chrome build of WebKit with FILE_SYSTEM flag will be broken at LocalFileSystem::deleteFileSystem.
Type of the third parameter is PassOwnPtr<AsyncFileSystemCallbacks> in header file,
but PassRefPtr<AsyncFileSystemCallbacks> in cpp file.

Non-Chrome WebKit build with FILE_SYSTEM should be finished successfully.

  • Modules/filesystem/LocalFileSystem.cpp:

(WebCore::LocalFileSystem::deleteFileSystem):

12:21 AM WebKitGtkLayoutTests edited by Philippe Normand
(diff)
12:20 AM Changeset in webkit [129601] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

String.localeCompare should normalize input
​https://bugs.webkit.org/show_bug.cgi?id=97639

Reviewed by Filip Pizlo.

From the spec: "It is strongly recommended that this function treat Strings that are
canonically equivalent according to the Unicode standard as identical (in other words,
compare the Strings as if they had both been converted to Normalised Form C or D first).
It is also recommended that this function not honour Unicode compatibility equivalences
or decompositions."

Source/WTF:

  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::createCollator):

  • Enable normalization.

LayoutTests:

  • fast/js/script-tests/string-localeCompare.js: Added.
  • fast/js/string-localeCompare-expected.txt: Added.
  • fast/js/string-localeCompare.html: Added.
    • Add lests for localeCompare.
12:18 AM Changeset in webkit [129600] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

REGRESSION (r126189): No more mismatch-did-not-occur failures in reftests
​https://bugs.webkit.org/show_bug.cgi?id=97112

Reviewed by Dirk Pranke.

Don't use the reftest's image hash when gathering output of its reference.
This indirectly forces the driver to return the reference's image output
as well. This specifically solves the problem when the reftest and its
mismatch reference are equal but the unexpected match failure is not
reported due to missing image output of the reference file.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._run_reftest):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.diff_image):
(TestDriver.run_test):

12:03 AM Changeset in webkit [129599] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip passing test after r129592.

  • platform/efl/TestExpectations:

Sep 25, 2012:

11:55 PM Changeset in webkit [129598] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[WIN] Fix ASSERT in BString after r128988.

  • platform/win/BString.cpp:

(WebCore::BString::~BString):
(WebCore::BString::adoptBSTR):
(WebCore::BString::clear): Set pointer to 0 after freeing.

11:06 PM Changeset in webkit [129597] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Update master.cfg to invoke run-perf-tests with --no-show-results and --reset-results
​https://bugs.webkit.org/show_bug.cgi?id=97613

Reviewed by Dirk Pranke.

Use options added in r129580.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunAndUploadPerfTests):

11:03 PM Changeset in webkit [129596] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix non-Mac builds.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

10:58 PM Changeset in webkit [129595] by commit-queue@webkit.org
  • 11 edits in trunk

Web Inspector: Fix logging in pure protocol test harness
​https://bugs.webkit.org/show_bug.cgi?id=97579

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-09-25
Reviewed by Yury Semikhatsky.

Tools:

JavaScript alert implementation in DumpRenderTree gets immediate flush to make sure that
the message survives crash or kill by timeout.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::runJavaScriptAlert):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::runModalAlertDialog):

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onJavaScriptAlert):

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webViewScriptAlert):

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::javaScriptAlert):

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::runJavaScriptAlertPanelWithMessage):

LayoutTests:

Logging facility is fixed and improved for inspector protocol harness.

  • http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.log): proper escaping is added
(InspectorTest.debugLog): new method is added for crash-proof debug messaging

  • http/tests/inspector-protocol/resources/protocol-test.js:

(debugLog): new method is added for crash-proof debug messaging

10:39 PM Changeset in webkit [129594] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/efl

[EFL] Add fullscreen set/get APIs and callbacks
​https://bugs.webkit.org/show_bug.cgi?id=97421

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2012-09-25
Reviewed by Gyuyoung Kim.

Add setting APIs for JavaScript Fullscreen API and also add two callbacks to ewk_view API,
so that UI could customise behavior when fullscreen mode is requested.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::enterFullScreenForElement):
(WebCore::ChromeClientEfl::exitFullScreenForElement):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_fullscreen_get):
(ewk_view_setting_enable_fullscreen_set):
(ewk_view_fullscreen_enter):
(ewk_view_fullscreen_exit):

  • ewk/ewk_view.h:
  • ewk/ewk_view_private.h:
  • tests/test_ewk_view.cpp:

(ewkViewEnableFullscreenCb):
(TEST):

10:13 PM Changeset in webkit [129593] by mitz@apple.com
  • 14 edits in trunk

Source/WebKit/mac: WebKit/mac part of <rdar://problem/11455228> [mac] Stop using screen fonts
​https://bugs.webkit.org/show_bug.cgi?id=97620

Reviewed by John Sullivan.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Changed the default value of the screenFontSubstitutionEnabled
preference to NO.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Changed to enable screen font substitution also if
the value of the NSFontDefaultScreenFontSubstitutionEnabled user defaults key is YES.

Source/WebKit2: WebKit2 part of <rdar://problem/11455228> [mac] Stop using screen fonts
​https://bugs.webkit.org/show_bug.cgi?id=97620

Reviewed by John Sullivan.

  • Shared/WebPreferencesStore.h:

(WebKit): Changed the default value of the screenFontSubstitutionEnabled preference to false.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Added an initializer for
the new shouldForceScreenFontSubstitution data member.
(WebKit::WebProcessCreationParameters::encode): Added encoding of shouldForceScreenFontSubstitution.
(WebKit::WebProcessCreationParameters::decode): Added decoding of shouldForceScreenFontSubstitution.

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters): Added shouldForceScreenFontSubstitution boolean data member.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess): Added code to set shouldForceScreenFontSubstitution
in the process creation parameters to the value of the NSFontDefaultScreenFontSubstitutionEnabled user
defaults key.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Changed to enable screen font substitution also if
shouldForceScreenFontSubstitution() is true.

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::shouldForceScreenFontSubstitution): Added this getter.
(WebProcess): Added m_shouldForceScreenFontSubstitution boolean data member.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Added initialization of
m_shouldForceScreenFontSubstitution from the creation parameters.

Tools: Tools part of <rdar://problem/11455228> [mac] Stop using screen fonts
​https://bugs.webkit.org/show_bug.cgi?id=97620

Reviewed by John Sullivan.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues): Enable screen font substitution when
running the tests.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues): Ditto.

9:45 PM Changeset in webkit [129592] by barraclough@apple.com
  • 11 edits in trunk

REGRESSION (r129456): http/tests/security/xss-eval.html is failing on JSC platforms
​https://bugs.webkit.org/show_bug.cgi?id=97529

Reviewed by Filip Pizlo.

A recent patch changed JSC's EvalError behaviour; bring this more into line with other browsers.

Source/JavaScriptCore:

JSC currently throws an EvalError if you try to call eval with a this object that doesn't
match the given eval function. This does not match other browsers, which generally just
ignore the this value that was passed, and eval the string in the eval function's environment.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • Remove EvalError, ignore passed this value.

LayoutTests:

  • fast/js/eval-cross-window-expected.txt:
  • fast/js/eval-cross-window.html:
    • Changed not to expect EvalErrors (this matches other browsers), and modified testThis to check that the this object is always set to the global object.
  • http/tests/security/resources/xss-eval2.html:
  • http/tests/security/resources/xss-eval3.html:
  • http/tests/security/xss-eval-expected.txt:
  • http/tests/security/xss-eval.html:
    • Updated. Access via the global environment is not a security risk, since the eval is accessing it's own document's informantion. Access via the shell attempts to access the navigated pages document, tripping an access check & throwing a TypeError.
9:03 PM Changeset in webkit [129591] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

[Forms] We should disconnect DateTimeEditElement and DateTimeFieldElement on layout()
​https://bugs.webkit.org/show_bug.cgi?id=97438

Reviewed by Kent Tamura.

This patch is for code cleanup. It is better to disconnect DateTimeFieldElement
from DateTimeEditElement when DateTimeEditElement doesn't have
pointers to DateTimeFieldElement.

No new tests. This patch doesn't change behavior.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::resetFields): Changed to call DateTimeFieldElement::removeEventHandler()
for existing fields to disconnect DateTimeEditElement and DateTimeFieldElement.

8:38 PM Changeset in webkit [129590] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[CSS Exclusions] shape-inside line segment layout should be based on line position and height
​https://bugs.webkit.org/show_bug.cgi?id=95479

Patch by Bear Travis <​betravis@adobe.com> on 2012-09-25
Reviewed by Levi Weintraub.

Source/WebCore:

This patch adds line height to line top to calculate line segments using the line's upper
and lower logical edges. The last line in a shape is allowed to overflow the shape,
using line top and shape bottom to calculate the available line segments. Overflow
behavior will develop in greater detail as the specification advances. For more on
overflow, see:

As more shapes are added, line positions within a shape are no longer guaranteed to
have segments (eg, the first line in a circular shape inside), and so many instances
of lineState were replaced with hasSegments. Layout code also uses lineOverlapsShapeBounds
rather than lineState, now that lines may partially overlap a shape without being
completely contained by it. Because layout begins at the shape's logical top, however,
we only run into this edge case laying out the last line within a shape-inside.

Test: fast/exclusions/shape-inside/shape-inside-rounded-rectangle.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::LineWidth): Use WrapShapeInfo::hasSegments rather than
WrapShapeInfo::lineState, as line positions within a shape are no longer
guaranteed to always have line segments.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Pass lineBottom as well as lineTop
to computeSegmentsForLine.

  • rendering/WrapShapeInfo.cpp:

(WebCore::WrapShapeInfo::computeSegmentsForLine): Pass lineBottom as well as lineTop
to ExclusionShape::getInsideIntervals.

  • rendering/WrapShapeInfo.h:

(WrapShapeInfo):
(WebCore::WrapShapeInfo::shapeLogicalBottom): Calculate the logical bottom of an
Exclusion Shape.
(WebCore::WrapShapeInfo::hasSegments): Allow hasSegments to be called even when
a line does not overlap a shape.
(WebCore::WrapShapeInfo::lineOverlapsShapeBounds): Test whether a line's top/bottom
overlap a shape's top/bottom. This includes lines that begin before or end after
a shape but still overlap it.

LayoutTests:

Test that line bottom as well as line top is used when calculating line segments
for a rounded rectangle.

  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle.html: Added.
8:18 PM Changeset in webkit [129589] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix. "values" doesn't necessarily contain multiple values but it needs to be always parsed as an array.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest.parse_output):

7:56 PM Changeset in webkit [129588] by fpizlo@apple.com
  • 6 edits
    9 adds in trunk

DFG ArrayPush, ArrayPop don't handle clobbering or having a bad time correctly
​https://bugs.webkit.org/show_bug.cgi?id=97535

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

LayoutTests:

Rubber stamped by Oliver Hunt.

  • fast/js/dfg-array-pop-side-effects-expected.txt: Added.
  • fast/js/dfg-array-pop-side-effects.html: Added.
  • fast/js/dfg-array-push-bad-time-expected.txt: Added.
  • fast/js/dfg-array-push-bad-time.html: Added.
  • fast/js/dfg-array-push-slow-put-expected.txt: Added.
  • fast/js/dfg-array-push-slow-put.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-array-pop-side-effects.js: Added.

(foo):
(.b):

  • fast/js/script-tests/dfg-array-push-bad-time.js: Added.
  • fast/js/script-tests/dfg-array-push-slow-put.js: Added.

(foo):

7:55 PM Changeset in webkit [129587] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Fat Fingers doesn't work on non-scrollable pages.
PR #209609
​https://bugs.webkit.org/show_bug.cgi?id=97607

Patch by Genevieve Mak <​gmak@rim.com> on 2012-09-25
Reviewed by Antonio Gomes.

Only bypass Fat Fingers and use the actual touch point if its specifically
requested and the page has a mouse move listener or if using the Touch Event
Mode meta-tag.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

7:27 PM Changeset in webkit [129586] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

JSC should dump object size inference statistics
​https://bugs.webkit.org/show_bug.cgi?id=97618

Reviewed by Filip Pizlo.

Added an option to dump object size inference statistics.

To see statistics on live objects:

jsc --showHeapStatistics=1

To see cumulative statistics on all objects ever allocated:

jsc --showHeapStatistics=1 --objectsAreImmortal=1

(This is useful for showing GC churn caused by over-allocation.)

To support this second mode, I refactored Zombies to separate out their
immortality feature so I could reuse it.

  • heap/Heap.cpp:

(JSC::MarkObject): Helper for making things immortal. We have to checked
for being zapped because blocks start out in this state.

(JSC::StorageStatistics): Gather statistics by walking the heap. Ignore
arrays and hash tables for now because they're not our focus. (We'll
remove these exceptions in future.)

(JSC::Heap::collect): Moved zombify to the end so it wouldn't interfere
with statistics gathering.

(JSC::Heap::showStatistics):
(JSC::Heap::markAllObjects): Factored out helper, so statistics could
take advantage of immortal objects.

(Zombify): Don't mark immortal objects -- that's another class's job now.

(JSC::Zombify::operator()):
(JSC::Heap::zombifyDeadObjects): Take advantage of forEachDeadCell instead
of rolling our own.

  • heap/Heap.h:

(Heap):

  • heap/MarkedSpace.h:

(MarkedSpace):
(JSC::MarkedSpace::forEachDeadCell): Added, so clients don't have to do
the iteration logic themselves.

  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/Options.h: New options, listed above. Make sure to initialize

based on environment variable first, so we can override with specific settings.

7:25 PM Changeset in webkit [129585] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

[Chromium] Network requests without a networking context can be started
​https://bugs.webkit.org/show_bug.cgi?id=97498

Reviewed by Eric Seidel.

Source/WebCore:

We shouldn't try to start network requests without a networking
context. Other ports have a similar null check.

  • platform/network/chromium/ResourceHandle.cpp:

(WebCore::ResourceHandle::start):

LayoutTests:

  • http/tests/security/svg-img-leak.html: Added.
  • http/tests/security/svg-img-leak-expected.txt: Added.
  • http/tests/security/resources/set-cookie.php: Added.
7:16 PM Changeset in webkit [129584] by inferno@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebCore/rendering/RenderArena.cpp

Merge 129583 - Mask RenderArena freelist entries.
Review URL: ​https://codereview.chromium.org/10996014

7:14 PM Changeset in webkit [129583] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

Mask RenderArena freelist entries.
​https://bugs.webkit.org/show_bug.cgi?id=97494

Patch by Justin Schuh <​jschuh@chromium.org> on 2012-09-25
Reviewed by Julien Chaffraix.

This is a mitigation for freelist spraying. See ​http://download.crowdstrike.com/papers/hes-exploiting-a-coalmine.pdf.

No new tests. This is a hardening measure. Found no measurable performance impact with Dromaeo.

  • rendering/RenderArena.cpp:

(MaskPtr):
(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free):

7:13 PM Changeset in webkit [129582] by hclam@chromium.org
  • 17 edits
    1 copy
    40 adds in trunk/LayoutTests

Unreviewed test expectations update. Round two.

r129571 affects all tests that invole image scaling so baselines need to be updated.

  • platform/chromium-linux-x86/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
  • platform/chromium-linux/fast/events/pointer-events-2-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/3d-corners-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/img-layer-grow-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-twice-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/video-frame-size-change-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/events/pointer-events-2-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/3d-corners-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/img-layer-grow-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-twice-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/video-frame-size-change-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Added.
  • platform/chromium-mac/compositing/masks/mask-of-clipped-layer-expected.png: Added.
  • platform/chromium-mac/fast/events/pointer-events-2-expected.png:
  • platform/chromium-mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png.
  • platform/chromium-win-xp/platform/chromium/compositing/3d-corners-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/img-layer-grow-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-twice-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Added.
  • platform/chromium-win/compositing/masks/mask-of-clipped-layer-expected.png: Added.
  • platform/chromium-win/fast/events/pointer-events-2-expected.png:
7:05 PM Changeset in webkit [129581] by hclam@chromium.org
  • 1020 edits
    3 adds
    23 deletes in trunk/LayoutTests

Unreviewed test expectations update.

r129571 affects all tests that invole image scaling so baselines need to be updated.

  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-linux-x86/fast/forms/placeholder-position-expected.png: Added.
  • platform/chromium-linux-x86/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/filters/feDisplacementMap-expected.png:
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-linux/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-linux/compositing/visibility/visibility-image-layers-expected.png:
  • platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-expected.png:
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
  • platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-linux/fast/css/input-search-padding-expected.png:
  • platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-linux/fast/css/text-overflow-input-expected.png:
  • platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-linux/fast/forms/search-rtl-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.png:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-linux/fast/images/jpeg-with-color-profile-expected.png:
  • platform/chromium-linux/fast/images/png-with-color-profile-expected.png:
  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/replaced/image-sizing-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-linux/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-layout-direction-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-styling-strict-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/media-controls-clone-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-08-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-10-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-linux/svg/custom/createImageElement2-expected.png:
  • platform/chromium-linux/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-linux/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-linux/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-linux/svg/filters/feDisplacementMap-expected.png:
  • platform/chromium-linux/svg/filters/filterRes-expected.png:
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-linux/tables/mozilla/core/misc-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-linux/transitions/cross-fade-background-image-expected.png:
  • platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-mac-snowleopard/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-mac-snowleopard/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/jpeg-with-color-profile-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/png-with-color-profile-expected.png:
  • platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feDisplacementMap-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-snowleopard/transitions/cross-fade-background-image-expected.png:
  • platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-mac/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-mac/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png:
  • platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-mac/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-mac/fast/borders/inline-mask-overlay-image-outset-expected.png:
  • platform/chromium-mac/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
  • platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/fast/images/jpeg-with-color-profile-expected.png:
  • platform/chromium-mac/fast/images/png-with-color-profile-expected.png:
  • platform/chromium-mac/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Added.
  • platform/chromium-mac/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac/fast/replaced/image-sizing-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-layout-direction-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-strict-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-controls-clone-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-08-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac/svg/custom/createImageElement-expected.png:
  • platform/chromium-mac/svg/custom/createImageElement2-expected.png:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-mac/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac/svg/filters/feDisplacementMap-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-mac/svg/filters/filterRes-expected.png:
  • platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac/tables/mozilla/core/misc-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac/transitions/cross-fade-background-image-expected.png:
  • platform/chromium-win-xp/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-win-xp/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-win-xp/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win-xp/fast/forms/search-styled-expected.png:
  • platform/chromium-win-xp/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win-xp/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Removed.
  • platform/chromium-win-xp/svg/filters/feDisplacementMap-expected.png:
  • platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-win/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-win/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-win/compositing/visibility/visibility-image-layers-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-win/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.png:
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
  • platform/chromium-win/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-win/fast/css/input-search-padding-expected.png:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-win/fast/css/text-overflow-input-expected.png:
  • platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-win/fast/forms/search-rtl-expected.png:
  • platform/chromium-win/fast/forms/search-styled-expected.png:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-win/fast/images/jpeg-with-color-profile-expected.png:
  • platform/chromium-win/fast/images/png-with-color-profile-expected.png:
  • platform/chromium-win/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Added.
  • platform/chromium-win/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-layout-direction-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-strict-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-08-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-10-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-win/svg/custom/createImageElement-expected.png:
  • platform/chromium-win/svg/custom/createImageElement2-expected.png:
  • platform/chromium-win/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-win/svg/custom/image-rescale-clip-expected.png:
  • platform/chromium-win/svg/custom/image-rescale-scroll-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-win/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-win/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-win/svg/custom/js-update-image-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-win/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-win/svg/filters/feDisplacementMap-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-win/svg/filters/filterRes-expected.png:
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/core/misc-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-win/transitions/cross-fade-background-image-expected.png:
6:32 PM Changeset in webkit [129580] by rniwa@webkit.org
  • 3 edits in trunk/Tools

run-perf-tests: cleanup options and results generation code
​https://bugs.webkit.org/show_bug.cgi?id=97611

Reviewed by Dirk Pranke.

Previously, --test-results-server triggered old JSOn format where the outermost structure was a dictionary
instead of an array, and also implicitly triggered --no-show-results, caused the old outputs not to merge,
and prevented the generation of results page. Also, it was not obvious that --source-json-path is an option
used only on buildbot slaves.

This patch will:

  • Remove the old format since perf-o-matic supports new format now.
  • Add --reset-results option so that we can explicitly clear existing outputs.
  • Add --slave-config-json-path option to replace --source-json-path option.
  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args): Added --reset-results and --slave-config-json-path options.
(PerfTestsRunner._generate_and_show_results): Refactored. Also removed the code to strip "values" from
results since perf-o-matic can parse and store these values now.
(PerfTestsRunner._merge_outputs_if_needed): Renamed from _merge_outputs_if_needed.

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_with_json_output): Test a harmless behavioral change to generate resuls page even when
--test-results-server is present.
(test_run_with_description):
(test_run_generates_json_by_default):
(test_run_merges_output_by_default): Added.
(test_run_respects_reset_results): Added.
(test_run_with_slave_config_json):
(test_run_with_bad_slave_config_json): Use --slave-config-json-path instead of --source-json-path to make
sure this optioon works as well.
(test_run_with_multiple_repositories):
(test_run_with_upload_json):

6:17 PM Changeset in webkit [129579] by macpherson@chromium.org
  • 9 edits
    8 adds in trunk

Ensure variables are resolved for specialized CSS primitive value types.
​https://bugs.webkit.org/show_bug.cgi?id=95930

Reviewed by Tony Chang.

Source/WebCore:

Sometimes CSSPrimitiveValue contains a collection of other CSSPrimitiveValues (eg. 2, 4 or n).
This patch makes sure any variables contained inside those child values are resolved.

Tests: fast/css/variables/root-background-size.html

fast/css/variables/var-inside-pair.html
fast/css/variables/var-inside-quad.html
fast/css/variables/var-inside-shape.html

  • css/CSSBasicShapes.cpp:

(WebCore::buildRectangleString):
(WebCore::CSSBasicShapeRectangle::cssText):
(WebCore):
(WebCore::CSSBasicShapeRectangle::serializeResolvingVariables):
Generates a string representation of this value with variables resolved from the provided HashMap of variables.
(WebCore::CSSBasicShapeRectangle::hasVariableReference):
Returns true if any of the values used to describe the rectange depend on the value of a variable.
(WebCore::buildCircleString):
(WebCore::CSSBasicShapeCircle::cssText):
(WebCore::CSSBasicShapeCircle::serializeResolvingVariables):
(WebCore::CSSBasicShapeCircle::hasVariableReference):
(WebCore::buildEllipseString):
(WebCore::CSSBasicShapeEllipse::cssText):
(WebCore::CSSBasicShapeEllipse::serializeResolvingVariables):
(WebCore::CSSBasicShapeEllipse::hasVariableReference):
(WebCore::CSSBasicShapePolygon::serializeResolvingVariables):
(WebCore::CSSBasicShapePolygon::hasVariableReference):

  • css/CSSBasicShapes.h:

(CSSBasicShapeRectangle):
(CSSBasicShapeCircle):
(CSSBasicShapeEllipse):
(CSSBasicShapePolygon):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::customCssText):
Move the logic for generating the strings for Rects, Quads, Pairs and Shapes into their respective classes.
(WebCore::CSSPrimitiveValue::customSerializeResolvingVariables):
Handle Rects, Quads, Pairs and Shapes when they contain variables, by calling their serializeResolvingVariables method.
(WebCore):
(WebCore::CSSPrimitiveValue::hasVariableReference):
Handle Rects, Quads, Pairs and Shapes by calling their respective hasVariableReference methods.

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/Pair.h:

(WebCore::Pair::pairString):
(Pair):
(WebCore::Pair::cssText):
(WebCore::Pair::serializeResolvingVariables):
(WebCore::Pair::hasVariableReference):

  • css/Rect.h:

(RectBase):
(WebCore::RectBase::hasVariableReference):
(WebCore::Rect::rectString):
(Rect):
(WebCore::Rect::cssText):
(WebCore::Rect::serializeResolvingVariables):
(WebCore::Quad::quadString):
(Quad):
(WebCore::Quad::cssText):
(WebCore::Quad::serializeResolvingVariables):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

Add tests that use specialized CSS values (eg. pairs, quads, rectangle, circle, ellipse etc.).

  • fast/css/variables/root-background-size-expected.html: Added.
  • fast/css/variables/root-background-size.html: Added.
  • fast/css/variables/var-inside-pair-expected.html: Added.
  • fast/css/variables/var-inside-pair.html: Added.
  • fast/css/variables/var-inside-quad-expected.html: Added.
  • fast/css/variables/var-inside-quad.html: Added.
  • fast/css/variables/var-inside-shape-expected.html: Added.
  • fast/css/variables/var-inside-shape.html: Added.
5:24 PM Changeset in webkit [129578] by Simon Fraser
  • 2 edits in trunk/Tools

Fix SnowLeopard build by adding #ifdefs.

Fix crashes on some tests where the CFURLRef appears to be null.

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:

(WTR::testPathFromURL):
(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):

5:22 PM Changeset in webkit [129577] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

We shouldn't use the optimized versions of shift/unshift if the user is doing crazy things to the array
​https://bugs.webkit.org/show_bug.cgi?id=97603
<rdar://problem/12370864>

Reviewed by Gavin Barraclough.

You changed the length behind our backs? No optimizations for you then!

  • runtime/ArrayPrototype.cpp:

(JSC::shift):
(JSC::unshift):

  • runtime/JSArray.cpp:

(JSC::JSArray::shiftCount):

5:03 PM Changeset in webkit [129576] by Simon Fraser
  • 3 edits in trunk/Tools

Speculative build fix for Production builds.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
4:52 PM Changeset in webkit [129575] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Get rid of WebContext::m_pendingMessagesToPostToInjectedBundle
​https://bugs.webkit.org/show_bug.cgi?id=94368

Reviewed by Anders Carlsson.

It doesn't appear to be of any use.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::createNewWebProcess): (WebKit::WebContext::postMessageToInjectedBundle):
  • UIProcess/WebContext.h:
4:42 PM Changeset in webkit [129574] by fpizlo@apple.com
  • 11 edits in trunk/Source

JSC bindings appear to sometimes ignore the possibility of arrays being in sparse mode
​https://bugs.webkit.org/show_bug.cgi?id=95610

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Add better support for quickly accessing the indexed storage from bindings.

  • runtime/JSObject.h:

(JSC::JSObject::tryGetIndexQuickly):
(JSObject):
(JSC::JSObject::getDirectIndex):
(JSC::JSObject::getIndex):

Source/WebCore:

Fix all of the cases I found where we were using getIndexQuickly(), which was wrong
if we were in sparse mode.

  • bindings/js/ArrayValue.cpp:

(WebCore::ArrayValue::get):

  • bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::JSCanvasRenderingContext2D::setWebkitLineDash):

  • bindings/js/JSDOMStringListCustom.cpp:

(WebCore::toDOMStringList):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):

  • bindings/js/ScriptValue.cpp:

(WebCore::jsToInspectorValue):

  • bindings/js/SerializedScriptValue.cpp:

(CloneSerializer):
(WebCore::CloneSerializer::serialize):

4:35 PM Changeset in webkit [129573] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

Load the linearized sRGB profile via NSData instead of CoreFoundation
​https://bugs.webkit.org/show_bug.cgi?id=97616

Reviewed by Dan Bernstein.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::linearRGBColorSpaceRef):

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::linearRGBColorSpaceRef):

4:20 PM Changeset in webkit [129572] by mkwst@chromium.org
  • 6 edits in trunk

CSP logging: Be more developer-friendly when 'default-src' is violated.
​https://bugs.webkit.org/show_bug.cgi?id=97597

Reviewed by Adam Barth.

Source/WebCore:

Developers unfamiliar with the details of Content Security Policy might
be confused when 'default-src' is used as a fallback for a directive
otherwise absent from the policy they've set. This patch adds an
explicit explanation to the permission warning in such a situation.

New warning string is covered by rebaselining existing tests.

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):

If the operative directive is 'default-src', output a warning,
using the type information present in the report to specify which
directive is falling back to the default values.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt:
  • http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers-expected.txt:

Rebaselining these tests with the new warning string.

4:18 PM Changeset in webkit [129571] by hclam@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Roll DEPS for Chromium.

  • DEPS:
4:15 PM Changeset in webkit [129570] by Simon Fraser
  • 2 edits in trunk/Tools

Fix the build after r129566.

  • DumpRenderTree/mac/FrameLoadDelegate.mm:
4:08 PM Changeset in webkit [129569] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=97615
fast/loader/scroll-position-restored-on-back.html failing after
didFirstLayout/didFirstVisuallyNonEmptyLayout change

Reviewed by Sam Weinig.

​http://trac.webkit.org/changeset/129545 made it so we only dispatch
the layout callbacks when the client has opted into them. This is a
problem for a bit of work that used to be done, prior to that patch,
in FrameLoader::didFirstLayout(). Because that function did some work
with scroll position and the state machine, and that is work that we
want to do even when the client has not opted into the didFirstLayout
callback. We are seeing this bug in DRT and WTR since those clients
do not opt into the callback. And they shouldn't have to to get this
scroll position and state machine work done.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didLayout):
(WebCore::FrameLoader::didFirstLayout):

  • loader/FrameLoader.h:

(FrameLoader):

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

4:00 PM Changeset in webkit [129568] by alecflett@chromium.org
  • 2 edits in trunk/Tools

AX: AccessibilityUIElementChromium.cpp won't build on Windows without wtf/StringExtras.h
​https://bugs.webkit.org/show_bug.cgi?id=97614

Unreviewed, fixing windows breakage.

Added wtf/StringExtras.h to the includes to fix the Chromium/Windows build.

Patch by Dominic Mazzoni <​dmazzoni@google.com> on 2012-09-25

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
4:00 PM Changeset in webkit [129567] by jpfau@apple.com
  • 7 edits
    4 adds in trunk

Add WebKit1 SPI for storage blocking preference
​https://bugs.webkit.org/show_bug.cgi?id=97356

Reviewed by Brady Eidson.

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setStorageBlockingPolicy:]):
(-[WebPreferences storageBlockingPolicy]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

LayoutTests:

  • http/tests/security/cross-origin-local-storage-wk1-expected.txt: Added.
  • http/tests/security/cross-origin-local-storage-wk1.html: Added.
  • platform/chromium/TestExpectations: Test currently fails on Chromium.
  • platform/mac-wk2/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Added.
  • platform/mac/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Added.
3:54 PM Changeset in webkit [129566] by Simon Fraser
  • 17 edits
    1 add in trunk

<rdar://problem/12351906> Have DumpRenderTree and WebKitTestRunner crash logs show which test crashed

Reviewed by Mark Rowe.

Use a new WebKitSytemInterface function to add data to crash logs about which
test was running when the crash happened.

Source/WebCore:

  • WebCore.exp.in: Export wkSetCrashReportApplicationSpecificInformation
  • platform/mac/WebCoreSystemInterface.h: Add wkSetCrashReportApplicationSpecificInformation.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Hook up the function pointer for [wk|WK]SetCrashReportApplicationSpecificInformation.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Hook up the function pointer for [wk|WK]SetCrashReportApplicationSpecificInformation.

Tools:

  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Make sure WEBKIT_SYSTEM_INTERFACE_LIBRARY is defined.
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: link with the WebKitSystemInterface library.
  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(testPathFromURL): Given a (probably) file URL, return the part after "/LayoutTests/"
(-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Tell Crash Reporter which test was running,
if we're the main frame and the test is active.

  • WebKitTestRunner/Configurations/DebugRelease.xcconfig: Make sure WEBKIT_SYSTEM_INTERFACE_LIBRARY is defined.
  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig: link the injected bundle with the WebKitSystemInterface library.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Call platformDidStartProvisionalLoadForFrame().
(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Stub for non-Mac platforms.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

Add a platformDidStartProvisionalLoadForFrame() for platform-specific work.

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm: Added.

(WTR::testPathFromURL): Given a (probably) file URL, return the part after "/LayoutTests/"
(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Tell Crash Reporter which test was running,
if we're the main frame.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add InjectedBundlePageMac.mm.
3:54 PM Changeset in webkit [129565] by Simon Fraser
  • 5 edits in trunk/WebKitLibraries

<rdar://problem/12351906> Have DumpRenderTree and WebKitTestRunner crash logs show which test crashed

Reviewed by Tim Horton.

New WKSI libraries and header.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:52 PM Changeset in webkit [129564] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Skip Dromaeo/jslib-modify-jquery.html per bug 95376.
It runs out of memory on Chromium port, and it takes unreasonably long time (~5 minutes)
to run on other ports.

  • Skipped:
3:37 PM Changeset in webkit [129563] by jparent@chromium.org
  • 3 edits in trunk/Tools

Make test_shell_tests show up in flakiness dashboard.
​https://bugs.webkit.org/show_bug.cgi?id=97585

Reviewed by Dirk Pranke.

test_shell_tests run only on chromium.org, and on the same bots as
the layout tests, so do not use the generic fallbacks.

  • TestResultServer/static-dashboards/builders.js:

(loadBuildersList):

  • TestResultServer/static-dashboards/dashboard_base.js:

(currentBuilderGroupCategory):

3:32 PM Changeset in webkit [129562] by fischman@chromium.org
  • 1 edit
    1 copy in branches/chromium/1271

Merge 129296 - HTMLMediaElement isn't garbage collected between document reloads
​https://bugs.webkit.org/show_bug.cgi?id=97020

Reviewed by Eric Carlson.

.:

Manual test added: ManualTests/audio-freed-during-reload.html

  • ManualTests/audio-freed-during-reload.html:

Source/WebCore:

JS-created (as opposed to DOM-created) Audio nodes never got collected, because they
appear to always hasPendingActivity(), because m_playing is never set to false.

Manual test added: ManualTests/audio-freed-during-reload.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::stop): set m_playing = false; explicitly.

TBR=​fischman@chromium.org
Review URL: ​https://codereview.chromium.org/10979026

3:23 PM Changeset in webkit [129561] by Lucas Forschler
  • 2 edits in trunk/Tools

Python tests fail on Windows bots when running with more than one child process. Temporarily use only one child process until the problem can be fixed.
​https://bugs.webkit.org/show_bug.cgi?id=97465

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunPythonTests.start):

3:16 PM Changeset in webkit [129560] by commit-queue@webkit.org
  • 4 edits in trunk

[BlackBerry] Enable LLInt
​https://bugs.webkit.org/show_bug.cgi?id=97604

Patch by Cosmin Truta <​ctruta@rim.com> on 2012-09-25
Reviewed by Yong Li.

.:

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WTF:

Set the prefix of LOCAL_LABEL_STRING to ".L" on QNX.

  • wtf/InlineASM.h:
3:02 PM Changeset in webkit [129559] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Do not enable DFG JIT for COMPILER(MSVC).

The current code does not support MSVC inline assembler, so disable it for now.

  • wtf/Platform.h:
2:54 PM Changeset in webkit [129558] by mkwst@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as a committer.

Yay. :)

  • Scripts/webkitpy/common/config/committers.py:
2:52 PM Changeset in webkit [129557] by Beth Dakin
  • 1 edit
    5 adds
    3 deletes in trunk/LayoutTests

Moving this test which was added with
​http://trac.webkit.org/changeset/129535
since it fails on the WK1 bots. Making it WK2-only for now.

  • http/tests/plugins/get-url-beforeunload-destroys-plugin-expected.txt: Removed.
  • http/tests/plugins/get-url-beforeunload-destroys-plugin.html: Removed.
  • http/tests/plugins/resources/notify-done.html: Removed.
  • platform/mac-wk2/http/tests/plugins: Added.
  • platform/mac-wk2/http/tests/plugins/get-url-beforeunload-destroys-plugin-expected.txt: Added.
  • platform/mac-wk2/http/tests/plugins/get-url-beforeunload-destroys-plugin.html: Added.
  • platform/mac-wk2/http/tests/plugins/resources: Added.
  • platform/mac-wk2/http/tests/plugins/resources/notify-done.html: Added.
2:40 PM Changeset in webkit [129556] by Beth Dakin
  • 3 edits in trunk/Source/WebKit2

Build fix. I removed this function as a part of
​https://bugs.webkit.org/show_bug.cgi?id=95397 but it is
still needed for nightlies and open source builds.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetPaintedObjectsCounterThreshold):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
2:22 PM Changeset in webkit [129555] by rniwa@webkit.org
  • 4 edits in trunk

Perf-o-matic should store "values" and support array'ed input
​https://bugs.webkit.org/show_bug.cgi?id=97601

Reviewed by Dirk Pranke.

Support new JSON format where the outermost structure is an array instead of a dictionary and results may
contain "values". This change will let us remove some code from run-perf-tests.

Old: {"webkit-revision": 123456, "results": {"test": {"avg": 123}}
New: [{"webkit-revision": 123456, "results": {"test": {"avg": 123, values: [122, 123, 124]}}}]

  • Websites/webkit-perf.appspot.com/app.yaml: Incremented the version number.
  • Websites/webkit-perf.appspot.com/models.py:

(TestResult): Added values property.
(TestResult.get_or_insert_from_parsed_json): Pass in "values" to the constructor if the value is present.
(ReportLog.get_value): Use the first item in the array if self._parsed uses the new format.
(ReportLog.results_are_well_formed): Verifies that items in "values" are floats convertible. Also verify that
if the JSON uses new format, there is exactly one set of results. In theory, we could support multiple results
but we don't do that now for its complexity.

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(TestResultTests.test_get_or_insert_stat_value): Make sure values is present and is an empty list.
(TestResultTests.test_get_or_insert_stat_value_with_values): Added.
(ReportLogTests.test_results_are_well_formed):
(ReportLogTests.test_chromium_revision): Renamed from chromium_revision so that it actually runs.
(ReportLogTests.test_results_in_array):

2:01 PM Changeset in webkit [129554] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests.

  • platform/qt-5.0-wk2/Skipped:
2:01 PM Changeset in webkit [129553] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Structure check hoisting phase doesn't know about the side-effecting nature of Arrayify
​https://bugs.webkit.org/show_bug.cgi?id=97537

Reviewed by Mark Hahnenberg.

No tests because if we use Arrayify then we also use PutByVal(BlankToXYZ), and the latter is
already known to be side-effecting. So this bug shouldn't have had any symptoms, as far as I
can tell.

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

1:52 PM Changeset in webkit [129552] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make COMPUTED_GOTO part of the HAVE section
​https://bugs.webkit.org/show_bug.cgi?id=97600

Reviewed by Yong Li.

Also get rid of COMPUTED_GOTO_INTERPRETER and add COMPUTED_GOTO_OPCODES.

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/AboutDataHaveFeatures.in:
1:47 PM Changeset in webkit [129551] by adamk@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove unused DOMAttrModified from EventsNames and Document::ListenerType
​https://bugs.webkit.org/show_bug.cgi?id=97591

Reviewed by Ojan Vafai.

WebKit does not, and will never, fire DOMAttrModified events, so
there's no need to create the "DOMAttrModified" event name.

The only use of the name was to set the DOMATTRMODIFIED_LISTENER bit
on Document; with the name gone, the enum value can be removed as well.

  • dom/Document.cpp:

(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h: Remove DOMATTRMODIFIED_LISTENER, and switch this

enum to use shift-left instead of hex values, so as to be easier to
update in future.

  • dom/EventNames.h:

(WebCore):

1:44 PM Changeset in webkit [129550] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Suspend the backingstore while adjusting the view on input field focus.
​https://bugs.webkit.org/show_bug.cgi?id=97595

Reviewed by Antonio Gomes.

PR 188751.

Avoid jumpiness when both a scroll and zoom are required to
move an input field into focus by suspending the backingstore.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

1:40 PM Changeset in webkit [129549] by psolanki@apple.com
  • 5 edits in trunk/Source

Remove HAVE_SBRK since we never set use_sbrk to true
​https://bugs.webkit.org/show_bug.cgi?id=97525
<rdar://problem/12363601>

Reviewed by Geoffrey Garen.

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataHaveFeatures.in: Remove SBRK from list.

Source/WTF:

The code under HAVE(SBRK) has not been used since 2005. We use mmap not sbrk for FastMalloc
not sbrk. We can just remove the define and move all of this code inside #ifndef
WTF_CHANGES.

  • wtf/Platform.h:
  • wtf/TCSystemAlloc.cpp:

(TCMalloc_SystemAlloc):

1:18 PM Changeset in webkit [129548] by barraclough@apple.com
  • 5 edits in trunk

Regression: put beyond vector length prefers prototype setters to sparse properties
​https://bugs.webkit.org/show_bug.cgi?id=97593

Reviewed by Geoff Garen & Filip Pizlo.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::putByIndexBeyondVectorLength):

  • Check for self properties in the sparse map - if present, don't examine the protochain.

LayoutTests:

  • fast/js/script-tests/array-defineOwnProperty.js:

(Object.defineProperty):
(set Object.defineProperty):

  • Added test case.
1:16 PM Changeset in webkit [129547] by leoyang@rim.com
  • 2 edits in trunk/Source/WebCore

GraphicsContext3D::compileShader is using incorrect string length in GraphicsContext3DOpenGLCommon.cpp
​https://bugs.webkit.org/show_bug.cgi?id=97476

Reviewed by Dean Jackson.

No new tests because it's not testable in webkit test runner.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
Use translatedShaderCString.length() instead of translatedShaderSource.length()
for the shader source length because we are using translatedShaderCString.data()
for glShaderSource().

1:11 PM Changeset in webkit [129546] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Use USE(3D_GRAPHICS) in CSS SHADERS code when ENABLE(WEBGL) is true.
​https://bugs.webkit.org/show_bug.cgi?id=97543

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-09-25
Reviewed by Dean Jackson.

This patch cleans remaining ENABLE(WEBGL) guards in CSS SHADERS code after
r122175, which made USE(3D_GRAPHICS) default to true when ENABLE(WEBGL) is true.

No new tests because of no behavior changes.

  • rendering/FilterEffectRenderer.cpp:

(WebCore):
(WebCore::FilterEffectRenderer::build):

  • rendering/RenderView.cpp:

(WebCore):

  • rendering/RenderView.h:

(WebCore):
(RenderView):

1:01 PM Changeset in webkit [129545] by Beth Dakin
  • 87 edits
    1 add in trunk

​https://bugs.webkit.org/show_bug.cgi?id=95397
Need to merge didFirstVisuallyNonEmptyLayout and
didNewFirstVisuallyNonEmptyLayout
-and corresponding-
<rdar://problem/10791680>

Reviewed by Sam Weinig.

Source/WebCore:

This patch merges didFirstLayout, didFirstVisuallyNonEmptyLayout,
and didNewFirstVisuallyNonEmptyLayout. Page keeps track of which
layout milestones we are interested in with a bit mask, so that
different ports/clients can opt-into different milestones. This
will allow us to safely add more layout milestones in the future
if that seems worthwhile.

Include new file LayoutMilestoneOptions.h

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:

Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. They are now replaced
by dispatchDidLayout(LayoutMilestoneOptions)

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDidLayout):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didLayout):

  • loader/FrameLoader.h:

(FrameLoader):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):
(WebCore::FrameLoaderClient::dispatchDidLayout):

  • page/LayoutMilestoneOptions.h: Added.

(WebCore):

Check with Page to find out which layout milestones the client is
interested in, and then dispatch the notifications when
appropriate.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

Remove setRelevantRepaintedObjectsCounterThreshold(). Instead keep
track of the layout milestones bit mask.

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::addLayoutMilestones):
(WebCore):
(WebCore::Page::isCountingRelevantRepaintedObjects):
(WebCore::Page::addRelevantRepaintedObject):

  • page/Page.h:

(Page):
(WebCore::Page::layoutMilestones):

Source/WebKit/blackberry:

Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
is now replaced by dispatchDidLayout(LayoutMilestoneOptions)

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

It is now necessary to opt into getting any of the
"layout milestone" notifications.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

Source/WebKit/chromium:

Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
is now replaced by dispatchDidLayout(LayoutMilestoneOptions)

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidLayout):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

It is now necessary to opt into getting any of the
"layout milestone" notifications.

  • src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::initPage):

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initPage):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/efl:

Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
is now replaced by dispatchDidLayout(LayoutMilestoneOptions)

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidLayout):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

It is now necessary to opt into getting any of the
"layout milestone" notifications.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Source/WebKit/gtk:

Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
is now replaced by dispatchDidLayout(LayoutMilestoneOptions)

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidLayout):

  • WebCoreSupport/FrameLoaderClientGtk.h:

(FrameLoaderClient):

It is now necessary to opt into getting any of the
"layout milestone" notifications.

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

Source/WebKit/mac:

The new API has two parts. First, the client has to opt into which
layout milestones they are interested in hearing about using
[WebView _layoutMilestones]. Then, WebKit will call
the WebFrameLoader delegate's didLayout(WebLayoutMilestones)
callback when the specified layout milestones have fired.
didLayout takes the WebLayoutMilestones bit mask, which will
indicate which milestones have fired since it is possible for two
to fire at the same time.

Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. They are now replaced
by dispatchDidLayout(LayoutMilestones)

  • WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidLayout):

Add new function to the delegate for didLayout.

  • WebView/WebDelegateImplementationCaching.h:

(WebFrameLoadDelegateImplementationCache):

We need a delegate template that takes an NSUInteger.

  • WebView/WebDelegateImplementationCaching.mm:

(CallDelegate):
(CallFrameLoadDelegate):

Convert between WebCore and WebKit versions of the bit mask.

  • WebView/WebView.mm:

(coreLayoutMilestones):
(kitLayoutMilestones):

Add new delegate, and set the appropriate layout milestones in
WebCore based on old delegates having implementations.
(-[WebView _cacheFrameLoadDelegateImplementations]):

Call into WebCore.
(-[WebView _listenForLayoutMilestones:]):
(-[WebView _layoutMilestones]):

  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
is now replaced by dispatchDidLayout(LayoutMilestoneOptions)

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidLayout):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

It is now necessary to opt into getting any of the
"layout milestone" notifications.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

Source/WebKit/win:

Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
is now replaced by dispatchDidLayout(LayoutMilestoneOptions)

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidLayout):

  • WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

It is now necessary to opt into getting any of the
"layout milestone" notifications.

  • WebView.cpp:

(WebView::initWithFrame):

Source/WebKit/wince:

Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
is now replaced by dispatchDidLayout(LayoutMilestones)

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::dispatchDidLayout):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

(FrameLoaderClientWinCE):

Source/WebKit/wx:

Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
is now replaced by dispatchDidLayout(LayoutMilestones)

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::dispatchDidLayout):

  • WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

The new API has two parts. First, the client has to opt into which
layout milestones they are interested in hearing about using
WKPageListenForLayoutMilestones or
WKBundlePageListenForLayoutMilestones(). Then, WebKit will call
the didLayout(WKLayoutMilestones) callback on the appropriate
clients when the specified layout milestones have fired. didLayout
takes the WKLayoutMilestones bit mask, which will indicate which
milestones have fired since it is possible for two to fire at the
same time.

Define WKLayoutMilestoneOptions.

  • Shared/API/c/WKPageLoadTypes.h:

Define conversions between WKLayoutMilestoneOptions and
WebCore::LayoutMilestoneOptions

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toWKLayoutMilestoneOptions):
(WebKit):
(WebKit::toLayoutMilestoneOptions):

New API.

  • UIProcess/API/C/WKPage.cpp:

(WKPageListenForLayoutMilestones):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didLayout):
(WebKit):

  • UIProcess/WebLoaderClient.h:

(WebLoaderClient):

didFirstLayoutForFrame, didFirstVisuallyNonEmptyLayoutForFrame,
and didNewFirstVisuallyNonEmptyLayout are now implemented with
didLayout under the hood. So if those old callbacks have been
defined, be sure to add the appropriate layout milestones here for
backwards-compatibility.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeLoaderClient):

New API.
(WebKit::WebPageProxy::listenForLayoutMilestones):
(WebKit):
(WebKit::WebPageProxy::didLayout):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:

New API. And remove the now-unnecessary
WKBundlePageSetPaintedObjectsCounterThreshold.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageListenForLayoutMilestones):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

New API.

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didNewFirstVisuallyNonEmptyLayout):
(WebKit):
(WebKit::InjectedBundlePageLoaderClient::didLayout):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

(InjectedBundlePageLoaderClient):

Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. They are now replaced
by dispatchDidLayout(LayoutMilestoneOptions)

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidLayout):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

didFirstLayoutForFrame, didFirstVisuallyNonEmptyLayoutForFrame,
and didNewFirstVisuallyNonEmptyLayout are now implemented with
didLayout under the hood. So if those old callbacks have been
defined, be sure to add the appropriate layout milestones here for
backwards-compatibility.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::initializeInjectedBundleLoaderClient):
(WebKit):

Call into WebCore to set the layout milestones.
(WebKit::WebPage::listenForLayoutMilestones):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:

Account for the new member of PageLoadClient.

  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

Tools:

Account for the new member of the PageLoadClient.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

The NewFirstVisuallyNonEmptyLayoutForImages has existed for a while,
but it did not have the right target membership.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Use new didLayout API instead of old
didNewFirstVisuallyNonEmptyLayout API.

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:

(TestWebKitAPI):
(TestWebKitAPI::didLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:

(TestWebKitAPI):
(TestWebKitAPI::didLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:

(TestWebKitAPI):
(TestWebKitAPI::didLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:

(TestWebKitAPI):
(TestWebKitAPI::didLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

12:58 PM Changeset in webkit [129544] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] When zooming into an input field take the current zoom level into account.
​https://bugs.webkit.org/show_bug.cgi?id=97594

Reviewed by Antonio Gomes.

PR 188751.

Perform the zoom action prior to scroll to avoid breaking scrolling
rules. Take the current scale into account when calculating the
zoom factor.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

12:55 PM Changeset in webkit [129543] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

StylePropertySet: Use subclasses to manage varying object layouts.
<​http://webkit.org/b/97470>

Reviewed by Antti Koivisto.

Add two StylePropertySet subclasses:

  • MutableStylePropertySet
  • ImmutableStylePropertySet

The StylePropertySet::m_isMutable bit determines which subclass to cast to when accessing
the property storage. Added mutablePropertyVector() and immutablePropertyArray() helpers
to StylePropertySet (with appropriate assertions.)

This patch removes one heap allocation (and one step of indirection) in the mutable case,
since the Vector<CSSProperty> is no longer heap-allocated, but part of MutableStylePropertySet.

Override RefCounted::deref() in StylePropertySet to make sure that the correct subclass
destructor gets called.

  • WebCore.exp.in:
  • css/StylePropertySet.cpp:

(WebCore::immutableStylePropertySetSize):
(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::immutableCopyIfNeeded):
(WebCore::MutableStylePropertySet::MutableStylePropertySet):
(WebCore::ImmutableStylePropertySet::ImmutableStylePropertySet):
(WebCore::ImmutableStylePropertySet::~ImmutableStylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::copy):
(WebCore::StylePropertySet::reportMemoryUsage):
(WebCore::StylePropertySet::append):
(WebCore::StylePropertySet::create):

  • css/StylePropertySet.h:

(StylePropertySet):
(WebCore::StylePropertySet::StylePropertySet):
(ImmutableStylePropertySet):
(MutableStylePropertySet):
(WebCore::MutableStylePropertySet::MutableStylePropertySet):
(WebCore::StylePropertySet::mutablePropertyVector):
(WebCore::StylePropertySet::immutablePropertyArray):
(WebCore::StylePropertySet::propertyAt):
(WebCore::StylePropertySet::propertyCount):
(WebCore::StylePropertySet::deref):

12:30 PM Changeset in webkit [129542] by dgrogan@chromium.org
  • 6 edits in trunk/LayoutTests

2012-09-25 David Grogan <​dgrogan@chromium.org>

Unreviewed. Change some more svn:eol-style properties from native to LF.

  • LayoutTests/fast/events/message-port-constructor-for-deleted-document-expected.txt
  • LayoutTests/fast/events/message-port-deleted-document-expected.txt
  • LayoutTests/fast/events/message-port-deleted-frame-expected.txt
  • LayoutTests/fast/events/message-port-expected.txt
  • LayoutTests/fast/events/message-port-inactive-document-expected.txt
12:30 PM Changeset in webkit [129541] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK][EFL] Disk cache is never dumped to disk in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=97583

Reviewed by Martin Robinson.

The problem is that WebProcess::platformTerminate(), where the
cache is currently dumped, is not called when the web process
finishes because the UI process closes the connection. The cache
is created and loaded in the main() so it can also be flushed and
dumped there, so that we also make sure it's always called when
the process finishes normally when the main loop quits.

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl): Flush and dump the disk cache when
the main loop returns.

  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk): Ditto.

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformTerminate): Do not flush and dump
the disk cache.

12:21 PM Changeset in webkit [129540] by leviw@chromium.org
  • 12 edits
    1 add
    4 deletes in trunk/LayoutTests

Unreviewed gardening. Updating expectations after r129529.

  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55527-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug55527-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
12:19 PM Changeset in webkit [129539] by dgrogan@chromium.org
  • 6 edits in trunk/LayoutTests

2012-09-25 David Grogan <​dgrogan@chromium.org>

Unreviewed. Change some svn:eol-style properties from native to LF.

  • fast/events/message-channel-gc-2-expected.txt
  • fast/events/message-channel-gc-3-expected.txt
  • fast/events/message-channel-gc-4-expected.txt
  • fast/events/message-channel-gc-expected.txt
  • fast/events/message-channel-listener-circular-ownership-expected.txt
12:13 PM Changeset in webkit [129538] by peter@chromium.org
  • 1 edit
    148 adds in trunk/LayoutTests

[Chromium] Rebaseline css1/ tests for Android.
​https://bugs.webkit.org/show_bug.cgi?id=96398

Unreviewed rebaselining.

  • platform/chromium-android/css1/: 136 new .txt and .png results.
12:11 PM Changeset in webkit [129537] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Webkit 1.8.2 fails to build with MinGW with spellchecking enabled
​https://bugs.webkit.org/show_bug.cgi?id=93255

Patch by Paweł Forysiuk <​tuxator@o2.pl> on 2012-09-25
Reviewed by Martin Robinson.

Build dies because of invalid cast. Additionaly word "interface" is in use with MinGW compiler.

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString): Use String to avoid unneded casting

  • webkit/webkitspellcheckerenchant.cpp:

(webkit_spell_checker_enchant_spell_checker_interface_init): rename interface -> checkerInterface

12:06 PM Changeset in webkit [129536] by benjamin@webkit.org
  • 21 edits in trunk

Add missing support for Geolocation tests on WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=97518

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-25
Reviewed by Sam Weinig.

Source/WebKit2:

The existing API for reporting error does not support passing and error message.

The interface UIProcess<->WebProcess is changed to take an error message, the
existing API now pass a null String, and the new function
WKGeolocationManagerProviderDidFailToDeterminePositionWithErrorMessage() provide
the extended support with error message.

  • UIProcess/API/C/WKGeolocationManager.cpp:

(WKGeolocationManagerProviderDidFailToDeterminePositionWithErrorMessage):

  • UIProcess/API/C/WKGeolocationManager.h:
  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):

  • UIProcess/WebGeolocationManagerProxy.h:

(WebGeolocationManagerProxy):

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didFailToDeterminePosition):

  • WebProcess/Geolocation/WebGeolocationManager.h:

(WebGeolocationManager):

  • WebProcess/Geolocation/WebGeolocationManager.messages.in:

Tools:

There are two main features added to the tooling to make the test run:
-Add support for error reporting for position errors through setMockGeolocationPositionUnavailableError.
-Support the 3 states permission: undefined-allowed-denied.

  • WebKitTestRunner/GeolocationProviderMock.cpp:

(WTR::GeolocationProviderMock::GeolocationProviderMock):
(WTR::GeolocationProviderMock::setPosition):
(WTR::GeolocationProviderMock::setPositionUnavailableError):
(WTR::GeolocationProviderMock::startUpdating):
(WTR::GeolocationProviderMock::sendPositionIfNeeded):
(WTR::GeolocationProviderMock::sendErrorIfNeeded):

  • WebKitTestRunner/GeolocationProviderMock.h:

(GeolocationProviderMock):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setMockGeolocationPositionUnavailableError):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::decidePolicyForGeolocationPermissionRequest):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::setGeolocationPermission):
(WTR::TestController::setMockGeolocationPosition):
(WTR::TestController::setMockGeolocationPositionUnavailableError):
(WTR::TestController::handleGeolocationPermissionRequest):
(WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Unskip almost all the layout tests.

  • platform/wk2/Skipped:
11:59 AM Changeset in webkit [129535] by beidson@apple.com
  • 3 edits
    3 adds in trunk

Crash after clicking in plugin at kauaiexplorer.com
<rdar://problem/11525987/> and ​https://bugs.webkit.org/show_bug.cgi?id=90925

Patch by Akash Vaswani <​avaswani@apple.com> on 2012-09-25
Reviewed by Sam Weinig.

Source/WebKit2:

Bug: Clicking the plugin to navigate away from the page caused the browser to crash.

This is because it is possible for a beforeunload handler to destroy the plugin
while it is still needed. In this case the handler set visibility to "none" and
then accessed a property on the plugin script object. This forced a layout
that destroyed the plugin.

Fix: Protecting PluginView objects until they are no longer required.

This was done by adding a RefPtr at the beginning of performURLRequest()

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performURLRequest):

LayoutTests:

  • http/tests/plugins/get-url-beforeunload-destroys-plugin-expected.txt: Added.
  • http/tests/plugins/get-url-beforeunload-destroys-plugin.html: Added.
  • http/tests/plugins/resources/notify-done.html: Added.
11:51 AM Changeset in webkit [129534] by jsbell@chromium.org
  • 10 edits
    6 adds in trunk

IndexedDB: One transaction coordinator per database
​https://bugs.webkit.org/show_bug.cgi?id=97501

Reviewed by Tony Chang.

Source/WebCore:

Per the IDB spec, transactions only need to be sequenced within databases.
The implementation was using one coordinator per factory backend (effectively
a singleton), which would prevent parallel execution of transactions in different
databases. Moved ownership of the transaction coordinator to the database backend.

Tests: storage/indexeddb/transaction-coordination-across-databases.html

storage/indexeddb/transaction-readwrite-exclusive.html

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::create):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::open):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(WebCore):
(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBTransactionCoordinator.cpp:

(WebCore::IDBTransactionCoordinator::create):
(WebCore::IDBTransactionCoordinator::IDBTransactionCoordinator):

  • Modules/indexeddb/IDBTransactionCoordinator.h:

(IDBTransactionCoordinator):

Source/WebKit/chromium:

Remove obsolete argument.

  • tests/IDBDatabaseBackendTest.h:

LayoutTests:

Test that transactions can be parallelized across databases, and ensure that
read/write transactions with overlapping scopes are not parallelized within a
database.

  • storage/indexeddb/resources/transaction-coordination-across-databases.js: Added.
  • storage/indexeddb/resources/transaction-readwrite-exclusive.js: Added.
  • storage/indexeddb/transaction-coordination-across-databases-expected.txt: Added.
  • storage/indexeddb/transaction-coordination-across-databases.html: Added.
  • storage/indexeddb/transaction-readwrite-exclusive-expected.txt: Added.
  • storage/indexeddb/transaction-readwrite-exclusive.html: Added.
11:45 AM WebKitGTK/1.10.x edited by Martin Robinson
(diff)
11:33 AM Changeset in webkit [129533] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Don't kill automatically the web process when the ui process finishes
​https://bugs.webkit.org/show_bug.cgi?id=97580

Reviewed by Martin Robinson.

We use prctl(PR_SET_PDEATHSIG, SIGKILL); in linux to make sure the
web process is killed when the UI process finishes. This is not
needed any more since now the web process stops the main loop when
the connection with the UI process is closed in
WebProcess::didClose(). This approach is better because it works
for any platform and makes the web process finish normally from
main().

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::childSetupFunction): Don't call prctl(PR_SET_PDEATHSIG,
SIGKILL) in the child process.

11:30 AM Changeset in webkit [129532] by commit-queue@webkit.org
  • 21 edits
    2 deletes in trunk

Unreviewed, rolling out r129517.
​http://trac.webkit.org/changeset/129517
​https://bugs.webkit.org/show_bug.cgi?id=97582

Link errors in chromium (Requested by alecf on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-25

Source/Platform:

  • chromium/public/WebMediaConstraints.h:

(WebMediaConstraints):

Source/WebCore:

  • Modules/mediastream/MediaConstraintsImpl.cpp:
  • Modules/mediastream/MediaConstraintsImpl.h:
  • Modules/mediastream/NavigatorMediaStream.cpp:

(WebCore::NavigatorMediaStream::webkitGetUserMedia):

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):

  • Modules/mediastream/UserMediaRequest.h:

(WebCore):
(UserMediaRequest):
(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):

  • platform/chromium/support/WebMediaConstraints.cpp:

Source/WebKit/chromium:

  • public/WebUserMediaRequest.h:

(WebUserMediaRequest):

  • src/WebUserMediaRequest.cpp:

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/MockConstraints.cpp: Removed.
  • DumpRenderTree/chromium/MockConstraints.h: Removed.
  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(isSupportedConstraint):
(isValidConstraint):
(MockWebRTCPeerConnectionHandler::initialize):

  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp:

(WebKit::WebUserMediaClientMock::requestUserMedia):

  • DumpRenderTree/chromium/WebUserMediaClientMock.h:

(WebKit):
(WebUserMediaClientMock):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebKit):
(WebViewHost):

LayoutTests:

  • fast/mediastream/getusermedia-expected.txt:
  • fast/mediastream/getusermedia.html:
11:29 AM Changeset in webkit [129531] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Build fix, GeolocationClientMock should not be included by WebProcess InjectedBundle

Unreviewed.

The patch r129252 removes the dependencies on GeolocationClientMock, r129444 removes
GeolocationClientMock from the Mac port. The #include breaks new Mac build.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:
11:22 AM Changeset in webkit [129530] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

[CSS Exclusions] Enable css exclusions for multiple blocks per element
​https://bugs.webkit.org/show_bug.cgi?id=89993

Patch by Bear Travis <​betravis@adobe.com> on 2012-09-25
Reviewed by Julien Chaffraix.

Source/WebCore:

Similar to multi-column layout, a parent RenderBlock's WrapShapeInfo may affect
the inline content of its children. This patch follows the example of ColumnInfo
and adds WrapShapeInfo to LayoutState, which tracks the current shape-inside that
inline content should respect.

Tests: fast/exclusions/shape-inside/shape-inside-multiple-blocks.html

fast/exclusions/shape-inside/shape-inside-multiple-blocks-vertical.html

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState): Initialize m_wrapShapeInfo.

  • rendering/LayoutState.h:

(WebCore):
(WebCore::LayoutState::LayoutState): Initialize m_wrapShapeInfo.
(LayoutState):
(WebCore::LayoutState::wrapShapeInfo): Getter for m_wrapShapeInfo.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::LineWidth): Use LayoutState to lookup WrapShapeInfo.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Ditto.

  • rendering/RenderView.h:

(WebCore::RenderView::pushLayoutState): Push LayoutState if a WrapShapeInfo
is present.

LayoutTests:

Adding tests to cover the case where a shape-inside affects block children's
inline content.

  • fast/exclusions/shape-inside/shape-inside-multiple-blocks-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-multiple-blocks-vertical-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-multiple-blocks-vertical.html: Added.
  • fast/exclusions/shape-inside/shape-inside-multiple-blocks.html: Added.
11:19 AM Changeset in webkit [129529] by eae@chromium.org
  • 10 edits
    2 adds in trunk

[chromium] REGRESSION: Incorrect preferred width calculation for table cells
​https://bugs.webkit.org/show_bug.cgi?id=97497

Reviewed by Levi Weintraub.

Source/WebCore:

In fixing bug 93911 r125694 caused a problem with the preferred
width calculations for table cells with a fractional padding
where the logic to ensure that the cell is wide enough for the
content returns different results for cells with a fixed width
and cells with an automatic width.

Test: fast/sub-pixel/table-cells-have-stable-width.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):
Move the logic that ensures that a cell is wide enough from AutoTableLayout::recalcColumn to RenderBlock::computePreferredLogicalWidths to. This way it also applies to FixedTableLayout which had the same problem.

LayoutTests:

Added test for cell width calculation and reverted three svg tests to the results prior to r125694.

  • fast/sub-pixel/table-cells-have-stable-width-expected.txt: Added.
  • fast/sub-pixel/table-cells-have-stable-width.html: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
11:12 AM Changeset in webkit [129528] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Handling required for multiple consecutive whitespace
​https://bugs.webkit.org/show_bug.cgi?id=97575

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-09-25
Reviewed by Rob Buis.

PR211670
Need specific handling in the case where we have multiple
consecutive whitespaces which exceeds our character limit. This
breaks some of the functionality employed with the visible_units
methods used here to tranverse the text.

Internally reviewed by Mike Fenton.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::trimWhitespaceFromRange):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::isEmptyRangeOrAllSpaces):

  • WebKitSupport/DOMSupport.h:

(WebCore):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spellCheckBlock):
(BlackBerry::WebKit::InputHandler::getRangeForSpellCheckWithFineGranularity):

10:46 AM Changeset in webkit [129527] by dmazzoni@google.com
  • 11 edits in trunk

AX: Chromium doesn't pass accessibility text range and line number tests
​https://bugs.webkit.org/show_bug.cgi?id=97246

Reviewed by Chris Fleizach.

Source/WebCore:

Adds a method to get all line breaks at once, so retrieving all
line breaks isn't an O(n2) operation for Chromium.

Enables four existing tests to pass on Chromium:
Tests: accessibility/textarea-insertion-point-line-number.html

accessibility/textarea-line-for-index.html
accessibility/textarea-selected-text-range.html
accessibility/textbox-role-reports-selection.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::lineBreaks):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::lineBreaks):
(WebCore):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

Source/WebKit/chromium:

Use improved implementation of AccessibilityRenderObject::lineBreaks
and implement methods to get the line number of the selection and
to set the text range.

Enables four existing tests to pass on Chromium:
Tests: accessibility/textarea-insertion-point-line-number.html

accessibility/textarea-line-for-index.html
accessibility/textarea-selected-text-range.html
accessibility/textbox-role-reports-selection.html

  • public/WebAccessibilityObject.h:

(WebAccessibilityObject):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::selectionEndLineNumber):
(WebKit):
(WebKit::WebAccessibilityObject::selectionStartLineNumber):
(WebKit::WebAccessibilityObject::setSelectedTextRange):
(WebKit::WebAccessibilityObject::lineBreaks):

Tools:

Provide a chromium implementation of some AccessibilityUIElement
methods needed by accessibility tests.

Enables four existing tests to pass on Chromium:
Tests: accessibility/textarea-insertion-point-line-number.html

accessibility/textarea-line-for-index.html
accessibility/textarea-selected-text-range.html
accessibility/textbox-role-reports-selection.html

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(AccessibilityUIElement::insertionPointLineNumberGetterCallback):
(AccessibilityUIElement::selectedTextRangeGetterCallback):
(AccessibilityUIElement::lineForIndexCallback):
(AccessibilityUIElement::setSelectedTextRangeCallback):

LayoutTests:

Enables four tests on chromium:
Tests: accessibility/textarea-insertion-point-line-number.html

accessibility/textarea-line-for-index.html
accessibility/textarea-selected-text-range.html
accessibility/textbox-role-reports-selection.html

  • platform/chromium/TestExpectations:
10:28 AM Changeset in webkit [129526] by jocelyn.turcotte@digia.com
  • 4 edits in trunk/Source/WebKit2

[Qt] PageViewportController: Consolidate positionRangeForViewportAtScale and boundPosition
​https://bugs.webkit.org/show_bug.cgi?id=97222

Reviewed by Kenneth Rohde Christiansen.

Those methods are used together everywhere, merge them into a single
clampViewportToContents method.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::innerBoundedViewportScale):
(WebKit::PageViewportController::outerBoundedViewportScale):
(WebKit::PageViewportController::clampViewportToContents):
(WebKit):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::syncVisibleContents):

  • UIProcess/PageViewportController.h:

(PageViewportController):
(WebKit):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::nearestValidVisibleContentsRect):

10:24 AM Changeset in webkit [129525] by commit-queue@webkit.org
  • 8 edits in trunk

CSP paths: Ignore invalid path components, rather than dropping the source completely.
​https://bugs.webkit.org/show_bug.cgi?id=97538

Patch by Mike West <​mkwst@google.com> on 2012-09-25
Reviewed by Adam Barth.

Source/WebCore:

Content Security Policy directives that accept source lists currently
handle soure URI paths containing '?' or '#' in a draconian fashion by
dropping the entire source expression. We should be slightly friendlier,
and ignore simply the portion of the source expression that we know to
be invalid, just as we previously ignored everything after and including
a '/' in source expressions before we supported paths.

The new behavior is covered by existing tests, and two test-cases added
to http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02.html.

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPSourceList::parsePath):

Report an error to the console, rather than ignoring a path that
contains an invalid fragment or query.

(WebCore::ContentSecurityPolicy::reportInvalidPathCharacter):
(WebCore):

  • page/ContentSecurityPolicy.h:

Add a new warning type to cover this case.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/source-list-parsing-05-expected.txt:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-06-expected.txt:

Updating to the new error message.

  • http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02-expected.txt:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02.html:

Adding new tests to check that valid paths followed by '?' or '#'
drop the invalid component, but remain valid sources.

10:22 AM Changeset in webkit [129524] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Reverting implementation for 407 error pages
​https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by ​commit-queue@webkit.org <​commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> on 2012-09-25
Reviewed by Rob Buis.

Adding additional fixes to NetworkJob since BlackBerry::Platform::Client
is no longer avaliable. Using BlackBerryPlatformSettings to get proxy
information instead.

BlackBerryPlatformClient was deleted in PR 170160.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

10:12 AM Changeset in webkit [129523] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

GIFImageReader: fix tautological compare
​https://bugs.webkit.org/show_bug.cgi?id=97563

Reviewed by Adam Barth.

The frame_reader->disposal_method field is of type
ImageFrame::FrameDisposalMethod, which has a range of 0--3. Therefore,
recent versions of Clang concludes that the expression
frame_reader->disposal_method == 4
will never be true, and warns about it.

This patch fixes the code by doing the comparison before storing the
value in the enum.

No new functionality, no new tests.

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::read):

10:10 AM Changeset in webkit [129522] by peter@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Android's build archives have grown from 38M to 102M in 11 days
​https://bugs.webkit.org/show_bug.cgi?id=97336

Reviewed by Adam Barth.

Each WebKit target results in four APKs in the out/{Debug,Release}/ directory,
while we really only need one. Ignoring the unsigned APKs removes six from
the archive will make sure that we only archive a single APK per target,
bringing its size back to rougly 40 megabytes.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

10:08 AM Changeset in webkit [129521] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

committers-autocomplete.js works only with WebKit based browsers
​https://bugs.webkit.org/show_bug.cgi?id=66752

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2012-09-25
Reviewed by Darin Adler.

Modified the code do only add event listeners to the given inputs,
and not to the full document.

  • committers-autocomplete.js:
9:39 AM Changeset in webkit [129520] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing failure expectations for a few passing reftests and reclassifying
one reftest as flaky.

  • platform/gtk/TestExpectations:
9:39 AM Changeset in webkit [129519] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

#undef some symbols before redefining them.
​https://bugs.webkit.org/show_bug.cgi?id=97568.

Reviewed by Michael Saboff.

  • wtf/Platform.h:
9:37 AM Changeset in webkit [129518] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/1229

Merge 129469 - adoptNode() shouldn't reset ownerDocument if the source node failed to remove itself
BUG=150966
Review URL: ​https://codereview.chromium.org/10987026

9:30 AM Changeset in webkit [129517] by tommyw@google.com
  • 21 edits
    2 copies in trunk

MediaStream API: Update getUserMedia to match the latest specification
​https://bugs.webkit.org/show_bug.cgi?id=97540

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebMediaConstraints.h:

(WebMediaConstraints):

Source/WebCore:

​http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

Existing tests expanded to cover the new change.

  • Modules/mediastream/MediaConstraintsImpl.cpp:

(WebCore::MediaConstraintsImpl::create):
(WebCore):

  • Modules/mediastream/MediaConstraintsImpl.h:

(MediaConstraintsImpl):

  • Modules/mediastream/NavigatorMediaStream.cpp:

(WebCore::NavigatorMediaStream::webkitGetUserMedia):

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::parseOptions):
(WebCore):
(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::audioConstraints):
(WebCore::UserMediaRequest::videoConstraints):

  • Modules/mediastream/UserMediaRequest.h:

(WebCore):
(UserMediaRequest):

  • platform/chromium/support/WebMediaConstraints.cpp:

(WebKit::WebMediaConstraints::WebMediaConstraints):
(WebKit):

Source/WebKit/chromium:

​http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.

  • public/WebUserMediaRequest.h:

(WebKit):
(WebUserMediaRequest):

  • src/WebUserMediaRequest.cpp:

(WebKit::WebUserMediaRequest::audioConstraints):
(WebKit):
(WebKit::WebUserMediaRequest::videoConstraints):

Tools:

Adding mock support for the enhanced getUserMedia call.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/MockConstraints.cpp: Copied from Source/WebCore/platform/chromium/support/WebMediaConstraints.cpp.

(MockConstraints):
(MockConstraints::isSupported):
(MockConstraints::isValid):
(MockConstraints::verify):

  • DumpRenderTree/chromium/MockConstraints.h: Copied from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h.

(WebKit):
(MockConstraints):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(MockWebRTCPeerConnectionHandler::initialize):

  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp:

(UserMediaRequestTask):
(UserMediaRequestTask::UserMediaRequestTask):
(WebUserMediaClientMock::requestUserMedia):

  • DumpRenderTree/chromium/WebUserMediaClientMock.h:

(WebUserMediaClientMock):
(WebUserMediaClientMock::taskList):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebKit):
(WebViewHost):

LayoutTests:

Expanding tests to cover the new getUserMedia behaviour.

  • fast/mediastream/getusermedia-expected.txt:
  • fast/mediastream/getusermedia.html:
9:22 AM Changeset in webkit [129516] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: yellow on-hover pop-up won't go if another pane asynchronously opens
​https://bugs.webkit.org/show_bug.cgi?id=97120

Patch by mire <​mbudaes@adobe.com> on 2012-09-25
Reviewed by Alexander Pavlov.

Add mouseout event listener to popover element so that the pop-up will go when moving to another panel.

No new tests.

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype.show):
(WebInspector.PopoverHelper.prototype._mouseOut):

9:15 AM Changeset in webkit [129515] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[Qt] Unify the PageViewportController<->Client interface regarding positions
​https://bugs.webkit.org/show_bug.cgi?id=97220

Patch by Jocelyn Turcotte <​jocelyn.turcotte@digia.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

  • Make sure that css units are used for all position arguments
  • Make sure that all positions represent the viewport relatively to the contents rather than the other way around
  • Delay clamping the viewport to the contents size in the controller rather than in the client
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::updateViewportSize):

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::didChangeViewportSize):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::positionRangeForViewportAtScale):

  • UIProcess/PageViewportController.h:

(PageViewportController):

  • UIProcess/PageViewportControllerClient.h:

(PageViewportControllerClient):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::nearestValidVisibleContentsRect):
(WebKit::PageViewportControllerClientQt::setViewportPosition):
(WebKit::PageViewportControllerClientQt::updateViewportController):

  • UIProcess/qt/PageViewportControllerClientQt.h:

(PageViewportControllerClientQt):

8:50 AM Changeset in webkit [129514] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Make sure that desktop pages honour the devicePixelRatio
​https://bugs.webkit.org/show_bug.cgi?id=97215

Patch by Jocelyn Turcotte <​jocelyn.turcotte@digia.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

The desktopWidth given to computeViewportAttributes is expected to be pixel-ratio adjusted already.
We need to make sure that the viewport size is divided by the pixel ratio to prevent
the equivalent of a 1.0 devicePixelRatio to be in effect once viewportSize.width() is larger
than layoutFallbackWidth.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):

8:37 AM Changeset in webkit [129513] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening.

Use the right bug number related to
fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html.

  • platform/efl/TestExpectations:
8:23 AM Changeset in webkit [129512] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, skip test that has started showing some flakiness.

  • platform/efl-wk2/TestExpectations:
8:22 AM Changeset in webkit [129511] by caseq@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] adding a page overlay causes endless update loop when accelerated compositing is used
​https://bugs.webkit.org/show_bug.cgi?id=97466

Reviewed by James Robinson.

Do not update overlays in composite() -- doing so ultimately causes invalidation
of the view, hence another update and another call do composite(). Overlays should be
updated only when their content changes.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):

8:18 AM Changeset in webkit [129510] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] Add Undo / Redo method to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=97553

Patch by Simon Pena <Simon Pena> on 2012-09-25
Reviewed by Martin Robinson.

Add the macros for Undo / Redo support, and include them
in the documentation.

  • UIProcess/API/gtk/WebKitEditingCommands.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
8:17 AM Changeset in webkit [129509] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip another test after r129479.

  • platform/efl-wk2/TestExpectations:
8:13 AM EFLWebKit edited by Laszlo Gombos
see ​http://trac.webkit.org/changeset/124094 (diff)
8:05 AM Changeset in webkit [129508] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Abstract as much devicePixelRatio logic as possible behind PageViewportController
​https://bugs.webkit.org/show_bug.cgi?id=97214

Patch by Jocelyn Turcotte <​jocelyn.turcotte@digia.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Currently the client is required to multiply the scales it receives each bime by the
devicePixelRatio. This shouldn't be required since essentially, the only places that the
devicePixelRatio should be in use, is to adjust the layout size, multiply the base scale
and for scale constants.

Other related changes:

  • Make sure that the controller and it's client are only exchanging effective scales (cssScale * devicePixelRatio)
  • Remove members duplicating m_rawAttributes values
  • Use a separate member for the minimum scale to fit the page, separate from the viewport arguments
  • Make sure that the minimum scale to fit is adjusted if the contents size isn't updated after the viewport attributes changed
  • Make the scale conversion functions private to discourage this logic from spreading in the client
  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::innerBoundedViewportScale):
(WebKit::PageViewportController::outerBoundedViewportScale):
(WebKit):
(WebKit::PageViewportController::devicePixelRatio):
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::resumeContent):
(WebKit::PageViewportController::updateMinimumScaleToFit):

  • UIProcess/PageViewportController.h:

(PageViewportController):
(WebKit::PageViewportController::minimumContentsScale):
(WebKit::PageViewportController::maximumContentsScale):
(WebKit::PageViewportController::currentContentsScale):
(WebKit::PageViewportController::fromViewportScale):
(WebKit::PageViewportController::toViewportScale):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::nearestValidVisibleContentsRect):
(WebKit::PageViewportControllerClientQt::setContentsRectToNearestValidBounds):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):

7:56 AM Changeset in webkit [129507] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix typo in accessing union field in a GdkEvent in a WebKit2 unit test
​https://bugs.webkit.org/show_bug.cgi?id=97564

Patch by Simon Pena <Simon Pena> on 2012-09-25
Reviewed by Martin Robinson.

In the WebViewTest::moveMouseTo method, the wrong field in
a union was being accessed in a GdkEvent: instead of the button
field, we were supposed to act on the motion one. This patch
fixes the typo.

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::mouseMoveTo):

7:37 AM Changeset in webkit [129506] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix failing assertion when calling QWebSettings::setIconDatabasePath multiple times

Reviewed by Jocelyn Turcotte.

This happens in various auto-tests. We can implement this by closing the database before
opening it with the new path.

  • Api/qwebsettings.cpp:

(QWebSettings::setIconDatabasePath):

7:36 AM Changeset in webkit [129505] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip crashing test after r129479.

  • platform/efl-wk2/TestExpectations:
7:23 AM Changeset in webkit [129504] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Reverting implementation for 407 error pages
​https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-09-25
Reviewed by Rob Buis.

Revert "[BlackBerry] Show custom error page when 407 is received"
This reverts commit f6fe97ec3f1841a151e4ebdde21f710a6185f9d6.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):

7:15 AM Changeset in webkit [129503] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitFindController
​https://bugs.webkit.org/show_bug.cgi?id=96775

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitFindController.cpp:

(getPage):
(webkitFindControllerConstructed):
(webKitFindControllerPerform):
(webkit_find_controller_search_next):
(webkit_find_controller_search_previous):
(webkit_find_controller_search_finish):

7:07 AM Changeset in webkit [129502] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Cookie info in Network Resources Cookies tab shows "Invalid Date"
​https://bugs.webkit.org/show_bug.cgi?id=97471

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-09-25
Reviewed by Yury Semikhatsky.

The original implementation is trying to create a new Date object
using another Date object, which is invalid. Also, Date.toGMTString is
deprecated.

The fix replaces toGMTString with toUTCString and fixes cookie.expire
so it won't crash when an empty requestDate is passed in.

Following RFC 6265, Max-age attributes now take precedence over expiresi
attribute in CookieParser.

Manual testing on inspector to make sure the CookiesTable is properly generated.

  • inspector/front-end/CookieParser.js:

(WebInspector.Cookie.prototype.expires):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable.prototype._createGridNode):

7:00 AM Changeset in webkit [129501] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark some newly-skipped inspector tests as flaky.

I thought they were just timing out, but it turns out they work
after the first run, so they are just flaky like the others on the
list.

  • platform/efl-wk2/TestExpectations:
6:58 AM Changeset in webkit [129500] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Apply the devicePixelRatio as soon as possible
​https://bugs.webkit.org/show_bug.cgi?id=97211

Patch by Jocelyn Turcotte <​jocelyn.turcotte@digia.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Having to wait for the contents size to apply the devicePixelRatio can
be problematic since the devicePixelRatio affects the layout width, which
then affects the contents size.

Fix the initial issue that this was working around by preventing the
early return if useFixedLayout() is true.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
(QQuickWebViewExperimental::devicePixelRatio):
(QQuickWebViewExperimental::setDevicePixelRatio):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):

6:55 AM Changeset in webkit [129499] by keishi@webkit.org
  • 4 edits in trunk

[Chromium] Enable datalist UI for input type=date
​https://bugs.webkit.org/show_bug.cgi?id=97541

Reviewed by Kent Tamura.

Source/WebCore:

This enables datalist UI for input type=date on Chromium.

No new tests. Adding tests in Bug 97551.

  • rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsDataListUI):

LayoutTests:

  • platform/chromium/fast/forms/datalist/input-list-expected.txt:
6:42 AM Changeset in webkit [129498] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r129494.

  • platform/efl/TestExpectations: Skip a few tests which depend on

V8-only features.

6:33 AM Changeset in webkit [129497] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Don't render at scale 1.0 when doing a pinch-zoom out
​https://bugs.webkit.org/show_bug.cgi?id=97212

Patch by Jocelyn Turcotte <​jocelyn.turcotte@digia.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

When the user starts pinching this creates extra rendering that is bound to the
page size and can be considerably big, reducing performance and peaking the tile
memory usage.

Fixing this might require a different approach that we could experiment with.

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):

6:16 AM Changeset in webkit [129496] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Focus out is not handled properly
​https://bugs.webkit.org/show_bug.cgi?id=96997

Patch by Michael Brüning <​michael.bruning@digia.com> on 2012-09-25
Reviewed by Simon Hausmann.

Adds a handler for QQuickWebView::itemChange event that is sent to
QQuickItems when their focus has been changed to replace focusOutEvent.

This fixes the problem because the focus has been updated when
itemChange is called, while it is not yet update when focusOutEvent
is called.

  • UIProcess/API/qt/qquickwebview.cpp: Removed focusOutEvent.

(QQuickWebView::itemChange): Added in place of focusOutEvent.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::handleFocusLost): Renamed from handleFocusOutEvent, parameter removed.

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

6:14 AM Changeset in webkit [129495] by rakuco@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[EFL] Generate results for test.

  • platform/efl-wk2/TestExpectations: Add a proper bug number for

this test.

  • platform/efl/fast/history/visited-link-background-color-expected.png: Added.
  • platform/efl/fast/history/visited-link-background-color-expected.txt: Added.
5:56 AM Changeset in webkit [129494] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] Do not dump inspector output in DRT
​https://bugs.webkit.org/show_bug.cgi?id=97018

Patch by Raphael Kubo da Costa <​raphael.kubo.da.costa@intel.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Tools:

Some inspector-related layout tests expect console output from the
inspector view to be suppressed. Do that by setting a property in
the inspector view that makes the onConsoleMessage callback return
early and not output anything.

Using evas_object_data_{get,set} is not very beautiful, but it is
still better than properly subclassing Ewk_View and having to
implement something similar to drt_view_console_message_enable_set().

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createWebInspectorView):

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onConsoleMessage):

LayoutTests:

  • platform/efl-wk2/TestExpectations: Skip some tests which still

fail on WK2.

  • platform/efl/Skipped: Unskip a few inspector tests that now

pass.

5:49 AM Changeset in webkit [129493] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[WK2] Supported media MIME types are not included to the list of shown MIME types.
​https://bugs.webkit.org/show_bug.cgi?id=97552

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Exported WebCore::MIMETypeRegistry::isSupportedMediaMIMEType() for MAC.

No new tests. No new functionality.

  • WebCore.exp.in:

Source/WebKit2:

Added supported media MIME types to the list of shown MIME types in order to fix
media tests regression after r129479.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canShowMIMEType):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCanShowMIMEType):

5:31 AM Changeset in webkit [129492] by commit-queue@webkit.org
  • 6 edits
    36 adds in trunk/LayoutTests

[EFL] Partial Skipped file clean up
​https://bugs.webkit.org/show_bug.cgi?id=97554

Unreviewed EFL rebaseline.

Rebaseline several EFL test cases and unskip them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-25

  • platform/efl-wk1/TestExpectations:
  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
  • platform/efl/fast/forms/basic-textareas-expected.png:
  • platform/efl/fast/forms/basic-textareas-expected.txt: Added.
  • platform/efl/fast/forms/basic-textareas-quirks-expected.png:
  • platform/efl/fast/forms/basic-textareas-quirks-expected.txt: Added.
  • platform/efl/fast/text/complex-text-opacity-expected.png: Added.
  • platform/efl/fast/text/complex-text-opacity-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-AN-after-L-expected.png: Added.
  • platform/efl/fast/text/international/bidi-AN-after-L-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
  • platform/efl/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-CS-after-AN-expected.png: Added.
  • platform/efl/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
  • platform/efl/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-listbox-atsui-expected.png: Added.
  • platform/efl/fast/text/international/bidi-listbox-atsui-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/efl/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/efl/fast/text/international/bidi-neutral-run-expected.txt: Added.
  • platform/efl/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/efl/fast/text/international/hebrew-vowels-expected.txt: Added.
  • platform/efl/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/efl/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/efl/fast/text/international/vertical-text-glyph-test-expected.png: Added.
  • platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/efl/fast/text/justify-ideograph-complex-expected.png: Added.
  • platform/efl/fast/text/justify-ideograph-complex-expected.txt: Added.
  • platform/efl/fast/text/large-text-composed-char-expected.png: Added.
  • platform/efl/fast/text/large-text-composed-char-expected.txt: Added.
  • platform/efl/fast/writing-mode/japanese-rl-selection-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
  • platform/efl/fast/writing-mode/japanese-rl-text-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-rl-text-expected.txt: Added.
  • platform/efl/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Added.
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Added.
5:20 AM Changeset in webkit [129491] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening.

Move test that is only failing for WK1 to the specific
TestExpectations file.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
5:19 AM Changeset in webkit [129490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Added hideColorPicker test case
​https://bugs.webkit.org/show_bug.cgi?id=97522

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Added a test case for removing input element during color picker is shown.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(setColorPickerColor):
(showColorPicker):
(hideColorPicker):
(TEST_F):

4:49 AM Changeset in webkit [129489] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] Unskip several test cases that are now passing
​https://bugs.webkit.org/show_bug.cgi?id=97550

Unreviewed gardening.

Unskip several test cases that are now passing for
WebKit2.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-25

  • platform/wk2/Skipped:
4:44 AM Changeset in webkit [129488] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[EFL] unskip toDataURL tests
​https://bugs.webkit.org/show_bug.cgi?id=97549

Unreviewed EFL gardening.

EFL port only supports "image/png" at the moment but only png is actually required
by spec and not testing required support is bad.

Patch by Jussi Kukkonen <​jussi.kukkonen@intel.com> on 2012-09-25

  • platform/efl/Skipped:
  • platform/efl/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
  • platform/efl/fast/canvas/toDataURL-supportedTypes-expected.txt: Added.
4:23 AM Changeset in webkit [129487] by commit-queue@webkit.org
  • 7 edits in trunk

[WK2][WKTR] TestRunner needs support for setWillSendRequestReturnsNullOnRedirect
​https://bugs.webkit.org/show_bug.cgi?id=97542

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implement support for setWillSendRequestReturnsNullOnRedirect
in WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willSendRequestForFrame):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
(WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
(TestRunner):

LayoutTests:

Unskip http/tests/misc/will-send-request-returns-null-on-redirect.html
for WebKit2 now that WebKitTestRunner supports
setWillSendRequestReturnsNullOnRedirect.

  • platform/wk2/Skipped:
4:06 AM Changeset in webkit [129486] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[WK2] Remove passing tests from Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=97546

Unreviewed gardening.

Unskip several unclassified test cases as they appear
to now pass for WebKit2. A few remaining failures
were classified as well.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-25

  • platform/efl/Skipped:
  • platform/wk2/Skipped:
3:58 AM Changeset in webkit [129485] by vsevik@chromium.org
  • 4 edits in trunk

Web Inspector: ResourceScriptMapping should no steal scripts from other mappings.
​https://bugs.webkit.org/show_bug.cgi?id=97453

Reviewed by Pavel Feldman.

Source/WebCore:

Exposed sourceMapping getter on Script so that resource mapping could check it.

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._reset):

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
3:48 AM Changeset in webkit [129484] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] More gardening.

Skip inspector/styles/variables/css-variables.html on WK2, specify
all CSS Sticky-related tests that are currently failing because
some are passing regardless of whether ENABLE_CSS_STICKY_POSITION
is enabled or not and update the way
http/tests/loading/307-after-303-after-post.html is being flaky.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
3:01 AM Changeset in webkit [129483] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Daily gardening. Skip a few failing tests.

  • platform/efl/TestExpectations:
2:58 AM Changeset in webkit [129482] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] [DRT] fast/forms/textarea-live-pseudo-selectors.html failed
​https://bugs.webkit.org/show_bug.cgi?id=97189

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2012-09-25
Reviewed by Rob Buis.

Translate ASCII key code to BlackBerry key code for BACKSPACE and DELETE key.

  • DumpRenderTree/blackberry/EventSender.cpp:

(keyDownCallback):

2:49 AM Changeset in webkit [129481] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new failing test.

  • platform/qt/Skipped:
2:39 AM Changeset in webkit [129480] by keishi@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r129448): multiple fields time input UI doesn't use system time format settings on Chromium-Mac
​https://bugs.webkit.org/show_bug.cgi?id=97517

Reviewed by Kent Tamura.

We need to locale [NSLocale currentLocale] if browser language/@lang equals [[NSLocal currentLocale] localeIdentifier]. Otherwise it won't use the custom time format that the user has set.

No new tests. Unable to test because we need to change system locale settings.

  • platform/text/mac/LocaleMac.h:

(LocaleMac):

  • platform/text/mac/LocaleMac.mm:

(WebCore::languageFromLocale): Moved to top.
(WebCore):
(WebCore::determineLocale): Modified so it takes a locale as an argument.
(WebCore::Localizer::create):
(WebCore::LocaleMac::LocaleMac): Added checks for invalid locales to this constructor and removed the other one so we don't have duplicated code.
(WebCore::LocaleMac::create):
(WebCore::LocaleMac::currentLocale):

2:19 AM Changeset in webkit [129479] by commit-queue@webkit.org
  • 9 edits in trunk

[WK2][WTR] WTR bundle client loads binary data as text
​https://bugs.webkit.org/show_bug.cgi?id=97532

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-09-25
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Added WKBundlePageCanShowMIMEType() function to WKBundlePage private API.
This function is put to WKBundlePage to keep consistency with WebKit::WebPageProxy::canShowMIMEType().
Actually it does not need anything from page.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCanShowMIMEType):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

WTR::InjectedBundlePage::decidePolicyForResponse now checks response MIME type
and returns WKBundlePagePolicyActionPassThrough if it cannot be shown.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::decidePolicyForResponse):

LayoutTests:

Unskipped http/tests/loading/text-content-type-with-binary-extension.html for WK2.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/wk2/Skipped:
2:09 AM Changeset in webkit [129478] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed, another test case adjustment after r129459. Python 2.7 doesn't
seem to be a requirement yet so the assertDictEqual method is not yet available
on all builders. Assert that the empty dictionary length equals 0 instead.

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.test_interpret_test_failures):

2:01 AM Changeset in webkit [129477] by apavlov@chromium.org
  • 8 edits
    1 add in trunk

Web Inspector: Relative URL Link Tooltips do not respect <base>
​https://bugs.webkit.org/show_bug.cgi?id=43434

Reviewed by Pavel Feldman.

Source/WebCore:

New "baseURL" field added into the DOM.Node payload for document nodes and is made use of while resolving and completing URLs.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::documentBaseURLString):
(WebCore):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.resolveURL):
(WebInspector.DOMDocument):

LayoutTests:

Added an iframe containing the <base> tag to test DOMNode.prototype.resolveURL() with a non-trivial baseURL.

  • inspector/elements/elements-panel-rewrite-href.html:
  • inspector/elements/elements-panel-rewrite-href-expected.txt:
  • inspector/elements/resources/elements-panel-rewrite-href-iframe.html: Added.
1:39 AM Changeset in webkit [129476] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: The JS code injected by worker inspector shouldn't be evaluated through JSMainThreadExecState
​https://bugs.webkit.org/show_bug.cgi?id=95341

Patch by Peter Wang <​peter.wang@torchmobile.com.cn> on 2012-09-25
Reviewed by Yury Semikhatsky.

Add extra code to "JSC::InjectedScriptManager" and "JSC::ScriptFunctionCall" to make sure the
interfaces of JSMainThreadExecState are invoked only in main thread.

No new test case for this bug. Without this patch, opening worker inspector will meet failed assert statements.

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):

1:34 AM Changeset in webkit [129475] by Carlos Garcia Campos
  • 10 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitWebView
​https://bugs.webkit.org/show_bug.cgi?id=96767

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitContextMenuClient.cpp:

(getContextMenuFromProposedMenu):

  • UIProcess/API/gtk/WebKitResourceLoadClient.cpp:

(didInitiateLoadForResource):

  • UIProcess/API/gtk/WebKitUIClient.cpp:

(createNewPage):
(runJavaScriptPrompt):
(mouseDidMoveOverElement):
(printFrame):

  • UIProcess/API/gtk/WebKitURIRequest.cpp:

(webkitURIRequestCreateForResourceRequest):
(webkitURIRequestGetResourceRequest):

  • UIProcess/API/gtk/WebKitURIRequestPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(allowModalDialogsChanged):
(zoomTextOnlyChanged):
(webkitWebViewSetSettings):
(webkitWebViewConstructed):
(webkitWebViewUpdateURI):
(webkitWebViewCreateNewPage):
(webkitWebViewRunJavaScriptPrompt):
(webkitWebViewMouseTargetChanged):
(webkitWebViewPrintFrame):
(webkitWebViewResourceLoadStarted):
(webkitWebViewPopulateContextMenu):
(webkit_web_view_load_uri):
(webkit_web_view_load_html):
(webkit_web_view_load_alternate_html):
(webkit_web_view_load_plain_text):
(webkit_web_view_load_request):
(webkit_web_view_reload):
(webkit_web_view_reload_bypass_cache):
(webkit_web_view_stop_loading):
(webkit_web_view_go_back):
(webkit_web_view_can_go_back):
(webkit_web_view_go_forward):
(webkit_web_view_can_go_forward):
(webkit_web_view_get_custom_charset):
(webkit_web_view_set_custom_charset):
(webkit_web_view_go_to_back_forward_list_item):
(webkit_web_view_set_settings):
(webkit_web_view_set_zoom_level):
(webkit_web_view_get_zoom_level):
(webkit_web_view_can_execute_editing_command):
(webkit_web_view_execute_editing_command):
(webkit_web_view_run_javascript):
(webkit_web_view_get_inspector):
(webkit_web_view_can_show_mime_type):
(ViewSaveAsyncData):
(getContentsAsMHTMLDataCallback):
(webkit_web_view_save):
(webkit_web_view_save_finish):
(webkit_web_view_save_to_file):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate):
(webkitWebViewBaseCreateWebPage):

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
1:20 AM Changeset in webkit [129474] by apavlov@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebCore/inspector/front-end/inspector.css

Merge 129117 - Web Inspector: [Elements] Word wrap disablement in the DOM tree broken
​https://bugs.webkit.org/show_bug.cgi?id=97185

Reviewed by Pavel Feldman.

Restored the effective "white-space: nowrap" for the tree elements.

  • inspector/front-end/inspector.css:

(.nowrap):

TBR=​apavlov@chromium.org
Review URL: ​https://codereview.chromium.org/10978018

1:15 AM Changeset in webkit [129473] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSParserString: Avoid pointless String refcount churn in init().
<​http://webkit.org/b/94748>

Reviewed by Sam Weinig.

Have CSSParserString::init() take a const String& instead of a String.

  • css/CSSParserValues.h:

(WebCore::CSSParserString::init):

1:14 AM Changeset in webkit [129472] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Update minimal required versions for dependencies
​https://bugs.webkit.org/show_bug.cgi?id=97523

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-25
Reviewed by Gyuyoung Kim.

Use the same versions numbers for dependencies as in Tools/efl/jhbuild.modules.

  • Source/cmake/OptionsEfl.cmake:
1:08 AM Changeset in webkit [129471] by Simon Hausmann
  • 4 edits in trunk

[Qt] Fix build with latest Qt 5
​https://bugs.webkit.org/show_bug.cgi?id=97479

Reviewed by Tor Arne Vestbø.

.:

Define MODULE_BASE_DIR before loading qt_module.prf, which now calls syncqt. MODULE_BASE_DIR is
passed as last parameter (source dir) to syncqt now, so set it to the directory that contains
sync.profile.

  • Source/api.pri:

Tools:

The variables for syncqt handling are now set in api.pri, but let's add a comment here that we can
remove them from default_pre.prf once we're past Qt 5 beta2.

  • qmake/mkspecs/features/default_pre.prf:
1:05 AM Changeset in webkit [129470] by apavlov@chromium.org
  • 12 edits in trunk

Web Inspector: [Styles] For group selectors, transmit their segments with the "matches" flag
​https://bugs.webkit.org/show_bug.cgi?id=96999

Reviewed by Pavel Feldman.

Source/WebCore:

The CSSRule protocol object has been modified to include a SelectorList object that contains selector-related data.
CSSAgent methods that return CSS rule matches will return RuleMatch objects that encapsulate matching CSSRules
with indices of matching selectors on the associated selector list, so the additional backend roundtrips
from StylesSidebarPane are no longer necessary.

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildObjectForRule):
(WebCore):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore):
(WebCore::InspectorStyleSheet::buildObjectForRule):

  • inspector/InspectorStyleSheet.h:

(InspectorStyleSheet):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.parseRuleMatchArrayPayload):
(WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
(WebInspector.CSSRule):
(WebInspector.CSSRule.parsePayload):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
(WebInspector.StylePropertiesSection.prototype._markSelectorMatches):
(WebInspector.StylePropertiesSection.prototype._moveEditorFromSelector):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled):

LayoutTests:

  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:
1:01 AM Changeset in webkit [129469] by morrita@google.com
  • 3 edits
    2 adds in trunk

adoptNode() shouldn't reset ownerDocument if the source node failed to remove itself
​https://bugs.webkit.org/show_bug.cgi?id=97527

Reviewed by Ryosuke Niwa.

Source/WebCore:

Document::adoptNode() overlooked an error which can happen in Node::removeChild().
Which results an assertion failure. This change adds an error check for that code path.

Test: fast/dom/adopt-node-prevented.html

  • dom/Document.cpp:

(WebCore::Document::adoptNode):

LayoutTests:

  • fast/dom/adopt-node-prevented-expected.txt: Added.
  • fast/dom/adopt-node-prevented.html: Added.
12:59 AM Changeset in webkit [129468] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviwed gardening. Greening bots.

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-09-25

  • platform/qt/Skipped:
12:55 AM Changeset in webkit [129467] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Partial Skipped file clean up
​https://bugs.webkit.org/show_bug.cgi?id=97531

Unreviewed EFL gardening.

Move part of the test cases from Skipped file
to TestExpectations since we want to get rid
of the Skipped list soon.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-25

  • platform/efl-wk2/TestExpectations:
  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
12:54 AM Changeset in webkit [129466] by loislo@chromium.org
  • 37 edits
    1 add in trunk/Source

Web Inspector: extract Vector instrumentation from core NMI code into MemoryInstrumentationVector.h header.
​https://bugs.webkit.org/show_bug.cgi?id=96650

Reviewed by Vsevolod Vlasov.

Source/WebCore:

addInstrumentedVector and addInstrumentedVectorPtr were replaced with addMember.
The same thing happens with addVector and addVectorPtr.

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportDescendantMemoryUsage):

  • css/CSSRuleList.cpp:

(WebCore::StaticCSSRuleList::reportMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::reportDescendantMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaQuerySet::reportMemoryUsage):

  • css/MediaQuery.cpp:

(WebCore::MediaQuery::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBlock::reportDescendantMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportDescendantMemoryUsage):

  • css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::reportDescendantMemoryUsage):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::reportMemoryUsage):

Source/WebKit/chromium:

Test for instrumented vector.

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::InstrumentedOwner::InstrumentedOwner):
(WebCore::TEST):
(WebCore):

Source/WTF:

Added reportMemoryUsage free template function with default body to core NMI code
and add custom version of reportMemoryUsage function for Vectors.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/MemoryInstrumentation.h:

(WTF):
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::addObjectImpl):

  • wtf/MemoryInstrumentationVector.h: Added.

(WTF):
(WTF::instrumentVectorValues):
(WTF::reportMemoryUsage):

12:53 AM Changeset in webkit [129465] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed, adjusting the test cases after r129459. The JSON data
for reftests now contains the 'reftest_type' key and no more 'is_reftest'
or 'is_mismatch_reftest' keys.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(EndToEndTest.test_reftest_with_two_notrefs):

12:33 AM Changeset in webkit [129464] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

REGRESSION(r129346): It broke !ENABLE(INSPECTOR) build
​https://bugs.webkit.org/show_bug.cgi?id=97490

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-09-25
Reviewed by Csaba Osztrogonác.

The dummy class implementation must be under the ENABLE(INSPECTOR)
guard. Added them to prevent from braking the build with --minimal
option for build-webkit

No new tests as caused by missing compile guard.

  • testing/Internals.cpp:

(WebCore):

12:04 AM Changeset in webkit [129463] by yosin@chromium.org
  • 2 edits
    4 copies in branches/chromium/1271

Merge 129448 - Document::adoptNode for multiple fields time input UI should not crash
​https://bugs.webkit.org/show_bug.cgi?id=97428

Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch changes Document::removeFocusedNodeOfSubtree() to check
focused node in shadow DOM tree for avoiding Document::m_focusedNode
not to have dangling pointer to field owner in DateTimeFieldElement.

Test:

  • fast/dom/shadow/shadow-removechild-and-blur-event.html: test for removeChild dispatches blur event.
  • fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: test for adoptNode not to crash.
  • fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur.html: removeChild of input type "time" dispatches blur event, existing test.
  • dom/Document.cpp:

(WebCore::Document::removeFocusedNodeOfSubtree): Changed to check
focused node in shadow DOM tree in addition to descendant node.

LayoutTests:

This patch adds a test for checking removeChild() of shadow host
dispatches blur event if focused node in shadow tree, a test for
checking adoptNode() doesn't causes crash and dispatches blur event
during document.adoptNode() and updates expectation for focus/blur event test.

  • fast/dom/shadow/shadow-removechild-and-blur-event-expectation.txt: Added.
  • fast/dom/shadow/shadow-removechild-and-blur-event.html: Added for checking removeChild of shadow host dispatchs blur event when focused node in shadow tree.
  • fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur-expected.txt: Updated to expectation to have output from blur event handler.

TBR=​yosin@chromium.org
Review URL: ​https://codereview.chromium.org/10980011

Sep 24, 2012:

11:51 PM Changeset in webkit [129462] by commit-queue@webkit.org
  • 24 edits
    8 adds in trunk

Reland "Add in-place reload behavior to ImagesEnabled setting" with optimizations
​https://bugs.webkit.org/show_bug.cgi?id=97055

Patch by Bo Liu <​boliu@chromium.org> on 2012-09-24
Reviewed by Adam Barth.

Relanding 128780, 128676, 128645. Was reverted in 128914 due to
performance regression in Chromium.

New changes in addition to previously reverted patches:

Refactored CachedResource::requestResource, loadResource, and
revalidateResource. Moved CachedResource::load method to end of
requestResource so there is one place where load is called for all
resources.

Added a enum parameter for requestResource and
determineRevalidationPolicy so that FrameLoaderClient::allowImage call
do not need to be called multiple times.

Removed CachedImage::load call in requestImage so it is not called
twice.

Removed unnecessary Frame.h includes in CachedResource and
CachedImage.

Removed dead load() method declaration in CachedImage.

Updated text expectation for two image-permissions tests to reflect
the removed calls to allowImage.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Tests: fast/loader/display-image-unset-allows-cached-image-load.html

fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

  • loader/cache/CachedResource.h:

(WebCore):
(WebCore::CachedResource::stillNeedsLoad):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore):
(WebCore::CachedResourceLoader::setImagesEnabled):
(WebCore::CachedResourceLoader::clientDefersImage):
(WebCore::CachedResourceLoader::shouldDeferImageLoad):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

  • page/Settings.cpp:

(WebCore::setImageLoadingSettings):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::imageLoadingSettingsTimerFired):
(WebCore::Settings::setImagesEnabled):

  • page/Settings.h:

(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setImagesEnabled):
(WebCore):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

  • win/WebKit2.def:

LayoutTests:

  • fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Added.
  • fast/loader/display-image-unset-allows-cached-image-load.html: Added.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
  • fast/loader/resources/image1.html: Added.
  • fast/loader/resources/image2.html: Added.
  • platform/chromium/permissionclient/image-permissions-expected.txt:
  • platform/chromium/permissionclient/image-permissions.html:
  • platform/chromium/permissionclient/resources/image.html:
  • platform/wk2/Skipped:
11:48 PM Changeset in webkit [129461] by barraclough@apple.com
  • 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=97530
Regression, freeze applied to numeric properties of non-array objects

Reviewed by Filip Pizlo.

Object.freeze has a fast implementation in JSObject, but this hasn't been updated to take into account numeric properties in butterflies.
For now, just fall back to the generic implementation if the object has numeric properties.

Source/JavaScriptCore:

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorFreeze):

  • fallback if the object has a non-zero indexed property vector length.

LayoutTests:

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
    • Added a test case for freezing an object with a numeric property.
11:32 PM Changeset in webkit [129460] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectation for http/tests/security/xss-eval.html as the
test started failing after r129456.

  • platform/gtk/TestExpectations:
11:17 PM Changeset in webkit [129459] by zandobersek@gmail.com
  • 12 edits in trunk

Unexpected reftest passes are only reported when pixel testing is enabled in results.html as well
​https://bugs.webkit.org/show_bug.cgi?id=97426

Reviewed by Ojan Vafai.

Tools:

The 'is_reftest' member of the TestResult class has been replaced by the reftest_type
member which is a set containing either '!=', '==', both or none if the test represented
by the object is not a reftest.

When summarizing results, the test dictionary is updated to contain the 'reftest_type' key
if the test is a reftest. The value of this key is a list of all the reftest types of this test.

The test failure interpretation method has been refactored, it now reports only
missing results of various formats and image diff percent in case of image or
reftest mismatch.

Unit tests have been modified accordingly.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner._update_summary_with_result):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(LayoutTestRunnerTests.test_update_summary_with_result):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(interpret_test_failures):
(summarize_results):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.test_interpret_test_failures):

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.run):
(SingleTestRunner._run_reftest):

  • Scripts/webkitpy/layout_tests/models/test_results.py:

(TestResult.init):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(EndToEndTest.test_reftest_with_two_notrefs):

LayoutTests:

Report unexpectedly passing reftests as well. Test cases included.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
11:12 PM Changeset in webkit [129458] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Bug in numeric accessors on global environment
​https://bugs.webkit.org/show_bug.cgi?id=97526

Reviewed by Geoff Garen.

I've hit this assert in test262 in browser, but haven't yet worked out how to repro in a test case :-/
The sparsemap is failing to map back from the global object to the window shell.
A test case would need to resolve a numeric property name against the global environment.

(JSC::SparseArrayEntry::get):
(JSC::SparseArrayEntry::put):

  • Add missing toThisObject calls.
10:27 PM Changeset in webkit [129457] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

SerializedScriptValue isn't aware of indexed storage, but should be
​https://bugs.webkit.org/show_bug.cgi?id=97515
<rdar://problem/12361874>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Export a method that WebCore now uses.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSObject.h:

(JSObject):

Source/WebCore:

New test: fast/js/post-message-numeric-property.html

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::putProperty):

LayoutTests:

  • fast/js/post-message-numeric-property-expected.txt: Added.
  • fast/js/post-message-numeric-property.html: Added.
  • fast/js/script-tests/post-message-numeric-property.js: Added.

(window.onmessage):

9:52 PM Changeset in webkit [129456] by barraclough@apple.com
  • 7 edits in trunk/Source

Remove JSObject::unwrappedGlobalObject(), JSObject::unwrappedObject()
​https://bugs.webkit.org/show_bug.cgi?id=97519

Reviewed by Geoff Garen.

../JavaScriptCore:

unwrappedGlobalObject() was only needed because globalObject() doesn't always return a helpful result -
specifically for WebCore's window shell the structure's globalObject is set to null. We can fix this by
simply keeping the structure up to date as the window navigates, obviating the need for this function.

The only other use of unwrappedObject() came from globalFuncEval(), and this can be trivially removed
by flipping the way we perform this globalObject check (which we may also be able to remove!) - instead
of getting the globalObject from the provided this value & comparing to the expected globalObject, we
can get the this value from the expected globalObject, and compare to that provided.

  • runtime/JSGlobalObject.cpp:
    • Call globalObject() instead of unwrappedGlobalObject().
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • Changed to compare this object values, instead of globalObjects - this means we only need to be able to map globalObject -> this, and not vice versa.
  • runtime/JSObject.cpp:

(JSC::JSObject::allowsAccessFrom):
(JSC::JSObject::createInheritorID):

  • Call globalObject() instead of unwrappedGlobalObject().
  • runtime/JSObject.h:

(JSObject):

  • Removed unwrappedGlobalObject(), unwrappedObject().

../WebCore:

JSDOMWindowShell::setWindow should update the structure's globalObject.

  • bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::setWindow):

  • Update the JSDOMWindowShell's structure's globalObject when the window changes.
9:50 PM EFLWebKit edited by Laszlo Gombos
Baseline minimal required tool versions (diff)
9:40 PM Changeset in webkit [129455] by yosin@chromium.org
  • 7 edits in trunk/Source/WebCore

[Forms] We should remove DateTimeEditElement::valueAsDouble()
​https://bugs.webkit.org/show_bug.cgi?id=97327

Reviewed by Kent Tamura.

This patch removes unused function DateTimeEditElement::valueAsDouble()
and related functions in DateTimeFieldElement.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

  • html/shadow/DateTimeEditElement.cpp: Removed valueAsDouble() implementation.
  • html/shadow/DateTimeEditElement.h: Removed valueAsDouble() declaration.

(DateTimeEditElement):

  • html/shadow/DateTimeFieldElement.cpp: Removed valueAsDouble() implementation.
  • html/shadow/DateTimeFieldElement.h: Removed unitInMillisecond() and valueAsDouble() declarations.

(DateTimeFieldElement):

  • html/shadow/DateTimeFieldElements.cpp: Removed unitInMillisecond() implementations.
  • html/shadow/DateTimeFieldElements.h:

(DateTimeAMPMFieldElement): Removed unitInMillisecond() declaration.
(DateTimeHourFieldElement): ditto.
(DateTimeMillisecondFieldElement): ditto.
(DateTimeMinuteFieldElement): ditto.
(DateTimeSecondFieldElement): ditto.

9:33 PM Changeset in webkit [129454] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WKProcessGroup can't load injected bundle with file URL
<rdar://problem/12322774>
​https://bugs.webkit.org/show_bug.cgi?id=97520

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKProcessGroup.mm:

(-[WKProcessGroup initWithInjectedBundleURL:]):
Fix typo. We need to pass the string as path, not as a URL.

9:30 PM Changeset in webkit [129453] by mark.lam@apple.com
  • 20 edits in trunk/Source

Deleting the classic interpreter and cleaning up some build options.
​https://bugs.webkit.org/show_bug.cgi?id=96969.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):

  • bytecode/Instruction.h:

(JSC::Instruction::Instruction):

  • interpreter/AbstractPC.cpp:

(JSC::AbstractPC::AbstractPC):

  • interpreter/AbstractPC.h:

(AbstractPC):

  • interpreter/CallFrame.h:

(ExecState):

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::getSourceURLFromCallFrame):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::retrieveArgumentsFromVMCode):
(JSC::Interpreter::retrieveCallerFromVMCode):
(JSC::Interpreter::retrieveLastCaller):

  • interpreter/Interpreter.h:

(JSC::Interpreter::getOpcodeID):
(Interpreter):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

  • offlineasm/asm.rb:
  • offlineasm/offsets.rb:
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(NativeExecutable):
(JSC::NativeExecutable::finishCreation):

  • runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:

(JSGlobalData):
(JSC::JSGlobalData::canUseJIT):
(JSC::JSGlobalData::canUseRegExpJIT):

  • runtime/Options.cpp:

(JSC::Options::initialize):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WTF:

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

  • wtf/Platform.h:
9:25 PM Changeset in webkit [129452] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

Don't use StyleSheetList internally.
​https://bugs.webkit.org/show_bug.cgi?id=97504

Reviewed by Ryosuke Niwa.

StyleSheetList is a DOM type and should not be used internally. Use plain Vector instead and construct StyleSheetList on DOM access only.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::StyleSheetList):
(WebCore::StyleSheetList::styleSheets):
(WebCore):
(WebCore::StyleSheetList::detachFromDocument):

Use live stylesheet vector of the documents stylesheet collection as long as we are attached to a document.
When detached copy the stylesheet vector to a member field and use that instead.

(WebCore::StyleSheetList::length):
(WebCore::StyleSheetList::item):
(WebCore::StyleSheetList::getNamedItem):

  • css/StyleSheetList.h:


Removed StyleSheetVector typedef as Vector<RefPtr<StyleSheet> > is less opaque and not much longer.


(WebCore):
(WebCore::StyleSheetList::create):
(StyleSheetList):
(WebCore::StyleSheetList::document):

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::styleSheets):

  • dom/Document.h:

(Document):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollec

9:09 PM Changeset in webkit [129451] by weinig@apple.com
  • 11 edits
    3 adds in trunk

Use NSUserDefaults rather than an environment variable to control whether to use an XPC Service for the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=97514

Reviewed by Anders Carlsson.

Source/WebKit2:

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • Target.pri:

Add new files.

  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connect):
Move platform specific launch options to a new function, platformConnect.

  • UIProcess/WebProcessProxy.h:
  • UIProcess/efl/WebProcessProxyEfl.cpp: Added.

Move Efl specific launch options here.

(WebKit::WebProcessProxy::platformConnect):

  • UIProcess/gtk/WebProcessProxyGtk.cpp: Added.

Add stub.

(WebKit::WebProcessProxy::platformConnect):

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::platformConnect):
Move Mac specific launch option setting here, and switch from
using an environment variable to NSUserDefaults.

  • UIProcess/qt/WebProcessProxyQt.cpp: Added.

(WebKit::WebProcessProxy::platformConnect):
Add stub.

  • UIProcess/win/WebProcessProxyWin.cpp:

(WebKit::WebProcessProxy::platformConnect):
Add stub.

Tools:

  • Scripts/webkitdirs.pm:

(argumentsForRunAndDebugMacWebKitApp):
Push "-WebKit2UseXPCServiceForWebProcess YES" as arguments when --use-web-process-xpc-service
is provided to set the user default. Move adding of @ARGV to after custom additions as calling
shouldUseXPCServiceForWebProcess() can change @ARGV.

(runMacWebKitApp):
(execMacWebKitAppForDebugging):
Stop setting the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable.

8:55 PM Changeset in webkit [129450] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Source/WebCore: [GTK][EFL] Remove cairo prefix from include statements
​https://bugs.webkit.org/show_bug.cgi?id=97509

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-24
Reviewed by Gyuyoung Kim.

Make the build system consistent by always assuming that directory
that includes the cairo headers is included in the include path.

No new tests as there is no new functionality.

  • platform/cairo/WidgetBackingStoreCairo.cpp:
  • platform/gtk/GtkWidgetBackingStoreX11.cpp:
  • plugins/gtk/PluginViewGtk.cpp:

Source/WebKit2: [GTK][EFL] Remove cairo prefix from include statements
​https://bugs.webkit.org/show_bug.cgi?id=97509

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-24
Reviewed by Gyuyoung Kim.

Make the build system consistent by always assuming that directory
that includes the cairo headers is included in the include path.

  • UIProcess/cairo/BackingStoreCairo.cpp:
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
8:53 PM Changeset in webkit [129449] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK][EFL] Make sure cairo is built with fontconfig support
​https://bugs.webkit.org/show_bug.cgi?id=97513

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-24
Reviewed by Martin Robinson.

The GTK and EFL port of WebKit requires a version of cairo that is built with fontconfig support.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
8:26 PM Changeset in webkit [129448] by yosin@chromium.org
  • 4 edits
    1 copy
    3 adds in trunk

Document::adoptNode for multiple fields time input UI should not crash
​https://bugs.webkit.org/show_bug.cgi?id=97428

Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch changes Document::removeFocusedNodeOfSubtree() to check
focused node in shadow DOM tree for avoiding Document::m_focusedNode
not to have dangling pointer to field owner in DateTimeFieldElement.

Test:

  • fast/dom/shadow/shadow-removechild-and-blur-event.html: test for removeChild dispatches blur event.
  • fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: test for adoptNode not to crash.
  • fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur.html: removeChild of input type "time" dispatches blur event, existing test.
  • dom/Document.cpp:

(WebCore::Document::removeFocusedNodeOfSubtree): Changed to check
focused node in shadow DOM tree in addition to descendant node.

LayoutTests:

This patch adds a test for checking removeChild() of shadow host
dispatches blur event if focused node in shadow tree, a test for
checking adoptNode() doesn't causes crash and dispatches blur event
during document.adoptNode() and updates expectation for focus/blur event test.

  • fast/dom/shadow/shadow-removechild-and-blur-event-expectation.txt: Added.
  • fast/dom/shadow/shadow-removechild-and-blur-event.html: Added for checking removeChild of shadow host dispatchs blur event when focused node in shadow tree.
  • fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur-expected.txt: Updated to expectation to have output from blur event handler.
8:22 PM Changeset in webkit [129447] by commit-queue@webkit.org
  • 2 edits in trunk

[CMake] Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR'.
​https://bugs.webkit.org/show_bug.cgi?id=97419

Patch by Byungwoo Lee <​bw80.lee@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

Use the value of LIB_INSTALL_DIR and EXEC_INSTALL_DIR instead of
hardcoding 'lib' and 'bin' for CMAKE_{ARCHIVE,LIBRARY,RUNTIME}_OUTPUT_DIRECTORY.

  • CMakeLists.txt:

Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Use ${EXEC_INSTALL_DIR} instead of hardcoding "bin".

8:13 PM Changeset in webkit [129446] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Blackberry] Add a software rendering path for media player
​https://bugs.webkit.org/show_bug.cgi?id=97443

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2012-09-24
Reviewed by Yong Li.

This patch adds a software rendering path for media player. When accelerated rendering
is not supported by the media engine for the current media, the rendering will fallback
to this software path.

PR #212386
Reviewed internally by Max Feil.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
(WebCore):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

7:56 PM Changeset in webkit [129445] by benjamin@webkit.org
  • 9 edits in trunk/LayoutTests

We should not expect percent-escaped hostname for invalid URLs
​https://bugs.webkit.org/show_bug.cgi?id=97415

Reviewed by Adam Barth.

The URL layout tests encode some Chromium specific behavior.
Chromium does a partial canonicalization of invalid URLs. Neither Safari, nor Firefox nor Opera
do that.

This patch fix the tests and expectations for the IP tests.

  • fast/url/invalid-urls-utf8-expected.txt:
  • fast/url/invalid-urls-utf8.html:

Move the "empty authority" check from both IP tests to the invalid URLs test. An empty authority
for a standard URL causes an invalid URL, it should be kept as is.

  • fast/url/ipv4-expected.txt:
  • fast/url/ipv6-expected.txt:
  • fast/url/script-tests/ipv4.js:
  • fast/url/script-tests/ipv6.js: Extend a comment to clarify the rule.

Invalid URLs should not be escaped.

7:30 PM Changeset in webkit [129444] by benjamin@webkit.org
  • 46 edits in trunk

Fix Geolocation error reporting in the test support
​https://bugs.webkit.org/show_bug.cgi?id=97386

Source/WebCore:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

GeolocationController currently expose GeolocationError which can be either
PermissionDenied or PositionUnavailable.

In practice, only PositionUnavailable is supported and tested, only Chrome
somewhat expose PermissionDenied.
The correct way to deny the permission is through Geolocation::setIsAllowed().

This patch does some of the initial cleanup toward that goal, reducing how
far GeolocationError is spread.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

Mac does not use GeolocationClientMock, it should not be compiled in WebCore.

  • platform/mock/GeolocationClientMock.cpp:

(WebCore::GeolocationClientMock::GeolocationClientMock):
(WebCore::GeolocationClientMock::setPosition):
(WebCore::GeolocationClientMock::setPositionUnavailableError):
This method replace setError(). It is limited to PositionUnavailable errors.

(WebCore::GeolocationClientMock::reset):
(WebCore::GeolocationClientMock::controllerTimerFired):
(WebCore):
(WebCore::GeolocationClientMock::clearError):

  • platform/mock/GeolocationClientMock.h:

(WebCore):
(GeolocationClientMock):

Source/WebKit/blackberry:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::setMockGeolocationPositionUnavailableError):

  • WebKitSupport/DumpRenderTreeSupport.h:

(DumpRenderTreeSupport):

Source/WebKit/chromium:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

  • public/WebGeolocationClientMock.h:

(WebGeolocationClientMock):

  • src/WebGeolocationClientMock.cpp:

(WebKit::WebGeolocationClientMock::setMockGeolocationPositionUnavailableError):

Source/WebKit/gtk:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setMockGeolocationPositionUnavailableError):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(-[WebView _geolocationDidFailWithMessage:]):

  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockGeolocationPositionUnavailableError):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.
The TestRunner was exposing internal implementation details of
the Geolocation object through setMockGeolocationError().

In practice, only the error code PositionUnavailable is supported
or even implemented.

Exposing setMockGeolocationError() does not make sense for WebKit2 as
passing generic errors from the UIProcess is a bad idea. This is the
opportunity to clean TestRunner and prepare and interface suitable for WebKit2.

  • DumpRenderTree/TestRunner.cpp:

(setMockGeolocationPositionUnavailableErrorCallback):
(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/mac/MockGeolocationProvider.h:
  • DumpRenderTree/mac/MockGeolocationProvider.mm:

(-[MockGeolocationProvider dealloc]):
(-[MockGeolocationProvider resetError]):
(-[MockGeolocationProvider setPosition:]):
(-[MockGeolocationProvider setPositionUnavailableErrorWithMessage:]):
(-[MockGeolocationProvider lastPosition]):
(-[MockGeolocationProvider timerFired]):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/wx/TestRunnerWx.cpp:

(TestRunner::setMockGeolocationPositionUnavailableError):

LayoutTests:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

Update the tests to use setMockGeolocationPositionUnavailableError() instead
of setMockGeolocationError().

Only PositionError.POSITION_UNAVAILABLE was supported, so this not change
anything for the test coverage.

  • fast/dom/Geolocation/error-clear-watch.html:
  • fast/dom/Geolocation/error-expected.txt:
  • fast/dom/Geolocation/maximum-age-expected.txt:
  • fast/dom/Geolocation/reentrant-error-expected.txt:
  • fast/dom/Geolocation/script-tests/error.js:
  • fast/dom/Geolocation/script-tests/maximum-age.js:

(checkError):
(testNonZeroMaximumAge):

  • fast/dom/Geolocation/script-tests/permission-denied-already-error.js:
  • fast/dom/Geolocation/script-tests/reentrant-error.js:
  • fast/dom/Geolocation/script-tests/watch.js:

(checkError):

  • fast/dom/Geolocation/watch-expected.txt:
7:16 PM Changeset in webkit [129443] by tkent@chromium.org
  • 7 edits
    1 copy
    1 add in trunk/Source

[Chromium] Implement ValidationMessageClient for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=97167

Reviewed by Hajime Morita.

Source/WebCore:

  • page/ValidationMessageClient.h:

Add forward declaration for WTF::String.

Source/WebKit/chromium:

Introduce ValidationMessageClientImpl. However actual popup
implementation should be done in WebViewClient.

  • WebKit.gyp: Add ValidationMessageClientImpl.{cpp,h}.
  • public/WebViewClient.h:

(WebKit::WebViewClient::showValidationMessage): Added.
(WebKit::WebViewClient::hideValidationMessage): Added.

  • src/ValidationMessageClientImpl.cpp: Added.

(WebKit::ValidationMessageClientImpl::ValidationMessageClientImpl):
(WebKit::ValidationMessageClientImpl::create):
(WebKit::ValidationMessageClientImpl::~ValidationMessageClientImpl):
Make sure that a popup is closed.
(WebKit::ValidationMessageClientImpl::showValidationMessage):
Implementataion of ValidationMessageClient::showValidationMessage.
minimumSecondToShowValidationMessage and secondPerCharacter are same as
the corresponding values in the current Shadow DOM implementation.
(WebKit::ValidationMessageClientImpl::hideValidationMessage):
Implementataion of ValidationMessageClient::hideValidationMessage.
(WebKit::ValidationMessageClientImpl::isValidationMessageVisible):
Implementataion of ValidationMessageClient::isValidationMessageVisible.
(WebKit::ValidationMessageClientImpl::hideCurrentValidationMessage):
This is a callback function for the timer.

  • src/ValidationMessageClientImpl.h: Added.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • Initialize m_validationMessage.
  • Add a comment for PageClients.
  • src/WebViewImpl.h:

Add m_validationMessage.

7:07 PM Changeset in webkit [129442] by mihaip@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove WebRuntimeFeatures::{enablePushState,isPushStateEnabled}
​https://bugs.webkit.org/show_bug.cgi?id=97506

Reviewed by Adam Barth.

These methods have been no-ops since r127674. All Chromium code that
called them was removed with ​http://crrev.com/155205.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:
6:48 PM Changeset in webkit [129441] by yosin@chromium.org
  • 7 edits in trunk/Source/WebCore

[Forms] DateTimeEditElement should return string value for ease of implementing other date/time input types.
​https://bugs.webkit.org/show_bug.cgi?id=97303

Reviewed by Kent Tamura.

This patch introduces a function DateTimeEditElement::value() for
setting internal text value of TimeInputType with new function
EditControlOwner::formatDateTimeFieldsState() to utilize this protocl
in other date time input types.

We used DateTimeEditElement::valueAsDouble() and and BaseDateAndTimeInputType::serialize()
to make string value then setting internal text value of multiple
fields time input UI. Although, this steps doesn't work well for
other date/time input types.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

  • html/DateTimeFieldsState.cpp:

(WebCore::DateTimeFieldsState::hour23): Added to convert 1 to 12 hour value to 0 to 23 hour.

  • html/DateTimeFieldsState.h:

(DateTimeFieldsState): Added declaration of hour23().

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged): Changed to use DateTimeEditElement::value() instead of DateTimeEditElement::valueAsDouble().
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::formatDateTimeFieldsState): Added to format time.
(WebCore::TimeInputType::restoreFormControlState): Changed to use DateTimeEditElement::value() instead of DateTimeEditElement::valueAsDouble().

  • html/TimeInputType.h:

(DateTimeEditControlOwnerImpl): Added a declaration of formatDateTimeFieldsState().

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::value): Added.

  • html/shadow/DateTimeEditElement.h:

(EditControlOwner): Added a declaration of formatDateTimeFieldsState().
(DateTimeEditElement): Added a declaration of value().

6:26 PM Changeset in webkit [129440] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

Nested try/finally should not confuse the finally unpopper in BytecodeGenerator::emitComplexJumpScopes
​https://bugs.webkit.org/show_bug.cgi?id=97508
<rdar://problem/12361132>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

We're reusing some vector for multiple iterations of a loop, but we were forgetting to clear its
contents from one iteration to the next. Hence if you did multiple iterations of finally unpopping
(like in a nested try/finally and a jump out of both of them) then you'd get a corrupted try
context stack afterwards.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitComplexJumpScopes):

LayoutTests:

  • fast/js/jsc-test-list:
  • fast/js/script-tests/try-try-return-finally-finally.js: Added.

(foo):

  • fast/js/try-try-return-finally-finally-expected.txt: Added.
  • fast/js/try-try-return-finally-finally.html: Added.
6:14 PM Changeset in webkit [129439] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

[WebGL] Intel Mac needs built-in function emulation
​https://bugs.webkit.org/show_bug.cgi?id=96140

Reviewed by Sam Weinig.

Temporarily turn on built-in function emulation for Intel GPUs
on OS X. This is a work-around for a driver bug, and
will be removed once the driver is updated:
​https://bugs.webkit.org/show_bug.cgi?id=97503

This can be tested using the Khronos WebGL conformance
suite, in particular:

conformance/glsl/functions/glsl-function-dot.html
conformance/glsl/functions/glsl-function-length.html
conformance/glsl/functions/glsl-function-normalize.html
conformance/glsl/functions/glsl-function-reflect.html

Note that the faceforward built-in will still cause
problems on Intel GPUs, but this would require an unnecessary
change in the ANGLE project (remember, we're going to
remove this code once the driver is fixed).

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

Temporarily add "Intel" to the list of GPUs we do translation
for in the shader compiler.

6:05 PM Changeset in webkit [129438] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

There is a mistake in InspectorProfilerAgent::enable(bool skipRecompile)
​https://bugs.webkit.org/show_bug.cgi?id=97450

Patch by Peter Wang <​peter.wang@torchmobile.com.cn> on 2012-09-24
Reviewed by Yury Semikhatsky.

The "InspectorProfilerAgent::enable()" should invokes "PageScriptDebugServer" in
no-worker thread.

No new test case.

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::PageProfilerAgent::recompileScript):
(PageProfilerAgent):
(WebCore::WorkerProfilerAgent::recompileScript):
(WorkerProfilerAgent):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::enable):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

5:54 PM Changeset in webkit [129437] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL][WK2] TestRunner needs touch events support.
​https://bugs.webkit.org/show_bug.cgi?id=96465

Patch by Nikhil Bansal <​n.bansal@samsung.com> on 2012-09-24
Reviewed by Kenneth Rohde Christiansen.

Tools:

Simulate touch events in WebkitTestRunner for touch related
layout tests. This patch uses ewk_view_feed_touch_event() to
generate touch events.

  • WebKitTestRunner/EventSenderProxy.h:

(EventSenderProxy):

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR):
(WTR::setEvasModifiers):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::~EventSenderProxy):
(WTR::EventSenderProxy::sendTouchEvent):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::touchCancel):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::cancelTouchPoint):

LayoutTests:

Touch events support added in WebKitTestRunner for layout tests.

  • platform/efl-wk2/TestExpectations:
5:53 PM Changeset in webkit [129436] by vollick@chromium.org
  • 2 edits in branches/chromium/1229/Source/WebCore

CCActiveAnimation should handle durations of zero gracefully

5:46 PM Changeset in webkit [129435] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

ValueToInt32 bool case does bad things to registers
​https://bugs.webkit.org/show_bug.cgi?id=97505
<rdar://problem/12356331>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):

LayoutTests:

  • fast/js/dfg-bool-to-int32-reuse-expected.txt: Added.
  • fast/js/dfg-bool-to-int32-reuse.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-bool-to-int32-reuse.js: Added.

(foo):

5:38 PM Changeset in webkit [129434] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add cloopDo instruction for debugging the llint C++ backend.
​https://bugs.webkit.org/show_bug.cgi?id=97502.

Reviewed by Geoffrey Garen.

  • offlineasm/cloop.rb:
  • offlineasm/instructions.rb:
  • offlineasm/parser.rb:
5:28 PM Changeset in webkit [129433] by Patrick Gansterer
  • 5 edits in trunk/Source

Remove String::operator+=()
​https://bugs.webkit.org/show_bug.cgi?id=96172

Reviewed by Benjamin Poulain.

Source/WebCore:

Replace the last usage with String::append() in Gtk.

  • platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::handleCommit):

Source/WTF:

  • wtf/Platform.h:
  • wtf/text/WTFString.h:
5:20 PM Changeset in webkit [129432] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

JSArray::putByIndex asserts with readonly property on prototype
​https://bugs.webkit.org/show_bug.cgi?id=97435
<rdar://problem/12357084>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Boy, there were some problems:

  • putDirectIndex() should know that it can set the index quickly even if it's a hole and we're in SlowPut mode, since that's the whole point of PutDirect.


  • We should have a fast path for putByIndex().


  • The LiteralParser should not use push(), since that may throw if we're having a bad time.
  • interpreter/Interpreter.cpp:

(JSC::eval):

  • runtime/JSObject.h:

(JSC::JSObject::putByIndexInline):
(JSObject):
(JSC::JSObject::putDirectIndex):

  • runtime/LiteralParser.cpp:

(JSC::::parse):

LayoutTests:

  • fast/js/concat-while-having-a-bad-time.html: Added.
  • fast/js/concat-while-having-a-bad-time-expected.txt: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/concat-while-having-a-bad-time.js: Added.
5:12 PM Changeset in webkit [129431] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip flaky http/tests/security/cookies/xmlhttprequest.html test on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=95803

  • platform/win/Skipped:
5:05 PM Changeset in webkit [129430] by commit-queue@webkit.org
  • 9 edits in trunk

[WK2] TestRunner does not support overridePreference with value "0"
​https://bugs.webkit.org/show_bug.cgi?id=97457

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24
Reviewed by Alexey Proskuryakov.

Tools:

testRunner.overridePreference() was marked as taking a boolean
in argument in testRunner.idl even though the test cases are
passing strings to it. The current code works if the test
case wants to enable a setting and therefore passes "1" string.
However, if the test wants to disable a setting and passes "0"
string, the current code also evaluates this to true causing
certain test cases to fail.

The argument to testRunner.overridePreference() is now of string
type and a function has been added to convert the string passed
by the test to a boolean value.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::toBool):
(WTR):
(WTR::TestRunner::overridePreference):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskip fast/regions/css-regions-disabled.html test case for
WebKit2 now that WebKitTestRunner actually supports overriding
a boolean preference with "0" value (to disable it).

  • platform/efl-wk2/TestExpectations:
  • platform/gtk-wk2/TestExpectations:
  • platform/mac-wk2/Skipped:
  • platform/qt-5.0-wk2/Skipped:
4:57 PM Changeset in webkit [129429] by pilgrim@chromium.org
  • 5 edits in trunk/Source

[Chromium][Mac] Remove loadFont from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=97360

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/graphics/chromium/CrossProcessFontLoading.mm:

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

4:53 PM Changeset in webkit [129428] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Added a missing "if VALUE_PROFILER" around an access to ArrayProfile record.
​https://bugs.webkit.org/show_bug.cgi?id=97496.

Reviewed by Filip Pizlo.

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
4:43 PM Changeset in webkit [129427] by tony@chromium.org
  • 5 edits in trunk/Source/WebCore

Replace 2 uses of updateLogicalHeight with computeLogicalHeight
​https://bugs.webkit.org/show_bug.cgi?id=97486

Reviewed by Ojan Vafai.

More work for bug 96804. This is just a refactoring.

No new tests, behavior should be the same as before.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeLogicalHeight):

  • rendering/RenderFlowThread.h:
  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::computeLogicalHeight):
(WebCore):

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):

4:12 PM Changeset in webkit [129426] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Inlined activation tear-off in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=97487

Reviewed by Filip Pizlo.

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h: Activation tear-off is always inlined now, so I

removed its out-of-line implementation.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Inlined the variable copy and update
of JSVariableObject::m_registers. This usually turns into < 10 instructions,
which is close to pure win as compared to the operation function call.

  • runtime/JSActivation.h:

(JSActivation):
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::tearOff):
(JSC::JSActivation::isTornOff):
(JSC):
(JSC::JSActivation::storageOffset):
(JSC::JSActivation::storage): Tiny bit of refactoring so the JIT can
share the pointer math helper functions we use internally.

3:23 PM Changeset in webkit [129425] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark http/tests/security/inactive-document-with-empty-security-origin.html while Geoff Garen
investigates in ​https://bugs.webkit.org/show_bug.cgi?id=95530 in order to get the bots green.

  • platform/win/Skipped:
3:18 PM Changeset in webkit [129424] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

[V8] ArrayBuffer code should not pass a negative length to SetIndexedPropertiesToExternalArrayData()
​https://bugs.webkit.org/show_bug.cgi?id=96703

Reviewed by Adam Barth.

Check length arguments that may be passed to SetIndexedPropertiesToExternalArrayData.

No tests because it is not guaranteed that buffers this large can actually be allocated.

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):

3:14 PM Changeset in webkit [129423] by Antti Koivisto
  • 30 edits
    1 copy
    1 add in trunk/Source

Split stylesheet related code out from Document
​https://bugs.webkit.org/show_bug.cgi?id=97353

Reviewed by Andreas Kling.

Document is big and unwieldy. The code related to tracking active stylesheets can be factored out.

The patch moves stylesheet upkeep, collection and invalidation code from Document to a separate
DocumentStyleSheetCollection class. There are no functional changes.

The usesLinkRules stylesheet feature bit and the related code is removed as no one was using it.

  • WebCore.xcodeproj/project.pbxproj:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::Features::Features):
(WebCore::StyleResolver::Features::add):
(WebCore::StyleResolver::Features::clear):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(WebCore::StyleResolver::usesBeforeAfterRules):
(Features):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::recalcStyle):
(WebCore):
(WebCore::Document::createStyleResolver):
(WebCore::Document::seamlessParentUpdatedStylesheets):
(WebCore::Document::didRemoveAllPendingStylesheet):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::styleSheets):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::reportMemoryUsage):
(WebCore::Document::haveStylesheetsLoaded):

  • dom/Document.h:

(WebCore):
(Document):
(WebCore::Document::styleSheetCollection):
(WebCore::Document::hasNodesWithPlaceholderStyle):
(WebCore::Document::setNeedsNotifyRemoveAllPendingStylesheet):
(WebCore::Document::inStyleRecalc):

  • dom/DocumentStyleSheetCollection.cpp: Added.

(WebCore):
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::pageUserSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
(WebCore::DocumentStyleSheetCollection::pageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::clearPageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::updatePageGroupUserSheets):
(WebCore::DocumentStyleSheetCollection::addUserSheet):
(WebCore::DocumentStyleSheetCollection::removePendingSheet):
(WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::removeStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::testAddedStyleSheetRequiresStyleRecalc):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::styleSheetsUseRemUnits):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • dom/DocumentStyleSheetCollection.h: Added.

(WebCore):
(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::authorStyleSheets):
(WebCore::DocumentStyleSheetCollection::documentUserSheets):
(WebCore::DocumentStyleSheetCollection::needsUpdateActiveStylesheetsOnStyleRecalc):
(WebCore::DocumentStyleSheetCollection::preferredStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::selectedStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::setPreferredStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::setSelectedStylesheetSetName):
(WebCore::DocumentStyleSheetCollection::addPendingSheet):
(WebCore::DocumentStyleSheetCollection::hasPendingSheets):
(WebCore::DocumentStyleSheetCollection::usesSiblingRules):
(WebCore::DocumentStyleSheetCollection::setUsesSiblingRulesOverride):
(WebCore::DocumentStyleSheetCollection::usesFirstLineRules):
(WebCore::DocumentStyleSheetCollection::usesFirstLetterRules):
(WebCore::DocumentStyleSheetCollection::setUsesFirstLetterRules):
(WebCore::DocumentStyleSheetCollection::usesBeforeAfterRules):
(WebCore::DocumentStyleSheetCollection::setUsesBeforeAfterRulesOverride):
(WebCore::DocumentStyleSheetCollection::usesRemUnits):
(WebCore::DocumentStyleSheetCollection::setUsesRemUnit):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::~ProcessingInstruction):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::insertedIntoDocument):
(WebCore::StyleElement::removedFromDocument):
(WebCore::StyleElement::clearDocumentData):
(WebCore::StyleElement::createSheet):
(WebCore::StyleElement::sheetLoaded):
(WebCore::StyleElement::startLoadingDynamicSheet):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):

  • html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::insertedInto):

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):

  • mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::insertedInto):

  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

  • page/PageGroup.cpp:

(WebCore::PageGroup::resetUserStyleCacheInAllFrames):

  • rendering/RenderBR.cpp:

(WebCore::RenderBR::lineHeight):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::lineHeight):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::uncachedFirstLineStyle):
(WebCore::RenderObject::firstLineStyleSlowCase):

  • rendering/RenderObject.h:

(WebCore::RenderObject::firstLineStyle):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::updateBeforeAndAfterContent):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

3:08 PM Changeset in webkit [129422] by kareng@chromium.org
  • 4 edits
    2 copies in branches/chromium/1271

Merge 128999 - Do touch adjustment on GestureTapDown
​https://bugs.webkit.org/show_bug.cgi?id=96677

Patch by Rick Byers <​rbyers@chromium.org> on 2012-09-19
Reviewed by Antonio Gomes.

Source/WebCore:

Do touch adjustment on GestureTapDown exactly as for GestureTap today.

Test: touchadjustment/touch-links-active.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::adjustGesturePosition):

Tools:

Allow radius to be set for GestureTapDown events.

  • DumpRenderTree/chromium/TestRunner/EventSender.cpp:

(EventSender::gestureEvent):

LayoutTests:

Make a few tweaks to the touchadjustment.js infrastructure to make it
simpler and easier to use. Add a test for touch-adjustment of
GestureTapDown events (based on touch-links-longpress).

  • touchadjustment/resources/touchadjustment.js:

(touchPoint.return.left.x.radiusX.top.y.radiusY.width.radiusX.2.height.radiusY.2.get x):
(touchPoint.return.get y):
(touchPoint):
(offsetTouchPoint):

  • touchadjustment/touch-links-active-expected.txt: Added.
  • touchadjustment/touch-links-active.html: Added.

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/10988006

3:06 PM Changeset in webkit [129421] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. http/tests/security/sandboxed-iframe-form-top.html fails on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=97485

This test actually "passes" but is producing wrong output in whichever test proceeds it, thus causing that test to fail.

  • platform/win/Skipped:
3:05 PM TestExpectations edited by dpranke@chromium.org
add comments about flaky tests (diff)
3:04 PM Changeset in webkit [129420] by Lucas Forschler
  • 5 edits in branches/safari-534.58-branch/Source

Versioning.

2:59 PM Changeset in webkit [129419] by commit-queue@webkit.org
  • 12 edits
    1 delete in trunk/Source

[BlackBerry] Reverting implementation for 407 error pages
​https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-09-24
Reviewed by Rob Buis.

Source/WebCore:

Revert "[BlackBerry] Reverting implementation for 407 error pages"
This reverts commit fda0a1b6ac40c06c03bb6293b4a7d7353c3ca238.

This revert also reverts commit 0cffe01961fb80204138505bcec29a83818efb73
due to dependency issues.

  • PlatformBlackBerry.cmake:
  • platform/blackberry/AuthenticationChallengeManager.cpp: Removed.
  • platform/blackberry/AuthenticationChallengeManager.h:
  • platform/blackberry/PageClientBlackBerry.h:
  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

Source/WebKit/blackberry:

Revert "[BlackBerry] Really fix bug 95488 that user can get the
authentication challenge dialog while the other tab has focus."
​https://bugs.webkit.org/show_bug.cgi?id=97348

This reverts commit 0cffe01961fb80204138505bcec29a83818efb73.

  • Api/BlackBerryGlobal.cpp:

(BlackBerry::WebKit::globalInitialize):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::setVisible):

  • Api/WebPage_p.h:

(WebPagePrivate):

2:55 PM Changeset in webkit [129418] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

[REGRESSION] Layout Test webaudio/biquad-getFrequencyResponse.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=97439

Reviewed by Kenneth Russell.

Fixes uninitialized member variable.

This should fix flaky failing test: webaudio/biquad-getFrequencyResponse.html

  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

2:52 PM Changeset in webkit [129417] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Narrow Chromium TestExpectations for some hidpi failures to be Linux-only.
crbug.com/150682

Unreviewed, expectations change.

Also remove a no-longer-failing Mac expectation for
compositing/overflow/overflow-scaled-descendant-overlapping.html

  • platform/chromium/TestExpectations:
2:40 PM Changeset in webkit [129416] by Lucas Forschler
  • 1 copy in tags/Safari-536.27.1

New Tag.

2:38 PM Changeset in webkit [129415] by dmazzoni@google.com
  • 3 edits in branches/chromium/1271

Merge 129036 - AX: A few control types are returning the wrong answer for isReadOnly
​https://bugs.webkit.org/show_bug.cgi?id=96735

Reviewed by Chris Fleizach.

Source/WebCore:

All input types should be read-only except ones that
are text fields. The previous logic was marking things like
checkboxes as not read-only.

Tests: platform/chromium/accessibility/readonly.html

platform/mac/accessibility/form-control-value-settable.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isReadOnly):

Tools:

Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isReadOnlyGetterCallback):

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:

(AccessibilityUIElement):

LayoutTests:

Adds a new test to make sure that readonly is exposed correctly on
all elements.

  • platform/chromium/accessibility/readonly-expected.txt: Added.
  • platform/chromium/accessibility/readonly.html: Added.
  • platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
  • platform/mac/accessibility/form-control-value-settable.html: Added.

TBR=​dmazzoni@google.com
Review URL: ​https://codereview.chromium.org/10984006

2:35 PM Changeset in webkit [129414] by tony@chromium.org
  • 7 edits in trunk

flex-grow should be 1 when omitted from flex shorthand
​https://bugs.webkit.org/show_bug.cgi?id=97480

Reviewed by Ojan Vafai.

Source/WebCore:

We were using 0, based on an outdated version of the spec.

Tests: css3/flexbox/flex-property-parsing.html

css3/flexbox/flex-algorithm.html: New test case.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

LayoutTests:

Update tests due to default CSS value changes.

  • css3/flexbox/flex-algorithm-expected.txt:
  • css3/flexbox/flex-algorithm.html: Add test case using -webkit-flex: auto.
  • css3/flexbox/flex-property-parsing-expected.txt:
  • css3/flexbox/flex-property-parsing.html:
2:32 PM Changeset in webkit [129413] by benjamin@webkit.org
  • 16 edits
    2 adds
    1 delete in trunk/Source

Add support for query encoding to WTFURL
​https://bugs.webkit.org/show_bug.cgi?id=97422

Reviewed by Adam Barth.

Source/WebCore:

Add the Charset conversion on WebCore side.

  • platform/KURLWTFURL.cpp:

(WebCore::KURL::KURL):
(CharsetConverter):
(WebCore::CharsetConverter::CharsetConverter):

  • platform/mac/KURLMac.mm:

(WebCore::KURL::KURL):

Source/WTF:

Expose character conversion through the new abstract class URLQueryCharsetConverter.
URLQueryCharsetConverter is implemented by WebCore to expose the TextEncoding classes.

Unfortunatelly that forces us to bring over URLBuffer in the public API. We may be able
to mitigate that later when moving WTFURL to more templates.

The change fixes 2 of the URL layout tests.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::ParsedURL):

  • wtf/url/api/ParsedURL.h:

(ParsedURL):
ParsedURL was using the same constructor for ParsedURLString, and URL without a base.
That was a mistake on my part, I did not intend that, fixed it now :)

  • wtf/url/api/URLBuffer.h: Renamed from Source/WTF/wtf/url/src/URLBuffer.h.

(URLBuffer):
(WTF::URLBuffer::URLBuffer):
(WTF::URLBuffer::~URLBuffer):
(WTF::URLBuffer::at):
(WTF::URLBuffer::set):
(WTF::URLBuffer::capacity):
(WTF::URLBuffer::length):
(WTF::URLBuffer::data):
(WTF::URLBuffer::setLength):
(WTF::URLBuffer::append):
(WTF::URLBuffer::grow):

  • wtf/url/api/URLQueryCharsetConverter.h: Added.

(URLQueryCharsetConverter):
(WTF::URLQueryCharsetConverter::URLQueryCharsetConverter):
(WTF::URLQueryCharsetConverter::~URLQueryCharsetConverter):

  • wtf/url/src/URLCanon.h:

(URLCanonicalizer):

  • wtf/url/src/URLCanonFilesystemurl.cpp:

(WTF::URLCanonicalizer::canonicalizeFileSystemURL):
(WTF::URLCanonicalizer::ReplaceFileSystemURL):

  • wtf/url/src/URLCanonFileurl.cpp:

(WTF::URLCanonicalizer::CanonicalizeFileURL):
(WTF::URLCanonicalizer::ReplaceFileURL):

  • wtf/url/src/URLCanonInternal.h:

(URLCanonicalizer):

  • wtf/url/src/URLCanonQuery.cpp:

(WTF::URLCanonicalizer::CanonicalizeQuery):
(WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):

  • wtf/url/src/URLCanonRelative.cpp:

(WTF::URLCanonicalizer::resolveRelativeURL):

  • wtf/url/src/URLCanonStdURL.cpp:

(WTF::URLCanonicalizer::CanonicalizeStandardURL):
(WTF::URLCanonicalizer::ReplaceStandardURL):

  • wtf/url/src/URLUtil.cpp:

(URLUtilities):
(WTF::URLUtilities::canonicalize):
(WTF::URLUtilities::resolveRelative):
(WTF::URLUtilities::ReplaceComponents):

  • wtf/url/src/URLUtil.h:

(URLUtilities):

2:30 PM Changeset in webkit [129412] by benjamin@webkit.org
  • 13 edits
    23 adds
    4 deletes in trunk/Source

Integrate most of GoogleURL in WTFURL
​https://bugs.webkit.org/show_bug.cgi?id=97405

Reviewed by Adam Barth.

Source/WebCore:

Loosen KURLWTFURL to be able to run most tests in Debug.

  • platform/KURLWTFURL.cpp:

(WebCore::KURL::KURL):
(WebCore::KURL::hasPort):
(WebCore::KURL::user):
(WebCore::KURL::pass):
(WebCore::KURL::hasPath):
(WebCore::KURL::path):
(WebCore::KURL::query):
(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::fileSystemPath):

Source/WTF:

This patch brings almost all of the implementatation of Google-URL in WTFURL
with only minor changes.

The changes from the original code are mostly:
-Code cleaning.
-Replace url_parse::Parsed by URLSegments.
-Replace url_parse::Component by URLComponent
-More code cleaning.
-Adopt URLBuffer and RawURLBuffer instead of the CanonOutputT and RawCanonOutputT.
-Use URLCharacterTypes instead of the litany of characters functions.
-Some more code cleaning.
-Fix the style to match WebKit as much as possible.
-Rename the files to match WebKit style.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::ParsedURL):
(WTF::ParsedURL::segment):

  • wtf/url/api/ParsedURL.h:

(WTF::ParsedURL::isValid):

  • wtf/url/src/RawURLBuffer.h:
  • wtf/url/src/URLCanon.h: Added.

(URLCanonicalizer):
(CharsetConverter):
(WTF::URLCanonicalizer::CharsetConverter::CharsetConverter):
(WTF::URLCanonicalizer::CharsetConverter::~CharsetConverter):
(CanonHostInfo):
(WTF::URLCanonicalizer::CanonHostInfo::CanonHostInfo):
(WTF::URLCanonicalizer::CanonHostInfo::IsIPAddress):
(WTF::URLCanonicalizer::CanonHostInfo::AddressLength):
(URLComponentSource):
(WTF::URLCanonicalizer::URLComponentSource::URLComponentSource):
(Replacements):
(WTF::URLCanonicalizer::Replacements::Replacements):
(WTF::URLCanonicalizer::Replacements::SetScheme):
(WTF::URLCanonicalizer::Replacements::IsSchemeOverridden):
(WTF::URLCanonicalizer::Replacements::SetUsername):
(WTF::URLCanonicalizer::Replacements::ClearUsername):
(WTF::URLCanonicalizer::Replacements::IsUsernameOverridden):
(WTF::URLCanonicalizer::Replacements::SetPassword):
(WTF::URLCanonicalizer::Replacements::ClearPassword):
(WTF::URLCanonicalizer::Replacements::IsPasswordOverridden):
(WTF::URLCanonicalizer::Replacements::SetHost):
(WTF::URLCanonicalizer::Replacements::ClearHost):
(WTF::URLCanonicalizer::Replacements::IsHostOverridden):
(WTF::URLCanonicalizer::Replacements::SetPort):
(WTF::URLCanonicalizer::Replacements::ClearPort):
(WTF::URLCanonicalizer::Replacements::IsPortOverridden):
(WTF::URLCanonicalizer::Replacements::SetPath):
(WTF::URLCanonicalizer::Replacements::ClearPath):
(WTF::URLCanonicalizer::Replacements::IsPathOverridden):
(WTF::URLCanonicalizer::Replacements::SetQuery):
(WTF::URLCanonicalizer::Replacements::ClearQuery):
(WTF::URLCanonicalizer::Replacements::IsQueryOverridden):
(WTF::URLCanonicalizer::Replacements::SetRef):
(WTF::URLCanonicalizer::Replacements::ClearRef):
(WTF::URLCanonicalizer::Replacements::IsRefOverridden):
(WTF::URLCanonicalizer::Replacements::sources):
(WTF::URLCanonicalizer::Replacements::components):
(WTF::URLCanonicalizer::Replacements::Placeholder):

  • wtf/url/src/URLCanonEtc.cpp: Added.

(WTF::URLCanonicalizer::removeURLWhitespace):
(URLCanonicalizer):
(WTF::URLCanonicalizer::canonicalSchemeChar):
(WTF::URLCanonicalizer::CanonicalizeScheme):
(WTF::URLCanonicalizer::CanonicalizeUserInfo):
(WTF::URLCanonicalizer::CanonicalizePort):
(WTF::URLCanonicalizer::CanonicalizeRef):

  • wtf/url/src/URLCanonFilesystemurl.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeFileSystemURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ReplaceFileSystemURL):

  • wtf/url/src/URLCanonFileurl.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeFileURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::FileCanonicalizePath):
(WTF::URLCanonicalizer::ReplaceFileURL):

  • wtf/url/src/URLCanonHost.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeHost):
(URLCanonicalizer):
(WTF::URLCanonicalizer::CanonicalizeHostVerbose):

  • wtf/url/src/URLCanonICU.cpp: Added.

(WTF::URLCanonicalizer::IDNToASCII):
(URLCanonicalizer):
(WTF::URLCanonicalizer::readUTFChar):

  • wtf/url/src/URLCanonIP.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeIPAddress):
(URLCanonicalizer):

  • wtf/url/src/URLCanonInternal.cpp: Added.

(URLCanonicalizer):
(WTF::URLCanonicalizer::AppendInvalidNarrowString):
(WTF::URLCanonicalizer::ConvertUTF16ToUTF8):
(WTF::URLCanonicalizer::ConvertUTF8ToUTF16):
(WTF::URLCanonicalizer::SetupOverrideComponents):
(WTF::URLCanonicalizer::SetupUTF16OverrideComponents):
(WTF::URLCanonicalizer::_itoa_s):
(WTF::URLCanonicalizer::_itow_s):

  • wtf/url/src/URLCanonInternal.h: Added.

(URLCanonicalizer):
(WTF::URLCanonicalizer::hexCharToValue):
(WTF::URLCanonicalizer::isDot):
(WTF::URLCanonicalizer::appendURLEscapedCharacter):
(WTF::URLCanonicalizer::doAppendUTF8):
(WTF::URLCanonicalizer::AppendCharToOutput):
(WTF::URLCanonicalizer::AppendUTF8Value):
(WTF::URLCanonicalizer::AppendUTF8EscapedValue):
(WTF::URLCanonicalizer::AppendUTF16Value):
(WTF::URLCanonicalizer::AppendUTF8EscapedChar):
(WTF::URLCanonicalizer::Is8BitChar):
(WTF::URLCanonicalizer::DecodeEscaped):
(WTF::URLCanonicalizer::_itoa_s):
(WTF::URLCanonicalizer::_itow_s):
(WTF::URLCanonicalizer::_strtoui64):

  • wtf/url/src/URLCanonMailto.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeMailtoURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ReplaceMailtoURL):

  • wtf/url/src/URLCanonPath.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizePath):
(URLCanonicalizer):
(WTF::URLCanonicalizer::CanonicalizePartialPath):

  • wtf/url/src/URLCanonPathurl.cpp: Added.

(WTF::URLCanonicalizer::canonicalizePathURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ReplacePathURL):

  • wtf/url/src/URLCanonQuery.cpp: Added.

(WTF::URLCanonicalizer::CanonicalizeQuery):
(URLCanonicalizer):
(WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):

  • wtf/url/src/URLCanonRelative.cpp: Added.

(WTF::URLCanonicalizer::isRelativeURL):
(URLCanonicalizer):
(WTF::URLCanonicalizer::resolveRelativeURL):

  • wtf/url/src/URLCanonStdURL.cpp: Added.

(WTF::URLCanonicalizer::DefaultPortForScheme):
(URLCanonicalizer):
(WTF::URLCanonicalizer::CanonicalizeStandardURL):
(WTF::URLCanonicalizer::ReplaceStandardURL):

  • wtf/url/src/URLCharacterTypes.cpp:
  • wtf/url/src/URLCharacterTypes.h:

(WTF::URLCharacterTypes::isComponentChar):
(WTF::URLCharacterTypes::isHexChar):
(WTF::URLCharacterTypes::isIPv4Char):
(WTF::URLCharacterTypes::isQueryChar):
(WTF::URLCharacterTypes::isCharacterOfType):
(URLCharacterTypes):

  • wtf/url/src/URLEscape.cpp: Removed.
  • wtf/url/src/URLFile.h: Added.

(URLParser):
(WTF::URLParser::isWindowsDriveSeparator):
(WTF::URLParser::isWindowsDriveLetter):
(WTF::URLParser::findNextSlash):
(WTF::URLParser::doesBeginWindowsDriveSpec):
(WTF::URLParser::doesBeginUNCPath):

  • wtf/url/src/URLParse.cpp: Added.

(WTF::URLParser::ExtractScheme):
(URLParser):
(WTF::URLParser::IsAuthorityTerminator):
(WTF::URLParser::ExtractFileName):
(WTF::URLParser::ExtractQueryKeyValue):
(WTF::URLParser::ParseAuthority):
(WTF::URLParser::ParsePort):
(WTF::URLParser::ParseStandardURL):
(WTF::URLParser::ParsePathURL):
(WTF::URLParser::ParseFileSystemURL):
(WTF::URLParser::ParseMailtoURL):
(WTF::URLParser::parsePathInternal):
(WTF::URLParser::ParseAfterScheme):

  • wtf/url/src/URLParse.h: Added.

(URLParser):

  • wtf/url/src/URLParseFile.cpp: Added.

(WTF):
(WTF::URLParser::ParseFileURL):
(URLParser):

  • wtf/url/src/URLParseInternal.h: Added.

(URLParser):
(WTF::URLParser::isURLSlash):
(WTF::URLParser::shouldTrimFromURL):
(WTF::URLParser::trimURL):
(WTF::URLParser::countConsecutiveSlashes):

  • wtf/url/src/URLParser.h: Removed.
  • wtf/url/src/URLQueryCanonicalizer.h: Removed.
  • wtf/url/src/URLSegments.cpp:
  • wtf/url/src/URLSegments.h:

(WTF::URLSegments::URLSegments):
(URLSegments):
(WTF::URLSegments::operator=):
(WTF::URLSegments::innerURLSegments):
(WTF::URLSegments::setInnerURLSegments):
(WTF::URLSegments::clearInnerURLSegments):

  • wtf/url/src/URLUtil.cpp: Added.

(URLUtilities):
(WTF::URLUtilities::IsStandard):
(WTF::URLUtilities::FindAndCompareScheme):
(WTF::URLUtilities::Canonicalize):
(WTF::URLUtilities::resolveRelative):
(WTF::URLUtilities::ReplaceComponents):
(WTF::URLUtilities::LowerCaseEqualsASCII):
(WTF::URLUtilities::DecodeURLEscapeSequences):
(WTF::URLUtilities::EncodeURIComponent):
(WTF::URLUtilities::CompareSchemeComponent):

  • wtf/url/src/URLUtil.h: Added.

(URLUtilities):

  • wtf/url/src/URLUtilInternal.h: Renamed from Source/WTF/wtf/url/src/URLEscape.h.

(URLUtilities):

2:18 PM Changeset in webkit [129411] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

[CSS Exclusions] ExclusionShape API should use logical coordinates for input/output
​https://bugs.webkit.org/show_bug.cgi?id=96156

Patch by Hans Muller <​hmuller@adobe.com> on 2012-09-24
Reviewed by Dirk Schulze.

Source/WebCore:

Correct how ExclusionShapes deal with logical coordinates and enable
shape-inside exclusion layout for vertical writing-modes.

BasicShape's are defined in physical cooordinates, incoming line and box
dimensions are logical coordinates, and the ExclusionShape internals assume
that lines are aligned with the Y axis. The createExclusionShape() method
is responsible for converting the BasicShape to the internal coordinate
system when the writing-mode is vertical. Similarly, the getInclude,ExcludedIntervals()
methods are responsible for converting their logical line parameters to Y
values in the internal coordinate system. The min,maxYForLogicalLine()
methods do the conversion, based on the WritingMode the ExclusionShape
was created with. The getInclude,ExcludedIntervals() methods return the
logical left and right edges of line segments. No transformation is needed for this.

The ExclusionShape's internal coordinate system is essentially the
"logical" one, except that top/bottom always map to Y, no matter what
the writing-mode is. This is just to simplify writing geometrical shape
algorithms, notably the complex ones for polygons. The bug report includes a
pair of diagrams that clarify how internal coordinates are related to logical
and physical coordinates.

Test: fast/exclusions/shape-inside/shape-inside-vertical-text.html

  • rendering/ExclusionRectangle.cpp:

(WebCore::ExclusionRectangle::getExcludedIntervals): rename more accurately reflects return value
(WebCore::ExclusionRectangle::getIncludedIntervals): rename for consistency with "excluded" version

  • rendering/ExclusionRectangle.h:
  • rendering/ExclusionShape.cpp:

(WebCore):
(WebCore::ExclusionShape::createExclusionShape):

  • rendering/ExclusionShape.h:

(LineSegment):
(WebCore::LineSegment::LineSegment): relocated from WrapShapeInfo.h
(WebCore):
(ExclusionShape):
(WebCore::ExclusionShape::minYForLogicalLine):
(WebCore::ExclusionShape::maxYForLogicalLine):
(WebCore::ExclusionShape::internalToLogicalBoundingBox):

  • rendering/WrapShapeInfo.cpp:

(WebCore::WrapShapeInfo::isWrapShapeInfoEnabledForRenderBlock):
(WebCore::WrapShapeInfo::computeShapeSize): pass writingMode to createExclusionShape()
(WebCore::WrapShapeInfo::computeSegmentsForLine): removed short-circuit for vertical writing-modes

  • rendering/WrapShapeInfo.h:

(WebCore):

LayoutTests:

Verify that shape-inside respects the writing-mode, notably the vertical writing-modes.

  • fast/exclusions/shape-inside/shape-inside-vertical-text-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-vertical-text.html: Added.
2:13 PM Changeset in webkit [129410] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

Rebaseline for r129389
​https://bugs.webkit.org/show_bug.cgi?id=97473

Unreviewed.

Patch by Alec Flett <​alecflett@chromium.org> on 2012-09-24

  • platform/chromium-mac-snowleopard/fast/text/emphasis-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.txt:
  • platform/chromium-mac/fast/text/emphasis-expected.png:
  • platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.png:
  • platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.txt:
2:11 PM Changeset in webkit [129409] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight
​https://bugs.webkit.org/show_bug.cgi?id=97475

Reviewed by Ojan Vafai.

Using RenderMeter::computeLogicalHeight is part of bug 96804.
Also fix some code to be vertical writing mode aware. This doesn't actually cause
a behavioral difference because we use percentage heights/widths which don't depend on
updateLogicalWidth or computeLogicalHeight. You can still see bugs if you try to set
the min-width on a <meter> node in a vertical writing mode.

No new tests, no behavioral changes.

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::updateLogicalWidth): Make vertical writing mode aware.
(WebCore::RenderMeter::computeLogicalHeight): Switch from updateLogicalHeight and make vertical writing mode aware.

  • rendering/RenderMeter.h:

(RenderMeter):

1:58 PM Changeset in webkit [129408] by Dimitri Glazkov
  • 5 edits
    2 deletes in trunk

Remove unbaked support for :scope pseudo-class.
​https://bugs.webkit.org/show_bug.cgi?id=97467

Reviewed by Antti Koivisto.

It turns out, the Selectors 4 require ":scope" to match contextual reference element set, which would be the root node in querySelector:
​http://dev.w3.org/csswg/selectors4/#the-scope-pseudo

Right now, we simply make ":scope" equivalent to ":root", which is not correct. Let's remove the partial implementation until we have
time/energy to fully implement it.

Source/WebCore:

No new tests, removing half-baked feature.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId): Removed all mentions of PseudoScope
(WebCore::nameToPseudoTypeMap): Ditto.
(WebCore::CSSSelector::extractPseudoType): Ditto.

  • css/CSSSelector.h: Ditto.
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Ditto.

LayoutTests:

  • fast/css/style-scoped/scope-pseudo-expected.txt: Removed.
  • fast/css/style-scoped/scope-pseudo.html: Removed.
1:47 PM Changeset in webkit [129407] by Csaba Osztrogonác
  • 4 edits in trunk

Unreviewed, rolling out r129343.
​http://trac.webkit.org/changeset/129343
​https://bugs.webkit.org/show_bug.cgi?id=97479

It broke the build (Requested by Ossy_NIGHT on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-24

.:

  • Source/api.pri:

Tools:

  • qmake/mkspecs/features/default_pre.prf:
1:34 PM Changeset in webkit [129406] by rniwa@webkit.org
  • 10 edits in trunk/Source

suspend/resumeWidgetHierarchyUpdates should be a RAII object
​https://bugs.webkit.org/show_bug.cgi?id=96706

Reviewed by Simon Fraser.

Source/WebCore:

Replaced suspendWidgetHierarchyUpdates and resumeWidgetHierarchyUpdates by WidgetHierarchyUpdatesSuspensionScope.

  • WebCore.exp.in: Export new symbols.
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::detach):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

  • rendering/RenderWidget.cpp:

(WebCore):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::widgetNewParentMap):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
(WebCore::moveWidgetToParentSoon):

  • rendering/RenderWidget.h:

(WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::~WidgetHierarchyUpdatesSuspensionScope):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::isSuspended):
(WebCore::WidgetHierarchyUpdatesSuspensionScope::scheduleWidgetToMove):
(WebCore):
(RenderWidget):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _invalidateGStatesForTree]):

1:23 PM Changeset in webkit [129405] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. accessibility/svg-bounds.html crashes on Windows due to use of AX role which hasn't been properly implemented on Windows.

  • platform/win/Skipped:
1:21 PM Changeset in webkit [129404] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Reverting implementation for 407 error pages
​https://bugs.webkit.org/show_bug.cgi?id=97455

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2012-09-24
Reviewed by Rob Buis.

Revert "[BlackBerry] Show custom error page when 407 is received"
This reverts commit e6d14529428fe47916fcb997528095b8acad2f2b.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):

1:09 PM Changeset in webkit [129403] by cevans@google.com
  • 1 edit in branches/chromium/1271/Source/WebCore/dom/Document.cpp

Merge 129270
BUG=147700
Review URL: ​https://codereview.chromium.org/10957065

1:07 PM Changeset in webkit [129402] by commit-queue@webkit.org
  • 24 edits
    8 deletes in trunk

Unreviewed, rolling out r129388.
​http://trac.webkit.org/changeset/129388
​https://bugs.webkit.org/show_bug.cgi?id=97477

Caused an assertion in a WebKit2 unit test (Requested by
abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-24

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:

(WebCore::CachedImage::stillNeedsLoad):
(CachedImage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

  • loader/cache/CachedResource.h:

(WebCore):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

  • page/Settings.cpp:

(WebCore::setLoadsImagesAutomaticallyInAllFrames):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::loadsImagesAutomaticallyTimerFired):
(WebCore::Settings::setImagesEnabled):

  • page/Settings.h:

(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

  • win/WebKit2.def:

LayoutTests:

  • fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Removed.
  • fast/loader/display-image-unset-allows-cached-image-load.html: Removed.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Removed.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Removed.
  • fast/loader/resources/image1.html: Removed.
  • fast/loader/resources/image2.html: Removed.
  • platform/chromium/permissionclient/image-permissions-expected.txt:
  • platform/chromium/permissionclient/image-permissions.html:
  • platform/chromium/permissionclient/resources/image.html:
  • platform/wk2/Skipped:
1:06 PM Changeset in webkit [129401] by cevans@google.com
  • 3 edits in branches/chromium/1271/Source/WebCore/rendering

Merge 129144
BUG=145530
Review URL: ​https://codereview.chromium.org/10970075

1:04 PM Changeset in webkit [129400] by arv@chromium.org
  • 8 edits
    10 adds in trunk

DOM4 remove method
​https://bugs.webkit.org/show_bug.cgi?id=73885

Reviewed by Ojan Vafai.

This adds the DOM 4 remove method.

​http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-childnode-remove

The remove method removes the node from its parent if it has a parent.

Source/WebCore:

Tests: fast/dom/Comment/remove.html

fast/dom/DocumentType/remove.html
fast/dom/Element/remove.html
fast/dom/Text/remove.html

  • dom/CharacterData.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Node.cpp:

(WebCore::Node::remove): The spec says to do nothing if the node has no parent.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody): Cleanup.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::removeDisplayTree): No need to check parenNode twice.

LayoutTests:

  • fast/dom/Comment/remove-expected.txt: Added.
  • fast/dom/Comment/remove.html: Added.
  • fast/dom/DocumentType/remove-expected.txt: Added.
  • fast/dom/DocumentType/remove.html: Added.
  • fast/dom/Element/remove-expected.txt: Added.
  • fast/dom/Element/remove.html: Added.
  • fast/dom/Text/remove-expected.txt: Added.
  • fast/dom/Text/remove.html: Added.
12:53 PM Changeset in webkit [129399] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[GTK] Add Select All method to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=97460

Patch by Simon Pena <Simon Pena> on 2012-09-24
Reviewed by Martin Robinson.

Following the same approach used when added Cut, Copy and Paste,
the Select All method is added to the WebKit2 GTK+ API.

This introduces a new macro in the WebKitEditingCommands,
updates the documentation, and includes a new unit test.

  • UIProcess/API/gtk/WebKitEditingCommands.h: Add a new macro for

the Select All command.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include the Select All

command in the documentation.

  • UIProcess/API/gtk/tests/TestWebViewEditor.cpp: Cover the new command

with a unit test.
(testWebViewEditorSelectAll):
(beforeAll):

12:12 PM Changeset in webkit [129398] by roger_fong@apple.com
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed. Removing Windows specific results for fast/text/international/float-as-only-child-of-isolate-crash that were added in ​https://bugs.webkit.org/show_bug.cgi?id=87998.
Test now passes properly.

  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Removed.
  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Removed.
11:56 AM Changeset in webkit [129397] by tommyw@google.com
  • 8 edits in trunk

MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback
​https://bugs.webkit.org/show_bug.cgi?id=97456

Reviewed by Adam Barth.

Renamed onnegotationneeded to onnegotiationneeded.

Source/WebCore:

Existing test updated.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::negotiationNeeded):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • dom/EventNames.h:

(WebCore):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
11:52 AM Changeset in webkit [129396] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
11:49 AM Changeset in webkit [129395] by dominik.rottsches@intel.com
  • 7 edits
    155 adds in trunk

[EFL][DRT] Enable Regions support
​https://bugs.webkit.org/show_bug.cgi?id=83897

Reviewed by Kenneth Rohde Christiansen.

.:

Default build setting for CSS regions set to on.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit/efl:

Activating CSS regions by default for EWK views.

  • ewk/ewk_view.cpp: Switch CSS regions on by default.

(_ewk_view_priv_new):

LayoutTests:

New baselines for CSS regions, some CSS regions test still in TestExpectations.

  • platform/efl-wk2/TestExpectations: fast/regions/css-regions-disabled.html still failing on wk2.
  • platform/efl/TestExpectations: Some remaining CSS regions cases still skipped.
  • platform/efl/fast/regions/absolute-pos-elem-in-named-flow-expected.txt: Added.
  • platform/efl/fast/regions/autoheight-regions-mark-expected.png: Added.
  • platform/efl/fast/regions/autoheight-regions-mark-expected.txt: Added.
  • platform/efl/fast/regions/autowidth-attachedinvalidregion-expected.txt: Added.
  • platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
  • platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
  • platform/efl/fast/regions/content-flowed-into-regions-no-scroll-expected.txt: Added.
  • platform/efl/fast/regions/content-webkit-from-flow-parsing-expected.txt: Added.
  • platform/efl/fast/regions/element-region-overset-state-expected.txt: Added.
  • platform/efl/fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt: Added.
  • platform/efl/fast/regions/element-region-overset-state-vertical-rl-expected.txt: Added.
  • platform/efl/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Added.
  • platform/efl/fast/regions/fixed-pos-elem-in-named-flow-expected.txt: Added.
  • platform/efl/fast/regions/fixed-pos-elem-in-named-flow2-expected.txt: Added.
  • platform/efl/fast/regions/flexbox-in-region-crash-expected.txt: Added.
  • platform/efl/fast/regions/flow-anonymous-children-expected.txt: Added.
  • platform/efl/fast/regions/flow-content-basic-expected.png: Added.
  • platform/efl/fast/regions/flow-content-basic-expected.txt: Added.
  • platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Added.
  • platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Added.
  • platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
  • platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
  • platform/efl/fast/regions/flow-region-into-itself-crash-expected.txt: Added.
  • platform/efl/fast/regions/flowed-content-bounding-client-rect-expected.txt: Added.
  • platform/efl/fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Added.
  • platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt: Added.
  • platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Added.
  • platform/efl/fast/regions/flowed-content-transform-bounding-client-rect-expected.txt: Added.
  • platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
  • platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
  • platform/efl/fast/regions/flows-dependency-same-flow-expected.png: Added.
  • platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-absolute-pos-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-content-nodes-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-display-none-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-empty-regions-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-fixed-pos-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-horiz-bt-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-inline-only-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-text-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-vert-lr-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-vert-rl-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Added.
  • platform/efl/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Added.
  • platform/efl/fast/regions/get-regions-by-content-expected.txt: Added.
  • platform/efl/fast/regions/get-regions-by-content-horiz-bt-expected.txt: Added.
  • platform/efl/fast/regions/get-regions-by-content-horiz-tb-expected.txt: Added.
  • platform/efl/fast/regions/get-regions-by-content-vert-lr-expected.txt: Added.
  • platform/efl/fast/regions/get-regions-by-content-vert-rl-expected.txt: Added.
  • platform/efl/fast/regions/get-regions-by-content2-expected.txt: Added.
  • platform/efl/fast/regions/hit-test-float-expected.txt: Added.
  • platform/efl/fast/regions/hit-test-region-expected.txt: Added.
  • platform/efl/fast/regions/imbricated-flow-threads-crash-expected.txt: Added.
  • platform/efl/fast/regions/move-anonymous-block-inside-named-flow-crash-expected.txt: Added.
  • platform/efl/fast/regions/moved-content-node-crash-expected.txt: Added.
  • platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/no-split-line-box-expected.txt: Added.
  • platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
  • platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
  • platform/efl/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
  • platform/efl/fast/regions/parse-incomplete-region-rule-expected.txt: Added.
  • platform/efl/fast/regions/parsing-region-style-rule-expected.txt: Added.
  • platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
  • platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
  • platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
  • platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
  • platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
  • platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/positioned-vrl-in-named-flow-expected.txt: Added.
  • platform/efl/fast/regions/positioned-vrl-in-parent-named-flow-expected.txt: Added.
  • platform/efl/fast/regions/positioned-with-vrl-parent-in-named-flow-expected.txt: Added.
  • platform/efl/fast/regions/region-attached-wrong-flow-crash-expected.txt: Added.
  • platform/efl/fast/regions/region-element-display-change-expected.txt: Added.
  • platform/efl/fast/regions/region-element-display-restriction-expected.txt: Added.
  • platform/efl/fast/regions/region-element-dynamic-attach-flow-expected.txt: Added.
  • platform/efl/fast/regions/region-element-dynamic-detach-flow-expected.txt: Added.
  • platform/efl/fast/regions/region-flow-reattach-crash-expected.txt: Added.
  • platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
  • platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
  • platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/efl/fast/regions/region-range-for-box-crash-expected.txt: Added.
  • platform/efl/fast/regions/region-style-block-background-color-expected.png: Added.
  • platform/efl/fast/regions/region-style-block-background-color-expected.txt: Added.
  • platform/efl/fast/regions/region-style-block-background-color2-expected.png: Added.
  • platform/efl/fast/regions/region-style-block-background-color2-expected.txt: Added.
  • platform/efl/fast/regions/remove-flow-thread-crash-expected.txt: Added.
  • platform/efl/fast/regions/removed-element-style-in-region-crash-expected.txt: Added.
  • platform/efl/fast/regions/select-in-region-crash-expected.txt: Added.
  • platform/efl/fast/regions/set-box-style-in-region-crash-expected.txt: Added.
  • platform/efl/fast/regions/svg-root-element-collected-expected.txt: Added.
  • platform/efl/fast/regions/symbol-in-named-flow-crash-expected.txt: Added.
  • platform/efl/fast/regions/text-region-breaks-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-after-resize-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-horizontal-bt-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Added.
  • platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-vertical-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-vertical-rl-expected.txt: Added.
  • platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
  • platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
  • platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
  • platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
  • platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-parsing-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-collection-crash-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-collection-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-add-to-flow-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-no-regions-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-target-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-event-to-null-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-existing-flow-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-flow-added-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-get-content-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-get-regions-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-invalid-name-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-modified-flow-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-name-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-non-existing-flow-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-overset-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-removed-flow-expected.txt: Added.
  • platform/efl/fast/regions/webkit-named-flow-same-object-expected.txt: Added.
  • platform/efl/fast/regions/webkit-region-overflow-parsing-expected.txt: Added.
  • platform/efl/fast/regions/webkit-region-rule-expected.txt: Added.
11:42 AM Changeset in webkit [129394] by peter@chromium.org
  • 3 edits in trunk/Source/WebCore

Android's mock scrollbars shows up as a difference in layout test results
​https://bugs.webkit.org/show_bug.cgi?id=96382

Reviewed by Adam Barth.

Remove the exceptions made for layout tests in Android's scrollbar theme.
This will make our actual scrollbars show up in layout test pixel results,
bringing the tests closer to what we actually ship.

An important difference with other platforms is that scrollbars do not
take any width on Android, they're rendered on top of the content. Therefore
each test that has a visible scrollbar does not just need a new pixel
result, but will also need a new text result. This will be handled as part
of a larger rebaselining process.

Will be exercised by every layout test that has a scrollbar.

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb):

  • platform/chromium/ScrollbarThemeChromiumAndroid.h:

(ScrollbarThemeChromiumAndroid):

11:39 AM Changeset in webkit [129393] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. [Win] Failing test http/tests/inspector/network/network-xhr-replay.html
​https://bugs.webkit.org/show_bug.cgi?id=96942

  • platform/win/Skipped: Skipping a test for the newly added feature.
11:34 AM Changeset in webkit [129392] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
​https://bugs.webkit.org/show_bug.cgi?id=96362

Patch by Sean Wang <​Xuewen.Wang@torchmobile.com.cn> on 2012-09-24
Reviewed by Rob Buis.

Fix a mistake of the commit 11fdc73c7c74bbd736ed4160248ff59636a01864
Trunk has been changed during reviewing that patch.

No new tests, this is to correct a build error.

  • platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::CredentialBackingStore::getProtectionSpace):

11:32 AM Changeset in webkit [129391] by zandobersek@gmail.com
  • 7 edits
    3 adds in trunk

[Gtk] Unskip the Shadow DOM layout tests
​https://bugs.webkit.org/show_bug.cgi?id=90776

Reviewed by Ryosuke Niwa.

Source/WebKit/gtk:

Add a method for enabling the Shadow DOM through RuntimeEnabledFeatures.
The method is called from DumpRenderTree when resetting state.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setShadowDOMEnabled):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Enable Shadow DOM through DumpRenderTreeSupport when resetting defaults in between tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests:

Unskip Shadow DOM layout tests, adding two required baselines and failure
expectations for tests that still fail.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/shadow/form-in-shadow-expected.txt: Added.
  • platform/gtk/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt: Added.
11:29 AM Changeset in webkit [129390] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening - re-enable IDB test that's now passing.
​https://bugs.webkit.org/show_bug.cgi?id=92776

  • platform/chromium/TestExpectations:
11:18 AM Changeset in webkit [129389] by mitz@apple.com
  • 12 edits in trunk

Source/WebCore: Reverted r129176, the fix for <​http://webkit.org/b/97269>, because it introduced a
discrepancy between line breaking and max width computation.

Rubber-stamped by Anders Carlsson.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

LayoutTests: Reveted r129176 and r129185.

Rubber-stamped by Anders Carlsson.

  • platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.txt:
  • platform/mac/fast/text/emphasis-expected.png:
  • platform/mac/fast/text/emphasis-expected.txt:
  • platform/mac/fast/text/sticky-typesetting-features-expected.png:
  • platform/mac/fast/text/sticky-typesetting-features-expected.txt:
  • platform/mac/fast/text/thai-combining-mark-positioning-expected.png:
  • platform/mac/fast/text/thai-combining-mark-positioning-expected.txt:
  • platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
  • platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:
11:13 AM Changeset in webkit [129388] by commit-queue@webkit.org
  • 24 edits
    8 adds in trunk

Reland "Add in-place reload behavior to ImagesEnabled setting" with optimizations
​https://bugs.webkit.org/show_bug.cgi?id=97055

Patch by Bo Liu <​boliu@chromium.org> on 2012-09-24
Reviewed by Adam Barth.

Relanding 128780, 128676, 128645. Was reverted in 128914 due to
performance regression in Chromium.

New changes in addition to previously reverted patches:

Refactored CachedResource::requestResource, loadResource, and
revalidateResource. Moved CachedResource::load method to end of
requestResource so there is one place where load is called for all
resources.

Added a enum parameter for requestResource and
determineRevalidationPolicy so that FrameLoaderClient::allowImage call
do not need to be called multiple times.

Removed CachedImage::load call in requestImage so it is not called
twice.

Removed unnecessary Frame.h includes in CachedResource and
CachedImage.

Removed dead load() method declaration in CachedImage.

Updated text expectation for two image-permissions tests to reflect
the removed calls to allowImage.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Tests: fast/loader/display-image-unset-allows-cached-image-load.html

fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

  • loader/cache/CachedResource.h:

(WebCore):
(WebCore::CachedResource::stillNeedsLoad):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore):
(WebCore::CachedResourceLoader::setImagesEnabled):
(WebCore::CachedResourceLoader::clientDefersImage):
(WebCore::CachedResourceLoader::shouldDeferImageLoad):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

  • page/Settings.cpp:

(WebCore::setImageLoadingSettings):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::imageLoadingSettingsTimerFired):
(WebCore::Settings::setImagesEnabled):

  • page/Settings.h:

(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setImagesEnabled):
(WebCore):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

  • win/WebKit2.def:

LayoutTests:

  • fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Added.
  • fast/loader/display-image-unset-allows-cached-image-load.html: Added.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
  • fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
  • fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
  • fast/loader/resources/image1.html: Added.
  • fast/loader/resources/image2.html: Added.
  • platform/chromium/permissionclient/image-permissions-expected.txt:
  • platform/chromium/permissionclient/image-permissions.html:
  • platform/chromium/permissionclient/resources/image.html:
  • platform/wk2/Skipped:
10:45 AM Changeset in webkit [129387] by commit-queue@webkit.org
  • 10 edits
    1 copy
    1 add
    2 deletes in trunk/Source

[GTK] Implement GraphicsLayer using Clutter
​https://bugs.webkit.org/show_bug.cgi?id=73767

Source/WebCore:

Patch by Joone Hur <​joone.hur@intel.com>, Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2012-09-24
Reviewed by Martin Robinson.

This patch is needed for enabling Accelerated Compositing(Clutter backend)
with the patches submitted in bug 92045 and 91940.

No new tests. This will be covered by pixel tests for Qt/GTK+ accelerated
compositing and 3D transforms.

  • GNUmakefile.list.am:
  • platform/clutter/GRefPtrClutter.cpp: Removed.
  • platform/clutter/GRefPtrClutter.h: Removed.
  • platform/graphics/clutter/PlatformClutterLayerClient.h: Added.

(WebCore):
(PlatformClutterLayerClient):
(WebCore::PlatformClutterLayerClient::~PlatformClutterLayerClient):

  • platform/graphics/clutter/TransformationMatrixClutter.cpp: Added to convert CoglMatrix to

TransformationMatrix.
(WebCore):
(WebCore::TransformationMatrix::operator CoglMatrix):

  • platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

Source/WebKit/gtk:

Patch by Joone Hur <​joone.hur@intel.com> on 2012-09-24
Reviewed by Martin Robinson.

This patch is needed for enabling Accelerated Compositing(Clutter backend)
with the patches submitted in bug 92045 and 91940.

  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp:

(WebKit::AcceleratedCompositingContext::scrollNonCompositedContents): Added to fix bulid break.
(WebKit):

Source/WebKit2:

Patch by Joone Hur <​joone.hur@intel.com>, Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2012-09-24
Reviewed by Martin Robinson.

Fixed link errors by adding Clutter library and header to WebKit2 build.

  • GNUmakefile.am:

Source/WTF:

Patch by Joone Hur <​joone.hur@intel.com> on 2012-09-24
Reviewed by Martin Robinson.

Add ClutterActor and GraphicsLayerActor to GTypedefs.h.

  • wtf/gobject/GTypedefs.h:
10:18 AM Changeset in webkit [129386] by eae@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed chromium linux/windows rebaseline for r129370.

  • platform/chromium-linux/media/video-zoom-controls-expected.txt: Removed.
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
10:17 AM Changeset in webkit [129385] by dgrogan@chromium.org
  • 11 edits
    5 adds in trunk

Unprefix IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=96548

Reviewed by Adam Barth.

Source/WebCore:

We are largely compatible with the FF implementation and the w3c test
suite submitted by MS. The w3c test suite doesn't yet check
for lack of prefix; this is mostly to signal to devs that we think our
implementation is stable.

This patch uses the new FeatureObserver to get data about prefixed
vs unprefixed usage.

Tests: storage/indexeddb/unprefix-workers.html

storage/indexeddb/unprefix.html

  • Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::indexedDB):

  • Modules/indexeddb/DOMWindowIndexedDatabase.h:

(DOMWindowIndexedDatabase):

  • Modules/indexeddb/DOMWindowIndexedDatabase.idl:
  • Modules/indexeddb/WorkerContextIndexedDatabase.cpp:

(WebCore::WorkerContextIndexedDatabase::indexedDB):

  • Modules/indexeddb/WorkerContextIndexedDatabase.h:

(WorkerContextIndexedDatabase):

  • Modules/indexeddb/WorkerContextIndexedDatabase.idl:
  • bindings/generic/RuntimeEnabledFeatures.h:

Making the auxiliary objects RuntimeEnabled didn't make much sense as
they are useless without the factory, so always enable them.

(WebCore::RuntimeEnabledFeatures::indexedDBEnabled):

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute):

  • page/FeatureObserver.h:

LayoutTests:

  • storage/indexeddb/resources/unprefix.js: Added.

(test):

  • storage/indexeddb/unprefix-expected.txt: Added.
  • storage/indexeddb/unprefix-workers-expected.txt: Added.
  • storage/indexeddb/unprefix-workers.html: Added.
  • storage/indexeddb/unprefix.html: Added.
10:10 AM Changeset in webkit [129384] by wjmaclean@chromium.org
  • 34 edits in trunk/LayoutTests

[chromium] Rebaseline gesture highlight test expectation images.
​https://bugs.webkit.org/show_bug.cgi?id=97248

Reviewed by Yuta Kitamura.

Updating image baselines for gesture highlight tests. There are subtle changes in the rendering of
text in the target links, impercetable to the eye but ImageDiff picks them up.

  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.png:
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.png:
9:59 AM Changeset in webkit [129383] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] First step towards 2D canvas instrumentation in injected script
​https://bugs.webkit.org/show_bug.cgi?id=96746

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Pavel Feldman.

First step towards the 2D canvas instrumentation from the WebGL injected script module side.
We trace and save all calls that affect the 2D canvas context state and it's resources (Gradient and Pattern)
so that we could replay the context and resources states later.
The 2D canvas context state consists of:

  • current transformation matrix
  • current default path
  • current clipping region (affected by the "clip" command)
  • current values of the context attributes (like strokeStyle, fillStyle, etc.)
  • a stack of saved drawing states (affected by the "save" and "restore" commands)
  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

9:36 AM Changeset in webkit [129382] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Skip a few tests unskipped in r129372 and r129375 that still fail
on the bots.

  • platform/efl/TestExpectations:
9:36 AM Changeset in webkit [129381] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [TextEditor] conditional breakpoint popup not showing up the first time
​https://bugs.webkit.org/show_bug.cgi?id=97442

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Pavel Feldman.

1) The conditional breakpoint popup may not show up the first time we click on the gutter.
This was the case because the popup decoration element would be deleted from the line while
it was being highlighted and appended afterwards. Now we do not remove decorations from the
DOM while highlighting.

2) Also the popup will close itself on any mouse click event, even if it's targeted to the
input box itself. This was due to pointer-events: none; CSS style for the parent element.
Now we just override this style for the input box.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._insertTextNodeBefore):

  • inspector/front-end/inspector.css:

(.source-frame-breakpoint-condition):

9:32 AM Changeset in webkit [129380] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] WebKitWebView:is-loading is not updated when the is loaded is started by link clicked navigation action
​https://bugs.webkit.org/show_bug.cgi?id=97458

Reviewed by Xan Lopez.

WebKitWebView:is-loading is set to TRUE when the load is started
by using the API. We want to make sure that both URI and
is-loading are updated before load-started is emitted, so we can
update both right before emitting load-started.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewEmitLoadChanged): Update both uri and is-loading
properties before emitting load-changed signal with
WEBKIT_LOAD_STARTED.
(webkit_web_view_load_uri): Don't call
webkitWebViewSetIsLoading().
(webkit_web_view_load_html): Ditto.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_load_plain_text): Ditto.
(webkit_web_view_load_request): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_go_back): Ditto.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.

9:25 AM Changeset in webkit [129379] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Move some inspector tests from Skipped to TestExpectations with a
proper explanation and related bug report.

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
9:19 AM Changeset in webkit [129378] by jsbell@chromium.org
  • 5 edits in trunk/LayoutTests

IndexedDB: Modernize some esoteric tests
​https://bugs.webkit.org/show_bug.cgi?id=97368

Reviewed by Tony Chang.

Change the logging - but not the flow or assertions - of some of our
more complex tests, to take advantage of our newer helper functions.

  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
  • storage/indexeddb/open-close-version-expected.txt:
  • storage/indexeddb/resources/factory-deletedatabase-interactions.js:
  • storage/indexeddb/resources/open-close-version.js:
9:15 AM Changeset in webkit [129377] by eae@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed chromium rebaseline for video-zoom-controls for r129370.

  • platform/chromium-linux/media/video-zoom-controls-expected.txt: Added.
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
9:02 AM Changeset in webkit [129376] by rakuco@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Move a test that is failing on both WK1 and WK2 to the common
TestExpectations file.

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
8:58 AM Changeset in webkit [129375] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations: Unskip passing inspector test.
8:58 AM WebKitGTK/WebKit2Roadmap edited by Martin Robinson
(diff)
8:47 AM Changeset in webkit [129374] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [Canvas] set CanvasAgent in InstrumentingAgents upon calling enable command
​https://bugs.webkit.org/show_bug.cgi?id=97331

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Yury Semikhatsky.

We should set CanvasAgent in InstrumentingAgents from enable() command and remove from disable(), instead of doing this in constructor and destructor.

  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::~InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::restore):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):

  • inspector/InspectorCanvasAgent.h:

(InspectorCanvasAgent):

  • inspector/InspectorCanvasInstrumentation.h:

(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

8:46 AM Changeset in webkit [129373] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Add setters to WebFilterOperation for IPC pickling
​https://bugs.webkit.org/show_bug.cgi?id=97147

Reviewed by James Robinson.

Source/Platform:

These methods allow us to restore a WebFilterOperation from a blob
of opaque data. The pickling code needs to be able to create an
empty object and then fill in the pieces, so these setters allow it
to do so.

Test: WebFilterOperationsTest.saveAndRestore

  • chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::dropShadowOffset):
(WebKit::WebFilterOperation::matrix):
(WebKit::WebFilterOperation::zoomRect):
(WebFilterOperation):
(WebKit::WebFilterOperation::createEmptyFilter):
(WebKit::WebFilterOperation::setType):
(WebKit::WebFilterOperation::setAmount):
(WebKit::WebFilterOperation::setDropShadowOffset):
(WebKit::WebFilterOperation::setDropShadowColor):
(WebKit::WebFilterOperation::setMatrix):
(WebKit::WebFilterOperation::setZoomRect):

  • chromium/src/WebFilterOperation.cpp:

Source/WebKit/chromium:

  • tests/FilterOperationsTest.cpp:

(WebKit):
(WebKit::TEST):

8:44 AM Changeset in webkit [129372] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/Skipped: Unskip a few inspector-related tests which

are currently passing.

8:38 AM Changeset in webkit [129371] by Patrick Gansterer
  • 4 edits in trunk/Source

Remove remaining WTF_DEPRECATED_STRING_OPERATORS from cpp files
​https://bugs.webkit.org/show_bug.cgi?id=97412

Reviewed by Adam Barth.

Source/WebCore:

  • css/StylePropertySet.cpp: Removed useless define.

Source/WebKit/chromium:

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::openTagToString): Replaced operator+= with StringBuilder::append().
(WebKit::WebPageSerializerImpl::endTagToString): Ditto.

8:35 AM Changeset in webkit [129370] by eae@chromium.org
  • 14 edits
    2 adds in trunk

snapToSize rounds the incorrectly for negative locations
​https://bugs.webkit.org/show_bug.cgi?id=97265

Reviewed by Eric Seidel.

Source/WebCore:

Change snapSizeToPixel to preserve sign for location which
affects rounding.

Test: fast/sub-pixel/snap-negative-location.html

  • platform/FractionalLayoutUnit.h:

(WebCore::snapSizeToPixel):

LayoutTests:

Add test for snapSizeToPixel handling of negative locations.
Skipped on platforms that do not enable subpixel layout.

  • fast/sub-pixel/snap-negative-location-expected.html: Added.
  • fast/sub-pixel/snap-negative-location.html: Added.
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
8:33 AM Changeset in webkit [129369] by peter@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

Allow robots to index bugs on Bugzilla
​https://bugs.webkit.org/show_bug.cgi?id=95688

Reviewed by Eric Seidel.

This allows robots to access show_bug.cgi, thus granting them access to
index contents and discussion on WebKit bugs. All other pages, except
for the site index itself, still have indexing disabled.

  • robots.txt:
8:09 AM Changeset in webkit [129368] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/inspector/InspectorOverlay.cpp

Merge 129350 - Web Inspector:EXC_BAD_ACCESS upon closing page with node highlighted
​https://bugs.webkit.org/show_bug.cgi?id=97446

Reviewed by Alexander Pavlov.

Added 0 check on frame view.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

TBR=​pfeldman@chromium.org
BUG=151559
Review URL: ​https://chromiumcodereview.appspot.com/10967070

8:05 AM Changeset in webkit [129367] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

MIPS: store8 functions added to MacroAssembler.

MIPS store8 functions
​https://bugs.webkit.org/show_bug.cgi?id=97243

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2012-09-24
Reviewed by Oliver Hunt.

Add MIPS store8 functions.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::lhu): New function.
(MIPSAssembler):
(JSC::MIPSAssembler::sb): New function.
(JSC::MIPSAssembler::sh): New function.

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::store8): New function.
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::store16): New function.

7:53 AM Changeset in webkit [129366] by zandobersek@gmail.com
  • 4 edits
    1 delete in trunk

REGRESSION (r129211-r129218): http/tests/loading/redirect-with-no-location-crash.html failing on GTK Linux 64-bit Release WK2 (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=97404

Reviewed by Philippe Normand.

Tools:

Print out the 'didReceiveTitle' information when dumping frame load callbacks.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webViewTitleChanged):

LayoutTests:

Remove WebKit2-specific failure expectation and GTK-specific baseline for the test in title.

  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: Removed.
7:40 AM Changeset in webkit [129365] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Use unsigned char for bitfield instead of unsigned.
​https://bugs.webkit.org/show_bug.cgi?id=97447

Patch by Jonathan Liu <​net147@gmail.com> on 2012-09-24
Reviewed by Andreas Kling.

Not all compilers will pad an unsigned bitfield to the smallest size.
Use unsigned char instead of unsigned to reduce padding for compilers
that pad to the underlying type.

No new tests. There is already a compile-time assertion.

  • css/CSSRule.cpp:

(SameSizeAsCSSRule):

  • css/CSSRule.h:

(CSSRule):

7:29 AM BuildingQtOnWindows edited by zeno@webkit.org
Add some information on how to create a sparse-checkout of the WebKit repo. (diff)
7:28 AM Changeset in webkit [129364] by commit-queue@webkit.org
  • 68 edits
    6 adds in trunk/LayoutTests

[EFL] Rebaseline several test cases in Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=97452

Unreviewed EFL rebaseline.

Rebaseline several test cases in the EFL Skipped file
and unskip them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

  • platform/efl/Skipped:
  • platform/efl/fast/table/prepend-in-anonymous-table-expected.png:
  • platform/efl/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/efl/fast/text/basic/011-expected.png:
  • platform/efl/fast/text/basic/011-expected.txt:
  • platform/efl/fast/text/basic/013-expected.png:
  • platform/efl/fast/text/basic/013-expected.txt:
  • platform/efl/fast/text/bidi-embedding-pop-and-push-same-expected.png:
  • platform/efl/fast/text/capitalize-boundaries-expected.png:
  • platform/efl/fast/text/capitalize-boundaries-expected.txt:
  • platform/efl/fast/text/cg-fallback-bolding-expected.png:
  • platform/efl/fast/text/drawBidiText-expected.png:
  • platform/efl/fast/text/emphasis-vertical-expected.png:
  • platform/efl/fast/text/emphasis-vertical-expected.txt:
  • platform/efl/fast/text/fallback-traits-fixup-expected.png:
  • platform/efl/fast/text/fallback-traits-fixup-expected.txt:
  • platform/efl/fast/text/firstline/001-expected.png:
  • platform/efl/fast/text/firstline/001-expected.txt:
  • platform/efl/fast/text/firstline/002-expected.png:
  • platform/efl/fast/text/firstline/003-expected.png:
  • platform/efl/fast/text/format-control-expected.png:
  • platform/efl/fast/text/format-control-expected.txt:
  • platform/efl/fast/text/hyphens-expected.png:
  • platform/efl/fast/text/hyphens-expected.txt:
  • platform/efl/fast/text/in-rendered-text-rtl-expected.png:
  • platform/efl/fast/text/international/001-expected.png:
  • platform/efl/fast/text/international/001-expected.txt:
  • platform/efl/fast/text/international/002-expected.png:
  • platform/efl/fast/text/international/002-expected.txt:
  • platform/efl/fast/text/international/003-expected.png:
  • platform/efl/fast/text/international/003-expected.txt:
  • platform/efl/fast/text/international/bidi-L2-run-reordering-expected.png:
  • platform/efl/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/efl/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/efl/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/efl/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/efl/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/efl/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/efl/fast/text/international/bidi-european-terminators-expected.png:
  • platform/efl/fast/text/international/bidi-explicit-embedding-expected.png:
  • platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/efl/fast/text/international/bidi-innertext-expected.png:
  • platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.png:
  • platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-listbox-expected.png:
  • platform/efl/fast/text/international/bidi-listbox-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
  • platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-override-expected.png:
  • platform/efl/fast/text/international/bidi-override-expected.txt: Added.
  • platform/efl/fast/text/international/rtl-caret-expected.png:
  • platform/efl/fast/text/international/rtl-white-space-pre-wrap-expected.png:
  • platform/efl/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • platform/efl/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/efl/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/efl/fast/text/international/wrap-CJK-001-expected.png:
  • platform/efl/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/efl/fast/text/midword-break-hang-expected.png:
  • platform/efl/fast/text/midword-break-hang-expected.txt:
  • platform/efl/fast/text/trailing-white-space-2-expected.png:
  • platform/efl/fast/text/trailing-white-space-expected.png:
  • platform/efl/fast/text/whitespace/024-expected.png:
  • platform/efl/fast/text/whitespace/024-expected.txt:
  • platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/efl/fast/writing-mode/border-vertical-lr-expected.png:
  • platform/efl/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/efl/fast/writing-mode/fallback-orientation-expected.png:
  • platform/efl/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/efl/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
  • platform/efl/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/efl/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/efl/svg/as-border-image/svg-as-border-image-expected.txt:
7:24 AM Changeset in webkit [129363] by kareng@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/platform/text/LocaleICU.cpp

Merge 129191 - [Platform] There are memory leak in LocaleICU
​https://bugs.webkit.org/show_bug.cgi?id=97289

Reviewed by Kent Tamura.

This patch adds udt_close() calls for medium time format and short
time format data used in LocaleICU class to avoid memory leak.

This memory leak is found by external tool Valgrind and reported in
Chromium bug repositry(​http://crbug.com/151006) with stack trace of
call path of leaked memory.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. External tool such as Valgrind will check this memory leak.

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::~LocaleICU): Added to call udt_close() for m_mediumTimeFormat
and m_shortTimeFormat which have UDateFormat objects.

TBR=​yosin@chromium.org
Review URL: ​https://codereview.chromium.org/10958068

7:17 AM Changeset in webkit [129362] by apavlov@chromium.org
  • 2 edits in branches/chromium/1271/Source/WebCore/inspector/front-end

Merge 129348 - Web Inspector: [REGRESSION] Cmd-Shift-C doesn't enable element inspection mode when inspector hidden
​https://bugs.webkit.org/show_bug.cgi?id=97249

Reviewed by Yury Semikhatsky.

Fix regression from r125871.

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.enterInspectElementMode):

  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector.documentKeyDown):

TBR=​apavlov@chromium.org
Review URL: ​https://codereview.chromium.org/10963058

7:10 AM Changeset in webkit [129361] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: don't allow exception in front-end when expanding function scope
​https://bugs.webkit.org/show_bug.cgi?id=97346

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-09-24
Reviewed by Yury Semikhatsky.

A missing guard condition is added.

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):

7:02 AM Changeset in webkit [129360] by kareng@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/Resources/pagepopups/calendarPicker.js

Merge 129094 - REGRESSION(r127727): Calendar picker focus ring should be hidden until key event
​https://bugs.webkit.org/show_bug.cgi?id=97165

Reviewed by Kent Tamura.

The regression was caused because NoFocusRing class was being removed
from then main element inside resetMain().

No new tests. Covered by calendar-picker-appearance.html.

  • Resources/pagepopups/calendarPicker.js:

(initialize):
(CalendarPicker):
(CalendarPicker.prototype._layout):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):
(CalendarPicker.prototype.maybeUpdateFocusStyle): Make this a method of CalendarPicker because we don't use it for other pickers.

TBR=​keishi@webkit.org
Review URL: ​https://codereview.chromium.org/10956071

7:01 AM Changeset in webkit [129359] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviwed gardening. Skip new failing test.
​https://bugs.webkit.org/show_bug.cgi?id=97451

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-09-24

  • platform/qt/Skipped: Skip inspector-protocol/css-getSupportedCSSProperties.html.
6:51 AM Changeset in webkit [129358] by kareng@chromium.org
  • 5 edits in branches/chromium/1271

Merge 128982 - MediaStream API: Rename the RTCIceServer uri parameter to url.
​https://bugs.webkit.org/show_bug.cgi?id=97086

Reviewed by Hajime Morita.

Source/WebCore:

Either the standard has changed or I can't read.
​http://dev.w3.org/2011/webrtc/editor/webrtc.html#dictionary-rtciceserver-members

Existing tests changed to cover this patch.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::parseConfiguration):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-expected.txt:
  • fast/mediastream/RTCPeerConnection.html:
  • fast/mediastream/constructors-expected.txt:
  • fast/mediastream/constructors.html:

TBR=​tommyw@google.com
Review URL: ​https://codereview.chromium.org/10969068

6:39 AM Changeset in webkit [129357] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Mark fast/forms/select/select-state-restore.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=97449

Unreviewed EFL gardening.

fast/forms/select/select-state-restore.html sometimes times out on
the WebKit2 EFL debug build bot. Add it to TestExpectations.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

  • platform/efl-wk2/TestExpectations:
6:34 AM Changeset in webkit [129356] by anilsson@rim.com
  • 13 edits
    2 adds in trunk/Source

[BlackBerry] Add cookie database API
​https://bugs.webkit.org/show_bug.cgi?id=97102

Reviewed by Antonio Gomes.

Source/WebCore:

Add a CookieManager method that takes a list of strings to parse
instead of just one string. Expose CookieParser::parseOneCookie.

Reviewed internally by Otto D. Cheung.

No change in behavior, no new tests.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::setCookies):
(WebCore):

  • platform/blackberry/CookieManager.h:
  • platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):
(WebCore):

  • platform/blackberry/CookieParser.h:

(CookieParser):

Source/WebKit:

Add cookie database file to build system.

Reviewed internally by Otto D. Cheung.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

The cookie database is exposed through WebCookieJar, which has only two
methods: cookies() and setCookies().

Also add a new WebString::fromUTF8 overload that takes a const char*
and a length, in order to avoid a strlen call when converting from
other string classes to WebString. This is useful for callers of the
new cookie API when converting cookies to WebString.

Reviewed internally by Otto D. Cheung.

PR 209282

  • Api/WebCookieJar.cpp: Added.

(WebKit):
(BlackBerry::WebKit::WebCookieJar::WebCookieJar):
(BlackBerry::WebKit::WebCookieJar::cookies):
(BlackBerry::WebKit::WebCookieJar::setCookies):

  • Api/WebCookieJar.h: Added.

(WebKit):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPage::cookieJar):
(WebKit):

  • Api/WebPage.h:

(WebKit):

  • Api/WebPage_p.h:

(WebKit):
(WebPagePrivate):

  • Api/WebString.cpp:

(BlackBerry::WebKit::WebString::fromUtf8):
(WebKit):

  • Api/WebString.h:
6:17 AM Changeset in webkit [129355] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Open resource dialog has too many false positive matches.
​https://bugs.webkit.org/show_bug.cgi?id=97332

Reviewed by Alexander Pavlov.

Source/WebCore:

Improved open resource dialog filtering to make the amount of false
positive search results less.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItem.get var):
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItem):

LayoutTests:

  • inspector/filtered-item-selection-dialog-filtering-expected.txt:
  • inspector/filtered-item-selection-dialog-filtering.html:
6:14 AM Changeset in webkit [129354] by commit-queue@webkit.org
  • 47 edits
    49 adds in trunk/LayoutTests

[EFL] Rebaseline several test cases in Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=97448

Unreviewed EFL rebaseline.

Rebaseline several test cases in the Skipped file and unskip
them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

  • platform/efl/Skipped:
  • platform/efl/svg/as-image/animated-svg-as-image-expected.png: Added.
  • platform/efl/svg/as-image/animated-svg-as-image-expected.txt:
  • platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt:
  • platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.txt:
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
  • platform/efl/svg/as-image/same-image-two-instances-expected.png: Added.
  • platform/efl/svg/as-image/same-image-two-instances-expected.txt:
  • platform/efl/svg/as-image/svg-image-change-content-size-expected.png: Added.
  • platform/efl/svg/as-image/svg-image-change-content-size-expected.txt:
  • platform/efl/svg/batik/masking/maskRegions-expected.png: Added.
  • platform/efl/svg/batik/masking/maskRegions-expected.txt:
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
  • platform/efl/svg/css/path-gradient-stroke-shadow-expected.png: Added.
  • platform/efl/svg/css/path-gradient-stroke-shadow-expected.txt:
  • platform/efl/svg/dom/css-transforms-expected.png: Added.
  • platform/efl/svg/dom/css-transforms-expected.txt: Added.
  • platform/efl/svg/hixie/error/012-expected.png: Added.
  • platform/efl/svg/hixie/error/012-expected.txt:
  • platform/efl/svg/hixie/error/013-expected.png: Added.
  • platform/efl/svg/hixie/error/013-expected.txt:
  • platform/efl/svg/hixie/mixed/003-expected.png: Added.
  • platform/efl/svg/hixie/mixed/003-expected.txt:
  • platform/efl/svg/hixie/mixed/004-expected.png: Added.
  • platform/efl/svg/hixie/mixed/004-expected.txt:
  • platform/efl/svg/hixie/mixed/005-expected.png: Added.
  • platform/efl/svg/hixie/mixed/005-expected.txt:
  • platform/efl/svg/hixie/mixed/006-expected.png: Added.
  • platform/efl/svg/hixie/mixed/006-expected.txt:
  • platform/efl/svg/hixie/mixed/007-expected.png: Added.
  • platform/efl/svg/hixie/mixed/007-expected.txt:
  • platform/efl/svg/hixie/mixed/008-expected.png: Added.
  • platform/efl/svg/hixie/mixed/008-expected.txt:
  • platform/efl/svg/hixie/mixed/009-expected.png: Added.
  • platform/efl/svg/hixie/mixed/009-expected.txt:
  • platform/efl/svg/hixie/mixed/010-expected.png: Added.
  • platform/efl/svg/hixie/mixed/010-expected.txt:
  • platform/efl/svg/hixie/mixed/011-expected.png: Added.
  • platform/efl/svg/hixie/mixed/011-expected.txt:
  • platform/efl/svg/hixie/perf/007-expected.png: Added.
  • platform/efl/svg/hixie/perf/007-expected.txt:
  • platform/efl/svg/hixie/processing-model/003-expected.png: Added.
  • platform/efl/svg/hixie/processing-model/003-expected.txt:
  • platform/efl/svg/hixie/processing-model/004-expected.png: Added.
  • platform/efl/svg/hixie/processing-model/004-expected.txt:
  • platform/efl/svg/hixie/rendering-model/003-expected.png: Added.
  • platform/efl/svg/hixie/rendering-model/003-expected.txt:
  • platform/efl/svg/hixie/rendering-model/004-expected.png: Added.
  • platform/efl/svg/hixie/rendering-model/004-expected.txt:
  • platform/efl/svg/hixie/text/003-expected.png: Added.
  • platform/efl/svg/hixie/text/003-expected.txt:
  • platform/efl/svg/in-html/by-reference-expected.png: Added.
  • platform/efl/svg/in-html/by-reference-expected.txt:
  • platform/efl/svg/in-html/circle-expected.png: Added.
  • platform/efl/svg/in-html/circle-expected.txt:
  • platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.txt:
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
  • platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
  • platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
  • platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.txt:
  • platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/efl/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/efl/svg/transforms/svg-css-transforms-expected.txt:
  • platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
  • platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • platform/efl/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/efl/svg/wicd/rightsizing-grid-expected.txt:
  • platform/efl/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/efl/svg/wicd/test-rightsizing-a-expected.txt:
  • platform/efl/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/efl/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/efl/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/efl/svg/wicd/test-scalable-background-image1-expected.txt:
  • platform/efl/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/efl/svg/wicd/test-scalable-background-image2-expected.txt:
6:01 AM Changeset in webkit [129353] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++ code
​https://bugs.webkit.org/show_bug.cgi?id=97203

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Yury Semikhatsky.

Implements wrapping a 2D canvas context through the injected canvas module script facility.

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • inspector/InjectedScriptCanvasModule.cpp:

(WebCore::InjectedScriptCanvasModule::wrapCanvas2DContext):
(WebCore):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::callWrapContextFunction):

  • inspector/InjectedScriptCanvasModule.h:

(InjectedScriptCanvasModule):

  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):

  • inspector/InspectorCanvasAgent.h:

(InspectorCanvasAgent):

  • inspector/InspectorCanvasInstrumentation.h:

(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

5:31 AM Changeset in webkit [129352] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Change the install path for libewk2UnitTestInjectedBundleSample.so.
​https://bugs.webkit.org/show_bug.cgi?id=97302

Patch by Byungwoo Lee <​bw80.lee@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

libewk2UnitTestInjectedBundleSample.so file is created under the
Source directory.
Change install directory for the library to under the build directory.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::injectedBundleSample):

5:20 AM Changeset in webkit [129351] by apavlov@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/inspector/front-end/inspector.css

Merge 129117 - Web Inspector: [Elements] Word wrap disablement in the DOM tree broken
​https://bugs.webkit.org/show_bug.cgi?id=97185

Reviewed by Pavel Feldman.

Restored the effective "white-space: nowrap" for the tree elements.

  • inspector/front-end/inspector.css:

(.nowrap):

TBR=​apavlov@chromium.org
Review URL: ​https://codereview.chromium.org/10975002

5:14 AM Changeset in webkit [129350] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector:EXC_BAD_ACCESS upon closing page with node highlighted
​https://bugs.webkit.org/show_bug.cgi?id=97446

Reviewed by Alexander Pavlov.

Added 0 check on frame view.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

5:09 AM Changeset in webkit [129349] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip proper shadow dom test case
​https://bugs.webkit.org/show_bug.cgi?id=97445

Unreviewed EFL gardening.

Skip again fast/dom/shadow/shadowdom-for-object-without-shadow.html
and unskip fast/dom/shadow/shadowdom-for-object-only-shadow.html
instead.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

  • platform/efl/TestExpectations:
4:55 AM Changeset in webkit [129348] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Cmd-Shift-C doesn't enable element inspection mode when inspector hidden
​https://bugs.webkit.org/show_bug.cgi?id=97249

Reviewed by Yury Semikhatsky.

Fix regression from r125871.

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.enterInspectElementMode):

  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector.documentKeyDown):

4:53 AM Changeset in webkit [129347] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Disable persistence of master switches in the "Overrides" settings tab
​https://bugs.webkit.org/show_bug.cgi?id=97440

Reviewed by Yury Semikhatsky.

Disables enforcement of device metrics, geolocation, and device orientation overrides on Web Inspector start.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::restore):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.UserAgentSettingsTab.prototype._onMetricsCheckboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._onGeolocationOverrideCheckboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._onDeviceOrientationOverrideCheckboxClicked):

  • inspector/front-end/UserAgentSupport.js:

(WebInspector.UserAgentSupport):
(WebInspector.UserAgentSupport.prototype.toggleDeviceMetricsOverride):
(WebInspector.UserAgentSupport.prototype.toggleGeolocationPositionOverride):
(WebInspector.UserAgentSupport.prototype.toggleDeviceOrientationOverride):

  • inspector/front-end/externs.js:
4:38 AM Changeset in webkit [129346] by commit-queue@webkit.org
  • 13 edits
    8 adds in trunk

Web Inspector: implement testing harness for pure protocol tests.
​https://bugs.webkit.org/show_bug.cgi?id=90675

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-09-24
Reviewed by Yury Semikhatsky.

.:

Added export symbols required for Gtk+ to support the Inspector Protocol
testing harness.

  • Source/autotools/symbols.filter:

Source/WebCore:

Implementing the testing harness as the APIs of Internals object not
only reduced platform specific patching of DRTs but also minimized the
the effort required to open up the new dummy inspector Frontend.

The openDummyInspectorFrontend method will return the handle to newly
created DOMWindow. This DOMWindow object can be utilized inside the test
case to communicate using postMessage WebAPI.

The newly created DOMWindow will host the protocol-test.html which
will seed the necessary JS libraries to communicate with the
InspectorBackend.

Test: inspector-protocol/css-getSupportedCSSProperties.html

  • WebCore.exp.in:
  • WebCore.gypi:
  • inspector/InspectorClient.h:

(InspectorClient):

  • testing/Internals.cpp:

(InspectorFrontendClientDummy):
(WebCore::InspectorFrontendClientDummy::~InspectorFrontendClientDummy):
(WebCore):
(WebCore::InspectorFrontendClientDummy::InspectorFrontendClientDummy):
(InspectorFrontendChannelDummy):
(WebCore::InspectorFrontendChannelDummy::~InspectorFrontendChannelDummy):
(WebCore::InspectorFrontendChannelDummy::InspectorFrontendChannelDummy):
(WebCore::InspectorFrontendChannelDummy::sendMessageToFrontend):
(WebCore::Internals::consoleMessageArgumentCounts):
(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Source/WebKit2:

Adding the export symbol definitions required on Apple Windows and WinCairo
ports to support Inspector Protocol testing harness.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Adding the resources required for the dummy frontend page to load minimal
frontend. These resources provide the mechanism to talk to the Inspector Backend.

Adding the inspector-protocol folder to host the relevant test cases
utilizing the inspector protocol test harness. Added an example test
case for getting all supported CSS properties using the inspector
protocol and searching for a particular property being supported.

  • http/tests/inspector-protocol: Added.
  • http/tests/inspector-protocol/resources: Added.
  • http/tests/inspector-protocol/resources/InspectorTest.js: Added.

(InspectorTest.sendCommand):
(WebInspector.dispatchMessageFromBackend):
(InspectorTest.log):
(InspectorTest.completeTest):

  • http/tests/inspector-protocol/resources/protocol-test.html: Added.
  • http/tests/inspector-protocol/resources/protocol-test.js: Added.

(log):
(closeTest):
(runTest):

  • inspector-protocol: Added.
  • inspector-protocol/css-getSupportedCSSProperties-expected.txt: Added.
  • inspector-protocol/css-getSupportedCSSProperties.html: Added.
4:19 AM Changeset in webkit [129345] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.10.0

Tagging the WebKitGTK+ 1.10.0 release

4:08 AM Changeset in webkit [129344] by keishi@webkit.org
  • 5 edits in trunk

REGRESSION(r127727): Calendar picker focus doesn't loop in calendar-picker.html
​https://bugs.webkit.org/show_bug.cgi?id=97183

Reviewed by Kent Tamura.

Source/WebCore:

Fixing bug calendar-picker.html. The page popup behaves fine because
this code is only necessary in calendar-picker.html where the focus can
move outside of the picker because we are just using an iframe.

No new tests. Added tests to calendar-picker-key-operations.html.

  • Resources/pagepopups/calendarPicker.js:

(YearMonthController.prototype.attachTo):
(CalendarPicker.prototype._handleBodyKeyDown):

LayoutTests:

  • fast/forms/date/calendar-picker-key-operations-expected.txt:
  • fast/forms/date/calendar-picker-key-operations.html:
4:07 AM Changeset in webkit [129343] by Simon Hausmann
  • 4 edits in trunk

[Qt] Fix build with latest Qt 5

Reviewed by Tor Arne Vestbø.

.:

Define MODULE_BASE_DIR before loading qt_module.prf, which now calls syncqt. MODULE_BASE_DIR is
passed as last parameter (source dir) to syncqt now, so set it to the directory that contains
sync.profile.

  • Source/api.pri:

Tools:

The variables for syncqt handling are now set in api.pri, but let's add a comment here that we can
remove them from default_pre.prf once we're past Qt 5 beta2.

  • qmake/mkspecs/features/default_pre.prf:
4:03 AM Changeset in webkit [129342] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-1.10

Unreviewed. Update NEWS and configure.ac for 1.10.0 release

3:19 AM Changeset in webkit [129341] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed follow-up to r129336 -- fixed closure compiler warnings.

  • inspector/front-end/HAREntry.js:
  • inspector/front-end/TimelineModel.js:
3:15 AM Changeset in webkit [129340] by yurys@chromium.org
  • 19 edits
    12 deletes in trunk/LayoutTests

Unreviewed. Update pixel results for 18 tests on Win.

  • platform/chromium-win-xp/fast/css/shadow-multiple-expected.png: Removed.
  • platform/chromium-win-xp/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/shadow-translucent-fill-expected.png: Removed.
  • platform/chromium-win-xp/fast/transforms/shadows-expected.png: Removed.
  • platform/chromium-win-xp/ietestcenter/css3/text/textshadow-002-expected.png: Removed.
  • platform/chromium-win-xp/ietestcenter/css3/text/textshadow-010-expected.png: Removed.
  • platform/chromium-win-xp/svg/css/text-gradient-shadow-expected.png: Removed.
  • platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Removed.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug56563-expected.png: Removed.
  • platform/chromium-win-xp/transitions/svg-text-shadow-transition-expected.png: Removed.
  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win/fast/css/shadow-multiple-expected.png:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-win/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win/fast/text/stroking-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/fast/writing-mode/english-lr-text-expected.png:
  • platform/chromium-win/ietestcenter/css3/text/textshadow-002-expected.png:
  • platform/chromium-win/ietestcenter/css3/text/textshadow-010-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-win/svg/css/shadow-changes-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
2:39 AM Changeset in webkit [129339] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [TextEditor] Line numbers out of sync after closing breakpoint condition editor
​https://bugs.webkit.org/show_bug.cgi?id=96510

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-09-24
Reviewed by Vsevolod Vlasov.

Sync line heights on adding/removing decorations.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorGutterChunk):
(WebInspector.TextEditorGutterChunk.prototype.addDecoration):
(WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
(WebInspector.TextEditorGutterChunk.prototype.set expanded):
(WebInspector.TextEditorGutterChunk.prototype.get height):
(WebInspector.TextEditorGutterChunk.prototype._createRow):
(WebInspector.TextEditorMainChunk.prototype.addDecoration):
(WebInspector.TextEditorMainChunk.prototype.removeDecoration):
(WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):

2:38 AM Changeset in webkit [129338] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Invalid featuring of INPUT_TYPE_COLOR in test_ewk2_view.
​https://bugs.webkit.org/show_bug.cgi?id=97430

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2012-09-24
Reviewed by Kenneth Rohde Christiansen.

The tests of ewk_view_context_get and ewk_view_feed_touch_event are not related to
INPUT_TYPE_COLOR. These tests should be moved to outside of INPUT_TYPE_COLOR block.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

2:38 AM Changeset in webkit [129337] by yurys@chromium.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r122243.
​http://trac.webkit.org/changeset/129243
​https://bugs.webkit.org/show_bug.cgi?id=97441

WebFilterOperationsTest.saveAndRestore added in the change is failing.

Source/Platform:

  • chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::dropShadowOffset):
(WebKit::WebFilterOperation::matrix):
(WebKit::WebFilterOperation::zoomRect):
(WebFilterOperation):

Source/WebKit/chromium:

  • tests/FilterOperationsTest.cpp:
2:23 AM Changeset in webkit [129336] by caseq@chromium.org
  • 8 edits
    2 adds in trunk

Web Inspector: support saving HAR with resources content
​https://bugs.webkit.org/show_bug.cgi?id=97341

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • add WebInspector.HARWriter that writes HAR with content to a stream;
  • replace Save all as HAR with Save all with Content as HAR in network's panel context menu;
  • remove entries for copying/saving of individual request items to reduce clutter in context menu;
  • a drive-by fix of an exception when invoking context menu not on a network item;

Test: http/tests/inspector/network/har-content.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/FileUtils.js:
  • inspector/front-end/HAREntry.js:

(WebInspector.HAREntry.prototype._buildPostData):
(WebInspector.HARLog.prototype.build):
(WebInspector.HARLog.prototype._creator):
(WebInspector.HARWriter):
(WebInspector.HARWriter.prototype.write):
(WebInspector.HARWriter.prototype._onContentAvailable):
(WebInspector.HARWriter.prototype._beginWrite):
(WebInspector.HARWriter.prototype._writeNextChunk):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.get statusBarItems):
(WebInspector.NetworkLogView.prototype._createStatusBarItems):
(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._exportAll.openCallback):
(WebInspector.NetworkLogView.prototype._exportAll):

LayoutTests:

  • moved StringOutputStream to inspector-test.js for reuse;
  • added test for HARWriter and response content in HAR.
  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest):
(initialize_InspectorTest.):

  • http/tests/inspector/network/har-content-expected.txt: Added.
  • http/tests/inspector/network/har-content.html: Added.
  • inspector/timeline/timeline-test.js:

(initialize_Timeline):

2:15 AM Changeset in webkit [129335] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Updated test expectations for webaudio/biquad-getFrequencyResponse.html

  • platform/chromium/TestExpectations:
1:56 AM Changeset in webkit [129334] by commit-queue@webkit.org
  • 29 edits
    30 adds in trunk/LayoutTests

[EFL] Rebaseline several test cases in Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=97437

Unreviewed EFL rebaseline.

Rebaseline several test cases from EFL Skipped list
and unskip them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

  • platform/efl/Skipped:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/efl/svg/batik/text/textOnPath-expected.png: Added.
  • platform/efl/svg/batik/text/textOnPath-expected.txt:
  • platform/efl/svg/batik/text/textProperties2-expected.png: Added.
  • platform/efl/svg/batik/text/textProperties2-expected.txt:
  • platform/efl/svg/hixie/perf/004-expected.png: Added.
  • platform/efl/svg/hixie/perf/005-expected.png: Added.
  • platform/efl/svg/hixie/perf/006-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/efl/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
1:34 AM Changeset in webkit [129333] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip test cases that started passing after r129303
​https://bugs.webkit.org/show_bug.cgi?id=97433

Unreviewed EFL gardening.

Unskip several ref tests that are marked as unexpected
passes after r129303. r129303 fixed detection of ref
tests that are passing unexpectedly.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-24

  • platform/efl/TestExpectations:
1:34 AM Changeset in webkit [129332] by thakis@chromium.org
  • 1 edit
    2 deletes in trunk/Source/WebCore

[chromium] Remove BitLockerSkia. It's apparently not used.
​https://bugs.webkit.org/show_bug.cgi?id=97434

Reviewed by Kent Tamura.

  • platform/graphics/skia/BitLockerSkia.cpp: Removed.
  • platform/graphics/skia/BitLockerSkia.h: Removed.
1:10 AM MinimalFileStorageAlternate edited by mjs@apple.com
(diff)
12:53 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
12:49 AM MinimalFileStorageAlternate created by mjs@apple.com
12:47 AM Changeset in webkit [129331] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-1.10

Merge r126439 - [GTK] The tarball should be called webkitgtk-x.x.x.tar.xz
​https://bugs.webkit.org/show_bug.cgi?id=94572

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-08-23
Reviewed by Carlos Garcia Campos.

Change the name of the tarball to match the name of the library
and to disambiguate it from other WebKit ports.

  • configure.ac: Update the tarball name.
12:41 AM Changeset in webkit [129330] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Skeleton implementation of dialog.showModal()
​https://bugs.webkit.org/show_bug.cgi?id=97425

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-09-24
Reviewed by Kent Tamura.

Source/WebCore:

This adds a basic implementation of showModal(), so it later can be
used to test the top layer, once it is implemented. The main features
of showModal(), modality and the top layer, are not yet implemented.

Test: fast/dom/HTMLDialogElement/dialog-show-modal.html

  • html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::showModal): The same as show(), but throws an error in the cases specified in the spec.
(WebCore):

  • html/HTMLDialogElement.h:

(HTMLDialogElement):

  • html/HTMLDialogElement.idl:

LayoutTests:

Add a test that showModal() opens the dialog or throws an error in the cases specified in the spec.

  • fast/dom/HTMLDialogElement/dialog-show-modal-expected.txt: Added.
  • fast/dom/HTMLDialogElement/dialog-show-modal.html: Added.
12:24 AM Changeset in webkit [129329] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Regression after r129328
​https://bugs.webkit.org/show_bug.cgi?id=97429

Unreviewed, rolling out r129328.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderTheme::themeForPage):

Sep 23, 2012:

11:28 PM Changeset in webkit [129328] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Duplicated RenderThemeEfl creation for same page
​https://bugs.webkit.org/show_bug.cgi?id=88391

Reviewed by Gyuyoung Kim.

Other ports return one or two RenderTheme regardless of page.
But, WebKit/Efl can create different theme for each page and
themeForPage creates new RenderTheme whenever it is called with page.
So more than one RenderTheme can be created for a page.

This patches checks whether page already has RenderTheme not to create new
RenderTheme for same page.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderTheme::themeForPage):

11:27 PM Changeset in webkit [129327] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add setting to toggle developer extensions
​https://bugs.webkit.org/show_bug.cgi?id=96974

Patch by Seokju Kwon <​seokju.kwon@samsung.com> on 2012-09-23
Reviewed by Kenneth Rohde Christiansen.

This is required to allow the user to inspect pages. (Web inspector)

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

9:39 PM Changeset in webkit [129326] by keishi@webkit.org
  • 8 edits
    2 adds in trunk

Add suggestionPicker to CalendarPicker
​https://bugs.webkit.org/show_bug.cgi?id=97201

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html: Added tests for SuggestionPicker.

Source/WebCore:

This adds the suggestionPicker to CalendarPicker. It is not available yet as a datalist UI but it can be used inside ManualTests/forms/calendar-picker.html.

No new tests. Suggestion Picker can be tested in ManualTests/forms/calendar-picker.html.

  • Resources/pagepopups/calendarPicker.js:

(initialize):
(openSuggestionPicker):

  • Resources/pagepopups/pickerCommon.js:

(enclosingNodeOrSelfWithClass):

  • Resources/pagepopups/suggestionPicker.css: Added.

(.suggestion-list):
(.suggestion-list-entry):
(.suggestion-list-entry:focus):
(.suggestion-list-entry:focus .label):
(.suggestion-list-entry .content):
(.suggestion-list-entry .title):
(.suggestion-list-entry .label):
(.measuring-width .suggestion-list-entry .label):
(.suggestion-list .separator):

  • Resources/pagepopups/suggestionPicker.js: Added.

(SuggestionPicker):
(SuggestionPicker.validateConfig):
(SuggestionPicker.prototype.cleanup):
(SuggestionPicker.prototype._setColors): Creates css rules that sets highlight colors.
(SuggestionPicker.prototype._createSuggestionEntryElement): Creates an entry that when selected submits the value.
(SuggestionPicker.prototype._createActionEntryElement): Creates an entry that causes an action. (e.x. "Other...")
(SuggestionPicker.prototype._measureMaxContentWidth): Temporarily left align everything to measure the width.
(SuggestionPicker.prototype._fixWindowSize):
(SuggestionPicker.prototype._layout):
(SuggestionPicker.prototype.selectEntry):
(SuggestionPicker.prototype._handleEntryClick):
(SuggestionPicker.prototype._findFirstVisibleEntry):
(SuggestionPicker.prototype._findLastVisibleEntry):
(SuggestionPicker.prototype._handleBodyKeyDown):
(SuggestionPicker.prototype._handleEntryMouseOver):
(SuggestionPicker.prototype._handleMouseOut):

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument): Add js/css for SuggestionPicker to page picker. Add highlight color to args.

8:47 PM Changeset in webkit [129325] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

PutScopedVar should not be marked as clobbering the world
​https://bugs.webkit.org/show_bug.cgi?id=97416

Reviewed by Filip Pizlo.

No performance change.

PutScopedVar doesn't have arbitrary side-effects, so it shouldn't be marked
as such.

  • dfg/DFGNodeType.h:

(DFG):

8:35 PM Changeset in webkit [129324] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-09-23 Geoffrey Garen <​ggaren@apple.com>

I accidentally the whole 32-bit :(.

Unbreak the DFG in 32-bit with the 32-bit path I forgot in my last patch.

  • dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile):
8:33 PM Changeset in webkit [129323] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r128239): Mutable ElementAttributeData leak their Attribute vectors.
<​http://webkit.org/b/97423>

Reviewed by Anders Carlsson.

r128239 added a WTF::deleteOwnedPtr() override for ElementAttributeData*, but ElementAttributeData is
a ref-counted object. Fixed this by overriding deref() instead to call the appropriate subclass destructor.

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::deref):

8:28 PM Changeset in webkit [129322] by keishi@webkit.org
  • 3 edits
    2 copies in branches/chromium/1271

Merge 129106 - REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
​https://bugs.webkit.org/show_bug.cgi?id=97166

Reviewed by Kent Tamura.

Source/WebCore:

Fixing bug in r127727 so arrow keys work properly.

Test: fast/forms/date/calendar-picker-key-operations.html

  • Resources/pagepopups/calendarPicker.js:

(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):

LayoutTests:

  • fast/forms/date/calendar-picker-key-operations-expected.txt: Added.
  • fast/forms/date/calendar-picker-key-operations.html: Added.

TBR=​keishi@webkit.org
Review URL: ​https://codereview.chromium.org/10968055

7:29 PM Changeset in webkit [129321] by yosin@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/html/TimeInputType.cpp

Merge 129095 - [Forms] multiple fields time input UI should call notifyFormStateChanged() when value of field is changed
​https://bugs.webkit.org/show_bug.cgi?id=97169

Reviewed by Kent Tamura.

This patch makes multiple fields time input UI calls notifyFormStateChanged()
when field value is changed as other input types do.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. We can't test this change in WebKit test tools. Test script
will be implemented in Chromium side.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged):

TBR=​yosin@chromium.org
Review URL: ​https://codereview.chromium.org/10957058

6:16 PM Changeset in webkit [129320] by tkent@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebKit/chromium/src/WebFrameImpl.cpp

Merge 128972 - [Chromium] Fix crash in WebFrameImpl::loadHistoryItem
​https://bugs.webkit.org/show_bug.cgi?id=96352

Reviewed by Adam Barth.

We have some crash reports with the following stack:

  • HistoryItem::shouldDoSameDocumentNavigationTo.
  • WebFrameImpl::loadHistoryItem ...

We don't have reproducible steps, and not sure what's the root
cause. Anyway we should check nullness of currentItem because
HistoryController::m_currentItem can be 0.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadHistoryItem):
Check nullness of currentItem.

TBR=​tkent@chromium.org
Review URL: ​https://codereview.chromium.org/10959062

6:02 PM Changeset in webkit [129319] by commit-queue@webkit.org
  • 20 edits in trunk/Source

Fix build warnings : -Wunused-parameter, -Wparentheses, -Wuninitialized.
​https://bugs.webkit.org/show_bug.cgi?id=97306

Patch by Byungwoo Lee <​bw80.lee@gmail.com> on 2012-09-23
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Fix build warning about -Wunused-parameter on MachineStackMarker.cpp,
LLIntSlowPaths.cpp, DatePrototype.cpp, Options.cpp by using
UNUSED_PARAM() macro or remove parameter name.

  • heap/MachineStackMarker.cpp:

(JSC::pthreadSignalHandlerSuspendResume):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::entryOSR):

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

  • runtime/Options.cpp:

(JSC::computeNumberOfGCMarkers):

Source/WebCore:

Fix build warning about -Wunused-parameter on ImageBufferCairo.cpp,
ImageDecoder.h by using ASSERT_UNUSED() macro.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::encodeImage):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::rgbColorProfile):
(WebCore::ImageDecoder::inputDeviceColorProfile):

Source/WebKit/efl:

Fix build warning about -Wunused-parameter on FrameLoaderClientEfl.cpp
by using ASSERT_UNUSED() macro.
Fix build warning aboug -Wparentheses on ewk_frame.cpp by adding
additional brace for the assign statement.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):

  • ewk/ewk_frame.cpp:

(ewk_frame_resources_location_get):

Source/WebKit2:

Fix build warning about -Wunused-parameter on Connection.cpp,
WKEinaSharedString.cpp, ewk_view_loader_client.cpp, WebPage.cpp by
using ASSERT_UNUSED() macro or removing parameter name.
Fix build warning about -Wuninitialized on WebEventFactory.cpp by
continueing the loop at the default switch case not to use the
uninitialized variable.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForSyncReply):

  • Shared/efl/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebTouchEvent):

  • UIProcess/API/cpp/efl/WKEinaSharedString.cpp:

(WKEinaSharedString::WKEinaSharedString):

  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didSameDocumentNavigationForFrame):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::SandboxExtensionTracker::beginLoad):

Source/WTF:

Fix build warning about -Wunused-parameter on FastMalloc.cpp,
OSAllocatorPosix.cpp by using UNUSED_PARAM() macro.
Fix header including order of FastMalloc.cpp.

  • wtf/FastMalloc.cpp:

(WTF::fastMallocSize):

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

5:57 PM Changeset in webkit [129318] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Enable ElementAttributeData sharing for non-HTML elements.
<​http://webkit.org/b/97413>

Reviewed by Anders Carlsson.

Use the whole qualified tag name when creating the ElementAttributeData cache key
instead of just the localName(). This allows sharing and caching of attribute data
for non-HTML elements and makes the code a little cleaner.

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):

Enable the ElementAttributeData sharing path for non-HTML elements.

  • dom/ElementAttributeData.h:

Make immutableAttributeArray() public so Document can call it instead of getting
the raw data address from a const_cast'ed attributeItem(0).

  • dom/Document.cpp:

(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheEntry::ImmutableAttributeDataCacheEntry):
(ImmutableAttributeDataCacheEntry):
(WebCore::Document::cachedImmutableAttributeData):

Let the immutable attribute data cache use a QualifiedName/attributes key
instead of the AtomicString/attributes we were using before. We still grab the
existingHash() from the QualifiedName::localName() and use that for the actual
HashMap key.

4:37 PM Changeset in webkit [129317] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

Sorting a non-array creates propreties (spec-violation)
​https://bugs.webkit.org/show_bug.cgi?id=25477

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

We're just calling get() to get properties, which is converting missing properties to
undefined. Hole values should be retained, and moved to the end of the array.

  • runtime/ArrayPrototype.cpp:

(JSC::getOrHole):

  • Helper function, returns JSValue() instead of undefined for missing properties.

(JSC::arrayProtoFuncSort):

  • Implemented per 15.4.4.11, see comments above.

LayoutTests:

Added test cases.

  • fast/js/array-sort-sparse-expected.txt: Added.
  • fast/js/array-sort-sparse.html: Added.
  • fast/js/script-tests/array-sort-sparse.js: Added.

(testSort):

3:48 PM Changeset in webkit [129316] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

CSE for access to closure variables (get_/put_scoped_var)
​https://bugs.webkit.org/show_bug.cgi?id=97414

Reviewed by Oliver Hunt.

I separated loading a scope from loading its storage pointer, so we can
CSE the storage pointer load. Then, I copied the global var CSE and adjusted
it for closure vars.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute): Renamed GetScopeChain => GetScope to
reflect renames from a few weeks ago.

Added a case for the storage pointer load, similar to object storage pointer load.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): Added an independent node for
the storage pointer.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getScopeLoadElimination):
(JSC::DFG::CSEPhase::getScopeRegistersLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE): Copied globalVarLoad/StoreElimination
and adapted the same logic to closure vars.

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scope):
(Node):

  • dfg/DFGNodeType.h:

(DFG): GetScopedVar and GetGlobalVar are no longer MustGenerate. I'm not
sure why they ever were. But these are simple load operations so, if they're
unused, they're truly dead.

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Updated for renames and split-out
node for getting the storage pointer.

10:37 AM Changeset in webkit [129315] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Measure the usage of the "X-WebKit-CSP" header in the hopes of dropping the prefix completely.
​https://bugs.webkit.org/show_bug.cgi?id=97408

Patch by Mike West <​mkwst@chromium.org> on 2012-09-23
Reviewed by Adam Barth.

We plan on landing the unprefixed header in webkit.org/b/96765 once the
spec moves to CR. Though we plan to use it for experimentation in the
near future, we'll want to drop the prefixed header completely at some
point in the future. Starting to measure its usage now will give us a
good baseline when we start contemplating that decision.

No new functionality, so no new tests.

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::didReceiveHeader):

  • page/FeatureObserver.h:
Note: See TracTimeline for information about the timeline view.