Timeline



Oct 8, 2012:

11:35 PM Changeset in webkit [130722] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION(r128699): It made 2 fast/js/dfg tests assert
https://bugs.webkit.org/show_bug.cgi?id=96907

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-08
Reviewed by Csaba Osztrogonác.

Unskipping tests.

  • platform/qt/TestExpectations:
11:11 PM FeatureFlags edited by cmuppala@apple.com
Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature flag. (diff)
11:01 PM Changeset in webkit [130721] by yosin@chromium.org
  • 1 edit
    2 copies in branches/chromium/1271

Merge 130717 - HTMLSelectElement::typeAheadFind depends on implementation dependent behavior
https://bugs.webkit.org/show_bug.cgi?id=98710

Reviewed by Kent Tamura.

Source/WebCore:

This patch gets rid of C/C++ implementation dependent behavior from
HTMLSelectElement::typeAheadFind() which does modulo operation with
a negative operand.

HTMLSelectElement::typeAheadFind() contains expression with modulo
operator and dividend can be -1 when the "select" element without
"option" element but "optgroup" element.

Test: fast/forms/select/select-typeahead-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo
operation with both operands are non-negative.

LayoutTests:

This patch adds a test for checking HTMLSelectElement::typeAheadFind
doesn't crash.

  • fast/forms/select/select-typeahead-crash-expected.txt: Added.
  • fast/forms/select/select-typeahead-crash.html: Added.

TBR=yosin@chromium.org
Review URL: https://codereview.chromium.org/11088020

10:45 PM Changeset in webkit [130720] by commit-queue@webkit.org
  • 42 edits
    2 adds in trunk

Throttle DOM timers on hidden pages.
https://bugs.webkit.org/show_bug.cgi?id=98474

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-10-08
Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

When the visibility of a page changes to "hidden", all it's DOM timers are
updated to align their fire times on one second intervals. This limits the
number of CPU wakes due to a hidden pages to one per second.

Test: fast/dom/timer-throttling-hidden-page.html

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore):
(WebCore::Document::timerAlignmentInterval):
Read Page::timerAlignmentInterval and pass it along to DOMTimer.

  • dom/Document.h:

(Document):

  • dom/ScriptExecutionContext.cpp:

(WebCore):
(WebCore::ScriptExecutionContext::didChangeTimerAlignmentInterval):
Scan through self DOM Timers and tell them to recompute their fire
time based on the updated alignment interval.
(WebCore::ScriptExecutionContext::timerAlignmentInterval):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

  • page/DOMTimer.cpp:

(WebCore):
(WebCore::DOMTimer::alignedFireTime):
If the document's alignment interval is non zero, round up the fire
time to the next multiple of alignment interval.

  • page/DOMTimer.h:

(DOMTimer):
(WebCore::DOMTimer::defaultTimerAlignmentInterval):
(WebCore::DOMTimer::setDefaultTimerAlignmentInterval):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore):
(WebCore::Page::setTimerAlignmentInterval):
(WebCore::Page::timerAlignmentInterval):
(WebCore::Page::setVisibilityState):
Getter and Setter for alignment interval. Expose setVisibilityState
if either PAGE_VISIBILITY_API is enabled or if HIDDEN_PAGE_DOM_TIMER_REDUCTION
is enabled.

  • page/Page.h:

(Page):

  • page/Settings.cpp:

(WebCore):
(WebCore::Settings::setDefaultDOMTimerAlignmentInterval):
(WebCore::Settings::defaultDOMTimerAlignmentInterval):
(WebCore::Settings::setDOMTimerAlignmentInterval):
(WebCore::Settings::domTimerAlignmentInterval):

  • page/Settings.h:

(Settings):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::suspend):
Save the time remaining to the original unaligned fire time, so that
on resuming, the fire time will be correctly aligned using the latest
alignment interval.

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::sharedTimerFiredInternal):
Clear m_unalignedNextFireTime along with m_nextFireTime to keep
them always in sync.

  • platform/Timer.cpp:

(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::setNextFireTime):
Save the requested fire time in m_unalignedNextFireTime and
set m_nextFireTime to the aligned value. The unalinged value
is used to recompute fire time if alignment interval changes.
(WebCore):
(WebCore::TimerBase::didChangeAlignmentInterval):
Recompute next fire time from m_unalignedNextFireTime.
(WebCore::TimerBase::nextUnalignedFireInterval):
Interval from current time to the original unaligned fire time.

  • platform/Timer.h:

(TimerBase):
(WebCore::TimerBase::alignedFireTime):

Source/WebKit/mac:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define and provide a SPI for
DumpRenderTree to modify the visibility state of a page. The latter
is needed to test throttling of timers on hidden pages through DumpRenderTree.

  • Configurations/FeatureDefines.xcconfig:
  • WebView/WebView.mm:

(-[WebView _setVisibilityState:isInitialState:]):

  • WebView/WebViewPrivate.h:

Source/WebKit2:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define. Use existing code of
PAGE_VISIBILITY_API to detect changes to page visibility state.

  • Configurations/FeatureDefines.xcconfig:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Check visibility state on construction.
(WebKit::WebPageProxy::initializeWebPage):
Send initial visibility state message if HIDDEN_PAGE_DOM_TIMER_THROTTLING
is enabled or if PAGE_VISIBILITY_API is enabled.
(WebKit::WebPageProxy::viewStateDidChange):
When PAGE_VISIBILITY_API is not enabled, compare new visibility against
WebPageProxy::m_isVisible, to minimize number of messages sent.
Remove unnecessary second call to PageClient::isViewVisible for updating
visibility state.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPageVisibilityState):
WebKitTestRunner uses this method to implement testRunner.setPageVisibility(),
hence enable it for testing hidden page timer throttling as well.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit):
(WebKit::WebPage::setVisibilityState):
Ensure Page::setVisibilityState is called either if PAGE_VISIBILITY_API is
enabled or if HIDDEN_PAGE_DOM_TIMER_THROTTLING is enabled.

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:

Tools:

Implement testRunner.setPageVisibility on mac for testing throttling
of timers on hidden pages using DumpRenderTree.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:

Fix build error on mac-ews bot. Add JSC copy of ICU headers to search path.

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):

WebKitLibraries:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Add a test for DOM timer throttling on hidden pages.

  • fast/dom/timer-throttling-hidden-page-expected.txt: Added.
  • fast/dom/timer-throttling-hidden-page.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:

Skip the test since HIDDEN_PAGE_DOM_TIMER_THROTTLING is not enabled by default.

10:31 PM Changeset in webkit [130719] by yosin@chromium.org
  • 1 edit
    2 copies in branches/chromium/1229

Merge 130717 - HTMLSelectElement::typeAheadFind depends on implementation dependent behavior
https://bugs.webkit.org/show_bug.cgi?id=98710

Reviewed by Kent Tamura.

Source/WebCore:

This patch gets rid of C/C++ implementation dependent behavior from
HTMLSelectElement::typeAheadFind() which does modulo operation with
a negative operand.

HTMLSelectElement::typeAheadFind() contains expression with modulo
operator and dividend can be -1 when the "select" element without
"option" element but "optgroup" element.

Test: fast/forms/select/select-typeahead-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo
operation with both operands are non-negative.

LayoutTests:

This patch adds a test for checking HTMLSelectElement::typeAheadFind
doesn't crash.

  • fast/forms/select/select-typeahead-crash-expected.txt: Added.
  • fast/forms/select/select-typeahead-crash.html: Added.

TBR=yosin@chromium.org
Review URL: https://codereview.chromium.org/11091018

10:12 PM Changeset in webkit [130718] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

1.18MB below RenderTableSection::setCachedCollapsedBorderValue() on Membuster3.
<http://webkit.org/b/98670>
<rdar://problem/12454276>

Reviewed by Anders Carlsson.

Refactor CollapsedBorderValue to only store the bits and pieces from the BorderValue
that it actually needs. Packed the whole thing into 64 bits.

Reduces memory consumption by 547kB on Membuster3.

  • rendering/RenderTableCell.cpp:

Add compile-time size assertion for CollapsedBorderValue.

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::width):
(WebCore::CollapsedBorderValue::style):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::isTransparent):
(WebCore::CollapsedBorderValue::precedence):
(WebCore::CollapsedBorderValue::isSameIgnoringColor):
(CollapsedBorderValue):

Apply shrinkwrap to CollapsedBorderValue. Removed specialized copy constructor since
the class only has primitive members now.

9:47 PM Changeset in webkit [130717] by yosin@chromium.org
  • 3 edits
    2 adds in trunk

HTMLSelectElement::typeAheadFind depends on implementation dependent behavior
https://bugs.webkit.org/show_bug.cgi?id=98710

Reviewed by Kent Tamura.

Source/WebCore:

This patch gets rid of C/C++ implementation dependent behavior from
HTMLSelectElement::typeAheadFind() which does modulo operation with
a negative operand.

HTMLSelectElement::typeAheadFind() contains expression with modulo
operator and dividend can be -1 when the "select" element without
"option" element but "optgroup" element.

Test: fast/forms/select/select-typeahead-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo
operation with both operands are non-negative.

LayoutTests:

This patch adds a test for checking HTMLSelectElement::typeAheadFind
doesn't crash.

  • fast/forms/select/select-typeahead-crash-expected.txt: Added.
  • fast/forms/select/select-typeahead-crash.html: Added.
7:18 PM Changeset in webkit [130716] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Take account of overflowing values for width calculation of a year sub-field
https://bugs.webkit.org/show_bug.cgi?id=98506

Reviewed by Eric Seidel.

Source/WebCore:

When we decide the width of a year field of an input[type=date]
with the multiple fields UI, we need to take account of the
current value width because we allow to set overflowing values to
the input[type=date].

This change affects only platforms with INPUT_TYPE_DATE &&
INPUT_MULTIPLE_FIELDS_UI.

Test: fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::customStyleForRenderer):
Take account of the current value width.

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html: Added.
6:52 PM Changeset in webkit [130715] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium DEPS roll r160657:160764.

Unreviewed.

  • DEPS:
6:52 PM Changeset in webkit [130714] by tony@chromium.org
  • 5 edits
    2 adds in trunk

image not displayed in flexbox
https://bugs.webkit.org/show_bug.cgi?id=98611

Reviewed by Ojan Vafai.

Source/WebCore:

Flexbox will override the width of a child and when stretching, will override the height of the child.
When this happens, when an image loads, it checks to see if it's width/height has
changed, and if so, does a relayout. The overridden width/height was preventing this
relayout from happening.

To fix, we clear all the override sizes when we're done laying out the flex children.

Test: css3/flexbox/relayout-image-load.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock): Clear child override sizes.
(WebCore::RenderFlexibleBox::clearChildOverrideSizes):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): No longer need to clear the override size
here since it should have already been cleared.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

Load an image after flexbox layout has happened.

  • css3/flexbox/relayout-image-load-expected.txt: Added.
  • css3/flexbox/relayout-image-load.html: Added.
  • platform/chromium/TestExpectations: Remove css3/flexbox/flexitem-stretch-image.html

since it should no longer be flaky.

6:48 PM Changeset in webkit [130713] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Skip Layout/subtree-detaching.html temporarily as it's very noisy and
takes 112s to run on Chromium Mac. This is tracked by the bug 98708.

  • Skipped:
6:44 PM Changeset in webkit [130712] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r130643): editing/pasteboard/data-transfer-item is failing on chromium.
<http://webkit.org/b/98686>

Reviewed by Tony Chang.

Change ChromiumDataObject::createFromPasteboard() to use a ListHashSet instead of a HashSet so that
item order is preserved.

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::createFromPasteboard):

6:43 PM Changeset in webkit [130711] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Perf. test results page is broken when runs have different sets of tests
https://bugs.webkit.org/show_bug.cgi?id=98691

Reviewed by Daniel Bates.

Add "missing" columns for tests that are missing some runs.

Also fix regressions from the previous patch:

  • Make reference run switch work again
  • Load jquery plugins from the remote server when the jquery is loaded from the remote server.
  • resources/results-template.html:
6:39 PM Changeset in webkit [130710] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

Inline logicalHeightForRowSizing to shave another 2-3% off robohornet's resizecol.html
https://bugs.webkit.org/show_bug.cgi?id=98703

Reviewed by Emil A Eklund.

This is very small potatoes. There are much bigger wins for table layout yet, but
this was an easy win.

This function should probably be converted to use int's only, as table cells are pixel-sized
according to our subpixel-experts.

Also, I suspect there should be ways to early return with less-math in the common cases, but
I've saved such for a later patch.

Note that I changed from using paddingBefore/paddingAfter (which include the instrinsic padding)
to calling computedCSSPaddingBefore/computedCSSPaddingAfter directly as well.

This single function is about 11% of total time for robohornet's resizecol.

  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::logicalHeightForRowSizing):

6:36 PM Changeset in webkit [130709] by dpranke@chromium.org
  • 6 edits in trunk

results.html and garden-o-matic are ignoring IMAGE failures when expected to FAIL
https://bugs.webkit.org/show_bug.cgi?id=98706

Reviewed by Ojan Vafai.

FAIL is supposed to map onto Failure which is supposed to map
onto the old [ TEXT, IMAGE_PLUS_TEXT, AUDIO ] mapping.
results.html was including IMAGE in this and garden-o-matic was
including CRASH and TIMEOUT as well :(.

Tools:

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:

LayoutTests:

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
6:17 PM Changeset in webkit [130708] by alecflett@chromium.org
  • 22 edits in trunk/Source

IndexedDB: remove autogenerated objectStore/index id code
https://bugs.webkit.org/show_bug.cgi?id=98085

Reviewed by Tony Chang.

Source/WebCore:

Remove support for backend-generated objectstore and index
ids. The frontend objects now manage that state during
versionchange transactions. The IDBDatabaseBackendInterface and
IDBObjectStoreBackendInterface methods will go away when
https://bugs.webkit.org/show_bug.cgi?id=98682 lands.

No new tests as this is part of a refactoring, existing indexeddb
tests cover correctness.

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::setMaxIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

Remove support for unused createObjectStore/createIndex. These
methods will go away entirely when
https://bugs.webkit.org/show_bug.cgi?id=98682 is fixed.

  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::createObjectStore):

  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

5:59 PM Changeset in webkit [130707] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

[EFL] Build ControlTheme only when necessary
https://bugs.webkit.org/show_bug.cgi?id=98519

Reviewed by Eric Seidel.

  • EWebLauncher/ControlTheme/CMakeLists.txt:

Added custom command keyword not to build ControlTheme every time.
In addition, removed ALL keyword because targets, which use ControlTheme,
already have dependency.

5:55 PM Changeset in webkit [130706] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CAIRO] Adjust the source rect size when IMAGE_DECODER_DOWN_SAMPLING is enabled
https://bugs.webkit.org/show_bug.cgi?id=98630

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-08
Reviewed by Martin Robinson.

IMAGE_DECODER_DOWN_SAMPLING scales down the size of the big image.
CAIRO needs to adjust the source size to the scaled value.

No new tests.

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw):

5:08 PM Changeset in webkit [130705] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove unused features of BlobBuilder
https://bugs.webkit.org/show_bug.cgi?id=98331

Reviewed by Eric Seidel.

Now that we don't expose BlobBuilder as a web platform API, we can
strip down the class to handle only those cases that are needed by the
Blob constructor.

I've also renamed the class from WebKitBlobBuilder to BlobBuilder and
made it stack allocated rather than RefCounted. A future patch will
actually move the files around. (I didn't want to mix moving code
around with modifying the code.)

  • bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore):
(WebCore::BlobBuilder::BlobBuilder):
(WebCore::BlobBuilder::getBuffer):
(WebCore::BlobBuilder::append):
(WebCore::BlobBuilder::appendBytesData):
(WebCore::BlobBuilder::getBlob):

  • fileapi/WebKitBlobBuilder.h:

(WebCore):
(BlobBuilder):

  • page/FeatureObserver.h:
5:02 PM Changeset in webkit [130704] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

Try to fix the debug build after r130699

Move the assignment of the ResourceHandleInternal local to before
the include statement where it is used.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::createSoupMessageForHandleAndRequest):

4:33 PM Changeset in webkit [130703] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Do not swallow fatal messages in qt/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=98211

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-10-08
Reviewed by Eric Seidel.

Fix condition in message type filtering.

  • DumpRenderTree/qt/DumpRenderTreeMain.cpp:

(messageHandler):

4:31 PM Changeset in webkit [130702] by hclam@chromium.org
  • 164 edits
    73 adds in trunk/LayoutTests

Not reviewed. Rebaselines for Chromium.

Rebaseline after r130412 which affected image scaling pixel tests.

  • platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize15-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Added.
  • platform/chromium-linux-x86/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-linux-x86/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/clip-mask-negative-scale-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/pointer-events-image-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-linux/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-expected.png:
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
  • platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-linux/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-linux/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-mac/fast/borders/inline-mask-overlay-image-outset-expected.png:
  • platform/chromium-mac/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
  • platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win-xp/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/backgroundSize15-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-scaled-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/scaled-border-image-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-win-xp/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
  • platform/chromium-win-xp/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/clip-mask-negative-scale-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/image-small-width-height-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/pointer-events-image-expected.png: Added.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-win/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.png:
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
  • platform/chromium-win/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-win/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium/TestExpectations:
4:24 PM Changeset in webkit [130701] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

4:20 PM Changeset in webkit [130700] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

Post-r130226 Cleanup: Comment a complicated if statement and make it a helper.
https://bugs.webkit.org/show_bug.cgi?id=98463

Reviewed by Eric Seidel.

No new tests, refactor only.

  • rendering/RenderLayer.cpp:

(WebCore::frameElementAndViewPermitScroll):
(WebCore::RenderLayer::scrollRectToVisible):

4:12 PM Changeset in webkit [130699] by mrobinson@webkit.org
  • 5 edits in trunk/Source/WebCore

[Soup] Simplify the way that requests are started
https://bugs.webkit.org/show_bug.cgi?id=98532

Reviewed by Gustavo Noronha Silva.

Simplify the creation of the libsoup request and message when kicking off
requests, by elminating a bit of duplicate code.

No new tests. This should not change any behavior.

  • platform/network/ResourceHandle.h:

(ResourceHandle):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::ResourceHandleInternal::soupSession): Ensure the session
is initialized when passing it to the caller.
(WebCore::createSoupMessageForHandleAndRequest): Added this helper which
takes care of creating the SoupMessage for HTTP/HTTPS requests.
(WebCore::createSoupRequestAndMessageForHandle): Collapsed the HTTP and
non-HTTP request creation into this helper.
(WebCore::ResourceHandle::start): Call the new helper now and then sendPendingRequest.
(WebCore::ResourceHandle::sendPendingRequest): Instead of having special
helpers to create and send the request, duplicating the logic for sending it
across the file, add this method which can be used in both cases.
(WebCore::waitingToSendRequest): Reworked the hasBeenSent method to answer
the question of whether or not the request is ready to be sent, but is unsent.
(WebCore::ResourceHandle::platformSetDefersLoading): Use the new helper.

  • platform/network/soup/ResourceRequest.h:

(ResourceRequest): Added a new method for getting the URL string for soup.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::urlStringForSoup): Added.

3:59 PM Changeset in webkit [130698] by eric@webkit.org
  • 5 edits in trunk/Source/WebCore

Make no-column table-layout cases a little faster with inlining
https://bugs.webkit.org/show_bug.cgi?id=98566

Reviewed by Julien Chaffraix.

This change is almost not worth it at only a couple percent boost on
http://www.robohornet.org/tests/resizecol.html
However, I think the logicalWidthFromTableColumn split it kinda nice
so I've decided to post it anyway.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::slowColElement):

  • rendering/RenderTable.h:

(WebCore::RenderTable::colElement):
(RenderTable):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::logicalWidthFromTableColumn):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::styleOrColLogicalWidth):
(RenderTableCell):

3:58 PM BuildingOnWindows edited by roger_fong@apple.com
(diff)
3:58 PM Changeset in webkit [130697] by jchaffraix@webkit.org
  • 8 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

  • platform/chromium/TestExpectations:

Marked a test as crashing on Lion.

  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:

Rebaselined these tests after a change in Chromium compositor (Chromium r160671).

3:41 PM Changeset in webkit [130696] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Tools

Unreviewed. Moving myself from Committer to Reviewer list.
http://lists.webkit.org/pipermail/webkit-dev/2012-October/022460.html

  • Scripts/webkitpy/common/config/committers.py:
3:31 PM Changeset in webkit [130695] by benjamin@webkit.org
  • 8 edits in trunk/Source/WTF

Generalize moving URLComponent's begin position
https://bugs.webkit.org/show_bug.cgi?id=98626

Reviewed by Adam Barth.

The patch r130609 introduced moving URLComponents's position.
It turns out this concept is really useful in the parser so
this patch generalize the idea.

  • wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::removePort):

  • wtf/url/src/URLCanonEtc.cpp:
  • wtf/url/src/URLComponent.h:

(WTF::URLComponent::moveBy):
Rename URLComponent::move() to URLComponent::moveBy() for consistency
with some of WebCore types.

  • wtf/url/src/URLParse.cpp:
  • wtf/url/src/URLParseFile.cpp:
  • wtf/url/src/URLSegments.cpp:

(WTF::URLSegments::moveFromComponentBy):
Change the semantic to everything from a certain component. This is
useful to move everything, including the scheme.

  • wtf/url/src/URLSegments.h:

(URLSegments):

3:30 PM Changeset in webkit [130694] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Rename RenderObject::firstLineStyleSlowCase() to a more appropriate cachedFirstLineStyle()
https://bugs.webkit.org/show_bug.cgi?id=98631

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-10-08
Reviewed by Eric Seidel.

Renaming firstLineStyleSlowCase() to cachedFirstLineStyle().

The current name is confusing since the function actually gets the
the cached first-line styles.
It also makes the name more descriptive of its functionality
and in accordance with RenderObject::uncachedFirstLineStyle().

No new tests required for this change since no change in behavior is expected.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::cachedFirstLineStyle):

  • rendering/RenderObject.h:

(WebCore::RenderObject::firstLineStyle):
(RenderObject):
Renamed RenderObject::firstLineStyleSlowCase() to cachedFirstLineStyle()
and made the associated changes.

3:22 PM Changeset in webkit [130693] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Try to fix Windows build by exporting Frame::layerTreeAsText().

  • win/WebKit2.def:
3:15 PM Changeset in webkit [130692] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

Some non-scrollable elements are added to non-fast-scrollable region
https://bugs.webkit.org/show_bug.cgi?id=97927

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-10-08
Reviewed by James Robinson.

Source/WebCore:

Only RenderLayers that can actually be scrolled should be added to the
ScrollingCoordinator's non-fast scrollable region. Otherwise we may
needlessly fall back to main thread scrolling.

Test: ScrollingCoordinatorChromiumTest.clippedBodyTest

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):

Source/WebKit/chromium:

Test that a non-scrollable RenderLayer isn't added to the non-fast scrollable
region.

The test in this patch consists of a web page where both the html and
body elements clip horizontal overflow. This results in a hierarchy
where the body element gets a scrollable RenderLayer. However, that
layer isn't (interactively) scrollable because while the scroll geometry
is calculated based on the amount of overflow, the scroll bars are
hidden because of the "overflow-x: hidden" style.

Previously this layer would have made the entire page part of the
non-fast scrollable region. With this patch,
RenderLayer::allowScrolling() is used as a pre-requisite for expanding
the region, thus avoiding the problem.

  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::TEST_F):
(WebKit):

  • tests/data/clipped-body.html: Added.
3:07 PM Changeset in webkit [130691] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit/chromium

Mac Chromium: Ignore system numpad modifier
https://bugs.webkit.org/show_bug.cgi?id=97161

Patch by Sailesh Agrawal <sail@chromium.org> on 2012-10-08
Reviewed by Tony Chang.

On Mac, arrow key events have numpad modifier set. This is inconsistent with other platforms.

My fix is to only rely on keycode to decide when to set the numpad modifier.

This code is not exersided by layout tests so I added a new unit test for this.

  • WebKit.gypi:
  • WebKitUnitTests.gyp:
  • src/mac/WebInputEventFactory.mm:

(WebKit::isKeypadEvent): Removed check for numpad modifier.

  • tests/WebInputEventFactoryTestMac.mm: Added.

(TEST): Added new test for WebInputEventFactory::keyboardEvent().

3:06 PM Changeset in webkit [130690] by dpranke@chromium.org
  • 7 edits in trunk/Tools

nrwt: [chromium] run http tests in parallel on bigger machines
https://bugs.webkit.org/show_bug.cgi?id=98562

Reviewed by Eric Seidel.

The "locked tests" shard (which includes the http tests and the
perf tests) is the long pole on machines where we have 4 or more
workers, so we should start making sure that
we can run http tests in parallel, following the normal sharding
rules (all tests in the same directory are in the same shard by
default). We should still probably limit the number of workers
hitting the web server in parallel where we can; a heuristic of
no more than 25% of them seems okay for a start. This will
likely only affect developer workstations and a couple of bots
at first, so should be low risk and a good reward.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.default_max_locked_shards):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.default_max_locked_shards):

  • Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:

(ChromiumPortTestCase.test_default_max_locked_shards):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_default_max_locked_shards):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_max_locked_shards):

2:55 PM Changeset in webkit [130689] by Simon Fraser
  • 132 edits in trunk

Move layerTreeAsText to window.internals
https://bugs.webkit.org/show_bug.cgi?id=98690

Reviewed by James Robinson.

Add window.internals.layerTreeAsText(document), and change the tests to use it.
I'll remove testRunner.layerTreeAsText() in a later patch.

Source/WebCore:

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

  • compositing/animation/animation-compositing.html:
  • compositing/backing/no-backing-for-clip-overlap.html:
  • compositing/backing/no-backing-for-clip.html:
  • compositing/backing/no-backing-for-perspective.html:
  • compositing/bounds-in-flipped-writing-mode.html:
  • compositing/clip-child-by-non-stacking-ancestor.html:
  • compositing/columns/composited-in-paginated.html:
  • compositing/geometry/ancestor-overflow-change.html:
  • compositing/geometry/bounds-clipped-composited-child.html:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant.html:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html:
  • compositing/geometry/bounds-ignores-hidden-dynamic.html:
  • compositing/geometry/bounds-ignores-hidden.html:
  • compositing/geometry/clip.html:
  • compositing/geometry/composited-in-columns.html:
  • compositing/geometry/fixed-position-composited-switch.html:
  • compositing/geometry/flipped-writing-mode.html:
  • compositing/geometry/foreground-layer.html:
  • compositing/geometry/layer-due-to-layer-children-deep-switch.html:
  • compositing/geometry/layer-due-to-layer-children-switch.html:
  • compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
  • compositing/geometry/limit-layer-bounds-fixed-positioned.html:
  • compositing/geometry/limit-layer-bounds-opacity-transition.html:
  • compositing/geometry/limit-layer-bounds-overflow-root.html:
  • compositing/geometry/limit-layer-bounds-positioned-transition.html:
  • compositing/geometry/limit-layer-bounds-positioned.html:
  • compositing/geometry/limit-layer-bounds-transformed-overflow.html:
  • compositing/geometry/limit-layer-bounds-transformed.html:
  • compositing/geometry/preserve-3d-switching.html:
  • compositing/iframes/become-composited-nested-iframes.html:
  • compositing/iframes/become-overlapped-iframe.html:
  • compositing/iframes/composited-parent-iframe.html:
  • compositing/iframes/connect-compositing-iframe-delayed.html:
  • compositing/iframes/connect-compositing-iframe.html:
  • compositing/iframes/connect-compositing-iframe2.html:
  • compositing/iframes/connect-compositing-iframe3.html:
  • compositing/iframes/enter-compositing-iframe.html:
  • compositing/iframes/iframe-resize.html:
  • compositing/iframes/iframe-size-from-zero.html:
  • compositing/iframes/iframe-size-to-zero.html:
  • compositing/iframes/iframe-src-change.html:
  • compositing/iframes/invisible-nested-iframe-hide.html:
  • compositing/iframes/invisible-nested-iframe-show.html:
  • compositing/iframes/leave-compositing-iframe.html:
  • compositing/iframes/overlapped-iframe-iframe.html:
  • compositing/iframes/overlapped-iframe.html:
  • compositing/iframes/overlapped-nested-iframes.html:
  • compositing/iframes/page-cache-layer-tree.html:
  • compositing/iframes/resizer.html:
  • compositing/iframes/scrolling-iframe.html:
  • compositing/images/clip-on-directly-composited-image.html:
  • compositing/layer-creation/animation-overlap-with-children.html:
  • compositing/layer-creation/fixed-position-and-transform.html:
  • compositing/layer-creation/fixed-position-out-of-view.html:
  • compositing/layer-creation/fixed-position-under-transform.html:
  • compositing/layer-creation/no-compositing-for-preserve-3d.html:
  • compositing/layer-creation/overflow-scroll-overlap.html:
  • compositing/layer-creation/overlap-animation.html:
  • compositing/layer-creation/overlap-child-layer.html:
  • compositing/layer-creation/overlap-clipping.html:
  • compositing/layer-creation/overlap-transformed-and-clipped.html:
  • compositing/layer-creation/overlap-transformed-layer.html:
  • compositing/layer-creation/overlap-transforms.html:
  • compositing/layer-creation/rotate3d-overlap.html:
  • compositing/layer-creation/scroll-partial-update.html:
  • compositing/layer-creation/spanOverlapsCanvas.html:
  • compositing/layer-creation/stacking-context-overlap-nested.html:
  • compositing/layer-creation/stacking-context-overlap.html:
  • compositing/layer-creation/translatez-overlap.html:
  • compositing/overflow-trumps-transform-style.html:
  • compositing/overflow/clip-descendents.html:
  • compositing/overflow/content-gains-scrollbars.html:
  • compositing/overflow/content-loses-scrollbars.html:
  • compositing/overflow/overflow-auto-with-touch-no-overflow.html:
  • compositing/overflow/overflow-auto-with-touch-toggle.html:
  • compositing/overflow/overflow-auto-with-touch.html:
  • compositing/overflow/overflow-hidden-with-touch.html:
  • compositing/overflow/overflow-overlay-with-touch-no-overflow.html:
  • compositing/overflow/overflow-overlay-with-touch.html:
  • compositing/overflow/overflow-scroll-with-touch-no-overflow.html:
  • compositing/overflow/overflow-scrollbar-layers.html:
  • compositing/overflow/overflow-visible-with-touch.html:
  • compositing/overflow/resize-painting.html:
  • compositing/overflow/scrolling-content-clip-to-viewport.html:
  • compositing/overflow/textarea-scroll-touch.html:
  • compositing/plugins/1x1-composited-plugin.html:
  • compositing/plugins/large-to-small-composited-plugin.html:
  • compositing/plugins/no-backing-store.html:
  • compositing/plugins/small-to-large-composited-plugin.html:
  • compositing/rtl/rtl-absolute-overflow-scrolled.html:
  • compositing/rtl/rtl-absolute-overflow.html:
  • compositing/rtl/rtl-absolute.html:
  • compositing/rtl/rtl-fixed-overflow-scrolled.html:
  • compositing/rtl/rtl-fixed-overflow.html:
  • compositing/rtl/rtl-fixed.html:
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html:
  • compositing/rtl/rtl-iframe-absolute-overflow.html:
  • compositing/rtl/rtl-iframe-absolute.html:
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html:
  • compositing/rtl/rtl-iframe-fixed-overflow.html:
  • compositing/rtl/rtl-iframe-fixed.html:
  • compositing/rtl/rtl-iframe-relative.html:
  • compositing/rtl/rtl-relative.html:
  • compositing/tiled-layers-hidpi.html:
  • compositing/tiling/crash-reparent-tiled-layer.html:
  • compositing/tiling/huge-layer-add-remove-child.html-disabled:
  • compositing/tiling/huge-layer-img.html-disabled:
  • compositing/tiling/huge-layer-resize.html-disabled:
  • compositing/tiling/huge-layer-with-layer-children-resize.html-disabled:
  • compositing/tiling/huge-layer-with-layer-children.html-disabled:
  • compositing/tiling/huge-layer.html-disabled:
  • compositing/video/video-poster.html:
  • compositing/visibility/layer-visible-content.html:
  • compositing/visibility/visibility-image-layers-dynamic.html:
  • css3/compositing/should-have-compositing-layer.html:
  • css3/filters/composited-during-animation-layertree.html:
  • css3/filters/composited-during-transition-layertree.html:
  • css3/filters/filtered-compositing-descendant.html:
  • css3/filters/should-not-have-compositing-layer.html:
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html:
  • platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
  • platform/mac/compositing/canvas/accelerated-canvas-compositing.html:
2:27 PM Changeset in webkit [130688] by jonlee@apple.com
  • 17 edits
    2 adds in trunk/Source/WebCore

Add render object that paints plugin snapshots
https://bugs.webkit.org/show_bug.cgi?id=98322
<rdar://problem/12426546>

Reviewed by Simon Fraser.

First, teach plugins to maintain a set of states when plugin snapshotting is enabled.

Second, a new RenderSnapshottedPlugIn class is a RenderEmbeddedObject that knows how to paint
snapshots when the plugin is not visibly playing. It maintains a RenderImageResource to
the generated poster image.

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::HTMLPlugInElement): By default all plugins play on load.

  • html/HTMLPlugInElement.h: Move the inheritance of ImageLoaderClientBase down to

HTMLPlugInImageElement, since that is the class that actually deals with image-based plugins.
(WebCore::HTMLPlugInElement::displayState): Add bit for display state.
(WebCore::HTMLPlugInElement::setDisplayState):
(WebCore::HTMLPlugInElement::updateSnapshot):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): If plugin snapshotting is
enabled, plugin state is set to wait for a poster image.
(WebCore::HTMLPlugInImageElement::createRenderer): Create RenderSnapshottedPlugIn if
plugin snapshotting is enabled.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Once a snapshot is available, update the
renderer and set its state to wait for user input to start the plugin.

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isSnapshottedPlugIn): Add new function to identify
RenderSnapshottedPlugIn instances. Since RenderSnapshottedPlugIn inherits from
RenderEmbeddedObject, isEmbeddedObject() still returns true.

  • rendering/RenderEmbeddedObject.h:

(RenderEmbeddedObject): Elevate a few virtual methods to protected for
RenderSnapshottedPlugIn to override.

  • rendering/RenderSnapshottedPlugIn.cpp: Added.

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): Initialize snapshot
resource.
(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn): Shut down snapshot
image resource to remove the renderer as a client, and remove image from memory cache.
(WebCore::RenderSnapshottedPlugIn::plugInImageElement): Convenience function to get the
HTML element.
(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Cache the snapshot, and repaint.
(WebCore::RenderSnapshottedPlugIn::paint): If the plugin is not playing, paint like a
RenderImage does.
(WebCore::RenderSnapshottedPlugIn::paintReplaced): Paint the snapshot and overlay if the
plugin is not playing.
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot): Inspired by
RenderImage::paintReplaced() and RenderImage::paintIntoRect().

  • rendering/RenderSnapshottedPlugIn.h: Added.

(WebCore::RenderSnapshottedPlugIn::isSnapshottedPlugin): Returns true.

  • rendering/RenderTheme.h: Add a function that paints the overlay on top of the snapshot.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintPlugInSnapshotOverlay):

  • WebCore.xcodeproj/project.pbxproj: Add new RenderSnapshottedPlugIn class.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • rendering/RenderingAllInOne.cpp: Ditto.
2:20 PM Changeset in webkit [130687] by commit-queue@webkit.org
  • 10 edits
    13 adds in trunk

[CSS Exclusions] Add support for polygonal shapes
https://bugs.webkit.org/show_bug.cgi?id=96811

Patch by Hans Muller <hmuller@adobe.com> on 2012-10-08
Reviewed by Dirk Schulze.

Source/WebCore:

Initial version of the layout support for polygonal exclusion shapes: the ExclusionPolygon class.
Supports the public ExclusionShape operations using the algorithm described here:
http://hansmuller-webkit.blogspot.com/2012/06/horizontal-box-polygon-intersection-for.html.
Although both the "included" and "excluded" operations are supported, only the former is
used, since only shape-inside is supported at the moment.

The ExclusionPolygon class stores the polygon's edges in an interval tree.

Polygon edges are represented by the ExclusionPolygonEdge struct, which records the indices of
the pair of vertices joined by the edge. Edge vertex index1 is usually less than index2, except
the last edge where index2 is 0. We plan to improve the algorithm that creates the edges
by spanning vertices contained in sequences of more than two colinear vertices. For example,
a triangular polygon might be specified with 5 vertices like this: 3,0 5,0, 5,5, 4,4 2,2, 0,0.
By spanning the extra colinear points: 0,0 5,0, 5,5, which implies index1-index2 edges: 5-1 1-2 2-5.

Although the implementation supports complex polygons, the layout code is limited to
essentially rectangular shapes until a patch for https://bugs.webkit.org/show_bug.cgi?id=96813
lands.

Tests: fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html

fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html
fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html
fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html
fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/ExclusionPolygon.cpp: Added.

(WebCore):
(EdgeIntersection): Internal description of the intersection of a polygon edge and a horizontal line.
(WebCore::ExclusionPolygon::ExclusionPolygon): See the introductory text above for a description of this type.
(WebCore::computeXIntersection): Find and classify the X intercept of a polygon edge with horizontal line, if any.
(WebCore::ExclusionPolygon::rightVertexY): This method is used to decide if a horizontal line "crosses" a vertex.
(WebCore::appendIntervalX): Append an x coordinate to a vector of ExclusionIntervals.
(WebCore::ExclusionPolygon::computeXIntersections): Return a vector of the intersections of a horizontal line with the polygon's edges.
(WebCore::ExclusionPolygon::computeEdgeIntersections): Return a vector of the X projections of the edges that overlap a horizonal rectangle.
(WebCore::ExclusionPolygon::getExcludedIntervals): Return a SegmentList of the X intervals within a horizontal rectangle that overlap the polygon.
(WebCore::ExclusionPolygon::getIncludedIntervals): Return the X intervals within a horizontal rectangle that fit inside the polygon.

  • rendering/ExclusionPolygon.h: Added.

(WebCore):
(ExclusionPolygon):
(WebCore::ExclusionPolygon::getXAt): X coordinate of a polygon vertex
(WebCore::ExclusionPolygon::getYAt): Y coordinate of a polygon vertex
(WebCore::ExclusionPolygon::numberOfVertices):
(WebCore::ExclusionPolygon::fillRule): A WindRule value that defines "inside" for self-intersecting polygons.
(ExclusionPolygonEdge):
(WebCore::ExclusionPolygonEdge::ExclusionPolygonEdge):
(WebCore::ExclusionPolygonEdge::vertex1):
(WebCore::ExclusionPolygonEdge::vertex2):
(WebCore::ExclusionPolygonEdge::minX):
(WebCore::ExclusionPolygonEdge::minY):
(WebCore::ExclusionPolygonEdge::maxX):
(WebCore::ExclusionPolygonEdge::maxY):

  • rendering/ExclusionShape.cpp:

(WebCore::createExclusionPolygon): Return a new ExclusionPolygon.
(WebCore):
(WebCore::ExclusionShape::createExclusionShape): Added support for BasicShape::BASIC_SHAPE_POLYGON.

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock): Enable BASIC_SHAPE_POLYGON shapes for RenderBlocks.

LayoutTests:

Verify that a rectangular shape-inside specified as a polygon works as expected for all
writing-modes.

Added exclusions tests for non-complex concave shape-inside polygons as well.
The shapes in this set of tests are "rectangular" in the sense that
horizontal lines that overlap the polygon only cross the polygon twice.
The expected part of each test uses float "sandbags" to simulate the
shape-inside area in the test expectations. The tests use SVG to
display the polygon itself, to simplify visual inspection.
(See http://www.alistapart.com/articles/sandbags/).

  • fast/exclusions/shape-inside/shape-inside-polygon-rectangle-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html: Added.
  • fast/exclusions/resources/simple-polygon.js: Added.

(createPolygon):
(polygonXIntercepts):
(generatePolygonContentString):
(simulatePolygonShape):
(generateSimulatedPolygonShapeInsideElement):
(positionInformativeText):
(createPolygonShapeInsideTestCase):
(createPolygonShapeInsideTestCaseExpected):

  • fast/exclusions/shape-inside/shape-inside-simple-polygon-001-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-002-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-003-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-004-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html: Added.
2:16 PM Changeset in webkit [130686] by tony@chromium.org
  • 5 edits in trunk/Source/WebCore

Replace 2 uses of updateLogicalHeight with computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=98677

Reviewed by Ojan Vafai.

This is part of bug 96804. Convert RenderTextControl and RenderSVGForeignObject to
override the const computeLogicalHeight method rather than the updateLogicalHeight
setter method.

No new tests, there should be no behavior change as this is just a refactor.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeLogicalHeight): Pass logicalHeight through rather than setting height.
This is a slight correctness fix, although we don't support vertical inputs yet.

  • rendering/RenderTextControl.h:

(RenderTextControl):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::computeLogicalHeight):

  • rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

2:16 PM Changeset in webkit [130685] by Csaba Osztrogonác
  • 2 edits
    8 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add PNGs after r130653,
and skip tests on Qt-WK2, because they fail on it.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-text2-expected.png: Added.
2:10 PM Changeset in webkit [130684] by jchaffraix@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

Unreviewed Chromium gardening.

Rebaselined those 2 tables/ tests that were forgotten in the rebaselining after r103875.
https://bugs.webkit.org/show_bug.cgi?id=74888 was opened to track those rebaselining but
it looks like some platform fell through the cracks.

  • platform/chromium/TestExpectations:

Removed the 2 entries.

  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions1-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions2-expected.txt: Added.

Progression: the table captions are larger, which matches other browsers and other platforms' baselines.

1:58 PM Changeset in webkit [130683] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Upstream some tweaks for overlay play button on Android
https://bugs.webkit.org/show_bug.cgi?id=98671

Patch by Min Qin <qinmin@chromium.org> on 2012-10-08
Reviewed by Adam Barth.

This change stops displaying the overlay play button if video height is too small
No test for this. Will rebase layout test expectations for android later.

  • css/mediaControlsChromiumAndroid.css:

(video::-webkit-media-controls-overlay-enclosure):

1:54 PM Changeset in webkit [130682] by zandobersek@gmail.com
  • 4 edits in trunk

GTK port should warn if bug modifier is missing in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=98678

Reviewed by Dirk Pranke.

Tools:

Reimplement the warn_if_bug_missing_in_test_expectations method in
GtkPort, returning True for producing a warning in such cases.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.warn_if_bug_missing_in_test_expectations):

LayoutTests:

Add generic Bug(GTK) modifiers for two test expectations.

  • platform/gtk/TestExpectations:
1:48 PM Changeset in webkit [130681] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress editing/pasteboard/data-transfer-items.html failure.
https://bugs.webkit.org/show_bug.cgi?id=98686

Unreviewed, expectations change.

  • platform/chromium/TestExpectations:
1:47 PM Changeset in webkit [130680] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Add missing compile flag for compositing
https://bugs.webkit.org/show_bug.cgi?id=98681

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-10-08
Reviewed by Dirk Schulze.

This flag is needed in case there is a difference in API
when compositing is enabled

  • Configurations/FeatureDefines.xcconfig:
1:26 PM Changeset in webkit [130679] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed rebaselining after r130598 and r130600.

  • platform/chromium-linux-x86/svg/filters/filterRes-expected.txt:

This baseline was forgotten.

1:24 PM Changeset in webkit [130678] by eae@chromium.org
  • 4 edits
    3 copies in branches/chromium/1271

Merge 130329 - Round image sizes when zooming
https://bugs.webkit.org/show_bug.cgi?id=98205

Reviewed by Eric Seidel.

Source/WebCore:

We currently floor image sizes when zooming which can result in
images being rendered at one pixel less than the actual size.
This is especially likely to happen for very large images.

Test: fast/sub-pixel/zoomed-image-tiles.html

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

LayoutTests:

Add test for zoomed large image tiles.

  • fast/images/zoomed-img-size.html:
  • fast/sub-pixel/zoomed-image-tiles-expected.html: Added.
  • fast/sub-pixel/zoomed-image-tiles.html: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium/fast/images/zoomed-img-size-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/mac-lion/TestExpectations:
  • platform/mac-snowleopard/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win-wk2/TestExpectations:
  • platform/win-xp/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:

TBR=eae@chromium.org

1:22 PM Changeset in webkit [130677] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=98663

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Laszlo Gombos.

EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test was
failing because the elements of a list were checked in a given
order but the list was not sorted beforehand.

  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(sortHostNames):
(TEST_F):

1:10 PM Changeset in webkit [130676] by Simon Fraser
  • 16 edits in trunk/Source

Some GraphicsLayer cleanup to separate the concepts of using a tile cache, and being the main tile cache layer
https://bugs.webkit.org/show_bug.cgi?id=98574

Reviewed by Dean Jackson.

GraphicsLayerCA assumed that using a TileCache equated to being the main page tile
cache layer, which has some special considerations. Make these two concepts separate
to get closer to being able to use TileCaches in place of CATiledLayer.

Source/WebCore:

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer): Remove m_usingTileCache member, which was not appropriate
for this class to have.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer): Remove init of m_usingTileCache.
(WebCore::GraphicsLayer::debugBorderInfo): Can no longer use m_usingTileCache to
get the blue color, so moved code into a virtual debugBorderInfo() method.
(WebCore::GraphicsLayer::updateDebugIndicators): Call the virtual debugBorderInfo().

  • platform/graphics/GraphicsLayerClient.h: Remove the usingTileCache() callback;

we now just cache this information in the GraphicsLayerCA on creation.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA): Init m_isPageTileCacheLayer to false,
then set to m_isPageTileCacheLayer if the client says we should create a tile cache.
(WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter): Overidden to avoid duplicate repaint
counters in the top-left tile.
(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): If this layer is the page tile cache layer,
we allow setting of its background color.
(WebCore::GraphicsLayerCA::debugBorderInfo): Overidden to use a blue color for tiles.
(WebCore::GraphicsLayerCA::requiresTiledLayer): Don't make CATiledLayers for the page tile cache.

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/PlatformCALayerClient.h:

(PlatformCALayerClient): Need to pass the platform layer into platformCALayerShowRepaintCounter()
so we can distinguish between calls for tiles, and calls for the tile cache layer itself.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::shouldShowRepaintCounters): Pass 0 to platformCALayerShowRepaintCounter() to
indicate that we're asking about a tile.

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents): Now we can just rely on platformCALayerShowRepaintCounter() to tell us whether
to draw the repaint counter.
(-[WebLayer setNeedsDisplayInRect:]):

  • platform/graphics/mac/WebTiledLayer.mm:

(-[WebTiledLayer setNeedsDisplayInRect:]):

  • rendering/RenderLayerBacking.h:

(WebCore::RenderLayerBacking::usingTileCache):
(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::documentBackgroundColorDidChange): We can ask the RenderLayerBacking
whether it's for the tile cache, rather than going to the GraphicsLayer.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerShowRepaintCounter):

Source/WebKit/win:

  • FullscreenVideoController.cpp:

(FullscreenVideoController::LayerClient::platformCALayerShowRepaintCounter):

12:46 PM Changeset in webkit [130675] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] new test introduced in r120354 fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=91968

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Unskipping test.

  • platform/qt/TestExpectations:
12:33 PM Changeset in webkit [130674] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-08

  • DEPS:
12:18 PM Changeset in webkit [130673] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

[EFL][DRT] Switch default backing store to single
https://bugs.webkit.org/show_bug.cgi?id=98591

Reviewed by Eric Seidel.

There are two backing stores for WebKit/Efl, Single Backing Store(SBS) and
Tiled Backing Store(TBS), and DRT/Efl has used TBS.
But, TBS is not suitable to run pixel tests because it does not have a good way
to render mock scrollbars well.

So, this patch changes the default backing store to SBS.
In addition, this changes the environment variable from DRT_USE_SINGLE_BACKING_STORE
to DRT_USE_TILED_BACKING_STORE.

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(shouldUseTiledBackingStore):
(chooseAndInitializeAppropriateSmartClass):

12:14 PM Changeset in webkit [130672] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt] Make ImageBufferQt use premultiplied converting functions in Color.h instead of its own mechanism.
https://bugs.webkit.org/show_bug.cgi?id=98582

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-08
Reviewed by Eric Seidel.

Source/WebCore:

Only Qt port failed canvas/philip/tests/2d.imageData.put.unchanged.html because
ImageBufferQt converts from or to a premultiplied color using its own code. When
we convert twice from an unmultiplied color to a premultiplied color and then to
an unmultiplied color using this code, the calculated result are pretty
different against the input color. It is why Gtk passes this test although Qt
fails. Gtk port uses them in Color.h.

In addition, Qt should use the functions in Color.h to reduce duplicated codes.

Tests: canvas/philip/tests/2d.imageData.put.unchanged.html: Fixed a test case

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::getImageData):
(WebCore::convertBGRAToRGBA):
(WebCore::ImageBuffer::putByteArray):

LayoutTests:

Unskipping canvas/philip/tests/2d.imageData.put.unchanged.html that is passing.

  • platform/qt/TestExpectations:
12:10 PM Changeset in webkit [130671] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Avoid useless converting to WKPage
https://bugs.webkit.org/show_bug.cgi?id=98516

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-08
Reviewed by Eric Seidel.

Use priv->pageProxy->findString() and priv->pageProxy->hideFindUI()
to avoid useless converting to WK.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):

12:07 PM Changeset in webkit [130670] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Fix video-test.js relativeURL() bug
https://bugs.webkit.org/show_bug.cgi?id=98546

Patch by Shadi Khalek <shadi@chromium.org> on 2012-10-08
Reviewed by Eric Seidel.

Some layout tests failed due to this bug (crbug.com/154157)

  • media/video-test.js:

(testArraysEqual):
(relativeURL):

12:02 PM Changeset in webkit [130669] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Perf test pesults page takes forever to load on a machine with a slow Internet connection
https://bugs.webkit.org/show_bug.cgi?id=98561

Reviewed by Ojan Vafai.

Try loading jquery both locally and remotely, and use the same method to load the remaining
jquery plugins when either one succeeds.

  • resources/results-template.html:
12:00 PM Changeset in webkit [130668] by commit-queue@webkit.org
  • 5 edits
    14 deletes in trunk

Remove "orphaned units" quirk
https://bugs.webkit.org/show_bug.cgi?id=98553

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-08
Reviewed by Eric Seidel.

This patch removes our "orphaned units" quirk.
We have an "orphaned units" quirk to match IE, which allows things like "width: 20 px;".
But FF and Opera don't have it and aren't aware of bugs for it,
and it's not in Simon Pieters' Quirks Mode spec <http://dvcs.w3.org/hg/quirks-mode/raw-file/tip/Overview.html>

No new tests, because I'm killing a quirk.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSParser.h:

(CSSParser):

11:57 AM Changeset in webkit [130667] by jchaffraix@webkit.org
  • 2 edits
    24 adds
    4 deletes in trunk/LayoutTests

Additional fast/repaint Chromium rebaseline.

Rebaselined more tests on Chromium Mac. Same as r130654 but there
is some anti-aliasing differences on transformed lines.

  • platform/chromium/TestExpectations:

Removed the rebaselined tests.

  • fast/repaint/table-section-repaint-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-outline-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/table-collapsed-border-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/text-append-dirty-lines-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/transform-relative-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/transform-repaint-descendants-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-outline-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-col-background-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-collapsed-border-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-outer-border-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-row-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-section-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-section-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-two-pass-layout-overpaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/text-append-dirty-lines-expected.png: Added.
  • platform/chromium-mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
  • platform/chromium-mac/fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/transform-absolute-child-expected.png: Added.
  • platform/chromium-mac/fast/repaint/transform-disable-layoutstate-expected.png: Added.
  • platform/chromium-mac/fast/repaint/transform-relative-position-expected.png: Added.
  • platform/chromium-mac/fast/repaint/transform-repaint-descendants-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-section-repaint-expected.txt: Removed.
  • platform/chromium/fast/repaint/table-section-repaint-expected.txt: Added.
  • platform/efl/fast/repaint/table-section-repaint-expected.txt: Removed.
  • platform/gtk/fast/repaint/table-section-repaint-expected.txt: Removed.
  • platform/qt/fast/repaint/table-section-repaint-expected.txt: Removed.
11:50 AM Changeset in webkit [130666] by zandobersek@gmail.com
  • 46 edits
    6 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining SVG tests after changes in r130599.

  • platform/gtk/TestExpectations:
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • platform/gtk/svg/batik/paints/gradientLimit-expected.png:
  • platform/gtk/svg/batik/paints/gradientLimit-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-expected.png:
  • platform/gtk/svg/batik/paints/patternRegions-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/batik/text/textEffect-expected.png:
  • platform/gtk/svg/batik/text/textEffect-expected.txt: Added.
  • platform/gtk/svg/batik/text/textEffect3-expected.png:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/gtk/svg/custom/gradient-deep-referencing-expected.png:
  • platform/gtk/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/gtk/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
  • platform/gtk/svg/custom/gradient-with-1d-boundingbox-expected.txt:
  • platform/gtk/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
  • platform/gtk/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
  • platform/gtk/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/gtk/svg/custom/radialGradient-focal-radius-expected.txt: Added.
  • platform/gtk/svg/custom/recursive-gradient-expected.png:
  • platform/gtk/svg/custom/recursive-gradient-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/gtk/svg/custom/stroked-pattern-expected.png:
  • platform/gtk/svg/custom/stroked-pattern-expected.txt:
  • platform/gtk/svg/hixie/perf/006-expected.png:
  • platform/gtk/svg/hixie/perf/006-expected.txt:
11:46 AM Changeset in webkit [130665] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

audiobuffer.html need to include audio-testing.js file.
https://bugs.webkit.org/show_bug.cgi?id=98641

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-08
Reviewed by Eric Seidel.

As we discussed at the bug https://bugs.webkit.org/show_bug.cgi?id=88624,
WebAudio tests need to include audio-testing.js file to set WebKitWebAudioEnabled.

  • webaudio/audiobuffer.html: Include audio-testing.js file.
11:46 AM Changeset in webkit [130664] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

After r130344, OpaqueJSString() creates an empty string which should be a null string
https://bugs.webkit.org/show_bug.cgi?id=98417

Reviewed by Sam Weinig.

Changed create() of a null string to return 0. This is the same behavior as before r130344.

  • API/OpaqueJSString.cpp:

(OpaqueJSString::create):

11:44 AM Changeset in webkit [130663] by robert@webkit.org
  • 3 edits
    2 adds in trunk

Border, margin and padding of an inline's inline ancestors counted twice
https://bugs.webkit.org/show_bug.cgi?id=63074

Reviewed by David Hyatt.

Source/WebCore:

In a line such as '<span><span><img>Text' the border, padding and margin belonging
to the two spans was counted twice by RenderBlockLineLayout::nextLineBreak(): once
when adding the width of the <img> object to the line, and a second time when adding
the 'Text'. The result was that nextLineBreak() now had a length for the line that
exceeded the line's maximum length and inserted a bogus line break.

This all happened because the helper function that is used to add in the border etc.
from inline ancestors was crawling up the tree each time. It doesn't need to do that, it
should stop crawling up the tree when the current object is not the first or last sibling below a parent.

Test: fast/inline/bpm-inline-ancestors.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::shouldAddBorderPaddingMargin): Broke this check out into a helper function so that it
can help inlineLogicalWidth() return early and also treat empty RenderTexts the same as no previous/next
sibling on the line. This ensures that collapsed leading space does not interfere with the decision to
crawl up the ancestors accumulating border, padding, and margin.
(WebCore):
(WebCore::inlineLogicalWidth): Return early once the current child is no longer on the edge of its line -
this ensures the border, padding and margin of ancestors is not counted twice.

LayoutTests:

  • fast/inline/bpm-inline-ancestors-expected.html: Added.
  • fast/inline/bpm-inline-ancestors.html: Added.
11:40 AM Changeset in webkit [130662] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2][WTR] WebKitTestRunner needs testRunner.dispatchPendingLoadRequests
https://bugs.webkit.org/show_bug.cgi?id=98638

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-08
Reviewed by Eric Seidel.

Source/WebKit2:

Add implementation for testRunner.dispatchPendingLoadRequests in
WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleDispatchPendingLoadRequests):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::dispatchPendingLoadRequests):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Add implementation for testRunner.dispatchPendingLoadRequests in
WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::dispatchPendingLoadRequests):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskip http/tests/loading/deleted-host-in-resource-load-delegate-callback.html

  • platform/wk2/TestExpectations:
11:37 AM Changeset in webkit [130661] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip http/tests/multipart/multipart-html.php while we wait for kov's patch.

  • platform/efl/TestExpectations:
11:37 AM Changeset in webkit [130660] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Add support for window.close in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98667

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Laszlo Gombos.

When calling window.close() from JavaScript, MiniBrowser
now closes the given window.

  • MiniBrowser/efl/main.c:

(window_close):
(on_ecore_evas_delete):
(on_close_window):
(window_create):

11:35 AM Changeset in webkit [130659] by ojan@chromium.org
  • 3 edits in trunk/Tools

Properly strip new tests from the test results json if they are pass/nodata/skip.
https://bugs.webkit.org/show_bug.cgi?id=98669

Reviewed by Eric Seidel.

In _merge_json, we had a codepath that didn't call _normalize_results_json
for tests that aren't already in the aggregated results.
Instead, now do all the merging first and then normalize the aggregated results.

  • TestResultServer/model/jsonresults.py:

(JsonResults._merge_json):
(JsonResults._merge_tests):
(JsonResults._normalize_results):
(JsonResults):
(JsonResults._should_delete_leaf):

  • TestResultServer/model/jsonresults_unittest.py:

Removed test_merge_build_directory_hierarchy_old_version since there is
no longer any version 3 json to support.
(JsonResultsTest.test_merge_remove_new_test):
(JsonResultsTest.test_merge_prune_extra_results_with_new_result_of_same_type):

11:23 AM Changeset in webkit [130658] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Simplify frame flattening support in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=98657

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Simplify frame flattening support code in MiniBrowser to
avoid passing the setting around to window_create()
function().

  • MiniBrowser/efl/main.c:

(on_key_down):
(on_new_window):
(window_create):
(main):

11:15 AM Changeset in webkit [130657] by mkwst@chromium.org
  • 4 edits
    2 adds in trunk

Null-check for DOMWindow before feeding it to FeatureObserver.
https://bugs.webkit.org/show_bug.cgi?id=98624

Reviewed by Adam Barth.

Source/WebCore:

We shouldn't call out to FeatureObserver in
ContentSecurityPolicy::didReceiveHeader if the policy's document doesn't
have a DOMWindow.

Test: http/tests/security/contentSecurityPolicy/xmlhttprequest-protected-resource-does-not-crash.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::didReceiveHeader):

Null check 'document->domWindow' before passing it on.

  • page/FeatureObserver.cpp:

(WebCore::FeatureObserver::observe):

ASSERT 'domWindow'.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/xmlhttprequest-protected-resource-does-not-crash-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/xmlhttprequest-protected-resource-does-not-crash.html: Added.

This test shouldn't crash.

11:10 AM Changeset in webkit [130656] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Add minimum version information for tool dependencies
https://bugs.webkit.org/show_bug.cgi?id=97592

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Capture the minimum version information for the tools that are required
to build the EFL port (or more generally WebKit).

  • CMakeLists.txt:
11:05 AM Changeset in webkit [130655] by tony@chromium.org
  • 13 edits
    5 deletes in trunk/LayoutTests

Unreviewed, new baseline for fast/table/colspanMinWidth-vertical.html.

The baseline changed in http://trac.webkit.org/changeset/130569 because
controls should all be horizontal.

  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.txt: Removed.
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/TestExpectations:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/qt/TestExpectations:
  • platform/qt/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/qt/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
10:54 AM Changeset in webkit [130654] by jchaffraix@webkit.org
  • 3 edits
    43 adds
    1 delete in trunk/LayoutTests

Unreviewed fast/repaint Chromium rebaselining.

Rebaselined those tests on Chromium Mac. The differences fall in 3 buckets:

  • the background has an alpha off-by-one (crbug.com/23473)
  • the repaint rectangles are united (the Mac baselines don't do the union).
  • On Lion, the font used is different.
  • platform/chromium/TestExpectations:

Removed the rebaselined tests' entries.

  • platform/chromium-mac-snowleopard/fast/repaint/bugzilla-5699-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/control-clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/create-layer-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/layout-state-only-positioned-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/list-marker-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/make-children-non-inline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/outline-child-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/outline-repaint-glitch-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-scroll-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/reflection-redraw-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/selection-after-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/static-to-positioned-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/table-cell-move-expected.png: Added.
  • platform/chromium-mac/fast/repaint/background-generated-expected.png: Added.
  • platform/chromium-mac/fast/repaint/bugzilla-5699-expected.png: Added.
  • platform/chromium-mac/fast/repaint/content-into-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/control-clip-expected.png: Added.
  • platform/chromium-mac/fast/repaint/control-clip-expected.txt:
  • platform/chromium-mac/fast/repaint/create-layer-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/intermediate-layout-position-clip-expected.png: Added.
  • platform/chromium-mac/fast/repaint/intermediate-layout-position-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layout-state-only-positioned-expected.png: Added.
  • platform/chromium-mac/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
  • platform/chromium-mac/fast/repaint/line-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/list-marker-2-expected.png: Added.
  • platform/chromium-mac/fast/repaint/make-children-non-inline-expected.png: Added.
  • platform/chromium-mac/fast/repaint/outline-child-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/outline-inset-expected.png: Added.
  • platform/chromium-mac/fast/repaint/outline-repaint-glitch-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-into-content-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-scroll-delete-expected.png: Added.
  • platform/chromium-mac/fast/repaint/reflection-redraw-expected.png: Added.
  • platform/chromium-mac/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/selection-after-delete-expected.png: Added.
  • platform/chromium-mac/fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
  • platform/chromium-mac/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/chromium-mac/fast/repaint/static-to-positioned-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Added.
  • platform/chromium-win/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
  • platform/mac-lion/fast/repaint: Removed.
  • platform/mac-lion/fast/repaint/control-clip-expected.txt: Removed.
10:21 AM Changeset in webkit [130653] by allan.jensen@digia.com
  • 2 edits
    8 adds in trunk/LayoutTests

[Qt] Add baselines to passing ruby DOM tests.

Unreviewed gardening.

  • platform/qt/TestExpectations:
  • platform/qt/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-insert-text2-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-rt2-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-text2-expected.txt: Added.
10:13 AM Changeset in webkit [130652] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL] Use Ctrl+n shortcut to create a new window in MiniBrowser / EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=98655

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Use "Ctrl+n" shortcut instead of "F9" to open a new window in
MiniBrowser and EWebLauncher. This is the shortcut that is
commonly used for this action.

  • EWebLauncher/main.c:

(on_key_down):

  • MiniBrowser/efl/main.c:

(on_key_down):

10:08 AM Changeset in webkit [130651] by Nate Chapin
  • 6 edits
    2 adds in trunk

Source/WebCore: Loader cleanup : Simplify FrameLoader/DocumentLoader setupForReplace()
https://bugs.webkit.org/show_bug.cgi?id=49072

Reviewed by Eric Seidel.

This patch contains one small known behavior change: multipart/x-mixed-replace main resources with text/html parts
will no longer load the text/html progressively. In practice, loading the html progressively causes the document
to get cleared as soon as the next part's data starts arriving, which leads to a blank page most of the time. This case
seems to be pathological, as IE, FF, Opera and WebKit all do something different currently. This patch will cause
us to behave like Firefox, which is the most sane of the current behaviors.

Test: http/tests/multipart/multipart-html.php

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData): Use isMultipartReplacingLoad() helper.
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::setupForReplace): Renamed from setupForReplaceByMIMEType(). Call maybeFinishLoadingMultipartContent()

instead of doing identical work inline. After we call frameLoader()->setReplacing(), we will never load progressively, so remove
the if (doesProgressiveLoad(newMIMEType)) {} block.

(WebCore::DocumentLoader::isMultipartReplacingLoad):
(WebCore::DocumentLoader::maybeFinishLoadingMultipartContent): Inline the old DocumentLoader::setupForeReplace(), check

frameLoader()->isReplacing() instead of the delete doesProgressiveLoad().

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setupForReplace): Move all calls to revertToProvisionalState here.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse): Call setupForReplace(), renamed from setupForReplaceByMIMEType().

LayoutTests: Add a test for multipart/x-mixed-replace documents with text/html
parts.
https://bugs.webkit.org/show_bug.cgi?id=49072

Reviewed by Eric Seidel.

  • http/tests/multipart/multipart-html-expected.txt: Added.
  • http/tests/multipart/multipart-html.php: Added.
10:06 AM Changeset in webkit [130650] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip svg/text/caret-in-svg-text.xhtml in WK1.

  • platform/efl-wk1/TestExpectations:
10:02 AM LayoutUnit edited by eae@chromium.org
Updated article to reflect that we now use 1/64 instead of 1/60. (diff)
9:53 AM Changeset in webkit [130649] by jchaffraix@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

Unreviewed gardening after r130587.

Per discussion with Adam, this change lands the failing baselines to
get some coverage until V8 matches JSC. Fixing the baselines is
covered by https://bugs.webkit.org/show_bug.cgi?id=98658

  • platform/chromium/TestExpectations:

Marked one of test as SLOW as it is timing out in Debug.

  • platform/chromium/fast/dom/gc-12-expected.txt: Added.
  • platform/chromium/fast/dom/gc-3-expected.txt: Added.
  • platform/chromium/fast/dom/gc-5-expected.txt: Added.
  • platform/chromium/fast/dom/gc-dom-tree-lifetime-expected.txt: Added.
9:50 AM Changeset in webkit [130648] by allan.jensen@digia.com
  • 5 edits in trunk/LayoutTests

Unreviewed Qt gardening.

Rebaseline Qt expectations for these passing tests.

  • platform/qt/TestExpectations:
  • platform/qt/fast/text/basic/013-expected.txt:
  • platform/qt/fast/text/basic/015-expected.txt:
  • platform/qt/fast/text/line-breaks-expected.txt:
9:45 AM Changeset in webkit [130647] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark fast/dynamic/window-scrollbars-test.html as flaky.

  • platform/efl/TestExpectations:
9:33 AM Changeset in webkit [130646] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Add support for window.create in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98649

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Calling window.create() from JavaScript now creates a
new window in Minibrowser, as directed.

  • MiniBrowser/efl/main.c:

(on_new_window):
(window_create):

9:14 AM Changeset in webkit [130645] by rakuco@webkit.org
  • 2 edits
    128 adds in trunk/LayoutTests

[EFL] Unskip svg/text.

Most of the text cases are passing, the ones which don't have been
properly skipped.

  • platform/efl/TestExpectations:
  • platform/efl/svg/text/append-text-node-to-tspan-expected.png: Added.
  • platform/efl/svg/text/append-text-node-to-tspan-expected.txt: Added.
  • platform/efl/svg/text/bidi-embedded-direction-expected.png: Added.
  • platform/efl/svg/text/bidi-embedded-direction-expected.txt: Added.
  • platform/efl/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/efl/svg/text/bidi-reorder-value-lists-expected.txt: Added.
  • platform/efl/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/efl/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/efl/svg/text/bidi-text-query-expected.png: Added.
  • platform/efl/svg/text/bidi-text-query-expected.txt: Added.
  • platform/efl/svg/text/bidi-tspans-expected.png: Added.
  • platform/efl/svg/text/bidi-tspans-expected.txt: Added.
  • platform/efl/svg/text/ems-display-none-expected.png: Added.
  • platform/efl/svg/text/ems-display-none-expected.txt: Added.
  • platform/efl/svg/text/exs-display-none-expected.png: Added.
  • platform/efl/svg/text/exs-display-none-expected.txt: Added.
  • platform/efl/svg/text/font-size-below-point-five-2-expected.png: Added.
  • platform/efl/svg/text/font-size-below-point-five-2-expected.txt: Added.
  • platform/efl/svg/text/font-size-below-point-five-expected.png: Added.
  • platform/efl/svg/text/font-size-below-point-five-expected.txt: Added.
  • platform/efl/svg/text/foreignObject-repaint-expected.png: Added.
  • platform/efl/svg/text/foreignObject-repaint-expected.txt: Added.
  • platform/efl/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
  • platform/efl/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.
  • platform/efl/svg/text/kerning-expected.png: Added.
  • platform/efl/svg/text/kerning-expected.txt: Added.
  • platform/efl/svg/text/modify-text-node-in-tspan-expected.png: Added.
  • platform/efl/svg/text/modify-text-node-in-tspan-expected.txt: Added.
  • platform/efl/svg/text/multichar-glyph-expected.png: Added.
  • platform/efl/svg/text/multichar-glyph-expected.txt: Added.
  • platform/efl/svg/text/remove-text-node-from-tspan-expected.png: Added.
  • platform/efl/svg/text/remove-text-node-from-tspan-expected.txt: Added.
  • platform/efl/svg/text/remove-tspan-from-text-expected.png: Added.
  • platform/efl/svg/text/remove-tspan-from-text-expected.txt: Added.
  • platform/efl/svg/text/scaled-font-expected.png: Added.
  • platform/efl/svg/text/scaled-font-expected.txt: Added.
  • platform/efl/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/efl/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
  • platform/efl/svg/text/selection-background-color-expected.png: Added.
  • platform/efl/svg/text/selection-background-color-expected.txt: Added.
  • platform/efl/svg/text/selection-styles-expected.png: Added.
  • platform/efl/svg/text/selection-styles-expected.txt: Added.
  • platform/efl/svg/text/small-fonts-2-expected.png: Added.
  • platform/efl/svg/text/small-fonts-2-expected.txt: Added.
  • platform/efl/svg/text/small-fonts-3-expected.png: Added.
  • platform/efl/svg/text/small-fonts-3-expected.txt: Added.
  • platform/efl/svg/text/small-fonts-expected.png: Added.
  • platform/efl/svg/text/small-fonts-in-html5-expected.png: Added.
  • platform/efl/svg/text/small-fonts-in-html5-expected.txt: Added.
  • platform/efl/svg/text/text-align-01-b-expected.png: Added.
  • platform/efl/svg/text/text-align-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-align-02-b-expected.png: Added.
  • platform/efl/svg/text/text-align-02-b-expected.txt: Added.
  • platform/efl/svg/text/text-align-03-b-expected.png: Added.
  • platform/efl/svg/text/text-align-03-b-expected.txt: Added.
  • platform/efl/svg/text/text-align-04-b-expected.png: Added.
  • platform/efl/svg/text/text-align-04-b-expected.txt: Added.
  • platform/efl/svg/text/text-align-05-b-expected.png: Added.
  • platform/efl/svg/text/text-align-05-b-expected.txt: Added.
  • platform/efl/svg/text/text-align-06-b-expected.png: Added.
  • platform/efl/svg/text/text-align-06-b-expected.txt: Added.
  • platform/efl/svg/text/text-altglyph-01-b-expected.png: Added.
  • platform/efl/svg/text/text-altglyph-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-deco-01-b-expected.png: Added.
  • platform/efl/svg/text/text-deco-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-fill-opacity-expected.png: Added.
  • platform/efl/svg/text/text-fill-opacity-expected.txt: Added.
  • platform/efl/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/efl/svg/text/text-fonts-01-t-expected.txt: Added.
  • platform/efl/svg/text/text-fonts-02-t-expected.png: Added.
  • platform/efl/svg/text/text-fonts-02-t-expected.txt: Added.
  • platform/efl/svg/text/text-gradient-positioning-expected.png: Added.
  • platform/efl/svg/text/text-gradient-positioning-expected.txt: Added.
  • platform/efl/svg/text/text-hkern-expected.png: Added.
  • platform/efl/svg/text/text-hkern-expected.txt: Added.
  • platform/efl/svg/text/text-hkern-on-vertical-text-expected.png: Added.
  • platform/efl/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
  • platform/efl/svg/text/text-intro-05-t-expected.png: Added.
  • platform/efl/svg/text/text-intro-05-t-expected.txt: Added.
  • platform/efl/svg/text/text-midpoint-split-bug-expected.png: Added.
  • platform/efl/svg/text/text-midpoint-split-bug-expected.txt: Added.
  • platform/efl/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/efl/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/efl/svg/text/text-path-01-b-expected.png: Added.
  • platform/efl/svg/text/text-path-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-path-middle-align-expected.png: Added.
  • platform/efl/svg/text/text-path-middle-align-expected.txt: Added.
  • platform/efl/svg/text/text-repaint-rects-expected.png: Added.
  • platform/efl/svg/text/text-repaint-rects-expected.txt: Added.
  • platform/efl/svg/text/text-rescale-expected.png: Added.
  • platform/efl/svg/text/text-rescale-expected.txt: Added.
  • platform/efl/svg/text/text-spacing-01-b-expected.png: Added.
  • platform/efl/svg/text/text-spacing-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-text-01-b-expected.png: Added.
  • platform/efl/svg/text/text-text-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-text-03-b-expected.png: Added.
  • platform/efl/svg/text/text-text-03-b-expected.txt: Added.
  • platform/efl/svg/text/text-text-04-t-expected.png: Added.
  • platform/efl/svg/text/text-text-04-t-expected.txt: Added.
  • platform/efl/svg/text/text-text-05-t-expected.png: Added.
  • platform/efl/svg/text/text-text-05-t-expected.txt: Added.
  • platform/efl/svg/text/text-text-06-t-expected.png: Added.
  • platform/efl/svg/text/text-text-06-t-expected.txt: Added.
  • platform/efl/svg/text/text-text-07-t-expected.png: Added.
  • platform/efl/svg/text/text-text-07-t-expected.txt: Added.
  • platform/efl/svg/text/text-text-08-b-expected.png: Added.
  • platform/efl/svg/text/text-text-08-b-expected.txt: Added.
  • platform/efl/svg/text/text-tref-01-b-expected.png: Added.
  • platform/efl/svg/text/text-tref-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-tselect-01-b-expected.png: Added.
  • platform/efl/svg/text/text-tselect-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-tselect-02-f-expected.png: Added.
  • platform/efl/svg/text/text-tselect-02-f-expected.txt: Added.
  • platform/efl/svg/text/text-tspan-01-b-expected.png: Added.
  • platform/efl/svg/text/text-tspan-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-viewbox-rescale-expected.png: Added.
  • platform/efl/svg/text/text-vkern-expected.png: Added.
  • platform/efl/svg/text/text-vkern-expected.txt: Added.
  • platform/efl/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
  • platform/efl/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
  • platform/efl/svg/text/text-ws-01-t-expected.png: Added.
  • platform/efl/svg/text/text-ws-01-t-expected.txt: Added.
  • platform/efl/svg/text/text-ws-02-t-expected.png: Added.
  • platform/efl/svg/text/text-ws-02-t-expected.txt: Added.
  • platform/efl/svg/text/textPathBoundsBug-expected.png: Added.
  • platform/efl/svg/text/textPathBoundsBug-expected.txt: Added.
  • platform/efl/svg/text/tspan-dynamic-positioning-expected.png: Added.
  • platform/efl/svg/text/tspan-dynamic-positioning-expected.txt: Added.
8:16 AM Changeset in webkit [130644] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip svg/dom/altGlyph-dom.xhtml

Seems to be passing these days.

  • platform/efl/TestExpectations:
8:11 AM Changeset in webkit [130643] by kling@webkit.org
  • 2 edits in trunk/Source/WTF

Lower minimum table size of WTF::HashTable to reduce memory usage.
<http://webkit.org/b/98406>
<rdar://problem/12432140>

Reviewed by Anders Carlsson.

Lower the default minimumTableSize for WTF hash tables from 64 to 8 entries.
This reduces WebProcess memory consumption by ~16MB on Membuster3 (a 6% progression!)

No significant movement on PLT or JSC benchmarks on my machine. If there's a perf regression somewhere
from this, we can tweak individual tables to have a larger minimumTableSize.

  • wtf/HashTraits.h:
8:05 AM Changeset in webkit [130642] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

[GTK] Add a setting to enable/disable smooth scrolling to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=98646

Reviewed by Xan Lopez.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Implement setter for new property.
(webKitSettingsGetProperty): Implement getter for new property.
(webkit_settings_class_init): Add new property
enable-smooth-scrolling.
(webkit_settings_get_enable_smooth_scrolling):
(webkit_settings_set_enable_smooth_scrolling):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Test smooth scrolling setting API.

8:04 AM Changeset in webkit [130641] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing crash expectations for tests that were fixed in r130611.

Removing failure expectations for fast/xsl/xslt-missing-namespace-in-xslt.xml,
the test is working fine after r130543.

  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
7:50 AM Changeset in webkit [130640] by allan.jensen@digia.com
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.

Adding expectations for tests under css2.1.

  • platform/qt/TestExpectations:
7:44 AM Changeset in webkit [130639] by kling@webkit.org
  • 4 edits in trunk

Using float/double as WTF hash table key is unreliable.
<http://webkit.org/b/98627>

Reviewed by Geoffrey Garen.

Source/WTF:

Change FloatHash::equal() to do a bitwise compare instead of a logical compare.
This fixes a problem where the keys with different binary representation but the
same logical value (e.g 0 and -0) could block each other from being found if they
ended up in the same hash bucket.

  • wtf/HashFunctions.h:

(FloatHash):
(WTF::FloatHash::hash):
(WTF::FloatHash::equal):

Tools:

Add a test case checking that using double as the hash table key type won't
have problems distinguishing between keys that are considered equal by operator==
but have different binary representations.

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestDoubleHashTraits):

7:36 AM BadContent edited by Csaba Osztrogonác
add more spammer addresses (diff)
7:05 AM Changeset in webkit [130638] by rakuco@webkit.org
  • 2 edits
    534 adds in trunk/LayoutTests

[EFL] Unskip svg/W3C-SVG-1.1.

All but one test case worked fine (compared to the expectations in
mac/).

  • platform/efl/TestExpectations:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-09-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-10-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-12-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-14-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-15-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-16-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-17-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-18-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-19-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-20-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prof-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prop-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prop-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prop-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-dom-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-events-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-order-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-order-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-order-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-05-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-render-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-08-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-10-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-13-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-14-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-15-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-line-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-cond-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-cond-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-group-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-group-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-09-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-use-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-06-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-06-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-deco-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-path-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tref-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tselect-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-ws-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-ws-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Added.
7:03 AM Changeset in webkit [130637] by commit-queue@webkit.org
  • 26 edits
    1 move in trunk

[EFL][WK2] Use URL instead of URI in the API
https://bugs.webkit.org/show_bug.cgi?id=98643

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Use URL instead of URI in WebKit2 EFL API. This change
was discussed on the mailing list and aims at making
the API more consistent.

  • UIProcess/API/efl/ewk_back_forward_list_item.cpp:

(_Ewk_Back_Forward_List_Item):
(ewk_back_forward_list_item_url_get):
(ewk_back_forward_list_item_original_url_get):

  • UIProcess/API/efl/ewk_back_forward_list_item.h:
  • UIProcess/API/efl/ewk_context.cpp:

(ewk_context_url_scheme_register):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_download_client.cpp:

(decideDestinationWithSuggestedFilename):

  • UIProcess/API/efl/ewk_download_job.h:
  • UIProcess/API/efl/ewk_resource_private.h:
  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_url_update):
(ewk_view_url_set):
(ewk_view_url_get):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_load_finished):
(ewk_view_load_provisional_redirect):
(ewk_view_load_provisional_started):
(ewk_view_html_string_load):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didSameDocumentNavigationForFrame):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):
(EWK2UnitTest::onURLChanged):
(EWK2UnitTest::timeOutWhileWaitingUntilURLChangedTo):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilURLChangedTo):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTestBase):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:

(EWK2UnitTestServer::EWK2UnitTestServer):
(EWK2UnitTestServer::~EWK2UnitTestServer):
(EWK2UnitTestServer::getURLForPath):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h:

(EWK2UnitTestServer):

  • UIProcess/API/efl/tests/resources/redirect_url_to_default.html: Renamed from Source/WebKit2/UIProcess/API/efl/tests/resources/redirect_uri_to_default.html.
  • UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:

(checkItem):
(urlFromTitle):

  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_download_job.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

Tools:

Update Minibrowser to reflect API changes. We now
use URL instead of URI in WK2 EFL API.

  • EWebLauncher/url_bar.c:

(on_urlbar_key_down):

  • MiniBrowser/efl/CMakeLists.txt:
  • MiniBrowser/efl/main.c:

(on_url_changed):
(window_create):

6:44 AM Changeset in webkit [130636] by zoltan@webkit.org
  • 35 edits in trunk/Source

[Qt] r122720 causes performance regression with DirectFB on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=97548

Reviewed by Jocelyn Turcotte.

Revert the rest of r122720. This change modifies the NativeImagePtr from QImage* to QPixmap*.

Covered by existing tests.

Source/WebCore:

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::QtPixmapRuntime::toQt):

  • platform/DragImage.h:

(WebCore):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/Image.h:

(Image):

  • platform/graphics/NativeImagePtr.h:

(WebCore):

  • platform/graphics/gstreamer/ImageGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamerQt.cpp:

(ImageGStreamer::ImageGStreamer):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::getImageData):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::pushTransparencyLayerInternal):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):

  • platform/graphics/qt/ImageBufferDataQt.h:

(ImageBufferData):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBufferData::ImageBufferData):
(WebCore):
(WebCore::ImageBufferData::toQImage):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageFrame::asNewNativeImage):

  • platform/graphics/qt/ImageQt.cpp:

(graphics):
(loadResourcePixmap):
(WebCore::Image::loadPlatformResource):
(WebCore::Image::setPlatformResource):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::create):

  • platform/graphics/qt/PatternQt.cpp:

(WebCore::Pattern::createPlatformPattern):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::StillImage):
(WebCore::StillImage::~StillImage):
(WebCore::StillImage::currentFrameHasAlpha):
(WebCore::StillImage::size):
(WebCore::StillImage::nativeImageForCurrentFrame):
(WebCore::StillImage::draw):

  • platform/graphics/qt/StillImageQt.h:

(WebCore::StillImage::create):
(WebCore::StillImage::createForRendering):
(StillImage):

  • platform/graphics/qt/TransparencyLayer.h:

(WebCore::TransparencyLayer::TransparencyLayer):
(TransparencyLayer):

  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:

(WebCore::GraphicsSurface::createReadOnlyImage):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::createDragImage):
(WebCore::ClipboardQt::declareAndWriteDragImage):

  • platform/qt/CursorQt.cpp:

(WebCore::createCustomCursor):

  • platform/qt/DragImageQt.cpp:

(WebCore::createDragImageFromImage):

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeImage):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

  • Api/qwebhistory.cpp:

(QWebHistoryItem::icon):

  • Api/qwebsettings.cpp:

(QWebSettings::iconForUrl):
(QWebSettings::setWebGraphic):
(QWebSettings::webGraphic):

  • WebCoreSupport/DragClientQt.cpp:

(WebCore::DragClientQt::startDrag):

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

Source/WebKit2:

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createImage):

  • UIProcess/qt/QtWebIconDatabaseClient.cpp:

(WebKit::QtWebIconDatabaseClient::iconImageForPageURL):

  • WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:

(WebKit::convertQPixmapToShareableBitmap):
(WebKit::WebDragClient::startDrag):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::adoptImageBackingStore):

6:43 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
5:51 AM Changeset in webkit [130635] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(r130629): It made touchadjustment/focusout-on-touch.html fail
https://bugs.webkit.org/show_bug.cgi?id=98642

Unreviewed gardening, skip the new failing test to paint the bot green.

  • platform/qt-5.0-wk2/TestExpectations:
4:29 AM Changeset in webkit [130634] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing header file to compilation.
4:04 AM Changeset in webkit [130633] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r130630

Explicit convertion is required from QSizeF to FloatSize.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):

4:02 AM Changeset in webkit [130632] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] plugins/refcount-leaks.html fails
https://bugs.webkit.org/show_bug.cgi?id=98640

Unreviewed gardening, skip the failing test.

  • platform/qt/TestExpectations:
3:48 AM Changeset in webkit [130631] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix the mouse hover events transformation when devicePixelRatio != 1
https://bugs.webkit.org/show_bug.cgi?id=98429

Reviewed by Kenneth Rohde Christiansen.

This prevents the events from being transformed two or three times.
This is only noticeable in desktop mode.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::handleHoverLeaveEvent):
(WebKit::QtWebPageEventHandler::handleHoverMoveEvent):

3:45 AM Changeset in webkit [130630] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Apply QQuickWebViewExperimental::devicePixelRatio to the desktop mode as well
https://bugs.webkit.org/show_bug.cgi?id=98428

Reviewed by Kenneth Rohde Christiansen.

This is handled by the PageViewportController when in flickable mode.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):

3:41 AM Changeset in webkit [130629] by jocelyn.turcotte@digia.com
  • 5 edits in trunk/Source/WebKit2

[Qt] Prevent the PageViewportController from affecting the viewport in desktop mode
https://bugs.webkit.org/show_bug.cgi?id=98427

Reviewed by Kenneth Rohde Christiansen.

QQuickFlickable isn't tightly bound to it anymore, we can avoid creating it
completely in this case.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewPrivate::viewportController):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate::viewportController):
(QQuickWebViewFlickablePrivate):

  • UIProcess/qt/QtPageClient.cpp:

(WebKit::QtPageClient::didRenderFrame):
(WebKit::QtPageClient::didChangeContentsSize):
(WebKit::QtPageClient::pageTransitionViewportReady):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(WebKit::QtWebPageLoadClient::didCommitLoad):

3:29 AM Changeset in webkit [130628] by kkristof@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

Unreviewed gardening, skip and update some failing test.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-08

  • platform/qt/TestExpectations:
  • platform/qt/http/tests/misc/acid3-expected.png:
  • platform/qt/http/tests/misc/acid3-expected.txt:
2:57 AM Changeset in webkit [130627] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix a QSocketNotifier warning at startup
https://bugs.webkit.org/show_bug.cgi?id=98411

Reviewed by Simon Hausmann.

The actual warning:
QSocketNotifier: socket notifiers cannot be enabled from another thread

The problem was that QSocketNotifier::setEnabled was called on the main thread
after moveToThread was called. This hasn't had any effect since Connection
would dispatch a readyReadHandler call right after which would then call
setEnabled again from the correct thread from ~SocketNotifierResourceGuard.

Replace the call with a queued invoke to shut the warning.

  • Platform/qt/WorkQueueQt.cpp:

(WorkQueue::registerSocketEventHandler):

2:47 AM Changeset in webkit [130626] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Fix build break when WEB_AUDIO is enabled.
https://bugs.webkit.org/show_bug.cgi?id=98635

Unreviewed build fix.

Build error is occurred because of the new flag, ENABLE_LEGACY_WEB_AUDIO,
which was introduced by https://bugs.webkit.org/show_bug.cgi?id=97050.

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-08

  • Source/cmakeconfig.h.cmake: Add ENABLE_LEGACY_WEB_AUDIO.
2:28 AM Changeset in webkit [130625] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Test /webkit2/WebKitWebView/populate-menu asserts in debug bots
https://bugs.webkit.org/show_bug.cgi?id=98507

Reviewed by Martin Robinson.

Make sure we retain the page URL before asking for the icon.

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously): Retain the page URL before asking
for the icon, and release it if we fail to get an icon.
(processPendingIconsForPageURL): Renamed to make it clear it
receives a Sring and not a char* and moved
getIconSurfaceSynchronously() call out of the loop to call it only
once even if there are multiple requests pending.
(iconDataReadyForPageURLCallback): Do not retain the page URL
here.

2:23 AM Changeset in webkit [130624] by joone.hur@intel.com
  • 5 edits in trunk

[EFL] Add support for -webkit-sticky
https://bugs.webkit.org/show_bug.cgi?id=95182

Reviewed by Kenneth Rohde Christiansen.

Turn on CSS sticky position by default for WebKitEfl,
but most of the CSS sticky position test cases still do not pass on WK1.

.:

  • Source/cmake/OptionsEfl.cmake:

LayoutTests:

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
1:49 AM Changeset in webkit [130623] by kbalazs@webkit.org
  • 7 edits in trunk

[Qt] Reenable plugin tests
https://bugs.webkit.org/show_bug.cgi?id=98528

Reviewed by Csaba Osztrogonác.

Tools:

Uncomment this function so we can pick up the test plugin.
It was commented out because of https://bugs.webkit.org/show_bug.cgi?id=86620
and that bug seems to be fixed now.

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::initializeTestPluginDirectory):

LayoutTests:

Reenable plugin tests. Skip new failures.

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0/TestExpectations:
  • platform/qt/TestExpectations:
1:06 AM Changeset in webkit [130622] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r130619.
http://trac.webkit.org/changeset/130619
https://bugs.webkit.org/show_bug.cgi?id=98634

Causes many crashes on the EFL bots. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-08

Source/WebCore:

  • platform/RunLoop.h:

(RunLoop):

  • platform/efl/RunLoopEfl.cpp:

(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::wakeUpEvent):
(WebCore::RunLoop::wakeUp):

Source/WTF:

  • wtf/efl/MainThreadEfl.cpp:

(WTF::pipeObject):
(WTF):
(WTF::monitorDispatchFunctions):
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):

1:05 AM Changeset in webkit [130621] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitWebContext
https://bugs.webkit.org/show_bug.cgi?id=96768

Reviewed by Martin Robinson.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitDownloadClient.cpp:

(didStart):
(didReceiveResponse):
(didReceiveData):
(decideDestinationWithSuggestedFilename):
(didCreateDestination):
(didFail):
(didCancel):
(didFinish):
(attachDownloadClientToContext):

  • UIProcess/API/gtk/WebKitRequestManagerClient.cpp:

(attachRequestManagerClientToContext):

  • UIProcess/API/gtk/WebKitSecurityManager.cpp:

(registerSecurityPolicyForURIScheme):

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(_WebKitWebContextPrivate):
(createDefaultWebContext):
(webkit_web_context_set_cache_model):
(webkit_web_context_get_cache_model):
(webkit_web_context_clear_cache):
(webkit_web_context_download_uri):
(webkit_web_context_get_cookie_manager):
(webkit_web_context_get_favicon_database_directory):
(webkit_web_context_get_favicon_database):
(webkit_web_context_set_additional_plugins_directory):
(webkitWebContextGetPluginThread):
(webkit_web_context_register_uri_scheme):
(webkitWebContextGetOrCreateDownload):
(webkitWebContextRemoveDownload):
(webkitWebContextGetContext):
(webkitWebContextGetRequestManager):

  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):

12:40 AM Changeset in webkit [130620] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Support multiple window creation for MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=97884

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Implement the multiple window creation for MiniBrowser and bind the 'F9' key for opening a new window.
Also, refactored MiniBrowser codes according to EFL coding style.

  • MiniBrowser/efl/main.c:

(_Browser_Window):
(window_free):
(main_signal_exit):
(on_ecore_evas_delete):
(on_ecore_evas_resize):
(on_key_down):
(on_title_changed):
(on_url_changed):
(on_progress):
(window_create):
(main):

12:20 AM Changeset in webkit [130619] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[EFL] Use ecore_main_loop_thread_safe_call_async() to wakeup main loop.
https://bugs.webkit.org/show_bug.cgi?id=98505

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Instead of ecore_pipe_write(),
use ecore_main_loop_thread_safe_call_async() to wakeup ecore main loop.

According to the EFL API document, this function is designed to dispatch
a function on ecore main loop by avoiding dead lock or race condition.
With this function, webkit doesn't need to maintain ecore pipe also.

Source/WebCore:

No new tests. The function to wakeup main loop is changed.

  • platform/RunLoop.h:

(RunLoop):

  • platform/efl/RunLoopEfl.cpp:

(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::wakeUpEvent):
(WebCore::RunLoop::wakeUp):

Source/WTF:

  • wtf/efl/MainThreadEfl.cpp:

(WTF::monitorDispatchFunctions):
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):

Oct 7, 2012:

11:59 PM Changeset in webkit [130618] by noel.gordon@gmail.com
  • 1 edit
    6 adds in trunk/LayoutTests

Add partial load test for JPEG image
https://bugs.webkit.org/show_bug.cgi?id=98487

Reviewed by Adam Barth.

Partial load test: receive a partial number of image bytes and stall forever. The partial
image should be decoded and drawn and the green <img> background should be visible.

  • fast/images/resources/lenna.jpg: Added.
  • http/tests/images/jpeg-partial-load-expected.png: Added.
  • http/tests/images/jpeg-partial-load-expected.txt: Added.
  • http/tests/images/jpeg-partial-load.html: Added.
  • platform/chromium/http/tests/images/jpeg-partial-load-expected.png: Added.
  • platform/mac/http/tests/images/jpeg-partial-load-expected.png: Added.
11:28 PM Changeset in webkit [130617] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Add Web Inspector to EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=91718

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-10-07
Reviewed by Gyuyoung Kim.

Implementation of Web Inspector in EWebLauncher.
The Web Inspector can be opened or closed by pressing ctrl+i on web page.

  • EWebLauncher/main.c:

(on_browser_ecore_evas_resize):
(on_web_inspector_ecore_evas_resize):
(on_key_down):
(on_web_inspector_view_create):
(on_web_inspector_view_close):
(on_web_inspector_view_destroyed):
(browserCreate):
(webInspectorCreate):
(windowCreate):
(closeWindow):
(main_signal_exit):
(parseUserArguments):

9:42 PM Changeset in webkit [130616] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

:first-line pseudo selector ignoring words created from :before
https://bugs.webkit.org/show_bug.cgi?id=80794

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-10-07
Reviewed by Daniel Bates.

Source/WebCore:

The :first-line pseudo-element style is not applied for content
which is generated from the :before/:after pseudo-elements.

Test: fast/css/first-line-style-for-before-after-content.html

  • rendering/RenderObject.cpp:

(WebCore::firstLineStyleForCachedUncachedType):
Added a new static helper function incorporating the common
functionality of both uncachedFirstLineStyle() and firstLineStyleSlowCase()
functions. It also modifies the functionality to handle the
scenario when :first-line style needs to be applied on content
generated from :before/:after.

While getting the :first-line style we should also consider the case
when the content is generated from a :before/:after pseudo-element in
which case the RenderInline's parent should be considered for
obtaining the first-line style.

(WebCore):
(WebCore::RenderObject::uncachedFirstLineStyle):
(WebCore::RenderObject::firstLineStyleSlowCase):
Moved the duplicate code between the two functions to the common
helper function firstLineStyleForCachedUncachedType().

LayoutTests:

  • fast/css/first-line-style-for-before-after-content-expected.html: Added.
  • fast/css/first-line-style-for-before-after-content.html: Added.

Added ref test for verification of the scenario when :first-line style
is applied to content generated from :before/:after pseudo-elements.

9:37 PM Changeset in webkit [130615] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: The front-end should provide the position in original source file when set a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=93473

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-10-07
Reviewed by Yury Semikhatsky.

Since frontend truncates the indent, the first statement in a line must match the breakpoint (line, 0).
With this patch JSC debugger can support both normal and "Pretty Print" mode.

No new test case. This patch can be verified with cases in "LayoutTests/inspector/debugger/".

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::pauseIfNeeded):

  • bindings/js/ScriptDebugServer.h:

(ScriptDebugServer):

8:29 PM Changeset in webkit [130614] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix unused parameter compile warning.
https://bugs.webkit.org/show_bug.cgi?id=98610

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-07
Reviewed by Laszlo Gombos.

Fixed unused parameter compile warning by removing initiatingPageRef parameter name.

  • UIProcess/API/efl/ewk_context_request_manager_client.cpp:

(didReceiveURIRequest):

5:35 PM Changeset in webkit [130613] by mrobinson@webkit.org
  • 5 edits
    1 add in trunk/Source/WebCore

[Soup] Clean up ResourceError creation
https://bugs.webkit.org/show_bug.cgi?id=98521

Reviewed by Carlos Garcia Campos.

Simplify the creation of ResourcErrors in ResourceHandleSoup. This is
part of a process to make the libsoup networking backend more hackable.

No new tests. This shouldn't change functionality.

  • GNUmakefile.list.am: Added new file.
  • PlatformEfl.cmake: Added new file.
  • platform/network/soup/ResourceError.h:

(ResourceError): Added new factories.

  • platform/network/soup/ResourceErrorSoup.cpp: Added.

(WebCore::failingURI): Added this helper.
(WebCore::ResourceError::httpError): New factory.
(WebCore::ResourceError::genericIOError): Ditto.
(WebCore::ResourceError::tlsError): Ditto.
(WebCore::ResourceError::timeoutError): Ditto.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::handleUnignoredTLSErrors): Created this helper which merges
some of the logic from sendRequestCallback.
(WebCore::sendRequestCallback): Use the new helper.
(WebCore::requestTimeoutCallback): Use the new factory.

4:12 PM Changeset in webkit [130612] by benjamin@webkit.org
  • 401 edits in trunk

Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784

Patch by Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> on 2012-10-07
Reviewed by Eric Seidel.

Source/JavaScriptCore:

  • API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren):

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnNonIndexPropertyNames):

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::contextData):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::EvalCodeCache::visitAggregate):
(JSC::CodeBlock::nameForRegister):

  • bytecode/JumpTable.h:

(JSC::StringJumpTable::offsetForValue):
(JSC::StringJumpTable::ctiForValue):

  • bytecode/LazyOperandValueProfile.cpp:

(JSC::LazyOperandValueProfileParser::getIfPresent):

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::dump):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitLazyNewFunction):

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • debugger/Debugger.cpp:
  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):

  • dfg/DFGAssemblyHelpers.cpp:

(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):

  • dfg/DFGByteCodeCache.h:

(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):
(JSC::DFG::StructureCheckHoistingPhase::noticeStructureCheck):
(JSC::DFG::StructureCheckHoistingPhase::noticeClobber):

  • heap/Heap.cpp:

(JSC::Heap::markProtectedObjects):

  • heap/Heap.h:

(JSC::Heap::forEachProtectedCell):

  • heap/JITStubRoutineSet.cpp:

(JSC::JITStubRoutineSet::markSlow):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::internalAppend):

  • heap/Weak.h:

(JSC::weakRemove):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::ctiStub):

  • parser/Parser.cpp:

(JSC::::parseStrictObjectLiteral):

  • profiler/Profile.cpp:

(JSC::functionNameCountPairComparator):
(JSC::Profile::debugPrintDataSampleStyle):

  • runtime/Identifier.cpp:

(JSC::Identifier::add):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnNonIndexPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

  • runtime/JSArray.cpp:

(JSC::JSArray::setLength):

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::attemptToInterceptPutByIndexOnHoleForPrototype):
(JSC::JSObject::putByIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::getOwnPropertyDescriptor):

  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::invalidateCode):

  • runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::putEntry):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayValueMap::visitChildren):

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::clear):
(JSC::WeakGCMap::set):

  • tools/ProfileTreeNode.h:

(JSC::ProfileTreeNode::sampleChild):
(JSC::ProfileTreeNode::childCount):
(JSC::ProfileTreeNode::dumpInternal):
(JSC::ProfileTreeNode::compareEntries):

Source/WebCore:

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::Watchers::find):
(WebCore::Geolocation::Watchers::remove):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::objectStoreNames):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::metadata):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
(WebCore::IDBFactoryBackendImpl::open):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::objectStoreDeleted):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::dispatchEvent):

  • Modules/mediastream/MediaConstraintsImpl.cpp:

(WebCore::MediaConstraintsImpl::getMandatoryConstraints):
(WebCore::MediaConstraintsImpl::getMandatoryConstraintValue):

  • Modules/webdatabase/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::performOpenAndVerify):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

  • Modules/webdatabase/OriginUsageRecord.cpp:

(WebCore::OriginUsageRecord::diskUsage):

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):

  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

  • Modules/webdatabase/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):
(WebCore::QuotaTracker::updateDatabaseSize):

  • Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketExtensionDeflateFrame::processResponse):

  • Modules/websockets/WebSocketExtensionDispatcher.cpp:

(WebCore::WebSocketExtensionDispatcher::appendAcceptedExtension):

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache):

  • bindings/gobject/DOMObjectCache.cpp:

(WebKit::DOMObjectCache::clearByFrame):

  • bindings/js/DOMObjectHashTableMap.h:

(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::cacheDOMStructure):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::getDOMConstructor):

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::clearScriptObjects):

  • bindings/js/ScriptController.h:

(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::checkForDuplicate):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::GetRawTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::GetRawTemplate):
(WebCore::V8TestEventTarget::GetTemplate):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::GetRawTemplate):
(WebCore::V8TestInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetRawTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetRawTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetRawTemplate):
(WebCore::V8TestNode::GetTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::GetRawTemplate):
(WebCore::V8TestObj::GetTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::deallocate):
(WebCore::DOMWrapperWorld::ensureIsolatedWorld):

  • bindings/v8/NPV8Object.cpp:

(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::ensureIsolatedWorldContext):
(WebCore::ScriptController::existingWindowShellInternal):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8DOMMap.h:

(WebCore::WeakReferenceMap::removeIfPresent):
(WebCore::WeakReferenceMap::visit):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::dispose):

  • bindings/v8/npruntime.cpp:
  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • bridge/NP_jsobject.cpp:

(ObjectMap::add):
(ObjectMap::remove):

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::invalidate):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::counterToCSSValue):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::crossfadeChanged):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::getImage):

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::parsePseudoType):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createFontFamilyValue):
(WebCore::CSSValuePool::createFontFaceValue):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):

  • css/RuleSet.cpp:

(WebCore::reportAtomRuleMap):
(WebCore::RuleSet::addToRuleSet):
(WebCore::shrinkMapVectorsToFit):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::ruleSetForScope):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAddNamespace):
(WebCore::StyleSheetContents::determineNamespace):

  • dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationAccumulator::getOrCreate):

  • dom/Document.cpp:

(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::getCSSCanvasElement):
(WebCore::Document::cachedImmutableAttributeData):
(WebCore::Document::getCachedLocalizer):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
(WebCore::DocumentMarkerController::showMarkers):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::remove):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::pageGroupUserSheets):

  • dom/ElementAttributeData.cpp:

(WebCore::ensureAttrListForElement):

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):

  • dom/IdTargetObserverRegistry.cpp:

(WebCore::IdTargetObserverRegistry::addObserver):
(WebCore::IdTargetObserverRegistry::removeObserver):

  • dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::clearRareData):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::collectMatchingObserversForMutation):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
(WebCore::NodeListsNodeData::adoptTreeScope):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::adjustMinimumTimerInterval):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCache::add):

  • dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitStringData::create):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

  • editing/mac/AlternativeTextUIController.mm:

(WebCore::AlternativeTextUIController::AlernativeTextContextController::alternativesForContext):

  • html/FormController.cpp:

(WebCore::SavedFormState::serializeTo):
(WebCore::SavedFormState::appendControlState):
(WebCore::SavedFormState::takeControlState):
(WebCore::SavedFormState::getReferencedFilePaths):
(WebCore::FormKeyGenerator::formKey):
(WebCore::FormController::createSavedFormStateMap):
(WebCore::FormController::formElementsState):
(WebCore::FormController::takeStateForFormElement):
(WebCore::FormController::getReferencedFilePaths):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollectionCacheBase::append):

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeAttachments):

  • inspector/CodeGeneratorInspector.py:
  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):

  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptIdFor):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
(WebCore::InjectedScriptManager::releaseObjectGroup):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::commitSelector):
(WebCore::SelectorProfile::commitSelectorTime):
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::didModifyDOMAttr):
(WebCore::InspectorCSSAgent::resetPseudoStates):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::count):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::nodeForId):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::memoryBytesUsedByStorageCache):

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::databaseId):
(WebCore::InspectorDatabaseAgent::findByFileName):
(WebCore::InspectorDatabaseAgent::databaseForId):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

  • inspector/InspectorPageAgent.cpp:

(WebCore::cachedResourcesForFrame):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameDetached):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getProfile):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForHeaders):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::documentThreadableLoaderStartedLoadingForClient):
(WebCore::InspectorResourceAgent::willLoadXHR):
(WebCore::InspectorResourceAgent::replayXHR):

  • inspector/InspectorState.cpp:

(WebCore::InspectorState::getBoolean):
(WebCore::InspectorState::getString):
(WebCore::InspectorState::getLong):
(WebCore::InspectorState::getDouble):
(WebCore::InspectorState::getObject):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::styleWithProperties):
(WebCore::InspectorStyleSheet::inspectorStyleForId):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorObjectBase::get):
(WebCore::InspectorObjectBase::writeJSON):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::countObjectSize):

  • inspector/MemoryInstrumentationImpl.h:

(WebCore::MemoryInstrumentationClientImpl::totalSize):
(WebCore::MemoryInstrumentationClientImpl::reportedSizeForAllTypes):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::setXHRReplayData):
(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore::NetworkResourcesData::clear):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isSimpleCrossOriginAccessRequest):
(WebCore::createAccessControlPreflightRequest):

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::getSubresources):
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::servePendingRequests):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::removeResource):
(WebCore::ApplicationCache::clearStorageID):
(WebCore::ApplicationCache::dump):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::startLoadingEntry):
(WebCore::ApplicationCacheGroup::addEntry):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::fillResourceList):

  • loader/appcache/ApplicationCacheResource.cpp:

(WebCore::ApplicationCacheResource::estimatedSizeInStorage):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::empty):
(WebCore::ApplicationCacheStorage::storeCopyOfCache):

  • loader/archive/ArchiveFactory.cpp:

(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::canReuse):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::switchClientsToRevalidatedResource):
(WebCore::CachedResource::updateResponseAfterRevalidation):

  • loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):
(WebCore::CachedResourceLoader::removeCachedResource):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeResourcesWithOrigin):
(WebCore::MemoryCache::getOriginsWithCache):
(WebCore::MemoryCache::getStatistics):
(WebCore::MemoryCache::setDisabled):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::removeAllIcons):
(WebCore::IconDatabase::iconRecordCountWithData):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScripts):

  • page/PageGroup.cpp:

(WebCore::PageGroup::pageGroup):
(WebCore::PageGroup::closeLocalStorage):
(WebCore::PageGroup::clearLocalStorageForAllOrigins):
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore::PageGroup::syncLocalStorage):
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::urlForBlankFrame):

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

  • page/Settings.cpp:

(WebCore::setGenericFontFamilyMap):
(WebCore::getGenericFontFamilyForScript):

  • page/SpeechInput.cpp:

(WebCore::SpeechInput::registerListener):

  • page/TouchDisambiguation.cpp:

(WebCore::findGoodTouchTargets):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::boolFeature):
(WebCore::WindowFeatures::floatFeature):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::numberOfActiveAnimations):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::clearRenderer):
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):
(WebCore::CompositeAnimation::getAnimatedStyle):
(WebCore::CompositeAnimation::setAnimating):
(WebCore::CompositeAnimation::timeToNextService):
(WebCore::CompositeAnimation::getAnimationForProperty):
(WebCore::CompositeAnimation::suspendAnimations):
(WebCore::CompositeAnimation::resumeAnimations):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::CompositeAnimation::isAnimatingProperty):
(WebCore::CompositeAnimation::numberOfActiveAnimations):

  • platform/Language.cpp:

(WebCore::languageDidChange):

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

  • platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore::CookieManager::removeAllCookies):

  • platform/blackberry/CookieMap.cpp:

(WebCore::CookieMap::removeOldestCookie):
(WebCore::CookieMap::getAllChildCookies):

  • platform/cf/BinaryPropertyList.cpp:

(WebCore::BinaryPropertyListPlan::writeIntegerArray):

  • platform/chromium/support/WebHTTPLoadInfo.cpp:

(WebKit::addHeader):

  • platform/chromium/support/WebURLRequest.cpp:

(WebKit::WebURLRequest::visitHTTPHeaderFields):

  • platform/chromium/support/WebURLResponse.cpp:

(WebKit::WebURLResponse::addHTTPHeaderField):
(WebKit::WebURLResponse::visitHTTPHeaderFields):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::unregisterClient):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getVerticalData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::treeGlyphPageCount):
(WebCore::GlyphPageTreeNode::pageCount):
(WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
(WebCore::GlyphPageTreeNode::pruneTreeFontData):
(WebCore::GlyphPageTreeNode::pruneCustomFontData):
(WebCore::GlyphPageTreeNode::pruneFontData):
(WebCore::GlyphPageTreeNode::showSubtree):
(showGlyphPageTrees):

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::resizeEdgeTiles):
(WebCore::TiledBackingStore::setKeepRect):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::avfWrapperForCallbackContext):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::bindContentsTexture):

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::textureForColor):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::pauseAnimation):
(WebCore::GraphicsLayerCA::layerDidDisplay):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateTransform):
(WebCore::GraphicsLayerCA::updateChildrenTransform):
(WebCore::GraphicsLayerCA::updateMasksToBounds):
(WebCore::GraphicsLayerCA::updateContentsVisibility):
(WebCore::GraphicsLayerCA::updateContentsOpaque):
(WebCore::GraphicsLayerCA::updateBackfaceVisibility):
(WebCore::GraphicsLayerCA::updateFilters):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsRect):
(WebCore::GraphicsLayerCA::updateMaskLayer):
(WebCore::GraphicsLayerCA::updateLayerAnimations):
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::removeCAAnimationFromLayer):
(WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer):
(WebCore::GraphicsLayerCA::suspendAnimations):
(WebCore::GraphicsLayerCA::resumeAnimations):
(WebCore::GraphicsLayerCA::findOrMakeClone):
(WebCore::GraphicsLayerCA::setOpacityInternal):
(WebCore::GraphicsLayerCA::updateOpacityOnLayer):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::~TileCache):
(WebCore::TileCache::setNeedsDisplay):
(WebCore::TileCache::setScale):
(WebCore::TileCache::setAcceleratesDrawing):
(WebCore::TileCache::setTileDebugBorderWidth):
(WebCore::TileCache::setTileDebugBorderColor):
(WebCore::TileCache::revalidateTiles):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::animationStarted):
(resubmitAllAnimations):
(PlatformCALayer::animationForKey):

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::LookupAltName):
(WebCore::fontContainsCharacter):

  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:

(WebCore::getDerivedFontData):

  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::getValidatedProgram):
(WebCore::CustomFilterGlobalContext::removeValidatedProgram):

  • platform/graphics/filters/CustomFilterProgram.cpp:

(WebCore::CustomFilterProgram::notifyClients):

  • platform/graphics/harfbuzz/HarfBuzzSkia.cpp:

(WebCore::getCachedHarfbuzzFace):
(WebCore::releaseCachedHarfbuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp:

(WebCore::HarfBuzzNGFace::HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::~HarfBuzzNGFace):

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::mappedSymbolName):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):

  • platform/graphics/openvg/EGLDisplayOpenVG.cpp:

(WebCore::EGLDisplayOpenVG::~EGLDisplayOpenVG):
(WebCore::EGLDisplayOpenVG::destroySurface):
(WebCore::EGLDisplayOpenVG::contextForSurface):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

  • platform/graphics/wince/FontPlatformData.cpp:

(WebCore::FixedSizeFontData::create):

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::forClipboard):

  • platform/gtk/GtkDragAndDropHelper.cpp:

(WebCore::GtkDragAndDropHelper::handleGetDragData):
(WebCore::GtkDragAndDropHelper::handleDragLeave):
(WebCore::GtkDragAndDropHelper::handleDragMotion):
(WebCore::GtkDragAndDropHelper::handleDragDataReceived):
(WebCore::GtkDragAndDropHelper::handleDragDrop):

  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::filterXDamageEvent):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::gtkStyleChangedCallback):
(WebCore::getStyleContext):

  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):

  • platform/network/CredentialStorage.cpp:

(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::get):

  • platform/network/MIMEHeader.cpp:

(WebCore::MIMEHeader::parseHeader):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::addHTTPHeaderField):
(WebCore::ResourceRequestBase::addHTTPHeaderFields):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::targetTypeFromMimeType):
(WebCore::ResourceRequest::initializePlatformRequest):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::setClientCertificate):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::toSoupMessage):

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::toSoupMessage):

  • platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::start):

  • platform/qt/RunLoopQt.cpp:

(WebCore::RunLoop::TimerBase::timerFired):

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::scriptNameToCode):
(WebCore::localeToScriptCodeForFontSelection):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::pruneBlacklistedCodecs):
(WebCore::dumpTextEncodingNameMap):

  • platform/text/transcoder/FontTranscoder.cpp:

(WebCore::FontTranscoder::converterType):

  • platform/text/win/TextCodecWin.cpp:

(WebCore::LanguageManager::LanguageManager):
(WebCore::getCodePage):
(WebCore::TextCodecWin::registerExtendedEncodingNames):
(WebCore::TextCodecWin::registerExtendedCodecs):
(WebCore::TextCodecWin::enumerateSupportedEncodings):

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::getDataMapItem):
(WebCore::getClipboardData):
(WebCore::setClipboardData):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::types):

  • platform/win/FileSystemWin.cpp:

(WebCore::cachedStorageDirectory):

  • platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::TimerBase::timerFired):

  • platform/win/WCDataObject.cpp:

(WebCore::WCDataObject::createInstance):

  • platform/wince/MIMETypeRegistryWinCE.cpp:

(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

  • platform/wx/ContextMenuWx.cpp:

(WebCore::ContextMenu::appendItem):

  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::MIMETypeForExtension):
(WebCore::PluginDatabase::remove):

  • plugins/PluginMainThreadScheduler.cpp:

(WebCore::PluginMainThreadScheduler::scheduleCall):
(WebCore::PluginMainThreadScheduler::dispatchCalls):

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::startStream):

  • plugins/blackberry/PluginDataBlackBerry.cpp:

(WebCore::PluginData::initPlugins):

  • plugins/wx/PluginDataWx.cpp:

(WebCore::PluginData::initPlugins):

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::ensureExclusionShapeInsideInfoForRenderBlock):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::unregisterNamedFlowContentNode):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::requiresIdeographicBaseline):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::highQualityRepaintTimerFired):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::performOverlapTests):

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayerFilterInfo::filterInfoForRenderLayer):
(WebCore::RenderLayerFilterInfo::createFilterInfoForRenderLayerIfNeeded):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::RenderNamedFlowThread::pushDependencies):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::cachedCollapsedBorder):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor):

  • rendering/RenderView.cpp:

(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::setSelection):

  • rendering/RenderWidget.cpp:

(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/VerticalPositionCache.h:

(WebCore::VerticalPositionCache::get):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::characterStartsNewTextChunk):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::resourceDestroyed):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::swapItemsInLayoutAttributes):

  • rendering/svg/SVGTextLayoutAttributes.cpp:

(WebCore::SVGTextLayoutAttributes::dump):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildCharacterDataMap):
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::performImport):
(WebCore::StorageAreaSync::sync):

  • storage/StorageMap.cpp:

(WebCore::StorageMap::key):
(WebCore::StorageMap::setItem):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::localStorageNamespace):
(WebCore::StorageNamespaceImpl::copy):
(WebCore::StorageNamespaceImpl::close):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget):
(WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::effectReferences):
(WebCore::SVGFilterBuilder::addBuiltinEffects):

  • svg/properties/SVGAnimatedProperty.h:

(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):

  • svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::addProperties):
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::hasPendingActivity):

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::close):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setRequestHeaderInternal):
(WebCore::XMLHttpRequest::getAllResponseHeaders):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::createFunction):

  • xml/XPathParser.cpp:

(isAxisName):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::xsltParamArrayFromParameterMap):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTProcessor::transformToString):

Source/WebKit/blackberry:

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):

  • WebCoreSupport/NotificationPresenterImpl.cpp:

(WebCore::NotificationPresenterImpl::cancel):
(WebCore::NotificationPresenterImpl::onPermission):
(WebCore::NotificationPresenterImpl::notificationClicked):

  • WebCoreSupport/UserMediaClientImpl.cpp:

(WebCore::UserMediaClientImpl::cancelUserMediaRequest):

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):

  • WebKitSupport/FrameLayers.cpp:

(BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
(BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
(BlackBerry::WebKit::FrameLayers::calculateRootLayer):

Source/WebKit/chromium:

  • src/WebGeolocationPermissionRequestManager.cpp:

(WebGeolocationPermissionRequestManager::remove):

  • src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):

  • src/WebIntent.cpp:

(WebKit::WebIntent::extrasValue):

  • tests/MemoryInstrumentationTest.cpp:
  • tests/WebSocketExtensionDispatcherTest.cpp:

(WebCore::TEST_F):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):

  • WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::getPluginInfo):

  • ewk/ewk_intent.cpp:

(ewk_intent_extra_get):

Source/WebKit/gtk:

  • WebCoreSupport/PlatformStrategiesGtk.cpp:

(PlatformStrategiesGtk::getPluginInfo):

  • webkit/webkitfavicondatabase.cpp:

(webkitFaviconDatabaseImportFinished):

  • webkit/webkitwebplugin.cpp:

(webkit_web_plugin_get_mimetypes):

Source/WebKit/mac:

  • History/WebHistory.mm:

(-[WebHistoryPrivate removeItemFromDateCaches:]):
(-[WebHistoryPrivate orderedLastVisitedDays]):
(WebHistoryWriter::WebHistoryWriter):

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
(+[WebCoreStatistics javaScriptObjectTypeCounts]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::hostForPlugin):
(WebKit::NetscapePluginHostManager::pluginHostDied):
(WebKit::NetscapePluginHostManager::didCreateWindow):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::pluginHostDied):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
(WebKit::NetscapePluginInstanceProxy::destroy):
(WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason):
(WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodNamed):
(WebKit::ProxyInstance::fieldNamed):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView stopTimers]):
(-[WebNetscapePluginView startTimers]):

  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):

  • WebView/WebHTMLView.mm:

(commandNameForSelector):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(extractContentTypeFromPluginVector):

  • Api/qwebplugindatabase.cpp:

(QWebPluginInfo::mimeTypes):

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::getPluginInfo):

Source/WebKit/win:

  • COMPropertyBag.h:

(::Read):
(::GetPropertyInfo):

  • WebCoreStatistics.cpp:

(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::getPluginInfo):

  • WebHistory.cpp:

(WebHistory::removeItemFromDateCaches):

  • WebKitCOMAPI.cpp:

(classFactory):

  • WebKitStatistics.cpp:

(WebKitStatistics::comClassNameCounts):

  • WebNotificationCenter.cpp:

(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::removeObserver):

Source/WebKit/wince:

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::getPluginInfo):

Source/WebKit2:

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SyncMessageState::getOrCreate):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::registerEventSourceHandler):
(WorkQueue::unregisterEventSourceHandler):

  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::unregisterMachPortEventHandler):

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::pluginDestroyed):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

  • Shared/WebPreferencesStore.cpp:

(WebKit::valueForKey):
(WebKit::WebPreferencesStore::getBoolValueForKey):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::decode):

  • Shared/qt/ArgumentCodersQt.cpp:

(CoreIPC::::decode):

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::decode):

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(_Ewk_Back_Forward_List::~_Ewk_Back_Forward_List):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context::~_Ewk_Context):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_priv_loading_resources_clear):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_subresources):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseContainerForall):

  • UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _expectedPreviewCallbackForRect:]):
(pageDidDrawToPDF):
(-[WKPrintingView _drawPreview:]):

  • UIProcess/API/mac/WKView.mm:

(commandNameForSelector):
(-[WKView validateUserInterfaceItem:]):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::updateTile):
(WebKit::CoordinatedBackingStore::texture):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
(WebKit::CoordinatedBackingStore::commitTileOperations):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::LayerTreeRenderer::syncCanvas):
(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::setLayerFilters):
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::assignImageToLayer):

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests):

  • UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit::WebInspectorServer::~WebInspectorServer):
(WebKit::WebInspectorServer::registerPage):

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):

  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:

(WebKit::WebInspectorServer::buildPageList):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):

  • UIProcess/WebContext.cpp:

(WebKit::createDictionaryFromHashMap):

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::didFinishURLImport):

  • UIProcess/WebIntentData.cpp:

(WebKit::WebIntentData::extras):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
(WebKit::WebProcessProxy::addBackForwardItem):
(WebKit::WebProcessProxy::frameCountInPage):

  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:

(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::didReceiveGeolocationPermissionDecision):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):

  • WebProcess/InjectedBundle/InjectedBundleIntent.cpp:

(WebKit::InjectedBundleIntent::extras):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::removeNotificationFromContextMap):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::destroyStream):
(WebKit::NetscapePlugin::frameDidFinishLoading):
(WebKit::NetscapePlugin::frameDidFail):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::buildHTTPHeaders):
(WebKit::PluginView::~PluginView):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::layerByID):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::removeItem):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::commandNameForSelectorName):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
(WebKit::WebProcess::focusedWebPage):
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::webPageGroup):
(WebKit::fromCountedSetToHashMap):
(WebKit::WebProcess::setTextCheckerState):

Source/WTF:

Currently HashMap iterators follow the same interface in std::map: given an
iterator it, we use it->first to access the key and it->second to access the
value. This patch changes these accesses to it->key and it->value, improving the
readability at call sites.

One potential downside of this change would be the confusion between std::map and
HashMap interfaces. However, they are already different in other aspects and the
usage of std::map is more an exception than a rule in WebKit code, so we consider
the confusion will be less likely to happen.

  • wtf/HashCountedSet.h:

(WTF::::add):
(WTF::::remove):
(WTF::copyToVector):

  • wtf/HashIterators.h:

(WTF::HashTableConstKeysIterator::get):
(WTF::HashTableConstValuesIterator::get):
(WTF::HashTableKeysIterator::get):
(WTF::HashTableValuesIterator::get):

  • wtf/HashMap.h:

(WTF::KeyValuePairKeyExtractor::extract):
(WTF::HashMapValueTraits::isEmptyValue):
(WTF::HashMapTranslator::translate):
(WTF::HashMapTranslatorAdapter::translate):
(WTF::::set):
(WTF::::get):
(WTF::::take):
(WTF::operator==):
(WTF::deleteAllValues):
(WTF::deleteAllKeys):
Removed deleteAllPairFirsts() and deleteAllPairSeconds() since they are now unused.

  • wtf/HashTable.h:

(WTF::hashTableSwap):
(WTF::::checkTableConsistencyExceptSize):

  • wtf/HashTraits.h:

(WTF):
(WTF::KeyValuePair::KeyValuePair):
(KeyValuePair):
(WTF::KeyValuePairHashTraits::constructDeletedValue):
(WTF::KeyValuePairHashTraits::isDeletedValue):

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::addFreeSpace):
(WTF::MetaAllocator::incrementPageOccupancy):
(WTF::MetaAllocator::decrementPageOccupancy):

  • wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::~RefCountedLeakCounter):

  • wtf/RefPtrHashMap.h:

(WTF::::set):
(WTF::::get):
(WTF::::inlineGet):
(WTF::::take):

  • wtf/Spectrum.h:

(WTF::Spectrum::add):
(WTF::Spectrum::get):
(WTF::Spectrum::buildList):

  • wtf/ThreadingPthreads.cpp:

(WTF::identifierByPthreadHandle):

Tools:

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(MockWebSpeechInputController::addMockRecognitionResult):

  • DumpRenderTree/chromium/NotificationPresenter.cpp:

(NotificationPresenter::simulateClick):
(NotificationPresenter::show):

  • DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:

(CppBoundClass::~CppBoundClass):
(CppBoundClass::invoke):
(CppBoundClass::getProperty):
(CppBoundClass::setProperty):
(CppBoundClass::bindCallback):
(CppBoundClass::bindProperty):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(applyFontMap):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printResourceDescription):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(worldIDForWorld):
(TestRunner::evaluateScriptInIsolatedWorld):

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::~AccessibilityController):
(AccessibilityController::winNotificationReceived):

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::descriptionSuitableForTestResult):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(worldIDForWorld):
(TestRunner::evaluateScriptInIsolatedWorld):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::worldIDForWorld):
(WTR::TestRunner::evaluateScriptInIsolatedWorld):

3:56 PM Changeset in webkit [130611] by ggaren@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION (r130584): Crashes in JSC::MarkedAllocator::allocateSlowCase, failing fast/dom/gc-dom-tree-lifetime.html
https://bugs.webkit.org/show_bug.cgi?id=98612

Reviewed by Darin Adler.

Since DOM modification can happen outside of JS, calls into JS due to
DOM modification need to take the JS lock.

  • bindings/js/JSNodeCustom.cpp:

(WebCore::willCreatePossiblyOrphanedTreeByRemovalSlowCase): Take the JS
lock before doing a JS allocation, since this may be a JS entrypoint.

  • bindings/js/JSNodeCustom.h:

(WebCore::willCreatePossiblyOrphanedTreeByRemoval): Split out a slow case
to help the inliner.

3:14 PM Changeset in webkit [130610] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[chromium] Crash in WebCore::GraphicsLayerChromium::setContentsToImage
https://bugs.webkit.org/show_bug.cgi?id=98456

Patch by Nick Carter <nick@chromium.org> on 2012-10-07
Reviewed by James Robinson.

Source/WebCore:

Handle null return of nativeImageForCurrentFrame.

Test: compositing/images/truncated-direct-png-image.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):

LayoutTests:

New tests exercising a broken image on its own layer.

  • compositing/images/truncated-direct-png-image-expected.html: Added.
  • compositing/images/truncated-direct-png-image.html: Added.
3:01 PM Changeset in webkit [130609] by benjamin@webkit.org
  • 10 edits in trunk/Source

WTFURL: implement URL port removal for HTMLAnchorElement
https://bugs.webkit.org/show_bug.cgi?id=98604

Reviewed by Adam Barth.

Source/WebCore:

  • platform/KURLWTFURL.cpp:

(WebCore::KURL::hasPort):
(WebCore::KURL::removePort):
(WebCore::KURL::isHierarchical):
Implement those methods to pass the port removal test of HTMLAnchorElement.

Source/WTF:

Add hasStandardScheme() (similar to isStandard from Google URL),
hasPort() and removePort() to implement the port removal of KURL.

  • wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::hasStandardScheme):
(WTF::ParsedURL::hasPort):
(WTF::ParsedURL::removePort):

  • wtf/url/api/ParsedURL.h:

(ParsedURL):

  • wtf/url/src/URLComponent.h:

(WTF::URLComponent::move):

  • wtf/url/src/URLSegments.cpp:

(WTF::URLSegments::moveComponentsAfter):

  • wtf/url/src/URLSegments.h:

(URLSegments):

  • wtf/url/src/URLUtil.cpp:

(URLUtilities):
(WTF::URLUtilities::isStandard):

  • wtf/url/src/URLUtil.h:

(URLUtilities):
Remove LowerCaseEqualsASCII() from the interface, make it an internal template.

(WTF::URLUtilities::isStandard):
Since in WebKit, LChar is a superset of char, expose LChar and cast char* to LChar*.

12:33 PM Changeset in webkit [130608] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Web process XPC services don't have correct version information in their Info.plist files
https://bugs.webkit.org/show_bug.cgi?id=98619

Reviewed by Anders Carlsson.

  • WebProcessService/Info.plist: Added CFBundleGetInfoString, and changed

CFBundleShortVersionString and CFBundleVersion to report the source version.

  • WebProcessServiceForWebKitDevelopment/Info.plist: Ditto.
12:20 PM Changeset in webkit [130607] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark media/video-controls-rendering.html as flaky.

  • platform/efl/TestExpectations:
11:38 AM Changeset in webkit [130606] by Lucas Forschler
  • 3 edits in tags/Safari-537.13.1/Source/JavaScriptCore

Rollout r130344. <rdar://problem/12448776>

11:36 AM Changeset in webkit [130605] by rakuco@webkit.org
  • 2 edits
    62 adds in trunk/LayoutTests

[EFL] Unskip svg/W3C-SVG-1.1-SE and add expectations for it.

All pixel tests look OK (compared to the ones in mac/), and all
tests seem to pass.

  • platform/efl/TestExpectations:
  • platform/efl/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
11:34 AM Changeset in webkit [130604] by Lucas Forschler
  • 4 edits in tags/Safari-537.13.1/Source

Versioning.

11:31 AM Changeset in webkit [130603] by Lucas Forschler
  • 1 copy in tags/Safari-537.13.1

New Tag.

11:23 AM Changeset in webkit [130602] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip passing test.

  • platform/efl/TestExpectations:
11:14 AM Changeset in webkit [130601] by rakuco@webkit.org
  • 5 edits
    47 adds in trunk/LayoutTests

[EFL] Finish rebaselining the SVG tests after r130599.

  • platform/efl/TestExpectations:
  • platform/efl/svg/W3C-SVG-1.1: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-use-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Added.
  • platform/efl/svg/batik/paints/patternRegions-expected.txt:
  • platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/efl/svg/batik/text/textEffect-expected.txt: Added.
  • platform/efl/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/efl/svg/custom: Added.
  • platform/efl/svg/custom/clip-mask-negative-scale-expected.png: Added.
  • platform/efl/svg/custom/clip-mask-negative-scale-expected.txt: Added.
  • platform/efl/svg/custom/gradient-deep-referencing-expected.png: Added.
  • platform/efl/svg/custom/gradient-deep-referencing-expected.txt: Added.
  • platform/efl/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
  • platform/efl/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
  • platform/efl/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/efl/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/efl/svg/custom/radialGradient-focal-radius-expected.txt: Added.
  • platform/efl/svg/custom/recursive-gradient-expected.png: Added.
  • platform/efl/svg/custom/recursive-gradient-expected.txt: Added.
  • platform/efl/svg/custom/relative-sized-content-with-resources-expected.png: Added.
  • platform/efl/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
  • platform/efl/svg/custom/stroked-pattern-expected.png: Added.
  • platform/efl/svg/custom/stroked-pattern-expected.txt: Added.
  • platform/efl/svg/hixie/perf/006-expected.txt:
9:38 AM Changeset in webkit [130600] by dbates@webkit.org
  • 13 edits in trunk/LayoutTests

Update expected results for SVG tests on EFL, GTK, and Qt after <http://trac.webkit.org/changeset/130599>
https://bugs.webkit.org/show_bug.cgi?id=97986

  • platform/efl/svg/filters/feDisplacementMap-expected.txt:
  • platform/efl/svg/filters/filterRes-expected.txt:
  • platform/gtk/svg/custom/gradient-attr-update-expected.txt:
  • platform/gtk/svg/custom/gradient-rotated-bbox-expected.txt:
  • platform/gtk/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/gtk/svg/custom/large-bounding-box-percents-expected.txt:
  • platform/gtk/svg/filters/feDisplacementMap-expected.txt:
  • platform/gtk/svg/filters/filterRes-expected.txt:
  • platform/qt/svg/custom/gradient-attr-update-expected.txt:
  • platform/qt/svg/custom/gradient-rotated-bbox-expected.txt:
  • platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/qt/svg/custom/large-bounding-box-percents-expected.txt:
7:36 AM Changeset in webkit [130599] by krit@webkit.org
  • 47 edits
    3 adds in trunk

SVG radialGradient should support 'fr' for focal radius (just like Canvas)
https://bugs.webkit.org/show_bug.cgi?id=97986

Reviewed by Daniel Bates.

Source/WebCore:

Update SVGRadialGradient to the changed behavior in SVG2: http://www.w3.org/TR/SVG2/pservers.html#RadialGradients
SVG2 adds the focal radius for radial gradients. Color stops will start from the edge of
the focal radius.
The new specification does not limit the focal point to be inside the radial gradients radius.
This makes SVGRadialGradient consistent with the radial gradient on Canvas.

Test: svg/custom/radialGradient-focal-radius.svg

  • rendering/svg/RenderSVGResourceRadialGradient.cpp:

Remove checks for position of focal point. The focal point
can be placed every where outside the radius of the gradient now.

(WebCore::RenderSVGResourceRadialGradient::focalRadius):

Add new method to get the focal radius from SVGRadialGradientElement.

(WebCore::RenderSVGResourceRadialGradient::buildGradient):

  • rendering/svg/RenderSVGResourceRadialGradient.h:

(RenderSVGResourceRadialGradient):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGResourceContainer):

Modify DRT output to include the focal radius.

  • svg/RadialGradientAttributes.h:

(WebCore::RadialGradientAttributes::RadialGradientAttributes):
(WebCore::RadialGradientAttributes::fr):
(WebCore::RadialGradientAttributes::setFr):
(WebCore::RadialGradientAttributes::hasFr):
(RadialGradientAttributes):

New setters and getters for focal radius.

  • svg/SVGRadialGradientElement.cpp:

(WebCore):
(WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
(WebCore::SVGRadialGradientElement::isSupportedAttribute):
(WebCore::SVGRadialGradientElement::parseAttribute):
(WebCore::SVGRadialGradientElement::collectGradientAttributes):
(WebCore::SVGRadialGradientElement::selfHasRelativeLengths):

Ditto.

  • svg/SVGRadialGradientElement.h:

(SVGRadialGradientElement):

  • svg/SVGRadialGradientElement.idl:
  • svg/svgattrs.in:

Add 'fr' as new attribute to the SVG attribute list.

LayoutTests:

DRT changed the output to reflect the new added focal radius. A bunch of tests need
a rebaseline on DRT.
Added a new test for focal radius and changed behavior of focal point.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • platform/mac/svg/batik/paints/gradientLimit-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/custom/gradient-attr-update-expected.txt:
  • platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.txt:
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt:
  • platform/mac/svg/custom/large-bounding-box-percents-expected.txt:
  • platform/mac/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/mac/svg/custom/radialGradient-focal-radius-expected.txt: Added.
  • platform/mac/svg/custom/recursive-gradient-expected.txt:
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/hixie/perf/006-expected.txt:
  • svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
  • svg/custom/gradient-stroke-width-expected.txt:
  • svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
  • svg/custom/radialGradient-focal-radius.svg: Added.
7:22 AM Changeset in webkit [130598] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Use start instead of -webkit-auto in default and quirks mode stylesheets.
https://bugs.webkit.org/show_bug.cgi?id=98609

Patch by Glenn Adams <glenn@skynav.com> on 2012-10-07
Reviewed by Antti Koivisto.

Change text-align use of legacy '-webkit-auto' to 'start' in the few places where it is used
in default/quirks stylesheets.

No new tests. No change of rendering/styling behavior. No performance impact.

  • css/html.css:

(input, textarea, keygen, select, button, isindex):
(ruby > rt):

  • css/quirks.css:

(table):

7:16 AM Changeset in webkit [130597] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, rolling out r130596.
http://trac.webkit.org/changeset/130596
https://bugs.webkit.org/show_bug.cgi?id=98616

Broke build bots without IPV6 support

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-10-07

Tools:

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.is_cygwin):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_version_dir):
(Port.to.start_websocket_server):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_operating_system):
(PortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd):
(LayoutTestApacheHttpd.init):

LayoutTests:

  • http/conf/apache2-debian-httpd.conf:
  • http/conf/apache2-httpd.conf:
  • http/conf/cygwin-httpd.conf:
  • http/conf/fedora-httpd.conf:
6:19 AM Changeset in webkit [130596] by rakuco@webkit.org
  • 10 edits in trunk

webkitpy: Pass the `Listen' Apache directive from Apache, not the httpd.conf files.
https://bugs.webkit.org/show_bug.cgi?id=98602

Reviewed by Eric Seidel.

Tools:

Unify all the different `Listen' directives present in the several
httpd.conf files we have in LayoutTests/http/conf. For one, we
were already passing `Listen 127.0.0.1:8000' via webkitpy before,
and opening the other ports from the conf files.

The configuration files differed mostly in the way they handled
IPV6 ports. Some of them did not listen to IPV6 ports because the
systems which used them sometimes did not have IPV6 support. The
`http_server_supports_ipv6' method has been added to Port to
address that. cygwin, on its turn, still seems to use Apache 1.3,
which does not support IPV6 at all; the newly-added method has a
special case for that.

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.is_cygwin):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_version_dir):
(Port.to.start_websocket_server):
(Port.to):
(Port.to.http_server_supports_ipv6):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_http_server_supports_ipv6):
(PortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd):
(LayoutTestApacheHttpd.init):

LayoutTests:

  • http/conf/apache2-debian-httpd.conf: Remove the `Listen'

directive and related comments, it is passed to httpd by webkitpy
now.

  • http/conf/apache2-httpd.conf: Ditto.
  • http/conf/cygwin-httpd.conf: Ditto.
  • http/conf/fedora-httpd.conf: Ditto.
6:17 AM Changeset in webkit [130595] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip css3/masking tests added in r130592
https://bugs.webkit.org/show_bug.cgi?id=98614

Unreviewed EFL gardening.

Skip the two css3/masking ref tests added in r130592 since
they fail for EFL port and GTK port.

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-07

  • platform/efl/TestExpectations:
2:01 AM Changeset in webkit [130594] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding crash and failure expectations for regressions introduced through r130584.
Adding image mismatch expectations for two new tests introduced in r130592.

  • platform/gtk/TestExpectations:

Oct 6, 2012:

6:55 PM Changeset in webkit [130593] by tkent@chromium.org
  • 7 edits in trunk/LayoutTests

Update test expectation
https://bugs.webkit.org/show_bug.cgi?id=98479

Skip tests in fast/forms/date-multiple-fields/ because it needs
ENABLE_INPUT_MULTIPLE_FIELDS_UI.

  • platform/chromium-android/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
6:35 PM Changeset in webkit [130592] by krit@webkit.org
  • 9 edits
    8 adds in trunk

-webkit-clip-path should parse IRIs
https://bugs.webkit.org/show_bug.cgi?id=96381

Patch by Raul Hudea <rhudea@adobe.com> on 2012-10-06
Reviewed by Andreas Kling.

Source/WebCore:

Implemented the clipping via referencing a SVG clipPath. Currently it works only if the clipPath is defined
before using it on an HTML element. The forward reference issue is tracked via https://bugs.webkit.org/show_bug.cgi?id=90405.

Tests: css3/masking/clip-path-reference-userSpaceOnUse.html

css3/masking/clip-path-reference.html
fast/masking/parsing-clip-path-iri.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add handling for SVG clipPath references.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Add handling for SVG clipPath references.

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyClipPath::applyValue): Add handling for SVG references.

  • rendering/ClipPathOperation.h:

(ReferenceClipPathOperation): Added a new class corresponding to SVG referenced clipPath.
(WebCore::ReferenceClipPathOperation::create):
(WebCore::ReferenceClipPathOperation::url):
(WebCore::ReferenceClipPathOperation::fragment):
(WebCore::ReferenceClipPathOperation::operator==):
(WebCore::ReferenceClipPathOperation::ReferenceClipPathOperation):
(WebCore):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents): Add handling for ReferenceClipPathOperation.

  • rendering/svg/RenderSVGResourceClipper.h:

(RenderSVGResourceClipper): Made applyClippingToContext public as it needs to be called directly for HTML elements.

LayoutTests:

Tests for SVG referenced clipPath with both types of clipPathUnits: "userSpaceOnUse" and "objectBoundingBox".

  • css3/masking/clip-path-reference-expected.html: Added.
  • css3/masking/clip-path-reference-userSpaceOnUse-expected.html: Added.
  • css3/masking/clip-path-reference-userSpaceOnUse.html: Added.
  • css3/masking/clip-path-reference.html: Added.
  • fast/masking/parsing-clip-path-iri-expected.txt: Added.
  • fast/masking/parsing-clip-path-iri.html: Added.
  • platform/chromium/TestExpectations:
5:02 PM Changeset in webkit [130591] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Reduce calls to CGImageSourceCopyPropertiesAtIndex from frameSizeAtIndex
https://bugs.webkit.org/show_bug.cgi?id=98607

Reviewed by Dan Bernstein.

Refactor code so that we avoid a second call to CGImageSourceCopyPropertiesAtIndex under
ImageSource::frameSizeAtIndex().

No new tests because no functional change.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::orientationFromProperties):
(WebCore):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):

2:51 PM Changeset in webkit [130590] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

Stop calling -[NSSliderCell setTitle:]. It's never done anything on OS X.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::sliderThumbHorizontal):
(WebCore::RenderThemeMac::sliderThumbVertical):

1:03 PM Changeset in webkit [130589] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark media/audio-garbage-collect.html as flaky on WK2.

  • platform/efl-wk2/TestExpectations:
12:14 PM Changeset in webkit [130588] by kling@webkit.org
  • 22 edits in trunk/Source/WebCore

Clipboard::types() should return an ordered collection.
<http://webkit.org/b/98547>

Reviewed by Darin Adler.

Let Clipboard::types() return a ListHashSet<String> instead of a HashSet<String> to make sure
it retains the order in which type strings are added.

No test, this fixes an issue that was uncovered when lowering the default table size of WTF
hash tables, causing the HashSet<String> to rehash and reorder itself.

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):

  • dom/Clipboard.h:

(Clipboard):

  • platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::types):

  • platform/blackberry/ClipboardBlackBerry.h:

(ClipboardBlackBerry):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):

  • platform/chromium/ChromiumDataObject.h:

(ChromiumDataObject):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::types):

  • platform/chromium/ClipboardChromium.h:

(ClipboardChromium):

  • platform/efl/ClipboardEfl.cpp:

(WebCore::ClipboardEfl::types):

  • platform/efl/ClipboardEfl.h:

(ClipboardEfl):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::types):

  • platform/gtk/ClipboardGtk.h:

(ClipboardGtk):

  • platform/mac/ClipboardMac.h:

(ClipboardMac):

  • platform/mac/ClipboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::types):

  • platform/qt/ClipboardQt.h:

(ClipboardQt):

  • platform/win/ClipboardWin.cpp:

(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):

  • platform/win/ClipboardWin.h:

(ClipboardWin):

  • platform/wx/ClipboardWx.cpp:

(WebCore::ClipboardWx::types):

  • platform/wx/ClipboardWx.h:

(ClipboardWx):

11:51 AM Changeset in webkit [130587] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

If Node X is reachable from JavaScript, all Nodes in the same tree should be kept alive
https://bugs.webkit.org/show_bug.cgi?id=88834

Reviewed by Gavin Barraclough.

Follow-up patch to address some comments by Darin Adler.

  • bindings/js/JSNodeCustom.h:

(WebCore::willCreatePossiblyOrphanedTreeByRemoval): Save some space by
collapsing comment lines. Use Node::hasChildNodes() for brevity.

11:44 AM Changeset in webkit [130586] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix weird use of KURL's protocolIs
https://bugs.webkit.org/show_bug.cgi?id=98584

Reviewed by Adam Barth.

Converting a KURL to string is a bad idea.

Invalid URLs can return a string that pass the tests, while an
invalid URL will fail protocolIs().

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::removeClient):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::load):

  • platform/network/DataURL.cpp:

(WebCore::handleDataURL):

11:37 AM Changeset in webkit [130585] by mitz@apple.com
  • 11 edits in trunk/Source

Source/WebCore: WebCore part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
https://bugs.webkit.org/show_bug.cgi?id=98601

Reviewed by Darin Adler.

  • WebCore.exp.in: Exported Font::setDefaultTypesettingFeatures().
  • platform/graphics/Font.cpp:

(WebCore::Font::s_defaultTypesettingFeatures): Defined this static.
(WebCore::Font::setDefaultTypesettingFeatures): Added this setter.
(WebCore::Font::defaultTypesettingFeatures): Added this getter.

  • platform/graphics/Font.h:

(WebCore::Font::typesettingFeatures): Changed to use the value of the new static member
s_defaultTypesettingFeatures, rather than 0, if text-redering is set to auto.

Source/WebKit/mac: WebKit/mac part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
https://bugs.webkit.org/show_bug.cgi?id=98601

Reviewed by Darin Adler.

  • WebView/WebView.mm:

(+[WebView initialize]): Added a call to Font::setDefaultTypesettingFeatures() to enable
kerning and ligatures if the WebKitKerningAndLigaturesEnabledByDefault user default key has
the value YES.

Source/WebKit2: WebKit2 part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
https://bugs.webkit.org/show_bug.cgi?id=98601

Reviewed by Darin Adler.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Added initializer for
to shouldEnableKerningAndLigaturesByDefault. The initial value is false.
(WebKit::WebProcessCreationParameters::encode): Added encoding of
shouldEnableKerningAndLigaturesByDefault.
(WebKit::WebProcessCreationParameters::decode): Added decoding of
shouldEnableKerningAndLigaturesByDefault.

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters): Added shouldEnableKerningAndLigaturesByDefault boolean
member variable.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess): Changed to set
shouldEnableKerningAndLigaturesByDefault in the process creation parameters according to
the value of the WebKitKerningAndLigaturesEnabledByDefault user defaults key.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Added a call to
Font::setDefaultTypesettingFeatures() to enable kerning and ligatures if requested in the
process creation parameters.

11:27 AM Changeset in webkit [130584] by ggaren@apple.com
  • 10 edits
    4 adds in trunk

If Node X is reachable from JavaScript, all Nodes in the same tree should be kept alive
https://bugs.webkit.org/show_bug.cgi?id=88834

Reviewed by Gavin Barraclough.

Source/WebCore:

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isObservable): Clarified this comment, since it seems to have
misled some folks.

  • bindings/js/JSNodeCustom.h:

(WebCore::willCreatePossiblyOrphanedTreeByRemoval): New helper function
to ensure that a disconnected tree is visible to JavaScript.

  • bindings/js/ScriptState.cpp:

(WebCore::mainWorldScriptState): Need to check for null because a document's
frame can be null.

  • dom/ContainerNode.cpp:

(WebCore::dispatchChildRemovalEvents): When we remove a subtree from the
document, we sever the reference that JavaScript previously held by
referencing its root. So, we give JavaScript an opportunity to establish
a reference to the new root.

LayoutTests:

  • fast/dom/gc-12-expected.txt: Added.
  • fast/dom/gc-12.html: Added. Test case matches an example cited by

Kentaro Hara <haraken@chromium.org> in bugzilla.

  • fast/dom/gc-3-expected.txt:
  • fast/dom/gc-3.html:
  • fast/dom/gc-5-expected.txt:
  • fast/dom/gc-5.html: Updated these tests to reflect new expected behavior.

We've decided that disconnected trees should persist in memory. This risks
a programmer accidentally retaining more memory than expected, but it
also makes the API more obvious.

  • fast/dom/gc-dom-tree-lifetime-expected.txt: Added.
  • fast/dom/gc-dom-tree-lifetime.html: Added. Test case written by

Kentaro Hara <haraken@chromium.org>.

9:55 AM Changeset in webkit [130583] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening.

Skip fast/selectors/unqualified-hover-strict.html because it seems
to be flaky.

While here, correct its pixel expectation and fix its
svn:mime-type property.

  • platform/efl/fast/selectors/unqualified-hover-strict-expected.png: Modified property svn:mime-type.
3:35 AM Changeset in webkit [130582] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix build warning : -Wunused-parameter.
https://bugs.webkit.org/show_bug.cgi?id=98583

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-06
Reviewed by Kentaro Hara.

Use ASSERT_UNUSED() macro to remove build warning.

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::delayDeliveryTimerFired):
(WebCore::PluginStream::didReceiveResponse):
(WebCore::PluginStream::didReceiveData):
(WebCore::PluginStream::didFail):
(WebCore::PluginStream::didFinishLoading):

  • plugins/PluginView.cpp:

(WebCore::PluginView::requestTimerFired):
(WebCore::PluginView::invalidateTimerFired):

2:26 AM Changeset in webkit [130581] by loislo@chromium.org
  • 5 edits in trunk/Source

Web Inspector: NMI fix String instrumentation the way it was discussed in WK97964
https://bugs.webkit.org/show_bug.cgi?id=98500

Reviewed by Benjamin Poulain.

Current instrumentation incorrectly covers the case when StringImpl object has been created via StringImpl::createWithTerminatingNullCharacter().
Looks like the only way to detect the strings that has been created from literals is to compare the addresses of buffer and stringImpl + 1.

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

Source/WTF:

  • wtf/MemoryInstrumentationString.h:

(WTF::reportMemoryUsage):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::hasInternalBuffer):

2:03 AM Changeset in webkit [130580] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=98590

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06

  • platform/efl/TestExpectations: Skip

fast/writing-mode/vertical-subst-font-vert-no-dflt.html after r130570.

  • platform/efl/http/tests/misc/acid3-expected.txt: Update baselines

after r130555.

2:01 AM Changeset in webkit [130579] by commit-queue@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

[EFL] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=98576

Unreviewed EFL gardening.

Add platform-specific baselines after r130443 and r130489.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06

  • platform/efl/TestExpectations:
  • platform/efl/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
  • platform/efl/fast/repaint/box-shadow-inset-repaint-expected.txt: Added.
  • platform/efl/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
  • platform/efl/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
1:58 AM Changeset in webkit [130578] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

[EFL] Gardening of the WK2 Debug Bot failing tests
https://bugs.webkit.org/show_bug.cgi?id=98575

Unreviewed EFL gardening.

Skip failing tests in order to make the bots green.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/fast/replaced/object-with-embed-url-param-expected.txt: Removed. Current results

matches the base expectations on WK2.

1:08 AM Changeset in webkit [130577] by benjamin@webkit.org
  • 3 edits in trunk/Source/WTF

Fix build of WTFURL after r130187
https://bugs.webkit.org/show_bug.cgi?id=98588

Reviewed by Kentaro Hara.

  • wtf/MemoryInstrumentationParsedURL.h:

(WTF::reportMemoryUsage):

  • wtf/url/api/ParsedURL.h:

(WTF::ParsedURL::spec):

Oct 5, 2012:

11:46 PM Changeset in webkit [130576] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding reftest failure expectations for a couple of tests that
were introduced in r130557 and r130570.

  • platform/gtk/TestExpectations:
11:20 PM Changeset in webkit [130575] by tkent@chromium.org
  • 65 edits
    19 adds in trunk/LayoutTests

[Chromium] Rebaseline for recent INPUT_MULTIPLE_FIELDS_UI changes

  • platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium/TestExpectations:
7:08 PM Changeset in webkit [130574] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] toV8(Node*, ...) does more work than needed (6% faster on dom-traverse)
https://bugs.webkit.org/show_bug.cgi?id=98567

Reviewed by Kentaro Hara.

This patch introduces toV8Fast for Node*. This function works a
differently from the existing toV8 function in two ways:

1) It uses the inline wrapper cache in Node to determine if we're

executing in the main world. This is faster both in the case when
isolated worlds exist because we don't need to retrieve any state
for the current context.

2) It doesn't attempt to inline the hash table lookup used to find the

wrapper in the isolated world. There isn't a big need to inline this
code since performance in the isolated world case is dominated by
the hash table lookup.

Because of these two changes, toV8Fast is small enough to inline into
each attribute getter profitably. Over time, I would like to convert
all the performance critical uses of toV8(Node*) to toV8Fast. At that
point, we can delete toV8 and rename toV8Slow to toV8.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):

6:28 PM Changeset in webkit [130573] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[mac] REGRESSION (r122215): Animated GIF outside the viewport doesn't play when scrolled into view.
https://bugs.webkit.org/show_bug.cgi?id=94874

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-05
Reviewed by Simon Fraser.

Rollback previous patch because this patch caused two problems.

  1. GIF animation is occasionally paused when tiled scrolling is enabled.
  2. This change regressed Apple's Membuster benchmark by ~20% (80MB.)
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::shouldPauseAnimation):

  • loader/cache/CachedImage.h:

(CachedImage):

  • loader/cache/CachedResource.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::pruneLiveResourcesToSize):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willRenderImage):

6:23 PM Changeset in webkit [130572] by Simon Fraser
  • 2 edits in trunk/Tools

Attempt to fix the SnowLeopard build to making the implementation of
-isPaginated come before its use.

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController reload:]):
(-[WK1BrowserWindowController forceRepaint:]):
(-[WK1BrowserWindowController goBack:]):
(-[WK1BrowserWindowController goForward:]):
(-[WK1BrowserWindowController isPaginated]):

6:09 PM Changeset in webkit [130571] by Simon Fraser
  • 6 edits
    3 copies
    1 add in trunk/Tools

Provide a way to run WebKit1
https://bugs.webkit.org/show_bug.cgi?id=98568

Reviewed by Tim Horton.

Make it possible to create both WebKit1 and WebKit2 windows in MiniBrowser.

Turn BrowserWindowController into a base class; subclassed by
WK1BrowserWindowController and WK2BrowserWindowController, each of
which implement the BrowserController protocol.

Use Command-N to get a WebKit1 window, and Command-Option-N to
get a WK2 window. Also add "Open Location" to focus the URL bar,
and code to add an http:// if missing.

Hook up window title callbacks; append " [WK1/2]" to window title
as appropriate.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController initWithWindow:]):
(-[BrowserWindowController windowDidLoad]):
(-[BrowserWindowController openLocation:]):
(-[BrowserWindowController loadURLString:]):
(-[BrowserWindowController applicationTerminating]):
(-[BrowserWindowController addProtocolIfNecessary:]):

  • MiniBrowser/mac/MainMenu.xib:
  • MiniBrowser/mac/WK1BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.

(WebView):

  • MiniBrowser/mac/WK1BrowserWindowController.m: Added.

(-[WK1BrowserWindowController awakeFromNib]):
(-[WK1BrowserWindowController dealloc]):
(-[WK1BrowserWindowController loadURLString:]):
(-[WK1BrowserWindowController fetch:]):
(-[WK1BrowserWindowController showHideWebView:]):
(-[WK1BrowserWindowController removeReinsertWebView:]):
(-[WK1BrowserWindowController validateMenuItem:]):
(-[WK1BrowserWindowController reload:]):
(-[WK1BrowserWindowController forceRepaint:]):
(-[WK1BrowserWindowController goBack:]):
(-[WK1BrowserWindowController goForward:]):
(-[WK1BrowserWindowController validateUserInterfaceItem:]):
(-[WK1BrowserWindowController validateToolbar]):
(-[WK1BrowserWindowController windowShouldClose:]):
(-[WK1BrowserWindowController windowWillClose:]):
(-[WK1BrowserWindowController applicationTerminating]):
(-[WK1BrowserWindowController currentZoomFactor]):
(-[WK1BrowserWindowController canZoomIn]):
(-[WK1BrowserWindowController zoomIn:]):
(-[WK1BrowserWindowController canZoomOut]):
(-[WK1BrowserWindowController zoomOut:]):
(-[WK1BrowserWindowController canResetZoom]):
(-[WK1BrowserWindowController resetZoom:]):
(-[WK1BrowserWindowController toggleZoomMode:]):
(-[WK1BrowserWindowController isPaginated]):
(-[WK1BrowserWindowController togglePaginationMode:]):
(-[WK1BrowserWindowController find:]):
(-[WK1BrowserWindowController dumpSourceToConsole:]):
(-[WK1BrowserWindowController webView:didStartProvisionalLoadForFrame:]):
(-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):

  • MiniBrowser/mac/WK2BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
  • MiniBrowser/mac/WK2BrowserWindowController.m: Copied from Tools/MiniBrowser/mac/BrowserWindowController.m.

(-[WK2BrowserWindowController initWithContext:pageGroup:]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController fetch:]):
(-[WK2BrowserWindowController showHideWebView:]):
(-[WK2BrowserWindowController removeReinsertWebView:]):
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController reload:]):
(-[WK2BrowserWindowController forceRepaint:]):
(-[WK2BrowserWindowController goBack:]):
(-[WK2BrowserWindowController goForward:]):
(-[WK2BrowserWindowController validateUserInterfaceItem:]):
(-[WK2BrowserWindowController validateToolbar]):
(-[WK2BrowserWindowController windowShouldClose:]):
(-[WK2BrowserWindowController windowWillClose:]):
(-[WK2BrowserWindowController applicationTerminating]):
(-[WK2BrowserWindowController currentZoomFactor]):
(-[WK2BrowserWindowController setCurrentZoomFactor:]):
(-[WK2BrowserWindowController canZoomIn]):
(-[WK2BrowserWindowController zoomIn:]):
(-[WK2BrowserWindowController canZoomOut]):
(-[WK2BrowserWindowController zoomOut:]):
(-[WK2BrowserWindowController canResetZoom]):
(-[WK2BrowserWindowController resetZoom:]):
(-[WK2BrowserWindowController toggleZoomMode:]):
(-[WK2BrowserWindowController isPaginated]):
(-[WK2BrowserWindowController togglePaginationMode:]):
(-[WK2BrowserWindowController dumpSourceToConsole:]):
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishDocumentLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didSameDocumentNavigationForFrame):
(didReceiveTitleForFrame):
(didFirstLayoutForFrame):
(didFirstVisuallyNonEmptyLayoutForFrame):
(didRemoveFrameFromHierarchy):
(didDisplayInsecureContentForFrame):
(didRunInsecureContentForFrame):
(didDetectXSSForFrame):
(didStartProgress):
(didChangeProgress):
(didFinishProgress):
(didBecomeUnresponsive):
(didBecomeResponsive):
(processDidExit):
(didChangeBackForwardList):
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(decidePolicyForResponse):
(createNewPage):
(showPage):
(closePage):
(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(setStatusText):
(mouseDidMoveOverElement):
(getWindowFrame):
(setWindowFrame):
(runBeforeUnloadConfirmPanel):
(runOpenPanel):
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController didStartProgress]):
(-[WK2BrowserWindowController didChangeProgress:]):
(-[WK2BrowserWindowController didFinishProgress]):
(-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
(-[WK2BrowserWindowController didStartProvisionalLoadForFrame:]):
(-[WK2BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
(-[WK2BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
(-[WK2BrowserWindowController didFailLoadWithErrorForFrame:]):
(-[WK2BrowserWindowController didSameDocumentNavigationForFrame:]):
(-[WK2BrowserWindowController didCommitLoadForFrame:]):
(-[WK2BrowserWindowController loadURLString:]):
(-[WK2BrowserWindowController performFindPanelAction:]):
(-[WK2BrowserWindowController find:]):

5:38 PM Changeset in webkit [130570] by wangxianzhu@chromium.org
  • 5 edits
    2 adds in trunk

OpenTypeVerticalData issue with DroidSansFallback.ttf on chromium-android and chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=97824

Reviewed by Tony Chang.

Source/WebCore:

The issue occurred when a font that contains vert GSUB table but doesn't have
a DFLT script and the first script doesn't have vert feature. Added logic to
handle the case.

Test: fast/writing-mode/vertical-subst-font-vert-no-dflt.html

  • platform/graphics/opentype/OpenTypeVerticalData.cpp:

(FeatureList):
(WebCore::OpenType::FeatureList::findFeature): Added to find the matching feature in FeatureList.
(WebCore::OpenType::GSUBTable::feature): Added logic to handle the case of no DFLT script and no vert feature under the first script.

LayoutTests:

Ref test for the change. The punctuations in the vertical text are expected to
be substituted with the corresponding vertical forms.

  • fast/writing-mode/vertical-subst-font-vert-no-dflt-expected.html: Added.
  • fast/writing-mode/vertical-subst-font-vert-no-dflt.html: Added.
  • platform/mac/TestExpectations: Added the new test as it fails on Mac because of https://bugs.webkit.org/show_bug.cgi?id=98560.
4:57 PM Changeset in webkit [130569] by tony@chromium.org
  • 10 edits
    2 adds
    23 deletes in trunk

Form controls should always be horizontal
https://bugs.webkit.org/show_bug.cgi?id=98563

Reviewed by Ojan Vafai.

Source/WebCore:

Fix a regression where we didn't force form controls to be horizontal.

Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html

fast/dom/HTMLProgressElement/progress-writing-mode.html
fast/table/colspanMinWidth-vertical.html

  • css/html.css:

(input, textarea, keygen, select, button, isindex, meter, progress):

LayoutTests:

Convert fast/dom/HTMLMeterElement/meter-writing-mode.html and
fast/dom/HTMLProgressElement/progress-writing-mode.html to be ref tests.
Also rebaseline fast/table/colspanMinWidth-vertical.html and mark the
test as needing a rebaseline on platforms other than Chromium Linux.

  • fast/dom/HTMLMeterElement/meter-writing-mode-expected.html: Added.
  • fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
  • fast/dom/HTMLProgressElement/progress-writing-mode-expected.html: Added.
  • fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
  • fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
  • platform/efl/TestExpectations:
  • platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
  • platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
  • platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/qt/TestExpectations:
  • platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
4:42 PM Changeset in webkit [130568] by commit-queue@webkit.org
  • 12 edits in trunk

[WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads
https://bugs.webkit.org/show_bug.cgi?id=98524

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-05
Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Add implementation for testRunner.setSerializeHTTPLoads in
WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetSerialLoadingEnabled):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setSerialLoadingEnabled):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Add implementation for testRunner.setSerializeHTTPLoads in
WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setSerializeHTTPLoads):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskip tests that are now passing.

  • platform/wk2/TestExpectations:
4:28 PM Changeset in webkit [130567] by commit-queue@webkit.org
  • 30 edits
    1 delete in trunk

Unreviewed, rolling out r130556 and r130564.
http://trac.webkit.org/changeset/130556
http://trac.webkit.org/changeset/130564
https://bugs.webkit.org/show_bug.cgi?id=98572

The patch wasn't reviewed by a reviewer and it is breaking
Chromium Windows (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-05

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • css/mediaControls.css:

(video::-webkit-media-text-track-container):
(video::-webkit-media-text-track-past-nodes):
(video::-webkit-media-text-track-future-nodes):
(video::-webkit-media-text-track-display):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::attach):
(WebCore::HTMLMediaElement::userIsInterestedInThisLanguage):
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
(WebCore::HTMLMediaElement::updateClosedCaptionsControls):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/shadow/MediaControlElements.cpp:

(WebCore):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):

  • html/shadow/MediaControlElements.h:

(MediaControlTextTrackContainerElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::updateTextTrackDisplay):

  • html/shadow/MediaControlRootElement.h:

(MediaControlRootElement):

  • html/shadow/MediaControls.h:

(MediaControls):

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::isValidKindKeyword):
(WebCore::TextTrack::setKind):
(WebCore::TextTrack::setMode):
(WebCore::TextTrack::mode):

  • html/track/TextTrack.h:

(WebCore::TextTrack::create):
(WebCore::TextTrack::kind):
(TextTrack):
(WebCore::TextTrack::label):
(WebCore::TextTrack::setLabel):
(WebCore::TextTrack::language):
(WebCore::TextTrack::setLanguage):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCueBox::shadowPseudoId):
(WebCore):
(WebCore::TextTrackCue::updateDisplayTree):

  • html/track/TextTrackCue.h:

(TextTrackCueBox):
(TextTrackCue):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • rendering/CaptionPreferencesChangedListener.h: Removed.
  • rendering/RenderTheme.h:

(WebCore):
(RenderTheme):

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore):
(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::~RenderThemeMac):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries:

  • WebKitSystemInterface.h:

LayoutTests:

  • media/track/track-cue-rendering-expected.txt:
  • media/track/track-cue-rendering.html:
  • platform/chromium/TestExpectations:
3:59 PM Changeset in webkit [130566] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Set the current working directory to TMPDIR when entering the sandbox in the plug-in process.
Based on a patch by Ivan Krstić.

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:

(enterSandbox):

3:56 PM Changeset in webkit [130565] by timothy_horton@apple.com
  • 9 edits in trunk/Source

[cg] GraphicsContextCG should ask CG whether the shadow offset workaround is required
https://bugs.webkit.org/show_bug.cgi?id=98565
<rdar://problem/12436468>

Reviewed by Simon Fraser.

On Mountain Lion and above, CG can tell us whether we need to work around incorrect
shadow offsets. Prior to Mountain Lion, we should assume we need to apply the workaround.

No new tests, as this requires an obscure configuration to test.

  • WebCore.exp.in:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::applyShadowOffsetWorkaroundIfNeeded):
(WebCore::GraphicsContext::setPlatformShadow):

  • platform/mac/WebCoreSystemInterface.h: Add wkCGContextDrawsWithCorrectShadowOffsets.
  • platform/mac/WebCoreSystemInterface.mm: Add wkCGContextDrawsWithCorrectShadowOffsets.

Add wkCGContextDrawsWithCorrectShadowOffsets.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

3:53 PM Changeset in webkit [130564] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the build.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::captionsWindowColor):

3:30 PM Changeset in webkit [130563] by timothy_horton@apple.com
  • 5 edits in trunk/WebKitLibraries

Update WebKitSystemInterface libraries and header.

Reviewed by Simon Fraser.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:30 PM Changeset in webkit [130562] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

TestResultsServer does not display sync_integration_tests results
https://bugs.webkit.org/show_bug.cgi?id=98551

Patch by Richard Larocque <rlarocque@chromium.org> on 2012-10-05
Reviewed by Ojan Vafai.

Allow builders whose name contains "Sync" to pass through the
isChromiumWebkitDepsTestRunner filter.

The test expectations in flakiness_dashboard_unittests.js have been
updated to match the new behaviour.

  • TestResultServer/static-dashboards/builders.js:

(isChromiumDepsGTestRunner):

3:13 PM Changeset in webkit [130561] by jchaffraix@webkit.org
  • 2 edits
    8 adds
    4 deletes in trunk/LayoutTests

Unreviewed Chromium gardening.

  • platform/chromium/TestExpectations:

Updated a wrong bug info and rebaselined 2 tests:
fast/reflections/inline-crash.html and fast/backgrounds/solid-color-context-restore.html

  • fast/backgrounds/solid-color-context-restore-expected.txt: Added.
  • fast/reflections/inline-crash-expected.txt: Added.
  • platform/chromium-linux/fast/backgrounds/solid-color-context-restore-expected.png: Added.
  • platform/chromium-linux/fast/reflections/inline-crash-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/solid-color-context-restore-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/solid-color-context-restore-expected.txt: Added.
  • platform/chromium-win/fast/reflections/inline-crash-expected.png: Added.
  • platform/chromium-win/fast/reflections/inline-crash-expected.txt: Added.
  • platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt: Removed.
  • platform/efl/fast/reflections/inline-crash-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt: Removed.
  • platform/gtk/fast/reflections/inline-crash-expected.txt: Removed.
3:09 PM Changeset in webkit [130560] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove needless virtual calls and inline RenderStyle::logical* to make table layout faster
https://bugs.webkit.org/show_bug.cgi?id=98550

Reviewed by Andreas Kling.

This shaved another 5% (100ms) off of the runtime of resizecol.html microbenchmark:
http://www.robohornet.org/tests/resizecol.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
3:08 PM Changeset in webkit [130559] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Tests in webkitpy involving child processes are flaky.
Skipping run_webkit_tests_integrationtest.py.
https://bugs.webkit.org/show_bug.cgi?id=98559

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_verbose_in_child_processes):

3:05 PM Changeset in webkit [130558] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Only define SK_SUPPORT_HINTING_SCALE_FACTOR when building for chromeOS
https://bugs.webkit.org/show_bug.cgi?id=98526

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-10-05
Reviewed by Stephen White.

This is causing some problems with picture serialization between chrome
and the mainline skia tools. (Once this change lands and is gardened in,
I will make the corresponding change in chromium/skia/skia.gyp)

  • features.gypi:
3:01 PM Changeset in webkit [130557] by commit-queue@webkit.org
  • 1 edit
    2 moves
    8 adds in trunk/LayoutTests

[CSS Exclusions] Add shape-inside tests for rounded rectangles
https://bugs.webkit.org/show_bug.cgi?id=96669

Patch by Bear Travis <betravis@adobe.com> on 2012-10-05
Reviewed by Levi Weintraub.

Adding multiple rounded rectangle tests. The more complex tests use float "sandbags"
to simulate the shape-inside area in the test expectations.
(See http://www.alistapart.com/articles/sandbags/)
In general, each line has its own pair of left and right floats (both lineHeight tall),
to position the text and appropriately limit its width. In the simple, 0 corner radius
cases, these floats can be merged because they all have the same width on the left and
right.

  • fast/exclusions/resources/rounded-rectangle.js: Contains functionality for generating

a shape-inside, simulating one, and generating content that should roughly fill the
shape-inside.
(xFromEllipseCenter): The x distance from the center of an ellipse, based on its y
distance from center.
(xInset): The inset of a rounded rectangle from its bounding box.
(generateString): Generate a string that roughly fills a shape-inside's content area.
(simulateShape): Create floats to simulate a shape-inside area.
(simulateShapeOutline): Create an outline for the rounded rectangle shape-inside.
(generateSimulatedShapeElement): Simulate a shape-inside and appropriately fill it
with content.
(generateShapeElement): Create a shape-inside and fill it with content.

  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-001-expected.html:

Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-rounded-rectangle-expected.html.

  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-001.html:

Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-rounded-rectangle.html.

  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html: Added.
2:57 PM Changeset in webkit [130556] by jer.noble@apple.com
  • 30 edits
    1 add in trunk

Allow ports to override text track rendering style
https://bugs.webkit.org/show_bug.cgi?id=97800
<rdar://problem/12044964>

Patch by Eric Carlson <eric.carlson@apple.com> on 2012-10-04
Reviewed by Silvia Pfeiffer.

Source/WebCore:

  • WebCore.exp.in: Export new WebkitSystemInterface functions.
  • WebCore.xcodeproj/project.pbxproj: Add CaptionPreferencesChangedListener.h.
  • css/mediaControls.css: Rearrange the caption CSS so it is possible to style the cue window,

background, and text independently.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_disableCaptions with theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::attach): Register for caption preferences change callbacks.
(WebCore::HTMLMediaElement::detach): Unregister for caption preferences change callbacks.
(WebCore::HTMLMediaElement::userPrefersCaptions): Return theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Consider userPrefersCaptions().
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Move the code that marks all tracks as

un-configured to markCaptionAndSubtitleTracksAsUnconfigured so it can be reused.

(WebCore::HTMLMediaElement::captionPreferencesChanged): New, force a reevaluation of all text tracks.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): New, code moved from

setClosedCaptionsVisible

  • html/HTMLMediaElement.h: Inherit from CaptionPreferencesChangedListener.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::userCaptionPreferencesChanged): New, if theme

has a captions style sheet override, inject it into the current page group, otherwise
remove injected sheet.

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Get rid of unnecessary member

variable. Get caption font scale from theme instead of hard coding.

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::userCaptionPreferencesChanged): New.
(WebCore::MediaControlRootElement::updateTextTrackDisplay):

  • html/shadow/MediaControlRootElement.h: Add userCaptionPreferencesChanged, minor cleanup.
  • html/shadow/MediaControls.h:

(WebCore::MediaControls::userCaptionPreferencesChanged): New.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox): Set the shadow pseudo id.
(WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId): New, class method to return the

shadow pseudo id so it can be used elsewhere.

(WebCore::TextTrackCueBox::shadowPseudoId): Call textTrackCueBoxShadowPseudoId.
(WebCore::TextTrackCue::pastNodesShadowPseudoId): New, class method to return the

shadow pseudo id so it can be used elsewhere.

(WebCore::TextTrackCue::futureNodesShadowPseudoId): Ditto.
(WebCore::TextTrackCue::updateDisplayTree):

  • html/track/TextTrackCue.h:
  • platform/mac/WebCoreSystemInterface.h: Updated.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • rendering/CaptionPreferencesChangedListener.h: Added.
  • rendering/RenderTheme.h:

(WebCore::RenderTheme::userPrefersCaptions): New, default do-nothing implementation.
(WebCore::RenderTheme::userHasCaptionPreferences): Ditto.
(WebCore::RenderTheme::captionFontSizeScale): Ditto.
(WebCore::RenderTheme::captionsStyleSheetOverride): Ditto.
(WebCore::RenderTheme::registerForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::RenderTheme::unregisterForCaptionPreferencesChangedCallbacks): Ditto.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::userCaptionPreferencesChangedNotificationCallback): New, receives preference changed notifications.
(WebCore::RenderThemeMac::RenderThemeMac): Initialize m_listeningForCaptionPreferenceNotifications.
(WebCore::RenderThemeMac::~RenderThemeMac): Unregister for notifications if necessary.
(WebCore::RenderThemeMac::userHasCaptionPreferences): New, passthrough to WKSI function.
(WebCore::RenderThemeMac::userPrefersCaptions): Ditto.
(WebCore::RenderThemeMac::captionsWindowColor): Return Color with user's caption window color preference.
(WebCore::RenderThemeMac::captionsBackgroundColor): Return Color with user's caption

background color preference.

(WebCore::RenderThemeMac::captionsTextColor): Return Color with user's caption text color preference.
(WebCore::RenderThemeMac::captionsEdgeColorForTextColor): Return Color for text edge effect.
(WebCore::RenderThemeMac::cssPropertyWithTextEdgeColor): Return String with CSS to set a text-shadow

or webkit-text-stroke property.

(WebCore::RenderThemeMac::cssColorProperty): Return a String with css to set a property

with a color value.

(WebCore::RenderThemeMac::captionsTextEdgeStyle): Return a String with css to style caption

text with the user's preferred text edge stye.

(WebCore::RenderThemeMac::captionsDefaultFont): Return a String with css to style caption

text with the user's preferred font.

(WebCore::RenderThemeMac::captionsStyleSheetOverride): Return a String with css to style captions

with the user's preferred style.

(WebCore::RenderThemeMac::captionFontSizeScale): Return the user's preferred caption font scale.
(WebCore::RenderThemeMac::captionPreferencesChanged): Notify listeners of caption preference change.
(WebCore::RenderThemeMac::registerForCaptionPreferencesChangedCallbacks): Add a caption preferences

changes listener.

(WebCore::RenderThemeMac::unregisterForCaptionPreferencesChangedCallbacks): Remove a caption preferences

changes listener.

Source/WebKit/mac:

Add WCSI support for new WKSI caption functions.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize new WKSI function pointers.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize new WKSI function pointers.

WebKitLibraries:

Update WKSI header with SPI for getting the user caption appearance preferences.

  • WebKitSystemInterface.h:

LayoutTests:

  • media/track/track-cue-rendering-expected.txt: Update results for caption css changes.
  • media/track/track-cue-rendering.html:
  • platform/chromium/TestExpectations: Skip tests that need to be rebaselined.
2:54 PM Changeset in webkit [130555] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

Inline continuations create :after generated content on style recalcs
https://bugs.webkit.org/show_bug.cgi?id=93170

Patch by Takashi Sakamoto <tasak@google.com> on 2012-10-05
Reviewed by Abhishek Arya.

Source/WebCore:

The bug is caused by RenderInline::styleDidChange's setContinuation(0).
RenderObjectChildList uses continuation to know whether the given
renderer should have AFTER render object or not.
However, setContinuation(0) makes RenderObjectChildList to
misunderstand that all continuations are last continuation.
To avoid the misunderstanding, added a new flag to class
RenderObejctChildList to enable/disable updating :after content (and
also :before content).

Tests: fast/css-generated-content/after-with-inline-continuation.html

fast/css-generated-content/dynamic-apply-after-for-inline.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::styleDidChange):
Disable upating :after content for continuations which are not
the last one during setStyle just after setContinuation(0).
The setStyle invokes RenderInline::styleDidChange and also invokes
updateBeforeAfterContent via the styleDidChange. This means,
the last continuation's updateBeforeAfterContent is also invoked
after setContinuation(0). We have to update :after for the last
continuation.

  • rendering/RenderObjectChildList.cpp:

(WebCore):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
If s_updateBeforeAfterContent is false, quickly exit
updateBeforeAfterContent.

  • rendering/RenderObjectChildList.h:

(RenderObjectChildList):
Added a new flag s_enableUpdateBeforeAfterContent to enable/disable
updating :before or :after content.

LayoutTests:

  • fast/css-generated-content/after-with-inline-continuation-expected.html: Added.
  • fast/css-generated-content/after-with-inline-continuation.html: Added.
  • fast/css-generated-content/dynamic-apply-after-for-inline-expected.html: Added.
  • fast/css-generated-content/dynamic-apply-after-for-inline.html: Added.
  • http/tests/misc/acid3-expected.txt:

The acid3-expected.txt has the duplicate RenderBlock (positioned).
Two 'layer at(638, 18) size 20x20, ... text run at (0,0) width 20: "X"'
exist. So did reset-results for acid3-expected.txt.

2:51 PM Changeset in webkit [130554] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Don't assume that TileCache layers are opaque
https://bugs.webkit.org/show_bug.cgi?id=98555

Reviewed by Dean Jackson.

TileCache previously set all its tile CALayers as opaque.
However, we will need non-opaque tile caches when we use this
tile cache for tiled layers, so add a member function to
control tile opacity.

RenderLayerBacking already calls m_graphicsLayer->setContentsOpaque()
using the FrameView's notion of opaqueness, so this change will
cause the main tile cache to be non-opaque if external forces have
set the FrameView to be non-opaque.

Also tweak the layer border widths on tiled layers.

  • platform/graphics/ca/mac/TileCache.h:

(TileCache):
(WebCore::TileCache::tilesAreOpaque):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):
(WebCore::TileCache::setTilesOpaque):
(WebCore::TileCache::createTileLayer):

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer setOpaque:]):
(-[WebTileCacheLayer isOpaque]):
(-[WebTileCacheLayer setBorderWidth:]):

2:39 PM Changeset in webkit [130553] by tony@chromium.org
  • 5 edits in trunk

Fix margin box ascent computation in flexbox
https://bugs.webkit.org/show_bug.cgi?id=98540

Reviewed by Ojan Vafai.

Source/WebCore:

The margin box ascent doesn't depend on the margin below the box.

Tests: css3/flexbox/flex-align.html: Fixed a test case and removed a FIXME.

css3/flexbox/flex-align-vertical-writing-mode.html: Similar test case.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::marginBoxAscentForChild):

LayoutTests:

Remove a FIXME and update the results.

  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
2:38 PM Changeset in webkit [130552] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed.

Disable WebFrameTest.DivScrollIntoEditableTest. The test depends on
some code that is conditionally compiled and therefore fails in some
configurations.

  • tests/WebFrameTest.cpp:
2:22 PM Changeset in webkit [130551] by wjmaclean@chromium.org
  • 4 edits
    1 move
    14 adds
    2 deletes in trunk

[chromium] Enhance support for transforms in LinkHighlight.
https://bugs.webkit.org/show_bug.cgi?id=94355

Reviewed by Adrienne Walker.

Improved handling of transformed highlight targets, where the transform goes beyond simple translation.

Source/WebKit/chromium:

  • src/LinkHighlight.cpp:

(WebKit::convertTargetSpaceQuadToCompositedLayer): Converts target space quad to composited layer coordinates.
(WebKit):
(WebKit::addQuadToPath): Supports adding non-rectilinear quads to Path.
(WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Updated to deal with target's quadlist, transform individual quads according to transforms.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::bestTouchLinkNode):

LayoutTests:

  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line.html: Added.
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div.html: Added.
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link.html: Added.
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX.html: Added.
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY.html: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.png: Removed.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.txt: Removed.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.txt: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div-expected.txt: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link-expected.txt: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX-expected.txt: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY-expected.txt: Added.
2:13 PM Changeset in webkit [130550] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed build fix after r130545.

  • tests/WebFrameTest.cpp:

Avoid a warning about truncating the double constant on Windows. While touching the variable, changed
it to be proper camelCase.

2:12 PM Changeset in webkit [130549] by ojan@chromium.org
  • 5 edits
    2 adds in trunk

Deprecated flexboxes subtract scrollbar width/height twice
https://bugs.webkit.org/show_bug.cgi?id=98552

Reviewed by Tony Chang.

Source/WebCore:

This is a regression from http://trac.webkit.org/changeset/119507.
The problem is that contentHeight subtracts the scrollbar and
RenderDeprecatedFlexbox subtracts the scrollbar.

-Make it so that we only access override sizes if one has been set.
I think this makes the calling code more clear.
-If we don't have one set, grab the height/width - borderAndPadding.
-Add a FIXME to change this all back to being borderbox sizes.
There's something trick with making table padding/border work right for that
though (noted in the original patch).

Test: fast/flexbox/flexing-overflow-scroll-item.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::overrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::contentWidthForChild):
(WebCore):
(WebCore::contentHeightForChild):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

LayoutTests:

  • fast/flexbox/flexing-overflow-scroll-item-expected.txt: Added.
  • fast/flexbox/flexing-overflow-scroll-item.html: Added.
1:47 PM Changeset in webkit [130548] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

Make tables which don't use col/row span much faster to layout
https://bugs.webkit.org/show_bug.cgi?id=98221

Reviewed by Julien Chaffraix.

My sense is that most tables on webpages do not use colspan/rowspan
so I stole another bit from RenderTableCell::m_column to avoid
having to re-parse the colSpan/rowSpan attributes for every cell
when doing table layout.
This made these symbols disappear from biggrid.html/redraw.html (dglazkov's spreadsheets benchmarks)
as well as moved our robohornet/resizecol.html number from an average of 3221ms to 2608ms (~20%!).

I removed m_hasHTMLTableCellElement (from http://trac.webkit.org/changeset/97691)
since it was attempting to do the same sort of optimization.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):
(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):
(WebCore::RenderTableCell::layout):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
(RenderTableCell):

1:45 PM Changeset in webkit [130547] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source

Source/WebCore: Allow EventHandler to handle longpress gestures, including longpress selection on Android.
https://bugs.webkit.org/show_bug.cgi?id=98173

Patch by Oli Lan <olilan@chromium.org> on 2012-10-05
Reviewed by Ryosuke Niwa.

Adds handling for GestureLongPress to EventHandler::handleGestureEvent, with a new
handleGestureLongPress method. On Android, this method selects the closest word
if the gesture event was over non-link text.

This is tested via a new chromium test WebViewTest.LongPressSelection.

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectClosestWordFromHitTestResult):
(WebCore::EventHandler::selectClosestWordFromMouseEvent):
(WebCore):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureLongPress):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium: Allow EventHandler to handle longpress gestures, including longpress selection on Android.
https://bugs.webkit.org/show_bug.cgi?id=98173

Patch by Oli Lan <olilan@chromium.org> on 2012-10-05
Reviewed by Ryosuke Niwa.

This patch changes the longpress gesture handling code in WebViewImpl to call EventHandler::handleGestureEvent.
The WebCore part of this patch adds longpress handling to that method, including the long press selection behaviour
required for Android. This means that a long press gesture performed on word (that is not part of a link)
selects the word, without generating a context menu event.

A new test, WebViewTest.LongPressSelection has been added to test this.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebViewImpl):

  • tests/WebViewTest.cpp:
  • tests/data/longpress_selection.html: Added.
1:33 PM Changeset in webkit [130546] by rniwa@webkit.org
  • 5 edits
    22 deletes in trunk/LayoutTests

GTK+ and Qt rebaselines after r130532.

  • platform/chromium-linux-x86/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/chromium-linux-x86/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-linux-x86/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/chromium-win-xp/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/chromium-win-xp/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-win-xp/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/chromium/svg/custom/delete-text-crash-expected.txt: Removed.
  • platform/chromium/svg/custom/delete-text-innerText-crash-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/gtk/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt: Removed.
1:30 PM Changeset in webkit [130545] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Support zooming focused node for mobile devices
https://bugs.webkit.org/show_bug.cgi?id=97958

Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-10-05
Reviewed by Adam Barth.

This unforks the Android version of scrollFocusedNodeIntoRect().A new setting
autoZoomFocusedNodeToLegibleScale was added to turn it on, since not all
platforms with ENABLE(GESTURE_EVENTS) want this.

Test: WebFrameTest.DivScrollIntoEditableTest

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setAutoZoomFocusedNodeToLegibleScale):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::autoZoomFocusedNodeToLegibleScale):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):

  • tests/WebFrameTest.cpp:
  • tests/data/get_scale_for_zoom_into_editable_test.html: Added.
1:25 PM Changeset in webkit [130544] by rniwa@webkit.org
  • 10 edits
    11 adds in trunk/LayoutTests

Chromium and Mac rebaselines after r130532.

  • platform/chromium-linux-x86/editing/pasteboard/interchange-newline-1-expected.txt: Added.
  • platform/chromium-linux-x86/editing/pasteboard/paste-text-002-expected.txt: Added.
  • platform/chromium-linux-x86/editing/pasteboard/paste-text-003-expected.txt: Added.
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.txt: Added.
  • platform/chromium-linux/editing/pasteboard/paste-text-002-expected.txt: Added.
  • platform/chromium-linux/editing/pasteboard/paste-text-003-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt:
  • platform/chromium-win-xp/editing/pasteboard/interchange-newline-1-expected.txt: Added.
  • platform/chromium-win-xp/editing/pasteboard/paste-text-002-expected.txt: Added.
  • platform/chromium-win-xp/editing/pasteboard/paste-text-003-expected.txt: Added.
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt:
  • platform/chromium/svg/custom/delete-text-crash-expected.txt: Added.
  • platform/chromium/svg/custom/delete-text-innerText-crash-expected.txt: Added.
  • svg/custom/delete-text-crash-expected.txt:
  • svg/custom/delete-text-innerText-crash-expected.txt:
12:55 PM Changeset in webkit [130543] by zandobersek@gmail.com
  • 5 edits in trunk

[Gtk] fast/xsl/xslt-missing-namespace-in-xslt.xml is failing on the 64-bit Debug builder
https://bugs.webkit.org/show_bug.cgi?id=91009

Reviewed by Martin Robinson.

Tools:

Include libxml2 into the jhbuild module. Version 2.8.0 introduces
a more correct (but not completely correct) behavior in the
fast/xsl/xslt-missing-namespace-in-xslt.html test.

  • gtk/jhbuild.modules:

LayoutTests:

Update the test's baselines. The output now properly shows the error.

  • platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.png:
  • platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
12:46 PM Changeset in webkit [130542] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Fix lint error in TestExpectations from previous change.

Unreviewed.

  • platform/chromium/TestExpectations:
12:19 PM Changeset in webkit [130541] by commit-queue@webkit.org
  • 3 edits
    1 add
    15 deletes in trunk

<marquee> element forces itself to be at least 1em high, regardless of 'height' declaration
https://bugs.webkit.org/show_bug.cgi?id=18098

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-05
Reviewed by Eric Seidel.

This restriction originally existed to match IE, but IE changed some time ago to be normal instead.
We're the last browser, afaict, to still enforce this de-facto restriction.
This patch makes <marquee> instead act like a normal element.

Tests: fast/css/MarqueeLayoutTest.html (rewritten from the older, bad version)

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::updateMarqueeStyle):

12:18 PM Changeset in webkit [130540] by dpranke@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

[chromium] tests failing after r130443.
https://bugs.webkit.org/show_bug.cgi?id=98545

Unreviewed, expectations change.

[chromium] fast/text/international/text-spliced-font.html and
fast/writing-mode/Kusa-Makura-background-canvas.html are failing on
the Mac after r130443 and we're not quite sure why ...

  • platform/chromium-linux/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
  • platform/chromium-mac/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
  • platform/chromium-mac/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
  • platform/chromium-win/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
  • platform/chromium-win/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
  • platform/chromium/TestExpectations:
12:05 PM Changeset in webkit [130539] by wjmaclean@chromium.org
  • 6 edits
    2 copies
    4 adds in trunk

[chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and animate on GestureTapCancel.
https://bugs.webkit.org/show_bug.cgi?id=97355

Reviewed by Adrienne Walker.

This patch revises the behaviour of GestureTapDown highlighting so that the highlight should disappear if
interrupted by GestureTap, and animate away if interrupted by GestureTapCancel.

Source/WebKit/chromium:

  • src/LinkHighlight.cpp:

(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimationIfNeeded):

  • src/LinkHighlight.h:

(LinkHighlight):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::enableTouchHighlight):

LayoutTests:

  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel.html: removed extra testRunner.display().
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2.html: Added.
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress.html: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.txt: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress-expected.txt: Added.
12:01 PM Changeset in webkit [130538] by rwlbuis@webkit.org
  • 6 edits in trunk

[BlackBerry] Implement TestRunner.setMockDeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=98542

Reviewed by Antonio Gomes.

PR 120681

Source/WebKit/blackberry:

Provide framework for mock device motion.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(toDeviceOrientationClientMock):
(DumpRenderTreeSupport::setMockDeviceOrientation):

  • WebKitSupport/DumpRenderTreeSupport.h:

(DumpRenderTreeSupport):

Tools:

This fixes tests in fast/dom/DeviceOrientation.

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::setMockDeviceOrientation):

11:50 AM Changeset in webkit [130537] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fix regression in proxy auth
https://bugs.webkit.org/show_bug.cgi?id=98533

Patch by Joe Mason <jmason@rim.com> on 2012-10-05
Reviewed by Yong Li.

The proxy auth dialog gets the proxy address from
BlackBerry::Platform::Settings::proxyAddress, which returns
"host:port", but we try to parse it with a KURL, which expects
"scheme://host:port". Since this is an http proxy, add http:// to the
url to get it to parse.

PR 220567.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

11:41 AM Changeset in webkit [130536] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98527

Unreviewed gardening after r129479.

  • platform/mac-wk2/TestExpectations:
11:35 AM Changeset in webkit [130535] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing failure expectation for fast/text/vertical-rl-rtl-linebreak.html
since the test only needed platform-specific baselines (which were added
in r130524).

  • platform/gtk/TestExpectations:
11:34 AM Changeset in webkit [130534] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

No autorelease pool in place, causing buildup of autoreleased objects.
https://bugs.webkit.org/show_bug.cgi?id=98522
<rdar://problem/11647950>

Reviewed by Alexey Proskuryakov.

Wrap each timer callback in an AutodrainPool, ensuring an autorelease
pool is present during calls from C/C++ into ObjC.

  • platform/cf/RunLoopTimerCF.cpp:

(WebCore::timerFired):

11:32 AM Changeset in webkit [130533] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Have perf test assert worst order of magnitude
https://bugs.webkit.org/show_bug.cgi?id=98535

Reviewed by Tony Chang.

Really we only care if tests get order of magnitude slower.
Assert that tests are at least a certain magnitude.
Hopefully this will reduce flakiness some.

  • resources/magnitude-perf.js:

(Magnitude._run):

11:26 AM Changeset in webkit [130532] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

Deleting across multiple paragraphs can change the style of surrounding text
https://bugs.webkit.org/show_bug.cgi?id=97266

Reviewed by Levi Weintraub.

Source/WebCore:

Preserve editing styles from CSS rules in wrappingStyleForSerialization as well as inline styles
even when we're not annotating. We don't want to preserve all styles because it's against
the user expectation to keep borders, etc... when merging paragraphs. We also don't want to copy
styles from a mail blockquote because that's not a style the user has applied. See the comment
in EditingStyle::wrappingStyleForSerialization.

Test: editing/deleting/merge-paragraph-with-style-from-rule.html

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
(WebCore::EditingStyle::wrappingStyleForSerialization):

LayoutTests:

Added a regression test and rebaselined tests.

  • editing/deleting/delete-before-block-image-2-expected.txt:
  • editing/deleting/merge-paragraph-from-p-with-style-expected.txt:
  • editing/deleting/merge-paragraph-from-p-with-style.html: We changed the behavior. The editing style of p

is now preserved when merging paragraphs.

  • editing/deleting/merge-paragraph-with-style-from-rule-expected.txt: Added.
  • editing/deleting/merge-paragraph-with-style-from-rule.html: Added.
  • platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
11:18 AM Changeset in webkit [130531] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

Reversing a GlyphBuffer needlessly queries its size multiple times
https://bugs.webkit.org/show_bug.cgi?id=98530

Reviewed by Simon Fraser.

No new tests because there is no change in behavior.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::getGlyphsAndAdvancesForSimpleText): Replaced the condition
(i < glyphBuffer.size() / 2) with the equivalent test (i < end).

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::getGlyphsAndAdvancesForComplexText): Ditto.

11:09 AM Changeset in webkit [130530] by pilgrim@chromium.org
  • 42 edits in trunk/Source/WebKit/chromium

[Chromium] Update some more #includes for Platform/ directory
https://bugs.webkit.org/show_bug.cgi?id=98534

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

  • src/WebFormElement.cpp:
  • src/WebFrameImpl.cpp:
  • src/WebGeolocationClientMock.cpp:
  • src/WebGeolocationError.cpp:
  • src/WebGeolocationPermissionRequest.cpp:
  • src/WebHistoryItem.cpp:
  • src/WebHitTestResult.cpp:
  • src/WebIDBTransactionImpl.h:
  • src/WebIconLoadingCompletionImpl.h:
  • src/WebImageDecoder.cpp:
  • src/WebImageSkia.cpp:
  • src/WebInputElement.cpp:
  • src/WebKit.cpp:
  • src/WebLabelElement.cpp:
  • src/WebMediaStreamRegistry.cpp:
  • src/WebNode.cpp:
  • src/WebNotification.cpp:
  • src/WebOptionElement.cpp:
  • src/WebPageSerializer.cpp:
  • src/WebPageSerializerImpl.cpp:
  • src/WebPageSerializerImpl.h:
  • src/WebPluginListBuilderImpl.cpp:
  • src/WebPluginLoadObserver.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebRange.cpp:
  • src/WebRegularExpression.cpp:
  • src/WebScriptController.cpp:
  • src/WebSecurityOrigin.cpp:
  • src/WebSecurityPolicy.cpp:
  • src/WebSelectElement.cpp:
  • src/WebSerializedScriptValue.cpp:
  • src/WebSessionDescriptionDescriptor.cpp:
  • src/WebSettingsImpl.cpp:
  • src/WebSocketImpl.cpp:
  • src/WebSocketImpl.h:
  • src/WebStorageEventDispatcherImpl.cpp:
  • src/WebSurroundingText.cpp:
  • src/WebURLLoadTiming.cpp:
  • src/WorkerAsyncFileWriterChromium.cpp:
  • src/WorkerFileSystemCallbacksBridge.cpp:
11:08 AM Changeset in webkit [130529] by jchaffraix@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed rebaseline after r130355.

r130447 forgot to update the Snow Leopard pixel baselines. The only differences are due to a different font used.

  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
11:03 AM Changeset in webkit [130528] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Add expected result accidentally left out of http://trac.webkit.org/changeset/130337.

  • perf/adding-radio-buttons-expected.txt:
10:57 AM Changeset in webkit [130527] by kpiascik@rim.com
  • 1 edit
    1 delete in trunk/Source/WebKit/blackberry

[BlackBerry] Remove unnecessary html file.
https://bugs.webkit.org/show_bug.cgi?id=98531

Reviewed by Yong Li.

We now just use Source/WebCore/inspector/front-end/inspector.html
instead.

  • WebCoreSupport/inspectorBB.html: Removed.
10:56 AM Changeset in webkit [130526] by kareng@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/rendering/RenderLayer.cpp

Merge 130322 - [Sub-pixel layout] incorrect rendering when painting sub-layers as their own root
https://bugs.webkit.org/show_bug.cgi?id=97484

Reviewed by Eric Seidel.

When in compositing mode, layer painting can be triggered through the backing store. When this
happens, a non-top-level RenderLayer is called to paint as its own root. Normally, we attempt to preserve
the proper sub-pixel accumulation through layers to their children, but since we're not
starting with the top-level layer, we haven't properly accumulated one, and convertToLayerCoords,
another source of correctly getting the sub-pixel offset for a layer, also avoids crawling
past the listed root layer.

When painting a root layer, we're aligned to the surface we're painting to, so we round our
offset to avoid moving objects around.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/11031075

10:54 AM Changeset in webkit [130525] by mrobinson@webkit.org
  • 25 edits
    3 adds in trunk

[GTK] Add support for creating EGL contexts
https://bugs.webkit.org/show_bug.cgi?id=77921

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-10-05
Reviewed by Martin Robinson.

This patch adds support for EGL, using OpenGL and OpenGL ES 2. Both
options are set up on compile time, with the configure options
--enable-egl and --enable-gles2.

The implementation only adds support for EGL on top of X11, to
isolate the changes to the minimum. More changes should come
later to enable EGL for other targets (as Wayland).

.:

  • GNUmakefile.am:
  • configure.ac: new configure options --enable-egl and --enable-gles2.

Source/WebCore:

No new tests required, as existing WebGL and AC tests should cover
the cases.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):

  • platform/graphics/OpenGLESShims.h:
  • platform/graphics/cairo/GLContext.cpp:

(WebCore):
(WebCore::GLContext::sharedX11Display):
(WebCore::GLContext::cleanupSharedX11Display):
(WebCore::activeContextList):
(WebCore::GLContext::addActiveContext):
(WebCore::GLContext::removeActiveContext):
(WebCore::GLContext::cleanupActiveContextsAtExit):
(WebCore::GLContext::createContextForWindow):
(WebCore::GLContext::createOffscreenContext):

  • platform/graphics/cairo/GLContext.h:

(GLContext):

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/clutter/GraphicsContext3DClutter.cpp:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:
  • platform/graphics/egl/GLContextEGL.cpp: Added.

(WebCore):
(WebCore::sharedEGLDisplay):
(WebCore::getEGLConfig):
(WebCore::GLContextEGL::createWindowContext):
(WebCore::GLContextEGL::createPbufferContext):
(WebCore::GLContextEGL::createPixmapContext):
(WebCore::GLContextEGL::createContext):
(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::~GLContextEGL):
(WebCore::GLContextEGL::canRenderToDefaultFramebuffer):
(WebCore::GLContextEGL::defaultFrameBufferSize):
(WebCore::GLContextEGL::makeContextCurrent):
(WebCore::GLContextEGL::swapBuffers):
(WebCore::GLContextEGL::waitNative):
(WebCore::GLContextEGL::platformContext):

  • platform/graphics/egl/GLContextEGL.h: Added.

(WebCore):
(GLContextEGL):

  • platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::createWindowContext):
(WebCore::GLContextGLX::createPbufferContext):
(WebCore::GLContextGLX::createPixmapContext):
(WebCore::GLContextGLX::createContext):
(WebCore::GLContextGLX::~GLContextGLX):
(WebCore::GLContextGLX::defaultFrameBufferSize):
(WebCore::GLContextGLX::makeContextCurrent):
(WebCore::GLContextGLX::swapBuffers):
(WebCore):
(WebCore::GLContextGLX::waitNative):

  • platform/graphics/glx/GLContextGLX.h:

(GLContextGLX):

  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::renderbufferStorage):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/texmap/TextureMapper.h:
  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::~RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::resize):

  • platform/gtk/RedirectedXCompositeWindow.h:

Source/WebKit2:

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
10:53 AM Changeset in webkit [130524] by zandobersek@gmail.com
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Adding platform-specific baselines after r130443 and r130489.

  • platform/gtk/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
  • platform/gtk/fast/repaint/box-shadow-inset-repaint-expected.txt: Added.
  • platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
  • platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
10:53 AM Changeset in webkit [130523] by jonlee@apple.com
  • 13 edits in trunk/Source

Add a setting to enable plugin snapshotting
https://bugs.webkit.org/show_bug.cgi?id=98319
<rdar://problem/12426480>

Reviewed by Brady Eidson.

Source/WebCore:

Add a new bit for this preference.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Preference is false by default.

  • page/Settings.h: Added m_plugInSnapshottingEnabled bit.

(WebCore::Settings::setPlugInSnapshottingEnabled): Set the bit.
(WebCore::Settings::plugInSnapshottingEnabled): Return the bit.

Source/WebKit/mac:

Expose plugInSnapshottingEnabled preference to WebKit clients.

  • WebView/WebPreferenceKeysPrivate.h: Add WebKitPlugInSnapshottingEnabled key.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Setting is turned off by default.
(-[WebPreferences plugInSnapshottingEnabled]):
(-[WebPreferences setPlugInSnapshottingEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Update settings based on preference.

Source/WebKit2:

Expose plugInSnapshottingEnabled preference to WebKit clients.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPlugInSnapshottingEnabled):
(WKPreferencesGetPlugInSnapshottingEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Update preference based on store.

10:39 AM Changeset in webkit [130522] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=98256

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implement UIClient's focus callbacks for the main page in
WebKitTestRunner.

  • WebKitTestRunner/TestController.cpp:

(WTR::focus):
(WTR::TestController::initialize):

LayoutTests:

Unskip fast/dom/Window/mozilla-focus-blur.html now that
WebKitTestRunner implements UIClient's focus callbacks.

  • platform/efl-wk2/TestExpectations:
10:38 AM Changeset in webkit [130521] by rniwa@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove wrong expectations added in r130452.

  • platform/chromium-win-xp/editing/pasteboard/5006779-expected.png: Removed.
  • platform/chromium-win-xp/editing/pasteboard/5006779-expected.txt: Removed.
10:35 AM Changeset in webkit [130520] by mhahnenberg@apple.com
  • 15 edits
    2 adds in trunk

JSC should have a way to gather and log Heap memory use and pause times
https://bugs.webkit.org/show_bug.cgi?id=98431

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

In order to improve our infrastructure for benchmark-driven development, we should
have a centralized method of gathering and logging various statistics about the state
of the JS heap. This would allow us to create and to use other tools to analyze the
output of the VM after running various workloads.

The first two statistics that might be interesting is memory use by JSC and GC pause
times. We can control whether this recording happens through the use of the Options
class, allowing us to either use environment variables or command line flags.

(JSC::Heap::collect): If we finish a collection and are still over our set GC heap size,
we end the program immediately and report an error. Also added recording of pause times.

  • heap/Heap.h:

(Heap):
(JSC::Heap::shouldCollect): When we set a specific GC heap size through Options, we
ignore all other heuristics on when we should collect and instead only ask if we're
greater than the amount specified in the Option value. This allows us to view time/memory
tradeoffs more clearly.

  • heap/HeapStatistics.cpp: Added.

(JSC):
(JSC::HeapStatistics::initialize):
(JSC::HeapStatistics::recordGCPauseTime):
(JSC::HeapStatistics::logStatistics):
(JSC::HeapStatistics::exitWithFailure):
(JSC::HeapStatistics::reportSuccess):
(JSC::HeapStatistics::parseMemoryAmount):
(StorageStatistics):
(JSC::StorageStatistics::StorageStatistics):
(JSC::StorageStatistics::operator()):
(JSC::StorageStatistics::objectWithOutOfLineStorageCount):
(JSC::StorageStatistics::objectCount):
(JSC::StorageStatistics::storageSize):
(JSC::StorageStatistics::storageCapacity):
(JSC::HeapStatistics::showObjectStatistics): Moved the old showHeapStatistics (renamed to showObjectStatistics)
to try to start collecting our various memory statistics gathering/reporting mechanisms scattered throughout the
codebase into one place.

  • heap/HeapStatistics.h: Added.

(JSC):
(HeapStatistics):

  • jsc.cpp:

(main):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce): We need to initialize our data structures for recording
statistics if necessary.

  • runtime/Options.cpp: Add new Options for the various types of statistics we'll be gathering.

(JSC::parse):
(JSC):
(JSC::Options::initialize): Initialize the various new options using environment variables.
(JSC::Options::dumpOption):

  • runtime/Options.h:

(JSC):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(main): Added a check as to whether we should dump our JSC Heap statistics on exit.

9:51 AM Changeset in webkit [130519] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Plugins are completely broken with a custom device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=98518

Reviewed by Kenneth Rohde Christiansen.

Implement painting with scale factor in ShareableBitmap.
The backing store of the plugin are still overscaled in MiniBrowser
with this patch but this is only the effect of the fake device scale
factor defined in qml (1.5). We should probably remove it on desktop.

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::paint):

9:37 AM Changeset in webkit [130518] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed inspector front-end closure compilaiton fixes.

  • inspector/InjectedScriptCanvasModuleSource.js:
  • inspector/InjectedScriptExterns.js:

(InjectedScriptHost.prototype.getInternalProperties):

  • inspector/front-end/DockController.js:
  • inspector/front-end/externs.js:

(InspectorFrontendHostAPI.prototype.requestSetDockSide):

9:30 AM Changeset in webkit [130517] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Fix mktemp() compilation warning in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98493

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.

Fix wrong mktemp usage causing a compilation warning
in MiniBrowser.

  • MiniBrowser/efl/main.c:

(on_download_request):

9:28 AM Changeset in webkit [130516] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Replace uses of prefixed properties with unprefixed versions in the UA stylesheets
https://bugs.webkit.org/show_bug.cgi?id=98453

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-05
Reviewed by Ojan Vafai.

Switched 'border-radius' and 'box-shadow' to their unprefixed version in the UA stylesheets.

No new tests, because the unprefixed properties have the same behavior as the prefixed.

  • css/fullscreenQuickTime.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):

  • css/html.css:

(keygen, select):
(select[size][multiple]):
(select[size="1"]):
(::-webkit-validation-bubble-message):

  • css/themeBlackBerry.css:

(input, textarea):

  • css/themeChromiumAndroid.css:

(select[size][multiple]):

  • css/themeQtNoListboxes.css:

(select[size][multiple]):

  • css/themeWin.css:

(select[size="1"]):

  • css/view-source.css:

(.webkit-html-message-bubble):

9:16 AM Changeset in webkit [130515] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][WKTR] Avoid duplication of UIClient callbacks for main page and other pages
https://bugs.webkit.org/show_bug.cgi?id=98503

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.

Avoid the need for duplicating UIClient callbacks for main page
and other pages by passing the view as clientInfo
for those callbacks.

Previously, callbacks for the main page were passed the
TestController as clientInfo while the callbacks for other pages
were passed the PlatformWebView as clientInfo. This was error prone
and leads to useless code duplication.

  • WebKitTestRunner/TestController.cpp:

(WTR::getWindowFrame):
(WTR::setWindowFrame):
(WTR::runBeforeUnloadConfirmPanel):
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
(WTR::TestController::decidePolicyForNotificationPermissionRequest):

9:16 AM Changeset in webkit [130514] by abarth@webkit.org
  • 1 edit
    2 copies in branches/chromium/1271

Merge 130313 - Crash when calling document.open during unload
https://bugs.webkit.org/show_bug.cgi?id=98287

Reviewed by Nate Chapin.

Source/WebCore:

Calling document.open results in us nulling out m_documentLoader. This
code doesn't properly handle that case and crashes.

Test: fast/parser/document-open-in-unload.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

LayoutTests:

Test that we don't crash when calling document.open during the unload event.

  • fast/parser/document-open-in-unload-expected.txt: Added.
  • fast/parser/document-open-in-unload.html: Added.

TBR=abarth@webkit.org
Review URL: https://codereview.chromium.org/11026067

9:15 AM Changeset in webkit [130513] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[chromium] Only inflate the height of rows in a popup menu when a touch device is detected.
https://bugs.webkit.org/show_bug.cgi?id=98515

Patch by Kevin Ellis <kevers@chromium.org> on 2012-10-05
Reviewed by Adam Barth.

Enforces a minimum row height for popup menus when a touch device is
detected. In a previous patch (r127597), the sizing of popup was
consolidated for touch and non-touch. Based on user feedback, reverting
to the old behavior for non-touch and only adding padding for touch
devices seems like a much safer strategy. This patch is not a direct
revert of r127567 since the padding previously used for touch is a bit
excessive.

Covered by existing tests.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore):

  • platform/chromium/PopupMenuChromium.h:

(WebCore::PopupMenuChromium::optionRowHeightForTouch):
(WebCore::PopupMenuChromium::setOptionRowHeightForTouch):
(PopupMenuChromium):

9:13 AM Changeset in webkit [130512] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Unskip fullscreen unit tests for EwkView
https://bugs.webkit.org/show_bug.cgi?id=98509

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.

Update 2 fullscreen unit tests for EwkView so that
they don't require a call to ecore_evas_fullscreen_set()
to succeed. ecore_evas_fullscreen_set() does not
seem to work in Xvfb and causes the tests to hang.
With this update, we can now run those tests again.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

9:00 AM Changeset in webkit [130511] by apavlov@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: [Styles] Unable to edit properties in broken stylesheets
https://bugs.webkit.org/show_bug.cgi?id=98246

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Pop source data for invalid rules off the stack whenever we have consecutive CSSParser::markRuleHeaderStart() invocations.

Test: inspector/styles/parse-stylesheet-errors.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::popRuleData):
(WebCore::CSSParser::markRuleHeaderStart):
(WebCore::CSSParser::markRuleBodyStart):

  • css/CSSParser.h:

(CSSParser):

LayoutTests:

A small refactoring to share the CSS style data dumping code among tests.

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest):

  • inspector/styles/parse-stylesheet-errors-expected.txt: Added.
  • inspector/styles/parse-stylesheet-errors.html: Added.
  • inspector/styles/styles-new-API.html:
8:55 AM Changeset in webkit [130510] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98523

Unreviewed gardening after r130414.

  • platform/mac/TestExpectations:
8:46 AM Changeset in webkit [130509] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Test /webkit2/WebKitPrintOperation/print-errors gives runtime critical warnings
https://bugs.webkit.org/show_bug.cgi?id=98497

Reviewed by Martin Robinson.

The problem is that GTK+ tries to write in the IO channel that has
already been closed.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::print): Finish the surface when
printing fails because printing data is invalid.

8:31 AM Changeset in webkit [130508] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Test /webkit2/WebKitWebResource/response fails
https://bugs.webkit.org/show_bug.cgi?id=98511

Reviewed by Martin Robinson.

Do not consider the favicon as a resource for the web resources
unit tests.

  • UIProcess/API/gtk/tests/TestResources.cpp:
8:26 AM Changeset in webkit [130507] by Carlos Garcia Campos
  • 9 edits in trunk/Source/WebKit2

REGRESSION (r129989 - r130019): [WK2] TestResources test is failing
https://bugs.webkit.org/show_bug.cgi?id=98342

Reviewed by Martin Robinson.

Return 404 error in unit tests using a HTTP server for paths not
handled by the test. This way all tests should return now a 404
for /favicon.ico.

  • UIProcess/API/gtk/tests/TestBackForwardList.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestCookieManager.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestLoaderClient.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestResources.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestSSL.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(serverCallback):

  • UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(serverCallback):

8:22 AM Changeset in webkit [130506] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[WK2][SOUP] Assertion hit in WebKit::DownloadManager::downloadFinished() when download fails
https://bugs.webkit.org/show_bug.cgi?id=97565

Reviewed by Gustavo Noronha Silva.

Make sure to notify the downlaod client that the response has been
received when the newly created download has already been added to
the DownloadManager downloads map.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::DownloadClient): Initialize
m_handleResponseLaterID.
(WebKit::DownloadClient::~DownloadClient): Remove the source for
the delayed response notification if it hasn't been triggered.
(WebKit::DownloadClient::didReceiveData): If response hasn't been
handled yet, remove the source for the delayed response
notification and handle the resource before start writing the data
received to the output stream.
(WebKit::DownloadClient::handleResponse): Call
didReceiveResponse() with the delayed response.
(WebKit::DownloadClient::handleResponseLaterCallback): Call
handleResponse().
(WebKit::DownloadClient::handleResponseLater): Schedule an idle
callback to handle the response later, to make sure the download
has been added to the downloads map.
(WebKit::Download::startWithHandle): Call handleResponseLater()
with the given response to handle the response when the download
has been added to the downloads map.

8:21 AM Changeset in webkit [130505] by Csaba Osztrogonác
  • 8 edits
    1 add in trunk/LayoutTests

[Qt] Updates expected test results for the expanded coverage in testfonts
https://bugs.webkit.org/show_bug.cgi?id=98425

Unreviewed gardening after r130502.

  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt:
  • platform/qt/fast/images/icon-decoding-expected.png: Added.
  • platform/qt/fast/images/icon-decoding-expected.txt:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
7:42 AM Changeset in webkit [130504] by commit-queue@webkit.org
  • 8 edits
    3 adds in trunk

[chromium] Allow dragging into plugins.
https://bugs.webkit.org/show_bug.cgi?id=98277

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-05
Reviewed by Tony Chang.

Source/WebKit/chromium:

Allow plugins to receive drag events. This will make it possible to
perform drag-n-drop into browser plugins (and other plugins if desired).

  • public/WebDragStatus.h: Added.

(WebKit):

  • public/WebPlugin.h:

(WebKit):
(WebPlugin):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleMouseEvent):
(WebKit::WebPluginContainerImpl::handleDragEvent):
(WebKit):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

Tools:

Update the TestWebPlugin to receive drag events and print them out.

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::handleDragStatusUpdate):

  • DumpRenderTree/chromium/TestWebPlugin.h:

(TestWebPlugin):

LayoutTests:

Add test to make sure that plugins receive the drag events correctly.

  • platform/chromium/plugins/drag-events-expected.txt: Added.
  • platform/chromium/plugins/drag-events.html: Added.
7:33 AM Changeset in webkit [130503] by rwlbuis@webkit.org
  • 4 edits in trunk

[BlackBerry] Sync up CMake files
https://bugs.webkit.org/show_bug.cgi?id=98442

Reviewed by Gyuyoung Kim.

.:

Amongst others some internal paths changed.

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit:

Amongst others use InspectorOverlayBlackBerry.

  • PlatformBlackBerry.cmake:
7:31 AM Changeset in webkit [130502] by Csaba Osztrogonác
  • 16 edits
    6 deletes in trunk/LayoutTests

[Qt] Updates expected test results for the expanded coverage in testfonts
https://bugs.webkit.org/show_bug.cgi?id=98425

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-10-05
Reviewed by Csaba Osztrogonác.

The Qt testfonts repository was expanded with the croscore set of
fonts, which provides a great number of new glyphs (e.g. hebrew
characters).

See the comments in the testfonts commit for detailed information:
https://gitorious.org/qtwebkit/testfonts/commit/f11a54548121ee9fb0688dc6f32acdbfec5d2d2f/diffs

  • platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
  • platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt: Removed.
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt: Removed.
  • platform/qt-5.0/fast/forms/search-rtl-expected.png: Removed.
  • platform/qt-5.0/fast/forms/search-rtl-expected.txt: Removed.
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/qt/fast/borders/bidi-012-expected.txt:
  • platform/qt/fast/forms/listbox-bidi-align-expected.png:
  • platform/qt/fast/forms/listbox-bidi-align-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.png:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/qt/fast/text/large-text-composed-char-expected.png:
  • platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.png:
  • platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.txt:
7:29 AM Changeset in webkit [130501] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Find a proper fix for the WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling hack
https://bugs.webkit.org/show_bug.cgi?id=98517
PR #137382

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>

We've generalized composited in-region scrolling, originally only applicable
to block elements, to inner frames (see PR #197093). Past that, we no longer
need to force repaints of offscreen areas when we finish scrolling, since translating
the Layer takes care of properly invalidating it. Thus, remove this method.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):

  • Api/WebPage_p.h:

(WebPagePrivate):

7:19 AM Changeset in webkit [130500] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update default input support style for single line inputs.
https://bugs.webkit.org/show_bug.cgi?id=98510

Reviewed by Antonio Gomes.

PR 219588.

Update style calculations to eliminate automatic changes
by default on single line input fields.

Reviewed Internally by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::inputStyle):

6:59 AM Changeset in webkit [130499] by kadam@inf.u-szeged.hu
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed Qt gardening.

The ICO decoder shouldn't be broken since it is the WebKit decoder.

Patch by Allan Sandfeld Jensen <allan.jensen@digia.com> on 2012-10-05

  • platform/qt/TestExpectations:
6:42 AM Changeset in webkit [130498] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update an expected file for newer Qt5.

  • platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png:
  • platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
5:47 AM Changeset in webkit [130497] by rgabor@webkit.org
  • 2 edits in trunk/Source/WebCore

Add ARM-NEON support to VectorMath in WebAudio
https://bugs.webkit.org/show_bug.cgi?id=98131

Reviewed by Zoltan Herczeg.

Speed up vector operations in WebAudio with NEON intrinsics.

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::vsma):
(WebCore::VectorMath::vsmul):
(WebCore::VectorMath::vadd):
(WebCore::VectorMath::vmul):
(WebCore::VectorMath::zvmul):
(WebCore::VectorMath::vsvesq):
(WebCore::VectorMath::vmaxmgv):

5:36 AM Changeset in webkit [130496] by Simon Hausmann
  • 6 edits
    4 moves
    4 deletes in trunk/Source

Unreviewed, rolling out r130495.
http://trac.webkit.org/changeset/130495
https://bugs.webkit.org/show_bug.cgi?id=98268

Source/WebCore:

Made WK2 tests crash.

  • Target.pri:
  • platform/qt/QStyleFacade.cpp: Removed.
  • platform/qt/QStyleFacade.h: Removed.

Source/WebKit:

Made WK2 tests crash....

  • WebKit1.pro:

Source/WebKit/qt:

Made WK2 tests crash.

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

  • WebCoreSupport/QStyleFacadeImp.cpp: Removed.
  • WebCoreSupport/QStyleFacadeImp.h: Removed.
  • WebCoreSupport/RenderThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.cpp.

(WebCore):
(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::colorPalette):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • WebCoreSupport/RenderThemeQStyle.h: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.h.

(WebCore):
(RenderThemeQStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):

  • WebCoreSupport/ScrollbarThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQStyle.cpp.

(WebCore):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::styleOptionSlider):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
(WebCore::ScrollbarThemeQStyle::style):

  • WebCoreSupport/ScrollbarThemeQStyle.h: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQStyle.h.

(WebCore):
(ScrollbarThemeQStyle):

4:43 AM Changeset in webkit [130495] by Simon Hausmann
  • 6 edits
    4 moves
    4 adds in trunk/Source

[Qt] Make RenderThemeQStyle/ScrollbarThemeQStyle compile without QStyle/QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=98268

Reviewed by Tor Arne Vestbø.

Source/WebCore:

Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.

QStyleFacade is a pure interface that lives in WebCore/platform/qt
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
minimal interface of what we need to draw with QStyle as well as basic
hit testing and metric retrieval. It also provides a
QStyleFacadeOption class that aggregates common meta-data for
rendering primitives, such as direction, rectangle, state (sunken,
enabled, etc.) or palette. It also provides some more slider/scrollbar
specific fields in a slider sub-structure.

RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
them with state information from render objects, before calling straight to QStyle. Most of the common code
was encapsulated in StylePainterQStyle.

The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
StylePainterQStyle to populate state into QStyleFacadeOption before
calling into QStyleFacade.

The style facade is then implemented by QStyleFacadeImp, which extracts
meta-data from QStyleFacadeOption arguments, populates style
primitive specific QStyleOption objects and then calls on QStyle.

RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
separate QtWebKitWidgets library in the future and therefore cannot use
any WebCore types.

  • Target.pri:
  • platform/qt/QStyleFacade.cpp: Added.

(WebCore):
(WebCore::QStyleFacade::styleForPage):

  • platform/qt/QStyleFacade.h: Added.

(WebCore):
(QStyleFacade):
(WebCore::QStyleFacade::~QStyleFacade):
(WebCore::QStyleFacadeOption::QStyleFacadeOption):
(QStyleFacadeOption):

  • platform/qt/RenderThemeQStyle.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.cpp.

(WebCore):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::setStyleFactoryFunction):
(WebCore::RenderThemeQStyle::styleFactory):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::colorPalette):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • platform/qt/RenderThemeQStyle.h: Renamed from Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.h.

(WebCore):
(RenderThemeQStyle):
(WebCore::RenderThemeQStyle::qStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::paintButton):
(WebCore::StylePainterQStyle::paintTextField):
(WebCore::StylePainterQStyle::paintComboBox):
(WebCore::StylePainterQStyle::paintComboBoxArrow):
(WebCore::StylePainterQStyle::paintSliderTrack):
(WebCore::StylePainterQStyle::paintSliderThumb):
(WebCore::StylePainterQStyle::paintInnerSpinButton):
(WebCore::StylePainterQStyle::paintProgressBar):
(WebCore::StylePainterQStyle::paintScrollCorner):
(WebCore::StylePainterQStyle::paintScrollBar):

  • platform/qt/ScrollbarThemeQStyle.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/ScrollbarThemeQStyle.cpp.

(WebCore):
(WebCore::ScrollbarThemeQStyle::ScrollbarThemeQStyle):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::initSliderStyleOption):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):

  • platform/qt/ScrollbarThemeQStyle.h: Renamed from Source/WebKit/qt/WebCoreSupport/ScrollbarThemeQStyle.h.

(WebCore):
(ScrollbarThemeQStyle):
(WebCore::ScrollbarThemeQStyle::qStyle):

Source/WebKit:

  • WebKit1.pro: Add new files to the build.

Source/WebKit/qt:

Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.

QStyleFacade is a pure interface that lives in WebCore/platform/qt
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
minimal interface of what we need to draw with QStyle as well as basic
hit testing and metric retrieval. It also provides a
QStyleFacadeOption class that aggregates common meta-data for
rendering primitives, such as direction, rectangle, state (sunken,
enabled, etc.) or palette. It also provides some more slider/scrollbar
specific fields in a slider sub-structure.

RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
them with state information from render objects, before calling straight to QStyle. Most of the common code
was encapsulated in StylePainterQStyle.

The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
StylePainterQStyle to populate state into QStyleFacadeOption before
calling into QStyleFacade.

The style facade is then implemented by QStyleFacadeImp, which extracts
meta-data from QStyleFacadeOption arguments, populates style
primitive specific QStyleOption objects and then calls on QStyle.

RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
separate QtWebKitWidgets library in the future and therefore cannot use
any WebCore types.

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

  • WebCoreSupport/QStyleFacadeImp.cpp: Added.

(WebKit):
(WebKit::convertToQStyleState):
(WebKit::convertToQStyleSubControl):
(WebKit::initGenericStyleOption):
(WebKit::initSpecificStyleOption):
(MappedStyleOption):
(WebKit::MappedStyleOption::MappedStyleOption):
(WebKit::convertPixelMetric):
(WebKit::convertToQStyleFacadeSubControl):
(WebKit::QStyleFacadeImp::QStyleFacadeImp):
(WebKit::QStyleFacadeImp::~QStyleFacadeImp):
(WebKit::QStyleFacadeImp::buttonSubElementRect):
(WebKit::QStyleFacadeImp::findFrameLineWidth):
(WebKit::QStyleFacadeImp::simplePixelMetric):
(WebKit::QStyleFacadeImp::buttonMargin):
(WebKit::QStyleFacadeImp::sliderLength):
(WebKit::QStyleFacadeImp::sliderThickness):
(WebKit::QStyleFacadeImp::progressBarChunkWidth):
(WebKit::QStyleFacadeImp::getButtonMetrics):
(WebKit::QStyleFacadeImp::sizeFromContents):
(WebKit::QStyleFacadeImp::paintButton):
(WebKit::QStyleFacadeImp::paintTextField):
(WebKit::QStyleFacadeImp::paintComboBox):
(WebKit::QStyleFacadeImp::paintComboBoxArrow):
(WebKit::QStyleFacadeImp::paintSliderTrack):
(WebKit::QStyleFacadeImp::paintSliderThumb):
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
(WebKit::QStyleFacadeImp::paintProgressBar):
(WebKit::QStyleFacadeImp::scrollBarExtent):
(WebKit::QStyleFacadeImp::scrollBarMiddleClickAbsolutePositionStyleHint):
(WebKit::QStyleFacadeImp::paintScrollCorner):
(WebKit::QStyleFacadeImp::hitTestScrollBar):
(WebKit::QStyleFacadeImp::scrollBarSubControlRect):
(WebKit::QStyleFacadeImp::paintScrollBar):
(WebKit::QStyleFacadeImp::widgetForPainter):
(WebKit::QStyleFacadeImp::style):

  • WebCoreSupport/QStyleFacadeImp.h: Added.

(WebCore):
(WebKit):
(QStyleFacadeImp):
(WebKit::QStyleFacadeImp::create):
(WebKit::QStyleFacadeImp::isValid):

4:33 AM Changeset in webkit [130494] by commit-queue@webkit.org
  • 16 edits
    3 moves in trunk

[EFL][WK2] Remove "web" word from ewk_web_error APIs
https://bugs.webkit.org/show_bug.cgi?id=97886

Patch by Jongseok Yang <js45.yang@samsung.com> on 2012-10-05
Reviewed by Gyuyoung Kim.

Remove "web" word from ewk_web_error APIs.
"web" word was redundant because "ewk" means "EFL WebKit" and WK APIs for error does not have "web" word.

Source/WebKit2:

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_context_download_client.cpp:

(didFail):

  • UIProcess/API/efl/ewk_cookie_manager.cpp:

(getAcceptPolicyCallback):
(getHostnamesWithCookiesCallback):

  • UIProcess/API/efl/ewk_cookie_manager.h:
  • UIProcess/API/efl/ewk_download_job_private.h:
  • UIProcess/API/efl/ewk_error.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_error.cpp.

(_Ewk_Error):
(_Ewk_Error::_Ewk_Error):
(_Ewk_Error::~_Ewk_Error):
(ewk_error_free):
(ewk_error_type_get):
(ewk_error_url_get):
(ewk_error_code_get):
(ewk_error_description_get):
(ewk_error_cancellation_get):
(ewk_error_new):

  • UIProcess/API/efl/ewk_error.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_error.h.
  • UIProcess/API/efl/ewk_error_private.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_error_private.h.
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_resource_load_failed):
(ewk_view_download_job_failed):
(ewk_view_load_error):
(ewk_view_load_provisional_failed):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didFailLoadWithErrorForFrame):
(didFailProvisionalLoadWithErrorForFrame):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:

(didFailLoadForResource):

  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(getAcceptPolicyCallback):
(getHostnamesWithCookiesCallback):

  • UIProcess/API/efl/tests/test_ewk2_download_job.cpp:

(on_download_failed):

Tools:

  • MiniBrowser/efl/main.c:

(on_error):

4:30 AM Changeset in webkit [130493] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2][GTK] WebPageAccessibilityObject leaking
https://bugs.webkit.org/show_bug.cgi?id=98502

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-05
Reviewed by Carlos Garcia Campos.

Use GRefPtr on the accessibility object to fix the leak.

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::updateAccessibilityTree):

3:59 AM Changeset in webkit [130492] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add API to count the matching text
https://bugs.webkit.org/show_bug.cgi?id=97873

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-05
Reviewed by Gyuyoung Kim.

Add an API, ewk_view_text_matches_count(), to count the matched text in the document.
This API does not highlight the matched text in the document unlike ewk_view_text_find().

ewk_view_text_find() finds the matching text and but also update the UI view,
but some applications may not want to affect the view, and just want to know the count.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_text_matches_count):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

3:23 AM Changeset in webkit [130491] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WTF

[GTK] Add support for GBytes in GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=98489

Patch by Simon Pena <Simon Pena> on 2012-10-05
Reviewed by Carlos Garcia Campos.

Adding support for GBytes in GRefPtr makes it easier
for them to be used when adding GResources support,
and is more consistent with the rest of the port.

This calls g_bytes_ref and g_bytes_unref in the implementation
of the refPtr and derefPtr template functions, in case the GLib
version is met. Otherwise, it does nothing.

  • wtf/gobject/GRefPtr.cpp: Implement templates for ref and deref.

(WTF::refGPtr):
(WTF):
(WTF::derefGPtr):

  • wtf/gobject/GRefPtr.h:

(WTF):

  • wtf/gobject/GTypedefs.h: Define the GBytes datatype.
2:19 AM Changeset in webkit [130490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][GTK][EFL] standard_output returned by g_spawn_sync must be freed
https://bugs.webkit.org/show_bug.cgi?id=98384

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-05
Reviewed by Gyuyoung Kim.

Free the standard_output returned by g_spawn_sync() to avoid
a memory leak.

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

2:09 AM Changeset in webkit [130489] by commit-queue@webkit.org
  • 6 edits
    5 adds in trunk

Incomplete repaint of boxes with inset box-shadow and padding when resized
https://bugs.webkit.org/show_bug.cgi?id=59863

Patch by Andrei Bucur <abucur@adobe.com> on 2012-10-05
Reviewed by Simon Fraser.

Source/WebCore:

The patch extends the repaint rectangle to include the inset shadow extent for renderers that resize and need to be repainted. The rectangle computations are also better fragmented and easier to read.

New Test: fast/repaint/box-shadow-inset-repaint.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getShadowInsetExtent):
(WebCore):

  • rendering/style/RenderStyle.h:

LayoutTests:

The patch adds a new pixel test and expected PNG results for mac and chromium-mac. The test fails on Chromium Linux EWS (and maybe others)
so I've added a rule in the TestExpectations file.

  • platform/chromium/TestExpectations:
  • fast/repaint/box-shadow-inset-repaint.html: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
  • platform/mac/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
  • platform/mac/fast/repaint/box-shadow-inset-repaint-expected.txt: Added.
2:00 AM Changeset in webkit [130488] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=98491

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-05
Reviewed by Jocelyn Turcotte.

This code was added long time ago for a Symbian related project and is
not needed anymore.

  • Api/qwebframe.cpp:
1:49 AM Changeset in webkit [130487] by zandobersek@gmail.com
  • 10 edits
    1 delete in trunk/LayoutTests

Unreviewed GTK gardening.

Updating platform-specific baselines after r130411.
Removing platform-specific baselines for CSS compositing tests
and skipping these tests entirely as the feature is not yet enabled
on the GTK port.

  • platform/gtk/TestExpectations:
  • platform/gtk/css3/compositing: Removed.
  • platform/gtk/css3/compositing/blend-mode-property-expected.txt: Removed.
  • platform/gtk/css3/compositing/blend-mode-property-parsing-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/gtk/editing/execCommand/paste-1-expected.txt:
  • platform/gtk/editing/pasteboard/8145-3-expected.txt:
  • platform/gtk/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/gtk/editing/pasteboard/unrendered-br-expected.txt:
1:33 AM Changeset in webkit [130486] by Csaba Osztrogonác
  • 3 edits
    1 move
    1 add in trunk

[Qt] Enable CSS compositing by default
https://bugs.webkit.org/show_bug.cgi?id=98490

Reviewed by Simon Hausmann.

Tools:

  • qmake/mkspecs/features/features.pri:

LayoutTests:

  • platform/qt/css3/compositing/should-have-compositing-layer-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/css3/compositing/should-have-compositing-layer-expected.txt.
1:17 AM Changeset in webkit [130485] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=98481

r130477 affects month-multiple-fields tests too.

  • platform/chromium/TestExpectations:
1:15 AM Changeset in webkit [130484] by vsevik@chromium.org
  • 3 edits in branches/chromium/1229/Source/WebCore/inspector/front-end

Merge 124886 - Web Inspector: Do not disable network tracking while profiling cpu.
https://bugs.webkit.org/show_bug.cgi?id=93359

Reviewed by Yury Semikhatsky.

Removed network tracking enabling/disabling machinery.

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileType.prototype.buttonClicked):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):

TBR=vsevik@chromium.org
BUG=153748
Review URL: https://codereview.chromium.org/11068016

1:12 AM Changeset in webkit [130483] by Csaba Osztrogonác
  • 4 edits in trunk

Unreviewed, rolling out r130466.
http://trac.webkit.org/changeset/130466
https://bugs.webkit.org/show_bug.cgi?id=98495

It made 12 tests crash on Qt-WK2 (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-05

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::focus):
(WTR::TestController::initialize):

LayoutTests:

  • platform/efl-wk2/TestExpectations:
1:11 AM Changeset in webkit [130482] by vsevik@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebCore/inspector/front-end/inspector.css

Merge 125255 - Web Inspector: Search matches count view is flaky.
https://bugs.webkit.org/show_bug.cgi?id=93451

Patch by Sam D <dsam2912@gmail.com> on 2012-08-10
Reviewed by Pavel Feldman.

Modified css properties for aligning search panel.

No new tests.UI change.

  • inspector/front-end/inspector.css:

(.search-results-matches):

TBR=commit-queue@webkit.org
BUG=153753
Review URL: https://codereview.chromium.org/11029044

1:09 AM Changeset in webkit [130481] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WTF

Unreviewed, rolling out r130478.
http://trac.webkit.org/changeset/130478
https://bugs.webkit.org/show_bug.cgi?id=98494

It broke the Qt build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-05

  • wtf/gobject/GRefPtr.cpp:
  • wtf/gobject/GRefPtr.h:

(WTF):

  • wtf/gobject/GTypedefs.h:
12:58 AM Changeset in webkit [130480] by tkent@chromium.org
  • 2 edits
    14 adds in trunk/LayoutTests

Add appearance tests for input[type=date] with multiple fields
https://bugs.webkit.org/show_bug.cgi?id=98479

Reviewed by Kentaro Hara.

  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html: Added.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium/TestExpectations:
12:46 AM Changeset in webkit [130479] by commit-queue@webkit.org
  • 7 edits
    3 moves in trunk/Source/WebKit2

[EFL][WK2] Remove "web" word from ewk_resource APIs
https://bugs.webkit.org/show_bug.cgi?id=97887

Patch by Jongseok Yang <js45.yang@samsung.com> on 2012-10-05
Reviewed by Gyuyoung Kim.

Remove "web" word from ewk_web_resource APIs.
"web" word was redundant because "ewk" means "EFL WebKit" and enough to understand the meaning with ewk_resource_XXX.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_resource.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_resource.cpp.

(_Ewk_Resource):
(_Ewk_Resource::_Ewk_Resource):
(_Ewk_Resource::~_Ewk_Resource):
(ewk_resource_ref):
(ewk_resource_unref):
(ewk_resource_url_get):
(ewk_resource_new):
(ewk_resource_main_resource_get):

  • UIProcess/API/efl/ewk_resource.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_resource.h.
  • UIProcess/API/efl/ewk_resource_private.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_web_resource_private.h.
  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_priv_loading_resources_clear):
(ewk_view_resource_load_initiated):
(ewk_view_resource_load_response):
(ewk_view_resource_load_failed):
(ewk_view_resource_load_finished):
(ewk_view_resource_request_sent):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:

(didInitiateLoadForResource):

12:40 AM Changeset in webkit [130478] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WTF

[GTK] Add support for GBytes in GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=98489

Patch by Simon Pena <Simon Pena> on 2012-10-05
Reviewed by Carlos Garcia Campos.

Adding support for GBytes in GRefPtr makes it easier
for them to be used when adding GResources support,
and is more consistent with the rest of the port.

This calls g_bytes_ref and g_bytes_unref in the implementation
of the refPtr and derefPtr template functions.

  • wtf/gobject/GRefPtr.cpp: Implement templates for ref and deref.

(WTF::refGPtr):
(WTF):
(WTF::derefGPtr):

  • wtf/gobject/GRefPtr.h:

(WTF):

  • wtf/gobject/GTypedefs.h: Define the GBytes datatype.
12:35 AM Changeset in webkit [130477] by tkent@chromium.org
  • 11 edits in trunk

Fix sub-field width to the maximum width of a placeholder and the maximum value
https://bugs.webkit.org/show_bug.cgi?id=98481

Reviewed by Hajime Morita.

Source/WebCore:

We can't assume a placeholder text is shorter than the width of
digits. The placeholder string for the year field of
input[type=week] is "----", but input[type=date] will have a
localized string for it.

We should set the 'width' CSS property to the maximum of the
placeholder width and the maximum value width in order to prevent
the field width from growing/narrowing.

Before this patch, we secured four digits space for a year field,
and allowed the field to grow its width when a larger year is
set. After this patch, we don't allow it to grow because the
'width' property is set to the maximum width.

Update week-multiple-fields-appearance-basic.html, and the
following tests are affected.

  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html
  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
Enable customStyleForRenderer.
(WebCore::DateTimeNumericFieldElement::customStyleForRenderer):
Added. The code is similar to DateTimeSymbolicFieldElement::customStyleForRenderer().
(WebCore::DateTimeNumericFieldElement::formatValue):
Made a function with the code in value(). This is used in
customStyleForRenderer() and value().
(WebCore::DateTimeNumericFieldElement::value): Use formatValue().

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Declare new functions.

LayoutTests:

Update a test and test expectations.

  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt:
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium/TestExpectations:
12:27 AM Changeset in webkit [130476] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

Improve spelling and performance of Localizer.cpp
https://bugs.webkit.org/show_bug.cgi?id=98485

Reviewed by Kentaro Hara.

Some improvements pointed in webkit.org/b/98229#c5.

No new tests because of no behavior change.

  • platform/text/Localizer.h:

(Localizer):

  • Rename dateTimeFormatWithSecond to dateTimeFormatWithSeconds
  • Rename dateTimeFormatWithoutSecond to dateTimeFormatWithoutSeconds
  • Add data members: m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.
  • platform/text/Localizer.cpp:

(WebCore::Localizer::timeFormat): Check isNull instead of isEmpty
(WebCore::Localizer::shortTimeFormat): Ditto.
(WebCore::Localizer::dateTimeFormatWithSeconds):

  • Renamed.
  • Cache the concatenation result to a data member.

(WebCore::Localizer::dateTimeFormatWithoutSeconds): Ditto.

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::setupLayoutParameters): Follow the renaming.

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::setupLayoutParameters): Ditto.

12:21 AM Changeset in webkit [130475] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2][WTR] Unskip parser-tests-110.html test case.
https://bugs.webkit.org/show_bug.cgi?id=98484

Unreviewed EFL gardening.

fast/encoding/parser-tests-110.html test case has been passed consistently.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-05

  • platform/efl-wk2/TestExpectations:
12:19 AM Changeset in webkit [130474] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Gardening, skip some failing test.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-05
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
12:16 AM Changeset in webkit [130473] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] Fix window resizing / moving in WK1 and WKTR
https://bugs.webkit.org/show_bug.cgi?id=98486

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-05
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Fix ChromeClientEfl::windowRect() code to use
ecore_evas_request_geometry_get() instead of
evas_object_geometry_get() and therefore avoid
returning incorrect values when the engine has
not processed a call to ecore_evas_move_resize()
yet. This fixes a couple of layout tests.

The code was also refactored a bit for
consistency with the WebKit2 EFL implementation.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::windowRect):
(WebCore::ChromeClientEfl::setWindowRect):

Tools:

Fix PlatformWebView::windowFrame() and
PlatformWebView::setWindowFrame() in EFL's WKTR so
that it resizes / moves the window, not the view.

The new code matches the implementation in EwkView's
UIClient.

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):

LayoutTests:

Unskip 2 window resizing / moving tests now that
the implementation for those has been fixed in
WebKit1 EFL.

  • platform/efl-wk1/TestExpectations:

Oct 4, 2012:

11:58 PM Changeset in webkit [130472] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Fix destination path when download with suggested filename on the Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98334

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-10-04
Reviewed by Gyuyoung Kim.

Add callback functions for download requests to Minibrowser to set the destination path for download.
Set the destination path with suggested file name as (destination folder) + (suggested file name).
The 'destination folder' should be a specific folder user selected, but is set to '/tmp' for now.

Additionally, for printing out the download status,
use the info macro and set the verbose variable to 1 to enable it.

  • MiniBrowser/efl/main.c:

(on_download_request):
(on_download_finished):
(on_download_failed):
(browserCreate):

11:57 PM Changeset in webkit [130471] by bashi@chromium.org
  • 10 edits
    2 adds in trunk/Source

[WebSocket] ExtensionParser should have its own file
https://bugs.webkit.org/show_bug.cgi?id=98475

Reviewed by Yuta Kitamura.

Source/WebCore:

Factor out ExtensionParser from WebSocketExtensionDispatcher and rename it as WebSocketExtensionParser.
WebSocketExtensionParser has its own file.

No changes in behavior. Added a test case for parsing Sec-WebSocket-Extensions field as a chromium unit test.

  • CMakeLists.txt: Added WebSocketExtensionParser.
  • GNUmakefile.list.am: Ditto.
  • Modules/websockets/WebSocketExtensionDispatcher.cpp:

(WebCore::WebSocketExtensionDispatcher::processHeaderValue):
Use WebSocketExtensionParser::parseExtension() to parser extension header value.

  • Modules/websockets/WebSocketExtensionParser.cpp: Added.

(WebCore):
(WebCore::WebSocketExtensionParser::finished): Moved from ExtensionParser.
(WebCore::WebSocketExtensionParser::parsedSuccessfully): Ditto.
(WebCore::isSeparator): Ditto.
(WebCore::WebSocketExtensionParser::skipSpaces): Ditto.
(WebCore::WebSocketExtensionParser::consumeToken): Ditto.
(WebCore::WebSocketExtensionParser::consumeQuotedString): Ditto.
(WebCore::WebSocketExtensionParser::consumeQuotedStringOrToken): Ditto.
(WebCore::WebSocketExtensionParser::consumeCharacter): Ditto.
(WebCore::WebSocketExtensionParser::parseExtension): Moved from WebSocketExtensionDispatcher.

  • Modules/websockets/WebSocketExtensionParser.h: Added.

(WebCore):
(WebSocketExtensionParser):
(WebCore::WebSocketExtensionParser::WebSocketExtensionParser):
(WebCore::WebSocketExtensionParser::currentToken):

  • Target.pri: Added WebSocketExtensionParser.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.

Source/WebKit/chromium:

Add a test for parsing Sec-WebSocket-Extensions field.

  • tests/WebSocketExtensionDispatcherTest.cpp:

(WebCore):
(WebCore::TEST_F):

11:55 PM Changeset in webkit [130470] by ryuan.choi@samsung.com
  • 7 edits in trunk/Source/WebKit2

[EFL][WK2] ewk_web_error_free is not a public API
https://bugs.webkit.org/show_bug.cgi?id=98482

Reviewed by Gyuyoung Kim.

Because Ewk_Web_Error is just passed as a parameter of callback function
and maintained internally, ewk_web_error_free should not be a public API.

This patch moves ewk_web_error_free from public header to private header.

  • UIProcess/API/efl/ewk_context_download_client.cpp:
  • UIProcess/API/efl/ewk_view_loader_client.cpp:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:
  • UIProcess/API/efl/ewk_web_error.cpp:
  • UIProcess/API/efl/ewk_web_error.h:
  • UIProcess/API/efl/ewk_web_error_private.h:
11:41 PM Changeset in webkit [130469] by commit-queue@webkit.org
  • 9 edits in trunk

<input> size attribute should throw INDEX_SIZE_ERR when set to 0
https://bugs.webkit.org/show_bug.cgi?id=61675

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-10-04
Reviewed by Kent Tamura.

Source/WebCore:

According to the spec, the size IDL attribute of input elements is limited
to only non-negative numbers greater than zero. It should throw INDEX_SIZE_ERR
exception when set to 0. New behavior matches both Firefox and IE.
Spec: http://www.w3.org/TR/html5/common-input-element-attributes.html#the-size-attribute

Test: fast/dom/HTMLInputElement/input-size-attribute.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setSize):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLInputElement.idl:

LayoutTests:

Added test case to verify that input.size throws INDEX_SIZE_ERR when set to 0.

Updated fast/forms/number/number-size.html to reflect new behavior.

  • fast/dom/HTMLInputElement/input-size-attribute-expected.txt:
  • fast/dom/HTMLInputElement/input-size-attribute.html:
  • fast/forms/number/number-size.html:
  • fast/forms/number/number-size-expected.txt:
11:39 PM Changeset in webkit [130468] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Improve SocketStreamHandle::send() stability
https://bugs.webkit.org/show_bug.cgi?id=98459

Reviewed by Yuta Kitamura.

Avoid null dereference in SocketStreamHandleInternal::send().
No changes in behavior.

  • src/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::send):

11:24 PM Changeset in webkit [130467] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix font for date/time input types.
https://bugs.webkit.org/show_bug.cgi?id=98478

Reviewed by Kentaro Hara.

input[type=date] should use monospace font if
ENABLE_INPUT_MULTIPLE_FIELDS_UI && ENABLE_INPUT_TYPE_DATE.

For other date/time types, they should use monospace font only
if their types are enabled. input[type="foo"] matches input
element with type="foo" even if the foo type is not supported.

The input[type=date] change is covered by
fast/forms/date/calendar-picker-appearance.html,
platform/chromium/fast/forms/date/date-suggestion-picker-appearance*.html

  • css/html.css:

(input[type="date"]):
(input[type="datetime"]):
(input[type="datetime-local"]):
(input[type="month"]):
(input[type="time"]):

11:22 PM Changeset in webkit [130466] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=98256

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implement UIClient's focus callbacks in WebKitTestRunner.

  • WebKitTestRunner/TestController.cpp:

(WTR::focus):
(WTR::TestController::initialize):

LayoutTests:

Unskip fast/dom/Window/mozilla-focus-blur.html now that
WebKitTestRunner implements UIClient's focus callbacks.

  • platform/efl-wk2/TestExpectations:
11:15 PM Changeset in webkit [130465] by morrita@google.com
  • 9 edits
    4 adds in trunk/Source/WebCore

[Refactoring] Some classes in StyleResolver.cpp/h could have its own file.
https://bugs.webkit.org/show_bug.cgi?id=98469

Reviewed by Dimitri Glazkov.

This change extracts RuleData, RuleSet, RuleFeature and Featurs class
to its own file: RuleSet.h/cpp and RuleFeature.h/cpp

RuleFeature class is moved fro StyleResolver inner class to plain WebCore class.
Feaures class is renamed to RuleFeatureSet to avoid possible name conflict.

No new tests. Just splitting file and doing simple rename.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/RuleFeature.cpp: Added.

(WebCore):
(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):
(WebCore::RuleFeatureSet::reportMemoryUsage):

  • css/RuleFeature.h: Added.

(WebCore):
(RuleFeature):
(WebCore::RuleFeature::RuleFeature):
(RuleFeatureSet):
(WebCore::RuleFeatureSet::RuleFeatureSet):

  • css/RuleSet.cpp: Added.

(WebCore):
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::selectorListContainsUncommonAttributeSelector):
(WebCore::isCommonAttributeSelectorAttribute):
(WebCore::containsUncommonAttributeSelector):
(WebCore::RuleData::RuleData):
(WebCore::RuleData::reportMemoryUsage):
(WebCore::reportAtomRuleMap):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromRuleData):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
(WebCore::shrinkMapVectorsToFit):
(WebCore::RuleSet::shrinkToFit):

  • css/RuleSet.h: Added.

(WebCore):
(RuleData):
(WebCore::RuleData::position):
(WebCore::RuleData::rule):
(WebCore::RuleData::selector):
(WebCore::RuleData::selectorIndex):
(WebCore::RuleData::hasFastCheckableSelector):
(WebCore::RuleData::hasMultipartSelector):
(WebCore::RuleData::hasRightmostSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleData::containsUncommonAttributeSelector):
(WebCore::RuleData::specificity):
(WebCore::RuleData::linkMatchType):
(WebCore::RuleData::hasDocumentSecurityOrigin):
(WebCore::RuleData::isInRegionRule):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(SameSizeAsRuleData):
(RuleSet):
(WebCore::RuleSet::create):
(WebCore::RuleSet::disableAutoShrinkToFit):
(WebCore::RuleSet::features):
(WebCore::RuleSet::idRules):
(WebCore::RuleSet::classRules):
(WebCore::RuleSet::tagRules):
(WebCore::RuleSet::shadowPseudoElementRules):
(WebCore::RuleSet::linkPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):
(WebCore::RuleSet::pageRules):
(WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
(RuleSetSelectorPair):
(WebCore::RuleSet::RuleSet):

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::makeRuleSet):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(StyleResolver):

11:11 PM Changeset in webkit [130464] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit2

[EFL][WK2] Implement window frame callbacks in UIClient
https://bugs.webkit.org/show_bug.cgi?id=98280

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Implement callbacks to set and query window geometry
in EwkView's UIClient.

  • UIProcess/API/efl/ewk_view_ui_client.cpp:

(getWindowFrame):
(setWindowFrame):
(ewk_view_ui_client_attach):

  • UIProcess/API/efl/tests/resources/window_move_resize.html: Added.
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(windowMoveResizeTimedOut):
(TEST_F): Add corresponding unit test.

11:02 PM Changeset in webkit [130463] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

FeatureObserver should distinguish between legacy HTML and text notifications
https://bugs.webkit.org/show_bug.cgi?id=98441

Reviewed by Tony Chang.

We might be able to drop support for legacy HTML notifications before
we can drop support for legacy text notifications. We should measure
and find out.

  • Modules/notifications/NotificationCenter.idl:
  • page/FeatureObserver.h:
10:00 PM Changeset in webkit [130462] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium DEPS roll r160281:160322

Unreviewed.

  • DEPS:
9:59 PM Changeset in webkit [130461] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Removing the unused member variable m_wasMalformed from HTMLFormElement class and its related code frgment.
https://bugs.webkit.org/show_bug.cgi?id=98444

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-10-04
Reviewed by Eric Seidel.

The member variable m_wasMalformed of HTMLFormElement class was used to determine if the <form> tag was malformed or not.
This information was used elsewhere to decide if bottom margins have to be included for such a <form>.
However currently this member variable is not being set by any code following code refactoring in HTML parser class.

Code cleanup patch. No new tests required.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::HTMLFormElement):

Removed m_wasMalformed initialization.

  • html/HTMLFormElement.h:

(HTMLFormElement):

Removed m_wasMalformed variable.
Removed m_wasMalformed variable's setter and getter functions.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

Removed code fragment using/dependent on m_wasMalformed.

9:56 PM Changeset in webkit [130460] by commit-queue@webkit.org
  • 16 edits in trunk

Turn Compositing on by default in WebKit build
https://bugs.webkit.org/show_bug.cgi?id=98315

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-10-04
Reviewed by Simon Fraser.

enable -webkit-blend-mode on trunk.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests. Existing blending test were updated.

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • css3/compositing/blend-mode-property-expected.txt:
  • css3/compositing/blend-mode-property-parsing-expected.txt:
  • css3/compositing/script-tests/blend-mode-property.js:

(testblendmode):

  • css3/compositing/should-have-compositing-layer-expected.txt:
  • platform/chromium/TestExpectations:
9:47 PM Changeset in webkit [130459] by hayato@chromium.org
  • 4 edits
    1 add in trunk

[Refactoring] Introduce a traversal strategy in SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=97298

Reviewed by Antti Koivisto.

PerformanceTests:

Introduces querySelector() performance tests to check SelectorChecker performance.

  • CSS/PseudoClassSelectors.html: Added.

Source/WebCore:

We extract DOM traversal code from SelectorChecker so that we can use another traversal strategy.
Another traversal strategy will be introduced in Bug 96990.

Since this code path is very hot, we were very careful not to regress performance.
We will use template specialization to change the traversal implementation.

We confirmed that this patch does not regress SelectorCheckerPerformance. I have checked the performance of
the added test in my Linux Box using run-perf-tests.

The performance of the added test before using this patch was:

RESULT CSS: PseudoClassSelectors= 3399.68308031 runs/s
median= 3404.48685564 runs/s, stdev= 37.3480114449 runs/s, min= 3272.64871114 runs/s, max= 3438.72385184 runs/s

When we used this patch, the performance was:

RESULT CSS: PseudoClassSelectors= 3367.74473886 runs/s
median= 3367.12072755 runs/s, stdev= 14.1464547639 runs/s, min= 3348.55881171 runs/s, max= 3395.98212857 runs/s

Test: PerformanceTests/CSS/PseudoClass-Selectors.html

  • css/SelectorChecker.cpp:

(WebCore):
(WebCore::SelectorChecker::checkSelector): Make this a template method to accept another Context type.
Another Context type will be introduced in coming patch.
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::DOMTraversalStrategy::isFirstChild):
(WebCore::SelectorChecker::DOMTraversalStrategy::isLastChild):
(WebCore::SelectorChecker::DOMTraversalStrategy::isFirstOfType):
(WebCore::SelectorChecker::DOMTraversalStrategy::isLastOfType):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsBefore):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsOfTypeBefore):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsAfter):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsOfTypeAfter):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
(SelectorCheckingContext):
(SelectorChecker):
(DOMTraversalStrategy): Extracted the DOM traversal code from SelectorChecker. Another traversal code
will be introduced the coming patch.

9:44 PM Changeset in webkit [130458] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

Update some picker tests for input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=98390

Follow up of r130433. We still need offsetTop access.

  • fast/forms/date/calendar-picker-common.js:

(openPicker):

  • fast/forms/resources/suggestion-picker-common.js:

(openPicker):

  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html:

Remove unnecessary width style.

9:37 PM Changeset in webkit [130457] by tony@chromium.org
  • 19 edits
    1 add in trunk/LayoutTests

Convert some flexbox tests to run in mozilla
https://bugs.webkit.org/show_bug.cgi?id=98464

Reviewed by Ojan Vafai.

Move properties with a small number of values into resources/flexbox.css
and start using it in some flexbox tests.

  • css3/flexbox/align-absolute-child.html:
  • css3/flexbox/align-baseline-expected.html:
  • css3/flexbox/align-baseline.html:
  • css3/flexbox/anonymous-block-merge-crash.html:
  • css3/flexbox/anonymous-block.html:
  • css3/flexbox/auto-height-dynamic.html:
  • css3/flexbox/auto-margins.html:
  • css3/flexbox/box-sizing-min-max-sizes.html:
  • css3/flexbox/box-sizing.html:
  • css3/flexbox/child-overflow-expected.html:
  • css3/flexbox/child-overflow.html:
  • css3/flexbox/columns-auto-size.html:
  • css3/flexbox/columns-height-set-via-top-bottom.html:
  • css3/flexbox/content-height-with-scrollbars.html:
  • css3/flexbox/cross-axis-scrollbar.html:
  • css3/flexbox/flex-algorithm-min-max.html:
  • css3/flexbox/flex-algorithm-with-margins.html:
  • css3/flexbox/flex-algorithm.html:
  • css3/flexbox/resources/flexbox.css: Added.
9:22 PM Changeset in webkit [130456] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

SVGAttributeHashTranslator does not need to copy QualifiedName in the common case
https://bugs.webkit.org/show_bug.cgi?id=98473

Reviewed by Adam Barth.

I tested this using instruments on a test case which modified SVG attributes in a loop.
I believe pdr has some perf-tests in this area, but they weren't needed here. A simple sample showed this as a huge win,
since we're no longer creating a QualifiedName (and thus adding it to the hash) on each QualifiedName-based lookup in SVG.

  • svg/SVGElement.h:

(WebCore::SVGAttributeHashTranslator::hash):
(WebCore::SVGAttributeHashTranslator::equal):

9:14 PM Changeset in webkit [130455] by aelias@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Scale plugin container by frameScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=98468

Reviewed by Adam Barth.

Plugin containers (for invalid plugins) weren't taking into account
frameScaleFactor, looking cut off when that was non-1.

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::paint):

8:56 PM Changeset in webkit [130454] by jchaffraix@webkit.org
  • 5 edits in trunk/Source/WebCore

Split the intrinsic padding update code out of RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=98454

Reviewed by Eric Seidel.

RenderTableSection::layoutRows is very long and it's difficult to see what's
going on. This change moves the intrinsic padding update code into RenderTableCell
for clarity. While at it, cleaned up a bit the code (renaming variables, functions).

Change covered by existing table tests.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeIntrinsicPadding):
Added this new function that does the update. Removed the 'default' case, replaced by
the explicit label BASELINE_MIDDLE.

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::setIntrinsicPaddingBefore):
(WebCore::RenderTableCell::setIntrinsicPaddingAfter):
(WebCore::RenderTableCell::setIntrinsicPadding):
Moved those setters to the private section as we want other classes
to use computeIntrinsicPadding.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
Replaced the code with a call to RenderTableCell::computeIntrinsicPadding.
Also moved 2 variables in the loop per our coding style.

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::rowBaseline):
Renamed to match our coding style.

8:18 PM Changeset in webkit [130453] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Fix the Qt build by removing an errant paste at the top of the file.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
7:55 PM Changeset in webkit [130452] by dpranke@chromium.org
  • 2 edits
    2 copies
    1 move
    1 add in trunk/LayoutTests

Update chromium baselines for 5006779.html and paint-subrect-grid.html.

Unreviewed, rebaselining.

Updates after r130425 and r130411.

  • platform/chromium-linux/fast/images/paint-subrect-grid-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png.
  • platform/chromium-win-xp/editing/pasteboard/5006779-expected.png: Added.
  • platform/chromium-win-xp/editing/pasteboard/5006779-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/5006779-expected.txt.
  • platform/chromium-win/editing/pasteboard/5006779-expected.txt:
  • platform/chromium/fast/images/paint-subrect-grid-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png.
7:47 PM Changeset in webkit [130451] by hclam@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewd. Chromium DEPS roll. Update to r160281.

  • DEPS:
7:37 PM Changeset in webkit [130450] by ryuan.choi@samsung.com
  • 6 edits
    2 adds in trunk

[EFL][WK2] Add APIs to get/set the frame flattening.
https://bugs.webkit.org/show_bug.cgi?id=95982

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Added new APIs and test case to support frame flattening.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_enable_frame_flattening_set):
(ewk_settings_enable_frame_flattening_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/resources/frame_flattening_test.html: Added.
  • UIProcess/API/efl/tests/resources/frame_flattening_test_subframe.html: Added.
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

Tools:

  • MiniBrowser/efl/main.c: Added frame flattening option to test.

(browserCreate):
(main):

7:31 PM Changeset in webkit [130449] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

Crash in EventHandler::mouseMoved().
https://bugs.webkit.org/show_bug.cgi?id=98460

Reviewed by Abhishek Arya.

No new tests, this fixes fast/events/mouse-moved-remove-frame-crash.html.

  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):

7:30 PM Changeset in webkit [130448] by pilgrim@chromium.org
  • 41 edits in trunk/Source/WebKit/chromium

[Chromium] Update some #includes for Platform directory
https://bugs.webkit.org/show_bug.cgi?id=98440

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

  • src/ApplicationCacheHost.cpp:
  • src/AssociatedURLLoader.h:
  • src/AsyncFileWriterChromium.cpp:
  • src/AudioDestinationChromium.h:
  • src/AutofillPopupMenuClient.cpp:
  • src/ChromeClientImpl.cpp:
  • src/ContextMenuClientImpl.cpp:
  • src/DeliveredIntentClientImpl.h:
  • src/DragClientImpl.cpp:
  • src/DragScrollTimer.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/InspectorClientImpl.cpp:
  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp:
  • src/NotificationPresenterImpl.cpp:
  • src/PageWidgetDelegate.h:
  • src/SocketStreamHandle.cpp:
  • src/SocketStreamHandleInternal.h:
  • src/SpeechInputClientImpl.cpp:
  • src/StorageAreaProxy.cpp:
  • src/StorageNamespaceProxy.cpp:
  • src/UserMediaClientImpl.cpp:
  • src/WebAccessibilityObject.cpp:
  • src/WebAnimationControllerImpl.cpp:
  • src/WebCommon.cpp:
  • src/WebDOMEventListenerPrivate.h:
  • src/WebDOMMessageEvent.cpp:
  • src/WebDOMStringList.cpp:
  • src/WebDataSourceImpl.cpp:
  • src/WebDatabase.cpp:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:
  • src/WebDocument.cpp:
  • src/WebDocumentType.cpp:
  • src/WebDragData.cpp:
  • src/WebElement.cpp:
  • src/WebEntities.cpp:
  • src/WebFileChooserCompletionImpl.h:
  • src/WebFileSystemCallbacksImpl.cpp:
  • src/WebFontImpl.cpp:
7:26 PM Changeset in webkit [130447] by noel.gordon@gmail.com
  • 53 edits in trunk/LayoutTests

[chromium] Unreviewed. Rebaseline mac/win results after r130355
https://bugs.webkit.org/show_bug.cgi?id=98472

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-10-04

  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/fast/clip/overflow-border-radius-combinations-expected.png:
  • platform/chromium-mac/fast/clip/overflow-border-radius-fixed-position-expected.png:
  • platform/chromium-mac/fast/clip/overflow-border-radius-transformed-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-strict-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.png:
  • platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.png:
  • platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.png:
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-strict-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium/TestExpectations:
7:18 PM Changeset in webkit [130446] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] NotificationCenter leaks because it uses buggy custom bindings
https://bugs.webkit.org/show_bug.cgi?id=98445

Reviewed by Tony Chang.

There's no reason to use custom bindings here. All they do is cause leaks..

  • Modules/notifications/NotificationCenter.idl:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
7:16 PM Changeset in webkit [130445] by keishi@webkit.org
  • 4 edits
    2 copies in branches/chromium/1271

Merge 130008 - REGRESSION(r127727): Calendar picker is ignoring step
https://bugs.webkit.org/show_bug.cgi?id=97893

Reviewed by Kent Tamura.

Source/WebCore:

There were two mistakes:

  • An if-statement to check step attribute validity was wrong, and
  • DateTiemChooserParameters.step was milleseconds when it should be number of days.

This will be changing the DateTimeChooserParameters.step to milliseconds so we can handle steps for other input types in the future.

Test: fast/forms/date/calendar-picker-appearance-with-step.html

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker):

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup): If statement was wrong.

LayoutTests:

  • fast/forms/date/calendar-picker-appearance-with-step-expected.txt: Added.
  • fast/forms/date/calendar-picker-appearance-with-step.html: Added.

TBR=keishi@webkit.org

7:04 PM Changeset in webkit [130444] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk

Selector specificity categories "overflow" into higher categories
https://bugs.webkit.org/show_bug.cgi?id=98295

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-04
Reviewed by Eric Seidel.

This patch adds per-component overflow guards for CSS selector specificity.
Previously, we didn't guard against overflow.
Since we stored each component as a byte mapped into a single unsigned int for the whole specificity,
256 of a particular simple selector was equivalent to 1 of the next-higher-group selector.
This violated the Selectors specification,
which requires the components to be compared lexicographically.

Tests: /fast/selectors/specificity-overflow.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::specificity):

7:03 PM Changeset in webkit [130443] by enrica@apple.com
  • 8 edits
    2 adds in trunk

Font::glyphDataAndPageForCharacter doesn't account for text orientation when using systemFallback on a cold cache.
https://bugs.webkit.org/show_bug.cgi?id=98452.

Reviewed by Dan Bernstein.

Source/WebCore:

The text orientation was considered only when there is a cache hit.
This change moves the logic to handle text orientation to a separate
inline function that is called also when the glyph is added to the cache.

Test: fast/text/vertical-rl-rtl-linebreak.html

  • platform/graphics/FontFastPath.cpp:

(WebCore::applyTextOrientationForCharacter): Added.
(WebCore::Font::glyphDataAndPageForCharacter): Modified to use the new function in
both cases of cold and warm cache.

LayoutTests:

The new test adds platform specific results for Mac, since it uses system fallback fonts.
I've added the expected failure for all the other platforms.

  • fast/text/vertical-rl-rtl-linebreak.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
6:57 PM FeatureFlags edited by tkent@chromium.org
Remove LEGACY_WEBKIT_BLOB_BUILDER. Add INPUT_TYPE_DATE_LEGACY_UI (diff)
6:02 PM Changeset in webkit [130442] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

MutationRecord attributeName should be null for non attribute changes
https://bugs.webkit.org/show_bug.cgi?id=98438

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/mutation/mutation-record-nullity.html

  • dom/MutationRecord.idl:

LayoutTests:

  • fast/mutation/mutation-record-nullity-expected.txt: Added.
  • fast/mutation/mutation-record-nullity.html: Added.
5:54 PM Changeset in webkit [130441] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

TiledCoreAnimationDrawingArea.mm should not include RenderLayerCompositor.h
https://bugs.webkit.org/show_bug.cgi?id=98471

Reviewed by Dean Jackson.

Remove #import of <WebCore/RenderLayerCompositor.h> from this file.
It is not required.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
5:46 PM Changeset in webkit [130440] by rniwa@webkit.org
  • 6 edits
    1 delete in trunk/LayoutTests

More Qt rebaselines after r130411.

  • platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-021-expected.txt:
  • platform/qt/editing/pasteboard/5006779-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Removed.
5:43 PM Changeset in webkit [130439] by Simon Fraser
  • 58 edits in trunk/Source

Final part of "sync" to "flush" renaming
https://bugs.webkit.org/show_bug.cgi?id=98430

Reviewed by Tim Horton.

Change method names on GraphicsLayer and GraphicsLayerClient that
refer to "sync" to use the term "flush" instead, to be consistent
with the rest of the code.

Source/WebCore:

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::flushCompositingState):
(WebCore::GraphicsLayer::flushCompositingStateForThisLayerOnly):

  • platform/graphics/GraphicsLayerClient.h:

(GraphicsLayerClient):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(WebCore::GraphicsLayerBlackBerry::notifyFlushRequired):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::setNeedsCommit):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::flushCompositingState):
(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
(WebCore::GraphicsLayerCA::positionForCloneRootLayer):
(WebCore::GraphicsLayerCA::noteLayerPropertyChanged):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::flushCompositingState):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::flushCompositingState):
(WebCore::TextureMapperLayer::flushCompositingStateSelf):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::notifyFlushRequired):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

  • rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::notifyFlushRequired):

Source/WebKit/blackberry:

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyFlushRequired):

  • Api/WebOverlay_p.h:

(WebOverlayPrivateWebKitThread):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/DefaultTapHighlight.cpp:

(BlackBerry::WebKit::DefaultTapHighlight::notifyFlushRequired):

  • WebKitSupport/DefaultTapHighlight.h:

(DefaultTapHighlight):

  • WebKitSupport/InspectorOverlayBlackBerry.cpp:

(BlackBerry::WebKit::InspectorOverlay::notifyFlushRequired):

  • WebKitSupport/InspectorOverlayBlackBerry.h:

(InspectorOverlay):

  • WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::notifyFlushRequired):

  • WebKitSupport/SelectionOverlay.h:

(SelectionOverlay):

Source/WebKit/efl:

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp:

(WebCore::AcceleratedCompositingContext::syncLayersNow):
(WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):

Source/WebKit/gtk:

  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext):

  • WebCoreSupport/AcceleratedCompositingContextCairo.cpp:

(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebKit::AcceleratedCompositingContext::resizeRootLayer):
(WebKit::AcceleratedCompositingContext::syncLayersNow):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):

  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp:

(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):

Source/WebKit/mac:

  • WebView/WebView.mm:

Source/WebKit/qt:

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::TextureMapperLayerClientQt::syncRootLayer):

Source/WebKit/win:

  • WebView.cpp:

(WebView::notifyFlushRequired):
(WebView::flushPendingGraphicsLayerChanges):

  • WebView.h:

Source/WebKit2:

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::paintToCurrentGLContext):
(WebKit::LayerTreeRenderer::flushLayerChanges):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(WebKit::LayerTreeRenderer::notifyFlushRequired):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::didChangeLayerState):
(WebCore::CoordinatedGraphicsLayer::didChangeAnimatedProperties):
(WebCore::CoordinatedGraphicsLayer::didChangeChildren):
(WebCore::CoordinatedGraphicsLayer::didChangeFilters):
(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
(WebCore::CoordinatedGraphicsLayer::setContentsToCanvas):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::notifyFlushRequired):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::notifyFlushRequired):
(WebKit::LayerTreeHostCA::flushPendingLayerChanges):

  • WebProcess/WebPage/ca/LayerTreeHostCA.h:

(LayerTreeHostCA):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::notifyFlushRequired):
(WebKit::LayerTreeHostGtk::flushPendingLayerChanges):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

(LayerTreeHostGtk):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::notifyFlushRequired):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

5:41 PM Changeset in webkit [130438] by rniwa@webkit.org
  • 22 edits in trunk/LayoutTests

GTK+ rebaselines after r130411.

  • platform/gtk/editing/deleting/delete-block-merge-contents-018-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-021-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-022-expected.txt:
  • platform/gtk/editing/deleting/merge-no-br-expected.txt:
  • platform/gtk/editing/execCommand/find-after-replace-expected.txt:
  • platform/gtk/editing/execCommand/paste-2-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/pasteboard/5006779-expected.txt:
  • platform/gtk/editing/pasteboard/5028447-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/gtk/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/gtk/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/gtk/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/gtk/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/fast/lists/drag-into-marker-expected.txt:
5:35 PM Changeset in webkit [130437] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

1ex should equal .5em when the font has no x-height metric
https://bugs.webkit.org/show_bug.cgi?id=80360

Patch by Tab Atkins <tabatkins@google.com> on 2012-10-04
Reviewed by Eric Seidel.

Source/WebCore:

Updated FontMetrics and CSSPrimitiveValue to have/use an explicit "hasXHeight" flag to determine how to size an 'ex' unit.

Updated a few of the platform font files to set the flag properly.

Patch cleanup by David Barr <davidbarr@chromium.org>.

Test: fast/css/ex-unit-with-no-x-height.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLengthDouble):

  • platform/graphics/FontMetrics.h:

(WebCore::FontMetrics::FontMetrics):
(WebCore::FontMetrics::setXHeight):
(FontMetrics):
(WebCore::FontMetrics::hasXHeight):
(WebCore::FontMetrics::setHasXHeight):
(WebCore::FontMetrics::reset):

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformInit):

LayoutTests:

If a font has no x-height metric, 1ex should equal .5em.

Test layout tweaked by David Barr <davidbarr@chromium.org>.

  • fast/css/ex-unit-with-no-x-height-expected.txt: Added.
  • fast/css/ex-unit-with-no-x-height.html: Added.
5:34 PM Changeset in webkit [130436] by dpranke@chromium.org
  • 2 edits in trunk/Source/WTF

Unreviewed, rolling out r130419.
http://trac.webkit.org/changeset/130419
https://bugs.webkit.org/show_bug.cgi?id=98406

broke editing/pasteboard/data-transfer-items.html on chromium

  • wtf/HashTraits.h:
4:52 PM Changeset in webkit [130435] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] New test introduced in r129346 inspector-protocol/css-getSupportedCSSProperties.html fails
https://bugs.webkit.org/show_bug.cgi?id=97451

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Unskipping this test that is passing.

  • platform/qt/TestExpectations:
4:51 PM Changeset in webkit [130434] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Implement PageClientImpl::isViewVisible()
https://bugs.webkit.org/show_bug.cgi?id=98249

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Implement PageClientImpl::isViewVisible() for EFL port
by calling evas_object_visible_get() on the view.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::isViewVisible):

4:50 PM Changeset in webkit [130433] by tkent@chromium.org
  • 12 edits in trunk/LayoutTests

Update some picker tests for input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=98390

Reviewed by Daniel Bates.

r130375 changed a behavior. A key bind to open a calendar picker
or a suggestion picker was changed from "Down" to "Alt + Down". We
need to update tests which open pickers for input[type=date].

  • fast/forms/date/calendar-picker-appearance-expected.txt:
  • fast/forms/date/calendar-picker-appearance-pre-100.html:

Use openPicker() in calendar-picker-common.js.

  • fast/forms/date/calendar-picker-appearance.html: Ditto.
  • fast/forms/date/calendar-picker-common.js:

(openPicker): Specify Alt modifier.
(sendKey): Add ctrlKey and altKey flags.

  • fast/forms/date/calendar-picker-with-step.html:

Use openPicker() in calendar-picker-common.js.

  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html:

Use openPicker() in suggestion-picker-common.js

  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html:

Ditto.

  • platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html:

Ditto.

  • platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt:
  • platform/chromium/fast/forms/date/date-suggestion-picker-key-operations.html:

Use openPicker() and sendKey() in suggestion-picker-common.js.
Increase the internal timeout because it was too short on my machine.

3:54 PM Changeset in webkit [130432] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Improve initial empty process tracking
https://bugs.webkit.org/show_bug.cgi?id=98458

Reviewed by Sam Weinig.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::disconnectProcess): Unset m_haveInitialEmptyProcess if we no longer do.
3:52 PM Changeset in webkit [130431] by Lucas Forschler
  • 1 copy in tags/Safari-534.58.1

New Tag.

3:45 PM Changeset in webkit [130430] by hclam@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Chromium rebaselines.

Rebaseline pixel results after r130412.

  • platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
3:40 PM Changeset in webkit [130429] by rniwa@webkit.org
  • 4 edits in trunk

Source/WebCore: Build fix after r130411. Add the right offset.
Also use RefPtr instead of a raw pointer for next and previous pointers.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition):

LayoutTests: Another rebaseline needed after r130411.

  • platform/mac/editing/pasteboard/5006779-expected.txt:
3:38 PM Changeset in webkit [130428] by alecflett@chromium.org
  • 30 edits in trunk/Source

IndexedDB: promote objectstore/index backend ids to the frontend
https://bugs.webkit.org/show_bug.cgi?id=97834

Reviewed by Tony Chang.

Source/WebCore:

Expose int64-based database/objectStore/index ids to the renderer,
step 1 of 2. Support both styles of createObjectStore and
createIndex: those that take an explicit id, and those that take
-1, meaning to autogenerate an id on the backend. In part 2, after
the chromium side lands, support for the autogenerated ids will be
removed. (See https://bugs.webkit.org/show_bug.cgi?id=98085)

This is a part of larger refactoring work to ultimately make the interface
between the frontend and the backend simpler.

No new tests, extensive ASSERTs and existing tests cover correctness.

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::metadata):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):
(WebCore::getMaxObjectStoreId):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::setMaxObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::getMaxIndexId):
(WebCore::setMaxIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
(IDBDatabaseMetadata):
(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):
(IDBObjectStoreMetadata):
(WebCore::IDBIndexMetadata::IDBIndexMetadata):
(IDBIndexMetadata):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::create):
(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

Support for marshalling additional IDBMetadata and new calls to
createObjectStore/createIndex.

  • public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::createObjectStore):

  • public/WebIDBMetadata.h:

(ObjectStore):
(Index):

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::createIndex):

  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::createObjectStore):
(WebKit):

  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::createObjectStore):
(WebKit):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::createIndex):
(WebKit):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

3:32 PM Changeset in webkit [130427] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] Add libxml 2.8.0 to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=98418

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Laszlo Gombos.

.:

Bump dependency for libxml to 2.8.0 to match
jhbuild.

  • Source/cmake/OptionsEfl.cmake:

Tools:

Add libxml 2.8.0 to EFL's jhbuild for consistency.

  • efl/jhbuild.modules:

LayoutTests:

Unskip fast/xsl/xslt-missing-namespace-in-xslt.xml
since it passes with libxml 2.8.0 and we now depend
on that version.

  • platform/efl/TestExpectations:
3:30 PM Changeset in webkit [130426] by tony@chromium.org
  • 5 edits
    1 copy
    1 move
    9 adds in trunk/LayoutTests

Unreviewed gardening. Landing render tree results for css3/flexbox/flexbox-baseline.html.
https://bugs.webkit.org/show_bug.cgi?id=98306

This pixel test was added in r130405.

  • platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/chromium-win/css3/flexbox/flexbox-baseline-expected.txt: Copied from LayoutTests/platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt.
  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/mac/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/qt/TestExpectations:
  • platform/qt/css3/flexbox/flexbox-baseline-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt.
3:23 PM Changeset in webkit [130425] by hclam@chromium.org
  • 1 edit
    1 copy
    1 move in trunk/LayoutTests

Unreviewed. Chromium rebaselines.

  • platform/chromium-mac/fast/images/paint-subrect-grid-expected.png: Copied from LayoutTests/platform/chromium/fast/images/paint-subrect-grid-expected.png.
  • platform/chromium-win/fast/images/paint-subrect-grid-expected.png: Renamed from LayoutTests/platform/chromium/fast/images/paint-subrect-grid-expected.png.
1:27 PM Changeset in webkit [130424] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Crash in Safari at com.apple.JavaScriptCore: WTF::StringImpl::is8Bit const + 12
https://bugs.webkit.org/show_bug.cgi?id=98433

Reviewed by Jessie Berlin.

The problem is due to a String with a null StringImpl (i.e. a null string).
Added a length check before the is8Bit() check since length() checks for a null StringImpl. Changed the
characters16() call to characters() since it can handle a null StringImpl as well.

  • API/JSValueRef.cpp:

(JSValueMakeFromJSONString):

1:18 PM Changeset in webkit [130423] by rniwa@webkit.org
  • 34 edits
    1 add
    1 delete in trunk/LayoutTests

Chromium rebaselines after r130411.

  • platform/chromium-linux-x86/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium-linux/editing/pasteboard/4944770-2-expected.txt:
  • platform/chromium-linux/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
  • platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-008-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-xml-expected.txt: Added.
  • platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium-win-xp/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-018-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-021-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-022-expected.txt:
  • platform/chromium-win/editing/deleting/merge-no-br-expected.txt:
  • platform/chromium-win/editing/execCommand/find-after-replace-expected.txt:
  • platform/chromium-win/editing/execCommand/paste-1-expected.txt:
  • platform/chromium-win/editing/execCommand/paste-2-expected.txt:
  • platform/chromium-win/editing/pasteboard/4944770-2-expected.txt:
  • platform/chromium-win/editing/pasteboard/5028447-expected.txt:
  • platform/chromium-win/editing/pasteboard/8145-3-expected.txt:
  • platform/chromium-win/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-008-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-009-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/chromium-win/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/unrendered-br-expected.txt:
  • platform/chromium-win/fast/lists/drag-into-marker-expected.txt:
1:09 PM Changeset in webkit [130422] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Layout broken after cloning and re-inserting a table with a misplaced <form>
https://bugs.webkit.org/show_bug.cgi?id=86746

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-10-04
Reviewed by Julien Chaffraix.

Source/WebCore:

There is a concept of demotion for a <form> contained in a table. A <form> is demoted if its immediate parent
is either a <table>, table sections (tbody, etc) or a table row (tr). A renderer for such a <form> is created only
if its display is one of the table display types (TABLE, INLINE_TABLE, TABLE_FOOTER_GROUP, etc).
However when a <table> containing a demoted <form> is cloned, the <form> does not retain its demotion state and
results in the table getting improperly rendered.

Test: fast/table/form-with-non-table-display-inside-table-elements.html

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::copyNonAttributePropertiesFromElement):

Extended the virtual function for HTMLFormElement class specific implementation.
The function is used to copy any necessary state information(member variables) associated with
the <form> element being cloned to the current node.
For HTMLFormElement node the member variable can be classified into five groups based on the
information they hold:

1) Variables containing information regarding <form> subtree and elements associated with it.

These get updated as and when an element is added to the <form> subtree.

2) Variables containing <form> submit state information.
3) Flag to hold information if reset() has been called.
4) Flag(m_wasDemoted) that indicates whether the form is demoted or not, based on which it needs to

be handled differently during creation of its renderer.
This information is currently being updated only during the HTML tree construction phase.

5) Flag(m_wasMalformed) to hold information if the <form> is malformed or not.

Variables of group (1) will be updated as and when elements are added to the <form> subtree. Whereas,
(2) and (3) hold instance specific information, thus copying them is not required. Also (5) is currently not
being used(not set by any code).

On the other hand, (4) is required to be copied during cloning as this information cannot be accessed
during the cloning process.

(WebCore):

  • html/HTMLFormElement.h: Added copyNonAttributePropertiesFromElement() declaration.

LayoutTests:

  • fast/table/form-with-non-table-display-inside-table-elements-expected.txt: Added.
  • fast/table/form-with-non-table-display-inside-table-elements.html: Added.
1:01 PM Changeset in webkit [130421] by rniwa@webkit.org
  • 20 edits in trunk/LayoutTests

Qt rebaseline after r130411.

  • platform/qt/editing/deleting/delete-block-merge-contents-018-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-022-expected.txt:
  • platform/qt/editing/deleting/merge-no-br-expected.txt:
  • platform/qt/editing/execCommand/find-after-replace-expected.txt:
  • platform/qt/editing/execCommand/paste-1-expected.txt:
  • platform/qt/editing/execCommand/paste-2-expected.txt:
  • platform/qt/editing/pasteboard/4944770-2-expected.txt:
  • platform/qt/editing/pasteboard/5006779-expected.txt:
  • platform/qt/editing/pasteboard/5028447-expected.txt:
  • platform/qt/editing/pasteboard/8145-3-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-008-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-009-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/qt/editing/pasteboard/unrendered-br-expected.txt:
12:57 PM Changeset in webkit [130420] by Lucas Forschler
  • 1 copy in tags/Safari-537.13

New Tag.

12:49 PM Changeset in webkit [130419] by kling@webkit.org
  • 2 edits in trunk/Source/WTF

Lower minimum table size of WTF::HashTable to reduce memory usage.
<http://webkit.org/b/98406>
<rdar://problem/12432140>

Reviewed by Anders Carlsson.

Lower the default minimumTableSize for WTF hash tables from 64 to 8 entries.
This reduces WebProcess memory consumption by ~16MB on Membuster3 (a 6% progression!)

No significant movement on PLT or JSC benchmarks on my machine. If there's a perf regression somewhere
from this, we can tweak individual tables to have a larger minimumTableSize.

  • wtf/HashTraits.h:
12:34 PM Changeset in webkit [130418] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Use copyLCharsFromUCharSource() for IdentifierLCharFromUCharTranslator translation
https://bugs.webkit.org/show_bug.cgi?id=98335

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-04
Reviewed by Michael Saboff.

Michael Saboff added an optimized version of UChar->LChar conversion in r125846.
Use this function in JSC::Identifier.

  • runtime/Identifier.cpp:

(JSC::IdentifierLCharFromUCharTranslator::translate):

12:31 PM Changeset in webkit [130417] by dino@apple.com
  • 13 edits in trunk

Attribute and Uniform variable names need translation in shader
https://bugs.webkit.org/show_bug.cgi?id=70989

Reviewed by Tim Horton (and Darin Adler).

Source/WebCore:

WebGL specifies some maximum lengths for variable names (attributes
and uniforms). Also, some GL drivers have issues with long names. For
that reason, ANGLE has an option to rewrite the shader, translating
long names into short names. Turning this on helps shaders compile,
but we need to keep a mapping between the original names and the
translated names, so that we bind to the right location from user code
(which won't ever see the translated source).

This provided an opportunity to clean up some other bits of code:
CSS Filters examined the uniform names after a compilation; It can
now use the variable name map. I also added a typedef for the
HashMaps that keep the shader, the source code and the variable name
mappings.

I also opened a followup bug to make sure these tables are deleted
when the associated shaders (or linked programs) go away:
https://bugs.webkit.org/show_bug.cgi?id=98204

Covered by existing tests (with some enhancements):

  • fast/canvas/webgl/attrib-location-length-limits.html:
  • fast/canvas/webgl/uniform-location-length-limits.html:
  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::getSymbolInfo): Extracts all the information on symbols (either attributes
or uniforms) from the newly compiled shader.
(WebCore):
(WebCore::ANGLEWebKitBridge::compileShaderSource): New method name.

  • platform/graphics/ANGLEWebKitBridge.h:

(WebCore::getUniforms): Deleted this method.
(WebCore::ANGLEShaderSymbol::isSampler): Make sure the symbol is a uniform.
(ANGLEWebKitBridge):

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::SymbolInfo::SymbolInfo): A new object that
holds the size, type and translated name of a symbol from a WebGL shader.
(ShaderSourceEntry):
(WebCore::GraphicsContext3D::ShaderSourceEntry::ShaderSourceEntry): Now keeps track
of the translated source code and symbol mappings.
(WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap): Helper function to
get the member variable corresponding to the type of symbol you're asking fo.

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram): Calls new method
name which also produces a set of symbols to examine.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): We now can pass
in some extra compile options to do translation of long symbol names. Also fill the
map of translated symbol names.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::mappedSymbolName): Returns the mapped name for
a shader symbol if it was translated during compilation.
(WebCore):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getUniformLocation):

LayoutTests:

Added subtests to exercise variables that are well under the limits but
not long enough to produce an error. This way we now test all three options:
under the limit, at the limit, over the limit.

Also, the tests are unskipped on Mac.

  • fast/canvas/webgl/attrib-location-length-limits-expected.txt:
  • fast/canvas/webgl/attrib-location-length-limits.html:
  • fast/canvas/webgl/uniform-location-length-limits-expected.txt:
  • fast/canvas/webgl/uniform-location-length-limits.html:
  • platform/mac/TestExpectations:
12:10 PM Changeset in webkit [130416] by benjamin@webkit.org
  • 31 edits
    2 adds in trunk

[WK2] Support all attributes of GeolocationPosition
https://bugs.webkit.org/show_bug.cgi?id=98212

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-03
Reviewed by Sam Weinig.

Source/WebKit/mac:

Add an internal constructor for the sake of testing.
A similar API is used on iOS.

  • WebView/WebGeolocationPosition.mm:

(-[WebGeolocationPosition initWithGeolocationPosition:]):

Source/WebKit2:

Add complete support for GeolocationPosition.

  • Shared/WebGeolocationPosition.cpp:

(WebKit::WebGeolocationPosition::WebGeolocationPosition):
(WebKit::WebGeolocationPosition::Data::encode):
(WebKit::WebGeolocationPosition::Data::decode):

  • Shared/WebGeolocationPosition.h:

(Data):
(WebKit::WebGeolocationPosition::create):
(WebKit::WebGeolocationPosition::canProvideAltitude):
(WebKit::WebGeolocationPosition::altitude):
(WebGeolocationPosition):
(WebKit::WebGeolocationPosition::canProvideAltitudeAccuracy):
(WebKit::WebGeolocationPosition::altitudeAccuracy):
(WebKit::WebGeolocationPosition::canProvideHeading):
(WebKit::WebGeolocationPosition::heading):
(WebKit::WebGeolocationPosition::canProvideSpeed):
(WebKit::WebGeolocationPosition::speed):
WebGeolocationPosition mirror the attributes of WebCore::GeolocationPosition.

  • UIProcess/API/C/WKGeolocationPosition.cpp:

(WKGeolocationPositionCreate):
(WKGeolocationPositionCreate_b):
Add a new API exposing all the arguments.

  • UIProcess/API/C/WKGeolocationPosition.h:
  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):

Tools:

Expand WebKitTestRunner and DumpRenderTree to test all the attributes
of GeolocationPosition.

  • DumpRenderTree/TestRunner.cpp:

(setMockGeolocationPositionCallback):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::setMockGeolocationPosition):

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::setMockGeolocationPosition):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setMockGeolocationPosition):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setMockGeolocationPosition):

  • DumpRenderTree/wx/TestRunnerWx.cpp:

(TestRunner::setMockGeolocationPosition):

  • WebKitTestRunner/GeolocationProviderMock.cpp:

(WTR::GeolocationProviderMock::setPosition):

  • WebKitTestRunner/GeolocationProviderMock.h:

(GeolocationProviderMock):

  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(_platformTypeVariableDeclaration):
Use a proper constructor for the JSValueRef, it is an opaque type, we are not supposed
to build the pointer outself.
This is necessary to support optional JSValueRef properly.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::setMockGeolocationPosition):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setMockGeolocationPosition):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::setMockGeolocationPosition):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Add a new test for the exposed attributes. It is disabled everywhere else than
Mac because of the missing DRT features.

  • fast/dom/Geolocation/coordinates-interface-attributes-expected.txt: Added.
  • fast/dom/Geolocation/coordinates-interface-attributes.html: Added.
  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
11:58 AM Changeset in webkit [130415] by rakuco@webkit.org
  • 3 edits in trunk/Tools

Make the Xvfb driver recognize `X' as a valid X server binary.
https://bugs.webkit.org/show_bug.cgi?id=98434

Reviewed by Dirk Pranke.

The X server binary can also be called `X', so account for that
possibility in the _next_free_display regexp.

Additionally, make the regular expression require at least one
space character after the `ps comm' part.

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._next_free_display):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:

(XvfbDriverTest.test_next_free_display):

11:50 AM Changeset in webkit [130414] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Accept WEBKITOUTPUTDIR in Port._setup_environ_for_server.
https://bugs.webkit.org/show_bug.cgi?id=98436

Reviewed by Dirk Pranke.

The Xvfb driver (ab)uses Port._setup_environ_for_server() to set
the environment for the server process, and the WEBKITOUTPUTDIR
environment variable was not being passed through, causing the
build directory to be wrongfully set to WebKitBuild/ all the time.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.setup_environ_for_server):

11:49 AM Changeset in webkit [130413] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

After r130344, OpaqueJSString() creates a empty string which should be a null string
https://bugs.webkit.org/show_bug.cgi?id=98417

Reviewed by Alexey Proskuryakov.

Removed the setting of enclosed string to an empty string from default constructor.
Before changeset r130344, the semantic was the default constructor produced a null
string.

  • API/OpaqueJSString.h:

(OpaqueJSString::OpaqueJSString):

11:40 AM Changeset in webkit [130412] by hclam@chromium.org
  • 6 edits
    11 adds in trunk

[skia] Drawing a subrect of bitmap image is misaligned
https://bugs.webkit.org/show_bug.cgi?id=95121

Reviewed by Stephen White.

Source/WebCore:

When drawing a subrect of BitmapImage and the subrect is not aligned
to integer boundaries, skia expands it to the closest enclosing integer
rectangle. This creates prominent rendering artifacts when an image
is used as background and its sub-regions are invalidated frequently.

This patch fixes the problem by doing alignment to integer boundaries
and clipping for both cases of RESAMPLE_AWESOME and RESAMPLE_LINEAR.

A clip rect is applied to the canvas using original destination
rectangle, while source and destination rectangles are enlarged
appropriately to ensure source rectangle is aligned.

This patch also fixes a closely related problem. In RESAMPLE_AWESOME
resampling mode the previous algorithm applies different approximated
scale factor for each scaled image fragment. This caused the stitched
image to look ugly.

Scale factor is approximated using entire image size, this gives a
more accurate approximation because of greater denominator and a
consistent scale factor across all fragments.

Changes in Skia enable caching of the scaled image and return the
scaled fragment because scale factor is now consistent for all
fragments.

Tests: fast/images/paint-subrect-grid.html

fast/images/paint-subrect.html
fast/images/repaint-subrect-grid.html

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::computeResamplingMode): Use float for width and height.
(WebCore):
(WebCore::areBoundariesIntegerAligned):
(WebCore::computeBitmapDrawRects):
(WebCore::extractScaledImageFragment):
(WebCore::drawResampledBitmap): New algorithm for drawing scaled image fragment.
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw): Use SkRect instead of SkIRect.
(WebCore::BitmapImageSingleFrameSkia::draw):

  • platform/graphics/skia/NativeImageSkia.cpp:

Changing the algorithm for extracting a scaled image fragment.
A fragment is now identified by (scaledImageSize, scaledImageSubset).
(WebCore::NativeImageSkia::hasResizedBitmap):
(WebCore::NativeImageSkia::resizedBitmap):
(WebCore::NativeImageSkia::shouldCacheResampling):
(WebCore::NativeImageSkia::CachedImageInfo::CachedImageInfo):
(WebCore):
(WebCore::NativeImageSkia::CachedImageInfo::isEqual):
(WebCore::NativeImageSkia::CachedImageInfo::set):
(WebCore::NativeImageSkia::CachedImageInfo::rectInSubset):

  • platform/graphics/skia/NativeImageSkia.h:

(NativeImageSkia):
(CachedImageInfo):

LayoutTests:

3 new tests added.

  • fast/images/paint-subrect.html

This test enlarges a 2x1 image in a canvas for easy verification.
2/3 of the image is used as source rectangle to exercise the code path
for partial pixel addressing.

Pixel test result should have 1/3 blue on the left and 2/3 green on the
right with gradient according to interpolation settings.

  • fast/images/paint-subrect-grid.html

Draws a 11x11 image into a canvas in 8 fragments with partial pixels.
Canvas should look just like a single image enlarged.

  • fast/images/repaint-subrect-grid.html

Scale a 31x31 image to 55x55. A blue square moves across the scaled
image such that the image is partially invalidated. After the animation
the image should look the same.

  • fast/images/paint-subrect-expected.txt: Added.
  • fast/images/paint-subrect-grid-expected.txt: Added.
  • fast/images/paint-subrect-grid.html: Added.
  • fast/images/paint-subrect.html: Added.
  • fast/images/repaint-subrect-grid-expected.html: Added.
  • fast/images/repaint-subrect-grid.html: Added.
  • fast/images/resources/grid-large.png: Added.
  • fast/images/resources/grid-small.png: Added.
  • platform/chromium/TestExpectations: Added image failure expectations.
  • platform/chromium/fast/images/paint-subrect-expected.png: Added.
  • platform/chromium/fast/images/paint-subrect-grid-expected.png: Added.
  • platform/chromium/fast/images/repaint-subrect-grid-expected.png: Added.
11:36 AM Changeset in webkit [130411] by rniwa@webkit.org
  • 60 edits in trunk

ReplaceSelectionCommand should merge text nodes
https://bugs.webkit.org/show_bug.cgi?id=98188

Reviewed by Levi Weintraub.

Source/WebCore:

Added mergeTextNodesAroundPosition to ReplaceSelectionCommand to merge text nodes after the replace in
completeHTMLReplacement. Also fixed a bunch of bugs in other classes and functions to make this work.

This behavior change is tested by existing tests.

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): When splitting a text node, place the insertionPosition
at the end of the first half. Leaving it at the beginning of the second half confuses the rest of the code in
the function. However, the logic to handle the "insignificant" white spaces needs the position at the start of
the second half. So keep this position.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Update visibleStart after inserting a paragraph separator so that
the logic to cleanup the nested div checks the right condition (right beneath it starting with a long comment).
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace): Insert a space for smart paste at the appropriate
offset instead of at the end of endNode. Also update the layout before obtaining startDownstream as we may have
modified the DOM by inserting a space for endNode. Finally, a non-breaking space should be treated like a space
isCharacterSmartReplaceExempt for the purpose of smart replace. e.g. if we're inserting "world" after
"hello&nbsp;", we shouldn't be inserting another space between "hello" and "world".
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition): Added. Merge text nodes around position, and
adjust position and positionOnlyToBeUpdated accordingly. We need to call updatePositionForNodeRemoval when
positions were before or after the text node.

  • editing/ReplaceSelectionCommand.h:

(ReplaceSelectionCommand):

LayoutTests:

Rebaselined tests.

  • editing/deleting/merge-paragraphs-with-transparent-background-expected.txt:
  • editing/deleting/paste-with-transparent-background-color-expected.txt:
  • editing/execCommand/outdent-selection-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/avoid-copying-body-with-background-expected.txt:
  • editing/pasteboard/block-wrappers-necessary-expected.txt:
  • editing/pasteboard/drag-drop-list-expected.txt:
  • editing/pasteboard/merge-end-5-expected.txt:
  • editing/pasteboard/paste-before-tab-span-expected.txt:
  • editing/pasteboard/paste-into-table-cell-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-unrendered-select-expected.txt:
  • editing/pasteboard/smart-paste-001-expected.txt:
  • editing/pasteboard/smart-paste-002-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • fast/events/ondragenter-expected.txt:
  • fast/lists/drag-into-marker.html:
  • platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
  • platform/mac/editing/deleting/merge-no-br-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/execCommand/paste-2-expected.txt:
  • platform/mac/editing/pasteboard/4944770-2-expected.txt:
  • platform/mac/editing/pasteboard/5006779-expected.txt:
  • platform/mac/editing/pasteboard/5028447-expected.txt:
  • platform/mac/editing/pasteboard/8145-3-expected.txt:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-004-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-005-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-008-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-009-expected.txt:
  • platform/mac/editing/pasteboard/smart-drag-drop-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/mac/editing/pasteboard/unrendered-br-expected.txt:
10:51 AM Changeset in webkit [130410] by tony@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed, fix flexbox-baseline.html to test the new behavior after r130409.

  • css3/flexbox/flexbox-baseline.html:
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt:
10:46 AM Changeset in webkit [130409] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix <input type="month"> tests
https://bugs.webkit.org/show_bug.cgi?id=98426

Reviewed by Ojan Vafai.

The month picker uses flexbox and assumes that it will be aligned with
the last line box. This looks visually correct. I will follow up on
www-style to see what the expected behavior is.

Tests: fast/forms/month-multiple-fields tests cover this.

  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderFlexibleBox.h:
10:29 AM Changeset in webkit [130408] by tony@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed, fixing expected results for a test that needs a new baseline.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
10:24 AM Changeset in webkit [130407] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r130396.
http://trac.webkit.org/changeset/130396
https://bugs.webkit.org/show_bug.cgi?id=98421

This patch is causing crashes on 4 tests on Lion Debug and
Mountain Lion Debug (Requested by jernoble on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-04

Source/WebCore:

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

  • rendering/RenderLayerCompositor.h:
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:

(Backup):

LayoutTests:

  • compositing/layer-creation/fixed-position-absolute-descendant-expected.txt: Removed.
  • compositing/layer-creation/fixed-position-absolute-descendant.html: Removed.
10:21 AM Changeset in webkit [130406] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Fix r140403 by skipping the right test.

  • platform/efl/TestExpectations:
9:47 AM Changeset in webkit [130405] by tony@chromium.org
  • 10 edits
    3 adds in trunk

inline-flex baseline is sometimes wrong
https://bugs.webkit.org/show_bug.cgi?id=96188

Reviewed by Ojan Vafai.

Source/WebCore:

Implement the necessary methods to get the proper baseline alignment of flexbox.
We were falling back to the inline-block behavior.

Test: css3/flexbox/flexbox-baseline.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::RenderFlexibleBox::baselinePosition): Used to get the baseline of the box.
Mostly just the first line box baseline.
(WebCore):
(WebCore::RenderFlexibleBox::lastLineBoxBaseline): This is used for getting the baseline when in an inline-block.
We actually don't want the last line, but the flexbox's baseline.
(WebCore::RenderFlexibleBox::firstLineBoxBaseline): Compute the baseline according to the rules in the spec.
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): Keep track of the number of children on the
first line so we don't have to re-compute this when getting the baseline.
(WebCore::RenderFlexibleBox::crossAxisExtentForChild): Make const.
(WebCore::RenderFlexibleBox::mainAxisExtentForChild): Make const.
(WebCore::RenderFlexibleBox::hasAutoMarginsInCrossAxis): Make const.

  • rendering/RenderFlexibleBox.h: Add a size_t to keep track of how many children are in the first line.

LayoutTests:

Add a new pixel test and mark the test as failing so we can get pixel results from the bots.

  • css3/flexbox/flexbox-baseline.html: Added.
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
9:45 AM Changeset in webkit [130404] by msaboff@apple.com
  • 3 edits in trunk/Source/WTF

String::remove will convert an 8 bit string to a 16 bit string
https://bugs.webkit.org/show_bug.cgi?id=98299

Reviewed by Benjamin Poulain.

Added an 8 bit path to remove(). Added a private templated helper removeInternal.

  • wtf/text/WTFString.cpp:

(WTF::String::removeInternal):
(WTF::String::remove):

  • wtf/text/WTFString.h:

(String):

9:39 AM Changeset in webkit [130403] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Temporarily skip fast/xsl/xslt-missing-namespace-in-xslt.html.

As bug 91009 shows, libxml 2.8.0 makes us produce a different test
result. Unskip the test for now until we add that version to
jhbuild.

  • platform/efl/TestExpectations:
9:37 AM Changeset in webkit [130402] by wangxianzhu@chromium.org
  • 3 edits
    3 adds in trunk

[Chromium] Should set unitsPerEm in SimpleFontDataSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=98100

Reviewed by Stephen White.

Source/WebCore:

At least on chromium-linux and chromium-android, unitsPerEm was not set
according to the information in the font, causing at least problems in
OpenTypeVerticalData when calculating vertical advance.

Test: fast/writing-mode/vertical-font-vmtx-units-per-em.html

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformInit):

LayoutTests:

  • fast/writing-mode/resources/DroidSansFallback-reduced.ttf: Added.
  • fast/writing-mode/vertical-font-vmtx-units-per-em-expected.txt: Added.
  • fast/writing-mode/vertical-font-vmtx-units-per-em.html: Added.
9:24 AM Changeset in webkit [130401] by rakuco@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

[EFL] Revert some wrong baselines added in r130387.

Thanks to Christophe Dumez and Mikhail Pozdnyakov for the help.

  • platform/efl/compositing/visibility/visibility-simple-video-layer-expected.txt: Removed.
  • platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt:
9:16 AM Changeset in webkit [130400] by Simon Fraser
  • 50 edits in trunk/Source

Standardize on "flush" terminology for compositing layer flushing/syncing
https://bugs.webkit.org/show_bug.cgi?id=98321

Reviewed by Simon Fraser.

Rename compositing-related methods that refer to "syncing" to instead
refer to "flushing".

Source/WebCore:

  • WebCore.exp.in:
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::scheduleCompositingLayerFlush):

  • page/ChromeClient.h:

(ChromeClient):

  • page/FrameView.cpp:

(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::flushCompositingStateIncludingSubframes):
(WebCore::FrameView::paintContents):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::scheduleLayerFlush):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

Source/WebKit/blackberry:

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::scheduleCompositingLayerFlush):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::scheduleCompositingLayerFlush):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::scheduleCompositingLayerFlush):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::scheduleCompositingLayerFlush):

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::scheduleCompositingLayerFlush):

  • WebView/WebView.mm:

(-[WebView _flushCompositingChanges]):
(LayerFlushController::flushLayers):
(-[WebView _scheduleCompositingLayerFlush]):

  • WebView/WebViewInternal.h:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::scheduleCompositingLayerFlush):

  • WebCoreSupport/ChromeClientQt.h:

(ChromeClientQt):

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::syncLayers):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::scheduleCompositingLayerFlush):

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebView.cpp:

(WebView::flushPendingGraphicsLayerChanges):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::scheduleCompositingLayerFlush):

  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scheduleCompositingLayerFlush):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebPage/DrawingArea.h:

(DrawingArea):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::scheduleCompositingLayerFlush):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::flushPendingLayerChanges):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlush):
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

9:13 AM Changeset in webkit [130399] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

[Qt] Add missing LLInt dependencies to the build system
https://bugs.webkit.org/show_bug.cgi?id=98394

Reviewed by Geoffrey Garen.

  • DerivedSources.pri:
  • LLIntOffsetsExtractor.pro:
9:12 AM Changeset in webkit [130398] by commit-queue@webkit.org
  • 16 edits
    4 adds in trunk

Web Inspector: expose object internal properties such as PrimitiveValue or BoundThis
https://bugs.webkit.org/show_bug.cgi?id=94397

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-10-04
Reviewed by Yury Semikhatsky.

Source/WebCore:

Internal property access is built from Injected Script to V8 debug API. JSC binding
has a stub imlpementation. Protocol is updated to explicitly reflect internal properties.

Test: inspector-protocol/runtime-getProperties.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::getInternalProperties):
(WebCore):

  • bindings/v8/DebuggerScript.js:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::getInternalProperties):
(WebCore):

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::getInternalPropertiesCallback):
(WebCore):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getInternalProperties):
(WebCore):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

LayoutTests:

A test is added to support new feature. Old test is updated because line number changed.

  • inspector-protocol/runtime-getProperties-expected.txt: Added.
  • inspector-protocol/runtime-getProperties.html: Added.
  • inspector/console/command-line-api-expected.txt:
9:08 AM Changeset in webkit [130397] by kpiascik@rim.com
  • 2 edits in trunk/Source/WebKit

[BlackBerry] Update how we compile inspector front-end javascript.
https://bugs.webkit.org/show_bug.cgi?id=98413

Reviewed by Rob Buis.

No longer cat all JavaScript together, instead use the lazy init and
only append our custom changes script to the end of inspectorBB.html.

  • PlatformBlackBerry.cmake:
8:57 AM Changeset in webkit [130396] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Fixed position visibility check does not consider descendants
https://bugs.webkit.org/show_bug.cgi?id=98144

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-10-04
Reviewed by Simon Fraser.

Source/WebCore:

The check against creating composition layers for invisible fixed positioned
elements is too aggressive in that it does not consider descendants of the
fixed positioned element that may be visible even though the element itself is
out of view.

Fix the problem by calculating the true composited bounds of the fixed
element instead of just using the size of the fixed layer. Because calculating
the true bounds may be expensive, it is only done if the fixed layer itself is
invisible.

Test: compositing/layer-creation/fixed-position-absolute-descendant.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

  • rendering/RenderLayerCompositor.h:

LayoutTests:

Added a test for the fixed position layer visibility check.

  • compositing/layer-creation/fixed-position-absolute-descendant-expected.txt: Added.
  • compositing/layer-creation/fixed-position-absolute-descendant.html: Added.
8:52 AM Changeset in webkit [130395] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

[EFL][WK2] Add setting to allow file access from file:// URLs
https://bugs.webkit.org/show_bug.cgi?id=98121

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Laszlo Gombos.

Source/WebKit2:

Add Ewk setting to set / query permission to access
files from file:// URLs.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/resources/local_file_access.html: Added.
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F): Add unit tests for new ewk setting.

Tools:

Allow file access from file:// URLs by default in Minibrowser
to facilitate testing.

  • MiniBrowser/efl/main.c:

(browserCreate):

8:47 AM Changeset in webkit [130394] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r130385. Skip some failing test.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt:
8:32 AM Changeset in webkit [130393] by vsevik@chromium.org
  • 11 edits in trunk

Web Inspector: When uiSourceCode content has diverged from VM script, call frames should be shown in temporary script based uiSourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=98385

Reviewed by Pavel Feldman.

Source/WebCore:

When javaScriptSource diverges from VM, ResourceScriptMapping now switches debugging
to temporary VM scripts based uiSourceCode with isDivergedReplacement property set.
Added hasDivergedFromVM and isDivergingFromVM properties to JavaScriptSource.
JavaScriptSourceFrame and ScriptSnippetsModel are updated to process breakpoint changes correctly.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.restoreBreakpoints):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
(WebInspector.JavaScriptSource.prototype.workingCopyChanged):
(WebInspector.JavaScriptSource.prototype.fireHasDivergedFromVMChanged):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype._hasDivergedFromVM):
(WebInspector.JavaScriptSourceFrame.prototype.onTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._getBreakpointDecorations):
(WebInspector.JavaScriptSourceFrame.prototype._muteBreakpointsWhileEditing):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._hasDivergedFromVMChanged):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateTemporaryUISourceCode):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.ScriptSnippetModel.prototype._restoreBreakpoints):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._revealExecutionLine):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.formatted):

LayoutTests:

  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/resource-script-mapping-expected.txt:
8:31 AM Changeset in webkit [130392] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Exiting fullscreen does not set the correct scroll position (Part II)
https://bugs.webkit.org/show_bug.cgi?id=97917
PR #212920

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Jacky Jiang.

Inform the client of transform change so that we avoid
getting stuck on overscroll.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

7:56 AM Changeset in webkit [130391] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Scripts panel should not automatically switch to snippet evaluation when previously evaluated snippet is edited.
https://bugs.webkit.org/show_bug.cgi?id=98402

Reviewed by Pavel Feldman.

Scripts panel does not automatically switch to snippet evaluation when
one edits previously evaluated snippet.

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._revealExecutionLine):

7:45 AM Changeset in webkit [130390] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] Run unit tests with Xvfb
https://bugs.webkit.org/show_bug.cgi?id=98389

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Laszlo Gombos.

Source/WebKit2:

  • UIProcess/API/efl/ewk_main.cpp:

(ewk_init): Call ecore_evas_shutdown() instead of
edje_shutdown() when ecore_x_init() fails.
(ewk_shutdown): Remove extra call to edje_shutdown().

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F): Temporarily disable fullscreen unit tests
until we get them working with Xvfb.

Tools:

Run EFL unit tests with Xvfb, similarly to GTK port.

  • Scripts/run-efl-tests:
6:42 AM Changeset in webkit [130389] by kbalazs@webkit.org
  • 9 edits in trunk

.: Don't allow to disable compositing in forced compositing mode
https://bugs.webkit.org/show_bug.cgi?id=98048

Reviewed by Jocelyn Turcotte.

Export Settings::setAcceleratedCompositingEnabled because it has been deinlined.

  • Source/autotools/symbols.filter:

Source/WebCore: Don't allow to disable compositing in forced compositing mode
https://bugs.webkit.org/show_bug.cgi?id=98048

Reviewed by Jocelyn Turcotte.

Make forced compositing mode imply accelerated compositing. This will
avoid unexpected situations for platforms that don't want to support
the non-accelerated rendering path.

Covered by existing tests.

  • WebCore.exp.in: Export Settings::setAcceleratedCompositingEnabled

because it has been deinlined.

  • page/Settings.cpp:

(WebCore::Settings::setAcceleratedCompositingEnabled):
(WebCore::Settings::setForceCompositingMode):
(WebCore):

  • page/Settings.h:

(Settings):
(WebCore::Settings::forceCompositingMode): Make it const as a side fix.

Source/WebKit2: Don't allow compositing to be disabled in forced compositing mode
https://bugs.webkit.org/show_bug.cgi?id=98048

Reviewed by Jocelyn Turcotte.

Export Settings::setAcceleratedCompositingEnabled because it has been deinlined.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
6:20 AM Changeset in webkit [130388] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r130385. Skip a failing test.
https://bugs.webkit.org/show_bug.cgi?id=62741

  • platform/qt/TestExpectations:
5:31 AM Changeset in webkit [130387] by rakuco@webkit.org
  • 46 edits
    8 adds in trunk/LayoutTests

[EFL] Pixel test rebaselines to enable pixel testing on the bots, part 6.

  • platform/efl/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/efl/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/efl/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/efl/compositing/visibility/visibility-simple-video-layer-expected.txt: Added.
  • platform/efl/fast/forms/datalist/update-range-with-datalist-expected.png: Added.
  • platform/efl/fast/selectors/unqualified-hover-strict-expected.png:
  • platform/efl/fast/selectors/unqualified-hover-strict-expected.txt:
  • platform/efl/fast/xsl/xslt-missing-namespace-in-xslt-expected.png:
  • platform/efl/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
  • platform/efl/fullscreen/full-screen-stacking-context-expected.png:
  • platform/efl/fullscreen/full-screen-zIndex-after-expected.png:
  • platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.png:
  • platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt:
  • platform/efl/http/tests/local/file-url-sent-as-referer-expected.png:
  • platform/efl/http/tests/misc/frame-access-during-load-expected.png:
  • platform/efl/http/tests/misc/iframe404-expected.png:
  • platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/efl/http/tests/uri/css-href-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
  • platform/efl/svg/filters/big-sized-filter-expected.png:
  • platform/efl/svg/filters/feColorMatrix-saturate-expected.png: Added.
  • platform/efl/svg/filters/feDropShadow-expected.png: Added.
  • platform/efl/svg/filters/feGaussianBlur-expected.png:
  • platform/efl/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
  • platform/efl/svg/filters/filterRes1-expected.png:
  • platform/efl/svg/filters/filterRes3-expected.png:
  • platform/efl/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/efl/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
5:24 AM Changeset in webkit [130386] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Enable inspector by default in GtkLauncher/MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=98333

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2012-10-04
Reviewed by Xan Lopez.

Both MiniBrowser and GtkLauncher are tools for testing, so in
the end every time we want to test the inspector we have to
manually enable enable the “developer extras” setting when using
them. It make sense to have this setting enabled by default.

  • GtkLauncher/main.c:

(main):

  • MiniBrowser/gtk/main.c:

(main):

5:23 AM Changeset in webkit [130385] by kadam@inf.u-szeged.hu
  • 5 edits
    7 adds in trunk/LayoutTests

[Qt] Reviewing old bugs in Qt TestExpectations. Unskip now passing test.

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/qt/http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object-expected.txt: Added.
  • platform/qt/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Added.
5:18 AM Changeset in webkit [130384] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark perf/show-hide-table-rows.html as flaky.

  • platform/chromium/TestExpectations:
4:06 AM Changeset in webkit [130383] by commit-queue@webkit.org
  • 17 edits in trunk

Change RTCPeerConnection GetStats to use Date timestamp format
https://bugs.webkit.org/show_bug.cgi?id=98263

Patch by Harald Alvestrand <hta@google.com> on 2012-10-04
Reviewed by Yury Semikhatsky.

Source/Platform:

  • chromium/public/WebRTCStatsResponse.h:

(WebRTCStatsResponse):

Source/WebCore:

Tested by extension to RTCPeerConnection-stats test.

  • Modules/mediastream/RTCStatsElement.cpp:

(WebCore::RTCStatsElement::create):
(WebCore::RTCStatsElement::RTCStatsElement):

  • Modules/mediastream/RTCStatsElement.h: long -> double

(RTCStatsElement):
(WebCore::RTCStatsElement::timestamp):

  • Modules/mediastream/RTCStatsElement.idl: long -> Date
  • Modules/mediastream/RTCStatsReport.cpp:

(WebCore::RTCStatsReport::addElement):

  • Modules/mediastream/RTCStatsReport.h:

(RTCStatsReport):

  • Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::addElement):

  • Modules/mediastream/RTCStatsResponse.h:

(RTCStatsResponse):

  • platform/chromium/support/WebRTCStatsResponse.cpp:

(WebKit::WebRTCStatsResponse::addElement):

  • platform/mediastream/RTCStatsResponseBase.h:

(RTCStatsResponseBase):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
3:43 AM Changeset in webkit [130382] by jocelyn.turcotte@digia.com
  • 4 edits in trunk/Source/WebKit2

[Qt] Fix the tst_QQuickWebView::scrollRequest auto test
https://bugs.webkit.org/show_bug.cgi?id=98045

Reviewed by Simon Hausmann.

Relying on QQuickWebViewPrivate::setNeedsDisplay can cause a false positive
emission of the loadVisuallyCommitted signal since this method is also
called when a layer is deleted or when the root layer changes.

Move the signal emission to QQuickWebViewPrivate::didRenderFrame which
is called only after a DidRenderFrame message has been received from the
web process.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::setNeedsDisplay):
(QQuickWebViewPrivate::didRenderFrame):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/qt/QtPageClient.cpp:

(WebKit::QtPageClient::didRenderFrame):

3:18 AM Changeset in webkit [130381] by dpranke@chromium.org
  • 4 edits in trunk/Tools

[NRWT] --skipped option is ignored when --test-list is used
https://bugs.webkit.org/show_bug.cgi?id=98260

Reviewed by Ojan Vafai.

Adds a --skipped=always flag that will skip any tests listed in
TestExpectations even if they're listed explicitly on the
command line.

This is most useful if you are using --test-list to specify a
long list of files but you still want to skip some of them
depending on what's in TestExpectations.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:

(LayoutTestFinder.skip_tests):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_skipped_flag):

3:08 AM Changeset in webkit [130380] by commit-queue@webkit.org
  • 17 edits in trunk

Unreviewed, rolling out r130377.
http://trac.webkit.org/changeset/130377
https://bugs.webkit.org/show_bug.cgi?id=98392

Chromium Win compilation is broken (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-04

Source/Platform:

  • chromium/public/WebRTCStatsResponse.h:

(WebRTCStatsResponse):

Source/WebCore:

  • Modules/mediastream/RTCStatsElement.cpp:

(WebCore::RTCStatsElement::create):
(WebCore::RTCStatsElement::RTCStatsElement):

  • Modules/mediastream/RTCStatsElement.h:

(RTCStatsElement):
(WebCore::RTCStatsElement::timestamp):

  • Modules/mediastream/RTCStatsElement.idl:
  • Modules/mediastream/RTCStatsReport.cpp:

(WebCore::RTCStatsReport::addElement):

  • Modules/mediastream/RTCStatsReport.h:

(RTCStatsReport):

  • Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::addElement):

  • Modules/mediastream/RTCStatsResponse.h:

(RTCStatsResponse):

  • platform/chromium/support/WebRTCStatsResponse.cpp:

(WebKit::WebRTCStatsResponse::addElement):

  • platform/mediastream/RTCStatsResponseBase.h:

(RTCStatsResponseBase):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
2:51 AM Changeset in webkit [130379] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Some picker test for input[type=date] are failing
https://bugs.webkit.org/show_bug.cgi?id=98390

  • platform/chromium/TestExpectations:
2:24 AM Changeset in webkit [130378] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fix an error in TestExpectations.

  • platform/chromium/TestExpectations:
2:14 AM Changeset in webkit [130377] by commit-queue@webkit.org
  • 17 edits in trunk

Change RTCPeerConnection GetStats to use Date timestamp format
https://bugs.webkit.org/show_bug.cgi?id=98263

Patch by Harald Alvestrand <hta@google.com> on 2012-10-04
Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebRTCStatsResponse.h:

(WebRTCStatsResponse):

Source/WebCore:

Tested by extension to RTCPeerConnection-stats test.

  • Modules/mediastream/RTCStatsElement.cpp:

(WebCore::RTCStatsElement::create):
(WebCore::RTCStatsElement::RTCStatsElement):

  • Modules/mediastream/RTCStatsElement.h: long -> double

(RTCStatsElement):
(WebCore::RTCStatsElement::timestamp):

  • Modules/mediastream/RTCStatsElement.idl: long -> Date
  • Modules/mediastream/RTCStatsReport.cpp:

(WebCore::RTCStatsReport::addElement):

  • Modules/mediastream/RTCStatsReport.h:

(RTCStatsReport):

  • Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::addElement):

  • Modules/mediastream/RTCStatsResponse.h:

(RTCStatsResponse):

  • platform/chromium/support/WebRTCStatsResponse.cpp:

(WebKit::WebRTCStatsResponse::addElement):

  • platform/mediastream/RTCStatsResponseBase.h:

(RTCStatsResponseBase):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
2:01 AM Changeset in webkit [130376] by tkent@chromium.org
  • 2 edits
    17 deletes in trunk/LayoutTests

Update tests for input[type=date] with the multiple fields UI
https://bugs.webkit.org/show_bug.cgi?id=98386

Reviewed by Hajime Morita.

Remove some tests for input[type=date. They depends on the old UI, which
we don't use any more.
Mark some tests fail. We need to update their results later.

  • fast/forms/date/date-appearance.html: Removed.
  • fast/forms/date/date-fixed-placeholder-expected.txt: Removed.
  • fast/forms/date/date-fixed-placeholder.html: Removed.
  • fast/forms/date/date-input-visible-strings-expected.txt: Removed.
  • fast/forms/date/date-input-visible-strings.html: Removed.
  • fast/forms/date/input-date-commit-valid-only-expected.txt: Removed.
  • fast/forms/date/input-date-commit-valid-only.html: Removed.
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.png: Removed.
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/date/date-input-visible-strings-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Removed.
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png: Removed.
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt: Removed.
  • platform/chromium-win/fast/forms/date/date-appearance-expected.png: Removed.
  • platform/chromium-win/fast/forms/date/date-appearance-expected.txt: Removed.
  • platform/chromium-win/fast/forms/date/date-input-visible-strings-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/date/date-input-visible-strings-expected.txt: Removed.
1:59 AM Changeset in webkit [130375] by tkent@chromium.org
  • 5 edits in trunk/Source

[Chromium] Enable the multiple fields UI for input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=98351

Reviewed by Hajime Morita.

Source/WebCore:

Touch files related to ENABLE_INPUT_TYPE_DATE_LEGACY_UI to avoid build
issues.

No new tests. Many tests will be landed shortly.

  • html/DateInputType.cpp:
  • html/DateInputType.h:

Source/WebKit/chromium:

  • features.gypi:

Disable ENABLE_INPUT_TYPE_DATE_LEGACY_UI.

1:58 AM Changeset in webkit [130374] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] webintents/web-intents-failure.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98349

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Gyuyoung Kim.

After r130344, OpaqueJSString().string() returns
an empty string instead of a null one. Therefore,
we need to update the check in
DumpRenderTreeSupportEfl::sendWebIntentResponse().

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::sendWebIntentResponse):

1:50 AM Changeset in webkit [130373] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Regression(r130363): Broke unit tests
https://bugs.webkit.org/show_bug.cgi?id=98341

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-04
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Fix WebKitEFL unit tests to use X11 as
well.

  • tests/UnitTestUtils/EWKTestBase.cpp:

(EWKUnitTests::EWKTestBase::SetUp):

  • tests/UnitTestUtils/EWKTestEnvironment.h:

(EWKTestEnvironment):

  • tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestView::init):

  • tests/UnitTestUtils/EWKTestView.h:

(EWKTestView):

Source/WebKit2:

Fix WebKit2 EFL to use X11 as well.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::SetUp):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::EWK2UnitTestEnvironment):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:

(EWK2UnitTestEnvironment):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp:

(main):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(checkFullScreenProperty):

1:46 AM Changeset in webkit [130372] by rakuco@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, remove unused $legacyWebKitBlobBuilderSupport variable after r130343.

  • Scripts/webkitperl/FeatureList.pm:
1:09 AM Changeset in webkit [130371] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] css2.1/20110323/text-indent-intrinsic-00* fail
https://bugs.webkit.org/show_bug.cgi?id=91772

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-04
Reviewed by Yuta Kitamura.

Unskip some tests that are passing.

  • platform/qt/TestExpectations:
12:59 AM Changeset in webkit [130370] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding proper bug modifiers for accessibility failures that don't yet have one.

  • platform/gtk/TestExpectations:
12:49 AM Changeset in webkit [130369] by tkent@chromium.org
  • 15 edits in trunk/Source

Add code for input[type=date] with the multiple fields UI
https://bugs.webkit.org/show_bug.cgi?id=98340

Reviewed by Hajime Morita.

Source/WebCore:

The new code is available if !ENABLE(INPUT_TYPE_DATE_LEGACY_UI). At this
moment, there are no platforms enabling the new code. We're going to
enable it soon on desktop Chromium, and add tests. Then we're going to
remove the code for ENABLE(INPUT_TYPE_DATE_LEGACY_UI).

ENABLE(INPUT_TYPE_DATE_LEGACY_UI) means the current UI; input[type=date]
is represetnted as a kind of text field, and it has code to invoke a
calendar picker.
ENABLE(CALENDAR_PICKER) was used wrongly. It meant calendar picker
support + text field UI of input[type=date]. Now it means only calendar
picker support.

  • html/DateInputType.h:

(WebCore): If ENABLE(INPUT_MULTIPLE_FIELDS_UI) &&
!ENABLE(INPUT_TYPE_DATE_LEGACY_UI), change the base class to the class
for multiple fields UI.
(DateInputType): Wrap the code for text fields behavior and calendar
picker UI with ENABLE(INPUT_TYPE_DATE_LEGACY_UI). Add functions for
ENABLE(INPUT_MULTIPLE_FIELDS_UI)

  • html/DateInputType.cpp:

(WebCore::DateInputType::DateInputType):
Change the flag name; CALENDAR_PICKER -> INPUT_TYPE_DATE_LEGACY_UI
(WebCore): ditto.
(WebCore::DateInputType::formatDateTimeFieldsState):
A callback for multiple fields UI. This constructs a string value from
each of values of multiple fields.
Note that we don't need to do +1 to month().
(WebCore::DateInputType::setupLayoutParameters):
A callback for multiple fields UI. Passes information to build UI.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):
Add m_pickerIndicatorIsAlwaysVisible member, wrap some members with flags.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType):
Initialize m_pickerIndicatorIsAlwaysVisible.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
If a type supports calendar picker, we should always show the picker
indicator. We introduce m_pickerIndicatorIsAlwaysVisible flag, and ask
RenderTheme for support status of each of types.
Add a local variable 'document' to avoid multiple element()->document().
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility):

  • If m_pickerIndicatorIsAlwaysVisible, don't hide the picker indicator element.
  • Wrap the code with appropriate flags.
  • rendering/RenderTheme.h:

(WebCore::RenderTheme::supportsCalendarPicker): Added.

  • rendering/RenderThemeChromiumMac.h: Override supportsCalendarPicker.
  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::supportsCalendarPicker):
Added. Delegate to RenderThemeChromiumCommon.

  • rendering/RenderThemeChromiumSkia.h: Override supportsCalendarPicker.
  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::supportsCalendarPicker):
Added. Delegate to RenderThemeChromiumCommon.

  • rendering/RenderThemeChromiumCommon.h:

(RenderThemeChromiumCommon): Declare supportsCalendarPicker.

  • rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsCalendarPicker):
Returns true if the type is "date."

  • html/DateTimeFieldsState.h:

(DateTimeFieldsState): Add a comment for the m_month field.

Source/WebKit/chromium:

  • features.gypi: Add ENABLE_INPUT_TYPE_DATE_LEGACY_UI=1 for non-Android.
12:27 AM Changeset in webkit [130368] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Removed duplicate entries introduced by r130355

  • platform/chromium/TestExpectations:
12:12 AM Changeset in webkit [130367] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening, skip new crashing tests to paint the bot green.

  • platform/qt-5.0-wk2/TestExpectations:
Note: See TracTimeline for information about the timeline view.