Timeline



Oct 10, 2012:

11:40 PM Changeset in webkit [131018] by jer.noble@apple.com
  • 6 edits in trunk/Source

Disallow full screen mode keyboard access by default.
https://bugs.webkit.org/show_bug.cgi?id=98971
<rdar://problem/12474226>

Reviewed by Sam Weinig.

Source/WebCore:

Fall back to requesting non-keyboard access if the client refuses to allow keyboard access.

  • dom/Document.cpp:

(WebCore::Document::requestFullScreenForElement):

Source/WebKit/mac:

Only support full screen if keyboard access is not requested.

  • WebView/WebView.mm:

(-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):

Source/WebKit2:

Only support full screen if keyboard access is not requested.

  • UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::supportsFullScreen):

11:05 PM Changeset in webkit [131017] by loislo@chromium.org
  • 12 edits
    2 copies
    3 adds in trunk

Web Inspector: NMI instrument HTMLCanvas element.
https://bugs.webkit.org/show_bug.cgi?id=98917

Reviewed by Yury Semikhatsky.

It also includes non intrusive instrumentation for skia classes.

Source/WebCore:

Test: inspector/profiler/memory-instrumentation-canvas.html

  • WebCore.gypi:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reportMemoryUsage):
(WebCore):

  • html/HTMLCanvasElement.h:

(HTMLCanvasElement):

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::reportMemoryUsage):
(WebCore):

  • platform/graphics/ImageBuffer.h:

(ImageBuffer):

  • platform/graphics/chromium/ImageBufferDataSkia.h:

(ImageBufferData):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBufferData::reportMemoryUsage):
(WebCore):

  • platform/graphics/skia/MemoryInstrumentationSkia.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageBufferDataSkia.h.

(reportMemoryUsage):

  • platform/graphics/skia/MemoryInstrumentationSkia.h: Copied from Source/WebCore/platform/graphics/chromium/ImageBufferDataSkia.h.
  • platform/graphics/skia/NativeImageSkia.cpp:

LayoutTests:

  • inspector/profiler/memory-instrumentation-cached-images-expected.txt:
  • inspector/profiler/memory-instrumentation-cached-images.html:
  • inspector/profiler/memory-instrumentation-canvas.html: Added.
  • inspector/profiler/memory-instrumentation-test.js: Added.

(initialize_MemoryInstrumentationTest.InspectorTest._memoryBlockSize):
(initialize_MemoryInstrumentationTest.InspectorTest.validateMemoryBlockSize):
(initialize_MemoryInstrumentationTest):

10:24 PM Changeset in webkit [131016] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening.

  • platform/qt/TestExpectations: Skip new failing tests.
  • platform/qt/fast/css-generated-content/table-row-group-to-inline-expected.png: Updated after r131004.
  • platform/qt/fast/css-generated-content/table-row-group-to-inline-expected.txt: Updated after r131004.
9:56 PM Changeset in webkit [131015] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Document calls createElement with the wrong parameters.
https://bugs.webkit.org/show_bug.cgi?id=98907

Patch by Mike West <mkwst@google.com> on 2012-10-10
Reviewed by Kent Tamura.

Document::importNode calls Document::createElement with a QualifiedName
and ExceptionCode. The Document::createElement that takes a
QualifiedName doesn't generate an exception; the second argument is a
bool, which the ExceptionCode autocasts into.

Changing the argument to an explicit bool shouldn't have any visible
effect; no new tests are required.

  • dom/Document.cpp:

(WebCore::Document::importNode):

9:55 PM Changeset in webkit [131014] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk/Source

[BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult.
https://bugs.webkit.org/show_bug.cgi?id=97397
Internal PR: 186597.

Internally reviewed by Yong Li, Joe Mason.
Patch by Lianghui Chen <liachen@rim.com> on 2012-10-10
Reviewed by George Staikos.

Source/WebCore:

Add a singleton AuthenticationChallengeManager to manage authentication
challenge dialog. It does following things:
Record page creation/deletion, so it knows what page is present or not.
Record page visibility change so it knows when to display a dialog or not.
Accept authentication challenge, and decide whether to postpone the

challenge dialog based on whether there is active authentication challenge
dialog already and whether its page is visible or not.

When a challenge result comes back, notify the result to all clients

authenticating for the same protection space, and then start the next
authentication challenge from the same page, if there is one.

When a page becomes visible, start the first authentication challenge

dialog that has been blocked before.

When an authentication challenge is requested, the NetworkJob will be

deferred so its initial response will be saved while waiting for
user decision on the challenge.

No new tests for platform specific internal change.

  • PlatformBlackBerry.cmake:
  • platform/blackberry/AuthenticationChallengeManager.cpp: Added.

(WebCore):
(ChallengeInfo):
(WebCore::ChallengeInfo::ChallengeInfo):
(AuthenticationChallengeManagerPrivate):
(WebCore::AuthenticationChallengeManagerPrivate::AuthenticationChallengeManagerPrivate):
(WebCore::AuthenticationChallengeManagerPrivate::resumeAuthenticationChallenge):
(WebCore::AuthenticationChallengeManagerPrivate::startAuthenticationChallenge):
(WebCore::AuthenticationChallengeManagerPrivate::pageExists):
(WebCore::AuthenticationChallengeManager::AuthenticationChallengeManager):
(WebCore::AuthenticationChallengeManager::pageCreated):
(WebCore::AuthenticationChallengeManager::pageDeleted):
(WebCore::AuthenticationChallengeManager::pageVisibilityChanged):
(WebCore::AuthenticationChallengeManager::authenticationChallenge):
(WebCore::AuthenticationChallengeManager::cancelAuthenticationChallenge):
(WebCore::AuthenticationChallengeManager::notifyChallengeResult):
(WebCore::AuthenticationChallengeManager::instance):
(WebCore::AuthenticationChallengeManager::init):

  • platform/blackberry/AuthenticationChallengeManager.h:

(WebCore):
(AuthenticationChallengeManager):

  • platform/blackberry/PageClientBlackBerry.h:
  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::~NetworkJob):
(WebCore):
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::shouldReleaseClientResource):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

Source/WebKit/blackberry:

Update WebPage to use new AuthenticationChallengeManager.
Register page creation/deletion and visibility change to the new

AuthenticationChallengeManager.

Initialize AuthenticationChallengeManager in GlobalInitialize() function.

  • Api/BlackBerryGlobal.cpp:

(BlackBerry::WebKit::globalInitialize):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::setVisible):

  • Api/WebPage_p.h:

(WebPagePrivate):

9:49 PM Changeset in webkit [131013] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

Expose background color in WebLayer https://bugs.webkit.org/show_bug.cgi?id=98707

Patch by Scott Violet <sky@google.com> on 2012-10-10
Reviewed by James Robinson.

  • chromium/public/WebLayer.h:

(WebLayer): Adds backgroundColor.

9:47 PM Changeset in webkit [131012] by shinyak@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed gardening, rebaselined.

  • platform/chromium-mac-snowleopard/fast/css-generated-content/table-row-group-to-inline-expected.png:
  • platform/chromium-mac/fast/css-generated-content/table-row-group-to-inline-expected.png: Removed.
9:44 PM Changeset in webkit [131011] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Calendar picker: should use consistent Localizer object
https://bugs.webkit.org/show_bug.cgi?id=98983

Reviewed by Kentaro Hara.

In Source/WebKit/chromium/src/DateTimeChooserImpl.cpp, we used two
Localizer objects, one was m_localizer and another was 'localizer' local
object in writeDocument. We should use single Localizer object.

Also, Localizer::create(nullAtom) had unexpected behaviors in ICU
environment; e.g. Month labels in a calendar picker were numeric. This
patch fixes it, and this is covered by
fast/forms/date/calendar-picker-appearance.html.

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument):
Use m_localizer.

9:26 PM Changeset in webkit [131010] by Simon Fraser
  • 2 edits in trunk/LayoutTests

compositing/images/truncated-direct-png-image.html has been failing on Mac since it was
added. Mark it as an expected image failure.

  • platform/mac/TestExpectations:
9:07 PM Changeset in webkit [131009] by Simon Fraser
  • 4 edits in trunk

compositing/tiling/crash-reparent-tiled-layer.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=82546

Reviewed by Beth Dakin.

Source/WebCore:

When calling layerTreeAsText() inside the document load event,
GraphicsLayerCA may have not flushed layers yet, so layer tree
properties that are affected by flushing (tiled layer, visible
rects) appeared flakey in tests.

Fix by forcing a flush before dumping the layer tree.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

LayoutTests:

Unskip a previously-flakey tiled layer test that should not be flakey after this change.

  • platform/mac/TestExpectations:
8:57 PM Changeset in webkit [131008] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit2

Unreviewed, rolling out r130972 and r130984.
http://trac.webkit.org/changeset/130972
http://trac.webkit.org/changeset/130984
https://bugs.webkit.org/show_bug.cgi?id=98986

Huge numbers of WK2 crashes (Requested by smfr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-10

  • Platform/CoreIPC/Connection.h:

(Connection):

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::addMessageReceiver):
(CoreIPC::MessageReceiverMap::clearAllMessageReceivers):
(CoreIPC::MessageReceiverMap::knowsHowToHandleMessage):
(CoreIPC::MessageReceiverMap::dispatchMessage):
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • UIProcess/WebConnectionToWebProcess.h:

(WebConnectionToWebProcess):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::knowsHowToHandleMessage):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

8:41 PM Changeset in webkit [131007] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=98984
REGRESSION: Crash happens after we add non-top-level frame to the
ScrollingStateTree

Reviewed by Simon Fraser.

isRootLayer() can return true for layers that do not correspond to
the main frame. But we only want the ones that DO correspond to the
main frame!

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

8:39 PM Changeset in webkit [131006] by simonjam@chromium.org
  • 5 edits
    9 adds in trunk/LayoutTests

Import W3C test suite for performance.now()
https://bugs.webkit.org/show_bug.cgi?id=98953

Reviewed by Tony Gentilcore.

  • http/tests/w3c/webperf/approved/HighResolutionTime/basic-expected.txt: Added.
  • http/tests/w3c/webperf/approved/HighResolutionTime/basic.html: Added.
  • http/tests/w3c/webperf/approved/HighResolutionTime/monotonic-clock-expected.txt: Added.
  • http/tests/w3c/webperf/approved/HighResolutionTime/monotonic-clock.html: Added.
  • http/tests/w3c/webperf/approved/HighResolutionTime/resources/now_frame.html: Added.
  • http/tests/w3c/webperf/approved/HighResolutionTime/test_cross_frame_start-expected.txt: Added.
  • http/tests/w3c/webperf/approved/HighResolutionTime/test_cross_frame_start.html: Added.
  • platform/chromium/TestExpectations: Skipped everywhere until we remove the prefix.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
8:20 PM Changeset in webkit [131005] by mitz@apple.com
  • 5 edits
    2 adds in trunk

<rdar://problem/12472460> text-combine doesn’t use third- and quarter-width variants when used with @font-face
https://bugs.webkit.org/show_bug.cgi?id=98961

Reviewed by Tim Horton.

Source/WebCore:

Test: fast/text/text-combine-with-font-face.html

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData): Added the width variant to the
key used for entries in the font data table, so that we can return different
font data for different width variants.

  • platform/graphics/FontWidthVariant.h: Defined FontWidthVariantWidth for

use in the computation of the above key.

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::combineText): Added a local variable to store
the font selector before changing the font description. Previously, by the time
we tried to get the font selector from the font, it had already been cleared,
so we called Font::update() with a 0 font selector, meaning @font-face fonts
could not be selected.

LayoutTests:

  • fast/text/text-combine-with-font-face-expected.html: Added.
  • fast/text/text-combine-with-font-face.html: Added.
8:17 PM Changeset in webkit [131004] by commit-queue@webkit.org
  • 43 edits
    2 adds in trunk

Move :before and :after into the DOM
https://bugs.webkit.org/show_bug.cgi?id=95117

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-10
Reviewed by Eric Seidel.

Source/WebCore:

Reimplement generated content :before and :after as DOM Elements. Now ElementRareData has
two RefPtrs to PseudoElements for the generated content and Node has methods for traversing
the tree including generated content.

This allows the generated content to be treated as real nodes instead of anonymous and take
part in the usual recalcStyle and attach flow which fixes many bugs and vastly simplifies the
lifecycle of generated content.

No new tests needed for now.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Element.cpp:

(WebCore::Element::attach): Add generated content if needed.
(WebCore::Element::detach): Remove all child generated content.
(WebCore::Element::recalcStyle): Add or remove generated content based on the new style.
(WebCore::Element::updatePseudoElement): Updates pseudo content based on a pseudoId.
(WebCore):
(WebCore::Element::createPseudoElementIfNeeded):
(WebCore::Element::beforePseudoElement):
(WebCore::Element::afterPseudoElement):

  • dom/Element.h:

(WebCore):
(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::setPseudoElement):
(WebCore):
(WebCore::ElementRareData::pseudoElement):

  • dom/Node.cpp:

(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::checkAcceptChild): Forbid moving PseudoElements for sanity. The code never does this.

  • dom/Node.h:

(Node):
(WebCore::Node::isPseudoElement):
(WebCore::Node::pseudoId): Fast path that only calls virtualPseudoId if the node has custom callbacks so isPseudoElement is fast.
(WebCore::Node::virtualPseudoId):
(WebCore::Node::isBeforePseudoElement):
(WebCore::Node::isAfterPseudoElement):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::nextRenderer): Changed to find the next sibling of pseudos for insertion.

  • dom/PseudoElement.cpp: Added.

(WebCore):
(WebCore::pseudoElementName):
(WebCore::PseudoElement::PseudoElement):
(WebCore::PseudoElement::pseudoRendererIsNeeded):
(WebCore::PseudoElement::customStyleForRenderer):
(WebCore::PseudoElement::attach):
(WebCore::PseudoElement::rendererIsNeeded):
(WebCore::PseudoElement::updateChildStyle): Propagates the style downward into the anonymous renderers for the content.
(WebCore::PseudoElement::didRecalcStyle):
(WebCore::PseudoElement::createRendererForContent): Refactored from RenderObjectChildList.

  • dom/PseudoElement.h: Added.

(WebCore):
(PseudoElement):
(WebCore::PseudoElement::create):
(WebCore::toPseudoElement):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::setInnerNode): Hit testing a PseudoElement should really hit the parent.
(WebCore::HitTestResult::setInnerNonSharedNode): Same as above.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange): Remove old generated content code, same for below.
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::createReplacementRunIn):
(WebCore::RenderBlock::renderName):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderButton.cpp:
  • rendering/RenderButton.h:

(RenderButton):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::originalText):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::renderName):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::renderName):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::renderName):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::updateMarkerLocation):

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::renderName):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isPseudoElement):
(RenderObject):
(WebCore::RenderObject::generatingNode):

  • rendering/RenderObjectChildList.cpp:
  • rendering/RenderObjectChildList.h:

(RenderObjectChildList):

  • rendering/RenderRubyText.cpp:
  • rendering/RenderRubyText.h:

(RenderRubyText):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::renderName):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):

  • rendering/RenderTableRow.h:

(WebCore::RenderTableRow::renderName):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::renderName):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

LayoutTests:

Regenerated some baselines for tests given the new generated content architecture and disabled
tests that are testing generated content on inputs which were wrong.

  • fast/css-generated-content/before-content-continuation-chain-expected.txt:
  • platform/chromium-mac/fast/css-generated-content/table-row-group-to-inline-expected.png:
  • platform/chromium/TestExpectations: Disable the tests for generated content on inputs. A follow up CL with remove these tests.
  • platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.png:
  • platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.txt:

This test always produced wrong output because we leave an anonymous RenderTable in the tree,
and now that generated content is handled like DOM nodes this test renders differently since the
content ends up after the left over RenderTable. Both outputs are wrong until Bug 86261 is fixed.

8:13 PM Changeset in webkit [131003] by weinig@apple.com
  • 12 edits
    4 copies in trunk/Source

Add more Objective-C WebKit2 DOM API skeletons.
https://bugs.webkit.org/show_bug.cgi?id=98981

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in:

Add necessary export.

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMElement.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMElement.mm:

Update guards to actually do something. CLANG is never defined, but clang is.

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
  • Abstracts DOM object caching into the DOMCache class which can only be used as a singleton.
  • Adds WKDOMRange class extension to allow manipulating its internal pointer for caching purposes.
  • Add WKDOMRange conversion functions.
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:

Rename _node to _impl for consistency.

  • WebProcess/InjectedBundle/API/mac/WKDOMRange.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange _initWithImpl:WebCore::]):
(-[WKDOMRange initWithDocument:]):
(-[WKDOMRange dealloc]):
(-[WKDOMRange startContainer]):
(-[WKDOMRange startOffset]):
(-[WKDOMRange endContainer]):
(-[WKDOMRange endOffset]):
(-[WKDOMRange text]):
Added. Only offers base range functionality.

  • WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm:

(-[WKDOMTextIterator initWithRange:]):
(-[WKDOMTextIterator advance]):
(-[WKDOMTextIterator atEnd]):
(-[WKDOMTextIterator currentRange]):
(-[WKDOMTextIterator currentTextPointer]):
(-[WKDOMTextIterator currentTextLength]):
Added. Almost identical to WebTextIterator API in WebKit.

8:07 PM Changeset in webkit [131002] by Dimitri Glazkov
  • 3 edits in trunk/Source/WebCore

Minimize the recent template explosion in SelectorChecker.
https://bugs.webkit.org/show_bug.cgi?id=98829

Reviewed by Antti Koivisto.

We've recently added the capability to switch sibling traversal strategy to SelectorChecker, at some readability/clarity expense.
This patch tries to minimize the surface of this expense to SelectorChecker::checkOneSelector.

No new tests, no change in behavior.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector): Turned back into a function.
(WebCore::SelectorChecker::checkOneSelector): Changed to specialize on traversal strategy, rather than the context, which was less clear.
(WebCore::SelectorChecker::DOMTraversalStrategy::isFirstChild): Turned into a function.
(WebCore::SelectorChecker::DOMTraversalStrategy::isLastChild): Ditto.
(WebCore::SelectorChecker::DOMTraversalStrategy::isFirstOfType): Ditto.
(WebCore::SelectorChecker::DOMTraversalStrategy::isLastOfType): Ditto.
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsBefore): Ditto.
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsOfTypeBefore): Ditto.
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsAfter): Ditto.
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsOfTypeAfter): Ditto.

  • css/SelectorChecker.h:

(DOMTraversalStrategy): Changed into a class, rather than a template.
(SelectorChecker): Turned back into a function.

8:06 PM Changeset in webkit [131001] by simonjam@chromium.org
  • 11 edits in trunk/Source/WebCore

High res times should start at 0
https://bugs.webkit.org/show_bug.cgi?id=84912

Reviewed by Tony Gentilcore.

Test: Existing Navigation Timing tests.

  • inspector/InspectorInstrumentation.cpp: Use legacy document time, pending 98223.

(WebCore):
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForTiming):

  • loader/DocumentLoadTiming.cpp:

(WebCore::DocumentLoadTiming::convertMonotonicTimeToLegacyDocumentTime):
(WebCore):
(WebCore::DocumentLoadTiming::convertMonotonicTimeToZeroBasedDocumentTime):
(WebCore::DocumentLoadTiming::markNavigationStart):

  • loader/DocumentLoadTiming.h:

(DocumentLoadTiming):
(WebCore::DocumentLoadTiming::navigationStart): These just report raw monotonic times now.
(WebCore::DocumentLoadTiming::unloadEventStart):
(WebCore::DocumentLoadTiming::unloadEventEnd):
(WebCore::DocumentLoadTiming::redirectStart):
(WebCore::DocumentLoadTiming::redirectEnd):
(WebCore::DocumentLoadTiming::fetchStart):
(WebCore::DocumentLoadTiming::responseEnd):
(WebCore::DocumentLoadTiming::loadEventStart):
(WebCore::DocumentLoadTiming::loadEventEnd):

  • page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::navigationStart): Convert these back to legacy document times.
(WebCore::PerformanceTiming::unloadEventStart):
(WebCore::PerformanceTiming::unloadEventEnd):
(WebCore::PerformanceTiming::redirectStart):
(WebCore::PerformanceTiming::redirectEnd):
(WebCore::PerformanceTiming::fetchStart):
(WebCore::PerformanceTiming::responseEnd):
(WebCore::PerformanceTiming::loadEventStart):
(WebCore::PerformanceTiming::loadEventEnd):
(WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute):
(WebCore::PerformanceTiming::monotonicTimeToIntegerMilliseconds):

  • platform/network/ResourceLoadTiming.cpp:

(WebCore::ResourceLoadTiming::convertResourceLoadTimeToMonotonicTime):

  • platform/network/ResourceLoadTiming.h:

(ResourceLoadTiming):

7:47 PM Changeset in webkit [131000] by leviw@chromium.org
  • 4 edits in trunk

Tests failure on Chromium Mac after r130821
https://bugs.webkit.org/show_bug.cgi?id=98865

Reviewed by Adam Barth.

Source/WebCore:

Updating the check for USE(HARFBUZZ_NG) to check for Mac Chromium, as the HARFBUZZ_NG flag isn't
actually set, despite us using Harfbuzz. This unbreaks Chromium Mac as we diagnose the root
cause of this issue.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

LayoutTests:

Removing failing test entries.

  • platform/chromium/TestExpectations:
7:40 PM Changeset in webkit [130999] by schenney@chromium.org
  • 3 edits
    2 adds in trunk

SVGTextRunRenderingContext changes font data in the glyph page, but it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=98755

Reviewed by Eric Seidel.

Source/WebCore:

The code in SVGTextRunRenderingContext::glyphDataForCharacter, when it
encounters an <altglyph> tag, immediately replaces the font data for a
glyph with font data for the primary font, presumably to meet the SVG
spec requirement: "If the references to alternate glyphs do not result
in successful identification of alternate glyphs to use, then the
character(s) that are inside of the ‘altGlyph’ element are rendered as
if the ‘altGlyph’ element were a ‘tspan’ element instead."

If the alt glyph is not then found we are in the case from the spec
and indeed we should use the primary font. However, we end up replacing the GlyphPage
entry for the character with primary font data, which we should not do
because the glyph page might be used in some place that does not have
the alt glyph tag.

Furthermore, this causes object lifetime problems for font data, because
in cases where the font data that is replaced is for the system fallback
font the GlyphPage will live forever with no knowldege that it contains
font data pointers into font data other that the system fallback. The
replaced font data may be deleted while the pointer lives on in the
system fallback page.

The fix is simply not to replace the font data in the page.

Test: svg/text/alt-glpyh-on-fallback-font-crash.html

  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter): Keep track of the original font data and put it back
in the glyph page when the method has finished.

LayoutTests:

New test case that includes an alt-glyph that comes from the system
fallback font (because the alt-glyph doesn't reference anything). This
test crashes on Chromium linux without the patch, and may crash on
other platforms too.

  • svg/text/alt-glpyh-on-fallback-font-crash.html: Added.
7:33 PM Changeset in webkit [130998] by piman@chromium.org
  • 2 edits
    1 copy in trunk/Source/Platform

[chromium] Add entrypoints to set frame contents and recycle resources in WebDelegatedRendererLayer
https://bugs.webkit.org/show_bug.cgi?id=98833

Reviewed by James Robinson.

This is needed for https://codereview.chromium.org/10915298

  • chromium/public/WebDelegatedRendererLayer.h:

(cc):
(WebKit):
(WebDelegatedRendererLayer):

7:26 PM Changeset in webkit [130997] by commit-queue@webkit.org
  • 6 edits in trunk

column-count: 0 should not prevent margin-collapse through
https://bugs.webkit.org/show_bug.cgi?id=65159

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-10
Reviewed by Tony Chang.

Source/WebCore:

This patch makes "column-count:0" be properly recognized as invalid syntax,
as it violates the property grammar in the spec.

Tests: fast/multicol/zeroColumnCount.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::parseValue):

  • css/CSSParser.h:

LayoutTests:

Fixed the zeroColumnCount.html test to properly test that "0" is an invalid CSS value,
rather than just ensuring that it doesn't crash.

  • fast/multicol/zeroColumnCount-expected.txt:
  • fast/multicol/zeroColumnCount.html:
7:24 PM Changeset in webkit [130996] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

[WK2] Safari crashes on error when using CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=98965

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-10
Reviewed by Sam Weinig.

The code of ResourceErrorMac when using CFNetwork was assuming
there is always either a CFError or an NSError associated with
any ResourceError.

This is not true on WebKit2 where error can be generic errors
in the WebProcess (for example a cannotShowURLError).
The code was crashing when trying to invoke function on the
non-existing CFError.

This patch fixes the issue by handling that third case separately.
If the ResourceError is a generic error, a new NSError is created,
similarily to what is done in the non-CFNetwork case.

  • platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::nsError):

7:07 PM Changeset in webkit [130995] by commit-queue@webkit.org
  • 8 edits
    6 adds in trunk

Invalid values for media query features are not handled
https://bugs.webkit.org/show_bug.cgi?id=97006

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-10-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

This patch improves pass rate of CSS3 Media Queries test suite
by making media expressions compliant with W3C specification. Few
performance issues are fixed by removal of string comparison during
media expression evaluation.

Tests: fast/media/w3c/test_media_queries.html

  • css/CSSGrammar.y: Handle media query expression with specified media restrictor as invalid.
  • css/MediaQuery.cpp:

(WebCore::MediaQuery::serialize): Serialize invalid query according to specification.

  • css/MediaQueryEvaluator.cpp:

(WebCore::orientationMediaFeatureEval): Compare CSSValueID instead of strings.
(WebCore::view_modeMediaFeatureEval): Compare CSSValueID instead of strings.
(WebCore::pointerMediaFeatureEval): Compare CSSValueID instead of strings.

  • css/MediaQueryExp.cpp:

(WebCore::MediaQueryExp::MediaQueryExp): Check that media features initialized with correct values.

LayoutTests:

Imported CSS3 Media Queries test suite from http://www.w3.org/Style/CSS/Test/MediaQueries/20120229/

  • fast/media/media-query-invalid-value.html: Fixed invalid media query.
  • fast/media/media-query-serialization.html: Fixed invalid media query.
  • fast/media/w3c/README: Added.
  • fast/media/w3c/resources/media_queries_iframe.html: Added. (Imported from w3c test suite)
  • fast/media/w3c/test_media_queries-expected.txt: Added.
  • fast/media/w3c/test_media_queries.html: Added. (Imported from w3c test suite)
7:05 PM Changeset in webkit [130994] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Chromium] Smoother animation for non-RAF 2D canvas animations
https://bugs.webkit.org/show_bug.cgi?id=97918

Patch by Justin Novosad <junov@chromium.org> on 2012-10-10
Reviewed by Stephen White.

Source/WebCore:

Reduces animation jank by preventing the accumulation of multiple
frames of backlog in the deferred canvas rendering queue. When the
animation is more than one full frame ahead of the compositor, an
immediate flush is triggered. This takes into account overdraw
elimination by the skip-on-clear optimization that is built-in to
SkDeferredCanvas, to allow non-RAF animations that clear the canvas at
each frame to run without any rate limiting. This change also
incidentally improves frame rate in many cases by providing more
granular batching of GPU API calls, resulting in better pipelining
through the command buffer.

Test: webkit_unit_test Canvas2DLayerManagerTest.testDeferredFrame

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::limitPendingFrames):
Called at the end of a task (usually a scheduled script action) that
invoked 2d canvas rendering context methods. The end of the task
marks the completion of a displayable frame. This method will trigger
a flush if it detects that the layer has pending draw commands that
are more that one frame old.
(WebCore):
(WebCore::Canvas2DLayerBridge::flushedDrawCommands):
(WebCore::Canvas2DLayerBridge::didFlushPendingCommands):
(WebCore::Canvas2DLayerBridge::skippedPendingDrawCommands):
(WebCore::Canvas2DLayerBridge::flush):
(WebCore::Canvas2DLayerBridge::contextAcquired):

  • platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):

  • platform/graphics/chromium/Canvas2DLayerManager.cpp:

(WebCore::Canvas2DLayerManager::~Canvas2DLayerManager):
(WebCore::Canvas2DLayerManager::willProcessTask):
(WebCore):
(WebCore::Canvas2DLayerManager::didProcessTask):
(WebCore::Canvas2DLayerManager::layerDidDraw):

  • platform/graphics/chromium/Canvas2DLayerManager.h:

(Canvas2DLayerManager):

Source/WebKit/chromium:

New unit test to verify the automatic flushing of deferred 2d canvas
layers when scripted animations are more than one full frame ahead
of the compositor. Also verifies that automatic flushing does not
kick-in when the skip on clear optimization fires

  • DEPS:
  • tests/Canvas2DLayerManagerTest.cpp:

(FakeCanvas2DLayerBridge::fakeSkipPendingDrawCommands):
To fake the skip on clear optimization
(FakeCanvas2DLayerBridge):
(Canvas2DLayerManagerTest):
(Canvas2DLayerManagerTest::doDeferredFrameTestTask):
Method that simulates a javascript scheduled action that draws to
a 2D canvas layer
(DeferredFrameTestTask):
Task object to simulate a scheduled action. This is so the unit
test can cover the TaskObserver behavior of Canvas2DLayerManager.
(Canvas2DLayerManagerTest::DeferredFrameTestTask::DeferredFrameTestTask):
(Canvas2DLayerManagerTest::deferredFrameTest):
The unit test implementation, which uses the WebThread run loop to
post tasks that touch the canvas layer.

6:52 PM Changeset in webkit [130993] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not perform backing store blit for animations during one-shot drawing synchronization
https://bugs.webkit.org/show_bug.cgi?id=98944

Patch by Andrew Lo <anlo@rim.com> on 2012-10-10
Reviewed by Rob Buis.

Internally reviewed by: Arvid Nilsson.
Internal PR 220014
Prevent animations from causing a backing store blit during a
one-shot drawing synchronization.

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):

6:45 PM Changeset in webkit [130992] by leandrogracia@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Update selection on long press to match normal delimiters.
https://bugs.webkit.org/show_bug.cgi?id=98947

Reviewed by Adam Barth.

Make the long press selection behaviour consistent.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::detectContentOnTouch):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/WebViewTest.cpp:
6:40 PM Changeset in webkit [130991] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix crash for detached node when validating selection change.
https://bugs.webkit.org/show_bug.cgi?id=98926

Reviewed by Rob Buis.

PR 220628.

Guard against detached nodes when generating selection rect.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::visibleTextQuads):

6:37 PM Writing Layout Tests for DumpRenderTree edited by noel.gordon@gmail.com
(diff)
6:26 PM TestExpectations edited by noel.gordon@gmail.com
(diff)
6:25 PM Changeset in webkit [130990] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Adjust spell checking location to update after the cursor position is set.
https://bugs.webkit.org/show_bug.cgi?id=98904

Reviewed by Rob Buis.

PR 215172.

Delay calculation of caret position until it is updated on mouse release
handling.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

6:24 PM Changeset in webkit [130989] by Beth Dakin
  • 7 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=98968
REGRESSION: Unable to scroll with trackpad on some websites after
r130783

Reviewed by Simon Fraser.

This bug seems to reproduce mostly on web pages that require login.
The re-routing causes extra churn of the RenderLayerBacking, and we
end up destroying and re-creating the backing and therefore the
ScrollingStateNodes, and when the timing is just wrong we get into a
state where the ScrollingTree has a set of incorrect information.
This patch fixes the bug by making sure the ScrollingStateNodes keep
the ScrollingTree in synch with their re-set data.

Tell the ScrollingStateTree that the root layer has changed.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):

New virtual function will set every property as having changed.

  • page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::setHasChangedProperties):

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::setHasChangedProperties):
(WebCore):

  • page/scrolling/ScrollingStateScrollingNode.h:

When the root layer changes, make sure we update the ScrollingTree
appropriately by indicating that every property could have changed.

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::rootLayerDidChange):
(WebCore):

  • page/scrolling/ScrollingStateTree.h:

(ScrollingStateTree):

6:18 PM Changeset in webkit [130988] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

[Chromium] Crash on SpellChecker::didCheck()
https://bugs.webkit.org/show_bug.cgi?id=98476

Reviewed by Kent Tamura.

SpellChecker::didCheck() assumed m_processingRequest is non-NULL. However, SpellChecker::invokeRequest()
calls SpellCheckRequest::didCancel(), which results didCheck() with NULL m_processingRequest.
This chagne eliminates the problematic didCheck().

No new tests. The case depends on specific timing and is hard to hit by automated testing.

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::didCheck):

6:00 PM Changeset in webkit [130987] by morrita@google.com
  • 10 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=95664
[Shadow DOM] should be able to be available without <style scoped>

Reviewed by Dimitri Glazkov.

Source/WebCore:

This change relaxes ENABLE(STYLE_SCOPED) compilation guard
and styleScopedEnabled() runtime guard. The flags now masks
user visible bits of the code, rather than all of it.
This change also eliminates some redundant guards for simplicity.

Test: fast/dom/shadow/style-scoped-not-enabled.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::scopeFor):

  • css/StyleScopeResolver.h:

(WebCore):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::parseAttribute):
(WebCore::HTMLStyleElement::scopedAttributeChanged):
(WebCore::HTMLStyleElement::isRegisteredAsScoped):
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):
(WebCore::HTMLStyleElement::scoped):
(WebCore::HTMLStyleElement::scopingElement):

  • html/HTMLStyleElement.h:

(HTMLStyleElement):

  • testing/InternalSettings.cpp: Exporsing a flag for testing.

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setStyleScopedEnabled):
(WebCore):

  • testing/InternalSettings.h: Exporsing a flag for testing.

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl: Exporsing a flag for testing.

LayoutTests:

  • fast/dom/shadow/style-scoped-not-enabled-expected.txt: Added.
  • fast/dom/shadow/style-scoped-not-enabled.html: Added.
6:00 PM Changeset in webkit [130986] by kpiascik@rim.com
  • 2 edits in trunk/Source/WebKit

[BlackBerry] Install inspector files into staging directory.
https://bugs.webkit.org/show_bug.cgi?id=98930

Reviewed by Rob Buis.

Internally reviewed by Ming Xie.
Install the web inspector resources into the staging directory to make it easier to flash to device.

  • PlatformBlackBerry.cmake:
5:45 PM Changeset in webkit [130985] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

[WebGL] [On Mac] queried attributes and uniforms need to return the original variable name, not the mapped name.
https://bugs.webkit.org/show_bug.cgi?id=98470

Reviewed by Timothy Horton.

When a variable name is too long we translate to a shorter version and keep a mapping between the long and short names.
However, when querying for a variable client side using getActiveAttrib or getActiveUniform, we accidentally return the
translated names. This fix makes these methods return the original variable names.

Tested using Khronos WebGL conformance suite:
conformance/glsl/misc/glsl-long-variable-names.html

  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: getActiveAttrib and getActiveUniform

now use GraphicsContext3D::originalSymbolName to find the original variable name.
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore):
(WebCore::GraphicsContext3D::originalSymbolName): This method returns the original variable name given
the mapped name.

5:30 PM Changeset in webkit [130984] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Stop crashing left and right.

  • UIProcess/WebConnectionToWebProcess.h:

(WebKit::WebConnectionToWebProcess::webProcessProxy):
Add a getter.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::fromConnection):
The WebProcessProxy is not the Connection::Client, the WebConnectionToWebProcess is.

5:26 PM Changeset in webkit [130983] by beidson@apple.com
  • 23 edits in trunk/Source/WebCore

Switch over CachedResource::data() from taking a SharedBuffer to taking a ResourceBuffer.
https://bugs.webkit.org/show_bug.cgi?id=98952

Reviewed by Anders Carlsson.

No new tests (No behavior change).

  • html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::appendBytes):
(WebCore::ImageDocumentParser::finish):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::sendDataToResource):
(WebCore::SubresourceLoader::didFinishLoading):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::data):

  • loader/cache/CachedCSSStyleSheet.h:

(WebCore):
(CachedCSSStyleSheet):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::data):

  • loader/cache/CachedFont.h:

(WebCore):
(CachedFont):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::data):

  • loader/cache/CachedImage.h:

(CachedImage):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::data):

  • loader/cache/CachedRawResource.h:

(CachedRawResource):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::data):

  • loader/cache/CachedResource.h:

(CachedResource):

  • loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::data):

  • loader/cache/CachedSVGDocument.h:

(CachedSVGDocument):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::data):

  • loader/cache/CachedScript.h:

(CachedScript):

  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::data):

  • loader/cache/CachedShader.h:

(CachedShader):

  • loader/cache/CachedTextTrack.cpp:

(WebCore::CachedTextTrack::data):

  • loader/cache/CachedTextTrack.h:

(CachedTextTrack):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::data):

  • loader/cache/CachedXSLStyleSheet.h:

(CachedXSLStyleSheet):

5:25 PM Changeset in webkit [130982] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-10

  • DEPS:
4:54 PM Changeset in webkit [130981] by Lucas Forschler
  • 2 edits in trunk/Tools

Remove Apple Mac Snow Leopard bots.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:53 PM Changeset in webkit [130980] by weinig@apple.com
  • 9 edits in trunk/Source/WebKit2

Fix the GCC Mac build. Why are we still building with GCC again?

  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMElement.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMElement.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
4:42 PM Changeset in webkit [130979] by ojan@chromium.org
  • 69 edits
    1 add
    1 delete in trunk/LayoutTests

check-layout.js should always dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=98959

Reviewed by Tony Chang.

Every checkLayout test was already dumpAsText except for
css3/flexbox/flex-item-child-overflow.html, which is a reftest
and really doesn't need to be a checkLayout test.

  • css3/flexbox/auto-height-dynamic.html:
  • css3/flexbox/box-sizing-min-max-sizes.html:
  • css3/flexbox/box-sizing.html:
  • css3/flexbox/columns-auto-size.html:
  • css3/flexbox/columns-height-set-via-top-bottom.html:
  • css3/flexbox/flex-algorithm-min-max.html:
  • css3/flexbox/flex-algorithm-with-margins.html:
  • css3/flexbox/flex-algorithm.html:
  • css3/flexbox/flex-align-column.html:
  • css3/flexbox/flex-align-end.html:
  • css3/flexbox/flex-align-max.html:
  • css3/flexbox/flex-align-percent-height.html:
  • css3/flexbox/flex-align-stretch.html:
  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/flex-flow-auto-margins.html:
  • css3/flexbox/flex-flow-border.html:
  • css3/flexbox/flex-flow-margins-auto-size.html:
  • css3/flexbox/flex-flow-margins.html:
  • css3/flexbox/flex-flow-orientations.html:
  • css3/flexbox/flex-flow-overflow.html:
  • css3/flexbox/flex-flow-padding.html:
  • css3/flexbox/flex-flow.html:
  • css3/flexbox/flex-item-child-overflow-expected.html:
  • css3/flexbox/flex-item-child-overflow.html:
  • css3/flexbox/flex-item-min-size.html:
  • css3/flexbox/flex-justify-content.html:
  • css3/flexbox/flex-no-flex.html:
  • css3/flexbox/flex-rounding.html:
  • css3/flexbox/flexitem-stretch-image.html:
  • css3/flexbox/flexitem.html:
  • css3/flexbox/floated-flexbox.html:
  • css3/flexbox/inline-flex.html:
  • css3/flexbox/line-wrapping.html:
  • css3/flexbox/multiline-align-content-horizontal-column.html:
  • css3/flexbox/multiline-align-content.html:
  • css3/flexbox/multiline-align-self.html:
  • css3/flexbox/multiline-column-auto.html:
  • css3/flexbox/multiline-justify-content.html:
  • css3/flexbox/multiline-reverse-wrap-overflow.html:
  • css3/flexbox/multiline.html:
  • css3/flexbox/nested-stretch.html:
  • css3/flexbox/orthogonal-flex-directions.html:
  • css3/flexbox/percent-margins.html:
  • css3/flexbox/percentage-heights.html:
  • css3/flexbox/percentage-sizes-quirks.html:
  • css3/flexbox/percentage-sizes.html:
  • css3/flexbox/perpendicular-writing-modes-inside-flex-item.html:
  • css3/flexbox/position-absolute-child.html:
  • css3/flexbox/position-absolute-children.html:
  • css3/flexbox/preferred-widths-orthogonal.html:
  • css3/flexbox/preferred-widths.html:
  • css3/flexbox/relayout-image-load.html:
  • css3/flexbox/style-change.html:
  • css3/flexbox/true-centering.html:
  • css3/flexbox/writing-modes.html:
  • fast/block/margins-perpendicular-containing-block.html:
  • fast/css-grid-layout/place-cell-by-index.html:
  • fast/css/deprecated-flexbox-auto-min-size.html:
  • fast/css/nested-percent-height-on-replaced.html:
  • fast/css/percentage-height-auto-sized-body-quirks.html:
  • fast/flexbox/flexing-overflow-scroll-item.html:
  • fast/replaced/vertical-writing-mode-max-logical-width-replaced.html:
  • fast/table/bad-replaced-sizing-preferred-logical-widths.html:
  • fast/table/margins-flipped-text-direction.html:
  • fast/table/margins-perpendicular-containing-block.html:
  • fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html:
  • fast/writing-mode/percentage-height-orthogonal-writing-modes.html:
  • resources/check-layout.js:
4:36 PM Changeset in webkit [130978] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL][WK2] Add toolbar buttons to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=98883

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add "back,forward,list,changed" signal on the Ewk_View
to notify the client when the view's back / forward
list has changed. This is useful for the UI to update
its back / forward buttons disabled state.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_back_forward_list_changed):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didChangeBackForwardList):

  • UIProcess/API/efl/ewk_view_private.h:

Tools:

Add toolbar buttons to MiniBrowser to support
navigation back / forward, refresh and go
to home page.

  • MiniBrowser/efl/main.c:

(_Browser_Window):
(on_back_forward_list_changed):
(on_back_button_clicked):
(on_forward_button_clicked):
(on_refresh_button_clicked):
(on_home_button_clicked):
(create_toolbar_button):
(window_create):

4:23 PM Changeset in webkit [130977] by jonlee@apple.com
  • 28 edits in trunk/Source

[WK2] Activate plugins when user clicks on snapshot
https://bugs.webkit.org/show_bug.cgi?id=98328
<rdar://problem/12426681>

Reviewed by Brady Eidson.

Source/WebCore:

Extend the default event handler to deal with plugins with snapshots.
When the user clicks on the placeholder, the plugin is recreated and displayed.

  • loader/FrameLoaderClient.h: Add new client function recreatePlugin(), which is

expected to re-create the plugin with the same parameters as when it was run to
obtain the plugin's snapshot placeholder.

  • loader/EmptyClients.cpp: Stub implementation of recreatePlugin().
  • loader/EmptyClients.h:
  • WebCore.exp.in: Expose HTMLPlugInElement::pluginWidget().
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler): Update to look for
RenderSnapshottedPlugIn. If the plugin is not playing, have the renderer handle the
event.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugin::getCursor): Set to hand cursor when the plugin is not
playing.
(WebCore::RenderSnapshottedPlugIn::handleEvent): If the user clicked on the plugin using the
left button, update the state of the element to playing. Recreate the plugin if the widget exists
to begin with. The cached snapshot image will be saved for possible reuse on back/forward navigation.

  • rendering/RenderSnapshottedPlugIn.h:

(RenderSnapshottedPlugIn):

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.h:

(WebKit::FrameLoaderClientImpl::recreatePlugin): Stub implementation of recreatePlugin().

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.h:

(WebCore::FrameLoaderClientEfl::recreatePlugin): Stub implementation of recreatePlugin().

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.h:

(WebKit::FrameLoaderClient::recreatePlugin): Stub implementation of recreatePlugin().

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::recreatePlugin): Stub implementation of recreatePlugin().

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.h:

(WebCore::FrameLoaderClientQt::recreatePlugin): Stub implementation of recreatePlugin().

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient::recreatePlugin): Stub implementation of recreatePlugin().

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.h:

(WebKit::FrameLoaderClientWinCE::recreatePlugin): Stub implementation of recreatePlugin().

Source/WebKit2:

Implement the recreation of the plugin.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::recreateAndInitialize): We can run into a situation where the user
decided to run the plugin before the snapshot was ready to be taken. In this case, the
plugin member variable is non-null, and the timer is still active. Turn off the timer, and
destroy that instance of the plugin. We set the plugin to the instance provided in the
first parameter to this function, and reset the member variables so that the PluginView is
in a state similar to when it was first created. We also immediately initialize the plugin,
which may happen synchronously or asynchronously.

  • WebProcess/Plugins/PluginView.h:

(WebKit::PluginView::initialParameters): Expose the initial parameters. Used to recreate
the plugin.
(WebKit::PluginView::pluginElement): Expose the element associated with the widget. Used to
recreate the plugin.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::recreatePlugin): Create a new Plugin instance using the same
parameters used to create the plugin for snapshotting. Forward that instance to the widget.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient): Implement recreatePlugin().

4:09 PM Changeset in webkit [130976] by jpfau@apple.com
  • 2 edits in trunk/LayoutTests

[Mac][WK2] Unreviewed, skipping fast/parser/document-open-in-unload.html

  • platform/mac-wk2/TestExpectations:
3:58 PM Changeset in webkit [130975] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Remove perf tests that haven't failed in the past 500 runs.

  • platform/chromium/TestExpectations:
3:50 PM Changeset in webkit [130974] by aestes@apple.com
  • 2 edits in trunk/Tools

Fix the Lion build after r130948.

  • TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3:41 PM Changeset in webkit [130973] by weinig@apple.com
  • 9 edits in trunk/Source/WebKit2

Fix 32-bit build.

  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMElement.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMElement.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
3:34 PM Changeset in webkit [130972] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

WebContext should be a MessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=98958

Reviewed by Sam Weinig.

Make WebContext be a MessageReceiver that lives in its own map. This allows us to get rid of the
knowsHowToHandleMessage functions on MessageReceiverMap and WebContext.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::client):
(Connection):

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::addMessageReceiver):
(CoreIPC::MessageReceiverMap::invalidate):
(CoreIPC::MessageReceiverMap::knowsHowToHandleMessage):
(CoreIPC::MessageReceiverMap::dispatchMessage):
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::dispatchMessage):
(WebKit::WebContext::dispatchSyncMessage):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::fromConnection):
(WebKit):
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

3:31 PM Changeset in webkit [130971] by weinig@apple.com
  • 2 edits
    8 adds in trunk/Source/WebKit2

Add skeleton of a WebKit2 ObjC DOM SPI (not intended to be the full DOM)
https://bugs.webkit.org/show_bug.cgi?id=98955

Reviewed by Anders Carlsson.

Add a skeleton DOM implementation only exposing Node, Element and Document
for now. It is currently only available in 64-bit as it relies on the non-fragile
ABI for now.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.h: Added.
  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm: Added.
  • WebProcess/InjectedBundle/API/mac/WKDOMElement.h: Added.
  • WebProcess/InjectedBundle/API/mac/WKDOMElement.mm: Added.
  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.h: Added.
  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm: Added.
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.h: Added.
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm: Added.
3:30 PM Changeset in webkit [130970] by aestes@apple.com
  • 2 edits in trunk/Tools

Speculative build fix for Snow Leopard after r130948.

  • TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: Pull the

declaration of backgroundColorQuery out of a block to appease GCC.

3:27 PM Changeset in webkit [130969] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

More unreviewed Chromium gardening.

  • platform/chromium/TestExpectations:

Removed 11 more entries that have not failed in last 100 runs according to the flakiness dashboard.

3:17 PM Changeset in webkit [130968] by bashi@chromium.org
  • 3 edits in trunk/Source/WebCore

FontVerticalDataCache should allow zero as a key value
https://bugs.webkit.org/show_bug.cgi?id=98877

Reviewed by Tony Chang.

Use WTF::UnsignedWithZeroKeyHashTraits for type definition of
FontVerticalDataCache.

No new tests because there is no certain way to make
FontPlatformDataHarfBuzz::uniqueID() be zero.

  • platform/graphics/FontCache.cpp:

(WebCore):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::verticalData): Removed zero check of uniqueID().
(WebCore::FontPlatformData::openTypeTable): Ditto.

3:11 PM Changeset in webkit [130967] by commit-queue@webkit.org
  • 9 edits in trunk

[WK2][WTR] WebKitTestRunner UI process should be aware of Custom Policy Delegate
https://bugs.webkit.org/show_bug.cgi?id=95974

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-10
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added TestController::decidePolicyForNavigationAction() function as a 'decidePolicyForNavigationAction' WKPagePolicyClient callback
for WTR UI process. WTR bundle client notifies UI process about Custom Policy Delegate via newly added message,
so that TestController is aware of whether Custom Policy Delegate as enabled and
permissive. This data is used then in TestController::decidePolicyForNavigationAction for making policy decision.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::setCustomPolicyDelegate):
(WTR):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setCustomPolicyDelegate):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::setCustomPolicyDelegate):
(WTR):
(WTR::TestController::decidePolicyForNavigationAction):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Unskipped fast/loader/onload-policy-ignore-for-frame.html for WK2.

  • platform/wk2/TestExpectations:
3:07 PM Changeset in webkit [130966] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[EFL] Use the shareable GraphicsContext3DOpenGL* implementation.
https://bugs.webkit.org/show_bug.cgi?id=96627

Patch by Regina Chung <heejin.r.chung@samsung.com> on 2012-10-10
Reviewed by Kenneth Rohde Christiansen.

Changed EFL implementation of GraphicsContext3D(GC3D) to use GraphicsContext3DOpenGL*.
It was initially implemented in a different way, due to characteristics of Evas,
but it would be better to use the common implementation and find another way
to deal with Evas, especially because all the duplicated code.

No new tests. No functional changes.

  • PlatformEfl.cmake: Removed cairo implementation of GC3D and added efl files to WebCore_SOURCES.
  • platform/graphics/efl/GraphicsContext3DEfl.cpp: Modified code so GC3DOpenGL* can be used.

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore::GraphicsContext3D::paintToCanvas):
(WebCore):
(WebCore::GraphicsContext3D::createGraphicsSurfaces):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::getImageData):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp: Removed functions implemented in GC3DOpenGL*

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createSurface):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/efl/GraphicsContext3DPrivate.h: Removed functions implemented in GC3DOpenGL*

(GraphicsContext3DPrivate):

2:40 PM Changeset in webkit [130965] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This test can also fail with TEXT.

  • platform/chromium/TestExpectations:
2:37 PM Changeset in webkit [130964] by jchaffraix@webkit.org
  • 6 edits
    2 adds in trunk/LayoutTests

Unreviewed Chromium gardening.

  • platform/chromium-linux/fast/repaint/reflection-repaint-test-expected.png:
  • platform/chromium-linux/fast/repaint/transform-layout-repaint-expected.png:
  • platform/chromium-mac/fast/repaint/reflection-repaint-test-expected.png: Added.
  • platform/chromium-mac/fast/repaint/transform-layout-repaint-expected.png: Added.
  • platform/chromium-win/fast/repaint/reflection-repaint-test-expected.png:
  • platform/chromium-win/fast/repaint/transform-layout-repaint-expected.png:

The flakiness dashboard was lying on this entry. After talking with Emil, the baselines are correct so
rebaselined these tests.

  • platform/chromium/TestExpectations:

Marked fast/dom/gc-dom-tree-lifetime.html as timeout as marking it slow didn't remove the flakiness.

2:36 PM Changeset in webkit [130963] by wjmaclean@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/platform/TouchFlingPlatformGestureCurve.cpp

Merge 130846 - [chromium] revert fling deacceleration parameter change
https://bugs.webkit.org/show_bug.cgi?id=98820

Reviewed by Adrienne Walker.

After an extended discussion, it has been decided that a previous
adjustment to fling deacceleration parameters should be reverted.

Tested by existing unit tests.

  • platform/TouchFlingPlatformGestureCurve.cpp:

(WebCore::TouchFlingPlatformGestureCurve::createForTouchPad):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchScreen):

TBR=rjkroege@chromium.org
Review URL: https://codereview.chromium.org/11085056

2:33 PM Changeset in webkit [130962] by tony@chromium.org
  • 11 edits
    1 move
    2 deletes in trunk

Unreviewed, rolling out r130937, r130949, r130955, and
r130957.
http://trac.webkit.org/changeset/130937
http://trac.webkit.org/changeset/130949
http://trac.webkit.org/changeset/130955
http://trac.webkit.org/changeset/130957
https://bugs.webkit.org/show_bug.cgi?id=94290

Breaks Qt build

.:

  • Source/cmake/WebKitMacros.cmake:

Source/WebCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_preprocessgrammar.py: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSGrammar.y: Renamed from Source/WebCore/css/CSSGrammar.y.in.
  • css/CSSGrammar.y.includes: Removed.
  • css/makegrammar.pl:
2:28 PM Changeset in webkit [130961] by abarth@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

When we check in image baselines, we use the -expected.png suffix
rather than the -actual.png suffix. (This is likely a typo in
http://trac.webkit.org/changeset/130940.)

  • platform/chromium-win/editing/spelling/inline-spelling-markers-hidpi-actual.png: Removed.
  • platform/chromium-win/editing/spelling/inline-spelling-markers-hidpi-expected.png: Copied from LayoutTests/platform/chromium-win/editing/spelling/inline-spelling-markers-hidpi-actual.png.
2:20 PM Changeset in webkit [130960] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Adapt to new image for search-cancel
https://bugs.webkit.org/show_bug.cgi?id=98954

Reviewed by Antonio Gomes.

The new image for search-cancel is bigger than the old one, so invert the scaling.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::adjustSearchFieldCancelButtonStyle):

2:18 PM Changeset in webkit [130959] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip the color-correction tests.

Just specifying `Missing' makes the build bots sometimes report
these tests as failing.

  • platform/efl/TestExpectations:
2:17 PM Changeset in webkit [130958] by junov@google.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed. Adding myself as Committer.

2:15 PM Changeset in webkit [130957] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, another speculative fix for Qt Win.

  • DerivedSources.pri: Pass --preprocessor to the perl script.
  • css/makegrammar.pl: Use --preprocessor instead of /usr/bin/gcc.
2:01 PM Changeset in webkit [130956] by zoltan@webkit.org
  • 9 edits in trunk

Pageload tests should measure memory usage
https://bugs.webkit.org/show_bug.cgi?id=93958

Reviewed by Ryosuke Niwa.

Add JS Heap and Heap memory measurement to PageLoad tests.

Source/JavaScriptCore:

  • heap/HeapStatistics.cpp:

(JSC::HeapStatistics::usedJSHeap): Add new private function to expose the used JS Heap size.
(JSC):

  • heap/HeapStatistics.h:

(HeapStatistics): Add new private function to expose the used JS Heap size.

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dump): Print memory results with DRT.

  • Scripts/old-run-webkit-tests:

(readFromDumpToolWithTimer): Hadle memory results.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(DriverOutput.init): Add new parameter for the results.
(Driver.init): Initialize the new parameter.
(Driver.run_test):
(Driver._read_first_block): Add support for the new headers.
(Driver._process_stdout_line):
(ContentBlock.init):

  • Scripts/webkitpy/performance_tests/perftest.py:

(PageLoadingPerfTest.calculate_statistics): Move statistics calculation into a function.
(PageLoadingPerfTest.run): Handle the new memory results.
(PageLoadingPerfTest.run.in):
(PageLoadingPerfTest):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py: Add test for memory results of pageloadtests.

(TestPageLoadingPerfTest.MockDriver.init):
(TestPageLoadingPerfTest.MockDriver.run_test):
(TestPageLoadingPerfTest.test_run_with_memory_output):

1:55 PM Changeset in webkit [130955] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, another speculative fix for Qt Win.

  • DerivedSources.pri: Make the path slash marks be forward slashes to the .in file.
1:52 PM Changeset in webkit [130954] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Add a note that this test is flaky and can trigger an ASSERT.

  • platform/chromium/TestExpectations:
1:51 PM Changeset in webkit [130953] by Lucas Forschler
  • 4 edits in branches/safari-536.28-branch/Source

Versioning.

1:46 PM Changeset in webkit [130952] by Lucas Forschler
  • 1 copy in branches/safari-536.28-branch

New Branch.

1:38 PM Changeset in webkit [130951] by ojan@chromium.org
  • 3 edits
    2 copies in branches/chromium/1271

Merge 130549 - Deprecated flexboxes subtract scrollbar width/height twice
https://bugs.webkit.org/show_bug.cgi?id=98552

Reviewed by Tony Chang.

Source/WebCore:

This is a regression from http://trac.webkit.org/changeset/119507.
The problem is that contentHeight subtracts the scrollbar and
RenderDeprecatedFlexbox subtracts the scrollbar.

-Make it so that we only access override sizes if one has been set.
I think this makes the calling code more clear.
-If we don't have one set, grab the height/width - borderAndPadding.
-Add a FIXME to change this all back to being borderbox sizes.
There's something trick with making table padding/border work right for that
though (noted in the original patch).

Test: fast/flexbox/flexing-overflow-scroll-item.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::overrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::contentWidthForChild):
(WebCore):
(WebCore::contentHeightForChild):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

LayoutTests:

  • fast/flexbox/flexing-overflow-scroll-item-expected.txt: Added.
  • fast/flexbox/flexing-overflow-scroll-item.html: Added.

TBR=ojan@chromium.org
Review URL: https://codereview.chromium.org/11017062

1:33 PM Changeset in webkit [130950] by Dave Barton
  • 6 edits in trunk

Turn on ENABLE_MATHML for Chromium
https://bugs.webkit.org/show_bug.cgi?id=96960

Reviewed by Adam Barth.

Source/WebCore:

Add the rendering/mathml directory to search.

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

We're enabling MathML now partly to let the automated fuzzers go to work. Some layout tuning will also be done in the
next few days, so we expect MathML pixel tests to be changing during that time.

  • platform/chromium/TestExpectations:
1:31 PM Changeset in webkit [130949] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, speculative build fix for Qt Win.

  • css/makegrammar.pl: Rather than making a temp file, use a pipe to

pass data from gcc to the final output file.

1:28 PM Changeset in webkit [130948] by aestes@apple.com
  • 26 edits
    3 adds in trunk

[WebKit2] Create an API for adding and removing user stylesheets from a page group
https://bugs.webkit.org/show_bug.cgi?id=98432

Reviewed by Sam Weinig.

Source/WebKit2:

This patch adds the following API to WKBrowsingContextGroup:

  • (void)addUserStyleSheet:(NSString *)source baseURL:(NSURL *)baseURL whitelist:(NSArray *)whitelist blacklist:(NSArray *)blacklist mainFrameOnly:(BOOL)mainFrameOnly;
  • (void)removeAllUserStyleSheets;

Sheets added via this API are sent to all processes that contain a page
in the given page group. Sheets are also cached in the UI process in a
new object called UserContentContainer, which is a property of each
group's WebPageGroupData and is sent to new web processes during page
initialization.

This is less than ideal, since new pages added to a pre-existing
process / page group combination will send redundant user stylesheet
strings over the wire. To avoid this we'd have to keep track track of
the groups that currently exist in each process and only send user
content during page creation if it is the first time a process has seen
the page's group. I decided to not add this complexity for the time
being, but we might need to consider it if we find that the current
approach impacts performance for clients that heavily utilize user
content.

  • Shared/API/c/WKArray.cpp:

(WKArrayCreateAdoptingValues): Add a WKArray creation function that
adopts the incoming WKTypeRefs rather than refing them.

  • Shared/API/c/WKArray.h:
  • Shared/API/c/WKBase.h: Move WKUserContentInjectedFrames out of

WKBundlePrivate.h so it can be used in WKPageGroup, too.

  • Shared/API/c/cf/WKURLCF.cpp:

(WKURLCreateWithCFURL): Return 0 for null CFURLRefs instead of crashing
inside CFURLGetString().

  • Shared/ImmutableArray.cpp:

(WebKit::ImmutableArray::ImmutableArray): Add a tag to differentiate
between the adopting and refing ctors.

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::create): Call the refing ctor.
(WebKit::ImmutableArray::adopt): Call the adopting ctor.

  • Shared/UserContentContainer.cpp: Added.

(UserContentItemMessageEncoder): Create a UserMessageEncoder for
serializing UserContentContainer::Item's APIObjects.
(WebKit::UserContentItemMessageEncoder::UserContentItemMessageEncoder):
(WebKit::UserContentItemMessageEncoder::encode):
(UserContentItemMessageDecoder): Create a UserMessageEncoder for
deserializing UserContentContainer::Item's APIObjects.
(WebKit::UserContentItemMessageDecoder::UserContentItemMessageDecoder):
(WebKit::UserContentItemMessageDecoder::decode):
(WebKit::UserContentContainer::Item::Item):
(WebKit::encodeStringArray): Add a helper function for encoding
ImmutableArrays of WebStrings.
(WebKit::UserContentContainer::Item::encode): Encode the item's
properties using UserContentItemMessageEncoder.
(WebKit::decodeStringArray): Add a helper function for decoding
ImmutableArrays of WebStrings.
(WebKit::UserContentContainer::Item::decode): Decode the item's
properties using UserContentItemMessageDecoder.
(WebKit::toStringVector): Add a helper function for converting an
ImmutableArray of WebStrings to a Vector of Strings.
(WebKit::UserContentContainer::Item::whitelist): Use toStringVector().
(WebKit::UserContentContainer::Item::blacklist): Ditto.
(WebKit::UserContentContainer::encode): Encode the Vector of UserContentContainer::Items.
(WebKit::UserContentContainer::decode): Decode the Vector of UserContentContainer::Items.

  • Shared/UserContentContainer.h: Added.
  • Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::encode): Include userStyleSheets when encoding.
(WebKit::WebPageGroupData::decode): Include userStyleSheets when decoding.

  • Shared/WebPageGroupData.h:

(WebPageGroupData): Add a UserContentContainer called userStyleSheets
to WebPageGroupData.

  • UIProcess/API/C/WKPageGroup.cpp: Add the C SPI version of the Objective-C API.

(WKPageGroupAddUserStyleSheet):
(WKPageGroupRemoveAllUserStyleSheets):

  • UIProcess/API/C/WKPageGroup.h:
  • UIProcess/API/mac/WKBrowsingContextGroup.h: Add the Objective-C API.
  • UIProcess/API/mac/WKBrowsingContextGroup.mm:

(createWKArray): Add a helper function that converts an NSArray of NSStrings to a WKArray of WKStrings.
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelist:blacklist:mainFrameOnly:]):
Implement the Objective-C API in terms of the C SPI.
(-[WKBrowsingContextGroup removeAllUserStyleSheets]): Ditto.

  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::addUserStyleSheet): Add the new sheet to the
group's WebPageGroupData, which ensures that the group's sheets are
sent to new web processes.
(WebKit::WebPageGroup::removeAllUserStyleSheets): Ditto for removal.

  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup): Add a helper message
that sends a message to all processes that have a page in the current
group. This is used to add new user sheets to already-initialized page
groups in the UI processes.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Moved

WKUserContentInjectedFrames from here to WKBase.h.

  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::WebPageGroupProxy): Add each sheet in the
WebPageGroupData to WebCore's page group.
(WebKit::WebPageGroupProxy::addUserStyleSheet): Add the sheet received
from the UI process to WebCore's page group.
(WebKit::WebPageGroupProxy::removeAllUserStyleSheets): Remove all
sheets from WebCore's page group.

  • WebProcess/WebPage/WebPageGroupProxy.h:
  • WebProcess/WebPage/WebPageGroupProxy.messages.in: Define

AddUserStyleSheet and RemoveAllUserStyleSheets, two messages sent from
the UI process to a web process's WebPageGroupProxy.

Tools:

Add three new API tests:

  • Test adding a user stylesheet before a page is created. This tests

the code path where the sheet is sent to the web process as part of
the new page's WebPageCreationParameters.

  • Test adding a user stylesheet after a page is created. This tests the

code patch where the sheet is sent as a separate message to all
processes containing the given page group.

  • Test removing all user stylesheets.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: Added.

(-[UserContentTestLoadDelegate initWithBlockToRunOnLoad:]):
(-[UserContentTestLoadDelegate browsingContextControllerDidFinishLoad:]):
(expectScriptValue):

  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1:23 PM Changeset in webkit [130947] by beidson@apple.com
  • 28 edits
    3 adds in trunk/Source

Switch CachedResource over from SharedBuffer to a new ResourceBuffer
https://bugs.webkit.org/show_bug.cgi?id=98541

Reviewed by Anders Carlsson.

Source/WebCore:

As part of preparation for a WebKit2 NetworkProcess, we need to change the data handle shared
between CachedResources and ResourceLoaders to be one that can be backed by something other
than a SharedBuffer.

ResourceBuffer is this new object. Right now it is directly backed by a SharedBuffer and there
should be no change in behavior.

No new tests (No behavior change).

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore.vcproj/WebCore.vcproj:
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:

Implementation of the new ResourceBuffer, backed directly by a SharedBuffer:

  • loader/ResourceBuffer.cpp: Added.

(WebCore):
(WebCore::ResourceBuffer::ResourceBuffer):
(WebCore::ResourceBuffer::~ResourceBuffer):
(WebCore::ResourceBuffer::data):
(WebCore::ResourceBuffer::size):
(WebCore::ResourceBuffer::isEmpty):
(WebCore::ResourceBuffer::getSomeData):
(WebCore::ResourceBuffer::sharedBuffer):
(WebCore::ResourceBuffer::copy):
(WebCore::ResourceBuffer::hasPurgeableBuffer):
(WebCore::ResourceBuffer::releasePurgeableBuffer):
(WebCore::ResourceBuffer::createCFData):

  • loader/ResourceBuffer.h: Added.

(WebCore):
(ResourceBuffer):
(WebCore::ResourceBuffer::create):
(WebCore::ResourceBuffer::adoptSharedBuffer):

  • loader/mac/ResourceBuffer.mm: Added.

(WebCore):
(WebCore::ResourceBuffer::createNSData):

Switch CachedResource over to using it:

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::makePurgeable):

  • loader/cache/CachedResource.h:

(WebCore):
(WebCore::CachedResource::resourceBuffer):
(CachedResource):

Switch all the other CachedResource subclasses over to using it:

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::data):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::data):
(WebCore::CachedFont::ensureCustomFontData):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::didAddClient):
(WebCore::CachedImage::data):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::data):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::data):

  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::data):

  • loader/cache/CachedTextTrack.cpp:

(WebCore::CachedTextTrack::data):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::data):

Switch other affect parties over to using it:

  • inspector/InspectorPageAgent.cpp:

(WebCore::decodeBuffer):
(WebCore::InspectorPageAgent::cachedResourceContent):
(WebCore::InspectorPageAgent::sharedBufferContent):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::subresource):

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::processNewCueData):
(WebCore::TextTrackLoader::didReceiveData):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::notifyFinished):

  • platform/mac/PasteboardMac.mm:

(WebCore::fileWrapperForImage):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):

Source/WebKit/win:

  • WebDataSource.cpp:

(WebDataSource::subresourceForURL):

1:22 PM Changeset in webkit [130946] by kareng@chromium.org
  • 3 edits
    1 copy in branches/chromium/1271/Source/WebKit/chromium

Merge 130691 - Mac Chromium: Ignore system numpad modifier
https://bugs.webkit.org/show_bug.cgi?id=97161

Patch by Sailesh Agrawal <sail@chromium.org> on 2012-10-08
Reviewed by Tony Chang.

On Mac, arrow key events have numpad modifier set. This is inconsistent with other platforms.

My fix is to only rely on keycode to decide when to set the numpad modifier.

This code is not exersided by layout tests so I added a new unit test for this.

  • WebKit.gypi:
  • WebKitUnitTests.gyp:
  • src/mac/WebInputEventFactory.mm:

(WebKit::isKeypadEvent): Removed check for numpad modifier.

  • tests/WebInputEventFactoryTestMac.mm: Added.

(TEST): Added new test for WebInputEventFactory::keyboardEvent().

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11088058

1:18 PM Changeset in webkit [130945] by piman@chromium.org
  • 1 edit
    2 adds in trunk/Source/Platform

[chromium] Add empty WebCompositorFrame/WebCompositorFrameAck
https://bugs.webkit.org/show_bug.cgi?id=98841

Reviewed by James Robinson.

These were used in the WebKit API but never defined.

  • chromium/public/WebCompositorFrame.h: Added.

(WebKit):

  • chromium/public/WebCompositorFrameAck.h: Added.

(WebKit):

12:59 PM Changeset in webkit [130944] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r130940.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker):
Avoid redefining the same variable twice.

12:49 PM Changeset in webkit [130943] by alexis@webkit.org
  • 2 edits in trunk/Source/WebCore

[Mac] Deprecate getPropertyShorthand from objective c bindings for future removal
https://bugs.webkit.org/show_bug.cgi?id=98916

Reviewed by Timothy Hatcher.

Mark getPropertyShorthand as deprecated so we can remove it later. It will allow us
to remove getPropertyShorthand from the web exposed API (this function is not part of
any specification, it was there for historical reason).

No new tests : just mark a function as deprecated.

  • bindings/objc/PublicDOMInterfaces.h:
12:29 PM Changeset in webkit [130942] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

  • platform/chromium/TestExpectations:

Removed 10 entries that have not failed in last 100 runs according to the flakiness dashboard.

12:23 PM Changeset in webkit [130941] by mkwst@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: add support for %c (style) in console API
https://bugs.webkit.org/show_bug.cgi?id=69401

Reviewed by Pavel Feldman.

Source/WebCore:

This patch mimics Firebug's '%c' option when calling 'console.log'
messages. 'console.log("%cBlue!", "color: blue;");' will write blue
text to the console, and so on.

To match Firebug's behavior, multiple '%c' entries will overwrite each
other: only one style will be applied. Sorry, folks.

Test: inspector/console/console-format-style.html

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString.styleFormatter):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString.append):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):

LayoutTests:

  • http/tests/inspector/console-test.js:

(initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithStyles):

Helper to dump the style associated with a console message.

  • inspector/console/console-format-style-expected.txt: Added.
  • inspector/console/console-format-style.html: Added.
12:15 PM Changeset in webkit [130940] by commit-queue@webkit.org
  • 8 edits
    10 adds in trunk

[chromium] Spelling and grammar markers are pixelated in hidpi.
https://bugs.webkit.org/show_bug.cgi?id=98339

Patch by Varun Jain <varunjain@chromium.org> on 2012-10-10
Reviewed by Stephen White.

We create separate bitmaps for markers in normal and hidpi mode as per
specification from UX and choose the right bitmap based on the current
device scale factor.

Source/WebCore:

Tests: editing/spelling/grammar-markers-hidpi.html

editing/spelling/inline-spelling-markers-hidpi.html

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::draw2xMarker):
(WebCore):
(WebCore::draw1xMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::deviceScaleFactor):
(WebCore::PlatformContextSkia::setDeviceScaleFactor):
(PlatformContextSkia):

Source/WebKit/chromium:

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::paint):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paintRootLayer):

LayoutTests:

  • editing/spelling/grammar-markers-hidpi-expected.txt: Added.
  • editing/spelling/grammar-markers-hidpi.html: Added.
  • editing/spelling/inline-spelling-markers-hidpi-expected.txt: Added.
  • editing/spelling/inline-spelling-markers-hidpi.html: Added.
  • platform/chromium-linux/editing/spelling/grammar-markers-hidpi-expected.png: Added.
  • platform/chromium-linux/editing/spelling/inline-spelling-markers-hidpi-expected.png: Added.
  • platform/chromium-mac/editing/spelling/grammar-markers-hidpi-expected.png: Added.
  • platform/chromium-mac/editing/spelling/inline-spelling-markers-hidpi-expected.png: Added.
  • platform/chromium-win/editing/spelling/grammar-markers-hidpi-expected.png: Added.
  • platform/chromium-win/editing/spelling/inline-spelling-markers-hidpi-actual.png: Added.
12:06 PM Changeset in webkit [130939] by commit-queue@webkit.org
  • 34 edits in trunk/Source/WebKit2

Make all of the WebContext sub objects MessageReceivers
https://bugs.webkit.org/show_bug.cgi?id=98661

Patch by Sam Weinig <sam@webkit.org> on 2012-10-10
Reviewed by Anders Carlsson.

Start work towards simplified message dispatch.

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::clearAllMessageReceivers):
(CoreIPC::MessageReceiverMap::knowsHowToHandleMessage):
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

Add additional helper methods.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):
(WebKit::WebContext::addMessageReceiver):
(WebKit::WebContext::knowsHowToHandleMessage):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):

  • UIProcess/WebContext.h:

Add a MessageReceiverMap that chains to the main on in WebProcessProxy. Simplifies
didReceiveMessage and didReceiveSyncMessage.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
Use the new WebContext methods to simplify dispatch.

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):

  • UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

  • UIProcess/WebBatteryManagerProxy.cpp:

(WebKit::WebBatteryManagerProxy::WebBatteryManagerProxy):

  • UIProcess/WebBatteryManagerProxy.h:

(WebBatteryManagerProxy):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):

  • UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy):
(WebKit::WebDatabaseManagerProxy::didReceiveMessage):
(WebKit):

  • UIProcess/WebDatabaseManagerProxy.h:

(WebDatabaseManagerProxy):

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):

  • UIProcess/WebGeolocationManagerProxy.h:

(WebGeolocationManagerProxy):

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::WebIconDatabase):

  • UIProcess/WebIconDatabase.h:

(WebIconDatabase):
(WebKit::WebIconDatabase::type):

  • UIProcess/WebKeyValueStorageManagerProxy.cpp:

(WebKit::WebKeyValueStorageManagerProxy::WebKeyValueStorageManagerProxy):

  • UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

  • UIProcess/WebNetworkInfoManagerProxy.cpp:

(WebKit::WebNetworkInfoManagerProxy::WebNetworkInfoManagerProxy):
(WebKit::WebNetworkInfoManagerProxy::didReceiveSyncMessage):

  • UIProcess/WebNetworkInfoManagerProxy.h:

(WebNetworkInfoManagerProxy):

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::WebResourceCacheManagerProxy):
(WebKit::WebResourceCacheManagerProxy::didReceiveMessage):
(WebKit):

  • UIProcess/WebResourceCacheManagerProxy.h:

(WebResourceCacheManagerProxy):

  • UIProcess/WebVibrationProxy.cpp:

(WebKit::WebVibrationProxy::WebVibrationProxy):

  • UIProcess/WebVibrationProxy.h:

(WebVibrationProxy):

  • UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::WebSoupRequestManagerProxy):
(WebKit::WebSoupRequestManagerProxy::didReceiveMessage):
(WebKit):

  • UIProcess/soup/WebSoupRequestManagerProxy.h:

(WebSoupRequestManagerProxy):

  • WebProcess/Authentication/AuthenticationManager.h:

(AuthenticationManager):

  • WebProcess/Geolocation/WebGeolocationManager.h:

(WebGeolocationManager):
Make all the WebContext sub-objects MessageReceivers to simplify dispatch.

11:36 AM Changeset in webkit [130938] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Suppress keyboard requests while processing spell checking suggestions unless focus change is occurring..
https://bugs.webkit.org/show_bug.cgi?id=98903

Reviewed by Rob Buis.

PR 221143.

Suppress keyboard state changes when they are not triggered by
focus changes.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):

  • WebKitSupport/InputHandler.h:
11:34 AM Changeset in webkit [130937] by commit-queue@webkit.org
  • 11 edits
    1 move
    2 adds in trunk

Pre-process CSSGrammar.y before running through bison.
https://bugs.webkit.org/show_bug.cgi?id=94290

Patch by Pablo Flouret <pablof@motorola.com> on 2012-10-10
Reviewed by Tony Chang.

.:

  • Source/cmake/WebKitMacros.cmake:

Use WebCore/css/makegrammar.pl to generate bison grammar files.

Source/WebCore:

Running CSSGrammar.y through a preprocessor allows the use of feature
defines in all places of the yacc file (i.e. not just in C blocks).
Mostly useful to be able to keep every part of a feature under feature
flags for self-documenting purposes.

No new tests, CSSGrammar.y should be generated correctly and everything
should keep working as before.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:

Modify build systems to use makegrammar.pl to generate the .y files
and run those through bison.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_preprocessgrammar.py: Added.

Add a new action to preprocess the CSSGrammar.y.in file before the
bison rule is run.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Add the new .y.in / .y.includes files.

  • css/CSSGrammar.y.in: Renamed from Source/WebCore/css/CSSGrammar.y.

Also moved the top declarations section that has includes, defines,
etc. to its own file. These shouldn't be touched by the first
pass of the preprocessor. And changed the existing ENABLE(FEATURE)
ifdefs to ENABLE_FEATURE since the ENABLE() macro is not available
yet.

  • css/CSSGrammar.y.includes: Added.

The aforementioned declarations header section. After the .y.in file
is processed it will be concatenated with this one to make the
CSSGrammar.y file.

  • css/makegrammar.pl:

Modify the script to handle .y.in files.

11:31 AM Changeset in webkit [130936] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

These tests appear to pass now.

  • platform/chromium/TestExpectations:
11:23 AM Changeset in webkit [130935] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

RegisterFile to JSStack rename fix for a struct member.

Compilation problem in debug build on MIPS
https://bugs.webkit.org/show_bug.cgi?id=98808

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2012-10-10
Reviewed by Alexey Proskuryakov.

In ASSERT conditions structure field name "registerFile" was replaced
with type name "JSStack" and it should be "stack".

  • jit/JITStubs.cpp:

(JSC::JITThunks::JITThunks): structure member name fix.

11:17 AM Changeset in webkit [130934] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[chromium] Add attribute for disabling automatic flushes
https://bugs.webkit.org/show_bug.cgi?id=98834

Patch by John Bauman <jbauman@chromium.org> on 2012-10-10
Reviewed by Kenneth Russell.

This attribute allows the compositor context to specify that it wants
to handle flushing itself.

  • chromium/public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::Attributes::Attributes):
(Attributes):

11:15 AM Changeset in webkit [130933] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

These tests appear to pass.

  • platform/chromium/TestExpectations:
11:15 AM Changeset in webkit [130932] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Add the mangled symbol name for Frame::layerTreeAsText() to the confusingly named
Windows export file.

  • win/WebKit2.def:
11:08 AM Changeset in webkit [130931] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

After r130344, OpaqueJSString::string() shouldn't directly return the wrapped String
https://bugs.webkit.org/show_bug.cgi?id=98801

Reviewed by Geoffrey Garen.

Return a copy of the wrapped String so that the wrapped string cannot be turned into
an Identifier.

  • API/OpaqueJSString.cpp:

(OpaqueJSString::string):

  • API/OpaqueJSString.h:

(OpaqueJSString):

11:07 AM Changeset in webkit [130930] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

EventHandler::handleGestureLongPress breaks compilation if CONTEXT_MENUS isn't set
https://bugs.webkit.org/show_bug.cgi?id=98890

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-10-10
Reviewed by Caio Marcelo de Oliveira Filho.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureLongPress):

11:01 AM Changeset in webkit [130929] by Simon Fraser
  • 2 edits in trunk

Attempt to fix gtk build which controls exports via this mysteriously-named
file.

  • Source/autotools/symbols.filter:
10:57 AM Changeset in webkit [130928] by dgrogan@chromium.org
  • 8 edits in trunk

Inspector: display IndexedDB integer versions
https://bugs.webkit.org/show_bug.cgi?id=95816

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Added basic test to database-structure.html

  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.Database):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDatabaseView):
(WebInspector.IDBDatabaseView.prototype._refreshDatabase):

LayoutTests:

  • http/tests/inspector/indexeddb/database-structure-expected.txt:
  • http/tests/inspector/indexeddb/database-structure.html:
10:49 AM Changeset in webkit [130927] by Simon Fraser
  • 19 edits in trunk/Source

Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText
https://bugs.webkit.org/show_bug.cgi?id=98839

Reviewed by Sam Weinig.

Source/WebCore:

To replace CATiledLayer with TileCaches, we need to be able to compute the visible part of a GraphicsLayer,
in order to limit the extent of TileCache tiles. Reuse the existing code in GraphicsLayerCA for this,
but store the computed rect in m_visibleRect.

Add a flag to layerTreeAsText() so that tests can optionally include this visible rect in
layer tree dumps. This output will be platform-specific, so we don't want to do it unconditionally.

  • WebCore.exp.in: Signature of Frame::layerTreeAsText() changed.
  • page/Frame.cpp:

(WebCore::Frame::layerTreeAsText): Change to take some enum flags rather than just a bool.

  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::writeIndent): Make into a static class method so subclasses can use it.
(WebCore::GraphicsLayer::dumpProperties): Call a virtual dumpAdditionalProperties() for subclasses.
(showGraphicsLayerTree):

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer): New LayerTreeAsTextIncludeVisibleRects flag.
(WebCore::GraphicsLayer::dumpAdditionalProperties): New virtual method.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges): clipRectForChildren and clipRectForSelf
were previously unused and buggy. Fix to correctly compute clipRectForSelf, to assign
to m_visibleRect.
(WebCore::GraphicsLayerCA::dumpAdditionalProperties): Dump m_visibleRect.

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText): Convert the flags from Frame flags
to GraphicsLayerFlags and pass them along.

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText): Overloaded method to handle the optional IDL arguments.

  • testing/Internals.h: Add enum.
  • testing/Internals.idl: Add optional flags, and a const short to describe the flags.

Source/WebKit/chromium:

Add a flag to layerTreeAsText() so that tests can optionally include this visible rect in
layer tree dumps. This output will be platform-specific, so we don't want to do it unconditionally.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::layerTreeAsText):

Source/WebKit/mac:

To replace CATiledLayer with TileCaches, we need to be able to compute the visible part of a GraphicsLayer,
in order to limit the extent of TileCache tiles. Reuse the existing code in GraphicsLayerCA for this,
but store the computed rect in m_visibleRect.

Add a flag to layerTreeAsText() so that tests can optionally include this visible rect in
layer tree dumps. This output will be platform-specific, so we don't want to do it unconditionally.

  • WebView/WebFrame.mm:

(-[WebFrame _layerTreeAsText]):

Source/WebKit2:

Add a flag to layerTreeAsText() so that tests can optionally include this visible rect in
layer tree dumps. This output will be platform-specific, so we don't want to do it unconditionally.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::layerTreeAsText):

10:47 AM Changeset in webkit [130926] by shinyak@chromium.org
  • 13 edits
    2 adds in trunk

Needs internal API to return distributed nodes for InsertionPoint
https://bugs.webkit.org/show_bug.cgi?id=98868

Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

When testing insertion points, we would like to have an internal API which returns a node list
distributed to an insertion point.

We've added the API in Internals.

Test: fast/dom/shadow/distributed-nodes.html

  • WebCore.exp.in:
  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::distributedNodes): Returns the distributed nodes. When InsertionPoint is not
attached, the result will be null, since the distribution is not calculated correctly.
(WebCore):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):

  • testing/Internals.cpp:

(WebCore::Internals::distributedNodes):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/distributed-nodes-expected.txt: Added.
  • fast/dom/shadow/distributed-nodes.html: Added.
10:42 AM Changeset in webkit [130925] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium]Android x86 content shell debug build warning for uninitialized value used as error with gcc 4.6
https://bugs.webkit.org/show_bug.cgi?id=98629

Patch by Wei James <james.wei@intel.com> on 2012-10-10
Reviewed by Adam Barth.

Warning was taken as error for uninitialized value being used when
building content shell for Android x86 with gcc 4.6.

  • WebCore.gyp/WebCore.gyp:
10:42 AM Changeset in webkit [130924] by mitz@apple.com
  • 2 edits in trunk/Tools

Changed debug-safari, debug-minibrowser and debug-test-runner to use LLDB by default when
using Xcode 4.5 or later.

Reviewed by Anders Carlsson.

  • Scripts/webkitdirs.pm:

(determineDebugger): Changed the default debugger from GDB to LLDB when the Xcode version
is 4.5 or later. Added a --use-gdb switch for overriding this.
(printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Updated to mention --use-gdb and the
how the default debugger choice depends on the Xcode version. Also changed the description
of --no-saved-state to use the same terminology Xcode’s scheme editor uses to describe this
option, and clarified to which OS X versions it applies.

10:32 AM Changeset in webkit [130923] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed watch list addition.

Patch by Antonio Gomes <agomes@rim.com> on 2012-10-10

  • Scripts/webkitpy/common/config/watchlist:
10:30 AM Changeset in webkit [130922] by dpranke@chromium.org
  • 3 edits in trunk/Tools

NRWT crashes on too many timeouts
https://bugs.webkit.org/show_bug.cgi?id=97047

Reviewed by Tony Chang.

Apparently if you kill a subprocess directly python doesn't
auto-close the file descriptors.

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._reset):

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
10:26 AM Changeset in webkit [130921] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[TestResultServer] Enable CORS for test files
https://bugs.webkit.org/show_bug.cgi?id=98918

Reviewed by Dirk Pranke.

Serve the JSON test files with the Access-Control-Allow-Origin
response header to enable cross-origin sharing of these files.
This eases up hacking on TestResultServer.

  • TestResultServer/handlers/testfilehandler.py:

(GetFile._serve_json):

10:25 AM Changeset in webkit [130920] by peter@chromium.org
  • 12 edits
    325 adds in trunk/LayoutTests

Update more baselines and some entries in TestExpectations for Android.

Unreviewed rebaselining.

  • platform/chromium-android/compositing/: 5 new baselines.
  • platform/chromium-android/css2.1/: 5 new baselines.
  • platform/chromium-android/css3/: 2 new baselines.
  • platform/chromium-android/editing/: 5 new baselines.
  • platform/chromium-android/fast/: 67 new baselines.
  • platform/chromium-android/http/: 3 new baselines.
  • platform/chromium-android/ietestcenter/: 4 new baselines.
  • platform/chromium-android/platform/: 51 new baselines.
  • platform/chromium-android/svg/: 111 new baselines.
  • platform/chromium-android/tables/: 57 new baselines.
  • platform/chromium-android/transitions/: 1 new baseline.
  • platform/chromium/TestExpectations:
10:15 AM WebKitGtkLayoutTests edited by mrobinson@webkit.org
Move GTK+ API test dependencies to the main list, add more prominent … (diff)
10:14 AM Changeset in webkit [130919] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

  • platform/chromium/TestExpectations:

Amend bad change from r130904, the test *IS* timing out on all Debug platforms,
not just on Android Debug.

10:11 AM Changeset in webkit [130918] by commit-queue@webkit.org
  • 8 edits
    1 move
    1 add
    7 deletes in trunk

[CSS Regions] Create a separate list for the invalid regions
https://bugs.webkit.org/show_bug.cgi?id=98752

Patch by Andrei Bucur <abucur@adobe.com> on 2012-10-10
Reviewed by Andreas Kling.

Source/WebCore:

This patch moves the invalid regions in a low traffic data structure, outside the main region list. This should add a small performance boost (there's no test for it) and simplifies the code in the following ways:

  • iterations through the region list don't need to worry about invalid regions
  • accessing the first/last region is straightforward
  • list manipulations are easier to implement (e.g. binary search for a region)

Tests: Adapted fast/regions/flows-dependency-same-flow.html to use the new dump format for the region chain.

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::getRegionsByContent): Now returns only the valid regions.
(WebCore::WebKitNamedFlow::getRegions): Now returns only the valid regions.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::updateLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore::RenderFlowThread::regionInRange):
(WebCore::RenderFlowThread::checkRegionsWithStyling):
(WebCore::RenderFlowThread::objectInFlowRegion):
(WebCore::RenderFlowThread::autoLogicalHeightRegionsCount):

  • rendering/RenderFlowThread.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore):
(WebCore::addRegionToList):
(WebCore::RenderNamedFlowThread::addRegionToThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):

  • rendering/RenderNamedFlowThread.h:

(WebCore::RenderNamedFlowThread::invalidRenderRegionList):
(RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::canBeDestroyed):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderRegionList):
(WebCore):
(WebCore::writeRenderNamedFlowThreads): The valid regions are listed first followed by the invalid regions.

LayoutTests:

The result for fast/regions/flows-dependency-same-flow.html was adapted to the new dump format.
Also, the platform expected results files were removed and a generic baseline was added.

  • fast/regions/flows-dependency-same-flow-expected.png: Added.
  • fast/regions/flows-dependency-same-flow-expected.txt: Renamed from LayoutTests/platform/qt/fast/regions/flows-dependency-same-flow-expected.txt.
  • platform/efl/fast/regions/flows-dependency-same-flow-expected.png: Removed.
  • platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Removed.
  • platform/gtk/fast/regions/flows-dependency-same-flow-expected.png: Removed.
  • platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt: Removed.
  • platform/mac/fast/regions/flows-dependency-same-flow-expected.png: Removed.
  • platform/mac/fast/regions/flows-dependency-same-flow-expected.txt: Removed.
  • platform/qt/fast/regions/flows-dependency-same-flow-expected.png: Removed.
9:51 AM Changeset in webkit [130917] by rakuco@webkit.org
  • 2 edits
    9 deletes in trunk/LayoutTests

[EFL] Remove a few wrong expectations from the tree and properly skip the tests.

  • platform/efl/TestExpectations:
  • platform/efl/fast/css/color-correction-backgrounds-and-text-expected.png: Removed.
  • platform/efl/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-expected.png: Removed.
  • platform/efl/fast/css/color-correction-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-background-image-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-untagged-images-expected.txt: Removed.
9:45 AM Changeset in webkit [130916] by rakuco@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] More gardening.

  • platform/efl/TestExpectations: Unskip a few tests which have had

their pixel expectations committed.

  • platform/efl/svg/css/text-gradient-shadow-expected.png: Added.
9:44 AM Changeset in webkit [130915] by zandobersek@gmail.com
  • 2 edits
    5 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining tests after r130851.

  • platform/gtk/fast/text/justify-ideograph-complex-expected.txt:
  • platform/gtk/platform: Added.
  • platform/gtk/platform/gtk: Added.
  • platform/gtk/platform/gtk/fonts: Added.
  • platform/gtk/platform/gtk/fonts/complex-text-shadows-expected.txt: Added.
  • platform/gtk/platform/gtk/fonts/font-face-with-complex-text-expected.txt: Added.
9:22 AM Changeset in webkit [130914] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Regression] Stale revisions are not cleared when inspector is opened for the already loaded page.
https://bugs.webkit.org/show_bug.cgi?id=98915

Reviewed by Alexander Pavlov.

WorkspaceController now clears stale revisions on navigation as well.

  • inspector/front-end/Workspace.js:

(WebInspector.WorkspaceController):
(WebInspector.WorkspaceController.prototype._mainFrameNavigated):

9:20 AM Changeset in webkit [130913] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Exception when committing java script editing with revision history view open.
https://bugs.webkit.org/show_bug.cgi?id=98908

Reviewed by Alexander Pavlov.

Added null check.

  • inspector/front-end/RevisionHistoryView.js:
9:11 AM Changeset in webkit [130912] by rjkroege@chromium.org
  • 3 edits in branches/chromium/1271/Source/WebCore/platform/chromium

Merge 130513 - [chromium] Only inflate the height of rows in a popup menu when a touch device is detected.
https://bugs.webkit.org/show_bug.cgi?id=98515

Patch by Kevin Ellis <kevers@chromium.org> on 2012-10-05
Reviewed by Adam Barth.

Enforces a minimum row height for popup menus when a touch device is
detected. In a previous patch (r127597), the sizing of popup was
consolidated for touch and non-touch. Based on user feedback, reverting
to the old behavior for non-touch and only adding padding for touch
devices seems like a much safer strategy. This patch is not a direct
revert of r127567 since the padding previously used for touch is a bit
excessive.

Covered by existing tests.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore):

  • platform/chromium/PopupMenuChromium.h:

(WebCore::PopupMenuChromium::optionRowHeightForTouch):
(WebCore::PopupMenuChromium::setOptionRowHeightForTouch):
(PopupMenuChromium):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11099038

8:59 AM Changeset in webkit [130911] by rakuco@webkit.org
  • 1 edit
    83 adds in trunk/LayoutTests

[EFL] Add more missing pixel expectations to lots of different directories.

  • platform/efl/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/efl/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
  • platform/efl/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/efl/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/efl/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/efl/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
  • platform/efl/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
  • platform/efl/compositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/efl/editing/pasteboard/drag-drop-dead-frame-expected.png: Added.
  • platform/efl/editing/selection/5354455-2-expected.png: Added.
  • platform/efl/editing/undo/4063751-expected.png: Added.
  • platform/efl/editing/undo/5378473-expected.png: Added.
  • platform/efl/editing/undo/redo-typing-001-expected.png: Added.
  • platform/efl/editing/undo/undo-combined-delete-boundary-expected.png: Added.
  • platform/efl/editing/undo/undo-combined-delete-expected.png: Added.
  • platform/efl/editing/undo/undo-delete-boundary-expected.png: Added.
  • platform/efl/editing/undo/undo-delete-expected.png: Added.
  • platform/efl/editing/undo/undo-forward-delete-boundary-expected.png: Added.
  • platform/efl/editing/undo/undo-forward-delete-expected.png: Added.
  • platform/efl/editing/undo/undo-misspellings-expected.png: Added.
  • platform/efl/editing/undo/undo-typing-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-002-expected.png: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-003-expected.png: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-004-expected.png: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-005-expected.png: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-006-expected.png: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-007-expected.png: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-009-expected.png: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-010-expected.png: Added.
  • platform/efl/printing/iframe-print-expected.png: Added.
8:58 AM Changeset in webkit [130910] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: protect node in the InspectorDOMNode::inspect
https://bugs.webkit.org/show_bug.cgi?id=98914

Reviewed by Yury Semikhatsky.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::inspect):

8:48 AM Changeset in webkit [130909] by yoli@rim.com
  • 4 edits in trunk

[BlackBerry] Define WTF_USE_EXTRA_MACROS in cmake rather than Platform.h
https://bugs.webkit.org/show_bug.cgi?id=98819

Reviewed by Rob Buis.

And make it depend on SHARED_CORE
RIM PR# 221339.

.:

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WTF:

  • wtf/Platform.h:
8:45 AM Changeset in webkit [130908] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] svg/W3C-SVG-1.1/animate-elem-08-t.svg needs rebaselining after r130840
https://bugs.webkit.org/show_bug.cgi?id=98910

Unreviewed, rebaseline GTK+ test results.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-10

  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
8:42 AM WebInspector edited by lindahomes9@gmail.com
(diff)
8:38 AM Changeset in webkit [130907] by allan.jensen@digia.com
  • 1 edit
    4 copies
    5 moves
    3 adds in trunk/LayoutTests

[Qt] REGRESSION: 5 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=90687

Unreviewed gardening after r129234.

Moves the Qt 5 specific results to qt-5.0 directory, while moving the old results to qt-4.8.

  • platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Copied from LayoutTests/platform/qt/http/tests/xmlhttprequest/methods-expected.txt.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Copied from LayoutTests/platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Copied from LayoutTests/platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Copied from LayoutTests/platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt.
  • platform/qt-5.0/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt.
  • platform/qt-5.0/http/tests/xmlhttprequest/methods-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/xmlhttprequest/methods-expected.txt.
  • platform/qt-5.0/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt.
  • platform/qt-5.0/http/tests/xmlhttprequest/workers/methods-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt.
  • platform/qt-5.0/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt.
8:34 AM Changeset in webkit [130906] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Record that these tests have additional failure modes.

  • platform/chromium/TestExpectations:
8:33 AM WebKitGtkLayoutTests edited by Andres Gomez
(diff)
8:27 AM Changeset in webkit [130905] by kling@webkit.org
  • 2 edits in trunk/Tools

Future-proof the WTF.DoubleHashCollisions test.
<http://webkit.org/b/98853>

Reviewed by Anders Carlsson.

Add a check that the two keys that are supposed to clobber each other actually end up
in the same bucket with the DefaultHash<double> hash function.

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::bucketForKey):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

8:18 AM Changeset in webkit [130904] by peter@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium-Android] Another batch of TestExpectation updates for Android
https://bugs.webkit.org/show_bug.cgi?id=98909

Unreviewed test expectation update.

Many of the failures were actually ImageOnlyFailure, which isn't part
of the Failure state. This also includes a number of new expected
results, mostly focusing on crashing and timing out tests.

  • platform/chromium-android/TestExpectations:
  • platform/chromium/TestExpectations:
8:04 AM Changeset in webkit [130903] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test platform/chromium/fast/forms/*/*-suggestion-picker-*-operations.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=98906

  • platform/chromium/TestExpectations:
7:49 AM Changeset in webkit [130902] by rakuco@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[EFL] Add some css3 expectations, rebaseline a css2.1 PNG.

  • platform/efl/css2.1/20110323/abspos-containing-block-initial-001-expected.png:
  • platform/efl/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/efl/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/efl/css3/images/cross-fade-background-size-expected.png: Added.
7:32 AM Changeset in webkit [130901] by rakuco@webkit.org
  • 1 edit
    124 adds in trunk/LayoutTests

[EFL] Hopefully finish adding SVG pixel expectations.

  • platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
  • platform/efl/svg/as-background-image/animated-svg-as-background-expected.png: Added.
  • platform/efl/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
  • platform/efl/svg/as-background-image/background-image-tiled-expected.png: Added.
  • platform/efl/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
  • platform/efl/svg/as-background-image/svg-as-background-2-expected.png: Added.
  • platform/efl/svg/as-background-image/svg-as-background-5-expected.png: Added.
  • platform/efl/svg/as-background-image/svg-as-background-6-expected.png: Added.
  • platform/efl/svg/as-background-image/svg-as-background-expected.png: Added.
  • platform/efl/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Added.
  • platform/efl/svg/as-background-image/svg-as-tiled-background-expected.png: Added.
  • platform/efl/svg/as-background-image/svg-background-partial-redraw-expected.png: Added.
  • platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.png: Added.
  • platform/efl/svg/as-image/image-respects-pageScaleFactor-change-expected.png: Added.
  • platform/efl/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
  • platform/efl/svg/as-image/svg-as-image-expected.png: Added.
  • platform/efl/svg/as-image/svg-as-relative-image-expected.png: Added.
  • platform/efl/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
  • platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/efl/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/efl/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/efl/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
  • platform/efl/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/efl/svg/carto.net/combobox-expected.png: Added.
  • platform/efl/svg/carto.net/scrollbar-expected.png: Added.
  • platform/efl/svg/carto.net/selectionlist-expected.png: Added.
  • platform/efl/svg/carto.net/textbox-expected.png: Added.
  • platform/efl/svg/clip-path/clip-in-clip-expected.png: Added.
  • platform/efl/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
  • platform/efl/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-clipped-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-clipped-nonzero-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-objectBoundingBox-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-on-clipped-use-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-on-g-and-child-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-on-g-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-on-svg-and-child-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-on-svg-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-recursive-call-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-text-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-transform-2-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Added.
  • platform/efl/svg/css/arrow-with-shadow-expected.png: Added.
  • platform/efl/svg/css/background-image-svg-expected.png: Added.
  • platform/efl/svg/css/circle-in-mask-with-shadow-expected.png: Added.
  • platform/efl/svg/css/composite-shadow-text-expected.png: Added.
  • platform/efl/svg/css/css-box-min-width-expected.png: Added.
  • platform/efl/svg/css/path-with-shadow-expected.png: Added.
  • platform/efl/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
  • platform/efl/svg/css/shadow-and-opacity-expected.png: Added.
  • platform/efl/svg/css/shadow-with-large-radius-expected.png: Added.
  • platform/efl/svg/css/shadow-with-negative-offset-expected.png: Added.
  • platform/efl/svg/css/text-shadow-multiple-expected.png: Added.
  • platform/efl/svg/dom/SVGLengthList-appendItem-expected.png: Added.
  • platform/efl/svg/dom/SVGLengthList-basics-expected.png: Added.
  • platform/efl/svg/dom/SVGLengthList-getItem-expected.png: Added.
  • platform/efl/svg/dom/SVGLengthList-initialize-expected.png: Added.
  • platform/efl/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
  • platform/efl/svg/dom/SVGLengthList-removeItem-expected.png: Added.
  • platform/efl/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
  • platform/efl/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
  • platform/efl/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
  • platform/efl/svg/dom/SVGNumberList-basics-expected.png: Added.
  • platform/efl/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/efl/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/efl/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/efl/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/efl/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/efl/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
  • platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
  • platform/efl/svg/dom/SVGPointList-basics-expected.png: Added.
  • platform/efl/svg/dom/SVGRectElement: Added.
  • platform/efl/svg/dom/SVGRectElement/rect-modify-rx-expected.png: Added.
  • platform/efl/svg/dom/SVGStringList-basics-expected.png: Added.
  • platform/efl/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/efl/svg/filters/color-interpolation-filters-expected.png: Added.
  • platform/efl/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Added.
  • platform/efl/svg/foreignObject/fO-display-none-expected.png: Added.
  • platform/efl/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png: Added.
  • platform/efl/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
  • platform/efl/svg/foreignObject/fO-parent-display-none-expected.png: Added.
  • platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Added.
  • platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Added.
  • platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Added.
  • platform/efl/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Added.
  • platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.png: Added.
  • platform/efl/svg/foreignObject/svg-document-in-html-document-expected.png: Added.
  • platform/efl/svg/foreignObject/text-tref-02-b-expected.png: Added.
7:29 AM Changeset in webkit [130900] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

EditorCommand calls setProperty with the wrong parameters.
https://bugs.webkit.org/show_bug.cgi?id=98896

Patch by Mike West <mkwst@google.com> on 2012-10-10
Reviewed by Jochen Eisinger.

EditorCommand::executeToggleStyleInList calls
StylePropertySet::setProperty with an ExceptionCode as the final
argument. This only succeeds because it's automagically cast to a bool,
which is what the method actually expects.

Implicitly passing in 'false' by dropping the parameter shouldn't change
any visible functionality; no new tests are required.

  • editing/EditorCommand.cpp:

(WebCore::executeToggleStyleInList):

7:22 AM Changeset in webkit [130899] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

SVG root element's inspector highlight has different dimensions than the element when zooming the page
https://bugs.webkit.org/show_bug.cgi?id=78031

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-10
Reviewed by Pavel Feldman.

Add test that verifies the position and size of the highlight rectangles overlayed on an SVG
root element when the page is zoomed.

  • inspector/elements/highlight-svg-root-zoomed-expected.txt: Added.
  • inspector/elements/highlight-svg-root-zoomed.html: Added.
7:14 AM Changeset in webkit [130898] by kbalazs@webkit.org
  • 264 edits
    24 copies
    19 adds in trunk

[Qt] Test drivers should handle repaint rects
https://bugs.webkit.org/show_bug.cgi?id=68870

Reviewed by Zoltan Herczeg.

Source/WebKit/qt:

Added helpers to enable and get the repaint rects.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setTrackRepaintRects):
(DumpRenderTreeSupportQt::trackRepaintRects):
(DumpRenderTreeSupportQt::getTrackedRepaintRects):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Implemented masking the area not covered by repaint rects.
This is equivalent with the implementation for Mac.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::dump):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::display):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  • WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

LayoutTests:

Rebasline results. Added new expectations where the results were good.
I evaulated the results based on the mac and chromium-mac ports. In some
cases I accepted our diverging result if it seemed to be ok by looking
into the test. Marked bad results as image failure.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/compositing/iframes/fixed-position-iframe-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/iframes/scroll-fixed-transformed-element-expected.png: Copied from LayoutTests/platform/qt/fast/layers/add-layer-with-nested-stacking-expected.png.
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.png:
  • platform/qt-5.0-wk2/compositing/repaint/newly-composited-on-scroll-expected.png:
  • platform/qt-5.0-wk2/compositing/repaint/shrink-layer-expected.png: Copied from LayoutTests/platform/qt/svg/custom/clip-path-href-changes-expected.png.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-overflow-invalidation-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/clip-with-layout-delta-expected.png.
  • platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/qt-5.0-wk2/compositing/transitions/singular-scale-transition-expected.png: Added.
  • platform/qt-5.0-wk2/css3/filters/filter-change-repaint-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/solid-color-context-restore-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/canvas-incremental-repaint-2-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/subtree-root-clip-3-expected.png.
  • platform/qt-5.0-wk2/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/listbox-clip-expected.png: Copied from LayoutTests/platform/qt/svg/repaint/repainting-after-animation-element-removal-expected.png.
  • platform/qt-5.0-wk2/fast/reflections/inline-crash-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/body-background-image-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/delete-into-nested-block-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/fixed-after-scroll-expected.png: Copied from LayoutTests/platform/qt/svg/custom/use-disappears-after-style-update-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/fixed-scale-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/iframe-scroll-repaint-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/fixed-scroll-simple-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/fixed-table-cell-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/button-spurious-layout-hint-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/fixed-table-overflow-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/subtree-root-clip-2-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/fixed-table-overflow-zindex-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/subtree-root-clip-2-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/iframe-scroll-repaint-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/clip-with-layout-delta-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/reflection-repaint-test-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/region-painting-invalidation-expected.png: Copied from LayoutTests/platform/qt/fast/layers/add-layer-with-nested-stacking-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/region-painting-via-layout-expected.png: Copied from LayoutTests/platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/scale-page-shrink-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/selection-after-delete-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/selection-after-remove-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/selection-clear-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/table-hover-on-link-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/cached-69296-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/table-two-pass-layout-overpaint-expected.png.
  • platform/qt-5.0-wk2/fast/text/font-initial-expected.png: Added.
  • platform/qt-5.0-wk2/svg/text/remove-text-node-from-tspan-expected.png: Added.
  • platform/qt-5.0-wk2/svg/text/remove-tspan-from-text-expected.png: Added.
  • platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.png:
  • platform/qt/fast/canvas/canvas-incremental-repaint-expected.png: Added.
  • platform/qt/fast/dynamic/containing-block-change-expected.png:
  • platform/qt/fast/frames/transparent-scrollbar-expected.png: Copied from LayoutTests/platform/qt/svg/custom/repaint-on-constant-size-change-expected.png.
  • platform/qt/fast/layers/add-layer-with-nested-stacking-expected.png:
  • platform/qt/fast/layers/inline-dirty-z-order-lists-expected.png:
  • platform/qt/fast/layers/layer-content-visibility-change-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/layout-state-only-positioned-expected.png.
  • platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.png:
  • platform/qt/fast/repaint/4774354-expected.png:
  • platform/qt/fast/repaint/4776765-expected.png:
  • platform/qt/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/qt/fast/repaint/block-no-inflow-children-expected.png:
  • platform/qt/fast/repaint/border-fit-lines-expected.png:
  • platform/qt/fast/repaint/border-radius-repaint-expected.png:
  • platform/qt/fast/repaint/border-repaint-glitch-expected.png:
  • platform/qt/fast/repaint/box-shadow-dynamic-expected.png:
  • platform/qt/fast/repaint/bugzilla-3509-expected.png:
  • platform/qt/fast/repaint/bugzilla-5699-expected.png:
  • platform/qt/fast/repaint/bugzilla-6278-expected.png:
  • platform/qt/fast/repaint/bugzilla-6388-expected.png:
  • platform/qt/fast/repaint/bugzilla-6473-expected.png:
  • platform/qt/fast/repaint/bugzilla-7235-expected.png:
  • platform/qt/fast/repaint/button-spurious-layout-hint-expected.png:
  • platform/qt/fast/repaint/caret-outside-block-expected.png:
  • platform/qt/fast/repaint/change-transform-expected.png:
  • platform/qt/fast/repaint/clip-with-layout-delta-expected.png:
  • platform/qt/fast/repaint/clipped-relative-expected.png:
  • platform/qt/fast/repaint/containing-block-position-change-expected.png:
  • platform/qt/fast/repaint/content-into-overflow-expected.png:
  • platform/qt/fast/repaint/continuation-after-outline-expected.png:
  • platform/qt/fast/repaint/control-clip-expected.png:
  • platform/qt/fast/repaint/create-layer-repaint-expected.png:
  • platform/qt/fast/repaint/delete-into-nested-block-expected.png:
  • platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-tranformed-expected.png:
  • platform/qt/fast/repaint/float-move-during-layout-expected.png:
  • platform/qt/fast/repaint/float-overflow-expected.png:
  • platform/qt/fast/repaint/float-overflow-right-expected.png:
  • platform/qt/fast/repaint/gradients-em-stops-repaint-expected.png:
  • platform/qt/fast/repaint/iframe-scroll-repaint-expected.png:
  • platform/qt/fast/repaint/inline-color-change-expected.png:
  • platform/qt/fast/repaint/inline-outline-repaint-expected.png:
  • platform/qt/fast/repaint/invisible-objects-expected.png:
  • platform/qt/fast/repaint/layer-visibility-expected.png: Copied from LayoutTests/platform/qt/fast/layers/add-layer-with-nested-stacking-expected.png.
  • platform/qt/fast/repaint/layout-state-only-positioned-expected.png:
  • platform/qt/fast/repaint/layout-state-relative-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.png:
  • platform/qt/fast/repaint/line-overflow-expected.png:
  • platform/qt/fast/repaint/lines-with-layout-delta-expected.png:
  • platform/qt/fast/repaint/list-marker-2-expected.png:
  • platform/qt/fast/repaint/make-children-non-inline-expected.png:
  • platform/qt/fast/repaint/multicol-repaint-expected.png:
  • platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png:
  • platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.png:
  • platform/qt/fast/repaint/outline-child-repaint-expected.png:
  • platform/qt/fast/repaint/outline-inset-expected.png:
  • platform/qt/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/qt/fast/repaint/outline-shrinking-expected.png:
  • platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.png:
  • platform/qt/fast/repaint/overflow-delete-line-expected.png:
  • platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
  • platform/qt/fast/repaint/overflow-into-content-expected.png:
  • platform/qt/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/qt/fast/repaint/reflection-redraw-expected.png:
  • platform/qt/fast/repaint/reflection-repaint-test-expected.png:
  • platform/qt/fast/repaint/region-painting-invalidation-expected.png:
  • platform/qt/fast/repaint/region-painting-via-layout-expected.png:
  • platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.png:
  • platform/qt/fast/repaint/repaint-during-scroll-expected.png:
  • platform/qt/fast/repaint/repaint-resized-overflow-expected.png:
  • platform/qt/fast/repaint/search-field-cancel-expected.png:
  • platform/qt/fast/repaint/select-option-background-color-expected.png:
  • platform/qt/fast/repaint/selected-replaced-expected.png:
  • platform/qt/fast/repaint/selection-after-delete-expected.png:
  • platform/qt/fast/repaint/selection-after-remove-expected.png:
  • platform/qt/fast/repaint/selection-clear-expected.png:
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/qt/fast/repaint/selection-rl-expected.png:
  • platform/qt/fast/repaint/stacked-diacritics-expected.png:
  • platform/qt/fast/repaint/subtree-layoutstate-transform-expected.png:
  • platform/qt/fast/repaint/subtree-root-clip-2-expected.png:
  • platform/qt/fast/repaint/subtree-root-clip-3-expected.png:
  • platform/qt/fast/repaint/subtree-root-clip-expected.png:
  • platform/qt/fast/repaint/subtree-root-skipped-expected.png:
  • platform/qt/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/qt/fast/repaint/table-cell-move-expected.png:
  • platform/qt/fast/repaint/table-collapsed-border-expected.png:
  • platform/qt/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/qt/fast/repaint/table-hover-on-link-expected.png:
  • platform/qt/fast/repaint/table-section-repaint-expected.png:
  • platform/qt/fast/repaint/table-two-pass-layout-overpaint-expected.png:
  • platform/qt/fast/repaint/text-append-dirty-lines-expected.png:
  • platform/qt/fast/repaint/transform-absolute-child-expected.png:
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/qt/fast/repaint/transform-disable-layoutstate-expected.png:
  • platform/qt/fast/repaint/transform-layout-repaint-expected.png:
  • platform/qt/fast/repaint/transform-relative-position-expected.png:
  • platform/qt/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/qt/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/qt/fast/repaint/transform-rotate-and-remove-expected.png:
  • platform/qt/fast/repaint/transform-translate-expected.png:
  • platform/qt/fast/table/border-collapsing/cached-69296-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/layout-state-only-positioned-expected.png.
  • platform/qt/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Copied from LayoutTests/platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png.
  • platform/qt/fast/table/border-collapsing/cached-change-row-border-width-expected.png: Copied from LayoutTests/platform/qt/svg/repaint/repainting-after-animation-element-removal-expected.png.
  • platform/qt/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/table-two-pass-layout-overpaint-expected.png.
  • platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/qt/svg/as-image/animated-svg-as-image-expected.png:
  • platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/qt/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png:
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/qt/svg/carto.net/window-expected.png:
  • platform/qt/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/qt/svg/custom/animate-path-discrete-expected.png:
  • platform/qt/svg/custom/animate-path-morphing-expected.png:
  • platform/qt/svg/custom/animate-target-id-changed-expected.png:
  • platform/qt/svg/custom/animate-target-removed-from-document-expected.png:
  • platform/qt/svg/custom/circle-move-invalidation-expected.png:
  • platform/qt/svg/custom/clip-path-child-changes-expected.png:
  • platform/qt/svg/custom/clip-path-href-changes-expected.png:
  • platform/qt/svg/custom/clip-path-units-changes-expected.png:
  • platform/qt/svg/custom/deep-dynamic-updates-expected.png:
  • platform/qt/svg/custom/fill-opacity-update-expected.png:
  • platform/qt/svg/custom/foreignObject-crash-on-hover-expected.png:
  • platform/qt/svg/custom/gradient-add-stops-expected.png:
  • platform/qt/svg/custom/gradient-stop-style-change-expected.png:
  • platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.png:
  • platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/qt/svg/custom/js-late-clipPath-creation-expected.png:
  • platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/qt/svg/custom/js-late-gradient-creation-expected.png:
  • platform/qt/svg/custom/js-late-marker-and-object-creation-expected.png:
  • platform/qt/svg/custom/js-late-marker-creation-expected.png:
  • platform/qt/svg/custom/js-late-mask-and-object-creation-expected.png:
  • platform/qt/svg/custom/js-late-mask-creation-expected.png:
  • platform/qt/svg/custom/js-update-bounce-expected.png:
  • platform/qt/svg/custom/js-update-container-expected.png:
  • platform/qt/svg/custom/js-update-container2-expected.png:
  • platform/qt/svg/custom/js-update-gradient-expected.png:
  • platform/qt/svg/custom/js-update-image-expected.png:
  • platform/qt/svg/custom/js-update-path-changes-expected.png:
  • platform/qt/svg/custom/js-update-path-removal-expected.png:
  • platform/qt/svg/custom/js-update-pattern-child-expected.png:
  • platform/qt/svg/custom/js-update-pattern-expected.png:
  • platform/qt/svg/custom/js-update-polygon-changes-expected.png:
  • platform/qt/svg/custom/js-update-polygon-removal-expected.png:
  • platform/qt/svg/custom/js-update-stop-expected.png:
  • platform/qt/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/qt/svg/custom/js-update-style-expected.png:
  • platform/qt/svg/custom/js-update-transform-addition-expected.png:
  • platform/qt/svg/custom/js-update-transform-changes-expected.png:
  • platform/qt/svg/custom/marker-child-changes-css-expected.png:
  • platform/qt/svg/custom/marker-child-changes-expected.png:
  • platform/qt/svg/custom/marker-viewBox-changes-expected.png:
  • platform/qt/svg/custom/mask-child-changes-expected.png:
  • platform/qt/svg/custom/mask-invalidation-expected.png:
  • platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png:
  • platform/qt/svg/custom/prevent-default-expected.png:
  • platform/qt/svg/custom/relative-sized-content-expected.png:
  • platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
  • platform/qt/svg/custom/relative-sized-image-expected.png:
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.png:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.png:
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/qt/svg/custom/repaint-moving-svg-and-div-expected.png:
  • platform/qt/svg/custom/repaint-on-constant-size-change-expected.png:
  • platform/qt/svg/custom/repaint-on-image-bounds-change-expected.png:
  • platform/qt/svg/custom/repaint-stroke-width-changes-expected.png:
  • platform/qt/svg/custom/resource-client-removal-expected.png:
  • platform/qt/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/qt/svg/custom/scroll-hit-test-expected.png:
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/qt/svg/custom/stroke-opacity-update-expected.png:
  • platform/qt/svg/custom/svg-absolute-children-expected.png:
  • platform/qt/svg/custom/text-dom-removal-expected.png:
  • platform/qt/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/qt/svg/custom/use-clipped-hit-expected.png:
  • platform/qt/svg/custom/use-detach-expected.png:
  • platform/qt/svg/custom/use-disappears-after-style-update-expected.png:
  • platform/qt/svg/custom/use-elementInstance-event-target-expected.png:
  • platform/qt/svg/custom/use-elementInstance-methods-expected.png:
  • platform/qt/svg/custom/use-event-handler-on-referenced-element-expected.png:
  • platform/qt/svg/custom/use-event-handler-on-use-element-expected.png:
  • platform/qt/svg/custom/use-setAttribute-crash-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
  • platform/qt/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
  • platform/qt/svg/filters/feImage-change-target-id-expected.png:
  • platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.png:
  • platform/qt/svg/filters/feImage-reference-invalidation-expected.png: Copied from LayoutTests/platform/qt/svg/custom/animate-target-removed-from-document-expected.png.
  • platform/qt/svg/filters/feImage-remove-target-expected.png:
  • platform/qt/svg/filters/feImage-target-add-to-document-expected.png:
  • platform/qt/svg/filters/feImage-target-attribute-change-expected.png:
  • platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
  • platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
  • platform/qt/svg/filters/feImage-target-changes-id-expected.png:
  • platform/qt/svg/filters/feImage-target-id-change-expected.png:
  • platform/qt/svg/filters/feImage-target-inline-style-change-expected.png:
  • platform/qt/svg/filters/feImage-target-property-change-expected.png:
  • platform/qt/svg/filters/feImage-target-reappend-to-document-expected.png:
  • platform/qt/svg/filters/feImage-target-remove-from-document-expected.png:
  • platform/qt/svg/filters/feImage-target-style-change-expected.png:
  • platform/qt/svg/filters/filter-refresh-expected.png:
  • platform/qt/svg/filters/filter-width-update-expected.png:
  • platform/qt/svg/filters/invalidate-on-child-layout-expected.png:
  • platform/qt/svg/hixie/perf/001-expected.png:
  • platform/qt/svg/hixie/perf/002-expected.png:
  • platform/qt/svg/hixie/perf/003-expected.png:
  • platform/qt/svg/hixie/perf/004-expected.png:
  • platform/qt/svg/hixie/perf/005-expected.png:
  • platform/qt/svg/hixie/perf/007-expected.png:
  • platform/qt/svg/repaint/filter-child-repaint-expected.png:
  • platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.png:
  • platform/qt/svg/repaint/inner-svg-change-viewBox-expected.png:
  • platform/qt/svg/repaint/inner-svg-change-viewPort-relative-expected.png:
  • platform/qt/svg/repaint/mask-clip-target-transform-expected.png:
  • platform/qt/svg/repaint/repainting-after-animation-element-removal-expected.png:
  • platform/qt/svg/repaint/text-mask-update-expected.png:
  • platform/qt/svg/text/append-text-node-to-tspan-expected.png:
  • platform/qt/svg/text/ems-display-none-expected.png:
  • platform/qt/svg/text/exs-display-none-expected.png:
  • platform/qt/svg/text/modify-text-node-in-tspan-expected.png:
  • platform/qt/svg/text/text-text-05-t-expected.png:
  • platform/qt/svg/text/text-viewbox-rescale-expected.png:
  • platform/qt/svg/text/tspan-dynamic-positioning-expected.png:
  • platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png:
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png:
  • platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.png:
  • platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.png:
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.png:
6:56 AM Changeset in webkit [130897] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLTextFormControlElement calls setInlineStyleProperty with the wrong parameters.
https://bugs.webkit.org/show_bug.cgi?id=98892

Patch by Mike West <mkwst@google.com> on 2012-10-10
Reviewed by Jochen Eisinger.

HTMLTextFormControlElement::updatePlaceholderVisibility calls
HTMLElement::setInlineStyleProperty with an ExceptionCode as the last
parameter. This only succeeds because it's automagically cast to a bool,
which is what the method actually expects.

Implicitly passing in 'false' by dropping the parameter shouldn't change
any functionality; so no new tests are required.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):

6:55 AM Changeset in webkit [130896] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip fast/css/color-correction-on-text.html.

  • platform/efl/TestExpectations:
6:52 AM Changeset in webkit [130895] by rakuco@webkit.org
  • 5 edits
    64 adds in trunk/LayoutTests

[EFL] Gardening for the some SVG pixel expectations.

  • platform/efl/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/efl/svg/filters/animate-fill-expected.png: Added.
  • platform/efl/svg/filters/feImage-reference-invalidation-expected.png: Added.
  • platform/efl/svg/hixie/data-types/001-expected.png: Added.
  • platform/efl/svg/hixie/dynamic/002-expected.png: Added.
  • platform/efl/svg/hixie/dynamic/003-expected.png: Added.
  • platform/efl/svg/hixie/dynamic/004-expected.png: Added.
  • platform/efl/svg/hixie/dynamic/005-expected.png: Added.
  • platform/efl/svg/hixie/dynamic/006-expected.png: Added.
  • platform/efl/svg/hixie/error/002-expected.png: Added.
  • platform/efl/svg/hixie/error/006-expected.png: Added.
  • platform/efl/svg/hixie/error/007-expected.png: Added.
  • platform/efl/svg/hixie/error/008-expected.png: Added.
  • platform/efl/svg/hixie/error/009-expected.png: Added.
  • platform/efl/svg/hixie/error/010-expected.png: Added.
  • platform/efl/svg/hixie/error/011-expected.png: Added.
  • platform/efl/svg/hixie/error/014-test-expected.png: Added.
  • platform/efl/svg/hixie/error/015-expected.png: Added.
  • platform/efl/svg/hixie/error/016-expected.png: Added.
  • platform/efl/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/efl/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/efl/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/efl/svg/hixie/links/001-expected.png: Added.
  • platform/efl/svg/hixie/links/002-expected.png: Added.
  • platform/efl/svg/hixie/painting/001-expected.png: Added.
  • platform/efl/svg/hixie/processing-model/005-expected.png: Added.
  • platform/efl/svg/hixie/rendering-model/003a-expected.png: Added.
  • platform/efl/svg/hixie/text/001-expected.png: Added.
  • platform/efl/svg/hixie/text/002-expected.png: Added.
  • platform/efl/svg/hixie/text/003a-expected.png: Added.
  • platform/efl/svg/hixie/text/003b-expected.png: Added.
  • platform/efl/svg/hixie/use/002-test-expected.png: Added.
  • platform/efl/svg/hixie/viewbox/001-expected.png: Added.
  • platform/efl/svg/hixie/viewbox/002-expected.png: Added.
  • platform/efl/svg/hixie/viewbox/003-expected.png: Added.
  • platform/efl/svg/hixie/viewbox/004-expected.png: Added.
  • platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.png: Added.
  • platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-foreignObject-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Added.
  • platform/efl/svg/repaint/image-href-change-expected.png: Added.
  • platform/efl/svg/repaint/image-with-clip-path-expected.png: Added.
  • platform/efl/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
  • platform/efl/svg/repaint/mask-clip-target-transform-expected.png: Added.
  • platform/efl/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/efl/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
  • platform/efl/svg/wicd/sizing-flakiness-expected.png: Added.
  • platform/efl/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/efl/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/efl/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-image-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/efl/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/efl/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/efl/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
6:44 AM Changeset in webkit [130894] by jocelyn.turcotte@digia.com
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] REGRESSION(r130879): It made fast/events/touch/* tests crash
https://bugs.webkit.org/show_bug.cgi?id=98888

Reviewed by Kenneth Rohde Christiansen.

Add null-checks in the gesture recognizers to allow them working without a PageViewportController.
The pinch and pan gesture recognizers aren't used in that case yet, but they could eventually
be used to send pinch and pan gesture events to the web process. They are currently kept active
because we need the tap gesture recognizer and its logic is bound to those other recognizers.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::update):
(WebKit::QtPanGestureRecognizer::finish):
(WebKit::QtPanGestureRecognizer::cancel):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::update):
(WebKit::QtPinchGestureRecognizer::finish):
(WebKit::QtPinchGestureRecognizer::cancel):

6:35 AM Changeset in webkit [130893] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed inspector test fix.

  • http/tests/inspector/search/resources-search-match-index.html:
6:21 AM Changeset in webkit [130892] by rakuco@webkit.org
  • 3 edits
    50 adds
    2 deletes in trunk/LayoutTests

[EFL] Update some pixel expectations for the new Cairo, and add more baselines for other tests.

  • platform/efl/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
  • platform/efl/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
  • platform/efl/fast/borders/border-shadow-large-radius-expected.png: Added.
  • platform/efl/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/efl/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
  • platform/efl/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/efl/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/efl/fast/css/color-correction-on-text-expected.png: Removed.
  • platform/efl/fast/css/color-correction-on-text-expected.txt: Removed.
  • platform/efl/fast/css/square-button-appearance-expected.png: Added.
  • platform/efl/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/efl/fast/css/text-overflow-ellipsis-text-align-justify-expected.png: Added.
  • platform/efl/fast/css/text-overflow-ellipsis-text-align-left-expected.png: Added.
  • platform/efl/fast/css/text-overflow-ellipsis-text-align-right-expected.png: Added.
  • platform/efl/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/efl/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png: Added.
  • platform/efl/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png: Added.
  • platform/efl/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png: Added.
  • platform/efl/fast/events/context-no-deselect-expected.png: Added.
  • platform/efl/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
  • platform/efl/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
  • platform/efl/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/efl/fast/forms/textarea: Added.
  • platform/efl/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/efl/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/efl/fast/html/details-marker-style-expected.png: Added.
  • platform/efl/fast/images/image-css3-content-data-expected.png: Added.
  • platform/efl/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/efl/fast/images/paint-subrect-expected.png: Added.
  • platform/efl/fast/images/paint-subrect-grid-expected.png: Added.
  • platform/efl/fast/images/repaint-subrect-grid-expected.png: Added.
  • platform/efl/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Added.
  • platform/efl/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Added.
  • platform/efl/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
  • platform/efl/fast/js: Added.
  • platform/efl/fast/js/exception-linenums-in-html-3-expected.png: Added.
  • platform/efl/fast/js/missing-style-end-tag-js-expected.png: Added.
  • platform/efl/fast/js/missing-title-end-tag-js-expected.png: Added.
  • platform/efl/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
  • platform/efl/fast/layers/scroll-with-transform-layer-expected.png: Added.
  • platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
  • platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Added.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
  • platform/efl/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/efl/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/efl/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/efl/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/efl/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/efl/fast/scrolling: Added.
  • platform/efl/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Added.
  • platform/efl/fast/table/colspanMinWidth-vertical-expected.png: Added.
  • platform/efl/fast/table/table-row-focus-ring-paint-expected.png: Added.
  • platform/efl/fast/text/text-shadow-no-default-color-expected.png: Added.
5:37 AM Changeset in webkit [130891] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

SQLResultSet.rowsAffected not cleared
https://bugs.webkit.org/show_bug.cgi?id=46070

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

SQLResultSet.rowsAffected is supposed to return the number
of rows that were changed by the statement. For "SELECT"
statements, it should return 0.

However, our implementation currently relies on sqlite3_changes()
to compute this value. sqlite3_changes() returns the number of
direct row changes in the most recent INSERT, UPDATE, or DELETE
statement within the same trigger context. Unfortunately, the
most recent INSERT, UPDATE, or DELETE statement may not be the
last statement. As a consequence, if you INSERT 1 row, then
do a SELECT, SQLResultSet.rowsAffected will be 1 for both the
INSERT and the SELECT statements.

The proposed solution is to use sqlite3_total_changes() instead
of sqlite3_changes(). sqlite3_total_changes() returns the number
of row changes caused by INSERT, UPDATE or DELETE statements since
the database connection was opened. We now store the value
returned by sqlite3_total_changes() before each statement in
order to return the count difference in
SQLiteDatabase::lastChanges().

Test: storage/websql/execute-sql-rowsAffected.html

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::SQLiteDatabase):
(WebCore::SQLiteDatabase::updateLastChangesCount):
(WebCore):
(WebCore::SQLiteDatabase::lastChanges):

  • platform/sql/SQLiteDatabase.h:

(SQLiteDatabase):

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::step):

LayoutTests:

Add layout test to check that SQLResultSet.rowsAffected is
correct in executeSql() success callback.

  • storage/websql/execute-sql-rowsAffected-expected.txt: Added.
  • storage/websql/execute-sql-rowsAffected.html: Added.
5:33 AM Changeset in webkit [130890] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt]QtTestBrowser should have default url(google.com) when no command line args
https://bugs.webkit.org/show_bug.cgi?id=98880

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-10-10
Reviewed by Simon Hausmann.

Making QtTestBrowser use www.google.com as default url when no arguments are passed

  • QtTestBrowser/qttestbrowser.cpp:

(main):

4:42 AM Changeset in webkit [130889] by commit-queue@webkit.org
  • 4 edits
    6 adds in trunk/LayoutTests

[EFL] Rebaseline after r129972 which enabled plugin feature
https://bugs.webkit.org/show_bug.cgi?id=98750

Unreviewed. Plugin feature is enabled on EFL port after r129972.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-10-10

  • platform/efl-wk1/TestExpectations: EFL WK1 does not support plugins yet.
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/plugins/iframe-plugin-bgcolor-expected.txt: Added.
  • platform/efl/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • platform/efl/plugins/netscape-dom-access-expected.txt: Added.
  • platform/efl/plugins/plugin-javascript-access-expected.txt: Added.
  • platform/efl/plugins/resize-from-plugin-expected.txt: Added.
4:29 AM Changeset in webkit [130888] by keishi@webkit.org
  • 4 edits in trunk

REGRESSION (r129738): Calendar picker is too wide when the input is rtl
https://bugs.webkit.org/show_bug.cgi?id=98881

.:

Reviewed by kent Tamura.

  • ManualTests/forms/calendar-picker.html: Added isCalendarRTL parameters.

Source/WebCore:

Reviewed by Kent Tamura.

Calendar picker should use param.isCalendarRTL instead of param.isRTL but some were left.

No new tests. Covered by ManualTests/forms/calendar-picker.html.

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype.fixWindowSize): Calendar picker should use param.isCalendarRTL instead of param.isRTL.
(DaysTable.prototype._handleKey): Ditto.

4:22 AM Changeset in webkit [130887] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

[EFL][WK2] Port MiniBrowser to Elementary
https://bugs.webkit.org/show_bug.cgi?id=98748

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-10
Reviewed by Kenneth Rohde Christiansen.

.:

Bump EFL librairies dependencies to v1.7
and add Elementary as optional dependency now
that it is needed to build MiniBrowser.

  • Source/cmake/FindEet.cmake: Added.
  • Source/cmake/FindElementary.cmake: Added.
  • Source/cmake/OptionsEfl.cmake:

Tools:

Port MiniBrowser to Elementary to simplify the
code and make future improvements easier. The
URL bar is now an Elementary Entry widget and
supports additional functionality like copy /
paste.

  • CMakeLists.txt:
  • EWebLauncher/url_bar.c:

(on_urlbar_key_down): Remove WK2-specific code
now that this file is no longer used by MiniBrowser.

  • MiniBrowser/efl/CMakeLists.txt:
  • MiniBrowser/efl/main.c:

(_Browser_Window):
(window_free):
(window_close):
(view_focus_set):
(on_mouse_down):
(title_set):
(on_title_changed):
(on_url_changed):
(on_close_window):
(on_progress):
(quit):
(on_url_bar_activated):
(on_url_bar_clicked):
(on_window_deletion):
(window_create):
(elm_main):

  • efl/jhbuild.modules: Add Elementary to jhbuild and bump

EFL dependencies to 1.7.

4:16 AM Changeset in webkit [130886] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Test /webkit2/WebKitWebView/history-cache asserts in debug bot
https://bugs.webkit.org/show_bug.cgi?id=98731

Reviewed by Martin Robinson.

The problem is in the test itself that is using
SingleResourceLoadTest class to load a multiresource document.

  • UIProcess/API/gtk/tests/TestResources.cpp:

(testWebViewResourcesHistoryCache): Load only single resource
documents and check also that the main resource given is the
expected one.
(serverCallback): Add another single resource document.

4:14 AM Changeset in webkit [130885] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2][SOUP] ResourceError.isCancellation() is not carried over IPC
https://bugs.webkit.org/show_bug.cgi?id=98882

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Properly serialize / deserialize ResourceError.isCancellation
boolean so that it can be used in UIProcess.

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

Tools:

Do not display the error page in MiniBrowser if the loading
error corresponds to a cancellation.

  • MiniBrowser/efl/main.c:

(on_error):

3:52 AM Changeset in webkit [130884] by tkent@chromium.org
  • 10 edits
    2 copies
    17 adds in trunk/LayoutTests

Add behavior tests for input[type=date] with multiple fields
https://bugs.webkit.org/show_bug.cgi?id=98480

Reviewed by Kentaro Hara.

  • fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-blur-and-focus-events-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-blur-and-focus-events.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
  • fast/forms/date-multiple-fields/date-multiple-fields-mouse-events-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-reset-value-after-reloads-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-reset-value-after-reloads.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events.html.
  • fast/forms/date-multiple-fields/date-multiple-fields-wheel-event-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-wheel-event.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events.html.
  • fast/forms/date/date-reset-value-expected.html: Added.
  • fast/forms/date/date-reset-value.html: Added.
  • fast/forms/resources/common-spinbutton-change-and-input-events.js:

(testSpinButtonChangeAndInputEvents):
Uses getElementByPseudoId() to obtain spin button position. The date
type and the time type have their spin button at different positions
because of a picker indicator triangle.

  • fast/forms/number/number-spinbutton-change-and-input-events.html:

Need to import comon.js because common-spinbutton-change-and-input-events.js depends on it.

  • fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events.html:

Ditto.

  • fast/forms/resources/common-wheel-event.js:

(testWheelEvent): Fix a wrong message.

  • fast/forms/time-multiple-fields/time-multiple-fields-wheel-event-expected.txt: Ditto.
  • fast/forms/resources/multiple-fields-blur-and-focus-events.js:

Added. Move the code from time-multiple-fields-blur-and-focus-events.html.

  • fast/forms/time-multiple-fields/time-multiple-fields-blur-and-focus-events.html:

Moved the code to multiple-fields-blur-and-focus-events.js.

  • platform/chromium/TestExpectations:
3:50 AM Changeset in webkit [130883] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: Semantically incorrect CSS rules result in broken source code data
https://bugs.webkit.org/show_bug.cgi?id=98520

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Pop and throw away rule data from the stack when data have been collected for a semantically invalid CSS rule
(which is not going to be created).

  • css/CSSParser.cpp:

(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createRegionRule):

LayoutTests:

  • inspector/styles/parse-stylesheet-errors-expected.txt:
  • inspector/styles/parse-stylesheet-errors.html:
3:41 AM Changeset in webkit [130882] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add APIs to get/set the DNS prefetching
https://bugs.webkit.org/show_bug.cgi?id=98790

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-10
Reviewed by Laszlo Gombos.

Add setting APIs for DNS prefetching and a unit test.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_DNS_prefetching_enabled_set):
(ewk_settings_DNS_prefetching_enabled_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

3:40 AM Changeset in webkit [130881] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Use ewk_view_paint instead of ewk_view_paint_contents in ewk_view_single.
https://bugs.webkit.org/show_bug.cgi?id=98716

Reviewed by Kenneth Rohde Christiansen.

ewk_view_paint is the wrapper of ScrollView::paint and
ewk_view_paint_contents is the wrapper of FrameView::paintContents.

Because FrameView::paintContents just draw contents,
ewk_view_single should use ewk_view_paint instead of ewk_view_paint_contents
like other ports.

  • ewk/ewk_view.cpp:

(ewk_view_paint):
Moved updateLayoutAndStyleIfNeededRecursive to share ewk_view_paint.

  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_repaints_process):
Modified to call ewk_view_paint.

3:38 AM Changeset in webkit [130880] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt][Mac] GL_ARB_texture_rectangle must be activated when using ANGLE.
https://bugs.webkit.org/show_bug.cgi?id=98387

Check for the availability of GL_ARB_texture_rectangle extension.
In case it is available, we activate the extension for ANGLE.
This is necessary for WebGL on mac, because the GraphicsSurface
on this platform is based on an IOSurface, which requires this extension.

Reviewed by Noam Rosenthal.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::initializeANGLE):

3:24 AM Changeset in webkit [130879] by jocelyn.turcotte@digia.com
  • 4 edits in trunk

[Qt][WK2] REGRESSION(r130629): It made touchadjustment/focusout-on-touch.html fai1
https://bugs.webkit.org/show_bug.cgi?id=98642

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

There was an early return that would prevent gesture recognition if no PageViewportController
has been set on QtWebPageEventHandler. The gesture recognizer are also used to send
GestureEvents to WebCore which this layout test is using.

Make sure that the gesture recognition is done even when no PageViewportController is present.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::handleInputEvent):
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):

LayoutTests:

  • platform/qt-5.0-wk2/TestExpectations: Unskip focusout-on-touch.html
3:23 AM Changeset in webkit [130878] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Tools

[Qt] WTR: Fix an assert triggered by EventSenderProxy::touchEnd
https://bugs.webkit.org/show_bug.cgi?id=98735

Reviewed by Kenneth Rohde Christiansen.

ASSERT: "itemForTouchPointId.isEmpty()" in file qt5/qtdeclarative/src/quick/items/qquickwindow.cpp, line 1563
This assert is caused by QQuickWindow not registering our TouchPointReleased
since it expects QTouchEvent::touchPointStates() to be filled by the event's sender.

This patch calculates the touchPointStates like QQuickWindowPrivate::touchEventWithPoints does.

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::sendTouchEvent):

2:53 AM Changeset in webkit [130877] by allan.jensen@digia.com
  • 6 edits in trunk

[Qt] DumpRenderTree needs a beginDragWithFiles implementation
https://bugs.webkit.org/show_bug.cgi?id=50902

Reviewed by Simon Hausmann.

Tools:

Implement support for beginDragWithFiles. This function similates dragging without going
though regular event handling. Which allows us to test effects of dropping files on
different elements.

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::EventSender):
(EventSender::mouseUp):
(EventSender::mouseMoveTo):
(EventSender::beginDragWithFiles):

  • DumpRenderTree/qt/EventSenderQt.h:

(EventSender):

LayoutTests:

Move some skipped tests that now passing in DRT to only being skipped in WTR.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
2:48 AM Changeset in webkit [130876] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] ProcessLauncherQt should use QStringLiteral for serviceName.
https://bugs.webkit.org/show_bug.cgi?id=98398

QString(const char*) is deprecated, we should use QStringLiteral instead.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

2:20 AM Changeset in webkit [130875] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Use Evas function instead of memcpy
https://bugs.webkit.org/show_bug.cgi?id=98483

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-10
Reviewed by Gyuyoung Kim.

Evas supports evas_object_image_data_copy_set() to copy raw image data.
Change memcpy() with evas_object_image_data_copy_set().

Spell out variable names and refactor variable declaration statements.

No new tests, no functionality was changed.

  • ewk/ewk_util.cpp:

(ewk_util_image_from_cairo_surface_add):

1:46 AM Changeset in webkit [130874] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WTR][CMake] Add a missing TestNetscapePlugin file
https://bugs.webkit.org/show_bug.cgi?id=98637

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-10-10
Reviewed by Kenneth Rohde Christiansen.

PluginScriptableObjectOverridesAllProperties.cpp is used during
plugins/npruntime/overrides-all-properties.html test introduced by r123936.

  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1:31 AM Changeset in webkit [130873] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing test.
https://bugs.webkit.org/show_bug.cgi?id=98876

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-10-10

  • platform/qt/TestExpectations: skip fast/text/word-space-with-kerning.html.
1:31 AM Changeset in webkit [130872] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add moveDoubleToInts and moveIntsToDouble to MacroAssemblerARM
https://bugs.webkit.org/show_bug.cgi?id=98855

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2012-10-10
Reviewed by Filip Pizlo.

Implement the missing moveDoubleToInts and moveIntsToDouble
methods in the MacroAssemblerARM after r130839.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::moveDoubleToInts):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::moveIntsToDouble):

1:24 AM WebInspector edited by mtjohnwoods@gmail.com
(diff)
1:14 AM Changeset in webkit [130871] by commit-queue@webkit.org
  • 8 edits
    6 adds in trunk/Source/WebKit2

[EFL][WK2] Add History callbacks API
https://bugs.webkit.org/show_bug.cgi?id=98594

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-10
Reviewed by Kenneth Rohde Christiansen.

Added History callbacks API to Ewk Context. Added unit tests.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(ewk_context_history_callbacks_set): New public function which lets the client to set History callbacks.
(ewk_context_history_client_get):
(ewk_context_add_visited_link): New public function to mark a URL as visited link.

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_history_client.cpp: Added.

(getEwkHistoryDelegate):
(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
(populateVisitedLinks):
(ewk_context_history_client_attach):

  • UIProcess/API/efl/ewk_context_history_client_private.h: Added.
  • UIProcess/API/efl/ewk_context_private.h:
  • UIProcess/API/efl/ewk_navigation_data.cpp: Added.

(_Ewk_Navigation_Data):
(_Ewk_Navigation_Data::_Ewk_Navigation_Data):
(_Ewk_Navigation_Data::~_Ewk_Navigation_Data):
(ewk_navigation_data_ref):
(ewk_navigation_data_unref):
(ewk_navigation_data_title_get):
(ewk_navigation_data_original_request_get):
(ewk_navigation_data_url_get):
(ewk_navigation_data_new):

  • UIProcess/API/efl/ewk_navigation_data.h: Added.
  • UIProcess/API/efl/ewk_navigation_data_private.h: Added.
  • UIProcess/API/efl/ewk_view.cpp:

(addToPageViewMap):
(removeFromPageViewMap):
(_ewk_view_smart_del):
(_ewk_view_initialize):
(ewk_view_from_page_get):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/tests/test_ewk2_context_history_delegate.cpp: Added.

(httpServer):
(navigateWithNavigationData):
(performClientRedirect):
(performServerRedirect):
(updateHistoryTitle):
(populateVisitedLinks):
(onLoadFinishedForRedirection):
(serverCallbackRedirection):
(TEST_F):

1:04 AM Changeset in webkit [130870] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

ElementAttributeData: tighten member packing on 64-bit.
<http://webkit.org/b/98861>

Reviewed by Anders Carlsson.

Pack m_isMutable and m_arraySize into the slack from the RefCounted base on 64-bit.
218kB progression on Membuster3.

  • dom/ElementAttributeData.h:

(ElementAttributeData):

12:55 AM Changeset in webkit [130869] by bashi@chromium.org
  • 15 edits
    1 add
    1 delete in trunk/Tools

Update pywebsocket to 0.7.7
https://bugs.webkit.org/show_bug.cgi?id=98872

Reviewed by Yuta Kitamura.

This version contains server-side permessage-compress extension support.
We need this version to add tests for permessage-compress extension.

I confirmed all tests under http/tests/websocket passed.

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/init.py:
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py:
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:

(parse_frame):
(FragmentedFrameBuilder.init):
(FragmentedFrameBuilder.build):
(create_closing_handshake_body):
(StreamOptions.init):
(Stream.init):
(Stream._receive_frame._receive_bytes):
(Stream._receive_frame):
(Stream.receive_filtered_frame):
(Stream.send_message):
(Stream._get_message_from_frame):
(Stream):
(Stream._process_close_message):
(Stream._process_ping_message):
(Stream._process_pong_message):
(Stream.receive_message):
(Stream._send_closing_handshake):
(Stream.get_last_received_opcode):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:

(Dispatcher.transfer_data):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:

(ExtensionProcessorInterface.name):
(DeflateStreamExtensionProcessor):
(DeflateStreamExtensionProcessor.name):
(_log_compression_ratio):
(_log_decompression_ratio):
(DeflateFrameExtensionProcessor):
(DeflateFrameExtensionProcessor.name):
(DeflateFrameExtensionProcessor._outgoing_filter):
(DeflateFrameExtensionProcessor._incoming_filter):
(CompressionExtensionProcessorBase):
(CompressionExtensionProcessorBase.for):
(CompressionExtensionProcessorBase.init):
(CompressionExtensionProcessorBase.name):
(CompressionExtensionProcessorBase._get_compression_processor_response):
(CompressionExtensionProcessorBase.set_compression_processor_hook):
(PerFrameCompressionExtensionProcessor):
(PerFrameCompressionExtensionProcessor.init):
(PerFrameCompressionExtensionProcessor.name):
(PerFrameCompressionExtensionProcessor._lookup_compression_processor):
(DeflateMessageProcessor):
(DeflateMessageProcessor.init):
(DeflateMessageProcessor.name):
(DeflateMessageProcessor.get_extension_response):
(DeflateMessageProcessor.setup_stream_options):
(DeflateMessageProcessor.setup_stream_options._OutgoingMessageFilter):
(DeflateMessageProcessor.setup_stream_options._OutgoingMessageFilter.init):
(DeflateMessageProcessor.setup_stream_options._OutgoingMessageFilter.filter):
(DeflateMessageProcessor.setup_stream_options._IncomingMessageFilter):
(DeflateMessageProcessor.setup_stream_options._IncomingMessageFilter.init):
(DeflateMessageProcessor.setup_stream_options._IncomingMessageFilter.decompress_next_message):
(DeflateMessageProcessor.setup_stream_options._IncomingMessageFilter.filter):
(DeflateMessageProcessor.setup_stream_options._OutgoingFrameFilter):
(DeflateMessageProcessor.setup_stream_options._OutgoingFrameFilter.init):
(DeflateMessageProcessor.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
(DeflateMessageProcessor.setup_stream_options._OutgoingFrameFilter.filter):
(DeflateMessageProcessor.setup_stream_options._IncomingFrameFilter):
(DeflateMessageProcessor.setup_stream_options._IncomingFrameFilter.init):
(DeflateMessageProcessor.setup_stream_options._IncomingFrameFilter.filter):
(DeflateMessageProcessor.set_c2s_max_window_bits):
(DeflateMessageProcessor.set_c2s_no_context_takeover):
(DeflateMessageProcessor.enable_outgoing_compression):
(DeflateMessageProcessor.disable_outgoing_compression):
(DeflateMessageProcessor._process_incoming_message):
(DeflateMessageProcessor._process_outgoing_message):
(DeflateMessageProcessor._process_incoming_frame):
(DeflateMessageProcessor._process_outgoing_frame):
(PerMessageCompressionExtensionProcessor):
(PerMessageCompressionExtensionProcessor.init):
(PerMessageCompressionExtensionProcessor.name):
(PerMessageCompressionExtensionProcessor._lookup_compression_processor):
(MuxExtensionProcessor):
(MuxExtensionProcessor.init):
(MuxExtensionProcessor.name):
(MuxExtensionProcessor.get_extension_response):
(MuxExtensionProcessor.setup_stream_options):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/init.py:

(do_handshake):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:

(validate_subprotocol):
(check_request_line):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/draft75.py: Removed.
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:

(Handshaker.do_handshake):
(Handshaker._set_protocol):
(Handshaker._create_stream):
(Handshaker):
(Handshaker._create_handshake_response):
(Handshaker._send_handshake):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py:

(send_message):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Added.

(MuxUnexpectedException):
(MuxNotImplementedException):
(LogicalConnectionClosedException):
(PhysicalConnectionError):
(PhysicalConnectionError.init):
(LogicalChannelError):
(LogicalChannelError.init):
(_encode_channel_id):
(_encode_number):
(_create_add_channel_response):
(_create_drop_channel):
(_create_flow_control):
(_create_new_channel_slot):
(_create_fallback_new_channel_slot):
(_parse_request_text):
(_ControlBlock):
(_ControlBlock.init):
(_MuxFramePayloadParser):
(_MuxFramePayloadParser.that):
(_MuxFramePayloadParser.init):
(_MuxFramePayloadParser.read_channel_id):
(_MuxFramePayloadParser.read_inner_frame):
(_MuxFramePayloadParser._read_number):
(_MuxFramePayloadParser._read_size_and_contents):
(_MuxFramePayloadParser._read_add_channel_request):
(_MuxFramePayloadParser._read_add_channel_response):
(_MuxFramePayloadParser._read_flow_control):
(_MuxFramePayloadParser._read_drop_channel):
(_MuxFramePayloadParser._read_new_channel_slot):
(_MuxFramePayloadParser.read_control_blocks):
(_MuxFramePayloadParser.remaining_data):
(_LogicalRequest):
(_LogicalRequest.init):
(_LogicalRequest.is_https):
(_LogicalConnection):
(_LogicalConnection.init):
(_LogicalConnection.get_local_addr):
(_LogicalConnection.get_remote_addr):
(_LogicalConnection.get_memorized_lines):
(_LogicalConnection.write):
(_LogicalConnection.write_control_data):
(_LogicalConnection.notify_write_done):
(_LogicalConnection.append_frame_data):
(_LogicalConnection.read):
(_LogicalConnection.set_read_state):
(_LogicalStream):
(_LogicalStream.interprets):
(_LogicalStream.init):
(_LogicalStream._create_inner_frame):
(_LogicalStream._write_inner_frame):
(_LogicalStream.replenish_send_quota):
(_LogicalStream.consume_receive_quota):
(_LogicalStream.send_message):
(_LogicalStream._receive_frame):
(_LogicalStream.receive_message):
(_LogicalStream._send_closing_handshake):
(_LogicalStream.send_ping):
(_LogicalStream._send_pong):
(_LogicalStream.close_connection):
(_LogicalStream._drain_received_data):
(_OutgoingData):
(_OutgoingData.init):
(_PhysicalConnectionWriter):
(_PhysicalConnectionWriter.init):
(_PhysicalConnectionWriter.put_outgoing_data):
(_PhysicalConnectionWriter._write_data):
(_PhysicalConnectionWriter.run):
(_PhysicalConnectionWriter.stop):
(_PhysicalConnectionReader):
(_PhysicalConnectionReader.init):
(_PhysicalConnectionReader.run):
(_Worker):
(_Worker.init):
(_Worker.run):
(_MuxHandshaker):
(_MuxHandshaker.init):
(_MuxHandshaker._create_stream):
(_MuxHandshaker._create_handshake_response):
(_MuxHandshaker._send_handshake):
(_LogicalChannelData):
(_LogicalChannelData.init):
(_HandshakeDeltaBase):
(_HandshakeDeltaBase.that):
(_HandshakeDeltaBase.init):
(_HandshakeDeltaBase.create_headers):
(_MuxHandler):
(_MuxHandler.are):
(_MuxHandler.init):
(_MuxHandler.start):
(_MuxHandler.add_channel_slots):
(_MuxHandler.wait_until_done):
(_MuxHandler.notify_write_done):
(_MuxHandler.send_control_data):
(_MuxHandler.send_data):
(_MuxHandler._send_drop_channel):
(_MuxHandler._send_error_add_channel_response):
(_MuxHandler._create_logical_request):
(_MuxHandler._do_handshake_for_logical_request):
(_MuxHandler._add_logical_channel):
(_MuxHandler._process_add_channel_request):
(_MuxHandler._process_flow_control):
(_MuxHandler._process_drop_channel):
(_MuxHandler._process_control_blocks):
(_MuxHandler._process_logical_frame):
(_MuxHandler.dispatch_message):
(_MuxHandler.notify_worker_done):
(_MuxHandler.notify_reader_done):
(_MuxHandler.fail_physical_connection):
(_MuxHandler.fail_logical_channel):
(use_mux):
(start):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:

(_StandaloneRequest.get_protocol):
(_StandaloneRequest):
(_alias_handlers):
(WebSocketServer.init):
(WebSocketServer._create_sockets):
(WebSocketServer.server_bind):
(WebSocketServer.server_activate):
(WebSocketRequestHandler.parse_request):
(_configure_logging):
(_build_option_parser):
(_main):
(_main.if):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py:
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:

(_Deflater.compress):
(_RFC1979Deflater.filter):

12:33 AM Changeset in webkit [130868] by tkent@chromium.org
  • 3 edits
    5 adds in trunk/LayoutTests

Add a test to check a step attribute works for a calendar picker
https://bugs.webkit.org/show_bug.cgi?id=98866

Reviewed by Yuta Kitamura.

  • platform/chromium-android/TestExpectations:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html: Added.
12:32 AM Changeset in webkit [130867] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Unreviewed, rolling out r130853.
http://trac.webkit.org/changeset/130853
https://bugs.webkit.org/show_bug.cgi?id=98873

The rollout was incorrect (Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-10

  • webkit/webkitwebview.cpp:

(resizeWebViewFromAllocation):
(webkit_web_view_size_allocate):
(webkitWebViewMap):

12:23 AM Changeset in webkit [130866] by aelias@chromium.org
  • 2 edits in trunk/Source/WebCore

Text Autosizing: Counteract funky window sizing on Android.
https://bugs.webkit.org/show_bug.cgi?id=98809

Reviewed by Adam Barth.

In Chrome for Android, the window sizes provided to WebCore are
currently in physical screen pixels instead of
device-scale-adjusted units. For example window width on a
Galaxy Nexus is 720 instead of 360. Text autosizing expects
device-independent pixels. When Chrome for Android cuts over to
the new coordinate space, it will be tied to the setting
applyPageScaleFactorInCompositor.

No new tests.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processSubtree):

12:03 AM Changeset in webkit [130865] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip tests to paint the bot green.

  • platform/qt-5.0-wk2/TestExpectations:

Oct 9, 2012:

11:59 PM Changeset in webkit [130864] by kerz@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/svg/SVGElementInstance.cpp

Merge 130855 - Recursively detach SVGElementInstances
https://bugs.webkit.org/show_bug.cgi?id=98851

Reviewed by Ryosuke Niwa and Abhishek Arya

Before this patch, SVGElementInstance child nodes were not being detached. This
patch makes detach() recursively detach SVGElementInstances.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::detach):

TBR=pdr@google.com
Review URL: https://codereview.chromium.org/11017051

11:59 PM Changeset in webkit [130863] by kerz@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/svg/SVGElementInstance.cpp

Merge 130855 - Recursively detach SVGElementInstances
https://bugs.webkit.org/show_bug.cgi?id=98851

Reviewed by Ryosuke Niwa and Abhishek Arya

Before this patch, SVGElementInstance child nodes were not being detached. This
patch makes detach() recursively detach SVGElementInstances.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::detach):

TBR=pdr@google.com
Review URL: https://codereview.chromium.org/11086043

11:58 PM Changeset in webkit [130862] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

Flush load-and-stall.php output after sleeping
https://bugs.webkit.org/show_bug.cgi?id=98862

Reviewed by Kent Tamura.

Should not be a behavioral change: testing the bots with this change to see if
it helps with chromium linux/win test flakyness.

  • http/tests/resources/load-and-stall.php:
11:56 PM Changeset in webkit [130861] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note test failures after http://trac.webkit.org/changeset/130851. We
plan to follow up in the morning in
https://bugs.webkit.org/show_bug.cgi?id=98867.

  • platform/chromium/TestExpectations:
11:46 PM Changeset in webkit [130860] by inferno@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebCore/inspector/front-end/inspector.css

Revert 130482 - Merge 125255 - Web Inspector: Search matches count view is flaky.
https://bugs.webkit.org/show_bug.cgi?id=93451

Patch by Sam D <dsam2912@gmail.com> on 2012-08-10
Reviewed by Pavel Feldman.

Modified css properties for aligning search panel.

No new tests.UI change.

  • inspector/front-end/inspector.css:

(.search-results-matches):

TBR=commit-queue@webkit.org
BUG=153753
Review URL: https://codereview.chromium.org/11029044

TBR=vsevik@chromium.org
Review URL: https://codereview.chromium.org/11090043

11:46 PM Changeset in webkit [130859] by inferno@chromium.org
  • 3 edits in branches/chromium/1229/Source/WebCore/inspector/front-end

Revert 130484 - Merge 124886 - Web Inspector: Do not disable network tracking while profiling cpu.
https://bugs.webkit.org/show_bug.cgi?id=93359

Reviewed by Yury Semikhatsky.

Removed network tracking enabling/disabling machinery.

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileType.prototype.buttonClicked):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):

TBR=vsevik@chromium.org
BUG=153748
Review URL: https://codereview.chromium.org/11068016

TBR=vsevik@chromium.org
Review URL: https://codereview.chromium.org/11086042

11:45 PM Changeset in webkit [130858] by inferno@chromium.org
  • 1 edit
    2 deletes in branches/chromium/1229

Revert 130719 - Merge 130717 - HTMLSelectElement::typeAheadFind depends on implementation dependent behavior
https://bugs.webkit.org/show_bug.cgi?id=98710

Reviewed by Kent Tamura.

Source/WebCore:

This patch gets rid of C/C++ implementation dependent behavior from
HTMLSelectElement::typeAheadFind() which does modulo operation with
a negative operand.

HTMLSelectElement::typeAheadFind() contains expression with modulo
operator and dividend can be -1 when the "select" element without
"option" element but "optgroup" element.

Test: fast/forms/select/select-typeahead-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo
operation with both operands are non-negative.

LayoutTests:

This patch adds a test for checking HTMLSelectElement::typeAheadFind
doesn't crash.

  • fast/forms/select/select-typeahead-crash-expected.txt: Added.
  • fast/forms/select/select-typeahead-crash.html: Added.

TBR=yosin@chromium.org
Review URL: https://codereview.chromium.org/11091018

TBR=yosin@chromium.org
Review URL: https://codereview.chromium.org/11090042

11:38 PM Changeset in webkit [130857] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Tests failure on Chromium Mac after r130821.
https://bugs.webkit.org/show_bug.cgi?id=98865

Unreviewed.

Marking tests as failing.

  • platform/chromium/TestExpectations:
11:34 PM Changeset in webkit [130856] by inferno@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebCore/svg/SVGElementInstance.cpp

Merge 130855 - Recursively detach SVGElementInstances
Review URL: https://codereview.chromium.org/11093040

11:31 PM Changeset in webkit [130855] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Recursively detach SVGElementInstances
https://bugs.webkit.org/show_bug.cgi?id=98851

Reviewed by Ryosuke Niwa and Abhishek Arya

Before this patch, SVGElementInstance child nodes were not being detached. This
patch makes detach() recursively detach SVGElementInstances.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::detach):

11:23 PM Changeset in webkit [130854] by bashi@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Fix harfbuzz-ng related code after r130231
https://bugs.webkit.org/show_bug.cgi?id=98858

Reviewed by Kent Tamura.

Replace first/second with key/value.

No new tests. No changes in behavior.

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp:

(WebCore::harfbuzzGetGlyph):

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

11:10 PM Changeset in webkit [130853] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Unreviewed, rolling out r130838.
http://trac.webkit.org/changeset/130838
https://bugs.webkit.org/show_bug.cgi?id=98860

The patch is causing X errors (=> crashes) on GTK 64-bit
Release builder (Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09

  • webkit/webkitwebview.cpp:

(resizeWebViewFromAllocation):
(webkit_web_view_size_allocate):
(webkitWebViewMap):

11:02 PM Changeset in webkit [130852] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

Initialize $written variable in load-and-stall.php script
https://bugs.webkit.org/show_bug.cgi?id=98854

Reviewed by Kent Tamura.

  • http/tests/resources/load-and-stall.php:
11:00 PM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
10:48 PM Changeset in webkit [130851] by enrica@apple.com
  • 7 edits in trunk/Source/WebCore

Only measure text once instead of twice when performing line layout.
https://bugs.webkit.org/show_bug.cgi?id=98317
<rdar://problem/12080821>

Reviewed by Dan Bernstein.

Since we are measuring each word to find out where the line break should occur,
we should cache that information to avoid measuring the run again when
creating the line box. The bulk of the change is in nextLineBreak, where
the measurements are collected and placed in a vector so that they can
be consumed in setLogicalWidthForTextRun where we used to measure the
text one more time.
Each entry in the vector is a WordMeasurement object that contains information
about the start and end offset in the run, the renderer, the measured width
and, possibly, a list of fallback fonts.
When we need to compute the width of the run to create the line box, we add
all the measurements for the given renderer in the run to get the total width.
This optiomization is currently disabled for platforms using HarfBuzz.

  • platform/graphics/Font.cpp:

(WebCore::Font::width): Added fallback fonts parameter.

  • platform/graphics/Font.h:

(Font): Added fallback fonts parameter to the width static member function.
This method is called when we compute the width using TextLayout.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::TextLayout::width): Added fallback fonts parameter.
(WebCore::Font::width):
(WebCore::ComplexTextController::advance):

  • platform/graphics/mac/ComplexTextController.h:

(ComplexTextController): Added fallback fonts parameter to advance method.

  • rendering/RenderBlock.h: Added WordMeasures parameter to few methods.
  • rendering/RenderBlockLineLayout.cpp:

(WordMeasurement): Added new class to hold measurement information.
(WebCore::setLogicalWidthForTextRun): This is where we compute the run width using the
cached information.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Added wordMeasures parameter.
(WebCore::RenderBlock::createLineBoxesFromBidiRuns): Added wordMeasures parameter.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Added declaration of the WordMeasures
vector and its use.
(WebCore::textWidth): Added fallbackFonts parameter, since now we only measure once.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): This method has been modified to collect
the measurements of the individual words and add them to the vector.

10:28 PM Changeset in webkit [130850] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

GlyphPageTreeNode should use HashMap<OwnPtr>.
<http://webkit.org/b/98845>

Reviewed by Dan Bernstein.

  • Replace manual memory management by OwnPtrs.
  • Added a GlyphPageTreeNodeMap typedef to make call sites look a bit nicer.

Changed some hashmap get()/remove() pairs to use the more efficient take() instead.

  • Made the constructor private, it has no external clients.
  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::getRoot):
(WebCore::GlyphPageTreeNode::pageCount):
(WebCore::GlyphPageTreeNode::getChild):
(WebCore::GlyphPageTreeNode::pruneCustomFontData):
(WebCore::GlyphPageTreeNode::pruneFontData):
(WebCore::GlyphPageTreeNode::showSubtree):

  • platform/graphics/GlyphPageTreeNode.h:

(GlyphPageTreeNode):
(WebCore::GlyphPageTreeNode::GlyphPageTreeNode):

10:25 PM Changeset in webkit [130849] by Csaba Osztrogonác
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk1/fast/history/history-back-initial-vs-final-url-expected.txt: Renamed from LayoutTests/platform/qt/fast/history/history-back-initial-vs-final-url-expected.txt.
10:20 PM Changeset in webkit [130848] by tkent@chromium.org
  • 10 edits in trunk

Sub-fields in input[type=time] should not be focusable if the input is disabled or read-only
https://bugs.webkit.org/show_bug.cgi?id=98850

Reviewed by Kentaro Hara.

Source/WebCore:

Covered by additional test cases of
time-multiple-fields/time-multiple-fields-keyboard-events.html and
time-multiple-fields/time-multiple-fields-mouse-events.html.

  • html/shadow/DateTimeFieldElement.h:

(FieldOwner): Add isFieldOwnerDisabledOrReadOnly.

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::isFocusable):
Check isFieldOwnerDisabledOrReadOnly, and calls HTMLElement::isFocusable()
just in case.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::isFieldOwnerDisabledOrReadOnly): Added.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Declare isFieldOwnerDisabledOrReadOnly.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
  • fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html:
10:07 PM Changeset in webkit [130847] by tkent@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName
https://bugs.webkit.org/show_bug.cgi?id=98714

Reviewed by Abhishek Arya.

  • public/WebElement.h:

(WebElement):

  • Add a comment to tagName().
  • Add a comment to hasTagName().
  • Declare hasHTMLTagName(), which is useful to check HTML tags.
  • src/WebElement.cpp:

(WebKit::WebElement::hasHTMLTagName): Added.

9:56 PM Changeset in webkit [130846] by rjkroege@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] revert fling deacceleration parameter change
https://bugs.webkit.org/show_bug.cgi?id=98820

Reviewed by Adrienne Walker.

After an extended discussion, it has been decided that a previous
adjustment to fling deacceleration parameters should be reverted.

Tested by existing unit tests.

  • platform/TouchFlingPlatformGestureCurve.cpp:

(WebCore::TouchFlingPlatformGestureCurve::createForTouchPad):
(WebCore::TouchFlingPlatformGestureCurve::createForTouchScreen):

9:55 PM Changeset in webkit [130845] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt]REGRESSION(r120107): It made http/tests/xmlhttprequest/origin-exact-matching.html fails
https://bugs.webkit.org/show_bug.cgi?id=88913

Patch by Pablo Flouret <pablof@motorola.com> on 2012-10-09
Reviewed by Csaba Osztrogonác.

Blind fix to try to fix the test.

  • http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html:
  • http/tests/xmlhttprequest/resources/access-control-allow-lists.php:
9:50 PM Changeset in webkit [130844] by commit-queue@webkit.org
  • 11 edits in trunk/LayoutTests

[EFL] Update EFL baselines after r130840
https://bugs.webkit.org/show_bug.cgi?id=98846

Unreviewed EFL gardening.

Update baselines after the cairo update in r130840.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-09

  • platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
9:49 PM Changeset in webkit [130843] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] Change parameter and return type of loadUrlSync().
https://bugs.webkit.org/show_bug.cgi?id=97920

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-09
Reviewed by Gyuyoung Kim.

loadUrlSync() uses waitUntilLoadFinished() internally, and it has
a parameter and return value for timeout.
To set and check timeout, loadUrlSync() should have those.

A parameter for timeout interval is added to loadUrlSync() and it
returns the result of waitUntilLoadFinished() for checking timeout.

And I added codes to check the result of all the LoadUrlSync()
function calls with ASSERT_TRUE() macro.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTestBase):

  • UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_intents.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

9:48 PM Changeset in webkit [130842] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] new test http/tests/cookies/single-quoted-value.html is failing
https://bugs.webkit.org/show_bug.cgi?id=86066

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Csaba Osztrogonác.

Unskipping test.

  • platform/qt/TestExpectations:
8:26 PM Changeset in webkit [130841] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

extract-localizable-strings script should be able to handle paths to files containing whitespaces.
https://bugs.webkit.org/show_bug.cgi?id=98844

Patch by Damian Kaleta <dkaleta@apple.com> on 2012-10-09
Reviewed by Dan Bernstein.

  • Scripts/extract-localizable-strings: Added ability to handle whitespace.
7:15 PM Changeset in webkit [130840] by commit-queue@webkit.org
  • 55 edits in trunk

[Cairo] Bump Cairo to fix more canvas/philip tests
https://bugs.webkit.org/show_bug.cgi?id=97658

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-09
Reviewed by Martin Robinson.

Tools:

Bumping cairo to version 1.12.4 which fixes more canvas/philip tests.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:

LayoutTests:

Update platform-specific baselines after the cairo update. Also,
unksip canvas/philip tests which are passing now.

  • platform/efl/TestExpectations:
  • platform/efl/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/efl/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/efl/fast/dynamic/window-scrollbars-test-expected.png:
  • platform/efl/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png:
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/efl/svg/batik/text/smallFonts-expected.png:
  • platform/efl/svg/batik/text/smallFonts-expected.txt:
  • platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/efl/svg/batik/text/textOnPath-expected.png:
  • platform/efl/svg/batik/text/textOnPath-expected.txt:
  • platform/efl/svg/batik/text/textOnPath2-expected.png:
  • platform/efl/svg/batik/text/textOnPath2-expected.txt:
  • platform/efl/svg/batik/text/textOnPath3-expected.png:
  • platform/efl/svg/batik/text/textOnPath3-expected.txt:
  • platform/efl/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/efl/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/efl/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/efl/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/efl/transforms/2d/transform-fixed-container-expected.png:
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/gtk/svg/batik/text/smallFonts-expected.png:
  • platform/gtk/svg/batik/text/smallFonts-expected.txt:
  • platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath-expected.png:
  • platform/gtk/svg/batik/text/textOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath2-expected.png:
  • platform/gtk/svg/batik/text/textOnPath2-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath3-expected.png:
  • platform/gtk/svg/batik/text/textOnPath3-expected.txt:
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/gtk/svg/custom/js-update-path-changes-expected.png:
  • platform/gtk/svg/custom/js-update-path-changes-expected.txt:
  • platform/gtk/svg/custom/js-update-path-removal-expected.png:
  • platform/gtk/svg/custom/js-update-path-removal-expected.txt:
  • platform/gtk/svg/custom/path-textPath-simulation-expected.png:
  • platform/gtk/svg/custom/path-textPath-simulation-expected.txt:
7:14 PM Changeset in webkit [130839] by fpizlo@apple.com
  • 21 edits
    2 adds in trunk/Source/JavaScriptCore

Typed arrays should not be 20x slower in the baseline JIT than in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=98605

Reviewed by Oliver Hunt and Gavin Barraclough.

This adds typed array get_by_val/put_by_val patching to the baseline JIT. It's
a big (~40%) win on benchmarks that have trouble staying in the DFG JIT. Even
if we fix those benchmarks, this functionality gives us the insurance that we
typically desire with all speculative optimizations: even if we bail to
baseline, we're still reasonably performant.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/MacroAssembler.cpp: Added.

(JSC):

  • assembler/MacroAssembler.h:

(MacroAssembler):
(JSC::MacroAssembler::patchableBranchPtr):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::moveDoubleToInts):
(JSC::MacroAssemblerARMv7::moveIntsToDouble):
(JSC::MacroAssemblerARMv7::patchableBranchPtr):

  • assembler/MacroAssemblerX86.h:

(MacroAssemblerX86):
(JSC::MacroAssemblerX86::moveDoubleToInts):
(JSC::MacroAssemblerX86::moveIntsToDouble):

  • bytecode/ByValInfo.h:

(JSC::hasOptimizableIndexingForClassInfo):
(JSC):
(JSC::hasOptimizableIndexing):
(JSC::jitArrayModeForClassInfo):
(JSC::jitArrayModeForStructure):
(JSC::ByValInfo::ByValInfo):
(ByValInfo):

  • dfg/DFGAssemblyHelpers.cpp:

(DFG):

  • dfg/DFGAssemblyHelpers.h:

(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • jit/JIT.h:

(JIT):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompilePutByVal):
(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSCell.h:
  • runtime/JSGlobalData.h:

(JSGlobalData):
(JSC::JSGlobalData::typedArrayDescriptor):

  • runtime/TypedArrayDescriptor.h: Added.

(JSC):
(JSC::TypedArrayDescriptor::TypedArrayDescriptor):
(TypedArrayDescriptor):

7:11 PM Changeset in webkit [130838] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Plugins don't display
https://bugs.webkit.org/show_bug.cgi?id=98789

Patch by Daniel Drake <dsd@laptop.org> on 2012-10-09
Reviewed by Martin Robinson.

Fix a recent regression where plugin content was not being displayed.
Bringing webkit_web_view_size_allocate in line with the WebKit2
equivalent solves the issue.

  • webkit/webkitwebview.cpp:

(resizeWebViewFromAllocation): pass allocation request to children
even when the allocation size does not change.
(webkit_web_view_size_allocate): don't bail too early if the
allocation size does not change.

7:08 PM Changeset in webkit [130837] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

fast/canvas/canvas-fillRect-gradient-shadow.html failing
https://bugs.webkit.org/show_bug.cgi?id=98760

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-09
Reviewed by Martin Robinson.

Adjust the test case to verify the pixel in the middle of the shadow,
instead of the outer edge, to make sure that the test will not fail
in case if there is any effect around the borders.

  • fast/canvas/script-tests/canvas-fillRect-gradient-shadow.js:
6:41 PM Changeset in webkit [130836] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Move timeout callback to the CallbackDataTimer class.
https://bugs.webkit.org/show_bug.cgi?id=97861

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-09
Reviewed by Gyuyoung Kim.

Timeout callbacks for waitUntil{LoadFinished,TitleChanged,URIChanged}
can be moved to the CallbackDataTimer class.

Moved the callback implementation to the CallbackDataTimer class.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::CallbackDataTimer::CallbackDataTimer):
(CallbackDataTimer):
(EWK2UnitTest::CallbackDataTimer::timeOutCallback):
(EWK2UnitTest::CallbackDataExpectedValue::CallbackDataExpectedValue):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilLoadFinished):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTitleChangedTo):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilURIChangedTo):

6:40 PM Changeset in webkit [130835] by tkent@chromium.org
  • 6 edits
    1 copy
    1 add in trunk

Should reject invalid dates constructed with multiple fields UI
https://bugs.webkit.org/show_bug.cgi?id=98727

Reviewed by Hajime Morita.

Source/WebCore:

In input[type=date] with multiple fields UI, we allow users to set
day-of-month value to 1-31 regardless of the month value. So users can
construct an invalid date such as "2012-02-31". We should sanitize such
values.

This change affects platforms with ENABLE_INPUT_TYPE_DATE &&
ENABLE_INPUT_MULTIPLE_FIELDS_UI.

Test: fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html

  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType): Make sanitizeValue protected to be called from
BaseMultipleFieldsDateAndTimeInputType.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged):
Apply sanitizeValue to a value constructed in UI.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState):
Ditto.

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html: Updated the test. 275760-12 is not a valid month value.
6:23 PM Changeset in webkit [130834] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Check for null m_frame in NetworkJob
https://bugs.webkit.org/show_bug.cgi?id=98830

Patch by Joe Mason <jmason@rim.com> on 2012-10-09
Reviewed by George Staikos.

PR 220025

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::storeCredentials):

6:21 PM Changeset in webkit [130833] by jpfau@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed, skipping http/tests/security/svg-image-leak.html

  • platform/mac/TestExpectations:
6:18 PM Changeset in webkit [130832] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add tests to testapi for null OpaqueJSStrings
https://bugs.webkit.org/show_bug.cgi?id=98805

Reviewed by Geoffrey Garen.

Added tests that check that OpaqueJSString, which is wrapped via JSStringRef, properly returns
null strings and that a null string in a JSStringRef will return a NULL JSChar* and 0 length
via the JSStringGetCharactersPtr() and JSStringGetLength() APIs respectively. Added a check that
JSValueMakeFromJSONString() properly handles a null string as well.

  • API/tests/testapi.c:

(main):

5:30 PM Changeset in webkit [130831] by jchaffraix@webkit.org
  • 2 edits in trunk/Tools

Unreviewed Chromium Windows build fix after r130823.

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(roleToString): Re-added the 'default' label as some cases are not handled.

5:18 PM Changeset in webkit [130830] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

filesystem-url-in-iframe test is flaky
https://bugs.webkit.org/show_bug.cgi?id=95246

Reviewed by Eric Seidel.

This test was assuming that the navigation would complete before the
async JavaScript executed, which is true usually (but not always).

  • http/tests/security/mixedContent/filesystem-url-in-iframe.html:
  • platform/chromium/TestExpectations:
5:06 PM Changeset in webkit [130829] by jianli@chromium.org
  • 54 edits
    2 adds
    2 deletes in trunk

Update the CSS property used to support draggable regions.
https://bugs.webkit.org/show_bug.cgi?id=97156

Reviewed by Adam Barth.

Source/JavaScriptCore:

The CSS property to support draggable regions, guarded under
WIDGET_REGION is now disabled from Mac WebKit, in order not to cause
confusion with DASHBOARD_SUPPORT feature.

  • Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature.

Source/WebCore:

The CSS property to support draggable regions has been changed from
"-webkit-widget-region" to "-webkit-app-region" in the following syntax:

-webkit-app-region: drag|no-drag

The CSS parsing code for draggable regions is now different from the CSS
parsing code for dashboard regions since we have quite different syntax.

We still try to share as much rendering update code as possible for
these two features. To make the shared code easier to understand for
both features, the name "DashboardRegions" in the shared code is changed
to "AnnotatedRegions" to work for both dashboard regions and draggable
regions.

Note that we still using WIDGET_REGION as feature name in order not to
add more changes to this patch. It will be renamed to a more appropriate
name in next patch. WIDGET_REGION is now only turned on for the chromium
port.

Test: fast/css/draggable-region-parser.html

  • Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature.
  • WebCore.exp.in: Update the exported symbol due to renaming.
  • css/CSSComputedStyleDeclaration.cpp: Update the CSS parsing.

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp: Update the CSS parsing.

(WebCore::CSSParser::parseValue):
(WebCore):
(WebCore::CSSParser::parseDashboardRegions):

  • css/CSSParserValues.cpp: Update the CSS parsing.

(WebCore::CSSParserValue::createCSSValue):

  • css/CSSPrimitiveValue.cpp: Update the CSS parsing.

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):

  • css/CSSPrimitiveValue.h: Update the CSS parsing.

(CSSPrimitiveValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in: Rename the CSS property for draggable region.
  • css/CSSValueKeywords.in: Add the keywords supported for the draggable region.
  • css/DashboardRegion.h: Remove WIDGET_REGION guard.

(DashboardRegion):

  • css/StyleResolver.cpp: Update the CSS parsing.

(WebCore::StyleResolver::collectMatchingRulesForList):

  • dom/Document.cpp: Rename dashboardRegions to annotatedRegions.

(WebCore::Document::Document):
(WebCore::Document::annotatedRegions):
(WebCore::Document::setAnnotatedRegions):
(WebCore::Document::reportMemoryUsage):

  • dom/Document.h: Rename dashboardRegions to annotatedRegions.

(WebCore):
(WebCore::Document::setAnnotatedRegionsDirty):
(WebCore::Document::annotatedRegionsDirty):
(WebCore::Document::hasAnnotatedRegions):
(WebCore::Document::setHasAnnotatedRegions):
(Document):

  • page/Chrome.cpp: Rename dashboardRegions to annotatedRegions.

(WebCore::ChromeClient::annotatedRegionsChanged):

  • page/ChromeClient.h: Rename dashboardRegions to annotatedRegions.

(ChromeClient):

  • page/FrameView.cpp: Rename dashboardRegions to annotatedRegions.

(WebCore::FrameView::layout):
(WebCore::FrameView::updateAnnotatedRegions):
(WebCore::FrameView::paintContents):

  • page/FrameView.h: Rename dashboardRegions to annotatedRegions.

(FrameView):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::addAnnotatedRegions):

  • rendering/RenderInline.h: Rename dashboardRegions to annotatedRegions.

(RenderInline):

  • rendering/RenderLayer.cpp: Rename dashboardRegions to annotatedRegions.

(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):

  • rendering/RenderListBox.cpp: Rename dashboardRegions to annotatedRegions.

(WebCore::RenderListBox::setHasVerticalScrollbar):

  • rendering/RenderObject.cpp: Rename dashboardRegions to annotatedRegions.

(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::addAnnotatedRegions):
(WebCore::RenderObject::collectAnnotatedRegions):

  • rendering/RenderObject.h: Rename dashboardRegions to annotatedRegions.

(WebCore::AnnotatedRegionValue::operator==):
(WebCore::AnnotatedRegionValue::operator!=):
(AnnotatedRegionValue):
(RenderObject):

  • rendering/style/RenderStyle.cpp: Update the CSS parsing.

(WebCore::RenderStyle::diff):
(WebCore):

  • rendering/style/RenderStyle.h: Update the CSS parsing.
  • rendering/style/RenderStyleConstants.h: Update the CSS parsing.
  • rendering/style/StyleDashboardRegion.h: Update the CSS parsing.
  • rendering/style/StyleRareNonInheritedData.cpp: Update the CSS parsing.

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h: Update the CSS parsing.

(WebCore):
(StyleRareNonInheritedData):

Source/WebKit/chromium:

Update the code to use the new name annotatedRegions to work for
both features.

  • public/WebDraggableRegion.h: Rename dashboardRegions to annotatedRegions.

(WebDraggableRegion):

  • src/ChromeClientImpl.cpp: Rename dashboardRegions to annotatedRegions.

(WebKit::ChromeClientImpl::annotatedRegionsChanged):

  • src/ChromeClientImpl.h: Rename dashboardRegions to annotatedRegions.

(ChromeClientImpl):

  • src/WebDocument.cpp: Rename dashboardRegions to annotatedRegions.

(WebKit::WebDocument::draggableRegions):

Source/WebKit/mac:

The CSS property to support draggable regions, guarded under
WIDGET_REGION is now disabled from Mac WebKit, in order not to cause
confusion with DASHBOARD_SUPPORT feature.

Also update the code to use the new name annotatedRegions to work for
both features.

  • Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature.
  • WebCoreSupport/WebChromeClient.h: Rename dashboardRegions to annotatedRegions.
  • WebCoreSupport/WebChromeClient.mm: Rename dashboardRegions to annotatedRegions.

(WebChromeClient::annotatedRegionsChanged):

  • WebView/WebView.mm: Rename dashboardRegions to annotatedRegions.

(-[WebView _dashboardRegions]):

Source/WebKit2:

The CSS property to support draggable regions, guarded under
WIDGET_REGION is now disabled from Mac WebKit, in order not to cause
confusion with DASHBOARD_SUPPORT feature.

Also update the code to use the new name annotatedRegions to work for
both features.

  • Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: Rename dashboardRegions to annotatedRegions.

(WebKit::WebChromeClient::annotatedRegionsChanged):

  • WebProcess/WebCoreSupport/WebChromeClient.h: Rename dashboardRegions to annotatedRegions.

(WebChromeClient):

LayoutTests:

Update the test and rename the files due to CSS property name and
syntax changes.

  • fast/css/draggable-region-parser-expected.txt: Added.
  • fast/css/draggable-region-parser.html: Added.
  • fast/css/widget-region-parser-expected.txt: Removed.
  • fast/css/widget-region-parser.html: Removed.
  • platform/efl/TestExpectations: Rename the skipped test.
  • platform/gtk/TestExpectations: Rename the skipped test.
  • platform/mac/TestExpectations: Skip the renamed test since WIDGET_REGION is off.
  • platform/qt/TestExpectations: Rename the skipped test.
  • platform/win/TestExpectations: Rename the skipped test.
  • platform/wincairo/TestExpectations: Rename the skipped test.
5:00 PM Changeset in webkit [130828] by fpizlo@apple.com
  • 1 edit
    2 adds in trunk/Source/JavaScriptCore

Unreviewed, adding forgotten files.

  • bytecode/ByValInfo.h: Added.

(JSC):
(JSC::isOptimizableIndexingType):
(JSC::jitArrayModeForIndexingType):
(JSC::ByValInfo::ByValInfo):
(ByValInfo):
(JSC::getByValInfoBytecodeIndex):

  • runtime/IndexingType.cpp: Added.

(JSC):
(JSC::indexingTypeToString):

4:49 PM Changeset in webkit [130827] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Fix coding style of layout test fast/dom/timer-throttling-hidden-page.html
https://bugs.webkit.org/show_bug.cgi?id=98828

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-10-09
Reviewed by Ojan Vafai.

Replaced tab characters with spaces, fixed position of braces and renamed
variables to be more explanatory.

  • fast/dom/timer-throttling-hidden-page.html:
4:39 PM Changeset in webkit [130826] by fpizlo@apple.com
  • 58 edits in trunk/Source

JSC should infer when indexed storage is contiguous, and optimize for it
https://bugs.webkit.org/show_bug.cgi?id=97288

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

This introduces a new kind of indexed property storage called Contiguous,
which has the following properties:

  • No header bits beyond IndexedHeader. This results in a 16 byte reduction in memory usage per array versus an ArrayStorage array. It also means that the total memory usage for an empty array is now just 3 * 8 on both 32-bit and 64-bit. Of that, only 8 bytes are array-specific; the rest is our standard object header overhead.


  • No need for hole checks on store. This results in a ~4% speed-up on Kraken and a ~1% speed-up on V8v7.


  • publicLength <= vectorLength. This means that doing new Array(blah) immediately allocates room for blah elements.


  • No sparse map or index bias.


If you ever do things to an array that would require publicLength >
vectorLength, a sparse map, or index bias, then we switch to ArrayStorage
mode. This seems to never happen in any benchmark we track, and is unlikely
to happen very frequently on any website.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::JumpList::append):

  • assembler/MacroAssembler.h:

(MacroAssembler):
(JSC::MacroAssembler::patchableBranchTest32):

  • bytecode/ByValInfo.h: Added.

(JSC):
(JSC::isOptimizableIndexingType):
(JSC::jitArrayModeForIndexingType):
(JSC::ByValInfo::ByValInfo):
(ByValInfo):
(JSC::getByValInfoBytecodeIndex):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::getByValInfo):
(JSC::CodeBlock::setNumberOfByValInfos):
(JSC::CodeBlock::numberOfByValInfos):
(JSC::CodeBlock::byValInfo):

  • bytecode/SamplingTool.h:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::fromObserved):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):

  • dfg/DFGArrayMode.h:

(DFG):
(JSC::DFG::modeUsesButterfly):
(JSC::DFG::modeIsJSArray):
(JSC::DFG::isInBoundsAccess):
(JSC::DFG::mayStoreToTail):
(JSC::DFG::mayStoreToHole):
(JSC::DFG::modeIsPolymorphic):
(JSC::DFG::polymorphicIncludesContiguous):
(JSC::DFG::polymorphicIncludesArrayStorage):
(JSC::DFG::canCSEStorage):
(JSC::DFG::modeSupportsLength):
(JSC::DFG::benefitsFromStructureCheck):
(JSC::DFG::isEffectful):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::byValIsPure):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
(JSC::DFG::SpeculativeJIT::temporaryRegisterForPutByVal):
(DFG):

  • dfg/DFGSpeculativeJIT.h:

(DFG):
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::putByValWillNeedExtraRegister):
(JSC::DFG::SpeculativeJIT::temporaryRegisterForPutByVal):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileContiguousGetByVal):
(DFG):
(JSC::DFG::SpeculativeJIT::compileArrayStorageGetByVal):
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compileArrayStoragePutByVal):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileContiguousGetByVal):
(DFG):
(JSC::DFG::SpeculativeJIT::compileArrayStorageGetByVal):
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compileArrayStoragePutByVal):
(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/Interpreter.cpp:

(SamplingScope):
(JSC::SamplingScope::SamplingScope):
(JSC::SamplingScope::~SamplingScope):
(JSC):
(JSC::Interpreter::execute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::ByValCompilationInfo::ByValCompilationInfo):
(ByValCompilationInfo):
(JSC):
(JIT):
(JSC::JIT::compileGetByVal):
(JSC::JIT::compilePutByVal):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateJSArray):
(JSC::JIT::emitArrayProfileStoreToHoleSpecialCase):
(JSC):
(JSC::arrayProfileSaw):
(JSC::JIT::chooseArrayMode):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_get_argument_by_val):
(JSC::JIT::emit_op_new_array):
(JSC::JIT::emitSlow_op_new_array):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_get_argument_by_val):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC):
(JSC::JIT::emitContiguousGetByVal):
(JSC::JIT::emitArrayStorageGetByVal):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompilePutByVal):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC):
(JSC::JIT::emitContiguousGetByVal):
(JSC::JIT::emitArrayStorageGetByVal):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emitSlow_op_put_by_val):

  • jit/JITStubs.cpp:

(JSC::getByVal):
(JSC):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::putByVal):

  • jit/JITStubs.h:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/ArrayConventions.h:

(JSC::isDenseEnoughForVector):

  • runtime/ArrayPrototype.cpp:

(JSC):
(JSC::shift):
(JSC::unshift):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

  • runtime/Butterfly.h:

(Butterfly):
(JSC::Butterfly::fromPointer):
(JSC::Butterfly::pointer):
(JSC::Butterfly::publicLength):
(JSC::Butterfly::vectorLength):
(JSC::Butterfly::setPublicLength):
(JSC::Butterfly::setVectorLength):
(JSC::Butterfly::contiguous):
(JSC::Butterfly::fromContiguous):

  • runtime/ButterflyInlineMethods.h:

(JSC::Butterfly::unshift):
(JSC::Butterfly::shift):

  • runtime/IndexingHeaderInlineMethods.h:

(JSC::IndexingHeader::indexingPayloadSizeInBytes):

  • runtime/IndexingType.cpp: Added.

(JSC):
(JSC::indexingTypeToString):

  • runtime/IndexingType.h:

(JSC):
(JSC::hasContiguous):

  • runtime/JSArray.cpp:

(JSC::JSArray::setLengthWithArrayStorage):
(JSC::JSArray::setLength):
(JSC):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithArrayStorage):
(JSC::JSArray::unshiftCountWithAnyIndexingType):
(JSC::JSArray::sortNumericVector):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sortCompactedVector):
(JSC::JSArray::sort):
(JSC::JSArray::sortVector):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
(JSC::JSArray::compactForSorting):

  • runtime/JSArray.h:

(JSC::JSArray::shiftCountForShift):
(JSC::JSArray::shiftCountForSplice):
(JSArray):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCountForShift):
(JSC::JSArray::unshiftCountForSplice):
(JSC::JSArray::unshiftCount):
(JSC::JSArray::isLengthWritable):
(JSC::createContiguousArrayButterfly):
(JSC):
(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC):
(JSC::JSGlobalObject::haveABadTime):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::arrayStructureWithArrayStorage):
(JSC::JSGlobalObject::addressOfArrayStructureWithArrayStorage):
(JSC::constructEmptyArray):

  • runtime/JSObject.cpp:

(JSC::JSObject::visitButterfly):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::putByIndex):
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::createInitialContiguous):
(JSC):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::ensureArrayStorageSlow):
(JSC::JSObject::ensureIndexedStorageSlow):
(JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
(JSC::JSObject::switchToSlowPutArrayStorage):
(JSC::JSObject::setPrototype):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::putByIndexBeyondVectorLengthContiguousWithoutAttributes):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::countElementsInContiguous):
(JSC::JSObject::increaseVectorLength):
(JSC::JSObject::ensureContiguousLengthSlow):
(JSC::JSObject::getOwnPropertyDescriptor):

  • runtime/JSObject.h:

(JSC::JSObject::getArrayLength):
(JSC::JSObject::getVectorLength):
(JSC::JSObject::canGetIndexQuickly):
(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly):
(JSC::JSObject::canSetIndexQuickly):
(JSC::JSObject::canSetIndexQuicklyForPutDirect):
(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):
(JSC::JSObject::hasSparseMap):
(JSC::JSObject::inSparseIndexingMode):
(JSObject):
(JSC::JSObject::ensureContiguous):
(JSC::JSObject::ensureIndexedStorage):
(JSC::JSObject::ensureContiguousLength):
(JSC::JSObject::indexingData):
(JSC::JSObject::relevantLength):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/Structure.cpp:

(JSC::Structure::needsSlowPutIndexing):
(JSC):
(JSC::Structure::suggestedArrayStorageTransition):

  • runtime/Structure.h:

(Structure):

  • runtime/StructureTransitionTable.h:

(JSC::newIndexingType):

Source/WTF:

Moved out this helpful math utility to MathExtras, since we now use it in
multiple places.

  • wtf/MathExtras.h:

(timesThreePlusOneDividedByTwo):

4:28 PM Changeset in webkit [130825] by commit-queue@webkit.org
  • 8 edits in trunk

[chromium] Add drop event for plugins.
https://bugs.webkit.org/show_bug.cgi?id=98827

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-09
Reviewed by Adam Barth.

Source/WebKit/chromium:

Add conversion for drop events.

  • public/WebDragStatus.h:
  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleDragEvent):

Tools:

Update the test plugin to receive drop events.

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::handleDragStatusUpdate):

LayoutTests:

Updated the test to verify that a plugin can receive drop events. Note
that the plugin needs contentEditable set to true.

  • platform/chromium/plugins/drag-events-expected.txt:
  • platform/chromium/plugins/drag-events.html:
4:21 PM Changeset in webkit [130824] by commit-queue@webkit.org
  • 71 edits
    6 deletes in trunk

Unreviewed, rolling out r130811 and r130821.
http://trac.webkit.org/changeset/130811
http://trac.webkit.org/changeset/130821
https://bugs.webkit.org/show_bug.cgi?id=98831

Broke date-suggestion-picker-appearance-with-scroll-bar.html
(Requested by abarth|gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09

Source/WebCore:

  • WebCore.exp.in:
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getUpperLeftCorner):
(WebCore::ContainerNode::getLowerRightCorner):

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::computeRelativePosition):

  • dom/Node.cpp:

(WebCore::Node::convertToPage):
(WebCore::Node::convertFromPage):

  • editing/FrameSelection.cpp:

(WebCore::CaretBase::absoluteBoundsForLocalRect):

  • editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::absoluteRect):

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::absoluteCaretBounds):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::defaultEventHandler):

  • page/FrameView.cpp:

(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::absoluteQuads):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::absoluteQuads):
(WebCore::RenderBox::absoluteContentBox):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::mapAbsoluteToLocalPoint):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computeStickyPositionConstraints):
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::userResize):

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::absolutePoint):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::absoluteToContents):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::childrenClipRect):
(WebCore::RenderLayer::selfClipRect):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::contentsVisible):

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::absoluteFocusRingQuads):
(WebCore::RenderObject::localToAbsolute):
(WebCore::RenderObject::absoluteToLocal):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::mapAbsoluteToLocalPoint):
(WebCore::RenderObject::localToContainerQuad):
(WebCore::RenderObject::localToContainerPoint):

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::localToAbsoluteQuad):

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):

  • rendering/RenderView.cpp:

(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):
(WebCore::RenderView::selectionBounds):

  • rendering/RenderView.h:

(RenderView):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetGeometry):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::mapLocalToContainer):

  • rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::mapLocalToContainer):

  • rendering/svg/RenderSVGInline.h:

(RenderSVGInline):

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::mapLocalToContainer):
(WebCore::RenderSVGModelObject::absoluteQuads):

  • rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::mapLocalToContainer):

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::mapLocalToContainer):
(WebCore::RenderSVGText::absoluteQuads):

  • rendering/svg/RenderSVGText.h:

(RenderSVGText):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform):

Source/WebKit/chromium:

  • src/FindInPageCoordinates.cpp:

(WebKit::toNormalizedRect):

  • src/LinkHighlight.cpp:

(WebKit::convertTargetSpaceQuadToCompositedLayer):

  • src/WebInputEventConversion.cpp:

(WebKit::convertLocationForRenderObject):

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(screenRectOfContents):

  • WebView/WebRenderNode.mm:

(copyRenderNode):

Source/WebKit2:

  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::screenRectOfContents):

LayoutTests:

  • fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html: Removed.
  • platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Removed.
  • platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Removed.
  • platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Removed.
  • platform/mac-lion/TestExpectations:
  • platform/mac-snowleopard/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win-wk2/TestExpectations:
  • platform/win-xp/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
4:15 PM Changeset in webkit [130823] by dmazzoni@google.com
  • 12 edits
    3 copies
    1 move
    2 deletes in trunk

AX: 5 accessibility tests just need minor tweaks to pass on chromium
https://bugs.webkit.org/show_bug.cgi?id=98311

Reviewed by Chris Fleizach.

Tools:

Update roleToString on Chromium to include all missing roles,
which enables some layout tests to pass.

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(roleToString):

LayoutTests:

Modifies tests so that they log data that tends to vary between
platforms using debug(), rather than asserting a platform-specific
value. Gets rid of "forks" of tests in the gtk directory. Adds
expectations and unskips 5 tests on Chromium.

  • accessibility/aria-list-and-listitem.html:
  • accessibility/aria-option-role.html:
  • accessibility/aria-tab-roles.html:
  • platform/chromium/TestExpectations:
  • platform/chromium/accessibility/aria-fallback-roles-expected.txt: Renamed from LayoutTests/platform/chromium-win/accessibility/aria-fallback-roles-expected.txt.
  • platform/chromium/accessibility/aria-list-and-listitem-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-list-and-listitem-expected.txt.
  • platform/chromium/accessibility/aria-option-role-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-option-role-expected.txt.
  • platform/chromium/accessibility/aria-tab-roles-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-tab-roles-expected.txt.
  • platform/gtk/accessibility/aria-list-and-listitem-expected.txt:
  • platform/gtk/accessibility/aria-list-and-listitem.html: Removed.
  • platform/gtk/accessibility/aria-option-role-expected.txt:
  • platform/gtk/accessibility/aria-option-role.html: Removed.
  • platform/mac/accessibility/aria-list-and-listitem-expected.txt:
  • platform/mac/accessibility/aria-option-role-expected.txt:
  • platform/mac/accessibility/aria-tab-roles-expected.txt:
3:45 PM Changeset in webkit [130822] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Rolling back unintended change to iframe-copy-on-scroll.html from previous commit.

  • compositing/iframes/iframe-copy-on-scroll.html:
3:31 PM Changeset in webkit [130821] by leviw@chromium.org
  • 4 edits
    3 adds in trunk/LayoutTests

Unreviewed gardening. Updating test expectations after r130811.

  • compositing/iframes/iframe-copy-on-scroll.html:
  • platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Added.
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Added.
  • platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Added.
  • platform/chromium/TestExpectations:
3:24 PM Changeset in webkit [130820] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r130812.
http://trac.webkit.org/changeset/130812
https://bugs.webkit.org/show_bug.cgi?id=98826

Caused fast/text/shaping/shaping-selection-rect to fail
(Requested by abarth|gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09

  • platform/graphics/Font.cpp:

(WebCore::Font::width):

  • platform/graphics/Font.h:

(Font):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::TextLayout::width):
(WebCore::Font::width):
(WebCore::ComplexTextController::advance):

  • platform/graphics/mac/ComplexTextController.h:

(ComplexTextController):

  • rendering/RenderBlock.h:

(WebCore):
(LineBreaker):
(RenderBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::createLineBoxesFromBidiRuns):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::textWidth):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

3:19 PM Changeset in webkit [130819] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkit-patch rebaseline-expectations doesn't work w/o failures specified
https://bugs.webkit.org/show_bug.cgi?id=98810

Reviewed by Ojan Vafai.

If you try to mark a test as foo.html [ Rebaseline ] it wasn't
getting picked up for rebaselining; we needed to think the test
was failing.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.get_rebaselining_failures):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(RebaseliningTest.test_get_rebaselining_failures):

3:19 PM Changeset in webkit [130818] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

DOM/textarea-edit.html spends 35% of time in numGraphemeClusters
https://bugs.webkit.org/show_bug.cgi?id=98711

Reviewed by Kent Tamura.

Since the number of characters is always greater than the number of grapheme clusters,
we can avoid calling computeLengthForSubmission when the number of characters is less
than maxlength. We still have to count the number of LFs since they all need to be
converted into CRLFs. This improves WebKit's score on DOM/textarea-edit.html by 45%.

  • html/HTMLTextAreaElement.cpp:

(WebCore::computeLengthForSubmission):
(WebCore::numberOfLineBreaks):
(WebCore::upperBoundForLengthForSubmission): Added.
(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
(WebCore::HTMLTextAreaElement::tooLong):

2:58 PM Changeset in webkit [130817] by Nate Chapin
  • 9 edits in trunk/Source/WebCore

Make CachedResourceLoader RefCounted and have both Document
and DocumentLoader hold RefPtrs. This is in preparation for
caching main resources.
https://bugs.webkit.org/show_bug.cgi?id=86787

Reviewed by Adam Barth.

No new tests, no functionality changes at this time.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::Document): Only create our own CachedResourceLoader

if we were given a null frame.

(WebCore::Document::~Document):
(WebCore::Document::cachedResourceLoader):
(WebCore):

  • dom/Document.h:

(Document):

  • loader/DocumentLoader.cpp: Throughout, use our m_cachedResourceLoader instead

of the Document's pointer.

(WebCore::DocumentLoader::DocumentLoader): Create a CachedResourceLoader.
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::subresource):
(WebCore::DocumentLoader::getSubresources):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::cachedResourceLoader):
(DocumentLoader):

  • loader/SubresourceLoader.cpp: Remove m_document, since it only existed to keep alive and access the CachedResourceLoader.

It can now be accessed from m_documentLoader.

(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::~SubresourceLoader):
(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::releaseResources):

  • loader/SubresourceLoader.h:

(SubresourceLoader):

  • loader/cache/CachedResourceLoader.cpp: Handle the possibility of a null Document in several places.

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::frame):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
(WebCore::CachedResourceLoader::loadDone):

  • loader/cache/CachedResourceLoader.h:

(WebCore):
(WebCore::CachedResourceLoader::create): Add create(), make constructor private.
(CachedResourceLoader):
(WebCore::CachedResourceLoader::document):
(WebCore::CachedResourceLoader::setDocument):
(WebCore::CachedResourceLoader::clearDocumentLoader):

2:53 PM Changeset in webkit [130816] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

CSS Style is not recalculated when media attribute of style element is changed
https://bugs.webkit.org/show_bug.cgi?id=96752

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-10-09
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

When "media" attribute of style element is changed, style should be recalculated.
This patch modifies HTMLStyleElement::parseAttribute, so that when the media attribute
is updated, new MediaQuerySet is created and applied to the style element then, document
style is recalculated. Since media query set is updated for CSSStyleSheet, CSSOM wrapper
for media query should be updated as well in order to sync with new media query set value.

Test: fast/media/mq-js-update-media.html

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::setMediaQueries):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseAttribute):

LayoutTests:

Added test to verify that when "media" attribute for style element is updated,
style is recalculated.

  • fast/media/mq-js-update-media.html: Added.
2:50 PM Changeset in webkit [130815] by benm@google.com
  • 5 edits in trunk/Source

[chromium][Android] Add WebSecurityOrigin::grantLoadLocalResources()
https://bugs.webkit.org/show_bug.cgi?id=97689

Reviewed by Adam Barth.

Source/WebCore:

In addition to the WebKit/chromium side of the change, remove the
ASSERT in SecurityOrigin::grantLoadLocalResources(). Android WebView
is a legitimate user of this API in cases where neither of the
ASSERT'd conditions hold.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::grantLoadLocalResources): Remove ASSERT.

Source/WebKit/chromium:

This change exposes the WebCore::SecurityOrigin::grantLoadLocalResources()
function to the Chromium WebKit API layer. This is needed in Chromium
to implement the Android WebView.loadDataWithBaseUrl function in a
compatible manner.

Please see crbug.com/152223 for further information and the chromium
side patch.

  • public/WebSecurityOrigin.h:

(WebSecurityOrigin): Add grantLoadLocalResources() API.

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::grantLoadLocalResources):

Implement the API by calling through to the WebCore function
of the same name.

(WebKit):

2:49 PM Changeset in webkit [130814] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for Qt Windows.

  • html/HTMLPlugInElement.h: Include Image.h.
2:35 PM Changeset in webkit [130813] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Chromium DEPS has a stray directory, turning our Win bots red
https://bugs.webkit.org/show_bug.cgi?id=98817

Reviewed by Dirk Pranke.

  • DEPS: Removed the stray directory which solved the redness on several of our bots.
2:35 PM Changeset in webkit [130812] by enrica@apple.com
  • 7 edits in trunk/Source/WebCore

Only measure text once instead of twice when performing line layout.
https://bugs.webkit.org/show_bug.cgi?id=98317
<rdar://problem/12080821>

Reviewed by Dan Bernstein.

Since we are measuring each word to find out where the line break should occur,
we should cache that information to avoid measuring the run again when
creating the line box. The bulk of the change is in nextLineBreak, where
the measurements are collected and placed in a vector so that they can
be consumed in setLogicalWidthForTextRun where we used to measure the
text one more time.
Each entry in the vector is a WordMeasurement object that contains information
about the start and end offset in the run, the renderer, the measured width
and, possibly, a list of fallback fonts.
When we need to compute the width of the run to create the line box, we add
all the measurements for the given renderer in the run to get the total width.

  • platform/graphics/Font.cpp:

(WebCore::Font::width): Added fallback fonts parameter.

  • platform/graphics/Font.h:

(Font): Added fallback fonts parameter to the width static member function.
This method is called when we compute the width using TextLayout.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::TextLayout::width): Added fallback fonts parameter.
(WebCore::Font::width):
(WebCore::ComplexTextController::advance):

  • platform/graphics/mac/ComplexTextController.h:

(ComplexTextController): Added fallback fonts parameter to advance method.

  • rendering/RenderBlock.h: Added WordMeasures parameter to few methods.
  • rendering/RenderBlockLineLayout.cpp:

(WordMeasurement): Added new class to hold measurement information.
(WebCore::setLogicalWidthForTextRun): This is where we compute the run width using the
cached information.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Added wordMeasures parameter.
(WebCore::RenderBlock::createLineBoxesFromBidiRuns): Added wordMeasures parameter.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Added declaration of the WordMeasures
vector and its use.
(WebCore::textWidth): Added fallbackFonts parameter, since now we only measure once.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): This method has been modified to collect
the measurements of the individual words and add them to the vector.

2:31 PM Changeset in webkit [130811] by leviw@chromium.org
  • 68 edits
    3 adds in trunk

[Sub pixel layout] Fast-path iframe scrolling can picks up an extra pixel
https://bugs.webkit.org/show_bug.cgi?id=98571

Reviewed by Emil A Eklund.

Source/WebCore:

Refactoring all coordinate-switching functionality to use a single "mode" flag
as opposed to having a bunch of boolean values. This enables the same set of
options across the board, and a consistent interface. This was previously
done for mapLocalToContainer.

The imptetus for this for this stems from the one logical change in this patch
which only effects sub-pixel layout. FrameView::convertToRenderer and
convertFromRenderer return IntPoint coordinates, and need to also snap transform
offsets to determine proper rects for scrolling.

Unlabeled functions below are simply being updated to these new interfaces.

Test: fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html

  • WebCore.exp.in:
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getUpperLeftCorner):
(WebCore::ContainerNode::getLowerRightCorner):

  • dom/Element.cpp:

(WebCore::Element::boundsInRootViewSpace):

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::computeRelativePosition):

  • dom/Node.cpp:

(WebCore::Node::convertToPage):
(WebCore::Node::convertFromPage):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::defaultEventHandler):

  • page/FrameView.cpp:

(WebCore::FrameView::convertToRenderer): Now pixel-snaps offsets before passing
them to TransformState, which transforms the coordinates.
(WebCore::FrameView::convertFromRenderer): Ditto.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::absoluteQuads):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::absoluteQuads):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::mapAbsoluteToLocalPoint):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::userResize):

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::absolutePoint):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::absoluteToContents):
(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::localToAbsolute):
(WebCore::RenderObject::absoluteToLocal):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::mapAbsoluteToLocalPoint):
(WebCore::RenderObject::localToContainerQuad):
(WebCore::RenderObject::localToContainerPoint):

  • rendering/RenderObject.h:

(RenderObject): MapLocalToContainerFlags is now MapCoordinatesFlags since it's
now used for other conversion methods.
(WebCore::RenderObject::localToAbsoluteQuad):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):

  • rendering/RenderView.cpp:

(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):

  • rendering/RenderView.h:

(RenderView):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::mapLocalToContainer):

  • rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::mapLocalToContainer):

  • rendering/svg/RenderSVGInline.h:

(RenderSVGInline):

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::mapLocalToContainer):

  • rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::mapLocalToContainer):

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::mapLocalToContainer):

  • rendering/svg/RenderSVGText.h:

(RenderSVGText):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform):

LayoutTests:

Tests scrolling of sub-pixel layers on sub-pixel platforms (Chromium).

  • fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html: Added.
  • platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Added.
  • platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:

The repaint rect shrinks safely by one pixel.

  • platform/chromium/TestExpectations:
  • platform/mac-lion/TestExpectations:
  • platform/mac-snowleopard/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win-wk2/TestExpectations:
  • platform/win-xp/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
2:23 PM Changeset in webkit [130810] by jonlee@apple.com
  • 9 edits in trunk/Source

[WK2] Have plugins render offscreen to capture snapshot
https://bugs.webkit.org/show_bug.cgi?id=98326
<rdar://problem/12426658>

Reviewed by Simon Fraser.

Source/WebCore:

Change updateSnapshot() to use a PassRefPtr<Image> instead of Image*. WebKit2 ultimately
hands the image off to RenderSnapshottedPlugin. A CachedImage instance then manages the
lifetime of the Image.

  • html/HTMLPlugInElement.h:

(WebCore::HTMLPlugInElement::updateSnapshot):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshot):

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Updated to use the PassRefPtr<Image>
pointer.

  • rendering/RenderSnapshottedPlugIn.h:

(RenderSnapshottedPlugIn):

Source/WebKit2:

Keep the plugin rendering without compositing to easily grab the snapshot.

PluginView now has two variables referring to snapshots, but are unrelated. The timer
is used to capture a snapshot that acts as a poster for a plugin. The ShareableBitmap
variable m_snapshot is used whenever the plugin paints in software, to avoid side effects
should the plugin run JS during painting.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit): Add a named constant for the time delay before a snapshot is taken.
(WebKit::PluginView::PluginView): Initialize a 3-second timer to get the snapshot.
(WebKit::PluginView::~PluginView): Refactor part of the destructor code out into
destroyPluginAndReset() for reuse.
(WebKit::PluginView::destroyPluginAndReset): Contains part of the destructor code.
In addition to destroying the plugin, the destructor cancels pending loads and streams.
(WebKit::PluginView::didInitializePlugin): If the plugin is in a state where it needs
to generate or display a poster, don't setup the compositing layer and start the timer.
(WebKit::PluginView::paint): Avoid painting if the plugin is not running.
(WebKit::PluginView::invalidateRect): Avoid painting if the plugin is not running.
(WebKit::PluginView::isAcceleratedCompositingEnabled): Don't enable accelerated compositing
until the plugin is running.
(WebKit::PluginView::pluginSnapshotTimerFired): When the timer fires, get a snapshot, generate
an Image that WebCore can render, and destroy the plugin.

Rename m_snapshot to m_transientPaintingSnapshot.

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::paint):
(WebKit::PluginView::notifyWidget):
(WebKit::PluginView::pluginSnapshotTimerFired):

2:20 PM Changeset in webkit [130809] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

These tests also fail with ImageOnlyFailures.

  • platform/chromium/TestExpectations:
2:17 PM Changeset in webkit [130808] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This test now appears to fail on the bots because
http://trac.webkit.org/changeset/130799 removed the ImageOnlyFailure
attribute.

  • platform/chromium/TestExpectations:
2:09 PM Changeset in webkit [130807] by abarth@webkit.org
  • 1 edit
    1 move in trunk/Source/WebCore

Unreviewed. Move this file to where the build systems think it should
be. See https://bugs.webkit.org/show_bug.cgi?id=94755

  • platform/graphics/CustomFilterConstants.h: Removed.
  • platform/graphics/filters/CustomFilterConstants.h: Copied from Source/WebCore/platform/graphics/CustomFilterConstants.h.
1:38 PM Changeset in webkit [130806] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Use computeLogical* methods instead of updateLogical* methods in RenderImage
https://bugs.webkit.org/show_bug.cgi?id=98802

Reviewed by Eric Seidel.

We were storing the old values of width/height, calling updateLogical{Width,Height}, then restoring
the old values. Instead, use the computeLogical{Width,Height} methods so we don't have to overwrite
the current values.

No new tests, this is just a refactoring.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageDimensionsChanged):

1:36 PM Changeset in webkit [130805] by dbates@webkit.org
  • 7 edits in trunk/Tools

VCSUtils.pm doesn't support SVN 1.7 diff files
<https://bugs.webkit.org/show_bug.cgi?id=80762>

Reviewed by Eric Seidel.

Implement support for the SVN 1.7 diff format.

  • Scripts/VCSUtils.pm:

(parseChunkRange): Modified to support parsing an SVN 1.7 chunk range
that begins and ends with "##" (e.g. ## -0,0 +1,7 ##). For comparison,
earlier versions of SVN parsed chunk ranges of the form "@@ -0,0 +1,7 @@".

(parseSvnDiffHeader): Modified to parse an SVN 1.7 binary diff; SVN 1.7
has an unusual display format for a binary diff. It repeats the first
two lines of the diff header.

(parseSvnProperty): Modified to ignore both an SVN 1.7 chunk range and
lines of the form "\ No newline at end of property". SVN 1.7 emits the latter
message after a property value that doesn't end in a newline.

(parseSvnPropertyValue): Stop parsing an SVN property value when we encounter
a line of the form "\ No newline at end of property" (emitted by svn diff as of
SVN 1.7).

  • Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
    • Added the following unit tests: "Line count is 0" "New line count is 1"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
    • Added the following unit tests: "svn:executable followed by custom property using SVN 1.7 syntax" "svn:executable followed by custom property without newline using SVN 1.7 syntax"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
    • Updated test results for test "binary file".
    • Added unit test "binary file using SVN 1.7 syntax".
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
    • Added the following unit tests: "simple: add svn:executable using SVN 1.7 syntax" "simple: delete svn:executable using SVN 1.7 syntax" "add svn:mime-type and add svn:executable using SVN 1.7 syntax"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
    • Added the following unit tests: "singe-line '+' change using SVN 1.7 syntax" "single-line '-' change using SVN 1.7 syntax"
1:35 PM Changeset in webkit [130804] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Cleanup FatFingers.cpp
https://bugs.webkit.org/show_bug.cgi?id=98806

Reviewed by Antonio Gomes.

Cleanup namespace usage and sync up FatFingers.cpp.

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::compareDistanceBetweenPoints):
(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::checkFingerIntersection):
(BlackBerry::WebKit::FatFingers::findIntersectingRegions):
(BlackBerry::WebKit::FatFingers::checkForClickableElement):
(BlackBerry::WebKit::FatFingers::checkForText):
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
(BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):

1:28 PM Changeset in webkit [130803] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

[chromium] fast/text/international/text-spliced-font.html and fast/writing-mode/Kusa-Makura-
background-canvas.html failing on the Mac after r130443
https://bugs.webkit.org/show_bug.cgi?id=98545

Reviewed by Tony Chang.

Adding back the ! removed by mistake before submitting r130779.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataAndPageForCharacter):

1:28 PM Changeset in webkit [130802] by jamesr@google.com
  • 2 edits in trunk/Tools

Unreviewed, rolling out r128488.
http://trac.webkit.org/changeset/128488
https://bugs.webkit.org/show_bug.cgi?id=96678

The bot is fixed now

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

(.):

1:12 PM Changeset in webkit [130801] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] EGL Context deleted prematurely in GraphicsContext3D destructor
https://bugs.webkit.org/show_bug.cgi?id=98796

Patch by Artem Simonov <asimonov@rim.com> on 2012-10-09
Reviewed by George Staikos.

Reordered destruction of GraphicsContext3D so that the compositing layer is
destroyed first.

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):

1:06 PM Changeset in webkit [130800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Disable hinting when webkit-font-smoothing:antialiased is used on Mac.
https://bugs.webkit.org/show_bug.cgi?id=98061

Patch by Ben Wagner <bungeman@chromium.org> on 2012-10-09
Reviewed by Stephen White.

Normal anti-aliased text matches subpixel anti-aliased text.
However, text marked with webkit-font-smoothing:antialiased should be drawn without hinting to match Safari.
See crbug.com/152304 .

Test is fast/css/font-smoothing.html, but DRT runs with font smoothing disabled, so no change visible.

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::setupPaint):
Set kNo_Hinting when webkit-font-smoothing is antialiased.

1:06 PM Changeset in webkit [130799] by peter@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] More TestExpectation updates for Android
https://bugs.webkit.org/show_bug.cgi?id=98818

Unreviewed test expectation updates.

List more failures (all with bugs assigned) in the TestExpectation file for
Android. Move an older block around, considering we may want to re-triage it.

  • platform/chromium/TestExpectations:
12:55 PM Changeset in webkit [130798] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

  • platform/chromium/TestExpectations:

Removed this entry: there was no need for new baselines.

12:48 PM Changeset in webkit [130797] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source/WebCore

[CSS Shaders] Create constants for vertex attribute sizes and offsets
https://bugs.webkit.org/show_bug.cgi?id=94755

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-09
Reviewed by Dean Jackson.

Factor out the vertex attribute size and offset constants into a new file,
CustomFilterConstants.h. Replace literals in CustomFilterMeshGenerator with the constants.

I could have added the constants to CustomFilterMeshGenerator.h, but this would make
FECustomFilter depend on CustomFilterMeshGenerator.

I also could have added the constants to CustomFilterMesh.h, but this would make
CustomFilterMeshGenerator depend on CustomFilterMesh.

No new tests. No change in behavior.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/CustomFilterConstants.h: Added.

(WebCore):

  • platform/graphics/filters/CustomFilterMeshGenerator.h:

(WebCore::CustomFilterMeshGenerator::floatsPerVertex):

Use the new constants instead of literal values.

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::bindProgramAndBuffers):

Pull the constant definitions out of here.

12:44 PM Changeset in webkit [130796] by abarth@webkit.org
  • 11 edits in trunk/LayoutTests

dfg-cross-global tests are flaky because they misuse js-test-pre.js
https://bugs.webkit.org/show_bug.cgi?id=98813

Reviewed by Daniel Bates.

These tests have a race between js-test-pre's "done" message and the
timeout. This patch change then to use jsTestIsAsync and finishJSTest()
appropriately.

  • fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal-with-variables.js:
  • fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal.js:
  • fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-elements.js:
  • fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-size.js:
  • fast/js/script-tests/dfg-cross-global-object-inline-new-array.js:
12:26 PM Changeset in webkit [130795] by msaboff@apple.com
  • 4 edits in trunk/Source/WebCore

MarkupAccumulator should optimally handle 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=98224

Reviewed by Ryosuke Niwa.

Updated appendCharactersReplacingEntities to take a string, offset and length and process 8 or 16 bit
data as appropriate. Also made it a member function of MarkupAccumulator.

No new tests, behavior covered by existing tests.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendCharactersReplacingEntities):
(WebCore::MarkupAccumulator::appendAttributeValue):
(WebCore::MarkupAccumulator::appendNodeValue):

  • editing/MarkupAccumulator.h:

(MarkupAccumulator):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendText):
(WebCore::urlToMarkup):

12:25 PM Changeset in webkit [130794] by jsbell@chromium.org
  • 5 edits in trunk

IndexedDB: Overflowing key generator should throw ConstraintError
https://bugs.webkit.org/show_bug.cgi?id=98807

Reviewed by Tony Chang.

Source/WebCore:

After the WebKit implementation landed throwing DataError, public-webapps
consensus was that the exception thrown should be ConstraintError. Trivial
change, and we pass one more W3C test submission.

Test: storage/indexeddb/key-generator.html

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):

LayoutTests:

Verify that overflowing key generator throws ConstraintError.

  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/resources/key-generator.js:
12:23 PM Changeset in webkit [130793] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Don't run perf/mouse-event on debug builds

Unreviewed, expectations change.

We don't normally run any perf tests on a debug build, but this
one was getting run due to an improperly scoped expectation
overriding the wontfix rule.

  • platform/chromium/TestExpectations:
12:23 PM Changeset in webkit [130792] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

XvfbDriver unit test is flaky on Linux builders
https://bugs.webkit.org/show_bug.cgi?id=98346

Reviewed by Adam Barth.

Temporarily skip the XvfbDriver test case that tests
the display number of the next free display. The test
is flaky on Linux builders.

  • Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:

(XvfbDriverTest.disabled_test_next_free_display):

12:18 PM Changeset in webkit [130791] by dgrogan@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

IndexedDB: open-in-upgradeneeded layout test
https://bugs.webkit.org/show_bug.cgi?id=95912

Reviewed by Tony Chang.

  • storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt: Added.
  • storage/indexeddb/intversion-open-in-upgradeneeded.html: Added.
  • storage/indexeddb/resources/intversion-open-in-upgradeneeded.js: Added.

(test):
(deleteSuccess):
(upgradeNeeded1.transaction.oncomplete):
(upgradeNeeded1):
(openSuccess1):
(onVersionChange):
(onBlocked):
(upgradeNeeded2):
(openSuccess2):

12:16 PM Changeset in webkit [130790] by ojan@chromium.org
  • 3 edits in trunk/Tools

Don't duplicated build numbers when merging flakiness dashboard JSON
https://bugs.webkit.org/show_bug.cgi?id=98812

Reviewed by Dirk Pranke.

In general, build numbers are not unique, but we should basically never
get the same build number uploaded twice in a row. This is a workaround
for https://bugs.webkit.org/show_bug.cgi?id=97643, which frequently hits this
because we update results_small.json and timeout updating results.json and then
we retry the whole request.

  • TestResultServer/model/jsonresults.py:

(JsonResults.merge):

  • TestResultServer/model/jsonresults_unittest.py:

(JsonResultsTest.test_merge_duplicate_build_number):

12:16 PM Changeset in webkit [130789] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the order of the statements in my previous build fix.

Reviewed by Gustavo Noronha Silva.

My previous build build fix for ResourceHandleSoup ordered the assignment
of the local ResourceHandleInternal incorrectly. Instead of being before
both assertions, it should be interspersed among them.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::createSoupMessageForHandleAndRequest):

12:14 PM Changeset in webkit [130788] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Need implement isWordTextBreak for QT, and WinCE for visual word movement functionality
https://bugs.webkit.org/show_bug.cgi?id=81136

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Caio Marcelo de Oliveira Filho.

Uskipping tests that are passing after the merge https://gitorious.org/qtwebkit/testfonts/merge_requests/1

  • platform/qt/TestExpectations:
12:08 PM Changeset in webkit [130787] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

RTL: selection.modify("move", "forward", "line") when cursor is at start of a line does not move down a line
https://bugs.webkit.org/show_bug.cgi?id=51517

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Caio Marcelo de Oliveira Filho.

Unskipping a test that is passing, with testfonts change in https://gitorious.org/qtwebkit/testfonts/merge_requests/1

  • platform/qt/TestExpectations:
12:06 PM Changeset in webkit [130786] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note that this test is flaky.

  • platform/chromium/TestExpectations:
11:59 AM Changeset in webkit [130785] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Revert change to TestExpectations in http://trac.webkit.org/changeset/130779.
These tests still give the wrong results.

  • platform/chromium/TestExpectations:
11:56 AM Changeset in webkit [130784] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

  • platform/chromium/TestExpectations:

Fix new-run-webkit-tests --lint-test-files after r130778.

11:47 AM Changeset in webkit [130783] by Beth Dakin
  • 17 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=98457
ScrollingStateNodes should be referenced via IDs on
RenderLayerBacking

Reviewed by Simon Fraser.

This patch associates all ScrollingStateNodes with a
RenderLayerBacking via a HashMap from RenderLayerBackings to
ScrollingStateNodes on ScrollingCoordinator. Prior to this patch, the
root ScrollingStateNode was created immediately upon creation of the
ScrollingCoordinator, and it was constantly re-used for every main
FrameView. This doesn't work in the new model since that doesn't
allow that ScrollingStateNode to have a definite association with a
RenderLayerBacking. So this patch does also introduce some lifetime
differences with the ScrollingStateNodes.

If a page is going into the page cache, we should clear the state
tree. When the page is in the cache, we won't have access to the
RenderLayerBacking, and we don't want to be doing anything with the
ScrollingStateNodes anyway.

  • dom/Document.cpp:

(WebCore::Document::setInPageCache):

When a page is restored from the page cache, call
frameViewRootLayerDidChange() to re-create the state tree.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

This new FrameView function will return the scrollLayerID for a given FrameView.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollLayerID):
(WebCore):

  • page/FrameView.h:

(FrameView):

There is a lot of unfortunate fiddling with the terrible
if-defs in ScrollingCoordinator. I added a FIXME to the header
noting how we can avoid this in the future.

  • page/scrolling/ScrollingCoordinator.cpp:

All of this code used to refer to the rootStateNode directly.
Instead, now it looks up the proper ScrollingStateNode for the given
FrameView in the HashMap.
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::ScrollingCoordinator::updateMainFrameScrollLayerPosition):
(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):
(WebCore::ScrollingCoordinator::setScrollLayerForNode):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegionForNode):
(WebCore::ScrollingCoordinator::setScrollParametersForNode):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCountForNode):

Returns the existing ScrollingStateNode for a given FrameView by
looking it up in the HashMap.
(WebCore::ScrollingCoordinator::stateNodeForFrameView):

This is called when a RenderLayerBacking is destroyed. At that time,
its associated ScrollingStateNode is destroyed.
(WebCore::ScrollingCoordinator::detachFromStateTree):

clearStateTree() clears the HashMap and destroys all of the nodes in
the current state tree.
(WebCore::ScrollingCoordinator::clearStateTree):

Creates a new root state node for the given FrameView.
(WebCore::ScrollingCoordinator::ensureRootStateNodeForFrameView):

Some new functions for the new node stuff.

  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::supportsFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinator::detachFromStateTree):
(WebCore::ScrollingCoordinator::clearStateTree):
(WebCore::ScrollingCoordinator::ensureRootStateNodeForFrameView):
(WebCore::setScrollParameters):
(WebCore::setWheelEventHandlerCount):

New remove functions are used when the sate tree is cleared and when
a RenderLayerBacking is destroyed.

  • page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::removeChild):
(WebCore):

  • page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::isScrollingStateScrollingNode):
(ScrollingStateNode):
(WebCore::ScrollingStateNode::parent):

New convenience function for casting to ScrollingStateScrollingNodes.

  • page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::toScrollingStateScrollingNode):
(WebCore):

No longer automatically create a root node upon creation of the
ScrollingStateTree. We now want to wait to create the root node until
we have a RenderLayerBacking to associate it with.

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::ScrollingStateTree):
(WebCore::ScrollingStateTree::removeNode):
(WebCore):

  • page/scrolling/ScrollingStateTree.h:

(WebCore::ScrollingStateTree::setRootStateNode):
(ScrollingStateTree):

RenderLayerBacking has a new data member called m_scrollLayerID. If
this RenderLayerBacking is represented in the scrolling tree, then
the ID with be unique and non-zero.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::generateScrollLayerID):
(WebCore):
(WebCore::RenderLayerBacking::attachToScrollingCoordinator):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):
(WebCore::RenderLayerBacking::scrollLayerID):

Move the call to ScrollingCooridinator::frameViewRootLayerDidChange()
from RenderLayerCompositor::attachRootLayer() to
RenderLayerCompositor:: updateBacking(). The problem with the old call
site is that there is no backing at that time, so we are trying to set
state on the root scrolling state node before we have enough
information to create that node and add it to the HashMap.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::attachRootLayer):

11:37 AM Changeset in webkit [130782] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] modify-up-on-rtl-wrapping-text.html fails on DRT
https://bugs.webkit.org/show_bug.cgi?id=50291

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Csaba Osztrogonác.

Unskipping editing/selection/modify-up-on-rtl-wrapping-text.html

  • platform/qt/TestExpectations:
11:37 AM Changeset in webkit [130781] by alexis@webkit.org
  • 2 edits in trunk/Tools

[GTK] Shadow builds are not working anymore.
https://bugs.webkit.org/show_bug.cgi?id=98785

Reviewed by Martin Robinson.

When setting WEBKITOUTPUTDIR the build was failing with a python
error : the os.execve expect three arguments. Also the condition
to check whether we build the GTK port with jhbuild or not was buggy
as it was always assuming an in source build. We can use now jhbuildutils
which has a convenient function to locate the directory where
the dependencies built with jhbuild are and take into account WEBKITOUTPUTDIR.
If the Dependencies path does not exist then the build was not done using
jhbuild so we can fallback to a regular build against system libraries.

  • gtk/run-with-jhbuild:
11:36 AM Changeset in webkit [130780] by fmalita@chromium.org
  • 2 edits in trunk/Source/WebCore

SVGResources should use HashSet<AtomicString> instead of HashSet<AtomicStringImpl*>
https://bugs.webkit.org/show_bug.cgi?id=98683

Reviewed by Darin Adler.

Eric's notes:

SVGResources should use HashSet<AtomicString> instead of HashSet<AtomicStringImpl*>
They do basically the same thing, and the former is much more common (and less code). It's
also safe, on the off-chance that we're using AtomicStrings which might otherwise go away.

No new tests, refactoring.

  • rendering/svg/SVGResources.cpp:

(WebCore::clipperFilterMaskerTags):
(WebCore::markerTags):
(WebCore::fillAndStrokeTags):
(WebCore::chainableResourceTags):
(WebCore::SVGResources::buildCachedResources):

11:09 AM Changeset in webkit [130779] by enrica@apple.com
  • 6 edits
    1 add in trunk

[chromium] fast/text/international/text-spliced-font.html and fast/writing-mode/Kusa-Makura-background-canvas.html
failing on the Mac after r130443
https://bugs.webkit.org/show_bug.cgi?id=98545

Reviewed by Tony Chang.

Source/WebCore:

Fixes a regression introduced with r130443.
No new tests added since we already have tests covering this.
Updated TestExpectations for chromium and mac.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataAndPageForCharacter): Text orientation should not be
taken into account if the character is an ideograph or a symbol.

LayoutTests:

Updated TextExpectations for Chromium and Mac.
Moved existing expected results from mac to mac-lion and added new results for Mountain Lion.

  • platform/chromium/TestExpectations:
  • platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
11:06 AM Changeset in webkit [130778] by reed@google.com
  • 2 edits in trunk/LayoutTests

Update expectations in preparation for enabling float-src-rect behavior in SkCanvas::drawBitmapRect
https://bugs.webkit.org/show_bug.cgi?id=98795

Reviewed by NOBODY.

Expectations change only.

  • platform/chromium/TestExpectations:
10:49 AM Changeset in webkit [130777] by pdr@google.com
  • 13 edits
    5 adds in trunk

Prevent animation when CSS attributeType is invalid.
https://bugs.webkit.org/show_bug.cgi?id=94569

Reviewed by Dirk Schulze.

Source/WebCore:

This patch changes hasValidAttributeType() to return false when
we have attributeType=CSS with a non-CSS attribute name.

Previously we would animate non-CSS attributes when attributeType was
CSS which resulted in crashes. To track this case, this patch catches
changes to targetElement, attributeName, and attributeType and checks
if an invalid combination is present. If invalid, hasInvalidCSSAttributeType()
will return true causing hasValidAttributeType() to return false and prevent
the animation from running.

Tests: svg/animations/animate-css-xml-attributeType.html

svg/animations/invalid-css-attribute-crash-expected.svg
svg/animations/invalid-css-attribute-crash.svg

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::hasValidAttributeType):
(WebCore::SVGAnimateElement::targetElementWillChange):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::SVGAnimationElement):
(WebCore::SVGAnimationElement::isSupportedAttribute):

This now supports the attributeType attribute which is stored in m_attributeType.

(WebCore::SVGAnimationElement::parseAttribute):
(WebCore::SVGAnimationElement::setAttributeType):

Changes to attributeType, attributeName, and targetElement need to be tracked
to determine when an invalid combination happens.

(WebCore::SVGAnimationElement::targetElementWillChange):
(WebCore):
(WebCore::SVGAnimationElement::setAttributeName):
(WebCore::SVGAnimationElement::checkInvalidCSSAttributeType):

  • svg/SVGAnimationElement.h:

(WebCore::SVGAnimationElement::attributeType):
(SVGAnimationElement):
(WebCore::SVGAnimationElement::hasInvalidCSSAttributeType):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::targetElement):

  • svg/animation/SVGSMILElement.h:

(SVGSMILElement):

LayoutTests:

Adding a test to prove this patch works (invalid-css-attribute-crash.svg)
and an additional test to show that switching between XML and CSS
attributeTypes works as expected (animate-css-xml-attributeType.html).

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • svg/animations/animate-css-xml-attributeType-expected.txt: Added.
  • svg/animations/animate-css-xml-attributeType.html: Added.
  • svg/animations/invalid-css-attribute-crash-expected.svg: Added.
  • svg/animations/invalid-css-attribute-crash.svg: Added.
  • svg/animations/script-tests/animate-css-xml-attributeType.js: Added.

(sample1):
(sample6):
(executeTest):

10:17 AM Changeset in webkit [130776] by Simon Fraser
  • 19 edits in trunk

Remove DRT/WTR implementations of layerTreeAsText
https://bugs.webkit.org/show_bug.cgi?id=98697

Reviewed by Tim Horton, James Robinson, Alexey Proskuryakov.

Tools:

Remove code related to layerTreeAsText(), which is now on window.internals.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Fix a couple of tests missed in the previous chnage.

  • compositing/geometry/preserve-3d-switching.html:
  • compositing/visibility/visibility-image-layers-dynamic.html:
9:59 AM Changeset in webkit [130775] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebKit2

Add missing compile flag for compositing
https://bugs.webkit.org/show_bug.cgi?id=98681

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-10-09
Reviewed by Dirk Schulze.

This flag is needed in case there is a difference in API
when compositing is enabled

  • Configurations/FeatureDefines.xcconfig:
9:55 AM Changeset in webkit [130774] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

max-width property is does not overriding the width properties for css tables(display:table)
https://bugs.webkit.org/show_bug.cgi?id=98455

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-10-09
Reviewed by Tony Chang.

Source/WebCore:

The max-width property determines the maximum computed width an element can have. In case of css tables(display:table),
the computed was not being limited by the max-width property. The current patch fixes this issue.

Test: fast/table/css-table-max-width.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::updateLogicalWidth):

Logic to compute the logical width of an element such that it does not exceed the max-width value.
Also when both min-width and max-width are present, the following contraint is used to compute the logical width:

1) min-width < Computed LogicalWidth < max-width, when min-width < max-width.
2) Computed LogicalWidth = min-width, when min-width > max-width.

LayoutTests:

  • fast/table/css-table-max-width-expected.txt: Added.
  • fast/table/css-table-max-width.html: Added.
9:50 AM Changeset in webkit [130773] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Expanding failure expectation for editing/pasteboard/drag-drop-list.html to
again include debug configurations as well.

  • platform/gtk/TestExpectations:
9:25 AM Changeset in webkit [130772] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r130680.
http://trac.webkit.org/changeset/130680
https://bugs.webkit.org/show_bug.cgi?id=98720

this patch has a typo so was ineffective (Requested by
cabanier on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09

  • Configurations/FeatureDefines.xcconfig:
9:21 AM Changeset in webkit [130771] by peter@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Test expectation updates for Android
https://bugs.webkit.org/show_bug.cgi?id=98786

Unreviewed test expectation update.

Update the test expectations for Android. Nineteen bugs were filed,
which are all blocking bug 96398.

  • platform/chromium-android/TestExpectations:
  • platform/chromium/TestExpectations:
9:03 AM Changeset in webkit [130770] by zoltan@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Remove myself from QtWebKit2 subscriptions.

  • Scripts/webkitpy/common/config/watchlist:
8:57 AM Changeset in webkit [130769] by rakuco@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
8:56 AM Changeset in webkit [130768] by commit-queue@webkit.org
  • 15 edits in trunk

Source/Platform: Change PeerConnection getStats function to single value local / remote
elements in RTCStatsReport.
https://bugs.webkit.org/show_bug.cgi?id=98753

Patch by Harald Alvestrand <hta@google.com> on 2012-10-09
Reviewed by Adam Barth.

  • chromium/public/WebRTCStatsResponse.h:

(WebRTCStatsResponse):

Source/WebCore: Change PeerConnection getStats function to single value local / remote
elements in RTCStatsReport.

https://bugs.webkit.org/show_bug.cgi?id=98753

Patch by Harald Alvestrand <hta@google.com> on 2012-10-09
Reviewed by Adam Barth.

IDL of RTCStatsReport has been changed to make local/remote
single valued RTCStatsElement attributes.
The RTCStatsReport argument to index the list of RTCStatsElement
in the local and remote functions has been removed.

Tested by modifications to RTCPeerConnection-stats.html

  • Modules/mediastream/RTCStatsReport.cpp:

(WebCore::RTCStatsReport::addElement):
(WebCore::RTCStatsReport::addStatistic):

  • Modules/mediastream/RTCStatsReport.h:

(WebCore::RTCStatsReport::local):
(WebCore::RTCStatsReport::remote):
(RTCStatsReport):

  • Modules/mediastream/RTCStatsReport.idl:
  • Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::addElement):
(WebCore::RTCStatsResponse::addStatistic):

  • Modules/mediastream/RTCStatsResponse.h:

(RTCStatsResponse):

  • platform/chromium/support/WebRTCStatsResponse.cpp:

(WebKit::WebRTCStatsResponse::addElement):
(WebKit::WebRTCStatsResponse::addStatistic):

  • platform/mediastream/RTCStatsResponseBase.h:

(RTCStatsResponseBase):

Tools: Change PeerConnection getStats function to single value local / remote
elements in RTCStatsReport.
https://bugs.webkit.org/show_bug.cgi?id=98753

Patch by Harald Alvestrand <hta@google.com> on 2012-10-09
Reviewed by Adam Barth.

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::getStats):

LayoutTests: Change PeerConnection getStats function to single value local / remote
elements in RTCStatsReport.
https://bugs.webkit.org/show_bug.cgi?id=98753

Patch by Harald Alvestrand <hta@google.com> on 2012-10-09
Reviewed by Adam Barth.

  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
8:54 AM Changeset in webkit [130767] by abarth@webkit.org
  • 3 edits
    3 adds in trunk/LayoutTests

Unreviewed. Add chromium-mac specific results for these tests. They
differ from the expected results only in text rendering.

  • platform/chromium-mac-snowleopard/fast/text/hyphenate-character-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/hyphens-expected.png:
  • platform/chromium-mac/fast/text/hyphenate-character-expected.png: Added.
  • platform/chromium-mac/fast/text/hyphenate-limit-before-after-expected.png: Added.
  • platform/chromium-mac/fast/text/hyphens-expected.png: Added.
8:33 AM Changeset in webkit [130766] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark svg/text/selection-tripleclick.svg as flaky on WK2.

  • platform/efl-wk2/TestExpectations:
8:13 AM Changeset in webkit [130765] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[chromium] Make sure events are transformed correctly for plugins.
https://bugs.webkit.org/show_bug.cgi?id=89250

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-09
Reviewed by Tony Chang.

Source/WebKit/chromium:

The events arriving in WebPluginContainerImpl are in the coordinate
space of the page containing the plugin. Before the events are
dispatched to the plugin, it is necessary to convert them into the
plugin's own coordinate system.

  • src/WebInputEventConversion.cpp:

(WebKit::convertLocationForRenderObject): Transforms an event location for the specified RenderObject.
(WebKit):
(WebKit::updateWebMouseEventFromWebCoreMouseEvent): Refactored code to reduce code-duplication for mouse and wheel events.
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

  • src/WebInputEventConversion.h:

(WebCore):
(WebKit):
(WebMouseEventBuilder):
(WebMouseWheelEventBuilder):
(WebTouchEventBuilder):
(WebGestureEventBuilder):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleMouseEvent):
(WebKit::WebPluginContainerImpl::handleWheelEvent):

Tools:

Update the test plugin to print event details for mouse and gesture events.

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(printEventDetails):

LayoutTests:

Added tests to make sure that events are transformed properly. Note that
for touch-events, each point in the three touch-point lists in the
touch-event is printed, so the same touch-point is printed out three
times.

  • platform/chromium/plugins/transformed-events-expected.txt: Added.
  • platform/chromium/plugins/transformed-events.html: Added.
8:06 AM WebKit Team edited by zoltan@webkit.org
(diff)
8:03 AM Changeset in webkit [130764] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Inform the PageProxy about visibility changes when the view is shown/hidden.
https://bugs.webkit.org/show_bug.cgi?id=98757

Reviewed by Kenneth Rohde Christiansen.

SVN r130720 exposed a bug in our code: the PageProxy is not
notified when one calls evas_object_show() or evas_object_hide()
on the view, so the visibility it has when the WebPageProxy is
constructed remained set forever.

This made the ewk_context_vibration_client_callbacks_set unit test
start running forever, because WebPageProxy's constructor now sets
the page's visibility to hidden by the default for us, since it is
called from within ewk_view_smart_add() and before
evas_object_show().

We now listen to the EVAS_CALLBACK_SHOW and EVAS_CALLBACK_HIDE
callbacks and update the WebPageProxy accordingly. Note that we
could not do this from the smart_show and smart_hide functions we
already had, since they are called before the object's actual
visibility is updated.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_on_show):
(_ewk_view_on_hide):
(_ewk_view_smart_add):

8:00 AM Changeset in webkit [130763] by tonikitoo@webkit.org
  • 4 edits in trunk/Source

Get rid of FIXED_POSITION_CREATES_STACKING_CONTEXT in favor of Settings::fixedPositionCreatesStackingContext()
https://bugs.webkit.org/show_bug.cgi?id=98756

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

Source/WebCore:

No behavior change so no new tests.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

7:48 AM Changeset in webkit [130762] by msaboff@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Corrected reviewer that webkit-patch got wrong.

7:46 AM Changeset in webkit [130761] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

After r130344, OpaqueJSString::identifier() adds wrapped String to identifier table
https://bugs.webkit.org/show_bug.cgi?id=98693
REGRESSION (r130344): Install failed in Install Environment
<rdar://problem/12450118>

Reviewed by Filip Pizlo.

Use Identifier(LChar*, length) or Identifier(UChar*, length) constructors so that we don't
add the String instance in the OpaqueJSString to any identifier tables.

  • API/OpaqueJSString.cpp:

(OpaqueJSString::identifier):

7:15 AM Changeset in webkit [130760] by Simon Hausmann
  • 2 edits in trunk/Tools

Unreviewed trivial Qt build fix: Remove stray closing braces from r130758.

  • qmake/mkspecs/features/features.prf:
7:03 AM Changeset in webkit [130759] by Simon Hausmann
  • 6 edits in trunk/Source

[Qt] Fix build with QtMultimedia

Reviewed by Tor Arne Vestbø.

Source/WebCore:

This is an initial rudimentary port to of the QtMultimedia back-end,
adapted to slight API changes and (more importantly) to the
implementation of QAbstractVideoSurface instead of using
QGraphicsVideoItem (which is in QtMultimediaWidgets).

  • WebCore.pri:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::supportsType):
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::~MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::didLoadingProgress):
(WebCore::MediaPlayerPrivateQt::totalBytes):
(WebCore::MediaPlayerPrivateQt::setVisible):
(WebCore::MediaPlayerPrivateQt::surfaceFormatChanged):
(WebCore::MediaPlayerPrivateQt::setSize):
(WebCore::MediaPlayerPrivateQt::removeVideoItem):
(WebCore::MediaPlayerPrivateQt::restoreVideoItem):
(WebCore):
(WebCore::MediaPlayerPrivateQt::start):
(WebCore::MediaPlayerPrivateQt::supportedPixelFormats):
(WebCore::MediaPlayerPrivateQt::present):
(WebCore::MediaPlayerPrivateQt::paint):
(WebCore::MediaPlayerPrivateQt::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateQt::paintToTextureMapper):

  • platform/graphics/qt/MediaPlayerPrivateQt.h:

(MediaPlayerPrivateQt):

Source/WebKit:

  • WebKit1.pri: WK1 needs QtMultimediaWidgets for QVideoWidget and friends.
7:02 AM Changeset in webkit [130758] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Clean up Qt module detection

Reviewed by Tor Arne Vestbø.

Replace the use of MOBILITY_CONFIG (not supported anymore) with modern use of haveQtModule.

  • qmake/mkspecs/features/features.prf:
6:45 AM Changeset in webkit [130757] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[GTK] Respect WEBKITOUTPUTDIR in run-with-jhbuild.
https://bugs.webkit.org/show_bug.cgi?id=98732

Reviewed by Gustavo Noronha Silva.

Follow-up to r113066: if the WEBKITOUTPUTDIR environment variable
was used when running update-webkitgtk-libs,
WebKitBuild/Dependencies will not exist, so we now check its
contents first and then fall back to WebKitBuild/.

  • gtk/run-with-jhbuild:
6:43 AM Changeset in webkit [130756] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Allow users to specify a different hover image for TextFieldDecorationElement
https://bugs.webkit.org/show_bug.cgi?id=93662

Patch by Garrett Casto <gcasto@chromium.org> on 2012-10-09
Reviewed by Kent Tamura.

Source/WebCore:

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::TextFieldDecorationElement):
(WebCore::TextFieldDecorationElement::updateImage):
(WebCore::TextFieldDecorationElement::defaultEventHandler): Handles mouseover and mouseout events.
(WebCore::TextFieldDecorationElement::willRespondToMouseMoveEvents): Now returns true if the element is not disabled.
(WebCore):

  • html/shadow/TextFieldDecorationElement.h:

(TextFieldDecorator):
(TextFieldDecorationElement):

Source/WebKit/chromium:

  • public/WebTextFieldDecoratorClient.h:

(WebTextFieldDecoratorClient):
(WebKit::WebTextFieldDecoratorClient::imageNameForHoverState): Allow users to specify the name of the image for mouseover.

  • src/TextFieldDecoratorImpl.cpp:

(WebKit::TextFieldDecoratorImpl::imageForReadonlyState):
(WebKit::TextFieldDecoratorImpl::imageForHoverState):
(WebKit):

  • src/TextFieldDecoratorImpl.h:

(TextFieldDecoratorImpl):

6:31 AM Changeset in webkit [130755] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

[GTK] Add support for running JavaScript from GResources
https://bugs.webkit.org/show_bug.cgi?id=98488

Patch by Simon Pena <Simon Pena> on 2012-10-09
Reviewed by Carlos Garcia Campos.

GResources allow embedding certain resources, frequently used, in a "bundle"
which can be kept separated or stored in the binary. This patch adds
support for running JavaScript from GResources.

.:

  • configure.ac: Add support for compiling GResources

Source/WebKit2:

For this, methods run_javascript_from_gresource and
run_javascript_from_gresource_finish are added, which load the resource
asynchronously and, when it is ready, run the JavaScript.

  • UIProcess/API/gtk/WebKitWebView.cpp: Include the new methods.

(resourcesStreamReadCallback):
(webkit_web_view_run_javascript_from_gresource):
(webkit_web_view_run_javascript_from_gresource_finish):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include the new

methods in the documentation.

  • UIProcess/API/gtk/tests/GNUmakefile.am: Add the test resources to the

build infrastructure.

  • UIProcess/API/gtk/tests/TestMain.cpp: Register the resources in the tests,

so that they can be accessed in all of them.
(register_gresource):
(main):

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp: Test the

run_javascript_from_gresource method.
(testWebViewRunJavaScript):

  • UIProcess/API/gtk/tests/WebViewTest.cpp: Add a method for testing the

new run_javascript_from_gresource method.
(runJavaScriptFromGResourceReadyCallback):
(WebViewTest::runJavaScriptFromGResourceAndWaitUntilFinished):

  • UIProcess/API/gtk/tests/WebViewTest.h:
  • UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml: Added.

Resource bundle containing the resources.

  • UIProcess/API/gtk/tests/resources/webkit2gtk-tests.test.js: Added.

Example JavaScript file to test the GResources support.

6:07 AM Changeset in webkit [130754] by rakuco@webkit.org
  • 29 edits
    2 adds in trunk/LayoutTests

[EFL] Rebaseline some svg/text tests.

Some pixel tests now have the red rectangle drawn around some
areas like other ports.

While here, also add an expectation for selection-tripleclick.svg,
which seems to be passing now.

  • platform/efl/TestExpectations:
  • platform/efl/svg/text/foreignObject-text-clipping-bug-expected.png:
  • platform/efl/svg/text/selection-tripleclick-expected.png: Added.
  • platform/efl/svg/text/selection-tripleclick-expected.txt: Added.
  • platform/efl/svg/text/text-align-01-b-expected.png:
  • platform/efl/svg/text/text-align-02-b-expected.png:
  • platform/efl/svg/text/text-align-03-b-expected.png:
  • platform/efl/svg/text/text-align-04-b-expected.png:
  • platform/efl/svg/text/text-align-05-b-expected.png:
  • platform/efl/svg/text/text-align-06-b-expected.png:
  • platform/efl/svg/text/text-altglyph-01-b-expected.png:
  • platform/efl/svg/text/text-deco-01-b-expected.png:
  • platform/efl/svg/text/text-fonts-01-t-expected.png:
  • platform/efl/svg/text/text-fonts-02-t-expected.png:
  • platform/efl/svg/text/text-intro-05-t-expected.png:
  • platform/efl/svg/text/text-path-01-b-expected.png:
  • platform/efl/svg/text/text-spacing-01-b-expected.png:
  • platform/efl/svg/text/text-text-01-b-expected.png:
  • platform/efl/svg/text/text-text-03-b-expected.png:
  • platform/efl/svg/text/text-text-04-t-expected.png:
  • platform/efl/svg/text/text-text-05-t-expected.png:
  • platform/efl/svg/text/text-text-06-t-expected.png:
  • platform/efl/svg/text/text-text-07-t-expected.png:
  • platform/efl/svg/text/text-text-08-b-expected.png:
  • platform/efl/svg/text/text-tref-01-b-expected.png:
  • platform/efl/svg/text/text-tselect-01-b-expected.png:
  • platform/efl/svg/text/text-tselect-02-f-expected.png:
  • platform/efl/svg/text/text-tspan-01-b-expected.png:
  • platform/efl/svg/text/text-ws-01-t-expected.png:
  • platform/efl/svg/text/text-ws-02-t-expected.png:
6:00 AM Changeset in webkit [130753] by allan.jensen@digia.com
  • 5 edits in trunk

[Qt] Uploading images to Google+ using QtWebKit does not work.
https://bugs.webkit.org/show_bug.cgi?id=72329

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Implement handling of Blob FormData, including its extensions to the File FormData.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::appendBlobResolved):
(WebCore::FormDataIODevice::prepareFormElements):
(WebCore::FormDataIODevice::computeSize):
(WebCore::FormDataIODevice::moveToNextElement):
(WebCore::FormDataIODevice::prepareCurrentElement):
(WebCore::FormDataIODevice::openFileForCurrentElement):
(WebCore::FormDataIODevice::readData):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):

  • platform/network/qt/QNetworkReplyHandler.h:

(FormDataIODevice):

LayoutTests:

Unskip the two BLOB tests that now passes. The rest of the BLOB tests unfortunately depend
on features we do not have.

  • platform/qt/TestExpectations:
5:47 AM Changeset in webkit [130752] by Csaba Osztrogonác
  • 45 edits
    42 adds in trunk/LayoutTests

[Qt] Unskip and rebase now passing tests.

  • platform/qt/TestExpectations:
  • platform/qt/compositing/overflow/clip-descendents-expected.txt: Added.
  • platform/qt/css1/formatting_model/floating_elements-expected.png:
  • platform/qt/css1/formatting_model/floating_elements-expected.txt:
  • platform/qt/editing/selection/caret-ltr-2-expected.png:
  • platform/qt/editing/selection/caret-ltr-2-expected.txt:
  • platform/qt/editing/selection/caret-ltr-2-left-expected.png:
  • platform/qt/editing/selection/caret-ltr-2-left-expected.txt:
  • platform/qt/editing/selection/caret-ltr-expected.png:
  • platform/qt/editing/selection/caret-ltr-expected.txt:
  • platform/qt/editing/selection/caret-ltr-right-expected.png:
  • platform/qt/editing/selection/caret-ltr-right-expected.txt:
  • platform/qt/editing/selection/caret-rtl-2-left-expected.png:
  • platform/qt/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/qt/editing/selection/caret-rtl-right-expected.png:
  • platform/qt/editing/selection/caret-rtl-right-expected.txt:
  • platform/qt/fast/backgrounds/size/zero-expected.png: Added.
  • platform/qt/fast/backgrounds/size/zero-expected.txt:
  • platform/qt/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/qt/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
  • platform/qt/fast/forms/basic-buttons-expected.png:
  • platform/qt/fast/forms/basic-buttons-expected.txt:
  • platform/qt/fast/multicol/overflow-across-columns-expected.png: Added.
  • platform/qt/fast/multicol/overflow-across-columns-expected.txt: Added.
  • platform/qt/fast/multicol/overflow-unsplittable-expected.png: Added.
  • platform/qt/fast/multicol/overflow-unsplittable-expected.txt: Added.
  • platform/qt/fast/multicol/positive-leading-expected.png: Added.
  • platform/qt/fast/multicol/positive-leading-expected.txt: Added.
  • platform/qt/fast/multicol/shadow-breaking-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/qt/fast/overflow/003-expected.png:
  • platform/qt/fast/overflow/003-expected.txt:
  • platform/qt/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
  • platform/qt/fast/replaced/table-percent-height-expected.txt:
  • platform/qt/fast/text/line-initial-and-final-swashes-expected.txt: Added.
  • platform/qt/fonts/cursive-expected.png: Added.
  • platform/qt/fonts/cursive-expected.txt: Added.
  • platform/qt/fonts/default-expected.png: Added.
  • platform/qt/fonts/default-expected.txt: Added.
  • platform/qt/fonts/fantasy-expected.png: Added.
  • platform/qt/fonts/fantasy-expected.txt: Added.
  • platform/qt/fonts/monospace-expected.png: Added.
  • platform/qt/fonts/monospace-expected.txt: Added.
  • platform/qt/fonts/sans-serif-expected.png: Added.
  • platform/qt/fonts/sans-serif-expected.txt: Added.
  • platform/qt/fonts/serif-expected.png: Added.
  • platform/qt/fonts/serif-expected.txt: Added.
  • platform/qt/printing/page-count-relayout-shrink-expected.txt: Added.
  • platform/qt/printing/return-from-printing-mode-expected.png: Added.
  • platform/qt/printing/return-from-printing-mode-expected.txt: Added.
  • platform/qt/printing/setPrinting-expected.png: Added.
  • platform/qt/printing/setPrinting-expected.txt: Added.
  • platform/qt/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
  • platform/qt/svg/custom/clip-mask-negative-scale-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10296-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug12384-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug99948-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/qt/tables/mozilla/marvin/colgroup_width_pct-expected.png: Added.
  • platform/qt/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
  • platform/qt/tables/mozilla/marvin/table_overflow_hidden_td-expected.png: Added.
  • platform/qt/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
4:55 AM Changeset in webkit [130751] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] remove duplicate failure expectations
https://bugs.webkit.org/show_bug.cgi?id=98736

Unreviewed gardening.

Many tests are listed in both efl and wk2 expectations. Remove the efl expectations
in cases where the bug seems to be a wk2 issue.

Most expectations are also added into the efl-wk1 expectations (which is where
they should have been all along).

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-09

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
4:42 AM Changeset in webkit [130750] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Text decorations specified on the containing block are not properly applied when ::first-line is present.
https://bugs.webkit.org/show_bug.cgi?id=93829

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-10-09
Reviewed by Abhishek Arya.

Source/WebCore:

If a container's style and its pseudo :first-line style have unique
text-decorations specified for them, only the :first-line text-decoarations
were being applied.

The uploaded patch intends to first compute the text decoration colors
for the containing box, followed by that of the first-line (if specified).

This thus avoids the condition wherein our containing box's text-decorations
were not getting applied at all since initially we were only computing
for the first-line style.

Test: fast/css/text-decorations-on-first-line-and-containing-block.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
getTextDecorationColors() is first called for computing the containing box's
text-decoration values and then for first-line style's text-decorations,
if specified.

LayoutTests:

  • fast/css/text-decorations-on-first-line-and-containing-block-expected.html: Added.
  • fast/css/text-decorations-on-first-line-and-containing-block.html: Added.

Tests added for verifying the behavior of text-decorations when specified
both for the ::first-line as well as its containing block.

4:33 AM Changeset in webkit [130749] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r130746.
http://trac.webkit.org/changeset/130746
https://bugs.webkit.org/show_bug.cgi?id=98749

It made 45 tests crash on Qt (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09

Source/WebCore:

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::FormDataIODevice::computeSize):
(WebCore::FormDataIODevice::moveToNextElement):
(WebCore::FormDataIODevice::openFileForCurrentElement):
(WebCore::FormDataIODevice::readData):
(WebCore::QNetworkReplyHandler::getIODevice):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):

  • platform/network/qt/QNetworkReplyHandler.h:

(QNetworkReplyHandler):
(FormDataIODevice):

LayoutTests:

  • platform/qt/TestExpectations:
4:05 AM Changeset in webkit [130748] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed GTK gardening.

Skipping the accept-policy test in TestCookieManager API test that's
currently failing. The test failure is covered by
https://bugs.webkit.org/show_bug.cgi?id=98738.

  • Scripts/run-gtk-tests:

(TestRunner):

3:49 AM Changeset in webkit [130747] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark a few tests skipped in r130745 as failures instead of timeouts.

  • platform/efl/TestExpectations:
3:18 AM Changeset in webkit [130746] by allan.jensen@digia.com
  • 5 edits in trunk

[Qt] Uploading images to Google+ using QtWebKit does not work.
https://bugs.webkit.org/show_bug.cgi?id=72329

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Implement handling of Blob FormData, including its extensions to the File FormData.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::FormDataIODevice::computeSize):
(WebCore::FormDataIODevice::moveToNextElement):
(WebCore::FormDataIODevice::prepareCurrentElement):
(WebCore::FormDataIODevice::openFileForCurrentElement):
(WebCore::FormDataIODevice::readData):
(WebCore::QNetworkReplyHandler::getIODevice):
(WebCore::QNetworkReplyHandler::handleBlobDataIfAny):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):

  • platform/network/qt/QNetworkReplyHandler.h:

(QNetworkReplyHandler):
(FormDataIODevice):

LayoutTests:

Unskip the two BLOB tests that now passes. The rest of the BLOB tests unfortunately depend
on features we do not have.

  • platform/qt/TestExpectations:
2:44 AM Changeset in webkit [130745] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip a few tests after r130699.

  • platform/efl/TestExpectations:
2:35 AM Changeset in webkit [130744] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Remove comment added in r130650 now that I've run the GTK+ tests.

  • platform/efl-wk1/TestExpectations:
2:18 AM Changeset in webkit [130743] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding more failure expectations for regressions after r130699.

  • platform/gtk/TestExpectations:
2:11 AM Changeset in webkit [130742] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unskip now passing tests.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
2:09 AM Changeset in webkit [130741] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] /editing/selection/caret-bidi-first-and-last-letters.html fails
https://bugs.webkit.org/show_bug.cgi?id=51884

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Ryosuke Niwa.

This test pass with this change in testfonts https://gitorious.org/qtwebkit/testfonts/merge_requests/1

  • platform/qt/TestExpectations:
2:04 AM Changeset in webkit [130740] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] editing/selection/caret-at-bidi-boundary.html fails
https://bugs.webkit.org/show_bug.cgi?id=66514

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
Reviewed by Yuta Kitamura.

Unskipping test. The update in testfonts solved this bug.

  • platform/qt/TestExpectations:
1:55 AM Changeset in webkit [130739] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unskip and rebase a now passing test.

  • platform/qt/TestExpectations:
  • platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
1:50 AM Changeset in webkit [130738] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unskip fast/transforms/scrollIntoView-transformed.html.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
1:46 AM Changeset in webkit [130737] by Csaba Osztrogonác
  • 7 edits in trunk/LayoutTests

[Qt] Unskip and rebase now passing tests.

  • platform/qt-5.0/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
1:37 AM Changeset in webkit [130736] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectations for regressions after r130699 and
a failing multipart test introduced in r130651.

  • platform/gtk/TestExpectations:
1:27 AM Changeset in webkit [130735] by Csaba Osztrogonác
  • 10 edits
    1 add
    1 delete in trunk/LayoutTests

[Qt] Unskip and rebasing now passing tests.

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt/fast/css/word-space-extra-expected.png:
  • platform/qt/fast/css/word-space-extra-expected.txt:
  • platform/qt/fast/history/history-back-initial-vs-final-url-expected.txt: Added.
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/qt/http/tests/navigation/postredirect-frames-expected.txt:
  • platform/qt/http/tests/navigation/postredirect-goback2-expected.txt:
1:17 AM Changeset in webkit [130734] by keishi@webkit.org
  • 15 edits
    3 adds in trunk

Page popup should be smarter about its layout
https://bugs.webkit.org/show_bug.cgi?id=98499

Reviewed by Kent Tamura.

Source/WebCore:

This change fixes these two issues:

  1. Page popup should reposition itself so it won't get clipped by screen(Win/Linux) or rootview(Mac) bounds.
  2. Page popup should resize itself when it doesn't fit.

Test: platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html

  • Resources/pagepopups/calendarPicker.js:

(initialize): We need to set global.params at the beginning because we need it for resizeWindow().

  • Resources/pagepopups/colorSuggestionPicker.js: Added global.params.

(handleMessage):
(initialize):
(handleArgumentsTimeout):

  • Resources/pagepopups/pickerCommon.js:

(Rect): Represents an axis aligned rectangle.
(Rect.prototype.get maxX): Gets position of right edge.
(Rect.prototype.get maxY): Gets position of bottom edge.
(Rect.prototype.toString):
(Rect.intersection): Returns the intersection of two rectangles.
(resizeWindow): Resize window to a certain size. Don't allow shrinking.
(adjustWindowRect): Calculates the best position and size for the popup.
(_adjustWindowRectVertically):
(_adjustWindowRectHorizontally):
(setWindowRect): Sets the position and size of the popup to the given rect.

  • Resources/pagepopups/suggestionPicker.css:

(.suggestion-list): Don't show horizontal scroll bar.

  • Resources/pagepopups/suggestionPicker.js:

(SuggestionPicker.prototype._fixWindowSize):

  • page/PagePopupClient.cpp:

(WebCore::PagePopupClient::addProperty): For adding an int to JSON.
(WebCore::PagePopupClient::addProperty): For adding an IntRect to JSON.
(WebCore):

  • page/PagePopupClient.h:

(PagePopupClient):

Source/WebKit/chromium:

  • src/ColorChooserUIController.cpp:

(WebKit::ColorChooserUIController::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView.

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::init): We keep the originBoundsInRootView argument for MockPagePopupDriver.
(WebKit::WebPagePopupImpl::resize): WebPagePopupImpl isn't in charge of setting the popup position any more.

  • src/WebPagePopupImpl.h:

(WebPagePopupImpl):

LayoutTests:

  • platform/chromium/fast/forms/page-popup/page-popup-adjust-rect-expected.txt: Added.
  • platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html: Added.
  • platform/chromium-android/TestExpectations: Added platform/chromium/fast/forms/page-popup.
1:07 AM Changeset in webkit [130733] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unskip now passing tests.

  • platform/qt/TestExpectations:
1:00 AM Changeset in webkit [130732] by morrita@google.com
  • 9 edits
    2 adds in trunk/Source/WebCore

[Refactoring] Scoped Style related code should have its own class.
https://bugs.webkit.org/show_bug.cgi?id=98244

Reviewed by Dimitri Glazkov.

This change extracts StyleScopeResolver from StyleResolver to clarify
the responsibility of the style scope handling. Now we can easily see
where the style scoping needs to be involed.

Coming Shadow DOM related change like @host rules will fit within this class.

No new tests, refactoring.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::pushParentElement):
(WebCore::StyleResolver::popParentElement):
(WebCore::StyleResolver::pushParentShadowRoot):
(WebCore::StyleResolver::popParentShadowRoot):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleResolver.h:

(StyleResolver):

  • css/StyleScopeResolver.cpp: Added.

(WebCore):
(WebCore::StyleScopeResolver::StyleScopeResolver):
(WebCore::StyleScopeResolver::~StyleScopeResolver):
(WebCore::StyleScopeResolver::scopeFor):
(WebCore::StyleScopeResolver::ruleSetFor):
(WebCore::StyleScopeResolver::ensureRuleSetFor):
(WebCore::StyleScopeResolver::setupStack):
(WebCore::StyleScopeResolver::push):
(WebCore::StyleScopeResolver::pop):
(WebCore::StyleScopeResolver::collectFeaturesTo):
(WebCore::StyleScopeResolver::reportMemoryUsage):

  • css/StyleScopeResolver.h: Added.

(WebCore):
(StyleScopeResolver):
(WebCore::StyleScopeResolver::StackFrame::StackFrame):
(StackFrame):
(WebCore::StyleScopeResolver::hasScopedStyles):
(WebCore::StyleScopeResolver::stackSize):
(WebCore::StyleScopeResolver::stackFrameAt):
(WebCore::StyleScopeResolver::matchesStyleBounds):
(WebCore::StyleScopeResolver::stackIsConsistent):
(WebCore::StyleScopeResolver::ensureStackConsistency):
(WebCore::StyleScopeResolver::scopeFor):
(WebCore::StyleScopeResolver::ensureRuleSetFor):

12:58 AM Changeset in webkit [130731] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unskip now passing tests.

  • platform/qt/TestExpectations:
12:50 AM Changeset in webkit [130730] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unskip now passing tests.

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0/TestExpectations:
12:40 AM Changeset in webkit [130729] by charles.wei@torchmobile.com.cn
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Need API to control the DNS Prefetching
https://bugs.webkit.org/show_bug.cgi?id=98713

Reviewed by George Staikos.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::enableDNSPrefetch):
(WebKit):
(BlackBerry::WebKit::WebPage::disableDNSPrefetch):
(BlackBerry::WebKit::WebPage::isDNSPrefetchEnabled):

  • Api/WebPage.h:
12:22 AM Changeset in webkit [130728] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Remove redundant JAVASCRIPTCORE_JIT variable
https://bugs.webkit.org/show_bug.cgi?id=50000

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-10-09
Reviewed by Simon Hausmann.

Use ENABLE_JIT instead.

  • qmake/mkspecs/features/valgrind.prf:
12:18 AM Changeset in webkit [130727] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed gadening after r130709.

  • fast/harness/results-expected.txt:
12:12 AM Changeset in webkit [130726] by mark.lam@apple.com
  • 67 edits
    2 moves in trunk/Source/JavaScriptCore

Renamed RegisterFile to JSStack, and removed prototype of the
previously deleted Interpreter::privateExecute().
https://bugs.webkit.org/show_bug.cgi?id=98717.

Reviewed by Filip Pizlo.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.order:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/BytecodeConventions.h:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::nameForRegister):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::alreadyInJSStack):
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedInt32):
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedCell):
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedBoolean):
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedDouble):
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::isAlreadyInJSStack):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dump):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::registerFor):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::emitGetFromCallFrameHeaderPtr):
(JSC::DFG::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGGenerationInfo.h:

(GenerationInfo):
(JSC::DFG::GenerationInfo::needsSpill):

  • dfg/DFGGraph.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::beginCall):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryBuildGetByIDList):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::spill):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGThunks.cpp:

(JSC::DFG::throwExceptionFromCallSlowPathGenerator):
(JSC::DFG::slowPathFor):
(JSC::DFG::virtualForThunkGenerator):

  • dfg/DFGValueSource.cpp:

(JSC::DFG::ValueSource::dump):

  • dfg/DFGValueSource.h:

(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):
(JSC::DFG::isInJSStack):
(JSC::DFG::ValueSource::forSpeculation):
(JSC::DFG::ValueSource::isInJSStack):
(JSC::DFG::ValueSource::valueRecovery):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

  • heap/Heap.cpp:

(JSC::Heap::stack):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):

  • heap/Heap.h:

(JSC):
(Heap):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::stack):

  • interpreter/CallFrame.h:

(JSC::ExecState::calleeAsValue):
(JSC::ExecState::callee):
(JSC::ExecState::codeBlock):
(JSC::ExecState::scope):
(JSC::ExecState::callerFrame):
(JSC::ExecState::returnPC):
(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(JSC::ExecState::setBytecodeOffsetForNonDFGCode):
(JSC::ExecState::inlineCallFrame):
(JSC::ExecState::codeOriginIndexForDFG):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setScope):
(JSC::ExecState::init):
(JSC::ExecState::argumentCountIncludingThis):
(JSC::ExecState::offsetFor):
(JSC::ExecState::setArgumentCountIncludingThis):
(JSC::ExecState::setCallee):
(JSC::ExecState::setCodeBlock):
(JSC::ExecState::setReturnPC):
(JSC::ExecState::setInlineCallFrame):
(ExecState):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::slideRegisterWindowForCall):
(JSC::eval):
(JSC::loadVarargs):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::endRepeatCall):

  • interpreter/Interpreter.h:

(JSC::Interpreter::stack):
(Interpreter):
(JSC::Interpreter::execute):
(JSC):

  • interpreter/JSStack.cpp: Copied from Source/JavaScriptCore/interpreter/RegisterFile.cpp.

(JSC::stackStatisticsMutex):
(JSC::JSStack::~JSStack):
(JSC::JSStack::growSlowCase):
(JSC::JSStack::gatherConservativeRoots):
(JSC::JSStack::releaseExcessCapacity):
(JSC::JSStack::initializeThreading):
(JSC::JSStack::committedByteCount):
(JSC::JSStack::addToCommittedByteCount):

  • interpreter/JSStack.h: Copied from Source/JavaScriptCore/interpreter/RegisterFile.h.

(JSStack):
(JSC::JSStack::JSStack):
(JSC::JSStack::shrink):
(JSC::JSStack::grow):

  • interpreter/RegisterFile.cpp: Removed.
  • interpreter/RegisterFile.h: Removed.
  • interpreter/VMInspector.cpp:

(JSC::VMInspector::dumpFrame):

  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC):
(JIT):

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):

  • jit/JITCode.h:

(JSC):
(JSC::JITCode::execute):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitPutToCallFrameHeader):
(JSC::JIT::emitPutCellToCallFrameHeader):
(JSC::JIT::emitPutIntToCallFrameHeader):
(JSC::JIT::emitPutImmediateToCallFrameHeader):
(JSC::JIT::emitGetFromCallFrameHeaderPtr):
(JSC::JIT::emitGetFromCallFrameHeader32):
(JSC::JIT::updateTopCallFrame):
(JSC::JIT::unmap):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emit_op_get_arguments_length):
(JSC::JIT::emit_op_get_argument_by_val):
(JSC::JIT::emit_op_resolve_global_dynamic):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emit_op_get_arguments_length):
(JSC::JIT::emit_op_get_argument_by_val):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):

  • jit/JITStubs.cpp:

(JSC::ctiTrampoline):
(JSC::JITThunks::JITThunks):
(JSC):
(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC):
(JITStackFrame):

  • jit/JSInterfaceJIT.h:
  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntOffsetsExtractor.cpp:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::genericCall):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter.asm:
  • runtime/Arguments.cpp:

(JSC::Arguments::tearOffForInlineCallFrame):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::globalExec):

  • runtime/JSGlobalObject.h:

(JSC):
(JSGlobalObject):

  • runtime/JSLock.cpp:

(JSC):

  • runtime/JSVariableObject.h:

(JSVariableObject):

  • runtime/MemoryStatistics.cpp:

(JSC::globalMemoryStatistics):

12:10 AM Changeset in webkit [130725] by zandobersek@gmail.com
  • 2 edits in trunk

Unreviewed GTK build fix after r130689.

Adding a required symbol to symbols.filter.

  • Source/autotools/symbols.filter:
12:06 AM Changeset in webkit [130724] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unskip now passing tests.

  • platform/qt-5.0-wk2/TestExpectations:
12:06 AM Changeset in webkit [130723] by Simon Hausmann
  • 6 edits
    4 moves
    4 adds in trunk/Source

[Qt] Make RenderThemeQStyle/ScrollbarThemeQStyle compile without QStyle/QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=98268

Reviewed by Tor Arne Vestbø.

Source/WebCore:

Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.

QStyleFacade is a pure interface that lives in WebCore/platform/qt
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
minimal interface of what we need to draw with QStyle as well as basic
hit testing and metric retrieval. It also provides a
QStyleFacadeOption class that aggregates common meta-data for
rendering primitives, such as direction, rectangle, state (sunken,
enabled, etc.) or palette. It also provides some more slider/scrollbar
specific fields in a slider sub-structure.

RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
them with state information from render objects, before calling straight to QStyle. Most of the common code
was encapsulated in StylePainterQStyle.

The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
StylePainterQStyle to populate state into QStyleFacadeOption before
calling into QStyleFacade.

The style facade is then implemented by QStyleFacadeImp, which extracts
meta-data from QStyleFacadeOption arguments, populates style
primitive specific QStyleOption objects and then calls on QStyle.

RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
separate QtWebKitWidgets library in the future and therefore cannot use
any WebCore types.

  • Target.pri:
  • platform/qt/QStyleFacade.cpp: Added.

(WebCore):
(WebCore::QStyleFacade::styleForPage):

  • platform/qt/QStyleFacade.h: Added.

(WebCore):
(QStyleFacade):
(WebCore::QStyleFacade::~QStyleFacade):
(WebCore::QStyleFacadeOption::QStyleFacadeOption):
(QStyleFacadeOption):

  • platform/qt/RenderThemeQStyle.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.cpp.

(WebCore):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::setStyleFactoryFunction):
(WebCore::RenderThemeQStyle::styleFactory):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::colorPalette):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • platform/qt/RenderThemeQStyle.h: Renamed from Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.h.

(WebCore):
(RenderThemeQStyle):
(WebCore::RenderThemeQStyle::qStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::paintButton):
(WebCore::StylePainterQStyle::paintTextField):
(WebCore::StylePainterQStyle::paintComboBox):
(WebCore::StylePainterQStyle::paintComboBoxArrow):
(WebCore::StylePainterQStyle::paintSliderTrack):
(WebCore::StylePainterQStyle::paintSliderThumb):
(WebCore::StylePainterQStyle::paintInnerSpinButton):
(WebCore::StylePainterQStyle::paintProgressBar):
(WebCore::StylePainterQStyle::paintScrollCorner):
(WebCore::StylePainterQStyle::paintScrollBar):

  • platform/qt/ScrollbarThemeQStyle.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/ScrollbarThemeQStyle.cpp.

(WebCore):
(WebCore::ScrollbarThemeQStyle::ScrollbarThemeQStyle):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::initSliderStyleOption):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):

  • platform/qt/ScrollbarThemeQStyle.h: Renamed from Source/WebKit/qt/WebCoreSupport/ScrollbarThemeQStyle.h.

(WebCore):
(ScrollbarThemeQStyle):
(WebCore::ScrollbarThemeQStyle::qStyle):

Source/WebKit:

  • WebKit1.pro: Add new files to the build.

Source/WebKit/qt:

Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.

QStyleFacade is a pure interface that lives in WebCore/platform/qt
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
minimal interface of what we need to draw with QStyle as well as basic
hit testing and metric retrieval. It also provides a
QStyleFacadeOption class that aggregates common meta-data for
rendering primitives, such as direction, rectangle, state (sunken,
enabled, etc.) or palette. It also provides some more slider/scrollbar
specific fields in a slider sub-structure.

RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
them with state information from render objects, before calling straight to QStyle. Most of the common code
was encapsulated in StylePainterQStyle.

The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
StylePainterQStyle to populate state into QStyleFacadeOption before
calling into QStyleFacade.

The style facade is then implemented by QStyleFacadeImp, which extracts
meta-data from QStyleFacadeOption arguments, populates style
primitive specific QStyleOption objects and then calls on QStyle.

RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
separate QtWebKitWidgets library in the future and therefore cannot use
any WebCore types.

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

  • WebCoreSupport/QStyleFacadeImp.cpp: Added.

(WebKit):
(WebKit::convertToQStyleState):
(WebKit::convertToQStyleSubControl):
(WebKit::initGenericStyleOption):
(WebKit::initSpecificStyleOption):
(MappedStyleOption):
(WebKit::MappedStyleOption::MappedStyleOption):
(WebKit::convertPixelMetric):
(WebKit::convertToQStyleFacadeSubControl):
(WebKit::QStyleFacadeImp::QStyleFacadeImp):
(WebKit::QStyleFacadeImp::~QStyleFacadeImp):
(WebKit::QStyleFacadeImp::buttonSubElementRect):
(WebKit::QStyleFacadeImp::findFrameLineWidth):
(WebKit::QStyleFacadeImp::simplePixelMetric):
(WebKit::QStyleFacadeImp::buttonMargin):
(WebKit::QStyleFacadeImp::sliderLength):
(WebKit::QStyleFacadeImp::sliderThickness):
(WebKit::QStyleFacadeImp::progressBarChunkWidth):
(WebKit::QStyleFacadeImp::getButtonMetrics):
(WebKit::QStyleFacadeImp::sizeFromContents):
(WebKit::QStyleFacadeImp::paintButton):
(WebKit::QStyleFacadeImp::paintTextField):
(WebKit::QStyleFacadeImp::paintComboBox):
(WebKit::QStyleFacadeImp::paintComboBoxArrow):
(WebKit::QStyleFacadeImp::paintSliderTrack):
(WebKit::QStyleFacadeImp::paintSliderThumb):
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
(WebKit::QStyleFacadeImp::paintProgressBar):
(WebKit::QStyleFacadeImp::scrollBarExtent):
(WebKit::QStyleFacadeImp::scrollBarMiddleClickAbsolutePositionStyleHint):
(WebKit::QStyleFacadeImp::paintScrollCorner):
(WebKit::QStyleFacadeImp::hitTestScrollBar):
(WebKit::QStyleFacadeImp::scrollBarSubControlRect):
(WebKit::QStyleFacadeImp::paintScrollBar):
(WebKit::QStyleFacadeImp::widgetForPainter):
(WebKit::QStyleFacadeImp::style):

  • WebCoreSupport/QStyleFacadeImp.h: Added.

(WebCore):
(WebKit):
(QStyleFacadeImp):
(WebKit::QStyleFacadeImp::create):
(WebKit::QStyleFacadeImp::isValid):

12:01 AM TestExpectations edited by pdr@google.com
Fix spelling errors (diff)

Oct 8, 2012:

11:35 PM Changeset in webkit [130722] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION(r128699): It made 2 fast/js/dfg tests assert
https://bugs.webkit.org/show_bug.cgi?id=96907

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-08
Reviewed by Csaba Osztrogonác.

Unskipping tests.

  • platform/qt/TestExpectations:
11:11 PM FeatureFlags edited by cmuppala@apple.com
Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature flag. (diff)
11:01 PM Changeset in webkit [130721] by yosin@chromium.org
  • 1 edit
    2 copies in branches/chromium/1271

Merge 130717 - HTMLSelectElement::typeAheadFind depends on implementation dependent behavior
https://bugs.webkit.org/show_bug.cgi?id=98710

Reviewed by Kent Tamura.

Source/WebCore:

This patch gets rid of C/C++ implementation dependent behavior from
HTMLSelectElement::typeAheadFind() which does modulo operation with
a negative operand.

HTMLSelectElement::typeAheadFind() contains expression with modulo
operator and dividend can be -1 when the "select" element without
"option" element but "optgroup" element.

Test: fast/forms/select/select-typeahead-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo
operation with both operands are non-negative.

LayoutTests:

This patch adds a test for checking HTMLSelectElement::typeAheadFind
doesn't crash.

  • fast/forms/select/select-typeahead-crash-expected.txt: Added.
  • fast/forms/select/select-typeahead-crash.html: Added.

TBR=yosin@chromium.org
Review URL: https://codereview.chromium.org/11088020

10:45 PM Changeset in webkit [130720] by commit-queue@webkit.org
  • 42 edits
    2 adds in trunk

Throttle DOM timers on hidden pages.
https://bugs.webkit.org/show_bug.cgi?id=98474

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-10-08
Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

When the visibility of a page changes to "hidden", all it's DOM timers are
updated to align their fire times on one second intervals. This limits the
number of CPU wakes due to a hidden pages to one per second.

Test: fast/dom/timer-throttling-hidden-page.html

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore):
(WebCore::Document::timerAlignmentInterval):
Read Page::timerAlignmentInterval and pass it along to DOMTimer.

  • dom/Document.h:

(Document):

  • dom/ScriptExecutionContext.cpp:

(WebCore):
(WebCore::ScriptExecutionContext::didChangeTimerAlignmentInterval):
Scan through self DOM Timers and tell them to recompute their fire
time based on the updated alignment interval.
(WebCore::ScriptExecutionContext::timerAlignmentInterval):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

  • page/DOMTimer.cpp:

(WebCore):
(WebCore::DOMTimer::alignedFireTime):
If the document's alignment interval is non zero, round up the fire
time to the next multiple of alignment interval.

  • page/DOMTimer.h:

(DOMTimer):
(WebCore::DOMTimer::defaultTimerAlignmentInterval):
(WebCore::DOMTimer::setDefaultTimerAlignmentInterval):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore):
(WebCore::Page::setTimerAlignmentInterval):
(WebCore::Page::timerAlignmentInterval):
(WebCore::Page::setVisibilityState):
Getter and Setter for alignment interval. Expose setVisibilityState
if either PAGE_VISIBILITY_API is enabled or if HIDDEN_PAGE_DOM_TIMER_REDUCTION
is enabled.

  • page/Page.h:

(Page):

  • page/Settings.cpp:

(WebCore):
(WebCore::Settings::setDefaultDOMTimerAlignmentInterval):
(WebCore::Settings::defaultDOMTimerAlignmentInterval):
(WebCore::Settings::setDOMTimerAlignmentInterval):
(WebCore::Settings::domTimerAlignmentInterval):

  • page/Settings.h:

(Settings):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::suspend):
Save the time remaining to the original unaligned fire time, so that
on resuming, the fire time will be correctly aligned using the latest
alignment interval.

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::sharedTimerFiredInternal):
Clear m_unalignedNextFireTime along with m_nextFireTime to keep
them always in sync.

  • platform/Timer.cpp:

(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::setNextFireTime):
Save the requested fire time in m_unalignedNextFireTime and
set m_nextFireTime to the aligned value. The unalinged value
is used to recompute fire time if alignment interval changes.
(WebCore):
(WebCore::TimerBase::didChangeAlignmentInterval):
Recompute next fire time from m_unalignedNextFireTime.
(WebCore::TimerBase::nextUnalignedFireInterval):
Interval from current time to the original unaligned fire time.

  • platform/Timer.h:

(TimerBase):
(WebCore::TimerBase::alignedFireTime):

Source/WebKit/mac:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define and provide a SPI for
DumpRenderTree to modify the visibility state of a page. The latter
is needed to test throttling of timers on hidden pages through DumpRenderTree.

  • Configurations/FeatureDefines.xcconfig:
  • WebView/WebView.mm:

(-[WebView _setVisibilityState:isInitialState:]):

  • WebView/WebViewPrivate.h:

Source/WebKit2:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define. Use existing code of
PAGE_VISIBILITY_API to detect changes to page visibility state.

  • Configurations/FeatureDefines.xcconfig:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Check visibility state on construction.
(WebKit::WebPageProxy::initializeWebPage):
Send initial visibility state message if HIDDEN_PAGE_DOM_TIMER_THROTTLING
is enabled or if PAGE_VISIBILITY_API is enabled.
(WebKit::WebPageProxy::viewStateDidChange):
When PAGE_VISIBILITY_API is not enabled, compare new visibility against
WebPageProxy::m_isVisible, to minimize number of messages sent.
Remove unnecessary second call to PageClient::isViewVisible for updating
visibility state.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPageVisibilityState):
WebKitTestRunner uses this method to implement testRunner.setPageVisibility(),
hence enable it for testing hidden page timer throttling as well.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit):
(WebKit::WebPage::setVisibilityState):
Ensure Page::setVisibilityState is called either if PAGE_VISIBILITY_API is
enabled or if HIDDEN_PAGE_DOM_TIMER_THROTTLING is enabled.

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:

Tools:

Implement testRunner.setPageVisibility on mac for testing throttling
of timers on hidden pages using DumpRenderTree.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:

Fix build error on mac-ews bot. Add JSC copy of ICU headers to search path.

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):

WebKitLibraries:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Add a test for DOM timer throttling on hidden pages.

  • fast/dom/timer-throttling-hidden-page-expected.txt: Added.
  • fast/dom/timer-throttling-hidden-page.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:

Skip the test since HIDDEN_PAGE_DOM_TIMER_THROTTLING is not enabled by default.

10:31 PM Changeset in webkit [130719] by yosin@chromium.org
  • 1 edit
    2 copies in branches/chromium/1229

Merge 130717 - HTMLSelectElement::typeAheadFind depends on implementation dependent behavior
https://bugs.webkit.org/show_bug.cgi?id=98710

Reviewed by Kent Tamura.

Source/WebCore:

This patch gets rid of C/C++ implementation dependent behavior from
HTMLSelectElement::typeAheadFind() which does modulo operation with
a negative operand.

HTMLSelectElement::typeAheadFind() contains expression with modulo
operator and dividend can be -1 when the "select" element without
"option" element but "optgroup" element.

Test: fast/forms/select/select-typeahead-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo
operation with both operands are non-negative.

LayoutTests:

This patch adds a test for checking HTMLSelectElement::typeAheadFind
doesn't crash.

  • fast/forms/select/select-typeahead-crash-expected.txt: Added.
  • fast/forms/select/select-typeahead-crash.html: Added.

TBR=yosin@chromium.org
Review URL: https://codereview.chromium.org/11091018

10:12 PM Changeset in webkit [130718] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

1.18MB below RenderTableSection::setCachedCollapsedBorderValue() on Membuster3.
<http://webkit.org/b/98670>
<rdar://problem/12454276>

Reviewed by Anders Carlsson.

Refactor CollapsedBorderValue to only store the bits and pieces from the BorderValue
that it actually needs. Packed the whole thing into 64 bits.

Reduces memory consumption by 547kB on Membuster3.

  • rendering/RenderTableCell.cpp:

Add compile-time size assertion for CollapsedBorderValue.

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::width):
(WebCore::CollapsedBorderValue::style):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::isTransparent):
(WebCore::CollapsedBorderValue::precedence):
(WebCore::CollapsedBorderValue::isSameIgnoringColor):
(CollapsedBorderValue):

Apply shrinkwrap to CollapsedBorderValue. Removed specialized copy constructor since
the class only has primitive members now.

9:47 PM Changeset in webkit [130717] by yosin@chromium.org
  • 3 edits
    2 adds in trunk

HTMLSelectElement::typeAheadFind depends on implementation dependent behavior
https://bugs.webkit.org/show_bug.cgi?id=98710

Reviewed by Kent Tamura.

Source/WebCore:

This patch gets rid of C/C++ implementation dependent behavior from
HTMLSelectElement::typeAheadFind() which does modulo operation with
a negative operand.

HTMLSelectElement::typeAheadFind() contains expression with modulo
operator and dividend can be -1 when the "select" element without
"option" element but "optgroup" element.

Test: fast/forms/select/select-typeahead-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo
operation with both operands are non-negative.

LayoutTests:

This patch adds a test for checking HTMLSelectElement::typeAheadFind
doesn't crash.

  • fast/forms/select/select-typeahead-crash-expected.txt: Added.
  • fast/forms/select/select-typeahead-crash.html: Added.
7:18 PM Changeset in webkit [130716] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Take account of overflowing values for width calculation of a year sub-field
https://bugs.webkit.org/show_bug.cgi?id=98506

Reviewed by Eric Seidel.

Source/WebCore:

When we decide the width of a year field of an input[type=date]
with the multiple fields UI, we need to take account of the
current value width because we allow to set overflowing values to
the input[type=date].

This change affects only platforms with INPUT_TYPE_DATE &&
INPUT_MULTIPLE_FIELDS_UI.

Test: fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::customStyleForRenderer):
Take account of the current value width.

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html: Added.
6:52 PM Changeset in webkit [130715] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium DEPS roll r160657:160764.

Unreviewed.

  • DEPS:
6:52 PM Changeset in webkit [130714] by tony@chromium.org
  • 5 edits
    2 adds in trunk

image not displayed in flexbox
https://bugs.webkit.org/show_bug.cgi?id=98611

Reviewed by Ojan Vafai.

Source/WebCore:

Flexbox will override the width of a child and when stretching, will override the height of the child.
When this happens, when an image loads, it checks to see if it's width/height has
changed, and if so, does a relayout. The overridden width/height was preventing this
relayout from happening.

To fix, we clear all the override sizes when we're done laying out the flex children.

Test: css3/flexbox/relayout-image-load.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock): Clear child override sizes.
(WebCore::RenderFlexibleBox::clearChildOverrideSizes):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): No longer need to clear the override size
here since it should have already been cleared.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

Load an image after flexbox layout has happened.

  • css3/flexbox/relayout-image-load-expected.txt: Added.
  • css3/flexbox/relayout-image-load.html: Added.
  • platform/chromium/TestExpectations: Remove css3/flexbox/flexitem-stretch-image.html

since it should no longer be flaky.

6:48 PM Changeset in webkit [130713] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Skip Layout/subtree-detaching.html temporarily as it's very noisy and
takes 112s to run on Chromium Mac. This is tracked by the bug 98708.

  • Skipped:
6:44 PM Changeset in webkit [130712] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r130643): editing/pasteboard/data-transfer-item is failing on chromium.
<http://webkit.org/b/98686>

Reviewed by Tony Chang.

Change ChromiumDataObject::createFromPasteboard() to use a ListHashSet instead of a HashSet so that
item order is preserved.

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::createFromPasteboard):

6:43 PM Changeset in webkit [130711] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Perf. test results page is broken when runs have different sets of tests
https://bugs.webkit.org/show_bug.cgi?id=98691

Reviewed by Daniel Bates.

Add "missing" columns for tests that are missing some runs.

Also fix regressions from the previous patch:

  • Make reference run switch work again
  • Load jquery plugins from the remote server when the jquery is loaded from the remote server.
  • resources/results-template.html:
6:39 PM Changeset in webkit [130710] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

Inline logicalHeightForRowSizing to shave another 2-3% off robohornet's resizecol.html
https://bugs.webkit.org/show_bug.cgi?id=98703

Reviewed by Emil A Eklund.

This is very small potatoes. There are much bigger wins for table layout yet, but
this was an easy win.

This function should probably be converted to use int's only, as table cells are pixel-sized
according to our subpixel-experts.

Also, I suspect there should be ways to early return with less-math in the common cases, but
I've saved such for a later patch.

Note that I changed from using paddingBefore/paddingAfter (which include the instrinsic padding)
to calling computedCSSPaddingBefore/computedCSSPaddingAfter directly as well.

This single function is about 11% of total time for robohornet's resizecol.

  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::logicalHeightForRowSizing):

6:36 PM Changeset in webkit [130709] by dpranke@chromium.org
  • 6 edits in trunk

results.html and garden-o-matic are ignoring IMAGE failures when expected to FAIL
https://bugs.webkit.org/show_bug.cgi?id=98706

Reviewed by Ojan Vafai.

FAIL is supposed to map onto Failure which is supposed to map
onto the old [ TEXT, IMAGE_PLUS_TEXT, AUDIO ] mapping.
results.html was including IMAGE in this and garden-o-matic was
including CRASH and TIMEOUT as well :(.

Tools:

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:

LayoutTests:

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
6:17 PM Changeset in webkit [130708] by alecflett@chromium.org
  • 22 edits in trunk/Source

IndexedDB: remove autogenerated objectStore/index id code
https://bugs.webkit.org/show_bug.cgi?id=98085

Reviewed by Tony Chang.

Source/WebCore:

Remove support for backend-generated objectstore and index
ids. The frontend objects now manage that state during
versionchange transactions. The IDBDatabaseBackendInterface and
IDBObjectStoreBackendInterface methods will go away when
https://bugs.webkit.org/show_bug.cgi?id=98682 lands.

No new tests as this is part of a refactoring, existing indexeddb
tests cover correctness.

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::setMaxIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

Remove support for unused createObjectStore/createIndex. These
methods will go away entirely when
https://bugs.webkit.org/show_bug.cgi?id=98682 is fixed.

  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::createObjectStore):

  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

5:59 PM Changeset in webkit [130707] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

[EFL] Build ControlTheme only when necessary
https://bugs.webkit.org/show_bug.cgi?id=98519

Reviewed by Eric Seidel.

  • EWebLauncher/ControlTheme/CMakeLists.txt:

Added custom command keyword not to build ControlTheme every time.
In addition, removed ALL keyword because targets, which use ControlTheme,
already have dependency.

5:55 PM Changeset in webkit [130706] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CAIRO] Adjust the source rect size when IMAGE_DECODER_DOWN_SAMPLING is enabled
https://bugs.webkit.org/show_bug.cgi?id=98630

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-08
Reviewed by Martin Robinson.

IMAGE_DECODER_DOWN_SAMPLING scales down the size of the big image.
CAIRO needs to adjust the source size to the scaled value.

No new tests.

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw):

5:08 PM Changeset in webkit [130705] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove unused features of BlobBuilder
https://bugs.webkit.org/show_bug.cgi?id=98331

Reviewed by Eric Seidel.

Now that we don't expose BlobBuilder as a web platform API, we can
strip down the class to handle only those cases that are needed by the
Blob constructor.

I've also renamed the class from WebKitBlobBuilder to BlobBuilder and
made it stack allocated rather than RefCounted. A future patch will
actually move the files around. (I didn't want to mix moving code
around with modifying the code.)

  • bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore):
(WebCore::BlobBuilder::BlobBuilder):
(WebCore::BlobBuilder::getBuffer):
(WebCore::BlobBuilder::append):
(WebCore::BlobBuilder::appendBytesData):
(WebCore::BlobBuilder::getBlob):

  • fileapi/WebKitBlobBuilder.h:

(WebCore):
(BlobBuilder):

  • page/FeatureObserver.h:
5:02 PM Changeset in webkit [130704] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

Try to fix the debug build after r130699

Move the assignment of the ResourceHandleInternal local to before
the include statement where it is used.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::createSoupMessageForHandleAndRequest):

4:33 PM Changeset in webkit [130703] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Do not swallow fatal messages in qt/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=98211

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-10-08
Reviewed by Eric Seidel.

Fix condition in message type filtering.

  • DumpRenderTree/qt/DumpRenderTreeMain.cpp:

(messageHandler):

4:31 PM Changeset in webkit [130702] by hclam@chromium.org
  • 164 edits
    73 adds in trunk/LayoutTests

Not reviewed. Rebaselines for Chromium.

Rebaseline after r130412 which affected image scaling pixel tests.

  • platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize15-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Added.
  • platform/chromium-linux-x86/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-linux-x86/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/clip-mask-negative-scale-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/pointer-events-image-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-linux/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-expected.png:
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
  • platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-linux/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-linux/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-mac/fast/borders/inline-mask-overlay-image-outset-expected.png:
  • platform/chromium-mac/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
  • platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win-xp/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/backgroundSize15-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-scaled-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/scaled-border-image-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-win-xp/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
  • platform/chromium-win-xp/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/clip-mask-negative-scale-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/image-small-width-height-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/pointer-events-image-expected.png: Added.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-win/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.png:
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
  • platform/chromium-win/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-win/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium/TestExpectations:
4:24 PM Changeset in webkit [130701] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

4:20 PM Changeset in webkit [130700] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

Post-r130226 Cleanup: Comment a complicated if statement and make it a helper.
https://bugs.webkit.org/show_bug.cgi?id=98463

Reviewed by Eric Seidel.

No new tests, refactor only.

  • rendering/RenderLayer.cpp:

(WebCore::frameElementAndViewPermitScroll):
(WebCore::RenderLayer::scrollRectToVisible):

4:12 PM Changeset in webkit [130699] by mrobinson@webkit.org
  • 5 edits in trunk/Source/WebCore

[Soup] Simplify the way that requests are started
https://bugs.webkit.org/show_bug.cgi?id=98532

Reviewed by Gustavo Noronha Silva.

Simplify the creation of the libsoup request and message when kicking off
requests, by elminating a bit of duplicate code.

No new tests. This should not change any behavior.

  • platform/network/ResourceHandle.h:

(ResourceHandle):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::ResourceHandleInternal::soupSession): Ensure the session
is initialized when passing it to the caller.
(WebCore::createSoupMessageForHandleAndRequest): Added this helper which
takes care of creating the SoupMessage for HTTP/HTTPS requests.
(WebCore::createSoupRequestAndMessageForHandle): Collapsed the HTTP and
non-HTTP request creation into this helper.
(WebCore::ResourceHandle::start): Call the new helper now and then sendPendingRequest.
(WebCore::ResourceHandle::sendPendingRequest): Instead of having special
helpers to create and send the request, duplicating the logic for sending it
across the file, add this method which can be used in both cases.
(WebCore::waitingToSendRequest): Reworked the hasBeenSent method to answer
the question of whether or not the request is ready to be sent, but is unsent.
(WebCore::ResourceHandle::platformSetDefersLoading): Use the new helper.

  • platform/network/soup/ResourceRequest.h:

(ResourceRequest): Added a new method for getting the URL string for soup.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::urlStringForSoup): Added.

3:59 PM Changeset in webkit [130698] by eric@webkit.org
  • 5 edits in trunk/Source/WebCore

Make no-column table-layout cases a little faster with inlining
https://bugs.webkit.org/show_bug.cgi?id=98566

Reviewed by Julien Chaffraix.

This change is almost not worth it at only a couple percent boost on
http://www.robohornet.org/tests/resizecol.html
However, I think the logicalWidthFromTableColumn split it kinda nice
so I've decided to post it anyway.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::slowColElement):

  • rendering/RenderTable.h:

(WebCore::RenderTable::colElement):
(RenderTable):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::logicalWidthFromTableColumn):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::styleOrColLogicalWidth):
(RenderTableCell):

3:58 PM BuildingOnWindows edited by roger_fong@apple.com
(diff)
3:58 PM Changeset in webkit [130697] by jchaffraix@webkit.org
  • 8 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

  • platform/chromium/TestExpectations:

Marked a test as crashing on Lion.

  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:

Rebaselined these tests after a change in Chromium compositor (Chromium r160671).

3:41 PM Changeset in webkit [130696] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Tools

Unreviewed. Moving myself from Committer to Reviewer list.
http://lists.webkit.org/pipermail/webkit-dev/2012-October/022460.html

  • Scripts/webkitpy/common/config/committers.py:
3:31 PM Changeset in webkit [130695] by benjamin@webkit.org
  • 8 edits in trunk/Source/WTF

Generalize moving URLComponent's begin position
https://bugs.webkit.org/show_bug.cgi?id=98626

Reviewed by Adam Barth.

The patch r130609 introduced moving URLComponents's position.
It turns out this concept is really useful in the parser so
this patch generalize the idea.

  • wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::removePort):

  • wtf/url/src/URLCanonEtc.cpp:
  • wtf/url/src/URLComponent.h:

(WTF::URLComponent::moveBy):
Rename URLComponent::move() to URLComponent::moveBy() for consistency
with some of WebCore types.

  • wtf/url/src/URLParse.cpp:
  • wtf/url/src/URLParseFile.cpp:
  • wtf/url/src/URLSegments.cpp:

(WTF::URLSegments::moveFromComponentBy):
Change the semantic to everything from a certain component. This is
useful to move everything, including the scheme.

  • wtf/url/src/URLSegments.h:

(URLSegments):

3:30 PM Changeset in webkit [130694] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Rename RenderObject::firstLineStyleSlowCase() to a more appropriate cachedFirstLineStyle()
https://bugs.webkit.org/show_bug.cgi?id=98631

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-10-08
Reviewed by Eric Seidel.

Renaming firstLineStyleSlowCase() to cachedFirstLineStyle().

The current name is confusing since the function actually gets the
the cached first-line styles.
It also makes the name more descriptive of its functionality
and in accordance with RenderObject::uncachedFirstLineStyle().

No new tests required for this change since no change in behavior is expected.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::cachedFirstLineStyle):

  • rendering/RenderObject.h:

(WebCore::RenderObject::firstLineStyle):
(RenderObject):
Renamed RenderObject::firstLineStyleSlowCase() to cachedFirstLineStyle()
and made the associated changes.

3:22 PM Changeset in webkit [130693] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Try to fix Windows build by exporting Frame::layerTreeAsText().

  • win/WebKit2.def:
3:15 PM Changeset in webkit [130692] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

Some non-scrollable elements are added to non-fast-scrollable region
https://bugs.webkit.org/show_bug.cgi?id=97927

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-10-08
Reviewed by James Robinson.

Source/WebCore:

Only RenderLayers that can actually be scrolled should be added to the
ScrollingCoordinator's non-fast scrollable region. Otherwise we may
needlessly fall back to main thread scrolling.

Test: ScrollingCoordinatorChromiumTest.clippedBodyTest

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):

Source/WebKit/chromium:

Test that a non-scrollable RenderLayer isn't added to the non-fast scrollable
region.

The test in this patch consists of a web page where both the html and
body elements clip horizontal overflow. This results in a hierarchy
where the body element gets a scrollable RenderLayer. However, that
layer isn't (interactively) scrollable because while the scroll geometry
is calculated based on the amount of overflow, the scroll bars are
hidden because of the "overflow-x: hidden" style.

Previously this layer would have made the entire page part of the
non-fast scrollable region. With this patch,
RenderLayer::allowScrolling() is used as a pre-requisite for expanding
the region, thus avoiding the problem.

  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::TEST_F):
(WebKit):

  • tests/data/clipped-body.html: Added.
3:07 PM Changeset in webkit [130691] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit/chromium

Mac Chromium: Ignore system numpad modifier
https://bugs.webkit.org/show_bug.cgi?id=97161

Patch by Sailesh Agrawal <sail@chromium.org> on 2012-10-08
Reviewed by Tony Chang.

On Mac, arrow key events have numpad modifier set. This is inconsistent with other platforms.

My fix is to only rely on keycode to decide when to set the numpad modifier.

This code is not exersided by layout tests so I added a new unit test for this.

  • WebKit.gypi:
  • WebKitUnitTests.gyp:
  • src/mac/WebInputEventFactory.mm:

(WebKit::isKeypadEvent): Removed check for numpad modifier.

  • tests/WebInputEventFactoryTestMac.mm: Added.

(TEST): Added new test for WebInputEventFactory::keyboardEvent().

3:06 PM Changeset in webkit [130690] by dpranke@chromium.org
  • 7 edits in trunk/Tools

nrwt: [chromium] run http tests in parallel on bigger machines
https://bugs.webkit.org/show_bug.cgi?id=98562

Reviewed by Eric Seidel.

The "locked tests" shard (which includes the http tests and the
perf tests) is the long pole on machines where we have 4 or more
workers, so we should start making sure that
we can run http tests in parallel, following the normal sharding
rules (all tests in the same directory are in the same shard by
default). We should still probably limit the number of workers
hitting the web server in parallel where we can; a heuristic of
no more than 25% of them seems okay for a start. This will
likely only affect developer workstations and a couple of bots
at first, so should be low risk and a good reward.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.default_max_locked_shards):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.default_max_locked_shards):

  • Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:

(ChromiumPortTestCase.test_default_max_locked_shards):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_default_max_locked_shards):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_max_locked_shards):

2:55 PM Changeset in webkit [130689] by Simon Fraser
  • 132 edits in trunk

Move layerTreeAsText to window.internals
https://bugs.webkit.org/show_bug.cgi?id=98690

Reviewed by James Robinson.

Add window.internals.layerTreeAsText(document), and change the tests to use it.
I'll remove testRunner.layerTreeAsText() in a later patch.

Source/WebCore:

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

  • compositing/animation/animation-compositing.html:
  • compositing/backing/no-backing-for-clip-overlap.html:
  • compositing/backing/no-backing-for-clip.html:
  • compositing/backing/no-backing-for-perspective.html:
  • compositing/bounds-in-flipped-writing-mode.html:
  • compositing/clip-child-by-non-stacking-ancestor.html:
  • compositing/columns/composited-in-paginated.html:
  • compositing/geometry/ancestor-overflow-change.html:
  • compositing/geometry/bounds-clipped-composited-child.html:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant.html:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html:
  • compositing/geometry/bounds-ignores-hidden-dynamic.html:
  • compositing/geometry/bounds-ignores-hidden.html:
  • compositing/geometry/clip.html:
  • compositing/geometry/composited-in-columns.html:
  • compositing/geometry/fixed-position-composited-switch.html:
  • compositing/geometry/flipped-writing-mode.html:
  • compositing/geometry/foreground-layer.html:
  • compositing/geometry/layer-due-to-layer-children-deep-switch.html:
  • compositing/geometry/layer-due-to-layer-children-switch.html:
  • compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
  • compositing/geometry/limit-layer-bounds-fixed-positioned.html:
  • compositing/geometry/limit-layer-bounds-opacity-transition.html:
  • compositing/geometry/limit-layer-bounds-overflow-root.html:
  • compositing/geometry/limit-layer-bounds-positioned-transition.html:
  • compositing/geometry/limit-layer-bounds-positioned.html:
  • compositing/geometry/limit-layer-bounds-transformed-overflow.html:
  • compositing/geometry/limit-layer-bounds-transformed.html:
  • compositing/geometry/preserve-3d-switching.html:
  • compositing/iframes/become-composited-nested-iframes.html:
  • compositing/iframes/become-overlapped-iframe.html:
  • compositing/iframes/composited-parent-iframe.html:
  • compositing/iframes/connect-compositing-iframe-delayed.html:
  • compositing/iframes/connect-compositing-iframe.html:
  • compositing/iframes/connect-compositing-iframe2.html:
  • compositing/iframes/connect-compositing-iframe3.html:
  • compositing/iframes/enter-compositing-iframe.html:
  • compositing/iframes/iframe-resize.html:
  • compositing/iframes/iframe-size-from-zero.html:
  • compositing/iframes/iframe-size-to-zero.html:
  • compositing/iframes/iframe-src-change.html:
  • compositing/iframes/invisible-nested-iframe-hide.html:
  • compositing/iframes/invisible-nested-iframe-show.html:
  • compositing/iframes/leave-compositing-iframe.html:
  • compositing/iframes/overlapped-iframe-iframe.html:
  • compositing/iframes/overlapped-iframe.html:
  • compositing/iframes/overlapped-nested-iframes.html:
  • compositing/iframes/page-cache-layer-tree.html:
  • compositing/iframes/resizer.html:
  • compositing/iframes/scrolling-iframe.html:
  • compositing/images/clip-on-directly-composited-image.html:
  • compositing/layer-creation/animation-overlap-with-children.html:
  • compositing/layer-creation/fixed-position-and-transform.html:
  • compositing/layer-creation/fixed-position-out-of-view.html:
  • compositing/layer-creation/fixed-position-under-transform.html:
  • compositing/layer-creation/no-compositing-for-preserve-3d.html:
  • compositing/layer-creation/overflow-scroll-overlap.html:
  • compositing/layer-creation/overlap-animation.html:
  • compositing/layer-creation/overlap-child-layer.html:
  • compositing/layer-creation/overlap-clipping.html:
  • compositing/layer-creation/overlap-transformed-and-clipped.html:
  • compositing/layer-creation/overlap-transformed-layer.html:
  • compositing/layer-creation/overlap-transforms.html:
  • compositing/layer-creation/rotate3d-overlap.html:
  • compositing/layer-creation/scroll-partial-update.html:
  • compositing/layer-creation/spanOverlapsCanvas.html:
  • compositing/layer-creation/stacking-context-overlap-nested.html:
  • compositing/layer-creation/stacking-context-overlap.html:
  • compositing/layer-creation/translatez-overlap.html:
  • compositing/overflow-trumps-transform-style.html:
  • compositing/overflow/clip-descendents.html:
  • compositing/overflow/content-gains-scrollbars.html:
  • compositing/overflow/content-loses-scrollbars.html:
  • compositing/overflow/overflow-auto-with-touch-no-overflow.html:
  • compositing/overflow/overflow-auto-with-touch-toggle.html:
  • compositing/overflow/overflow-auto-with-touch.html:
  • compositing/overflow/overflow-hidden-with-touch.html:
  • compositing/overflow/overflow-overlay-with-touch-no-overflow.html:
  • compositing/overflow/overflow-overlay-with-touch.html:
  • compositing/overflow/overflow-scroll-with-touch-no-overflow.html:
  • compositing/overflow/overflow-scrollbar-layers.html:
  • compositing/overflow/overflow-visible-with-touch.html:
  • compositing/overflow/resize-painting.html:
  • compositing/overflow/scrolling-content-clip-to-viewport.html:
  • compositing/overflow/textarea-scroll-touch.html:
  • compositing/plugins/1x1-composited-plugin.html:
  • compositing/plugins/large-to-small-composited-plugin.html:
  • compositing/plugins/no-backing-store.html:
  • compositing/plugins/small-to-large-composited-plugin.html:
  • compositing/rtl/rtl-absolute-overflow-scrolled.html:
  • compositing/rtl/rtl-absolute-overflow.html:
  • compositing/rtl/rtl-absolute.html:
  • compositing/rtl/rtl-fixed-overflow-scrolled.html:
  • compositing/rtl/rtl-fixed-overflow.html:
  • compositing/rtl/rtl-fixed.html:
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html:
  • compositing/rtl/rtl-iframe-absolute-overflow.html:
  • compositing/rtl/rtl-iframe-absolute.html:
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html:
  • compositing/rtl/rtl-iframe-fixed-overflow.html:
  • compositing/rtl/rtl-iframe-fixed.html:
  • compositing/rtl/rtl-iframe-relative.html:
  • compositing/rtl/rtl-relative.html:
  • compositing/tiled-layers-hidpi.html:
  • compositing/tiling/crash-reparent-tiled-layer.html:
  • compositing/tiling/huge-layer-add-remove-child.html-disabled:
  • compositing/tiling/huge-layer-img.html-disabled:
  • compositing/tiling/huge-layer-resize.html-disabled:
  • compositing/tiling/huge-layer-with-layer-children-resize.html-disabled:
  • compositing/tiling/huge-layer-with-layer-children.html-disabled:
  • compositing/tiling/huge-layer.html-disabled:
  • compositing/video/video-poster.html:
  • compositing/visibility/layer-visible-content.html:
  • compositing/visibility/visibility-image-layers-dynamic.html:
  • css3/compositing/should-have-compositing-layer.html:
  • css3/filters/composited-during-animation-layertree.html:
  • css3/filters/composited-during-transition-layertree.html:
  • css3/filters/filtered-compositing-descendant.html:
  • css3/filters/should-not-have-compositing-layer.html:
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html:
  • platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
  • platform/mac/compositing/canvas/accelerated-canvas-compositing.html:
2:27 PM Changeset in webkit [130688] by jonlee@apple.com
  • 17 edits
    2 adds in trunk/Source/WebCore

Add render object that paints plugin snapshots
https://bugs.webkit.org/show_bug.cgi?id=98322
<rdar://problem/12426546>

Reviewed by Simon Fraser.

First, teach plugins to maintain a set of states when plugin snapshotting is enabled.

Second, a new RenderSnapshottedPlugIn class is a RenderEmbeddedObject that knows how to paint
snapshots when the plugin is not visibly playing. It maintains a RenderImageResource to
the generated poster image.

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::HTMLPlugInElement): By default all plugins play on load.

  • html/HTMLPlugInElement.h: Move the inheritance of ImageLoaderClientBase down to

HTMLPlugInImageElement, since that is the class that actually deals with image-based plugins.
(WebCore::HTMLPlugInElement::displayState): Add bit for display state.
(WebCore::HTMLPlugInElement::setDisplayState):
(WebCore::HTMLPlugInElement::updateSnapshot):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): If plugin snapshotting is
enabled, plugin state is set to wait for a poster image.
(WebCore::HTMLPlugInImageElement::createRenderer): Create RenderSnapshottedPlugIn if
plugin snapshotting is enabled.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Once a snapshot is available, update the
renderer and set its state to wait for user input to start the plugin.

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isSnapshottedPlugIn): Add new function to identify
RenderSnapshottedPlugIn instances. Since RenderSnapshottedPlugIn inherits from
RenderEmbeddedObject, isEmbeddedObject() still returns true.

  • rendering/RenderEmbeddedObject.h:

(RenderEmbeddedObject): Elevate a few virtual methods to protected for
RenderSnapshottedPlugIn to override.

  • rendering/RenderSnapshottedPlugIn.cpp: Added.

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): Initialize snapshot
resource.
(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn): Shut down snapshot
image resource to remove the renderer as a client, and remove image from memory cache.
(WebCore::RenderSnapshottedPlugIn::plugInImageElement): Convenience function to get the
HTML element.
(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Cache the snapshot, and repaint.
(WebCore::RenderSnapshottedPlugIn::paint): If the plugin is not playing, paint like a
RenderImage does.
(WebCore::RenderSnapshottedPlugIn::paintReplaced): Paint the snapshot and overlay if the
plugin is not playing.
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot): Inspired by
RenderImage::paintReplaced() and RenderImage::paintIntoRect().

  • rendering/RenderSnapshottedPlugIn.h: Added.

(WebCore::RenderSnapshottedPlugIn::isSnapshottedPlugin): Returns true.

  • rendering/RenderTheme.h: Add a function that paints the overlay on top of the snapshot.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintPlugInSnapshotOverlay):

  • WebCore.xcodeproj/project.pbxproj: Add new RenderSnapshottedPlugIn class.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • rendering/RenderingAllInOne.cpp: Ditto.
2:20 PM Changeset in webkit [130687] by commit-queue@webkit.org
  • 10 edits
    13 adds in trunk

[CSS Exclusions] Add support for polygonal shapes
https://bugs.webkit.org/show_bug.cgi?id=96811

Patch by Hans Muller <hmuller@adobe.com> on 2012-10-08
Reviewed by Dirk Schulze.

Source/WebCore:

Initial version of the layout support for polygonal exclusion shapes: the ExclusionPolygon class.
Supports the public ExclusionShape operations using the algorithm described here:
http://hansmuller-webkit.blogspot.com/2012/06/horizontal-box-polygon-intersection-for.html.
Although both the "included" and "excluded" operations are supported, only the former is
used, since only shape-inside is supported at the moment.

The ExclusionPolygon class stores the polygon's edges in an interval tree.

Polygon edges are represented by the ExclusionPolygonEdge struct, which records the indices of
the pair of vertices joined by the edge. Edge vertex index1 is usually less than index2, except
the last edge where index2 is 0. We plan to improve the algorithm that creates the edges
by spanning vertices contained in sequences of more than two colinear vertices. For example,
a triangular polygon might be specified with 5 vertices like this: 3,0 5,0, 5,5, 4,4 2,2, 0,0.
By spanning the extra colinear points: 0,0 5,0, 5,5, which implies index1-index2 edges: 5-1 1-2 2-5.

Although the implementation supports complex polygons, the layout code is limited to
essentially rectangular shapes until a patch for https://bugs.webkit.org/show_bug.cgi?id=96813
lands.

Tests: fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html

fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html
fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html
fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html
fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/ExclusionPolygon.cpp: Added.

(WebCore):
(EdgeIntersection): Internal description of the intersection of a polygon edge and a horizontal line.
(WebCore::ExclusionPolygon::ExclusionPolygon): See the introductory text above for a description of this type.
(WebCore::computeXIntersection): Find and classify the X intercept of a polygon edge with horizontal line, if any.
(WebCore::ExclusionPolygon::rightVertexY): This method is used to decide if a horizontal line "crosses" a vertex.
(WebCore::appendIntervalX): Append an x coordinate to a vector of ExclusionIntervals.
(WebCore::ExclusionPolygon::computeXIntersections): Return a vector of the intersections of a horizontal line with the polygon's edges.
(WebCore::ExclusionPolygon::computeEdgeIntersections): Return a vector of the X projections of the edges that overlap a horizonal rectangle.
(WebCore::ExclusionPolygon::getExcludedIntervals): Return a SegmentList of the X intervals within a horizontal rectangle that overlap the polygon.
(WebCore::ExclusionPolygon::getIncludedIntervals): Return the X intervals within a horizontal rectangle that fit inside the polygon.

  • rendering/ExclusionPolygon.h: Added.

(WebCore):
(ExclusionPolygon):
(WebCore::ExclusionPolygon::getXAt): X coordinate of a polygon vertex
(WebCore::ExclusionPolygon::getYAt): Y coordinate of a polygon vertex
(WebCore::ExclusionPolygon::numberOfVertices):
(WebCore::ExclusionPolygon::fillRule): A WindRule value that defines "inside" for self-intersecting polygons.
(ExclusionPolygonEdge):
(WebCore::ExclusionPolygonEdge::ExclusionPolygonEdge):
(WebCore::ExclusionPolygonEdge::vertex1):
(WebCore::ExclusionPolygonEdge::vertex2):
(WebCore::ExclusionPolygonEdge::minX):
(WebCore::ExclusionPolygonEdge::minY):
(WebCore::ExclusionPolygonEdge::maxX):
(WebCore::ExclusionPolygonEdge::maxY):

  • rendering/ExclusionShape.cpp:

(WebCore::createExclusionPolygon): Return a new ExclusionPolygon.
(WebCore):
(WebCore::ExclusionShape::createExclusionShape): Added support for BasicShape::BASIC_SHAPE_POLYGON.

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock): Enable BASIC_SHAPE_POLYGON shapes for RenderBlocks.

LayoutTests:

Verify that a rectangular shape-inside specified as a polygon works as expected for all
writing-modes.

Added exclusions tests for non-complex concave shape-inside polygons as well.
The shapes in this set of tests are "rectangular" in the sense that
horizontal lines that overlap the polygon only cross the polygon twice.
The expected part of each test uses float "sandbags" to simulate the
shape-inside area in the test expectations. The tests use SVG to
display the polygon itself, to simplify visual inspection.
(See http://www.alistapart.com/articles/sandbags/).

  • fast/exclusions/shape-inside/shape-inside-polygon-rectangle-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html: Added.
  • fast/exclusions/resources/simple-polygon.js: Added.

(createPolygon):
(polygonXIntercepts):
(generatePolygonContentString):
(simulatePolygonShape):
(generateSimulatedPolygonShapeInsideElement):
(positionInformativeText):
(createPolygonShapeInsideTestCase):
(createPolygonShapeInsideTestCaseExpected):

  • fast/exclusions/shape-inside/shape-inside-simple-polygon-001-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-002-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-003-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-004-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html: Added.
2:16 PM Changeset in webkit [130686] by tony@chromium.org
  • 5 edits in trunk/Source/WebCore

Replace 2 uses of updateLogicalHeight with computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=98677

Reviewed by Ojan Vafai.

This is part of bug 96804. Convert RenderTextControl and RenderSVGForeignObject to
override the const computeLogicalHeight method rather than the updateLogicalHeight
setter method.

No new tests, there should be no behavior change as this is just a refactor.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeLogicalHeight): Pass logicalHeight through rather than setting height.
This is a slight correctness fix, although we don't support vertical inputs yet.

  • rendering/RenderTextControl.h:

(RenderTextControl):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::computeLogicalHeight):

  • rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

2:16 PM Changeset in webkit [130685] by Csaba Osztrogonác
  • 2 edits
    8 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add PNGs after r130653,
and skip tests on Qt-WK2, because they fail on it.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-text2-expected.png: Added.
2:10 PM Changeset in webkit [130684] by jchaffraix@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

Unreviewed Chromium gardening.

Rebaselined those 2 tables/ tests that were forgotten in the rebaselining after r103875.
https://bugs.webkit.org/show_bug.cgi?id=74888 was opened to track those rebaselining but
it looks like some platform fell through the cracks.

  • platform/chromium/TestExpectations:

Removed the 2 entries.

  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions1-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions2-expected.txt: Added.

Progression: the table captions are larger, which matches other browsers and other platforms' baselines.

1:58 PM Changeset in webkit [130683] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Upstream some tweaks for overlay play button on Android
https://bugs.webkit.org/show_bug.cgi?id=98671

Patch by Min Qin <qinmin@chromium.org> on 2012-10-08
Reviewed by Adam Barth.

This change stops displaying the overlay play button if video height is too small
No test for this. Will rebase layout test expectations for android later.

  • css/mediaControlsChromiumAndroid.css:

(video::-webkit-media-controls-overlay-enclosure):

1:54 PM Changeset in webkit [130682] by zandobersek@gmail.com
  • 4 edits in trunk

GTK port should warn if bug modifier is missing in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=98678

Reviewed by Dirk Pranke.

Tools:

Reimplement the warn_if_bug_missing_in_test_expectations method in
GtkPort, returning True for producing a warning in such cases.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.warn_if_bug_missing_in_test_expectations):

LayoutTests:

Add generic Bug(GTK) modifiers for two test expectations.

  • platform/gtk/TestExpectations:
1:48 PM Changeset in webkit [130681] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress editing/pasteboard/data-transfer-items.html failure.
https://bugs.webkit.org/show_bug.cgi?id=98686

Unreviewed, expectations change.

  • platform/chromium/TestExpectations:
1:47 PM Changeset in webkit [130680] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Add missing compile flag for compositing
https://bugs.webkit.org/show_bug.cgi?id=98681

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-10-08
Reviewed by Dirk Schulze.

This flag is needed in case there is a difference in API
when compositing is enabled

  • Configurations/FeatureDefines.xcconfig:
1:26 PM Changeset in webkit [130679] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed rebaselining after r130598 and r130600.

  • platform/chromium-linux-x86/svg/filters/filterRes-expected.txt:

This baseline was forgotten.

1:24 PM Changeset in webkit [130678] by eae@chromium.org
  • 4 edits
    3 copies in branches/chromium/1271

Merge 130329 - Round image sizes when zooming
https://bugs.webkit.org/show_bug.cgi?id=98205

Reviewed by Eric Seidel.

Source/WebCore:

We currently floor image sizes when zooming which can result in
images being rendered at one pixel less than the actual size.
This is especially likely to happen for very large images.

Test: fast/sub-pixel/zoomed-image-tiles.html

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

LayoutTests:

Add test for zoomed large image tiles.

  • fast/images/zoomed-img-size.html:
  • fast/sub-pixel/zoomed-image-tiles-expected.html: Added.
  • fast/sub-pixel/zoomed-image-tiles.html: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium/fast/images/zoomed-img-size-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/mac-lion/TestExpectations:
  • platform/mac-snowleopard/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win-wk2/TestExpectations:
  • platform/win-xp/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:

TBR=eae@chromium.org

1:22 PM Changeset in webkit [130677] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=98663

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Laszlo Gombos.

EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test was
failing because the elements of a list were checked in a given
order but the list was not sorted beforehand.

  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(sortHostNames):
(TEST_F):

1:10 PM Changeset in webkit [130676] by Simon Fraser
  • 16 edits in trunk/Source

Some GraphicsLayer cleanup to separate the concepts of using a tile cache, and being the main tile cache layer
https://bugs.webkit.org/show_bug.cgi?id=98574

Reviewed by Dean Jackson.

GraphicsLayerCA assumed that using a TileCache equated to being the main page tile
cache layer, which has some special considerations. Make these two concepts separate
to get closer to being able to use TileCaches in place of CATiledLayer.

Source/WebCore:

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer): Remove m_usingTileCache member, which was not appropriate
for this class to have.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer): Remove init of m_usingTileCache.
(WebCore::GraphicsLayer::debugBorderInfo): Can no longer use m_usingTileCache to
get the blue color, so moved code into a virtual debugBorderInfo() method.
(WebCore::GraphicsLayer::updateDebugIndicators): Call the virtual debugBorderInfo().

  • platform/graphics/GraphicsLayerClient.h: Remove the usingTileCache() callback;

we now just cache this information in the GraphicsLayerCA on creation.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA): Init m_isPageTileCacheLayer to false,
then set to m_isPageTileCacheLayer if the client says we should create a tile cache.
(WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter): Overidden to avoid duplicate repaint
counters in the top-left tile.
(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): If this layer is the page tile cache layer,
we allow setting of its background color.
(WebCore::GraphicsLayerCA::debugBorderInfo): Overidden to use a blue color for tiles.
(WebCore::GraphicsLayerCA::requiresTiledLayer): Don't make CATiledLayers for the page tile cache.

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/PlatformCALayerClient.h:

(PlatformCALayerClient): Need to pass the platform layer into platformCALayerShowRepaintCounter()
so we can distinguish between calls for tiles, and calls for the tile cache layer itself.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::shouldShowRepaintCounters): Pass 0 to platformCALayerShowRepaintCounter() to
indicate that we're asking about a tile.

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents): Now we can just rely on platformCALayerShowRepaintCounter() to tell us whether
to draw the repaint counter.
(-[WebLayer setNeedsDisplayInRect:]):

  • platform/graphics/mac/WebTiledLayer.mm:

(-[WebTiledLayer setNeedsDisplayInRect:]):

  • rendering/RenderLayerBacking.h:

(WebCore::RenderLayerBacking::usingTileCache):
(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::documentBackgroundColorDidChange): We can ask the RenderLayerBacking
whether it's for the tile cache, rather than going to the GraphicsLayer.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerShowRepaintCounter):

Source/WebKit/win:

  • FullscreenVideoController.cpp:

(FullscreenVideoController::LayerClient::platformCALayerShowRepaintCounter):

12:46 PM Changeset in webkit [130675] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] new test introduced in r120354 fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=91968

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Unskipping test.

  • platform/qt/TestExpectations:
12:33 PM Changeset in webkit [130674] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-08

  • DEPS:
12:18 PM Changeset in webkit [130673] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

[EFL][DRT] Switch default backing store to single
https://bugs.webkit.org/show_bug.cgi?id=98591

Reviewed by Eric Seidel.

There are two backing stores for WebKit/Efl, Single Backing Store(SBS) and
Tiled Backing Store(TBS), and DRT/Efl has used TBS.
But, TBS is not suitable to run pixel tests because it does not have a good way
to render mock scrollbars well.

So, this patch changes the default backing store to SBS.
In addition, this changes the environment variable from DRT_USE_SINGLE_BACKING_STORE
to DRT_USE_TILED_BACKING_STORE.

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(shouldUseTiledBackingStore):
(chooseAndInitializeAppropriateSmartClass):

12:14 PM Changeset in webkit [130672] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt] Make ImageBufferQt use premultiplied converting functions in Color.h instead of its own mechanism.
https://bugs.webkit.org/show_bug.cgi?id=98582

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-08
Reviewed by Eric Seidel.

Source/WebCore:

Only Qt port failed canvas/philip/tests/2d.imageData.put.unchanged.html because
ImageBufferQt converts from or to a premultiplied color using its own code. When
we convert twice from an unmultiplied color to a premultiplied color and then to
an unmultiplied color using this code, the calculated result are pretty
different against the input color. It is why Gtk passes this test although Qt
fails. Gtk port uses them in Color.h.

In addition, Qt should use the functions in Color.h to reduce duplicated codes.

Tests: canvas/philip/tests/2d.imageData.put.unchanged.html: Fixed a test case

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::getImageData):
(WebCore::convertBGRAToRGBA):
(WebCore::ImageBuffer::putByteArray):

LayoutTests:

Unskipping canvas/philip/tests/2d.imageData.put.unchanged.html that is passing.

  • platform/qt/TestExpectations:
12:10 PM Changeset in webkit [130671] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Avoid useless converting to WKPage
https://bugs.webkit.org/show_bug.cgi?id=98516

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-08
Reviewed by Eric Seidel.

Use priv->pageProxy->findString() and priv->pageProxy->hideFindUI()
to avoid useless converting to WK.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):

12:07 PM Changeset in webkit [130670] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Fix video-test.js relativeURL() bug
https://bugs.webkit.org/show_bug.cgi?id=98546

Patch by Shadi Khalek <shadi@chromium.org> on 2012-10-08
Reviewed by Eric Seidel.

Some layout tests failed due to this bug (crbug.com/154157)

  • media/video-test.js:

(testArraysEqual):
(relativeURL):

12:02 PM Changeset in webkit [130669] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Perf test pesults page takes forever to load on a machine with a slow Internet connection
https://bugs.webkit.org/show_bug.cgi?id=98561

Reviewed by Ojan Vafai.

Try loading jquery both locally and remotely, and use the same method to load the remaining
jquery plugins when either one succeeds.

  • resources/results-template.html:
12:00 PM Changeset in webkit [130668] by commit-queue@webkit.org
  • 5 edits
    14 deletes in trunk

Remove "orphaned units" quirk
https://bugs.webkit.org/show_bug.cgi?id=98553

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-08
Reviewed by Eric Seidel.

This patch removes our "orphaned units" quirk.
We have an "orphaned units" quirk to match IE, which allows things like "width: 20 px;".
But FF and Opera don't have it and aren't aware of bugs for it,
and it's not in Simon Pieters' Quirks Mode spec <http://dvcs.w3.org/hg/quirks-mode/raw-file/tip/Overview.html>

No new tests, because I'm killing a quirk.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSParser.h:

(CSSParser):

11:57 AM Changeset in webkit [130667] by jchaffraix@webkit.org
  • 2 edits
    24 adds
    4 deletes in trunk/LayoutTests

Additional fast/repaint Chromium rebaseline.

Rebaselined more tests on Chromium Mac. Same as r130654 but there
is some anti-aliasing differences on transformed lines.

  • platform/chromium/TestExpectations:

Removed the rebaselined tests.

  • fast/repaint/table-section-repaint-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-outline-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/table-collapsed-border-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/text-append-dirty-lines-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/transform-relative-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/transform-repaint-descendants-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-outline-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-col-background-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-collapsed-border-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-outer-border-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-row-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-section-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-section-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-two-pass-layout-overpaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/text-append-dirty-lines-expected.png: Added.
  • platform/chromium-mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
  • platform/chromium-mac/fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/transform-absolute-child-expected.png: Added.
  • platform/chromium-mac/fast/repaint/transform-disable-layoutstate-expected.png: Added.
  • platform/chromium-mac/fast/repaint/transform-relative-position-expected.png: Added.
  • platform/chromium-mac/fast/repaint/transform-repaint-descendants-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-section-repaint-expected.txt: Removed.
  • platform/chromium/fast/repaint/table-section-repaint-expected.txt: Added.
  • platform/efl/fast/repaint/table-section-repaint-expected.txt: Removed.
  • platform/gtk/fast/repaint/table-section-repaint-expected.txt: Removed.
  • platform/qt/fast/repaint/table-section-repaint-expected.txt: Removed.
11:50 AM Changeset in webkit [130666] by zandobersek@gmail.com
  • 46 edits
    6 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining SVG tests after changes in r130599.

  • platform/gtk/TestExpectations:
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • platform/gtk/svg/batik/paints/gradientLimit-expected.png:
  • platform/gtk/svg/batik/paints/gradientLimit-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-expected.png:
  • platform/gtk/svg/batik/paints/patternRegions-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/batik/text/textEffect-expected.png:
  • platform/gtk/svg/batik/text/textEffect-expected.txt: Added.
  • platform/gtk/svg/batik/text/textEffect3-expected.png:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/gtk/svg/custom/gradient-deep-referencing-expected.png:
  • platform/gtk/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/gtk/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
  • platform/gtk/svg/custom/gradient-with-1d-boundingbox-expected.txt:
  • platform/gtk/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
  • platform/gtk/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
  • platform/gtk/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/gtk/svg/custom/radialGradient-focal-radius-expected.txt: Added.
  • platform/gtk/svg/custom/recursive-gradient-expected.png:
  • platform/gtk/svg/custom/recursive-gradient-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/gtk/svg/custom/stroked-pattern-expected.png:
  • platform/gtk/svg/custom/stroked-pattern-expected.txt:
  • platform/gtk/svg/hixie/perf/006-expected.png:
  • platform/gtk/svg/hixie/perf/006-expected.txt:
11:46 AM Changeset in webkit [130665] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

audiobuffer.html need to include audio-testing.js file.
https://bugs.webkit.org/show_bug.cgi?id=98641

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-08
Reviewed by Eric Seidel.

As we discussed at the bug https://bugs.webkit.org/show_bug.cgi?id=88624,
WebAudio tests need to include audio-testing.js file to set WebKitWebAudioEnabled.

  • webaudio/audiobuffer.html: Include audio-testing.js file.
11:46 AM Changeset in webkit [130664] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

After r130344, OpaqueJSString() creates an empty string which should be a null string
https://bugs.webkit.org/show_bug.cgi?id=98417

Reviewed by Sam Weinig.

Changed create() of a null string to return 0. This is the same behavior as before r130344.

  • API/OpaqueJSString.cpp:

(OpaqueJSString::create):

11:44 AM Changeset in webkit [130663] by robert@webkit.org
  • 3 edits
    2 adds in trunk

Border, margin and padding of an inline's inline ancestors counted twice
https://bugs.webkit.org/show_bug.cgi?id=63074

Reviewed by David Hyatt.

Source/WebCore:

In a line such as '<span><span><img>Text' the border, padding and margin belonging
to the two spans was counted twice by RenderBlockLineLayout::nextLineBreak(): once
when adding the width of the <img> object to the line, and a second time when adding
the 'Text'. The result was that nextLineBreak() now had a length for the line that
exceeded the line's maximum length and inserted a bogus line break.

This all happened because the helper function that is used to add in the border etc.
from inline ancestors was crawling up the tree each time. It doesn't need to do that, it
should stop crawling up the tree when the current object is not the first or last sibling below a parent.

Test: fast/inline/bpm-inline-ancestors.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::shouldAddBorderPaddingMargin): Broke this check out into a helper function so that it
can help inlineLogicalWidth() return early and also treat empty RenderTexts the same as no previous/next
sibling on the line. This ensures that collapsed leading space does not interfere with the decision to
crawl up the ancestors accumulating border, padding, and margin.
(WebCore):
(WebCore::inlineLogicalWidth): Return early once the current child is no longer on the edge of its line -
this ensures the border, padding and margin of ancestors is not counted twice.

LayoutTests:

  • fast/inline/bpm-inline-ancestors-expected.html: Added.
  • fast/inline/bpm-inline-ancestors.html: Added.
11:40 AM Changeset in webkit [130662] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2][WTR] WebKitTestRunner needs testRunner.dispatchPendingLoadRequests
https://bugs.webkit.org/show_bug.cgi?id=98638

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-08
Reviewed by Eric Seidel.

Source/WebKit2:

Add implementation for testRunner.dispatchPendingLoadRequests in
WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleDispatchPendingLoadRequests):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::dispatchPendingLoadRequests):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Add implementation for testRunner.dispatchPendingLoadRequests in
WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::dispatchPendingLoadRequests):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskip http/tests/loading/deleted-host-in-resource-load-delegate-callback.html

  • platform/wk2/TestExpectations:
11:37 AM Changeset in webkit [130661] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip http/tests/multipart/multipart-html.php while we wait for kov's patch.

  • platform/efl/TestExpectations:
11:37 AM Changeset in webkit [130660] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Add support for window.close in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98667

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Laszlo Gombos.

When calling window.close() from JavaScript, MiniBrowser
now closes the given window.

  • MiniBrowser/efl/main.c:

(window_close):
(on_ecore_evas_delete):
(on_close_window):
(window_create):

11:35 AM Changeset in webkit [130659] by ojan@chromium.org
  • 3 edits in trunk/Tools

Properly strip new tests from the test results json if they are pass/nodata/skip.
https://bugs.webkit.org/show_bug.cgi?id=98669

Reviewed by Eric Seidel.

In _merge_json, we had a codepath that didn't call _normalize_results_json
for tests that aren't already in the aggregated results.
Instead, now do all the merging first and then normalize the aggregated results.

  • TestResultServer/model/jsonresults.py:

(JsonResults._merge_json):
(JsonResults._merge_tests):
(JsonResults._normalize_results):
(JsonResults):
(JsonResults._should_delete_leaf):

  • TestResultServer/model/jsonresults_unittest.py:

Removed test_merge_build_directory_hierarchy_old_version since there is
no longer any version 3 json to support.
(JsonResultsTest.test_merge_remove_new_test):
(JsonResultsTest.test_merge_prune_extra_results_with_new_result_of_same_type):

11:23 AM Changeset in webkit [130658] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Simplify frame flattening support in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=98657

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Simplify frame flattening support code in MiniBrowser to
avoid passing the setting around to window_create()
function().

  • MiniBrowser/efl/main.c:

(on_key_down):
(on_new_window):
(window_create):
(main):

11:15 AM Changeset in webkit [130657] by mkwst@chromium.org
  • 4 edits
    2 adds in trunk

Null-check for DOMWindow before feeding it to FeatureObserver.
https://bugs.webkit.org/show_bug.cgi?id=98624

Reviewed by Adam Barth.

Source/WebCore:

We shouldn't call out to FeatureObserver in
ContentSecurityPolicy::didReceiveHeader if the policy's document doesn't
have a DOMWindow.

Test: http/tests/security/contentSecurityPolicy/xmlhttprequest-protected-resource-does-not-crash.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::didReceiveHeader):

Null check 'document->domWindow' before passing it on.

  • page/FeatureObserver.cpp:

(WebCore::FeatureObserver::observe):

ASSERT 'domWindow'.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/xmlhttprequest-protected-resource-does-not-crash-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/xmlhttprequest-protected-resource-does-not-crash.html: Added.

This test shouldn't crash.

11:10 AM Changeset in webkit [130656] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Add minimum version information for tool dependencies
https://bugs.webkit.org/show_bug.cgi?id=97592

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Capture the minimum version information for the tools that are required
to build the EFL port (or more generally WebKit).

  • CMakeLists.txt:
11:05 AM Changeset in webkit [130655] by tony@chromium.org
  • 13 edits
    5 deletes in trunk/LayoutTests

Unreviewed, new baseline for fast/table/colspanMinWidth-vertical.html.

The baseline changed in http://trac.webkit.org/changeset/130569 because
controls should all be horizontal.

  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.txt: Removed.
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/TestExpectations:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/qt/TestExpectations:
  • platform/qt/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/qt/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
10:54 AM Changeset in webkit [130654] by jchaffraix@webkit.org
  • 3 edits
    43 adds
    1 delete in trunk/LayoutTests

Unreviewed fast/repaint Chromium rebaselining.

Rebaselined those tests on Chromium Mac. The differences fall in 3 buckets:

  • the background has an alpha off-by-one (crbug.com/23473)
  • the repaint rectangles are united (the Mac baselines don't do the union).
  • On Lion, the font used is different.
  • platform/chromium/TestExpectations:

Removed the rebaselined tests' entries.

  • platform/chromium-mac-snowleopard/fast/repaint/bugzilla-5699-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/control-clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/create-layer-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/layout-state-only-positioned-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/list-marker-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/make-children-non-inline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/outline-child-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/outline-repaint-glitch-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-scroll-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/reflection-redraw-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/selection-after-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/static-to-positioned-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/table-cell-move-expected.png: Added.
  • platform/chromium-mac/fast/repaint/background-generated-expected.png: Added.
  • platform/chromium-mac/fast/repaint/bugzilla-5699-expected.png: Added.
  • platform/chromium-mac/fast/repaint/content-into-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/control-clip-expected.png: Added.
  • platform/chromium-mac/fast/repaint/control-clip-expected.txt:
  • platform/chromium-mac/fast/repaint/create-layer-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/intermediate-layout-position-clip-expected.png: Added.
  • platform/chromium-mac/fast/repaint/intermediate-layout-position-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layout-state-only-positioned-expected.png: Added.
  • platform/chromium-mac/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
  • platform/chromium-mac/fast/repaint/line-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/list-marker-2-expected.png: Added.
  • platform/chromium-mac/fast/repaint/make-children-non-inline-expected.png: Added.
  • platform/chromium-mac/fast/repaint/outline-child-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/outline-inset-expected.png: Added.
  • platform/chromium-mac/fast/repaint/outline-repaint-glitch-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-into-content-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-scroll-delete-expected.png: Added.
  • platform/chromium-mac/fast/repaint/reflection-redraw-expected.png: Added.
  • platform/chromium-mac/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/selection-after-delete-expected.png: Added.
  • platform/chromium-mac/fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
  • platform/chromium-mac/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/chromium-mac/fast/repaint/static-to-positioned-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Added.
  • platform/chromium-win/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
  • platform/mac-lion/fast/repaint: Removed.
  • platform/mac-lion/fast/repaint/control-clip-expected.txt: Removed.
10:21 AM Changeset in webkit [130653] by allan.jensen@digia.com
  • 2 edits
    8 adds in trunk/LayoutTests

[Qt] Add baselines to passing ruby DOM tests.

Unreviewed gardening.

  • platform/qt/TestExpectations:
  • platform/qt/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-insert-text2-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-rt2-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
  • platform/qt/fast/ruby/rubyDOM-remove-text2-expected.txt: Added.
10:13 AM Changeset in webkit [130652] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL] Use Ctrl+n shortcut to create a new window in MiniBrowser / EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=98655

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Use "Ctrl+n" shortcut instead of "F9" to open a new window in
MiniBrowser and EWebLauncher. This is the shortcut that is
commonly used for this action.

  • EWebLauncher/main.c:

(on_key_down):

  • MiniBrowser/efl/main.c:

(on_key_down):

10:08 AM Changeset in webkit [130651] by Nate Chapin
  • 6 edits
    2 adds in trunk

Source/WebCore: Loader cleanup : Simplify FrameLoader/DocumentLoader setupForReplace()
https://bugs.webkit.org/show_bug.cgi?id=49072

Reviewed by Eric Seidel.

This patch contains one small known behavior change: multipart/x-mixed-replace main resources with text/html parts
will no longer load the text/html progressively. In practice, loading the html progressively causes the document
to get cleared as soon as the next part's data starts arriving, which leads to a blank page most of the time. This case
seems to be pathological, as IE, FF, Opera and WebKit all do something different currently. This patch will cause
us to behave like Firefox, which is the most sane of the current behaviors.

Test: http/tests/multipart/multipart-html.php

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData): Use isMultipartReplacingLoad() helper.
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::setupForReplace): Renamed from setupForReplaceByMIMEType(). Call maybeFinishLoadingMultipartContent()

instead of doing identical work inline. After we call frameLoader()->setReplacing(), we will never load progressively, so remove
the if (doesProgressiveLoad(newMIMEType)) {} block.

(WebCore::DocumentLoader::isMultipartReplacingLoad):
(WebCore::DocumentLoader::maybeFinishLoadingMultipartContent): Inline the old DocumentLoader::setupForeReplace(), check

frameLoader()->isReplacing() instead of the delete doesProgressiveLoad().

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setupForReplace): Move all calls to revertToProvisionalState here.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse): Call setupForReplace(), renamed from setupForReplaceByMIMEType().

LayoutTests: Add a test for multipart/x-mixed-replace documents with text/html
parts.
https://bugs.webkit.org/show_bug.cgi?id=49072

Reviewed by Eric Seidel.

  • http/tests/multipart/multipart-html-expected.txt: Added.
  • http/tests/multipart/multipart-html.php: Added.
10:06 AM Changeset in webkit [130650] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip svg/text/caret-in-svg-text.xhtml in WK1.

  • platform/efl-wk1/TestExpectations:
10:02 AM LayoutUnit edited by eae@chromium.org
Updated article to reflect that we now use 1/64 instead of 1/60. (diff)
9:53 AM Changeset in webkit [130649] by jchaffraix@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

Unreviewed gardening after r130587.

Per discussion with Adam, this change lands the failing baselines to
get some coverage until V8 matches JSC. Fixing the baselines is
covered by https://bugs.webkit.org/show_bug.cgi?id=98658

  • platform/chromium/TestExpectations:

Marked one of test as SLOW as it is timing out in Debug.

  • platform/chromium/fast/dom/gc-12-expected.txt: Added.
  • platform/chromium/fast/dom/gc-3-expected.txt: Added.
  • platform/chromium/fast/dom/gc-5-expected.txt: Added.
  • platform/chromium/fast/dom/gc-dom-tree-lifetime-expected.txt: Added.
9:50 AM Changeset in webkit [130648] by allan.jensen@digia.com
  • 5 edits in trunk/LayoutTests

Unreviewed Qt gardening.

Rebaseline Qt expectations for these passing tests.

  • platform/qt/TestExpectations:
  • platform/qt/fast/text/basic/013-expected.txt:
  • platform/qt/fast/text/basic/015-expected.txt:
  • platform/qt/fast/text/line-breaks-expected.txt:
9:45 AM Changeset in webkit [130647] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark fast/dynamic/window-scrollbars-test.html as flaky.

  • platform/efl/TestExpectations:
9:33 AM Changeset in webkit [130646] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Add support for window.create in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98649

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Calling window.create() from JavaScript now creates a
new window in Minibrowser, as directed.

  • MiniBrowser/efl/main.c:

(on_new_window):
(window_create):

9:14 AM Changeset in webkit [130645] by rakuco@webkit.org
  • 2 edits
    128 adds in trunk/LayoutTests

[EFL] Unskip svg/text.

Most of the text cases are passing, the ones which don't have been
properly skipped.

  • platform/efl/TestExpectations:
  • platform/efl/svg/text/append-text-node-to-tspan-expected.png: Added.
  • platform/efl/svg/text/append-text-node-to-tspan-expected.txt: Added.
  • platform/efl/svg/text/bidi-embedded-direction-expected.png: Added.
  • platform/efl/svg/text/bidi-embedded-direction-expected.txt: Added.
  • platform/efl/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/efl/svg/text/bidi-reorder-value-lists-expected.txt: Added.
  • platform/efl/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/efl/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/efl/svg/text/bidi-text-query-expected.png: Added.
  • platform/efl/svg/text/bidi-text-query-expected.txt: Added.
  • platform/efl/svg/text/bidi-tspans-expected.png: Added.
  • platform/efl/svg/text/bidi-tspans-expected.txt: Added.
  • platform/efl/svg/text/ems-display-none-expected.png: Added.
  • platform/efl/svg/text/ems-display-none-expected.txt: Added.
  • platform/efl/svg/text/exs-display-none-expected.png: Added.
  • platform/efl/svg/text/exs-display-none-expected.txt: Added.
  • platform/efl/svg/text/font-size-below-point-five-2-expected.png: Added.
  • platform/efl/svg/text/font-size-below-point-five-2-expected.txt: Added.
  • platform/efl/svg/text/font-size-below-point-five-expected.png: Added.
  • platform/efl/svg/text/font-size-below-point-five-expected.txt: Added.
  • platform/efl/svg/text/foreignObject-repaint-expected.png: Added.
  • platform/efl/svg/text/foreignObject-repaint-expected.txt: Added.
  • platform/efl/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
  • platform/efl/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.
  • platform/efl/svg/text/kerning-expected.png: Added.
  • platform/efl/svg/text/kerning-expected.txt: Added.
  • platform/efl/svg/text/modify-text-node-in-tspan-expected.png: Added.
  • platform/efl/svg/text/modify-text-node-in-tspan-expected.txt: Added.
  • platform/efl/svg/text/multichar-glyph-expected.png: Added.
  • platform/efl/svg/text/multichar-glyph-expected.txt: Added.
  • platform/efl/svg/text/remove-text-node-from-tspan-expected.png: Added.
  • platform/efl/svg/text/remove-text-node-from-tspan-expected.txt: Added.
  • platform/efl/svg/text/remove-tspan-from-text-expected.png: Added.
  • platform/efl/svg/text/remove-tspan-from-text-expected.txt: Added.
  • platform/efl/svg/text/scaled-font-expected.png: Added.
  • platform/efl/svg/text/scaled-font-expected.txt: Added.
  • platform/efl/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/efl/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
  • platform/efl/svg/text/selection-background-color-expected.png: Added.
  • platform/efl/svg/text/selection-background-color-expected.txt: Added.
  • platform/efl/svg/text/selection-styles-expected.png: Added.
  • platform/efl/svg/text/selection-styles-expected.txt: Added.
  • platform/efl/svg/text/small-fonts-2-expected.png: Added.
  • platform/efl/svg/text/small-fonts-2-expected.txt: Added.
  • platform/efl/svg/text/small-fonts-3-expected.png: Added.
  • platform/efl/svg/text/small-fonts-3-expected.txt: Added.
  • platform/efl/svg/text/small-fonts-expected.png: Added.
  • platform/efl/svg/text/small-fonts-in-html5-expected.png: Added.
  • platform/efl/svg/text/small-fonts-in-html5-expected.txt: Added.
  • platform/efl/svg/text/text-align-01-b-expected.png: Added.
  • platform/efl/svg/text/text-align-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-align-02-b-expected.png: Added.
  • platform/efl/svg/text/text-align-02-b-expected.txt: Added.
  • platform/efl/svg/text/text-align-03-b-expected.png: Added.
  • platform/efl/svg/text/text-align-03-b-expected.txt: Added.
  • platform/efl/svg/text/text-align-04-b-expected.png: Added.
  • platform/efl/svg/text/text-align-04-b-expected.txt: Added.
  • platform/efl/svg/text/text-align-05-b-expected.png: Added.
  • platform/efl/svg/text/text-align-05-b-expected.txt: Added.
  • platform/efl/svg/text/text-align-06-b-expected.png: Added.
  • platform/efl/svg/text/text-align-06-b-expected.txt: Added.
  • platform/efl/svg/text/text-altglyph-01-b-expected.png: Added.
  • platform/efl/svg/text/text-altglyph-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-deco-01-b-expected.png: Added.
  • platform/efl/svg/text/text-deco-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-fill-opacity-expected.png: Added.
  • platform/efl/svg/text/text-fill-opacity-expected.txt: Added.
  • platform/efl/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/efl/svg/text/text-fonts-01-t-expected.txt: Added.
  • platform/efl/svg/text/text-fonts-02-t-expected.png: Added.
  • platform/efl/svg/text/text-fonts-02-t-expected.txt: Added.
  • platform/efl/svg/text/text-gradient-positioning-expected.png: Added.
  • platform/efl/svg/text/text-gradient-positioning-expected.txt: Added.
  • platform/efl/svg/text/text-hkern-expected.png: Added.
  • platform/efl/svg/text/text-hkern-expected.txt: Added.
  • platform/efl/svg/text/text-hkern-on-vertical-text-expected.png: Added.
  • platform/efl/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
  • platform/efl/svg/text/text-intro-05-t-expected.png: Added.
  • platform/efl/svg/text/text-intro-05-t-expected.txt: Added.
  • platform/efl/svg/text/text-midpoint-split-bug-expected.png: Added.
  • platform/efl/svg/text/text-midpoint-split-bug-expected.txt: Added.
  • platform/efl/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/efl/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/efl/svg/text/text-path-01-b-expected.png: Added.
  • platform/efl/svg/text/text-path-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-path-middle-align-expected.png: Added.
  • platform/efl/svg/text/text-path-middle-align-expected.txt: Added.
  • platform/efl/svg/text/text-repaint-rects-expected.png: Added.
  • platform/efl/svg/text/text-repaint-rects-expected.txt: Added.
  • platform/efl/svg/text/text-rescale-expected.png: Added.
  • platform/efl/svg/text/text-rescale-expected.txt: Added.
  • platform/efl/svg/text/text-spacing-01-b-expected.png: Added.
  • platform/efl/svg/text/text-spacing-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-text-01-b-expected.png: Added.
  • platform/efl/svg/text/text-text-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-text-03-b-expected.png: Added.
  • platform/efl/svg/text/text-text-03-b-expected.txt: Added.
  • platform/efl/svg/text/text-text-04-t-expected.png: Added.
  • platform/efl/svg/text/text-text-04-t-expected.txt: Added.
  • platform/efl/svg/text/text-text-05-t-expected.png: Added.
  • platform/efl/svg/text/text-text-05-t-expected.txt: Added.
  • platform/efl/svg/text/text-text-06-t-expected.png: Added.
  • platform/efl/svg/text/text-text-06-t-expected.txt: Added.
  • platform/efl/svg/text/text-text-07-t-expected.png: Added.
  • platform/efl/svg/text/text-text-07-t-expected.txt: Added.
  • platform/efl/svg/text/text-text-08-b-expected.png: Added.
  • platform/efl/svg/text/text-text-08-b-expected.txt: Added.
  • platform/efl/svg/text/text-tref-01-b-expected.png: Added.
  • platform/efl/svg/text/text-tref-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-tselect-01-b-expected.png: Added.
  • platform/efl/svg/text/text-tselect-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-tselect-02-f-expected.png: Added.
  • platform/efl/svg/text/text-tselect-02-f-expected.txt: Added.
  • platform/efl/svg/text/text-tspan-01-b-expected.png: Added.
  • platform/efl/svg/text/text-tspan-01-b-expected.txt: Added.
  • platform/efl/svg/text/text-viewbox-rescale-expected.png: Added.
  • platform/efl/svg/text/text-vkern-expected.png: Added.
  • platform/efl/svg/text/text-vkern-expected.txt: Added.
  • platform/efl/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
  • platform/efl/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
  • platform/efl/svg/text/text-ws-01-t-expected.png: Added.
  • platform/efl/svg/text/text-ws-01-t-expected.txt: Added.
  • platform/efl/svg/text/text-ws-02-t-expected.png: Added.
  • platform/efl/svg/text/text-ws-02-t-expected.txt: Added.
  • platform/efl/svg/text/textPathBoundsBug-expected.png: Added.
  • platform/efl/svg/text/textPathBoundsBug-expected.txt: Added.
  • platform/efl/svg/text/tspan-dynamic-positioning-expected.png: Added.
  • platform/efl/svg/text/tspan-dynamic-positioning-expected.txt: Added.
8:16 AM Changeset in webkit [130644] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip svg/dom/altGlyph-dom.xhtml

Seems to be passing these days.

  • platform/efl/TestExpectations:
8:11 AM Changeset in webkit [130643] by kling@webkit.org
  • 2 edits in trunk/Source/WTF

Lower minimum table size of WTF::HashTable to reduce memory usage.
<http://webkit.org/b/98406>
<rdar://problem/12432140>

Reviewed by Anders Carlsson.

Lower the default minimumTableSize for WTF hash tables from 64 to 8 entries.
This reduces WebProcess memory consumption by ~16MB on Membuster3 (a 6% progression!)

No significant movement on PLT or JSC benchmarks on my machine. If there's a perf regression somewhere
from this, we can tweak individual tables to have a larger minimumTableSize.

  • wtf/HashTraits.h:
8:05 AM Changeset in webkit [130642] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

[GTK] Add a setting to enable/disable smooth scrolling to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=98646

Reviewed by Xan Lopez.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Implement setter for new property.
(webKitSettingsGetProperty): Implement getter for new property.
(webkit_settings_class_init): Add new property
enable-smooth-scrolling.
(webkit_settings_get_enable_smooth_scrolling):
(webkit_settings_set_enable_smooth_scrolling):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Test smooth scrolling setting API.

8:04 AM Changeset in webkit [130641] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing crash expectations for tests that were fixed in r130611.

Removing failure expectations for fast/xsl/xslt-missing-namespace-in-xslt.xml,
the test is working fine after r130543.

  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
7:50 AM Changeset in webkit [130640] by allan.jensen@digia.com
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.

Adding expectations for tests under css2.1.

  • platform/qt/TestExpectations:
7:44 AM Changeset in webkit [130639] by kling@webkit.org
  • 4 edits in trunk

Using float/double as WTF hash table key is unreliable.
<http://webkit.org/b/98627>

Reviewed by Geoffrey Garen.

Source/WTF:

Change FloatHash::equal() to do a bitwise compare instead of a logical compare.
This fixes a problem where the keys with different binary representation but the
same logical value (e.g 0 and -0) could block each other from being found if they
ended up in the same hash bucket.

  • wtf/HashFunctions.h:

(FloatHash):
(WTF::FloatHash::hash):
(WTF::FloatHash::equal):

Tools:

Add a test case checking that using double as the hash table key type won't
have problems distinguishing between keys that are considered equal by operator==
but have different binary representations.

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestDoubleHashTraits):

7:36 AM BadContent edited by Csaba Osztrogonác
add more spammer addresses (diff)
7:05 AM Changeset in webkit [130638] by rakuco@webkit.org
  • 2 edits
    534 adds in trunk/LayoutTests

[EFL] Unskip svg/W3C-SVG-1.1.

All but one test case worked fine (compared to the expectations in
mac/).

  • platform/efl/TestExpectations:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-09-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-10-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-12-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-14-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-15-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-16-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-17-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-18-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-19-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-20-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prof-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prop-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prop-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prop-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-dom-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-events-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-order-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-order-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-order-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-05-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-render-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-08-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-10-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-13-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-14-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-15-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-line-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-cond-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-cond-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-group-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-group-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-09-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-use-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-06-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-06-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-deco-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-path-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-06-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-07-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tref-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tselect-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-ws-01-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-ws-02-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Added.
7:03 AM Changeset in webkit [130637] by commit-queue@webkit.org
  • 26 edits
    1 move in trunk

[EFL][WK2] Use URL instead of URI in the API
https://bugs.webkit.org/show_bug.cgi?id=98643

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Use URL instead of URI in WebKit2 EFL API. This change
was discussed on the mailing list and aims at making
the API more consistent.

  • UIProcess/API/efl/ewk_back_forward_list_item.cpp:

(_Ewk_Back_Forward_List_Item):
(ewk_back_forward_list_item_url_get):
(ewk_back_forward_list_item_original_url_get):

  • UIProcess/API/efl/ewk_back_forward_list_item.h:
  • UIProcess/API/efl/ewk_context.cpp:

(ewk_context_url_scheme_register):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_download_client.cpp:

(decideDestinationWithSuggestedFilename):

  • UIProcess/API/efl/ewk_download_job.h:
  • UIProcess/API/efl/ewk_resource_private.h:
  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_url_update):
(ewk_view_url_set):
(ewk_view_url_get):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_load_finished):
(ewk_view_load_provisional_redirect):
(ewk_view_load_provisional_started):
(ewk_view_html_string_load):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didSameDocumentNavigationForFrame):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):
(EWK2UnitTest::onURLChanged):
(EWK2UnitTest::timeOutWhileWaitingUntilURLChangedTo):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilURLChangedTo):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTestBase):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:

(EWK2UnitTestServer::EWK2UnitTestServer):
(EWK2UnitTestServer::~EWK2UnitTestServer):
(EWK2UnitTestServer::getURLForPath):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h:

(EWK2UnitTestServer):

  • UIProcess/API/efl/tests/resources/redirect_url_to_default.html: Renamed from Source/WebKit2/UIProcess/API/efl/tests/resources/redirect_uri_to_default.html.
  • UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:

(checkItem):
(urlFromTitle):

  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_download_job.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

Tools:

Update Minibrowser to reflect API changes. We now
use URL instead of URI in WK2 EFL API.

  • EWebLauncher/url_bar.c:

(on_urlbar_key_down):

  • MiniBrowser/efl/CMakeLists.txt:
  • MiniBrowser/efl/main.c:

(on_url_changed):
(window_create):

6:44 AM Changeset in webkit [130636] by zoltan@webkit.org
  • 35 edits in trunk/Source

[Qt] r122720 causes performance regression with DirectFB on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=97548

Reviewed by Jocelyn Turcotte.

Revert the rest of r122720. This change modifies the NativeImagePtr from QImage* to QPixmap*.

Covered by existing tests.

Source/WebCore:

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::QtPixmapRuntime::toQt):

  • platform/DragImage.h:

(WebCore):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/Image.h:

(Image):

  • platform/graphics/NativeImagePtr.h:

(WebCore):

  • platform/graphics/gstreamer/ImageGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamerQt.cpp:

(ImageGStreamer::ImageGStreamer):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::getImageData):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::pushTransparencyLayerInternal):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):

  • platform/graphics/qt/ImageBufferDataQt.h:

(ImageBufferData):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBufferData::ImageBufferData):
(WebCore):
(WebCore::ImageBufferData::toQImage):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageFrame::asNewNativeImage):

  • platform/graphics/qt/ImageQt.cpp:

(graphics):
(loadResourcePixmap):
(WebCore::Image::loadPlatformResource):
(WebCore::Image::setPlatformResource):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::create):

  • platform/graphics/qt/PatternQt.cpp:

(WebCore::Pattern::createPlatformPattern):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::StillImage):
(WebCore::StillImage::~StillImage):
(WebCore::StillImage::currentFrameHasAlpha):
(WebCore::StillImage::size):
(WebCore::StillImage::nativeImageForCurrentFrame):
(WebCore::StillImage::draw):

  • platform/graphics/qt/StillImageQt.h:

(WebCore::StillImage::create):
(WebCore::StillImage::createForRendering):
(StillImage):

  • platform/graphics/qt/TransparencyLayer.h:

(WebCore::TransparencyLayer::TransparencyLayer):
(TransparencyLayer):

  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:

(WebCore::GraphicsSurface::createReadOnlyImage):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::createDragImage):
(WebCore::ClipboardQt::declareAndWriteDragImage):

  • platform/qt/CursorQt.cpp:

(WebCore::createCustomCursor):

  • platform/qt/DragImageQt.cpp:

(WebCore::createDragImageFromImage):

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeImage):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

  • Api/qwebhistory.cpp:

(QWebHistoryItem::icon):

  • Api/qwebsettings.cpp:

(QWebSettings::iconForUrl):
(QWebSettings::setWebGraphic):
(QWebSettings::webGraphic):

  • WebCoreSupport/DragClientQt.cpp:

(WebCore::DragClientQt::startDrag):

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

Source/WebKit2:

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createImage):

  • UIProcess/qt/QtWebIconDatabaseClient.cpp:

(WebKit::QtWebIconDatabaseClient::iconImageForPageURL):

  • WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:

(WebKit::convertQPixmapToShareableBitmap):
(WebKit::WebDragClient::startDrag):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::adoptImageBackingStore):

6:43 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
5:51 AM Changeset in webkit [130635] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(r130629): It made touchadjustment/focusout-on-touch.html fail
https://bugs.webkit.org/show_bug.cgi?id=98642

Unreviewed gardening, skip the new failing test to paint the bot green.

  • platform/qt-5.0-wk2/TestExpectations:
4:29 AM Changeset in webkit [130634] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing header file to compilation.
4:04 AM Changeset in webkit [130633] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r130630

Explicit convertion is required from QSizeF to FloatSize.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):

4:02 AM Changeset in webkit [130632] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] plugins/refcount-leaks.html fails
https://bugs.webkit.org/show_bug.cgi?id=98640

Unreviewed gardening, skip the failing test.

  • platform/qt/TestExpectations:
3:48 AM Changeset in webkit [130631] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix the mouse hover events transformation when devicePixelRatio != 1
https://bugs.webkit.org/show_bug.cgi?id=98429

Reviewed by Kenneth Rohde Christiansen.

This prevents the events from being transformed two or three times.
This is only noticeable in desktop mode.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::handleHoverLeaveEvent):
(WebKit::QtWebPageEventHandler::handleHoverMoveEvent):

3:45 AM Changeset in webkit [130630] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Apply QQuickWebViewExperimental::devicePixelRatio to the desktop mode as well
https://bugs.webkit.org/show_bug.cgi?id=98428

Reviewed by Kenneth Rohde Christiansen.

This is handled by the PageViewportController when in flickable mode.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):

3:41 AM Changeset in webkit [130629] by jocelyn.turcotte@digia.com
  • 5 edits in trunk/Source/WebKit2

[Qt] Prevent the PageViewportController from affecting the viewport in desktop mode
https://bugs.webkit.org/show_bug.cgi?id=98427

Reviewed by Kenneth Rohde Christiansen.

QQuickFlickable isn't tightly bound to it anymore, we can avoid creating it
completely in this case.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewPrivate::viewportController):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate::viewportController):
(QQuickWebViewFlickablePrivate):

  • UIProcess/qt/QtPageClient.cpp:

(WebKit::QtPageClient::didRenderFrame):
(WebKit::QtPageClient::didChangeContentsSize):
(WebKit::QtPageClient::pageTransitionViewportReady):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(WebKit::QtWebPageLoadClient::didCommitLoad):

3:29 AM Changeset in webkit [130628] by kkristof@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

Unreviewed gardening, skip and update some failing test.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-08

  • platform/qt/TestExpectations:
  • platform/qt/http/tests/misc/acid3-expected.png:
  • platform/qt/http/tests/misc/acid3-expected.txt:
2:57 AM Changeset in webkit [130627] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix a QSocketNotifier warning at startup
https://bugs.webkit.org/show_bug.cgi?id=98411

Reviewed by Simon Hausmann.

The actual warning:
QSocketNotifier: socket notifiers cannot be enabled from another thread

The problem was that QSocketNotifier::setEnabled was called on the main thread
after moveToThread was called. This hasn't had any effect since Connection
would dispatch a readyReadHandler call right after which would then call
setEnabled again from the correct thread from ~SocketNotifierResourceGuard.

Replace the call with a queued invoke to shut the warning.

  • Platform/qt/WorkQueueQt.cpp:

(WorkQueue::registerSocketEventHandler):

2:47 AM Changeset in webkit [130626] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Fix build break when WEB_AUDIO is enabled.
https://bugs.webkit.org/show_bug.cgi?id=98635

Unreviewed build fix.

Build error is occurred because of the new flag, ENABLE_LEGACY_WEB_AUDIO,
which was introduced by https://bugs.webkit.org/show_bug.cgi?id=97050.

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-08

  • Source/cmakeconfig.h.cmake: Add ENABLE_LEGACY_WEB_AUDIO.
2:28 AM Changeset in webkit [130625] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Test /webkit2/WebKitWebView/populate-menu asserts in debug bots
https://bugs.webkit.org/show_bug.cgi?id=98507

Reviewed by Martin Robinson.

Make sure we retain the page URL before asking for the icon.

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously): Retain the page URL before asking
for the icon, and release it if we fail to get an icon.
(processPendingIconsForPageURL): Renamed to make it clear it
receives a Sring and not a char* and moved
getIconSurfaceSynchronously() call out of the loop to call it only
once even if there are multiple requests pending.
(iconDataReadyForPageURLCallback): Do not retain the page URL
here.

2:23 AM Changeset in webkit [130624] by joone.hur@intel.com
  • 5 edits in trunk

[EFL] Add support for -webkit-sticky
https://bugs.webkit.org/show_bug.cgi?id=95182

Reviewed by Kenneth Rohde Christiansen.

Turn on CSS sticky position by default for WebKitEfl,
but most of the CSS sticky position test cases still do not pass on WK1.

.:

  • Source/cmake/OptionsEfl.cmake:

LayoutTests:

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
1:49 AM Changeset in webkit [130623] by kbalazs@webkit.org
  • 7 edits in trunk

[Qt] Reenable plugin tests
https://bugs.webkit.org/show_bug.cgi?id=98528

Reviewed by Csaba Osztrogonác.

Tools:

Uncomment this function so we can pick up the test plugin.
It was commented out because of https://bugs.webkit.org/show_bug.cgi?id=86620
and that bug seems to be fixed now.

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::initializeTestPluginDirectory):

LayoutTests:

Reenable plugin tests. Skip new failures.

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0/TestExpectations:
  • platform/qt/TestExpectations:
1:06 AM Changeset in webkit [130622] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r130619.
http://trac.webkit.org/changeset/130619
https://bugs.webkit.org/show_bug.cgi?id=98634

Causes many crashes on the EFL bots. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-08

Source/WebCore:

  • platform/RunLoop.h:

(RunLoop):

  • platform/efl/RunLoopEfl.cpp:

(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::wakeUpEvent):
(WebCore::RunLoop::wakeUp):

Source/WTF:

  • wtf/efl/MainThreadEfl.cpp:

(WTF::pipeObject):
(WTF):
(WTF::monitorDispatchFunctions):
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):

1:05 AM Changeset in webkit [130621] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitWebContext
https://bugs.webkit.org/show_bug.cgi?id=96768

Reviewed by Martin Robinson.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitDownloadClient.cpp:

(didStart):
(didReceiveResponse):
(didReceiveData):
(decideDestinationWithSuggestedFilename):
(didCreateDestination):
(didFail):
(didCancel):
(didFinish):
(attachDownloadClientToContext):

  • UIProcess/API/gtk/WebKitRequestManagerClient.cpp:

(attachRequestManagerClientToContext):

  • UIProcess/API/gtk/WebKitSecurityManager.cpp:

(registerSecurityPolicyForURIScheme):

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(_WebKitWebContextPrivate):
(createDefaultWebContext):
(webkit_web_context_set_cache_model):
(webkit_web_context_get_cache_model):
(webkit_web_context_clear_cache):
(webkit_web_context_download_uri):
(webkit_web_context_get_cookie_manager):
(webkit_web_context_get_favicon_database_directory):
(webkit_web_context_get_favicon_database):
(webkit_web_context_set_additional_plugins_directory):
(webkitWebContextGetPluginThread):
(webkit_web_context_register_uri_scheme):
(webkitWebContextGetOrCreateDownload):
(webkitWebContextRemoveDownload):
(webkitWebContextGetContext):
(webkitWebContextGetRequestManager):

  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):

12:40 AM Changeset in webkit [130620] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Support multiple window creation for MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=97884

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Implement the multiple window creation for MiniBrowser and bind the 'F9' key for opening a new window.
Also, refactored MiniBrowser codes according to EFL coding style.

  • MiniBrowser/efl/main.c:

(_Browser_Window):
(window_free):
(main_signal_exit):
(on_ecore_evas_delete):
(on_ecore_evas_resize):
(on_key_down):
(on_title_changed):
(on_url_changed):
(on_progress):
(window_create):
(main):

12:20 AM Changeset in webkit [130619] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[EFL] Use ecore_main_loop_thread_safe_call_async() to wakeup main loop.
https://bugs.webkit.org/show_bug.cgi?id=98505

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Instead of ecore_pipe_write(),
use ecore_main_loop_thread_safe_call_async() to wakeup ecore main loop.

According to the EFL API document, this function is designed to dispatch
a function on ecore main loop by avoiding dead lock or race condition.
With this function, webkit doesn't need to maintain ecore pipe also.

Source/WebCore:

No new tests. The function to wakeup main loop is changed.

  • platform/RunLoop.h:

(RunLoop):

  • platform/efl/RunLoopEfl.cpp:

(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::wakeUpEvent):
(WebCore::RunLoop::wakeUp):

Source/WTF:

  • wtf/efl/MainThreadEfl.cpp:

(WTF::monitorDispatchFunctions):
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):

Oct 7, 2012:

11:59 PM Changeset in webkit [130618] by noel.gordon@gmail.com
  • 1 edit
    6 adds in trunk/LayoutTests

Add partial load test for JPEG image
https://bugs.webkit.org/show_bug.cgi?id=98487

Reviewed by Adam Barth.

Partial load test: receive a partial number of image bytes and stall forever. The partial
image should be decoded and drawn and the green <img> background should be visible.

  • fast/images/resources/lenna.jpg: Added.
  • http/tests/images/jpeg-partial-load-expected.png: Added.
  • http/tests/images/jpeg-partial-load-expected.txt: Added.
  • http/tests/images/jpeg-partial-load.html: Added.
  • platform/chromium/http/tests/images/jpeg-partial-load-expected.png: Added.
  • platform/mac/http/tests/images/jpeg-partial-load-expected.png: Added.
11:28 PM Changeset in webkit [130617] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Add Web Inspector to EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=91718

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-10-07
Reviewed by Gyuyoung Kim.

Implementation of Web Inspector in EWebLauncher.
The Web Inspector can be opened or closed by pressing ctrl+i on web page.

  • EWebLauncher/main.c:

(on_browser_ecore_evas_resize):
(on_web_inspector_ecore_evas_resize):
(on_key_down):
(on_web_inspector_view_create):
(on_web_inspector_view_close):
(on_web_inspector_view_destroyed):
(browserCreate):
(webInspectorCreate):
(windowCreate):
(closeWindow):
(main_signal_exit):
(parseUserArguments):

9:42 PM Changeset in webkit [130616] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

:first-line pseudo selector ignoring words created from :before
https://bugs.webkit.org/show_bug.cgi?id=80794

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-10-07
Reviewed by Daniel Bates.

Source/WebCore:

The :first-line pseudo-element style is not applied for content
which is generated from the :before/:after pseudo-elements.

Test: fast/css/first-line-style-for-before-after-content.html

  • rendering/RenderObject.cpp:

(WebCore::firstLineStyleForCachedUncachedType):
Added a new static helper function incorporating the common
functionality of both uncachedFirstLineStyle() and firstLineStyleSlowCase()
functions. It also modifies the functionality to handle the
scenario when :first-line style needs to be applied on content
generated from :before/:after.

While getting the :first-line style we should also consider the case
when the content is generated from a :before/:after pseudo-element in
which case the RenderInline's parent should be considered for
obtaining the first-line style.

(WebCore):
(WebCore::RenderObject::uncachedFirstLineStyle):
(WebCore::RenderObject::firstLineStyleSlowCase):
Moved the duplicate code between the two functions to the common
helper function firstLineStyleForCachedUncachedType().

LayoutTests:

  • fast/css/first-line-style-for-before-after-content-expected.html: Added.
  • fast/css/first-line-style-for-before-after-content.html: Added.

Added ref test for verification of the scenario when :first-line style
is applied to content generated from :before/:after pseudo-elements.

9:37 PM Changeset in webkit [130615] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: The front-end should provide the position in original source file when set a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=93473

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-10-07
Reviewed by Yury Semikhatsky.

Since frontend truncates the indent, the first statement in a line must match the breakpoint (line, 0).
With this patch JSC debugger can support both normal and "Pretty Print" mode.

No new test case. This patch can be verified with cases in "LayoutTests/inspector/debugger/".

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::pauseIfNeeded):

  • bindings/js/ScriptDebugServer.h:

(ScriptDebugServer):

8:29 PM Changeset in webkit [130614] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix unused parameter compile warning.
https://bugs.webkit.org/show_bug.cgi?id=98610

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-07
Reviewed by Laszlo Gombos.

Fixed unused parameter compile warning by removing initiatingPageRef parameter name.

  • UIProcess/API/efl/ewk_context_request_manager_client.cpp:

(didReceiveURIRequest):

5:35 PM Changeset in webkit [130613] by mrobinson@webkit.org
  • 5 edits
    1 add in trunk/Source/WebCore

[Soup] Clean up ResourceError creation
https://bugs.webkit.org/show_bug.cgi?id=98521

Reviewed by Carlos Garcia Campos.

Simplify the creation of ResourcErrors in ResourceHandleSoup. This is
part of a process to make the libsoup networking backend more hackable.

No new tests. This shouldn't change functionality.

  • GNUmakefile.list.am: Added new file.
  • PlatformEfl.cmake: Added new file.
  • platform/network/soup/ResourceError.h:

(ResourceError): Added new factories.

  • platform/network/soup/ResourceErrorSoup.cpp: Added.

(WebCore::failingURI): Added this helper.
(WebCore::ResourceError::httpError): New factory.
(WebCore::ResourceError::genericIOError): Ditto.
(WebCore::ResourceError::tlsError): Ditto.
(WebCore::ResourceError::timeoutError): Ditto.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::handleUnignoredTLSErrors): Created this helper which merges
some of the logic from sendRequestCallback.
(WebCore::sendRequestCallback): Use the new helper.
(WebCore::requestTimeoutCallback): Use the new factory.

4:12 PM Changeset in webkit [130612] by benjamin@webkit.org
  • 401 edits in trunk

Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784

Patch by Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> on 2012-10-07
Reviewed by Eric Seidel.

Source/JavaScriptCore:

  • API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren):

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnNonIndexPropertyNames):

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::contextData):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::EvalCodeCache::visitAggregate):
(JSC::CodeBlock::nameForRegister):

  • bytecode/JumpTable.h:

(JSC::StringJumpTable::offsetForValue):
(JSC::StringJumpTable::ctiForValue):

  • bytecode/LazyOperandValueProfile.cpp:

(JSC::LazyOperandValueProfileParser::getIfPresent):

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::dump):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitLazyNewFunction):

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • debugger/Debugger.cpp:
  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):

  • dfg/DFGAssemblyHelpers.cpp:

(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):

  • dfg/DFGByteCodeCache.h:

(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):
(JSC::DFG::StructureCheckHoistingPhase::noticeStructureCheck):
(JSC::DFG::StructureCheckHoistingPhase::noticeClobber):

  • heap/Heap.cpp:

(JSC::Heap::markProtectedObjects):

  • heap/Heap.h:

(JSC::Heap::forEachProtectedCell):

  • heap/JITStubRoutineSet.cpp:

(JSC::JITStubRoutineSet::markSlow):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::internalAppend):

  • heap/Weak.h:

(JSC::weakRemove):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::ctiStub):

  • parser/Parser.cpp:

(JSC::::parseStrictObjectLiteral):

  • profiler/Profile.cpp:

(JSC::functionNameCountPairComparator):
(JSC::Profile::debugPrintDataSampleStyle):

  • runtime/Identifier.cpp:

(JSC::Identifier::add):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnNonIndexPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

  • runtime/JSArray.cpp:

(JSC::JSArray::setLength):

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::attemptToInterceptPutByIndexOnHoleForPrototype):
(JSC::JSObject::putByIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::getOwnPropertyDescriptor):

  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::invalidateCode):

  • runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::putEntry):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayValueMap::visitChildren):

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::clear):
(JSC::WeakGCMap::set):

  • tools/ProfileTreeNode.h:

(JSC::ProfileTreeNode::sampleChild):
(JSC::ProfileTreeNode::childCount):
(JSC::ProfileTreeNode::dumpInternal):
(JSC::ProfileTreeNode::compareEntries):

Source/WebCore:

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::Watchers::find):
(WebCore::Geolocation::Watchers::remove):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::objectStoreNames):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::metadata):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
(WebCore::IDBFactoryBackendImpl::open):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::objectStoreDeleted):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::dispatchEvent):

  • Modules/mediastream/MediaConstraintsImpl.cpp:

(WebCore::MediaConstraintsImpl::getMandatoryConstraints):
(WebCore::MediaConstraintsImpl::getMandatoryConstraintValue):

  • Modules/webdatabase/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::performOpenAndVerify):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

  • Modules/webdatabase/OriginUsageRecord.cpp:

(WebCore::OriginUsageRecord::diskUsage):

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):

  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

  • Modules/webdatabase/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):
(WebCore::QuotaTracker::updateDatabaseSize):

  • Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketExtensionDeflateFrame::processResponse):

  • Modules/websockets/WebSocketExtensionDispatcher.cpp:

(WebCore::WebSocketExtensionDispatcher::appendAcceptedExtension):

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache):

  • bindings/gobject/DOMObjectCache.cpp:

(WebKit::DOMObjectCache::clearByFrame):

  • bindings/js/DOMObjectHashTableMap.h:

(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::cacheDOMStructure):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::getDOMConstructor):

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::clearScriptObjects):

  • bindings/js/ScriptController.h:

(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::checkForDuplicate):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::GetRawTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::GetRawTemplate):
(WebCore::V8TestEventTarget::GetTemplate):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::GetRawTemplate):
(WebCore::V8TestInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetRawTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetRawTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetRawTemplate):
(WebCore::V8TestNode::GetTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::GetRawTemplate):
(WebCore::V8TestObj::GetTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::deallocate):
(WebCore::DOMWrapperWorld::ensureIsolatedWorld):

  • bindings/v8/NPV8Object.cpp:

(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::ensureIsolatedWorldContext):
(WebCore::ScriptController::existingWindowShellInternal):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8DOMMap.h:

(WebCore::WeakReferenceMap::removeIfPresent):
(WebCore::WeakReferenceMap::visit):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::dispose):

  • bindings/v8/npruntime.cpp:
  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • bridge/NP_jsobject.cpp:

(ObjectMap::add):
(ObjectMap::remove):

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::invalidate):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::counterToCSSValue):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::crossfadeChanged):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::getImage):

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::parsePseudoType):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createFontFamilyValue):
(WebCore::CSSValuePool::createFontFaceValue):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):

  • css/RuleSet.cpp:

(WebCore::reportAtomRuleMap):
(WebCore::RuleSet::addToRuleSet):
(WebCore::shrinkMapVectorsToFit):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::ruleSetForScope):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAddNamespace):
(WebCore::StyleSheetContents::determineNamespace):

  • dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationAccumulator::getOrCreate):

  • dom/Document.cpp:

(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::getCSSCanvasElement):
(WebCore::Document::cachedImmutableAttributeData):
(WebCore::Document::getCachedLocalizer):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
(WebCore::DocumentMarkerController::showMarkers):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::remove):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::pageGroupUserSheets):

  • dom/ElementAttributeData.cpp:

(WebCore::ensureAttrListForElement):

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):

  • dom/IdTargetObserverRegistry.cpp:

(WebCore::IdTargetObserverRegistry::addObserver):
(WebCore::IdTargetObserverRegistry::removeObserver):

  • dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::clearRareData):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::collectMatchingObserversForMutation):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
(WebCore::NodeListsNodeData::adoptTreeScope):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::adjustMinimumTimerInterval):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCache::add):

  • dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitStringData::create):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

  • editing/mac/AlternativeTextUIController.mm:

(WebCore::AlternativeTextUIController::AlernativeTextContextController::alternativesForContext):

  • html/FormController.cpp:

(WebCore::SavedFormState::serializeTo):
(WebCore::SavedFormState::appendControlState):
(WebCore::SavedFormState::takeControlState):
(WebCore::SavedFormState::getReferencedFilePaths):
(WebCore::FormKeyGenerator::formKey):
(WebCore::FormController::createSavedFormStateMap):
(WebCore::FormController::formElementsState):
(WebCore::FormController::takeStateForFormElement):
(WebCore::FormController::getReferencedFilePaths):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollectionCacheBase::append):

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeAttachments):

  • inspector/CodeGeneratorInspector.py:
  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):

  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptIdFor):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
(WebCore::InjectedScriptManager::releaseObjectGroup):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::commitSelector):
(WebCore::SelectorProfile::commitSelectorTime):
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::didModifyDOMAttr):
(WebCore::InspectorCSSAgent::resetPseudoStates):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::count):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::nodeForId):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::memoryBytesUsedByStorageCache):

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::databaseId):
(WebCore::InspectorDatabaseAgent::findByFileName):
(WebCore::InspectorDatabaseAgent::databaseForId):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

  • inspector/InspectorPageAgent.cpp:

(WebCore::cachedResourcesForFrame):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameDetached):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getProfile):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForHeaders):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::documentThreadableLoaderStartedLoadingForClient):
(WebCore::InspectorResourceAgent::willLoadXHR):
(WebCore::InspectorResourceAgent::replayXHR):

  • inspector/InspectorState.cpp:

(WebCore::InspectorState::getBoolean):
(WebCore::InspectorState::getString):
(WebCore::InspectorState::getLong):
(WebCore::InspectorState::getDouble):
(WebCore::InspectorState::getObject):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::styleWithProperties):
(WebCore::InspectorStyleSheet::inspectorStyleForId):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorObjectBase::get):
(WebCore::InspectorObjectBase::writeJSON):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::countObjectSize):

  • inspector/MemoryInstrumentationImpl.h:

(WebCore::MemoryInstrumentationClientImpl::totalSize):
(WebCore::MemoryInstrumentationClientImpl::reportedSizeForAllTypes):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::setXHRReplayData):
(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore::NetworkResourcesData::clear):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isSimpleCrossOriginAccessRequest):
(WebCore::createAccessControlPreflightRequest):

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::getSubresources):
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::servePendingRequests):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::removeResource):
(WebCore::ApplicationCache::clearStorageID):
(WebCore::ApplicationCache::dump):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::startLoadingEntry):
(WebCore::ApplicationCacheGroup::addEntry):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::fillResourceList):

  • loader/appcache/ApplicationCacheResource.cpp:

(WebCore::ApplicationCacheResource::estimatedSizeInStorage):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::empty):
(WebCore::ApplicationCacheStorage::storeCopyOfCache):

  • loader/archive/ArchiveFactory.cpp:

(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::canReuse):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::switchClientsToRevalidatedResource):
(WebCore::CachedResource::updateResponseAfterRevalidation):

  • loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):
(WebCore::CachedResourceLoader::removeCachedResource):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeResourcesWithOrigin):
(WebCore::MemoryCache::getOriginsWithCache):
(WebCore::MemoryCache::getStatistics):
(WebCore::MemoryCache::setDisabled):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::removeAllIcons):
(WebCore::IconDatabase::iconRecordCountWithData):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScripts):

  • page/PageGroup.cpp:

(WebCore::PageGroup::pageGroup):
(WebCore::PageGroup::closeLocalStorage):
(WebCore::PageGroup::clearLocalStorageForAllOrigins):
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore::PageGroup::syncLocalStorage):
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::urlForBlankFrame):

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

  • page/Settings.cpp:

(WebCore::setGenericFontFamilyMap):
(WebCore::getGenericFontFamilyForScript):

  • page/SpeechInput.cpp:

(WebCore::SpeechInput::registerListener):

  • page/TouchDisambiguation.cpp:

(WebCore::findGoodTouchTargets):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::boolFeature):
(WebCore::WindowFeatures::floatFeature):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::numberOfActiveAnimations):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::clearRenderer):
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):
(WebCore::CompositeAnimation::getAnimatedStyle):
(WebCore::CompositeAnimation::setAnimating):
(WebCore::CompositeAnimation::timeToNextService):
(WebCore::CompositeAnimation::getAnimationForProperty):
(WebCore::CompositeAnimation::suspendAnimations):
(WebCore::CompositeAnimation::resumeAnimations):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::CompositeAnimation::isAnimatingProperty):
(WebCore::CompositeAnimation::numberOfActiveAnimations):

  • platform/Language.cpp:

(WebCore::languageDidChange):

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

  • platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore::CookieManager::removeAllCookies):

  • platform/blackberry/CookieMap.cpp:

(WebCore::CookieMap::removeOldestCookie):
(WebCore::CookieMap::getAllChildCookies):

  • platform/cf/BinaryPropertyList.cpp:

(WebCore::BinaryPropertyListPlan::writeIntegerArray):

  • platform/chromium/support/WebHTTPLoadInfo.cpp:

(WebKit::addHeader):

  • platform/chromium/support/WebURLRequest.cpp:

(WebKit::WebURLRequest::visitHTTPHeaderFields):

  • platform/chromium/support/WebURLResponse.cpp:

(WebKit::WebURLResponse::addHTTPHeaderField):
(WebKit::WebURLResponse::visitHTTPHeaderFields):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::unregisterClient):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getVerticalData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::treeGlyphPageCount):
(WebCore::GlyphPageTreeNode::pageCount):
(WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
(WebCore::GlyphPageTreeNode::pruneTreeFontData):
(WebCore::GlyphPageTreeNode::pruneCustomFontData):
(WebCore::GlyphPageTreeNode::pruneFontData):
(WebCore::GlyphPageTreeNode::showSubtree):
(showGlyphPageTrees):

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::resizeEdgeTiles):
(WebCore::TiledBackingStore::setKeepRect):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::avfWrapperForCallbackContext):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::bindContentsTexture):

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::textureForColor):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::pauseAnimation):
(WebCore::GraphicsLayerCA::layerDidDisplay):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateTransform):
(WebCore::GraphicsLayerCA::updateChildrenTransform):
(WebCore::GraphicsLayerCA::updateMasksToBounds):
(WebCore::GraphicsLayerCA::updateContentsVisibility):
(WebCore::GraphicsLayerCA::updateContentsOpaque):
(WebCore::GraphicsLayerCA::updateBackfaceVisibility):
(WebCore::GraphicsLayerCA::updateFilters):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsRect):
(WebCore::GraphicsLayerCA::updateMaskLayer):
(WebCore::GraphicsLayerCA::updateLayerAnimations):
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::removeCAAnimationFromLayer):
(WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer):
(WebCore::GraphicsLayerCA::suspendAnimations):
(WebCore::GraphicsLayerCA::resumeAnimations):
(WebCore::GraphicsLayerCA::findOrMakeClone):
(WebCore::GraphicsLayerCA::setOpacityInternal):
(WebCore::GraphicsLayerCA::updateOpacityOnLayer):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::~TileCache):
(WebCore::TileCache::setNeedsDisplay):
(WebCore::TileCache::setScale):
(WebCore::TileCache::setAcceleratesDrawing):
(WebCore::TileCache::setTileDebugBorderWidth):
(WebCore::TileCache::setTileDebugBorderColor):
(WebCore::TileCache::revalidateTiles):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::animationStarted):
(resubmitAllAnimations):
(PlatformCALayer::animationForKey):

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::LookupAltName):
(WebCore::fontContainsCharacter):

  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:

(WebCore::getDerivedFontData):

  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::getValidatedProgram):
(WebCore::CustomFilterGlobalContext::removeValidatedProgram):

  • platform/graphics/filters/CustomFilterProgram.cpp:

(WebCore::CustomFilterProgram::notifyClients):

  • platform/graphics/harfbuzz/HarfBuzzSkia.cpp:

(WebCore::getCachedHarfbuzzFace):
(WebCore::releaseCachedHarfbuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp:

(WebCore::HarfBuzzNGFace::HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::~HarfBuzzNGFace):

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::mappedSymbolName):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):

  • platform/graphics/openvg/EGLDisplayOpenVG.cpp:

(WebCore::EGLDisplayOpenVG::~EGLDisplayOpenVG):
(WebCore::EGLDisplayOpenVG::destroySurface):
(WebCore::EGLDisplayOpenVG::contextForSurface):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

  • platform/graphics/wince/FontPlatformData.cpp:

(WebCore::FixedSizeFontData::create):

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::forClipboard):

  • platform/gtk/GtkDragAndDropHelper.cpp:

(WebCore::GtkDragAndDropHelper::handleGetDragData):
(WebCore::GtkDragAndDropHelper::handleDragLeave):
(WebCore::GtkDragAndDropHelper::handleDragMotion):
(WebCore::GtkDragAndDropHelper::handleDragDataReceived):
(WebCore::GtkDragAndDropHelper::handleDragDrop):

  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::filterXDamageEvent):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::gtkStyleChangedCallback):
(WebCore::getStyleContext):

  • platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):

  • platform/network/CredentialStorage.cpp:

(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::get):

  • platform/network/MIMEHeader.cpp:

(WebCore::MIMEHeader::parseHeader):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::addHTTPHeaderField):
(WebCore::ResourceRequestBase::addHTTPHeaderFields):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::targetTypeFromMimeType):
(WebCore::ResourceRequest::initializePlatformRequest):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::setClientCertificate):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::toSoupMessage):

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::toSoupMessage):

  • platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::start):

  • platform/qt/RunLoopQt.cpp:

(WebCore::RunLoop::TimerBase::timerFired):

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::scriptNameToCode):
(WebCore::localeToScriptCodeForFontSelection):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::pruneBlacklistedCodecs):
(WebCore::dumpTextEncodingNameMap):

  • platform/text/transcoder/FontTranscoder.cpp:

(WebCore::FontTranscoder::converterType):

  • platform/text/win/TextCodecWin.cpp:

(WebCore::LanguageManager::LanguageManager):
(WebCore::getCodePage):
(WebCore::TextCodecWin::registerExtendedEncodingNames):
(WebCore::TextCodecWin::registerExtendedCodecs):
(WebCore::TextCodecWin::enumerateSupportedEncodings):

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::getDataMapItem):
(WebCore::getClipboardData):
(WebCore::setClipboardData):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::types):

  • platform/win/FileSystemWin.cpp:

(WebCore::cachedStorageDirectory):

  • platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::TimerBase::timerFired):

  • platform/win/WCDataObject.cpp:

(WebCore::WCDataObject::createInstance):

  • platform/wince/MIMETypeRegistryWinCE.cpp:

(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

  • platform/wx/ContextMenuWx.cpp:

(WebCore::ContextMenu::appendItem):

  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::MIMETypeForExtension):
(WebCore::PluginDatabase::remove):

  • plugins/PluginMainThreadScheduler.cpp:

(WebCore::PluginMainThreadScheduler::scheduleCall):
(WebCore::PluginMainThreadScheduler::dispatchCalls):

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::startStream):

  • plugins/blackberry/PluginDataBlackBerry.cpp:

(WebCore::PluginData::initPlugins):

  • plugins/wx/PluginDataWx.cpp:

(WebCore::PluginData::initPlugins):

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::ensureExclusionShapeInsideInfoForRenderBlock):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::unregisterNamedFlowContentNode):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::requiresIdeographicBaseline):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::highQualityRepaintTimerFired):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::performOverlapTests):

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayerFilterInfo::filterInfoForRenderLayer):
(WebCore::RenderLayerFilterInfo::createFilterInfoForRenderLayerIfNeeded):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::RenderNamedFlowThread::pushDependencies):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::cachedCollapsedBorder):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor):

  • rendering/RenderView.cpp:

(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::setSelection):

  • rendering/RenderWidget.cpp:

(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/VerticalPositionCache.h:

(WebCore::VerticalPositionCache::get):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::characterStartsNewTextChunk):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::resourceDestroyed):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::swapItemsInLayoutAttributes):

  • rendering/svg/SVGTextLayoutAttributes.cpp:

(WebCore::SVGTextLayoutAttributes::dump):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildCharacterDataMap):
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::performImport):
(WebCore::StorageAreaSync::sync):

  • storage/StorageMap.cpp:

(WebCore::StorageMap::key):
(WebCore::StorageMap::setItem):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::localStorageNamespace):
(WebCore::StorageNamespaceImpl::copy):
(WebCore::StorageNamespaceImpl::close):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget):
(WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::effectReferences):
(WebCore::SVGFilterBuilder::addBuiltinEffects):

  • svg/properties/SVGAnimatedProperty.h:

(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):

  • svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::addProperties):
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::hasPendingActivity):

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::close):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setRequestHeaderInternal):
(WebCore::XMLHttpRequest::getAllResponseHeaders):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::createFunction):

  • xml/XPathParser.cpp:

(isAxisName):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::xsltParamArrayFromParameterMap):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTProcessor::transformToString):

Source/WebKit/blackberry:

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):

  • WebCoreSupport/NotificationPresenterImpl.cpp:

(WebCore::NotificationPresenterImpl::cancel):
(WebCore::NotificationPresenterImpl::onPermission):
(WebCore::NotificationPresenterImpl::notificationClicked):

  • WebCoreSupport/UserMediaClientImpl.cpp:

(WebCore::UserMediaClientImpl::cancelUserMediaRequest):

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):

  • WebKitSupport/FrameLayers.cpp:

(BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
(BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
(BlackBerry::WebKit::FrameLayers::calculateRootLayer):

Source/WebKit/chromium:

  • src/WebGeolocationPermissionRequestManager.cpp:

(WebGeolocationPermissionRequestManager::remove):

  • src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):

  • src/WebIntent.cpp:

(WebKit::WebIntent::extrasValue):

  • tests/MemoryInstrumentationTest.cpp:
  • tests/WebSocketExtensionDispatcherTest.cpp:

(WebCore::TEST_F):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):

  • WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::getPluginInfo):

  • ewk/ewk_intent.cpp:

(ewk_intent_extra_get):

Source/WebKit/gtk:

  • WebCoreSupport/PlatformStrategiesGtk.cpp:

(PlatformStrategiesGtk::getPluginInfo):

  • webkit/webkitfavicondatabase.cpp:

(webkitFaviconDatabaseImportFinished):

  • webkit/webkitwebplugin.cpp:

(webkit_web_plugin_get_mimetypes):

Source/WebKit/mac:

  • History/WebHistory.mm:

(-[WebHistoryPrivate removeItemFromDateCaches:]):
(-[WebHistoryPrivate orderedLastVisitedDays]):
(WebHistoryWriter::WebHistoryWriter):

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
(+[WebCoreStatistics javaScriptObjectTypeCounts]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::hostForPlugin):
(WebKit::NetscapePluginHostManager::pluginHostDied):
(WebKit::NetscapePluginHostManager::didCreateWindow):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::pluginHostDied):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
(WebKit::NetscapePluginInstanceProxy::destroy):
(WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason):
(WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodNamed):
(WebKit::ProxyInstance::fieldNamed):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView stopTimers]):
(-[WebNetscapePluginView startTimers]):

  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):

  • WebView/WebHTMLView.mm:

(commandNameForSelector):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(extractContentTypeFromPluginVector):

  • Api/qwebplugindatabase.cpp:

(QWebPluginInfo::mimeTypes):

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::getPluginInfo):

Source/WebKit/win:

  • COMPropertyBag.h:

(::Read):
(::GetPropertyInfo):

  • WebCoreStatistics.cpp:

(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::getPluginInfo):

  • WebHistory.cpp:

(WebHistory::removeItemFromDateCaches):

  • WebKitCOMAPI.cpp:

(classFactory):

  • WebKitStatistics.cpp:

(WebKitStatistics::comClassNameCounts):

  • WebNotificationCenter.cpp:

(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::removeObserver):

Source/WebKit/wince:

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::getPluginInfo):

Source/WebKit2:

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SyncMessageState::getOrCreate):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::registerEventSourceHandler):
(WorkQueue::unregisterEventSourceHandler):

  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::unregisterMachPortEventHandler):

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::pluginDestroyed):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

  • Shared/WebPreferencesStore.cpp:

(WebKit::valueForKey):
(WebKit::WebPreferencesStore::getBoolValueForKey):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::decode):

  • Shared/qt/ArgumentCodersQt.cpp:

(CoreIPC::::decode):

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::decode):

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(_Ewk_Back_Forward_List::~_Ewk_Back_Forward_List):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context::~_Ewk_Context):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_priv_loading_resources_clear):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_subresources):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseContainerForall):

  • UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _expectedPreviewCallbackForRect:]):
(pageDidDrawToPDF):
(-[WKPrintingView _drawPreview:]):

  • UIProcess/API/mac/WKView.mm:

(commandNameForSelector):
(-[WKView validateUserInterfaceItem:]):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::updateTile):
(WebKit::CoordinatedBackingStore::texture):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
(WebKit::CoordinatedBackingStore::commitTileOperations):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::LayerTreeRenderer::syncCanvas):
(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::setLayerFilters):
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::assignImageToLayer):

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests):

  • UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit::WebInspectorServer::~WebInspectorServer):
(WebKit::WebInspectorServer::registerPage):

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):

  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:

(WebKit::WebInspectorServer::buildPageList):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):

  • UIProcess/WebContext.cpp:

(WebKit::createDictionaryFromHashMap):

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::didFinishURLImport):

  • UIProcess/WebIntentData.cpp:

(WebKit::WebIntentData::extras):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
(WebKit::WebProcessProxy::addBackForwardItem):
(WebKit::WebProcessProxy::frameCountInPage):

  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:

(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::didReceiveGeolocationPermissionDecision):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):

  • WebProcess/InjectedBundle/InjectedBundleIntent.cpp:

(WebKit::InjectedBundleIntent::extras):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::removeNotificationFromContextMap):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::destroyStream):
(WebKit::NetscapePlugin::frameDidFinishLoading):
(WebKit::NetscapePlugin::frameDidFail):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::buildHTTPHeaders):
(WebKit::PluginView::~PluginView):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::layerByID):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::removeItem):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::commandNameForSelectorName):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
(WebKit::WebProcess::focusedWebPage):
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::webPageGroup):
(WebKit::fromCountedSetToHashMap):
(WebKit::WebProcess::setTextCheckerState):

Source/WTF:

Currently HashMap iterators follow the same interface in std::map: given an
iterator it, we use it->first to access the key and it->second to access the
value. This patch changes these accesses to it->key and it->value, improving the
readability at call sites.

One potential downside of this change would be the confusion between std::map and
HashMap interfaces. However, they are already different in other aspects and the
usage of std::map is more an exception than a rule in WebKit code, so we consider
the confusion will be less likely to happen.

  • wtf/HashCountedSet.h:

(WTF::::add):
(WTF::::remove):
(WTF::copyToVector):

  • wtf/HashIterators.h:

(WTF::HashTableConstKeysIterator::get):
(WTF::HashTableConstValuesIterator::get):
(WTF::HashTableKeysIterator::get):
(WTF::HashTableValuesIterator::get):

  • wtf/HashMap.h:

(WTF::KeyValuePairKeyExtractor::extract):
(WTF::HashMapValueTraits::isEmptyValue):
(WTF::HashMapTranslator::translate):
(WTF::HashMapTranslatorAdapter::translate):
(WTF::::set):
(WTF::::get):
(WTF::::take):
(WTF::operator==):
(WTF::deleteAllValues):
(WTF::deleteAllKeys):
Removed deleteAllPairFirsts() and deleteAllPairSeconds() since they are now unused.

  • wtf/HashTable.h:

(WTF::hashTableSwap):
(WTF::::checkTableConsistencyExceptSize):

  • wtf/HashTraits.h:

(WTF):
(WTF::KeyValuePair::KeyValuePair):
(KeyValuePair):
(WTF::KeyValuePairHashTraits::constructDeletedValue):
(WTF::KeyValuePairHashTraits::isDeletedValue):

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::addFreeSpace):
(WTF::MetaAllocator::incrementPageOccupancy):
(WTF::MetaAllocator::decrementPageOccupancy):

  • wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::~RefCountedLeakCounter):

  • wtf/RefPtrHashMap.h:

(WTF::::set):
(WTF::::get):
(WTF::::inlineGet):
(WTF::::take):

  • wtf/Spectrum.h:

(WTF::Spectrum::add):
(WTF::Spectrum::get):
(WTF::Spectrum::buildList):

  • wtf/ThreadingPthreads.cpp:

(WTF::identifierByPthreadHandle):

Tools:

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(MockWebSpeechInputController::addMockRecognitionResult):

  • DumpRenderTree/chromium/NotificationPresenter.cpp:

(NotificationPresenter::simulateClick):
(NotificationPresenter::show):

  • DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:

(CppBoundClass::~CppBoundClass):
(CppBoundClass::invoke):
(CppBoundClass::getProperty):
(CppBoundClass::setProperty):
(CppBoundClass::bindCallback):
(CppBoundClass::bindProperty):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(applyFontMap):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printResourceDescription):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(worldIDForWorld):
(TestRunner::evaluateScriptInIsolatedWorld):

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::~AccessibilityController):
(AccessibilityController::winNotificationReceived):

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::descriptionSuitableForTestResult):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(worldIDForWorld):
(TestRunner::evaluateScriptInIsolatedWorld):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::worldIDForWorld):
(WTR::TestRunner::evaluateScriptInIsolatedWorld):

3:56 PM Changeset in webkit [130611] by ggaren@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION (r130584): Crashes in JSC::MarkedAllocator::allocateSlowCase, failing fast/dom/gc-dom-tree-lifetime.html
https://bugs.webkit.org/show_bug.cgi?id=98612

Reviewed by Darin Adler.

Since DOM modification can happen outside of JS, calls into JS due to
DOM modification need to take the JS lock.

  • bindings/js/JSNodeCustom.cpp:

(WebCore::willCreatePossiblyOrphanedTreeByRemovalSlowCase): Take the JS
lock before doing a JS allocation, since this may be a JS entrypoint.

  • bindings/js/JSNodeCustom.h:

(WebCore::willCreatePossiblyOrphanedTreeByRemoval): Split out a slow case
to help the inliner.

3:14 PM Changeset in webkit [130610] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[chromium] Crash in WebCore::GraphicsLayerChromium::setContentsToImage
https://bugs.webkit.org/show_bug.cgi?id=98456

Patch by Nick Carter <nick@chromium.org> on 2012-10-07
Reviewed by James Robinson.

Source/WebCore:

Handle null return of nativeImageForCurrentFrame.

Test: compositing/images/truncated-direct-png-image.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):

LayoutTests:

New tests exercising a broken image on its own layer.

  • compositing/images/truncated-direct-png-image-expected.html: Added.
  • compositing/images/truncated-direct-png-image.html: Added.
3:01 PM Changeset in webkit [130609] by benjamin@webkit.org
  • 10 edits in trunk/Source

WTFURL: implement URL port removal for HTMLAnchorElement
https://bugs.webkit.org/show_bug.cgi?id=98604

Reviewed by Adam Barth.

Source/WebCore:

  • platform/KURLWTFURL.cpp:

(WebCore::KURL::hasPort):
(WebCore::KURL::removePort):
(WebCore::KURL::isHierarchical):
Implement those methods to pass the port removal test of HTMLAnchorElement.

Source/WTF:

Add hasStandardScheme() (similar to isStandard from Google URL),
hasPort() and removePort() to implement the port removal of KURL.

  • wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::hasStandardScheme):
(WTF::ParsedURL::hasPort):
(WTF::ParsedURL::removePort):

  • wtf/url/api/ParsedURL.h:

(ParsedURL):

  • wtf/url/src/URLComponent.h:

(WTF::URLComponent::move):

  • wtf/url/src/URLSegments.cpp:

(WTF::URLSegments::moveComponentsAfter):

  • wtf/url/src/URLSegments.h:

(URLSegments):

  • wtf/url/src/URLUtil.cpp:

(URLUtilities):
(WTF::URLUtilities::isStandard):

  • wtf/url/src/URLUtil.h:

(URLUtilities):
Remove LowerCaseEqualsASCII() from the interface, make it an internal template.

(WTF::URLUtilities::isStandard):
Since in WebKit, LChar is a superset of char, expose LChar and cast char* to LChar*.

12:33 PM Changeset in webkit [130608] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Web process XPC services don't have correct version information in their Info.plist files
https://bugs.webkit.org/show_bug.cgi?id=98619

Reviewed by Anders Carlsson.

  • WebProcessService/Info.plist: Added CFBundleGetInfoString, and changed

CFBundleShortVersionString and CFBundleVersion to report the source version.

  • WebProcessServiceForWebKitDevelopment/Info.plist: Ditto.
12:20 PM Changeset in webkit [130607] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark media/video-controls-rendering.html as flaky.

  • platform/efl/TestExpectations:
11:38 AM Changeset in webkit [130606] by Lucas Forschler
  • 3 edits in tags/Safari-537.13.1/Source/JavaScriptCore

Rollout r130344. <rdar://problem/12448776>

11:36 AM Changeset in webkit [130605] by rakuco@webkit.org
  • 2 edits
    62 adds in trunk/LayoutTests

[EFL] Unskip svg/W3C-SVG-1.1-SE and add expectations for it.

All pixel tests look OK (compared to the ones in mac/), and all
tests seem to pass.

  • platform/efl/TestExpectations:
  • platform/efl/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
11:34 AM Changeset in webkit [130604] by Lucas Forschler
  • 4 edits in tags/Safari-537.13.1/Source

Versioning.

11:31 AM Changeset in webkit [130603] by Lucas Forschler
  • 1 copy in tags/Safari-537.13.1

New Tag.

11:23 AM Changeset in webkit [130602] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip passing test.

  • platform/efl/TestExpectations:
11:14 AM Changeset in webkit [130601] by rakuco@webkit.org
  • 5 edits
    47 adds in trunk/LayoutTests

[EFL] Finish rebaselining the SVG tests after r130599.

  • platform/efl/TestExpectations:
  • platform/efl/svg/W3C-SVG-1.1: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-use-05-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png: Added.
  • platform/efl/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Added.
  • platform/efl/svg/batik/paints/patternRegions-expected.txt:
  • platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/efl/svg/batik/text/textEffect-expected.txt: Added.
  • platform/efl/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/efl/svg/custom: Added.
  • platform/efl/svg/custom/clip-mask-negative-scale-expected.png: Added.
  • platform/efl/svg/custom/clip-mask-negative-scale-expected.txt: Added.
  • platform/efl/svg/custom/gradient-deep-referencing-expected.png: Added.
  • platform/efl/svg/custom/gradient-deep-referencing-expected.txt: Added.
  • platform/efl/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
  • platform/efl/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
  • platform/efl/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/efl/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/efl/svg/custom/radialGradient-focal-radius-expected.txt: Added.
  • platform/efl/svg/custom/recursive-gradient-expected.png: Added.
  • platform/efl/svg/custom/recursive-gradient-expected.txt: Added.
  • platform/efl/svg/custom/relative-sized-content-with-resources-expected.png: Added.
  • platform/efl/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
  • platform/efl/svg/custom/stroked-pattern-expected.png: Added.
  • platform/efl/svg/custom/stroked-pattern-expected.txt: Added.
  • platform/efl/svg/hixie/perf/006-expected.txt:
9:38 AM Changeset in webkit [130600] by dbates@webkit.org
  • 13 edits in trunk/LayoutTests

Update expected results for SVG tests on EFL, GTK, and Qt after <http://trac.webkit.org/changeset/130599>
https://bugs.webkit.org/show_bug.cgi?id=97986

  • platform/efl/svg/filters/feDisplacementMap-expected.txt:
  • platform/efl/svg/filters/filterRes-expected.txt:
  • platform/gtk/svg/custom/gradient-attr-update-expected.txt:
  • platform/gtk/svg/custom/gradient-rotated-bbox-expected.txt:
  • platform/gtk/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/gtk/svg/custom/large-bounding-box-percents-expected.txt:
  • platform/gtk/svg/filters/feDisplacementMap-expected.txt:
  • platform/gtk/svg/filters/filterRes-expected.txt:
  • platform/qt/svg/custom/gradient-attr-update-expected.txt:
  • platform/qt/svg/custom/gradient-rotated-bbox-expected.txt:
  • platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/qt/svg/custom/large-bounding-box-percents-expected.txt:
7:36 AM Changeset in webkit [130599] by krit@webkit.org
  • 47 edits
    3 adds in trunk

SVG radialGradient should support 'fr' for focal radius (just like Canvas)
https://bugs.webkit.org/show_bug.cgi?id=97986

Reviewed by Daniel Bates.

Source/WebCore:

Update SVGRadialGradient to the changed behavior in SVG2: http://www.w3.org/TR/SVG2/pservers.html#RadialGradients
SVG2 adds the focal radius for radial gradients. Color stops will start from the edge of
the focal radius.
The new specification does not limit the focal point to be inside the radial gradients radius.
This makes SVGRadialGradient consistent with the radial gradient on Canvas.

Test: svg/custom/radialGradient-focal-radius.svg

  • rendering/svg/RenderSVGResourceRadialGradient.cpp:

Remove checks for position of focal point. The focal point
can be placed every where outside the radius of the gradient now.

(WebCore::RenderSVGResourceRadialGradient::focalRadius):

Add new method to get the focal radius from SVGRadialGradientElement.

(WebCore::RenderSVGResourceRadialGradient::buildGradient):

  • rendering/svg/RenderSVGResourceRadialGradient.h:

(RenderSVGResourceRadialGradient):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGResourceContainer):

Modify DRT output to include the focal radius.

  • svg/RadialGradientAttributes.h:

(WebCore::RadialGradientAttributes::RadialGradientAttributes):
(WebCore::RadialGradientAttributes::fr):
(WebCore::RadialGradientAttributes::setFr):
(WebCore::RadialGradientAttributes::hasFr):
(RadialGradientAttributes):

New setters and getters for focal radius.

  • svg/SVGRadialGradientElement.cpp:

(WebCore):
(WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
(WebCore::SVGRadialGradientElement::isSupportedAttribute):
(WebCore::SVGRadialGradientElement::parseAttribute):
(WebCore::SVGRadialGradientElement::collectGradientAttributes):
(WebCore::SVGRadialGradientElement::selfHasRelativeLengths):

Ditto.

  • svg/SVGRadialGradientElement.h:

(SVGRadialGradientElement):

  • svg/SVGRadialGradientElement.idl:
  • svg/svgattrs.in:

Add 'fr' as new attribute to the SVG attribute list.

LayoutTests:

DRT changed the output to reflect the new added focal radius. A bunch of tests need
a rebaseline on DRT.
Added a new test for focal radius and changed behavior of focal point.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • platform/mac/svg/batik/paints/gradientLimit-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/custom/gradient-attr-update-expected.txt:
  • platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.txt:
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt:
  • platform/mac/svg/custom/large-bounding-box-percents-expected.txt:
  • platform/mac/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/mac/svg/custom/radialGradient-focal-radius-expected.txt: Added.
  • platform/mac/svg/custom/recursive-gradient-expected.txt:
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/hixie/perf/006-expected.txt:
  • svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
  • svg/custom/gradient-stroke-width-expected.txt:
  • svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
  • svg/custom/radialGradient-focal-radius.svg: Added.
7:22 AM Changeset in webkit [130598] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Use start instead of -webkit-auto in default and quirks mode stylesheets.
https://bugs.webkit.org/show_bug.cgi?id=98609

Patch by Glenn Adams <glenn@skynav.com> on 2012-10-07
Reviewed by Antti Koivisto.

Change text-align use of legacy '-webkit-auto' to 'start' in the few places where it is used
in default/quirks stylesheets.

No new tests. No change of rendering/styling behavior. No performance impact.

  • css/html.css:

(input, textarea, keygen, select, button, isindex):
(ruby > rt):

  • css/quirks.css:

(table):

7:16 AM Changeset in webkit [130597] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, rolling out r130596.
http://trac.webkit.org/changeset/130596
https://bugs.webkit.org/show_bug.cgi?id=98616

Broke build bots without IPV6 support

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-10-07

Tools:

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.is_cygwin):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_version_dir):
(Port.to.start_websocket_server):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_operating_system):
(PortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd):
(LayoutTestApacheHttpd.init):

LayoutTests:

  • http/conf/apache2-debian-httpd.conf:
  • http/conf/apache2-httpd.conf:
  • http/conf/cygwin-httpd.conf:
  • http/conf/fedora-httpd.conf:
6:19 AM Changeset in webkit [130596] by rakuco@webkit.org
  • 10 edits in trunk

webkitpy: Pass the `Listen' Apache directive from Apache, not the httpd.conf files.
https://bugs.webkit.org/show_bug.cgi?id=98602

Reviewed by Eric Seidel.

Tools:

Unify all the different `Listen' directives present in the several
httpd.conf files we have in LayoutTests/http/conf. For one, we
were already passing `Listen 127.0.0.1:8000' via webkitpy before,
and opening the other ports from the conf files.

The configuration files differed mostly in the way they handled
IPV6 ports. Some of them did not listen to IPV6 ports because the
systems which used them sometimes did not have IPV6 support. The
`http_server_supports_ipv6' method has been added to Port to
address that. cygwin, on its turn, still seems to use Apache 1.3,
which does not support IPV6 at all; the newly-added method has a
special case for that.

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.is_cygwin):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_version_dir):
(Port.to.start_websocket_server):
(Port.to):
(Port.to.http_server_supports_ipv6):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_http_server_supports_ipv6):
(PortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd):
(LayoutTestApacheHttpd.init):

LayoutTests:

  • http/conf/apache2-debian-httpd.conf: Remove the `Listen'

directive and related comments, it is passed to httpd by webkitpy
now.

  • http/conf/apache2-httpd.conf: Ditto.
  • http/conf/cygwin-httpd.conf: Ditto.
  • http/conf/fedora-httpd.conf: Ditto.
6:17 AM Changeset in webkit [130595] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip css3/masking tests added in r130592
https://bugs.webkit.org/show_bug.cgi?id=98614

Unreviewed EFL gardening.

Skip the two css3/masking ref tests added in r130592 since
they fail for EFL port and GTK port.

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-07

  • platform/efl/TestExpectations:
2:01 AM Changeset in webkit [130594] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding crash and failure expectations for regressions introduced through r130584.
Adding image mismatch expectations for two new tests introduced in r130592.

  • platform/gtk/TestExpectations:

Oct 6, 2012:

6:55 PM Changeset in webkit [130593] by tkent@chromium.org
  • 7 edits in trunk/LayoutTests

Update test expectation
https://bugs.webkit.org/show_bug.cgi?id=98479

Skip tests in fast/forms/date-multiple-fields/ because it needs
ENABLE_INPUT_MULTIPLE_FIELDS_UI.

  • platform/chromium-android/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
6:35 PM Changeset in webkit [130592] by krit@webkit.org
  • 9 edits
    8 adds in trunk

-webkit-clip-path should parse IRIs
https://bugs.webkit.org/show_bug.cgi?id=96381

Patch by Raul Hudea <rhudea@adobe.com> on 2012-10-06
Reviewed by Andreas Kling.

Source/WebCore:

Implemented the clipping via referencing a SVG clipPath. Currently it works only if the clipPath is defined
before using it on an HTML element. The forward reference issue is tracked via https://bugs.webkit.org/show_bug.cgi?id=90405.

Tests: css3/masking/clip-path-reference-userSpaceOnUse.html

css3/masking/clip-path-reference.html
fast/masking/parsing-clip-path-iri.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add handling for SVG clipPath references.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Add handling for SVG clipPath references.

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyClipPath::applyValue): Add handling for SVG references.

  • rendering/ClipPathOperation.h:

(ReferenceClipPathOperation): Added a new class corresponding to SVG referenced clipPath.
(WebCore::ReferenceClipPathOperation::create):
(WebCore::ReferenceClipPathOperation::url):
(WebCore::ReferenceClipPathOperation::fragment):
(WebCore::ReferenceClipPathOperation::operator==):
(WebCore::ReferenceClipPathOperation::ReferenceClipPathOperation):
(WebCore):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents): Add handling for ReferenceClipPathOperation.

  • rendering/svg/RenderSVGResourceClipper.h:

(RenderSVGResourceClipper): Made applyClippingToContext public as it needs to be called directly for HTML elements.

LayoutTests:

Tests for SVG referenced clipPath with both types of clipPathUnits: "userSpaceOnUse" and "objectBoundingBox".

  • css3/masking/clip-path-reference-expected.html: Added.
  • css3/masking/clip-path-reference-userSpaceOnUse-expected.html: Added.
  • css3/masking/clip-path-reference-userSpaceOnUse.html: Added.
  • css3/masking/clip-path-reference.html: Added.
  • fast/masking/parsing-clip-path-iri-expected.txt: Added.
  • fast/masking/parsing-clip-path-iri.html: Added.
  • platform/chromium/TestExpectations:
5:02 PM Changeset in webkit [130591] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Reduce calls to CGImageSourceCopyPropertiesAtIndex from frameSizeAtIndex
https://bugs.webkit.org/show_bug.cgi?id=98607

Reviewed by Dan Bernstein.

Refactor code so that we avoid a second call to CGImageSourceCopyPropertiesAtIndex under
ImageSource::frameSizeAtIndex().

No new tests because no functional change.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::orientationFromProperties):
(WebCore):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):

2:51 PM Changeset in webkit [130590] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

Stop calling -[NSSliderCell setTitle:]. It's never done anything on OS X.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::sliderThumbHorizontal):
(WebCore::RenderThemeMac::sliderThumbVertical):

1:03 PM Changeset in webkit [130589] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark media/audio-garbage-collect.html as flaky on WK2.

  • platform/efl-wk2/TestExpectations:
12:14 PM Changeset in webkit [130588] by kling@webkit.org
  • 22 edits in trunk/Source/WebCore

Clipboard::types() should return an ordered collection.
<http://webkit.org/b/98547>

Reviewed by Darin Adler.

Let Clipboard::types() return a ListHashSet<String> instead of a HashSet<String> to make sure
it retains the order in which type strings are added.

No test, this fixes an issue that was uncovered when lowering the default table size of WTF
hash tables, causing the HashSet<String> to rehash and reorder itself.

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):

  • dom/Clipboard.h:

(Clipboard):

  • platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::types):

  • platform/blackberry/ClipboardBlackBerry.h:

(ClipboardBlackBerry):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):

  • platform/chromium/ChromiumDataObject.h:

(ChromiumDataObject):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::types):

  • platform/chromium/ClipboardChromium.h:

(ClipboardChromium):

  • platform/efl/ClipboardEfl.cpp:

(WebCore::ClipboardEfl::types):

  • platform/efl/ClipboardEfl.h:

(ClipboardEfl):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::types):

  • platform/gtk/ClipboardGtk.h:

(ClipboardGtk):

  • platform/mac/ClipboardMac.h:

(ClipboardMac):

  • platform/mac/ClipboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::types):

  • platform/qt/ClipboardQt.h:

(ClipboardQt):

  • platform/win/ClipboardWin.cpp:

(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):

  • platform/win/ClipboardWin.h:

(ClipboardWin):

  • platform/wx/ClipboardWx.cpp:

(WebCore::ClipboardWx::types):

  • platform/wx/ClipboardWx.h:

(ClipboardWx):

11:51 AM Changeset in webkit [130587] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

If Node X is reachable from JavaScript, all Nodes in the same tree should be kept alive
https://bugs.webkit.org/show_bug.cgi?id=88834

Reviewed by Gavin Barraclough.

Follow-up patch to address some comments by Darin Adler.

  • bindings/js/JSNodeCustom.h:

(WebCore::willCreatePossiblyOrphanedTreeByRemoval): Save some space by
collapsing comment lines. Use Node::hasChildNodes() for brevity.

11:44 AM Changeset in webkit [130586] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix weird use of KURL's protocolIs
https://bugs.webkit.org/show_bug.cgi?id=98584

Reviewed by Adam Barth.

Converting a KURL to string is a bad idea.

Invalid URLs can return a string that pass the tests, while an
invalid URL will fail protocolIs().

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::removeClient):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::load):

  • platform/network/DataURL.cpp:

(WebCore::handleDataURL):

11:37 AM Changeset in webkit [130585] by mitz@apple.com
  • 11 edits in trunk/Source

Source/WebCore: WebCore part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
https://bugs.webkit.org/show_bug.cgi?id=98601

Reviewed by Darin Adler.

  • WebCore.exp.in: Exported Font::setDefaultTypesettingFeatures().
  • platform/graphics/Font.cpp:

(WebCore::Font::s_defaultTypesettingFeatures): Defined this static.
(WebCore::Font::setDefaultTypesettingFeatures): Added this setter.
(WebCore::Font::defaultTypesettingFeatures): Added this getter.

  • platform/graphics/Font.h:

(WebCore::Font::typesettingFeatures): Changed to use the value of the new static member
s_defaultTypesettingFeatures, rather than 0, if text-redering is set to auto.

Source/WebKit/mac: WebKit/mac part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
https://bugs.webkit.org/show_bug.cgi?id=98601

Reviewed by Darin Adler.

  • WebView/WebView.mm:

(+[WebView initialize]): Added a call to Font::setDefaultTypesettingFeatures() to enable
kerning and ligatures if the WebKitKerningAndLigaturesEnabledByDefault user default key has
the value YES.

Source/WebKit2: WebKit2 part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
https://bugs.webkit.org/show_bug.cgi?id=98601

Reviewed by Darin Adler.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Added initializer for
to shouldEnableKerningAndLigaturesByDefault. The initial value is false.
(WebKit::WebProcessCreationParameters::encode): Added encoding of
shouldEnableKerningAndLigaturesByDefault.
(WebKit::WebProcessCreationParameters::decode): Added decoding of
shouldEnableKerningAndLigaturesByDefault.

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters): Added shouldEnableKerningAndLigaturesByDefault boolean
member variable.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess): Changed to set
shouldEnableKerningAndLigaturesByDefault in the process creation parameters according to
the value of the WebKitKerningAndLigaturesEnabledByDefault user defaults key.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Added a call to
Font::setDefaultTypesettingFeatures() to enable kerning and ligatures if requested in the
process creation parameters.

11:27 AM Changeset in webkit [130584] by ggaren@apple.com
  • 10 edits
    4 adds in trunk

If Node X is reachable from JavaScript, all Nodes in the same tree should be kept alive
https://bugs.webkit.org/show_bug.cgi?id=88834

Reviewed by Gavin Barraclough.

Source/WebCore:

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isObservable): Clarified this comment, since it seems to have
misled some folks.

  • bindings/js/JSNodeCustom.h:

(WebCore::willCreatePossiblyOrphanedTreeByRemoval): New helper function
to ensure that a disconnected tree is visible to JavaScript.

  • bindings/js/ScriptState.cpp:

(WebCore::mainWorldScriptState): Need to check for null because a document's
frame can be null.

  • dom/ContainerNode.cpp:

(WebCore::dispatchChildRemovalEvents): When we remove a subtree from the
document, we sever the reference that JavaScript previously held by
referencing its root. So, we give JavaScript an opportunity to establish
a reference to the new root.

LayoutTests:

  • fast/dom/gc-12-expected.txt: Added.
  • fast/dom/gc-12.html: Added. Test case matches an example cited by

Kentaro Hara <haraken@chromium.org> in bugzilla.

  • fast/dom/gc-3-expected.txt:
  • fast/dom/gc-3.html:
  • fast/dom/gc-5-expected.txt:
  • fast/dom/gc-5.html: Updated these tests to reflect new expected behavior.

We've decided that disconnected trees should persist in memory. This risks
a programmer accidentally retaining more memory than expected, but it
also makes the API more obvious.

  • fast/dom/gc-dom-tree-lifetime-expected.txt: Added.
  • fast/dom/gc-dom-tree-lifetime.html: Added. Test case written by

Kentaro Hara <haraken@chromium.org>.

9:55 AM Changeset in webkit [130583] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening.

Skip fast/selectors/unqualified-hover-strict.html because it seems
to be flaky.

While here, correct its pixel expectation and fix its
svn:mime-type property.

  • platform/efl/fast/selectors/unqualified-hover-strict-expected.png: Modified property svn:mime-type.
3:35 AM Changeset in webkit [130582] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix build warning : -Wunused-parameter.
https://bugs.webkit.org/show_bug.cgi?id=98583

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-06
Reviewed by Kentaro Hara.

Use ASSERT_UNUSED() macro to remove build warning.

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::delayDeliveryTimerFired):
(WebCore::PluginStream::didReceiveResponse):
(WebCore::PluginStream::didReceiveData):
(WebCore::PluginStream::didFail):
(WebCore::PluginStream::didFinishLoading):

  • plugins/PluginView.cpp:

(WebCore::PluginView::requestTimerFired):
(WebCore::PluginView::invalidateTimerFired):

2:26 AM Changeset in webkit [130581] by loislo@chromium.org
  • 5 edits in trunk/Source

Web Inspector: NMI fix String instrumentation the way it was discussed in WK97964
https://bugs.webkit.org/show_bug.cgi?id=98500

Reviewed by Benjamin Poulain.

Current instrumentation incorrectly covers the case when StringImpl object has been created via StringImpl::createWithTerminatingNullCharacter().
Looks like the only way to detect the strings that has been created from literals is to compare the addresses of buffer and stringImpl + 1.

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

Source/WTF:

  • wtf/MemoryInstrumentationString.h:

(WTF::reportMemoryUsage):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::hasInternalBuffer):

2:03 AM Changeset in webkit [130580] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=98590

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06

  • platform/efl/TestExpectations: Skip

fast/writing-mode/vertical-subst-font-vert-no-dflt.html after r130570.

  • platform/efl/http/tests/misc/acid3-expected.txt: Update baselines

after r130555.

2:01 AM Changeset in webkit [130579] by commit-queue@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

[EFL] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=98576

Unreviewed EFL gardening.

Add platform-specific baselines after r130443 and r130489.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06

  • platform/efl/TestExpectations:
  • platform/efl/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
  • platform/efl/fast/repaint/box-shadow-inset-repaint-expected.txt: Added.
  • platform/efl/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
  • platform/efl/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
1:58 AM Changeset in webkit [130578] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

[EFL] Gardening of the WK2 Debug Bot failing tests
https://bugs.webkit.org/show_bug.cgi?id=98575

Unreviewed EFL gardening.

Skip failing tests in order to make the bots green.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/fast/replaced/object-with-embed-url-param-expected.txt: Removed. Current results

matches the base expectations on WK2.

1:08 AM Changeset in webkit [130577] by benjamin@webkit.org
  • 3 edits in trunk/Source/WTF

Fix build of WTFURL after r130187
https://bugs.webkit.org/show_bug.cgi?id=98588

Reviewed by Kentaro Hara.

  • wtf/MemoryInstrumentationParsedURL.h:

(WTF::reportMemoryUsage):

  • wtf/url/api/ParsedURL.h:

(WTF::ParsedURL::spec):

Note: See TracTimeline for information about the timeline view.