Timeline



Oct 23, 2012:

11:48 PM WebKit Team edited by kihong.kwon@samsung.com
(diff)
11:44 PM Changeset in webkit [132317] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] TestWebKitAPI/TestWebKit2 and TestWebKitAPI/TestGtk link to the installed libs
https://bugs.webkit.org/show_bug.cgi?id=100134

Reviewed by Martin Robinson.

Do not share the LDADD variable among TestWTF, TestWebKit2 and
TestGtk.

  • TestWebKitAPI/GNUmakefile.am:
11:43 PM Changeset in webkit [132316] by zoltan@webkit.org
  • 2 edits in trunk/PerformanceTests

Store the loaded file locally in measurePageLoadTime
https://bugs.webkit.org/show_bug.cgi?id=100172

Reviewed by Csaba Osztrogonác.

Store the loaded file as a local variable instead of attaching it to the test object.
Handle chunkSize inside test.run.

  • resources/runner.js:

(.):

11:35 PM Changeset in webkit [132315] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Memory instrumentation: don't count agent-specific front-ends separately
https://bugs.webkit.org/show_bug.cgi?id=100087

Reviewed by Alexander Pavlov.

Pointers to domain-specific inspector front-end interfaces are reported as
weak pointers instead of members to avoid double-counting.

Test by comparing set of reported instrumented objects with the set of objects
allocated by tcmalloc.

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::reportMemoryUsage):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

11:27 PM Changeset in webkit [132314] by Dave Barton
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Some linux MathML tests are timing out - see webkit.org/b/100202.

  • platform/chromium/TestExpectations:
11:23 PM Changeset in webkit [132313] by kihong.kwon@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
11:16 PM Changeset in webkit [132312] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

Regression(r132303) Broke debug build when SHADOW_DOM is enabled but STYLE_SCOPED is disabled
https://bugs.webkit.org/show_bug.cgi?id=100203

Unreviewed Build fix.

Fix compilation error in StyleResolver.h when SHADOW_DOM flag is
set and STYLE_SCOPED is not.

No new tests, no behavior change.

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23

  • css/StyleResolver.h:

(WebCore::StyleResolver::ensureScopeResolver):

10:27 PM Changeset in webkit [132311] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove specialized hash traits for GlyphPages.
<http://webkit.org/b/100185>

Reviewed by Dan Bernstein.

Now that the default minimum table size has been lowered for all tables, there's no need
for this specialization anymore.

  • platform/graphics/FontFallbackList.h:

(FontFallbackList):

10:22 PM Changeset in webkit [132310] by tkent@chromium.org
  • 5 edits in trunk

Multiple fields input UI: Don't use CSS properties for physical direction
https://bugs.webkit.org/show_bug.cgi?id=100195

Reviewed by Kentaro Hara.

Source/WebCore:

CSS declarations such as "padding: 0 0 0 1px;" "margin-left: 0.2em;" are
not direction-neutral, and makes unexpected appearance in RTL. We should
use -webkit-padding-start or -webkit-margin-start.

No new tests. Covered by date-multiple-fields-appearance-l10n.html and
month-multiple-fields-appearance-l10n.html

  • css/html.css:

(input[type="date"]): Use padding:0 and -webkit-padding-start:1px;
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input[type="week"]::-webkit-inner-spin-button):
Use -webkit-margin-start. Also use an integral pixel size instead of
avoid a fractional relative size to avoid subpixel layout rounding.

LayoutTests:

  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
10:13 PM Changeset in webkit [132309] by mitz@apple.com
  • 7 edits in trunk

Source/WebKit/mac: WebKit/mac part of <rdar://problem/2966974> [mac] Kerning and ligatures are not enabled by default
https://bugs.webkit.org/show_bug.cgi?id=100188

Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(+[WebView initialize]): Added a local variable to hold the standard user defaults. Added
code to register a value of YES for the WebKitKerningAndLigaturesEnabledByDefault user
default. Changed to refer to that default key by name.

Source/WebKit2: WebKit2 part of <rdar://problem/2966974> [mac] Kerning and ligatures are not enabled by default
https://bugs.webkit.org/show_bug.cgi?id=100188

Reviewed by Sam Weinig.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::registerUserDefaultsIfNeeded): Added. Registers a value of YES for the
WebKitKerningAndLigaturesEnabledByDefault user default if it has not been registered yet.
(WebKit::WebContext::platformInitializeWebProcess): Added a call to
registerUserDefaultsIfNeeded, and changed to refer to the defaults key by name.

Tools: Tools changes for <rdar://problem/2966974> [mac] Kerning and ligatures are not enabled by default
https://bugs.webkit.org/show_bug.cgi?id=100188

Reviewed by Sam Weinig.

Disable kerning and ligatures by default when running the tests.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues): Set a value of NO for the
WebKitKerningAndLigaturesEnabledByDefault user default.

  • WebKitTestRunner/mac/main.mm:

(main): Register a value of NO for the WebKitKerningAndLigaturesEnabledByDefault user
default.

10:12 PM Changeset in webkit [132308] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

The font cache evicts inactive font data too aggressively when not under memory pressure
https://bugs.webkit.org/show_bug.cgi?id=100194

Reviewed by Sam Weinig.

Increasing the number of inactive font data objects the cache may hold increases the hit
rate, leading to improved page load performance. When memory pressure is detected,
MemoryPressureHandler evicts all inactive objects, regardless of the limits we are
increasing here.

  • platform/graphics/FontCache.cpp:

(WebCore): Increased the maximum number of inactive font data objects in the cache from 50
to 225, and the number of objects to evict once the limit is met from 20 to 25.

10:10 PM Changeset in webkit [132307] by kling@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

CodeBlock: Give m_putToBaseOperations an inline capacity.
<http://webkit.org/b/100190>
<rdar://problem/12562466>

Reviewed by Oliver Hunt.

Since the CodeBlock constructor always inserts a single PutToBaseOperation, but there's no
guarantee that more will follow, give the m_putToBaseOperations vector an inline capacity of 1.
There are 4009 of these Vectors on Membuster3, and only 126 of them have more than a single entry.

This change yields a 1.90MB reduction in memory usage.

  • bytecode/CodeBlock.h:

(CodeBlock):

9:56 PM Changeset in webkit [132306] by tkent@chromium.org
  • 68 edits
    10 adds in trunk/LayoutTests

[Chromium] Rebaseline for r132291
https://bugs.webkit.org/show_bug.cgi?id=100088

  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
9:50 PM Changeset in webkit [132305] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed nightly gardening, skip new failing tests.

  • platform/qt/TestExpectations:
9:45 PM Changeset in webkit [132304] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Remove duplicate platform/mac entries
https://bugs.webkit.org/show_bug.cgi?id=100167

Reviewed by Dirk Pranke.

We intentionally don't run platform/mac tests in Chromium. Remove lines
that duplicate the directory WontFix.

  • platform/chromium/TestExpectations:
9:37 PM Changeset in webkit [132303] by tasak@google.com
  • 15 edits
    2 adds in trunk

[Shadow DOM] Needs @host rule for ShadowDOM styling
https://bugs.webkit.org/show_bug.cgi?id=88606

Reviewed by Hajime Morita.

Source/WebCore:

Implemented @host-@rules according to the shadow dom spec:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#host-at-rule
The design doc is:
https://docs.google.com/document/d/1P2yorchF8lci2sccr-mVSRf2dtvjKeiuyQWzCB2bEA8/edit

Test: fast/dom/shadow/athost-atrules.html

  • css/CSSGrammar.y.in:

Added rules for parsing @host @-rules.

  • css/CSSParser.cpp:

(WebCore::CSSParser::detectAtToken):
Added a new token "@host".
(WebCore::CSSParser::createHostRule):
Added a new method to create an @host @-rule, which is invoked from
(WebCore):

  • css/CSSParser.h:

Added a declaration of the above new method: createHostRule.

  • css/CSSPropertySourceData.h:

Added HOST_RULE to enum Type.

  • css/RuleSet.cpp:

(WebCore::RuleData::RuleData):
Modified multiple bool arguments into one argument. Now it
uses combinations of values from enum AddRuleFlags.
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addStyleRule):
Updated according to the RuleData's change.
Modified to Invoke increaseSpecificity if the given rule is @host
@-rule.
(WebCore::RuleSet::addRulesFromSheet):
Invoked addHostRule if the given rule is @host @-rule.

  • css/RuleSet.h:

(RuleData):
(WebCore::RuleData::increaseSpecificity):
Added a new method to increase selector's specificity. This method is
used to make @host @-rules' specificity larger than normal author
rules' specificity.
(RuleSet):

  • css/StyleResolver.cpp:

(WebCore::makeRuleSet):
(WebCore::StyleResolver::addHostRule):
A wrapper method to invoke StyleScopeResolver::addHostRule. The method
is used to make only StyleResolver know an implementation detail about
class StyleScopeResolver.
(WebCore::StyleResolver::appendAuthorStylesheets):
Updated according to the RuleData's change.
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
A new method to find matched host rules when an element is given.
This method invokes
StyleScopeResolver::styleSharingCandidateMatchesHostRules to find
matched host rules.
(WebCore):
(WebCore::StyleResolver::matchHostRules):
A new method to find matched host rules when an element is given.
This method invokes StyleScopeResolver::matchHostRules to find
matched host rules.
(WebCore::StyleResolver::matchScopedAuthorRules):
Modified to invoke matchHostRules.
(WebCore::StyleResolver::locateSharedStyle):
Disable sibling style cache if the given element is a shadow host and
any @host @-rules are applied to the element.

  • css/StyleResolver.h:

(WebCore::StyleResolver::ensureScopeResolver):
If no scopeResolver is created, create and return the instance.
If created, just return the instance.
(StyleResolver):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleHost::StyleRuleHost):
Implemented class StyleRuleHost. The class is almost the same as
StyleRuleBlock except type.
(WebCore):

  • css/StyleRule.h:

(WebCore::StyleRuleBase::isHostRule):
(StyleRuleHost):
(WebCore::StyleRuleHost::create):
(WebCore::StyleRuleHost::copy):
(WebCore):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::ensureAtHostRuleSetFor):
A new method to create a new RuleSet for the given shadow root.
(WebCore):
(WebCore::StyleScopeResolver::atHostRuleSetFor):
A new private inline method to obtain @host @-rules declared in
the given shadow root.
(WebCore::StyleScopeResolver::addHostRule):
Added a new method to register @host @-rules with shadow roots.
(WebCore::StyleScopeResolver::styleSharingCandidateMatchesHostRules):
A new method to find whether any @host @-rules are applied to
the given host element.
(WebCore::StyleScopeResolver::matchHostRules):
A new method to find matched rules for the given host element.
(WebCore::StyleScopeResolver::reportMemoryUsage):

  • css/StyleScopeResolver.h:

(WebCore):
(StyleScopeResolver):

  • css/StyleSheetContents.cpp:

(WebCore::childRulesHaveFailedOrCanceledSubresources):

LayoutTests:

  • fast/dom/shadow/athost-atrules-expected.txt: Added.
  • fast/dom/shadow/athost-atrules.html: Added.
9:33 PM Changeset in webkit [132302] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r130643): ASSERTION FAILED: result.iterator != end() below PluginDatabase::add
<http://webkit.org/b/100065>

Reviewed by Anders Carlsson.

Restore the pre-r130643 hash table size for PluginDatabase to prevent these easily reproducible
collisions. This will need a proper fix at some point.

  • plugins/PluginDatabase.h:
  • plugins/PluginPackage.h:

(PluginPackageHashTraits):

9:31 PM Changeset in webkit [132301] by Csaba Osztrogonác
  • 24 edits
    2 adds in trunk

Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=100159

Patch by Simon Fraser <Simon Fraser> on 2012-10-23
Reviewed by Tim Horton.

Source/WebCore:

Add a LAYER_TREE_INCLUDES_PAGE_TILE_CACHE flag for layerTreeAsText(), and plumb it
through to GraphicsLayerCA, which dumps the TiledBacking tile coverage rect.

Test: platform/mac/tiled-drawing/use-tiled-drawing.html

  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:

(showGraphicsLayerTree):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::tiledBacking):

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::tiledBacking):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/mac/TileCache.h:

(WebCore::TileCache::tileCoverageRect):
(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::computeTileCoverageRect):
(WebCore::TileCache::revalidateTiles):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText):

  • testing/Internals.h:
  • testing/Internals.idl:

Tools:

Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
whose path includes "tiled-drawing". It does this by passing around a WKDictionary
of options, and if the current PlatformWebView doesn't support those options, it will
create a new one.

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView): Add a WKDictionaryRef options dictionary argument.
(WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
supports the options in the WKDictionaryRef.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize): Call createWebViewWithOptions() with
no options in the normal case.
(WTR::TestController::createWebViewWithOptions): Moved code into this fuction
so we can call it in two places.
(WTR::TestController::ensureViewSupportsOptions): If the current view
doesn't support the given options, throw it away and makea new one that does.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
(WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
the view supports the given options. No-op for non-Mac platforms.
(WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
(-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
a custom value from this method.
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

LayoutTests:

A new test that dumps tile cache data for a large page.

  • platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Added.
  • platform/mac/tiled-drawing/use-tiled-drawing.html: Added.
9:21 PM Changeset in webkit [132300] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit

[Texmap][EFL] Add AcceleratedCompositingContextEfl to the build system.
https://bugs.webkit.org/show_bug.cgi?id=88630

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-10-23
Reviewed by Gyuyoung Kim.

Source/WebKit:

  • PlatformEfl.cmake: Add the AcceleratedCompositingContextEfl.cpp file

and INCLUDE paths for TEXTURE_MAPPER_GL.

Source/WebKit/efl:

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp: Modify the #include file.
9:15 PM Changeset in webkit [132299] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Flush pending GraphicsLayer changes when reattaching compositing layers if necessary
https://bugs.webkit.org/show_bug.cgi?id=100187
<rdar://problem/12546770>

Reviewed by Dan Bernstein.

Fix a regression from r131940. That revision changed RenderLayerCompositor::flushPendingLayerChanges()
to bail if the root layer is unattached, which indicates that we're in the page cache, or in a
background tab. However, that dropped the layer flush on the floor, so that any subsequent changes
to GraphicsLayerCAs would just pile up and never get flushed. This was most evident on pages
that require frequent flushing, such as those running animated GIFs.

Fix by setting a flag in flushPendingLayerChanges() if we're unattached. Consult the flag
when re-attaching the root layer, and if it's set, flush the GraphicsLayers.

Not testable because we can't test detaching and re-adding web views in DRT/WTR.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor): Initialize m_shouldFlushOnReattach to false.
(WebCore::RenderLayerCompositor::flushPendingLayerChanges): If the root layer attachment
is RootLayerUnattached, set the m_shouldFlushOnReattach flag before returning.
(WebCore::RenderLayerCompositor::attachRootLayer): If m_shouldFlushOnReattach, flush the layers,
saying that we're the flush root.

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor): Add m_shouldFlushOnReattach flag.

9:12 PM Changeset in webkit [132298] by Csaba Osztrogonác
  • 24 edits
    2 deletes in trunk

Unreviewed, rolling out r132276.
http://trac.webkit.org/changeset/132276
https://bugs.webkit.org/show_bug.cgi?id=100189

It broke the Qt-WK2 build intentionally (Requested by
Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-23

Source/WebCore:

  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:

(showGraphicsLayerTree):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::tiledBacking):

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::tiledBacking):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::tileCoverageRect):
(WebCore::TileCache::revalidateTiles):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText):

  • testing/Internals.h:
  • testing/Internals.idl:

Tools:

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR):
(WTR::TestInvocation::invoke):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView):

LayoutTests:

  • platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Removed.
  • platform/mac/tiled-drawing/use-tiled-drawing.html: Removed.
9:09 PM Changeset in webkit [132297] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

exif-orientation tests should use dumpAsText(true)
https://bugs.webkit.org/show_bug.cgi?id=100076

Reviewed by Eric Seidel.

  • fast/images/exif-orientation-css.html: Use dumpAsText(true).
  • fast/images/exif-orientation.html: ditto.
9:01 PM Changeset in webkit [132296] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

Coordinated Graphics: Enable threaded/IPC animations
https://bugs.webkit.org/show_bug.cgi?id=93146

Unreviewed build fix, some function names changed between review and landing.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::encodeTimingFunction):
(CoreIPC::decodeTimingFunction):
(CoreIPC::::encode):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:

(WebCore):

8:21 PM Changeset in webkit [132295] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Add extra check for data() in PageSerializer.
https://bugs.webkit.org/show_bug.cgi?id=99102

Reviewed by Eric Seidel.

The image returned from imageForRenderer() does not contain the raw SVG data
so this patch adds a check for image->image()->data() before writing SVG
in PageSerializer::addImageToResources.

Covered by existing test WebPageNewSerializeTest.SVGImageDontCrash.

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::addImageToResources):

7:53 PM Changeset in webkit [132294] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop using NSHomeDirectory() to get the home directory, it doesn't always return what we want
https://bugs.webkit.org/show_bug.cgi?id=100180

Reviewed by Anders Carlsson.

NSHomeDirectory() doesn't return the real home directory if the host process
is App Sandboxed, so drop down and use getpwuid_r instead.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::appendReadwriteSandboxDirectory):
There is no reason anymore to try to create the directory.

(WebKit::WebProcess::initializeSandbox):
Switch to getpwuid_r.

7:49 PM Changeset in webkit [132293] by commit-queue@webkit.org
  • 1 edit
    26 adds in trunk/LayoutTests

[EFL] Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=100125

Added pixel baselines for editing/pasteboard.

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-10-23

  • platform/efl/editing/pasteboard: 26 new pixel baselines.
7:16 PM Changeset in webkit [132292] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

Move appendAsLDMLLiteral in LocaleWin.cpp to a common place
https://bugs.webkit.org/show_bug.cgi?id=100129

Reviewed by Kentaro Hara.

We're going to use appendAsLDMLLiteral in other code, and it is
related to DateTimeFormat class. So we move it to DateTimeFormat
class as quoteAndAppendLiteral.

No new tests because of no behavior change.

  • platform/text/DateTimeFormat.cpp:

(WebCore::DateTimeFormat::quoteAndAppendLiteral):
Moved from LocaleWin.cpp

  • platform/text/DateTimeFormat.h:

Declare StringBuilder by wtf/Forward.h. It also declares String.
(DateTimeFormat): Declare quoteAndAppendLiteral.

  • platform/text/LocaleWin.cpp:

(WebCore): Move appendLDMLLiteral to DateTimeFormat.
(WebCore::convertWindowsDateFormatToLDML):
Follow the moving.

7:12 PM Changeset in webkit [132291] by tkent@chromium.org
  • 10 edits in trunk

REGRESSION(r131421): Text baseline is not aligned in some locales
https://bugs.webkit.org/show_bug.cgi?id=100088

Reviewed by Hajime Morita.

Source/WebCore:

Before this patch, the element with ::-webkit-datetime-edit had
-webkit-align-items:center. It was incorrect at all because it
ignores baselines of each of inner fields. We need to change it to
-webkit-align-items:baseline, or stop using -webkit-flex.

However -webkit-align-items:baseline doesn't work because a spin
button element in the element doesn't have the baseline. If we
specified -webkit-align-items:baseline, the spin button would
shift up.

So, we change the element structure for multiple fields input
elements. Before this patch, the structure was:

input

|

  • ::-webkit-date-and-time-container (flex cotainer) |
::-webkit-datetime-edit (has flexibility in date-and-time-container, also this is a flex container)
|::-webkit-datetime-edit-foo

| | :
| |

|::-webkit-date-time-edit-gap (has flexibility in datetime-edit)

| - ::-webkit-inne-spin-button

  • ::-webkit-calendar-picker-indicator

After the patch, the structure will be:

input

|

  • ::-webkit-date-and-time-container (flexible box) |
::-webkit-datetime-edit (has flexibility in date-and-time-container)
|::-webkit-datetime-edit-foo

| | :
| |
|

::-webkit-inne-spin-button

  • ::-webkit-calendar-picker-indicator

Because the spin button owner is date-and-time-container, we don't
need to make the datetime-edit element a flex container.

Also, we had rounding error by subpixel layout. To avoid it, we
stop using fractional paddings.

In order to implement this, we need to change the SpinButtonOwner
interface provider from DateTimeEditElement to
BaseMultipleFieldsDateAndTimeInputType.

No new tests. Covered by month-multiple-fields-appearance-l10n.html.

  • css/html.css:

(input::-webkit-datetime-edit): Stop making this a flex
container. Inner fields in this use the single baseline.
(input::-webkit-datetime-edit-ampm-field):
Don't use fractional paddings to avoid rounding erros of subpixel
layout. Use integral margin instead to avoid overwrap of focus
ring and background-color of the field.
(input::-webkit-datetime-edit-day-field): Ditto.
(input::-webkit-datetime-edit-hour-field): Ditto.
(input::-webkit-datetime-edit-millisecond-field): Ditto.
(input::-webkit-datetime-edit-minute-field): Ditto.
(input::-webkit-datetime-edit-month-field): Ditto.
(input::-webkit-datetime-edit-second-field): Ditto.
(input::-webkit-datetime-edit-week-field): Ditto.
(input::-webkit-datetime-edit-year-field): Ditto.
(input::-webkit-date-and-time-container): Ditto.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Overrides
SpinButtonOwner functions, and add m_spinButtonElement.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::focusAndSelectSpinButtonOwner):
Just delegate to DateTimeEditElement::focusIfNoFocus.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldSpinButtonRespondToMouseEvents):
Moved from DateTimeEditElement::shouldSpinButtonRespondToMouseEvents.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldSpinButtonRespondToWheelEvents):
Moved from DateTimeEditElement::shouldSpinButtonRespondToWheelEvents.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::spinButtonStepDown):
Delegate to DateTimeEditElement::stepDown.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::spinButtonStepUp):
Delegate to DateTimeEditElement::stepUp.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType):
Initialize m_spinButtonElement.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType):
Reset SpinButtonOwner for m_spinButtonElement like the old code of ~DateTimeEditElement.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
Put a SpinButtonElement between the DateTimeEditElement and the PickerIndicatorElement.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::forwardEvent):
Take care of SpinButtonElement.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged):
Release capture of SpinButtonElement. This corresponds to the old
code of DateTimeEditElement::updateUIState.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::readonlyAttributeChanged): Ditto.

  • html/TextFieldInputType.h:

Make SpinButtonElement::SpinButtonOwner protected to allow overriding.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Remove SpniButtonOwner implementation,
m_spinButton, and rename some functions.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::DateTimeEditElement):
Remove m_spinButton.
(WebCore::DateTimeEditElement::~DateTimeEditElement): Ditto.
(WebCore::DateTimeEditElement::focusIfNoFocus):
Renamed from focusAndSelectSpinButtonOwner. This is called
BaseMultipleFieldsDateAndTimeInputType::focusAndSelectSpinButtonOwner.
(WebCore::DateTimeEditElement::layout):
Remove creation code for -webkit-datetime-edit-gap and SpinButtonElement.
(WebCore::DateTimeEditElement::defaultEventHandler):
Move the code for m_spinButton to
BaseMultipleFieldsDateAndTimeInputType::forwardEvent.
(WebCore::DateTimeEditElement::hasFocusedField): A helper for
BaseMultipleFieldsDateAndTimeInputType::shouldSpinButtonRespondToWheelEvents.
(WebCore::DateTimeEditElement::stepDown): A helper for
BaseMultipleFieldsDateAndTimeInputType::spinButtonStepDown.
(WebCore::DateTimeEditElement::stepUp): A helper for
BaseMultipleFieldsDateAndTimeInputType::spinButtonStepUp.
(WebCore::DateTimeEditElement::updateUIState): Move the code to
BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged
and readonlyAttributeChanged.

LayoutTests:

Add a pixel image which has notable changes.
Input elements in other tests have slightly small height and
slightly narrow width.

  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium/TestExpectations:
6:57 PM Changeset in webkit [132290] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Web page renders at the wrong zoom level after viewport changes
https://bugs.webkit.org/show_bug.cgi?id=100096

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-10-23
Reviewed by Rob Buis.

Notify the client of the zoom level change before resuming screen updates.
Otherwise, the user interface thread may blit the content at the wrong
zoom level in some cases. This can also prevent potential flickering.

Reviewed internally by Arvid Nilsson.

PR #225741

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):

6:48 PM Changeset in webkit [132289] by Martin Robinson
  • 4 edits
    1 add
    1 delete in trunk

POTFILES.in/.skip need updates for translators
https://bugs.webkit.org/show_bug.cgi?id=67580

Reviewed by Xan Lopez.

.:

Now process POTFILES.in during configuration.

  • configure.ac:

Source/WebKit/gtk/po:

Move POTFILES to POTFILES.in to satisfy intltools-update and also update
the list of files with translations. Since the way the path is calculated
is different now, we also need to change the gettext invocation in
GNUmakefile.am.

  • GNUmakefile.am:
  • POTFILES: Removed.
  • POTFILES.in: Added.
6:13 PM Changeset in webkit [132288] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink immutable ElementAttributeData and StylePropertySet by one pointer each.
<http://webkit.org/b/100123>

Reviewed by Anders Carlsson.

Remove one pointer of unintentional padding in the immutable versions of these objects.
583kB progression on Membuster3.

  • css/StylePropertySet.cpp:

(WebCore::immutableStylePropertySetSize):

  • dom/ElementAttributeData.cpp:

(WebCore::immutableElementAttributeDataSize):

6:10 PM Changeset in webkit [132287] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::SubresourceLoader::willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=100147

Reviewed by Abhishek Arya.

No new tests. There is a test case that should cover this, but it doesn't
work correctly on many platforms due to its use of testRunner.addURLToRedirect().
See http/tests/loading/cross-origin-XHR-willLoadRequest.html.
Tested manually on http://www.nick.co.uk/shows/spongebob

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

6:08 PM Changeset in webkit [132286] by Martin Robinson
  • 20 edits
    2 adds
    2 deletes in trunk

[GTK][Soup] Implement the default authentication dialog via WebCoreSupport
https://bugs.webkit.org/show_bug.cgi?id=99351

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Instead of connecting to the SoupSession::authenticate signal in the API layer
via a SoupSessionFeature, route the message through the typical WebCore authentication
mechanism. This is a step on the path to having full-blown support for authentication
in the API allowing for custom authentication dialogs and behavior in clients.

No new tests. This should not change behavior.

  • GNUmakefile.list.am: Add the new implementation file for the AuthenticationChallenge.
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveAuthenticationChallenge): Include GTK+ here as well.

  • platform/gtk/GtkAuthenticationDialog.cpp: Instead of carrying a raw pointer to a SoupAuth

carry a GRefPtr which will allow the dialog to be used even after the AuthenticationChallenge
is destroyed.

  • platform/gtk/GtkAuthenticationDialog.h: ditto.
  • platform/network/ResourceHandle.h: Add a didReceiveAuthenticationChallenge method.
  • platform/network/ResourceHandleInternal.h:

(ResourceHandleInternal): Remove the getter for the initiating page ID.

  • platform/network/soup/AuthenticationChallenge.h: Added an implementation of AuthenticationChallenge

that takes a bit of data from the handle including SoupMessage, SoupAuth, and SoupSession.

  • platform/network/soup/AuthenticationChallengeSoup.cpp: Added. Ditto.
  • platform/network/soup/ResourceError.h:

(ResourceError): Added a factory for authentication errors.

  • platform/network/soup/ResourceErrorSoup.cpp: Ditto.
  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::setSoupRequestInitiaingPageID): Just get the page directly from the NetworkingContext.
(WebCore::createSoupMessageForHandleAndRequest): Always set the "handle" data on the message.
It's always used now.
(WebCore::ResourceHandle::start): Get the initiating page ID directly from the NetworkingContext.
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Added this method which routes
the authentication challenge to the client.
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): Added a stub for this method.
(WebCore::ResourceHandle::loadResourceSynchronously): Don't pass the session to the loader.
(WebCore::authenicateCallback): Added.
(WebCore::ResourceHandle::defaultSession): Connect the authenticate callback.

Source/WebKit/gtk:

Instead of using a custom SoupSessionFeature to show the authentication dialog,
show it using the corresponding WebCore message.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
Show the dialog when we need to authenticate. Also, so not show the dialog
if we are in DRT mode.

  • webkit/webkitglobals.cpp:

(webkitInit): No longer install our SoupFeature.

Source/WebKit2:

Instead of using a custom SoupSessionFeature to show the authentication
dialog, show it using the corresponding WebCore message.

  • GNUmakefile.list.am: Removed the SoupSessionFeature files.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit): Only use the default dispatchDidReceiveAuthenticationChallenge
for non-GTK+ ports.

  • WebProcess/WebCoreSupport/gtk/WebFrameLoaderClientGtk.cpp: Added.

(WebKit::WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): Added
a GTK+-specific implementation that shows the GtkAuthenticationDialog.

  • WebProcess/gtk/WebAuthDialog.cpp: Removed.
  • WebProcess/gtk/WebAuthDialog.h: Removed.
  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk): Don't install the custom session feature.

Tools:

We no longer need to turn off the soup authentication dialog soup feature,
because it's not installed.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(setDefaultsToConsistentStateValuesForTesting): Don't turn off the feature any longer.

5:58 PM Changeset in webkit [132285] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Simplify GCEpilogueVisitor along the same lines as GCPrologueVisitor
https://bugs.webkit.org/show_bug.cgi?id=100157

Reviewed by Eric Seidel.

This patch removes the traits template parameter from GCEpilogueVisitor
and makes it mirror GCPrologueVisitor again.

  • bindings/v8/V8GCController.cpp:

(WebCore):
(ActiveDOMObjectEpilogueVisitor):
(WebCore::ActiveDOMObjectEpilogueVisitor::ActiveDOMObjectEpilogueVisitor):
(WebCore::ActiveDOMObjectEpilogueVisitor::visitDOMWrapper):
(WebCore::V8GCController::majorGCEpilogue):

5:51 PM Changeset in webkit [132284] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove deprecatedSend
https://bugs.webkit.org/show_bug.cgi?id=100127

Reviewed by Andreas Kling.

deprecatedSend is no longer used anywhere, remove it.

  • Platform/CoreIPC/Connection.h:

(Connection):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

5:26 PM Changeset in webkit [132283] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Context menu generated from touch gestures on textareas has
context of the cursor position instead of the position where the event occurs.
https://bugs.webkit.org/show_bug.cgi?id=99520

Patch by Varun Jain <varunjain@chromium.org> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Send a synthetic mouse down event for context menu-summoning-gesture events so
that textareas can correctly set cursors before receiving the context menu event.

Test: fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureTwoFingerTap):
(WebCore):
(WebCore::EventHandler::sendContextMenuEventForGesture):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

Send a synthetic mouse down event for context menu-summoning-gesture events so
that textareas can correctly set cursors before receiving the context menu event.
Also in this change, WebInputEvent::GestureTwoFingerTap now follows the same
code path as WebInputEvent::GestureLongPress, hence fixing this bug for both gestures.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

LayoutTests:

Send a synthetic mouse down event for context menu-summoning-gesture events so that
textareas can correctly set cursors before receiving the context menu event.

  • fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html: Added.
  • platform/chromium/fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position-expected.txt: Added.
4:44 PM Changeset in webkit [132282] by aestes@apple.com
  • 12 edits in trunk/Source

[WebKit2 API] Add properties to get textRects from a WKDOMRange or WKDOMNode
https://bugs.webkit.org/show_bug.cgi?id=100162

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in: Exported symbols needed by WebKit2.
  • bindings/objc/DOM.mm:

(-[DOMNode textRects]): Moved some logic into Node::textRects()
(everything but the call to updateLayoutIgnorePendingStylesheets()).

  • dom/Node.cpp:

(WebCore::Node::textRects):

  • dom/Node.h:

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:

(WebKit::toNSArray): Added a helper function to convert a Vector of IntRects to an NSArray.

  • WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:

(-[WKDOMNode textRects]):

  • WebProcess/InjectedBundle/API/mac/WKDOMRange.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange textRects]):

4:41 PM Changeset in webkit [132281] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove unused function from DOM wrapper visitor
https://bugs.webkit.org/show_bug.cgi?id=100163

Reviewed by Eric Seidel.

No one overrides these virtual functions. They were added in
http://trac.webkit.org/changeset/73491, but we don't use them in the GC
controller anymore.

  • bindings/v8/V8DOMMap.h:

(WebCore::WeakReferenceMap::visit):

4:15 PM Changeset in webkit [132280] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Clear m_mediaSource reference when the MediaSource is closed
https://bugs.webkit.org/show_bug.cgi?id=100047

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-10-23
Reviewed by Eric Carlson.

The m_mediaSource object shouldn't be accessed after the object
transitions to closed so this change simply clears the reference
when that transition happens.

No new tests because the change isn't visible to JavaScript.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource): Removed a closed transition that is actually dead code.
(WebCore::HTMLMediaElement::setSourceState): Clear the m_mediaSource reference on closed transition.

4:10 PM Changeset in webkit [132279] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Cache TouchDown HitTestResult to avoid calling RenderLayer::hitTest unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=99649

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-10-23
Reviewed by George Staikos.

Random latency before scroll starts on sites like http://pintrest.com
Internal PR225398

The chief problem here is the all the hit testing that we do for
touch events and simulated mouse events. If the render tree is dirty
hit tests can take a long time in Document::recalcStyle(). Masking
the flags that force style recalculations will make them fast, at the
expense that they might be happening on stale data.

Since we are only using these hit tests to look for event handlers -
we're not actually modifying anything, it is better to skip the
Document::recalcStyle() and save ourselves tons of time.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
(BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::resumeDocumentStyleRecalc):
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):
(BlackBerry::WebKit::WebPagePrivate::clearCachedHitTestResult):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):

  • WebKitSupport/FatFingers.h:
  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

3:55 PM Rebaseline edited by dpranke@chromium.org
update to new TestExpectations syntax (diff)
3:46 PM Changeset in webkit [132278] by leviw@chromium.org
  • 1 edit
    47 adds in trunk/LayoutTests

The rest of the baselines have landed! Should green the Mac bots for MathML after r132264.

  • platform/chromium-mac-lion/mathml: Added.
  • platform/chromium-mac-lion/mathml/presentation: Added.
  • platform/chromium-mac-lion/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/over-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/row-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/style-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-mac-lion/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/under-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-mac-lion/mathml/xHeight-expected.png: Added.
  • platform/chromium-mac/mathml: Added.
  • platform/chromium-mac/mathml/presentation: Added.
  • platform/chromium-mac/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/fenced-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/over-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/row-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/style-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-mac/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/under-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-mac/mathml/xHeight-expected.png: Added.
3:36 PM Changeset in webkit [132277] by leviw@chromium.org
  • 1 edit
    44 adds in trunk/LayoutTests

Unreviewed gardening. Updating expectations after r132264.

  • platform/chromium-mac-snowleopard/mathml: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/attributes-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fenced-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fenced-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fractions-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mroot-pref-width-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/over-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/over-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/roots-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/row-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/style-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/sub-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/sup-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/tokenElements-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/under-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/under-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/underover-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/xHeight-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/xHeight-expected.txt: Added.
3:22 PM Changeset in webkit [132276] by Simon Fraser
  • 24 edits
    3 adds in trunk

Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=100159

Reviewed by Tim Horton.

Source/WebCore:

Add a LAYER_TREE_INCLUDES_PAGE_TILE_CACHE flag for layerTreeAsText(), and plumb it
through to GraphicsLayerCA, which dumps the TiledBacking tile coverage rect.

Test: platform/mac/tiled-drawing/use-tiled-drawing.html

  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:

(showGraphicsLayerTree):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::tiledBacking):

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::tiledBacking):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/mac/TileCache.h:

(WebCore::TileCache::tileCoverageRect):
(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::computeTileCoverageRect):
(WebCore::TileCache::revalidateTiles):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText):

  • testing/Internals.h:
  • testing/Internals.idl:

Tools:

Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
whose path includes "tiled-drawing". It does this by passing around a WKDictionary
of options, and if the current PlatformWebView doesn't support those options, it will
create a new one.

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView): Add a WKDictionaryRef options dictionary argument.
(WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
supports the options in the WKDictionaryRef.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize): Call createWebViewWithOptions() with
no options in the normal case.
(WTR::TestController::createWebViewWithOptions): Moved code into this fuction
so we can call it in two places.
(WTR::TestController::ensureViewSupportsOptions): If the current view
doesn't support the given options, throw it away and makea new one that does.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
(WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
the view supports the given options. No-op for non-Mac platforms.
(WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
(-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
a custom value from this method.
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

LayoutTests:

A new test that dumps tile cache data for a large page.

  • platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Added.
  • platform/mac/tiled-drawing/use-tiled-drawing.html: Added.
3:19 PM Changeset in webkit [132275] by noam.rosenthal@nokia.com
  • 20 edits in trunk/Source

Coordinated Graphics: Enable threaded/IPC animations
https://bugs.webkit.org/show_bug.cgi?id=93146

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add enablers to TextureMapper and GraphicsLayerAnimation so that they could be used
across processes with IPC. Added some public accessors to GraphicsLayerAnimation,
and allowed a GraphicsLayerTextureMapper to receive a full list of animations.

Covered by existing animation and compositing tests.

  • platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::GraphicsLayerAnimation::GraphicsLayerAnimation):

Initialize the animation with the startTime instead of the offset.

(WebCore::GraphicsLayerAnimations::getActiveAnimations):

  • platform/graphics/GraphicsLayerAnimation.h:

(WebCore::GraphicsLayerAnimation::setState):

Allow setting the pause time as well.

(WebCore::GraphicsLayerAnimation::boxSize):
(WebCore::GraphicsLayerAnimation::startTime):
(WebCore::GraphicsLayerAnimation::pauseTime):
(WebCore::GraphicsLayerAnimation::animation):
(WebCore::GraphicsLayerAnimation::keyframes):
(WebCore::GraphicsLayerAnimation::listsMatch):
(WebCore::GraphicsLayerAnimations::size):
(WebCore::GraphicsLayerAnimations::animations):

Add public accessors to GraphicsLayerAnimation properties.

(GraphicsLayerAnimation):
(GraphicsLayerAnimations):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::setAnimations):

Allow replacing the entire list of animations.

(WebCore):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::applyAnimationsRecursively):
(WebCore):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

Source/WebKit2:

Re-enable UI-process animations for Coordinated-Graphics/TextureMapper.

  • Added an argument coder for GraphicsLayerAnimations.
  • Allow LayerTreeCoordinator to manage the animations per layer with the proxy, as opposed to applying the animation values in the web process as before.
  • LayerTreeRenderer now calls updateViewport() after painting when an animation is active.

To overcome the problem we've had in the past with synchronizing UI-side and web-side
animations, we now lock the animations in the UI process when a frame starts rendering,
and unlock it when the frame finishes rendering, or if after the layout there is no visible
changes pending on the screen.

  • Scripts/webkit2/messages.py:

(headers_for_type):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC):
(CoreIPC::encodeTimingFunction):
(CoreIPC::decodeTimingFunction):
(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:

(WebCore):

Added argument coders for GraphicsLayerAnimations.

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::setLayerAnimations):
(WebKit::LayerTreeCoordinatorProxy::setAnimationsLocked):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:

Added an option to sync the layer's animations, and also to lock/unlock animations.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::paintToCurrentGLContext):

Sync animations if they're not locked, and call updateViewport() if we have animations.

(WebKit::LayerTreeRenderer::flushLayerChanges):
(WebKit::LayerTreeRenderer::setLayerAnimations):
(WebKit::LayerTreeRenderer::setAnimationsLocked):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::didChangeAnimations):
(WebCore::CoordinatedGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::addAnimation):
(WebCore::CoordinatedGraphicsLayer::pauseAnimation):
(WebCore::CoordinatedGraphicsLayer::removeAnimation):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
(WebCore):

Pass the animation info to the UI process instead of applying it in the web process.

(WebCore::CoordinatedGraphicsLayer::hasPendingVisibleChanges):

Compute whether a layer tree might have sync issues or flickers if rendered while
background animations are ongoing.

(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
(WebCore::CoordinatedGraphicsLayer::selfOrAncestorHaveNonAffineTransforms):

Don't allow progressive tiling for layers with animations.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(WebCore):
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::lockAnimations):
(WebKit):
(WebKit::LayerTreeCoordinator::unlockAnimations):
(WebKit::LayerTreeCoordinator::performScheduledLayerFlush):
(WebKit::LayerTreeCoordinator::setLayerAnimations):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

3:11 PM Changeset in webkit [132274] by crogers@google.com
  • 7 edits
    2 moves in trunk

Change setTargetValueAtTime() to setTargetAtTime()
https://bugs.webkit.org/show_bug.cgi?id=100153

Reviewed by Adam Barth.

Source/WebCore:

The AudioParam method name has changed due to Web Audio API spec review.
Keep legacy support for the old name.

Test: webaudio/audioparam-setTargetAtTime.html

  • Modules/webaudio/AudioParam.h:

(WebCore::AudioParam::setTargetAtTime):

  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::setTargetAtTime):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

  • Modules/webaudio/AudioParamTimeline.h:

(AudioParamTimeline):

LayoutTests:

  • webaudio/audioparam-setTargetAtTime-expected.txt: Renamed from LayoutTests/webaudio/audioparam-setTargetValueAtTime-expected.txt.
  • webaudio/audioparam-setTargetAtTime.html: Renamed from LayoutTests/webaudio/audioparam-setTargetValueAtTime.html.
  • webaudio/resources/audioparam-testing.js:
3:03 PM Changeset in webkit [132273] by zoltan@webkit.org
  • 3 edits in trunk/PerformanceTests

Add measurePageLoadTime function to PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=100029

Reviewed by Ryosuke Niwa.

Adopt chunk based loading logic from html5-full-render.html into measurePageLoadTime function,
this is needed to measure the performance and the memory consumption of the PageLoadTests as
we do it for all other performancetests.

  • Parser/html5-full-render.html: Move the behavior to runner.js.
  • resources/runner.js:

(.): Add measurePageLoadTime function.

3:02 PM Changeset in webkit [132272] by benjamin@webkit.org
  • 6 edits in trunk/Source/WebCore

[Mac] Remove extraneous conversion to String->NSString
https://bugs.webkit.org/show_bug.cgi?id=100044

Reviewed by Darin Adler.

Improve some unfortunate use of String->NSString.

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification): The variable macNotification is ultimately
needed as NSString, and all its value are or can be NSString.
Convert the last 3 char* values to NSString literal and use NSString* all the way.

  • loader/mac/LoaderNSURLExtras.h:
  • loader/mac/LoaderNSURLExtras.mm:

(suggestedFilenameWithMIMEType):
We converted the String to NSString to pass to suggestedFilenameWithMIMEType. There is no need
for the string to be a NSSTring there, we can leave it in its original type.

The case checking for a nil MIMEType was dead code because the implicit conversion never returns nil.

  • platform/mac/DragImageMac.mm:

(WebCore::createDragImageForLink):
Use String's nsStringNilIfEmpty().

  • platform/mac/HTMLConverter.mm:

(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
Fix the coding style. Do the conversion to NSString only when needed.

2:49 PM Changeset in webkit [132271] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Popup menus positioning needs to take multiple monitors into account.
https://bugs.webkit.org/show_bug.cgi?id=100158

Reviewed by Timothy Horton.

Add screen.x() to repositioning check to account for position of current monitor.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):

2:45 PM Changeset in webkit [132270] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Shaders] Set FilterOperations on GraphicsLayer after the program of CSS Shaders is loaded.
https://bugs.webkit.org/show_bug.cgi?id=99908

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-23
Reviewed by Dean Jackson.

CSS Shaders can not render anything until the program is loaded. If there is
partial loaded shaders program, whole FilterOperations chain can not render
anything. It occurs a flash. So We have to wait until the program is loaded, to
prevent a flash as RenderLayerBacking::updateImageContents() waits until an
image is fully loaded.

No new tests, CSS Shaders on Accelerated Compositing are not activated yet.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateFilters):

2:40 PM Changeset in webkit [132269] by commit-queue@webkit.org
  • 9 edits
    6 adds
    20 deletes in trunk

Generated should not be supported for things with a shadow
https://bugs.webkit.org/show_bug.cgi?id=98836

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-23
Reviewed by Dimitri Glazkov.

Source/WebCore:

As far as CSS is concerned inputs and things with shadow content inside
shouldn't support pseudo elements like :before, :after or :first-letter.
Neither Gecko or Presto supports it, and we only accidentally supported
it.

Until the spec tells us what to do we should disable support. This is
also neccesary because the new generated content implementation doesn't
support shadows.

Test: fast/forms/pseudo-elements.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderListBox.h: Added missing canHaveGeneratedChildren() that returns false.
  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

Change all pseudos on <input> tests to be ref tests and clean up the tests.
They now make sure we don't support generated content on things with a shadow.
Also added another test for the other form control types to ensure they don't
support pseudos either.

  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/pseudo-elements-expected.html: Added.
  • fast/forms/pseudo-elements.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
2:34 PM Changeset in webkit [132268] by commit-queue@webkit.org
  • 5 edits in trunk

[CSS Shaders] Implement overlay, color-dodge, color-burn, hard-light, soft-light blend modes.
https://bugs.webkit.org/show_bug.cgi?id=98504

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-23
Reviewed by Dean Jackson.

Source/WebCore:

Add expressions for the aforementioned blend modes. The expressions are lifted
directly from the CSS Compositing and Blending spec [1]. WebKit adds these
blending expressions to the author's shader.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnormal

Test: css3/filters/custom/custom-filter-blend-modes.html

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):
(WebCore::CustomFilterValidatedProgram::blendFunctionString):

LayoutTests:

Update the test for the aforementioned blend modes.

  • css3/filters/custom/custom-filter-blend-modes-expected.html:
  • css3/filters/custom/custom-filter-blend-modes.html:
2:31 PM Changeset in webkit [132267] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[CSS Shaders] Implement all composite operators except destination and lighter.
https://bugs.webkit.org/show_bug.cgi?id=97859

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-23
Reviewed by Dean Jackson.

Source/WebCore:

Add expressions for all composite operators except destination and
lighter. The expressions are lifted directly from the CSS Compositing
and Blending spec [1]. WebKit adds these compositing expressions to the
author's shader.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#advancedcompositing

Test: css3/filters/custom/custom-filter-composite-operators.html

  • platform/graphics/filters/CustomFilterCompiledProgram.cpp:

(WebCore::CustomFilterCompiledProgram::initializeParameterLocations):

Remove ASSERTION checking if glGetUniformLocation returns negative,
because ASSERTION can fail with clear and copy composite operations.
Clear and copy composite operations do not need "css_u_texture"
representing the DOM element texture. If the driver compiler is
smart, "css_u_texture" is not regarded as an active uniform, so
glGetuniformLocation returns -1. glGetAttribLocation ditto.

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::compiledProgram):

Move the above ASSERTION in CustomFilterCompiledProgram to here.
ASSERTION checks if m_samplerLocation is not -1 when the author
shader needs an input texture.

(WebCore::CustomFilterValidatedProgram::needsInputTexture):
(WebCore):
(WebCore::CustomFilterValidatedProgram::compositeFunctionString):

  • platform/graphics/filters/CustomFilterValidatedProgram.h:

(CustomFilterValidatedProgram):

LayoutTests:

Add test to check that the DOM element texture composites correctly with the css_MixColor
variable from the author's shader for each composite operator.

  • css3/filters/custom/custom-filter-composite-operators-expected.png: Added.
  • css3/filters/custom/custom-filter-composite-operators-expected.txt: Added.
  • css3/filters/custom/custom-filter-composite-operators.html: Added.
2:24 PM Changeset in webkit [132266] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[CSS Shaders] Changing the blend mode in CSS doesn't update the custom filter rendering
https://bugs.webkit.org/show_bug.cgi?id=99887

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-23
Reviewed by Dirk Schulze.

Source/WebCore:

Before this patch, WebKit would not recompute an element's style when just its custom filter
blend mode changed.

For example, suppose an element initially has the style:
-webkit-filter: custom(none mix(url(shader.fs) multiply source-atop));

Then, we change the blend mode from "multiply" to "normal":
-webkit-filter: custom(none mix(url(shader.fs) normal source-atop));

WebKit now detects this change and recomputes the style.

CustomFilterProgram now has an equals operator that considers the program type and the mix
settings. The mix settings contain the blend mode.

Test: css3/filters/custom/custom-filter-change-blend-mode.html

  • platform/graphics/filters/CustomFilterProgram.cpp:

(WebCore::CustomFilterProgram::operator==):

Previously, the equals operator was pure virtual in CustomFilterProgram. Now,
CustomFilterProgram implements it and compares the program type and mix settings, if
appropriate.

(WebCore):

  • platform/graphics/filters/CustomFilterProgram.h:
  • platform/graphics/filters/CustomFilterProgramInfo.cpp:

(WebCore::CustomFilterProgramInfo::hash):

Refactor a repeated condition into a boolean to improve readability.

(WebCore::CustomFilterProgramInfo::operator==):

Refactor repeated conditions to improve readability. Reorder the conditions so the less
expensive ones occur first.

  • rendering/style/StyleCustomFilterProgram.h:

(WebCore::StyleCustomFilterProgram::operator==):

Call the base class's equals operator.

LayoutTests:

Add a test that resolves a custom filter's style with the "multiply" blend mode and then
changes the blend mode to "normal". The test makes sure not to change any other parameters
besides the blend mode, since the other parameters can trigger style recalculations on their
own.

  • css3/filters/custom/custom-filter-change-blend-mode-expected.html: Added.
  • css3/filters/custom/custom-filter-change-blend-mode.html: Added.
2:21 PM Changeset in webkit [132265] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[WebGL] conformance/textures/texture-size.html is failing on Apple Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=94041

Reviewed by Dean Jackson.

When binding a texture to GL_TEXTURE_2D when GL_ACTIVE_TEXTURE is 0, we set m_boundTexture0 to the texture unit.
However when we delete the texture, we need to be setting m_boundTexture0 to 0.
Otherwise when we draw to the screen we bind m_boundTexture0 in the prepareTexture() method and since the associated texture
has already been deleted we end up in an error state.

Tested using Khronos WebGL conformance suite:
conformance/textures/texture-size.html

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::deleteTexture):

2:14 PM Changeset in webkit [132264] by Dave Barton
  • 55 edits in trunk

[MathML] Symbol font uses greek letters for roman ones on linux and Windows
https://bugs.webkit.org/show_bug.cgi?id=99921

Reviewed by Eric Seidel.

Source/WebCore:

For parts of stretched parentheses and brackets, mathml.css currently uses the Symbol font,
which on linux and Windows has greek letters at roman code points. To fix this, we switch
to the STIXSizeOneSym font when available. However, this can cause vertical gaps between
glyph parts, because of hard-coded constants in RenderMathMLOperator.cpp. We eliminate all
these constants. We also shift glyphs upward by 1px and truncate them to avoid the gaps.

Tested by existing tests, and one test added to LayoutTests/mathml/presentation/mo.xhtml.

  • css/mathml.css:

(math, mfenced > *):

  • Set font-family for mn, mi, etc.

(mo, mfenced):

  • Set font-family for mo and anonymous operators, including extension glyphs for stretched operators like parentheses and brackets.

(math):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore):

  • Change 0x23d0 to 0x23aa for STIX & Cambria Math fonts.

(WebCore::RenderMathMLOperator::glyphHeightForCharacter):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createStackableStyle):

  • Eliminate unused lineHeight and topRelative parameters, and the hard-coded font size of 14.

(WebCore::RenderMathMLOperator::createGlyph):

  • Eliminate unused lineHeight and topRelative parameters.
  • rendering/mathml/RenderMathMLOperator.h:

(RenderMathMLOperator):

Tools:

Enable the STIXSizeOneSym font for testing.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):

  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::allowedFontFamilySet):

LayoutTests:

  • mathml/presentation/mo.xhtml:
  • platform/chromium/TestExpectations:
  • platform/chromium/mathml/presentation/attributes-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/attributes-expected.txt:
  • platform/chromium/mathml/presentation/fenced-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/fenced-expected.txt:
  • platform/chromium/mathml/presentation/fenced-mi-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/fenced-mi-expected.txt:
  • platform/chromium/mathml/presentation/fractions-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/fractions-expected.txt:
  • platform/chromium/mathml/presentation/fractions-vertical-alignment-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/chromium/mathml/presentation/mo-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/mo-expected.txt:
  • platform/chromium/mathml/presentation/mo-stretch-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/mo-stretch-expected.txt:
  • platform/chromium/mathml/presentation/mroot-pref-width-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/mroot-pref-width-expected.txt:
  • platform/chromium/mathml/presentation/over-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/over-expected.txt:
  • platform/chromium/mathml/presentation/roots-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/roots-expected.txt:
  • platform/chromium/mathml/presentation/row-alignment-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/row-alignment-expected.txt:
  • platform/chromium/mathml/presentation/row-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/row-expected.txt:
  • platform/chromium/mathml/presentation/style-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/style-expected.txt:
  • platform/chromium/mathml/presentation/sub-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/sub-expected.txt:
  • platform/chromium/mathml/presentation/subsup-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/subsup-expected.txt:
  • platform/chromium/mathml/presentation/sup-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/sup-expected.txt:
  • platform/chromium/mathml/presentation/tables-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/tables-expected.txt:
  • platform/chromium/mathml/presentation/tokenElements-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/tokenElements-expected.txt:
  • platform/chromium/mathml/presentation/under-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/under-expected.txt:
  • platform/chromium/mathml/presentation/underover-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/underover-expected.txt:
  • platform/chromium/mathml/xHeight-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/xHeight-expected.txt:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
2:11 PM Changeset in webkit [132263] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Properly skipping http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout*
tests, as was the author's intention.

  • platform/chromium/TestExpectations:
2:09 PM Changeset in webkit [132262] by tony@chromium.org
  • 2 edits in trunk/Tools

[chromium] Chromium window build system does not rebuild correctly when enabling/disabling a feature
https://bugs.webkit.org/show_bug.cgi?id=38926

Reviewed by Eric Seidel.

Remove hack for clobbering build when features.gypi changes. Now that
Chromium requires VS2010 or newer, this bug has gone away.

  • Scripts/update-webkit:
2:09 PM Changeset in webkit [132261] by benjamin@webkit.org
  • 5 edits in trunk/Source

WTFURL: Implement KURL::setPort()
https://bugs.webkit.org/show_bug.cgi?id=99898

Reviewed by Adam Barth.

Source/WebCore:

  • platform/KURLWTFURL.cpp:

(WebCore::KURL::setPort):

Source/WTF:

Add an efficient implementation for remplacing the port component
in an URL. This will be the base for replacing other components
efficiently.

The testing is covered by fast/dom/HTMLAnchorElement/set-href-attribute-port.html

  • wtf/url/api/ParsedURL.cpp:

(WTF::generateNewSpecWithPort):
(WTF::replacePortWithString):
(WTF::ParsedURL::replacePort):

  • wtf/url/api/ParsedURL.h:

(ParsedURL):

2:05 PM Changeset in webkit [132260] by thakis@chromium.org
  • 5 edits in trunk/Source/WebCore

In the open-source jpeg decoder, read image orientation from the exif data
https://bugs.webkit.org/show_bug.cgi?id=100144

Reviewed by Eric Seidel.

This will be used to implement the shouldRespectImageOrientation
setting (see bug 19688). Currently this isn't hooked up anywhere, so
it has no observable effect for now.

Once it's hooked up, it will be tested by
fast/images/exif-orientation.html

  • platform/graphics/BitmapImage.h:
  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::orientation):
(ImageDecoder):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readUint16):
(WebCore):
(WebCore::readUint32):
(WebCore::checkExifHeader):
(WebCore::readImageOrientation):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::decode):

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:

(WebCore::JPEGImageDecoder::setOrientation):

2:02 PM Changeset in webkit [132259] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Fix thread safety issue in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=100154

Reviewed by Kenneth Russell.

Add appropriate locking in AudioParamTimeline::valueForContextTime()

  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valueForContextTime):

1:25 PM Changeset in webkit [132258] by alecflett@chromium.org
  • 14 edits in trunk/Source

IndexedDB: refactor backend to use IDB*Metadata
https://bugs.webkit.org/show_bug.cgi?id=100055

Reviewed by Tony Chang.

Source/WebCore:

This further encapsulates the static data in
IDBObjectStoreBackendImpl and IDBIndexBackendImp into their
respective IDB*Metadata structs, in preparation for
https://bugs.webkit.org/show_bug.cgi?id=99774.

No new tests as this is purely a refactor.

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::metadata):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(WebCore::IDBIndexBackendImpl::id):
(WebCore::IDBIndexBackendImpl::setId):
(WebCore::IDBIndexBackendImpl::hasValidId):
(WebCore::IDBIndexBackendImpl::name):
(WebCore::IDBIndexBackendImpl::keyPath):
(WebCore::IDBIndexBackendImpl::unique):
(WebCore::IDBIndexBackendImpl::multiEntry):
(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::getIndexes):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::create):
(WebCore::IDBObjectStoreBackendImpl::id):
(WebCore::IDBObjectStoreBackendImpl::setId):
(WebCore::IDBObjectStoreBackendImpl::name):
(WebCore::IDBObjectStoreBackendImpl::keyPath):
(WebCore::IDBObjectStoreBackendImpl::autoIncrement):
(IDBObjectStoreBackendImpl):

Source/WebKit/chromium:

Update tests to reflect refactoring.

  • tests/IDBDatabaseBackendTest.cpp:
  • tests/IDBFakeBackingStore.h:
1:17 PM Changeset in webkit [132257] by krit@webkit.org
  • 3 edits
    2 adds in trunk

BasicShapePolygon::path takes width instead of height for boundary calculation
https://bugs.webkit.org/show_bug.cgi?id=99919

Reviewed by Darin Adler.

Source/WebCore:

The 'y' parameters of polygon were calculated by the with of the bounding box of the object.
This caused problems on percentage values for point positions.
Changed it to the height of the bounding box.

Test: css3/masking/clip-path-polygon-percentage.html

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapePolygon::path):

LayoutTests:

Test that the correct relation is used for calculating point position of an polygon.

  • css3/masking/clip-path-polygon-percentage-expected.html: Added.
  • css3/masking/clip-path-polygon-percentage.html: Added.
12:44 PM Changeset in webkit [132256] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[Chromium] Add CHROMIUM_texture_from_image extension support.
https://bugs.webkit.org/show_bug.cgi?id=99894

Patch by David Reveman <reveman@chromium.org> on 2012-10-23
Reviewed by James Robinson.

Add bindTexImage2DCHROMIUM and releaseTexImage2DCHROMIUM prototypes to
WebGraphicsContext3D.h.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::bindTexImage2DCHROMIUM):
(WebKit::WebGraphicsContext3D::releaseTexImage2DCHROMIUM):

12:40 PM Changeset in webkit [132255] by Lucas Forschler
  • 2 edits in tags/Safari-537.15.2/Source/WebKit2

Hand merge fix for:
<rdar://problem/12530687>


  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

12:14 PM Changeset in webkit [132254] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium DEPS r163297:163557
https://bugs.webkit.org/show_bug.cgi?id=100146

Reviewed by Adrienne Walker.

12:12 PM Changeset in webkit [132253] by dpranke@chromium.org
  • 1 edit
    33 deletes in trunk/LayoutTests

Remove remaining fast/innerHTML pixel test baselines after r131960.

Unreviewed, expectations change.

  • platform/chromium-linux/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-linux/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-linux/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/001-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/002-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/003-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/006-expected.txt: Removed.
  • platform/efl/fast/innerHTML/001-expected.txt: Removed.
  • platform/efl/fast/innerHTML/002-expected.txt: Removed.
  • platform/efl/fast/innerHTML/003-expected.txt: Removed.
  • platform/efl/fast/innerHTML/006-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/001-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/002-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/003-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/006-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.
  • platform/mac/fast/innerHTML/001-expected.txt: Removed.
  • platform/mac/fast/innerHTML/002-expected.txt: Removed.
  • platform/mac/fast/innerHTML/003-expected.txt: Removed.
  • platform/mac/fast/innerHTML/006-expected.txt: Removed.
  • platform/qt/fast/innerHTML/001-expected.txt: Removed.
  • platform/qt/fast/innerHTML/002-expected.txt: Removed.
  • platform/qt/fast/innerHTML/003-expected.txt: Removed.
  • platform/qt/fast/innerHTML/006-expected.txt: Removed.
11:49 AM Changeset in webkit [132252] by dominik.rottsches@intel.com
  • 13 edits
    25 adds in trunk

Add timeout support to XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=74802

Reviewed by Nate Chapin.

Source/WebCore:

An implementation of XHR2 timeouts by using ResourceRequest's setTimeoutInterval.
This made several changes necessary in CachedResource and SubresourceLoader in order
to distinguish and forward the timeout case from there.

The case of late updates to the timeout property, changing the timeout value after send()
is not supported yet and handled separately in bug 98156.

XHR2 timeout tests were initially written by Mozilla's Alex Vincent's. He granted
permission to reuse them under PD/BSD license
in https://bugzilla.mozilla.org/show_bug.cgi?id=525816#c86 - big thanks!
I adapted them for W3C testharness.js and split them into groups with shorter test running time
so that they can be used as WebKit layout tests.

Tests: http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html

http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::notifyFinished): Forward information about timeout case.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFail): Distinguish timeout case when informing client.

  • loader/cache/CachedResource.h: Distinguishing timeout case for errors.

(WebCore::CachedResource::errorOccurred):
(WebCore::CachedResource::loadFailedOrCanceled):
(WebCore::CachedResource::timedOut):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest): Initializing m_timeout value to zero.
(WebCore::XMLHttpRequest::setTimeout): Setter function, possibly raising JS exception.
(WebCore):
(WebCore::XMLHttpRequest::open): Open call may raise exception for synchronous requests when timeout value is set.
(WebCore::XMLHttpRequest::createRequest): Assigning timeout value to ResourceRequest.
(WebCore::XMLHttpRequest::didFail): Handling timeout case separately.
(WebCore::XMLHttpRequest::didTimeout): Timeout case state transisition and event firing as spec'ed.

  • xml/XMLHttpRequest.h: New event listener, member and callback for handling timeout.

(WebCore::XMLHttpRequest::timeout):
(XMLHttpRequest):

  • xml/XMLHttpRequest.idl: New event listener and property added.
  • xml/XMLHttpRequestException.cpp:
  • xml/XMLHttpRequestException.h: Added an exception value for the timeout case.

LayoutTests:

XHR2 timeout tests were initially written by Mozilla's Alex Vincent's. He granted
permission to reuse them under PD/BSD license
in https://bugzilla.mozilla.org/show_bug.cgi?id=525816#c86 - big thanks!
I adapted them for W3C testharness.js and split them into groups with shorter test running time
so that they can be used as WebKit layout tests. Each individual test should
complete in less than 20 seconds.

The case of late updates to the timeout property, changing the timeout value after send()
is not supported yet and handled separately in bug 98156. Tests that are testing this feature
are commented out until this bug is tackled.

The suffix of the html test filename matches the groups in xmlhttprequest-timeout.js which contains
all tests that are run. The result of assertions is reported back to testharness.js.

For example, the "overrides" group is currently not run yet since all tests in that group are cases
of late updates, see above. Once late updates are supported we can add a file
xmlhttprequest-timeout-overrides.html to run them.

  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-runner.js: Added. Distinguishes which group of tests to run based on filename suffix.

(testResultCallbackHandler.return):
(groupFromLocation):

  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout.js: Added. Contains test cases for all individual test html files.

(message): Wrapper for postMessage in worker and document context case.
(is),
(ok): Assertion functions.
(RequestTracker): Class for variations of the regular timeout case.
(RequestTracker.prototype.startXHR.handleEvent):
(RequestTracker.prototype.startXHR):
(RequestTracker.prototype.getMessage):
(RequestTracker.prototype.handleEvent):
(AbortedRequest): Class for testing timeout event vs. abort events.
(AbortedRequest.prototype.startXHR.handleEvent):
(AbortedRequest.prototype.startXHR.abortReq):
(AbortedRequest.prototype.startXHR.else):
(AbortedRequest.prototype.startXHR):
(AbortedRequest.prototype.noEventsFired):
(AbortedRequest.prototype.getMessage):
(AbortedRequest.prototype.handleEvent):
(SyncRequestSettingTimeoutAfterOpen.startXHR),
(SyncRequestSettingTimeoutBeforeOpen.startXHR): Test classes for synchronous XHR cases.
(TestCounter.testComplete),
(TestCounter.next): Used for cycling through tests.

  • platform/chromium/TestExpectations: Skipping XHR timeout cases since setTimeoutInterval is not supported in Chromium's HTTP stack.
  • platform/gtk/TestExpectations: Marking XHR timeout cases as slow in order to run them with a longer test timeout threshold.
  • platform/qt/TestExpectations: Skipping XHR timeout cases since setTimeoutInterval is not supported in Chromium's HTTP stack.
11:45 AM Changeset in webkit [132251] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. css3/filters/blur-filter-page-scroll-self.html is crashing
now as well as generating incorrect image results :(

  • platform/chromium/TestExpectations:
11:42 AM Changeset in webkit [132250] by Lucas Forschler
  • 5 edits in tags/Safari-537.15.2/Source/JavaScriptCore

Merged r131791.

11:29 AM Changeset in webkit [132249] by Lucas Forschler
  • 4 edits in tags/Safari-537.15.2/Source

Versioning.

11:29 AM Changeset in webkit [132248] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[WIN7] Skip fast/media/mq-resolution.html.
https://bugs.webkit.org/show_bug.cgi?id=100143.

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

The feature is not yet implemented.

  • platform/win/TestExpectations:
11:26 AM Changeset in webkit [132247] by Lucas Forschler
  • 1 copy in tags/Safari-537.15.2

New Tag.

11:22 AM Changeset in webkit [132246] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Possible assertion hit in WebCore::HTMLSelectElement::updateListBoxSelection()
https://bugs.webkit.org/show_bug.cgi?id=99967

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23
Reviewed by Tony Chang.

Source/WebCore:

Fix assertion hit in WebCore::HTMLSelectElement::updateListBoxSelection() when
pressing the left mouse button outside a multiselect and then moving the cursor
over the multiselect element while holding the button down.

The issue is that the HTMLSelectElement handler for the mouse move event does
not check if there is a selection before trying to extend the selection.

Test: fast/dom/HTMLSelectElement/select-selectedIndex-noAnchorIndex-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

LayoutTests:

Added layout test to reproduce an assertion hit in
WebCore::HTMLSelectElement::updateListBoxSelection() when pressing the left
button outside a multiselect and then moving the mouse over the multiselect
element while holding the button down.

  • fast/dom/HTMLSelectElement/select-selectedIndex-noAnchorIndex-crash-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-noAnchorIndex-crash.html: Added.
11:14 AM Changeset in webkit [132245] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

[V8] ScriptWrappable should hold the wrapper handle directly (Dromaeo/dom-modify and dom-traverse get ~2.5% faster)
https://bugs.webkit.org/show_bug.cgi?id=97974

Reviewed by Eric Seidel.

Previously, we stored a pointer to a handle to a wrapper in Node. That
is an extra layer of indirection that slows down finding the wrapper
for the node. A handle is just a pointer, so we might as we just store
the handle in the Node directly. That speeds up dom-modify and
dom-traverse by about 2.5%.

This change also lets us get rid of the ChunkedTable we were using to
store all the wrappers because they're now stored in the Nodes
directly.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::get):
(WebCore::IntrusiveDOMWrapperMap::set):
(WebCore::IntrusiveDOMWrapperMap::contains):
(WebCore::IntrusiveDOMWrapperMap::visit):
(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
(WebCore::IntrusiveDOMWrapperMap::clear):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::ScriptWrappable):
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::reportMemoryUsage):
(ScriptWrappable):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

10:58 AM Changeset in webkit [132244] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Regression(r132143): Assertion hit in JSC::Interpreter::StackPolicy::StackPolicy(JSC::Interpreter&, const WTF::StackBounds&)
https://bugs.webkit.org/show_bug.cgi?id=100109

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23
Reviewed by Oliver Hunt.

Fix possible integer overflow in StackPolicy constructor by
using size_t type instead of int for stack sizes. The value
returned by StackBounds::size() is of type size_t but was
assigned to an int, which may overflow.

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::StackPolicy::StackPolicy):

10:57 AM Changeset in webkit [132243] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Replace SetGlobalGCPrologueCallback() with AddGCPrologueCallback()
https://bugs.webkit.org/show_bug.cgi?id=100140

Reviewed by Adam Barth.

SetGlobalGCPrologueCallback() and SetGlobalGCEpilogueCallback()
are deprecated (See http://code.google.com/codesearch#OAMlx_jo-ck/src/v8/include/v8.h&exact_package=chromium&q=v8.h&type=cs&l=3149)
Instead we should use AddGCPrologueCallback()
and AddGCEpilogueCallback().

No tests. No change in behavior.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::initializeV8IfNeeded):

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::gcPrologue):
(WebCore):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
(WebCore::V8GCController::gcEpilogue):
(WebCore::V8GCController::minorGCEpilogue):
(WebCore::V8GCController::majorGCEpilogue):

  • bindings/v8/V8GCController.h:

(V8GCController):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initIsolate):

10:34 AM Changeset in webkit [132242] by abarth@webkit.org
  • 13 edits in trunk/Source/WebCore

[V8] Enumerate Nodes via the V8 heap rather than via a list in WebCore
https://bugs.webkit.org/show_bug.cgi?id=100033

Reviewed by Eric Seidel.

This patch changes how we enumerate nodes during garbage collection.
After this patch, we use V8's list of open handles to enumerate node
wrappers rather than using a separate list that we maintain in WebCore
for this purpose. A future patch will remove the list in WebCore for a
DOM performance gain.

  • bindings/js/ScriptProfiler.h:

(WebCore):
(WebCore::ScriptProfiler::visitNodeWrappers):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::IntrusiveDOMWrapperMap::set):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

  • bindings/v8/ScriptProfiler.h:

(WebCore):
(ScriptProfiler):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::NodeWrapperVisitor::~NodeWrapperVisitor):
(WebCore):
(WebCore::visitAllDOMNodes):

  • bindings/v8/V8DOMMap.h:

(WebCore):
(NodeWrapperVisitor):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode):

  • bindings/v8/V8GCController.cpp:

(WebCore::NodeVisitor::visitNodeWrapper):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::gcEpilogue):

  • inspector/BindingVisitors.h:

(WebCore::WrappedNodeVisitor::~WrappedNodeVisitor):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

10:25 AM Changeset in webkit [132241] by jochen@chromium.org
  • 6 edits in trunk/Tools

[chromium] remove the const qualifier from WebTestDelegate::printMessage
https://bugs.webkit.org/show_bug.cgi?id=100082

Reviewed by Adam Barth.

There's no reason the method should be const, and indeed for
content_shell we want to send an IPC which is a non-const operation.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::printMessage):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printMessage):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:12 AM Changeset in webkit [132240] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make selection in search input box not overlap cancel button
https://bugs.webkit.org/show_bug.cgi?id=100130

Reviewed by Antonio Gomes.

This ensures that even when selection is active, the user can still press 'cancel'.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):

10:06 AM Changeset in webkit [132239] by caseq@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: paint rectangles are incorrectly shown in case subframes are present
https://bugs.webkit.org/show_bug.cgi?id=99849

Reviewed by Pavel Feldman.

Move GraphicsContext and paint rectangle from willPaint() to didPaint(), so we don't have
to store them as a state of InspectorPageAgent

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didPaint):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::didPaint):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/TimelineRecordFactory.cpp:
  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

  • page/FrameView.cpp:

(WebCore::FrameView::paintContents):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

10:04 AM Changeset in webkit [132238] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: array grouping does not work for arrays with exactly 10000 elements.
https://bugs.webkit.org/show_bug.cgi?id=100131

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Using ceil() - 1 instead of floor() in bucket size calculation.

  • inspector/front-end/ObjectPropertiesSection.js:

LayoutTests:

  • inspector/console/console-big-array-expected.txt:
  • inspector/console/console-big-array.html:
9:39 AM Changeset in webkit [132237] by shinyak@chromium.org
  • 8 edits
    2 adds in trunk

The order of resolving distribution in tree composition is wrong.
https://bugs.webkit.org/show_bug.cgi?id=99552

Reviewed by Dimitri Glazkov.

Source/WebCore:

According to the current ShadowDOM spec, we have to resolve <content> first, then resolve <shadow>.
However, the order of resolution is now the mixed tree order of <content> and <shadow>.

Test: fast/dom/shadow/content-reprojection-order.html

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute): We should resolve <content> before <shadow>.
Only the first active shadow insertion point can select the rest of contents.

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):

  • html/shadow/HTMLShadowElement.cpp:
  • html/shadow/HTMLShadowElement.h:

(WebCore::isHTMLShadowElement):
(WebCore):
(WebCore::toHTMLShadowElement):

  • html/shadow/InsertionPoint.h:

(InsertionPoint): We don't need doesSelectFromHostChildren() anymore.

LayoutTests:

We also fix the existing wrong test.

  • fast/dom/shadow/content-reprojection-order-expected.html: Added.
  • fast/dom/shadow/content-reprojection-order.html: Added.
  • fast/dom/shadow/shadow-element-rendering-single.html:
9:33 AM Changeset in webkit [132236] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectation for fast/media/mq-resolution.html, it relies
on the Resolution Media Query feature being enabled.
Adding a proper bug modifier for fast/files/workers/worker-apply-blob-url-to-xhr.html.

  • platform/gtk/TestExpectations:
9:32 AM Changeset in webkit [132235] by allan.jensen@digia.com
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Add preference for enabling scroll animators
https://bugs.webkit.org/show_bug.cgi?id=100124

Reviewed by Jocelyn Turcotte.

Expose the ScollAnimatorEnabled setting in QWebPreferences.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::scrollAnimatorEnabled):
(QWebPreferences::setScrollAnimatorEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:
9:25 AM Changeset in webkit [132234] by vsevik@chromium.org
  • 11 edits in trunk

Web Inspector: Move UISourceCode creation out of mappings to workspace.
https://bugs.webkit.org/show_bug.cgi?id=100092

Reviewed by Pavel Feldman.

Source/WebCore:

Moved uiSourceCode constructor calls out of mappings to workspace.

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._deleteOriginalUISourceCodeForScripts):
(WebInspector.ResourceScriptMapping.prototype._deleteTemporaryUISourceCodeForScripts):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._createUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateOriginalUISourceCode):

  • inspector/front-end/SASSSourceMapping.js:

(_bindUISourceCode):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):

  • inspector/front-end/Workspace.js:

(WebInspector.Project.prototype.addUISourceCode):
(WebInspector.Project.prototype.removeUISourceCode):
(WebInspector.Workspace.prototype.addTemporaryUISourceCode):
(WebInspector.Workspace.prototype.removeTemporaryUISourceCode):

LayoutTests:

  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):

  • inspector/debugger/resource-script-mapping-expected.txt:
  • inspector/debugger/scripts-panel.html:
9:22 AM Changeset in webkit [132233] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary m_layoutDelta[XY]Saturated initialization
https://bugs.webkit.org/show_bug.cgi?id=100018

Reviewed by Julien Chaffraix.

Remove unnecessary initialization from LayoutState constructor
added in r132105.

No new tests, no change in functionality.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

9:18 AM Changeset in webkit [132232] by zeno.albisser@digia.com
  • 4 edits in trunk/Source/WebCore

[Texmap] Fix drawTextureRectangleARB after r131485.
https://bugs.webkit.org/show_bug.cgi?id=100133

Consistently rename u_textureSize to u_samplerSize.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTextureRectangleARB):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::getShaderSpec):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(TextureMapperShaderProgram):

9:09 AM Changeset in webkit [132231] by mkwst@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Web Inspector: 'data:' URLs should be properly trimmed for readability.
https://bugs.webkit.org/show_bug.cgi?id=100083

Reviewed by Pavel Feldman.

We recently landed a patch to trim the middle out of long URLs in
console messages in order to improve readability. That patch didn't
effect 'data:' URLs, as they didn't match the regex in the linkifier.
This patch ensures that 'data:' URLs are properly trimmed down to
size.

This problem came to light while resolving a different, smaller issue:
'image/jpg' wasn't whitelisted as an image MIME type. That trivial fix
is included in this patch.

Test: http/tests/inspector/network/image-as-text-loading-data-url.html

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager):

Adds 'image/jpg' as a valid image type.

  • inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):

Supports 'data:' URLs in the linkifier's regex.

LayoutTests: Web Inspector: MIME type errors should truncate long URLs.
https://bugs.webkit.org/show_bug.cgi?id=100083

Reviewed by Pavel Feldman.

  • http/tests/inspector/network/image-as-text-loading-data-url-expected.txt: Added.
  • http/tests/inspector/network/image-as-text-loading-data-url.html: Added.
9:07 AM Changeset in webkit [132230] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Floated anchor element sometimes overlaps following content.
https://bugs.webkit.org/show_bug.cgi?id=100105

Reviewed by Pavel Feldman.

This patch ensures that each console message clears the
potentially-overlapping floated anchor element.

  • inspector/front-end/inspector.css:

(#console-prompt):
(.console-message, .console-user-command):

Clear the float, and flip the border from the bottom of the
message to the top. Do the same for the prompt.

(.console-message:first-child):

Ensure that the first message doesn't have a top border.

8:57 AM Changeset in webkit [132229] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Crash when adding a keyframes rule in the Styles pane
https://bugs.webkit.org/show_bug.cgi?id=99826

Reviewed by Pavel Feldman.

Source/WebCore:

The client-supplied selector text is first parsed to make sure it results in a valid style rule selector.

Test: inspector/styles/add-new-rule-invalid-selector.html

  • inspector/InspectorStyleSheet.cpp:

(WebCore::createCSSParser):
(WebCore):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::checkStyleRuleSelector):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

LayoutTests:

  • inspector/styles/add-new-rule-invalid-selector-expected.txt: Added.
  • inspector/styles/add-new-rule-invalid-selector.html: Added.
8:44 AM Changeset in webkit [132228] by commit-queue@webkit.org
  • 19 edits in trunk/Source/WebKit2

[EFL][WK2] Use the port independent PageViewportController
https://bugs.webkit.org/show_bug.cgi?id=99850

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Take PageViewportController into use, and rely on it to calculate
scroll position and zoom level.
With this patch, we can do intra page navigation and use the scrollwheel
to scroll, when WTF_USE_TILED_BACKING_STORE and all related flags are enabled.

  • CMakeLists.txt:
  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeViewportProperties):
(WebKit::PageClientImpl::pageDidRequestScroll):
(WebKit::PageClientImpl::didChangeContentsSize):
(WebKit):
(WebKit::PageClientImpl::didRenderFrame):
(WebKit::PageClientImpl::pageTransitionViewportReady):

  • UIProcess/API/efl/PageClientImpl.h:

(WebKit):
(PageClientImpl):
(WebKit::PageClientImpl::setPageViewportController):

  • UIProcess/API/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::PageViewportControllerClientEfl):
(WebKit::PageViewportControllerClientEfl::display):
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::setVisibleContentsRect):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setContentsScale):
(WebKit::PageViewportControllerClientEfl::didResumeContent):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
(WebKit::PageViewportControllerClientEfl::setController):

  • UIProcess/API/efl/PageViewportControllerClientEfl.h:

(WebKit::PageViewportControllerClientEfl::scaleFactor):
(WebKit::PageViewportControllerClientEfl::scrollPosition):
(PageViewportControllerClientEfl):

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(mapToWebContent):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_initialize):
(ewk_view_load_committed):
(ewk_view_feed_touch_event):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::didRenderFrame):

  • UIProcess/PageClient.h:

(PageClient):

  • UIProcess/PageViewportController.cpp:
  • UIProcess/PageViewportController.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit):
(WebKit::WebPageProxy::pageTransitionViewportReady):
(WebKit::WebPageProxy::didRenderFrame):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit):
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
(WebKit::PageLoadClientEfl::PageLoadClientEfl):

  • UIProcess/efl/PageLoadClientEfl.h:

(PageLoadClientEfl):

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit):
(WebKit::WebPageProxy::setUserScripts):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCompletePageTransition):

8:15 AM Changeset in webkit [132227] by kenneth@webkit.org
  • 33 edits
    2 adds in trunk

Add support for resolution media query
https://bugs.webkit.org/show_bug.cgi?id=99077

Reviewed by Antti Koivisto.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Add support for the RESOLUTION_MEDIA_QUERY feature flag.

  • Source/autotools/symbols.filter:

Export the WebCore::Settings setting.

Source/WebCore:

Add support for 'resolution' media query feature.

Background info:
http://www.w3.org/blog/CSS/2012/06/14/unprefix-webkit-device-pixel-ratio

Related spec links:
http://www.w3.org/TR/css3-mediaqueries/#resolution (recommendation)
http://www.w3.org/TR/css3-values/#resolution (candidate recommentation)

Add infrastructure to make it testable.

Test: fast/media/mq-resolution.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::detectNumberToken):

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::unitCategory):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):

  • css/CSSPrimitiveValue.h:

Enable dpi, dpcm and dppx units when RESOLUTION_MEDIA_QUERY
is enabled.

  • WebCore.exp.in:

Export the WebCore::Settings setting.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isDotsPerInch):
(WebCore::CSSPrimitiveValue::isDotsPerPixel):
(WebCore::CSSPrimitiveValue::isDotsPerCentimeter):
(CSSPrimitiveValue):

Add function for checking the recently added density types.

  • css/MediaFeatureNames.h:

(MediaFeatureNames):

Add support for resolution, min-resolution and max-resolution.

  • css/MediaQueryEvaluator.cpp:

(WebCore::compareResolution): Add methods for comparing resolutions.
(WebCore):
(WebCore::resolutionMediaFeatureEval):
(WebCore::min_resolutionMediaFeatureEval):
(WebCore::max_resolutionMediaFeatureEval):

Implement the resolution method evaluation.

  • css/MediaQueryExp.cpp:

(WebCore::featureWithValidPositiveDensity):
(WebCore):
(WebCore::featureWithoutValue):
(WebCore::MediaQueryExp::MediaQueryExp):

Hook up resolution with the right pre-checks.

  • page/Screen.cpp:

(WebCore::Screen::horizontalDPI):
(WebCore::Screen::verticalDPI):

Check whether an override exists, and if so, uses it.
If not calculate the value given the device scale factor.

  • page/Settings.cpp:

(WebCore::Settings::setResolutionOverride):
(WebCore):

  • page/Settings.h:

(Settings):
(WebCore::Settings::resolutionOverride):

Add a resolution override to settings.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setResolutionOverride):
(WebCore):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Add a new setResolutionOverride method to internals.settings.

Source/WebKit/chromium:

Add support for the RESOLUTION_MEDIA_QUERY feature flag.

  • features.gypi:

Source/WebKit/mac:

Add support for the RESOLUTION_MEDIA_QUERY feature flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • win/WebKit2.def:

Add exports for the WebCore::Settings setting.

  • Configurations/FeatureDefines.xcconfig:

Add support for the RESOLUTION_MEDIA_QUERY feature flag.

Tools:

Add support for the RESOLUTION_MEDIA_QUERY feature flag.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

LayoutTests:

Test (resolution: x) media query to ensure compliance
with spec plus proposed dppx values.

  • fast/media/mq-resolution-expected.txt: Added.
  • fast/media/mq-resolution.html: Added.
  • LayoutTests/platform/mac/TestExpectations:
  • LayoutTests/platform/chromium/TestExpectations:

Skip the test as the ports do not enable CSS Image Resolution.

8:11 AM Changeset in webkit [132226] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.

  • platform/qt-5.0-wk2/http/tests/navigation/forward-and-cancel-expected.txt:
8:09 AM Changeset in webkit [132225] by Bruno de Oliveira Abinader
  • 2 edits in trunk/Tools

Adding myself to commiters.py
https://bugs.webkit.org/show_bug.cgi?id=100122

Unreviewed update to commiters.py.

  • Scripts/webkitpy/common/config/committers.py:
7:52 AM Changeset in webkit [132224] by anilsson@rim.com
  • 7 edits
    1 delete in trunk/Source/WebKit/blackberry

[BlackBerry] Let WebKit manage the SelectionOverlay
https://bugs.webkit.org/show_bug.cgi?id=99585

Reviewed by Rob Buis.

The SelectionOverlay was exposed to clients of the BlackBerry::WebKit
API. However, all the information and notifications necessary to manage
the SelectionOverlay are available within WebKit, so the client does
not have to shoulder this responsibility.

Remove WebSelection and all the related plumbing. Now that nobody is
using the class from the user interface thread, remove the message
related code in SelectionOverlay.

Add two calls to SelectionOverlay::hide() that are necessary now that
the client is no longer responsible for hiding it.

RIM PR: 225789

Reviewed internally by Mike Fenton.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):

  • Api/WebPage.h:

(WebKit):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebSelectionOverlay.h: Removed.
  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::cancelSelection): Hide the overlay here, because state is reset and selection mode is no longer active
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged): Also hide overlay here, to go with the call to cancelSelectionVisuals

  • WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):

  • WebKitSupport/SelectionOverlay.h:

(BlackBerry::WebKit::SelectionOverlay::create):
(SelectionOverlay):

7:51 AM WebKit Team edited by Bruno de Oliveira Abinader
Adding myself to commiters list. (diff)
7:51 AM Changeset in webkit [132223] by danakj@chromium.org
  • 3 edits in trunk/Source

[chromium] Expose setAutomaticallyComputeRasterScale on the WebLayer API
https://bugs.webkit.org/show_bug.cgi?id=100013

Reviewed by James Robinson.

This allows web content to opt-in to having their contentsScale
determined from their CSS transforms, without having this behaviour
unconditionally enabled globally.

Supports http://crbug.com/149943

  • chromium/public/WebLayer.h:

(WebLayer):

7:49 AM Changeset in webkit [132222] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] Port QWebPreferences to C++
https://bugs.webkit.org/show_bug.cgi?id=100121

Reviewed by Kenneth Rohde Christiansen.

Port all the WebPreference calls to using the direct API instead of going through
the auto-generated C API.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
(QWebPreferencesPrivate::preferences):

  • UIProcess/API/qt/qwebpreferences_p_p.h:
7:41 AM Changeset in webkit [132221] by timothy@apple.com
  • 2 edits in trunk/Tools

Unreviewed watchlist change to monitor Inspector IDLs.

  • Scripts/webkitpy/common/config/watchlist:
7:32 AM Changeset in webkit [132220] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Convert WebEvent's timestamp from millisecond to second.
https://bugs.webkit.org/show_bug.cgi?id=100101

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Convert timestamp to second to create WebEvent from Evas event because
the unit of timestamp from Evas Event is millisecond, but the unit of
timestamp for WebEvent is second.

  • Shared/efl/WebEventFactory.cpp:

(WebKit::convertMillisecondToSecond):
(WebKit):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):

7:29 AM Changeset in webkit [132219] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Improve the use of stencil buffer during compositing
https://bugs.webkit.org/show_bug.cgi?id=100020

We always want to scissor so remove the define.
Only turn stenciling on if needed.

Patch by Filip Spacek <fspacek@rim.com> on 2012-10-23
Reviewed by Rob Buis.

Reviewed internally by Arvid Nilsson.

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::updateScissorIfNeeded):

7:10 AM Changeset in webkit [132218] by Csaba Osztrogonác
  • 2 edits
    4 adds in trunk/LayoutTests

[Qt] Unreviewed holiday gardening to paint the bots green.

  • platform/qt-5.0-wk2/http/tests/navigation/forward-and-cancel-expected.txt: Added after r132041.
  • platform/qt-5.0-wk2/http/tests/navigation/postredirect-frames-expected.txt: Added after r132041.
  • platform/qt-5.0-wk2/http/tests/navigation/postredirect-goback2-expected.txt: Added after r132041.
  • platform/qt/TestExpectations: Skip new failing tests.
6:52 AM Changeset in webkit [132217] by commit-queue@webkit.org
  • 4 edits
    2 moves in trunk/Source/WebKit2

[EFL][WK2] Make request manager client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100093

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Make EFL's request manager client a C++ class and
move URL scheme handling code to it. The new
RequestManagerClientEfl is now in UIProcess/efl
instead of UIProcess/API/efl since it is not
part of the public API.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::Ewk_Context):
(Ewk_Context::requestManager):
(ewk_context_url_scheme_register):

  • UIProcess/API/efl/ewk_context_private.h:

(WebKit):
(Ewk_Context):

  • UIProcess/efl/RequestManagerClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_context_request_manager_client.cpp.

(WebKit):
(Ewk_Url_Scheme_Handler):
(WebKit::Ewk_Url_Scheme_Handler::Ewk_Url_Scheme_Handler):
(WebKit::toRequestManagerClientEfl):
(WebKit::RequestManagerClientEfl::didReceiveURIRequest):
(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
(WebKit::RequestManagerClientEfl::~RequestManagerClientEfl):
(WebKit::RequestManagerClientEfl::registerURLSchemeHandler):

  • UIProcess/efl/RequestManagerClientEfl.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_context_request_manager_client_private.h.

(WebKit):
(RequestManagerClientEfl):
(WebKit::RequestManagerClientEfl::create):

6:50 AM Changeset in webkit [132216] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.11.1

Tagging the WebKitGTK+ 1.11.1 release

6:43 AM Changeset in webkit [132215] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: kick out non-chromium files from WebCore.gypi.

  • WebCore.gypi:
6:40 AM Changeset in webkit [132214] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and configure.ac for 1.11.1 release

.:

  • configure.ac: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.11.1.
6:37 AM Changeset in webkit [132213] by Carlos Garcia Campos
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing header file.
6:20 AM Changeset in webkit [132212] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[EFL][WK2] ecore_x should be initialised in WebProcess to avoid re-initialization by PlatformScreenEfl utilities and systemBeep() function
https://bugs.webkit.org/show_bug.cgi?id=100110

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Removed initialization of ecore_x, since it is initialized when process starts.

test: fast/media/*

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenDepth):
(WebCore::screenRect):

  • platform/efl/SoundEfl.cpp:

(WebCore::systemBeep):

Source/WebKit2:

PlatformScreenEfl functions and systemBeep() depend on ecore_x functionality, therefore,
ecore_x should be initialized when web process starts to avoid re-initialization.

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl): Initialized ecore_x module.

6:06 AM Changeset in webkit [132211] by adamk@chromium.org
  • 5 edits in trunk

Always parse pasted fragments as HTML even on XHTML pages
https://bugs.webkit.org/show_bug.cgi?id=99880

Reviewed by Ojan Vafai.

Source/WebCore:

When pasting HTML into a page, using the XML parser is unlikely
to work correctly, as the contents of the clipboard are unlikely
to be properly-formed XHTML. Thus, for the pasting case, it's always
better to use HTML parsing, which will properly parse either HTML
(which is what's usually in the clipboard) or XHTML (which is
sometimes there as well).

The Mac port previously worked around this problem by falling back to plain text
when parsing failed, but switching to HTML seems like a clear improvement.

This also fixes a crash in Chromium (see http://webkit.org/b/99607
and http://crbug.com/136218); it erroneously assumed that createFragmentFromMarkup()
would never return null. This patch makes that true.

  • editing/markup.cpp:

(WebCore::createFragmentFromMarkup): Don't delegate to createContextualFragment:
we already know our context element is safe (i.e., it's <body>),
and we want to force HTML (not XML) parsing.

LayoutTests:

Updated existing tests to match new expected behavior.

  • editing/pasteboard/paste-noscript-xhtml-expected.txt: The HTML

parser leaves <script> tags in the DOM when pasting, but removes their
attributes and children, so this is just as safe as the previous
behavior.

  • platform/mac/editing/pasteboard/paste-xml-expected.txt: Now that we

use the HTML parser, parsing the paste succeeds and so we insert DOM
instead of plain text. Similar rebaselines may be needed on other
platforms.

5:34 AM Changeset in webkit [132210] by ryuan.choi@samsung.com
  • 20 edits in trunk

[EFL][WK2] Add support for IMF composition
https://bugs.webkit.org/show_bug.cgi?id=89552

Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/FindEcore.cmake: Checked Ecore_IMF.

Source/WebKit2:

Implemented basic IMF support.

  • PlatformEfl.cmake:
  • Shared/NativeWebKeyboardEvent.h:

(NativeWebKeyboardEvent):
(WebKit::NativeWebKeyboardEvent::isFiltered):
Added to determine whether current keyboard event is compositing.

  • Shared/efl/NativeWebKeyboardEventEfl.cpp:

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::updateTextInputState):
Added to change input state.

  • UIProcess/API/efl/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/efl/ewk_main.cpp:

(ewk_init): Called ecore_imf_init.
(ewk_shutdown): Called ecore_imf_shutdown.

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(_ewk_view_smart_key_down): Modified to send keyboard event to IMF.
(_ewk_view_smart_mouse_up): Modified to reset input method context.
(_ewk_view_preedit_changed): Added to send composition string.
(_ewk_view_commit): Added to send a message that composition is finished.
(_ewk_view_imf_context_create): Added to create Ecore_IMF_Context.
(_ewk_view_imf_context_destroy): Added to destroy Ecore_IMF_Context.
(ewk_view_text_input_state_update): Added to update input state.

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/PageClient.h: Moved updateTextInputState() to share with EFL port.

(PageClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::editorStateChanged):
Added PLATFORM(EFL) to call updateTextInputState()

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:

Added HandleInputMethodKeydown message to determine whether keydown is handled.

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::handleInputMethodKeydown):
Added to check whether input method handled keydown.
(WebKit::WebPageProxy::confirmComposition): Added to support composition.
(WebKit::WebPageProxy::setComposition): Ditto.
(WebKit::WebPageProxy::cancelComposition): Ditto.

  • WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:

(WebKit::WebEditorClient::handleInputMethodKeydown):
Added to check whether input method handled keydown.

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in: Added messages to support composition.
  • WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::targetFrameForEditing): Referenced from QT port to get focused frame.
(WebKit::WebPage::confirmComposition): Added to support composition.
(WebKit::WebPage::setComposition): Ditto.
(WebKit::WebPage::cancelComposition): Ditto.

5:33 AM Changeset in webkit [132209] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Make plugin process debugging easier (PLUGIN_PROCESS_COMMAND_PREFIX)
https://bugs.webkit.org/show_bug.cgi?id=99297

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Add support for PLUGIN_PROCESS_COMMAND_PREFIX environment variable, to allow easier
plugin debugging with e.g.:
$ PLUGIN_PROCESS_COMMAND_PREFIX="xterm gdb --args" MiniBrowser

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
(WebKit):

5:31 AM Changeset in webkit [132208] by commit-queue@webkit.org
  • 3 edits
    2 moves in trunk/Source/WebKit2

[EFL][WK2] Make Policy client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100089

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Make page policy client a C++ class and remove it from API folder.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(_ewk_view_initialize):

  • UIProcess/efl/PagePolicyClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_policy_client.cpp.

(WebKit):
(WebKit::toPagePolicyClientEfl):
(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):
(WebKit::PagePolicyClientEfl::decidePolicyForResponseCallback):
(WebKit::PagePolicyClientEfl::PagePolicyClientEfl):

  • UIProcess/efl/PagePolicyClientEfl.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_policy_client_private.h.

(WebKit):
(PagePolicyClientEfl):
(WebKit::PagePolicyClientEfl::create):
(WebKit::PagePolicyClientEfl::view):

5:30 AM Changeset in webkit [132207] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Fixing failure expectation for fast/sub-pixel/file-upload-control-at-fractional-offset.html,
the test is a reftest so the expectation should be ImageOnlyFailure.

  • platform/gtk/TestExpectations:
5:12 AM Changeset in webkit [132206] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2] [WTR] WebKitTestRunner needs testRunner.queueForwardNavigation
https://bugs.webkit.org/show_bug.cgi?id=99700

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implemented testRunner.queueForwardNavigation, made little refactoring in Work Queue
to obviate code duplication.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::queueBackNavigation):
(WTR):
(WTR::InjectedBundle::queueForwardNavigation):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::queueForwardNavigation):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/WorkQueueManager.cpp:

(NavigationItem):
(WTR::NavigationItem::NavigationItem):
(WTR::NavigationItem::invoke):
(WTR):
(WTR::WorkQueueManager::queueBackNavigation):
(WTR::WorkQueueManager::queueForwardNavigation):

  • WebKitTestRunner/WorkQueueManager.h:

(WorkQueueManager):

LayoutTests:

Unskipped http/tests/cache/subresource-failover-to-network.html for WK2 ports.

  • platform/wk2/TestExpectations:
5:10 AM Changeset in webkit [132205] by allan.jensen@digia.com
  • 4 edits in trunk

[Qt] REGRESSION (r130851): fast/text/word-space-with-kerning.html fails
https://bugs.webkit.org/show_bug.cgi?id=98876

Reviewed by Simon Hausmann.

Source/WebCore:

Do not add word-spacing for leading space. This matches what simple path font-width does.

Tested by existing tests.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForComplexText):

LayoutTests:

Unskip passing word-width tests.

  • platform/qt/TestExpectations:
5:08 AM Changeset in webkit [132204] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

viewport-128-expected.txt has been removed unexpectedly.
https://bugs.webkit.org/show_bug.cgi?id=100108

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-23
Reviewed by Gyuyoung Kim.

viewport-128-expected.txt has been removed by http://trac.webkit.org/changeset/132186 unexpectedly.

  • fast/viewport/viewport-128-expected.txt: Added.
4:41 AM Changeset in webkit [132203] by commit-queue@webkit.org
  • 3 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[EFL][WK2] Make UI client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100099

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-23
Reviewed by Gyuyoung Kim.

Made page UI client a C++ class and removed it from API directory.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(_ewk_view_initialize):

  • UIProcess/API/efl/ewk_view_ui_client.cpp: Removed.
  • UIProcess/API/efl/ewk_view_ui_client_private.h: Removed.
  • UIProcess/efl/PageUIClientEfl.cpp: Added.

(WebKit):
(WebKit::toPageUIClientEfl):
(WebKit::PageUIClientEfl::closePage):
(WebKit::PageUIClientEfl::createNewPage):
(WebKit::PageUIClientEfl::runJavaScriptAlert):
(WebKit::PageUIClientEfl::runJavaScriptConfirm):
(WebKit::PageUIClientEfl::runJavaScriptPrompt):
(WebKit::PageUIClientEfl::showColorPicker):
(WebKit::PageUIClientEfl::hideColorPicker):
(WebKit::PageUIClientEfl::exceededDatabaseQuota):
(WebKit::PageUIClientEfl::focus):
(WebKit::PageUIClientEfl::unfocus):
(WebKit::PageUIClientEfl::takeFocus):
(WebKit::PageUIClientEfl::getWindowFrame):
(WebKit::PageUIClientEfl::setWindowFrame):
(WebKit::PageUIClientEfl::PageUIClientEfl):

  • UIProcess/efl/PageUIClientEfl.h: Added.

(WebKit):
(PageUIClientEfl):
(WebKit::PageUIClientEfl::create):

4:36 AM Changeset in webkit [132202] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: Incorrect resolution of relative URLs containing a scheme in query parameters
https://bugs.webkit.org/show_bug.cgi?id=100084

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Use the RFC 3986 grammar for the URL scheme.

  • inspector/front-end/ParsedURL.js:

(WebInspector.ParsedURL):

LayoutTests:

  • inspector/styles/styles-url-linkify-expected.txt:
  • inspector/styles/styles-url-linkify.html:
4:27 AM Changeset in webkit [132201] by kling@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] REGRESSION(r132169): It broke all plugin related test.
<http://webkit.org/b/100094>

Unreviewed test fix, make the CoreIPC encode/decode functions for CString match again.

  • Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::encode):

3:53 AM Changeset in webkit [132200] by commit-queue@webkit.org
  • 6 edits
    1 move
    1 add
    1 delete in trunk/Source/WebKit2

[EFL][WK2] Make a download client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100005

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Make EFL's Download client a C++ class and move
the id <-> download mapping from Ewk_Context to
DownloadManagerEfl.

The Download client was also moved to
UIProcess/efl/ instead of UIProcess/API/efl/
since it is not part of the public API.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::handleDownloadRequest):

  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::Ewk_Context):
(Ewk_Context::downloadManager):

  • UIProcess/API/efl/ewk_context_download_client_private.h: Removed.
  • UIProcess/API/efl/ewk_context_private.h:

(Ewk_Context):

  • UIProcess/API/efl/ewk_download_job_private.h:
  • UIProcess/efl/DownloadManagerEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_context_download_client.cpp.

(WebKit):
(WebKit::toDownloadManagerEfl):
(WebKit::DownloadManagerEfl::decideDestinationWithSuggestedFilename):
(WebKit::DownloadManagerEfl::didReceiveResponse):
(WebKit::DownloadManagerEfl::didCreateDestination):
(WebKit::DownloadManagerEfl::didReceiveData):
(WebKit::DownloadManagerEfl::didFail):
(WebKit::DownloadManagerEfl::didCancel):
(WebKit::DownloadManagerEfl::didFinish):
(WebKit::DownloadManagerEfl::DownloadManagerEfl):
(WebKit::DownloadManagerEfl::registerDownload):
(WebKit::DownloadManagerEfl::downloadJob):
(WebKit::DownloadManagerEfl::unregisterDownloadJob):

  • UIProcess/efl/DownloadManagerEfl.h: Added.

(WebKit):
(DownloadManagerEfl):
(WebKit::DownloadManagerEfl::create):

3:45 AM Changeset in webkit [132199] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Elaborate source panel sidebar context menus.
https://bugs.webkit.org/show_bug.cgi?id=99980

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-23
Reviewed by Vsevolod Vlasov.

  • Watches: add "Add watch expression" item to items and empty element
  • Watches: hide "Remove watch expression" from editing prompt context menu
  • Watches: add titles to header buttons
  • XHR Breakpoints: add "Add Breakpoint" item to items and empty element
  • XHR Breakpoints: add "Remove all breakpoints" item to items (when >1)
  • XHR Breakpoints: add title to header button
  • JS Breakpoints: hide "Remove/(De)Activate breakpoints" when only 1 item present
  • JS Breakpoints: add "(De)Activate breakpoints" to empty element context menu
  • English.lproj/localizedStrings.js: Added corresponding strings.
  • inspector/front-end/BreakpointsSidebarPane.js: Adjusted context menu.

(WebInspector.XHRBreakpointsSidebarPane): Ditto.

  • inspector/front-end/ObjectPropertiesSection.js: Added "isEditing()"
  • inspector/front-end/WatchExpressionsSidebarPane.js: Adjusted context menu.
3:14 AM Changeset in webkit [132198] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Update binding test results for r132194
https://bugs.webkit.org/show_bug.cgi?id=100097

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::installPerContextProperties):

3:05 AM Changeset in webkit [132197] by apavlov@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Sass can only resolve same folder paths
https://bugs.webkit.org/show_bug.cgi?id=99259

Reviewed by Vsevolod Vlasov.

The actual reason is that the rule source location linkifier tries to linkify a resource (*.scss), which does not exist,
and falls back to just stripping the main page URL prefix from the rule location URL. This change introduces LiveLocations
for CSSRule locations and makes sure they are linkified using uiSourceCode's parsedURL.displayName.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel): Introduced LiveLocation management for CSSRules.
(WebInspector.CSSStyleModel.prototype.setSourceMapping):
(WebInspector.CSSStyleModel.prototype._updateLocations):
(WebInspector.CSSStyleModel.prototype.createLiveLocation):
(WebInspector.CSSStyleModel.prototype.updateLocations):
(WebInspector.CSSStyleModel.LiveLocation): A LiveLocation for the CSS domain.
(WebInspector.CSSStyleModel.LiveLocation.prototype.uiLocation):
(WebInspector.CSSStyleModel.LiveLocation.prototype.dispose):

  • inspector/front-end/Linkifier.js:

(WebInspector.Linkifier.prototype.linkifyCSSRuleLocation): CSSRule LiveLocation-based link builder.
(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor): Add a title for anchors.
(WebInspector.Linkifier.DefaultCSSFormatter): Formatter for CSS location links.
(WebInspector.Linkifier.DefaultCSSFormatter.prototype.formatLiveAnchor):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.displayNameForURL): Use parsedURL.displayName if uiSourceCode is present for the specified URL.

  • inspector/front-end/SASSSourceMapping.js:
  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):

  • inspector/front-end/inspector.html:
2:58 AM Changeset in webkit [132196] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk

Unreviewed, rolling out r132149.
http://trac.webkit.org/changeset/132149
https://bugs.webkit.org/show_bug.cgi?id=100098

Breaks inspector profiler tests in debug mode. (Requested by
pfeldman1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-23

Source/WebCore:

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
(WebCore::RenderTableCol::computePreferredLogicalWidths):

  • rendering/RenderTableCol.h:

(RenderTableCol):

LayoutTests:

  • fast/table/col-span-change-relayout-expected.txt: Removed.
  • fast/table/col-span-change-relayout.html: Removed.
2:49 AM Changeset in webkit [132195] by Simon Hausmann
  • 4 edits in trunk

Unreviewed trivial Qt build fix: Fix build without USE_3D_GRAPHICS

Source/WebCore:

Move the #if USE(GRAPHICS_SURFACE) up to protect the inclusion of
GraphicsContext3D.h to be done only if we use the surface.

  • platform/graphics/surfaces/GraphicsSurface.h:

Tools:

Disable USE_GRAPHICS_SURFACE if we don't have USE_3D_GRAPHICS because
GraphicsSurface.h needs GraphicsContext3D.

  • qmake/mkspecs/features/features.prf:
2:47 AM Changeset in webkit [132194] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r132033.
http://trac.webkit.org/changeset/132033
https://bugs.webkit.org/show_bug.cgi?id=100097

Broke calendar picker (Requested by tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-23

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

2:15 AM Changeset in webkit [132193] by abecsi@webkit.org
  • 21 edits in trunk

Remove devicePixelRatio from ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=99845

Reviewed by Adam Barth.

.:

  • Source/autotools/symbols.filter: Update symbol.

Source/WebCore:

Since r121555 the devicePixelRatio is not calculated any more
and the scale factor is stored in Page::m_deviceScaleFactor,
thus it can be removed from ViewportAttributes to reduce
redundancy and unnecessary client code.
Use a new parameter in viewport calculation functions using
the visible viewport size (instead of passing the adjusted
viewport size) so that after this change clients do not end
up using the unadjusted viewport size for calculations.

No behavioural change, no new tests needed.

  • WebCore.exp.in:
  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):
(WebCore::computeMinimumScaleFactorForContentContained):
Add the devicePixelRatio as a parameter.
(WebCore::restrictMinimumScaleFactorToViewportSize): Ditto.

  • dom/ViewportArguments.h:

(ViewportAttributes):
(WebCore):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::configurationForViewport):

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(_ewk_view_viewport_attributes_compute):
Pass the device pixel ratio as a function argument.

Source/WebKit/gtk:

  • webkit/webkitviewportattributes.cpp:

(webkitViewportAttributesRecompute):
Pass the device pixel ratio as a function argument.

Source/WebKit/qt:

Pass the device pixel ratio as a function argument to
match the new API.

  • Api/qwebpage.cpp:

(QWebPage::viewportAttributesForSize):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

Update PageViewportController and co. to pass the device pixel ratio
as an argument to functions that need to adjust the visible viewport size.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::updateMinimumScaleToFit):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::didChangeViewportAttributes):

1:40 AM Changeset in webkit [132192] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] Refactor Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=99594

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Ewk_Context is now encapsulated to a C++ class inherited from WTF::RefCounted.
Also the same instance of Ewk_Context is returned for the same instance of
WKContext, so memory leak in ewk_view is also fixed.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::handleDownloadRequest):

  • UIProcess/API/efl/ewk_context.cpp:

(contextMap):
(Ewk_Context::Ewk_Context):
(Ewk_Context::~Ewk_Context):
(Ewk_Context::create):
(Ewk_Context::defaultContext):
(Ewk_Context::cookieManager):
(Ewk_Context::faviconDatabase):
(Ewk_Context::registerURLScheme):
(Ewk_Context::vibrationProvider):
(Ewk_Context::addVisitedLink):
(Ewk_Context::setCacheModel):
(Ewk_Context::cacheModel):
(ewk_context_ref):
(ewk_context_unref):
(ewk_context_cookie_manager_get):
(ewk_context_favicon_database_get):
(Ewk_Context::wkContext):
(Ewk_Context::addDownloadJob):
(Ewk_Context::downloadJob):
(Ewk_Context::removeDownloadJob):
(Ewk_Context::requestManager):
(Ewk_Context::urlSchemeRequestReceived):
(ewk_context_default_get):
(ewk_context_new):
(ewk_context_new_with_injected_bundle_path):
(ewk_context_url_scheme_register):
(ewk_context_vibration_client_callbacks_set):
(ewk_context_history_callbacks_set):
(ewk_context_visited_link_add):
(ewk_context_cache_model_set):
(ewk_context_cache_model_get):

  • UIProcess/API/efl/ewk_context_download_client.cpp:

(decideDestinationWithSuggestedFilename):
(didReceiveResponse):
(didCreateDestination):
(didReceiveData):
(didFail):
(didCancel):
(didFinish):
(ewk_context_download_client_attach):

  • UIProcess/API/efl/ewk_context_history_client.cpp:

(getEwkHistoryClient):
(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
(populateVisitedLinks):
(ewk_context_history_client_attach):

  • UIProcess/API/efl/ewk_context_private.h:

(Ewk_Context):
(Ewk_Context::historyClient):

  • UIProcess/API/efl/ewk_context_request_manager_client.cpp:

(didReceiveURIRequest):
(ewk_context_request_manager_client_attach):

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(Ewk_View_Private_Data::Ewk_View_Private_Data):
(Ewk_View_Private_Data::~Ewk_View_Private_Data):
(_ewk_view_priv_del):
(_ewk_view_initialize):
(ewk_view_base_add):
(ewk_view_add_with_context):
(ewk_view_context_get):
(ewk_view_update_icon):

1:25 AM Changeset in webkit [132191] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed build fix with newer Qt 5.

QPlastiqueStyle has been removed, but as pointed out by Jens it's also not
maintained anymore and hence safe to remove. We can do tweaks with the new
fusion style if required.

  • WebCoreSupport/QStyleFacadeImp.cpp:

(WebKit::QStyleFacadeImp::paintInnerSpinButton):

1:25 AM Changeset in webkit [132190] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed holiday gardening.

  • platform/qt/TestExpectations: Skip new tests (and sort) because ENABLE(SHADOW_DOM) is disabled.
1:11 AM Changeset in webkit [132189] by commit-queue@webkit.org
  • 3 edits
    1 move
    1 add
    1 delete in trunk/Source/WebKit2

[EFL][WK2] Make page load client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100081

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Make page load client a C++ class and move it
up to UIProcess/efl since it is not really part
of the public API.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(_ewk_view_initialize):

  • UIProcess/API/efl/ewk_view_loader_client_private.h: Removed.
  • UIProcess/efl/PageLoadClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_loader_client.cpp.

(WebKit):
(WebKit::toPageLoadClientEfl):
(WebKit::PageLoadClientEfl::didReceiveTitleForFrame):
(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):
(WebKit::PageLoadClientEfl::didChangeProgress):
(WebKit::PageLoadClientEfl::didFinishLoadForFrame):
(WebKit::PageLoadClientEfl::didFailLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didStartProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didFailProvisionalLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didChangeBackForwardList):
(WebKit::PageLoadClientEfl::didSameDocumentNavigationForFrame):
(WebKit::PageLoadClientEfl::PageLoadClientEfl):

  • UIProcess/efl/PageLoadClientEfl.h: Added.

(WebKit):
(PageLoadClientEfl):
(WebKit::PageLoadClientEfl::create):
(WebKit::PageLoadClientEfl::view):

1:09 AM Changeset in webkit [132188] by Simon Pena
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
1:01 AM Changeset in webkit [132187] by tkent@chromium.org
  • 10 edits in trunk

Support full month names in DateTimeEditElement, and use them in input[type=month] by default
https://bugs.webkit.org/show_bug.cgi?id=100060

Reviewed by Kentaro Hara.

Source/WebCore:

According to https://plus.google.com/104770450049736549185/posts/4zsoeHoa7SM
no one wants to show abbreviated month names for input[type=month].
This change add support for full month names in DateTimeEditELement, and
LocaleICU and LocaleMac retun month formats with full month names. Note
that LocaleWin::monthFormat returns formats for full month names.

No new tests. Covered by fast/forms/month-multiple-fields/month-multiple-fields-appearance-*.html

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitField):
If count is 4, use Localizer::monthLabels or standAloneMonthLabels.

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::monthFormat):
Returns a format for full month names.

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::monthFormat): Ditto.

Source/WebKit/chromium:

  • tests/LocaleMacTest.cpp:

(TEST_F): Follow LocaleMac::monthFormat change.

  • tests/LocalizedDateICUTest.cpp:

(TEST_F): Follow LocaleICU::monthFormat change.

LayoutTests:

Note: Other affected tests are already marked in TestExpectations.

  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html: Add max attributes to show appearance in typical usage.
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:

Updated.

12:58 AM Changeset in webkit [132186] by mkwst@chromium.org
  • 10 edits
    1 delete in trunk

Viewport errors should be slightly friendlier with regard to ';'.
https://bugs.webkit.org/show_bug.cgi?id=100003

Reviewed by Adam Barth.

Source/WebCore:

This patch scans viewport values that cause errors for ';'. If found,
a quick message is appended to the error, noting that semicolons are
not valid separators in viewport contents, and that commas would be
the proper substitute.

No functional changes, just a better error message.

  • dom/ViewportArguments.cpp:

(WebCore::reportViewportWarning):

LayoutTests:

  • fast/viewport/viewport-128-expected.txt:
  • fast/viewport/viewport-133-expected.txt:
  • fast/viewport/viewport-134-expected.txt:
  • fast/viewport/viewport-54-expected.txt:
  • fast/viewport/viewport-65-expected.txt:
  • fast/viewport/viewport-67-expected.txt:
  • fast/viewport/viewport-77-expected.txt:
  • fast/viewport/viewport-warnings-5-expected.txt:

Updating tests with new expectations.

12:53 AM Changeset in webkit [132185] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Docking/undocking the Web Inspector does not work correctly in Safari.

The "docked" and "bottom" strings need quoted instead of being passed as identifiers.

https://bugs.webkit.org/show_bug.cgi?id=100080

Reviewed by Yury Semikhatsky.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::setAttachedWindow): Put quotes around the %s.

12:26 AM Changeset in webkit [132184] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][WK2] Compilation warning in GraphicsContext3DPrivate.cpp when AC is enabled
https://bugs.webkit.org/show_bug.cgi?id=99723

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in GraphicsContext3DPrivate.cpp when AC is
enabled.

No new tests, no change in behavior.

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::createSurface):

12:24 AM Changeset in webkit [132183] by commit-queue@webkit.org
  • 19 edits in trunk

When blocking localStorage, Firefox throws a security exception on access, and maybe so should we
https://bugs.webkit.org/show_bug.cgi?id=63257

Patch by Dan Carney <dcarney@google.com> on 2012-10-23
Reviewed by Jochen Eisinger.

Source/WebCore:

Throw security exception when local storage is accessed
under certain circumstances to match firefox.

No new tests. Existing tests modified.

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore):
(WebCore::setDOMException):
(WebCore::V8Storage::namedPropertyEnumerator):
(WebCore::storageGetter):
(WebCore::V8Storage::namedPropertyQuery):
(WebCore::storageDeleter):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

  • storage/Storage.cpp:
  • storage/Storage.h:

(WebCore):
(WebCore::Storage::length):
(WebCore::Storage::key):
(WebCore::Storage::getItem):
(WebCore::Storage::setItem):
(WebCore::Storage::removeItem):
(WebCore::Storage::clear):
(WebCore::Storage::contains):

  • storage/Storage.idl:
  • storage/StorageArea.h:

(StorageArea):

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::canAccessStorage): Checks whether access to storage is a security violation.
(WebCore):
(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):
(WebCore::StorageAreaImpl::length):
(WebCore::StorageAreaImpl::key):
(WebCore::StorageAreaImpl::getItem):
(WebCore::StorageAreaImpl::setItem):
(WebCore::StorageAreaImpl::removeItem):
(WebCore::StorageAreaImpl::clear):
(WebCore::StorageAreaImpl::contains):

  • storage/StorageAreaImpl.h:

(StorageAreaImpl):

Source/WebKit/chromium:

Add security check and security check cache.

  • src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::StorageAreaProxy):
(WebCore::StorageAreaProxy::length):
(WebCore::StorageAreaProxy::key):
(WebCore::StorageAreaProxy::getItem):
(WebCore::StorageAreaProxy::setItem):
(WebCore::StorageAreaProxy::removeItem):
(WebCore::StorageAreaProxy::clear):
(WebCore::StorageAreaProxy::contains):
(WebCore::StorageAreaProxy::canAccessStorage):

  • src/StorageAreaProxy.h:

(StorageAreaProxy):
(WebCore::StorageAreaProxy::canAccessStorage):

LayoutTests:

Adjust tests to handle new exceptions.

  • fast/storage/storage-detached-iframe-expected.txt:
  • fast/storage/storage-detached-iframe.html:
  • platform/chromium/permissionclient/storage-permission-expected.txt:
  • platform/chromium/permissionclient/storage-permission.html:
12:12 AM Changeset in webkit [132182] by mark.lam@apple.com
  • 16 edits
    1 add in trunk

Make topCallFrame reliable.
https://bugs.webkit.org/show_bug.cgi?id=98928.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • VM entry points and the GC now uses topCallFrame.
  • The callerFrame value in CallFrames are now always the previous frame on the stack, except for the first frame which has a callerFrame of 0 (not counting the HostCallFrameFlag). Hence, we can now traverse every frame on the stack all the way back to the first frame.
  • GlobalExec's will no longer be used as the callerFrame values in call frames.
  • Added fences and traps for debugging the JSStack in debug builds.
  • bytecode/SamplingTool.h:

(SamplingTool):
(JSC::SamplingTool::CallRecord::CallRecord):

  • dfg/DFGOperations.cpp:
  • Fixed 2 DFG helper functions to flush topCallFrame as expected.
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::prepareForExternalCall):

  • interpreter/CallFrame.h:

(JSC::ExecState::callerFrameNoFlags):
(ExecState):
(JSC::ExecState::argIndexForRegister):
(JSC::ExecState::getArgumentUnsafe):

  • interpreter/CallFrameClosure.h:

(CallFrameClosure):

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::eval):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::endRepeatCall):

  • interpreter/Interpreter.h:

(JSC):
(Interpreter):

  • interpreter/JSStack.cpp:

(JSC::JSStack::JSStack):
(JSC::JSStack::gatherConservativeRoots):
(JSC::JSStack::disableErrorStackReserve):

  • interpreter/JSStack.h:

(JSC):
(JSStack):
(JSC::JSStack::installFence):
(JSC::JSStack::validateFence):
(JSC::JSStack::installTrapsAfterFrame):

  • interpreter/JSStackInlines.h: Added.

(JSC):
(JSC::JSStack::getTopOfFrame):
(JSC::JSStack::getTopOfStack):
(JSC::JSStack::getStartOfFrame):
(JSC::JSStack::pushFrame):
(JSC::JSStack::popFrame):
(JSC::JSStack::generateFenceValue):
(JSC::JSStack::installFence):
(JSC::JSStack::validateFence):
(JSC::JSStack::installTrapsAfterFrame):

  • jit/JITStubs.cpp:

(JSC::jitCompileFor):
(JSC::lazyLinkFor):

  • Set frame->codeBlock to 0 for both the above because they are called with partially intitialized frames (cb uninitialized), but may trigger a GC.

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

LayoutTests:

  • Re-baseline some tests to match the new stack dump results.
  • http/tests/inspector/console-resource-errors-expected.txt:
  • http/tests/inspector/stacktraces/csp-injected-content-warning-contains-stacktrace-expected.txt:
  • http/tests/inspector/stacktraces/csp-inline-warning-contains-stacktrace-expected.txt:

Oct 22, 2012:

10:56 PM Changeset in webkit [132181] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing failure for an accessibility test that's already passing.
Updating and adding expectations for subpixel tests to reflect
the current situation.

  • platform/gtk/TestExpectations:
10:51 PM Changeset in webkit [132180] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip fast/events/tabindex-focus-blur-all.html case.
https://bugs.webkit.org/show_bug.cgi?id=100067

Unreviewed, EFL gardening.

fast/events/tabindex-focus-blur-all.html case has been crashed due to ASSERT in hashtable.
Please refer to BUG 100065 for crash details.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-22

  • platform/efl-wk1/TestExpectations:
10:21 PM Changeset in webkit [132179] by jsbell@chromium.org
  • 8 edits
    1 delete in trunk/Source/WebCore

IndexedDB: Remove custom binding code for IDBCursor.value
https://bugs.webkit.org/show_bug.cgi?id=100034

Reviewed by Kentaro Hara.

Now that we're using ScriptValue instead of SerializedScriptValue we can just expose
IDBCursor.value as an |any| (IDL) or |ScriptValue| (C++) to maintain the specified
semantics that the object identity is retained across accesses.

Test: storage/indexeddb/cursor-value.html

  • Modules/indexeddb/IDBCursor.cpp: Remove "dirty" tracking.

(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::value):
(WebCore::IDBCursor::setValueReady):

  • Modules/indexeddb/IDBCursor.h: IDBAny -> ScriptValue

(IDBCursor):

  • Modules/indexeddb/IDBCursorWithValue.idl: IDBAny -> any
  • Modules/indexeddb/IDBObjectStore.cpp: No need to route through IDBAny to get ScriptValue.

(WebCore):

  • UseV8.cmake: Remove references to IDBCustomBindings.cpp
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • bindings/v8/IDBCustomBindings.cpp: Removed.
10:11 PM Changeset in webkit [132178] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Font’s fast code path is used for partial runs with kerning and ligatures, but shouldn’t be
https://bugs.webkit.org/show_bug.cgi?id=100068

Reviewed by Sam Weinig.

As described in <http://webkit.org/b/100050>, the fast code path doesn’t handle partial runs
correctly when kerning or ligatures are enabled. Since the partial-run case is uncommon,
for now just use the complex code path in this case.

  • platform/graphics/Font.cpp:

(WebCore::Font::drawText): Changed to use the complex path for partial runs if there are any
typesetting features.
(WebCore::Font::drawEmphasisMarks): Ditto.
(WebCore::Font::selectionRectForText): Ditto.
(WebCore::Font::offsetForPosition): Changed to use the complex path if there are any
typesetting features.

9:33 PM Changeset in webkit [132177] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Missing some cookies in HTTP response header when set several cookies in one "Set-Cookie" header.
https://bugs.webkit.org/show_bug.cgi?id=99950

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-10-22
Reviewed by George Staikos.

In "NetworkJob::handleNotifyHeaderReceived", if there are several "Set-Cookie" headers,
we should combine the following ones with the first.

No new test case.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyHeaderReceived):

9:20 PM Changeset in webkit [132176] by morrita@google.com
  • 4 edits
    2 adds in trunk

Assertion failed at WebCore::toInsertionPoint / WebCore::ContentDistributor::distribute
https://bugs.webkit.org/show_bug.cgi?id=100038

Reviewed by Kent Tamura.

Source/WebCore:

isHTMLContentElement() assumes that the content element always has
a tag name "content" but it doesn't when Shadow DOM feature is
disabled. This fix let the function see the correct tag name.

Test: fast/dom/shadow/insertion-points-with-shadow-disabled.html

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::contentTagName):

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):
(WebCore::isHTMLContentElement):

LayoutTests:

  • fast/dom/shadow/insertion-points-with-shadow-disabled-expected.txt: Added.
  • fast/dom/shadow/insertion-points-with-shadow-disabled.html: Added.
8:43 PM Changeset in webkit [132175] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Include path in the repaint-text-decoration-style.html should be changed.
https://bugs.webkit.org/show_bug.cgi?id=100063

Unreviewed gardening.

The include path is differentiated by http://trac.webkit.org/changeset/132043

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-22

  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style.html:
8:08 PM Changeset in webkit [132174] by shinyak@chromium.org
  • 6 edits
    4 adds in trunk

[Shadow] Fallback content should also be reprojection.
https://bugs.webkit.org/show_bug.cgi?id=99750

Reviewed by Dimitri Glazkov.

Source/WebCore:

Fallback content of InsertionPoint should be reprojected. The existing assumption that
only the direct child of host element can be distributed to InsertionPoint does not hold anymore.
So, if the parent of an element is InsertionPoint which should show fallback element, we have to
check the grand parent of the element instead of the element.

Tests: fast/dom/shadow/content-reprojection-fallback-reprojection.html

fast/dom/shadow/content-reprojection-fallback.html

  • css/StyleResolver.cpp:

(WebCore::shouldResetStyleInheritance): Checks the grandparent of the element if the parent is
an InsertionPoint which uses fallback content.

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::shadowOfParentForDistribution):
(WebCore):
(WebCore::resolveReprojection):
(WebCore::ComposedShadowTreeWalker::traverseParent):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::shouldUseFallbackElements): True if the InsertionPoint should use fallback content.
(WebCore):

  • html/shadow/InsertionPoint.h:

(WebCore::parentElementForDistribution): Returns the grandparent element if the parent is InsertionPoint which uses
fallback content. Returns parent element otherwise.
(WebCore):

LayoutTests:

  • fast/dom/shadow/content-reprojection-fallback-expected.html: Added.
  • fast/dom/shadow/content-reprojection-fallback-reprojection-expected.html: Added.
  • fast/dom/shadow/content-reprojection-fallback-reprojection.html: Added.
  • fast/dom/shadow/content-reprojection-fallback.html: Added.
7:58 PM Changeset in webkit [132173] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Suppress compositor invalidations during FrameView recreation in force-compositing-mode
https://bugs.webkit.org/show_bug.cgi?id=99882

Patch by James Robinson <jamesr@chromium.org> on 2012-10-22
Reviewed by Adrienne Walker.

In force compositing mode, page navigation temporarily takes us in and out of compositing mode because the
root GraphicsLayer is owned by the FrameView which is destroyed and recreated. These changes generate
invalidations on the WebViewClient that trigger frames but aren't actually terribly useful. WebCore suppresses
repaints too early during page load to avoid flashing white or mostly white and to avoid impacting page load time.

This suppresses compositor invalidations during FrameView recreation.

Covered by chromium's page cycler performance tests.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::commitDocumentData):
(WebKit::WebFrameImpl::createFrameView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::suppressInvalidations):
(WebKit):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::scheduleComposite):

  • src/WebViewImpl.h:

(WebViewImpl):

7:14 PM Changeset in webkit [132172] by keishi@webkit.org
  • 3 edits in trunk/Source/WebCore

Label position is wrong in the suggestion picker when all the suggestions have labels
https://bugs.webkit.org/show_bug.cgi?id=99965

Reviewed by Kent Tamura.

Somehow the scrollbar was appearing and so the label element was being wrapped to the next line.

No new tests. Can't reproduce in layout test.

  • Resources/pagepopups/suggestionPicker.css:

(.suggestion-list):

  • Resources/pagepopups/suggestionPicker.js:

(SuggestionPicker.prototype._fixWindowSize): Explicitly show the scroll bar.

7:05 PM Changeset in webkit [132171] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

[Chromium] Needs to track ShadowRoot usage
https://bugs.webkit.org/show_bug.cgi?id=99955

Reviewed by Dimitri Glazkov.

Added an UMA instrumentation.

  • dom/ShadowRoot.cpp:

(WebCore::determineUsageType):
(WebCore):
(WebCore::ShadowRoot::create):

6:22 PM Changeset in webkit [132170] by tkent@chromium.org
  • 12 edits in trunk/Source

Introduce Localizer::standAloneMonthLabels
https://bugs.webkit.org/show_bug.cgi?id=99963

Reviewed by Kentaro Hara.

Source/WebCore:

We realized full month names and full stand-alone month names were
necessary for input[type=month] UI. We change the compile-flag for
Localizer::monthLabels from "ENABLE(CALENDAR_PICKER)" to

"ENABLE(CALENDAR_PICKER)
ENABLE(INPUT_MULTIPLE_FIELDS_UI)," and

introduce Localizer::standAloneMonthLabels.

Tests: Add some test cases to Source/WebKit/chromium/LocaleMacTest.cpp
and LocalizedDateICUTest.cpp.

  • platform/text/Localizer.h:

(Localizer):

  • Add pure virtual standAloneMonthLabels.
  • Change the condition for monthLabels.
  • platform/text/LocaleNone.cpp:

(LocaleNone): Declare monthLabels, standAloneMonthLabels, and m_monthLabels.
(WebCore::LocaleNone::monthLabels):
Added. It always returns English month names.
(WebCore::LocaleNone::standAloneMonthLabels):
Added. Just calls monthLabels.

  • platform/text/LocaleWin.h:

(LocaleWin):
Declare standAloneMonthLabels, and change the condition for monthLabels.

  • platform/text/LocaleWin.cpp:

(WebCore): Change the condition for monthLabels.
(WebCore::LocaleWin::standAloneMonthLabels):
Added. Just calls monthLabels.

  • platform/text/mac/LocaleMac.h:

(LocaleMac):

  • Add standAloneMonthLabels and m_standAloneMonthLabels
  • Change the condition for monthLabels and m_monthLabels.
  • platform/text/mac/LocaleMac.mm:

(WebCore): Change the condition for monthLabels.
(WebCore::LocaleMac::standAloneMonthLabels):
Added. Get the information with NSDateFormatter::standaloneMonthSymbols.

  • platform/text/LocaleICU.h:

(LocaleICU):

  • Add standAloneMonthLabels and m_standAloneMonthLabels
  • Change the condition for monthLabels and m_monthLabels.
  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::initializeCalendar):
Remove m_monthLabels initialization in order to avoid dependecy from monthLabels.
(WebCore):
(WebCore::createFallbackMonthLabels): Change the compile condition.
(WebCore::LocaleICU::monthLabels):

  • Change the compile condition.
  • Don't depend on initializeCalendar to make the code for

ENABLE(INPUT_MULTIPLE_FIELDS_UI) && !ENABLE(CALENDAR_PICKER) minimal.
(WebCore::LocaleICU::standAloneMonthLabels):
Added. The code is similar to shortStandAloneMonthLabels.

Source/WebKit/chromium:

Note that we don't add tests to LocaleWinTest because new function
LocaleWin::standAloneMonthLabels is equivalent to monthLabels.

  • tests/LocaleMacTest.cpp:

(LocaleMacTest::standAloneMonthLabel): Added a helper function.
(TEST_F): Add some tests. We don't test ru_ru locale because it has
different data on OSX versions.

  • tests/LocalizedDateICUTest.cpp:

(LocalizedDateICUTest::standAloneMonthLabel): Added a helper function.
(TEST_F): Add some tests.

5:58 PM Changeset in webkit [132169] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Handle ArgumentCoder template specializations that take the ArgumentEncoder as a reference
https://bugs.webkit.org/show_bug.cgi?id=100056

Reviewed by Andreas Kling.

Use template magic to make it possible to have ArgumentCoder specializations where the encode
function takes the ArgumentEncoder object as a reference instead of as a pointer. Also, add an
operator<< to ArgumentEncoder and change the string related ArgumentCoder specializations over to taking
the encoder as a reference and using stream operators.

  • Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::encode):

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/ArgumentEncoder.h:

(ArgumentEncoder):
(UsesDeprecatedEncodeFunction):
(NoType):
(CoreIPC::ArgumentEncoder::encode):
(CoreIPC::ArgumentEncoder::operator<<):

5:55 PM Changeset in webkit [132168] by shinyak@chromium.org
  • 4 edits in trunk/Source/WebCore

Refactoring around ContainerNode::attachChildren
https://bugs.webkit.org/show_bug.cgi?id=99968

Reviewed by Hajime Morita.

Since ContainerNode::attach() is now equivalent to ContainerNode::attachChildren() + Node::attach(), we should call
ContainerNode::attach() instead of calling them.

No new tests, no change in behavior.

  • dom/ContainerNode.h:

(ContainerNode):

  • dom/Element.cpp:

(WebCore::Element::attach):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::attach):

5:45 PM Changeset in webkit [132167] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, more Chromium ML expectation updating.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium/TestExpectations:
5:42 PM Changeset in webkit [132166] by jochen@chromium.org
  • 7 edits in trunk/Tools

[chromium] Move the call to RegisterIsolatedFileSystem to the WebTestDelegate interface
https://bugs.webkit.org/show_bug.cgi?id=100048

Reviewed by Adam Barth.

The call needs to be done outside of the sandbox.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::beginDragWithFiles):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::registerIsolatedFileSystem):
(WebTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::registerIsolatedFileSystem):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

5:39 PM Changeset in webkit [132165] by msaboff@apple.com
  • 6 edits in trunk/Source/WebCore

HTML Parser should produce 8 bit strings for doctype, comment and tagName tokens
https://bugs.webkit.org/show_bug.cgi?id=99889

Reviewed by Geoffrey Garen.

Added 8 bit check for accumulating all token data in MarkupTokenBase. Added code to convert
"name" token data directly to a string (8 or 16 as appropriate). Changed to accumulate
m_bufferedEndTagName as LChar's.

No new tests, covered by existing tests.

  • html/parser/HTMLToken.h:

(HTMLToken):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):
(WebCore::HTMLTokenizer::addToPossibleEndTag):
(WebCore::HTMLTokenizer::isAppropriateEndTag):

  • html/parser/HTMLTokenizer.h:

(HTMLTokenizer):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeading):

  • xml/parser/MarkupTokenBase.h:

(WebCore::MarkupTokenBase::beginStartTag):
(WebCore::MarkupTokenBase::beginEndTag):
(MarkupTokenBase):
(WebCore::MarkupTokenBase::beginDOCTYPE):
(WebCore::MarkupTokenBase::appendToComment):
(WebCore::MarkupTokenBase::appendToName):
(WebCore::MarkupTokenBase::nameString):
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):

5:36 PM Writing Reftests edited by danakj@chromium.org
(diff)
5:03 PM Changeset in webkit [132164] by tony@chromium.org
  • 4 edits
    2 adds in trunk

margin-top/bottom has no effect for child nodes of flex items
https://bugs.webkit.org/show_bug.cgi?id=99923

Reviewed by Ojan Vafai.

Source/WebCore:

Flexitems, like table cells, shouldn't collapse margins.

Test: css3/flexbox/flexitem-no-margin-collapsing.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo): Check to see if the parent is a flexible box.
We should always have a parent if we make it this far in the check.

LayoutTests:

Add a test to make sure we don't collapse margins in flex items.

  • css3/flexbox/flexitem-no-margin-collapsing-expected.txt: Added.
  • css3/flexbox/flexitem-no-margin-collapsing.html: Added.
  • css3/flexbox/repaint.html:
5:00 PM Changeset in webkit [132163] by eae@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed chromium win rebaselines.

  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
4:52 PM Changeset in webkit [132162] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG::Array::Undecided should be called DFG::Array::SelectUsingPredictions
https://bugs.webkit.org/show_bug.cgi?id=100052

Reviewed by Oliver Hunt.

No functional change, just renaming. It's a clearer name that more accurately
reflects the meaning, and it eliminates the namespace confusion that will happen
with the Undecided indexing type in https://bugs.webkit.org/show_bug.cgi?id=98606

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::fromObserved):
(JSC::DFG::refineArrayMode):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):

  • dfg/DFGArrayMode.h:

(JSC::DFG::canCSEStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):
(JSC::DFG::benefitsFromStructureCheck):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::blessArrayOperation):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::arrayify):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:51 PM Changeset in webkit [132161] by andersca@apple.com
  • 22 edits in trunk/Source/WebKit2

More Argument coder cleanup
https://bugs.webkit.org/show_bug.cgi?id=100022

Reviewed by Andreas Kling.

Remove the ArgumentDecoder::decode overload that takes a const reference - if the call to decode ends up creating a temporary
we'll encode into it and then destroy it. Since this decode overload was mostly used with the CoreIPC::Out functions, remove them
(and CoreIPC::In) as well. Clean up a couple of ArgumentCoders as well.

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/Arguments.h:
  • Platform/CoreIPC/Connection.h:

(Connection):

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::decode):

  • Shared/PrintInfo.cpp:

(WebKit::PrintInfo::encode):
(WebKit::PrintInfo::decode):

  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::encode):
(WebKit::WebContextMenuItemData::decode):

  • Shared/WebEvent.cpp:

(WebKit::WebEvent::encode):
(WebKit::WebEvent::decode):

  • Shared/WebGeolocationPosition.cpp:

(WebKit::WebGeolocationPosition::Data::encode):
(WebKit::WebGeolocationPosition::Data::decode):

  • Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::encode):
(WebKit::WebMouseEvent::decode):

  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::encode):
(WebKit::WebPopupItem::decode):

  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::decodeMessageBody):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):

  • WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::decodeMessageBody):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::postInjectedBundleMessage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::postInjectedBundleMessage):

4:42 PM Changeset in webkit [132160] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, more Chromium ML expectation updating.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium/TestExpectations:
4:37 PM Changeset in webkit [132159] by msaboff@apple.com
  • 3 edits
    2 adds in trunk

Regression(r131655): Crash in StringImpl::findIgnoringCase
https://bugs.webkit.org/show_bug.cgi?id=99753

Reviewed by Geoffrey Garen.

Source/WTF:

Fixed to use the searchLength to take into account the start index.

Added LayoutTests/fast/js/find-ignoring-case-regress-99753.html

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::findIgnoringCase):

LayoutTests:

New regression test.

  • fast/js/find-ignoring-case-regress-99753-expected.txt: Added.
  • fast/js/find-ignoring-case-regress-99753.html: Added.
4:36 PM Changeset in webkit [132158] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: remove unneeded debug messages from find_files()
https://bugs.webkit.org/show_bug.cgi?id=100041

Reviewed by Adam Barth.

This routine gets called all the time when loading the virtual
suites, and the debug messages were spamming me.

  • Scripts/webkitpy/common/find_files.py:

(_normalized_find):

4:35 PM Changeset in webkit [132157] by commit-queue@webkit.org
  • 27 edits
    2 adds in trunk/Source/WebCore

Refactor CachedResourceLoader: add CachedResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=99736

Patch by Marja Hölttä <marja@chromium.org> on 2012-10-22
Reviewed by Adam Barth.

For fixing bugs 84883 and 92761,
CachedResourceLoader::requestResource should take as parameter
information about who initiated the request. But the parameter
list was already long. This gathers all the parameters into a
separate class, CachedResourceRequest. The next step is to add
information about who initiated the request into
CachedResourceRequest.

No new tests because no changes in functionality, just moving code
around.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::cachedFont):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::cachedImageSet):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

  • css/WebKitCSSSVGDocumentValue.cpp:

(WebCore::WebKitCSSSVGDocumentValue::load):

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::cachedShader):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestScript):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestShader):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::requestPreload):
(WebCore::CachedResourceLoader::defaultCachedResourceOptions):
(WebCore):

  • loader/cache/CachedResourceLoader.h:

(WebCore):
(CachedResourceLoader):

  • loader/cache/CachedResourceRequest.cpp: Added.

(WebCore):
(WebCore::CachedResourceRequest::CachedResourceRequest):

  • loader/cache/CachedResourceRequest.h: Added.

(WebCore):
(CachedResourceRequest):
(WebCore::CachedResourceRequest::mutableResourceRequest):
(WebCore::CachedResourceRequest::resourceRequest):
(WebCore::CachedResourceRequest::charset):
(WebCore::CachedResourceRequest::setCharset):
(WebCore::CachedResourceRequest::options):
(WebCore::CachedResourceRequest::priority):
(WebCore::CachedResourceRequest::forPreload):
(WebCore::CachedResourceRequest::setForPreload):
(WebCore::CachedResourceRequest::defer):
(WebCore::CachedResourceRequest::setDefer):

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::requestImageResource):

  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::loadFont):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::svgAttributeChanged):

  • xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::loadSheet):

4:32 PM Changeset in webkit [132156] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] ASSERT that removeAllDOMObjects() is called only on worker threads
https://bugs.webkit.org/show_bug.cgi?id=100046

Reviewed by Eric Seidel.

This function is called only on worker threads. We should ASSERT that
fact and remove the dead code that tries to handle the main thread
case.

  • bindings/v8/V8DOMMap.cpp:

(WebCore::removeAllDOMObjects):

4:32 PM Changeset in webkit [132155] by tony@chromium.org
  • 4 edits
    4 adds in trunk/LayoutTests

Unreviewed, land render tree results for css3/flexbox pixel test that
landed earlier this morning. The results were pulled from the bots.

  • platform/gtk/TestExpectations:
  • platform/gtk/css3/flexbox/flexbox-baseline-margins-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/mac/css3/flexbox/flexbox-baseline-margins-expected.txt: Added.
  • platform/qt/TestExpectations:
  • platform/qt/css3/flexbox/flexbox-baseline-margins-expected.txt: Added.
4:03 PM Changeset in webkit [132154] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Rebaseline another test after r131941 and r131991.

  • platform/efl/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png:
3:57 PM Changeset in webkit [132153] by rakuco@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[EFL] Add some missing SVG expectations.

  • platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/efl/svg/transforms/svg-css-transforms-expected.txt: Added.
3:53 PM Changeset in webkit [132152] by rakuco@webkit.org
  • 56 edits
    1 add in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 11.

Finally finish rebaselining the SVG tests!

  • platform/efl/svg/filters/animate-fill-expected.png:
  • platform/efl/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
  • platform/efl/svg/filters/feImage-change-target-id-expected.png:
  • platform/efl/svg/filters/feImage-multiple-targets-id-change-expected.png:
  • platform/efl/svg/filters/feImage-reference-invalidation-expected.png:
  • platform/efl/svg/filters/feImage-remove-target-expected.png:
  • platform/efl/svg/filters/feImage-target-add-to-document-expected.png:
  • platform/efl/svg/filters/feImage-target-attribute-change-expected.png:
  • platform/efl/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
  • platform/efl/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
  • platform/efl/svg/filters/feImage-target-changes-id-expected.png:
  • platform/efl/svg/filters/feImage-target-id-change-expected.png:
  • platform/efl/svg/filters/feImage-target-inline-style-change-expected.png:
  • platform/efl/svg/filters/feImage-target-property-change-expected.png:
  • platform/efl/svg/filters/feImage-target-reappend-to-document-expected.png:
  • platform/efl/svg/filters/feImage-target-remove-from-document-expected.png:
  • platform/efl/svg/filters/feImage-target-style-change-expected.png:
  • platform/efl/svg/filters/filter-refresh-expected.png:
  • platform/efl/svg/filters/filter-width-update-expected.png: Added.
  • platform/efl/svg/filters/invalidate-on-child-layout-expected.png:
  • platform/efl/svg/hixie/perf/001-expected.png:
  • platform/efl/svg/hixie/perf/002-expected.png:
  • platform/efl/svg/hixie/perf/003-expected.png:
  • platform/efl/svg/hixie/perf/004-expected.png:
  • platform/efl/svg/hixie/perf/005-expected.png:
  • platform/efl/svg/hixie/perf/006-expected.png:
  • platform/efl/svg/hixie/perf/007-expected.png:
  • platform/efl/svg/repaint/filter-child-repaint-expected.png:
  • platform/efl/svg/repaint/image-href-change-expected.png:
  • platform/efl/svg/repaint/image-with-clip-path-expected.png:
  • platform/efl/svg/repaint/inner-svg-change-viewBox-contract-expected.png:
  • platform/efl/svg/repaint/inner-svg-change-viewBox-expected.png:
  • platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.png:
  • platform/efl/svg/repaint/mask-clip-target-transform-expected.png:
  • platform/efl/svg/repaint/repainting-after-animation-element-removal-expected.png:
  • platform/efl/svg/repaint/text-mask-update-expected.png:
  • platform/efl/svg/text/append-text-node-to-tspan-expected.png:
  • platform/efl/svg/text/ems-display-none-expected.png:
  • platform/efl/svg/text/exs-display-none-expected.png:
  • platform/efl/svg/text/modify-text-node-in-tspan-expected.png:
  • platform/efl/svg/text/remove-text-node-from-tspan-expected.png:
  • platform/efl/svg/text/remove-tspan-from-text-expected.png:
  • platform/efl/svg/text/text-rescale-expected.png:
  • platform/efl/svg/text/text-text-05-t-expected.png:
  • platform/efl/svg/text/text-viewbox-rescale-expected.png:
  • platform/efl/svg/text/tspan-dynamic-positioning-expected.png:
  • platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/efl/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png:
  • platform/efl/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/efl/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png:
  • platform/efl/svg/zoom/text/absolute-sized-document-scrollbars-expected.png:
  • platform/efl/svg/zoom/text/relative-sized-document-scrollbars-expected.png:
  • platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/efl/svg/zoom/text/zoom-foreignObject-expected.png:
3:50 PM Changeset in webkit [132151] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

[V8] We should call the faster v8::Integer::New APIs
https://bugs.webkit.org/show_bug.cgi?id=100016

Reviewed by Eric Seidel.

In working to remove the integer cache, I added some faster APIs for
creating v8::Integers. These APIs are faster than the old APIs, but not
quite fast enough to replace the integer cache. We should still use
them when we miss the integer cache.

I've also included a small refactoring to V8PerIsolateData to make it
clearer when we're calling v8::Isolate::GetCurrent().

  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

  • bindings/v8/V8Binding.h:

(WebCore::v8ExternalString):
(WebCore::v8Integer):
(WebCore::v8UnsignedInteger):

  • bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::current):
(WebCore::V8PerIsolateData::from):

  • bindings/v8/V8ValueCache.cpp:

(WebCore::StringCache::v8ExternalStringSlow):
(WebCore::IntegerCache::createSmallIntegers):

  • bindings/v8/V8ValueCache.h:

(WebCore::IntegerCache::v8Integer):
(WebCore::IntegerCache::v8UnsignedInteger):
(IntegerCache):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

3:46 PM Changeset in webkit [132150] by rakuco@webkit.org
  • 67 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 10.

  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
3:40 PM Changeset in webkit [132149] by jchaffraix@webkit.org
  • 7 edits
    2 adds in trunk

RenderTableCol::computePreferredLogicalWidths and RenderTableCol::layout should never be called
https://bugs.webkit.org/show_bug.cgi?id=99861

Reviewed by Ojan Vafai.

Source/WebCore:

RenderTableCol's computePreferredLogicalWidths and layout's only purpose were to clear the preferred logical
widths dirty / layout flag so that we would properly propagate the information to our containing table. This
led to clunky code where the table layout code had to forcefully call RenderTableCol::computePreferredLogicalWidths
or else we would ignore the next layout hint on the <col> or <colgroup>.

Test: fast/table/col-span-change-relayout.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):
Simplified the code now that we only need to iterate over the sections.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
Removed call to computePreferredLogicalWidths.

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
Forward a layout hint to the table so that we properly recompute the cell's logical withs.

(WebCore::RenderTableCol::computePreferredLogicalWidths):
(WebCore::RenderTableCol::layout):
Change our implementations of those 2 methods to be no-ops, while enforcing that they are
never called.

(WebCore::RenderTableCol::propagateLayoutCueToTable):
New helper function that forward any layout cue to the containing table, this works around
us not clearing the flags which confuses RenderObject markContainingBlocksForLayout and
invalidateContainerPreferredLogicalWidths.

  • rendering/RenderTableCol.h:

Made the function that we are not expected to be called private.

LayoutTests:

Added this test as the code in RenderTableCol::updateFromElement wasn't properly covered.

  • fast/table/col-span-change-relayout-expected.txt: Added.
  • fast/table/col-span-change-relayout.html: Added.
3:37 PM Changeset in webkit [132148] by rakuco@webkit.org
  • 56 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 9.

  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png:
3:36 PM Changeset in webkit [132147] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[User Timing]Integrate with Perforamnce Timeline.
https://bugs.webkit.org/show_bug.cgi?id=91072.

Patch by Pan Deng <pan.deng@intel.com> on 2012-10-22
Reviewed by Tony Gentilcore.

This patch expose user timing entries via performance timeline interface. JavaScriptCore custom binding will be another patch

No new tests, user timing test cases have been landed.

  • page/Performance.cpp:

(WebCore::Performance::Performance):
(WebCore::Performance::webkitGetEntries):
(WebCore::Performance::webkitGetEntriesByType):
(WebCore::Performance::webkitGetEntriesByName):

  • page/PerformanceEntry.h:

(WebCore::PerformanceEntry::startTimeCompareLessThan):
(PerformanceEntry):

  • page/PerformanceEntryList.cpp:

(WebCore::PerformanceEntryList::sort):
(WebCore):

  • page/PerformanceEntryList.h:

(PerformanceEntryList):

  • page/PerformanceUserTiming.cpp:

(WebCore::convertToEntrySequence):
(WebCore):
(WebCore::getEntrySequenceByName):
(WebCore::UserTiming::getMarks):
(WebCore::UserTiming::getMeasures):

  • page/PerformanceUserTiming.h:

(UserTiming):

3:34 PM Changeset in webkit [132146] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Modify obsolete code in User Timing
https://bugs.webkit.org/show_bug.cgi?id=99851

Patch by Pan Deng <pan.deng@intel.com> on 2012-10-22
Reviewed by Tony Gentilcore.

Modify user timing implementation as PlatformString.h, prefix of webkitNow is removed, etc.

No new tests.

  • page/PerformanceUserTiming.cpp:

(WebCore::insertPerformanceEntry):
(WebCore::UserTiming::mark):
(WebCore::UserTiming::measure):

  • page/PerformanceUserTiming.h:
3:28 PM Changeset in webkit [132145] by rakuco@webkit.org
  • 56 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 8.

  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
3:20 PM Changeset in webkit [132144] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, update more Chromium ML expectations.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium/TestExpectations:
3:09 PM Changeset in webkit [132143] by mark.lam@apple.com
  • 23 edits in trunk

Change stack recursion checks to be based on stack availability.
https://bugs.webkit.org/show_bug.cgi?id=99872.

Reviewed by Filip Pizlo and Geoffrey Garen.

Source/JavaScriptCore:

  • Remove m_reentryDepth, ThreadStackType which are now obsolete.
  • Replaced the reentryDepth checks with a StackBounds check.
  • Added the Interpreter::StackPolicy class to compute a reasonable stack capacity requirement given the native stack that the interpreter is executing on at that time.
  • Reserved an amount of JSStack space for the use of error handling and enable its use (using Interpreter::ErrorHandlingMode) when we're about to throw or report an exception.
  • Interpreter::StackPolicy also allows more native stack space to be used when in ErrorHandlingMode. This is needed in the case of native stack overflows.
  • Fixed the parser so that it throws a StackOverflowError instead of a SyntaxError when it encounters a stack overflow.
  • API/JSContextRef.cpp:

(JSContextGroupCreate):
(JSGlobalContextCreateInGroup):

(JSC::Interpreter::ErrorHandlingMode::ErrorHandlingMode):
(JSC):
(JSC::Interpreter::ErrorHandlingMode::~ErrorHandlingMode):
(JSC::Interpreter::StackPolicy::StackPolicy):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

  • interpreter/Interpreter.h:

(JSC):
(Interpreter):
(ErrorHandlingMode):
(StackPolicy):
(JSC::Interpreter::StackPolicy::requiredCapacity):

  • interpreter/JSStack.cpp:

(JSC):
(JSC::JSStack::JSStack):
(JSC::JSStack::growSlowCase):
(JSC::JSStack::enableErrorStackReserve):
(JSC::JSStack::disableErrorStackReserve):

  • interpreter/JSStack.h:

(JSStack):
(JSC::JSStack::reservationEnd):
(JSC):

  • jsc.cpp:

(jscmain):

  • parser/Parser.cpp:

(JSC::::Parser):

  • parser/Parser.h:

(Parser):
(JSC::::parse):

  • runtime/ExceptionHelpers.cpp:

(JSC::throwStackOverflowError):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):
(JSC::JSGlobalData::sharedInstance):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/StringRecursionChecker.h:

(JSC::StringRecursionChecker::performCheck):

  • testRegExp.cpp:

(realMain):

Source/WebCore:

Removed the use of ThreadStackType. Enabled the reserved JSStack space
for error processing before doing work in reportException().

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonJSGlobalData):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):

LayoutTests:

Updated test baseline.

  • fast/js/global-recursion-on-full-stack-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
3:09 PM Changeset in webkit [132142] by andersca@apple.com
  • 25 edits in trunk/Source/WebKit2

Remove MessageReceiverMap::deprecatedAddMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=100012

Reviewed by Andreas Kling.

Get rid of MessageReceiverMap::deprecatedAddMessageReceiver and make callers use addMessageReceiver instead.
Also, remove the message receiver map inside Connection and add a message receiver map to WebProcess instead.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchMessage):

  • Platform/CoreIPC/Connection.h:

(Connection):

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::invalidate):
(CoreIPC::MessageReceiverMap::dispatchMessage):
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):

  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy):

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::WebIconDatabase):

  • UIProcess/WebKeyValueStorageManagerProxy.cpp:

(WebKit::WebKeyValueStorageManagerProxy::WebKeyValueStorageManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::WebResourceCacheManagerProxy):

  • WebProcess/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::AuthenticationManager):

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::WebGeolocationManager):
(WebKit::WebGeolocationManager::registerWebPage):

  • WebProcess/Geolocation/WebGeolocationManager.h:

(WebGeolocationManager):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::addMessageReceiver):
(WebKit):
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebProcess):

3:05 PM Changeset in webkit [132141] by kling@webkit.org
  • 11 edits
    2 adds in trunk

REGRESSION(r131104): Heap-use-after-free in WebCore::Element::attributeChanged
<http://webkit.org/b/99937>

Reviewed by Anders Carlsson.

Source/WebCore:

Setting the "type" attribute on an HTMLInputElement that has no "value" attribute set will cause the
input type changing mechanism to write a value attribute onto the element. This happens in
HTMLInputElement::updateType(), below parseAttribute().

It's done via Element::setAttribute(), so we end up re-entering Element::setAttributeInternal()
where the 'existingAttribute' pointer may now be invalid if adding the "value" attribute caused
a reallocation in the ElementAttributeData's underlying Vector<Attribute>.

To make it harder to introduce this kind of bug in the future, I changed almost all functions that take
a "const Attribute&" to take a QualifiedName/AtomicString couple instead (the idea being that the
fewer references into the attribute store we have, the better.)

Test: fast/html/input-type-change-crash.html

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):
(WebCore::Element::attributeChanged):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::addAttributeInternal):
(WebCore::Element::didAddAttribute):
(WebCore::Element::didModifyAttribute):
(WebCore::Element::didRemoveAttribute):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::cloneDataFrom):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

  • dom/StyledElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged):

  • svg/SVGElement.h:

(SVGElement):

LayoutTests:

  • fast/html/input-type-change-crash-expected.txt: Added.
  • fast/html/input-type-change-crash.html: Added.
2:53 PM Changeset in webkit [132140] by jsbell@chromium.org
  • 7 edits in trunk

IndexedDB: Bounds check for IDBCursor.advance() incorrect
https://bugs.webkit.org/show_bug.cgi?id=100014

Reviewed by Tony Chang.

Source/WebCore:

Fix introduced by trac.webkit.org/changeset/131658 restricted cursor.advance()'s argument
as [EnforceRange] unsigned long long, but it's typed as [EnforceRange] unsigned long; the
useless comparison was caught by a clang check.

In lieu of webkit.org/b/96798 make it long long and correct the range check.

Test: storage/indexeddb/cursor-advance.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursor.idl:

LayoutTests:

Assert that advance(232) throws and advance(232-1) does not, per WebIDL.

  • storage/indexeddb/cursor-advance-expected.txt:
  • storage/indexeddb/resources/cursor-advance.js:

(testBadAdvance.advanceBadly):
(testBadAdvance):
(testEdges.request.onsuccess):
(testEdges):

2:49 PM Changeset in webkit [132139] by tony@chromium.org
  • 2 edits in trunk/Tools

[chromium] Add Mac 10.7 Debug bot since it's on the waterfall
https://bugs.webkit.org/show_bug.cgi?id=100028

Reviewed by Eric Seidel.

garden-o-matic can't baseline without this entry.

  • Scripts/webkitpy/layout_tests/port/builders.py:
2:38 PM Changeset in webkit [132138] by jochen@chromium.org
  • 25 edits
    2 copies
    2 moves in trunk/Tools

[chromium] introduce WebTask to the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=99964

Reviewed by Adam Barth.

I'm also removing the dependency on webkit_support, and instead go
through the WebTestDelegate interface.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:

(DRTDevToolsAgent::taskList):

  • DumpRenderTree/chromium/DRTDevToolsClient.cpp:
  • DumpRenderTree/chromium/DRTDevToolsClient.h:

(DRTDevToolsClient::taskList):

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(InvokeCallbackTask::InvokeCallbackTask):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner::taskList):
(DRTTestRunner::WorkQueue::taskList):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(StringDataTask::StringDataTask):
(CharPtrDataTask::CharPtrDataTask):
(DataChannelReadyStateTask::DataChannelReadyStateTask):
(RTCPeerConnectionReadyStateTask::RTCPeerConnectionReadyStateTask):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::taskList):

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(MockWebSpeechInputController::SpeechTask::SpeechTask):

  • DumpRenderTree/chromium/MockWebSpeechInputController.h:

(MockWebSpeechInputController::taskList):
(MockWebSpeechInputController):

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
  • DumpRenderTree/chromium/MockWebSpeechRecognizer.h:

(MockWebSpeechRecognizer::taskList):
(MockWebSpeechRecognizer):
(MockWebSpeechRecognizer::StepTask::StepTask):

  • DumpRenderTree/chromium/Task.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/Task.cpp.

(WebTestRunner):
(WebTestRunner::invokeTask):
(TaskWrapper):
(WebTestRunner::TaskWrapper::TaskWrapper):
(WebTestRunner::TaskWrapper::~TaskWrapper):
(WebTestRunner::TaskWrapper::Run):
(postTask):
(postDelayedTask):

  • DumpRenderTree/chromium/Task.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTask.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/Task.h.

(WebTestRunner):
(WebTask):
(WebTaskList):
(WebMethodTask):
(WebTestRunner::WebMethodTask::WebMethodTask):
(WebTestRunner::WebMethodTask::~WebMethodTask):
(WebTestRunner::WebMethodTask::run):
(WebTestRunner::WebMethodTask::cancel):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner):
(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::scheduleAsynchronousClick):
(WebTestRunner::KeyDownTask::KeyDownTask):
(WebTestRunner::EventSender::scheduleAsynchronousKeyDown):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebTestRunner::EventSender::taskList):
(EventSender):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(WebTestRunner):
(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
  • DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/Task.cpp.

(WebTestRunner):
(WebTestRunner::WebTask::WebTask):
(WebTestRunner::WebTask::~WebTask):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::postTask):
(WebTestRunner):
(WebTestRunner::WebTestInterfaces::Internal::postDelayedTask):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp:

(UserMediaRequestTask::UserMediaRequestTask):

  • DumpRenderTree/chromium/WebUserMediaClientMock.h:

(WebUserMediaClientMock::taskList):
(WebUserMediaClientMock):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::postTask):
(WebViewHost::postDelayedTask):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):
(WebViewHost::taskList):
(WebViewHost::HostMethodTask::HostMethodTask):

2:38 PM Changeset in webkit [132137] by rakuco@webkit.org
  • 76 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 7.

  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
2:32 PM Changeset in webkit [132136] by tony@chromium.org
  • 14 edits in trunk

WebKit does not support 'flex-wrap: nowrap'
https://bugs.webkit.org/show_bug.cgi?id=99924

Reviewed by Ojan Vafai.

Source/WebCore:

The spec changed back from using none to nowrap for the single-line
flexbox case.
http://dev.w3.org/csswg/css3-flexbox/#flex-wrap-property

No new tests, covered by css3/flexbox/css-properties.html and others.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):

  • css/CSSValueKeywords.in:
  • rendering/RenderBox.cpp:

(WebCore::isStretchingColumnFlexItem):
(WebCore::RenderBox::sizesLogicalWidthToFitContent):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::isMultiline):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Update expectations (find and replace none with nowrap).

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
2:15 PM Changeset in webkit [132135] by eae@chromium.org
  • 200 edits
    30 adds
    103 deletes in trunk/LayoutTests

Unreviewed chromium windows gardening.

  • platform/chromium-linux/compositing/shadows/shadow-drawing-expected.txt: Removed.
  • platform/chromium-linux/css1/text_properties/vertical_align-expected.txt: Removed.
  • platform/chromium-linux/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt: Removed.
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt: Removed.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
  • platform/chromium-linux/fast/css/acid2-expected.txt: Removed.
  • platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/007-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/placeholder-position-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-child-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-child-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-details-child-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-details-child-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-child-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-add-summary-child-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-marker-style-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-nested-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-nested-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-no-summary1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-no-summary2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-no-summary3-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-no-summary4-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open-javascript-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open3-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open4-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open5-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-open6-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-position-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-child-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-child-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.txt: Removed.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.txt: Removed.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.txt: Removed.
  • platform/chromium-linux/fast/inline/002-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/chromium-linux/fast/writing-mode/fieldsets-expected.txt: Removed.
  • platform/chromium-linux/http/tests/misc/acid2-expected.txt: Removed.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.txt: Removed.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows: Removed.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.txt: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.txt: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug30692-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-2-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Removed.
  • platform/chromium-linux/transforms/svg-vs-css-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/css/acid2-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/acid2-pixel-expected.png: Added.
  • platform/chromium-mac-lion/fast/inline/002-expected.png: Added.
  • platform/chromium-mac-lion/fast/multicol: Added.
  • platform/chromium-mac-lion/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
  • platform/chromium-mac-lion/http/tests/misc: Added.
  • platform/chromium-mac-lion/http/tests/misc/acid2-expected.png: Added.
  • platform/chromium-mac-lion/http/tests/misc/acid2-pixel-expected.png: Added.
  • platform/chromium-mac-lion/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/chromium-mac-lion/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug14323-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug43854-2-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug4427-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug6404-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug1647-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug56024-expected.png: Added.
  • platform/chromium-mac-lion/transforms: Added.
  • platform/chromium-mac-lion/transforms/svg-vs-css-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/acid2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/acid2-pixel-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Removed.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid2-pixel-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-clip-path-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-expected.png: Removed.
  • platform/chromium-mac-snowleopard/transforms/svg-vs-css-expected.png: Removed.
  • platform/chromium-win-xp/fast/inline: Added.
  • platform/chromium-win-xp/fast/inline-block/contenteditable-baseline-expected.txt:
  • platform/chromium-win-xp/fast/inline/vertical-align-text-bottom-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win-xp/http/tests/misc/acid2-pixel-expected.txt: Added.
  • platform/chromium-win-xp/svg/transforms: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Removed.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug14323-expected.txt: Added.
  • platform/chromium-win-xp/tables/mozilla_expected_failures/bugs: Added.
  • platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug1647-expected.txt: Added.
  • platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug56024-expected.txt: Added.
  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-win/css1/text_properties/vertical_align-expected.png:
  • platform/chromium-win/css1/text_properties/vertical_align-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-win/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
  • platform/chromium-win/fast/css/acid2-expected.txt:
  • platform/chromium-win/fast/css/acid2-pixel-expected.txt:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-win/fast/forms/007-expected.png:
  • platform/chromium-win/fast/forms/007-expected.txt:
  • platform/chromium-win/fast/forms/basic-buttons-expected.png:
  • platform/chromium-win/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/html/details-add-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-marker-style-expected.png:
  • platform/chromium-win/fast/html/details-marker-style-expected.txt:
  • platform/chromium-win/fast/html/details-nested-1-expected.png:
  • platform/chromium-win/fast/html/details-nested-1-expected.txt:
  • platform/chromium-win/fast/html/details-nested-2-expected.png:
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary1-expected.png:
  • platform/chromium-win/fast/html/details-no-summary1-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary2-expected.png:
  • platform/chromium-win/fast/html/details-no-summary2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary3-expected.png:
  • platform/chromium-win/fast/html/details-no-summary3-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.png:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.png:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open1-expected.png:
  • platform/chromium-win/fast/html/details-open1-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.png:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open3-expected.png:
  • platform/chromium-win/fast/html/details-open3-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.png:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/html/details-open5-expected.png:
  • platform/chromium-win/fast/html/details-open5-expected.txt:
  • platform/chromium-win/fast/html/details-open6-expected.png:
  • platform/chromium-win/fast/html/details-open6-expected.txt:
  • platform/chromium-win/fast/html/details-position-expected.png:
  • platform/chromium-win/fast/html/details-position-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-win/fast/html/details-replace-text-expected.png:
  • platform/chromium-win/fast/html/details-replace-text-expected.txt:
  • platform/chromium-win/fast/html/details-writing-mode-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.txt:
  • platform/chromium-win/fast/inline-block/contenteditable-baseline-expected.txt:
  • platform/chromium-win/fast/inline/002-expected.txt:
  • platform/chromium-win/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/chromium-win/fast/inline/vertical-align-text-bottom-expected.txt:
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-win/fast/repaint/4774354-expected.png:
  • platform/chromium-win/fast/repaint/4776765-expected.png:
  • platform/chromium-win/fast/repaint/caret-outside-block-expected.png:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win/fast/repaint/selection-rl-expected.png:
  • platform/chromium-win/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-win/fast/writing-mode/fieldsets-expected.txt:
  • platform/chromium-win/http/tests/misc/acid2-expected.txt:
  • platform/chromium-win/http/tests/misc/acid2-pixel-expected.txt:
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/chromium-win/svg/transforms/svg-css-transforms-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1647-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
  • platform/chromium-win/transforms/svg-vs-css-expected.txt:
2:10 PM Changeset in webkit [132134] by tony@chromium.org
  • 2 edits
    1 move
    5 adds in trunk/LayoutTests

[chromium] Unreviewed, Win and Mac baselines for css3/flexbox/flexbox-baseline-margins.html.

  • platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-margins-expected.txt: Added.
  • platform/chromium-win/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
  • platform/chromium-win/css3/flexbox/flexbox-baseline-margins-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css3/flexbox/flexbox-baseline-margins-expected.txt.
  • platform/chromium/TestExpectations:
2:00 PM Changeset in webkit [132133] by rakuco@webkit.org
  • 52 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 6.

  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
1:53 PM Changeset in webkit [132132] by rakuco@webkit.org
  • 41 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 5.

  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
1:45 PM Changeset in webkit [132131] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
1:30 PM Changeset in webkit [132130] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

'image/pjpeg' should be treated as an image by Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=100001

Reviewed by Pavel Feldman.

It's not exactly a "real" MIME type, but it's in use.

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager):

Adding 'image/pjpeg' as an image MIME type.

1:22 PM Changeset in webkit [132129] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r132119.
http://trac.webkit.org/changeset/132119
https://bugs.webkit.org/show_bug.cgi?id=100019

Fails its own test on Mac platforms. (Requested by leviw on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-22

Source/WebCore:

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::sendContextMenuEventForGesture):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

LayoutTests:

  • fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html: Removed.
  • platform/chromium/fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position-expected.txt: Removed.
1:20 PM Changeset in webkit [132128] by eae@chromium.org
  • 130 edits
    9 adds
    59 deletes in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-mac-lion/editing/selection/3690703-2-expected.txt: Removed.
  • platform/chromium-mac-lion/editing/selection/3690703-expected.txt: Removed.
  • platform/chromium-mac-lion/editing/selection/3690719-expected.txt: Removed.
  • platform/chromium-mac-lion/editing/selection/4397952-expected.txt: Removed.
  • platform/chromium-mac-lion/editing/selection/5240265-expected.txt: Removed.
  • platform/chromium-mac-lion/editing/selection/selection-button-text-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/block/float/032-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/block/float/float-avoidance-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/css/continuationCrash-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/css/margin-top-bottom-dynamic-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/css/rtl-ordering-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/001-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/blankbuttons-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/box-shadow-override-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/button-sizes-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/button-style-color-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/button-text-transform-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/control-restrict-line-height-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/file/file-input-direction-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/file/file-input-disabled-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/file/input-file-re-render-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/form-element-geometry-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/formmove3-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/input-appearance-height-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-button-sizes-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/input-value-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/menulist-clip-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/targeted-frame-submission-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/overflow/scrollRevealButton-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/replaced/replaced-breaking-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/replaced/width100percent-button-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/text/textIteratorNilRenderer-expected.txt: Removed.
  • platform/chromium-mac-lion/http/tests/navigation/javascriptlink-frames-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1188-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1318-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug138725-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug18359-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-2-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-3-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-4-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug26178-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug28928-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug33855-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug39209-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug4429-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-1-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-2-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51037-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51727-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug60749-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug7342-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/dom/tableDom-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla/other/move_row-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug1725-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/css/acid2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/acid2-pixel-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid2-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid2-pixel-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/svg-vs-css-expected.png: Added.
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.txt:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.txt:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.txt:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.txt:
  • platform/chromium-mac/editing/selection/5240265-expected.png:
  • platform/chromium-mac/editing/selection/5240265-expected.txt:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.txt:
  • platform/chromium-mac/fast/block/float/032-expected.txt:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.txt:
  • platform/chromium-mac/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac/fast/css/continuationCrash-expected.txt:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/chromium-mac/fast/forms/001-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.txt:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac/fast/forms/button-style-color-expected.txt:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.txt:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.txt:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.txt:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/formmove3-expected.png:
  • platform/chromium-mac/fast/forms/formmove3-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/input-value-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.txt:
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.txt:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/chromium-mac/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.txt:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
1:14 PM Changeset in webkit [132127] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

[CSS Exclusions] Points on the bottom and right edges of an exclusion shape should be classified as "outside"
https://bugs.webkit.org/show_bug.cgi?id=98967

Patch by Hans Muller <hmuller@adobe.com> on 2012-10-22
Reviewed by Dirk Schulze.

Source/WebCore:

Changed the way lines are represented in the ExclusionShapeInsideInfo and ExclusionShape classes
so that they're consistent with the rendering code that depends on them. Lines are now defined
by logicalTop, logicalHeight, instead of logicalTop,logicalBottom. This a clean-up, not a change
in functionality. It's already covered by the existing fast/exclusions LayoutTests.

Test: fast/exclusions/shape-inside/shape-inside-bottom-edge.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::ExclusionPolygon::getExcludedIntervals):
(WebCore::ExclusionPolygon::getIncludedIntervals):

  • rendering/ExclusionPolygon.h:
  • rendering/ExclusionRectangle.cpp:

(WebCore::ExclusionRectangle::getExcludedIntervals):
(WebCore::ExclusionRectangle::getIncludedIntervals):

  • rendering/ExclusionRectangle.h:
  • rendering/ExclusionShape.h:

(LineSegment): Moved the struct fields below the constructor per webkit style.
(ExclusionShape):
(WebCore::ExclusionShape::minYForLogicalLine):
(WebCore::ExclusionShape::maxYForLogicalLine):

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::computeSegmentsForLine):

  • rendering/ExclusionShapeInsideInfo.h:

(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds): Changed the test to not include

lines whose logicalTop is equal to the shape's top+height.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):

LayoutTests:

Verify that a exclusion shape-inside overlaps lines whose top is less than the
shape bounds' top+height but not equal to the shape bounds' top+height.

  • fast/exclusions/shape-inside/shape-inside-bottom-edge-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-bottom-edge.html: Added.
1:11 PM Changeset in webkit [132126] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] ewk_view_color_picker_color_set() is leaking
https://bugs.webkit.org/show_bug.cgi?id=100007

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Fix a leak in ewk_view_color_picker_color_set() by adopting WKStringRef
returned by WKStringCreateWithUTF8CString().

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_color_picker_color_set):

1:11 PM Changeset in webkit [132125] by crogers@google.com
  • 12 edits in trunk

Update some AudioContext create() method names to latest Web Audio spec
https://bugs.webkit.org/show_bug.cgi?id=99888

Reviewed by Adam Barth.

Source/WebCore:

The following AudioContext method names are being changed, with legacy support for the old names:
createGainNode -> createGain
createDelayNode -> createDelay
createJavaScriptNode -> createScriptProcessor

For details:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=18332

Tests changed: webaudio/delaynode.html, webaudio/gain.html, webaudio/javascriptaudionode.html
to test coverage of the new names.

  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createScriptProcessor):
(WebCore::AudioContext::createGain):
(WebCore::AudioContext::createDelay):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioContext.idl:
  • page/FeatureObserver.h:

LayoutTests:

  • webaudio/delaynode-expected.txt:
  • webaudio/delaynode.html:
  • webaudio/gain.html:
  • webaudio/javascriptaudionode-expected.txt:
  • webaudio/javascriptaudionode.html:
1:01 PM Changeset in webkit [132124] by leviw@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening. Baselines following r132112.

  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
12:56 PM Changeset in webkit [132123] by rakuco@webkit.org
  • 41 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 4.

  • platform/efl/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/efl/svg/as-image/animated-svg-as-image-expected.png:
  • platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/efl/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/efl/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
  • platform/efl/svg/as-object/embedded-svg-size-changes-expected.png:
  • platform/efl/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png:
  • platform/efl/svg/as-object/nested-embedded-svg-size-changes-expected.png:
  • platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/efl/svg/carto.net/tabgroup-expected.png:
  • platform/efl/svg/carto.net/window-expected.png:
  • platform/efl/svg/css/shadow-changes-expected.png:
  • platform/efl/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png:
  • platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
  • platform/efl/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png:
  • platform/efl/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
  • platform/efl/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
  • platform/efl/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png:
  • platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png:
12:53 PM Changeset in webkit [132122] by commit-queue@webkit.org
  • 4 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[EFL][WK2] Make the resource load client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=99982

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Create a C++ class for the resource load client and
move the id <-> resource mapping from the Ewk_View
to ResourceLoadClientEfl for better a cleaner
separation.

The resource load client code was also moved out of
UIProcess/API/efl to UIProcess/efl since this is not
part of the WK2 EFL API.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(_ewk_view_initialize):
(ewk_view_wkpage_get):
(ewk_view_resource_load_initiated):
(ewk_view_resource_load_response):
(ewk_view_resource_load_failed):
(ewk_view_resource_load_finished):
(ewk_view_resource_request_sent):
(ewk_view_load_provisional_started):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp: Removed.
  • UIProcess/API/efl/ewk_view_resource_load_client_private.h: Removed.
  • UIProcess/efl/ResourceLoadClientEfl.cpp: Added.

(WebKit):
(WebKit::toResourceLoadClientEfl):
(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):
(WebKit::ResourceLoadClientEfl::didFinishLoadForResource):
(WebKit::ResourceLoadClientEfl::didFailLoadForResource):
(WebKit::ResourceLoadClientEfl::onViewProvisionalLoadStarted):
(WebKit::ResourceLoadClientEfl::ResourceLoadClientEfl):
(WebKit::ResourceLoadClientEfl::~ResourceLoadClientEfl):

  • UIProcess/efl/ResourceLoadClientEfl.h: Added.

(WebKit):
(ResourceLoadClientEfl):
(WebKit::ResourceLoadClientEfl::create):

12:46 PM Changeset in webkit [132121] by eae@chromium.org
  • 452 edits
    132 adds
    25 deletes in trunk/LayoutTests

Unreviewed gardening.

  • css1/text_properties/vertical_align-expected.txt: Added.
  • fast/multicol/table-vertical-align-expected.png: Added.
  • fast/multicol/table-vertical-align-expected.txt: Added.
  • fast/repaint/caret-outside-block-expected.png: Added.
  • http/tests/misc/acid2-expected.png: Added.
  • platform/chromium-linux-x86/fast/inline: Added.
  • platform/chromium-linux-x86/fast/inline-block/contenteditable-baseline-expected.txt:
  • platform/chromium-linux-x86/fast/inline/vertical-align-text-bottom-expected.txt: Added.
  • platform/chromium-linux-x86/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/chromium-linux-x86/http/tests/misc/acid2-pixel-expected.txt: Added.
  • platform/chromium-linux-x86/svg/transforms: Removed.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug14323-expected.txt: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug1647-expected.txt: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug56024-expected.txt: Added.
  • platform/chromium-linux/compositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/chromium-linux/css1/text_properties/vertical_align-expected.png:
  • platform/chromium-linux/css1/text_properties/vertical_align-expected.txt: Added.
  • platform/chromium-linux/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt: Added.
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
  • platform/chromium-linux/fast/css/acid2-expected.txt: Added.
  • platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-linux/fast/forms/007-expected.png:
  • platform/chromium-linux/fast/forms/007-expected.txt: Added.
  • platform/chromium-linux/fast/forms/basic-buttons-expected.png:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-linux/fast/forms/input-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.txt: Added.
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.txt: Added.
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/html/details-add-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-child-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-child-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-details-child-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-details-child-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-child-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-child-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-marker-style-expected.png:
  • platform/chromium-linux/fast/html/details-marker-style-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-nested-1-expected.png:
  • platform/chromium-linux/fast/html/details-nested-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-nested-2-expected.png:
  • platform/chromium-linux/fast/html/details-nested-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-no-summary1-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-no-summary2-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-no-summary3-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary3-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-no-summary4-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary4-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png:
  • platform/chromium-linux/fast/html/details-open-javascript-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open1-expected.png:
  • platform/chromium-linux/fast/html/details-open1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open2-expected.png:
  • platform/chromium-linux/fast/html/details-open2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open3-expected.png:
  • platform/chromium-linux/fast/html/details-open3-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open4-expected.png:
  • platform/chromium-linux/fast/html/details-open4-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open5-expected.png:
  • platform/chromium-linux/fast/html/details-open5-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-open6-expected.png:
  • platform/chromium-linux/fast/html/details-open6-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-position-expected.png:
  • platform/chromium-linux/fast/html/details-position-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-child-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-child-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-linux/fast/html/details-replace-text-expected.png:
  • platform/chromium-linux/fast/html/details-replace-text-expected.txt:
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png:
  • platform/chromium-linux/fast/html/details-writing-mode-expected.txt: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/chromium-linux/fast/inline-block/contenteditable-baseline-expected.txt:
  • platform/chromium-linux/fast/inline/002-expected.txt: Added.
  • platform/chromium-linux/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/chromium-linux/fast/inline/vertical-align-text-bottom-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-linux/fast/repaint/4774354-expected.png:
  • platform/chromium-linux/fast/repaint/4776765-expected.png:
  • platform/chromium-linux/fast/repaint/caret-outside-block-expected.png:
  • platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-linux/fast/repaint/selection-rl-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-linux/fast/writing-mode/fieldsets-expected.txt: Added.
  • platform/chromium-linux/http/tests/misc/acid2-expected.txt: Added.
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.txt: Added.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.txt: Added.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/chromium-linux/svg/transforms/svg-css-transforms-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug30692-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-2-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1647-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1647-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug56024-expected.txt: Added.
  • platform/chromium-linux/transforms/svg-vs-css-expected.txt: Added.
  • platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-mac-lion/fast/forms/007-expected.png:
  • platform/chromium-mac-lion/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac-lion/fast/forms/datalist: Added.
  • platform/chromium-mac-lion/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-lion/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-marker-style-expected.png:
  • platform/chromium-mac-lion/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac-lion/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open3-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open4-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open5-expected.png:
  • platform/chromium-mac-lion/fast/html/details-open6-expected.png:
  • platform/chromium-mac-lion/fast/html/details-position-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac-lion/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac-lion/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac-lion/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac-lion/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-mac-lion/fast/inline: Added.
  • platform/chromium-mac-lion/fast/inline/vertical-align-text-bottom-expected.png: Added.
  • platform/chromium-mac-lion/fast/inline/vertical-align-text-bottom-expected.txt: Added.
  • platform/chromium-mac-lion/fast/repaint: Added.
  • platform/chromium-mac-lion/fast/repaint/4774354-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/4776765-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/caret-outside-block-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/selection-rl-expected.png: Added.
  • platform/chromium-mac-lion/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/007-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/vertical-align-text-bottom-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/4774354-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/4776765-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/caret-outside-block-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-mac/fast/css/acid2-expected.png: Added.
  • platform/chromium-mac/fast/css/acid2-pixel-expected.png:
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium-mac/fast/forms/007-expected.png:
  • platform/chromium-mac/fast/forms/007-expected.txt:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-details-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-details-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-marker-style-expected.png:
  • platform/chromium-mac/fast/html/details-marker-style-expected.txt:
  • platform/chromium-mac/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac/fast/html/details-nested-1-expected.txt:
  • platform/chromium-mac/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac/fast/html/details-nested-2-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary2-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-mac/fast/html/details-open1-expected.png:
  • platform/chromium-mac/fast/html/details-open1-expected.txt:
  • platform/chromium-mac/fast/html/details-open2-expected.png:
  • platform/chromium-mac/fast/html/details-open2-expected.txt:
  • platform/chromium-mac/fast/html/details-open3-expected.png:
  • platform/chromium-mac/fast/html/details-open3-expected.txt:
  • platform/chromium-mac/fast/html/details-open4-expected.png:
  • platform/chromium-mac/fast/html/details-open4-expected.txt:
  • platform/chromium-mac/fast/html/details-open5-expected.png:
  • platform/chromium-mac/fast/html/details-open5-expected.txt:
  • platform/chromium-mac/fast/html/details-open6-expected.png:
  • platform/chromium-mac/fast/html/details-open6-expected.txt:
  • platform/chromium-mac/fast/html/details-position-expected.png:
  • platform/chromium-mac/fast/html/details-position-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-mac/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac/fast/html/details-replace-text-expected.txt:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zoom-expected.txt:
  • platform/chromium-mac/fast/inline/002-expected.png:
  • platform/chromium-mac/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/chromium-mac/fast/inline/vertical-align-text-bottom-expected.txt:
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-mac/fast/repaint/4774354-expected.png:
  • platform/chromium-mac/fast/repaint/4776765-expected.png:
  • platform/chromium-mac/fast/repaint/caret-outside-block-expected.png:
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/chromium-mac/fast/repaint/selection-rl-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.txt:
  • platform/chromium-mac/http/tests/misc/acid2-expected.png: Added.
  • platform/chromium-mac/http/tests/misc/acid2-pixel-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-mac/svg/transforms/svg-css-transforms-clip-path-expected.png:
  • platform/chromium-mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/chromium-mac/svg/transforms/svg-css-transforms-expected.png:
  • platform/chromium-mac/svg/transforms/svg-css-transforms-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug43854-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1647-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/chromium-mac/transforms/svg-vs-css-expected.png:
  • platform/chromium-mac/transforms/svg-vs-css-expected.txt:
  • platform/chromium-win-xp/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug43854-2-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Replaced.
  • platform/chromium/fast/css/acid2-expected.png: Removed.
  • platform/chromium/http/tests/misc/acid2-expected.png: Removed.
  • platform/efl/css1/text_properties/vertical_align-expected.txt: Removed.
  • platform/efl/fast/multicol/table-vertical-align-expected.png: Removed.
  • platform/efl/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/efl/fast/repaint/caret-outside-block-expected.png: Removed.
  • platform/efl/http/tests/misc/acid2-expected.png: Removed.
  • platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
  • platform/efl/svg/transforms/svg-css-transforms-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug43854-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug4427-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug6404-expected.txt: Removed.
  • platform/gtk/css1/text_properties/vertical_align-expected.txt: Removed.
  • platform/gtk/fast/multicol/table-vertical-align-expected.png: Removed.
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/gtk/fast/repaint/caret-outside-block-expected.png: Removed.
  • platform/gtk/http/tests/misc/acid2-expected.png: Removed.
  • platform/gtk/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
  • platform/gtk/svg/transforms/svg-css-transforms-expected.txt: Removed.
12:23 PM Changeset in webkit [132120] by andersca@apple.com
  • 4 edits in trunk

[WK2] Regression(r131990): plugins/npruntime/remove-property.html started failing
https://bugs.webkit.org/show_bug.cgi?id=99977

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Remove int32_t casts - the ArgumentDecoder::decode overload that takes a const int would cause
a temporary to be created which the number was then decoded into.

  • Shared/Plugins/NPIdentifierData.cpp:

(WebKit::NPIdentifierData::encode):
(WebKit::NPIdentifierData::decode):

LayoutTests:

Remove now passing test.

  • platform/efl-wk2/TestExpectations:
12:21 PM Changeset in webkit [132119] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Context menu generated from touch gestures on textareas has
context of the cursor position instead of the position where the event occurs.
https://bugs.webkit.org/show_bug.cgi?id=99520

Patch by Varun Jain <varunjain@chromium.org> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Send a synthetic mouse down event for context menu-summoning-gesture events so
that textareas can correctly set cursors before receiving the context menu event.

Test: fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureTwoFingerTap):
(WebCore):
(WebCore::EventHandler::sendContextMenuEventForGesture):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

Send a synthetic mouse down event for context menu-summoning-gesture events so
that textareas can correctly set cursors before receiving the context menu event.
Also in this change, WebInputEvent::GestureTwoFingerTap now follows the same
code path as WebInputEvent::GestureLongPress, hence fixing this bug for both gestures.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

LayoutTests:

Send a synthetic mouse down event for context menu-summoning-gesture events so that
textareas can correctly set cursors before receiving the context menu event.

  • fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html: Added.
  • platform/chromium/fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position-expected.txt: Added.
12:17 PM Changeset in webkit [132118] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

TextureMapperSurfaceBackingStore should check if GraphicsSurface is valid.
https://bugs.webkit.org/show_bug.cgi?id=100002

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):

Check if a surface has been created before accessing the pointer.

(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):

Check if m_graphicsSurface is a valid pointer before dereferencing it.

12:11 PM Changeset in webkit [132117] by eae@chromium.org
  • 133 edits
    80 adds
    1 delete in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-mac-lion/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690703-2-expected.txt: Added.
  • platform/chromium-mac-lion/editing/selection/3690703-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690703-expected.txt: Added.
  • platform/chromium-mac-lion/editing/selection/3690719-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690719-expected.txt: Added.
  • platform/chromium-mac-lion/editing/selection/4397952-expected.png:
  • platform/chromium-mac-lion/editing/selection/4397952-expected.txt: Added.
  • platform/chromium-mac-lion/editing/selection/5240265-expected.png:
  • platform/chromium-mac-lion/editing/selection/5240265-expected.txt: Added.
  • platform/chromium-mac-lion/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-lion/editing/selection/selection-button-text-expected.txt: Added.
  • platform/chromium-mac-lion/fast/block/float/032-expected.txt: Added.
  • platform/chromium-mac-lion/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac-lion/fast/block/float/float-avoidance-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac-lion/fast/css/continuationCrash-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac-lion/fast/css/margin-top-bottom-dynamic-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac-lion/fast/css/rtl-ordering-expected.txt: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac-lion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/001-expected.png:
  • platform/chromium-mac-lion/fast/forms/001-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac-lion/fast/forms/blankbuttons-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/box-shadow-override-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/box-shadow-override-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac-lion/fast/forms/button-sizes-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac-lion/fast/forms/button-style-color-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac-lion/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac-lion/fast/forms/button-text-transform-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-lion/fast/forms/control-restrict-line-height-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields: Added.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac-lion/fast/forms/file/file-input-direction-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac-lion/fast/forms/file/file-input-disabled-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac-lion/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac-lion/fast/forms/file/input-file-re-render-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-lion/fast/forms/form-element-geometry-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/formmove3-expected.png:
  • platform/chromium-mac-lion/fast/forms/formmove3-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac-lion/fast/forms/input-button-sizes-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/input-value-expected.png:
  • platform/chromium-mac-lion/fast/forms/input-value-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-lion/fast/forms/menulist-clip-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac-lion/fast/forms/targeted-frame-submission-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields: Added.
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac-lion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac-lion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Added.
  • platform/chromium-mac-lion/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac-lion/fast/overflow/scrollRevealButton-expected.txt: Added.
  • platform/chromium-mac-lion/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-lion/fast/replaced/replaced-breaking-expected.txt: Added.
  • platform/chromium-mac-lion/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac-lion/fast/replaced/width100percent-button-expected.txt: Added.
  • platform/chromium-mac-lion/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-mac-lion/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac-lion/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-lion/fast/text/textIteratorNilRenderer-expected.txt: Added.
  • platform/chromium-mac-lion/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-lion/http/tests/navigation/javascriptlink-frames-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1188-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1318-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug138725-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug18359-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-4-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug26178-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug28928-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug33855-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug39209-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug4429-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-1-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-2-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51037-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51727-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug60749-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug7342-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/dom/tableDom-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/other/move_row-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug1725-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5240265-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.png: Removed.
11:58 AM Changeset in webkit [132116] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

r131955 is has improper function call in LinkHashChromium.cpp
https://bugs.webkit.org/show_bug.cgi?id=100008

Reviewed by Alexey Proskuryakov.

Followup fix to r131955 for chromium platform. Added call to
(const UChar*, unsigned) version of visitedLinkHash from String& version.

  • platform/chromium/LinkHashChromium.cpp:

(WebCore::visitedLinkHash):

11:52 AM Changeset in webkit [132115] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

webkitsourceopen event doesn't always fire
https://bugs.webkit.org/show_bug.cgi?id=99868

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-10-22
Reviewed by Adam Barth.

Source/WebCore:

Changed MediaSource to derive from ActiveDOMObject so that event listeners
will still fire even if all references to the object go out of scope.

Test: http/tests/media/media-source/video-media-source-garbage-collection-before-sourceopen.html

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::create):
(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::scriptExecutionContext):
(WebCore):
(WebCore::MediaSource::hasPendingActivity):
(WebCore::MediaSource::stop): Clears m_player & m_asyncEventQueue so they don't indicate pending activity anymore.

  • Modules/mediasource/MediaSource.h:

(MediaSource):

  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::registerMediaSourceURL): Added setPendingActivity() call so the MediaSource object stays active while in the registry.
(WebCore::MediaSourceRegistry::unregisterMediaSourceURL): Added unsetPendingActivity() call so the MediaSource object can become inactive after being removed from the registry.

LayoutTests:

Added a test that verifies the webkitsourceopen event still fires
even if the MediaSource variable goes out of scope and garbage
collection occurs.

  • http/tests/media/media-source/video-media-source-garbage-collection-before-sourceopen-expected.txt: Added.
  • http/tests/media/media-source/video-media-source-garbage-collection-before-sourceopen.html: Added.
11:50 AM Changeset in webkit [132114] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

[V8] Vastly simplify V8GCController's NodeVisitor
https://bugs.webkit.org/show_bug.cgi?id=99884

Reviewed by Kentaro Hara.

PerformanceTests:

Adds some performance tests for the garbage collector.

  • Bindings/gc-forest.html: Added.
  • Bindings/gc-mini-tree.html: Added.
  • Bindings/gc-tree.html: Added.

Source/WebCore:

NodeVisitor was vastly more complicated than necessary.

This patch improve performance on these new gc benchmarks:

gc-forest: 1.14% better
gc-mini-tree: 5.09% better
gc-tree: 4.60% better

  • bindings/v8/V8GCController.cpp:

(WebCore::ObjectVisitor::visitDOMWrapper):
(WebCore::addImplicitReferencesForNodeWithEventListeners):
(WebCore::rootForGC):
(WebCore::NodeVisitor::visitDOMWrapper):
(WebCore::NodeVisitor::applyGrouping):
(NodeVisitor):

11:40 AM Changeset in webkit [132113] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Roll Chromium DEPS to get new version of V8
https://bugs.webkit.org/show_bug.cgi?id=100015

Unreviewed.

  • DEPS:
    • Bigger is better.
11:38 AM Changeset in webkit [132112] by eae@chromium.org
  • 51 edits
    2 adds in trunk

Source/WebCore: Change baselinePosition and maxAscent/maxDescent to int
https://bugs.webkit.org/show_bug.cgi?id=99767

Reviewed by Levi Weintraub.

Currently baselinePostion, maxAscent and maxDescent are
LayoutUnits while ascent, descent and m_lineHeight are ints.
This can lead to subtle alignment and rounding problems.

Change baselinePosition and maxAscent/maxDescent to int to avoid
these issues.

Test: fast/sub-pixel/replaced-element-baseline.html

  • editing/FrameSelection.cpp:

(WebCore::repaintRectForCaret):
Inflate Y dimension just like we do for X to ensure that the
repaint rect fully contains the caret.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::baselinePosition):

  • rendering/InlineBox.h:

(InlineBox):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
Change maxAscent/maxDescent to int to match ascent/descent.

  • rendering/InlineFlowBox.h:

(InlineFlowBox):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::baselinePosition):

  • rendering/InlineTextBox.h:

(InlineTextBox):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::baselinePosition):

  • rendering/RenderBox.h:

(WebCore::RenderBox::firstLineBoxBaseline):
(WebCore::RenderBox::lastLineBoxBaseline):
(RenderBox):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::baselinePosition):
(WebCore::RenderFlexibleBox::firstLineBoxBaseline):

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::baselinePosition):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::baselinePosition):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::baselinePosition):

  • rendering/RenderListMarker.h:

(RenderListMarker):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::baselinePosition):

  • rendering/RenderSlider.h:

(RenderSlider):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::baselinePosition):
(WebCore::RenderTable::lastLineBoxBaseline):
(WebCore::RenderTable::firstLineBoxBaseline):

  • rendering/RenderTable.h:

(RenderTable):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstLineBoxBaseline):

  • rendering/RenderTableSection.h:

(RenderTableSection):

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::baselinePosition):

  • rendering/RenderTextControlMultiLine.h:

(RenderTextControlMultiLine):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::baselinePosition):

  • rendering/RenderTheme.h:

(RenderTheme):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::baselinePosition):

  • rendering/RenderThemeSafari.h:

(RenderThemeSafari):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):

  • rendering/RootInlineBox.h:

(RootInlineBox):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::baselinePosition):
(WebCore::RenderMathMLTable::firstLineBoxBaseline):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):
(RenderMathMLTable):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::firstLineBoxBaseline):

  • rendering/mathml/RenderMathMLFraction.h:

(RenderMathMLFraction):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::firstLineBoxBaseline):

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::firstLineBoxBaseline):

  • rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

LayoutTests: Unreviewed, further Apple Mac baselines for shadow DOM changes to RenderSlider.

Patch by Jer Noble <jer.noble@apple.com> on 2012-10-22

  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/media/controls-without-preload-expected.txt:
11:16 AM Changeset in webkit [132111] by jer.noble@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed, further Apple Mac baselines for shadow DOM changes to RenderSlider.

  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/media/controls-without-preload-expected.txt:
11:09 AM Changeset in webkit [132110] by inferno@chromium.org
  • 5 edits
    5 copies in branches/chromium/1271

Merge 130777 - Prevent animation when CSS attributeType is invalid.
BUG=143648

11:07 AM Changeset in webkit [132109] by inferno@chromium.org
  • 6 edits in branches/chromium/1271/Source/WebCore/svg

Merge 129670 - Refactor SMILTimeContainer to maintain animation information instead of recalculating it every frame
BUG=143648
Review URL: https://codereview.chromium.org/11229037

11:06 AM Changeset in webkit [132108] by ojan@chromium.org
  • 3 edits in trunk/Tools

Update flakiness dashboard to match the state of the builders.

  • TestResultServer/static-dashboards/builders.js:

(isChromiumDepsGTestRunner):
Broaden the filter since Chromium naming scheme is not consistent.
(loadBuildersList):
The main Chromium master now only runs builders, no tests.

  • TestResultServer/static-dashboards/dashboard_base.js:

Remove test suites that no longer run on any of these masters.

11:03 AM Changeset in webkit [132107] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.10.1

Tag the WebKitGTK+ 1.10.1 release

10:48 AM Changeset in webkit [132106] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, marking fast/sub-pixel/file-upload-control-at-fractional-offset.html as failing on LION for now.

  • platform/chromium/TestExpectations:
10:46 AM Changeset in webkit [132105] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

Modify LayoutState ASSERTS to support SATURATED_LAYOUT_ARITHMETIC
https://bugs.webkit.org/show_bug.cgi?id=98692

Reviewed by Dan Bernstein.

We currently overflow/wrap when computing the delta in
RenderBlock::setLogicalTopForChild in cases where we have an
element with a width or height exceeding maxLayoutUnit. When
the delta is later added back in RenderBlock::layoutBlockChild
the number wraps again getting us back to the correct value.

With SATURATED_LAYOUT_ARITHMETIC enabled the values no longer
wraps, which seems like the correct thing to do however this
causes the compare to fail for obvious reasons. By accounting
for this we can keep the asserts (which have proven very
helpful) even when SATURATED_LAYOUT_ARITHMETIC is turned on.

No new tests, covered by existing tests.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

  • rendering/RenderView.h:

(WebCore::RenderView::addLayoutDelta):
(RenderView):
(WebCore::RenderView::layoutDeltaMatches):

10:45 AM Changeset in webkit [132104] by tony@chromium.org
  • 16 edits
    3 adds in trunk

Fix some baseline flexbox alignment
https://bugs.webkit.org/show_bug.cgi?id=99879

Reviewed by Ojan Vafai.

Source/WebCore:

Fix a bug where we weren't handling margin properly on inline-flexbox.
Fix a bug where we weren't getting the edge of the content box properly when synthesizing
a baseline.

Test: css3/flexbox/flexbox-baseline-margins.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::inlineBlockBaseline): Add a new method that is used when calculating an inline-block's
baseline. Previously we would use lastLineBoxBaseline.
(WebCore::RenderBlock::lastLineBoxBaseline): Pass in direction and when searching children, use inlineBlockBaseline.

  • rendering/RenderBlock.h:

(RenderBlock): Make lastLineBoxBaseline non-virtual.

  • rendering/RenderBox.h:

(WebCore::RenderBox::inlineBlockBaseline): Replace lastLineBoxBaseline with inlineBlockBaseline.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::synthesizedBaselineFromContentBox): Helper method for getting the baseline from the content box.
(WebCore::RenderFlexibleBox::baselinePosition): Always include the margin. This fixes the inline-flexbox case.
(WebCore::RenderFlexibleBox::firstLineBoxBaseline): Fix a case where we didn't synthesize a baseline. Returning -1 means there is no baseline, but we can
synthesize a baseline if we have a flexitem without text.
(WebCore::RenderFlexibleBox::inlineBlockBaseline):

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderTable.cpp: Replace lastLineBoxBaseline with inlineBlockBaseline.

(WebCore::RenderTable::inlineBlockBaseline): Try to make comment more direct.

  • rendering/RenderTable.h:

(RenderTable): Replace lastLineBoxBaseline with inlineBlockBaseline.

LayoutTests:

Additional test cases for baseline aligning flexbox.

  • css3/flexbox/flexbox-baseline-margins.html: Added.
  • css3/flexbox/resources/flexbox.css:

(.flex-one): New cross browser value.

  • platform/chromium-linux/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-margins-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
10:43 AM Changeset in webkit [132103] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating skipped tests that moved.

  • platform/win/TestExpectations:
10:42 AM Changeset in webkit [132102] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed Chromium build fix following r132074.

  • WebCore.gypi:
10:39 AM Changeset in webkit [132101] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.10

Update configure.ac and the NEWS in preparation for the 1.10.1 release.

.:

  • configure.ac: Update the version.

Source/WebKit/gtk:

  • NEWS: Update the NEWS file.
10:39 AM Changeset in webkit [132100] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.10/LayoutTests/platform/gtk

Update baselines to the point where all tests are passing

10:39 AM Changeset in webkit [132099] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge 131076 - accelerated compositing does not work with ati driver
https://bugs.webkit.org/show_bug.cgi?id=97472

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-11
Reviewed by Martin Robinson.

Create m_parentWindow at positive position. Otherwise, parts of it are
not displayed on ati drivers.

Covered by existing tests.

  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):

10:39 AM Changeset in webkit [132098] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk

Merge 130838 - [GTK] Plugins don't display
https://bugs.webkit.org/show_bug.cgi?id=98789

Patch by Daniel Drake <dsd@laptop.org> on 2012-10-09
Reviewed by Martin Robinson.

Fix a recent regression where plugin content was not being displayed.
Bringing webkit_web_view_size_allocate in line with the WebKit2
equivalent solves the issue.

  • webkit/webkitwebview.cpp:

(resizeWebViewFromAllocation): pass allocation request to children
even when the allocation size does not change.
(webkit_web_view_size_allocate): don't bail too early if the
allocation size does not change.

10:39 AM Changeset in webkit [132097] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk

Merge 130108 - [Gtk] crash when accelerated composition is turned off
https://bugs.webkit.org/show_bug.cgi?id=98099

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-01
Reviewed by Martin Robinson.

frame->view()->updateLayoutAndStyleIfNeededRecursive() may reset root
compositing layer in flushAndRenderLayers. So, we check if compositing
is enabled afterwards, and return if it is not.

This bug is handled by LayoutTests/compositing/toggle-compositing.html

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::flushAndRenderLayers):

10:39 AM Changeset in webkit [132096] by Martin Robinson
  • 19 edits in releases/WebKitGTK/webkit-1.10

Merge 129651 - [GTK] Use XDamage to simplify RedirectedXCompositeWindow
https://bugs.webkit.org/show_bug.cgi?id=97267

Reviewed by Alejandro G. Castro.

Use XDamage to queue redraws of the widget when redirecting accelerated compositing
to an offscreen window. This allows removing a finicky timer-based approach, improves
performance, and allows simplifying things greatly.

.:

  • configure.ac: Add support for finding XDamage via pkg-config.

Source/WebCore:

No new tests. This is covered by existing tests.

  • GNUmakefile.am: Add the XDamage CFLAGS in the appropriate place.
  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::getWindowHashMap): Added.
(WebCore::filterXDamageEvent): Added.
(WebCore::supportsXDamageAndXComposite): Added.
(WebCore::RedirectedXCompositeWindow::create): Fail to create the window if
the XServer doesn't support XDamage and XComposite.
(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow): Add XDamage support and
remove the m_usable size distinction. Add the window the window HashMap now.
(WebCore::RedirectedXCompositeWindow::~RedirectedXCompositeWindow): Remove the window
from the window HashMap.
(WebCore::RedirectedXCompositeWindow::resize): Now just immediately update the size.
(WebCore::RedirectedXCompositeWindow::callDamageNotifyCallback): Added.

  • platform/gtk/RedirectedXCompositeWindow.h:

(WebCore::RedirectedXCompositeWindow::setDamageNotifyCallback): Added.

Source/WebKit/gtk:

  • GNUmakefile.am: Add the XDamage CFLAGS and LIBS.
  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext): Change the signature of compositeLayersToContext
to accept an enum that explains the composite purpose.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::redirectedWindowDamagedCallback): Added.
(WebKit::AcceleratedCompositingContext::initialize): Handle the situation where
the RedirectedXCompositeWindow returns a null pointer.
(WebKit::AcceleratedCompositingContext::enabled): Ditto.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): Remove the code handling
the usable size of the RedirectedXCompositeWindow. The usable size is now always equal
to the size.
(WebKit::AcceleratedCompositingContext::compositeLayersToContext): When drawing for a
resize, first clear the entire context. Remove the double swap-buffer, as it's no
longer necessary.
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer): Handle the case that
the redirected window is null.
(WebKit::AcceleratedCompositingContext::resizeRootLayer): Instead of doing another
immediate layer flush, just recomposite the current layer state and schedule a new
flush. This should make resizing faster.
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers): We no longer need to
queue a redraw, unless we want to force one.

Source/WebKit2:

  • GNUmakefile.am: Add the XDamage CFLAGS and LIBS to the appropriate places.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Remove readyToRenderAcceleratedCompositingResults as
it's no longer necessary.
(webkit_web_view_base_init): Handle the situation where the RedirectedXCompositeWindow
is null.
(webkitWebViewRenderAcceleratedCompositingResults): Ditto.
(resizeWebKitWebViewBaseFromAllocation): Ditto.
(webkitWebViewBaseCreateWebPage): Ditto.
(redirectedWindowDamagedCallback): Added.

  • UIProcess/WebPageProxy.h: Remove InvalidateWidget message.
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • UIProcess/gtk/WebPageProxyGtk.cpp: Ditto.
  • WebProcess/WebPage/WebPage.h: Ditto.
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::compositeLayersToContext): No longer need to
trigger the invalidateWindow message.

  • WebProcess/WebPage/gtk/WebPageGtk.cpp: Ditto.
10:38 AM Changeset in webkit [132095] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WTF

Merge 130076 - Another SIGILL in JavaScriptCore on a Geode processor
https://bugs.webkit.org/show_bug.cgi?id=96286

Patch by Daniel Drake <dsd@laptop.org> on 2012-10-01
Reviewed by Filip Pizlo.

Disable LLint for the GTK build where the build target does not
support SSE2 instructions. Restores support for non-SSE2 processors
such as the AMD Geode.

  • wtf/Platform.h:
10:38 AM Changeset in webkit [132094] by Martin Robinson
  • 3 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk

Merge 129537 - [GTK] Webkit 1.8.2 fails to build with MinGW with spellchecking enabled
https://bugs.webkit.org/show_bug.cgi?id=93255

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2012-09-25
Reviewed by Martin Robinson.

Build dies because of invalid cast. Additionaly word "interface" is in use with MinGW compiler.

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString): Use String to avoid unneded casting

  • webkit/webkitspellcheckerenchant.cpp:

(webkit_spell_checker_enchant_spell_checker_interface_init): rename interface -> checkerInterface

10:38 AM Changeset in webkit [132093] by Martin Robinson
  • 6 edits
    1 add in releases/WebKitGTK/webkit-1.10

Merge 129247 - REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=96196

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-21
Reviewed by Martin Robinson.

The "regression" is that a new test was added but the support was missing
in the Gtk port for spin buttons.

Source/WebCore:

No new tests. Instead the new test which had been skipped was unskipped
as part of this fix.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(atkRole): Map SpinButtonRole to ATK_ROLE_SPIN_BUTTON
(getInterfaceMaskFromObject): Add SpinButtonRole to the roles implementing
the AtkValue interface.

Tools:

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::valueDescription): Updated the FIXME comment to
indicate that this cannot be implemented until it is implemented in ATK.
URL of the newly-filed ATK bug included for reference.

LayoutTests:

  • platform/gtk/TestExpectations: Unskip the new test.
  • platform/gtk/accessibility/spinbutton-value-expected.txt: Added.
10:38 AM Changeset in webkit [132092] by Martin Robinson
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 129246 - [GTK] [Stable] Infinite recursion in WebCore::AXObjectCache::getOrCreate
https://bugs.webkit.org/show_bug.cgi?id=96932

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-21
Reviewed by Martin Robinson.

Source/WebCore:

Make the decision based on RenderObjects rather than AccessibilityObjects
to avoid the infinite recursion which occurs when remapAriaRoleDueToParent
gets called.

Test: platform/gtk/accessibility/remapped-aria-crash.html

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

LayoutTests:

Added a new test which replicates the recursion and crash.

  • platform/gtk/accessibility/remapped-aria-crash-expected.txt: Added.
  • platform/gtk/accessibility/remapped-aria-crash.html: Added.
10:32 AM Changeset in webkit [132091] by mario@webkit.org
  • 8 edits in trunk

[GTK] Don't use deprecated AccessibilityObject methods after r99502
https://bugs.webkit.org/show_bug.cgi?id=99985

Reviewed by Chris Fleizach.

Source/WebCore:

Update callers for AccessibilityObject's title() and
accessibilityDescription() so they now use AccessibilityText.

  • accessibility/gtk/WebKitAccessibleUtil.cpp:

(titleTagShouldBeUsedInDescriptionField): Internal helper function.
(accessibilityTitle): New helper function, returns an String with
the title for a AccessibilityObject, using AccessibleText.
(accessibilityDescription): New helper function, returns an String with
the description for a AccessibilityObject, using AccessibleText.

  • accessibility/gtk/WebKitAccessibleUtil.h: Added public

declarations for accessibilityTitle and accessibilityDescription.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetName): Use new helpers for retrieving the title.
(webkitAccessibleGetDescription): Use new helpers for retrieving
the title and description.

  • accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:

(webkitAccessibleImageGetImageDescription): Use new helpers for
retrieving the title.

LayoutTests:

Update test and expectations to reflect the changes in the
accessible title (now it's the localized one) being returned.

  • platform/gtk/accessibility/media-controls-panel-title-expected.txt: Updated.
  • platform/gtk/accessibility/media-controls-panel-title.html: Updated.
10:24 AM Changeset in webkit [132090] by jochen@chromium.org
  • 11 edits in trunk/Tools

[chromium] add a method for printing message to the WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=99960

Reviewed by Adam Barth.

When using the TestRunner library from the content_shell, we can't print
message directly but need to send them to the browser process.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:

(WebTestRunner::AccessibilityController::fallbackCallback):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:

(WebTestRunner::AccessibilityController::setDelegate):
(AccessibilityController):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::dumpFilenameBeingDragged):

  • DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:

(GamepadController::connect):
(GamepadController::disconnect):
(GamepadController::setId):
(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):
(GamepadController::fallbackCallback):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(TestInterfaces::~TestInterfaces):
(TestInterfaces::setDelegate):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::printMessage):
(WebTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didBeginEditing):
(WebViewHost::lastContextMenuData):
(WebViewHost::clearContextMenuData):
(WebViewHost::setEditCommand):
(WebViewHost::clearEditCommand):
(WebViewHost::fillSpellingSuggestionList):
(WebViewHost::setGamepadData):
(WebViewHost::printMessage):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:19 AM Changeset in webkit [132089] by eae@chromium.org
  • 1 edit
    1 add
    9 deletes in trunk/LayoutTests

Convert fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html to ref test
https://bugs.webkit.org/show_bug.cgi?id=99869

Reviewed by Eric Seidel.

fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html is currently a pixel test, convert it to a ref test instead.

  • fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html: Added.
  • platform/chromium-linux/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.
  • platform/chromium-linux/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.
  • platform/chromium-win/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.
  • platform/chromium-win/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.
  • platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.
  • platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.
10:16 AM Changeset in webkit [132088] by caseq@chromium.org
  • 11 edits in trunk

Web Inspector: add timeline instrumentation for scrolling of a layer
https://bugs.webkit.org/show_bug.cgi?id=99461

Reviewed by Pavel Feldman.

Source/WebCore:

  • added timeline instrumentation for scrolling of a layer;
  • added TRACE_EVENT for ScrollableArea::scrollPositionChanged()
  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willScrollLayerImpl):
(WebCore::InspectorInstrumentation::didScrollLayerImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willScrollLayer):
(WebCore):
(WebCore::InspectorInstrumentation::didScrollLayer):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore::InspectorTimelineAgent::willScroll):
(WebCore):
(WebCore::InspectorTimelineAgent::didScroll):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/front-end/TimelineModel.js:
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel._initRecordStyles):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged):

LayoutTests:

  • added Scroll record type;
  • inspector/timeline/timeline-enum-stability-expected.txt:
10:05 AM Changeset in webkit [132087] by commit-queue@webkit.org
  • 4 edits
    1 move in trunk/Source/WebCore

Moved cmdevtools.js to folder cm/

Web Inspector: Move file cmdevtools.css to cm/
https://bugs.webkit.org/show_bug.cgi?id=99956

Patch by Jan Keromnes <janx@linux.com> on 2012-10-22
Reviewed by Pavel Feldman.

The file cmdevtools.js belongs to the CodeMirror editor experiment in cm/.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/cm/cmdevtools.css: Renamed from Source/WebCore/inspector/front-end/cmdevtools.css.

(.CodeMirror):
(.CodeMirror-scroll):
(.cm-highlight):
(@-webkit-keyframes fadeout):
(to):
(.cm-breakpoint):
(.cm-breakpoint-disabled):
(.cm-breakpoint-conditional):
(.cm-execution-line):
(.cm-s-web-inspector-js span.cm-keyword):
(.cm-s-web-inspector-js span.cm-number):
(.cm-s-web-inspector-js span.cm-comment):
(.cm-s-web-inspector-js span.cm-string):
(.cm-s-web-inspector-js span.cm-string-2):
(.cm-s-web-inspector-css span.cm-keyword):
(.cm-s-web-inspector-css span.cm-number):
(.cm-s-web-inspector-css span.cm-comment):
(.cm-s-web-inspector-css span.cm-string):
(.cm-s-web-inspector-css span.cm-string-2):
(.cm-s-web-inspector-css span.cm-link):
(.cm-s-web-inspector-css span.cm-variable):
(.cm-s-web-inspector-html span.cm-meta):
(.cm-s-web-inspector-html span.cm-comment):
(.cm-s-web-inspector-html span.cm-string):
(.cm-s-web-inspector-html span.cm-tag):
(.cm-s-web-inspector-html span.cm-attribute):
(.cm-s-web-inspector-html span.cm-link):
(.webkit-html-message-bubble):
(.webkit-html-warning-message):
(.webkit-html-error-message):
(.webkit-html-message-line):
(.webkit-html-message-line-hover):

9:56 AM Changeset in webkit [132086] by vsevik@chromium.org
  • 6 edits in trunk

Web Inspector: Prepare mappings to moving uiSourceCodes creation out of them to workspace.
https://bugs.webkit.org/show_bug.cgi?id=99997

Reviewed by Pavel Feldman.

Source/WebCore:

Source mappings could now store a link to temporary uiSourceCodes only.
Otherwise it should retrieve uiSourceCodes from workspace by URL.
Original uiSourceCodes are now temporary in CompilerScriptMapping.

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
(WebInspector.CompilerScriptMapping.prototype._reset):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._projectWillReset):

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping):
(_bindUISourceCode):
(_reset):

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
9:55 AM Changeset in webkit [132085] by andersca@apple.com
  • 21 edits
    1 copy
    1 add in trunk/Source/WebKit2

Don't use CStrings for message receiver names and message names
https://bugs.webkit.org/show_bug.cgi?id=99853

Reviewed by Andreas Kling.

Re-land this with a fix to MessageReceiverMap::dispatchSyncMessage to look in the new global message receivers map.

Introduce StringReference which is similar to DataReference except it holds a pointer to + length of a char *
and can be created from a string literal. Use this in place of CString in MessageEncoder/MessageDecoder and
make MessageReceiverMap use a HashMap from StringReferences to MessageReceivers for global message receivers.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::dispatchSyncMessage):

  • Platform/CoreIPC/Connection.h:

(Connection):
(CoreIPC::Connection::deprecatedSendSync):
(CoreIPC::Connection::deprecatedSend):

  • Platform/CoreIPC/MessageDecoder.cpp:

(CoreIPC::MessageDecoder::MessageDecoder):

  • Platform/CoreIPC/MessageDecoder.h:

(CoreIPC::MessageDecoder::messageReceiverName):
(CoreIPC::MessageDecoder::messageName):
(MessageDecoder):

  • Platform/CoreIPC/MessageEncoder.cpp:

(CoreIPC::MessageEncoder::create):
(CoreIPC::MessageEncoder::MessageEncoder):

  • Platform/CoreIPC/MessageEncoder.h:

(CoreIPC):
(MessageEncoder):

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::addMessageReceiver):
(CoreIPC):
(CoreIPC::MessageReceiverMap::dispatchMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • Platform/CoreIPC/StringReference.cpp: Added.

(CoreIPC):
(CoreIPC::StringReference::encode):
(CoreIPC::StringReference::decode):
(CoreIPC::StringReference::Hash::hash):

  • Platform/CoreIPC/StringReference.h: Added.

(CoreIPC):
(StringReference):
(CoreIPC::StringReference::StringReference):
(CoreIPC::StringReference::isEmpty):
(CoreIPC::StringReference::size):
(CoreIPC::StringReference::data):
(CoreIPC::StringReference::operator==):
(Hash):
(CoreIPC::StringReference::Hash::equal):
(WTF):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):

  • Scripts/webkit2/messages.py:

(message_to_struct_declaration):
(forward_declarations_and_headers):
(generate_messages_header):

  • Scripts/webkit2/messages_unittest.py:
  • Shared/CoreIPCSupport/WebContextMessageKinds.h:
  • Target.pri:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::addMessageReceiver):
(WebKit):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::deprecatedSend):
(WebKit::WebProcessProxy::send):

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
9:53 AM Changeset in webkit [132084] by rakuco@webkit.org
  • 8 edits in trunk/Source/WebKit2

Unreviewed, rolling out r132072.
http://trac.webkit.org/changeset/132072
https://bugs.webkit.org/show_bug.cgi?id=100011

Made most of the tests crash on the WK2 bot. (Requested by
rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-22

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::handleDownloadRequest):

  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context):
(Ewk_Context::Ewk_Context):
(ewk_context_ref):
(ewk_context_unref):
(ewk_context_cookie_manager_get):
(ewk_context_favicon_database_get):
(ewk_context_WKContext_get):
(ewk_context_new_from_WKContext):
(ewk_context_download_job_add):
(ewk_context_download_job_get):
(ewk_context_download_job_remove):
(ewk_context_request_manager_get):
(ewk_context_url_scheme_request_received):
(ewk_context_default_get):
(ewk_context_new):
(ewk_context_new_with_injected_bundle_path):
(ewk_context_url_scheme_register):
(ewk_context_vibration_client_callbacks_set):
(ewk_context_history_callbacks_set):
(ewk_context_history_client_get):
(ewk_context_visited_link_add):
(ewk_context_cache_model_set):
(ewk_context_cache_model_get):

  • UIProcess/API/efl/ewk_context_download_client.cpp:

(decideDestinationWithSuggestedFilename):
(didReceiveResponse):
(didCreateDestination):
(didReceiveData):
(didFail):
(didCancel):
(didFinish):
(ewk_context_download_client_attach):

  • UIProcess/API/efl/ewk_context_history_client.cpp:

(getEwkHistoryDelegate):
(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
(populateVisitedLinks):
(ewk_context_history_client_attach):

  • UIProcess/API/efl/ewk_context_private.h:
  • UIProcess/API/efl/ewk_context_request_manager_client.cpp:

(didReceiveURIRequest):
(ewk_context_request_manager_client_attach):

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(Ewk_View_Private_Data::Ewk_View_Private_Data):
(Ewk_View_Private_Data::~Ewk_View_Private_Data):
(_ewk_view_priv_del):
(_ewk_view_initialize):
(ewk_view_base_add):
(ewk_view_add_with_context):
(ewk_view_context_get):
(ewk_view_update_icon):

9:49 AM Changeset in webkit [132083] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove specialized handling for isIndex fields.
https://bugs.webkit.org/show_bug.cgi?id=100004

Reviewed by Rob Buis.

PR 214342.

Remove special handling for isIndex field as the tag
is rewritten.

Reviewed Internally by Yongxin Dai and Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::inputStyle):
(BlackBerry::WebKit::InputHandler::elementType):

9:48 AM Changeset in webkit [132082] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Fixing expectations for fast/dom/gc-acid3.html to pass the linting.

  • platform/gtk/TestExpectations:
9:44 AM Changeset in webkit [132081] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Gstreamer 1.0 not working
https://bugs.webkit.org/show_bug.cgi?id=99852

Patch by Nicolas Dufresne <nicolas.dufresne@collabora.com> on 2012-10-22
Reviewed by Philippe Normand.

There was a series of trivial issue, g_object_is_floating() was called
on type GstCaps (which is not a GObject), webkitGstGetPadCaps() was
returning non-fixed caps and GST_MESSAGE_DURATION has been renamed
to GST_MESSAGE_DURATION_CHANGED.

Most failing test passes now.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(webkitGstGetPadCaps):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

9:30 AM Changeset in webkit [132080] by Darin Adler
  • 2 edits in trunk/Source/WebKit2
  • UIProcess/API/mac/WKView.mm:

(-[WKView view:stringForToolTip:point:userData:]): Fix build. Forgot to save file
before committing.

9:28 AM Changeset in webkit [132079] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r131686): Crash in NSToolTipManager mouseEnteredToolTip
<rdar://problem/12527528> and https://bugs.webkit.org/show_bug.cgi?id=99792

Roll out the tool tip part of r131686 since it still seems to be causing trouble.

  • UIProcess/API/mac/WKView.mm:

(-[WKView view:stringForToolTip:point:userData:]): Added this method back.
(-[WKView _wk_toolTipChangedFrom:to:]): Use self as owner again, eliminating the
separate WKToolTipDelegate object.

9:26 AM Changeset in webkit [132078] by vsevik@chromium.org
  • 13 edits in trunk

Web Inspector: Treat dynamic anonymous scripts as other anonymous and fix anonymous script editing and breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=99989

Reviewed by Pavel Feldman.

Source/WebCore:

Dynamic anonymous scripts are now mapped to anonymous temporary uiSourceCodes.
ResourceScriptMapping now supports two types of temporary uiSourceCodes:

  • original uiSourceCodes represent scripts while main uiSourceCodes are diverged;
  • temporary uiSourceCodes represent scripts for which resources are not yet loaded.
  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.breakpointStorageId):
(WebInspector.BreakpointManager.Storage.prototype._updateBreakpoint):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._hasMergedToVM):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._deleteOriginalUISourceCodeForScripts):
(WebInspector.ResourceScriptMapping.prototype._deleteTemporaryUISourceCodeForScripts):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._createUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateOriginalUISourceCode):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.ResourceScriptMapping.prototype._scriptsForUISourceCode.get if):
(WebInspector.ResourceScriptMapping.prototype._reset):

LayoutTests:

  • http/tests/inspector-enabled/dynamic-scripts-expected.txt:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-scripts-expected.txt:
  • inspector/debugger/live-edit-breakpoints-expected.txt:
  • inspector/debugger/live-edit-breakpoints.html:
  • inspector/debugger/resource-script-mapping-expected.txt:
  • inspector/debugger/resource-script-mapping.html:
9:07 AM Changeset in webkit [132077] by eae@chromium.org
  • 3 edits
    5 deletes in trunk/LayoutTests

Convert fast/sub-pixel/float-containing-block-with-margin.html to text test
https://bugs.webkit.org/show_bug.cgi?id=99866

Reviewed by Eric Seidel.

fast/sub-pixel/float-containing-block-with-margin.html doesn't
need to be a pixel test, convert it to a text one.

  • fast/sub-pixel/float-containing-block-with-margin-expected.txt:
  • fast/sub-pixel/float-containing-block-with-margin.html:
  • platform/chromium-linux/fast/sub-pixel/float-containing-block-with-margin-expected.png: Removed.
  • platform/chromium-mac-lion/fast/sub-pixel: Removed.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/float-containing-block-with-margin-expected.png: Removed.
  • platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png: Removed.
  • platform/chromium-win/fast/sub-pixel/float-containing-block-with-margin-expected.png: Removed.
8:52 AM Changeset in webkit [132076] by commit-queue@webkit.org
  • 13 edits
    4 adds in trunk

[css3-text] Add rendering support for -webkit-text-decoration-style
https://bugs.webkit.org/show_bug.cgi?id=94094

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-10-22
Reviewed by Julien Chaffraix.

Source/WebCore:

This patch implements the "text-decoration-style" property rendering as
specified in CSS3 working draft, with "-webkit-" prefix. The specification can
be found here: http://dev.w3.org/csswg/css3-text/#text-decoration-style

Additionally, Mozilla implementation details can be found here:
https://developer.mozilla.org/en/CSS/text-decoration-style

Tests: fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style.html

fast/css3-text/css3-text-decoration/text-decoration-style.html

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformStrokeStyle):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLine):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::toQPenStyle):
(WebCore::GraphicsContext::drawLine):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::setupPaintForStroking):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::createPen):

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::strokeStyleToWxPenStyle):
Added 'DoubleStroke' and 'WavyStroke' to StrokeStyle enum and updated
platform-specific stroke handling. Some styles requires
platform-specific implementation (handled in bug 92868).

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::textDecorationStyleToStrokeStyle): Added static function that
translates text decoration to stroke styles.
(WebCore::InlineTextBox::paintDecoration): Text decoration style does
not specify a property for line thickness (like border-width does for
border style), so we statically set it to 1 for now. The 'double' style
implementation simply adds a parallel line (depending if it is
underline, overline or line-through) and the space between lines follows
the approach used by border's 'double' style.

  • rendering/InlineTextBox.h:

(InlineTextBox):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

Added text decoration style rendering support to
InlineTextBox::paintDecoration().

LayoutTests:

Added paint and repaint layout tests for CSS3 text-decoration-style
property. Pixel results are not included due to missing platform support
for some decoration styles (handled on bug 93507). These are going
to be added when platform support is complete.

  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-style-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-style.html: Added.
8:36 AM Changeset in webkit [132075] by allan.jensen@digia.com
  • 2 edits in trunk/Tools

I now only watch Selectors instead of all of CSS.

Unreviewed update of watchlist.

  • Scripts/webkitpy/common/config/watchlist:
8:33 AM Changeset in webkit [132074] by allan.jensen@digia.com
  • 2 edits
    1 add
    2 deletes in trunk/Source/WebCore

[Qt] Use the DNS resolve queue
https://bugs.webkit.org/show_bug.cgi?id=99994

Reviewed by Simon Hausmann.

Use the DNS resolve queue, to ensure we can prefetch more than just the first 10 hostname encountered
during parsing. It also ensure each hostname is only appears once in the queue.

  • Target.pri:
  • platform/network/qt/DNSQt.cpp: Added.

(DnsPrefetchHelper):
(WebCore::DnsPrefetchHelper::DnsPrefetchHelper):
(WebCore::DnsPrefetchHelper::lookup):
(WebCore::DnsPrefetchHelper::lookedUp):
(WebCore::prefetchDNS):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):

  • platform/network/qt/DnsPrefetchHelper.cpp: Removed.
  • platform/network/qt/DnsPrefetchHelper.h: Removed.

(DnsPrefetchHelper):

8:03 AM Changeset in webkit [132073] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Memory leak in Ewk_Form_Submission_Request::fieldValue()
https://bugs.webkit.org/show_bug.cgi?id=99993

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Adopt the WKStringRef returned by toCopiedAPI() in
Ewk_Form_Submission_Request::fieldValue() to avoid
a memory leak.

  • UIProcess/API/efl/ewk_form_submission_request.cpp:

(Ewk_Form_Submission_Request::fieldValue):

7:47 AM Changeset in webkit [132072] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] Refactor Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=99594

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Ewk_Context is now encapsulated to a C++ class inherited from WTF::RefCounted.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::handleDownloadRequest):

  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::Ewk_Context):
(Ewk_Context::~Ewk_Context):
(Ewk_Context::create):
(Ewk_Context::defaultContext):
(Ewk_Context::cookieManager):
(Ewk_Context::faviconDatabase):
(Ewk_Context::registerURLScheme):
(Ewk_Context::vibrationProvider):
(Ewk_Context::addVisitedLink):
(Ewk_Context::setCacheModel):
(Ewk_Context::cacheModel):
(ewk_context_ref):
(ewk_context_unref):
(ewk_context_cookie_manager_get):
(ewk_context_favicon_database_get):
(Ewk_Context::wkContext):
(Ewk_Context::addDownloadJob):
(Ewk_Context::downloadJob):
(Ewk_Context::removeDownloadJob):
(Ewk_Context::requestManager):
(Ewk_Context::urlSchemeRequestReceived):
(ewk_context_default_get):
(ewk_context_new):
(ewk_context_new_with_injected_bundle_path):
(ewk_context_url_scheme_register):
(ewk_context_vibration_client_callbacks_set):
(ewk_context_history_callbacks_set):
(ewk_context_visited_link_add):
(ewk_context_cache_model_set):
(ewk_context_cache_model_get):

  • UIProcess/API/efl/ewk_context_download_client.cpp:

(decideDestinationWithSuggestedFilename):
(didReceiveResponse):
(didCreateDestination):
(didReceiveData):
(didFail):
(didCancel):
(didFinish):
(ewk_context_download_client_attach):

  • UIProcess/API/efl/ewk_context_history_client.cpp:

(getEwkHistoryClient):
(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
(populateVisitedLinks):
(ewk_context_history_client_attach):

  • UIProcess/API/efl/ewk_context_private.h:

(Ewk_Context):
(Ewk_Context::create):
(Ewk_Context::historyClient):

  • UIProcess/API/efl/ewk_context_request_manager_client.cpp:

(didReceiveURIRequest):
(ewk_context_request_manager_client_attach):

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(Ewk_View_Private_Data::Ewk_View_Private_Data):
(Ewk_View_Private_Data::~Ewk_View_Private_Data):
(_ewk_view_priv_del):
(_ewk_view_initialize):
(ewk_view_base_add):
(ewk_view_add_with_context):
(ewk_view_context_get):
(ewk_view_update_icon):

7:29 AM Changeset in webkit [132071] by arv@chromium.org
  • 7 edits
    4 adds in trunk

HTMLBaseElement href attribute binding returns wrong URL
https://bugs.webkit.org/show_bug.cgi?id=98184

Reviewed by Ojan Vafai.

Resolve the href attribute binding relative to the document URL instead of resolving it to the
base element itself. If there is no href attribute this should return the fallback base URL.

http://www.whatwg.org/specs/web-apps/current-work/multipage/semantics.html#the-base-element

Source/WebCore:

Tests: fast/dom/HTMLAnchorElement/set-href-attribute-rebase.html

fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html

  • html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::href): Don't use completeURL. Resolve href based on document's URL instead
of the generic [Reflect, URL] binding.
(WebCore::HTMLBaseElement::setHref): Just sets the attribute.

  • html/HTMLBaseElement.h:
  • html/HTMLBaseElement.idl: We can no longer use [Reflect, URL]

LayoutTests:

  • fast/dom/HTMLAnchorElement/set-href-attribute-rebase-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-rebase.html: Added.
  • fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document-expected.txt: Added.
  • fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html: Added.
  • fast/dom/element-attribute-js-null-expected.txt:
  • fast/dom/element-attribute-js-null.html:
7:14 AM Changeset in webkit [132070] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Revisions should not be restored and persisted for anonymous uiSourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=99991

Reviewed by Alexander Pavlov.

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

7:10 AM Changeset in webkit [132069] by fmalita@chromium.org
  • 3 edits
    2 adds in trunk

Incorrect embedded SVG image sizing on first load
https://bugs.webkit.org/show_bug.cgi?id=99489

Reviewed by Nikolas Zimmermann.

Source/WebCore:

RenderSVGImage::updateImageViewport() must be called after the image loader is finished,
to ensure that a SVGImageCache::SizeAndScalesMap entry is created even if layout has
already been performed.

Test: svg/custom/svg-image-initial-size.html

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::imageChanged):

LayoutTests:

  • svg/custom/svg-image-initial-size-expected.html: Added.
  • svg/custom/svg-image-initial-size.html: Added.
7:04 AM Changeset in webkit [132068] by yurys@chromium.org
  • 2 edits in trunk/Tools

Make sure base and derived class pointers are different in MemoryInstrumentationTest.instrumentedWithMultipleAncestors
https://bugs.webkit.org/show_bug.cgi?id=99987

Reviewed by Alexander Pavlov.

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: changed first parent

class in the list so that it has virtual table as well as the second one. This
way we may be sure that pointer to the second ancestor class will differ from
the pointer to the derived class.

5:53 AM Changeset in webkit [132067] by Simon Hausmann
  • 2 edits in trunk/Source/WTF

Unreviewed: Re-enable LLINT on Qt/Linux after r131932.

  • wtf/Platform.h:
5:45 AM Changeset in webkit [132066] by Simon Hausmann
  • 6 edits in trunk/Source

[Qt] Fix build without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=99981

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

Remove dependency to QtWidgets that is not needed here anymore since
the removal of the QtQuick1 code.

  • declarative/experimental/experimental.pri:
  • declarative/public.pri:

Source/WebKit2:

Make it possible to compile WebProcess without QtWidgets by instantiating a
QGuiApplication instead of a QApplication if we're built without widgets.

  • WebProcess.pro:
  • qt/MainQt.cpp:

(main):

5:15 AM Changeset in webkit [132065] by yurys@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Fix compilation after r132059.

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
4:39 AM Changeset in webkit [132064] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Skip plugins/npruntime/remove-property.html
https://bugs.webkit.org/show_bug.cgi?id=99978

Unreviewed EFL gardening.

Skip plugins/npruntime/remove-property.html which started
failing after r131990.

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-22

  • platform/efl-wk2/TestExpectations:
4:23 AM Changeset in webkit [132063] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[EFL] pc files should use DATA_INSTALL_DIR for datadir
https://bugs.webkit.org/show_bug.cgi?id=99961

Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2012-10-22
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

  • ewebkit.pc.in: Used DATA_INSTALL_DIR instead of hardcoded shared/XXX

Source/WebKit2:

  • ewebkit.pc.in: Fixed wrong datadir
4:04 AM EFLWebKitBuildBots edited by rakuco@webkit.org
tmpsantos is back, remove myself from the gardening schedule (diff)
3:56 AM Changeset in webkit [132062] by dominik.rottsches@intel.com
  • 2 edits in trunk/Tools

Adding Cairo and Harfbuzz watchlist entries

Unreviewed watchlist update.

Added myself to these new ones and SVG.

  • Scripts/webkitpy/common/config/watchlist:
3:49 AM Changeset in webkit [132061] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Change the path of the include files in the text decoration test cases.
https://bugs.webkit.org/show_bug.cgi?id=99974

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-22
Reviewed by Gyuyoung Kim.

The include path is differentiated by http://trac.webkit.org/changeset/132043

  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html:
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html:
  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line.html:
3:43 AM Changeset in webkit [132060] by keishi@webkit.org
  • 6 edits in trunk/Source

Remove monthFormatInLDML
https://bugs.webkit.org/show_bug.cgi?id=99971

Reviewed by Kent Tamura.

Source/Platform:

  • chromium/public/WebLocalizedString.h:

Source/WebCore:

Removing monthFormatInLDML from localized strings because Localizer class now provides the same functionality.

No new tests. Just removing unused code.

  • platform/LocalizedStrings.h:

(WebCore):

Source/WebKit/chromium:

  • src/LocalizedStrings.cpp:
3:29 AM Changeset in webkit [132059] by yurys@chromium.org
  • 4 edits in trunk

Web Inspector: do not double count memory of objects with multiple ancestors
https://bugs.webkit.org/show_bug.cgi?id=99958

Reviewed by Alexander Pavlov.

Source/WTF:

Make sure memory occupied by objects of classes with multiple inheritance is
not double counted.

  • wtf/MemoryInstrumentation.h:

(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::reportedPointer):
(WTF::MemoryObjectInfo::reportObjectInfo): 1) Store actual pointer to the instrumented
object as it may differ from the original pointer by which it was reported. 2) Make
the method non-template and calculate object size on the caller side.
(MemoryObjectInfo):
(WTF::MemoryInstrumentation::reportObjectMemoryUsage):
(WTF::MemoryClassInfo::MemoryClassInfo):
(WTF::MemoryInstrumentation::InstrumentedPointer::process): use adjusted pointer
returned by reportMemoryUsage to check if the object has already been visited when
the pointer differs from the orinal one(it may happen if the object was reported
by a pointer to one of its base classes).

Tools:

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: Test that there

is no double counting in case of multiple inheritance.

3:18 AM Changeset in webkit [132058] by zandobersek@gmail.com
  • 6 edits in trunk

[GTK] Enable Microdata DOM API
https://bugs.webkit.org/show_bug.cgi?id=99033

Reviewed by Martin Robinson.

Source/WebCore:

Enable the Microdata DOM API, but still disable it when the unstable
features should be disabled (for instance in release builds).

No new tests - related tests are being unskipped and are expected to pass.

  • GNUmakefile.am:
  • GNUmakefile.features.am:
  • bindings/gobject/GNUmakefile.am: Add the required files so the Microdata

API GObject bindings are generated and built.

LayoutTests:

Unskip the Microdata tests, they all pass now that the feature has been enabled.

  • platform/gtk/TestExpectations:
3:14 AM Changeset in webkit [132057] by keishi@webkit.org
  • 4 edits in trunk/Source

[Chromium] Rename WeekFormatInLDML to WeekFormatTemplate
https://bugs.webkit.org/show_bug.cgi?id=99972

Reviewed by Kent Tamura.

Source/Platform:

Renaming because Chromium won't be returning a week format in LDML.

  • chromium/public/WebLocalizedString.h:

Source/WebKit/chromium:

  • src/LocalizedStrings.cpp:

(WebCore::weekFormatInLDML):

3:14 AM Changeset in webkit [132056] by zandobersek@gmail.com
  • 5 edits in trunk

[GTK] Enable CSP 1.1
https://bugs.webkit.org/show_bug.cgi?id=99064

Reviewed by Martin Robinson.

Source/WebCore:

Enable CSP 1.1 in development builds but keep it disabled when the
unstable features should not be enabled (like in stable releases).

No new tests - they already exist and will be unskipped.

  • GNUmakefile.am:
  • GNUmakefile.features.am:

LayoutTests:

Unskip the CSP 1.1 layout tests as they all pass with the feature enabled.

  • platform/gtk/TestExpectations:
3:10 AM Changeset in webkit [132055] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

Test date-suggestion-picker-reset-value-after-reload.html will timeout when running with other tests
https://bugs.webkit.org/show_bug.cgi?id=99969

Reviewed by Kent Tamura.

When running with other tests the iframe onload event seems to fire before the script tag is parsed.

  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html:
2:58 AM Changeset in webkit [132054] by jocelyn.turcotte@digia.com
  • 20 edits in trunk/Source

[Qt] Fix "ASSERTION FAILED: !document->inPageCache()" when loading a page
https://bugs.webkit.org/show_bug.cgi?id=98514

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The problem is that we call setFixedVisibleContentRect, which triggers
a layout, after the document has been put in the page cache and before
the load has been actually committed.

This applies the same trick as with setFixedLayoutSize by passing the rect
in Frame::createView and calling setFixedVisibleContentRect before the
new FrameView gets attached to the Frame/Document to prevent the layout.

  • WebCore.exp.in:
  • page/Frame.cpp:

(WebCore::Frame::createView): Give a default value to the fixedLayoutSize and
useFixedLayout arguments as well since they are used exceptionally.

  • page/Frame.h:

(Frame):

Source/WebKit/blackberry:

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_view_create_for_view):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage): Use FrameView::fixedVisibleContentRect
instead of FrameView::visibleContentRect as the source to always keep the correct state.

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::transitionToCommittedForNewPage):

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::transitionToCommittedForNewPage):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Use FrameView::fixedVisibleContentRect
instead of WebFrame::visibleContentBounds as the source to always keep the correct state.

2:54 AM Changeset in webkit [132053] by allan.jensen@digia.com
  • 5 edits
    2 adds in trunk

[Qt] Handle GET of blob URLs.
https://bugs.webkit.org/show_bug.cgi?id=99053

Reviewed by Simon Hausmann.

Source/WebCore:

Let BlobResourceHandle handle Blob request internally.

  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

LayoutTests:

Unskip tests working after we handle GET of Blob URLs. Unfortunately they require beginDragWithFiles,
and thus only work in DRT.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/fast/files/workers/worker-read-blob-async-actual.txt: Added.
2:48 AM Changeset in webkit [132052] by allan.jensen@digia.com
  • 11 edits
    1 add in trunk

[Qt] Basic gesture event handling
https://bugs.webkit.org/show_bug.cgi?id=66173

Reviewed by Simon Hausmann.

Source/WebKit/qt:

Implement basic handling of QGestureEvent converting and forwarding
Tap and TapAndHold gestures to WebCore.

  • Api/qwebpage.cpp:

(QWebPagePrivate::gestureEvent):
(QWebPage::event):

  • Api/qwebpage_p.h:

(QWebPagePrivate):

  • WebCoreSupport/WebEventConversion.cpp:

(WebKitPlatformGestureEvent):
(WebCore::WebKitPlatformGestureEvent::WebKitPlatformGestureEvent):
(WebCore::convertGesture):

  • WebCoreSupport/WebEventConversion.h:

Tools:

Add support for eventSender.gestureLongPress.

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::EventSender):
(EventSender::gestureLongPress):

  • DumpRenderTree/qt/EventSenderQt.h:

(EventSender):

LayoutTests:

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/fast/events/touch/gesture/gesture-click-expected.txt: Added.
2:35 AM Changeset in webkit [132051] by bashi@chromium.org
  • 3 edits in trunk/Source/WebCore

HarfBuzzShaper::shape() should return false when it adds no glyph to GlyphBuffer
https://bugs.webkit.org/show_bug.cgi?id=99966

Reviewed by Kent Tamura.

If no glyph is added to GlyphBuffer, HarfBuzzShaper::shape() returns false.

No new tests. Confirmed the fix by using Address Sanitizer.

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shape):
(WebCore::HarfBuzzShaper::fillGlyphBuffer): Returns false when glyphBuffer.size() == 0

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:

(HarfBuzzShaper):

2:24 AM Changeset in webkit [132050] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[WTR] Properly initialize TestRunner::m_dumpSelectionRect.
https://bugs.webkit.org/show_bug.cgi?id=99970

Reviewed by Kenneth Rohde Christiansen.

Follow-up to r131476: actually initialize m_dumpSelectionRect to
some value to avoid some flakyness in the tests.

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

2:20 AM Changeset in webkit [132049] by caseq@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp

Merge 129511 - [chromium] adding a page overlay causes endless update loop when accelerated compositing is used
https://bugs.webkit.org/show_bug.cgi?id=97466

Reviewed by James Robinson.

Do not update overlays in composite() -- doing so ultimately causes invalidation
of the view, hence another update and another call do composite(). Overlays should be
updated only when their content changes.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):

TBR=caseq@chromium.org
Review URL: https://codereview.chromium.org/11235025

2:17 AM Changeset in webkit [132048] by caseq@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp

Merge 129772 - Page overlays are not updated when WebView is resized
https://bugs.webkit.org/show_bug.cgi?id=97789

Reviewed by Vsevolod Vlasov.

Invalidate page overlays when view is resized.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::sendResizeEventAndRepaint):

TBR=caseq@chromium.org
Review URL: https://codereview.chromium.org/11235024

2:11 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Add auth dialog bugs and update the target version (diff)
2:04 AM Changeset in webkit [132047] by shinyak@chromium.org
  • 6 edits
    2 adds in trunk

[Shadow] ASSERT triggered when we try reprojecting fallback elements.
https://bugs.webkit.org/show_bug.cgi?id=99815

Reviewed by Hajime Morita.

Source/WebCore:

When fallback elements of InsertionPoint is reprojected, they were attached twice.
We have to skip attaching them if they are attached. We also add a few ASSERT not to
allow attaching twice if not necessary.

We have confirmed that this patch does not regress the performance. The summary of the
performance test is the following:

Dromaeo/dom-modify.html [runs/s]:

median stdev min max

without this patch: 3928 184 3655 4361
with this patch : 3925 178 3652 4350

Parser/html5-full-render.html [s]:

median stdev min max

without this patch: 3821 17 3811 3850
with this patch : 3838 4.4 3833 3844

Test: fast/dom/shadow/content-reprojection-fallback-crash.html

  • dom/ContainerNode.cpp:

(WebCore):
(WebCore::childAttachedAllowedWhenAttachingChildren): If true, children of this node might
be attached in advance because of ShadowDOM attaching process.

  • dom/ContainerNode.h:

(ContainerNode):
(WebCore):
(WebCore::ContainerNode::attachChildren):

  • dom/Element.cpp:

(WebCore::Element::attach):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::attach):

LayoutTests:

  • fast/dom/shadow/content-reprojection-fallback-crash-expected.txt: Added.
  • fast/dom/shadow/content-reprojection-fallback-crash.html: Added.
2:04 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Add user style sheet (diff)
1:59 AM Changeset in webkit [132046] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Don't build any of the tools in production_build

Reviewed by Simon Hausmann.

  • Tools.pro:
  • qmake/mkspecs/features/configure.prf:
1:52 AM Changeset in webkit [132045] by pfeldman@chromium.org
  • 20 edits in trunk

Web Inspector: merge "docked" state into the "dock side" enum.
https://bugs.webkit.org/show_bug.cgi?id=99717

Reviewed by Vsevolod Vlasov.

.:

Otherwise, it is hard to manage these inter-dependent flags.

  • Source/autotools/symbols.filter:

Source/WebCore:

Otherwise, it is hard to manage these inter-dependent flags.

  • WebCore.exp.in:
  • inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::requestSetDockSide):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):

  • inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::requestSetDockSide):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/DockController.js:

(WebInspector.DockController):
(WebInspector.DockController.prototype._updateUI.get sides):
(WebInspector.DockController.prototype._updateUI):
(WebInspector.DockController.prototype._toggleDockState):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setAttachedWindow):
(InspectorFrontendAPI.setDockSide):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):

  • inspector/front-end/externs.js:

Source/WebKit/chromium:

Otherwise, it is hard to manage these inter-dependent flags.

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::requestSetDockSide):

  • src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
1:49 AM Changeset in webkit [132044] by rakuco@webkit.org
  • 49 edits
    7 adds in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 3.

  • platform/efl/fast/repaint/scroll-fixed-layer-with-reflection-expected.png:
  • platform/efl/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
  • platform/efl/fast/repaint/scroll-fixed-reflected-layer-expected.png:
  • platform/efl/fast/repaint/scroll-in-clipped-layer-expected.png:
  • platform/efl/fast/repaint/scroll-in-fixed-layer-expected.png:
  • platform/efl/fast/repaint/scroll-in-transformed-layer-expected.png:
  • platform/efl/fast/repaint/scroll-inside-table-cell-expected.png:
  • platform/efl/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/efl/fast/repaint/scroll-with-transformed-parent-layer-expected.png:
  • platform/efl/fast/repaint/search-field-cancel-expected.png:
  • platform/efl/fast/repaint/select-option-background-color-expected.png:
  • platform/efl/fast/repaint/selected-replaced-expected.png:
  • platform/efl/fast/repaint/selection-after-delete-expected.png:
  • platform/efl/fast/repaint/selection-after-remove-expected.png:
  • platform/efl/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/efl/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/efl/fast/repaint/selection-rl-expected.png:
  • platform/efl/fast/repaint/stacked-diacritics-expected.png:
  • platform/efl/fast/repaint/static-to-positioned-expected.png:
  • platform/efl/fast/repaint/subtree-layoutstate-transform-expected.png:
  • platform/efl/fast/repaint/subtree-root-clip-2-expected.png: Added.
  • platform/efl/fast/repaint/subtree-root-clip-3-expected.png: Added.
  • platform/efl/fast/repaint/subtree-root-clip-expected.png: Added.
  • platform/efl/fast/repaint/subtree-root-skipped-expected.png:
  • platform/efl/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/efl/fast/repaint/table-cell-move-expected.png:
  • platform/efl/fast/repaint/table-col-background-expected.png:
  • platform/efl/fast/repaint/table-collapsed-border-expected.png:
  • platform/efl/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/efl/fast/repaint/table-outer-border-expected.png:
  • platform/efl/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png:
  • platform/efl/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png:
  • platform/efl/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png:
  • platform/efl/fast/repaint/table-row-expected.png:
  • platform/efl/fast/repaint/table-section-overflow-expected.png:
  • platform/efl/fast/repaint/table-section-repaint-expected.png:
  • platform/efl/fast/repaint/table-two-pass-layout-overpaint-expected.png:
  • platform/efl/fast/repaint/text-append-dirty-lines-expected.png:
  • platform/efl/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/efl/fast/repaint/text-selection-rect-in-overflow-expected.png:
  • platform/efl/fast/repaint/textarea-set-disabled-expected.png:
  • platform/efl/fast/repaint/transform-absolute-child-expected.png:
  • platform/efl/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/efl/fast/repaint/transform-disable-layoutstate-expected.png:
  • platform/efl/fast/repaint/transform-layout-repaint-expected.png:
  • platform/efl/fast/repaint/transform-relative-position-expected.png:
  • platform/efl/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/efl/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/efl/fast/repaint/transform-rotate-and-remove-expected.png:
  • platform/efl/fast/repaint/transform-translate-expected.png:
  • platform/efl/fast/table/border-collapsing/cached-69296-expected.png:
  • platform/efl/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Added.
  • platform/efl/fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
  • platform/efl/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
  • platform/efl/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.
1:45 AM Changeset in webkit [132043] by commit-queue@webkit.org
  • 6 edits
    14 moves
    11 adds in trunk/LayoutTests

Move LayoutTests/fast/css3-text-decoration directory into LayoutTests/fast/css3-text directory.
https://bugs.webkit.org/show_bug.cgi?id=99948

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-22
Reviewed by Hajime Morita.

css3-text-decoration is one of the feature under the ENABLE_CSS3_TEXT flag,
it should be maintained in the css3-text directory with other features under the same flag.

  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt.
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html.
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt.
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html.
  • fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js.

(testElementStyle):
(testComputedStyle):

  • fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-style.js: Renamed from LayoutTests/fast/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-style.js.

(testElementStyle):
(testComputedStyleValue):
(testValue):

  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png: Renamed from LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png.
  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-expected.txt: Renamed from LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.txt.
  • fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line.html: Renamed from LayoutTests/fast/css3-text-decoration/repaint/repaint-text-decoration-line.html.
  • fast/css3-text/css3-text-decoration/text-decoration-line-expected.html: Renamed from LayoutTests/fast/css3-text-decoration/text-decoration-line-expected.html.
  • fast/css3-text/css3-text-decoration/text-decoration-line.html: Renamed from LayoutTests/fast/css3-text-decoration/text-decoration-line.html.
  • platform/chromium/TestExpectations:
  • platform/efl/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png: Renamed from LayoutTests/platform/efl/fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png.
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Renamed from LayoutTests/platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt.
  • platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Renamed from LayoutTests/platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt.
1:43 AM Changeset in webkit [132042] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Move OBJECTS_DIR and friends to default_pre.prf

The introduction of load(qt_build_config) in .qmake.conf meant
that we started loading qtmodule.pri, which in turn set both
MOC_DIR, RCC_DIR, and OBJECTS_DIR.

We were setting OBJECTS_DIR in default_post under a isEmpty() guard
so that project files could override the objects dir. Instead of
using the isEmpty() check we move it to defaul_pre, which will
override the qtmodule.pri settings, but still allow project files
to override it.

Reviewed by Ossy.

1:42 AM Changeset in webkit [132041] by commit-queue@webkit.org
  • 11 edits in trunk

WebKitTestRunner needs testRunner.queueLoadingScript and testRunner.queueNonLoadingScript
https://bugs.webkit.org/show_bug.cgi?id=42675

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-22
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added implementation of testRunner.queueLoadingScript and testRunner.queueNonLoadingScript.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::queueLoadingScript):
(WTR):
(WTR::InjectedBundle::queueNonLoadingScript):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::queueLoadingScript):
(WTR):
(WTR::TestRunner::queueNonLoadingScript):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/WorkQueueManager.cpp:

(WTR):
(WTR::runJavaScriptFunction):
(ScriptItem):
(WTR::ScriptItem::ScriptItem):
(WTR::ScriptItem::invoke):
(WTR::WorkQueueManager::queueBackNavigation):
(WTR::WorkQueueManager::queueLoadingScript):
(WTR::WorkQueueManager::queueNonLoadingScript):

  • WebKitTestRunner/WorkQueueManager.h:

(WorkQueueManager):

LayoutTests:

Unskipped corresponding test cases for WK2. Put those which still fail to appropriate
groups.

  • platform/wk2/TestExpectations:
1:40 AM Changeset in webkit [132040] by rakuco@webkit.org
  • 55 edits
    1 add in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 2.

  • platform/efl/fast/repaint/body-background-image-expected.png:
  • platform/efl/fast/repaint/layout-state-only-positioned-expected.png:
  • platform/efl/fast/repaint/layout-state-relative-expected.png:
  • platform/efl/fast/repaint/layout-state-scrolloffset-expected.png:
  • platform/efl/fast/repaint/layout-state-scrolloffset2-expected.png:
  • platform/efl/fast/repaint/layout-state-scrolloffset3-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/efl/fast/repaint/line-in-scrolled-clipped-block-expected.png:
  • platform/efl/fast/repaint/line-overflow-expected.png:
  • platform/efl/fast/repaint/lines-with-layout-delta-expected.png:
  • platform/efl/fast/repaint/list-marker-2-expected.png:
  • platform/efl/fast/repaint/make-children-non-inline-expected.png:
  • platform/efl/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/efl/fast/repaint/multicol-repaint-expected.png:
  • platform/efl/fast/repaint/nested-iframe-scroll-inner-expected.png:
  • platform/efl/fast/repaint/nested-iframe-scroll-outer-expected.png:
  • platform/efl/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png:
  • platform/efl/fast/repaint/opacity-change-on-overflow-float-expected.png:
  • platform/efl/fast/repaint/outline-child-repaint-expected.png:
  • platform/efl/fast/repaint/outline-inset-expected.png:
  • platform/efl/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/efl/fast/repaint/outline-shrinking-expected.png:
  • platform/efl/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png:
  • platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
  • platform/efl/fast/repaint/overflow-delete-line-expected.png:
  • platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
  • platform/efl/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png:
  • platform/efl/fast/repaint/overflow-hide-expected.png:
  • platform/efl/fast/repaint/overflow-into-content-expected.png:
  • platform/efl/fast/repaint/overflow-outline-repaint-expected.png:
  • platform/efl/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/efl/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png:
  • platform/efl/fast/repaint/overflow-show-expected.png:
  • platform/efl/fast/repaint/reflection-redraw-expected.png:
  • platform/efl/fast/repaint/reflection-repaint-test-expected.png:
  • platform/efl/fast/repaint/region-painting-invalidation-expected.png:
  • platform/efl/fast/repaint/region-painting-via-layout-expected.png:
  • platform/efl/fast/repaint/rel-positioned-inline-with-overflow-expected.png:
  • platform/efl/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/efl/fast/repaint/repaint-during-scroll-expected.png:
  • platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.png:
  • platform/efl/fast/repaint/repaint-resized-overflow-expected.png:
  • platform/efl/fast/repaint/scroll-absolute-layer-with-reflection-expected.png:
  • platform/efl/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png:
1:30 AM Changeset in webkit [132039] by rakuco@webkit.org
  • 74 edits
    2 adds
    1 delete in trunk/LayoutTests

[EFL] Rebaseline pixel expectations after r131941 and r131991, part 1.

  • platform/efl/fast/repaint/4774354-expected.png:
  • platform/efl/fast/repaint/4776765-expected.png:
  • platform/efl/fast/repaint/absolute-position-changed-expected.png:
  • platform/efl/fast/repaint/add-table-overpaint-expected.png: Removed.
  • platform/efl/fast/repaint/background-generated-expected.png:
  • platform/efl/fast/repaint/background-misaligned-expected.png:
  • platform/efl/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/efl/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/efl/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/efl/fast/repaint/block-no-inflow-children-expected.png:
  • platform/efl/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.png:
  • platform/efl/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/efl/fast/repaint/block-selection-gap-stale-cache-expected.png:
  • platform/efl/fast/repaint/border-fit-lines-expected.png:
  • platform/efl/fast/repaint/border-radius-repaint-expected.png:
  • platform/efl/fast/repaint/border-repaint-glitch-expected.png:
  • platform/efl/fast/repaint/box-shadow-dynamic-expected.png:
  • platform/efl/fast/repaint/box-shadow-inset-repaint-expected.png:
  • platform/efl/fast/repaint/bugzilla-3509-expected.png:
  • platform/efl/fast/repaint/bugzilla-5699-expected.png:
  • platform/efl/fast/repaint/bugzilla-6278-expected.png:
  • platform/efl/fast/repaint/bugzilla-6388-expected.png:
  • platform/efl/fast/repaint/bugzilla-6473-expected.png:
  • platform/efl/fast/repaint/bugzilla-7235-expected.png:
  • platform/efl/fast/repaint/button-spurious-layout-hint-expected.png:
  • platform/efl/fast/repaint/canvas-putImageData-expected.png:
  • platform/efl/fast/repaint/caret-outside-block-expected.png:
  • platform/efl/fast/repaint/change-transform-expected.png:
  • platform/efl/fast/repaint/clip-with-layout-delta-expected.png:
  • platform/efl/fast/repaint/clipped-relative-expected.png:
  • platform/efl/fast/repaint/containing-block-position-change-expected.png:
  • platform/efl/fast/repaint/content-into-overflow-expected.png:
  • platform/efl/fast/repaint/continuation-after-outline-expected.png:
  • platform/efl/fast/repaint/control-clip-expected.png:
  • platform/efl/fast/repaint/create-layer-repaint-expected.png:
  • platform/efl/fast/repaint/delete-into-nested-block-expected.png:
  • platform/efl/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/efl/fast/repaint/erase-overflow-expected.png:
  • platform/efl/fast/repaint/fixed-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-and-absolute-position-scrolled-expected.png:
  • platform/efl/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-expected.png:
  • platform/efl/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/efl/fast/repaint/fixed-position-transparency-with-overflow-expected.png:
  • platform/efl/fast/repaint/fixed-scale-expected.png:
  • platform/efl/fast/repaint/fixed-scroll-simple-expected.png:
  • platform/efl/fast/repaint/fixed-table-cell-expected.png:
  • platform/efl/fast/repaint/fixed-table-overflow-expected.png:
  • platform/efl/fast/repaint/fixed-table-overflow-zindex-expected.png:
  • platform/efl/fast/repaint/fixed-tranformed-expected.png:
  • platform/efl/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
  • platform/efl/fast/repaint/float-move-during-layout-expected.png:
  • platform/efl/fast/repaint/float-new-in-block-expected.png:
  • platform/efl/fast/repaint/float-overflow-expected.png: Added.
  • platform/efl/fast/repaint/float-overflow-right-expected.png: Added.
  • platform/efl/fast/repaint/gradients-em-stops-repaint-expected.png:
  • platform/efl/fast/repaint/iframe-scroll-repaint-expected.png:
  • platform/efl/fast/repaint/inline-block-resize-expected.png:
  • platform/efl/fast/repaint/inline-color-change-expected.png:
  • platform/efl/fast/repaint/inline-horizontal-bt-overflow-expected.png:
  • platform/efl/fast/repaint/inline-outline-repaint-expected.png:
  • platform/efl/fast/repaint/inline-vertical-lr-overflow-expected.png:
  • platform/efl/fast/repaint/inline-vertical-rl-overflow-expected.png:
  • platform/efl/fast/repaint/intermediate-layout-position-clip-expected.png:
  • platform/efl/fast/repaint/intermediate-layout-position-expected.png:
  • platform/efl/fast/repaint/invisible-objects-expected.png:
  • platform/efl/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/efl/fast/repaint/layer-full-repaint-expected.png:
  • platform/efl/fast/repaint/layer-hide-when-needs-layout-expected.png:
  • platform/efl/fast/repaint/layer-visibility-expected.png:
1:26 AM Changeset in webkit [132038] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed follow up to update test result after r132033.

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::installPerContextProperties):

1:22 AM Changeset in webkit [132037] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding flaky crashing expectations for fast/dom/gc-acid3.html
and http/tests/misc/acid3.html.
Removing timeout expectations for tests that were fixed in r131942.
Reclassifying svg/animations/animate-css-xml-attributeType.html
as a non-flaky failure.

  • platform/gtk/TestExpectations:
1:10 AM EFLCookiesApiTutorial created by Krzysztof Kuliga
1:06 AM Changeset in webkit [132036] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium rebaselines.

  • platform/chromium/TestExpectations:
12:58 AM EFLWebKit edited by Krzysztof Kuliga
(diff)
12:47 AM Changeset in webkit [132035] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed, a follow-up to r132034 where I forgot to address
Ojan's review comment about the race condition in handleLocationChange.

  • TestResultServer/static-dashboards/dashboard_base.js:

(handleLocationChange):

12:44 AM Changeset in webkit [132034] by zandobersek@gmail.com
  • 10 edits
    2 adds in trunk/Tools

[TestResultServer] Move the resource loading into a dedicated class
https://bugs.webkit.org/show_bug.cgi?id=99246

Reviewed by Ojan Vafai.

A new 'loader' namespace is created, containing the request method (previously located in dashboard_base.js)
and the new Loader object, which handles the loading of all the necessary data the dashboard might require.

  • TestResultServer/static-dashboards/aggregate_results.html: Include the loader.js source file.
  • TestResultServer/static-dashboards/builders.js:

(requestBuilderList): Use the request method located in the loader namespace instead of the removed doXHR method.
(onBuilderListLoad): Now parses the response text of the passed-in XHR. When all the builder lists are loaded the
resource loader object is notified appropriately.
(onErrorLoadingBuilderList): The partial function that calls this function also adds an XHR parameter.

  • TestResultServer/static-dashboards/dashboard_base.js: Much of the resource loading-related code is moved to loader.js.

The Loader object is now used to load all the required resources.
(parseParameters): Don't push the 'builder' parameter into the current state if the unit tests are being run.
(resourceLoadingComplete): This method gets called when all the resources are loaded and the dashboard should
proceed with generating the page.
(handleLocationChange):

  • TestResultServer/static-dashboards/flakiness_dashboard.html: Include the loader.js source file.
  • TestResultServer/static-dashboards/flakiness_dashboard.js: The request method has been relocated to the loader namespace.
  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: The affected test cases are modified appropriately.

(test):

  • TestResultServer/static-dashboards/loader.js: Added.

(.): A new namespace is introduced, publicly exporting the request method that performs an XHR operation and a Loader object
which oversees resource loading. The loading is done in steps, first loading the builders list, after that the results files
the current dashboard needs, and lastly the TestExpectations files if they are required by the dashboard. When done the loader
calls the resourceLoadingComplete method located in dashboard_base.js. This signals the dashboard all resources are available
and it can proceed with generating the dashboard page.

  • TestResultServer/static-dashboards/loader_unittests.js: Added. Contains unit tests for the Loader object, covering the

incremental loading and the loading of results files and TestExpectations files. The builders list loading is currently not
tested as the unit tests page overrides related methods that possibly affect other tests' behavior.

  • TestResultServer/static-dashboards/run-unittests.html: Now includes the loader.js and loader_unittests.js source file.

Refactors the code a bit due to changes in how onBuilderListLoad behaves.

  • TestResultServer/static-dashboards/timeline_explorer.html: Now includes the loader.js source file.
  • TestResultServer/static-dashboards/treemap.html: Ditto. Also refactors the code to take into account

that all the test files are now loaded before generating the dashboard page.

Oct 21, 2012:

11:44 PM Changeset in webkit [132033] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

[V8] V8EnablePerContext shouldn't require document() accessor to the native object.
https://bugs.webkit.org/show_bug.cgi?id=99954

Reviewed by Kentaro Hara.

It now refers ScriptExecutionContext of the creation context instead of document() of
wrapped object.

No new tests. No behavior change at this time.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

11:37 PM Changeset in webkit [132032] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] QNX build fails when building against Qt without clipboard support
https://bugs.webkit.org/show_bug.cgi?id=98040

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-10-21
Reviewed by Simon Hausmann.

Gracefully handle QT_NO_CLIPBOARD and do not try to access qApp->clipboard()
in such cases. Instead, return false to indicate global selection is unsupported.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::supportsGlobalSelection):

10:45 PM Changeset in webkit [132031] by tkent@chromium.org
  • 7 edits in trunk/Source

Page popup: Fix crash by events after closing
https://bugs.webkit.org/show_bug.cgi?id=99951

Reviewed by Hajime Morita.

Source/WebCore:

WebCore should provide a way to uninstall a DOMWindowPagePopup supplement.

No new tests. The bug is timing-dependent.

  • page/DOMWindowPagePopup.cpp:

(WebCore::DOMWindowPagePopup::uninstall):
Added. Calls Supplementable::removeSupplement.

  • page/DOMWindowPagePopup.h:

(DOMWindowPagePopup): Declare uninstall.

  • platform/Supplementable.h:

(WebCore::Supplementable::removeSupplement): Added.

Source/WebKit/chromium:

  • We should not handle events after closePopup call.
  • We should uninstall a DOMWindowPagePopup supplement in closePopup.
  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::WebPagePopupImpl):
Initialize m_closing.
(WebKit::WebPagePopupImpl::handleGestureEvent):
Don't handle events if m_closing.
(WebKit::WebPagePopupImpl::handleInputEvent): Ditto.
(WebKit::WebPagePopupImpl::handleKeyEvent): Ditto.
(WebKit::WebPagePopupImpl::closePopup):

  • Uninstall a DOMWindowPagePopup supplement.
  • Set m_closing.
  • src/WebPagePopupImpl.h:

(WebPagePopupImpl): Declare m_closing.

10:37 PM Changeset in webkit [132030] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, suppressing failure until I can figure out what's going on.

  • platform/chromium/TestExpectations:
10:13 PM Changeset in webkit [132029] by jochen@chromium.org
  • 22 edits
    6 copies
    2 adds in trunk/Tools

[chromium] introduce a public API for the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=99904

Reviewed by Adam Barth.

The API decouples the public API from the underlying implementation, so
embedders can depend on it. I'm also changing DRT to consume the
TestRunner API through the public API, except for DRTTestRunner and all
places that require Task.h. These two will be migrated in later changes.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
  • DumpRenderTree/chromium/MockSpellCheck.cpp:

(MockSpellCheck::fillSuggestionList):

  • DumpRenderTree/chromium/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
  • DumpRenderTree/chromium/MockWebSpeechInputController.h:
  • DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
  • DumpRenderTree/chromium/TestRunner/public/WebAccessibilityController.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.

(WebKit):
(WebTestRunner):
(WebAccessibilityController):

  • DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.

(WebKit):
(WebTestRunner):
(WebEventSender):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.

(WebKit):
(WebTestRunner):
(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h.

(WebKit):
(WebTestRunner):
(WebTestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::makeMenuItemStringsFor):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebAccessibilityController.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.

(WebTestRunner):
(WebTestRunner::WebAccessibilityController::WebAccessibilityController):
(WebTestRunner::WebAccessibilityController::setFocusedElement):
(WebTestRunner::WebAccessibilityController::notificationReceived):
(WebTestRunner::WebAccessibilityController::shouldLogAccessibilityEvents):

  • DumpRenderTree/chromium/TestRunner/src/WebEventSender.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.

(WebTestRunner):
(WebTestRunner::WebEventSender::WebEventSender):
(WebTestRunner::WebEventSender::doDragDrop):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Added.

(WebTestRunner):
(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::testInterfaces):
(WebTestRunner::WebTestInterfaces::Internal::accessibilityController):
(WebTestRunner::WebTestInterfaces::Internal::eventSender):
(WebTestRunner::WebTestInterfaces::Internal::Internal):
(WebTestRunner::WebTestInterfaces::Internal::~Internal):
(WebTestRunner::WebTestInterfaces::Internal::setDelegate):
(WebTestRunner::WebTestInterfaces::Internal::clearContextMenuData):
(WebTestRunner::WebTestInterfaces::Internal::clearEditCommand):
(WebTestRunner::WebTestInterfaces::Internal::fillSpellingSuggestionList):
(WebTestRunner::WebTestInterfaces::Internal::setEditCommand):
(WebTestRunner::WebTestInterfaces::Internal::lastContextMenuData):
(WebTestRunner::WebTestInterfaces::Internal::setGamepadData):
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::setWebView):
(WebTestRunner::WebTestInterfaces::setDelegate):
(WebTestRunner::WebTestInterfaces::bindTo):
(WebTestRunner::WebTestInterfaces::resetAll):
(WebTestRunner::WebTestInterfaces::accessibilityController):
(WebTestRunner::WebTestInterfaces::eventSender):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::eventSender):
(TestShell::accessibilityController):
(TestShell):

  • DumpRenderTree/chromium/WebUserMediaClientMock.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::finishLastTextCheck):
(WebViewHost::fillSpellingSuggestionList):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:08 PM Changeset in webkit [132028] by keishi@webkit.org
  • 50 edits
    3 adds
    1 delete in trunk

Refactor picker tests to fix flakiness and share code
https://bugs.webkit.org/show_bug.cgi?id=99671

Reviewed by Kent Tamura.

Source/WebCore:

Disable transitions until the picker is fully ready. This should fix flakiness.

No new tests.

  • Resources/pagepopups/calendarPicker.css:

(.preparing .unavailable): Disable transitions.
(.preparing .available): Disable transitions.

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker): Set "preparing" class.
(CalendarPicker.prototype._handleWindowResize): Remove the "preparing" class when the window finishes resizing.

LayoutTests:

Refactored so picker tests share code and structure.

  • fast/forms/resources/picker-common.js: Shared by all picker tests. Requires js-test-pre.js. Sets up an asynchronous test.

(openPicker): Opens the picker for the given input and calls the callback when the picker did open.
(popupOpenCallbackWrapper):
(sendKey):

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium/TestExpectations: Marked all tests as not flaky. Marked all pixel tests as need rebaseline.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.txt:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.txt:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step-expected.txt:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step.html:
  • platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
  • platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt:
  • platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html:
  • platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.txt:
  • platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html:
  • platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.txt:
  • platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html:
  • platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.txt:
  • platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html:
  • platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html:
  • platform/chromium/fast/forms/suggestion-picker/resources/suggestion-picker-common.js: Moved to resource directory like all other js files.

(valueForEntry):
(highlightedEntry):
(entryValues):

  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-key-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html:
9:59 PM EFLWebKit edited by joone@webkit.org
(diff)
9:52 PM Changeset in webkit [132027] by dpranke@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed, could've sworn this was in the previous patch ...

  • platform/chromium-win-xp/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Removed.
  • platform/chromium-win/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
9:06 PM Changeset in webkit [132026] by dpranke@chromium.org
  • 1 edit
    2 moves
    2 adds
    7 deletes in trunk/LayoutTests

Unreviewed. More chromium baseline cleanup after r132022.

  • platform/chromium-mac-lion/editing/selection/iframe-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-mac-lion/svg/custom/pattern-scaling-expected.png: Removed.
  • platform/chromium-mac-lion/svg/custom/pattern-scaling-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-scaling-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-scaling-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/pattern-scaling-expected.txt: Removed.
  • platform/chromium-win-xp/svg/custom/pattern-scaling-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/pattern-scaling-expected.txt: Removed.
  • platform/chromium-win/svg/custom/pattern-scaling-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/custom/pattern-scaling-expected.png.
  • platform/chromium/svg/custom/pattern-scaling-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/custom/pattern-scaling-expected.txt.
8:33 PM Changeset in webkit [132025] by ostapenko.viatcheslav@nokia.com
  • 2 edits in trunk/Tools

Unreviewed. Updating my emails.

7:58 PM Changeset in webkit [132024] by shinyak@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: Shadow DOM: Node removal doesn't reflect.
https://bugs.webkit.org/show_bug.cgi?id=99567

Reviewed by Pavel Feldman.

Source/WebCore:

We have to call InspectorInstrumentation::willRemoveDOMNode() even if a node is in a shadow tree.
Otherwise, node won't be removed from the inspector.

Test: inspector/elements/update-shadowdom.html

  • dom/ContainerNode.cpp:

(WebCore::dispatchChildRemovalEvents):

LayoutTests:

  • inspector/elements/update-shadowdom-expected.txt: Added.
  • inspector/elements/update-shadowdom.html: Added.
  • platform/mac/TestExpectations:
7:37 PM Changeset in webkit [132023] by kling@webkit.org
  • 13 edits in trunk/Source

Remove Page::javaScriptURLsAreAllowed setting.
<http://webkit.org/b/99944>

Reviewed by Anders Carlsson.

Source/WebCore:

This setting was exposed through internal WebView API in Apple's WebKit1.
There are no longer any clients of that API.

This is a step towards preventing elements from modifying their own attributes
below attributeChanged().

  • WebCore.exp.in:
  • WebCore.order:
  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(Page):

Source/WebKit/mac:

  • WebKit.order:
  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit/win:

Have WebView::setJavaScriptURLsAreAllowed() do nothing and return E_NOTIMPL
to prevent COM ABI breakage.

  • WebView.cpp:

(WebView::setJavaScriptURLsAreAllowed):

7:27 PM Changeset in webkit [132022] by dpranke@chromium.org
  • 5 edits
    1 copy
    1 add in trunk/LayoutTests

Unreviewed, more Chromium ML baselining minor cleanups.

  • platform/chromium-mac-lion/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png.
  • platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-win-xp/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium/TestExpectations:
7:02 PM Changeset in webkit [132021] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Storing the enclosing rect dimensions of the first finger for a two finger tap
https://bugs.webkit.org/show_bug.cgi?id=99763

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-10-21
Reviewed by Adam Barth.

Add a struct |twoFingerTap| inside the union |data| of a WebGestureEvent. The fields |firstFingerWidth|
and |firstFingerHeight| will represent the dimensions of the enclosing rectangle corresponding to the
first touch point in the gesture. These will be used in a future CL to perform target fuzzing on a
two-finger tap gesture.

Note: I chose not to name the two fields |width| and |height| so that they aren't confused with the
width and height of the gesture's bounding box, which contains the enclosing rectangles of both touch
points. My future fuzzing CL will only be concerned with the location and enclosing rectangle of the
first touch point.

  • public/WebInputEvent.h:
6:39 PM Changeset in webkit [132020] by dpranke@chromium.org
  • 230 edits
    228 copies
    10 adds in trunk/LayoutTests

Unreviewed, rebaseline remaining Chromium ML editing tests.

(long list of new baselines omitted).

6:27 PM Changeset in webkit [132019] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Add a separate flag for rgb swizzling whether it can be modified or not
https://bugs.webkit.org/show_bug.cgi?id=98728

BitmapTexture swizzles the source image if the OpenGL driver
doesn't support the BGRA extension.
In case of directly composited images, the source image should not
be modified.

http://www.satine.org/research/webkit/snowleopard/snowstack.html

Patch by Hyungchan Kim <hyungchan2.kim@lge.com> on 2012-10-21
Reviewed by Noam Rosenthal.

No new tests as this is only testable on specific hardware and
currently not avaiable in the bots.

Source/WebCore:

  • platform/graphics/texmap/TextureMapper.h:

(BitmapTexture):

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(TextureMapperTile):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawRepaintCounter):
(WebCore::BitmapTextureGL::updateContents):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::updateContents):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(BitmapTextureImageBuffer):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore):

Source/WebKit2:

  • platform/graphics/texmap/TextureMapper.h:

(BitmapTexture):

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(TextureMapperTile):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawRepaintCounter):
(WebCore::BitmapTextureGL::updateContents):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::updateContents):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(BitmapTextureImageBuffer):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore):

6:25 PM Changeset in webkit [132018] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[EFL] Fix failure to access the inspector resources
https://bugs.webkit.org/show_bug.cgi?id=99816

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-10-21
Reviewed by Gyuyoung Kim.

access() returns -1, if path has a file protocol like "file://".
And I have removed it from the first argument of access().
If not, inspectorBaseURL() or inspectorFilesPath() always returns WEB_INSPECTOR_DIR.
Then all layout test related to inspector can fail after installing webkit package.

Source/WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::inspectorFilesPath):

Source/WebKit2:

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::inspectorBaseURL):

6:13 PM Changeset in webkit [132017] by dpranke@chromium.org
  • 180 edits
    187 copies
    18 adds in trunk/LayoutTests

Unreviewed, new Chromium ML expectations for editing/inserting and editing/pasteboard.

(long list of new baselines omitted).

5:54 PM Changeset in webkit [132016] by dpranke@chromium.org
  • 160 edits
    160 copies
    40 adds
    3 deletes in trunk/LayoutTests

Unreviewed, new Chromium ML baselines for editing/deleting, editing/execCommand, and editing/selection

(long list of new baselines omitted).

5:32 PM Changeset in webkit [132015] by dpranke@chromium.org
  • 19 edits
    17 copies
    4 adds in trunk/LayoutTests

Unreviewed, new Chromium ML baselines for platform/chromium/virtual/gpu/fast/hidpi.

  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-4-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-4-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-5-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-5-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-6-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-6-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-7-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-7-expected.png.
  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png.
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-4-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-5-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-6-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-7-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium/TestExpectations:
5:00 PM FeatureFlags edited by dw.im@samsung.com
(diff)
4:48 PM Changeset in webkit [132014] by dpranke@chromium.org
  • 19 edits
    15 copies
    1 add in trunk/LayoutTests

Unreviewed, add Chromium ML baselines for fast/hidpi.

  • platform/chromium-mac-lion/fast/hidpi/clip-text-in-hidpi-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/clip-text-in-hidpi-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-as-background-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-as-background-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-background-dynamic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-background-dynamic-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-background-repeat-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-background-repeat-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-background-repeat-without-size-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-background-repeat-without-size-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-border-image-comparison-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-border-image-comparison-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-border-image-dynamic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-border-image-dynamic-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-border-image-simple-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-border-image-simple-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-in-content-dynamic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-in-content-dynamic-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-out-of-order-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-out-of-order-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-simple-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-simple-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/image-set-without-specified-width-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/image-set-without-specified-width-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/resize-corner-hidpi-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/resize-corner-hidpi-expected.png.
  • platform/chromium-mac-lion/fast/hidpi/video-controls-in-hidpi-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png.
  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac/fast/hidpi/clip-text-in-hidpi-expected.png:
  • platform/chromium-mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-as-background-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-background-dynamic-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-without-size-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-border-image-comparison-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-border-image-dynamic-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-border-image-simple-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-in-content-dynamic-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-out-of-order-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-simple-expected.png:
  • platform/chromium-mac/fast/hidpi/image-set-without-specified-width-expected.png:
  • platform/chromium-mac/fast/hidpi/resize-corner-hidpi-expected.png:
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-win/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
4:37 PM Changeset in webkit [132013] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, re-adjust Chromium Mac expectations.

  • platform/chromium/TestExpectations:
4:33 PM Changeset in webkit [132012] by dpranke@chromium.org
  • 35 edits
    32 copies
    7 moves
    1 add
    1 delete in trunk/LayoutTests

Unreviewed, new Chromium ML baselines for fast/canvas.

  • fast/canvas/canvas-incremental-repaint-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-incremental-repaint-expected.png.
  • fast/canvas/canvas-size-change-after-layout-expected.png: Renamed from LayoutTests/platform/mac/fast/canvas/canvas-size-change-after-layout-expected.png.
  • fast/canvas/canvasDrawingIntoSelf-expected.png: Renamed from LayoutTests/platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.png.
  • fast/canvas/drawImage-expected.png: Renamed from LayoutTests/platform/mac/fast/canvas/drawImage-expected.png.
  • fast/canvas/shadow-offset-1-expected.png: Renamed from LayoutTests/platform/mac/fast/canvas/shadow-offset-1-expected.png.
  • fast/canvas/shadow-offset-2-expected.png: Renamed from LayoutTests/platform/mac/fast/canvas/shadow-offset-2-expected.png.
  • fast/canvas/shadow-offset-3-expected.png: Renamed from LayoutTests/platform/mac/fast/canvas/shadow-offset-3-expected.png.
  • platform/chromium-mac-lion/fast/canvas/arc360-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/arc360-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-before-css-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-before-css-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-bg-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-bg-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-composite-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-composite-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-resize-reset-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-resize-reset-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-size-change-after-layout-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-size-change-after-layout-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-text-alignment-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-text-alignment-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-text-baseline-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-text-baseline-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-transforms-during-path-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-transforms-during-path-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvas-zoom-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvas-zoom-expected.png.
  • platform/chromium-mac-lion/fast/canvas/canvasDrawingIntoSelf-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/canvasDrawingIntoSelf-expected.png.
  • platform/chromium-mac-lion/fast/canvas/check-stale-putImageData-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/check-stale-putImageData-expected.png.
  • platform/chromium-mac-lion/fast/canvas/drawImage-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/drawImage-expected.png.
  • platform/chromium-mac-lion/fast/canvas/drawImage-with-globalAlpha-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/drawImage-with-globalAlpha-expected.png.
  • platform/chromium-mac-lion/fast/canvas/fill-stroke-clip-reset-path-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/fill-stroke-clip-reset-path-expected.png.
  • platform/chromium-mac-lion/fast/canvas/fillrect-gradient-zero-stops-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/fillrect-gradient-zero-stops-expected.png.
  • platform/chromium-mac-lion/fast/canvas/fillrect_gradient-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png.
  • platform/chromium-mac-lion/fast/canvas/image-object-in-canvas-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png.
  • platform/chromium-mac-lion/fast/canvas/image-pattern-rotate-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png.
  • platform/chromium-mac-lion/fast/canvas/patternfill-repeat-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/patternfill-repeat-expected.png.
  • platform/chromium-mac-lion/fast/canvas/quadraticCurveTo-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/quadraticCurveTo-expected.png.
  • platform/chromium-mac-lion/fast/canvas/setWidthResetAfterForcedRender-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-1-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-1-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-2-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-2-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-3-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-3-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-4-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-4-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-5-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-5-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-6-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-6-expected.png.
  • platform/chromium-mac-lion/fast/canvas/shadow-offset-7-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/shadow-offset-7-expected.png.
  • platform/chromium-mac-lion/fast/canvas/toDataURL-alpha-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/toDataURL-alpha-expected.png.
  • platform/chromium-mac-lion/fast/canvas/zero-size-fill-rect-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/zero-size-fill-rect-expected.png.
  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac/fast/canvas/arc360-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-before-css-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-resize-reset-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-size-change-after-layout-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-transforms-during-path-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-zoom-expected.png:
  • platform/chromium-mac/fast/canvas/canvasDrawingIntoSelf-expected.png:
  • platform/chromium-mac/fast/canvas/check-stale-putImageData-expected.png:
  • platform/chromium-mac/fast/canvas/drawImage-expected.png:
  • platform/chromium-mac/fast/canvas/drawImage-with-globalAlpha-expected.png:
  • platform/chromium-mac/fast/canvas/fill-stroke-clip-reset-path-expected.png:
  • platform/chromium-mac/fast/canvas/fillrect-gradient-zero-stops-expected.png:
  • platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png:
  • platform/chromium-mac/fast/canvas/patternfill-repeat-expected.png:
  • platform/chromium-mac/fast/canvas/quadraticCurveTo-expected.png:
  • platform/chromium-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-1-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-2-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-3-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-4-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-5-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-6-expected.png:
  • platform/chromium-mac/fast/canvas/shadow-offset-7-expected.png:
  • platform/chromium-mac/fast/canvas/toDataURL-alpha-expected.png:
  • platform/chromium-mac/fast/canvas/zero-size-fill-rect-expected.png:
  • platform/chromium/TestExpectations:
  • platform/gtk/fast/canvas/canvas-incremental-repaint-expected.png: Removed.
3:51 PM Changeset in webkit [132011] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, expectations update for Chromium.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium/TestExpectations:
3:39 PM Changeset in webkit [132010] by dpranke@chromium.org
  • 108 edits
    106 copies
    1 move
    12 adds
    23 deletes in trunk/LayoutTests

Unreviewed, update Chromium ML baselines for LayoutTests/css1 and optimize.

  • css1/formatting_model/floating_elements-expected.png: Renamed from LayoutTests/platform/efl/css1/formatting_model/floating_elements-expected.png.
  • platform/chromium-linux-x86/css1/basic/class_as_selector-expected.png: Removed.
  • platform/chromium-linux-x86/css1/basic/id_as_selector-expected.png: Removed.
  • platform/chromium-linux-x86/css1/box_properties/border_bottom-expected.png: Removed.
  • platform/chromium-linux-x86/css1/box_properties/margin_left-expected.png: Removed.
  • platform/chromium-linux-x86/css1/box_properties/padding_right-expected.png: Removed.
  • platform/chromium-linux-x86/css1/pseudo/anchor-expected.png: Removed.
  • platform/chromium-mac-lion/css1/basic/class_as_selector-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/class_as_selector-expected.png.
  • platform/chromium-mac-lion/css1/basic/comments-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/comments-expected.png.
  • platform/chromium-mac-lion/css1/basic/containment-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/containment-expected.png.
  • platform/chromium-mac-lion/css1/basic/contextual_selectors-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/contextual_selectors-expected.png.
  • platform/chromium-mac-lion/css1/basic/grouping-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/grouping-expected.png.
  • platform/chromium-mac-lion/css1/basic/id_as_selector-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/id_as_selector-expected.png.
  • platform/chromium-mac-lion/css1/basic/inheritance-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/basic/inheritance-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/acid_test-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/acid_test-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_bottom-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_bottom-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_bottom_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_bottom_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_bottom_width-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_bottom_width-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_bottom_width_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_bottom_width_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_color-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_color-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_color_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_color_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_left-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_left-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_left_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_left_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_left_width-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_left_width-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_left_width_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_left_width_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_right-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_right-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_right_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_right_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_right_width-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_right_width-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_right_width_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_right_width_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_style-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_style-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_style_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_style_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_top-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_top-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_top_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_top_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_top_width-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_top_width-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_top_width_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_top_width_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_width-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_width-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/border_width_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/border_width_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/clear-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/clear-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/clear_float-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/clear_float-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/float-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/float-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/float_elements_in_series-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/float_margin-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/float_margin-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/float_on_text_elements-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/height-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/height-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_bottom-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_bottom-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_bottom_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_bottom_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_left-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_left-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_left_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_left_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_right-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_right-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_right_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_right_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_top-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_top-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/margin_top_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/margin_top_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_bottom-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_bottom-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_bottom_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_bottom_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_left-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_left-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_left_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_left_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_right-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_right-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_right_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_right_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_top-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_top-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/padding_top_inline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/padding_top_inline-expected.png.
  • platform/chromium-mac-lion/css1/box_properties/width-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/box_properties/width-expected.png.
  • platform/chromium-mac-lion/css1/cascade/cascade_order-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/cascade/cascade_order-expected.png.
  • platform/chromium-mac-lion/css1/cascade/important-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/cascade/important-expected.png.
  • platform/chromium-mac-lion/css1/classification/display-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/classification/display-expected.png.
  • platform/chromium-mac-lion/css1/classification/list_style-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/classification/list_style-expected.png.
  • platform/chromium-mac-lion/css1/classification/list_style_image-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/classification/list_style_image-expected.png.
  • platform/chromium-mac-lion/css1/classification/list_style_position-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/classification/list_style_position-expected.png.
  • platform/chromium-mac-lion/css1/classification/list_style_type-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/classification/list_style_type-expected.png.
  • platform/chromium-mac-lion/css1/classification/white_space-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/classification/white_space-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/background-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/background-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/background_attachment-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/background_attachment-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/background_color-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/background_color-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/background_image-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/background_image-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/background_position-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/background_position-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/background_repeat-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/background_repeat-expected.png.
  • platform/chromium-mac-lion/css1/color_and_background/color-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/color_and_background/color-expected.png.
  • platform/chromium-mac-lion/css1/conformance/forward_compatible_parsing-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.png.
  • platform/chromium-mac-lion/css1/font_properties/font-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/font_properties/font-expected.png.
  • platform/chromium-mac-lion/css1/font_properties/font_family-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/font_properties/font_family-expected.png.
  • platform/chromium-mac-lion/css1/font_properties/font_size-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/font_properties/font_size-expected.png.
  • platform/chromium-mac-lion/css1/font_properties/font_style-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/font_properties/font_style-expected.png.
  • platform/chromium-mac-lion/css1/font_properties/font_variant-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/font_properties/font_variant-expected.png.
  • platform/chromium-mac-lion/css1/font_properties/font_weight-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/font_properties/font_weight-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/canvas-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/canvas-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/floating_elements-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/floating_elements-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/height_of_lines-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/height_of_lines-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/horizontal_formatting-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/inline_elements-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/inline_elements-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/replaced_elements-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/replaced_elements-expected.png.
  • platform/chromium-mac-lion/css1/formatting_model/vertical_formatting-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.png.
  • platform/chromium-mac-lion/css1/pseudo/anchor-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/pseudo/anchor-expected.png.
  • platform/chromium-mac-lion/css1/pseudo/firstletter-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/pseudo/firstletter-expected.png.
  • platform/chromium-mac-lion/css1/pseudo/firstline-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/pseudo/firstline-expected.png.
  • platform/chromium-mac-lion/css1/pseudo/multiple_pseudo_elements-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.png.
  • platform/chromium-mac-lion/css1/pseudo/pseudo_elements_in_selectors-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/pseudo/pseudo_elements_in_selectors-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/letter_spacing-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/letter_spacing-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/line_height-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/line_height-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/text_align-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/text_align-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/text_decoration-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/text_decoration-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/text_indent-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/text_indent-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/text_transform-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/text_transform-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/vertical_align-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/vertical_align-expected.png.
  • platform/chromium-mac-lion/css1/text_properties/word_spacing-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/text_properties/word_spacing-expected.png.
  • platform/chromium-mac-lion/css1/units/color_units-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/units/color_units-expected.png.
  • platform/chromium-mac-lion/css1/units/length_units-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/units/length_units-expected.png.
  • platform/chromium-mac-lion/css1/units/percentage_units-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/units/percentage_units-expected.png.
  • platform/chromium-mac-lion/css1/units/urls-expected.png: Copied from LayoutTests/platform/chromium-mac/css1/units/urls-expected.png.
  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac/css1/basic/class_as_selector-expected.png:
  • platform/chromium-mac/css1/basic/comments-expected.png:
  • platform/chromium-mac/css1/basic/containment-expected.png:
  • platform/chromium-mac/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-mac/css1/basic/grouping-expected.png:
  • platform/chromium-mac/css1/basic/id_as_selector-expected.png:
  • platform/chromium-mac/css1/basic/inheritance-expected.png:
  • platform/chromium-mac/css1/box_properties/acid_test-expected.png:
  • platform/chromium-mac/css1/box_properties/border-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom_width_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_color-expected.png:
  • platform/chromium-mac/css1/box_properties/border_color_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left_width_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right_width_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_style-expected.png:
  • platform/chromium-mac/css1/box_properties/border_style_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top_width_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_width-expected.png:
  • platform/chromium-mac/css1/box_properties/border_width_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/clear-expected.png:
  • platform/chromium-mac/css1/box_properties/clear_float-expected.png:
  • platform/chromium-mac/css1/box_properties/float-expected.png:
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-mac/css1/box_properties/float_margin-expected.png:
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-mac/css1/box_properties/height-expected.png:
  • platform/chromium-mac/css1/box_properties/margin-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_bottom-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_bottom_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_left-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_left_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_right_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_top-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_top_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/padding-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_bottom-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_bottom_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_left-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_left_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_right_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_top-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_top_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/width-expected.png:
  • platform/chromium-mac/css1/cascade/cascade_order-expected.png:
  • platform/chromium-mac/css1/cascade/important-expected.png:
  • platform/chromium-mac/css1/classification/display-expected.png:
  • platform/chromium-mac/css1/classification/list_style-expected.png:
  • platform/chromium-mac/css1/classification/list_style_image-expected.png:
  • platform/chromium-mac/css1/classification/list_style_position-expected.png:
  • platform/chromium-mac/css1/classification/list_style_type-expected.png:
  • platform/chromium-mac/css1/classification/white_space-expected.png:
  • platform/chromium-mac/css1/color_and_background/background-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_color-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_image-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_position-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_repeat-expected.png:
  • platform/chromium-mac/css1/color_and_background/color-expected.png:
  • platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.png:
  • platform/chromium-mac/css1/font_properties/font-expected.png:
  • platform/chromium-mac/css1/font_properties/font_family-expected.png:
  • platform/chromium-mac/css1/font_properties/font_size-expected.png:
  • platform/chromium-mac/css1/font_properties/font_style-expected.png:
  • platform/chromium-mac/css1/font_properties/font_variant-expected.png:
  • platform/chromium-mac/css1/font_properties/font_weight-expected.png:
  • platform/chromium-mac/css1/formatting_model/canvas-expected.png:
  • platform/chromium-mac/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/height_of_lines-expected.png:
  • platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/chromium-mac/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-mac/css1/pseudo/anchor-expected.png:
  • platform/chromium-mac/css1/pseudo/firstletter-expected.png:
  • platform/chromium-mac/css1/pseudo/firstline-expected.png:
  • platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/chromium-mac/css1/pseudo/pseudo_elements_in_selectors-expected.png:
  • platform/chromium-mac/css1/text_properties/letter_spacing-expected.png:
  • platform/chromium-mac/css1/text_properties/line_height-expected.png:
  • platform/chromium-mac/css1/text_properties/text_align-expected.png:
  • platform/chromium-mac/css1/text_properties/text_decoration-expected.png:
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png:
  • platform/chromium-mac/css1/text_properties/text_transform-expected.png:
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.png:
  • platform/chromium-mac/css1/text_properties/word_spacing-expected.png:
  • platform/chromium-mac/css1/units/color_units-expected.png:
  • platform/chromium-mac/css1/units/length_units-expected.png:
  • platform/chromium-mac/css1/units/percentage_units-expected.png:
  • platform/chromium-mac/css1/units/urls-expected.png:
  • platform/chromium-win-xp/css1/basic/class_as_selector-expected.png: Removed.
  • platform/chromium-win-xp/css1/basic/containment-expected.png: Removed.
  • platform/chromium-win-xp/css1/basic/id_as_selector-expected.png: Removed.
  • platform/chromium-win-xp/css1/box_properties/border_bottom-expected.png: Removed.
  • platform/chromium-win-xp/css1/box_properties/border_left-expected.png: Removed.
  • platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Removed.
  • platform/chromium-win-xp/css1/box_properties/border_top-expected.png: Removed.
  • platform/chromium-win-xp/css1/box_properties/clear_float-expected.png: Removed.
  • platform/chromium-win-xp/css1/box_properties/margin_left-expected.png: Removed.
  • platform/chromium-win-xp/css1/box_properties/margin_right-expected.png: Removed.
  • platform/chromium-win-xp/css1/box_properties/padding_left-expected.png: Removed.
  • platform/chromium-win-xp/css1/box_properties/padding_right-expected.png: Removed.
  • platform/chromium-win-xp/css1/cascade/cascade_order-expected.png: Removed.
  • platform/chromium-win-xp/css1/classification/list_style_type-expected.png: Removed.
  • platform/chromium-win-xp/css1/formatting_model/floating_elements-expected.png: Removed.
  • platform/chromium-win-xp/css1/pseudo/anchor-expected.png: Removed.
  • platform/gtk/css1/formatting_model/floating_elements-expected.png: Removed.
3:02 PM Changeset in webkit [132009] by Antti Koivisto
  • 13 edits
    2 adds in trunk/Source/WebCore

Factor stylesheet invalidation analysis code into a class
https://bugs.webkit.org/show_bug.cgi?id=99933

Reviewed by Sam Weinig.

Currently the stylesheet analysis code is all over the place. It should be factored into a class to make
further progress easier.

The patch adds StyleInvalidationAnalysis class and moves a bunch of code from SelectorChecker, StyleResolver
and DocumentStyleSheetCollection there. No functional changes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/SelectorChecker.cpp:

(WebCore):

  • css/SelectorChecker.h:

(WebCore):

  • css/StyleInvalidationAnalysis.cpp: Added.

(WebCore):
(WebCore::StyleInvalidationAnalysis::StyleInvalidationAnalysis):
(WebCore::StyleInvalidationAnalysis::create):
(WebCore::determineSelectorScopes):
(WebCore::StyleInvalidationAnalysis::analyzeStyleSheet):
(WebCore::elementMatchesSelectorScopes):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):

  • css/StyleInvalidationAnalysis.h: Added.

(WebCore):
(StyleInvalidationAnalysis):
(WebCore::StyleInvalidationAnalysis::dirtiesAllStyle):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::checkRegionSelector):

  • css/StyleResolver.h:

(StyleResolver):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):

  • dom/DocumentStyleSheetCollection.h:

(DocumentStyleSheetCollection):

3:02 PM Changeset in webkit [132008] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, chromium expectations update to remove passing tests.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium/TestExpectations:
12:53 PM Changeset in webkit [132007] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[EFL][WK2] Make Ewk_Error, Ewk_Resource and Ewk_Popup_Menu_Item members private
https://bugs.webkit.org/show_bug.cgi?id=99931

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-21
Reviewed by Kenneth Rohde Christiansen.

Make Ewk_Error, Ewk_Resource and Ewk_Popup_Menu_Item class
members private.

  • UIProcess/API/efl/ewk_error.cpp:

(Ewk_Error::Ewk_Error):
(Ewk_Error::url):
(Ewk_Error::description):
(Ewk_Error::domain):
(Ewk_Error::errorCode):
(Ewk_Error::isCancellation):
(ewk_error_type_get):
(ewk_error_url_get):
(ewk_error_code_get):
(ewk_error_description_get):
(ewk_error_cancellation_get):

  • UIProcess/API/efl/ewk_error_private.h:

(Ewk_Error):

  • UIProcess/API/efl/ewk_popup_menu_item.cpp:

(Ewk_Popup_Menu_Item::Ewk_Popup_Menu_Item):
(Ewk_Popup_Menu_Item::type):
(Ewk_Popup_Menu_Item::textDirection):
(Ewk_Popup_Menu_Item::text):
(Ewk_Popup_Menu_Item::tooltipText):
(Ewk_Popup_Menu_Item::accessibilityText):
(Ewk_Popup_Menu_Item::hasTextDirectionOverride):
(Ewk_Popup_Menu_Item::isEnabled):
(Ewk_Popup_Menu_Item::isLabel):
(Ewk_Popup_Menu_Item::isSelected):
(ewk_popup_menu_item_type_get):
(ewk_popup_menu_item_text_get):
(ewk_popup_menu_item_text_direction_get):
(ewk_popup_menu_item_text_direction_override_get):
(ewk_popup_menu_item_tooltip_get):
(ewk_popup_menu_item_accessibility_text_get):
(ewk_popup_menu_item_enabled_get):
(ewk_popup_menu_item_is_label_get):
(ewk_popup_menu_item_selected_get):

  • UIProcess/API/efl/ewk_popup_menu_item_private.h:

(Ewk_Popup_Menu_Item):

  • UIProcess/API/efl/ewk_resource.cpp:

(Ewk_Resource::Ewk_Resource):
(Ewk_Resource::url):
(Ewk_Resource::isMainResource):
(ewk_resource_url_get):
(ewk_resource_main_resource_get):

  • UIProcess/API/efl/ewk_resource_private.h:

(Ewk_Resource):

10:17 AM Changeset in webkit [132006] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit2

[EFL][WK2] Make Ewk_Url_Request, Ewk_Url_Response and Ewk_Url_Scheme_Request members private
https://bugs.webkit.org/show_bug.cgi?id=99936

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-21
Reviewed by Kenneth Rohde Christiansen.

Make wk_Url_Request, Ewk_Url_Response and Ewk_Url_Scheme_Request
class members private.

  • UIProcess/API/efl/ewk_context.cpp:

(ewk_context_url_scheme_request_received):

  • UIProcess/API/efl/ewk_download_job.cpp:

(Ewk_Download_Job::estimatedProgress):

  • UIProcess/API/efl/ewk_url_request.cpp:

(Ewk_Url_Request::Ewk_Url_Request):
(Ewk_Url_Request::url):
(Ewk_Url_Request::firstParty):
(Ewk_Url_Request::httpMethod):
(ewk_url_request_url_get):
(ewk_request_cookies_first_party_get):
(ewk_url_request_http_method_get):

  • UIProcess/API/efl/ewk_url_request_private.h:

(Ewk_Url_Request):

  • UIProcess/API/efl/ewk_url_response.cpp:

(Ewk_Url_Response::Ewk_Url_Response):
(Ewk_Url_Response::httpStatusCode):
(Ewk_Url_Response::url):
(Ewk_Url_Response::mimeType):
(Ewk_Url_Response::contentLength):
(ewk_url_response_url_get):
(ewk_url_response_status_code_get):
(ewk_url_response_mime_type_get):
(ewk_url_response_content_length_get):

  • UIProcess/API/efl/ewk_url_response_private.h:

(Ewk_Url_Response):

  • UIProcess/API/efl/ewk_url_scheme_request.cpp:

(Ewk_Url_Scheme_Request::Ewk_Url_Scheme_Request):
(Ewk_Url_Scheme_Request::id):
(Ewk_Url_Scheme_Request::url):
(Ewk_Url_Scheme_Request::scheme):
(Ewk_Url_Scheme_Request::path):
(Ewk_Url_Scheme_Request::finish):
(ewk_url_scheme_request_scheme_get):
(ewk_url_scheme_request_url_get):
(ewk_url_scheme_request_path_get):
(ewk_url_scheme_request_finish):

  • UIProcess/API/efl/ewk_url_scheme_request.h: Fix ewk_url_scheme_request_finish() declaration

so that the request argument is no longer marked as const and so that the content type is of
type uint64_t instead of unsigned int.

  • UIProcess/API/efl/ewk_url_scheme_request_private.h:

(Ewk_Url_Scheme_Request):

9:34 AM Changeset in webkit [132005] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[EFL][WK2] Make Ewk_Form_Submission_Request, Ewk_Navigation_Data and Ewk_Navigation_Policy_Decision members private
https://bugs.webkit.org/show_bug.cgi?id=99934

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-21
Reviewed by Kenneth Rohde Christiansen.

Make Ewk_Form_Submission_Request, Ewk_Navigation_Data and
Ewk_Navigation_Policy_Decision class members private.

  • UIProcess/API/efl/ewk_form_submission_request.cpp:

(Ewk_Form_Submission_Request::Ewk_Form_Submission_Request):
(Ewk_Form_Submission_Request::~Ewk_Form_Submission_Request):
(Ewk_Form_Submission_Request::fieldValue):
(Ewk_Form_Submission_Request::fieldNames):
(Ewk_Form_Submission_Request::submit):
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):
(ewk_form_submission_request_submit):

  • UIProcess/API/efl/ewk_form_submission_request_private.h:

(Ewk_Form_Submission_Request):

  • UIProcess/API/efl/ewk_navigation_data.cpp:

(Ewk_Navigation_Data::Ewk_Navigation_Data):
(Ewk_Navigation_Data::originalRequest):
(Ewk_Navigation_Data::title):
(Ewk_Navigation_Data::url):
(ewk_navigation_data_title_get):
(ewk_navigation_data_original_request_get):
(ewk_navigation_data_url_get):

  • UIProcess/API/efl/ewk_navigation_data_private.h:

(Ewk_Navigation_Data):

  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(Ewk_Navigation_Policy_Decision::Ewk_Navigation_Policy_Decision):
(Ewk_Navigation_Policy_Decision::~Ewk_Navigation_Policy_Decision):
(Ewk_Navigation_Policy_Decision::navigationType):
(Ewk_Navigation_Policy_Decision::mouseButton):
(Ewk_Navigation_Policy_Decision::modifiers):
(Ewk_Navigation_Policy_Decision::frameName):
(Ewk_Navigation_Policy_Decision::request):
(Ewk_Navigation_Policy_Decision::accept):
(Ewk_Navigation_Policy_Decision::reject):
(Ewk_Navigation_Policy_Decision::download):
(ewk_navigation_policy_navigation_type_get):
(ewk_navigation_policy_mouse_button_get):
(ewk_navigation_policy_modifiers_get):
(ewk_navigation_policy_frame_name_get):
(ewk_navigation_policy_request_get):
(ewk_navigation_policy_decision_accept):
(ewk_navigation_policy_decision_reject):
(ewk_navigation_policy_decision_download):

  • UIProcess/API/efl/ewk_navigation_policy_decision_private.h:

(Ewk_Navigation_Policy_Decision):

9:23 AM Changeset in webkit [132004] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Make Ewk_Favicon_Database members private
https://bugs.webkit.org/show_bug.cgi?id=99932

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-21
Reviewed by Kenneth Rohde Christiansen.

Make Ewk_Favicon_Database class members private.

  • UIProcess/API/efl/ewk_favicon_database.cpp:

(Ewk_Favicon_Database::Ewk_Favicon_Database):
(Ewk_Favicon_Database::iconURLForPageURL):
(Ewk_Favicon_Database::watchChanges):
(Ewk_Favicon_Database::unwatchChanges):
(AsyncIconRequestResponse):
(AsyncIconRequestResponse::AsyncIconRequestResponse):
(respond_icon_request_idle):
(Ewk_Favicon_Database::iconForPageURL):
(Ewk_Favicon_Database::didChangeIconForPageURL):
(Ewk_Favicon_Database::getIconSurfaceSynchronously):
(Ewk_Favicon_Database::iconDataReadyForPageURL):
(ewk_favicon_database_icon_url_get):
(ewk_favicon_database_async_icon_get):
(ewk_favicon_database_icon_change_callback_add):
(ewk_favicon_database_icon_change_callback_del):

  • UIProcess/API/efl/ewk_favicon_database.h:
  • UIProcess/API/efl/ewk_favicon_database_private.h:

(Ewk_Favicon_Database):

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data::~Ewk_View_Private_Data):
(_ewk_view_initialize):

9:13 AM Changeset in webkit [132003] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] Make Ewk back / forward list classes members private and remove private C functions
https://bugs.webkit.org/show_bug.cgi?id=99929

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-21
Reviewed by Kenneth Rohde Christiansen.

Make Ewk_Back_Forward_List and Ewk_Back_Forward_List_Item members
private and remove private C functions.

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(Ewk_Back_Forward_List::Ewk_Back_Forward_List):
(Ewk_Back_Forward_List::nextItem):
(Ewk_Back_Forward_List::previousItem):
(Ewk_Back_Forward_List::currentItem):
(Ewk_Back_Forward_List::itemAt):
(Ewk_Back_Forward_List::size):
(Ewk_Back_Forward_List::backList):
(Ewk_Back_Forward_List::forwardList):
(Ewk_Back_Forward_List::getFromCacheOrCreate):
(Ewk_Back_Forward_List::createEinaList):
(Ewk_Back_Forward_List::update):
(ewk_back_forward_list_current_item_get):
(ewk_back_forward_list_previous_item_get):
(ewk_back_forward_list_next_item_get):
(ewk_back_forward_list_item_at_index_get):
(ewk_back_forward_list_count):
(ewk_back_forward_list_n_back_items_copy):
(ewk_back_forward_list_n_forward_items_copy):

  • UIProcess/API/efl/ewk_back_forward_list_item.cpp:

(Ewk_Back_Forward_List_Item::Ewk_Back_Forward_List_Item):
(Ewk_Back_Forward_List_Item::url):
(Ewk_Back_Forward_List_Item::title):
(Ewk_Back_Forward_List_Item::originalURL):
(ewk_back_forward_list_item_url_get):
(ewk_back_forward_list_item_title_get):
(ewk_back_forward_list_item_original_url_get):

  • UIProcess/API/efl/ewk_back_forward_list_item_private.h:

(Ewk_Back_Forward_List_Item):

  • UIProcess/API/efl/ewk_back_forward_list_private.h:

(Ewk_Back_Forward_List):

  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didChangeBackForwardList):

9:00 AM Changeset in webkit [132002] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Make Ewk_Cookie_Manager members private
https://bugs.webkit.org/show_bug.cgi?id=99930

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-21
Reviewed by Kenneth Rohde Christiansen.

Make Ewk_Cookie_Manager class members private.

  • UIProcess/API/efl/ewk_cookie_manager.cpp:

(Ewk_Cookie_Manager::Ewk_Cookie_Manager):
(Ewk_Cookie_Manager::~Ewk_Cookie_Manager):
(Ewk_Cookie_Manager::setPersistentStorage):
(Ewk_Cookie_Manager::setHTTPAcceptPolicy):
(Ewk_Cookie_Manager::clearHostnameCookies):
(Ewk_Cookie_Manager::clearAllCookies):
(Ewk_Cookie_Manager::watchChanges):
(Ewk_Cookie_Manager::isWatchingForChanges):
(Ewk_Cookie_Manager::getHostNamesWithCookies):
(Ewk_Cookie_Manager::getHTTPAcceptPolicy):
(Ewk_Cookie_Manager::cookiesDidChange):
(ewk_cookie_manager_persistent_storage_set):
(ewk_cookie_manager_accept_policy_set):
(Get_Policy_Async_Data):
(Get_Policy_Async_Data::Get_Policy_Async_Data):
(ewk_cookie_manager_async_accept_policy_get):
(Get_Hostnames_Async_Data):
(Get_Hostnames_Async_Data::Get_Hostnames_Async_Data):
(ewk_cookie_manager_async_hostnames_with_cookies_get):
(ewk_cookie_manager_hostname_cookies_clear):
(ewk_cookie_manager_cookies_clear):
(ewk_cookie_manager_changes_watch):

  • UIProcess/API/efl/ewk_cookie_manager_private.h:

(Ewk_Cookie_Manager):

3:38 AM Changeset in webkit [132001] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] Make Ewk intent classes members private
https://bugs.webkit.org/show_bug.cgi?id=99832

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-21
Reviewed by Kenneth Rohde Christiansen.

Make Ewk_Intent and Ewk_Intent_Service members
private and add class methods to get them.

  • UIProcess/API/efl/ewk_intent.cpp:

(Ewk_Intent::Ewk_Intent):
(Ewk_Intent::webIntentData):
(Ewk_Intent::action):
(Ewk_Intent::type):
(Ewk_Intent::service):
(Ewk_Intent::suggestions):
(Ewk_Intent::extra):
(Ewk_Intent::extraKeys):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):

  • UIProcess/API/efl/ewk_intent_private.h:

(WebKit):
(Ewk_Intent):

  • UIProcess/API/efl/ewk_intent_service.cpp:

(Ewk_Intent_Service::Ewk_Intent_Service):
(Ewk_Intent_Service::action):
(Ewk_Intent_Service::type):
(Ewk_Intent_Service::href):
(Ewk_Intent_Service::title):
(Ewk_Intent_Service::disposition):
(ewk_intent_service_action_get):
(ewk_intent_service_type_get):
(ewk_intent_service_href_get):
(ewk_intent_service_title_get):
(ewk_intent_service_disposition_get):

  • UIProcess/API/efl/ewk_intent_service_private.h:

(Ewk_Intent_Service):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_intent_deliver):

3:36 AM Changeset in webkit [132000] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] Make Ewk_Download_Job members private and remove private C functions
https://bugs.webkit.org/show_bug.cgi?id=99697

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-21
Reviewed by Kenneth Rohde Christiansen.

Make Ewk_Download_Job private and replace private C functions
by class methods. New methods were also added to match the
public C API.

  • UIProcess/API/efl/ewk_context.cpp:

(ewk_context_download_job_add):

  • UIProcess/API/efl/ewk_context_download_client.cpp:

(decideDestinationWithSuggestedFilename):
(didReceiveResponse):
(didCreateDestination):
(didReceiveData):
(didFail):
(didCancel):
(didFinish):

  • UIProcess/API/efl/ewk_download_job.cpp:

(Ewk_Download_Job::Ewk_Download_Job):
(Ewk_Download_Job::id):
(Ewk_Download_Job::view):
(ewk_download_job_state_get):
(Ewk_Download_Job::state):
(ewk_download_job_request_get):
(Ewk_Download_Job::request):
(ewk_download_job_response_get):
(Ewk_Download_Job::response):
(ewk_download_job_destination_get):
(Ewk_Download_Job::destination):
(ewk_download_job_destination_set):
(Ewk_Download_Job::setDestination):
(ewk_download_job_suggested_filename_get):
(Ewk_Download_Job::suggestedFileName):
(ewk_download_job_cancel):
(Ewk_Download_Job::cancel):
(ewk_download_job_estimated_progress_get):
(Ewk_Download_Job::estimatedProgress):
(ewk_download_job_elapsed_time_get):
(Ewk_Download_Job::elapsedTime):
(Ewk_Download_Job::setResponse):
(Ewk_Download_Job::setSuggestedFileName):
(Ewk_Download_Job::incrementReceivedData):
(Ewk_Download_Job::setState):

  • UIProcess/API/efl/ewk_download_job.h:
  • UIProcess/API/efl/ewk_download_job_private.h:

(Ewk_Download_Job):

3:27 AM Changeset in webkit [131999] by robert@webkit.org
  • 3 edits
    2 adds in trunk

In some float situations, the original layout is wrong and only corrects itself on repaint
https://bugs.webkit.org/show_bug.cgi?id=18939

Reviewed by Levi Weintraub.

Source/WebCore:

A <br> that follows collapsing spaces and has clearance set always needs to get a run and a linebox of its own.
This allows the line below it to check for clearance from the <br> if it gets dirtied but the line with the <br>
does not.

Test: fast/block/br-with-clearance-after-collapsing-space.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

  • fast/block/br-with-clearance-after-collapsing-space-expected.html: Added.
  • fast/block/br-with-clearance-after-collapsing-space.html: Added.
2:44 AM Changeset in webkit [131998] by robert@webkit.org
  • 3 edits
    2 adds in trunk

floated element with negative margin causes text wrap bug
https://bugs.webkit.org/show_bug.cgi?id=94825

Reviewed by Levi Weintraub.

Source/WebCore:

Avoid over-estimating the available width on the line by ensuring that the offset taken to avoid
floats on the line is at least as much as the offset given by border, margin and padding. This only
happens when a negative margin on the float brings its edge back before the offset
given by the border, margin and padding of its parents.

Test: fast/block/float/float-on-line-obeys-container-padding.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

LayoutTests:

  • fast/block/float/float-on-line-obeys-container-padding.html: Added.
  • fast/block/float/float-on-line-obeys-container-padding-expected.html: Added.
2:11 AM Changeset in webkit [131997] by rakuco@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix 'make dist' for the GTK+ port

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-10-20

  • GNUmakefile.list.am: Add missing files to the source list.

Oct 20, 2012:

11:31 PM Changeset in webkit [131996] by Martin Robinson
  • 7 edits in trunk/Source

Fix 'make dist' for the GTK+ port

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing files to the source list.

Source/WebCore:

  • GNUmakefile.am: Add missing files to the source list.
  • GNUmakefile.list.am: Ditto.

Source/WTF:

  • GNUmakefile.list.am: Add missing files to the source list.
6:57 PM Changeset in webkit [131995] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/12512710> [mac] Text with zero font size renders as 12px sometimes
https://bugs.webkit.org/show_bug.cgi?id=99918

Reviewed by Geoff Garen.

Source/WebCore:

-[NSFont fontWithName:size:] returns an NSFont of size 12 (the default User Font size) when
asked for size 0, and this is what Font::drawGlyphs uses to draw the text.

Test: fast/text/zero-font-size-2.html

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs): Added an early return if the size is zero.

LayoutTests:

  • fast/text/zero-font-size-2-expected.html: Added.
  • fast/text/zero-font-size-2.html: Added.
6:31 PM Changeset in webkit [131994] by fmalita@chromium.org
  • 7 edits
    3 copies
    4 adds
    5 deletes in trunk/LayoutTests

[Chromium] Unreviewed rebaselines after http://trac.webkit.org/changeset/131974, take two.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt.
  • platform/chromium-mac-lion/svg/custom/pattern-scaling-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-scaling-expected.txt: Added.
  • platform/chromium-mac/svg/custom/pattern-scaling-expected.txt: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-creation-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/pattern-scaling-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/pattern-with-transformation-expected.png: Removed.
  • platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
  • platform/chromium-win-xp/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
4:08 PM Changeset in webkit [131993] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Clean up QualifiedName-as-hash-key scenario.
<http://webkit.org/b/99394>

Reviewed by Anders Carlsson.

Cache the hash on QualifiedNameImpl after the first time it's computed.
This grows QualifiedNameImpl by 4 bytes on 32-bit (no change on 64-bit due to base class padding)
which I believe is fine, since QualifiedName is a shared object.

Add a global nullQName() function that returns a QualifiedName(nullAtom, nullAtom, nullAtom)
and use this to implement HashTraits<QualifiedName>::emptyValue(). The old implementation would
create a new QualifiedName(nullAtom, nullAtom, nullAtom) each time, which had to be hashed,
added to the global QualifiedName cache, etc.

Finally, don't have SVGAttributeHashTranslator create a temporary QualifiedName just to compute
the hash of a (namespace, prefix, localName) tuple, use QualifiedNameComponents and hashComponents()
directly instead.

Altogether this shaves ~100ms off of the RoboHornet svgresize.html benchmark on my MBP.

  • dom/QualifiedName.cpp:

(WebCore::nullQName):
(WebCore::QualifiedName::QualifiedNameImpl::computeHash):

  • dom/QualifiedName.h:

(QualifiedNameImpl):
(WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
(WebCore::QualifiedNameHash::hash):

  • svg/SVGElement.h:

(WebCore::SVGAttributeHashTranslator::hash):

3:44 PM Changeset in webkit [131992] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] m_mainFrame should be null checked before use in WebPagePrivate destructor
https://bugs.webkit.org/show_bug.cgi?id=99916

Patch by Andrew Lo <anlo@rim.com> on 2012-10-20
Reviewed by George Staikos.
Internally reviewed by Arvid Nilsson.

Internal PR228029
Add null checks for m_mainFrame for things that happen during
WebPage destruction.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setVisible):
(BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):

2:45 PM Changeset in webkit [131991] by rakuco@webkit.org
  • 7 edits in trunk

[EFL][DRT] Implement tracking and painting repaint rectangles.
https://bugs.webkit.org/show_bug.cgi?id=99838

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Add the required DumpRenderTreeSupport plumbing functions to
interact with FrameView and track/obtain repaint rectangles for
DumpRenderTree.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled):
(DumpRenderTreeSupportEfl::setTracksRepaints):
(DumpRenderTreeSupportEfl::resetTrackedRepaints):
(DumpRenderTreeSupportEfl::isTrackingRepaints):
(DumpRenderTreeSupportEfl::trackedRepaintRects):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement displayWebView() and start tracking/painting the repaint
rectangles for the repaint tests that rely on it.

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(displayWebView):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView):

2:27 PM Changeset in webkit [131990] by andersca@apple.com
  • 30 edits in trunk/Source/WebKit2

Remove ::encode template specializations and just use overloads
https://bugs.webkit.org/show_bug.cgi?id=99865

Reviewed by Andreas Kling.

Get rid of the various encode functions and just use overloading instead.

  • Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::encode):

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::encodeVariableLengthByteArray):
(CoreIPC::ArgumentEncoder::encode):

  • Platform/CoreIPC/ArgumentEncoder.h:

(ArgumentEncoder):
(CoreIPC::ArgumentEncoder::encodeEnum):

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::sendOutgoingMessage):

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::encode):

  • Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::Handle::encode):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):

  • Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode):

  • Shared/Plugins/NPIdentifierData.cpp:

(WebKit::NPIdentifierData::encode):
(WebKit::NPIdentifierData::decode):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::encode):

  • Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::encode):

  • Shared/mac/KeychainAttribute.cpp:

(CoreIPC::encode):

  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::encode):

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::HandleArray::encode):

  • Shared/mac/SecItemRequestData.cpp:

(WebKit::SecItemRequestData::encode):

  • Shared/mac/SecItemResponseData.cpp:

(WebKit::SecItemResponseData::encode):

  • Shared/mac/SecKeychainItemRequestData.cpp:

(WebKit::SecKeychainItemRequestData::encode):

  • Shared/mac/SecKeychainItemResponseData.cpp:

(WebKit::SecKeychainItemResponseData::encode):

  • Shared/qt/ArgumentCodersQt.cpp:

(CoreIPC::::encode):

  • Shared/qt/QtNetworkReplyData.cpp:

(WebKit::QtNetworkReplyData::encode):

  • Shared/soup/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::encode):

  • Shared/win/LayerTreeContextWin.cpp:

(WebKit::LayerTreeContext::encode):

  • Shared/win/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::encode):

  • Shared/win/WindowGeometry.cpp:

(WebKit::WindowGeometry::encode):

  • WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::encodeBool):
(WebKit::EncoderAdapter::encodeUInt16):
(WebKit::EncoderAdapter::encodeUInt32):
(WebKit::EncoderAdapter::encodeUInt64):
(WebKit::EncoderAdapter::encodeInt32):
(WebKit::EncoderAdapter::encodeInt64):
(WebKit::EncoderAdapter::encodeFloat):
(WebKit::EncoderAdapter::encodeDouble):
(WebKit::EncoderAdapter::encodeString):

1:06 PM Changeset in webkit [131989] by fpizlo@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

LLInt backends of non-ARM RISC platforms should be able to share code with the existing ARMv7 backend
https://bugs.webkit.org/show_bug.cgi?id=99745

Reviewed by Geoffrey Garen.

This moves all of the things in armv7.rb that I thought are generally useful out
into risc.rb. It also separates some phases (branch ops is separated into one
phase that does sensible things, and another that does things that are painfully
ARM-specific), and removes ARM assumptions from others by using a callback to
drive exactly what lowering must happen. The goal here is to minimize the future
maintenance burden of LLInt by ensuring that the various platforms share as much
lowering code as possible.

  • offlineasm/armv7.rb:
  • offlineasm/risc.rb: Added.
9:03 AM Changeset in webkit [131988] by rakuco@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

[EFL] Add missing expectations for some tests in svg/custom.

  • platform/efl/svg/custom/js-late-pattern-creation-expected.png: Added.
  • platform/efl/svg/custom/js-late-pattern-creation-expected.txt: Added.
  • platform/efl/svg/custom/pattern-skew-transformed-expected.png: Added.
  • platform/efl/svg/custom/pattern-with-transformation-expected.png: Added.
  • platform/efl/svg/custom/pattern-with-transformation-expected.txt: Added.
7:29 AM Changeset in webkit [131987] by fmalita@chromium.org
  • 8 edits
    15 adds
    3 deletes in trunk/LayoutTests

Unreviewed rebaseline after http://trac.webkit.org/changeset/131974.

  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
  • platform/chromium-mac-lion/svg/custom/js-late-pattern-creation-expected.png: Added.
  • platform/chromium-mac-lion/svg/custom/pattern-scaling-expected.png: Added.
  • platform/chromium-mac-lion/svg/custom/pattern-with-transformation-expected.png: Added.
  • platform/chromium-mac-lion/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
  • platform/chromium-mac-lion/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-scaling-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed.
  • platform/chromium-mac/svg/custom/pattern-scaling-expected.png: Added.
  • platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-creation-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/pattern-scaling-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/pattern-with-transformation-expected.png: Added.
  • platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win-xp/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium/TestExpectations:
3:58 AM Changeset in webkit [131986] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix compile warning.

  • UIProcess/API/gtk/tests/GNUmakefile.am: Pass sourcedir to

glib-compile-resource when generating dependencies too.

3:25 AM Changeset in webkit [131985] by mkwst@chromium.org
  • 1 edit
    12 moves
    5 adds
    2 deletes in trunk/LayoutTests

Cleanup: Move stacktrace tests to a subdirectory.
https://bugs.webkit.org/show_bug.cgi?id=99857

Reviewed by Pavel Feldman.

I plan on adding more than a few tests checking that stacktraces are
associated with console logs. This patch simply moves the four existing
tests into a subdirectory so that I don't spam http/tests/inspector with
stacktrace tests.

  • http/tests/inspector/stacktraces/csp-injected-content-warning-contains-stacktrace-expected.txt: Renamed from LayoutTests/http/tests/inspector/csp-injected-content-warning-contains-stacktrace-expected.txt.
  • http/tests/inspector/stacktraces/csp-injected-content-warning-contains-stacktrace.html: Renamed from LayoutTests/http/tests/inspector/csp-injected-content-warning-contains-stacktrace.html.
  • http/tests/inspector/stacktraces/csp-inline-warning-contains-stacktrace-expected.txt: Renamed from LayoutTests/http/tests/inspector/csp-inline-warning-contains-stacktrace-expected.txt.
  • http/tests/inspector/stacktraces/csp-inline-warning-contains-stacktrace.html: Renamed from LayoutTests/http/tests/inspector/csp-inline-warning-contains-stacktrace.html.
  • http/tests/inspector/stacktraces/csp-setInterval-warning-contains-stacktrace-expected.txt: Renamed from LayoutTests/http/tests/inspector/csp-setInterval-warning-contains-stacktrace-expected.txt.
  • http/tests/inspector/stacktraces/csp-setInterval-warning-contains-stacktrace.html: Renamed from LayoutTests/http/tests/inspector/csp-setInterval-warning-contains-stacktrace.html.
  • http/tests/inspector/stacktraces/csp-setTimeout-warning-contains-stacktrace-expected.txt: Renamed from LayoutTests/http/tests/inspector/csp-setTimeout-warning-contains-stacktrace-expected.txt.
  • http/tests/inspector/stacktraces/csp-setTimeout-warning-contains-stacktrace.html: Renamed from LayoutTests/http/tests/inspector/csp-setTimeout-warning-contains-stacktrace.html.
  • http/tests/inspector/stacktraces/resources/csp-inline-test.js: Renamed from LayoutTests/http/tests/inspector/resources/csp-inline-test.js.

(thisTest):

  • http/tests/inspector/stacktraces/resources/stacktrace-test.js: Renamed from LayoutTests/http/tests/inspector/resources/csp-test.js.

(test.addMessage):
(test):

  • platform/chromium/http/tests/inspector/stacktraces/csp-injected-content-warning-contains-stacktrace-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/inspector/csp-injected-content-warning-contains-stacktrace-expected.txt.
  • platform/chromium/http/tests/inspector/stacktraces/csp-inline-warning-contains-stacktrace-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/inspector/csp-inline-warning-contains-stacktrace-expected.txt.
  • platform/chromium/http/tests/inspector/stacktraces/csp-setInterval-warning-contains-stacktrace-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/inspector/csp-setInterval-warning-contains-stacktrace-expected.txt.
  • platform/chromium/http/tests/inspector/stacktraces/csp-setTimeout-warning-contains-stacktrace-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/inspector/csp-setTimeout-warning-contains-stacktrace-expected.txt.
3:15 AM Changeset in webkit [131984] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip the tests about regressions after r130699.
https://bugs.webkit.org/show_bug.cgi?id=99910

Unreviewed EFL gardening.

Unskip the test cases about regressions after r130699
fast/css/import-style-update.html
fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html
fast/events/attribute-listener-cloned-from-frameless-doc-context.html
fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
fast/events/attribute-listener-extracted-from-frameless-doc-context.html
fast/html/link-rel-stylesheet.html
fast/loader/data-url-encoding-html.html
fast/loader/data-url-encoding-svg.html
fast/spatial-navigation/snav-iframe-nested.html

It seems to be passing consistently now.

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-20

  • platform/efl/TestExpectations:
1:02 AM Changeset in webkit [131983] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][AC] Build fix after r131933
https://bugs.webkit.org/show_bug.cgi?id=99901

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-20
Reviewed by Kentaro Hara.

Add ArrayBoundsClamper.cpp to WebCore/CMakeLists.txt.

No new tests.

  • CMakeLists.txt:

Oct 19, 2012:

11:53 PM Changeset in webkit [131982] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

DFG should have some facility for recognizing redundant CheckArrays and Arrayifies
https://bugs.webkit.org/show_bug.cgi?id=99287

Reviewed by Mark Hahnenberg.

Adds reasoning about indexing type sets (i.e. ArrayModes) to AbstractValue, which
then enables us to fold away CheckArray's and Arrayify's that are redundant.

  • bytecode/ArrayProfile.cpp:

(JSC::arrayModesToString):
(JSC):

  • bytecode/ArrayProfile.h:

(JSC):
(JSC::mergeArrayModes):
(JSC::arrayModesAlreadyChecked):

  • bytecode/StructureSet.h:

(JSC::StructureSet::arrayModesFromStructures):
(StructureSet):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::AbstractValue):
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(AbstractValue):
(JSC::DFG::AbstractValue::setMostSpecific):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::filterArrayModes):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):
(JSC::DFG::AbstractValue::clobberArrayModes):
(JSC::DFG::AbstractValue::clobberArrayModesSlow):
(JSC::DFG::AbstractValue::setFuturePossibleStructure):
(JSC::DFG::AbstractValue::filterFuturePossibleStructure):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::modeAlreadyChecked):

  • dfg/DFGArrayMode.h:

(JSC::DFG::arrayModesFor):
(DFG):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::arrayify):

11:29 PM Changeset in webkit [131981] by abarth@webkit.org
  • 34 edits in trunk/Source/WebCore

[V8] V8DOMWrapper should avoid using its document parameter (so we can remove it soon)
https://bugs.webkit.org/show_bug.cgi?id=99876

Reviewed by Kentaro Hara.

We want to remove the document parameter to instantiateV8Object. There
isn't always a Document available, so it doesn't make sense to pass it
as a parameter. We're just waiting for a V8 API change so we can still
construct Node wrappers quickly.

This patch removes a use of the document that snuck in. Rather than
passing the ScriptExecutionContext around, we get it from the
CreationContext of the prototype object (and only when we actually need
it).

  • Modules/notifications/NotificationCenter.cpp:
  • Modules/notifications/NotificationCenter.h:

(NotificationCenter):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateConstructorGetter):
(GenerateImplementation):
(GenerateToV8Converters):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8PerContextData::constructorForTypeSlowCase):

  • bindings/v8/V8PerContextData.h:

(WebCore::V8PerContextData::createWrapperFromCache):
(WebCore::V8PerContextData::constructorForType):
(V8PerContextData):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initializeIfNeeded):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WebCore::WrapperTypeInfo::installPerContextPrototypeProperties):

11:28 PM Changeset in webkit [131980] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Change the title of inspector window when inspected page is changed
https://bugs.webkit.org/show_bug.cgi?id=99684

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-10-19
Reviewed by Gyuyoung Kim.

Implement platformInspectedURLChanged() to change the title of inspector window
when inspected page is changed.

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformInspectedURLChanged):

11:05 PM Changeset in webkit [131979] by mitz@apple.com
  • 7 edits
    3 adds in trunk

Add bundle API for hit-testing
https://bugs.webkit.org/show_bug.cgi?id=99907

Reviewed by Sam Weinig.

Source/WebKit2:

Test: TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCreateHitTestResult): Added this wrapper.

  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::hitTest): Added. Hit tests at the given point, ignoring clipping.

  • WebProcess/WebPage/WebFrame.h:

(WebFrame): Declared hitTest.

Tools:

Added an API test for WKBundleFrameCreateHitTest().

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added InjectedBundleFrameHitTest.cpp,

InjectedBundleFrameHitTest_bundle.cpp, and link-with-title.html.

  • TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Checks that the message contains the
title of the link in link-with-title.html.
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp: Added.

(TestWebKitAPI::InjectedBundleFrameHitTestTest::InjectedBundleFrameHitTestTest):
(TestWebKitAPI::didFinishLoadForFrameCallback): Hit tests at (50, 50) and sends the link title
from the result back to the UI process.
(TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
(TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):

  • TestWebKitAPI/Tests/WebKit2/link-with-title.html: Added.
10:37 PM Changeset in webkit [131978] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Add API unit tests for scaling
https://bugs.webkit.org/show_bug.cgi?id=99451

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-19
Reviewed by Gyuyoung Kim.

Add API unit test for ewk_view_scale_set()/get() APIs.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

10:09 PM Changeset in webkit [131977] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Baseline JIT should not inline array allocations, to make them easier to instrument
https://bugs.webkit.org/show_bug.cgi?id=99905

Reviewed by Mark Hahnenberg.

This will make it easier to instrument array allocations for the purposes of profiling.
It also allows us to kill off a bunch of code. And, this doesn't appear to hurt
performance at all. That's expected because these days any hot allocation will end up
in the DFG JIT, which does inline these allocations.

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):

  • jit/JITInlineMethods.h:

(JSC):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array):

9:52 PM Changeset in webkit [131976] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Modify ewk_view_scale_set to public API
https://bugs.webkit.org/show_bug.cgi?id=99902

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-10-19
Reviewed by Gyuyoung Kim.

Modify ewk_view_scale_set to public API.

  • UIProcess/API/efl/ewk_view.h:
9:09 PM Changeset in webkit [131975] by kling@webkit.org
  • 2 edits in trunk/Source/WebKit2

Race condition in WebProcessProxy::handleGetPlugins().
<http://webkit.org/b/99903>
<rdar://problem/12541471>

Reviewed by Anders Carlsson.

Scope the Vector<PluginModuleInfo> so that all the destructors are guaranteed
to have run when sendDidGetPlugins() executes on the main thread.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::handleGetPlugins):

7:51 PM Changeset in webkit [131974] by fmalita@chromium.org
  • 12 edits
    3 adds in trunk

Incorrect pattern scaling
https://bugs.webkit.org/show_bug.cgi?id=99870

Reviewed by Dirk Schulze.

Source/WebCore:

The pattern space transform scale should reflect the tile_size(user space)
to tile_image_size ratio, instead of tile_size to absolute_tile_size.

Test: svg/custom/pattern-scaling.svg

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

LayoutTests:

  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-linux/svg/custom/pattern-scaling-expected.png: Added.
  • platform/chromium-linux/svg/custom/pattern-scaling-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • svg/custom/pattern-scaling.svg: Added.
7:33 PM Changeset in webkit [131973] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix some of the regression cause by the non-local variable reworking
https://bugs.webkit.org/show_bug.cgi?id=99896

Reviewed by Filip Pizlo.

The non0local variable reworking led to some of the optimisations performed by
the bytecode generator being dropped. This in turn put more pressure on the DFG
optimisations. This exposed a short coming in our double speculation propogation.
Now we try to distinguish between places where we should SpecDoubleReal vs generic
SpecDouble.

  • dfg/DFGPredictionPropagationPhase.cpp:

(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::speculatedDoubleTypeForPrediction):
(JSC::DFG::PredictionPropagationPhase::speculatedDoubleTypeForPredictions):
(JSC::DFG::PredictionPropagationPhase::propagate):

6:49 PM Changeset in webkit [131972] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

RenderFlexibleBox::preferredMainAxisContentExtentForChild can return a negative value
https://bugs.webkit.org/show_bug.cgi?id=97827

Reviewed by Ojan Vafai.

I'm pretty sure this isn't possible (logicalHeight and maxPreferredLogicalWidth should always include
border and padding), so just add an assert.

No new tests, the assert is for code clarity.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):

6:43 PM Changeset in webkit [131971] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Replace calls to updateLogicalHeight with calls to computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=99883

Reviewed by Ojan Vafai.

In RenderBox and RenderBlock, switch to using computeLogicalHeight instead of
saving the old height, calling update logical height, then restoring the old height.

No new tests, this is just a refactoring.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths): Simple replace.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight): Adjust for content height.
(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Adjust for content height.
(WebCore::RenderBox::availableLogicalHeightUsing): Adjust for content height.

6:16 PM Changeset in webkit [131970] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/canvas/webgl/array-bounds-clamping.html
failing on Chromium.

  • platform/chromium/TestExpectations:
6:07 PM Changeset in webkit [131969] by commit-queue@webkit.org
  • 15 edits
    31 adds in trunk

Implement setRangeText() on text controls
https://bugs.webkit.org/show_bug.cgi?id=91907

Patch by Pablo Flouret <pablof@motorola.com> on 2012-10-19
Reviewed by Kent Tamura.

Source/WebCore:

setRangeText() replaces a range of text with some other text, and
adjusts the existing selection according to its parameters.

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#dom-textarea/input-setrangetext

Tests: fast/forms/color/color-setrangetext.html

fast/forms/date/date-setrangetext.html
fast/forms/datetime/datetime-setrangetext.html
fast/forms/datetimelocal/datetimelocal-setrangetext.html
fast/forms/file/file-setrangetext.html
fast/forms/hidden/hidden-setrangetext.html
fast/forms/image/image-setrangetext.html
fast/forms/month/month-setrangetext.html
fast/forms/number/number-setrangetext.html
fast/forms/range/range-setrangetext.html
fast/forms/search/search-setrangetext.html
fast/forms/setrangetext.html
fast/forms/textarea/textarea-setrangetext.html
fast/forms/time/time-setrangetext.html
fast/forms/week/week-setrangetext.html

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction):

The GObject generator doesn't support function overloads, so skip the
version of setRangeText() that has only one argument, its behavior
can be emulated with the four-argument version.

  • html/InputType.cpp:

(WebCore::InputType::supportsSelectionAPI):
(WebCore):

  • html/InputType.h:

(InputType):

Add supportsSelectionAPI() which indicates whether the various
selection api functions like setRangeText, setSelectionRange, etc.
are supported by this input element.

  • html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::supportsSelectionAPI):
(WebCore):

  • html/BaseTextInputType.h:

(BaseTextInputType):

Text-based input types support the selection APIs.

  • html/EmailInputType.cpp:

(WebCore::EmailInputType::supportsSelectionAPI):
(WebCore):

  • html/EmailInputType.h:

(EmailInputType):

Email inputs don't support the selection APIs.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setRangeText):

  • html/HTMLInputElement.h:

(HTMLInputElement):

Add a setRangeText override which checks if it should apply to the
input type, and calls the actual implementation on the parent class.

  • html/HTMLInputElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setRangeText):

  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

setRangeText implementation.

LayoutTests:

  • fast/forms/color/color-setrangetext-expected.txt: Added.
  • fast/forms/color/color-setrangetext.html: Added.
  • fast/forms/date/date-setrangetext-expected.txt: Added.
  • fast/forms/date/date-setrangetext.html: Added.
  • fast/forms/datetime/datetime-setrangetext-expected.txt: Added.
  • fast/forms/datetime/datetime-setrangetext.html: Added.
  • fast/forms/datetimelocal/datetimelocal-setrangetext-expected.txt: Added.
  • fast/forms/datetimelocal/datetimelocal-setrangetext.html: Added.
  • fast/forms/file/file-setrangetext-expected.txt: Added.
  • fast/forms/file/file-setrangetext.html: Added.
  • fast/forms/hidden/hidden-setrangetext-expected.txt: Added.
  • fast/forms/hidden/hidden-setrangetext.html: Added.
  • fast/forms/image/image-setrangetext-expected.txt: Added.
  • fast/forms/image/image-setrangetext.html: Added.
  • fast/forms/month/month-setrangetext-expected.txt: Added.
  • fast/forms/month/month-setrangetext.html: Added.
  • fast/forms/number/number-setrangetext-expected.txt: Added.
  • fast/forms/number/number-setrangetext.html: Added.
  • fast/forms/range/range-setrangetext-expected.txt: Added.
  • fast/forms/range/range-setrangetext.html: Added.
  • fast/forms/resources/common-setrangetext.js: Added.

(runTestsShouldPass):
(runTestsShouldFail):

  • fast/forms/search/search-setrangetext-expected.txt: Added.
  • fast/forms/search/search-setrangetext.html: Added.
  • fast/forms/setrangetext-expected.txt: Added.
  • fast/forms/setrangetext.html: Added.
  • fast/forms/textarea/textarea-setrangetext-expected.txt: Added.
  • fast/forms/textarea/textarea-setrangetext.html: Added.
  • fast/forms/time/time-setrangetext-expected.txt: Added.
  • fast/forms/time/time-setrangetext.html: Added.
  • fast/forms/week/week-setrangetext-expected.txt: Added.
  • fast/forms/week/week-setrangetext.html: Added.
6:02 PM Changeset in webkit [131968] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro in StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=99782

Reviewed by Sam Weinig.

Removes last usage of HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro, so that in future there will be no temptation
to use it instead of adding a line to StyleBuilder.
Also removes redundant checks for inital and inherit (HANDLE_INHERIT_AND_INTIAL already returns in those cases).
I don't want to move this code into StyleBuilder until the FIXME that is already there is fixed.

Covered by many existing writing mode tests (eg. fast/html/details-writing-mode.html)

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::applyProperty):

5:55 PM Changeset in webkit [131967] by jsbell@chromium.org
  • 6 edits in trunk

IndexedDB: Hidden indexing events are visible to script via bubbling/capture
https://bugs.webkit.org/show_bug.cgi?id=96566

Reviewed by Tony Chang.

Source/WebCore:

Stop propagation of error events fired at internal indexing requests as a result of
aborting, as they should not be visible to scripts.

Test: storage/indexeddb/index-population.html

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::dispatchEvent):

  • Modules/indexeddb/IDBRequest.h:

(WebCore::IDBRequest::preventPropagation):
(IDBRequest):

LayoutTests:

Listen for unexpected events in both capture and bubble phases.

  • storage/indexeddb/resources/index-population.js:

(deleteSuccess):
(doSetVersion1):
(setVersion2):

5:36 PM Changeset in webkit [131966] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Remove .get() calls in assertions as suggested by Darin Adler.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::appendSublayer):
(PlatformCALayer::insertSublayer):
(PlatformCALayer::replaceSublayer):

5:19 PM Changeset in webkit [131965] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium] Double-tap defaults to zoom (should only do this on Android)
https://bugs.webkit.org/show_bug.cgi?id=99600

Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-10-19
Reviewed by Adam Barth.

Adds a web setting for enabling DoubleTapToZoom on a doubleTap gesture.
This gesture was just needed for mobile, and the patch that implemented it caused regressions on other platforms.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setDoubleTapToZoomEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

  • tests/WebFrameTest.cpp:
5:15 PM Changeset in webkit [131964] by Simon Fraser
  • 4 edits
    4 adds in trunk

Source/WebCore: Fix a hang when combining tile cache layers with preserve-3d or reflections
https://bugs.webkit.org/show_bug.cgi?id=99890
<rdar://problem/12539560>

Reviewed by Dean Jackson.

The new tile cache code added an updateSublayers() call when switching to/from
tiled layers. This confused later sublayer rebuilding, causing us to attempt to
add a layer as a child of itself, causing a hang in CA.

Fix by removing all the explicit calls to updateFoo when updating the structural
layer and switching to/from tiled layers. Instead, we set dirty flags, and rely
on the fact that these flag-dirtying functions get called before the later functions
that process those dirty flags. This is assured by some reordering of the update
function calls.

A final wrinkle is that ensureStructuralLayer() can change the layer that our
parent GraphicsLayer put in its sublayer list. Rather than diddle with that sublayer
list directly like we used to, just call noteSublayersChanged() on the parent, and have
commitLayerChangesAfterSublayers() check the ChildrenChanged and do a second update
of sublayers if necessary (we clear the flag in commitLayerChangesBeforeSublayers(), so
only do this work if a sublayer requested it).

Tests: compositing/tiling/preserve3d-tiled.html

compositing/tiling/reflected-tiled.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::commitLayerChangesAfterSublayers):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::appendSublayer): Add assertion about adding a layer to itself.
(PlatformCALayer::insertSublayer): Ditto.
(PlatformCALayer::replaceSublayer): Ditto.

LayoutTests: Fix a hang when combining tile cache layers with preserve-3d or reflections
https://bugs.webkit.org/show_bug.cgi?id=99890

Reviewed by Dean Jackson.

Tests that combine tiled layers with preserve-3d and reflections.

  • compositing/tiling/preserve3d-tiled-expected.txt: Added.
  • compositing/tiling/preserve3d-tiled.html: Added.
  • compositing/tiling/reflected-tiled-expected.txt: Added.
  • compositing/tiling/reflected-tiled.html: Added.
5:00 PM Changeset in webkit [131963] by beidson@apple.com
  • 6 edits in trunk/Source/WebKit2

WebProcess should only connect to the NetworkProcess if NetworkProcess is enabled
https://bugs.webkit.org/show_bug.cgi?id=99885

Reviewed by Alexey Proskuryakov.

WebContext should tell each WebProcess it creates whether NetworkProcess use is enabled.

Add a WebProcess initialization flag for whether or not NetworkProcess use is enabled:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

Include that info in the initialization parameters:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):

Store whether or not NetworkProcess use is enabled, and only connect to the NetworkProcess if appropriate:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensureNetworkProcessConnection):

  • WebProcess/WebProcess.h:
4:57 PM Changeset in webkit [131962] by commit-queue@webkit.org
  • 9 edits in trunk

Unreviewed, rolling out r131944.
http://trac.webkit.org/changeset/131944
https://bugs.webkit.org/show_bug.cgi?id=99891

On second thoughts, not such a great idea (Requested by jamesr
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-19

Source/Platform:

  • chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):

Source/WebKit/chromium:

  • public/WebView.h:

(WebKit):
(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::createNewWindow):

4:40 PM Changeset in webkit [131961] by eae@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-linux/platform/chromium/virtual/deferred: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium/TestExpectations:
4:37 PM Changeset in webkit [131960] by eae@chromium.org
  • 1 edit
    4 adds
    24 deletes in trunk/LayoutTests

Convert fast/innerHTML from pixel to ref tests
https://bugs.webkit.org/show_bug.cgi?id=99875

Reviewed by Dirk Pranke.

  • fast/innerHTML/001-expected.html: Added.
  • fast/innerHTML/002-expected.html: Added.
  • fast/innerHTML/003-expected.html: Added.
  • fast/innerHTML/006-expected.html: Added.
  • platform/chromium-linux/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-linux/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-linux/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-linux/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/001-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/002-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/003-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/006-expected.txt: Removed.
  • platform/chromium/fast/innerHTML/001-expected.txt: Removed.
  • platform/chromium/fast/innerHTML/002-expected.txt: Removed.
  • platform/chromium/fast/innerHTML/003-expected.txt: Removed.
  • platform/chromium/fast/innerHTML/006-expected.txt: Removed.
  • platform/efl/fast/innerHTML/001-expected.png: Removed.
  • platform/efl/fast/innerHTML/001-expected.txt: Removed.
  • platform/efl/fast/innerHTML/002-expected.png: Removed.
  • platform/efl/fast/innerHTML/002-expected.txt: Removed.
  • platform/efl/fast/innerHTML/003-expected.png: Removed.
  • platform/efl/fast/innerHTML/003-expected.txt: Removed.
  • platform/efl/fast/innerHTML/006-expected.png: Removed.
  • platform/efl/fast/innerHTML/006-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/001-expected.png: Removed.
  • platform/gtk/fast/innerHTML/001-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/002-expected.png: Removed.
  • platform/gtk/fast/innerHTML/002-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/003-expected.png: Removed.
  • platform/gtk/fast/innerHTML/003-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/006-expected.png: Removed.
  • platform/gtk/fast/innerHTML/006-expected.txt: Removed.
  • platform/mac/fast/innerHTML/001-expected.png: Removed.
  • platform/mac/fast/innerHTML/001-expected.txt: Removed.
  • platform/mac/fast/innerHTML/002-expected.png: Removed.
  • platform/mac/fast/innerHTML/002-expected.txt: Removed.
  • platform/mac/fast/innerHTML/003-expected.png: Removed.
  • platform/mac/fast/innerHTML/003-expected.txt: Removed.
  • platform/mac/fast/innerHTML/006-expected.png: Removed.
  • platform/mac/fast/innerHTML/006-expected.txt: Removed.
  • platform/qt/fast/innerHTML/001-expected.png: Removed.
  • platform/qt/fast/innerHTML/001-expected.txt: Removed.
  • platform/qt/fast/innerHTML/002-expected.png: Removed.
  • platform/qt/fast/innerHTML/002-expected.txt: Removed.
  • platform/qt/fast/innerHTML/003-expected.png: Removed.
  • platform/qt/fast/innerHTML/003-expected.txt: Removed.
  • platform/qt/fast/innerHTML/006-expected.png: Removed.
  • platform/qt/fast/innerHTML/006-expected.txt: Removed.
4:28 PM Changeset in webkit [131959] by Lucas Forschler
  • 6 edits in branches/safari-536.28-branch

Merge <rdar://problem/12523419>.

4:26 PM Changeset in webkit [131958] by beidson@apple.com
  • 18 edits
    7 copies
    2 adds in trunk/Source/WebKit2

Add infrastructure for NetworkProcess management
https://bugs.webkit.org/show_bug.cgi?id=99817

Reviewed by Alexey Proskuryakov.

Add support for the WebProcess itself requesting a connection to the default NetworkProcess.

Add proper handling of crashes so any of the Web/Network/UI processes crash the others take appropriate action.

Project file stuff and general messaging changes:

  • DerivedSources.make:
  • Platform/CoreIPC/MessageID.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC):
(CoreIPC::callMemberFunction): Add some new required templates.

WebContext now does much less of this stuff:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):

  • UIProcess/WebContext.h:

(WebContext):

UIProcess now has a process manager to handle most of this:

  • UIProcess/Network/NetworkProcessManager.cpp:

(WebKit):
(WebKit::NetworkProcessManager::shared):
(WebKit::NetworkProcessManager::NetworkProcessManager):
(WebKit::NetworkProcessManager::getNetworkProcessConnection):
(WebKit::NetworkProcessManager::ensureNetworkProcess):
(WebKit::NetworkProcessManager::removeNetworkProcessProxy):

  • UIProcess/Network/NetworkProcessManager.h:

(WebKit):
(NetworkProcessManager):

Flesh out the NetworkProcessProxy to handle creating these connections between Network and Web Processes:

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::create):
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
(WebKit):
(WebKit::NetworkProcessProxy::networkProcessCrashedOrFailedToLaunch):
(WebKit::NetworkProcessProxy::didReceiveMessage):
(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::didCreateNetworkConnectionToWebProcess):
(WebKit::NetworkProcessProxy::didFinishLaunching):

  • UIProcess/Network/NetworkProcessProxy.h:

(WebKit):
(NetworkProcessProxy):

  • UIProcess/Network/NetworkProcessProxy.messages.in:

Add a class representing a connection from a NetworkProcess to a particular WebProcess:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp: Added.

(WebKit):
(WebKit::NetworkConnectionToWebProcess::create):
(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::didReceiveInvalidMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveNetworkConnectionToWebProcessMessage):

  • NetworkProcess/NetworkConnectionToWebProcess.h:

(WebKit):
(NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::connection):

  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:

Add the ability for a NetworkProcess to create a connection for a different process, which is used on behalf of WebProcesses for now:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::removeNetworkConnectionToWebProcess):
(WebKit):
(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):

  • NetworkProcess/NetworkProcess.h:

(WebKit):
(NetworkProcess):

  • NetworkProcess/NetworkProcess.messages.in:

Forward on the message that a WebProcess wants a connection to a NetworkProcess:

  • UIProcess/WebProcessProxy.cpp:

(WebKit):
(WebKit::WebProcessProxy::getNetworkProcessConnection):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/WebProcessProxy.messages.in:

Add a class representing the WebProcesses connection to the NetworkProcess:

  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit):
(WebKit::NetworkProcessConnection::NetworkProcessConnection):
(WebKit::NetworkProcessConnection::~NetworkProcessConnection):
(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
(WebKit::NetworkProcessConnection::didClose):
(WebKit::NetworkProcessConnection::didReceiveInvalidMessage):

  • WebProcess/Network/NetworkProcessConnection.h:

(WebKit):
(NetworkProcessConnection):
(WebKit::NetworkProcessConnection::create):
(WebKit::NetworkProcessConnection::connection):

Have the WebProcess make sure it has a connection to the NetworkProcess, even though it currently does nothing with it:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit):
(WebKit::WebProcess::ensureNetworkProcessConnection):
(WebKit::WebProcess::networkProcessConnectionClosed):
(WebKit::WebProcess::networkProcessCrashed):

  • WebProcess/WebProcess.h:

(WebKit):
(WebProcess):

  • WebProcess/WebProcess.messages.in:
4:24 PM Changeset in webkit [131957] by Chris Fleizach
  • 13 edits in trunk

AX: aria-hidden=false does not work as expected
https://bugs.webkit.org/show_bug.cgi?id=98787

Reviewed by Beth Dakin.

Source/WebCore:

ARIA requires that aria-hidden=false override an element's native visibility and include that
node in the AX hierarchy.

To accomplish this we have to allow invisible items to be included, as well as items that
have no renderers associated with them.

Test: accessibility/aria-hidden-negates-no-visibility.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addTableCellChild):
(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore):

(WebCore::AccessibilityNodeObject::boundingBoxRect):

(WebCore::AccessibilityNodeObject::insertChild):
(WebCore::AccessibilityNodeObject::addChild):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::textUnderElement):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::textIteratorBehaviorForTextRange):
(WebCore):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
(WebCore::AccessibilityObject::addChild):
(WebCore::AccessibilityObject::insertChild):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

LayoutTests:

  • accessibility/aria-hidden-negates-no-visibility.html: Added.
  • platform/mac/accessibility/aria-hidden-negates-no-visibility-expected.txt: Added.
4:23 PM Changeset in webkit [131956] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Lexer should create 8 bit Identifiers for RegularExpressions and ASCII identifiers
https://bugs.webkit.org/show_bug.cgi?id=99855

Reviewed by Filip Pizlo.

Added makeIdentifier helpers that will always make an 8 bit Identifier or make an
Identifier that is the same size as the template parameter. Used the first in the fast
path when looking for a JS identifier and the second when scanning regular expressions.

  • parser/Lexer.cpp:

(JSC::::scanRegExp):

  • parser/Lexer.h:

(Lexer):
(JSC::::makeIdentifierSameType):
(JSC::::makeLCharIdentifier):
(JSC::::lexExpectIdentifier):

4:21 PM Changeset in webkit [131955] by msaboff@apple.com
  • 8 edits in trunk/Source

Add String version of visitedLinkHash() to properly handle 8-bit URL Strings.
https://bugs.webkit.org/show_bug.cgi?id=99735

Reviewed by Filip Pizlo.

Added String version of visitedLinkHash(). Made speculative addition of visitedLinkHash()
to chromium platform version of LinkHashChromium.cpp.
Changed calls in the form of visitedLinkHash(string.characters(), string.length()) to use the
new form.

No changes to functionality, so no new tests.

  • WebCore.exp.in:
  • loader/HistoryController.cpp:

(WebCore::addVisitedLink):

  • page/PageGroup.cpp:

(WebCore::PageGroup::addVisitedLink):

  • platform/LinkHash.cpp:

(WebCore::visitedLinkHashInline):
(WebCore::visitedLinkHash):

  • platform/LinkHash.h:
  • platform/chromium/LinkHashChromium.cpp:

(WebCore::visitedLinkHash):

4:19 PM Changeset in webkit [131954] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

String(CFStringRef) should try to converting to an 8 bit string before converting to 16 bit string
https://bugs.webkit.org/show_bug.cgi?id=99794

Reviewed by Filip Pizlo.

Try getting a Latin1 byte string before getting a UTF16 (UChar*) string.

No new test, added 8 bit path.

  • platform/text/cf/StringCF.cpp:

(WTF::String::String):

4:13 PM Changeset in webkit [131953] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Page should be removed from the cache right after restore was called.
https://bugs.webkit.org/show_bug.cgi?id=99737

Patch by Dima Gorbik <dgorbik@apple.com> on 2012-10-19
Reviewed by Brady Eidson.

The pageCache was inconsistent after the restoration for a period of time because the cachedFrame is being nulled,
but the page is still in the Cache. Now the page is being removed from the cache right after the restoration.
This issue was spotted in a custom built application using WebKit and unfortunately there is no way to test this
behavior in LayoutTests. All the current tests that exercise the page cache do pass.

No new tests.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

3:54 PM Changeset in webkit [131952] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WebGL] getUniformLocation fails for uniform array name without array brackets
https://bugs.webkit.org/show_bug.cgi?id=99854

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-19
Reviewed by Dean Jackson.

Before this patch, gl.getUniformLocation(program, "array[0]") would return the array
location, but gl.getUniformLocation(program, "array") would not. Now, the latter also
returns the array location.

In the process of adding a check to the following Khronos WebGL conformance test:
conformance/glsl/misc/glsl-long-variable-names.html

  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::getSymbolInfo):

Before, we used to check that the symbol size was greater than one to determine that the
symbol was an array. However, this doesn't identify arrays of length one. Now, we check
if the symbol name ends in "[0]", since ANGLE appends this suffix to array symbol
names.
If the symbol is an array, we strip off the "[0]" and add a symbol with just the base
name. We set the isArray flag on the symbol, so we don't lose the information that it is
an array.
Then, we create symbols for each array element like before. However, instead of
replacing the "0" in array[0]" with each index, we take the base name "array" and
append array brackets containing each index (e.g. "array" + "[7]").

  • platform/graphics/ANGLEWebKitBridge.h:

(ANGLEShaderSymbol):

Add isArray boolean to ANGLEShaderSymbol. Since array symbols don't end in "[0]"
anymore, this is the only way to identify arrays.

3:25 PM Changeset in webkit [131951] by mifenton@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Convert input style to int64_t
https://bugs.webkit.org/show_bug.cgi?id=99848

Reviewed by Yong Li.

PR 227381.

Switch input style mask to int64_t to match the the updated definition.

Reviewed Internally by Nima Ghanavatian.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::inputStyle):

  • WebKitSupport/InputHandler.h:

(InputHandler):

3:24 PM Changeset in webkit [131950] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] when building a shared library component build, we must not depend on WebCore

Unreviewed build fix.

  • WebKit.gyp:
3:11 PM Changeset in webkit [131949] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fix lint error in Qt TestExpectations file.

  • platform/qt-5.0-wk1/TestExpectations: Remove duplicate skip entry.
3:09 PM Changeset in webkit [131948] by eae@chromium.org
  • 1 edit
    31 adds in trunk/LayoutTests

Unreviewed gardening, rebaselining deferred image tests for r131928.

  • platform/chromium-mac-lion/platform/chromium/virtual/deferred: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/animated-gif-with-offsets-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/image-map-anchor-children-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-case-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/animated-gif-with-offsets-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/image-map-anchor-children-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-case-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/png-with-color-profile-expected.png: Added.
2:59 PM Changeset in webkit [131947] by Csaba Osztrogonác
  • 13 edits
    2 deletes in trunk

Unreviewed, rolling out r131915.
http://trac.webkit.org/changeset/131915
https://bugs.webkit.org/show_bug.cgi?id=98787

It broke the build on platforms with \!HAVE(ACCESSIBILITY)

Source/WebCore:

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::nodeIsTextControl):

  • accessibility/AXObjectCache.h:

(WebCore):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addChild):
(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::elementRect):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::textUnderElement):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::textIteratorBehaviorForTextRange):
(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

LayoutTests:

  • accessibility/aria-hidden-negates-no-visibility.html: Removed.
  • platform/chromium/TestExpectations:
  • platform/mac/accessibility/aria-hidden-negates-no-visibility-expected.txt: Removed.
2:55 PM Changeset in webkit [131946] by tony@chromium.org
  • 21 edits in trunk

Unreviewed, rolling out r131936.
http://trac.webkit.org/changeset/131936
https://bugs.webkit.org/show_bug.cgi?id=99717

Broke the clang build

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::requestAttachWindow):
(WebCore):
(WebCore::InspectorFrontendClientLocal::requestDetachWindow):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):

  • inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::requestSetDockSide):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::requestAttachWindow):
(WebCore):
(WebCore::InspectorFrontendHost::requestDetachWindow):
(WebCore::InspectorFrontendHost::requestSetDockSide):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/DockController.js:

(WebInspector.DockController):
(WebInspector.DockController.prototype.setDocked):
(WebInspector.DockController.prototype._innerSetDocked.set if):
(WebInspector.DockController.prototype._innerSetDocked):
(WebInspector.DockController.prototype._updateUI.get states):
(WebInspector.DockController.prototype._updateUI):
(WebInspector.DockController.prototype._toggleDockState):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setAttachedWindow):
(InspectorFrontendAPI.setDockSide):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.requestAttachWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestDetachWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):

  • inspector/front-end/externs.js:

(InspectorFrontendHostAPI.prototype.requestAttachWindow):
(InspectorFrontendHostAPI.prototype.requestDetachWindow):

Source/WebKit/chromium:

  • public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::requestDockWindow):
(WebKit::WebDevToolsFrontendClient::requestUndockWindow):

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::requestAttachWindow):
(WebKit):
(WebKit::InspectorFrontendClientImpl::requestDetachWindow):
(WebKit::InspectorFrontendClientImpl::requestSetDockSide):

  • src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
2:36 PM Changeset in webkit [131945] by commit-queue@webkit.org
  • 21 edits
    2 deletes in trunk/Source/WebKit2

Unreviewed, rolling out r131931.
http://trac.webkit.org/changeset/131931
https://bugs.webkit.org/show_bug.cgi?id=99871

Broke Safari exensions (Requested by smfr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-19

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::dispatchSyncMessage):

  • Platform/CoreIPC/Connection.h:

(Connection):
(CoreIPC::Connection::deprecatedSendSync):
(CoreIPC::Connection::deprecatedSend):

  • Platform/CoreIPC/MessageDecoder.cpp:

(CoreIPC::MessageDecoder::MessageDecoder):

  • Platform/CoreIPC/MessageDecoder.h:

(MessageDecoder):

  • Platform/CoreIPC/MessageEncoder.cpp:

(CoreIPC::MessageEncoder::create):
(CoreIPC::MessageEncoder::MessageEncoder):

  • Platform/CoreIPC/MessageEncoder.h:

(MessageEncoder):

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::dispatchMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • Platform/CoreIPC/StringReference.cpp: Removed.
  • Platform/CoreIPC/StringReference.h: Removed.
  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):

  • Scripts/webkit2/messages.py:

(message_to_struct_declaration):
(forward_declarations_and_headers):
(generate_messages_header):

  • Scripts/webkit2/messages_unittest.py:
  • Shared/CoreIPCSupport/WebContextMessageKinds.h:
  • Target.pri:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::deprecatedSend):
(WebKit::WebProcessProxy::send):

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
2:30 PM Changeset in webkit [131944] by aelias@chromium.org
  • 9 edits in trunk

[chromium] API to pass impl thread via WebLayerTreeView
https://bugs.webkit.org/show_bug.cgi?id=99863

Reviewed by James Robinson.

This adds an API to pass the compositor impl thread via WebView and
WebLayerTreeView. This is currently a no-op change, but in the future
this codepath will supercede WebCompositor. The goal is to avoid statics
in compositor initialization.

Source/Platform:

  • chromium/public/WebCompositorSupport.h:

(WebKit::WebCompositorSupport::createLayerTreeView):
(WebCompositorSupport):

  • chromium/public/WebLayerTreeView.h:

(WebKit):
(WebLayerTreeView):

Source/WebKit/chromium:

  • public/WebView.h:

(WebKit):
(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setCompositorImplThread):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::createNewWindow):

2:04 PM Changeset in webkit [131943] by eae@chromium.org
  • 1 edit
    21 adds in trunk/LayoutTests

Unreviewed gardening, rebaselining deferred image tests for r131928.

  • platform/chromium-mac/platform/chromium/virtual/deferred: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/animated-gif-with-offsets-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/image-map-anchor-children-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-case-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
2:02 PM Changeset in webkit [131942] by Martin Robinson
  • 4 edits in trunk

REGRESSION (r130699): 5 various fast/ tests started failing
https://bugs.webkit.org/show_bug.cgi?id=98729

Reviewed by Xan Lopez.

Source/WebCore:

Do not try to remove the URL fragment for data URLs. This will likely
just corrupt the URL.

No new tests. This unskips some previously failing tests.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::urlStringForSoup): Do nothing for data URLs.

LayoutTests:

Unskip some tests which are now passing.

  • platform/gtk/TestExpectations:
1:47 PM Changeset in webkit [131941] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[Cairo][WTR] Implement the painting of repaint rectangles.
https://bugs.webkit.org/show_bug.cgi?id=99839

Reviewed by Martin Robinson.

Implement the required code to paint the gray overlay with
transparent regions for the repaint rectangles, as other ports
already do and as is already done in most WK1 ports.

  • WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

1:43 PM Changeset in webkit [131940] by Simon Fraser
  • 7 edits in trunk/Source/WebCore

Use tile caches in place of CATiledLayer
https://bugs.webkit.org/show_bug.cgi?id=99806
<rdar://problem/6474145>

Reviewed by Tim Horton.

Have GraphicsLayerCA use TileCaches instead of CATiledLayer now for
layers that exceed the 2000px size threshold.

  • platform/graphics/TiledBacking.h:

(TiledBacking): Have normal getter and setter for the visible rect.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly): We need
to pass in an old visibleRect to commitLayerChangesBeforeSublayers(). Just use
our current visible rect, which result in no tile area work.
(WebCore::GraphicsLayerCA::computeVisibleRect): Make this const and have it
return the rect, for clarity.
(WebCore::GraphicsLayerCA::recursiveCommitChanges): Keep track of the old
visible rect, and use the change flags mechanism to ensure that we recompute
tile areas later.
When calling commitLayerChangesBeforeSublayers() on the mask layer, just pass
its own visible rect as the old visible rect.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Pass in the
oldVisibleRect so that updateVisibleRect() can use this to see how the
visibleRect is changing.
(WebCore::GraphicsLayerCA::adjustTiledLayerVisibleRect): This member function
compares the old and new visible rects, and extends the tile coverage area
in directions where more content is being exposed. It takes care to avoid
"jitter" in the visible rect deltas causing edge tiles to get created then
destroyed by keeping any extra padding that already exists in a direction
where more content is being exposed.
(WebCore::GraphicsLayerCA::updateVisibleRect): Call adjustTiledLayerVisibleRect()
and use the result to update the TiledBacking's visibleRect.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Create layers of type
LayerTypeTileCacheLayer instead of LayerTypeWebTiledLayer. Because tile
cache layers involve adding an extra layer to the hierarchy (the tile container),
we call updateSublayerList() when changing layer type.

  • platform/graphics/ca/GraphicsLayerCA.h: New m_sizeAtLastVisibleRectUpdate member

that is used to prevent the adjustTiledLayerVisibleRect() logic being confused by
size changes.
(WebCore::GraphicsLayerCA::visibleRect):

  • platform/graphics/ca/mac/TileCache.h: Have normal getter and setter for the visible rect.
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setVisibleRect): Renamed to setVisibleRect().

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges): Avoid doing work
for pages in the page cache, for which the root layer is unattached.
(WebCore::RenderLayerCompositor::frameViewDidScroll): visibleRectChanged() was renamed
to setVisibleRect().

1:33 PM Changeset in webkit [131939] by Beth Dakin
  • 6 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=99768
We should limit the tile cache coverage when a page can't take
advantage of fast tile scrolling anyway

Reviewed by Simon Fraser.

When sites can't use fast-scrolling, there is no need to inflate the
tile cache. In fact, we get a performance boost by keeping it small
on painting-intensive sites.

Instead of just looking a whether or not the FrameView
canHaveScrollbar(), consult
shouldUpdateScrollLayerPositionOnMainThread().

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

Expose shouldUpdateScrollLayerPositionOnMainThread().

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
(WebCore::ScrollingCoordinator::shouldUpdateScrollLayerPositionOnMainThread):
(WebCore):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

Bug fix. Should be bitwise and.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::tileCoverageRect):

1:09 PM Changeset in webkit [131938] by mark.lam@apple.com
  • 53 edits
    2 adds in trunk/Source

Added WTF::StackStats mechanism.
https://bugs.webkit.org/show_bug.cgi?id=99805.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added StackStats checkpoints and probes.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::append):
(JSC::visitChildren):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::mergeOpaqueRoots):
(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionalFinalizers):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

  • parser/Parser.h:

(JSC::Parser::canRecurse):

  • runtime/StringRecursionChecker.h:

(StringRecursionChecker):

Source/WebCore:

Added StackStats probes in layout methods.

  • dom/Document.cpp:

(WebCore::Document::updateLayout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layout):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::layout):

  • rendering/RenderDialog.cpp:

(WebCore::RenderDialog::layout):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::layout):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layout):

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::layout):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::layout):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::layout):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::layout):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::layout):

  • rendering/RenderMedia.cpp:

(WebCore::RenderMedia::layout):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::layout):

  • rendering/RenderObject.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layout):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::layout):

  • rendering/RenderReplica.cpp:

(WebCore::RenderReplica::layout):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layoutSpecialExcludedChild):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::layout):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::layout):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layout):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::layout):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::layout):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::layout):

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::layout):

  • rendering/svg/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::layout):

  • rendering/svg/RenderSVGHiddenContainer.cpp:

(WebCore::RenderSVGHiddenContainer::layout):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::layout):

  • rendering/svg/RenderSVGResourceMarker.cpp:

(WebCore::RenderSVGResourceMarker::layout):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::layout):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

Source/WTF:

Disabled by default. Should have no performance and memory cost when
disabled. To enable, #define ENABLE_STACK_STATS 1 in StackStats.h.
The output is currently hardcoded to be dumped in /tmp/stack-stats.log,
and is in the form of stack sample events. By default, it only logs
a sample event when a new high watermark value is encountered.

Also renamed StackBounds::recursiveCheck() to isSafeToRecurse().

  • WTF.xcodeproj/project.pbxproj:
  • wtf/StackBounds.h:

(StackBounds):
(WTF::StackBounds::size):
(WTF::StackBounds::isSafeToRecurse):

  • wtf/StackStats.cpp: Added.

(WTF):
(WTF::StackStats::initialize):
(WTF::StackStats::PerThreadStats::PerThreadStats):
(WTF::StackStats::CheckPoint::CheckPoint):
(WTF::StackStats::CheckPoint::~CheckPoint):
(WTF::StackStats::probe):
(WTF::StackStats::LayoutCheckPoint::LayoutCheckPoint):
(WTF::StackStats::LayoutCheckPoint::~LayoutCheckPoint):

  • wtf/StackStats.h: Added.

(WTF):
(StackStats):
(CheckPoint):
(WTF::StackStats::CheckPoint::CheckPoint):
(PerThreadStats):
(WTF::StackStats::PerThreadStats::PerThreadStats):
(LayoutCheckPoint):
(WTF::StackStats::LayoutCheckPoint::LayoutCheckPoint):
(WTF::StackStats::initialize):
(WTF::StackStats::probe):

  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):

  • wtf/WTFThreadData.h:

(WTFThreadData):
(WTF::WTFThreadData::stackStats):

1:09 PM Changeset in webkit [131937] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Move all keyboard type calculations into InputHandler.
https://bugs.webkit.org/show_bug.cgi?id=99847

Reviewed by Yong Li.

PR 227381.

Move all keyboard type calculations into webkit and avoid passing type
information to the webview.

Reviewed Internally by Nima Ghanavatian.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertInputTypeToVKBType):
(WebKit):
(BlackBerry::WebKit::InputHandler::setElementFocused):

1:03 PM Changeset in webkit [131936] by pfeldman@chromium.org
  • 19 edits in trunk/Source

Web Inspector: merge "docked" state into the "dock side" enum.
https://bugs.webkit.org/show_bug.cgi?id=99717

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Otherwise, it is hard to manage these inter-dependent flags.

  • inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::requestSetDockSide):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):

  • inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::requestSetDockSide):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/DockController.js:

(WebInspector.DockController):
(WebInspector.DockController.prototype._updateUI.get sides):
(WebInspector.DockController.prototype._updateUI):
(WebInspector.DockController.prototype._toggleDockState):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setAttachedWindow):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):

Source/WebKit/chromium:

  • public/WebDevToolsFrontendClient.h:
  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::requestSetDockSide):

  • src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

12:55 PM Changeset in webkit [131935] by eae@chromium.org
  • 3 edits
    2 adds
    4 deletes in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Removed.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
12:46 PM Changeset in webkit [131934] by jsbell@chromium.org
  • 3 edits
    3 adds in trunk

[V8] IndexedDB: Crash when lazy-indexing Date keys
https://bugs.webkit.org/show_bug.cgi?id=99860

Reviewed by Adam Barth.

Source/WebCore:

Missing a scope/context needed when digging values out of Date objects
in an indexing callback.

Test: storage/indexeddb/lazy-index-types.html

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromScriptValueAndKeyPath):

LayoutTests:

Add test for greedy/lazy indexing all different key types.

  • storage/indexeddb/lazy-index-types-expected.txt: Added.
  • storage/indexeddb/lazy-index-types.html: Added.
  • storage/indexeddb/resources/lazy-index-types.js: Added.

(test.request.onsuccess):
(test):
(onSuccess.request.onsuccess):
(onSuccess):
(onComplete):

12:45 PM Changeset in webkit [131933] by dino@apple.com
  • 15 edits
    4 adds in trunk

Shader translator needs option to clamp uniform array accesses in vertex shaders
https://bugs.webkit.org/show_bug.cgi?id=98977
https://code.google.com/p/angleproject/issues/detail?id=49

Reviewed by Alok Priyadarshi and Ken Russell.

Source/ThirdParty/ANGLE:

WebGL does not allow GLSL code to index a uniform array outside its bounds. Add a
flag to the ANGLE compiler to insert clamp statements around such indexing.
Since it is possible to access vec2/3/4 and mat2/3/4 components by array indexing,
they must be similarly clamped.

Unfortunately, it is currently not possible to always determine that the indexing is
operating on a uniform variable. For example, suppose we have "uniform mat4 a". ANGLE
is currently not able to tell us that the rvalue of "a[0]" is a uniform, just that
it has a size of 4. Therefore, the clamping is done on all indirect array indexing.

This will have a performance impact. Future enhancements may be able to determine
cases where the clamping is not necessary. Currently only direct indexing is skipped
(i.e. looking up a value using a constant index).

The clamp insertion is only performed on the GLSL output. Direct3D already guarantees
that out-of-bounds uniform array access returns a zero value.

  • ANGLE.xcodeproj/project.pbxproj:
  • Target.pri:
  • include/GLSLANG/ShaderLang.h: New compiler option.
  • src/compiler/ArrayBoundsClamper.cpp: Added.

(ArrayBoundsClamper::ArrayBoundsClamper):
(ArrayBoundsClamper::OutputClampingFunctionDefinition): Injects a clamping function for integers into GLSL source.
(ArrayBoundsClamper::MarkIndirectArrayBoundsForClamping): Examines the AST looking for non-direct array indexing.

  • src/compiler/ArrayBoundsClamper.h: Added.

(ArrayBoundsClamper):
(ArrayBoundsClamper::GetArrayBoundsClampDefinitionNeeded):
(ArrayBoundsClamper::SetArrayBoundsClampDefinitionNeeded): Marks the object as needing to output the clamping function.
(ArrayBoundsClamper::Cleanup): Resets the state so that subsequent runs start fresh.

  • src/compiler/Compiler.cpp:

(TCompiler::compile): Run the clamping code if the compile option was set.
(TCompiler::clearResults):
(TCompiler::getArrayBoundsClamper):

  • src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::visitBinary): If the expression has been flagged, insert an appropriate "clamp" statement.

  • src/compiler/ShHandle.h:

(TCompiler):

  • src/compiler/TranslatorESSL.cpp:

(TranslatorESSL::translate):

  • src/compiler/TranslatorGLSL.cpp:

(TranslatorGLSL::translate):

  • src/compiler/intermOut.cpp:

(TType::getCompleteString): Add array size to intermediate tree output.

  • src/compiler/intermediate.h:

(TIntermBinary::setAddIndexClamp): New flag for indicating a binary expression needs clamping.
(TIntermBinary::getAddIndexClamp):
(TIntermBinary):

Source/WebCore:

WebGL forbids out-of-bounds array access in shaders. Rewrite any shaders to
ensure that non-direct array indexing is clamped to the bounds of the array.

Test: fast/canvas/webgl/array-bounds-clamping.html

  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::ANGLEWebKitBridge::compileShaderSource): Pass new compiler option SH_CLAMP_INDIRECT_ARRAY_BOUNDS

LayoutTests:

  • fast/canvas/webgl/array-bounds-clamping-expected.txt: Added.
  • fast/canvas/webgl/array-bounds-clamping.html: Added.
  • platform/chromium/TestExpectations: Won't pass on Chromium until this patch is upstreamed.
12:34 PM Changeset in webkit [131932] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r131822): It made 500+ tests crash on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=99814

Reviewed by Filip Pizlo.

Call the correct macro in 32bit.

  • llint/LowLevelInterpreter.asm:
12:28 PM Changeset in webkit [131931] by andersca@apple.com
  • 21 edits
    1 copy
    1 add in trunk/Source/WebKit2

Don't use CStrings for message receiver names and message names
https://bugs.webkit.org/show_bug.cgi?id=99853

Reviewed by Andreas Kling.

Introduce StringReference which is similar to DataReference except it holds a pointer to + length of a char *
and can be created from a string literal. Use this in place of CString in MessageEncoder/MessageDecoder and
make MessageReceiverMap use a HashMap from StringReferences to MessageReceivers for global message receivers.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::dispatchSyncMessage):

  • Platform/CoreIPC/Connection.h:

(Connection):
(CoreIPC::Connection::deprecatedSendSync):
(CoreIPC::Connection::deprecatedSend):

  • Platform/CoreIPC/MessageDecoder.cpp:

(CoreIPC::MessageDecoder::MessageDecoder):

  • Platform/CoreIPC/MessageDecoder.h:

(CoreIPC::MessageDecoder::messageReceiverName):
(CoreIPC::MessageDecoder::messageName):
(MessageDecoder):

  • Platform/CoreIPC/MessageEncoder.cpp:

(CoreIPC::MessageEncoder::create):
(CoreIPC::MessageEncoder::MessageEncoder):

  • Platform/CoreIPC/MessageEncoder.h:

(CoreIPC):
(MessageEncoder):

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::addMessageReceiver):
(CoreIPC):
(CoreIPC::MessageReceiverMap::dispatchMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • Platform/CoreIPC/StringReference.cpp: Added.

(CoreIPC):
(CoreIPC::StringReference::encode):
(CoreIPC::StringReference::decode):
(CoreIPC::StringReference::Hash::hash):

  • Platform/CoreIPC/StringReference.h: Added.

(CoreIPC):
(StringReference):
(CoreIPC::StringReference::StringReference):
(CoreIPC::StringReference::isEmpty):
(CoreIPC::StringReference::size):
(CoreIPC::StringReference::data):
(CoreIPC::StringReference::operator==):
(Hash):
(CoreIPC::StringReference::Hash::equal):
(WTF):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):

  • Scripts/webkit2/messages.py:

(message_to_struct_declaration):
(forward_declarations_and_headers):
(generate_messages_header):

  • Scripts/webkit2/messages_unittest.py:
  • Shared/CoreIPCSupport/WebContextMessageKinds.h:
  • Target.pri:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::addMessageReceiver):
(WebKit):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::deprecatedSend):
(WebKit::WebProcessProxy::send):

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
12:21 PM Changeset in webkit [131930] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Reduce memory footprint of canvas pattern object with deferred rendering
https://bugs.webkit.org/show_bug.cgi?id=99856

Patch by Justin Novosad <junov@chromium.org> on 2012-10-19
Reviewed by Stephen White.

Marking internal bitmap copy as immutable to prevent it from being
unnecessarily duplicated in skia by SkBitmapHeap.

No new tests: code path already well covered by existing layout tests
fast/canvas/canvas-pattern-*

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformPattern):

12:18 PM Changeset in webkit [131929] by Antti Koivisto
  • 7 edits in trunk/Source/WebCore

Maintain a list of active CSS stylesheets
https://bugs.webkit.org/show_bug.cgi?id=99843

Reviewed by Andreas Kling.

Currently we maintain a per-document list of stylesheets that matches what is returned by the StyleSheetList DOM API.
This list contains both CSS and XSLT stylesheets which internally have basically nothing in common. Maintaining
a list of active CSS stylesheets separately simplifies code in number of places.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::collectCSSOMWrappers):

  • css/StyleResolver.h:

(StyleResolver):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::styleSheets):
(WebCore::StyleSheetList::detachFromDocument):

  • dom/Document.cpp:

(WebCore::Document::setCompatibilityMode):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::styleSheetsUseRemUnits):
(WebCore::filterEnabledCSSStyleSheets):
(WebCore):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::styleSheetsForStyleSheetList):
(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::activeAuthorStyleSheets):

12:06 PM Changeset in webkit [131928] by hclam@chromium.org
  • 21 edits
    13 adds in trunk

[chromium] Implement deferred image decoding
https://bugs.webkit.org/show_bug.cgi?id=94240

Reviewed by Stephen White.

Source/WebCore:

Objectives:

To record image decoding operations during painting and to defer
decoding operations until rasterization.

Rationale:

This is a key feature that enables impl-side painting which requires
fast recording of drawing operations. The existing decode-on-draw
restricts that recording has to block on expensive decoding operations.
This change allows recording of image decoding operations during paint
time.

Design:

Image decoding happens when a BitmapImage is drawn into a
GraphicsContext. When per-tile painting is enabled GraphicsContext
is backed by SkCanvas in recording mode. This SkCanvas records drawing
and image decoding operations to minimize recording time.

An image decoding operation is recorded as a SkPixelRef object
implemented by LazyDecodingPixelRef. This object references raw encoded
data, regions to be decoded and scaling information.

When used in conjunction with per-tile painting this feature defers
image decoding until the SkCanvas referencing the image is rasterized.

Both recording and rasterization happen on the main thread.

Performance Impact:

This feature is enabled by WebKit::setDeferredImageDecodingEnabled()
and does not have an impact when disabled.

This feature is disabled by default.

Upcoming Changes:

  1. Implement a full-featured image cache in ImageDecodingStore.
  2. Allow rasterization and decoding on impl thread.

Classes Involved:

BitmapImage

BitmapImage is the entry point for deferred image decoding. When
drawing a BitmapImage into a GraphicsContext it makes a request to
create a NativeImageSkia. We substitute the content in NativeImageSkia
such that it is lazily decoded.

DeferredImageDecoder

This is the platform implementation of a image decoder for Chromium.
This is a bridge layer that either delegates calls to the actual
ImageDecoder or create a lazily-decoded SkBitmap and delegates calls
to ImageDecodingStore.

ImageDecodingStore

This object manages all encoded images. It keeps track of encoded
data and the corresponding ImageDecoder for doing actual decoding. It
is also responsible for generating lazily decoded SkBitmaps. This
SkBitmap contains a LazyDecodingPixelRef object which references to an
image entry in ImageDecodingStore.

ScaledImageFragment

A container for a scaled image fragment. In addition to bitmap pixels
it contains information about the ID of the image, scale and clipping.

ImageFrameGenerator

This object is responsible for generating decoded pixels. It is also
a container for encoded image data and corresponding image decoder.

LazyDecodingPixelRef

This object is embedded in a SkBitmap to enable lazy decoding. When
SkBitmap needs to access pixels LazyDecodingPixelRef is locked. It
contains information to locate an image and scaling info, these
information is submitted to ImageDecodingStore to access actual pixels.

Layout tests. There are about 80 tests in this virtual test suite
running this feature in this directory:

platform/chromium/virtual/deferred/fast/images

Unit tests. Added DeferredImageDecoderTest to verify deferred
image decoding behavior.

  • WebCore.gypi:
  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::setData):

  • platform/graphics/ImageSource.h:

(WebCore):
(ImageSource):

  • platform/graphics/chromium/DeferredImageDecoder.cpp: Added.

(WebCore):
(WebCore::DeferredImageDecoder::DeferredImageDecoder):
(WebCore::DeferredImageDecoder::~DeferredImageDecoder):
(WebCore::DeferredImageDecoder::create):
(WebCore::DeferredImageDecoder::createForTesting):
(WebCore::DeferredImageDecoder::filenameExtension):
(WebCore::DeferredImageDecoder::frameBufferAtIndex):
(WebCore::DeferredImageDecoder::setData):
(WebCore::DeferredImageDecoder::isSizeAvailable):
(WebCore::DeferredImageDecoder::size):
(WebCore::DeferredImageDecoder::frameSizeAtIndex):
(WebCore::DeferredImageDecoder::frameCount):
(WebCore::DeferredImageDecoder::repetitionCount):
(WebCore::DeferredImageDecoder::clearFrameBufferCache):
(WebCore::DeferredImageDecoder::frameHasAlphaAtIndex):
(WebCore::DeferredImageDecoder::frameBytesAtIndex):

  • platform/graphics/chromium/DeferredImageDecoder.h: Added.

(WebCore):
(DeferredImageDecoder):

  • platform/graphics/chromium/ImageDecodingStore.cpp: Added.

(WebCore::ImageDecodingStore::ImageDecodingStore):
(WebCore):
(WebCore::ImageDecodingStore::~ImageDecodingStore):
(WebCore::ImageDecodingStore::instanceOnMainThread):
(WebCore::ImageDecodingStore::initializeOnMainThread):
(WebCore::ImageDecodingStore::shutdown):
(WebCore::ImageDecodingStore::isLazyDecoded):
(WebCore::ImageDecodingStore::createLazyDecodedSkBitmap):
(WebCore::ImageDecodingStore::resizeLazyDecodedSkBitmap):
(WebCore::ImageDecodingStore::setData):
(WebCore::ImageDecodingStore::lockPixels):
(WebCore::ImageDecodingStore::unlockPixels):
(WebCore::ImageDecodingStore::frameGeneratorBeingDestroyed):
(WebCore::ImageDecodingStore::calledOnValidThread):
(WebCore::ImageDecodingStore::lookupFrameCache):
(WebCore::ImageDecodingStore::deleteFrameCache):

  • platform/graphics/chromium/ImageDecodingStore.h: Added.

(WebCore):
(ImageDecodingStore):
(WebCore::ImageDecodingStore::create):

  • platform/graphics/chromium/ScaledImageFragment.cpp: Added.

(WebCore):
(WebCore::ScaledImageFragment::~ScaledImageFragment):
(WebCore::ScaledImageFragment::ScaledImageFragment):
(WebCore::ScaledImageFragment::isEqual):

  • platform/graphics/chromium/ScaledImageFragment.h: Added.

(WebCore):
(ScaledImageFragment):
(WebCore::ScaledImageFragment::create):
(WebCore::ScaledImageFragment::bitmap):
(WebCore::ScaledImageFragment::isComplete):

  • platform/graphics/chromium/ImageFrameGenerator.cpp: Added.

(WebCore):
(WebCore::ImageFrameGenerator::ImageFrameGenerator):
(WebCore::ImageFrameGenerator::~ImageFrameGenerator):
(WebCore::ImageFrameGenerator::decoder):
(WebCore::ImageFrameGenerator::setData):

  • platform/graphics/chromium/ImageFrameGenerator.h: Added.

(WebCore):
(ImageFrameGenerator):
(WebCore::ImageFrameGenerator::create):
(WebCore::ImageFrameGenerator::size):
(WebCore::ImageFrameGenerator::imageId):

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp: Added.

(WebCore):
(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::~LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::isScaled):
(WebCore::LazyDecodingPixelRef::isClipped):
(WebCore::LazyDecodingPixelRef::onLockPixels):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):
(WebCore::LazyDecodingPixelRef::onLockPixelsAreWritable):

  • platform/graphics/chromium/LazyDecodingPixelRef.h: Added.

(WebCore):
(LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::frameGenerator):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::resizedBitmap):

  • platform/image-decoders/ImageDecoder.h:

(ImageFrame):
(WebCore::ImageFrame::setSkBitmap):
(WebCore::ImageFrame::getSkBitmap):

Source/WebKit/chromium:

Adding new unit tests for deferred image decoding.
These tests are defined in DeferredImageDecoderTest.cpp. They verify
image decoding happens only when SkPicture is rasterized for both
scaled and non-scaled cases.

Tests: DeferredImageDecoderTest.drawIntoSkPicture

DeferredImageDecoderTest.drawScaledIntoSkPicture

  • WebKit.gypi:
  • public/WebSettings.h:
  • src/WebKit.cpp:

(WebKit::shutdown):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • tests/DeferredImageDecoderTest.cpp: Added.

(WebCore):
(DeferredImageDecoderTest):
(WebCore::DeferredImageDecoderTest::SetUp):
(WebCore::DeferredImageDecoderTest::TearDown):
(WebCore::TEST_F):

  • tests/MockImageDecoder.h: Added.

(WebCore):
(MockImageDecoder):
(WebCore::MockImageDecoder::MockImageDecoder):
(WebCore::MockImageDecoder::filenameExtension):
(WebCore::MockImageDecoder::frameBufferAtIndex):
(WebCore::MockImageDecoder::frameBufferRequestCount):

Tools:

Add --enable-deferred-image-decoding to DRT.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setDeferredImageDecodingEnabled):
(TestShell):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.virtual_test_suites):

LayoutTests:

Adding a virtual test suite for Chromium to test deferred image
decoding.

platform/chromium/virtual/deferred/fast/images will be tested with
--force-compositing --enable-per-tile-painting --enable-deferred-image-decoding.

  • platform/chromium/virtual/deferred/fast/images/README.txt: Added.
12:04 PM Changeset in webkit [131927] by hclam@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll DEPS

Unreviewed DEPS roll.

  • DEPS:
12:00 PM Changeset in webkit [131926] by eae@chromium.org
  • 1 edit
    25 adds in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-mac-lion/compositing/shadows: Added.
  • platform/chromium-mac-lion/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-mac-lion/css2.1: Added.
  • platform/chromium-mac-lion/css2.1/t0804-c5509-padn-l-03-f-g-expected.png: Added.
  • platform/chromium-mac-lion/css2.1/t090501-c414-flt-03-b-g-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
  • platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
  • platform/chromium-mac-lion/fast/block/float/032-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-baseline-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/placeholder-position-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/searchfield-heights-expected.png: Added.
  • platform/chromium-mac-lion/fast/inline-block: Added.
  • platform/chromium-mac-lion/fast/inline-block/contenteditable-baseline-expected.png: Added.
  • platform/chromium-mac-lion/platform: Added.
  • platform/chromium-mac-lion/platform/chromium: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/shadows: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-4-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug30692-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
11:53 AM Changeset in webkit [131925] by commit-queue@webkit.org
  • 41 edits in trunk

Rename ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT
https://bugs.webkit.org/show_bug.cgi?id=99804

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-19
Reviewed by Julien Chaffraix.

CSS3 text related properties will be implemented under this flag,
including text decoration, text-align-last, and text-justify.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new functionality, no new test.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.features.am:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::parseTextDecoration):

  • css/CSSPrimitiveValueMappings.h:

(WebCore):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

(WebCore):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
11:44 AM Changeset in webkit [131924] by eae@chromium.org
  • 3 edits
    6 adds in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/shadows: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
11:08 AM Changeset in webkit [131923] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Page viewport aspect ratio not kept on navigating back
https://bugs.webkit.org/show_bug.cgi?id=99760

Reviewed by Yong Li.
Patch by Jacky Jiang <zhajiang@rim.com>.
Internally reviewed by Konrad Piascik.

PR: 222437
This is to fix the second issue on PR222437 that the viewport not kept
when navigating back from google after rotation to bloomberg.
We were trying to restore the history contents size and scale of
bloomberg which has virtual viewport. The scale would be recalculated
based on the new screen size. However, we would still use the current
contents size if it was greater than the history contents size in
FrameView::setContentsSize which made the contents seem to be scaled
too much.
Actually when we relayout the contents after rotation change, the
current contents size which is based on the virtual viewport has taken
the screen size into account. Shrinking the contents size will be
expensive. So we can ignore screen size based scale calculation here.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

10:59 AM FeatureFlags edited by pablof@motorola.com
Added CSS3_CONDITIONAL_RULES (diff)
10:53 AM Changeset in webkit [131922] by eae@chromium.org
  • 689 edits
    194 adds
    8 deletes in trunk/LayoutTests

Unreviewed chromium rebaseline for r131503.

  • fast/forms/input-baseline-expected.txt: Added.
  • fast/forms/placeholder-position-expected.txt: Added.
  • platform/chromium-linux-x86/fast/inline-block: Added.
  • platform/chromium-linux-x86/fast/inline-block/contenteditable-baseline-expected.txt: Added.
  • platform/chromium-linux-x86/fast/text/international: Added.
  • platform/chromium-linux-x86/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-linux/fast/forms/007-expected.png:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.png:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-linux/fast/forms/input-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-linux/fast/html/details-add-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-marker-style-expected.png:
  • platform/chromium-linux/fast/html/details-nested-1-expected.png:
  • platform/chromium-linux/fast/html/details-nested-2-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary1-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary2-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary3-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary4-expected.png:
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png:
  • platform/chromium-linux/fast/html/details-open1-expected.png:
  • platform/chromium-linux/fast/html/details-open2-expected.png:
  • platform/chromium-linux/fast/html/details-open3-expected.png:
  • platform/chromium-linux/fast/html/details-open4-expected.png:
  • platform/chromium-linux/fast/html/details-open5-expected.png:
  • platform/chromium-linux/fast/html/details-open6-expected.png:
  • platform/chromium-linux/fast/html/details-position-expected.png:
  • platform/chromium-linux/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-linux/fast/html/details-replace-text-expected.png:
  • platform/chromium-linux/fast/html/details-replace-text-expected.txt:
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png:
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-linux/fast/inline-block/contenteditable-baseline-expected.txt: Added.
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/text/international/vertical-text-glyph-test-expected.png: Added.
  • platform/chromium-linux/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-mac-lion/css3: Added.
  • platform/chromium-mac-lion/css3/flexbox: Added.
  • platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/3690703-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/3690719-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/4397952-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/5240265-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/selection-button-text-expected.png: Added.
  • platform/chromium-mac-lion/fast: Added.
  • platform/chromium-mac-lion/fast/block: Added.
  • platform/chromium-mac-lion/fast/block/float: Added.
  • platform/chromium-mac-lion/fast/block/float/float-avoidance-expected.png: Added.
  • platform/chromium-mac-lion/fast/css: Added.
  • platform/chromium-mac-lion/fast/css/continuationCrash-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/margin-top-bottom-dynamic-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/rtl-ordering-expected.png: Added.
  • platform/chromium-mac-lion/fast/dom: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLTextAreaElement: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms: Added.
  • platform/chromium-mac-lion/fast/forms/001-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/007-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/basic-buttons-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/blankbuttons-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/button-sizes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/button-style-color-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/button-table-styles-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/button-text-transform-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/date: Added.
  • platform/chromium-mac-lion/fast/forms/date/date-reset-value-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/file: Added.
  • platform/chromium-mac-lion/fast/forms/file/file-input-direction-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/file/file-input-disabled-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/file/input-file-re-render-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/form-element-geometry-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/formmove3-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-button-sizes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-value-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/menulist-clip-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/targeted-frame-submission-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-mac-lion/fast/html: Added.
  • platform/chromium-mac-lion/fast/html/details-add-child-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-child-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-marker-style-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-nested-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-nested-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open3-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open4-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open5-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open6-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-position-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-child-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-child-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-replace-text-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-mac-lion/fast/images: Added.
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-mac-lion/fast/overflow: Added.
  • platform/chromium-mac-lion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Added.
  • platform/chromium-mac-lion/fast/overflow/scrollRevealButton-expected.png: Added.
  • platform/chromium-mac-lion/fast/replaced: Added.
  • platform/chromium-mac-lion/fast/replaced/replaced-breaking-expected.png: Added.
  • platform/chromium-mac-lion/fast/replaced/width100percent-button-expected.png: Added.
  • platform/chromium-mac-lion/fast/speech: Added.
  • platform/chromium-mac-lion/fast/sub-pixel: Added.
  • platform/chromium-mac-lion/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
  • platform/chromium-mac-lion/fast/text: Added.
  • platform/chromium-mac-lion/fast/text/international: Added.
  • platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/textIteratorNilRenderer-expected.png: Added.
  • platform/chromium-mac-lion/fast/writing-mode: Added.
  • platform/chromium-mac-lion/fast/writing-mode/fieldsets-expected.png: Added.
  • platform/chromium-mac-lion/http: Added.
  • platform/chromium-mac-lion/http/tests: Added.
  • platform/chromium-mac-lion/http/tests/navigation: Added.
  • platform/chromium-mac-lion/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-mac-lion/svg: Added.
  • platform/chromium-mac-lion/svg/as-border-image: Added.
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom: Added.
  • platform/chromium-mac-lion/svg/zoom/page: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-mac-lion/tables: Added.
  • platform/chromium-mac-lion/tables/mozilla: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1318-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug138725-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug26178-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug33855-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug39209-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug4429-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-1-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51727-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug60749-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/collapsing_borders: Added.
  • platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/dom: Added.
  • platform/chromium-mac-lion/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/other: Added.
  • platform/chromium-mac-lion/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5240265-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/007-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-reset-value-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
  • platform/chromium-mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.txt:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.txt:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.txt:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.txt:
  • platform/chromium-mac/editing/selection/5240265-expected.png:
  • platform/chromium-mac/editing/selection/5240265-expected.txt:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.txt:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/chromium-mac/fast/block/float/032-expected.png:
  • platform/chromium-mac/fast/block/float/032-expected.txt:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.txt:
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-mac/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac/fast/css/continuationCrash-expected.txt:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/chromium-mac/fast/forms/001-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.txt:
  • platform/chromium-mac/fast/forms/007-expected.png:
  • platform/chromium-mac/fast/forms/007-expected.txt:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.txt:
  • platform/chromium-mac/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac/fast/forms/button-style-color-expected.txt:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.txt:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.txt:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-mac/fast/forms/date/date-reset-value-expected.png: Added.
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.txt:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/formmove3-expected.png:
  • platform/chromium-mac/fast/forms/formmove3-expected.txt:
  • platform/chromium-mac/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.txt:
  • platform/chromium-mac/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.txt:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-details-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-details-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-marker-style-expected.png:
  • platform/chromium-mac/fast/html/details-marker-style-expected.txt:
  • platform/chromium-mac/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac/fast/html/details-nested-1-expected.txt:
  • platform/chromium-mac/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac/fast/html/details-nested-2-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary2-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-mac/fast/html/details-open1-expected.png:
  • platform/chromium-mac/fast/html/details-open1-expected.txt:
  • platform/chromium-mac/fast/html/details-open2-expected.png:
  • platform/chromium-mac/fast/html/details-open2-expected.txt:
  • platform/chromium-mac/fast/html/details-open3-expected.png:
  • platform/chromium-mac/fast/html/details-open3-expected.txt:
  • platform/chromium-mac/fast/html/details-open4-expected.png:
  • platform/chromium-mac/fast/html/details-open4-expected.txt:
  • platform/chromium-mac/fast/html/details-open5-expected.png:
  • platform/chromium-mac/fast/html/details-open5-expected.txt:
  • platform/chromium-mac/fast/html/details-open6-expected.png:
  • platform/chromium-mac/fast/html/details-open6-expected.txt:
  • platform/chromium-mac/fast/html/details-position-expected.png:
  • platform/chromium-mac/fast/html/details-position-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-mac/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac/fast/html/details-replace-text-expected.txt:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zoom-expected.txt:
  • platform/chromium-mac/fast/inline-block/contenteditable-baseline-expected.png:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/chromium-mac/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.txt:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-mac/table