Timeline
Nov 5, 2012:
- 11:47 PM Changeset in webkit [133567] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG should not fall down to patchable GetById just because a prototype had things added to it
https://bugs.webkit.org/show_bug.cgi?id=101299
Reviewed by Geoffrey Garen.
This looks like a slight win on V8v7 and SunSpider.
- bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 11:44 PM Changeset in webkit [133566] by
-
- 3 edits in trunk/Tools
webkit-patch rebaseline*: fix typo for --results-directory
https://bugs.webkit.org/show_bug.cgi?id=101295
Reviewed by Ojan Vafai.
Had --results_directory instead of --results-directory in both the
code and the unit test.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand._rebaseline_commands):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineJson.test_results_directory):
- 11:18 PM Changeset in webkit [133565] by
-
- 2 edits in trunk/Source/WebCore
Introduce Day class to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101194
Reviewed by Kent Tamura.
Introducing Day class so day, week, and month can all be abstracted. To
solve some of the complexity around which months to show, I made
CalendarPicker in charge of it. This also made YearMonthController and
DaysTable independent of each other.
No new tests. Covered by existing calendar-picker-*.html tests.
- Resources/pagepopups/calendarPicker.js:
(createUTCDate): Allow negative month or date.
(parseDateString): Will return Day or Month depending on string format.
(Day): Represents a day.
(Day.parse): Parse yyyy-mm-dd.
(Day.createFromDate): Creates a Day that contains a datetime.
(Day.createFromToday): Creates Day for today. A method with the same name will be added to Week and Month in the future.
(Day.prototype.equals): Returns true if they are the same.
(Day.prototype.previous): Returns the previous day.
(Day.prototype.next): Returns the next day.
(Day.prototype.startDate): Returns the datetime that is the start of this day.
(Day.prototype.endDate): Returns the datetime that is the start of this day.
(Day.prototype.valueOf): Returns the milliseconds since epoch.
(Day.prototype.toString): Returns an ISO date string.
(Month): Fix bug in calculating month from value.
(Month.prototype.endDate): Use Day.Maximum.
(CalendarPicker): Added _currentMonth. yearMonthController and daysTable can be private members now.
(CalendarPicker.prototype._layout):
(CalendarPicker.prototype.handleToday): Use Day.createFromToday.
(CalendarPicker.prototype.shouldShowMonth): Returns true if the month should be shown.
(CalendarPicker.prototype.showMonth): Shows the given month. If the month is out of the range of months that should be shown, we clamp the month and show that.
(CalendarPicker.prototype.currentMonth): Returns the current month that is shown.
(YearMonthController): Removed _currentMonth.
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype.setMonth):
(YearMonthController.prototype._handleYearMonthChange): Use CalendarPicker.showMonth
(YearMonthController.prototype.moveRelatively):
(DaysTable):
(CalendarPicker.prototype._stepMismatch): Made private.
(CalendarPicker.prototype._outOfRange): Made private.
(CalendarPicker.prototype.isValidDate): Take Day or Month instead of milliseconds since epoch.
(DaysTable.prototype._renderMonth):
(DaysTable.prototype.navigateToMonth): Shows a given month. Can use animation and leave the selection position as is.
(DaysTable.prototype.selectRange): Select a range.
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):
- 11:16 PM Changeset in webkit [133564] by
-
- 22 edits4 deletes in trunk/Source/JavaScriptCore
Get rid of method_check
https://bugs.webkit.org/show_bug.cgi?id=101147
Reviewed by Geoffrey Garen.
op_method_check no longer buys us anything, since get_by_id proto caching
gives just as much profiling information and the DFG inlines monomorphic
proto accesses anyway.
This also has the potential for a speed-up since it makes parsing of
profiling data easier. No longer do we have to deal with the confusion of
the get_by_id portion of a method_check appearing monomorphic even though
we're really dealing with a bimorphic access (method_check specializes for
one case and get_by_id for another).
This looks like a 1% speed-up on both SunSpider and V8v7.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::unlinkCalls):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::callLinkInfo):
(CodeBlock):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
- bytecode/MethodCallLinkInfo.cpp: Removed.
- bytecode/MethodCallLinkInfo.h: Removed.
- bytecode/MethodCallLinkStatus.cpp: Removed.
- bytecode/MethodCallLinkStatus.h: Removed.
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC):
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
- bytecompiler/NodesCodegen.cpp:
(JSC::FunctionCallDotNode::emitBytecode):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::PropertyStubCompilationInfo::slowCaseInfo):
(PropertyStubCompilationInfo):
(JSC):
(JIT):
- jit/JITPropertyAccess.cpp:
(JSC):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::compileGetByIdSlowCase):
- jit/JITPropertyAccess32_64.cpp:
(JSC):
(JSC::JIT::compileGetByIdSlowCase):
- jit/JITStubs.cpp:
(JSC):
- jit/JITStubs.h:
- llint/LowLevelInterpreter.asm:
- 10:43 PM Changeset in webkit [133563] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, Adding #if PLATFORM(CHROMIUM) for the fix of
https://bugs.webkit.org/show_bug.cgi?id=101009
This fix requires the most recent version of harfbuzz-ng.
EFL port uses version 0.9.2, which doesn't have the fix.
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
- 10:41 PM Changeset in webkit [133562] by
-
- 4 edits in trunk/Source/WebCore
Ensure acquireLineBreakIterator signature consistency on non-ICU ports.
https://bugs.webkit.org/show_bug.cgi?id=101281
Patch by Glenn Adams <glenn@skynav.com> on 2012-11-05
Reviewed by Ryosuke Niwa.
Fix (newly) inconsistent signature for acquireLineBreakIterator for non-ICU ports
caused by http://trac.webkit.org/changeset/133529.
See new tests added from https://bugs.webkit.org/show_bug.cgi?id=89235.
- platform/text/TextBreakIterator.cpp:
(WebCore::acquireLineBreakIterator):
- platform/text/gtk/TextBreakIteratorGtk.cpp:
(WebCore::setUpIterator):
(WebCore::acquireLineBreakIterator):
- platform/text/wince/TextBreakIteratorWinCE.cpp:
(WebCore::acquireLineBreakIterator):
- 10:25 PM Changeset in webkit [133561] by
-
- 2 edits in trunk/Source/WebCore
Use switch/case statements instead of if/elseif in CSSSelector.cpp
https://bugs.webkit.org/show_bug.cgi?id=100470
Reviewed by Ryosuke Niwa.
Minor clean up. We can get compiler warnings if we use switch/case statements here.
No changes to functionality, so no new tests.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
- 10:24 PM Changeset in webkit [133560] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed morning gardening, skip new failing tests.
- platform/qt/TestExpectations:
- 10:11 PM BuildingGtk edited by
- (diff)
- 10:06 PM Changeset in webkit [133559] by
-
- 3 edits in trunk/Tools
webkit-patch rebaseline*: fix handling of local file urls
https://bugs.webkit.org/show_bug.cgi?id=101296
Reviewed by Ojan Vafai.
When using --results-directory, we need to make sure we're converting
paths to file:/// urls for urllib to work correctly. Also, this
patch reworks the unit tests to get better coverage (of the execute()
command) and reduce copy/pasting of mock options.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.setUp):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test_with_results_directory):
(test_rebaseline_test_internal_with_move_overwritten_baselines_to):
- 9:52 PM Changeset in webkit [133558] by
-
- 10 edits in trunk/Source/WebKit2
Need a way to send and receive messages between the WKWebProcessPlugIn object and the client
https://bugs.webkit.org/show_bug.cgi?id=101282
Reviewed by Anders Carlsson.
API wise, this adds:
- A connection property on the WKWebProcessPlugInController
- A method to send messages across a WKConnection (sendMessageWithName:body).
It also implements message sending and receiving for WKConnection. Message bodies are currently
restricted to being object graphs with values that are property list types, but in the future, should
support all types conforming to the NSSecureCoding protocol.
- Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
(WebKit::WebConnection::handleMessage):
- Shared/WebConnection.h:
(WebConnection):
- Shared/WebConnection.messages.in:
Switch HandleMessage to be a variadic message to avoid an extra copy and support attachments correctly.
- Shared/mac/ArgumentCodersMac.h:
- Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::typeFromObject):
(CoreIPC::encode):
(CoreIPC::decode):
Add support for encoding/decoding NSArray, NSDate and NSData.
- UIProcess/API/mac/WKConnection.h:
- UIProcess/API/mac/WKConnection.mm:
(-[WKConnection sendMessageWithName:body:]):
(didReceiveMessage):
Implement message sending and receiving.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
(-[WKWebProcessPlugInController _initWithPrincipalClassInstance:bundleRef:]):
(-[WKWebProcessPlugInController connection]):
Add a wrapper for the WKConnectionRef vended via WKBundleGetApplicationConnection() and expose it as
API on the WKWebProcessPlugInController.
- 9:04 PM Changeset in webkit [133557] by
-
- 19 edits170 adds12 deletes in trunk/LayoutTests
Unreviewed gardening. Updating MathML chromium baselines.
- platform/chromium-linux-x86/mathml/presentation: Added.
- platform/chromium-linux-x86/mathml/presentation/attributes-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/attributes-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/fenced-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/fenced-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/fenced-mi-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/fenced-mi-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/fractions-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/fractions-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/mo-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/mo-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/mo-stretch-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/mroot-pref-width-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/mroot-pref-width-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/over-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/over-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/roots-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/roots-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/row-alignment-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/row-alignment-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/row-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/row-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/style-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/style-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/sub-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/sub-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/subsup-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/subsup-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/sup-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/sup-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/tables-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/tables-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/tokenElements-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/tokenElements-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/under-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/under-expected.txt: Added.
- platform/chromium-linux-x86/mathml/presentation/underover-expected.png: Added.
- platform/chromium-linux-x86/mathml/presentation/underover-expected.txt: Added.
- platform/chromium-linux-x86/mathml/xHeight-expected.txt:
- platform/chromium-linux/mathml/presentation: Added.
- platform/chromium-linux/mathml/presentation/attributes-expected.png: Added.
- platform/chromium-linux/mathml/presentation/attributes-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/fenced-expected.png: Added.
- platform/chromium-linux/mathml/presentation/fenced-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/fenced-mi-expected.png: Added.
- platform/chromium-linux/mathml/presentation/fenced-mi-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/fractions-expected.png: Added.
- platform/chromium-linux/mathml/presentation/fractions-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/chromium-linux/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/mo-expected.png: Added.
- platform/chromium-linux/mathml/presentation/mo-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/mo-stretch-expected.png: Added.
- platform/chromium-linux/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/mroot-pref-width-expected.png: Added.
- platform/chromium-linux/mathml/presentation/mroot-pref-width-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/over-expected.png: Added.
- platform/chromium-linux/mathml/presentation/over-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/roots-expected.png: Added.
- platform/chromium-linux/mathml/presentation/roots-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/row-alignment-expected.png: Added.
- platform/chromium-linux/mathml/presentation/row-alignment-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/row-expected.png: Added.
- platform/chromium-linux/mathml/presentation/row-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/style-expected.png: Added.
- platform/chromium-linux/mathml/presentation/style-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/sub-expected.png: Added.
- platform/chromium-linux/mathml/presentation/sub-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/subsup-expected.png: Added.
- platform/chromium-linux/mathml/presentation/subsup-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/sup-expected.png: Added.
- platform/chromium-linux/mathml/presentation/sup-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/tables-expected.png: Added.
- platform/chromium-linux/mathml/presentation/tables-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/tokenElements-expected.png: Added.
- platform/chromium-linux/mathml/presentation/tokenElements-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/under-expected.png: Added.
- platform/chromium-linux/mathml/presentation/under-expected.txt: Added.
- platform/chromium-linux/mathml/presentation/underover-expected.png: Added.
- platform/chromium-linux/mathml/presentation/underover-expected.txt: Added.
- platform/chromium-linux/mathml/xHeight-expected.txt:
- platform/chromium-mac-lion/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/chromium-mac-lion/mathml/presentation/row-alignment-expected.png:
- platform/chromium-mac-lion/mathml/presentation/row-alignment-expected.txt: Added.
- platform/chromium-mac-lion/mathml/presentation/subsup-expected.png:
- platform/chromium-mac-lion/mathml/presentation/subsup-expected.txt:
- platform/chromium-mac-lion/mathml/presentation/tables-expected.png:
- platform/chromium-mac-lion/mathml/presentation/tables-expected.txt: Added.
- platform/chromium-mac-snowleopard/mathml/presentation/mo-stretch-expected.txt:
- platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.png:
- platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.txt:
- platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.png:
- platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.txt:
- platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.png:
- platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.txt:
- platform/chromium-mac/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/chromium-mac/mathml/presentation/row-alignment-expected.png:
- platform/chromium-mac/mathml/presentation/row-alignment-expected.txt: Added.
- platform/chromium-mac/mathml/presentation/subsup-expected.png:
- platform/chromium-mac/mathml/presentation/subsup-expected.txt:
- platform/chromium-mac/mathml/presentation/tables-expected.png:
- platform/chromium-mac/mathml/presentation/tables-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation: Added.
- platform/chromium-win-xp/mathml/presentation/attributes-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/attributes-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/fenced-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/fenced-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/fenced-mi-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/fenced-mi-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/fractions-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/fractions-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/mo-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/mo-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/mo-stretch-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/mroot-pref-width-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/mroot-pref-width-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/over-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/over-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/roots-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/roots-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/row-alignment-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/row-alignment-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/row-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/row-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/style-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/style-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/sub-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/sub-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/subsup-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/subsup-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/sup-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/sup-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/tables-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/tables-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/tokenElements-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/tokenElements-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/under-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/under-expected.txt: Added.
- platform/chromium-win-xp/mathml/presentation/underover-expected.png: Added.
- platform/chromium-win-xp/mathml/presentation/underover-expected.txt: Added.
- platform/chromium-win/mathml/presentation: Added.
- platform/chromium-win/mathml/presentation/attributes-expected.png: Added.
- platform/chromium-win/mathml/presentation/attributes-expected.txt: Added.
- platform/chromium-win/mathml/presentation/fenced-expected.png: Added.
- platform/chromium-win/mathml/presentation/fenced-expected.txt: Added.
- platform/chromium-win/mathml/presentation/fenced-mi-expected.png: Added.
- platform/chromium-win/mathml/presentation/fenced-mi-expected.txt: Added.
- platform/chromium-win/mathml/presentation/fractions-expected.png: Added.
- platform/chromium-win/mathml/presentation/fractions-expected.txt: Added.
- platform/chromium-win/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/chromium-win/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
- platform/chromium-win/mathml/presentation/mo-expected.png: Added.
- platform/chromium-win/mathml/presentation/mo-expected.txt: Added.
- platform/chromium-win/mathml/presentation/mo-stretch-expected.png: Added.
- platform/chromium-win/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/chromium-win/mathml/presentation/mroot-pref-width-expected.png: Added.
- platform/chromium-win/mathml/presentation/mroot-pref-width-expected.txt: Added.
- platform/chromium-win/mathml/presentation/over-expected.png: Added.
- platform/chromium-win/mathml/presentation/over-expected.txt: Added.
- platform/chromium-win/mathml/presentation/roots-expected.png: Added.
- platform/chromium-win/mathml/presentation/roots-expected.txt: Added.
- platform/chromium-win/mathml/presentation/row-alignment-expected.png: Added.
- platform/chromium-win/mathml/presentation/row-alignment-expected.txt: Added.
- platform/chromium-win/mathml/presentation/row-expected.png: Added.
- platform/chromium-win/mathml/presentation/row-expected.txt: Added.
- platform/chromium-win/mathml/presentation/style-expected.png: Added.
- platform/chromium-win/mathml/presentation/style-expected.txt: Added.
- platform/chromium-win/mathml/presentation/sub-expected.png: Added.
- platform/chromium-win/mathml/presentation/sub-expected.txt: Added.
- platform/chromium-win/mathml/presentation/subsup-expected.png: Added.
- platform/chromium-win/mathml/presentation/subsup-expected.txt: Added.
- platform/chromium-win/mathml/presentation/sup-expected.png: Added.
- platform/chromium-win/mathml/presentation/sup-expected.txt: Added.
- platform/chromium-win/mathml/presentation/tables-expected.png: Added.
- platform/chromium-win/mathml/presentation/tables-expected.txt: Added.
- platform/chromium-win/mathml/presentation/tokenElements-expected.png: Added.
- platform/chromium-win/mathml/presentation/tokenElements-expected.txt: Added.
- platform/chromium-win/mathml/presentation/under-expected.png: Added.
- platform/chromium-win/mathml/presentation/under-expected.txt: Added.
- platform/chromium-win/mathml/presentation/underover-expected.png: Added.
- platform/chromium-win/mathml/presentation/underover-expected.txt: Added.
- platform/chromium/TestExpectations:
- platform/chromium/mathml/presentation/attributes-expected.png: Removed.
- platform/chromium/mathml/presentation/fractions-expected.png: Removed.
- platform/chromium/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
- platform/chromium/mathml/presentation/mo-expected.png: Removed.
- platform/chromium/mathml/presentation/mo-stretch-expected.png: Removed.
- platform/chromium/mathml/presentation/mroot-pref-width-expected.png: Removed.
- platform/chromium/mathml/presentation/over-expected.png: Removed.
- platform/chromium/mathml/presentation/roots-expected.png: Removed.
- platform/chromium/mathml/presentation/row-alignment-expected.png: Removed.
- platform/chromium/mathml/presentation/row-expected.png: Removed.
- platform/chromium/mathml/presentation/style-expected.png: Removed.
- platform/chromium/mathml/presentation/subsup-expected.png: Removed.
- 8:15 PM Changeset in webkit [133556] by
-
- 2 edits in trunk/Tools
Added secondary email address and IRC nick.
https://bugs.webkit.org/show_bug.cgi?id=101290
Unreviewed change to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 8:08 PM Changeset in webkit [133555] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Do not show error page for main loads denied by client application
https://bugs.webkit.org/show_bug.cgi?id=101287
Internal PR: 237574.
Internally reviewed by Arvid Nilsson, Joe Mason.
Patch by Lianghui Chen <liachen@rim.com> on 2012-11-05
Reviewed by George Staikos.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 7:46 PM Changeset in webkit [133554] by
-
- 7 edits in trunk/Source/WebKit2
[EFL][WK2] Fix wrong coding style in the boilerplates
https://bugs.webkit.org/show_bug.cgi?id=101283
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-05
Reviewed by Gyuyoung Kim.
Fix boilerplate which have wrong coding style.
- UIProcess/efl/InputMethodContextEfl.cpp:
- UIProcess/efl/InputMethodContextEfl.h:
- UIProcess/efl/PageClientDefaultImpl.cpp:
- UIProcess/efl/PageClientDefaultImpl.h:
- UIProcess/efl/PageClientLegacyImpl.cpp:
- UIProcess/efl/PageClientLegacyImpl.h:
- 7:46 PM Changeset in webkit [133553] by
-
- 1 edit16 adds in trunk/LayoutTests
[EFL][WK2][PixelTests] Add missing expectations
https://bugs.webkit.org/show_bug.cgi?id=101289
Unreviewed, EFL gardening.
Add 16 missing pixel test expectations.
Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-05
- platform/efl/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
- platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
- platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
- platform/efl/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
- platform/efl/compositing/overflow/scroll-ancestor-update-expected.png: Added.
- platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
- platform/efl/fast/forms/basic-inputs-expected.png: Added.
- platform/efl/fast/media/view-mode-media-feature-expected.png: Added.
- platform/efl/media/video-aspect-ratio-expected.png: Added.
- platform/efl/media/video-layer-crash-expected.png: Added.
- platform/efl/media/video-transformed-expected.png: Added.
- platform/efl/media/video-zoom-controls-expected.png: Added.
- platform/efl/media/video-zoom-expected.png: Added.
- platform/efl/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- 7:37 PM Changeset in webkit [133552] by
-
- 32 edits31 copies6 adds in trunk/LayoutTests
Unreviewed, update chromium-mac-mountainlion baselines for svg failures after r133538
- platform/chromium-mac-lion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png.
- platform/chromium-mac-lion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png.
- platform/chromium-mac-lion/svg/batik/filters/filterRegions-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/filters/filterRegions-expected.png.
- platform/chromium-mac-lion/svg/batik/masking/maskRegions-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/masking/maskRegions-expected.png.
- platform/chromium-mac-lion/svg/batik/paints/gradientLimit-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png.
- platform/chromium-mac-lion/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png.
- platform/chromium-mac-lion/svg/batik/paints/patternRegionA-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png.
- platform/chromium-mac-lion/svg/batik/paints/patternRegions-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternRegions-expected.png.
- platform/chromium-mac-lion/svg/batik/paints/patternRegions-positioned-objects-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png.
- platform/chromium-mac-lion/svg/batik/text/longTextOnPath-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/longTextOnPath-expected.png.
- platform/chromium-mac-lion/svg/batik/text/smallFonts-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/smallFonts-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textAnchor-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textAnchor-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textDecoration-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textDecoration-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textEffect-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textEffect-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textEffect2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textEffect2-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textEffect3-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textEffect3-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textFeatures-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textFeatures-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textLayout-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLayout-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textLayout2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLayout2-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textLength-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLength-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textOnPath-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textOnPath-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textOnPathSpaces-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textPosition-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textPosition-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textPosition2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textPosition2-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textProperties-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textProperties-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textProperties2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textProperties2-expected.png.
- platform/chromium-mac-lion/svg/batik/text/textStyles-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textStyles-expected.png.
- platform/chromium-mac-lion/svg/batik/text/verticalText-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/verticalText-expected.png.
- platform/chromium-mac-lion/svg/batik/text/verticalTextOnPath-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png.
- platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
- platform/chromium-mac/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-mac/svg/batik/masking/maskRegions-expected.png:
- platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
- platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
- platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png:
- platform/chromium-mac/svg/batik/paints/patternRegions-expected.png:
- platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
- platform/chromium-mac/svg/batik/text/longTextOnPath-expected.png:
- platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
- platform/chromium-mac/svg/batik/text/textAnchor-expected.png:
- platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
- platform/chromium-mac/svg/batik/text/textEffect-expected.png:
- platform/chromium-mac/svg/batik/text/textEffect2-expected.png:
- platform/chromium-mac/svg/batik/text/textEffect3-expected.png:
- platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
- platform/chromium-mac/svg/batik/text/textLayout-expected.png:
- platform/chromium-mac/svg/batik/text/textLayout2-expected.png:
- platform/chromium-mac/svg/batik/text/textLength-expected.png:
- platform/chromium-mac/svg/batik/text/textOnPath-expected.png:
- platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png:
- platform/chromium-mac/svg/batik/text/textPosition-expected.png:
- platform/chromium-mac/svg/batik/text/textPosition2-expected.png:
- platform/chromium-mac/svg/batik/text/textProperties-expected.png:
- platform/chromium-mac/svg/batik/text/textProperties2-expected.png:
- platform/chromium-mac/svg/batik/text/textStyles-expected.png:
- platform/chromium-mac/svg/batik/text/verticalText-expected.png:
- platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
- 7:12 PM Changeset in webkit [133551] by
-
- 8 edits in trunk/Source/JavaScriptCore
Refactor LLInt64 to distinguish the pointer operations from the 64-bit integer operations
https://bugs.webkit.org/show_bug.cgi?id=100321
Reviewed by Filip Pizlo.
We have refactored the MacroAssembler and JIT compilers to distinguish
the pointer operations from the 64-bit integer operations (see bug #99154).
Now we want to do the similar work for LLInt, and the goal is same as
the one mentioned in 99154.
This is the second part of the modification: in the low level interpreter,
changing the operations on 64-bit integers to use the "<foo>q" instructions.
This also removes some unused/meaningless "<foo>p" instructions.
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- llint/LowLevelInterpreter64.asm:
- offlineasm/armv7.rb:
- offlineasm/cloop.rb:
- offlineasm/instructions.rb:
- offlineasm/x86.rb:
- 7:04 PM Changeset in webkit [133550] by
-
- 3 edits2 adds in trunk
[Chromium] Unicode combining diacritical aren't always combined on Linux
https://bugs.webkit.org/show_bug.cgi?id=101009
Reviewed by Kent Tamura.
Source/WebCore:
Add a space character to harfbuzzBuffer as pre-context. This will prevent
harfbuzz from inserting dotted-circle.
Test: fast/text/international/combining-marks-position.html
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
LayoutTests:
Add a test that checks whether combining marks are combined with base characters.
- fast/text/international/combining-marks-position-expected.txt: Added.
- fast/text/international/combining-marks-position.html: Added.
- 6:46 PM BuildingGtk edited by
- (diff)
- 6:18 PM Changeset in webkit [133549] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
[l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
https://bugs.webkit.org/show_bug.cgi?id=100817
Patch by Sandeep Shedmake <sshedmak@redhat.com> on 2012-11-05
Rubber-stamped by Gustavo Noronha.
- mr.po: updated.
- 6:13 PM Changeset in webkit [133548] by
-
- 3 edits in trunk/Source/WebCore
LayoutTest fast/dom/shadow/shadowroot-type.html is failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=101201
Reviewed by Hajime Morita.
When we use a bit field for enum, Windows compiler seems returning some wrong value.
We would like to avoid using a bit field for enum value.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::type):
(WebCore::ShadowRoot::setType):
(ShadowRoot):
- 6:05 PM Changeset in webkit [133547] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
[l10n] updated id.po for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100264
Patch by Andika Triwidada <andika@gmail.com> on 2012-11-05
Rubber-stamped by Gustavo Noronha.
- id.po: updated.
- 5:53 PM Changeset in webkit [133546] by
-
- 11 edits in trunk
Prototype chain caching should check that the path from the base object to the slot base involves prototype hops only
https://bugs.webkit.org/show_bug.cgi?id=101276
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Changed normalizePrototypeChain() to report an invalid prototype chain if any object is a proxy.
This catches cases where our prototype chain checks would have been insufficient to guard against
newly introduced properties, despecialized properties, or deleted properties in the chain of
objects involved in the access.
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
- jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Operations.h:
(JSC):
(JSC::normalizePrototypeChain):
LayoutTests:
This test already covered this case, but only for method_check. Modified it to
also cover the get_by_id case.
- fast/js/toString-and-valueOf-override-expected.txt:
- fast/js/toString-and-valueOf-override.html:
- 5:48 PM Changeset in webkit [133545] by
-
- 2 edits in trunk/Source/WebCore
TransformOperationInfo's constructor is really slow
https://bugs.webkit.org/show_bug.cgi?id=101143
Reviewed by Sam Weinig.
TransformOperationInfo() was slow for a few reasons:
-The function used a lot of branches. The basic assumption is that the input
is incorrect, thus every character is an opportunity to fail.
-Every branch had to be tested in order. If the name was matching the last if()
all the previous names had to be tested.
-Since equalIgnoringCase() was used in every branch, it was forcing the case folding
every time.
-When the string is 16bits, the case folding was using ICU, which was incredibly inefficient.
This can be fixed by either
1) Compute the lowercase name, then match it to a HashMap.
2) Write a tree to quickly reduce the number of branch needed.
The first solution is not viable because 16bits strings case folding
remains an important bottleneck.
Instead, the code now splits the names on simple characteristics to
match any name in a limited number of branches.
The assumption is the input is correct, so & is used instead of && to
avoid branches in favor of conditional instructions.
- css/CSSParser.cpp:
(WebCore::TransformOperationInfo::TransformOperationInfo):
- 5:45 PM Changeset in webkit [133544] by
-
- 4 edits in trunk/Source/WebCore
RenderGeometryMap asserts when loading http://en.softonic.com/mac
https://bugs.webkit.org/show_bug.cgi?id=101284
<rdar://problem/11540560>
Reviewed by Tim Horton.
When FrameView::layout() calls document->updateStyleIfNeeded(), we
can be in a state where FrameView::needsLayout() is false. However,
this is a bad time to update compositing layers, because we're about
to do layout, which will require us to update them again soon anyway,
and some RenderLayers may not have been sized or positioned yet.
Fix by adding a m_doingPreLayoutStyleUpdate member to FrameView,
and toggling it around this call to updateStyleIfNeeded().
Read this state in updateCompositingLayersAfterStyleChange(), which is
now called unconditionally by recalcStyle(), but returns early
if this flag is set, or layout is pending.
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
- page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::layout):
- page/FrameView.h:
(FrameView):
- 4:54 PM Changeset in webkit [133543] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Fix build warning in PageClientLegacyImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=101266
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-05
Reviewed by Laszlo Gombos.
The 'size' is not used when !USE(TILED_BACKING_STORE)
Use UNUSED_PARAM macro for removing -Wunused-parameter warning
- UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::updateViewportSize):
- 4:48 PM Changeset in webkit [133542] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=101275
Clean up ScrollingConstraints.h
Reviewed by Simon Fraser.
This class cleans up ScrollingConstraints.h by removing the constructors since the
compiler will generate those constructors for us anyway. The patch also makes the
two override functions private.
- page/scrolling/ScrollingConstraints.h:
(ViewportConstraints):
(FixedPositionViewportConstraints):
(StickyPositionViewportConstraints):
- 4:35 PM Changeset in webkit [133541] by
-
- 2 edits in trunk/Source/WebCore
Make Document::updateStyleIfNeeded() non-virtual
https://bugs.webkit.org/show_bug.cgi?id=101273
Reviewed by Eric Seidel.
Document::updateStyleIfNeeded() has been virtual like forever, but
no-one ever overrides it, so make it non-virtual.
- dom/Document.h:
(Document):
- 4:23 PM Changeset in webkit [133540] by
-
- 3 edits in trunk/LayoutTests
Fixed flaky fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html.
https://bugs.webkit.org/show_bug.cgi?id=101268.
Reviewed by Geoffrey Garen.
- fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
- fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html:
- 4:14 PM Changeset in webkit [133539] by
-
- 1 edit5 adds in trunk/PerformanceTests
WebKit should have performance tests for book chapter reflow
https://bugs.webkit.org/show_bug.cgi?id=101271
Reviewed by Dan Bernstein.
I grabbed a book chapter from the Project Gutenberg front page:
- Layout/chapter-reflow-once.html: Added.
- Layout/chapter-reflow-thrice.html: Added.
- Layout/chapter-reflow-twice.html: Added.
- Layout/chapter-reflow.html: Added.
I also created a torture-test random text generator:
- Layout/chapter-reflow-once-random.html: Added.
- 4:13 PM Changeset in webkit [133538] by
-
- 6 edits in trunk
Unblock SVG external references
https://bugs.webkit.org/show_bug.cgi?id=100635
Reviewed by Adam Barth.
This patch reverts r132849 and r132869 because the potential XSS issue
turned out to not be an issue after all.
Covered by existing tests, many of which are re-whitelisted with this patch.
Source/WebCore:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
Source/WTF:
- wtf/Platform.h:
LayoutTests:
- platform/chromium/TestExpectations:
- 3:41 PM Changeset in webkit [133537] by
-
- 2 edits in trunk/Tools
Add IRC alias for Glenn Adams
https://bugs.webkit.org/show_bug.cgi?id=101262
Patch by Glenn Adams <glenn@skynav.com> on 2012-11-05
Reviewed by Eric Seidel.
Add IRC alias for Glenn Adams.
- Scripts/webkitpy/common/config/committers.py:
- 3:31 PM Changeset in webkit [133536] by
-
- 28 edits19 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=101001
Pages with position:fixed elements should still be able to scroll on
the scrolling thread
-and corresponding-
<rdar://problem/10857315>
Reviewed by Simon Fraser.
Source/WebCore:
This patch adds two new classes. ScrollingStateFixedNode is a class
to represent fixed nodes in the state tree, and
ScrollingTreeFixedNode represents fixed node in the scrolling tree
over on the scrolling thread.
- WebCore.xcodeproj/project.pbxproj:
When we are (non-programatically) scrolling fixed objects on the
scrolling thread, we do not want to do any work here.
- page/FrameView.cpp:
(WebCore::FrameView::updateFixedElementsAfterScrolling):
Whenever we sync the position of the main frame's layer, we have to
do the same for scrolling tree children.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
New ScrollingNodeType -- FixedNode, yay! And two new functions
specific to dealing with FixedNodes.
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::updateViewportConstrainedNode):
(WebCore::ScrollingCoordinator::syncChildPositions):
This is the new class that represents fixed nodes in the state tree.
All of the changed properties are stored within
FixedPositionViewportConstraints.
- page/scrolling/ScrollingStateFixedNode.cpp: Added.
(WebCore):
(WebCore::ScrollingStateFixedNode::create):
(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::~ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::updateConstraints):
(WebCore::ScrollingStateFixedNode::dumpProperties):
- page/scrolling/ScrollingStateFixedNode.h: Added.
(WebCore):
(ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::viewportConstraints):
(WebCore::toScrollingStateFixedNode):
Make sure to create the right type of clone for each node.
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::cloneAndReset):
Now that m_children may be anything other than null, I found this
bug. We encounter it when the parameter to removeChild is this and we
want to remove all of our children. In that case, this is obviously
not found in its own child array.
(WebCore::ScrollingStateNode::removeChild):
ScrollingStateNode now caches the GraphicsLayer in addition to the
PlatformLayer. This will allow us to sync the GraphicsLayer position
at the appropriate times.
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::isScrollingStateFixedNode):
(WebCore::ScrollingStateNode::graphicsLayer):
(ScrollingStateNode):
Handle fixed nodes.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
New function parentScrollPositionDidChange() is called on children
when the parent has scrolled.
- page/scrolling/ScrollingTreeNode.h:
(ScrollingTreeNode):
- page/scrolling/ScrollingTreeScrollingNode.h:
(ScrollingTreeScrollingNode):
Return true for supportsFixedPositionLayers().
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollingCoordinatorMac):
Handle fixed nodes.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::attachToStateTree):
Now that m_children can be non-null I caught this pre-existing bug
where we would come times remove a node without updating the HashMap.
This patch fixes that by consolidating the removal into one function.
(WebCore::ScrollingCoordinatorMac::removeNode):
(WebCore::ScrollingCoordinatorMac::detachFromStateTree):
(WebCore::ScrollingCoordinatorMac::clearStateTree):
Update the GraphicsLayers to reflect the new position that the
Scrolling thread has moved the underlying CALayer to already.
(WebCore::ScrollingCoordinatorMac::syncChildPositions):
Pass new constraints over to the appropriate state node.
(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):
Cache the GraphicsLayer in addition to the PlatformLayer.
- page/scrolling/mac/ScrollingStateNodeMac.mm:
(WebCore::ScrollingStateNode::setScrollLayer):
Here is the new class that represents fixed nodes over on the
scrolling thread.
- page/scrolling/mac/ScrollingTreeFixedNode.h: Added.
(WebCore):
(ScrollingTreeFixedNode):
- page/scrolling/mac/ScrollingTreeFixedNode.mm: Added.
(WebCore):
(WebCore::ScrollingTreeFixedNode::create):
(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):
(WebCore::ScrollingTreeFixedNode::~ScrollingTreeFixedNode):
(WebCore::ScrollingTreeFixedNode::update):
This is where the magic happens. re-position the fixed object when
its parent has scrolled so that it appears to have not moved at all.
(WebCore::ScrollingTreeFixedNode::parentScrollPositionDidChange):
Whenever we change the position of a scrolling layer, tell our
children.
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
Handle fixed nodes.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::attachToScrollingCoordinator):
detachFromScrollingCoordinator() needs to be public so that it can be
called from RenderLayerCompositor for fixed nodes.
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
RenderLayerCompositor takes control of attaching and detaching fixed
nodes to/from the ScrollingCoordinator.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::didFlushChangesForLayer):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::didMoveOnscreen):
(WebCore::RenderLayerCompositor::willMoveOffscreen):
(WebCore::RenderLayerCompositor::clearBackingForLayerIncludingDescendants):
(WebCore::isRootmostFixedOrStickyLayer):
(WebCore):
(WebCore::RenderLayerCompositor::updateViewportConstraintStatus):
(WebCore::RenderLayerCompositor::addViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::removeViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::computeViewportConstraints):
(WebCore::nearestScrollingCoordinatorAncestor):
(WebCore::RenderLayerCompositor::registerOrUpdateViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::unregisterViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
(WebCore::RenderLayerCompositor::unregisterAllViewportConstrainedLayers):
- rendering/RenderLayerCompositor.h:
(WebCore):
(RenderLayerCompositor):
LayoutTests:
New tests.
- platform/mac/tiled-drawing/fixed: Added.
- platform/mac/tiled-drawing/fixed/absolute-inside-fixed-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/absolute-inside-fixed.html: Added.
- platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html: Added.
- platform/mac/tiled-drawing/fixed/fixed-position-out-of-view.html: Added.
- platform/mac/tiled-drawing/fixed/four-bars-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/four-bars.html: Added.
- platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/nested-fixed.html: Added.
- platform/mac/tiled-drawing/fixed/percentage-inside-fixed-expected.txt: Added.
- platform/mac/tiled-drawing/fixed/percentage-inside-fixed.html: Added.
These two tests are supposed to be in "slow scrolling" mode. Now that
fixed elements can scroll "fast," we need something else to force
slow scrolling. We should probably just add something to
window.internals to do that, but in the meantime,
background-attachment:fixed will work.
- platform/mac/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt:
- platform/mac/tiled-drawing/scrolling-tree-slow-scrolling.html:
- platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
- platform/mac/tiled-drawing/tile-coverage-slow-scrolling.html:
- 3:22 PM Changeset in webkit [133535] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Mark fonts/cursive.html as flaky on MountainLion as well as Lion.
https://bugs.webkit.org/show_bug.cgi?id=83219
- platform/chromium/TestExpectations:
- 3:18 PM Changeset in webkit [133534] by
-
- 3 edits in trunk/Source/WebCore
Cleaned up the Font class in preparation for optimizing kerning and ligatures
https://bugs.webkit.org/show_bug.cgi?id=101258
Reviewed by Dan Bernstein.
- platform/graphics/Font.h:
(WebCore::Font::typesettingFeatures):
(WebCore::Font::computeTypesettingFeatures): Compute and cache our
typesetting features instead of recomputing each time a client asks
for them. This makes the class interface easier to use because
"typesettingFeatures()" can appear in more than one expression without
undue performance cost. This may also be a small speedup to code that
calls typesettingFeatures() often for other reasons.
- platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::update): Ditto.
(WebCore::Font::width): Unforked the width() function so all width-related
interfaces can benefit from optimization without duplicate code.
- 3:10 PM Changeset in webkit [133533] by
-
- 7 edits in trunk
Back out controversial changes from Bug 98665.
https://bugs.webkit.org/show_bug.cgi?id=101244
Patch by Dima Gorbik <dgorbik@apple.com> on 2012-11-05
Reviewed by David Kilzer.
Backing out changes from Bug 98665 until further discussions take place on rules for including Platform.h in Assertions.h.
Source/JavaScriptCore:
- API/tests/minidom.c:
- API/tests/testapi.c:
Source/WTF:
- wtf/Assertions.h:
Tools:
- DumpRenderTree/mac/MockGeolocationProvider.mm:
- 3:07 PM Changeset in webkit [133532] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
- platform/chromium-mac-mountainlion/TestExpectations:
- 2:56 PM Changeset in webkit [133531] by
-
- 2 edits in trunk/Source/WebCore
Webkit does not handle some media keys correctly On Linux gtk platform.
https://bugs.webkit.org/show_bug.cgi?id=101221
Patch by Peng Huang <penghuang@google.com> on 2012-11-05
Reviewed by Alexey Proskuryakov.
Add media keyboard support on Linux gtk platform.
- platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
- 2:52 PM Changeset in webkit [133530] by
-
- 4 edits4 copies in trunk/Source/WebKit2
Begin stubbing out the new remote layer tree drawing area
https://bugs.webkit.org/show_bug.cgi?id=101256
Reviewed by Andreas Kling.
- Shared/DrawingAreaInfo.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/DrawingArea.cpp:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
- 2:39 PM Changeset in webkit [133529] by
-
- 10 edits70 adds in trunk
Add support to -webkit-line-break property for CSS3 Text line-break property values and semantics.
https://bugs.webkit.org/show_bug.cgi?id=89235
Patch by Glenn Adams <glenn@skynav.com> on 2012-11-05
Reviewed by Eric Seidel.
See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping
Source/WebCore:
Web exposed changes include:
(1) The default (initial) value for -webkit-line-break becomes 'auto', instead of 'normal';
(2) The values 'auto', 'loose', 'normal', and 'strict' are added to -webkit-line-break;
(3) See [2] above for details regarding interpretation.
Tests: css3/line-break/line-break-auto-centered.html
css3/line-break/line-break-auto-half-kana.html
css3/line-break/line-break-auto-hyphens.html
css3/line-break/line-break-auto-inseparables.html
css3/line-break/line-break-auto-iteration-marks.html
css3/line-break/line-break-auto-postfixes.html
css3/line-break/line-break-auto-prefixes.html
css3/line-break/line-break-auto-sound-marks.html
css3/line-break/line-break-loose-centered.html
css3/line-break/line-break-loose-half-kana.html
css3/line-break/line-break-loose-hyphens.html
css3/line-break/line-break-loose-inseparables.html
css3/line-break/line-break-loose-iteration-marks.html
css3/line-break/line-break-loose-postfixes.html
css3/line-break/line-break-loose-prefixes.html
css3/line-break/line-break-loose-sound-marks.html
css3/line-break/line-break-normal-centered.html
css3/line-break/line-break-normal-half-kana.html
css3/line-break/line-break-normal-hyphens.html
css3/line-break/line-break-normal-inseparables.html
css3/line-break/line-break-normal-iteration-marks.html
css3/line-break/line-break-normal-postfixes.html
css3/line-break/line-break-normal-prefixes.html
css3/line-break/line-break-normal-sound-marks.html
css3/line-break/line-break-strict-centered.html
css3/line-break/line-break-strict-half-kana.html
css3/line-break/line-break-strict-hyphens.html
css3/line-break/line-break-strict-inseparables.html
css3/line-break/line-break-strict-iteration-marks.html
css3/line-break/line-break-strict-postfixes.html
css3/line-break/line-break-strict-prefixes.html
css3/line-break/line-break-strict-sound-marks.html
- platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
Add static function to construct ICU locale argument (also used as pool key) with additional
break keyword.
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):
Remove direct dependency from ICU library (and types), moving that dependency into
new {open,close}LineBreakIterator() functions (defined in TextBreakIteratorICU.cpp).
Update to take line break mode into account.
Create (and cache) different break iterators depending on line break mode (in addition to locale),
which entails expanding pool entry key format to optionally append "@break=" +
"loose"|"normal"|"strict" keyword to locale string.
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::isLooseCJKMode):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
Define LineBreakIteratorMode enumeration for use in TextBreakIterator et al.
Add state member to indicate line break mode.
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::acquireLineBreakIterator):
Use new line break mode when making iterator from pool.
Handle change of return type of LineBreakIteratorPool::take() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::releaseLineBreakIterator):
Handle change of parameter type of LineBreakIteratorPool::put() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::isCJKLocale):
New functions for determining if CJK rules apply.
(WebCore::openLineBreakIterator):
New function for abstracting opening of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
This function also takes into account the line break mode.
(WebCore::closeLineBreakIterator):
(WebCore::mapLineIteratorModeToRules):
New function for abstracting closing of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Pass line break iterator mode flag when reseting LazyLineBreakIterator.
Add looseMode local variable to prevent need for computing under isBreakable().
- rendering/RenderText.cpp:
(WebCore::mapLineBreakToIteratorMode):
Add implementation for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
(WebCore::RenderText::computePreferredLogicalWidths):
Ensure (lazy line) breakIterator is initialized for line break mode.
Ensure isBreakable() is passed loose mode flag to match behavior in RenderBlock::LineBreaker::nextLineBreak.
- rendering/RenderText.h:
(WebCore):
Add declaration for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
- rendering/break_lines.cpp:
(WebCore):
Introduce two (local) enums NBSPBehavior and LooseBehavior for expanding template on nextBreakablePosition
to include loose mode parameter.
(WebCore::isBreakableSpace):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation. Use new loose mode flavors off NBP functions.
(WebCore::needsLineBreakIterator):
Introduce loose mode behavior template parameter to optimize loose mode behavior code path in order
to prevent regression to non loose mode path.
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
Use new template parameter enums described above.
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
(WebCore::nextBreakablePositionLoose):
Introduce two additional 'loose' mode flavors of NBP template expansions.
- rendering/break_lines.h:
(WebCore):
(WebCore::isBreakable):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation.
LayoutTests:
- css3/line-break/line-break-auto-centered-expected.html: Added.
- css3/line-break/line-break-auto-centered.html: Added.
- css3/line-break/line-break-auto-half-kana-expected.html: Added.
- css3/line-break/line-break-auto-half-kana.html: Added.
- css3/line-break/line-break-auto-hyphens-expected.html: Added.
- css3/line-break/line-break-auto-hyphens.html: Added.
- css3/line-break/line-break-auto-inseparables-expected.html: Added.
- css3/line-break/line-break-auto-inseparables.html: Added.
- css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
- css3/line-break/line-break-auto-iteration-marks.html: Added.
- css3/line-break/line-break-auto-postfixes-expected.html: Added.
- css3/line-break/line-break-auto-postfixes.html: Added.
- css3/line-break/line-break-auto-prefixes-expected.html: Added.
- css3/line-break/line-break-auto-prefixes.html: Added.
- css3/line-break/line-break-auto-sound-marks-expected.html: Added.
- css3/line-break/line-break-auto-sound-marks.html: Added.
- css3/line-break/line-break-loose-centered-expected.html: Added.
- css3/line-break/line-break-loose-centered.html: Added.
- css3/line-break/line-break-loose-half-kana-expected.html: Added.
- css3/line-break/line-break-loose-half-kana.html: Added.
- css3/line-break/line-break-loose-hyphens-expected.html: Added.
- css3/line-break/line-break-loose-hyphens.html: Added.
- css3/line-break/line-break-loose-inseparables-expected.html: Added.
- css3/line-break/line-break-loose-inseparables.html: Added.
- css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
- css3/line-break/line-break-loose-iteration-marks.html: Added.
- css3/line-break/line-break-loose-postfixes-expected.html: Added.
- css3/line-break/line-break-loose-postfixes.html: Added.
- css3/line-break/line-break-loose-prefixes-expected.html: Added.
- css3/line-break/line-break-loose-prefixes.html: Added.
- css3/line-break/line-break-loose-sound-marks-expected.html: Added.
- css3/line-break/line-break-loose-sound-marks.html: Added.
- css3/line-break/line-break-normal-centered-expected.html: Added.
- css3/line-break/line-break-normal-centered.html: Added.
- css3/line-break/line-break-normal-half-kana-expected.html: Added.
- css3/line-break/line-break-normal-half-kana.html: Added.
- css3/line-break/line-break-normal-hyphens-expected.html: Added.
- css3/line-break/line-break-normal-hyphens.html: Added.
- css3/line-break/line-break-normal-inseparables-expected.html: Added.
- css3/line-break/line-break-normal-inseparables.html: Added.
- css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
- css3/line-break/line-break-normal-iteration-marks.html: Added.
- css3/line-break/line-break-normal-postfixes-expected.html: Added.
- css3/line-break/line-break-normal-postfixes.html: Added.
- css3/line-break/line-break-normal-prefixes-expected.html: Added.
- css3/line-break/line-break-normal-prefixes.html: Added.
- css3/line-break/line-break-normal-sound-marks-expected.html: Added.
- css3/line-break/line-break-normal-sound-marks.html: Added.
- css3/line-break/line-break-strict-centered-expected.html: Added.
- css3/line-break/line-break-strict-centered.html: Added.
- css3/line-break/line-break-strict-half-kana-expected.html: Added.
- css3/line-break/line-break-strict-half-kana.html: Added.
- css3/line-break/line-break-strict-hyphens-expected.html: Added.
- css3/line-break/line-break-strict-hyphens.html: Added.
- css3/line-break/line-break-strict-inseparables-expected.html: Added.
- css3/line-break/line-break-strict-inseparables.html: Added.
- css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
- css3/line-break/line-break-strict-iteration-marks.html: Added.
- css3/line-break/line-break-strict-postfixes-expected.html: Added.
- css3/line-break/line-break-strict-postfixes.html: Added.
- css3/line-break/line-break-strict-prefixes-expected.html: Added.
- css3/line-break/line-break-strict-prefixes.html: Added.
- css3/line-break/line-break-strict-sound-marks-expected.html: Added.
- css3/line-break/line-break-strict-sound-marks.html: Added.
- platform/chromium/css3/line-break/line-break-auto-half-kana-expected.html: Added.
- platform/chromium/css3/line-break/line-break-auto-sound-marks-expected.html: Added.
Override reftest expectations on chromium due to different ICU auto behavior.
- platform/chromium-android/css3/line-break/line-break-auto-half-kana-expected.html: Added.
- platform/chromium-android/css3/line-break/line-break-auto-sound-marks-expected.html: Added.
Override override of reftest expectations on chromium due to different ICU auto behavior;
that is, chromium-android seems to follow the generic expectations.
- 2:34 PM Changeset in webkit [133528] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] screenX/Y gives wrong values
https://bugs.webkit.org/show_bug.cgi?id=101259
Reviewed by Yong Li.
PR 237071
Reviewed internally by Gen Mak.
Do not transform screenPos coordinates.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::mouseEvent):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
- 2:32 PM Changeset in webkit [133527] by
-
- 11 edits in trunk
webkitRegionLayoutUpdate is incorrectly named
https://bugs.webkit.org/show_bug.cgi?id=100335
Reviewed by Ojan Vafai.
Source/WebCore:
DOM event names are supposed to be lower case.
- dom/EventNames.h:
(WebCore):
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
LayoutTests:
Update tests to use the proper name.
- fast/regions/webkit-named-flow-event-add-to-flow.html:
- fast/regions/webkit-named-flow-event-no-regions.html:
- fast/regions/webkit-named-flow-event-remove-from-dom.html:
- fast/regions/webkit-named-flow-event-remove-from-flow.html:
- fast/regions/webkit-named-flow-event-target.html:
- fast/regions/webkit-named-flow-event-to-null.html:
- fast/regions/webkit-named-flow-event.html:
- 2:15 PM Changeset in webkit [133526] by
-
- 33 edits3 deletes in trunk/Source
[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110
Reviewed by Kentaro Hara.
Source/WebCore:
This patch generalizes our support for storing wrappers in DOM objects
to be usable for more than just nodes. After this patch, any object
with a ScriptWrappable base class will have its wrapper stored inline
in the object in the main world.
To achieve this goal, this patch hides the details of how we map from
objects to wrappers inside DOMDataStore and then removes the
IntrusiveDOMWrapperMap class entirely. This approach lets us remove the
DOMWrapperMap base class and make all of these functions non-virtual.
- UseV8.cmake:
- WebCore.gypi:
- Remove deleted files.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
- Rather than grabbing at the DOMWrapperMap directly, we now ask the DOMDataStore to do this work for us.
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::V8Float64Array::wrap):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::V8TestActiveDOMObject::wrap):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::V8TestCustomNamedGetter::wrap):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::V8TestEventConstructor::wrap):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::V8TestEventTarget::wrap):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::wrap):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::wrap):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::wrap):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::wrap):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::wrap):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::wrap):
- bindings/v8/DOMDataStore.cpp:
- Updated run-bindings-test results.
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
- Simplify constructor and destructor now that there is only one hash map.
(WebCore::DOMDataStore::current):
- Now that V8DOMMap.cpp doesn't handle the null isolate case, we need to handle it here.
(WebCore::DOMDataStore::reportMemoryUsage):
- Simplfied now that there is only one wrapper map.
(WebCore::DOMDataStore::weakCallback):
- Moved from IntrusiveDOMWrapperMap.h
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
- These functions now handle the intrusive case with a branch rather than with a virtual function call. In many cases, the branch can be optimized away by the compiler when the overloaded inline functions are inlined.
(WebCore::DOMDataStore::wrapperIsStoredInObject):
- Overloaded functions to determine whether to store the wrapper inside the object or in the hashmap.
(WebCore::DOMDataStore::getWrapperFromObject):
(WebCore::DOMDataStore::storeWrapperInObject):
- Overloaded functions to get/set the wrapper from inside the object itself.
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperHashMap::get):
(WebCore::DOMWrapperHashMap::set):
(WebCore::DOMWrapperHashMap::clear):
(WebCore::DOMWrapperHashMap::reportMemoryUsage):
(WebCore::DOMWrapperHashMap::remove):
- These functions are no longer virtual.
- bindings/v8/DOMWrapperWorld.h:
- bindings/v8/IntrusiveDOMWrapperMap.h: Removed.
- bindings/v8/ScriptProfiler.cpp:
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::neuterBinding):
- We need to keep the type information slightly longer so that we look in the right wrapper map.
- bindings/v8/V8DOMMap.cpp: Removed.
- bindings/v8/V8DOMMap.h: Removed.
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- Defer this work to the store.
(WebCore::V8DOMWrapper::setWrapperClass):
- An overloaded function to set the right wrapper class.
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
- This function is now general enough to handle ever kind of object.
- bindings/v8/V8GCController.cpp:
- bindings/v8/V8NPObject.cpp:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/WorkerScriptController.cpp:
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
- Call the more general function (instead of the now-deleted specialized function).
Source/WebKit/chromium:
- src/WebScriptController.cpp:
- Remove unneeded include of deleted file.
- 2:11 PM Changeset in webkit [133525] by
-
- 2 edits in trunk/LayoutTests
Remove fast/forms/week-multiple-fields from
platform/mac/TestExpectations, since it no longer exists and makes the
style script complain. Unreviewed.
- platform/mac/TestExpectations:
- 2:07 PM Changeset in webkit [133524] by
-
- 20 edits1 delete in trunk
Get rid of setCookieStoragePrivateBrowsingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=101247
Reviewed by Brady Eidson.
We were only doing anything here on Mac, and only because we couldn't know if
sessions were in use. But sessions are always in use, and those obsolete changing
cookie storage explicitly.
- platform/network/win/CookieStorageWin.cpp: Removed.
- PlatformWinCE.cmake:
- WebCore.gypi: No more CookieStorageWin.cpp with an empty implementation.
- WebCore.exp.in:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm: We no longer need this WKSI function.
- page/Settings.cpp: (WebCore::Settings::setPrivateBrowsingEnabled): Removed the only call to setCookieStoragePrivateBrowsingEnabled().
- platform/network/CookieStorage.h:
- platform/network/cf/CookieStorageCFNet.cpp:
- platform/network/curl/CookieJarCurl.cpp:
- platform/network/soup/CookieStorageSoup.cpp:
- platform/qt/TemporaryLinkStubsQt.cpp: Removed empty setCookieStoragePrivateBrowsingEnabled implementations.
- platform/network/mac/CookieStorageMac.mm: This function used to have a FIXME that we should observe private storage while in private browsing mode. I don't think that it was correct - Safari doesn't display content of private storage, and thus doesn't need to know about changes. The removal of this function has an effect on WebKit1 clients that enable private browsing. We used to globally change cookie storage, even for loads not initiated by WebKit. Now we match API description: "If private browsing is enabled, WebKit will not store information about sites the user visits."
- 2:03 PM Changeset in webkit [133523] by
-
- 2 edits in trunk/LayoutTests
[chromium] Give actual bug IDs to some past gardening. Unreviewed.
- platform/chromium/TestExpectations:
- 1:59 PM Changeset in webkit [133522] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Do not display error page for failed downloads
https://bugs.webkit.org/show_bug.cgi?id=101246
Internal PR: 236318
Internal reviewed by Joe Mason, Leo Yang.
Patch by Lianghui Chen <liachen@rim.com> on 2012-11-05
Reviewed by Rob Buis.
Right now when a main load, including all downloads, failed, it will
display an error page. This is not very user friendly, especially for
WebWorks application, which want to use its own user interface to info
user about the failure.
So we just stop displaying error page for downloads.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 1:51 PM Changeset in webkit [133521] by
-
- 41 edits2 adds in trunk
Crash when mixing layers, foreignObjects and SVG hidden containers
https://bugs.webkit.org/show_bug.cgi?id=87297
Reviewed by Dirk Schulze.
Source/WebCore:
Foreign objects may introduce content which requires layers, but layer creation is
suppressed within RenderSVGHiddenContainer subtrees and this yields an inconsistent render
tree state. This patch prevents foreignObject renderer instantiation under
RenderSVGHiddenContainers.
Test: svg/foreignObject/foreign-object-defs-crash.svg
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::rendererIsNeeded):
(WebCore):
- svg/SVGForeignObjectElement.h:
(SVGForeignObjectElement):
LayoutTests:
- platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/chromium-win/svg/foreignObject/fO-parent-display-none-expected.txt:
- platform/chromium-win/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
- platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
- platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
- platform/chromium/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/chromium/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/chromium/svg/foreignObject/fO-parent-display-none-expected.txt:
- platform/chromium/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
- platform/chromium/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
- platform/chromium/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
- platform/efl/svg/foreignObject/fO-parent-display-none-expected.txt:
- platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
- platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
- platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/gtk/svg/foreignObject/fO-parent-display-none-expected.txt:
- platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
- platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
- platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/mac/svg/foreignObject/fO-parent-display-none-expected.txt:
- platform/mac/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
- platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
- platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/qt/svg/foreignObject/fO-parent-display-none-expected.txt:
- platform/qt/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
- platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
- platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
- svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
- svg/foreignObject/foreign-object-defs-crash-expected.txt: Added.
- svg/foreignObject/foreign-object-defs-crash.svg: Added.
- svg/foreignObject/text-tref-02-b-expected.txt:
- 1:43 PM Changeset in webkit [133520] by
-
- 2 edits in trunk/Source/WebCore
Remove the unused m_fixedPositionedElements from RenderView
https://bugs.webkit.org/show_bug.cgi?id=101251
Reviewed by Anders Carlsson.
m_fixedPositionedElements was completely unused. Remove it
and the related typedef.
- rendering/RenderView.h:
(RenderView):
- 1:38 PM Changeset in webkit [133519] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark several compositing tests as only failing Image
and not Text, after r133513. Unreviewed.
- platform/chromium/TestExpectations:
- 1:25 PM Changeset in webkit [133518] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] New compositing/tiling tests fail
https://bugs.webkit.org/show_bug.cgi?id=101166
Unskip now passing tests after r133513.
- platform/qt-5.0-wk2/TestExpectations:
- 1:07 PM Changeset in webkit [133517] by
-
- 46 edits in trunk/Source
Fix layer borders to cleaning appear and disappear on switching
https://bugs.webkit.org/show_bug.cgi?id=101136
Source/WebCore:
Reviewed by Sam Weinig.
GraphicsLayers decided whether to show layer borders based
on a callback through the GraphicsLayerClient. This made it
hard to manage state, resulting in a failure to cleanly
hide layers when toggled off via the preference.
Changed the layer border and repaint counter visibility to be bits
stored on GraphicsLayer just like other properties, with getters
and setters. RenderLayerBacking now updates these debug
indicators when we update other compositing layer properties.
In GraphicsLayerCA, avoid calling updateDebugIndicators() explicitly
in several places by setting the change flag DebugIndicatorsChanged
for properties whose values affect the appearance of the debug border.
Removed the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter() which are no longer required.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::updateDebugIndicators):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setShowDebugBorder):
(WebCore::GraphicsLayer::isShowingDebugBorder):
(WebCore::GraphicsLayer::setShowRepaintCounter):
(WebCore::GraphicsLayer::isShowingRepaintCounter):
(WebCore::GraphicsLayer::repaintCount):
(WebCore::GraphicsLayer::incrementRepaintCount):
- platform/graphics/GraphicsLayerClient.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setMasksToBounds):
(WebCore::GraphicsLayerCA::setDrawsContent):
(WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateMasksToBounds):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateDebugBorder):
(WebCore::GraphicsLayerCA::setShowDebugBorder):
(WebCore::GraphicsLayerCA::setShowRepaintCounter):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::setupContentsLayer):
(WebCore::GraphicsLayerCA::cloneLayer):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
(WebCore::GraphicsLayerCA::platformCALayerShowDebugBorders):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDebugIndicators):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
Source/WebKit/blackberry:
Reviewed by Sam Weinig.
Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().
- Api/WebOverlay_p.h:
(WebOverlayPrivateWebKitThread):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
- Api/WebPage_p.h:
- WebKitSupport/DefaultTapHighlight.cpp:
- WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):
- WebKitSupport/InspectorOverlayBlackBerry.cpp:
- WebKitSupport/InspectorOverlayBlackBerry.h:
(InspectorOverlay):
- WebKitSupport/SelectionOverlay.cpp:
- WebKitSupport/SelectionOverlay.h:
(SelectionOverlay):
Source/WebKit/chromium:
Reviewed by Sam Weinig.
Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().
- src/NonCompositedContentHost.cpp:
- src/NonCompositedContentHost.h:
(NonCompositedContentHost):
- src/PageOverlay.cpp:
- tests/GraphicsLayerChromiumTest.cpp:
- tests/ImageLayerChromiumTest.cpp:
Source/WebKit/gtk:
Reviewed by Sam Weinig.
Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().
- WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
- WebCoreSupport/AcceleratedCompositingContextCairo.cpp:
- WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
Source/WebKit/win:
Reviewed by Sam Weinig.
Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().
- WebView.cpp:
- WebView.h:
Source/WebKit2:
Reviewed by Sam Weinig.
Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
- WebProcess/WebPage/ca/LayerTreeHostCA.h:
(LayerTreeHostCA):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
- 12:49 PM Changeset in webkit [133516] by
-
- 3 edits in trunk/Source
[chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas
https://bugs.webkit.org/show_bug.cgi?id=101016
Reviewed by Adrienne Walker.
Passing SkBitmap by value requires including SkBitmap.h, which is tricky for some clients to do since it
requires having the rest of skia's headers on the include path and setting up the correct config to set
preprocessor defines. Also shuffles the parameter order around to make rolling easier since you can't override
just by const ref-ness.
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::setFontAtlas):
- 12:40 PM Changeset in webkit [133515] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Input date should not popup dialog when readonly is set
https://bugs.webkit.org/show_bug.cgi?id=101234
Reviewed by Yong Li.
PR 236114
Reviewed internally by Mike Fenton.
Suppress popup dialog if the input element has readonly attribute set.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::openColorPopup):
- 12:36 PM Changeset in webkit [133514] by
-
- 3 edits in branches/chromium/1312/Source/WebCore
Merge 133262 - Build fix. http://trac.webkit.org/changeset/133252 broke the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=101008
Reviewed by fischman@chromium.org.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::clearMediaPlayer):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
TBR=roger_fong@apple.com
Review URL: https://codereview.chromium.org/11368088
- 12:36 PM Changeset in webkit [133513] by
-
- 3 edits in trunk/LayoutTests
[Qt][WK2] New compositing/tiling tests fail
https://bugs.webkit.org/show_bug.cgi?id=101166
The platform-independent results should not contain visibleRect, since this is
only dumped on Mac.
- compositing/tiling/rotated-tiled-clamped-expected.txt:
- compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- 12:34 PM Changeset in webkit [133512] by
-
- 4 edits1 copy in branches/chromium/1312
Merge 133252 - HTMLMediaPlayer should free m_player when src is set/changed
https://bugs.webkit.org/show_bug.cgi?id=99647
Reviewed by Eric Carlson.
.:
- ManualTests/media-players-are-dropped-on-error.html: Added.
Various scenarios are tested to make sure players aren't
leaked in different ways for each of them.
Source/WebCore:
New ManualTest added; manual since leaking media players doesn't have layoutTestController-visible effects.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): clearMediaPlayer() when src is set/changed
(WebCore::HTMLMediaElement::userCancelledLoad): use new clearMediaPlayer() helper
(WebCore::HTMLMediaElement::clearMediaPlayer): clear m_player and associated timers/flags
(WebCore):
(WebCore::HTMLMediaElement::createMediaPlayer): whitespace-only change
- html/HTMLMediaElement.h: new method: createMediaPlayer().
(HTMLMediaElement):
TBR=fischman@chromium.org
Review URL: https://codereview.chromium.org/11275156
- 12:28 PM Changeset in webkit [133511] by
-
- 13 edits in trunk/LayoutTests
Rebaseline some Lion results that were affected by enabling subpixel layout.
- platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
- platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
- platform/mac-lion/fast/text/international/hindi-spacing-expected.txt:
- platform/mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt:
- platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
- platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
- platform/mac-lion/fast/writing-mode/vertical-font-fallback-expected.txt:
- 11:47 AM Changeset in webkit [133510] by
-
- 3 edits in trunk/Tools
webkitpy: lint, clean up rebaseline.py
https://bugs.webkit.org/show_bug.cgi?id=101240
Reviewed by Ojan Vafai.
Miscellaneous cleanup of lint errors and warnings.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(RebaselineTest._test_root):
(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AnalyzeBaselines.init):
(AbstractParallelRebaselineCommand):
(AbstractParallelRebaselineCommand._builders_to_fetch_from):
(AbstractParallelRebaselineCommand._files_to_add):
(AbstractParallelRebaselineCommand._rebaseline):
(RebaselineExpectations.init):
(Rebaseline.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(_BaseTestCase.setUp):
(TestAnalyzeBaselines.setUp):
- 11:28 AM Changeset in webkit [133509] by
-
- 5 edits in trunk/Tools
webkit-patch optimize-baselines should take a --platform arg
https://bugs.webkit.org/show_bug.cgi?id=97623
Reviewed by Ojan Vafai.
So that we can optionally limit/control which platforms' results
are affected.
This patch adds --platform to analyze-baselines as well.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(_baseline_search_hypergraph):
(BaselineOptimizer.init):
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(TestBaselineOptimizer.init):
(BaselineOptimizerTest.test_move_baselines):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(OptimizeBaselines.init):
(OptimizeBaselines.execute):
(AnalyzeBaselines.init):
(AnalyzeBaselines.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestAnalyzeBaselines.test_default):
(TestAnalyzeBaselines.test_missing_baselines):
- 11:26 AM Changeset in webkit [133508] by
-
- 4 edits1 add in trunk/Tools
webkit-patch rebaseline-expectations should take a --platform arg
https://bugs.webkit.org/show_bug.cgi?id=97621
Reviewed by Ojan Vafai.
So that we can limit which platforms we attempt to rebaseline;
this can reduce the noise the command produces if some ports
have errors or warnings in their TestExpectations files and/or
help produce more predictable results.
In testing this patch, I realized that the rebaseline-in-parallel
commands (rebaseline-json, rebaseline-expectations, etc.) can
cause multiple rebaseline-test-internal commands to attempt to
modify the TestExpectations files concurrently, and that we needed
to lock the files to prevent corruption; it would be nice if
we can split the updating-the-expectations-files out separately
from updating the filesystem (much like we do with the scm updates)
to avoid this concurrency.
- Scripts/webkitpy/common/system/file_lock_mock.py: Added.
(MockFileLock):
(MockFileLock.init):
(MockFileLock.acquire_lock):
(MockFileLock.release_lock):
- Scripts/webkitpy/common/system/systemhost.py:
(SystemHost.copy_current_environment):
(SystemHost):
(SystemHost.make_file_lock):
- Scripts/webkitpy/common/system/systemhost_mock.py:
(MockSystemHost.copy_current_environment):
(MockSystemHost):
(MockSystemHost.make_file_lock):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._update_expectations_file):
(RebaselineExpectations.init):
(RebaselineExpectations._add_tests_to_rebaseline_for_port):
(RebaselineExpectations.execute):
- 11:24 AM Changeset in webkit [133507] by
-
- 5 edits in trunk/Tools
webkitpy: clean up options for specifying multiple platforms at once
https://bugs.webkit.org/show_bug.cgi?id=101140
Reviewed by Ojan Vafai.
This patch reworks how we display the help strings for --platform
options and how we filter out platforms matching a glob. This will
be useful as I add patches to ensure that all the webkit-patch
commands are using --platform consistently to filter ports.
There should be no functional changes resulting from this patch.
- Scripts/webkitpy/layout_tests/port/factory.py:
(platform_options):
(PortFactory.all_port_names):
(PortFactory.get_from_builder_name):
- Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.init):
(PrintBaselines.init):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(RebaselineJson.init):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineExpectations.setUp):
(TestRebaselineExpectations.test_rebaseline_expectations):
- 11:21 AM Changeset in webkit [133506] by
-
- 2 edits in trunk/Tools
The layout test runner shouldn't wait for data if stdout/stderr have been closed
https://bugs.webkit.org/show_bug.cgi?id=101233
Reviewed by Dirk Pranke.
Trying to read the file descriptor for the stdout or stderr pipes when DumpRenderTree
has crashed during a Chromium Android layout test-run, which uses FIFOs for
communication, causes the File.fileno() method to raise a ValueError. Return early
if either of the pipes has already been closed.
- Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._wait_for_data_and_update_buffers_using_select):
- 11:17 AM Changeset in webkit [133505] by
-
- 3 edits in trunk/Tools
webkit-patch rebaseline is broken
https://bugs.webkit.org/show_bug.cgi?id=101235
Reviewed by Ojan Vafai.
It didn't get updated to handle the change in parsing --suffixes
properly, and the unit test didn't get updated either, masking the
problem.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(Rebaseline._tests_to_update):
(Rebaseline.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline):
- 11:12 AM Changeset in webkit [133504] by
-
- 5 edits in trunk/Tools
lint-webkitpy doesn't autoinstall pylint properly.
https://bugs.webkit.org/show_bug.cgi?id=101106
Reviewed by Ojan Vafai.
Re-land r133381 with fix; ironically, lint-webkitpy would've
complained about the problem. Also modify pylintrc and clean up
any other lint errors in the modified files.
- Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._set_up_target_dir):
(AutoInstaller):
(AutoInstaller._make_package):
(AutoInstaller._create_scratch_directory):
(AutoInstaller._install):
(AutoInstaller.install):
- Scripts/webkitpy/pylintrc:
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
(AutoinstallImportHook):
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install_webpagereplay):
(AutoinstallImportHook._install):
- Scripts/webkitpy/thirdparty/init_unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.init):
(ThirdpartyTest.test_import_hook):
(ThirdpartyTest.test_imports):
- 11:10 AM Changeset in webkit [133503] by
-
- 6 edits in trunk/Source/WebKit/chromium
Expose hit test related methods in public chromium port
https://bugs.webkit.org/show_bug.cgi?id=101204
Patch by Bo Liu <boliu@chromium.org> on 2012-11-05
Reviewed by Adam Barth.
The methods are needed in implementating hit test related methods in the
Android WebView API.
The specific methods are:
[Web]HitTestResult::urlElement
[Web]HitTestResult::absoluteImageURL
[Web]HitTestResult::absoluteLinkURL
[Web]HitTestResult::isContentEditable
WebViewImpl::hitTestResultAt
- public/WebHitTestResult.h:
(WebKit):
(WebHitTestResult):
- public/WebView.h:
(WebKit):
(WebView):
- src/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::urlElement):
(WebKit):
(WebKit::WebHitTestResult::absoluteImageURL):
(WebKit::WebHitTestResult::absoluteLinkURL):
(WebKit::WebHitTestResult::isContentEditable):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::hitTestResultAt):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
- 11:09 AM Changeset in webkit [133502] by
-
- 4 edits in trunk/Source
[BLACKBERRY] Update touch code to reflect touch refactor
https://bugs.webkit.org/show_bug.cgi?id=101227
Patch by Genevieve Mak <gmak@rim.com> on 2012-11-05
Reviewed by Rob Buis.
PR #2706785
Reviewed Internally by: Mike Lattanzio
Source/WebCore:
- platform/blackberry/PlatformTouchEventBlackBerry.cpp:
(WebCore::touchEventType):
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
- 11:08 AM Changeset in webkit [133501] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark css3/filters/custom/custom-filter-animation.html
as timing out intermittently. Unreviewed.
- platform/chromium/TestExpectations:
- 10:59 AM Changeset in webkit [133500] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r125353. <rdar://problem/12536410>
- 10:56 AM Changeset in webkit [133499] by
-
- 12 edits in trunk/Source
[chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents
https://bugs.webkit.org/show_bug.cgi?id=99083
Reviewed by Stephen White.
Use LCD text setting passed to WebContentLayerClient::paintContents instead of turning it off for all composited layers.
Source/Platform:
- chromium/public/WebContentLayerClient.h:
(WebContentLayerClient):
(WebKit::WebContentLayerClient::paintContents):
Source/WebCore:
No new tests needed. This patch does not change anything functionally.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::paint):
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:
(OpaqueRectTrackingContentLayerDelegate):
Source/WebKit/chromium:
- src/LinkHighlight.cpp:
(WebKit::LinkHighlight::paintContents):
- src/LinkHighlight.h:
(LinkHighlight):
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit::NonCompositedContentHost::paintContents):
- src/NonCompositedContentHost.h:
(NonCompositedContentHost):
- tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore::TEST_F):
- 10:55 AM WebKit Team edited by
- Add aboxhall and dmazzoni to the Committers list (already in committers.py) (diff)
- 10:51 AM Changeset in webkit [133498] by
-
- 10 edits2 copies in branches/safari-536.28-branch
Merged r125351. <rdar://problem/12536410>
- 10:51 AM Changeset in webkit [133497] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Build fix after http://trac.webkit.org/changeset/133488.
Removed a deleted file. Unreviewed.
- WebCore.gypi:
- 10:42 AM WebKit Team edited by
- (diff)
- 10:41 AM Changeset in webkit [133496] by
-
- 2 edits in trunk/Source/WebCore
[V8] toV8(impl) should return null if impl is 0
https://bugs.webkit.org/show_bug.cgi?id=101206
Reviewed by Adam Barth.
toV8(impl) should return null if impl is 0. However,
V8HTMLCollection::toV8() does not have the null check.
All other toV8()s return null.
No tests. I think there will be no call path that hits the change.
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
- 10:18 AM Changeset in webkit [133495] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 10:17 AM Changeset in webkit [133494] by
-
- 4 edits in trunk
Implement SimpleFontData::platformBoundsForGlyph on skia
https://bugs.webkit.org/show_bug.cgi?id=101115
Reviewed by Eric Seidel.
Source/WebCore:
The implementation is similar to SimpleFontData::platformWidthForGlyph on skia.
Tested by: fast/block/lineboxcontain/*glyphs*, mathml/presentation/*
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph): Implemented.
LayoutTests:
Some lineboxcontain/etc. tests will need rebaselining.
- platform/chromium/TestExpectations:
- 10:15 AM Changeset in webkit [133493] by
-
- 16 edits in trunk/Source/JavaScriptCore
Reduce the verbosity of referring to QNaN in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=101174
Reviewed by Geoffrey Garen.
Introduces a #define QNaN in JSValue.h, and replaces all previous uses of
std::numeric_limits<double>::quiet_NaN() with QNaN.
- API/JSValueRef.cpp:
(JSValueMakeNumber):
(JSValueToNumber):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitFloatTypedArrayGetByVal):
- runtime/CachedTranscendentalFunction.h:
(JSC::CachedTranscendentalFunction::initialize):
- runtime/DateConstructor.cpp:
(JSC::constructDate):
- runtime/DateInstanceCache.h:
(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):
- runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
- runtime/JSCell.h:
(JSC::JSValue::getPrimitiveNumber):
- runtime/JSDateMath.cpp:
(JSC::parseDateFromNullTerminatedCharacters):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::toDouble):
(JSC::jsToNumber):
(JSC::parseFloat):
- runtime/JSValue.cpp:
(JSC::JSValue::toNumberSlowCase):
- runtime/JSValue.h:
(JSC):
- runtime/JSValueInlineMethods.h:
(JSC::jsNaN):
- runtime/MathObject.cpp:
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
- 10:06 AM Changeset in webkit [133492] by
-
- 7 edits in trunk/Source/WebCore
Decouple Attr logic from ElementAttributeData.
<http://webkit.org/b/101126>
Reviewed by Antti Koivisto.
Move all logic dealing with Attr DOM nodes from ElementAttributeData to Element.
This makes more sense since an Attr is tied to a single Element, but an ElementAttributeData
can be shared by any number of Elements at a given time.
Also updated naming convention from just "Attr" to "Attr node" in the code I was touching.
"Attr" is way too generic, and has been historically confused with WebCore::Attribute a lot.
- dom/Element.h:
- dom/ElementAttributeData.h:
- dom/Element.cpp:
(WebCore::attrNodeListMap):
(WebCore::attrNodeListForElement):
(WebCore::ensureAttrNodeListForElement):
(WebCore::removeAttrNodeListForElement):
(WebCore::findAttrNodeInList):
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
(WebCore::Element::detachAttrNodeFromElementWithValue):
(WebCore::Element::detachAllAttrNodesFromElement):
(WebCore::Element::cloneAttributesFromElement):
Move everything Attr-related into Element.cpp while simplifying some loops and remove
conditions that are no longer needed as they used to depend on having an attributeData().
- dom/Node.h:
(WebCore::Node::hasSyntheticAttrChildNodes):
(WebCore::Node::setHasSyntheticAttrChildNodes):
Renamed the hasAttrList() node flag to hasSyntheticAttrChildNodes().
- dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):
Remove awkward indirection and let the call site deal with removing the Attr node from
the Element's list of Attr nodes.
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::clearAttributes):
Remove now-unused Element* argument.
- 10:01 AM Changeset in webkit [133491] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, unskip a now passing test.
- platform/qt-5.0-wk1/TestExpectations:
- 9:53 AM Changeset in webkit [133490] by
-
- 4 edits4 adds in trunk
[CSS Exclusions] Polygon edges should span colinear vertices
https://bugs.webkit.org/show_bug.cgi?id=99343
Patch by Hans Muller <hmuller@adobe.com> on 2012-11-05
Reviewed by Dirk Schulze.
Source/WebCore:
ExclusionPolygonEdges now span coincident and collinear vertices. Currently
pairs of vertices are only considered coincident if their coordinates are exactly
equal. Similarly, a vertex is only considered collinear with an edge if the area
of the triangle defined by the three vertices is exactly zero. In the future it
may be useful to relax the comparison with zero.
Tests: fast/exclusions/shape-inside/shape-inside-coincident-vertices.html
fast/exclusions/shape-inside/shape-inside-collinear-vertices.html
- rendering/ExclusionPolygon.cpp:
(WebCore::determinant): Used to measure collinearity.
(WebCore):
(WebCore::areCollinearPoints): True if three FloatPoint arguments are collinear per the test outlined above.
(WebCore::areCoincidentPoints): True if the two FloatPoint arguments are equal.
(WebCore::nextVertexIndex): The next vertex index in clockwise or counterclockwise order.
(WebCore::ExclusionPolygon::findNextEdgeVertexIndex): Return the index of the next non-coincident, non-collinear vertex.
(WebCore::ExclusionPolygon::ExclusionPolygon): Skip coincident and collinear vertices when building the list of edges.
- rendering/ExclusionPolygon.h: Added private findNextEdgeVertexIndex() declaration.
LayoutTests:
Verify that exclusion polygonal shape-inside layout is unaffected by coincident
or collinear vertices.
- fast/exclusions/shape-inside/shape-inside-coincident-vertices-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-coincident-vertices.html: Added.
- fast/exclusions/shape-inside/shape-inside-collinear-vertices-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-collinear-vertices.html: Added.
- 9:37 AM Changeset in webkit [133489] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r125315. <rdar://problem/12536439>
- 9:33 AM Changeset in webkit [133488] by
-
- 2 edits1 delete in trunk/Source/WebCore
[EFL] Use POSIX implementation of SharedBuffer::createWithContentsOfFile()
https://bugs.webkit.org/show_bug.cgi?id=101228
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Get rid of EFL-specific implementation of SharedBuffer::createWithContentsOfFile()
and reuse the POSIX one since it is pretty much the same.
No new tests, no behavior change.
- PlatformEfl.cmake:
- platform/efl/SharedBufferEfl.cpp: Removed.
- 9:25 AM Changeset in webkit [133487] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, unskip now passing tests.
- platform/qt/TestExpectations:
- 9:22 AM Changeset in webkit [133486] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark inspector-protocol/debugger-pause-dedicated-worker.html
as also crashy, and give it a bug ID. Unreviewed.
- platform/chromium/TestExpectations:
- 8:57 AM Changeset in webkit [133485] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r125237. <rdar://problem/12536461>
- 8:48 AM Changeset in webkit [133484] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r125234. <rdar://problem/12536433>
- 8:32 AM Changeset in webkit [133483] by
-
- 3 edits in trunk/Source/WebCore
Add a comment about a return value of IDBKey::toV8()
https://bugs.webkit.org/show_bug.cgi?id=101212
Reviewed by Adam Barth.
Although all other toV8(impl) return null when impl is 0,
IDBKey::toV8(impl) is expected to return undefined when impl is 0.
This patch adds a comment about it.
No tests.
- bindings/js/JSIDBKeyCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
- 8:23 AM Changeset in webkit [133482] by
-
- 6 edits6 adds in trunk
[Cairo] Make Cairo honor image orientation
https://bugs.webkit.org/show_bug.cgi?id=101207
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Implement transformed image drawing in BitmapImageCairo, similar
as it was done for Skia in bug 100179, r132384.
The image drawing code needs to transform the graphics context
depending on exif orientation in order for this to work.
No new tests, covered by fast/images/exif-* which are passing now.
- platform/graphics/BitmapImage.h: Enable draw function which respects image orientation for Cairo.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::draw): Apply ImageOrientation's transformFromDefault() transformation to context.
(WebCore):
LayoutTests:
Unskip and rebaseline exif orientation tests for EFL.
- platform/efl-wk1/TestExpectations: Tests not passing here yet, since DRT needs a setShouldRespectImageOrientation setting.
- platform/efl/TestExpectations: Unskipping three exif orientation tests.
- platform/efl/fast/images/exif-orientation-css-expected.png: Added.
- platform/efl/fast/images/exif-orientation-css-expected.txt: Added.
- platform/efl/fast/images/exif-orientation-expected.png: Added.
- platform/efl/fast/images/exif-orientation-expected.txt: Added.
- platform/efl/fast/images/exif-orientation-image-document-expected.png: Added.
- platform/efl/fast/images/exif-orientation-image-document-expected.txt: Added.
- 8:20 AM Changeset in webkit [133481] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebKit2
Merged r125176. <rdar://problem/12516381>
- 8:16 AM Changeset in webkit [133480] by
-
- 5 edits4 copies in branches/safari-536.28-branch
Merged r125162. <rdar://problem/12536458>
- 8:14 AM Changeset in webkit [133479] by
-
- 9 edits in trunk/Source/WebCore
[V8] Dispose() and Clear() should be always coupled for safety
https://bugs.webkit.org/show_bug.cgi?id=101191
Reviewed by Adam Barth.
Clear() is not mandatory. However, to avoid misusing already
disposed wrappers, Clear() should be always called just
after Dispose().
No tests. No change in behavior.
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperHashMap::defaultWeakCallback):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::IntrusiveDOMWrapperMap::weakCallback):
- bindings/v8/NPV8Object.cpp:
(WebCore::freeV8NPObject):
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::~ScheduledAction):
- bindings/v8/V8NPObject.cpp:
(WebCore::V8NPTemplateMap::dispose):
(WebCore::weakNPObjectCallback):
(WebCore::forgetV8ObjectForNPObject):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::dispose):
- bindings/v8/V8ValueCache.cpp:
(WebCore::cachedStringCallback):
(WebCore::IntegerCache::~IntegerCache):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::WeakReferenceCallback):
- 7:56 AM Changeset in webkit [133478] by
-
- 11 edits2 copies in branches/safari-536.28-branch
Merged r125147. <rdar://problem/12536499>
- 7:42 AM Changeset in webkit [133477] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Web Inspector: Add InspectorInstrumentaiton calls for timeline compositing.
https://bugs.webkit.org/show_bug.cgi?id=101213
RIM PR 178131
Reviewed by Rob Buis.
Internally Reviewed by Arvid Nilsson.
Added compositing events to the timeline for BlackBerry.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::willComposite):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::didComposite):
- Api/WebPage_p.h:
(WebPagePrivate):
- 7:29 AM Changeset in webkit [133476] by
-
- 12 edits in branches/safari-536.28-branch/Source
Merged r125091. <rdar://problem/12486152>
- 7:25 AM Changeset in webkit [133475] by
-
- 3 edits2 adds in trunk
[CSS Exclusions] Layout of the first shape-inside line can be incorrect
https://bugs.webkit.org/show_bug.cgi?id=100996
Patch by Hans Muller <hmuller@adobe.com> on 2012-11-05
Reviewed by Dirk Schulze.
Source/WebCore:
Made the conversion from floating point top/bottom logical shape bounds coordinates
LayoutUnits explicit and corrected the case where the top value was truncated. A
float logicalTop value is converted to LayoutUnit with fromFloatCeil() to ensure
that the LayoutUnit value is within the shape.
Test: fast/exclusions/shape-inside/shape-inside-shape-logical-top.html
- rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::shapeLogicalTop): Redefined this method in terms of shapeLogicalBoundsY,Max().
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBottom): Ditto.
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds): Ditto.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBoundsY): Explicit conversion from floating point shape coordinates to LayoutUnits.
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBoundsMaxY): Ditto.
LayoutTests:
Verify that the first line of shape-inside content is laid out correctly
when the top of the shape's bounds has a non-integral value.
- fast/exclusions/shape-inside/shape-inside-shape-logical-top-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-shape-logical-top.html: Added.
- 7:20 AM Changeset in webkit [133474] by
-
- 4 edits2 copies in branches/safari-536.28-branch
Merged r125052. <rdar://problem/12536419>
- 7:17 AM Changeset in webkit [133473] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark a flaky test. Unreviewed.
- platform/chromium/TestExpectations:
- 7:14 AM Changeset in webkit [133472] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r124924. <rdar://problem/12516358>
- 7:08 AM Changeset in webkit [133471] by
-
- 2 edits in trunk/LayoutTests
[chromium] Add a now-failing test, remove a now-passing test. Unreviewed.
- platform/chromium/TestExpectations:
- 7:06 AM Changeset in webkit [133470] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r124919. <rdar://problem/12516354>
- 7:02 AM Changeset in webkit [133469] by
-
- 2 edits in trunk/Source/WebCore
Protect against resource deletion during iteration in MemoryCache::pruneDeadResourcesToSize
https://bugs.webkit.org/show_bug.cgi?id=101211
Reviewed by Andreas Kling.
Some crashes have been seen under MemoryCache::pruneDeadResourcesToSize. A possible cause is that
destroyDecodedData() call ends up evicting the resource pointed by 'previous' pointer during iteration
and deleting the object. This looks in principle possible via stylesheets and SVG images.
Speculative fix, no repro, no obvious way to construct a test.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneDeadResourcesToSize):
Use CachedResourceHandle to protect the 'previous' pointer during iteration. Check if the
resource has been kicked out from the cache during destroyDecodedData() and stop iterating
if has (as it may die when CachedResourceHandle releases it).
The 'current' pointer is not protected as the resource it points to is allowed to die.
- 6:58 AM Changeset in webkit [133468] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r124914. <rdar://problem/12536456>
- 6:49 AM Changeset in webkit [133467] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r124888. <rdar://problem/12536408>
- 6:41 AM Changeset in webkit [133466] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r124843. <rdar://problem/12536452>
- 6:27 AM Changeset in webkit [133465] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=101199
Patch by Miguel Garcia <miguelg@chromium.org> on 2012-11-05
Reviewed by Julien Chaffraix.
Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
actually wired up internally. Disable the feature to avoid breaking feature detection
until we can implement it properly.
- features.gypi:
- 6:22 AM Changeset in webkit [133464] by
-
- 8 edits2 moves4 adds in trunk/Source/WebKit2
[EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS
https://bugs.webkit.org/show_bug.cgi?id=100674
Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Make a distinction between calling ewk_view_base_add and ewk_view_smart_add.
Calling ewk_view_base_add creates a desktop style view, that does not support
fixed layout size, while calling ewk_view_smart_add does support fixed layout size.
As a result, WebKitTestRunner and the inspector window do not support
fixed layout size, while MiniBrowser does. This change allows many DumpAsText
layout tests to pass without modification, when AC is enabled.
- PlatformEfl.cmake:
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::informLoadCommitted):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::informContentsSizeChange):
- UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
(EwkViewImpl::pageClient):
(EwkViewImpl::setScaleFactor):
(EwkViewImpl::scaleFactor):
(EwkViewImpl::setScrollPosition):
(EwkViewImpl::scrollPosition):
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):
(createEwkView):
(ewk_view_base_add):
- UIProcess/efl/PageClientBase.cpp: Copied from Source/WebKit2/UIProcess/efl/PageClientImpl.cpp.
(WebKit::PageClientBase::PageClientBase):
(WebKit::PageClientBase::~PageClientBase):
(WebKit::PageClientBase::viewImpl):
(WebKit::PageClientBase::createDrawingAreaProxy):
(WebKit::PageClientBase::setViewNeedsDisplay):
(WebKit::PageClientBase::displayView):
(WebKit::PageClientBase::scrollView):
(WebKit::PageClientBase::viewSize):
(WebKit::PageClientBase::isViewWindowActive):
(WebKit::PageClientBase::isViewFocused):
(WebKit::PageClientBase::isViewVisible):
(WebKit::PageClientBase::isViewInWindow):
(WebKit::PageClientBase::processDidCrash):
(WebKit::PageClientBase::didRelaunchProcess):
(WebKit::PageClientBase::pageClosed):
(WebKit::PageClientBase::toolTipChanged):
(WebKit::PageClientBase::setCursor):
(WebKit::PageClientBase::setCursorHiddenUntilMouseMoves):
(WebKit::PageClientBase::registerEditCommand):
(WebKit::PageClientBase::clearAllEditCommands):
(WebKit::PageClientBase::canUndoRedo):
(WebKit::PageClientBase::executeUndoRedo):
(WebKit::PageClientBase::convertToDeviceSpace):
(WebKit::PageClientBase::convertToUserSpace):
(WebKit::PageClientBase::screenToWindow):
(WebKit::PageClientBase::windowToScreen):
(WebKit::PageClientBase::doneWithKeyEvent):
(WebKit::PageClientBase::doneWithTouchEvent):
(WebKit::PageClientBase::createPopupMenuProxy):
(WebKit::PageClientBase::createContextMenuProxy):
(WebKit::PageClientBase::createColorChooserProxy):
(WebKit::PageClientBase::setFindIndicator):
(WebKit::PageClientBase::enterAcceleratedCompositingMode):
(WebKit::PageClientBase::exitAcceleratedCompositingMode):
(WebKit::PageClientBase::updateAcceleratedCompositingMode):
(WebKit::PageClientBase::didChangeScrollbarsForMainFrame):
(WebKit::PageClientBase::didCommitLoadForMainFrame):
(WebKit::PageClientBase::didFinishLoadingDataForCustomRepresentation):
(WebKit::PageClientBase::customRepresentationZoomFactor):
(WebKit::PageClientBase::setCustomRepresentationZoomFactor):
(WebKit::PageClientBase::flashBackingStoreUpdates):
(WebKit::PageClientBase::findStringInCustomRepresentation):
(WebKit::PageClientBase::countStringMatchesInCustomRepresentation):
(WebKit::PageClientBase::updateTextInputState):
(WebKit::PageClientBase::handleDownloadRequest):
- UIProcess/efl/PageClientBase.h: Copied from Source/WebKit2/UIProcess/efl/PageClientImpl.h.
(PageClientBase):
- UIProcess/efl/PageClientDefaultImpl.cpp: Added.
(WebKit):
(WebKit::PageClientDefaultImpl::PageClientDefaultImpl):
(WebKit::PageClientDefaultImpl::didCommitLoad):
(WebKit::PageClientDefaultImpl::updateViewportSize):
(WebKit::PageClientDefaultImpl::didChangeViewportProperties):
(WebKit::PageClientDefaultImpl::didChangeContentsSize):
(WebKit::PageClientDefaultImpl::pageDidRequestScroll):
(WebKit::PageClientDefaultImpl::didRenderFrame):
(WebKit::PageClientDefaultImpl::pageTransitionViewportReady):
- UIProcess/efl/PageClientDefaultImpl.h: Added.
(WebKit):
(PageClientDefaultImpl):
(WebKit::PageClientDefaultImpl::create):
(WebKit::PageClientDefaultImpl::~PageClientDefaultImpl):
- UIProcess/efl/PageClientImpl.cpp: Removed.
- UIProcess/efl/PageClientImpl.h: Removed.
- UIProcess/efl/PageClientLegacyImpl.cpp: Added.
(WebKit):
(WebKit::PageClientLegacyImpl::PageClientLegacyImpl):
(WebKit::PageClientLegacyImpl::didCommitLoad):
(WebKit::PageClientLegacyImpl::updateViewportSize):
(WebKit::PageClientLegacyImpl::didChangeViewportProperties):
(WebKit::PageClientLegacyImpl::didChangeContentsSize):
(WebKit::PageClientLegacyImpl::pageDidRequestScroll):
(WebKit::PageClientLegacyImpl::didRenderFrame):
(WebKit::PageClientLegacyImpl::pageTransitionViewportReady):
- UIProcess/efl/PageClientLegacyImpl.h: Added.
(WebKit):
(PageClientLegacyImpl):
(WebKit::PageClientLegacyImpl::create):
(WebKit::PageClientLegacyImpl::~PageClientLegacyImpl):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setContentsScale):
- UIProcess/efl/PageViewportControllerClientEfl.h:
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::viewWidget):
- 6:15 AM Changeset in webkit [133463] by
-
- 54 edits in trunk/Source/WebCore
Web Inspector: Fix jscompiler cast syntax
https://bugs.webkit.org/show_bug.cgi?id=101066
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-05
Reviewed by Pavel Feldman.
Casts should be in the form of "/ @type {TypeName} */ (expr)" instead of "/ @type {TypeName} */ expr".
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- inspector/InjectedScriptSource.js:
(.):
- inspector/front-end/ApplicationCacheModel.js:
(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):
- inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype._onRequestStarted):
(WebInspector.AuditLauncherView.prototype._onRequestFinished):
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype._uiSourceCodeFormatted):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.Breakpoint.prototype._locationUpdated):
(WebInspector.BreakpointManager.Storage):
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):
- inspector/front-end/CSSNamedFlowCollectionsView.js:
(WebInspector.CSSNamedFlowCollectionsView.prototype._documentUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._namedFlowCreated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._regionLayoutUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._selectedNodeChanged):
- inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSProfileHeader.prototype.createView):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.LiveLocation.prototype.uiLocation):
(WebInspector.CSSStyleDeclaration.parseComputedStylePayload):
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._frameAdded):
(WebInspector.ConsoleView.prototype._frameRemoved):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMDocument):
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointByURL):
(WebInspector.DebuggerModel.prototype.):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.CallFrame.prototype.get location):
- inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping.prototype._parsedScriptSource):
- inspector/front-end/DirectoryContentView.js:
(WebInspector.DirectoryContentView.prototype._sort):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._updateBreadcrumbIfNeeded):
- inspector/front-end/ElementsPanelDescriptor.js:
(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):
- inspector/front-end/ElementsTreeOutline.js:
(.get node):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype._notifyUISourceCodeContentCommitted):
(WebInspector.ExtensionServer.prototype._notifyRequestFinished):
- inspector/front-end/FileContentView.js:
(WebInspector.FileContentView.prototype._metadataReceived):
(WebInspector.FileContentView.FileContentProvider.prototype.requestContent):
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._frameAdded):
(WebInspector.FileSystemModel.prototype._frameNavigated):
(WebInspector.FileSystemModel.prototype._frameDetached):
- inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView.EntryTreeElement.prototype.onselect):
(WebInspector.FileSystemView.EntryTreeElement.prototype.refresh):
- inspector/front-end/HandlerRegistry.js:
(WebInspector.HandlerRegistry.prototype._appendHrefItems):
- inspector/front-end/HeapSnapshotLoader.js:
(WebInspector.HeapSnapshotLoader.prototype.write):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._changeBase):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._snapshotReceived):
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.prototype._frameNavigated):
(WebInspector.IndexedDBModel.prototype._frameDetached):
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._keyColumnHeaderFragment):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._handleGutterClick):
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype.show):
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._uiSourceCodeTitleChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyCommitted):
(WebInspector.NavigatorView.prototype._uiSourceCodeFormattedChanged):
- inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog.prototype._onRequestStarted):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._onRequestUpdated):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):
(WebInspector.NetworkPanel.prototype.reveal):
(WebInspector.NetworkPanel.prototype.appendApplicableItems):
- inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
- inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
- inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleMessageAdded):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
- inspector/front-end/ProfilesPanel.js:
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onRequestFinished):
(WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._databaseAdded):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBLoaded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemAdded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemTreeElementByName):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):
- inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView.prototype._uiSourceCodeRemoved):
- inspector/front-end/SASSSourceMapping.js:
(rawLocationToUILocation):
- inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update):
- inspector/front-end/Script.js:
(WebInspector.Script.Location.prototype.uiLocation):
- inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype.get _worker):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
(WebInspector.ScriptsPanel.prototype.canSearchAndReplace):
(WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
(WebInspector.ScriptsPanel.prototype.replaceAllWith):
(WebInspector.ScriptsPanel.prototype._toggleBreakpoint):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
- inspector/front-end/ScriptsPanelDescriptor.js:
(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._scrollChanged):
(WebInspector.TabbedEditorContainer.prototype._selectionChanged):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._tabSelected):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeTitleChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyCommitted):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeFormattedChanged):
- inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModelLoader.prototype.write):
- inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):
- inspector/front-end/Workspace.js:
(WebInspector.WorkspaceController.prototype._frameAdded):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
- 6:09 AM Changeset in webkit [133462] by
-
- 2 edits in trunk/LayoutTests
[Qt] Fix broken comment in WK2 TestExpectations
Unreviewed fix, just an obviously missing '#' character.
- platform/qt-5.0-wk2/TestExpectations:
- 6:08 AM Changeset in webkit [133461] by
-
- 2 edits in trunk/LayoutTests
fast/events/popup-allowed-from-gesture-initiated-event.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101208
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Close the new popup between each test to make sure the new window
does not mask the buttons and therefore prevent them from being
clicked. This addresses flakiness for this test.
- fast/events/popup-allowed-from-gesture-initiated-event.html:
- 5:43 AM Changeset in webkit [133460] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: render message bubbles in CodeMirror experiment.
https://bugs.webkit.org/show_bug.cgi?id=101164
Reviewed by Vsevolod Vlasov.
It sounds like addLineWidget just makes it happen.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.addDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.get if):
(WebInspector.CodeMirrorTextEditor.prototype.removeDecoration):
(WebInspector.CodeMirrorTextEditor.prototype._change):
- inspector/front-end/DefaultTextEditor.js:
(.preventDefaultOnMouseUp):
- inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper):
- inspector/front-end/cm/cmdevtools.css:
(.CodeMirror .webkit-html-message-bubble):
(.CodeMirror .webkit-html-message-bubble img):
(.CodeMirror .webkit-html-warning-message):
(.CodeMirror .webkit-html-error-message):
- 5:05 AM Changeset in webkit [133459] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed GTK gardening.
A followup to r133453, adding a baseline for http/tests/inspector/console-websocket-error.html.
- platform/gtk/http/tests/inspector: Added.
- platform/gtk/http/tests/inspector/console-websocket-error-expected.txt: Added.
- 4:47 AM Changeset in webkit [133458] by
-
- 8 edits2 adds in trunk
Validate CSS Device Adaptation properties and resolve shorthands
https://bugs.webkit.org/show_bug.cgi?id=95962
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-05
Reviewed by Alexis Menard.
Source/WebCore:
Add the missing keywords and properties for the viewport at-rule.
Note that we have to mark that we are inside a viewport scope because
some properties are not validated as they would be inside a style
rule. As an example, the semantics of CSSPropertyWidth are completely
different: on a viewport rule, it stands for a shorthand for the
minimum and maximum width.
Test: css3/device-adapt/viewport-properties-validation.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore):
(WebCore::CSSParser::parseViewportProperty):
(WebCore::CSSParser::parseViewportShorthand):
- css/CSSParser.h:
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
LayoutTests:
Added a test for CSS Device Adaptation property parsing validation.
- css3/device-adapt/viewport-properties-validation-expected.txt: Added.
- css3/device-adapt/viewport-properties-validation.html: Added.
- 4:39 AM Changeset in webkit [133457] by
-
- 18 edits in trunk/Source/WebKit2
[EFL][WK2] Make Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data Ewk_Objects
https://bugs.webkit.org/show_bug.cgi?id=101205
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-05
Reviewed by Gyuyoung Kim.
Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data are using common Ewk_Object interface now.
- UIProcess/API/efl/EwkViewImpl.h:
- UIProcess/API/efl/ewk_download_job.cpp:
(Ewk_Download_Job::request):
(Ewk_Download_Job::response):
(Ewk_Download_Job::setResponse):
- UIProcess/API/efl/ewk_download_job_private.h:
(Ewk_Download_Job):
- UIProcess/API/efl/ewk_navigation_data.cpp:
(EwkNavigationData::EwkNavigationData):
(EwkNavigationData::originalRequest):
(EwkNavigationData::title):
(EwkNavigationData::url):
(ewk_navigation_data_title_get):
(ewk_navigation_data_original_request_get):
(ewk_navigation_data_url_get):
- UIProcess/API/efl/ewk_navigation_data.h:
- UIProcess/API/efl/ewk_navigation_data_private.h:
(EwkNavigationData):
(EwkNavigationData::create):
- UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
(Ewk_Navigation_Policy_Decision::Ewk_Navigation_Policy_Decision):
(Ewk_Navigation_Policy_Decision::request):
- UIProcess/API/efl/ewk_navigation_policy_decision_private.h:
(Ewk_Navigation_Policy_Decision::create):
(Ewk_Navigation_Policy_Decision):
- UIProcess/API/efl/ewk_url_request.cpp:
(EwkUrlRequest::EwkUrlRequest):
(EwkUrlRequest::url):
(EwkUrlRequest::firstParty):
(EwkUrlRequest::httpMethod):
(ewk_url_request_url_get):
(ewk_request_cookies_first_party_get):
(ewk_url_request_http_method_get):
- UIProcess/API/efl/ewk_url_request.h:
- UIProcess/API/efl/ewk_url_request_private.h:
(EwkUrlRequest):
(EwkUrlRequest::create):
- UIProcess/API/efl/ewk_url_response.cpp:
(EwkUrlResponse::EwkUrlResponse):
(EwkUrlResponse::httpStatusCode):
(EwkUrlResponse::url):
(EwkUrlResponse::mimeType):
(EwkUrlResponse::contentLength):
(ewk_url_response_url_get):
(ewk_url_response_status_code_get):
(ewk_url_response_mime_type_get):
(ewk_url_response_content_length_get):
- UIProcess/API/efl/ewk_url_response.h:
- UIProcess/API/efl/ewk_url_response_private.h:
(EwkUrlResponse):
(EwkUrlResponse::create):
- UIProcess/efl/ContextHistoryClientEfl.cpp:
(WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):
- UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::didReceiveResponse):
- UIProcess/efl/ResourceLoadClientEfl.cpp:
(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):
- 4:23 AM Changeset in webkit [133456] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Remove a few tests which depend on setIsolatedWorldSecurityOrigin
since they are already skipped in efl/TestExpectations.
- platform/efl-wk2/TestExpectations:
- 4:14 AM Changeset in webkit [133455] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] EWK2UnitTestBase.ewk_auth_request_cancel API test is failing after r133389
https://bugs.webkit.org/show_bug.cgi?id=101203
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Attempt for continue without credential when the client cancels
authentication (or does not handle the authentication request)
instead of cancelling the load. We now get a 402 error when
when cancelling the authentication, which is the behavior we
want (and the behavior we used to have before r133389).
- UIProcess/API/efl/ewk_auth_request.cpp:
(Ewk_Auth_Request::~Ewk_Auth_Request):
(Ewk_Auth_Request::continueWithoutCredential):
(ewk_auth_request_cancel):
- UIProcess/API/efl/ewk_auth_request_private.h:
(Ewk_Auth_Request):
- UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
(TEST_F):
- 3:50 AM Changeset in webkit [133454] by
-
- 2 edits in trunk/LayoutTests
[EFL] fast/forms/week-multiple-fields does not exist and should be removed from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=101202
Unreviewed EFL gardening.
Remove fast/forms/week-multiple-fields from TestExpections since it does
not exist and makes the style script complain.
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
- platform/efl/TestExpectations:
- 3:43 AM Changeset in webkit [133453] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Clean up the inspector-related test expectations. Instead of marking
many tests as skipped, proper failure expectations are put in place.
The tests are still being skipped as their current behavior on the
buildbots is unknown.
- platform/gtk/TestExpectations:
- 2:57 AM Changeset in webkit [133452] by
-
- 2 edits in trunk/Tools
[EFL] Fix build warning in EWebLauncher/main.c
https://bugs.webkit.org/show_bug.cgi?id=101197
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-05
Reviewed by Kentaro Hara.
Because the strp of _Ecore_Getopt_Value is char (Ecore_Getopt.h),
The parameter of ECORE_GETOPT_VALUE_STR should be char*
- EWebLauncher/main.c:
(_User_Arguments):
- 2:47 AM Changeset in webkit [133451] by
-
- 11 edits in trunk/Source/WebCore
Unreviewed, rolling out r133286, r133385, and r133394.
http://trac.webkit.org/changeset/133286
http://trac.webkit.org/changeset/133385
http://trac.webkit.org/changeset/133394
https://bugs.webkit.org/show_bug.cgi?id=101198
Broke image placement on some web sites. (Requested by kling
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-05
- css/StyleResolver.cpp:
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::canShareStyleWithElement):
- dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):
- dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
(WebCore::Element::cloneAttributesFromElement):
- dom/Element.h:
(Element):
(WebCore::Element::updateInvalidAttributes):
- dom/ElementAttributeData.cpp:
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore):
(WebCore::attrListMap):
(WebCore::attrListForElement):
(WebCore::ensureAttrListForElement):
(WebCore::removeAttrListForElement):
(WebCore::findAttrInList):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::reportMemoryUsage):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::getAttributeNode):
- dom/ElementAttributeData.h:
(WebCore):
(WebCore::ElementAttributeData::attributeStyle):
(WebCore::ElementAttributeData::setAttributeStyle):
(ElementAttributeData):
(WebCore::ElementAttributeData::ElementAttributeData):
- dom/Node.h:
(WebCore):
(WebCore::Node::hasAttrList):
(WebCore::Node::attributeStyleDirty):
(WebCore::Node::setAttributeStyleDirty):
(WebCore::Node::clearAttributeStyleDirty):
(Node):
(WebCore::Node::setHasAttrList):
(WebCore::Node::clearHasAttrList):
(WebCore::Node::isStyleAttributeValid):
(WebCore::Node::setIsStyleAttributeValid):
(WebCore::Node::clearIsStyleAttributeValid):
- dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::updateAttributeStyle):
- dom/StyledElement.h:
(StyledElement):
(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::attributeStyle):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
- 2:36 AM EFLWebKitCodingStyle edited by
- Remove . at the end of @ field. (diff)
- 2:34 AM Changeset in webkit [133450] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Add --window-size command line option to EFL MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=100942
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Added window-size (-s) command line option to EFL MiniBrowser.
- MiniBrowser/efl/main.c:
(window_create):
(parse_window_size):
(elm_main):
- 2:25 AM Changeset in webkit [133449] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Skip fast/dom/shadow/shadowroot-type.html because SHADOW_DOM is disabled.
- platform/qt/TestExpectations:
- 2:12 AM Changeset in webkit [133448] by
-
- 2 edits in trunk
[Qt] Trivial unreviewed: Add missing module dependencies for builds in Qt CI system.
These fields aren't used by anyone except some perl scripts in the Qt CI builds.
- Source/sync.profile:
- 2:12 AM Changeset in webkit [133447] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed trivial Qt build fix.
Surround imports from QtGui by QT_{BEGIN,END}_NAMESPACE to fix namespaced
builds.
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/qt/ImageQt.cpp:
- 1:53 AM Changeset in webkit [133446] by
-
- 22 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining MathML tests after r132264 and r133221 and updating
pixel baselines with outdated hash.
- platform/gtk/TestExpectations:
- platform/gtk/mathml/presentation/attributes-expected.png:
- platform/gtk/mathml/presentation/fenced-expected.png:
- platform/gtk/mathml/presentation/fenced-expected.txt:
- platform/gtk/mathml/presentation/mo-expected.png:
- platform/gtk/mathml/presentation/mo-expected.txt:
- platform/gtk/mathml/presentation/mo-stretch-expected.png:
- platform/gtk/mathml/presentation/mo-stretch-expected.txt:
- platform/gtk/mathml/presentation/mroot-pref-width-expected.png:
- platform/gtk/mathml/presentation/over-expected.png:
- platform/gtk/mathml/presentation/over-expected.txt:
- platform/gtk/mathml/presentation/roots-expected.png:
- platform/gtk/mathml/presentation/row-alignment-expected.png:
- platform/gtk/mathml/presentation/row-alignment-expected.txt:
- platform/gtk/mathml/presentation/row-expected.png:
- platform/gtk/mathml/presentation/row-expected.txt:
- platform/gtk/mathml/presentation/style-expected.png:
- platform/gtk/mathml/presentation/subsup-expected.png:
- platform/gtk/mathml/presentation/subsup-expected.txt:
- platform/gtk/mathml/presentation/tables-expected.png:
- platform/gtk/mathml/presentation/tables-expected.txt:
- 1:33 AM Changeset in webkit [133445] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip compositing/repaint/invalidations-on-composited-layers.html
https://bugs.webkit.org/show_bug.cgi?id=101181
Unreviewed EFL gardening.
Mark compositing/repaint/invalidations-on-composited-layers.html as
expected to fail since accelerated compositing is disabled by default
on EFL port.
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
- platform/efl/TestExpectations:
- 1:23 AM Changeset in webkit [133444] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Skipping ENABLE_SUBPIXEL- and ENABLE_INPUT_TYPE_*-related testing
directories. These features are not enabled yet and most of the
tests fail.
Removing failure expectation for fast/files/workers/worker-apply-blob-url-to-xhr.html,
the issue was fixed in r132973.
Moving the skip entry for css3/device-adapt to the proper section.
- platform/gtk/TestExpectations:
- 1:05 AM Changeset in webkit [133443] by
-
- 6 edits2 adds in trunk
[Shadow] ShadowRoot type is not set correctly.
https://bugs.webkit.org/show_bug.cgi?id=101188
Reviewed by Hajime Morita.
Source/WebCore:
ShadowRoot type is not set correctly in Release build. We have had to remove #ifndef block.
Test: fast/dom/shadow/shadowroot-type.html
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
- testing/Internals.cpp:
(WebCore::Internals::shadowRootType):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
- fast/dom/shadow/shadowroot-type-expected.txt: Added.
- fast/dom/shadow/shadowroot-type.html: Added.
- 12:55 AM Changeset in webkit [133442] by
-
- 9 edits in trunk
[EFL][WK2] The icon database path should be set by the client
https://bugs.webkit.org/show_bug.cgi?id=101182
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
No longer set the favicon database path in database instance getter.
Instead, a new ewk_context_favicon_database_directory_set() API
function was added to let the client set the icon database path.
This is needed because the icon database path can only be set once
and setting it unconditionally in the getter prevents the client
from setting it.
This will also avoid crashes in WebKitTestRunner since WKTR was
setting the path once and ewk_context was attempting to override it.
Note that the favicon database functionality is disabled until the
client sets its path.
- UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::ensureFaviconDatabase):
(Ewk_Context::setFaviconDatabaseDirectoryPath):
(Ewk_Context::faviconDatabase):
(ewk_context_favicon_database_directory_set):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_private.h:
(Ewk_Context):
- UIProcess/API/efl/ewk_favicon_database.cpp:
(Ewk_Favicon_Database::Ewk_Favicon_Database):
(Ewk_Favicon_Database::~Ewk_Favicon_Database):
(Ewk_Favicon_Database::iconURLForPageURL):
(Ewk_Favicon_Database::iconForPageURL):
(Ewk_Favicon_Database::getIconSurfaceSynchronously):
- UIProcess/API/efl/ewk_favicon_database_private.h:
(WebKit):
(Ewk_Favicon_Database::create):
(Ewk_Favicon_Database):
- UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
(TEST_F):
Tools:
Enable favicon database functionality in MiniBrowser since
it is used and it is no longer enabled by default.
- MiniBrowser/efl/main.c:
(elm_main):
- 12:22 AM Changeset in webkit [133441] by
-
- 6 edits in trunk/Source/WebCore
BaseChooserOnlyDateAndTimeInputType should implement DateTimeChooserClient
https://bugs.webkit.org/show_bug.cgi?id=101038
Reviewed by Hajime Morita.
Add DateTimeChooserClient behavior to BaseChooserOnlyDateAndTimeInputType.
It means that date/time input elements without
ENABLE_INPUT_MULTIPLE_FIELDS_UI can open date/time choosers by
DOMActivate event.
This patch doesn't change behavior yet because Chromimum-Android port
intercepts user events and doesn't deliver them to date/time input
elements. <http://crbug.com/159381>
- html/BaseChooserOnlyDateAndTimeInputType.cpp:
Add DateTimeChooserClient behavior. The code is similar to
PickerIndicatorElement.
(WebCore::BaseChooserOnlyDateAndTimeInputType::~BaseChooserOnlyDateAndTimeInputType):
Closes DateTimeChooser.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
Open DateTimeChooser if
- The element is not disabled,
- The element is not read-only,
- The element has a renderer,
- This event is created by a user gesture, and
- The element has no DateTimeChooser.
(WebCore::BaseChooserOnlyDateAndTimeInputType::detach):
Closes DateTimeChooser.
(WebCore::BaseChooserOnlyDateAndTimeInputType::didChooseValue):
Set a string value coming from a chooser to the input element.
(WebCore::BaseChooserOnlyDateAndTimeInputType::didEndChooser):
Clear m_dateTimeChooser when the chooser was closed.
(WebCore::BaseChooserOnlyDateAndTimeInputType::closeDateTimeChooser):
Requests to close the chooser.
- html/BaseChooserOnlyDateAndTimeInputType.h:
(BaseChooserOnlyDateAndTimeInputType):
- Implement DateTimeChooserClient
- Add closeDateTimeChooser helper function.
- Add detach override.
- Add m_dateTimeChooser.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):
Added. The code is moved from PickerIndicatorElement.cpp in order to
share it with BaseChooserOnlyDateAndTimeInputType.
- html/HTMLInputElement.h:
(HTMLInputElement): Declare setupDateTimeChooserParameters.
- html/shadow/PickerIndicatorElement.cpp:
(WebCore::PickerIndicatorElement::openPopup):
Move some code to HTMLInputElement::setupDateTimeChooserParameters.
- 12:04 AM Changeset in webkit [133440] by
-
- 2 edits135 moves16 adds in trunk/LayoutTests
2012-11-04 Kent Tamura <tkent@chromium.org>
Move *-multiple-fields-appearance-*.html from fast/forms/*-multiple-fields/ to fast/forms/*/
https://bugs.webkit.org/show_bug.cgi?id=101186
Rubber-stamped by Kentaro Hara.
The fast/forms/{date,month,time,week}-multiple-fields/
{date,month,time,week}-multiple-fields-appearance-*.html tests don't
depend on the multiple-fields UI, and should work for non
multiple-fields configuration too. They should be moved to
fast/forms/{date,month,time,week}/.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html: Removed.
- fast/forms/date/date-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.txt.
- fast/forms/date/date-appearance-basic.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic.html.
- fast/forms/date/date-appearance-l10n-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.txt.
- fast/forms/date/date-appearance-l10n.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n.html.
- fast/forms/date/date-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.txt.
- fast/forms/date/date-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html.
- fast/forms/date/date-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt.
- fast/forms/date/date-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html.
- fast/forms/date/date-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.txt.
- fast/forms/date/date-appearance-style.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html: Removed.
- fast/forms/month/month-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.txt.
- fast/forms/month/month-appearance-basic.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html.
- fast/forms/month/month-appearance-l10n-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.txt.
- fast/forms/month/month-appearance-l10n.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html.
- fast/forms/month/month-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.txt.
- fast/forms/month/month-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html.
- fast/forms/month/month-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt.
- fast/forms/month/month-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html.
- fast/forms/month/month-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.txt.
- fast/forms/month/month-appearance-style.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: Removed.
- fast/forms/time/time-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt.
- fast/forms/time/time-appearance-basic.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html.
- fast/forms/time/time-appearance-disabled-readonly-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt.
- fast/forms/time/time-appearance-disabled-readonly.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html.
- fast/forms/time/time-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt.
- fast/forms/time/time-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html.
- fast/forms/time/time-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt.
- fast/forms/time/time-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html.
- fast/forms/time/time-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt.
- fast/forms/time/time-appearance-style.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html: Removed.
- fast/forms/week/week-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt.
- fast/forms/week/week-appearance-basic.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html.
- fast/forms/week/week-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.txt.
- fast/forms/week/week-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html.
- fast/forms/week/week-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt.
- fast/forms/week/week-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html.
- fast/forms/week/week-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.txt.
- fast/forms/week/week-appearance-style.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
- platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-linux/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-linux/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
- platform/chromium-linux/fast/forms/month: Added.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
- platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-linux/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-linux/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
- platform/chromium-linux/fast/forms/time: Added.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
- platform/chromium-linux/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
- platform/chromium-linux/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-linux/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
- platform/chromium-linux/fast/forms/week: Added.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
- platform/chromium-linux/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-linux/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-lion/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-lion/fast/forms/month: Added.
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-lion/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-lion/fast/forms/time: Added.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-lion/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
- platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-lion/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-lion/fast/forms/week: Added.
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-lion/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/month: Added.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/time: Added.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/week: Added.
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-mac/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac/fast/forms/month: Added.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-mac/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac/fast/forms/time: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
- platform/chromium-mac/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
- platform/chromium-mac/fast/forms/week: Added.
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
- platform/chromium-mac/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-mac/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
- platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-win-xp/fast/forms/month: Added.
- platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
- platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-win/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-win/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
- platform/chromium-win/fast/forms/month: Added.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
- platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
- platform/chromium-win/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-win/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
- platform/chromium-win/fast/forms/time: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
- platform/chromium-win/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
- platform/chromium-win/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-win/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
- platform/chromium-win/fast/forms/week: Added.
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
- platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
- platform/chromium-win/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
- platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
- platform/chromium-win/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
- platform/chromium/TestExpectations:
Nov 4, 2012:
- 11:55 PM Changeset in webkit [133439] by
-
- 8 edits4 adds in trunk
Fix the collapsing border code to handle mixed directionality at the row level
https://bugs.webkit.org/show_bug.cgi?id=101060
Reviewed by Ojan Vafai.
Source/WebCore:
After bug 87900, we support mixed directionality at the row-group level. For coherency
- as the underlying code didn't support it - we were artificially ignoring 'direction'
below the row-group. This change relaxes the restriction and patches the collapsing
borders code to query the right style and border.
Tests: fast/table/border-collapsing/table-ltr-rows-mixed-direction.html
fast/table/border-collapsing/table-rtl-row-mixed-direction.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::tableStartBorderAdjoiningCell):
(WebCore::RenderTable::tableEndBorderAdjoiningCell):
Changed to query the row's direction.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::hasStartBorderAdjoiningTable):
(WebCore::RenderTableCell::hasEndBorderAdjoiningTable):
Added 2 helper functions. They determine if a specific cell's border
adjoins the table. This code is required as the last cell's end border
can be resolved against the start border.
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Updated these functions now that being the start / end column doesn't mean
that we have to resolve against the row / row-group / table's border.
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::styleForCellFlow):
Updated to return the row's style.
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::borderAdjoiningStartCell):
(WebCore::RenderTableRow::borderAdjoiningEndCell):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::borderAdjoiningStartCell):
(WebCore::RenderTableSection::borderAdjoiningEndCell):
Updated these functions to work with mixed directionality.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setLogicalPositionForCell):
Changed this function to use the section's direction. This is wrong and should be changed
once we properly fix the collapsing border code.
(WebCore::RenderTableSection::logicalRectForWritingModeAndDirection):
Added a FIXME.
- rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::width):
This is a bug in our implementation: we used to return a non-zero width for inexistant borders (per CSS 2.1,
'border-style: off | hidden' should have a 0 width). This is covered by our existing tests (among others by
fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl.html).
LayoutTests:
- fast/table/border-collapsing/table-ltr-rows-mixed-direction-expected.html: Added.
- fast/table/border-collapsing/table-ltr-rows-mixed-direction.html: Added.
- fast/table/border-collapsing/table-rtl-row-mixed-direction-expected.html: Added.
- fast/table/border-collapsing/table-rtl-row-mixed-direction.html: Added.
- 11:52 PM Changeset in webkit [133438] by
-
- 4 edits1 move5 adds in trunk
Web Inspector: [Canvas] do not blow up the capturing log
https://bugs.webkit.org/show_bug.cgi?id=100752
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-04
Reviewed by Pavel Feldman.
Source/WebCore:
Clear obsolete calls in the canvas 2D capturing log in runtime.
Now we store in the log only minimum number of calls that are necessary to replay a
canvas 2D context. To achieve that we find in runtime those calls in the log that no
longer contribute to the final context state and remove them.
These are the rules according which we find and remove such calls:
- all PATH methods between a clip() call and beginPath() call can be removed
- all MATRIX methods before a restore() or setTransform() call but after any PATH or corresponding save() method
- all consecutive save() + restore() calls
Tests: inspector/profiler/canvas2d/canvas2d-api-changes.html
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
LayoutTests:
Added test for track Canvas 2D API changes, as well as basics for the capturing.
- inspector/profiler/canvas-profiler-test.js: Renamed from LayoutTests/inspector/profiler/webgl/webgl-profiler-test.js.
(initialize_CanvasWebGLProfilerTest.InspectorTest.enableCanvasAgent):
(initialize_CanvasWebGLProfilerTest):
(createWebGLContext):
(createCanvas2DContext):
- inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt: Added.
- inspector/profiler/canvas2d/canvas2d-api-changes.html: Added.
- inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics-expected.txt: Added.
- inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html: Added.
- inspector/profiler/webgl/webgl-profiler-get-error.html:
- 11:49 PM Changeset in webkit [133437] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Skip a new failing test introduced in r133428, because SHADOW_DOM is disabled.
Unskip a test that does not exist already.
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-11-04
- platform/qt/TestExpectations:
- 11:30 PM Changeset in webkit [133436] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for accessibility/svg-remote-element,
fast/images/exif-orientation-image-document.html and
svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg.
Rebaselining fast/images/repaint-subrect-grid.html, the new baseline
matches the one Mac port uses.
- platform/gtk/TestExpectations:
- platform/gtk/fast/images/repaint-subrect-grid-expected.txt: Added.
- 11:29 PM Changeset in webkit [133435] by
-
- 2 edits in trunk/Source/WebCore
[Shadow] ShadowRoot should have a method to return ShadowRootType.
https://bugs.webkit.org/show_bug.cgi?id=101178
Reviewed by Hajime Morita.
When we style PseudoCustomElement, we have to know ShadowRootType.
We would like to expose a method to get ShadowRootType also in Release mode.
This is a preparation patch for Bug 101170.
- dom/ShadowRoot.h:
(ShadowRoot):
- 11:13 PM Changeset in webkit [133434] by
-
- 8 edits in trunk
Introduce Month class to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101024
Reviewed by Kent Tamura.
Source/WebCore:
Month class needs to be introduced to implement a month picker. This
patch just introduces the Month class into the calendar picker without
changing the current behavior.
No new tests. Covered by existing calendar-picker-*.html tests.
- Resources/pagepopups/calendarPicker.js:
(Month.prototype.toLocaleString): Returns a localized month string.
(Month): Takes a Month object, number representing the month, or year and month numbers.
(Month.parse): Returns a new Month from an ISO month string.
(Month.createFromDate): Returns a new Month containing the given datetime.
(Month.prototype.equals): Returns true if the given month is the same.
(Month.prototype.previous): Returns the previous month.
(Month.prototype.next): Returns the next month.
(Month.prototype.startDate): Returns a datetime that is the start of this month. The value is inclusive.
(Month.prototype.endDate): Returns a datetime that is the end of this month. The value is exclusive.
(Month.prototype.valueOf): Returns a number representing the month.
(Month.prototype.toString): Returns an ISO month string.
(YearMonthController): Use Month object.
(YearMonthController.prototype.attachTo): Year 275760 ends in September so use the year before to measure the label width.
(YearMonthController.prototype.setMonth): Take a month object.
(YearMonthController.prototype._redraw): Use ISO month string for element.dataset.value.
(YearMonthController.prototype._handleYearMonthChange):
(YearMonthController.prototype.moveRelatively):
(DaysTable): Use Month object.
(DaysTable.prototype._renderMonth): Take a month object. Testing for isNaN is moved up to fix a bug when showing September, 275760.
(DaysTable.prototype._navigateToMonth): Take a month object.
(DaysTable.prototype._navigateToMonthWithAnimation): Take a month object.
(DaysTable.prototype.navigateToMonthAndKeepSelectionPosition): Take a month object.
(DaysTable.prototype.selectDate):
(DaysTable.prototype._maybeSetPreviousMonth): Use Month object to calculate the previous month.
(DaysTable.prototype._maybeSetNextMonth): Use Month object to calculate the next month.
LayoutTests:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html: Adjust the expectation because we changed the month string format.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html: Ditto.
- 10:17 PM Changeset in webkit [133433] by
-
- 2 edits31 deletes in trunk/LayoutTests
Remove obsolete tests for date/time input types
https://bugs.webkit.org/show_bug.cgi?id=98783
Reviewed by Kentaro Hara.
*-input-visible-string.html and *-stepup-stepdown-from-renderer.html are
unnecessary and should be removed because they depend on textfield
behavior, and the date/time input types no longer have textfield
behavior on any platforms.
- fast/forms/datetime/datetime-input-visible-string-expected.txt: Removed.
- fast/forms/datetime/datetime-input-visible-string.html: Removed.
- fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Removed.
- fast/forms/datetimelocal/datetimelocal-input-visible-string.html: Removed.
- fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/month/month-input-visible-string-expected.txt: Removed.
- fast/forms/month/month-input-visible-string.html: Removed.
- fast/forms/month/month-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/month/month-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/time/time-input-visible-string-expected.txt: Removed.
- fast/forms/time/time-input-visible-string.html: Removed.
- fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/time/time-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/week/week-input-visible-string-expected.txt: Removed.
- fast/forms/week/week-input-visible-string.html: Removed.
- fast/forms/week/week-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/week/week-stepup-stepdown-from-renderer.html: Removed.
- platform/chromium-android/fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/datetime/datetime-input-visible-string-expected.txt: Removed.
- platform/chromium/fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Removed.
- platform/chromium/fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Removed.
- platform/chromium/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Removed.
- platform/chromium/fast/forms/month/month-input-visible-string-expected.txt: Removed.
- platform/chromium/fast/forms/month/month-stepup-stepdown-from-renderer-expected.txt: Removed.
- platform/chromium/fast/forms/time/time-input-visible-string-expected.txt: Removed.
- platform/chromium/fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Removed.
- platform/chromium/fast/forms/week/week-input-visible-string-expected.txt: Removed.
- platform/chromium/fast/forms/week/week-stepup-stepdown-from-renderer-expected.txt: Removed.
- 9:35 PM FeatureFlags edited by
- Remove UNDO_MANAGER (diff)
- 9:33 PM Changeset in webkit [133432] by
-
- 6 edits in trunk/Source
[EFL] Use _LIBRARIES instead of _LIBRARY
https://bugs.webkit.org/show_bug.cgi?id=101042
Patch by Halton Huo <halton.huo@intel.com> on 2012-11-04
Reviewed by Gyuyoung Kim.
In CMake Find files, _LIBRARY is intended for internal use, should
use _LIBRARIES instead.
Source/WebCore:
- PlatformEfl.cmake: s/_LIBRARY}/_LIBRARIES}
Source/WebKit:
- PlatformEfl.cmake: s/_LIBRARY}/_LIBRARIES}
Source/WebKit2:
- PlatformEfl.cmake: s/_LIBRARY}/_LIBRARIES}
- 9:22 PM Changeset in webkit [133431] by
-
- 2 edits in trunk/LayoutTests
[EFL][DRT] Skip a fast/images/repaint-subrect-grid.html test case after r133322
https://bugs.webkit.org/show_bug.cgi?id=101175
Unreviewed gardening.
fast/images/repaint-subrect-grid.html is failing on WK1 debug bot.
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-04
- platform/efl-wk1/TestExpectations:
- 7:13 PM Changeset in webkit [133430] by
-
- 4 edits in trunk/Source/JavaScriptCore
Baseline JIT should use structure watchpoints whenever possible
https://bugs.webkit.org/show_bug.cgi?id=101146
Reviewed by Sam Weinig.
No speed-up yet except on toy programs. I think that it will start to show
speed-ups with https://bugs.webkit.org/show_bug.cgi?id=101147, which this is
a step towards.
- jit/JIT.h:
(JIT):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::addStructureTransitionCheck):
(JSC):
(JSC::JIT::testPrototype):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- 7:09 PM Changeset in webkit [133429] by
-
- 10 edits in trunk/Source
Shadow DOM should be able to be disabled per context.
https://bugs.webkit.org/show_bug.cgi?id=101173
Reviewed by Dimitri Glazkov.
Source/WebCore:
This change pulls back relevant bits from r131549. Note that if
the the port enables runtime Shadow DOM flag, this can cause slow
down on some Chromium page cycler test cases (which r131549
attempted to fix).
This change is temporal and the flags should be switched back from
ContextFeatures to RuntimeEnabledFeatures once it gains sufficent
stability.
- dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::shadowDOMEnabled):
(WebCore):
- dom/ContextFeatures.h:
- dom/Position.cpp:
(WebCore::Position::Position):
(WebCore::Position::findParent):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection):
- html/HTMLTagNames.in:
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::contentTagName):
- page/DOMWindow.idl:
Source/WebKit/chromium:
- src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):
- 7:04 PM Changeset in webkit [133428] by
-
- 5 edits2 adds in trunk
[Shadow] Implement custom pseudo-elements styling
https://bugs.webkit.org/show_bug.cgi?id=100812
Reviewed by Hajime Morita.
Source/WebCore:
Instead of using ElementRareData::m_shadowPseudoId, we use 'pseudo' attribute.
Later we would like to remove Element::shadowPseudoId and Element::setShadowPseudoId
and use pseudo()/setPseudo() instead (Bug 101171).
Test: fast/dom/shadow/styling-pseudo-attribute.html
- dom/Element.cpp:
(WebCore::Element::shadowPseudoId):
(WebCore::Element::setShadowPseudoId):
- dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
- dom/ElementRareData.h:
(ElementRareData):
LayoutTests:
- fast/dom/shadow/styling-pseudo-attribute-expected.html: Added.
- fast/dom/shadow/styling-pseudo-attribute.html: Added.
- 3:16 PM Changeset in webkit [133427] by
-
- 6 edits in trunk/Source/WebCore
BaseChooserOnlyDateAndTimeInputType should have BaseClickableWithKeyInputType behavior
https://bugs.webkit.org/show_bug.cgi?id=101039
Reviewed by Hajime Morita.
Add BaseClickableWithKeyInputType behavior to
BaseChooserOnlyDateAndTimeInputType. It means date/time input types
without ENABLE_INPUT_MULTIPLE_FIELDS_UI receive DOMActivate events by
pressing space or enter key. They're going to open a date/time chooser
by DOMActive event.
Because BaseChooserOnlyDateAndTimeInputType inherits from
BaseDateAndTimeInputType, it can't inherit
BaseClickableWithKeyInputType. So, this patch adds static helper
functions to BaseClickableWithKeyInputType, and
BaseChooserOnlyDateAndTimeInputType uses them.
This patch doesn't change behavior yet because Chromimum-Android port
intercepts user events and doesn't deliver them to date/time input
elements.
- html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
Add an empty implementation with a FIXME comment.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeydownEvent):
Add BaseClickableWithKeyInputType behavior by a helper function.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeypressEvent): Ditto.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeyupEvent): Ditto.
(WebCore::BaseChooserOnlyDateAndTimeInputType::accessKeyAction): Ditto.
- html/BaseChooserOnlyDateAndTimeInputType.h:
(BaseChooserOnlyDateAndTimeInputType): Add function declarations.
- html/BaseClickableWithKeyInputType.cpp:
Add static helper functions, and existing member functions use them.
- html/BaseClickableWithKeyInputType.h:
(BaseClickableWithKeyInputType): Add declarations of the helper functions.
- html/InputType.h:
(InputType): Make dispatchSimulatedClickIfActive public because it is
called from a helper function.
- 2:30 PM Changeset in webkit [133426] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r133416.
http://trac.webkit.org/changeset/133416
https://bugs.webkit.org/show_bug.cgi?id=101169
Broke world selection by right click (Requested by rniwa on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-04
Source/WebCore:
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
(WebCore::EventHandler::sendContextMenuEvent):
LayoutTests:
- fast/events/touch/gesture/disabled-input-text-selection-expected.txt: Removed.
- fast/events/touch/gesture/disabled-input-text-selection.html: Removed.
- platform/chromium/TestExpectations:
- 2:26 PM Changeset in webkit [133425] by
-
- 5 edits in trunk/Source/WebKit2
Expose security origin to BundleFrame
https://bugs.webkit.org/show_bug.cgi?id=101139
<rdar://problem/12629900>
Reviewed by Darin Adler.
Create a WebSecurityOrigin instance, sharing the security origin instance
that comes directly from the frame's document. We can do this because the
WK2 API only retrieves information about the origin, and because those
results are returned as copies. The security origin holds no references
that could lead to a retain cycle, avoiding the possibility that the
injected bundle accidentally keeps something alive.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedAPI): Create copied API for WebCore::SecurityOrigin
instances.
- Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::create): Add a new create() function that
takes a PassRefPtr to a WebCore SecurityOrigin instance.
(WebKit::WebSecurityOrigin::createFromString): Refactor to use new create()
function.
(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier): Refactor to
use new create() function.
(WebKit::WebSecurityOrigin::create): Refactor to use new create()
function.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopySecurityOrigin): Add function to retrieve the security
origin as a WK2 API object.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- 9:27 AM Changeset in webkit [133424] by
-
- 2 edits in trunk/Source/WebCore
Missing ASCIILiteral in a place of accessibility
https://bugs.webkit.org/show_bug.cgi?id=101160
Reviewed by Darin Adler.
ASCIILiteral usage is being missed in a spot of accessibliity.
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaTimeDisplay::accessibilityDescription):
- 8:02 AM Changeset in webkit [133423] by
-
- 4 edits in trunk/Source/WebKit2
[EFL] Unify transforms in WK2
https://bugs.webkit.org/show_bug.cgi?id=101051
Reviewed by Simon Hausmann.
Move our transforms into EwkViewImpl and use them
everywhere needed.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::smartData):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::transformToScene):
(EwkViewImpl::transformToScreen):
(EwkViewImpl::displayTimerFired):
- UIProcess/API/efl/EwkViewImpl.h:
(WebCore):
(EwkViewImpl):
(EwkViewImpl::pageViewportControllerClient):
(EwkViewImpl::pageViewportController):
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(ewk_view_feed_touch_event):
- 6:57 AM Changeset in webkit [133422] by
-
- 2 edits in trunk/LayoutTests
[chromium] Add a now-failing test. Unreviewed.
- platform/chromium/TestExpectations:
- 6:07 AM Changeset in webkit [133421] by
-
- 16 edits1 move1 add3 deletes in trunk
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838
Reviewed by Simon Hausmann.
Reland with build fixes.
Source/WebCore:
The problem here is that we use QWebSettings::clearMemoryCaches, a WebKit1 API
from the injected bundle, which calls initializeWebCoreQt and it sets the platform
strategies to the one for WebKit1. We should stop using WebKit1 API's from WebKit2
code. In order to keep the behavior, this patch adds exported helpers to WebCore
that can be used from DumpRenderTree and WebKitTestRunner. This is the same idea
as WebCoreTestSupport but these helpers are specific to Qt. Technically we could
add it to the WebKit1 API for the time being, but my goal was to move in the direction
of removing the WebKit1 dependency from WebKitTestRunner. We only build the file
in non production mode.
Basically covered by all tests.
- Target.pri:
- WebCore.pri: We need to link against fontconfig (only in non-production mode) since
initializeTestFonts uses it.
- platform/qt/QtTestSupport.cpp: Added. I choose GPL license because code from qwebsettings.cpp
is also under that.
(WebKit):
(WebKit::QtTestSupport::clearMemoryCaches): This is basically a copy of QWebSettings::clearMemoryCaches
without calling initializeWebCoreQt.
(WebKit::QtTestSupport::initializeTestFonts): I moved this code here as well now that we have to expose
symbols from WebCore anyway. The advantage is that now we don't have to build it twice and we don't need
additional files to forward it from the directory of DumpRenderTree for WebKitTestRunner.
I added a call to FontCace::invalidate in the case when the font set has been changed so that it will do
the job even if we would stop clearing all caches between tests. Also moved the call to
QFontDatabase::removeAllApplicationFonts from callers to here.
- platform/qt/QtTestSupport.h:
(WebKit):
(QtTestSupport):
Tools:
Turned test runners to use the new QtTestSupport.
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
- MiniBrowser/qt/MiniBrowser.pro:
- QtTestBrowser/QtTestBrowser.pro:
- QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
- WebKitTestRunner/InjectedBundle/Target.pri:
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
- WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize): Removed the comment from here
because it was just lying, apparently two times. First, it is not incorrect
to reinitialize our font set and clear font caches, it is what the tests
expect. Second, the use of QRawFont has nothing to do with the font cache.
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/qt/main.cpp:
(main):
- 5:26 AM Changeset in webkit [133420] by
-
- 3 edits2 adds in trunk
Color-profile property triggers assert
https://bugs.webkit.org/show_bug.cgi?id=101080
Reviewed by Dirk Schulze.
Source/WebCore:
CSSPropertyColorProfile is not handled in StyleResolver::applySVGProperty(), triggering the
unimplemented property assert. Adding a stub entry to avoid that.
Test: svg/css/color-profile-crash.html
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
LayoutTests:
- svg/css/color-profile-crash-expected.txt: Added.
- svg/css/color-profile-crash.html: Added.
- 4:30 AM Changeset in webkit [133419] by
-
- 5 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed weekend gardening, skip failing tests, update expected files.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Updated after r133019.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Updated after r133019.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Updated after r133019.
- 2:55 AM Changeset in webkit [133418] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip one more failing test.
- platform/qt/TestExpectations:
- 2:31 AM Changeset in webkit [133417] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip new failing tests.
- platform/qt/TestExpectations:
- 1:20 AM Changeset in webkit [133416] by
-
- 4 edits2 adds in trunk
Unable to copy text on disabled input fields on long press gesture
https://bugs.webkit.org/show_bug.cgi?id=99698
Reviewed by Ryosuke Niwa.
Text from disabled input/text should be allowed to select. Replaced isContentEditable()
with canStartSelection()
Source/WebCore:
Test: fast/events/touch/gesture/disabled-input-text-selection.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureLongPress):
LayoutTests:
- fast/events/touch/gesture/disabled-input-text-selection-expected.txt: Added.
- fast/events/touch/gesture/disabled-input-text-selection.html: Added.
- platform/chromium/TestExpectations: Not Valid for chromium desktop.
Nov 4, 2012:
- 1:07 AM Changeset in webkit [133415] by
-
- 4 edits in trunk/Source/JavaScriptCore
[Qt] udis86_itab.c is always regenerated
https://bugs.webkit.org/show_bug.cgi?id=100756
Reviewed by Simon Hausmann.
- DerivedSources.pri: Generate sources to the generated directory.
- disassembler/udis86/differences.txt:
- disassembler/udis86/itab.py: Add --outputDir option.
(UdItabGenerator.init):
(genItabH):
(genItabC):
(main):
- 1:03 AM Changeset in webkit [133414] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r133381.
http://trac.webkit.org/changeset/133381
https://bugs.webkit.org/show_bug.cgi?id=101161
It made webkit-patch useless (Requested by Ossy_weekend on
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-04
- Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._create_scratch_directory):
(AutoInstaller._install):
(AutoInstaller.install):
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook.init):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install):
- Scripts/webkitpy/thirdparty/init_unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.init):
(ThirdpartyTest.test_import_hook):
- 12:43 AM Changeset in webkit [133413] by
-
- 2 edits in trunk/LayoutTests
[chromium] Remove some no-longer-flaky tests. Unreviewed.
- platform/chromium/TestExpectations:
Nov 3, 2012:
- 6:06 PM Changeset in webkit [133412] by
-
- 2 edits in trunk/LayoutTests
[chromium] Remove some a no-longer-flaky test. Unreviewed.
- platform/chromium/TestExpectations:
- 5:57 PM Changeset in webkit [133411] by
-
- 16 edits3 copies1 move1 delete in trunk
Unreviewed, rolling out r133403, r133404, and r133409.
http://trac.webkit.org/changeset/133403
http://trac.webkit.org/changeset/133404
http://trac.webkit.org/changeset/133409
https://bugs.webkit.org/show_bug.cgi?id=101158
"Broke tests" (Requested by kbalazs on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-03
Source/WebCore:
- Target.pri:
- WebCore.pri:
- platform/qt/QtTestSupport.h: Removed.
Tools:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
(WebKit):
(WebKit::initializeTestFonts):
- DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
(WebKit):
- MiniBrowser/qt/MiniBrowser.pro:
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
- QtTestBrowser/QtTestBrowser.pro:
- QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
- WebKitTestRunner/InjectedBundle/Target.pri:
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
- WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/qt/main.cpp:
(main):
- 5:35 PM Changeset in webkit [133410] by
-
- 30 edits in trunk/Source
Get rid of USE(CFURLSTORAGESESSIONS)
https://bugs.webkit.org/show_bug.cgi?id=101131
Reviewed by Sam Weinig.
Source/WebCore:
This is always enabled on CFNetwork based platforms.
- WebCore.exp.in:
- page/Settings.cpp:
(WebCore::Settings::setPrivateBrowsingEnabled):
- platform/mac/CookieJar.mm:
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
- platform/network/ResourceHandle.h:
(ResourceHandle):
- platform/network/cf/CookieStorageCFNet.cpp:
(WebCore):
(WebCore::currentCFHTTPCookieStorage):
- platform/network/cf/CookieStorageCFNet.h:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
(WebCore::makeFinalRequest):
(WebCore::ResourceHandle::willSendRequest):
(WebCore):
- platform/network/cf/ResourceRequest.h:
(ResourceRequest):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore):
- platform/network/mac/CookieStorageMac.mm:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::shouldRelaxThirdPartyCookiePolicy):
(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::willSendRequest):
(WebCore):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore):
(WebCore::ResourceRequest::setStorageSession):
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataUseFeatures.in: Not sure what this list is about, but
CFURLSTORAGESESSIONS probably doesn't need to stay here.
Source/WebKit/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
(+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
- WebView/WebView.mm:
(-[WebView _cachedResponseForURL:]):
Source/WebKit2:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
- UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- WebProcess/Cookies/mac/WebCookieManagerMac.mm:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::switchNetworkLoaderToNewTestingSession):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::cachedResponseForURL):
- WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::cachedResponseForURL):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformClearResourceCaches):
Source/WTF:
- wtf/Platform.h:
- 5:14 PM Changeset in webkit [133409] by
-
- 2 edits in trunk/Tools
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838
2nd unreviewed buildfix.
- MiniBrowser/qt/MiniBrowserApplication.cpp:
- 5:09 PM Changeset in webkit [133408] by
-
- 2 edits in trunk/LayoutTests
[chromium] Remove some now-passing tests. Unreviewed.
- platform/chromium/TestExpectations:
- 5:04 PM Changeset in webkit [133407] by
-
- 2 edits in tags/Safari-537.17.1/Source/WebCore
Merged r133398.
- 5:00 PM Changeset in webkit [133406] by
-
- 4 edits in tags/Safari-537.17.1/Source
Versioning.
- 4:57 PM Changeset in webkit [133405] by
-
- 1 copy in tags/Safari-537.17.1
New Tag.
- 4:47 PM Changeset in webkit [133404] by
-
- 2 edits in trunk/Tools
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838
Unreviewed buildfix.
- WebKitTestRunner/Target.pri:
- 3:52 PM Changeset in webkit [133403] by
-
- 15 edits1 move1 add3 deletes in trunk
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838
Reviewed by Simon Hausmann.
Reland with build fix.
Source/WebCore:
The problem here is that we use QWebSettings::clearMemoryCaches, a WebKit1 API
from the injected bundle, which calls initializeWebCoreQt and it sets the platform
strategies to the one for WebKit1. We should stop using WebKit1 API's from WebKit2
code. In order to keep the behavior, this patch adds exported helpers to WebCore
that can be used from DumpRenderTree and WebKitTestRunner. This is the same idea
as WebCoreTestSupport but these helpers are specific to Qt. Technically we could
add it to the WebKit1 API for the time being, but my goal was to move in the direction
of removing the WebKit1 dependency from WebKitTestRunner. We only build the file
in non production mode.
Basically covered by all tests.
- Target.pri:
- WebCore.pri: We need to link against fontconfig (only in non-production mode) since
initializeTestFonts uses it.
- platform/qt/QtTestSupport.cpp: Added. I choose GPL license because code from qwebsettings.cpp
is also under that.
(WebKit):
(WebKit::QtTestSupport::clearMemoryCaches): This is basically a copy of QWebSettings::clearMemoryCaches
without calling initializeWebCoreQt.
(WebKit::QtTestSupport::initializeTestFonts): I moved this code here as well now that we have to expose
symbols from WebCore anyway. The advantage is that now we don't have to build it twice and we don't need
additional files to forward it from the directory of DumpRenderTree for WebKitTestRunner.
I added a call to FontCace::invalidate in the case when the font set has been changed so that it will do
the job even if we would stop clearing all caches between tests. Also moved the call to
QFontDatabase::removeAllApplicationFonts from callers to here.
- platform/qt/QtTestSupport.h:
(WebKit):
(QtTestSupport):
Tools:
Turned test runners to use the new QtTestSupport.
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
- MiniBrowser/qt/MiniBrowser.pro:
- QtTestBrowser/QtTestBrowser.pro:
- QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
- WebKitTestRunner/InjectedBundle/Target.pri:
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
- WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize): Removed the comment from here
because it was just lying, apparently two times. First, it is not incorrect
to reinitialize our font set and clear font caches, it is what the tests
expect. Second, the use of QRawFont has nothing to do with the font cache.
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/qt/main.cpp:
(main):
- 3:36 PM Changeset in webkit [133402] by
-
- 10 edits2 moves in trunk/LayoutTests
[chromium] New baselines for no-longer-flaky tests. Unreviewed.
- platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- platform/chromium-mac-lion/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- platform/chromium/TestExpectations:
- platform/efl-wk1/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png.
- platform/efl-wk1/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png.
- 3:27 PM Changeset in webkit [133401] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
- platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- 2:42 PM Changeset in webkit [133400] by
-
- 14 edits3 copies1 move1 delete in trunk
Unreviewed, rolling out r133397.
http://trac.webkit.org/changeset/133397
https://bugs.webkit.org/show_bug.cgi?id=101155
"Broke Qt. No way to force the damn bots to do a clean build.
I'm giving up." (Requested by kbalazs on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-03
Source/WebCore:
- Target.pri:
- WebCore.pri:
- platform/qt/QtTestSupport.h: Removed.
Tools:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
(WebKit):
(WebKit::initializeTestFonts):
- DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
(WebKit):
- QtTestBrowser/QtTestBrowser.pro:
- QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
- WebKitTestRunner/InjectedBundle/Target.pri:
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
- WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/qt/main.cpp:
(main):
- 1:52 PM Changeset in webkit [133399] by
-
- 3 edits in trunk/Source/WebCore
Speculative fix to eliminate flakiness in
css3/filters/blur-filter-page-scroll-self.html
https://bugs.webkit.org/show_bug.cgi?id=91620.
Suspicion is that a prior test is setting
window.internals.settings.setEnableCompositingForFixedPosition(true),
causing this test to be intermittely run on the GPU, giving different
pixel results depending on test order.
Reviewed by Jochen Eisinger.
Covered by css3/filters/blur-filter-page-scroll-self.html
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
- testing/InternalSettings.h:
(Backup):
- 1:48 PM Changeset in webkit [133398] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r132858): Crash below -[DOMElement setClassName:] when called with a nil string
Reviewed by Anders Carlsson.
The changes in r132858 introduced an overload of AtomicString::add for CFStrings. However, the overload
that was introduced is not null safe.
- platform/text/cf/AtomicStringCF.cpp:
(WTF::AtomicString::add): Handle a null string by returning a null StringImpl.
- 1:36 PM Changeset in webkit [133397] by
-
- 14 edits1 move1 add3 deletes in trunk
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838
Reviewed by Simon Hausmann.
Source/WebCore:
The problem here is that we use QWebSettings::clearMemoryCaches, a WebKit1 API
from the injected bundle, which calls initializeWebCoreQt and it sets the platform
strategies to the one for WebKit1. We should stop using WebKit1 API's from WebKit2
code. In order to keep the behavior, this patch adds exported helpers to WebCore
that can be used from DumpRenderTree and WebKitTestRunner. This is the same idea
as WebCoreTestSupport but these helpers are specific to Qt. Technically we could
add it to the WebKit1 API for the time being, but my goal was to move in the direction
of removing the WebKit1 dependency from WebKitTestRunner. We only build the file
in non production mode.
Basically covered by all tests.
- Target.pri:
- WebCore.pri: We need to link against fontconfig (only in non-production mode) since
initializeTestFonts uses it.
- platform/qt/QtTestSupport.cpp: Added. I choose GPL license because code from qwebsettings.cpp
is also under that.
(WebKit):
(WebKit::QtTestSupport::clearMemoryCaches): This is basically a copy of QWebSettings::clearMemoryCaches
without calling initializeWebCoreQt.
(WebKit::QtTestSupport::initializeTestFonts): I moved this code here as well now that we have to expose
symbols from WebCore anyway. The advantage is that now we don't have to build it twice and we don't need
additional files to forward it from the directory of DumpRenderTree for WebKitTestRunner.
I added a call to FontCace::invalidate in the case when the font set has been changed so that it will do
the job even if we would stop clearing all caches between tests. Also moved the call to
QFontDatabase::removeAllApplicationFonts from callers to here.
- platform/qt/QtTestSupport.h:
(WebKit):
(QtTestSupport):
Tools:
Turned test runners to use the new QtTestSupport.
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
- QtTestBrowser/QtTestBrowser.pro:
- QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
- WebKitTestRunner/InjectedBundle/Target.pri:
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
- WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
- WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize): Removed the comment from here
because it was just lying, apparently two times. First, it is not incorrect
to reinitialize our font set and clear font caches, it is what the tests
expect. Second, the use of QRawFont has nothing to do with the font cache.
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/qt/main.cpp:
(main):
- 9:08 AM Changeset in webkit [133396] by
-
- 17 edits2 adds in trunk
Implement HTMLFormElement#requestAutocomplete and associated events
https://bugs.webkit.org/show_bug.cgi?id=100557
Patch by Dan Beam <dbeam@chromium.org> on 2012-11-03
Reviewed by Adam Barth.
Source/WebCore:
Implements an initial version of the proposal for interactive autocomplete outlined in this email:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037711.html
The goal of this patch is to allow web authors to call formElement.requestAutocomplete(); after subscribing for
autocomplete/autocompleteerror events on formElement. If the form's [autocomplete] attribute is "off" an
error will be dispatched. Otherwise, a request will be issued to the FrameLoaderClient. At the moment, the
implementation in Chrome (https://codereview.chromium.org/11270018/) will simply dispatch an error until the
UI on Chrome's side is built. Both autocomplete and autocompleteerror events will be dispatched asynchronously
after a small delay to behave consistently in all situations and implementations.
Currently this is behind the feature flag REQUEST_AUTOCOMPLETE, which is disabled.
Test: fast/forms/form-request-autocomplete.html
- dom/EventNames.h:
(WebCore):
Added autocomplete and autocompleteerror events. The autocomplete event is dispatched after a user adds more
information to a form using the future UI. This is not currently dispatched in any implementation (including Chrome)
but will be in the future. The autocompleteerror event is dispatched when the form has [autocomplete="off"] on the
node being asked for an interactive autocomplete. The user agent may also dispatch this event if it doesn't implement
this API but has turned on the feature flag, can't currently show an autocomplete UI (e.g. running headlessly or in
an HTML notification, security concerns, or any other reason it desires).
- html/HTMLAttributeNames.in:
Added onautocomplete and onautocompleteerror attributes so they can be parsed when creating form elements and used
as event listeners. For example:
<form onautocomplete="/* when autocomplete succeeds */" autocompleteerror="/* when autocomplete fails */">
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore):
Added m_requestAutocompleteTimer (a timer that's used to dispatch events asynchronously) to the initializer list that
triggers requestAutocompleteTimerFired when it times out.
(WebCore::HTMLFormElement::requestAutocomplete):
Called when HTMLFormElement#requestAutocomplete is called from JS (also see HTMLFormElement.idl) and decides whether
to dispatch an error and exit early (in the case where autocomplete="off") or pass the request on to the
FrameLoaderClient.
(WebCore::HTMLFormElement::finishRequestAutocomplete):
Called when the request for an interactive autocomplete is finished with either a success or error result. This
causes an event to queue and fired after a 0 second delay. Events are owned by HTMLFormElement and reference the
target element (this) until fired.
(WebCore::HTMLFormElement::requestAutocompleteTimerFired):
Called when the event timer runs out to pump the queue of current events. Events are released on dispatch.
(WebCore::HTMLFormElement::parseAttribute):
Encountering onautocomplete or onautocompleteerror attributes while parsing HTMLFormElements now adds event listeners
for autocomplete an autocompleteerror events (respectively) to dispatch the value of the attribute as a script.
- html/HTMLFormElement.h:
(HTMLFormElement):
Added various methods and data members as required by the implementation.
- html/HTMLFormElement.idl:
Added the method requestAutocomplete and associated DOM event handler attributes (onautocomplete/onautocompleteerror)
to HTMLFormElement's public DOM API (unprefixed, as per Ian Hickson's advice). All are require the Conditional
REQUEST_AUTOCOMPLETE to be enabled to be activated.
- loader/EmptyClients.cpp:
(WebCore):
(WebCore::EmptyFrameLoaderClient::didRequestAutocomplete):
Added noop implementation for FrameLoader::didRequestAutocomplete.
- loader/EmptyClients.h:
(EmptyFrameLoaderClient):
Added FrameLoader::didRequestAutocomplete to EmptyFrameLoaderClient interface.
- loader/FrameLoaderClient.h:
(FrameLoaderClient):
Added noop implementation to FrameLoaderClient interface (which is implemented chromium's FrameLoaderLoaderImpl.cpp).
Source/WebKit/chromium:
Implements an initial version of the proposal for interactive autocomplete outlined in this email:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037711.html
The goal of this patch is to allow web authors to call formElement.requestAutocomplete(); after subscribing for
autocomplete/autocompleteerror events on formElement. If the form's [autocomplete] attribute is "off" an
error will be dispatched. Otherwise, a request will be issued to the FrameLoaderClient. At the moment, the
implementation in Chrome (https://codereview.chromium.org/11270018/) will simply dispatch an error until the
UI on Chrome's side is built. Both autocomplete and autocompleteerror events will be dispatched asynchronously
after a small delay to behave consistently in all situations and implementations.
Currently this is behind the feature flag REQUEST_AUTOCOMPLETE, which is disabled.
Test: fast/forms/form-request-autocomplete.html
- public/WebAutofillClient.h:
(WebKit):
(WebAutofillClient):
(WebKit::WebAutofillClient::didRequestAutocomplete):
Added WebAutofillClient::didRequestAutocomplete to chrome's public WebKit interface.
- public/WebFormElement.h:
Added an enum that matches HTMLFormElement::AutocompleteResult (and added compile time assert) and a public method
(WebFormElement::finishRequestAutocomplete) to WebFormElement's public interface.
- src/AssertMatchingEnums.cpp:
Added a compile time assert to guarantee the HTMLFormElement::AutocompleteResult enum matches the
WebFormElement::AutocompleteResult enum.
- src/FrameLoaderClientImpl.cpp:
(WebKit):
(WebKit::FrameLoaderClientImpl::didRequestAutocomplete):
Implemented the added FrameLoaderClient::didRequestAutocomplete, which simply passes through to the
WebAutofillClient.
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
Implementing FrameLoaderClient::didRequestAutocomplete.
- src/WebFormElement.cpp:
(WebKit::WebFormElement::finishRequestAutocomplete):
(WebKit):
Added WebFormElement::finishRequestAutocomplete to allow chromium's renderer a public API to call to finish the
autocomplete request on a WebFormElement.
LayoutTests:
Adds tests for an initial implementation of the proposal for interactive autocomplete outlined in this email:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037711.html
The goal of this patch is to allow web authors to call formElement.requestAutocomplete(); after subscribing
for autocomplete/autocompleteerror events on formElement. If the form's [autocomplete] attribute is "off" an
error will be dispatched. Otherwise, a request will be issued to the FrameLoaderClient. At the moment, the
implementation in Chrome (https://codereview.chromium.org/11270018/) will simply dispatch an error until the
UI on Chrome's side is built. Both autocomplete and autocompleteerror events will be dispatched asynchronously
after a small delay to behave consistently in all situations and implementations.
Currently the implementation is behind the feature flag REQUEST_AUTOCOMPLETE, which is disabled, so the test
is expected to fail. This test verifies that currently no client implements this method on HTMLFormElement
(HTMLFormElement#requestAutocomplete) and returns. When the chrome-side lands I'll add a success case in
LayoutTests/platform/chromium/fast/forms/ with the expected successful results.
- fast/forms/form-request-autocomplete-expected.txt: Added.
- fast/forms/form-request-autocomplete.html: Added.
- 8:32 AM Changeset in webkit [133395] by
-
- 5 edits2 adds in trunk
Web Inspector: %d, %i, and %f log formatters have same result
https://bugs.webkit.org/show_bug.cgi?id=101148
Reviewed by Alexander Pavlov.
Source/WebCore:
Added separate formatters for %f, %i, %d and %s.
Test: inspector/console/console-message-format.html
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.stringFormatter):
(WebInspector.ConsoleMessageImpl.prototype.floatFormatter):
(WebInspector.ConsoleMessageImpl.prototype.integerFormatter):
LayoutTests:
- inspector/console/console-format-expected.txt:
- inspector/console/console-format.html:
- inspector/console/console-message-format-expected.txt: Added.
- inspector/console/console-message-format.html: Added.
- 4:55 AM Changeset in webkit [133394] by
-
- 7 edits in trunk/Source/WebCore
Decouple Attr logic from ElementAttributeData.
<http://webkit.org/b/101126>
Reviewed by Antti Koivisto.
Move all logic dealing with Attr DOM nodes from ElementAttributeData to Element.
This makes more sense since an Attr is tied to a single Element, but an ElementAttributeData
can be shared by any number of Elements at a given time.
Also updated naming convention from just "Attr" to "Attr node" in the code I was touching.
"Attr" is way too generic, and has been historically confused with WebCore::Attribute a lot.
- dom/Element.h:
- dom/ElementAttributeData.h:
- dom/Element.cpp:
(WebCore::attrNodeListMap):
(WebCore::attrNodeListForElement):
(WebCore::ensureAttrNodeListForElement):
(WebCore::removeAttrNodeListForElement):
(WebCore::findAttrNodeInList):
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
(WebCore::Element::detachAttrNodeFromElementWithValue):
(WebCore::Element::detachAllAttrNodesFromElement):
(WebCore::Element::cloneAttributesFromElement):
Move everything Attr-related into Element.cpp while simplifying some loops and remove
conditions that are no longer needed as they used to depend on having an attributeData().
- dom/Node.h:
(WebCore::Node::hasSyntheticAttrChildNodes):
(WebCore::Node::setHasSyntheticAttrChildNodes):
Renamed the hasAttrList() node flag to hasSyntheticAttrChildNodes().
- dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):
Remove awkward indirection and let the call site deal with removing the Attr node from
the Element's list of Attr nodes.
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::clearAttributes):
Remove now-unused Element* argument.
- 4:36 AM Changeset in webkit [133393] by
-
- 4 edits in trunk/Source
REGRESSION (r132014-r132047): Webkit Inspector Window docking broken
https://bugs.webkit.org/show_bug.cgi?id=101125
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Added "bottom" as default docked state.
- inspector/front-end/DockController.js:
(WebInspector.DockController):
Source/WebKit2:
Migrated from ?docked= to ?dockSide= format.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage):
Nov 2, 2012:
- 11:40 PM Changeset in webkit [133392] by
-
- 9 edits2 adds in trunk
[Shadow] ShadowRoot should be able to know the existence of <content>
https://bugs.webkit.org/show_bug.cgi?id=100921
Reviewed by Dimitri Glazkov.
Source/WebCore:
When <content> is inserted into or removed from a shadow subtree, ShadowRoot counts the number of <content>.
It provides O(1) method to check the existence of <content>.
This is necessary when we implement a fast checking path for distribution invalidation when an element attribute
is changed. Larger context is explained in Bug 100451.
Test: fast/dom/shadow/has-content-elements.html
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::hasInsertionPoint): Since we track both <content> and <shadow>, we don't need to traverse
all the descendants of ShadowRoot anymore.
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::registerContentElement):
(WebCore::ShadowRoot::unregisterContentElement):
(WebCore::ShadowRoot::hasContentElement):
(ShadowRoot):
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::insertedInto): When <content> is inserted into ShadowDOM subtree,
we notify it to the ShadowRoot. Note that only active <content> element is counted.
(WebCore):
(WebCore::HTMLContentElement::removedFrom):
- html/shadow/HTMLContentElement.h:
(HTMLContentElement):
- testing/Internals.cpp:
(WebCore::Internals::hasContentElement):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
- fast/dom/shadow/has-content-elements-expected.txt: Added.
- fast/dom/shadow/has-content-elements.html: Added.
- 11:29 PM Changeset in webkit [133391] by
-
- 2 edits in trunk/Source/WebCore
sCurrentPaintTimeStamp is not initialized when FrameView::paintContents returns in the middle
https://bugs.webkit.org/show_bug.cgi?id=99990
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-02
Reviewed by Darin Adler.
Move initialization code for sCurrentPaintTimeStamp to the below of early returns,
because it was not reset after early return.
- page/FrameView.cpp:
(WebCore::FrameView::paintContents):
- 11:26 PM Changeset in webkit [133390] by
-
- 2 edits in trunk/Source/WebCore
Fix build warning in PluginView.cpp on release build
https://bugs.webkit.org/show_bug.cgi?id=101049
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-02
Reviewed by Kentaro Hara.
The protocol, host, port parameters are not used when LOG_DISABLED
Use UNUSED_PARAM macro for removing -Wunused-parameter warning
- plugins/PluginView.cpp:
(WebCore::PluginView::getAuthenticationInfo):
- 9:38 PM Changeset in webkit [133389] by
-
- 12 edits in trunk/Source
[GTK] Move soup authentication from GtkAuthenticationDialog to WebCore
https://bugs.webkit.org/show_bug.cgi?id=99914
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Move the actual soup authentication code from the GtkAuthenticationDialog to ResourceHandleSoup.
This allows a more generic implementation of authentication, for example, one where a WebKit2
client can completely handle authentication.
No new tests. This does not change behavior.
- platform/gtk/GtkAuthenticationDialog.cpp: Remove references to the SoupPasswordManager, which
is going away in the next release of Gnome. Instead we always assume that the authentication backend has
support for remembering passwords and pass that information along with the answer to the authentication
request.
The rest of the changes to this class can be summarized as:
- Getting the information from the AuthenticationChallenge instead of directly from the libsoup objects.
- Using the AuthenticationClient to accomplish the authentication instead of talking to libsoup directly.
- platform/gtk/GtkAuthenticationDialog.h:
(GtkAuthenticationDialog): Remove members which are no longer used.
- platform/network/ResourceHandle.h:
(ResourceHandle): ResourceHandleSoup now implements the entire AuthenticationClient interface.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::didReceiveAuthenticationChallenge): Don't handle authentication
for synchronous handles.
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Now set the current challenge on
the internal data structure.
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): Added.
(WebCore::ResourceHandle::receivedCredential): Added.
(WebCore::ResourceHandle::receivedCancellation): Added.
(WebCore::authenicateCallback): Pass the handle as the authentication client.
Source/WebKit/gtk:
The calls which actually authenticate a soup message are gone from the GtkAuthenticationDialog. Since the
GtkAuthenticationDialog exposed by the WebKitSoupAuthentication class in the GTK+ API work without a
ResourceHandle (they are more general), we add a WebKitSoupAuthDialogAuthenticationClient added to avoid
breaking API. This is unused by either Epiphany or internally in WebKitGTK+.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): The authentication dialog
now just takes the AuthenticationChallenge instead of the libsoup objects.
- webkit/webkitsoupauthdialog.cpp:
(WebKitSoupAuthDialogAuthenticationClient): Added this helper.
(sessionAuthenticate): Use the new WebKitSoupAuthDialogAuthenticationClient.
Source/WebKit2:
Instead of passing the libsoup objects to the GtkAuthenticationDialog, pass the
AuthenticationChallenge itself.
- WebProcess/WebCoreSupport/gtk/WebFrameLoaderClientGtk.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
- 9:24 PM Changeset in webkit [133388] by
-
- 5 copies1 add in releases/Apple/Safari 6.0.2
Added a tag for the Safari 6.0.2 release.
Safari 6.0.2 includes JavaScriptCore-x536.26.15, WebCore-x536.26.15, WebKit-x536.26.17, and WebKit2-x536.26.17.
- 8:32 PM Changeset in webkit [133387] by
-
- 3 edits in trunk/Source/WebCore
Improve CSSParser::setupParser() since the prefix/suffix are literals
https://bugs.webkit.org/show_bug.cgi?id=101107
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-11-02
Reviewed by Andreas Kling.
- css/CSSParser.cpp:
(WebCore::CSSParser::setupParser):
- css/CSSParser.h:
(CSSParser):
(WebCore::CSSParser::setupParser):
CSSParser::setupParser() is only used with literals prefix and suffix. We do not have
to compute the length at runtime, we can direclty encode it in the binary.
- 6:48 PM Changeset in webkit [133386] by
-
- 10 edits66 deletes in trunk
Unreviewed, rolling out r133375.
http://trac.webkit.org/changeset/133375
https://bugs.webkit.org/show_bug.cgi?id=101138
Caused 3 tests to fail on Mac (Requested by aboxhall-laptop on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-02
Source/WebCore:
- platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):
- platform/text/TextBreakIterator.h:
(WebCore):
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
- rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
- rendering/RenderText.h:
(WebCore):
- rendering/break_lines.cpp:
(WebCore):
(WebCore::isBreakableSpace):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
- rendering/break_lines.h:
(WebCore):
(WebCore::isBreakable):
LayoutTests:
- css3/line-break/line-break-auto-centered-expected.html: Removed.
- css3/line-break/line-break-auto-centered.html: Removed.
- css3/line-break/line-break-auto-half-kana-expected.html: Removed.
- css3/line-break/line-break-auto-half-kana.html: Removed.
- css3/line-break/line-break-auto-hyphens-expected.html: Removed.
- css3/line-break/line-break-auto-hyphens.html: Removed.
- css3/line-break/line-break-auto-inseparables-expected.html: Removed.
- css3/line-break/line-break-auto-inseparables.html: Removed.
- css3/line-break/line-break-auto-iteration-marks-expected.html: Removed.
- css3/line-break/line-break-auto-iteration-marks.html: Removed.
- css3/line-break/line-break-auto-postfixes-expected.html: Removed.
- css3/line-break/line-break-auto-postfixes.html: Removed.
- css3/line-break/line-break-auto-prefixes-expected.html: Removed.
- css3/line-break/line-break-auto-prefixes.html: Removed.
- css3/line-break/line-break-auto-sound-marks-expected.html: Removed.
- css3/line-break/line-break-auto-sound-marks.html: Removed.
- css3/line-break/line-break-loose-centered-expected.html: Removed.
- css3/line-break/line-break-loose-centered.html: Removed.
- css3/line-break/line-break-loose-half-kana-expected.html: Removed.
- css3/line-break/line-break-loose-half-kana.html: Removed.
- css3/line-break/line-break-loose-hyphens-expected.html: Removed.
- css3/line-break/line-break-loose-hyphens.html: Removed.
- css3/line-break/line-break-loose-inseparables-expected.html: Removed.
- css3/line-break/line-break-loose-inseparables.html: Removed.
- css3/line-break/line-break-loose-iteration-marks-expected.html: Removed.
- css3/line-break/line-break-loose-iteration-marks.html: Removed.
- css3/line-break/line-break-loose-postfixes-expected.html: Removed.
- css3/line-break/line-break-loose-postfixes.html: Removed.
- css3/line-break/line-break-loose-prefixes-expected.html: Removed.
- css3/line-break/line-break-loose-prefixes.html: Removed.
- css3/line-break/line-break-loose-sound-marks-expected.html: Removed.
- css3/line-break/line-break-loose-sound-marks.html: Removed.
- css3/line-break/line-break-normal-centered-expected.html: Removed.
- css3/line-break/line-break-normal-centered.html: Removed.
- css3/line-break/line-break-normal-half-kana-expected.html: Removed.
- css3/line-break/line-break-normal-half-kana.html: Removed.
- css3/line-break/line-break-normal-hyphens-expected.html: Removed.
- css3/line-break/line-break-normal-hyphens.html: Removed.
- css3/line-break/line-break-normal-inseparables-expected.html: Removed.
- css3/line-break/line-break-normal-inseparables.html: Removed.
- css3/line-break/line-break-normal-iteration-marks-expected.html: Removed.
- css3/line-break/line-break-normal-iteration-marks.html: Removed.
- css3/line-break/line-break-normal-postfixes-expected.html: Removed.
- css3/line-break/line-break-normal-postfixes.html: Removed.
- css3/line-break/line-break-normal-prefixes-expected.html: Removed.
- css3/line-break/line-break-normal-prefixes.html: Removed.
- css3/line-break/line-break-normal-sound-marks-expected.html: Removed.
- css3/line-break/line-break-normal-sound-marks.html: Removed.
- css3/line-break/line-break-strict-centered-expected.html: Removed.
- css3/line-break/line-break-strict-centered.html: Removed.
- css3/line-break/line-break-strict-half-kana-expected.html: Removed.
- css3/line-break/line-break-strict-half-kana.html: Removed.
- css3/line-break/line-break-strict-hyphens-expected.html: Removed.
- css3/line-break/line-break-strict-hyphens.html: Removed.
- css3/line-break/line-break-strict-inseparables-expected.html: Removed.
- css3/line-break/line-break-strict-inseparables.html: Removed.
- css3/line-break/line-break-strict-iteration-marks-expected.html: Removed.
- css3/line-break/line-break-strict-iteration-marks.html: Removed.
- css3/line-break/line-break-strict-postfixes-expected.html: Removed.
- css3/line-break/line-break-strict-postfixes.html: Removed.
- css3/line-break/line-break-strict-prefixes-expected.html: Removed.
- css3/line-break/line-break-strict-prefixes.html: Removed.
- css3/line-break/line-break-strict-sound-marks-expected.html: Removed.
- css3/line-break/line-break-strict-sound-marks.html: Removed.
- platform/chromium-linux/css3/line-break/line-break-auto-half-kana-expected.html: Removed.
- platform/chromium-linux/css3/line-break/line-break-auto-sound-marks-expected.html: Removed.
- 6:39 PM Changeset in webkit [133385] by
-
- 3 edits in trunk/Source/WebCore
Cut overgrown ElementAttributeData bitfield.
<http://webkit.org/b/101129>
Reviewed by Anders Carlsson.
Make sure the ElementAttributeData bitfield fits into 32 bits. Added a compile-time assertion
to guard against future bloatage.
- dom/ElementAttributeData.cpp:
(SameSizeAsElementAttributeData):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- 6:21 PM Changeset in webkit [133384] by
-
- 17 edits1 add in trunk/LayoutTests
[CSS Exclusions] Clean up shape-inside tests' subpixel snapping code
https://bugs.webkit.org/show_bug.cgi?id=100704
Patch by Bear Travis <betravis@adobe.com> on 2012-11-02
Reviewed by Dirk Schulze.
Factor out the pixel snapping behavior from polygon tests to be shared with
the rounded rectangle tests. In sub-pixel layout, the rounding behavior may be
slightly different. This adds a new file, subpixel-utils.js, which tests for the
feature availability and provides functions for rounding at line left & line right.
I've also taken the opportunity to factor the window.internal.settings code into
rounded-rectangle.js and simple-polygon.js.
- fast/exclusions/resources/rounded-rectangle.js:
(simulateShape): Use the new subpixel rounding code.
- fast/exclusions/resources/simple-polygon.js:
(polygonXIntercepts): Ditto.
- fast/exclusions/resources/subpixel-utils.js: Added.
(SubPixelLayout): Adding the SubPixelLayout object which has helper methods
for determining how line edges should round, and whether subpixel layout is enabled.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002-expected.html:
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002.html:
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003-expected.html:
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html:
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004-expected.html:
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html:
- fast/exclusions/shape-inside/shape-inside-simple-polygon-001-expected.html:
- fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html:
- fast/exclusions/shape-inside/shape-inside-simple-polygon-002-expected.html:
- fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html:
- fast/exclusions/shape-inside/shape-inside-simple-polygon-003-expected.html:
- fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html:
- fast/exclusions/shape-inside/shape-inside-simple-polygon-004-expected.html:
- fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html:
- 5:58 PM Changeset in webkit [133383] by
-
- 2 edits1 copy2 adds in trunk/LayoutTests
Rebaseline some webaudio tests due to increased precision in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=101134
Unreviewed rebaseline.
- platform/chromium-linux/webaudio/audiobuffersource-loop-points-expected.wav:
- platform/chromium/webaudio/audiobuffersource-loop-points-expected.wav: Copied from LayoutTests/platform/chromium-linux/webaudio/audiobuffersource-loop-points-expected.wav.
- platform/chromium/webaudio/audiobuffersource-playbackrate-expected.wav: Added.
- 5:51 PM Changeset in webkit [133382] by
-
- 3 edits in trunk/Tools
webkit-patch rebaseline is broken
https://bugs.webkit.org/show_bug.cgi?id=101081
Reviewed by Ojan Vafai.
I broke this in r133061 and the unit tests weren't covering this
code path. Fixed the issue and the tests. --results-directory
doesn't make sense for either 'webkit-patch rebaseline' or
'webkit-patch rebaseline-expectations', so we don't want to expose
that as a command line option, but they all call a common
_rebaseline() routine that references options.results_directory,
so we need to set a default value.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations.execute):
(Rebaseline.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline):
(TestRebaseline.test_rebaseline):
- 5:50 PM Changeset in webkit [133381] by
-
- 4 edits in trunk/Tools
lint-webkitpy doesn't autoinstall pylint properly
https://bugs.webkit.org/show_bug.cgi?id=101106
Reviewed by Ojan Vafai.
Turns out the autoinstalling code for pylint didn't install
pylint's dependencies, and the autoinstaller code didn't work
using nested directories (e.g., "logilab/astng"). Fix those issues,
clean up the autoinstaller code, and add tests to make sure everything
imports successfully.
- Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._create_scratch_directory):
(AutoInstaller._install):
(AutoInstaller.install):
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install):
- Scripts/webkitpy/thirdparty/init_unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.init):
(ThirdpartyTest.test_import_hook):
(ThirdpartyTest.test_imports):
- 5:48 PM Changeset in webkit [133380] by
-
- 9 edits in trunk/Tools
nrwt prints an awkward result message for missing results
https://bugs.webkit.org/show_bug.cgi?id=100915
Reviewed by Ojan Vafai.
Completely rework how we print out the description of
each tests's result - we now will print either "passed" or "failed",
followed by " unexpectedly" if we weren't expecting the result,
followed by a short description of each type of failure that happened
(in parentheses). Also reworked the description of each type of
failure slightly to be clearer.
Also rework the tests to make sure we have coverage of all of the
messages. Examples of the new output are posted as an attachment to
the bug.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
- Scripts/webkitpy/layout_tests/models/test_failures.py:
(FailureTimeout.message):
(FailureMissingResult.message):
(FailureTextMismatch.message):
(FailureMissingImageHash.message):
(FailureMissingImage.message):
(FailureImageHashMismatch.message):
(FailureImageHashIncorrect.message):
(FailureReftestMismatch.message):
(FailureReftestMismatchDidNotOccur.message):
(FailureReftestNoImagesGenerated.message):
(FailureMissingAudio.message):
(FailureAudioMismatch.message):
(FailureEarlyExit.message):
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_missing_and_unexpected_results):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._print_result_summary_entry):
(Printer.print_finished_test):
(Printer._result_message):
(Printer._print_unexpected_results):
- Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 5:23 PM Changeset in webkit [133379] by
-
- 2 edits in trunk/Source/WebKit2
Very speculative ArgumentDecoder crash fix
https://bugs.webkit.org/show_bug.cgi?id=101130
<rdar://problem/11917046>
Reviewed by Sam Weinig.
Switch from fastMalloc/fastFree to system malloc/free in the hopes that it'll give more information about
a crash inside TCMalloc when freeing the argument data. (It seems unlikely that this is a bug in TCMalloc, but
switching to the system malloc could potentially give better error reporting).
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::~ArgumentDecoder):
(CoreIPC::ArgumentDecoder::initialize):
- 5:14 PM Changeset in webkit [133378] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r124776. <rdar://problem/12536423>
- 5:02 PM Changeset in webkit [133377] by
-
- 2 edits in trunk/Source/WebCore
Crash calling is8Bit() in visitedLinkHash()
https://bugs.webkit.org/show_bug.cgi?id=101119
Reviewed by Filip Pizlo.
Added an isEmpty() check to AttributeURL and KURL.
- platform/LinkHash.cpp:
(WebCore::visitedLinkHash):
- 5:01 PM Changeset in webkit [133376] by
-
- 4 edits2 copies in branches/safari-536.28-branch
Merged r124733. <rdar://problem/12536503>
- 4:55 PM Changeset in webkit [133375] by
-
- 10 edits68 adds in trunk
Add support to -webkit-line-break property for CSS3 Text line-break property values and semantics.
https://bugs.webkit.org/show_bug.cgi?id=89235
Patch by Glenn Adams <glenn@skynav.com> on 2012-11-02
Reviewed by Eric Seidel.
See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping
Source/WebCore:
Web exposed changes include:
(1) The default (initial) value for -webkit-line-break becomes 'auto', instead of 'normal';
(2) The values 'auto', 'loose', 'normal', and 'strict' are added to -webkit-line-break;
(3) See [2] above for details regarding interpretation.
Tests: css3/line-break/line-break-auto-centered.html
css3/line-break/line-break-auto-half-kana.html
css3/line-break/line-break-auto-hyphens.html
css3/line-break/line-break-auto-inseparables.html
css3/line-break/line-break-auto-iteration-marks.html
css3/line-break/line-break-auto-postfixes.html
css3/line-break/line-break-auto-prefixes.html
css3/line-break/line-break-auto-sound-marks.html
css3/line-break/line-break-loose-centered.html
css3/line-break/line-break-loose-half-kana.html
css3/line-break/line-break-loose-hyphens.html
css3/line-break/line-break-loose-inseparables.html
css3/line-break/line-break-loose-iteration-marks.html
css3/line-break/line-break-loose-postfixes.html
css3/line-break/line-break-loose-prefixes.html
css3/line-break/line-break-loose-sound-marks.html
css3/line-break/line-break-normal-centered.html
css3/line-break/line-break-normal-half-kana.html
css3/line-break/line-break-normal-hyphens.html
css3/line-break/line-break-normal-inseparables.html
css3/line-break/line-break-normal-iteration-marks.html
css3/line-break/line-break-normal-postfixes.html
css3/line-break/line-break-normal-prefixes.html
css3/line-break/line-break-normal-sound-marks.html
css3/line-break/line-break-strict-centered.html
css3/line-break/line-break-strict-half-kana.html
css3/line-break/line-break-strict-hyphens.html
css3/line-break/line-break-strict-inseparables.html
css3/line-break/line-break-strict-iteration-marks.html
css3/line-break/line-break-strict-postfixes.html
css3/line-break/line-break-strict-prefixes.html
css3/line-break/line-break-strict-sound-marks.html
- platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
Add static function to construct ICU locale argument (also used as pool key) with additional
break keyword.
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):
Remove direct dependency from ICU library (and types), moving that dependency into
new {open,close}LineBreakIterator() functions (defined in TextBreakIteratorICU.cpp).
Update to take line break mode into account.
Create (and cache) different break iterators depending on line break mode (in addition to locale),
which entails expanding pool entry key format to optionally append "@break=" +
"loose"|"normal"|"strict" keyword to locale string.
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::isLooseCJKMode):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
Define LineBreakIteratorMode enumeration for use in TextBreakIterator et al.
Add state member to indicate line break mode.
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::acquireLineBreakIterator):
Use new line break mode when making iterator from pool.
Handle change of return type of LineBreakIteratorPool::take() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::releaseLineBreakIterator):
Handle change of parameter type of LineBreakIteratorPool::put() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::isCJKLocale):
New functions for determining if CJK rules apply.
(WebCore::openLineBreakIterator):
New function for abstracting opening of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
This function also takes into account the line break mode.
(WebCore::closeLineBreakIterator):
(WebCore::mapLineIteratorModeToRules):
New function for abstracting closing of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Pass line break iterator mode flag when reseting LazyLineBreakIterator.
Add looseMode local variable to prevent need for computing under isBreakable().
- rendering/RenderText.cpp:
(WebCore::mapLineBreakToIteratorMode):
Add implementation for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
(WebCore::RenderText::computePreferredLogicalWidths):
Ensure (lazy line) breakIterator is initialized for line break mode.
Ensure isBreakable() is passed loose mode flag to match behavior in RenderBlock::LineBreaker::nextLineBreak.
- rendering/RenderText.h:
(WebCore):
Add declaration for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
- rendering/break_lines.cpp:
(WebCore):
Introduce two (local) enums NBSPBehavior and LooseBehavior for expanding template on nextBreakablePosition
to include loose mode parameter.
(WebCore::isBreakableSpace):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation. Use new loose mode flavors off NBP functions.
(WebCore::needsLineBreakIterator):
Introduce loose mode behavior template parameter to optimize loose mode behavior code path in order
to prevent regression to non loose mode path.
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
Use new template parameter enums described above.
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
(WebCore::nextBreakablePositionLoose):
Introduce two additional 'loose' mode flavors of NBP template expansions.
- rendering/break_lines.h:
(WebCore):
(WebCore::isBreakable):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation.
LayoutTests:
- css3/line-break/line-break-auto-centered-expected.html: Added.
- css3/line-break/line-break-auto-centered.html: Added.
- css3/line-break/line-break-auto-half-kana-expected.html: Added.
- css3/line-break/line-break-auto-half-kana.html: Added.
- css3/line-break/line-break-auto-hyphens-expected.html: Added.
- css3/line-break/line-break-auto-hyphens.html: Added.
- css3/line-break/line-break-auto-inseparables-expected.html: Added.
- css3/line-break/line-break-auto-inseparables.html: Added.
- css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
- css3/line-break/line-break-auto-iteration-marks.html: Added.
- css3/line-break/line-break-auto-postfixes-expected.html: Added.
- css3/line-break/line-break-auto-postfixes.html: Added.
- css3/line-break/line-break-auto-prefixes-expected.html: Added.
- css3/line-break/line-break-auto-prefixes.html: Added.
- css3/line-break/line-break-auto-sound-marks-expected.html: Added.
- css3/line-break/line-break-auto-sound-marks.html: Added.
- css3/line-break/line-break-loose-centered-expected.html: Added.
- css3/line-break/line-break-loose-centered.html: Added.
- css3/line-break/line-break-loose-half-kana-expected.html: Added.
- css3/line-break/line-break-loose-half-kana.html: Added.
- css3/line-break/line-break-loose-hyphens-expected.html: Added.
- css3/line-break/line-break-loose-hyphens.html: Added.
- css3/line-break/line-break-loose-inseparables-expected.html: Added.
- css3/line-break/line-break-loose-inseparables.html: Added.
- css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
- css3/line-break/line-break-loose-iteration-marks.html: Added.
- css3/line-break/line-break-loose-postfixes-expected.html: Added.
- css3/line-break/line-break-loose-postfixes.html: Added.
- css3/line-break/line-break-loose-prefixes-expected.html: Added.
- css3/line-break/line-break-loose-prefixes.html: Added.
- css3/line-break/line-break-loose-sound-marks-expected.html: Added.
- css3/line-break/line-break-loose-sound-marks.html: Added.
- css3/line-break/line-break-normal-centered-expected.html: Added.
- css3/line-break/line-break-normal-centered.html: Added.
- css3/line-break/line-break-normal-half-kana-expected.html: Added.
- css3/line-break/line-break-normal-half-kana.html: Added.
- css3/line-break/line-break-normal-hyphens-expected.html: Added.
- css3/line-break/line-break-normal-hyphens.html: Added.
- css3/line-break/line-break-normal-inseparables-expected.html: Added.
- css3/line-break/line-break-normal-inseparables.html: Added.
- css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
- css3/line-break/line-break-normal-iteration-marks.html: Added.
- css3/line-break/line-break-normal-postfixes-expected.html: Added.
- css3/line-break/line-break-normal-postfixes.html: Added.
- css3/line-break/line-break-normal-prefixes-expected.html: Added.
- css3/line-break/line-break-normal-prefixes.html: Added.
- css3/line-break/line-break-normal-sound-marks-expected.html: Added.
- css3/line-break/line-break-normal-sound-marks.html: Added.
- css3/line-break/line-break-strict-centered-expected.html: Added.
- css3/line-break/line-break-strict-centered.html: Added.
- css3/line-break/line-break-strict-half-kana-expected.html: Added.
- css3/line-break/line-break-strict-half-kana.html: Added.
- css3/line-break/line-break-strict-hyphens-expected.html: Added.
- css3/line-break/line-break-strict-hyphens.html: Added.
- css3/line-break/line-break-strict-inseparables-expected.html: Added.
- css3/line-break/line-break-strict-inseparables.html: Added.
- css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
- css3/line-break/line-break-strict-iteration-marks.html: Added.
- css3/line-break/line-break-strict-postfixes-expected.html: Added.
- css3/line-break/line-break-strict-postfixes.html: Added.
- css3/line-break/line-break-strict-prefixes-expected.html: Added.
- css3/line-break/line-break-strict-prefixes.html: Added.
- css3/line-break/line-break-strict-sound-marks-expected.html: Added.
- css3/line-break/line-break-strict-sound-marks.html: Added.
- platform/chromium-linux/css3/line-break/line-break-auto-half-kana-expected.html: Added.
- platform/chromium-linux/css3/line-break/line-break-auto-sound-marks-expected.html: Added.
- 4:54 PM Changeset in webkit [133374] by
-
- 4 edits4 copies in branches/safari-536.28-branch
Merged r124724. <rdar://problem/12536531>
- 4:42 PM Changeset in webkit [133373] by
-
- 5 edits2 copies in branches/safari-536.28-branch
Merged r124681. <rdar://problem/12536448>
- 4:39 PM Changeset in webkit [133372] by
-
- 12 edits in trunk/Source/WebCore
Replace NodeRareData hash map with a union on m_renderer
https://bugs.webkit.org/show_bug.cgi?id=100057
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-02
Reviewed by Eric Seidel.
Use a union on Node::m_renderer between NodeRareData* and RenderObject*. This removes
the overhead of accessing rare data and the memory from the map.
This is an 8% improvement on Bindings/get-elements-by-tag-name.html which tested
document.getElementsByTagName and was previously optimized in Bug 90059 for a 5%
improvement. As this is better than even the special casing for document that was
done in that bug, general node list access should see an even greater win.
This reduces the memory usage on nytimes.com by 250k per Bug 101052 by
removing the rare data map overhead.
This is also a 15% improvement on Parser/textarea-parsing.html
By removing the performance overhead of rareData() this patch addresses the performance
issues raised in Bugs 73853, 87034 and 89635.
I ran Parser/html5-full-render.html and there was no performance regression after
tuning Text::recalcTextStyle and the refactor that was done in r132684.
No new tests, this is just a refactor.
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore::Node::Node):
- dom/Element.cpp:
(WebCore::Element::elementRareData):
- dom/Node.cpp:
(WebCore::Node::rareData):
(WebCore::Node::ensureRareData):
(WebCore::Node::clearRareData):
(WebCore::Node::renderBox):
(WebCore::Node::renderBoxModelObject):
(WebCore::Node::reportMemoryUsage):
- dom/Node.h:
(NodeRareDataBase):
Base class for NodeRareData that knows about the renderer so we can
inline the accesses in Node.h
(WebCore::NodeRareDataBase::renderer):
(WebCore::NodeRareDataBase::setRenderer):
(WebCore::NodeRareDataBase::~NodeRareDataBase):
(WebCore::NodeRareDataBase::NodeRareDataBase):
(WebCore):
(WebCore::Node::renderer):
(WebCore::Node::setRenderer):
(Node):
- dom/NodeRareData.h:
- dom/NodeRenderStyle.h:
(WebCore::Node::renderStyle):
- dom/Text.cpp:
(WebCore::Text::recalcTextStyle):
This method appears very hot in html5-full-render.html and accessing the
renderer 4 times caused a 2% performance regression with this patch. I
reduced it to 1 access and there's no longer any performance regression.
- dom/WebCoreMemoryInstrumentation.cpp: Removed tracking of the rare data map memory usage as there is no longer a map to track.
- dom/WebCoreMemoryInstrumentation.h:
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- 4:39 PM Changeset in webkit [133371] by
-
- 18 edits in trunk
Don't instantiate the Java plug-in if it's inactive
https://bugs.webkit.org/show_bug.cgi?id=101102
<rdar://problem/12595679>
Reviewed by Andreas Kling.
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
The RenderEmbeddedObject::PluginInactive reason should always result in a button being shown.
(WebChromeClient::unavailablePluginButtonClicked):
If the Java plug-in is inactive, call WKJLReportWebComponentsUsed() to reactivate the plug-in and
then reload the page.
- WebCoreSupport/WebFrameLoaderClient.mm:
(isOracleJavaPlugIn):
(isPlugInInactive):
Helper functions.
(WebFrameLoaderClient::createPlugin):
If the plug-in is inactive, set the appropriate unavailability reason on the renderer.
Source/WebKit2:
- Shared/Plugins/PluginModuleInfo.h:
Add a PluginModuleLoadPolicy enum.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::policyForPlugin):
- UIProcess/Plugins/PluginInfoStore.h:
(PluginInfoStore):
Rename shouldBlockPlugin to policyForPlugin and make it return an enum so we can handle inactive plug-ins.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::shouldBlockPlugin):
Add helper function.
(WebKit::PluginInfoStore::policyForPlugin):
If the Java plug-in is inactive, return PluginModuleInactive.
(WebKit::PluginInfoStore::reactivateInactivePlugin):
If the given plug-in is the Java plug-in, call WKJLReportWebComponentsUsed() to reactivate it.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
If the plug-in is inactive, try to reactivate it and reload the page if reactivation succeeded.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginPath):
- UIProcess/WebProcessProxy.h:
This now returns a plug-in load policy.
- UIProcess/WebProcessProxy.messages.in:
GetPluginPack now returns a load policy enum.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
Change this to a switch statement and always return true for RenderEmbeddedObject::PluginInactive.
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
Add RenderEmbeddedObject::PluginInactive to the assertion.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Update now that GetPluginPath returns a pluginLoadPolicy enum.
(WebKit::canPluginHandleResponse):
Ditto.
WebKitLibraries:
Update WebKitSystemInterface to a version that has WKJLReportWebComponentsUsed.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
Roll WebKitSystemInterface DERPS.
- 4:29 PM Changeset in webkit [133370] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Generalising flakiness for fast/forms/formaction-attribute.html.
https://bugs.webkit.org/show_bug.cgi?id=72039
- platform/chromium/TestExpectations:
- 4:24 PM Changeset in webkit [133369] by
-
- 5 edits2 copies in branches/safari-536.28-branch
Merged r124654. <rdar://problem/12516349>
- 4:19 PM Changeset in webkit [133368] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLInt 32-bit put_by_val ArrayStorage case should use the right register (t3, not t2) for the index in the publicLength updating path
https://bugs.webkit.org/show_bug.cgi?id=101118
Reviewed by Gavin Barraclough.
- llint/LowLevelInterpreter32_64.asm:
- 4:14 PM Changeset in webkit [133367] by
-
- 5 edits2 copies in branches/safari-536.28-branch
Merge 124645. '<rdar://problem/12536525>'
- 4:11 PM Changeset in webkit [133366] by
-
- 7 edits in trunk/Source
[Mac] ResourceHandle changes for network process
https://bugs.webkit.org/show_bug.cgi?id=101111
Reviewed by Jessie Berlin.
With NSOperationQueue, we'll be getting NetworkProcess delegate method calls
on secondary threads, and so we won't block other requests while consulting with WebProcess.
- platform/network/NetworkingContext.h: (WebCore::NetworkingContext::scheduledRunLoopPairs): (WebCore::NetworkingContext::scheduledOperationQueue): Add an ability to schedule on an NSOperationQueue. Now that scheduling on run loop is not a must, give scheduledRunLoopPairs() a default implementation.
- platform/network/mac/ResourceHandleMac.mm: Removed isInitializingConnection static. It was only used to catch a long obsolete bug with debug logging, and cannot work with multiple threads. (WebCore::ResourceHandle::start): Scedule on a operation queue if applicable. (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Removed a check that used isInitializingConnection.
- 4:10 PM Changeset in webkit [133365] by
-
- 4 edits in trunk/Source/WebCore
Automating gain AudioParam with linearRampToValueAtTime introduces buzzing distortion
https://bugs.webkit.org/show_bug.cgi?id=100885
Reviewed by Kenneth Russell.
AudioParamTimeline needs to use double-precision for time-values to avoid drift and precision issues.
Covered by existing tests.
- Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::calculateTimelineValues):
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::AudioParamTimeline::valuesForTimeRange):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
- Modules/webaudio/AudioParamTimeline.h:
(AudioParamTimeline):
- 4:09 PM Changeset in webkit [133364] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Fixing duplicate marking of video-media-source-state-changes.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=96725
- platform/chromium/TestExpectations:
- 3:58 PM Changeset in webkit [133363] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::Node::converToStructureTransitionWatchpoint should take kindly to ArrayifyToStructure
https://bugs.webkit.org/show_bug.cgi?id=101117
Reviewed by Gavin Barraclough.
We have logic to convert ArrayifyToStructure to StructureTransitionWatchpoint, which is awesome, except
that previously convertToStructureTransitionWatchpoint was (a) asserting that it never saw an
ArrayifyToStructure and (b) would incorrectly create a ForwardStructureTransitionWatchpoint if it did.
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToStructureTransitionWatchpoint):
- 3:30 PM Changeset in webkit [133362] by
-
- 11 edits in trunk/Source/WebCore
Reduce redundant code in SimpleFontData[platform]
https://bugs.webkit.org/show_bug.cgi?id=97245
Reviewed by Eric Seidel.
Move duplicated code out of platform specific files and into the common file.
This represents all of the methods in SimpleFontData that do not have genuine
platform specific code.
No new tests because there is no change at all in the functionality.
- platform/graphics/SimpleFontData.cpp:
(WebCore):
(WebCore::SimpleFontData::smallCapsFontData): Implementation from platform files.
(WebCore::SimpleFontData::emphasisMarkFontData): Implementation from platform files.
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore): Removed common code.
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore): Removed common code.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore): Removed common code.
- platform/graphics/pango/SimpleFontDataPango.cpp:
(WebCore): Removed common code.
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore): Removed common code.
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore): Removed common code.
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore): Removed common code.
- platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore): Removed common code.
- platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore): Removed common code.
- 3:27 PM Changeset in webkit [133361] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::SpeculativeJIT::typedArrayDescriptor should use the Float64Array descriptor for Float64Arrays
https://bugs.webkit.org/show_bug.cgi?id=101114
Reviewed by Gavin Barraclough.
As in https://bugs.webkit.org/show_bug.cgi?id=101112, this was only wrong when Float64Array descriptors
hadn't been initialized yet. That happens rarely, but when it does happen, we would crash.
This would also become much more wrong if we ever put type size info (num bytes, etc) in the descriptor
and used that directly. So it's good to fix it.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::typedArrayDescriptor):
- 3:25 PM Changeset in webkit [133360] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Mark video-media-source-state-changes.html as flaky.
- platform/chromium/TestExpectations:
- 3:21 PM Changeset in webkit [133359] by
-
- 2 edits in trunk/Source/JavaScriptCore
JIT::privateCompileGetByVal should use the uint8ClampedArrayDescriptor for compiling accesses to Uint8ClampedArrays
https://bugs.webkit.org/show_bug.cgi?id=101112
Reviewed by Gavin Barraclough.
The only reason why the code was wrong to use uint8ArrayDescriptor instead is that if we're just using
Uint8ClampedArrays then the descriptor for Uint8Array may not have been initialized.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByVal):
- 3:14 PM Changeset in webkit [133358] by
-
- 5 edits in trunk/Source/JavaScriptCore
MarkedBlocks should use something other than the mark bits to indicate liveness for newly allocated objects
https://bugs.webkit.org/show_bug.cgi?id=100877
Reviewed by Filip Pizlo.
Currently when we canonicalize cell liveness data in MarkedBlocks, we set the mark bit for every cell in the
block except for those in the free list. This allows us to consider objects that were allocated since the
previous collection to be considered live until they have a chance to be properly marked by the collector.
If we want to use the mark bits to signify other types of information, e.g. using sticky mark bits for generational
collection, we will have to keep track of newly allocated objects in a different fashion when we canonicalize cell liveness.
One method would be to allocate a separate set of bits while canonicalizing liveness data. These bits would
track the newly allocated objects in the block separately from those objects who had already been marked. We would
then check these bits, along with the mark bits, when determining liveness.
- heap/Heap.h:
(Heap):
(JSC::Heap::isLive): We now check for the presence of the newlyAllocated Bitmap.
(JSC):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::specializedSweep): We clear the newlyAllocated Bitmap if we're creating a free list. This
will happen if we canonicalize liveness data for some other reason than collection (e.g. forEachCell) and
then start allocating again.
(JSC::SetNewlyAllocatedFunctor::SetNewlyAllocatedFunctor):
(SetNewlyAllocatedFunctor):
(JSC::SetNewlyAllocatedFunctor::operator()): We set the newlyAllocated bits for all the objects
that aren't already marked. We undo the bits for the objects in the free list later in canonicalizeCellLivenessData.
(JSC::MarkedBlock::canonicalizeCellLivenessData): We should never have a FreeListed block with a newlyAllocated Bitmap.
We allocate the new Bitmap, set the bits for all the objects that aren't already marked, and then unset all of the
bits for the items currently in the FreeList.
- heap/MarkedBlock.h:
(JSC::MarkedBlock::clearMarks): We clear the newlyAllocated bitmap if it exists because at this point we don't need it
any more.
(JSC::MarkedBlock::isEmpty): If we have some objects that are newlyAllocated, we are not empty.
(JSC::MarkedBlock::isNewlyAllocated):
(JSC):
(JSC::MarkedBlock::setNewlyAllocated):
(JSC::MarkedBlock::clearNewlyAllocated):
(JSC::MarkedBlock::isLive): We now check the newlyAllocated Bitmap, if it exists, when determining liveness of a cell in
a block that is Marked.
- heap/WeakBlock.cpp:
(JSC::WeakBlock::visit): We need to make sure we don't finalize objects that are in the newlyAllocated Bitmap.
(JSC::WeakBlock::reap): Ditto.
- 3:12 PM Changeset in webkit [133357] by
-
- 2 edits in trunk/Source/JavaScriptCore
JIT::privateCompileGetByVal should use MacroAssemblerCodePtr::createFromExecutableAddress like JIT::privateCompilePutByVal
https://bugs.webkit.org/show_bug.cgi?id=101109
Reviewed by Gavin Barraclough.
This fixes crashes on ARMv7 resulting from the return address already being tagged with the THUMB2 bit.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByVal):
- 3:01 PM Changeset in webkit [133356] by
-
- 3 edits in trunk/LayoutTests
report-blocked-uri-cross-origin.html is failing
https://bugs.webkit.org/show_bug.cgi?id=101096
Reviewed by Adam Barth.
Don't actually create a report file during the syntax-only test for when
the report directive comes before the mode directive in an X-XSS-Protection
header. Thus, we avoid having to clean it up later.
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
- platform/chromium/TestExpectations:
- 2:57 PM Changeset in webkit [133355] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r124631. <rdar://problem/12536479>
- 2:54 PM Changeset in webkit [133354] by
-
- 2 edits in trunk/Source/WebCore
memory-instrumentation-cached-images.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=101103
Unreviewed.
Restore code deleted in http://trac.webkit.org/changeset/133331.
- bindings/v8/IntrusiveDOMWrapperMap.h:
- 2:45 PM Changeset in webkit [133353] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r124626. <rdar://problem/12536373>
- 2:38 PM Changeset in webkit [133352] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r124588. <rdar://problem/12516365>
- 2:35 PM Changeset in webkit [133351] by
-
- 680 edits5 copies90 adds7 deletes in trunk
Enable SUBPIXEL_LAYOUT on Mac
https://bugs.webkit.org/show_bug.cgi?id=101076
Reviewed by Dave Hyatt.
Source/JavaScriptCore:
Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES.
- Configurations/FeatureDefines.xcconfig:
LayoutTests:
Update results affected by subpixel layout.
- platform/mac/accessibility/svg-bounds-expected.txt:
- platform/mac/accessibility/svg-remote-element-expected.txt: Copied from LayoutTests/platform/mac/accessibility/svg-bounds-expected.txt.
- platform/mac/animations/keyframes-comma-separated-expected.txt: Added.
- platform/mac/compositing/direct-image-compositing-expected.txt:
- platform/mac/compositing/overflow/theme-affects-visual-overflow-expected.txt:
- platform/mac/compositing/shadows/shadow-drawing-expected.txt:
- platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt: Added.
- platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
- platform/mac/css1/basic/inheritance-expected.txt:
- platform/mac/css1/box_properties/acid_test-expected.txt:
- platform/mac/css1/box_properties/clear_float-expected.txt:
- platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
- platform/mac/css1/box_properties/margin-expected.txt:
- platform/mac/css1/box_properties/margin_bottom-expected.txt:
- platform/mac/css1/box_properties/margin_right-expected.txt:
- platform/mac/css1/box_properties/margin_top-expected.txt:
- platform/mac/css1/box_properties/padding-expected.txt:
- platform/mac/css1/box_properties/padding_bottom-expected.txt:
- platform/mac/css1/box_properties/padding_left-expected.txt:
- platform/mac/css1/box_properties/padding_right-expected.txt:
- platform/mac/css1/box_properties/padding_top-expected.txt:
- platform/mac/css1/box_properties/width-expected.txt:
- platform/mac/css1/color_and_background/background_attachment-expected.txt:
- platform/mac/css1/font_properties/font-expected.txt:
- platform/mac/css1/font_properties/font_size-expected.txt:
- platform/mac/css1/font_properties/font_weight-expected.txt:
- platform/mac/css1/formatting_model/floating_elements-expected.txt:
- platform/mac/css1/formatting_model/horizontal_formatting-expected.txt:
- platform/mac/css1/formatting_model/inline_elements-expected.txt:
- platform/mac/css1/formatting_model/replaced_elements-expected.txt:
- platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
- platform/mac/css1/text_properties/text_indent-expected.txt:
- platform/mac/css1/text_properties/vertical_align-expected.txt:
- platform/mac/css1/units/percentage_units-expected.txt:
- platform/mac/css1/units/rounding-expected.txt: Added.
- platform/mac/css2.1/20110323/block-replaced-width-001-expected.txt:
- platform/mac/css2.1/20110323/floating-replaced-height-008-expected.txt:
- platform/mac/css2.1/20110323/inline-block-replaced-height-008-expected.txt:
- platform/mac/css2.1/20110323/inline-replaced-height-008-expected.txt:
- platform/mac/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
- platform/mac/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
- platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/mac/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
- platform/mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
- platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
- platform/mac/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
- platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
- platform/mac/css2.1/t1002-c5523-width-02-b-g-expected.txt:
- platform/mac/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
- platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.txt:
- platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
- platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.txt:
- platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt:
- platform/mac/css2.1/t1506-c525-font-wt-00-b-expected.txt:
- platform/mac/css2.1/t1508-c527-font-09-b-expected.txt:
- platform/mac/css2.1/t1602-c43-center-00-d-ag-expected.txt:
- platform/mac/css3/flexbox/flexbox-baseline-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-25-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-70-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-25-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-70-expected.txt:
- platform/mac/css3/unicode-bidi-isolate-basic-expected.txt:
- platform/mac/editing/inserting/editing-empty-divs-expected.txt:
- platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
- platform/mac/editing/selection/3690703-2-expected.txt:
- platform/mac/editing/selection/3690703-expected.txt:
- platform/mac/editing/selection/3690719-expected.txt:
- platform/mac/editing/selection/4397952-expected.txt:
- platform/mac/editing/selection/5240265-expected.txt:
- platform/mac/editing/selection/5354455-2-expected.txt:
- platform/mac/editing/selection/caret-ltr-2-expected.txt:
- platform/mac/editing/selection/caret-ltr-2-left-expected.txt:
- platform/mac/editing/selection/caret-ltr-expected.txt:
- platform/mac/editing/selection/caret-ltr-right-expected.txt:
- platform/mac/editing/selection/caret-rtl-2-expected.txt:
- platform/mac/editing/selection/caret-rtl-2-left-expected.txt:
- platform/mac/editing/selection/caret-rtl-expected.txt:
- platform/mac/editing/selection/caret-rtl-right-expected.txt:
- platform/mac/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
- platform/mac/editing/selection/drag-start-event-client-x-y-expected.txt: Added.
- platform/mac/editing/selection/mixed-editability-10-expected.txt: Added.
- platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/mac/editing/selection/select-text-overflow-ellipsis-expected.txt:
- platform/mac/editing/selection/selection-button-text-expected.txt:
- platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
- platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
- platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
- platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
- platform/mac/fast/backgrounds/background-inherit-color-bug-expected.txt:
- platform/mac/fast/backgrounds/background-position-parsing-expected.txt:
- platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
- platform/mac/fast/block/basic/001-expected.txt:
- platform/mac/fast/block/basic/011-expected.txt:
- platform/mac/fast/block/basic/014-expected.txt:
- platform/mac/fast/block/basic/015-expected.txt:
- platform/mac/fast/block/basic/016-expected.txt:
- platform/mac/fast/block/basic/019-expected.txt:
- platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
- platform/mac/fast/block/float/013-expected.txt:
- platform/mac/fast/block/float/025-expected.txt:
- platform/mac/fast/block/float/026-expected.txt:
- platform/mac/fast/block/float/027-expected.txt:
- platform/mac/fast/block/float/028-expected.txt:
- platform/mac/fast/block/float/032-expected.txt:
- platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.txt:
- platform/mac/fast/block/float/float-avoidance-expected.txt:
- platform/mac/fast/block/float/float-in-float-painting-expected.txt:
- platform/mac/fast/block/float/nopaint-after-layer-destruction2-expected.txt:
- platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
- platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
- platform/mac/fast/block/margin-collapse/100-expected.txt:
- platform/mac/fast/block/margin-collapse/103-expected.txt:
- platform/mac/fast/block/positioning/047-expected.txt:
- platform/mac/fast/block/positioning/051-expected.txt:
- platform/mac/fast/block/positioning/inline-block-relposition-expected.txt:
- platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
- platform/mac/fast/borders/bidi-002-expected.txt:
- platform/mac/fast/borders/bidi-009a-expected.txt:
- platform/mac/fast/borders/bidi-012-expected.txt:
- platform/mac/fast/borders/fieldsetBorderRadius-expected.txt: Added.
- platform/mac/fast/borders/rtl-border-01-expected.txt:
- platform/mac/fast/borders/rtl-border-02-expected.txt:
- platform/mac/fast/borders/rtl-border-03-expected.txt:
- platform/mac/fast/box-sizing/box-sizing-expected.txt:
- platform/mac/fast/canvas/webgl/oes-element-index-uint-expected.txt: Added.
- platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt: Added.
- platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt: Added.
- platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgb565-expected.txt: Added.
- platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba4444-expected.txt: Added.
- platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551-expected.txt: Added.
- platform/mac/fast/clip/overflow-border-radius-composited-expected.txt:
- platform/mac/fast/clip/overflow-border-radius-transformed-expected.txt:
- platform/mac/fast/css-generated-content/011-expected.txt:
- platform/mac/fast/css-generated-content/012-expected.txt:
- platform/mac/fast/css-generated-content/013-expected.txt:
- platform/mac/fast/css-generated-content/014-expected.txt:
- platform/mac/fast/css-generated-content/015-expected.txt:
- platform/mac/fast/css-generated-content/inline-display-types-expected.txt:
- platform/mac/fast/css/003-expected.txt:
- platform/mac/fast/css/004-expected.txt:
- platform/mac/fast/css/005-expected.txt:
- platform/mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
- platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
- platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
- platform/mac/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Added.
- platform/mac/fast/css/continuationCrash-expected.txt:
- platform/mac/fast/css/css1_forward_compatible_parsing-expected.txt:
- platform/mac/fast/css/css2-system-fonts-expected.txt:
- platform/mac/fast/css/empty-pseudo-class-expected.txt:
- platform/mac/fast/css/ex-after-font-variant-expected.txt:
- platform/mac/fast/css/fieldset-display-row-expected.txt:
- platform/mac/fast/css/first-child-pseudo-class-expected.txt:
- platform/mac/fast/css/first-line-text-decoration-expected.txt:
- platform/mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
- platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
- platform/mac/fast/css/h1-in-section-elements-expected.txt:
- platform/mac/fast/css/hsl-color-expected.txt:
- platform/mac/fast/css/hsla-color-expected.txt:
- platform/mac/fast/css/inline-properties-important-expected.txt:
- platform/mac/fast/css/invalid-percentage-property-expected.txt:
- platform/mac/fast/css/large-number-round-trip-expected.txt: Added.
- platform/mac/fast/css/last-child-pseudo-class-expected.txt:
- platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
- platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt:
- platform/mac/fast/css/non-standard-checkbox-size-expected.txt:
- platform/mac/fast/css/only-child-pseudo-class-expected.txt:
- platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
- platform/mac/fast/css/percentage-non-integer-expected.txt:
- platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
- platform/mac/fast/css/rgb-float-expected.txt:
- platform/mac/fast/css/rtl-ordering-expected.txt:
- platform/mac/fast/css/selector-set-attribute-expected.txt:
- platform/mac/fast/css/text-align-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
- platform/mac/fast/css/transform-default-parameter-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
- platform/mac/fast/css/word-space-extra-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
- platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
- platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
- platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
- platform/mac/fast/dom/HTMLTableElement/cellpadding-attribute-expected.txt: Removed.
- platform/mac/fast/dom/HTMLTableElement/early-acid3-65-excerpt-expected.txt: Removed.
- platform/mac/fast/dom/HTMLTableElement/early-acid3-66-excerpt-expected.txt: Removed.
- platform/mac/fast/dom/HTMLTableElement/insert-row-expected.txt: Removed.
- platform/mac/fast/dom/HTMLTableElement/rows-expected.txt: Removed.
- platform/mac/fast/dom/HTMLTableElement/tBodies-expected.txt: Removed.
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/mac/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
- platform/mac/fast/dom/clone-node-dynamic-style-expected.txt:
- platform/mac/fast/dynamic/012-expected.txt:
- platform/mac/fast/dynamic/anchor-lock-expected.txt:
- platform/mac/fast/dynamic/subtree-parent-static-y-expected.txt:
- platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
- platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
- platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
- platform/mac/fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.
- platform/mac/fast/events/document-elementFromPoint-expected.txt: Added.
- platform/mac/fast/events/pointer-events-2-expected.txt:
- platform/mac/fast/flexbox/flex-hang-expected.txt: Added.
- platform/mac/fast/forms/001-expected.txt:
- platform/mac/fast/forms/006-expected.txt:
- platform/mac/fast/forms/007-expected.txt:
- platform/mac/fast/forms/basic-buttons-expected.txt:
- platform/mac/fast/forms/basic-inputs-expected.txt:
- platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
- platform/mac/fast/forms/blankbuttons-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/button-cannot-be-nested-expected.txt:
- platform/mac/fast/forms/button-default-title-expected.txt:
- platform/mac/fast/forms/button-generated-content-expected.txt:
- platform/mac/fast/forms/button-positioned-expected.txt:
- platform/mac/fast/forms/button-sizes-expected.txt:
- platform/mac/fast/forms/button-style-color-expected.txt:
- platform/mac/fast/forms/button-table-styles-expected.txt:
- platform/mac/fast/forms/button-text-transform-expected.txt:
- platform/mac/fast/forms/button-white-space-expected.txt:
- platform/mac/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac/fast/forms/fieldset-align-expected.txt:
- platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
- platform/mac/fast/forms/fieldset-with-float-expected.txt:
- platform/mac/fast/forms/file/file-input-direction-expected.txt:
- platform/mac/fast/forms/file/file-input-disabled-expected.txt:
- platform/mac/fast/forms/file/input-file-re-render-expected.txt:
- platform/mac/fast/forms/float-before-fieldset-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/formmove-expected.txt:
- platform/mac/fast/forms/formmove2-expected.txt:
- platform/mac/fast/forms/formmove3-expected.txt:
- platform/mac/fast/forms/indeterminate-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-button-sizes-expected.txt:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt:
- platform/mac/fast/forms/menulist-clip-expected.txt:
- platform/mac/fast/forms/minWidthPercent-expected.txt:
- platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/mac/fast/forms/range/input-appearance-range-expected.txt:
- platform/mac/fast/forms/range/slider-mouse-events-expected.txt: Added.
- platform/mac/fast/forms/search-vertical-alignment-expected.txt:
- platform/mac/fast/forms/searchfield-heights-expected.txt:
- platform/mac/fast/forms/select-baseline-expected.txt:
- platform/mac/fast/forms/targeted-frame-submission-expected.txt:
- platform/mac/fast/forms/textAreaLineHeight-expected.txt:
- platform/mac/fast/forms/validation-message-appearance-expected.txt:
- platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
- platform/mac/fast/gradients/crash-on-zero-radius-expected.txt:
- platform/mac/fast/gradients/generated-gradients-expected.txt:
- platform/mac/fast/gradients/radial-centered-expected.txt:
- platform/mac/fast/gradients/simple-gradients-expected.txt:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/mac/fast/html/details-add-child-1-expected.txt:
- platform/mac/fast/html/details-add-child-2-expected.txt:
- platform/mac/fast/html/details-add-details-child-1-expected.txt:
- platform/mac/fast/html/details-add-details-child-2-expected.txt:
- platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-1-expected.txt:
- platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-10-expected.txt:
- platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-2-expected.txt:
- platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-3-expected.txt:
- platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-4-expected.txt:
- platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-5-expected.txt:
- platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-6-expected.txt:
- platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-7-expected.txt:
- platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-8-expected.txt:
- platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-9-expected.txt:
- platform/mac/fast/html/details-add-summary-child-1-expected.txt:
- platform/mac/fast/html/details-add-summary-child-2-expected.txt:
- platform/mac/fast/html/details-marker-style-expected.txt: Added.
- platform/mac/fast/html/details-nested-1-expected.txt:
- platform/mac/fast/html/details-nested-2-expected.txt:
- platform/mac/fast/html/details-no-summary1-expected.txt:
- platform/mac/fast/html/details-no-summary2-expected.txt:
- platform/mac/fast/html/details-no-summary3-expected.txt:
- platform/mac/fast/html/details-no-summary4-expected.txt:
- platform/mac/fast/html/details-open-javascript-expected.txt:
- platform/mac/fast/html/details-open1-expected.txt:
- platform/mac/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-open3-expected.txt:
- platform/mac/fast/html/details-open4-expected.txt:
- platform/mac/fast/html/details-open5-expected.txt:
- platform/mac/fast/html/details-open6-expected.txt:
- platform/mac/fast/html/details-position-expected.txt:
- platform/mac/fast/html/details-remove-child-1-expected.txt:
- platform/mac/fast/html/details-remove-child-2-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-expected.txt:
- platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-2-expected.txt:
- platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-3-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-expected.txt:
- platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-5-expected.txt:
- platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-6-expected.txt:
- platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
- platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
- platform/mac/fast/html/details-replace-summary-child-expected.txt:
- platform/mac/fast/html/details-replace-text-expected.txt:
- platform/mac/fast/html/details-writing-mode-expected.txt:
- platform/mac/fast/images/imagemap-focus-ring-zoom-expected.txt:
- platform/mac/fast/images/zoomed-img-size-expected.txt: Added.
- platform/mac/fast/inline-block/inline-block-vertical-align-expected.txt:
- platform/mac/fast/inline/002-expected.txt:
- platform/mac/fast/inline/continuation-outlines-expected.txt:
- platform/mac/fast/inline/inline-borders-with-bidi-override-expected.txt:
- platform/mac/fast/inline/inline-box-background-expected.txt:
- platform/mac/fast/inline/inline-box-background-long-image-expected.txt:
- platform/mac/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/mac/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/mac/fast/inline/outline-continuations-expected.txt:
- platform/mac/fast/inline/positionedLifetime-expected.txt:
- platform/mac/fast/invalid/010-expected.txt:
- platform/mac/fast/invalid/014-expected.txt:
- platform/mac/fast/invalid/junk-data-expected.txt:
- platform/mac/fast/invalid/missing-end-tag-expected.txt:
- platform/mac/fast/invalid/nestedh3s-expected.txt:
- platform/mac/fast/invalid/residual-style-expected.txt:
- platform/mac/fast/layers/video-layer-expected.txt:
- platform/mac/fast/line-grid/line-align-left-edges-expected.txt:
- platform/mac/fast/line-grid/line-grid-contains-value-expected.txt:
- platform/mac/fast/lists/003-expected.txt:
- platform/mac/fast/lists/003-vertical-expected.txt:
- platform/mac/fast/lists/008-expected.txt:
- platform/mac/fast/lists/008-vertical-expected.txt:
- platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
- platform/mac/fast/loader/javascript-url-in-embed-expected.txt: Added.
- platform/mac/fast/media/mq-relative-constraints-08-expected.txt:
- platform/mac/fast/multicol/break-properties-expected.txt: Added.
- platform/mac/fast/multicol/client-rects-expected.txt:
- platform/mac/fast/multicol/column-break-with-balancing-expected.txt:
- platform/mac/fast/multicol/float-multicol-expected.txt:
- platform/mac/fast/multicol/float-paginate-complex-expected.txt:
- platform/mac/fast/multicol/layers-in-multicol-expected.txt:
- platform/mac/fast/multicol/nested-columns-expected.txt:
- platform/mac/fast/multicol/overflow-across-columns-expected.txt:
- platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt: Copied from LayoutTests/platform/mac/fast/multicol/overflow-across-columns-expected.txt.
- platform/mac/fast/multicol/overflow-unsplittable-expected.txt:
- platform/mac/fast/multicol/scrolling-overflow-expected.txt:
- platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
- platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
- platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt:
- platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
- platform/mac/fast/multicol/span/clone-flexbox-expected.txt: Added.
- platform/mac/fast/multicol/span/clone-summary-expected.txt: Added.
- platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/mac/fast/multicol/span/span-margin-collapsing-expected.txt:
- platform/mac/fast/multicol/table-vertical-align-expected.txt:
- platform/mac/fast/multicol/vertical-lr/break-properties-expected.txt: Added.
- platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
- platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
- platform/mac/fast/multicol/vertical-lr/nested-columns-expected.txt:
- platform/mac/fast/multicol/vertical-rl/break-properties-expected.txt: Added.
- platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
- platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt:
- platform/mac/fast/multicol/vertical-rl/nested-columns-expected.txt:
- platform/mac/fast/overflow/007-expected.txt:
- platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
- platform/mac/fast/overflow/infiniteRecursionGuard-expected.txt:
- platform/mac/fast/overflow/overflow-rtl-expected.txt:
- platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/mac/fast/overflow/overflow_hidden-expected.txt:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/mac/fast/overflow/scrollRevealButton-expected.txt:
- platform/mac/fast/parser/bad-xml-slash-expected.txt:
- platform/mac/fast/parser/entity-comment-in-style-expected.txt:
- platform/mac/fast/parser/style-script-head-test-expected.txt: Added.
- platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
- platform/mac/fast/reflections/reflection-with-zoom-expected.txt:
- platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
- platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
- platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
- platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
- platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
- platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
- platform/mac/fast/repaint/control-clip-expected.txt:
- platform/mac/fast/repaint/delete-into-nested-block-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
- platform/mac/fast/repaint/table-section-repaint-expected.txt: Removed.
- platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
- platform/mac/fast/repaint/transform-translate-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/table-percent-height-expected.txt: Added.
- platform/mac/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
- platform/mac/fast/replaced/width100percent-button-expected.txt:
- platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
- platform/mac/fast/replaced/width100percent-radio-expected.txt:
- platform/mac/fast/ruby/ruby-inline-table-expected.txt:
- platform/mac/fast/selectors/032-expected.txt:
- platform/mac/fast/selectors/166-expected.txt:
- platform/mac/fast/selectors/unqualified-hover-quirks-expected.txt:
- platform/mac/fast/selectors/unqualified-hover-strict-expected.txt:
- platform/mac/fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction-expected.txt: Added.
- platform/mac/fast/table/009-expected.txt:
- platform/mac/fast/table/014-expected.txt:
- platform/mac/fast/table/040-expected.txt:
- platform/mac/fast/table/040-vertical-expected.txt:
- platform/mac/fast/table/041-expected.txt:
- platform/mac/fast/table/absolute-table-at-bottom-expected.txt:
- platform/mac/fast/table/append-cells2-expected.txt:
- platform/mac/fast/table/border-collapsing/004-expected.txt:
- platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/mac/fast/table/frame-and-rules-expected.txt:
- platform/mac/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
- platform/mac/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
- platform/mac/fast/table/nested-percent-height-table-expected.txt:
- platform/mac/fast/table/overflowHidden-expected.txt:
- platform/mac/fast/table/percent-heights-expected.txt:
- platform/mac/fast/table/remove-td-display-none-expected.txt:
- platform/mac/fast/table/table-display-types-strict-expected.txt:
- platform/mac/fast/table/table-hspace-align-center-expected.txt:
- platform/mac/fast/text/basic/012-expected.txt:
- platform/mac/fast/text/basic/013-expected.txt:
- platform/mac/fast/text/basic/generic-family-reset-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
- platform/mac/fast/text/international/hindi-spacing-expected.txt:
- platform/mac/fast/text/international/thai-line-breaks-expected.txt:
- platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
- platform/mac/fast/text/line-breaks-expected.txt:
- platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
- platform/mac/fast/text/vertical-rl-rtl-linebreak-expected.txt:
- platform/mac/fast/text/whitespace/024-expected.txt:
- platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
- platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
- platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
- platform/mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
- platform/mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
- platform/mac/fast/transforms/transforms-with-zoom-expected.txt: Added.
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/mac/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
- platform/mac/fast/writing-mode/broken-ideographic-font-expected.txt:
- platform/mac/fast/writing-mode/fieldsets-expected.txt:
- platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
- platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
- platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt:
- platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
- platform/mac/http/tests/cookies/multiple-cookies-expected.txt: Added.
- platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
- platform/mac/http/tests/misc/acid3-expected.txt: Added.
- platform/mac/http/tests/misc/iframe404-expected.txt:
- platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/http/tests/security/sandboxed-iframe-origin-add-expected.txt: Added.
- platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.txt: Added.
- platform/mac/http/tests/webarchive/test-preload-resources-expected.txt: Added.
- platform/mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt:
- platform/mac/mathml/presentation/attributes-expected.txt:
- platform/mac/mathml/presentation/fenced-expected.txt:
- platform/mac/mathml/presentation/fenced-mi-expected.txt:
- platform/mac/mathml/presentation/fractions-expected.txt:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/mathml/presentation/mroot-pref-width-expected.txt:
- platform/mac/mathml/presentation/over-expected.txt:
- platform/mac/mathml/presentation/roots-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/row-expected.txt:
- platform/mac/mathml/presentation/style-expected.txt:
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.txt:
- platform/mac/mathml/presentation/sup-expected.txt:
- platform/mac/mathml/presentation/tables-expected.txt:
- platform/mac/mathml/presentation/tokenElements-expected.txt:
- platform/mac/mathml/presentation/under-expected.txt:
- platform/mac/mathml/presentation/underover-expected.txt:
- platform/mac/mathml/xHeight-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-strict-expected.txt:
- platform/mac/media/controls-styling-strict-expected.txt:
- platform/mac/media/controls-without-preload-expected.txt:
- platform/mac/media/media-controls-clone-expected.txt:
- platform/mac/media/media-element-play-after-eos-expected.txt: Added.
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/media/video-display-toggle-expected.txt:
- platform/mac/media/video-empty-source-expected.txt:
- platform/mac/media/video-no-audio-expected.txt:
- platform/mac/media/video-playing-and-pause-expected.txt:
- platform/mac/platform/mac/fast/forms/focus-option-control-on-page-expected.txt: Added.
- platform/mac/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
- platform/mac/platform/mac/fast/text/x-height-expected.txt: Added.
- platform/mac/plugins/netscape-dom-access-and-reload-expected.txt: Added.
- platform/mac/plugins/npp-set-window-called-during-destruction-expected.txt:
- platform/mac/svg/as-border-image/svg-as-border-image-2-expected.txt:
- platform/mac/svg/as-border-image/svg-as-border-image-expected.txt:
- platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
- platform/mac/svg/as-image/svg-non-integer-scaled-image-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt.
- platform/mac/svg/custom/bug45331-expected.txt:
- platform/mac/svg/custom/fractional-rects-expected.txt: Added.
- platform/mac/svg/custom/image-parent-translation-expected.txt:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/mac/svg/custom/js-update-container-expected.txt: Added.
- platform/mac/svg/custom/junk-data-expected.txt:
- platform/mac/svg/custom/missing-xlink-expected.txt:
- platform/mac/svg/custom/object-sizing-expected.txt:
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
- platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- platform/mac/svg/custom/path-bad-data-expected.txt:
- platform/mac/svg/custom/rootmost-svg-xy-attrs-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
- platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
- platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
- platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Added.
- platform/mac/svg/custom/use-font-face-crash-expected.txt:
- platform/mac/svg/custom/viewBox-hit-expected.txt: Added.
- platform/mac/svg/hixie/error/012-expected.txt:
- platform/mac/svg/text/small-fonts-in-html5-expected.txt:
- platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
- platform/mac/svg/transforms/svg-css-transforms-expected.txt:
- platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: Added.
- platform/mac/svg/webarchive/svg-feimage-subresources-expected.txt: Added.
- platform/mac/svg/webarchive/svg-script-subresouces-expected.txt: Added.
- platform/mac/svg/wicd/rightsizing-grid-expected.txt:
- platform/mac/svg/wicd/test-rightsizing-a-expected.txt:
- platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
- platform/mac/svg/wicd/test-scalable-background-image1-expected.txt:
- platform/mac/svg/wicd/test-scalable-background-image2-expected.txt:
- platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt:
- platform/mac/svg/zoom/page/zoom-background-images-expected.txt:
- platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
- platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
- platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
- platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt.
- platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt.
- platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
- platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
- platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
- platform/mac/tables/mozilla/bugs/bug10269-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1055-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug106816-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113424-expected.txt:
- platform/mac/tables/mozilla/bugs/bug11384q-expected.txt:
- platform/mac/tables/mozilla/bugs/bug11384s-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug126742-expected.txt:
- platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
- platform/mac/tables/mozilla/bugs/bug13118-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
- platform/mac/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug159108-expected.txt:
- platform/mac/tables/mozilla/bugs/bug17130-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug17130-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug17138-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
- platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
- platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2886-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3309-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3309-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33137-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
- platform/mac/tables/mozilla/bugs/bug39209-expected.txt:
- platform/mac/tables/mozilla/bugs/bug42187-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4284-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4429-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46480-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46480-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
- platform/mac/tables/mozilla/bugs/bug5538-expected.txt:
- platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
- platform/mac/tables/mozilla/bugs/bug60749-expected.txt:
- platform/mac/tables/mozilla/bugs/bug6304-expected.txt:
- platform/mac/tables/mozilla/bugs/bug67915-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug69187-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7112-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7112-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug73321-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
- platform/mac/tables/mozilla/bugs/bug8032-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug83786-expected.txt: Added.
- platform/mac/tables/mozilla/bugs/bug8381-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9271-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9271-2-expected.txt:
- platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/mac/tables/mozilla/core/bloomberg-expected.txt:
- platform/mac/tables/mozilla/core/margins-expected.txt:
- platform/mac/tables/mozilla/core/misc-expected.txt:
- platform/mac/tables/mozilla/dom/tableDom-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_index-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/mac/tables/mozilla/other/move_row-expected.txt:
- platform/mac/tables/mozilla/other/test3-expected.txt:
- platform/mac/tables/mozilla/other/test6-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug61042-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug61042-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions3-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/standards1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
- platform/mac/transforms/2d/hindi-rotated-expected.txt:
- platform/mac/transforms/2d/zoom-menulist-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-opacity-expected.txt: Added.
- platform/mac/transforms/svg-vs-css-expected.txt:
- platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.txt: Added.
- platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.txt: Added.
- platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.txt: Added.
- platform/mac/webarchive/archive-empty-frame-dom-expected.txt: Added.
- platform/mac/webarchive/archive-empty-frame-source-expected.txt: Added.
- platform/mac/webarchive/archive-with-unencoded-url-expected.txt: Added.
- platform/mac/webarchive/css-page-rule-crash-expected.txt: Added.
- platform/mac/webarchive/doctype-expected.txt: Added.
- platform/mac/webarchive/ignore-noscript-if-scripting-enabled-expected.txt: Added.
- platform/mac/webarchive/test-body-background-expected.txt: Added.
- platform/mac/webarchive/test-css-import-expected.txt: Added.
- platform/mac/webarchive/test-duplicate-resources-expected.txt: Added.
- platform/mac/webarchive/test-frameset-expected.txt: Added.
- platform/mac/webarchive/test-img-src-expected.txt: Added.
- platform/mac/webarchive/test-input-src-expected.txt: Added.
- platform/mac/webarchive/test-link-href-expected.txt: Added.
- platform/mac/webarchive/test-link-rel-icon-beforeload-expected.txt: Added.
- platform/mac/webarchive/test-object-data-expected.txt: Added.
- platform/mac/webarchive/test-script-src-expected.txt: Added.
- platform/mac/webarchive/test-table-background-expected.txt: Added.
- platform/mac/webarchive/test-td-background-expected.txt: Added.
- platform/mac/webarchive/test-xml-stylesheet-expected.txt: Added.
- 2:32 PM Changeset in webkit [133350] by
-
- 4 edits6 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening. Some new Mac baselines, and
add real bugs in place of Bug(senorblanco).
- platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
- platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
- platform/chromium/TestExpectations:
- 2:32 PM Changeset in webkit [133349] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r124580. <rdar://problem/12536416>
- 2:32 PM Changeset in webkit [133348] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix compile-time warning of a possible empty-body if statement
https://bugs.webkit.org/show_bug.cgi?id=101095
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-02
Reviewed by Yong Li.
Internally reviewed by Jeff Rogers.
BBLOG might be compiled out leaving an if statement with an empty
body. This is giving us a warning at the moment. Simply putting braces
around it will fail as well because then we'd have braces around a
single-line if. So, in following with the style observed in other parts
of BackingStore.cpp, break up the log message and add braces.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
(BlackBerry::WebKit::BackingStorePrivate::fillWindow):
(BlackBerry::WebKit::BackingStorePrivate::clearWindow):
- 2:28 PM Changeset in webkit [133347] by
-
- 8 edits in trunk/LayoutTests
[chromium] platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html failing
https://bugs.webkit.org/show_bug.cgi?id=100887
Reviewed by Ojan Vafai.
The tests were racing the load time of js-test-post.js and the test completion.
Previously, js-test-post.js would already be in the cache, so it would always load first.
Now that we clear the cache, sometimes js-test-post.js would run after the other test output.
Fix this by setting window.jsTestIsAsync = true and calling finishJSTest() when the test
ends (this delays the js-test-post.js output until finishJSTest() is called).
- platform/chromium/TestExpectations:
- platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt:
- platform/chromium/accessibility/is-ignored-change-sends-notification.html:
- platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt:
- platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html:
- platform/chromium/accessibility/text-change-notification-expected.txt:
- platform/chromium/accessibility/text-change-notification.html:
- 2:26 PM Changeset in webkit [133346] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r124564. <rdar://problem/12536416>
- 2:14 PM Changeset in webkit [133345] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed baselines for chromium-mac.
- platform/chromium-mac-lion/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
- platform/chromium-mac-snowleopard/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
- platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
- 2:12 PM Changeset in webkit [133344] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed baselines for chromium-mac.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
- 2:11 PM Changeset in webkit [133343] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Optimize backspace key handling
https://bugs.webkit.org/show_bug.cgi?id=101083
PR233591
Optimize backspace key handling. Some of these calls are not
required by IMF since the input_service already processes the backspace key
and updates the state before passing us the key.
Internally reviewed by Mike Fenton.
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-02
Reviewed by Yong Li.
Blocking calls with a flag that we clear immediately after
processing a backspace keydown.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::nodeTextChanged):
(BlackBerry::WebKit::InputHandler::selectionChanged):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 2:09 PM Changeset in webkit [133342] by
-
- 17 edits4 copies in branches/safari-536.28-branch
Merged r124556. <rdar://problem/12536530>
- 2:07 PM Changeset in webkit [133341] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setClient to null.
https://bugs.webkit.org/show_bug.cgi?id=101082
Internal PR: 235410.
Patch suggested by George Staikos, prepared by Lyon Chen.
Patch by Lianghui Chen <liachen@rim.com> on 2012-11-02
Reviewed by Yong Li.
ResourceHandle::cancel() should call setClient(0) to close the window
during which it has been cancelled but its client is still there and can
be called.
No new tests as it's a code improvement without obvious bug.
- platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::cancel):
- 1:55 PM Changeset in webkit [133340] by
-
- 2 edits in trunk/Tools
webkitpy: clean up logging in common.system.autoinstall
https://bugs.webkit.org/show_bug.cgi?id=101090
Reviewed by Ojan Vafai.
This module logged way too much, much of which was logging that
was either really redundant or useful only during initial development.
This patch deletes a lot of code and tweaks the remaining log messages
to be more useful now.
Also, clean up a bunch of lint errors and warnings.
- Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller.init):
(AutoInstaller._write_file):
(AutoInstaller._set_up_target_dir):
(AutoInstaller._create_scratch_directory):
(AutoInstaller._url_downloaded_path):
(AutoInstaller._is_downloaded):
(AutoInstaller._record_url_downloaded):
(AutoInstaller._extract_targz):
(AutoInstaller._extract_all):
(AutoInstaller._unzip):
(AutoInstaller._download_to_stream):
(AutoInstaller._download):
(AutoInstaller._install):
(AutoInstaller.install):
- 1:53 PM Changeset in webkit [133339] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Mark report-blocked-uri-cross-origin.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=101096
- platform/chromium/TestExpectations:
- 1:43 PM Changeset in webkit [133338] by
-
- 14 edits in trunk/Source
Add a PluginInactive plug-in unavailability reason
https://bugs.webkit.org/show_bug.cgi?id=101089
Reviewed by Sam Weinig.
Source/WebCore:
This is to be used by Mac WebKit and WebKit2 shortly.
- English.lproj/Localizable.strings:
- platform/LocalizedStrings.cpp:
(WebCore::inactivePluginText):
(WebCore):
- platform/LocalizedStrings.h:
(WebCore):
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::inactivePluginText):
(WebCore):
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::inactivePluginText):
(WebCore):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::inactivePluginText):
(WebCore):
- platform/qt/LocalizedStringsQt.cpp:
(WebCore::inactivePluginText):
(WebCore):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::unavailablePluginReplacementText):
- rendering/RenderEmbeddedObject.h:
Source/WebKit/chromium:
- src/LocalizedStrings.cpp:
(WebCore::inactivePluginText):
(WebCore):
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
- 1:41 PM Changeset in webkit [133337] by
-
- 7 edits in branches/safari-536.28-branch
Merged r124520. <rdar://problem/12536445>
- 1:33 PM Changeset in webkit [133336] by
-
- 3 edits1 copy3 deletes in branches/safari-536.28-branch/LayoutTests
Merge 123658.
- 1:27 PM Changeset in webkit [133335] by
-
- 2 edits in trunk/Source/WebCore
[CMAKE] Remove QNX specific section
https://bugs.webkit.org/show_bug.cgi?id=101063
Reviewed by Daniel Bates.
We do not need the QNX section anymore, so also remove the FEATURE_DEFINES_CSS variable as it
equals FEATURE_DEFINES_WITH_SPACE_SEPARATOR.
- CMakeLists.txt:
- 1:21 PM Changeset in webkit [133334] by
-
- 2 edits in trunk/Source/WebCore
visitedHashLink() converts 8 bit URLs and attributes to 16 bits.
https://bugs.webkit.org/show_bug.cgi?id=101014
Reviewed by Geoffrey Garen.
Converted most of the static methods to templated based on character type. Changed visitedHashLink to
check bitness of both the base URL and attribute. If both are 8 bit, then we process using the LChar
version of the templated methods. Otherwise we use the 16 bit flavor.
Changes covered by existing tests.
- platform/LinkHash.cpp:
(WebCore::findSlashDotDotSlash):
(WebCore::findSlashSlash):
(WebCore::findSlashDotSlash):
(WebCore::containsColonSlashSlash):
(WebCore::squeezeOutNullCharacters):
(WebCore::cleanSlashDotDotSlashes):
(WebCore::mergeDoubleSlashes):
(WebCore::cleanSlashDotSlashes):
(WebCore::cleanPath):
(WebCore::matchLetter):
(WebCore::needsTrailingSlash):
(WebCore::visitedURLInline):
(WebCore::visitedURL):
(WebCore::visitedLinkHash):
- 1:20 PM Changeset in webkit [133333] by
-
- 2 edits in trunk/Source/JavaScriptCore
RegExp.prototype.toString Should Produce an 8 bit JSString if possible.
https://bugs.webkit.org/show_bug.cgi?id=101003
Reviewed by Geoffrey Garen.
Took the logic of regExpObjectSource() and created two templated helpers that uses the
source character type when appending to the StringBuilder.
- runtime/RegExpObject.cpp:
(JSC::appendLineTerminatorEscape): Checks line terminate type to come up with escaped version.
(JSC::regExpObjectSourceInternal): Templated version of original.
(JSC::regExpObjectSource): Wrapper function.
- 12:58 PM Changeset in webkit [133332] by
-
- 28 edits3 adds in trunk
Support invalidation tracking for composited layers
https://bugs.webkit.org/show_bug.cgi?id=97801
Reviewed by Simon Fraser.
GraphicsLayers now store invalidated rects and can include them in
the layer tree dump.
Source/WebCore:
Test: compositing/repaint/invalidations-on-composited-layers.html
- WebCore.exp.in: Exports FrameView::resetTrackedRepaints()
- page/FrameView.cpp:
(WebCore::FrameView::setTracksRepaints):
Notifies each compositor that we are starting/stopping repaints.
(WebCore::FrameView::resetTrackedRepaints):
Moved implementation to the cpp file.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::~GraphicsLayer):
Clears the repaint rects associated with this layer.
(WebCore::GraphicsLayer::resetTrackedRepaints):
Clears the repaint rects associated with this layer.
Note that the repaint rects are stored in a statically allocated
HashMap to avoid using space on the graphics layers.
(WebCore::GraphicsLayer::addRepaintRect):
Adds a repaint rect to list associated with this layer in the
hash map mentioned above.
(WebCore::GraphicsLayer::dumpProperties):
This has been modified to include the repaint rects in the dump
if they've been requested.
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::isTrackingRepaints):
This is how graphics layers check if repaint tracking is happening.
Returns false by default.
- platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::setContentsNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
These now call GraphicsLayer::addRepaintRect as necessary.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setNeedsDisplayInRect):
Now calls GraphicsLayer::addRepaintRect as necessary.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
These now call GraphicsLayer::addRepaintRect as necessary.
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::setNeedsDisplay):
(WebCore::GraphicsLayerClutter::setNeedsDisplayInRect):
These now call GraphicsLayer::addRepaintRect as necessary.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
These now call GraphicsLayer::addRepaintRect as necessary.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isTrackingRepaints):
Required since this is a GraphicsLayerClient.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
Now accepts a flag to include the repaint rects in the layer tree
dump.
(WebCore::resetTrackedRepaintRectsRecursive):
Clears the repaint rects on all graphics layers.
(WebCore::RenderLayerCompositor::resetTrackedRepaintRects):
Clears the repaint rects on all graphics layers.
(WebCore::RenderLayerCompositor::isTrackingRepaints):
Required since this is a GraphicsLayerClient.
- testing/Internals.cpp:
(WebCore::Internals::layerTreeAsText):
- testing/Internals.h:
- testing/Internals.idl: The internals changes plumb the new flag for including the repaint rects in the layer tree dump.
Source/WebKit/chromium:
(WebKit::WebWidget::isTrackingRepaints):
Used by the NonCompositedContentHost to determine if we are tracking
repaint rects.
(WebKit::WebWidget::isTrackingRepaints):
- src/LinkHighlight.cpp:
(WebKit::LinkHighlight::updateGeometry):
Now calls GraphicsLayer::addRepaintRect when invalidated.
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::isTrackingRepaints):
Required as this is a GraphicsLayerClient.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::isTrackingRepaints):
Implementation of WebWidget::isTrackingRepaints.
LayoutTests:
- compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
- compositing/repaint/invalidations-on-composited-layers.html: Added.
- platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
- 12:22 PM Changeset in webkit [133331] by
-
- 3 edits in trunk/Source/WebCore
[V8] Generalize NodeWrapperMap to be able to handle other sorts of keys
https://bugs.webkit.org/show_bug.cgi?id=100973
Reviewed by Stephen White.
This is the first step towards using intrusive DOM wrapper maps more
widely in WebCore (see
http://lists.webkit.org/pipermail/webkit-dev/2012-November/022686.html
for more context).
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore):
(WebCore::IntrusiveDOMWrapperMap::weakCallback):
- 12:15 PM Changeset in webkit [133330] by
-
- 4 edits2 adds in trunk
ASSERT in RenderLayer::hitTestContents can fire
https://bugs.webkit.org/show_bug.cgi?id=99656
Reviewed by Eric Seidel.
Source/WebCore:
The issue is that updateHitTestResult and addNodeToRectBasedTestResult
are using two different nodes. Since they aren't consistent, we violate
assertions about only setting the inner node if we're doing a
rect-based hit test. This patch makes the two consistent.
Test: fast/dom/nodesFromRect/nodesFromRect-continuation-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeForHitTest):
(WebCore):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::updateHitTestResult):
- rendering/RenderBlock.h:
(RenderBlock):
LayoutTests:
This test ensures that we don't trigger the assert.
- fast/dom/nodesFromRect/nodesFromRect-continuation-crash-expected.txt: Added.
- fast/dom/nodesFromRect/nodesFromRect-continuation-crash.html: Added.
- 12:05 PM Changeset in webkit [133329] by
-
- 16 edits in trunk
Prefer 'Content-Security-Policy' to 'X-WebKit-CSP'.
https://bugs.webkit.org/show_bug.cgi?id=101043
Reviewed by Adam Barth.
The canonical 'Content-Security-Policy' header landed in 133095, but we
missed a few tests while updating to the new hotness. We also should
start using the canonical header for the inspector.
This patch should have no visible change; tests should continue to pass
with the new header, just as they did with the old header.
Source/WebCore:
- inspector/front-end/inspector.html:
LayoutTests:
- http/tests/inspector/stacktraces/csp-injected-content-warning-contains-stacktrace.html:
- http/tests/inspector/stacktraces/csp-inline-warning-contains-stacktrace.html:
- http/tests/inspector/stacktraces/csp-setInterval-warning-contains-stacktrace.html:
- http/tests/inspector/stacktraces/csp-setTimeout-warning-contains-stacktrace.html:
- http/tests/security/contentSecurityPolicy/img-blocked-no-gc-crash.html:
- http/tests/security/isolatedWorld/bypass-main-world-csp.html:
- inspector/console/console-eval-blocked.html:
- inspector/debugger/debugger-pause-on-blocked-event-handler.html:
- inspector/debugger/debugger-pause-on-blocked-script-injection.html:
- inspector/debugger/debugger-pause-on-blocked-script-url.html:
- inspector/debugger/eval-on-pause-blocked.html:
- inspector/elements/resolve-node-blocked.html:
- media/csp-blocks-video.html:
- 12:02 PM Changeset in webkit [133328] by
-
- 5 edits in trunk/Tools
webkit-patch analyze-baselines output is weak
https://bugs.webkit.org/show_bug.cgi?id=100998
Reviewed by Ojan Vafai.
Currently analyze-baselines prints a list of baselines that have
the same checksum per line, but the format is hard to read;
this patch cleans up the output to print by directory instead
and use the same format I recently added for debugging optimize-baselines,
then refactors the code so that we share and adds tests for
analyze-baselines (which was untested).
Also, I got rid of a couple of unnecessarily-hardcoded port names,
and modified the baseline optimizer to log the current world when
optimize fails.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer.read_results_by_directory):
(BaselineOptimizer.write_by_directory):
(BaselineOptimizer.optimize):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(OptimizeBaselines.execute):
(AnalyzeBaselines.init):
(AnalyzeBaselines._write):
(AnalyzeBaselines._analyze_baseline):
(AnalyzeBaselines.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(_FakeOptimizer):
(_FakeOptimizer.read_results_by_directory):
(TestAnalyzeBaselines):
(TestAnalyzeBaselines.setUp):
(TestAnalyzeBaselines.test_default):
(TestAnalyzeBaselines.test_missing_baselines):
- 12:02 PM Changeset in webkit [133327] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marking object-clip-rects-assertion.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=86909
- platform/chromium/TestExpectations:
- 12:01 PM Changeset in webkit [133326] by
-
- 38 edits13 deletes in trunk
ENABLE(UNDO_MANAGER) is disabled everywhere and is not under active development
https://bugs.webkit.org/show_bug.cgi?id=100711
Reviewed by Eric Seidel.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No one is actively working on ENABLE(UNDO_MANAGER). There are some
tricky lifetime issues in the UndoManager API that are complicating
ongoing work to improve the interaction between WebCore and the garbage
collector. Rather than leave this code in a broken state, we should
remove it for the time being. We can always restore it from the svn
history when there is an active owner for this code.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.features.am:
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- UseV8.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMTransaction.cpp: Removed.
- bindings/js/DOMTransaction.h: Removed.
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSUndoManagerCustom.cpp: Removed.
- bindings/v8/DOMTransaction.cpp: Removed.
- bindings/v8/DOMTransaction.h: Removed.
- bindings/v8/V8HiddenPropertyName.h:
(WebCore):
- bindings/v8/custom/V8DOMTransactionCustom.cpp: Removed.
- bindings/v8/custom/V8UndoManagerCustom.cpp: Removed.
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
- dom/CharacterData.cpp:
(WebCore::CharacterData::setDataAndUpdate):
- dom/ContainerNode.cpp:
(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::updateTreeAfterInsertion):
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore):
(Document):
- dom/Document.idl:
- dom/Element.cpp:
(WebCore::Element::willModifyAttribute):
- editing/CompositeEditCommand.h:
- editing/DOMTransaction.idl: Removed.
- editing/DOMTransactionStep.cpp: Removed.
- editing/DOMTransactionStep.h: Removed.
- editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::canUndo):
(WebCore::Editor::undo):
(WebCore::Editor::canRedo):
(WebCore::Editor::redo):
- editing/UndoManager.cpp: Removed.
- editing/UndoManager.h: Removed.
- editing/UndoManager.idl: Removed.
- editing/UndoStep.h:
(UndoStep):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
- 11:54 AM Changeset in webkit [133325] by
-
- 3 edits in trunk/Source/WebCore
Measure the usage of the various CSP headers.
https://bugs.webkit.org/show_bug.cgi?id=100974
Reviewed by Adam Barth.
Currently, we're collecting metrics regarding usage of the
'X-WebKit-CSP' and 'X-WebKit-CSP-Report-Only' HTTP headers. We've
recently added support for the canonical 'Content-Security-Policy'
and 'Content-Security-Policy-Report-Only' headers. This patch adds
those headers explicitly into the metrics, giving insight into uptake
of the unprefixed header, and into usage of pure reporting vs.
enforcement.
No visible functionality should change; all Content Security Policy
tests should continue to pass.
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
Convert the CSP header type into a FeatureObserver::Feature, and
observe it.
- page/FeatureObserver.h:
Add three new values to the enum to cover the new header types.
- 11:53 AM Changeset in webkit [133324] by
-
- 2 edits in trunk/Source/WebCore
Fix silly mistake from http://trac.webkit.org/changeset/133315.
Forgot to remove the "!".
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
- 11:50 AM Changeset in webkit [133323] by
-
- 16 edits5 copies11 adds in trunk
Support X-XSS-Protection: report=URL header syntax in XSSAuditor.
https://bugs.webkit.org/show_bug.cgi?id=100892
Reviewed by Adam Barth.
Source/WebCore:
This patch adds a security feature which allows a violation report to be sent back
to a site when the XSSAuditor detects a reflected XSS against it. It uses the same
reporting mechanism as for CSP violation reports.
Tests: http/tests/security/xssAuditor/malformed-xss-protection-header-5.html
http/tests/security/xssAuditor/malformed-xss-protection-header-6.html
http/tests/security/xssAuditor/malformed-xss-protection-header-7.html
http/tests/security/xssAuditor/malformed-xss-protection-header-8.html
http/tests/security/xssAuditor/malformed-xss-protection-header-9.html
http/tests/security/xssAuditor/report-script-tag.html
http/tests/security/xssAuditor/xss-protection-parsing-03.html
http/tests/security/xssAuditor/xss-protection-parsing-04.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
Invoke Ping loader's violation reporting, if requested, when a reflected
XSS is detected.
- html/parser/XSSAuditor.h:
XSSAuditor class need to store the report URL as well as the undigested versions
of the request URL and request body for reporting.
- loader/MixedContentChecker.cpp:
(WebCore):
- loader/MixedContentChecker.h:
(MixedContentChecker):
Make isMixedContent() method public.
- loader/PingLoader.cpp:
(WebCore::PingLoader::sendViolationReport):
- loader/PingLoader.h:
(PingLoader):
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
Renamed reportContentSecurityPolicyViolation() method to sendViolationReport(),
since this is now used to send more than just CSP violations.
- platform/network/HTTPParsers.cpp:
(WebCore):
(WebCore::skipEquals):
(WebCore::skipValue):
(WebCore::parseXSSProtectionHeader):
- platform/network/HTTPParsers.h:
Parse and return report= directive in X-XSS-Protection header.
LayoutTests:
- http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt: Added.
- http/tests/security/xssAuditor/malformed-xss-protection-header-5.html: Added.
- http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt: Added.
- http/tests/security/xssAuditor/malformed-xss-protection-header-6.html: Added.
- http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt: Added.
- http/tests/security/xssAuditor/malformed-xss-protection-header-7.html: Added.
- http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt: Added.
- http/tests/security/xssAuditor/malformed-xss-protection-header-8.html: Added.
- http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt: Added.
- http/tests/security/xssAuditor/malformed-xss-protection-header-9.html: Added.
- http/tests/security/xssAuditor/report-script-tag-expected.txt: Added.
- http/tests/security/xssAuditor/report-script-tag.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
- http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt: Added.
- http/tests/security/xssAuditor/xss-protection-parsing-03.html: Added.
- http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt: Added.
- http/tests/security/xssAuditor/xss-protection-parsing-04.html: Added.
- 11:45 AM Changeset in webkit [133322] by
-
- 5 edits1 add2 deletes in trunk/LayoutTests
[Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98523
Reviewed by Simon Fraser.
The repaint-subrect-grid.html layout test is now text-based and
doesn't use testRunner.displayInvalidatedRegion().
- fast/images/repaint-subrect-grid-expected.txt:
- fast/images/repaint-subrect-grid.html:
- platform/chromium/fast/images/repaint-subrect-grid-expected.png: Removed.
- platform/efl/fast/images/repaint-subrect-grid-expected.png: Removed.
- platform/mac/TestExpectations:
- platform/mac/fast/images/repaint-subrect-grid-expected.txt: Added.
- platform/qt/TestExpectations:
- 11:43 AM Changeset in webkit [133321] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r133313.
http://trac.webkit.org/changeset/133313
https://bugs.webkit.org/show_bug.cgi?id=101078
"A lot of tests hit the ASSERTs introduced by this patch"
(Requested by haraken on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-02
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setDOMWrapper):
- 11:39 AM Changeset in webkit [133320] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marking some repaint tests as flaky.
https://bugs.webkit.org/show_bug.cgi?id=84720
- platform/chromium/TestExpectations:
- 11:33 AM Changeset in webkit [133319] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r132913.
http://trac.webkit.org/changeset/132913
https://bugs.webkit.org/show_bug.cgi?id=91850
Caused performance regressions.
See https://bugs.webkit.org/show_bug.cgi?id=100872 for details.
- bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::visitExternalStrings):
- bindings/v8/V8StringResource.cpp:
(StringTraits):
(WebCore::v8StringToWebCoreString):
- bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):
(WebCore::WebCoreStringResource::visitStrings):
- bindings/v8/V8ValueCache.h:
(WebCore::WebCoreStringResource::WebCoreStringResource):
(WebCore::WebCoreStringResource::~WebCoreStringResource):
(WebCore::WebCoreStringResource::data):
(WebCoreStringResource):
(WebCore::WebCoreStringResource::length):
(WebCore::WebCoreStringResource::atomicString):
(WebCore::WebCoreStringResource::toStringResource):
- 11:27 AM Changeset in webkit [133318] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] Crash when calling WebOpenPanelResultListenerProxy::cancel() after PageClient is destroyed
https://bugs.webkit.org/show_bug.cgi?id=100977
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-02
Reviewed by Alexey Proskuryakov.
Call WebPageProxy::close() in EwkViewImpl's destructor to avoid crashes
if other objects keep a reference to the WebPageProxy and try to use
it after the view (and therefore the PageClient) is destroyed.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::~EwkViewImpl):
- 11:05 AM Changeset in webkit [133317] by
-
- 13 edits3 adds in trunk
[GTK] Remove dependency on SoupPasswordManager
https://bugs.webkit.org/show_bug.cgi?id=100775
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-11-02
Reviewed by Carlos Garcia Campos.
.:
Add a libsecret dependency to the build. This is necessary so that we can remove
a dependency on SoupPasswordManager.
- configure.ac: Look for libsecret using the pkg-config configuration macro.
Source/WebCore:
Remember passwords using libsecret instead of SoupPasswordManager. We accomplish this using
a new class, CredentialBackingStore. CredentialBackingStore will soon be the thing that backs
CredentialStoreGtk. The name is based on the name of a similar class from the BlackBerry port.
No new tests. This does not change behavior.
- GNUmakefile.am: Add libsecret flags to the build and the new directory to the include list.
- GNUmakefile.list.am: Add new files to the source list.
- platform/gtk/GRefPtrGtk.cpp: Add support for SecretValue to GRefPtrGtk.
- platform/gtk/GtkAuthenticationDialog.cpp: Replace interaction with SoupPasswordManger with
interaction with the CredentialBackingStore. Remove all conditional SoupPasswordManager guards.
- platform/gtk/GtkAuthenticationDialog.h: Ditto.
- platform/network/gtk/CredentialBackingStore.cpp: Added.
- platform/network/gtk/CredentialBackingStore.h: Added.
Source/WebKit/gtk:
Add a libsecret dependency to the build. This is necessary so that we can remove
a dependency on SoupPasswordManager.
- GNUmakefile.am: Use libsecret libs during WebKit1 library compilation.
Source/WebKit2:
Add a libsecret dependency to the build. This is necessary so that we can remove
a dependency on SoupPasswordManager.
- GNUmakefile.am: Add libsecret CFLAGS to the WebKit2 build.
- 10:57 AM Changeset in webkit [133316] by
-
- 2 edits in trunk/Source/WebCore
Fix build warning [-Wswitch]
https://bugs.webkit.org/show_bug.cgi?id=101029
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-02
Reviewed by Alexey Proskuryakov.
Fix build warning message: enumeration value ‘Viewport’ not handled in switch [-Wswitch]
in Source/WebCore/css/StyleSheetContents.cpp.
Add case statement for 'Viewport' with the CSS_DEVICE_ADAPTATION macro.
- css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):
- 10:54 AM Changeset in webkit [133315] by
-
- 2 edits in trunk/Source/WebCore
Move m_element checks out of canShareStyle into locateSharedStyle
https://bugs.webkit.org/show_bug.cgi?id=101070
Reviewed by Darin Adler.
Can shareStyleWithElement is called for each sibling as we look for a
shareElement. locateSharedStyle is called once for the element we're
trying to find a style for. Checks that only depend on the latter
element should, thus be in locateSharedStyle.
No new tests. There should be no change in behavior, except possibly
a performance improvement in some cases.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
- 10:46 AM Changeset in webkit [133314] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Adding window.external to our port
https://bugs.webkit.org/show_bug.cgi?id=100868
Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-02
Reviewed by Rob Buis.
PR 158809
Patch up an error where we were dereferencing a null pointer.
- WebCoreSupport/ExternalExtension.cpp:
(addSearchProviderMethod):
(IsSearchProviderInstalledMethod):
- 10:42 AM Changeset in webkit [133313] by
-
- 2 edits in trunk/Source/WebCore
[V8] Add ASSERT() to guarantee that we don't store NULL pointers to V8 internal fields
https://bugs.webkit.org/show_bug.cgi?id=101054
Reviewed by Adam Barth.
I'm investigating a Chromium crash bug:
http://code.google.com/p/chromium/issues/detail?id=155942
I've not yet identified the root cause (because I can't reproduce
the crash), but it looks like we are storing NULL pointers to
V8 internal fields. Just in case, we can add an ASSERT() to
guarantee that NULL pointers are never stored. (Also I'm hoping
that this ASSERT() will give me more debug information.)
No tests. No change in behavior.
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setDOMWrapper):
- 10:19 AM Changeset in webkit [133312] by
-
- 5 edits in trunk
Imrpove scoring in touch adjustment to address bias towards smaller targets.
https://bugs.webkit.org/show_bug.cgi?id=101046
Patch by Kevin Ellis <kevers@chromium.org> on 2012-11-02
Reviewed by Antonio Gomes.
Source/WebCore:
Update the touch overlap score for touch adjustmetn to normalize
with respect to the maximum possible overlap rather than the size
of the target element. This change enables good overlap scores for
small and large targets alike. Prior to the patch it was not possible
to get a good overlap score for a sufficiently larget target.
Covered by existing tests, which have been updated to reflect the
intended behavior.
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::hybridDistanceFunction):
LayoutTests:
Add missing mouse handlers to ensure proper handling of nested
elements. Nested elements with explicit handlers are favored over
ancestor elements. The change to scoring in touch adjustment,
which removes bias towards small targets, broke two of the layout
tests. The updated tests more accurately reflect intended
behavior.
- touchadjustment/nested-shadow-node.html:
- touchadjustment/rotated-node.html:
- 10:10 AM Changeset in webkit [133311] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Repeated errors are rendered incorrectly: link is not floating to the right.
https://bugs.webkit.org/show_bug.cgi?id=101032
Reviewed by Yury Semikhatsky.
https://bugs.webkit.org/show_bug.cgi?id=100525 incorrectly added
'-webkit-flex: 1' only to the list generated for errors in the console.
It should have been added to normal warning text as well. This patch
fixes the problem.
- inspector/front-end/inspector.css:
(.repeated-message .outline-disclosure, .repeated-message > .console-message-text):
- 10:07 AM Changeset in webkit [133310] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Timeline: show popup for CPU bars.
https://bugs.webkit.org/show_bug.cgi?id=100951
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-02
Reviewed by Pavel Feldman.
Each CPU bar can represent a combination of several shorter messages.
We should show information about combined messages - start time,
total duration, CPU time, message count.
- English.lproj/localizedStrings.js: Added "Message Count" string.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._refreshMainThreadBars):
Supply elements with underlying info.
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.generateMainThreadBarPopupContent):
Added.
- 9:58 AM Changeset in webkit [133309] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Network panel grid UI is misaligned after r132888
https://bugs.webkit.org/show_bug.cgi?id=101050
Rollback the change to basic data grid css and move it to the native memory
snapshot datagrid css.
Patch by Alexei Filippov <alph@chromium.org> on 2012-11-02
Reviewed by Alexander Pavlov.
- inspector/front-end/dataGrid.css:
(.data-grid td):
- inspector/front-end/nativeMemoryProfiler.css:
(.native-snapshot-view .data-grid td):
- 9:43 AM Changeset in webkit [133308] by
-
- 15 edits3 copies1 move1 delete in trunk
Unreviewed, rolling out r133303.
http://trac.webkit.org/changeset/133303
https://bugs.webkit.org/show_bug.cgi?id=101068
"Broke qt wk2 build (seems like bots fails to rerun qmake if
needed)" (Requested by kbalazs on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-02
Source/WebCore:
- Target.pri:
- WebCore.pri:
- platform/PlatformStrategies.cpp:
(WebCore):
- platform/qt/QtTestSupport.h: Removed.
Tools:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
(WebKit):
(WebKit::initializeTestFonts):
- DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
(WebKit):
- QtTestBrowser/QtTestBrowser.pro:
- QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
- WebKitTestRunner/InjectedBundle/Target.pri:
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
- WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/qt/main.cpp:
(main):
- 9:30 AM Changeset in webkit [133307] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Change the scope of locking in WorkQueueEfl.cpp.
https://bugs.webkit.org/show_bug.cgi?id=98978
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-11-02
Reviewed by Kenneth Rohde Christiansen.
Release the m_workItemQueueLock and m_timerWorkItemsLock mutexes
immediately after the protected resource is no longer modified to
prevent a possible source of a deadlock.
And additional mutex locker for the m_writeToPipeDescriptor is added
to ensure thread-safety of the sendMessageToThread() function.
- Platform/WorkQueue.h:
(WorkQueue):
- Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::insertTimerWorkItem):
(WorkQueue::performTimerWork):
(WorkQueue::sendMessageToThread):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
- 9:16 AM Changeset in webkit [133306] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 9:14 AM Changeset in webkit [133305] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/TestExpectations:
- 9:09 AM Changeset in webkit [133304] by
-
- 2 edits1 add in trunk/Source/WebKit2
[EFL][WK2] Add API unit tests for Ewk_Object
https://bugs.webkit.org/show_bug.cgi?id=101037
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-02
Reviewed by Kenneth Rohde Christiansen.
Added API unit tests for Ewk_Object.
- PlatformEfl.cmake:
- UIProcess/API/efl/tests/test_ewk2_object.cpp: Added.
(TestEwkObject1):
(TestEwkObject1::create):
(TestEwkObject1::~TestEwkObject1):
(TestEwkObject2):
(TestEwkObject2::create):
(TEST_F):
- 9:02 AM Changeset in webkit [133303] by
-
- 15 edits1 move1 add3 deletes in trunk
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838
Reviewed by Simon Hausmann.
Source/WebCore:
The problem here is that we use QWebSettings::clearMemoryCaches, a WebKit1 API
from the injected bundle, which calls initializeWebCoreQt and it sets the platform
strategies to the one for WebKit1. We should stop using WebKit1 API's from WebKit2
code. In order to keep the behavior, this patch adds exported helpers to WebCore
that can be used from DumpRenderTree and WebKitTestRunner. This is the same idea
as WebCoreTestSupport but these helpers are specific to Qt. Technically we could
add it to the WebKit1 API for the time being, but my goal was to move in the direction
of removing the WebKit1 dependency from WebKitTestRunner. We only build the file
in non production mode.
Basically covered by all tests.
- Target.pri:
- WebCore.pri: We need to link against fontconfig (only in non-production mode) since
initializeTestFonts uses it.
- platform/PlatformStrategies.cpp:
(WebCore): Zero initialize the global static variable as it is expected by the functions
below. It is a side fix. It seems like it has not been shown on debug WebKit2 bots because
common runtime environments tend to zero initialize statics by default - but I don't think
we should rely on that.
- platform/qt/QtTestSupport.cpp: Added. I choose GPL license because code from qwebsettings.cpp
is also under that.
(WebKit):
(WebKit::QtTestSupport::clearMemoryCaches): This is basically a copy of QWebSettings::clearMemoryCaches
without calling initializeWebCoreQt.
(WebKit::QtTestSupport::initializeTestFonts): I moved this code here as well now that we have to expose
symbols from WebCore anyway. The advantage is that now we don't have to build it twice and we don't need
additional files to forward it from the directory of DumpRenderTree for WebKitTestRunner.
I added a call to FontCace::invalidate in the case when the font set has been changed so that it will do
the job even if we would stop clearing all caches between tests. Also moved the call to
QFontDatabase::removeAllApplicationFonts from callers to here.
- platform/qt/QtTestSupport.h:
(WebKit):
(QtTestSupport):
Tools:
Turned test runners to use the new QtTestSupport.
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
- QtTestBrowser/QtTestBrowser.pro:
- QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
- WebKitTestRunner/InjectedBundle/Target.pri:
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
- WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
- WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
- WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize): Removed the comment from here
because it was just lying, apparently two times. First, it is not incorrect
to reinitialize our font set and clear font caches, it is what the tests
expect. Second, the use of QRawFont has nothing to do with the font cache.
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/qt/main.cpp:
(main):
- 8:42 AM Changeset in webkit [133302] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Fix build on Windows when Qt is configured with -release
https://bugs.webkit.org/show_bug.cgi?id=101041
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-11-02
Reviewed by Jocelyn Turcotte.
When Qt is configured with -debug or -release, the release/debug build of for example
QtCore is not available by default. For LLIntExtractor we always need to build debug
_and_ release versions, but we do not actually need any Qt libraries nor qtmain(d).lib.
Therefore we can disable all these features but need to keep $$QT.core.includes in the
INCLUDEPATH for some defines from qglobal.h.
- LLIntOffsetsExtractor.pro:
- 8:26 AM Changeset in webkit [133301] by
-
- 4 edits in trunk/Source
Optimize DateTimeFormat::quoteAndAppendLiteral output
https://bugs.webkit.org/show_bug.cgi?id=101040
Reviewed by Kentaro Hara.
Source/WebCore:
In LDML date format pattern, only ASCII alphabet and quote have special
roles. So we don't need to quote the input string if it doesn't contain
them.
No new tests. Updated WebKit/chromium/tests/LocaleWinTest.cpp
- platform/text/DateTimeFormat.cpp:
(WebCore::isASCIIAlphabetOrQuote): A helper to check special characters.
(WebCore::DateTimeFormat::quoteAndAppendLiteral):
Append the input string as is if it has no special character.
Source/WebKit/chromium:
- tests/LocaleWinTest.cpp:
(TEST_F): Update test results.
- 8:22 AM Changeset in webkit [133300] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r133075): plugins/plugin-javascript-access.html is failing
https://bugs.webkit.org/show_bug.cgi?id=101045
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-02
Reviewed by Kenneth Rohde Christiansen.
Encode the plugin filename in ArgumentCoder<PluginInfo> so that
plugin.filename returns the filename instead of name of the plugin.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
- 8:16 AM Changeset in webkit [133299] by
-
- 2 edits1 add in trunk/Tools
Output Android's device status before running tests on the bots
https://bugs.webkit.org/show_bug.cgi?id=100944
Reviewed by Dirk Pranke.
This adds a new step to the build master which will be run prior to the
actual tests-suites on the Chromium Android tester, and soon the Chromium
Android Perf bot. For each attached device, it outputs the build
information, battery level, battery temperature and username.
The Android tester currently is very flaky, and this will help tremendously
in being able to figure out what's wrong with the bot.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(OutputAndroidDeviceStatus):
(TestFactory.init):
- BuildSlaveSupport/chromium/output-android-device-status: Added.
(GetAttachedDevices):
(AndroidDeviceStatus):
(AndroidDeviceStatus.init):
(AndroidDeviceStatus._run_adb_command):
(AndroidDeviceStatus.device_type):
(AndroidDeviceStatus.device_build):
(AndroidDeviceStatus.device_fingerprint):
(AndroidDeviceStatus.battery_level):
(AndroidDeviceStatus.battery_temperature):
(AndroidDeviceStatus.username):
(main):
- 8:10 AM Changeset in webkit [133298] by
-
- 6 edits in trunk/Source
Web Inspector: NMI instrument NodeRareData::Map. It uses ~250k on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=101052
Reviewed by Yury Semikhatsky.
I noticed that in many cases cache structures are plain static HashMap, HashSet etc.
MemoryAgent can visit it but instrumentation for these containers report no objectType.
It means that addRootObject method needs to accept objectType property as an argument.
Otherwise I would have had to create a proxy class with proper objectType.
Source/WebCore:
- dom/WebCoreMemoryInstrumentation.cpp:
(WebCore::WebCoreMemoryInstrumentation::reportMemoryUsage):
(WebCore):
- dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryInstrumentation):
(WebCore):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
Source/WTF:
- wtf/MemoryInstrumentation.h:
(WTF::MemoryInstrumentation::addRootObject):
- 8:08 AM Changeset in webkit [133297] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2][AC] Wrong translation of mouse events
https://bugs.webkit.org/show_bug.cgi?id=100983
Reviewed by Kenneth Rohde Christiansen.
The transform that we build for mouse events is scaled by the scale factor.
The url bar should not be scaled, so it should be scaled in the oposite
direction to compensate for that.
- UIProcess/API/efl/ewk_view.cpp:
(toWebContentTransform):
- 7:42 AM Changeset in webkit [133296] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Add missing variable initialization in PageViewportController
Reviewed by Jocelyn Turcotte.
Updating the viewport state depends on uninitialized booleans
which it should not.
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
- 7:35 AM Changeset in webkit [133295] by
-
- 1 edit2 copies in branches/chromium/1312
Merge 132904 - [subixel] Change LineWidth::shrinkAvailableWidthForNewFloatIfNeeded to not pixel snap
https://bugs.webkit.org/show_bug.cgi?id=100742
Reviewed by Levi Weintraub.
Source/WebCore:
As we no longer pixel snap values when computing the current width for a
line we should not do it in shrinkAvailableWidthForNewFloatIfNeeded
either.
Test: fast/sub-pixel/float-wrap-zoom.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth): Remove unnecessary ifdef.
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Use float values instead of pixel snapped/floored values as the line width calculations uses floats.
LayoutTests:
Add test for wrapping when combining float and inline elements.
- fast/sub-pixel/float-wrap-zoom-expected.html: Added.
- fast/sub-pixel/float-wrap-zoom.html: Added.
TBR=eae@chromium.org
Review URL: https://codereview.chromium.org/11367059
- 7:25 AM Changeset in webkit [133294] by
-
- 3 edits1 add in trunk
[Qt][WK2] ASSERT hit for every mouse click
https://bugs.webkit.org/show_bug.cgi?id=100607
Reviewed by Jocelyn Turcotte.
.:
Added a test with a link that contains an <em> tag surrounding the entire inner text.
The test should be run on an assert enabled build and the assert should not be
triggered when tapping the link.
- ManualTests/tap-gesture-on-em-link-tap-highlight-assert.html: Added.
Source/WebCore:
Changed the logic of absolutePathForRenderer to use the first highlight box as the mid box
by uniting the two in case the mid box is empty. This allows the first box to be merged with
the last box should they intersect, and thereby prevents an ASSERT in addHighlightRect that is
triggered by two intersecting boxes being passed to addHighlightRect as separate ones.
Also, this patch removes some superfluous checks for LayoutRect::isEmpty, which is being checked
in LayoutRect::intersects already.
No new tests, but added manual test: ManualTests/tap-gesture-on-em-link-tap-highlight-assert.html
- page/GestureTapHighlighter.cpp:
- 7:07 AM Changeset in webkit [133293] by
-
- 4 edits in trunk/LayoutTests
Fix test calendar-picker-key-operations.html
https://bugs.webkit.org/show_bug.cgi?id=101020
Reviewed by Kent Tamura.
The test was wrong and failing.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
- 6:55 AM Changeset in webkit [133292] by
-
- 3 edits2 adds in trunk
Regression r130057: Improper preferred width calculation when an inline replaced object, wrapped in an inline flow, follows some text.
https://bugs.webkit.org/show_bug.cgi?id=99442
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-11-02
Reviewed by Levi Weintraub.
Source/WebCore:
Extra width is displayed after an inline replaced object that follows some
text (not ending in a whitespace) within an inline-block. This is due to
the end width (endMin) of the text object being carried forward (via inlineMin)
and added onto the next line containing the inline replaced object.
This was caused as a regression to, or rather became apparent post the fix
http://trac.webkit.org/changeset/130057 which fixed the block's preferred
width when a renderInline with width contained an inline replaced object.
Test: fast/block/block-with-inline-replaced-child-following-text.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
Introduced another flag (shouldBreakLineAfterText) which is set when
our current Text line (object) does not end in a whitespace, thereby
implying that there could be more text following, for which the end width
needs to be carried forward onto the next line.
In case the following object instead turns out to be an Inline Replaced
object, we should terminate our previous line and reset this extra width.
This is now being handled by checking for the shouldBreakLineAfterText
flag while processing Inline Replaced objects.
Once set, shouldBreakLineAfterText shall be reset only if we get another
Text object that ends in a whitespace, signifying the termination of
that text line. For all other cases, we persist with this flag through
the block's inline contents.
LayoutTests:
- fast/block/block-with-inline-replaced-child-following-text-expected.txt: Added.
- fast/block/block-with-inline-replaced-child-following-text.html: Added.
Test added for verifying the width of the inline-block when an inline replaced
object follows some text object which does not end in a whitespace.
The correct width of our containing box in this case should be 94px which is
determined by the min-width of our text (using ahem font) which is 64px +
the padding - 30px.
Prior to this fix, the trailing end-width from the text (64px) would be carried
onto the next line containing the inline replaced object. This would then make
that line's width as 64px (end width of text) + 30 px (padding) + 50px (width
of our image object) making it 144px in total. This would then incorrectly
define the width of our containing box.
- 6:52 AM Changeset in webkit [133291] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Console: remove obsolete ctrl-shift-m shortcut
https://bugs.webkit.org/show_bug.cgi?id=101036
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-02
Reviewed by Pavel Feldman.
Ctrl-shift-m on console dumps MemoryAgent.getDOMNodeCount
This functionality seems to be obsolete.
- inspector/front-end/ConsoleView.js: Removed shortcut and function.
- 6:33 AM Changeset in webkit [133290] by
-
- 3 edits in trunk/Source/WebCore
SVG classes cause layering violations in platform Font code
https://bugs.webkit.org/show_bug.cgi?id=98513
Reviewed by Eric Seidel.
Add a contained class to save and restore GlpyhPage state in FontFallbackList.
This allows us to remove the layering violation, and several methods, that
previously existed to support SVGTextRunRenderingContext.
No new tests because no change at all in functionality.
- platform/graphics/FontFallbackList.h:
(FontFallbackList):
(GlyphPagesStateSaver): New state save and restore class
(WebCore::FontFallbackList::GlyphPagesStateSaver::GlyphPagesStateSaver): Save GlyphPage state
(WebCore::FontFallbackList::GlyphPagesStateSaver::~GlyphPagesStateSaver): Restore GlyphPage state
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter): Shift to usage of the new class.
- 6:00 AM Changeset in webkit [133289] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Use MutexLocker instead of lock()/unlock().
https://bugs.webkit.org/show_bug.cgi?id=101015
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-11-02
Reviewed by Kenneth Rohde Christiansen.
Instead of lock()/unlock(), use MutexLocker in WorkQueue::performWork()
and WorkQueue::performTimerWork().
The locking scope will be more clear and simple with using MutexLocker.
- Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::performWork):
(WorkQueue::insertTimerWorkItem):
(WorkQueue::performTimerWork):
(WorkQueue::dispatchAfterDelay):
- 5:16 AM Changeset in webkit [133288] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Fix compilation errors
https://bugs.webkit.org/show_bug.cgi?id=101027
Reviewed by Yury Semikhatsky.
- inspector/InjectedScriptSource.js:
(.):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotNode.prototype._createSizeCell):
- 5:09 AM Changeset in webkit [133287] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed pixel expectations gardening.
- platform/efl/TestExpectations: Skip some css3-text-decoration
tests which depend on pending features.
- 5:09 AM Changeset in webkit [133286] by
-
- 10 edits in trunk/Source/WebCore
Only resolve attribute-derived style once per shared ElementAttributeData.
<http://webkit.org/b/100990>
Reviewed by Antti Koivisto.
Track the serialization of the "style" attribute, and the dirtiness of the presentation attribute style
on ElementAttributeData instead of in Node flags.
This allows us to avoid duplicate work for ElementAttributeData that are shared between multiple elements,
since the state is no longer per-Element.
I've left the presentation attribute cache in there for now, since it covers two additional cases:
- Elements with the same attributes in different order.
- Elements with the same presentation attributes, but with differing non-presentation attributes.
It's likely that we're not gaining much from it anymore, but that's a topic for another patch.
- dom/Node.h:
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::presentationAttributeStyle):
(WebCore::ElementAttributeData::setPresentationAttributeStyle):
(WebCore::ElementAttributeData::styleAttributeIsDirty):
(WebCore::ElementAttributeData::setStyleAttributeIsDirty):
(WebCore::ElementAttributeData::presentationAttributeStyleIsDirty):
(WebCore::ElementAttributeData::setPresentationAttributeStyleIsDirty):
(ElementAttributeData):
(WebCore::ElementAttributeData::ElementAttributeData):
- dom/Element.cpp:
(WebCore::Element::getAttribute):
- dom/Element.h:
(WebCore::Element::styleAttributeIsDirty):
(WebCore::Element::updateInvalidAttributes):
- dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
- dom/StyledElement.h:
(WebCore::StyledElement::invalidateStyleAttribute):
Move the "attribute style dirty" and "style attribute valid" node flags to ElementAttributeData
and change them to both use dirty semantics.
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::cloneDataFrom):
Share the presentation attribute style between cloned elements initially.
- dom/StyledElement.h:
(WebCore::StyledElement::presentationAttributeStyle):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::canShareStyleWithElement):
- dom/ElementAttributeData.cpp:
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::reportMemoryUsage):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
Renamed StyledElement::attributeStyle() to presentationAttributeStyle(). The old name was too
easily confused with "style attribute".
- dom/StyledElement.cpp:
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
Renamed from updateAttributeStyle().
- 5:06 AM Changeset in webkit [133285] by
-
- 2 edits in trunk/Tools
[Qt] WTR: Make sure that eventSender.mouseDown sends a press event for the second press
https://bugs.webkit.org/show_bug.cgi?id=101033
Reviewed by Simon Hausmann.
eventSender.mouseDown doesn't work properly since r133153 where
MouseButtonDblClick events aren't interpreted as Press events anymore.
The problem is that mouseDown sends a DblClick event instead of a Press,
while the correct way is to send both events.
Since QQuickWebView isn't doing anything with DblClick events anymore,
simply send Press events all the time and let WebCore figure out
where the double clicks are.
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::mouseDown):
- 4:41 AM FeatureFlags edited by
- AddDATE_AND_TIME_INPUT_TYPES (diff)
- 4:27 AM Changeset in webkit [133284] by
-
- 41 edits in trunk/Source
Introduce ENABLE_DATE_AND_TIME_INPUT_TYPES, and clarify usage of other related flags
https://bugs.webkit.org/show_bug.cgi?id=101007
Reviewed by Kentaro Hara.
Source/WebCore:
ChromeClient::openDateTimeChooser and Locale::formatDateTime are
necessary if one of date/time input types is enabled and even if
ENABLE_INPUT_MULTIPLE_FIELDS_UI is disabled. So they should be wrapped
with ENABLE(DATE_AND_TIME_INPUT_TYPES).
The following clases are used only for ChromeClient::openDateTimeChooser.
They should be wrapped with the same flag.
- class DateTimeChooser
- class DateTiemChooserClient
The following classes/functions are used for
Locale::formatDateTime. They should be wrapped with the same flag.
- Locale::dateFormat
- Locale::monthFormat
- Locale::timeFormat
- Locale::shortTimeFormat
- Locale::monthLabels
- Locale::shortMonthLabels
- Locale::standAloneMonthLabels
- Locale::shortStandAloneMonthLabels
- class DateTimeFormat
Also, we change the meaning of ENABLE_CALENDAR_PICKER. It meant
1) <input> supports calendar picker UI, and
2) WebCore/Resources/pagepopups/ is used for the calendar UI implementation.
Now ENABLE_CALENDAR_PICKER means only 2.
No new tests because of no behavior changes.
- html/BaseDateAndTimeInputType.h: This is necessary only if date/time
input types are enabled because this is a common super class of
date/time InputType classes.
- html/BaseDateAndTimeInputType.cpp: Ditto.
- html/BaseChooserOnlyDateAndTimeInputType.cpp: Ditto.
- html/BaseChooserOnlyDateAndTimeInputType.h: Ditto.
- page/ChromeClient.h: Change the flag for openDateTimeChooser, and add a comment.
- loader/EmptyClients.cpp: Follow the openDateTimeChooser flag change.
- loader/EmptyClients.h: Ditto.
- platform/DateTimeChooser.h:
This is needed only if ChromeClient::openDateTimeChooser is available.
- platform/DateTimeChooserClient.h: Ditto.
- platform/LocalizedStrings.h:
weekFormatInLDML is necessary if ENABLE(INPUT_TYPE_WEEK) regardless of
ENABLE(INPUT_MULTIPLE_FIELDS_UI).
- platform/text/PlatformLocale.h:
Change the condition for Locale::formatDateTime and the code used by
Locale::formatDateTime.
- platform/text/PlatformLocale.cpp:
(WebCore::Locale::formatDateTime):
This is necessary even if !ENABLE(INPUT_MULTIPLE_FIELDS_UI), to produce
localized representations of date/time values.
- platform/text/LocaleICU.cpp:
Change the condition for the code used by Locale::formatDateTime.
- platform/text/LocaleICU.h: Ditto.
- platform/text/LocaleNone.cpp: Ditto.
- platform/text/mac/LocaleMac.h: Ditto.
- platform/text/mac/LocaleMac.mm: Ditto.
- platform/text/win/LocaleWin.cpp: Ditto.
- platform/text/win/LocaleWin.h: Ditto.
- platform/text/DateTimeFormat.cpp: Ditto.
- platform/text/DateTimeFormat.h: Ditto.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
Remove some #if-#endif for a picker indicator element because
ENABLE_CALENDAR_PICKER meaning is changed.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp: Ditto.
- html/shadow/PickerIndicatorElement.cpp: CALENDAR_PICKER ->
INPUT_MULTIPLE_FIELDS_UI because ENABLE_CALENDAR_PICKER meaning is changed.
- html/shadow/PickerIndicatorElement.h: Ditto.
- rendering/RenderDetailsMarker.cpp: Ditto.
- rendering/RenderDetailsMarker.h: Ditto.
- rendering/RenderTheme.h: Ditto.
- rendering/RenderThemeChromiumCommon.cpp: Ditto.
- rendering/RenderThemeChromiumCommon.h: Ditto.
- rendering/RenderThemeChromiumMac.h: Ditto.
- rendering/RenderThemeChromiumSkia.h: Ditto.
Source/WebKit/chromium:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::openDateTimeChooser):
Follow the ChromeClient::openDateTimeChooser flag change.
Also, add an empty implemenatation for Android.
- src/ChromeClientImpl.h:
Follow the ChromeClient::openDateTimeChooser flag change.
- src/DateTimeChooserImpl.cpp: Wrapped with
ENABLE(INPUT_MULTIPLE_FIELDS_UI). This class is not used in Android.
- src/DateTimeChooserImpl.h: Ditto.
- src/LocalizedStrings.cpp: Follow the LocalizedString.h change.
Source/WTF:
- wtf/Platform.h:
Add ENABLE_DATE_AND_TIME_INPUT_TYPES. It's a union of
ENABLE_INPUT_TYPE_{DATE,DATETIME,DATETIMELOCAL,MONTH,TIME,WEEK}.
- 4:22 AM Changeset in webkit [133283] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Revert QCocoaNativeInterface workaround from r131720.
https://bugs.webkit.org/show_bug.cgi?id=100842
Reviewed by Simon Hausmann.
After updating Qt5 on the buildbots, the workaround
introduced in r131720 is not needed anymore.
- platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
- 3:29 AM Changeset in webkit [133282] by
-
- 12 edits2 adds in trunk/Source/WebCore
Add a common base class for date/time input types without inline editing behavior
https://bugs.webkit.org/show_bug.cgi?id=101031
Reviewed by Hajime Morita.
Add BaseChooserOnlyDateAndTimeInputType class, which will support
DateTimeChooserClient, and date/time input types inherit it if
!ENABLE(INPUT_MULTIPLE_FIELDS_UI).
No new tests. This doesn't change any behavior.
- CMakeLists.txt: Add BaseChooserOnlyDateAndTimeInputType.{cpp,h}.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- html/BaseChooserOnlyDateAndTimeInputType.cpp: Added.
- html/BaseChooserOnlyDateAndTimeInputType.h: Added.
- html/DateInputType.h: Inherit BaseChooserOnlyDateAndTimeInputType if
!ENABLE(INPUT_MULTIPLE_FIELDS_UI).
- html/DateTimeInputType.h: Ditto.
- html/DateTimeLocalInputType.h: Ditto.
- html/MonthInputType.h: Ditto.
- html/TimeInputType.h: Ditto.
- html/WeekInputType.h: Ditto.
- 3:24 AM Changeset in webkit [133281] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: [JSC] implement WorkerScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=99801
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-11-02
Reviewed by Yury Semikhatsky.
To implement Worker Inspector for JSC.
The virtual function "runEventLoopWhilePaused" is defined, since there are different ways to block
the JS running in worker-context and normal page-context.
The function "isContentScript" now is virtual because the original invoked functions are useless
and cause problem in worker-context.
In function "WebCore::WorkerScriptController::attachDebugger", we invoke "initScriptIfNeeded" to
ensure the JSGloblalObject exist in the case of attaching Debugger before executing the worker
JS code (Pause on start).
No new test case.
- bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::runEventLoopWhilePaused):
(WebCore):
- bindings/js/PageScriptDebugServer.h:
(PageScriptDebugServer):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::isContentScript):
(WebCore::ScriptDebugServer::pauseIfNeeded):
- bindings/js/ScriptDebugServer.h:
(JSC):
(ScriptDebugServer):
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::attachDebugger):
(WebCore):
(WebCore::WorkerScriptController::detachDebugger):
- bindings/js/WorkerScriptController.h:
(WorkerScriptController):
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
- bindings/js/WorkerScriptDebugServer.h:
(WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::getListenersForGlobalObject):
(WebCore::WorkerScriptDebugServer::isContentScript):
- 3:24 AM Changeset in webkit [133280] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Add HTTP authentication support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=100953
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-02
Reviewed by Kenneth Rohde Christiansen.
Add HTTP authentication support to MiniBrowser. An authentication
dialog now pops up to ask the user for credentials whenever
a Web site requires authentication.
- MiniBrowser/efl/main.c:
(auth_popup_close):
(on_auth_cancel):
(on_auth_ok):
(on_authentication_request):
(window_create):
- 2:47 AM Changeset in webkit [133279] by
-
- 2 edits in trunk/Source/WebCore
Compilation warning in Node.cpp when USERSELECT_ALL is disabled
https://bugs.webkit.org/show_bug.cgi?id=101025
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-02
Reviewed by Ryosuke Niwa.
The parameter 'treatment' is not used when USERSELECT_ALL is disabled.
- dom/Node.cpp:
(WebCore::Node::rendererIsEditable):
- 2:24 AM Changeset in webkit [133278] by
-
- 9 edits2 copies1 add in trunk/Source/WebKit2
[EFL][WK2] Common ref and unref functions for EFL WK2 objects
https://bugs.webkit.org/show_bug.cgi?id=100751
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-02
Reviewed by Kenneth Rohde Christiansen.
Added common Ewk_Object class with ref/unref API also added several aux functions for safe
Ewk_Object conversion. Used new approach on ewk_back_forward_list_item as example.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_back_forward_list.cpp:
(Ewk_Back_Forward_List::getFromCacheOrCreate):
(Ewk_Back_Forward_List::createEinaList):
- UIProcess/API/efl/ewk_back_forward_list_item.cpp:
(EwkBackForwardListItem::EwkBackForwardListItem):
(EwkBackForwardListItem::url):
(EwkBackForwardListItem::title):
(EwkBackForwardListItem::originalURL):
(ewk_back_forward_list_item_url_get):
(ewk_back_forward_list_item_title_get):
(ewk_back_forward_list_item_original_url_get):
- UIProcess/API/efl/ewk_back_forward_list_item.h:
- UIProcess/API/efl/ewk_back_forward_list_item_private.h:
(EwkBackForwardListItem):
(EwkBackForwardListItem::create):
- UIProcess/API/efl/ewk_back_forward_list_private.h:
- UIProcess/API/efl/ewk_object.cpp: Copied from Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list_item_private.h.
(ewk_object_ref):
(ewk_object_unref):
- UIProcess/API/efl/ewk_object.h: Copied from Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list_item_private.h.
- UIProcess/API/efl/ewk_object_private.h: Added.
(Ewk_Object):
(Ewk_Object::~Ewk_Object):
(ewk_object_is_of_type):
(ewk_object_cast_check):
(ewk_object_cast):
- UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
(freeEinaList):
- 2:16 AM Changeset in webkit [133277] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Middle click closes an editor and pastes selection into current editor on Linux
https://bugs.webkit.org/show_bug.cgi?id=100743
Reviewed by Alexander Pavlov.
Editor now consumes all middle mouse button mouse ups except for the ones in the main panel.
TabbedPane now consumes all middle mouse button mouse ups as well.
Navigator view does not pass focus anymore if element was selected with middle mouse button.
- inspector/front-end/DefaultTextEditor.js:
(.preventDefaultOnMouseUp):
(.consumeMouseUp):
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorSourceTreeElement.prototype.ondblclick):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.onMouseUp):
(WebInspector.TabbedPane.prototype.onMouseClick):
- 2:16 AM Changeset in webkit [133276] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][Mac][Win] Unreviewed build fix after r133182
https://bugs.webkit.org/show_bug.cgi?id=100995
Remove two methods' OVERRIDE and virtual modifiers, because they cannot be found in any base class.
Also relocate their prototypes, because they mix with the overridden ones.
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-11-02
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
- 2:11 AM Changeset in webkit [133275] by
-
- 26 edits2 adds in trunk/Source/WebCore
Web Inspector: NMI instrument ShadowRoot. It gives us ~400k on plus.google.com
https://bugs.webkit.org/show_bug.cgi?id=100866
Reviewed by Yury Semikhatsky.
Plain vanilla memory instrumentation code for HTMLInputElement which has a ElementShadow.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::reportMemoryUsage):
(WebCore):
- dom/DocumentOrderedMap.h:
(DocumentOrderedMap):
- dom/Element.cpp:
(WebCore::Element::reportMemoryUsage):
(WebCore):
- dom/Element.h:
- dom/ElementRareData.cpp: Added.
(WebCore):
(WebCore::ElementRareData::reportMemoryUsage):
- dom/ElementRareData.h:
(ElementRareData):
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::reportMemoryUsage):
(WebCore):
- dom/ElementShadow.h:
(ElementShadow):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- dom/NodeRareData.cpp: Added.
(WebCore):
(WebCore::NodeListsNodeData::reportMemoryUsage):
(WebCore::NodeRareData::reportMemoryUsage):
- dom/NodeRareData.h:
(NodeListsNodeData):
(NodeRareData):
- dom/ShadowRoot.cpp:
(WebCore):
(WebCore::ShadowRoot::reportMemoryUsage):
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/TreeScope.cpp:
(WebCore::TreeScope::reportMemoryUsage):
(WebCore):
- dom/TreeScope.h:
(TreeScope):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::reportMemoryUsage):
(WebCore):
- html/HTMLFormControlElement.h:
(HTMLFormControlElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::reportMemoryUsage):
(WebCore):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::reportMemoryUsage):
(WebCore):
- html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement):
- 2:05 AM Changeset in webkit [133274] by
-
- 7 edits7 adds in trunk/Source/WebKit2
[EFL][WK2] Add ewk_security_origin and ewk_storage_manager APIs
https://bugs.webkit.org/show_bug.cgi?id=92827
Patch by Jihye Kang <jye.kang@samsung.com> on 2012-11-02
Reviewed by Gyuyoung Kim.
Add ewk_security_origin APIs to get security origin.
These APIs will be used to get host, protocol and port of security
origin.
Add ewk_storage_manager to manage web storage and
ewk_storage_manager_origins_get to get origins list of web storage.
Add Unit tests for ewk_storage_manager and ewk_security_origin APIs.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::storageManager):
(ewk_context_storage_manager_get):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_private.h:
(Ewk_Context):
- UIProcess/API/efl/ewk_security_origin.cpp: Added.
(Ewk_Security_Origin::Ewk_Security_Origin):
(Ewk_Security_Origin::host):
(Ewk_Security_Origin::protocol):
(Ewk_Security_Origin::port):
(ewk_security_origin_ref):
(ewk_security_origin_unref):
(ewk_security_origin_host_get):
(ewk_security_origin_protocol_get):
(ewk_security_origin_port_get):
- UIProcess/API/efl/ewk_security_origin.h: Added.
- UIProcess/API/efl/ewk_security_origin_private.h: Added.
(Ewk_Security_Origin):
(Ewk_Security_Origin::create):
- UIProcess/API/efl/ewk_storage_manager.cpp: Added.
(Ewk_Storage_Manager::Ewk_Storage_Manager):
(Ewk_Storage_Manager::getStorageOrigins):
(Ewk_Storage_Manager::createOriginList):
(_Ewk_Storage_Origins_Async_Get_Context):
(_Ewk_Storage_Origins_Async_Get_Context::_Ewk_Storage_Origins_Async_Get_Context):
(getStorageOriginsCallback):
(ewk_storage_manager_origins_get):
- UIProcess/API/efl/ewk_storage_manager.h: Added.
- UIProcess/API/efl/ewk_storage_manager_private.h: Added.
(Ewk_Storage_Manager):
(Ewk_Storage_Manager::create):
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp: Added.
(getStorageOriginsCallback):
(TEST_F):
- 1:53 AM Changeset in webkit [133273] by
-
- 11 edits in trunk
Web Inspector: Cookie info in Network Resources Cookies tab shows "Invalid Date"
https://bugs.webkit.org/show_bug.cgi?id=97471
Reviewed by Pavel Feldman.
Source/WebCore:
This patch is partly based on patch by Otto Derek Cheung <otcheung@rim.com>.
Refactored CookieParser so that all cookies in front-end were WebInspector.Cookie object.
Cookie table can now show Max-Age as well as Expires attribute of a cookie.
Fixed expiresDate calculation.
Removed getters from CookieParser for better compilation.
- English.lproj/localizedStrings.js:
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.CookieRuleBase.prototype.mapResourceCookies):
(WebInspector.AuditRules.CookieSizeRule.prototype._average):
(WebInspector.AuditRules.CookieSizeRule.prototype._max):
(WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):
- inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
- inspector/front-end/CookieParser.js:
(WebInspector.CookieParser.prototype.cookies):
(WebInspector.CookieParser.prototype._flushCookie):
(WebInspector.CookieParser.prototype._addCookie):
(WebInspector.Cookie.prototype.httpOnly):
(WebInspector.Cookie.prototype.secure):
(WebInspector.Cookie.prototype.session):
(WebInspector.Cookie.prototype.path):
(WebInspector.Cookie.prototype.domain):
(WebInspector.Cookie.prototype.expires):
(WebInspector.Cookie.prototype.maxAge):
(WebInspector.Cookie.prototype.size):
(WebInspector.Cookie.prototype.setSize):
(WebInspector.Cookie.prototype.expiresDate):
(WebInspector.Cookie.prototype.attributes):
(WebInspector.Cookies.getCookiesAsync):
(WebInspector.Cookies.buildCookiesFromString):
(WebInspector.Cookies.buildCookieProtocolObject):
(WebInspector.Cookies.cookieMatchesResourceURL):
(WebInspector.Cookies.cookieDomainMatchesResourceDomain):
- inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable):
(WebInspector.CookiesTable.prototype._totalSize):
(WebInspector.CookiesTable.prototype._sortCookies.expiresCompare):
(WebInspector.CookiesTable.prototype._sortCookies):
(WebInspector.CookiesTable.prototype._createGridNode):
- inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype._buildCookie):
LayoutTests:
- http/tests/inspector/resource-main-cookies.php:
- inspector/cookie-parser.html:
- 1:06 AM Changeset in webkit [133272] by
-
- 6 edits in trunk
Memory instrumentation: do not call checkCountedObject with wrong pointers
https://bugs.webkit.org/show_bug.cgi?id=100958
Reviewed by Alexander Pavlov.
Source/WebCore:
Removed redundant call to checkCountedObject.
- inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::countObjectSize):
Source/WTF:
Removed calls to checkCountedObject from places where the pointer may contain
an address of a base class which may differ from the actual object pointer. Instead
checkCountedObject is only called right after processing deferred pointer where
we know real address.
- wtf/MemoryInstrumentation.h:
(WTF::MemoryInstrumentation::addObjectImpl):
(WTF::::process):
Tools:
- TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: test that if there
if there is class A derived from classes B and C and we have pointer B* to an
object of class A then MemoryInstrumentationClient::checkoutCountedObject won't
be called for B* but only for A*
Also MemoryInstrumentation implementation used in the test was refactored to
allow passing client as a parameter. The client implementation was extracted into
a top-level class MemoryInstrumentationTestClient.
- 12:54 AM Changeset in webkit [133271] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: a small defect in "WorkersSidebarPanel.js"
https://bugs.webkit.org/show_bug.cgi?id=101022
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-11-02
Reviewed by Yury Semikhatsky.
In "autoattachToWorkersClicked", the "event.target.checked" doesn't alwyas valid, since the
"event.target" might be a label.
The problem just causes an error report, doesn't effect function, so no new test case.
- inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane.prototype._autoattachToWorkersClicked):
- 12:22 AM Changeset in webkit [133270] by
-
- 14 edits in trunk/Source/WebKit2
Coordinated Graphics: Manage the lifecycle of shareable surfaces precisely.
https://bugs.webkit.org/show_bug.cgi?id=100797
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-02
Reviewed by Noam Rosenthal.
Internal Review by Gwang Yoon Hwang and Jae Hyun Park.
This patch makes UpdateAtlas manage the lifecycle of shareable surfaces
containing the updates in the way how CoordinatedTile manages the lifecycle of
tiles. Currently, UI Process creates the shareable surface when receiving an
UpdateTileForLayer message, but there is no exact point to remove the shareable
surface. Now, we introduce new two messages to handle the lifecycle:
CreateUpdateAtlas and RemoveUpdateAtlas.
This patch gives us two benefits.
- Reduce file and mmap operations. Web Process does not need to duplicate a
file handle every tile update. UI Process does not need to create a
ShareableSurface every UpdateTileForLayer message.
- Save memory. We can remove a ShareableSurface in UI Process when UpdateAtlas
in Web Process is removed.
- Shared/SurfaceUpdateInfo.cpp:
(WebKit::SurfaceUpdateInfo::encode):
(WebKit::SurfaceUpdateInfo::decode):
- Shared/SurfaceUpdateInfo.h:
(SurfaceUpdateInfo):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::createUpdateAtlas):
(WebKit):
(WebKit::LayerTreeCoordinatorProxy::removeUpdateAtlas):
(WebKit::LayerTreeCoordinatorProxy::purgeBackingStores):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:
(WebKit::CoordinatedTile::updateBackBuffer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:
(CoordinatedTileClient):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::createUpdateAtlas):
(WebKit):
(WebKit::LayerTreeCoordinator::removeUpdateAtlas):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
- WebProcess/WebPage/UpdateAtlas.h:
(UpdateAtlasClient):
(WebKit):
(UpdateAtlas):
- 12:15 AM Changeset in webkit [133269] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Remove redundant internal function
https://bugs.webkit.org/show_bug.cgi?id=100969
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-02
Reviewed by Gyuyoung Kim.
Remove ewk_view_text_found() in ewk_view.cpp which is not used anymore.
Now, "text,found" signal is emitted by DECLARE_EWK_VIEW_CALLBACK(TextFound, "text,found", unsigned)
in EwkViewCallback.h
- UIProcess/API/efl/ewk_view.cpp:
Nov 1, 2012:
- 11:35 PM Changeset in webkit [133268] by
-
- 6 edits2 adds in trunk
[Shadow] Element should have getter and setter of attribute 'pseudo'
https://bugs.webkit.org/show_bug.cgi?id=100831
Reviewed by Hajime Morita.
Source/WebCore:
We expose 'pseudo' attribute in Element. When nothing is assigned to 'pseudo', it should return null.
Test: fast/dom/shadow/pseudo-attribute.html
- dom/Element.cpp:
(WebCore::Element::pseudo):
(WebCore):
(WebCore::Element::setPseudo):
- dom/Element.h:
(Element):
- dom/Element.idl:
- html/HTMLAttributeNames.in:
LayoutTests:
- fast/dom/shadow/pseudo-attribute-expected.txt: Added.
- fast/dom/shadow/pseudo-attribute.html: Added.
- 11:29 PM Changeset in webkit [133267] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Make File Chooser dialog modal in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=100962
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-01
Reviewed by Gyuyoung Kim.
Make File Chooser dialog modal in MiniBrowser and make
sure it is closed and freed when its parent window is
closed.
- MiniBrowser/efl/main.c:
(close_file_picker):
(on_filepicker_parent_deletion):
(on_file_chooser_request):
- 10:54 PM Changeset in webkit [133266] by
-
- 11 edits in trunk
[EFL][DRT] Support Geolocation
https://bugs.webkit.org/show_bug.cgi?id=97427
Source/WebKit:
Patch by Seonae Kim <sunaeluv.kim@samsung.com> on 2012-11-01
Reviewed by Gyuyoung Kim.
Add a mock directory to use GeolocationClientMock in DumpRenderTree.
- PlatformEfl.cmake:
Source/WebKit/efl:
Patch by Seonae Kim <sunaeluv.kim@samsung.com> on 2012-11-01
Reviewed by Gyuyoung Kim.
Implement methods to use GeolocationClientMock in DumpRenderTree.
This client attaches to the page whenever a view is created.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::attachClientToPage):
(DumpRenderTreeSupportEfl::resetGeolocationClientMock):
(DumpRenderTreeSupportEfl::setMockGeolocationPermission):
(DumpRenderTreeSupportEfl::setMockGeolocationPosition):
(DumpRenderTreeSupportEfl::setMockGeolocationPositionUnavailableError):
(DumpRenderTreeSupportEfl::numberOfPendingGeolocationPermissionRequests):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Patch by Seonae Kim <sunaeluv.kim@samsung.com> on 2012-11-01
Reviewed by Gyuyoung Kim.
Implement methods to use GeolocationClientMock in DumpRenderTree.
This client attaches to the page whenever a view is created.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::setMockGeolocationPosition):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setGeolocationPermission):
(TestRunner::numberOfPendingGeolocationPermissionRequests):
LayoutTests:
Patch by Seonae Kim <sunaeluv.kim@samsung.com> on 2012-11-01
Reviewed by Gyuyoung Kim.
Change the comment of Geolocation test cases.
- platform/efl/TestExpectations:
- 9:41 PM Changeset in webkit [133265] by
-
- 2 edits in trunk/Source/JavaScriptCore
A llint workaround for a toolchain issue.
https://bugs.webkit.org/show_bug.cgi?id=101012.
Reviewed by Michael Saboff.
- llint/LowLevelInterpreter.asm:
- use a local label to workaround the toolchain issue with undeclared global labels.
- 8:09 PM Changeset in webkit [133264] by
-
- 100 edits in trunk/LayoutTests
New image results for compositing tests. Cross-platform image results seem
impossible to maintain, so these are all Mac-specific.
- platform/mac/compositing/animation/busy-indicator-expected.png:
- platform/mac/compositing/animation/state-at-end-event-transform-layer-expected.png:
- platform/mac/compositing/color-matching/image-color-matching-expected.png:
- platform/mac/compositing/color-matching/pdf-image-match-expected.png:
- platform/mac/compositing/compositing-visible-descendant-expected.png:
- platform/mac/compositing/direct-image-compositing-expected.png:
- platform/mac/compositing/flat-with-transformed-child-expected.png:
- platform/mac/compositing/framesets/composited-frame-alignment-expected.png:
- platform/mac/compositing/generated-content-expected.png:
- platform/mac/compositing/geometry/abs-position-inside-opacity-expected.png:
- platform/mac/compositing/geometry/clipping-foreground-expected.png:
- platform/mac/compositing/geometry/composited-html-size-expected.png:
- platform/mac/compositing/geometry/fixed-in-composited-expected.png:
- platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
- platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
- platform/mac/compositing/geometry/fixed-position-expected.png:
- platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
- platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
- platform/mac/compositing/geometry/foreground-layer-expected.png:
- platform/mac/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/mac/compositing/geometry/layer-due-to-layer-children-expected.png:
- platform/mac/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png:
- platform/mac/compositing/geometry/outline-change-expected.png:
- platform/mac/compositing/geometry/partial-layout-update-expected.png:
- platform/mac/compositing/geometry/repaint-foreground-layer-expected.png:
- platform/mac/compositing/geometry/root-layer-update-expected.png:
- platform/mac/compositing/geometry/tall-page-composited-expected.png:
- platform/mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png:
- platform/mac/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/mac/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/mac/compositing/geometry/video-opacity-overlay-expected.png:
- platform/mac/compositing/iframes/composited-iframe-alignment-expected.png:
- platform/mac/compositing/iframes/iframe-copy-on-scroll-expected.png:
- platform/mac/compositing/iframes/iframe-in-composited-layer-expected.png:
- platform/mac/compositing/images/content-image-change-expected.png:
- platform/mac/compositing/images/direct-image-background-color-expected.png:
- platform/mac/compositing/layer-creation/fixed-position-scroll-expected.png:
- platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png:
- platform/mac/compositing/layers-inside-overflow-scroll-expected.png:
- platform/mac/compositing/masks/direct-image-mask-expected.png:
- platform/mac/compositing/masks/masked-ancestor-expected.png:
- platform/mac/compositing/masks/multiple-masks-expected.png:
- platform/mac/compositing/masks/simple-composited-mask-expected.png:
- platform/mac/compositing/overflow/ancestor-overflow-expected.png:
- platform/mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/mac/compositing/overflow/overflow-compositing-descendant-expected.png:
- platform/mac/compositing/overflow/overflow-positioning-expected.png:
- platform/mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png:
- platform/mac/compositing/overflow/overflow-scroll-expected.png:
- platform/mac/compositing/overflow/parent-overflow-expected.png:
- platform/mac/compositing/overflow/scroll-ancestor-update-expected.png:
- platform/mac/compositing/overflow/scrollbar-painting-expected.png:
- platform/mac/compositing/overflow/theme-affects-visual-overflow-expected.png:
- platform/mac/compositing/plugins/composited-plugin-expected.png:
- platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
- platform/mac/compositing/reflections/compositing-change-inside-reflection-expected.png:
- platform/mac/compositing/reflections/deeply-nested-reflections-expected.png:
- platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
- platform/mac/compositing/reflections/masked-reflection-on-composited-expected.png:
- platform/mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
- platform/mac/compositing/reflections/nested-reflection-expected.png:
- platform/mac/compositing/reflections/nested-reflection-mask-change-expected.png:
- platform/mac/compositing/reflections/nested-reflection-on-overflow-expected.png:
- platform/mac/compositing/reflections/nested-reflection-opacity-expected.png:
- platform/mac/compositing/reflections/nested-reflection-size-change-expected.png:
- platform/mac/compositing/reflections/nested-reflection-transformed-expected.png:
- platform/mac/compositing/reflections/nested-reflection-transformed2-expected.png:
- platform/mac/compositing/reflections/nested-reflection-transition-expected.png:
- platform/mac/compositing/reflections/reflection-in-composited-expected.png:
- platform/mac/compositing/reflections/reflection-on-composited-expected.png:
- platform/mac/compositing/reflections/reflection-opacity-expected.png:
- platform/mac/compositing/reflections/reflection-ordering-expected.png:
- platform/mac/compositing/reflections/reflection-positioning-expected.png:
- platform/mac/compositing/reflections/reflection-positioning2-expected.png:
- platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
- platform/mac/compositing/reflections/transform-inside-reflection-expected.png:
- platform/mac/compositing/repaint/become-overlay-composited-layer-expected.png:
- platform/mac/compositing/repaint/composited-document-element-expected.png:
- platform/mac/compositing/repaint/content-into-overflow-expected.png:
- platform/mac/compositing/repaint/layer-repaint-expected.png:
- platform/mac/compositing/repaint/layer-repaint-rects-expected.png:
- platform/mac/compositing/repaint/opacity-between-absolute-expected.png:
- platform/mac/compositing/repaint/opacity-between-absolute2-expected.png:
- platform/mac/compositing/repaint/overflow-into-content-expected.png:
- platform/mac/compositing/repaint/same-size-invalidation-expected.png:
- platform/mac/compositing/scaling/tiled-layer-recursion-expected.png:
- platform/mac/compositing/self-painting-layers-expected.png:
- platform/mac/compositing/shadows/shadow-drawing-expected.png:
- platform/mac/compositing/sibling-positioning-expected.png:
- platform/mac/compositing/text-on-large-layer-expected.png:
- platform/mac/compositing/transitions/scale-transition-no-start-expected.png:
- platform/mac/compositing/transitions/singular-scale-transition-expected.png:
- platform/mac/compositing/webgl/webgl-background-color-expected.png:
- platform/mac/compositing/webgl/webgl-no-alpha-expected.png:
- platform/mac/compositing/webgl/webgl-reflection-expected.png:
- 8:00 PM Changeset in webkit [133263] by
-
- 9 edits in trunk/LayoutTests
Rebaseline some MathML results, and mark compositing/iframes/overlapped-nested-iframes.html
as flakey because it is.
- platform/mac/TestExpectations:
- platform/mac/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.png:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.png:
- platform/mac/mathml/presentation/subsup-expected.txt:
- platform/mac/mathml/presentation/tables-expected.png:
- platform/mac/mathml/presentation/tables-expected.txt:
- 7:53 PM Changeset in webkit [133262] by
-
- 3 edits in trunk/Source/WebCore
Build fix. http://trac.webkit.org/changeset/133252 broke the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=101008
Reviewed by fischman@chromium.org.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::clearMediaPlayer):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- 7:50 PM Changeset in webkit [133261] by
-
- 1 edit1 move4 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/TestExpectations:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
- platform/efl-wk1/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png.
- 7:44 PM Changeset in webkit [133260] by
-
- 3 edits in trunk/Tools
Remove tests no longer needed after r133229.
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTestFactory.test_inspector_test):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests_with_skipped_list):
- 7:42 PM Changeset in webkit [133259] by
-
- 2 edits12 adds in trunk/LayoutTests
Unreviewed mathml rebaseline.
- platform/chromium-linux-x86/mathml: Added.
- platform/chromium-linux-x86/mathml/xHeight-expected.png: Added.
- platform/chromium-linux-x86/mathml/xHeight-expected.txt: Added.
- platform/chromium-linux/mathml: Added.
- platform/chromium-linux/mathml/xHeight-expected.png: Added.
- platform/chromium-linux/mathml/xHeight-expected.txt: Added.
- platform/chromium-win-xp/mathml: Added.
- platform/chromium-win-xp/mathml/xHeight-expected.png: Added.
- platform/chromium-win-xp/mathml/xHeight-expected.txt: Added.
- platform/chromium-win/mathml: Added.
- platform/chromium-win/mathml/xHeight-expected.png: Added.
- platform/chromium-win/mathml/xHeight-expected.txt: Added.
- platform/chromium/TestExpectations:
- 7:32 PM Changeset in webkit [133258] by
-
- 3 edits2 copies in branches/chromium/1312
Merge 132985 - F4 inside <input type=time> should not open calendar picker
https://bugs.webkit.org/show_bug.cgi?id=100730
Reviewed by Kent Tamura.
Source/WebCore:
We lacked the check to see if the picker indicator is visible.
Test: fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings.html
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleKeydownEvent): Check if picker indicator is visible.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings.html: Added.
TBR=keishi@webkit.org
Review URL: https://codereview.chromium.org/11369041
- 7:22 PM Changeset in webkit [133257] by
-
- 8 edits in branches/chromium/1312
Merge 133011 - Calendar picker can flicker when opened from the suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=100816
Reviewed by Kent Tamura.
Source/WebCore:
Calendar picker was opening before the hiding completed.
No new tests. Added test to date-suggestion-picker-key-operations.html.
- Resources/pagepopups/pickerCommon.js: Added didHide event.
- Resources/pagepopups/suggestionPicker.js:
(SuggestionPicker.prototype.selectEntry): Use didHide event so we don't open the calendar picker prematurely.
(SuggestionPicker._handleWindowDidHide): When the window finished hiding, open the calendar picker.
LayoutTests:
- fast/forms/resources/picker-common.js:
(openPicker): Fix mistake.
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html: Test that didHide event fires after the entry was selected and before the calendar picker opened.
TBR=keishi@webkit.org
Review URL: https://codereview.chromium.org/11364040
- 6:59 PM Changeset in webkit [133256] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r133244.
http://trac.webkit.org/changeset/133244
https://bugs.webkit.org/show_bug.cgi?id=100973
Broke Chromium Mac (clang) builds.
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::DOMNodeWrapperMap::weakCallback):
- 6:43 PM Changeset in webkit [133255] by
-
- 5 edits in trunk/Source/JavaScriptCore
Remove GlobalObject constant register that is typically unused
https://bugs.webkit.org/show_bug.cgi?id=101005
Reviewed by Geoffrey Garen.
The GlobalObject constant register is frequently allocated even when it
is not used, it is also getting in the way of some other optimisations.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseResolveOperations):
- 6:42 PM Changeset in webkit [133254] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening. Mark another flaky test.
- platform/chromium/TestExpectations:
- 6:40 PM Changeset in webkit [133253] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Simplify the code of returning JSValue in "BlackBerry::WebKit::WebPagePrivate::executeJavaScript"
https://bugs.webkit.org/show_bug.cgi?id=100941
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-11-01
Reviewed by Yong Li.
Remove the unnecessary steps, just directly deal with returned JSValue.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
(BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
- 6:38 PM Changeset in webkit [133252] by
-
- 4 edits1 add in trunk
HTMLMediaPlayer should free m_player when src is set/changed
https://bugs.webkit.org/show_bug.cgi?id=99647
Reviewed by Eric Carlson.
.:
- ManualTests/media-players-are-dropped-on-error.html: Added.
Various scenarios are tested to make sure players aren't
leaked in different ways for each of them.
Source/WebCore:
New ManualTest added; manual since leaking media players doesn't have layoutTestController-visible effects.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): clearMediaPlayer() when src is set/changed
(WebCore::HTMLMediaElement::userCancelledLoad): use new clearMediaPlayer() helper
(WebCore::HTMLMediaElement::clearMediaPlayer): clear m_player and associated timers/flags
(WebCore):
(WebCore::HTMLMediaElement::createMediaPlayer): whitespace-only change
- html/HTMLMediaElement.h: new method: createMediaPlayer().
(HTMLMediaElement):
- 6:36 PM Changeset in webkit [133251] by
-
- 4 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- 6:23 PM Changeset in webkit [133250] by
-
- 2 edits in trunk/Source/WebKit2
Reformat the annotationStyle initializer to appease update-webkit-localizable-strings.
Rubber-stamped by Dan Bernstein.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
- 6:22 PM Changeset in webkit [133249] by
-
- 3 edits6 adds in trunk
XSS blocker false positive when page contains <iframe src="">
https://bugs.webkit.org/show_bug.cgi?id=93416
Reviewed by Adam Barth.
Source/WebCore:
Treat src="" and src="about:blank" as safe resources even if they appear
in the query parameters.
Tests: http/tests/security/xssAuditor/iframe-injection-allowed-2.html
http/tests/security/xssAuditor/iframe-injection-allowed-3.html
http/tests/security/xssAuditor/iframe-injection-allowed.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::isLikelySafeResource):
LayoutTests:
- http/tests/security/xssAuditor/iframe-injection-allowed-2-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-injection-allowed-2.html: Added.
- http/tests/security/xssAuditor/iframe-injection-allowed-3-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-injection-allowed-3.html: Added.
- http/tests/security/xssAuditor/iframe-injection-allowed-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-injection-allowed.html: Added.
- 6:19 PM Changeset in webkit [133248] by
-
- 3 edits2 adds in trunk
Fix assertion failure in RenderGeometryMap::absoluteRect when frame scale != 1.0
https://bugs.webkit.org/show_bug.cgi?id=100912
Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-01
Reviewed by Simon Fraser.
Frame scale will add transformation to RenderView, so fixed position doesn't
get propagated up to the viewport by RenderGeometryMap. This is handled
correctly in RenderView::mapLocalToContainer, causing the assertion to fail.
This patch corrects RenderGeometryMap::mapToAbsolute to handle the RenderView
transformation case.
A layout test is added to catch this issue. The test will crash debug build
without this patch.
Source/WebCore:
Test: compositing/geometry/fixed-position-composited-page-scale-scroll.html
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToAbsolute):
LayoutTests:
- compositing/geometry/fixed-position-composited-page-scale-scroll-expected.txt: Added.
- compositing/geometry/fixed-position-composited-page-scale-scroll.html: Added.
- 6:17 PM Changeset in webkit [133247] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add a prompt to enable global location services
https://bugs.webkit.org/show_bug.cgi?id=100992
PR 227897
Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-01
Reviewed by Rob Buis.
Adding a dialog to let the user know location services isn't enabled.
Currently, the browser app does not check whether the global setting for
location service is enabled. This patch adds a dialog to allow the user
to open the settings app and change that setting. This infobar will only
show once per session. If the user fails to turn on location services after
the first prompt, all geolocation requests will automatically fail.
Also, adapting GeolocationClientBlackBerry to the removal of GeoTracker.
The class now talks directly to the geo handler singleton.
- Api/WebPageClient.h:
- WebCoreSupport/GeolocationClientBlackBerry.cpp:
(GeolocationClientBlackBerry::GeolocationClientBlackBerry):
(GeolocationClientBlackBerry::geolocationDestroyed):
(GeolocationClientBlackBerry::startUpdating):
(GeolocationClientBlackBerry::stopUpdating):
(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::setEnableHighAccuracy):
- WebCoreSupport/GeolocationClientBlackBerry.h:
(WebCore::GeolocationClientBlackBerry::requiresHighAccuracy):
(GeolocationClientBlackBerry):
- 5:59 PM Changeset in webkit [133246] by
-
- 2 edits in trunk/Tools
[chromium] Try to find ninja if it's not in the path already
https://bugs.webkit.org/show_bug.cgi?id=100988
Reviewed by Ryosuke Niwa.
Similar to the gclient detection logic in update-webkit-chromium
- Scripts/webkitdirs.pm:
(buildChromiumNinja):
- 5:41 PM Changeset in webkit [133245] by
-
- 2884 edits222 adds18 deletes in trunk/LayoutTests
Rebaseline tests listed in Mac TestExpectations as needing new baselines, other than those that
are failing ref tests.
Removed relevant lines from TestExpectations.
Carry along some new image results for the directories which were rebaselined.
Rubber-stamped by Tim Horton
- 5:24 PM Changeset in webkit [133244] by
-
- 3 edits in trunk/Source/WebCore
[V8] Generalize NodeWrapperMap to be able to handle other sorts of keys
https://bugs.webkit.org/show_bug.cgi?id=100973
Reviewed by Kentaro Hara.
This is the first step towards using intrusive DOM wrapper maps more
widely in WebCore (see
http://lists.webkit.org/pipermail/webkit-dev/2012-November/022686.html
for more context).
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore):
(WebCore::IntrusiveDOMWrapperMap::weakCallback):
- 5:07 PM Changeset in webkit [133243] by
-
- 2 edits in trunk/Tools
Add Glenn Adams to the Contributor list
https://bugs.webkit.org/show_bug.cgi?id=100982
Reviewed by Adam Barth.
I CC him enough on bugs it would help me to have him listed here.
- Scripts/webkitpy/common/config/committers.py:
- 5:03 PM Changeset in webkit [133242] by
-
- 6 edits in trunk/Source/WebCore
[CSS Shaders] CustomFilterOperation should be converted to ValidatedCustomFilterOperation before using it
https://bugs.webkit.org/show_bug.cgi?id=100533
Reviewed by Dean Jackson.
Added the code that converts a CustomFilterOperation to a ValidatedCustomFilterOperation.
Both the software path and the composited one will use this operation instead. There will be
no need to check the shader in platform code anymore.
No new tests, already covered by existing custom filter tests.
- platform/graphics/filters/ValidatedCustomFilterOperation.cpp:
(WebCore::ValidatedCustomFilterOperation::ValidatedCustomFilterOperation):
- platform/graphics/filters/ValidatedCustomFilterOperation.h:
(WebCore):
(WebCore::ValidatedCustomFilterOperation::create):
(ValidatedCustomFilterOperation):
(WebCore::ValidatedCustomFilterOperation::validatedProgram):
(WebCore::ValidatedCustomFilterOperation::parameters):
(WebCore::ValidatedCustomFilterOperation::meshRows):
(WebCore::ValidatedCustomFilterOperation::meshColumns):
(WebCore::ValidatedCustomFilterOperation::meshType):
(WebCore::ValidatedCustomFilterOperation::operator==):
- rendering/FilterEffectRenderer.cpp:
(WebCore::createCustomFilterEffect):
(WebCore::FilterEffectRenderer::build):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::ensureBacking):
(WebCore::RenderLayer::clearBacking):
(WebCore::RenderLayer::styleChanged): updateOrRemoveFilterClients needs to be called before the composited
layer is updated. Otherwise the composited layer will never see a loaded filter in the first call.
(WebCore):
(WebCore::RenderLayer::isCSSCustomFilterEnabled):
(WebCore::RenderLayer::computeFilterOperations):
(WebCore::RenderLayer::updateOrRemoveFilterClients): Split updateOrRemoveFilterEffect into 2 functions.
This one is supposed to add the clients needed to load network resources.
(WebCore::RenderLayer::updateOrRemoveFilterEffectRenderer): Figures out if a software fallback is needed
and creates a FilterEffectRenderer.
- rendering/RenderLayer.h:
(RenderLayer):
- 4:58 PM Changeset in webkit [133241] by
-
- 7 edits4 adds in trunk
[CSS Shaders] Get rid of internal tex coord attribute
https://bugs.webkit.org/show_bug.cgi?id=94358
Patch by Max Vujovic <mvujovic@adobe.com> on 2012-11-01
Reviewed by Dean Jackson.
Source/WebCore:
Remove the internal css_a_texCoord attribute that WebKit added to shaders in order to
sample the element texture by texture coordinate.
Now, the WebKit-added sampling code can leverage a_texCoord if the author defined it, or
WebKit can add its own a_texCoord definition to the author's shader.
Note that vertex attributes are read-only in GLSL. Also, note that we already reject the
shader if the author did not define a_texCoord with the correct type. Essentially, if
a_texCoord exists in the author's validated shader, we are guaranteed that it's the correct
type and that its value is unmodified.
Test: css3/filters/custom/custom-filter-a-tex-coord-optional.html
- platform/graphics/filters/CustomFilterCompiledProgram.cpp:
(WebCore::CustomFilterCompiledProgram::CustomFilterCompiledProgram):
Remove the references to m_internalTexCoordAttribLocation.
(WebCore::CustomFilterCompiledProgram::initializeParameterLocations): Ditto.
- platform/graphics/filters/CustomFilterCompiledProgram.h: Ditto.
- platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::bindProgramAndBuffers): Ditto.
(WebCore::CustomFilterRenderer::unbindVertexAttributes): Ditto.
- platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):
Pass the set of symbols found in the author's shaders to the rewriteMixVertexShader
method.
(WebCore::CustomFilterValidatedProgram::rewriteMixVertexShader):
If the author didn't define a_texCoord, add it to the end of the author's vertex
shader, but before the shader's new main function. As before, the new main function
will pass the texture coordinate to the fragment shader via the css_v_texCoord varying.
- platform/graphics/filters/CustomFilterValidatedProgram.h:
(WebCore):
Add a forward declaration for ANGLEShaderSymbol.
(CustomFilterValidatedProgram):
Update the method prototype for rewriteMixVertexShader.
LayoutTests:
Add a test which verifies that a custom filter executes regardless of whether the author
defines a_texCoord in the vertex shader. We check this because the implementation uses
the author's a_texCoord definition if it exists. If it doesn't exist, the implementation
adds its own a_texCoord definition to the author's shader.
- css3/filters/custom/custom-filter-a-tex-coord-optional-expected.html: Added.
- css3/filters/custom/custom-filter-a-tex-coord-optional.html: Added.
- css3/filters/resources/a-tex-coord-defined.vs: Added.
- css3/filters/resources/a-tex-coord-undefined.vs: Added.
- 4:36 PM Changeset in webkit [133240] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Suppressing an image failure after
r133224.
- platform/chromium/TestExpectations:
- 4:23 PM Changeset in webkit [133239] by
-
- 3 edits in trunk/Source/WebCore
Ensure that AudioNode deletion is synchronized with a stable state of the rendering graph
https://bugs.webkit.org/show_bug.cgi?id=100994
Reviewed by Kenneth Russell.
In some rare cases it has been observed that nodes are getting deleted in the main thread
during an audio rendering quantum where the dirty inputs and outputs have not yet been cleaned
via calls to handleDirtyAudioSummingJunctions() and handleDirtyAudioNodeOutputs().
This was possible because nodes marked for deletion with markForDeletion() could be picked
up in a subsequent call to deleteMarkedNodes() before the render quantum has finished and
handlePostRenderTasks() has had a chance to reconcile these marked nodes and clean the dirty state.
The solution is to manage the marked nodes in a separate vector which only gets copied to another
vector truly eligible for deletion which is synchronized in handlePostRenderTasks().
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::markForDeletion):
(WebCore::AudioContext::scheduleNodeDeletion):
(WebCore::AudioContext::deleteMarkedNodes):
- Modules/webaudio/AudioContext.h:
(AudioContext):
- 3:58 PM Changeset in webkit [133238] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r133224 as suggested by Enrica.
Confirmed the test failures go away on Chromium Mac locally.
- page/EventHandler.cpp:
(WebCore::EventHandler::updateSelectionForMouseDrag):
- 3:58 PM Changeset in webkit [133237] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html.
It is inherently flaky: https://bugs.webkit.org/show_bug.cgi?id=100117
- platform/win/TestExpectations:
- 3:51 PM Changeset in webkit [133236] by
-
- 6 edits2 copies in branches/safari-536.28-branch
Merged r124491. <rdar://problem/12536449>
- 3:45 PM Changeset in webkit [133235] by
-
- 4 edits2 copies1 add in branches/safari-536.28-branch
Merged r124258. <rdar://problem/12536444>
- 3:33 PM Changeset in webkit [133234] by
-
- 2 edits in trunk/Tools
Add Python-LLDB support for WTF::Vector types.
https://bugs.webkit.org/show_bug.cgi?id=100980
Reviewed by Anders Carlsson.
Add a synthetic child provider for WTF::Vector types.
- lldb/lldb_webkit.py:
(lldb_init_module): Add both the summary and synthetic providers for WTF::Vector
(WTFVector_SummaryProvider): Wrapper around WTFVectorProvider
(WTFVectorProvider):
(WTFVectorProvider.init):
(WTFVectorProvider.num_children): Return m_size+2 children to account for synthesized children.
(WTFVectorProvider.get_child_index): Synthesize child indexes for each entry in the Vector.
(WTFVectorProvider.get_child_at_index): Synthesize children for each entry in the Vector.
(WTFVectorProvider.update): Retrieve state from the underlying Vector.
(WTFVectorProvider.has_children): Vectors always have children.
- 3:29 PM Changeset in webkit [133233] by
-
- 14 edits in trunk/Source
Rename HAVE(NETWORK_CFDATA_ARRAY_CALLBACK) to USE(NETWORK_CFDATA_ARRAY_CALLBACK)
Rubber-stamped by Joe Pecoraro.
All CFNetwork based platforms have this now, but not all use it at the moment.
- loader/ResourceLoader.h:
- loader/SubresourceLoader.h:
- loader/cf/SubresourceLoaderCF.cpp:
- loader/mac/ResourceLoaderMac.mm:
- platform/SharedBuffer.cpp: (WebCore::SharedBuffer::clear): (WebCore::SharedBuffer::buffer): (WebCore::SharedBuffer::getSomeData):
- platform/SharedBuffer.h:
- platform/cf/SharedBufferCF.cpp:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.h: (ResourceHandleClient):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willCacheResponse): (WebCore::ResourceHandle::createCFURLConnection):
- platform/network/mac/ResourceHandleMac.mm:
- 3:26 PM Changeset in webkit [133232] by
-
- 7 edits in trunk/Source
Fix HAVE(NETWORK_CFDATA_ARRAY_CALLBACK) build
https://bugs.webkit.org/show_bug.cgi?id=100979
Reviewed by Joseph Pecoraro.
- loader/ResourceBuffer.cpp: (WebCore::ResourceBuffer::append):
- loader/ResourceBuffer.h: Added a version of append() that takes CFDataRef, passing it directly to SharedBuffer.
- loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didReceiveDataArray): InspectorInstrumentation now takes a length. Unfortunately, we don't have encodedLength here, meaning that the results will likely be incorrect.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willCacheResponse): Removed a version that needlessly used deprecated API. (WebCore::ResourceHandle::createCFURLConnection): This code assumed that HAVE(NETWORK_CFDATA_ARRAY_CALLBACK) and USE(PROTECTION_SPACE_AUTH_CALLBACK) always come together. Changed to check for these separately.
- 3:23 PM Changeset in webkit [133231] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r124156. <rdar://problem/12536490>
- 3:18 PM Changeset in webkit [133230] by
-
- 2 edits in branches/safari-536.28-branch/Source/WebCore
Merged r124089. <rdar://problem/12536443>
- 2:59 PM Changeset in webkit [133229] by
-
- 2 edits in trunk/Tools
Remove PageLoad directory entry from PerformanceTests pattern_map
https://bugs.webkit.org/show_bug.cgi?id=100989
Reviewed by Ryosuke Niwa.
Since we removed PageLoad directory from PerformanceTests we don't need this entry in pattern_map.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTestFactory):
- 2:59 PM Changeset in webkit [133228] by
-
- 3 edits3 adds in trunk
[BlackBerry] Add more form validation strings
https://bugs.webkit.org/show_bug.cgi?id=100978
Reviewed by Yong Li.
PR 210072
Source/WebCore:
Implement these two methods properly.
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::validationMessageRangeUnderflowText):
(WebCore::validationMessageRangeOverflowText):
LayoutTests:
Add the result we expect after adding translations for range over and underflow.
- platform/blackberry/fast/forms/number/number-validation-message-expected.txt: Added.
- 2:48 PM Changeset in webkit [133227] by
-
- 14 edits in trunk/Source
[CSS Shaders] Move MeshBoxType out of CustomFilterOperation
https://bugs.webkit.org/show_bug.cgi?id=100782
Reviewed by Dean Jackson.
Source/WebCore:
Moved CustomFilter::MeshBoxType enum to the CustomFilterConstants.h file and renamed it to CustomFilterMeshBoxType.
This way we can reuse it without including the CustomFilterOperation file.
No new tests, just refactoring code.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CustomFilterMeshBoxType):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperation):
- platform/graphics/filters/CustomFilterArrayParameter.h: Adding AnimationUtilities.h for WebCore::blend, looks like
CustomFilterOperation already included AnimationsUtilities.h indirectly.
- platform/graphics/filters/CustomFilterConstants.h: Added CustomFilterMeshBoxType.
- platform/graphics/filters/CustomFilterNumberParameter.h:
- platform/graphics/filters/CustomFilterOperation.cpp:
(WebCore::CustomFilterOperation::CustomFilterOperation):
- platform/graphics/filters/CustomFilterOperation.h:
(WebCore::CustomFilterOperation::create):
(WebCore::CustomFilterOperation::meshBoxType):
(CustomFilterOperation):
- platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::create):
(WebCore::CustomFilterRenderer::CustomFilterRenderer):
- platform/graphics/filters/CustomFilterRenderer.h: Also removed the need to include CustomFilterOperation.h. Some other
headers were needed to replace the files that were automatically incldued because of that file.
(WebCore):
(CustomFilterRenderer):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::create):
- platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):
Source/WebKit2:
Renamed the CustomFilterOperation::MeshBoxType to CustomFilterMeshBoxType.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::decode):
- 1:57 PM Changeset in webkit [133226] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed; marking another inspector test as flaky.
- platform/chromium/TestExpectations:
- 1:57 PM Changeset in webkit [133225] by
-
- 2 edits in trunk/Source/WebKit/mac
[WK1] Fixed-position elements jiggle up and down slightly during scrolling on a Retina display
https://bugs.webkit.org/show_bug.cgi?id=100957
Reviewed by Simon Fraser.
WebCore doesn't yet support subpixel scrolling. WebKit2 forces
scrolling to always be integral. Now WebKit1 forces this as well.
I'm not sure how to write a test for this.
- WebView/WebDynamicScrollBarsView.mm:
(shouldRoundScrollOrigin): Returns YES if there are any position:fixed
or position:sticky elements in the page.
(-[WebDynamicScrollBarsView scrollClipView:toPoint:]): Round the
scroll origin to the nearest pixel if needed.
- 1:54 PM Changeset in webkit [133224] by
-
- 19 edits2 adds in trunk
Part2 of: Extend -webkit-user-select with new value "all"
<rdar://problem/10161404>
https://bugs.webkit.org/show_bug.cgi?id=91912
Reviewed by Ryosuke Niwa.
Source/WebCore:
The new value "all" for -webkit-user-select property gives content none-or-all selection option.
The patch was originally prepared by Alice Cheng but the approach has been changed.
The idea is to treat these elements like non editable, meaning that we should skip over them entirely
when moving the cursor and a deletion should delete the element and all its descentants at once.
The key change is in Node::rendererIsEditable where we now return false if the element style is
userSelect: all. The other change is in the way we create the selection on mouse click and dragging
over the element. In both cases we force the selection to extend over the entire element with
the user-select: all attribute.
This is currently enabled only for the Mac port.
Test: editing/selection/user-select-all-selection.html
- dom/Node.cpp: Added a parameter to isContentEditable to behave differently
when called from JavaScript. Internally isContentEditable returns false on
nodes with user-select: all style.
(WebCore::Node::isContentEditable):
(WebCore::Node::isContentRichlyEditable):
(WebCore::Node::rendererIsEditable):
(WebCore::Node::shouldUseInputMethod):
(WebCore::Node::willRespondToMouseClickEvents):
- dom/Node.h:
(WebCore::Node::rendererIsEditable):
(WebCore::Node::rendererIsRichlyEditable):
- dom/Position.cpp:
(WebCore::Position::nodeIsUserSelectAll): Added.
(WebCore::Position::rootUserSelectAllForNode): Added.
- dom/Position.h: Added static functions described above.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added parameter to
isContentEditable() call.
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Added parameter to
isContentEditable() call.
- editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply): Added parameter to
isContentEditable() call.
- editing/FrameSelection.cpp:
(WebCore::adjustForwardPositionForUserSelectAll): New helper function.
(WebCore::adjustBackwardPositionForUserSelectAll): New helper function.
(WebCore::FrameSelection::modifyExtendingRight):
(WebCore::FrameSelection::modifyExtendingForward):
(WebCore::FrameSelection::modifyExtendingLeft):
(WebCore::FrameSelection::modifyExtendingBackward):
(WebCore::FrameSelection::modify):
(WebCore::CaretBase::invalidateCaretRect): Added parameter to
isContentEditable() call.
- editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply): Ditto.
(WebCore::InsertNodeBeforeCommand::doUnapply): Ditto.
- editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doApply): Ditto.
- editing/visible_units.cpp:
(WebCore::startOfParagraph): We should not consider a paragraph break and element
with user-select: all style, like we do at the border of editability.
(WebCore::endOfParagraph): Ditto.
- page/EventHandler.cpp:
(WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart): Create a selection
around the element whose style is user-select: all.
(WebCore::EventHandler::updateSelectionForMouseDrag): Ditto.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionState): Fixed a bug uncovered during this work.
If the selection starts in one of the leaf boxes and after we encounter one with SelectionNone,
we should return the selection state as SelectionBoth, assuming we went past the end selection.
This avoids doing an incorrect gap filling for the selection highlighting.
LayoutTests:
Testing moving and extending selections with the new CSS propertyvalue, with mouse movements
and with the keyboard.
Updated test expectations for all the platforms, since this is only enabled for the Mac port.
- editing/selection/user-select-all-selection-expected.txt: Added.
- editing/selection/user-select-all-selection.html: Added.
- platform/chromium/TestExpectations:
- platform/qt/TestExpectations:
- platform/gtk/TestExpectations:
- platform/win/TestExpectations:
- platform/efl/TestExpectations:
- 1:50 PM Changeset in webkit [133223] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Fix Windows build by re-adding a #include
https://bugs.webkit.org/show_bug.cgi?id=100986
Patch by Alec Flett <alecflett@chromium.org> on 2012-11-01
Reviewed by Stephen White.
Fix #include that broke windows.
- Modules/indexeddb/IDBCallbacks.h:
- 1:49 PM Changeset in webkit [133222] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged 123131. '<rdar://problem/12536524>'
- 1:42 PM Changeset in webkit [133221] by
-
- 8 edits in trunk
REGRESSION (r128837): mathml/presentation/subsup.xhtml became flaky
https://bugs.webkit.org/show_bug.cgi?id=97390
Reviewed by Ojan Vafai.
Source/WebCore:
In a RenderMathMLSubSup, we need to set the base's wrapper's style so that baseHeight
in layout() will be the base's true height, without any flexbox stretching.
Tested by existing tests.
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::fixAnonymousStyles):
(WebCore::RenderMathMLSubSup::addChild):
(WebCore::RenderMathMLSubSup::styleDidChange):
- rendering/mathml/RenderMathMLSubSup.h:
(RenderMathMLSubSup):
LayoutTests:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- 1:35 PM Changeset in webkit [133220] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r123128. <rdar://problem/12536420>
- 1:30 PM Changeset in webkit [133219] by
-
- 5 edits2 copies in branches/safari-536.28-branch
Merged r123062. <rdar://problem/12516377>
- 1:30 PM Changeset in webkit [133218] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Mark an inspector test as flaky.
- platform/chromium/TestExpectations:
- 1:25 PM Changeset in webkit [133217] by
-
- 2 edits1 delete in trunk/LayoutTests
[chromium] Unreviewed gardening.
- platform/chromium-linux-x86/compositing/reflections/nested-reflection-anchor-point-expected.png: Removed.
- platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
- 1:23 PM Changeset in webkit [133216] by
-
- 3 edits2 deletes in trunk/LayoutTests
[chromium] Unreviewed gardening. Move baselines for a couple of
compositing tests to platform-mac, so MountainLion can use them too.
- platform/chromium-mac-lion/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
- platform/chromium-mac-lion/platform/chromium/compositing/huge-layer-rotated-expected.png: Removed.
- platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
- 1:13 PM Changeset in webkit [133215] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r122755. <rdar://problem/12536436>
- 12:41 PM Changeset in webkit [133214] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION (r132941): attribute modification 10% performance regression
https://bugs.webkit.org/show_bug.cgi?id=100873
Reviewed by Ojan Vafai.
Don't do the class change finding by mutating SpaceSplitString. It is slow. Instead use a bit vector
to mark the unchanged classes
- css/StyleResolver.cpp:
(WebCore):
- css/StyleResolver.h:
(WebCore::StyleResolver::hasSelectorForAttribute):
(WebCore):
(WebCore::StyleResolver::hasSelectorForClass):
(WebCore::StyleResolver::hasSelectorForId):
Inlined these and moved value validity testing to clients.
- dom/Element.cpp:
(WebCore::checkNeedsStyleInvalidationForIdChange):
(WebCore):
(WebCore::Element::attributeChanged):
Clean up id testing too.
(WebCore::checkNeedsStyleInvalidationForClassChange):
Use bit vector for marking seen values. Avoids allocations and reffing.
(WebCore::Element::classAttributeChanged):
Don't test if style is already invalid.
- 12:31 PM Changeset in webkit [133213] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Mark yet another test as flaky.
- platform/chromium/TestExpectations:
- 12:30 PM Changeset in webkit [133212] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Mark a test as flaky.
- platform/chromium/TestExpectations:
- 12:16 PM Changeset in webkit [133211] by
-
- 1 edit2 adds in trunk/Tools
Add LLDB-Python scripts to support WebKit data types.
https://bugs.webkit.org/show_bug.cgi?id=100898
Reviewed by Anders Carlsson.
Add Summary providers for common WebKit string types.
- lldb/lldb_webkit.py: Added.
(lldb_init_module): Register these providers with the debugger.
(WTFString_SummaryProvider): Wrapper around WTFStringProvider.
(WTFStringImpl_SummaryProvider): Wrapper around WTFStringImplProvider.
(WTFAtomicString_SummaryProvider): Ditto.
(guess_string_length): Walk through the string looking for a null-byte(s).
(ustring_to_string): Walk through the string, extracting two-byte values, and concatenate them.
(lstring_to_string): Walk through the string, extracting byte values, and concatenate them.
(WTFStringImplProvider):
(WTFStringImplProvider.init):
(WTFStringImplProvider.get_length): Extract the m_length variable.
(WTFStringImplProvider.get_data8): Extract the m_data8 variable.
(WTFStringImplProvider.get_data16): Extract the m_data16 variable.
(WTFStringImplProvider.to_string): Pass the appropriate data variable to {u,l}string_to_string.
(WTFStringImplProvider.is_8bit): Check the m_hashAndFlags variable.
(WTFStringProvider):
(WTFStringProvider.init):
(WTFStringProvider.stringimpl): Extract the m_impl variable.
(WTFStringProvider.get_length): Pass through to WTFStringImplProvider.
(WTFStringProvider.to_string): Ditto.
- 12:13 PM Changeset in webkit [133210] by
-
- 4 edits2 copies in branches/safari-536.28-branch
Merged r122278. <rdar://problem/12536506>
- 12:08 PM Changeset in webkit [133209] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r121930. <rdar://problem/12536519>
- 12:03 PM Changeset in webkit [133208] by
-
- 3 edits2 copies in branches/safari-536.28-branch
Merged r121491. <rdar://problem/12536496>
- 12:02 PM Changeset in webkit [133207] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Crash in Range::editingStartPosition
https://bugs.webkit.org/show_bug.cgi?id=100972
Reviewed by Enrica Casucci.
Add a missing null pointer check. toNormalizedRange() can return null here, in which case the call to
pastLastNode() will crash.
No new tests since determining the exact condition under which we go through the said code path and
toNormalRange returns null is hard.
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontForSelection):
- 12:01 PM Changeset in webkit [133206] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, remove failing expectations after rebaseline.
- platform/chromium/TestExpectations:
- 11:57 AM Changeset in webkit [133205] by
-
- 21 edits4 adds in trunk
.: https://bugs.webkit.org/show_bug.cgi?id=100917
There should be a way to dump the scrolling tree from the layout tests
Reviewed by Simon Fraser.
- Source/autotools/symbols.filter:
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=100917
There should be a way to dump the scrolling tree from the layout tests
Reviewed by Simon Fraser.
New Internals call to dump the scrolling state tree as text. Calls through to the
ScrollingCoordinator.
- testing/Internals.cpp:
(WebCore::Internals::scrollingStateTreeAsText):
(WebCore):
- testing/Internals.h:
- testing/Internals.idl:
- WebCore.exp.in:
- page/Page.cpp:
(WebCore::Page::scrollingStateTreeAsText):
(WebCore):
- page/Page.h:
(Page):
ScrollingCoordinator tells the rootStateNode to dump the tree as text.
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollingCoordinatorMac):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::scrollingStateTreeAsText):
(WebCore):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollingStateTreeAsText):
(WebCore):
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
dumpNode() dumps generic stuff for each node, and dumpProperties will dump the
properties that are specific to different types of nodes.
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::writeIndent):
(WebCore):
(WebCore::ScrollingStateNode::dumpNode):
(WebCore::ScrollingStateNode::scrollingStateTreeAsText):
- page/scrolling/ScrollingStateNode.h:
(WebCore):
(ScrollingStateNode):
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::dumpProperties):
(WebCore):
- page/scrolling/ScrollingStateScrollingNode.h:
(ScrollingStateScrollingNode):
Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=100917
There should be a way to dump the scrolling tree from the layout tests
Reviewed by Simon Fraser.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=100917
There should be a way to dump the scrolling tree from the layout tests
Reviewed by Simon Fraser.
- platform/mac/tiled-drawing/scrolling-tree-after-scroll-expected.txt: Added.
- platform/mac/tiled-drawing/scrolling-tree-after-scroll.html: Added.
- platform/mac/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt: Added.
- platform/mac/tiled-drawing/scrolling-tree-slow-scrolling.html: Added.
- 11:56 AM Changeset in webkit [133204] by
-
- 12 edits2 moves11 adds1 delete in trunk/LayoutTests
Rebaseline after compositor migration to gfx types.
http://crbug.com/147395
Unreviewed rebaselines.
- platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
- platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-linux/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
- platform/chromium-mac-lion/compositing/geometry/vertical-scroll-composited-expected.png: Added.
- platform/chromium-mac-lion/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-mac-lion/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
- platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
- platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
- platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
- platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
- platform/chromium-win-xp/compositing/reflections/nested-reflection-anchor-point-expected.png: Removed.
- platform/efl-wk1/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png.
- platform/efl-wk1/compositing/reflections/nested-reflection-anchor-point-expected.png: Renamed from LayoutTests/platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.png.
- 11:56 AM Changeset in webkit [133203] by
-
- 3 edits4 adds in trunk/Source/Platform
[chromium] Provide WebKit API interface for platform gesture curves
https://bugs.webkit.org/show_bug.cgi?id=100675
Reviewed by James Robinson.
Define interfaces to permit the Chromium embedder to provide its own
implementation of a gesture animation curve and add an entry point
to Platform.h that permits WebKit to obtain an instance of an embedder-
provided gesture curve.
No tests needed in this CL: only interfaces are being added.
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::createFlingAnimationCurve):
- chromium/public/WebGestureCurve.h: Added.
(WebKit):
(WebGestureCurve):
(WebKit::WebGestureCurve::~WebGestureCurve):
- chromium/public/WebGestureCurveTarget.h: Added.
(WebKit):
(WebGestureCurveTarget):
(WebKit::WebGestureCurveTarget::~WebGestureCurveTarget):
- chromium/src/WebActiveGestureAnimation.cpp: Added.
(WebKit):
(WebKit::WebActiveGestureAnimation::createAtAnimationStart):
(WebKit::WebActiveGestureAnimation::createWithTimeOffset):
(WebKit::WebActiveGestureAnimation::~WebActiveGestureAnimation):
(WebKit::WebActiveGestureAnimation::WebActiveGestureAnimation):
(WebKit::WebActiveGestureAnimation::animate):
- chromium/src/WebActiveGestureAnimation.h: Added.
(WebKit):
(WebActiveGestureAnimation):
- 11:53 AM Changeset in webkit [133202] by
-
- 3 edits in trunk/Source/WebCore
Add RGB to supported destination formats of ImageBuffer::copyToPlatformTexture
https://bugs.webkit.org/show_bug.cgi?id=100971
Reviewed by Stephen White.
The ImageBuffer::copyToPlatformTexture restriction added in
r132965 was too restrictive. Allow RGB textures to prevent
performance regressions.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::texImage2D):
- platform/graphics/ImageBuffer.h:
(ImageBuffer):
- 11:41 AM Changeset in webkit [133201] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, marking tests as failing preemptively.
http://crbug.com/147395
- platform/chromium/TestExpectations:
- 11:40 AM Changeset in webkit [133200] by
-
- 7 edits in trunk/Tools
[Chromium-Android] Apache doesn't properly clean up ipc semaphores after a layout test run
https://bugs.webkit.org/show_bug.cgi?id=100950
Reviewed by Dirk Pranke.
When a test run would fail to complete due to an exception in one of
the workers, the HTTP server wouldn't get a chance to gracefully shut
down. This caused too much IPC semaphores to be left on the server,
causing Apache to fail to start in subsequent runs.
By unifying the Android-specific code with other ports, we no longer
fail to call the ChromiumPort/Base setup_test_run() and clean_up_test_run()
methods either. Furthermore, the number_of_servers argument for starting
the HTTP server is now available as well.
Because not all tests require an HTTP server, it's not guaranteed that
it will be started. Android depends on this, so add a new method to Port
and override it for Android: requires_http_server().
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.run_tests):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.requires_http_server):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_dont_require_http_server):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.requires_http_server):
(ChromiumAndroidPort.start_http_server):
- Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.test_must_require_http_server):
- 11:37 AM Changeset in webkit [133199] by
-
- 5 edits in trunk/Source
[BlackBerry] Web page view state should be preserved for pages loaded from page cache
https://bugs.webkit.org/show_bug.cgi?id=100694
Internal PR: 220488
Internally reviewed by Lianghui Chen, Joe Mason
Patch by Michael Matovsky <mmatovsky@rim.com> on 2012-11-01
Reviewed by Rob Buis.
The web page view specific metadata should be preserved for web pages loaded from page cache (by using back/forward).
This requires web page view state to be saved in and restored from the corresponding page cache history item.
Source/WebCore:
No new tests for platform specific internal change.
- history/blackberry/HistoryItemViewState.h:
(HistoryItemViewState):
Source/WebKit/blackberry:
- Api/WebPageClient.h:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- 11:36 AM Changeset in webkit [133198] by
-
- 2 edits in trunk/Source/Platform
[chromium] Allow implicit conversion between gfx::Vector2d and WebSize
https://bugs.webkit.org/show_bug.cgi?id=100553
Reviewed by James Robinson.
The gfx::Vector2d class is used in chromium for defining distances. The
IntSize class is used equivalently inside WebCore. This lets us convert
between vectors and sizes along the API boundary.
- chromium/public/WebSize.h:
(WebKit::WebSize::WebSize):
(WebSize):
(WebKit::WebSize::operator=):
(WebKit::WebSize::operator gfx::Vector2d):
- 11:28 AM Changeset in webkit [133197] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Mark a test as flaky.
- platform/chromium/TestExpectations:
- 11:12 AM Changeset in webkit [133196] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip fast/workers/worker-domurl.html on Windows. ENABLE_BLOB not enabled.
- platform/win/TestExpectations:
- 11:07 AM Changeset in webkit [133195] by
-
- 43 edits in trunk/Source
IndexedDB: add methods to support id-based backend APIs
https://bugs.webkit.org/show_bug.cgi?id=100425
Reviewed by Tony Chang.
Source/WebCore:
First half of refactor involves adding a number of methods that
are int64_t-based rather than String-based. As a part of this, the
IDB*Metadata structs and the backend objectStore/index maps all
use int64_t as keys, rather than String.
In addition, there were a number of cleanups that came out of the
refactor:
- The list of object stores active in a transaction is now maintained by the frontend IDBTransaction rather than the backend IDBTransactionBackendImpl. This also had a simplifying rippling effect through other call signatures.
- I was able to remove an apparently old FIXME from IDBTransactionBackendImpl::objectStore and replace it with an ASSERT.
- IDBObjectStoreBackendImpl's IndexWriter class got a little simpler since the id is now easily available in the IDBIndexMetadata.
- A number of methods got simpler in their int64_t versions, specifically dropping a number of ExceptionCodes.
There is also some glue code
(getIndexId/getIndexIds/getObjectStoreId) that will go away with
the 2nd half of this: https://bugs.webkit.org/show_bug.cgi?id=100425
No new tests, no new functionality as this is just a refactor.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::objectStoreNames):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::objectStore):
(WebCore::IDBDatabaseBackendImpl::getObjectStoreId):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
(WebCore::IDBDatabaseBackendImpl::removeObjectStoreFromMap):
(WebCore::IDBDatabaseBackendImpl::addObjectStoreToMap):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
- Modules/indexeddb/IDBIndex.h:
(WebCore::IDBIndex::id):
(WebCore::IDBIndex::openKeyCursor):
- Modules/indexeddb/IDBIndexBackendInterface.h:
- Modules/indexeddb/IDBMetadata.h:
(WebCore::IDBIndexMetadata::IDBIndexMetadata):
(IDBIndexMetadata):
(IDBObjectStoreMetadata):
(WebCore::IDBObjectStoreMetadata::containsIndex):
(IDBDatabaseMetadata):
(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
(WebCore::IDBDatabaseMetadata::containsObjectStore):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReadyInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::getIndexId):
(WebCore::IDBObjectStoreBackendImpl::getIndexIds):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::removeIndexFromMap):
(WebCore::IDBObjectStoreBackendImpl::addIndexToMap):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
- Modules/indexeddb/IDBObjectStoreBackendInterface.h:
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::objectStore):
- Modules/indexeddb/IDBTransaction.h:
(IDBTransaction):
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::create):
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::objectStore):
(WebCore):
(WebCore::IDBTransactionBackendImpl::scheduleTask):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
(IDBTransactionBackendImpl):
- Modules/indexeddb/IDBTransactionBackendInterface.h:
Source/WebKit/chromium:
Chromium Proxy and WebIDB* support for new int64_t-based methods.
- public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::deleteObjectStore):
(WebKit::WebIDBDatabase::transaction):
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::put):
(WebKit::WebIDBObjectStore::setIndexKeys):
(WebKit::WebIDBObjectStore::setIndexesReady):
(WebKit::WebIDBObjectStore::index):
(WebKit::WebIDBObjectStore::deleteIndex):
- public/WebIDBTransaction.h:
(WebKit::WebIDBTransaction::objectStore):
- src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::deleteObjectStore):
(WebKit):
(WebKit::IDBDatabaseBackendProxy::transaction):
- src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
- src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::put):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):
- src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
- src/IDBTransactionBackendProxy.cpp:
(WebKit::IDBTransactionBackendProxy::objectStore):
- src/IDBTransactionBackendProxy.h:
(IDBTransactionBackendProxy):
- src/WebIDBMetadata.cpp:
(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):
- src/WebIDBTransactionImpl.cpp:
(WebKit::WebIDBTransactionImpl::objectStore):
(WebKit):
- src/WebIDBTransactionImpl.h:
- tests/IDBDatabaseBackendTest.cpp:
- 10:48 AM Changeset in webkit [133194] by
-
- 4 edits in trunk/Source/WebCore
[V8] The DOMWrapperVisitor abstraction is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=100965
Reviewed by Kentaro Hara.
This patch removes the DOMWrapperVisitor interface because it is no
longer needed. As a consequence, DOMWrapperMaps no longer need to
support enumeration, and we can move more DOM objects to use the faster
intrusive wrappers.
There was one remaining user of DOMWrapperVisitor in the
ScriptProfiler, which I've moved over to enumerating objects directly
from V8, similar to a function above it in the same file.
- bindings/v8/DOMWrapperMap.h:
(WebCore):
(DOMWrapperMap):
- bindings/v8/IntrusiveDOMWrapperMap.h:
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::visitNodeWrappers):
(WebCore::ScriptProfiler::visitExternalArrays):
- 10:46 AM Changeset in webkit [133193] by
-
- 14 edits2 adds in trunk
CSP 1.0: Warn when old-style directives encountered.
https://bugs.webkit.org/show_bug.cgi?id=100883
Reviewed by Adam Barth.
Source/WebCore:
In Mozilla's pre-W3C-spec implementation, a few directives are
implemented that were either renamed, reworked, or removed from CSP 1.0.
This patch adds special warning messages for three of those directives
to set developer expectations correctly.
Test: http/tests/security/contentSecurityPolicy/source-list-parsing-deprecated.html
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::parseDirective):
(WebCore::CSPDirectiveList::addDirective):
(WebCore::ContentSecurityPolicy::reportUnsupportedDirective):
- page/ContentSecurityPolicy.h:
Rename 'reportUnrecognizedDirectives' to
'reportUnsupportedDirectives', and teach it to give more descriptive
error messages when encountering 'allow', 'options', and
'policy-uri'.
LayoutTests:
- http/tests/security/contentSecurityPolicy/directive-parsing-01-expected.txt:
- http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers-expected.txt:
- http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
- http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
- http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt:
- http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-deprecated-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-deprecated.html: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
- platform/chromium/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
- 10:45 AM Changeset in webkit [133192] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-01
- DEPS:
- 10:42 AM Changeset in webkit [133191] by
-
- 3 edits in trunk/Source/WebKit/chromium
Web Inspector: expose Inspector.detached event factory to the embedder.
https://bugs.webkit.org/show_bug.cgi?id=100967
Reviewed by Vsevolod Vlasov.
That way embedder will be able to send messages on behalf of the backend being destructed.
- public/WebDevToolsAgent.h:
(WebDevToolsAgent):
- src/WebDevToolsAgentImpl.cpp:
(SerializingFrontendChannel):
(WebKit::SerializingFrontendChannel::sendMessageToFrontend):
(WebKit::WebDevToolsAgent::inspectorDetachedEvent):
(WebKit):
(WebKit::WebDevToolsAgent::workerDisconnectedFromWorkerEvent):
(WebKit::WebDevToolsAgent::disconnectEventAsText):
- 10:31 AM Changeset in webkit [133190] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html
as slow on Linux Debug based on the flakiness dashboard.
- platform/chromium/TestExpectations:
- 10:05 AM Changeset in webkit [133189] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Update CodeMirror to v3
https://bugs.webkit.org/show_bug.cgi?id=99319
Reviewed by Vsevolod Vlasov.
Updated to ToT v3.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype._gutterClick):
(WebInspector.CodeMirrorTextEditor.prototype.addBreakpoint):
(WebInspector.CodeMirrorTextEditor.prototype.removeBreakpoint):
(WebInspector.CodeMirrorTextEditor.prototype.setExecutionLine):
(WebInspector.CodeMirrorTextEditor.prototype.clearExecutionLine):
(WebInspector.CodeMirrorTextEditor.prototype.highlightLine):
(WebInspector.CodeMirrorTextEditor.prototype.clearLineHighlight):
(WebInspector.CodeMirrorTextEditor.prototype._change):
- inspector/front-end/cm/cmdevtools.css:
(.CodeMirror):
(.CodeMirror-linenumber):
(.cm-breakpoint):
- inspector/front-end/cm/codemirror.css:
(.CodeMirror):
(.CodeMirror-scroll):
(.CodeMirror-lines):
(.CodeMirror pre):
(.CodeMirror-scrollbar-filler):
(.CodeMirror-gutters):
(.CodeMirror-linenumbers):
(.CodeMirror-linenumber):
(.CodeMirror pre.CodeMirror-cursor):
(.CodeMirror pre.CodeMirror-secondarycursor):
(.cm-keymap-fat-cursor pre.CodeMirror-cursor):
(.cm-keymap-fat-cursor pre.CodeMirror-cursor:not(#nonsense_id)):
(.CodeMirror pre.CodeMirror-cursor.CodeMirror-overwrite):
(.cm-s-default .cm-keyword):
(.cm-s-default .cm-atom):
(.cm-s-default .cm-number):
(.cm-s-default .cm-def):
(.cm-s-default .cm-variable):
(.cm-s-default .cm-variable-2):
(.cm-s-default .cm-variable-3):
(.cm-s-default .cm-property):
(.cm-s-default .cm-operator):
(.cm-s-default .cm-comment):
(.cm-s-default .cm-string):
(.cm-s-default .cm-string-2):
(.cm-s-default .cm-meta):
(.cm-s-default .cm-error):
(.cm-s-default .cm-qualifier):
(.cm-s-default .cm-builtin):
(.cm-s-default .cm-bracket):
(.cm-s-default .cm-tag):
(.cm-s-default .cm-attribute):
(.cm-s-default .cm-header):
(.cm-s-default .cm-quote):
(.cm-s-default .cm-hr):
(.cm-s-default .cm-link):
(.cm-header, .cm-strong):
(.cm-em):
(.cm-emstrong):
(.cm-link):
(.cm-invalidchar):
(div.CodeMirror span.CodeMirror-matchingbracket):
(div.CodeMirror span.CodeMirror-nonmatchingbracket):
(.CodeMirror-sizer):
(.CodeMirror-vscrollbar, .CodeMirror-hscrollbar, .CodeMirror-scrollbar-filler):
(.CodeMirror-vscrollbar):
(.CodeMirror-hscrollbar):
(.CodeMirror-gutter):
(.CodeMirror-gutter-elt):
(.CodeMirror-linebackground):
(.CodeMirror-linewidget):
(.CodeMirror-measure):
(.CodeMirror-measure pre):
(.CodeMirror-selected):
(.CodeMirror-focused .CodeMirror-selected):
(.CodeMirror span):
- inspector/front-end/cm/codemirror.js:
(window.CodeMirror.):
(window.CodeMirror):
- inspector/front-end/utilities.js:
- 9:51 AM Changeset in webkit [133188] by
-
- 3 edits in trunk/Source
Source/WebCore: [BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-01
Reviewed by Rob Buis.
RIM PR 235194.
Check img pointer is null, if so, do early return.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::drawControl):
(WebCore::drawThreeSlice):
(WebCore::drawNineSlice):
Source/WebKit/chromium: [Chromium] debug builds: Use after free under ~PageOverlay()
https://bugs.webkit.org/show_bug.cgi?id=100930
Patch by Vsevolod Vlasov <vsevik@chromium.org> on 2012-11-01
Reviewed by Pavel Feldman.
Changed members order in PageOverlay so that GraphicsLayer is destroyed before GraphicsLayerClient.
- src/PageOverlay.h:
(PageOverlay):
- 9:47 AM Changeset in webkit [133187] by
-
- 4 edits in trunk/Source/WebCore
[V8] The V8DOMMap visitors are no longer needed
https://bugs.webkit.org/show_bug.cgi?id=100963
Reviewed by Kentaro Hara.
This patch inlines visitAllDOMNodes into its one caller (and removes
one layer of visitor adaptor abstraction).
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::visitNodeWrappers):
- bindings/v8/V8DOMMap.cpp:
- bindings/v8/V8DOMMap.h:
(WebCore):
- 9:46 AM Changeset in webkit [133186] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-01
Reviewed by Rob Buis.
RIM PR 235194.
Check img pointer is null, if so, do early return.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::drawControl):
(WebCore::drawThreeSlice):
(WebCore::drawNineSlice):
- 9:45 AM Changeset in webkit [133185] by
-
- 2 edits in trunk/Source/Platform
[chromium] Make WebLayerTreeView::adjustEventPointForPinchZoom pure virtual.
https://bugs.webkit.org/show_bug.cgi?id=100875
Reviewed by James Robinson.
This CL removes the default implementation for adjustEventPointForPinchZoom(), which
was necessary for landing the original patch in https://bugs.webkit.org/show_bug.cgi?id=100542.
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
- 9:24 AM Changeset in webkit [133184] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use clipped background rect in backing store
https://bugs.webkit.org/show_bug.cgi?id=100960
Reviewed by Yong Li.
Reviewed internally by Arvid Nilsson.
We calculated clipped background rect but didn't really use it when painting
the background. Use the correct rect to avoid ASSERT failure in platform code.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
- 9:11 AM Changeset in webkit [133183] by
-
- 9 edits2 deletes in trunk/LayoutTests
Unreviewed chromium windows rebaseline.
- platform/chromium-linux-x86/svg/zoom: Removed.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
- platform/chromium-win/compositing/overflow/overflow-compositing-descendant-expected.png:
- platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- 8:55 AM Changeset in webkit [133182] by
-
- 6 edits in trunk/Source/WebKit2
Coordinated Graphics: Clean up headers of Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=100907
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-01
Reviewed by Noam Rosenthal.
This patch performs:
- Remove unused methods.
- Change public methods to private if needed.
- Put virtual, OVERRIDE and explicit keywords if needed.
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::fixedToViewport):
(WebCore::CoordinatedGraphicsLayer::setMaskTarget):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- 8:51 AM Changeset in webkit [133181] by
-
- 18 edits1 add5 deletes in trunk/LayoutTests
Unreviewed chromium rebaseline for r133172.
- platform/chromium-linux-x86/svg/zoom/page: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
- platform/chromium-mac-lion/compositing/overflow/overflow-compositing-descendant-expected.png:
- platform/chromium-mac-lion/compositing/overflow/scroll-ancestor-update-expected.png:
- platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png:
- platform/chromium-mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
- platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png:
- platform/chromium-mac/svg/as-image/svg-non-integer-scaled-image-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/efl/compositing/overflow/overflow-compositing-descendant-expected.png: Removed.
- platform/efl/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Removed.
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Removed.
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
- 8:41 AM Changeset in webkit [133180] by
-
- 2 edits in trunk/LayoutTests
Add suppressions for images for new skia roll
https://bugs.webkit.org/show_bug.cgi?id=100961
Reviewed by NOBODY.
New skia roll improves clipped antialias hairlines, and this means a few images need to be rebaselined.
crbug.com/148638
- platform/chromium/TestExpectations:
- 8:40 AM Changeset in webkit [133179] by
-
- 2 edits in trunk/Tools
Crash beneath WKRelease after failed load in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=100954
Reviewed by Sam Weinig.
There were just some simple retain/release bugs.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController updateTextFieldFromURL:]):
(-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
Don't try to release null URLs.
(-[WK2BrowserWindowController updateCommittedURLForFrame:]): Don't
release a URL for which we don't have ownership.
- 8:33 AM Changeset in webkit [133178] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Build fix.
- bindings/v8/V8GCController.cpp:
- 8:32 AM Changeset in webkit [133177] by
-
- 13 edits4 adds in trunk/Source
[EFL][WK2] Add Ewk_Auth_Request API
https://bugs.webkit.org/show_bug.cgi?id=100858
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-01
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Provide an AuthenticationClient for EFL port in WebCore so
that we can handle authentication similarly to other ports
of WebKit.
No new tests, no behavior change for layout tests.
- PlatformEfl.cmake: Add AuthenticationChallengeSoup.cpp to CMake.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
- platform/network/ResourceHandle.h:
(ResourceHandle): Have ResourceHandle subclass AuthenticationClient like
most of the other ports.
- platform/network/soup/AuthenticationChallengeSoup.cpp: Fix initialization
of previousFailureCount member. It should be 1 if we are retrying
authentication and 0 otherwise, not the opposite.
(WebCore::AuthenticationChallenge::AuthenticationChallenge):
- platform/network/soup/ResourceHandleSoup.cpp: Provide implementation for EFL
port of AuthenticationClient methods.
(WebCore::WebCoreSynchronousLoader::didReceiveAuthenticationChallenge):
(WebCoreSynchronousLoader):
(WebCore):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::receivedCancellation):
(WebCore::authenticateCallback):
(WebCore::ResourceHandle::defaultSession):
Source/WebKit2:
Add Ewk_Auth_Request API for the client to handle
HTTP authentication.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/EwkViewCallbacks.h:
(EwkViewCallbacks):
- UIProcess/API/efl/ewk_auth_request.cpp: Added.
(Ewk_Auth_Request::Ewk_Auth_Request):
(Ewk_Auth_Request::~Ewk_Auth_Request):
(Ewk_Auth_Request::suggestedUsername):
(Ewk_Auth_Request::realm):
(Ewk_Auth_Request::host):
(Ewk_Auth_Request::cancel):
(Ewk_Auth_Request::authenticate):
(Ewk_Auth_Request::isRetrying):
(ewk_auth_request_ref):
(ewk_auth_request_unref):
(ewk_auth_request_suggested_username_get):
(ewk_auth_request_cancel):
(ewk_auth_request_authenticate):
(ewk_auth_request_retrying_get):
(ewk_auth_request_realm_get):
(ewk_auth_request_host_get):
- UIProcess/API/efl/ewk_auth_request.h: Added.
- UIProcess/API/efl/ewk_auth_request_private.h: Added.
(WebKit):
(Ewk_Auth_Request):
(Ewk_Auth_Request::create):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_auth_request.cpp: Added corresponding API tests.
(serverCallback):
(onAuthenticationRequest):
(TEST_F):
(onResourceLoadResponse):
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):
(WebKit):
(WebKit::PageLoadClientEfl::PageLoadClientEfl):
- UIProcess/efl/PageLoadClientEfl.h:
(PageLoadClientEfl):
- 8:19 AM Changeset in webkit [133176] by
-
- 2 edits in trunk/Source/WebKit2
Fix the Mac breakage
https://bugs.webkit.org/show_bug.cgi?id=100383
Reviewed by Kenneth Rohde Christiansen.
acceleratedCompositingForFixedPositionEnabled needs to be enabled
for fixed layout to work efficiently but it's wrong to force it
to false if fixed layout isn't enabled.
Separate hard requirements for fixed layout from rendering optimizations
and guard the later with USE(COORDINATED_GRAPHICS).
Also add an early return to make sure that ports always having a false
useFixedLayout creation parameter won't get their settings adjusted.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout):
- 8:17 AM Changeset in webkit [133175] by
-
- 4 edits in trunk/Source
WebIconDatabase: Properly clean up on destruction
https://bugs.webkit.org/show_bug.cgi?id=100237
Reviewed by Brady Eidson.
Source/WebCore:
It's now possible that the IconDatabase gets destroyed since WebKit2
isn't using it as a singleton.
Check that the database was properly closed rather than asserting that
it won't get deleted.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::~IconDatabase):
Source/WebKit2:
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::invalidate):
Make sure that IconDatabaseBase::iconDatabase won't return a dangling pointer.
- 8:16 AM Changeset in webkit [133174] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: make component subitems use parent color in native memory snapshots.
https://bugs.webkit.org/show_bug.cgi?id=100876
A component subitems use the color of the component itself if the color
is not explicitly specified for the subitem.
Patch by Alexei Filippov <alph@chromium.org> on 2012-11-01
Reviewed by Yury Semikhatsky.
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotNode.prototype._createSizeCell):
(WebInspector.MemoryBlockViewProperties._initialize):
(WebInspector.MemoryBlockViewProperties._forMemoryBlock):
- 8:06 AM Changeset in webkit [133173] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening. Remove some no-longer-flaky tests
from TestExpectations.
- platform/chromium/TestExpectations:
- 8:00 AM Changeset in webkit [133172] by
-
- 38 edits2 adds in trunk
[subpixel] Change intrinsicSize to LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=99104
Reviewed by Levi Weintraub.
Source/WebCore:
Change RenderReplaced and intrinsicSize to LayoutUnit to avoid
rounding problems when zooming/scaling. Also change imageSize to
LayoutUnit as it can return a scaled size.
Test: fast/sub-pixel/tiled-canvas-elements.html
- html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::finish):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
- loader/cache/CachedImage.h:
(CachedImage):
- platform/graphics/FractionalLayoutSize.h:
(FractionalLayoutSize):
(WebCore::FractionalLayoutSize::scale):
(WebCore::FractionalLayoutSize::clampToMinimumSize):
- rendering/RenderBox.h:
(WebCore::RenderBox::intrinsicSize):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::canvasSizeChanged):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::updateIntrinsicSizeIfNeeded):
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::minimumReplacedHeight):
- rendering/RenderImage.h:
(RenderImage):
- rendering/RenderImageResource.h:
(WebCore::RenderImageResource::imageSize):
- rendering/RenderImageResourceStyleImage.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced):
(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
- rendering/RenderReplaced.h:
(RenderReplaced):
(WebCore::RenderReplaced::minimumReplacedHeight):
(WebCore::RenderReplaced::setIntrinsicSize):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize):
(WebCore::RenderVideo::calculateIntrinsicSize):
(WebCore::RenderVideo::videoBox):
(WebCore::RenderVideo::minimumReplacedHeight):
- rendering/RenderVideo.h:
(RenderVideo):
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::imageSize):
- rendering/style/StyleCachedImage.h:
(StyleCachedImage):
- rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::imageSize):
- rendering/style/StyleCachedImageSet.h:
(StyleCachedImageSet):
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
- rendering/style/StyleGeneratedImage.h:
(StyleGeneratedImage):
- rendering/style/StyleImage.h:
(StyleImage):
- rendering/style/StylePendingImage.h:
LayoutTests:
Add test for tiled replaced elements and update existing expectations as needed.
- fast/sub-pixel/tiled-canvas-elements-expected.txt: Added.
- fast/sub-pixel/tiled-canvas-elements.html: Added.
- platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
- platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- platform/chromium/fast/reflections/reflection-with-zoom-expected.txt:
- platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt:
- platform/chromium/svg/zoom/page/zoom-svg-as-image-expected.txt:
- platform/chromium/svg/zoom/page/zoom-svg-as-relative-image-expected.txt:
- 7:56 AM Changeset in webkit [133171] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening. New reftest from
http://trac.webkit.org/changeset/133146 doesn't seem to work on
MacOS 10.8.
- platform/chromium/TestExpectations:
- 7:56 AM Changeset in webkit [133170] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Fix event mapping for WebKit2 with coordinated graphics
https://bugs.webkit.org/show_bug.cgi?id=100956
Reviewed by Alexis Menard.
Apply scale after translation.
- UIProcess/API/efl/ewk_view.cpp:
(toWebContentTransform):
- 7:52 AM Changeset in webkit [133169] by
-
- 8 edits in trunk/Source/WebCore
[V8] Unify the V8GCController visitors
https://bugs.webkit.org/show_bug.cgi?id=100897
Reviewed by Eric Seidel.
After this patch, we use a single visitor for all DOM wrappers,
regardless of type. We also visit all the wrappers in one pass by
calling v8::V8::VisitHandlesWithClassIds directly rather than via
visitAllDOMNodes.
This patch also introduces a wrapper class ID for non-Node DOM objects.
Previously, only DOM nodes had a class ID.
- bindings/v8/IntrusiveDOMWrapperMap.h:
- bindings/v8/ScriptProfiler.cpp:
(WebCore::retainedDOMInfo):
(WebCore::ScriptProfiler::initialize):
- bindings/v8/V8DOMMap.cpp:
(WebCore::visitAllDOMNodes):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
- bindings/v8/V8GCController.cpp:
(WebCore::GCHandleVisitor::notifyFinished):
(GCHandleVisitor):
(WebCore::V8GCController::majorGCPrologue):
- bindings/v8/WrapperTypeInfo.h:
(WebCore):
- 7:44 AM Changeset in webkit [133168] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Skipping http/tests/security/contentSecurityPolicy/object-src-none-blocked.html
as it's consistently leaking state into the next text (object-src-url-allowed.html).
Filed https://bugs.webkit.org/show_bug.cgi?id=100955 to follow up.
- platform/chromium/TestExpectations:
- 7:26 AM Changeset in webkit [133167] by
-
- 15 edits3 deletes in trunk/Source
Unreviewed, rolling out r133143.
http://trac.webkit.org/changeset/133143
https://bugs.webkit.org/show_bug.cgi?id=96894
Causing content_browsertests failures
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DeviceOrientationClient.h:
(DeviceOrientationClient):
- dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::DeviceOrientationController):
(WebCore):
(WebCore::DeviceOrientationController::~DeviceOrientationController):
(WebCore::DeviceOrientationController::timerFired):
(WebCore::DeviceOrientationController::addListener):
(WebCore::DeviceOrientationController::removeListener):
(WebCore::DeviceOrientationController::removeAllListeners):
(WebCore::DeviceOrientationController::suspendEventsForAllListeners):
(WebCore::DeviceOrientationController::resumeEventsForAllListeners):
(WebCore::DeviceOrientationController::didChangeDeviceOrientation):
(WebCore::DeviceOrientationController::supplementName):
- dom/DeviceOrientationController.h:
(WebCore):
(DeviceOrientationController):
(WebCore::DeviceOrientationController::isActive):
(WebCore::DeviceOrientationController::client):
(WebCore::DeviceOrientationController::from):
- dom/Document.cpp:
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
- loader/EmptyClients.h:
(WebCore::EmptyDeviceOrientationClient::startUpdating):
(WebCore::EmptyDeviceOrientationClient::stopUpdating):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):
- page/DeviceClient.h: Removed.
- page/DeviceController.cpp: Removed.
- page/DeviceController.h: Removed.
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
- 7:25 AM Changeset in webkit [133166] by
-
- 4 edits in trunk/Tools
[BlackBerry] Fix editing/text-iterator/findString-expected.html fail
https://bugs.webkit.org/show_bug.cgi?id=100902
Reviewed by Yong Li.
PR 210039
Fix the test my using the Page::findString method instead of our own in-page searcher.
This also syncs some of the changes we did regarding String usage.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::dumpFramesAsText):
(BlackBerry::WebKit::dumpHistoryItem):
(BlackBerry::WebKit::dumpBackForwardListForWebView):
(BlackBerry::WebKit::DumpRenderTree::dump):
(BlackBerry::WebKit::DumpRenderTree::didFinishDocumentLoadForFrame):
(BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
(BlackBerry::WebKit::DumpRenderTree::runJavaScriptAlert):
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(DumpRenderTree):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::setMockGeolocationError):
(TestRunner::layerTreeAsText):
(TestRunner::findString):
(TestRunner::setStorageDatabaseIdleInterval):
- 7:24 AM Changeset in webkit [133165] by
-
- 1 delete in trunk/LayoutTests/fast/css3-text-decoration
Remove empty directory after r132043.
- 7:22 AM Changeset in webkit [133164] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Avoid attempting to defer commits when they are already deferred
https://bugs.webkit.org/show_bug.cgi?id=100913
Patch by James Robinson <jamesr@chromium.org> on 2012-11-01
Reviewed by Adrienne Walker.
In threaded compositing mode, it's possible to load and unload FrameViews without any
intervening invalidations. In this case, we enter setIsAcceleratedCompositingActive
with commits already deferred. There's no need to defer again and doing so trips
an assertion in the implementation.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
- 7:17 AM Changeset in webkit [133163] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Add File Chooser dialog support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=100822
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-01
Reviewed by Kenneth Rohde Christiansen.
Add very basic file picker dialog to MiniBrowser so that
the user can select a file from the file system when
clicking an input element of type "file".
- MiniBrowser/efl/main.c:
(close_file_picker):
(on_filepicker_deletion):
(on_fileselector_done):
(on_file_chooser_request):
(window_create):
- 7:17 AM Changeset in webkit [133162] by
-
- 2 edits in trunk/Source/WebCore
[EFL][AC]Free GL resources allocated by GraphicsContext3DEfl.
https://bugs.webkit.org/show_bug.cgi?id=100923.
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-11-01
Reviewed by Kenneth Rohde Christiansen.
GraphicsContext3DEfl creates FBO's, textures and render buffer's, but doesn't free them.
This patch makes sure that GraphicsContext3dEfl frees all the GL resources allocated by it.
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
- 7:14 AM Changeset in webkit [133161] by
-
- 7 edits in trunk/Source/WebKit2
[EFL] Correct our use of the coordinated graphics
https://bugs.webkit.org/show_bug.cgi?id=100947
Reviewed by Alexis Menard.
Replace the display(...) call with a regular update() on the view.
In the coordinated graphics case this updates our view using
paintToCurrentGLContext with our viewmodel matrix and clips it to
the viewport. This avoid the need to manually joining update regions.
Unneeded update calls have also been removed and the resizing
logic has been improved.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::update):
- UIProcess/API/efl/EwkViewImpl.h:
(WebCore):
(EwkViewImpl):
(EwkViewImpl::clearEvasGLSurface):
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):
- UIProcess/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::setViewNeedsDisplay):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::setVisibleContentsRect):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
- UIProcess/efl/PageViewportControllerClientEfl.h:
(PageViewportControllerClientEfl):
- 7:10 AM Changeset in webkit [133160] by
-
- 3 edits in trunk/Source/WebCore
Fix StylePropertySet/ElementAttributeData custom allocation in debug builds.
<http://webkit.org/b/100753>
Unreviewed debug bot crash fix after r133138.
There's additional padding after StylePropertySet and ElementAttributeData
in 64-bit debug builds since there are additional members in RefCountedBase.
Use 'sizeof(ImmutableFoo) - sizeof(void*)' as the base size of ImmutableFoo.
Patch by Andreas Kling <kling@webkit.org> on 2012-11-01
- css/StylePropertySet.cpp:
(WebCore::sizeForImmutableStylePropertySetWithPropertyCount):
- dom/ElementAttributeData.cpp:
(WebCore::sizeForImmutableElementAttributeDataWithAttributeCount):
(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::reportMemoryUsage):
- 7:05 AM Changeset in webkit [133159] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-01
- DEPS:
- 6:54 AM Changeset in webkit [133158] by
-
- 2 edits in trunk/Source/WebCore
FEImage::m_document is never cleared. Why not?
https://bugs.webkit.org/show_bug.cgi?id=99243
Reviewed by Dirk Schulze.
Adding a comment to explain why the failure to clear m_document is not a problem.
No new tests because no code change at all.
- svg/graphics/filters/SVGFEImage.h:
(FEImage): Add a comment on the lifetime of m_document.
- 6:50 AM Changeset in webkit [133157] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Timeline: make "addRecord" unambiguous
https://bugs.webkit.org/show_bug.cgi?id=100761
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-01
Reviewed by Pavel Feldman.
TimelinePresentationModel.addRecord accepts two parameters:
record and parentRecord. parentRecord is always root record.
Make this explicit by removing parentRecord parameter.
- inspector/front-end/TimelinePanel.js: Removed parameter.
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.addRecord):
Used root recoed instead of parent record.
- 6:47 AM Changeset in webkit [133156] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Browser prematurely sends wrong credentials
https://bugs.webkit.org/show_bug.cgi?id=100585
Reviewed by George Staikos.
Don't send credentials to the server before been challenged.
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- 6:39 AM Changeset in webkit [133155] by
-
- 3 edits3 adds in trunk
SVG as an image may recreate the renderer on zoom
https://bugs.webkit.org/show_bug.cgi?id=99508
Reviewed by Abhishek Arya.
Source/WebCore:
The SVGImage code, when SVG is used in <img> tags, caches the renderer
at the start of the painting method and re-uses the pointer at the end
of the method. However, when the page is zoomed the renderer may be
detached mid-method, thus leaving a stray pointer. The fix is to
re-fetch the pointer after the zooms.
Test: svg/as-image/img-zoom-svg-stylesheet.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawSVGToImageBuffer): Re-fetch the renderer after
the zoom operations.
LayoutTests:
Test and ref-test-result for zooming of SVG content when loaded as-image, and the svg is actually a css file.
- svg/as-image/img-zoom-svg-stylesheet-expected.html: Added.
- svg/as-image/img-zoom-svg-stylesheet.html: Added.
- svg/as-image/resources/svg-stylesheet-for-zoom.svg: Added.
- 6:27 AM Changeset in webkit [133154] by
-
- 2 edits in trunk/Tools
Unreviewed. Change my email address.
- Scripts/webkitpy/common/config/committers.py:
- 6:18 AM Changeset in webkit [133153] by
-
- 6 edits in trunk
[Qt] Double clicks/taps aren't passed down to the page
https://bugs.webkit.org/show_bug.cgi?id=100949
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Since we are passing double click events as press events and that
they are preceeded by a real press event, double clicks are passed
down to the page as triple clicks.
Ignore double click events and let WebCore::EventHandler handle it
through press and release events.
- Shared/qt/WebEventFactoryQt.cpp:
(WebKit::webEventTypeForEvent):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::handleMouseEvent):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::handleInputEvent):
Tools:
Touch mocking shouldn't transform double click events as well,
this adds an extra touch update between clicks which prevents
double-tap detection from triggering on web pages.
Tested on the mobile version of Google maps.
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
- 6:16 AM Changeset in webkit [133152] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: introduce Inspector.detached message containing termination cause.
https://bugs.webkit.org/show_bug.cgi?id=100948
Reviewed by Yury Semikhatsky.
Now protocol clients have more information to process connection termination.
- English.lproj/localizedStrings.js:
- inspector/Inspector.json:
- inspector/front-end/InspectorFrontendHostStub.js:
(WebInspector.RemoteDebuggingTerminatedScreen):
- inspector/front-end/inspector.js:
(WebInspector.loaded.WebInspector.socket.onopen):
(WebInspector.loaded):
(WebInspector.detached):
- 5:27 AM Changeset in webkit [133151] by
-
- 9 edits in trunk
Web Inspector: Restoring breakpoints for formatted UISourceCode should be triggered by BreakpointManager, not ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=100593
Reviewed by Pavel Feldman.
Source/WebCore:
BreakpointManager now listen for FormattedChanged event and restores formatted breakpoints on it.
Removed now redundant callback from UISourceCode.setFormatted().
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._restoreBreakpoints):
(WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype._uiSourceCodeFormatted):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype._fireContentAvailable):
(WebInspector.UISourceCode.prototype.setFormatted.formattedChanged):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent):
(WebInspector.UISourceCode.prototype.setFormatted):
LayoutTests:
- inspector/debugger/script-formatter-breakpoints.html:
- inspector/debugger/script-formatter-console.html:
- inspector/debugger/script-formatter-search-expected.txt:
- inspector/debugger/script-formatter-search.html:
- 5:17 AM Changeset in webkit [133150] by
-
- 24 edits in trunk
Web Inspector: Output code evaluated in the console the same as console.log
https://bugs.webkit.org/show_bug.cgi?id=100695
Reviewed by Pavel Feldman.
Source/WebCore:
Added an option to return object preview from evaluation commands in the protocol.
The option is used to generate preview for console eval results.
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
- inspector/InjectedScript.h:
(InjectedScript):
- inspector/InjectedScriptSource.js:
(.):
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
- inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.useArrayPreviewInFormatter):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleCommandResult.prototype.useArrayPreviewInFormatter):
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.evaluateOnSelectedCallFrame):
(WebInspector.DebuggerModel.CallFrame.prototype.evaluate):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.evaluate):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):
- inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype.evaluate):
(WebInspector.RuntimeModel.prototype.evaluated):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):
LayoutTests:
Rebaselined some tests after object preview is started beeing used for
console eval results.
- inspector/console/command-line-api-expected.txt:
- inspector/console/command-line-api-inspect-expected.txt:
- inspector/console/console-eval-global-expected.txt:
- inspector/console/console-eval-undefined-override-expected.txt:
- platform/chromium/inspector/console/console-eval-undefined-override-expected.txt:
- 4:35 AM Changeset in webkit [133149] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove obsolete code from JavaScriptSourceFrame
https://bugs.webkit.org/show_bug.cgi?id=100594
Reviewed by Yury Semikhatsky.
Removed obsolete WorkingCopyCommitted listener.
Removed redundant code that removes breakpoints from _innerSetContent.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._innerSetContent):
- 4:32 AM Changeset in webkit [133148] by
-
- 2 edits in trunk/Source/WebCore
Update average StylePropertySet size estimation.
<http://webkit.org/b/100940>
Reviewed by Antti Koivisto.
Use sizeForImmutableStylePropertySetWithPropertyCount(2) as the average StylePropertySet
size to keep it in sync with the changed object memory layout.
- css/StylePropertySet.cpp:
(WebCore::sizeForImmutableStylePropertySetWithPropertyCount):
(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::averageSizeInBytes):
(WebCore::StylePropertySet::reportMemoryUsage):
- 4:22 AM Changeset in webkit [133147] by
-
- 2 edits in trunk/Source/WebCore
[EFL][Qt][AC] Remove an unnecessary connection to X-Server.
https://bugs.webkit.org/show_bug.cgi?id=100628.
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-11-01
Reviewed by Kenneth Rohde Christiansen.
With Changset: https://bugs.webkit.org/show_bug.cgi?id=100523
GraphicsSurfacePrivate should always use the Display returned by offscreenwindow.
However, in GraphicsSurfacePrivate constructor we call XOpenDisplay before asking
display from offscreenwindow.
This patch removes unnecessary call to XOpenDisplay made in GraphicsSurfacePrivate.
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
- 4:17 AM Changeset in webkit [133146] by
-
- 3 edits2 adds in trunk
[CSSRegions]Former auto-height regions should not ignore their defined height
https://bugs.webkit.org/show_bug.cgi?id=100749
Reviewed by Julien Chaffraix.
Source/WebCore:
When a region with height auto has its height defined, we should also clear the override logical content height.
Otherwise, the region will use the wrong height when laying out content from the associated render flow thread.
Test: fast/regions/autoheight-definedheight-changenotdetected.html
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
LayoutTests:
Add a test in which we flow content into a region chain with 2 regions, the first one having height auto.
After a first layout, the region with height auto has an override logical content height, which should be
cleared when the first region has its height changed from auto to defined.
- fast/regions/autoheight-definedheight-changenotdetected-expected.html: Added.
- fast/regions/autoheight-definedheight-changenotdetected.html: Added.
- 4:06 AM Changeset in webkit [133145] by
-
- 2 edits in trunk/Source/WebCore
Memory instrumentation: do not report memory occupied by RenderObjects referenced from CSSImageGeneratorValue
https://bugs.webkit.org/show_bug.cgi?id=100934
Reviewed by Alexander Pavlov.
- css/CSSImageGeneratorValue.cpp:
(WTF): Skip rederences to RenderObjects from CSSImageGeneratorValue when collecting
memory usage data.
- 4:04 AM Changeset in webkit [133144] by
-
- 3 edits in trunk/Source/WebKit2
[AC][EFL][WK2] Rename PageViewportControllerClientEfl::m_pageViewportController to m_controller
https://bugs.webkit.org/show_bug.cgi?id=100933
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-01
Reviewed by Kenneth Rohde Christiansen.
PageViewportControllerClientEfl::m_pageViewportController has to be renamed to m_controller
to keep consistency with other ports. Assertinons were also added.
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::PageViewportControllerClientEfl):
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::setVisibleContentsRect):
(WebKit::PageViewportControllerClientEfl::didResumeContent):
(WebKit::PageViewportControllerClientEfl::setController):
- UIProcess/efl/PageViewportControllerClientEfl.h:
(PageViewportControllerClientEfl):
- 3:38 AM Changeset in webkit [133143] by
-
- 15 edits3 adds in trunk/Source
Add DeviceController base-class to remove duplication of DeviceXXXControler
https://bugs.webkit.org/show_bug.cgi?id=96894
Reviewed by Hajime Morita.
Source/WebCore:
Add DeviceController which is extracted from DeviceOrientationController to remove duplication.
And soon-to-be-added DeviceMotionController and ProximityController.
Covered by existing tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DeviceOrientationClient.h:
- dom/DeviceOrientationController.cpp:
Remove member functions to move to DeviceController.
- addListener(), removeListener(), removeAllListeners(), isActive()
(WebCore::DeviceOrientationController::DeviceOrientationController):
(WebCore::DeviceOrientationController::didChangeDeviceOrientation):
(WebCore::DeviceOrientationController::client):
(WebCore::DeviceOrientationController::hasLastData):
(WebCore::DeviceOrientationController::getLastEvent):
(WebCore::DeviceOrientationController::from):
(WebCore):
- dom/DeviceOrientationController.h:
(WebCore):
(WebCore::DeviceOrientationController::~DeviceOrientationController):
(DeviceOrientationController):
- dom/Document.cpp:
Remove suspendEventsForAllListeners() and resumeEventsForAllListeners() function calls.
These calls can be made by checking activeDOMObjectsAreSuspended() and activeDOMObjectsAreStopped() before dispatchEvent.
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
- loader/EmptyClients.h:
(EmptyDeviceClient):
(WebCore::EmptyDeviceClient::startUpdating):
(WebCore::EmptyDeviceClient::stopUpdating):
(WebCore):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):
- page/DeviceClient.h: Added.
(WebCore):
(DeviceClient):
(WebCore::DeviceClient::~DeviceClient):
- page/DeviceController.cpp: Added.
DeviceController has extracted functions from DeviceOrientationController and DeviceMotionController.
- addDeviceEventListener(), removeDeviceEventlistener(), removeAllDeviceEventListeners(), dispatchDeviceEvent()
All kind of device event controller which has DeviceClient can be inherited from DeviceController.
(WebCore):
(WebCore::DeviceController::DeviceController):
(WebCore::DeviceController::addDeviceEventListener):
(WebCore::DeviceController::removeDeviceEventListener):
(WebCore::DeviceController::removeAllDeviceEventListeners):
(WebCore::DeviceController::dispatchDeviceEvent):
(WebCore::DeviceController::fireDeviceEvent):
- page/DeviceController.h: Added.
(WebCore):
(DeviceController):
(WebCore::DeviceController::~DeviceController):
(WebCore::DeviceController::isActive):
(WebCore::DeviceController::client):
(WebCore::DeviceController::hasLastData):
(WebCore::DeviceController::getLastEvent):
Source/WebKit/qt:
Change client() to deviceOrientationClient() to get DeviceOrientationClient*.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
- 3:17 AM Changeset in webkit [133142] by
-
- 1 edit1 add in trunk/LayoutTests
[chromium] Add new baseline for exif-orientation-css.html on linux.
- platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/exif-orientation-css-expected.png: Added.
- 2:28 AM Changeset in webkit [133141] by
-
- 9 edits in trunk/Source
Memory instrumentation: report memory occupied by ResourceRequest instead of its base ResourceRequestBase
https://bugs.webkit.org/show_bug.cgi?id=100497
Reviewed by Alexander Pavlov.
Source/WebCore:
Added memory reporting method to chromium implementation of ResourceRequest.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsageBase): Renamed reportMemoryUsage
on ResourceRequestBase to reportMemoryUsageBase and made it protected. I'd
rather make ResourceRequestBase::reportMemoryUsage virtual and override it
in the descendant but ResourceRequestBase doesn't have any virtual methods
and shouldn't be used directly(ResourceRequest should be used instead).
- platform/network/ResourceRequestBase.h:
(ResourceRequestBase):
- platform/network/chromium/ResourceRequest.cpp:
(WebCore::ResourceRequest::reportMemoryUsage):
(WebCore):
- platform/network/chromium/ResourceRequest.h:
(ResourceRequest):
Source/WebKit/chromium:
Updated MemoryInstrumentationTest.ImageObserver so that it doesn't fail
when instrumentation of objects referenced by CachedImage changes.
- tests/MemoryInstrumentationTest.cpp:
Source/WTF:
- wtf/MemoryInstrumentation.h:
(WTF::MemoryClassInfo::addPrivateBuffer): do not report memory usage for empty buffer.
- 2:08 AM Changeset in webkit [133140] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening after r133056
https://bugs.webkit.org/show_bug.cgi?id=100929
Unreviewed gardening.
Newly added compositing/tiling tests are failing on EFL port due to missing AC support.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-01
- platform/efl/TestExpectations:
- 2:00 AM Changeset in webkit [133139] by
-
- 2 edits1 add in trunk/LayoutTests
[chromium] Unreviewed, two fast/images/exif-orientation-* tests now pass.
- platform/chromium-win/platform/chromium/virtual/deferred/fast/images/exif-orientation-css-expected.png: Added.
- platform/chromium/TestExpectations:
- 1:55 AM Changeset in webkit [133138] by
-
- 5 edits in trunk/Source/WebCore
Pack immutable StylePropertySets harder on 64-bit.
<http://webkit.org/b/100753>
<rdar://problem/12599155>
Reviewed by Antti Koivisto.
Move away from using CSSProperty as internal storage for immutable StylePropertySets.
Instead use two arrays, one for property metadata (ID, shorthand ID, !important, ...)
and one for the CSSValue pointers. This saves 4 bytes per property on 64-bit.
Old object layout:
Ref count (4 bytes)
Metadata (4 bytes)
CSSProperty [N] (16 bytes each)
New object layout:
Ref count (4 bytes)
Metadata (4 bytes)
CSSValue* [N] (8 bytes each)
StylePropertyMetadata [N] (4 bytes each)
901kB progress on Membuster3 (22% overall reduction in StylePropertySet memory.)
The CSSProperty class sticks around for now, it's still used in mutable StylePropertySets
and by the StylePropertySet constructors.
- css/CSSProperty.cpp:
- css/CSSProperty.h:
(CSSProperty):
(WebCore::CSSProperty::CSSProperty):
(WebCore::CSSProperty::id):
(WebCore::CSSProperty::shorthandID):
(WebCore::CSSProperty::isImportant):
(WebCore::CSSProperty::metadata):
Break the bitfield from CSSProperty out into a StylePropertyMetadata class (actually a union.)
- css/StylePropertySet.cpp:
(WebCore::immutableStylePropertySetSize):
Updated size calculation for immutable StylePropertySets, 1/4 smaller!
(WebCore::ImmutableStylePropertySet::ImmutableStylePropertySet):
(WebCore::ImmutableStylePropertySet::~ImmutableStylePropertySet):
(WebCore::MutableStylePropertySet::MutableStylePropertySet):
(WebCore::StylePropertySet::mergeAndOverrideOnConflict):
(WebCore::StylePropertySet::reportMemoryUsage):
(WebCore::StylePropertySet::PropertyReference::cssName):
(WebCore::StylePropertySet::PropertyReference::cssText):
- css/StylePropertySet.h:
(WebCore::StylePropertySet::PropertyReference::id):
(WebCore::StylePropertySet::PropertyReference::shorthandID):
(WebCore::StylePropertySet::PropertyReference::isImportant):
(WebCore::StylePropertySet::PropertyReference::isInherited):
(WebCore::StylePropertySet::PropertyReference::isImplicit):
(PropertyReference):
(WebCore::StylePropertySet::PropertyReference::value):
(WebCore::StylePropertySet::PropertyReference::toCSSProperty):
(WebCore::StylePropertySet::PropertyReference::propertyMetadata):
(WebCore::StylePropertySet::PropertyReference::propertyValue):
(StylePropertySet):
(ImmutableStylePropertySet):
(WebCore::StylePropertySet::immutableValueArray):
(WebCore::StylePropertySet::immutableMetadataArray):
Refactored internal storage for StylePropertySet.
- 1:53 AM Changeset in webkit [133137] by
-
- 2 edits in trunk/LayoutTests
2012-11-01 Pavel Podivilov <podivilov@google.com>
[chromium] Unreviewed, remove several tests that started to pass from TestExpectations.
- platform/chromium/TestExpectations:
- 1:04 AM Changeset in webkit [133136] by
-
- 7 edits7 deletes in trunk/Source/WebKit2
Unreviewed, rolling out r133126.
http://trac.webkit.org/changeset/133126
https://bugs.webkit.org/show_bug.cgi?id=100925
This made EFL API test break on EFL buildbots (Requested by
gyuyoung on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-01
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::Ewk_Context):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_private.h:
(Ewk_Context):
- UIProcess/API/efl/ewk_security_origin.cpp: Removed.
- UIProcess/API/efl/ewk_security_origin.h: Removed.
- UIProcess/API/efl/ewk_security_origin_private.h: Removed.
- UIProcess/API/efl/ewk_storage_manager.cpp: Removed.
- UIProcess/API/efl/ewk_storage_manager.h: Removed.
- UIProcess/API/efl/ewk_storage_manager_private.h: Removed.
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
- UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp: Removed.
- 12:49 AM WebKitGTK/WebKit2Roadmap edited by
- g-i done (diff)
- 12:41 AM Changeset in webkit [133135] by
-
- 6 edits in trunk/Source/JavaScriptCore
DFG optimized string access code should be enabled
https://bugs.webkit.org/show_bug.cgi?id=100825
Reviewed by Oliver Hunt.
- Removes prediction checks from the parser.
- Fixes the handling of array mode refinement for strings. I.e. we don't do any refinement - we already know it's going to be a string. We could revisit this in the future, but for now the DFG lacks the ability to handle any array modes other than Array::String for string intrinsics, so this is as good as it gets.
- Removes uses of isBlahSpeculation for checking if a mode is already checked. isBlahSpeculation implicitly checks if the SpeculatedType is not BOTTOM ("empty"), which breaks for checking if a mode is already checked since a mode may already be "checked" in the sense that we've proven that the code is unreachable.
~1% speed-up on V8v7, mostly from a speed-up on crypto, which uses string
intrinsics in one of the hot functions.
- bytecode/SpeculatedType.h:
(JSC::speculationChecked):
(JSC):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::alreadyChecked):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
- 12:31 AM Changeset in webkit [133134] by
-
- 13 edits in trunk/Source
Remove unused Locale::parseDateTime
https://bugs.webkit.org/show_bug.cgi?id=100910
Reviewed by Kentaro Hara.
Source/WebCore:
For date/time input types, InputType::convertFromVisibleValue is never
called. convertFromVisibleValue is called when an inner editable node is
updated. However input elements don't have such editable nodes if
ENABLE_INPUT_MULTIPLE_FIELDS_UI is enabled, and a user can't edit the
inner editable node otherwise because we open date/time pickers when a
user try to change the field value.
We had used convertFromVisibleValue for input[type=date] with an old UI.
No new tests because of no behavior changes.
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::convertFromVisibleValue):
Remove Locale::parseDateTiem and put ASSERT_NOT_REACHED.
- platform/text/PlatformLocale.h: Remove parseDateTime.
- platform/text/LocaleICU.h: Remove parseDateTime and a bogus comment.
- platform/text/LocaleICU.cpp: Remove parseDateTime.
- platform/text/LocaleNone.cpp: Remove parseDateTime.
- platform/text/mac/LocaleMac.h: Remove parseDateTime.
- platform/text/mac/LocaleMac.mm: Ditto.
- platform/text/win/LocaleWin.h:
- Remove parseDateTime, its helpers, and m_baseYear.
- Remove appendNumber, appendTwoDigitsNumber, appendFourDigitsNumber, and formatDate. They don't exist.
- platform/text/win/LocaleWin.cpp:
Remove the above functions.
(WebCore::LocaleWin::LocaleWin): Remove m_baseYear iniitalization.
Source/WebKit/chromium:
- tests/LocaleMacTest.cpp: Remove tests for parseDateTime.
- tests/LocaleWinTest.cpp: Ditto.
- 12:26 AM Changeset in webkit [133133] by
-
- 7 edits in trunk/Source/WebKit2
[WK2] Add APIs to get/set encoding detector
https://bugs.webkit.org/show_bug.cgi?id=100066
Patch by Yuni Jeong <yhnet.jung@samsung.com> on 2012-11-01
Reviewed by Gyuyoung Kim.
Add setting APIs for encoding dector and a unit test.
- Shared/WebPreferencesStore.h:
(WebKit):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetUsesEncodingDetector):
(WKPreferencesGetUsesEncodingDetector):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/API/efl/ewk_settings.cpp:
(ewk_setting_uses_encoding_detector_set):
(ewk_setting_uses_encoding_detector_get):
- UIProcess/API/efl/ewk_settings.h:
- UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
- 12:01 AM Changeset in webkit [133132] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Page popup shows up at wrong locations when root view is scrolled
https://bugs.webkit.org/show_bug.cgi?id=100830
Reviewed by Kent Tamura.
We need to account for the scroll position when calculating the root view rectangle in the screen.
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument):
