Timeline



Nov 8, 2012:

11:45 PM Changeset in webkit [134023] by commit-queue@webkit.org
  • 4 edits in trunk

Web Inspector: Timeline: "Send Request" events are shown out of order.
https://bugs.webkit.org/show_bug.cgi?id=101544

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-08
Reviewed by Yury Semikhatsky.

Solution: replace obsolete out-of-order record pushing with frontend
record reparenting.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willSendResourceRequest): Replaced
direct record pushing with standard appendRecord invokation.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype._findParentRecord):
Made "Send Request" records top-level if gluing is on.

11:41 PM Changeset in webkit [134022] by commit-queue@webkit.org
  • 31 edits in trunk/Source

Unreviewed, rolling out r134010.
http://trac.webkit.org/changeset/134010
https://bugs.webkit.org/show_bug.cgi?id=101716

Broke the chromium windows build. (Requested by noel_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

Source/WebCore:

  • Modules/indexeddb/IDBAny.cpp:
  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::getObjectStoreId):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(WebCore):
(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::containsIndex):
(WebCore::IDBDatabaseMetadata::findObjectStore):
(IDBDatabaseMetadata):
(WebCore::IDBDatabaseMetadata::containsObjectStore):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::getIndexId):
(WebCore::IDBObjectStoreBackendImpl::getIndexIds):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:

(WebCore):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):
(WebCore):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(IDBTransactionBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

Source/WebKit/chromium:

  • src/IDBCallbacksProxy.cpp:
  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::transaction):
(WebKit):

  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::deleteObjectStore):
(WebKit):
(WebKit::WebIDBDatabaseImpl::transaction):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
(WebKit):
(WebKit::WebIDBObjectStoreImpl::setIndexKeys):
(WebKit::WebIDBObjectStoreImpl::setIndexesReady):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::deleteIndex):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

  • src/WebIDBTransactionImpl.cpp:

(WebKit::WebIDBTransactionImpl::objectStore):
(WebKit):

  • src/WebIDBTransactionImpl.h:
  • tests/IDBRequestTest.cpp:
11:34 PM Changeset in webkit [134021] by g.czajkowski@samsung.com
  • 7 edits in trunk/Source

[EFL] Add a method to the TextCheckerEnchant class to check whether any dictionary is loaded
https://bugs.webkit.org/show_bug.cgi?id=101570

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Expose a new method to check whether a vector of loaded languages is empty.
WK2-EFL needs it to set the default language (if the client didn't set any) when
spelling setting is being enabled. This change makes it more convenient to check
whether the dictionaries vector is empty.

No new tests, no behavior change.

  • platform/text/enchant/TextCheckerEnchant.cpp:

(TextCheckerEnchant::checkSpellingOfString):
(TextCheckerEnchant::getGuessesForWord):
(TextCheckerEnchant::loadedSpellCheckingLanguages):
A newly exposed method is used internally too.

  • platform/text/enchant/TextCheckerEnchant.h:

(WebCore::TextCheckerEnchant::hasDictionary):
Add an inline hasDictionary() method.

Source/WebKit2:

To do not get the vector of loaded languages, WebKit2-EFL calls
TextCheckerEnchant::hasDictionary() method to check whether the
dictionaries vector is empty.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_continuous_spell_checking_enabled_set):

  • UIProcess/API/efl/ewk_text_checker.cpp:

(Ewk_Text_Checker::hasDictionary):
(Ewk_Text_Checker):

  • UIProcess/API/efl/ewk_text_checker_private.h:

(Ewk_Text_Checker):

11:28 PM Changeset in webkit [134020] by shinyak@chromium.org
  • 3 edits in trunk/Source/WebCore

[Refactoring] Remove shadowPseudoId() and use pseudo() instead in TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=101702

Reviewed by Hajime Morita.

We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from TextTrackCue and use
setPseudo()/pseudo() instead.

No new tests, simple refactoring.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox):

  • html/track/TextTrackCue.h:

(TextTrackCueBox):

11:23 PM Changeset in webkit [134019] by hayato@chromium.org
  • 4 edits
    2 adds in trunk/LayoutTests

Unreviewed, update chromium-mac baselines.

  • platform/chromium-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.png:
  • platform/chromium-mac/platform/chromium/media/video-frame-size-change-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/text-on-scaled-layer-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/text-on-scaled-surface-expected.png: Added.
11:20 PM Changeset in webkit [134018] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove Chromium test expectations after r133939.

  • platform/chromium/TestExpectations:
11:03 PM Changeset in webkit [134017] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

table not aligned in center column and seems shrunk because of float:right (table-layout: fixed and width: 100%)
https://bugs.webkit.org/show_bug.cgi?id=18153

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-11-08
Reviewed by Beth Dakin.

Source/WebCore:

Preferred logical width is computed incorrectly for fixed layout tables
with 100% percent width, in standards mode.

According to our fixed table layout algorithm (CSS2 specification - 17.5.2.1)
the ultimate width of the table is the greater of the value of the
'width' property for the table elements and the sum of the column
widths.

For our specific scenario we have a fixed layout table with 100% width
consisting of columns with fixed widths, the sum of which is less than
the specified width of the table (i.e. 100% of the containing block).
Even then the applied width is the cummulative of the width of the
columns.

This happens because of the quirks mode check added in
FixedTableLayout::computePreferredLogicalWidths(), which prohibits the
setting of maxWidth to our fixed layout table with percent width, and
which perhaps is not required anymore.

Test: fast/table/fixed-table-layout/table-with-percent-width.html

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::computePreferredLogicalWidths):
Removed the quirks mode check.

LayoutTests:

  • fast/table/fixed-table-layout/table-with-percent-width-expected.txt: Added.
  • fast/table/fixed-table-layout/table-with-percent-width.html: Added.

Test added to verify the width of the fixed layout tables with 100%
width, in standards mode.

10:54 PM Changeset in webkit [134016] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r134004.
http://trac.webkit.org/changeset/134004
https://bugs.webkit.org/show_bug.cgi?id=101713

multiple crashes (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):
(WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderThumb):

10:46 PM Changeset in webkit [134015] by timothy@apple.com
  • 4 edits in trunk/Source

Always use a textured window for the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=101693

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController window]): Removed the conditional for a textured window.

Source/WebKit2:

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Removed the conditional for a textured window.

10:46 PM Changeset in webkit [134014] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: stop using cursorCoords in CodeMirrorTextEditor
https://bugs.webkit.org/show_bug.cgi?id=101607

Patch by Jan Keromnes <janx@linux.com> on 2012-11-08
Reviewed by Vsevolod Vlasov.

API changes completing migration to v3.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.revealLine):
(WebInspector.CodeMirrorTextEditor.prototype.selection):

10:39 PM Changeset in webkit [134013] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] about:blank should display the blank page
https://bugs.webkit.org/show_bug.cgi?id=101566

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-08
Reviewed by Laszlo Gombos.

Add a check to return early without prepending http:// scheme, if the
URL is 'about:blank'.

  • EWebLauncher/url_utils.c:

(url_from_user_input):

10:33 PM Changeset in webkit [134012] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed test expectations update.

Unskip and start generating results for fast/images/color-jpeg-with-color-profile.html
on Win to prepare for an upcoming rebaseline.

  • platform/chromium/TestExpectations:
10:30 PM Changeset in webkit [134011] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: make "Other" bar color darker in NMI snapshot.
https://bugs.webkit.org/show_bug.cgi?id=101602

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-08
Reviewed by Vsevolod Vlasov.

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

10:27 PM Changeset in webkit [134010] by alecflett@chromium.org
  • 31 edits in trunk/Source

IndexedDB: switch frontend to use int64_t-based references
https://bugs.webkit.org/show_bug.cgi?id=100426

Reviewed by Tony Chang.

Source/WebCore:

Remove String-based objectStore/index references, obsoleted by
https://bugs.webkit.org/show_bug.cgi?id=100425.

No new tests as this is the second half of a refactor.

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::findIndex):
(IDBObjectStoreMetadata):
(WebCore::IDBObjectStoreMetadata::containsIndex):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • inspector/Inspector-1.0.json:
  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::InspectorIndexedDBAgent::requestData):

  • inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

Source/WebKit/chromium:

Remove implementation stubs from chromium API for
methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425

  • src/IDBObjectStoreBackendProxy.cpp:
  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

10:24 PM Changeset in webkit [134009] by keishi@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
https://bugs.webkit.org/show_bug.cgi?id=93800

Reviewed by Kent Tamura.

We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::close): Set m_closing to true.

10:17 PM Changeset in webkit [134008] by shinyak@chromium.org
  • 4 edits in trunk/Source/WebCore

[Refactoring] Expose collectFeaturesFromSelector from RuleSet.cpp
https://bugs.webkit.org/show_bug.cgi?id=101692

Reviewed by Dimitri Glazkov.

We expose collectFeaturesFromSelector in RuleSet.cpp to use it for collecting ShadowDOM select attribute features.

No new tests, simple refactoring.

  • css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::collectFeaturesFromSelector): Moved from RuleSet.cpp.
(WebCore):

  • css/RuleFeature.h:

(WebCore):
(RuleFeatureSet):

  • css/RuleSet.cpp:

(WebCore::collectFeaturesFromRuleData):

10:02 PM Changeset in webkit [134007] by hayato@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, Unreviewed gardening following r133972.

  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/exif-orientation-expected.png: Added.
9:50 PM Changeset in webkit [134006] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium expectations for svg/repaint/image-with-clip-path.svg.

  • platform/chromium/TestExpectations:
9:42 PM Changeset in webkit [134005] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Make jquery/manipulation.html into one in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=101686

Unreviewed, EFL gardening.

Currently there are three definitions on jquery/manipulation.html case.
As BUG 100636 fixed, we don't need Crash definition anymore.
Therefore, this patch makes this case into one definition without Crash in TestExpectations.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-08

  • platform/efl/TestExpectations:
9:02 PM Changeset in webkit [134004] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Guard calls to WebKitSystemInterface media control drawing functions in RenderThemeMac with PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=101634

Patch by Robert Sesek <rsesek@chromium.org> on 2012-11-08
Reviewed by Adam Barth.

No new tests, just disabling unused code in Chromium port.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):
(WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderThumb):

8:50 PM Changeset in webkit [134003] by hayato@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed, update chromium expectations for tables/.

  • platform/chromium-mac/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
8:34 PM Changeset in webkit [134002] by dpranke@chromium.org
  • 1985 edits
    2139 adds in trunk/LayoutTests

2012-11-08 Dirk Pranke <dpranke@chromium.org>

Unreviewed, update chromium-mac-mountainlion baselines for fast/

Also roll remaining mountainlion-specific failures into the main
TestExpectations file.

  • platform/chromium/TestExpectations:
  • platform/chromium-mac-mountainlion/TestExpectations:
8:21 PM Changeset in webkit [134001] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Coordinated Graphics: Don't send the messages for releasing resources during purging.
https://bugs.webkit.org/show_bug.cgi?id=101685

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-08
Reviewed by Noam Rosenthal.

We don't need to send the messages related to releasing resources to UI Process
during purging, because UI Process already had removed all resources.
This patch gives us reducing slight messaging overhead and increasing readability.

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::purgeBackingStores):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::purgeReleasedImages):
(WebKit::LayerTreeCoordinator::removeTile):
(WebKit::LayerTreeCoordinator::removeUpdateAtlas):
(WebKit::LayerTreeCoordinator::purgeBackingStores):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

8:18 PM Changeset in webkit [134000] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ArrayPrototype.h should have correct indentation

Rubber stamped by Sam Weinig.

  • runtime/ArrayPrototype.h:
8:15 PM Changeset in webkit [133999] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] need to call closePopup at setValueAndClosePopup
https://bugs.webkit.org/show_bug.cgi?id=101568

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-11-08
Reviewed by George Staikos.

When early return occurs, we need to call closePopup
at setValueAndClosePopup function. See the comments
in WebCore/page/PagePopupClient.h. If we have not it,
Webkit thread is held and browser will be unresponsive
in BlackBerry port.

RIM PR 232962
Internally reviewed by Charles Wei.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::setValueAndClosePopup):

7:51 PM Changeset in webkit [133998] by keishi@webkit.org
  • 4 edits in trunk

Enable calendar picker for input types week/month
https://bugs.webkit.org/show_bug.cgi?id=101553

Reviewed by Kent Tamura.

Source/WebCore:

Enabling calendar picker for <input type=week/month>

No new tests. Tests will be added later in Bug 101556 and Bug 101555.

  • rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsCalendarPicker):

LayoutTests:

  • platform/chromium/TestExpectations: Mark week/month appearance tests as needs rebaseline.
7:43 PM Changeset in webkit [133997] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Change the default return value of MediaPlayerPrivate::hasSingleSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=101681

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-11-08
Reviewed by George Staikos.

Since the platform player in BlackBerry disallows resources that come from different origins,
so it's safe to directly returns true here.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin):

7:36 PM Changeset in webkit [133996] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium expectations to remove a duplication.

  • platform/chromium/TestExpectations:
7:03 PM Changeset in webkit [133995] by mark.lam@apple.com
  • 54 edits
    10 moves in trunk/Source

Renamed ...InlineMethods.h files to ...Inlines.h.
https://bugs.webkit.org/show_bug.cgi?id=101145.

Reviewed by Geoffrey Garen.

This is only a refactoring effort to rename the files. There are no
functionality changes.

Source/JavaScriptCore:

  • API/JSObjectRef.cpp:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp:
  • dfg/DFGOperations.cpp:
  • heap/ConservativeRoots.cpp:
  • heap/CopiedBlock.h:
  • heap/CopiedSpace.cpp:
  • heap/CopiedSpaceInlineMethods.h: Removed.
  • heap/CopiedSpaceInlines.h: Copied from Source/JavaScriptCore/heap/CopiedSpaceInlineMethods.h.
  • heap/CopyVisitor.cpp:
  • heap/CopyVisitorInlineMethods.h: Removed.
  • heap/CopyVisitorInlines.h: Copied from Source/JavaScriptCore/heap/CopyVisitorInlineMethods.h.
  • heap/GCThread.cpp:
  • heap/GCThreadSharedData.cpp:
  • heap/HandleStack.cpp:
  • heap/Heap.cpp:
  • heap/HeapRootVisitor.h:
  • heap/MarkStack.cpp:
  • heap/MarkStackInlineMethods.h: Removed.
  • heap/MarkStackInlines.h: Copied from Source/JavaScriptCore/heap/MarkStackInlineMethods.h.
  • heap/SlotVisitor.cpp:
  • heap/SlotVisitor.h:
  • heap/SlotVisitorInlineMethods.h: Removed.
  • heap/SlotVisitorInlines.h: Copied from Source/JavaScriptCore/heap/SlotVisitorInlineMethods.h.
  • jit/HostCallReturnValue.cpp:
  • jit/JIT.cpp:
  • jit/JITArithmetic.cpp:
  • jit/JITArithmetic32_64.cpp:
  • jit/JITCall.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITInlineMethods.h: Removed.
  • jit/JITInlines.h: Copied from Source/JavaScriptCore/jit/JITInlineMethods.h.
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
  • jsc.cpp:
  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayPrototype.cpp:
  • runtime/ButterflyInlineMethods.h: Removed.
  • runtime/ButterflyInlines.h: Copied from Source/JavaScriptCore/runtime/ButterflyInlineMethods.h.
  • runtime/IndexingHeaderInlineMethods.h: Removed.
  • runtime/IndexingHeaderInlines.h: Copied from Source/JavaScriptCore/runtime/IndexingHeaderInlineMethods.h.
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:
  • runtime/JSArray.h:
  • runtime/JSCell.h:
  • runtime/JSObject.cpp:
  • runtime/JSValueInlineMethods.h: Removed.
  • runtime/JSValueInlines.h: Copied from Source/JavaScriptCore/runtime/JSValueInlineMethods.h.
  • runtime/LiteralParser.cpp:
  • runtime/ObjectConstructor.cpp:
  • runtime/Operations.h:
  • runtime/RegExpMatchesArray.cpp:
  • runtime/RegExpObject.cpp:
  • runtime/StringPrototype.cpp:

Source/WebCore:

No new tests.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLEntityParser.cpp:
  • html/parser/HTMLTokenizer.cpp:
  • html/track/WebVTTTokenizer.cpp:
  • xml/parser/CharacterReferenceParserInlineMethods.h: Removed.
  • xml/parser/CharacterReferenceParserInlines.h: Copied from Source/WebCore/xml/parser/CharacterReferenceParserInlineMethods.h.
  • xml/parser/MarkupTokenizerInlineMethods.h: Removed.
  • xml/parser/MarkupTokenizerInlines.h: Copied from Source/WebCore/xml/parser/MarkupTokenizerInlineMethods.h.
  • xml/parser/XMLCharacterReferenceParser.cpp:
  • xml/parser/XMLTokenizer.cpp:
6:52 PM Changeset in webkit [133994] by commit-queue@webkit.org
  • 26 edits in trunk/Source

Unreviewed, rolling out r133984.
http://trac.webkit.org/changeset/133984
https://bugs.webkit.org/show_bug.cgi?id=101684

windows build error. (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

Source/WebCore:

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::getObjectStoreId):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::containsIndex):
(WebCore::IDBDatabaseMetadata::findObjectStore):
(IDBDatabaseMetadata):
(WebCore::IDBDatabaseMetadata::containsObjectStore):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::getIndexId):
(WebCore::IDBObjectStoreBackendImpl::getIndexIds):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):
(WebCore):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(IDBTransactionBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

Source/WebKit/chromium:

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::deleteObjectStore):
(WebKit):
(WebKit::WebIDBDatabaseImpl::transaction):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
(WebKit):
(WebKit::WebIDBObjectStoreImpl::setIndexKeys):
(WebKit::WebIDBObjectStoreImpl::setIndexesReady):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::deleteIndex):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

  • src/WebIDBTransactionImpl.cpp:

(WebKit::WebIDBTransactionImpl::objectStore):
(WebKit):

  • src/WebIDBTransactionImpl.h:
6:49 PM Changeset in webkit [133993] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[QT] css3/line-break should be removed from TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=101562

Unreviewed gardening.

css3/line-break is removed by http://trac.webkit.org/changeset/133644.

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-11-08

  • platform/qt/TestExpectations:
6:40 PM Changeset in webkit [133992] by shinyak@chromium.org
  • 8 edits in trunk/Source/WebCore

HTMLContentElement should preserve parsed CSSSelectorList
https://bugs.webkit.org/show_bug.cgi?id=101543

Reviewed by Dimitri Glazkov.

We would like to preserve CSSSelectorList for select attribute of HTMLContentElement.

Before, we parsed and validated select attribute every time distribution happens. If we preserve the parsed
CSSSelectorList, we can reduce distribution time.

This is also a prepration patch for Bug 101180. It also needs the parsed CSSSelectorList. We don't want to
parse and validate it again.

No new tests, covered by exising tests.

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorQuery::ContentSelectorQuery): We don't parse select attribute here anymore.
if it's already parsed.
(WebCore::ContentSelectorQuery::matches):

  • html/shadow/ContentSelectorQuery.h:

(ContentSelectorQuery):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::isSelectValid):
(WebCore::HTMLContentElement::ensureSelectParsed): If we don't have parsed the current select attribute,
we parse and validate it.
(WebCore::HTMLContentElement::parseAttribute): When select attribute is changed, we have to have a flag enabled
to parse select attrite again.
(WebCore::validateSubSelector): Moved from ContentSelectorQuery.
(WebCore):
(WebCore::validateSelector): Moved from ContentSelectorQuery.
(WebCore::HTMLContentElement::validateSelect):

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):
(WebCore::HTMLContentElement::setSelect):
(WebCore):
(WebCore::HTMLContentElement::selectorList):

  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::emptySelectorList):
(WebCore):

  • html/shadow/HTMLShadowElement.h:

(HTMLShadowElement):
(WebCore::HTMLShadowElement::selectorList):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):

6:04 PM Changeset in webkit [133991] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ArrayConstructor.h should have correct indentation

Rubber stamped by Sam Weinig.

  • runtime/ArrayConstructor.h:
5:57 PM Changeset in webkit [133990] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should know that int == null is always false
https://bugs.webkit.org/show_bug.cgi?id=101665

Reviewed by Oliver Hunt.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

5:54 PM Changeset in webkit [133989] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium expectations for chromium-mac-mountainlion svg failure.

  • platform/chromium/TestExpectations:
5:49 PM Changeset in webkit [133988] by dpranke@chromium.org
  • 873 edits
    879 adds in trunk

Unreviewed, chromium-mac-mountainlion baselines for tables/.

  • platform/chromium/TestExpectations:
  • platform/chromium-mac-mountainlion/TestExpectations:
5:42 PM Changeset in webkit [133987] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Arguments.h should have correct indentation

Rubber stamped by Sam Weinig.

  • runtime/Arguments.h:
5:41 PM Changeset in webkit [133986] by jsbell@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening following r133972.

  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/exif-orientation-expected.png: Added.
5:38 PM Changeset in webkit [133985] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

It should be possible to JIT compile get_by_vals and put_by_vals even if the DFG is disabled.

Reviewed by Oliver Hunt.

  • jit/JITInlineMethods.h:

(JSC::JIT::chooseArrayMode):

5:36 PM Changeset in webkit [133984] by alecflett@chromium.org
  • 26 edits in trunk/Source

IndexedDB: switch frontend to use int64_t-based references
https://bugs.webkit.org/show_bug.cgi?id=100426

Reviewed by Tony Chang.

Source/WebCore:

Remove String-based objectStore/index references, obsoleted by
https://bugs.webkit.org/show_bug.cgi?id=100425.

No new tests as this is the second half of a refactor.

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::findIndex):
(IDBObjectStoreMetadata):
(WebCore::IDBObjectStoreMetadata::containsIndex):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • inspector/Inspector-1.0.json:
  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::InspectorIndexedDBAgent::requestData):

  • inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

Source/WebKit/chromium:

Remove implementation stubs from chromium API for
methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425

  • src/IDBObjectStoreBackendProxy.cpp:
  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

5:34 PM Changeset in webkit [133983] by bashi@chromium.org
  • 4 edits
    2 adds in trunk

[Chromium] Arabic digits should appear left-to-right
https://bugs.webkit.org/show_bug.cgi?id=101440

Reviewed by Tony Chang.

Source/WebCore:

Call hb_buffer_set_direction() to set direction when drawing glyphs or
direction should be overridden. Leave direction setting to HarfBuzz when
WebKit is calculating widths because the direction is LTR by default while
calculating widths. Set script before shaping so that HarfBuzz can estimate
appropriate direction.

Test: fast/text/international/arabic-digits.html

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
Add m_script. This holds the script of the run.
(WebCore::HarfBuzzShaper::shape):
Tell shapeHarfBuzzRuns() to set direction when drawing glyphs or
direction should be overridden.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns):
Set script of HarfBuzzRuns.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
Add an argument that indicates it should set direction.

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:

(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):
(WebCore::HarfBuzzShaper::HarfBuzzRun::script):
(HarfBuzzRun):
(HarfBuzzShaper):

LayoutTests:

Add a test that checks Arabic digits appear in increasing order from left to right.

  • fast/text/international/arabic-digits-expected.html: Added.
  • fast/text/international/arabic-digits.html: Added.
5:33 PM Changeset in webkit [133982] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] WebElement::hasHTMLTagName returns true for non-HTML elements
https://bugs.webkit.org/show_bug.cgi?id=101537

Reviewed by Abhishek Arya.

We should not do ignore-case comparison for tagName, which is always
upper-case and createElementNS(xhtmlNS, "INPUT") doesn't create an
HTMLInputElement object. We need to check if localName is equal to
"input" in this case.

  • src/WebElement.cpp:

(WebKit::WebElement::hasHTMLTagName):

5:31 PM Changeset in webkit [133981] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[TexMap] Remove contentsLayer() in GraphicsLayerTextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=101658

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-08
Reviewed by Noam Rosenthal.

GraphicsLayerTextureMapper::contentsLayer() is duplicated to
GraphicsLayer::platformLayer(), so we remove it.

No new tests, this is just a refactor.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(WebCore::GraphicsLayerTextureMapper::platformLayer):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::flushCompositingStateSelf):

5:27 PM Changeset in webkit [133980] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

op_call should have LLInt call link info even if the DFG is disabled
https://bugs.webkit.org/show_bug.cgi?id=101672

Reviewed by Oliver Hunt.

Get rid of the evil uses of fall-through.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

5:25 PM Changeset in webkit [133979] by jpetsovits@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Replace checkerboard with page background color.
https://bugs.webkit.org/show_bug.cgi?id=101652
RIM PR 188235

Reviewed by George Staikos.

In order to do this, we introduce a new member variable for
BackingStore because when blitting, we can't access the
page background color in a threadsafe way.

Solid background color fill is still only used for public builds.
Developers and beta testers should still see checkerboard and
do something about it.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::fillWindow):
(BlackBerry::WebKit::BackingStorePrivate::webPageBackgroundColorUserInterfaceThread):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::setWebPageBackgroundColor):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

5:21 PM Changeset in webkit [133978] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Some more gardening after r133898.

  • platform/efl/TestExpectations:
5:20 PM Changeset in webkit [133977] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Null check URL key entries into WebHistory hash table.
https://bugs.webkit.org/show_bug.cgi?id=101664
<rdar://problem/12440852>

Reviewed by Brady Eidson.

Sometimes the _entriesByURL hash table used to keep track of web history is erroneously passed in null key entries, which causes an exception to fire.
This prevents the desired page navigation from taking effect. This is a workaround for the problem.
Ideally we would figure out where the null values for the key are coming from but for now we'll just set it to "" to prevent the exception from being thrown
so that navigation can continue as expected.

  • History/WebHistory.mm:

(-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]):

5:15 PM Changeset in webkit [133976] by benjamin@webkit.org
  • 96 edits in trunk/Source

Improve the use of AtomicString with literals
https://bugs.webkit.org/show_bug.cgi?id=101298

Reviewed by Darin Adler.

Fix a bunch of cases of AtomicString with literals:
-Do not create temporary AtomicString to perform a comparison, that is very wasteful.
-Use the ConstructFromLiteral constructor whenever it makes sense.
-Make "x-frame-options" static instead of creating it for each response.
-Use ASCIILiteral() instead of AtomicString() in EventHandler, the function takes a String,

not an AtomicString.

  • Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::supplementName):

  • Modules/battery/NavigatorBattery.cpp:

(WebCore::NavigatorBattery::from):

  • Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:

(WebCore::DraggedIsolatedFileSystem::supplementName):

  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::from):

  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::supplementName):

  • Modules/geolocation/NavigatorGeolocation.cpp:

(WebCore::NavigatorGeolocation::from):

  • Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::from):

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::directionNext):
(WebCore::IDBCursor::directionNextUnique):
(WebCore::IDBCursor::directionPrev):
(WebCore::IDBCursor::directionPrevUnique):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::readyState):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::modeReadOnly):
(WebCore::IDBTransaction::modeReadWrite):
(WebCore::IDBTransaction::modeVersionChange):
(WebCore::IDBTransaction::modeReadOnlyLegacy):
(WebCore::IDBTransaction::modeReadWriteLegacy):

  • Modules/indexeddb/PageGroupIndexedDatabase.cpp:

(WebCore::PageGroupIndexedDatabase::from):

  • Modules/intents/DOMWindowIntents.cpp:

(WebCore::DOMWindowIntents::from):

  • Modules/mediastream/UserMediaController.cpp:

(WebCore::UserMediaController::supplementName):

  • Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::NavigatorContentUtils::supplementName):

  • Modules/networkinfo/NavigatorNetworkInfoConnection.cpp:

(WebCore::NavigatorNetworkInfoConnection::from):

  • Modules/networkinfo/NetworkInfoController.cpp:

(WebCore::NetworkInfoController::supplementName):

  • Modules/notifications/DOMWindowNotifications.cpp:

(WebCore::DOMWindowNotifications::from):

  • Modules/notifications/NotificationController.cpp:

(WebCore::NotificationController::supplementName):

  • Modules/quota/DOMWindowQuota.cpp:

(WebCore::DOMWindowQuota::from):

  • Modules/speech/SpeechRecognitionController.cpp:

(WebCore::SpeechRecognitionController::supplementName):

  • Modules/vibration/Vibration.cpp:

(WebCore::Vibration::supplementName):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::invalidStatus):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
(WebCore::AccessibilityRenderObject::ariaLiveRegionRelevant):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedSecurityCheck):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

  • dom/ContextFeatures.cpp:

(WebCore::ContextFeatures::supplementName):

  • dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::supplementName):

  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::supplementName):

  • dom/Element.cpp:

(WebCore::Element::webkitRegionOverset):

  • dom/MutationRecord.cpp:
  • html/FileInputType.cpp:

(WebCore::UploadButtonElement::shadowPseudoId):

  • html/FormController.cpp:

(WebCore::SavedFormState::getReferencedFilePaths):
(WebCore::FormKeyGenerator::formKey):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::formControlType):

  • html/HTMLDetailsElement.cpp:

(WebCore::summaryQuerySelector):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::formControlType):

  • html/HTMLKeygenElement.cpp:

(WebCore::KeygenSelectElement::shadowPseudoId):
(WebCore::HTMLKeygenElement::formControlType):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::formControlType):

  • html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::formControlType):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::formControlType):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::formControlType):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::directionString):

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::DateTimeEditElement):

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeAMPMFieldElement::create):
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeHourFieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeSymbolicMonthFieldElement::create):
(WebCore::DateTimeWeekFieldElement::create):
(WebCore::DateTimeYearFieldElement::create):

  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::shadowPseudoId):

  • html/shadow/ImageInnerElement.cpp:

(WebCore::ImageInnerElement::shadowPseudoId):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::shadowPseudoId):
(WebCore::MediaControlTimelineContainerElement::shadowPseudoId):
(WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId):
(WebCore::MediaControlStatusDisplayElement::shadowPseudoId):
(WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId):
(WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId):
(WebCore::MediaControlPlayButtonElement::shadowPseudoId):
(WebCore::MediaControlOverlayPlayButtonElement::shadowPseudoId):
(WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId):
(WebCore::MediaControlSeekBackButtonElement::shadowPseudoId):
(WebCore::MediaControlRewindButtonElement::shadowPseudoId):
(WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
(WebCore::MediaControlTimelineElement::shadowPseudoId):
(WebCore::MediaControlVolumeSliderElement::shadowPseudoId):
(WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId):
(WebCore::MediaControlFullscreenButtonElement::shadowPseudoId):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId):
(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId):
(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId):
(WebCore::MediaControlTextTrackContainerElement::shadowPseudoId):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::shadowPseudoId):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlPanelEnclosureElement::shadowPseudoId):
(WebCore::MediaControlRootElementChromium::shadowPseudoId):

  • html/shadow/MediaControlRootElementChromiumAndroid.cpp:

(WebCore::MediaControlOverlayEnclosureElement::shadowPseudoId):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterInnerElement::shadowPseudoId):
(WebCore::MeterBarElement::shadowPseudoId):
(WebCore::MeterValueElement::shadowPseudoId):

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressInnerElement::shadowPseudoId):
(WebCore::ProgressBarElement::shadowPseudoId):
(WebCore::ProgressValueElement::shadowPseudoId):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbShadowPseudoId):
(WebCore::mediaSliderThumbShadowPseudoId):
(WebCore::SliderContainerElement::shadowPseudoId):

  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::shadowPseudoId):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
(WebCore::SearchFieldCancelButtonElement::shadowPseudoId):
(WebCore::InputFieldSpeechButtonElement::shadowPseudoId):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/PrerendererClient.cpp:

(WebCore::PrerendererClient::supplementName):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::updateResponseAfterRevalidation):

  • page/DOMWindowPagePopup.cpp:

(WebCore::DOMWindowPagePopup::supplementName):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handlePasteGlobalSelection):
(WebCore::focusDirectionForKey):

  • page/SpeechInput.cpp:

(WebCore::SpeechInput::supplementName):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateKeyframeAnimations):

  • platform/graphics/FontCache.cpp:

(WebCore::alternateFamilyName):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::applicationOctetStream):
(WebCore::textPlain):
(WebCore::codecs):

  • platform/graphics/chromium/FontCacheAndroid.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::effectName):

  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::effectName):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/skia/FontCacheSkia.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/wx/FontCacheWx.cpp:

(WebCore::FontCache::getSimilarFontPlatformData):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::ResourceResponseBase::hasCacheValidatorFields):
(WebCore::ResourceResponseBase::date):
(WebCore::ResourceResponseBase::age):
(WebCore::ResourceResponseBase::expires):
(WebCore::ResourceResponseBase::lastModified):
(WebCore::ResourceResponseBase::isAttachment):

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::getAvgCharWidth):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::getAvgCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):

  • svg/SVGAnimateColorElement.cpp:

(WebCore::attributeValueIsCurrentColor):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::rotateMode):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::setCalcMode):
(WebCore::SVGAnimationElement::setAttributeType):
(WebCore::SVGAnimationElement::isAdditive):
(WebCore::SVGAnimationElement::isAccumulated):
(WebCore::inheritsFromProperty):

  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier):
(WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier):
(WebCore::SVGFEConvolveMatrixElement::orderXIdentifier):
(WebCore::SVGFEConvolveMatrixElement::orderYIdentifier):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier):
(WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier):

  • svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::stdDeviationXIdentifier):
(WebCore::SVGFEDropShadowElement::stdDeviationYIdentifier):

  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier):
(WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier):

  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::radiusXIdentifier):
(WebCore::SVGFEMorphologyElement::radiusYIdentifier):

  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier):
(WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier):

  • svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier):
(WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier):

  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::filterResXIdentifier):
(WebCore::SVGFilterElement::filterResYIdentifier):

  • svg/SVGLangSpace.cpp:

(WebCore::SVGLangSpace::xmlspace):
(WebCore::SVGLangSpace::addSupportedAttributes):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::orientTypeIdentifier):
(WebCore::SVGMarkerElement::orientAngleIdentifier):
(WebCore::SVGMarkerElement::synchronizeOrientType):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::contentScriptType):
(WebCore::SVGSVGElement::contentStyleType):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::type):
(WebCore::SVGStyleElement::media):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::collectStyleForAttribute):

  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::viewBoxIdentifier):
(WebCore::SVGViewSpec::preserveAspectRatioIdentifier):
(WebCore::SVGViewSpec::transformIdentifier):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseClockValue):
(WebCore::SVGSMILElement::restart):
(WebCore::SVGSMILElement::fill):
(WebCore::SVGSMILElement::repeatCount):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::from):

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::processXMLEntity):

5:12 PM Changeset in webkit [133975] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Improve effectiveness of function-level caching
https://bugs.webkit.org/show_bug.cgi?id=101667

Reviewed by Filip Pizlo.

Added a random-eviction based cache for unlinked functions, and switch
UnlinkedFunctionExecutable's code references to Weak<>, thereby letting
us remove the explicit UnlinkedFunctionExecutable::clearCode() calls that
were being triggered by GC.

Refactored the random eviction part of the CodeCache into a separate data
structure so that I didn't have to duplicate the code again, and then used
that for the new function cache.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::visitChildren):
(JSC::UnlinkedFunctionExecutable::codeBlockFor):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::clearCodeForRecompilation):
(UnlinkedFunctionExecutable):

  • debugger/Debugger.cpp:
  • runtime/CodeCache.cpp:

(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode):
(JSC):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::clearUnlinkedCodeForRecompilationIfNotCompiling):
(JSC::FunctionExecutable::clearCode):

  • runtime/Executable.h:

(FunctionExecutable):

5:01 PM Changeset in webkit [133974] by Beth Dakin
  • 7 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=101644
Fixed header on Facebook news feed becomes detached from top of
viewport after rubber band scrolling
-and corresponding-
<rdar://problem/12651944>

Reviewed by Simon Fraser.

Source/WebCore:

There is code to handle this for non-threaded scrolling on FrameView.
This patch moves most of that code into a convenience function on
ScrollingCoordinator.

Have FrameView::scrollOffsetForFixedPosition() call
WebCore::scrollOffsetForFixedPosition() with all the right
parameters.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollOffsetForFixedPosition):

Here's where all the math happens.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::fixedPositionScrollOffset):
(WebCore::scrollOffsetForFixedPosition):

The viewportRect in these three places needs to have the
adjusted-for-fixed offset.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):

LayoutTests:

New test ensures that negative offsets will not make their way into
the FixedPositionViewportConstraints.

  • platform/mac/tiled-drawing/fixed/negative-scroll-offset-expected.txt: Added.
  • platform/mac/tiled-drawing/fixed/negative-scroll-offset.html: Added.
4:20 PM Changeset in webkit [133973] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/JavaScriptCore

Merged r125806. <rdar://problem/12486139>

4:19 PM Changeset in webkit [133972] by hclam@chromium.org
  • 5 edits
    5 deletes in trunk

[chromium] Deferred image decoding fails with image orientation
https://bugs.webkit.org/show_bug.cgi?id=101648

Reviewed by Stephen White.

Source/WebCore:

When an image is deferred save the orientation state. Once this state
is cached it can be used to reply future queries since this state is
static.

No new tests but platform/chromium/virtual/deferred/fast/images/image-orientation.html is passing now.

  • platform/graphics/chromium/DeferredImageDecoder.cpp:

(WebCore::DeferredImageDecoder::DeferredImageDecoder):
(WebCore::DeferredImageDecoder::frameBufferAtIndex):
(WebCore::DeferredImageDecoder::orientation):

  • platform/graphics/chromium/DeferredImageDecoder.h:

(DeferredImageDecoder):

LayoutTests:

Update test expectations and baselines accordingly since these two
tests are now passing with deferred image decoding.

fast/images/exif-orientation-image-document.html
fast/images/exif-orientation.html

  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Removed.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Removed.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Removed.
  • platform/chromium/TestExpectations:
4:15 PM Changeset in webkit [133971] by fpizlo@apple.com
  • 6 edits
    1 add in trunk/Source/JavaScriptCore

DFG constant folding and CFG simplification should be smart enough to know that if a logical op's operand is proven to have a non-masquerading structure then it always evaluates to true
https://bugs.webkit.org/show_bug.cgi?id=101511

Reviewed by Oliver Hunt.

To make life easier, this moves BranchDirection into BasicBlock so that after
running the CFA, we always know, for each block, what direction the CFA
proved. CFG simplification now both uses and preserves cfaBranchDirection in
its transformations.

Also made both LogicalNot and Branch check whether the operand is a known cell
with a known structure, and if so, made them do the appropriate folding.

5% speed-up on V8/raytrace because it makes raytrace's own null checks
evaporate (i.e. idioms like 'if (!x) throw "unhappiness"') thanks to the fact
that we were already doing structure check hoisting.

(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):

  • dfg/DFGBranchDirection.h: Added.

(DFG):
(JSC::DFG::branchDirectionToString):
(JSC::DFG::isKnownDirection):
(JSC::DFG::branchCondition):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

4:12 PM Changeset in webkit [133970] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

DocumentLoader: Shrink-to-fit the ResourceResponse vector after loading completes.
<http://webkit.org/b/101657>

Reviewed by Anders Carlsson.

Shrink DocumentLoader::m_responses to exact size when we stop adding responses to it,
as we know it won't grow after that.

520kB progression on Membuster3.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopRecordingResponses):

4:10 PM Changeset in webkit [133969] by Lucas Forschler
  • 6 edits
    2 copies in branches/safari-536.28-branch

Merged r125695. <rdar://problem/12665292>

4:09 PM Changeset in webkit [133968] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

[CSS Exclusions] Polygon with horizontal bottom edges returns incorrect segments
https://bugs.webkit.org/show_bug.cgi?id=100874

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-08
Reviewed by Dirk Schulze.

Source/WebCore:

Revised the way that computeXIntersections() handles intersections with horizotal polygon edges.
Deciding if a vertex intersection corresponds to a polygon "edge crossing", i.e. a change from inside
to outside or outside to inside, now depends on which side of the horizontal line the function's
y parameter corresponds to. If the y corresponds to the top of the line, then isaMinY the parameter
is true, and an intersection with a horizontal edge is only considered to be an edge crossing if
if the inside of the polygon is just below the horizontal edge. When isMinY is false then the inside
of the polygon must be just above the horizontal edge.

Tests: fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-003.html

fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-004.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::getVertexIntersectionVertices): Corrected two cases where the next/previous vertex was determined incorrectly.
(WebCore::ExclusionPolygon::computeXIntersections): Added a bool isMinY parameter which specifies if the y parameter corresponds to the top or bottom a horizontal line.
(WebCore::ExclusionPolygon::getExcludedIntervals): Added the new computeXIntersections() parameter.
(WebCore::ExclusionPolygon::getIncludedIntervals): Ditto.

  • rendering/ExclusionPolygon.h:

(WebCore::ExclusionPolygonEdge::previousEdge): Corrected the previousEdge() function.

LayoutTests:

Added two additional tests for rectilinear polygons, where the tops and bottoms
of lines intersect the polygons' horizontal edges. More tests of this kind will
be needed when exclusion layout supports polygons that break horizontal lines up
into more than one segment.

  • fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-003-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-003.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-004-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-004.html: Added.
4:07 PM Changeset in webkit [133967] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Unused parameters on LayerTreeRenderer.cpp
https://bugs.webkit.org/show_bug.cgi?id=101653

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-08
Reviewed by Noam Rosenthal.

Because the 'tileID' parameter is not used now,
comment out it to fix build warning -Wunused-parameter

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::removeBackingStoreIfNeeded):

4:05 PM Changeset in webkit [133966] by commit-queue@webkit.org
  • 4 edits
    8 adds in trunk

[JSC] HTML extensions to String.prototype should escape " as &quot; in argument values
https://bugs.webkit.org/show_bug.cgi?id=90667

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-08
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Escape quotation mark as &quot; in argument values to:

  • String.prototype.anchor(name)
  • String.prototype.fontcolor(color)
  • String.prototype.fontsize(size)
  • String.prototype.link(href)

This behavior matches Chromium/V8 and Firefox/Spidermonkey
implementations and is requited by:
http://mathias.html5.org/specs/javascript/#escapeattributevalue

This also fixes a potential security risk (XSS vector).

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):

LayoutTests:

Add layout test coverage for the following String.prototype methods:

  • String.prototype.anchor(name)
  • String.prototype.fontcolor(color)
  • String.prototype.fontsize(size)
  • String.prototype.link(href)

Those tests also check that the quotation mark is correctly escaped
in argument values to prevent potential exploits.

  • fast/js/string-anchor-expected.txt: Added.
  • fast/js/string-anchor.html: Added.
  • fast/js/string-fontcolor-expected.txt: Added.
  • fast/js/string-fontcolor.html: Added.
  • fast/js/string-fontsize-expected.txt: Added.
  • fast/js/string-fontsize.html: Added.
  • fast/js/string-link-expected.txt: Added.
  • fast/js/string-link.html: Added.
  • platform/chromium/TestExpectations: Skip new tests for chromium port due

to http://code.google.com/p/v8/issues/detail?id=2218

3:50 PM Changeset in webkit [133965] by jsbell@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening. Added missing *-expected.txt following rebaselines.

  • platform/chromium-mac/fast/css/text-overflow-input-expected.txt: Added.
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.txt: Added.
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.txt: Added.
3:50 PM Changeset in webkit [133964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Disable cookies on file://
https://bugs.webkit.org/show_bug.cgi?id=101646

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-08
Reviewed by Rob Buis.

Disabling cookies on file and local in the browser app.

PR 239779

Tested by trying to set and retrieve cookies on WI while browsing
files on the file scheme.

  • platform/blackberry/CookieManager.cpp:

(WebCore):
(WebCore::shouldIgnoreScheme):
(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::checkAndTreatCookie):

3:47 PM Changeset in webkit [133963] by jsbell@chromium.org
  • 7 edits in trunk/Source

Expose snapshots in platform/leveldb wrapper API
https://bugs.webkit.org/show_bug.cgi?id=100786

Reviewed by Tony Chang.

Source/WebCore:

Expose leveldb "snapshots" in the LevelDB API. A snapshot lets you observe the database
as it was when the snapshot was taken. This can be used to implement parallel transactions,
e.g. where a read transaction won't see updates made by a later write transaction.

Tests: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.Transaction*'

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBSnapshot::LevelDBSnapshot): New (but for now internal-only) wrapper type.
(WebCore):
(WebCore::LevelDBSnapshot::~LevelDBSnapshot): Release the leveldb::Snapshot.
(WebCore::LevelDBDatabase::get): Optional snapshot argument, for use by transactions.
(WebCore::LevelDBDatabase::createIterator): Ditto.

  • platform/leveldb/LevelDBDatabase.h:

(leveldb):
(WebCore):
(LevelDBSnapshot):
(LevelDBDatabase):

  • platform/leveldb/LevelDBTransaction.cpp:

(WebCore::LevelDBTransaction::LevelDBTransaction): Initialize a snapshot.
(WebCore::LevelDBTransaction::get):
(WebCore::LevelDBTransaction::TransactionIterator::TransactionIterator):

  • platform/leveldb/LevelDBTransaction.h:

(LevelDBTransaction):

Source/WebKit/chromium:

Add unit tests for transactions/snapshots.

  • tests/LevelDBTest.cpp:

(WebCore::encodeString): Don't append to pre-sized vector.
(WebCore::TEST):
(WebCore):

3:41 PM Changeset in webkit [133962] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Some more gardening after r133898.

  • platform/efl/TestExpectations:
3:34 PM Changeset in webkit [133961] by commit-queue@webkit.org
  • 9 edits in trunk

[EFL][WK2] Add proper support for fullscreen API to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=101615

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::enterFullScreen):

  • UIProcess/API/efl/ewk_security_origin.cpp:

(EwkSecurityOrigin::EwkSecurityOrigin):

  • UIProcess/API/efl/ewk_security_origin_private.h:

(EwkSecurityOrigin::create): Add factory method to construct a
EwkSecurityOrigin from a KURL.
(EwkSecurityOrigin):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_fullscreen_exit): Add public API function to exit
fullscreen mode.

  • UIProcess/API/efl/ewk_view.h: Add security origin parameter

to fullscreen_enter smart function since this information is
useful to the user agent.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(fullScreenCallback):
(fullScreenExitCallback):
(TEST_F):

Tools:

Implement fullscreen API support in MiniBrowser. When entering
fullscreen a popup is shown to notify the user that something
is displayed in fullscreen and to advertise that the Escape
key can be used to exit fullscreen. This behavior is according
to specification.

  • MiniBrowser/efl/main.c:

(on_key_down):
(on_fullscreen_accept):
(on_fullscreen_deny):
(on_fullscreen_enter):
(on_fullscreen_exit):
(window_create):

3:32 PM Changeset in webkit [133960] by jsbell@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening - rebaseline a couple of tests for lion.

  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/basic-textareas-expected.png: Added.
3:32 PM Changeset in webkit [133959] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

HeapStatistics::s_pauseTimeStarts and s_pauseTimeEnds should be Vectors
https://bugs.webkit.org/show_bug.cgi?id=101651

Reviewed by Andreas Kling.

HeapStatistics uses Deques when Vectors would work just as good.

  • heap/HeapStatistics.cpp:
  • heap/HeapStatistics.h:

(HeapStatistics):

3:08 PM Changeset in webkit [133958] by Lucas Forschler
  • 3 edits
    1 copy in branches/safari-536.28-branch

Merged r125597. <rdar://problem/12516348>

3:04 PM Changeset in webkit [133957] by beidson@apple.com
  • 17 edits
    3 copies
    1 add in trunk/Source

Have NetworkProcess do the actual loading of subresources.
https://bugs.webkit.org/show_bug.cgi?id=101640

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests (No change in behavior in any configuration we test.)

  • WebCore.exp.in:
  • loader/ResourceBuffer.h: Virtualize a few methods for ports to override.

Source/WebKit2:

This adds actual loading of subresources in the NetworkProcess.

Currently a resource just gets its entire buffer of data built up and then delivered to the WebProcess in one chunk.

Many FIXMEs point the path towards much better behavior.

Project file stuff:

  • WebKit2.xcodeproj/project.pbxproj:

Add a new Logging channel for scheduling so the one for loading can be separate:

  • Platform/Logging.cpp:
  • Platform/Logging.h:

Add an enhancement FIXME:

  • NetworkProcess/HostRecord.cpp:

(WebKit::HostRecord::remove):

NetworkRequest now derives from ResourceHandleClient and does actual loading, messaging WebProcess as it does:

  • NetworkProcess/NetworkRequest.cpp:

(WebKit::NetworkRequest::NetworkRequest):
(WebKit::NetworkRequest::~NetworkRequest):
(WebKit::NetworkRequest::start):
(WebKit::requestsToStopMutex):
(WebKit::requestsToStop):
(WebKit::NetworkRequest::scheduleStopOnMainThread): Stop
(WebKit::NetworkRequest::performStops):
(WebKit::NetworkRequest::stop): Does NetworkRequest cleanup that happens no matter the state of the network load.
(WebKit::NetworkRequest::didReceiveResponse):
(WebKit::NetworkRequest::didReceiveData):
(WebKit::NetworkRequest::didFinishLoading):
(WebKit::NetworkRequest::didFail):

  • NetworkProcess/NetworkRequest.h:

Change some logging and now invalid asserts, as well as starting requests in-process instead of relying on WebProcess:

  • NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::scheduleNetworkRequest):
(WebKit::NetworkResourceLoadScheduler::addLoadInProgress):
(WebKit::NetworkResourceLoadScheduler::removeLoadIdentifier):
(WebKit::NetworkResourceLoadScheduler::crossOriginRedirectReceived):
(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
(WebKit::NetworkResourceLoadScheduler::servePendingRequestsForHost):
(WebKit::NetworkResourceLoadScheduler::removeScheduledLoadIdentifiers):
(WebKit::NetworkResourceLoadScheduler::scheduleRemoveLoadIdentifier):

  • NetworkProcess/NetworkResourceLoadScheduler.h:

(NetworkResourceLoadScheduler):

Add a "ShareableResource" which includes a SharedMemory block, an offset into that block, and a size:

  • Shared/ShareableResource.cpp: Added.

(WebKit::ShareableResource::Handle::Handle):
(WebKit::ShareableResource::Handle::encode):
(WebKit::ShareableResource::Handle::decode):
(WebKit::ShareableResource::create):
(WebKit::ShareableResource::ShareableResource):
(WebKit::ShareableResource::~ShareableResource):
(WebKit::ShareableResource::createHandle):
(WebKit::ShareableResource::data):
(WebKit::ShareableResource::size):

  • Shared/ShareableResource.h:

(WebKit::ShareableResource::Handle::isNull):
(WebKit::ShareableResource::Handle::size):

Add an implementation of WebCore::ResourceBuffer that wraps a ShareableResource instead of a SharedBuffer:

  • Shared/WebResourceBuffer.cpp:

(WebKit::WebResourceBuffer::WebResourceBuffer):
(WebKit::WebResourceBuffer::~WebResourceBuffer):
(WebKit::WebResourceBuffer::data):
(WebKit::WebResourceBuffer::size):

  • Shared/WebResourceBuffer.h:

(WebResourceBuffer):
(WebKit::WebResourceBuffer::create):

Add messaging that responds to resource load events from the NetworkProcess and passes them to the scheduler:

  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveResponse):
(WebKit::NetworkProcessConnection::didReceiveResource):
(WebKit::NetworkProcessConnection::didFailResourceLoad):

  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.messages.in:

Takes resource load events passed from the NetworkProcess and hands them off directly to WebCore ResourceLoaders:

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad): Update some logging.
(WebKit::WebResourceLoadScheduler::addMainResourceLoad): Ditto.
(WebKit::WebResourceLoadScheduler::remove): Ditto.
(WebKit::WebResourceLoadScheduler::crossOriginRedirectReceived): Ditto.
(WebKit::WebResourceLoadScheduler::servePendingRequests): Ditto.
(WebKit::WebResourceLoadScheduler::didReceiveResponse): Call through to ResourceLoader.
(WebKit::WebResourceLoadScheduler::didReceiveResource): Ditto.
(WebKit::WebResourceLoadScheduler::didFailResourceLoad): Ditto.

  • WebProcess/Network/WebResourceLoadScheduler.h:
2:55 PM Changeset in webkit [133956] by fpizlo@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

DFG should not assume that something is a double just because it might be undefined
https://bugs.webkit.org/show_bug.cgi?id=101438

Reviewed by Oliver Hunt.

This changes all non-bitop arithmetic to (a) statically expect that variables are
defined prior to use in arithmetic and (b) not fall off into double paths just
because a value may not be a number. This is accomplished with two new notions of
speculation:

shouldSpeculateIntegerExpectingDefined: Should we speculate that the value is an
integer if we ignore undefined (i.e. SpecOther) predictions?

shouldSpeculateIntegerForArithmetic: Should we speculate that the value is an
integer if we ignore non-numeric predictions?

This is a ~2x speed-up on programs that seem to our prediction propagator to have
paths in which otherwise numeric variables are undefined.

  • bytecode/SpeculatedType.h:

(JSC::isInt32SpeculationForArithmetic):
(JSC):
(JSC::isInt32SpeculationExpectingDefined):
(JSC::isDoubleSpeculationForArithmetic):
(JSC::isNumberSpeculationExpectingDefined):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::mulShouldSpeculateInteger):
(JSC::DFG::Graph::negateShouldSpeculateInteger):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
(JSC::DFG::Graph::mulImmediateShouldSpeculateInteger):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateIntegerForArithmetic):
(Node):
(JSC::DFG::Node::shouldSpeculateIntegerExpectingDefined):
(JSC::DFG::Node::shouldSpeculateDoubleForArithmetic):
(JSC::DFG::Node::shouldSpeculateNumberExpectingDefined):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithMod):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_div):

2:37 PM Changeset in webkit [133955] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk

Coordinated Graphics: Remove an invisible TiledBackingStore of CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=101424

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-08
Reviewed by Noam Rosenthal.

Source/WebCore:

This patch adds ASSERT to TextureMapperLayer while fixing this bug in
WebKit2.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelf):

Source/WebKit2:

We must remove an invisible TiledBackingStore of CoordinatedGraphicsLayer.
Currently, CoordinatedGraphicsLayer only removes a TiledBackingStore if
!drawsContent() while TextureMapperLayer::updateBackingStore() removes a backing

store if (!m_state.drawsContent
!m_state.contentsVisible m_size.isEmpty()).

CoordinatedGraphicsLayer must have the same behavior.

In addition, this patch makes LayerTreeRenderer remove a backing store from
GraphicsLayerTextureMapper when CoordinatedBackingStore does not have any tiles.

Test: compositing/nested-direct-image-compositing.html

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::removeTile):
(WebKit::CoordinatedBackingStore::isEmpty):
(WebKit):
(WebKit::CoordinatedBackingStore::commitTileOperations):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(CoordinatedBackingStore):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::removeBackingStoreIfNeeded):
(WebKit):
(WebKit::LayerTreeRenderer::removeTile):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::adjustContentsScale):

LayoutTests:

Coordinated Graphics had a bug when a compositing div has a compositing
img with an absolute position property. This test is added to prevent from
a regression.

  • compositing/nested-direct-image-compositing-expected.png: Added.
  • compositing/nested-direct-image-compositing-expected.txt: Added.
  • compositing/nested-direct-image-compositing.html: Added.
2:35 PM Changeset in webkit [133954] by jsbell@chromium.org
  • 20 edits in trunk/Source/WebCore

Unreviewed, rolling out r133945.
http://trac.webkit.org/changeset/133945
https://bugs.webkit.org/show_bug.cgi?id=101645

Numerous layout and unit test failures (Requested by
jsbell|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::V8Float64Array::toNative):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::toNative):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::toNative):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::toNative):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::toNative):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::V8TestException::toNative):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::toNative):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::toNative):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::toNative):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::V8TestNode::toNative):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::V8TestObj::toNative):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::toNative):

  • bindings/v8/NPV8Object.cpp:

(WebCore::v8ObjectToNPObject):
(WebCore::npCreateV8ScriptObject):

  • bindings/v8/V8Collection.h:

(WebCore::toNativeCollection):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::isWrapperOfType):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::setDOMWrapper):
(WebCore::V8DOMWrapper::clearDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore::toNative):
(WebCore::toWrapperTypeInfo):

2:28 PM Changeset in webkit [133953] by fpizlo@apple.com
  • 87 edits
    2 adds in trunk/Source

JSC should infer when indexed storage contains only integers or doubles
https://bugs.webkit.org/show_bug.cgi?id=98606

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This adds two new indexing types: int32 and double. It also adds array allocation profiling,
which allows array allocations to converge to allocating arrays using those types to which
those arrays would have been converted.

20% speed-up on navier-stokes. 40% speed-up on various Kraken DSP tests. Some slow-downs too,
but a performance win overall on all benchmarks we track.

  • API/JSObjectRef.cpp:

(JSObjectMakeArray):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/AbstractMacroAssembler.h:

(JumpList):
(JSC::AbstractMacroAssembler::JumpList::JumpList):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchDouble):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::jnp):
(X86Assembler):
(JSC::X86Assembler::X86InstructionFormatter::emitRex):

  • bytecode/ArrayAllocationProfile.cpp: Added.

(JSC):
(JSC::ArrayAllocationProfile::updateIndexingType):

  • bytecode/ArrayAllocationProfile.h: Added.

(JSC):
(ArrayAllocationProfile):
(JSC::ArrayAllocationProfile::ArrayAllocationProfile):
(JSC::ArrayAllocationProfile::selectIndexingType):
(JSC::ArrayAllocationProfile::updateLastAllocation):
(JSC::ArrayAllocationProfile::selectIndexingTypeFor):
(JSC::ArrayAllocationProfile::updateLastAllocationFor):

  • bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::updatedObservedArrayModes):
(JSC):

  • bytecode/ArrayProfile.h:

(JSC):
(JSC::arrayModesInclude):
(JSC::shouldUseSlowPutArrayStorage):
(JSC::shouldUseFastArrayStorage):
(JSC::shouldUseContiguous):
(JSC::shouldUseDouble):
(JSC::shouldUseInt32):
(ArrayProfile):

  • bytecode/ByValInfo.h:

(JSC::isOptimizableIndexingType):
(JSC::jitArrayModeForIndexingType):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC):
(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllArrayPredictions):
(JSC::CodeBlock::updateAllPredictions):
(JSC::CodeBlock::shouldOptimizeNow):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::numberOfArrayAllocationProfiles):
(JSC::CodeBlock::addArrayAllocationProfile):
(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllArrayPredictions):

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • bytecode/Instruction.h:

(JSC):
(JSC::Instruction::Instruction):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/SpeculatedType.h:

(JSC):
(JSC::isRealNumberSpeculation):

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

  • bytecode/UnlinkedCodeBlock.h:

(JSC):
(JSC::UnlinkedCodeBlock::addArrayAllocationProfile):
(JSC::UnlinkedCodeBlock::numberOfArrayAllocationProfiles):
(UnlinkedCodeBlock):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::newArrayAllocationProfile):
(JSC):
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitExpectedFunctionSnippet):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::refine):
(DFG):
(JSC::DFG::ArrayMode::alreadyChecked):
(JSC::DFG::arrayTypeToString):

  • dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::withType):
(ArrayMode):
(JSC::DFG::ArrayMode::withTypeAndConversion):
(JSC::DFG::ArrayMode::usesButterfly):
(JSC::DFG::ArrayMode::isSpecific):
(JSC::DFG::ArrayMode::supportsLength):
(JSC::DFG::ArrayMode::arrayModesThatPassFiltering):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getArrayMode):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGCallArrayAllocatorSlowPathGenerator.h:

(JSC::DFG::CallArrayAllocatorSlowPathGenerator::generateInternal):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::generateInternal):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::byValIsPure):

  • dfg/DFGNode.h:

(NewArrayBufferData):
(JSC::DFG::Node::hasIndexingType):
(Node):
(JSC::DFG::Node::indexingType):
(JSC::DFG::Node::setIndexingType):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateJSArray):
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
(DFG):
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(SpeculateIntegerOperand):
(JSC::DFG::SpeculateIntegerOperand::use):
(SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::use):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.h:

(JSC::JIT::emitInt32GetByVal):
(JIT):
(JSC::JIT::emitInt32PutByVal):
(JSC::JIT::emitDoublePutByVal):
(JSC::JIT::emitContiguousPutByVal):

  • jit/JITExceptions.cpp:

(JSC::genericThrow):

  • jit/JITInlineMethods.h:

(JSC::arrayProfileSaw):
(JSC::JIT::chooseArrayMode):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array):
(JSC::JIT::emit_op_new_array_with_size):
(JSC::JIT::emit_op_new_array_buffer):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitDoubleGetByVal):
(JSC):
(JSC::JIT::emitContiguousGetByVal):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompilePutByVal):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitContiguousGetByVal):
(JSC::JIT::emitDoubleGetByVal):
(JSC):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitSlow_op_put_by_val):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC):

  • jsc.cpp:

(GlobalObject::finishCreation):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/x86.rb:
  • runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

  • runtime/ArrayConstructor.h:

(JSC):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):

  • runtime/Butterfly.h:

(JSC::Butterfly::contiguousInt32):
(JSC::Butterfly::contiguousDouble):
(JSC::Butterfly::fromContiguous):

  • runtime/ButterflyInlineMethods.h:

(JSC::Butterfly::createUninitializedDuringCollection):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncBind):

  • runtime/IndexingHeaderInlineMethods.h:

(JSC::IndexingHeader::indexingPayloadSizeInBytes):

  • runtime/IndexingType.cpp:

(JSC::leastUpperBoundOfIndexingTypes):
(JSC):
(JSC::leastUpperBoundOfIndexingTypeAndType):
(JSC::leastUpperBoundOfIndexingTypeAndValue):
(JSC::indexingTypeToString):

  • runtime/IndexingType.h:

(JSC):
(JSC::hasUndecided):
(JSC::hasInt32):
(JSC::hasDouble):

  • runtime/JSArray.cpp:

(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithAnyIndexingType):
(JSC::compareNumbersForQSortWithInt32):
(JSC):
(JSC::compareNumbersForQSortWithDouble):
(JSC::JSArray::sortNumericVector):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sortCompactedVector):
(JSC::JSArray::sort):
(JSC::JSArray::sortVector):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
(JSC::JSArray::compactForSorting):

  • runtime/JSArray.h:

(JSArray):
(JSC::createContiguousArrayButterfly):
(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC):
(JSC::JSGlobalObject::haveABadTime):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::originalArrayStructureForIndexingType):
(JSC::JSGlobalObject::arrayStructureForIndexingTypeDuringAllocation):
(JSC::JSGlobalObject::arrayStructureForProfileDuringAllocation):
(JSC::JSGlobalObject::isOriginalArrayStructure):
(JSC::constructEmptyArray):
(JSC::constructArray):

  • runtime/JSObject.cpp:

(JSC::JSObject::copyButterfly):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::putByIndex):
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::createInitialIndexedStorage):
(JSC):
(JSC::JSObject::createInitialUndecided):
(JSC::JSObject::createInitialInt32):
(JSC::JSObject::createInitialDouble):
(JSC::JSObject::createInitialContiguous):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToDouble):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::constructConvertedArrayStorageWithoutCopyingElements):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToContiguous):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToContiguous):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::convertUndecidedForValue):
(JSC::JSObject::convertInt32ForValue):
(JSC::JSObject::setIndexQuicklyToUndecided):
(JSC::JSObject::convertInt32ToDoubleOrContiguousWhilePerformingSetIndex):
(JSC::JSObject::convertDoubleToContiguousWhilePerformingSetIndex):
(JSC::JSObject::ensureInt32Slow):
(JSC::JSObject::ensureDoubleSlow):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::ensureArrayStorageSlow):
(JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
(JSC::JSObject::switchToSlowPutArrayStorage):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::countElements):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::getOwnPropertyDescriptor):

  • runtime/JSObject.h:

(JSC::JSObject::getArrayLength):
(JSC::JSObject::getVectorLength):
(JSC::JSObject::canGetIndexQuickly):
(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly):
(JSC::JSObject::canSetIndexQuickly):
(JSC::JSObject::canSetIndexQuicklyForPutDirect):
(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):
(JSC::JSObject::hasSparseMap):
(JSC::JSObject::inSparseIndexingMode):
(JSObject):
(JSC::JSObject::ensureInt32):
(JSC::JSObject::ensureDouble):
(JSC::JSObject::ensureLength):
(JSC::JSObject::indexingData):
(JSC::JSObject::currentIndexingData):
(JSC::JSObject::getHolyIndexQuickly):
(JSC::JSObject::relevantLength):
(JSC::JSObject::currentRelevantLength):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/LiteralParser.cpp:

(JSC::::parse):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSplit):

  • runtime/Structure.cpp:

(JSC::Structure::nonPropertyTransition):

  • runtime/StructureTransitionTable.h:

(JSC::newIndexingType):

Source/WebCore:

Just refactoring WebCore to pass 0 for the ArrayAllocationProfile*.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::JSCanvasRenderingContext2D::webkitLineDash):

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::jsArray):

  • bindings/js/JSDOMBinding.h:

(WebCore::jsArray):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::getJSListenerFunctions):

  • bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::scopeChain):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::ports):

  • bindings/js/JSMutationCallbackCustom.cpp:

(WebCore::JSMutationCallback::handleEvent):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):
(WebCore::JSWebGLRenderingContext::getAttachedShaders):
(WebCore::JSWebGLRenderingContext::getSupportedExtensions):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::deserialize):

2:25 PM Changeset in webkit [133952] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[BlackBerry] Update BB10 date input form.
https://bugs.webkit.org/show_bug.cgi?id=101075

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-08
Reviewed by Rob Buis.

RIM PR 234531
Internally Reviewed by Mike Fenton.
Change date input appearance to button and hide caret when click on them.

Source/WebCore:

  • css/themeBlackBerry.css:

(input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"]):

Source/WebKit/blackberry:

  • WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::setValueAndClosePopup):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openDatePopup):

2:22 PM Changeset in webkit [133951] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Provide pixel coordinates to IMF relative to the screen
https://bugs.webkit.org/show_bug.cgi?id=101628

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-08
Reviewed by Rob Buis.

Reviewed internally by Mike Fenton and Jakob Petsovits.

We need to provide the correct pixel coordinates to IMF,
accounting for webkit based fields in UIB as well as browser.
Getting an offset value from the screen point to the document
content point allows us to adjust for when the document,
such as in UIB, does not start at 0,0.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

2:20 PM Changeset in webkit [133950] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

ASSERT problem on MIPS
https://bugs.webkit.org/show_bug.cgi?id=100589

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2012-11-08
Reviewed by Oliver Hunt.

ASSERT fix for MIPS arch.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_resolve_operations):

2:03 PM Changeset in webkit [133949] by Lucas Forschler
  • 10 edits
    3 copies in branches/safari-536.28-branch

Merged r125457. <rdar://problem/12516352>

1:59 PM Changeset in webkit [133948] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Some more gardening after r133898.

  • platform/efl/TestExpectations:
1:58 PM Changeset in webkit [133947] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r125100. <rdar://problem/12516350>

1:55 PM Changeset in webkit [133946] by Lucas Forschler
  • 32 edits
    8 copies in branches/safari-536.28-branch

Merged r124815. <rdar://problem/12516369>

1:53 PM Changeset in webkit [133945] by abarth@webkit.org
  • 20 edits in trunk/Source/WebCore

[V8] Update callers to use the aligned pointer API rather than the deprecated unaligned pointer API
https://bugs.webkit.org/show_bug.cgi?id=101519

Reviewed by Ojan Vafai.

There should be no change in behavior. The new API is slightly faster
than the old API (and apparently works correctly internally in V8).

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::V8Float64Array::toNative):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::toNative):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::toNative):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::toNative):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::toNative):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::V8TestException::toNative):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::toNative):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::toNative):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::toNative):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::V8TestNode::toNative):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::V8TestObj::toNative):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::toNative):

  • bindings/v8/NPV8Object.cpp:

(WebCore::v8ObjectToNPObject):
(WebCore::npCreateV8ScriptObject):

  • bindings/v8/V8Collection.h:

(WebCore::toNativeCollection):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::isWrapperOfType):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::setDOMWrapper):
(WebCore::V8DOMWrapper::clearDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore::toNative):
(WebCore::toWrapperTypeInfo):

1:52 PM Changeset in webkit [133944] by arv@chromium.org
  • 7 edits in trunk

setAttributeNode and friends should not have optional argument
https://bugs.webkit.org/show_bug.cgi?id=101631

Reviewed by Ojan Vafai.

Source/WebCore:

http://www.w3.org/TR/DOM-Level-3-Core/core.html#ID-887236154

Fix getAttributeNode, getAttributeNodeNS and removeAttributeNode to make the Attr
argument mandatory.

These used to throw DOMExceptions when an invalid type was passed instead of
TypeError which is also a spec violation.

Updated existing tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • dom/Element.cpp:
  • dom/Element.idl:

LayoutTests:

Fix getAttributeNode, getAttributeNodeNS and removeAttributeNode to make the Attr
argument mandatory.

These used to throw DOMExceptions when an invalid type was passed instead of
TypeError which is also a spec violation.

  • fast/dom/Element/attr-param-typechecking-expected.txt:
  • fast/dom/Element/script-tests/attr-param-typechecking.js:
1:50 PM Changeset in webkit [133943] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r124652. <rdar://problem/12516369>

1:48 PM Changeset in webkit [133942] by Lucas Forschler
  • 8 edits in branches/safari-536.28-branch

Merged r124649. <rdar://problem/12516369>

1:39 PM Changeset in webkit [133941] by commit-queue@webkit.org
  • 3 edits in trunk

[Chromium] DumpRenderTree fix for canvas in software compositing
https://bugs.webkit.org/show_bug.cgi?id=101509

Patch by Slavomir Kaslev <skaslev@google.com> on 2012-11-08
Reviewed by Adrienne Walker.

Don't use accelerated canvas 2d when in software compositing mode.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):

1:37 PM Changeset in webkit [133940] by jsbell@chromium.org
  • 6 edits in trunk

Source/WebCore: IndexedDB: Remove unused error handling clauses when writing to transaction
https://bugs.webkit.org/show_bug.cgi?id=100700

Reviewed by Tony Chang.

Transactions are written into in-memory data structures. This can only fail if allocation
fails, so "success" results are always returned. Change the return types to void, and delete
all of the unreachable error handling code.

No new tests - just refactoring/dead code removal.

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::putBool): Only write to transactions.
(WebCore):
(WebCore::putInt): Ditto.
(WebCore::putVarInt): Ditto.
(WebCore::putString): Ditto.
(WebCore::putIDBKeyPath): Ditto.
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::deleteRange): Writes only to transaction, so can't fail.
(WebCore::setMaxObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::getNewVersionNumber):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::setMaxIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):

  • platform/leveldb/LevelDBTransaction.cpp:

(WebCore::LevelDBTransaction::set): Return type is void.
(WebCore::LevelDBTransaction::put): Ditto.
(WebCore::LevelDBTransaction::remove): Ditto.

  • platform/leveldb/LevelDBTransaction.h:

(LevelDBTransaction):

LayoutTests: [Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
1:36 PM Changeset in webkit [133939] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

On Chromium, click-after-nested-block.html, focus_editable_html.html, and autoscroll.html
hit assertion added in r133840
https://bugs.webkit.org/show_bug.cgi?id=101576

Reviewed by Abhishek Arya.

Update layout before invalidating caret rect as needed.
Existing tests cover this.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setCaretVisibility): Merged clearCaretRectIfNeeded.

  • editing/FrameSelection.h:
1:35 PM Changeset in webkit [133938] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed.

Roll Chromium DEPS: 166678 => 166755

  • DEPS:
1:09 PM Changeset in webkit [133937] by Lucas Forschler
  • 6 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r124393. <rdar://problem/12516369>

12:54 PM Changeset in webkit [133936] by eae@chromium.org
  • 8 edits
    21 adds
    18 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines.

  • platform/chromium-linux-x86/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-linux-x86/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/text-overflow-input-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-disabled-color-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/search-rtl-expected.png: Added.
  • platform/chromium-mac-lion/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
  • platform/chromium-mac-lion/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-mac-lion/fast/replaced/width100percent-textarea-expected.png: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-center-expected.png:
  • platform/chromium-win-xp/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-win-xp/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/efl-wk1/fast/css: Added.
  • platform/efl-wk1/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
  • platform/efl-wk1/fast/css/text-overflow-ellipsis-expected.png: Added.
  • platform/efl-wk1/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
  • platform/efl-wk1/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/efl-wk1/fast/css/text-overflow-input-expected.png: Added.
  • platform/efl-wk1/fast/css/text-overflow-input-expected.txt: Added.
  • platform/efl-wk1/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.png: Removed.
  • platform/efl/fast/css/text-overflow-ellipsis-expected.png: Removed.
  • platform/efl/fast/css/text-overflow-ellipsis-strict-expected.png: Removed.
  • platform/efl/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Removed.
  • platform/efl/fast/css/text-overflow-input-expected.png: Removed.
  • platform/efl/fast/css/text-overflow-input-expected.txt: Removed.
  • platform/efl/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Removed.
  • platform/efl/fast/forms/basic-textareas-quirks-expected.png: Removed.
  • platform/efl/fast/forms/basic-textareas-quirks-expected.txt: Removed.
  • platform/efl/fast/forms/input-disabled-color-expected.png: Removed.
  • platform/efl/fast/forms/input-disabled-color-expected.txt: Removed.
  • platform/efl/fast/forms/input-readonly-dimmed-expected.png: Removed.
  • platform/efl/fast/forms/input-readonly-dimmed-expected.txt: Removed.
  • platform/efl/fast/forms/input-text-scroll-left-on-blur-expected.png: Removed.
  • platform/efl/fast/forms/input-text-scroll-left-on-blur-expected.txt: Removed.
  • platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png: Removed.
  • platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Removed.
  • platform/efl/fast/replaced/width100percent-textarea-expected.png: Removed.
12:47 PM Changeset in webkit [133935] by timothy_horton@apple.com
  • 13 edits in trunk/Source/WebKit2

[WK2] Print preview should vend images to the UIProcess instead of PDFs
https://bugs.webkit.org/show_bug.cgi?id=101382
<rdar://problem/9866766>

Reviewed by Alexey Proskuryakov.

In the interests of keeping PDF processing inside the WebProcess, we should
remove print preview's reliance on PDFs, by handing bitmaps back instead.

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::create): Add an optional SharedMemory::Protection argument, so we can make
ShareableBitmaps from read-only handles if desired. Defaults to read-write as previously.
(WebKit::ShareableBitmap::createHandle): Add an optional SharedMemory::Protection argument, so we can make
read-only handles if desired. Defaults to read-write as previously.

  • Shared/ShareableBitmap.h:
  • UIProcess/API/mac/WKPrintingView.h:

(WebImage): Store WebImages instead of raw PDF data for previews.

  • UIProcess/API/mac/WKPrintingView.mm:

(pageDidDrawToImage): Add a callback for when a preview we've requested is done rendering into an image.
Cache the image in _pagePreviews if appropriate.
(pageDidDrawToPDF): Do not handle PDF data unless we are expecting a real print callback (not a preview).
(-[WKPrintingView _drawPreview:]): Request an image instead of PDF data when doing a print preview.

  • UIProcess/GenericCallback.h:

(ImageCallback): Add a callback type with one argument: a ShareableBitmap::Handle.
I can't use the GenericCallback template because ShareableBitmap::Handle doesn't have a corresponding WK type.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Add support for ImageCallback.
(WebKit::WebPageProxy::imageCallback): Add support for ImageCallback.
(WebKit::WebPageProxy::drawRectToImage): Rename drawRectToPDF to drawRectToImage.

  • UIProcess/WebPageProxy.h:

(WebPageProxy): Rename drawRectToPDF to drawRectToImage, add support for ImageCallback.

  • UIProcess/WebPageProxy.messages.in: Add support for ImageCallback.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRectToImage): Rename drawRectToPDF to drawRectToImage.
Make drawRectToImage create a bitmap snapshot of the page (using the normal snapshotting code),
or, if the page is backed by a *PDFPlugin, draw the PDF document into a bitmap and use that.

  • WebProcess/WebPage/WebPage.h:

(WebPage): Rename drawRectToPDF to drawRectToImage.

  • WebProcess/WebPage/WebPage.messages.in: Rename drawRectToPDF to drawRectToImage.
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::drawPDFDocument): Rename drawRectToPDFFromPDFDocument to drawPDFDocument,
because it's more like drawImage than anything else.

12:41 PM Changeset in webkit [133934] by tony@chromium.org
  • 4 edits in trunk/LayoutTests

Layout test editing/pasteboard/file-drag-to-editable.html flaky
https://bugs.webkit.org/show_bug.cgi?id=101092

Reviewed by Ryosuke Niwa.

Fix a flaky test. The problem was that we were confusing the test harness by
trying to do a navigation before the initial load finished (the notifyDone()
call did nothing because waitUntilDone() was missing). Depending on the state
of the frame loader when the test run, there was a race in whether or not we
would dump the results before or after completing the script execution.

Fix this by restructuring the test to run during onload and by calling notifyDone()
after the file load attempt failed.

  • editing/pasteboard/file-drag-to-editable-expected.txt:
  • editing/pasteboard/script-tests/file-drag-to-editable.js:

(runTest.window.onbeforeunload): Simplify and don't run nofityDone yet.
(runTest): Run test during onload event.

  • platform/chromium/TestExpectations: Remove flaky marker.
12:37 PM Changeset in webkit [133933] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Skip frame owner disconnect when there's no frames
https://bugs.webkit.org/show_bug.cgi?id=101619

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-08
Reviewed by Ojan Vafai.

Even when there's no subframes in the document we traverse down every
subtree on Node removal looking for frames to disconnect. This patch
checks document()->frame()->tree()->firstChild() to skip this traversal
if there's no subframes.

No new tests, this just short circuits code for speed.

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):

12:33 PM Changeset in webkit [133932] by arv@chromium.org
  • 11 edits in trunk

Wrong error type is thrown for type errors in callbacks
https://bugs.webkit.org/show_bug.cgi?id=101502

Reviewed by Adam Barth.

We should be throwing a TypeError and not a DOMException with code TYPE_MISMATCH_ERR.

http://www.w3.org/TR/WebIDL/#es-callback-function

Source/WebCore:

Updated existing tests.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/V8/V8TestObj.cpp:

LayoutTests:

  • fast/mediastream/argument-types-expected.txt:
  • fast/mediastream/peerconnection-argument-types-expected.txt:
  • fast/mediastream/script-tests/argument-types.js:
  • fast/mediastream/script-tests/peerconnection-argument-types.js:
  • fast/workers/storage/open-database-inputs-sync-expected.txt:
12:33 PM Changeset in webkit [133931] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

  • DEPS:
12:16 PM Changeset in webkit [133930] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Even more gardening after r133898.

  • platform/efl/TestExpectations:
12:09 PM Changeset in webkit [133929] by andersca@apple.com
  • 3 edits in trunk/WebKitLibraries

Roll WebKitSystemInterface DEPS.

Rubber-stamped by Andreas Kling.

  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
12:08 PM Changeset in webkit [133928] by jpetsovits@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Janitor: Remove unused m_isValid bool
https://bugs.webkit.org/show_bug.cgi?id=101610

Reviewed by Rob Buis.

It's not used anywhere, but as we have a constructor
that creates an invalid TileIndex, let's add another
method to check validity - now a correct check.

On top of that, make the stylebot happy by reducing
"unsigned int" to just "unsigned".

  • WebKitSupport/TileIndex.h:

(BlackBerry::WebKit::TileIndex::TileIndex):
(BlackBerry::WebKit::TileIndex::i):
(BlackBerry::WebKit::TileIndex::j):
(BlackBerry::WebKit::TileIndex::setIndex):
(BlackBerry::WebKit::TileIndex::isValid):
(TileIndex):

12:03 PM Changeset in webkit [133927] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Introduce WebScreenInfo.deviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=101613

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-08
Reviewed by Adam Barth.

Introduce the WebScreenInfo.deviceScaleFactor property, which specifies the
ratio between physical and logical pixels. This is the first step in replacing
horizontalDPI/verticalDPI in favor of the deviceScaleFactor.

For now, this value is only initialized on Mac, because the other ports that
use it initialize the value in Chromium, whereas Windows and X11 default to a
factor of 1. The value on Mac is truncated to an integer to match the
expectation in Chromium's RenderWidget.

Source/Platform:

  • chromium/public/WebScreenInfo.h:

(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):

Source/WebKit/chromium:

  • src/mac/WebScreenInfoFactory.mm:

(WebKit::WebScreenInfoFactory::screenInfo):

11:37 AM Changeset in webkit [133926] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

4.68MB below RenderStyle::filter() on Membuster3.
<http://webkit.org/b/101624>
<rdar://problem/12663822>

Reviewed by Darin Adler.

Rename the non-const RenderStyle::filter() to mutableFilter() since using it causes us to detach
from the rare non-inherited data (copy-on-write.)
Most call sites were calling filter() on a RenderStyle* which was causing the bloat.

4.68MB progression on Membuster3.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::loadPendingShaders):

  • rendering/style/RenderStyle.h:
11:35 AM Changeset in webkit [133925] by ap@apple.com
  • 1 edit
    1 add in trunk/Source/WebCore

Create loader/blackberry directory, because svn-apply cannot apply a patch that
creates a directory and moves a file into it.

  • loader/blackberry: Added.
11:30 AM Changeset in webkit [133924] by efidler@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Increase memory cache size
https://bugs.webkit.org/show_bug.cgi?id=101622

Reviewed by Yong Li.

  • WebCoreSupport/CacheClientBlackBerry.cpp:

(WebCore::CacheClientBlackBerry::updateCacheCapacity):

  • WebCoreSupport/CacheClientBlackBerry.h:

(CacheClientBlackBerry):

11:23 AM Changeset in webkit [133923] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Mac build fix: Mark WidthCache.h 'private' so WebKit can use it.

Not reviewed.

  • WebCore.xcodeproj/project.pbxproj:
11:13 AM Changeset in webkit [133922] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening - widen flaky expectation to include crash

  • platform/chromium/TestExpectations:
11:06 AM Changeset in webkit [133921] by ggaren@apple.com
  • 8 edits
    1 add in trunk/Source/WebCore

Optimized kerning and ligatures using caching
https://bugs.webkit.org/show_bug.cgi?id=101269

Reviewed by Dan Bernstein.

Consider three kinds of text layout, and the value of caching for each:

(1) 1 layout of 100% unique words: small negative value.

(2) 1 layout of English prose: medium positive value.

(3) Many layouts of anything: extra-extra-large positive value.

Since we can't distinguish betwen these workflows a priori, we use statistical
sampling. To minimize cost in (1) and maximize benefit in (2) and (3), we treat
each cache access as a statistical sample, and use the cache in proportion to
the observed probability of duplicate text measurement.

Benchmark results:

plt3: 1% faster
chapter-reflow-once-random: No change [*]
chapter-reflow-once: 23% faster
chapter-reflow-twice: 52% faster
chapter-reflow-thrice: 68% faster
chapter-reflow: 263% faster
line-layout: 270% faster

[*] This is a stress test designed to make everything go wrong for
caching. It does not represent real world content.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/WidthCache.h: Added.

(WidthCache): Added a class that caches common word widths. This cache
could cache more things or more cases in future -- but for now it seems
to cover the common cases.

(SmallStringKey): Early profiling showed that allocating an AtomicString
or String measurably added to the cost of the cache, so I added a custom
string key that can be stored directly inside the table by value --
empirically answering an age-old question with which Apple WebKit engineers
seem to be obsessed.

(WebCore::WidthCache::SmallStringKey::capacity):
(WebCore::WidthCache::SmallStringKey::SmallStringKey):
(WebCore::WidthCache::SmallStringKey::characters):
(WebCore::WidthCache::SmallStringKey::length):
(WebCore::WidthCache::SmallStringKey::hash):
(WebCore::WidthCache::SmallStringKey::isHashTableDeletedValue):
(WebCore::WidthCache::SmallStringKey::isHashTableEmptyValue):
(WebCore::WidthCache::SmallStringKeyHash::hash):
(WebCore::WidthCache::SmallStringKeyHash::equal):
(SmallStringKeyHash):
(SmallStringKeyHashTraits):
(WebCore::WidthCache::SmallStringKeyHashTraits::isEmptyValue): Ditto.

(WebCore::WidthCache::WidthCache):
(WebCore::WidthCache::add): Separate out the "don't use the cache" case
so the compiler can inline it separate, hopefully further reducing cases
of (1).

(WebCore::WidthCache::addSlowCase): There's a little subtlety to the
sampling policy here. Lots of different approaches are possible, and I
just picked a simple one that seemed to work based on benchmarking. I'll
point out some interesting sublteties I'm aware of here:

(*) Since we start at the min sampling rate, a font used for 20 words
or fewer never allocates a cache. Anecdotally, some fonts seem to
be used this way.

(*) When the sampling rate is x / y, sampling all x words in a row
seems smart because some words may occur more commonly in relation to
each other (such as 'each' and 'other'), and repeat workloads will
lay out the same words in order. Intuitively, these are both reasons
this policy may ramp up more effectively under load.

(*) I opted for linear back-off instead of, say, exponential back-off
because we're not trying to back off to infinity -- just to our min
sampling rate. Since we don't expect the cache to hit for every word,
my guess is that exponential back-off would be too aggressive.

(*) Our "eviction" policy has an IQ of 1. I expect this is sufficient
because it would be surprising to see a million unique words all used
in the same document. (I would not like to play a Letterpress game
against such a document.)

(WebCore::WidthCache::clear): Needed because a font can change, in which
case we need to ditch its cache.

(WebCore::operator==): Needed for hashing.

10:57 AM Changeset in webkit [133920] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. More gardening after r133898.

  • platform/efl/TestExpectations:
10:54 AM Changeset in webkit [133919] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening - fix lint failures in expectations file.

  • platform/chromium/TestExpectations:
10:47 AM Changeset in webkit [133918] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

HashAndUTF8CharactersTranslator should create an 8 bit string if possible
https://bugs.webkit.org/show_bug.cgi?id=101515

Reviewed by Darin Adler.

Added isAllASCII flag that's passed to convertUTF8ToUTF16(). If on return it is true, create an
8 bit string, otherwise use the 16 bit string.

  • wtf/text/AtomicString.cpp:

(WTF::HashAndUTF8CharactersTranslator::translate):

10:37 AM Changeset in webkit [133917] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

Multiple Layout Tests (e.g. fast/repaint/japanese-rl-selection-clear.html) is failing after r133840.
https://bugs.webkit.org/show_bug.cgi?id=101547

[Chromium] Unreviewed gardening - test expectations update.

  • platform/chromium/TestExpectations:
10:33 AM Changeset in webkit [133916] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Cleanup IDBBindingUtilitiesTest
https://bugs.webkit.org/show_bug.cgi?id=100860

Patch by Dan Carney <dcarney@google.com> on 2012-11-08
Reviewed by Adam Barth.

Small cleanup of IDBBindingUtilitiesTest as per
https://bugs.webkit.org/show_bug.cgi?id=99975#c38

  • tests/IDBBindingUtilitiesTest.cpp:

(IDBKeyFromValueAndKeyPathTest):
(WebKit::IDBKeyFromValueAndKeyPathTest::IDBKeyFromValueAndKeyPathTest):
(WebKit::IDBKeyFromValueAndKeyPathTest::context):
(WebKit):
(WebKit::TEST_F):

10:24 AM Changeset in webkit [133915] by caseq@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: show statistics over selected frame range in Timeline's Frame mode
https://bugs.webkit.org/show_bug.cgi?id=101593

Reviewed by Pavel Feldman.

  • change status bar records counter wording to "N of M frames|records shown" depending on mode;
  • append average frame length and & stddev in frame mode;
  • expand the above to a popover that includes frame count, range duration and min/avg/max/stddev on frame length;
  • show frame bars & dividers iff selection range includes < 30 frames (drive-by)
  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelineFrameController.js:

(WebInspector.FrameStatistics):

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.aggregateTimeByCategory):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusBarItems.getAnchor):
(WebInspector.TimelinePanel.prototype._createStatusBarItems):
(WebInspector.TimelinePanel.prototype._updateRecordsCounter):
(WebInspector.TimelinePanel.prototype._updateFrameStatistics):
(WebInspector.TimelinePanel.prototype._showFrameStatistics):
(WebInspector.TimelinePanel.prototype._updateFrameBars):
(WebInspector.TimelinePanel.prototype._overviewModeChanged.set if):
(WebInspector.TimelinePanel.prototype._overviewModeChanged):
(WebInspector.TimelinePanel.prototype._refresh):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.):
(WebInspector.TimelinePresentationModel.prototype.compareEndTime):
(WebInspector.TimelinePresentationModel.prototype.filteredFrames):
(WebInspector.TimelinePresentationModel.generatePopupContentForFrameStatistics):

  • inspector/front-end/timelinePanel.css:

(.timeline-records-stats, .storage-application-cache-status, .storage-application-cache-connectivity):
(.timeline-records-stats):
(.timeline-frames-stats):

10:21 AM Changeset in webkit [133914] by jpetsovits@rim.com
  • 16 edits in trunk

[BlackBerry] Rework the API to use document coordinates
https://bugs.webkit.org/show_bug.cgi?id=101608
RIM PR 173292

Reviewed by Adam Treat.

Source/WebCore:

Provide a better API for WebPage to relay.
See Source/WebKit/blackberry/ChangeLog for details.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::getWindowScreenRect):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(Platform):
(BlackBerry):
(MediaPlayerPrivate):

Source/WebKit/blackberry:

Scrolling and zooming APIs used to operate on
transformed coordinates, which is a bad idea:
The UI thread might long have moved on to a
different scale and scroll position so outdated
pixel coordinates are of limited value.

Moreover, more transformation calculations are
needed than if we operate purely on document
coordinates.

With webkitThreadViewportAccessor() exposed,
the caller has a choice between how to handle
coordinates and the means to perform conversions
with little effort and overhead if needed.
Therefore, we should remove pixel coordinates
from the public API. This commit makes this change.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::didRenderContent):

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScroller::setDocumentScrollPositionCompositingThread):
(BlackBerry::WebKit::InRegionScroller::setDocumentScrollPositionWebKitThread):
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):

  • Api/InRegionScroller.h:
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPage::setDocumentScrollPosition):
(BlackBerry::WebKit::WebPagePrivate::hasVirtualViewport):
(BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
(BlackBerry::WebKit::WebPagePrivate::notifyTransformedScrollChanged):
(BlackBerry::WebKit::WebPagePrivate::setCursor):
(BlackBerry::WebKit::WebPagePrivate::notifyPopupAutofillDialog):
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::bestNodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
(BlackBerry::WebKit::WebPage::setVirtualViewportSize):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
(BlackBerry::WebKit::WebPage::setDocumentScrollOriginPoint):
(BlackBerry::WebKit::handleScrolling):
(BlackBerry::WebKit::WebPage::selectionContainsDocumentPoint):
(BlackBerry::WebKit::WebPage::setDocumentSelection):
(BlackBerry::WebKit::WebPage::setDocumentCaretPosition):
(BlackBerry::WebKit::WebPage::selectAtDocumentPoint):
(BlackBerry::WebKit::WebPagePrivate::setTextReflowAnchorPoint):
(BlackBerry::WebKit::WebPage::pinchZoomAboutPoint):
(BlackBerry::WebKit::WebPage::blockZoom):
(BlackBerry::WebKit::WebPage::nodeAtDocumentPoint):
(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):

  • Api/WebPage.h:

(Platform):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/AutofillManager.cpp:

(WebCore::AutofillManager::didChangeInTextField):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

Tools:

Adapt to changed WebPage API.
See Source/WebKit/blackberry/ChangeLog for details.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

10:15 AM Changeset in webkit [133913] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectations for failing image tests following Chromium r166632.

Unreviewed gardening.

  • platform/chromium/TestExpectations:
9:51 AM Changeset in webkit [133912] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Widen flaky crash expectation fast/workers/worker-multi-startup.html to include linux.

Unreviewed gardening.

  • platform/chromium/TestExpectations:
9:44 AM Changeset in webkit [133911] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] http/tests/inspector/indexeddb/database-data.html ASSERT on Win7 following r133855
https://bugs.webkit.org/show_bug.cgi?id=101618

Unreviewed gardening.

  • platform/chromium/TestExpectations:
9:43 AM Changeset in webkit [133910] by keishi@webkit.org
  • 4 edits in trunk/Source

Add properties for week/month picker in DateTimeChooserImpl::writeDocument
https://bugs.webkit.org/show_bug.cgi?id=101552

Reviewed by Kent Tamura.

Source/Platform:

  • chromium/public/WebLocalizedString.h: Add WeekNumberLabel.

Source/WebKit/chromium:

Changing the arguments for calendar picker to support week/month picker.

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument):

9:35 AM Changeset in webkit [133909] by jsbell@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r133892.
http://trac.webkit.org/changeset/133892
https://bugs.webkit.org/show_bug.cgi?id=101617

Compile failures on mac, android, linux (Requested by
jsbell|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::domDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

9:28 AM Changeset in webkit [133908] by eae@chromium.org
  • 26 edits
    28 adds
    7 deletes in trunk/LayoutTests

Unreviewed chromium mac rebaseline for r101497.

  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-bidi-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-strict-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/search-rtl-expected.txt: Added.
  • platform/chromium-mac-lion/fast/multicol/span: Added.
  • platform/chromium-mac-lion/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
  • platform/chromium-mac-lion/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/chromium-mac-lion/fast/replaced/width100percent-textarea-expected.txt: Added.
  • platform/chromium-mac-lion/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-bidi-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-strict-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.txt: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-expected.txt: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.txt: Added.
  • platform/chromium-mac/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png:
  • platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.txt:
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-textarea-expected.txt: Added.
  • platform/chromium-mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/css/text-overflow-input-expected.txt: Removed.
  • platform/chromium/fast/forms/input-readonly-dimmed-expected.txt: Removed.
  • platform/chromium/fast/forms/input-text-scroll-left-on-blur-expected.txt: Removed.
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.txt: Removed.
  • platform/mac/fast/css/text-overflow-input-expected.txt: Removed.
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt: Removed.
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt: Removed.
9:28 AM Changeset in webkit [133907] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Canvas] UI iterations: image on the top, auto replay
https://bugs.webkit.org/show_bug.cgi?id=101584

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-08
Reviewed by Pavel Feldman.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._showTraceLog):
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):

  • inspector/front-end/canvasProfiler.css:

(.canvas-trace-log):
(#canvas-replay-image-container):
(#canvas-replay-image):

9:26 AM Changeset in webkit [133906] by commit-queue@webkit.org
  • 5 edits in trunk

While absolute positioning is put before the first flexitem, flexitems will move to a new line.
https://bugs.webkit.org/show_bug.cgi?id=101294

Patch by Wei Fanzhe <whyer1@gmail.com> on 2012-11-08
Reviewed by Ojan Vafai.

Source/WebCore:

This issue has to do with RenderFlexibleBox::computeNextFlexLine. When determing line breaks, the algorithm sees if 1) the total width exceeds lineBreakLength and 2) whether orderedChildren is non-empty. But then, if the total width exceeds lineBreakLength and there's only absolutely positioned elemments in orderedChildren then the conditions are met and the algorithm mistakenly breaks the line. The solution is to see if orderedChildren collects at least a flex item. If it does, break the line.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeNextFlexLine):

LayoutTests:

Add a case to test flexible layout while absolute positioning is put before the first flexitem.

  • css3/flexbox/flex-algorithm-expected.txt:
  • css3/flexbox/flex-algorithm.html:
9:19 AM Changeset in webkit [133905] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Gardening after r133898.

  • platform/efl/TestExpectations:
9:00 AM Changeset in webkit [133904] by Dimitri Glazkov
  • 10 edits in trunk/Source

Unreviewed, rolling out r133429.
http://trac.webkit.org/changeset/133429
https://bugs.webkit.org/show_bug.cgi?id=101173

Speculative roll out, investigating perf regression.

Source/WebCore:

  • dom/ContextFeatures.cpp:
  • dom/ContextFeatures.h:
  • dom/Position.cpp:

(WebCore::Position::Position):
(WebCore::Position::findParent):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::getSelection):

  • html/HTMLTagNames.in:
  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::contentTagName):

  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • src/ContextFeaturesClientImpl.cpp:

(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

8:45 AM Changeset in webkit [133903] by eae@chromium.org
  • 25 edits in trunk

Fix enclosingLayoutRect calls in InlineFlowBox.h
https://bugs.webkit.org/show_bug.cgi?id=101497

Reviewed by Levi Weintraub.

Source/WebCore:

InlineFlowBox.h used to include LayoutTypesInlineMethods.h which
overrid enclosingLayoutRect to call closingIntRect. When we
removed the LayoutTypes abstraction we switched these to
enclosingIntRect to preserve the behavior.
This patch changes these back to enclosingLayoutRect which is
the desired behavior.

Covered by existing tests.

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::visualOverflowRect):

LayoutTests:

Update tests expectations to reflect change form
enclosingIntRect to enclosingLayoutRect.

  • platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-win/svg/text/text-overflow-ellipsis-svgfont-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/replaced/width100percent-textarea-expected.txt:
  • platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt:
8:24 AM Changeset in webkit [133902] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Verify touched element using the rootEditableElement
https://bugs.webkit.org/show_bug.cgi?id=101510

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-08
Reviewed by Rob Buis.

Reviewed internally by Mike Fenton.

Move up the tree until we find the rootEditableElement and use
that to compare with the touched element.

  • WebKitSupport/FatFingers.h:

(BlackBerry::WebKit::FatFingersResult::node):
(BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

7:43 AM Changeset in webkit [133901] by rjkroege@chromium.org
  • 2 edits in trunk/Source/Platform

[chromium] correct coding oversight for clang
https://bugs.webkit.org/show_bug.cgi?id=101513

Reviewed by Kent Tamura.

https://bugs.webkit.org/show_bug.cgi?id=100675 contains an
incorrect declaration that precludes compiling embedder code
with clang: patch changes class to struct appropriately.

  • chromium/public/WebGestureCurveTarget.h:

(WebKit):

7:39 AM Changeset in webkit [133900] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Turn WTF_USE_TILED_BACKING_STORE in OptionsEfl.cmake.
https://bugs.webkit.org/show_bug.cgi?id=101559

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-11-08
Reviewed by Kenneth Rohde Christiansen.

Follow-up to 133859; also change the default value in
OptionsEfl.cmake so that the default changes for people not using
build-webkit (ie. users) as well.

  • Source/cmake/OptionsEfl.cmake:
7:32 AM Changeset in webkit [133899] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebKit/qt

[Qt] API test tst_qwebinspector crashes
https://bugs.webkit.org/show_bug.cgi?id=101599

Reviewed by Simon Hausmann.

Delete the internal inspector from QWebPage destructor, instead of causing recursions
between QWebPagePrivate::setInspector and QWebInspector::setPage.

Also separate the three tests in tst_QWebInspector to better tell which one is failing.

  • Api/qwebpage.cpp:

(QWebPagePrivate::~QWebPagePrivate):
(QWebPagePrivate::setInspector):

  • tests/qwebinspector/tst_qwebinspector.cpp:

(tst_QWebInspector):
(tst_QWebInspector::attachAndDestroyPageFirst):
(tst_QWebInspector::attachAndDestroyInspectorFirst):
(tst_QWebInspector::attachAndDestroyInternalInspector):

7:25 AM Changeset in webkit [133898] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
https://bugs.webkit.org/show_bug.cgi?id=101526

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-08
Reviewed by Kenneth Rohde Christiansen.

.:

Separate out ENABLE_WEBGL. It is not ready to be enabled by default.

  • Source/cmake/OptionsEfl.cmake:

Tools:

Turn on WTF_USE_TILED_BACKING_STORE for EFL port.

  • Scripts/webkitperl/FeatureList.pm:
7:19 AM Changeset in webkit [133897] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Remove unnecessary save/restore in SVGTextRunRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=101546

Reviewed by Andreas Kling.

This patch removes an unnecessary context save/restore SVGTextRunRenderingContext by
refactoring the code to save off the stroke thickness.

No new tests as this is heavily covered by existing tests.

  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs):

7:09 AM Changeset in webkit [133896] by Simon Hausmann
  • 4 edits in trunk

[Qt] Fix build with MSVC 2012 and Angle
https://bugs.webkit.org/show_bug.cgi?id=101588

Reviewed by Tor Arne Vestbø.

Angle includes STL's <memory> header file, which with MSVC 2012 includes stdint.h. MSVC 2012
does ship stdint.h, but it's lacking other headers such as inttypes.h.

So for the rest of WebKit we have to continue to use our own versions of these files from
JavaScriptCore/os-win32. But for Angle we are just including a shipped STL header file (memory)
and so it's up to the compiler to make that work, i.e. using the stdint.h it ships.

This patch moves the addition of JavaScriptCore/os-win32 out of default_post.prf, so that it
doesn't apply to each and every target anymore. In particular it won't apply to Angle anymore,
because its presence causes a build issue where due to the addition of os-win32/ we end up
including our own stdint.h but are lacking WTF/ to be in the include search path (which our own
stdint.h requires). So out of default_post.prf and into WTF.pri, our own wrappers are now only
used where WTF is also needed, and since os-win32/stdint.h depends on wtf/Platform.h, it seems
like a logical location.

Source/WTF:

  • WTF.pri:

Tools:

  • qmake/mkspecs/features/default_post.prf:
6:56 AM Changeset in webkit [133895] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline fast/media/w3c/test_media_queries.html and fast/media/mq-resolution.html after r133884
https://bugs.webkit.org/show_bug.cgi?id=101597

Unreviewed, WebKit gardening.

Layout tests fast/media/w3c/test_media_queries.html and fast/media/mq-resolution.html
need new test expectations after r133884.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-11-08

  • fast/media/mq-resolution-expected.txt:
  • fast/media/w3c/test_media_queries-expected.txt:
6:54 AM Changeset in webkit [133894] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

OpaqueJSClassContextData() should use StringImpl::isolatedCopy() to make string copies
https://bugs.webkit.org/show_bug.cgi?id=101507

Reviewed by Andreas Kling.

Changed to use isolatedCopy() for key Strings.

  • API/JSClassRef.cpp:

(OpaqueJSClassContextData::OpaqueJSClassContextData):

6:34 AM Changeset in webkit [133893] by Carlos Garcia Campos
  • 53 edits in trunk/Source/WebCore

[GTK] Clean up includes in GObject DOM bindings code
https://bugs.webkit.org/show_bug.cgi?id=101077

Reviewed by Kentaro Hara.

Remove some headers included multiple times for the same file and
fix consistency in the includes style.

  • bindings/gobject/DOMObjectCache.cpp:
  • bindings/gobject/GObjectEventListener.cpp:
  • bindings/gobject/GObjectEventListener.h:
  • bindings/gobject/WebKitDOMBinding.cpp:
  • bindings/gobject/WebKitDOMBinding.h:
  • bindings/gobject/WebKitDOMEventTarget.cpp:
  • bindings/gobject/WebKitDOMEventTarget.h:
  • bindings/gobject/WebKitDOMEventTargetPrivate.h:

(WebKit):

  • bindings/gobject/WebKitDOMObject.cpp:
  • bindings/gobject/WebKitDOMObject.h:
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
  • bindings/gobject/WebKitHTMLElementWrapperFactory.h:
  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateHeader):
(GenerateFunction):
(Generate):
(WriteData):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
  • bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestException.h:
  • bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestNode.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
6:23 AM Changeset in webkit [133892] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] Main world should have one DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101470

Patch by Dan Carney <dcarney@google.com> on 2012-11-08
Reviewed by Kentaro Hara.

The main world DOMWrapperWorld held onto a DOMDataStore that should
never be used, as there is a static one optimized for speed in
DOMDataStore.

No new tests. No change in functionality.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::isolatedWorldDomDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

6:15 AM Changeset in webkit [133891] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] Remove non-variable options from the build system
https://bugs.webkit.org/show_bug.cgi?id=101506

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-08
Reviewed by Kenneth Rohde Christiansen.

.:

Remove WTF_USE_PTHREADS, WTF_USE_ICU_UNICODE, WTF_USE_CAIRO,
WTF_USE_FREETYPE and WTF_USE_HARFBUZZ_NG cmake variables
as these are always set to const 1 and not really configurable.

Remove the definition of ENABLE_CONTEXT_MENUS as this is already set to 1 by default in Platform.h.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Remove WTF_USE_ICU_UNICODE, WTF_USE_CAIRO and WTF_USE_FREETYPE cmake variables
as these are always set to const 1 and not really configurable.

Remove duplicate platform/graphics/cairo include path from
PlatformEfl.cmake.

No new tests as there is no new functionality.

  • PlatformEfl.cmake:

Source/WebKit:

Remove WTF_USE_FREETYPE and ENABLE_GLIB_SUPPORT cmake variables
as these are always set to const 1 and not really configurable.

  • PlatformEfl.cmake:
5:55 AM Changeset in webkit [133890] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Fix build without WebKit1
https://bugs.webkit.org/show_bug.cgi?id=101583

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-11-08
Reviewed by Tor Arne Vestbø.

WebProcess needs access to the QStyle themeing via the initializeWebKit2Theme() function from
WebKit1. Try to access it depending on whether WebKit1 is built or not, not depending on whether
widgets are available not.

  • WebProcess.pro:
  • qt/MainQt.cpp:

(WebKit):
(main):

5:35 AM Changeset in webkit [133889] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unused parameters on GraphicsLayerUpdater.cpp
https://bugs.webkit.org/show_bug.cgi?id=101577

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-08
Reviewed by Kentaro Hara.

The parameter 'displayID' is not used when !USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
Use UNUSED_PARAM macro for removing -Wunused-parameter warnings

  • platform/graphics/GraphicsLayerUpdater.cpp:

(WebCore::GraphicsLayerUpdater::GraphicsLayerUpdater):
(WebCore::GraphicsLayerUpdater::screenDidChange):

5:23 AM Changeset in webkit [133888] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Rebaseline fast/canvas/fillText-shadow.html
https://bugs.webkit.org/show_bug.cgi?id=101587

Unreviewed gardening.

Test fast/canvas/fillText-shadow.html has to be rebased after r133834.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-08

  • platform/efl/fast/canvas/fillText-shadow-expected.txt:
5:21 AM Changeset in webkit [133887] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r133807 and r133820
https://bugs.webkit.org/show_bug.cgi?id=101585

Unreviewed gardening.

Skipping of compositing/absolute-inside-out-of-view-fixed.html and
editing/execCommand/switch-list-type-with-orphaned-li.html for EFL.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-08

  • platform/efl/TestExpectations:
5:19 AM Changeset in webkit [133886] by rakuco@webkit.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

[EFL] Rebaseline svg/css/group-with-shadow.svg
https://bugs.webkit.org/show_bug.cgi?id=101592

Unreviewed gardening.

Test svg/css/group-with-shadow.svg has to be rebaselined after r133834.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-08

  • platform/efl-wk1/svg/css/group-with-shadow-expected.png: Removed.
  • platform/efl/svg/css/group-with-shadow-expected.png: Added.
  • platform/efl/svg/css/group-with-shadow-expected.txt:
5:13 AM Changeset in webkit [133885] by apavlov@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: Add option to disable rulers (Elements panel)
https://bugs.webkit.org/show_bug.cgi?id=101554

Reviewed by Pavel Feldman.

A new setting, showMetricsRulers, has been introduced (off by default, so users need to opt in to see the rulers).
The setting value is passed into InspectorDOMAgent, down to the InspectorOverlayPage, which affects the drawGrid() and
drawRulers() calls. As a side effect, the issue when the rulers were painted for elements having no renderers has been fixed.

No new tests, a UI change.

  • English.lproj/localizedStrings.js: Add "Show rulers" string.
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject): Copy over the showRulers value.

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForHighlight): Copy over the showRulers value.

  • inspector/InspectorOverlay.h:

(HighlightConfig): Add |bool showRulers|.
(WebCore::Highlight::Highlight): Initialize fields.
(Highlight): Add |bool showRulers|.
(WebCore::Highlight::setDataFromConfig):

  • inspector/InspectorOverlayPage.html:
  • inspector/front-end/DOMAgent.js: Make use of WebInspector.settings.showMetricsRulers when building the highlight DTO.
  • inspector/front-end/Settings.js: Add showMetricsRulers.
  • inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab): Add "Show rulers" checkbox in the Elements panel section.

5:11 AM Changeset in webkit [133884] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Warn in the inspector console when using dpi and dpcm units outside of media="print"
https://bugs.webkit.org/show_bug.cgi?id=100865

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-11-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Added function that prints warning to inspector console whenever dpi or dpcm CSS units
are used for screen media.

Test: fast/media/mq-resolution-dpi-dpcm-warning.html

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::setMediaQueries):

  • css/MediaList.cpp:

(WebCore):
(WebCore::addResolutionWarningMessageToConsole):
(WebCore::reportMediaQueryWarningIfNeeded):

  • css/MediaList.h:

(WebCore):

  • css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::matchMedia):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAppendRule):

LayoutTests:

Added layout test that checks if warning is printed to console when dpi or dpcm CSS
units are used for resolution media feature.

  • fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
  • fast/media/mq-resolution-dpi-dpcm-warning.html: Added.

Skip tests for platforms that doesn't support resolution media feature.

  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
5:10 AM Changeset in webkit [133883] by zandobersek@gmail.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a platform-specific baseline for the test added in r133868.

  • platform/gtk/http/tests/security/XFrameOptions: Added.
  • platform/gtk/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
4:45 AM Changeset in webkit [133882] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Unreviewed build fix after r133880.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::setAdditionalPluginPath):

4:39 AM Changeset in webkit [133881] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Console: "time" and "timeEnd" should have same number of required arguments
https://bugs.webkit.org/show_bug.cgi?id=101451

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-08
Reviewed by Yury Semikhatsky.

Solution: make console.time "title" parameter mandatory.

  • page/Console.idl: Changed parameter specification.
4:14 AM Changeset in webkit [133880] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Add ewk_context_additional_plugin_path_set API
https://bugs.webkit.org/show_bug.cgi?id=101530

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-11-08
Reviewed by Gyuyoung Kim.

Add ewk_context_additional_plugin_path_set() to set additional plugin directory.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::setAdditionalPluginPath):
(ewk_context_additional_plugin_path_set):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext):

  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

3:55 AM Changeset in webkit [133879] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Use explicit constructor in BatteryProvider, DownloadManagerEfl, NetworkInfoProvider
https://bugs.webkit.org/show_bug.cgi?id=101567

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-08
Reviewed by Kentaro Hara.

Added explicit keyword in constructors of BatteryProvider, DownloadManagerEfl,
and NetworkInfoProvider in order to avoid implicit type conversion.

  • UIProcess/efl/BatteryProvider.h:

(BatteryProvider):

  • UIProcess/efl/DownloadManagerEfl.h:

(DownloadManagerEfl):

  • UIProcess/efl/NetworkInfoProvider.h:

(NetworkInfoProvider):

3:36 AM Changeset in webkit [133878] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[EFL][WK2] Use smart pointers in EwkContext more actively
https://bugs.webkit.org/show_bug.cgi?id=101565

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-08
Reviewed by Gyuyoung Kim.

Since we're using WebContext instead of WKContext starting r133844 we should
use smart pointers accordingly including PassRefPtr.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):
(EwkContext::~EwkContext):
(EwkContext::create):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):

  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext):
(EwkContext::webContext):

  • UIProcess/API/efl/ewk_database_manager_private.h:

(Ewk_Database_Manager::create):

  • UIProcess/API/efl/ewk_storage_manager_private.h:

(Ewk_Storage_Manager::create):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::DownloadManagerEfl):

  • UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):

3:32 AM Changeset in webkit [133877] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed fixed inspector frontend compilation

  • inspector/front-end/DataGrid.js:
3:32 AM Changeset in webkit [133876] by dominik.rottsches@intel.com
  • 2 edits in trunk

Unreviewed, rolling out r133865.
http://trac.webkit.org/changeset/133865
https://bugs.webkit.org/show_bug.cgi?id=101579

dependent patch has been rolled out. (Requested by drott on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

  • Source/cmake/OptionsEfl.cmake:
3:21 AM Changeset in webkit [133875] by dominik.rottsches@intel.com
  • 4 edits in trunk

Unreviewed, rolling out r133859.
http://trac.webkit.org/changeset/133859
https://bugs.webkit.org/show_bug.cgi?id=101526

Breaks EFL bots test execution.

.:

  • Source/cmake/OptionsEfl.cmake:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
2:49 AM Changeset in webkit [133874] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

GraphicsSurfaceGLX needs to query the drawable for YInversion.
https://bugs.webkit.org/show_bug.cgi?id=101472

After r133049 the WebGL content is now displayed upside down
for the Qt port. We cannot just apply a generic rule, that
the content needs to be flipped upside down.
Instead we have to query GLX to tell us, if the drawable's
framebuffer is y-inverted.

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::textureIsYInverted):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):

2:37 AM Changeset in webkit [133873] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Reduce the number of clean builds
https://bugs.webkit.org/show_bug.cgi?id=100844

Reviewed by Tor Arne Vestbø.

A change in any Qt project file shouldn't trigger clean
build always, but only if the incremental build failed.

  • Scripts/webkitdirs.pm:

(buildQMakeProjects):

2:35 AM Changeset in webkit [133872] by kadam@inf.u-szeged.hu
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed Gardening.

Skip a failing after r133820. Added new baseline after 133834. Update expectation after 133638.

  • platform/qt/TestExpectations:
  • platform/qt/css3/filters/effect-reference-expected.png:
  • platform/qt/css3/filters/effect-reference-expected.txt:
  • platform/qt/svg/css/group-with-shadow-expected.txt:
2:25 AM Changeset in webkit [133871] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][MiniBrowser] Add encoding detector option.
https://bugs.webkit.org/show_bug.cgi?id=100931

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-08
Reviewed by Gyuyoung Kim.

Source/WebKit2:

Add triggering Settings::setUsesEncodingDetector for WK2 UI process.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Add a runtime option to enable/disable encoding detector.

  • MiniBrowser/efl/main.c:

(window_create):
(elm_main):

2:15 AM WebKit Team edited by zandobersek@gmail.com
Adding myself as a committer. (diff)
1:53 AM Changeset in webkit [133870] by zandobersek@gmail.com
  • 5 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a failure expectation for editing/execCommand/switch-list-type-with-orphaned-li.html,
the test regressed in r133820
Further rebaselining after r133834.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/canvas/fillText-shadow-expected.txt:
  • platform/gtk/svg/css/group-with-shadow-expected.png:
  • platform/gtk/svg/css/group-with-shadow-expected.txt:
1:49 AM Changeset in webkit [133869] by kbalazs@webkit.org
  • 4 edits in trunk/Tools

[Qt] DumpRenderTree does not honor the shouldDumpPixels boolean argument of dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=101485

Reviewed by Csaba Osztrogonác.

[Qt] DumpRenderTree does not honor the shouldDumpPixels boolean argument of dumpAsText

Support dumpAsText(true) which means we should not dump a render tree
but should dump pixels. All other platforms already support it.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::dump):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::reset):
(TestRunner::dumpAsText):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner::shouldDumpPixels):
(TestRunner):

1:43 AM Changeset in webkit [133868] by mkwst@chromium.org
  • 6 edits
    3 adds in trunk

Warn when parsing an invalid X-Frame-Options header.
https://bugs.webkit.org/show_bug.cgi?id=101447

Reviewed by Adam Barth.

Source/WebCore:

An 'X-Frame-Options' header that contains an invalid option (that is,
neither 'DENY' nor 'SAMEORIGIN') is ignored. This patch adds a console
warning to notify developers that they've made a mistake.

Test: http/tests/security/XFrameOptions/x-frame-options-invalid.html

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

Move the request identifier generation out of the failure block in
order to pass it into 'shouldInterruptLoadForXFrameOptions'. This
ensures that the console message is properly tied to a request.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):

  • loader/FrameLoader.h:

(FrameLoader):

'shouldInterruptLoadForXFrameOptions' now accepts a request
identifier as a parameter, and generates a console message if the
load is blocked.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

Pass the request identifier into 'shouldInterruptLoadForXFrameOptions'.

LayoutTests:

  • http/tests/security/XFrameOptions/resources/x-frame-options-invalid.cgi: Added.
  • http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-invalid.html: Added.

New test with an invalid frame option value.

1:36 AM Changeset in webkit [133867] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebKit2

[GTK] WebKitWebView doesn't notify of favicon changes for known favicons but new pages
https://bugs.webkit.org/show_bug.cgi?id=98874

Reviewed by Martin Robinson.

If the page is unknown (not registered in the icon database) but
the icon is known (registered by another page) favicon-ready
signal is not emitted because the icon has already been imported
from the database. The view always asks for the favicon when the
load has been committed, but it's usually too early and the
favicon of the page is still unkown. We can use
didChangeIconForPageURLCallback to know when to ask for the
favicon emitting a favicon-changed signal. The callback
iconDataReadyForPageURLCallback is still useful to process pending
icon requests, but the favicon-ready signal can be removed in
favor of favicon-changed.

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(_WebKitFaviconDatabasePrivate): Keep a map of page icons that has
been imported to make sure we only emit favicon-changed signal
when the favicon URI has actually changed, because
didChangeIconForPageURLCallback can be called multiple times for
the same favicon URI in some cases.
(webkit_favicon_database_class_init): Remove favicon-ready signal
and add favicon-changed that includes the new favicon URI for the
given page URI.
(didChangeIconForPageURLCallback): Emit favicon-changed signal if
the favicon URI is new or has changed for the given page URI.
(iconDataReadyForPageURLCallback): Process pending icon requests.
(webkitFaviconDatabaseCreate): Add implementation for
didChangeIconForPageURLCallback.

  • UIProcess/API/gtk/WebKitFaviconDatabasePrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(_WebKitWebViewPrivate): Add favicon URI to make sure we only ask for a
new favicon when the favicon URI has changed.
(webkitWebViewUpdateFavicon): Update the favicon and emit
notify::favicon if it has changed.
(gotFaviconCallback): Update the favicon if the request hasn't
been cancelled.
(webkitWebViewRequestFavicon): Ask for the page favicon.
(webkitWebViewUpdateFaviconURI): Updated the favicon URI and
request the page favicon if the favicon URI has changed.
(faviconChangedCallback): Call webkitWebViewUpdateFaviconURI() with
the given favicon URI.
(webkitWebViewWatchForChangesInFavicon): Connect to
WebKitFaviconDatabase::favicon-changed.
(webkitWebViewDisconnectFaviconDatabaseSignalHandlers): Disconnect
WebKitFaviconDatabase::favicon-changed signal.
(webkitWebViewLoadChanged): Call webkitWebViewUpdateFaviconURI()
with the current favicon URI when the load has been committed.

  • UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:

(serverCallback):
(testNotInitialized):
(testGetFavicon):
(testGetFaviconURI):
(testWebViewFavicon):
(beforeAll):

  • UIProcess/API/gtk/webkit2marshal.list: Add new marshaler.
1:02 AM Changeset in webkit [133866] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt to silence a compiler warning.

  • WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:

(WebKit::RemoteGraphicsLayer::RemoteGraphicsLayer):

1:00 AM Changeset in webkit [133865] by rakuco@webkit.org
  • 2 edits in trunk

[EFL] Turn WTF_USE_TILED_BACKING_STORE in OptionsEfl.cmake.
https://bugs.webkit.org/show_bug.cgi?id=101559

Reviewed by Kenneth Rohde Christiansen.

Follow-up to 133859; also change the default value in
OptionsEfl.cmake so that the default changes for people not using
build-webkit (ie. users) as well.

  • Source/cmake/OptionsEfl.cmake:
12:49 AM Changeset in webkit [133864] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Moving some expectations to proper sections, unskiping a couple of tests
and merging expectations for tests in printing/.

  • platform/gtk/TestExpectations:
12:40 AM Changeset in webkit [133863] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Web Inspector: Timeline: Improve time/timeEnd appearance.
https://bugs.webkit.org/show_bug.cgi?id=100936

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-08
Reviewed by Yury Semikhatsky.

Source/WebCore:

Changes:

  • time/timeEnd records should be top level records only in "glue" mode
  • time/timeEnd records should display "message" in record list / popover
  • glued records add aggregated statistics to root record
  • glued records do not reduce their origin self time

Test: inspector/timeline/timeline-time.html

  • English.lproj/localizedStrings.js: Added "Message" string.
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record): Added "origin" field.

LayoutTests:

Tested gluing of time/timeEnd records.

  • inspector/timeline/timeline-time-expected.txt: Added.
  • inspector/timeline/timeline-time.html: Added.
12:35 AM Changeset in webkit [133862] by yurys@chromium.org
  • 9 edits in trunk

Web Inspector: move front-end methods called from native part to InspectorFrontendAPI
https://bugs.webkit.org/show_bug.cgi?id=101463

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Moved Web Inspector methods called from native code to InspectorFrontendAPI.

  • inspector/InspectorClient.cpp:

(WebCore::InspectorClient::doDispatchMessageOnFrontendPage):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::FrontendMenuProvider::create):
(WebCore::FrontendMenuProvider::disconnect):
(WebCore::FrontendMenuProvider::FrontendMenuProvider):
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
(WebCore::FrontendMenuProvider::contextMenuCleared):
(FrontendMenuProvider):
(WebCore::InspectorFrontendHost::showContextMenu):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.loadCompleted):
(InspectorFrontendAPI.contextMenuItemSelected):
(InspectorFrontendAPI.contextMenuCleared):
(InspectorFrontendAPI.dispatchMessageAsync):
(InspectorFrontendAPI.dispatchMessage):

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

Moved Web Inspector methods called from native code to InspectorFrontendAPI. Updated
WebDevToolsFrontendImpl appropriately.

  • src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

LayoutTests:

Moved Web Inspector methods called from native code to InspectorFrontendAPI.

  • http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorFrontendAPI.dispatchMessageAsync):

12:33 AM Changeset in webkit [133861] by zandobersek@gmail.com
  • 18 edits
    5 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining after r131974, r133037 and r133834.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/gtk/fast/table/025-expected.png:
  • platform/gtk/fast/table/025-expected.txt:
  • platform/gtk/svg/css/arrow-with-shadow-expected.png:
  • platform/gtk/svg/css/arrow-with-shadow-expected.txt:
  • platform/gtk/svg/css/clippath-with-shadow-expected.txt:
  • platform/gtk/svg/css/composite-shadow-example-expected.png:
  • platform/gtk/svg/css/composite-shadow-example-expected.txt:
  • platform/gtk/svg/css/composite-shadow-text-expected.png:
  • platform/gtk/svg/css/composite-shadow-with-opacity-expected.png: Added.
  • platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/gtk/svg/css/shadow-changes-expected.png:
  • platform/gtk/svg/css/shadow-changes-expected.txt:
  • platform/gtk/svg/custom/pattern-scaling-expected.png: Added.
  • platform/gtk/svg/custom/pattern-scaling-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.png:
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-with-transformation-expected.png:
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.txt:
  • platform/gtk/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
  • platform/gtk/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
12:17 AM Changeset in webkit [133860] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

User can change a disabled select (drop down box)
https://bugs.webkit.org/show_bug.cgi?id=100932

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-08
Reviewed by Kent Tamura.

Source/WebCore:

<select> should not handle events if it's disabled.

Test: fast/forms/select/select-disabled.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::defaultEventHandler):

LayoutTests:

Verify that keyboard events do not change value of disabled select.

  • fast/forms/select/select-disabled-expected.txt: Added.
  • fast/forms/select/select-disabled.html: Added.
12:10 AM Changeset in webkit [133859] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
https://bugs.webkit.org/show_bug.cgi?id=101526

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-08
Reviewed by Kenneth Rohde Christiansen.

.:

Separate out ENABLE_WEBGL. It is not ready to be enabled by default.

  • Source/cmake/OptionsEfl.cmake:

Tools:

Turn on WTF_USE_TILED_BACKING_STORE for EFL port.

  • Scripts/webkitperl/FeatureList.pm:
12:05 AM Changeset in webkit [133858] by alecflett@chromium.org
  • 9 edits in trunk/Source

IndexedDB: Rename methods and remove dead code from IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=101488

Reviewed by Ojan Vafai.

Source/WebCore:

In preparation for merging IDBBackingStore and IDBLevelDBBackingStore:

1) rename ObjectStoreRecordIdentifier to RecordIdentifier
2) remove IDBBackingStore::forEachRecord and friends
3) remove IDBBackingStore::Cursor::close, since it was an empty method.

No new tests as this is purely code cleanup.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getRecord):
(WebCore):
(WebCore::IDBLevelDBBackingStore::putRecord):
(WebCore::IDBLevelDBBackingStore::createInvalidRecordIdentifier):
(WebCore::IDBLevelDBBackingStore::deleteRecord):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):

  • Modules/indexeddb/IDBBackingStore.h:

(WebCore::IDBBackingStore::RecordIdentifier::~RecordIdentifier):
(IDBBackingStore):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::close):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):

Source/WebKit/chromium:

Update IDBFakeBackingStore to reflect method changes in IDBBackingStore.

  • tests/IDBFakeBackingStore.h:

Nov 7, 2012:

11:38 PM Changeset in webkit [133857] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: console error after inspecting IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=101481

Reviewed by Pavel Feldman.

Added objectId nullity check to RemoteOBject::release.
Drive-by added release for entry key and primaryKey.

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDataView.prototype.clear):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.release):

11:35 PM Changeset in webkit [133856] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Web Inspector: some tests failing with "Cannot call method 'hasTextContent' of undefined"
https://bugs.webkit.org/show_bug.cgi?id=94501

Unreviewed unskipped test.

  • platform/chromium/TestExpectations:
11:32 PM Changeset in webkit [133855] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: Migrate inspector IndexedDB support to frontend API.
https://bugs.webkit.org/show_bug.cgi?id=101457

Reviewed by Pavel Feldman.

Source/WebCore:

Migrated IndexedDB support to web facing IndexedDB API.

  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::assertIDBFactory):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype.innerCallback):
(WebInspector.IndexedDBModel.prototype._requestData):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataGridNode):
(WebInspector.IDBDataGridNode.prototype.createCell):

LayoutTests:

  • http/tests/inspector/indexeddb/database-data.html:
11:29 PM Changeset in webkit [133854] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Make wait-for-SVN-server.py accept empty string as revision
https://bugs.webkit.org/show_bug.cgi?id=98014

Reviewed by Dirk Pranke.

  • BuildSlaveSupport/wait-for-SVN-server.py:

(waitForSVNRevision):

11:03 PM Changeset in webkit [133853] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Web Inspector: Infinite loop in DataGrid::autoSizeColumn
https://bugs.webkit.org/show_bug.cgi?id=101363

Patch by Vsevolod Vlasov <vsevik@chromium.org> on 2012-11-07
Reviewed by Pavel Feldman.

  • inspector/datagrid-autosize-expected.txt: Added.
  • inspector/datagrid-autosize.html: Added.
10:49 PM Changeset in webkit [133852] by vsevik@chromium.org
  • 5 edits in trunk/Source

Web Inspector: Drop dimmed crumb handling
https://bugs.webkit.org/show_bug.cgi?id=94457

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-20
Reviewed by Vsevolod Vlasov.

Source/WebCore:

No new tests. Existing inspector test should work.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes):

  • inspector/front-end/breadcrumbList.css:

Source/WebKit/chromium:

  • src/js/devTools.css:
10:45 PM Changeset in webkit [133851] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Infinite loop in DataGrid::autoSizeColumn
https://bugs.webkit.org/show_bug.cgi?id=101363

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/datagrid-autosize.html

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._autoSizeWidths):
(WebInspector.DataGrid.prototype.autoSizeColumns):

LayoutTests:

  • inspector/datagrid-autosize-expected.txt: Added.
  • inspector/datagrid-autosize.html: Added.
10:35 PM Changeset in webkit [133850] by keishi@webkit.org
  • 7 edits in trunk

Implement week picking to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101449

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html: Added test for week picker.

Source/WebCore:

This adds week picker mode to CalendarPicker.

No new tests. Tests will be added later when this feature is enabled in DRT.

  • Resources/pagepopups/calendarPicker.css:

(.month-mode .day):
(.week-mode .available.day-selected.monday): Rounded corners around week selection.
(.week-mode .available.day-selected.sunday): Ditto.
(.week-mode .unavailable.day-selected):
(.week-mode .unavailable.day-selected.monday):
(.week-mode .unavailable.day-selected.sunday):
(.week-mode .week-column.unavailable.day-selected):
(.week-column): Hide week column unless in week mode.
(.week-mode .week-column):

  • Resources/pagepopups/calendarPicker.js:

(parseDateString): Support week string.
(Week):
(Week.parse): Parses "yyyy-Www" string.
(Week.createFromDate): Creates Week containing datetime.
(Week.createFromToday): Creates Week containing today.
(Week.weekOneStartDateForYear): Returns the start date for the first week of year.
(Week.numberOfWeeksInYear): Returns the number of weeks in year.
(Week._numberOfWeeksSinceDate): Returns number of weeks since a date.
(Week.prototype.equals): Returns true if the Weeks are the same.
(Week.prototype.previous): Returns the previous Week.
(Week.prototype.next): Returns the next Week.
(Week.prototype.startDate): Returns start datetime of Week.
(Week.prototype.endDate): Returns end datetime of Week.
(Week.prototype.valueOf): Returns the milliseconds since epoch.
(Week.prototype.toString): Returns ISO week string.
(CalendarPicker): Add week picker mode.
(CalendarPicker.prototype.showMonth): Use NavigationBehaviour instead of bools.
(YearMonthController.prototype.attachTo): Fix bug.
(YearMonthController.prototype.moveRelatively): Use new showMonth.
(DaysTable.prototype.attachTo): Add week number column.
(DaysTable.prototype._renderMonth): Render week numbers.
(DaysTable.prototype.navigateToMonth): Render week numbers.
(DaysTable.prototype.selectRange):
(DaysTable.prototype._selectRangeAtPosition): Week number nodes have an positionX of -1.
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
(MonthPickerDaysTable.prototype.selectRange):
(MonthPickerDaysTable.prototype.selectRangeAndShowEntireRange):
(MonthPickerDaysTable.prototype._handleKey):
(WeekPickerDaysTable): Added.
(WeekPickerDaysTable.prototype._markRangeAsSelected): Marks week as selected.
(WeekPickerDaysTable.prototype.selectRange): Selects week.
(WeekPickerDaysTable.prototype.selectRangeAndShowEntireRange): Selects week and navigate to show entire selection.
(WeekPickerDaysTable.prototype._rangeForNode): Returns Week for node.
(WeekPickerDaysTable.prototype._handleKey):

LayoutTests:

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html: Needs to be changed because we changed DaysTable DOM.
10:14 PM Changeset in webkit [133849] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit gardening.

Remove a duplication which caused a webkit-lint error.

  • platform/chromium/TestExpectations:
10:08 PM Changeset in webkit [133848] by commit-queue@webkit.org
  • 25 edits
    2 adds in trunk

Unreviewed, rolling out r133841.
http://trac.webkit.org/changeset/133841
https://bugs.webkit.org/show_bug.cgi?id=101542

Reverted patches were innocent (Requested by shinyak on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::shadowPseudoId):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.cpp:

(WebCore::ElementRareData::reportMemoryUsage):

  • dom/ElementRareData.h:

(ElementRareData):

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::initialize):

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement):

  • html/shadow/PickerIndicatorElement.cpp:

(WebCore::PickerIndicatorElement::PickerIndicatorElement):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCue::updateDisplayTree):

  • testing/Internals.cpp:

(WebCore::Internals::setShadowPseudoId):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/styling-pseudo-attribute-expected.html: Added.
  • fast/dom/shadow/styling-pseudo-attribute.html: Added.
  • platform/chromium/TestExpectations:
9:40 PM Changeset in webkit [133847] by hayato@chromium.org
  • 5 edits
    6 copies
    4 moves
    6 adds
    6 deletes in trunk/LayoutTests

Unreviewed, WebKit gardening.

Rebaseline after r133384.

  • fast/repaint/moving-shadow-on-container-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.txt.
  • platform/chromium-linux-x86/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
  • platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png: Added.
  • platform/chromium-linux/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
  • platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/svg/css/group-with-shadow-expected.png.
  • platform/chromium-mac-lion/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
  • platform/chromium-mac-snowleopard/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
  • platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/chromium-mac/svg/css/group-with-shadow-expected.png: Added.
  • platform/chromium-mac/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
  • platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
  • platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/chromium-win/svg/css/group-with-shadow-expected.png: Added.
  • platform/chromium-win/svg/css/group-with-shadow-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/chromium/svg/css/group-with-shadow-expected.png: Removed.
  • platform/efl-wk1/fast/repaint/moving-shadow-on-container-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/moving-shadow-on-container-expected.png.
  • platform/efl-wk1/svg/css/group-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/group-with-shadow-expected.png.
  • platform/efl/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
9:36 PM Changeset in webkit [133846] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Fix EFL build, which has accelerated compositing disabled, by making
repaintViewRectangle() const.

  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintViewRectangle):

  • rendering/RenderView.h:

(RenderView):

9:15 PM Changeset in webkit [133845] by Simon Fraser
  • 41 edits in trunk/Source/WebCore

constify ALL the repaint containers
https://bugs.webkit.org/show_bug.cgi?id=101541

Reviewed by Beth Dakin.

Make all the RenderLayerModelObject* repaintContainer arguments const, since
these member functions should have no need to mutate this object.

  • WebCore.exp.in:
  • rendering/RenderBR.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::rectWithOutlineForRepaint):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::outlineBoundsForRepaint):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderBox.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::repaintRectangleInRegions): Need to use a const_iterator.

  • rendering/RenderFlowThread.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderInline.h:
  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::selectionRectForRepaint):

  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::computeFloatRectForRepaint):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localToContainerQuad):
(WebCore::RenderObject::localToContainerPoint):

  • rendering/RenderObject.h:

(WebCore::RenderObject::selectionRectForRepaint):
(WebCore::RenderObject::outlineBoundsForRepaint):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::selectionRectForRepaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):

  • rendering/RenderReplaced.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::clippedOverflowRectForRepaint):

  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::clippedOverflowRectForRepaint):

  • rendering/RenderTableRow.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::clippedOverflowRectForRepaint):
(WebCore::RenderText::selectionRectForRepaint):

  • rendering/RenderText.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::computeRectForRepaint):

  • rendering/RenderView.h:
  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeFloatRectForRepaint):
(WebCore::RenderSVGForeignObject::mapLocalToContainer):

  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGGradientStop.h:
  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeFloatRectForRepaint):
(WebCore::RenderSVGInline::mapLocalToContainer):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeFloatRectForRepaint):
(WebCore::RenderSVGModelObject::mapLocalToContainer):
(WebCore::RenderSVGModelObject::outlineBoundsForRepaint):

  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
(WebCore::RenderSVGRoot::mapLocalToContainer):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):
(WebCore::RenderSVGText::computeFloatRectForRepaint):
(WebCore::RenderSVGText::mapLocalToContainer):

  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeFloatRectForRepaint):
(WebCore::SVGRenderSupport::mapLocalToContainer):

  • rendering/svg/SVGRenderSupport.h:

(SVGRenderSupport):

8:38 PM Changeset in webkit [133844] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebKit2

[EFL][WK2] Make ewk_context use WebContext instead of WKContext
https://bugs.webkit.org/show_bug.cgi?id=101477

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-07
Reviewed by Gyuyoung Kim.

Refactor ewk_context to use WebContext as ewk_context is encapsulated in a C++ classes.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):
(EwkContext::~EwkContext):
(EwkContext::create):
(EwkContext::defaultContext):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):

  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext):
(EwkContext::webContext):

  • UIProcess/API/efl/ewk_database_manager.cpp:

(Ewk_Database_Manager::Ewk_Database_Manager):
(Ewk_Database_Manager::getDatabaseOrigins):

  • UIProcess/API/efl/ewk_database_manager_private.h:

(Ewk_Database_Manager::create):
(Ewk_Database_Manager):

  • UIProcess/API/efl/ewk_storage_manager.cpp:

(Ewk_Storage_Manager::Ewk_Storage_Manager):
(Ewk_Storage_Manager::getStorageOrigins):

  • UIProcess/API/efl/ewk_storage_manager_private.h:

(Ewk_Storage_Manager::create):
(Ewk_Storage_Manager):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::DownloadManagerEfl):

  • UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):

8:34 PM Changeset in webkit [133843] by dpranke@chromium.org
  • 1114 edits
    1107 copies
    40 adds in trunk/LayoutTests

Unreviewed, new chromium-mac-mountainlion svg baselines.

8:12 PM Changeset in webkit [133842] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium-win] Refactor date/time format conversion code in LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=101329

Reviewed by Kentaro Hara.

convertWindowsDateFormatToLDML and convertWindowsTimeFormatToLDML did
similar jobs with different code. We can merge them into one function.

As for the date format conversion, we have tokenized a format string and
stored token objects into a vector. We skip token object generation and
generate a LDML-compliant pattern string during parsing.

No new tests. This should make no behavior changes and
WebKit/chromium/tests/LocaleWinTest.cpp has test cases.

  • platform/text/win/LocaleWin.cpp:

(WebCore): Remove DateFormatToken, isFooSymbol, ensureShortDateTokens,
convertWindowsDateFormatToLDML, mapCharacterToDateTimeFieldType, and
convertWindowsTimeFormatToLDML.
(WebCore::commitLiteralToken): Store the result to the specified StringBuilder.
(WebCore::convertWindowsDateTimeFormat):
Renamed from parseDateFormat, and supports time format symbols.
(WebCore::LocaleWin::dateFormat): Use convertWindowsDateTimeFormat.
(WebCore::LocaleWin::monthFormat): Ditto.
(WebCore::LocaleWin::timeFormat): Ditto.
(WebCore::LocaleWin::shortTimeFormat): Ditto.

  • platform/text/win/LocaleWin.h:

(LocaleWin): Remove ensureShortDateTokens and m_shortDateTokens.

8:00 PM Changeset in webkit [133841] by shinyak@chromium.org
  • 25 edits
    2 deletes in trunk

Unreviewed, rolling out r133428 and r133749
https://bugs.webkit.org/show_bug.cgi?id=101533

These patches might cause memory regression.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::shadowPseudoId):
(WebCore):
(WebCore::Element::setShadowPseudoId):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.cpp:

(WebCore::ElementRareData::reportMemoryUsage):

  • dom/ElementRareData.h:

(ElementRareData):

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::initialize):

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement):

  • html/shadow/PickerIndicatorElement.cpp:

(WebCore::PickerIndicatorElement::PickerIndicatorElement):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCue::updateDisplayTree):

  • testing/Internals.cpp:

(WebCore::Internals::setShadowPseudoId):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/styling-pseudo-attribute-expected.html: Removed.
  • fast/dom/shadow/styling-pseudo-attribute.html: Removed.
  • platform/chromium/TestExpectations:
7:50 PM Changeset in webkit [133840] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::RenderLayer::normalFlowList
https://bugs.webkit.org/show_bug.cgi?id=101528

Reviewed by Simon Fraser.

Make sure the layout is up to date before re-computing the caret rect.
Avoid doing the layout when the selection is cleared since we can always stop
the blink timer in that case.

Unfortunately, we haven't found any reproduction of this crash yet.

  • editing/FrameSelection.cpp:

(WebCore::isNonOrphanedCaret):
(WebCore::FrameSelection::localCaretRect):
(WebCore::FrameSelection::updateAppearance):

7:42 PM Changeset in webkit [133839] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Marking new test editing/execCommand/switch-list-type-with-orphaned-li.html per webkit.org/b/101539.

  • platform/chromium/TestExpectations:
7:23 PM Changeset in webkit [133838] by kareng@chromium.org
  • 1 edit
    2 copies in branches/chromium/1312

Merge 133124 - [Refactoring] Move initial style setting for ProgressValueElement from attach method to createShadowSubtree method in HTMLProgressElement.
https://bugs.webkit.org/show_bug.cgi?id=83664

Reviewed by Hajime Morita.

Source/WebCore:

The original code updates inline style during attach(). However,
the attach would be invoked from Element::recalcStyle()'s reattach().
If updating inline styles during the reattach(), style related flags,
i.e. childNeedsStyleRecalc, and needsStyleRecalc are cleared after the
reattach(). So the inline styles are not updated in next
setNeedsStyleRecalc, because ProgressValueElement has already had
InlineStyleChange (existingChanegType == InlineStyleChange) and
markAncestorsWithChildNeedsStyleRecalc is not invoked.

Test: fast/dom/HTMLProgressElement/progress-bar-set-value.html

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::attach):
Copied updateFromElement from didElementStateChange. If removing the
update, indeterminate-progress-001.html and progress-element.html
under fast/dom/HTMLProgressElement will fail. We still need attach()
and updateFromElement. To remove the attach(), need more refactoring,
i.e. investigating where attach() is invoked from and modifying all
related codes.
(WebCore::HTMLProgressElement::createShadowSubtree):
Initialize m_value by indeterminate-position. The value is default
value of progress element.

LayoutTests:

  • fast/dom/HTMLProgressElement/progress-bar-set-value-expected.html: Added.
  • fast/dom/HTMLProgressElement/progress-bar-set-value.html: Added.

TBR=tasak@google.com
Review URL: https://codereview.chromium.org/11275208

7:05 PM Changeset in webkit [133837] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110

Reviewed by Kentaro Hara.

Hopefully the memory issues with this patch have been resolved by
fixing bug 101525. This patch re-lands this patch again, hopefully for
the last time.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::weakCallback):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::wrapperIsStoredInObject):
(WebCore::DOMDataStore::getWrapperFromObject):
(WebCore::DOMDataStore::setWrapperInObject):

7:03 PM Changeset in webkit [133836] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Seam occurred between pieces of ShadowBlur on floating point zoom
https://bugs.webkit.org/show_bug.cgi?id=101435

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-07
Reviewed by Simon Fraser.

When paint Shadow that doesn't have blurred edge on floating point zoom,
pixel seam (pixel cracks) occurred between pieces of the ShadowBlur because of unaligned clip rect.
So, enlarge the clipping area 1 pixel so that the fill does not bleed (due to antialiasing)
even if the unaligned clip rect occurred.

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::calculateLayerBoundingRect):

7:01 PM Changeset in webkit [133835] by dpranke@chromium.org
  • 148 edits
    135 copies
    27 adds in trunk/LayoutTests

Unreviewed, new chromium-mac-mountainlion baselines for remaining dirs outside of fast, svg, and tables.

6:58 PM Changeset in webkit [133834] by timothy_horton@apple.com
  • 26 edits
    7 adds in trunk

Repaint issues with -webkit-svg-shadow used on a container
https://bugs.webkit.org/show_bug.cgi?id=65643
<rdar://problem/7600532>

Reviewed by Simon Fraser.

SVG renderer repaint rects are currently expanded only by the shadow of
the renderer itself; however, the area they need to repaint can be larger
than that, if their parents also have shadows. We need to take into account
parent's shadows (respecting transforms, as well).

clippedOverflowRectForRepaint already recurses upwards through the render tree,
and ends up with a rect in layout coordinates, so we manually apply the shadow
at each step (repaintRectInLocalCoordinatesExcludingSVGShadow was added to allow
us to get the raw repaint rect without the shadow baked-in).

repaintRectInLocalCoordinates now includes shadows from all parents.

Also, RenderSVGRoot was clipping repaint rects to the viewport before applying
shadows, so offscreen elements with on-screen shadows (applied by the root) would not paint the shadows.
We can just swap the order of these things to correct this.

Tests: svg/css/parent-shadow-offscreen.svg, svg/css/root-shadow-offscreen.svg, svg/repaint/repaint-webkit-svg-shadow.svg

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild): Mark the child being added as having an SVG shadow if it is being added as a child of an element that does.
(WebCore::RenderObject::styleDidChange): Mark the child being added as having an SVG shadow if its new style has a shadow.

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout): Cache the repaint rect before intersecting it with the shadow.

  • rendering/svg/RenderSVGImage.h:

(WebCore::RenderSVGImage::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::RenderSVGModelObject): Renderers do not have a shadow by default.

  • rendering/svg/RenderSVGModelObject.h:

(WebCore::RenderSVGModelObject::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
(WebCore::RenderSVGModelObject::hasSVGShadow): Return whether or not the renderer has a shadow.
(WebCore::RenderSVGModelObject::setHasSVGShadow): Set whether or not the renderer has a shadow.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint): Apply the shadow before clipping to the viewport, so we draw shadows for elements outside the viewport.
(WebCore::RenderSVGRoot::updateCachedBoundaries): Cache the repaint rect before intersecting it with the shadow.

  • rendering/svg/RenderSVGRoot.h:

(WebCore::RenderSVGRoot::hasSVGShadow): Return whether or not the renderer has a shadow.
(WebCore::RenderSVGRoot::setHasSVGShadow): Set whether or not the renderer has a shadow.
(WebCore::RenderSVGRoot::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::updateRepaintBoundingBox): Cache the repaint rect before intersecting it with the shadow.

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::repaintRectForRendererInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint): Apply shadows as we walk through our parents, instead of only applying the renderer's own shadow.
(WebCore::SVGRenderSupport::rendererHasSVGShadow): Return whether or not the renderer has a shadow.
(WebCore::SVGRenderSupport::setRendererHasSVGShadow): Set whether or not the renderer has a shadow.
(WebCore::SVGRenderSupport::intersectRepaintRectWithShadows): Walk through the element's parents, adding shadows to the repaint rect as we go, eventually
transforming the repaint rect back into local coordinates.
(WebCore::SVGRenderSupport::intersectRepaintRectWithResources): Don't add shadows by default, just other resources, so that we can cache repaint rects with and without shadows.

  • rendering/svg/SVGRenderSupport.h:
  • platform/chromium/TestExpectations: Mark tests as needing rebaseline.
  • platform/efl/TestExpectations: Mark tests as needing rebaseline.
  • platform/gtk/TestExpectations: Mark tests as needing rebaseline.
  • platform/qt/TestExpectations: Mark tests as needing rebaseline.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/mac/svg/css/arrow-with-shadow-expected.txt:
  • platform/mac/svg/css/clippath-with-shadow-expected.txt:
  • platform/mac/svg/css/composite-shadow-example-expected.txt:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/mac/svg/css/group-with-shadow-expected.txt:
  • platform/mac/svg/css/shadow-changes-expected.txt:
  • platform/mac/svg/custom/simple-text-double-shadow-expected.txt:

Rebaseline Mac results due to this change.

  • svg/css/parent-shadow-offscreen-expected.svg: Added.
  • svg/css/parent-shadow-offscreen.svg: Added.

Add a new test that ensures that <g> with -webkit-svg-shadow applied draws when children are offscreen but the shadow is not.

  • svg/css/root-shadow-offscreen-expected.svg: Added.
  • svg/css/root-shadow-offscreen.svg: Added.

Add a new test that ensures that <svg> with -webkit-svg-shadow applied draws when children are offscreen but the shadow is not.

  • platform/mac/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
  • svg/repaint/repaint-webkit-svg-shadow-expected.txt: Added.
  • svg/repaint/repaint-webkit-svg-shadow.svg: Added.

Add a new test that ensures that SVG elements with -webkit-svg-shadow are correctly invalidated.

6:52 PM Changeset in webkit [133833] by andersca@apple.com
  • 9 edits
    2 copies in trunk/Source

Add RemoteGraphicsLayer class
https://bugs.webkit.org/show_bug.cgi?id=101535

Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.exp.in:

Export GraphicsLayer symbols required by WebKit2.

  • WebCore.xcodeproj/project.pbxproj:

Make GraphicsLayerFactory.h a private header.

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
  • WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:

Add RemoteGraphicsLayer, a subclass of WebCore::GraphicsLayer.

  • WebProcess/WebPage/mac/RemoteLayerTreeController.h:

Make RemoteLayerTreeController a GraphicsLayerFactory.

  • WebProcess/WebPage/mac/RemoteLayerTreeController.mm:

(WebKit::RemoteLayerTreeController::createGraphicsLayer):
Create a new RemoteGraphicsLayer.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::graphicsLayerFactory):
Return the layer tree controller.

6:52 PM Changeset in webkit [133832] by roger_fong@apple.com
  • 30 edits in trunk

Enable Subpixel Layout on Windows. Rebaseline any failing tests that were rebaselined in r133351.
https://bugs.webkit.org/show_bug.cgi?id=101538

Rubberstamped by Tim Horton.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • platform/win/css1/font_properties/font-expected.txt:
  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/win/editing/selection/caret-ltr-right-expected.txt:
  • platform/win/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/win/editing/selection/caret-rtl-right-expected.txt:
  • platform/win/editing/selection/mixed-editability-10-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/win/fast/borders/bidi-012-expected.txt:
  • platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
  • platform/win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/win/fast/inline/inline-box-background-expected.txt:
  • platform/win/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/win/fast/lists/003-vertical-expected.txt:
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
5:41 PM Changeset in webkit [133831] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101408

Reviewed by Kent Tamura.

Mistake with timezone was making this test flaky.

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
5:39 PM Changeset in webkit [133830] by dpranke@chromium.org
  • 744 edits
    742 copies
    17 adds in trunk/LayoutTests

Unreviewed, new chromium-mac-mountainlion baselines for css3/selectors3.

5:29 PM Changeset in webkit [133829] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

[V8] Don't leak <img> elements in content scripts
https://bugs.webkit.org/show_bug.cgi?id=101525

Reviewed by Ojan Vafai.

I found the leak that was causing a problem for bug 101110. We weren't
filling in the derefObjectFunction for HTMLImageElements (and
potentially some other types of elements). That manifests today as a
memory leak in content scripts (which use the derefObjectFunction for
nodes) and caused a memory leak after bug 101110 because we started
using the derefObjectFunction in the main world as well.

This patch adds ASSERTs so that we won't make this mistake in the future.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::weakCallback):

  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::defaultWeakCallback):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

5:29 PM Changeset in webkit [133828] by commit-queue@webkit.org
  • 21 edits
    1 move
    1 add
    1 delete in trunk/Source/WebKit2

[WK2] Make WebVibrationProxy to be a member of WebPageProxy.
https://bugs.webkit.org/show_bug.cgi?id=100334

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-11-07
Reviewed by Anders Carlsson.

WebVibrationProxy should be a member of WebPageProxy, because the IPC
messages of WebVibrationProxy have page destination ID.

The r132386 proposed a way to add/delete message receivers that can
handle IPC messages with destination ID.

Previous implementation that creating WebVibrationProxy as a WebContext
member and using the global message receiver for the proxy can make
assertions after r132386.

To handle the vibration IPC messages properly, this patch will do the
followings.

1) Instead of WebContext, WebPageProxy will have the WebVibrationProxy.

2) WebVibrationProxy will add itself to the message receiver map of

the WebContext with page destination ID.

3) When WebProcessProxy received vibration ipc messages, it will

forward the messages to the WebContext first. Then the message
receiver map of the WebContext will handle the messages with the
registered WebVibrationProxy.

4) APIs will be modified to apply these changes.

a) WK API to get WKVibrationRef will use WKPageRef not WKContextRef.
b) EFL APIs and API test for the vibration will also be changed.

  • EwkViewImpl will have vibration client. (EwkContext will not have it)
  • Previous API to register the vibration callback will be removed.
  • New signals for vibration will be added to the EwkViewImpl.
  • VibrationProxy will be renamed to VibrationClient for the consistency with other clients in EwkViewImpl.
  • VibrationClient will use EwkViewImpl instead of EwkContext.
  • Previous API test for vibration will be moved from context test to view test, and it will use the changed API.
  • PlatformEfl.cmake:
  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetVibration):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/efl/EwkViewCallbacks.h:

(EwkViewCallbacks):

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):

  • UIProcess/API/efl/EwkViewImpl.h:

(WebKit):
(EwkViewImpl):

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_private.h:

(WebKit):
(EwkContext):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_context.cpp:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(VibrationCbData):
(onVibrate):
(onCancelVibration):
(loadVibrationHTMLString):
(TEST_F):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):

  • UIProcess/WebContext.h:

(WebKit):
(WebContext):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/WebPageProxy.h:

(WebKit):
(WebPageProxy):
(WebKit::WebPageProxy::vibration):

  • UIProcess/WebVibrationProxy.cpp:

(WebKit::WebVibrationProxy::create):
(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):
(WebKit::WebVibrationProxy::invalidate):

  • UIProcess/WebVibrationProxy.h:

(WebKit):
(WebVibrationProxy):

  • UIProcess/efl/VibrationClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/VibrationProvider.cpp.

(toVibrationClient):
(VibrationClientEfl::vibrateCallback):
(VibrationClientEfl::cancelVibrationCallback):
(VibrationClientEfl::create):
(VibrationClientEfl::VibrationClientEfl):
(VibrationClientEfl::~VibrationClientEfl):

  • UIProcess/efl/VibrationClientEfl.h: Renamed from Source/WebKit2/UIProcess/efl/VibrationProvider.h.

(WebKit):
(VibrationClientEfl):

5:26 PM Changeset in webkit [133827] by andersca@apple.com
  • 4 edits
    2 copies in trunk/Source/WebKit2

Add empty RemoteLayerTree class
https://bugs.webkit.org/show_bug.cgi?id=101524

Reviewed by Simon Fraser.

Add a new RemoteLayerTree class which will contain the remote graphics layers.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/mac/RemoteLayerTree.h: Added.
  • WebProcess/WebPage/mac/RemoteLayerTree.mm: Added.
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

(RemoteLayerTreeDrawingArea):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):

5:18 PM Changeset in webkit [133826] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

5:16 PM Changeset in webkit [133825] by alecflett@chromium.org
  • 5 edits
    1 move in trunk/Source/WebCore

IndexedDB: Prepare for IDBBackingStore merge by renaming IDBLevelDBBackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=101486

Reviewed by Ojan Vafai.

Rename IDBLevelDBBackingStore.cpp to IDBBackingStore.cpp in
preparation for merging these classes. This will make the merge
diffs sane. See https://bugs.webkit.org/show_bug.cgi?id=101415
for the final goal.

No new tests, this is is just a rename and minor style fix.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBBackingStore.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp.
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
5:13 PM Changeset in webkit [133824] by Lucas Forschler
  • 1 copy in tags/Safari-537.18

New Tag.

4:56 PM Changeset in webkit [133823] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Prepare DOMDataStore to be able to store ScriptWrappable wrappers inline
https://bugs.webkit.org/show_bug.cgi?id=101523

Unreviewed. Technically this patch hasn't been reviewed, but it is part
of a patch that was reviewed by Kentaro Hara.

Sadly, my patch for bug 101110 triggered the regression again. This
patch is a smaller incremental step towards the patch in bug 101110. It
doesn't make that much sense on its own, but it will help me isolate
the source of the regression.

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::get):
(DOMDataStore):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::wrapperIsStoredInObject):
(WebCore::DOMDataStore::getWrapperFromObject):
(WebCore::DOMDataStore::setWrapperInObject):

4:52 PM Changeset in webkit [133822] by dpranke@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed, fix mistakenly added pngs for failing compositing ref tests :(.

  • platform/chromium-mac/compositing/text-on-scaled-layer-expected.png: Removed.
  • platform/chromium-mac/compositing/text-on-scaled-surface-expected.png: Removed.
  • platform/chromium/TestExpectations:
4:36 PM Changeset in webkit [133821] by dpranke@chromium.org
  • 9 edits
    7 copies
    2 adds in trunk/LayoutTests

Unreviewed, clean up chromium-mac-mountainlion for remaining compositing, css3 (non selectors3) tests.

  • platform/chromium-mac-lion/css3/css3-modsel-33-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-33-expected.png.
  • platform/chromium-mac-lion/css3/css3-modsel-35-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-35-expected.png.
  • platform/chromium-mac-lion/css3/css3-modsel-36-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-36-expected.png.
  • platform/chromium-mac-lion/css3/css3-modsel-37-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-37-expected.png.
  • platform/chromium-mac-lion/css3/flexbox/repaint-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/flexbox/repaint-expected.png.
  • platform/chromium-mac-lion/css3/font-feature-settings-rendering-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/font-feature-settings-rendering-expected.png.
  • platform/chromium-mac-lion/css3/unicode-bidi-isolate-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png.
  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac/compositing/text-on-scaled-layer-expected.png: Added.
  • platform/chromium-mac/compositing/text-on-scaled-surface-expected.png: Added.
  • platform/chromium-mac/css3/css3-modsel-33-expected.png:
  • platform/chromium-mac/css3/css3-modsel-35-expected.png:
  • platform/chromium-mac/css3/css3-modsel-36-expected.png:
  • platform/chromium-mac/css3/css3-modsel-37-expected.png:
  • platform/chromium-mac/css3/flexbox/repaint-expected.png:
  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.png:
  • platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
4:35 PM Changeset in webkit [133820] by rniwa@webkit.org
  • 17 edits in trunk/Source/WebCore

SimplifyMarkupCommand takes a disproportionally long time to run when there are many nodes to remove
https://bugs.webkit.org/show_bug.cgi?id=101144

Reviewed by Enrica Casucci.

The bug was caused by attach() happening between each node removal. Since the command was trying
to remove millions of node in some cases, attach()ing render objects for each node being reinserted
imposed a huge runtime cost.

Fixed the bug by using lazy attach when removing nodes and avoiding calls to isContentEditable.
Also remove all ancestors at once when they are direct child/parent of each other so that we don't
remove an ancestor and then insert its child back only to remove it again in the next iteration.

No new tests since it doesn't change the asymptotic performance, and adding a new performance test for
this specific case is not the worth the increase in the bot cycle time. I'll note that the email
attached in the original radar bug (<rdar://problem/12179712>) took 100 seconds to open now only takes
7 seconds to open on my MacPro.

  • editing/AppendNodeCommand.cpp:

(WebCore::AppendNodeCommand::doApply): Takes a flag indicating whether we should assume nodes are editable
without calling isContentEditable or not.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Update the style as later code requires render
object.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::insertNodeBefore): Passes a flag to the command.
(WebCore::CompositeEditCommand::removeNode): Ditto.
(WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto.

  • editing/CompositeEditCommand.h:

(CompositeEditCommand):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeNode): Takes a flag indicating whether we should assume nodes are
editable without calling isContentEditable or not.

  • editing/DeleteSelectionCommand.h:

(DeleteSelectionCommand):

  • editing/EditCommand.h:
  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply): Update the layout when password echo is enabled since
we need to have render objects for echoing.

  • editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Ditto.
(WebCore::InsertNodeBeforeCommand::doApply): Ditto; also always use lazy attach.
(WebCore::InsertNodeBeforeCommand::doUnapply):

  • editing/InsertNodeBeforeCommand.h:

(WebCore::InsertNodeBeforeCommand::create):
(InsertNodeBeforeCommand):

  • editing/RemoveNodeCommand.cpp:

(WebCore::RemoveNodeCommand::RemoveNodeCommand): Ditto about the flag.
(WebCore::RemoveNodeCommand::doApply):

  • editing/RemoveNodeCommand.h:

(WebCore::RemoveNodeCommand::create):
(RemoveNodeCommand):

  • editing/RemoveNodePreservingChildrenCommand.cpp:

(WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): Ditto.
(WebCore::RemoveNodePreservingChildrenCommand::doApply):

  • editing/RemoveNodePreservingChildrenCommand.h:

(WebCore::RemoveNodePreservingChildrenCommand::create):
(RemoveNodePreservingChildrenCommand):

  • editing/SimplifyMarkupCommand.cpp:

(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove): Added to optimize removals of multiple
ancestors.

  • editing/SimplifyMarkupCommand.h:

(SimplifyMarkupCommand):

4:22 PM Changeset in webkit [133819] by dpranke@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Unreviewed, chromium expectations cleanup

Remove entries for a couple of passing tests and one stale pixel
result for a reftest.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac/fast/sub-pixel/float-wrap-zoom-expected.png: Removed.
  • platform/chromium/TestExpectations:
4:20 PM Changeset in webkit [133818] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r133810.
http://trac.webkit.org/changeset/133810
https://bugs.webkit.org/show_bug.cgi?id=101520

This patch made ws_single_peak_r regress by 15% (Requested by
abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::weakCallback):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
(DOMDataStore):

4:14 PM Changeset in webkit [133817] by dpranke@chromium.org
  • 3 edits
    8 deletes in trunk/LayoutTests

Unreviewed, update chromium-mac-ml expectations after r133811 and r133814.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/overflow-applies-to-007-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/overflow-applies-to-010-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/overflow-applies-to-012-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/overflow-applies-to-013-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/overflow-applies-to-014-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/overflow-applies-to-015-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/text-indent-014-expected.png: Removed.
  • platform/chromium/TestExpectations:
4:11 PM Changeset in webkit [133816] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Remove exif-orientation-image-document.html from failure list
https://bugs.webkit.org/show_bug.cgi?id=101518

Unreviewed gardening.

fast/images/exif-orientation-image-document.html passes after r133728

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-07

  • platform/efl-wk1/TestExpectations:
4:09 PM Changeset in webkit [133815] by pdr@google.com
  • 10 edits
    2 adds in trunk/LayoutTests

Rebaselinene after external SVG unblocked in WK100485
https://bugs.webkit.org/show_bug.cgi?id=101248

Unreviewed update of test expectations.

  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added property svn:mime-type.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added property svn:mime-type.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added property svn:mime-type.
  • platform/chromium/TestExpectations:
3:48 PM Changeset in webkit [133814] by dpranke@chromium.org
  • 476 edits
    475 copies
    4 adds in trunk/LayoutTests

Unreviewed, update chromium-mac-mountainlion baselines for css2.1

3:37 PM Changeset in webkit [133813] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Clean up confused use of Document::renderer and renderView
https://bugs.webkit.org/show_bug.cgi?id=101484

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-07
Reviewed by Ojan Vafai.

Document::renderer and Document::renderView are the same thing, but it seems
people don't always realize it and check if document()->renderer() is a RenderView.

This patch cleans up usage of document()->renderer() and document()->renderView() and
simplifies the code that was written without realizing they were the same thing.

No new tests, this is just a refactor.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForPoint): Lots of simplification.

  • dom/Element.cpp:

(WebCore::Element::screenRect):
(WebCore::Element::unregisterNamedFlowContentNode): Remove unneeded conditional.

  • editing/FrameSelection.cpp: Remove verbose casts.

(WebCore::clearRenderViewSelection):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::CaretBase::invalidateCaretRect):
(WebCore::FrameSelection::focusedOrActiveStateChanged):

  • page/Frame.cpp:

(WebCore::Frame::contentRenderer): Vastly simplified.

  • page/PrintContext.cpp: Remove verbose casts.

(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):

  • page/wince/FrameWinCE.cpp:

(WebCore::computePageRectsForFrame): Remove unreachable code.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::maximalOutlineSize): Remove verbose cast.

3:34 PM Changeset in webkit [133812] by mhahnenberg@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

WeakBlocks should be HeapBlocks
https://bugs.webkit.org/show_bug.cgi?id=101411

Reviewed by Oliver Hunt.

Currently WeakBlocks use fastMalloc memory. They are very similar to the other HeapBlocks, however,
so we should change them to being allocated with the BlockAllocator.

  • heap/BlockAllocator.cpp:

(JSC::BlockAllocator::BlockAllocator):

  • heap/BlockAllocator.h: Added a new RegionSet for WeakBlocks.

(JSC):
(BlockAllocator):
(JSC::WeakBlock):

  • heap/Heap.h: Friended WeakSet to allow access to the BlockAllocator.

(Heap):

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::create): Refactored to use HeapBlocks rather than fastMalloc.
(JSC::WeakBlock::WeakBlock):

  • heap/WeakBlock.h: Changed the WeakBlock size to 4 KB so that it divides evenly into the Region size.

(JSC):
(WeakBlock):

  • heap/WeakSet.cpp:

(JSC::WeakSet::~WeakSet):
(JSC::WeakSet::addAllocator):

3:25 PM Changeset in webkit [133811] by dpranke@chromium.org
  • 256 edits
    255 copies
    9 adds in trunk/LayoutTests

Unreviewed, update chromium-mac-mountainlion baselines for css2.1/2011/0323

3:11 PM Changeset in webkit [133810] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110

Reviewed by Kentaro Hara.

This patch generalizes our support for storing wrappers in DOM objects
to be usable for more than just nodes. After this patch, any object
with a ScriptWrappable base class will have its wrapper stored inline
in the object in the main world.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::weakCallback):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):

3:01 PM Changeset in webkit [133809] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
2:48 PM Changeset in webkit [133808] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-07
Reviewed by Rob Buis.

RIM PR 236997
Internally Reviewed by Jakob Petsovits.

Set font family to fix DRT test fast/forms/input-type-text-min-width.html

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::defaultGUIFont):
(WebCore):
(WebCore::RenderThemeBlackBerry::systemFont):

2:27 PM Changeset in webkit [133807] by Beth Dakin
  • 9 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=101303
Fixed position elements that are out of view still end up forcing
non-threaded scrolling
-and corresponding-
<rdar://problem/12642222>

Reviewed by Simon Fraser.

Source/WebCore:

Re-name hasNonLayerFixedObjects() to
hasVisibleSlowRepaintFixedObjects() and make it virtual.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintFixedObjects):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

Override hasVisibleSlowRepaintFixedObjects() to always return false.
We don't want to bother with the extra computation in the
ScrollingCoordinator implementation, though other ports might still
want it.

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(WebCore::ScrollingCoordinatorMac::hasVisibleSlowRepaintFixedObjects):
(ScrollingCoordinatorMac):

Make this function const so that we can call it from
requiresCompositingForPosition().

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds):

Actually be thorough here and check if the fixed object has any
descendants that are visible in the view. If it does, then we do
want to composite the fixed object.
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

  • rendering/RenderLayerCompositor.h:

LayoutTests:

New tests for an invisible fixed object that has visible children.

  • compositing/absolute-inside-out-of-view-fixed-expected.txt: Added.
  • compositing/absolute-inside-out-of-view-fixed.html: Added.
  • platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed-expected.txt: Added.
  • platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html: Added.

Updated results because these tests can now scroll on the scrolling
thread, yay!

  • platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt:
  • platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt:
1:58 PM Changeset in webkit [133806] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed. Style fix following r133262.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::clearMediaPlayer):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

1:45 PM Changeset in webkit [133805] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] DOMWrapperMap doesn't need to use virtual functions
https://bugs.webkit.org/show_bug.cgi?id=101494

Reviewed by Kentaro Hara.

DOMWrapperMap has only one subclass. There's no reason to use virtual functions.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):

  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::DOMWrapperMap):
(WebCore::DOMWrapperMap::get):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::clear):
(WebCore::DOMWrapperMap::reportMemoryUsage):
(WebCore::DOMWrapperMap::remove):
(WebCore::DOMWrapperMap::defaultWeakCallback):

  • bindings/v8/V8NPObject.cpp:

(WebCore::staticNPObjectMap):

1:42 PM Changeset in webkit [133804] by dpranke@chromium.org
  • 2 edits in trunk/Tools

garden-o-matic should handle concurrent requests
https://bugs.webkit.org/show_bug.cgi?id=101407

Reviewed by Ojan Vafai.

Garden-o-Matic is implemented on top of the BaseHttpServer
python library, which implements a single-threaded (one request at
a time) server. This means that we can only rebaseline one test at
a time, and when using a local results file, even fetching the results
for diffs is single-threaded.

Mixing in the ThreadingMixin enables concurrent requests (subject
to the global python interpreter lock). Given that we're doing all
of the work in webkit-patch subprocesses, I think this is safe.

Of course, it may not be safe to do some of the subprocesses in
parallel (e.g., rollout), but I think as long as we don't issue
commands that touch overlapping sets of files things should be fine.
The file locking over modifying testexpectations should keep that
from being corrupted.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPServer):
(GardeningHTTPRequestHandler):

1:30 PM Changeset in webkit [133803] by Alexandru Chiculita
  • 7 edits in trunk/Source/WebCore

[CSS Shaders] Remove the dependency on CustomFilterValidatedProgram from CustomFilterRenderer
https://bugs.webkit.org/show_bug.cgi?id=101071

Reviewed by Dean Jackson.

I've removed the need to get a CustomFilterValidatedProgram from FilterEffectRenderer. It was only
used to delay the compilation of the shader until it was really needed. Instead, the FilterEffectRenderer
will directly get the compiled shader in the constructor. The callers that still want to avoid
compiling the shader until it is really needed can use the setCompiledProgram to inject the shader
at a later time, before painting.

No new tests, the change is covered by the css3/filters/custom/ tests.

  • platform/graphics/filters/CustomFilterConstants.h:
  • platform/graphics/filters/CustomFilterProgramInfo.h:
  • platform/graphics/filters/CustomFilterRenderer.cpp:

(WebCore::CustomFilterRenderer::create):
(WebCore::CustomFilterRenderer::CustomFilterRenderer):
(WebCore::CustomFilterRenderer::premultipliedAlpha):
(WebCore::CustomFilterRenderer::setCompiledProgram):
(WebCore):
(WebCore::CustomFilterRenderer::prepareForDrawing):
(WebCore::CustomFilterRenderer::bindProgramAndBuffers):

  • platform/graphics/filters/CustomFilterRenderer.h:

(WebCore):
(CustomFilterRenderer):
(WebCore::CustomFilterRenderer::compiledProgram):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::prepareForDrawing):

  • platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

1:30 PM Changeset in webkit [133802] by rwlbuis@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove setUserStyleSheetString/userStyleSheetString
https://bugs.webkit.org/show_bug.cgi?id=101490

Reviewed by Yong Li.

We no longer need this API.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

  • Api/WebSettings.cpp:

(WebKit):

  • Api/WebSettings.h:
1:24 PM Changeset in webkit [133801] by pdr@google.com
  • 2 edits
    1 delete in trunk/LayoutTests

Update expectations for svg/text/text-rescale.svg

Unreviewed update of test expectations.

This test needed a rebaseline after r133786.

  • platform/chromium-win/svg/text/text-rescale-expected.png:
  • platform/efl/svg/text/text-rescale-expected.png: Removed.
1:15 PM Changeset in webkit [133800] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Indentation of ArgList.h is wrong
https://bugs.webkit.org/show_bug.cgi?id=101441

Reviewed by Andreas Kling.

Just unindented by 4 spaces.

  • runtime/ArgList.h:
1:10 PM Changeset in webkit [133799] by commit-queue@webkit.org
  • 5 edits in trunk

Remove build-webkit dependency on Java SDK for Apple Mac WebKit.
<http://webkit.org/b/101492>

Patch by Andreas Kling <akling@apple.com> on 2012-11-07
Reviewed by Anders Carlsson.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Remove WebJavaPlugIn.h

Source/WebKit/mac:

  • Plugins/WebJavaPlugIn.h: Removed.

Tools:

Don't check for a Java SDK before building the Apple Mac port. It's no longer needed for
the build after the Java bridge was removed.

  • Scripts/build-webkit:

(cMakeArgsFromFeatures):

1:08 PM Changeset in webkit [133798] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL][WK2] Allow client to override setWindowFrame() / getWindowFrame()
https://bugs.webkit.org/show_bug.cgi?id=101496

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add window_geometry_set() / window_geometry_get() smart functions to
ewk_view allowing the client to provide its own implementation for
those.

This is particularly useful if the application uses elm_win because
the default implementation will not behave correctly in this case.
This is due to the fact that the default implementation interacts
with the Ecore_Evas that contains the view and is not aware of the
parent window widget.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::windowGeometry):
(EwkViewImpl::setWindowGeometry):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::getWindowFrame):
(WebKit::PageUIClientEfl::setWindowFrame):

Tools:

Provide implementation for on_window_geometry_get() / on_window_geometry_set()
smart functions that interact with the elm_win widget.

  • MiniBrowser/efl/main.c:

(on_window_geometry_get):
(on_window_geometry_set):
(window_create):

12:54 PM Changeset in webkit [133797] by Luciano Miguel Wolf
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Adding myself to commiters.py.

12:47 PM Changeset in webkit [133796] by hans@chromium.org
  • 2 edits in trunk/Source/WTF

Fix asm operand type for weakCompareAndSwap on ARM_THUMB2
https://bugs.webkit.org/show_bug.cgi?id=101238

Reviewed by Benjamin Poulain.

'result' was a bool, but the asm was expecting a 32-bit register. A
recent version of Clang warned about this:

WebKit/Source/WTF/wtf/Atomics.h:163:34: error: the size being stored
is truncated, use a modifier to specify the size [-Werror,-Wasm-operand-widths]

This patch fixes it by making 'result' an unsigned. It does not change
the functionality in practice ('result' would be in a 32-bit register
anyway), but it makes the code more correct and makes the warning go
away.

Also make 'result' for the X86 version an 'unsigned char' to make it
more clear that it is a byte.

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

12:41 PM Changeset in webkit [133795] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2][AC] API tests crash
https://bugs.webkit.org/show_bug.cgi?id=101480

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

When AC is enabled, 8 API tests are crashing. We need to properly set the evas engine for these tests.

  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::initEcoreEvas):

12:39 PM Changeset in webkit [133794] by abarth@webkit.org
  • 5 edits
    1 delete in trunk/Source/WebCore

[V8] IntrusiveDOMWrapperMap is no longer needed and can be deleted
https://bugs.webkit.org/show_bug.cgi?id=101493

Reviewed by Kentaro Hara.

This patch is another incremental step towards landing the patch in bug

  1. In this patch, we delete IntrusiveDOMWrapperMap, which is no

longer needed.

  • WebCore.gypi:
  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
(WebCore::DOMDataStore::reportMemoryUsage):
(WebCore::DOMDataStore::weakCallback):
(WebCore):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
(DOMDataStore):

  • bindings/v8/IntrusiveDOMWrapperMap.h: Removed.
  • bindings/v8/V8GCController.cpp:
12:35 PM Changeset in webkit [133793] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Function adoptNS and adoptCF should not generate memory leak diagnostic with Clang Static Analyzer.
https://bugs.webkit.org/show_bug.cgi?id=101420

Patch by Remy Demarest <rdemarest@apple.com> on 2012-11-07
Reviewed by Benjamin Poulain.

Add attributes to the adoptNS and adoptCF function arguments to remove Clang Static Analyzer diagnotics.
Define CF_RELEASES_ARGUMENT and NS_RELEASES_ARGUMENT if not available, use them in function declarations.

  • wtf/RetainPtr.h:

(WTF::adoptCF): Adds CF_RELEASES_ARGUMENT attribute to the argument.
(WTF::adoptNS): Adds NS_RELEASES_ARGUMENT attribute to the argument.

12:34 PM Changeset in webkit [133792] by lauro.neto@openbossa.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Adding myself to commiters.py.

12:32 PM Changeset in webkit [133791] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[AC] glXChooseFBConfig() and glXGetVisualFromFBConfig() return values are leaking in GraphicsSurface
https://bugs.webkit.org/show_bug.cgi?id=101475

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Free the memory returned by glXChooseFBConfig and glXGetVisualFromFBConfig
using XFree to avoid memory leaks.

No tests. No change in behavior.

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):

12:10 PM Changeset in webkit [133790] by fsamuel@chromium.org
  • 4 edits in trunk/Source/WebCore

Autoresize should work even if turned on while the page is loading.
https://bugs.webkit.org/show_bug.cgi?id=101380

Reviewed by David Levin.

Autoresize does not work in cases where it is turned on while loading.
This patch addresses this by allowing autoSize to complete if it's turned on
while loading and doing a final pass after loading.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkCompleted):
Adjust to call renamed function.

  • page/FrameView.cpp:

(WebCore::FrameView::handleLoadCompleted):
Rename function to encompass its expanded responsibilities (which include doing the final auto size after the load is completed).
(WebCore::FrameView::autoSizeIfEnabled):
Allow the size to shrink if autosize is adjusted while the page is loading.

  • page/FrameView.h:

(FrameView):
Renamed 'checkFlushDeferredRepaintsAfterLoadComplete' to 'handleLoadComplete'

11:49 AM Changeset in webkit [133789] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Open link in this window action
https://bugs.webkit.org/show_bug.cgi?id=101226

Patch by Allan Sandfeld Jensen <allan.jensen@digia.com> on 2012-11-07
Reviewed by Csaba Osztrogonác.

  • Api/qwebpage.cpp: Fix after r133763, move the initialization of OpenLinkInThisWindow to the proper place.
11:35 AM Changeset in webkit [133788] by eae@chromium.org
  • 2 edits in trunk/Source/WebKit/efl

Unreviewed EFL build fix.

  • ewk/ewk_view.cpp:
11:31 AM Changeset in webkit [133787] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

Add API for touchEventHandlerRegion to WebLayer
https://bugs.webkit.org/show_bug.cgi?id=101406

Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-11-07
Reviewed by James Robinson.

These will be used to keep track of JavaScript touch event handlers from the compositor thread.

  • chromium/public/WebLayer.h:

(WebKit::WebLayer::setTouchEventHandlerRegion):
(WebKit::WebLayer::touchEventHandlerRegion):
(WebLayer):

11:26 AM Changeset in webkit [133786] by pdr@google.com
  • 11 edits in trunk

Skip SVG repaint tracking when parent container transforms
https://bugs.webkit.org/show_bug.cgi?id=101177

Reviewed by Eric Seidel.

Source/WebCore:

This patch skips child repaint rect checks when a parent container is transformed, leading
to a 75% increase on the RoboHornet SVG benchmark:

http://www.robohornet.org/#et=svg (average of 2 runs)
Before patch: 161.6ms
After patch: 38.5ms

SVG transforms are relative to the local container which makes calculating an absolute
repaint rect expensive because it requires multiplying the local repaint rect by each
parent container's local transform. See SVGRenderSupport::computeFloatRectForRepaint
as an example of this calculation.

This patch takes advantage of SVG's container rules: when a parent container's transform
changes, all children must be repainted (there is no absolute positioning in SVG).
SVGRenderSupport::checkForSVGRepaintDuringLayout has been added which checks for whether
the parent transform changed before doing child repaint checks. A similar optimization is
used in HTML (see RenderObject::checkForRepaintDuringLayout) where no repaint checking
is done when the view is fully repainted.

This code is tested in existing tests.

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::layout):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::layout):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::checkForSVGRepaintDuringLayout):
(WebCore):

  • rendering/svg/SVGRenderSupport.h:

(SVGRenderSupport):

LayoutTests:

The repaint area in svg/repaint/inner-svg-change-viewBox.svg has
been tightened as a result of this patch.

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
11:24 AM Changeset in webkit [133785] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: Textfields don't get focus when navigated to from 'show all tabs' button
https://bugs.webkit.org/show_bug.cgi?id=101369

Reviewed by Darin Adler.

When focus leaves a webpage, the webpage does not normally clear its focused node. When focus
returns (through tab, or mouse click), then focus will be cleared and restored.

However, when focus is returned through accessibility means, focus is not cleared first, which
means subsequent focus actions do nothing.

This fix will check if the focused node is the same as the node being focused, and if so, clear the focus first.

Making a layout test for this is not possible because it requires setting focus to something in the chrome, and then
moving focus back to the webpage.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setFocused):

11:02 AM Changeset in webkit [133784] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Text on scaled layer is blurry
https://bugs.webkit.org/show_bug.cgi?id=101491

Unreviewed gardening.

Mark tests as ImageOnlyFailure.

  • platform/qt-5.0-wk2/TestExpectations:
10:59 AM Changeset in webkit [133783] by abarth@webkit.org
  • 14 edits
    2 deletes in trunk/Source

[V8] We should hide the DOMWrapperMaps inside DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101430

Reviewed by Kentaro Hara.

Source/WebCore:

This is yet another incremental step towards landing the patch in bug

  1. In this patch, we hide the existence of DOMWrapperMaps inside

DOMDataStore. In the process, we can remove V8DOMMap.cpp.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::set):

  • bindings/v8/DOMWrapperWorld.h:
  • bindings/v8/ScriptProfiler.cpp:
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::neuterBinding):

  • bindings/v8/V8DOMMap.cpp: Removed.
  • bindings/v8/V8DOMMap.h: Removed.
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):
(WebCore::V8DOMWrapper::setWrapperClass):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):

  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/WorkerScriptController.cpp:

Source/WebKit/chromium:

Remove unneeded header includes.

  • src/WebScriptController.cpp:
10:53 AM Changeset in webkit [133782] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

Enable text dump in fast/forms/file/get-file-upload.html earlier.
https://bugs.webkit.org/show_bug.cgi?id=101468

Reviewed by Kentaro Hara.

Do not call testRunner.dumpAsText() only when processing the form
submission, since that will not be triggered if a port does not
support, say, beginDragWithFiles(), and a useless pixel result
will be generated in that case.

Instead, call dumpAsText() as early as possible.

  • fast/forms/file/get-file-upload.html:
10:49 AM Changeset in webkit [133781] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[Qt][ARM] REGRESSION(r133688): It made all JSC and layout tests crash on ARM traditional platform
https://bugs.webkit.org/show_bug.cgi?id=101465

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-07
Reviewed by Oliver Hunt.

Fix failing javascriptcore tests on ARM after r133688

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

10:37 AM Changeset in webkit [133780] by commit-queue@webkit.org
  • 9 edits in trunk

Add new gesture type, LongTap, which is basically the completion of a GestureLongPress
https://bugs.webkit.org/show_bug.cgi?id=101385

Patch by Varun Jain <varunjain@chromium.org> on 2012-11-07
Reviewed by Adam Barth.

Test: Only creating the new enum. No functionality change, hence no tests required.

Source/WebCore:

  • platform/PlatformEvent.h:

Source/WebKit/chromium:

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isGestureEventType):

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::handleInputEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

10:33 AM Changeset in webkit [133779] by eae@chromium.org
  • 116 edits
    9 moves
    1 add
    3 deletes in trunk/Source

Remove LayoutTypes abstraction
https://bugs.webkit.org/show_bug.cgi?id=93050

Reviewed by Levi Weintraub.

Remove LayoutTypes abstraction and rename FractionalLayout* to
Layout* now that all platforms use the FractionalLayout version
(albeit with different fractions).

No new tests, no change in functionality.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityNodeObject.cpp:
  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.h:
  • css/LengthFunctions.cpp:
  • css/LengthFunctions.h:
  • dom/Document.h:
  • dom/DocumentMarkerController.h:
  • dom/ElementRareData.h:
  • dom/MouseRelatedEvent.h:
  • dom/Node.h:
  • dom/Touch.h:
  • editing/FrameSelection.cpp:
  • editing/FrameSelection.h:
  • editing/RenderedPosition.h:
  • html/HTMLAreaElement.h:
  • inspector/InspectorOverlay.h:
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:
  • inspector/TimelineRecordFactory.h:
  • loader/cache/CachedImage.h:
  • page/FocusController.h:
  • page/FrameView.h:
  • page/Page.h:
  • page/SpatialNavigation.cpp:
  • page/SpatialNavigation.h:
  • platform/FractionalLayoutUnit.h: Removed.
  • platform/LayoutUnit.h: Copied from Source/WebCore/platform/FractionalLayoutUnit.h.
  • platform/Length.h:
  • platform/PopupMenuClient.h:
  • platform/animation/AnimationUtilities.h:
  • platform/graphics/FloatPoint.cpp:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.cpp:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.cpp:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FractionalLayoutBoxExtent.cpp: Removed.
  • platform/graphics/FractionalLayoutBoxExtent.h: Removed.
  • platform/graphics/FractionalLayoutPoint.h: Removed.
  • platform/graphics/FractionalLayoutRect.cpp: Removed.
  • platform/graphics/FractionalLayoutRect.h: Removed.
  • platform/graphics/FractionalLayoutSize.h: Removed.
  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayerAnimation.cpp:
  • platform/graphics/IntRect.cpp:
  • platform/graphics/IntRect.h:
  • platform/graphics/LayoutBoxExtent.cpp: Copied from Source/WebCore/platform/graphics/FractionalLayoutBoxExtent.cpp.
  • platform/graphics/LayoutBoxExtent.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutBoxExtent.h.
  • platform/graphics/LayoutPoint.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutPoint.h.
  • platform/graphics/LayoutRect.cpp: Copied from Source/WebCore/platform/graphics/FractionalLayoutRect.cpp.
  • platform/graphics/LayoutRect.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutRect.h.
  • platform/graphics/LayoutSize.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutSize.h.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/filters/CustomFilterOperation.h:
  • platform/graphics/filters/CustomFilterParameterList.h:
  • platform/graphics/filters/FilterOperation.h:
  • platform/graphics/filters/FilterOperations.h:
  • platform/graphics/filters/ValidatedCustomFilterOperation.cpp:
  • platform/graphics/filters/ValidatedCustomFilterOperation.h:
  • platform/graphics/qt/FractionalLayoutPointQt.cpp: Removed.
  • platform/graphics/qt/FractionalLayoutRectQt.cpp: Removed.
  • platform/graphics/qt/FractionalLayoutSizeQt.cpp: Removed.
  • platform/graphics/qt/LayoutPointQt.cpp: Copied from Source/WebCore/platform/graphics/qt/FractionalLayoutPointQt.cpp.
  • platform/graphics/qt/LayoutRectQt.cpp: Added.
  • platform/graphics/qt/LayoutSizeQt.cpp: Copied from Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp.
  • platform/graphics/transforms/TransformOperations.h:
  • platform/graphics/transforms/TransformState.h:
  • platform/graphics/transforms/TransformationMatrix.cpp:
  • platform/graphics/transforms/TransformationMatrix.h:
  • rendering/AutoTableLayout.h:
  • rendering/ColumnInfo.h:
  • rendering/ExclusionShapeInsideInfo.h:
  • rendering/FilterEffectRenderer.h:
  • rendering/FixedTableLayout.h:
  • rendering/GapRects.h:
  • rendering/HitTestResult.h:
  • rendering/HitTestingTransformState.cpp:
  • rendering/HitTestingTransformState.h:
  • rendering/InlineFlowBox.cpp:
  • rendering/LayoutRepainter.cpp:
  • rendering/LayoutRepainter.h:
  • rendering/LayoutState.h:
  • rendering/LayoutTypes.h:
  • rendering/LayoutTypesInlineMethods.h:
  • rendering/PaintInfo.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderDeprecatedFlexibleBox.cpp:
  • rendering/RenderFieldset.cpp:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderFlowThread.cpp:
  • rendering/RenderGeometryMap.h:
  • rendering/RenderImageResource.h:
  • rendering/RenderInline.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerFilterInfo.h:
  • rendering/RenderLineBoxList.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderMarquee.cpp:
  • rendering/RenderMenuList.h:
  • rendering/RenderMultiColumnBlock.cpp:
  • rendering/RenderMultiColumnSet.cpp:
  • rendering/RenderNamedFlowThread.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderOverflow.h:
  • rendering/RenderRegion.cpp:
  • rendering/RenderReplaced.cpp:
  • rendering/RenderTable.cpp:
  • rendering/RenderTable.h:
  • rendering/RenderText.cpp:
  • rendering/RenderThemeChromiumCommon.cpp:
  • rendering/RenderThemeChromiumCommon.h:
  • rendering/RenderTreeAsText.cpp:
  • rendering/RenderTreeAsText.h:
  • rendering/RenderView.h:
  • rendering/style/NinePieceImage.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/ShadowData.cpp:
  • rendering/style/ShadowData.h:
  • rendering/style/StyleCachedImageSet.h:
  • rendering/style/StyleImage.h:
  • rendering/svg/SVGRenderSupport.h:

Source/WebKit/chromium:

  • src/LinkHighlight.cpp:
10:33 AM Changeset in webkit [133778] by peter@chromium.org
  • 2 edits in trunk/Tools

Don't show the Android tester in garden-o-matic yet
https://bugs.webkit.org/show_bug.cgi?id=101476

Reviewed by Adam Barth.

The Android tester just started running layout tests, and doesn't upload its
results yet. Don't show it for now. This exception will be removed once it
has a baseline of greenness.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

(.):

10:29 AM Changeset in webkit [133777] by Alexandru Chiculita
  • 5 edits in trunk/Source

CoordinatedGraphicsArgumentCoders should use ValidatedCustomFitlerOperation instead
https://bugs.webkit.org/show_bug.cgi?id=100905

Reviewed by Noam Rosenthal.

Source/WebCore:

Added getters for the validated shaders, so that platform code could extract them.

No new tests, just added two getters.

  • platform/graphics/filters/CustomFilterValidatedProgram.h:

(WebCore::CustomFilterValidatedProgram::validatedVertexShader):
(WebCore::CustomFilterValidatedProgram::validatedFragmentShader):
(CustomFilterValidatedProgram):

Source/WebKit2:

The code now knows how to read a ValidatedCustomFitlerOperation and serialize it to the UI process.

No new tests, the code path is not used yet.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/CoordinatedGraphics/WebCustomFilterProgram.h:
10:26 AM Changeset in webkit [133776] by jsbell@chromium.org
  • 5 edits
    3 adds in trunk

IndexedDB: Assertion failure with open() within upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=96947

Reviewed by Dimitri Glazkov.

Source/WebCore:

Postpone creation of the "pending second half open" until the version change
transaction has started.

Test: storage/indexeddb/unblocked-version-changes.html

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setIntVersionInternal):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseCallbacks.h:

LayoutTests:

Exercise the code path leading to the assert by having a second version change transaction
unblocked by the first's connection closing. Includes a known failure due to metadata
snapshot timing.

  • storage/indexeddb/resources/unblocked-version-changes.js: Added.

(test):
(openConnection):
(onUpgradeNeeded):
(onError):
(onUpgradeNeeded2):
(onSuccess):

  • storage/indexeddb/unblocked-version-changes-expected.txt: Added.
  • storage/indexeddb/unblocked-version-changes.html: Added.
10:20 AM Changeset in webkit [133775] by Lucas Forschler
  • 8 edits in branches/safari-536.28-branch/Source/WebCore

Merged r129652. <rdar://problem/12516382>

9:57 AM Changeset in webkit [133774] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-536.28-branch

Merged r129535. <rdar://problem/12536360>

9:55 AM Changeset in webkit [133773] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.28-branch

Merged r129469. <rdar://problem/12536545>

9:48 AM Changeset in webkit [133772] by Simon Fraser
  • 1 edit
    17 adds in trunk/LayoutTests

Fix failing platform/mac/tiled-drawing on Lion.

It's not possible to use TestExpectations to skip tests on all but current mac-wk2,
so just land results for Lion.

  • platform/mac-lion/platform/mac/tiled-drawing/fixed/absolute-inside-fixed-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/fixed/fixed-in-overflow-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/fixed/four-bars-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/fixed/percentage-inside-fixed-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/scrolling-tree-after-scroll-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/tile-coverage-after-scroll-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/tiled-drawing-zoom-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Added.
9:46 AM Changeset in webkit [133771] by Alexandru Chiculita
  • 5 edits in trunk/Source/WebCore

[CSS Shaders] Add CustomFilterMeshBoxType to ValidatedCustomFilterOperation
https://bugs.webkit.org/show_bug.cgi?id=100890

Reviewed by Dean Jackson.

Added the CustomFilterMeshBoxType parameter to the ValidatedCustomFilterOperation.

No new tests, this parameter is not used in the implementation yet.

  • platform/graphics/filters/ValidatedCustomFilterOperation.cpp:

(WebCore::ValidatedCustomFilterOperation::ValidatedCustomFilterOperation):

  • platform/graphics/filters/ValidatedCustomFilterOperation.h:

(WebCore::ValidatedCustomFilterOperation::create):
(WebCore::ValidatedCustomFilterOperation::meshBoxType):
(WebCore::ValidatedCustomFilterOperation::operator==):
(ValidatedCustomFilterOperation):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::createCustomFilterEffect):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeFilterOperations):

9:39 AM Changeset in webkit [133770] by sergio@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Implement deleteCookie() for persistent storage
https://bugs.webkit.org/show_bug.cgi?id=101272

Reviewed by Jocelyn Turcotte.

Individual cookies were never persistently cleared as the
deleteCookie() virtual method was not implemented for persistent
storage. That's why cookies were only deleted for the current
session.

  • platform/qt/CookieJarQt.cpp:

(WebCore::SharedCookieJarQt::deleteCookie):
(WebCore): added deleteCookie() implementation for persistent
storage.

  • platform/qt/CookieJarQt.h:

(SharedCookieJarQt):

9:35 AM Changeset in webkit [133769] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

[Shadow] Style should update when 'pseudo' attribute is dynamically updated
https://bugs.webkit.org/show_bug.cgi?id=100918

Reviewed by Dimitri Glazkov.

Source/WebCore:

When 'pseudo' attribute is changed and its element is in ShadowTree, we enable the styleShouldRecalc flag.

It would be fast if we have a set of pseudo attribute style value in RuleFeatureSet,
but it might consume a lot of memory.

Test: fast/dom/shadow/pseudo-attribute-dynamic.html

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

LayoutTests:

  • fast/dom/shadow/pseudo-attribute-dynamic-expected.html: Added.
  • fast/dom/shadow/pseudo-attribute-dynamic.html: Added.
9:33 AM Changeset in webkit [133768] by kbalazs@webkit.org
  • 5 edits in trunk/Tools

WebKitTestRunner flakily hangs when running pixel tests on Qt
https://bugs.webkit.org/show_bug.cgi?id=100686

Reviewed by Csaba Osztrogonác.

Make WebKitTestRunner harden against the situation when the coordinated
graphics rendering synchronisation fails. If we time out when waiting
for the forced repaint to finish it usually a symptom of the synchronisation
has been broken. In this case all other tests will fail with the same error.
The underlying problem is not yet known. Ths patch make us report this situation
as web process unresponsiveness, so the test harness will kill us and launch
a new instance. This will make our pixel test bot usable while it should not limit
us debugging the underlying bug.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::run):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dumpWebProcessUnresponsiveness):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation): Introduce new members to hold our state
that was local to invoke() so far.

  • WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

9:30 AM Changeset in webkit [133767] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations update.

  • platform/chromium/TestExpectations:
9:14 AM Changeset in webkit [133766] by jsbell@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening. Rebaseline the tests added
in http://trac.webkit.org/changeset/133686 - part deux.

  • platform/chromium-win/fast/backgrounds/transformed-body-background-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/transformed-body-html-background-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/transformed-html-body-background-expected.png: Added.
9:12 AM Changeset in webkit [133765] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] WebKit sends unnecessary low memory notification when running memory benchmarks
https://bugs.webkit.org/show_bug.cgi?id=101474

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-11-07
Reviewed by Kentaro Hara.

Do not send low memory notification to V8 when most of memory usage
comes from V8 heap and not DOM objects. In this case V8 can schedule GC
itself more optimally.

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

8:28 AM Changeset in webkit [133764] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07

  • DEPS:
8:12 AM Changeset in webkit [133763] by allan.jensen@digia.com
  • 10 edits in trunk

[Qt] Open link in this window action
https://bugs.webkit.org/show_bug.cgi?id=101226

Reviewed by Simon Hausmann.

Source/WebCore:

Adds the action to the WebCore context-menu controller.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

  • platform/ContextMenuItem.h:
  • platform/LocalizedStrings.h:
  • platform/qt/LocalizedStringsQt.cpp:

(WebCore::contextMenuItemTagOpenLinkInThisWindow):

Source/WebKit/qt:

Adds the action to QtWebKit.

  • Api/qwebpage.cpp:

(webActionForContextMenuAction):
(QWebPage::triggerAction):
(QWebPage::action):

  • Api/qwebpage.h:

Tools:

Populates the context-menu with the new action when the default action is to open in a new window.

  • QtTestBrowser/webview.cpp:

(createContextMenu):

8:05 AM Changeset in webkit [133762] by vsevik@chromium.org
  • 2 edits in branches/chromium/1312/Source/WebCore/inspector/front-end

Merge 133750 - Web Inspector: [Regression] Editing formatted source should not be allowed.
https://bugs.webkit.org/show_bug.cgi?id=101355

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):

  • inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):

TBR=vsevik@chromium.org
BUG=159820
Review URL: https://codereview.chromium.org/11377027

8:04 AM Changeset in webkit [133761] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL][WK2] Add ewk_settings_preferred_minimum_contents_width_get/set API
https://bugs.webkit.org/show_bug.cgi?id=101467

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Added ewk_settings_preferred_minimum_contents_width_get/set API which is used for setting/getting
of default minimum contents width for non viewport meta element sites.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_preferred_minimum_contents_width_set):
(ewk_settings_preferred_minimum_contents_width_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

Tools:

Added ewk_settings_preferred_minimum_contents_width_get/set API which is used for setting/getting
of default minimum contents width for non viewport meta element sites.
Set default minimum contents width to '0' for MiniBrowser as it should behave like desktop browser.

  • MiniBrowser/efl/main.c:

(window_create):

7:16 AM Changeset in webkit [133760] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Avoid creating an empty surface
https://bugs.webkit.org/show_bug.cgi?id=101464

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Make sure we have a valid view size before creating a GL surface.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_calculate):

7:13 AM Changeset in webkit [133759] by vsevik@chromium.org
  • 3 edits in trunk/LayoutTests

Layout Test inspector/debugger/script-formatter-breakpoints.html is failing
https://bugs.webkit.org/show_bug.cgi?id=101361

Unreviewed test fix.

  • inspector/debugger/script-formatter-breakpoints.html:
  • platform/chromium/TestExpectations:
7:07 AM Changeset in webkit [133758] by kbalazs@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening

Some image expectetions was accidentally added for reference tests and it consused nrwt.
Deleted them.

  • platform/qt-5.0-wk2/compositing/text-on-scaled-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/text-on-scaled-surface-expected.png: Removed.
  • platform/qt/css2.1/20110323/margin-collapse-clear-016-expected.png: Removed.
  • platform/qt/svg/animations/animateMotion-additive-2c-expected.png: Removed.
7:05 AM Changeset in webkit [133757] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Add EFL to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=101444

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Added the EFL bots running layout tests to the garden-o-matic report
page. We are skipping here the bot that just builds WebKit EFL to make
the data fetching faster.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

(.):

6:58 AM Changeset in webkit [133756] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a timeout expectation for the test introduced in r133660.
Adding timeout expectations for two media tests that started timing
out probably after r133633.

  • platform/gtk/TestExpectations:
6:55 AM Changeset in webkit [133755] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][UNIX] Crash in WebKit::PluginProcessProxy::scanPlugin()
https://bugs.webkit.org/show_bug.cgi?id=101446

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Make sure that the disposition of the SIGCHLD signal is reset to the default
before calling g_spawn_sync(). If the disposition is set to SIG_IGN, then
g_spawn_sync() will not be able to return the exit status of the child
process, our exit failure check will be useless and the following warning
will be printed:

GLib-WARNING : In call to g_spawn_sync(), exit status of a child process
was requested but SIGCHLD action was set to SIG_IGN and ECHILD was received
by waitpid(), so exit status can't be returned. This is a bug in the
program calling g_spawn_sync(); either don't request the exit status, or
don't set the SIGCHLD action.

This patch also adds a NULL-check for stdOut to avoid crashing in such
case and makes use of String::split() to parse stdOut instead of doing it
manually.

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

6:52 AM Changeset in webkit [133754] by dominik.rottsches@intel.com
  • 7 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaselining a few ruby tests.

  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png:
  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
6:42 AM Changeset in webkit [133753] by Csaba Osztrogonác
  • 1 edit
    3 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening after r133688, remove unnecessary platform specific expected files.

  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Removed.
6:37 AM Changeset in webkit [133752] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] closure compiler fixes
https://bugs.webkit.org/show_bug.cgi?id=101459

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-07
Reviewed by Pavel Feldman.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

6:18 AM Changeset in webkit [133751] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r133712.
http://trac.webkit.org/changeset/133712
https://bugs.webkit.org/show_bug.cgi?id=101461

Broke fast/forms/time* tests on chromium-win. (Requested by
mkwst on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07

  • platform/text/win/LocaleWin.cpp:

(WebCore::DateFormatToken::DateFormatToken):
(DateFormatToken):
(WebCore):
(WebCore::isEraSymbol):
(WebCore::isYearSymbol):
(WebCore::isMonthSymbol):
(WebCore::isDaySymbol):
(WebCore::commitLiteralToken):
(WebCore::parseDateFormat):
(WebCore::LocaleWin::ensureShortDateTokens):
(WebCore::convertWindowsDateFormatToLDML):
(WebCore::mapCharacterToDateTimeFieldType):
(WebCore::convertWindowsTimeFormatToLDML):
(WebCore::LocaleWin::dateFormat):
(WebCore::LocaleWin::monthFormat):
(WebCore::LocaleWin::timeFormat):
(WebCore::LocaleWin::shortTimeFormat):

  • platform/text/win/LocaleWin.h:

(LocaleWin):

6:14 AM Changeset in webkit [133750] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Regression] Editing formatted source should not be allowed.
https://bugs.webkit.org/show_bug.cgi?id=101355

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):

  • inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):

6:13 AM Changeset in webkit [133749] by shinyak@chromium.org
  • 21 edits in trunk

[Shadow] Use setPseudo() instead of setShadowPseudoId().
https://bugs.webkit.org/show_bug.cgi?id=101306

Reviewed by Kent Tamura.

.:

Exposes necessary symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

We would like to remove setShadowPseudoId() and use setPseudo() instead, since ShadowDOM spec now has
'pseudo' attribute.

We change all setShadowPseudoId() invocation to setPseudo() invocation. Also, when AtomicString is not
constructed with AtomicStringFromLiteral, we use it.

No new tests, refactoring.

  • WebCore.exp.in:
  • dom/Element.cpp:
  • dom/Element.h:

(Element):

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::initialize):

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement):

  • html/shadow/PickerIndicatorElement.cpp:

(WebCore::PickerIndicatorElement::PickerIndicatorElement):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCue::updateDisplayTree):

  • testing/Internals.cpp:

(WebCore::Internals::setShadowPseudoId):

Source/WebKit2:

Exposes necessary symbols.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
5:57 AM Changeset in webkit [133748] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

navigator-vibration.html is still crashing occasionally.

  • platform/efl-wk2/TestExpectations:
5:53 AM Changeset in webkit [133747] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Web Inspector: [Canvas] Save CanvasGradient objects state for a replay
https://bugs.webkit.org/show_bug.cgi?id=101432

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-07
Reviewed by Pavel Feldman.

Source/WebCore:

Save CanvasGradient resource state for a subsequent replay. The gradient's state is modified by the gradient.addColorStop() call.

Test: inspector/profiler/canvas2d/canvas2d-gradient-capturing.html

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

LayoutTests:

Alerts about API changes to CanvasGradient and CanvasPattern classes.
Checks capturing for CanvasGradient objects' state.

  • inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt:
  • inspector/profiler/canvas2d/canvas2d-api-changes.html:
  • inspector/profiler/canvas2d/canvas2d-gradient-capturing-expected.txt: Added.
  • inspector/profiler/canvas2d/canvas2d-gradient-capturing.html: Added.
5:51 AM Changeset in webkit [133746] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [Regression] Snippets evaluations should not appear in Sources tab of navigator.
https://bugs.webkit.org/show_bug.cgi?id=101354

Reviewed by Pavel Feldman.

  • inspector/front-end/DebuggerScriptMapping.js:
  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.isSnippet):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._snippetIdForSourceURL):

5:50 AM Changeset in webkit [133745] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

fast/repaint/block-selection-gap-in-table-cell.html is not
rendering correctly, so skip it when running pixel tests. Need a

  • platform/efl/TestExpectations:
5:45 AM Changeset in webkit [133744] by commit-queue@webkit.org
  • 39 edits in trunk

[EFL][WK2] Make EWK classes Ewk_Objects
https://bugs.webkit.org/show_bug.cgi?id=101057

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Now all the existing EWK classes share common Ewk_Object ref/unref API.

Source/WebKit2:

  • UIProcess/API/efl/EwkViewCallbacks.h:
  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

  • UIProcess/API/efl/ewk_database_manager.cpp:

(Ewk_Database_Manager::createOriginList):

  • UIProcess/API/efl/ewk_database_manager_private.h:
  • UIProcess/API/efl/ewk_file_chooser_request.cpp:

(EwkFileChooserRequest::EwkFileChooserRequest):
(EwkFileChooserRequest::~EwkFileChooserRequest):
(EwkFileChooserRequest::allowMultipleFiles):
(EwkFileChooserRequest::acceptedMIMETypes):
(EwkFileChooserRequest::cancel):
(EwkFileChooserRequest::chooseFiles):
(ewk_file_chooser_request_allow_multiple_files_get):
(ewk_file_chooser_request_accepted_mimetypes_get):
(ewk_file_chooser_request_cancel):
(ewk_file_chooser_request_files_choose):
(ewk_file_chooser_request_file_choose):

  • UIProcess/API/efl/ewk_file_chooser_request.h:
  • UIProcess/API/efl/ewk_file_chooser_request_private.h:

(EwkFileChooserRequest):
(EwkFileChooserRequest::create):

  • UIProcess/API/efl/ewk_form_submission_request.cpp:

(EwkFormSubmissionRequest::EwkFormSubmissionRequest):
(EwkFormSubmissionRequest::~EwkFormSubmissionRequest):
(EwkFormSubmissionRequest::fieldValue):
(EwkFormSubmissionRequest::fieldNames):
(EwkFormSubmissionRequest::submit):
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):
(ewk_form_submission_request_submit):

  • UIProcess/API/efl/ewk_form_submission_request.h:
  • UIProcess/API/efl/ewk_form_submission_request_private.h:

(EwkFormSubmissionRequest):
(EwkFormSubmissionRequest::create):

  • UIProcess/API/efl/ewk_intent.cpp:

(EwkIntent::EwkIntent):
(EwkIntent::webIntentData):
(EwkIntent::action):
(EwkIntent::type):
(EwkIntent::service):
(EwkIntent::suggestions):
(EwkIntent::extra):
(EwkIntent::extraKeys):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):

  • UIProcess/API/efl/ewk_intent.h:
  • UIProcess/API/efl/ewk_intent_private.h:

(EwkIntent):
(EwkIntent::create):

  • UIProcess/API/efl/ewk_intent_service.cpp:

(EwkIntentService::EwkIntentService):
(EwkIntentService::action):
(EwkIntentService::type):
(EwkIntentService::href):
(EwkIntentService::title):
(EwkIntentService::disposition):
(ewk_intent_service_action_get):
(ewk_intent_service_type_get):
(ewk_intent_service_href_get):
(ewk_intent_service_title_get):
(ewk_intent_service_disposition_get):

  • UIProcess/API/efl/ewk_intent_service.h:
  • UIProcess/API/efl/ewk_intent_service_private.h:

(EwkIntentService):
(EwkIntentService::create):

  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(EwkNavigationPolicyDecision::EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::~EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::navigationType):
(EwkNavigationPolicyDecision::mouseButton):
(EwkNavigationPolicyDecision::modifiers):
(EwkNavigationPolicyDecision::frameName):
(EwkNavigationPolicyDecision::request):
(EwkNavigationPolicyDecision::accept):
(EwkNavigationPolicyDecision::reject):
(EwkNavigationPolicyDecision::download):
(ewk_navigation_policy_navigation_type_get):
(ewk_navigation_policy_mouse_button_get):
(ewk_navigation_policy_modifiers_get):
(ewk_navigation_policy_frame_name_get):
(ewk_navigation_policy_request_get):
(ewk_navigation_policy_decision_accept):
(ewk_navigation_policy_decision_reject):
(ewk_navigation_policy_decision_download):

  • UIProcess/API/efl/ewk_navigation_policy_decision.h:
  • UIProcess/API/efl/ewk_navigation_policy_decision_private.h:

(EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::create):

  • UIProcess/API/efl/ewk_resource.cpp:

(EwkResource::EwkResource):
(EwkResource::url):
(EwkResource::isMainResource):
(ewk_resource_url_get):
(ewk_resource_main_resource_get):

  • UIProcess/API/efl/ewk_resource.h:
  • UIProcess/API/efl/ewk_resource_private.h:

(EwkResource):
(EwkResource::create):

  • UIProcess/API/efl/ewk_security_origin.cpp:

(EwkSecurityOrigin::EwkSecurityOrigin):
(EwkSecurityOrigin::host):
(EwkSecurityOrigin::protocol):
(EwkSecurityOrigin::port):
(ewk_security_origin_host_get):
(ewk_security_origin_protocol_get):
(ewk_security_origin_port_get):

  • UIProcess/API/efl/ewk_security_origin.h:
  • UIProcess/API/efl/ewk_security_origin_private.h:

(EwkSecurityOrigin):
(EwkSecurityOrigin::create):

  • UIProcess/API/efl/ewk_storage_manager.cpp:

(Ewk_Storage_Manager::createOriginList):

  • UIProcess/API/efl/ewk_url_scheme_request_private.h:

(EwkUrlSchemeRequest):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_intent_deliver):

  • UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:

(onFileChooserRequest):
(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:

(TEST_F):

  • UIProcess/efl/FormClientEfl.cpp:

(WebKit::FormClientEfl::willSubmitForm):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):

  • UIProcess/efl/PagePolicyClientEfl.cpp:

(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):

  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::runOpenPanel):

  • UIProcess/efl/ResourceLoadClientEfl.cpp:

(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):

  • UIProcess/efl/ResourceLoadClientEfl.h:

Tools:

  • MiniBrowser/efl/main.c:

(close_file_picker):
(on_file_chooser_request):

5:42 AM Changeset in webkit [133743] by keishi@webkit.org
  • 2 edits in branches/chromium/1312/Source/WebKit/chromium

Merge 133132 - [Chromium] Page popup shows up at wrong locations when root view is scrolled
https://bugs.webkit.org/show_bug.cgi?id=100830

Reviewed by Kent Tamura.

We need to account for the scroll position when calculating the root view rectangle in the screen.

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument):

TBR=keishi@webkit.org
Review URL: https://codereview.chromium.org/11275190

5:35 AM Changeset in webkit [133742] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed inspector test polish.
Made http/tests/indexeddb/database-data.html test faster, added more verbose errors for test debugging.

  • http/tests/inspector/indexeddb/database-data-expected.txt:
  • http/tests/inspector/indexeddb/database-data.html:
  • http/tests/inspector/indexeddb/indexeddb-test.js:

(onIndexedDBError):
(onIndexedDBBlocked):
(doWithDatabase):

5:35 AM Changeset in webkit [133741] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Return earlier if a plugin snapshot cannot be created.
https://bugs.webkit.org/show_bug.cgi?id=101445

Reviewed by Kenneth Rohde Christiansen.

Currently only the Mac port has support for creating snapshots of
Netscape plugins. Return earlier in PluginProxy::snapshot() so
that we do not pass a null handler to ShareableBitmap::create()
and avoid crashing when running pixel tests with plugins.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::snapshot):

5:33 AM Changeset in webkit [133740] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Change encoding detector API names
https://bugs.webkit.org/show_bug.cgi?id=101450

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-07
Reviewed by Gyuyoung Kim.

To make settings API name consistent, we need to change two APIs with respect to encoding detector.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_encoding_detector_enabled_set):
(ewk_settings_encoding_detector_enabled_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

5:15 AM Changeset in webkit [133739] by rakuco@webkit.org
  • 8 edits
    4 adds in trunk/LayoutTests

[EFL] Gardening. Add or fix a few pixel expectations.

  • platform/efl/compositing/plugins/composited-plugin-expected.png:
  • platform/efl/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png:
  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/efl/plugins/iframe-plugin-bgcolor-expected.png: Added.
  • platform/efl/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
  • platform/efl/plugins/netscape-dom-access-expected.png: Added.
5:14 AM Changeset in webkit [133738] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Unreviewed. Add Qt EWS bots to the watchers list.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(QtEWS):
(QtWK2EWS):

4:55 AM Changeset in webkit [133737] by senorblanco@chromium.org
  • 1 edit
    7 deletes in trunk/LayoutTests

Now that it no longer produces image results, remove unnecessary
PNGs for crash-hw-sw-switch.html. Unreviewed.

  • platform/chromium-android/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
4:39 AM Changeset in webkit [133736] by g.czajkowski@samsung.com
  • 9 edits
    3 adds in trunk

Source/WebKit2: WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Reviewed by Gyuyoung Kim.

When WebKitTestRunner turns on the spelling feature with the resetStateToConsistentValues() method,
it happens that the WebProcess is still not launched (although it is already created).
In this case, isValid() method returns false.

This fix sends a message to the WebProcess messages queue, and the message
will be handled once the WebProcess is ready.

  • Target.pri:

Adds missing files to compile spellcheking feature for WebKit2-Qt
to use WebKit C API from WKTextChecker.h.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::updateTextCheckerState):
Uses canSendMessage() method instead of isValid() to check whether the message to
the WebProcess can be sent.

  • UIProcess/efl/TextCheckerEfl.cpp:

(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
Calls TextChecker::setContinuousSpellCheckingEnabled which additionaly invokes the client's method.
WK2-EFL settings for text checker (ewk_settings.cpp) set the default language (if it wasn't set earlier) to
perform the spelling. It allows to pass the tests from editing/spelling directory.

Tools: WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Reviewed by Gyuyoung Kim.

WebKitTestRunner enables spelling feature to pass the layout tests from editing/spelling.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
Enables spelling by WebKit2 C API.

LayoutTests: [EFL] WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Reviewed by Gyuyoung Kim.

Unskip the spelling tests from efl-wk2/TestExpectations to run them for WebKit2-EFL.
Add new missing baselines for two spelling tests for EFL platform.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Added.
  • platform/efl/editing/spelling/spelling-expected.txt: Added.
4:28 AM Changeset in webkit [133735] by dominik.rottsches@intel.com
  • 2 edits in trunk/Tools

[EFL] Switch the efl-linux-slave-2 to Wk2 Release
https://bugs.webkit.org/show_bug.cgi?id=101345

Reviewed by Gyuyoung Kim.

Switching efl-linux-slave-2 to Wk2 Release.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:14 AM Changeset in webkit [133734] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Cleanup V8DOMWrapper::getCachedWrapper
https://bugs.webkit.org/show_bug.cgi?id=100853

Patch by Dan Carney <dcarney@google.com> on 2012-11-07
Reviewed by Adam Barth.

Slight cleanup. Removed redundant branch.

No new tests. No change in functionality.

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

2:22 AM Changeset in webkit [133733] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed trivial build fix adapting to QtMultimedia API changes

The QtMultimedia namespace is now called QMultimedia and
QtMultimedia::MetaData is now QMediaMetaData.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::supportsType):
(WebCore::MediaPlayerPrivateQt::totalBytes):

1:45 AM Changeset in webkit [133732] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Marking new test media/progress-events-generated-correctly.html as failing on EFL.

  • platform/efl/TestExpectations:
1:43 AM Changeset in webkit [133731] by commit-queue@webkit.org
  • 22 edits in trunk

Add replaceWithLiteral() method to WTF::String
https://bugs.webkit.org/show_bug.cgi?id=101257

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-07
Reviewed by Benjamin Poulain.

Source/WebCore:

Substitute String::replace() calls by String::replaceWithLiteral() where
adequate, for efficiency.

No new tests, no behavior change.

  • dom/Node.cpp:

(WebCore::Node::showNode):

  • editing/EditingStyle.cpp:

(WebCore::StyleChange::extractTextStyles):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::setSearch):

  • loader/FormSubmission.cpp:

(WebCore::appendMailtoPostFormDataToURL):

  • platform/network/soup/ProxyResolverSoup.cpp:

(soupProxyResolverWkSetProperty):

  • plugins/PluginView.cpp:

(WebCore::makeURL):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::showBox):

  • xml/XSLTProcessor.cpp:

(WebCore::transformTextStringToXHTMLDocumentString):

Source/WebKit/blackberry:

Substitute String::replace() calls by String::replaceWithLiteral() where
adequate, for efficiency.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::generateHTML):

Source/WebKit2:

Substitute String::replace() calls by String::replaceWithLiteral() where
adequate, for efficiency.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::makeURLString):

Source/WTF:

Add replaceWithLiteral() method to WTF::String that takes
replacement string as a literal to avoid uselessly constructing
a String object.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::replace):
(WTF):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::replace):
(StringImpl):

  • wtf/text/WTFString.h:

(String):
(WTF::String::replaceWithLiteral):

Tools:

Add API tests for String::replaceWithLiteral() and corresponding
StringImpl methods.

  • TestWebKitAPI/CMakeLists.txt: Add WTFString API tests to CMake.
  • TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):
(TestWebKitAPI):

  • TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

1:32 AM Changeset in webkit [133730] by Simon Hausmann
  • 4 edits in trunk

[Qt] Fix build of modules depending on QtWebKit when using prefix
https://bugs.webkit.org/show_bug.cgi?id=101437

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-11-07
Reviewed by Simon Hausmann.

.:

.qmake.conf loads qt_build_config.prf, which nowadays is responsible for
adding the path to .qmake.super (before it was done by default_pre.prf,
so having setting the path in our default_pre wrapper was sufficient).

  • .qmake.conf:

Tools:

Remove setting of MODULE_QMAKE_OUTDIR from here, it's been moved to .qmake.conf.

  • qmake/mkspecs/features/default_pre.prf:
12:54 AM Changeset in webkit [133729] by kenneth@webkit.org
  • 7 edits in trunk/Source

Remove support for "desktop-width" in the viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=101217

Reviewed by Gyuyoung Kim.

Source/WebCore:

This has been removed from the CSS Device Adaptation spec, and
should be safe to remove as it is not documented anywhere (neither
in blog posts).

The viewport meta should only support the legacy features.

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):
(WebCore::findSizeValue):
(WebCore::findScaleValue):
(WebCore::findUserScalableValue):

  • dom/ViewportArguments.h:

Source/WebKit/blackberry:

Sync WebViewportArguments enum with the one in
WebCore::ViewportArguments

  • Api/WebViewportArguments.h:

Source/WebKit/chromium:

Remove some code trying to use the set desktop width (say 980) for
sites not using a viewport meta element.

Removing this code should have no effect as it ends up being set
to desktop width in that case anyway, by the ViewportArguments
algorithm.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

12:40 AM Changeset in webkit [133728] by dominik.rottsches@intel.com
  • 4 edits in trunk

[EFL] Fix execution of exif-orientation-image-document.html on EFL Wk2 bot
https://bugs.webkit.org/show_bug.cgi?id=101343

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add Cairo to the list of backends that support shouldRespectImageOrientation.

No new tests, fixes exif-orientation-image-document.html.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

LayoutTests:

Unskipping exif-orientation-image-document.html now that respecting
orientation is default enabled for image documents.

  • platform/efl-wk2/TestExpectations:
12:32 AM Changeset in webkit [133727] by yurys@chromium.org
  • 4 edits
    2 adds in trunk

Console not displaying all properties of an Object once native Constructor overwritten
https://bugs.webkit.org/show_bug.cgi?id=101320

Reviewed by Pavel Feldman.

Source/WebCore:

Use Object instance from {}.constructor when formatting inspector messages in the
injected script. Otherwise inspected page may overwrite Object value and break inspector.

Test: inspector/console/console-Object-overwritten.html

  • inspector/InjectedScriptSource.js:

LayoutTests:

Check that Web Inspector's console works fine if Object is overwritten in the inspected
page.

  • inspector/console/console-Object-overwritten-expected.txt: Added.
  • inspector/console/console-Object-overwritten.html: Added.

Nov 6, 2012:

11:13 PM Changeset in webkit [133726] by msaboff@apple.com
  • 3 edits in trunk/Source/WTF

StringBuilder::append(UChar) with an 8 bit quantity shouldn't change the contents to 16 bits
https://bugs.webkit.org/show_bug.cgi?id=101421

Reviewed by Anders Carlsson.

If the string builder contains only 8 bit data, check if the character being appended contains
8 bit data. If so, append it to the 8 bit buffer instead of converting the buffer to 16 bits.

  • wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::append):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::append):

10:46 PM Changeset in webkit [133725] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] media/media-continues-playing-after-replace-source.html fails
https://bugs.webkit.org/show_bug.cgi?id=101429

Unreviewed, EFL gardening.

media-continues-playing-after-replace-source.html test case crashes in WK2 only.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-06

  • platform/efl-wk2/TestExpectations:
10:46 PM Changeset in webkit [133724] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Move DrawingAreaImpl methods graphicsLayerFactory, setRootCompositingLayer & scheduleCompositingLayerSync under ACCELERATED_COMPOSITING
https://bugs.webkit.org/show_bug.cgi?id=101427

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-11-06
Reviewed by Anders Carlsson.

Moving these methods under the ACCELERATED_COMPOSITING flag.
This fixes broken wincairo due to use of override specifier.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

10:31 PM Changeset in webkit [133723] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] API test crash with accelerated compositing on.
https://bugs.webkit.org/show_bug.cgi?id=101384

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-06
Reviewed by Gyuyoung Kim.

If accelerated compositing is enabled API tests should create GL evas engine
instead of default one.
Also, in API tests first window resize and display often comes earlier
than enterAcceleratedCompositingMode call, so let's create GL surface in
_ewk_view_smart_calculate on first window resize.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_calculate):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::SetUp):

10:29 PM Changeset in webkit [133722] by keishi@webkit.org
  • 5 edits in trunk

Implement month picking to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101333

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html: Added test for month picker.

Source/WebCore:

This adds month picker mode to CalendarPicker.

No new tests. Tests will be added later when this feature is enabled in DRT.

  • Resources/pagepopups/calendarPicker.css:

(.month-mode .day): Remove rounded corners when in month mode.

  • Resources/pagepopups/calendarPicker.js:

(Month.createFromToday): Creates month containing today.
(CalendarPicker): Set this.selectionConstructor to Day or Month depending on the mode. Create DayTables or MonthPickerDaysTable depending on the mode.
(CalendarPicker.prototype.handleToday):
(CalendarPicker.prototype._layoutButtons):
(DaysTable.prototype._renderMonth): Set element.dataset.monthValue for all date nodes.
(DaysTable.prototype._markRangeAsSelected): Marks all day nodes in range as selected.
(DaysTable.prototype.selectRange): Selects a day.
(DaysTable.prototype.selectRangeAndShowEntireRange): Same as selectRange.
(DaysTable.prototype._selectRangeContainingNode):
(DaysTable.prototype._rangeForNode): Returns Day for node.
(DaysTable.prototype.startDate): Start datetime of visible date range. This value is inclusive.
(DaysTable.prototype.endDate): End datetime of visible date range. This value is exclusive.
(DaysTable.prototype._handleKey):
(MonthPickerDaysTable):
(MonthPickerDaysTable.prototype._markRangeAsSelected): Marks all day nodes in range as selected.
(MonthPickerDaysTable.prototype.selectRange): Selects month. If month is not visible, navigates to that month.
(MonthPickerDaysTable.prototype.selectRangeAndShowEntireRange): Selects month. Navigates to the month.
(MonthPickerDaysTable.prototype._rangeForNode): Returns Month for node.
(MonthPickerDaysTable.prototype._handleKey): Arrow keys simply move the selection forwards or backwards.

9:28 PM Changeset in webkit [133721] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

Unreviewed attempt to fix the chromium-mac build.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

9:18 PM FeatureFlags edited by dbeam@chromium.org
(diff)
9:06 PM AddingFeatures edited by noel.gordon@gmail.com
(diff)
9:05 PM Changeset in webkit [133720] by commit-queue@webkit.org
  • 13 edits
    1 add in trunk

Enable REQUEST_AUTOCOMPLETE for chromium port
https://bugs.webkit.org/show_bug.cgi?id=101376

Patch by Dan Beam <dbeam@chromium.org> on 2012-11-06
Reviewed by Adam Barth.

Source/WebCore:

Added a runtime enabled feature to control whether HTMLFormElement#requestAutocomplete is visible from JavaScript.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

Added a binding from RuntimeEnabledFeatures that triggers [V8EnabledAtRuntime=requestAutocomplete].

(WebCore::RuntimeEnabledFeatures::requestAutocompleteEnabled):

Added a getter to WebCore to ask whether the runtime flag requestAutocomplete is on.

(WebCore::RuntimeEnabledFeatures::setRequestAutocompleteEnabled):

Added a setter to WebCore to affect the runtime flag requestAutocomplete.

  • html/HTMLFormElement.idl:

Wrapped commonly grouped features in an #if defined(ENABLED_REQUEST_AUTOCOMPLETE) block and added [V8EnableAtRuntime]
so these features can be changed with a command line switch in the chromium port.

Source/WebKit/chromium:

This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use
HTMLFormElement#requestAutocomplete as the chrome-side work progresses further.

  • features.gypi:

Turned on the *compile* time flag for REQUEST_AUTOCOMPLETE in chromium's webkit port but also added a *run* time flag
that functionally enables the behavior. This means the chromium port will compile in support but will require a run
time flag to enable.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

Added a method to the public chromium run time features interface to allow chrome to enable/disable this feature.

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableRequestAutocomplete):
(WebKit):

A setter than can be called from chrome code to change the enable/disable requestAutocomplete and associated events at
runtime.

(WebKit::WebRuntimeFeatures::isRequestAutocompleteEnabled):

A getter that returns whether the requestAutocomplete run time feature is enabled.

Tools:

This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use
HTMLFormElement#requestAutocomplete as the chrome-side work progresses further.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

Enables the requestAutocomplete runtime feature flag during tests.

LayoutTests:

This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use
HTMLFormElement#requestAutocomplete as the chrome-side work progresses further.

  • fast/forms/form-request-autocomplete-expected.txt:

Updated to match form-request-autocomplete.html changes.

  • fast/forms/form-request-autocomplete.html:

Remove bug number as per Adam Barth <abarth@webkit.org>'s advice.

  • platform/chromium/fast/forms/form-request-autocomplete-expected.txt: Added.

Adding expected successful layout test for form-request-autocomplete.html tests to chromium specific directory
(as chromium is currently the only place the feature is enabled).

8:59 PM Changeset in webkit [133719] by abarth@webkit.org
  • 20 edits in trunk/Source/WebCore

[V8] Unify setJSWrapperForDOMObject and setJSWrapperForDOMNode
https://bugs.webkit.org/show_bug.cgi?id=101422

Reviewed by Kentaro Hara.

This patch is another incremental step towards the patch in Bug 10110.
In this step, we unify setJSWrapperForDOMObject and
setJSWrapperForDOMNode.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::V8Float64Array::wrap):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::wrap):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::wrap):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::wrap):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::wrap):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::V8TestException::wrap):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::wrap):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::wrap):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::V8TestObj::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::wrap):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::get):
(DOMDataStore):

  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperPrivate):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

8:56 PM Changeset in webkit [133718] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2][EFL] Add shortcut for setting a pagination mode on Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=100301

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-06
Reviewed by Gyuyoung Kim.

Setting pagination modes is for a paginated view - left to right / right to left / top to bottom / bottom to top.
Assign a shortcut "F7" to set pagination modes for tests.

  • MiniBrowser/efl/main.c:

(on_key_down):

8:55 PM Changeset in webkit [133717] by kenrb@chromium.org
  • 4 edits
    2 adds in trunk

Crash due to column span under button element
https://bugs.webkit.org/show_bug.cgi?id=101402

Reviewed by Abhishek Arya.

Source/WebCore:

When there is a column-spanning child of a RenderButton
splitBlocks() must split the RenderButton as well as its
only permitted direct child, the anonymous block referenced
by m_inner. A crash was occurring because splitBlocks()
calls addChildIgnoringAnonymousColumnBlocks() to add the
cloned m_inner to the cloned RenderButton, which meant the
m_inner for the cloned RenderButton was not being set even
though a child was being added. This violates state
assumptions in the RenderButton code.

This patch prevents any descendants of RenderButton from
spanning columns. Also, it adds a precautionary check in
RenderButton::removeChild() to mitigate problems if similar
state problems are found in future.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containingColumnsBlock):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::removeChild):

LayoutTests:

Test creates crashing condition for bug 101402.

  • fast/block/colspan-under-button-crash.html: Added.
  • fast/block/colspan-under-button-crash-expected.txt: Added.
8:50 PM Changeset in webkit [133716] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] fast/dom/shadow/shadowdom-for-object-only-shadow.html fails
https://bugs.webkit.org/show_bug.cgi?id=101417

Unreviewed, EFL gardening.

shadowdom-for-object-only-shadow.html test is flaky in WK2 only.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-11-06

  • platform/efl-wk2/TestExpectations:
8:40 PM Changeset in webkit [133715] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

[Shadow] Pseudo custom-elements should start with 'x-'.
https://bugs.webkit.org/show_bug.cgi?id=100919

Reviewed by Dimitri Glazkov.

Source/WebCore:

Pseuco custom-elements should start with 'x-'. 'Pseudo' starting with '-webkit-' should work
only in UserAgent ShadowDOM. If it's used in Author ShadowDOM, it should not work.

Test: fast/dom/shadow/pseudo-attribute-rendering.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector): Added ShadowRoot type check.

LayoutTests:

  • fast/dom/shadow/pseudo-attribute-rendering-expected.html: Added.
  • fast/dom/shadow/pseudo-attribute-rendering.html: Added.
8:39 PM Changeset in webkit [133714] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][EWebLauncher] Use Ctrl +/- to zoom in EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=100207

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-06
Reviewed by Gyuyoung Kim.

Use "Ctrl -" instead of "F7" to zoom out, and use "Ctrl +" instead of "F8" to zoom in,
and use "Ctrl 0" to set to default zoom level.
They are more common shortcuts on usual browsers.

  • EWebLauncher/main.c:

(on_key_down):

8:14 PM Changeset in webkit [133713] by cevans@google.com
  • 5 edits in trunk/Source/WebCore

Re-order variables in BidiRun and LayoutState
https://bugs.webkit.org/show_bug.cgi?id=100173

Reviewed by Eric Seidel.

The variable re-ordering and use of bitfields for bools has two benefits:
1) Size reduction. sizeof(BidiRun) goes down from 48 to 40 bytes on 64-bit. This is achieved by removing a bool member variable from BidiRun and packing it together with other bools in the BidiCharacterRun base class.
2) Security improvement. We have a lot of use-after-free in the RenderObject hierarchy, and the RenderArena class protects us from a lot of trouble by ensuring that objects of arbitrary type cannot be overlayed on top of freed RenderObjects. This change additionally makes sure that non-virtual RenderArena allocated objects do not have member variables which fully overlap the freed vtable pointer. This leaves re-used vtable pointers always pointing to either a valid vtable or an invalid address due to the freelist high-bit poisoning.

This change is exclusively about size savings; it is performance neutral as you would expect, including on Parser/html5-full-render.html

  • platform/text/BidiResolver.h:

(WebCore::BidiCharacterRun::BidiCharacterRun): impact from re-ordering members.
(BidiCharacterRun): provide an efficiently packed bit of storage for BidiRun subclass to use, and re-order members to place bools adjacent.

  • rendering/BidiRun.h:

(WebCore::BidiRun::BidiRun): use base class' efficiently packed bit storage for m_hasHyphen.
(BidiRun): m_hasHyphen is now stored in the base class.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState): impact from re-ordering members.
(LayoutState): re-order members to place bools adjacently.

7:33 PM Changeset in webkit [133712] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium-win] Refactor date/time format conversion code in LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=101329

Reviewed by Kentaro Hara.

convertWindowsDateFormatToLDML and convertWindowsTimeFormatToLDML did
similar jobs with different code. We can merge them into one function.

As for the date format conversion, we have tokenized a format string and
stored token objects into a vector. We skip token object generation and
generate a LDML-compliant pattern string during parsing.

No new tests. This should make no behavior changes and
WebKit/chromium/tests/LocaleWinTest.cpp has test cases.

  • platform/text/win/LocaleWin.cpp:

(WebCore): Remove DateFormatToken, isFooSymbol, ensureShortDateTokens,
convertWindowsDateFormatToLDML, mapCharacterToDateTimeFieldType, and
convertWindowsTimeFormatToLDML.
(WebCore::commitLiteralToken): Store the result to the specified StringBuilder.
(WebCore::convertWindowsDateTimeFormat):
Renamed from parseDateFormat, and supports time format symbols.
(WebCore::LocaleWin::dateFormat): Use convertWindowsDateTimeFormat.
(WebCore::LocaleWin::monthFormat): Ditto.
(WebCore::LocaleWin::timeFormat): Ditto.
(WebCore::LocaleWin::shortTimeFormat): Ditto.

  • platform/text/win/LocaleWin.h:

(LocaleWin): Remove ensureShortDateTokens and m_shortDateTokens.

7:31 PM Changeset in webkit [133711] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Make Document::renderer faster by using the cached ptr for RenderView
https://bugs.webkit.org/show_bug.cgi?id=101409

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-06
Reviewed by Eric Seidel.

In Bug 101277 I made Document::renderView() just return m_renderView instead
of casting the result of renderer(). While this made renderView() cheaper it
makes more sense to just make renderer() faster for Document pointers and
go back to the out of line method in RenderView.h because lots of places in
the code do document()->renderer().

No new tests, this is just a refactor.

  • dom/Document.h:

(WebCore::Document::renderer):

  • rendering/RenderView.h:

(WebCore::Document::renderView):

6:47 PM Changeset in webkit [133710] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebCore

Merged r129270. <rdar://problem/12536542>

6:36 PM Changeset in webkit [133709] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebCore

Merged r128964. <rdar://problem/12516360>

6:31 PM Changeset in webkit [133708] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] neuterBinding should remember the type of its argument
https://bugs.webkit.org/show_bug.cgi?id=101413

Reviewed by Kentaro Hara.

This is a small part of the patch in
https://bugs.webkit.org/show_bug.cgi?id=101110 that we can land
separately to try to tease out what is causing the memory regression.

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore):
(WebCore::neuterBinding):

6:30 PM Changeset in webkit [133707] by andersca@apple.com
  • 2 edits in trunk/WebKitLibraries

Build fix.

  • WebKitSystemInterface.h:
6:26 PM Changeset in webkit [133706] by Lucas Forschler
  • 3 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r128935. <rdar://problem/12486170>

6:06 PM Changeset in webkit [133705] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r128792. <rdar://problem/12516344>

6:04 PM Changeset in webkit [133704] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r128774. <rdar://problem/12514580>

6:02 PM Changeset in webkit [133703] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-536.28-branch

Merged r128654. <rdar://problem/12536534>

5:58 PM Changeset in webkit [133702] by andersca@apple.com
  • 8 edits in trunk

Update Java related WKSI function names
https://bugs.webkit.org/show_bug.cgi?id=101414

Reviewed by Sam Weinig.

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::unavailablePluginButtonClicked):

  • WebCoreSupport/WebFrameLoaderClient.mm:

(isPlugInInactive):

Source/WebKit2:

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::shouldUsePlugin):
(WebKit::PluginInfoStore::policyForPlugin):
(WebKit::PluginInfoStore::reactivateInactivePlugin):

WebKitLibraries:

Roll WebKitSystemInterface DEPS.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
5:56 PM Changeset in webkit [133701] by aboxhall@chromium.org
  • 4 edits
    1 move
    12 adds in trunk/LayoutTests

Unreviewed gardening. Rebaseline the tests added in http://trac.webkit.org/changeset/133686 for different platforms.

  • platform/chromium-linux/fast/backgrounds/transformed-body-background-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/transformed-body-html-background-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/transformed-html-body-background-expected.png: Added.
  • platform/chromium-mac-lion/compositing/repaint/composited-document-element-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/repaint/composited-document-element-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/repaint/composited-document-element-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/repaint/composited-document-element-expected.png: Added.
  • platform/chromium-mac/compositing/repaint/composited-document-element-expected.png:
  • platform/chromium-mac/fast/backgrounds/transformed-body-background-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/transformed-body-html-background-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/transformed-html-body-background-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/composited-document-element-expected.png: Added.
  • platform/efl-wk1/compositing/repaint/composited-document-element-expected.png: Renamed from LayoutTests/platform/efl/compositing/repaint/composited-document-element-expected.png.
5:35 PM Changeset in webkit [133700] by Lucas Forschler
  • 3 edits
    4 copies in branches/safari-536.28-branch

Merged r127082. <rdar://problem/12536425>

5:17 PM Changeset in webkit [133699] by commit-queue@webkit.org
  • 27 edits
    5 copies
    1 add in trunk/Source/WebKit2

Add application occlusion criterion to enable/disable process suppression on Mac
https://bugs.webkit.org/show_bug.cgi?id=100997

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-11-06
Reviewed by Alexey Proskuryakov.

Provide support for enabling and disabling process suppression when application is completely occluded on Mac.

  • NetworkProcess/NetworkProcess.messages.in: Added message to update application occlusion status.
  • NetworkProcess/mac/NetworkProcessMainMac.mm:

(WebKit::NetworkProcessMain): Removed call to take process suppression assertion since ChildProcess
takes one on constrution.

  • PluginProcess/PluginProcess.messages.in: Added message to update application occlusion status.
  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain): Removed call to take process suppression assertion since ChildProcess
takes one on construction.

  • Shared/ChildProcess.cpp:

(WebKit::ChildProcess::ChildProcess): Take process suppression assertion on construction.

  • Shared/ChildProcess.h:

(WebKit::ChildProcess::applicationIsOccluded):

  • Shared/mac/ChildProcessMac.mm: Added.

(WebKit::ChildProcess::setApplicationIsOccluded): Release process suppression assertion if application
becomes occluded or take a new assertion if application becomes visible.
(WebKit::ChildProcess::disableProcessSuppression):
(WebKit::ChildProcess::enableProcessSuppression):
Helper methods to take and release process suppression assertion.

  • SharedWorkerProcess/SharedWorkerProcess.messages.in: Added message to update application occlusion status.
  • SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm:

(WebKit::SharedWorkerProcessMain): Removed call to take process suppression assertion since ChildProcess
takes one on construction.

  • UIProcess/Network/NetworkProcessManager.h:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didFinishLaunching): Update application occlusion status post launch.

  • UIProcess/Network/NetworkProcessProxy.h:

(WebKit::NetworkProcessProxy::isValid):

  • UIProcess/Network/mac/NetworkProcessManagerMac.mm: Added.

(WebKit::NetworkProcessManager::setApplicationIsOccluded):

  • UIProcess/Network/mac/NetworkProcessProxyMac.mm:

(WebKit::NetworkProcessProxy::setApplicationIsOccluded):

  • UIProcess/Plugins/PluginProcessManager.h:
  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching): Update application occlusion status post launch.

  • UIProcess/Plugins/PluginProcessProxy.h:

(WebKit::PluginProcessProxy::isValid):

  • UIProcess/Plugins/mac/PluginProcessManagerMac.mm: Added.

(WebKit::PluginProcessManager::setApplicationIsOccluded):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::setApplicationIsOccluded):

  • UIProcess/SharedWorkers/SharedWorkerProcessManager.h:
  • UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:

(WebKit::SharedWorkerProcessProxy::didFinishLaunching): Update application occlusion status post launch.

  • UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:

(WebKit::SharedWorkerProcessProxy::isValid):

  • UIProcess/SharedWorkers/mac/SharedWorkerProcessManagerMac.mm: Added.

(WebKit::SharedWorkerProcessManager::setApplicationIsOccluded):

  • UIProcess/SharedWorkers/mac/SharedWorkerProcessProxyMac.mm: Added.

(WebKit::SharedWorkerProcessProxy::setApplicationIsOccluded):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::create): Added call to initialize process suppression support.

  • UIProcess/WebContext.h:

(WebKit::WebContext::applicationIsOccluded):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didFinishLaunching): Update application occlusion status post launch.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::applicationBecameVisible):
(WebKit::WebContext::applicationBecameOccluded):
Notification handlers for informing non UI WebKit2 processes of changes to application occlusion state.
(WebKit::WebContext::registerOcclusionNotificationHandlers):
(WebKit::WebContext::initializeProcessSuppressionSupport):
Helper method to register occlusion notification handlers if process suppression support is enabled.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.messages.in: Added message to update application occlusion status.
  • WebProcess/mac/WebProcessInitialization.mm:

(WebKit::InitializeWebProcess): Removed call to take process supression assertion since ChildProcess
takes one on construction.

5:14 PM Changeset in webkit [133698] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

fast/forms/select-set-length-with-mutation-remove is slow on chromium debug builds
https://bugs.webkit.org/show_bug.cgi?id=60092

[Chromium] Unreviewed gardening - so slow it's timing out at 60s rather often.

  • platform/chromium/TestExpectations:
5:02 PM Changeset in webkit [133697] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[CSS Exclusions] Changeset r133384 defeated the rectilinear polygon tests
https://bugs.webkit.org/show_bug.cgi?id=101405

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-06
Reviewed by Dirk Schulze.

When the exclusions/shape-inside subpixel layout JS code was refactored,
(see https://bugs.webkit.org/show_bug.cgi?id=100704) these two tests were not
properly updated. They now include subpixel-utils.js, which simple-polygon.js depends on.

  • fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-001-expected.html:
  • fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-001.html:
  • fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-002-expected.html:
  • fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-002.html:
4:48 PM Changeset in webkit [133696] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Don't write pixels for crash-hw-sw-switch test; if it doesn't crash, it
passes. Unreviewed.

  • css3/filters/crash-hw-sw-switch.html:
4:46 PM Changeset in webkit [133695] by noel.gordon@gmail.com
  • 4 edits
    3 deletes in trunk/LayoutTests

(r125185) http/tests/images/jpg-img-partial-load.html timeout on Lion
https://bugs.webkit.org/show_bug.cgi?id=93636

Reviewed by Simon Fraser.

Remove this test: fast/images/jpeg-partial-load.html is now used to test
partial jpeg image loads.

  • http/tests/images/jpg-img-partial-load-expected.png: Removed.
  • http/tests/images/jpg-img-partial-load-expected.txt: Removed.
  • http/tests/images/jpg-img-partial-load.html: Removed.
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
4:41 PM Changeset in webkit [133694] by ap@apple.com
  • 17 edits in trunk

Clean up which storage cookie jar functions use
https://bugs.webkit.org/show_bug.cgi?id=101395

Reviewed by Brady Eidson.

Source/WebCore:

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Updated for two new WKSI functions.

  • platform/CookieJar.h: Added explanatory comments.
  • platform/mac/CookieJar.mm:

(WebCore::cookies): Removed fallback on NSHTTPCookieStorage, the WKSI function
already implements it.
(WebCore::cookieRequestHeaderFieldValue): Ditto.
(WebCore::setCookies): Ditto.
(WebCore::cookiesEnabled): Ditto.
(WebCore::getRawCookies): Ditto.
(WebCore::deleteCookie): Ditto.
(WebCore::getHostnamesWithCookies): This function used to look at NSHTTPCookieStorage
exclusively. While it makes sense to bypass private storage session, default storage
session (currently only used for testing on Mac) is never OK to bypass. Changed to
use a WKSI function that supports both.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.

  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
Updated to match Foundation, so now these functions bypass private session.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::currentCFHTTPCookieStorage): Updated a comment.
(WebCore::defaultCFHTTPCookieStorage): Added a function that returns cookie storage
for non-private session (or null if that would be an NSHTTPCookieStorage).
(WebCore::startObservingCookieChanges): We do not want to observe private cookies
here, and we certainly don't want a mismatch between start/stop due to private
browsing mode changes.
(WebCore::stopObservingCookieChanges): Ditto.

  • platform/network/cf/CookieStorageCFNet.h: Added defaultCFHTTPCookieStorage().

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Updated for

two new functions.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface):

Updated for two new functions.

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:

Added WKHTTPCookies() and WKDeleteAllHTTPCookies(). Updated ifdefs for currently
supported OS versions.

4:37 PM Changeset in webkit [133693] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.28-branch

Merged r126657. <rdar://problem/12536471>

4:32 PM Changeset in webkit [133692] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk/Source/WebKit2

[EFL][WK2] Add ewk_database_manager APIs
https://bugs.webkit.org/show_bug.cgi?id=101193

Patch by Jihye Kang <jye.kang@samsung.com> on 2012-11-06
Reviewed by Gyuyoung Kim.

Add ewk_database_manager to manage web database and
ewk_database_manaager_origins_get to get origins list of web storage.
Add unit tests for ewk_database_manager APIs.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::Ewk_Context):
(Ewk_Context::databaseManager):
(ewk_context_database_manager_get):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_private.h:

(Ewk_Context):

  • UIProcess/API/efl/ewk_database_manager.cpp: Added.

(Ewk_Database_Manager::Ewk_Database_Manager):
(Ewk_Database_Manager::getDatabaseOrigins):
(Ewk_Database_Manager::createOriginList):
(Ewk_Database_Origins_Async_Get_Context):
(Ewk_Database_Origins_Async_Get_Context::Ewk_Database_Origins_Async_Get_Context):
(getDatabaseOriginsCallback):
(ewk_database_manager_origins_get):

  • UIProcess/API/efl/ewk_database_manager.h: Added.
  • UIProcess/API/efl/ewk_database_manager_private.h: Added.

(Ewk_Database_Manager):
(Ewk_Database_Manager::create):

  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_database_manager.cpp: Added.

(OriginData):
(OriginData::OriginData):
(getDatabaseOriginsCallback):
(timerCallback):
(TEST_F):

4:29 PM Changeset in webkit [133691] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. A couple of expectation updates c/o Dave Barton
and marking calendar-picker-key-operations.html flaky per webkit.org/b/101408

  • platform/chromium/TestExpectations:
4:16 PM Changeset in webkit [133690] by senorblanco@chromium.org
  • 1 edit
    6 deletes in trunk/LayoutTests

Removed useless image baselines for filter-empty-element-crash.
Unreviewed.

  • platform/chromium-linux/css3/filters/filter-empty-element-crash-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/filter-empty-element-crash-expected.png: Removed.
  • platform/chromium-mac/css3/filters/filter-empty-element-crash-expected.png: Removed.
  • platform/chromium-win/css3/filters/filter-empty-element-crash-expected.png: Removed.
  • platform/mac-snowleopard/css3/filters/filter-empty-element-crash-expected.png: Removed.
  • platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Removed.
4:14 PM Changeset in webkit [133689] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix. r133601 broke the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=101404

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-06
Reviewed by Noam Rosenthal.

Only static const integral data members can be initialized within a class in the
Windows, so we initialize static const double date members out of the class.

  • platform/graphics/texmap/TextureMapper.cpp:

(BitmapTexturePool):
(WebCore):

4:13 PM Changeset in webkit [133688] by oliver@apple.com
  • 45 edits
    5 adds in trunk/Source/JavaScriptCore

Reduce parser overhead in JSC
https://bugs.webkit.org/show_bug.cgi?id=101127

Reviewed by Filip Pizlo.

An exciting journey into the world of architecture in which our hero
adds yet another layer to JSC codegeneration.

This patch adds a marginally more compact form of bytecode that is
free from any data specific to a given execution context, and that
does store any data structures necessary for execution. To actually
execute this UnlinkedBytecode we still need to instantiate a real
CodeBlock, but this is a much faster linear time operation than any
of the earlier parsing or code generation passes.

As the unlinked code is context free we can then simply use a cache
from source to unlinked code mapping to completely avoid all of the
old parser overhead. The cache is currently very simple and memory
heavy, using the complete source text as a key (rather than SourceCode
or equivalent), and a random eviction policy.

This seems to produce a substantial win when loading identical content
in different contexts.

  • API/tests/testapi.c:

(main):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp:
  • bytecode/CodeBlock.h:

Moved a number of fields, and a bunch of logic to UnlinkedCodeBlock.h/cpp

  • bytecode/Opcode.h:

Added a global const init no op instruction needed to get correct
behaviour without any associated semantics.

  • bytecode/UnlinkedCodeBlock.cpp: Added.
  • bytecode/UnlinkedCodeBlock.h: Added.

A fairly shallow, GC allocated version of the old CodeBlock
classes with a 32bit instruction size, and just metadata
size tracking.

  • bytecompiler/BytecodeGenerator.cpp:
  • bytecompiler/BytecodeGenerator.h:

Replace direct access to m_symbolTable with access through
symbolTable(). ProgramCode no longer has a symbol table at
all so some previously unconditional (and pointless) uses
of symbolTable get null checks.
A few other changes to deal with type changes due to us generating
unlinked code (eg. pointer free, so profile indices rather than
pointers).

  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGCapabilities.h:

Support global_init_nop

  • interpreter/Interpreter.cpp:

Now get the ProgramExecutable to initialise new global properties
before starting execution.

  • jit/JIT.cpp:
  • jit/JITDriver.h:
  • jit/JITStubs.cpp:
  • llint/LLIntData.cpp:
  • llint/LLIntSlowPaths.cpp:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:

Adding init_global_const_nop everywhere else

  • parser/Parser.h:
  • parser/ParserModes.h: Added.
  • parser/ParserTokens.h:

Parser no longer needs a global object or callframe to function

  • runtime/CodeCache.cpp: Added.
  • runtime/CodeCache.h: Added.

A simple, random eviction, Source->UnlinkedCode cache

  • runtime/Executable.cpp:
  • runtime/Executable.h:

Executables now reference their unlinked counterparts, and
request code specifically for the target global object.

  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:

GlobalData now owns a CodeCache and a set of new structures
for the unlinked code types.

  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:

Utility functions used by executables to perform compilation

  • runtime/JSType.h: Add new JSTypes for unlinked code
4:11 PM Changeset in webkit [133687] by senorblanco@chromium.org
  • 6 edits in trunk/LayoutTests

[Chromium] New baselines for some CSS3 filter tests. Unreviewed.

  • platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-expected.txt:
  • platform/chromium-win/css3/filters/effect-reference-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-expected.txt:
4:03 PM Changeset in webkit [133686] by Simon Fraser
  • 4 edits
    12 adds in trunk

-webkit-background-clip:text produces artifacts when applied to the body and the browser is resized
https://bugs.webkit.org/show_bug.cgi?id=89287

Reviewed by Beth Dakin.

Source/WebCore:

If the body had -webkit-background-clip: text, we'd fail to paint
anything behind it, so would see garbage pixels.

Fix by having RenderView::paintBoxDecorations() check for a background-clip of "text"
on the renderer that paints the root background.

Added some new pixel tests for combinations of html and body transform
and backgrounds; earlier versions of the patch broke some of these tests.

Tests: fast/backgrounds/background-clip-text-on-body.html

fast/backgrounds/transformed-body-background.html
fast/backgrounds/transformed-body-html-background.html
fast/backgrounds/transformed-html-body-background.html

  • rendering/RenderView.cpp:

(WebCore::rendererObscuresBackground): Broke up the single condition
into early 'false' returns when possible. We need to also check whether
the renderer that actually paints the background (which might be the body)
will fill it; background-clip: text does not.
(WebCore::RenderView::paintBoxDecorations): Rather than checking firstChild(),
actually check the root renderer, so that we can reliably get to the renderer
that mains the root background.

LayoutTests:

Test with -webkit-background-clip: text on the body, which scrolls.

Some additional tests that exercise different combinations of html and
body transform and background.

  • compositing/repaint/composited-document-element.html:
  • fast/backgrounds/background-clip-text-on-body-expected.png: Added.
  • fast/backgrounds/background-clip-text-on-body-expected.txt: Added.
  • fast/backgrounds/background-clip-text-on-body.html: Added.
  • fast/backgrounds/transformed-body-background-expected.png: Added.
  • fast/backgrounds/transformed-body-background-expected.txt: Added.
  • fast/backgrounds/transformed-body-background.html: Added.
  • fast/backgrounds/transformed-body-html-background-expected.png: Added.
  • fast/backgrounds/transformed-body-html-background-expected.txt: Added.
  • fast/backgrounds/transformed-body-html-background.html: Added.
  • fast/backgrounds/transformed-html-body-background-expected.png: Added.
  • fast/backgrounds/transformed-html-body-background-expected.txt: Added.
  • fast/backgrounds/transformed-html-body-background.html: Added.
3:52 PM Changeset in webkit [133685] by oliver@apple.com
  • 3 edits in trunk/Tools

Don't warn about RefPtr* parameters
https://bugs.webkit.org/show_bug.cgi?id=101403

Reviewed by Gavin Barraclough.

RefPtr<>* is a valid parameter type.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_function_definition_and_pass_ptr):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(PassPtrTest.test_ref_ptr_parameter_value):

3:51 PM Changeset in webkit [133684] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement save and restore for a bunch of InternalSettings state
https://bugs.webkit.org/show_bug.cgi?id=101394

Reviewed by Dirk Pranke.

In http://trac.webkit.org/changeset/133399, I resolved a bunch of
flaky tests by saving and restoring the InternalSettings state
EnableCompositingForFixedPosition. On a hunch, I git grepped for all
internal settings state which is being set by layout tests but not
saved and restored. It turns out there about 15 calls.

This patch takes care of five of them, mostly compositing-related.
The others I was either not sure about, or were already at least
being reset to known values by the testing harness.

Hopefully this will alleviate some further test flakiness.

  • testing/InternalSettings.cpp:
  • testing/InternalSettings.h:
3:50 PM Changeset in webkit [133683] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build warning in RenderLayer.cpp caused by r133628
https://bugs.webkit.org/show_bug.cgi?id=101401

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-06
Reviewed by Simon Fraser.

The static function WebCore::frameViewFromLayer is only used when USE(ACCELERATED_COMPOSITING),
so define it only that case for removing -Wunused-function warning

  • rendering/RenderLayer.cpp:

(WebCore):

3:47 PM Changeset in webkit [133682] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[CSS Exclusions] Store ExclusionPolygonEdge vertices in clockwise order
https://bugs.webkit.org/show_bug.cgi?id=100763

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-06
Reviewed by Darin Adler.

Source/WebCore:

The ExclusionPolygon's internal logic, notably getVertexIntersectionVertices(),
assumes that ExclusionPolygonEdge vertices are stored in clockwise order.
If this is not true, then we construct the polygon's edges in reverse.

To determine if the vertices are in clockwise order, we compare the slope
of the line between the top,left vertex and its previous vertex, with the
the slope of the line of vertices before and after the top,left vertex.
If the slope of the latter is greater, then top,left vertex is located
to its left, and the vertices are clockwise.

Test: fast/exclusions/shape-inside/shape-inside-counterclockwise-polygon.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::determinant): Used to decide if the min vertex is on the left side of the line that passes through its adjacent vertices.
(WebCore::ExclusionPolygon::ExclusionPolygon): If the polygon's vertices are specified in counterclockwise order, construct the edges in reverse.
(WebCore::appendIntervalX): Made this an inline since it was only defined as a function for the sake of clarity.

LayoutTests:

Verify that a shape-inside polygon whose vertices are specified in counterclockwise
order is handled correctly.

  • fast/exclusions/shape-inside/shape-inside-counterclockwise-polygon-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-counterclockwise-polygon.html: Added.
3:44 PM Changeset in webkit [133681] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, remove a couple of passing tests from chromium expectations.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium/TestExpectations:
3:38 PM Changeset in webkit [133680] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening after r133676.

  • platform/efl-wk2/TestExpectations: Unskip a few passing tests.
3:30 PM Changeset in webkit [133679] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash in InRegionScrollerPrivate.
https://bugs.webkit.org/show_bug.cgi?id=101399

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-06
Reviewed by Rob Buis.

Add a pointer to the enclosing document as the pointer to layer
or node along the way may become invalid.
Use document pointer in clearDocumentData.
PR #238469

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
(BlackBerry::WebKit::InRegionScrollableArea::document):
(WebKit):

  • WebKitSupport/InRegionScrollableArea.h:

(WebCore):
(InRegionScrollableArea):

3:25 PM Changeset in webkit [133678] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Simplify the build system
https://bugs.webkit.org/show_bug.cgi?id=101392

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-06
Reviewed by Kenneth Rohde Christiansen.

.:

Remove unused cmake variables. In addition there is no longer a need to define
WTF_USE_TEXTURE_MAPPER_GL in the build system as that is now handled in Platform.h
(see r133623).

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit:

Use WTF_USE_3D_GRAPHICS to guard the inclusion of surfaces and textmap
directories under WebCore/graphics to be consistent with
WebCore/PlatformEfl.cmake.

  • PlatformEfl.cmake:
3:06 PM Changeset in webkit [133677] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

http/tests/inspector-enabled/dynamic-scripts.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=100926

Unreviewed gardening.

  • platform/chromium/TestExpectations:
3:04 PM Changeset in webkit [133676] by rakuco@webkit.org
  • 6 edits in trunk/Tools

[WTR] Reset EventSender before running each test.
https://bugs.webkit.org/show_bug.cgi?id=101353

Reviewed by Simon Fraser.

Contrary to what was done to at least some ports in DumpRenderTree,
EventSender did not currently reset its values in WTR. This caused
flakiness if a test such as editing/selection/fake-doubleclick.html was
run twice in a row, since the click count was not reset across each
run.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController): Do not create m_eventSenderProxy
in the constructor anymore, it is created in
resetStateToConsistentValues now.
(WTR::TestController::resetStateToConsistentValues): Recreate
m_eventSenderProxy every time this method is run.

  • WebKitTestRunner/TestController.h: Make m_eventSenderProxy an OwnPtr

and guard it with a platform #ifdef.

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::~EventSenderProxy): Add an empty
implementation.

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::~EventSenderProxy): Ditto.

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::~EventSenderProxy): Ditto.

2:58 PM Changeset in webkit [133675] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html flaky on linux debug
https://bugs.webkit.org/show_bug.cgi?id=101377

Unreviewed gardening. Add ImageOnlyFailure expectation, for extra fun.

  • platform/chromium/TestExpectations:
2:50 PM Changeset in webkit [133674] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-06
Reviewed by Rob Buis.

RIM PR 238123
Internal Reviewed by Chris Hutten-Czapski
BB10 selection theme use slice image function to draw selection button,
any border-radius setting other than 0 will make the button corner
clipped. Always set button border-radius: 0 for BB10 theme.

  • css/themeBlackBerry.css:

(select[size][multiple]):
(select[size="1"]):

2:42 PM EFLWebKit edited by Laszlo Gombos
add an example to pass arguments to make (diff)
2:21 PM Changeset in webkit [133673] by commit-queue@webkit.org
  • 21 edits in trunk

[EFL][WK2] Refactor Ewk_Auth_Request, Ewk_Url_Scheme_Request and Ewk_Download_Job to be Ewk_Objects
https://bugs.webkit.org/show_bug.cgi?id=101383

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-06
Reviewed by Kenneth Rohde Christiansen.

Ewk_Auth_Request, Ewk_Url_Scheme_Request and Ewk_Download_Job are Ewk_Objects now.

Source/WebKit2:

  • UIProcess/API/efl/EwkViewCallbacks.h:
  • UIProcess/API/efl/EwkViewImpl.h:
  • UIProcess/API/efl/ewk_auth_request.cpp:

(EwkAuthRequest::EwkAuthRequest):
(EwkAuthRequest::~EwkAuthRequest):
(EwkAuthRequest::suggestedUsername):
(EwkAuthRequest::realm):
(EwkAuthRequest::host):
(EwkAuthRequest::continueWithoutCredential):
(EwkAuthRequest::authenticate):
(EwkAuthRequest::isRetrying):
(ewk_auth_request_suggested_username_get):
(ewk_auth_request_cancel):
(ewk_auth_request_authenticate):
(ewk_auth_request_retrying_get):
(ewk_auth_request_realm_get):
(ewk_auth_request_host_get):

  • UIProcess/API/efl/ewk_auth_request.h:
  • UIProcess/API/efl/ewk_auth_request_private.h:

(EwkAuthRequest):
(EwkAuthRequest::create):

  • UIProcess/API/efl/ewk_back_forward_list.h:
  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext):

  • UIProcess/API/efl/ewk_download_job.cpp:

(EwkDownloadJob::EwkDownloadJob):
(EwkDownloadJob::id):
(EwkDownloadJob::viewImpl):
(ewk_download_job_state_get):
(EwkDownloadJob::state):
(ewk_download_job_request_get):
(EwkDownloadJob::request):
(ewk_download_job_response_get):
(EwkDownloadJob::response):
(ewk_download_job_destination_get):
(EwkDownloadJob::destination):
(ewk_download_job_destination_set):
(EwkDownloadJob::setDestination):
(ewk_download_job_suggested_filename_get):
(EwkDownloadJob::suggestedFileName):
(ewk_download_job_cancel):
(EwkDownloadJob::cancel):
(ewk_download_job_estimated_progress_get):
(EwkDownloadJob::estimatedProgress):
(ewk_download_job_elapsed_time_get):
(EwkDownloadJob::elapsedTime):
(EwkDownloadJob::setResponse):
(EwkDownloadJob::setSuggestedFileName):
(EwkDownloadJob::incrementReceivedData):
(EwkDownloadJob::setState):

  • UIProcess/API/efl/ewk_download_job.h:
  • UIProcess/API/efl/ewk_download_job_private.h:

(EwkDownloadJob):
(EwkDownloadJob::create):

  • UIProcess/API/efl/ewk_url_scheme_request.cpp:

(EwkUrlSchemeRequest::EwkUrlSchemeRequest):
(EwkUrlSchemeRequest::id):
(EwkUrlSchemeRequest::url):
(EwkUrlSchemeRequest::scheme):
(EwkUrlSchemeRequest::path):
(EwkUrlSchemeRequest::finish):
(ewk_url_scheme_request_scheme_get):
(ewk_url_scheme_request_url_get):
(ewk_url_scheme_request_path_get):
(ewk_url_scheme_request_finish):

  • UIProcess/API/efl/ewk_url_scheme_request.h:
  • UIProcess/API/efl/ewk_url_scheme_request_private.h:

(EwkUrlSchemeRequest):
(EwkUrlSchemeRequest::create):

  • UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:

(onAuthenticationRequest):
(TEST_F):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::decideDestinationWithSuggestedFilename):
(WebKit::DownloadManagerEfl::didReceiveResponse):
(WebKit::DownloadManagerEfl::didCreateDestination):
(WebKit::DownloadManagerEfl::didReceiveData):
(WebKit::DownloadManagerEfl::didFail):
(WebKit::DownloadManagerEfl::didCancel):
(WebKit::DownloadManagerEfl::didFinish):
(WebKit::DownloadManagerEfl::registerDownload):
(WebKit::DownloadManagerEfl::downloadJob):

  • UIProcess/efl/DownloadManagerEfl.h:

(DownloadManagerEfl):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):

  • UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::RequestManagerClientEfl::didReceiveURIRequest):

Tools:

  • MiniBrowser/efl/main.c:

(auth_popup_close):
(on_authentication_request):

2:16 PM Changeset in webkit [133672] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSStringCreateWithCFString() Should create an 8 bit String if possible
https://bugs.webkit.org/show_bug.cgi?id=101104

Reviewed by Darin Adler.

Try converting the CFString to an 8 bit string using CFStringGetBytes(...,
kCFStringEncodingISOLatin1, ...) and return the 8 bit string if successful.
If not proceed with 16 bit conversion.

  • API/JSStringRefCF.cpp:

(JSStringCreateWithCFString):

2:12 PM Changeset in webkit [133671] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove branch from inside RenderObject::view now that renderer() is more expensive
https://bugs.webkit.org/show_bug.cgi?id=101277

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-06
Reviewed by Eric Seidel.

It was observed in Bug 100057 that calling renderer() repeatedly now that it has a branch
can be a performance regression. Now that we no longer keep a separate pointer for rare data
in Document, we can use that space for a pointer to the RenderView making RenderObject::view()
faster and removing the branch.

This is a 1% improvement on Parser/html5-full-render.html

This also cleans up the code because it turns out we don't need to have RenderObject::view() in
RenderView.h because we can just call Document::renderView() and not do toRenderView. This makes
it easier to find this method as it exists in the right header file now.

No new tests, this is just a refactor.

  • WebCore.exp.in: Remove export of Document::renderView since it's inline now.
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::setRenderer):
(WebCore):

  • dom/Document.h:

(WebCore::Document::renderView):
(Document):

  • rendering/RenderObject.h:

(WebCore::RenderObject::view):

  • rendering/RenderView.h:

(WebCore):

2:06 PM Changeset in webkit [133670] by ap@apple.com
  • 1 edit
    2 deletes in trunk/WebKitLibraries

Delete Leopard and Snow Leopard versions of WKSI. These have not been updated in ages.

Rubber-stampted by Mark Rowe.

  • libWebKitSystemInterfaceLeopard.a: Removed.
  • libWebKitSystemInterfaceSnowLeopard.a: Removed.
2:05 PM Changeset in webkit [133669] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Reduce direct m_symbolTable usage in CodeBlock
https://bugs.webkit.org/show_bug.cgi?id=101391

Reviewed by Sam Weinig.

Simple refactoring.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::dumpStatistics):
(JSC::CodeBlock::nameForRegister):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::isCaptured):

2:01 PM Changeset in webkit [133668] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Lexer::scanRegExp, create 8 bit pattern and flag Identifiers from 16 bit source when possible
https://bugs.webkit.org/show_bug.cgi?id=101013

Reviewed by Darin Adler.

Changed scanRegExp so that it will create 8 bit identifiers from 8 bit sources and from 16 bit sources
whan all the characters are 8 bit. Using two templated helpers, the "is all 8 bit" check is only performed
on 16 bit sources. The first helper is orCharacter() that will accumulate the or value of all characters
only for 16 bit sources. Replaced the helper Lexer::makeIdentifierSameType() with Lexer::makeRightSizedIdentifier().

  • parser/Lexer.cpp:

(JSC::orCharacter<LChar>): Explicit template that serves as a placeholder.
(JSC::orCharacter<UChar>): Explicit template that actually or accumulates characters.
(JSC::Lexer::scanRegExp):

  • parser/Lexer.h:

(Lexer):
(JSC::Lexer::makeRightSizedIdentifier<LChar>): New template that always creates an 8 bit Identifier.
(JSC::Lexer::makeRightSizedIdentifier<UChar>): New template that creates an 8 bit Identifier for 8 bit
data in a 16 bit source.

2:00 PM Changeset in webkit [133667] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Pushing window.external.* events to webplatform
https://bugs.webkit.org/show_bug.cgi?id=101386

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-06
Reviewed by Rob Buis.

Adding calls to trigger window.external events so we can handle them on the
browser side.

PR 170059

  • Api/WebPageClient.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::addSearchProvider):
(WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):

1:38 PM Changeset in webkit [133666] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-536.28-branch

Merged r126205. <rdar://problem/12536482>

1:37 PM Changeset in webkit [133665] by jsbell@chromium.org
  • 33 edits
    3 copies in trunk/Source

Unreviewed, rolling out r133526.
http://trac.webkit.org/changeset/133526
https://bugs.webkit.org/show_bug.cgi?id=101388

May have caused 15% memory regression in Chromium (Requested
by jsbell|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-06

Source/WebCore:

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
(GetDomMapFunction):
(GetDomMapName):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::V8Float64Array::wrap):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::wrap):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::wrap):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::wrap):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::wrap):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::V8TestException::wrap):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::wrap):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::wrap):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::V8TestObj::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::wrap):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
(WebCore::DOMDataStore::current):
(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::domNodeMap):
(WebCore::DOMDataStore::domObjectMap):
(DOMDataStore):

  • bindings/v8/DOMWrapperMap.h:

(WebCore):
(DOMWrapperMap):
(WebCore::DOMWrapperMap::~DOMWrapperMap):
(WebCore::DOMWrapperHashMap::remove):

  • bindings/v8/DOMWrapperWorld.h:
  • bindings/v8/IntrusiveDOMWrapperMap.h: Copied from Source/WebKit/chromium/src/WebScriptController.cpp.

(WebCore):
(IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::weakCallback):

  • bindings/v8/ScriptProfiler.cpp:
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::neuterBinding):

  • bindings/v8/V8DOMMap.cpp: Copied from Source/WebKit/chromium/src/WebScriptController.cpp.

(WebCore):
(WebCore::getDOMNodeMap):
(WebCore::getDOMObjectMap):

  • bindings/v8/V8DOMMap.h: Copied from Source/WebKit/chromium/src/WebScriptController.cpp.

(WebCore):

  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::getCachedWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):

  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/WorkerScriptController.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

Source/WebKit/chromium:

  • src/WebScriptController.cpp:
1:24 PM Changeset in webkit [133664] by ap@apple.com
  • 5 edits in trunk/Source/WebCore

Some cookie code cleanup
https://bugs.webkit.org/show_bug.cgi?id=101375

Reviewed by Dan Bernstein.

  • platform/CookieJar.h: Fixed style. Grouped functions by which storage they operate

on in Mac port, but didn't add explanatory comments yet, because this is different
in some ports.

  • platform/mac/CookieJar.mm:

(WebCore): Removed special code for isHTTPOnly, it's present in Foundation in all
supported OS X versions.
(WebCore::filterCookies): Use -isHTTPOnly directly.
(WebCore::cookies): Get rid of a variable for URL, implicit conversion works just as well.
(WebCore::cookieRequestHeaderFieldValue): Ditto.
(WebCore::setCookies): Assert that no more than one cookie was created from one
Set-Cookie header, document.cookie can only be used to set one cookie at a time.
(WebCore::getRawCookies): Removed useless local variables.

  • platform/network/CookieStorage.h: Removed an unneeded include, clarified a comment.
  • platform/network/HTTPHeaderMap.h: Added a FIXME.
1:19 PM Changeset in webkit [133663] by dpranke@chromium.org
  • 4 edits
    2 deletes in trunk/LayoutTests

Unreviewed chromium, chromium-mac-mountainlion gardening

Remove a bunch of passing tests, and clean up a couple of ML issues.

  • platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.png: Removed.
  • platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
  • platform/chromium/TestExpectations:
1:19 PM Changeset in webkit [133662] by Lucas Forschler
  • 6 edits
    2 adds in branches/safari-536.28-branch

Merged r126131. <rdar://problem/12536500>

1:13 PM Changeset in webkit [133661] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Indentation of JSCell.h is wrong
https://bugs.webkit.org/show_bug.cgi?id=101379

Rubber stamped by Alexey Proskuryakov.

Just removed four spaces on a bunch of lines.

  • runtime/JSCell.h:
1:08 PM Changeset in webkit [133660] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Implement MediaPlayerPrivate::didLoadingProgress for BlackBerry platform
https://bugs.webkit.org/show_bug.cgi?id=100378

Patch by John Griggs <jgriggs@rim.com> on 2012-11-06
Reviewed by Eric Carlson.

Implement this method for BlackBerry platform.

New test: LayoutTests/media/progress-events-generated-correctly.html

Source/WebCore:

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::didLoadingProgress):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

LayoutTests:

  • media/progress-events-generated-correctly-expected.txt: Added.
  • media/progress-events-generated-correctly.html: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
12:44 PM Changeset in webkit [133659] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Wrong scroll position when going back in history
https://bugs.webkit.org/show_bug.cgi?id=101358

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-06
Reviewed by Kenneth Rohde Christiansen.

Reset the contentsSize after a new load was committed. We should not continue
to use the contentsSize of the previous page in any calculation.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didCommitLoad):

12:43 PM Changeset in webkit [133658] by Lucas Forschler
  • 7 edits
    2 copies in branches/safari-536.28-branch

Merged r125988. <rdar://problem/12536463>

12:25 PM Changeset in webkit [133657] by abarth@webkit.org
  • 3 edits
    1 add in trunk

DOMImplementation should use ScriptWrappable
https://bugs.webkit.org/show_bug.cgi?id=101279

Reviewed by Eric Seidel.

PerformanceTests:

This simple PerformanceTest measure how quickly we can access
document.implementation. The goal of this performance test is just to
validate that using ScriptWrappable actually makes the bindings faster.

  • Bindings/document-implementation.html: Added.

Source/WebCore:

This patch makes DOMImplementation ScriptWrappable. Both the V8 and JSC
bindings automatically detect the presence of this base class and use
it to optimize getting and setting JavaScript wrappers.

This patch is a 23% progression on Bindings/document-implementation for
the V8 bindings and a 69% progression for the JSC bindings.

  • dom/DOMImplementation.h:
12:23 PM Changeset in webkit [133656] by Lucas Forschler
  • 1 edit
    2 copies in branches/safari-536.28-branch/LayoutTests

Merged r126144. <rdar://problem/12516374>

12:22 PM Changeset in webkit [133655] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.28-branch

Merged r125631. <rdar://problem/12516374>

12:10 PM Changeset in webkit [133654] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-06

  • DEPS:
12:10 PM Changeset in webkit [133653] by benjamin@webkit.org
  • 5 edits in trunk/Source

Speed up TransformationMatrix::multiply() on modern ARM
https://bugs.webkit.org/show_bug.cgi?id=101084

Reviewed by Gavin Barraclough.

Source/WebCore:

The main improvements are:
-Store the full source matrix in the registers d16 to d31. This way we avoid going

back and forth to memory to use the operands.
Since the full matrix is in register, we can also directly modify the memory of m_matrix,
we no longer need the temporary matrix memcopied at the end.

-Use of LoadMultiple and StoreMultiple to load-store the matrix parameters.
-Use Multiply-Accumulate instead of VMUL followed by VADD. This half the number of instruction.
-On regular ARMv7, using a loop to reuse the same code for each row also improve the performance.

Depending on the hardware, the new code takes 20% to 42% less time than the basic implementation.

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::multiply):

  • platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

Source/WTF:

  • wtf/Platform.h:

Add CPU(ARM_VFP) for detecting VFP availability.
Add CPU(APPLE_ARMV7S) for the Apple ARMv7S architecture.

12:08 PM Changeset in webkit [133652] by kareng@chromium.org
  • 8 edits in branches/chromium/1180/Source/WebCore

Revert 123677 - Merge 123495 - Files from drag and file <input> should use getMIMETypeForExtension to determine content type.
https://bugs.webkit.org/show_bug.cgi?id=91702

Reviewed by Jian Li.

Awhile back, we changed File to only use getWellKnownMIMETypeForExtension to prevent web
pages from being able to detect what applications a user has installed indirectly through
the MIME types. However, some sites like YouTube's drag and drop uploader use MIME types
that aren't in WebKit's internal list, so we relax the restriction for Files that originate
from an user action.

  • fileapi/File.cpp:

(WebCore::getContentTypeFromFileName):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):
(WebCore::createBlobDataForFileWithMetadata):
(WebCore::File::createWithRelativePath):
(WebCore::File::File):

  • fileapi/File.h:

(File):
(WebCore::File::create):
(WebCore::File::createWithName):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createFileList):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::addFilename):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::files):

  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::files):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::files):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::files):

TBR=dcheng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10821032

TBR=kareng@chromium.org
Review URL: https://codereview.chromium.org/11370004

12:03 PM Changeset in webkit [133651] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.28-branch

Merged r125503. <rdar://problem/12536466>

11:24 AM Changeset in webkit [133650] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
11:19 AM Changeset in webkit [133649] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Indentation of JSObject.h is wrong
https://bugs.webkit.org/show_bug.cgi?id=101313

Rubber stamped by Alexey Proskuryakov.

Just unindented code, since namespace bodies shouldn't be indented.

  • runtime/JSObject.h:
11:18 AM Changeset in webkit [133648] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[CSS Regions] Fix failing tests on Mac after sub-pixel layout was enabled
https://bugs.webkit.org/show_bug.cgi?id=101364

Patch by Andrei Bucur <abucur@adobe.com> on 2012-11-06
Reviewed by Simon Fraser.

There are no changes in the code. Only the tests had to be fixed.

  • fast/regions/float-pushed-width-change-expected.html: Remove the unnecessary 0.5px margin.
  • fast/regions/floats-basic-in-variable-width-regions-expected.html: Because of how regions are implemented, the left offset for lines is 50px (the float width) - X.5px (margin: auto gives a different value in the two regions). This translated into 37.5px which triggered a sub-pixel layout issue. The new width values changes the X.5px into a rounded value.
  • fast/regions/floats-basic-in-variable-width-regions.html: See above
  • fast/regions/render-region-renderer-expected.html: Remove unnecessary 0.5px height.
11:15 AM Changeset in webkit [133647] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html flaky on linux debug
https://bugs.webkit.org/show_bug.cgi?id=101377

Unreviewed gardening. Add new expectation, remove expectation for reverted change.

  • platform/chromium/TestExpectations:
11:13 AM Changeset in webkit [133646] by fpizlo@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix ChangeLog comment: r133645 was rubber stamped by, not reviwed by, Alexey.

11:10 AM Changeset in webkit [133645] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Indentation of JSArray.h is wrong
https://bugs.webkit.org/show_bug.cgi?id=101314

Reviewed by Alexey Proskuryakov.

Just removing the indentation inside the namespace body.

  • runtime/JSArray.h:
11:10 AM Changeset in webkit [133644] by commit-queue@webkit.org
  • 13 edits
    68 deletes in trunk

Unreviewed, rolling out r133529 and r133562.
http://trac.webkit.org/changeset/133529
http://trac.webkit.org/changeset/133562
https://bugs.webkit.org/show_bug.cgi?id=101371

Caused 15% memory regression on Chromium page cyclers
(Requested by jsbell|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-06

Source/WebCore:

  • platform/text/LineBreakIteratorPoolICU.h:

(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):

  • platform/text/TextBreakIterator.cpp:

(WebCore::acquireLineBreakIterator):

  • platform/text/TextBreakIterator.h:

(WebCore):
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • platform/text/gtk/TextBreakIteratorGtk.cpp:

(WebCore::setUpIterator):
(WebCore::acquireLineBreakIterator):

  • platform/text/wince/TextBreakIteratorWinCE.cpp:

(WebCore::acquireLineBreakIterator):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/RenderText.h:

(WebCore):

  • rendering/break_lines.cpp:

(WebCore):
(WebCore::isBreakableSpace):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):

  • rendering/break_lines.h:

(WebCore):
(WebCore::isBreakable):

LayoutTests:

  • css3/line-break/line-break-auto-centered-expected.html: Removed.
  • css3/line-break/line-break-auto-centered.html: Removed.
  • css3/line-break/line-break-auto-half-kana-expected.html: Removed.
  • css3/line-break/line-break-auto-half-kana.html: Removed.
  • css3/line-break/line-break-auto-hyphens-expected.html: Removed.
  • css3/line-break/line-break-auto-hyphens.html: Removed.
  • css3/line-break/line-break-auto-inseparables-expected.html: Removed.
  • css3/line-break/line-break-auto-inseparables.html: Removed.
  • css3/line-break/line-break-auto-iteration-marks-expected.html: Removed.
  • css3/line-break/line-break-auto-iteration-marks.html: Removed.
  • css3/line-break/line-break-auto-postfixes-expected.html: Removed.
  • css3/line-break/line-break-auto-postfixes.html: Removed.
  • css3/line-break/line-break-auto-prefixes-expected.html: Removed.
  • css3/line-break/line-break-auto-prefixes.html: Removed.
  • css3/line-break/line-break-auto-sound-marks-expected.html: Removed.
  • css3/line-break/line-break-auto-sound-marks.html: Removed.
  • css3/line-break/line-break-loose-centered-expected.html: Removed.
  • css3/line-break/line-break-loose-centered.html: Removed.
  • css3/line-break/line-break-loose-half-kana-expected.html: Removed.
  • css3/line-break/line-break-loose-half-kana.html: Removed.
  • css3/line-break/line-break-loose-hyphens-expected.html: Removed.
  • css3/line-break/line-break-loose-hyphens.html: Removed.
  • css3/line-break/line-break-loose-inseparables-expected.html: Removed.
  • css3/line-break/line-break-loose-inseparables.html: Removed.
  • css3/line-break/line-break-loose-iteration-marks-expected.html: Removed.
  • css3/line-break/line-break-loose-iteration-marks.html: Removed.
  • css3/line-break/line-break-loose-postfixes-expected.html: Removed.
  • css3/line-break/line-break-loose-postfixes.html: Removed.
  • css3/line-break/line-break-loose-prefixes-expected.html: Removed.
  • css3/line-break/line-break-loose-prefixes.html: Removed.
  • css3/line-break/line-break-loose-sound-marks-expected.html: Removed.
  • css3/line-break/line-break-loose-sound-marks.html: Removed.
  • css3/line-break/line-break-normal-centered-expected.html: Removed.
  • css3/line-break/line-break-normal-centered.html: Removed.
  • css3/line-break/line-break-normal-half-kana-expected.html: Removed.
  • css3/line-break/line-break-normal-half-kana.html: Removed.
  • css3/line-break/line-break-normal-hyphens-expected.html: Removed.
  • css3/line-break/line-break-normal-hyphens.html: Removed.
  • css3/line-break/line-break-normal-inseparables-expected.html: Removed.
  • css3/line-break/line-break-normal-inseparables.html: Removed.
  • css3/line-break/line-break-normal-iteration-marks-expected.html: Removed.
  • css3/line-break/line-break-normal-iteration-marks.html: Removed.
  • css3/line-break/line-break-normal-postfixes-expected.html: Removed.
  • css3/line-break/line-break-normal-postfixes.html: Removed.
  • css3/line-break/line-break-normal-prefixes-expected.html: Removed.
  • css3/line-break/line-break-normal-prefixes.html: Removed.
  • css3/line-break/line-break-normal-sound-marks-expected.html: Removed.
  • css3/line-break/line-break-normal-sound-marks.html: Removed.
  • css3/line-break/line-break-strict-centered-expected.html: Removed.
  • css3/line-break/line-break-strict-centered.html: Removed.
  • css3/line-break/line-break-strict-half-kana-expected.html: Removed.
  • css3/line-break/line-break-strict-half-kana.html: Removed.
  • css3/line-break/line-break-strict-hyphens-expected.html: Removed.
  • css3/line-break/line-break-strict-hyphens.html: Removed.
  • css3/line-break/line-break-strict-inseparables-expected.html: Removed.
  • css3/line-break/line-break-strict-inseparables.html: Removed.
  • css3/line-break/line-break-strict-iteration-marks-expected.html: Removed.
  • css3/line-break/line-break-strict-iteration-marks.html: Removed.
  • css3/line-break/line-break-strict-postfixes-expected.html: Removed.
  • css3/line-break/line-break-strict-postfixes.html: Removed.
  • css3/line-break/line-break-strict-prefixes-expected.html: Removed.
  • css3/line-break/line-break-strict-prefixes.html: Removed.
  • css3/line-break/line-break-strict-sound-marks-expected.html: Removed.
  • css3/line-break/line-break-strict-sound-marks.html: Removed.
  • platform/chromium-android/css3/line-break/line-break-auto-half-kana-expected.html: Removed.
  • platform/chromium-android/css3/line-break/line-break-auto-sound-marks-expected.html: Removed.
  • platform/chromium/css3/line-break/line-break-auto-half-kana-expected.html: Removed.
  • platform/chromium/css3/line-break/line-break-auto-sound-marks-expected.html: Removed.
11:08 AM Changeset in webkit [133643] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Declare all smart callbacks in EwkViewCallbacks.h
https://bugs.webkit.org/show_bug.cgi?id=101360

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-06
Reviewed by Kenneth Rohde Christiansen.

Declare all EwkView smart callbacks in EwkViewCallbacks.h
and remove remaining calls to evas_object_smart_callback_call().
It is a good idea to have all the callbacks declared in one
place for convenience and consistency. We also have better
argument type checking if we use the new callback mechanism.

  • UIProcess/API/efl/EwkViewCallbacks.h:

(EwkViewCallbacks::CallBack::call):
(CallBack):
(EwkViewCallbacks):

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::informIconChange):
(EwkViewImpl::informURLChange):
(EwkViewImpl::createNewPage):
(EwkViewImpl::closePage):

11:04 AM Changeset in webkit [133642] by peter@chromium.org
  • 4 edits in trunk/Source

[Chromium] Enable the JavaScript i18n API for Android
https://bugs.webkit.org/show_bug.cgi?id=101357

Reviewed by Adam Barth.

Source/WebCore:

Remove the conditional dependency on the v8-i18n API. The library is now
always available in a Chromium for Android checkout.

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

Enable the JavaScript i18n API for Chromium on Android. This adds a
grand total of 18.7 KiB of data to the content shell apk.

  • features.gypi:
11:03 AM Changeset in webkit [133641] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium-mac-mountainlion expectations to remove passing tests.

  • platform/chromium-mac-mountainlion/TestExpectations:
10:58 AM Changeset in webkit [133640] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Don't dump pixels for filter-empty-element-crash.
https://bugs.webkit.org/show_bug.cgi?id=101359

Reviewed by Adrienne Walker.

  • css3/filters/filter-empty-element-crash.html:
10:51 AM Changeset in webkit [133639] by Simon Fraser
  • 3 edits in trunk/LayoutTests

(r133351): Number of test failures from enabling SUBPIXEL_LAYOUT on Mac
https://bugs.webkit.org/show_bug.cgi?id=101220

New baselines for two more tests whose output was affected by enabling subpixel layout.

  • platform/mac/fast/dynamic/subtree-parent-static-y-expected.txt:
  • platform/mac/fast/images/repaint-subrect-grid-expected.txt:
10:48 AM WebKit Team edited by yael@webkit.org
(diff)
10:43 AM Changeset in webkit [133638] by senorblanco@chromium.org
  • 3 edits in trunk/LayoutTests

Add new test cases to layout test effect-reference and effect-reference-hw.
https://bugs.webkit.org/show_bug.cgi?id=101366

Reviewed by Dean Jackson.

  • css3/filters/effect-reference-hw.html:
  • css3/filters/effect-reference.html:

Add some test cases for feBlend and feSpecularLighting.

10:42 AM Changeset in webkit [133637] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Hook up the remote layer tree drawing area to an environment variable
https://bugs.webkit.org/show_bug.cgi?id=101267

Reviewed by Andreas Kling.

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::sizeDidChange):
(WebKit::RemoteLayerTreeDrawingAreaProxy::deviceScaleFactorDidChange):

10:40 AM Changeset in webkit [133636] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[chromium] Two touchadjustment tests are failing on mac
https://bugs.webkit.org/show_bug.cgi?id=100833

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-06
Reviewed by Antonio Gomes.

Re-enable these two tests with appropriate tweaks. Also avoid the platform dependant
behavior by switching to the Ahem font.

  • platform/chromium/TestExpectations: Remove the failure expectations.
  • touchadjustment/html-label.html: Tweak one very borderline case to be closer to pass

reliably. Previously this passed only due to a bug in the test infrastructure fixed in r132929.

  • touchadjustment/nested-touch.html: Tweak borderline case to compensate for inclusion of

the border in the measurement of the size of the div.

10:27 AM Changeset in webkit [133635] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
10:25 AM Changeset in webkit [133634] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Adding window.external to our port
https://bugs.webkit.org/show_bug.cgi?id=100868

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-06
Reviewed by Rob Buis.

Patching the method names to match the ones in the spec.

  • WebCoreSupport/ExternalExtension.cpp:
10:19 AM Changeset in webkit [133633] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

ScriptWrappable should work for more than just Node
https://bugs.webkit.org/show_bug.cgi?id=101319

Reviewed by Eric Seidel.

This patch generalizes the inline cached wrapper code path to work with
all subclasses of ScriptWrappable, not just Node.

  • bindings/js/JSDOMBinding.h:

(WebCore::setInlineCachedWrapper):
(WebCore::getInlineCachedWrapper):
(WebCore):
(WebCore::clearInlineCachedWrapper):
(WebCore::cacheWrapper):

  • bindings/js/JSNodeCustom.h:
10:17 AM Changeset in webkit [133632] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-06
Reviewed by Rob Buis.

Revert webkit/ce306dcc698199a6f7ce679daf0a30c25d3a3d43 slider theme
change which break media control and vertical slider.

RIM PR 236993
Internal Reviewed by Jeff Rogers.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintSliderTrackRect):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):

10:15 AM Changeset in webkit [133631] by msaboff@apple.com
  • 4 edits in trunk/Source/WebCore

canonicalizedTitle() shouldn't convert 8 bit title strings to 16 bit
https://bugs.webkit.org/show_bug.cgi?id=101105

Reviewed by Darin Adler.

Turned canonicalizedTitle() into a templated function based on character type.
Changed call in updateTitle() to check the bitness of the title string to call
the right template flavor of canonicalizedTitle().
Made supporting changes by adding displayBufferModifiedByEncoding(LChar*, ...)
and made TextEncoding::displayBuffer() a templated function as well.

No new tests needed, as functionality is unchanged.

  • dom/Document.cpp:

(WebCore::canonicalizedTitle):
(WebCore::Document::updateTitle):
(WebCore::Document::displayBufferModifiedByEncodingInternal):

  • dom/Document.h:

(WebCore::Document::displayBufferModifiedByEncoding):

  • platform/text/TextEncoding.h:

(TextEncoding):
(WebCore::TextEncoding::displayBuffer):

10:15 AM Changeset in webkit [133630] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] css3/line-break/line-break-strict-sound-marks.html image flaky on Mac 10.7
https://bugs.webkit.org/show_bug.cgi?id=101368

Unreviewed gardening.

  • platform/chromium/TestExpectations:
10:01 AM Changeset in webkit [133629] by zhajiang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Page can't back to whole screen after zoom out and orientation change
https://bugs.webkit.org/show_bug.cgi?id=101350

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>.
Internally reviewed by Arvid Nilsson.

PR: 229321
When rotating device during touch interaction, bitmap zooming was
unexpected ended by resetBitmapZoomScale() so that it couldn't bounce
back. The call resetBitmapZoomScale() is ancient, which just resets the
scale of the bitmap before. Right now it only ends the bitmap zooming
which caused the issue. As UI viewport will be updated by zoomChanged()
right after that, we can remove this trouble maker.
Update the interaction views if the rotation is being changed so that
ZoomHandler can get the updated views.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):

  • Api/WebPageClient.h:
9:57 AM Changeset in webkit [133628] by Simon Fraser
  • 3 edits
    2 adds in trunk

Fix RenderGeometryMap assertion when layers are scrolled during layout
https://bugs.webkit.org/show_bug.cgi?id=101292

Reviewed by Beth Dakin.

Source/WebCore:

When we set RenderLayer scroll positions as part of layout, we don't want
to update compositing layers right away. Updating compositing layers
requires that the entire layer tree has been updated from renderers,
so that the geometry of all RenderLayers can be trusted. When this state
was violated, RenderGeometryMap asserts.

Fix by bailing from updateCompositingLayersAfterScroll() if FrameView
tells us that we're doing layout. A full update of the compositing layers
will happen later anyway.

Test: compositing/geometry/geometry-map-scroll-during-layout-assertion.html

  • rendering/RenderLayer.cpp:

(WebCore::frameViewFromLayer):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):

LayoutTests:

Test that hit the assertion before the fix.

  • compositing/geometry/geometry-map-scroll-during-layout-assertion-expected.txt: Added.
  • compositing/geometry/geometry-map-scroll-during-layout-assertion.html: Added.
9:54 AM Changeset in webkit [133627] by jsbell@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening - more rebaselines following bug 101115.

  • platform/chromium-mac-lion/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/chromium-mac-lion/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
  • platform/chromium-mac-lion/fast/block/lineboxcontain/glyphs-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/stacked-diacritics-expected.png: Added.
9:50 AM Changeset in webkit [133626] by tommyw@google.com
  • 2 edits in trunk/Tools

[chromium] MediaStream API: Remove the valgrind issue with MockWebRTCPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=101336

Reviewed by Andreas Kling.

This patch changes the delete to delete [] to match the new[].

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
9:42 AM Changeset in webkit [133625] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

quoteCSSString() always creates a 16 bit string
https://bugs.webkit.org/show_bug.cgi?id=101004

Reviewed by Darin Adler.

Added a new templated helper based on character type from the logic of quoteCSSString() to process
the argument string based on its native bitness.

Functionality covered by existing tests.

  • css/CSSParser.cpp:

(WebCore::quoteCSSStringInternal):
(WebCore::quoteCSSString):

9:34 AM Changeset in webkit [133624] by abecsi@webkit.org
  • 7 edits
    1 add in trunk/Source

[Qt][WK2] Fit-to-width broken on pages with viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=99715

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Add a bool that indicates if the content had an explicit
initial-scale in the viewport meta tag.

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):

  • dom/ViewportArguments.h:

(ViewportAttributes):

Source/WebKit2:

The initial scale from the viewport attributes should only
be applied if the scale was explicitly specified in the
viewport meta tag.
If the initial scale is auto it should be calculated using
the final contents size, which might be larger than the
layout size, so that the content fits horizontally into
the view.

Also add QML unit tests that cover this functionality.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml:
  • UIProcess/API/qt/tests/qmltests/common/test5.html: Added.
  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageTransitionViewportReady):

9:31 AM Changeset in webkit [133623] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Refactor setting TEXTURE_MAPPER_GL
https://bugs.webkit.org/show_bug.cgi?id=99758

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-06
Reviewed by Noam Rosenthal.

Make the rule that sets the default for USE(3D_GRAPHICS) port independent.

If not set, set USE(TEXTURE_MAPPER_GL) when USE(TEXTURE_MAPPER) and
USE(3D_GRAPHICS) is enabled.

  • wtf/Platform.h:
9:28 AM Changeset in webkit [133622] by rakuco@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] Gardening, add pixel expectation for test.

  • platform/efl/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
9:26 AM Changeset in webkit [133621] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] fast/dom/Window/customized-property-survives-gc.html slow on debug
https://bugs.webkit.org/show_bug.cgi?id=101362

Unreviewed gardening.

  • platform/chromium/TestExpectations:
9:15 AM Changeset in webkit [133620] by mkwst@chromium.org
  • 20 edits
    4 adds in trunk

CSP 1.1: Tweak the script interface to match the spec.
https://bugs.webkit.org/show_bug.cgi?id=101321

Reviewed by Adam Barth.

Source/WebCore:

This patch brings WebKit in line with the changes made to the spec in
https://dvcs.w3.org/hg/content-security-policy/rev/5a29424a37d4.
Specifically, the following:

  • Renamed 'document.SecurityPolicy' to 'document.securityPolicy'
  • Converted the following to read-only boolean attributes:
  • 'allowsEval'
  • 'allowsInlineScript'
  • 'allowsInlineStyle'
  • 'isActive'

These changes only have effect for ports with CSP_NEXT enabled.

Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowinlinescript.html

http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowinlinestyle.html

  • dom/Document.idl:
  • page/DOMSecurityPolicy.idl:

Tweaking the IDL files to match the new definition of the
functionlity in the spec.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowconnectionto.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-alloweval.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowfontfrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowformaction.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowframefrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowimagefrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowmediafrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowobjectfrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowplugintype.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowscriptfrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowstylefrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-isactive-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-isactive.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-reporturi-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-reporturi.html:
  • http/tests/security/contentSecurityPolicy/resources/securitypolicy-tests-base.js:

s/document.SecurityPolicy/document.securityPolicy/g

  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowinlinescript-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowinlinescript.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowinlinestyle-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowinlinestyle.html: Added.

For whatever reason, we never wrote tests for these methods. Now we
have, which is good.

9:02 AM EFLWebKit edited by Laszlo Gombos
add an example to turn on verbose build logs for cmake (diff)
8:44 AM Changeset in webkit [133619] by Dave Barton
  • 8 edits
    20 adds in trunk/LayoutTests

Unreviewed gardening after bug 101115 fixed.

  • platform/chromium-linux-x86/fast/block/lineboxcontain: Added.
  • platform/chromium-linux-x86/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
  • platform/chromium-linux-x86/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
  • platform/chromium-linux-x86/fast/block/lineboxcontain/glyphs-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/lineboxcontain/glyphs-expected.txt: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-expected.png:
  • platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/glyphs-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/glyphs-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/stacked-diacritics-expected.png:
  • platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-expected.png:
  • platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.png:
  • platform/chromium-mac/fast/block/lineboxcontain/glyphs-expected.png:
  • platform/chromium-mac/fast/repaint/stacked-diacritics-expected.png:
  • platform/chromium-win-xp/fast/block/lineboxcontain: Added.
  • platform/chromium-win-xp/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
  • platform/chromium-win-xp/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
  • platform/chromium-win-xp/fast/block/lineboxcontain/glyphs-expected.png: Added.
  • platform/chromium-win-xp/fast/block/lineboxcontain/glyphs-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/glyphs-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/glyphs-expected.txt: Added.
  • platform/chromium/TestExpectations:
8:37 AM EFLWebKit edited by Laszlo Gombos
sort the list of dependent packages to avoid adding the same package … (diff)
8:37 AM Changeset in webkit [133618] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add Adobe's bug tracker to committers.py
https://bugs.webkit.org/show_bug.cgi?id=101338

Patch by Mihai Balan <mibalan@adobe.com> on 2012-11-06
Reviewed by Kentaro Hara.

Adding Adobe's bug tracker mailing list to committers.py
to enable its inclusion in the autocomplete list.

  • Scripts/webkitpy/common/config/committers.py:
8:22 AM Changeset in webkit [133617] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Make webkit_lint happy. Unreviewed.

  • platform/chromium/TestExpectations:
8:18 AM Changeset in webkit [133616] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Mark fast/dom/shadow/shadowdom-for-output-only-shadow.html as flaky.

  • platform/efl/TestExpectations:
8:15 AM Changeset in webkit [133615] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening. Unskip test that's been passing for a while.

  • platform/efl-wk2/TestExpectations:
8:14 AM Changeset in webkit [133614] by commit-queue@webkit.org
  • 15 edits
    2 adds in trunk

Added console.clear() method

Web Inspector: add console.clear()
https://bugs.webkit.org/show_bug.cgi?id=101021

Patch by Andrey Lushnikov <lushnikov@google.com> on 2012-11-06
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Adds native implementation of console.clear

Test: inspector/console/console-clear-function.html

  • English.lproj/localizedStrings.js: Adds 'Console was cleared' string
  • inspector/ConsoleMessage.cpp:

(WebCore::messageTypeValue): Adds ClearMessageType

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage): Display strategy for "clear" message

  • inspector/front-end/ConsoleModel.js:
  • inspector/front-end/inspector.css:

(.console-info): Adds style for the 'console was cleared' message

  • page/Console.cpp: backend binging for console.clear()

(WebCore::Console::clear):
(WebCore):

  • page/Console.h:

(Console):

  • page/Console.idl: Adds 'clear' message to protocol
  • page/ConsoleTypes.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.mm:

(stringForMessageType): Added ClearMessageType case to switch

LayoutTests:

  • inspector/console/console-clear-function-expected.txt: Added.
  • inspector/console/console-clear-function.html: Added.
8:11 AM Changeset in webkit [133613] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] fast/images/exif-orientation-image-document.html failing on WK2 bots
https://bugs.webkit.org/show_bug.cgi?id=101344

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-06

  • platform/efl-wk2/TestExpectations:
8:06 AM Changeset in webkit [133612] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
8:00 AM Changeset in webkit [133611] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
7:54 AM Changeset in webkit [133610] by commit-queue@webkit.org
  • 5 edits in trunk

Heap-buffer-overflow in WebCore::TextTrackCueList::add
https://bugs.webkit.org/show_bug.cgi?id=101018

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-11-06
Reviewed by Eric Carlson.

Source/WebCore:

Added an extra check to avoid using a negative array index when a cue
is added to the beginning of the list.

Test case added to LayoutTests/media/track/track-add-remove-cue.html.

  • html/track/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add):

LayoutTests:

Added a test case to verify that adding a cue to the beginning of a non-empty list doesn't crash.

  • media/track/track-add-remove-cue-expected.txt:
  • media/track/track-add-remove-cue.html:
7:42 AM Changeset in webkit [133609] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Regression(r132681): Heap-use-after-free in WebCore::RenderTextTrackCue::layout
https://bugs.webkit.org/show_bug.cgi?id=100981

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-11-06
Reviewed by Eric Carlson.

Source/WebCore:

Fixing a TextTrackCue use after free bug. textTrackRemoveCues() needs to be called when
an HTMLTrackElement is removed from an HTMLMediaElement so that references to
TextTrackCues are removed from m_cueTree.

Test: media/track/track-remove-by-setting-innerHTML.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::willRemoveTrack):

LayoutTests:

Added a test that removes track elements by setting innerHTML on the track's parent.

  • media/track/track-remove-by-setting-innerHTML-expected.txt: Added.
  • media/track/track-remove-by-setting-innerHTML.html: Added.
7:34 AM Changeset in webkit [133608] by senorblanco@chromium.org
  • 27 edits
    1 copy
    2 adds in trunk

[skia] Implement reference (url) filters on composited layers.
https://bugs.webkit.org/show_bug.cgi?id=100142

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebLayer.h:

Expose Layer::setFilter() to the WebKit API.

Source/WebCore:

Covered by css3/filters/effect-reference-hw.html

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Add new files.

  • WebCore.xcodeproj/project.pbxproj:

Mark FilterEffect.h as "private".

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setFilters):
Use the new SkImageFilter builder and setLayer() infrastructure, but
only if there's a reference filter in the chain.

  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::createImageFilter):
Add createImageFilter() factory function for building SkImageFilters.

  • platform/graphics/filters/FilterOperation.h:

(WebCore::FilterOperation::ReferenceFilterOperation::filterEffect):
(WebCore::FilterOperation::ReferenceFilterOperation::setFilterEffect):
Add a FilterEffect member to ReferenceFilterOperation, and accessors
for it.

  • platform/graphics/filters/skia/FEBlendSkia.cpp:

(WebCore::FEBlend::createImageFilter):
Implement SkImageFilter building for FEBlend filter.

  • platform/graphics/filters/skia/FEColorMatrixSkia.cpp:

(WebCore::createColorFilter):
(WebCore::FEColorMatrix::platformApplySkia):
Refactor creation of SkColorFilter from an FEColorMatrix filter.
(WebCore::FEColorMatrix::createImageFilter):
Implement SkImageFilter building for FEColorMatrix filter.

  • platform/graphics/filters/skia/FEGaussianBlurSkia.cpp:

(WebCore::FEGaussianBlur::createImageFilter):
Implement SkImageFilter building for FEGaussianBlur filter.

  • platform/graphics/filters/skia/FELightingSkia.cpp:

(WebCore::FELighting::createImageFilter):
Implement SkImageFilter building for FELighting filters.

  • platform/graphics/filters/skia/FEMorphologySkia.cpp:

(WebCore::FEMorphology::createImageFilter):
Implement SkImageFilter building for FEMorphology filter.

  • platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp: Added.

(WebCore::SkiaImageFilterBuilder::SkiaImageFilterBuilder):
(WebCore::SkiaImageFilterBuilder::build):

  • platform/graphics/filters/skia/SkiaImageFilterBuilder.h:

Implement new helper class for building an SkImageFilter DAG from
a FilterEffect DAG. Can also build from FilterOperations list.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):
When building FilterEffects from a reference filter, also store the
generated DAG on the ReferenceFilterOperation itself.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateOrRemoveFilterEffect):
Even when in composited mode, if there's a reference filter in the
chain, build the FilterEffect DAG from it.

7:32 AM Changeset in webkit [133607] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

[chromium] Enable fixed position compositing on Android DRT
https://bugs.webkit.org/show_bug.cgi?id=100263

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-06
Reviewed by James Robinson.

Chrome on Android forces composited mode for every page and creates
stacking contexts and graphics layers for fixed positioned elements.
Change the DumpRenderTree settings to match this.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setAcceleratedCompositingForFixedPositionEnabled):
(TestShell):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.additional_drt_flag):

7:27 AM Changeset in webkit [133606] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[BlackBerry] Automatically go fullscreen on video play
https://bugs.webkit.org/show_bug.cgi?id=101100

Patch by Max Feil <mfeil@rim.com> on 2012-11-06
Reviewed by Eric Carlson.

Source/WebCore:

There is a requirement to have HTML5 video automatically enter
fullscreen when a video starts playing (PR131774). This change
implements this feature, with restrictions. The main restriction
is adherence to WebKit's philosophy of only entering fullscreen
due to a user gesture. This is important in order to avoid
pop-up advertisements and other unwanted fullscreen content.
One consequence of this is that video elements with the autoplay
attribute will not automatically enter fullscreen.

Other caveats:

  • This feature applies only to "small screen" devices where

automatically going fullscreen makes more sense.

  • Fullscreen will only be entered automatically when the

video is played from the beginning (current time is zero).
It is assumed that if the user is resuming play from a paused
state and is not in fullscreen mode, then they exited fullscreen
mode intentionally.

Test: platform/blackberry/media/video-automatic-fullscreen.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerEnterFullscreen):
(WebCore):
(WebCore::HTMLMediaElement::mediaPlayerIsFullscreen):
(WebCore::HTMLMediaElement::mediaPlayerIsFullscreenPermitted):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerEnterFullscreen):
(WebCore::MediaPlayerClient::mediaPlayerIsFullscreen):
(WebCore::MediaPlayerClient::mediaPlayerIsFullscreenPermitted):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
(WebCore::MediaPlayerPrivate::conditionallyGoFullscreenAfterPlay):
(WebCore):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

LayoutTests:

Test that fullscreen is entered automatically when play is
pressed (PR131774). This test applies to handheld (small screen)
devices only, not tablets. The html code for this test was based
on video-controls-fullscreen-volume.html and modified.

  • platform/blackberry/media/video-automatic-fullscreen-expected.txt: Added.
  • platform/blackberry/media/video-automatic-fullscreen.html: Added.
7:20 AM Changeset in webkit [133605] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Coordinated Graphics: Remove a parent member in WebLayerInfo.
https://bugs.webkit.org/show_bug.cgi?id=101142

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-06
Reviewed by Noam Rosenthal.

The parent member is not used in UI Process, and GraphicsLayer::setParent is
internally used only, so we don't need to send the parent layer id to UI Process.

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerInfo::WebLayerInfo):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::syncLayerState):

7:16 AM Changeset in webkit [133604] by pfeldman@chromium.org
  • 13 edits in branches/chromium/1312/Source/WebCore/inspector

Merge 133052 - Web Inspector: frame chooser does not work on subsequent inspector open.
https://bugs.webkit.org/show_bug.cgi?id=100771

Reviewed by Yury Semikhatsky.

  • Make WorkerRuntimeAgent and PageRuntimeAgent register themselves in the instrumenting agents independently
  • Move pause / run worker handling from InspectorRuntimeAgent into WorkerRuntimeAgent
  • Remove remains of the front-end reused signal from InspectorAgent
  • Send execution contexts post clear window object instead of post commit load.
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::clearFrontend):
(WebCore::InspectorAgent::didCommitLoad):

  • inspector/InspectorAgent.h:

(InspectorAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::restore):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::run):
(WebCore::InspectorRuntimeAgent::setScriptDebugServer):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

  • inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::workerRuntimeAgent):
(WebCore::InstrumentingAgents::setWorkerRuntimeAgent):
(InstrumentingAgents):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::~PageRuntimeAgent):
(WebCore::PageRuntimeAgent::setFrontend):
(WebCore::PageRuntimeAgent::clearFrontend):
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::didCreateMainWorldContext):

  • inspector/PageRuntimeAgent.h:

(PageRuntimeAgent):

  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::run):
(WebCore):
(WebCore::WorkerRuntimeAgent::pauseWorkerContext):

  • inspector/WorkerRuntimeAgent.h:

(WorkerRuntimeAgent):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11366107

7:16 AM Changeset in webkit [133603] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: Remove two methods' virtual modifiers in CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=101141

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-06
Reviewed by Noam Rosenthal.

The methods exist for only CoordinatedGraphicsLayer and we have no plan to
extend CoordinatedGraphicsLayer.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

7:14 AM Changeset in webkit [133602] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebCore

[WK2][EFL][GTK] early return of checkSpellingOfString treats correct words as misspelled
https://bugs.webkit.org/show_bug.cgi?id=101215

Reviewed by Gustavo Noronha Silva.

Save the misspelled location and length of the string to the default values (-1, 0)
at the beginning of the checkSpellingOfString method.
It assumes that the words are spelled correctly and early return of method doesn't
cause assertions in findFirstMisspelling (WebCore/editing/TextCheckingHelper.cpp).

  • platform/text/enchant/TextCheckerEnchant.cpp:

(TextCheckerEnchant::checkSpellingOfString):

7:12 AM Changeset in webkit [133601] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[TexMap] Remove unused textures in the texture pool.
https://bugs.webkit.org/show_bug.cgi?id=100706

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-06
Reviewed by Noam Rosenthal.

Currently, we do not remove textures in the texture pool of
TextureMapper. The texture pool is destroyed when TextureMapper is
destroyed. It means the texture pool consumes texture memory until its
destruction. This patch removes textures if the textures have been not
used in 3 seconds as LayerTreeCoordinator manages UpdateAtlases.

Changing cache policy is not testable in layout tests.

  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore::BitmapTexturePoolEntry::BitmapTexturePoolEntry):
(WebCore::BitmapTexturePoolEntry::markUsed):
(WebCore::BitmapTexturePoolEntry::compareTimeLastUsed):
(BitmapTexturePoolEntry):
(WebCore):
(BitmapTexturePool):
(WebCore::BitmapTexturePool::BitmapTexturePool):
(WebCore::BitmapTexturePool::scheduleReleaseUnusedTextures):
(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):
(WebCore::BitmapTexturePool::acquireTexture):
(WebCore::TextureMapper::acquireTextureFromPool):
(WebCore::TextureMapper::TextureMapper):
(WebCore::TextureMapper::~TextureMapper):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore):
(TextureMapper):

6:45 AM Changeset in webkit [133600] by loislo@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Web Inspector: NMI instrument CachedMetadata. It uses ~300k on plus.google.com
https://bugs.webkit.org/show_bug.cgi?id=101067

Reviewed by Yury Semikhatsky.

Plain vanilla instrumentation for CachedMetadata class.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachedMetadata.cpp: Added.

(WebCore):
(WebCore::CachedMetadata::reportMemoryUsage):

  • loader/CachedMetadata.h:

(CachedMetadata):

6:40 AM Changeset in webkit [133599] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebKit2

[CoordinatedGraphics] Access to LayerTreeRenderer::m_renderQueue should be thread safe
https://bugs.webkit.org/show_bug.cgi?id=101341

Reviewed by Noam Rosenthal.

The queue can be accessed from public API so we should make
sure it is not updated concurrently with a threaded render loop.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::syncRemoteContent):
(WebKit::LayerTreeRenderer::appendUpdate):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

6:18 AM Changeset in webkit [133598] by senorblanco@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed unskip passing tests.

Patch by Vsevolod Vlasov <vsevik@chromium.org> on 2012-11-06

  • platform/qt-arm/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
6:15 AM Changeset in webkit [133597] by rakuco@webkit.org
  • 3 edits in trunk/Tools

[EFL][WTR] EventSender: Get rid of the WTRMouseButton enum.
https://bugs.webkit.org/show_bug.cgi?id=101340

Reviewed by Kenneth Rohde Christiansen.

Get rid of an enum which was basically a duplicate of the
WKEventMouseButton one in the shared API.

The only difference is that it also had a case for a 4th mouse
button that we treat in a special way in evasMouseButton() now.

  • WebKitTestRunner/EventSenderProxy.h:

(EventSenderProxy):

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::evasMouseButton):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::leapForward):

6:13 AM Changeset in webkit [133596] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed unskip passing tests.

  • platform/qt-arm/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
6:08 AM Changeset in webkit [133595] by vsevik@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

Web Inspector: Flakyness in http/tests/inspector/network/network-initiator-from-console.html
https://bugs.webkit.org/show_bug.cgi?id=101195

Unreviewed test flakiness fix.

  • http/tests/inspector/network/network-initiator-from-console-expected.txt:
  • http/tests/inspector/network/network-initiator-from-console.html:
  • http/tests/inspector/network/resources/silent_script.js: Added.

(foo):

6:07 AM Changeset in webkit [133594] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
6:05 AM Changeset in webkit [133593] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: report physical memory really committed for JS heap in NMI
https://bugs.webkit.org/show_bug.cgi?id=101335

Some OSes (e.g. Linux) perform lazy commits of requested memory.
Because of that the committed memory may not retain any physical
memory until the very first access to the committed chunk.
That led to JS heap reported more physical memory than was currently
in use.

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-06
Reviewed by Vsevolod Vlasov.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::ScriptGCEvent::getHeapSize):

5:57 AM Changeset in webkit [133592] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Breakpoint is not removed when it was set in non-formatted mode and then removed while in formatted mode.
https://bugs.webkit.org/show_bug.cgi?id=100595

Reviewed by Yury Semikhatsky.

Source/WebCore:

Breakpoints in storage are now updated/removed by file name saved from primary location when they were created,
not by the name returned by UISourceCode (as this one could change when UISourceCode is formatted).
SourceFileId is now used across BreakpointManager to specify file name.
And breakpointStorageId is now used to specify (fileName, lineNumber) pair.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.sourceFileId):
(WebInspector.BreakpointManager.prototype._restoreBreakpoints):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved): Removed redundant check.
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.Breakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype._breakpointStorageId):
(WebInspector.BreakpointManager.Storage.prototype._restoreBreakpoints):
(set WebInspector.BreakpointManager.Storage.Item):

LayoutTests:

  • inspector/debugger/script-formatter-breakpoints-expected.txt:
  • inspector/debugger/script-formatter-breakpoints.html:
5:55 AM Changeset in webkit [133591] by alexis@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add an extra test for background-position parsing.
https://bugs.webkit.org/show_bug.cgi?id=101245

Reviewed by Eric Seidel.

This test may overlap some existing tests but they are usually
old tests where the parsing is tested but mixed with the rendering
verification, therefore it is not ideal to add new parsing tests.
This will be useful for the upcoming support of background-position with 4
values as this test will be extended to verify the parsing and later another
test/patch will be added to check/support the rendering.

  • fast/backgrounds/background-position-parsing-2-expected.txt: Added.
  • fast/backgrounds/background-position-parsing-2.html: Added.
5:24 AM Changeset in webkit [133590] by keishi@webkit.org
  • 5 edits in trunk

The "Rect" class in WebCore/Resources/pagepopups/pickerCommon.js should be renamed
https://bugs.webkit.org/show_bug.cgi?id=101304

Reviewed by Kent Tamura.

Source/WebCore:

The name Rect conflicts with CSS Rect.

No new tests. Just renaming.

  • Resources/pagepopups/pickerCommon.js:

(Rectangle): Renamed from Rect.
(Rectangle.prototype.toString):
(Rectangle.intersection):
(adjustWindowRect):
(hideWindow):

LayoutTests:

  • platform/chromium/fast/forms/page-popup/page-popup-adjust-rect-expected.txt: Replace Rect with Rectangle.
  • platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html: Ditto.
5:20 AM Changeset in webkit [133589] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Replace setDOMWrapper(wrapper, 0) with resetDOMWrapper(wrapper)
https://bugs.webkit.org/show_bug.cgi?id=101190

Reviewed by Adam Barth.

To guarantee that we never stores NULL pointers to V8 internal
fields, we want to insert ASSERT()s to setDOMWrapper().
This patch replaces setDOMWrapper() that intentionally
passes NULL pointers with clearDOMWrapper().

No tests. No change in behavior.

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::clearDOMWrapper):

  • bindings/v8/V8NPObject.cpp:

(WebCore::forgetV8ObjectForNPObject):

4:56 AM Changeset in webkit [133588] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Exclude fast/css/style-scoped cases from layout test running
https://bugs.webkit.org/show_bug.cgi?id=101326

Unreviewed, EFL gardening.

According to BUG 49142, html5 style scoped attribute implementation is on progress.
Therefore, we can skip its test cases from regular layout test running.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-06

  • platform/efl/TestExpectations:
4:35 AM Changeset in webkit [133587] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebKit2

[EFL][WK2] Make Ewk_Context Ewk_Object
https://bugs.webkit.org/show_bug.cgi?id=101322

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-06
Reviewed by Kenneth Rohde Christiansen.

Ewk_Context is Ewk_Object now and using common ref/unref API.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl::ewkContext):
(EwkViewImpl):

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):
(EwkContext::~EwkContext):
(EwkContext::create):
(EwkContext::defaultContext):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::faviconDatabase):
(EwkContext::storageManager):
(EwkContext::requestManager):
(EwkContext::vibrationProvider):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):
(ewk_context_cookie_manager_get):
(ewk_context_favicon_database_directory_set):
(ewk_context_favicon_database_get):
(ewk_context_storage_manager_get):
(EwkContext::wkContext):
(EwkContext::downloadManager):
(EwkContext::historyClient):
(ewk_context_default_get):
(ewk_context_new):
(ewk_context_new_with_injected_bundle_path):
(ewk_context_url_scheme_register):
(ewk_context_vibration_client_callbacks_set):
(ewk_context_history_callbacks_set):
(ewk_context_visited_link_add):
(ewk_context_cache_model_set):
(ewk_context_cache_model_get):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext):

  • UIProcess/API/efl/ewk_view.cpp:

(createEwkView):
(ewk_view_base_add):
(ewk_view_smart_add):
(ewk_view_add_with_context):

  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::DownloadManagerEfl):

  • UIProcess/efl/DownloadManagerEfl.h:

(WebKit::DownloadManagerEfl::create):
(DownloadManagerEfl):

  • UIProcess/efl/PageClientBase.cpp:

(WebKit::PageClientBase::handleDownloadRequest):

  • UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):

  • UIProcess/efl/RequestManagerClientEfl.h:

(WebKit::RequestManagerClientEfl::create):
(RequestManagerClientEfl):

4:33 AM Changeset in webkit [133586] by peter@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] There shouldn't be linting errors about our TestExpectation files

Unreviewed test expectation update.

A number of linting errors were being displayed, partially because of my
recent additions. Fix them.

  • platform/chromium-android/TestExpectations:
  • platform/chromium/TestExpectations:
4:14 AM Changeset in webkit [133585] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Minibrowser forgets http variables when url includes ampersand
https://bugs.webkit.org/show_bug.cgi?id=101061

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-06
Reviewed by Kenneth Rohde Christiansen.

Elementary entry only returns 'markup' text, meaning ampersands
in a url will become "&amp;". Use elm_entry_markup_to_utf8() and
elm_entry_utf8_to_markup() when interacting with the entry.

  • MiniBrowser/efl/main.c:

(on_url_changed):
(on_url_bar_activated):

4:09 AM Changeset in webkit [133584] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Disable all tests fast/dom/shadow
https://bugs.webkit.org/show_bug.cgi?id=101324

Patch by Shinya Kawanaka <shinyak@chromium.org> on 2012-11-06
Reviewed by Csaba Osztrogonác.

Since Qt does not have SHADOW_DOM flag enabled, a lot of tests are failing.
Let's skip all tests.

  • platform/qt/TestExpectations:
4:07 AM Changeset in webkit [133583] by vsevik@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: Displayed name/path of urls in network tab of dev tools is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=101064

Reviewed by Yury Semikhatsky.

Source/WebCore:

Extracted some generic methods from ParsedURL displayName getters (about:blank and data url handlers).
Implemented consistent name() and path() method on NetworkRequest based on ParsedURL.
NetworkPanel now uses name() and path() methods on NetworkRequest to show requests and search for them.

Test: http/tests/inspector/network/request-name-path.html

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._matchRequest):
(WebInspector.NetworkLogView.prototype._highlightMatchedRequests):
(WebInspector.NetworkLogView.prototype.performFilter):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
(WebInspector.NetworkDataGridNode.NameComparator):

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.set url):
(WebInspector.NetworkRequest.prototype.name):
(WebInspector.NetworkRequest.prototype.path):
(WebInspector.NetworkRequest.prototype._parseNameAndPathFromURL):

  • inspector/front-end/ParsedURL.js:

(WebInspector.ParsedURL):
(WebInspector.ParsedURL.prototype.get displayName):
(WebInspector.ParsedURL.prototype.dataURLDisplayName):
(WebInspector.ParsedURL.prototype.isAboutBlank):
(WebInspector.ParsedURL.prototype.isDataURL):

LayoutTests:

  • http/tests/inspector/network/request-name-path-expected.txt: Added.
  • http/tests/inspector/network/request-name-path.html: Added.
4:00 AM Changeset in webkit [133582] by pfeldman@chromium.org
  • 12 edits
    1 add in trunk/Source/WebCore

Web Inspector: make Spectrum and Popover WebInspector.Views in order to enable reuse
https://bugs.webkit.org/show_bug.cgi?id=101200

Reviewed by Yury Semikhatsky.

  • Split Spectrum and SpectrumPopoverHelper (first is a component, second is controller)
  • Made Popover a root view in order to enable lazy style loading for potential subviews (such as Spectrum)
  • Extracted spectrum's css into a separate file
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DOMExtension.js:

(Element.prototype.positionAt):
(Size):
(Element.prototype.measurePreferredSize):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype.willHide):
(WebInspector.HeapSnapshotView.prototype._helpClicked):

  • inspector/front-end/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.Popover.prototype.showView):
(WebInspector.Popover.prototype._innerShow):
(WebInspector.Popover.prototype.hide):
(WebInspector.Popover.prototype.dispose):
(WebInspector.Popover.prototype._positionElement):

  • inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.alphaDrag):
(WebInspector.Spectrum):
(WebInspector.Spectrum.prototype.wasShown):
(WebInspector.SpectrumPopupHelper):
(WebInspector.SpectrumPopupHelper.prototype.spectrum):
(WebInspector.SpectrumPopupHelper.prototype.toggle):
(WebInspector.SpectrumPopupHelper.prototype.show):
(WebInspector.SpectrumPopupHelper.prototype.reposition):
(WebInspector.SpectrumPopupHelper.prototype.hide):
(WebInspector.ColorSwatch):
(WebInspector.ColorSwatch.prototype.setColorString):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype.willHide):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

  • inspector/front-end/View.js:

(WebInspector.View.prototype.measurePreferredSize):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/elementsPanel.css:

(.image-preview-container img):

  • inspector/front-end/inspector.css:

(.swatch):
(.swatch-inner):
(.swatch-inner:hover):

  • inspector/front-end/spectrum.css: Added.

(.spectrum-container):
(.spectrum-top):
(.spectrum-color):
(.spectrum-display-value):
(.spectrum-hue):
(.spectrum-fill):
(.spectrum-range-container):
(.spectrum-range-container *):
(.spectrum-range-container label):
(.spectrum-range-container input):
(.spectrum-dragger, .spectrum-slider):
(.spectrum-sat):
(.spectrum-val):
(.spectrum-dragger):
(.spectrum-slider):
(.spectrum-container .swatch):

3:33 AM Changeset in webkit [133581] by tasak@google.com
  • 7 edits
    2 adds in trunk

removeAttribute('style') not working in certain circumstances
https://bugs.webkit.org/show_bug.cgi?id=99295

Reviewed by Ryosuke Niwa.

Source/WebCore:

After web developers did style.XXXX=YYYY for some element, the inline
style should be always removable by using "removeAttribute('style')".
Currently it depends on whether web developers invokes
getAttribute('style'), setAttribute('style), and so on. E.g. once they
invoke getAttribute('style'), removeAttribute('style') works. This is
very confusing behavior.
Looking at Firefox browser, removeAttribute('style') always removes
all inline styles.

Test: fast/css/remove-attribute-style.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::clear):
Added a new method to remove all style properties.
(WebCore):

  • css/StylePropertySet.h:

(StylePropertySet):

  • dom/Element.cpp:

(WebCore::Element::removeAttribute):
If 'style' is given but the element has no style attribute, the old
code did nothing. However, if the element is styled element and has any
inline styles, the inline styles should be removed. So invoke
StyledElement::removeAllInlineStyleProperties and if any inline styles
are removed, invoke style recalc, too.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::removeAllInlineStyleProperties):
Added a new method to remove all inline style propeties. If any inline
style is removed, invoke inlineStyleChanged() to force style recalc.
(WebCore):

  • dom/StyledElement.h:

(StyledElement):

LayoutTests:

  • fast/css/remove-attribute-style-expected.txt: Added.
  • fast/css/remove-attribute-style.html: Added.
3:17 AM Changeset in webkit [133580] by peter@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium-Android] Skip a number of crashing tests.

Unreviewed rebaselining.

  • platform/chromium/TestExpectations:
2:49 AM Changeset in webkit [133579] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: dim size bar for expanded item in native memory snapshot grid
https://bugs.webkit.org/show_bug.cgi?id=101062

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-06
Reviewed by Yury Semikhatsky.

  • inspector/front-end/nativeMemoryProfiler.css:

(.native-snapshot-view .data-grid .expanded div.size-bar):

2:46 AM Changeset in webkit [133578] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CoordinatedGraphics] compositing/iframes/connect-compositing-iframe.html crashes
https://bugs.webkit.org/show_bug.cgi?id=101232

Reviewed by Jocelyn Turcotte.

The crash is happening in CoordinatedGraphicsLayer::flushCompositingState
because we dereferencing a null m_coordinatedGraphicsLayerClient.
This happens when the root layer became composited because it has content overlapping
with an inner iframe that is composited. In this case the RenderLayerCompositor attaches
the layer with RootLayerAttachedViaEnclosingFrame attachment flag and do not call
ChromeClient::attachRootGraphcisLayer so we don't have a chance to set m_coordinatedGraphicsLayerClient.
The solution is to set the client early in the factory method.

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::createGraphicsLayer):

2:43 AM Changeset in webkit [133577] by shinyak@chromium.org
  • 14 edits
    2 adds in trunk

[Shadow] Using isUnknownPseudoElement() for shadow pseudo id seems confusing
https://bugs.webkit.org/show_bug.cgi?id=100826

Reviewed by Hajime Morita.

Source/WebCore:

We used isUnknownPseudoElement() for these 3 meanings: 1) the element is a custom pseudo-element (starting with 'x-'),
2) the element is a webkit custom pseudo-element (starting with '-webkit-'), and 3) the element has an unknown type.
We would like to distinguish them when parsing CSSSelector types. Also, we disable using (3) type for using
shadowPseudoId.

In this patch, we allow using WebKitCustomPseudoElement in AuthorShadowRoot, and CustomPseudoElement in
UAShadowRoot. However, we will disable them later.

Test: fast/dom/shadow/shadow-pseudo-id.html

  • css/CSSGrammar.y.in: Now we can discard UNKNOWN type. It should not match anything.
  • css/CSSParser.cpp:

(WebCore::CSSParser::updateSpecifiersWithElementName):
(WebCore::CSSParser::updateSpecifiers):

  • css/CSSParserValues.h:

(WebCore::CSSParserSelector::isCustomPseudoElement):
(CSSParserSelector):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::parsePseudoType):
(WebCore::CSSSelector::isCustomPseudoType): Returns true if the type is PseudoUserAgentCustomElement or PseudoWebKitCustomElement.
(WebCore::CSSSelector::extractPseudoType):

  • css/CSSSelector.h:

(CSSSelector):
(WebCore::CSSSelector::isCustomPseudoElement):
(WebCore):

  • css/CSSSelectorList.cpp:

(WebCore::SelectorHasInvalidSelectorFunctor::operator()): We will reject all selectors which were judged as
UNKNOWN before. i.e. It contians all three types for now.
(WebCore::CSSSelectorList::hasInvalidSelector): Renamed.

  • css/CSSSelectorList.h:

(CSSSelectorList):

  • css/RuleSet.cpp:

(WebCore::RuleSet::addRule):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

  • dom/Element.cpp:

(WebCore::Element::setShadowPseudoId):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCache::add):

LayoutTests:

  • fast/dom/shadow/shadow-nested-pseudo-id.html: Fixed a testcase so that shadowPseudoId starts with 'x-'.
  • fast/dom/shadow/shadow-pseudo-id-expected.html: Added.
  • fast/dom/shadow/shadow-pseudo-id.html: Added.
2:26 AM Changeset in webkit [133576] by Csaba Osztrogonác
  • 2 edits in trunk/Websites/bugs.webkit.org

committers-autocomplete.js works only with WebKit based browsers
https://bugs.webkit.org/show_bug.cgi?id=66752

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2012-11-06
Reviewed by Csaba Osztrogonác.

Based on the patch posted by Peter Gal. Attach event listeners
to all input elements we want to enable auto-completions on.

  • committers-autocomplete.js:
2:15 AM Changeset in webkit [133575] by shinyak@chromium.org
  • 7 edits
    2 adds in trunk

[Shadow] ShadowRoot should know the existence of elements having ElementShadow.
https://bugs.webkit.org/show_bug.cgi?id=100922

Reviewed by Hajime Morita.

Source/WebCore:

We count the elements having ElementShadow in ShadowRoot. This is a prepation patch for to solve Bug 100451.
We have a count-up and count-down login in ShadowRoot::insertedInto and ShadowRoot::removedFrom.

For performance reason, we have a flag that an element should be unregistered in ShadowRoot.

Test: fast/dom/shadow/has-elementshadow.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::insertedInto): Count up the number of elements having ElementShadow. ElementShadow
is created only when the oldest ShadowRoot is created, we only count up only when this ShadowRoot is oldest.
(WebCore):
(WebCore::ShadowRoot::removedFrom): Count down if we used this ShadowRoot for count up.

  • dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::ShadowRoot::registerElementShadow):
(WebCore::ShadowRoot::unregisterElementShadow):
(WebCore::ShadowRoot::hasElementShadow):
(WebCore::ShadowRoot::countElementShadow):

  • testing/Internals.cpp:

(WebCore::Internals::countElementShadow):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

  • fast/dom/shadow/has-elementshadow-expected.txt: Added.
  • fast/dom/shadow/has-elementshadow.html: Added.
2:12 AM Changeset in webkit [133574] by kbalazs@webkit.org
  • 11 edits in trunk/Tools

DumpRenderTree should have --pixel-tests option again
https://bugs.webkit.org/show_bug.cgi?id=98648

Reviewed by Dirk Pranke.

Add back the --pixel-tests command line option to DumpRenderTree.
It was removed r124581 because tools don't use it after that patch.
However, it turned out that it is useful for debugging and working
with pixel tests.

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(parseCommandLineOptions):
(runTest):

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeGlobalsFromCommandLineOptions):
(runTest):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(initializeGlobalsFromCommandLineOptions):
(runTest):

  • DumpRenderTree/qt/DumpRenderTreeMain.cpp:

(isOption):
(printUsage):
(main):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::processLine):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(WebCore::DumpRenderTree::setShouldDumpPixelsForAllTests):
(DumpRenderTree):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(runTest):
(dllLauncherEntryPoint):

  • DumpRenderTree/wx/DumpRenderTreeWx.cpp:

(runTest):
(MyApp::OnInit):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):

  • WebKitTestRunner/TestController.h:

(TestController):

2:06 AM Changeset in webkit [133573] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: show "debugging session terminated" message when remote debuggign connection is closed unexpectedly.
https://bugs.webkit.org/show_bug.cgi?id=101030

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/inspector.js:

(WebInspector.loaded.WebInspector.socket.onclose):
(WebInspector.loaded):
(WebInspector.detached):

2:04 AM Changeset in webkit [133572] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Overrides] Add Chrome for Android and Firefox for Android user agent strings
https://bugs.webkit.org/show_bug.cgi?id=100666

Reviewed by Pavel Feldman.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.get const):

1:49 AM Changeset in webkit [133571] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[QT] [GTK] Remove fast/forms/week-multiple-fields from TestExpectations of gtk and qt.
https://bugs.webkit.org/show_bug.cgi?id=101317

Unreviewed gardening.

fast/forms/week-multiple-fields is removed by http://trac.webkit.org/changeset/133440.

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-11-06

  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
1:34 AM Changeset in webkit [133570] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] [WK2] Random crash in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=101241

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-06
Reviewed by Gyuyoung Kim.

Do not clear GL context and GL surface in exitAcceleratedCompositing.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::exitAcceleratedCompositingMode):

12:49 AM Changeset in webkit [133569] by yurys@chromium.org
  • 9 edits
    2 adds in trunk

Web Inspector: JavaScript web workers debugging crashes
https://bugs.webkit.org/show_bug.cgi?id=101065

Reviewed by Alexander Pavlov.

Source/WebCore:

Clear m_pageInspector when page inspector instance is deleted.
Disable worker inspection when front-end disconnects.

Test: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): notify
WorkerMessagingProxy so that it can clear pointer to the channel.

LayoutTests:

Test that inspected page won't crash if inspected worker is terminated when it is paused
on a breakpoint.

  • inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt: Added.
  • inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
12:02 AM Changeset in webkit [133568] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Console: wrap long URLs
https://bugs.webkit.org/show_bug.cgi?id=100970

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-06
Reviewed by Yury Semikhatsky.

  • inspector/front-end/inspector.css:

(.console-message-url):

Nov 5, 2012:

11:47 PM Changeset in webkit [133567] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG should not fall down to patchable GetById just because a prototype had things added to it
https://bugs.webkit.org/show_bug.cgi?id=101299

Reviewed by Geoffrey Garen.

This looks like a slight win on V8v7 and SunSpider.

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:44 PM Changeset in webkit [133566] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkit-patch rebaseline*: fix typo for --results-directory
https://bugs.webkit.org/show_bug.cgi?id=101295

Reviewed by Ojan Vafai.

Had --results_directory instead of --results-directory in both the
code and the unit test.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractParallelRebaselineCommand._rebaseline_commands):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineJson.test_results_directory):

11:18 PM Changeset in webkit [133565] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Introduce Day class to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101194

Reviewed by Kent Tamura.

Introducing Day class so day, week, and month can all be abstracted. To
solve some of the complexity around which months to show, I made
CalendarPicker in charge of it. This also made YearMonthController and
DaysTable independent of each other.

No new tests. Covered by existing calendar-picker-*.html tests.

  • Resources/pagepopups/calendarPicker.js:

(createUTCDate): Allow negative month or date.
(parseDateString): Will return Day or Month depending on string format.
(Day): Represents a day.
(Day.parse): Parse yyyy-mm-dd.
(Day.createFromDate): Creates a Day that contains a datetime.
(Day.createFromToday): Creates Day for today. A method with the same name will be added to Week and Month in the future.
(Day.prototype.equals): Returns true if they are the same.
(Day.prototype.previous): Returns the previous day.
(Day.prototype.next): Returns the next day.
(Day.prototype.startDate): Returns the datetime that is the start of this day.
(Day.prototype.endDate): Returns the datetime that is the start of this day.
(Day.prototype.valueOf): Returns the milliseconds since epoch.
(Day.prototype.toString): Returns an ISO date string.
(Month): Fix bug in calculating month from value.
(Month.prototype.endDate): Use Day.Maximum.
(CalendarPicker): Added _currentMonth. yearMonthController and daysTable can be private members now.
(CalendarPicker.prototype._layout):
(CalendarPicker.prototype.handleToday): Use Day.createFromToday.
(CalendarPicker.prototype.shouldShowMonth): Returns true if the month should be shown.
(CalendarPicker.prototype.showMonth): Shows the given month. If the month is out of the range of months that should be shown, we clamp the month and show that.
(CalendarPicker.prototype.currentMonth): Returns the current month that is shown.
(YearMonthController): Removed _currentMonth.
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype.setMonth):
(YearMonthController.prototype._handleYearMonthChange): Use CalendarPicker.showMonth
(YearMonthController.prototype.moveRelatively):
(DaysTable):
(CalendarPicker.prototype._stepMismatch): Made private.
(CalendarPicker.prototype._outOfRange): Made private.
(CalendarPicker.prototype.isValidDate): Take Day or Month instead of milliseconds since epoch.
(DaysTable.prototype._renderMonth):
(DaysTable.prototype.navigateToMonth): Shows a given month. Can use animation and leave the selection position as is.
(DaysTable.prototype.selectRange): Select a range.
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):

11:16 PM Changeset in webkit [133564] by fpizlo@apple.com
  • 22 edits
    4 deletes in trunk/Source/JavaScriptCore

Get rid of method_check
https://bugs.webkit.org/show_bug.cgi?id=101147

Reviewed by Geoffrey Garen.

op_method_check no longer buys us anything, since get_by_id proto caching
gives just as much profiling information and the DFG inlines monomorphic
proto accesses anyway.

This also has the potential for a speed-up since it makes parsing of
profiling data easier. No longer do we have to deal with the confusion of
the get_by_id portion of a method_check appearing monomorphic even though
we're really dealing with a bimorphic access (method_check specializes for
one case and get_by_id for another).

This looks like a 1% speed-up on both SunSpider and V8v7.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::unlinkCalls):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::callLinkInfo):
(CodeBlock):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):

  • bytecode/MethodCallLinkInfo.cpp: Removed.
  • bytecode/MethodCallLinkInfo.h: Removed.
  • bytecode/MethodCallLinkStatus.cpp: Removed.
  • bytecode/MethodCallLinkStatus.h: Removed.
  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallDotNode::emitBytecode):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::PropertyStubCompilationInfo::slowCaseInfo):
(PropertyStubCompilationInfo):
(JSC):
(JIT):

  • jit/JITPropertyAccess.cpp:

(JSC):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::compileGetByIdSlowCase):

  • jit/JITPropertyAccess32_64.cpp:

(JSC):
(JSC::JIT::compileGetByIdSlowCase):

  • jit/JITStubs.cpp:

(JSC):

  • jit/JITStubs.h:
  • llint/LowLevelInterpreter.asm:
10:43 PM Changeset in webkit [133563] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, Adding #if PLATFORM(CHROMIUM) for the fix of
https://bugs.webkit.org/show_bug.cgi?id=101009

This fix requires the most recent version of harfbuzz-ng.
EFL port uses version 0.9.2, which doesn't have the fix.

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

10:41 PM Changeset in webkit [133562] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Ensure acquireLineBreakIterator signature consistency on non-ICU ports.
https://bugs.webkit.org/show_bug.cgi?id=101281

Patch by Glenn Adams <glenn@skynav.com> on 2012-11-05
Reviewed by Ryosuke Niwa.

Fix (newly) inconsistent signature for acquireLineBreakIterator for non-ICU ports
caused by http://trac.webkit.org/changeset/133529.

See new tests added from https://bugs.webkit.org/show_bug.cgi?id=89235.

  • platform/text/TextBreakIterator.cpp:

(WebCore::acquireLineBreakIterator):

  • platform/text/gtk/TextBreakIteratorGtk.cpp:

(WebCore::setUpIterator):
(WebCore::acquireLineBreakIterator):

  • platform/text/wince/TextBreakIteratorWinCE.cpp:

(WebCore::acquireLineBreakIterator):

10:25 PM Changeset in webkit [133561] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Use switch/case statements instead of if/elseif in CSSSelector.cpp
https://bugs.webkit.org/show_bug.cgi?id=100470

Reviewed by Ryosuke Niwa.

Minor clean up. We can get compiler warnings if we use switch/case statements here.

No changes to functionality, so no new tests.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

10:24 PM Changeset in webkit [133560] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening, skip new failing tests.

  • platform/qt/TestExpectations:
10:11 PM BuildingGtk edited by halton.huo@gmail.com
(diff)
10:06 PM Changeset in webkit [133559] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkit-patch rebaseline*: fix handling of local file urls
https://bugs.webkit.org/show_bug.cgi?id=101296

Reviewed by Ojan Vafai.

When using --results-directory, we need to make sure we're converting
paths to file:/// urls for urllib to work correctly. Also, this
patch reworks the unit tests to get better coverage (of the execute()
command) and reduce copy/pasting of mock options.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.setUp):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test_with_results_directory):
(test_rebaseline_test_internal_with_move_overwritten_baselines_to):

9:52 PM Changeset in webkit [133558] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

Need a way to send and receive messages between the WKWebProcessPlugIn object and the client
https://bugs.webkit.org/show_bug.cgi?id=101282

Reviewed by Anders Carlsson.

API wise, this adds:

  • A connection property on the WKWebProcessPlugInController
  • A method to send messages across a WKConnection (sendMessageWithName:body).

It also implements message sending and receiving for WKConnection. Message bodies are currently
restricted to being object graphs with values that are property list types, but in the future, should
support all types conforming to the NSSecureCoding protocol.

  • Shared/WebConnection.cpp:

(WebKit::WebConnection::postMessage):
(WebKit::WebConnection::handleMessage):

  • Shared/WebConnection.h:

(WebConnection):

  • Shared/WebConnection.messages.in:

Switch HandleMessage to be a variadic message to avoid an extra copy and support attachments correctly.

  • Shared/mac/ArgumentCodersMac.h:
  • Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::typeFromObject):
(CoreIPC::encode):
(CoreIPC::decode):
Add support for encoding/decoding NSArray, NSDate and NSData.

  • UIProcess/API/mac/WKConnection.h:
  • UIProcess/API/mac/WKConnection.mm:

(-[WKConnection sendMessageWithName:body:]):
(didReceiveMessage):
Implement message sending and receiving.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

(-[WKWebProcessPlugInController _initWithPrincipalClassInstance:bundleRef:]):
(-[WKWebProcessPlugInController connection]):
Add a wrapper for the WKConnectionRef vended via WKBundleGetApplicationConnection() and expose it as
API on the WKWebProcessPlugInController.

9:04 PM Changeset in webkit [133557] by Dave Barton
  • 19 edits
    170 adds
    12 deletes in trunk/LayoutTests

Unreviewed gardening. Updating MathML chromium baselines.

  • platform/chromium-linux-x86/mathml/presentation: Added.
  • platform/chromium-linux-x86/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/attributes-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/fenced-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/fenced-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/fractions-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/mo-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/mroot-pref-width-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/over-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/over-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/roots-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/row-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/row-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/style-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/style-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/sub-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/sup-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/tables-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/tokenElements-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/under-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/under-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-linux-x86/mathml/presentation/underover-expected.txt: Added.
  • platform/chromium-linux-x86/mathml/xHeight-expected.txt:
  • platform/chromium-linux/mathml/presentation: Added.
  • platform/chromium-linux/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/attributes-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/fenced-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/fenced-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/fractions-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/mo-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/mroot-pref-width-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/over-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/over-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/roots-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/row-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/row-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/style-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/style-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/sub-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/sup-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/tables-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/tokenElements-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/under-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/under-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-linux/mathml/presentation/underover-expected.txt: Added.
  • platform/chromium-linux/mathml/xHeight-expected.txt:
  • platform/chromium-mac-lion/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/chromium-mac-lion/mathml/presentation/row-alignment-expected.png:
  • platform/chromium-mac-lion/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/chromium-mac-lion/mathml/presentation/subsup-expected.png:
  • platform/chromium-mac-lion/mathml/presentation/subsup-expected.txt:
  • platform/chromium-mac-lion/mathml/presentation/tables-expected.png:
  • platform/chromium-mac-lion/mathml/presentation/tables-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-stretch-expected.txt:
  • platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.png:
  • platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.txt:
  • platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.png:
  • platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.txt:
  • platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.png:
  • platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.txt:
  • platform/chromium-mac/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/chromium-mac/mathml/presentation/row-alignment-expected.png:
  • platform/chromium-mac/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/chromium-mac/mathml/presentation/subsup-expected.png:
  • platform/chromium-mac/mathml/presentation/subsup-expected.txt:
  • platform/chromium-mac/mathml/presentation/tables-expected.png:
  • platform/chromium-mac/mathml/presentation/tables-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation: Added.
  • platform/chromium-win-xp/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/attributes-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/fenced-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/fenced-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/fractions-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/mo-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/mroot-pref-width-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/over-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/over-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/roots-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/row-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/row-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/style-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/style-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/sub-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/sup-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/tables-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/tokenElements-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/under-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/under-expected.txt: Added.
  • platform/chromium-win-xp/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-win-xp/mathml/presentation/underover-expected.txt: Added.
  • platform/chromium-win/mathml/presentation: Added.
  • platform/chromium-win/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-win/mathml/presentation/attributes-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/fenced-expected.png: Added.
  • platform/chromium-win/mathml/presentation/fenced-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-win/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-win/mathml/presentation/fractions-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-win/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-win/mathml/presentation/mo-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-win/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-win/mathml/presentation/mroot-pref-width-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/over-expected.png: Added.
  • platform/chromium-win/mathml/presentation/over-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-win/mathml/presentation/roots-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-win/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/row-expected.png: Added.
  • platform/chromium-win/mathml/presentation/row-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/style-expected.png: Added.
  • platform/chromium-win/mathml/presentation/style-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-win/mathml/presentation/sub-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-win/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-win/mathml/presentation/sup-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-win/mathml/presentation/tables-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-win/mathml/presentation/tokenElements-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/under-expected.png: Added.
  • platform/chromium-win/mathml/presentation/under-expected.txt: Added.
  • platform/chromium-win/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-win/mathml/presentation/underover-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/mathml/presentation/attributes-expected.png: Removed.
  • platform/chromium/mathml/presentation/fractions-expected.png: Removed.
  • platform/chromium/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
  • platform/chromium/mathml/presentation/mo-expected.png: Removed.
  • platform/chromium/mathml/presentation/mo-stretch-expected.png: Removed.
  • platform/chromium/mathml/presentation/mroot-pref-width-expected.png: Removed.
  • platform/chromium/mathml/presentation/over-expected.png: Removed.
  • platform/chromium/mathml/presentation/roots-expected.png: Removed.
  • platform/chromium/mathml/presentation/row-alignment-expected.png: Removed.
  • platform/chromium/mathml/presentation/row-expected.png: Removed.
  • platform/chromium/mathml/presentation/style-expected.png: Removed.
  • platform/chromium/mathml/presentation/subsup-expected.png: Removed.
8:15 PM Changeset in webkit [133556] by kbr@google.com
  • 2 edits in trunk/Tools

Added secondary email address and IRC nick.
https://bugs.webkit.org/show_bug.cgi?id=101290

Unreviewed change to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
8:08 PM Changeset in webkit [133555] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not show error page for main loads denied by client application
https://bugs.webkit.org/show_bug.cgi?id=101287

Internal PR: 237574.
Internally reviewed by Arvid Nilsson, Joe Mason.
Patch by Lianghui Chen <liachen@rim.com> on 2012-11-05
Reviewed by George Staikos.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

7:46 PM Changeset in webkit [133554] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[EFL][WK2] Fix wrong coding style in the boilerplates
https://bugs.webkit.org/show_bug.cgi?id=101283

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-05
Reviewed by Gyuyoung Kim.

Fix boilerplate which have wrong coding style.

  • UIProcess/efl/InputMethodContextEfl.cpp:
  • UIProcess/efl/InputMethodContextEfl.h:
  • UIProcess/efl/PageClientDefaultImpl.cpp:
  • UIProcess/efl/PageClientDefaultImpl.h:
  • UIProcess/efl/PageClientLegacyImpl.cpp:
  • UIProcess/efl/PageClientLegacyImpl.h:
7:46 PM Changeset in webkit [133553] by commit-queue@webkit.org
  • 1 edit
    16 adds in trunk/LayoutTests

[EFL][WK2][PixelTests] Add missing expectations
https://bugs.webkit.org/show_bug.cgi?id=101289

Unreviewed, EFL gardening.

Add 16 missing pixel test expectations.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-05

  • platform/efl/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/efl/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/efl/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/efl/fast/forms/basic-inputs-expected.png: Added.
  • platform/efl/fast/media/view-mode-media-feature-expected.png: Added.
  • platform/efl/media/video-aspect-ratio-expected.png: Added.
  • platform/efl/media/video-layer-crash-expected.png: Added.
  • platform/efl/media/video-transformed-expected.png: Added.
  • platform/efl/media/video-zoom-controls-expected.png: Added.
  • platform/efl/media/video-zoom-expected.png: Added.
  • platform/efl/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
7:37 PM Changeset in webkit [133552] by dpranke@chromium.org
  • 32 edits
    31 copies
    6 adds in trunk/LayoutTests

Unreviewed, update chromium-mac-mountainlion baselines for svg failures after r133538

  • platform/chromium-mac-lion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png.
  • platform/chromium-mac-lion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png.
  • platform/chromium-mac-lion/svg/batik/filters/filterRegions-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/filters/filterRegions-expected.png.
  • platform/chromium-mac-lion/svg/batik/masking/maskRegions-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/masking/maskRegions-expected.png.
  • platform/chromium-mac-lion/svg/batik/paints/gradientLimit-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png.
  • platform/chromium-mac-lion/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png.
  • platform/chromium-mac-lion/svg/batik/paints/patternRegionA-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png.
  • platform/chromium-mac-lion/svg/batik/paints/patternRegions-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternRegions-expected.png.
  • platform/chromium-mac-lion/svg/batik/paints/patternRegions-positioned-objects-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/longTextOnPath-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/longTextOnPath-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/smallFonts-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/smallFonts-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textAnchor-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textAnchor-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textDecoration-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textDecoration-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textEffect-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textEffect-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textEffect2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textEffect2-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textEffect3-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textEffect3-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textFeatures-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textFeatures-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textLayout-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLayout-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textLayout2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLayout2-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textLength-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLength-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textOnPath-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textOnPath-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textOnPathSpaces-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textPosition-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textPosition-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textPosition2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textPosition2-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textProperties-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textProperties-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textProperties2-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textProperties2-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/textStyles-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textStyles-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/verticalText-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/verticalText-expected.png.
  • platform/chromium-mac-lion/svg/batik/text/verticalTextOnPath-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png.
  • platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac/svg/batik/text/textLength-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-mac/svg/batik/text/textPosition-expected.png:
  • platform/chromium-mac/svg/batik/text/textPosition2-expected.png:
  • platform/chromium-mac/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac/svg/batik/text/verticalText-expected.png:
  • platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
7:12 PM Changeset in webkit [133551] by yuqiang.xian@intel.com
  • 8 edits in trunk/Source/JavaScriptCore

Refactor LLInt64 to distinguish the pointer operations from the 64-bit integer operations
https://bugs.webkit.org/show_bug.cgi?id=100321

Reviewed by Filip Pizlo.

We have refactored the MacroAssembler and JIT compilers to distinguish
the pointer operations from the 64-bit integer operations (see bug #99154).
Now we want to do the similar work for LLInt, and the goal is same as
the one mentioned in 99154.

This is the second part of the modification: in the low level interpreter,
changing the operations on 64-bit integers to use the "<foo>q" instructions.
This also removes some unused/meaningless "<foo>p" instructions.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

  • llint/LowLevelInterpreter64.asm:
  • offlineasm/armv7.rb:
  • offlineasm/cloop.rb:
  • offlineasm/instructions.rb:
  • offlineasm/x86.rb:
7:04 PM Changeset in webkit [133550] by bashi@chromium.org
  • 3 edits
    2 adds in trunk

[Chromium] Unicode combining diacritical aren't always combined on Linux
https://bugs.webkit.org/show_bug.cgi?id=101009

Reviewed by Kent Tamura.

Source/WebCore:

Add a space character to harfbuzzBuffer as pre-context. This will prevent
harfbuzz from inserting dotted-circle.

Test: fast/text/international/combining-marks-position.html

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

LayoutTests:

Add a test that checks whether combining marks are combined with base characters.

  • fast/text/international/combining-marks-position-expected.txt: Added.
  • fast/text/international/combining-marks-position.html: Added.
6:46 PM BuildingGtk edited by halton.huo@gmail.com
(diff)
6:18 PM Changeset in webkit [133549] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

[l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
https://bugs.webkit.org/show_bug.cgi?id=100817

Patch by Sandeep Shedmake <sshedmak@redhat.com> on 2012-11-05
Rubber-stamped by Gustavo Noronha.

  • mr.po: updated.
6:13 PM Changeset in webkit [133548] by shinyak@chromium.org
  • 3 edits in trunk/Source/WebCore

LayoutTest fast/dom/shadow/shadowroot-type.html is failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=101201

Reviewed by Hajime Morita.

When we use a bit field for enum, Windows compiler seems returning some wrong value.
We would like to avoid using a bit field for enum value.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

  • dom/ShadowRoot.h:

(WebCore::ShadowRoot::type):
(WebCore::ShadowRoot::setType):
(ShadowRoot):

6:05 PM Changeset in webkit [133547] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

[l10n] updated id.po for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100264

Patch by Andika Triwidada <andika@gmail.com> on 2012-11-05
Rubber-stamped by Gustavo Noronha.

  • id.po: updated.
5:53 PM Changeset in webkit [133546] by fpizlo@apple.com
  • 11 edits in trunk

Prototype chain caching should check that the path from the base object to the slot base involves prototype hops only
https://bugs.webkit.org/show_bug.cgi?id=101276

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Changed normalizePrototypeChain() to report an invalid prototype chain if any object is a proxy.
This catches cases where our prototype chain checks would have been insufficient to guard against
newly introduced properties, despecialized properties, or deleted properties in the chain of
objects involved in the access.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):

  • jit/JITStubs.cpp:

(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/Operations.h:

(JSC):
(JSC::normalizePrototypeChain):

LayoutTests:

This test already covered this case, but only for method_check. Modified it to
also cover the get_by_id case.

  • fast/js/toString-and-valueOf-override-expected.txt:
  • fast/js/toString-and-valueOf-override.html:
5:48 PM Changeset in webkit [133545] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

TransformOperationInfo's constructor is really slow
https://bugs.webkit.org/show_bug.cgi?id=101143

Reviewed by Sam Weinig.

TransformOperationInfo() was slow for a few reasons:
-The function used a lot of branches. The basic assumption is that the input

is incorrect, thus every character is an opportunity to fail.

-Every branch had to be tested in order. If the name was matching the last if()

all the previous names had to be tested.

-Since equalIgnoringCase() was used in every branch, it was forcing the case folding

every time.

-When the string is 16bits, the case folding was using ICU, which was incredibly inefficient.

This can be fixed by either
1) Compute the lowercase name, then match it to a HashMap.
2) Write a tree to quickly reduce the number of branch needed.

The first solution is not viable because 16bits strings case folding
remains an important bottleneck.

Instead, the code now splits the names on simple characteristics to
match any name in a limited number of branches.

The assumption is the input is correct, so & is used instead of && to
avoid branches in favor of conditional instructions.

  • css/CSSParser.cpp:

(WebCore::TransformOperationInfo::TransformOperationInfo):

5:45 PM Changeset in webkit [133544] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

RenderGeometryMap asserts when loading http://en.softonic.com/mac
https://bugs.webkit.org/show_bug.cgi?id=101284
<rdar://problem/11540560>

Reviewed by Tim Horton.

When FrameView::layout() calls document->updateStyleIfNeeded(), we
can be in a state where FrameView::needsLayout() is false. However,
this is a bad time to update compositing layers, because we're about
to do layout, which will require us to update them again soon anyway,
and some RenderLayers may not have been sized or positioned yet.

Fix by adding a m_doingPreLayoutStyleUpdate member to FrameView,
and toggling it around this call to updateStyleIfNeeded().
Read this state in updateCompositingLayersAfterStyleChange(), which is
now called unconditionally by recalcStyle(), but returns early
if this flag is set, or layout is pending.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::layout):

  • page/FrameView.h:

(FrameView):

4:54 PM Changeset in webkit [133543] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix build warning in PageClientLegacyImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=101266

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-05
Reviewed by Laszlo Gombos.

The 'size' is not used when !USE(TILED_BACKING_STORE)
Use UNUSED_PARAM macro for removing -Wunused-parameter warning

  • UIProcess/efl/PageClientLegacyImpl.cpp:

(WebKit::PageClientLegacyImpl::updateViewportSize):

4:48 PM Changeset in webkit [133542] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=101275
Clean up ScrollingConstraints.h

Reviewed by Simon Fraser.

This class cleans up ScrollingConstraints.h by removing the constructors since the
compiler will generate those constructors for us anyway. The patch also makes the
two override functions private.

  • page/scrolling/ScrollingConstraints.h:

(ViewportConstraints):
(FixedPositionViewportConstraints):
(StickyPositionViewportConstraints):

4:35 PM Changeset in webkit [133541] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Make Document::updateStyleIfNeeded() non-virtual
https://bugs.webkit.org/show_bug.cgi?id=101273

Reviewed by Eric Seidel.

Document::updateStyleIfNeeded() has been virtual like forever, but
no-one ever overrides it, so make it non-virtual.

  • dom/Document.h:

(Document):

4:23 PM Changeset in webkit [133540] by mark.lam@apple.com
  • 3 edits in trunk/LayoutTests

Fixed flaky fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html.
https://bugs.webkit.org/show_bug.cgi?id=101268.

Reviewed by Geoffrey Garen.

  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html:
4:14 PM Changeset in webkit [133539] by ggaren@apple.com
  • 1 edit
    5 adds in trunk/PerformanceTests

WebKit should have performance tests for book chapter reflow
https://bugs.webkit.org/show_bug.cgi?id=101271

Reviewed by Dan Bernstein.

I grabbed a book chapter from the Project Gutenberg front page:

  • Layout/chapter-reflow-once.html: Added.
  • Layout/chapter-reflow-thrice.html: Added.
  • Layout/chapter-reflow-twice.html: Added.
  • Layout/chapter-reflow.html: Added.

I also created a torture-test random text generator:

  • Layout/chapter-reflow-once-random.html: Added.
4:13 PM Changeset in webkit [133538] by pdr@google.com
  • 6 edits in trunk

Unblock SVG external references
https://bugs.webkit.org/show_bug.cgi?id=100635

Reviewed by Adam Barth.

This patch reverts r132849 and r132869 because the potential XSS issue
turned out to not be an issue after all.

Covered by existing tests, many of which are re-whitelisted with this patch.

Source/WebCore:

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

Source/WTF:

  • wtf/Platform.h:

LayoutTests:

  • platform/chromium/TestExpectations:
3:41 PM Changeset in webkit [133537] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add IRC alias for Glenn Adams
https://bugs.webkit.org/show_bug.cgi?id=101262

Patch by Glenn Adams <glenn@skynav.com> on 2012-11-05
Reviewed by Eric Seidel.

Add IRC alias for Glenn Adams.

  • Scripts/webkitpy/common/config/committers.py:
3:31 PM Changeset in webkit [133536] by Beth Dakin
  • 28 edits
    19 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=101001
Pages with position:fixed elements should still be able to scroll on
the scrolling thread
-and corresponding-
<rdar://problem/10857315>

Reviewed by Simon Fraser.

Source/WebCore:

This patch adds two new classes. ScrollingStateFixedNode is a class
to represent fixed nodes in the state tree, and
ScrollingTreeFixedNode represents fixed node in the scrolling tree
over on the scrolling thread.

  • WebCore.xcodeproj/project.pbxproj:

When we are (non-programatically) scrolling fixed objects on the
scrolling thread, we do not want to do any work here.

  • page/FrameView.cpp:

(WebCore::FrameView::updateFixedElementsAfterScrolling):

Whenever we sync the position of the main frame's layer, we have to
do the same for scrolling tree children.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

New ScrollingNodeType -- FixedNode, yay! And two new functions
specific to dealing with FixedNodes.

  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::updateViewportConstrainedNode):
(WebCore::ScrollingCoordinator::syncChildPositions):

This is the new class that represents fixed nodes in the state tree.
All of the changed properties are stored within
FixedPositionViewportConstraints.

  • page/scrolling/ScrollingStateFixedNode.cpp: Added.

(WebCore):
(WebCore::ScrollingStateFixedNode::create):
(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::~ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::updateConstraints):
(WebCore::ScrollingStateFixedNode::dumpProperties):

  • page/scrolling/ScrollingStateFixedNode.h: Added.

(WebCore):
(ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::viewportConstraints):
(WebCore::toScrollingStateFixedNode):

Make sure to create the right type of clone for each node.

  • page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::cloneAndReset):

Now that m_children may be anything other than null, I found this
bug. We encounter it when the parameter to removeChild is this and we
want to remove all of our children. In that case, this is obviously
not found in its own child array.
(WebCore::ScrollingStateNode::removeChild):

ScrollingStateNode now caches the GraphicsLayer in addition to the
PlatformLayer. This will allow us to sync the GraphicsLayer position
at the appropriate times.

  • page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::isScrollingStateFixedNode):
(WebCore::ScrollingStateNode::graphicsLayer):
(ScrollingStateNode):

Handle fixed nodes.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode):

New function parentScrollPositionDidChange() is called on children
when the parent has scrolled.

  • page/scrolling/ScrollingTreeNode.h:

(ScrollingTreeNode):

  • page/scrolling/ScrollingTreeScrollingNode.h:

(ScrollingTreeScrollingNode):

Return true for supportsFixedPositionLayers().

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollingCoordinatorMac):

Handle fixed nodes.

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::attachToStateTree):

Now that m_children can be non-null I caught this pre-existing bug
where we would come times remove a node without updating the HashMap.
This patch fixes that by consolidating the removal into one function.
(WebCore::ScrollingCoordinatorMac::removeNode):
(WebCore::ScrollingCoordinatorMac::detachFromStateTree):
(WebCore::ScrollingCoordinatorMac::clearStateTree):

Update the GraphicsLayers to reflect the new position that the
Scrolling thread has moved the underlying CALayer to already.
(WebCore::ScrollingCoordinatorMac::syncChildPositions):

Pass new constraints over to the appropriate state node.
(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):

Cache the GraphicsLayer in addition to the PlatformLayer.

  • page/scrolling/mac/ScrollingStateNodeMac.mm:

(WebCore::ScrollingStateNode::setScrollLayer):

Here is the new class that represents fixed nodes over on the
scrolling thread.

  • page/scrolling/mac/ScrollingTreeFixedNode.h: Added.

(WebCore):
(ScrollingTreeFixedNode):

  • page/scrolling/mac/ScrollingTreeFixedNode.mm: Added.

(WebCore):
(WebCore::ScrollingTreeFixedNode::create):
(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):
(WebCore::ScrollingTreeFixedNode::~ScrollingTreeFixedNode):
(WebCore::ScrollingTreeFixedNode::update):

This is where the magic happens. re-position the fixed object when
its parent has scrolled so that it appears to have not moved at all.
(WebCore::ScrollingTreeFixedNode::parentScrollPositionDidChange):

Whenever we change the position of a scrolling layer, tell our
children.

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

Handle fixed nodes.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::attachToScrollingCoordinator):

detachFromScrollingCoordinator() needs to be public so that it can be
called from RenderLayerCompositor for fixed nodes.

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

RenderLayerCompositor takes control of attaching and detaching fixed
nodes to/from the ScrollingCoordinator.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::didFlushChangesForLayer):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::didMoveOnscreen):
(WebCore::RenderLayerCompositor::willMoveOffscreen):
(WebCore::RenderLayerCompositor::clearBackingForLayerIncludingDescendants):
(WebCore::isRootmostFixedOrStickyLayer):
(WebCore):
(WebCore::RenderLayerCompositor::updateViewportConstraintStatus):
(WebCore::RenderLayerCompositor::addViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::removeViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::computeViewportConstraints):
(WebCore::nearestScrollingCoordinatorAncestor):
(WebCore::RenderLayerCompositor::registerOrUpdateViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::unregisterViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
(WebCore::RenderLayerCompositor::unregisterAllViewportConstrainedLayers):

  • rendering/RenderLayerCompositor.h:

(WebCore):
(RenderLayerCompositor):

LayoutTests:

New tests.

  • platform/mac/tiled-drawing/fixed: Added.
  • platform/mac/tiled-drawing/fixed/absolute-inside-fixed-expected.txt: Added.
  • platform/mac/tiled-drawing/fixed/absolute-inside-fixed.html: Added.
  • platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt: Added.
  • platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt: Added.
  • platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html: Added.
  • platform/mac/tiled-drawing/fixed/fixed-position-out-of-view.html: Added.
  • platform/mac/tiled-drawing/fixed/four-bars-expected.txt: Added.
  • platform/mac/tiled-drawing/fixed/four-bars.html: Added.
  • platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt: Added.
  • platform/mac/tiled-drawing/fixed/nested-fixed.html: Added.
  • platform/mac/tiled-drawing/fixed/percentage-inside-fixed-expected.txt: Added.
  • platform/mac/tiled-drawing/fixed/percentage-inside-fixed.html: Added.

These two tests are supposed to be in "slow scrolling" mode. Now that
fixed elements can scroll "fast," we need something else to force
slow scrolling. We should probably just add something to
window.internals to do that, but in the meantime,
background-attachment:fixed will work.

  • platform/mac/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt:
  • platform/mac/tiled-drawing/scrolling-tree-slow-scrolling.html:
  • platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
  • platform/mac/tiled-drawing/tile-coverage-slow-scrolling.html:
3:22 PM Changeset in webkit [133535] by aboxhall@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Mark fonts/cursive.html as flaky on MountainLion as well as Lion.
https://bugs.webkit.org/show_bug.cgi?id=83219

  • platform/chromium/TestExpectations:
3:18 PM Changeset in webkit [133534] by ggaren@apple.com
  • 3 edits in trunk/Source/WebCore

Cleaned up the Font class in preparation for optimizing kerning and ligatures
https://bugs.webkit.org/show_bug.cgi?id=101258

Reviewed by Dan Bernstein.

  • platform/graphics/Font.h:

(WebCore::Font::typesettingFeatures):
(WebCore::Font::computeTypesettingFeatures): Compute and cache our
typesetting features instead of recomputing each time a client asks
for them. This makes the class interface easier to use because
"typesettingFeatures()" can appear in more than one expression without
undue performance cost. This may also be a small speedup to code that
calls typesettingFeatures() often for other reasons.

  • platform/graphics/Font.cpp:

(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::update): Ditto.

(WebCore::Font::width): Unforked the width() function so all width-related
interfaces can benefit from optimization without duplicate code.

3:10 PM Changeset in webkit [133533] by commit-queue@webkit.org
  • 7 edits in trunk

Back out controversial changes from Bug 98665.
https://bugs.webkit.org/show_bug.cgi?id=101244

Patch by Dima Gorbik <dgorbik@apple.com> on 2012-11-05
Reviewed by David Kilzer.

Backing out changes from Bug 98665 until further discussions take place on rules for including Platform.h in Assertions.h.

Source/JavaScriptCore:

  • API/tests/minidom.c:
  • API/tests/testapi.c:

Source/WTF:

  • wtf/Assertions.h:

Tools:

  • DumpRenderTree/mac/MockGeolocationProvider.mm:
3:07 PM Changeset in webkit [133532] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

  • platform/chromium-mac-mountainlion/TestExpectations:
2:56 PM Changeset in webkit [133531] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Webkit does not handle some media keys correctly On Linux gtk platform.
https://bugs.webkit.org/show_bug.cgi?id=101221

Patch by Peng Huang <penghuang@google.com> on 2012-11-05
Reviewed by Alexey Proskuryakov.

Add media keyboard support on Linux gtk platform.

  • platform/chromium/KeyCodeConversionGtk.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

2:52 PM Changeset in webkit [133530] by andersca@apple.com
  • 4 edits
    4 copies in trunk/Source/WebKit2

Begin stubbing out the new remote layer tree drawing area
https://bugs.webkit.org/show_bug.cgi?id=101256

Reviewed by Andreas Kling.

  • Shared/DrawingAreaInfo.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingArea.cpp:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
2:39 PM Changeset in webkit [133529] by commit-queue@webkit.org
  • 10 edits
    70 adds in trunk

Add support to -webkit-line-break property for CSS3 Text line-break property values and semantics.
https://bugs.webkit.org/show_bug.cgi?id=89235

Patch by Glenn Adams <glenn@skynav.com> on 2012-11-05
Reviewed by Eric Seidel.

See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping

Source/WebCore:

Web exposed changes include:
(1) The default (initial) value for -webkit-line-break becomes 'auto', instead of 'normal';
(2) The values 'auto', 'loose', 'normal', and 'strict' are added to -webkit-line-break;
(3) See [2] above for details regarding interpretation.

Tests: css3/line-break/line-break-auto-centered.html

css3/line-break/line-break-auto-half-kana.html
css3/line-break/line-break-auto-hyphens.html
css3/line-break/line-break-auto-inseparables.html
css3/line-break/line-break-auto-iteration-marks.html
css3/line-break/line-break-auto-postfixes.html
css3/line-break/line-break-auto-prefixes.html
css3/line-break/line-break-auto-sound-marks.html
css3/line-break/line-break-loose-centered.html
css3/line-break/line-break-loose-half-kana.html
css3/line-break/line-break-loose-hyphens.html
css3/line-break/line-break-loose-inseparables.html
css3/line-break/line-break-loose-iteration-marks.html
css3/line-break/line-break-loose-postfixes.html
css3/line-break/line-break-loose-prefixes.html
css3/line-break/line-break-loose-sound-marks.html
css3/line-break/line-break-normal-centered.html
css3/line-break/line-break-normal-half-kana.html
css3/line-break/line-break-normal-hyphens.html
css3/line-break/line-break-normal-inseparables.html
css3/line-break/line-break-normal-iteration-marks.html
css3/line-break/line-break-normal-postfixes.html
css3/line-break/line-break-normal-prefixes.html
css3/line-break/line-break-normal-sound-marks.html
css3/line-break/line-break-strict-centered.html
css3/line-break/line-break-strict-half-kana.html
css3/line-break/line-break-strict-hyphens.html
css3/line-break/line-break-strict-inseparables.html
css3/line-break/line-break-strict-iteration-marks.html
css3/line-break/line-break-strict-postfixes.html
css3/line-break/line-break-strict-prefixes.html
css3/line-break/line-break-strict-sound-marks.html

  • platform/text/LineBreakIteratorPoolICU.h:

(WebCore::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
Add static function to construct ICU locale argument (also used as pool key) with additional
break keyword.
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):
Remove direct dependency from ICU library (and types), moving that dependency into
new {open,close}LineBreakIterator() functions (defined in TextBreakIteratorICU.cpp).
Update to take line break mode into account.
Create (and cache) different break iterators depending on line break mode (in addition to locale),
which entails expanding pool entry key format to optionally append "@break=" +
"loose"|"normal"|"strict" keyword to locale string.

  • platform/text/TextBreakIterator.h:

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::isLooseCJKMode):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
Define LineBreakIteratorMode enumeration for use in TextBreakIterator et al.
Add state member to indicate line break mode.

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::acquireLineBreakIterator):
Use new line break mode when making iterator from pool.
Handle change of return type of LineBreakIteratorPool::take() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::releaseLineBreakIterator):
Handle change of parameter type of LineBreakIteratorPool::put() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::isCJKLocale):
New functions for determining if CJK rules apply.
(WebCore::openLineBreakIterator):
New function for abstracting opening of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
This function also takes into account the line break mode.
(WebCore::closeLineBreakIterator):
(WebCore::mapLineIteratorModeToRules):
New function for abstracting closing of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Pass line break iterator mode flag when reseting LazyLineBreakIterator.
Add looseMode local variable to prevent need for computing under isBreakable().

  • rendering/RenderText.cpp:

(WebCore::mapLineBreakToIteratorMode):
Add implementation for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
(WebCore::RenderText::computePreferredLogicalWidths):
Ensure (lazy line) breakIterator is initialized for line break mode.
Ensure isBreakable() is passed loose mode flag to match behavior in RenderBlock::LineBreaker::nextLineBreak.

  • rendering/RenderText.h:

(WebCore):
Add declaration for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.

  • rendering/break_lines.cpp:

(WebCore):
Introduce two (local) enums NBSPBehavior and LooseBehavior for expanding template on nextBreakablePosition
to include loose mode parameter.
(WebCore::isBreakableSpace):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation. Use new loose mode flavors off NBP functions.
(WebCore::needsLineBreakIterator):
Introduce loose mode behavior template parameter to optimize loose mode behavior code path in order
to prevent regression to non loose mode path.
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
Use new template parameter enums described above.
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
(WebCore::nextBreakablePositionLoose):
Introduce two additional 'loose' mode flavors of NBP template expansions.

  • rendering/break_lines.h:

(WebCore):
(WebCore::isBreakable):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation.

LayoutTests:

  • css3/line-break/line-break-auto-centered-expected.html: Added.
  • css3/line-break/line-break-auto-centered.html: Added.
  • css3/line-break/line-break-auto-half-kana-expected.html: Added.
  • css3/line-break/line-break-auto-half-kana.html: Added.
  • css3/line-break/line-break-auto-hyphens-expected.html: Added.
  • css3/line-break/line-break-auto-hyphens.html: Added.
  • css3/line-break/line-break-auto-inseparables-expected.html: Added.
  • css3/line-break/line-break-auto-inseparables.html: Added.
  • css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
  • css3/line-break/line-break-auto-iteration-marks.html: Added.
  • css3/line-break/line-break-auto-postfixes-expected.html: Added.
  • css3/line-break/line-break-auto-postfixes.html: Added.
  • css3/line-break/line-break-auto-prefixes-expected.html: Added.
  • css3/line-break/line-break-auto-prefixes.html: Added.
  • css3/line-break/line-break-auto-sound-marks-expected.html: Added.
  • css3/line-break/line-break-auto-sound-marks.html: Added.
  • css3/line-break/line-break-loose-centered-expected.html: Added.
  • css3/line-break/line-break-loose-centered.html: Added.
  • css3/line-break/line-break-loose-half-kana-expected.html: Added.
  • css3/line-break/line-break-loose-half-kana.html: Added.
  • css3/line-break/line-break-loose-hyphens-expected.html: Added.
  • css3/line-break/line-break-loose-hyphens.html: Added.
  • css3/line-break/line-break-loose-inseparables-expected.html: Added.
  • css3/line-break/line-break-loose-inseparables.html: Added.
  • css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
  • css3/line-break/line-break-loose-iteration-marks.html: Added.
  • css3/line-break/line-break-loose-postfixes-expected.html: Added.
  • css3/line-break/line-break-loose-postfixes.html: Added.
  • css3/line-break/line-break-loose-prefixes-expected.html: Added.
  • css3/line-break/line-break-loose-prefixes.html: Added.
  • css3/line-break/line-break-loose-sound-marks-expected.html: Added.
  • css3/line-break/line-break-loose-sound-marks.html: Added.
  • css3/line-break/line-break-normal-centered-expected.html: Added.
  • css3/line-break/line-break-normal-centered.html: Added.
  • css3/line-break/line-break-normal-half-kana-expected.html: Added.
  • css3/line-break/line-break-normal-half-kana.html: Added.
  • css3/line-break/line-break-normal-hyphens-expected.html: Added.
  • css3/line-break/line-break-normal-hyphens.html: Added.
  • css3/line-break/line-break-normal-inseparables-expected.html: Added.
  • css3/line-break/line-break-normal-inseparables.html: Added.
  • css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
  • css3/line-break/line-break-normal-iteration-marks.html: Added.
  • css3/line-break/line-break-normal-postfixes-expected.html: Added.
  • css3/line-break/line-break-normal-postfixes.html: Added.
  • css3/line-break/line-break-normal-prefixes-expected.html: Added.
  • css3/line-break/line-break-normal-prefixes.html: Added.
  • css3/line-break/line-break-normal-sound-marks-expected.html: Added.
  • css3/line-break/line-break-normal-sound-marks.html: Added.
  • css3/line-break/line-break-strict-centered-expected.html: Added.
  • css3/line-break/line-break-strict-centered.html: Added.
  • css3/line-break/line-break-strict-half-kana-expected.html: Added.
  • css3/line-break/line-break-strict-half-kana.html: Added.
  • css3/line-break/line-break-strict-hyphens-expected.html: Added.
  • css3/line-break/line-break-strict-hyphens.html: Added.
  • css3/line-break/line-break-strict-inseparables-expected.html: Added.
  • css3/line-break/line-break-strict-inseparables.html: Added.
  • css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
  • css3/line-break/line-break-strict-iteration-marks.html: Added.
  • css3/line-break/line-break-strict-postfixes-expected.html: Added.
  • css3/line-break/line-break-strict-postfixes.html: Added.
  • css3/line-break/line-break-strict-prefixes-expected.html: Added.
  • css3/line-break/line-break-strict-prefixes.html: Added.
  • css3/line-break/line-break-strict-sound-marks-expected.html: Added.
  • css3/line-break/line-break-strict-sound-marks.html: Added.
  • platform/chromium/css3/line-break/line-break-auto-half-kana-expected.html: Added.
  • platform/chromium/css3/line-break/line-break-auto-sound-marks-expected.html: Added.

Override reftest expectations on chromium due to different ICU auto behavior.

  • platform/chromium-android/css3/line-break/line-break-auto-half-kana-expected.html: Added.
  • platform/chromium-android/css3/line-break/line-break-auto-sound-marks-expected.html: Added.

Override override of reftest expectations on chromium due to different ICU auto behavior;
that is, chromium-android seems to follow the generic expectations.

2:34 PM Changeset in webkit [133528] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] screenX/Y gives wrong values
https://bugs.webkit.org/show_bug.cgi?id=101259

Reviewed by Yong Li.

PR 237071

Reviewed internally by Gen Mak.

Do not transform screenPos coordinates.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::mouseEvent):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):

2:32 PM Changeset in webkit [133527] by abarth@webkit.org
  • 11 edits in trunk

webkitRegionLayoutUpdate is incorrectly named
https://bugs.webkit.org/show_bug.cgi?id=100335

Reviewed by Ojan Vafai.

Source/WebCore:

DOM event names are supposed to be lower case.

  • dom/EventNames.h:

(WebCore):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Update tests to use the proper name.

  • fast/regions/webkit-named-flow-event-add-to-flow.html:
  • fast/regions/webkit-named-flow-event-no-regions.html:
  • fast/regions/webkit-named-flow-event-remove-from-dom.html:
  • fast/regions/webkit-named-flow-event-remove-from-flow.html:
  • fast/regions/webkit-named-flow-event-target.html:
  • fast/regions/webkit-named-flow-event-to-null.html:
  • fast/regions/webkit-named-flow-event.html:
2:15 PM Changeset in webkit [133526] by abarth@webkit.org
  • 33 edits
    3 deletes in trunk/Source

[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110

Reviewed by Kentaro Hara.

Source/WebCore:

This patch generalizes our support for storing wrappers in DOM objects
to be usable for more than just nodes. After this patch, any object
with a ScriptWrappable base class will have its wrapper stored inline
in the object in the main world.

To achieve this goal, this patch hides the details of how we map from
objects to wrappers inside DOMDataStore and then removes the
IntrusiveDOMWrapperMap class entirely. This approach lets us remove the
DOMWrapperMap base class and make all of these functions non-virtual.

  • UseV8.cmake:
  • WebCore.gypi:
    • Remove deleted files.
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):

  • Rather than grabbing at the DOMWrapperMap directly, we now ask the DOMDataStore to do this work for us.
  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::V8Float64Array::wrap):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::wrap):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::wrap):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::wrap):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::wrap):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::V8TestException::wrap):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::wrap):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::wrap):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::V8TestObj::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::wrap):

  • bindings/v8/DOMDataStore.cpp:
    • Updated run-bindings-test results.

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):

  • Simplify constructor and destructor now that there is only one hash map.

(WebCore::DOMDataStore::current):

  • Now that V8DOMMap.cpp doesn't handle the null isolate case, we need to handle it here.

(WebCore::DOMDataStore::reportMemoryUsage):

  • Simplfied now that there is only one wrapper map.

(WebCore::DOMDataStore::weakCallback):

  • Moved from IntrusiveDOMWrapperMap.h
  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):

  • These functions now handle the intrusive case with a branch rather than with a virtual function call. In many cases, the branch can be optimized away by the compiler when the overloaded inline functions are inlined.

(WebCore::DOMDataStore::wrapperIsStoredInObject):

  • Overloaded functions to determine whether to store the wrapper inside the object or in the hashmap.

(WebCore::DOMDataStore::getWrapperFromObject):
(WebCore::DOMDataStore::storeWrapperInObject):

  • Overloaded functions to get/set the wrapper from inside the object itself.
  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperHashMap::get):
(WebCore::DOMWrapperHashMap::set):
(WebCore::DOMWrapperHashMap::clear):
(WebCore::DOMWrapperHashMap::reportMemoryUsage):
(WebCore::DOMWrapperHashMap::remove):

  • These functions are no longer virtual.
  • bindings/v8/DOMWrapperWorld.h:
  • bindings/v8/IntrusiveDOMWrapperMap.h: Removed.
  • bindings/v8/ScriptProfiler.cpp:
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::neuterBinding):

  • We need to keep the type information slightly longer so that we look in the right wrapper map.
  • bindings/v8/V8DOMMap.cpp: Removed.
  • bindings/v8/V8DOMMap.h: Removed.
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

  • Defer this work to the store.

(WebCore::V8DOMWrapper::setWrapperClass):

  • An overloaded function to set the right wrapper class.

(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):

  • This function is now general enough to handle ever kind of object.
  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/WorkerScriptController.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • Call the more general function (instead of the now-deleted specialized function).

Source/WebKit/chromium:

  • src/WebScriptController.cpp:
    • Remove unneeded include of deleted file.
2:11 PM Changeset in webkit [133525] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Remove fast/forms/week-multiple-fields from
platform/mac/TestExpectations, since it no longer exists and makes the
style script complain. Unreviewed.

  • platform/mac/TestExpectations:
2:07 PM Changeset in webkit [133524] by ap@apple.com
  • 20 edits
    1 delete in trunk

Get rid of setCookieStoragePrivateBrowsingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=101247

Reviewed by Brady Eidson.

We were only doing anything here on Mac, and only because we couldn't know if
sessions were in use. But sessions are always in use, and those obsolete changing
cookie storage explicitly.

  • platform/network/win/CookieStorageWin.cpp: Removed.
  • PlatformWinCE.cmake:
  • WebCore.gypi: No more CookieStorageWin.cpp with an empty implementation.


  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: We no longer need this WKSI function.
  • page/Settings.cpp: (WebCore::Settings::setPrivateBrowsingEnabled): Removed the only call to setCookieStoragePrivateBrowsingEnabled().
  • platform/network/CookieStorage.h:
  • platform/network/cf/CookieStorageCFNet.cpp:
  • platform/network/curl/CookieJarCurl.cpp:
  • platform/network/soup/CookieStorageSoup.cpp:
  • platform/qt/TemporaryLinkStubsQt.cpp: Removed empty setCookieStoragePrivateBrowsingEnabled implementations.
  • platform/network/mac/CookieStorageMac.mm: This function used to have a FIXME that we should observe private storage while in private browsing mode. I don't think that it was correct - Safari doesn't display content of private storage, and thus doesn't need to know about changes. The removal of this function has an effect on WebKit1 clients that enable private browsing. We used to globally change cookie storage, even for loads not initiated by WebKit. Now we match API description: "If private browsing is enabled, WebKit will not store information about sites the user visits."
2:03 PM Changeset in webkit [133523] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Give actual bug IDs to some past gardening. Unreviewed.

  • platform/chromium/TestExpectations:
1:59 PM Changeset in webkit [133522] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not display error page for failed downloads
https://bugs.webkit.org/show_bug.cgi?id=101246

Internal PR: 236318
Internal reviewed by Joe Mason, Leo Yang.
Patch by Lianghui Chen <liachen@rim.com> on 2012-11-05
Reviewed by Rob Buis.

Right now when a main load, including all downloads, failed, it will
display an error page. This is not very user friendly, especially for
WebWorks application, which want to use its own user interface to info
user about the failure.
So we just stop displaying error page for downloads.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

1:51 PM Changeset in webkit [133521] by fmalita@chromium.org
  • 41 edits
    2 adds in trunk

Crash when mixing layers, foreignObjects and SVG hidden containers
https://bugs.webkit.org/show_bug.cgi?id=87297

Reviewed by Dirk Schulze.

Source/WebCore:

Foreign objects may introduce content which requires layers, but layer creation is
suppressed within RenderSVGHiddenContainer subtrees and this yields an inconsistent render
tree state. This patch prevents foreignObject renderer instantiation under
RenderSVGHiddenContainers.

Test: svg/foreignObject/foreign-object-defs-crash.svg

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::rendererIsNeeded):
(WebCore):

  • svg/SVGForeignObjectElement.h:

(SVGForeignObjectElement):

LayoutTests:

  • platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/chromium-win/svg/foreignObject/fO-parent-display-none-expected.txt:
  • platform/chromium-win/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
  • platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/chromium/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/chromium/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/chromium/svg/foreignObject/fO-parent-display-none-expected.txt:
  • platform/chromium/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/chromium/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
  • platform/chromium/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/efl/svg/foreignObject/fO-parent-display-none-expected.txt:
  • platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
  • platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/gtk/svg/foreignObject/fO-parent-display-none-expected.txt:
  • platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
  • platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/mac/svg/foreignObject/fO-parent-display-none-expected.txt:
  • platform/mac/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
  • platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-display-none-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt:
  • platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt:
  • svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
  • svg/foreignObject/foreign-object-defs-crash-expected.txt: Added.
  • svg/foreignObject/foreign-object-defs-crash.svg: Added.
  • svg/foreignObject/text-tref-02-b-expected.txt:
1:43 PM Changeset in webkit [133520] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Remove the unused m_fixedPositionedElements from RenderView
https://bugs.webkit.org/show_bug.cgi?id=101251

Reviewed by Anders Carlsson.

m_fixedPositionedElements was completely unused. Remove it
and the related typedef.

  • rendering/RenderView.h:

(RenderView):

1:38 PM Changeset in webkit [133519] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark several compositing tests as only failing Image
and not Text, after r133513. Unreviewed.

  • platform/chromium/TestExpectations:
1:25 PM Changeset in webkit [133518] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] New compositing/tiling tests fail
https://bugs.webkit.org/show_bug.cgi?id=101166

Unskip now passing tests after r133513.

  • platform/qt-5.0-wk2/TestExpectations:
1:07 PM Changeset in webkit [133517] by Simon Fraser
  • 46 edits in trunk/Source

Fix layer borders to cleaning appear and disappear on switching
https://bugs.webkit.org/show_bug.cgi?id=101136

Source/WebCore:

Reviewed by Sam Weinig.

GraphicsLayers decided whether to show layer borders based
on a callback through the GraphicsLayerClient. This made it
hard to manage state, resulting in a failure to cleanly
hide layers when toggled off via the preference.

Changed the layer border and repaint counter visibility to be bits
stored on GraphicsLayer just like other properties, with getters
and setters. RenderLayerBacking now updates these debug
indicators when we update other compositing layer properties.

In GraphicsLayerCA, avoid calling updateDebugIndicators() explicitly
in several places by setting the change flag DebugIndicatorsChanged
for properties whose values affect the appearance of the debug border.

Removed the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter() which are no longer required.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::updateDebugIndicators):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setShowDebugBorder):
(WebCore::GraphicsLayer::isShowingDebugBorder):
(WebCore::GraphicsLayer::setShowRepaintCounter):
(WebCore::GraphicsLayer::isShowingRepaintCounter):
(WebCore::GraphicsLayer::repaintCount):
(WebCore::GraphicsLayer::incrementRepaintCount):

  • platform/graphics/GraphicsLayerClient.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setMasksToBounds):
(WebCore::GraphicsLayerCA::setDrawsContent):
(WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateMasksToBounds):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateDebugBorder):
(WebCore::GraphicsLayerCA::setShowDebugBorder):
(WebCore::GraphicsLayerCA::setShowRepaintCounter):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::setupContentsLayer):
(WebCore::GraphicsLayerCA::cloneLayer):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):
(WebCore::GraphicsLayerCA::platformCALayerShowDebugBorders):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDebugIndicators):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

Source/WebKit/blackberry:

Reviewed by Sam Weinig.

Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().

  • Api/WebOverlay_p.h:

(WebOverlayPrivateWebKitThread):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):

  • Api/WebPage_p.h:
  • WebKitSupport/DefaultTapHighlight.cpp:
  • WebKitSupport/DefaultTapHighlight.h:

(DefaultTapHighlight):

  • WebKitSupport/InspectorOverlayBlackBerry.cpp:
  • WebKitSupport/InspectorOverlayBlackBerry.h:

(InspectorOverlay):

  • WebKitSupport/SelectionOverlay.cpp:
  • WebKitSupport/SelectionOverlay.h:

(SelectionOverlay):

Source/WebKit/chromium:

Reviewed by Sam Weinig.

Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().

  • src/NonCompositedContentHost.cpp:
  • src/NonCompositedContentHost.h:

(NonCompositedContentHost):

  • src/PageOverlay.cpp:
  • tests/GraphicsLayerChromiumTest.cpp:
  • tests/ImageLayerChromiumTest.cpp:

Source/WebKit/gtk:

Reviewed by Sam Weinig.

Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().

  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext):

  • WebCoreSupport/AcceleratedCompositingContextCairo.cpp:
  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

Source/WebKit/win:

Reviewed by Sam Weinig.

Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().

  • WebView.cpp:
  • WebView.h:

Source/WebKit2:

Reviewed by Sam Weinig.

Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
  • WebProcess/WebPage/ca/LayerTreeHostCA.h:

(LayerTreeHostCA):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

(LayerTreeHostGtk):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
12:49 PM Changeset in webkit [133516] by jamesr@google.com
  • 3 edits in trunk/Source

[chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas
https://bugs.webkit.org/show_bug.cgi?id=101016

Reviewed by Adrienne Walker.

Passing SkBitmap by value requires including SkBitmap.h, which is tricky for some clients to do since it
requires having the rest of skia's headers on the include path and setting up the correct config to set
preprocessor defines. Also shuffles the parameter order around to make rolling easier since you can't override
just by const ref-ness.

  • chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::setFontAtlas):

12:40 PM Changeset in webkit [133515] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Input date should not popup dialog when readonly is set
https://bugs.webkit.org/show_bug.cgi?id=101234

Reviewed by Yong Li.

PR 236114

Reviewed internally by Mike Fenton.

Suppress popup dialog if the input element has readonly attribute set.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::openColorPopup):

12:36 PM Changeset in webkit [133514] by fischman@chromium.org
  • 3 edits in branches/chromium/1312/Source/WebCore

Merge 133262 - Build fix. http://trac.webkit.org/changeset/133252 broke the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=101008

Reviewed by fischman@chromium.org.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::clearMediaPlayer):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

TBR=roger_fong@apple.com
Review URL: https://codereview.chromium.org/11368088

12:36 PM Changeset in webkit [133513] by Simon Fraser
  • 3 edits in trunk/LayoutTests

[Qt][WK2] New compositing/tiling tests fail
https://bugs.webkit.org/show_bug.cgi?id=101166

The platform-independent results should not contain visibleRect, since this is
only dumped on Mac.

  • compositing/tiling/rotated-tiled-clamped-expected.txt:
  • compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
12:34 PM Changeset in webkit [133512] by fischman@chromium.org
  • 4 edits
    1 copy in branches/chromium/1312

Merge 133252 - HTMLMediaPlayer should free m_player when src is set/changed
https://bugs.webkit.org/show_bug.cgi?id=99647

Reviewed by Eric Carlson.

.:

  • ManualTests/media-players-are-dropped-on-error.html: Added.

Various scenarios are tested to make sure players aren't
leaked in different ways for each of them.

Source/WebCore:

New ManualTest added; manual since leaking media players doesn't have layoutTestController-visible effects.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute): clearMediaPlayer() when src is set/changed
(WebCore::HTMLMediaElement::userCancelledLoad): use new clearMediaPlayer() helper
(WebCore::HTMLMediaElement::clearMediaPlayer): clear m_player and associated timers/flags
(WebCore):
(WebCore::HTMLMediaElement::createMediaPlayer): whitespace-only change

  • html/HTMLMediaElement.h: new method: createMediaPlayer().

(HTMLMediaElement):

TBR=fischman@chromium.org
Review URL: https://codereview.chromium.org/11275156

12:28 PM Changeset in webkit [133511] by Simon Fraser
  • 13 edits in trunk/LayoutTests

Rebaseline some Lion results that were affected by enabling subpixel layout.

  • platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/mac-lion/fast/text/international/hindi-spacing-expected.txt:
  • platform/mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/mac-lion/fast/writing-mode/vertical-font-fallback-expected.txt:
11:47 AM Changeset in webkit [133510] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: lint, clean up rebaseline.py
https://bugs.webkit.org/show_bug.cgi?id=101240

Reviewed by Ojan Vafai.

Miscellaneous cleanup of lint errors and warnings.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand):
(RebaselineTest._test_root):
(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AnalyzeBaselines.init):
(AbstractParallelRebaselineCommand):
(AbstractParallelRebaselineCommand._builders_to_fetch_from):
(AbstractParallelRebaselineCommand._files_to_add):
(AbstractParallelRebaselineCommand._rebaseline):
(RebaselineExpectations.init):
(Rebaseline.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(_BaseTestCase.setUp):
(TestAnalyzeBaselines.setUp):

11:28 AM Changeset in webkit [133509] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkit-patch optimize-baselines should take a --platform arg
https://bugs.webkit.org/show_bug.cgi?id=97623

Reviewed by Ojan Vafai.

So that we can optionally limit/control which platforms' results
are affected.

This patch adds --platform to analyze-baselines as well.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(_baseline_search_hypergraph):
(BaselineOptimizer.init):

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(TestBaselineOptimizer.init):
(BaselineOptimizerTest.test_move_baselines):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(OptimizeBaselines.init):
(OptimizeBaselines.execute):
(AnalyzeBaselines.init):
(AnalyzeBaselines.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestAnalyzeBaselines.test_default):
(TestAnalyzeBaselines.test_missing_baselines):

11:26 AM Changeset in webkit [133508] by dpranke@chromium.org
  • 4 edits
    1 add in trunk/Tools

webkit-patch rebaseline-expectations should take a --platform arg
https://bugs.webkit.org/show_bug.cgi?id=97621

Reviewed by Ojan Vafai.

So that we can limit which platforms we attempt to rebaseline;
this can reduce the noise the command produces if some ports
have errors or warnings in their TestExpectations files and/or
help produce more predictable results.

In testing this patch, I realized that the rebaseline-in-parallel
commands (rebaseline-json, rebaseline-expectations, etc.) can
cause multiple rebaseline-test-internal commands to attempt to
modify the TestExpectations files concurrently, and that we needed
to lock the files to prevent corruption; it would be nice if
we can split the updating-the-expectations-files out separately
from updating the filesystem (much like we do with the scm updates)
to avoid this concurrency.

  • Scripts/webkitpy/common/system/file_lock_mock.py: Added.

(MockFileLock):
(MockFileLock.init):
(MockFileLock.acquire_lock):
(MockFileLock.release_lock):

  • Scripts/webkitpy/common/system/systemhost.py:

(SystemHost.copy_current_environment):
(SystemHost):
(SystemHost.make_file_lock):

  • Scripts/webkitpy/common/system/systemhost_mock.py:

(MockSystemHost.copy_current_environment):
(MockSystemHost):
(MockSystemHost.make_file_lock):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._update_expectations_file):
(RebaselineExpectations.init):
(RebaselineExpectations._add_tests_to_rebaseline_for_port):
(RebaselineExpectations.execute):

11:24 AM Changeset in webkit [133507] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkitpy: clean up options for specifying multiple platforms at once
https://bugs.webkit.org/show_bug.cgi?id=101140

Reviewed by Ojan Vafai.

This patch reworks how we display the help strings for --platform
options and how we filter out platforms matching a glob. This will
be useful as I add patches to ensure that all the webkit-patch
commands are using --platform consistently to filter ports.

There should be no functional changes resulting from this patch.

  • Scripts/webkitpy/layout_tests/port/factory.py:

(platform_options):
(PortFactory.all_port_names):
(PortFactory.get_from_builder_name):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintExpectations.init):
(PrintBaselines.init):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand):
(RebaselineJson.init):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineExpectations.setUp):
(TestRebaselineExpectations.test_rebaseline_expectations):

11:21 AM Changeset in webkit [133506] by peter@chromium.org
  • 2 edits in trunk/Tools

The layout test runner shouldn't wait for data if stdout/stderr have been closed
https://bugs.webkit.org/show_bug.cgi?id=101233

Reviewed by Dirk Pranke.

Trying to read the file descriptor for the stdout or stderr pipes when DumpRenderTree
has crashed during a Chromium Android layout test-run, which uses FIFOs for
communication, causes the File.fileno() method to raise a ValueError. Return early
if either of the pipes has already been closed.

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._wait_for_data_and_update_buffers_using_select):

11:17 AM Changeset in webkit [133505] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkit-patch rebaseline is broken
https://bugs.webkit.org/show_bug.cgi?id=101235

Reviewed by Ojan Vafai.

It didn't get updated to handle the change in parsing --suffixes
properly, and the unit test didn't get updated either, masking the
problem.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(Rebaseline._tests_to_update):
(Rebaseline.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline):

11:12 AM Changeset in webkit [133504] by dpranke@chromium.org
  • 5 edits in trunk/Tools

lint-webkitpy doesn't autoinstall pylint properly.
https://bugs.webkit.org/show_bug.cgi?id=101106

Reviewed by Ojan Vafai.

Re-land r133381 with fix; ironically, lint-webkitpy would've
complained about the problem. Also modify pylintrc and clean up
any other lint errors in the modified files.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._set_up_target_dir):
(AutoInstaller):
(AutoInstaller._make_package):
(AutoInstaller._create_scratch_directory):
(AutoInstaller._install):
(AutoInstaller.install):

  • Scripts/webkitpy/pylintrc:
  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
(AutoinstallImportHook):
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install_webpagereplay):
(AutoinstallImportHook._install):

  • Scripts/webkitpy/thirdparty/init_unittest.py:

(ThirdpartyTest.test_import_hook.MockImportHook.init):
(ThirdpartyTest.test_import_hook):
(ThirdpartyTest.test_imports):

11:10 AM Changeset in webkit [133503] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

Expose hit test related methods in public chromium port
https://bugs.webkit.org/show_bug.cgi?id=101204

Patch by Bo Liu <boliu@chromium.org> on 2012-11-05
Reviewed by Adam Barth.

The methods are needed in implementating hit test related methods in the
Android WebView API.

The specific methods are:
[Web]HitTestResult::urlElement
[Web]HitTestResult::absoluteImageURL
[Web]HitTestResult::absoluteLinkURL
[Web]HitTestResult::isContentEditable
WebViewImpl::hitTestResultAt

  • public/WebHitTestResult.h:

(WebKit):
(WebHitTestResult):

  • public/WebView.h:

(WebKit):
(WebView):

  • src/WebHitTestResult.cpp:

(WebKit::WebHitTestResult::urlElement):
(WebKit):
(WebKit::WebHitTestResult::absoluteImageURL):
(WebKit::WebHitTestResult::absoluteLinkURL):
(WebKit::WebHitTestResult::isContentEditable):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::hitTestResultAt):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

11:09 AM Changeset in webkit [133502] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[BLACKBERRY] Update touch code to reflect touch refactor
https://bugs.webkit.org/show_bug.cgi?id=101227

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-05
Reviewed by Rob Buis.

PR #2706785
Reviewed Internally by: Mike Lattanzio

Source/WebCore:

  • platform/blackberry/PlatformTouchEventBlackBerry.cpp:

(WebCore::touchEventType):
(WebCore::PlatformTouchEvent::PlatformTouchEvent):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):

11:08 AM Changeset in webkit [133501] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark css3/filters/custom/custom-filter-animation.html
as timing out intermittently. Unreviewed.

  • platform/chromium/TestExpectations:
10:59 AM Changeset in webkit [133500] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebCore

Merged r125353. <rdar://problem/12536410>

10:56 AM Changeset in webkit [133499] by alokp@chromium.org
  • 12 edits in trunk/Source

[chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents
https://bugs.webkit.org/show_bug.cgi?id=99083

Reviewed by Stephen White.

Use LCD text setting passed to WebContentLayerClient::paintContents instead of turning it off for all composited layers.

Source/Platform:

  • chromium/public/WebContentLayerClient.h:

(WebContentLayerClient):
(WebKit::WebContentLayerClient::paintContents):

Source/WebCore:

No new tests needed. This patch does not change anything functionally.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::paint):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:

(OpaqueRectTrackingContentLayerDelegate):

Source/WebKit/chromium:

  • src/LinkHighlight.cpp:

(WebKit::LinkHighlight::paintContents):

  • src/LinkHighlight.h:

(LinkHighlight):

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit::NonCompositedContentHost::paintContents):

  • src/NonCompositedContentHost.h:

(NonCompositedContentHost):

  • tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:

(WebCore::TEST_F):

10:55 AM WebKit Team edited by aboxhall@chromium.org
Add aboxhall and dmazzoni to the Committers list (already in committers.py) (diff)
10:51 AM Changeset in webkit [133498] by Lucas Forschler
  • 10 edits
    2 copies in branches/safari-536.28-branch

Merged r125351. <rdar://problem/12536410>

10:51 AM Changeset in webkit [133497] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Build fix after http://trac.webkit.org/changeset/133488.
Removed a deleted file. Unreviewed.

  • WebCore.gypi:
10:42 AM WebKit Team edited by robert@roberthogan.net
(diff)
10:41 AM Changeset in webkit [133496] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] toV8(impl) should return null if impl is 0
https://bugs.webkit.org/show_bug.cgi?id=101206

Reviewed by Adam Barth.

toV8(impl) should return null if impl is 0. However,
V8HTMLCollection::toV8() does not have the null check.
All other toV8()s return null.

No tests. I think there will be no call path that hits the change.

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::toV8):

10:18 AM Changeset in webkit [133495] by alokp@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
10:17 AM Changeset in webkit [133494] by Dave Barton
  • 4 edits in trunk

Implement SimpleFontData::platformBoundsForGlyph on skia
https://bugs.webkit.org/show_bug.cgi?id=101115

Reviewed by Eric Seidel.

Source/WebCore:

The implementation is similar to SimpleFontData::platformWidthForGlyph on skia.

Tested by: fast/block/lineboxcontain/*glyphs*, mathml/presentation/*

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph): Implemented.

LayoutTests:

Some lineboxcontain/etc. tests will need rebaselining.

  • platform/chromium/TestExpectations:
10:15 AM Changeset in webkit [133493] by fpizlo@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Reduce the verbosity of referring to QNaN in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=101174

Reviewed by Geoffrey Garen.

Introduces a #define QNaN in JSValue.h, and replaces all previous uses of
std::numeric_limits<double>::quiet_NaN() with QNaN.

  • API/JSValueRef.cpp:

(JSValueMakeNumber):
(JSValueToNumber):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitFloatTypedArrayGetByVal):

  • runtime/CachedTranscendentalFunction.h:

(JSC::CachedTranscendentalFunction::initialize):

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • runtime/DateInstanceCache.h:

(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):

  • runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):

  • runtime/JSCell.h:

(JSC::JSValue::getPrimitiveNumber):

  • runtime/JSDateMath.cpp:

(JSC::parseDateFromNullTerminatedCharacters):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::toDouble):
(JSC::jsToNumber):
(JSC::parseFloat):

  • runtime/JSValue.cpp:

(JSC::JSValue::toNumberSlowCase):

  • runtime/JSValue.h:

(JSC):

  • runtime/JSValueInlineMethods.h:

(JSC::jsNaN):

  • runtime/MathObject.cpp:

(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):

10:06 AM Changeset in webkit [133492] by kling@webkit.org
  • 7 edits in trunk/Source/WebCore

Decouple Attr logic from ElementAttributeData.
<http://webkit.org/b/101126>

Reviewed by Antti Koivisto.

Move all logic dealing with Attr DOM nodes from ElementAttributeData to Element.
This makes more sense since an Attr is tied to a single Element, but an ElementAttributeData
can be shared by any number of Elements at a given time.

Also updated naming convention from just "Attr" to "Attr node" in the code I was touching.
"Attr" is way too generic, and has been historically confused with WebCore::Attribute a lot.

  • dom/Element.h:
  • dom/ElementAttributeData.h:
  • dom/Element.cpp:

(WebCore::attrNodeListMap):
(WebCore::attrNodeListForElement):
(WebCore::ensureAttrNodeListForElement):
(WebCore::removeAttrNodeListForElement):
(WebCore::findAttrNodeInList):
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
(WebCore::Element::detachAttrNodeFromElementWithValue):
(WebCore::Element::detachAllAttrNodesFromElement):
(WebCore::Element::cloneAttributesFromElement):

Move everything Attr-related into Element.cpp while simplifying some loops and remove
conditions that are no longer needed as they used to depend on having an attributeData().

  • dom/Node.h:

(WebCore::Node::hasSyntheticAttrChildNodes):
(WebCore::Node::setHasSyntheticAttrChildNodes):

Renamed the hasAttrList() node flag to hasSyntheticAttrChildNodes().

  • dom/Attr.cpp:

(WebCore::Attr::detachFromElementWithValue):

Remove awkward indirection and let the call site deal with removing the Attr node from
the Element's list of Attr nodes.

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::clearAttributes):

Remove now-unused Element* argument.

10:01 AM Changeset in webkit [133491] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip a now passing test.

  • platform/qt-5.0-wk1/TestExpectations:
9:53 AM Changeset in webkit [133490] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

[CSS Exclusions] Polygon edges should span colinear vertices
https://bugs.webkit.org/show_bug.cgi?id=99343

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-05
Reviewed by Dirk Schulze.

Source/WebCore:

ExclusionPolygonEdges now span coincident and collinear vertices. Currently
pairs of vertices are only considered coincident if their coordinates are exactly
equal. Similarly, a vertex is only considered collinear with an edge if the area
of the triangle defined by the three vertices is exactly zero. In the future it
may be useful to relax the comparison with zero.

Tests: fast/exclusions/shape-inside/shape-inside-coincident-vertices.html

fast/exclusions/shape-inside/shape-inside-collinear-vertices.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::determinant): Used to measure collinearity.
(WebCore):
(WebCore::areCollinearPoints): True if three FloatPoint arguments are collinear per the test outlined above.
(WebCore::areCoincidentPoints): True if the two FloatPoint arguments are equal.
(WebCore::nextVertexIndex): The next vertex index in clockwise or counterclockwise order.
(WebCore::ExclusionPolygon::findNextEdgeVertexIndex): Return the index of the next non-coincident, non-collinear vertex.
(WebCore::ExclusionPolygon::ExclusionPolygon): Skip coincident and collinear vertices when building the list of edges.

  • rendering/ExclusionPolygon.h: Added private findNextEdgeVertexIndex() declaration.

LayoutTests:

Verify that exclusion polygonal shape-inside layout is unaffected by coincident
or collinear vertices.

  • fast/exclusions/shape-inside/shape-inside-coincident-vertices-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-coincident-vertices.html: Added.
  • fast/exclusions/shape-inside/shape-inside-collinear-vertices-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-collinear-vertices.html: Added.
9:37 AM Changeset in webkit [133489] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebCore

Merged r125315. <rdar://problem/12536439>

9:33 AM Changeset in webkit [133488] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebCore

[EFL] Use POSIX implementation of SharedBuffer::createWithContentsOfFile()
https://bugs.webkit.org/show_bug.cgi?id=101228

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Get rid of EFL-specific implementation of SharedBuffer::createWithContentsOfFile()
and reuse the POSIX one since it is pretty much the same.

No new tests, no behavior change.

  • PlatformEfl.cmake:
  • platform/efl/SharedBufferEfl.cpp: Removed.
9:25 AM Changeset in webkit [133487] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

  • platform/qt/TestExpectations:
9:22 AM Changeset in webkit [133486] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark inspector-protocol/debugger-pause-dedicated-worker.html
as also crashy, and give it a bug ID. Unreviewed.

  • platform/chromium/TestExpectations:
8:57 AM Changeset in webkit [133485] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.28-branch

Merged r125237. <rdar://problem/12536461>

8:48 AM Changeset in webkit [133484] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.28-branch

Merged r125234. <rdar://problem/12536433>

8:32 AM Changeset in webkit [133483] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Add a comment about a return value of IDBKey::toV8()
https://bugs.webkit.org/show_bug.cgi?id=101212

Reviewed by Adam Barth.

Although all other toV8(impl) return null when impl is 0,
IDBKey::toV8(impl) is expected to return undefined when impl is 0.
This patch adds a comment about it.

No tests.

  • bindings/js/JSIDBKeyCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

8:23 AM Changeset in webkit [133482] by dominik.rottsches@intel.com
  • 6 edits
    6 adds in trunk

[Cairo] Make Cairo honor image orientation
https://bugs.webkit.org/show_bug.cgi?id=101207

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Implement transformed image drawing in BitmapImageCairo, similar
as it was done for Skia in bug 100179, r132384.
The image drawing code needs to transform the graphics context
depending on exif orientation in order for this to work.

No new tests, covered by fast/images/exif-* which are passing now.

  • platform/graphics/BitmapImage.h: Enable draw function which respects image orientation for Cairo.
  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw): Apply ImageOrientation's transformFromDefault() transformation to context.
(WebCore):

LayoutTests:

Unskip and rebaseline exif orientation tests for EFL.

  • platform/efl-wk1/TestExpectations: Tests not passing here yet, since DRT needs a setShouldRespectImageOrientation setting.
  • platform/efl/TestExpectations: Unskipping three exif orientation tests.
  • platform/efl/fast/images/exif-orientation-css-expected.png: Added.
  • platform/efl/fast/images/exif-orientation-css-expected.txt: Added.
  • platform/efl/fast/images/exif-orientation-expected.png: Added.
  • platform/efl/fast/images/exif-orientation-expected.txt: Added.
  • platform/efl/fast/images/exif-orientation-image-document-expected.png: Added.
  • platform/efl/fast/images/exif-orientation-image-document-expected.txt: Added.
8:20 AM Changeset in webkit [133481] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r125176. <rdar://problem/12516381>

8:16 AM Changeset in webkit [133480] by Lucas Forschler
  • 5 edits
    4 copies in branches/safari-536.28-branch

Merged r125162. <rdar://problem/12536458>

8:14 AM Changeset in webkit [133479] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

[V8] Dispose() and Clear() should be always coupled for safety
https://bugs.webkit.org/show_bug.cgi?id=101191

Reviewed by Adam Barth.

Clear() is not mandatory. However, to avoid misusing already
disposed wrappers, Clear() should be always called just
after Dispose().

No tests. No change in behavior.

  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperHashMap::defaultWeakCallback):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::IntrusiveDOMWrapperMap::weakCallback):

  • bindings/v8/NPV8Object.cpp:

(WebCore::freeV8NPObject):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::~ScheduledAction):

  • bindings/v8/V8NPObject.cpp:

(WebCore::V8NPTemplateMap::dispose):
(WebCore::weakNPObjectCallback):
(WebCore::forgetV8ObjectForNPObject):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::dispose):

  • bindings/v8/V8ValueCache.cpp:

(WebCore::cachedStringCallback):
(WebCore::IntegerCache::~IntegerCache):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::WeakReferenceCallback):

7:56 AM Changeset in webkit [133478] by Lucas Forschler
  • 11 edits
    2 copies in branches/safari-536.28-branch

Merged r125147. <rdar://problem/12536499>

7:42 AM Changeset in webkit [133477] by kpiascik@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Web Inspector: Add InspectorInstrumentaiton calls for timeline compositing.
https://bugs.webkit.org/show_bug.cgi?id=101213
RIM PR 178131

Reviewed by Rob Buis.

Internally Reviewed by Arvid Nilsson.

Added compositing events to the timeline for BlackBerry.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::willComposite):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::didComposite):

  • Api/WebPage_p.h:

(WebPagePrivate):

7:29 AM Changeset in webkit [133476] by Lucas Forschler
  • 12 edits in branches/safari-536.28-branch/Source

Merged r125091. <rdar://problem/12486152>

7:25 AM Changeset in webkit [133475] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[CSS Exclusions] Layout of the first shape-inside line can be incorrect
https://bugs.webkit.org/show_bug.cgi?id=100996

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-05
Reviewed by Dirk Schulze.

Source/WebCore:

Made the conversion from floating point top/bottom logical shape bounds coordinates
LayoutUnits explicit and corrected the case where the top value was truncated. A
float logicalTop value is converted to LayoutUnit with fromFloatCeil() to ensure
that the LayoutUnit value is within the shape.

Test: fast/exclusions/shape-inside/shape-inside-shape-logical-top.html

  • rendering/ExclusionShapeInsideInfo.h:

(WebCore::ExclusionShapeInsideInfo::shapeLogicalTop): Redefined this method in terms of shapeLogicalBoundsY,Max().
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBottom): Ditto.
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds): Ditto.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBoundsY): Explicit conversion from floating point shape coordinates to LayoutUnits.
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBoundsMaxY): Ditto.

LayoutTests:

Verify that the first line of shape-inside content is laid out correctly
when the top of the shape's bounds has a non-integral value.

  • fast/exclusions/shape-inside/shape-inside-shape-logical-top-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-shape-logical-top.html: Added.
7:20 AM Changeset in webkit [133474] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-536.28-branch

Merged r125052. <rdar://problem/12536419>

7:17 AM Changeset in webkit [133473] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark a flaky test. Unreviewed.

  • platform/chromium/TestExpectations:
7:14 AM Changeset in webkit [133472] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebCore

Merged r124924. <rdar://problem/12516358>

7:08 AM Changeset in webkit [133471] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Add a now-failing test, remove a now-passing test. Unreviewed.

  • platform/chromium/TestExpectations:
7:06 AM Changeset in webkit [133470] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebCore

Merged r124919. <rdar://problem/12516354>

7:02 AM Changeset in webkit [133469] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Protect against resource deletion during iteration in MemoryCache::pruneDeadResourcesToSize
https://bugs.webkit.org/show_bug.cgi?id=101211

Reviewed by Andreas Kling.

Some crashes have been seen under MemoryCache::pruneDeadResourcesToSize. A possible cause is that
destroyDecodedData() call ends up evicting the resource pointed by 'previous' pointer during iteration
and deleting the object. This looks in principle possible via stylesheets and SVG images.

Speculative fix, no repro, no obvious way to construct a test.

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::pruneDeadResourcesToSize):

Use CachedResourceHandle to protect the 'previous' pointer during iteration. Check if the
resource has been kicked out from the cache during destroyDecodedData() and stop iterating
if has (as it may die when CachedResourceHandle releases it).
The 'current' pointer is not protected as the resource it points to is allowed to die.

6:58 AM Changeset in webkit [133468] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.28-branch

Merged r124914. <rdar://problem/12536456>

6:49 AM Changeset in webkit [133467] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.28-branch

Merged r124888. <rdar://problem/12536408>

6:41 AM Changeset in webkit [133466] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.28-branch

Merged r124843. <rdar://problem/12536452>

6:27 AM Changeset in webkit [133465] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=101199

Patch by Miguel Garcia <miguelg@chromium.org> on 2012-11-05
Reviewed by Julien Chaffraix.

Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
actually wired up internally. Disable the feature to avoid breaking feature detection
until we can implement it properly.

  • features.gypi:
6:22 AM Changeset in webkit [133464] by commit-queue@webkit.org
  • 8 edits
    2 moves
    4 adds in trunk/Source/WebKit2

[EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS
https://bugs.webkit.org/show_bug.cgi?id=100674

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Make a distinction between calling ewk_view_base_add and ewk_view_smart_add.
Calling ewk_view_base_add creates a desktop style view, that does not support
fixed layout size, while calling ewk_view_smart_add does support fixed layout size.
As a result, WebKitTestRunner and the inspector window do not support
fixed layout size, while MiniBrowser does. This change allows many DumpAsText
layout tests to pass without modification, when AC is enabled.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::informLoadCommitted):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::informContentsSizeChange):

  • UIProcess/API/efl/EwkViewImpl.h:

(WebKit):
(EwkViewImpl):
(EwkViewImpl::pageClient):
(EwkViewImpl::setScaleFactor):
(EwkViewImpl::scaleFactor):
(EwkViewImpl::setScrollPosition):
(EwkViewImpl::scrollPosition):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_calculate):
(createEwkView):
(ewk_view_base_add):

  • UIProcess/efl/PageClientBase.cpp: Copied from Source/WebKit2/UIProcess/efl/PageClientImpl.cpp.

(WebKit::PageClientBase::PageClientBase):
(WebKit::PageClientBase::~PageClientBase):
(WebKit::PageClientBase::viewImpl):
(WebKit::PageClientBase::createDrawingAreaProxy):
(WebKit::PageClientBase::setViewNeedsDisplay):
(WebKit::PageClientBase::displayView):
(WebKit::PageClientBase::scrollView):
(WebKit::PageClientBase::viewSize):
(WebKit::PageClientBase::isViewWindowActive):
(WebKit::PageClientBase::isViewFocused):
(WebKit::PageClientBase::isViewVisible):
(WebKit::PageClientBase::isViewInWindow):
(WebKit::PageClientBase::processDidCrash):
(WebKit::PageClientBase::didRelaunchProcess):
(WebKit::PageClientBase::pageClosed):
(WebKit::PageClientBase::toolTipChanged):
(WebKit::PageClientBase::setCursor):
(WebKit::PageClientBase::setCursorHiddenUntilMouseMoves):
(WebKit::PageClientBase::registerEditCommand):
(WebKit::PageClientBase::clearAllEditCommands):
(WebKit::PageClientBase::canUndoRedo):
(WebKit::PageClientBase::executeUndoRedo):
(WebKit::PageClientBase::convertToDeviceSpace):
(WebKit::PageClientBase::convertToUserSpace):
(WebKit::PageClientBase::screenToWindow):
(WebKit::PageClientBase::windowToScreen):
(WebKit::PageClientBase::doneWithKeyEvent):
(WebKit::PageClientBase::doneWithTouchEvent):
(WebKit::PageClientBase::createPopupMenuProxy):
(WebKit::PageClientBase::createContextMenuProxy):
(WebKit::PageClientBase::createColorChooserProxy):
(WebKit::PageClientBase::setFindIndicator):
(WebKit::PageClientBase::enterAcceleratedCompositingMode):
(WebKit::PageClientBase::exitAcceleratedCompositingMode):
(WebKit::PageClientBase::updateAcceleratedCompositingMode):
(WebKit::PageClientBase::didChangeScrollbarsForMainFrame):
(WebKit::PageClientBase::didCommitLoadForMainFrame):
(WebKit::PageClientBase::didFinishLoadingDataForCustomRepresentation):
(WebKit::PageClientBase::customRepresentationZoomFactor):
(WebKit::PageClientBase::setCustomRepresentationZoomFactor):
(WebKit::PageClientBase::flashBackingStoreUpdates):
(WebKit::PageClientBase::findStringInCustomRepresentation):
(WebKit::PageClientBase::countStringMatchesInCustomRepresentation):
(WebKit::PageClientBase::updateTextInputState):
(WebKit::PageClientBase::handleDownloadRequest):

  • UIProcess/efl/PageClientBase.h: Copied from Source/WebKit2/UIProcess/efl/PageClientImpl.h.

(PageClientBase):

  • UIProcess/efl/PageClientDefaultImpl.cpp: Added.

(WebKit):
(WebKit::PageClientDefaultImpl::PageClientDefaultImpl):
(WebKit::PageClientDefaultImpl::didCommitLoad):
(WebKit::PageClientDefaultImpl::updateViewportSize):
(WebKit::PageClientDefaultImpl::didChangeViewportProperties):
(WebKit::PageClientDefaultImpl::didChangeContentsSize):
(WebKit::PageClientDefaultImpl::pageDidRequestScroll):
(WebKit::PageClientDefaultImpl::didRenderFrame):
(WebKit::PageClientDefaultImpl::pageTransitionViewportReady):

  • UIProcess/efl/PageClientDefaultImpl.h: Added.

(WebKit):
(PageClientDefaultImpl):
(WebKit::PageClientDefaultImpl::create):
(WebKit::PageClientDefaultImpl::~PageClientDefaultImpl):

  • UIProcess/efl/PageClientImpl.cpp: Removed.
  • UIProcess/efl/PageClientImpl.h: Removed.
  • UIProcess/efl/PageClientLegacyImpl.cpp: Added.

(WebKit):
(WebKit::PageClientLegacyImpl::PageClientLegacyImpl):
(WebKit::PageClientLegacyImpl::didCommitLoad):
(WebKit::PageClientLegacyImpl::updateViewportSize):
(WebKit::PageClientLegacyImpl::didChangeViewportProperties):
(WebKit::PageClientLegacyImpl::didChangeContentsSize):
(WebKit::PageClientLegacyImpl::pageDidRequestScroll):
(WebKit::PageClientLegacyImpl::didRenderFrame):
(WebKit::PageClientLegacyImpl::pageTransitionViewportReady):

  • UIProcess/efl/PageClientLegacyImpl.h: Added.

(WebKit):
(PageClientLegacyImpl):
(WebKit::PageClientLegacyImpl::create):
(WebKit::PageClientLegacyImpl::~PageClientLegacyImpl):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setContentsScale):

  • UIProcess/efl/PageViewportControllerClientEfl.h:
  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::viewWidget):

6:15 AM Changeset in webkit [133463] by commit-queue@webkit.org
  • 54 edits in trunk/Source/WebCore

Web Inspector: Fix jscompiler cast syntax
https://bugs.webkit.org/show_bug.cgi?id=101066

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-05
Reviewed by Pavel Feldman.

Casts should be in the form of "/ @type {TypeName} */ (expr)" instead of "/ @type {TypeName} */ expr".

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/front-end/ApplicationCacheModel.js:

(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):

  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView.prototype._onRequestStarted):
(WebInspector.AuditLauncherView.prototype._onRequestFinished):

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype._uiSourceCodeFormatted):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.Breakpoint.prototype._locationUpdated):
(WebInspector.BreakpointManager.Storage):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):

  • inspector/front-end/CSSNamedFlowCollectionsView.js:

(WebInspector.CSSNamedFlowCollectionsView.prototype._documentUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._namedFlowCreated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._regionLayoutUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._selectedNodeChanged):

  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSProfileHeader.prototype.createView):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.LiveLocation.prototype.uiLocation):
(WebInspector.CSSStyleDeclaration.parseComputedStylePayload):

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._frameAdded):
(WebInspector.ConsoleView.prototype._frameRemoved):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMDocument):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointByURL):
(WebInspector.DebuggerModel.prototype.):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.CallFrame.prototype.get location):

  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping.prototype._parsedScriptSource):

  • inspector/front-end/DirectoryContentView.js:

(WebInspector.DirectoryContentView.prototype._sort):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._updateBreadcrumbIfNeeded):

  • inspector/front-end/ElementsPanelDescriptor.js:

(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):

  • inspector/front-end/ElementsTreeOutline.js:

(.get node):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype._notifyUISourceCodeContentCommitted):
(WebInspector.ExtensionServer.prototype._notifyRequestFinished):

  • inspector/front-end/FileContentView.js:

(WebInspector.FileContentView.prototype._metadataReceived):
(WebInspector.FileContentView.FileContentProvider.prototype.requestContent):

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype._frameAdded):
(WebInspector.FileSystemModel.prototype._frameNavigated):
(WebInspector.FileSystemModel.prototype._frameDetached):

  • inspector/front-end/FileSystemView.js:

(WebInspector.FileSystemView.EntryTreeElement.prototype.onselect):
(WebInspector.FileSystemView.EntryTreeElement.prototype.refresh):

  • inspector/front-end/HandlerRegistry.js:

(WebInspector.HandlerRegistry.prototype._appendHrefItems):

  • inspector/front-end/HeapSnapshotLoader.js:

(WebInspector.HeapSnapshotLoader.prototype.write):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._changeBase):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._snapshotReceived):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype._frameNavigated):
(WebInspector.IndexedDBModel.prototype._frameDetached):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDataView.prototype._keyColumnHeaderFragment):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._handleGutterClick):
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype.show):

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype._uiSourceCodeTitleChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyCommitted):
(WebInspector.NavigatorView.prototype._uiSourceCodeFormattedChanged):

  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog.prototype._onRequestStarted):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._onRequestUpdated):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):
(WebInspector.NetworkPanel.prototype.reveal):
(WebInspector.NetworkPanel.prototype.appendApplicableItems):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):

  • inspector/front-end/ObjectPopoverHelper.js:

(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):

  • inspector/front-end/PresentationConsoleMessageHelper.js:

(WebInspector.PresentationConsoleMessageHelper.prototype._consoleMessageAdded):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._onRequestFinished):
(WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._databaseAdded):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBLoaded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemAdded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemTreeElementByName):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):

  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView.prototype._uiSourceCodeRemoved):

  • inspector/front-end/SASSSourceMapping.js:

(rawLocationToUILocation):

  • inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

  • inspector/front-end/Script.js:

(WebInspector.Script.Location.prototype.uiLocation):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype.get _worker):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
(WebInspector.ScriptsPanel.prototype.canSearchAndReplace):
(WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
(WebInspector.ScriptsPanel.prototype.replaceAllWith):
(WebInspector.ScriptsPanel.prototype._toggleBreakpoint):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):

  • inspector/front-end/ScriptsPanelDescriptor.js:

(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._scrollChanged):
(WebInspector.TabbedEditorContainer.prototype._selectionChanged):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._tabSelected):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeTitleChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyCommitted):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeFormattedChanged):

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModelLoader.prototype.write):

  • inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):

  • inspector/front-end/Workspace.js:

(WebInspector.WorkspaceController.prototype._frameAdded):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):

6:09 AM Changeset in webkit [133462] by pierre.rossi@gmail.com
  • 2 edits in trunk/LayoutTests

[Qt] Fix broken comment in WK2 TestExpectations

Unreviewed fix, just an obviously missing '#' character.

  • platform/qt-5.0-wk2/TestExpectations:
6:08 AM Changeset in webkit [133461] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

fast/events/popup-allowed-from-gesture-initiated-event.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101208

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Close the new popup between each test to make sure the new window
does not mask the buttons and therefore prevent them from being
clicked. This addresses flakiness for this test.

  • fast/events/popup-allowed-from-gesture-initiated-event.html:
5:43 AM Changeset in webkit [133460] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: render message bubbles in CodeMirror experiment.
https://bugs.webkit.org/show_bug.cgi?id=101164

Reviewed by Vsevolod Vlasov.

It sounds like addLineWidget just makes it happen.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.addDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.get if):
(WebInspector.CodeMirrorTextEditor.prototype.removeDecoration):
(WebInspector.CodeMirrorTextEditor.prototype._change):

  • inspector/front-end/DefaultTextEditor.js:

(.preventDefaultOnMouseUp):

  • inspector/front-end/PresentationConsoleMessageHelper.js:

(WebInspector.PresentationConsoleMessageHelper):

  • inspector/front-end/cm/cmdevtools.css:

(.CodeMirror .webkit-html-message-bubble):
(.CodeMirror .webkit-html-message-bubble img):
(.CodeMirror .webkit-html-warning-message):
(.CodeMirror .webkit-html-error-message):

5:05 AM Changeset in webkit [133459] by zandobersek@gmail.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening.

A followup to r133453, adding a baseline for http/tests/inspector/console-websocket-error.html.

  • platform/gtk/http/tests/inspector: Added.
  • platform/gtk/http/tests/inspector/console-websocket-error-expected.txt: Added.
4:47 AM Changeset in webkit [133458] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Validate CSS Device Adaptation properties and resolve shorthands
https://bugs.webkit.org/show_bug.cgi?id=95962

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-05
Reviewed by Alexis Menard.

Source/WebCore:

Add the missing keywords and properties for the viewport at-rule.
Note that we have to mark that we are inside a viewport scope because
some properties are not validated as they would be inside a style
rule. As an example, the semantics of CSSPropertyWidth are completely
different: on a viewport rule, it stands for a shorthand for the
minimum and maximum width.

Test: css3/device-adapt/viewport-properties-validation.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore):
(WebCore::CSSParser::parseViewportProperty):
(WebCore::CSSParser::parseViewportShorthand):

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:

LayoutTests:

Added a test for CSS Device Adaptation property parsing validation.

  • css3/device-adapt/viewport-properties-validation-expected.txt: Added.
  • css3/device-adapt/viewport-properties-validation.html: Added.
4:39 AM Changeset in webkit [133457] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebKit2

[EFL][WK2] Make Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data Ewk_Objects
https://bugs.webkit.org/show_bug.cgi?id=101205

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-05
Reviewed by Gyuyoung Kim.

Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data are using common Ewk_Object interface now.

  • UIProcess/API/efl/EwkViewImpl.h:
  • UIProcess/API/efl/ewk_download_job.cpp:

(Ewk_Download_Job::request):
(Ewk_Download_Job::response):
(Ewk_Download_Job::setResponse):

  • UIProcess/API/efl/ewk_download_job_private.h:

(Ewk_Download_Job):

  • UIProcess/API/efl/ewk_navigation_data.cpp:

(EwkNavigationData::EwkNavigationData):
(EwkNavigationData::originalRequest):
(EwkNavigationData::title):
(EwkNavigationData::url):
(ewk_navigation_data_title_get):
(ewk_navigation_data_original_request_get):
(ewk_navigation_data_url_get):

  • UIProcess/API/efl/ewk_navigation_data.h:
  • UIProcess/API/efl/ewk_navigation_data_private.h:

(EwkNavigationData):
(EwkNavigationData::create):

  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(Ewk_Navigation_Policy_Decision::Ewk_Navigation_Policy_Decision):
(Ewk_Navigation_Policy_Decision::request):

  • UIProcess/API/efl/ewk_navigation_policy_decision_private.h:

(Ewk_Navigation_Policy_Decision::create):
(Ewk_Navigation_Policy_Decision):

  • UIProcess/API/efl/ewk_url_request.cpp:

(EwkUrlRequest::EwkUrlRequest):
(EwkUrlRequest::url):
(EwkUrlRequest::firstParty):
(EwkUrlRequest::httpMethod):
(ewk_url_request_url_get):
(ewk_request_cookies_first_party_get):
(ewk_url_request_http_method_get):

  • UIProcess/API/efl/ewk_url_request.h:
  • UIProcess/API/efl/ewk_url_request_private.h:

(EwkUrlRequest):
(EwkUrlRequest::create):

  • UIProcess/API/efl/ewk_url_response.cpp:

(EwkUrlResponse::EwkUrlResponse):
(EwkUrlResponse::httpStatusCode):
(EwkUrlResponse::url):
(EwkUrlResponse::mimeType):
(EwkUrlResponse::contentLength):
(ewk_url_response_url_get):
(ewk_url_response_status_code_get):
(ewk_url_response_mime_type_get):
(ewk_url_response_content_length_get):

  • UIProcess/API/efl/ewk_url_response.h:
  • UIProcess/API/efl/ewk_url_response_private.h:

(EwkUrlResponse):
(EwkUrlResponse::create):

  • UIProcess/efl/ContextHistoryClientEfl.cpp:

(WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::didReceiveResponse):

  • UIProcess/efl/ResourceLoadClientEfl.cpp:

(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):

4:23 AM Changeset in webkit [133456] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Remove a few tests which depend on setIsolatedWorldSecurityOrigin
since they are already skipped in efl/TestExpectations.

  • platform/efl-wk2/TestExpectations:
4:14 AM Changeset in webkit [133455] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2UnitTestBase.ewk_auth_request_cancel API test is failing after r133389
https://bugs.webkit.org/show_bug.cgi?id=101203

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Attempt for continue without credential when the client cancels
authentication (or does not handle the authentication request)
instead of cancelling the load. We now get a 402 error when
when cancelling the authentication, which is the behavior we
want (and the behavior we used to have before r133389).

  • UIProcess/API/efl/ewk_auth_request.cpp:

(Ewk_Auth_Request::~Ewk_Auth_Request):
(Ewk_Auth_Request::continueWithoutCredential):
(ewk_auth_request_cancel):

  • UIProcess/API/efl/ewk_auth_request_private.h:

(Ewk_Auth_Request):

  • UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:

(TEST_F):

3:50 AM Changeset in webkit [133454] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] fast/forms/week-multiple-fields does not exist and should be removed from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=101202

Unreviewed EFL gardening.

Remove fast/forms/week-multiple-fields from TestExpections since it does
not exist and makes the style script complain.

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05

  • platform/efl/TestExpectations:
3:43 AM Changeset in webkit [133453] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Clean up the inspector-related test expectations. Instead of marking
many tests as skipped, proper failure expectations are put in place.
The tests are still being skipped as their current behavior on the
buildbots is unknown.

  • platform/gtk/TestExpectations:
2:57 AM Changeset in webkit [133452] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Fix build warning in EWebLauncher/main.c
https://bugs.webkit.org/show_bug.cgi?id=101197

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-05
Reviewed by Kentaro Hara.

Because the strp of _Ecore_Getopt_Value is char (Ecore_Getopt.h),
The parameter of ECORE_GETOPT_VALUE_STR should be char*

  • EWebLauncher/main.c:

(_User_Arguments):

2:47 AM Changeset in webkit [133451] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r133286, r133385, and r133394.
http://trac.webkit.org/changeset/133286
http://trac.webkit.org/changeset/133385
http://trac.webkit.org/changeset/133394
https://bugs.webkit.org/show_bug.cgi?id=101198

Broke image placement on some web sites. (Requested by kling
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-05

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::canShareStyleWithElement):

  • dom/Attr.cpp:

(WebCore::Attr::detachFromElementWithValue):

  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
(WebCore::Element::cloneAttributesFromElement):

  • dom/Element.h:

(Element):
(WebCore::Element::updateInvalidAttributes):

  • dom/ElementAttributeData.cpp:

(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore):
(WebCore::attrListMap):
(WebCore::attrListForElement):
(WebCore::ensureAttrListForElement):
(WebCore::removeAttrListForElement):
(WebCore::findAttrInList):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::reportMemoryUsage):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::getAttributeNode):

  • dom/ElementAttributeData.h:

(WebCore):
(WebCore::ElementAttributeData::attributeStyle):
(WebCore::ElementAttributeData::setAttributeStyle):
(ElementAttributeData):
(WebCore::ElementAttributeData::ElementAttributeData):

  • dom/Node.h:

(WebCore):
(WebCore::Node::hasAttrList):
(WebCore::Node::attributeStyleDirty):
(WebCore::Node::setAttributeStyleDirty):
(WebCore::Node::clearAttributeStyleDirty):
(Node):
(WebCore::Node::setHasAttrList):
(WebCore::Node::clearHasAttrList):
(WebCore::Node::isStyleAttributeValid):
(WebCore::Node::setIsStyleAttributeValid):
(WebCore::Node::clearIsStyleAttributeValid):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::updateAttributeStyle):

  • dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::attributeStyle):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

2:36 AM EFLWebKitCodingStyle edited by gyuyoung.kim@samsung.com
Remove . at the end of @ field. (diff)
2:34 AM Changeset in webkit [133450] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Add --window-size command line option to EFL MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=100942

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Added window-size (-s) command line option to EFL MiniBrowser.

  • MiniBrowser/efl/main.c:

(window_create):
(parse_window_size):
(elm_main):

2:25 AM Changeset in webkit [133449] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skip fast/dom/shadow/shadowroot-type.html because SHADOW_DOM is disabled.

  • platform/qt/TestExpectations:
2:12 AM Changeset in webkit [133448] by Simon Hausmann
  • 2 edits in trunk

[Qt] Trivial unreviewed: Add missing module dependencies for builds in Qt CI system.

These fields aren't used by anyone except some perl scripts in the Qt CI builds.

  • Source/sync.profile:
2:12 AM Changeset in webkit [133447] by Simon Hausmann
  • 3 edits in trunk/Source/WebCore

Unreviewed trivial Qt build fix.

Surround imports from QtGui by QT_{BEGIN,END}_NAMESPACE to fix namespaced
builds.

  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/ImageQt.cpp:
1:53 AM Changeset in webkit [133446] by zandobersek@gmail.com
  • 22 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining MathML tests after r132264 and r133221 and updating
pixel baselines with outdated hash.

  • platform/gtk/TestExpectations:
  • platform/gtk/mathml/presentation/attributes-expected.png:
  • platform/gtk/mathml/presentation/fenced-expected.png:
  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.png:
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/mo-stretch-expected.png:
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
  • platform/gtk/mathml/presentation/mroot-pref-width-expected.png:
  • platform/gtk/mathml/presentation/over-expected.png:
  • platform/gtk/mathml/presentation/over-expected.txt:
  • platform/gtk/mathml/presentation/roots-expected.png:
  • platform/gtk/mathml/presentation/row-alignment-expected.png:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.png:
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.png:
  • platform/gtk/mathml/presentation/subsup-expected.png:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
  • platform/gtk/mathml/presentation/tables-expected.png:
  • platform/gtk/mathml/presentation/tables-expected.txt:
1:33 AM Changeset in webkit [133445] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Skip compositing/repaint/invalidations-on-composited-layers.html
https://bugs.webkit.org/show_bug.cgi?id=101181

Unreviewed EFL gardening.

Mark compositing/repaint/invalidations-on-composited-layers.html as
expected to fail since accelerated compositing is disabled by default
on EFL port.

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05

  • platform/efl/TestExpectations:
1:23 AM Changeset in webkit [133444] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Skipping ENABLE_SUBPIXEL- and ENABLE_INPUT_TYPE_*-related testing
directories. These features are not enabled yet and most of the
tests fail.

Removing failure expectation for fast/files/workers/worker-apply-blob-url-to-xhr.html,
the issue was fixed in r132973.

Moving the skip entry for css3/device-adapt to the proper section.

  • platform/gtk/TestExpectations:
1:05 AM Changeset in webkit [133443] by shinyak@chromium.org
  • 6 edits
    2 adds in trunk

[Shadow] ShadowRoot type is not set correctly.
https://bugs.webkit.org/show_bug.cgi?id=101188

Reviewed by Hajime Morita.

Source/WebCore:

ShadowRoot type is not set correctly in Release build. We have had to remove #ifndef block.

Test: fast/dom/shadow/shadowroot-type.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

  • testing/Internals.cpp:

(WebCore::Internals::shadowRootType):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

  • fast/dom/shadow/shadowroot-type-expected.txt: Added.
  • fast/dom/shadow/shadowroot-type.html: Added.
12:55 AM Changeset in webkit [133442] by commit-queue@webkit.org
  • 9 edits in trunk

[EFL][WK2] The icon database path should be set by the client
https://bugs.webkit.org/show_bug.cgi?id=101182

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

No longer set the favicon database path in database instance getter.
Instead, a new ewk_context_favicon_database_directory_set() API
function was added to let the client set the icon database path.
This is needed because the icon database path can only be set once
and setting it unconditionally in the getter prevents the client
from setting it.

This will also avoid crashes in WebKitTestRunner since WKTR was
setting the path once and ewk_context was attempting to override it.

Note that the favicon database functionality is disabled until the
client sets its path.

  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::ensureFaviconDatabase):
(Ewk_Context::setFaviconDatabaseDirectoryPath):
(Ewk_Context::faviconDatabase):
(ewk_context_favicon_database_directory_set):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_private.h:

(Ewk_Context):

  • UIProcess/API/efl/ewk_favicon_database.cpp:

(Ewk_Favicon_Database::Ewk_Favicon_Database):
(Ewk_Favicon_Database::~Ewk_Favicon_Database):
(Ewk_Favicon_Database::iconURLForPageURL):
(Ewk_Favicon_Database::iconForPageURL):
(Ewk_Favicon_Database::getIconSurfaceSynchronously):

  • UIProcess/API/efl/ewk_favicon_database_private.h:

(WebKit):
(Ewk_Favicon_Database::create):
(Ewk_Favicon_Database):

  • UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:

(TEST_F):

Tools:

Enable favicon database functionality in MiniBrowser since
it is used and it is no longer enabled by default.

  • MiniBrowser/efl/main.c:

(elm_main):

12:22 AM Changeset in webkit [133441] by tkent@chromium.org
  • 6 edits in trunk/Source/WebCore

BaseChooserOnlyDateAndTimeInputType should implement DateTimeChooserClient
https://bugs.webkit.org/show_bug.cgi?id=101038

Reviewed by Hajime Morita.

Add DateTimeChooserClient behavior to BaseChooserOnlyDateAndTimeInputType.
It means that date/time input elements without
ENABLE_INPUT_MULTIPLE_FIELDS_UI can open date/time choosers by
DOMActivate event.

This patch doesn't change behavior yet because Chromimum-Android port
intercepts user events and doesn't deliver them to date/time input
elements. <http://crbug.com/159381>

  • html/BaseChooserOnlyDateAndTimeInputType.cpp:

Add DateTimeChooserClient behavior. The code is similar to
PickerIndicatorElement.
(WebCore::BaseChooserOnlyDateAndTimeInputType::~BaseChooserOnlyDateAndTimeInputType):
Closes DateTimeChooser.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
Open DateTimeChooser if

  • The element is not disabled,
  • The element is not read-only,
  • The element has a renderer,
  • This event is created by a user gesture, and
  • The element has no DateTimeChooser.

(WebCore::BaseChooserOnlyDateAndTimeInputType::detach):
Closes DateTimeChooser.
(WebCore::BaseChooserOnlyDateAndTimeInputType::didChooseValue):
Set a string value coming from a chooser to the input element.
(WebCore::BaseChooserOnlyDateAndTimeInputType::didEndChooser):
Clear m_dateTimeChooser when the chooser was closed.
(WebCore::BaseChooserOnlyDateAndTimeInputType::closeDateTimeChooser):
Requests to close the chooser.

  • html/BaseChooserOnlyDateAndTimeInputType.h:

(BaseChooserOnlyDateAndTimeInputType):

  • Implement DateTimeChooserClient
  • Add closeDateTimeChooser helper function.
  • Add detach override.
  • Add m_dateTimeChooser.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setupDateTimeChooserParameters):
Added. The code is moved from PickerIndicatorElement.cpp in order to
share it with BaseChooserOnlyDateAndTimeInputType.

  • html/HTMLInputElement.h:

(HTMLInputElement): Declare setupDateTimeChooserParameters.

  • html/shadow/PickerIndicatorElement.cpp:

(WebCore::PickerIndicatorElement::openPopup):
Move some code to HTMLInputElement::setupDateTimeChooserParameters.

12:04 AM Changeset in webkit [133440] by tkent@chromium.org
  • 2 edits
    135 moves
    16 adds in trunk/LayoutTests

2012-11-04 Kent Tamura <tkent@chromium.org>

Move *-multiple-fields-appearance-*.html from fast/forms/*-multiple-fields/ to fast/forms/*/
https://bugs.webkit.org/show_bug.cgi?id=101186

Rubber-stamped by Kentaro Hara.

The fast/forms/{date,month,time,week}-multiple-fields/
{date,month,time,week}-multiple-fields-appearance-*.html tests don't
depend on the multiple-fields UI, and should work for non
multiple-fields configuration too. They should be moved to
fast/forms/{date,month,time,week}/.

  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html: Removed.
  • fast/forms/date/date-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.txt.
  • fast/forms/date/date-appearance-basic.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic.html.
  • fast/forms/date/date-appearance-l10n-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.txt.
  • fast/forms/date/date-appearance-l10n.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n.html.
  • fast/forms/date/date-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.txt.
  • fast/forms/date/date-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html.
  • fast/forms/date/date-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt.
  • fast/forms/date/date-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html.
  • fast/forms/date/date-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.txt.
  • fast/forms/date/date-appearance-style.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html: Removed.
  • fast/forms/month/month-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.txt.
  • fast/forms/month/month-appearance-basic.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html.
  • fast/forms/month/month-appearance-l10n-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.txt.
  • fast/forms/month/month-appearance-l10n.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html.
  • fast/forms/month/month-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.txt.
  • fast/forms/month/month-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html.
  • fast/forms/month/month-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt.
  • fast/forms/month/month-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html.
  • fast/forms/month/month-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.txt.
  • fast/forms/month/month-appearance-style.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: Removed.
  • fast/forms/time/time-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt.
  • fast/forms/time/time-appearance-basic.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html.
  • fast/forms/time/time-appearance-disabled-readonly-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt.
  • fast/forms/time/time-appearance-disabled-readonly.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html.
  • fast/forms/time/time-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt.
  • fast/forms/time/time-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html.
  • fast/forms/time/time-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt.
  • fast/forms/time/time-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html.
  • fast/forms/time/time-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt.
  • fast/forms/time/time-appearance-style.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html: Removed.
  • fast/forms/week/week-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt.
  • fast/forms/week/week-appearance-basic.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html.
  • fast/forms/week/week-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.txt.
  • fast/forms/week/week-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html.
  • fast/forms/week/week-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt.
  • fast/forms/week/week-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html.
  • fast/forms/week/week-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.txt.
  • fast/forms/week/week-appearance-style.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
  • platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
  • platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
  • platform/chromium-linux/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
  • platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
  • platform/chromium-linux/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
  • platform/chromium-linux/fast/forms/month: Added.
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-linux/fast/forms/mon